gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
   4         Rename from tui_display_reg_element_at_line.
   5         (tui_data_window::display_registers_from_line): Update.
   6         * tui/tui-data.h (struct tui_data_window)
   7         <display_reg_element_at_line>: New method.
   8
   9 2019-07-17  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-regs.h (tui_display_registers_from)
  12         (tui_display_registers_from_line): Don't declare.
  13         * tui/tui-windata.c (tui_data_window::display_all_data)
  14         (tui_data_window::refresh_all)
  15         (tui_data_window::do_scroll_vertical): Update.
  16         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  17         from tui_display_registers_from.
  18         (tui_display_reg_element_at_line): Update.
  19         (tui_data_window::display_registers_from_line): Rename from
  20         tui_display_registers_from_line.
  21         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  22         display_registers_from_line>: New methods.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  27         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  28         from tui_erase_data_content.
  29         (tui_data_window::display_all_data)
  30         (tui_data_window::refresh_all)
  31         (tui_data_window::do_scroll_vertical): Update.
  32         * tui/tui-regs.c (tui_show_registers): Update.
  33         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  34         New method.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  39         declare.
  40         * tui/tui-windata.c
  41         (tui_data_window::delete_data_content_windows): Rename from
  42         tui_delete_data_content_windows.
  43         (tui_data_window::display_all_data)
  44         (tui_data_window::do_scroll_vertical): Update.
  45         * tui/tui-data.h (struct tui_data_window)
  46         <delete_data_content_windows>: New method.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  51         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  56         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  57         from tui_display_all_data.
  58         * tui/tui-win.c
  59         (tui_data_window::do_make_visible_with_new_height): Update.
  60         * tui/tui-regs.c (tui_show_registers): Update.
  61         * tui/tui-layout.c (tui_set_layout): Update.
  62         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  63         method.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  68         * tui/tui-windata.c (tui_display_data_from): Remove.
  69         (tui_data_window::refresh_all): Update.
  70
  71 2019-07-17  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  74         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  75         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  76         tui_display_registers_from_line.
  77         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  78         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  79         "force_display" parameter.
  80
  81 2019-07-17  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  84         declare.
  85         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  86         Rename from tui_first_reg_element_no_inline.
  87         (tui_display_reg_element_at_line)
  88         (tui_display_registers_from_line): Update.
  89         * tui/tui-data.h (struct tui_data_window)
  90         <first_reg_element_no_inline>: New method.
  91
  92 2019-07-17  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-windata.c (tui_display_data_from)
  95         (tui_data_window::do_scroll_vertical): Update.
  96         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  97         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  98         Rename from tui_line_from_reg_element_no.
  99         (tui_display_registers_from_line): Update.
 100         * tui/tui-data.h (struct tui_data_window)
 101         <line_from_reg_element_no>: New method.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 106         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 107         tui_last_regs_line_no.
 108         (tui_display_reg_element_at_line)
 109         (tui_display_registers_from_line): Update.
 110         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 111         method.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         PR tui/24722:
 116         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 117         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 118         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 119         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 120         (tui_update_breakpoint_info): Likewise.
 121         * tui/tui-hooks.c (tui_event_create_breakpoint)
 122         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 123         Update.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.c (tui_update_source_window_as_is)
 132         (tui_update_source_windows_with_addr): Update.
 133         * tui/tui-source.h (tui_set_source_content)
 134         (tui_show_symtab_source): Add "win_info" parameter.
 135         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 136         parameter.
 137         (tui_show_symtab_source): Likewise.
 138
 139 2019-07-17  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c
 142         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 147         (struct tui_cmd_window) <can_scroll>: New method.
 148         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 149         method.
 150
 151 2019-07-17  Tom Tromey  <tromey@adacore.com>
 152
 153         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 154         do_field_signed>: Rename.  Change type of "value".
 155         * ui-out.c (ui_out::field_signed): Rename from field_int.
 156         Change type of "value".
 157         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 158         type of "value".
 159         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 160         do_field_int.  Change type of "value".
 161         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 162         do_field_int.  Change type of "value".
 163         * tracepoint.c (trace_status_mi, tfind_1)
 164         (print_one_static_tracepoint_marker): Update.
 165         * thread.c (print_thread_info_1, print_selected_thread_frame):
 166         Update.
 167         * stack.c (print_frame, print_frame_info): Update.
 168         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 169         Update.
 170         * source.c (print_source_lines_base): Update.
 171         * skip.c (info_skip_command): Update.
 172         * record-btrace.c (btrace_ui_out_decode_error)
 173         (btrace_call_history_src_line): Update.
 174         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 175         Update.
 176         * progspace.c (print_program_space): Update.
 177         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 178         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 179         do_field_int.  Change type of "value".
 180         * mi/mi-out.c (mi_ui_out::do_table_begin)
 181         (mi_ui_out::do_table_header): Update.
 182         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 183         type of "value".
 184         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 185         (mi_cmd_data_list_changed_registers, output_register)
 186         (mi_cmd_data_read_memory, mi_load_progress)
 187         (mi_cmd_trace_frame_collected): Update.
 188         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 189         Update.
 190         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 191         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 192         (mi_cmd_var_list_children, varobj_update_one): Update.
 193         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 194         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 195         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 196         * inferior.c (print_inferior): Update.
 197         * gdb_bfd.c (print_one_bfd): Update.
 198         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 199         Update.
 200         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 201         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 202         do_field_int.  Change type of "value".
 203         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 204         do_field_int.  Change type of "value".
 205         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 206         (print_one_breakpoint_location, print_it_catch_fork)
 207         (print_one_catch_fork, print_it_catch_vfork)
 208         (print_one_catch_vfork, print_it_catch_solib)
 209         (print_it_catch_exec, print_it_ranged_breakpoint)
 210         (print_mention_watchpoint, print_mention_masked_watchpoint)
 211         (bkpt_print_it, update_static_tracepoint): Update.
 212         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 213         * break-catch-syscall.c (print_it_catch_syscall): Update.
 214         * ada-tasks.c (print_ada_task_info): Update.
 215         * ada-lang.c (print_it_exception, print_mention_exception):
 216         Update.
 217
 218 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         PR breakpoints/24541
 221         * gdbarch.c: Regenerate.
 222         * gdbarch.h: Regenerate.
 223         * gdbarch.sh: Adjust return type and parameter types for
 224         'stap_adjust_register'.
 225         (i386_stap_adjust_register): Adjust signature and return new
 226         register name.
 227         * stap-probe.c (stap_parse_register_operand): Adjust use of
 228         'gdbarch_stap_adjust_register'.
 229
 230 2019-07-17  Tom Tromey  <tromey@adacore.com>
 231
 232         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 233         declare VEC.
 234         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 235         std::vector.
 236         (struct s390_process_info): Add initializers.
 237         (s390_add_process): Use new.
 238         (s390_linux_nat_target::low_forget_process): Use delete.
 239         (s390_linux_nat_target::low_new_fork)
 240         (s390_linux_nat_target::stopped_by_watchpoint)
 241         (s390_linux_nat_target::low_prepare_to_resume)
 242         (s390_linux_nat_target::insert_watchpoint)
 243         (s390_linux_nat_target::insert_hw_breakpoint)
 244         (s390_linux_nat_target::remove_watchpoint)
 245         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 246
 247 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * aarch64-fbsd-nat.c: Include regcache.h.
 250         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 251         argument.
 252         (aarch64_fbsd_nat_target::fetch_registers)
 253         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 254         variable.
 255         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 256
 257 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * fbsd-nat.c: Include gdbarch.h.
 260
 261 2019-07-15  Tom Tromey  <tromey@adacore.com>
 262
 263         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 264
 265 2019-07-15  Tom Tromey  <tromey@adacore.com>
 266
 267         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 268         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 269         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 270         * cli-out.c (cli_ui_out::do_field_int): New method.
 271         * ui-out.c (ui_out::field_unsigned): New method.
 272         * symfile.c (generic_load): Use field_unsigned.
 273         (print_transfer_performance): Likewise.
 274         * record-btrace.c (ui_out_field_uint): Remove.
 275         (btrace_call_history_insn_range, btrace_call_history): Use
 276         field_unsigned.
 277         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 278         field_unsigned.
 279         * ui-out.h (class ui_out) <field_unsigned>: New method.
 280         <do_field_unsigned>: Likewise.
 281
 282 2019-07-15  Tom Tromey  <tromey@adacore.com>
 283
 284         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 285         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 286         * target.c (flash_erase_command): Use field_string.
 287         * infrun.c (print_signal_received_reason): Use field_string.
 288         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 289         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 290         field_string.
 291         * ada-tasks.c (print_ada_task_info): Use field_string.
 292
 293 2019-07-15  Tom Tromey  <tromey@adacore.com>
 294
 295         * target.c (flash_erase_command): Use field_core_addr.
 296         * symfile.c (generic_load): Use field_core_addr.
 297         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 298         Use field_core_addr.
 299         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 300         field_core_addr.
 301
 302 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 303
 304         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 305         value if its desired type is smaller than a CORE_ADDR and signed.
 306
 307 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 310         of changes to field names, and use new is_reference field to
 311         decide if a property is a reference or not.
 312         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 313         field.
 314         (struct dwarf2_property_baton): Update header comment, rename
 315         'referenced_type' to 'property_type' and update comments.
 316         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 317         default property type, store in property baton, update to take
 318         accound of renamed field.
 319         (read_func_scope): Update call to attr_to_dynamic_prop.
 320         (read_array_type): Likewise.
 321         (dwarf2_per_cu_addr_sized_int_type): New function.
 322         (read_subrange_index_type): Move type finding code to
 323         dwarf2_per_cu_addr_sized_int_type.
 324         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 325         (dwarf2_per_cu_addr_type): New function.
 326         (set_die_type): Update calls to attr_to_dynamic_prop.
 327
 328 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * dwarf2read.c (read_subrange_index_type): New function.
 331         (read_subrange_type): Move code into new function and call it.
 332         * gdbtypes.c (create_range_type): Add some asserts.
 333
 334 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 337         update return statements.
 338         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 339         declaration, and update comment to match.
 340         * gdbtypes.c (resolve_dynamic_array): Update call to
 341         dwarf2_evaluate_property to match new return type.
 342
 343 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * valarith.c (value_subscripted_rvalue): Change lowerbound
 346         parameter type from int to LONGEST.
 347         * value.h (value_subscripted_rvalue): Likewise in declaration.
 348
 349 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * cli/cli-utils.c (info_print_command_completer): New function.
 352         * cli/cli-utils.h: Add 'completer.h' include, and forward
 353         declaration for 'struct cmd_list_element'.
 354         (info_print_command_completer): Declare.
 355         * stack.c (_initialize_stack): Add completer for 'info locals' and
 356         'info args'.
 357         * symtab.c (_initialize_symtab): Add completer for 'info
 358         variables' and 'info functions'.
 359         * NEWS: Mention completion for additional info commands.
 360
 361 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * cli/cli-utils.c (extract_info_print_args): Delete.
 364         (extract_arg_maybe_quoted): Delete.
 365         (info_print_options_defs): New variable.
 366         (make_info_print_options_def_group): New function.
 367         (extract_info_print_options): Define new function.
 368         * cli/cli-utils.h (extract_info_print_args): Delete.
 369         (struct info_print_options): New structure.
 370         (extract_info_print_options): Declare new function.
 371         * stack.c (info_locals_command): Update to use new
 372         extract_info_print_options, also add a header comment.
 373         (info_args_command): Likewise.
 374         * symtab.c (info_variables_command): Likewise.
 375         (info_functions_command): Likewise.
 376
 377 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 380         to extract string arguments.
 381         * common/common-utils.c (extract_string_maybe_quoted): New function.
 382         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 383
 384 2019-07-11  Tom Tromey  <tromey@adacore.com>
 385
 386         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 387         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 388         * top.h (gdbinit): Don't declare.
 389         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 390         into...
 391         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 392         * top.c (gdb_init): Don't call init_cli_cmds.
 393         (gdbinit): Remove.
 394         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 395
 396 2019-07-11  Tom Tromey  <tromey@adacore.com>
 397
 398         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 399         after it has been moved.
 400
 401 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 402
 403         * valops.c (value_must_coerce_to_target): Change return type to
 404         bool.
 405         * value.h (value_must_coerce_to_target): Likewise.
 406
 407 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 408
 409         * breakpoint.c (is_hardware_watchpoint): Remove
 410         forward-declaration.
 411         (is_masked_watchpoint): Change return type to bool.
 412         (is_tracepoint): Likewise.
 413         (is_breakpoint): Likewise.
 414         (is_hardware_watchpoint): Likewise.
 415         (is_watchpoint): Likewise.
 416         (is_no_memory_software_watchpoint): Likewise.
 417         (is_catchpoint): Likewise.
 418         (breakpoint_1): Make FILTER parameter's return type bool.
 419         is_masked_watchpoint): Change return type to bool.
 420         (save_breakpoints): Make FILTER parameter's return type bool.
 421         * breakpoint.h (is_breakpoint): Change return type to bool.
 422         (is_watchpoint): Likewise.
 423         (is_catchpoint): Likewise.
 424         (is_tracepoint): Likewise.
 425
 426 2019-07-10  Tom Tromey  <tom@tromey.com>
 427
 428         * defs.h: Don't include gdbarch.h.
 429         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 430         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 431         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 432         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 433         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 434         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 435         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 436         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 437         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 438         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 439         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 440         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 441         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 442         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 443         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 444         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 445         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 446         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 447         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 448         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 449         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 450         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 451         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 452         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 453         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 454         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 455         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 456
 457 2019-07-10  Tom Tromey  <tromey@adacore.com>
 458
 459         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 460         * breakpoint.c (init_ada_exception_breakpoint): Register as
 461         bp_catchpoint.
 462         (print_one_breakpoint_location, print_one_breakpoint): Use
 463         is_ada_exception_catchpoint.
 464         * ada-lang.c (class ada_catchpoint_location): Pass
 465         bp_loc_software_breakpoint to bp_location constructor.
 466         (is_ada_exception_catchpoint): New function.
 467
 468 2019-07-10  Tom Tromey  <tromey@adacore.com>
 469
 470         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 471         VEC.
 472         (struct arm_exidx_entry): New method operator<.
 473         (struct arm_exidx_data) <section_maps>: Change type.
 474         (arm_exidx_data_free): Remove.
 475         (arm_exidx_data_key): Change type.  Move lower.
 476         (arm_exidx_new_objfile): Update.
 477         (arm_compare_exidx_entries): Remove.
 478         (arm_find_exidx_entry, _initialize_arm_tdep)
 479
 480 2019-07-10  Tom Tromey  <tromey@adacore.com>
 481
 482         * solib-spu.c (ocl_program_data_key): Change type.
 483         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 484         Update.
 485
 486 2019-07-10  Tom Tromey  <tromey@adacore.com>
 487
 488         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 489         (struct solib_aix_inferior_data) <library_list>: Change type.
 490         (solib_aix_inferior_data_handle): Change type.
 491         (get_solib_aix_inferior_data): Update.
 492         (solib_aix_free_library_list): Remove.
 493         (library_list_start_library): Update.
 494         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 495         return type.
 496         (solib_aix_get_library_list)
 497         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 498         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 499
 500 2019-07-10  Tom Tromey  <tromey@adacore.com>
 501
 502         * solib-dsbt.c (struct dsbt_info): Add initializers.
 503         (solib_dsbt_pspace_data): Change type.
 504         (dsbt_pspace_data_cleanup): Remove.
 505         (get_dsbt_info, _initialize_dsbt_solib): Update.
 506
 507 2019-07-10  Tom Tromey  <tromey@adacore.com>
 508
 509         * spu-tdep.c (spu_overlay_data): Change type.
 510         (spu_get_overlay_table, spu_overlay_new_objfile)
 511         (_initialize_spu_tdep): Update.
 512
 513 2019-07-10  Tom Tromey  <tromey@adacore.com>
 514
 515         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 516         destructor.
 517         (dbx_objfile_data_key): Change type and declare later.
 518         (DBX_SYMFILE_INFO): Rewrite.
 519         * dbxread.c (dbx_objfile_data_key): Change type.
 520         (dbx_symfile_init): Update.
 521         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 522         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 523         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 524
 525 2019-07-10  Tom Tromey  <tromey@adacore.com>
 526
 527         * jit.c (jit_program_space_key): Change type.  Move lower.
 528         (get_jit_program_space_data): Update.
 529         (jit_program_space_data_cleanup): Remove.
 530         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 531         Update.
 532         (struct jit_program_space_data): Add initializers.
 533
 534 2019-07-10  Tom Tromey  <tromey@adacore.com>
 535
 536         * solib-darwin.c (struct darwin_info): Add initializers.
 537         (solib_darwin_pspace_data): Change type.
 538         (darwin_pspace_data_cleanup): Remove.
 539         (get_darwin_info, _initialize_darwin_solib): Update.
 540
 541 2019-07-10  Tom Tromey  <tromey@adacore.com>
 542
 543         * remote-sim.c (struct sim_inferior_data): Add initializers,
 544         constructor, and destructor.
 545         (sim_inferior_data_key): Change type.  Move lower.
 546         (check_for_duplicate_sim_descriptor): Update.
 547         (get_sim_inferior_data): Use new.  Update.
 548         (~sim_inferior_data_cleanup): Rename from
 549         sim_inferior_data_cleanup.  Simplify.
 550         (gdbsim_close_inferior, simulator_command)
 551         (sim_command_completer, _initialize_remote_sim): Update.
 552         (next_pid, INITIAL_PID): Move earlier.
 553
 554 2019-07-10  Tom Tromey  <tromey@adacore.com>
 555
 556         * python/python-internal.h (create_thread_object): Return
 557         gdbpy_ref.
 558         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 559         * python/py-inferior.c (struct threadlist_entry): Add
 560         constructor.
 561         <thread_obj>: Now a gdbpy_ref.
 562         (thread_to_thread_object): Update.
 563         (add_thread_object): Use new.
 564         (delete_thread_object): Use delete.
 565         (infpy_threads): Update.
 566         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 567         GIL.
 568
 569 2019-07-10  Tom Tromey  <tromey@adacore.com>
 570
 571         * valops.c (value_cast): Specialize error message for Ada.
 572
 573 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 574
 575         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 576
 577 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 578
 579         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 580         bpstat_should_step): Return bool, adjust comments.
 581         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 582         bpstat_should_step): Likewise.
 583
 584 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 585
 586         * features/Makefile: Use feature target descriptions for Arm.
 587         * features/arm/arm-core.c: Generate new file.
 588         * features/arm/arm-fpa.c: Likewise.
 589         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 590         * features/arm/arm-m-profile.c: Likewise.
 591         * features/arm/arm-vfpv2.c: Likewise.
 592         * features/arm/arm-vfpv3.c: Likewise.
 593         * features/arm/xscale-iwmmxt.c: Likewise.
 594         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 595
 596 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 597
 598         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 599         ptrace earlier.
 600
 601 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 602
 603         * features/aarch64-pauth.c: Regenerate.
 604
 605 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 606
 607         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 608         bool.
 609         (bpstat_what): Use false instead of 0.
 610
 611 2019-07-09  Pedro Alves  <palves@redhat.com>
 612
 613         * break-catch-throw.c (is_exception_catchpoint): New.
 614         * breakpoint.c (print_one_breakpoint_location): New parameter
 615         'raw_loc'.  Handle it.  Use
 616         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 617         looking at the breakpoint's type.
 618         (print_one_breakpoint): If handling "maint info breakpoints", also
 619         print locations of exception catchpoints.
 620         * breakpoint.h (is_exception_catchpoint): Declare.
 621
 622 2019-07-09  Pedro Alves  <palves@redhat.com>
 623
 624         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 625         "addr" field.
 626         (allocate_location_exception_catchpoint): New.
 627         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 628         (initialize_throw_catchpoint_ops): Install
 629         allocate_location_exception_catchpoint as allocate_location
 630         method.
 631         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 632         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 633         bp_loc_other.
 634         (breakpoint_address_is_meaningful): Delete.
 635         (bl_address_is_meaningful): New.
 636         (breakpoint_locations_match): Adjust comment.
 637         (bp_location_from_bp_type): New, factored out of...
 638         (bp_location::bp_location(breakpoint *)): ... this.
 639         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 640         factored out of...
 641         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 642         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 643         breakpoint_address_is_meaningful.
 644         (bp_locations_compare): Adjust comment.
 645         (update_global_location_list): Use bl_address_is_meaningful
 646         instead of breakpoint_address_is_meaningful.
 647         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 648         explicit.
 649         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 650         * python/py-breakpoint.c (bppy_get_location): No longer check
 651         whether location is null.
 652
 653 2019-07-09  Pedro Alves  <palves@redhat.com>
 654
 655         PR c++/15468
 656         * breakpoint.c (print_one_breakpoint_location): Remove
 657         single-location assert.
 658
 659 2019-07-09  Tom Tromey  <tom@tromey.com>
 660
 661         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 662         * configure: Rebuild.
 663         * configure.ac: Change common to gdbsupport.
 664         * gdbsupport: Rename from common.
 665         * acinclude.m4: Change common to gdbsupport.
 666         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 667         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 668         gdbsupport.
 669         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 670         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 671         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 672         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 673         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 674         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 675         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 676         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 677         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 678         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 679         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 680         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 681         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 682         coff-pe-read.c, command.h, compile/compile-c-support.c,
 683         compile/compile-c.h, compile/compile-cplus-symbols.c,
 684         compile/compile-cplus-types.c, compile/compile-cplus.h,
 685         compile/compile-loc2c.c, compile/compile.c, completer.c,
 686         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 687         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 688         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 689         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 690         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 691         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 692         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 693         features/aarch64-core.c, features/aarch64-fpu.c,
 694         features/aarch64-pauth.c, features/aarch64-sve.c,
 695         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 696         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 697         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 698         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 699         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 700         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 701         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 702         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 703         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 704         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 705         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 706         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 707         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 708         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 709         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 710         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 711         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 712         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 713         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 714         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 715         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 716         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 717         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 718         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 719         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 720         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 721         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 722         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 723         minsyms.c, mips-linux-tdep.c, namespace.h,
 724         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 725         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 726         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 727         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 728         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 729         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 730         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 731         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 732         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 733         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 734         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 735         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 736         procfs.c, producer.c, progspace.h, psymtab.h,
 737         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 738         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 739         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 740         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 741         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 742         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 743         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 744         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 745         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 746         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 747         target-memory.c, target.c, target.h, target/waitstatus.c,
 748         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 749         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 750         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 751         unittests/array-view-selftests.c,
 752         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 753         unittests/common-utils-selftests.c,
 754         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 755         unittests/format_pieces-selftests.c,
 756         unittests/function-view-selftests.c,
 757         unittests/lookup_name_info-selftests.c,
 758         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 759         unittests/mkdir-recursive-selftests.c,
 760         unittests/observable-selftests.c,
 761         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 762         unittests/parse-connection-spec-selftests.c,
 763         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 764         unittests/scoped_fd-selftests.c,
 765         unittests/scoped_mmap-selftests.c,
 766         unittests/scoped_restore-selftests.c,
 767         unittests/string_view-selftests.c, unittests/style-selftests.c,
 768         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 769         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 770         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 771         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 772         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 773         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 774
 775 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 778         bool value.
 779         (decode_digits_ordinary): Set explicit_line field in sal.
 780         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 781         symtab_and_line that was set on an explicit line number in
 782         assembler code.  Do always update the recorded symtab and line if
 783         we do skip the prologue.
 784
 785 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * breakpoint.c (set_breakpoint_location_function): Remove
 788         explicit_loc parameter.
 789         (momentary_breakpoint_from_master): Update call to
 790         set_breakpoint_location_function.
 791         (add_location_to_breakpoint): Likewise.
 792
 793 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 796         required features based on default bfd type when no specific bfd
 797         is present.
 798
 799 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 800
 801         * NEWS: Mention that GDB printf and eval commands can now print
 802         C-style and Ada-style convenience var strings without
 803         calling the inferior.
 804         * printcmd.c (printf_c_string): Locally print GDB internal var
 805         instead of transiting via the inferior.
 806         (printf_wide_c_string): Likewise.
 807
 808 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 809
 810         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 811
 812 2019-07-04  Tom Tromey  <tom@tromey.com>
 813
 814         PR tui/24724:
 815         * tui/tui-winsource.c (tui_clear_source_content): Update.
 816         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 817         (tui_update_breakpoint_info): Update.
 818         (tui_set_exec_info_content): Update.
 819         * tui/tui-source.c (tui_set_source_content_nil): Update.
 820         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 821         has_break.
 822         * tui/tui-data.h (enum tui_bp_flag): New.
 823         (tui_bp_flags): New enum flags type.
 824         (struct tui_source_element) <break_mode>: Change type.  Rename
 825         from has_break.
 826         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 827         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 828         constants.
 829         * tui/tui-winsource.h: Fix comment.
 830
 831 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 834         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 835         (store_fpregs_to_thread)
 836         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 837         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 838         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 839         (IWMMXT_REGS_SIZE): Add define.
 840         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 841         (fetch_vfp_regs, store_vfp_regs)
 842         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 843         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 844
 845 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 846
 847         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 848         defines.
 849         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 850         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 851         (ARM_INT_REGISTER_SIZE): ...to this.
 852         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 853         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 854         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 855         (arm_linux_collect_gregset, supply_nwfpe_register)
 856         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 857         defines.
 858         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 859         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 860         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 861         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 862         (arm_return_in_memory, arm_store_return_value)
 863         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 864         (arm_record_ld_st_multiple): Likewise.
 865         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 866         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 867
 868 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 869
 870         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 871         AARCH64_DISPLACED_MODIFIED_INSNS.
 872         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 873         (aarch64_displaced_step_copy_insn): Likewise.
 874         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 875         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 876         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 877         ARM_DISPLACED_MODIFIED_INSNS.
 878         * arm-tdep.c (arm_gdbarch_init): Likewise.
 879         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 880         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 881         (struct arm_displaced_step_closure): Use
 882         ARM_DISPLACED_MODIFIED_INSNS.
 883
 884 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 885
 886         * features/Makefile: Remove unused xml files.
 887         * features/aarch64.xml: Remove.
 888         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 889         * features/i386/amd64-avx-avx512.xml: Remove.
 890         * features/i386/amd64-avx-linux.xml: Remove.
 891         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 892         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 893         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 894         * features/i386/amd64-avx-mpx.xml: Remove.
 895         * features/i386/amd64-avx.xml: Remove.
 896         * features/i386/amd64-linux.xml: Remove.
 897         * features/i386/amd64-mpx-linux.xml: Remove.
 898         * features/i386/amd64-mpx.xml: Remove.
 899         * features/i386/amd64.xml: Remove.
 900         * features/i386/i386-avx-avx512-linux.xml: Remove.
 901         * features/i386/i386-avx-avx512.xml: Remove.
 902         * features/i386/i386-avx-linux.xml: Remove.
 903         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 904         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 905         * features/i386/i386-avx-mpx-linux.xml: Remove.
 906         * features/i386/i386-avx-mpx.xml: Remove.
 907         * features/i386/i386-avx.xml: Remove.
 908         * features/i386/i386-linux.xml: Remove.
 909         * features/i386/i386-mmx-linux.xml: Remove.
 910         * features/i386/i386-mmx.xml: Remove.
 911         * features/i386/i386-mpx-linux.xml: Remove.
 912         * features/i386/i386-mpx.xml: Remove.
 913         * features/i386/i386.xml: Remove.
 914         * features/i386/x32-avx-avx512-linux.xml: Remove.
 915         * features/i386/x32-avx-linux.xml: Remove.
 916         * features/i386/x32-linux.xml: Remove.
 917
 918 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 919
 920         * regformats/aarch64.dat: Remove.
 921         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 922         * regformats/i386/amd64-avx-linux.dat: Remove.
 923         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 924         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 925         * regformats/i386/amd64-linux.dat: Remove.
 926         * regformats/i386/amd64-mpx-linux.dat: Remove.
 927         * regformats/i386/amd64.dat: Remove.
 928         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 929         * regformats/i386/i386-avx-linux.dat: Remove.
 930         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 931         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 932         * regformats/i386/i386-linux.dat: Remove.
 933         * regformats/i386/i386-mmx-linux.dat: Remove.
 934         * regformats/i386/i386-mpx-linux.dat: Remove.
 935         * regformats/i386/i386.dat: Remove.
 936         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 937         * regformats/i386/x32-avx-linux.dat: Remove.
 938         * regformats/i386/x32-linux.dat: Remove.
 939
 940 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * aarch64-tdep.c: Remove xml self tests.
 943         * amd64-linux-tdep.c: Likewise.
 944         * amd64-tdep.c: Likewise.
 945         * i386-linux-tdep.c: Likewise.
 946         * i386-tdep.c: Likewise.
 947
 948 2019-07-03  Pedro Alves  <palves@redhat.com>
 949
 950         PR cli/24732
 951         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 952         (pipe_cmd_option_defs): New.
 953         (make_pipe_cmd_options_def_group): New.
 954         (pipe_command): Use gdb::option::process_options.
 955         (pipe_command_completer): New function.
 956         (_initialize_cli_cmds): Install completer for "pipe" command.
 957
 958 2019-07-03  Pedro Alves  <palves@redhat.com>
 959
 960         * cli/cli-option.c (union option_value) <string>: New field.
 961         (struct option_def_and_value): Add ctor, move ctor, dtor and
 962         use DISABLE_COPY_AND_ASSIGN.
 963         (option_def_and_value::clear_value): New.
 964         (parse_option, save_option_value_in_ctx, get_val_type_str)
 965         (add_setshow_cmds_for_options): Handle var_string.
 966         * cli-option.h (union option_def::var_address) <string>: New
 967         field.
 968         (struct string_option_def): New.
 969         * maint-test-options.c (struct test_options_opts): Add default
 970         ctor and use DISABLE_COPY_AND_ASSIGN.
 971         <string_opt>: New field.
 972         (test_options_opts::~test_options_opts): New.
 973         (test_options_opts::dump): Also dump "-string".
 974         (test_options_option_defs): Install "string.
 975
 976 2019-07-03  Pedro Alves  <palves@redhat.com>
 977
 978         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 979         option_value with a null enumeration.
 980         (complete_options): Save the option values in the context.
 981         (save_option_value_in_ctx): New, factored out from ...
 982         (process_options): ... here.
 983         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 984         of the function.
 985         * maint-test-options.c (test_options_opts::dump): New, factored
 986         out from ...
 987         (maintenance_test_options_command_mode): ... here.
 988         (maintenance_test_options_command_completion_result): Delete.
 989         (maintenance_test_options_command_completion_text): Update
 990         comment.
 991         (maintenance_show_test_options_completion_result): Change
 992         prototype.  Just print
 993         maintenance_test_options_command_completion_text.
 994         (save_completion_result): New.
 995         (maintenance_test_options_completer_mode): Pass options context to
 996         complete_options, and then save a dump.
 997         (_initialize_maint_test_options): Use add_cmd to install "maint
 998         show test-options-completion-result".
 999
1000 2019-07-03  Pedro Alves  <palves@redhat.com>
1001
1002         * NEWS (New commands): Mention "with" and "maint with".
1003         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1004         (with_command, with_command_completer): New.
1005         (pipe_command): Adjust to new repeat_previous
1006         interface.
1007         (_initialize_cli_cmds): Install the "with" command and its "w"
1008         alias.
1009         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1010         declarations.
1011         * cli/cli-setshow.c (parse_cli_var_uinteger)
1012         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1013         argument strings for all var_types.
1014         (get_setshow_command_value_string): New, factored out from ...
1015         (do_show_command): ... this.
1016         * cli/cli-setshow.h: Include <string>.
1017         (get_setshow_command_value_string): Declare.
1018         * command.h (repeat_previous): Now returns const char *.  Adjust
1019         comment.
1020         * maint.c: Include "cli/cli-cmds.h".
1021         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1022         (_initialize_maint_cmds): Register the "maintenance with" command.
1023         * top.c (repeat_previous): Move bits from pipe_command here:
1024         Return the saved command line, if any; error out if there's no
1025         command to relaunch.
1026
1027 2019-07-03  Pedro Alves  <palves@redhat.com>
1028
1029         * NEWS (New commands): Mention "maint set/show test-settings"
1030         instead of "maint test-settings".
1031         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1032         (maintenance_test_settings_set_list): Rename to ...
1033         (maintenance_set_test_settings_list): ... this.
1034         (maintenance_test_settings_show_list): Rename to  ...
1035         (maintenance_show_test_settings_list): ... this.
1036         (maintenance_test_settings_cmd): Delete.
1037         (maintenance_test_settings_set_cmd): ...
1038         (maintenance_set_test_settings_cmd): ... this.
1039         (maintenance_test_settings_show_cmd): ...
1040         (maintenance_show_test_settings_cmd): ... this.
1041         (maintenance_test_settings_show_value_cmd):
1042         (maintenance_show_test_settings_value_cmd): ... this.
1043         (_initialize_maint_test_settings): No longer install the "maint
1044         test-settings" prefix command.  Rename "maint test-settings set"
1045         to "maint set test-settings", and "maint test-settings show" to
1046         "maint show test-settings".  Adjust all subcommands.
1047
1048 2019-07-03  Pedro Alves  <palves@redhat.com>
1049
1050         * maint-test-settings.c: Fix file's intro comment.  Replace all
1051         references to "test-options" with references to "test-settings",
1052         in comments.
1053
1054 2019-07-03  Pedro Alves  <palves@redhat.com>
1055
1056         * maint-test-settings.c (maintenance_test_settings_xxx)
1057         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1058         New.
1059         (maintenance_test_settings_enums): Use them.
1060         (maintenance_test_settings_enum): Default to
1061         maintenance_test_settings_xxx.
1062         (_initialize_maint_test_settings): Initialize
1063         MAINTENANCE_TEST_SETTINGS_FILENAME.
1064
1065 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1066
1067         * breakpoint.h (remove_breakpoints_inf): Change return type to
1068         void, move function documentation here.
1069         * breakpoint.c (remove_breakpoints_inf): Change return type to
1070         void, move function documentation to header.
1071
1072 2019-07-02  Pedro Alves  <palves@redhat.com>
1073
1074         * NEWS (Completion improvements): Mention "info threads".
1075         * thread.c (struct info_threads_opts, info_threads_option_defs)
1076         (make_info_threads_options_def_group): New.
1077         (info_threads_command): Use gdb::option::process_options.
1078         (info_threads_command_completer): New.
1079         (_initialize_thread): Use gdb::option::build_help to build the
1080         help text for "info threads".
1081
1082 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1083
1084         * defs.h (generic_load): Move from here...
1085         * symfile.h (generic_load): ... to here.  Rename name parameter
1086         to args.
1087         * symfile.c (generic_load): Add comment.
1088
1089 2019-07-01  Tom Tromey  <tromey@adacore.com>
1090
1091         * dwarf2read.c
1092         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1093         declaration of without_params.  Fix formatting.
1094
1095 2019-07-01  Tom Tromey  <tromey@adacore.com>
1096
1097         * ada-exp.y (find_primitive_type): Update.
1098         * ada-lang.h (ada_lookup_symbol): Update.
1099         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1100         parameter.
1101         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1102
1103 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1104
1105         PR breakpoints/24541
1106         * gdbarch.c: Regenerate.
1107         * gdbarch.h: Regenerate.
1108         * gdbarch.sh: Add 'stap_adjust_register'.
1109         * i386-tdep.c: Include '<unordered_set>'.
1110         (i386_stap_adjust_register): New function.
1111         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1112         * stap-probe.c (stap_parse_register_operand): Call
1113         'gdbarch_stap_adjust_register'.
1114
1115 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1116
1117         PR python/24742
1118         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1119         * python/python.c (do_start_initialization): Use 'xmalloc'
1120         instead of 'PyMem_Malloc'.
1121
1122 2019-06-28  Tom Tromey  <tromey@adacore.com>
1123
1124         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1125         for Ada.
1126
1127 2019-06-27  Tom Tromey  <tromey@adacore.com>
1128
1129         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1130         objfile_key.
1131         (arm_find_mapping_symbol, arm_record_special_symbol)
1132         (_initialize_arm_tdep): Update.
1133         (arm_objfile_data_free): Remove.
1134
1135 2019-06-27  Tom Tromey  <tromey@adacore.com>
1136
1137         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1138         to cp_print_static_field.
1139
1140 2019-06-26  Tom Tromey  <tromey@adacore.com>
1141
1142         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1143         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1144         declare.
1145
1146 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1147
1148         * features/aarch64-core.c (create_feature_aarch64_core):
1149         Regenerate.
1150         * features/aarch64-core.xml: Add cpsr flags.
1151
1152 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1153
1154         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1155         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1156
1157 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1158
1159         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1160         field.
1161         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1162         use.
1163         (arm_record_special_symbol): Don't insert new symbol in sorted
1164         position, push it at the end.
1165
1166 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1167
1168         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1169         (arm_mapping_symbol_s): Remove.
1170         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1171         (arm_mapping_symbol_vec): New typedef.
1172         (struct arm_per_objfile): Add constructor.
1173         <section_maps>: Change type to
1174         std::unique_ptr<arm_mapping_symbol_vec[]>.
1175         (arm_compare_mapping_symbols): Remove.
1176         (arm_find_mapping_symbol): Adjust to section_maps type change.
1177         (arm_objfile_data_free): Call delete on arm_per_objfile.
1178         (arm_record_special_symbol): Adjust to section_maps type change.
1179         Allocate arm_per_objfile with new.
1180
1181 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1182
1183         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1184         with the command prefix.
1185
1186 2019-06-25  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1189         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1194         type.
1195         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1196         protected.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.c
1201         (tui_source_window_base::set_is_exec_point_at): Add check against
1202         LOA_ADDRESS.
1203
1204 2019-06-25  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-source.c (tui_set_source_content): Don't check before
1207         xfree.
1208         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1209
1210 2019-06-25  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-winsource.h (tui_update_source_window_as_is)
1213         (tui_alloc_source_buffer, tui_line_is_displayed)
1214         (tui_addr_is_displayed): Change type of win_info.
1215         * tui/tui-winsource.c (tui_update_source_window_as_is)
1216         (tui_clear_source_content, tui_show_source_line)
1217         (tui_show_source_content, tui_source_window_base::refill)
1218         (tui_source_window_base::set_is_exec_point_at)
1219         (tui_source_window_base::set_is_exec_point_at)
1220         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1221         (tui_alloc_source_buffer, tui_line_is_displayed)
1222         (tui_addr_is_displayed): Change type of win_info.  Update.
1223         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1224         (tui_source_window_base::do_make_visible_with_new_height):
1225         Update.
1226         * tui/tui-source.c (tui_set_source_content)
1227         (tui_set_source_content_nil)
1228         (tui_source_window::do_scroll_vertical): Update.
1229         * tui/tui-layout.c (show_layout): Update.
1230         * tui/tui-disasm.c (tui_set_disassem_content)
1231         (tui_disasm_window::do_scroll_vertical): Update.
1232         * tui/tui-data.h (tui_win_content): Remove.
1233         (struct tui_gen_win_info) <content, content_size>: Remove.
1234         (struct tui_source_element): Add initializers and destructor.
1235         (union tui_which_element, struct tui_win_element): Remove.
1236         (struct tui_source_window_base) <content>: New field.
1237         (struct tui_data_window): Remove destructor.
1238         (tui_alloc_content, tui_free_win_content)
1239         (tui_free_all_source_wins_content): Don't declare.
1240         * tui/tui-data.c (tui_initialize_static_data): Update.
1241         (init_content_element, tui_alloc_content): Remove.
1242         (~tui_gen_win_info): Update.
1243         (~tui_data_window, tui_free_all_source_wins_content)
1244         (tui_free_win_content, free_content, free_content_elements):
1245         Remove.
1246
1247 2019-06-25  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-winsource.h (tui_clear_source_content)
1250         (tui_erase_source_content, tui_show_source_content): Change type
1251         of win_info.
1252         * tui/tui-winsource.c (tui_clear_source_content)
1253         (tui_erase_source_content, tui_show_source_content): Change type
1254         of win_info.
1255         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1256         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1257         win_info.
1258         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1259         win_info.
1260         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-winsource.c (tui_clear_source_content)
1265         (tui_source_window_base::set_is_exec_point_at): Update.
1266         * tui/tui-source.c (tui_set_source_content_nil): Update.
1267         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1268         a bool.
1269         * tui/tui-data.c (init_content_element): Update.
1270
1271 2019-06-25  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1274         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1275         * tui/tui-layout.c (init_and_make_win): Update.
1276         * tui/tui.h (enum tui_win_type): Update.
1277         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1278         tui_win_is_auxillary.
1279         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1280         tui_win_is_auxillary.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1285         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1286         (tui_delete_data_content_windows, tui_display_all_data)
1287         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1288         Update.
1289         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1290         * tui/tui-regs.c (tui_last_regs_line_no)
1291         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1292         (tui_show_registers): Update.
1293         (tui_show_register_group): Return void.  Update.
1294         (tui_display_registers_from, tui_display_reg_element_at_line)
1295         (tui_display_registers_from_line, tui_check_register_values):
1296         Update.
1297         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1298         member.
1299         (struct tui_data_window) <regs_content>: Now a std::vector.
1300         <regs_content_count>: Remove.
1301         (tui_add_content_elements, tui_free_data_content): Don't declare.
1302         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1303         (init_content_element): Remove DATA_WIN case.  Add assert.
1304         (tui_add_content_elements): Remove.
1305         (tui_data_window): Update.
1306         (tui_free_data_content): Remove.
1307         (free_content_elements): Remove DATA_WIN case.
1308
1309 2019-06-25  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-data.c (tui_data_item_window): Update.
1312         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1313         * tui/tui-windata.c (tui_display_all_data)
1314         (tui_display_data_from_line): Update.
1315         (tui_check_data_values): Remove.
1316         * tui/tui-regs.c (tui_show_register_group)
1317         (tui_display_reg_element_at_line): Update.
1318         * tui/tui-hooks.c (tui_register_changed)
1319         (tui_refresh_frame_and_register_information): Call
1320         tui_check_register_values.
1321         * tui/tui-data.h (struct tui_data_window) <data_content,
1322         data_content_count, data_type>: Remove.
1323         (enum tui_data_type): Remove.
1324
1325         * tui/tui-data.c (tui_data_window::clear_detail)
1326         (~tui_data_window): Update.
1327
1328 2019-06-25  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1331         declare.
1332         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1333         Rename from tui_first_data_item_displayed.  Update.
1334         (tui_data_window::refresh_all)
1335         (tui_data_window::do_scroll_vertical): Update.
1336         * tui/tui-data.h (struct tui_data_window)
1337         <first_data_item_displayed>: Declare new method.
1338
1339 2019-06-25  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1342         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1343         contents...
1344         (tui_initialize_static_data): ...here.
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1349         (tui_display_registers_from, tui_check_register_values): Update.
1350         (tui_display_register): Remove win_info parameter; update.
1351         (tui_get_register): Change type of parameters.
1352         * tui/tui-data.h (struct tui_data_element): Remove.
1353         (union tui_which_element) <data>: Remove.
1354         <data_window>: Change type.
1355         (struct tui_data_item_window): New.
1356         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1357         case.  Add assert.
1358         (~tui_data_item_window): New destructor.
1359         (free_content_elements): Remove DATA_ITEM_WIN case.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1364         Remove.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-data.h (struct tui_command_element): Remove.
1369         (union tui_which_element) <command>: Remove.
1370         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1371         assert.
1372         (free_content_elements): Remove CMD_WIN case.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-layout.c (tui_set_layout): Update.
1377         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1378         * tui/tui-data.c (layout_def): Update.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1383         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1384         (tui_source_window_base::set_new_height): Update.
1385         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1386         Update.
1387         (tui_set_locator_fullname, tui_set_locator_info)
1388         (tui_show_frame_info): Update.
1389         * tui/tui-source.c (tui_set_source_content)
1390         (tui_source_is_displayed): Update.
1391         * tui/tui-layout.c (show_source_disasm_command, show_data)
1392         (show_source_or_disasm_and_command): Update.
1393         * tui/tui-disasm.c (tui_set_disassem_content)
1394         (tui_get_begin_asm_address): Update.
1395         * tui/tui-data.h (struct tui_locator_element): Remove.
1396         (union tui_which_element) <locator>: Remove.
1397         (struct tui_locator_window): New.
1398         (tui_locator_win_info_ptr): Change return type.
1399         * tui/tui-data.c (_locator): Change type.
1400         (tui_locator_win_info_ptr): Change return type.
1401         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1402         (tui_alloc_content): Add assert.
1403
1404 2019-06-25  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-winsource.c
1407         (tui_exec_info_window::maybe_allocate_content): New method.
1408         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1409         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1410         (make_source_or_disasm_window): Add cast.
1411         * tui/tui-data.h (union tui_which_element) <simple_string>:
1412         Remove.
1413         (struct tui_source_info): New.
1414         (struct tui_source_window_base) <execution_info>: Change type.
1415         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1416         case, and add assert.
1417         (tui_alloc_content): Add assert.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1422         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1423         * tui/tui-data.c (tui_alloc_win_info): Remove.
1424
1425 2019-06-25  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1428         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1429         can_highlight.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1434         make_visible_with_new_height method.
1435         (tui_win_info::make_visible_with_new_height): New method.
1436         (tui_source_window_base::do_make_visible_with_new_height)
1437         (tui_data_window::do_make_visible_with_new_height)
1438         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1439         (make_visible_with_new_height): Remove.
1440         (tui_resize_all, tui_adjust_win_heights): Use
1441         make_visible_with_new_height method.
1442         * tui/tui-data.h (struct tui_win_info)
1443         <do_make_visible_with_new_height, make_visible_with_new_height>:
1444         New methods.
1445         (struct tui_source_window_base, struct tui_data_window)
1446         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1447         methods.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1452         method.
1453         (update_tab_width): Call update_tab_width method.
1454         * tui/tui-data.h (struct tui_win_info)
1455         (struct tui_source_window_base) <update_tab_width>: New methods.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1460         parameter.
1461         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1462         parameter.
1463         (tui_gen_win_info::make_visible): Update.
1464         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1465         parameter.
1466         * tui/tui-data.h (enum tui_box): New enum.
1467         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1472         init_and_make_win for EXEC_INFO_WIN.
1473         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1474         longer inline.
1475         (struct tui_win_info) <~tui_win_info>: Inline.
1476         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1477         Don't declare.
1478         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1479         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1480         Remove.
1481         (tui_initialize_static_data): Update.
1482         (~tui_gen_win_info): Handle more cleanup here.
1483         (~tui_source_window_base): Delete "execution_info".
1484         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1485
1486 2019-06-25  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-layout.c (make_command_window): Don't set
1489         can_highlight.
1490         (show_source_disasm_command): Call the reset method.
1491         (show_data): Don't set can_highlight.  Call the reset method.
1492         (tui_gen_win_info::reset): Rename from init_gen_win_info
1493         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1494         (show_source_or_disasm_and_command): Call the reset method.
1495         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1496         (struct tui_cmd_window): Set can_highlight.
1497
1498 2019-06-25  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1501         from make_visible.
1502         (tui_make_visible, tui_make_invisible): Rewrite.
1503         (tui_win_info::make_visible): Remove.
1504         (tui_source_window_base::make_visible): Update.
1505         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1506         method.  Moved from...
1507         (struct tui_win_info) <make_visible>: ...here.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.c
1512         (tui_source_window_base::do_scroll_horizontal): Remove direction
1513         parameter.
1514         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1515         direction parameter.
1516         * tui/tui-win.c (tui_win_info::forward_scroll)
1517         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1518         (tui_win_info::right_scroll): Update.
1519         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1520         direction parameter.
1521         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1522         direction parameter.
1523         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1524         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1525         Remove direction parameter.
1526         (struct tui_source_window_base, struct tui_source_window)
1527         (struct tui_disasm_window, struct tui_data_window)
1528         (struct tui_cmd_window): Update.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-winsource.h (tui_set_exec_info_content)
1533         (tui_show_exec_info_content, tui_erase_exec_info_content)
1534         (tui_clear_exec_info_content, tui_update_exec_info): Change
1535         argument to tui_source_window_base.
1536         * tui/tui-winsource.c (tui_set_exec_info_content)
1537         (tui_show_exec_info_content, tui_erase_exec_info_content)
1538         (tui_clear_exec_info_content, tui_update_exec_info): Change
1539         argument to tui_source_window_base.
1540
1541 2019-06-25  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1544         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1549         check.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1554         type to void.
1555         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1556         type to void.
1557         * tui/tui-source.c (tui_set_source_content): Update.
1558         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1559
1560 2019-06-25  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-win.c (window_name_completer, tui_set_focus)
1563         (tui_all_windows_info): Use name method.
1564         * tui/tui-data.h (struct tui_gen_win_info)
1565         (struct tui_source_window, struct tui_disasm_window)
1566         (struct tui_data_window, struct tui_cmd_window) <name>: New
1567         method.
1568         (tui_win_name): Don't declare.
1569         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1570         (tui_win_name): Remove.
1571
1572 2019-06-25  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-winsource.h (tui_update_source_window)
1575         (tui_update_source_window_as_is): Change parameter type.
1576         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1577         to be a tui_source_window_base.
1578         (tui_update_source_window_as_is): Likewise.
1579         * tui/tui-win.c (make_visible_with_new_height): Update.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-winsource.c (tui_erase_source_content)
1584         (tui_show_source_content, tui_show_exec_info_content)
1585         (tui_erase_exec_info_content): Use refresh_window method.
1586         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1587         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1588         from tui_refresh_win.
1589         (tui_data_window::refresh_window): New method.
1590         (tui_win_info::refresh, tui_source_window_base::refresh)
1591         (tui_refresh_all): Use refresh_window method.
1592         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1593         method.
1594         * tui/tui-regs.c (tui_display_register): Call refresh_window
1595         method.
1596         * tui/tui-layout.c (show_source_disasm_command)
1597         (show_source_or_disasm_and_command): Call refresh_window method.
1598         * tui/tui-data.h (struct tui_gen_win_info)
1599         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1600         New method.
1601
1602 2019-06-25  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui.c (tui_rl_other_window, tui_enable)
1605         (tui_is_window_visible, tui_get_command_dimension): Update.
1606         * tui/tui-winsource.c (tui_update_source_window_as_is)
1607         (tui_clear_source_content, tui_erase_source_content)
1608         (tui_show_source_line, tui_source_window_base::refill)
1609         (tui_source_window_base::do_scroll_horizontal)
1610         (tui_source_window_base::set_is_exec_point_at)
1611         (tui_update_breakpoint_info, tui_set_exec_info_content)
1612         (tui_alloc_source_buffer, tui_line_is_displayed)
1613         (tui_addr_is_displayed): Update.
1614         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1615         (tui_check_and_display_highlight_if_needed)
1616         (tui_win_info::make_visible, tui_win_info::refresh)
1617         (tui_refresh_all): Update.
1618         * tui/tui-windata.c (tui_first_data_item_displayed)
1619         (tui_delete_data_content_windows, tui_erase_data_content)
1620         (tui_display_all_data, tui_data_window::refresh_all)
1621         (tui_check_data_values): Update.
1622         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1623         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1624         (tui_win_info::backward_scroll, tui_refresh_all_win)
1625         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1626         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1627         (tui_source_window_base::set_new_height)
1628         (tui_data_window::set_new_height)
1629         (make_invisible_and_set_new_height)
1630         (make_visible_with_new_height, new_height_ok)
1631         (parse_scrolling_args): Update.
1632         * tui/tui-stack.c (tui_show_frame_info): Update.
1633         * tui/tui-source.c (tui_set_source_content)
1634         (tui_set_source_content_nil, tui_source_is_displayed)
1635         (tui_source_window::do_scroll_vertical): Update.
1636         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1637         (tui_display_registers_from, tui_display_reg_element_at_line)
1638         (tui_check_register_values, tui_reg_command): Update.
1639         * tui/tui-layout.c (tui_default_win_height)
1640         (show_source_disasm_command, show_data, init_and_make_win)
1641         (show_source_or_disasm_and_command): Update.
1642         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1643         (tui_redisplay_readline, tui_mld_flush)
1644         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1645         (tui_getc): Update.
1646         * tui/tui-disasm.c (tui_set_disassem_content)
1647         (tui_disasm_window::do_scroll_vertical): Update.
1648         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1649         Now virtual.
1650         (struct tui_win_info): Derive from tui_gen_win_info.
1651         <~tui_win_info>: Mark as override.
1652         <generic>: Remove member.
1653         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1654         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1655         (~tui_data_window, ~tui_win_info)
1656         (tui_free_all_source_wins_content): Update.
1657         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-layout.c (init_and_make_win): Use new.
1662         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1663         destructor, initializers.
1664         (tui_alloc_generic_win_info): Don't declare.
1665         * tui/tui-data.c (_locator): Add argument to constructor.
1666         (source_win, disasm_win): New globals.
1667         (exec_info): Remove.
1668         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1669         Update.
1670         (tui_alloc_generic_win_info): Remove.
1671         (init_content_element): Use new.
1672         (tui_win_info::tui_win_info): Update.
1673         (free_content_elements) <case DATA_WIN>: Use delete.
1674
1675 2019-06-25  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1678         * tui/tui-windata.c (tui_first_data_item_displayed)
1679         (tui_delete_data_content_windows): Update.
1680         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1681         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1682         (tui_display_registers_from, tui_check_register_values): Update.
1683         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1684         pointer.
1685         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1686         window.
1687         (tui_free_data_content): Update.
1688         (free_content_elements) <case DATA_WIN>: Free the window.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1693         Update.
1694         * tui/tui-layout.c (make_command_window)
1695         (show_source_disasm_command, show_data, init_and_make_win)
1696         (show_source_or_disasm_and_command): Update.
1697         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1698         method.
1699         <can_highight, is_highlighted>: Now bool.
1700         (tui_set_win_highlight): Don't declare.
1701         * tui/tui-data.c (tui_set_win_highlight): Remove.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-wingeneral.c (make_visible): Remove check of window
1706         type.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-win.c (tui_win_info::max_height)
1711         (tui_cmd_window::max_height): New methods.
1712         (new_height_ok): Call max_height.
1713         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1714         <max_height>: New method.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-win.c (tui_source_window_base::set_new_height)
1719         (tui_data_window::set_new_height): New methods.
1720         (make_invisible_and_set_new_height): Call set_new_height method.
1721         * tui/tui-data.h (struct tui_win_info)
1722         (struct tui_source_window_base, struct tui_data_window)
1723         <set_new_height>: New method.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1728         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1729         tui_refresh_data_win.
1730         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1731         method.
1732         (tui_refresh_all_win): Call the refresh_all method.
1733         (tui_set_focus): Likewise.
1734         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1735         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1736         Likewise.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-winsource.h (tui_refill_source_window)
1741         (tui_set_is_exec_point_at): Don't declare.
1742         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1743         (tui_source_window_base::refill): Rename from
1744         tui_refill_source_window.
1745         (tui_source_window_base::do_scroll_horizontal): Update.
1746         (tui_source_window_base::set_is_exec_point_at): Rename from
1747         tui_set_is_exec_point_at.
1748         (tui_update_all_breakpoint_info): Update.
1749         * tui/tui-stack.c (tui_show_frame_info): Update.
1750         * tui/tui-layout.c (show_data): Add cast.
1751         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1752         * tui/tui-data.h (struct tui_source_window_base) <refill,
1753         set_is_exec_point_at>: New methods.
1754         (tui_source_windows, tui_add_to_source_windows): Update types.
1755         (tui_add_to_source_windows): Remove redundant declaration.
1756         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1757         (tui_source_windows): Change return type.
1758         (tui_clear_source_windows_detail): Update.
1759         (tui_add_to_source_windows): Change type of parameter.
1760         (tui_free_all_source_wins_content): Update.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-wingeneral.c (tui_win_info::refresh)
1765         (tui_source_window_base::refresh): New methods.
1766         (tui_refresh_all): Call the refresh method.
1767         * tui/tui-data.h (struct tui_win_info)
1768         (struct tui_source_window_base) <refresh>: New method.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui.h (tui_is_window_visible): Return bool.
1773         * tui/tui.c (tui_is_window_visible): Return bool.
1774         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1775         (tui_make_visible, tui_make_invisible)
1776         (tui_win_info::make_visible)
1777         (tui_source_window_base::make_visible, make_all_visible)
1778         (tui_make_all_visible, tui_make_all_invisible): Update.
1779         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1780         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1781         bool.
1782         (struct tui_win_info, struct tui_source_window_base)
1783         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1784         * tui/tui-data.c (tui_init_generic_part): Update.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1789         (tui_source_window_base::make_visible): New methods.
1790         (make_all_visible): Make method call.
1791         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1792         (struct tui_source_window_base, struct tui_cmd_window): Override
1793         make_visible.
1794         (tui_win_is_source_type): Don't declare.
1795         * tui/tui-data.c (tui_win_is_source_type): Remove.
1796
1797 2019-06-25  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1800         NULL check.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1805         Inline constructor.  Add initializers for members.
1806         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1807         constructors; now inline in class.
1808
1809 2019-06-25  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-regs.c (tui_show_registers): Update.
1812         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1813         bool.
1814         * tui/tui-data.c (tui_data_window::clear_detail)
1815         (tui_data_window): Update.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-windata.c (tui_display_all_data)
1820         (tui_display_data_from_line, tui_display_data_from)
1821         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1822         Update.
1823         * tui/tui-regs.c (tui_last_regs_line_no)
1824         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1825         (tui_show_registers, tui_show_register_group)
1826         (tui_display_registers_from, tui_display_reg_element_at_line)
1827         (tui_display_registers_from_line, tui_check_register_values)
1828         (tui_reg_next, tui_reg_prev): Update.
1829         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1830         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1831         tui_data_window.
1832         (struct tui_win_info) <detail>: Remove.  Add new fields from
1833         tui_data_info.
1834         (TUI_DATA_WIN): Add cast.
1835         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1836         (~tui_data_window): Simplify.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-layout.c (show_source_disasm_command)
1841         (show_source_or_disasm_and_command): Update.
1842         * tui/tui-io.c (update_cmdwin_start_line)
1843         (tui_redisplay_readline): Update.
1844         * tui/tui-data.h (struct tui_command_info): Remove.
1845         (struct tui_win_info) <detail>: Remove command_info member.
1846         (struct tui_data_window) <start_line>: New member, from
1847         tui_command_info.
1848         (TUI_CMD_WIN): Add casts.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.c (tui_update_source_window)
1853         (tui_refill_source_window)
1854         (tui_source_window_base::do_scroll_horizontal)
1855         (tui_update_breakpoint_info, tui_set_exec_info_content)
1856         (tui_show_exec_info_content, tui_erase_exec_info_content)
1857         (tui_clear_exec_info_content): Update.
1858         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1859         Update.
1860         * tui/tui-win.c (make_invisible_and_set_new_height)
1861         (make_visible_with_new_height): Update.
1862         * tui/tui-source.c (tui_set_source_content)
1863         (tui_show_symtab_source): Update.
1864         * tui/tui-layout.c (extract_display_start_addr)
1865         (show_source_disasm_command, show_data)
1866         (make_source_or_disasm_window)
1867         (show_source_or_disasm_and_command): Update.
1868         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1869         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1870         "gdbarch".
1871         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1872         to tui_source_window_base.
1873         (struct tui_win_info) <detail>: Remove source_info member.
1874         (struct tui_source_window_base) <has_locator>: Inline.
1875         Move contents from tui_source_info; rename has_locator member to
1876         m_has_locator.
1877         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1878         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1879         header file.
1880         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1881         Simplify.
1882         (tui_free_all_source_wins_content): Cast to
1883         tui_source_window_base.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-win.c (make_invisible_and_set_new_height)
1888         (make_visible_with_new_height): Call has_locator method.
1889         * tui/tui-layout.c (show_source_disasm_command, show_data)
1890         (show_source_or_disasm_and_command): Update for bool change.
1891         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1892         (tui_win_info) <has_locator>: New method.
1893         (struct tui_source_window_base) <has_locator>: New method.
1894         (tui_win_has_locator): Don't declare.
1895         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1896         from tui_win_has_locator.
1897         (tui_source_window_base): Use false, not FALSE.
1898
1899 2019-06-25  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1902         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1903         clear_detail method directly.
1904         (tui_clear_win_detail): Remove.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1909         "this", not TUI_DISASM_WIN.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1914         declare.
1915         * tui/tui-winsource.c
1916         (tui_source_window_base::do_scroll_horizontal): Rename from
1917         tui_horizontal_source_scroll.
1918         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1919         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1920         from tui_vertical_data_scroll.
1921         * tui/tui-win.h (tui_scroll): Don't declare.
1922         * tui/tui-win.c (tui_win_info::forward_scroll)
1923         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1924         (tui_win_info::right_scroll): Rename and update.
1925         (tui_scroll_forward_command, tui_scroll_backward_command)
1926         (tui_scroll_left_command, tui_scroll_right_command): Update.
1927         (tui_scroll): Remove.
1928         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1929         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1930         from tui_vertical_source_scroll.
1931         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1932         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1933         from tui_vertical_disassem_scroll.
1934         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1935         do_scroll_horizontal>: New methods.
1936         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1937         Likewise.
1938         (struct tui_source_window_base): Add do_scroll_horizontal.
1939         (struct tui_source_window, struct tui_disasm_window): Add
1940         do_scroll_vertical.
1941         (struct tui_data_window, struct tui_cmd_window): Add
1942         do_scroll_horizontal and do_scroll_vertical.
1943         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-data.h (struct tui_source_window_base): New struct.
1948         (struct tui_source_window): Derive from tui_source_window_base.
1949         (struct tui_disasm_window): New struct.
1950         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1951         from tui_source_window::clear_detail.
1952         (tui_source_window_base): Rename from tui_source_window.
1953         (~tui_source_window_base): Rename from ~tui_source_window.
1954         (tui_alloc_win_info): Create a tui_disasm_window.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-data.h (struct tui_source_window)
1959         (struct tui_data_window): Declare destructors.
1960         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1961         destructors.
1962         (tui_win_info): Simplify.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-winsource.c (tui_display_main)
1967         (tui_update_source_windows_with_addr)
1968         (tui_update_all_breakpoint_info): Update.
1969         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1970         (new_height_ok, parse_scrolling_args): Update.
1971         * tui/tui-stack.c (tui_show_frame_info): Update.
1972         * tui/tui-data.h (struct tui_list): Remove.
1973         (tui_source_windows): Return a reference to a std::vector.
1974         * tui/tui-data.c (source_windows): Now a std::vector.
1975         (tui_source_windows): Change return type.
1976         (tui_clear_source_windows): Rewrite.
1977         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1978         (tui_free_all_source_wins_content): Rewrite.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1983         (struct tui_data_window, struct tui_cmd_window): Declare
1984         clear_detail method.
1985         * tui/tui-data.c (tui_source_window::clear_detail)
1986         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1987         methods.
1988         (tui_clear_win_detail): Simplify.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-layout.c (make_source_window, make_disasm_window)
1993         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1994         Return the new window.
1995         (show_source_disasm_command, show_data)
1996         (show_source_or_disasm_and_command): Update.
1997
1998 2019-06-25  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2001         parameter.  Return the new window.
2002         (show_source_disasm_command): Update and remove NULL check.
2003         (show_source_or_disasm_and_command): Update.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-data.h (struct tui_win_info): Make constructor
2012         protected.  Make destructor virtual.  Add initializers.
2013         (tui_source_window, tui_data_window, tui_cmd_window): New
2014         classes.
2015         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2016         constructor.  Add "type" parameter.
2017         (tui_source_window, tui_data_window, tui_cmd_window): New
2018         constructors.
2019         (tui_alloc_win_info): Instantiate the appropriate subclass.
2020
2021 2019-06-25  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-win.c (tui_resize_all): Use delete.
2024         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2025         destructor.
2026         (tui_free_window): Don't declare.
2027         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2028         Update.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-data.h (struct tui_win_info): Add constructor.
2033         * tui/tui-data.c (tui_alloc_win_info): Use new.
2034         (tui_free_window): Use delete.
2035
2036 2019-06-22  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2039         declare.
2040         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2041
2042 2019-06-22  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2045         declare.
2046         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2047
2048 2019-06-22  Tom de Vries  <tdevries@suse.de>
2049
2050         * dwarf2read.c (create_addrmap_from_aranges)
2051         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2052         instead of '%zu'.
2053
2054 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2055
2056         * dwarf2read.h (dwarf2_section_info_def): Remove.
2057         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2058         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2059         std::vector<dwarf2_section_info>.
2060         (struct dwo_file) <~dwo_file>: Remove.
2061         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2062         types field.
2063         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2064         (dwarf2_read_debug_names): Likewise.
2065         (create_debug_types_hash_table): Change parameter type to
2066         array_view, adjust code accordingly.
2067         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2068         (partial_die_info::fixup): Likewise.
2069         (determine_prefix): Likewise.
2070         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2071
2072 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2073
2074         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2075         gdb_bfd_ref_ptr.
2076         <~dwo_file>: Remove call to gdb_bfd_unref.
2077         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2078         gdb_bfd_ref_ptr::get.
2079
2080 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2081
2082         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2083         type to htab_up.
2084         * dwarf2read.c (struct dwo_file): Initialize fields.
2085         <~dwo_file>: New.
2086         (free_dwo_file): Remove, move content to ~dwo_file.
2087         (struct dwo_file_deleter): Remove.
2088         (dwo_file_up>: Remove custom deleter.
2089         (free_dwo_files): Remove.
2090         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2091         dwo_files.
2092         (process_skeletonless_type_units): Call unique_ptr::get.
2093         (allocate_dwo_file_hash_table): Add deleter to created hash
2094         table.  Change return type to htab_up.
2095         (lookup_dwo_file_slot): Don't memset dwo_file, call
2096         unique_ptr::get.
2097         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2098         (create_dwo_unit_in_dwp_v2): Likewise.
2099         (open_and_init_dwo_file): Likewise.
2100         (free_dwo_file_from_slot): Remove.
2101
2102 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2103
2104         * dwarf2read.h (struct dwarf2_section_info) <readin,
2105         is_virtual>: Change type to bool.
2106         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2107         true instead of 1.
2108
2109 2019-06-19  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-data.h (tui_init_content_element): Don't declare.
2112
2113 2019-06-19  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-data.h (tui_init_win_info): Don't declare.
2116
2117 2019-06-19  Tom de Vries  <tdevries@suse.de>
2118
2119         * dwarf2read.h (abstract_to_concrete): Change type to
2120         std::unordered_map<sect_offset, std::vector<sect_offset>,
2121         gdb::hash_enum<sect_offset>>.
2122
2123 2019-06-19  Tom Tromey  <tromey@adacore.com>
2124
2125         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2126         EVAL_AVOID_SIDE_EFFECTS specially.
2127
2128 2019-06-19  Tom Tromey  <tromey@adacore.com>
2129
2130         * source-cache.c (highlighter): New global.
2131         (source_cache::get_source_lines): Create a highlighter on demand.
2132
2133 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * defs.h (deprecated_interactive_hook): Delete declaration.
2136         * interps.c (clear_interpreter_hooks): Remove use of
2137         deprecated_interactive_hook.
2138         * top.c (deprecated_interactive_hook): Delete definition.
2139         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2140
2141 2019-06-18  Tom de Vries  <tdevries@suse.de>
2142
2143         PR gdb/24515
2144         * dwarf2read.h (abstract_to_concrete): Change type from
2145         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2146         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2147         * dwarf2read.c (read_variable): Update.
2148         (dwarf2_fetch_die_loc_sect_off): Update.
2149
2150 2019-06-17  Tom de Vries  <tdevries@suse.de>
2151
2152         PR gdb/24617
2153         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2154         accessing parent[parent_len - 1].
2155
2156 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2157
2158         PR gdb/24364
2159         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2160         call dtrace_process_dof with NULL dof.
2161
2162 2019-06-16  Tom de Vries  <tdevries@suse.de>
2163
2164         PR gdb/24445
2165         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2166
2167 2019-06-16  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2170         (make_all_visible): Use address of member.
2171
2172 2019-06-16  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2175         (tui_free_window, free_content, free_content_elements): Remove
2176         unnecessary cast.
2177         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2178         cast.
2179         * tui/tui-regs.c (tui_show_register_group)
2180         (tui_display_registers_from, tui_display_reg_element_at_line):
2181         Remove unnecessary cast.
2182
2183 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * linux-nat.c (normal_mask): Delete.
2186         (_initialize_linux_nat): Don't initialise normal_mask.
2187
2188 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         PR gdb/24445
2191         * dwarf-index-write.h (write_psymtabs_to_index): Add
2192         dwz_basename parameter.
2193         * dwarf-index-write.c (write_gdbindex): Move file writing to
2194         write_gdbindex_1.  Change return type void.
2195         (assert_file_size): Move up, remove filename parameter.
2196         (write_gdbindex_1): New function.
2197         (write_debug_names): Change return type to void, call
2198         assert_file_size.
2199         (struct index_wip_file): New struct.
2200         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2201         file logic to index_wip_file.  Write index for dwz file if
2202         needed.
2203         (save_gdb_index_command): Pass basename of dwz file, if present.
2204         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2205         build-id of dwz file, if present.
2206         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2207         (dwarf2_get_dwz_file): Likewise.
2208         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2209         (dwarf2_get_dwz_file): Likewise.
2210
2211 2019-06-16  Tom Tromey  <tom@tromey.com>
2212
2213         * coffread.c (process_coff_symbol): Use xstrdup.
2214         * value.c (create_internalvar): Use xstrdup.
2215
2216 2019-06-16  Tom Tromey  <tom@tromey.com>
2217
2218         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2219         * breakpoint.c (stopin_command, stopat_command)
2220         (until_break_command, decode_location_default): Remove unnecessary
2221         cast.
2222         * utils.c (subset_compare): Remove unnecessary cast.
2223         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2224         cast.
2225         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2226         cast.
2227         * infcmd.c (path_command): Remove unnecessary cast.
2228         * coffread.c (decode_type): Remove unnecessary cast.
2229         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2230         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2231         * tui/tui-stack.c (tui_show_locator_content)
2232         (tui_show_frame_info): Remove unnecessary cast.
2233         * tui/tui-win.c (tui_scroll_forward_command)
2234         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2235         (parse_scrolling_args): Remove unnecessary cast.
2236         * tui/tui-data.c (init_win_info, tui_del_window)
2237         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2238         (free_content_elements): Remove unnecessary cast.
2239         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2240         unnecessary cast.
2241         * tui/tui-source.c (tui_set_source_content)
2242         (tui_vertical_source_scroll): Remove unnecessary cast.
2243         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2244         cast.
2245         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2246         * tui/tui-regs.c (tui_display_registers_from)
2247         (tui_display_register): Remove unnecessary cast.
2248         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2249         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2250         (make_visible): Remove unnecessary cast.
2251         * tui/tui-winsource.c (tui_erase_source_content)
2252         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2253         unnecessary cast.
2254         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2255         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2256         * stabsread.c (read_type, read_array_type, read_range_type):
2257         Remove unnecessary cast.
2258         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2259         (parse_symbol, parse_type, upgrade_type, parse_external)
2260         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2261         unnecessary cast.
2262         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2263
2264 2019-06-16  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-data.c (tui_alloc_generic_win_info)
2267         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2268         checks.
2269
2270 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2271             Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * f-typeprint.c (f_print_type): Don't return early for not
2274         associated or not allocated types.
2275         (f_type_print_varspec_suffix): Add print_rank parameter and print
2276         ranks of array types in case they dangling.
2277         (f_type_print_base): Add print_rank parameter.
2278
2279 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * NEWS: Mention new MI commands.
2282         * break-catch-throw.c (enum exception_event_kind): Move to
2283         breakpoint.h.
2284         (print_mention_exception_catchpoint): Output text as a single
2285         message.
2286         (catch_exception_command_1): Rename to...
2287         (catch_exception_event): ...this, make non-static, update header
2288         command, and change some parameter types.
2289         (catch_catch_command): Update for changes to
2290         catch_exception_command_1.
2291         (catch_throw_command): Likewise.
2292         (catch_rethrow_command): Likewise.
2293         * breakpoint.c (enum exception_event_kind): Delete.
2294         * breakpoint.h (enum exception_event_kind): Moved here from
2295         break-catch-throw.c.
2296         (catch_exception_event): Declare.
2297         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2298         (mi_cmd_catch_throw): New function.
2299         (mi_cmd_catch_rethrow): New function.
2300         (mi_cmd_catch_catch): New function.
2301         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2302         'catch-catch' entries.
2303         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2304         (mi_cmd_catch_rethrow): Declare.
2305         (mi_cmd_catch_catch): Declare.
2306
2307 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * annotate.c (annotate_source_line): Change return type to void,
2310         update implementation to match.
2311         * annotate.h (annotate_source_line): Change return type to void,
2312         update header comment.
2313         * stack.c (print_frame_info): Don't change what frame information
2314         is printed based on whether annotations are on or not.
2315
2316 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2319         (annotate_source): Make static.
2320         (annotate_source_line): Moved from source.c and renamed from
2321         identify_source_line.  Update the return type.
2322         * annotate.h (annotate_source): Delete declaration.
2323         (annotate_source_line): Declaration moved from source.h, and
2324         renamed from identify_source_line.  Return type updated.
2325         * source.c (identify_source_line): Moved to annotate.c and renamed
2326         to annotate_source_line.
2327         (info_line_command): Remove check of annotation_level.
2328         * source.h (identify_source_line): Move declaration to annotate.h
2329         and rename to annotate_source_line.
2330         * stack.c: Add 'annotate.h' include.
2331         (print_frame_info): Remove check of annotation_level before
2332         calling annotate_source_line.
2333
2334 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * source-cache.c (source_cache::get_plain_source_lines): Use
2337         open_source_file_with_line_charpos instead of just
2338         open_source_file, remove call to find_source_lines.
2339         (source_cache::get_source_lines): Likewise.
2340         * source.c (find_source_lines): Make static.
2341         (get_filename_and_charpos): Renamed into...
2342         (open_source_file_with_line_charpos): ..this along with changes to
2343         return a scoped_fd, and some other minor clean ups.
2344         (identify_source_line): Use open_source_file_with_line_charpos.
2345         (search_command_helper): Use open_source_file_with_line_charpos
2346         instead of just open_source_file, remove call to
2347         find_source_lines.
2348         * source.h (open_source_file_with_line_charpos): Declare new
2349         function.
2350         (find_source_lines): Delete declaration.
2351
2352 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2353
2354         * source.c (get_filename_and_charpos): Remove fullname
2355         parameter.
2356         (identify_source_line): Update call to get_filename_and_charpos.
2357
2358 2019-06-14  Tom Tromey  <tromey@adacore.com>
2359
2360         PR gdb/24502:
2361         * ui-style.h (skip_ansi_escape): Update comment.
2362         * ui-file.h (class no_terminal_escape_file): New class.
2363         * ui-file.c (no_terminal_escape_file::write)
2364         (no_terminal_escape_file::puts): New methods.
2365         * cli/cli-logging.c (handle_redirections): Use
2366         no_terminal_escape_file.
2367
2368 2019-06-14  Tom Tromey  <tromey@adacore.com>
2369
2370         * NEWS: Move convenience variable news above Python news.
2371
2372 2019-06-14  Tom Tromey  <tom@tromey.com>
2373
2374         * gnulib: Move directory to top-level.
2375         * configure.ac: Don't configure gnulib.
2376         * configure: Rebuild.
2377         * common/common-defs.h: Use new path to gnulib.
2378         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2379         (GNULIB_H): Remove.
2380         (INCGNU): Look in new gnulib location.
2381         (HFILES_NO_SRCDIR): Remove gnulib files.
2382         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2383         (generated_files): Remove GNULIB_H.
2384         ($(LIBGNU), all-lib): Remove targets.
2385         (distclean): Don't mention GNULIB_BUILDDIR.
2386         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2387
2388 2019-06-14  Tom Tromey  <tromey@adacore.com>
2389
2390         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2391         Warn if symbol file does not provide any symbols.
2392
2393 2019-06-14  Tom Tromey  <tromey@adacore.com>
2394
2395         * source.c (find_and_open_source): Respect basenames_may_differ.
2396
2397 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2398
2399         * annotate.c (annotate_breakpoints_invalid): Make use of
2400         scoped_restore_terminal_state.
2401         (annotate_frames_invalid): Likewise.
2402
2403 2019-06-14  Tom Tromey  <tromey@adacore.com>
2404
2405         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2406         allow assignment to an internalvar.
2407
2408 2019-06-14  Tom Tromey  <tromey@adacore.com>
2409
2410         * ada-lex.l: Allow "_" in attribute names.
2411
2412 2019-06-14  Tom Tromey  <tromey@adacore.com>
2413
2414         PR gdb/24653:
2415         * regcache.c (registers_changed): Don't call alloca.
2416         * top.c (execute_command): Don't call alloca.
2417
2418 2019-06-13  Pedro Alves  <palves@redhat.com>
2419
2420         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2421         'expression'.  When parsing an expression, error out if there's
2422         junk after "unlimited".
2423         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2424         (do_set_command): Adjust calls to is_unlimited_literal.
2425
2426 2019-06-13  Pedro Alves  <palves@redhat.com>
2427
2428         * compile/compile.c (make_compile_options_def_group): Add braces
2429         around array_view initializer.
2430         * thread.c (make_thread_apply_all_options_def_group)
2431         (make_thread_apply_all_options_def_group): Likewise.
2432
2433 2019-06-13  Pedro Alves  <palves@redhat.com>
2434
2435         * NEWS (New commands): Mention "maint test-options
2436         require-delimiter", "maint test-options unknown-is-error", "maint
2437         test-options unknown-is-operand" and "maint show
2438         test-options-completion-result".
2439         (New command options, command completion): New section.
2440         (Completion improvements): New section.
2441         Mention that you can abbreviate "unlimited".
2442
2443 2019-06-13  Pedro Alves  <palves@redhat.com>
2444
2445         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2446         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2447         * unittests/cli-utils-selftests.c (test_parse_flags)
2448         (test_parse_flags_qcs): Delete.
2449         (test_cli_utils): Don't call deleted functions.
2450
2451 2019-06-13  Pedro Alves  <palves@redhat.com>
2452
2453         * thread.c: Include "cli/cli-option.h".
2454         (tp_array_compar_ascending): Global.
2455         (tp_array_compar): Delete function.
2456         (tp_array_compar_ascending, tp_array_compar_descending): New
2457         functions.
2458         (ascending_option_def, qcs_flag_option_def)
2459         (thr_qcs_flags_option_defs)
2460         (make_thread_apply_all_options_def_group)
2461         (make_thread_apply_options_def_group): New.
2462         (thread_apply_all_command): Use gdb::option::process_options.
2463         (thread_apply_command_completer)
2464         (thread_apply_all_command_completer): New.
2465         (thread_apply_command): Use gdb::option::process_options.
2466         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2467         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2468         to generate help text of "thread apply".  Adjust "taas"'s help.
2469         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2470         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2471
2472 2019-06-13  Pedro Alves  <palves@redhat.com>
2473
2474         * thread.c (thread_apply_command): Check for invalid TID with
2475         isdigit instead of !isalpha.
2476
2477 2019-06-13  Pedro Alves  <palves@redhat.com>
2478
2479         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2480         (validate_flags_qcs): New.
2481         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2482         (validate_flags_qcs): Declare.
2483         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2484         (make_frame_apply_options_def_group): New.
2485         (frame_apply_command_count): Process options with
2486         gdb::option::process_options.
2487         (frame_apply_completer): New.
2488         (frame_apply_level_completer, frame_apply_all_completer)
2489         (frame_apply_completer): New.
2490         (_initialize_stack): Update help of "frame apply", "frame apply
2491         level", "frame apply all" and "faas" to mention supported options
2492         and install command completers.
2493         * stack.h (frame_apply_all_completer): Declare.
2494         * thread.c: Include "stack.h".
2495         (tfaas_command): Add "--".
2496         (_initialize_thread): Update help "tfaas" to mention supported
2497         options and install command completer.
2498
2499 2019-06-13  Pedro Alves  <palves@redhat.com>
2500
2501         * completer.c (complete_nested_command_line): New.
2502         (gdb_completion_word_break_characters_throw): Add assertion.
2503         * completer.h (complete_nested_command_line): Declare.
2504
2505 2019-06-13  Pedro Alves  <palves@redhat.com>
2506
2507         * stack.c (parse_backtrace_qualifiers): New.
2508         (backtrace_command): Use it.
2509         (backtrace_command_completer): Complete on qualifiers.
2510
2511 2019-06-13  Pedro Alves  <palves@redhat.com>
2512
2513         * frame.c: Include "cli/cli-option.h.
2514         (user_set_backtrace_options): New.
2515         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2516         Delete.
2517         (get_prev_frame): Adjust.
2518         (boolean_option_def, uinteger_option_def)
2519         (set_backtrace_option_defs): New.
2520         (_initialize_frame): Adjust and use
2521         gdb::option::add_setshow_cmds_for_options to install "set
2522         backtrace past-main" and "set backtrace past-entry".
2523         * frame.h: Include "cli/cli-option.h".
2524         (struct frame_print_options): Forward declare.
2525         (print_frame_arguments_all, print_frame_arguments_scalars)
2526         (print_frame_arguments_none): Declare.
2527         (print_entry_values): Delete declaration.
2528         (struct frame_print_options, user_frame_print_options): New.
2529         (struct set_backtrace_options): New.
2530         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2531         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2532         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2533         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2534         (list_args_or_locals): Add frame_print_options parameter.
2535         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2536         * python/py-framefilter.c (enumerate_args): Pass down
2537         USER_FRAME_PRINT_OPTIONS.
2538         * stack.c: Include "cli/cli-option.h".
2539         (print_frame_arguments_all, print_frame_arguments_scalars)
2540         (print_frame_arguments_none): Declare.
2541         (print_raw_frame_arguments, print_entry_values): Delete.
2542         (user_frame_print_options): New.
2543         (boolean_option_def, enum_option_def, frame_print_option_defs):
2544         New.
2545         (struct backtrace_cmd_options): New.
2546         (bt_flag_option_def): New.
2547         (backtrace_command_option_defs): New.
2548         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2549         (print_frame_arg, read_frame_arg, print_frame_args)
2550         (print_frame_info, print_frame): Add frame_print_options parameter
2551         and use it.
2552         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2553         (backtrace_command_1): Add frame_print_options and
2554         backtrace_cmd_options parameters and use them.
2555         (make_backtrace_options_def_group): New.
2556         (backtrace_command): Process command options with
2557         gdb::option::process_options.
2558         (backtrace_command_completer): New.
2559         (_initialize_stack): Extend "backtrace"'s help to mention
2560         supported options.  Install completer for "backtrace".
2561         Install some settings commands with add_setshow_cmds_for_options.
2562
2563 2019-06-13  Pedro Alves  <palves@redhat.com>
2564
2565         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2566         and that "set/show print raw frame-arguments" are now deprecated.
2567
2568         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2569         command.
2570         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2571         * stack.c (_initialize_stack): Install "set/show print
2572         raw-frame-arguments", and deprecate "set/show print raw
2573         frame-arguments".
2574         * valprint.c (_initialize_valprint): Deprecate "set/show print
2575         raw".
2576
2577 2019-06-13  Pedro Alves  <palves@redhat.com>
2578
2579         * compile/compile.c (struct compile_options): New.
2580         (compile_flag_option_def, compile_command_option_defs)
2581         (make_compile_options_def_group): New.
2582         (compile_file_command): Handle options with
2583         gdb::option::process_options.
2584         (compile_file_command_completer): New function.
2585         (compile_code_command): Handle options with
2586         gdb::option::process_options.
2587         (compile_code_command_completer): New function.
2588         (_initialize_compiler): Install completers for "compile code" and
2589         "compile file".  Mention available options in "compile code" and
2590         "compile code"'s help.
2591         * completer.c (advance_to_completion_word): New, factored out from
2592         ...
2593         (advance_to_expression_complete_word_point): ... this.
2594         (advance_to_filename_complete_word_point): New.
2595         * completer.h (advance_to_filename_complete_word_point): New
2596         declaration.
2597
2598 2019-06-13  Pedro Alves  <palves@redhat.com>
2599
2600         * compile/compile.c: Include "cli/cli-option.h".
2601         (compile_print_value): Scope data pointer is now a
2602         value_print_options pointer; adjust.
2603         (compile_print_command): Process options.  Scope data pointer is
2604         now a value_print_options pointer; adjust.
2605         (_initialize_compile): Update "compile print"'s help to include
2606         supported options.  Install a completer for "compile print".
2607         * cp-valprint.c (show_vtblprint, show_objectprint)
2608         (show_static_field_print): Delete.
2609         (_initialize_cp_valprint): Don't install "set print
2610         static-members", "set print vtbl", "set print object" here.
2611         * printcmd.c: Include "cli/cli-option.h" and
2612         "common/gdb_optional.h".
2613         (print_command_parse_format): Rework to fill in a
2614         value_print_options instead of a format_data.
2615         (print_value): Change parameter type from format_data pointer to
2616         value_print_options reference.  Adjust.
2617         (print_command_1): Process options.  Adjust to pass down a
2618         value_print_options.
2619         (print_command_completer): New.
2620         (_initialize_printcmd): Install print_command_completer as
2621         handle_brkchars completer for the "print" command.  Update
2622         "print"'s help to include supported options.
2623         * valprint.c: Include "cli/cli-option.h".
2624         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2625         here from cp-valprint.c.
2626         (boolean_option_def, uinteger_option_def)
2627         (value_print_option_defs, make_value_print_options_def_group):
2628         New.  Use gdb::option::add_setshow_cmds_for_options to install
2629         "set print elements", "set print null-stop", "set print repeats",
2630         "set print pretty", "set print union", "set print array", "set
2631         print address", "set print symbol", "set print array-indexes".
2632         * valprint.h: Include <string> and "cli/cli-option.h".
2633         (make_value_print_options_def_group): Declare.
2634         (print_value): Change parameter type from format_data pointer to
2635         value_print_options reference.
2636         (print_command_completer): Declare.
2637
2638 2019-06-13  Pedro Alves  <palves@redhat.com>
2639
2640         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2641         (COMMON_SFILES): Add maint-test-settings.c.
2642         * cli/cli-decode.c (boolean_enums): New global, factored out from
2643         ...
2644         (add_setshow_boolean_cmd): ... here.
2645         * cli/cli-decode.h (boolean_enums): Declare.
2646         * cli/cli-option.c: New file.
2647         * cli/cli-option.h: New file.
2648         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2649         factored out from ...
2650         (parse_cli_boolean_value(const char *)): ... this.
2651         (is_unlimited_literal): Change parameter type to pointer to
2652         pointer.  Adjust and advance ARG pointer.
2653         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2654         (parse_cli_var_enum): New, factored out from ...
2655         (do_set_command): ... this.  Adjust.
2656         * cli/cli-setshow.h (parse_cli_boolean_value)
2657         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2658         (parse_cli_var_enum): Declare.
2659         * cli/cli-utils.c: Include "cli/cli-option.h".
2660         (get_ulongest): New.
2661         * cli/cli-utils.h (get_ulongest): Declare.
2662         (check_for_argument): New overloads.
2663         * maint-test-options.c: New file.
2664
2665 2019-06-13  Pedro Alves  <palves@redhat.com>
2666
2667         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2668         parse a range if "-" is at the end of the string.
2669
2670 2019-06-13  Pedro Alves  <palves@redhat.com>
2671
2672         * cli/cli-setshow.c (parse_auto_binary_operation)
2673         (parse_cli_boolean_value): Don't allow "o".
2674
2675 2019-06-13  Pedro Alves  <palves@redhat.com>
2676
2677         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2678         * NEWS: Mention maint test-settings KIND.
2679         * maint-test-settings.c: New file.
2680
2681 2019-06-13  Pedro Alves  <palves@redhat.com>
2682
2683         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2684         completer.
2685         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2686         "set" completers.
2687
2688 2019-06-13  Pedro Alves  <palves@redhat.com>
2689
2690         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2691         after item.
2692
2693 2019-06-13  Pedro Alves  <palves@redhat.com>
2694
2695         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2696
2697 2019-06-13  Pedro Alves <palves@redhat.com>
2698
2699         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2700         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2701         call.
2702         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2703         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2704         calls.
2705         (check_for_argument): Skip spaces after argument.
2706
2707 2019-06-13  Pedro Alves  <palves@redhat.com>
2708
2709         * thread.c (thread_apply_command): Adjust TID parsing.
2710         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2711         detected before end of string.
2712         (tid_is_in_list): Error out if LIST is invalid.
2713
2714 2019-06-13  Pedro Alves  <palves@redhat.com>
2715
2716         * completer.c (complete_line_internal_1): Rewind completion word
2717         point.
2718         (completion_tracker::advance_custom_word_point_by): Change
2719         parameter type to int.
2720         * completer.h (completion_tracker::advance_custom_word_point_by):
2721         Likewise.
2722
2723 2019-06-13  Pedro Alves  <palves@redhat.com>
2724
2725         * completer.c (advance_to_completion_word): Handle delimiters.
2726
2727 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2728
2729         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2730
2731 2019-06-11  Tom Tromey  <tom@tromey.com>
2732
2733         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2734         (xmalloc_failed): Move to alloc.c.
2735         * alloc.c: New file.
2736         * Makefile.in (COMMON_SFILES): Add alloc.c.
2737
2738 2019-06-11  Tom Tromey  <tom@tromey.com>
2739
2740         * nat/linux-waitpid.c: Don't include server.h.
2741         (linux_debug): Remove.
2742         (my_waitpid): Update.
2743
2744 2019-06-11  Tom Tromey  <tromey@adacore.com>
2745
2746         * infcall.c (_initialize_infcall): Remove trailing newline from
2747         help.
2748         * user-regs.c (_initialize_user_regs): Remove trailing newline
2749         from help.
2750         * typeprint.c (_initialize_typeprint): Remove trailing newline
2751         from help.
2752         * reverse.c (_initialize_reverse): Remove trailing newlines from
2753         help.
2754         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2755         from help.
2756         * language.c (add_set_language_command): Remove trailing newline
2757         from help.
2758         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2759         help.
2760         * disasm.c (_initialize_disasm): Remove trailing newline from
2761         help.
2762         * top.c (init_main): Remove trailing newline from help.
2763         * interps.c (_initialize_interpreter): Remove trailing newline
2764         from help.
2765         * btrace.c (_initialize_btrace): Remove trailing newlines from
2766         help.
2767         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2768         from help.
2769         * python/python.c (_initialize_python): Remove trailing newline
2770         from help.
2771         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2772         help.
2773         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2774         from help.  Reformat some text.
2775         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2776         from help.
2777         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2778         newline from help.
2779
2780 2019-06-11  Tom Tromey  <tromey@adacore.com>
2781
2782         * darwin-nat.c (darwin_decode_exception_message)
2783         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2784
2785 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * valops.c (value_slice): Check for not allocated or not
2788         associated values.
2789
2790 2019-06-10  Tom de Vries  <tdevries@suse.de>
2791
2792         PR gdb/24618
2793         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2794         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2795         invalid.
2796
2797 2019-06-10  Tom de Vries  <tdevries@suse.de>
2798
2799         PR gdb/24611
2800         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2801         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2802
2803 2019-06-10  Tom de Vries  <tdevries@suse.de>
2804
2805         PR symtab/24545
2806         * symtab.c (struct demangled_name_entry): Add language field.
2807         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2808         static minimal symbol".  Set and use language field.
2809
2810 2019-06-10  Tom Tromey  <tromey@adacore.com>
2811
2812         * ada-lang.c (_initialize_ada_language): Update help text.
2813
2814 2019-06-10  Tom Tromey  <tromey@adacore.com>
2815
2816         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2817         with a newline.
2818         * guile/guile.c (handle_boot_error): Don't end warning with a
2819         newline.
2820         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2821         warning with a newline.
2822         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2823         newline.
2824         (s12z_frame_cache): Likewise.
2825         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2826         a newline.
2827         * solib-svr4.c (disable_probes_interface): Don't end warning with
2828         a newline.
2829         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2830         newline.
2831         * python/python.c (do_finish_initialization): Don't end warning
2832         with a newline.
2833
2834 2019-06-10  Tom Tromey  <tom@tromey.com>
2835
2836         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2837         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2838         gdbpy_enter.
2839
2840 2019-06-10  Tom Tromey  <tromey@adacore.com>
2841
2842         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2843         data.
2844         (elf_new_init): Don't call stabsread_new_init.
2845         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2846         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2847         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2848
2849 2019-06-10  Tom de Vries  <tdevries@suse.de>
2850
2851         PR symtab/16264
2852         PR symtab/24517
2853         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2854
2855 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2856
2857         * source.c (find_and_open_source): Also rewrite relative file
2858         names.
2859
2860 2019-04-26  Amos Bird  <amosbird@gmail.com>
2861
2862         * annotate.c (annotate_thread_exited): Add "thread-exited"
2863         annotation.
2864
2865 2019-06-06  Tom Tromey  <tromey@adacore.com>
2866
2867         * maint.h (class scoped_command_stats): Use
2868         DISABLE_COPY_AND_ASSIGN.
2869         <print_time>: New method.
2870         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2871         print_time.
2872         (scoped_command_stats::print_time): New method.
2873
2874 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2877         instructions of lengths 6 or 8 bytes.
2878
2879 2019-06-04  Pedro Alves  <palves@redhat.com>
2880
2881         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2882
2883         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2884         * breakpoint.c (condition_completer): Likewise.
2885         * cli/cli-dump.c (scan_expression): Likewise.
2886         * common/filestuff.c (mkdir_recursive): Likewise.
2887         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2888         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2889         (gdb_abspath): Likewise.
2890         * compile/compile-cplus-types.c
2891         (compile_cplus_instance::decl_name): Likewise.
2892         * completer.c (complete_explicit_location):
2893         (signal_completer, reg_or_group_completer_1): Likewise.
2894         * cp-support.c (cp_remove_params_if_any): Likewise.
2895         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2896         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2897         * infcmd.c (strip_bg_char): Likewise.
2898         * linespec.c (copy_token_string): Likewise.
2899         * mi/mi-main.c (output_cores): Likewise.
2900         * psymtab.c (psymtab_search_name):
2901         * symfile.c (test_set_ext_lang_command): Likewise.
2902         * target.c (target_fileio_read_stralloc): Likewise.
2903         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2904         * value.c (complete_internalvar): Likewise.
2905
2906 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2907
2908         Add objfile property to gdb.Type.
2909         * NEWS: Mention Python API addition.
2910         * python/py-type.c (typy_get_objfile): New method.
2911
2912 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2913
2914         * NEWS: Mention the new set|show style [title|highlight].
2915         Mention changes to "show style", "help" and "apropos".
2916
2917 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2918
2919         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2920         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2921         instead of print_help_for_command.
2922         (print_doc_of_command): New function.
2923         (help_list): Add 'apropos -v word' suggestion.
2924         (print_help_for_command): Style the command name using title style.
2925         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2926         (_initialize_cli_cmds): Describe -v in apropos_command help.
2927
2928 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2929
2930         * cli/cli-style.h (cli_style_option): Add name in constructor,
2931         add m_name class member, add constructor with intensity,
2932         add name class function.
2933         (cli_style_option::add_setshow_commands): Remove name argument.
2934         (highlight_style, title_style): New styles.
2935         * cli/cli-style.c (do_show): New function that shows a style
2936         characteristic styling the style name with itself.
2937         (set_style_name): New function.
2938         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2939         Update all callers according to the changes in cli/cli-style.h.
2940         * utils.h (fputs_highlighted): New function.
2941         * utils.c (fputs_highlighted): Likewise.
2942
2943 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2944
2945         * NEWS: Mention new pipe command and new convenience variables.
2946
2947 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2948
2949         * cli/cli-cmds.c (pipe_command): New function.
2950         (_initialize_cli_cmds): Call add_com for pipe_command.
2951         Define | as an alias for pipe.
2952         (exit_status_set_internal_vars): New function.
2953         (shell_escape): Call exit_status_set_internal_vars.
2954         cli/cli-decode.c (find_command_name_length): Recognize | as
2955         a single character command.
2956
2957 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2958
2959         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2960         top.c (execute_command_to_ui_file): New function, mostly a copy
2961         of execute_command_to_string.
2962         (execute_command_to_string): Implement by calling
2963         execute_command_to_ui_file.
2964
2965 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2966
2967         * top.h (saved_command_line): Remove declaration.
2968         * top.c (previous_saved_command_line, previous_repeat_arguments):
2969         New variables.
2970         (saved_command_line): Make static, define together with other
2971         'repeat variables'.
2972         (dont_repeat): Clear repeat_arguments.
2973         (repeat_previous, get_saved_command_line, save_command_line):
2974         New functions.
2975         (gdb_init): Initialize saved_command_line
2976         and previous_saved_command_line.
2977         * main.c (captured_main_1): Remove saved_command_line initialization.
2978         * event-top.c (handle_line_of_input): Update to use
2979         the new 'repeat' related functions instead of direct access to
2980         saved_command_line.
2981         * command.h (repeat_previous, get_saved_command_line,
2982         save_command_line): New declarations.
2983         (dont_repeat): Add comment.
2984
2985 2019-05-30  Tom Tromey  <tromey@adacore.com>
2986
2987         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2988         Fix comment.
2989         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2990
2991 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2992
2993         PR cli/24587
2994         * completer.c (complete): Initialize variable word.
2995
2996 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2997
2998         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2999         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3000         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3001         'body' is NULL to the outter 'if', protecting the '!is_define'
3002         situation as well.
3003
3004 2019-05-29  Tom Tromey  <tromey@adacore.com>
3005
3006         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3007         (dwarf_unknown): New function.
3008         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3009         (dwarf_type_encoding_name): Use dwarf_unknown.
3010
3011 2019-05-29  Tom Tromey  <tromey@adacore.com>
3012
3013         PR c++/20020:
3014         * cp-valprint.c (cp_print_value_fields): Call
3015         cp_print_static_field inside "try".
3016
3017 2019-05-29  Tom Tromey  <tromey@adacore.com>
3018
3019         * inflow.c (struct terminal_info): Add default operator=.
3020         * configure: Rebuild.
3021         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3022         -Wdeprecated-copy-dtor, -Wredundant-move.
3023
3024 2019-05-29  Tom Tromey  <tromey@adacore.com>
3025
3026         * NEWS: Add entry.
3027         * infcmd.c (print_return_value_1): Handle finish_print
3028         option.
3029         (show_print_finish): New function.
3030         (_initialize_infcmd): Add "set/show print finish" commands.
3031         * valprint.c (user_print_options): Initialize new member.
3032         * valprint.h (struct value_print_options) <finish_print>: New
3033         member.
3034
3035 2019-05-28  Tom Tromey  <tromey@adacore.com>
3036
3037         * ada-lang.c (ada_remove_Xbn_suffix)
3038         (find_old_style_renaming_symbol)
3039         (parse_old_style_renaming): Remove.
3040         (ada_find_renaming_symbol): Don't call
3041         find_old_style_renaming_symbol.
3042         (ada_is_renaming_symbol): Rename from
3043         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3044         bool.  Now static.
3045         (ada_read_var_value): Update and simplify.
3046         * ada-exp.y (write_var_or_type): Remove old code.
3047
3048 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3049
3050         * event-top.c: Remove include comment.
3051         * inflow.c (class scoped_ignore_sigttou): Move from here...
3052         * inflow.h (class scoped_ignore_sigttou): ...to here.
3053         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3054         * top.c:  Remove include comment.
3055
3056 2019-05-27  Tom Tromey  <tom@tromey.com>
3057
3058         * NEWS: Fix typo.
3059
3060 2019-05-22  Tom Tromey  <tromey@adacore.com>
3061
3062         * target.c (target_follow_exec): Constify parameter.
3063         * target-delegates.c: Rebuild.
3064         * remote.c (remote_target::follow_exec): Constify parameter.
3065         * infrun.c (follow_exec): Constify parameter.
3066         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3067         (target_follow_exec): Likewise.
3068
3069 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3070
3071         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3072         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3073
3074 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * NEWS: Add debugredirect and testsuite sections.
3077
3078 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3079
3080         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3081         target descriptions using exclusively floating point register name
3082         aliases.
3083
3084 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3085
3086         PR gdb/18644:
3087         * f-lang.c (build_fortran_types): Handle the case where
3088         gdbarch_floatformat_for_type returns a nullptr.
3089
3090 2019-05-21  Tom de Vries  <tdevries@suse.de>
3091
3092         PR cli/24587
3093         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3094
3095 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         PR gdb/18644:
3098         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3099         16-byte floats.
3100         * i386-tdep.c (i386_floatformat_for_type): Use
3101         floatformats_ia64_quad for the 16-byte floating point component
3102         within a fortran 32-byte complex number.
3103
3104 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3107         delete default constructor.
3108         (find_partial_die): Update to return const struct.
3109         (partial_die_parent_scope): Move variable declaration into scope
3110         of its use and change its type to auto.
3111         (guess_partial_die_structure_name): Likewise.
3112         (partial_die_info::fixup): Likewise.
3113
3114 2019-05-17  Tom Tromey  <tromey@adacore.com>
3115
3116         * source.c (find_and_open_source): Remove cast.
3117
3118 2019-05-17  Tom Tromey  <tromey@adacore.com>
3119
3120         * annotate.c (annotate_source): Make "filename" const.
3121         * annotate.h (annotate_source): Use const.
3122
3123 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3124
3125         * disasm.c (set_disassembler_options): Send errors to stderr.
3126
3127 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3128
3129         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3130         (cli_interp_base::set_logging): Check debug_redirect.
3131         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3132         * cli/cli-logging.c (debug_redirect): Add static variable.
3133         (pop_output_files): Add default param.
3134         (handle_redirections): Print debug setting.
3135         (show_logging_command): Likewise.
3136         (_initialize_cli_logging): Add debugredirect command.
3137         * interps.c (current_interp_set_logging): Add debug_redirect
3138         parameter.
3139         * interps.h (set_logging): Add debug_redirect parameter.
3140         (current_interp_set_logging): Likewise.
3141         * mi/mi-common.h: Likewise.
3142         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3143
3144 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3145             Tom Tromey  <tromey@adacore.com>
3146
3147         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3148         directly.
3149         * cli/cli-interp.h (make_logging_output): Remove declaration.
3150         * cli/cli-logging.c (make_logging_output): Remove function.
3151         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3152         directly.
3153         * ui-file.c (tee_file::tee_file): Remove bools.
3154         (tee_file::~tee_file): Remove deletes.
3155         * ui-file.h (tee_file): Remove bools.
3156
3157 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3158
3159         * mi/mi-cmds.h (mi_cmd_complete): New function.
3160         * mi/mi-main.c (mi_cmd_complete): Likewise.
3161         * mi/mi-cmds.c: Define new MI command -complete.
3162         * NEWS: Mention new -complete command.
3163
3164 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3165
3166         * completer.h (complete): New function.
3167         * completer.c (complete): Likewise.
3168         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3169         function defined in completer.h.
3170
3171 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3172
3173         * MAINTAINERS (Write After Approval): Add myself.
3174
3175 2019-05-17  Tom de Vries  <tdevries@suse.de>
3176
3177         PR gdb/24094
3178         * dwarf2read.c (struct cu_partial_die_info): New struct.
3179         (find_partial_die): Return cu_partial_die_info.
3180         (partial_die_parent_scope, guess_partial_die_structure_name)
3181         (partial_die_info::fixup): Handle new return type of find_partial_die.
3182
3183 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3184
3185         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3186         "std::string", simplifying the algorithm.
3187
3188 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3189
3190         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3191         (stap_static_probe_ops::get_probes): Likewise.
3192
3193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3194
3195         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3196         '-')" and "else if".
3197         (stap_parse_single_operand): Join checks for
3198         "gdbarch_stap_parse_special_token_p" and
3199         "gdbarch_stap_parse_special_token" in the same "if" statement.
3200         Invert check when verifying for operation on register
3201         displacement.
3202
3203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3204
3205         * stap-probe.c (stap_get_opcode): Update comment.
3206         (stap_get_expected_argument_type): Likewise.
3207         (handle_stap_probe): Likewise.
3208
3209 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3210
3211         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3212         return type to 'bool'.  Adjust comment.  Use 'bool' when
3213         appropriate.
3214         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3215         * stap-probe.c (stap_parse_argument_1): Likewise.
3216         (stap_is_operator): Likewise.
3217         (stap_is_generic_prefix): Likewise.
3218         (stap_is_register_prefix): Likewise.
3219         (stap_is_register_indirection_prefix): Likewise.
3220         (stap_is_integer_prefix): Likewise.
3221         (stap_generic_check_suffix): Likewise.
3222         (stap_check_integer_suffix): Likewise.
3223         (stap_check_register_suffix): Likewise.
3224         (stap_check_register_indirection_suffix): Likewise.
3225         (stap_parse_register_operand): Likewise.
3226         (stap_parse_single_operand): Likewise.
3227         (stap_parse_argument_1): Likewise.
3228         (stap_probe::get_argument_count): Likewise.
3229         (stap_is_operator): Likewise.
3230
3231 2019-05-16  Tom Tromey  <tromey@adacore.com>
3232
3233         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3234         keyword to foreach.
3235
3236 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3237
3238         * linux-thread-db.c (try_thread_db_load_1): Change return type
3239         to bool.
3240         (try_thread_db_load): Likewise.
3241         (try_thread_db_load_from_pdir_1): Likewise.
3242         (try_thread_db_load_from_pdir): Likewise.
3243         (try_thread_db_load_from_sdir): Likewise.
3244         (try_thread_db_load_from_dir): Likewise.
3245         (thread_db_load_search): Likewise.
3246         (has_libpthread): Likewise.
3247         (thread_db_load): Likewise.
3248
3249 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3250
3251         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3252         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3253         NULL, and complain/return if that's the case.
3254
3255 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3256
3257         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3258         (advance, posn, abstract_read_memory): New functions.
3259         [struct mem_read_abstraction]: New struct.
3260         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3261
3262 2019-05-14  Tom Tromey  <tromey@adacore.com>
3263
3264         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3265         value is not lval_memory.
3266
3267 2019-05-14  Tom Tromey  <tromey@adacore.com>
3268
3269         * solib.c (info_sharedlibrary_command): Style the file name.
3270
3271 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3272
3273         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3274         (aarch64_vnv_type): Likewise.
3275         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3276         * common/tdesc.c: Likewise.
3277         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3278         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3279         * features/aarch64-fpu.xml: Add ieee half view.
3280         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3281         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3282         * gdbtypes.h (struct builtin_type): Likewise.
3283         (struct objfile_type): Likewise.
3284
3285 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3286
3287         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3288         typo.
3289         * location.h (string_to_event_location): Likewise.
3290
3291 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3292
3293         GDB 8.3 released.
3294
3295 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3296
3297         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3298         New variable declaration.
3299         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3300         New variable.
3301         (print_one_breakpoint): Use ui_out::test_flags and new global
3302         variable to compute use_fixed_output.
3303         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3304         Remove.
3305         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3306         (mi_multi_location_breakpoint_output_fixed): Remove.
3307         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3308         new variable.
3309         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3310         fix_multi_location_breakpoint_output flag if version >= 3.
3311         * ui-out.h (enum ui_out_flag)
3312         <fix_multi_location_breakpoint_output>: New enumerator.
3313
3314 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3315
3316         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3317
3318 2019-05-10  Tom Tromey  <tromey@adacore.com>
3319
3320         * ada-lang.c (catch_ada_completer): New function.
3321         (_initialize_ada_language): Use it.
3322
3323 2019-05-10  Tom Tromey  <tromey@adacore.com>
3324
3325         * thread.c (print_thread_info): Make "requested_threads" const.
3326         * gdbthread.h (print_thread_info): Make "requested_threads"
3327         const.
3328         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3329         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3330
3331 2019-05-08  Tom Tromey  <tom@tromey.com>
3332
3333         * gdbtypes.c (objfile_type_data): Change type.
3334         (objfile_type, _initialize_gdbtypes): Update.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3339         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3340         (_initialize_dwarf2_frame): Update.
3341
3342 2019-05-08  Tom Tromey  <tom@tromey.com>
3343
3344         * objc-lang.c (objc_objfile_data): Change type.
3345         (find_methods): Update.
3346         (_initialize_objc_lang): Remove.
3347
3348 2019-05-08  Tom Tromey  <tom@tromey.com>
3349
3350         * stabsread.c (rs6000_builtin_type_data): Change type.
3351         (rs6000_builtin_type, _initialize_stabsread): Update.
3352
3353 2019-05-08  Tom Tromey  <tom@tromey.com>
3354
3355         * mips-tdep.c (mips_pdr_data): Remove.
3356         (_initialize_mips_tdep): Update.
3357
3358 2019-05-08  Tom Tromey  <tom@tromey.com>
3359
3360         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3361         (hppa_init_objfile_priv_data, read_unwind_info)
3362         (find_unwind_entry, _initialize_hppa_tdep): Update.
3363
3364 2019-05-08  Tom Tromey  <tom@tromey.com>
3365
3366         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3367         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3368         on obstack.
3369         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3370
3371 2019-05-08  Tom Tromey  <tom@tromey.com>
3372
3373         * mdebugread.c (basic_type_data): Change type.
3374         (basic_type, _initialize_mdebugread): Update.
3375
3376 2019-05-08  Tom Tromey  <tom@tromey.com>
3377
3378         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3379
3380 2019-05-08  Tom Tromey  <tom@tromey.com>
3381
3382         * nto-tdep.c (nto_inferior_data_reg): Change type.
3383         (nto_inferior_data): Update.
3384         (nto_inferior_data_cleanup, nto_new_inferior_data)
3385         (_initialize_nto_tdep): Remove.
3386         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3387
3388 2019-05-08  Tom Tromey  <tom@tromey.com>
3389
3390         * ada-lang.c (struct ada_inferior_data): Add initializers.
3391         (ada_inferior_data): Change type.
3392         (ada_inferior_data_cleanup): Remove.
3393         (get_ada_inferior_data, ada_inferior_exit)
3394         (struct ada_pspace_data): Add initializers, destructor.
3395         (ada_pspace_data_handle): Change type.
3396         (get_ada_pspace_data): Update.
3397         (ada_pspace_data_cleanup): Remove.
3398
3399 2019-05-08  Tom Tromey  <tom@tromey.com>
3400
3401         * coffread.c (struct coff_symfile_info): Add initializers.
3402         (coff_objfile_data_key): Move lower.  Change type.
3403         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3404         Update.
3405         (coff_free_info): Remove.
3406
3407 2019-05-08  Tom Tromey  <tom@tromey.com>
3408
3409         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3410         (fbsd_pspace_data_handle): Move lower.  Change type.
3411         (get_fbsd_pspace_data): Update.
3412         (fbsd_pspace_data_cleanup): Remove.
3413         (_initialize_fbsd_tdep): Update.
3414
3415 2019-05-08  Tom Tromey  <tom@tromey.com>
3416
3417         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3418         (get_ada_tasks_pspace_data): Update.
3419         (ada_tasks_pspace_data_cleanup): Remove.
3420         (_initialize_tasks): Update.
3421         (ada_tasks_inferior_data_handle): Change type.
3422         (get_ada_tasks_inferior_data): Update.
3423         (ada_tasks_inferior_data_cleanup): Remove.
3424         (struct ada_tasks_pspace_data): Add initializers.
3425
3426 2019-05-08  Tom Tromey  <tom@tromey.com>
3427
3428         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3429         * symfile-debug.c (debug_sym_get_probes): Change type.
3430         * stap-probe.c (handle_stap_probe):
3431         (stap_static_probe_ops::get_probes): Change type.
3432         * probe.h (class static_probe_ops) <get_probes>: Change type.
3433         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3434         (parse_probes_in_pspace): Update.
3435         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3436         Update.
3437         (any_static_probe_ops::get_probes): Change type.
3438         * elfread.c (elfread_data): New typedef.
3439         (probe_key): Change type.
3440         (elf_get_probes): Likewise.  Update.
3441         (probe_key_free): Remove.
3442         (_initialize_elfread): Update.
3443         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3444         Change type.
3445         (dtrace_process_dof_probe, dtrace_process_dof)
3446         (dtrace_static_probe_ops::get_probe): Change type.
3447
3448 2019-05-08  Tom Tromey  <tom@tromey.com>
3449
3450         * xcoffread.c (struct xcoff_symfile_info): Rename from
3451         coff_symfile_info.  Add initializers.
3452         (xcoff_objfile_data_key): Move lower.  Change type.
3453         (XCOFF_DATA): Rewrite.
3454         (xcoff_free_info): Remove.
3455         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3456         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3457         (xcoff_initial_scan): Update.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * solib-svr4.c (struct svr4_info): Add initializers and
3462         destructor.
3463         <probes_table>: Now an htab_up.
3464         (solib_svr4_pspace_data): Change type.
3465         (free_probes_table): Simplify.
3466         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3467         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3468         (probes_table_remove_objfile_probes, register_solib_event_probe)
3469         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3470         (_initialize_svr4_solib): Update.
3471
3472 2019-05-08  Tom Tromey  <tom@tromey.com>
3473
3474         * remote.c (remote_pspace_data): Change type.
3475         (remote_pspace_data_cleanup): Remove.
3476         (get_remote_exec_file, set_pspace_remote_exec_file)
3477         (_initialize_remote): Update.
3478
3479 2019-05-08  Tom Tromey  <tom@tromey.com>
3480
3481         * breakpoint.c (breakpoint_objfile_key): Change type.
3482         (get_breakpoint_objfile_data): Update.
3483         (free_breakpoint_objfile_data): Remove.
3484         (_initialize_breakpoint): Update.
3485
3486 2019-05-08  Tom Tromey  <tom@tromey.com>
3487
3488         * linux-tdep.c (struct linux_info): Add initializers.
3489         (linux_inferior_data): Move.  Change type.
3490         (invalidate_linux_cache_inf): Update.
3491         (linux_inferior_data_cleanup): Remove.
3492         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3493
3494 2019-05-08  Tom Tromey  <tom@tromey.com>
3495
3496         * auxv.c (auxv_inferior_data): Move.  Change type.
3497         (auxv_inferior_data_cleanup): Remove.
3498         (invalidate_auxv_cache_inf): Rewrite.
3499         (get_auxv_inferior_data, _initialize_auxv): Update.
3500
3501 2019-05-08  Tom Tromey  <tom@tromey.com>
3502
3503         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3504         (symfile_debug_objfile_data_key): Change type.
3505         (symfile_debug_installed, debug_qf_has_symbols)
3506         (debug_qf_find_last_source_symtab)
3507         (debug_qf_forget_cached_source_info)
3508         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3509         (debug_qf_print_stats, debug_qf_dump)
3510         (debug_qf_expand_symtabs_for_function)
3511         (debug_qf_expand_all_symtabs)
3512         (debug_qf_expand_symtabs_with_fullname)
3513         (debug_qf_map_matching_symbols)
3514         (debug_qf_expand_symtabs_matching)
3515         (debug_qf_find_pc_sect_compunit_symtab)
3516         (debug_qf_map_symbol_filenames)
3517         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3518         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3519         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3520         (debug_sym_read_linetable, debug_sym_relocate): Update.
3521         (symfile_debug_free_objfile): Remove.
3522         (install_symfile_debug_logging, _initialize_symfile_debug):
3523         Update.
3524
3525 2019-05-08  Tom Tromey  <tom@tromey.com>
3526
3527         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3528         allocate_on_obstack.
3529         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3530         (get_dwarf2_per_objfile): Update.
3531         (set_dwarf2_per_objfile): Remove.
3532         (dwarf2_has_info, dwarf2_get_section_info): Update.
3533         (dwarf2_free_objfile): Remove.
3534         (_initialize_dwarf2_read): Update.
3535
3536 2019-05-08  Tom Tromey  <tom@tromey.com>
3537
3538         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3539         initializers.
3540         <unsupported_script_warning_printed,
3541         script_not_found_warning_printed>: Now bool.
3542         (auto_load_pspace_data): Change type.
3543         (~auto_load_pspace_info): Rename from
3544         auto_load_pspace_data_cleanup.
3545         (get_auto_load_pspace_data, init_loaded_scripts_info)
3546         (clear_section_scripts, maybe_print_unsupported_script_warning)
3547         (maybe_print_script_not_found_warning, _initialize_auto_load):
3548         Update.
3549
3550 2019-05-08  Tom Tromey  <tom@tromey.com>
3551
3552         * objfiles.c (objfile_pspace_info): Add destructor and
3553         initializers.
3554         (objfiles_pspace_data): Change type.
3555         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3556         (get_objfile_pspace_data): Update.
3557         (objfiles_bfd_data): Change type.
3558         (get_objfile_bfd_data): Update.
3559         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3560
3561 2019-05-08  Tom Tromey  <tom@tromey.com>
3562
3563         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3564         Change type.
3565         (get_catch_syscall_inferior_data): Update.
3566         (catch_syscall_inferior_data_cleanup): Remove.
3567         (_initialize_break_catch_syscall): Update.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * inflow.c (struct terminal_info): Add destructor and
3572         initializers.
3573         (inflow_inferior_data): Change type.
3574         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3575         (get_inflow_inferior_data, inflow_inferior_exit)
3576         (swap_terminal_info, _initialize_inflow): Update.
3577
3578 2019-05-08  Tom Tromey  <tom@tromey.com>
3579
3580         * target-dcache.c (target_dcache_cleanup): Remove.
3581         (target_dcache_aspace_key): Change type.
3582         (target_dcache_init_p, target_dcache_invalidate)
3583         (target_dcache_get, target_dcache_get_or_init)
3584         (_initialize_target_dcache): Update.
3585         * dcache.h (struct dcache_deleter): New.
3586
3587 2019-05-08  Tom Tromey  <tom@tromey.com>
3588
3589         * symtab.c (struct symbol_cache): Add destructor and
3590         initializers.
3591         (symbol_cache_key): Move.  Change type.
3592         (make_symbol_cache, free_symbol_cache): Remove.
3593         (get_symbol_cache): Update.
3594         (symbol_cache_cleanup): Remove.
3595         (ALL_PSPACES, symbol_cache_flush)
3596         (maintenance_print_symbol_cache)
3597         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3598         Update.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * symtab.c (struct main_info): Add destructor and initializers.
3603         (main_progspace_key): Move.  Change type.
3604         (get_main_info): Update.
3605         (main_info_cleanup): Remove.
3606         (_initialize_symtab): Update.
3607
3608 2019-05-08  Tom Tromey  <tom@tromey.com>
3609
3610         * registry.h (DECLARE_REGISTRY): Define the _key class.
3611
3612 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * NEWS: Merge two 'New commands' sections.
3615
3616 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3617
3618         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3619         parameter and use Ada language definition instead.
3620         (ada_val_print_ptr): Remove unused language parameter.
3621         (ada_val_print_num): Remove language parameter and use Ada language
3622         definition instead.
3623         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3624         parameter.
3625         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3626         parameter and use Ada language definition instead.
3627         (ada_val_print_1): Update all ada_val_print_xxx calls.
3628         Remove language parameter.
3629         (ada_val_print): Update ada_val_print_1 call.
3630
3631 2019-05-08  Tom Tromey  <tromey@adacore.com>
3632
3633         * remote.c (remote_hw_watchpoint_limit)
3634         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3635         Now static.
3636
3637 2019-05-08  Tom Tromey  <tromey@adacore.com>
3638
3639         * maint.c (_initialize_maint_cmds): Move initialization code to
3640         remote.c.
3641         (watchdog, show_watchdog): Move to remote.c.
3642         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3643         "watchdog" static.
3644         (_initialize_remote): Move initialization code from maint.c.
3645         * defs.h (watchdog): Don't declare.
3646
3647 2019-05-08  Tom Tromey  <tromey@adacore.com>
3648
3649         * tui/tui-interp.c: Include main.h.
3650         * interps.c: Include main.h.
3651         * main.h (interpreter_p): Declare.
3652         * defs.h (interpreter_p): Don't declare.
3653
3654 2019-05-08  Tom Tromey  <tromey@adacore.com>
3655
3656         * dwarf2loc.c: Include dwarf2read.h.
3657         * defs.h (read_unsigned_leb128): Don't declare.
3658         * dwarf2read.h (read_unsigned_leb128): Declare.
3659
3660 2019-05-08  Tom Tromey  <tromey@adacore.com>
3661
3662         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3663         method.
3664
3665 2019-05-08  Tom Tromey  <tromey@adacore.com>
3666
3667         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3668         when no wrap column is set.
3669
3670 2019-05-08  Tom Tromey  <tromey@adacore.com>
3671
3672         * c-lang.c (c_get_string): Handle non-C-style arrays.
3673
3674 2019-05-08  Tom Tromey  <tromey@adacore.com>
3675
3676         * typeprint.c (print_offset_data::update): Print the bit offset,
3677         not the number of bits remaining.
3678
3679 2019-05-08  Tom Tromey  <tromey@adacore.com>
3680
3681         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3682         padding at end of comment.
3683
3684 2019-05-08  Tom Tromey  <tromey@adacore.com>
3685
3686         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3687         Compare main types.
3688
3689 2019-05-06  Tom Tromey  <tom@tromey.com>
3690
3691         * common/scoped_mmap.c: Include common-defs.h.
3692         * common/scoped_mmap.h: Don't include config.h.
3693
3694 2019-05-04  Tom Tromey  <tom@tromey.com>
3695
3696         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3697         (struct aarch64_call_info): Add initializers.
3698         <si>: Now a std::vector.
3699         (pass_on_stack, aarch64_push_dummy_call): Update.
3700
3701 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3702             Tom Tromey  <tom@tromey.com>
3703
3704         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3705         (ppc_threads): Now a std::vector.  Now static.
3706         (hwdebug_find_thread_points_by_tid)
3707         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3708         Update.
3709
3710 2019-05-04  Tom Tromey  <tom@tromey.com>
3711
3712         * arc-tdep.c (arc_tdesc_init): Return bool.
3713
3714 2019-05-04  Tom Tromey  <tom@tromey.com>
3715
3716         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3717         Use gdb_assert_not_reached.
3718
3719 2019-05-04  Tom Tromey  <tom@tromey.com>
3720
3721         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3722         "false".
3723
3724 2019-05-04  Tom Tromey  <tom@tromey.com>
3725
3726         * arc-tdep.c (arc_tdesc_init): Use bool.
3727
3728 2019-05-04  Tom Tromey  <tom@tromey.com>
3729
3730         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3731
3732 2019-05-04  Tom Tromey  <tom@tromey.com>
3733
3734         * cli/cli-cmds.c (valid_command_p): Return bool.
3735
3736 2019-05-04  Tom Tromey  <tom@tromey.com>
3737
3738         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3739         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3740
3741 2019-05-04  Raul Tambre  <raul@tambre.ee>
3742
3743         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3744         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3745         operator for comparison.
3746
3747 2019-05-04  Tom Tromey  <tom@tromey.com>
3748
3749         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3750         (lookup_partial_symbol, print_partial_symbols)
3751         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3752         (psymbol_compare): Update.
3753         (add_psymbol_to_bcache): Clear the entire psymbol.
3754         (maintenance_check_psymtabs): Update.
3755         * psympriv.h (struct partial_symbol): Don't derive from
3756         general_symbol_info.
3757         <obj_section, unrelocated_address, address,
3758         set_unrelocated_address>: Update.
3759         <ginfo>: New member.
3760         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3761         (debug_names::write_psymbols): Update.
3762
3763 2019-05-04  Tom de Vries  <tdevries@suse.de>
3764
3765         * contrib/cc-with-tweaks.sh: Support -n arg.
3766
3767 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3768
3769         * corelow.c (core_target::detach): Ensure frame cache and
3770         register caches are cleared.
3771         inferior.c (exit_inferior_1): Likewise.
3772
3773 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3774             Tom Tromey  <tom@tromey.com>
3775
3776         * dictionary.c (collate_pending_symbols_by_language): Remove
3777         "struct" from foreach.
3778         * symtab.c (lookup_global_symbol_from_objfile)
3779         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3780         foreach.
3781         * ser-tcp.c (net_open): Remove "struct" from foreach.
3782         * objfiles.c (objfile_relocate, objfile_rebase)
3783         (objfile_has_symbols): Remove "struct" from foreach.
3784         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3785         from foreach.
3786         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3787         foreach.
3788         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3789         "struct" from foreach.
3790         * ada-lang.c (create_excep_cond_exprs)
3791         (ada_exception_catchpoint_cond_string): Remove "struct" from
3792         foreach.
3793
3794 2019-05-03  Tom Tromey  <tromey@adacore.com>
3795
3796         * ada-exp.y (convert_char_literal): Check suffix of each
3797         enumerator.
3798
3799 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3800
3801         PR ada/21406:
3802         * ada-exp.y (yywrap): Don't define.
3803         * ada-lex.l (%option): Add noyywrap
3804         (yywrap): Remove.
3805
3806 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3807
3808         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3809         _WIN32_WINNT to the XP level, unless already defined to a higher
3810         level.
3811
3812         * unittests/parse-connection-spec-selftests.c:
3813         * ser-tcp.c:
3814         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3815         override.
3816
3817         * symfile.c (find_separate_debug_file): Remove colon from the
3818         drive spec of DOS/Windows file names of the target, so that the
3819         file name produced from DEBUGDIR and the target's directory will
3820         be valid on DOS/Windows systems.
3821
3822 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * rust-lang.c (val_print_struct): Handle printing structures
3825         containing strings.
3826
3827 2019-05-02  Tom Tromey  <tromey@adacore.com>
3828
3829         * valarith.c (_initialize_valarith): Remove.
3830
3831 2019-05-01  Tom Tromey  <tromey@adacore.com>
3832
3833         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3834         bitfields.
3835
3836 2019-05-01  Tom Tromey  <tromey@adacore.com>
3837
3838         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3839         for big-endian copies.
3840
3841 2019-04-30  Ali Tamur  <tamur@google.com>
3842         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3843         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3844         (read_3_bytes): New function.
3845
3846 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3847
3848         * windows-nat.c (main_thread_id): Delete.
3849         (handle_output_debug_string): Replace main_thread_id by
3850         current_event.dwThreadId.
3851         (fake_create_process): Likewise.
3852         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3853         Do not set main_thread_id.
3854         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3855         current_event.dwThreadId.
3856         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3857
3858 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3859
3860         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3861         Use current_event.dwThreadId instead of main_thread_id.
3862
3863 2019-04-30  Tom Tromey  <tromey@adacore.com>
3864
3865         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3866         (create_excep_cond_exprs): Iterate over program spaces.
3867         (ada_exception_catchpoint_cond_string): Examine all minimal
3868         symbols for exception types.
3869
3870 2019-04-30  Tom Tromey  <tromey@adacore.com>
3871
3872         PR c++/24470:
3873         * dwarf2read.c (process_structure_scope): Handle case where type
3874         has template parameters but no symbol was created.
3875
3876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3877             Chris January  <chris.january@arm.com>
3878
3879         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3880         qualifier.
3881         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3882
3883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * f-typeprint.c (f_print_type): Update rules for printing
3886         whitespace.
3887         (f_type_print_varspec_suffix): Likewise.
3888
3889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3890             Chris January  <chris.january@arm.com>
3891
3892         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3893         function arguments.
3894
3895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * f-lang.c (build_fortran_types): Change name of void type to
3898         lower case.
3899         * f-typeprint.c (f_type_print_base): Print the name of the void
3900         type, rather than a fixed string.
3901         * f-valprint.c (f_decorations): Use lower case void string.
3902
3903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3904             Chris January  <chris.january@arm.com>
3905
3906         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3907         types for Fortran.
3908
3909 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3910             Chris January  <chris.january@arm.com>
3911             David Lecomber  <david.lecomber@arm.com>
3912
3913         * f-exp.y (BINOP_INTRINSIC): New token.
3914         (exp): New parser rule handling BINOP_INTRINSIC.
3915         (f77_keywords): Add new builtin procedures.
3916         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3917         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3918         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3919         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3920         (print_unop_subexp_f): New function.
3921         (print_binop_subexp_f): New function.
3922         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3923         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3924         (dump_subexp_body_f): Likewise.
3925         (operator_check_f): Likewise.
3926         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3927         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3928
3929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3930
3931         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3932         UNOP_KIND.
3933         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3934         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3935         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3936         (operator_length_f): New fuction.
3937         (print_subexp_f): New function.
3938         (op_name_f): New function.
3939         (dump_subexp_body_f): New function.
3940         (operator_check_f): New function.
3941         (exp_descriptor_f): Replace standard expression handling functions
3942         with new functions.
3943         * gdb/fortran-operator.def: New file.
3944         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3945         * gdb/std-operator.def: Remove UNOP_KIND.
3946
3947 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * std-operator.def: Remove unbalanced, stray double quote
3950         character.
3951
3952 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3953             Chris January  <chris.january@arm.com>
3954             Daniel Everett  <daniel.everett@arm.com>
3955             Nick Forrington  <nick.forrington@arm.com>
3956             Richard Bunt  <richard.bunt@arm.com>
3957
3958         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3959         of depth when printing anonymous structs or unions.
3960         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3961         Don't print either the top-level value, or the children if the
3962         max-depth is exceeded.
3963         (ppscm_print_children): When printing the key of a map, allow one
3964         extra level of depth.
3965         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3966         print either the top-level value, or the children if the max-depth
3967         is exceeded.
3968         (print_children): When printing the key of a map, allow one extra
3969         level of depth.
3970         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3971         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3972         (user_print_options): Initialise max_depth field.
3973         (val_print_scalar_or_string_type_p): New function.
3974         (val_print): Check to see if the max depth has been reached.
3975         (val_print_check_max_depth): Define new function.
3976         (show_print_max_depth): New function.
3977         (_initialize_valprint): Add 'print max-depth' option.
3978         * valprint.h (struct value_print_options) <max_depth>: New field.
3979         (val_print_check_max_depth): Declare new function.
3980         * NEWS: Document new feature.
3981
3982 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * ada-lang.c (ada_language_defn): Initialise new field.
3985         * c-lang.c (c_is_string_type_p): New function.
3986         (c_language_defn): Initialise new field.
3987         (cplus_language_defn): Initialise new field.
3988         (asm_language_defn): Initialise new field.
3989         (minimal_language_defn): Initialise new field.
3990         * c-lang.h (c_is_string_type_p): Declare new function.
3991         * d-lang.c (d_language_defn): Initialise new field.
3992         * f-lang.c (f_is_string_type_p): New function.
3993         (f_language_defn): Initialise new field.
3994         * go-lang.c (go_is_string_type_p): New function.
3995         (go_language_defn): Initialise new field.
3996         * language.c (default_is_string_type_p): New function.
3997         (unknown_language_defn): Initialise new field.
3998         (auto_language_defn): Initialise new field.
3999         * language.h (struct language_defn) <la_is_string_type_p>: New
4000         member variable.
4001         (default_is_string_type_p): Declare new function.
4002         * m2-lang.c (m2_language_defn): Initialise new field.
4003         * objc-lang.c (objc_language_defn): Initialise new field.
4004         * opencl-lang.c (opencl_language_defn): Initialise new field.
4005         * p-lang.c (pascal_is_string_type_p): New function.
4006         (pascal_language_defn): Initialise new field.
4007         * rust-lang.c (rust_is_string_type_p): New function.
4008         (rust_language_defn): Initialise new field.
4009
4010 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4013         New field.
4014         * ada-lang.c (ada_language_defn): Initialise new field.
4015         * c-lang.c (c_language_defn): Likewise.
4016         (cplus_language_defn): Likewise.
4017         (asm_language_defn): Likewise.
4018         (minimal_language_defn): Likewise.
4019         * d-lang.c (d_language_defn): Likewise.
4020         * f-lang.c (f_language_defn): Likewise.
4021         * go-lang.c (go_language_defn): Likewise.
4022         * language.c (unknown_language_defn): Likewise.
4023         (auto_language_defn): Likewise.
4024         * m2-lang.c (m2_language_defn): Likewise.
4025         * objc-lang.c (objc_language_defn): Likewise.
4026         * opencl-lang.c (opencl_language_defn): Likewise.
4027         * p-lang.c (pascal_language_defn): Likewise.
4028         * rust-lang.c (rust_language_defn): Likewise.
4029
4030 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * ada-lang.c (ada_is_character_type): Change return type to bool.
4033         (ada_is_string_type): Likewise.
4034         * ada-lang.h (ada_is_character_type): Update declaration
4035         (ada_is_string_type): Likewise.
4036
4037 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4038
4039         Support style in 'frame|thread apply'
4040
4041         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4042         * record.c (record_start, record_stop): Update callers of
4043         execute_command_to_string with false.
4044         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4045         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4046         methods.
4047         (class string_file): New constructor with term_out parameter.
4048         Override methods term_out and can_emit_style_escape.  New member
4049         term_out.
4050         (class stdio_file): Override can_emit_style_escape.
4051         (class tee_file): Override term_out and can_emit_style_escape.
4052         * utils.h (can_emit_style_escape): Remove.
4053         * utils.c (can_emit_style_escape): Likewise.
4054         Update all callers of can_emit_style_escape (SOMESTREAM) to
4055         SOMESTREAM->can_emit_style_escape.
4056         * source-cache.c (source_cache::get_source_lines): Likewise.
4057         * stack.c (frame_apply_command_count): Call execute_command_to_string
4058         passing the term_out characteristic of the current gdb_stdout.
4059         * thread.c (thr_try_catch_cmd): Likewise.
4060         * top.c (execute_command_to_string): pass term_out parameter
4061         to construct the string_file for the command output.
4062         * ui-file.c (term_cli_styling): New function (most code moved
4063         from utils.c can_emit_style_escape).
4064         (string_file::string_file, string_file::can_emit_style_escape,
4065         stdio_file::can_emit_style_escape, tee_file::term_out,
4066         tee_file::can_emit_style_escape): New functions.
4067
4068 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4069
4070         * NEWS: Mention the new set|show may-call-functions.
4071         * infcall.c (may_call_functions_p): New variable.
4072         (show_may_call_functions_p): New function.
4073         (call_function_by_hand_dummy): Throws an error if not
4074         may-call-functions.
4075         (_initialize_infcall): Call add_setshow_boolean_cmd for
4076         may-call-functions.
4077
4078 2019-04-25  Keith Seitz  <keiths@redhat.com>
4079
4080         PR c++/24367
4081         * cp-support.c (inspect_type): Don't attempt substitutions
4082         of symbol with the same name.
4083
4084 2019-04-25  Tom Tromey  <tromey@adacore.com>
4085
4086         PR gdb/24475:
4087         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4088         static.
4089
4090 2019-04-25  Tom Tromey  <tromey@adacore.com>
4091
4092         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4093         rvalue reference.
4094         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4095         (gdb_xml_parser::parse): Use std::move.
4096         * python/python-internal.h (gdbpy_convert_exception): Take a const
4097         reference.
4098         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4099         std::move.
4100         * python/py-utils.c (gdbpy_convert_exception): Take a const
4101         reference.
4102         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4103         Use std::move.
4104         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4105         Use std::move.
4106         * mi/mi-main.c (mi_print_exception): Take a const reference.
4107         * main.c (handle_command_errors): Take a const reference.
4108         * linespec.c (parse_linespec): Use std::move.
4109         * infcall.c (run_inferior_call): Use std::move.
4110         (call_function_by_hand_dummy): Use std::move.
4111         * exec.c (try_open_exec_file): Use std::move.
4112         * exceptions.h (exception_print, exception_fprintf)
4113         (exception_print_same): Update.
4114         * exceptions.c (print_exception, exception_print)
4115         (exception_fprintf, exception_print_same): Change parameters to
4116         const reference.
4117         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4118         * common/new-op.c: Use std::move.
4119         * common/common-exceptions.h (struct gdb_exception): Add move
4120         constructor.
4121         (struct gdb_exception_error, struct gdb_exception_quit, struct
4122         gdb_quit_bad_alloc): Change constructor to move constructor.
4123         (throw_exception): Change parameter to rvalue reference.
4124         * common/common-exceptions.c (throw_exception): Take rvalue
4125         reference.
4126         * cli/cli-interp.c (safe_execute_command): Use std::move.
4127         * breakpoint.c (insert_bp_location, location_to_sals): Use
4128         std::move.
4129
4130 2019-04-25  Tom Tromey  <tromey@adacore.com>
4131
4132         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4133         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4134         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4135         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4136         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4137         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4138         guile/scm-value.c: Use unpack.
4139         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4140         gdbscm_gdb_exception.
4141         (gdbscm_throw_gdb_exception): Likewise.
4142         (struct gdbscm_gdb_exception): New.
4143         (unpack): New function.
4144         (gdbscm_wrap): Use unpack.
4145
4146 2019-04-25  Tom Tromey  <tromey@adacore.com>
4147
4148         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4149         (gdb_rl_callback_handler): Use std::move.
4150         * common/common-exceptions.h (struct gdb_exception): Add move
4151         assignment operator.
4152         (throw_exception_sjlj): Change "exception" to const reference.
4153         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4154         (throw_exception_sjlj): Change "exception" to const reference.
4155
4156 2019-04-25  Tom Tromey  <tromey@adacore.com>
4157
4158         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4159         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4160         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4161         Update.
4162         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4163         Update.
4164         * mi/mi-interp.c (mi_interp::exec): Update.
4165         * linespec.c (parse_linespec): Update.
4166         * infcall.c (run_inferior_call): Update.
4167         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4168         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4169         (gdbscm_lookup_global_symbol): Update.
4170         * guile/scm-param.c (gdbscm_parameter_value): Update.
4171         * guile/scm-frame.c (gdbscm_frame_read_register)
4172         (gdbscm_frame_read_var): Update.
4173         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4174         * exec.c (try_open_exec_file): Update.
4175         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4176         (gdb_rl_callback_handler): Update.
4177         * common/common-exceptions.h (exception_none): Don't declare.
4178         * common/common-exceptions.c (exception_none): Don't define.
4179         (struct catcher) <exception>: Update.
4180         * cli/cli-interp.c (safe_execute_command): Update.
4181         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4182
4183 2019-04-25  Ali Tamur  <tamur@google.com>
4184
4185         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4186         (read_attribute_value): Likewise.
4187         (dwarf2_read_addr_index): Update comment.
4188         (read_str_index): Add DW_FORM_strx.
4189         (dwarf2_string_attr): Likewise.
4190         (dwarf2_const_value_attr): Likewise.
4191         (dump_die_shallow): Likewise.
4192         (dwarf2_fetch_constant_bytes): Likewise.
4193         (skip_form_bytes): Likewise.
4194         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4195
4196 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4197
4198         PR corefiles/11608
4199         PR corefiles/18187
4200         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4201         OFFSET.  Verify if current mapping contains an ELF header.
4202         (linux_find_memory_regions_full): Adjust call to
4203         dump_mapping_p.
4204
4205 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4206             Kang Li <kanglictf@gmail.com>
4207
4208         PR gdb/21600
4209
4210         * dwarf2-frame.c (read_initial_length): Be consistent about using
4211         unsigned representation of length.
4212         (decode_frame_entry_1): Likewise.  Check for wraparound of
4213         end pointer as well as buffer overflow.
4214
4215 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4216
4217         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4218         "vq".
4219
4220 2019-04-24  Tom Tromey  <tromey@adacore.com>
4221
4222         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4223
4224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * s12z-tdep.c (s12z_unwind_pc): Delete.
4227         (s12z_unwind_sp): Delete.
4228         (s12z_gdbarch_init): Don't register deleted functions with
4229         gdbarch.
4230
4231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4232
4233         * rl78-tdep.c (rl78_unwind_sp): Delete.
4234         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4235
4236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4239         (xstormy16_unwind_pc): Delete.
4240         (xstormy16_dummy_id): Delete.
4241         (xstormy16_gdbarch_init): Don't register deleted functions with
4242         gdbarch.
4243
4244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4245
4246         * vax-tdep.c (vax_unwind_pc): Delete.
4247         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4248
4249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * v850-tdep.c (v850_unwind_sp): Delete.
4252         (v850_unwind_pc): Delete.
4253         (v850_dummy_id): Delete.
4254         (v850_gdbarch_init): Don't register deleted functions with
4255         gdbarch.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4260         (tilegx_unwind_pc): Delete.
4261         (tilegx_unwind_dummy_id): Delete.
4262         (tilegx_gdbarch_init): Don't register deleted functions with
4263         gdbarch.
4264
4265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4268         (tic6x_dummy_id): Delete.
4269         (tic6x_gdbarch_init): Don't register deleted functions with
4270         gdbarch.
4271
4272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * sparc-tdep.c (sparc_unwind_pc): Delete.
4275         (sparc32_gdbarch_init): Don't register deleted function with
4276         gdbarch.
4277
4278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * sh-tdep.c (sh_unwind_sp): Delete.
4281         (sh_unwind_pc): Delete.
4282         (sh_dummy_id): Delete.
4283         (sh_gdbarch_init): Don't register deleted functions with
4284         gdbarch.
4285
4286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * score-tdep.c (score_unwind_sp): Delete.
4289         (score_unwind_pc): Delete.
4290         (score_dummy_id): Delete.
4291         (score_gdbarch_init): Don't register deleted functions with
4292         gdbarch.
4293
4294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * rx-tdep.c (rx_unwind_pc): Delete.
4297         (rx_unwind_sp): Delete.
4298         (rx_dummy_id): Delete.
4299         (rx_gdbarch_init): Don't register deleted functions with
4300         gdbarch.  Update comment.
4301
4302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4305         (rs6000_dummy_id): Delete.
4306         (rs6000_gdbarch_init): Don't register deleted functions with
4307         gdbarch.
4308
4309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * or1k-tdep.c (or1k_dummy_id): Delete.
4312         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * nios2-tdep.c (nios2_dummy_id): Delete.
4317         (nios2_unwind_sp): Delete.
4318         (nios2_gdbarch_init): Don't register deleted functions with
4319         gdbarch.
4320
4321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * nds32-tdep.c (nds32_dummy_id): Delete.
4324         (nds32_unwind_pc): Delete.
4325         (nds32_unwind_sp): Delete.
4326         (nds32_gdbarch_init): Don't register deleted functions with
4327         gdbarch.
4328
4329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * msp430-tdep.c (msp430_unwind_pc): Delete.
4332         (msp430_unwind_sp): Delete.
4333         (msp430_dummy_id): Delete.
4334         (msp430_gdbarch_init): Don't register deleted functions with
4335         gdbarch.
4336
4337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * moxie-tdep.c (moxie_unwind_sp): Delete.
4340         (moxie_unwind_pc): Delete.
4341         (moxie_dummy_id): Delete.
4342         (moxie_gdbarch_init): Don't register deleted functions with
4343         gdbarch.
4344
4345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4348         (mn10300_unwind_pc): Delete.
4349         (mn10300_unwind_sp): Delete.
4350         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4351         mn10300_unwind_sp.
4352         (mn10300_frame_unwind_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * mep-tdep.c (mep_unwind_pc): Delete.
4358         (mep_unwind_sp): Delete.
4359         (mep_dummy_id): Delete.
4360         (mep_gdbarch_init): Don't register deleted functions with
4361         gdbarch.
4362
4363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4366         (m68hc11_unwind_sp): Delete.
4367         (m68hc11_gdbarch_init): Don't register deleted functions with
4368         gdbarch.
4369
4370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * m32r-tdep.c (m32r_unwind_sp): Delete.
4373         (m32r_unwind_pc): Delete.
4374         (m32r_dummy_id): Delete.
4375         (m32r_gdbarch_init): Don't register deleted functions with
4376         gdbarch.
4377
4378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * m32c-tdep.c (m32c_unwind_pc): Delete.
4381         (m32c_unwind_sp): Delete.
4382         (m32c_dummy_id): Delete.
4383         (m32c_gdbarch_init): Don't register deleted functions with
4384         gdbarch.
4385
4386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4389         (lm32_unwind_pc): Delete.
4390         (lm32_dummy_id): Delete.
4391         (lm32_gdbarch_init): Don't register deleted functions with
4392         gdbarch.
4393
4394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4397         (iq2000_unwind_pc): Delete.
4398         (iq2000_dummy_id): Delete.
4399         (iq2000_gdbarch_init): Don't register deleted functions with
4400         gdbarch.
4401
4402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4403
4404         * nds32-tdep.c (nds32_type_align): Delete.
4405         (nds32_push_dummy_call): Use type_align instead.
4406
4407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * arm-tdep.c (arm_type_align): Only handle vector override case.
4410         (arm_push_dummy_call): Use type_align.
4411         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4412
4413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4416         case.
4417         (pass_on_stack): Use type_align.
4418         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4419         function.
4420
4421 2019-04-23  Tom Tromey  <tromey@adacore.com>
4422
4423         * dwarf2read.c (line_header::file_name_at): Remove unused
4424         overload.
4425
4426 2019-04-23  Tom de Vries  <tdevries@suse.de>
4427
4428         PR gdb/24438
4429         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4430         invocation.
4431
4432
4433 2019-03-27  Ali Tamur  <tamur@google.com>
4434
4435         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4436         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4437         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4438         (dwarf_expr_context::get_addr_index): Likewise
4439         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4440         (symbol_needs_eval_context::get_addr_index): Likewise
4441         (disassemble_dwarf_expression): Add DW_OP_addrx
4442         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4443         (read_cutu_die_from_dwo): Update comment
4444         (skip_one_die): Add DW_FORM_addrx
4445         (read_attribute_value): Likewise
4446         (var_decode_location): Add DW_OP_addrx
4447         (dwarf2_const_value_attr): Add DW_FORM_addrx
4448         (dump_die_shallow): Likewise
4449         (dwarf2_fetch_constant_bytes): Likewise
4450         (decode_locdesc): Add DW_OP_addrx
4451         (skip_form_bytes): Add DW_FORM_addrx
4452
4453 2019-04-22  Ali Tamur  <tamur@google.com>
4454
4455         * MAINTAINERS (Write After Approval): Add self.
4456
4457 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4460         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4461         (open_symbol_file_object): Likewise.
4462         (svr4_default_sos): Add info parameter.
4463         (svr4_read_so_list): Likewise.
4464         (svr4_current_sos_direct): Adjust functions calls to pass down
4465         info.
4466         (svr4_current_sos_1): Add info parameter.
4467         (svr4_current_sos): Call get_svr4_info, pass info down to
4468         svr4_current_sos_1.
4469         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4470         get_svr4_info.
4471         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4472         get_svr4_info.
4473         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4474         to get_svr4_info.
4475         (probes_table_remove_objfile_probes): Likewise.
4476         (register_solib_event_probe): Add info parameter.
4477         (solist_update_incremental): Pass info parameter down to
4478         svr4_read_so_list.
4479         (disable_probes_interface): Add info parameter.
4480         (svr4_handle_solib_event): Pass current_program_space to
4481         get_svr4_info.  Adjust disable_probes_interface cleanup.
4482         (svr4_create_probe_breakpoints): Add info parameter, pass it
4483         down to register_solib_event_probe.
4484         (svr4_create_solib_event_breakpoints): Add info parameter,
4485         pass it down to svr4_create_probe_breakpoints.
4486         (enable_break): Pass info down to
4487         svr4_create_solib_event_breakpoints.
4488         (svr4_solib_create_inferior_hook): Pass current_program_space to
4489         get_svr4_info.
4490         (svr4_clear_solib): Likewise.
4491
4492 2019-04-22  Pedro Alves  <palves@redhat.com>
4493
4494         * solib-svr4.c (svr4_free_objfile_observer): New.
4495         (probe_and_action::objfile): New field.
4496         (probes_table_htab_remove_objfile_probes)
4497         (probes_table_remove_objfile_probes): New functions.
4498         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4499         in the new probe_and_action.  Don't store the probe in 'lookup'.
4500         (svr4_create_probe_breakpoints): Pass objfile to
4501         register_solib_event_probe.
4502         (_initialize_svr4_solib): Register a free_objfile observer.
4503
4504 2019-04-19  Tom Tromey  <tom@tromey.com>
4505
4506         * common/queue.h: Remove.
4507
4508 2019-04-19  Tom Tromey  <tom@tromey.com>
4509
4510         * event-loop.c: Don't include "common/queue.h".
4511
4512 2019-04-19  Tom Tromey  <tom@tromey.com>
4513
4514         * remote.c (remote_target): Use delete.
4515         * remote-notif.h: Include <list>, not "common/queue.h".
4516         (notif_client_p): Remove typedef.
4517         (remote_notif_state): Add constructor, destructor, initializer.
4518         <notif_queue>: Now a std::list.
4519         (remote_notif_state_xfree): Don't declare.
4520         * remote-notif.c (remote_notif_process, handle_notification)
4521         (remote_notif_state_allocate): Update.
4522         (~remote_notif_state): Rename from remote_notif_state_xfree.
4523
4524 2019-04-19  Tom Tromey  <tom@tromey.com>
4525
4526         * symfile.c (reread_symbols): Update.
4527         * objfiles.c (objfile_register_static_link)
4528         (objfile_lookup_static_link): Update
4529         (~objfile) Don't delete static_links.
4530         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4531
4532 2019-04-19  Tom Tromey  <tom@tromey.com>
4533
4534         * type-stack.h (struct type_stack) <insert>: Constify string.
4535         * type-stack.c (type_stack::insert): Constify string.
4536         * gdbtypes.h (lookup_template_type): Update.
4537         (address_space_name_to_int): Update.
4538         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4539         const.
4540         (lookup_template_type): Make name const.
4541         * c-exp.y: Update rules.
4542         (lex_one_token, classify_name, classify_inner_name)
4543         (c_print_token): Update.
4544         * p-exp.y: Update rules.
4545         (yylex): Update.
4546         * f-exp.y: Update rules.
4547         (yylex): Update.
4548         * d-exp.y: Update rules.
4549         (lex_one_token, classify_name, classify_inner_name): Update.
4550         * parse.c (write_dollar_variable, copy_name): Return std::string.
4551         * parser-defs.h (copy_name): Change return type.
4552         * m2-exp.y: Update rules.
4553         (yylex): Update.
4554         * go-exp.y (lex_one_token): Update.
4555         Update rules.
4556         (classify_unsafe_function, classify_packaged_name)
4557         (classify_name, yylex): Update.
4558
4559 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4560
4561         * configure.ac: add --enable-source-highlight switch.
4562         * configure: Regenerate.
4563         * top.c (print_gdb_version): plumb --enable-source-highlight
4564         status to "show configuration".
4565
4566 2019-04-19  Tom Tromey  <tromey@adacore.com>
4567
4568         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4569         Check ADA_TYPE_P.
4570         (empty_record, ada_template_to_fixed_record_type_1)
4571         (template_to_static_fixed_type)
4572         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4573         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4574         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4575         macros.
4576
4577 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4578
4579         PR symtab/24423:
4580         * source.c (print_source_lines_base): Advance "iter" when a
4581         control character is seen.
4582
4583 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4584
4585         * inferior.h (struct infcall_suspend_state_deleter):
4586         Catch exception in destructor to avoid crash.
4587
4588 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4589
4590         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4591         close to the add_com "shell".
4592
4593 2019-04-18  Tom Tromey  <tromey@adacore.com>
4594
4595         * process-stratum-target.h (class process_stratum_target)
4596         <stratum>: Add "final".
4597
4598 2019-04-17  Tom Tromey  <tromey@adacore.com>
4599
4600         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4601         against nullptr before use.
4602
4603 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4604
4605         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4606
4607 2019-04-17  Jim Wilson  <jimw@sifive.com>
4608             Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4611         code read might fail, assume 4-byte breakpoint in that case.
4612
4613 2019-04-15  Leszek Swirski  <leszeks@google.com>
4614
4615         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4616         rather than a hand-rolled POD check when checking for forced MEMORY
4617         classification.
4618
4619 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4620
4621         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4622         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4623         function.
4624         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4625         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4626         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4627         declaration.
4628
4629 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4630
4631         * aarch64-linux-nat.c
4632         (aarch64_linux_nat_target::thread_architecture): Add override.
4633         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4634         each VQ.
4635
4636 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4637
4638         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4639
4640 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4643         target types of size 96-bits, add some additional comments, and
4644         check that the builtin type we found was the correct size.
4645
4646 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4647
4648         * utils.c (prompt_for_continue): Don't restore the styling at the
4649         end, as applied_style has the wrong value.  This fixes styling in
4650         long lists of file names that are interrupted by the "Continue?"
4651         prompt.
4652
4653 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4654
4655         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4656         * c-lang.c (c_language_defn): Likewise.
4657         (cplus_language_defn): Likewise.
4658         (asm_language_defn): Likewise.
4659         (minimal_language_defn): Likewise.
4660         * d-lang.c (d_language_defn): Likewise.
4661         * f-lang.c (f_language_defn): Likewise.
4662         * go-lang.c (go_language_defn): Likewise.
4663         * language.c (unknown_language_defn): Likewise.
4664         (auto_language_defn): Likewise.
4665         * language.h (struct language_defn): Remove la_magic field.
4666         (LANG_MAGIC): Delete.
4667         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4668         * objc-lang.c (objc_language_defn): Likewise.
4669         * opencl-lang.c (opencl_language_defn): Likewise.
4670         * p-lang.c (pascal_language_defn): Likewise.
4671         * rust-lang.c (rust_language_defn): Likewise.
4672
4673 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * riscv-tdep.c (riscv_type_align): New function.
4676         (riscv_type_alignment): Delete.
4677         (riscv_arg_location): Use 'type_align'.
4678         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4679
4680 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * gdbtypes.c (type_align): A struct with no non-static fields also
4683         has alignment of 1.
4684
4685 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4688         component to 0.
4689         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4690         member.
4691         (riscv_struct_info::analyse): New implementation using new
4692         analyse_inner member function.
4693         (riscv_struct_info::field_offset): New member function.
4694         (riscv_struct_info::m_offsets): New member variable.
4695         (riscv_struct_info::analyse_inner): New private member function,
4696         takes the old implementation of riscv_struct_info::analyse but
4697         extended to track field offsets.
4698         (riscv_call_arg_struct): Update the struct folding special cases
4699         to handle cases where empty C++ structs, which are non-zero
4700         length, are found.
4701         (riscv_arg_location): Initialise the length of each location, a
4702         non-zero length now indicates the location is in use.
4703         (riscv_push_dummy_call): Allow for the first location having a
4704         non-zero offset when setting up arguments.
4705         (riscv_return_value): Likewise, but for return values.
4706
4707 2019-04-11  Tom Tromey  <tromey@adacore.com>
4708
4709         * utils.c (internal_vproblem): Make "msg" const.
4710
4711 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4712
4713         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4714         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4715         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4716         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4717
4718 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4719
4720         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4721         function.
4722         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4723         of amd64_collect_native_gregset.
4724         (amd64_linux_nat_target::store_registers): Likewise.
4725
4726 2019-04-10  Tom Tromey  <tom@tromey.com>
4727
4728         * symtab.c (lookup_global_symbol_from_objfile)
4729         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4730         * objfiles.h (class separate_debug_iterator): New.
4731         (class separate_debug_range): New.
4732         (struct objfile) <separate_debug_objfiles>: New method.
4733         (objfile_separate_debug_iterate): Don't declare.
4734         * objfiles.c (separate_debug_iterator::operator++): Rename from
4735         objfile_separate_debug_iterate.
4736         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4737         iterator.
4738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4739         iterator.
4740
4741 2019-04-10  Tom Tromey  <tom@tromey.com>
4742
4743         * symfile.c (reread_symbols): Remove old comment.
4744         * objfiles.c (free_all_objfiles): Fix a typo.
4745
4746 2019-04-10  Tom Tromey  <tom@tromey.com>
4747
4748         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4749         * minsyms.c (lookup_minimal_symbol): Use foreach.
4750         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4751         (lookup_minimal_symbol_solib_trampoline): Likewise.
4752         * symfile.c (reread_symbols): Use foreach.
4753
4754 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4755             Tom Tromey  <tromey@adacore.com>
4756
4757         PR rust/24414:
4758         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4759         (rust_lex_int_test): Change "value" to be LONGEST.
4760         (rust_lex_tests): Add test for long integer literal.
4761
4762 2019-04-09  Tom Tromey  <tromey@adacore.com>
4763
4764         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4765         to bool.
4766         (extended_remote_target::attach): Update.
4767         (remote_target::remote_notice_new_inferior): Update.
4768         (remote_target::add_current_inferior_and_thread): Update.
4769         * inferior.c (exit_inferior_1): Use "false".
4770         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4771
4772 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4773
4774         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4775         the "start" command.
4776
4777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4778
4779         * python/py-inferior.c (infpy_thread_from_thread_handle):
4780         Adjust comments to reflect renaming of thread_from_thread_handle
4781         to thread_from_handle.  Adjust keywords.  Fix type error message.
4782         (inferior_object_methods): Add thread_from_handle.  Retain
4783         thread_from_thread_handle, but mark it as deprecated.
4784
4785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4786
4787         * gdbthread.h (find_thread_by_handle): Revise declaration.
4788         * thread.c (find_thread_by_handle): Likewise.  Adjust
4789         implementation too.
4790         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4791         support for buffer objects as handles.
4792
4793 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4794
4795         * python/py-infthread.c (thpy_thread_handle): New function.
4796         (thread_object_methods): Register thpy_thread_handle.
4797
4798 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4799
4800         * gdbthread.h (thread_to_thread_handle): Declare.
4801         * thread.c (gdbtypes.h): Include.
4802         (thread_to_thread_handle): New function.
4803
4804         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4805         (target_thread_info_to_thread_handle): Declare.
4806         * target.c (target_thread_info_to_thread_handle): New function.
4807         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4808         * target-delegates.c: Regenerate.
4809
4810         * linux-thread-db.c (class thread_db_target): Add method
4811         thread_info_to_thread_handle.
4812         (thread_db_target::thread_info_to_thread_handle): Define.
4813         * remote.c (class remote_target): Add new method
4814         thread_info_to_thread_handle.
4815         (remote_target::thread_info_to_thread_handle): Define.
4816
4817 2019-04-08  Pedro Alves  <palves@redhat.com>
4818
4819         * common/common-exceptions.c (throw_exception): Don't create
4820         named object to throw; throw directly.
4821         (throw_it): Likewise.  Don't initialize gdb_exception::message
4822         here, with new; pass FMT and AP to the ctor instead.
4823         * common/common-exceptions.h: Include <string>.
4824         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4825         const char *, va_list)): New ctor.  Use std::make_shared.
4826         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4827         errors)): Delete.
4828         (gdb_exception_error::gdb_exception_error(enum errors, const char
4829         *, va_list)): New.
4830         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4831         Add assertion.
4832         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4833         errors)): Delete.
4834         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4835         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4836         Add assertion.
4837
4838 2019-04-08  Tom Tromey  <tom@tromey.com>
4839
4840         * valops.c (value_rtti_indirect_type): Replace throw_exception
4841         with throw.
4842         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4843         with throw.
4844         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4845         throw.
4846         * target.c (target_translate_tls_address): Replace throw_exception
4847         with throw.
4848         * stack.c (frame_apply_command_count): Replace throw_exception
4849         with throw.
4850         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4851         throw.
4852         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4853         with throw.
4854         * rs6000-tdep.c (rs6000_frame_cache)
4855         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4856         * remote.c: Replace throw_exception with throw.
4857         * record-full.c (record_full_message, record_full_wait_1)
4858         (record_full_restore): Replace throw_exception with throw.
4859         * record-btrace.c:
4860         (get_thread_current_frame_id, record_btrace_start_replaying)
4861         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4862         (cmd_record_btrace_start): Replace throw_exception with throw.
4863         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4864         throw.
4865         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4866         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4867         * linespec.c:
4868         (find_linespec_symbols): Replace throw_exception with throw.
4869         * infrun.c (displaced_step_prepare, resume): Replace
4870         throw_exception with throw.
4871         * infcmd.c (post_create_inferior): Replace throw_exception with
4872         throw.
4873         * inf-loop.c (inferior_event_handler): Replace throw_exception
4874         with throw.
4875         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4876         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4877         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4878         (get_prev_frame_always, get_frame_pc_if_available)
4879         (get_frame_address_in_block_if_available, get_frame_language):
4880         Replace throw_exception with throw.
4881         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4882         throw_exception with throw.
4883         * eval.c (fetch_subexp_value, evaluate_var_value)
4884         (evaluate_funcall, evaluate_subexp_standard): Replace
4885         throw_exception with throw.
4886         * dwarf2loc.c (call_site_find_chain)
4887         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4888         Replace throw_exception with throw.
4889         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4890         with throw.
4891         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4892         throw.
4893         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4894         * completer.c (complete_line_internal): Replace throw_exception
4895         with throw.
4896         * compile/compile-object-run.c (compile_object_run): Replace
4897         throw_exception with throw.
4898         * cli/cli-script.c (process_next_line): Replace throw_exception
4899         with throw.
4900         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4901         (btrace_enable, btrace_maint_update_pt_packets): Replace
4902         throw_exception with throw.
4903         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4904         throw_exception with throw.
4905         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4906         throw_exception with throw.
4907         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4908         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4909         * aarch64-tdep.c (aarch64_make_prologue_cache)
4910         (aarch64_make_stub_cache): Replace throw_exception with throw.
4911
4912 2019-04-08  Tom Tromey  <tom@tromey.com>
4913
4914         * common/common-exceptions.c (throw_exception): Rename from
4915         throw_exception_cxx.  Remove old copy.  Make argument const.
4916         (throw_it): Create and throw exception objects directly.
4917         * common/common-exceptions.h (throw_exception): Make argument
4918         const.
4919         (struct gdb_exception_error): Add constructor.
4920         (struct gdb_exception_quit): Add constructor.
4921
4922 2019-04-08  Tom Tromey  <tom@tromey.com>
4923
4924         * common/common-exceptions.h (exception_rethrow): Don't declare.
4925         (TRY_SJLJ): Update comment.
4926         (TRY, CATCH, END_CATCH): Remove.
4927         * common/common-exceptions.c (exception_rethrow): Remove.
4928
4929 2019-04-08  Tom Tromey  <tom@tromey.com>
4930
4931         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4932         Remove.
4933         (gdb_exception_error): Rename from
4934         gdb_exception_RETURN_MASK_ERROR.
4935         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4936         (gdb_quit_bad_alloc): Update.
4937         * aarch64-tdep.c: Update.
4938         * ada-lang.c: Update.
4939         * ada-typeprint.c: Update.
4940         * ada-valprint.c: Update.
4941         * amd64-tdep.c: Update.
4942         * arch-utils.c: Update.
4943         * break-catch-throw.c: Update.
4944         * breakpoint.c: Update.
4945         * btrace.c: Update.
4946         * c-varobj.c: Update.
4947         * cli/cli-cmds.c: Update.
4948         * cli/cli-interp.c: Update.
4949         * cli/cli-script.c: Update.
4950         * common/common-exceptions.c: Update.
4951         * common/new-op.c: Update.
4952         * common/selftest.c: Update.
4953         * compile/compile-c-symbols.c: Update.
4954         * compile/compile-cplus-symbols.c: Update.
4955         * compile/compile-object-load.c: Update.
4956         * compile/compile-object-run.c: Update.
4957         * completer.c: Update.
4958         * corelow.c: Update.
4959         * cp-abi.c: Update.
4960         * cp-support.c: Update.
4961         * cp-valprint.c: Update.
4962         * darwin-nat.c: Update.
4963         * disasm-selftests.c: Update.
4964         * dtrace-probe.c: Update.
4965         * dwarf-index-cache.c: Update.
4966         * dwarf-index-write.c: Update.
4967         * dwarf2-frame-tailcall.c: Update.
4968         * dwarf2-frame.c: Update.
4969         * dwarf2loc.c: Update.
4970         * dwarf2read.c: Update.
4971         * eval.c: Update.
4972         * event-loop.c: Update.
4973         * event-top.c: Update.
4974         * exec.c: Update.
4975         * f-valprint.c: Update.
4976         * fbsd-tdep.c: Update.
4977         * frame-unwind.c: Update.
4978         * frame.c: Update.
4979         * gdbtypes.c: Update.
4980         * gnu-v3-abi.c: Update.
4981         * guile/guile-internal.h: Update.
4982         * guile/scm-block.c: Update.
4983         * guile/scm-breakpoint.c: Update.
4984         * guile/scm-cmd.c: Update.
4985         * guile/scm-disasm.c: Update.
4986         * guile/scm-frame.c: Update.
4987         * guile/scm-lazy-string.c: Update.
4988         * guile/scm-math.c: Update.
4989         * guile/scm-param.c: Update.
4990         * guile/scm-ports.c: Update.
4991         * guile/scm-pretty-print.c: Update.
4992         * guile/scm-symbol.c: Update.
4993         * guile/scm-symtab.c: Update.
4994         * guile/scm-type.c: Update.
4995         * guile/scm-value.c: Update.
4996         * i386-linux-tdep.c: Update.
4997         * i386-tdep.c: Update.
4998         * inf-loop.c: Update.
4999         * infcall.c: Update.
5000         * infcmd.c: Update.
5001         * infrun.c: Update.
5002         * jit.c: Update.
5003         * language.c: Update.
5004         * linespec.c: Update.
5005         * linux-fork.c: Update.
5006         * linux-nat.c: Update.
5007         * linux-tdep.c: Update.
5008         * linux-thread-db.c: Update.
5009         * main.c: Update.
5010         * mi/mi-cmd-break.c: Update.
5011         * mi/mi-cmd-stack.c: Update.
5012         * mi/mi-interp.c: Update.
5013         * mi/mi-main.c: Update.
5014         * objc-lang.c: Update.
5015         * p-valprint.c: Update.
5016         * parse.c: Update.
5017         * ppc-linux-tdep.c: Update.
5018         * printcmd.c: Update.
5019         * python/py-arch.c: Update.
5020         * python/py-breakpoint.c: Update.
5021         * python/py-cmd.c: Update.
5022         * python/py-finishbreakpoint.c: Update.
5023         * python/py-frame.c: Update.
5024         * python/py-framefilter.c: Update.
5025         * python/py-gdb-readline.c: Update.
5026         * python/py-inferior.c: Update.
5027         * python/py-infthread.c: Update.
5028         * python/py-lazy-string.c: Update.
5029         * python/py-linetable.c: Update.
5030         * python/py-objfile.c: Update.
5031         * python/py-param.c: Update.
5032         * python/py-prettyprint.c: Update.
5033         * python/py-progspace.c: Update.
5034         * python/py-record-btrace.c: Update.
5035         * python/py-record.c: Update.
5036         * python/py-symbol.c: Update.
5037         * python/py-type.c: Update.
5038         * python/py-unwind.c: Update.
5039         * python/py-utils.c: Update.
5040         * python/py-value.c: Update.
5041         * python/python.c: Update.
5042         * record-btrace.c: Update.
5043         * record-full.c: Update.
5044         * remote-fileio.c: Update.
5045         * remote.c: Update.
5046         * riscv-tdep.c: Update.
5047         * rs6000-aix-tdep.c: Update.
5048         * rs6000-tdep.c: Update.
5049         * rust-exp.y: Update.
5050         * rust-lang.c: Update.
5051         * s390-tdep.c: Update.
5052         * selftest-arch.c: Update.
5053         * solib-dsbt.c: Update.
5054         * solib-frv.c: Update.
5055         * solib-spu.c: Update.
5056         * solib-svr4.c: Update.
5057         * solib.c: Update.
5058         * sparc64-linux-tdep.c: Update.
5059         * stack.c: Update.
5060         * symfile-mem.c: Update.
5061         * symmisc.c: Update.
5062         * target.c: Update.
5063         * thread.c: Update.
5064         * top.c: Update.
5065         * tracefile-tfile.c: Update.
5066         * tui/tui.c: Update.
5067         * typeprint.c: Update.
5068         * unittests/cli-utils-selftests.c: Update.
5069         * unittests/parse-connection-spec-selftests.c: Update.
5070         * valops.c: Update.
5071         * valprint.c: Update.
5072         * value.c: Update.
5073         * varobj.c: Update.
5074         * windows-nat.c: Update.
5075         * x86-linux-nat.c: Update.
5076         * xml-support.c: Update.
5077
5078 2019-04-08  Tom Tromey  <tom@tromey.com>
5079
5080         * xml-support.c: Use C++ exception handling.
5081         * x86-linux-nat.c: Use C++ exception handling.
5082         * windows-nat.c: Use C++ exception handling.
5083         * varobj.c: Use C++ exception handling.
5084         * value.c: Use C++ exception handling.
5085         * valprint.c: Use C++ exception handling.
5086         * valops.c: Use C++ exception handling.
5087         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5088         handling.
5089         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5090         * typeprint.c: Use C++ exception handling.
5091         * tui/tui.c: Use C++ exception handling.
5092         * tracefile-tfile.c: Use C++ exception handling.
5093         * top.c: Use C++ exception handling.
5094         * thread.c: Use C++ exception handling.
5095         * target.c: Use C++ exception handling.
5096         * symmisc.c: Use C++ exception handling.
5097         * symfile-mem.c: Use C++ exception handling.
5098         * stack.c: Use C++ exception handling.
5099         * sparc64-linux-tdep.c: Use C++ exception handling.
5100         * solib.c: Use C++ exception handling.
5101         * solib-svr4.c: Use C++ exception handling.
5102         * solib-spu.c: Use C++ exception handling.
5103         * solib-frv.c: Use C++ exception handling.
5104         * solib-dsbt.c: Use C++ exception handling.
5105         * selftest-arch.c: Use C++ exception handling.
5106         * s390-tdep.c: Use C++ exception handling.
5107         * rust-lang.c: Use C++ exception handling.
5108         * rust-exp.y: Use C++ exception handling.
5109         * rs6000-tdep.c: Use C++ exception handling.
5110         * rs6000-aix-tdep.c: Use C++ exception handling.
5111         * riscv-tdep.c: Use C++ exception handling.
5112         * remote.c: Use C++ exception handling.
5113         * remote-fileio.c: Use C++ exception handling.
5114         * record-full.c: Use C++ exception handling.
5115         * record-btrace.c: Use C++ exception handling.
5116         * python/python.c: Use C++ exception handling.
5117         * python/py-value.c: Use C++ exception handling.
5118         * python/py-utils.c: Use C++ exception handling.
5119         * python/py-unwind.c: Use C++ exception handling.
5120         * python/py-type.c: Use C++ exception handling.
5121         * python/py-symbol.c: Use C++ exception handling.
5122         * python/py-record.c: Use C++ exception handling.
5123         * python/py-record-btrace.c: Use C++ exception handling.
5124         * python/py-progspace.c: Use C++ exception handling.
5125         * python/py-prettyprint.c: Use C++ exception handling.
5126         * python/py-param.c: Use C++ exception handling.
5127         * python/py-objfile.c: Use C++ exception handling.
5128         * python/py-linetable.c: Use C++ exception handling.
5129         * python/py-lazy-string.c: Use C++ exception handling.
5130         * python/py-infthread.c: Use C++ exception handling.
5131         * python/py-inferior.c: Use C++ exception handling.
5132         * python/py-gdb-readline.c: Use C++ exception handling.
5133         * python/py-framefilter.c: Use C++ exception handling.
5134         * python/py-frame.c: Use C++ exception handling.
5135         * python/py-finishbreakpoint.c: Use C++ exception handling.
5136         * python/py-cmd.c: Use C++ exception handling.
5137         * python/py-breakpoint.c: Use C++ exception handling.
5138         * python/py-arch.c: Use C++ exception handling.
5139         * printcmd.c: Use C++ exception handling.
5140         * ppc-linux-tdep.c: Use C++ exception handling.
5141         * parse.c: Use C++ exception handling.
5142         * p-valprint.c: Use C++ exception handling.
5143         * objc-lang.c: Use C++ exception handling.
5144         * mi/mi-main.c: Use C++ exception handling.
5145         * mi/mi-interp.c: Use C++ exception handling.
5146         * mi/mi-cmd-stack.c: Use C++ exception handling.
5147         * mi/mi-cmd-break.c: Use C++ exception handling.
5148         * main.c: Use C++ exception handling.
5149         * linux-thread-db.c: Use C++ exception handling.
5150         * linux-tdep.c: Use C++ exception handling.
5151         * linux-nat.c: Use C++ exception handling.
5152         * linux-fork.c: Use C++ exception handling.
5153         * linespec.c: Use C++ exception handling.
5154         * language.c: Use C++ exception handling.
5155         * jit.c: Use C++ exception handling.
5156         * infrun.c: Use C++ exception handling.
5157         * infcmd.c: Use C++ exception handling.
5158         * infcall.c: Use C++ exception handling.
5159         * inf-loop.c: Use C++ exception handling.
5160         * i386-tdep.c: Use C++ exception handling.
5161         * i386-linux-tdep.c: Use C++ exception handling.
5162         * guile/scm-value.c: Use C++ exception handling.
5163         * guile/scm-type.c: Use C++ exception handling.
5164         * guile/scm-symtab.c: Use C++ exception handling.
5165         * guile/scm-symbol.c: Use C++ exception handling.
5166         * guile/scm-pretty-print.c: Use C++ exception handling.
5167         * guile/scm-ports.c: Use C++ exception handling.
5168         * guile/scm-param.c: Use C++ exception handling.
5169         * guile/scm-math.c: Use C++ exception handling.
5170         * guile/scm-lazy-string.c: Use C++ exception handling.
5171         * guile/scm-frame.c: Use C++ exception handling.
5172         * guile/scm-disasm.c: Use C++ exception handling.
5173         * guile/scm-cmd.c: Use C++ exception handling.
5174         * guile/scm-breakpoint.c: Use C++ exception handling.
5175         * guile/scm-block.c: Use C++ exception handling.
5176         * guile/guile-internal.h: Use C++ exception handling.
5177         * gnu-v3-abi.c: Use C++ exception handling.
5178         * gdbtypes.c: Use C++ exception handling.
5179         * frame.c: Use C++ exception handling.
5180         * frame-unwind.c: Use C++ exception handling.
5181         * fbsd-tdep.c: Use C++ exception handling.
5182         * f-valprint.c: Use C++ exception handling.
5183         * exec.c: Use C++ exception handling.
5184         * event-top.c: Use C++ exception handling.
5185         * event-loop.c: Use C++ exception handling.
5186         * eval.c: Use C++ exception handling.
5187         * dwarf2read.c: Use C++ exception handling.
5188         * dwarf2loc.c: Use C++ exception handling.
5189         * dwarf2-frame.c: Use C++ exception handling.
5190         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5191         * dwarf-index-write.c: Use C++ exception handling.
5192         * dwarf-index-cache.c: Use C++ exception handling.
5193         * dtrace-probe.c: Use C++ exception handling.
5194         * disasm-selftests.c: Use C++ exception handling.
5195         * darwin-nat.c: Use C++ exception handling.
5196         * cp-valprint.c: Use C++ exception handling.
5197         * cp-support.c: Use C++ exception handling.
5198         * cp-abi.c: Use C++ exception handling.
5199         * corelow.c: Use C++ exception handling.
5200         * completer.c: Use C++ exception handling.
5201         * compile/compile-object-run.c: Use C++ exception handling.
5202         * compile/compile-object-load.c: Use C++ exception handling.
5203         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5204         * compile/compile-c-symbols.c: Use C++ exception handling.
5205         * common/selftest.c: Use C++ exception handling.
5206         * common/new-op.c: Use C++ exception handling.
5207         * cli/cli-script.c: Use C++ exception handling.
5208         * cli/cli-interp.c: Use C++ exception handling.
5209         * cli/cli-cmds.c: Use C++ exception handling.
5210         * c-varobj.c: Use C++ exception handling.
5211         * btrace.c: Use C++ exception handling.
5212         * breakpoint.c: Use C++ exception handling.
5213         * break-catch-throw.c: Use C++ exception handling.
5214         * arch-utils.c: Use C++ exception handling.
5215         * amd64-tdep.c: Use C++ exception handling.
5216         * ada-valprint.c: Use C++ exception handling.
5217         * ada-typeprint.c: Use C++ exception handling.
5218         * ada-lang.c: Use C++ exception handling.
5219         * aarch64-tdep.c: Use C++ exception handling.
5220
5221 2019-04-08  Tom Tromey  <tom@tromey.com>
5222
5223         * xml-support.c (gdb_xml_parser::parse): Update.
5224         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5225         * value.c (show_convenience): Update.
5226         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5227         (test_parse_flags_qcs): Update.
5228         * thread.c (thr_try_catch_cmd): Update.
5229         * target.c (target_translate_tls_address): Update.
5230         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5231         (info_frame_command_core, frame_apply_command_count): Update.
5232         * rust-exp.y (rust_lex_exception_test): Update.
5233         * riscv-tdep.c (riscv_print_one_register_info): Update.
5234         * remote.c (remote_target::enable_btrace): Update.
5235         * record-btrace.c (record_btrace_enable_warn): Update.
5236         * python/py-utils.c (gdbpy_convert_exception): Update.
5237         * printcmd.c (do_one_display, print_variable_and_value): Update.
5238         * mi/mi-main.c (mi_print_exception): Update.
5239         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5240         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5241         * linux-nat.c (linux_nat_target::attach): Update.
5242         * linux-fork.c (class scoped_switch_fork_info): Update.
5243         * infrun.c (displaced_step_prepare): Update.
5244         * infcall.c (call_function_by_hand_dummy): Update.
5245         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5246         * gnu-v3-abi.c (print_one_vtable): Update.
5247         * frame.c (get_prev_frame_always): Update.
5248         * f-valprint.c (info_common_command_for_block): Update.
5249         * exec.c (try_open_exec_file): Update.
5250         * exceptions.c (print_exception, exception_print)
5251         (exception_fprintf, exception_print_same): Update.
5252         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5253         * dwarf-index-cache.c (index_cache::store)
5254         (index_cache::lookup_gdb_index): Update.
5255         * darwin-nat.c (maybe_cache_shell): Update.
5256         * cp-valprint.c (cp_print_value_fields): Update.
5257         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5258         (gcc_cplus_symbol_address): Update.
5259         * compile/compile-c-symbols.c (gcc_convert_symbol)
5260         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5261         * common/selftest.c: Update.
5262         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5263         a std::string.
5264         (exception_try_scope_entry, exception_try_scope_exit): Don't
5265         declare.
5266         (struct exception_try_scope): Remove.
5267         (TRY): Don't use exception_try_scope.
5268         (struct gdb_exception): Add constructor, operator=.
5269         <what>: New method.
5270         (struct gdb_exception_RETURN_MASK_ALL)
5271         (struct gdb_exception_RETURN_MASK_ERROR)
5272         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5273         (struct gdb_quit_bad_alloc): Update.
5274         * common/common-exceptions.c (exception_none): Change
5275         initializer.
5276         (struct catcher) <state, exception>: Initialize inline.
5277         <prev>: Remove member.
5278         (current_catcher): Remove.
5279         (catchers): New global.
5280         (exceptions_state_mc_init): Simplify.
5281         (catcher_pop): Remove.
5282         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5283         (try_scope_depth, exception_try_scope_entry)
5284         (exception_try_scope_exit): Remove.
5285         (throw_exception_sjlj): Update.
5286         (exception_messages, exception_messages_size): Remove.
5287         (throw_it): Simplify.
5288         (gdb_exception_sliced_copy): Remove.
5289         (throw_exception_cxx): Update.
5290         * cli/cli-script.c (script_from_file): Update.
5291         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5292         Update.
5293         * ada-valprint.c (ada_val_print): Update.
5294         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5295         (create_excep_cond_exprs): Update.
5296
5297 2019-04-08  Tom Tromey  <tom@tromey.com>
5298
5299         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5300         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5301         (TRY, CATCH, END_CATCH): Remove some definitions.
5302         * common/common-exceptions.c: Don't use GDB_XCPT.
5303         (catcher_list_size): Remove.
5304         (throw_exception, throw_it): Simplify.
5305
5306 2019-04-05  Tom Tromey  <tom@tromey.com>
5307
5308         Revert the header-sorting patch.
5309         * ft32-tdep.c: Revert.
5310         * frv-tdep.c: Revert.
5311         * frv-linux-tdep.c: Revert.
5312         * frame.c: Revert.
5313         * frame-unwind.c: Revert.
5314         * frame-base.c: Revert.
5315         * fork-child.c: Revert.
5316         * findvar.c: Revert.
5317         * findcmd.c: Revert.
5318         * filesystem.c: Revert.
5319         * filename-seen-cache.h: Revert.
5320         * filename-seen-cache.c: Revert.
5321         * fbsd-tdep.c: Revert.
5322         * fbsd-nat.h: Revert.
5323         * fbsd-nat.c: Revert.
5324         * f-valprint.c: Revert.
5325         * f-typeprint.c: Revert.
5326         * f-lang.c: Revert.
5327         * extension.h: Revert.
5328         * extension.c: Revert.
5329         * extension-priv.h: Revert.
5330         * expprint.c: Revert.
5331         * exec.h: Revert.
5332         * exec.c: Revert.
5333         * exceptions.c: Revert.
5334         * event-top.c: Revert.
5335         * event-loop.c: Revert.
5336         * eval.c: Revert.
5337         * elfread.c: Revert.
5338         * dwarf2read.h: Revert.
5339         * dwarf2read.c: Revert.
5340         * dwarf2loc.c: Revert.
5341         * dwarf2expr.h: Revert.
5342         * dwarf2expr.c: Revert.
5343         * dwarf2-frame.c: Revert.
5344         * dwarf2-frame-tailcall.c: Revert.
5345         * dwarf-index-write.h: Revert.
5346         * dwarf-index-write.c: Revert.
5347         * dwarf-index-common.c: Revert.
5348         * dwarf-index-cache.h: Revert.
5349         * dwarf-index-cache.c: Revert.
5350         * dummy-frame.c: Revert.
5351         * dtrace-probe.c: Revert.
5352         * disasm.h: Revert.
5353         * disasm.c: Revert.
5354         * disasm-selftests.c: Revert.
5355         * dictionary.c: Revert.
5356         * dicos-tdep.c: Revert.
5357         * demangle.c: Revert.
5358         * dcache.h: Revert.
5359         * dcache.c: Revert.
5360         * darwin-nat.h: Revert.
5361         * darwin-nat.c: Revert.
5362         * darwin-nat-info.c: Revert.
5363         * d-valprint.c: Revert.
5364         * d-namespace.c: Revert.
5365         * d-lang.c: Revert.
5366         * ctf.c: Revert.
5367         * csky-tdep.c: Revert.
5368         * csky-linux-tdep.c: Revert.
5369         * cris-tdep.c: Revert.
5370         * cris-linux-tdep.c: Revert.
5371         * cp-valprint.c: Revert.
5372         * cp-support.c: Revert.
5373         * cp-namespace.c: Revert.
5374         * cp-abi.c: Revert.
5375         * corelow.c: Revert.
5376         * corefile.c: Revert.
5377         * continuations.c: Revert.
5378         * completer.h: Revert.
5379         * completer.c: Revert.
5380         * complaints.c: Revert.
5381         * coffread.c: Revert.
5382         * coff-pe-read.c: Revert.
5383         * cli-out.h: Revert.
5384         * cli-out.c: Revert.
5385         * charset.c: Revert.
5386         * c-varobj.c: Revert.
5387         * c-valprint.c: Revert.
5388         * c-typeprint.c: Revert.
5389         * c-lang.c: Revert.
5390         * buildsym.c: Revert.
5391         * buildsym-legacy.c: Revert.
5392         * build-id.h: Revert.
5393         * build-id.c: Revert.
5394         * btrace.c: Revert.
5395         * bsd-uthread.c: Revert.
5396         * breakpoint.h: Revert.
5397         * breakpoint.c: Revert.
5398         * break-catch-throw.c: Revert.
5399         * break-catch-syscall.c: Revert.
5400         * break-catch-sig.c: Revert.
5401         * blockframe.c: Revert.
5402         * block.c: Revert.
5403         * bfin-tdep.c: Revert.
5404         * bfin-linux-tdep.c: Revert.
5405         * bfd-target.c: Revert.
5406         * bcache.c: Revert.
5407         * ax-general.c: Revert.
5408         * ax-gdb.h: Revert.
5409         * ax-gdb.c: Revert.
5410         * avr-tdep.c: Revert.
5411         * auxv.c: Revert.
5412         * auto-load.c: Revert.
5413         * arm-wince-tdep.c: Revert.
5414         * arm-tdep.c: Revert.
5415         * arm-symbian-tdep.c: Revert.
5416         * arm-pikeos-tdep.c: Revert.
5417         * arm-obsd-tdep.c: Revert.
5418         * arm-nbsd-tdep.c: Revert.
5419         * arm-nbsd-nat.c: Revert.
5420         * arm-linux-tdep.c: Revert.
5421         * arm-linux-nat.c: Revert.
5422         * arm-fbsd-tdep.c: Revert.
5423         * arm-fbsd-nat.c: Revert.
5424         * arm-bsd-tdep.c: Revert.
5425         * arch-utils.c: Revert.
5426         * arc-tdep.c: Revert.
5427         * arc-newlib-tdep.c: Revert.
5428         * annotate.h: Revert.
5429         * annotate.c: Revert.
5430         * amd64-windows-tdep.c: Revert.
5431         * amd64-windows-nat.c: Revert.
5432         * amd64-tdep.c: Revert.
5433         * amd64-sol2-tdep.c: Revert.
5434         * amd64-obsd-tdep.c: Revert.
5435         * amd64-obsd-nat.c: Revert.
5436         * amd64-nbsd-tdep.c: Revert.
5437         * amd64-nbsd-nat.c: Revert.
5438         * amd64-nat.c: Revert.
5439         * amd64-linux-tdep.c: Revert.
5440         * amd64-linux-nat.c: Revert.
5441         * amd64-fbsd-tdep.c: Revert.
5442         * amd64-fbsd-nat.c: Revert.
5443         * amd64-dicos-tdep.c: Revert.
5444         * amd64-darwin-tdep.c: Revert.
5445         * amd64-bsd-nat.c: Revert.
5446         * alpha-tdep.c: Revert.
5447         * alpha-obsd-tdep.c: Revert.
5448         * alpha-nbsd-tdep.c: Revert.
5449         * alpha-mdebug-tdep.c: Revert.
5450         * alpha-linux-tdep.c: Revert.
5451         * alpha-linux-nat.c: Revert.
5452         * alpha-bsd-tdep.c: Revert.
5453         * alpha-bsd-nat.c: Revert.
5454         * aix-thread.c: Revert.
5455         * agent.c: Revert.
5456         * addrmap.c: Revert.
5457         * ada-varobj.c: Revert.
5458         * ada-valprint.c: Revert.
5459         * ada-typeprint.c: Revert.
5460         * ada-tasks.c: Revert.
5461         * ada-lang.c: Revert.
5462         * aarch64-tdep.c: Revert.
5463         * aarch64-ravenscar-thread.c: Revert.
5464         * aarch64-newlib-tdep.c: Revert.
5465         * aarch64-linux-tdep.c: Revert.
5466         * aarch64-linux-nat.c: Revert.
5467         * aarch64-fbsd-tdep.c: Revert.
5468         * aarch64-fbsd-nat.c: Revert.
5469         * aarch32-linux-nat.c: Revert.
5470
5471 2019-04-05  Tom Tromey  <tom@tromey.com>
5472
5473         * ft32-tdep.c: Sort headers.
5474         * frv-tdep.c: Sort headers.
5475         * frv-linux-tdep.c: Sort headers.
5476         * frame.c: Sort headers.
5477         * frame-unwind.c: Sort headers.
5478         * frame-base.c: Sort headers.
5479         * fork-child.c: Sort headers.
5480         * findvar.c: Sort headers.
5481         * findcmd.c: Sort headers.
5482         * filesystem.c: Sort headers.
5483         * filename-seen-cache.h: Sort headers.
5484         * filename-seen-cache.c: Sort headers.
5485         * fbsd-tdep.c: Sort headers.
5486         * fbsd-nat.h: Sort headers.
5487         * fbsd-nat.c: Sort headers.
5488         * f-valprint.c: Sort headers.
5489         * f-typeprint.c: Sort headers.
5490         * f-lang.c: Sort headers.
5491         * extension.h: Sort headers.
5492         * extension.c: Sort headers.
5493         * extension-priv.h: Sort headers.
5494         * expprint.c: Sort headers.
5495         * exec.h: Sort headers.
5496         * exec.c: Sort headers.
5497         * exceptions.c: Sort headers.
5498         * event-top.c: Sort headers.
5499         * event-loop.c: Sort headers.
5500         * eval.c: Sort headers.
5501         * elfread.c: Sort headers.
5502         * dwarf2read.h: Sort headers.
5503         * dwarf2read.c: Sort headers.
5504         * dwarf2loc.c: Sort headers.
5505         * dwarf2expr.h: Sort headers.
5506         * dwarf2expr.c: Sort headers.
5507         * dwarf2-frame.c: Sort headers.
5508         * dwarf2-frame-tailcall.c: Sort headers.
5509         * dwarf-index-write.h: Sort headers.
5510         * dwarf-index-write.c: Sort headers.
5511         * dwarf-index-common.c: Sort headers.
5512         * dwarf-index-cache.h: Sort headers.
5513         * dwarf-index-cache.c: Sort headers.
5514         * dummy-frame.c: Sort headers.
5515         * dtrace-probe.c: Sort headers.
5516         * disasm.h: Sort headers.
5517         * disasm.c: Sort headers.
5518         * disasm-selftests.c: Sort headers.
5519         * dictionary.c: Sort headers.
5520         * dicos-tdep.c: Sort headers.
5521         * demangle.c: Sort headers.
5522         * dcache.h: Sort headers.
5523         * dcache.c: Sort headers.
5524         * darwin-nat.h: Sort headers.
5525         * darwin-nat.c: Sort headers.
5526         * darwin-nat-info.c: Sort headers.
5527         * d-valprint.c: Sort headers.
5528         * d-namespace.c: Sort headers.
5529         * d-lang.c: Sort headers.
5530         * ctf.c: Sort headers.
5531         * csky-tdep.c: Sort headers.
5532         * csky-linux-tdep.c: Sort headers.
5533         * cris-tdep.c: Sort headers.
5534         * cris-linux-tdep.c: Sort headers.
5535         * cp-valprint.c: Sort headers.
5536         * cp-support.c: Sort headers.
5537         * cp-namespace.c: Sort headers.
5538         * cp-abi.c: Sort headers.
5539         * corelow.c: Sort headers.
5540         * corefile.c: Sort headers.
5541         * continuations.c: Sort headers.
5542         * completer.h: Sort headers.
5543         * completer.c: Sort headers.
5544         * complaints.c: Sort headers.
5545         * coffread.c: Sort headers.
5546         * coff-pe-read.c: Sort headers.
5547         * cli-out.h: Sort headers.
5548         * cli-out.c: Sort headers.
5549         * charset.c: Sort headers.
5550         * c-varobj.c: Sort headers.
5551         * c-valprint.c: Sort headers.
5552         * c-typeprint.c: Sort headers.
5553         * c-lang.c: Sort headers.
5554         * buildsym.c: Sort headers.
5555         * buildsym-legacy.c: Sort headers.
5556         * build-id.h: Sort headers.
5557         * build-id.c: Sort headers.
5558         * btrace.c: Sort headers.
5559         * bsd-uthread.c: Sort headers.
5560         * breakpoint.h: Sort headers.
5561         * breakpoint.c: Sort headers.
5562         * break-catch-throw.c: Sort headers.
5563         * break-catch-syscall.c: Sort headers.
5564         * break-catch-sig.c: Sort headers.
5565         * blockframe.c: Sort headers.
5566         * block.c: Sort headers.
5567         * bfin-tdep.c: Sort headers.
5568         * bfin-linux-tdep.c: Sort headers.
5569         * bfd-target.c: Sort headers.
5570         * bcache.c: Sort headers.
5571         * ax-general.c: Sort headers.
5572         * ax-gdb.h: Sort headers.
5573         * ax-gdb.c: Sort headers.
5574         * avr-tdep.c: Sort headers.
5575         * auxv.c: Sort headers.
5576         * auto-load.c: Sort headers.
5577         * arm-wince-tdep.c: Sort headers.
5578         * arm-tdep.c: Sort headers.
5579         * arm-symbian-tdep.c: Sort headers.
5580         * arm-pikeos-tdep.c: Sort headers.
5581         * arm-obsd-tdep.c: Sort headers.
5582         * arm-nbsd-tdep.c: Sort headers.
5583         * arm-nbsd-nat.c: Sort headers.
5584         * arm-linux-tdep.c: Sort headers.
5585         * arm-linux-nat.c: Sort headers.
5586         * arm-fbsd-tdep.c: Sort headers.
5587         * arm-fbsd-nat.c: Sort headers.
5588         * arm-bsd-tdep.c: Sort headers.
5589         * arch-utils.c: Sort headers.
5590         * arc-tdep.c: Sort headers.
5591         * arc-newlib-tdep.c: Sort headers.
5592         * annotate.h: Sort headers.
5593         * annotate.c: Sort headers.
5594         * amd64-windows-tdep.c: Sort headers.
5595         * amd64-windows-nat.c: Sort headers.
5596         * amd64-tdep.c: Sort headers.
5597         * amd64-sol2-tdep.c: Sort headers.
5598         * amd64-obsd-tdep.c: Sort headers.
5599         * amd64-obsd-nat.c: Sort headers.
5600         * amd64-nbsd-tdep.c: Sort headers.
5601         * amd64-nbsd-nat.c: Sort headers.
5602         * amd64-nat.c: Sort headers.
5603         * amd64-linux-tdep.c: Sort headers.
5604         * amd64-linux-nat.c: Sort headers.
5605         * amd64-fbsd-tdep.c: Sort headers.
5606         * amd64-fbsd-nat.c: Sort headers.
5607         * amd64-dicos-tdep.c: Sort headers.
5608         * amd64-darwin-tdep.c: Sort headers.
5609         * amd64-bsd-nat.c: Sort headers.
5610         * alpha-tdep.c: Sort headers.
5611         * alpha-obsd-tdep.c: Sort headers.
5612         * alpha-nbsd-tdep.c: Sort headers.
5613         * alpha-mdebug-tdep.c: Sort headers.
5614         * alpha-linux-tdep.c: Sort headers.
5615         * alpha-linux-nat.c: Sort headers.
5616         * alpha-bsd-tdep.c: Sort headers.
5617         * alpha-bsd-nat.c: Sort headers.
5618         * aix-thread.c: Sort headers.
5619         * agent.c: Sort headers.
5620         * addrmap.c: Sort headers.
5621         * ada-varobj.c: Sort headers.
5622         * ada-valprint.c: Sort headers.
5623         * ada-typeprint.c: Sort headers.
5624         * ada-tasks.c: Sort headers.
5625         * ada-lang.c: Sort headers.
5626         * aarch64-tdep.c: Sort headers.
5627         * aarch64-ravenscar-thread.c: Sort headers.
5628         * aarch64-newlib-tdep.c: Sort headers.
5629         * aarch64-linux-tdep.c: Sort headers.
5630         * aarch64-linux-nat.c: Sort headers.
5631         * aarch64-fbsd-tdep.c: Sort headers.
5632         * aarch64-fbsd-nat.c: Sort headers.
5633         * aarch32-linux-nat.c: Sort headers.
5634
5635 2019-04-04  Tom Tromey  <tom@tromey.com>
5636
5637         * varobj.c (varobj_create): Update.
5638         * rust-exp.y (struct rust_parser) <update_innermost_block,
5639         lookup_symbol>: New methods.
5640         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5641         Rename.
5642         (rust_parser::rust_lookup_type)
5643         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5644         * printcmd.c (display_command, do_one_display): Update.
5645         * parser-defs.h (struct parser_state) <parser_state>: Add
5646         "tracker" parameter.
5647         (block_tracker): New member.
5648         (class innermost_block_tracker) <innermost_block_tracker>: Add
5649         "types" parameter.
5650         <reset>: Remove method.
5651         (innermost_block): Don't declare.
5652         (null_post_parser): Update.
5653         * parse.c (innermost_block): Remove global.
5654         (write_dollar_variable): Update.
5655         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5656         Remove "tracker_types" parameter.
5657         (parse_expression): Add "tracker" parameter.
5658         (parse_expression_for_completion): Update.
5659         (null_post_parser): Add "tracker" parameter.
5660         * p-exp.y: Update rules.
5661         * m2-exp.y: Update rules.
5662         * language.h (struct language_defn) <la_post_parser>: Add
5663         "tracker" parameter.
5664         * go-exp.y: Update rules.
5665         * f-exp.y: Update rules.
5666         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5667         parameter.
5668         * d-exp.y: Update rules.
5669         * c-exp.y: Update rules.
5670         * breakpoint.c (set_breakpoint_condition): Create an
5671         innermost_block_tracker.
5672         (watch_command_1): Likewise.
5673         * ada-lang.c (resolve): Add "tracker" parameter.
5674         (resolve_subexp): Likewise.
5675         * ada-exp.y (write_var_from_sym): Update.
5676
5677 2019-04-04  Tom Tromey  <tom@tromey.com>
5678
5679         * type-stack.h: New file.
5680         * type-stack.c: New file.
5681         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5682         type-stack.h.
5683         (insert_into_type_stack, insert_type, push_type, push_type_int)
5684         (insert_type_address_space, pop_type, pop_type_int)
5685         (pop_typelist, pop_type_stack, append_type_stack)
5686         (push_type_stack, get_type_stack, push_typelist)
5687         (follow_type_instance_flags, follow_types): Don't declare.
5688         * parse.c (type_stack): Remove global.
5689         (parse_exp_in_context): Update.
5690         (insert_into_type_stack, insert_type, push_type, push_type_int)
5691         (insert_type_address_space, pop_type, pop_type_int)
5692         (pop_typelist, pop_type_stack, append_type_stack)
5693         (push_type_stack, get_type_stack, push_typelist)
5694         (follow_type_instance_flags, follow_types): Remove (moved to
5695         type-stack.c).
5696         * f-exp.y (type_stack): New global.
5697         Update rules.
5698         (push_kind_type, f_parse): Update.
5699         * d-exp.y (type_stack): New global.
5700         Update rules.
5701         (d_parse): Update.
5702         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5703         Update rules.
5704         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5705         (HFILES_NO_SRCDIR): Add type-stack.h.
5706
5707 2019-04-04  Tom Tromey  <tom@tromey.com>
5708
5709         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5710         (rust_parser::convert_ast_to_expression, rust_parse)
5711         (rust_lex_test_completion, rust_lex_tests): Update.
5712         * parser-defs.h (struct expr_completion_state): New.
5713         (struct parser_state) <parser_state>: Add completion parameter.
5714         <mark_struct_expression, mark_completion_tag>: New methods.
5715         <parse_completion, m_completion_state>: New members.
5716         (prefixify_expression, null_post_parser): Update.
5717         (mark_struct_expression, mark_completion_tag): Don't declare.
5718         * parse.c (parse_completion, expout_last_struct)
5719         (expout_tag_completion_type, expout_completion_name): Remove
5720         globals.
5721         (parser_state::mark_struct_expression)
5722         (parser_state::mark_completion_tag): Now methods.
5723         (prefixify_expression): Add last_struct parameter.
5724         (prefixify_subexp): Likewise.
5725         (parse_exp_1): Update.
5726         (parse_exp_in_context): Add cstate parameter.  Update.
5727         (parse_expression_for_completion): Create an
5728         expr_completion_state.
5729         (null_post_parser): Add "completion" parameter.
5730         * p-exp.y: Update rules.
5731         (yylex): Update.
5732         * language.h (struct language_defn) <la_post_parser>: Add
5733         "completing" parameter.
5734         * go-exp.y: Update rules.
5735         (lex_one_token): Update.
5736         * expression.h (parse_completion): Don't declare.
5737         * d-exp.y: Update rules.
5738         (lex_one_token): Update rules.
5739         * c-exp.y: Update rules.
5740         (lex_one_token): Update.
5741         * ada-lang.c (resolve): Add "parse_completion" parameter.
5742         (resolve_subexp): Likewise.
5743         (ada_resolve_function): Likewise.
5744
5745 2019-04-04  Tom Tromey  <tom@tromey.com>
5746
5747         * parser-defs.h (struct parser_state) <start_arglist,
5748         end_arglist>: New methods.
5749         <arglist_len, m_funcall_chain>: New members.
5750         (arglist_len, start_arglist, end_arglist): Don't declare.
5751         * parse.c (arglist_len, funcall_chain): Remove global.
5752         (start_arglist, end_arglist): Remove functions.
5753         (parse_exp_in_context): Update.
5754         * p-exp.y: Update rules.
5755         * m2-exp.y: Update rules.
5756         * go-exp.y: Update rules.
5757         * f-exp.y: Update rules.
5758         * d-exp.y: Update rules.
5759         * c-exp.y: Update rules.
5760
5761 2019-04-04  Tom Tromey  <tom@tromey.com>
5762
5763         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5764         lex_operator, push_back>: New methods.
5765         Update all rules.
5766         (rust_parser::lex_hex, lex_escape): Rename and update.
5767         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5768         (rust_parser::lex_operator): Rename and update.
5769         (rust_parser::lex_number, rustyylex, rustyyerror)
5770         (rust_lex_test_init, rust_lex_test_sequence)
5771         (rust_lex_test_push_back, rust_lex_tests): Update.
5772         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5773         parameter.
5774         <lexptr, prev_lexptr>: New members.
5775         (lexptr, prev_lexptr): Don't declare.
5776         * parse.c (lexptr, prev_lexptr): Remove globals.
5777         (parse_exp_in_context): Update.
5778         * p-exp.y (yylex, yyerror): Update.
5779         * m2-exp.y (parse_number, yylex, yyerror): Update.
5780         * go-exp.y (lex_one_token, yyerror): Update.
5781         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5782         * d-exp.y (lex_one_token, yyerror): Update.
5783         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5784         (lex_one_token, yyerror): Update.
5785         * ada-lex.l (YY_INPUT): Update.
5786         (rewind_to_char): Update.
5787         * ada-exp.y (yyerror): Update.
5788
5789 2019-04-04  Tom Tromey  <tom@tromey.com>
5790
5791         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5792         * parser-defs.h (struct parser_state) <parser_state>: Add new
5793         parameter.
5794         <comma_terminates>: New member.
5795         (comma_terminates): Don't declare global.
5796         * parse.c (comma_terminates): Remove global.
5797         (parse_exp_in_context): Update.
5798         * p-exp.y (yylex): Update.
5799         * m2-exp.y (yylex): Update.
5800         * go-exp.y (lex_one_token): Update.
5801         * f-exp.y (yylex): Update.
5802         * d-exp.y (lex_one_token): Update.
5803         * c-exp.y (lex_one_token): Update.
5804         * ada-lex.l: Update.
5805
5806 2019-04-04  Tom Tromey  <tom@tromey.com>
5807
5808         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5809         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5810         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5811         * parser-defs.h (paren_depth): Don't declare.
5812         * parse.c (paren_depth): Remove global.
5813         (parse_exp_in_context): Update.
5814         * p-exp.y (paren_depth): New global.
5815         (pascal_parse): Initialize it.
5816         * m2-exp.y (paren_depth): New global.
5817         (m2_parse): Initialize it.
5818         * go-exp.y (paren_depth): New global.
5819         (go_parse): Initialize it.
5820         * f-exp.y (paren_depth): New global.
5821         (f_parse): Initialize it.
5822         * d-exp.y (paren_depth): New global.
5823         (d_parse): Initialize it.
5824         * c-exp.y (paren_depth): New global.
5825         (c_parse): Initialize it.
5826         * ada-lex.l (paren_depth): New global.
5827         (lexer_init): Initialize it.
5828
5829 2019-04-04  Tom Tromey  <tom@tromey.com>
5830
5831         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5832         (rust_parser::convert_ast_to_type)
5833         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5834         * parser-defs.h (struct parser_state) <parser_state>: Add
5835         parameters.  Initialize new members.
5836         <expression_context_block, expression_context_pc>: New members.
5837         * parse.c (expression_context_block, expression_context_pc):
5838         Remove globals.
5839         (parse_exp_in_context): Update.
5840         * p-exp.y: Update all rules.
5841         (yylex): Update.
5842         * m2-exp.y: Update all rules.
5843         (yylex): Update.
5844         * go-exp.y (yylex): Update.
5845         * f-exp.y (yylex): Update.
5846         * d-exp.y: Update all rules.
5847         (yylex): Update.
5848         * c-exp.y: Update all rules.
5849         (lex_one_token, classify_name, yylex, c_parse): Update.
5850         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5851
5852 2019-04-04  Tom Tromey  <tom@tromey.com>
5853
5854         * gdbarch.h, gdbarch.c: Rebuild.
5855         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5856         * stap-probe.h:
5857         (struct stap_parse_info): Replace "parser_state" with
5858         "expr_builder".
5859         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5860         (parser_state): New class.
5861         * parse.c (expr_builder): Rename.
5862         (expr_builder::release): Rename.
5863         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5864         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5865         (write_exp_elt_longcst, write_exp_elt_floatcst)
5866         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5867         (write_exp_string_vector, write_exp_bitstring)
5868         (write_exp_msymbol, mark_struct_expression)
5869         (write_dollar_variable)
5870         (insert_type_address_space, increase_expout_size): Replace
5871         "parser_state" with "expr_builder".
5872         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5873         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5874         "parser_state" with "expr_builder".
5875
5876 2019-04-04  Tom Tromey  <tom@tromey.com>
5877
5878         * rust-exp.y: Replace "parse_language" with method call.
5879         * p-exp.y:
5880         (yylex): Replace "parse_language" with method call.
5881         * m2-exp.y:
5882         (yylex): Replace "parse_language" with method call.
5883         * go-exp.y (classify_name): Replace "parse_language" with method
5884         call.
5885         * f-exp.y (yylex): Replace "parse_language" with method call.
5886         * d-exp.y (lex_one_token): Replace "parse_language" with method
5887         call.
5888         * c-exp.y:
5889         (lex_one_token, classify_name, yylex): Replace "parse_language"
5890         with method call.
5891         * ada-exp.y (find_primitive_type, type_char)
5892         (type_system_address): Replace "parse_language" with method call.
5893
5894 2019-04-04  Tom Tromey  <tom@tromey.com>
5895
5896         * rust-exp.y: Replace "parse_gdbarch" with method call.
5897         * parse.c (write_dollar_variable, insert_type_address_space):
5898         Replace "parse_gdbarch" with method call.
5899         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5900         call.
5901         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5902         call.
5903         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5904         "parse_gdbarch" with method call.
5905         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5906         with method call.
5907         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5908         "parse_gdbarch" with method call.
5909         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5910         "parse_gdbarch" with method call.
5911         * c-exp.y (parse_type, parse_number, classify_name): Replace
5912         "parse_gdbarch" with method call.
5913         * ada-lex.l: Replace "parse_gdbarch" with method call.
5914         * ada-exp.y (parse_type, find_primitive_type, type_char)
5915         (type_system_address): Replace "parse_gdbarch" with method call.
5916
5917 2019-04-04  Tom Tromey  <tom@tromey.com>
5918
5919         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5920         * stap-probe.c (stap_parse_argument): Update.
5921         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5922         initial_size parameter.
5923         * rust-exp.y (rust_lex_tests): Update.
5924         * parse.c (parser_state): Update.
5925         (parse_exp_in_context): Update.
5926         * parser-defs.h (struct parser_state) <parser_state>: Remove
5927         "initial_size" parameter.
5928
5929 2019-04-04  Tom Tromey  <tom@tromey.com>
5930
5931         * parser-defs.h (increase_expout_size): Don't declare.
5932         * parse.c (increase_expout_size): Now static.
5933
5934 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5935
5936         * gnu-nat.c (gnu_nat_target::wait): Fix
5937         target_waitstatus_to_string call.
5938
5939 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * eval.c (evaluate_subexp_standard): Handle internal functions
5942         during Fortran function call handling.
5943
5944 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * NEWS: Mention new internal functions.
5947         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5948         (read_base_type): Use dwarf2_init_complex_target_type.
5949         * value.c (creal_internal_fn): New function.
5950         (cimag_internal_fn): New function.
5951         (_initialize_values): Register new internal functions.
5952
5953 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5954
5955         * infrun.c (stop_all_threads): If debug_infrun, always
5956         trace the wait status after wait_one, using
5957         target_waitstatus_to_string and target_pid_to_str.
5958         (handle_inferior_event): Replace various trace of
5959         wait status kind by a single trace.
5960         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5961         wait status kind image by target_waitstatus_to_string.
5962         * target/waitstatus.c (target_waitstatus_to_string): Fix
5963         obsolete comment.
5964
5965 2019-04-01  Tom Tromey  <tromey@adacore.com>
5966
5967         PR symtab/23331:
5968         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5969
5970 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5971             Pedro Alves  <palves@redhat.com>
5972
5973         * top.c (quit_force): Call 'finalize_values'.
5974         * value.c (finalize_values): New function.
5975         * value.h (finalize_values): Declare.
5976
5977 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5978
5979         * NEWS: Announce $_gdb_major and $_gdb_minor.
5980
5981         * top.c (init_gdb_version_vars): New function.
5982         (gdb_init): Call init_gdb_version_vars.
5983
5984 2019-03-29  Tom Tromey  <tromey@adacore.com>
5985
5986         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5987         help text.  Remove dead code.
5988
5989 2019-03-29  Keith Seitz  <keiths@redhat.com>
5990
5991         From Siddhesh Poyarekar:
5992         * f-lang.h (f77_get_upperbound): Return LONGEST.
5993         (f77_get_lowerbound): Likewise.
5994         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5995         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5996         print them.
5997         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5998         plongest to format print it.
5999         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6000         (f77_get_upperbound): Likewise.
6001         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6002         LOWER_BOUND to LONGEST.
6003         (f77_create_arrayprint_offset_tbl): Likewise.
6004
6005 2019-03-29  Keith Seitz  <keiths@redhat.com>
6006
6007         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6008         %s/pulongest for TYPE_LENGTH instead of %d in format
6009         strings.
6010         * ada-typerint.c (ada_print_type): Likewise.
6011         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6012         * compile/compile-c-support.c (generate_register_struct): Likewise.
6013         * gdbtypes.c (recursive_dump_type): Likewise.
6014         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6015         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6016         instead of %d in format strings.
6017         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6018         to std::min to ULONGEST.
6019         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6020         instead of %d in format strings.
6021         * tracepoint.c (info_scope_command): Likewise.
6022         * typeprint.c (print_offset_data::update)
6023         (print_offset_data::finish): Likewise.
6024         * xtensa-tdep.c (xtensa_store_return_value)
6025         (xtensa_push_dummy_call): Likewise.
6026
6027 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6028
6029         * windows-nat.c (display_selector): Fixed format specifications
6030         for 64-bit Cygwin.
6031
6032 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6033
6034         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6035
6036 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6037
6038         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6039         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6040         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6041         (nios2_linux_init_abi): Install it.
6042
6043 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6044
6045         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6046
6047 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6048
6049         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6050
6051 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6052             Tom Tromey  <tromey@adacore.com>
6053
6054         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6055
6056 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6057
6058         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6059         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6060         method to compute the bounds of range types. Also print "[evaluated]"
6061         if the bounds' values come from a dynamic evaluation.
6062
6063 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6066         whitespace when pretty printing is on.
6067
6068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6069
6070         * ppc-linux-nat.c: Add include.
6071
6072 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * NEWS: Mention AArch64 Pointer Authentication.
6075
6076 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6077
6078         * arm-linux-nat.c: Add include.
6079
6080 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6081
6082         * source-cache.c (source_cache::get_source_lines): Re-read
6083         fullname after calling open_source_file.
6084
6085 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6086
6087         * NEWS: Mention TLS support for FreeBSD.
6088
6089 2019-03-25  Tom Tromey  <tromey@adacore.com>
6090
6091         * minsyms.c (BUNCH_SIZE): Update comment.
6092         (~minimal_symbol_reader): Remove old comment.
6093         (compact_minimal_symbols): Update comment.
6094         (minimal_symbol_reader::install): Remove old comment.  Update
6095         other comments.
6096
6097 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6098
6099         * s390-linux-nat.c: Add include.
6100
6101 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6102
6103         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6104         Call linux_get_hwcap.
6105         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6106         Likewise.
6107         (aarch64_linux_get_hwcap): Remove function.
6108         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6109         declaration.
6110         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6111         linux_get_hwcap.
6112         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6113         * linux-tdep.c (linux_get_hwcap): Add function.
6114         (linux_get_hwcap2): Likewise.
6115         * linux-tdep.h (linux_get_hwcap): Add declaration.
6116         (linux_get_hwcap2): Likewise.
6117         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6118         (ppc_linux_get_hwcap2): Likewise.
6119         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6120         linux_get_hwcap.
6121         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6122         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6123         (ppc_linux_nat_target::read_description): Likewise.
6124         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6125         * s390-linux-nat.c: Likewise.
6126         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6127
6128 2019-03-24  Tom Tromey  <tom@tromey.com>
6129
6130         * ada-lang.c (standard_lookup): Simplify initialization.
6131         (ada_lookup_symbol_nonlocal): Simplify return.
6132         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6133         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6134         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6135         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6136         initialization.
6137         * solib.c (solib_global_lookup): Simplify.
6138         * symtab.c (null_block_symbol): Remove.
6139         (symbol_cache_lookup): Simplify returns.
6140         (lookup_language_this): Simplify returns.
6141         (lookup_symbol_aux): Simplify return.
6142         (lookup_local_symbol): Simplify returns.
6143         (lookup_global_symbol_from_objfile): Simplify return.
6144         (lookup_symbol_in_objfile_symtabs)
6145         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6146         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6147         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6148         * cp-namespace.c (cp_lookup_bare_symbol)
6149         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6150         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6151         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6152         (cp_lookup_symbol_via_imports): Simplify initialization.
6153         (find_symbol_in_baseclass): Likewise.
6154         * symtab.h (null_block_symbol): Remove.
6155         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6156         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6157         (d_lookup_symbol_module): Likewise.
6158         (find_symbol_in_baseclass): Simplify initialization.
6159
6160 2019-03-24  Tom Tromey  <tom@tromey.com>
6161
6162         * expression.h: Don't include symtab.h.
6163         (struct block): Forward declare.
6164
6165 2019-03-24  Tom Tromey  <tom@tromey.com>
6166
6167         * c-exp.y (typebase): Remove casts.
6168         * gdbtypes.c (lookup_unsigned_typename, )
6169         (lookup_signed_typename): Remove cast.
6170         * eval.c (parse_to_comma_and_eval): Remove cast.
6171         * parse.c (write_dollar_variable): Remove cast.
6172         * block.h (struct block) <superblock>: Now const.
6173         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6174         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6175         (map_block): Make "block" const.
6176         * symfile.h (struct quick_symbol_functions)
6177         <map_matching_symbols>: Constify block argument to "callback".
6178         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6179         const.
6180         (find_pc_sect_compunit_symtab): Make "b" const.
6181         (find_symbol_at_address): Likewise.
6182         (search_symbols): Likewise.
6183         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6184         (dw2_debug_names_lookup_symbol): Likewise.
6185         (dw2_map_matching_symbols): Update.
6186         * p-valprint.c (pascal_val_print): Remove "block".
6187         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6188         (aux_add_nonlocal_symbols): Make "block" const.
6189         (resolve_subexp): Remove cast.
6190         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6191         const.
6192         (iterate_over_file_blocks): Likewise.
6193         * f-exp.y (%union) <bval>: Remove.
6194         * coffread.c (patch_opaque_types): Make "b" const.
6195         * spu-tdep.c (spu_catch_start): Make "block" const.
6196         * c-valprint.c (print_unpacked_pointer): Remove "block".
6197         * symmisc.c (dump_symtab_1): Make "b" const.
6198         (block_depth): Make "block" const.
6199         * d-exp.y (%union) <bval>: Remove.
6200         * cp-support.h (cp_lookup_rtti_type): Update.
6201         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6202         * psymtab.c (psym_lookup_symbol): Make "block" const.
6203         (maintenance_check_psymtabs): Make "b" const.
6204         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6205         (enumerate_locals, enumerate_args): Update.
6206         * python/py-symtab.c (stpy_global_block): Make "block" const.
6207         (stpy_static_block): Likewise.
6208         * inline-frame.c (block_starting_point_at): Make "new_block"
6209         const.
6210         * block.c (find_block_in_blockvector): Make return type const.
6211         (blockvector_for_pc_sect): Make "b" const.
6212         (find_block_in_blockvector): Make "b" const.
6213
6214 2019-03-23  Tom Tromey  <tom@tromey.com>
6215
6216         * varobj.c (varobj_create): Update.
6217         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6218         * printcmd.c (display_command, do_one_display): Don't reset
6219         innermost_block.
6220         * parser-defs.h (enum innermost_block_tracker_type): Move to
6221         expression.h.
6222         (innermost_block): Update comment.
6223         * parse.c (parse_exp_1): Add tracker_types parameter.
6224         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6225         tracker_types parameter.  Reset innermost_block.
6226         (parse_exp_in_context): Remove.
6227         (parse_expression_for_completion): Update.
6228         * objfiles.c (~objfile): Don't reset expression_context_block or
6229         innermost_block.
6230         * expression.h (enum innermost_block_tracker_type): Move from
6231         parser-defs.h.
6232         (parse_exp_1): Add tracker_types parameter.
6233         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6234         reset innermost_block.
6235
6236 2019-03-23  Tom Tromey  <tom@tromey.com>
6237
6238         * objfiles.h: Include bcache.h.
6239
6240 2019-03-23  Tom Tromey  <tom@tromey.com>
6241
6242         * linespec.c (get_current_search_block): Use
6243         scoped_restore_current_language.
6244         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6245
6246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6247             Jiong Wang  <jiong.wang@arm.com>
6248
6249         * aarch64-linux-tdep.c
6250         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6251         section.
6252         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6253
6254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6255             Jiong Wang  <jiong.wang@arm.com>
6256
6257         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6258         instructions.
6259         (aarch64_analyze_prologue_test): Add PACIASP test.
6260         (aarch64_prologue_prev_register): Unmask PC value.
6261
6262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6263             Jiong Wang  <jiong.wang@arm.com>
6264
6265         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6266         (aarch64_dwarf2_prev_register): Unmask PC value.
6267         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6268         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6269         DW_CFA_AARCH64_negate_ra_state.
6270         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6271
6272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6273             Jiong Wang  <jiong.wang@arm.com>
6274
6275         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6276         registers.
6277         (aarch64_pseudo_register_name): Likewise.
6278         (aarch64_pseudo_register_type): Likewise.
6279         (aarch64_pseudo_register_reggroup_p): Likewise.
6280         (aarch64_gdbarch_init): Add pauth registers.
6281         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6282         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6283         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6284         (struct gdbarch_tdep): Add regnum for ra_state.
6285
6286 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6287             Jiong Wang  <jiong.wang@arm.com>
6288
6289         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6290
6291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6292             Jiong Wang  <jiong.wang@arm.com>
6293
6294         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6295         function.
6296         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6297         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6298         (aarch64_gdbarch_init): Add puth registers.
6299         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6300         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6301         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6302
6303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6304             Jiong Wang  <jiong.wang@arm.com>
6305
6306         * aarch64-linux-nat.c
6307         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6308         * aarch64-linux-tdep.c
6309         (aarch64_linux_core_read_description): Likewise.
6310         (aarch64_linux_get_hwcap): New function.
6311         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6312         (aarch64_linux_get_hwcap): New declaration.
6313
6314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6315             Jiong Wang  <jiong.wang@arm.com>
6316
6317         * aarch64-linux-nat.c
6318         (aarch64_linux_nat_target::read_description): Add pauth param.
6319         * aarch64-linux-tdep.c
6320         (aarch64_linux_core_read_description): Likewise.
6321         * aarch64-tdep.c (struct target_desc): Add in pauth.
6322         (aarch64_read_description): Add pauth param.
6323         (aarch64_gdbarch_init): Likewise.
6324         * aarch64-tdep.h (aarch64_read_description): Likewise.
6325         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6326         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6327         * features/Makefile: Add new files.
6328         * features/aarch64-pauth.c: New file.
6329         * features/aarch64-pauth.xml: New file.
6330
6331 2019-03-20  Tom Tromey  <tromey@adacore.com>
6332
6333         * infrun.c (handle_inferior_event): Rename from
6334         handle_inferior_event_1.  Create a scoped_value_mark.
6335         (handle_inferior_event): Remove.
6336
6337 2019-03-19  Tom Tromey  <tromey@adacore.com>
6338
6339         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6340         * infrun.h (print_stop_event): Add "displays" parameter.
6341         * infrun.c (print_stop_event): Add "displays" parameter.
6342
6343 2019-03-19  Pedro Alves  <palves@redhat.com>
6344
6345         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6346         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6347         to -1.  Fix TABs vs spaces.
6348         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6349         * tui/tui-out.h (tui_ui_out) Add intro comments.
6350         <m_line, m_start_of_line>: In-class initialize, and add describing
6351         comment.
6352
6353 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6354
6355         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6356         variable names.
6357         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6358
6359 2019-03-18  Pedro Alves  <palves@redhat.com>
6360             Eli Zaretskii <eliz@gnu.org>
6361
6362         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6363         m_line and m_start_of_line.
6364
6365 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6366
6367         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6368         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6369         it returns a newline.  This fixes a regression in TU mode, whereby
6370         the next line is output on the same screen line as the user input.
6371
6372 2019-03-18  Tom Tromey  <tromey@adacore.com>
6373
6374         * minsyms.c (minimal_symbol_reader::install): Remove call to
6375         obstack_blank.
6376
6377 2019-03-18  Pedro Alves  <palves@redhat.com>
6378
6379         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6380         New globals.
6381         (apply_style): New, factored out from ...
6382         (apply_ansi_escape): ... this.  Handle reverse video mode.
6383         (tui_set_reverse_mode): New function.
6384         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6385         * tui/tui-winsource.c (tui_show_source_line): Use
6386         tui_set_reverse_mode instead of setting A_STANDOUT.
6387         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6388         New setter methods.
6389
6390 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6391
6392         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6393         Handle tabs.
6394
6395 2019-03-18  Tom Tromey  <tromey@adacore.com>
6396
6397         * ada-lang.c (empty_array): Add "high" parameter.
6398         (ada_evaluate_subexp): Update.
6399
6400 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6401
6402         * unittests/string_view-selftests.c: Define
6403         _initialize_string_view_selftests unconditionally.
6404
6405 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6406
6407         PR gdb/24350
6408         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6409
6410 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6411
6412         PR gdb/24351
6413         * windows-nat.c (display_selector): Fix format specifiers.
6414
6415 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6416
6417         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6418         tui_refill_source_window instead of tui_refresh_win, to update the
6419         current execution line.  This fixes redisplay of the current line
6420         when stepping through the code with "next" or "step".
6421
6422 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6423
6424         * source-cache.c (source_cache::get_source_lines): Call
6425         find_source_lines to initialize s->nlines.  This fixes vertical
6426         scrolling of TUI source window when the DOWN arrow is pressed.
6427
6428 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6429
6430         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6431         linux-thread-db.c (_initialize_thread_db): Likewise.
6432
6433 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6434
6435         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6436         wclrtoeol in tui_show_source_line".  This reverts changes made in
6437         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6438
6439 2019-03-15  Tom Tromey  <tom@tromey.com>
6440
6441         * symtab.h (struct minimal_symbol): Derive from
6442         general_symbol_info.
6443         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6444         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6445         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6446         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6447         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6448         (MSYMBOL_SEARCH_NAME): Update.
6449         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6450         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6451         * minsyms.c (minimal_symbol_reader::record_full): Update.
6452
6453 2019-03-15  Tom Tromey  <tom@tromey.com>
6454
6455         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6456
6457 2019-03-15  Tom Tromey  <tom@tromey.com>
6458
6459         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6460         unique_xmalloc_ptr.
6461         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6462         Update.
6463         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6464         (build_minimal_symbol_hash_tables)
6465         (minimal_symbol_reader::install): Update.
6466
6467 2019-03-15  Tom Tromey  <tom@tromey.com>
6468
6469         * symtab.c (create_demangled_names_hash): Update.
6470         (symbol_set_names): Update.
6471         * objfiles.h (struct objfile_per_bfd_storage)
6472         <demangled_names_hash>: Now an htab_up.
6473         * objfiles.c (objfile_per_bfd_storage): Simplify.
6474
6475 2019-03-15  Tom Tromey  <tom@tromey.com>
6476
6477         * objfiles.h (struct objfile_per_bfd_storage): Declare
6478         destructor.
6479         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6480         New.
6481         (get_objfile_bfd_data): Use new.  Don't initialize
6482         language_of_main.
6483         (free_objfile_per_bfd_storage): Remove.
6484         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6485
6486 2019-03-15  Tom Tromey  <tom@tromey.com>
6487
6488         * symfile.c (reread_symbols): Update.
6489         * objfiles.c (objfile::objfile): Update.
6490         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6491         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6492         comment.
6493         (minimal_symbol_reader::install): Update.
6494         (terminate_minimal_symbol_table): Remove.
6495         * jit.c (jit_object_close_impl): Update.
6496
6497 2019-03-15  Tom Tromey  <tom@tromey.com>
6498
6499         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6500         initializations.
6501
6502 2019-03-15  Tom Tromey  <tom@tromey.com>
6503
6504         * objfiles.h (struct objfile_per_bfd_storage)
6505         <demangled_hash_languages>: Now a bitset.
6506         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6507         (lookup_minimal_symbol): Update.
6508
6509 2019-03-15  Tom Tromey  <tom@tromey.com>
6510
6511         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6512         Don't return the symbol.
6513         * coffread.c (record_minimal_symbol): Use record_full.
6514
6515 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6516
6517         The MS-Windows port of ncurses fails to switch to a color pair if
6518         one or both of the colors are the implicit default colors.  This
6519         change records the default colors when TUI is initialized, and
6520         then specifies them explicitly when a color pair uses the default
6521         colors.  This allows color styling in TUI mode on MS-Windows.
6522
6523         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6524         ncurses_norm_attr.
6525         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6526         colors in ncurses_norm_attr.
6527         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6528         "none", replace it with the default color recorded in
6529         ncurses_norm_attr.
6530
6531 2019-03-14  Tom Tromey  <tromey@adacore.com>
6532
6533         * source-cache.h (class source_cache) <get_source_lines>: Return
6534         std::string.
6535         * source-cache.c (source_cache::extract_lines): Handle case where
6536         first_pos==npos.  Return std::string.
6537         (source_cache::get_source_lines): Update.
6538
6539 2019-03-14  Tom Tromey  <tromey@adacore.com>
6540
6541         * NEWS: Add item for "style sources" commands.
6542         * source-cache.c (source_cache::get_source_lines): Check
6543         source_styling.
6544         * cli/cli-style.c (source_styling): New global.
6545         (_initialize_cli_style): Add "style sources" commands.
6546         (show_style_sources): New function.
6547         * cli/cli-style.h (source_styling): Declare.
6548
6549 2019-03-14  Pedro Alves  <palves@redhat.com>
6550             Tom Tromey  <tromey@adacore.com>
6551
6552         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6553         * tui/tui-winsource.c (tui_refill_source_window): New function,
6554         from...
6555         (tui_horizontal_source_scroll): ... here.  Move some logic.
6556         * cli/cli-style.c (set_style_enabled): Notify new observable.
6557         * tui/tui-hooks.c (tui_redisplay_source): New function.
6558         (tui_attach_detach_observers): Attach or detach
6559         tui_redisplay_source.
6560         * observable.h (source_styling_changed): New observable.
6561         * observable.c: Define source_styling_changed observable.
6562
6563 2019-03-13  Tom Tromey  <tromey@adacore.com>
6564
6565         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6566         (i386_gnu_nat_target::store_registers): Update.
6567         * target-debug.h (target_debug_print_std_string): New macro.
6568         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6569         * windows-tdep.c (display_one_tib): Update.
6570         * tui/tui-stack.c (tui_make_status_line): Update.
6571         * top.c (print_inferior_quit_action): Update.
6572         * thread.c (thr_try_catch_cmd): Update.
6573         (add_thread_with_info): Update.
6574         (thread_target_id_str): Update.
6575         (thr_try_catch_cmd): Update.
6576         (thread_command): Update.
6577         (thread_find_command): Update.
6578         * record-btrace.c (record_btrace_target::info_record)
6579         (record_btrace_resume_thread, record_btrace_target::resume)
6580         (record_btrace_cancel_resume, record_btrace_step_thread)
6581         (record_btrace_target::wait, record_btrace_target::wait)
6582         (record_btrace_target::wait, record_btrace_target::stop): Update.
6583         * progspace.c (print_program_space): Update.
6584         * process-stratum-target.c
6585         (process_stratum_target::thread_address_space): Update.
6586         * linux-fork.c (linux_fork_mourn_inferior)
6587         (detach_checkpoint_command, info_checkpoints_command)
6588         (linux_fork_context): Update.
6589         (linux_fork_detach): Update.
6590         (class scoped_switch_fork_info): Update.
6591         (delete_checkpoint_command): Update.
6592         * infrun.c (follow_fork_inferior): Update.
6593         (follow_fork_inferior): Update.
6594         (proceed_after_vfork_done): Update.
6595         (handle_vfork_child_exec_or_exit): Update.
6596         (follow_exec): Update.
6597         (displaced_step_prepare_throw): Update.
6598         (displaced_step_restore): Update.
6599         (start_step_over): Update.
6600         (resume_1): Update.
6601         (clear_proceed_status_thread): Update.
6602         (proceed): Update.
6603         (print_target_wait_results): Update.
6604         (do_target_wait): Update.
6605         (context_switch): Update.
6606         (stop_all_threads): Update.
6607         (restart_threads): Update.
6608         (finish_step_over): Update.
6609         (handle_signal_stop): Update.
6610         (switch_back_to_stepped_thread): Update.
6611         (keep_going_pass_signal): Update.
6612         (print_exited_reason): Update.
6613         (normal_stop): Update.
6614         * inferior.c (inferior_pid_to_str): Change return type.
6615         (print_selected_inferior): Update.
6616         (add_inferior): Update.
6617         (detach_inferior): Update.
6618         * dummy-frame.c (fprint_dummy_frames): Update.
6619         * dcache.c (dcache_info_1): Update.
6620         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6621         (btrace_fetch, btrace_clear): Update.
6622         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6623         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6624         type.
6625         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6626         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6627         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6628         * gdbarch.c, gdbarch.h: Rebuild.
6629         * gdbarch.sh (core_pid_to_str): Change return type.
6630         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6631         return type.
6632         (windows_nat_target::pid_to_str): Change return type.
6633         (windows_delete_thread): Update.
6634         (windows_nat_target::attach): Update.
6635         (windows_nat_target::files_info): Update.
6636         * target-delegates.c: Rebuild.
6637         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6638         return type.
6639         (sol_thread_target::pid_to_str): Change return type.
6640         * remote.c (class remote_target) <pid_to_str>: Change return
6641         type.
6642         (remote_target::pid_to_str): Change return type.
6643         (extended_remote_target::attach, remote_target::remote_stop_ns)
6644         (remote_target::remote_notif_remove_queued_reply)
6645         (remote_target::push_stop_reply, remote_target::disable_btrace):
6646         Update.
6647         (extended_remote_target::attach): Update.
6648         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6649         type.
6650         (gdbsim_target::pid_to_str): Change return type.
6651         * ravenscar-thread.c (struct ravenscar_thread_target)
6652         <pid_to_str>: Change return type.
6653         (ravenscar_thread_target::pid_to_str): Change return type.
6654         * procfs.c (class procfs_target) <pid_to_str>: Change return
6655         type.
6656         (procfs_target::pid_to_str): Change return type.
6657         (procfs_target::attach): Update.
6658         (procfs_target::detach): Update.
6659         (procfs_target::fetch_registers): Update.
6660         (procfs_target::store_registers): Update.
6661         (procfs_target::wait): Update.
6662         (procfs_target::files_info): Update.
6663         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6664         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6665         return type.
6666         (nto_procfs_target::pid_to_str): Change return type.
6667         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6668         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6669         return type.
6670         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6671         (exit_lwp): Update.
6672         (attach_proc_task_lwp_callback, get_detach_signal)
6673         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6674         (linux_nat_target::resume, wait_lwp, stop_callback)
6675         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6676         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6677         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6678         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6679         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6680         type.
6681         (inf_ptrace_target::attach): Update.
6682         (inf_ptrace_target::files_info): Update.
6683         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6684         type.
6685         (go32_nat_target::pid_to_str): Change return type.
6686         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6687         (gnu_nat_target::wait): Update.
6688         (gnu_nat_target::wait): Update.
6689         (gnu_nat_target::resume): Update.
6690         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6691         (fbsd_nat_target::wait): Update.
6692         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6693         type.
6694         (darwin_nat_target::attach): Update.
6695         * corelow.c (class core_target) <pid_to_str>: Change return type.
6696         (core_target::pid_to_str): Change return type.
6697         * target.c (normal_pid_to_str): Change return type.
6698         (default_pid_to_str): Likewise.
6699         (target_pid_to_str): Change return type.
6700         (target_translate_tls_address): Update.
6701         (target_announce_detach): Update.
6702         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6703         return type.
6704         (bsd_uthread_target::pid_to_str): Change return type.
6705         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6706         type.
6707         (bsd_kvm_target::pid_to_str): Change return type.
6708         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6709         return type.
6710         (aix_thread_target::pid_to_str): Change return type.
6711         * target.h (struct target_ops) <pid_to_str>: Change return type.
6712         (target_pid_to_str, normal_pid_to_str): Likewise.
6713         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6714         type.
6715         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6716         type.
6717         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6718         return type.
6719         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6720         type.
6721         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6722         type.
6723         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6724         return type.
6725
6726 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6727
6728         * NEWS: Mention that the new default MI version is 3.  Mention
6729         changes to the output of commands and events that deal with
6730         multi-location breakpoints.
6731         * breakpoint.c: Include "mi/mi-out.h".
6732         (print_one_breakpoint): Change output syntax if using MI version
6733         >= 3.
6734         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6735         New.
6736         (mi_multi_location_breakpoint_output_fixed): New.
6737         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6738         (mi_cmd_fix_multi_location_breakpoint_output): New.
6739         (mi_multi_location_breakpoint_output_fixed): New.
6740         * mi/mi-cmds.c (mi_cmds): Register command
6741         -fix-multi-location-breakpoint-output.
6742         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6743         interpreter "mi".
6744
6745 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6746
6747         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6748         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6749         instantiate mi_ui_out based on interpreter name.
6750         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6751         * mi/mi-main.c (mi_load_progress): Likewise.
6752
6753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6754
6755         * NEWS: Combine separate "New targets" sections for 8.3.
6756
6757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6758
6759         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6760         (ppcfbsd_init_abi): Install gdbarch
6761         "fetch_tls_load_module_address" and "get_thread_local_address"
6762         methods.
6763
6764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6765
6766         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6767         (riscv_fbsd_init_abi): Install gdbarch
6768         "fetch_tls_load_module_address" and "get_thread_local_address"
6769         methods.
6770
6771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6772
6773         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6774         (i386fbsd_init_abi): Install gdbarch
6775         "fetch_tls_load_module_address" and "get_thread_local_address"
6776         methods.
6777
6778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6779
6780         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6781         (amd64fbsd_init_abi): Install gdbarch
6782         "fetch_tls_load_module_address" and "get_thread_local_address"
6783         methods.
6784
6785 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6786
6787         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6788         (struct fbsd_pspace_data): New type.
6789         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6790         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6791         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6792         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6793         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6794
6795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6796
6797         * gdbtypes.c (lookup_struct_elt): New function.
6798         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6799         * gdbtypes.h (struct struct_elt): New type.
6800         (lookup_struct_elt): New prototype.
6801
6802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6803
6804         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6805         remove disabled code block.
6806
6807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6808
6809         * gdbarch.sh (get_thread_local_address): New method.
6810         * gdbarch.h, gdbarch.c: Regenerate.
6811         * target.c (target_translate_tls_address): Use
6812         gdbarch_get_thread_local_address if present instead of
6813         target::get_thread_local_address.
6814
6815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6816
6817         * target.h (target::get_thread_local_address): Update comment.
6818
6819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6820
6821         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6822         objfile->separate_debug_objfile_backlink if not NULL.
6823
6824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6825
6826         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6827         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6828         (amd64bsd_store_inferior_registers): Likewise.
6829         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6830         Enable segment base registers.
6831         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6832         PT_GETFSBASE and PT_GETGSBASE.
6833         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6834         PT_SETGSBASE.
6835         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6836         segment base registers.
6837         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6838
6839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6840
6841         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6842         Update calls to i386_target_description to add 'segments'
6843         parameter.
6844         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6845         add segment base registers.
6846         * arch/i386.c (i386_create_target_description): Add 'segments'
6847         parameter to enable segment base registers.
6848         * arch/i386.h (i386_create_target_description): Likewise.
6849         * features/i386/32bit-segments.xml: New file.
6850         * features/i386/32bit-segments.c: Generate.
6851         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6852         call to i386_target_description to add 'segments' parameter.
6853         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6854         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6855         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6856         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6857         if feature is present.
6858         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6859         Add 'segments' parameter to call to i386_target_description.
6860         (i386_target_description): Add 'segments' parameter to enable
6861         segment base registers.
6862         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6863         to call to i386_target_description.
6864         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6865         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6866         Define I386_NUM_REGS.
6867         (i386_target_description): Add 'segments' parameter to enable
6868         segment base registers.
6869
6870 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6871
6872         PR/24325
6873         * source-cache.c: #undef open and close, to avoid unresolved
6874         externals during linking.
6875
6876 2019-03-12  Tom Tromey  <tromey@adacore.com>
6877
6878         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6879         const.  Add initializers.
6880         (_initialize_remote): Don't initialize ptid globals.
6881
6882 2019-03-12  Pedro Alves  <palves@redhat.com>
6883
6884         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6885
6886 2019-03-12  Pedro Alves  <palves@redhat.com>
6887
6888         * cp-name-parser.y (main): Remove unused 'len' variable.
6889
6890 2019-03-12  Tom Tromey  <tromey@adacore.com>
6891
6892         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6893         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6894
6895 2019-03-12  Tom Tromey  <tromey@adacore.com>
6896
6897         * linux-nat.c (iterate_over_lwps): Update.
6898         (stop_callback): Remove parameter.
6899         (stop_wait_callback, detach_callback, resume_set_callback)
6900         (select_singlestep_lwp_callback, set_ignore_sigint)
6901         (status_callback, resumed_callback, resume_clear_callback)
6902         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6903         data parameter.
6904         (linux_nat_target::detach, linux_nat_target::resume)
6905         (linux_stop_and_wait_all_lwps, select_event_lwp)
6906         (linux_nat_filter_event, linux_nat_wait_1)
6907         (linux_nat_target::kill, linux_nat_target::stop)
6908         (linux_nat_target::stop): Update.
6909         (linux_nat_resume_callback): Change type.
6910         (resume_stopped_resumed_lwps, count_events_callback)
6911         (select_event_lwp_callback): Likewise.
6912         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6913         * arm-linux-nat.c (struct update_registers_data): Remove.
6914         (update_registers_callback): Change type.
6915         (arm_linux_insert_hw_breakpoint1): Update.
6916         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6917         parameter.
6918         (x86_linux_dr_set_addr): Update.
6919         (x86_linux_dr_set_control): Update.
6920         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6921         (iterate_over_lwps): Use gdb::function_view.
6922         * nat/aarch64-linux-hw-point.c (struct
6923         aarch64_dr_update_callback_param): Remove.
6924         (debug_reg_change_callback): Change type.
6925         (aarch64_notify_debug_reg_change): Update.
6926         * s390-linux-nat.c (s390_refresh_per_info): Update.
6927
6928 2019-03-11  Tom Tromey  <tromey@adacore.com>
6929
6930         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6931         redundant assignment to "this_cu".
6932
6933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6934
6935         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6936
6937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6938
6939         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6940         from...
6941         (rank_one_type): ... this.
6942
6943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6944
6945         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6946         from...
6947         (rank_one_type): ... this.
6948
6949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6950
6951         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6952         from...
6953         (rank_one_type): ... this.
6954
6955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6956
6957         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6958         from...
6959         (rank_one_type): ... this.
6960
6961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6962
6963         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6964         from...
6965         (rank_one_type): ... this.
6966
6967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6968
6969         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6970         from...
6971         (rank_one_type): ... this.
6972
6973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6974
6975         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6976         from...
6977         (rank_one_type): ... this.
6978
6979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6980
6981         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6982         from...
6983         (rank_one_type): ... this.
6984
6985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6986
6987         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6988         from...
6989         (rank_one_type): ... this.
6990
6991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6992
6993         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6994         from...
6995         (rank_one_type): ... this.
6996
6997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6998
6999         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7000         from...
7001         (rank_one_type): ... this.
7002
7003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7004
7005         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7006         from...
7007         (rank_one_type): ... this.
7008
7009 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7010
7011         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7012         inferior-events' shows the example events.
7013
7014 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7015
7016         Support styling on native MS-Windows console
7017
7018         PR/24315
7019         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7020         on MS-Windows if $TERM is not defined.
7021
7022         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7023
7024         * posix-hdep.c (gdb_console_fputs):
7025         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7026         functions.
7027         * ui-file.h (gdb_console_fputs): Add prototype.
7028
7029         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7030         back to fputs only if the former returns zero.
7031
7032 2019-03-07  Tom Tromey  <tom@tromey.com>
7033
7034         * symmisc.c (print_symbol_bcache_statistics): Update.
7035         (print_objfile_statistics): Update.
7036         * symfile.c (allocate_symtab): Update.
7037         * stabsread.c: Don't include bcache.h.
7038         * psymtab.h (struct psymbol_bcache): Don't declare.
7039         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7040         (psymbol_bcache_init, psymbol_bcache_free)
7041         (psymbol_bcache_get_bcache): Don't declare.
7042         * psymtab.c (struct psymbol_bcache): Remove.
7043         (psymtab_storage::psymtab_storage): Update.
7044         (psymtab_storage::~psymtab_storage): Update.
7045         (psymbol_bcache_init, psymbol_bcache_free)
7046         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7047         (add_psymbol_to_bcache): Update.
7048         (allocate_psymtab): Update.
7049         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7050         macro_cache>: No longer pointers.
7051         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7052         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7053         * macrotab.c (macro_bcache): Update.
7054         * macroexp.c: Don't include bcache.h.
7055         * gdbtypes.c (check_types_worklist): Update.
7056         (types_deeply_equal): Remove TRY/CATCH.  Update.
7057         * elfread.c (elf_symtab_read): Update.
7058         * dwarf2read.c: Don't include bcache.h.
7059         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7060         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7061         (print_bcache_statistics, bcache_memory_used): Don't declare.
7062         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7063         methods.  Rename all data members.
7064         * bcache.c (struct bcache): Move to bcache.h.
7065         (bcache::expand_hash_table): Rename from expand_hash_table.
7066         (bcache): Remove.
7067         (bcache::insert): Rename from bcache_full.
7068         (bcache::compare): Rename from bcache_compare.
7069         (bcache_xmalloc): Remove.
7070         (bcache::~bcache): Rename from bcache_xfree.
7071         (bcache::print_statistics): Rename from print_bcache_statistics.
7072         (bcache::memory_used): Rename from bcache_memory_used.
7073
7074 2019-03-07  Pedro Alves  <palves@redhat.com>
7075
7076         * infrun.c (normal_stop): Also check for
7077         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7078
7079 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * f-lang.c (value_from_host_double): Moved to...
7082         * value.c (value_from_host_double): ...here.
7083         * value.h (value_from_host_double): Declare.
7084         * guile/scm-math.c (vlscm_convert_typed_number): Use
7085         value_from_host_double.
7086         (vlscm_convert_number): Likewise.
7087         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7088         * python/py-value.c (convert_value_from_python): Likewise.
7089
7090 2019-03-06  Tom Tromey  <tom@tromey.com>
7091
7092         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7093
7094 2019-03-06  Tom Tromey  <tom@tromey.com>
7095
7096         * utils.h (free_current_contents): Don't declare.
7097         * utils.c (free_current_contents): Remove.
7098
7099 2019-03-06  Tom Tromey  <tom@tromey.com>
7100
7101         * top.c (quit_force): Update.
7102         * main.c (captured_command_loop): Update.
7103         * common/new-op.c (operator new): Update.
7104         * common/common-exceptions.c (struct catcher)
7105         <save_cleanup_chain>: Remove member.
7106         (exceptions_state_mc_init): Update.
7107         (exception_try_scope_entry): Return nullptr.
7108         (exception_try_scope_exit, exception_rethrow)
7109         (throw_exception_sjlj, throw_exception_cxx): Update.
7110         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7111         (all_cleanups, do_cleanups, discard_cleanups)
7112         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7113         (restore_cleanups, restore_final_cleanups): Don't declare.
7114         (do_final_cleanups): Remove parameter.
7115         * common/cleanups.c (cleanup_chain, make_cleanup)
7116         (make_cleanup_dtor, all_cleanups, do_cleanups)
7117         (discard_my_cleanups, discard_cleanups)
7118         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7119         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7120         (null_cleanup): Remove.
7121         (do_final_cleanups): Remove parameter.
7122
7123 2019-03-06  Tom Tromey  <tom@tromey.com>
7124
7125         * remote.c (remote_target::remote_parse_stop_reply): Use
7126         unique_xmalloc_ptr.
7127
7128 2019-03-06  Tom Tromey  <tom@tromey.com>
7129
7130         * stabsread.c (struct stabs_field_info): Rename from field_info.
7131         <list, fnlist>: Add initializers.
7132         <obstack>: New member.
7133         (read_member_functions, read_struct_fields, read_baseclasses):
7134         Allocate on obstack.  Don't use cleanups.
7135         (read_one_struct_field, read_member_functions, read_struct_fields)
7136         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7137         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7138         (read_struct_type): Update.
7139
7140 2019-03-06  Tom Tromey  <tom@tromey.com>
7141
7142         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7143         * common/filestuff.h (make_cleanup_close): Don't declare.
7144         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7145         Remove.
7146
7147 2019-03-06  Tom Tromey  <tom@tromey.com>
7148
7149         * solib-aix.c: Use make_scope_exit.
7150
7151 2019-03-06  Tom Tromey  <tom@tromey.com>
7152
7153         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7154         Use make_scope_exit.
7155
7156 2019-03-06  Tom Tromey  <tom@tromey.com>
7157
7158         * solib-svr4.c (disable_probes_interface): Remove parameter.
7159         (svr4_handle_solib_event): Use make_scope_exit.
7160
7161 2019-03-06  Tom Tromey  <tom@tromey.com>
7162
7163         * remote.c (struct stop_reply_deleter): Remove.
7164         (stop_reply_up): Update.
7165         (struct stop_reply): Derive from notif_event.  Don't typedef.
7166         <regcache>: Now a std::vector.
7167         (stop_reply_xfree): Remove.
7168         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7169         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7170         (remote_target::discard_pending_stop_replies): Use delete.
7171         (remote_target::remote_parse_stop_reply): Update.
7172         (remote_target::process_stop_reply): Update.
7173         * remote-notif.h (struct notif_event): Add virtual destructor.
7174         Remove "dtr" member.
7175         (struct notif_client) <alloc_event>: Return a unique_ptr.
7176         (notif_event_xfree): Don't declare.
7177         (notif_event_up): New typedef.
7178         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7179         (notif_event_xfree, do_notif_event_xfree): Remove.
7180         (remote_notif_state_xfree): Update.
7181
7182 2019-03-06  Tom Tromey  <tom@tromey.com>
7183
7184         * infrun.c (displaced_step_clear_cleanup): Now a
7185         forward_scope_exit type.
7186         (displaced_step_prepare_throw): Update.
7187         (displaced_step_fixup): Update.
7188
7189 2019-03-06  Tom Tromey  <tom@tromey.com>
7190
7191         * inferior.h (class inferior): Update comment.
7192         * gdbthread.h (class thread_info): Update comment.
7193
7194 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7195             Tom Tromey  <tom@tromey.com>
7196
7197         * stabsread.h (struct stab_section_list): Remove.
7198         (coffstab_build_psymtabs): Update.
7199         * dbxread.c (symbuf_sections): Now a std::vector.
7200         (sect_idx): New global.
7201         (fill_symbuf): Update.
7202         (coffstab_build_psymtabs): Change type of stabsects parameter.
7203         Update.
7204         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7205         std::vector.
7206         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7207         (coff_locate_sections): Update.
7208         (coff_symfile_read): Remove cleanups.  Update.
7209         (init_stringtab): Add storage parameter.
7210         (free_stringtab, free_stringtab_cleanup): Remove.
7211         (init_lineno): Add storage parameter.
7212         (free_linetab, free_linetab_cleanup): Remove.
7213
7214 2019-03-06  Pedro Alves  <palves@redhat.com>
7215
7216         * linux-fork.c (fork_info::clobber_regs): Delete.
7217         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7218         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7219         comment.  Adjust.
7220         (scoped_switch_fork_info::scoped_switch_fork_info)
7221         (checkpoint_command, linux_fork_context): Adjust
7222         fork_save_infrun_state calls.
7223
7224 2019-03-06  Pedro Alves  <palves@redhat.com>
7225
7226         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7227         (inf_has_multiple_threads): Return 'bool' and rewrite using
7228         inferior_info::threads().
7229
7230 2019-03-06  Pedro Alves  <palves@redhat.com>
7231
7232         * linux-fork.c: Include <list>.
7233         (fork_list): Now a std::list instance.
7234         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7235         (forks_exist_p, find_last_fork): Adjust.
7236         (new_fork): Delete.
7237         (one_fork_p): New.
7238         (add_fork): Adjust.
7239         (free_fork): Delete, folded into fork_info::~fork_info().
7240         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7241         Adjust.
7242         (init_fork_list): Delete.
7243         (linux_fork_killall, linux_fork_mourn_inferior)
7244         (linux_fork_detach, info_checkpoints_command): Adjust.
7245         (_initialize_linux_fork): No longer call init_fork_list.
7246
7247 2019-03-06  Pedro Alves  <palves@redhat.com>
7248
7249         * linux-fork.c (new_fork): New, split out of ...
7250         (add_fork): ... this.  Return void.  Move "first fork" special
7251         case from here, to ...
7252         (checkpoint_command): ... here.
7253         * linux-linux.h (add_fork): Return void.
7254
7255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7256
7257         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7258
7259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7260             Chris January  <chris.january@arm.com>
7261             David Lecomber  <david.lecomber@arm.com>
7262
7263         * f-exp.y: New token, UNOP_INTRINSIC.
7264         (exp): New pattern using UNOP_INTRINSIC token.
7265         (f77_keywords): Add 'abs' keyword.
7266         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7267         (value_from_host_double): New function.
7268         (evaluate_subexp_f): Support UNOP_ABS.
7269
7270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7273         types.
7274
7275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7276
7277         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7278         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7279         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7280
7281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7284
7285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7286             Chris January  <chris.january@arm.com>
7287
7288         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7289         * f-exp.y: Define 'KIND' token.
7290         (exp): New pattern for KIND expressions.
7291         (ptype): Handle types with a kind extension.
7292         (direct_abs_decl): Extend to spot kind extensions.
7293         (f77_keywords): Add 'kind' to the list.
7294         (push_kind_type): New function.
7295         (convert_to_kind_type): New function.
7296         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7297         * parse.c (operator_length_standard): Likewise.
7298         * parser-defs.h (enum type_pieces): Add tp_kind.
7299         * std-operator.def: Add UNOP_KIND.
7300
7301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7302
7303         * f-exp.y (f_parse): Set yydebug.
7304
7305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * f-lang.c (evaluate_subexp_f): New function.
7308         (exp_descriptor_f): New global.
7309         (f_language_defn): Use exp_descriptor_f instead of
7310         exp_descriptor_standard.
7311
7312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * f-exp.y (struct token): Add comments.
7315         (dot_ops): Remove uppercase versions and the end marker.
7316         (f77_keywords): Likewise.
7317         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7318         entries in the dot_ops array are case insensitive, and use
7319         strncasecmp to compare strings.  Also some whitespace cleanup in
7320         this area.  Similar for the f77_keywords array, except entries in
7321         this list might be case sensitive.
7322
7323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * f-exp.y (struct f77_boolean_val): Add comments.
7326         (boolean_values): Remove uppercase versions, and end marker.
7327         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7328         and use strncasecmp to achieve case insensitivity.  Additionally,
7329         perform whitespace cleanup around this code.
7330
7331 2019-03-06  Tom Tromey  <tromey@adacore.com>
7332
7333         * remote-sim.c (gdbsim_target_open): Use result of
7334         gdb_argv::release.
7335
7336 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7337         Dirk Schubert  <dirk.schubert@arm.com>
7338         Chris January  <chris.january@arm.com>
7339
7340         * eval.c (evaluate_subexp_standard): Call Fortran argument
7341         wrapping logic.
7342         * f-lang.c (struct value): A value which can be passed into a
7343         Fortran function call.
7344         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7345         where appropriate.
7346         (struct type): Value ready for a Fortran function call.
7347         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7348         is needed.
7349         * f-lang.h (fortran_argument_convert): Declaration.
7350         (fortran_preserve_arg_pointer): Declaration.
7351         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7352
7353 2019-03-05  Tom Tromey  <tromey@adacore.com>
7354
7355         * python/py-prettyprint.c (print_string_repr): Remove #if.
7356         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7357
7358 2019-03-05  Tom Tromey  <tromey@adacore.com>
7359
7360         * target.c (the_dummy_target): Move later.  Change type to
7361         "dummy_target".
7362         (initialize_targets): Don't initialize the_dummy_target.
7363
7364 2019-03-05  Tom Tromey  <tromey@adacore.com>
7365
7366         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7367         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7368
7369 2019-03-05  Tom Tromey  <tromey@adacore.com>
7370
7371         * windows-nat.c (windows_nat_target::attach)
7372         (windows_nat_target::detach): Don't call gdb_flush.
7373         * valprint.c (generic_val_print, val_print, val_print_string):
7374         Don't call gdb_flush.
7375         * utils.c (defaulted_query): Don't call gdb_flush.
7376         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7377         * target.c (target_announce_detach): Don't call gdb_flush.
7378         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7379         * remote.c (extended_remote_target::attach): Don't call
7380         gdb_flush.
7381         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7382         * printcmd.c (do_examine): Don't call gdb_flush.
7383         (info_display_command): Don't call gdb_flush.
7384         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7385         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7386         * memattr.c (info_mem_command): Don't call gdb_flush.
7387         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7388         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7389         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7390         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7391         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7392         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7393         (gnu_nat_target::detach): Don't call gdb_flush.
7394         * f-valprint.c (f_val_print): Don't call gdb_flush.
7395         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7396         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7397         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7398         gdb_flush.
7399         * c-valprint.c (c_val_print): Don't call gdb_flush.
7400         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7401
7402 2019-03-05  Tom Tromey  <tromey@adacore.com>
7403
7404         * varobj.c (update_dynamic_varobj_children): Update.
7405         (install_default_visualizer): Use reset, not release.
7406         * value.c (set_internalvar): Update.
7407         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7408         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7409         ATTRIBUTE_UNUSED_RESULT.
7410
7411 2019-03-05  Tom Tromey  <tromey@adacore.com>
7412
7413         * remote.c (class scoped_remote_fd) <release>: Add
7414         ATTRIBUTE_UNUSED_RESULT.
7415
7416 2019-03-05  Tom Tromey  <tromey@adacore.com>
7417
7418         * macroexp.c (struct macro_buffer) <release>: Add
7419         ATTRIBUTE_UNUSED_RESULT.
7420
7421 2019-03-05  Tom Tromey  <tromey@adacore.com>
7422
7423         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7424         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7425         ATTRIBUTE_UNUSED_RESULT.
7426
7427 2019-03-05  Tom Tromey  <tromey@adacore.com>
7428
7429         * common/scoped_fd.h (class scoped_fd) <release>: Add
7430         ATTRIBUTE_UNUSED_RESULT.
7431
7432 2019-03-05  Tom Tromey  <tromey@adacore.com>
7433
7434         * parser-defs.h (struct parser_state) <release>: Add
7435         ATTRIBUTE_UNUSED_RESULT.
7436
7437 2019-03-05  Tom Tromey  <tromey@adacore.com>
7438
7439         * utils.h (class gdb_argv) <release>: Add
7440         ATTRIBUTE_UNUSED_RESULT.
7441         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7442
7443 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7444
7445         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7446         for-loop range, to avoid compiler warnings.
7447
7448         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7449         avoid compiler warnings about unused variables.
7450
7451         * NEWS: Mention end of support for native debugging on MS-Windows
7452         before XP.
7453
7454         PR gdb/24292
7455         * common/netstuff.c:
7456         * gdbserver/gdbreplay.c
7457         * gdbserver/remote-utils.c:
7458         * ser-tcp.c:
7459         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7460         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7461         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7462         'getaddrinfo' and 'freeaddrinfo' were not available before
7463         Windows XP, and mingw.org's MinGW headers by default define
7464         _WIN32_WINNT to 0x500.
7465
7466 2019-03-01  Gary Benson <gbenson@redhat.com>
7467
7468         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7469
7470 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7471             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7472
7473         PR gdb/8527
7474         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7475         set_sigint_trap, clear_sigint_trap.
7476
7477 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7478
7479         * target.c (target_detach): Clear the regcache and the
7480         frame cache.
7481
7482 2019-02-27  Pedro Alves  <palves@redhat.com>
7483
7484         * utils.c (set_screen_size): When we cap the height/width sizes,
7485         tweak the corresponding command variable to show "unlimited":
7486
7487 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7488             Pedro Alves  <palves@redhat.com>
7489
7490         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7491         before calling rl_set_screen_size.
7492
7493 2019-02-27  Tom Tromey  <tromey@adacore.com>
7494
7495         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7496         define.
7497         * python/py-value.c: Remove Python 2.4 workaround.
7498         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7499         workaround.
7500         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7501         Python 2.4 workaround.
7502         * python/python-internal.h: Remove Python 2.4 comment.
7503         (Py_ssize_t): Don't define.
7504         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7505         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7506         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7507         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7508         * python/python.c (do_start_initialization): Remove Python 2.4
7509         workaround.
7510         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7511         (print_children): Remove Python 2.4 workaround.
7512         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7513         workaround.
7514         (CHARBUFFERPROC_NAME): Remove.
7515         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7516         Python 2.4 workaround.
7517
7518 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7519
7520         * NEWS: Note minimum Python version.
7521
7522 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7523
7524         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7525         code from these functions.  Remove corresponding ifdefs.  Use
7526         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7527         Remove gotos and target of gotos.
7528         (infpy_search_memory): Likewise.
7529
7530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7531
7532         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7533         (hppa_gdbarch_init): Don't register deleted functions with
7534         gdbarch.
7535
7536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7537
7538         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7539         (h8300_unwind_sp): Delete.
7540         (h8300_dummy_id): Delete.
7541         (h8300_gdbarch_init): Don't register deleted functions with
7542         gdbarch.
7543
7544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7547         (ft32_unwind_pc): Delete.
7548         (ft32_unwind_sp): Delete.
7549         (ft32_gdbarch_init): Don't register deleted functions with
7550         gdbarch.
7551
7552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7553
7554         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7555         (frv_unwind_pc): Delete.
7556         (frv_unwind_sp): Delete.
7557         (frv_gdbarch_init): Don't register deleted functions with
7558         gdbarch.
7559
7560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7561
7562         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7563         (riscv_unwind_pc): Delete.
7564         (riscv_unwind_sp): Delete.
7565         (riscv_gdbarch_init): Don't register deleted functions with
7566         gdbarch.
7567
7568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7569
7570         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7571         (csky_unwind_pc): Delete.
7572         (csky_unwind_sp): Delete.
7573         (csky_gdbarch_init): Don't register deleted functions with
7574         gdbarch.
7575
7576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7579         (cris_unwind_pc): Delete.
7580         (cris_unwind_sp): Delete.
7581         (cris_gdbarch_init): Don't register deleted functions with
7582         gdbarch.
7583
7584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7585
7586         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7587         (bfin_unwind_pc): Delete.
7588         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7589
7590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7591
7592         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7593         (arm_unwind_pc): Delete.
7594         (arm_unwind_sp): Delete.
7595         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7596
7597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7598
7599         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7600         (arc_unwind_pc): Delete.
7601         (arc_unwind_sp): Delete.
7602         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7603
7604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7607         (alpha_unwind_pc): Delete.
7608         (alpha_gdbarch_init): Don't register deleted functions with
7609         gdbarch.
7610
7611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7614         (aarch64_unwind_pc): Delete.
7615         (aarch64_unwind_sp): Delete.
7616         (aarch64_gdbarch_init): Don't register deleted functions with
7617         gdbarch.
7618
7619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * gdbtypes.c (type_align): Don't consider static members when
7622         computing structure alignment.
7623
7624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7625
7626         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7627         return 0 for other types.
7628         * arch-utils.c (default_type_align): Always return 0.
7629         * gdbarch.h: Regenerate.
7630         * gdbarch.sh (type_align): Extend comment.
7631         * gdbtypes.c (type_align): Add additional comments, always call
7632         gdbarch_type_align before applying the default rules.
7633         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7634         generic code will then apply a suitable default.
7635         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7636         types, return 0 for other types.
7637
7638 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7639
7640         * NEWS: Create a new section for the next release branch.
7641         Rename the section of the current branch, now that it has
7642         been cut.
7643
7644 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7645
7646         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7647         * version.in: Bump version to 8.3.50.DATE-git.
7648
7649 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7650
7651         * aix-thread.c (ptid_cmp): Remove unused variable.
7652         (get_signaled_thread): Likewise.
7653         (store_regs_user_thread): Likewise.
7654         (store_regs_kernel_thread): Likewise.
7655         (fetch_regs_kernel_thread): Remove shadowed variable.
7656
7657 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * features/riscv/32bit-cpu.xml: Add register numbers.
7660         * features/riscv/32bit-fpu.c: Regenerate.
7661         * features/riscv/32bit-fpu.xml: Add register numbers.
7662         * features/riscv/64bit-cpu.xml: Add register numbers.
7663         * features/riscv/64bit-fpu.c: Regenerate.
7664         * features/riscv/64bit-fpu.xml: Add register numbers.
7665
7666 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7667
7668         * NEWS: Mention two argument form of gdb.Value constructor.
7669         * python/py-value.c (convert_buffer_and_type_to_value): New
7670         function.
7671         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7672         Add support for handling an optional second argument.  Call
7673         convert_buffer_and_type_to_value as appropriate.
7674         * python/python-internal.h (Py_buffer_deleter): New struct.
7675         (Py_buffer_up): New typedef.
7676
7677 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7678
7679         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7680         instead of releasing ownership.
7681
7682 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7683
7684         * dwarf2read.c (open_and_init_dwp_file): Call
7685         elf_numsections instead of bfd_count_sections to initialize
7686         dwp_file->num_sections.
7687
7688 2019-02-25  Tom Tromey  <tromey@adacore.com>
7689
7690         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7691
7692 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7693
7694         * gcore.in: Add '--readnever' option when invoking GDB.
7695
7696 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7697
7698         * MAINTAINERS: Update my email address.
7699
7700 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7701
7702         * build-id.c (build_id_to_debug_bfd_1): New function.
7703         (build_id_to_debug_bfd): Look for separate debug file in
7704         sysroot.
7705
7706 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7707
7708         * gdbarch.sh: Update the copyright year range that is placed into
7709         generated files.
7710
7711 2019-02-22  Keith Seitz  <keiths@redhat.com>
7712
7713         PR symtab/23853
7714         * linespec.c (create_sals_line_offset): Search for the default
7715         symtab's filename instead of its fullname.
7716
7717 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7718
7719         * NEWS: Update style defaults.
7720
7721 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7722
7723         * main.c (captured_main_1): Disable styling in batch mode.
7724
7725 2019-02-20  Tom Tromey  <tom@tromey.com>
7726
7727         * symtab.c (symtab_symbol_info): Fix typos.
7728
7729 2019-02-20  Tom Tromey  <tromey@adacore.com>
7730
7731         * findcmd.c (_initialize_mem_search): Use upper case for
7732         metasyntactic variables.
7733
7734 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7735
7736         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7737         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7738
7739 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7740
7741         * top.h (source_file_name): Change to std::string.
7742         * top.c (source_file_name): Likewise.
7743         (command_line_input): Adjust.
7744         * cli/cli-script.c (script_from_file): Adjust.
7745
7746 2019-02-19  Tom Tromey  <tromey@adacore.com>
7747
7748         * ravenscar-thread.c
7749         (ravenscar_thread_target::update_thread_list): Don't call
7750         ada_build_task_list.
7751         * ada-lang.h (ada_build_task_list): Don't declare.
7752         * ada-tasks.c (struct ada_tasks_inferior_data)
7753         <task_list_valid_p>: Now bool.
7754         (read_known_tasks, ada_task_list_changed)
7755         (ada_tasks_invalidate_inferior_data): Update.
7756         (read_known_tasks_array): Return bool.
7757         (read_known_tasks_list): Likewise.
7758         (read_known_tasks): Return void.
7759         (ada_build_task_list): Now static.
7760
7761 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7764         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7765
7766 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7767
7768         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7769         variant for ada_tasks_pspace_data_handle and
7770         ada_tasks_inferior_data_handle.
7771         (ada_tasks_pspace_data_cleanup): New function.
7772         (ada_tasks_inferior_data_cleanup): New function.
7773
7774 2019-02-17  Tom Tromey  <tom@tromey.com>
7775
7776         * macrotab.h (macro_source_fullname): Return a std::string.
7777         * macrotab.c (macro_include, check_for_redefinition)
7778         (macro_undef, macro_lookup_definition, foreach_macro)
7779         (foreach_macro_in_scope): Update.
7780         (macro_source_fullname): Return a std::string.
7781         * macrocmd.c (show_pp_source_pos): Update.
7782
7783 2019-02-17  Tom Tromey  <tom@tromey.com>
7784
7785         * macrocmd.c (show_pp_source_pos): Style the file names.
7786
7787 2019-02-17  Tom Tromey  <tom@tromey.com>
7788
7789         PR tui/24197:
7790         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7791
7792 2019-02-17  Tom Tromey  <tom@tromey.com>
7793
7794         * ada-lang.c (user_select_syms): Use filtered printing.
7795         * utils.c (wrap_style): New global.
7796         (desired_style): Remove.
7797         (emit_style_escape): Add stream parameter.
7798         (set_output_style, reset_terminal_style, prompt_for_continue):
7799         Update.
7800         (flush_wrap_buffer): Only flush gdb_stdout.
7801         (wrap_here): Set wrap_style.
7802         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7803         treat escape sequences as a character.  Change when wrap buffer is
7804         flushed.
7805         (fputs_styled): Do not set the output style when the default is
7806         requested.
7807         * ui-style.h (struct ui_file_style) <is_default>: New method.
7808         * source.c (print_source_lines_base): Emit escape sequences in one
7809         piece.
7810
7811 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7812
7813         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7814         integers and enumeration types.
7815
7816 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7817
7818         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7819         instead of lookup_symbol_in_language
7820         (do_exact_match): New function.
7821         (ada_get_symbol_name_matcher): Return do_exact_match when
7822         doing a verbatim match.
7823
7824 2019-02-15  Tom Tromey  <tromey@adacore.com>
7825
7826         * ravenscar-thread.c (ravenscar_thread_target::resume)
7827         (ravenscar_thread_target::wait): Special case wildcard requests.
7828
7829 2019-02-15  Tom Tromey  <tromey@adacore.com>
7830
7831         * ravenscar-thread.c (base_ptid): Remove.
7832         (struct ravenscar_thread_target) <close>: New method.
7833         <m_base_ptid>: New member.
7834         <update_inferior_ptid, active_task, task_is_currently_active,
7835         runtime_initialized>: Declare methods.
7836         <ravenscar_thread_target>: Add constructor.
7837         (ravenscar_thread_target::task_is_currently_active)
7838         (ravenscar_thread_target::update_inferior_ptid)
7839         (ravenscar_runtime_initialized): Rename.  Now methods.
7840         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7841         (ravenscar_thread_target::update_thread_list): Update.
7842         (ravenscar_thread_target::active_task): Now method.
7843         (ravenscar_thread_target::store_registers)
7844         (ravenscar_thread_target::prepare_to_store)
7845         (ravenscar_thread_target::prepare_to_store)
7846         (ravenscar_thread_target::mourn_inferior): Update.
7847         (ravenscar_inferior_created): Use "new" to create target.
7848         (ravenscar_thread_target::get_ada_task_ptid): Update.
7849         (_initialize_ravenscar): Don't initialize base_ptid.
7850         (ravenscar_ops): Remove global.
7851
7852 2019-02-15  Tom Tromey  <tromey@adacore.com>
7853
7854         * target.h (push_target): Declare new overload.
7855         * target.c (push_target): New overload, taking an rvalue reference.
7856         * remote.c (remote_target::open_1): Use push_target overload.
7857         * corelow.c (core_target_open): Use push_target overload.
7858
7859 2019-02-15  Tom Tromey  <tromey@adacore.com>
7860
7861         * ravenscar-thread.c (is_ravenscar_task)
7862         (ravenscar_task_is_currently_active): Return bool.
7863         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7864         (_initialize_ravenscar): Remove "(void)".
7865         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7866         Return bool.
7867
7868 2019-02-15  Tom Tromey  <tromey@adacore.com>
7869
7870         * ravenscar-thread.c (ravenscar_runtime_initializer)
7871         (has_ravenscar_runtime, get_running_thread_id)
7872         (ravenscar_thread_target::resume): Fix indentation.
7873
7874 2019-02-15  Tom Tromey  <tromey@adacore.com>
7875
7876         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7877         from ravenscar_arch_ops.
7878         (sparc_ravenscar_ops::fetch_registers)
7879         (sparc_ravenscar_ops::store_registers): Now methods.
7880         (sparc_ravenscar_prepare_to_store): Remove.
7881         (sparc_ravenscar_ops): Redefine.
7882         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7883         methods and destructor.  Remove members.
7884         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7885         (ravenscar_thread_target::store_registers)
7886         (ravenscar_thread_target::prepare_to_store): Update.
7887         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7888         Remove.
7889         (struct ppc_ravenscar_powerpc_ops): Derive from
7890         ravenscar_arch_ops.
7891         (ppc_ravenscar_powerpc_ops::fetch_registers)
7892         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7893         (ppc_ravenscar_powerpc_ops): Redefine.
7894         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7895         (ppc_ravenscar_e500_ops::fetch_registers)
7896         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7897         (ppc_ravenscar_e500_ops): Redefine.
7898         * aarch64-ravenscar-thread.c
7899         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7900         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7901         (aarch64_ravenscar_fetch_registers)
7902         (aarch64_ravenscar_store_registers): Now methods.
7903         (aarch64_ravenscar_ops): Redefine.
7904
7905 2019-02-15  Tom Tromey  <tromey@adacore.com>
7906
7907         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7908         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7909         (ravenscar_thread_target::stopped_by_watchpoint)
7910         (ravenscar_thread_target::stopped_data_address)
7911         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7912
7913 2019-02-15  Tom Tromey  <tromey@adacore.com>
7914
7915         * ravenscar-thread.c: Fix some typos.
7916
7917 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7918             Tom Tromey  <tromey@adacore.com>
7919
7920         * ada-lang.c (ada_exception_sal): Change addr_string to a
7921         std::string.
7922         (create_ada_exception_catchpoint): Update.
7923
7924 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7925             Tom Tromey  <tromey@adacore.com>
7926
7927         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7928         (bp_location_ops): Remove.
7929         (base_breakpoint_allocate_location): Update.
7930         (free_bp_location): Update.
7931         * ada-lang.c (class ada_catchpoint_location)
7932         <ada_catchpoint_location>: Remove ops parameter.
7933         (ada_catchpoint_location_dtor): Remove.
7934         (ada_catchpoint_location_ops): Remove.
7935         (allocate_location_exception): Update.
7936         * breakpoint.h (struct bp_location_ops): Remove.
7937         (class bp_location) <bp_location>: Remove bp_location_ops
7938         parameter.
7939         <~bp_location>: Add destructor.
7940         <ops>: Remove.
7941
7942 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7943             Pedro Alves  <palves@redhat.com>
7944
7945         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7946         'PATH_MAX'.
7947
7948 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7949             Samuel Thibault  <samuel.thibault@gnu.org>
7950             Thomas Schwinge  <thomas@codesourcery.com>
7951
7952         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7953         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7954
7955 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7956
7957         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7958         (check_empty): Use "const char *".
7959
7960         * gnu-nat.c (gnu_nat_target::detach): Instead of
7961         'detach_inferior (pid)' call
7962         'detach_inferior (find_inferior_pid (pid))'.
7963
7964         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7965         'nat/fork-inferior.o'.
7966         * gnu-nat.c: #include "nat/fork-inferior.h".
7967
7968         * gnu-nat.c (gnu_nat_target::detach): Instead of
7969         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7970         * gnu-nat.h: #include "inf-child.h".
7971         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7972         'i386_gnu_nat_target::fetch_registers'.
7973         (gnu_store_registers): Rename/move to
7974         'i386_gnu_nat_target::store_registers'.
7975
7976         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7977         * gnu-nat.h (mach_thread_info): New function.
7978         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7979
7980         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7981
7982 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7983
7984         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7985
7986 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7987
7988         * windows-nat.c (windows_add_thread): Add new parameter
7989         "main_thread_p" with default value set to false.  Update
7990         function documentation as well as all callers.
7991         (windows_delete_thread): Likewise.
7992         (fake_create_process): Update call to windows_add_thread.
7993         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7994         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7995         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7996         call to windows_delete_thread.
7997
7998 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7999
8000         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8001
8002 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8003
8004         * symfile.c (find_separate_debug_file): Use canonical path of
8005         sysroot with child_path instead of gdb_sysroot if it is valid.
8006
8007 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8008
8009         * symfile.c (find_separate_debug_file): Use child_path to
8010         determine if an object file is under a sysroot.
8011
8012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8013
8014         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8015         unittests/child-path-selftests.c.
8016         * common/pathstuff.c (child_path): New function.
8017         * common/pathstuff.h (child_path): New prototype.
8018         * unittests/child-path-selftests.c: New file.
8019
8020 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8021
8022         * symfile.c (find_separate_debug_file): Look for separate debug
8023         files in debug directories under the sysroot.
8024
8025 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8026
8027         * symtab.h (struct minimal_symbol data_p): New const method.
8028         (struct minimal_symbol text_p): Likewise.
8029         * symtab.c (output_source_filename): Use file name style
8030         to print file name.
8031         (print_symbol_info): Likewise.
8032         (print_msymbol_info): Use address style to print addresses.
8033         Use function name style to print executable text symbols.
8034         (expand_symtab_containing_pc): Use data_p.
8035         (find_pc_sect_compunit_symtab): Likewise.
8036
8037 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8038
8039         * breakpoint.c (describe_other_breakpoints): Use address style
8040         to print addresses.
8041         (say_where): Likewise.
8042
8043 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8044
8045         * ada-typeprint.c (print_func_type): Print function name
8046         style to print function name.
8047         * c-typeprint.c (c_print_type_1): Likewise.
8048
8049 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8050
8051         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8052         for execve.
8053
8054 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8055
8056         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8057         type_stack.
8058
8059 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8060
8061         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8062         TYPE_CODE_REF types.
8063
8064 2019-02-08  Jim Wilson  <jimw@sifive.com>
8065
8066         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8067         (riscv_linux_fregset): New.
8068         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8069
8070 2019-02-07  Tom Tromey  <tom@tromey.com>
8071
8072         * thread.c (thread_cancel_execution_command): Update.
8073         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8074         methods.
8075         (struct thread_fsm_ops): Remove.
8076         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8077         (thread_fsm_should_stop, thread_fsm_return_value)
8078         (thread_fsm_set_finished, thread_fsm_finished_p)
8079         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8080         Don't declare.
8081         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8082         * infrun.c (clear_proceed_status_thread)
8083         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8084         (print_stop_event): Update.
8085         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8086         Add constructor.
8087         (step_command_fsm_ops): Remove.
8088         (new_step_command_fsm): Remove.
8089         (step_1): Update.
8090         (step_command_fsm::should_stop): Rename from
8091         step_command_fsm_should_stop.
8092         (step_command_fsm::clean_up): Rename from
8093         step_command_fsm_clean_up.
8094         (step_command_fsm::do_async_reply_reason): Rename from
8095         step_command_fsm_async_reply_reason.
8096         (struct until_next_fsm): Inherit from thread_fsm.  Add
8097         constructor.
8098         (until_next_fsm_ops): Remove.
8099         (new_until_next_fsm): Remove.
8100         (until_next_fsm::should_stop): Rename from
8101         until_next_fsm_should_stop.
8102         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8103         (until_next_fsm::do_async_reply_reason): Rename from
8104         until_next_fsm_async_reply_reason.
8105         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8106         constructor.  Change type of breakpoint.
8107         (finish_command_fsm_ops): Remove.
8108         (new_finish_command_fsm): Remove.
8109         (finish_command_fsm::should_stop): Rename from
8110         finish_command_fsm_should_stop.
8111         (finish_command_fsm::clean_up): Rename from
8112         finish_command_fsm_clean_up.
8113         (finish_command_fsm::return_value): Rename from
8114         finish_command_fsm_return_value.
8115         (finish_command_fsm::do_async_reply_reason): Rename from
8116         finish_command_fsm_async_reply_reason.
8117         (finish_command): Update.
8118         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8119         Add constructor.
8120         (call_thread_fsm_ops): Remove.
8121         (call_thread_fsm::call_thread_fsm): Rename from
8122         new_call_thread_fsm.
8123         (call_thread_fsm::should_stop): Rename from
8124         call_thread_fsm_should_stop.
8125         (call_thread_fsm::should_notify_stop): Rename from
8126         call_thread_fsm_should_notify_stop.
8127         (run_inferior_call, call_function_by_hand_dummy): Update.
8128         * cli/cli-interp.c (should_print_stop_to_console): Update.
8129         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8130         Add constructor.  Change type of location_breakpoint,
8131         caller_breakpoint.
8132         (until_break_fsm_ops): Remove.
8133         (new_until_break_fsm): Remove.
8134         (until_break_fsm::should_stop): Rename from
8135         until_break_fsm_should_stop.
8136         (until_break_fsm::clean_up): Rename from
8137         until_break_fsm_clean_up.
8138         (until_break_fsm::do_async_reply_reason): Rename from
8139         until_break_fsm_async_reply_reason.
8140         (until_break_command): Update.
8141         * thread-fsm.c: Remove.
8142         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8143
8144 2019-02-07  Tom Tromey  <tom@tromey.com>
8145
8146         * yy-remap.h: Add include guard.
8147         * xtensa-tdep.h: Add include guard.
8148         * xcoffread.h: Rename include guard.
8149         * varobj-iter.h: Add include guard.
8150         * tui/tui.h: Rename include guard.
8151         * tui/tui-winsource.h: Rename include guard.
8152         * tui/tui-wingeneral.h: Rename include guard.
8153         * tui/tui-windata.h: Rename include guard.
8154         * tui/tui-win.h: Rename include guard.
8155         * tui/tui-stack.h: Rename include guard.
8156         * tui/tui-source.h: Rename include guard.
8157         * tui/tui-regs.h: Rename include guard.
8158         * tui/tui-out.h: Rename include guard.
8159         * tui/tui-layout.h: Rename include guard.
8160         * tui/tui-io.h: Rename include guard.
8161         * tui/tui-hooks.h: Rename include guard.
8162         * tui/tui-file.h: Rename include guard.
8163         * tui/tui-disasm.h: Rename include guard.
8164         * tui/tui-data.h: Rename include guard.
8165         * tui/tui-command.h: Rename include guard.
8166         * tic6x-tdep.h: Add include guard.
8167         * target/waitstatus.h: Rename include guard.
8168         * target/wait.h: Rename include guard.
8169         * target/target.h: Rename include guard.
8170         * target/resume.h: Rename include guard.
8171         * target-float.h: Rename include guard.
8172         * stabsread.h: Add include guard.
8173         * rs6000-tdep.h: Add include guard.
8174         * riscv-fbsd-tdep.h: Add include guard.
8175         * regformats/regdef.h: Rename include guard.
8176         * record.h: Rename include guard.
8177         * python/python.h: Rename include guard.
8178         * python/python-internal.h: Rename include guard.
8179         * python/py-stopevent.h: Rename include guard.
8180         * python/py-ref.h: Rename include guard.
8181         * python/py-record.h: Rename include guard.
8182         * python/py-record-full.h: Rename include guard.
8183         * python/py-record-btrace.h: Rename include guard.
8184         * python/py-instruction.h: Rename include guard.
8185         * python/py-events.h: Rename include guard.
8186         * python/py-event.h: Rename include guard.
8187         * procfs.h: Add include guard.
8188         * proc-utils.h: Add include guard.
8189         * p-lang.h: Add include guard.
8190         * or1k-tdep.h: Rename include guard.
8191         * observable.h: Rename include guard.
8192         * nto-tdep.h: Rename include guard.
8193         * nat/x86-linux.h: Rename include guard.
8194         * nat/x86-linux-dregs.h: Rename include guard.
8195         * nat/x86-gcc-cpuid.h: Add include guard.
8196         * nat/x86-dregs.h: Rename include guard.
8197         * nat/x86-cpuid.h: Rename include guard.
8198         * nat/ppc-linux.h: Rename include guard.
8199         * nat/mips-linux-watch.h: Rename include guard.
8200         * nat/linux-waitpid.h: Rename include guard.
8201         * nat/linux-ptrace.h: Rename include guard.
8202         * nat/linux-procfs.h: Rename include guard.
8203         * nat/linux-osdata.h: Rename include guard.
8204         * nat/linux-nat.h: Rename include guard.
8205         * nat/linux-namespaces.h: Rename include guard.
8206         * nat/linux-btrace.h: Rename include guard.
8207         * nat/glibc_thread_db.h: Rename include guard.
8208         * nat/gdb_thread_db.h: Rename include guard.
8209         * nat/gdb_ptrace.h: Rename include guard.
8210         * nat/fork-inferior.h: Rename include guard.
8211         * nat/amd64-linux-siginfo.h: Rename include guard.
8212         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8213         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8214         * nat/aarch64-linux.h: Rename include guard.
8215         * nat/aarch64-linux-hw-point.h: Rename include guard.
8216         * mn10300-tdep.h: Add include guard.
8217         * mips-linux-tdep.h: Add include guard.
8218         * mi/mi-parse.h: Rename include guard.
8219         * mi/mi-out.h: Rename include guard.
8220         * mi/mi-main.h: Rename include guard.
8221         * mi/mi-interp.h: Rename include guard.
8222         * mi/mi-getopt.h: Rename include guard.
8223         * mi/mi-console.h: Rename include guard.
8224         * mi/mi-common.h: Rename include guard.
8225         * mi/mi-cmds.h: Rename include guard.
8226         * mi/mi-cmd-break.h: Rename include guard.
8227         * m2-lang.h: Add include guard.
8228         * location.h: Rename include guard.
8229         * linux-record.h: Rename include guard.
8230         * linux-nat.h: Add include guard.
8231         * linux-fork.h: Add include guard.
8232         * i386-darwin-tdep.h: Rename include guard.
8233         * hppa-linux-offsets.h: Add include guard.
8234         * guile/guile.h: Rename include guard.
8235         * guile/guile-internal.h: Rename include guard.
8236         * gnu-nat.h: Rename include guard.
8237         * gdb-stabs.h: Rename include guard.
8238         * frv-tdep.h: Add include guard.
8239         * f-lang.h: Add include guard.
8240         * event-loop.h: Add include guard.
8241         * darwin-nat.h: Rename include guard.
8242         * cp-abi.h: Rename include guard.
8243         * config/sparc/nm-sol2.h: Rename include guard.
8244         * config/nm-nto.h: Rename include guard.
8245         * config/nm-linux.h: Add include guard.
8246         * config/i386/nm-i386gnu.h: Rename include guard.
8247         * config/djgpp/nl_types.h: Rename include guard.
8248         * config/djgpp/langinfo.h: Rename include guard.
8249         * compile/gcc-cp-plugin.h: Add include guard.
8250         * compile/gcc-c-plugin.h: Add include guard.
8251         * compile/compile.h: Rename include guard.
8252         * compile/compile-object-run.h: Rename include guard.
8253         * compile/compile-object-load.h: Rename include guard.
8254         * compile/compile-internal.h: Rename include guard.
8255         * compile/compile-cplus.h: Rename include guard.
8256         * compile/compile-c.h: Rename include guard.
8257         * common/xml-utils.h: Rename include guard.
8258         * common/x86-xstate.h: Rename include guard.
8259         * common/version.h: Rename include guard.
8260         * common/vec.h: Rename include guard.
8261         * common/tdesc.h: Rename include guard.
8262         * common/selftest.h: Rename include guard.
8263         * common/scoped_restore.h: Rename include guard.
8264         * common/scoped_mmap.h: Rename include guard.
8265         * common/scoped_fd.h: Rename include guard.
8266         * common/safe-iterator.h: Rename include guard.
8267         * common/run-time-clock.h: Rename include guard.
8268         * common/refcounted-object.h: Rename include guard.
8269         * common/queue.h: Rename include guard.
8270         * common/ptid.h: Rename include guard.
8271         * common/print-utils.h: Rename include guard.
8272         * common/preprocessor.h: Rename include guard.
8273         * common/pathstuff.h: Rename include guard.
8274         * common/observable.h: Rename include guard.
8275         * common/netstuff.h: Rename include guard.
8276         * common/job-control.h: Rename include guard.
8277         * common/host-defs.h: Rename include guard.
8278         * common/gdb_wait.h: Rename include guard.
8279         * common/gdb_vecs.h: Rename include guard.
8280         * common/gdb_unlinker.h: Rename include guard.
8281         * common/gdb_unique_ptr.h: Rename include guard.
8282         * common/gdb_tilde_expand.h: Rename include guard.
8283         * common/gdb_sys_time.h: Rename include guard.
8284         * common/gdb_string_view.h: Rename include guard.
8285         * common/gdb_splay_tree.h: Rename include guard.
8286         * common/gdb_setjmp.h: Rename include guard.
8287         * common/gdb_ref_ptr.h: Rename include guard.
8288         * common/gdb_optional.h: Rename include guard.
8289         * common/gdb_locale.h: Rename include guard.
8290         * common/gdb_assert.h: Rename include guard.
8291         * common/filtered-iterator.h: Rename include guard.
8292         * common/filestuff.h: Rename include guard.
8293         * common/fileio.h: Rename include guard.
8294         * common/environ.h: Rename include guard.
8295         * common/common-utils.h: Rename include guard.
8296         * common/common-types.h: Rename include guard.
8297         * common/common-regcache.h: Rename include guard.
8298         * common/common-inferior.h: Rename include guard.
8299         * common/common-gdbthread.h: Rename include guard.
8300         * common/common-exceptions.h: Rename include guard.
8301         * common/common-defs.h: Rename include guard.
8302         * common/common-debug.h: Rename include guard.
8303         * common/cleanups.h: Rename include guard.
8304         * common/buffer.h: Rename include guard.
8305         * common/btrace-common.h: Rename include guard.
8306         * common/break-common.h: Rename include guard.
8307         * cli/cli-utils.h: Rename include guard.
8308         * cli/cli-style.h: Rename include guard.
8309         * cli/cli-setshow.h: Rename include guard.
8310         * cli/cli-script.h: Rename include guard.
8311         * cli/cli-interp.h: Rename include guard.
8312         * cli/cli-decode.h: Rename include guard.
8313         * cli/cli-cmds.h: Rename include guard.
8314         * charset-list.h: Add include guard.
8315         * buildsym-legacy.h: Rename include guard.
8316         * bfin-tdep.h: Add include guard.
8317         * ax.h: Rename include guard.
8318         * arm-linux-tdep.h: Add include guard.
8319         * arm-fbsd-tdep.h: Add include guard.
8320         * arch/xtensa.h: Rename include guard.
8321         * arch/tic6x.h: Add include guard.
8322         * arch/i386.h: Add include guard.
8323         * arch/arm.h: Rename include guard.
8324         * arch/arm-linux.h: Rename include guard.
8325         * arch/arm-get-next-pcs.h: Rename include guard.
8326         * arch/amd64.h: Add include guard.
8327         * arch/aarch64-insn.h: Rename include guard.
8328         * arch-utils.h: Rename include guard.
8329         * annotate.h: Add include guard.
8330         * amd64-darwin-tdep.h: Rename include guard.
8331         * aarch64-linux-tdep.h: Add include guard.
8332         * aarch64-fbsd-tdep.h: Add include guard.
8333         * aarch32-linux-nat.h: Add include guard.
8334
8335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8336
8337         * macrotab.c (macro_define_internal): New function that
8338         factorizes macro_define_object_internal and macro_define_function
8339         code.
8340         (macro_define_object_internal): Use macro_define_internal.
8341         (macro_define_function): Likewise.
8342
8343 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8344
8345         * macrocmd.c (extract_identifier): Return
8346         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8347         callers.
8348
8349 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8350
8351         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8352
8353 2019-02-05  Tom Tromey  <tom@tromey.com>
8354
8355         * target.c (target_stack::unpush): Move assertion earlier.
8356
8357 2019-01-30  Tom Tromey  <tom@tromey.com>
8358
8359         PR python/23615:
8360         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8361         (gdbpy_parse_and_eval): Likewise.
8362         * python/python-internal.h (gdbpy_allow_threads): New class.
8363
8364 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8365
8366         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8367         (aarch64_fbsd_fpregmap): Move earlier.
8368         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8369         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8370         instead of individual calls to trad_frame_set_reg_addr.
8371         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8372         earlier.
8373         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8374         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8375         instead of individual calls to trad_frame_set_reg_addr.
8376
8377 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8378
8379         * CONTRIBUTE: Replace contribution list with wiki link.
8380
8381 2019-01-25  Tom Tromey  <tom@tromey.com>
8382
8383         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8384
8385 2019-01-25  Tom Tromey  <tom@tromey.com>
8386
8387         * xtensa-linux-nat.c: Fix common/ includes.
8388         * xml-support.h: Fix common/ includes.
8389         * xml-support.c: Fix common/ includes.
8390         * x86-linux-nat.c: Fix common/ includes.
8391         * windows-nat.c: Fix common/ includes.
8392         * varobj.h: Fix common/ includes.
8393         * varobj.c: Fix common/ includes.
8394         * value.c: Fix common/ includes.
8395         * valops.c: Fix common/ includes.
8396         * utils.c: Fix common/ includes.
8397         * unittests/xml-utils-selftests.c: Fix common/ includes.
8398         * unittests/utils-selftests.c: Fix common/ includes.
8399         * unittests/unpack-selftests.c: Fix common/ includes.
8400         * unittests/tracepoint-selftests.c: Fix common/ includes.
8401         * unittests/style-selftests.c: Fix common/ includes.
8402         * unittests/string_view-selftests.c: Fix common/ includes.
8403         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8404         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8405         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8406         * unittests/rsp-low-selftests.c: Fix common/ includes.
8407         * unittests/parse-connection-spec-selftests.c: Fix common/
8408         includes.
8409         * unittests/optional-selftests.c: Fix common/ includes.
8410         * unittests/offset-type-selftests.c: Fix common/ includes.
8411         * unittests/observable-selftests.c: Fix common/ includes.
8412         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8413         * unittests/memrange-selftests.c: Fix common/ includes.
8414         * unittests/memory-map-selftests.c: Fix common/ includes.
8415         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8416         * unittests/function-view-selftests.c: Fix common/ includes.
8417         * unittests/environ-selftests.c: Fix common/ includes.
8418         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8419         * unittests/common-utils-selftests.c: Fix common/ includes.
8420         * unittests/cli-utils-selftests.c: Fix common/ includes.
8421         * unittests/array-view-selftests.c: Fix common/ includes.
8422         * ui-file.c: Fix common/ includes.
8423         * tui/tui-io.c: Fix common/ includes.
8424         * tracepoint.h: Fix common/ includes.
8425         * tracepoint.c: Fix common/ includes.
8426         * tracefile-tfile.c: Fix common/ includes.
8427         * top.h: Fix common/ includes.
8428         * top.c: Fix common/ includes.
8429         * thread.c: Fix common/ includes.
8430         * target/waitstatus.h: Fix common/ includes.
8431         * target/waitstatus.c: Fix common/ includes.
8432         * target.h: Fix common/ includes.
8433         * target.c: Fix common/ includes.
8434         * target-memory.c: Fix common/ includes.
8435         * target-descriptions.c: Fix common/ includes.
8436         * symtab.h: Fix common/ includes.
8437         * symfile.c: Fix common/ includes.
8438         * stap-probe.c: Fix common/ includes.
8439         * spu-linux-nat.c: Fix common/ includes.
8440         * sparc-nat.c: Fix common/ includes.
8441         * source.c: Fix common/ includes.
8442         * solib.c: Fix common/ includes.
8443         * solib-target.c: Fix common/ includes.
8444         * ser-unix.c: Fix common/ includes.
8445         * ser-tcp.c: Fix common/ includes.
8446         * ser-pipe.c: Fix common/ includes.
8447         * ser-base.c: Fix common/ includes.
8448         * selftest-arch.c: Fix common/ includes.
8449         * s12z-tdep.c: Fix common/ includes.
8450         * rust-exp.y: Fix common/ includes.
8451         * rs6000-aix-tdep.c: Fix common/ includes.
8452         * riscv-tdep.c: Fix common/ includes.
8453         * remote.c: Fix common/ includes.
8454         * remote-notif.h: Fix common/ includes.
8455         * remote-fileio.h: Fix common/ includes.
8456         * remote-fileio.c: Fix common/ includes.
8457         * regcache.h: Fix common/ includes.
8458         * regcache.c: Fix common/ includes.
8459         * record-btrace.c: Fix common/ includes.
8460         * python/python.c: Fix common/ includes.
8461         * python/py-type.c: Fix common/ includes.
8462         * python/py-inferior.c: Fix common/ includes.
8463         * progspace.h: Fix common/ includes.
8464         * producer.c: Fix common/ includes.
8465         * procfs.c: Fix common/ includes.
8466         * proc-api.c: Fix common/ includes.
8467         * printcmd.c: Fix common/ includes.
8468         * ppc-linux-nat.c: Fix common/ includes.
8469         * parser-defs.h: Fix common/ includes.
8470         * osdata.c: Fix common/ includes.
8471         * obsd-nat.c: Fix common/ includes.
8472         * nat/x86-linux.c: Fix common/ includes.
8473         * nat/x86-linux-dregs.c: Fix common/ includes.
8474         * nat/x86-dregs.h: Fix common/ includes.
8475         * nat/x86-dregs.c: Fix common/ includes.
8476         * nat/ppc-linux.c: Fix common/ includes.
8477         * nat/mips-linux-watch.h: Fix common/ includes.
8478         * nat/mips-linux-watch.c: Fix common/ includes.
8479         * nat/linux-waitpid.c: Fix common/ includes.
8480         * nat/linux-ptrace.h: Fix common/ includes.
8481         * nat/linux-ptrace.c: Fix common/ includes.
8482         * nat/linux-procfs.c: Fix common/ includes.
8483         * nat/linux-personality.c: Fix common/ includes.
8484         * nat/linux-osdata.c: Fix common/ includes.
8485         * nat/linux-namespaces.c: Fix common/ includes.
8486         * nat/linux-btrace.h: Fix common/ includes.
8487         * nat/linux-btrace.c: Fix common/ includes.
8488         * nat/fork-inferior.c: Fix common/ includes.
8489         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8490         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8491         * nat/aarch64-linux.c: Fix common/ includes.
8492         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8493         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8494         * namespace.h: Fix common/ includes.
8495         * mips-linux-tdep.c: Fix common/ includes.
8496         * minsyms.c: Fix common/ includes.
8497         * mi/mi-parse.h: Fix common/ includes.
8498         * mi/mi-main.c: Fix common/ includes.
8499         * mi/mi-cmd-env.c: Fix common/ includes.
8500         * memrange.h: Fix common/ includes.
8501         * memattr.c: Fix common/ includes.
8502         * maint.h: Fix common/ includes.
8503         * maint.c: Fix common/ includes.
8504         * main.c: Fix common/ includes.
8505         * machoread.c: Fix common/ includes.
8506         * location.c: Fix common/ includes.
8507         * linux-thread-db.c: Fix common/ includes.
8508         * linux-nat.c: Fix common/ includes.
8509         * linux-fork.c: Fix common/ includes.
8510         * inline-frame.c: Fix common/ includes.
8511         * infrun.c: Fix common/ includes.
8512         * inflow.c: Fix common/ includes.
8513         * inferior.h: Fix common/ includes.
8514         * inferior.c: Fix common/ includes.
8515         * infcmd.c: Fix common/ includes.
8516         * inf-ptrace.c: Fix common/ includes.
8517         * inf-child.c: Fix common/ includes.
8518         * ia64-linux-nat.c: Fix common/ includes.
8519         * i387-tdep.c: Fix common/ includes.
8520         * i386-tdep.c: Fix common/ includes.
8521         * i386-linux-tdep.c: Fix common/ includes.
8522         * i386-linux-nat.c: Fix common/ includes.
8523         * i386-go32-tdep.c: Fix common/ includes.
8524         * i386-fbsd-tdep.c: Fix common/ includes.
8525         * i386-fbsd-nat.c: Fix common/ includes.
8526         * guile/scm-type.c: Fix common/ includes.
8527         * guile/guile.c: Fix common/ includes.
8528         * go32-nat.c: Fix common/ includes.
8529         * gnu-nat.c: Fix common/ includes.
8530         * gdbthread.h: Fix common/ includes.
8531         * gdbarch-selftests.c: Fix common/ includes.
8532         * gdb_usleep.c: Fix common/ includes.
8533         * gdb_select.h: Fix common/ includes.
8534         * gdb_bfd.c: Fix common/ includes.
8535         * gcore.c: Fix common/ includes.
8536         * fork-child.c: Fix common/ includes.
8537         * findvar.c: Fix common/ includes.
8538         * fbsd-nat.c: Fix common/ includes.
8539         * event-top.c: Fix common/ includes.
8540         * event-loop.c: Fix common/ includes.
8541         * dwarf2read.c: Fix common/ includes.
8542         * dwarf2loc.c: Fix common/ includes.
8543         * dwarf2-frame.c: Fix common/ includes.
8544         * dwarf-index-cache.c: Fix common/ includes.
8545         * dtrace-probe.c: Fix common/ includes.
8546         * disasm-selftests.c: Fix common/ includes.
8547         * defs.h: Fix common/ includes.
8548         * csky-tdep.c: Fix common/ includes.
8549         * cp-valprint.c: Fix common/ includes.
8550         * cp-support.h: Fix common/ includes.
8551         * cp-support.c: Fix common/ includes.
8552         * corelow.c: Fix common/ includes.
8553         * completer.h: Fix common/ includes.
8554         * completer.c: Fix common/ includes.
8555         * compile/compile.c: Fix common/ includes.
8556         * compile/compile-loc2c.c: Fix common/ includes.
8557         * compile/compile-cplus-types.c: Fix common/ includes.
8558         * compile/compile-cplus-symbols.c: Fix common/ includes.
8559         * command.h: Fix common/ includes.
8560         * cli/cli-dump.c: Fix common/ includes.
8561         * cli/cli-cmds.c: Fix common/ includes.
8562         * charset.c: Fix common/ includes.
8563         * build-id.c: Fix common/ includes.
8564         * btrace.h: Fix common/ includes.
8565         * btrace.c: Fix common/ includes.
8566         * breakpoint.h: Fix common/ includes.
8567         * breakpoint.c: Fix common/ includes.
8568         * ax.h:
8569         (enum agent_op): Fix common/ includes.
8570         * ax-general.c (struct aop_map): Fix common/ includes.
8571         * ax-gdb.c: Fix common/ includes.
8572         * auxv.c: Fix common/ includes.
8573         * auto-load.c: Fix common/ includes.
8574         * arm-tdep.c: Fix common/ includes.
8575         * arch/riscv.c: Fix common/ includes.
8576         * arch/ppc-linux-common.c: Fix common/ includes.
8577         * arch/i386.c: Fix common/ includes.
8578         * arch/arm.c: Fix common/ includes.
8579         * arch/arm-linux.c: Fix common/ includes.
8580         * arch/arm-get-next-pcs.c: Fix common/ includes.
8581         * arch/amd64.c: Fix common/ includes.
8582         * arch/aarch64.c: Fix common/ includes.
8583         * arch/aarch64-insn.c: Fix common/ includes.
8584         * arch-utils.c: Fix common/ includes.
8585         * amd64-windows-tdep.c: Fix common/ includes.
8586         * amd64-tdep.c: Fix common/ includes.
8587         * amd64-sol2-tdep.c: Fix common/ includes.
8588         * amd64-obsd-tdep.c: Fix common/ includes.
8589         * amd64-nbsd-tdep.c: Fix common/ includes.
8590         * amd64-linux-tdep.c: Fix common/ includes.
8591         * amd64-linux-nat.c: Fix common/ includes.
8592         * amd64-fbsd-tdep.c: Fix common/ includes.
8593         * amd64-fbsd-nat.c: Fix common/ includes.
8594         * amd64-dicos-tdep.c: Fix common/ includes.
8595         * amd64-darwin-tdep.c: Fix common/ includes.
8596         * agent.c: Fix common/ includes.
8597         * ada-lang.h: Fix common/ includes.
8598         * ada-lang.c: Fix common/ includes.
8599         * aarch64-tdep.c: Fix common/ includes.
8600
8601 2019-01-25  Tom Tromey  <tom@tromey.com>
8602
8603         * common/create-version.sh: Use common/version.h.
8604
8605 2019-01-24  Pedro Alves  <palves@redhat.com>
8606
8607         * infrun.c (signal_stop, signal_print, signal_program)
8608         (signal_catch, signal_pass): Now arrays instead of pointers.
8609         (update_signals_program_target, do_target_resume)
8610         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8611         * linux-nat.c (linux_nat_target::pass_signals)
8612         (linux_nat_target::create_inferior, linux_nat_target::attach):
8613         Adjust.
8614         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8615         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8616         * procfs.c (procfs_target::pass_signals): Adjust.
8617         * record-full.c (record_full_target::resume): Adjust.
8618         * remote.c (remote_target::pass_signals)
8619         (remote_target::program_signals): Adjust.
8620         * target-debug.h (target_debug_print_signals): Now takes a
8621         gdb::array_view as parameter.  Adjust.
8622         * target.h (target_ops) <pass_signals, program_signals>: Replace
8623         pointer and length parameters with gdb::array_view.
8624         (target_pass_signals, target_program_signals): Likewise.
8625         * target-delegates.c: Regenerate.
8626
8627 2019-01-24  Pedro Alves  <palves@redhat.com>
8628
8629         * common/forward-scope-exit.h
8630         (forward_scope_exit::forward_scope_exit): Pass arguments to
8631         m_bind_function directly, instead of creating a std::bind and
8632         copying that.
8633
8634 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8635
8636         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8637         for static members.
8638         (pass_in_v_vfp_candidate): Likewise.
8639
8640 2019-01-23  Tom Tromey  <tom@tromey.com>
8641             Pedro Alves  <palves@redhat.com>
8642
8643         * regcache.c (class regcache_invalidator): Remove.
8644         (regcache::raw_write): Use make_scope_exit.
8645
8646 2019-01-23  Tom Tromey  <tom@tromey.com>
8647
8648         * ui-out.h (class ui_out_emit_type): Update comment.
8649
8650 2019-01-23  Tom Tromey  <tom@tromey.com>
8651
8652         * infrun.c (fetch_inferior_event): Update comment.
8653
8654 2019-01-23  Tom Tromey  <tom@tromey.com>
8655             Pedro Alves  <palves@redhat.com>
8656
8657         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8658         parameter.
8659         (fetch_inferior_event): Use SCOPE_EXIT.
8660
8661
8662 2019-01-23  Tom Tromey  <tom@tromey.com>
8663             Pedro Alves  <palves@redhat.com>
8664
8665         * infrun.c (disable_thread_events): Delete.
8666         (stop_all_threads): Use SCOPE_EXIT.
8667
8668 2019-01-23  Tom Tromey  <tom@tromey.com>
8669             Pedro Alves  <palves@redhat.com>
8670
8671         * symfile.c: Include forward-scope-exit.h.
8672         (clear_symtab_users_cleanup): Replace forward declaration with
8673         a FORWARD_SCOPE_EXIT.
8674         (syms_from_objfile_1): Use the forward_scope_exit and
8675         gdb::optional instead of cleanup_function.
8676         (reread_symbols): Use the forward_scope_exit instead of
8677         cleanup_function.
8678         (clear_symtab_users_cleanup): Remove function.
8679
8680 2019-01-23  Tom Tromey  <tom@tromey.com>
8681             Pedro Alves  <palves@redhat.com>
8682
8683         * linux-nat.c: Include scope-exit.h.
8684         (cleanup_target_stop): Remove.
8685         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8686         SCOPE_EXIT.
8687
8688 2019-01-23  Tom Tromey  <tom@tromey.com>
8689             Pedro Alves  <palves@redhat.com>
8690
8691         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8692         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8693
8694 2019-01-23  Tom Tromey  <tom@tromey.com>
8695             Andrew Burgess  <andrew.burgess@embecosm.com>
8696             Pedro Alves  <palves@redhat.com>
8697
8698         * infrun.c (fetch_inferior_event): Use scope_exit.
8699         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8700         * top.c (execute_command): Use scope_exit.
8701         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8702         * utils.c (do_bpstat_clear_actions_cleanup)
8703         (make_bpstat_clear_actions_cleanup): Remove.
8704
8705 2019-01-23  Tom Tromey  <tom@tromey.com>
8706             Pedro Alves  <palves@redhat.com>
8707
8708         * infrun.c: Include "common/scope-exit.h"
8709         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8710         (wait_for_inferior): Use SCOPE_EXIT.
8711         (fetch_inferior_event): Use scope_exit.
8712
8713 2019-01-23  Tom Tromey  <tom@tromey.com>
8714             Pedro Alves  <palves@redhat.com>
8715
8716         * breakpoint.c (create_breakpoint): Remove cleanup.
8717
8718 2019-01-23  Tom Tromey  <tom@tromey.com>
8719             Andrew Burgess  <andrew.burgess@embecosm.com>
8720             Pedro Alves  <palves@redhat.com>
8721
8722 2019-01-23  Pedro Alves  <palves@redhat.com>
8723
8724         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8725
8726 2019-01-23  Pedro Alves  <palves@redhat.com>
8727             Andrew Burgess  <andrew.burgess@embecosm.com>
8728
8729         * gdbthread.h: Include "common/forward-scope-exit.h".
8730         (scoped_finish_thread_state): Redefine custom class in terms of
8731         forward_scope_exit.
8732
8733 2019-01-23  Pedro Alves  <palves@redhat.com>
8734             Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * common/forward-scope-exit.h: New file.
8737
8738 2019-01-23  Pedro Alves  <palves@redhat.com>
8739             Andrew Burgess  <andrew.burgess@embecosm.com>
8740             Tom Tromey  <tom@tromey.com>
8741
8742         * common/scope-exit.h: New file.
8743
8744 2019-01-23  Pedro Alves  <palves@redhat.com>
8745
8746         * common/preprocessor.h (ESC): Rename to ...
8747         (ESC_PARENS): ... this.
8748         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8749         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752
8753         * language.h (class scoped_switch_to_sym_language_if_auto):
8754         Initialize m_lang in both cases.
8755
8756 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8757
8758         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8759         with XCNEW.
8760
8761 2019-01-22  Tom Tromey  <tom@tromey.com>
8762
8763         * corelow.c: Do not include sys/file.h.
8764
8765 2019-01-22  Tom Tromey  <tom@tromey.com>
8766
8767         * tui/tui-wingeneral.h: Include gdb_curses.h.
8768
8769 2019-01-22  Tom Tromey  <tom@tromey.com>
8770
8771         * source-cache.h (class source_cache) <get_source_lines,
8772         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8773
8774 2019-01-22  Tom Tromey  <tom@tromey.com>
8775
8776         * remote-fileio.h (struct remote_target): Declare.
8777
8778 2019-01-22  Tom Tromey  <tom@tromey.com>
8779
8780         * python/py-arch.c: Do not include py-ref.h.
8781         * python/py-bpevent.c: Do not include py-ref.h.
8782         * python/py-cmd.c: Do not include py-ref.h.
8783         * python/py-continueevent.c: Do not include py-ref.h.
8784         * python/py-event.h: Do not include py-ref.h.
8785         * python/py-evtregistry.c: Do not include py-ref.h.
8786         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8787         * python/py-frame.c: Do not include py-ref.h.
8788         * python/py-framefilter.c: Do not include py-ref.h.
8789         * python/py-function.c: Do not include py-ref.h.
8790         * python/py-infevents.c: Do not include py-ref.h.
8791         * python/py-linetable.c: Do not include py-ref.h.
8792         * python/py-objfile.c: Do not include py-ref.h.
8793         * python/py-param.c: Do not include py-ref.h.
8794         * python/py-prettyprint.c: Do not include py-ref.h.
8795         * python/py-progspace.c: Do not include py-ref.h.
8796         * python/py-symbol.c: Do not include py-ref.h.
8797         * python/py-symtab.c: Do not include py-ref.h.
8798         * python/py-type.c: Do not include py-ref.h.
8799         * python/py-unwind.c: Do not include py-ref.h.
8800         * python/py-utils.c: Do not include py-ref.h.
8801         * python/py-value.c: Do not include py-ref.h.
8802         * python/py-varobj.c: Do not include py-ref.h.
8803         * python/py-xmethods.c: Do not include py-ref.h.
8804         * python/python.c: Do not include py-ref.h.
8805         * varobj.c: Do not include py-ref.h.
8806
8807 2019-01-22  Tom Tromey  <tom@tromey.com>
8808
8809         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8810         keyword for bcache.
8811
8812 2019-01-22  Tom Tromey  <tom@tromey.com>
8813
8814         * compile/compile-cplus-types.c: Remove a comment by #include.
8815
8816 2019-01-22  Tom Tromey  <tom@tromey.com>
8817
8818         * compile/gcc-c-plugin.h: Include compile-internal.h.
8819
8820 2019-01-22  Tom Tromey  <tom@tromey.com>
8821
8822         * stabsread.c (EXTERN): Do not define.
8823         (symnum, next_symbol_text_func, processing_gcc_compilation)
8824         (within_function, global_sym_chain, global_stabs)
8825         (previous_stab_code, this_object_header_files)
8826         (n_this_object_header_files)
8827         (n_allocated_this_object_header_files): Define.
8828         * stabsread.h (EXTERN): Never define.  Use "extern".
8829
8830 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8831
8832         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8833         history_value.
8834
8835 2019-01-21  Tom Tromey  <tom@tromey.com>
8836
8837         * ui-out.c: Fix includes.
8838         * tui/tui-source.c: Fix includes.
8839         * target.c: Fix includes.
8840         * remote.c: Fix includes.
8841         * regcache.c: Fix includes.
8842         * python/py-block.c: Fix includes.
8843         * printcmd.c: Fix includes.
8844         * or1k-tdep.c: Fix includes.
8845         * mi/mi-main.c: Fix includes.
8846         * m32r-tdep.c: Fix includes.
8847         * csky-tdep.c: Fix includes.
8848         * compile/compile-cplus-types.c: Fix includes.
8849         * cli/cli-interp.c: Fix includes.
8850
8851 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8852
8853         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8854         for padding.
8855
8856 2019-01-16  Tom Tromey  <tom@tromey.com>
8857
8858         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8859         earlier.
8860         (struct objfile) <msymbols_range>: Move from top level.
8861         <msymbols>: New method.
8862         (class objfile_msymbols): Remove.
8863         * symtab.c (default_collect_symbol_completion_matches_break_on):
8864         Update.
8865         * symmisc.c (dump_msymbols): Update.
8866         * stabsread.c (scan_file_globals): Update.
8867         * objc-lang.c (info_selectors_command, info_classes_command)
8868         (find_methods): Update.
8869         * minsyms.c (find_solib_trampoline_target): Update.
8870         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8871         * coffread.c (coff_symfile_read): Update.
8872         * ada-lang.c (ada_lookup_simple_minsym)
8873         (ada_collect_symbol_completion_matches): Update.
8874
8875 2019-01-16  Tom Tromey  <tom@tromey.com>
8876
8877         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8878         type.  Remove no-argument constructor.
8879         <iterator::operator++>: Simplify.
8880         <begin>: Update.
8881         <end>: Use minimal_symbol_count.
8882
8883 2019-01-16  Tom Tromey  <tom@tromey.com>
8884
8885         * objfiles.h (struct objfile) <psymtabs>: New method.
8886         (class objfile_psymtabs): Remove.
8887         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8888         typedef.
8889         <range>: New method.
8890         (require_partial_symbols): Change return type.
8891         * psymtab.c (require_partial_symbols)
8892         (psym_expand_symtabs_matching): Update.
8893         * mdebugread.c (parse_partial_symbols): Update.
8894         * dbxread.c (dbx_end_psymtab): Update.
8895
8896 2019-01-15  Tom Tromey  <tom@tromey.com>
8897
8898         * symtab.c (lookup_objfile_from_block)
8899         (lookup_symbol_in_objfile_symtabs)
8900         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8901         (find_line_symtab, info_sources_command)
8902         (default_collect_symbol_completion_matches_break_on)
8903         (make_source_files_completion_list): Update.
8904         * symmisc.c (print_objfile_statistics, dump_objfile)
8905         (maintenance_print_symbols, maintenance_info_symtabs)
8906         (maintenance_check_symtabs, maintenance_info_line_tables):
8907         Update.
8908         * source.c (select_source_symtab)
8909         (forget_cached_source_info_for_objfile): Update.
8910         * objfiles.h (class objfile_compunits): Remove.
8911         (struct objfile) <compunits_range>: New typedef.
8912         (compunits): New method.
8913         * objfiles.c (objfile_relocate1): Update.
8914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8915         * maint.c (count_symtabs_and_blocks): Update.
8916         * linespec.c (iterate_over_all_matching_symtabs): Update.
8917         * cp-support.c (add_symbol_overload_list_qualified): Update.
8918         * coffread.c (coff_symtab_read): Update.
8919         * ada-lang.c (add_nonlocal_symbols)
8920         (ada_collect_symbol_completion_matches)
8921         (ada_add_global_exceptions): Update.
8922
8923 2019-01-15  Tom Tromey  <tom@tromey.com>
8924
8925         * progspace.h (program_space) <objfiles_safe_range>: New
8926         typedef.
8927         <objfiles_safe>: New method.
8928         * objfiles.h (class all_objfiles_safe): Remove.
8929         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8930         * jit.c (jit_inferior_exit_hook): Update.
8931
8932 2019-01-17  Tom Tromey  <tom@tromey.com>
8933
8934         * progspace.h (program_space) <objfiles_range>: New typedef.
8935         <objfiles>: New method.
8936         <objfiles_head>: Rename from objfiles.
8937         (object_files): Update.
8938         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8939         * guile/scm-pretty-print.c
8940         (ppscm_find_pretty_printer_from_objfiles): Update.
8941         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8942         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8943         Update.
8944         * python/py-progspace.c (pspy_get_objfiles): Update.
8945         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8946         Update.
8947         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8948         (objfpy_lookup_objfile_by_build_id): Update.
8949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8950         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8951         Update.
8952         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8953         (expand_symtab_containing_pc, lookup_objfile_from_block)
8954         (lookup_static_symbol, basic_lookup_transparent_type)
8955         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8956         (find_line_symtab, info_sources_command)
8957         (default_collect_symbol_completion_matches_break_on)
8958         (make_source_files_completion_list, find_main_name): Update.
8959         * symmisc.c (print_symbol_bcache_statistics)
8960         (print_objfile_statistics, maintenance_print_symbols)
8961         (maintenance_print_msymbols, maintenance_print_objfiles)
8962         (maintenance_info_symtabs, maintenance_check_symtabs)
8963         (maintenance_expand_symtabs, maintenance_info_line_tables):
8964         Update.
8965         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8966         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8967         (map_overlay_command, unmap_overlay_command)
8968         (simple_overlay_update, expand_symtabs_matching)
8969         (map_symbol_filenames): Update.
8970         * symfile-debug.c (set_debug_symfile): Update.
8971         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8972         Update.
8973         * source.c (select_source_symtab, forget_cached_source_info):
8974         Update.
8975         * solib.c (solib_read_symbols): Update.
8976         * solib-spu.c (append_ocl_sos): Update.
8977         * psymtab.c (maintenance_print_psymbols)
8978         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8979         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8980         * printcmd.c (info_symbol_command): Update.
8981         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8982         Update.
8983         * objfiles.h (class all_objfiles): Remove.
8984         * objfiles.c (have_partial_symbols, have_full_symbols)
8985         (have_minimal_symbols, qsort_cmp, update_section_map)
8986         (shared_objfile_contains_address_p)
8987         (default_iterate_over_objfiles_in_search_order): Update.
8988         * objc-lang.c (info_selectors_command, info_classes_command)
8989         (find_methods): Update.
8990         * minsyms.c (find_solib_trampoline_target): Update.
8991         * maint.c (maintenance_info_sections)
8992         (maintenance_translate_address, count_symtabs_and_blocks):
8993         Update.
8994         * main.c (captured_main_1): Update.
8995         * linux-thread-db.c (try_thread_db_load_from_pdir)
8996         (has_libpthread): Update.
8997         * linespec.c (iterate_over_all_matching_symtabs)
8998         (search_minsyms_for_name): Update.
8999         * jit.c (jit_find_objf_with_entry_addr): Update.
9000         * hppa-tdep.c (find_unwind_entry)
9001         (hppa_lookup_stub_minimal_symbol): Update.
9002         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9003         Update.
9004         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9005         (elf_gnu_ifunc_resolve_by_got): Update.
9006         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9007         * dwarf-index-write.c (save_gdb_index_command): Update.
9008         * cp-support.c (add_symbol_overload_list_qualified): Update.
9009         * breakpoint.c (create_overlay_event_breakpoint)
9010         (create_longjmp_master_breakpoint)
9011         (create_std_terminate_master_breakpoint)
9012         (create_exception_master_breakpoint): Update.
9013         * blockframe.c (find_pc_partial_function): Update.
9014         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9015         (ada_collect_symbol_completion_matches)
9016         (ada_add_global_exceptions): Update.
9017
9018 2019-01-17  Tom Tromey  <tom@tromey.com>
9019
9020         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9021         declare VEC.
9022         (solib_target_parse_libraries): Change return type.
9023         (library_list_start_segment, library_list_start_section)
9024         (library_list_end_library, library_list_start_library); Update.
9025         (solib_target_free_library_list): Remove.
9026         (solib_target_parse_libraries): Remove cleanup.  Change return
9027         type.
9028         (solib_target_current_sos): Update.
9029
9030 2019-01-17  Tom Tromey  <tromey@bapiya>
9031
9032         * valprint.c: Replace "the the" with "the".
9033         * symtab.c: Replace "the the" with "the".
9034         * solib.c: Replace "the the" with "the".
9035         * solib-dsbt.c: Replace "the the" with "the".
9036         * linespec.c: Replace "the the" with "the".
9037         * dwarf2loc.h: Replace "the the" with "the".
9038         * amd64-windows-tdep.c: Replace "the the" with "the".
9039         * aarch64-tdep.c: Replace "the the" with "the".
9040
9041 2019-01-16  Keith Seitz  <keiths@redhat.com>
9042
9043         PR gdb/23773
9044         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9045         <builder>: Rename to ..
9046         <m_builder>: ... this and make private.
9047         (dwarf2_cu::get_builder): New method.  Change all users of
9048         `builder' to use this method.
9049         (dwarf2_start_symtab): Move to ...
9050         (dwarf2_cu::start_symtab): ... here.  Update all callers
9051         (setup_type_unit_groups): Move to ...
9052         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9053         callers.
9054         (dwarf2_cu::reset_builder): New method.
9055         (process_full_compunit, process_full_type_unit): Use
9056         dwarf2_cu::reset_builder.
9057         (follow_die_offset): Record the ancestor CU if it is different
9058         from the followed DIE's CU.
9059         (follow_die_sig_1): Likewise.
9060
9061 2019-01-15  Tom Tromey  <tom@tromey.com>
9062
9063         * remote.c (class remote_state) <buf>: Now a char_vector.
9064         <buf_size>: Remove.
9065         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9066         parameter.
9067         (remote_target::getpkt_or_notif_sane_1)
9068         (remote_target::getpkt_sane)
9069         (remote_target::getpkt_or_notif_sane): Likewise.
9070         (class remote_target) <putpkt>: New overload.
9071         (remote_target::read_frame): Change type of "buf_p".  Remove
9072         sizeof_p parameter.
9073         (packet_ok): New overload.
9074         (packet_check_result): New overload.
9075         Update all uses.
9076
9077 2019-01-14  Tom Tromey  <tom@tromey.com>
9078
9079         * remote-notif.c (handle_notification, remote_notif_ack)
9080         (remote_notif_parse): Make "buf" const.
9081         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9082         const.
9083         (remote_notif_parse, remote_notif_ack, handle_notification):
9084         Likewise.
9085         * remote.c (remote_notif_stop_parse): Make "buf" const.
9086         (remote_target::remote_parse_stop_reply): Make "buf" const.
9087         (remote_notif_stop_ack): Make "buf" const.
9088
9089 2019-01-14  Tom Tromey  <tom@tromey.com>
9090
9091         * remote.c (remote_console_output): Make parameter const.
9092
9093 2019-01-14  Tom Tromey  <tom@tromey.com>
9094
9095         * target-debug.h (target_debug_print_signals): Constify.
9096         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9097         * procfs.c (procfs_target::pass_signals): Update.
9098         * linux-nat.c (linux_nat_target::pass_signals): Update.
9099         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9100         * target-delegates.c: Rebuild.
9101         * remote.c (remote_target::program_signals): Update.
9102         (remote_target::pass_signals): Update.
9103         * target.c (target_pass_signals): Constify argument.
9104         (target_program_signals): Likewise.
9105         * target.h (struct target_ops) <pass_signals, program_signals>:
9106         Constify argument.
9107         (target_pass_signals, target_program_signals): Constify argument.
9108
9109 2019-01-14  Tom Tromey  <tom@tromey.com>
9110
9111         PR tui/28819:
9112         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9113
9114 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9115
9116         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9117         field.
9118         * rs6000-tdep.c: Include reggroups.h.
9119         (IS_V_ALIAS_PSEUDOREG): Define.
9120         (rs6000_register_name): Return names for the "vX" aliases.
9121         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9122         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9123         aliases.  Call default_register_reggroup_p for all other
9124         pseudo-registers.
9125         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9126         New functions.
9127         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9128         Handle "vX" aliases.
9129         (v_alias_pseudo_register_collect): New function.
9130         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9131         (rs6000_gdbarch_init): Initialize "vX" aliases as
9132         pseudo-registers.  Restore registration of
9133         rs6000_pseudo_register_reggroup_p with
9134         set_tdesc_pseudo_register_reggroup_p.
9135
9136 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9137
9138         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9139         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9140         set_gdbarch_num_pseudo_regs.
9141
9142 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9143
9144         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9145         Remove arg prefixname, add do_set and do_show.
9146         Add member functions set_list and show_list.
9147         * cli/cli-style.c (class cli_style_option): Update accordingly.
9148         (style_set_list): Move to file scope.
9149         (style_show_list): Likewise.
9150         (set_style): Call help_list.
9151         (show_style): Call cmd_show_list.
9152         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9153         Update to use the new macro.
9154
9155 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9156
9157         * ada-lang.c (_initialize_ada_language): Expand the help text
9158         for the "catch exception" command.
9159
9160 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9161
9162         * symtab.c (matching_obj_sections): Initialize obj,
9163         declare it closer to its usage.
9164
9165 2019-01-10  Tom Tromey  <tom@tromey.com>
9166
9167         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9168         (basic_inf_threads_range): Remove.
9169         (inf_threads_range, inf_non_exited_threads_range)
9170         (safe_inf_threads_range): Use next_adapter.
9171
9172 2019-01-10  Keith Seitz  <keiths@redhat.com>
9173
9174         PR gdb/23712
9175         PR symtab/23010
9176         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9177         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9178
9179 2019-01-10  Keith Seitz  <keiths@redhat.com>
9180
9181         PR gdb/23712
9182         PR symtab/23010
9183         * dictionary.c (pending_to_vector): Remove.
9184         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9185         Remove _1 suffix, replacing functions of the same name.  Update
9186         all callers.
9187         (dict_create_hashed, dict_create_hashed_expandable)
9188         (dict_create_linear, dict_create_linear_expandable, dict_free)
9189         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9190         Make functions static.
9191
9192 2019-01-10  Keith Seitz  <keiths@redhat.com>
9193
9194         PR gdb/23712
9195         PR symtab/23010
9196         * dictionary.h (struct dictionary): Replace declaration with
9197         multidictionary.
9198         (dict_create_hashed, dict_create_hashed_expandable)
9199         (dict_create_linear, dict_create_linear_expandable)
9200         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9201         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9202         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9203         taking multidictionary argument.
9204         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9205         * block.h (struct block) <dict>: Change to multidictionary
9206         and rename `multidict'.
9207         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9208         symmisc.c: Update all dictionary references to multidictionary.
9209
9210 2019-01-10  Keith Seitz  <keiths@redhat.com>
9211
9212         PR gdb/23712
9213         PR symtab/23010
9214         * dictionary.c: Include unordered_map.
9215         (pending_to_vector): New function.
9216         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9217         Rewrite the non-"_1" functions to take vector instead
9218         of linked list.
9219         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9220         "new" _1 versions of the same name.
9221         (multidictionary): Define.
9222         (std::hash<enum language): New definition.
9223         (collate_pending_symbols_by_language, mdict_create_hashed)
9224         (mdict_create_hashed_expandable, mdict_create_linear)
9225         (mdict_create_linear_expandable, mdict_free)
9226         (find_language_dictionary, create_new_language_dictionary)
9227         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9228         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9229         (mdict_size, mdict_empty): New functions.
9230         * dictionary.h (mdict_iterator): Define.
9231
9232 2019-01-10  Pedro Alves  <palves@redhat.com>
9233
9234         * breakpoint.c (read_uploaded_action)
9235         (create_tracepoint_from_upload): Adjust to use
9236         gdb::unique_xmalloc_ptr.
9237         * ctf.c (ctf_write_uploaded_tp):
9238         (SET_ARRAY_FIELD): Use emplace_back.
9239         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9240         * tracefile-tfile.c (tfile_write_uploaded_tp):
9241         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9242         gdb::unique_xmalloc_ptr.
9243         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9244         at_string, cond_string, cmd_strings>: Replace char pointers
9245         with gdb::unique_xmalloc_ptr.
9246
9247 2019-01-10  Pedro Alves  <palves@redhat.com>
9248
9249         * solib-target.c (library_list_start_library): Don't xstrdup name.
9250
9251 2019-01-10  Pedro Alves  <palves@redhat.com>
9252
9253         * mdebugread.c (parse_partial_symbols): Use
9254         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9255
9256 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * linux-fork.c (scoped_switch_fork_info)
9259         <~scoped_switch_fork_info>: Fix incorrect variable name.
9260
9261 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * linux-fork.c (scoped_switch_fork_info)
9264         <scoped_switch_fork_info>: Make explicit.
9265         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9266
9267 2019-01-10  Tom Tromey  <tom@tromey.com>
9268
9269         * objfiles.h (objfile::reset_psymtabs): Update.
9270         * objfiles.c (objfile::objfile): Update.
9271         * psymtab.h (psymtab_storage::obstack): Update.
9272         (psymtab_storage::m_obstack): Use gdb::optional.
9273         (class psymtab_storage): Update comment.  Remove objfile
9274         parameter.
9275         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9276
9277 2019-01-10  Tom Tromey  <tom@tromey.com>
9278
9279         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9280         <free_psymtabs>: Now private.
9281         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9282         (allocate_psymtab): Use new method.
9283
9284 2019-01-10  Tom Tromey  <tom@tromey.com>
9285
9286         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9287         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9288         * mdebugread.c (parse_partial_symbols): Use
9289         allocate_dependencies.
9290         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9291         allocate_dependencies.
9292         (process_psymtab_comp_unit_reader)
9293         (build_type_psymtab_dependencies): Likewise.
9294         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9295
9296 2019-01-10  Tom Tromey  <tom@tromey.com>
9297
9298         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9299         PSYMBOL_SET_LANGUAGE.
9300         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9301
9302 2019-01-10  Tom Tromey  <tom@tromey.com>
9303
9304         * psymtab.h (psymtab_storage::obstack): New method.
9305         <m_obstack>: Rename from obstack; now private.
9306         * psymtab.c (psymtab_storage): Update.
9307         * dwarf2read.c (create_addrmap_from_index)
9308         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9309         Update.
9310
9311 2019-01-10  Tom Tromey  <tom@tromey.com>
9312
9313         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9314         * objfiles.h (objfile::reset_psymtabs): New method.
9315
9316 2019-01-10  Tom Tromey  <tom@tromey.com>
9317
9318         * symmisc.c (print_symbol_bcache_statistics): Update.
9319         (print_objfile_statistics): Update.
9320         * symfile.c (reread_symbols): Update.
9321         * psymtab.h (class psymtab_storage): New.
9322         * psymtab.c (psymtab_storage): New constructor.
9323         (~psymtab_storage): New destructor.
9324         (require_partial_symbols): Update.
9325         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9326         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9327         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9328         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9329         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9330         (start_psymtab_common, end_psymtab_common)
9331         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9332         (allocate_psymtab): Update.
9333         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9334         Update.
9335         (dump_psymtab_addrmap, maintenance_print_psymbols)
9336         (maintenance_check_psymtabs): Update.
9337         (class objfile_psymtabs): Move to objfiles.h.
9338         * psympriv.h (discard_psymtab): Now inline.
9339         (psymtab_discarder::psymtab_discarder): Update.
9340         (psymtab_discarder::~psymtab_discarder): Update.
9341         (ALL_OBJFILE_PSYMTABS): Rewrite.
9342         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9343         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9344         Remove fields.
9345         <partial_symtabs>: New field.
9346         (class objfile_psymtabs): Move from psymtab.h.  Update.
9347         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9348         psymbol_cache.
9349         (objfile::~objfile): Don't destroy psymbol_cache.
9350         * mdebugread.c (parse_partial_symbols): Update.
9351         * dwarf2read.c (create_addrmap_from_index)
9352         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9353         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9354         (add_partial_subprogram, dwarf2_ranges_read): Update.
9355         * dwarf-index-write.c (write_address_map)
9356         (write_one_signatured_type, recursively_write_psymbols)
9357         (class debug_names, class debug_names, write_psymtabs_to_index):
9358         Update.
9359
9360 2019-01-10  Tom Tromey  <tom@tromey.com>
9361
9362         * symtab.h (SYMBOL_SET_NAMES): Update.
9363         (symbol_set_names): Update.
9364         (MSYMBOL_SET_NAMES): Update.
9365         * symtab.c (symbol_set_names): Change argument to be an
9366         objfile_per_bfd_storage.
9367         * psymtab.c (add_psymbol_to_bcache): Update.
9368         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9369
9370 2019-01-10  Tom Tromey  <tom@tromey.com>
9371
9372         * symtab.c (create_demangled_names_hash): Change argument to be an
9373         objfile_per_bfd_storage.
9374         (symbol_set_names): Update.
9375
9376 2019-01-10  Tom Tromey  <tom@tromey.com>
9377
9378         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9379         init_psymbol_list.
9380         * psymtab.c (init_psymbol_list): Do nothing if already called.
9381         * psympriv.h (init_psymbol_list): Add comment.
9382         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9383         init_psymbol_list.
9384         * dbxread.c (dbx_symfile_read): Unconditionally call
9385         init_psymbol_list.
9386
9387 2019-01-10  Tom Tromey  <tom@tromey.com>
9388
9389         * xcoffread.c (scan_xcoff_symtab): Update.
9390         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9391         "where".
9392         * mdebugread.c (parse_partial_symbols)
9393         (handle_psymbol_enumerators): Update.
9394         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9395         * dbxread.c (read_dbx_symtab): Update.
9396         * psympriv.h (psymbol_placement): New enum.
9397         (add_psymbol_to_list): Update.
9398
9399 2019-01-10  Tom Tromey  <tom@tromey.com>
9400
9401         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9402         static_psymbols parameters.
9403         (scan_xcoff_symtab): Update.
9404         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9405         static_psymbols parameters.
9406         * psympriv.h (start_psymtab_common): Update.
9407         * mdebugread.c (parse_partial_symbols): Update.
9408         * dwarf2read.c (create_partial_symtab): Update.
9409         * dbxread.c (read_dbx_symtab): Update.
9410         (start_psymtab): Remove global_psymbols and static_psymbols
9411         parameters.
9412
9413 2019-01-10  Tom Tromey  <tom@tromey.com>
9414
9415         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9416         * psymtab.c (allocate_psymtab): Add comment.
9417         * psympriv.h (allocate_psymtab): Add comment.
9418         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9419         initializations.
9420         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9425         Don't declare.
9426         * mipsread.c: Include mdebugread.h.
9427         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9428         Declare.
9429         * elfread.c: Include mdebugread.h.
9430
9431 2019-01-09  Tom Tromey  <tom@tromey.com>
9432
9433         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9434         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9435         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9436         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9437         (psym_lookup_symbol, psym_find_last_source_symtab)
9438         (psym_forget_cached_source_info, psym_print_stats)
9439         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9440         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9441         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9442         (psym_find_compunit_symtab_by_address)
9443         (maintenance_print_psymbols, maintenance_info_psymtabs)
9444         (maintenance_check_psymtabs): Use ranged for.
9445         * psymtab.h (class objfile_psymtabs): New.
9446         (require_partial_symbols): Return objfile_psymtabs.
9447         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9448
9449 2019-01-09  Tom Tromey  <tom@tromey.com>
9450
9451         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9452         (find_pc_mapped_section, list_overlays_command)
9453         (map_overlay_command, unmap_overlay_command)
9454         (simple_overlay_update): Use all_objfiles.
9455         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9456         * printcmd.c (info_symbol_command): Use all_objfiles.
9457         * objfiles.h (ALL_OBJSECTIONS): Remove.
9458         * maint.c (maintenance_translate_address): Use all_objfiles.
9459         * gcore.c (gcore_create_callback): Use all_objfiles.
9460         (objfile_find_memory_regions): Likewise.
9461
9462 2019-01-09  Tom Tromey  <tom@tromey.com>
9463
9464         * symtab.c (find_line_symtab, info_sources_command)
9465         (make_source_files_completion_list): Use objfile_compunits.
9466         * source.c (select_source_symtab): Use objfile_compunits.
9467         * objfiles.h (struct objfile): Update comment.
9468         (ALL_OBJFILES): Remove.
9469         (ALL_FILETABS): Remove.
9470         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9471         objfile_compunits.
9472
9473 2019-01-09  Tom Tromey  <tom@tromey.com>
9474
9475         * symmisc.c (print_objfile_statistics, dump_objfile)
9476         (maintenance_print_symbols): Use compunit_filetabs.
9477         * source.c (forget_cached_source_info_for_objfile): Use
9478         compunit_filetabs.
9479         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9480         (ALL_FILETABS): Use compunit_filetabs.
9481         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9482         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9483
9484 2019-01-09  Tom Tromey  <tom@tromey.com>
9485
9486         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9487         (compunit_filetabs): New.
9488         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9489         compunit_filetabs.
9490         (info_sources_command, make_source_files_completion_list): Remove
9491         declaration.
9492         * symmisc.c (print_objfile_statistics, dump_objfile)
9493         (maintenance_print_symbols): Remove declaration.
9494         (maintenance_info_symtabs): Use compunit_filetabs.
9495         (maintenance_info_line_tables): Likewise.
9496         * source.c (select_source_symtab): Change local variable name.
9497         (forget_cached_source_info_for_objfile): Remove declaration.
9498         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9499         * objfiles.c (objfile_relocate1): Remove declaration.
9500         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9501         declaration.
9502         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9503         * coffread.c (coff_symtab_read): Remove declaration.
9504         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9505         compunit_filetabs.
9506
9507 2019-01-09  Tom Tromey  <tom@tromey.com>
9508
9509         * symtab.c (lookup_objfile_from_block)
9510         (find_pc_sect_compunit_symtab, search_symbols)
9511         (default_collect_symbol_completion_matches_break_on): Use
9512         objfile_compunits.
9513         * objfiles.h (ALL_COMPUNITS): Remove.
9514         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9515         * cp-support.c (add_symbol_overload_list_qualified): Use
9516         objfile_compunits.
9517         * ada-lang.c (ada_collect_symbol_completion_matches)
9518         (ada_add_global_exceptions): Use objfile_compunits.
9519
9520 2019-01-09  Tom Tromey  <tom@tromey.com>
9521
9522         * source.c (select_source_symtab)
9523         (forget_cached_source_info_for_objfile): Remove declaration.
9524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9525         declaration.
9526         * maint.c (count_symtabs_and_blocks): Remove declaration.
9527         * cp-support.c (add_symbol_overload_list_qualified): Remove
9528         declaration.
9529         * coffread.c (coff_symtab_read): Remove declaration.
9530         * symtab.c (lookup_symbol_in_objfile_symtabs)
9531         (basic_lookup_transparent_type_1): Use objfile_compunits.
9532         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9533         (info_sources_command, search_symbols)
9534         (default_collect_symbol_completion_matches_break_on)
9535         (make_source_files_completion_list): Remove declaration.
9536         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9537         (ada_collect_symbol_completion_matches)
9538         (ada_add_global_exceptions): Remove declaration.
9539         * linespec.c (iterate_over_all_matching_symtabs): Use
9540         objfile_compunits.
9541         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9542         (class objfile_compunits): New.
9543         (ALL_COMPUNITS): Use objfile_compunits.
9544         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9545         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9546         objfile_compunits.
9547         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9548
9549 2019-01-09  Tom Tromey  <tom@tromey.com>
9550
9551         * symtab.c (search_symbols)
9552         (default_collect_symbol_completion_matches_break_on): Use
9553         objfile_msymbols.
9554         * ada-lang.c (ada_lookup_simple_minsym)
9555         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9556         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9557         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9558         objfile_msymbols.
9559         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9560         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9561         * objc-lang.c (find_methods): Use objfile_msymbols.
9562         (info_selectors_command, info_classes_command): Likewise.
9563         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9564         * objfiles.h (class objfile_msymbols): New.
9565         (ALL_OBJFILE_MSYMBOLS): Remove.
9566         (ALL_MSYMBOLS): Remove.
9567
9568 2019-01-09  Tom Tromey  <tom@tromey.com>
9569
9570         * common/next-iterator.h (next_adapter): Add Iterator template
9571         parameter.
9572         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9573         (class all_objfiles_safe): New.
9574         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9575         * objfiles.c (put_objfile_before): Update comment.
9576         (add_separate_debug_objfile): Likewise.
9577         (free_all_objfiles): Use all_objfiles_safe.
9578         (objfile_purge_solibs): Likewise.
9579
9580 2019-01-09  Tom Tromey  <tom@tromey.com>
9581
9582         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9583         (expand_symtab_containing_pc, lookup_static_symbol)
9584         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9585         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9586         all_objfiles.
9587         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9588         * breakpoint.c (create_overlay_event_breakpoint)
9589         (create_longjmp_master_breakpoint)
9590         (create_std_terminate_master_breakpoint)
9591         (create_exception_master_breakpoint): Use all_objfiles.
9592         * linux-thread-db.c (try_thread_db_load_from_pdir)
9593         (has_libpthread): Use all_objfiles.
9594         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9595         * linespec.c (iterate_over_all_matching_symtabs)
9596         (search_minsyms_for_name): Use all_objfiles.
9597         * maint.c (maintenance_info_sections): Use all_objfiles.
9598         * main.c (captured_main_1): Use all_objfiles.
9599         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9600         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9601         * guile/scm-pretty-print.c
9602         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9603         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9604         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9605         (maintenance_print_msymbols): Use all_objfiles.
9606         * source.c (select_source_symtab): Use all_objfiles.
9607         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9608         * symfile.c (remove_symbol_file_command)
9609         (expand_symtabs_matching, map_symbol_filenames): Use
9610         all_objfiles.
9611         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9612         all_objfiles.
9613         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9614         * objc-lang.c (find_methods): Use all_objfiles.
9615         * objfiles.c (have_partial_symbols, have_full_symbols)
9616         (have_minimal_symbols, qsort_cmp)
9617         (default_iterate_over_objfiles_in_search_order): Use
9618         all_objfiles.
9619         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9620         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9621         (maintenance_check_psymtabs): Use all_objfiles.
9622         (ALL_PSYMTABS): Remove.
9623         * compile/compile-object-run.c (do_module_cleanup): Use
9624         all_objfiles.
9625         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9626         * cp-support.c (add_symbol_overload_list_qualified): Use
9627         all_objfiles.
9628         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9629         Use all_objfiles.
9630         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9631         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9632         all_objfiles.
9633         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9634         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9635         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9636         Uses all_objfiles.
9637         * solib.c (solib_read_symbols): Use all_objfiles
9638
9639 2019-01-09  Tom Tromey  <tom@tromey.com>
9640
9641         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9642         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9643         all_objfiles.
9644         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9645         * symmisc.c (print_symbol_bcache_statistics)
9646         (print_objfile_statistics, maintenance_print_objfiles)
9647         (maintenance_info_symtabs, maintenance_check_symtabs)
9648         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9649         all_objfiles.
9650         * source.c (forget_cached_source_info): Use all_objfiles.
9651         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9652         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9653         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9654         * objfiles.c (update_section_map): Use all_objfiles.
9655         (shared_objfile_contains_address_p): Likewise.
9656         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9657         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9658
9659 2019-01-09  Tom Tromey  <tom@tromey.com>
9660
9661         * common/next-iterator.h: New file.
9662         * objfiles.h (class all_objfiles): New.
9663         (struct objfile_iterator): New.
9664
9665 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9666
9667         * NEWS: Move the description of the changed "frame", "select-frame",
9668          and "info frame" commands to the Changed commands section.
9669
9670 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9671
9672         * gdbtypes.c (check_stub_method_group): Remove handling of old
9673         mangling schemes.
9674         * linespec.c (find_methods): Likewise.
9675         * stabsread.c (read_member_functions): Likewise.
9676         * valops.c (search_struct_method): Likewise.
9677         (value_struct_elt_for_reference): Likewise.
9678         * NEWS: Mention this change.
9679
9680 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9681
9682         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9683         print_source_lines.
9684         * source.c (print_source_lines_base): Update line number check.
9685         (print_source_lines): New function.
9686         (source_lines_range::source_lines_range): New function.
9687         * source.h (class source_lines_range): New class.
9688         (print_source_lines): New declaration.
9689
9690 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9691
9692         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9693
9694 2019-01-08  Tom Tromey  <tom@tromey.com>
9695             Simon Marchi  <simon.marchi@ericsson.com>
9696
9697         PR gdb/24060
9698         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9699         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9700         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9701         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9702         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9703         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9704
9705 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9706
9707         * source.c (select_source_symtab): Move header comment to
9708         declaration in source.h.
9709         (forget_cached_source_info_for_objfile): Likewise.
9710         (forget_cached_source_info): Likewise.
9711         (identify_source_line): Likewise.
9712         * source.h (identify_source_line): Move declaration from symtab.h
9713         and add comment from source.c
9714         (print_source_lines): Likewise.
9715         (forget_cached_source_info_for_objfile): Likewise.
9716         (forget_cached_source_info): Likewise.
9717         (select_source_symtab): Likewise.
9718         (enum print_source_lines_flag): Move definition from symtab.h.
9719         * symtab.h (identify_source_line): Move declaration to source.h.
9720         (print_source_lines): Likewise.
9721         (forget_cached_source_info_for_objfile): Likewise.
9722         (forget_cached_source_info): Likewise.
9723         (select_source_symtab): Likewise.
9724         (enum print_source_lines_flag): Move definition to source.h.
9725         * tui/tui-hooks.c: Add 'source.h' include.
9726
9727 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9728
9729         * source.c (print_source_lines_base): Handle requests to print
9730         reverse line number sequences, and guard against empty lines
9731         string.
9732
9733 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * source.c (print_source_lines_base): Fix skip of '\r' if next
9736         character is '\n'.
9737
9738 2019-01-06  Tom Tromey  <tom@tromey.com>
9739
9740         * c-exp.y (struct c_parse_state) <macro_original_text,
9741         expansion_obstack>: New member.
9742         (macro_original_text, expansion_obstack): Remove globals.
9743         (scan_macro_expansion, scanning_macro_expansion)
9744         (finished_macro_expansion): Update.
9745         (scan_macro_cleanup): Remove.
9746         (yylex, c_parse): Update.
9747
9748 2019-01-06  Tom Tromey  <tom@tromey.com>
9749
9750         * c-exp.y (struct c_parse_state) <strings>: New member.
9751         (operator_stoken): Update.
9752
9753 2019-01-06  Tom Tromey  <tom@tromey.com>
9754
9755         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9756         (union type_stack_elt) <typelist_val>: Now a pointer to
9757         std::vector.
9758         (type_stack_cleanup): Don't declare.
9759         (push_typelist): Update.
9760         * parse.c (pop_typelist): Return a std::vector.
9761         (push_typelist): Take a std::vector.
9762         (follow_types): Update.  Do not free args.
9763         (type_stack_cleanup): Remove.
9764         * c-exp.y (struct c_parse_state): New.
9765         (cpstate): New global.
9766         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9767         (nonempty_typelist): Update.
9768         (func_mod): Create a new vector.
9769         (c_parse): Create a c_parse_state.
9770         (check_parameter_typelist): Do not delete params.
9771         (function_method): Update.  Do not delete type_list.
9772
9773 2019-01-06  Tom Tromey  <tom@tromey.com>
9774
9775         PR gdb/28155:
9776         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9777         check_typedef.
9778         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9779         (print_return_value): Likewise.
9780
9781 2019-01-05  Tom Tromey  <tom@tromey.com>
9782
9783         * contrib/cleanup_check.py: Remove.
9784         * contrib/gcc-with-excheck: Remove.
9785         * contrib/exsummary.py: Remove.
9786         * contrib/excheck.py: Remove.
9787
9788 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9789
9790         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9791         NULL. Initialize tpprev to NULL instead of assigning it
9792         to NULL on the next statement.
9793         * windows-nat.c (windows_delete_thread): Remove check for
9794         main_thread_id before printing thread exit notifications.
9795         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9796         Remove thread ID check against main_thread_id.
9797         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9798         windows_delete_thread.
9799         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9800
9801 2019-01-04  Tom Tromey  <tom@tromey.com>
9802
9803         * compile/compile.c (_initialize_compile): Use upper case for
9804         metasyntactic variables.
9805         * symmisc.c (_initialize_symmisc): Use upper case for
9806         metasyntactic variables.
9807         * psymtab.c (_initialize_psymtab): Use upper case for
9808         metasyntactic variables.
9809         * demangle.c (demangle_command): Use upper case for metasyntactic
9810         variables.
9811         (_initialize_demangler): Likewise.
9812         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9813         variables.
9814
9815 2019-01-03  Tom Tromey  <tom@tromey.com>
9816
9817         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9818
9819 2019-01-03  Tom Tromey  <tom@tromey.com>
9820
9821         * python/py-symtab.c (salpy_str): Update.
9822         (struct salpy_sal_object) <symtab>: Now a PyObject.
9823         (salpy_dealloc): Update.
9824         (del_objfile_sal): Use gdbpy_ref.
9825
9826 2019-01-03  Tom Tromey  <tom@tromey.com>
9827
9828         * python/py-type.c (convert_field): Use new_reference.  Return
9829         gdbpy_ref.
9830         (make_fielditem): Return gdbpy_ref.
9831         (typy_fields): Update.
9832         (typy_getitem): Update.
9833         (field_name): Return gdbpy_ref.  Use new_reference.
9834         (typy_iterator_iternext): Update.
9835
9836 2019-01-03  Tom Tromey  <tom@tromey.com>
9837
9838         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9839
9840 2019-01-03  Tom Tromey  <tom@tromey.com>
9841
9842         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9843         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9844         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9845         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9846         (pspy_set_type_printers): Likewise.
9847         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9848         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9849         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9850         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9851         (objfpy_set_type_printers): Likewise.
9852
9853 2019-01-03  Tom Tromey  <tom@tromey.com>
9854
9855         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9856         (gdbpy_print_stack): Use gdbpy_err_fetch.
9857         * python/python-internal.h (class gdbpy_err_fetch): New class.
9858         (class gdbpy_enter) <m_error_type, m_error_value,
9859         m_error_traceback>: Remove.
9860         <m_error>: New member.
9861         (gdbpy_exception_to_string): Don't declare.
9862         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9863         * python/py-value.c (convert_value_from_python): Use
9864         gdbpy_err_fetch.
9865         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9866         gdbpy_exception_to_string.
9867         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9868         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9869         gdbpy_err_fetch.
9870
9871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * linux-nat.c (delete_lwp_cleanup): Delete.
9874         (struct lwp_deleter): New struct.
9875         (lwp_info_up): New typedef.
9876         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9877         lwp_info_up.
9878
9879 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9880
9881         * linux-fork.c (class scoped_switch_fork_info): New class.
9882         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9883
9884 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9885
9886         * valops.c (find_overload_match): Remove use of null_cleanup, and
9887         calls to do_cleanups.
9888
9889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9890
9891         * compile/compile-cplus-types.c
9892         (compile_cplus_instance::decl_name): Handle changes to
9893         cp_func_name.
9894         * cp-support.c (cp_func_name): Update header comment, update
9895         return type.
9896         * cp-support.h (cp_func_name): Update return type in declaration.
9897         * valops.c (find_overload_match): Move temp_func local to top
9898         level of function and change its type.  Use temp_func to hold and
9899         delete temporary string obtained from cp_func_name.
9900
9901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9902
9903         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9904         gdb::char_vector, remove cleanup, and update uses of `msg`.
9905
9906 2019-01-03  Jim Wilson  <jimw@sifive.com>
9907
9908         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9909
9910 2019-01-02  Tom Tromey  <tom@tromey.com>
9911
9912         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9913         (tdesc_parse_xml): Remove cleanups.
9914         * target-descriptions.h (make_cleanup_free_target_description):
9915         Don't declare.
9916         (target_desc_deleter): New struct.
9917         (target_desc_up): New typedef.
9918         * target-descriptions.c (target_desc_deleter::operator()): Rename
9919         from free_target_description.
9920         (make_cleanup_free_target_description): Remove.
9921
9922 2019-01-02  Tom Tromey  <tom@tromey.com>
9923
9924         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9925         constructor, destructor.
9926         (linespec_parser): Remove typedef.
9927         (~linespec_parser): Rename from linespec_parser_delete.
9928         (linespec_lex_to_end, linespec_complete_label)
9929         (linespec_complete): Update.
9930         (decode_line_full): Remove cleanups.
9931         (decode_line_1): Update.
9932
9933 2019-01-02  Tom Tromey  <tom@tromey.com>
9934
9935         * python/python-internal.h (inferior_to_inferior_object): Change
9936         return type.
9937         * python/py-exitedevent.c (create_exited_event_object): Update.
9938         * python/py-inferior.c (inferior_to_inferior_object): Return
9939         gdbpy_ref.
9940         (python_new_inferior, python_inferior_deleted)
9941         (thread_to_thread_object, delete_thread_object)
9942         (build_inferior_list, gdbpy_selected_inferior): Update.
9943         * python/py-infthread.c (create_thread_object): Update.  Also fail
9944         if inferior_to_inferior_object fails.
9945
9946 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9947
9948         * inferior.h (class inferior) <displaced_step_state>: New field.
9949         * infrun.h (struct displaced_step_state): Move here from
9950         infrun.c.  Initialize fields, add constructor.
9951         <inf>: Remove field.
9952         <reset>: New method.
9953         * infrun.c (struct displaced_step_inferior_state): Move to
9954         infrun.h.
9955         (displaced_step_inferior_states): Remove.
9956         (get_displaced_stepping_state): Adust.
9957         (displaced_step_in_progress_any_inferior): Adjust.
9958         (displaced_step_in_progress_thread): Adjust.
9959         (displaced_step_in_progress): Adjust.
9960         (add_displaced_stepping_state): Remove.
9961         (get_displaced_step_closure_by_addr): Adjust.
9962         (remove_displaced_stepping_state): Remove.
9963         (infrun_inferior_exit): Call displaced_step_state.reset.
9964         (use_displaced_stepping): Don't check for NULL.
9965         (displaced_step_prepare_throw): Call
9966         get_displaced_stepping_state.
9967         (displaced_step_fixup): Don't check for NULL.
9968         (prepare_for_detach): Don't check for NULL.
9969
9970 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9971
9972         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9973          in case of call that did not complete.
9974
9975 2019-01-02  Andrey Utkin  <autkin@undo.io>
9976
9977         * symfile.c (find_separate_debug_file): Fix search of debug files for
9978         remote debuggee.
9979
9980 2019-01-02  Tom Tromey  <tom@tromey.com>
9981
9982         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9983         indentation.
9984         * python/py-frame.c (frapy_older): Remove cast.
9985         (frapy_newer): Likewise.
9986         * python/py-breakpoint.c (local_setattro): Remove cast.
9987         * python/py-arch.c (archpy_name): Remove local variable.
9988         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9989
9990 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9991
9992         * unittests/basic_string_view/element_access/char/empty.cc:
9993         Fix year range in copyright header.
9994
9995 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9996
9997         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9998         Delete.
9999         <operator==>: Update with for removed field.
10000         <hash>: Likewise.
10001         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10002         <isa_features>: ...this.
10003         <abi_features>: New field.
10004         (riscv_isa_flen): Update comment.
10005         (riscv_abi_xlen): New declaration.
10006         (riscv_abi_flen): New declaration.
10007         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10008         isa_features.
10009         (riscv_abi_xlen): New function.
10010         (riscv_isa_flen): Update to get answer from isa_features.
10011         (riscv_abi_flen): New function.
10012         (riscv_has_fp_abi): Update to get answer from abi_features.
10013         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10014         xlen and flen.
10015         (riscv_call_info) <xlen, flen>: Update comment.
10016         (riscv_call_arg_struct): Remove invalid assertions
10017         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10018         is removed.
10019         (riscv_gdbarch_init): Gather isa features and abi features
10020         separately, ensure both match on the gdbarch when reusing an old
10021         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10022         a target with 64-bit float hardware.
10023
10024 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10025
10026         * source.c (search_command_helper): Stop reverse search
10027         when line 1 has been searched.
10028
10029 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10030
10031         * record-full.c (record_full_base_target::close): Rewrite
10032         record_full_core_buf_list free logic.
10033
10034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10035
10036         * break-catch-syscall.c (print_one_catch_syscall): xfree
10037         the last text.
10038
10039 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10040
10041         * top.c (print_gdb_version): Update Copyright year in version
10042         message.
10043
10044 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10045
10046         Update copyright year range in all GDB files.
10047
10048 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10049
10050         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10051
10052 For older changes see ChangeLog-2018.
10053 \f
10054 Local Variables:
10055 mode: change-log
10056 left-margin: 8
10057 fill-column: 74
10058 version-control: never
10059 coding: utf-8
10060 End:
10061