gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
   4         * tui/tui-win.c (tui_resize_all): Fix typo.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-wingeneral.h (tui_refresh_all): Update.
   9         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  10         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  11         * tui/tui-win.c (window_name_completer): Use foreach.
  12         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  13         (update_tab_width): Likewise.
  14         * tui/tui-layout.c (show_layout): Update.
  15         * tui/tui-data.h (class tui_window_iterator): New.
  16         (struct all_tui_windows): New.
  17         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  18
  19 2019-07-17  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  22         parameter.  Don't reference globals.
  23         (tui_reg_command): Update.
  24
  25 2019-07-17  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-regs.c (tui_show_registers): Simplify.
  28
  29 2019-07-17  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.c (tui_show_registers): Update.
  32         (tui_show_register_group): Add win_info parameter.
  33
  34 2019-07-17  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  37         Rename from tui_display_reg_element_at_line.
  38         (tui_data_window::display_registers_from_line): Update.
  39         * tui/tui-data.h (struct tui_data_window)
  40         <display_reg_element_at_line>: New method.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-regs.h (tui_display_registers_from)
  45         (tui_display_registers_from_line): Don't declare.
  46         * tui/tui-windata.c (tui_data_window::display_all_data)
  47         (tui_data_window::refresh_all)
  48         (tui_data_window::do_scroll_vertical): Update.
  49         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  50         from tui_display_registers_from.
  51         (tui_display_reg_element_at_line): Update.
  52         (tui_data_window::display_registers_from_line): Rename from
  53         tui_display_registers_from_line.
  54         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  55         display_registers_from_line>: New methods.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  60         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  61         from tui_erase_data_content.
  62         (tui_data_window::display_all_data)
  63         (tui_data_window::refresh_all)
  64         (tui_data_window::do_scroll_vertical): Update.
  65         * tui/tui-regs.c (tui_show_registers): Update.
  66         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  67         New method.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  72         declare.
  73         * tui/tui-windata.c
  74         (tui_data_window::delete_data_content_windows): Rename from
  75         tui_delete_data_content_windows.
  76         (tui_data_window::display_all_data)
  77         (tui_data_window::do_scroll_vertical): Update.
  78         * tui/tui-data.h (struct tui_data_window)
  79         <delete_data_content_windows>: New method.
  80
  81 2019-07-17  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  84         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  85
  86 2019-07-17  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  89         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  90         from tui_display_all_data.
  91         * tui/tui-win.c
  92         (tui_data_window::do_make_visible_with_new_height): Update.
  93         * tui/tui-regs.c (tui_show_registers): Update.
  94         * tui/tui-layout.c (tui_set_layout): Update.
  95         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  96         method.
  97
  98 2019-07-17  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 101         * tui/tui-windata.c (tui_display_data_from): Remove.
 102         (tui_data_window::refresh_all): Update.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 107         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 108         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 109         tui_display_registers_from_line.
 110         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 111         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 112         "force_display" parameter.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 117         declare.
 118         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 119         Rename from tui_first_reg_element_no_inline.
 120         (tui_display_reg_element_at_line)
 121         (tui_display_registers_from_line): Update.
 122         * tui/tui-data.h (struct tui_data_window)
 123         <first_reg_element_no_inline>: New method.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-windata.c (tui_display_data_from)
 128         (tui_data_window::do_scroll_vertical): Update.
 129         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 130         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 131         Rename from tui_line_from_reg_element_no.
 132         (tui_display_registers_from_line): Update.
 133         * tui/tui-data.h (struct tui_data_window)
 134         <line_from_reg_element_no>: New method.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 139         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 140         tui_last_regs_line_no.
 141         (tui_display_reg_element_at_line)
 142         (tui_display_registers_from_line): Update.
 143         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 144         method.
 145
 146 2019-07-17  Tom Tromey  <tom@tromey.com>
 147
 148         PR tui/24722:
 149         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 150         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 151         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 152         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 153         (tui_update_breakpoint_info): Likewise.
 154         * tui/tui-hooks.c (tui_event_create_breakpoint)
 155         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 156         Update.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 161
 162 2019-07-17  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-winsource.c (tui_update_source_window_as_is)
 165         (tui_update_source_windows_with_addr): Update.
 166         * tui/tui-source.h (tui_set_source_content)
 167         (tui_show_symtab_source): Add "win_info" parameter.
 168         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 169         parameter.
 170         (tui_show_symtab_source): Likewise.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-wingeneral.c
 175         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 180         (struct tui_cmd_window) <can_scroll>: New method.
 181         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 182         method.
 183
 184 2019-07-17  Tom Tromey  <tromey@adacore.com>
 185
 186         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 187         do_field_signed>: Rename.  Change type of "value".
 188         * ui-out.c (ui_out::field_signed): Rename from field_int.
 189         Change type of "value".
 190         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 191         type of "value".
 192         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 193         do_field_int.  Change type of "value".
 194         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 195         do_field_int.  Change type of "value".
 196         * tracepoint.c (trace_status_mi, tfind_1)
 197         (print_one_static_tracepoint_marker): Update.
 198         * thread.c (print_thread_info_1, print_selected_thread_frame):
 199         Update.
 200         * stack.c (print_frame, print_frame_info): Update.
 201         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 202         Update.
 203         * source.c (print_source_lines_base): Update.
 204         * skip.c (info_skip_command): Update.
 205         * record-btrace.c (btrace_ui_out_decode_error)
 206         (btrace_call_history_src_line): Update.
 207         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 208         Update.
 209         * progspace.c (print_program_space): Update.
 210         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 211         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 212         do_field_int.  Change type of "value".
 213         * mi/mi-out.c (mi_ui_out::do_table_begin)
 214         (mi_ui_out::do_table_header): Update.
 215         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 216         type of "value".
 217         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 218         (mi_cmd_data_list_changed_registers, output_register)
 219         (mi_cmd_data_read_memory, mi_load_progress)
 220         (mi_cmd_trace_frame_collected): Update.
 221         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 222         Update.
 223         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 224         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 225         (mi_cmd_var_list_children, varobj_update_one): Update.
 226         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 227         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 228         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 229         * inferior.c (print_inferior): Update.
 230         * gdb_bfd.c (print_one_bfd): Update.
 231         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 232         Update.
 233         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 234         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 235         do_field_int.  Change type of "value".
 236         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 237         do_field_int.  Change type of "value".
 238         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 239         (print_one_breakpoint_location, print_it_catch_fork)
 240         (print_one_catch_fork, print_it_catch_vfork)
 241         (print_one_catch_vfork, print_it_catch_solib)
 242         (print_it_catch_exec, print_it_ranged_breakpoint)
 243         (print_mention_watchpoint, print_mention_masked_watchpoint)
 244         (bkpt_print_it, update_static_tracepoint): Update.
 245         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 246         * break-catch-syscall.c (print_it_catch_syscall): Update.
 247         * ada-tasks.c (print_ada_task_info): Update.
 248         * ada-lang.c (print_it_exception, print_mention_exception):
 249         Update.
 250
 251 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         PR breakpoints/24541
 254         * gdbarch.c: Regenerate.
 255         * gdbarch.h: Regenerate.
 256         * gdbarch.sh: Adjust return type and parameter types for
 257         'stap_adjust_register'.
 258         (i386_stap_adjust_register): Adjust signature and return new
 259         register name.
 260         * stap-probe.c (stap_parse_register_operand): Adjust use of
 261         'gdbarch_stap_adjust_register'.
 262
 263 2019-07-17  Tom Tromey  <tromey@adacore.com>
 264
 265         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 266         declare VEC.
 267         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 268         std::vector.
 269         (struct s390_process_info): Add initializers.
 270         (s390_add_process): Use new.
 271         (s390_linux_nat_target::low_forget_process): Use delete.
 272         (s390_linux_nat_target::low_new_fork)
 273         (s390_linux_nat_target::stopped_by_watchpoint)
 274         (s390_linux_nat_target::low_prepare_to_resume)
 275         (s390_linux_nat_target::insert_watchpoint)
 276         (s390_linux_nat_target::insert_hw_breakpoint)
 277         (s390_linux_nat_target::remove_watchpoint)
 278         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 279
 280 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 281
 282         * aarch64-fbsd-nat.c: Include regcache.h.
 283         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 284         argument.
 285         (aarch64_fbsd_nat_target::fetch_registers)
 286         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 287         variable.
 288         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 289
 290 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 291
 292         * fbsd-nat.c: Include gdbarch.h.
 293
 294 2019-07-15  Tom Tromey  <tromey@adacore.com>
 295
 296         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 297
 298 2019-07-15  Tom Tromey  <tromey@adacore.com>
 299
 300         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 301         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 302         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 303         * cli-out.c (cli_ui_out::do_field_int): New method.
 304         * ui-out.c (ui_out::field_unsigned): New method.
 305         * symfile.c (generic_load): Use field_unsigned.
 306         (print_transfer_performance): Likewise.
 307         * record-btrace.c (ui_out_field_uint): Remove.
 308         (btrace_call_history_insn_range, btrace_call_history): Use
 309         field_unsigned.
 310         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 311         field_unsigned.
 312         * ui-out.h (class ui_out) <field_unsigned>: New method.
 313         <do_field_unsigned>: Likewise.
 314
 315 2019-07-15  Tom Tromey  <tromey@adacore.com>
 316
 317         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 318         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 319         * target.c (flash_erase_command): Use field_string.
 320         * infrun.c (print_signal_received_reason): Use field_string.
 321         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 322         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 323         field_string.
 324         * ada-tasks.c (print_ada_task_info): Use field_string.
 325
 326 2019-07-15  Tom Tromey  <tromey@adacore.com>
 327
 328         * target.c (flash_erase_command): Use field_core_addr.
 329         * symfile.c (generic_load): Use field_core_addr.
 330         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 331         Use field_core_addr.
 332         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 333         field_core_addr.
 334
 335 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 338         value if its desired type is smaller than a CORE_ADDR and signed.
 339
 340 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 341
 342         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 343         of changes to field names, and use new is_reference field to
 344         decide if a property is a reference or not.
 345         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 346         field.
 347         (struct dwarf2_property_baton): Update header comment, rename
 348         'referenced_type' to 'property_type' and update comments.
 349         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 350         default property type, store in property baton, update to take
 351         accound of renamed field.
 352         (read_func_scope): Update call to attr_to_dynamic_prop.
 353         (read_array_type): Likewise.
 354         (dwarf2_per_cu_addr_sized_int_type): New function.
 355         (read_subrange_index_type): Move type finding code to
 356         dwarf2_per_cu_addr_sized_int_type.
 357         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 358         (dwarf2_per_cu_addr_type): New function.
 359         (set_die_type): Update calls to attr_to_dynamic_prop.
 360
 361 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * dwarf2read.c (read_subrange_index_type): New function.
 364         (read_subrange_type): Move code into new function and call it.
 365         * gdbtypes.c (create_range_type): Add some asserts.
 366
 367 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 370         update return statements.
 371         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 372         declaration, and update comment to match.
 373         * gdbtypes.c (resolve_dynamic_array): Update call to
 374         dwarf2_evaluate_property to match new return type.
 375
 376 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 377
 378         * valarith.c (value_subscripted_rvalue): Change lowerbound
 379         parameter type from int to LONGEST.
 380         * value.h (value_subscripted_rvalue): Likewise in declaration.
 381
 382 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * cli/cli-utils.c (info_print_command_completer): New function.
 385         * cli/cli-utils.h: Add 'completer.h' include, and forward
 386         declaration for 'struct cmd_list_element'.
 387         (info_print_command_completer): Declare.
 388         * stack.c (_initialize_stack): Add completer for 'info locals' and
 389         'info args'.
 390         * symtab.c (_initialize_symtab): Add completer for 'info
 391         variables' and 'info functions'.
 392         * NEWS: Mention completion for additional info commands.
 393
 394 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 395
 396         * cli/cli-utils.c (extract_info_print_args): Delete.
 397         (extract_arg_maybe_quoted): Delete.
 398         (info_print_options_defs): New variable.
 399         (make_info_print_options_def_group): New function.
 400         (extract_info_print_options): Define new function.
 401         * cli/cli-utils.h (extract_info_print_args): Delete.
 402         (struct info_print_options): New structure.
 403         (extract_info_print_options): Declare new function.
 404         * stack.c (info_locals_command): Update to use new
 405         extract_info_print_options, also add a header comment.
 406         (info_args_command): Likewise.
 407         * symtab.c (info_variables_command): Likewise.
 408         (info_functions_command): Likewise.
 409
 410 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 413         to extract string arguments.
 414         * common/common-utils.c (extract_string_maybe_quoted): New function.
 415         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 416
 417 2019-07-11  Tom Tromey  <tromey@adacore.com>
 418
 419         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 420         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 421         * top.h (gdbinit): Don't declare.
 422         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 423         into...
 424         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 425         * top.c (gdb_init): Don't call init_cli_cmds.
 426         (gdbinit): Remove.
 427         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 428
 429 2019-07-11  Tom Tromey  <tromey@adacore.com>
 430
 431         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 432         after it has been moved.
 433
 434 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 435
 436         * valops.c (value_must_coerce_to_target): Change return type to
 437         bool.
 438         * value.h (value_must_coerce_to_target): Likewise.
 439
 440 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 441
 442         * breakpoint.c (is_hardware_watchpoint): Remove
 443         forward-declaration.
 444         (is_masked_watchpoint): Change return type to bool.
 445         (is_tracepoint): Likewise.
 446         (is_breakpoint): Likewise.
 447         (is_hardware_watchpoint): Likewise.
 448         (is_watchpoint): Likewise.
 449         (is_no_memory_software_watchpoint): Likewise.
 450         (is_catchpoint): Likewise.
 451         (breakpoint_1): Make FILTER parameter's return type bool.
 452         is_masked_watchpoint): Change return type to bool.
 453         (save_breakpoints): Make FILTER parameter's return type bool.
 454         * breakpoint.h (is_breakpoint): Change return type to bool.
 455         (is_watchpoint): Likewise.
 456         (is_catchpoint): Likewise.
 457         (is_tracepoint): Likewise.
 458
 459 2019-07-10  Tom Tromey  <tom@tromey.com>
 460
 461         * defs.h: Don't include gdbarch.h.
 462         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 463         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 464         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 465         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 466         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 467         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 468         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 469         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 470         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 471         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 472         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 473         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 474         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 475         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 476         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 477         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 478         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 479         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 480         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 481         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 482         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 483         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 484         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 485         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 486         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 487         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 488         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 489
 490 2019-07-10  Tom Tromey  <tromey@adacore.com>
 491
 492         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 493         * breakpoint.c (init_ada_exception_breakpoint): Register as
 494         bp_catchpoint.
 495         (print_one_breakpoint_location, print_one_breakpoint): Use
 496         is_ada_exception_catchpoint.
 497         * ada-lang.c (class ada_catchpoint_location): Pass
 498         bp_loc_software_breakpoint to bp_location constructor.
 499         (is_ada_exception_catchpoint): New function.
 500
 501 2019-07-10  Tom Tromey  <tromey@adacore.com>
 502
 503         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 504         VEC.
 505         (struct arm_exidx_entry): New method operator<.
 506         (struct arm_exidx_data) <section_maps>: Change type.
 507         (arm_exidx_data_free): Remove.
 508         (arm_exidx_data_key): Change type.  Move lower.
 509         (arm_exidx_new_objfile): Update.
 510         (arm_compare_exidx_entries): Remove.
 511         (arm_find_exidx_entry, _initialize_arm_tdep)
 512
 513 2019-07-10  Tom Tromey  <tromey@adacore.com>
 514
 515         * solib-spu.c (ocl_program_data_key): Change type.
 516         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 517         Update.
 518
 519 2019-07-10  Tom Tromey  <tromey@adacore.com>
 520
 521         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 522         (struct solib_aix_inferior_data) <library_list>: Change type.
 523         (solib_aix_inferior_data_handle): Change type.
 524         (get_solib_aix_inferior_data): Update.
 525         (solib_aix_free_library_list): Remove.
 526         (library_list_start_library): Update.
 527         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 528         return type.
 529         (solib_aix_get_library_list)
 530         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 531         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 532
 533 2019-07-10  Tom Tromey  <tromey@adacore.com>
 534
 535         * solib-dsbt.c (struct dsbt_info): Add initializers.
 536         (solib_dsbt_pspace_data): Change type.
 537         (dsbt_pspace_data_cleanup): Remove.
 538         (get_dsbt_info, _initialize_dsbt_solib): Update.
 539
 540 2019-07-10  Tom Tromey  <tromey@adacore.com>
 541
 542         * spu-tdep.c (spu_overlay_data): Change type.
 543         (spu_get_overlay_table, spu_overlay_new_objfile)
 544         (_initialize_spu_tdep): Update.
 545
 546 2019-07-10  Tom Tromey  <tromey@adacore.com>
 547
 548         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 549         destructor.
 550         (dbx_objfile_data_key): Change type and declare later.
 551         (DBX_SYMFILE_INFO): Rewrite.
 552         * dbxread.c (dbx_objfile_data_key): Change type.
 553         (dbx_symfile_init): Update.
 554         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 555         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 556         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 557
 558 2019-07-10  Tom Tromey  <tromey@adacore.com>
 559
 560         * jit.c (jit_program_space_key): Change type.  Move lower.
 561         (get_jit_program_space_data): Update.
 562         (jit_program_space_data_cleanup): Remove.
 563         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 564         Update.
 565         (struct jit_program_space_data): Add initializers.
 566
 567 2019-07-10  Tom Tromey  <tromey@adacore.com>
 568
 569         * solib-darwin.c (struct darwin_info): Add initializers.
 570         (solib_darwin_pspace_data): Change type.
 571         (darwin_pspace_data_cleanup): Remove.
 572         (get_darwin_info, _initialize_darwin_solib): Update.
 573
 574 2019-07-10  Tom Tromey  <tromey@adacore.com>
 575
 576         * remote-sim.c (struct sim_inferior_data): Add initializers,
 577         constructor, and destructor.
 578         (sim_inferior_data_key): Change type.  Move lower.
 579         (check_for_duplicate_sim_descriptor): Update.
 580         (get_sim_inferior_data): Use new.  Update.
 581         (~sim_inferior_data_cleanup): Rename from
 582         sim_inferior_data_cleanup.  Simplify.
 583         (gdbsim_close_inferior, simulator_command)
 584         (sim_command_completer, _initialize_remote_sim): Update.
 585         (next_pid, INITIAL_PID): Move earlier.
 586
 587 2019-07-10  Tom Tromey  <tromey@adacore.com>
 588
 589         * python/python-internal.h (create_thread_object): Return
 590         gdbpy_ref.
 591         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 592         * python/py-inferior.c (struct threadlist_entry): Add
 593         constructor.
 594         <thread_obj>: Now a gdbpy_ref.
 595         (thread_to_thread_object): Update.
 596         (add_thread_object): Use new.
 597         (delete_thread_object): Use delete.
 598         (infpy_threads): Update.
 599         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 600         GIL.
 601
 602 2019-07-10  Tom Tromey  <tromey@adacore.com>
 603
 604         * valops.c (value_cast): Specialize error message for Ada.
 605
 606 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 607
 608         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 609
 610 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 611
 612         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 613         bpstat_should_step): Return bool, adjust comments.
 614         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 615         bpstat_should_step): Likewise.
 616
 617 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 618
 619         * features/Makefile: Use feature target descriptions for Arm.
 620         * features/arm/arm-core.c: Generate new file.
 621         * features/arm/arm-fpa.c: Likewise.
 622         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 623         * features/arm/arm-m-profile.c: Likewise.
 624         * features/arm/arm-vfpv2.c: Likewise.
 625         * features/arm/arm-vfpv3.c: Likewise.
 626         * features/arm/xscale-iwmmxt.c: Likewise.
 627         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 628
 629 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 630
 631         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 632         ptrace earlier.
 633
 634 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 635
 636         * features/aarch64-pauth.c: Regenerate.
 637
 638 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 639
 640         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 641         bool.
 642         (bpstat_what): Use false instead of 0.
 643
 644 2019-07-09  Pedro Alves  <palves@redhat.com>
 645
 646         * break-catch-throw.c (is_exception_catchpoint): New.
 647         * breakpoint.c (print_one_breakpoint_location): New parameter
 648         'raw_loc'.  Handle it.  Use
 649         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 650         looking at the breakpoint's type.
 651         (print_one_breakpoint): If handling "maint info breakpoints", also
 652         print locations of exception catchpoints.
 653         * breakpoint.h (is_exception_catchpoint): Declare.
 654
 655 2019-07-09  Pedro Alves  <palves@redhat.com>
 656
 657         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 658         "addr" field.
 659         (allocate_location_exception_catchpoint): New.
 660         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 661         (initialize_throw_catchpoint_ops): Install
 662         allocate_location_exception_catchpoint as allocate_location
 663         method.
 664         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 665         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 666         bp_loc_other.
 667         (breakpoint_address_is_meaningful): Delete.
 668         (bl_address_is_meaningful): New.
 669         (breakpoint_locations_match): Adjust comment.
 670         (bp_location_from_bp_type): New, factored out of...
 671         (bp_location::bp_location(breakpoint *)): ... this.
 672         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 673         factored out of...
 674         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 675         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 676         breakpoint_address_is_meaningful.
 677         (bp_locations_compare): Adjust comment.
 678         (update_global_location_list): Use bl_address_is_meaningful
 679         instead of breakpoint_address_is_meaningful.
 680         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 681         explicit.
 682         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 683         * python/py-breakpoint.c (bppy_get_location): No longer check
 684         whether location is null.
 685
 686 2019-07-09  Pedro Alves  <palves@redhat.com>
 687
 688         PR c++/15468
 689         * breakpoint.c (print_one_breakpoint_location): Remove
 690         single-location assert.
 691
 692 2019-07-09  Tom Tromey  <tom@tromey.com>
 693
 694         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 695         * configure: Rebuild.
 696         * configure.ac: Change common to gdbsupport.
 697         * gdbsupport: Rename from common.
 698         * acinclude.m4: Change common to gdbsupport.
 699         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 700         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 701         gdbsupport.
 702         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 703         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 704         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 705         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 706         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 707         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 708         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 709         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 710         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 711         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 712         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 713         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 714         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 715         coff-pe-read.c, command.h, compile/compile-c-support.c,
 716         compile/compile-c.h, compile/compile-cplus-symbols.c,
 717         compile/compile-cplus-types.c, compile/compile-cplus.h,
 718         compile/compile-loc2c.c, compile/compile.c, completer.c,
 719         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 720         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 721         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 722         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 723         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 724         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 725         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 726         features/aarch64-core.c, features/aarch64-fpu.c,
 727         features/aarch64-pauth.c, features/aarch64-sve.c,
 728         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 729         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 730         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 731         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 732         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 733         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 734         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 735         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 736         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 737         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 738         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 739         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 740         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 741         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 742         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 743         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 744         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 745         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 746         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 747         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 748         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 749         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 750         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 751         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 752         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 753         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 754         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 755         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 756         minsyms.c, mips-linux-tdep.c, namespace.h,
 757         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 758         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 759         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 760         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 761         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 762         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 763         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 764         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 765         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 766         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 767         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 768         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 769         procfs.c, producer.c, progspace.h, psymtab.h,
 770         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 771         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 772         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 773         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 774         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 775         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 776         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 777         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 778         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 779         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 780         target-memory.c, target.c, target.h, target/waitstatus.c,
 781         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 782         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 783         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 784         unittests/array-view-selftests.c,
 785         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 786         unittests/common-utils-selftests.c,
 787         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 788         unittests/format_pieces-selftests.c,
 789         unittests/function-view-selftests.c,
 790         unittests/lookup_name_info-selftests.c,
 791         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 792         unittests/mkdir-recursive-selftests.c,
 793         unittests/observable-selftests.c,
 794         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 795         unittests/parse-connection-spec-selftests.c,
 796         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 797         unittests/scoped_fd-selftests.c,
 798         unittests/scoped_mmap-selftests.c,
 799         unittests/scoped_restore-selftests.c,
 800         unittests/string_view-selftests.c, unittests/style-selftests.c,
 801         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 802         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 803         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 804         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 805         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 806         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 807
 808 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 811         bool value.
 812         (decode_digits_ordinary): Set explicit_line field in sal.
 813         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 814         symtab_and_line that was set on an explicit line number in
 815         assembler code.  Do always update the recorded symtab and line if
 816         we do skip the prologue.
 817
 818 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * breakpoint.c (set_breakpoint_location_function): Remove
 821         explicit_loc parameter.
 822         (momentary_breakpoint_from_master): Update call to
 823         set_breakpoint_location_function.
 824         (add_location_to_breakpoint): Likewise.
 825
 826 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 829         required features based on default bfd type when no specific bfd
 830         is present.
 831
 832 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 833
 834         * NEWS: Mention that GDB printf and eval commands can now print
 835         C-style and Ada-style convenience var strings without
 836         calling the inferior.
 837         * printcmd.c (printf_c_string): Locally print GDB internal var
 838         instead of transiting via the inferior.
 839         (printf_wide_c_string): Likewise.
 840
 841 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 842
 843         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 844
 845 2019-07-04  Tom Tromey  <tom@tromey.com>
 846
 847         PR tui/24724:
 848         * tui/tui-winsource.c (tui_clear_source_content): Update.
 849         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 850         (tui_update_breakpoint_info): Update.
 851         (tui_set_exec_info_content): Update.
 852         * tui/tui-source.c (tui_set_source_content_nil): Update.
 853         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 854         has_break.
 855         * tui/tui-data.h (enum tui_bp_flag): New.
 856         (tui_bp_flags): New enum flags type.
 857         (struct tui_source_element) <break_mode>: Change type.  Rename
 858         from has_break.
 859         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 860         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 861         constants.
 862         * tui/tui-winsource.h: Fix comment.
 863
 864 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 865
 866         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 867         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 868         (store_fpregs_to_thread)
 869         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 870         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 871         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 872         (IWMMXT_REGS_SIZE): Add define.
 873         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 874         (fetch_vfp_regs, store_vfp_regs)
 875         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 876         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 877
 878 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 879
 880         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 881         defines.
 882         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 883         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 884         (ARM_INT_REGISTER_SIZE): ...to this.
 885         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 886         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 887         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 888         (arm_linux_collect_gregset, supply_nwfpe_register)
 889         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 890         defines.
 891         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 892         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 893         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 894         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 895         (arm_return_in_memory, arm_store_return_value)
 896         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 897         (arm_record_ld_st_multiple): Likewise.
 898         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 899         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 900
 901 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 902
 903         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 904         AARCH64_DISPLACED_MODIFIED_INSNS.
 905         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 906         (aarch64_displaced_step_copy_insn): Likewise.
 907         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 908         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 909         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 910         ARM_DISPLACED_MODIFIED_INSNS.
 911         * arm-tdep.c (arm_gdbarch_init): Likewise.
 912         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 913         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 914         (struct arm_displaced_step_closure): Use
 915         ARM_DISPLACED_MODIFIED_INSNS.
 916
 917 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 918
 919         * features/Makefile: Remove unused xml files.
 920         * features/aarch64.xml: Remove.
 921         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 922         * features/i386/amd64-avx-avx512.xml: Remove.
 923         * features/i386/amd64-avx-linux.xml: Remove.
 924         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 925         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 926         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 927         * features/i386/amd64-avx-mpx.xml: Remove.
 928         * features/i386/amd64-avx.xml: Remove.
 929         * features/i386/amd64-linux.xml: Remove.
 930         * features/i386/amd64-mpx-linux.xml: Remove.
 931         * features/i386/amd64-mpx.xml: Remove.
 932         * features/i386/amd64.xml: Remove.
 933         * features/i386/i386-avx-avx512-linux.xml: Remove.
 934         * features/i386/i386-avx-avx512.xml: Remove.
 935         * features/i386/i386-avx-linux.xml: Remove.
 936         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 937         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 938         * features/i386/i386-avx-mpx-linux.xml: Remove.
 939         * features/i386/i386-avx-mpx.xml: Remove.
 940         * features/i386/i386-avx.xml: Remove.
 941         * features/i386/i386-linux.xml: Remove.
 942         * features/i386/i386-mmx-linux.xml: Remove.
 943         * features/i386/i386-mmx.xml: Remove.
 944         * features/i386/i386-mpx-linux.xml: Remove.
 945         * features/i386/i386-mpx.xml: Remove.
 946         * features/i386/i386.xml: Remove.
 947         * features/i386/x32-avx-avx512-linux.xml: Remove.
 948         * features/i386/x32-avx-linux.xml: Remove.
 949         * features/i386/x32-linux.xml: Remove.
 950
 951 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * regformats/aarch64.dat: Remove.
 954         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 955         * regformats/i386/amd64-avx-linux.dat: Remove.
 956         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 957         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 958         * regformats/i386/amd64-linux.dat: Remove.
 959         * regformats/i386/amd64-mpx-linux.dat: Remove.
 960         * regformats/i386/amd64.dat: Remove.
 961         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 962         * regformats/i386/i386-avx-linux.dat: Remove.
 963         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 964         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 965         * regformats/i386/i386-linux.dat: Remove.
 966         * regformats/i386/i386-mmx-linux.dat: Remove.
 967         * regformats/i386/i386-mpx-linux.dat: Remove.
 968         * regformats/i386/i386.dat: Remove.
 969         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 970         * regformats/i386/x32-avx-linux.dat: Remove.
 971         * regformats/i386/x32-linux.dat: Remove.
 972
 973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 974
 975         * aarch64-tdep.c: Remove xml self tests.
 976         * amd64-linux-tdep.c: Likewise.
 977         * amd64-tdep.c: Likewise.
 978         * i386-linux-tdep.c: Likewise.
 979         * i386-tdep.c: Likewise.
 980
 981 2019-07-03  Pedro Alves  <palves@redhat.com>
 982
 983         PR cli/24732
 984         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 985         (pipe_cmd_option_defs): New.
 986         (make_pipe_cmd_options_def_group): New.
 987         (pipe_command): Use gdb::option::process_options.
 988         (pipe_command_completer): New function.
 989         (_initialize_cli_cmds): Install completer for "pipe" command.
 990
 991 2019-07-03  Pedro Alves  <palves@redhat.com>
 992
 993         * cli/cli-option.c (union option_value) <string>: New field.
 994         (struct option_def_and_value): Add ctor, move ctor, dtor and
 995         use DISABLE_COPY_AND_ASSIGN.
 996         (option_def_and_value::clear_value): New.
 997         (parse_option, save_option_value_in_ctx, get_val_type_str)
 998         (add_setshow_cmds_for_options): Handle var_string.
 999         * cli-option.h (union option_def::var_address) <string>: New
1000         field.
1001         (struct string_option_def): New.
1002         * maint-test-options.c (struct test_options_opts): Add default
1003         ctor and use DISABLE_COPY_AND_ASSIGN.
1004         <string_opt>: New field.
1005         (test_options_opts::~test_options_opts): New.
1006         (test_options_opts::dump): Also dump "-string".
1007         (test_options_option_defs): Install "string.
1008
1009 2019-07-03  Pedro Alves  <palves@redhat.com>
1010
1011         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1012         option_value with a null enumeration.
1013         (complete_options): Save the option values in the context.
1014         (save_option_value_in_ctx): New, factored out from ...
1015         (process_options): ... here.
1016         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1017         of the function.
1018         * maint-test-options.c (test_options_opts::dump): New, factored
1019         out from ...
1020         (maintenance_test_options_command_mode): ... here.
1021         (maintenance_test_options_command_completion_result): Delete.
1022         (maintenance_test_options_command_completion_text): Update
1023         comment.
1024         (maintenance_show_test_options_completion_result): Change
1025         prototype.  Just print
1026         maintenance_test_options_command_completion_text.
1027         (save_completion_result): New.
1028         (maintenance_test_options_completer_mode): Pass options context to
1029         complete_options, and then save a dump.
1030         (_initialize_maint_test_options): Use add_cmd to install "maint
1031         show test-options-completion-result".
1032
1033 2019-07-03  Pedro Alves  <palves@redhat.com>
1034
1035         * NEWS (New commands): Mention "with" and "maint with".
1036         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1037         (with_command, with_command_completer): New.
1038         (pipe_command): Adjust to new repeat_previous
1039         interface.
1040         (_initialize_cli_cmds): Install the "with" command and its "w"
1041         alias.
1042         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1043         declarations.
1044         * cli/cli-setshow.c (parse_cli_var_uinteger)
1045         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1046         argument strings for all var_types.
1047         (get_setshow_command_value_string): New, factored out from ...
1048         (do_show_command): ... this.
1049         * cli/cli-setshow.h: Include <string>.
1050         (get_setshow_command_value_string): Declare.
1051         * command.h (repeat_previous): Now returns const char *.  Adjust
1052         comment.
1053         * maint.c: Include "cli/cli-cmds.h".
1054         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1055         (_initialize_maint_cmds): Register the "maintenance with" command.
1056         * top.c (repeat_previous): Move bits from pipe_command here:
1057         Return the saved command line, if any; error out if there's no
1058         command to relaunch.
1059
1060 2019-07-03  Pedro Alves  <palves@redhat.com>
1061
1062         * NEWS (New commands): Mention "maint set/show test-settings"
1063         instead of "maint test-settings".
1064         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1065         (maintenance_test_settings_set_list): Rename to ...
1066         (maintenance_set_test_settings_list): ... this.
1067         (maintenance_test_settings_show_list): Rename to  ...
1068         (maintenance_show_test_settings_list): ... this.
1069         (maintenance_test_settings_cmd): Delete.
1070         (maintenance_test_settings_set_cmd): ...
1071         (maintenance_set_test_settings_cmd): ... this.
1072         (maintenance_test_settings_show_cmd): ...
1073         (maintenance_show_test_settings_cmd): ... this.
1074         (maintenance_test_settings_show_value_cmd):
1075         (maintenance_show_test_settings_value_cmd): ... this.
1076         (_initialize_maint_test_settings): No longer install the "maint
1077         test-settings" prefix command.  Rename "maint test-settings set"
1078         to "maint set test-settings", and "maint test-settings show" to
1079         "maint show test-settings".  Adjust all subcommands.
1080
1081 2019-07-03  Pedro Alves  <palves@redhat.com>
1082
1083         * maint-test-settings.c: Fix file's intro comment.  Replace all
1084         references to "test-options" with references to "test-settings",
1085         in comments.
1086
1087 2019-07-03  Pedro Alves  <palves@redhat.com>
1088
1089         * maint-test-settings.c (maintenance_test_settings_xxx)
1090         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1091         New.
1092         (maintenance_test_settings_enums): Use them.
1093         (maintenance_test_settings_enum): Default to
1094         maintenance_test_settings_xxx.
1095         (_initialize_maint_test_settings): Initialize
1096         MAINTENANCE_TEST_SETTINGS_FILENAME.
1097
1098 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1099
1100         * breakpoint.h (remove_breakpoints_inf): Change return type to
1101         void, move function documentation here.
1102         * breakpoint.c (remove_breakpoints_inf): Change return type to
1103         void, move function documentation to header.
1104
1105 2019-07-02  Pedro Alves  <palves@redhat.com>
1106
1107         * NEWS (Completion improvements): Mention "info threads".
1108         * thread.c (struct info_threads_opts, info_threads_option_defs)
1109         (make_info_threads_options_def_group): New.
1110         (info_threads_command): Use gdb::option::process_options.
1111         (info_threads_command_completer): New.
1112         (_initialize_thread): Use gdb::option::build_help to build the
1113         help text for "info threads".
1114
1115 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1116
1117         * defs.h (generic_load): Move from here...
1118         * symfile.h (generic_load): ... to here.  Rename name parameter
1119         to args.
1120         * symfile.c (generic_load): Add comment.
1121
1122 2019-07-01  Tom Tromey  <tromey@adacore.com>
1123
1124         * dwarf2read.c
1125         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1126         declaration of without_params.  Fix formatting.
1127
1128 2019-07-01  Tom Tromey  <tromey@adacore.com>
1129
1130         * ada-exp.y (find_primitive_type): Update.
1131         * ada-lang.h (ada_lookup_symbol): Update.
1132         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1133         parameter.
1134         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1135
1136 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1137
1138         PR breakpoints/24541
1139         * gdbarch.c: Regenerate.
1140         * gdbarch.h: Regenerate.
1141         * gdbarch.sh: Add 'stap_adjust_register'.
1142         * i386-tdep.c: Include '<unordered_set>'.
1143         (i386_stap_adjust_register): New function.
1144         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1145         * stap-probe.c (stap_parse_register_operand): Call
1146         'gdbarch_stap_adjust_register'.
1147
1148 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1149
1150         PR python/24742
1151         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1152         * python/python.c (do_start_initialization): Use 'xmalloc'
1153         instead of 'PyMem_Malloc'.
1154
1155 2019-06-28  Tom Tromey  <tromey@adacore.com>
1156
1157         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1158         for Ada.
1159
1160 2019-06-27  Tom Tromey  <tromey@adacore.com>
1161
1162         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1163         objfile_key.
1164         (arm_find_mapping_symbol, arm_record_special_symbol)
1165         (_initialize_arm_tdep): Update.
1166         (arm_objfile_data_free): Remove.
1167
1168 2019-06-27  Tom Tromey  <tromey@adacore.com>
1169
1170         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1171         to cp_print_static_field.
1172
1173 2019-06-26  Tom Tromey  <tromey@adacore.com>
1174
1175         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1176         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1177         declare.
1178
1179 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1180
1181         * features/aarch64-core.c (create_feature_aarch64_core):
1182         Regenerate.
1183         * features/aarch64-core.xml: Add cpsr flags.
1184
1185 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1188         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1189
1190 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1191
1192         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1193         field.
1194         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1195         use.
1196         (arm_record_special_symbol): Don't insert new symbol in sorted
1197         position, push it at the end.
1198
1199 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1200
1201         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1202         (arm_mapping_symbol_s): Remove.
1203         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1204         (arm_mapping_symbol_vec): New typedef.
1205         (struct arm_per_objfile): Add constructor.
1206         <section_maps>: Change type to
1207         std::unique_ptr<arm_mapping_symbol_vec[]>.
1208         (arm_compare_mapping_symbols): Remove.
1209         (arm_find_mapping_symbol): Adjust to section_maps type change.
1210         (arm_objfile_data_free): Call delete on arm_per_objfile.
1211         (arm_record_special_symbol): Adjust to section_maps type change.
1212         Allocate arm_per_objfile with new.
1213
1214 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1215
1216         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1217         with the command prefix.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1222         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1227         type.
1228         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1229         protected.
1230
1231 2019-06-25  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-winsource.c
1234         (tui_source_window_base::set_is_exec_point_at): Add check against
1235         LOA_ADDRESS.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-source.c (tui_set_source_content): Don't check before
1240         xfree.
1241         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1242
1243 2019-06-25  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-winsource.h (tui_update_source_window_as_is)
1246         (tui_alloc_source_buffer, tui_line_is_displayed)
1247         (tui_addr_is_displayed): Change type of win_info.
1248         * tui/tui-winsource.c (tui_update_source_window_as_is)
1249         (tui_clear_source_content, tui_show_source_line)
1250         (tui_show_source_content, tui_source_window_base::refill)
1251         (tui_source_window_base::set_is_exec_point_at)
1252         (tui_source_window_base::set_is_exec_point_at)
1253         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1254         (tui_alloc_source_buffer, tui_line_is_displayed)
1255         (tui_addr_is_displayed): Change type of win_info.  Update.
1256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1257         (tui_source_window_base::do_make_visible_with_new_height):
1258         Update.
1259         * tui/tui-source.c (tui_set_source_content)
1260         (tui_set_source_content_nil)
1261         (tui_source_window::do_scroll_vertical): Update.
1262         * tui/tui-layout.c (show_layout): Update.
1263         * tui/tui-disasm.c (tui_set_disassem_content)
1264         (tui_disasm_window::do_scroll_vertical): Update.
1265         * tui/tui-data.h (tui_win_content): Remove.
1266         (struct tui_gen_win_info) <content, content_size>: Remove.
1267         (struct tui_source_element): Add initializers and destructor.
1268         (union tui_which_element, struct tui_win_element): Remove.
1269         (struct tui_source_window_base) <content>: New field.
1270         (struct tui_data_window): Remove destructor.
1271         (tui_alloc_content, tui_free_win_content)
1272         (tui_free_all_source_wins_content): Don't declare.
1273         * tui/tui-data.c (tui_initialize_static_data): Update.
1274         (init_content_element, tui_alloc_content): Remove.
1275         (~tui_gen_win_info): Update.
1276         (~tui_data_window, tui_free_all_source_wins_content)
1277         (tui_free_win_content, free_content, free_content_elements):
1278         Remove.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-winsource.h (tui_clear_source_content)
1283         (tui_erase_source_content, tui_show_source_content): Change type
1284         of win_info.
1285         * tui/tui-winsource.c (tui_clear_source_content)
1286         (tui_erase_source_content, tui_show_source_content): Change type
1287         of win_info.
1288         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1289         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1290         win_info.
1291         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1292         win_info.
1293         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-winsource.c (tui_clear_source_content)
1298         (tui_source_window_base::set_is_exec_point_at): Update.
1299         * tui/tui-source.c (tui_set_source_content_nil): Update.
1300         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1301         a bool.
1302         * tui/tui-data.c (init_content_element): Update.
1303
1304 2019-06-25  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1307         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1308         * tui/tui-layout.c (init_and_make_win): Update.
1309         * tui/tui.h (enum tui_win_type): Update.
1310         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1311         tui_win_is_auxillary.
1312         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1313         tui_win_is_auxillary.
1314
1315 2019-06-25  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1318         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1319         (tui_delete_data_content_windows, tui_display_all_data)
1320         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1321         Update.
1322         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1323         * tui/tui-regs.c (tui_last_regs_line_no)
1324         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1325         (tui_show_registers): Update.
1326         (tui_show_register_group): Return void.  Update.
1327         (tui_display_registers_from, tui_display_reg_element_at_line)
1328         (tui_display_registers_from_line, tui_check_register_values):
1329         Update.
1330         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1331         member.
1332         (struct tui_data_window) <regs_content>: Now a std::vector.
1333         <regs_content_count>: Remove.
1334         (tui_add_content_elements, tui_free_data_content): Don't declare.
1335         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1336         (init_content_element): Remove DATA_WIN case.  Add assert.
1337         (tui_add_content_elements): Remove.
1338         (tui_data_window): Update.
1339         (tui_free_data_content): Remove.
1340         (free_content_elements): Remove DATA_WIN case.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-data.c (tui_data_item_window): Update.
1345         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1346         * tui/tui-windata.c (tui_display_all_data)
1347         (tui_display_data_from_line): Update.
1348         (tui_check_data_values): Remove.
1349         * tui/tui-regs.c (tui_show_register_group)
1350         (tui_display_reg_element_at_line): Update.
1351         * tui/tui-hooks.c (tui_register_changed)
1352         (tui_refresh_frame_and_register_information): Call
1353         tui_check_register_values.
1354         * tui/tui-data.h (struct tui_data_window) <data_content,
1355         data_content_count, data_type>: Remove.
1356         (enum tui_data_type): Remove.
1357
1358         * tui/tui-data.c (tui_data_window::clear_detail)
1359         (~tui_data_window): Update.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1364         declare.
1365         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1366         Rename from tui_first_data_item_displayed.  Update.
1367         (tui_data_window::refresh_all)
1368         (tui_data_window::do_scroll_vertical): Update.
1369         * tui/tui-data.h (struct tui_data_window)
1370         <first_data_item_displayed>: Declare new method.
1371
1372 2019-06-25  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1375         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1376         contents...
1377         (tui_initialize_static_data): ...here.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1382         (tui_display_registers_from, tui_check_register_values): Update.
1383         (tui_display_register): Remove win_info parameter; update.
1384         (tui_get_register): Change type of parameters.
1385         * tui/tui-data.h (struct tui_data_element): Remove.
1386         (union tui_which_element) <data>: Remove.
1387         <data_window>: Change type.
1388         (struct tui_data_item_window): New.
1389         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1390         case.  Add assert.
1391         (~tui_data_item_window): New destructor.
1392         (free_content_elements): Remove DATA_ITEM_WIN case.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1397         Remove.
1398
1399 2019-06-25  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-data.h (struct tui_command_element): Remove.
1402         (union tui_which_element) <command>: Remove.
1403         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1404         assert.
1405         (free_content_elements): Remove CMD_WIN case.
1406
1407 2019-06-25  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-layout.c (tui_set_layout): Update.
1410         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1411         * tui/tui-data.c (layout_def): Update.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1416         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1417         (tui_source_window_base::set_new_height): Update.
1418         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1419         Update.
1420         (tui_set_locator_fullname, tui_set_locator_info)
1421         (tui_show_frame_info): Update.
1422         * tui/tui-source.c (tui_set_source_content)
1423         (tui_source_is_displayed): Update.
1424         * tui/tui-layout.c (show_source_disasm_command, show_data)
1425         (show_source_or_disasm_and_command): Update.
1426         * tui/tui-disasm.c (tui_set_disassem_content)
1427         (tui_get_begin_asm_address): Update.
1428         * tui/tui-data.h (struct tui_locator_element): Remove.
1429         (union tui_which_element) <locator>: Remove.
1430         (struct tui_locator_window): New.
1431         (tui_locator_win_info_ptr): Change return type.
1432         * tui/tui-data.c (_locator): Change type.
1433         (tui_locator_win_info_ptr): Change return type.
1434         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1435         (tui_alloc_content): Add assert.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-winsource.c
1440         (tui_exec_info_window::maybe_allocate_content): New method.
1441         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1442         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1443         (make_source_or_disasm_window): Add cast.
1444         * tui/tui-data.h (union tui_which_element) <simple_string>:
1445         Remove.
1446         (struct tui_source_info): New.
1447         (struct tui_source_window_base) <execution_info>: Change type.
1448         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1449         case, and add assert.
1450         (tui_alloc_content): Add assert.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1455         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1456         * tui/tui-data.c (tui_alloc_win_info): Remove.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1461         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1462         can_highlight.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1467         make_visible_with_new_height method.
1468         (tui_win_info::make_visible_with_new_height): New method.
1469         (tui_source_window_base::do_make_visible_with_new_height)
1470         (tui_data_window::do_make_visible_with_new_height)
1471         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1472         (make_visible_with_new_height): Remove.
1473         (tui_resize_all, tui_adjust_win_heights): Use
1474         make_visible_with_new_height method.
1475         * tui/tui-data.h (struct tui_win_info)
1476         <do_make_visible_with_new_height, make_visible_with_new_height>:
1477         New methods.
1478         (struct tui_source_window_base, struct tui_data_window)
1479         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1480         methods.
1481
1482 2019-06-25  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1485         method.
1486         (update_tab_width): Call update_tab_width method.
1487         * tui/tui-data.h (struct tui_win_info)
1488         (struct tui_source_window_base) <update_tab_width>: New methods.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1493         parameter.
1494         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1495         parameter.
1496         (tui_gen_win_info::make_visible): Update.
1497         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1498         parameter.
1499         * tui/tui-data.h (enum tui_box): New enum.
1500         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1505         init_and_make_win for EXEC_INFO_WIN.
1506         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1507         longer inline.
1508         (struct tui_win_info) <~tui_win_info>: Inline.
1509         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1510         Don't declare.
1511         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1512         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1513         Remove.
1514         (tui_initialize_static_data): Update.
1515         (~tui_gen_win_info): Handle more cleanup here.
1516         (~tui_source_window_base): Delete "execution_info".
1517         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1518
1519 2019-06-25  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-layout.c (make_command_window): Don't set
1522         can_highlight.
1523         (show_source_disasm_command): Call the reset method.
1524         (show_data): Don't set can_highlight.  Call the reset method.
1525         (tui_gen_win_info::reset): Rename from init_gen_win_info
1526         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1527         (show_source_or_disasm_and_command): Call the reset method.
1528         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1529         (struct tui_cmd_window): Set can_highlight.
1530
1531 2019-06-25  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1534         from make_visible.
1535         (tui_make_visible, tui_make_invisible): Rewrite.
1536         (tui_win_info::make_visible): Remove.
1537         (tui_source_window_base::make_visible): Update.
1538         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1539         method.  Moved from...
1540         (struct tui_win_info) <make_visible>: ...here.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-winsource.c
1545         (tui_source_window_base::do_scroll_horizontal): Remove direction
1546         parameter.
1547         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1548         direction parameter.
1549         * tui/tui-win.c (tui_win_info::forward_scroll)
1550         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1551         (tui_win_info::right_scroll): Update.
1552         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1553         direction parameter.
1554         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1555         direction parameter.
1556         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1557         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1558         Remove direction parameter.
1559         (struct tui_source_window_base, struct tui_source_window)
1560         (struct tui_disasm_window, struct tui_data_window)
1561         (struct tui_cmd_window): Update.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-winsource.h (tui_set_exec_info_content)
1566         (tui_show_exec_info_content, tui_erase_exec_info_content)
1567         (tui_clear_exec_info_content, tui_update_exec_info): Change
1568         argument to tui_source_window_base.
1569         * tui/tui-winsource.c (tui_set_exec_info_content)
1570         (tui_show_exec_info_content, tui_erase_exec_info_content)
1571         (tui_clear_exec_info_content, tui_update_exec_info): Change
1572         argument to tui_source_window_base.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1577         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1582         check.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1587         type to void.
1588         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1589         type to void.
1590         * tui/tui-source.c (tui_set_source_content): Update.
1591         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1592
1593 2019-06-25  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-win.c (window_name_completer, tui_set_focus)
1596         (tui_all_windows_info): Use name method.
1597         * tui/tui-data.h (struct tui_gen_win_info)
1598         (struct tui_source_window, struct tui_disasm_window)
1599         (struct tui_data_window, struct tui_cmd_window) <name>: New
1600         method.
1601         (tui_win_name): Don't declare.
1602         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1603         (tui_win_name): Remove.
1604
1605 2019-06-25  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-winsource.h (tui_update_source_window)
1608         (tui_update_source_window_as_is): Change parameter type.
1609         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1610         to be a tui_source_window_base.
1611         (tui_update_source_window_as_is): Likewise.
1612         * tui/tui-win.c (make_visible_with_new_height): Update.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.c (tui_erase_source_content)
1617         (tui_show_source_content, tui_show_exec_info_content)
1618         (tui_erase_exec_info_content): Use refresh_window method.
1619         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1620         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1621         from tui_refresh_win.
1622         (tui_data_window::refresh_window): New method.
1623         (tui_win_info::refresh, tui_source_window_base::refresh)
1624         (tui_refresh_all): Use refresh_window method.
1625         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1626         method.
1627         * tui/tui-regs.c (tui_display_register): Call refresh_window
1628         method.
1629         * tui/tui-layout.c (show_source_disasm_command)
1630         (show_source_or_disasm_and_command): Call refresh_window method.
1631         * tui/tui-data.h (struct tui_gen_win_info)
1632         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1633         New method.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui.c (tui_rl_other_window, tui_enable)
1638         (tui_is_window_visible, tui_get_command_dimension): Update.
1639         * tui/tui-winsource.c (tui_update_source_window_as_is)
1640         (tui_clear_source_content, tui_erase_source_content)
1641         (tui_show_source_line, tui_source_window_base::refill)
1642         (tui_source_window_base::do_scroll_horizontal)
1643         (tui_source_window_base::set_is_exec_point_at)
1644         (tui_update_breakpoint_info, tui_set_exec_info_content)
1645         (tui_alloc_source_buffer, tui_line_is_displayed)
1646         (tui_addr_is_displayed): Update.
1647         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1648         (tui_check_and_display_highlight_if_needed)
1649         (tui_win_info::make_visible, tui_win_info::refresh)
1650         (tui_refresh_all): Update.
1651         * tui/tui-windata.c (tui_first_data_item_displayed)
1652         (tui_delete_data_content_windows, tui_erase_data_content)
1653         (tui_display_all_data, tui_data_window::refresh_all)
1654         (tui_check_data_values): Update.
1655         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1656         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1657         (tui_win_info::backward_scroll, tui_refresh_all_win)
1658         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1659         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1660         (tui_source_window_base::set_new_height)
1661         (tui_data_window::set_new_height)
1662         (make_invisible_and_set_new_height)
1663         (make_visible_with_new_height, new_height_ok)
1664         (parse_scrolling_args): Update.
1665         * tui/tui-stack.c (tui_show_frame_info): Update.
1666         * tui/tui-source.c (tui_set_source_content)
1667         (tui_set_source_content_nil, tui_source_is_displayed)
1668         (tui_source_window::do_scroll_vertical): Update.
1669         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1670         (tui_display_registers_from, tui_display_reg_element_at_line)
1671         (tui_check_register_values, tui_reg_command): Update.
1672         * tui/tui-layout.c (tui_default_win_height)
1673         (show_source_disasm_command, show_data, init_and_make_win)
1674         (show_source_or_disasm_and_command): Update.
1675         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1676         (tui_redisplay_readline, tui_mld_flush)
1677         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1678         (tui_getc): Update.
1679         * tui/tui-disasm.c (tui_set_disassem_content)
1680         (tui_disasm_window::do_scroll_vertical): Update.
1681         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1682         Now virtual.
1683         (struct tui_win_info): Derive from tui_gen_win_info.
1684         <~tui_win_info>: Mark as override.
1685         <generic>: Remove member.
1686         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1687         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1688         (~tui_data_window, ~tui_win_info)
1689         (tui_free_all_source_wins_content): Update.
1690         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.c (init_and_make_win): Use new.
1695         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1696         destructor, initializers.
1697         (tui_alloc_generic_win_info): Don't declare.
1698         * tui/tui-data.c (_locator): Add argument to constructor.
1699         (source_win, disasm_win): New globals.
1700         (exec_info): Remove.
1701         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1702         Update.
1703         (tui_alloc_generic_win_info): Remove.
1704         (init_content_element): Use new.
1705         (tui_win_info::tui_win_info): Update.
1706         (free_content_elements) <case DATA_WIN>: Use delete.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1711         * tui/tui-windata.c (tui_first_data_item_displayed)
1712         (tui_delete_data_content_windows): Update.
1713         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1714         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1715         (tui_display_registers_from, tui_check_register_values): Update.
1716         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1717         pointer.
1718         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1719         window.
1720         (tui_free_data_content): Update.
1721         (free_content_elements) <case DATA_WIN>: Free the window.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1726         Update.
1727         * tui/tui-layout.c (make_command_window)
1728         (show_source_disasm_command, show_data, init_and_make_win)
1729         (show_source_or_disasm_and_command): Update.
1730         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1731         method.
1732         <can_highight, is_highlighted>: Now bool.
1733         (tui_set_win_highlight): Don't declare.
1734         * tui/tui-data.c (tui_set_win_highlight): Remove.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-wingeneral.c (make_visible): Remove check of window
1739         type.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-win.c (tui_win_info::max_height)
1744         (tui_cmd_window::max_height): New methods.
1745         (new_height_ok): Call max_height.
1746         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1747         <max_height>: New method.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-win.c (tui_source_window_base::set_new_height)
1752         (tui_data_window::set_new_height): New methods.
1753         (make_invisible_and_set_new_height): Call set_new_height method.
1754         * tui/tui-data.h (struct tui_win_info)
1755         (struct tui_source_window_base, struct tui_data_window)
1756         <set_new_height>: New method.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1761         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1762         tui_refresh_data_win.
1763         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1764         method.
1765         (tui_refresh_all_win): Call the refresh_all method.
1766         (tui_set_focus): Likewise.
1767         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1768         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1769         Likewise.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-winsource.h (tui_refill_source_window)
1774         (tui_set_is_exec_point_at): Don't declare.
1775         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1776         (tui_source_window_base::refill): Rename from
1777         tui_refill_source_window.
1778         (tui_source_window_base::do_scroll_horizontal): Update.
1779         (tui_source_window_base::set_is_exec_point_at): Rename from
1780         tui_set_is_exec_point_at.
1781         (tui_update_all_breakpoint_info): Update.
1782         * tui/tui-stack.c (tui_show_frame_info): Update.
1783         * tui/tui-layout.c (show_data): Add cast.
1784         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1785         * tui/tui-data.h (struct tui_source_window_base) <refill,
1786         set_is_exec_point_at>: New methods.
1787         (tui_source_windows, tui_add_to_source_windows): Update types.
1788         (tui_add_to_source_windows): Remove redundant declaration.
1789         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1790         (tui_source_windows): Change return type.
1791         (tui_clear_source_windows_detail): Update.
1792         (tui_add_to_source_windows): Change type of parameter.
1793         (tui_free_all_source_wins_content): Update.
1794
1795 2019-06-25  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-wingeneral.c (tui_win_info::refresh)
1798         (tui_source_window_base::refresh): New methods.
1799         (tui_refresh_all): Call the refresh method.
1800         * tui/tui-data.h (struct tui_win_info)
1801         (struct tui_source_window_base) <refresh>: New method.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui.h (tui_is_window_visible): Return bool.
1806         * tui/tui.c (tui_is_window_visible): Return bool.
1807         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1808         (tui_make_visible, tui_make_invisible)
1809         (tui_win_info::make_visible)
1810         (tui_source_window_base::make_visible, make_all_visible)
1811         (tui_make_all_visible, tui_make_all_invisible): Update.
1812         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1813         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1814         bool.
1815         (struct tui_win_info, struct tui_source_window_base)
1816         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1817         * tui/tui-data.c (tui_init_generic_part): Update.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1822         (tui_source_window_base::make_visible): New methods.
1823         (make_all_visible): Make method call.
1824         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1825         (struct tui_source_window_base, struct tui_cmd_window): Override
1826         make_visible.
1827         (tui_win_is_source_type): Don't declare.
1828         * tui/tui-data.c (tui_win_is_source_type): Remove.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1833         NULL check.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1838         Inline constructor.  Add initializers for members.
1839         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1840         constructors; now inline in class.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-regs.c (tui_show_registers): Update.
1845         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1846         bool.
1847         * tui/tui-data.c (tui_data_window::clear_detail)
1848         (tui_data_window): Update.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-windata.c (tui_display_all_data)
1853         (tui_display_data_from_line, tui_display_data_from)
1854         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1855         Update.
1856         * tui/tui-regs.c (tui_last_regs_line_no)
1857         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1858         (tui_show_registers, tui_show_register_group)
1859         (tui_display_registers_from, tui_display_reg_element_at_line)
1860         (tui_display_registers_from_line, tui_check_register_values)
1861         (tui_reg_next, tui_reg_prev): Update.
1862         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1863         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1864         tui_data_window.
1865         (struct tui_win_info) <detail>: Remove.  Add new fields from
1866         tui_data_info.
1867         (TUI_DATA_WIN): Add cast.
1868         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1869         (~tui_data_window): Simplify.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-layout.c (show_source_disasm_command)
1874         (show_source_or_disasm_and_command): Update.
1875         * tui/tui-io.c (update_cmdwin_start_line)
1876         (tui_redisplay_readline): Update.
1877         * tui/tui-data.h (struct tui_command_info): Remove.
1878         (struct tui_win_info) <detail>: Remove command_info member.
1879         (struct tui_data_window) <start_line>: New member, from
1880         tui_command_info.
1881         (TUI_CMD_WIN): Add casts.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-winsource.c (tui_update_source_window)
1886         (tui_refill_source_window)
1887         (tui_source_window_base::do_scroll_horizontal)
1888         (tui_update_breakpoint_info, tui_set_exec_info_content)
1889         (tui_show_exec_info_content, tui_erase_exec_info_content)
1890         (tui_clear_exec_info_content): Update.
1891         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1892         Update.
1893         * tui/tui-win.c (make_invisible_and_set_new_height)
1894         (make_visible_with_new_height): Update.
1895         * tui/tui-source.c (tui_set_source_content)
1896         (tui_show_symtab_source): Update.
1897         * tui/tui-layout.c (extract_display_start_addr)
1898         (show_source_disasm_command, show_data)
1899         (make_source_or_disasm_window)
1900         (show_source_or_disasm_and_command): Update.
1901         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1902         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1903         "gdbarch".
1904         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1905         to tui_source_window_base.
1906         (struct tui_win_info) <detail>: Remove source_info member.
1907         (struct tui_source_window_base) <has_locator>: Inline.
1908         Move contents from tui_source_info; rename has_locator member to
1909         m_has_locator.
1910         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1911         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1912         header file.
1913         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1914         Simplify.
1915         (tui_free_all_source_wins_content): Cast to
1916         tui_source_window_base.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-win.c (make_invisible_and_set_new_height)
1921         (make_visible_with_new_height): Call has_locator method.
1922         * tui/tui-layout.c (show_source_disasm_command, show_data)
1923         (show_source_or_disasm_and_command): Update for bool change.
1924         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1925         (tui_win_info) <has_locator>: New method.
1926         (struct tui_source_window_base) <has_locator>: New method.
1927         (tui_win_has_locator): Don't declare.
1928         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1929         from tui_win_has_locator.
1930         (tui_source_window_base): Use false, not FALSE.
1931
1932 2019-06-25  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1935         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1936         clear_detail method directly.
1937         (tui_clear_win_detail): Remove.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1942         "this", not TUI_DISASM_WIN.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1947         declare.
1948         * tui/tui-winsource.c
1949         (tui_source_window_base::do_scroll_horizontal): Rename from
1950         tui_horizontal_source_scroll.
1951         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1952         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1953         from tui_vertical_data_scroll.
1954         * tui/tui-win.h (tui_scroll): Don't declare.
1955         * tui/tui-win.c (tui_win_info::forward_scroll)
1956         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1957         (tui_win_info::right_scroll): Rename and update.
1958         (tui_scroll_forward_command, tui_scroll_backward_command)
1959         (tui_scroll_left_command, tui_scroll_right_command): Update.
1960         (tui_scroll): Remove.
1961         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1962         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1963         from tui_vertical_source_scroll.
1964         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1965         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1966         from tui_vertical_disassem_scroll.
1967         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1968         do_scroll_horizontal>: New methods.
1969         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1970         Likewise.
1971         (struct tui_source_window_base): Add do_scroll_horizontal.
1972         (struct tui_source_window, struct tui_disasm_window): Add
1973         do_scroll_vertical.
1974         (struct tui_data_window, struct tui_cmd_window): Add
1975         do_scroll_horizontal and do_scroll_vertical.
1976         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-data.h (struct tui_source_window_base): New struct.
1981         (struct tui_source_window): Derive from tui_source_window_base.
1982         (struct tui_disasm_window): New struct.
1983         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1984         from tui_source_window::clear_detail.
1985         (tui_source_window_base): Rename from tui_source_window.
1986         (~tui_source_window_base): Rename from ~tui_source_window.
1987         (tui_alloc_win_info): Create a tui_disasm_window.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-data.h (struct tui_source_window)
1992         (struct tui_data_window): Declare destructors.
1993         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1994         destructors.
1995         (tui_win_info): Simplify.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-winsource.c (tui_display_main)
2000         (tui_update_source_windows_with_addr)
2001         (tui_update_all_breakpoint_info): Update.
2002         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2003         (new_height_ok, parse_scrolling_args): Update.
2004         * tui/tui-stack.c (tui_show_frame_info): Update.
2005         * tui/tui-data.h (struct tui_list): Remove.
2006         (tui_source_windows): Return a reference to a std::vector.
2007         * tui/tui-data.c (source_windows): Now a std::vector.
2008         (tui_source_windows): Change return type.
2009         (tui_clear_source_windows): Rewrite.
2010         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2011         (tui_free_all_source_wins_content): Rewrite.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2016         (struct tui_data_window, struct tui_cmd_window): Declare
2017         clear_detail method.
2018         * tui/tui-data.c (tui_source_window::clear_detail)
2019         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2020         methods.
2021         (tui_clear_win_detail): Simplify.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-layout.c (make_source_window, make_disasm_window)
2026         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2027         Return the new window.
2028         (show_source_disasm_command, show_data)
2029         (show_source_or_disasm_and_command): Update.
2030
2031 2019-06-25  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2034         parameter.  Return the new window.
2035         (show_source_disasm_command): Update and remove NULL check.
2036         (show_source_or_disasm_and_command): Update.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-data.h (struct tui_win_info): Make constructor
2045         protected.  Make destructor virtual.  Add initializers.
2046         (tui_source_window, tui_data_window, tui_cmd_window): New
2047         classes.
2048         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2049         constructor.  Add "type" parameter.
2050         (tui_source_window, tui_data_window, tui_cmd_window): New
2051         constructors.
2052         (tui_alloc_win_info): Instantiate the appropriate subclass.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-win.c (tui_resize_all): Use delete.
2057         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2058         destructor.
2059         (tui_free_window): Don't declare.
2060         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2061         Update.
2062
2063 2019-06-25  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-data.h (struct tui_win_info): Add constructor.
2066         * tui/tui-data.c (tui_alloc_win_info): Use new.
2067         (tui_free_window): Use delete.
2068
2069 2019-06-22  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2072         declare.
2073         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2074
2075 2019-06-22  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2078         declare.
2079         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2080
2081 2019-06-22  Tom de Vries  <tdevries@suse.de>
2082
2083         * dwarf2read.c (create_addrmap_from_aranges)
2084         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2085         instead of '%zu'.
2086
2087 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2088
2089         * dwarf2read.h (dwarf2_section_info_def): Remove.
2090         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2091         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2092         std::vector<dwarf2_section_info>.
2093         (struct dwo_file) <~dwo_file>: Remove.
2094         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2095         types field.
2096         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2097         (dwarf2_read_debug_names): Likewise.
2098         (create_debug_types_hash_table): Change parameter type to
2099         array_view, adjust code accordingly.
2100         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2101         (partial_die_info::fixup): Likewise.
2102         (determine_prefix): Likewise.
2103         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2104
2105 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2106
2107         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2108         gdb_bfd_ref_ptr.
2109         <~dwo_file>: Remove call to gdb_bfd_unref.
2110         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2111         gdb_bfd_ref_ptr::get.
2112
2113 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2114
2115         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2116         type to htab_up.
2117         * dwarf2read.c (struct dwo_file): Initialize fields.
2118         <~dwo_file>: New.
2119         (free_dwo_file): Remove, move content to ~dwo_file.
2120         (struct dwo_file_deleter): Remove.
2121         (dwo_file_up>: Remove custom deleter.
2122         (free_dwo_files): Remove.
2123         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2124         dwo_files.
2125         (process_skeletonless_type_units): Call unique_ptr::get.
2126         (allocate_dwo_file_hash_table): Add deleter to created hash
2127         table.  Change return type to htab_up.
2128         (lookup_dwo_file_slot): Don't memset dwo_file, call
2129         unique_ptr::get.
2130         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2131         (create_dwo_unit_in_dwp_v2): Likewise.
2132         (open_and_init_dwo_file): Likewise.
2133         (free_dwo_file_from_slot): Remove.
2134
2135 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2136
2137         * dwarf2read.h (struct dwarf2_section_info) <readin,
2138         is_virtual>: Change type to bool.
2139         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2140         true instead of 1.
2141
2142 2019-06-19  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-data.h (tui_init_content_element): Don't declare.
2145
2146 2019-06-19  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-data.h (tui_init_win_info): Don't declare.
2149
2150 2019-06-19  Tom de Vries  <tdevries@suse.de>
2151
2152         * dwarf2read.h (abstract_to_concrete): Change type to
2153         std::unordered_map<sect_offset, std::vector<sect_offset>,
2154         gdb::hash_enum<sect_offset>>.
2155
2156 2019-06-19  Tom Tromey  <tromey@adacore.com>
2157
2158         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2159         EVAL_AVOID_SIDE_EFFECTS specially.
2160
2161 2019-06-19  Tom Tromey  <tromey@adacore.com>
2162
2163         * source-cache.c (highlighter): New global.
2164         (source_cache::get_source_lines): Create a highlighter on demand.
2165
2166 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * defs.h (deprecated_interactive_hook): Delete declaration.
2169         * interps.c (clear_interpreter_hooks): Remove use of
2170         deprecated_interactive_hook.
2171         * top.c (deprecated_interactive_hook): Delete definition.
2172         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2173
2174 2019-06-18  Tom de Vries  <tdevries@suse.de>
2175
2176         PR gdb/24515
2177         * dwarf2read.h (abstract_to_concrete): Change type from
2178         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2179         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2180         * dwarf2read.c (read_variable): Update.
2181         (dwarf2_fetch_die_loc_sect_off): Update.
2182
2183 2019-06-17  Tom de Vries  <tdevries@suse.de>
2184
2185         PR gdb/24617
2186         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2187         accessing parent[parent_len - 1].
2188
2189 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2190
2191         PR gdb/24364
2192         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2193         call dtrace_process_dof with NULL dof.
2194
2195 2019-06-16  Tom de Vries  <tdevries@suse.de>
2196
2197         PR gdb/24445
2198         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2199
2200 2019-06-16  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2203         (make_all_visible): Use address of member.
2204
2205 2019-06-16  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2208         (tui_free_window, free_content, free_content_elements): Remove
2209         unnecessary cast.
2210         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2211         cast.
2212         * tui/tui-regs.c (tui_show_register_group)
2213         (tui_display_registers_from, tui_display_reg_element_at_line):
2214         Remove unnecessary cast.
2215
2216 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * linux-nat.c (normal_mask): Delete.
2219         (_initialize_linux_nat): Don't initialise normal_mask.
2220
2221 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2222
2223         PR gdb/24445
2224         * dwarf-index-write.h (write_psymtabs_to_index): Add
2225         dwz_basename parameter.
2226         * dwarf-index-write.c (write_gdbindex): Move file writing to
2227         write_gdbindex_1.  Change return type void.
2228         (assert_file_size): Move up, remove filename parameter.
2229         (write_gdbindex_1): New function.
2230         (write_debug_names): Change return type to void, call
2231         assert_file_size.
2232         (struct index_wip_file): New struct.
2233         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2234         file logic to index_wip_file.  Write index for dwz file if
2235         needed.
2236         (save_gdb_index_command): Pass basename of dwz file, if present.
2237         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2238         build-id of dwz file, if present.
2239         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2240         (dwarf2_get_dwz_file): Likewise.
2241         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2242         (dwarf2_get_dwz_file): Likewise.
2243
2244 2019-06-16  Tom Tromey  <tom@tromey.com>
2245
2246         * coffread.c (process_coff_symbol): Use xstrdup.
2247         * value.c (create_internalvar): Use xstrdup.
2248
2249 2019-06-16  Tom Tromey  <tom@tromey.com>
2250
2251         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2252         * breakpoint.c (stopin_command, stopat_command)
2253         (until_break_command, decode_location_default): Remove unnecessary
2254         cast.
2255         * utils.c (subset_compare): Remove unnecessary cast.
2256         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2257         cast.
2258         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2259         cast.
2260         * infcmd.c (path_command): Remove unnecessary cast.
2261         * coffread.c (decode_type): Remove unnecessary cast.
2262         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2263         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2264         * tui/tui-stack.c (tui_show_locator_content)
2265         (tui_show_frame_info): Remove unnecessary cast.
2266         * tui/tui-win.c (tui_scroll_forward_command)
2267         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2268         (parse_scrolling_args): Remove unnecessary cast.
2269         * tui/tui-data.c (init_win_info, tui_del_window)
2270         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2271         (free_content_elements): Remove unnecessary cast.
2272         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2273         unnecessary cast.
2274         * tui/tui-source.c (tui_set_source_content)
2275         (tui_vertical_source_scroll): Remove unnecessary cast.
2276         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2277         cast.
2278         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2279         * tui/tui-regs.c (tui_display_registers_from)
2280         (tui_display_register): Remove unnecessary cast.
2281         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2282         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2283         (make_visible): Remove unnecessary cast.
2284         * tui/tui-winsource.c (tui_erase_source_content)
2285         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2286         unnecessary cast.
2287         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2288         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2289         * stabsread.c (read_type, read_array_type, read_range_type):
2290         Remove unnecessary cast.
2291         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2292         (parse_symbol, parse_type, upgrade_type, parse_external)
2293         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2294         unnecessary cast.
2295         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2296
2297 2019-06-16  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-data.c (tui_alloc_generic_win_info)
2300         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2301         checks.
2302
2303 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2304             Andrew Burgess  <andrew.burgess@embecosm.com>
2305
2306         * f-typeprint.c (f_print_type): Don't return early for not
2307         associated or not allocated types.
2308         (f_type_print_varspec_suffix): Add print_rank parameter and print
2309         ranks of array types in case they dangling.
2310         (f_type_print_base): Add print_rank parameter.
2311
2312 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * NEWS: Mention new MI commands.
2315         * break-catch-throw.c (enum exception_event_kind): Move to
2316         breakpoint.h.
2317         (print_mention_exception_catchpoint): Output text as a single
2318         message.
2319         (catch_exception_command_1): Rename to...
2320         (catch_exception_event): ...this, make non-static, update header
2321         command, and change some parameter types.
2322         (catch_catch_command): Update for changes to
2323         catch_exception_command_1.
2324         (catch_throw_command): Likewise.
2325         (catch_rethrow_command): Likewise.
2326         * breakpoint.c (enum exception_event_kind): Delete.
2327         * breakpoint.h (enum exception_event_kind): Moved here from
2328         break-catch-throw.c.
2329         (catch_exception_event): Declare.
2330         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2331         (mi_cmd_catch_throw): New function.
2332         (mi_cmd_catch_rethrow): New function.
2333         (mi_cmd_catch_catch): New function.
2334         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2335         'catch-catch' entries.
2336         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2337         (mi_cmd_catch_rethrow): Declare.
2338         (mi_cmd_catch_catch): Declare.
2339
2340 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2341
2342         * annotate.c (annotate_source_line): Change return type to void,
2343         update implementation to match.
2344         * annotate.h (annotate_source_line): Change return type to void,
2345         update header comment.
2346         * stack.c (print_frame_info): Don't change what frame information
2347         is printed based on whether annotations are on or not.
2348
2349 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2352         (annotate_source): Make static.
2353         (annotate_source_line): Moved from source.c and renamed from
2354         identify_source_line.  Update the return type.
2355         * annotate.h (annotate_source): Delete declaration.
2356         (annotate_source_line): Declaration moved from source.h, and
2357         renamed from identify_source_line.  Return type updated.
2358         * source.c (identify_source_line): Moved to annotate.c and renamed
2359         to annotate_source_line.
2360         (info_line_command): Remove check of annotation_level.
2361         * source.h (identify_source_line): Move declaration to annotate.h
2362         and rename to annotate_source_line.
2363         * stack.c: Add 'annotate.h' include.
2364         (print_frame_info): Remove check of annotation_level before
2365         calling annotate_source_line.
2366
2367 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * source-cache.c (source_cache::get_plain_source_lines): Use
2370         open_source_file_with_line_charpos instead of just
2371         open_source_file, remove call to find_source_lines.
2372         (source_cache::get_source_lines): Likewise.
2373         * source.c (find_source_lines): Make static.
2374         (get_filename_and_charpos): Renamed into...
2375         (open_source_file_with_line_charpos): ..this along with changes to
2376         return a scoped_fd, and some other minor clean ups.
2377         (identify_source_line): Use open_source_file_with_line_charpos.
2378         (search_command_helper): Use open_source_file_with_line_charpos
2379         instead of just open_source_file, remove call to
2380         find_source_lines.
2381         * source.h (open_source_file_with_line_charpos): Declare new
2382         function.
2383         (find_source_lines): Delete declaration.
2384
2385 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * source.c (get_filename_and_charpos): Remove fullname
2388         parameter.
2389         (identify_source_line): Update call to get_filename_and_charpos.
2390
2391 2019-06-14  Tom Tromey  <tromey@adacore.com>
2392
2393         PR gdb/24502:
2394         * ui-style.h (skip_ansi_escape): Update comment.
2395         * ui-file.h (class no_terminal_escape_file): New class.
2396         * ui-file.c (no_terminal_escape_file::write)
2397         (no_terminal_escape_file::puts): New methods.
2398         * cli/cli-logging.c (handle_redirections): Use
2399         no_terminal_escape_file.
2400
2401 2019-06-14  Tom Tromey  <tromey@adacore.com>
2402
2403         * NEWS: Move convenience variable news above Python news.
2404
2405 2019-06-14  Tom Tromey  <tom@tromey.com>
2406
2407         * gnulib: Move directory to top-level.
2408         * configure.ac: Don't configure gnulib.
2409         * configure: Rebuild.
2410         * common/common-defs.h: Use new path to gnulib.
2411         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2412         (GNULIB_H): Remove.
2413         (INCGNU): Look in new gnulib location.
2414         (HFILES_NO_SRCDIR): Remove gnulib files.
2415         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2416         (generated_files): Remove GNULIB_H.
2417         ($(LIBGNU), all-lib): Remove targets.
2418         (distclean): Don't mention GNULIB_BUILDDIR.
2419         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2420
2421 2019-06-14  Tom Tromey  <tromey@adacore.com>
2422
2423         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2424         Warn if symbol file does not provide any symbols.
2425
2426 2019-06-14  Tom Tromey  <tromey@adacore.com>
2427
2428         * source.c (find_and_open_source): Respect basenames_may_differ.
2429
2430 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * annotate.c (annotate_breakpoints_invalid): Make use of
2433         scoped_restore_terminal_state.
2434         (annotate_frames_invalid): Likewise.
2435
2436 2019-06-14  Tom Tromey  <tromey@adacore.com>
2437
2438         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2439         allow assignment to an internalvar.
2440
2441 2019-06-14  Tom Tromey  <tromey@adacore.com>
2442
2443         * ada-lex.l: Allow "_" in attribute names.
2444
2445 2019-06-14  Tom Tromey  <tromey@adacore.com>
2446
2447         PR gdb/24653:
2448         * regcache.c (registers_changed): Don't call alloca.
2449         * top.c (execute_command): Don't call alloca.
2450
2451 2019-06-13  Pedro Alves  <palves@redhat.com>
2452
2453         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2454         'expression'.  When parsing an expression, error out if there's
2455         junk after "unlimited".
2456         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2457         (do_set_command): Adjust calls to is_unlimited_literal.
2458
2459 2019-06-13  Pedro Alves  <palves@redhat.com>
2460
2461         * compile/compile.c (make_compile_options_def_group): Add braces
2462         around array_view initializer.
2463         * thread.c (make_thread_apply_all_options_def_group)
2464         (make_thread_apply_all_options_def_group): Likewise.
2465
2466 2019-06-13  Pedro Alves  <palves@redhat.com>
2467
2468         * NEWS (New commands): Mention "maint test-options
2469         require-delimiter", "maint test-options unknown-is-error", "maint
2470         test-options unknown-is-operand" and "maint show
2471         test-options-completion-result".
2472         (New command options, command completion): New section.
2473         (Completion improvements): New section.
2474         Mention that you can abbreviate "unlimited".
2475
2476 2019-06-13  Pedro Alves  <palves@redhat.com>
2477
2478         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2479         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2480         * unittests/cli-utils-selftests.c (test_parse_flags)
2481         (test_parse_flags_qcs): Delete.
2482         (test_cli_utils): Don't call deleted functions.
2483
2484 2019-06-13  Pedro Alves  <palves@redhat.com>
2485
2486         * thread.c: Include "cli/cli-option.h".
2487         (tp_array_compar_ascending): Global.
2488         (tp_array_compar): Delete function.
2489         (tp_array_compar_ascending, tp_array_compar_descending): New
2490         functions.
2491         (ascending_option_def, qcs_flag_option_def)
2492         (thr_qcs_flags_option_defs)
2493         (make_thread_apply_all_options_def_group)
2494         (make_thread_apply_options_def_group): New.
2495         (thread_apply_all_command): Use gdb::option::process_options.
2496         (thread_apply_command_completer)
2497         (thread_apply_all_command_completer): New.
2498         (thread_apply_command): Use gdb::option::process_options.
2499         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2500         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2501         to generate help text of "thread apply".  Adjust "taas"'s help.
2502         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2503         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2504
2505 2019-06-13  Pedro Alves  <palves@redhat.com>
2506
2507         * thread.c (thread_apply_command): Check for invalid TID with
2508         isdigit instead of !isalpha.
2509
2510 2019-06-13  Pedro Alves  <palves@redhat.com>
2511
2512         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2513         (validate_flags_qcs): New.
2514         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2515         (validate_flags_qcs): Declare.
2516         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2517         (make_frame_apply_options_def_group): New.
2518         (frame_apply_command_count): Process options with
2519         gdb::option::process_options.
2520         (frame_apply_completer): New.
2521         (frame_apply_level_completer, frame_apply_all_completer)
2522         (frame_apply_completer): New.
2523         (_initialize_stack): Update help of "frame apply", "frame apply
2524         level", "frame apply all" and "faas" to mention supported options
2525         and install command completers.
2526         * stack.h (frame_apply_all_completer): Declare.
2527         * thread.c: Include "stack.h".
2528         (tfaas_command): Add "--".
2529         (_initialize_thread): Update help "tfaas" to mention supported
2530         options and install command completer.
2531
2532 2019-06-13  Pedro Alves  <palves@redhat.com>
2533
2534         * completer.c (complete_nested_command_line): New.
2535         (gdb_completion_word_break_characters_throw): Add assertion.
2536         * completer.h (complete_nested_command_line): Declare.
2537
2538 2019-06-13  Pedro Alves  <palves@redhat.com>
2539
2540         * stack.c (parse_backtrace_qualifiers): New.
2541         (backtrace_command): Use it.
2542         (backtrace_command_completer): Complete on qualifiers.
2543
2544 2019-06-13  Pedro Alves  <palves@redhat.com>
2545
2546         * frame.c: Include "cli/cli-option.h.
2547         (user_set_backtrace_options): New.
2548         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2549         Delete.
2550         (get_prev_frame): Adjust.
2551         (boolean_option_def, uinteger_option_def)
2552         (set_backtrace_option_defs): New.
2553         (_initialize_frame): Adjust and use
2554         gdb::option::add_setshow_cmds_for_options to install "set
2555         backtrace past-main" and "set backtrace past-entry".
2556         * frame.h: Include "cli/cli-option.h".
2557         (struct frame_print_options): Forward declare.
2558         (print_frame_arguments_all, print_frame_arguments_scalars)
2559         (print_frame_arguments_none): Declare.
2560         (print_entry_values): Delete declaration.
2561         (struct frame_print_options, user_frame_print_options): New.
2562         (struct set_backtrace_options): New.
2563         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2564         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2565         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2566         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2567         (list_args_or_locals): Add frame_print_options parameter.
2568         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2569         * python/py-framefilter.c (enumerate_args): Pass down
2570         USER_FRAME_PRINT_OPTIONS.
2571         * stack.c: Include "cli/cli-option.h".
2572         (print_frame_arguments_all, print_frame_arguments_scalars)
2573         (print_frame_arguments_none): Declare.
2574         (print_raw_frame_arguments, print_entry_values): Delete.
2575         (user_frame_print_options): New.
2576         (boolean_option_def, enum_option_def, frame_print_option_defs):
2577         New.
2578         (struct backtrace_cmd_options): New.
2579         (bt_flag_option_def): New.
2580         (backtrace_command_option_defs): New.
2581         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2582         (print_frame_arg, read_frame_arg, print_frame_args)
2583         (print_frame_info, print_frame): Add frame_print_options parameter
2584         and use it.
2585         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2586         (backtrace_command_1): Add frame_print_options and
2587         backtrace_cmd_options parameters and use them.
2588         (make_backtrace_options_def_group): New.
2589         (backtrace_command): Process command options with
2590         gdb::option::process_options.
2591         (backtrace_command_completer): New.
2592         (_initialize_stack): Extend "backtrace"'s help to mention
2593         supported options.  Install completer for "backtrace".
2594         Install some settings commands with add_setshow_cmds_for_options.
2595
2596 2019-06-13  Pedro Alves  <palves@redhat.com>
2597
2598         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2599         and that "set/show print raw frame-arguments" are now deprecated.
2600
2601         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2602         command.
2603         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2604         * stack.c (_initialize_stack): Install "set/show print
2605         raw-frame-arguments", and deprecate "set/show print raw
2606         frame-arguments".
2607         * valprint.c (_initialize_valprint): Deprecate "set/show print
2608         raw".
2609
2610 2019-06-13  Pedro Alves  <palves@redhat.com>
2611
2612         * compile/compile.c (struct compile_options): New.
2613         (compile_flag_option_def, compile_command_option_defs)
2614         (make_compile_options_def_group): New.
2615         (compile_file_command): Handle options with
2616         gdb::option::process_options.
2617         (compile_file_command_completer): New function.
2618         (compile_code_command): Handle options with
2619         gdb::option::process_options.
2620         (compile_code_command_completer): New function.
2621         (_initialize_compiler): Install completers for "compile code" and
2622         "compile file".  Mention available options in "compile code" and
2623         "compile code"'s help.
2624         * completer.c (advance_to_completion_word): New, factored out from
2625         ...
2626         (advance_to_expression_complete_word_point): ... this.
2627         (advance_to_filename_complete_word_point): New.
2628         * completer.h (advance_to_filename_complete_word_point): New
2629         declaration.
2630
2631 2019-06-13  Pedro Alves  <palves@redhat.com>
2632
2633         * compile/compile.c: Include "cli/cli-option.h".
2634         (compile_print_value): Scope data pointer is now a
2635         value_print_options pointer; adjust.
2636         (compile_print_command): Process options.  Scope data pointer is
2637         now a value_print_options pointer; adjust.
2638         (_initialize_compile): Update "compile print"'s help to include
2639         supported options.  Install a completer for "compile print".
2640         * cp-valprint.c (show_vtblprint, show_objectprint)
2641         (show_static_field_print): Delete.
2642         (_initialize_cp_valprint): Don't install "set print
2643         static-members", "set print vtbl", "set print object" here.
2644         * printcmd.c: Include "cli/cli-option.h" and
2645         "common/gdb_optional.h".
2646         (print_command_parse_format): Rework to fill in a
2647         value_print_options instead of a format_data.
2648         (print_value): Change parameter type from format_data pointer to
2649         value_print_options reference.  Adjust.
2650         (print_command_1): Process options.  Adjust to pass down a
2651         value_print_options.
2652         (print_command_completer): New.
2653         (_initialize_printcmd): Install print_command_completer as
2654         handle_brkchars completer for the "print" command.  Update
2655         "print"'s help to include supported options.
2656         * valprint.c: Include "cli/cli-option.h".
2657         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2658         here from cp-valprint.c.
2659         (boolean_option_def, uinteger_option_def)
2660         (value_print_option_defs, make_value_print_options_def_group):
2661         New.  Use gdb::option::add_setshow_cmds_for_options to install
2662         "set print elements", "set print null-stop", "set print repeats",
2663         "set print pretty", "set print union", "set print array", "set
2664         print address", "set print symbol", "set print array-indexes".
2665         * valprint.h: Include <string> and "cli/cli-option.h".
2666         (make_value_print_options_def_group): Declare.
2667         (print_value): Change parameter type from format_data pointer to
2668         value_print_options reference.
2669         (print_command_completer): Declare.
2670
2671 2019-06-13  Pedro Alves  <palves@redhat.com>
2672
2673         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2674         (COMMON_SFILES): Add maint-test-settings.c.
2675         * cli/cli-decode.c (boolean_enums): New global, factored out from
2676         ...
2677         (add_setshow_boolean_cmd): ... here.
2678         * cli/cli-decode.h (boolean_enums): Declare.
2679         * cli/cli-option.c: New file.
2680         * cli/cli-option.h: New file.
2681         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2682         factored out from ...
2683         (parse_cli_boolean_value(const char *)): ... this.
2684         (is_unlimited_literal): Change parameter type to pointer to
2685         pointer.  Adjust and advance ARG pointer.
2686         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2687         (parse_cli_var_enum): New, factored out from ...
2688         (do_set_command): ... this.  Adjust.
2689         * cli/cli-setshow.h (parse_cli_boolean_value)
2690         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2691         (parse_cli_var_enum): Declare.
2692         * cli/cli-utils.c: Include "cli/cli-option.h".
2693         (get_ulongest): New.
2694         * cli/cli-utils.h (get_ulongest): Declare.
2695         (check_for_argument): New overloads.
2696         * maint-test-options.c: New file.
2697
2698 2019-06-13  Pedro Alves  <palves@redhat.com>
2699
2700         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2701         parse a range if "-" is at the end of the string.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * cli/cli-setshow.c (parse_auto_binary_operation)
2706         (parse_cli_boolean_value): Don't allow "o".
2707
2708 2019-06-13  Pedro Alves  <palves@redhat.com>
2709
2710         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2711         * NEWS: Mention maint test-settings KIND.
2712         * maint-test-settings.c: New file.
2713
2714 2019-06-13  Pedro Alves  <palves@redhat.com>
2715
2716         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2717         completer.
2718         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2719         "set" completers.
2720
2721 2019-06-13  Pedro Alves  <palves@redhat.com>
2722
2723         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2724         after item.
2725
2726 2019-06-13  Pedro Alves  <palves@redhat.com>
2727
2728         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2729
2730 2019-06-13  Pedro Alves <palves@redhat.com>
2731
2732         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2733         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2734         call.
2735         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2736         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2737         calls.
2738         (check_for_argument): Skip spaces after argument.
2739
2740 2019-06-13  Pedro Alves  <palves@redhat.com>
2741
2742         * thread.c (thread_apply_command): Adjust TID parsing.
2743         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2744         detected before end of string.
2745         (tid_is_in_list): Error out if LIST is invalid.
2746
2747 2019-06-13  Pedro Alves  <palves@redhat.com>
2748
2749         * completer.c (complete_line_internal_1): Rewind completion word
2750         point.
2751         (completion_tracker::advance_custom_word_point_by): Change
2752         parameter type to int.
2753         * completer.h (completion_tracker::advance_custom_word_point_by):
2754         Likewise.
2755
2756 2019-06-13  Pedro Alves  <palves@redhat.com>
2757
2758         * completer.c (advance_to_completion_word): Handle delimiters.
2759
2760 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2761
2762         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2763
2764 2019-06-11  Tom Tromey  <tom@tromey.com>
2765
2766         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2767         (xmalloc_failed): Move to alloc.c.
2768         * alloc.c: New file.
2769         * Makefile.in (COMMON_SFILES): Add alloc.c.
2770
2771 2019-06-11  Tom Tromey  <tom@tromey.com>
2772
2773         * nat/linux-waitpid.c: Don't include server.h.
2774         (linux_debug): Remove.
2775         (my_waitpid): Update.
2776
2777 2019-06-11  Tom Tromey  <tromey@adacore.com>
2778
2779         * infcall.c (_initialize_infcall): Remove trailing newline from
2780         help.
2781         * user-regs.c (_initialize_user_regs): Remove trailing newline
2782         from help.
2783         * typeprint.c (_initialize_typeprint): Remove trailing newline
2784         from help.
2785         * reverse.c (_initialize_reverse): Remove trailing newlines from
2786         help.
2787         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2788         from help.
2789         * language.c (add_set_language_command): Remove trailing newline
2790         from help.
2791         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2792         help.
2793         * disasm.c (_initialize_disasm): Remove trailing newline from
2794         help.
2795         * top.c (init_main): Remove trailing newline from help.
2796         * interps.c (_initialize_interpreter): Remove trailing newline
2797         from help.
2798         * btrace.c (_initialize_btrace): Remove trailing newlines from
2799         help.
2800         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2801         from help.
2802         * python/python.c (_initialize_python): Remove trailing newline
2803         from help.
2804         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2805         help.
2806         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2807         from help.  Reformat some text.
2808         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2809         from help.
2810         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2811         newline from help.
2812
2813 2019-06-11  Tom Tromey  <tromey@adacore.com>
2814
2815         * darwin-nat.c (darwin_decode_exception_message)
2816         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2817
2818 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * valops.c (value_slice): Check for not allocated or not
2821         associated values.
2822
2823 2019-06-10  Tom de Vries  <tdevries@suse.de>
2824
2825         PR gdb/24618
2826         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2827         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2828         invalid.
2829
2830 2019-06-10  Tom de Vries  <tdevries@suse.de>
2831
2832         PR gdb/24611
2833         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2834         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2835
2836 2019-06-10  Tom de Vries  <tdevries@suse.de>
2837
2838         PR symtab/24545
2839         * symtab.c (struct demangled_name_entry): Add language field.
2840         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2841         static minimal symbol".  Set and use language field.
2842
2843 2019-06-10  Tom Tromey  <tromey@adacore.com>
2844
2845         * ada-lang.c (_initialize_ada_language): Update help text.
2846
2847 2019-06-10  Tom Tromey  <tromey@adacore.com>
2848
2849         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2850         with a newline.
2851         * guile/guile.c (handle_boot_error): Don't end warning with a
2852         newline.
2853         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2854         warning with a newline.
2855         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2856         newline.
2857         (s12z_frame_cache): Likewise.
2858         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2859         a newline.
2860         * solib-svr4.c (disable_probes_interface): Don't end warning with
2861         a newline.
2862         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2863         newline.
2864         * python/python.c (do_finish_initialization): Don't end warning
2865         with a newline.
2866
2867 2019-06-10  Tom Tromey  <tom@tromey.com>
2868
2869         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2870         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2871         gdbpy_enter.
2872
2873 2019-06-10  Tom Tromey  <tromey@adacore.com>
2874
2875         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2876         data.
2877         (elf_new_init): Don't call stabsread_new_init.
2878         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2879         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2880         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2881
2882 2019-06-10  Tom de Vries  <tdevries@suse.de>
2883
2884         PR symtab/16264
2885         PR symtab/24517
2886         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2887
2888 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2889
2890         * source.c (find_and_open_source): Also rewrite relative file
2891         names.
2892
2893 2019-04-26  Amos Bird  <amosbird@gmail.com>
2894
2895         * annotate.c (annotate_thread_exited): Add "thread-exited"
2896         annotation.
2897
2898 2019-06-06  Tom Tromey  <tromey@adacore.com>
2899
2900         * maint.h (class scoped_command_stats): Use
2901         DISABLE_COPY_AND_ASSIGN.
2902         <print_time>: New method.
2903         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2904         print_time.
2905         (scoped_command_stats::print_time): New method.
2906
2907 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2908
2909         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2910         instructions of lengths 6 or 8 bytes.
2911
2912 2019-06-04  Pedro Alves  <palves@redhat.com>
2913
2914         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2915
2916         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2917         * breakpoint.c (condition_completer): Likewise.
2918         * cli/cli-dump.c (scan_expression): Likewise.
2919         * common/filestuff.c (mkdir_recursive): Likewise.
2920         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2921         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2922         (gdb_abspath): Likewise.
2923         * compile/compile-cplus-types.c
2924         (compile_cplus_instance::decl_name): Likewise.
2925         * completer.c (complete_explicit_location):
2926         (signal_completer, reg_or_group_completer_1): Likewise.
2927         * cp-support.c (cp_remove_params_if_any): Likewise.
2928         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2929         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2930         * infcmd.c (strip_bg_char): Likewise.
2931         * linespec.c (copy_token_string): Likewise.
2932         * mi/mi-main.c (output_cores): Likewise.
2933         * psymtab.c (psymtab_search_name):
2934         * symfile.c (test_set_ext_lang_command): Likewise.
2935         * target.c (target_fileio_read_stralloc): Likewise.
2936         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2937         * value.c (complete_internalvar): Likewise.
2938
2939 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2940
2941         Add objfile property to gdb.Type.
2942         * NEWS: Mention Python API addition.
2943         * python/py-type.c (typy_get_objfile): New method.
2944
2945 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2946
2947         * NEWS: Mention the new set|show style [title|highlight].
2948         Mention changes to "show style", "help" and "apropos".
2949
2950 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2951
2952         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2953         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2954         instead of print_help_for_command.
2955         (print_doc_of_command): New function.
2956         (help_list): Add 'apropos -v word' suggestion.
2957         (print_help_for_command): Style the command name using title style.
2958         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2959         (_initialize_cli_cmds): Describe -v in apropos_command help.
2960
2961 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2962
2963         * cli/cli-style.h (cli_style_option): Add name in constructor,
2964         add m_name class member, add constructor with intensity,
2965         add name class function.
2966         (cli_style_option::add_setshow_commands): Remove name argument.
2967         (highlight_style, title_style): New styles.
2968         * cli/cli-style.c (do_show): New function that shows a style
2969         characteristic styling the style name with itself.
2970         (set_style_name): New function.
2971         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2972         Update all callers according to the changes in cli/cli-style.h.
2973         * utils.h (fputs_highlighted): New function.
2974         * utils.c (fputs_highlighted): Likewise.
2975
2976 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2977
2978         * NEWS: Mention new pipe command and new convenience variables.
2979
2980 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2981
2982         * cli/cli-cmds.c (pipe_command): New function.
2983         (_initialize_cli_cmds): Call add_com for pipe_command.
2984         Define | as an alias for pipe.
2985         (exit_status_set_internal_vars): New function.
2986         (shell_escape): Call exit_status_set_internal_vars.
2987         cli/cli-decode.c (find_command_name_length): Recognize | as
2988         a single character command.
2989
2990 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2991
2992         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2993         top.c (execute_command_to_ui_file): New function, mostly a copy
2994         of execute_command_to_string.
2995         (execute_command_to_string): Implement by calling
2996         execute_command_to_ui_file.
2997
2998 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2999
3000         * top.h (saved_command_line): Remove declaration.
3001         * top.c (previous_saved_command_line, previous_repeat_arguments):
3002         New variables.
3003         (saved_command_line): Make static, define together with other
3004         'repeat variables'.
3005         (dont_repeat): Clear repeat_arguments.
3006         (repeat_previous, get_saved_command_line, save_command_line):
3007         New functions.
3008         (gdb_init): Initialize saved_command_line
3009         and previous_saved_command_line.
3010         * main.c (captured_main_1): Remove saved_command_line initialization.
3011         * event-top.c (handle_line_of_input): Update to use
3012         the new 'repeat' related functions instead of direct access to
3013         saved_command_line.
3014         * command.h (repeat_previous, get_saved_command_line,
3015         save_command_line): New declarations.
3016         (dont_repeat): Add comment.
3017
3018 2019-05-30  Tom Tromey  <tromey@adacore.com>
3019
3020         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3021         Fix comment.
3022         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3023
3024 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3025
3026         PR cli/24587
3027         * completer.c (complete): Initialize variable word.
3028
3029 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3030
3031         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3032         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3033         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3034         'body' is NULL to the outter 'if', protecting the '!is_define'
3035         situation as well.
3036
3037 2019-05-29  Tom Tromey  <tromey@adacore.com>
3038
3039         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3040         (dwarf_unknown): New function.
3041         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3042         (dwarf_type_encoding_name): Use dwarf_unknown.
3043
3044 2019-05-29  Tom Tromey  <tromey@adacore.com>
3045
3046         PR c++/20020:
3047         * cp-valprint.c (cp_print_value_fields): Call
3048         cp_print_static_field inside "try".
3049
3050 2019-05-29  Tom Tromey  <tromey@adacore.com>
3051
3052         * inflow.c (struct terminal_info): Add default operator=.
3053         * configure: Rebuild.
3054         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3055         -Wdeprecated-copy-dtor, -Wredundant-move.
3056
3057 2019-05-29  Tom Tromey  <tromey@adacore.com>
3058
3059         * NEWS: Add entry.
3060         * infcmd.c (print_return_value_1): Handle finish_print
3061         option.
3062         (show_print_finish): New function.
3063         (_initialize_infcmd): Add "set/show print finish" commands.
3064         * valprint.c (user_print_options): Initialize new member.
3065         * valprint.h (struct value_print_options) <finish_print>: New
3066         member.
3067
3068 2019-05-28  Tom Tromey  <tromey@adacore.com>
3069
3070         * ada-lang.c (ada_remove_Xbn_suffix)
3071         (find_old_style_renaming_symbol)
3072         (parse_old_style_renaming): Remove.
3073         (ada_find_renaming_symbol): Don't call
3074         find_old_style_renaming_symbol.
3075         (ada_is_renaming_symbol): Rename from
3076         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3077         bool.  Now static.
3078         (ada_read_var_value): Update and simplify.
3079         * ada-exp.y (write_var_or_type): Remove old code.
3080
3081 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3082
3083         * event-top.c: Remove include comment.
3084         * inflow.c (class scoped_ignore_sigttou): Move from here...
3085         * inflow.h (class scoped_ignore_sigttou): ...to here.
3086         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3087         * top.c:  Remove include comment.
3088
3089 2019-05-27  Tom Tromey  <tom@tromey.com>
3090
3091         * NEWS: Fix typo.
3092
3093 2019-05-22  Tom Tromey  <tromey@adacore.com>
3094
3095         * target.c (target_follow_exec): Constify parameter.
3096         * target-delegates.c: Rebuild.
3097         * remote.c (remote_target::follow_exec): Constify parameter.
3098         * infrun.c (follow_exec): Constify parameter.
3099         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3100         (target_follow_exec): Likewise.
3101
3102 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3103
3104         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3105         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3106
3107 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3108
3109         * NEWS: Add debugredirect and testsuite sections.
3110
3111 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3112
3113         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3114         target descriptions using exclusively floating point register name
3115         aliases.
3116
3117 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         PR gdb/18644:
3120         * f-lang.c (build_fortran_types): Handle the case where
3121         gdbarch_floatformat_for_type returns a nullptr.
3122
3123 2019-05-21  Tom de Vries  <tdevries@suse.de>
3124
3125         PR cli/24587
3126         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3127
3128 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         PR gdb/18644:
3131         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3132         16-byte floats.
3133         * i386-tdep.c (i386_floatformat_for_type): Use
3134         floatformats_ia64_quad for the 16-byte floating point component
3135         within a fortran 32-byte complex number.
3136
3137 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3140         delete default constructor.
3141         (find_partial_die): Update to return const struct.
3142         (partial_die_parent_scope): Move variable declaration into scope
3143         of its use and change its type to auto.
3144         (guess_partial_die_structure_name): Likewise.
3145         (partial_die_info::fixup): Likewise.
3146
3147 2019-05-17  Tom Tromey  <tromey@adacore.com>
3148
3149         * source.c (find_and_open_source): Remove cast.
3150
3151 2019-05-17  Tom Tromey  <tromey@adacore.com>
3152
3153         * annotate.c (annotate_source): Make "filename" const.
3154         * annotate.h (annotate_source): Use const.
3155
3156 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3157
3158         * disasm.c (set_disassembler_options): Send errors to stderr.
3159
3160 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3161
3162         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3163         (cli_interp_base::set_logging): Check debug_redirect.
3164         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3165         * cli/cli-logging.c (debug_redirect): Add static variable.
3166         (pop_output_files): Add default param.
3167         (handle_redirections): Print debug setting.
3168         (show_logging_command): Likewise.
3169         (_initialize_cli_logging): Add debugredirect command.
3170         * interps.c (current_interp_set_logging): Add debug_redirect
3171         parameter.
3172         * interps.h (set_logging): Add debug_redirect parameter.
3173         (current_interp_set_logging): Likewise.
3174         * mi/mi-common.h: Likewise.
3175         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3176
3177 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3178             Tom Tromey  <tromey@adacore.com>
3179
3180         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3181         directly.
3182         * cli/cli-interp.h (make_logging_output): Remove declaration.
3183         * cli/cli-logging.c (make_logging_output): Remove function.
3184         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3185         directly.
3186         * ui-file.c (tee_file::tee_file): Remove bools.
3187         (tee_file::~tee_file): Remove deletes.
3188         * ui-file.h (tee_file): Remove bools.
3189
3190 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3191
3192         * mi/mi-cmds.h (mi_cmd_complete): New function.
3193         * mi/mi-main.c (mi_cmd_complete): Likewise.
3194         * mi/mi-cmds.c: Define new MI command -complete.
3195         * NEWS: Mention new -complete command.
3196
3197 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3198
3199         * completer.h (complete): New function.
3200         * completer.c (complete): Likewise.
3201         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3202         function defined in completer.h.
3203
3204 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3205
3206         * MAINTAINERS (Write After Approval): Add myself.
3207
3208 2019-05-17  Tom de Vries  <tdevries@suse.de>
3209
3210         PR gdb/24094
3211         * dwarf2read.c (struct cu_partial_die_info): New struct.
3212         (find_partial_die): Return cu_partial_die_info.
3213         (partial_die_parent_scope, guess_partial_die_structure_name)
3214         (partial_die_info::fixup): Handle new return type of find_partial_die.
3215
3216 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3217
3218         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3219         "std::string", simplifying the algorithm.
3220
3221 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3222
3223         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3224         (stap_static_probe_ops::get_probes): Likewise.
3225
3226 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3227
3228         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3229         '-')" and "else if".
3230         (stap_parse_single_operand): Join checks for
3231         "gdbarch_stap_parse_special_token_p" and
3232         "gdbarch_stap_parse_special_token" in the same "if" statement.
3233         Invert check when verifying for operation on register
3234         displacement.
3235
3236 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3237
3238         * stap-probe.c (stap_get_opcode): Update comment.
3239         (stap_get_expected_argument_type): Likewise.
3240         (handle_stap_probe): Likewise.
3241
3242 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3243
3244         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3245         return type to 'bool'.  Adjust comment.  Use 'bool' when
3246         appropriate.
3247         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3248         * stap-probe.c (stap_parse_argument_1): Likewise.
3249         (stap_is_operator): Likewise.
3250         (stap_is_generic_prefix): Likewise.
3251         (stap_is_register_prefix): Likewise.
3252         (stap_is_register_indirection_prefix): Likewise.
3253         (stap_is_integer_prefix): Likewise.
3254         (stap_generic_check_suffix): Likewise.
3255         (stap_check_integer_suffix): Likewise.
3256         (stap_check_register_suffix): Likewise.
3257         (stap_check_register_indirection_suffix): Likewise.
3258         (stap_parse_register_operand): Likewise.
3259         (stap_parse_single_operand): Likewise.
3260         (stap_parse_argument_1): Likewise.
3261         (stap_probe::get_argument_count): Likewise.
3262         (stap_is_operator): Likewise.
3263
3264 2019-05-16  Tom Tromey  <tromey@adacore.com>
3265
3266         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3267         keyword to foreach.
3268
3269 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3270
3271         * linux-thread-db.c (try_thread_db_load_1): Change return type
3272         to bool.
3273         (try_thread_db_load): Likewise.
3274         (try_thread_db_load_from_pdir_1): Likewise.
3275         (try_thread_db_load_from_pdir): Likewise.
3276         (try_thread_db_load_from_sdir): Likewise.
3277         (try_thread_db_load_from_dir): Likewise.
3278         (thread_db_load_search): Likewise.
3279         (has_libpthread): Likewise.
3280         (thread_db_load): Likewise.
3281
3282 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3283
3284         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3285         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3286         NULL, and complain/return if that's the case.
3287
3288 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3289
3290         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3291         (advance, posn, abstract_read_memory): New functions.
3292         [struct mem_read_abstraction]: New struct.
3293         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3294
3295 2019-05-14  Tom Tromey  <tromey@adacore.com>
3296
3297         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3298         value is not lval_memory.
3299
3300 2019-05-14  Tom Tromey  <tromey@adacore.com>
3301
3302         * solib.c (info_sharedlibrary_command): Style the file name.
3303
3304 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3305
3306         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3307         (aarch64_vnv_type): Likewise.
3308         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3309         * common/tdesc.c: Likewise.
3310         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3311         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3312         * features/aarch64-fpu.xml: Add ieee half view.
3313         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3314         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3315         * gdbtypes.h (struct builtin_type): Likewise.
3316         (struct objfile_type): Likewise.
3317
3318 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3319
3320         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3321         typo.
3322         * location.h (string_to_event_location): Likewise.
3323
3324 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3325
3326         GDB 8.3 released.
3327
3328 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3329
3330         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3331         New variable declaration.
3332         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3333         New variable.
3334         (print_one_breakpoint): Use ui_out::test_flags and new global
3335         variable to compute use_fixed_output.
3336         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3337         Remove.
3338         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3339         (mi_multi_location_breakpoint_output_fixed): Remove.
3340         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3341         new variable.
3342         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3343         fix_multi_location_breakpoint_output flag if version >= 3.
3344         * ui-out.h (enum ui_out_flag)
3345         <fix_multi_location_breakpoint_output>: New enumerator.
3346
3347 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3348
3349         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3350
3351 2019-05-10  Tom Tromey  <tromey@adacore.com>
3352
3353         * ada-lang.c (catch_ada_completer): New function.
3354         (_initialize_ada_language): Use it.
3355
3356 2019-05-10  Tom Tromey  <tromey@adacore.com>
3357
3358         * thread.c (print_thread_info): Make "requested_threads" const.
3359         * gdbthread.h (print_thread_info): Make "requested_threads"
3360         const.
3361         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3362         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3363
3364 2019-05-08  Tom Tromey  <tom@tromey.com>
3365
3366         * gdbtypes.c (objfile_type_data): Change type.
3367         (objfile_type, _initialize_gdbtypes): Update.
3368
3369 2019-05-08  Tom Tromey  <tom@tromey.com>
3370
3371         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3372         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3373         (_initialize_dwarf2_frame): Update.
3374
3375 2019-05-08  Tom Tromey  <tom@tromey.com>
3376
3377         * objc-lang.c (objc_objfile_data): Change type.
3378         (find_methods): Update.
3379         (_initialize_objc_lang): Remove.
3380
3381 2019-05-08  Tom Tromey  <tom@tromey.com>
3382
3383         * stabsread.c (rs6000_builtin_type_data): Change type.
3384         (rs6000_builtin_type, _initialize_stabsread): Update.
3385
3386 2019-05-08  Tom Tromey  <tom@tromey.com>
3387
3388         * mips-tdep.c (mips_pdr_data): Remove.
3389         (_initialize_mips_tdep): Update.
3390
3391 2019-05-08  Tom Tromey  <tom@tromey.com>
3392
3393         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3394         (hppa_init_objfile_priv_data, read_unwind_info)
3395         (find_unwind_entry, _initialize_hppa_tdep): Update.
3396
3397 2019-05-08  Tom Tromey  <tom@tromey.com>
3398
3399         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3400         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3401         on obstack.
3402         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3403
3404 2019-05-08  Tom Tromey  <tom@tromey.com>
3405
3406         * mdebugread.c (basic_type_data): Change type.
3407         (basic_type, _initialize_mdebugread): Update.
3408
3409 2019-05-08  Tom Tromey  <tom@tromey.com>
3410
3411         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3412
3413 2019-05-08  Tom Tromey  <tom@tromey.com>
3414
3415         * nto-tdep.c (nto_inferior_data_reg): Change type.
3416         (nto_inferior_data): Update.
3417         (nto_inferior_data_cleanup, nto_new_inferior_data)
3418         (_initialize_nto_tdep): Remove.
3419         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3420
3421 2019-05-08  Tom Tromey  <tom@tromey.com>
3422
3423         * ada-lang.c (struct ada_inferior_data): Add initializers.
3424         (ada_inferior_data): Change type.
3425         (ada_inferior_data_cleanup): Remove.
3426         (get_ada_inferior_data, ada_inferior_exit)
3427         (struct ada_pspace_data): Add initializers, destructor.
3428         (ada_pspace_data_handle): Change type.
3429         (get_ada_pspace_data): Update.
3430         (ada_pspace_data_cleanup): Remove.
3431
3432 2019-05-08  Tom Tromey  <tom@tromey.com>
3433
3434         * coffread.c (struct coff_symfile_info): Add initializers.
3435         (coff_objfile_data_key): Move lower.  Change type.
3436         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3437         Update.
3438         (coff_free_info): Remove.
3439
3440 2019-05-08  Tom Tromey  <tom@tromey.com>
3441
3442         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3443         (fbsd_pspace_data_handle): Move lower.  Change type.
3444         (get_fbsd_pspace_data): Update.
3445         (fbsd_pspace_data_cleanup): Remove.
3446         (_initialize_fbsd_tdep): Update.
3447
3448 2019-05-08  Tom Tromey  <tom@tromey.com>
3449
3450         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3451         (get_ada_tasks_pspace_data): Update.
3452         (ada_tasks_pspace_data_cleanup): Remove.
3453         (_initialize_tasks): Update.
3454         (ada_tasks_inferior_data_handle): Change type.
3455         (get_ada_tasks_inferior_data): Update.
3456         (ada_tasks_inferior_data_cleanup): Remove.
3457         (struct ada_tasks_pspace_data): Add initializers.
3458
3459 2019-05-08  Tom Tromey  <tom@tromey.com>
3460
3461         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3462         * symfile-debug.c (debug_sym_get_probes): Change type.
3463         * stap-probe.c (handle_stap_probe):
3464         (stap_static_probe_ops::get_probes): Change type.
3465         * probe.h (class static_probe_ops) <get_probes>: Change type.
3466         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3467         (parse_probes_in_pspace): Update.
3468         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3469         Update.
3470         (any_static_probe_ops::get_probes): Change type.
3471         * elfread.c (elfread_data): New typedef.
3472         (probe_key): Change type.
3473         (elf_get_probes): Likewise.  Update.
3474         (probe_key_free): Remove.
3475         (_initialize_elfread): Update.
3476         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3477         Change type.
3478         (dtrace_process_dof_probe, dtrace_process_dof)
3479         (dtrace_static_probe_ops::get_probe): Change type.
3480
3481 2019-05-08  Tom Tromey  <tom@tromey.com>
3482
3483         * xcoffread.c (struct xcoff_symfile_info): Rename from
3484         coff_symfile_info.  Add initializers.
3485         (xcoff_objfile_data_key): Move lower.  Change type.
3486         (XCOFF_DATA): Rewrite.
3487         (xcoff_free_info): Remove.
3488         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3489         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3490         (xcoff_initial_scan): Update.
3491
3492 2019-05-08  Tom Tromey  <tom@tromey.com>
3493
3494         * solib-svr4.c (struct svr4_info): Add initializers and
3495         destructor.
3496         <probes_table>: Now an htab_up.
3497         (solib_svr4_pspace_data): Change type.
3498         (free_probes_table): Simplify.
3499         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3500         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3501         (probes_table_remove_objfile_probes, register_solib_event_probe)
3502         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3503         (_initialize_svr4_solib): Update.
3504
3505 2019-05-08  Tom Tromey  <tom@tromey.com>
3506
3507         * remote.c (remote_pspace_data): Change type.
3508         (remote_pspace_data_cleanup): Remove.
3509         (get_remote_exec_file, set_pspace_remote_exec_file)
3510         (_initialize_remote): Update.
3511
3512 2019-05-08  Tom Tromey  <tom@tromey.com>
3513
3514         * breakpoint.c (breakpoint_objfile_key): Change type.
3515         (get_breakpoint_objfile_data): Update.
3516         (free_breakpoint_objfile_data): Remove.
3517         (_initialize_breakpoint): Update.
3518
3519 2019-05-08  Tom Tromey  <tom@tromey.com>
3520
3521         * linux-tdep.c (struct linux_info): Add initializers.
3522         (linux_inferior_data): Move.  Change type.
3523         (invalidate_linux_cache_inf): Update.
3524         (linux_inferior_data_cleanup): Remove.
3525         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3526
3527 2019-05-08  Tom Tromey  <tom@tromey.com>
3528
3529         * auxv.c (auxv_inferior_data): Move.  Change type.
3530         (auxv_inferior_data_cleanup): Remove.
3531         (invalidate_auxv_cache_inf): Rewrite.
3532         (get_auxv_inferior_data, _initialize_auxv): Update.
3533
3534 2019-05-08  Tom Tromey  <tom@tromey.com>
3535
3536         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3537         (symfile_debug_objfile_data_key): Change type.
3538         (symfile_debug_installed, debug_qf_has_symbols)
3539         (debug_qf_find_last_source_symtab)
3540         (debug_qf_forget_cached_source_info)
3541         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3542         (debug_qf_print_stats, debug_qf_dump)
3543         (debug_qf_expand_symtabs_for_function)
3544         (debug_qf_expand_all_symtabs)
3545         (debug_qf_expand_symtabs_with_fullname)
3546         (debug_qf_map_matching_symbols)
3547         (debug_qf_expand_symtabs_matching)
3548         (debug_qf_find_pc_sect_compunit_symtab)
3549         (debug_qf_map_symbol_filenames)
3550         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3551         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3552         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3553         (debug_sym_read_linetable, debug_sym_relocate): Update.
3554         (symfile_debug_free_objfile): Remove.
3555         (install_symfile_debug_logging, _initialize_symfile_debug):
3556         Update.
3557
3558 2019-05-08  Tom Tromey  <tom@tromey.com>
3559
3560         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3561         allocate_on_obstack.
3562         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3563         (get_dwarf2_per_objfile): Update.
3564         (set_dwarf2_per_objfile): Remove.
3565         (dwarf2_has_info, dwarf2_get_section_info): Update.
3566         (dwarf2_free_objfile): Remove.
3567         (_initialize_dwarf2_read): Update.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3572         initializers.
3573         <unsupported_script_warning_printed,
3574         script_not_found_warning_printed>: Now bool.
3575         (auto_load_pspace_data): Change type.
3576         (~auto_load_pspace_info): Rename from
3577         auto_load_pspace_data_cleanup.
3578         (get_auto_load_pspace_data, init_loaded_scripts_info)
3579         (clear_section_scripts, maybe_print_unsupported_script_warning)
3580         (maybe_print_script_not_found_warning, _initialize_auto_load):
3581         Update.
3582
3583 2019-05-08  Tom Tromey  <tom@tromey.com>
3584
3585         * objfiles.c (objfile_pspace_info): Add destructor and
3586         initializers.
3587         (objfiles_pspace_data): Change type.
3588         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3589         (get_objfile_pspace_data): Update.
3590         (objfiles_bfd_data): Change type.
3591         (get_objfile_bfd_data): Update.
3592         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3593
3594 2019-05-08  Tom Tromey  <tom@tromey.com>
3595
3596         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3597         Change type.
3598         (get_catch_syscall_inferior_data): Update.
3599         (catch_syscall_inferior_data_cleanup): Remove.
3600         (_initialize_break_catch_syscall): Update.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * inflow.c (struct terminal_info): Add destructor and
3605         initializers.
3606         (inflow_inferior_data): Change type.
3607         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3608         (get_inflow_inferior_data, inflow_inferior_exit)
3609         (swap_terminal_info, _initialize_inflow): Update.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * target-dcache.c (target_dcache_cleanup): Remove.
3614         (target_dcache_aspace_key): Change type.
3615         (target_dcache_init_p, target_dcache_invalidate)
3616         (target_dcache_get, target_dcache_get_or_init)
3617         (_initialize_target_dcache): Update.
3618         * dcache.h (struct dcache_deleter): New.
3619
3620 2019-05-08  Tom Tromey  <tom@tromey.com>
3621
3622         * symtab.c (struct symbol_cache): Add destructor and
3623         initializers.
3624         (symbol_cache_key): Move.  Change type.
3625         (make_symbol_cache, free_symbol_cache): Remove.
3626         (get_symbol_cache): Update.
3627         (symbol_cache_cleanup): Remove.
3628         (ALL_PSPACES, symbol_cache_flush)
3629         (maintenance_print_symbol_cache)
3630         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3631         Update.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * symtab.c (struct main_info): Add destructor and initializers.
3636         (main_progspace_key): Move.  Change type.
3637         (get_main_info): Update.
3638         (main_info_cleanup): Remove.
3639         (_initialize_symtab): Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * registry.h (DECLARE_REGISTRY): Define the _key class.
3644
3645 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * NEWS: Merge two 'New commands' sections.
3648
3649 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3650
3651         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3652         parameter and use Ada language definition instead.
3653         (ada_val_print_ptr): Remove unused language parameter.
3654         (ada_val_print_num): Remove language parameter and use Ada language
3655         definition instead.
3656         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3657         parameter.
3658         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3659         parameter and use Ada language definition instead.
3660         (ada_val_print_1): Update all ada_val_print_xxx calls.
3661         Remove language parameter.
3662         (ada_val_print): Update ada_val_print_1 call.
3663
3664 2019-05-08  Tom Tromey  <tromey@adacore.com>
3665
3666         * remote.c (remote_hw_watchpoint_limit)
3667         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3668         Now static.
3669
3670 2019-05-08  Tom Tromey  <tromey@adacore.com>
3671
3672         * maint.c (_initialize_maint_cmds): Move initialization code to
3673         remote.c.
3674         (watchdog, show_watchdog): Move to remote.c.
3675         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3676         "watchdog" static.
3677         (_initialize_remote): Move initialization code from maint.c.
3678         * defs.h (watchdog): Don't declare.
3679
3680 2019-05-08  Tom Tromey  <tromey@adacore.com>
3681
3682         * tui/tui-interp.c: Include main.h.
3683         * interps.c: Include main.h.
3684         * main.h (interpreter_p): Declare.
3685         * defs.h (interpreter_p): Don't declare.
3686
3687 2019-05-08  Tom Tromey  <tromey@adacore.com>
3688
3689         * dwarf2loc.c: Include dwarf2read.h.
3690         * defs.h (read_unsigned_leb128): Don't declare.
3691         * dwarf2read.h (read_unsigned_leb128): Declare.
3692
3693 2019-05-08  Tom Tromey  <tromey@adacore.com>
3694
3695         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3696         method.
3697
3698 2019-05-08  Tom Tromey  <tromey@adacore.com>
3699
3700         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3701         when no wrap column is set.
3702
3703 2019-05-08  Tom Tromey  <tromey@adacore.com>
3704
3705         * c-lang.c (c_get_string): Handle non-C-style arrays.
3706
3707 2019-05-08  Tom Tromey  <tromey@adacore.com>
3708
3709         * typeprint.c (print_offset_data::update): Print the bit offset,
3710         not the number of bits remaining.
3711
3712 2019-05-08  Tom Tromey  <tromey@adacore.com>
3713
3714         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3715         padding at end of comment.
3716
3717 2019-05-08  Tom Tromey  <tromey@adacore.com>
3718
3719         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3720         Compare main types.
3721
3722 2019-05-06  Tom Tromey  <tom@tromey.com>
3723
3724         * common/scoped_mmap.c: Include common-defs.h.
3725         * common/scoped_mmap.h: Don't include config.h.
3726
3727 2019-05-04  Tom Tromey  <tom@tromey.com>
3728
3729         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3730         (struct aarch64_call_info): Add initializers.
3731         <si>: Now a std::vector.
3732         (pass_on_stack, aarch64_push_dummy_call): Update.
3733
3734 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3735             Tom Tromey  <tom@tromey.com>
3736
3737         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3738         (ppc_threads): Now a std::vector.  Now static.
3739         (hwdebug_find_thread_points_by_tid)
3740         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3741         Update.
3742
3743 2019-05-04  Tom Tromey  <tom@tromey.com>
3744
3745         * arc-tdep.c (arc_tdesc_init): Return bool.
3746
3747 2019-05-04  Tom Tromey  <tom@tromey.com>
3748
3749         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3750         Use gdb_assert_not_reached.
3751
3752 2019-05-04  Tom Tromey  <tom@tromey.com>
3753
3754         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3755         "false".
3756
3757 2019-05-04  Tom Tromey  <tom@tromey.com>
3758
3759         * arc-tdep.c (arc_tdesc_init): Use bool.
3760
3761 2019-05-04  Tom Tromey  <tom@tromey.com>
3762
3763         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3764
3765 2019-05-04  Tom Tromey  <tom@tromey.com>
3766
3767         * cli/cli-cmds.c (valid_command_p): Return bool.
3768
3769 2019-05-04  Tom Tromey  <tom@tromey.com>
3770
3771         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3772         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3773
3774 2019-05-04  Raul Tambre  <raul@tambre.ee>
3775
3776         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3777         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3778         operator for comparison.
3779
3780 2019-05-04  Tom Tromey  <tom@tromey.com>
3781
3782         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3783         (lookup_partial_symbol, print_partial_symbols)
3784         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3785         (psymbol_compare): Update.
3786         (add_psymbol_to_bcache): Clear the entire psymbol.
3787         (maintenance_check_psymtabs): Update.
3788         * psympriv.h (struct partial_symbol): Don't derive from
3789         general_symbol_info.
3790         <obj_section, unrelocated_address, address,
3791         set_unrelocated_address>: Update.
3792         <ginfo>: New member.
3793         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3794         (debug_names::write_psymbols): Update.
3795
3796 2019-05-04  Tom de Vries  <tdevries@suse.de>
3797
3798         * contrib/cc-with-tweaks.sh: Support -n arg.
3799
3800 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3801
3802         * corelow.c (core_target::detach): Ensure frame cache and
3803         register caches are cleared.
3804         inferior.c (exit_inferior_1): Likewise.
3805
3806 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3807             Tom Tromey  <tom@tromey.com>
3808
3809         * dictionary.c (collate_pending_symbols_by_language): Remove
3810         "struct" from foreach.
3811         * symtab.c (lookup_global_symbol_from_objfile)
3812         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3813         foreach.
3814         * ser-tcp.c (net_open): Remove "struct" from foreach.
3815         * objfiles.c (objfile_relocate, objfile_rebase)
3816         (objfile_has_symbols): Remove "struct" from foreach.
3817         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3818         from foreach.
3819         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3820         foreach.
3821         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3822         "struct" from foreach.
3823         * ada-lang.c (create_excep_cond_exprs)
3824         (ada_exception_catchpoint_cond_string): Remove "struct" from
3825         foreach.
3826
3827 2019-05-03  Tom Tromey  <tromey@adacore.com>
3828
3829         * ada-exp.y (convert_char_literal): Check suffix of each
3830         enumerator.
3831
3832 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3833
3834         PR ada/21406:
3835         * ada-exp.y (yywrap): Don't define.
3836         * ada-lex.l (%option): Add noyywrap
3837         (yywrap): Remove.
3838
3839 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3840
3841         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3842         _WIN32_WINNT to the XP level, unless already defined to a higher
3843         level.
3844
3845         * unittests/parse-connection-spec-selftests.c:
3846         * ser-tcp.c:
3847         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3848         override.
3849
3850         * symfile.c (find_separate_debug_file): Remove colon from the
3851         drive spec of DOS/Windows file names of the target, so that the
3852         file name produced from DEBUGDIR and the target's directory will
3853         be valid on DOS/Windows systems.
3854
3855 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * rust-lang.c (val_print_struct): Handle printing structures
3858         containing strings.
3859
3860 2019-05-02  Tom Tromey  <tromey@adacore.com>
3861
3862         * valarith.c (_initialize_valarith): Remove.
3863
3864 2019-05-01  Tom Tromey  <tromey@adacore.com>
3865
3866         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3867         bitfields.
3868
3869 2019-05-01  Tom Tromey  <tromey@adacore.com>
3870
3871         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3872         for big-endian copies.
3873
3874 2019-04-30  Ali Tamur  <tamur@google.com>
3875         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3876         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3877         (read_3_bytes): New function.
3878
3879 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3880
3881         * windows-nat.c (main_thread_id): Delete.
3882         (handle_output_debug_string): Replace main_thread_id by
3883         current_event.dwThreadId.
3884         (fake_create_process): Likewise.
3885         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3886         Do not set main_thread_id.
3887         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3888         current_event.dwThreadId.
3889         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3890
3891 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3892
3893         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3894         Use current_event.dwThreadId instead of main_thread_id.
3895
3896 2019-04-30  Tom Tromey  <tromey@adacore.com>
3897
3898         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3899         (create_excep_cond_exprs): Iterate over program spaces.
3900         (ada_exception_catchpoint_cond_string): Examine all minimal
3901         symbols for exception types.
3902
3903 2019-04-30  Tom Tromey  <tromey@adacore.com>
3904
3905         PR c++/24470:
3906         * dwarf2read.c (process_structure_scope): Handle case where type
3907         has template parameters but no symbol was created.
3908
3909 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3910             Chris January  <chris.january@arm.com>
3911
3912         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3913         qualifier.
3914         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3915
3916 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * f-typeprint.c (f_print_type): Update rules for printing
3919         whitespace.
3920         (f_type_print_varspec_suffix): Likewise.
3921
3922 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3923             Chris January  <chris.january@arm.com>
3924
3925         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3926         function arguments.
3927
3928 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * f-lang.c (build_fortran_types): Change name of void type to
3931         lower case.
3932         * f-typeprint.c (f_type_print_base): Print the name of the void
3933         type, rather than a fixed string.
3934         * f-valprint.c (f_decorations): Use lower case void string.
3935
3936 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3937             Chris January  <chris.january@arm.com>
3938
3939         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3940         types for Fortran.
3941
3942 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3943             Chris January  <chris.january@arm.com>
3944             David Lecomber  <david.lecomber@arm.com>
3945
3946         * f-exp.y (BINOP_INTRINSIC): New token.
3947         (exp): New parser rule handling BINOP_INTRINSIC.
3948         (f77_keywords): Add new builtin procedures.
3949         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3950         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3951         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3952         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3953         (print_unop_subexp_f): New function.
3954         (print_binop_subexp_f): New function.
3955         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3956         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3957         (dump_subexp_body_f): Likewise.
3958         (operator_check_f): Likewise.
3959         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3960         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3961
3962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3965         UNOP_KIND.
3966         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3967         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3968         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3969         (operator_length_f): New fuction.
3970         (print_subexp_f): New function.
3971         (op_name_f): New function.
3972         (dump_subexp_body_f): New function.
3973         (operator_check_f): New function.
3974         (exp_descriptor_f): Replace standard expression handling functions
3975         with new functions.
3976         * gdb/fortran-operator.def: New file.
3977         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3978         * gdb/std-operator.def: Remove UNOP_KIND.
3979
3980 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * std-operator.def: Remove unbalanced, stray double quote
3983         character.
3984
3985 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3986             Chris January  <chris.january@arm.com>
3987             Daniel Everett  <daniel.everett@arm.com>
3988             Nick Forrington  <nick.forrington@arm.com>
3989             Richard Bunt  <richard.bunt@arm.com>
3990
3991         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3992         of depth when printing anonymous structs or unions.
3993         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3994         Don't print either the top-level value, or the children if the
3995         max-depth is exceeded.
3996         (ppscm_print_children): When printing the key of a map, allow one
3997         extra level of depth.
3998         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3999         print either the top-level value, or the children if the max-depth
4000         is exceeded.
4001         (print_children): When printing the key of a map, allow one extra
4002         level of depth.
4003         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4004         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4005         (user_print_options): Initialise max_depth field.
4006         (val_print_scalar_or_string_type_p): New function.
4007         (val_print): Check to see if the max depth has been reached.
4008         (val_print_check_max_depth): Define new function.
4009         (show_print_max_depth): New function.
4010         (_initialize_valprint): Add 'print max-depth' option.
4011         * valprint.h (struct value_print_options) <max_depth>: New field.
4012         (val_print_check_max_depth): Declare new function.
4013         * NEWS: Document new feature.
4014
4015 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * ada-lang.c (ada_language_defn): Initialise new field.
4018         * c-lang.c (c_is_string_type_p): New function.
4019         (c_language_defn): Initialise new field.
4020         (cplus_language_defn): Initialise new field.
4021         (asm_language_defn): Initialise new field.
4022         (minimal_language_defn): Initialise new field.
4023         * c-lang.h (c_is_string_type_p): Declare new function.
4024         * d-lang.c (d_language_defn): Initialise new field.
4025         * f-lang.c (f_is_string_type_p): New function.
4026         (f_language_defn): Initialise new field.
4027         * go-lang.c (go_is_string_type_p): New function.
4028         (go_language_defn): Initialise new field.
4029         * language.c (default_is_string_type_p): New function.
4030         (unknown_language_defn): Initialise new field.
4031         (auto_language_defn): Initialise new field.
4032         * language.h (struct language_defn) <la_is_string_type_p>: New
4033         member variable.
4034         (default_is_string_type_p): Declare new function.
4035         * m2-lang.c (m2_language_defn): Initialise new field.
4036         * objc-lang.c (objc_language_defn): Initialise new field.
4037         * opencl-lang.c (opencl_language_defn): Initialise new field.
4038         * p-lang.c (pascal_is_string_type_p): New function.
4039         (pascal_language_defn): Initialise new field.
4040         * rust-lang.c (rust_is_string_type_p): New function.
4041         (rust_language_defn): Initialise new field.
4042
4043 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4046         New field.
4047         * ada-lang.c (ada_language_defn): Initialise new field.
4048         * c-lang.c (c_language_defn): Likewise.
4049         (cplus_language_defn): Likewise.
4050         (asm_language_defn): Likewise.
4051         (minimal_language_defn): Likewise.
4052         * d-lang.c (d_language_defn): Likewise.
4053         * f-lang.c (f_language_defn): Likewise.
4054         * go-lang.c (go_language_defn): Likewise.
4055         * language.c (unknown_language_defn): Likewise.
4056         (auto_language_defn): Likewise.
4057         * m2-lang.c (m2_language_defn): Likewise.
4058         * objc-lang.c (objc_language_defn): Likewise.
4059         * opencl-lang.c (opencl_language_defn): Likewise.
4060         * p-lang.c (pascal_language_defn): Likewise.
4061         * rust-lang.c (rust_language_defn): Likewise.
4062
4063 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * ada-lang.c (ada_is_character_type): Change return type to bool.
4066         (ada_is_string_type): Likewise.
4067         * ada-lang.h (ada_is_character_type): Update declaration
4068         (ada_is_string_type): Likewise.
4069
4070 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4071
4072         Support style in 'frame|thread apply'
4073
4074         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4075         * record.c (record_start, record_stop): Update callers of
4076         execute_command_to_string with false.
4077         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4078         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4079         methods.
4080         (class string_file): New constructor with term_out parameter.
4081         Override methods term_out and can_emit_style_escape.  New member
4082         term_out.
4083         (class stdio_file): Override can_emit_style_escape.
4084         (class tee_file): Override term_out and can_emit_style_escape.
4085         * utils.h (can_emit_style_escape): Remove.
4086         * utils.c (can_emit_style_escape): Likewise.
4087         Update all callers of can_emit_style_escape (SOMESTREAM) to
4088         SOMESTREAM->can_emit_style_escape.
4089         * source-cache.c (source_cache::get_source_lines): Likewise.
4090         * stack.c (frame_apply_command_count): Call execute_command_to_string
4091         passing the term_out characteristic of the current gdb_stdout.
4092         * thread.c (thr_try_catch_cmd): Likewise.
4093         * top.c (execute_command_to_string): pass term_out parameter
4094         to construct the string_file for the command output.
4095         * ui-file.c (term_cli_styling): New function (most code moved
4096         from utils.c can_emit_style_escape).
4097         (string_file::string_file, string_file::can_emit_style_escape,
4098         stdio_file::can_emit_style_escape, tee_file::term_out,
4099         tee_file::can_emit_style_escape): New functions.
4100
4101 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4102
4103         * NEWS: Mention the new set|show may-call-functions.
4104         * infcall.c (may_call_functions_p): New variable.
4105         (show_may_call_functions_p): New function.
4106         (call_function_by_hand_dummy): Throws an error if not
4107         may-call-functions.
4108         (_initialize_infcall): Call add_setshow_boolean_cmd for
4109         may-call-functions.
4110
4111 2019-04-25  Keith Seitz  <keiths@redhat.com>
4112
4113         PR c++/24367
4114         * cp-support.c (inspect_type): Don't attempt substitutions
4115         of symbol with the same name.
4116
4117 2019-04-25  Tom Tromey  <tromey@adacore.com>
4118
4119         PR gdb/24475:
4120         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4121         static.
4122
4123 2019-04-25  Tom Tromey  <tromey@adacore.com>
4124
4125         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4126         rvalue reference.
4127         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4128         (gdb_xml_parser::parse): Use std::move.
4129         * python/python-internal.h (gdbpy_convert_exception): Take a const
4130         reference.
4131         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4132         std::move.
4133         * python/py-utils.c (gdbpy_convert_exception): Take a const
4134         reference.
4135         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4136         Use std::move.
4137         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4138         Use std::move.
4139         * mi/mi-main.c (mi_print_exception): Take a const reference.
4140         * main.c (handle_command_errors): Take a const reference.
4141         * linespec.c (parse_linespec): Use std::move.
4142         * infcall.c (run_inferior_call): Use std::move.
4143         (call_function_by_hand_dummy): Use std::move.
4144         * exec.c (try_open_exec_file): Use std::move.
4145         * exceptions.h (exception_print, exception_fprintf)
4146         (exception_print_same): Update.
4147         * exceptions.c (print_exception, exception_print)
4148         (exception_fprintf, exception_print_same): Change parameters to
4149         const reference.
4150         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4151         * common/new-op.c: Use std::move.
4152         * common/common-exceptions.h (struct gdb_exception): Add move
4153         constructor.
4154         (struct gdb_exception_error, struct gdb_exception_quit, struct
4155         gdb_quit_bad_alloc): Change constructor to move constructor.
4156         (throw_exception): Change parameter to rvalue reference.
4157         * common/common-exceptions.c (throw_exception): Take rvalue
4158         reference.
4159         * cli/cli-interp.c (safe_execute_command): Use std::move.
4160         * breakpoint.c (insert_bp_location, location_to_sals): Use
4161         std::move.
4162
4163 2019-04-25  Tom Tromey  <tromey@adacore.com>
4164
4165         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4166         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4167         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4168         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4169         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4170         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4171         guile/scm-value.c: Use unpack.
4172         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4173         gdbscm_gdb_exception.
4174         (gdbscm_throw_gdb_exception): Likewise.
4175         (struct gdbscm_gdb_exception): New.
4176         (unpack): New function.
4177         (gdbscm_wrap): Use unpack.
4178
4179 2019-04-25  Tom Tromey  <tromey@adacore.com>
4180
4181         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4182         (gdb_rl_callback_handler): Use std::move.
4183         * common/common-exceptions.h (struct gdb_exception): Add move
4184         assignment operator.
4185         (throw_exception_sjlj): Change "exception" to const reference.
4186         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4187         (throw_exception_sjlj): Change "exception" to const reference.
4188
4189 2019-04-25  Tom Tromey  <tromey@adacore.com>
4190
4191         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4192         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4193         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4194         Update.
4195         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4196         Update.
4197         * mi/mi-interp.c (mi_interp::exec): Update.
4198         * linespec.c (parse_linespec): Update.
4199         * infcall.c (run_inferior_call): Update.
4200         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4201         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4202         (gdbscm_lookup_global_symbol): Update.
4203         * guile/scm-param.c (gdbscm_parameter_value): Update.
4204         * guile/scm-frame.c (gdbscm_frame_read_register)
4205         (gdbscm_frame_read_var): Update.
4206         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4207         * exec.c (try_open_exec_file): Update.
4208         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4209         (gdb_rl_callback_handler): Update.
4210         * common/common-exceptions.h (exception_none): Don't declare.
4211         * common/common-exceptions.c (exception_none): Don't define.
4212         (struct catcher) <exception>: Update.
4213         * cli/cli-interp.c (safe_execute_command): Update.
4214         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4215
4216 2019-04-25  Ali Tamur  <tamur@google.com>
4217
4218         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4219         (read_attribute_value): Likewise.
4220         (dwarf2_read_addr_index): Update comment.
4221         (read_str_index): Add DW_FORM_strx.
4222         (dwarf2_string_attr): Likewise.
4223         (dwarf2_const_value_attr): Likewise.
4224         (dump_die_shallow): Likewise.
4225         (dwarf2_fetch_constant_bytes): Likewise.
4226         (skip_form_bytes): Likewise.
4227         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4228
4229 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4230
4231         PR corefiles/11608
4232         PR corefiles/18187
4233         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4234         OFFSET.  Verify if current mapping contains an ELF header.
4235         (linux_find_memory_regions_full): Adjust call to
4236         dump_mapping_p.
4237
4238 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4239             Kang Li <kanglictf@gmail.com>
4240
4241         PR gdb/21600
4242
4243         * dwarf2-frame.c (read_initial_length): Be consistent about using
4244         unsigned representation of length.
4245         (decode_frame_entry_1): Likewise.  Check for wraparound of
4246         end pointer as well as buffer overflow.
4247
4248 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4249
4250         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4251         "vq".
4252
4253 2019-04-24  Tom Tromey  <tromey@adacore.com>
4254
4255         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * s12z-tdep.c (s12z_unwind_pc): Delete.
4260         (s12z_unwind_sp): Delete.
4261         (s12z_gdbarch_init): Don't register deleted functions with
4262         gdbarch.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * rl78-tdep.c (rl78_unwind_sp): Delete.
4267         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4268
4269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4272         (xstormy16_unwind_pc): Delete.
4273         (xstormy16_dummy_id): Delete.
4274         (xstormy16_gdbarch_init): Don't register deleted functions with
4275         gdbarch.
4276
4277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * vax-tdep.c (vax_unwind_pc): Delete.
4280         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4281
4282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * v850-tdep.c (v850_unwind_sp): Delete.
4285         (v850_unwind_pc): Delete.
4286         (v850_dummy_id): Delete.
4287         (v850_gdbarch_init): Don't register deleted functions with
4288         gdbarch.
4289
4290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4293         (tilegx_unwind_pc): Delete.
4294         (tilegx_unwind_dummy_id): Delete.
4295         (tilegx_gdbarch_init): Don't register deleted functions with
4296         gdbarch.
4297
4298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4301         (tic6x_dummy_id): Delete.
4302         (tic6x_gdbarch_init): Don't register deleted functions with
4303         gdbarch.
4304
4305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * sparc-tdep.c (sparc_unwind_pc): Delete.
4308         (sparc32_gdbarch_init): Don't register deleted function with
4309         gdbarch.
4310
4311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * sh-tdep.c (sh_unwind_sp): Delete.
4314         (sh_unwind_pc): Delete.
4315         (sh_dummy_id): Delete.
4316         (sh_gdbarch_init): Don't register deleted functions with
4317         gdbarch.
4318
4319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4320
4321         * score-tdep.c (score_unwind_sp): Delete.
4322         (score_unwind_pc): Delete.
4323         (score_dummy_id): Delete.
4324         (score_gdbarch_init): Don't register deleted functions with
4325         gdbarch.
4326
4327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * rx-tdep.c (rx_unwind_pc): Delete.
4330         (rx_unwind_sp): Delete.
4331         (rx_dummy_id): Delete.
4332         (rx_gdbarch_init): Don't register deleted functions with
4333         gdbarch.  Update comment.
4334
4335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4338         (rs6000_dummy_id): Delete.
4339         (rs6000_gdbarch_init): Don't register deleted functions with
4340         gdbarch.
4341
4342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * or1k-tdep.c (or1k_dummy_id): Delete.
4345         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * nios2-tdep.c (nios2_dummy_id): Delete.
4350         (nios2_unwind_sp): Delete.
4351         (nios2_gdbarch_init): Don't register deleted functions with
4352         gdbarch.
4353
4354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * nds32-tdep.c (nds32_dummy_id): Delete.
4357         (nds32_unwind_pc): Delete.
4358         (nds32_unwind_sp): Delete.
4359         (nds32_gdbarch_init): Don't register deleted functions with
4360         gdbarch.
4361
4362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * msp430-tdep.c (msp430_unwind_pc): Delete.
4365         (msp430_unwind_sp): Delete.
4366         (msp430_dummy_id): Delete.
4367         (msp430_gdbarch_init): Don't register deleted functions with
4368         gdbarch.
4369
4370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * moxie-tdep.c (moxie_unwind_sp): Delete.
4373         (moxie_unwind_pc): Delete.
4374         (moxie_dummy_id): Delete.
4375         (moxie_gdbarch_init): Don't register deleted functions with
4376         gdbarch.
4377
4378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4381         (mn10300_unwind_pc): Delete.
4382         (mn10300_unwind_sp): Delete.
4383         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4384         mn10300_unwind_sp.
4385         (mn10300_frame_unwind_init): Don't register deleted functions with
4386         gdbarch.
4387
4388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * mep-tdep.c (mep_unwind_pc): Delete.
4391         (mep_unwind_sp): Delete.
4392         (mep_dummy_id): Delete.
4393         (mep_gdbarch_init): Don't register deleted functions with
4394         gdbarch.
4395
4396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4397
4398         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4399         (m68hc11_unwind_sp): Delete.
4400         (m68hc11_gdbarch_init): Don't register deleted functions with
4401         gdbarch.
4402
4403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * m32r-tdep.c (m32r_unwind_sp): Delete.
4406         (m32r_unwind_pc): Delete.
4407         (m32r_dummy_id): Delete.
4408         (m32r_gdbarch_init): Don't register deleted functions with
4409         gdbarch.
4410
4411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * m32c-tdep.c (m32c_unwind_pc): Delete.
4414         (m32c_unwind_sp): Delete.
4415         (m32c_dummy_id): Delete.
4416         (m32c_gdbarch_init): Don't register deleted functions with
4417         gdbarch.
4418
4419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4422         (lm32_unwind_pc): Delete.
4423         (lm32_dummy_id): Delete.
4424         (lm32_gdbarch_init): Don't register deleted functions with
4425         gdbarch.
4426
4427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4430         (iq2000_unwind_pc): Delete.
4431         (iq2000_dummy_id): Delete.
4432         (iq2000_gdbarch_init): Don't register deleted functions with
4433         gdbarch.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * nds32-tdep.c (nds32_type_align): Delete.
4438         (nds32_push_dummy_call): Use type_align instead.
4439
4440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4441
4442         * arm-tdep.c (arm_type_align): Only handle vector override case.
4443         (arm_push_dummy_call): Use type_align.
4444         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4445
4446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4449         case.
4450         (pass_on_stack): Use type_align.
4451         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4452         function.
4453
4454 2019-04-23  Tom Tromey  <tromey@adacore.com>
4455
4456         * dwarf2read.c (line_header::file_name_at): Remove unused
4457         overload.
4458
4459 2019-04-23  Tom de Vries  <tdevries@suse.de>
4460
4461         PR gdb/24438
4462         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4463         invocation.
4464
4465
4466 2019-03-27  Ali Tamur  <tamur@google.com>
4467
4468         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4469         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4470         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4471         (dwarf_expr_context::get_addr_index): Likewise
4472         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4473         (symbol_needs_eval_context::get_addr_index): Likewise
4474         (disassemble_dwarf_expression): Add DW_OP_addrx
4475         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4476         (read_cutu_die_from_dwo): Update comment
4477         (skip_one_die): Add DW_FORM_addrx
4478         (read_attribute_value): Likewise
4479         (var_decode_location): Add DW_OP_addrx
4480         (dwarf2_const_value_attr): Add DW_FORM_addrx
4481         (dump_die_shallow): Likewise
4482         (dwarf2_fetch_constant_bytes): Likewise
4483         (decode_locdesc): Add DW_OP_addrx
4484         (skip_form_bytes): Add DW_FORM_addrx
4485
4486 2019-04-22  Ali Tamur  <tamur@google.com>
4487
4488         * MAINTAINERS (Write After Approval): Add self.
4489
4490 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4491
4492         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4493         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4494         (open_symbol_file_object): Likewise.
4495         (svr4_default_sos): Add info parameter.
4496         (svr4_read_so_list): Likewise.
4497         (svr4_current_sos_direct): Adjust functions calls to pass down
4498         info.
4499         (svr4_current_sos_1): Add info parameter.
4500         (svr4_current_sos): Call get_svr4_info, pass info down to
4501         svr4_current_sos_1.
4502         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4503         get_svr4_info.
4504         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4505         get_svr4_info.
4506         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4507         to get_svr4_info.
4508         (probes_table_remove_objfile_probes): Likewise.
4509         (register_solib_event_probe): Add info parameter.
4510         (solist_update_incremental): Pass info parameter down to
4511         svr4_read_so_list.
4512         (disable_probes_interface): Add info parameter.
4513         (svr4_handle_solib_event): Pass current_program_space to
4514         get_svr4_info.  Adjust disable_probes_interface cleanup.
4515         (svr4_create_probe_breakpoints): Add info parameter, pass it
4516         down to register_solib_event_probe.
4517         (svr4_create_solib_event_breakpoints): Add info parameter,
4518         pass it down to svr4_create_probe_breakpoints.
4519         (enable_break): Pass info down to
4520         svr4_create_solib_event_breakpoints.
4521         (svr4_solib_create_inferior_hook): Pass current_program_space to
4522         get_svr4_info.
4523         (svr4_clear_solib): Likewise.
4524
4525 2019-04-22  Pedro Alves  <palves@redhat.com>
4526
4527         * solib-svr4.c (svr4_free_objfile_observer): New.
4528         (probe_and_action::objfile): New field.
4529         (probes_table_htab_remove_objfile_probes)
4530         (probes_table_remove_objfile_probes): New functions.
4531         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4532         in the new probe_and_action.  Don't store the probe in 'lookup'.
4533         (svr4_create_probe_breakpoints): Pass objfile to
4534         register_solib_event_probe.
4535         (_initialize_svr4_solib): Register a free_objfile observer.
4536
4537 2019-04-19  Tom Tromey  <tom@tromey.com>
4538
4539         * common/queue.h: Remove.
4540
4541 2019-04-19  Tom Tromey  <tom@tromey.com>
4542
4543         * event-loop.c: Don't include "common/queue.h".
4544
4545 2019-04-19  Tom Tromey  <tom@tromey.com>
4546
4547         * remote.c (remote_target): Use delete.
4548         * remote-notif.h: Include <list>, not "common/queue.h".
4549         (notif_client_p): Remove typedef.
4550         (remote_notif_state): Add constructor, destructor, initializer.
4551         <notif_queue>: Now a std::list.
4552         (remote_notif_state_xfree): Don't declare.
4553         * remote-notif.c (remote_notif_process, handle_notification)
4554         (remote_notif_state_allocate): Update.
4555         (~remote_notif_state): Rename from remote_notif_state_xfree.
4556
4557 2019-04-19  Tom Tromey  <tom@tromey.com>
4558
4559         * symfile.c (reread_symbols): Update.
4560         * objfiles.c (objfile_register_static_link)
4561         (objfile_lookup_static_link): Update
4562         (~objfile) Don't delete static_links.
4563         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4564
4565 2019-04-19  Tom Tromey  <tom@tromey.com>
4566
4567         * type-stack.h (struct type_stack) <insert>: Constify string.
4568         * type-stack.c (type_stack::insert): Constify string.
4569         * gdbtypes.h (lookup_template_type): Update.
4570         (address_space_name_to_int): Update.
4571         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4572         const.
4573         (lookup_template_type): Make name const.
4574         * c-exp.y: Update rules.
4575         (lex_one_token, classify_name, classify_inner_name)
4576         (c_print_token): Update.
4577         * p-exp.y: Update rules.
4578         (yylex): Update.
4579         * f-exp.y: Update rules.
4580         (yylex): Update.
4581         * d-exp.y: Update rules.
4582         (lex_one_token, classify_name, classify_inner_name): Update.
4583         * parse.c (write_dollar_variable, copy_name): Return std::string.
4584         * parser-defs.h (copy_name): Change return type.
4585         * m2-exp.y: Update rules.
4586         (yylex): Update.
4587         * go-exp.y (lex_one_token): Update.
4588         Update rules.
4589         (classify_unsafe_function, classify_packaged_name)
4590         (classify_name, yylex): Update.
4591
4592 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4593
4594         * configure.ac: add --enable-source-highlight switch.
4595         * configure: Regenerate.
4596         * top.c (print_gdb_version): plumb --enable-source-highlight
4597         status to "show configuration".
4598
4599 2019-04-19  Tom Tromey  <tromey@adacore.com>
4600
4601         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4602         Check ADA_TYPE_P.
4603         (empty_record, ada_template_to_fixed_record_type_1)
4604         (template_to_static_fixed_type)
4605         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4606         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4607         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4608         macros.
4609
4610 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4611
4612         PR symtab/24423:
4613         * source.c (print_source_lines_base): Advance "iter" when a
4614         control character is seen.
4615
4616 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4617
4618         * inferior.h (struct infcall_suspend_state_deleter):
4619         Catch exception in destructor to avoid crash.
4620
4621 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4622
4623         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4624         close to the add_com "shell".
4625
4626 2019-04-18  Tom Tromey  <tromey@adacore.com>
4627
4628         * process-stratum-target.h (class process_stratum_target)
4629         <stratum>: Add "final".
4630
4631 2019-04-17  Tom Tromey  <tromey@adacore.com>
4632
4633         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4634         against nullptr before use.
4635
4636 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4637
4638         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4639
4640 2019-04-17  Jim Wilson  <jimw@sifive.com>
4641             Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4644         code read might fail, assume 4-byte breakpoint in that case.
4645
4646 2019-04-15  Leszek Swirski  <leszeks@google.com>
4647
4648         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4649         rather than a hand-rolled POD check when checking for forced MEMORY
4650         classification.
4651
4652 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4653
4654         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4655         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4656         function.
4657         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4658         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4659         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4660         declaration.
4661
4662 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4663
4664         * aarch64-linux-nat.c
4665         (aarch64_linux_nat_target::thread_architecture): Add override.
4666         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4667         each VQ.
4668
4669 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4670
4671         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4672
4673 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4676         target types of size 96-bits, add some additional comments, and
4677         check that the builtin type we found was the correct size.
4678
4679 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4680
4681         * utils.c (prompt_for_continue): Don't restore the styling at the
4682         end, as applied_style has the wrong value.  This fixes styling in
4683         long lists of file names that are interrupted by the "Continue?"
4684         prompt.
4685
4686 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4689         * c-lang.c (c_language_defn): Likewise.
4690         (cplus_language_defn): Likewise.
4691         (asm_language_defn): Likewise.
4692         (minimal_language_defn): Likewise.
4693         * d-lang.c (d_language_defn): Likewise.
4694         * f-lang.c (f_language_defn): Likewise.
4695         * go-lang.c (go_language_defn): Likewise.
4696         * language.c (unknown_language_defn): Likewise.
4697         (auto_language_defn): Likewise.
4698         * language.h (struct language_defn): Remove la_magic field.
4699         (LANG_MAGIC): Delete.
4700         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4701         * objc-lang.c (objc_language_defn): Likewise.
4702         * opencl-lang.c (opencl_language_defn): Likewise.
4703         * p-lang.c (pascal_language_defn): Likewise.
4704         * rust-lang.c (rust_language_defn): Likewise.
4705
4706 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * riscv-tdep.c (riscv_type_align): New function.
4709         (riscv_type_alignment): Delete.
4710         (riscv_arg_location): Use 'type_align'.
4711         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4712
4713 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * gdbtypes.c (type_align): A struct with no non-static fields also
4716         has alignment of 1.
4717
4718 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4721         component to 0.
4722         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4723         member.
4724         (riscv_struct_info::analyse): New implementation using new
4725         analyse_inner member function.
4726         (riscv_struct_info::field_offset): New member function.
4727         (riscv_struct_info::m_offsets): New member variable.
4728         (riscv_struct_info::analyse_inner): New private member function,
4729         takes the old implementation of riscv_struct_info::analyse but
4730         extended to track field offsets.
4731         (riscv_call_arg_struct): Update the struct folding special cases
4732         to handle cases where empty C++ structs, which are non-zero
4733         length, are found.
4734         (riscv_arg_location): Initialise the length of each location, a
4735         non-zero length now indicates the location is in use.
4736         (riscv_push_dummy_call): Allow for the first location having a
4737         non-zero offset when setting up arguments.
4738         (riscv_return_value): Likewise, but for return values.
4739
4740 2019-04-11  Tom Tromey  <tromey@adacore.com>
4741
4742         * utils.c (internal_vproblem): Make "msg" const.
4743
4744 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4745
4746         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4747         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4748         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4749         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4750
4751 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4752
4753         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4754         function.
4755         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4756         of amd64_collect_native_gregset.
4757         (amd64_linux_nat_target::store_registers): Likewise.
4758
4759 2019-04-10  Tom Tromey  <tom@tromey.com>
4760
4761         * symtab.c (lookup_global_symbol_from_objfile)
4762         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4763         * objfiles.h (class separate_debug_iterator): New.
4764         (class separate_debug_range): New.
4765         (struct objfile) <separate_debug_objfiles>: New method.
4766         (objfile_separate_debug_iterate): Don't declare.
4767         * objfiles.c (separate_debug_iterator::operator++): Rename from
4768         objfile_separate_debug_iterate.
4769         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4770         iterator.
4771         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4772         iterator.
4773
4774 2019-04-10  Tom Tromey  <tom@tromey.com>
4775
4776         * symfile.c (reread_symbols): Remove old comment.
4777         * objfiles.c (free_all_objfiles): Fix a typo.
4778
4779 2019-04-10  Tom Tromey  <tom@tromey.com>
4780
4781         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4782         * minsyms.c (lookup_minimal_symbol): Use foreach.
4783         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4784         (lookup_minimal_symbol_solib_trampoline): Likewise.
4785         * symfile.c (reread_symbols): Use foreach.
4786
4787 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4788             Tom Tromey  <tromey@adacore.com>
4789
4790         PR rust/24414:
4791         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4792         (rust_lex_int_test): Change "value" to be LONGEST.
4793         (rust_lex_tests): Add test for long integer literal.
4794
4795 2019-04-09  Tom Tromey  <tromey@adacore.com>
4796
4797         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4798         to bool.
4799         (extended_remote_target::attach): Update.
4800         (remote_target::remote_notice_new_inferior): Update.
4801         (remote_target::add_current_inferior_and_thread): Update.
4802         * inferior.c (exit_inferior_1): Use "false".
4803         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4804
4805 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4806
4807         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4808         the "start" command.
4809
4810 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4811
4812         * python/py-inferior.c (infpy_thread_from_thread_handle):
4813         Adjust comments to reflect renaming of thread_from_thread_handle
4814         to thread_from_handle.  Adjust keywords.  Fix type error message.
4815         (inferior_object_methods): Add thread_from_handle.  Retain
4816         thread_from_thread_handle, but mark it as deprecated.
4817
4818 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4819
4820         * gdbthread.h (find_thread_by_handle): Revise declaration.
4821         * thread.c (find_thread_by_handle): Likewise.  Adjust
4822         implementation too.
4823         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4824         support for buffer objects as handles.
4825
4826 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4827
4828         * python/py-infthread.c (thpy_thread_handle): New function.
4829         (thread_object_methods): Register thpy_thread_handle.
4830
4831 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4832
4833         * gdbthread.h (thread_to_thread_handle): Declare.
4834         * thread.c (gdbtypes.h): Include.
4835         (thread_to_thread_handle): New function.
4836
4837         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4838         (target_thread_info_to_thread_handle): Declare.
4839         * target.c (target_thread_info_to_thread_handle): New function.
4840         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4841         * target-delegates.c: Regenerate.
4842
4843         * linux-thread-db.c (class thread_db_target): Add method
4844         thread_info_to_thread_handle.
4845         (thread_db_target::thread_info_to_thread_handle): Define.
4846         * remote.c (class remote_target): Add new method
4847         thread_info_to_thread_handle.
4848         (remote_target::thread_info_to_thread_handle): Define.
4849
4850 2019-04-08  Pedro Alves  <palves@redhat.com>
4851
4852         * common/common-exceptions.c (throw_exception): Don't create
4853         named object to throw; throw directly.
4854         (throw_it): Likewise.  Don't initialize gdb_exception::message
4855         here, with new; pass FMT and AP to the ctor instead.
4856         * common/common-exceptions.h: Include <string>.
4857         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4858         const char *, va_list)): New ctor.  Use std::make_shared.
4859         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4860         errors)): Delete.
4861         (gdb_exception_error::gdb_exception_error(enum errors, const char
4862         *, va_list)): New.
4863         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4864         Add assertion.
4865         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4866         errors)): Delete.
4867         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4868         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4869         Add assertion.
4870
4871 2019-04-08  Tom Tromey  <tom@tromey.com>
4872
4873         * valops.c (value_rtti_indirect_type): Replace throw_exception
4874         with throw.
4875         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4876         with throw.
4877         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4878         throw.
4879         * target.c (target_translate_tls_address): Replace throw_exception
4880         with throw.
4881         * stack.c (frame_apply_command_count): Replace throw_exception
4882         with throw.
4883         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4884         throw.
4885         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4886         with throw.
4887         * rs6000-tdep.c (rs6000_frame_cache)
4888         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4889         * remote.c: Replace throw_exception with throw.
4890         * record-full.c (record_full_message, record_full_wait_1)
4891         (record_full_restore): Replace throw_exception with throw.
4892         * record-btrace.c:
4893         (get_thread_current_frame_id, record_btrace_start_replaying)
4894         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4895         (cmd_record_btrace_start): Replace throw_exception with throw.
4896         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4897         throw.
4898         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4899         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4900         * linespec.c:
4901         (find_linespec_symbols): Replace throw_exception with throw.
4902         * infrun.c (displaced_step_prepare, resume): Replace
4903         throw_exception with throw.
4904         * infcmd.c (post_create_inferior): Replace throw_exception with
4905         throw.
4906         * inf-loop.c (inferior_event_handler): Replace throw_exception
4907         with throw.
4908         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4909         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4910         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4911         (get_prev_frame_always, get_frame_pc_if_available)
4912         (get_frame_address_in_block_if_available, get_frame_language):
4913         Replace throw_exception with throw.
4914         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4915         throw_exception with throw.
4916         * eval.c (fetch_subexp_value, evaluate_var_value)
4917         (evaluate_funcall, evaluate_subexp_standard): Replace
4918         throw_exception with throw.
4919         * dwarf2loc.c (call_site_find_chain)
4920         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4921         Replace throw_exception with throw.
4922         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4923         with throw.
4924         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4925         throw.
4926         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4927         * completer.c (complete_line_internal): Replace throw_exception
4928         with throw.
4929         * compile/compile-object-run.c (compile_object_run): Replace
4930         throw_exception with throw.
4931         * cli/cli-script.c (process_next_line): Replace throw_exception
4932         with throw.
4933         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4934         (btrace_enable, btrace_maint_update_pt_packets): Replace
4935         throw_exception with throw.
4936         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4937         throw_exception with throw.
4938         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4939         throw_exception with throw.
4940         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4941         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4942         * aarch64-tdep.c (aarch64_make_prologue_cache)
4943         (aarch64_make_stub_cache): Replace throw_exception with throw.
4944
4945 2019-04-08  Tom Tromey  <tom@tromey.com>
4946
4947         * common/common-exceptions.c (throw_exception): Rename from
4948         throw_exception_cxx.  Remove old copy.  Make argument const.
4949         (throw_it): Create and throw exception objects directly.
4950         * common/common-exceptions.h (throw_exception): Make argument
4951         const.
4952         (struct gdb_exception_error): Add constructor.
4953         (struct gdb_exception_quit): Add constructor.
4954
4955 2019-04-08  Tom Tromey  <tom@tromey.com>
4956
4957         * common/common-exceptions.h (exception_rethrow): Don't declare.
4958         (TRY_SJLJ): Update comment.
4959         (TRY, CATCH, END_CATCH): Remove.
4960         * common/common-exceptions.c (exception_rethrow): Remove.
4961
4962 2019-04-08  Tom Tromey  <tom@tromey.com>
4963
4964         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4965         Remove.
4966         (gdb_exception_error): Rename from
4967         gdb_exception_RETURN_MASK_ERROR.
4968         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4969         (gdb_quit_bad_alloc): Update.
4970         * aarch64-tdep.c: Update.
4971         * ada-lang.c: Update.
4972         * ada-typeprint.c: Update.
4973         * ada-valprint.c: Update.
4974         * amd64-tdep.c: Update.
4975         * arch-utils.c: Update.
4976         * break-catch-throw.c: Update.
4977         * breakpoint.c: Update.
4978         * btrace.c: Update.
4979         * c-varobj.c: Update.
4980         * cli/cli-cmds.c: Update.
4981         * cli/cli-interp.c: Update.
4982         * cli/cli-script.c: Update.
4983         * common/common-exceptions.c: Update.
4984         * common/new-op.c: Update.
4985         * common/selftest.c: Update.
4986         * compile/compile-c-symbols.c: Update.
4987         * compile/compile-cplus-symbols.c: Update.
4988         * compile/compile-object-load.c: Update.
4989         * compile/compile-object-run.c: Update.
4990         * completer.c: Update.
4991         * corelow.c: Update.
4992         * cp-abi.c: Update.
4993         * cp-support.c: Update.
4994         * cp-valprint.c: Update.
4995         * darwin-nat.c: Update.
4996         * disasm-selftests.c: Update.
4997         * dtrace-probe.c: Update.
4998         * dwarf-index-cache.c: Update.
4999         * dwarf-index-write.c: Update.
5000         * dwarf2-frame-tailcall.c: Update.
5001         * dwarf2-frame.c: Update.
5002         * dwarf2loc.c: Update.
5003         * dwarf2read.c: Update.
5004         * eval.c: Update.
5005         * event-loop.c: Update.
5006         * event-top.c: Update.
5007         * exec.c: Update.
5008         * f-valprint.c: Update.
5009         * fbsd-tdep.c: Update.
5010         * frame-unwind.c: Update.
5011         * frame.c: Update.
5012         * gdbtypes.c: Update.
5013         * gnu-v3-abi.c: Update.
5014         * guile/guile-internal.h: Update.
5015         * guile/scm-block.c: Update.
5016         * guile/scm-breakpoint.c: Update.
5017         * guile/scm-cmd.c: Update.
5018         * guile/scm-disasm.c: Update.
5019         * guile/scm-frame.c: Update.
5020         * guile/scm-lazy-string.c: Update.
5021         * guile/scm-math.c: Update.
5022         * guile/scm-param.c: Update.
5023         * guile/scm-ports.c: Update.
5024         * guile/scm-pretty-print.c: Update.
5025         * guile/scm-symbol.c: Update.
5026         * guile/scm-symtab.c: Update.
5027         * guile/scm-type.c: Update.
5028         * guile/scm-value.c: Update.
5029         * i386-linux-tdep.c: Update.
5030         * i386-tdep.c: Update.
5031         * inf-loop.c: Update.
5032         * infcall.c: Update.
5033         * infcmd.c: Update.
5034         * infrun.c: Update.
5035         * jit.c: Update.
5036         * language.c: Update.
5037         * linespec.c: Update.
5038         * linux-fork.c: Update.
5039         * linux-nat.c: Update.
5040         * linux-tdep.c: Update.
5041         * linux-thread-db.c: Update.
5042         * main.c: Update.
5043         * mi/mi-cmd-break.c: Update.
5044         * mi/mi-cmd-stack.c: Update.
5045         * mi/mi-interp.c: Update.
5046         * mi/mi-main.c: Update.
5047         * objc-lang.c: Update.
5048         * p-valprint.c: Update.
5049         * parse.c: Update.
5050         * ppc-linux-tdep.c: Update.
5051         * printcmd.c: Update.
5052         * python/py-arch.c: Update.
5053         * python/py-breakpoint.c: Update.
5054         * python/py-cmd.c: Update.
5055         * python/py-finishbreakpoint.c: Update.
5056         * python/py-frame.c: Update.
5057         * python/py-framefilter.c: Update.
5058         * python/py-gdb-readline.c: Update.
5059         * python/py-inferior.c: Update.
5060         * python/py-infthread.c: Update.
5061         * python/py-lazy-string.c: Update.
5062         * python/py-linetable.c: Update.
5063         * python/py-objfile.c: Update.
5064         * python/py-param.c: Update.
5065         * python/py-prettyprint.c: Update.
5066         * python/py-progspace.c: Update.
5067         * python/py-record-btrace.c: Update.
5068         * python/py-record.c: Update.
5069         * python/py-symbol.c: Update.
5070         * python/py-type.c: Update.
5071         * python/py-unwind.c: Update.
5072         * python/py-utils.c: Update.
5073         * python/py-value.c: Update.
5074         * python/python.c: Update.
5075         * record-btrace.c: Update.
5076         * record-full.c: Update.
5077         * remote-fileio.c: Update.
5078         * remote.c: Update.
5079         * riscv-tdep.c: Update.
5080         * rs6000-aix-tdep.c: Update.
5081         * rs6000-tdep.c: Update.
5082         * rust-exp.y: Update.
5083         * rust-lang.c: Update.
5084         * s390-tdep.c: Update.
5085         * selftest-arch.c: Update.
5086         * solib-dsbt.c: Update.
5087         * solib-frv.c: Update.
5088         * solib-spu.c: Update.
5089         * solib-svr4.c: Update.
5090         * solib.c: Update.
5091         * sparc64-linux-tdep.c: Update.
5092         * stack.c: Update.
5093         * symfile-mem.c: Update.
5094         * symmisc.c: Update.
5095         * target.c: Update.
5096         * thread.c: Update.
5097         * top.c: Update.
5098         * tracefile-tfile.c: Update.
5099         * tui/tui.c: Update.
5100         * typeprint.c: Update.
5101         * unittests/cli-utils-selftests.c: Update.
5102         * unittests/parse-connection-spec-selftests.c: Update.
5103         * valops.c: Update.
5104         * valprint.c: Update.
5105         * value.c: Update.
5106         * varobj.c: Update.
5107         * windows-nat.c: Update.
5108         * x86-linux-nat.c: Update.
5109         * xml-support.c: Update.
5110
5111 2019-04-08  Tom Tromey  <tom@tromey.com>
5112
5113         * xml-support.c: Use C++ exception handling.
5114         * x86-linux-nat.c: Use C++ exception handling.
5115         * windows-nat.c: Use C++ exception handling.
5116         * varobj.c: Use C++ exception handling.
5117         * value.c: Use C++ exception handling.
5118         * valprint.c: Use C++ exception handling.
5119         * valops.c: Use C++ exception handling.
5120         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5121         handling.
5122         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5123         * typeprint.c: Use C++ exception handling.
5124         * tui/tui.c: Use C++ exception handling.
5125         * tracefile-tfile.c: Use C++ exception handling.
5126         * top.c: Use C++ exception handling.
5127         * thread.c: Use C++ exception handling.
5128         * target.c: Use C++ exception handling.
5129         * symmisc.c: Use C++ exception handling.
5130         * symfile-mem.c: Use C++ exception handling.
5131         * stack.c: Use C++ exception handling.
5132         * sparc64-linux-tdep.c: Use C++ exception handling.
5133         * solib.c: Use C++ exception handling.
5134         * solib-svr4.c: Use C++ exception handling.
5135         * solib-spu.c: Use C++ exception handling.
5136         * solib-frv.c: Use C++ exception handling.
5137         * solib-dsbt.c: Use C++ exception handling.
5138         * selftest-arch.c: Use C++ exception handling.
5139         * s390-tdep.c: Use C++ exception handling.
5140         * rust-lang.c: Use C++ exception handling.
5141         * rust-exp.y: Use C++ exception handling.
5142         * rs6000-tdep.c: Use C++ exception handling.
5143         * rs6000-aix-tdep.c: Use C++ exception handling.
5144         * riscv-tdep.c: Use C++ exception handling.
5145         * remote.c: Use C++ exception handling.
5146         * remote-fileio.c: Use C++ exception handling.
5147         * record-full.c: Use C++ exception handling.
5148         * record-btrace.c: Use C++ exception handling.
5149         * python/python.c: Use C++ exception handling.
5150         * python/py-value.c: Use C++ exception handling.
5151         * python/py-utils.c: Use C++ exception handling.
5152         * python/py-unwind.c: Use C++ exception handling.
5153         * python/py-type.c: Use C++ exception handling.
5154         * python/py-symbol.c: Use C++ exception handling.
5155         * python/py-record.c: Use C++ exception handling.
5156         * python/py-record-btrace.c: Use C++ exception handling.
5157         * python/py-progspace.c: Use C++ exception handling.
5158         * python/py-prettyprint.c: Use C++ exception handling.
5159         * python/py-param.c: Use C++ exception handling.
5160         * python/py-objfile.c: Use C++ exception handling.
5161         * python/py-linetable.c: Use C++ exception handling.
5162         * python/py-lazy-string.c: Use C++ exception handling.
5163         * python/py-infthread.c: Use C++ exception handling.
5164         * python/py-inferior.c: Use C++ exception handling.
5165         * python/py-gdb-readline.c: Use C++ exception handling.
5166         * python/py-framefilter.c: Use C++ exception handling.
5167         * python/py-frame.c: Use C++ exception handling.
5168         * python/py-finishbreakpoint.c: Use C++ exception handling.
5169         * python/py-cmd.c: Use C++ exception handling.
5170         * python/py-breakpoint.c: Use C++ exception handling.
5171         * python/py-arch.c: Use C++ exception handling.
5172         * printcmd.c: Use C++ exception handling.
5173         * ppc-linux-tdep.c: Use C++ exception handling.
5174         * parse.c: Use C++ exception handling.
5175         * p-valprint.c: Use C++ exception handling.
5176         * objc-lang.c: Use C++ exception handling.
5177         * mi/mi-main.c: Use C++ exception handling.
5178         * mi/mi-interp.c: Use C++ exception handling.
5179         * mi/mi-cmd-stack.c: Use C++ exception handling.
5180         * mi/mi-cmd-break.c: Use C++ exception handling.
5181         * main.c: Use C++ exception handling.
5182         * linux-thread-db.c: Use C++ exception handling.
5183         * linux-tdep.c: Use C++ exception handling.
5184         * linux-nat.c: Use C++ exception handling.
5185         * linux-fork.c: Use C++ exception handling.
5186         * linespec.c: Use C++ exception handling.
5187         * language.c: Use C++ exception handling.
5188         * jit.c: Use C++ exception handling.
5189         * infrun.c: Use C++ exception handling.
5190         * infcmd.c: Use C++ exception handling.
5191         * infcall.c: Use C++ exception handling.
5192         * inf-loop.c: Use C++ exception handling.
5193         * i386-tdep.c: Use C++ exception handling.
5194         * i386-linux-tdep.c: Use C++ exception handling.
5195         * guile/scm-value.c: Use C++ exception handling.
5196         * guile/scm-type.c: Use C++ exception handling.
5197         * guile/scm-symtab.c: Use C++ exception handling.
5198         * guile/scm-symbol.c: Use C++ exception handling.
5199         * guile/scm-pretty-print.c: Use C++ exception handling.
5200         * guile/scm-ports.c: Use C++ exception handling.
5201         * guile/scm-param.c: Use C++ exception handling.
5202         * guile/scm-math.c: Use C++ exception handling.
5203         * guile/scm-lazy-string.c: Use C++ exception handling.
5204         * guile/scm-frame.c: Use C++ exception handling.
5205         * guile/scm-disasm.c: Use C++ exception handling.
5206         * guile/scm-cmd.c: Use C++ exception handling.
5207         * guile/scm-breakpoint.c: Use C++ exception handling.
5208         * guile/scm-block.c: Use C++ exception handling.
5209         * guile/guile-internal.h: Use C++ exception handling.
5210         * gnu-v3-abi.c: Use C++ exception handling.
5211         * gdbtypes.c: Use C++ exception handling.
5212         * frame.c: Use C++ exception handling.
5213         * frame-unwind.c: Use C++ exception handling.
5214         * fbsd-tdep.c: Use C++ exception handling.
5215         * f-valprint.c: Use C++ exception handling.
5216         * exec.c: Use C++ exception handling.
5217         * event-top.c: Use C++ exception handling.
5218         * event-loop.c: Use C++ exception handling.
5219         * eval.c: Use C++ exception handling.
5220         * dwarf2read.c: Use C++ exception handling.
5221         * dwarf2loc.c: Use C++ exception handling.
5222         * dwarf2-frame.c: Use C++ exception handling.
5223         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5224         * dwarf-index-write.c: Use C++ exception handling.
5225         * dwarf-index-cache.c: Use C++ exception handling.
5226         * dtrace-probe.c: Use C++ exception handling.
5227         * disasm-selftests.c: Use C++ exception handling.
5228         * darwin-nat.c: Use C++ exception handling.
5229         * cp-valprint.c: Use C++ exception handling.
5230         * cp-support.c: Use C++ exception handling.
5231         * cp-abi.c: Use C++ exception handling.
5232         * corelow.c: Use C++ exception handling.
5233         * completer.c: Use C++ exception handling.
5234         * compile/compile-object-run.c: Use C++ exception handling.
5235         * compile/compile-object-load.c: Use C++ exception handling.
5236         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5237         * compile/compile-c-symbols.c: Use C++ exception handling.
5238         * common/selftest.c: Use C++ exception handling.
5239         * common/new-op.c: Use C++ exception handling.
5240         * cli/cli-script.c: Use C++ exception handling.
5241         * cli/cli-interp.c: Use C++ exception handling.
5242         * cli/cli-cmds.c: Use C++ exception handling.
5243         * c-varobj.c: Use C++ exception handling.
5244         * btrace.c: Use C++ exception handling.
5245         * breakpoint.c: Use C++ exception handling.
5246         * break-catch-throw.c: Use C++ exception handling.
5247         * arch-utils.c: Use C++ exception handling.
5248         * amd64-tdep.c: Use C++ exception handling.
5249         * ada-valprint.c: Use C++ exception handling.
5250         * ada-typeprint.c: Use C++ exception handling.
5251         * ada-lang.c: Use C++ exception handling.
5252         * aarch64-tdep.c: Use C++ exception handling.
5253
5254 2019-04-08  Tom Tromey  <tom@tromey.com>
5255
5256         * xml-support.c (gdb_xml_parser::parse): Update.
5257         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5258         * value.c (show_convenience): Update.
5259         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5260         (test_parse_flags_qcs): Update.
5261         * thread.c (thr_try_catch_cmd): Update.
5262         * target.c (target_translate_tls_address): Update.
5263         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5264         (info_frame_command_core, frame_apply_command_count): Update.
5265         * rust-exp.y (rust_lex_exception_test): Update.
5266         * riscv-tdep.c (riscv_print_one_register_info): Update.
5267         * remote.c (remote_target::enable_btrace): Update.
5268         * record-btrace.c (record_btrace_enable_warn): Update.
5269         * python/py-utils.c (gdbpy_convert_exception): Update.
5270         * printcmd.c (do_one_display, print_variable_and_value): Update.
5271         * mi/mi-main.c (mi_print_exception): Update.
5272         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5273         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5274         * linux-nat.c (linux_nat_target::attach): Update.
5275         * linux-fork.c (class scoped_switch_fork_info): Update.
5276         * infrun.c (displaced_step_prepare): Update.
5277         * infcall.c (call_function_by_hand_dummy): Update.
5278         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5279         * gnu-v3-abi.c (print_one_vtable): Update.
5280         * frame.c (get_prev_frame_always): Update.
5281         * f-valprint.c (info_common_command_for_block): Update.
5282         * exec.c (try_open_exec_file): Update.
5283         * exceptions.c (print_exception, exception_print)
5284         (exception_fprintf, exception_print_same): Update.
5285         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5286         * dwarf-index-cache.c (index_cache::store)
5287         (index_cache::lookup_gdb_index): Update.
5288         * darwin-nat.c (maybe_cache_shell): Update.
5289         * cp-valprint.c (cp_print_value_fields): Update.
5290         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5291         (gcc_cplus_symbol_address): Update.
5292         * compile/compile-c-symbols.c (gcc_convert_symbol)
5293         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5294         * common/selftest.c: Update.
5295         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5296         a std::string.
5297         (exception_try_scope_entry, exception_try_scope_exit): Don't
5298         declare.
5299         (struct exception_try_scope): Remove.
5300         (TRY): Don't use exception_try_scope.
5301         (struct gdb_exception): Add constructor, operator=.
5302         <what>: New method.
5303         (struct gdb_exception_RETURN_MASK_ALL)
5304         (struct gdb_exception_RETURN_MASK_ERROR)
5305         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5306         (struct gdb_quit_bad_alloc): Update.
5307         * common/common-exceptions.c (exception_none): Change
5308         initializer.
5309         (struct catcher) <state, exception>: Initialize inline.
5310         <prev>: Remove member.
5311         (current_catcher): Remove.
5312         (catchers): New global.
5313         (exceptions_state_mc_init): Simplify.
5314         (catcher_pop): Remove.
5315         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5316         (try_scope_depth, exception_try_scope_entry)
5317         (exception_try_scope_exit): Remove.
5318         (throw_exception_sjlj): Update.
5319         (exception_messages, exception_messages_size): Remove.
5320         (throw_it): Simplify.
5321         (gdb_exception_sliced_copy): Remove.
5322         (throw_exception_cxx): Update.
5323         * cli/cli-script.c (script_from_file): Update.
5324         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5325         Update.
5326         * ada-valprint.c (ada_val_print): Update.
5327         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5328         (create_excep_cond_exprs): Update.
5329
5330 2019-04-08  Tom Tromey  <tom@tromey.com>
5331
5332         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5333         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5334         (TRY, CATCH, END_CATCH): Remove some definitions.
5335         * common/common-exceptions.c: Don't use GDB_XCPT.
5336         (catcher_list_size): Remove.
5337         (throw_exception, throw_it): Simplify.
5338
5339 2019-04-05  Tom Tromey  <tom@tromey.com>
5340
5341         Revert the header-sorting patch.
5342         * ft32-tdep.c: Revert.
5343         * frv-tdep.c: Revert.
5344         * frv-linux-tdep.c: Revert.
5345         * frame.c: Revert.
5346         * frame-unwind.c: Revert.
5347         * frame-base.c: Revert.
5348         * fork-child.c: Revert.
5349         * findvar.c: Revert.
5350         * findcmd.c: Revert.
5351         * filesystem.c: Revert.
5352         * filename-seen-cache.h: Revert.
5353         * filename-seen-cache.c: Revert.
5354         * fbsd-tdep.c: Revert.
5355         * fbsd-nat.h: Revert.
5356         * fbsd-nat.c: Revert.
5357         * f-valprint.c: Revert.
5358         * f-typeprint.c: Revert.
5359         * f-lang.c: Revert.
5360         * extension.h: Revert.
5361         * extension.c: Revert.
5362         * extension-priv.h: Revert.
5363         * expprint.c: Revert.
5364         * exec.h: Revert.
5365         * exec.c: Revert.
5366         * exceptions.c: Revert.
5367         * event-top.c: Revert.
5368         * event-loop.c: Revert.
5369         * eval.c: Revert.
5370         * elfread.c: Revert.
5371         * dwarf2read.h: Revert.
5372         * dwarf2read.c: Revert.
5373         * dwarf2loc.c: Revert.
5374         * dwarf2expr.h: Revert.
5375         * dwarf2expr.c: Revert.
5376         * dwarf2-frame.c: Revert.
5377         * dwarf2-frame-tailcall.c: Revert.
5378         * dwarf-index-write.h: Revert.
5379         * dwarf-index-write.c: Revert.
5380         * dwarf-index-common.c: Revert.
5381         * dwarf-index-cache.h: Revert.
5382         * dwarf-index-cache.c: Revert.
5383         * dummy-frame.c: Revert.
5384         * dtrace-probe.c: Revert.
5385         * disasm.h: Revert.
5386         * disasm.c: Revert.
5387         * disasm-selftests.c: Revert.
5388         * dictionary.c: Revert.
5389         * dicos-tdep.c: Revert.
5390         * demangle.c: Revert.
5391         * dcache.h: Revert.
5392         * dcache.c: Revert.
5393         * darwin-nat.h: Revert.
5394         * darwin-nat.c: Revert.
5395         * darwin-nat-info.c: Revert.
5396         * d-valprint.c: Revert.
5397         * d-namespace.c: Revert.
5398         * d-lang.c: Revert.
5399         * ctf.c: Revert.
5400         * csky-tdep.c: Revert.
5401         * csky-linux-tdep.c: Revert.
5402         * cris-tdep.c: Revert.
5403         * cris-linux-tdep.c: Revert.
5404         * cp-valprint.c: Revert.
5405         * cp-support.c: Revert.
5406         * cp-namespace.c: Revert.
5407         * cp-abi.c: Revert.
5408         * corelow.c: Revert.
5409         * corefile.c: Revert.
5410         * continuations.c: Revert.
5411         * completer.h: Revert.
5412         * completer.c: Revert.
5413         * complaints.c: Revert.
5414         * coffread.c: Revert.
5415         * coff-pe-read.c: Revert.
5416         * cli-out.h: Revert.
5417         * cli-out.c: Revert.
5418         * charset.c: Revert.
5419         * c-varobj.c: Revert.
5420         * c-valprint.c: Revert.
5421         * c-typeprint.c: Revert.
5422         * c-lang.c: Revert.
5423         * buildsym.c: Revert.
5424         * buildsym-legacy.c: Revert.
5425         * build-id.h: Revert.
5426         * build-id.c: Revert.
5427         * btrace.c: Revert.
5428         * bsd-uthread.c: Revert.
5429         * breakpoint.h: Revert.
5430         * breakpoint.c: Revert.
5431         * break-catch-throw.c: Revert.
5432         * break-catch-syscall.c: Revert.
5433         * break-catch-sig.c: Revert.
5434         * blockframe.c: Revert.
5435         * block.c: Revert.
5436         * bfin-tdep.c: Revert.
5437         * bfin-linux-tdep.c: Revert.
5438         * bfd-target.c: Revert.
5439         * bcache.c: Revert.
5440         * ax-general.c: Revert.
5441         * ax-gdb.h: Revert.
5442         * ax-gdb.c: Revert.
5443         * avr-tdep.c: Revert.
5444         * auxv.c: Revert.
5445         * auto-load.c: Revert.
5446         * arm-wince-tdep.c: Revert.
5447         * arm-tdep.c: Revert.
5448         * arm-symbian-tdep.c: Revert.
5449         * arm-pikeos-tdep.c: Revert.
5450         * arm-obsd-tdep.c: Revert.
5451         * arm-nbsd-tdep.c: Revert.
5452         * arm-nbsd-nat.c: Revert.
5453         * arm-linux-tdep.c: Revert.
5454         * arm-linux-nat.c: Revert.
5455         * arm-fbsd-tdep.c: Revert.
5456         * arm-fbsd-nat.c: Revert.
5457         * arm-bsd-tdep.c: Revert.
5458         * arch-utils.c: Revert.
5459         * arc-tdep.c: Revert.
5460         * arc-newlib-tdep.c: Revert.
5461         * annotate.h: Revert.
5462         * annotate.c: Revert.
5463         * amd64-windows-tdep.c: Revert.
5464         * amd64-windows-nat.c: Revert.
5465         * amd64-tdep.c: Revert.
5466         * amd64-sol2-tdep.c: Revert.
5467         * amd64-obsd-tdep.c: Revert.
5468         * amd64-obsd-nat.c: Revert.
5469         * amd64-nbsd-tdep.c: Revert.
5470         * amd64-nbsd-nat.c: Revert.
5471         * amd64-nat.c: Revert.
5472         * amd64-linux-tdep.c: Revert.
5473         * amd64-linux-nat.c: Revert.
5474         * amd64-fbsd-tdep.c: Revert.
5475         * amd64-fbsd-nat.c: Revert.
5476         * amd64-dicos-tdep.c: Revert.
5477         * amd64-darwin-tdep.c: Revert.
5478         * amd64-bsd-nat.c: Revert.
5479         * alpha-tdep.c: Revert.
5480         * alpha-obsd-tdep.c: Revert.
5481         * alpha-nbsd-tdep.c: Revert.
5482         * alpha-mdebug-tdep.c: Revert.
5483         * alpha-linux-tdep.c: Revert.
5484         * alpha-linux-nat.c: Revert.
5485         * alpha-bsd-tdep.c: Revert.
5486         * alpha-bsd-nat.c: Revert.
5487         * aix-thread.c: Revert.
5488         * agent.c: Revert.
5489         * addrmap.c: Revert.
5490         * ada-varobj.c: Revert.
5491         * ada-valprint.c: Revert.
5492         * ada-typeprint.c: Revert.
5493         * ada-tasks.c: Revert.
5494         * ada-lang.c: Revert.
5495         * aarch64-tdep.c: Revert.
5496         * aarch64-ravenscar-thread.c: Revert.
5497         * aarch64-newlib-tdep.c: Revert.
5498         * aarch64-linux-tdep.c: Revert.
5499         * aarch64-linux-nat.c: Revert.
5500         * aarch64-fbsd-tdep.c: Revert.
5501         * aarch64-fbsd-nat.c: Revert.
5502         * aarch32-linux-nat.c: Revert.
5503
5504 2019-04-05  Tom Tromey  <tom@tromey.com>
5505
5506         * ft32-tdep.c: Sort headers.
5507         * frv-tdep.c: Sort headers.
5508         * frv-linux-tdep.c: Sort headers.
5509         * frame.c: Sort headers.
5510         * frame-unwind.c: Sort headers.
5511         * frame-base.c: Sort headers.
5512         * fork-child.c: Sort headers.
5513         * findvar.c: Sort headers.
5514         * findcmd.c: Sort headers.
5515         * filesystem.c: Sort headers.
5516         * filename-seen-cache.h: Sort headers.
5517         * filename-seen-cache.c: Sort headers.
5518         * fbsd-tdep.c: Sort headers.
5519         * fbsd-nat.h: Sort headers.
5520         * fbsd-nat.c: Sort headers.
5521         * f-valprint.c: Sort headers.
5522         * f-typeprint.c: Sort headers.
5523         * f-lang.c: Sort headers.
5524         * extension.h: Sort headers.
5525         * extension.c: Sort headers.
5526         * extension-priv.h: Sort headers.
5527         * expprint.c: Sort headers.
5528         * exec.h: Sort headers.
5529         * exec.c: Sort headers.
5530         * exceptions.c: Sort headers.
5531         * event-top.c: Sort headers.
5532         * event-loop.c: Sort headers.
5533         * eval.c: Sort headers.
5534         * elfread.c: Sort headers.
5535         * dwarf2read.h: Sort headers.
5536         * dwarf2read.c: Sort headers.
5537         * dwarf2loc.c: Sort headers.
5538         * dwarf2expr.h: Sort headers.
5539         * dwarf2expr.c: Sort headers.
5540         * dwarf2-frame.c: Sort headers.
5541         * dwarf2-frame-tailcall.c: Sort headers.
5542         * dwarf-index-write.h: Sort headers.
5543         * dwarf-index-write.c: Sort headers.
5544         * dwarf-index-common.c: Sort headers.
5545         * dwarf-index-cache.h: Sort headers.
5546         * dwarf-index-cache.c: Sort headers.
5547         * dummy-frame.c: Sort headers.
5548         * dtrace-probe.c: Sort headers.
5549         * disasm.h: Sort headers.
5550         * disasm.c: Sort headers.
5551         * disasm-selftests.c: Sort headers.
5552         * dictionary.c: Sort headers.
5553         * dicos-tdep.c: Sort headers.
5554         * demangle.c: Sort headers.
5555         * dcache.h: Sort headers.
5556         * dcache.c: Sort headers.
5557         * darwin-nat.h: Sort headers.
5558         * darwin-nat.c: Sort headers.
5559         * darwin-nat-info.c: Sort headers.
5560         * d-valprint.c: Sort headers.
5561         * d-namespace.c: Sort headers.
5562         * d-lang.c: Sort headers.
5563         * ctf.c: Sort headers.
5564         * csky-tdep.c: Sort headers.
5565         * csky-linux-tdep.c: Sort headers.
5566         * cris-tdep.c: Sort headers.
5567         * cris-linux-tdep.c: Sort headers.
5568         * cp-valprint.c: Sort headers.
5569         * cp-support.c: Sort headers.
5570         * cp-namespace.c: Sort headers.
5571         * cp-abi.c: Sort headers.
5572         * corelow.c: Sort headers.
5573         * corefile.c: Sort headers.
5574         * continuations.c: Sort headers.
5575         * completer.h: Sort headers.
5576         * completer.c: Sort headers.
5577         * complaints.c: Sort headers.
5578         * coffread.c: Sort headers.
5579         * coff-pe-read.c: Sort headers.
5580         * cli-out.h: Sort headers.
5581         * cli-out.c: Sort headers.
5582         * charset.c: Sort headers.
5583         * c-varobj.c: Sort headers.
5584         * c-valprint.c: Sort headers.
5585         * c-typeprint.c: Sort headers.
5586         * c-lang.c: Sort headers.
5587         * buildsym.c: Sort headers.
5588         * buildsym-legacy.c: Sort headers.
5589         * build-id.h: Sort headers.
5590         * build-id.c: Sort headers.
5591         * btrace.c: Sort headers.
5592         * bsd-uthread.c: Sort headers.
5593         * breakpoint.h: Sort headers.
5594         * breakpoint.c: Sort headers.
5595         * break-catch-throw.c: Sort headers.
5596         * break-catch-syscall.c: Sort headers.
5597         * break-catch-sig.c: Sort headers.
5598         * blockframe.c: Sort headers.
5599         * block.c: Sort headers.
5600         * bfin-tdep.c: Sort headers.
5601         * bfin-linux-tdep.c: Sort headers.
5602         * bfd-target.c: Sort headers.
5603         * bcache.c: Sort headers.
5604         * ax-general.c: Sort headers.
5605         * ax-gdb.h: Sort headers.
5606         * ax-gdb.c: Sort headers.
5607         * avr-tdep.c: Sort headers.
5608         * auxv.c: Sort headers.
5609         * auto-load.c: Sort headers.
5610         * arm-wince-tdep.c: Sort headers.
5611         * arm-tdep.c: Sort headers.
5612         * arm-symbian-tdep.c: Sort headers.
5613         * arm-pikeos-tdep.c: Sort headers.
5614         * arm-obsd-tdep.c: Sort headers.
5615         * arm-nbsd-tdep.c: Sort headers.
5616         * arm-nbsd-nat.c: Sort headers.
5617         * arm-linux-tdep.c: Sort headers.
5618         * arm-linux-nat.c: Sort headers.
5619         * arm-fbsd-tdep.c: Sort headers.
5620         * arm-fbsd-nat.c: Sort headers.
5621         * arm-bsd-tdep.c: Sort headers.
5622         * arch-utils.c: Sort headers.
5623         * arc-tdep.c: Sort headers.
5624         * arc-newlib-tdep.c: Sort headers.
5625         * annotate.h: Sort headers.
5626         * annotate.c: Sort headers.
5627         * amd64-windows-tdep.c: Sort headers.
5628         * amd64-windows-nat.c: Sort headers.
5629         * amd64-tdep.c: Sort headers.
5630         * amd64-sol2-tdep.c: Sort headers.
5631         * amd64-obsd-tdep.c: Sort headers.
5632         * amd64-obsd-nat.c: Sort headers.
5633         * amd64-nbsd-tdep.c: Sort headers.
5634         * amd64-nbsd-nat.c: Sort headers.
5635         * amd64-nat.c: Sort headers.
5636         * amd64-linux-tdep.c: Sort headers.
5637         * amd64-linux-nat.c: Sort headers.
5638         * amd64-fbsd-tdep.c: Sort headers.
5639         * amd64-fbsd-nat.c: Sort headers.
5640         * amd64-dicos-tdep.c: Sort headers.
5641         * amd64-darwin-tdep.c: Sort headers.
5642         * amd64-bsd-nat.c: Sort headers.
5643         * alpha-tdep.c: Sort headers.
5644         * alpha-obsd-tdep.c: Sort headers.
5645         * alpha-nbsd-tdep.c: Sort headers.
5646         * alpha-mdebug-tdep.c: Sort headers.
5647         * alpha-linux-tdep.c: Sort headers.
5648         * alpha-linux-nat.c: Sort headers.
5649         * alpha-bsd-tdep.c: Sort headers.
5650         * alpha-bsd-nat.c: Sort headers.
5651         * aix-thread.c: Sort headers.
5652         * agent.c: Sort headers.
5653         * addrmap.c: Sort headers.
5654         * ada-varobj.c: Sort headers.
5655         * ada-valprint.c: Sort headers.
5656         * ada-typeprint.c: Sort headers.
5657         * ada-tasks.c: Sort headers.
5658         * ada-lang.c: Sort headers.
5659         * aarch64-tdep.c: Sort headers.
5660         * aarch64-ravenscar-thread.c: Sort headers.
5661         * aarch64-newlib-tdep.c: Sort headers.
5662         * aarch64-linux-tdep.c: Sort headers.
5663         * aarch64-linux-nat.c: Sort headers.
5664         * aarch64-fbsd-tdep.c: Sort headers.
5665         * aarch64-fbsd-nat.c: Sort headers.
5666         * aarch32-linux-nat.c: Sort headers.
5667
5668 2019-04-04  Tom Tromey  <tom@tromey.com>
5669
5670         * varobj.c (varobj_create): Update.
5671         * rust-exp.y (struct rust_parser) <update_innermost_block,
5672         lookup_symbol>: New methods.
5673         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5674         Rename.
5675         (rust_parser::rust_lookup_type)
5676         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5677         * printcmd.c (display_command, do_one_display): Update.
5678         * parser-defs.h (struct parser_state) <parser_state>: Add
5679         "tracker" parameter.
5680         (block_tracker): New member.
5681         (class innermost_block_tracker) <innermost_block_tracker>: Add
5682         "types" parameter.
5683         <reset>: Remove method.
5684         (innermost_block): Don't declare.
5685         (null_post_parser): Update.
5686         * parse.c (innermost_block): Remove global.
5687         (write_dollar_variable): Update.
5688         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5689         Remove "tracker_types" parameter.
5690         (parse_expression): Add "tracker" parameter.
5691         (parse_expression_for_completion): Update.
5692         (null_post_parser): Add "tracker" parameter.
5693         * p-exp.y: Update rules.
5694         * m2-exp.y: Update rules.
5695         * language.h (struct language_defn) <la_post_parser>: Add
5696         "tracker" parameter.
5697         * go-exp.y: Update rules.
5698         * f-exp.y: Update rules.
5699         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5700         parameter.
5701         * d-exp.y: Update rules.
5702         * c-exp.y: Update rules.
5703         * breakpoint.c (set_breakpoint_condition): Create an
5704         innermost_block_tracker.
5705         (watch_command_1): Likewise.
5706         * ada-lang.c (resolve): Add "tracker" parameter.
5707         (resolve_subexp): Likewise.
5708         * ada-exp.y (write_var_from_sym): Update.
5709
5710 2019-04-04  Tom Tromey  <tom@tromey.com>
5711
5712         * type-stack.h: New file.
5713         * type-stack.c: New file.
5714         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5715         type-stack.h.
5716         (insert_into_type_stack, insert_type, push_type, push_type_int)
5717         (insert_type_address_space, pop_type, pop_type_int)
5718         (pop_typelist, pop_type_stack, append_type_stack)
5719         (push_type_stack, get_type_stack, push_typelist)
5720         (follow_type_instance_flags, follow_types): Don't declare.
5721         * parse.c (type_stack): Remove global.
5722         (parse_exp_in_context): Update.
5723         (insert_into_type_stack, insert_type, push_type, push_type_int)
5724         (insert_type_address_space, pop_type, pop_type_int)
5725         (pop_typelist, pop_type_stack, append_type_stack)
5726         (push_type_stack, get_type_stack, push_typelist)
5727         (follow_type_instance_flags, follow_types): Remove (moved to
5728         type-stack.c).
5729         * f-exp.y (type_stack): New global.
5730         Update rules.
5731         (push_kind_type, f_parse): Update.
5732         * d-exp.y (type_stack): New global.
5733         Update rules.
5734         (d_parse): Update.
5735         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5736         Update rules.
5737         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5738         (HFILES_NO_SRCDIR): Add type-stack.h.
5739
5740 2019-04-04  Tom Tromey  <tom@tromey.com>
5741
5742         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5743         (rust_parser::convert_ast_to_expression, rust_parse)
5744         (rust_lex_test_completion, rust_lex_tests): Update.
5745         * parser-defs.h (struct expr_completion_state): New.
5746         (struct parser_state) <parser_state>: Add completion parameter.
5747         <mark_struct_expression, mark_completion_tag>: New methods.
5748         <parse_completion, m_completion_state>: New members.
5749         (prefixify_expression, null_post_parser): Update.
5750         (mark_struct_expression, mark_completion_tag): Don't declare.
5751         * parse.c (parse_completion, expout_last_struct)
5752         (expout_tag_completion_type, expout_completion_name): Remove
5753         globals.
5754         (parser_state::mark_struct_expression)
5755         (parser_state::mark_completion_tag): Now methods.
5756         (prefixify_expression): Add last_struct parameter.
5757         (prefixify_subexp): Likewise.
5758         (parse_exp_1): Update.
5759         (parse_exp_in_context): Add cstate parameter.  Update.
5760         (parse_expression_for_completion): Create an
5761         expr_completion_state.
5762         (null_post_parser): Add "completion" parameter.
5763         * p-exp.y: Update rules.
5764         (yylex): Update.
5765         * language.h (struct language_defn) <la_post_parser>: Add
5766         "completing" parameter.
5767         * go-exp.y: Update rules.
5768         (lex_one_token): Update.
5769         * expression.h (parse_completion): Don't declare.
5770         * d-exp.y: Update rules.
5771         (lex_one_token): Update rules.
5772         * c-exp.y: Update rules.
5773         (lex_one_token): Update.
5774         * ada-lang.c (resolve): Add "parse_completion" parameter.
5775         (resolve_subexp): Likewise.
5776         (ada_resolve_function): Likewise.
5777
5778 2019-04-04  Tom Tromey  <tom@tromey.com>
5779
5780         * parser-defs.h (struct parser_state) <start_arglist,
5781         end_arglist>: New methods.
5782         <arglist_len, m_funcall_chain>: New members.
5783         (arglist_len, start_arglist, end_arglist): Don't declare.
5784         * parse.c (arglist_len, funcall_chain): Remove global.
5785         (start_arglist, end_arglist): Remove functions.
5786         (parse_exp_in_context): Update.
5787         * p-exp.y: Update rules.
5788         * m2-exp.y: Update rules.
5789         * go-exp.y: Update rules.
5790         * f-exp.y: Update rules.
5791         * d-exp.y: Update rules.
5792         * c-exp.y: Update rules.
5793
5794 2019-04-04  Tom Tromey  <tom@tromey.com>
5795
5796         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5797         lex_operator, push_back>: New methods.
5798         Update all rules.
5799         (rust_parser::lex_hex, lex_escape): Rename and update.
5800         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5801         (rust_parser::lex_operator): Rename and update.
5802         (rust_parser::lex_number, rustyylex, rustyyerror)
5803         (rust_lex_test_init, rust_lex_test_sequence)
5804         (rust_lex_test_push_back, rust_lex_tests): Update.
5805         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5806         parameter.
5807         <lexptr, prev_lexptr>: New members.
5808         (lexptr, prev_lexptr): Don't declare.
5809         * parse.c (lexptr, prev_lexptr): Remove globals.
5810         (parse_exp_in_context): Update.
5811         * p-exp.y (yylex, yyerror): Update.
5812         * m2-exp.y (parse_number, yylex, yyerror): Update.
5813         * go-exp.y (lex_one_token, yyerror): Update.
5814         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5815         * d-exp.y (lex_one_token, yyerror): Update.
5816         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5817         (lex_one_token, yyerror): Update.
5818         * ada-lex.l (YY_INPUT): Update.
5819         (rewind_to_char): Update.
5820         * ada-exp.y (yyerror): Update.
5821
5822 2019-04-04  Tom Tromey  <tom@tromey.com>
5823
5824         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5825         * parser-defs.h (struct parser_state) <parser_state>: Add new
5826         parameter.
5827         <comma_terminates>: New member.
5828         (comma_terminates): Don't declare global.
5829         * parse.c (comma_terminates): Remove global.
5830         (parse_exp_in_context): Update.
5831         * p-exp.y (yylex): Update.
5832         * m2-exp.y (yylex): Update.
5833         * go-exp.y (lex_one_token): Update.
5834         * f-exp.y (yylex): Update.
5835         * d-exp.y (lex_one_token): Update.
5836         * c-exp.y (lex_one_token): Update.
5837         * ada-lex.l: Update.
5838
5839 2019-04-04  Tom Tromey  <tom@tromey.com>
5840
5841         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5842         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5843         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5844         * parser-defs.h (paren_depth): Don't declare.
5845         * parse.c (paren_depth): Remove global.
5846         (parse_exp_in_context): Update.
5847         * p-exp.y (paren_depth): New global.
5848         (pascal_parse): Initialize it.
5849         * m2-exp.y (paren_depth): New global.
5850         (m2_parse): Initialize it.
5851         * go-exp.y (paren_depth): New global.
5852         (go_parse): Initialize it.
5853         * f-exp.y (paren_depth): New global.
5854         (f_parse): Initialize it.
5855         * d-exp.y (paren_depth): New global.
5856         (d_parse): Initialize it.
5857         * c-exp.y (paren_depth): New global.
5858         (c_parse): Initialize it.
5859         * ada-lex.l (paren_depth): New global.
5860         (lexer_init): Initialize it.
5861
5862 2019-04-04  Tom Tromey  <tom@tromey.com>
5863
5864         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5865         (rust_parser::convert_ast_to_type)
5866         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5867         * parser-defs.h (struct parser_state) <parser_state>: Add
5868         parameters.  Initialize new members.
5869         <expression_context_block, expression_context_pc>: New members.
5870         * parse.c (expression_context_block, expression_context_pc):
5871         Remove globals.
5872         (parse_exp_in_context): Update.
5873         * p-exp.y: Update all rules.
5874         (yylex): Update.
5875         * m2-exp.y: Update all rules.
5876         (yylex): Update.
5877         * go-exp.y (yylex): Update.
5878         * f-exp.y (yylex): Update.
5879         * d-exp.y: Update all rules.
5880         (yylex): Update.
5881         * c-exp.y: Update all rules.
5882         (lex_one_token, classify_name, yylex, c_parse): Update.
5883         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5884
5885 2019-04-04  Tom Tromey  <tom@tromey.com>
5886
5887         * gdbarch.h, gdbarch.c: Rebuild.
5888         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5889         * stap-probe.h:
5890         (struct stap_parse_info): Replace "parser_state" with
5891         "expr_builder".
5892         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5893         (parser_state): New class.
5894         * parse.c (expr_builder): Rename.
5895         (expr_builder::release): Rename.
5896         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5897         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5898         (write_exp_elt_longcst, write_exp_elt_floatcst)
5899         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5900         (write_exp_string_vector, write_exp_bitstring)
5901         (write_exp_msymbol, mark_struct_expression)
5902         (write_dollar_variable)
5903         (insert_type_address_space, increase_expout_size): Replace
5904         "parser_state" with "expr_builder".
5905         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5906         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5907         "parser_state" with "expr_builder".
5908
5909 2019-04-04  Tom Tromey  <tom@tromey.com>
5910
5911         * rust-exp.y: Replace "parse_language" with method call.
5912         * p-exp.y:
5913         (yylex): Replace "parse_language" with method call.
5914         * m2-exp.y:
5915         (yylex): Replace "parse_language" with method call.
5916         * go-exp.y (classify_name): Replace "parse_language" with method
5917         call.
5918         * f-exp.y (yylex): Replace "parse_language" with method call.
5919         * d-exp.y (lex_one_token): Replace "parse_language" with method
5920         call.
5921         * c-exp.y:
5922         (lex_one_token, classify_name, yylex): Replace "parse_language"
5923         with method call.
5924         * ada-exp.y (find_primitive_type, type_char)
5925         (type_system_address): Replace "parse_language" with method call.
5926
5927 2019-04-04  Tom Tromey  <tom@tromey.com>
5928
5929         * rust-exp.y: Replace "parse_gdbarch" with method call.
5930         * parse.c (write_dollar_variable, insert_type_address_space):
5931         Replace "parse_gdbarch" with method call.
5932         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5933         call.
5934         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5935         call.
5936         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5937         "parse_gdbarch" with method call.
5938         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5939         with method call.
5940         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5941         "parse_gdbarch" with method call.
5942         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5943         "parse_gdbarch" with method call.
5944         * c-exp.y (parse_type, parse_number, classify_name): Replace
5945         "parse_gdbarch" with method call.
5946         * ada-lex.l: Replace "parse_gdbarch" with method call.
5947         * ada-exp.y (parse_type, find_primitive_type, type_char)
5948         (type_system_address): Replace "parse_gdbarch" with method call.
5949
5950 2019-04-04  Tom Tromey  <tom@tromey.com>
5951
5952         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5953         * stap-probe.c (stap_parse_argument): Update.
5954         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5955         initial_size parameter.
5956         * rust-exp.y (rust_lex_tests): Update.
5957         * parse.c (parser_state): Update.
5958         (parse_exp_in_context): Update.
5959         * parser-defs.h (struct parser_state) <parser_state>: Remove
5960         "initial_size" parameter.
5961
5962 2019-04-04  Tom Tromey  <tom@tromey.com>
5963
5964         * parser-defs.h (increase_expout_size): Don't declare.
5965         * parse.c (increase_expout_size): Now static.
5966
5967 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5968
5969         * gnu-nat.c (gnu_nat_target::wait): Fix
5970         target_waitstatus_to_string call.
5971
5972 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * eval.c (evaluate_subexp_standard): Handle internal functions
5975         during Fortran function call handling.
5976
5977 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * NEWS: Mention new internal functions.
5980         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5981         (read_base_type): Use dwarf2_init_complex_target_type.
5982         * value.c (creal_internal_fn): New function.
5983         (cimag_internal_fn): New function.
5984         (_initialize_values): Register new internal functions.
5985
5986 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5987
5988         * infrun.c (stop_all_threads): If debug_infrun, always
5989         trace the wait status after wait_one, using
5990         target_waitstatus_to_string and target_pid_to_str.
5991         (handle_inferior_event): Replace various trace of
5992         wait status kind by a single trace.
5993         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5994         wait status kind image by target_waitstatus_to_string.
5995         * target/waitstatus.c (target_waitstatus_to_string): Fix
5996         obsolete comment.
5997
5998 2019-04-01  Tom Tromey  <tromey@adacore.com>
5999
6000         PR symtab/23331:
6001         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6002
6003 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6004             Pedro Alves  <palves@redhat.com>
6005
6006         * top.c (quit_force): Call 'finalize_values'.
6007         * value.c (finalize_values): New function.
6008         * value.h (finalize_values): Declare.
6009
6010 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6011
6012         * NEWS: Announce $_gdb_major and $_gdb_minor.
6013
6014         * top.c (init_gdb_version_vars): New function.
6015         (gdb_init): Call init_gdb_version_vars.
6016
6017 2019-03-29  Tom Tromey  <tromey@adacore.com>
6018
6019         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6020         help text.  Remove dead code.
6021
6022 2019-03-29  Keith Seitz  <keiths@redhat.com>
6023
6024         From Siddhesh Poyarekar:
6025         * f-lang.h (f77_get_upperbound): Return LONGEST.
6026         (f77_get_lowerbound): Likewise.
6027         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6028         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6029         print them.
6030         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6031         plongest to format print it.
6032         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6033         (f77_get_upperbound): Likewise.
6034         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6035         LOWER_BOUND to LONGEST.
6036         (f77_create_arrayprint_offset_tbl): Likewise.
6037
6038 2019-03-29  Keith Seitz  <keiths@redhat.com>
6039
6040         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6041         %s/pulongest for TYPE_LENGTH instead of %d in format
6042         strings.
6043         * ada-typerint.c (ada_print_type): Likewise.
6044         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6045         * compile/compile-c-support.c (generate_register_struct): Likewise.
6046         * gdbtypes.c (recursive_dump_type): Likewise.
6047         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6048         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6049         instead of %d in format strings.
6050         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6051         to std::min to ULONGEST.
6052         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6053         instead of %d in format strings.
6054         * tracepoint.c (info_scope_command): Likewise.
6055         * typeprint.c (print_offset_data::update)
6056         (print_offset_data::finish): Likewise.
6057         * xtensa-tdep.c (xtensa_store_return_value)
6058         (xtensa_push_dummy_call): Likewise.
6059
6060 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6061
6062         * windows-nat.c (display_selector): Fixed format specifications
6063         for 64-bit Cygwin.
6064
6065 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6066
6067         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6068
6069 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6070
6071         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6072         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6073         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6074         (nios2_linux_init_abi): Install it.
6075
6076 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6077
6078         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6079
6080 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6081
6082         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6083
6084 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6085             Tom Tromey  <tromey@adacore.com>
6086
6087         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6088
6089 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6090
6091         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6092         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6093         method to compute the bounds of range types. Also print "[evaluated]"
6094         if the bounds' values come from a dynamic evaluation.
6095
6096 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6099         whitespace when pretty printing is on.
6100
6101 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6102
6103         * ppc-linux-nat.c: Add include.
6104
6105 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6106
6107         * NEWS: Mention AArch64 Pointer Authentication.
6108
6109 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6110
6111         * arm-linux-nat.c: Add include.
6112
6113 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6114
6115         * source-cache.c (source_cache::get_source_lines): Re-read
6116         fullname after calling open_source_file.
6117
6118 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6119
6120         * NEWS: Mention TLS support for FreeBSD.
6121
6122 2019-03-25  Tom Tromey  <tromey@adacore.com>
6123
6124         * minsyms.c (BUNCH_SIZE): Update comment.
6125         (~minimal_symbol_reader): Remove old comment.
6126         (compact_minimal_symbols): Update comment.
6127         (minimal_symbol_reader::install): Remove old comment.  Update
6128         other comments.
6129
6130 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6131
6132         * s390-linux-nat.c: Add include.
6133
6134 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6135
6136         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6137         Call linux_get_hwcap.
6138         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6139         Likewise.
6140         (aarch64_linux_get_hwcap): Remove function.
6141         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6142         declaration.
6143         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6144         linux_get_hwcap.
6145         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6146         * linux-tdep.c (linux_get_hwcap): Add function.
6147         (linux_get_hwcap2): Likewise.
6148         * linux-tdep.h (linux_get_hwcap): Add declaration.
6149         (linux_get_hwcap2): Likewise.
6150         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6151         (ppc_linux_get_hwcap2): Likewise.
6152         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6153         linux_get_hwcap.
6154         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6155         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6156         (ppc_linux_nat_target::read_description): Likewise.
6157         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6158         * s390-linux-nat.c: Likewise.
6159         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6160
6161 2019-03-24  Tom Tromey  <tom@tromey.com>
6162
6163         * ada-lang.c (standard_lookup): Simplify initialization.
6164         (ada_lookup_symbol_nonlocal): Simplify return.
6165         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6166         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6167         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6168         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6169         initialization.
6170         * solib.c (solib_global_lookup): Simplify.
6171         * symtab.c (null_block_symbol): Remove.
6172         (symbol_cache_lookup): Simplify returns.
6173         (lookup_language_this): Simplify returns.
6174         (lookup_symbol_aux): Simplify return.
6175         (lookup_local_symbol): Simplify returns.
6176         (lookup_global_symbol_from_objfile): Simplify return.
6177         (lookup_symbol_in_objfile_symtabs)
6178         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6179         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6180         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6181         * cp-namespace.c (cp_lookup_bare_symbol)
6182         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6183         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6184         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6185         (cp_lookup_symbol_via_imports): Simplify initialization.
6186         (find_symbol_in_baseclass): Likewise.
6187         * symtab.h (null_block_symbol): Remove.
6188         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6189         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6190         (d_lookup_symbol_module): Likewise.
6191         (find_symbol_in_baseclass): Simplify initialization.
6192
6193 2019-03-24  Tom Tromey  <tom@tromey.com>
6194
6195         * expression.h: Don't include symtab.h.
6196         (struct block): Forward declare.
6197
6198 2019-03-24  Tom Tromey  <tom@tromey.com>
6199
6200         * c-exp.y (typebase): Remove casts.
6201         * gdbtypes.c (lookup_unsigned_typename, )
6202         (lookup_signed_typename): Remove cast.
6203         * eval.c (parse_to_comma_and_eval): Remove cast.
6204         * parse.c (write_dollar_variable): Remove cast.
6205         * block.h (struct block) <superblock>: Now const.
6206         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6207         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6208         (map_block): Make "block" const.
6209         * symfile.h (struct quick_symbol_functions)
6210         <map_matching_symbols>: Constify block argument to "callback".
6211         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6212         const.
6213         (find_pc_sect_compunit_symtab): Make "b" const.
6214         (find_symbol_at_address): Likewise.
6215         (search_symbols): Likewise.
6216         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6217         (dw2_debug_names_lookup_symbol): Likewise.
6218         (dw2_map_matching_symbols): Update.
6219         * p-valprint.c (pascal_val_print): Remove "block".
6220         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6221         (aux_add_nonlocal_symbols): Make "block" const.
6222         (resolve_subexp): Remove cast.
6223         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6224         const.
6225         (iterate_over_file_blocks): Likewise.
6226         * f-exp.y (%union) <bval>: Remove.
6227         * coffread.c (patch_opaque_types): Make "b" const.
6228         * spu-tdep.c (spu_catch_start): Make "block" const.
6229         * c-valprint.c (print_unpacked_pointer): Remove "block".
6230         * symmisc.c (dump_symtab_1): Make "b" const.
6231         (block_depth): Make "block" const.
6232         * d-exp.y (%union) <bval>: Remove.
6233         * cp-support.h (cp_lookup_rtti_type): Update.
6234         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6235         * psymtab.c (psym_lookup_symbol): Make "block" const.
6236         (maintenance_check_psymtabs): Make "b" const.
6237         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6238         (enumerate_locals, enumerate_args): Update.
6239         * python/py-symtab.c (stpy_global_block): Make "block" const.
6240         (stpy_static_block): Likewise.
6241         * inline-frame.c (block_starting_point_at): Make "new_block"
6242         const.
6243         * block.c (find_block_in_blockvector): Make return type const.
6244         (blockvector_for_pc_sect): Make "b" const.
6245         (find_block_in_blockvector): Make "b" const.
6246
6247 2019-03-23  Tom Tromey  <tom@tromey.com>
6248
6249         * varobj.c (varobj_create): Update.
6250         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6251         * printcmd.c (display_command, do_one_display): Don't reset
6252         innermost_block.
6253         * parser-defs.h (enum innermost_block_tracker_type): Move to
6254         expression.h.
6255         (innermost_block): Update comment.
6256         * parse.c (parse_exp_1): Add tracker_types parameter.
6257         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6258         tracker_types parameter.  Reset innermost_block.
6259         (parse_exp_in_context): Remove.
6260         (parse_expression_for_completion): Update.
6261         * objfiles.c (~objfile): Don't reset expression_context_block or
6262         innermost_block.
6263         * expression.h (enum innermost_block_tracker_type): Move from
6264         parser-defs.h.
6265         (parse_exp_1): Add tracker_types parameter.
6266         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6267         reset innermost_block.
6268
6269 2019-03-23  Tom Tromey  <tom@tromey.com>
6270
6271         * objfiles.h: Include bcache.h.
6272
6273 2019-03-23  Tom Tromey  <tom@tromey.com>
6274
6275         * linespec.c (get_current_search_block): Use
6276         scoped_restore_current_language.
6277         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6278
6279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6280             Jiong Wang  <jiong.wang@arm.com>
6281
6282         * aarch64-linux-tdep.c
6283         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6284         section.
6285         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6286
6287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6288             Jiong Wang  <jiong.wang@arm.com>
6289
6290         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6291         instructions.
6292         (aarch64_analyze_prologue_test): Add PACIASP test.
6293         (aarch64_prologue_prev_register): Unmask PC value.
6294
6295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6296             Jiong Wang  <jiong.wang@arm.com>
6297
6298         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6299         (aarch64_dwarf2_prev_register): Unmask PC value.
6300         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6301         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6302         DW_CFA_AARCH64_negate_ra_state.
6303         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6304
6305 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6306             Jiong Wang  <jiong.wang@arm.com>
6307
6308         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6309         registers.
6310         (aarch64_pseudo_register_name): Likewise.
6311         (aarch64_pseudo_register_type): Likewise.
6312         (aarch64_pseudo_register_reggroup_p): Likewise.
6313         (aarch64_gdbarch_init): Add pauth registers.
6314         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6315         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6316         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6317         (struct gdbarch_tdep): Add regnum for ra_state.
6318
6319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6320             Jiong Wang  <jiong.wang@arm.com>
6321
6322         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6323
6324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6325             Jiong Wang  <jiong.wang@arm.com>
6326
6327         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6328         function.
6329         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6330         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6331         (aarch64_gdbarch_init): Add puth registers.
6332         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6333         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6334         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6335
6336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6337             Jiong Wang  <jiong.wang@arm.com>
6338
6339         * aarch64-linux-nat.c
6340         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6341         * aarch64-linux-tdep.c
6342         (aarch64_linux_core_read_description): Likewise.
6343         (aarch64_linux_get_hwcap): New function.
6344         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6345         (aarch64_linux_get_hwcap): New declaration.
6346
6347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6348             Jiong Wang  <jiong.wang@arm.com>
6349
6350         * aarch64-linux-nat.c
6351         (aarch64_linux_nat_target::read_description): Add pauth param.
6352         * aarch64-linux-tdep.c
6353         (aarch64_linux_core_read_description): Likewise.
6354         * aarch64-tdep.c (struct target_desc): Add in pauth.
6355         (aarch64_read_description): Add pauth param.
6356         (aarch64_gdbarch_init): Likewise.
6357         * aarch64-tdep.h (aarch64_read_description): Likewise.
6358         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6359         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6360         * features/Makefile: Add new files.
6361         * features/aarch64-pauth.c: New file.
6362         * features/aarch64-pauth.xml: New file.
6363
6364 2019-03-20  Tom Tromey  <tromey@adacore.com>
6365
6366         * infrun.c (handle_inferior_event): Rename from
6367         handle_inferior_event_1.  Create a scoped_value_mark.
6368         (handle_inferior_event): Remove.
6369
6370 2019-03-19  Tom Tromey  <tromey@adacore.com>
6371
6372         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6373         * infrun.h (print_stop_event): Add "displays" parameter.
6374         * infrun.c (print_stop_event): Add "displays" parameter.
6375
6376 2019-03-19  Pedro Alves  <palves@redhat.com>
6377
6378         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6379         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6380         to -1.  Fix TABs vs spaces.
6381         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6382         * tui/tui-out.h (tui_ui_out) Add intro comments.
6383         <m_line, m_start_of_line>: In-class initialize, and add describing
6384         comment.
6385
6386 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6387
6388         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6389         variable names.
6390         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6391
6392 2019-03-18  Pedro Alves  <palves@redhat.com>
6393             Eli Zaretskii <eliz@gnu.org>
6394
6395         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6396         m_line and m_start_of_line.
6397
6398 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6399
6400         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6401         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6402         it returns a newline.  This fixes a regression in TU mode, whereby
6403         the next line is output on the same screen line as the user input.
6404
6405 2019-03-18  Tom Tromey  <tromey@adacore.com>
6406
6407         * minsyms.c (minimal_symbol_reader::install): Remove call to
6408         obstack_blank.
6409
6410 2019-03-18  Pedro Alves  <palves@redhat.com>
6411
6412         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6413         New globals.
6414         (apply_style): New, factored out from ...
6415         (apply_ansi_escape): ... this.  Handle reverse video mode.
6416         (tui_set_reverse_mode): New function.
6417         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6418         * tui/tui-winsource.c (tui_show_source_line): Use
6419         tui_set_reverse_mode instead of setting A_STANDOUT.
6420         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6421         New setter methods.
6422
6423 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6424
6425         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6426         Handle tabs.
6427
6428 2019-03-18  Tom Tromey  <tromey@adacore.com>
6429
6430         * ada-lang.c (empty_array): Add "high" parameter.
6431         (ada_evaluate_subexp): Update.
6432
6433 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6434
6435         * unittests/string_view-selftests.c: Define
6436         _initialize_string_view_selftests unconditionally.
6437
6438 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6439
6440         PR gdb/24350
6441         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6442
6443 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6444
6445         PR gdb/24351
6446         * windows-nat.c (display_selector): Fix format specifiers.
6447
6448 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6449
6450         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6451         tui_refill_source_window instead of tui_refresh_win, to update the
6452         current execution line.  This fixes redisplay of the current line
6453         when stepping through the code with "next" or "step".
6454
6455 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6456
6457         * source-cache.c (source_cache::get_source_lines): Call
6458         find_source_lines to initialize s->nlines.  This fixes vertical
6459         scrolling of TUI source window when the DOWN arrow is pressed.
6460
6461 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6462
6463         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6464         linux-thread-db.c (_initialize_thread_db): Likewise.
6465
6466 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6467
6468         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6469         wclrtoeol in tui_show_source_line".  This reverts changes made in
6470         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6471
6472 2019-03-15  Tom Tromey  <tom@tromey.com>
6473
6474         * symtab.h (struct minimal_symbol): Derive from
6475         general_symbol_info.
6476         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6477         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6478         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6479         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6480         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6481         (MSYMBOL_SEARCH_NAME): Update.
6482         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6483         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6484         * minsyms.c (minimal_symbol_reader::record_full): Update.
6485
6486 2019-03-15  Tom Tromey  <tom@tromey.com>
6487
6488         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6489
6490 2019-03-15  Tom Tromey  <tom@tromey.com>
6491
6492         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6493         unique_xmalloc_ptr.
6494         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6495         Update.
6496         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6497         (build_minimal_symbol_hash_tables)
6498         (minimal_symbol_reader::install): Update.
6499
6500 2019-03-15  Tom Tromey  <tom@tromey.com>
6501
6502         * symtab.c (create_demangled_names_hash): Update.
6503         (symbol_set_names): Update.
6504         * objfiles.h (struct objfile_per_bfd_storage)
6505         <demangled_names_hash>: Now an htab_up.
6506         * objfiles.c (objfile_per_bfd_storage): Simplify.
6507
6508 2019-03-15  Tom Tromey  <tom@tromey.com>
6509
6510         * objfiles.h (struct objfile_per_bfd_storage): Declare
6511         destructor.
6512         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6513         New.
6514         (get_objfile_bfd_data): Use new.  Don't initialize
6515         language_of_main.
6516         (free_objfile_per_bfd_storage): Remove.
6517         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6518
6519 2019-03-15  Tom Tromey  <tom@tromey.com>
6520
6521         * symfile.c (reread_symbols): Update.
6522         * objfiles.c (objfile::objfile): Update.
6523         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6524         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6525         comment.
6526         (minimal_symbol_reader::install): Update.
6527         (terminate_minimal_symbol_table): Remove.
6528         * jit.c (jit_object_close_impl): Update.
6529
6530 2019-03-15  Tom Tromey  <tom@tromey.com>
6531
6532         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6533         initializations.
6534
6535 2019-03-15  Tom Tromey  <tom@tromey.com>
6536
6537         * objfiles.h (struct objfile_per_bfd_storage)
6538         <demangled_hash_languages>: Now a bitset.
6539         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6540         (lookup_minimal_symbol): Update.
6541
6542 2019-03-15  Tom Tromey  <tom@tromey.com>
6543
6544         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6545         Don't return the symbol.
6546         * coffread.c (record_minimal_symbol): Use record_full.
6547
6548 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6549
6550         The MS-Windows port of ncurses fails to switch to a color pair if
6551         one or both of the colors are the implicit default colors.  This
6552         change records the default colors when TUI is initialized, and
6553         then specifies them explicitly when a color pair uses the default
6554         colors.  This allows color styling in TUI mode on MS-Windows.
6555
6556         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6557         ncurses_norm_attr.
6558         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6559         colors in ncurses_norm_attr.
6560         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6561         "none", replace it with the default color recorded in
6562         ncurses_norm_attr.
6563
6564 2019-03-14  Tom Tromey  <tromey@adacore.com>
6565
6566         * source-cache.h (class source_cache) <get_source_lines>: Return
6567         std::string.
6568         * source-cache.c (source_cache::extract_lines): Handle case where
6569         first_pos==npos.  Return std::string.
6570         (source_cache::get_source_lines): Update.
6571
6572 2019-03-14  Tom Tromey  <tromey@adacore.com>
6573
6574         * NEWS: Add item for "style sources" commands.
6575         * source-cache.c (source_cache::get_source_lines): Check
6576         source_styling.
6577         * cli/cli-style.c (source_styling): New global.
6578         (_initialize_cli_style): Add "style sources" commands.
6579         (show_style_sources): New function.
6580         * cli/cli-style.h (source_styling): Declare.
6581
6582 2019-03-14  Pedro Alves  <palves@redhat.com>
6583             Tom Tromey  <tromey@adacore.com>
6584
6585         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6586         * tui/tui-winsource.c (tui_refill_source_window): New function,
6587         from...
6588         (tui_horizontal_source_scroll): ... here.  Move some logic.
6589         * cli/cli-style.c (set_style_enabled): Notify new observable.
6590         * tui/tui-hooks.c (tui_redisplay_source): New function.
6591         (tui_attach_detach_observers): Attach or detach
6592         tui_redisplay_source.
6593         * observable.h (source_styling_changed): New observable.
6594         * observable.c: Define source_styling_changed observable.
6595
6596 2019-03-13  Tom Tromey  <tromey@adacore.com>
6597
6598         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6599         (i386_gnu_nat_target::store_registers): Update.
6600         * target-debug.h (target_debug_print_std_string): New macro.
6601         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6602         * windows-tdep.c (display_one_tib): Update.
6603         * tui/tui-stack.c (tui_make_status_line): Update.
6604         * top.c (print_inferior_quit_action): Update.
6605         * thread.c (thr_try_catch_cmd): Update.
6606         (add_thread_with_info): Update.
6607         (thread_target_id_str): Update.
6608         (thr_try_catch_cmd): Update.
6609         (thread_command): Update.
6610         (thread_find_command): Update.
6611         * record-btrace.c (record_btrace_target::info_record)
6612         (record_btrace_resume_thread, record_btrace_target::resume)
6613         (record_btrace_cancel_resume, record_btrace_step_thread)
6614         (record_btrace_target::wait, record_btrace_target::wait)
6615         (record_btrace_target::wait, record_btrace_target::stop): Update.
6616         * progspace.c (print_program_space): Update.
6617         * process-stratum-target.c
6618         (process_stratum_target::thread_address_space): Update.
6619         * linux-fork.c (linux_fork_mourn_inferior)
6620         (detach_checkpoint_command, info_checkpoints_command)
6621         (linux_fork_context): Update.
6622         (linux_fork_detach): Update.
6623         (class scoped_switch_fork_info): Update.
6624         (delete_checkpoint_command): Update.
6625         * infrun.c (follow_fork_inferior): Update.
6626         (follow_fork_inferior): Update.
6627         (proceed_after_vfork_done): Update.
6628         (handle_vfork_child_exec_or_exit): Update.
6629         (follow_exec): Update.
6630         (displaced_step_prepare_throw): Update.
6631         (displaced_step_restore): Update.
6632         (start_step_over): Update.
6633         (resume_1): Update.
6634         (clear_proceed_status_thread): Update.
6635         (proceed): Update.
6636         (print_target_wait_results): Update.
6637         (do_target_wait): Update.
6638         (context_switch): Update.
6639         (stop_all_threads): Update.
6640         (restart_threads): Update.
6641         (finish_step_over): Update.
6642         (handle_signal_stop): Update.
6643         (switch_back_to_stepped_thread): Update.
6644         (keep_going_pass_signal): Update.
6645         (print_exited_reason): Update.
6646         (normal_stop): Update.
6647         * inferior.c (inferior_pid_to_str): Change return type.
6648         (print_selected_inferior): Update.
6649         (add_inferior): Update.
6650         (detach_inferior): Update.
6651         * dummy-frame.c (fprint_dummy_frames): Update.
6652         * dcache.c (dcache_info_1): Update.
6653         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6654         (btrace_fetch, btrace_clear): Update.
6655         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6656         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6657         type.
6658         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6659         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6660         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6661         * gdbarch.c, gdbarch.h: Rebuild.
6662         * gdbarch.sh (core_pid_to_str): Change return type.
6663         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6664         return type.
6665         (windows_nat_target::pid_to_str): Change return type.
6666         (windows_delete_thread): Update.
6667         (windows_nat_target::attach): Update.
6668         (windows_nat_target::files_info): Update.
6669         * target-delegates.c: Rebuild.
6670         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6671         return type.
6672         (sol_thread_target::pid_to_str): Change return type.
6673         * remote.c (class remote_target) <pid_to_str>: Change return
6674         type.
6675         (remote_target::pid_to_str): Change return type.
6676         (extended_remote_target::attach, remote_target::remote_stop_ns)
6677         (remote_target::remote_notif_remove_queued_reply)
6678         (remote_target::push_stop_reply, remote_target::disable_btrace):
6679         Update.
6680         (extended_remote_target::attach): Update.
6681         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6682         type.
6683         (gdbsim_target::pid_to_str): Change return type.
6684         * ravenscar-thread.c (struct ravenscar_thread_target)
6685         <pid_to_str>: Change return type.
6686         (ravenscar_thread_target::pid_to_str): Change return type.
6687         * procfs.c (class procfs_target) <pid_to_str>: Change return
6688         type.
6689         (procfs_target::pid_to_str): Change return type.
6690         (procfs_target::attach): Update.
6691         (procfs_target::detach): Update.
6692         (procfs_target::fetch_registers): Update.
6693         (procfs_target::store_registers): Update.
6694         (procfs_target::wait): Update.
6695         (procfs_target::files_info): Update.
6696         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6697         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6698         return type.
6699         (nto_procfs_target::pid_to_str): Change return type.
6700         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6701         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6702         return type.
6703         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6704         (exit_lwp): Update.
6705         (attach_proc_task_lwp_callback, get_detach_signal)
6706         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6707         (linux_nat_target::resume, wait_lwp, stop_callback)
6708         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6709         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6710         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6711         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6712         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6713         type.
6714         (inf_ptrace_target::attach): Update.
6715         (inf_ptrace_target::files_info): Update.
6716         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6717         type.
6718         (go32_nat_target::pid_to_str): Change return type.
6719         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6720         (gnu_nat_target::wait): Update.
6721         (gnu_nat_target::wait): Update.
6722         (gnu_nat_target::resume): Update.
6723         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6724         (fbsd_nat_target::wait): Update.
6725         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6726         type.
6727         (darwin_nat_target::attach): Update.
6728         * corelow.c (class core_target) <pid_to_str>: Change return type.
6729         (core_target::pid_to_str): Change return type.
6730         * target.c (normal_pid_to_str): Change return type.
6731         (default_pid_to_str): Likewise.
6732         (target_pid_to_str): Change return type.
6733         (target_translate_tls_address): Update.
6734         (target_announce_detach): Update.
6735         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6736         return type.
6737         (bsd_uthread_target::pid_to_str): Change return type.
6738         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6739         type.
6740         (bsd_kvm_target::pid_to_str): Change return type.
6741         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6742         return type.
6743         (aix_thread_target::pid_to_str): Change return type.
6744         * target.h (struct target_ops) <pid_to_str>: Change return type.
6745         (target_pid_to_str, normal_pid_to_str): Likewise.
6746         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6747         type.
6748         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6749         type.
6750         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6751         return type.
6752         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6753         type.
6754         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6755         type.
6756         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6757         return type.
6758
6759 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6760
6761         * NEWS: Mention that the new default MI version is 3.  Mention
6762         changes to the output of commands and events that deal with
6763         multi-location breakpoints.
6764         * breakpoint.c: Include "mi/mi-out.h".
6765         (print_one_breakpoint): Change output syntax if using MI version
6766         >= 3.
6767         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6768         New.
6769         (mi_multi_location_breakpoint_output_fixed): New.
6770         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6771         (mi_cmd_fix_multi_location_breakpoint_output): New.
6772         (mi_multi_location_breakpoint_output_fixed): New.
6773         * mi/mi-cmds.c (mi_cmds): Register command
6774         -fix-multi-location-breakpoint-output.
6775         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6776         interpreter "mi".
6777
6778 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6779
6780         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6781         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6782         instantiate mi_ui_out based on interpreter name.
6783         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6784         * mi/mi-main.c (mi_load_progress): Likewise.
6785
6786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6787
6788         * NEWS: Combine separate "New targets" sections for 8.3.
6789
6790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6791
6792         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6793         (ppcfbsd_init_abi): Install gdbarch
6794         "fetch_tls_load_module_address" and "get_thread_local_address"
6795         methods.
6796
6797 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6798
6799         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6800         (riscv_fbsd_init_abi): Install gdbarch
6801         "fetch_tls_load_module_address" and "get_thread_local_address"
6802         methods.
6803
6804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6805
6806         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6807         (i386fbsd_init_abi): Install gdbarch
6808         "fetch_tls_load_module_address" and "get_thread_local_address"
6809         methods.
6810
6811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6812
6813         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6814         (amd64fbsd_init_abi): Install gdbarch
6815         "fetch_tls_load_module_address" and "get_thread_local_address"
6816         methods.
6817
6818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6819
6820         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6821         (struct fbsd_pspace_data): New type.
6822         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6823         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6824         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6825         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6826         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6827
6828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6829
6830         * gdbtypes.c (lookup_struct_elt): New function.
6831         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6832         * gdbtypes.h (struct struct_elt): New type.
6833         (lookup_struct_elt): New prototype.
6834
6835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6836
6837         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6838         remove disabled code block.
6839
6840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6841
6842         * gdbarch.sh (get_thread_local_address): New method.
6843         * gdbarch.h, gdbarch.c: Regenerate.
6844         * target.c (target_translate_tls_address): Use
6845         gdbarch_get_thread_local_address if present instead of
6846         target::get_thread_local_address.
6847
6848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6849
6850         * target.h (target::get_thread_local_address): Update comment.
6851
6852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6853
6854         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6855         objfile->separate_debug_objfile_backlink if not NULL.
6856
6857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6858
6859         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6860         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6861         (amd64bsd_store_inferior_registers): Likewise.
6862         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6863         Enable segment base registers.
6864         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6865         PT_GETFSBASE and PT_GETGSBASE.
6866         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6867         PT_SETGSBASE.
6868         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6869         segment base registers.
6870         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6871
6872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6873
6874         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6875         Update calls to i386_target_description to add 'segments'
6876         parameter.
6877         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6878         add segment base registers.
6879         * arch/i386.c (i386_create_target_description): Add 'segments'
6880         parameter to enable segment base registers.
6881         * arch/i386.h (i386_create_target_description): Likewise.
6882         * features/i386/32bit-segments.xml: New file.
6883         * features/i386/32bit-segments.c: Generate.
6884         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6885         call to i386_target_description to add 'segments' parameter.
6886         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6887         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6888         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6889         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6890         if feature is present.
6891         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6892         Add 'segments' parameter to call to i386_target_description.
6893         (i386_target_description): Add 'segments' parameter to enable
6894         segment base registers.
6895         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6896         to call to i386_target_description.
6897         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6898         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6899         Define I386_NUM_REGS.
6900         (i386_target_description): Add 'segments' parameter to enable
6901         segment base registers.
6902
6903 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6904
6905         PR/24325
6906         * source-cache.c: #undef open and close, to avoid unresolved
6907         externals during linking.
6908
6909 2019-03-12  Tom Tromey  <tromey@adacore.com>
6910
6911         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6912         const.  Add initializers.
6913         (_initialize_remote): Don't initialize ptid globals.
6914
6915 2019-03-12  Pedro Alves  <palves@redhat.com>
6916
6917         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6918
6919 2019-03-12  Pedro Alves  <palves@redhat.com>
6920
6921         * cp-name-parser.y (main): Remove unused 'len' variable.
6922
6923 2019-03-12  Tom Tromey  <tromey@adacore.com>
6924
6925         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6926         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6927
6928 2019-03-12  Tom Tromey  <tromey@adacore.com>
6929
6930         * linux-nat.c (iterate_over_lwps): Update.
6931         (stop_callback): Remove parameter.
6932         (stop_wait_callback, detach_callback, resume_set_callback)
6933         (select_singlestep_lwp_callback, set_ignore_sigint)
6934         (status_callback, resumed_callback, resume_clear_callback)
6935         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6936         data parameter.
6937         (linux_nat_target::detach, linux_nat_target::resume)
6938         (linux_stop_and_wait_all_lwps, select_event_lwp)
6939         (linux_nat_filter_event, linux_nat_wait_1)
6940         (linux_nat_target::kill, linux_nat_target::stop)
6941         (linux_nat_target::stop): Update.
6942         (linux_nat_resume_callback): Change type.
6943         (resume_stopped_resumed_lwps, count_events_callback)
6944         (select_event_lwp_callback): Likewise.
6945         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6946         * arm-linux-nat.c (struct update_registers_data): Remove.
6947         (update_registers_callback): Change type.
6948         (arm_linux_insert_hw_breakpoint1): Update.
6949         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6950         parameter.
6951         (x86_linux_dr_set_addr): Update.
6952         (x86_linux_dr_set_control): Update.
6953         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6954         (iterate_over_lwps): Use gdb::function_view.
6955         * nat/aarch64-linux-hw-point.c (struct
6956         aarch64_dr_update_callback_param): Remove.
6957         (debug_reg_change_callback): Change type.
6958         (aarch64_notify_debug_reg_change): Update.
6959         * s390-linux-nat.c (s390_refresh_per_info): Update.
6960
6961 2019-03-11  Tom Tromey  <tromey@adacore.com>
6962
6963         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6964         redundant assignment to "this_cu".
6965
6966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6967
6968         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6969
6970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6971
6972         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6973         from...
6974         (rank_one_type): ... this.
6975
6976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6977
6978         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6979         from...
6980         (rank_one_type): ... this.
6981
6982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6983
6984         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6985         from...
6986         (rank_one_type): ... this.
6987
6988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6989
6990         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6991         from...
6992         (rank_one_type): ... this.
6993
6994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6995
6996         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6997         from...
6998         (rank_one_type): ... this.
6999
7000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7001
7002         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7003         from...
7004         (rank_one_type): ... this.
7005
7006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7007
7008         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7009         from...
7010         (rank_one_type): ... this.
7011
7012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7013
7014         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7015         from...
7016         (rank_one_type): ... this.
7017
7018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7019
7020         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7021         from...
7022         (rank_one_type): ... this.
7023
7024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7025
7026         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7027         from...
7028         (rank_one_type): ... this.
7029
7030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7031
7032         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7033         from...
7034         (rank_one_type): ... this.
7035
7036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7037
7038         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7039         from...
7040         (rank_one_type): ... this.
7041
7042 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7043
7044         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7045         inferior-events' shows the example events.
7046
7047 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7048
7049         Support styling on native MS-Windows console
7050
7051         PR/24315
7052         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7053         on MS-Windows if $TERM is not defined.
7054
7055         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7056
7057         * posix-hdep.c (gdb_console_fputs):
7058         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7059         functions.
7060         * ui-file.h (gdb_console_fputs): Add prototype.
7061
7062         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7063         back to fputs only if the former returns zero.
7064
7065 2019-03-07  Tom Tromey  <tom@tromey.com>
7066
7067         * symmisc.c (print_symbol_bcache_statistics): Update.
7068         (print_objfile_statistics): Update.
7069         * symfile.c (allocate_symtab): Update.
7070         * stabsread.c: Don't include bcache.h.
7071         * psymtab.h (struct psymbol_bcache): Don't declare.
7072         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7073         (psymbol_bcache_init, psymbol_bcache_free)
7074         (psymbol_bcache_get_bcache): Don't declare.
7075         * psymtab.c (struct psymbol_bcache): Remove.
7076         (psymtab_storage::psymtab_storage): Update.
7077         (psymtab_storage::~psymtab_storage): Update.
7078         (psymbol_bcache_init, psymbol_bcache_free)
7079         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7080         (add_psymbol_to_bcache): Update.
7081         (allocate_psymtab): Update.
7082         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7083         macro_cache>: No longer pointers.
7084         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7085         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7086         * macrotab.c (macro_bcache): Update.
7087         * macroexp.c: Don't include bcache.h.
7088         * gdbtypes.c (check_types_worklist): Update.
7089         (types_deeply_equal): Remove TRY/CATCH.  Update.
7090         * elfread.c (elf_symtab_read): Update.
7091         * dwarf2read.c: Don't include bcache.h.
7092         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7093         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7094         (print_bcache_statistics, bcache_memory_used): Don't declare.
7095         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7096         methods.  Rename all data members.
7097         * bcache.c (struct bcache): Move to bcache.h.
7098         (bcache::expand_hash_table): Rename from expand_hash_table.
7099         (bcache): Remove.
7100         (bcache::insert): Rename from bcache_full.
7101         (bcache::compare): Rename from bcache_compare.
7102         (bcache_xmalloc): Remove.
7103         (bcache::~bcache): Rename from bcache_xfree.
7104         (bcache::print_statistics): Rename from print_bcache_statistics.
7105         (bcache::memory_used): Rename from bcache_memory_used.
7106
7107 2019-03-07  Pedro Alves  <palves@redhat.com>
7108
7109         * infrun.c (normal_stop): Also check for
7110         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7111
7112 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * f-lang.c (value_from_host_double): Moved to...
7115         * value.c (value_from_host_double): ...here.
7116         * value.h (value_from_host_double): Declare.
7117         * guile/scm-math.c (vlscm_convert_typed_number): Use
7118         value_from_host_double.
7119         (vlscm_convert_number): Likewise.
7120         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7121         * python/py-value.c (convert_value_from_python): Likewise.
7122
7123 2019-03-06  Tom Tromey  <tom@tromey.com>
7124
7125         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7126
7127 2019-03-06  Tom Tromey  <tom@tromey.com>
7128
7129         * utils.h (free_current_contents): Don't declare.
7130         * utils.c (free_current_contents): Remove.
7131
7132 2019-03-06  Tom Tromey  <tom@tromey.com>
7133
7134         * top.c (quit_force): Update.
7135         * main.c (captured_command_loop): Update.
7136         * common/new-op.c (operator new): Update.
7137         * common/common-exceptions.c (struct catcher)
7138         <save_cleanup_chain>: Remove member.
7139         (exceptions_state_mc_init): Update.
7140         (exception_try_scope_entry): Return nullptr.
7141         (exception_try_scope_exit, exception_rethrow)
7142         (throw_exception_sjlj, throw_exception_cxx): Update.
7143         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7144         (all_cleanups, do_cleanups, discard_cleanups)
7145         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7146         (restore_cleanups, restore_final_cleanups): Don't declare.
7147         (do_final_cleanups): Remove parameter.
7148         * common/cleanups.c (cleanup_chain, make_cleanup)
7149         (make_cleanup_dtor, all_cleanups, do_cleanups)
7150         (discard_my_cleanups, discard_cleanups)
7151         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7152         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7153         (null_cleanup): Remove.
7154         (do_final_cleanups): Remove parameter.
7155
7156 2019-03-06  Tom Tromey  <tom@tromey.com>
7157
7158         * remote.c (remote_target::remote_parse_stop_reply): Use
7159         unique_xmalloc_ptr.
7160
7161 2019-03-06  Tom Tromey  <tom@tromey.com>
7162
7163         * stabsread.c (struct stabs_field_info): Rename from field_info.
7164         <list, fnlist>: Add initializers.
7165         <obstack>: New member.
7166         (read_member_functions, read_struct_fields, read_baseclasses):
7167         Allocate on obstack.  Don't use cleanups.
7168         (read_one_struct_field, read_member_functions, read_struct_fields)
7169         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7170         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7171         (read_struct_type): Update.
7172
7173 2019-03-06  Tom Tromey  <tom@tromey.com>
7174
7175         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7176         * common/filestuff.h (make_cleanup_close): Don't declare.
7177         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7178         Remove.
7179
7180 2019-03-06  Tom Tromey  <tom@tromey.com>
7181
7182         * solib-aix.c: Use make_scope_exit.
7183
7184 2019-03-06  Tom Tromey  <tom@tromey.com>
7185
7186         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7187         Use make_scope_exit.
7188
7189 2019-03-06  Tom Tromey  <tom@tromey.com>
7190
7191         * solib-svr4.c (disable_probes_interface): Remove parameter.
7192         (svr4_handle_solib_event): Use make_scope_exit.
7193
7194 2019-03-06  Tom Tromey  <tom@tromey.com>
7195
7196         * remote.c (struct stop_reply_deleter): Remove.
7197         (stop_reply_up): Update.
7198         (struct stop_reply): Derive from notif_event.  Don't typedef.
7199         <regcache>: Now a std::vector.
7200         (stop_reply_xfree): Remove.
7201         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7202         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7203         (remote_target::discard_pending_stop_replies): Use delete.
7204         (remote_target::remote_parse_stop_reply): Update.
7205         (remote_target::process_stop_reply): Update.
7206         * remote-notif.h (struct notif_event): Add virtual destructor.
7207         Remove "dtr" member.
7208         (struct notif_client) <alloc_event>: Return a unique_ptr.
7209         (notif_event_xfree): Don't declare.
7210         (notif_event_up): New typedef.
7211         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7212         (notif_event_xfree, do_notif_event_xfree): Remove.
7213         (remote_notif_state_xfree): Update.
7214
7215 2019-03-06  Tom Tromey  <tom@tromey.com>
7216
7217         * infrun.c (displaced_step_clear_cleanup): Now a
7218         forward_scope_exit type.
7219         (displaced_step_prepare_throw): Update.
7220         (displaced_step_fixup): Update.
7221
7222 2019-03-06  Tom Tromey  <tom@tromey.com>
7223
7224         * inferior.h (class inferior): Update comment.
7225         * gdbthread.h (class thread_info): Update comment.
7226
7227 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7228             Tom Tromey  <tom@tromey.com>
7229
7230         * stabsread.h (struct stab_section_list): Remove.
7231         (coffstab_build_psymtabs): Update.
7232         * dbxread.c (symbuf_sections): Now a std::vector.
7233         (sect_idx): New global.
7234         (fill_symbuf): Update.
7235         (coffstab_build_psymtabs): Change type of stabsects parameter.
7236         Update.
7237         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7238         std::vector.
7239         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7240         (coff_locate_sections): Update.
7241         (coff_symfile_read): Remove cleanups.  Update.
7242         (init_stringtab): Add storage parameter.
7243         (free_stringtab, free_stringtab_cleanup): Remove.
7244         (init_lineno): Add storage parameter.
7245         (free_linetab, free_linetab_cleanup): Remove.
7246
7247 2019-03-06  Pedro Alves  <palves@redhat.com>
7248
7249         * linux-fork.c (fork_info::clobber_regs): Delete.
7250         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7251         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7252         comment.  Adjust.
7253         (scoped_switch_fork_info::scoped_switch_fork_info)
7254         (checkpoint_command, linux_fork_context): Adjust
7255         fork_save_infrun_state calls.
7256
7257 2019-03-06  Pedro Alves  <palves@redhat.com>
7258
7259         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7260         (inf_has_multiple_threads): Return 'bool' and rewrite using
7261         inferior_info::threads().
7262
7263 2019-03-06  Pedro Alves  <palves@redhat.com>
7264
7265         * linux-fork.c: Include <list>.
7266         (fork_list): Now a std::list instance.
7267         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7268         (forks_exist_p, find_last_fork): Adjust.
7269         (new_fork): Delete.
7270         (one_fork_p): New.
7271         (add_fork): Adjust.
7272         (free_fork): Delete, folded into fork_info::~fork_info().
7273         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7274         Adjust.
7275         (init_fork_list): Delete.
7276         (linux_fork_killall, linux_fork_mourn_inferior)
7277         (linux_fork_detach, info_checkpoints_command): Adjust.
7278         (_initialize_linux_fork): No longer call init_fork_list.
7279
7280 2019-03-06  Pedro Alves  <palves@redhat.com>
7281
7282         * linux-fork.c (new_fork): New, split out of ...
7283         (add_fork): ... this.  Return void.  Move "first fork" special
7284         case from here, to ...
7285         (checkpoint_command): ... here.
7286         * linux-linux.h (add_fork): Return void.
7287
7288 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7291
7292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7293             Chris January  <chris.january@arm.com>
7294             David Lecomber  <david.lecomber@arm.com>
7295
7296         * f-exp.y: New token, UNOP_INTRINSIC.
7297         (exp): New pattern using UNOP_INTRINSIC token.
7298         (f77_keywords): Add 'abs' keyword.
7299         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7300         (value_from_host_double): New function.
7301         (evaluate_subexp_f): Support UNOP_ABS.
7302
7303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7306         types.
7307
7308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7309
7310         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7311         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7312         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7313
7314 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7317
7318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7319             Chris January  <chris.january@arm.com>
7320
7321         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7322         * f-exp.y: Define 'KIND' token.
7323         (exp): New pattern for KIND expressions.
7324         (ptype): Handle types with a kind extension.
7325         (direct_abs_decl): Extend to spot kind extensions.
7326         (f77_keywords): Add 'kind' to the list.
7327         (push_kind_type): New function.
7328         (convert_to_kind_type): New function.
7329         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7330         * parse.c (operator_length_standard): Likewise.
7331         * parser-defs.h (enum type_pieces): Add tp_kind.
7332         * std-operator.def: Add UNOP_KIND.
7333
7334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7335
7336         * f-exp.y (f_parse): Set yydebug.
7337
7338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * f-lang.c (evaluate_subexp_f): New function.
7341         (exp_descriptor_f): New global.
7342         (f_language_defn): Use exp_descriptor_f instead of
7343         exp_descriptor_standard.
7344
7345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7346
7347         * f-exp.y (struct token): Add comments.
7348         (dot_ops): Remove uppercase versions and the end marker.
7349         (f77_keywords): Likewise.
7350         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7351         entries in the dot_ops array are case insensitive, and use
7352         strncasecmp to compare strings.  Also some whitespace cleanup in
7353         this area.  Similar for the f77_keywords array, except entries in
7354         this list might be case sensitive.
7355
7356 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * f-exp.y (struct f77_boolean_val): Add comments.
7359         (boolean_values): Remove uppercase versions, and end marker.
7360         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7361         and use strncasecmp to achieve case insensitivity.  Additionally,
7362         perform whitespace cleanup around this code.
7363
7364 2019-03-06  Tom Tromey  <tromey@adacore.com>
7365
7366         * remote-sim.c (gdbsim_target_open): Use result of
7367         gdb_argv::release.
7368
7369 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7370         Dirk Schubert  <dirk.schubert@arm.com>
7371         Chris January  <chris.january@arm.com>
7372
7373         * eval.c (evaluate_subexp_standard): Call Fortran argument
7374         wrapping logic.
7375         * f-lang.c (struct value): A value which can be passed into a
7376         Fortran function call.
7377         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7378         where appropriate.
7379         (struct type): Value ready for a Fortran function call.
7380         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7381         is needed.
7382         * f-lang.h (fortran_argument_convert): Declaration.
7383         (fortran_preserve_arg_pointer): Declaration.
7384         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7385
7386 2019-03-05  Tom Tromey  <tromey@adacore.com>
7387
7388         * python/py-prettyprint.c (print_string_repr): Remove #if.
7389         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7390
7391 2019-03-05  Tom Tromey  <tromey@adacore.com>
7392
7393         * target.c (the_dummy_target): Move later.  Change type to
7394         "dummy_target".
7395         (initialize_targets): Don't initialize the_dummy_target.
7396
7397 2019-03-05  Tom Tromey  <tromey@adacore.com>
7398
7399         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7400         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7401
7402 2019-03-05  Tom Tromey  <tromey@adacore.com>
7403
7404         * windows-nat.c (windows_nat_target::attach)
7405         (windows_nat_target::detach): Don't call gdb_flush.
7406         * valprint.c (generic_val_print, val_print, val_print_string):
7407         Don't call gdb_flush.
7408         * utils.c (defaulted_query): Don't call gdb_flush.
7409         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7410         * target.c (target_announce_detach): Don't call gdb_flush.
7411         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7412         * remote.c (extended_remote_target::attach): Don't call
7413         gdb_flush.
7414         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7415         * printcmd.c (do_examine): Don't call gdb_flush.
7416         (info_display_command): Don't call gdb_flush.
7417         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7418         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7419         * memattr.c (info_mem_command): Don't call gdb_flush.
7420         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7421         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7422         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7423         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7424         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7425         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7426         (gnu_nat_target::detach): Don't call gdb_flush.
7427         * f-valprint.c (f_val_print): Don't call gdb_flush.
7428         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7429         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7430         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7431         gdb_flush.
7432         * c-valprint.c (c_val_print): Don't call gdb_flush.
7433         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7434
7435 2019-03-05  Tom Tromey  <tromey@adacore.com>
7436
7437         * varobj.c (update_dynamic_varobj_children): Update.
7438         (install_default_visualizer): Use reset, not release.
7439         * value.c (set_internalvar): Update.
7440         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7441         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7442         ATTRIBUTE_UNUSED_RESULT.
7443
7444 2019-03-05  Tom Tromey  <tromey@adacore.com>
7445
7446         * remote.c (class scoped_remote_fd) <release>: Add
7447         ATTRIBUTE_UNUSED_RESULT.
7448
7449 2019-03-05  Tom Tromey  <tromey@adacore.com>
7450
7451         * macroexp.c (struct macro_buffer) <release>: Add
7452         ATTRIBUTE_UNUSED_RESULT.
7453
7454 2019-03-05  Tom Tromey  <tromey@adacore.com>
7455
7456         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7457         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7458         ATTRIBUTE_UNUSED_RESULT.
7459
7460 2019-03-05  Tom Tromey  <tromey@adacore.com>
7461
7462         * common/scoped_fd.h (class scoped_fd) <release>: Add
7463         ATTRIBUTE_UNUSED_RESULT.
7464
7465 2019-03-05  Tom Tromey  <tromey@adacore.com>
7466
7467         * parser-defs.h (struct parser_state) <release>: Add
7468         ATTRIBUTE_UNUSED_RESULT.
7469
7470 2019-03-05  Tom Tromey  <tromey@adacore.com>
7471
7472         * utils.h (class gdb_argv) <release>: Add
7473         ATTRIBUTE_UNUSED_RESULT.
7474         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7475
7476 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7477
7478         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7479         for-loop range, to avoid compiler warnings.
7480
7481         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7482         avoid compiler warnings about unused variables.
7483
7484         * NEWS: Mention end of support for native debugging on MS-Windows
7485         before XP.
7486
7487         PR gdb/24292
7488         * common/netstuff.c:
7489         * gdbserver/gdbreplay.c
7490         * gdbserver/remote-utils.c:
7491         * ser-tcp.c:
7492         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7493         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7494         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7495         'getaddrinfo' and 'freeaddrinfo' were not available before
7496         Windows XP, and mingw.org's MinGW headers by default define
7497         _WIN32_WINNT to 0x500.
7498
7499 2019-03-01  Gary Benson <gbenson@redhat.com>
7500
7501         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7502
7503 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7504             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7505
7506         PR gdb/8527
7507         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7508         set_sigint_trap, clear_sigint_trap.
7509
7510 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7511
7512         * target.c (target_detach): Clear the regcache and the
7513         frame cache.
7514
7515 2019-02-27  Pedro Alves  <palves@redhat.com>
7516
7517         * utils.c (set_screen_size): When we cap the height/width sizes,
7518         tweak the corresponding command variable to show "unlimited":
7519
7520 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7521             Pedro Alves  <palves@redhat.com>
7522
7523         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7524         before calling rl_set_screen_size.
7525
7526 2019-02-27  Tom Tromey  <tromey@adacore.com>
7527
7528         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7529         define.
7530         * python/py-value.c: Remove Python 2.4 workaround.
7531         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7532         workaround.
7533         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7534         Python 2.4 workaround.
7535         * python/python-internal.h: Remove Python 2.4 comment.
7536         (Py_ssize_t): Don't define.
7537         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7538         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7539         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7540         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7541         * python/python.c (do_start_initialization): Remove Python 2.4
7542         workaround.
7543         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7544         (print_children): Remove Python 2.4 workaround.
7545         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7546         workaround.
7547         (CHARBUFFERPROC_NAME): Remove.
7548         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7549         Python 2.4 workaround.
7550
7551 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7552
7553         * NEWS: Note minimum Python version.
7554
7555 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7556
7557         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7558         code from these functions.  Remove corresponding ifdefs.  Use
7559         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7560         Remove gotos and target of gotos.
7561         (infpy_search_memory): Likewise.
7562
7563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7566         (hppa_gdbarch_init): Don't register deleted functions with
7567         gdbarch.
7568
7569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7572         (h8300_unwind_sp): Delete.
7573         (h8300_dummy_id): Delete.
7574         (h8300_gdbarch_init): Don't register deleted functions with
7575         gdbarch.
7576
7577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7578
7579         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7580         (ft32_unwind_pc): Delete.
7581         (ft32_unwind_sp): Delete.
7582         (ft32_gdbarch_init): Don't register deleted functions with
7583         gdbarch.
7584
7585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7586
7587         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7588         (frv_unwind_pc): Delete.
7589         (frv_unwind_sp): Delete.
7590         (frv_gdbarch_init): Don't register deleted functions with
7591         gdbarch.
7592
7593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7596         (riscv_unwind_pc): Delete.
7597         (riscv_unwind_sp): Delete.
7598         (riscv_gdbarch_init): Don't register deleted functions with
7599         gdbarch.
7600
7601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7604         (csky_unwind_pc): Delete.
7605         (csky_unwind_sp): Delete.
7606         (csky_gdbarch_init): Don't register deleted functions with
7607         gdbarch.
7608
7609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7612         (cris_unwind_pc): Delete.
7613         (cris_unwind_sp): Delete.
7614         (cris_gdbarch_init): Don't register deleted functions with
7615         gdbarch.
7616
7617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7620         (bfin_unwind_pc): Delete.
7621         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7622
7623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7624
7625         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7626         (arm_unwind_pc): Delete.
7627         (arm_unwind_sp): Delete.
7628         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7629
7630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7633         (arc_unwind_pc): Delete.
7634         (arc_unwind_sp): Delete.
7635         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7636
7637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7640         (alpha_unwind_pc): Delete.
7641         (alpha_gdbarch_init): Don't register deleted functions with
7642         gdbarch.
7643
7644 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7645
7646         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7647         (aarch64_unwind_pc): Delete.
7648         (aarch64_unwind_sp): Delete.
7649         (aarch64_gdbarch_init): Don't register deleted functions with
7650         gdbarch.
7651
7652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * gdbtypes.c (type_align): Don't consider static members when
7655         computing structure alignment.
7656
7657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7660         return 0 for other types.
7661         * arch-utils.c (default_type_align): Always return 0.
7662         * gdbarch.h: Regenerate.
7663         * gdbarch.sh (type_align): Extend comment.
7664         * gdbtypes.c (type_align): Add additional comments, always call
7665         gdbarch_type_align before applying the default rules.
7666         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7667         generic code will then apply a suitable default.
7668         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7669         types, return 0 for other types.
7670
7671 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7672
7673         * NEWS: Create a new section for the next release branch.
7674         Rename the section of the current branch, now that it has
7675         been cut.
7676
7677 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7678
7679         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7680         * version.in: Bump version to 8.3.50.DATE-git.
7681
7682 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7683
7684         * aix-thread.c (ptid_cmp): Remove unused variable.
7685         (get_signaled_thread): Likewise.
7686         (store_regs_user_thread): Likewise.
7687         (store_regs_kernel_thread): Likewise.
7688         (fetch_regs_kernel_thread): Remove shadowed variable.
7689
7690 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * features/riscv/32bit-cpu.xml: Add register numbers.
7693         * features/riscv/32bit-fpu.c: Regenerate.
7694         * features/riscv/32bit-fpu.xml: Add register numbers.
7695         * features/riscv/64bit-cpu.xml: Add register numbers.
7696         * features/riscv/64bit-fpu.c: Regenerate.
7697         * features/riscv/64bit-fpu.xml: Add register numbers.
7698
7699 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7700
7701         * NEWS: Mention two argument form of gdb.Value constructor.
7702         * python/py-value.c (convert_buffer_and_type_to_value): New
7703         function.
7704         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7705         Add support for handling an optional second argument.  Call
7706         convert_buffer_and_type_to_value as appropriate.
7707         * python/python-internal.h (Py_buffer_deleter): New struct.
7708         (Py_buffer_up): New typedef.
7709
7710 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7711
7712         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7713         instead of releasing ownership.
7714
7715 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7716
7717         * dwarf2read.c (open_and_init_dwp_file): Call
7718         elf_numsections instead of bfd_count_sections to initialize
7719         dwp_file->num_sections.
7720
7721 2019-02-25  Tom Tromey  <tromey@adacore.com>
7722
7723         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7724
7725 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7726
7727         * gcore.in: Add '--readnever' option when invoking GDB.
7728
7729 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7730
7731         * MAINTAINERS: Update my email address.
7732
7733 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7734
7735         * build-id.c (build_id_to_debug_bfd_1): New function.
7736         (build_id_to_debug_bfd): Look for separate debug file in
7737         sysroot.
7738
7739 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * gdbarch.sh: Update the copyright year range that is placed into
7742         generated files.
7743
7744 2019-02-22  Keith Seitz  <keiths@redhat.com>
7745
7746         PR symtab/23853
7747         * linespec.c (create_sals_line_offset): Search for the default
7748         symtab's filename instead of its fullname.
7749
7750 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7751
7752         * NEWS: Update style defaults.
7753
7754 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7755
7756         * main.c (captured_main_1): Disable styling in batch mode.
7757
7758 2019-02-20  Tom Tromey  <tom@tromey.com>
7759
7760         * symtab.c (symtab_symbol_info): Fix typos.
7761
7762 2019-02-20  Tom Tromey  <tromey@adacore.com>
7763
7764         * findcmd.c (_initialize_mem_search): Use upper case for
7765         metasyntactic variables.
7766
7767 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7768
7769         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7770         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7771
7772 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7773
7774         * top.h (source_file_name): Change to std::string.
7775         * top.c (source_file_name): Likewise.
7776         (command_line_input): Adjust.
7777         * cli/cli-script.c (script_from_file): Adjust.
7778
7779 2019-02-19  Tom Tromey  <tromey@adacore.com>
7780
7781         * ravenscar-thread.c
7782         (ravenscar_thread_target::update_thread_list): Don't call
7783         ada_build_task_list.
7784         * ada-lang.h (ada_build_task_list): Don't declare.
7785         * ada-tasks.c (struct ada_tasks_inferior_data)
7786         <task_list_valid_p>: Now bool.
7787         (read_known_tasks, ada_task_list_changed)
7788         (ada_tasks_invalidate_inferior_data): Update.
7789         (read_known_tasks_array): Return bool.
7790         (read_known_tasks_list): Likewise.
7791         (read_known_tasks): Return void.
7792         (ada_build_task_list): Now static.
7793
7794 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7797         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7798
7799 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7800
7801         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7802         variant for ada_tasks_pspace_data_handle and
7803         ada_tasks_inferior_data_handle.
7804         (ada_tasks_pspace_data_cleanup): New function.
7805         (ada_tasks_inferior_data_cleanup): New function.
7806
7807 2019-02-17  Tom Tromey  <tom@tromey.com>
7808
7809         * macrotab.h (macro_source_fullname): Return a std::string.
7810         * macrotab.c (macro_include, check_for_redefinition)
7811         (macro_undef, macro_lookup_definition, foreach_macro)
7812         (foreach_macro_in_scope): Update.
7813         (macro_source_fullname): Return a std::string.
7814         * macrocmd.c (show_pp_source_pos): Update.
7815
7816 2019-02-17  Tom Tromey  <tom@tromey.com>
7817
7818         * macrocmd.c (show_pp_source_pos): Style the file names.
7819
7820 2019-02-17  Tom Tromey  <tom@tromey.com>
7821
7822         PR tui/24197:
7823         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7824
7825 2019-02-17  Tom Tromey  <tom@tromey.com>
7826
7827         * ada-lang.c (user_select_syms): Use filtered printing.
7828         * utils.c (wrap_style): New global.
7829         (desired_style): Remove.
7830         (emit_style_escape): Add stream parameter.
7831         (set_output_style, reset_terminal_style, prompt_for_continue):
7832         Update.
7833         (flush_wrap_buffer): Only flush gdb_stdout.
7834         (wrap_here): Set wrap_style.
7835         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7836         treat escape sequences as a character.  Change when wrap buffer is
7837         flushed.
7838         (fputs_styled): Do not set the output style when the default is
7839         requested.
7840         * ui-style.h (struct ui_file_style) <is_default>: New method.
7841         * source.c (print_source_lines_base): Emit escape sequences in one
7842         piece.
7843
7844 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7845
7846         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7847         integers and enumeration types.
7848
7849 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7850
7851         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7852         instead of lookup_symbol_in_language
7853         (do_exact_match): New function.
7854         (ada_get_symbol_name_matcher): Return do_exact_match when
7855         doing a verbatim match.
7856
7857 2019-02-15  Tom Tromey  <tromey@adacore.com>
7858
7859         * ravenscar-thread.c (ravenscar_thread_target::resume)
7860         (ravenscar_thread_target::wait): Special case wildcard requests.
7861
7862 2019-02-15  Tom Tromey  <tromey@adacore.com>
7863
7864         * ravenscar-thread.c (base_ptid): Remove.
7865         (struct ravenscar_thread_target) <close>: New method.
7866         <m_base_ptid>: New member.
7867         <update_inferior_ptid, active_task, task_is_currently_active,
7868         runtime_initialized>: Declare methods.
7869         <ravenscar_thread_target>: Add constructor.
7870         (ravenscar_thread_target::task_is_currently_active)
7871         (ravenscar_thread_target::update_inferior_ptid)
7872         (ravenscar_runtime_initialized): Rename.  Now methods.
7873         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7874         (ravenscar_thread_target::update_thread_list): Update.
7875         (ravenscar_thread_target::active_task): Now method.
7876         (ravenscar_thread_target::store_registers)
7877         (ravenscar_thread_target::prepare_to_store)
7878         (ravenscar_thread_target::prepare_to_store)
7879         (ravenscar_thread_target::mourn_inferior): Update.
7880         (ravenscar_inferior_created): Use "new" to create target.
7881         (ravenscar_thread_target::get_ada_task_ptid): Update.
7882         (_initialize_ravenscar): Don't initialize base_ptid.
7883         (ravenscar_ops): Remove global.
7884
7885 2019-02-15  Tom Tromey  <tromey@adacore.com>
7886
7887         * target.h (push_target): Declare new overload.
7888         * target.c (push_target): New overload, taking an rvalue reference.
7889         * remote.c (remote_target::open_1): Use push_target overload.
7890         * corelow.c (core_target_open): Use push_target overload.
7891
7892 2019-02-15  Tom Tromey  <tromey@adacore.com>
7893
7894         * ravenscar-thread.c (is_ravenscar_task)
7895         (ravenscar_task_is_currently_active): Return bool.
7896         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7897         (_initialize_ravenscar): Remove "(void)".
7898         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7899         Return bool.
7900
7901 2019-02-15  Tom Tromey  <tromey@adacore.com>
7902
7903         * ravenscar-thread.c (ravenscar_runtime_initializer)
7904         (has_ravenscar_runtime, get_running_thread_id)
7905         (ravenscar_thread_target::resume): Fix indentation.
7906
7907 2019-02-15  Tom Tromey  <tromey@adacore.com>
7908
7909         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7910         from ravenscar_arch_ops.
7911         (sparc_ravenscar_ops::fetch_registers)
7912         (sparc_ravenscar_ops::store_registers): Now methods.
7913         (sparc_ravenscar_prepare_to_store): Remove.
7914         (sparc_ravenscar_ops): Redefine.
7915         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7916         methods and destructor.  Remove members.
7917         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7918         (ravenscar_thread_target::store_registers)
7919         (ravenscar_thread_target::prepare_to_store): Update.
7920         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7921         Remove.
7922         (struct ppc_ravenscar_powerpc_ops): Derive from
7923         ravenscar_arch_ops.
7924         (ppc_ravenscar_powerpc_ops::fetch_registers)
7925         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7926         (ppc_ravenscar_powerpc_ops): Redefine.
7927         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7928         (ppc_ravenscar_e500_ops::fetch_registers)
7929         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7930         (ppc_ravenscar_e500_ops): Redefine.
7931         * aarch64-ravenscar-thread.c
7932         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7933         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7934         (aarch64_ravenscar_fetch_registers)
7935         (aarch64_ravenscar_store_registers): Now methods.
7936         (aarch64_ravenscar_ops): Redefine.
7937
7938 2019-02-15  Tom Tromey  <tromey@adacore.com>
7939
7940         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7941         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7942         (ravenscar_thread_target::stopped_by_watchpoint)
7943         (ravenscar_thread_target::stopped_data_address)
7944         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7945
7946 2019-02-15  Tom Tromey  <tromey@adacore.com>
7947
7948         * ravenscar-thread.c: Fix some typos.
7949
7950 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7951             Tom Tromey  <tromey@adacore.com>
7952
7953         * ada-lang.c (ada_exception_sal): Change addr_string to a
7954         std::string.
7955         (create_ada_exception_catchpoint): Update.
7956
7957 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7958             Tom Tromey  <tromey@adacore.com>
7959
7960         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7961         (bp_location_ops): Remove.
7962         (base_breakpoint_allocate_location): Update.
7963         (free_bp_location): Update.
7964         * ada-lang.c (class ada_catchpoint_location)
7965         <ada_catchpoint_location>: Remove ops parameter.
7966         (ada_catchpoint_location_dtor): Remove.
7967         (ada_catchpoint_location_ops): Remove.
7968         (allocate_location_exception): Update.
7969         * breakpoint.h (struct bp_location_ops): Remove.
7970         (class bp_location) <bp_location>: Remove bp_location_ops
7971         parameter.
7972         <~bp_location>: Add destructor.
7973         <ops>: Remove.
7974
7975 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7976             Pedro Alves  <palves@redhat.com>
7977
7978         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7979         'PATH_MAX'.
7980
7981 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7982             Samuel Thibault  <samuel.thibault@gnu.org>
7983             Thomas Schwinge  <thomas@codesourcery.com>
7984
7985         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7986         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7987
7988 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7989
7990         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7991         (check_empty): Use "const char *".
7992
7993         * gnu-nat.c (gnu_nat_target::detach): Instead of
7994         'detach_inferior (pid)' call
7995         'detach_inferior (find_inferior_pid (pid))'.
7996
7997         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7998         'nat/fork-inferior.o'.
7999         * gnu-nat.c: #include "nat/fork-inferior.h".
8000
8001         * gnu-nat.c (gnu_nat_target::detach): Instead of
8002         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8003         * gnu-nat.h: #include "inf-child.h".
8004         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8005         'i386_gnu_nat_target::fetch_registers'.
8006         (gnu_store_registers): Rename/move to
8007         'i386_gnu_nat_target::store_registers'.
8008
8009         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8010         * gnu-nat.h (mach_thread_info): New function.
8011         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8012
8013         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8014
8015 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8016
8017         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8018
8019 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8020
8021         * windows-nat.c (windows_add_thread): Add new parameter
8022         "main_thread_p" with default value set to false.  Update
8023         function documentation as well as all callers.
8024         (windows_delete_thread): Likewise.
8025         (fake_create_process): Update call to windows_add_thread.
8026         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8027         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8028         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8029         call to windows_delete_thread.
8030
8031 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8032
8033         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8034
8035 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8036
8037         * symfile.c (find_separate_debug_file): Use canonical path of
8038         sysroot with child_path instead of gdb_sysroot if it is valid.
8039
8040 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8041
8042         * symfile.c (find_separate_debug_file): Use child_path to
8043         determine if an object file is under a sysroot.
8044
8045 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8046
8047         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8048         unittests/child-path-selftests.c.
8049         * common/pathstuff.c (child_path): New function.
8050         * common/pathstuff.h (child_path): New prototype.
8051         * unittests/child-path-selftests.c: New file.
8052
8053 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8054
8055         * symfile.c (find_separate_debug_file): Look for separate debug
8056         files in debug directories under the sysroot.
8057
8058 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8059
8060         * symtab.h (struct minimal_symbol data_p): New const method.
8061         (struct minimal_symbol text_p): Likewise.
8062         * symtab.c (output_source_filename): Use file name style
8063         to print file name.
8064         (print_symbol_info): Likewise.
8065         (print_msymbol_info): Use address style to print addresses.
8066         Use function name style to print executable text symbols.
8067         (expand_symtab_containing_pc): Use data_p.
8068         (find_pc_sect_compunit_symtab): Likewise.
8069
8070 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8071
8072         * breakpoint.c (describe_other_breakpoints): Use address style
8073         to print addresses.
8074         (say_where): Likewise.
8075
8076 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8077
8078         * ada-typeprint.c (print_func_type): Print function name
8079         style to print function name.
8080         * c-typeprint.c (c_print_type_1): Likewise.
8081
8082 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8083
8084         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8085         for execve.
8086
8087 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8088
8089         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8090         type_stack.
8091
8092 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8093
8094         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8095         TYPE_CODE_REF types.
8096
8097 2019-02-08  Jim Wilson  <jimw@sifive.com>
8098
8099         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8100         (riscv_linux_fregset): New.
8101         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8102
8103 2019-02-07  Tom Tromey  <tom@tromey.com>
8104
8105         * thread.c (thread_cancel_execution_command): Update.
8106         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8107         methods.
8108         (struct thread_fsm_ops): Remove.
8109         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8110         (thread_fsm_should_stop, thread_fsm_return_value)
8111         (thread_fsm_set_finished, thread_fsm_finished_p)
8112         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8113         Don't declare.
8114         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8115         * infrun.c (clear_proceed_status_thread)
8116         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8117         (print_stop_event): Update.
8118         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8119         Add constructor.
8120         (step_command_fsm_ops): Remove.
8121         (new_step_command_fsm): Remove.
8122         (step_1): Update.
8123         (step_command_fsm::should_stop): Rename from
8124         step_command_fsm_should_stop.
8125         (step_command_fsm::clean_up): Rename from
8126         step_command_fsm_clean_up.
8127         (step_command_fsm::do_async_reply_reason): Rename from
8128         step_command_fsm_async_reply_reason.
8129         (struct until_next_fsm): Inherit from thread_fsm.  Add
8130         constructor.
8131         (until_next_fsm_ops): Remove.
8132         (new_until_next_fsm): Remove.
8133         (until_next_fsm::should_stop): Rename from
8134         until_next_fsm_should_stop.
8135         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8136         (until_next_fsm::do_async_reply_reason): Rename from
8137         until_next_fsm_async_reply_reason.
8138         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8139         constructor.  Change type of breakpoint.
8140         (finish_command_fsm_ops): Remove.
8141         (new_finish_command_fsm): Remove.
8142         (finish_command_fsm::should_stop): Rename from
8143         finish_command_fsm_should_stop.
8144         (finish_command_fsm::clean_up): Rename from
8145         finish_command_fsm_clean_up.
8146         (finish_command_fsm::return_value): Rename from
8147         finish_command_fsm_return_value.
8148         (finish_command_fsm::do_async_reply_reason): Rename from
8149         finish_command_fsm_async_reply_reason.
8150         (finish_command): Update.
8151         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8152         Add constructor.
8153         (call_thread_fsm_ops): Remove.
8154         (call_thread_fsm::call_thread_fsm): Rename from
8155         new_call_thread_fsm.
8156         (call_thread_fsm::should_stop): Rename from
8157         call_thread_fsm_should_stop.
8158         (call_thread_fsm::should_notify_stop): Rename from
8159         call_thread_fsm_should_notify_stop.
8160         (run_inferior_call, call_function_by_hand_dummy): Update.
8161         * cli/cli-interp.c (should_print_stop_to_console): Update.
8162         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8163         Add constructor.  Change type of location_breakpoint,
8164         caller_breakpoint.
8165         (until_break_fsm_ops): Remove.
8166         (new_until_break_fsm): Remove.
8167         (until_break_fsm::should_stop): Rename from
8168         until_break_fsm_should_stop.
8169         (until_break_fsm::clean_up): Rename from
8170         until_break_fsm_clean_up.
8171         (until_break_fsm::do_async_reply_reason): Rename from
8172         until_break_fsm_async_reply_reason.
8173         (until_break_command): Update.
8174         * thread-fsm.c: Remove.
8175         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8176
8177 2019-02-07  Tom Tromey  <tom@tromey.com>
8178
8179         * yy-remap.h: Add include guard.
8180         * xtensa-tdep.h: Add include guard.
8181         * xcoffread.h: Rename include guard.
8182         * varobj-iter.h: Add include guard.
8183         * tui/tui.h: Rename include guard.
8184         * tui/tui-winsource.h: Rename include guard.
8185         * tui/tui-wingeneral.h: Rename include guard.
8186         * tui/tui-windata.h: Rename include guard.
8187         * tui/tui-win.h: Rename include guard.
8188         * tui/tui-stack.h: Rename include guard.
8189         * tui/tui-source.h: Rename include guard.
8190         * tui/tui-regs.h: Rename include guard.
8191         * tui/tui-out.h: Rename include guard.
8192         * tui/tui-layout.h: Rename include guard.
8193         * tui/tui-io.h: Rename include guard.
8194         * tui/tui-hooks.h: Rename include guard.
8195         * tui/tui-file.h: Rename include guard.
8196         * tui/tui-disasm.h: Rename include guard.
8197         * tui/tui-data.h: Rename include guard.
8198         * tui/tui-command.h: Rename include guard.
8199         * tic6x-tdep.h: Add include guard.
8200         * target/waitstatus.h: Rename include guard.
8201         * target/wait.h: Rename include guard.
8202         * target/target.h: Rename include guard.
8203         * target/resume.h: Rename include guard.
8204         * target-float.h: Rename include guard.
8205         * stabsread.h: Add include guard.
8206         * rs6000-tdep.h: Add include guard.
8207         * riscv-fbsd-tdep.h: Add include guard.
8208         * regformats/regdef.h: Rename include guard.
8209         * record.h: Rename include guard.
8210         * python/python.h: Rename include guard.
8211         * python/python-internal.h: Rename include guard.
8212         * python/py-stopevent.h: Rename include guard.
8213         * python/py-ref.h: Rename include guard.
8214         * python/py-record.h: Rename include guard.
8215         * python/py-record-full.h: Rename include guard.
8216         * python/py-record-btrace.h: Rename include guard.
8217         * python/py-instruction.h: Rename include guard.
8218         * python/py-events.h: Rename include guard.
8219         * python/py-event.h: Rename include guard.
8220         * procfs.h: Add include guard.
8221         * proc-utils.h: Add include guard.
8222         * p-lang.h: Add include guard.
8223         * or1k-tdep.h: Rename include guard.
8224         * observable.h: Rename include guard.
8225         * nto-tdep.h: Rename include guard.
8226         * nat/x86-linux.h: Rename include guard.
8227         * nat/x86-linux-dregs.h: Rename include guard.
8228         * nat/x86-gcc-cpuid.h: Add include guard.
8229         * nat/x86-dregs.h: Rename include guard.
8230         * nat/x86-cpuid.h: Rename include guard.
8231         * nat/ppc-linux.h: Rename include guard.
8232         * nat/mips-linux-watch.h: Rename include guard.
8233         * nat/linux-waitpid.h: Rename include guard.
8234         * nat/linux-ptrace.h: Rename include guard.
8235         * nat/linux-procfs.h: Rename include guard.
8236         * nat/linux-osdata.h: Rename include guard.
8237         * nat/linux-nat.h: Rename include guard.
8238         * nat/linux-namespaces.h: Rename include guard.
8239         * nat/linux-btrace.h: Rename include guard.
8240         * nat/glibc_thread_db.h: Rename include guard.
8241         * nat/gdb_thread_db.h: Rename include guard.
8242         * nat/gdb_ptrace.h: Rename include guard.
8243         * nat/fork-inferior.h: Rename include guard.
8244         * nat/amd64-linux-siginfo.h: Rename include guard.
8245         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8246         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8247         * nat/aarch64-linux.h: Rename include guard.
8248         * nat/aarch64-linux-hw-point.h: Rename include guard.
8249         * mn10300-tdep.h: Add include guard.
8250         * mips-linux-tdep.h: Add include guard.
8251         * mi/mi-parse.h: Rename include guard.
8252         * mi/mi-out.h: Rename include guard.
8253         * mi/mi-main.h: Rename include guard.
8254         * mi/mi-interp.h: Rename include guard.
8255         * mi/mi-getopt.h: Rename include guard.
8256         * mi/mi-console.h: Rename include guard.
8257         * mi/mi-common.h: Rename include guard.
8258         * mi/mi-cmds.h: Rename include guard.
8259         * mi/mi-cmd-break.h: Rename include guard.
8260         * m2-lang.h: Add include guard.
8261         * location.h: Rename include guard.
8262         * linux-record.h: Rename include guard.
8263         * linux-nat.h: Add include guard.
8264         * linux-fork.h: Add include guard.
8265         * i386-darwin-tdep.h: Rename include guard.
8266         * hppa-linux-offsets.h: Add include guard.
8267         * guile/guile.h: Rename include guard.
8268         * guile/guile-internal.h: Rename include guard.
8269         * gnu-nat.h: Rename include guard.
8270         * gdb-stabs.h: Rename include guard.
8271         * frv-tdep.h: Add include guard.
8272         * f-lang.h: Add include guard.
8273         * event-loop.h: Add include guard.
8274         * darwin-nat.h: Rename include guard.
8275         * cp-abi.h: Rename include guard.
8276         * config/sparc/nm-sol2.h: Rename include guard.
8277         * config/nm-nto.h: Rename include guard.
8278         * config/nm-linux.h: Add include guard.
8279         * config/i386/nm-i386gnu.h: Rename include guard.
8280         * config/djgpp/nl_types.h: Rename include guard.
8281         * config/djgpp/langinfo.h: Rename include guard.
8282         * compile/gcc-cp-plugin.h: Add include guard.
8283         * compile/gcc-c-plugin.h: Add include guard.
8284         * compile/compile.h: Rename include guard.
8285         * compile/compile-object-run.h: Rename include guard.
8286         * compile/compile-object-load.h: Rename include guard.
8287         * compile/compile-internal.h: Rename include guard.
8288         * compile/compile-cplus.h: Rename include guard.
8289         * compile/compile-c.h: Rename include guard.
8290         * common/xml-utils.h: Rename include guard.
8291         * common/x86-xstate.h: Rename include guard.
8292         * common/version.h: Rename include guard.
8293         * common/vec.h: Rename include guard.
8294         * common/tdesc.h: Rename include guard.
8295         * common/selftest.h: Rename include guard.
8296         * common/scoped_restore.h: Rename include guard.
8297         * common/scoped_mmap.h: Rename include guard.
8298         * common/scoped_fd.h: Rename include guard.
8299         * common/safe-iterator.h: Rename include guard.
8300         * common/run-time-clock.h: Rename include guard.
8301         * common/refcounted-object.h: Rename include guard.
8302         * common/queue.h: Rename include guard.
8303         * common/ptid.h: Rename include guard.
8304         * common/print-utils.h: Rename include guard.
8305         * common/preprocessor.h: Rename include guard.
8306         * common/pathstuff.h: Rename include guard.
8307         * common/observable.h: Rename include guard.
8308         * common/netstuff.h: Rename include guard.
8309         * common/job-control.h: Rename include guard.
8310         * common/host-defs.h: Rename include guard.
8311         * common/gdb_wait.h: Rename include guard.
8312         * common/gdb_vecs.h: Rename include guard.
8313         * common/gdb_unlinker.h: Rename include guard.
8314         * common/gdb_unique_ptr.h: Rename include guard.
8315         * common/gdb_tilde_expand.h: Rename include guard.
8316         * common/gdb_sys_time.h: Rename include guard.
8317         * common/gdb_string_view.h: Rename include guard.
8318         * common/gdb_splay_tree.h: Rename include guard.
8319         * common/gdb_setjmp.h: Rename include guard.
8320         * common/gdb_ref_ptr.h: Rename include guard.
8321         * common/gdb_optional.h: Rename include guard.
8322         * common/gdb_locale.h: Rename include guard.
8323         * common/gdb_assert.h: Rename include guard.
8324         * common/filtered-iterator.h: Rename include guard.
8325         * common/filestuff.h: Rename include guard.
8326         * common/fileio.h: Rename include guard.
8327         * common/environ.h: Rename include guard.
8328         * common/common-utils.h: Rename include guard.
8329         * common/common-types.h: Rename include guard.
8330         * common/common-regcache.h: Rename include guard.
8331         * common/common-inferior.h: Rename include guard.
8332         * common/common-gdbthread.h: Rename include guard.
8333         * common/common-exceptions.h: Rename include guard.
8334         * common/common-defs.h: Rename include guard.
8335         * common/common-debug.h: Rename include guard.
8336         * common/cleanups.h: Rename include guard.
8337         * common/buffer.h: Rename include guard.
8338         * common/btrace-common.h: Rename include guard.
8339         * common/break-common.h: Rename include guard.
8340         * cli/cli-utils.h: Rename include guard.
8341         * cli/cli-style.h: Rename include guard.
8342         * cli/cli-setshow.h: Rename include guard.
8343         * cli/cli-script.h: Rename include guard.
8344         * cli/cli-interp.h: Rename include guard.
8345         * cli/cli-decode.h: Rename include guard.
8346         * cli/cli-cmds.h: Rename include guard.
8347         * charset-list.h: Add include guard.
8348         * buildsym-legacy.h: Rename include guard.
8349         * bfin-tdep.h: Add include guard.
8350         * ax.h: Rename include guard.
8351         * arm-linux-tdep.h: Add include guard.
8352         * arm-fbsd-tdep.h: Add include guard.
8353         * arch/xtensa.h: Rename include guard.
8354         * arch/tic6x.h: Add include guard.
8355         * arch/i386.h: Add include guard.
8356         * arch/arm.h: Rename include guard.
8357         * arch/arm-linux.h: Rename include guard.
8358         * arch/arm-get-next-pcs.h: Rename include guard.
8359         * arch/amd64.h: Add include guard.
8360         * arch/aarch64-insn.h: Rename include guard.
8361         * arch-utils.h: Rename include guard.
8362         * annotate.h: Add include guard.
8363         * amd64-darwin-tdep.h: Rename include guard.
8364         * aarch64-linux-tdep.h: Add include guard.
8365         * aarch64-fbsd-tdep.h: Add include guard.
8366         * aarch32-linux-nat.h: Add include guard.
8367
8368 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8369
8370         * macrotab.c (macro_define_internal): New function that
8371         factorizes macro_define_object_internal and macro_define_function
8372         code.
8373         (macro_define_object_internal): Use macro_define_internal.
8374         (macro_define_function): Likewise.
8375
8376 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8377
8378         * macrocmd.c (extract_identifier): Return
8379         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8380         callers.
8381
8382 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8383
8384         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8385
8386 2019-02-05  Tom Tromey  <tom@tromey.com>
8387
8388         * target.c (target_stack::unpush): Move assertion earlier.
8389
8390 2019-01-30  Tom Tromey  <tom@tromey.com>
8391
8392         PR python/23615:
8393         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8394         (gdbpy_parse_and_eval): Likewise.
8395         * python/python-internal.h (gdbpy_allow_threads): New class.
8396
8397 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8398
8399         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8400         (aarch64_fbsd_fpregmap): Move earlier.
8401         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8402         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8403         instead of individual calls to trad_frame_set_reg_addr.
8404         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8405         earlier.
8406         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8407         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8408         instead of individual calls to trad_frame_set_reg_addr.
8409
8410 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8411
8412         * CONTRIBUTE: Replace contribution list with wiki link.
8413
8414 2019-01-25  Tom Tromey  <tom@tromey.com>
8415
8416         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8417
8418 2019-01-25  Tom Tromey  <tom@tromey.com>
8419
8420         * xtensa-linux-nat.c: Fix common/ includes.
8421         * xml-support.h: Fix common/ includes.
8422         * xml-support.c: Fix common/ includes.
8423         * x86-linux-nat.c: Fix common/ includes.
8424         * windows-nat.c: Fix common/ includes.
8425         * varobj.h: Fix common/ includes.
8426         * varobj.c: Fix common/ includes.
8427         * value.c: Fix common/ includes.
8428         * valops.c: Fix common/ includes.
8429         * utils.c: Fix common/ includes.
8430         * unittests/xml-utils-selftests.c: Fix common/ includes.
8431         * unittests/utils-selftests.c: Fix common/ includes.
8432         * unittests/unpack-selftests.c: Fix common/ includes.
8433         * unittests/tracepoint-selftests.c: Fix common/ includes.
8434         * unittests/style-selftests.c: Fix common/ includes.
8435         * unittests/string_view-selftests.c: Fix common/ includes.
8436         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8437         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8438         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8439         * unittests/rsp-low-selftests.c: Fix common/ includes.
8440         * unittests/parse-connection-spec-selftests.c: Fix common/
8441         includes.
8442         * unittests/optional-selftests.c: Fix common/ includes.
8443         * unittests/offset-type-selftests.c: Fix common/ includes.
8444         * unittests/observable-selftests.c: Fix common/ includes.
8445         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8446         * unittests/memrange-selftests.c: Fix common/ includes.
8447         * unittests/memory-map-selftests.c: Fix common/ includes.
8448         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8449         * unittests/function-view-selftests.c: Fix common/ includes.
8450         * unittests/environ-selftests.c: Fix common/ includes.
8451         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8452         * unittests/common-utils-selftests.c: Fix common/ includes.
8453         * unittests/cli-utils-selftests.c: Fix common/ includes.
8454         * unittests/array-view-selftests.c: Fix common/ includes.
8455         * ui-file.c: Fix common/ includes.
8456         * tui/tui-io.c: Fix common/ includes.
8457         * tracepoint.h: Fix common/ includes.
8458         * tracepoint.c: Fix common/ includes.
8459         * tracefile-tfile.c: Fix common/ includes.
8460         * top.h: Fix common/ includes.
8461         * top.c: Fix common/ includes.
8462         * thread.c: Fix common/ includes.
8463         * target/waitstatus.h: Fix common/ includes.
8464         * target/waitstatus.c: Fix common/ includes.
8465         * target.h: Fix common/ includes.
8466         * target.c: Fix common/ includes.
8467         * target-memory.c: Fix common/ includes.
8468         * target-descriptions.c: Fix common/ includes.
8469         * symtab.h: Fix common/ includes.
8470         * symfile.c: Fix common/ includes.
8471         * stap-probe.c: Fix common/ includes.
8472         * spu-linux-nat.c: Fix common/ includes.
8473         * sparc-nat.c: Fix common/ includes.
8474         * source.c: Fix common/ includes.
8475         * solib.c: Fix common/ includes.
8476         * solib-target.c: Fix common/ includes.
8477         * ser-unix.c: Fix common/ includes.
8478         * ser-tcp.c: Fix common/ includes.
8479         * ser-pipe.c: Fix common/ includes.
8480         * ser-base.c: Fix common/ includes.
8481         * selftest-arch.c: Fix common/ includes.
8482         * s12z-tdep.c: Fix common/ includes.
8483         * rust-exp.y: Fix common/ includes.
8484         * rs6000-aix-tdep.c: Fix common/ includes.
8485         * riscv-tdep.c: Fix common/ includes.
8486         * remote.c: Fix common/ includes.
8487         * remote-notif.h: Fix common/ includes.
8488         * remote-fileio.h: Fix common/ includes.
8489         * remote-fileio.c: Fix common/ includes.
8490         * regcache.h: Fix common/ includes.
8491         * regcache.c: Fix common/ includes.
8492         * record-btrace.c: Fix common/ includes.
8493         * python/python.c: Fix common/ includes.
8494         * python/py-type.c: Fix common/ includes.
8495         * python/py-inferior.c: Fix common/ includes.
8496         * progspace.h: Fix common/ includes.
8497         * producer.c: Fix common/ includes.
8498         * procfs.c: Fix common/ includes.
8499         * proc-api.c: Fix common/ includes.
8500         * printcmd.c: Fix common/ includes.
8501         * ppc-linux-nat.c: Fix common/ includes.
8502         * parser-defs.h: Fix common/ includes.
8503         * osdata.c: Fix common/ includes.
8504         * obsd-nat.c: Fix common/ includes.
8505         * nat/x86-linux.c: Fix common/ includes.
8506         * nat/x86-linux-dregs.c: Fix common/ includes.
8507         * nat/x86-dregs.h: Fix common/ includes.
8508         * nat/x86-dregs.c: Fix common/ includes.
8509         * nat/ppc-linux.c: Fix common/ includes.
8510         * nat/mips-linux-watch.h: Fix common/ includes.
8511         * nat/mips-linux-watch.c: Fix common/ includes.
8512         * nat/linux-waitpid.c: Fix common/ includes.
8513         * nat/linux-ptrace.h: Fix common/ includes.
8514         * nat/linux-ptrace.c: Fix common/ includes.
8515         * nat/linux-procfs.c: Fix common/ includes.
8516         * nat/linux-personality.c: Fix common/ includes.
8517         * nat/linux-osdata.c: Fix common/ includes.
8518         * nat/linux-namespaces.c: Fix common/ includes.
8519         * nat/linux-btrace.h: Fix common/ includes.
8520         * nat/linux-btrace.c: Fix common/ includes.
8521         * nat/fork-inferior.c: Fix common/ includes.
8522         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8523         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8524         * nat/aarch64-linux.c: Fix common/ includes.
8525         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8526         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8527         * namespace.h: Fix common/ includes.
8528         * mips-linux-tdep.c: Fix common/ includes.
8529         * minsyms.c: Fix common/ includes.
8530         * mi/mi-parse.h: Fix common/ includes.
8531         * mi/mi-main.c: Fix common/ includes.
8532         * mi/mi-cmd-env.c: Fix common/ includes.
8533         * memrange.h: Fix common/ includes.
8534         * memattr.c: Fix common/ includes.
8535         * maint.h: Fix common/ includes.
8536         * maint.c: Fix common/ includes.
8537         * main.c: Fix common/ includes.
8538         * machoread.c: Fix common/ includes.
8539         * location.c: Fix common/ includes.
8540         * linux-thread-db.c: Fix common/ includes.
8541         * linux-nat.c: Fix common/ includes.
8542         * linux-fork.c: Fix common/ includes.
8543         * inline-frame.c: Fix common/ includes.
8544         * infrun.c: Fix common/ includes.
8545         * inflow.c: Fix common/ includes.
8546         * inferior.h: Fix common/ includes.
8547         * inferior.c: Fix common/ includes.
8548         * infcmd.c: Fix common/ includes.
8549         * inf-ptrace.c: Fix common/ includes.
8550         * inf-child.c: Fix common/ includes.
8551         * ia64-linux-nat.c: Fix common/ includes.
8552         * i387-tdep.c: Fix common/ includes.
8553         * i386-tdep.c: Fix common/ includes.
8554         * i386-linux-tdep.c: Fix common/ includes.
8555         * i386-linux-nat.c: Fix common/ includes.
8556         * i386-go32-tdep.c: Fix common/ includes.
8557         * i386-fbsd-tdep.c: Fix common/ includes.
8558         * i386-fbsd-nat.c: Fix common/ includes.
8559         * guile/scm-type.c: Fix common/ includes.
8560         * guile/guile.c: Fix common/ includes.
8561         * go32-nat.c: Fix common/ includes.
8562         * gnu-nat.c: Fix common/ includes.
8563         * gdbthread.h: Fix common/ includes.
8564         * gdbarch-selftests.c: Fix common/ includes.
8565         * gdb_usleep.c: Fix common/ includes.
8566         * gdb_select.h: Fix common/ includes.
8567         * gdb_bfd.c: Fix common/ includes.
8568         * gcore.c: Fix common/ includes.
8569         * fork-child.c: Fix common/ includes.
8570         * findvar.c: Fix common/ includes.
8571         * fbsd-nat.c: Fix common/ includes.
8572         * event-top.c: Fix common/ includes.
8573         * event-loop.c: Fix common/ includes.
8574         * dwarf2read.c: Fix common/ includes.
8575         * dwarf2loc.c: Fix common/ includes.
8576         * dwarf2-frame.c: Fix common/ includes.
8577         * dwarf-index-cache.c: Fix common/ includes.
8578         * dtrace-probe.c: Fix common/ includes.
8579         * disasm-selftests.c: Fix common/ includes.
8580         * defs.h: Fix common/ includes.
8581         * csky-tdep.c: Fix common/ includes.
8582         * cp-valprint.c: Fix common/ includes.
8583         * cp-support.h: Fix common/ includes.
8584         * cp-support.c: Fix common/ includes.
8585         * corelow.c: Fix common/ includes.
8586         * completer.h: Fix common/ includes.
8587         * completer.c: Fix common/ includes.
8588         * compile/compile.c: Fix common/ includes.
8589         * compile/compile-loc2c.c: Fix common/ includes.
8590         * compile/compile-cplus-types.c: Fix common/ includes.
8591         * compile/compile-cplus-symbols.c: Fix common/ includes.
8592         * command.h: Fix common/ includes.
8593         * cli/cli-dump.c: Fix common/ includes.
8594         * cli/cli-cmds.c: Fix common/ includes.
8595         * charset.c: Fix common/ includes.
8596         * build-id.c: Fix common/ includes.
8597         * btrace.h: Fix common/ includes.
8598         * btrace.c: Fix common/ includes.
8599         * breakpoint.h: Fix common/ includes.
8600         * breakpoint.c: Fix common/ includes.
8601         * ax.h:
8602         (enum agent_op): Fix common/ includes.
8603         * ax-general.c (struct aop_map): Fix common/ includes.
8604         * ax-gdb.c: Fix common/ includes.
8605         * auxv.c: Fix common/ includes.
8606         * auto-load.c: Fix common/ includes.
8607         * arm-tdep.c: Fix common/ includes.
8608         * arch/riscv.c: Fix common/ includes.
8609         * arch/ppc-linux-common.c: Fix common/ includes.
8610         * arch/i386.c: Fix common/ includes.
8611         * arch/arm.c: Fix common/ includes.
8612         * arch/arm-linux.c: Fix common/ includes.
8613         * arch/arm-get-next-pcs.c: Fix common/ includes.
8614         * arch/amd64.c: Fix common/ includes.
8615         * arch/aarch64.c: Fix common/ includes.
8616         * arch/aarch64-insn.c: Fix common/ includes.
8617         * arch-utils.c: Fix common/ includes.
8618         * amd64-windows-tdep.c: Fix common/ includes.
8619         * amd64-tdep.c: Fix common/ includes.
8620         * amd64-sol2-tdep.c: Fix common/ includes.
8621         * amd64-obsd-tdep.c: Fix common/ includes.
8622         * amd64-nbsd-tdep.c: Fix common/ includes.
8623         * amd64-linux-tdep.c: Fix common/ includes.
8624         * amd64-linux-nat.c: Fix common/ includes.
8625         * amd64-fbsd-tdep.c: Fix common/ includes.
8626         * amd64-fbsd-nat.c: Fix common/ includes.
8627         * amd64-dicos-tdep.c: Fix common/ includes.
8628         * amd64-darwin-tdep.c: Fix common/ includes.
8629         * agent.c: Fix common/ includes.
8630         * ada-lang.h: Fix common/ includes.
8631         * ada-lang.c: Fix common/ includes.
8632         * aarch64-tdep.c: Fix common/ includes.
8633
8634 2019-01-25  Tom Tromey  <tom@tromey.com>
8635
8636         * common/create-version.sh: Use common/version.h.
8637
8638 2019-01-24  Pedro Alves  <palves@redhat.com>
8639
8640         * infrun.c (signal_stop, signal_print, signal_program)
8641         (signal_catch, signal_pass): Now arrays instead of pointers.
8642         (update_signals_program_target, do_target_resume)
8643         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8644         * linux-nat.c (linux_nat_target::pass_signals)
8645         (linux_nat_target::create_inferior, linux_nat_target::attach):
8646         Adjust.
8647         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8648         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8649         * procfs.c (procfs_target::pass_signals): Adjust.
8650         * record-full.c (record_full_target::resume): Adjust.
8651         * remote.c (remote_target::pass_signals)
8652         (remote_target::program_signals): Adjust.
8653         * target-debug.h (target_debug_print_signals): Now takes a
8654         gdb::array_view as parameter.  Adjust.
8655         * target.h (target_ops) <pass_signals, program_signals>: Replace
8656         pointer and length parameters with gdb::array_view.
8657         (target_pass_signals, target_program_signals): Likewise.
8658         * target-delegates.c: Regenerate.
8659
8660 2019-01-24  Pedro Alves  <palves@redhat.com>
8661
8662         * common/forward-scope-exit.h
8663         (forward_scope_exit::forward_scope_exit): Pass arguments to
8664         m_bind_function directly, instead of creating a std::bind and
8665         copying that.
8666
8667 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8668
8669         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8670         for static members.
8671         (pass_in_v_vfp_candidate): Likewise.
8672
8673 2019-01-23  Tom Tromey  <tom@tromey.com>
8674             Pedro Alves  <palves@redhat.com>
8675
8676         * regcache.c (class regcache_invalidator): Remove.
8677         (regcache::raw_write): Use make_scope_exit.
8678
8679 2019-01-23  Tom Tromey  <tom@tromey.com>
8680
8681         * ui-out.h (class ui_out_emit_type): Update comment.
8682
8683 2019-01-23  Tom Tromey  <tom@tromey.com>
8684
8685         * infrun.c (fetch_inferior_event): Update comment.
8686
8687 2019-01-23  Tom Tromey  <tom@tromey.com>
8688             Pedro Alves  <palves@redhat.com>
8689
8690         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8691         parameter.
8692         (fetch_inferior_event): Use SCOPE_EXIT.
8693
8694
8695 2019-01-23  Tom Tromey  <tom@tromey.com>
8696             Pedro Alves  <palves@redhat.com>
8697
8698         * infrun.c (disable_thread_events): Delete.
8699         (stop_all_threads): Use SCOPE_EXIT.
8700
8701 2019-01-23  Tom Tromey  <tom@tromey.com>
8702             Pedro Alves  <palves@redhat.com>
8703
8704         * symfile.c: Include forward-scope-exit.h.
8705         (clear_symtab_users_cleanup): Replace forward declaration with
8706         a FORWARD_SCOPE_EXIT.
8707         (syms_from_objfile_1): Use the forward_scope_exit and
8708         gdb::optional instead of cleanup_function.
8709         (reread_symbols): Use the forward_scope_exit instead of
8710         cleanup_function.
8711         (clear_symtab_users_cleanup): Remove function.
8712
8713 2019-01-23  Tom Tromey  <tom@tromey.com>
8714             Pedro Alves  <palves@redhat.com>
8715
8716         * linux-nat.c: Include scope-exit.h.
8717         (cleanup_target_stop): Remove.
8718         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8719         SCOPE_EXIT.
8720
8721 2019-01-23  Tom Tromey  <tom@tromey.com>
8722             Pedro Alves  <palves@redhat.com>
8723
8724         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8725         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8726
8727 2019-01-23  Tom Tromey  <tom@tromey.com>
8728             Andrew Burgess  <andrew.burgess@embecosm.com>
8729             Pedro Alves  <palves@redhat.com>
8730
8731         * infrun.c (fetch_inferior_event): Use scope_exit.
8732         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8733         * top.c (execute_command): Use scope_exit.
8734         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8735         * utils.c (do_bpstat_clear_actions_cleanup)
8736         (make_bpstat_clear_actions_cleanup): Remove.
8737
8738 2019-01-23  Tom Tromey  <tom@tromey.com>
8739             Pedro Alves  <palves@redhat.com>
8740
8741         * infrun.c: Include "common/scope-exit.h"
8742         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8743         (wait_for_inferior): Use SCOPE_EXIT.
8744         (fetch_inferior_event): Use scope_exit.
8745
8746 2019-01-23  Tom Tromey  <tom@tromey.com>
8747             Pedro Alves  <palves@redhat.com>
8748
8749         * breakpoint.c (create_breakpoint): Remove cleanup.
8750
8751 2019-01-23  Tom Tromey  <tom@tromey.com>
8752             Andrew Burgess  <andrew.burgess@embecosm.com>
8753             Pedro Alves  <palves@redhat.com>
8754
8755 2019-01-23  Pedro Alves  <palves@redhat.com>
8756
8757         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8758
8759 2019-01-23  Pedro Alves  <palves@redhat.com>
8760             Andrew Burgess  <andrew.burgess@embecosm.com>
8761
8762         * gdbthread.h: Include "common/forward-scope-exit.h".
8763         (scoped_finish_thread_state): Redefine custom class in terms of
8764         forward_scope_exit.
8765
8766 2019-01-23  Pedro Alves  <palves@redhat.com>
8767             Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * common/forward-scope-exit.h: New file.
8770
8771 2019-01-23  Pedro Alves  <palves@redhat.com>
8772             Andrew Burgess  <andrew.burgess@embecosm.com>
8773             Tom Tromey  <tom@tromey.com>
8774
8775         * common/scope-exit.h: New file.
8776
8777 2019-01-23  Pedro Alves  <palves@redhat.com>
8778
8779         * common/preprocessor.h (ESC): Rename to ...
8780         (ESC_PARENS): ... this.
8781         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8782         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8783
8784 2019-01-23  Tom Tromey  <tom@tromey.com>
8785
8786         * language.h (class scoped_switch_to_sym_language_if_auto):
8787         Initialize m_lang in both cases.
8788
8789 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8790
8791         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8792         with XCNEW.
8793
8794 2019-01-22  Tom Tromey  <tom@tromey.com>
8795
8796         * corelow.c: Do not include sys/file.h.
8797
8798 2019-01-22  Tom Tromey  <tom@tromey.com>
8799
8800         * tui/tui-wingeneral.h: Include gdb_curses.h.
8801
8802 2019-01-22  Tom Tromey  <tom@tromey.com>
8803
8804         * source-cache.h (class source_cache) <get_source_lines,
8805         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8806
8807 2019-01-22  Tom Tromey  <tom@tromey.com>
8808
8809         * remote-fileio.h (struct remote_target): Declare.
8810
8811 2019-01-22  Tom Tromey  <tom@tromey.com>
8812
8813         * python/py-arch.c: Do not include py-ref.h.
8814         * python/py-bpevent.c: Do not include py-ref.h.
8815         * python/py-cmd.c: Do not include py-ref.h.
8816         * python/py-continueevent.c: Do not include py-ref.h.
8817         * python/py-event.h: Do not include py-ref.h.
8818         * python/py-evtregistry.c: Do not include py-ref.h.
8819         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8820         * python/py-frame.c: Do not include py-ref.h.
8821         * python/py-framefilter.c: Do not include py-ref.h.
8822         * python/py-function.c: Do not include py-ref.h.
8823         * python/py-infevents.c: Do not include py-ref.h.
8824         * python/py-linetable.c: Do not include py-ref.h.
8825         * python/py-objfile.c: Do not include py-ref.h.
8826         * python/py-param.c: Do not include py-ref.h.
8827         * python/py-prettyprint.c: Do not include py-ref.h.
8828         * python/py-progspace.c: Do not include py-ref.h.
8829         * python/py-symbol.c: Do not include py-ref.h.
8830         * python/py-symtab.c: Do not include py-ref.h.
8831         * python/py-type.c: Do not include py-ref.h.
8832         * python/py-unwind.c: Do not include py-ref.h.
8833         * python/py-utils.c: Do not include py-ref.h.
8834         * python/py-value.c: Do not include py-ref.h.
8835         * python/py-varobj.c: Do not include py-ref.h.
8836         * python/py-xmethods.c: Do not include py-ref.h.
8837         * python/python.c: Do not include py-ref.h.
8838         * varobj.c: Do not include py-ref.h.
8839
8840 2019-01-22  Tom Tromey  <tom@tromey.com>
8841
8842         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8843         keyword for bcache.
8844
8845 2019-01-22  Tom Tromey  <tom@tromey.com>
8846
8847         * compile/compile-cplus-types.c: Remove a comment by #include.
8848
8849 2019-01-22  Tom Tromey  <tom@tromey.com>
8850
8851         * compile/gcc-c-plugin.h: Include compile-internal.h.
8852
8853 2019-01-22  Tom Tromey  <tom@tromey.com>
8854
8855         * stabsread.c (EXTERN): Do not define.
8856         (symnum, next_symbol_text_func, processing_gcc_compilation)
8857         (within_function, global_sym_chain, global_stabs)
8858         (previous_stab_code, this_object_header_files)
8859         (n_this_object_header_files)
8860         (n_allocated_this_object_header_files): Define.
8861         * stabsread.h (EXTERN): Never define.  Use "extern".
8862
8863 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8864
8865         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8866         history_value.
8867
8868 2019-01-21  Tom Tromey  <tom@tromey.com>
8869
8870         * ui-out.c: Fix includes.
8871         * tui/tui-source.c: Fix includes.
8872         * target.c: Fix includes.
8873         * remote.c: Fix includes.
8874         * regcache.c: Fix includes.
8875         * python/py-block.c: Fix includes.
8876         * printcmd.c: Fix includes.
8877         * or1k-tdep.c: Fix includes.
8878         * mi/mi-main.c: Fix includes.
8879         * m32r-tdep.c: Fix includes.
8880         * csky-tdep.c: Fix includes.
8881         * compile/compile-cplus-types.c: Fix includes.
8882         * cli/cli-interp.c: Fix includes.
8883
8884 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8885
8886         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8887         for padding.
8888
8889 2019-01-16  Tom Tromey  <tom@tromey.com>
8890
8891         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8892         earlier.
8893         (struct objfile) <msymbols_range>: Move from top level.
8894         <msymbols>: New method.
8895         (class objfile_msymbols): Remove.
8896         * symtab.c (default_collect_symbol_completion_matches_break_on):
8897         Update.
8898         * symmisc.c (dump_msymbols): Update.
8899         * stabsread.c (scan_file_globals): Update.
8900         * objc-lang.c (info_selectors_command, info_classes_command)
8901         (find_methods): Update.
8902         * minsyms.c (find_solib_trampoline_target): Update.
8903         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8904         * coffread.c (coff_symfile_read): Update.
8905         * ada-lang.c (ada_lookup_simple_minsym)
8906         (ada_collect_symbol_completion_matches): Update.
8907
8908 2019-01-16  Tom Tromey  <tom@tromey.com>
8909
8910         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8911         type.  Remove no-argument constructor.
8912         <iterator::operator++>: Simplify.
8913         <begin>: Update.
8914         <end>: Use minimal_symbol_count.
8915
8916 2019-01-16  Tom Tromey  <tom@tromey.com>
8917
8918         * objfiles.h (struct objfile) <psymtabs>: New method.
8919         (class objfile_psymtabs): Remove.
8920         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8921         typedef.
8922         <range>: New method.
8923         (require_partial_symbols): Change return type.
8924         * psymtab.c (require_partial_symbols)
8925         (psym_expand_symtabs_matching): Update.
8926         * mdebugread.c (parse_partial_symbols): Update.
8927         * dbxread.c (dbx_end_psymtab): Update.
8928
8929 2019-01-15  Tom Tromey  <tom@tromey.com>
8930
8931         * symtab.c (lookup_objfile_from_block)
8932         (lookup_symbol_in_objfile_symtabs)
8933         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8934         (find_line_symtab, info_sources_command)
8935         (default_collect_symbol_completion_matches_break_on)
8936         (make_source_files_completion_list): Update.
8937         * symmisc.c (print_objfile_statistics, dump_objfile)
8938         (maintenance_print_symbols, maintenance_info_symtabs)
8939         (maintenance_check_symtabs, maintenance_info_line_tables):
8940         Update.
8941         * source.c (select_source_symtab)
8942         (forget_cached_source_info_for_objfile): Update.
8943         * objfiles.h (class objfile_compunits): Remove.
8944         (struct objfile) <compunits_range>: New typedef.
8945         (compunits): New method.
8946         * objfiles.c (objfile_relocate1): Update.
8947         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8948         * maint.c (count_symtabs_and_blocks): Update.
8949         * linespec.c (iterate_over_all_matching_symtabs): Update.
8950         * cp-support.c (add_symbol_overload_list_qualified): Update.
8951         * coffread.c (coff_symtab_read): Update.
8952         * ada-lang.c (add_nonlocal_symbols)
8953         (ada_collect_symbol_completion_matches)
8954         (ada_add_global_exceptions): Update.
8955
8956 2019-01-15  Tom Tromey  <tom@tromey.com>
8957
8958         * progspace.h (program_space) <objfiles_safe_range>: New
8959         typedef.
8960         <objfiles_safe>: New method.
8961         * objfiles.h (class all_objfiles_safe): Remove.
8962         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8963         * jit.c (jit_inferior_exit_hook): Update.
8964
8965 2019-01-17  Tom Tromey  <tom@tromey.com>
8966
8967         * progspace.h (program_space) <objfiles_range>: New typedef.
8968         <objfiles>: New method.
8969         <objfiles_head>: Rename from objfiles.
8970         (object_files): Update.
8971         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8972         * guile/scm-pretty-print.c
8973         (ppscm_find_pretty_printer_from_objfiles): Update.
8974         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8975         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8976         Update.
8977         * python/py-progspace.c (pspy_get_objfiles): Update.
8978         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8979         Update.
8980         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8981         (objfpy_lookup_objfile_by_build_id): Update.
8982         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8983         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8984         Update.
8985         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8986         (expand_symtab_containing_pc, lookup_objfile_from_block)
8987         (lookup_static_symbol, basic_lookup_transparent_type)
8988         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8989         (find_line_symtab, info_sources_command)
8990         (default_collect_symbol_completion_matches_break_on)
8991         (make_source_files_completion_list, find_main_name): Update.
8992         * symmisc.c (print_symbol_bcache_statistics)
8993         (print_objfile_statistics, maintenance_print_symbols)
8994         (maintenance_print_msymbols, maintenance_print_objfiles)
8995         (maintenance_info_symtabs, maintenance_check_symtabs)
8996         (maintenance_expand_symtabs, maintenance_info_line_tables):
8997         Update.
8998         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8999         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9000         (map_overlay_command, unmap_overlay_command)
9001         (simple_overlay_update, expand_symtabs_matching)
9002         (map_symbol_filenames): Update.
9003         * symfile-debug.c (set_debug_symfile): Update.
9004         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9005         Update.
9006         * source.c (select_source_symtab, forget_cached_source_info):
9007         Update.
9008         * solib.c (solib_read_symbols): Update.
9009         * solib-spu.c (append_ocl_sos): Update.
9010         * psymtab.c (maintenance_print_psymbols)
9011         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9012         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9013         * printcmd.c (info_symbol_command): Update.
9014         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9015         Update.
9016         * objfiles.h (class all_objfiles): Remove.
9017         * objfiles.c (have_partial_symbols, have_full_symbols)
9018         (have_minimal_symbols, qsort_cmp, update_section_map)
9019         (shared_objfile_contains_address_p)
9020         (default_iterate_over_objfiles_in_search_order): Update.
9021         * objc-lang.c (info_selectors_command, info_classes_command)
9022         (find_methods): Update.
9023         * minsyms.c (find_solib_trampoline_target): Update.
9024         * maint.c (maintenance_info_sections)
9025         (maintenance_translate_address, count_symtabs_and_blocks):
9026         Update.
9027         * main.c (captured_main_1): Update.
9028         * linux-thread-db.c (try_thread_db_load_from_pdir)
9029         (has_libpthread): Update.
9030         * linespec.c (iterate_over_all_matching_symtabs)
9031         (search_minsyms_for_name): Update.
9032         * jit.c (jit_find_objf_with_entry_addr): Update.
9033         * hppa-tdep.c (find_unwind_entry)
9034         (hppa_lookup_stub_minimal_symbol): Update.
9035         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9036         Update.
9037         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9038         (elf_gnu_ifunc_resolve_by_got): Update.
9039         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9040         * dwarf-index-write.c (save_gdb_index_command): Update.
9041         * cp-support.c (add_symbol_overload_list_qualified): Update.
9042         * breakpoint.c (create_overlay_event_breakpoint)
9043         (create_longjmp_master_breakpoint)
9044         (create_std_terminate_master_breakpoint)
9045         (create_exception_master_breakpoint): Update.
9046         * blockframe.c (find_pc_partial_function): Update.
9047         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9048         (ada_collect_symbol_completion_matches)
9049         (ada_add_global_exceptions): Update.
9050
9051 2019-01-17  Tom Tromey  <tom@tromey.com>
9052
9053         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9054         declare VEC.
9055         (solib_target_parse_libraries): Change return type.
9056         (library_list_start_segment, library_list_start_section)
9057         (library_list_end_library, library_list_start_library); Update.
9058         (solib_target_free_library_list): Remove.
9059         (solib_target_parse_libraries): Remove cleanup.  Change return
9060         type.
9061         (solib_target_current_sos): Update.
9062
9063 2019-01-17  Tom Tromey  <tromey@bapiya>
9064
9065         * valprint.c: Replace "the the" with "the".
9066         * symtab.c: Replace "the the" with "the".
9067         * solib.c: Replace "the the" with "the".
9068         * solib-dsbt.c: Replace "the the" with "the".
9069         * linespec.c: Replace "the the" with "the".
9070         * dwarf2loc.h: Replace "the the" with "the".
9071         * amd64-windows-tdep.c: Replace "the the" with "the".
9072         * aarch64-tdep.c: Replace "the the" with "the".
9073
9074 2019-01-16  Keith Seitz  <keiths@redhat.com>
9075
9076         PR gdb/23773
9077         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9078         <builder>: Rename to ..
9079         <m_builder>: ... this and make private.
9080         (dwarf2_cu::get_builder): New method.  Change all users of
9081         `builder' to use this method.
9082         (dwarf2_start_symtab): Move to ...
9083         (dwarf2_cu::start_symtab): ... here.  Update all callers
9084         (setup_type_unit_groups): Move to ...
9085         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9086         callers.
9087         (dwarf2_cu::reset_builder): New method.
9088         (process_full_compunit, process_full_type_unit): Use
9089         dwarf2_cu::reset_builder.
9090         (follow_die_offset): Record the ancestor CU if it is different
9091         from the followed DIE's CU.
9092         (follow_die_sig_1): Likewise.
9093
9094 2019-01-15  Tom Tromey  <tom@tromey.com>
9095
9096         * remote.c (class remote_state) <buf>: Now a char_vector.
9097         <buf_size>: Remove.
9098         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9099         parameter.
9100         (remote_target::getpkt_or_notif_sane_1)
9101         (remote_target::getpkt_sane)
9102         (remote_target::getpkt_or_notif_sane): Likewise.
9103         (class remote_target) <putpkt>: New overload.
9104         (remote_target::read_frame): Change type of "buf_p".  Remove
9105         sizeof_p parameter.
9106         (packet_ok): New overload.
9107         (packet_check_result): New overload.
9108         Update all uses.
9109
9110 2019-01-14  Tom Tromey  <tom@tromey.com>
9111
9112         * remote-notif.c (handle_notification, remote_notif_ack)
9113         (remote_notif_parse): Make "buf" const.
9114         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9115         const.
9116         (remote_notif_parse, remote_notif_ack, handle_notification):
9117         Likewise.
9118         * remote.c (remote_notif_stop_parse): Make "buf" const.
9119         (remote_target::remote_parse_stop_reply): Make "buf" const.
9120         (remote_notif_stop_ack): Make "buf" const.
9121
9122 2019-01-14  Tom Tromey  <tom@tromey.com>
9123
9124         * remote.c (remote_console_output): Make parameter const.
9125
9126 2019-01-14  Tom Tromey  <tom@tromey.com>
9127
9128         * target-debug.h (target_debug_print_signals): Constify.
9129         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9130         * procfs.c (procfs_target::pass_signals): Update.
9131         * linux-nat.c (linux_nat_target::pass_signals): Update.
9132         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9133         * target-delegates.c: Rebuild.
9134         * remote.c (remote_target::program_signals): Update.
9135         (remote_target::pass_signals): Update.
9136         * target.c (target_pass_signals): Constify argument.
9137         (target_program_signals): Likewise.
9138         * target.h (struct target_ops) <pass_signals, program_signals>:
9139         Constify argument.
9140         (target_pass_signals, target_program_signals): Constify argument.
9141
9142 2019-01-14  Tom Tromey  <tom@tromey.com>
9143
9144         PR tui/28819:
9145         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9146
9147 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9148
9149         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9150         field.
9151         * rs6000-tdep.c: Include reggroups.h.
9152         (IS_V_ALIAS_PSEUDOREG): Define.
9153         (rs6000_register_name): Return names for the "vX" aliases.
9154         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9155         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9156         aliases.  Call default_register_reggroup_p for all other
9157         pseudo-registers.
9158         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9159         New functions.
9160         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9161         Handle "vX" aliases.
9162         (v_alias_pseudo_register_collect): New function.
9163         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9164         (rs6000_gdbarch_init): Initialize "vX" aliases as
9165         pseudo-registers.  Restore registration of
9166         rs6000_pseudo_register_reggroup_p with
9167         set_tdesc_pseudo_register_reggroup_p.
9168
9169 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9170
9171         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9172         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9173         set_gdbarch_num_pseudo_regs.
9174
9175 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9176
9177         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9178         Remove arg prefixname, add do_set and do_show.
9179         Add member functions set_list and show_list.
9180         * cli/cli-style.c (class cli_style_option): Update accordingly.
9181         (style_set_list): Move to file scope.
9182         (style_show_list): Likewise.
9183         (set_style): Call help_list.
9184         (show_style): Call cmd_show_list.
9185         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9186         Update to use the new macro.
9187
9188 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9189
9190         * ada-lang.c (_initialize_ada_language): Expand the help text
9191         for the "catch exception" command.
9192
9193 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9194
9195         * symtab.c (matching_obj_sections): Initialize obj,
9196         declare it closer to its usage.
9197
9198 2019-01-10  Tom Tromey  <tom@tromey.com>
9199
9200         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9201         (basic_inf_threads_range): Remove.
9202         (inf_threads_range, inf_non_exited_threads_range)
9203         (safe_inf_threads_range): Use next_adapter.
9204
9205 2019-01-10  Keith Seitz  <keiths@redhat.com>
9206
9207         PR gdb/23712
9208         PR symtab/23010
9209         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9210         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9211
9212 2019-01-10  Keith Seitz  <keiths@redhat.com>
9213
9214         PR gdb/23712
9215         PR symtab/23010
9216         * dictionary.c (pending_to_vector): Remove.
9217         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9218         Remove _1 suffix, replacing functions of the same name.  Update
9219         all callers.
9220         (dict_create_hashed, dict_create_hashed_expandable)
9221         (dict_create_linear, dict_create_linear_expandable, dict_free)
9222         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9223         Make functions static.
9224
9225 2019-01-10  Keith Seitz  <keiths@redhat.com>
9226
9227         PR gdb/23712
9228         PR symtab/23010
9229         * dictionary.h (struct dictionary): Replace declaration with
9230         multidictionary.
9231         (dict_create_hashed, dict_create_hashed_expandable)
9232         (dict_create_linear, dict_create_linear_expandable)
9233         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9234         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9235         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9236         taking multidictionary argument.
9237         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9238         * block.h (struct block) <dict>: Change to multidictionary
9239         and rename `multidict'.
9240         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9241         symmisc.c: Update all dictionary references to multidictionary.
9242
9243 2019-01-10  Keith Seitz  <keiths@redhat.com>
9244
9245         PR gdb/23712
9246         PR symtab/23010
9247         * dictionary.c: Include unordered_map.
9248         (pending_to_vector): New function.
9249         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9250         Rewrite the non-"_1" functions to take vector instead
9251         of linked list.
9252         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9253         "new" _1 versions of the same name.
9254         (multidictionary): Define.
9255         (std::hash<enum language): New definition.
9256         (collate_pending_symbols_by_language, mdict_create_hashed)
9257         (mdict_create_hashed_expandable, mdict_create_linear)
9258         (mdict_create_linear_expandable, mdict_free)
9259         (find_language_dictionary, create_new_language_dictionary)
9260         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9261         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9262         (mdict_size, mdict_empty): New functions.
9263         * dictionary.h (mdict_iterator): Define.
9264
9265 2019-01-10  Pedro Alves  <palves@redhat.com>
9266
9267         * breakpoint.c (read_uploaded_action)
9268         (create_tracepoint_from_upload): Adjust to use
9269         gdb::unique_xmalloc_ptr.
9270         * ctf.c (ctf_write_uploaded_tp):
9271         (SET_ARRAY_FIELD): Use emplace_back.
9272         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9273         * tracefile-tfile.c (tfile_write_uploaded_tp):
9274         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9275         gdb::unique_xmalloc_ptr.
9276         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9277         at_string, cond_string, cmd_strings>: Replace char pointers
9278         with gdb::unique_xmalloc_ptr.
9279
9280 2019-01-10  Pedro Alves  <palves@redhat.com>
9281
9282         * solib-target.c (library_list_start_library): Don't xstrdup name.
9283
9284 2019-01-10  Pedro Alves  <palves@redhat.com>
9285
9286         * mdebugread.c (parse_partial_symbols): Use
9287         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9288
9289 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * linux-fork.c (scoped_switch_fork_info)
9292         <~scoped_switch_fork_info>: Fix incorrect variable name.
9293
9294 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * linux-fork.c (scoped_switch_fork_info)
9297         <scoped_switch_fork_info>: Make explicit.
9298         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9299
9300 2019-01-10  Tom Tromey  <tom@tromey.com>
9301
9302         * objfiles.h (objfile::reset_psymtabs): Update.
9303         * objfiles.c (objfile::objfile): Update.
9304         * psymtab.h (psymtab_storage::obstack): Update.
9305         (psymtab_storage::m_obstack): Use gdb::optional.
9306         (class psymtab_storage): Update comment.  Remove objfile
9307         parameter.
9308         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9309
9310 2019-01-10  Tom Tromey  <tom@tromey.com>
9311
9312         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9313         <free_psymtabs>: Now private.
9314         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9315         (allocate_psymtab): Use new method.
9316
9317 2019-01-10  Tom Tromey  <tom@tromey.com>
9318
9319         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9320         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9321         * mdebugread.c (parse_partial_symbols): Use
9322         allocate_dependencies.
9323         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9324         allocate_dependencies.
9325         (process_psymtab_comp_unit_reader)
9326         (build_type_psymtab_dependencies): Likewise.
9327         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9328
9329 2019-01-10  Tom Tromey  <tom@tromey.com>
9330
9331         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9332         PSYMBOL_SET_LANGUAGE.
9333         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9334
9335 2019-01-10  Tom Tromey  <tom@tromey.com>
9336
9337         * psymtab.h (psymtab_storage::obstack): New method.
9338         <m_obstack>: Rename from obstack; now private.
9339         * psymtab.c (psymtab_storage): Update.
9340         * dwarf2read.c (create_addrmap_from_index)
9341         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9342         Update.
9343
9344 2019-01-10  Tom Tromey  <tom@tromey.com>
9345
9346         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9347         * objfiles.h (objfile::reset_psymtabs): New method.
9348
9349 2019-01-10  Tom Tromey  <tom@tromey.com>
9350
9351         * symmisc.c (print_symbol_bcache_statistics): Update.
9352         (print_objfile_statistics): Update.
9353         * symfile.c (reread_symbols): Update.
9354         * psymtab.h (class psymtab_storage): New.
9355         * psymtab.c (psymtab_storage): New constructor.
9356         (~psymtab_storage): New destructor.
9357         (require_partial_symbols): Update.
9358         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9359         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9360         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9361         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9362         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9363         (start_psymtab_common, end_psymtab_common)
9364         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9365         (allocate_psymtab): Update.
9366         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9367         Update.
9368         (dump_psymtab_addrmap, maintenance_print_psymbols)
9369         (maintenance_check_psymtabs): Update.
9370         (class objfile_psymtabs): Move to objfiles.h.
9371         * psympriv.h (discard_psymtab): Now inline.
9372         (psymtab_discarder::psymtab_discarder): Update.
9373         (psymtab_discarder::~psymtab_discarder): Update.
9374         (ALL_OBJFILE_PSYMTABS): Rewrite.
9375         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9376         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9377         Remove fields.
9378         <partial_symtabs>: New field.
9379         (class objfile_psymtabs): Move from psymtab.h.  Update.
9380         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9381         psymbol_cache.
9382         (objfile::~objfile): Don't destroy psymbol_cache.
9383         * mdebugread.c (parse_partial_symbols): Update.
9384         * dwarf2read.c (create_addrmap_from_index)
9385         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9386         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9387         (add_partial_subprogram, dwarf2_ranges_read): Update.
9388         * dwarf-index-write.c (write_address_map)
9389         (write_one_signatured_type, recursively_write_psymbols)
9390         (class debug_names, class debug_names, write_psymtabs_to_index):
9391         Update.
9392
9393 2019-01-10  Tom Tromey  <tom@tromey.com>
9394
9395         * symtab.h (SYMBOL_SET_NAMES): Update.
9396         (symbol_set_names): Update.
9397         (MSYMBOL_SET_NAMES): Update.
9398         * symtab.c (symbol_set_names): Change argument to be an
9399         objfile_per_bfd_storage.
9400         * psymtab.c (add_psymbol_to_bcache): Update.
9401         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9402
9403 2019-01-10  Tom Tromey  <tom@tromey.com>
9404
9405         * symtab.c (create_demangled_names_hash): Change argument to be an
9406         objfile_per_bfd_storage.
9407         (symbol_set_names): Update.
9408
9409 2019-01-10  Tom Tromey  <tom@tromey.com>
9410
9411         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9412         init_psymbol_list.
9413         * psymtab.c (init_psymbol_list): Do nothing if already called.
9414         * psympriv.h (init_psymbol_list): Add comment.
9415         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9416         init_psymbol_list.
9417         * dbxread.c (dbx_symfile_read): Unconditionally call
9418         init_psymbol_list.
9419
9420 2019-01-10  Tom Tromey  <tom@tromey.com>
9421
9422         * xcoffread.c (scan_xcoff_symtab): Update.
9423         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9424         "where".
9425         * mdebugread.c (parse_partial_symbols)
9426         (handle_psymbol_enumerators): Update.
9427         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9428         * dbxread.c (read_dbx_symtab): Update.
9429         * psympriv.h (psymbol_placement): New enum.
9430         (add_psymbol_to_list): Update.
9431
9432 2019-01-10  Tom Tromey  <tom@tromey.com>
9433
9434         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9435         static_psymbols parameters.
9436         (scan_xcoff_symtab): Update.
9437         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9438         static_psymbols parameters.
9439         * psympriv.h (start_psymtab_common): Update.
9440         * mdebugread.c (parse_partial_symbols): Update.
9441         * dwarf2read.c (create_partial_symtab): Update.
9442         * dbxread.c (read_dbx_symtab): Update.
9443         (start_psymtab): Remove global_psymbols and static_psymbols
9444         parameters.
9445
9446 2019-01-10  Tom Tromey  <tom@tromey.com>
9447
9448         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9449         * psymtab.c (allocate_psymtab): Add comment.
9450         * psympriv.h (allocate_psymtab): Add comment.
9451         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9452         initializations.
9453         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9454
9455 2019-01-10  Tom Tromey  <tom@tromey.com>
9456
9457         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9458         Don't declare.
9459         * mipsread.c: Include mdebugread.h.
9460         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9461         Declare.
9462         * elfread.c: Include mdebugread.h.
9463
9464 2019-01-09  Tom Tromey  <tom@tromey.com>
9465
9466         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9467         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9468         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9469         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9470         (psym_lookup_symbol, psym_find_last_source_symtab)
9471         (psym_forget_cached_source_info, psym_print_stats)
9472         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9473         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9474         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9475         (psym_find_compunit_symtab_by_address)
9476         (maintenance_print_psymbols, maintenance_info_psymtabs)
9477         (maintenance_check_psymtabs): Use ranged for.
9478         * psymtab.h (class objfile_psymtabs): New.
9479         (require_partial_symbols): Return objfile_psymtabs.
9480         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9481
9482 2019-01-09  Tom Tromey  <tom@tromey.com>
9483
9484         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9485         (find_pc_mapped_section, list_overlays_command)
9486         (map_overlay_command, unmap_overlay_command)
9487         (simple_overlay_update): Use all_objfiles.
9488         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9489         * printcmd.c (info_symbol_command): Use all_objfiles.
9490         * objfiles.h (ALL_OBJSECTIONS): Remove.
9491         * maint.c (maintenance_translate_address): Use all_objfiles.
9492         * gcore.c (gcore_create_callback): Use all_objfiles.
9493         (objfile_find_memory_regions): Likewise.
9494
9495 2019-01-09  Tom Tromey  <tom@tromey.com>
9496
9497         * symtab.c (find_line_symtab, info_sources_command)
9498         (make_source_files_completion_list): Use objfile_compunits.
9499         * source.c (select_source_symtab): Use objfile_compunits.
9500         * objfiles.h (struct objfile): Update comment.
9501         (ALL_OBJFILES): Remove.
9502         (ALL_FILETABS): Remove.
9503         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9504         objfile_compunits.
9505
9506 2019-01-09  Tom Tromey  <tom@tromey.com>
9507
9508         * symmisc.c (print_objfile_statistics, dump_objfile)
9509         (maintenance_print_symbols): Use compunit_filetabs.
9510         * source.c (forget_cached_source_info_for_objfile): Use
9511         compunit_filetabs.
9512         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9513         (ALL_FILETABS): Use compunit_filetabs.
9514         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9515         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9516
9517 2019-01-09  Tom Tromey  <tom@tromey.com>
9518
9519         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9520         (compunit_filetabs): New.
9521         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9522         compunit_filetabs.
9523         (info_sources_command, make_source_files_completion_list): Remove
9524         declaration.
9525         * symmisc.c (print_objfile_statistics, dump_objfile)
9526         (maintenance_print_symbols): Remove declaration.
9527         (maintenance_info_symtabs): Use compunit_filetabs.
9528         (maintenance_info_line_tables): Likewise.
9529         * source.c (select_source_symtab): Change local variable name.
9530         (forget_cached_source_info_for_objfile): Remove declaration.
9531         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9532         * objfiles.c (objfile_relocate1): Remove declaration.
9533         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9534         declaration.
9535         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9536         * coffread.c (coff_symtab_read): Remove declaration.
9537         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9538         compunit_filetabs.
9539
9540 2019-01-09  Tom Tromey  <tom@tromey.com>
9541
9542         * symtab.c (lookup_objfile_from_block)
9543         (find_pc_sect_compunit_symtab, search_symbols)
9544         (default_collect_symbol_completion_matches_break_on): Use
9545         objfile_compunits.
9546         * objfiles.h (ALL_COMPUNITS): Remove.
9547         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9548         * cp-support.c (add_symbol_overload_list_qualified): Use
9549         objfile_compunits.
9550         * ada-lang.c (ada_collect_symbol_completion_matches)
9551         (ada_add_global_exceptions): Use objfile_compunits.
9552
9553 2019-01-09  Tom Tromey  <tom@tromey.com>
9554
9555         * source.c (select_source_symtab)
9556         (forget_cached_source_info_for_objfile): Remove declaration.
9557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9558         declaration.
9559         * maint.c (count_symtabs_and_blocks): Remove declaration.
9560         * cp-support.c (add_symbol_overload_list_qualified): Remove
9561         declaration.
9562         * coffread.c (coff_symtab_read): Remove declaration.
9563         * symtab.c (lookup_symbol_in_objfile_symtabs)
9564         (basic_lookup_transparent_type_1): Use objfile_compunits.
9565         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9566         (info_sources_command, search_symbols)
9567         (default_collect_symbol_completion_matches_break_on)
9568         (make_source_files_completion_list): Remove declaration.
9569         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9570         (ada_collect_symbol_completion_matches)
9571         (ada_add_global_exceptions): Remove declaration.
9572         * linespec.c (iterate_over_all_matching_symtabs): Use
9573         objfile_compunits.
9574         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9575         (class objfile_compunits): New.
9576         (ALL_COMPUNITS): Use objfile_compunits.
9577         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9578         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9579         objfile_compunits.
9580         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9581
9582 2019-01-09  Tom Tromey  <tom@tromey.com>
9583
9584         * symtab.c (search_symbols)
9585         (default_collect_symbol_completion_matches_break_on): Use
9586         objfile_msymbols.
9587         * ada-lang.c (ada_lookup_simple_minsym)
9588         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9589         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9590         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9591         objfile_msymbols.
9592         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9593         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9594         * objc-lang.c (find_methods): Use objfile_msymbols.
9595         (info_selectors_command, info_classes_command): Likewise.
9596         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9597         * objfiles.h (class objfile_msymbols): New.
9598         (ALL_OBJFILE_MSYMBOLS): Remove.
9599         (ALL_MSYMBOLS): Remove.
9600
9601 2019-01-09  Tom Tromey  <tom@tromey.com>
9602
9603         * common/next-iterator.h (next_adapter): Add Iterator template
9604         parameter.
9605         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9606         (class all_objfiles_safe): New.
9607         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9608         * objfiles.c (put_objfile_before): Update comment.
9609         (add_separate_debug_objfile): Likewise.
9610         (free_all_objfiles): Use all_objfiles_safe.
9611         (objfile_purge_solibs): Likewise.
9612
9613 2019-01-09  Tom Tromey  <tom@tromey.com>
9614
9615         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9616         (expand_symtab_containing_pc, lookup_static_symbol)
9617         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9618         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9619         all_objfiles.
9620         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9621         * breakpoint.c (create_overlay_event_breakpoint)
9622         (create_longjmp_master_breakpoint)
9623         (create_std_terminate_master_breakpoint)
9624         (create_exception_master_breakpoint): Use all_objfiles.
9625         * linux-thread-db.c (try_thread_db_load_from_pdir)
9626         (has_libpthread): Use all_objfiles.
9627         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9628         * linespec.c (iterate_over_all_matching_symtabs)
9629         (search_minsyms_for_name): Use all_objfiles.
9630         * maint.c (maintenance_info_sections): Use all_objfiles.
9631         * main.c (captured_main_1): Use all_objfiles.
9632         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9633         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9634         * guile/scm-pretty-print.c
9635         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9636         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9637         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9638         (maintenance_print_msymbols): Use all_objfiles.
9639         * source.c (select_source_symtab): Use all_objfiles.
9640         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9641         * symfile.c (remove_symbol_file_command)
9642         (expand_symtabs_matching, map_symbol_filenames): Use
9643         all_objfiles.
9644         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9645         all_objfiles.
9646         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9647         * objc-lang.c (find_methods): Use all_objfiles.
9648         * objfiles.c (have_partial_symbols, have_full_symbols)
9649         (have_minimal_symbols, qsort_cmp)
9650         (default_iterate_over_objfiles_in_search_order): Use
9651         all_objfiles.
9652         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9653         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9654         (maintenance_check_psymtabs): Use all_objfiles.
9655         (ALL_PSYMTABS): Remove.
9656         * compile/compile-object-run.c (do_module_cleanup): Use
9657         all_objfiles.
9658         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9659         * cp-support.c (add_symbol_overload_list_qualified): Use
9660         all_objfiles.
9661         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9662         Use all_objfiles.
9663         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9664         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9665         all_objfiles.
9666         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9667         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9668         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9669         Uses all_objfiles.
9670         * solib.c (solib_read_symbols): Use all_objfiles
9671
9672 2019-01-09  Tom Tromey  <tom@tromey.com>
9673
9674         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9675         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9676         all_objfiles.
9677         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9678         * symmisc.c (print_symbol_bcache_statistics)
9679         (print_objfile_statistics, maintenance_print_objfiles)
9680         (maintenance_info_symtabs, maintenance_check_symtabs)
9681         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9682         all_objfiles.
9683         * source.c (forget_cached_source_info): Use all_objfiles.
9684         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9685         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9686         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9687         * objfiles.c (update_section_map): Use all_objfiles.
9688         (shared_objfile_contains_address_p): Likewise.
9689         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9690         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9691
9692 2019-01-09  Tom Tromey  <tom@tromey.com>
9693
9694         * common/next-iterator.h: New file.
9695         * objfiles.h (class all_objfiles): New.
9696         (struct objfile_iterator): New.
9697
9698 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9699
9700         * NEWS: Move the description of the changed "frame", "select-frame",
9701          and "info frame" commands to the Changed commands section.
9702
9703 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9704
9705         * gdbtypes.c (check_stub_method_group): Remove handling of old
9706         mangling schemes.
9707         * linespec.c (find_methods): Likewise.
9708         * stabsread.c (read_member_functions): Likewise.
9709         * valops.c (search_struct_method): Likewise.
9710         (value_struct_elt_for_reference): Likewise.
9711         * NEWS: Mention this change.
9712
9713 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9714
9715         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9716         print_source_lines.
9717         * source.c (print_source_lines_base): Update line number check.
9718         (print_source_lines): New function.
9719         (source_lines_range::source_lines_range): New function.
9720         * source.h (class source_lines_range): New class.
9721         (print_source_lines): New declaration.
9722
9723 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9724
9725         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9726
9727 2019-01-08  Tom Tromey  <tom@tromey.com>
9728             Simon Marchi  <simon.marchi@ericsson.com>
9729
9730         PR gdb/24060
9731         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9732         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9733         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9734         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9735         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9736         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9737
9738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9739
9740         * source.c (select_source_symtab): Move header comment to
9741         declaration in source.h.
9742         (forget_cached_source_info_for_objfile): Likewise.
9743         (forget_cached_source_info): Likewise.
9744         (identify_source_line): Likewise.
9745         * source.h (identify_source_line): Move declaration from symtab.h
9746         and add comment from source.c
9747         (print_source_lines): Likewise.
9748         (forget_cached_source_info_for_objfile): Likewise.
9749         (forget_cached_source_info): Likewise.
9750         (select_source_symtab): Likewise.
9751         (enum print_source_lines_flag): Move definition from symtab.h.
9752         * symtab.h (identify_source_line): Move declaration to source.h.
9753         (print_source_lines): Likewise.
9754         (forget_cached_source_info_for_objfile): Likewise.
9755         (forget_cached_source_info): Likewise.
9756         (select_source_symtab): Likewise.
9757         (enum print_source_lines_flag): Move definition to source.h.
9758         * tui/tui-hooks.c: Add 'source.h' include.
9759
9760 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9761
9762         * source.c (print_source_lines_base): Handle requests to print
9763         reverse line number sequences, and guard against empty lines
9764         string.
9765
9766 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9767
9768         * source.c (print_source_lines_base): Fix skip of '\r' if next
9769         character is '\n'.
9770
9771 2019-01-06  Tom Tromey  <tom@tromey.com>
9772
9773         * c-exp.y (struct c_parse_state) <macro_original_text,
9774         expansion_obstack>: New member.
9775         (macro_original_text, expansion_obstack): Remove globals.
9776         (scan_macro_expansion, scanning_macro_expansion)
9777         (finished_macro_expansion): Update.
9778         (scan_macro_cleanup): Remove.
9779         (yylex, c_parse): Update.
9780
9781 2019-01-06  Tom Tromey  <tom@tromey.com>
9782
9783         * c-exp.y (struct c_parse_state) <strings>: New member.
9784         (operator_stoken): Update.
9785
9786 2019-01-06  Tom Tromey  <tom@tromey.com>
9787
9788         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9789         (union type_stack_elt) <typelist_val>: Now a pointer to
9790         std::vector.
9791         (type_stack_cleanup): Don't declare.
9792         (push_typelist): Update.
9793         * parse.c (pop_typelist): Return a std::vector.
9794         (push_typelist): Take a std::vector.
9795         (follow_types): Update.  Do not free args.
9796         (type_stack_cleanup): Remove.
9797         * c-exp.y (struct c_parse_state): New.
9798         (cpstate): New global.
9799         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9800         (nonempty_typelist): Update.
9801         (func_mod): Create a new vector.
9802         (c_parse): Create a c_parse_state.
9803         (check_parameter_typelist): Do not delete params.
9804         (function_method): Update.  Do not delete type_list.
9805
9806 2019-01-06  Tom Tromey  <tom@tromey.com>
9807
9808         PR gdb/28155:
9809         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9810         check_typedef.
9811         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9812         (print_return_value): Likewise.
9813
9814 2019-01-05  Tom Tromey  <tom@tromey.com>
9815
9816         * contrib/cleanup_check.py: Remove.
9817         * contrib/gcc-with-excheck: Remove.
9818         * contrib/exsummary.py: Remove.
9819         * contrib/excheck.py: Remove.
9820
9821 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9822
9823         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9824         NULL. Initialize tpprev to NULL instead of assigning it
9825         to NULL on the next statement.
9826         * windows-nat.c (windows_delete_thread): Remove check for
9827         main_thread_id before printing thread exit notifications.
9828         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9829         Remove thread ID check against main_thread_id.
9830         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9831         windows_delete_thread.
9832         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9833
9834 2019-01-04  Tom Tromey  <tom@tromey.com>
9835
9836         * compile/compile.c (_initialize_compile): Use upper case for
9837         metasyntactic variables.
9838         * symmisc.c (_initialize_symmisc): Use upper case for
9839         metasyntactic variables.
9840         * psymtab.c (_initialize_psymtab): Use upper case for
9841         metasyntactic variables.
9842         * demangle.c (demangle_command): Use upper case for metasyntactic
9843         variables.
9844         (_initialize_demangler): Likewise.
9845         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9846         variables.
9847
9848 2019-01-03  Tom Tromey  <tom@tromey.com>
9849
9850         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9851
9852 2019-01-03  Tom Tromey  <tom@tromey.com>
9853
9854         * python/py-symtab.c (salpy_str): Update.
9855         (struct salpy_sal_object) <symtab>: Now a PyObject.
9856         (salpy_dealloc): Update.
9857         (del_objfile_sal): Use gdbpy_ref.
9858
9859 2019-01-03  Tom Tromey  <tom@tromey.com>
9860
9861         * python/py-type.c (convert_field): Use new_reference.  Return
9862         gdbpy_ref.
9863         (make_fielditem): Return gdbpy_ref.
9864         (typy_fields): Update.
9865         (typy_getitem): Update.
9866         (field_name): Return gdbpy_ref.  Use new_reference.
9867         (typy_iterator_iternext): Update.
9868
9869 2019-01-03  Tom Tromey  <tom@tromey.com>
9870
9871         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9872
9873 2019-01-03  Tom Tromey  <tom@tromey.com>
9874
9875         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9876         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9877         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9878         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9879         (pspy_set_type_printers): Likewise.
9880         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9881         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9882         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9883         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9884         (objfpy_set_type_printers): Likewise.
9885
9886 2019-01-03  Tom Tromey  <tom@tromey.com>
9887
9888         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9889         (gdbpy_print_stack): Use gdbpy_err_fetch.
9890         * python/python-internal.h (class gdbpy_err_fetch): New class.
9891         (class gdbpy_enter) <m_error_type, m_error_value,
9892         m_error_traceback>: Remove.
9893         <m_error>: New member.
9894         (gdbpy_exception_to_string): Don't declare.
9895         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9896         * python/py-value.c (convert_value_from_python): Use
9897         gdbpy_err_fetch.
9898         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9899         gdbpy_exception_to_string.
9900         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9901         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9902         gdbpy_err_fetch.
9903
9904 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9905
9906         * linux-nat.c (delete_lwp_cleanup): Delete.
9907         (struct lwp_deleter): New struct.
9908         (lwp_info_up): New typedef.
9909         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9910         lwp_info_up.
9911
9912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * linux-fork.c (class scoped_switch_fork_info): New class.
9915         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9916
9917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9918
9919         * valops.c (find_overload_match): Remove use of null_cleanup, and
9920         calls to do_cleanups.
9921
9922 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9923
9924         * compile/compile-cplus-types.c
9925         (compile_cplus_instance::decl_name): Handle changes to
9926         cp_func_name.
9927         * cp-support.c (cp_func_name): Update header comment, update
9928         return type.
9929         * cp-support.h (cp_func_name): Update return type in declaration.
9930         * valops.c (find_overload_match): Move temp_func local to top
9931         level of function and change its type.  Use temp_func to hold and
9932         delete temporary string obtained from cp_func_name.
9933
9934 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9935
9936         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9937         gdb::char_vector, remove cleanup, and update uses of `msg`.
9938
9939 2019-01-03  Jim Wilson  <jimw@sifive.com>
9940
9941         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9942
9943 2019-01-02  Tom Tromey  <tom@tromey.com>
9944
9945         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9946         (tdesc_parse_xml): Remove cleanups.
9947         * target-descriptions.h (make_cleanup_free_target_description):
9948         Don't declare.
9949         (target_desc_deleter): New struct.
9950         (target_desc_up): New typedef.
9951         * target-descriptions.c (target_desc_deleter::operator()): Rename
9952         from free_target_description.
9953         (make_cleanup_free_target_description): Remove.
9954
9955 2019-01-02  Tom Tromey  <tom@tromey.com>
9956
9957         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9958         constructor, destructor.
9959         (linespec_parser): Remove typedef.
9960         (~linespec_parser): Rename from linespec_parser_delete.
9961         (linespec_lex_to_end, linespec_complete_label)
9962         (linespec_complete): Update.
9963         (decode_line_full): Remove cleanups.
9964         (decode_line_1): Update.
9965
9966 2019-01-02  Tom Tromey  <tom@tromey.com>
9967
9968         * python/python-internal.h (inferior_to_inferior_object): Change
9969         return type.
9970         * python/py-exitedevent.c (create_exited_event_object): Update.
9971         * python/py-inferior.c (inferior_to_inferior_object): Return
9972         gdbpy_ref.
9973         (python_new_inferior, python_inferior_deleted)
9974         (thread_to_thread_object, delete_thread_object)
9975         (build_inferior_list, gdbpy_selected_inferior): Update.
9976         * python/py-infthread.c (create_thread_object): Update.  Also fail
9977         if inferior_to_inferior_object fails.
9978
9979 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9980
9981         * inferior.h (class inferior) <displaced_step_state>: New field.
9982         * infrun.h (struct displaced_step_state): Move here from
9983         infrun.c.  Initialize fields, add constructor.
9984         <inf>: Remove field.
9985         <reset>: New method.
9986         * infrun.c (struct displaced_step_inferior_state): Move to
9987         infrun.h.
9988         (displaced_step_inferior_states): Remove.
9989         (get_displaced_stepping_state): Adust.
9990         (displaced_step_in_progress_any_inferior): Adjust.
9991         (displaced_step_in_progress_thread): Adjust.
9992         (displaced_step_in_progress): Adjust.
9993         (add_displaced_stepping_state): Remove.
9994         (get_displaced_step_closure_by_addr): Adjust.
9995         (remove_displaced_stepping_state): Remove.
9996         (infrun_inferior_exit): Call displaced_step_state.reset.
9997         (use_displaced_stepping): Don't check for NULL.
9998         (displaced_step_prepare_throw): Call
9999         get_displaced_stepping_state.
10000         (displaced_step_fixup): Don't check for NULL.
10001         (prepare_for_detach): Don't check for NULL.
10002
10003 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10004
10005         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10006          in case of call that did not complete.
10007
10008 2019-01-02  Andrey Utkin  <autkin@undo.io>
10009
10010         * symfile.c (find_separate_debug_file): Fix search of debug files for
10011         remote debuggee.
10012
10013 2019-01-02  Tom Tromey  <tom@tromey.com>
10014
10015         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10016         indentation.
10017         * python/py-frame.c (frapy_older): Remove cast.
10018         (frapy_newer): Likewise.
10019         * python/py-breakpoint.c (local_setattro): Remove cast.
10020         * python/py-arch.c (archpy_name): Remove local variable.
10021         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10022
10023 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10024
10025         * unittests/basic_string_view/element_access/char/empty.cc:
10026         Fix year range in copyright header.
10027
10028 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10029
10030         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10031         Delete.
10032         <operator==>: Update with for removed field.
10033         <hash>: Likewise.
10034         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10035         <isa_features>: ...this.
10036         <abi_features>: New field.
10037         (riscv_isa_flen): Update comment.
10038         (riscv_abi_xlen): New declaration.
10039         (riscv_abi_flen): New declaration.
10040         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10041         isa_features.
10042         (riscv_abi_xlen): New function.
10043         (riscv_isa_flen): Update to get answer from isa_features.
10044         (riscv_abi_flen): New function.
10045         (riscv_has_fp_abi): Update to get answer from abi_features.
10046         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10047         xlen and flen.
10048         (riscv_call_info) <xlen, flen>: Update comment.
10049         (riscv_call_arg_struct): Remove invalid assertions
10050         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10051         is removed.
10052         (riscv_gdbarch_init): Gather isa features and abi features
10053         separately, ensure both match on the gdbarch when reusing an old
10054         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10055         a target with 64-bit float hardware.
10056
10057 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10058
10059         * source.c (search_command_helper): Stop reverse search
10060         when line 1 has been searched.
10061
10062 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10063
10064         * record-full.c (record_full_base_target::close): Rewrite
10065         record_full_core_buf_list free logic.
10066
10067 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10068
10069         * break-catch-syscall.c (print_one_catch_syscall): xfree
10070         the last text.
10071
10072 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10073
10074         * top.c (print_gdb_version): Update Copyright year in version
10075         message.
10076
10077 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10078
10079         Update copyright year range in all GDB files.
10080
10081 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10082
10083         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10084
10085 For older changes see ChangeLog-2018.
10086 \f
10087 Local Variables:
10088 mode: change-log
10089 left-margin: 8
10090 fill-column: 74
10091 version-control: never
10092 coding: utf-8
10093 End:
10094