gdb/ChangeLog

   1 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
   2
   3         * top.c (new_ui_command): Open specified terminal just once.
   4
   5 2019-07-18  Tom Tromey  <tromey@adacore.com>
   6
   7         * symtab.c (main_name): Constify return type.
   8         * symfile.c (set_initial_language): Update.
   9         * symtab.h (main_name): Constify return type.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-winsource.c (tui_update_source_window)
  14         (tui_update_source_window_as_is)
  15         (tui_update_source_windows_with_line): Remove return.
  16         * tui/tui-disasm.c (tui_show_disassem)
  17         (tui_show_disassem_and_update_source): Remove return.
  18         * tui/tui.c (tui_reset): Remove return.
  19         * tui/tui-wingeneral.c
  20         (tui_check_and_display_highlight_if_needed): Remove return.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.h (struct tui_exec_info_window)
  29         (struct tui_source_window_base): Move from tui-data.h.
  30         * tui/tui-winsource.c: Move many method definitions from
  31         elsewhere.  Remove "structuring" comments.
  32         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  33         (tui_source_window_base::refresh_window): Move to
  34         tui-winsource.c.
  35         * tui/tui-win.c (tui_source_window_base::refresh_all)
  36         (tui_source_window_base::update_tab_width)
  37         (tui_source_window_base::set_new_height)
  38         (tui_source_window_base::do_make_visible_with_new_height): Move to
  39         tui-winsource.c.
  40         * tui/tui-source.h: Update.
  41         * tui/tui-source.c (tui_source_window_base::reset): Move to
  42         tui-winsource.c.
  43         * tui/tui-disasm.h: Update.
  44         * tui/tui-data.h (struct tui_exec_info_window): Move to
  45         tui-winsource.h.
  46         (struct tui_source_window_base): Likewise.
  47         * tui/tui-data.c (tui_source_window_base::clear_detail)
  48         (tui_source_window_base, ~tui_source_window_base): Move to
  49         tui-winsource.c.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-win.c (tui_resize_all)
  54         (tui_source_window_base::update_tab_width)
  55         (tui_adjust_win_heights): Update.
  56         (tui_win_info::make_invisible_and_set_new_height): Rename from
  57         make_invisible_and_set_new_height.
  58         * tui/tui-data.h (struct tui_win_info)
  59         <make_invisible_and_set_new_height>: New method.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui.c: Update.
  64         * tui/tui-source.h (struct tui_source_window): Move from
  65         tui-data.h.
  66         * tui/tui-layout.c: Update.
  67         * tui/tui-disasm.c: Update.
  68         * tui/tui-data.h (struct tui_source_window): Move to
  69         tui-source.h.
  70
  71 2019-07-17  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  74         tui-data.h.
  75         * tui/tui-data.h (struct tui_disasm_window): Move to
  76         tui-disasm.h.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-regs.h (struct tui_data_item_window): Move from
  81         tui-data.h.
  82         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  83         * tui/tui-data.h (struct tui_data_item_window): Move to
  84         tui-regs.h.
  85         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui.c: Update.
  90         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  91         (tui_cmd_window::max_height): Move to tui-command.c.
  92         * tui/tui-layout.c: Update.
  93         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  94         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  95         tui-command.c.
  96         * tui/tui-command.h (struct tui_cmd_window): Move from
  97         tui-data.h.
  98         * tui/tui-command.c: Remove "structuring" comments.
  99         (tui_cmd_window::clear_detail)
 100         (tui_cmd_window::do_make_visible_with_new_height)
 101         (tui_cmd_window::max_height): Move from elsewhere.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 106         Now static.
 107         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 108         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui.c: Update.
 113         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 114         tui-regs.c.
 115         * tui/tui-windata.h: Remove file.
 116         * tui/tui-windata.c: Remove file.
 117         * tui/tui-win.c (tui_data_window::set_new_height)
 118         (tui_data_window::do_make_visible_with_new_height): Move to
 119         tui-regs.c.
 120         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 121         * tui/tui-regs.c: Remove "structuring" comments.
 122         (tui_data_window::first_data_item_displayed)
 123         (tui_data_window::delete_data_content_windows)
 124         (tui_data_window::erase_data_content)
 125         (tui_data_window::display_all_data)
 126         (tui_data_window::refresh_all)
 127         (tui_data_window::do_scroll_vertical)
 128         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 129         (tui_data_window::do_make_visible_with_new_height)
 130         (tui_data_window::refresh_window): Move from elsewhere.
 131         (_initialize_tui_regs): Move to end of file.
 132         * tui/tui-layout.c: Update.
 133         * tui/tui-hooks.c: Update.
 134         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 135         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 136         tui-regs.c.
 137         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 138
 139 2019-07-17  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 142         seen.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-win.c (tui_source_window_base::set_new_height)
 147         (tui_source_window_base::do_make_visible_with_new_height): Use
 148         m_has_locator field directly.
 149         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 150         method.
 151         (struct tui_source_window_base) <has_locator>: Likewise.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 156         Don't declare.
 157         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 158         Remove.
 159         * tui/tui-win.c (tui_source_window_base::set_new_height)
 160         (tui_source_window_base::set_new_height)
 161         (make_invisible_and_set_new_height)
 162         (tui_source_window_base::do_make_visible_with_new_height)
 163         (tui_source_window_base::do_make_visible_with_new_height):
 164         Update.
 165         * tui/tui-layout.c (show_source_disasm_command, show_data)
 166         (show_source_or_disasm_and_command): Update.
 167         * tui/tui-layout.c (show_layout): Update.
 168
 169 2019-07-17  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-layout.c (make_data_window): Remove.
 172         (show_data): Unify creation and re-initialization cases.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-layout.c (make_source_window, make_disasm_window):
 177         Remove.
 178         (show_data): Unify creation and re-initialization cases.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-layout.c (make_command_window): Remove.
 183         (show_source_disasm_command, show_source_or_disasm_and_command):
 184         Unify creation and re-initialization cases.
 185
 186 2019-07-17  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 189         creation and re-initialization cases.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-regs.c (tui_get_register): Return void.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 198         Simplify.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 203         resetting.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 208         * tui/tui-regs.c (tui_reg_layout): New function.
 209         (tui_show_registers, tui_reg_command): Use it.
 210         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 211         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 212         parameters.
 213         (tui_layout_command): Remove.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-layout.h (tui/tui-layout): Return void.
 218         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-layout.c (show_source_disasm_command, show_data):
 223         Update.
 224         (reset_locator): Remove.
 225         (show_source_or_disasm_and_command): Update.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-source.c (tui_source_window_base::reset): Remove
 230         win_type parameter.
 231         * tui/tui-layout.c (make_command_window, make_source_window)
 232         (make_disasm_window, make_data_window)
 233         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 234         (reset_locator, show_source_or_disasm_and_command): Update.
 235         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 236         win_type parameter.
 237         (struct tui_source_window_base) <reset>: Likewise.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-layout.c (show_source_disasm_command): Use
 242         reset_locator.
 243         (reset_locator): New function.
 244         (init_and_make_win): Remove.
 245         (show_source_or_disasm_and_command): Use reset_locator.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 250         condition.
 251         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 252         Remove condition.
 253         * tui/tui-source.c (tui_source_window_base::reset): New method.
 254         * tui/tui-layout.c (make_command_window): Don't call
 255         init_and_make_win.
 256         (make_source_window, make_disasm_window): Don't call
 257         make_source_or_disasm_window.
 258         (make_data_window): Don't call init_and_make_win.  Change calling
 259         convention.
 260         (show_source_disasm_command, show_data): Simplify.
 261         (make_source_or_disasm_window): Remove.
 262         (show_source_or_disasm_and_command): Simplify.
 263         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 264         (struct tui_source_window_base) <reset>: Likewise.
 265         <execution_info>: Remove initializer.
 266         * tui/tui-data.c (tui_source_window_base): Initialize
 267         execution_info.
 268
 269 2019-07-17  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 272         variable.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui.c (tui_rl_other_window): Update.
 277         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 278         superclass method first.  Always iterate over regs_content.
 279         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 280         method.
 281         * tui/tui-win.c (tui_set_focus_command): Update.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-win.c (tui_set_focus_command): Rename from
 286         tui_set_focus.  Call tui_enable.
 287         (tui_set_focus_command): Remove.
 288
 289 2019-07-17  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 292         refresh_window.
 293         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 294         touchwin.
 295         (tui_data_window::refresh_window): Call refresh_window on data
 296         items.  Always call superclass refresh_window.
 297         (tui_win_info::refresh): Remove.
 298         (tui_source_window_base::refresh_window): Update.
 299         (tui_refresh_all): Update.
 300         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 301         refresh_window.
 302         (show_source_or_disasm_and_command): Likewise.
 303         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 304         (struct tui_source_window_base) <refresh>: Likewise.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-winsource.c (tui_clear_source_content)
 309         (tui_show_source_content): Update.
 310         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 311         whether content is empty.
 312         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 313         Remove.
 314
 315 2019-07-17  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 318         window's contents.
 319         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 320         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 325         (struct tui_data_item_window): Update.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 330         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 331         defines.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-winsource.h (tui_erase_source_content)
 336         (tui_clear_source_content): Remove "display_prompt" parameter.
 337         * tui/tui-winsource.c (tui_update_source_window_as_is)
 338         (tui_update_source_windows_with_addr): Update.
 339         (tui_clear_source_content): Remove "display_prompt" parameter.
 340         (tui_erase_source_content): Likewise.  Simplify.
 341         (tui_show_source_content): Update.
 342         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 343         * tui/tui-stack.c (tui_show_frame_info): Update.
 344         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 345         Remove defines.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 350         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 351         parameter.
 352         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 353         parameter.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-winsource.c (tui_clear_source_content)
 358         (tui_show_source_content, tui_show_exec_info_content)
 359         (tui_clear_exec_info_content): Update.
 360         * tui/tui-stack.c (tui_show_locator_content): Update.
 361         (tui_show_frame_info): Update.
 362         * tui/tui-source.h (tui_source_window): Don't declare.
 363         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 364         from tui_source_is_displayed.
 365         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 366         Remove field.
 367         (struct tui_source_window_base) <content_in_use>: New field.  Now
 368         bool.
 369         (struct tui_source_window) <showing_source_p>: New method.
 370         (TUI_SRC_WIN): Change cast.
 371         * tui/tui-data.c (tui_initialize_static_data): Update.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 376         location_matches_p.
 377         * tui/tui-source.c (tui_source_window::location_matches_p): New
 378         method.
 379         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 380         method.
 381         * tui/tui-data.h (struct tui_source_window_base)
 382         <location_matches_p>: New method.
 383         (struct tui_source_window, struct tui_disasm_window)
 384         <location_matches_p>: Likewise.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-win.c (tui_set_win_height_command): Rename from
 389         tui_set_win_height.
 390         (tui_set_win_height_command): Remove.
 391
 392 2019-07-17  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-source.c (tui_source_window): New constructor.  Add
 395         observer.
 396         (~tui_source_window): New destructor.
 397         (tui_source_window::style_changed): New method.
 398         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 399         (tui_attach_detach_observers): Update.
 400         * tui/tui-data.h (struct tui_source_window): Make constructor not
 401         inline.  Add destructor.
 402         (struct tui_source_window) <style_changed>: New method.
 403         <m_observable>: New member.
 404
 405 2019-07-17  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 408         * tui/tui-win.c (tui_resize_all): Fix typo.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 413         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 414         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 415         * tui/tui-win.c (window_name_completer): Use foreach.
 416         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 417         (update_tab_width): Likewise.
 418         * tui/tui-layout.c (show_layout): Update.
 419         * tui/tui-data.h (class tui_window_iterator): New.
 420         (struct all_tui_windows): New.
 421         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 426         parameter.  Don't reference globals.
 427         (tui_reg_command): Update.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-regs.c (tui_show_registers): Simplify.
 432
 433 2019-07-17  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-regs.c (tui_show_registers): Update.
 436         (tui_show_register_group): Add win_info parameter.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 441         Rename from tui_display_reg_element_at_line.
 442         (tui_data_window::display_registers_from_line): Update.
 443         * tui/tui-data.h (struct tui_data_window)
 444         <display_reg_element_at_line>: New method.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-regs.h (tui_display_registers_from)
 449         (tui_display_registers_from_line): Don't declare.
 450         * tui/tui-windata.c (tui_data_window::display_all_data)
 451         (tui_data_window::refresh_all)
 452         (tui_data_window::do_scroll_vertical): Update.
 453         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 454         from tui_display_registers_from.
 455         (tui_display_reg_element_at_line): Update.
 456         (tui_data_window::display_registers_from_line): Rename from
 457         tui_display_registers_from_line.
 458         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 459         display_registers_from_line>: New methods.
 460
 461 2019-07-17  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 464         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 465         from tui_erase_data_content.
 466         (tui_data_window::display_all_data)
 467         (tui_data_window::refresh_all)
 468         (tui_data_window::do_scroll_vertical): Update.
 469         * tui/tui-regs.c (tui_show_registers): Update.
 470         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 471         New method.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 476         declare.
 477         * tui/tui-windata.c
 478         (tui_data_window::delete_data_content_windows): Rename from
 479         tui_delete_data_content_windows.
 480         (tui_data_window::display_all_data)
 481         (tui_data_window::do_scroll_vertical): Update.
 482         * tui/tui-data.h (struct tui_data_window)
 483         <delete_data_content_windows>: New method.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 488         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 493         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 494         from tui_display_all_data.
 495         * tui/tui-win.c
 496         (tui_data_window::do_make_visible_with_new_height): Update.
 497         * tui/tui-regs.c (tui_show_registers): Update.
 498         * tui/tui-layout.c (tui_set_layout): Update.
 499         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 500         method.
 501
 502 2019-07-17  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 505         * tui/tui-windata.c (tui_display_data_from): Remove.
 506         (tui_data_window::refresh_all): Update.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 511         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 512         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 513         tui_display_registers_from_line.
 514         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 515         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 516         "force_display" parameter.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 521         declare.
 522         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 523         Rename from tui_first_reg_element_no_inline.
 524         (tui_display_reg_element_at_line)
 525         (tui_display_registers_from_line): Update.
 526         * tui/tui-data.h (struct tui_data_window)
 527         <first_reg_element_no_inline>: New method.
 528
 529 2019-07-17  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-windata.c (tui_display_data_from)
 532         (tui_data_window::do_scroll_vertical): Update.
 533         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 534         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 535         Rename from tui_line_from_reg_element_no.
 536         (tui_display_registers_from_line): Update.
 537         * tui/tui-data.h (struct tui_data_window)
 538         <line_from_reg_element_no>: New method.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 543         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 544         tui_last_regs_line_no.
 545         (tui_display_reg_element_at_line)
 546         (tui_display_registers_from_line): Update.
 547         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 548         method.
 549
 550 2019-07-17  Tom Tromey  <tom@tromey.com>
 551
 552         PR tui/24722:
 553         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 554         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 555         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 556         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 557         (tui_update_breakpoint_info): Likewise.
 558         * tui/tui-hooks.c (tui_event_create_breakpoint)
 559         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 560         Update.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.c (tui_update_source_window_as_is)
 569         (tui_update_source_windows_with_addr): Update.
 570         * tui/tui-source.h (tui_set_source_content)
 571         (tui_show_symtab_source): Add "win_info" parameter.
 572         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 573         parameter.
 574         (tui_show_symtab_source): Likewise.
 575
 576 2019-07-17  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-wingeneral.c
 579         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 580
 581 2019-07-17  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 584         (struct tui_cmd_window) <can_scroll>: New method.
 585         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 586         method.
 587
 588 2019-07-17  Tom Tromey  <tromey@adacore.com>
 589
 590         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 591         do_field_signed>: Rename.  Change type of "value".
 592         * ui-out.c (ui_out::field_signed): Rename from field_int.
 593         Change type of "value".
 594         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 595         type of "value".
 596         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 597         do_field_int.  Change type of "value".
 598         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 599         do_field_int.  Change type of "value".
 600         * tracepoint.c (trace_status_mi, tfind_1)
 601         (print_one_static_tracepoint_marker): Update.
 602         * thread.c (print_thread_info_1, print_selected_thread_frame):
 603         Update.
 604         * stack.c (print_frame, print_frame_info): Update.
 605         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 606         Update.
 607         * source.c (print_source_lines_base): Update.
 608         * skip.c (info_skip_command): Update.
 609         * record-btrace.c (btrace_ui_out_decode_error)
 610         (btrace_call_history_src_line): Update.
 611         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 612         Update.
 613         * progspace.c (print_program_space): Update.
 614         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 615         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 616         do_field_int.  Change type of "value".
 617         * mi/mi-out.c (mi_ui_out::do_table_begin)
 618         (mi_ui_out::do_table_header): Update.
 619         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 620         type of "value".
 621         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 622         (mi_cmd_data_list_changed_registers, output_register)
 623         (mi_cmd_data_read_memory, mi_load_progress)
 624         (mi_cmd_trace_frame_collected): Update.
 625         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 626         Update.
 627         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 628         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 629         (mi_cmd_var_list_children, varobj_update_one): Update.
 630         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 631         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 632         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 633         * inferior.c (print_inferior): Update.
 634         * gdb_bfd.c (print_one_bfd): Update.
 635         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 636         Update.
 637         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 638         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 639         do_field_int.  Change type of "value".
 640         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 641         do_field_int.  Change type of "value".
 642         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 643         (print_one_breakpoint_location, print_it_catch_fork)
 644         (print_one_catch_fork, print_it_catch_vfork)
 645         (print_one_catch_vfork, print_it_catch_solib)
 646         (print_it_catch_exec, print_it_ranged_breakpoint)
 647         (print_mention_watchpoint, print_mention_masked_watchpoint)
 648         (bkpt_print_it, update_static_tracepoint): Update.
 649         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 650         * break-catch-syscall.c (print_it_catch_syscall): Update.
 651         * ada-tasks.c (print_ada_task_info): Update.
 652         * ada-lang.c (print_it_exception, print_mention_exception):
 653         Update.
 654
 655 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         PR breakpoints/24541
 658         * gdbarch.c: Regenerate.
 659         * gdbarch.h: Regenerate.
 660         * gdbarch.sh: Adjust return type and parameter types for
 661         'stap_adjust_register'.
 662         (i386_stap_adjust_register): Adjust signature and return new
 663         register name.
 664         * stap-probe.c (stap_parse_register_operand): Adjust use of
 665         'gdbarch_stap_adjust_register'.
 666
 667 2019-07-17  Tom Tromey  <tromey@adacore.com>
 668
 669         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 670         declare VEC.
 671         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 672         std::vector.
 673         (struct s390_process_info): Add initializers.
 674         (s390_add_process): Use new.
 675         (s390_linux_nat_target::low_forget_process): Use delete.
 676         (s390_linux_nat_target::low_new_fork)
 677         (s390_linux_nat_target::stopped_by_watchpoint)
 678         (s390_linux_nat_target::low_prepare_to_resume)
 679         (s390_linux_nat_target::insert_watchpoint)
 680         (s390_linux_nat_target::insert_hw_breakpoint)
 681         (s390_linux_nat_target::remove_watchpoint)
 682         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 683
 684 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 685
 686         * aarch64-fbsd-nat.c: Include regcache.h.
 687         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 688         argument.
 689         (aarch64_fbsd_nat_target::fetch_registers)
 690         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 691         variable.
 692         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 693
 694 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 695
 696         * fbsd-nat.c: Include gdbarch.h.
 697
 698 2019-07-15  Tom Tromey  <tromey@adacore.com>
 699
 700         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 701
 702 2019-07-15  Tom Tromey  <tromey@adacore.com>
 703
 704         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 705         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 706         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 707         * cli-out.c (cli_ui_out::do_field_int): New method.
 708         * ui-out.c (ui_out::field_unsigned): New method.
 709         * symfile.c (generic_load): Use field_unsigned.
 710         (print_transfer_performance): Likewise.
 711         * record-btrace.c (ui_out_field_uint): Remove.
 712         (btrace_call_history_insn_range, btrace_call_history): Use
 713         field_unsigned.
 714         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 715         field_unsigned.
 716         * ui-out.h (class ui_out) <field_unsigned>: New method.
 717         <do_field_unsigned>: Likewise.
 718
 719 2019-07-15  Tom Tromey  <tromey@adacore.com>
 720
 721         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 722         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 723         * target.c (flash_erase_command): Use field_string.
 724         * infrun.c (print_signal_received_reason): Use field_string.
 725         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 726         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 727         field_string.
 728         * ada-tasks.c (print_ada_task_info): Use field_string.
 729
 730 2019-07-15  Tom Tromey  <tromey@adacore.com>
 731
 732         * target.c (flash_erase_command): Use field_core_addr.
 733         * symfile.c (generic_load): Use field_core_addr.
 734         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 735         Use field_core_addr.
 736         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 737         field_core_addr.
 738
 739 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 740
 741         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 742         value if its desired type is smaller than a CORE_ADDR and signed.
 743
 744 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 745
 746         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 747         of changes to field names, and use new is_reference field to
 748         decide if a property is a reference or not.
 749         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 750         field.
 751         (struct dwarf2_property_baton): Update header comment, rename
 752         'referenced_type' to 'property_type' and update comments.
 753         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 754         default property type, store in property baton, update to take
 755         accound of renamed field.
 756         (read_func_scope): Update call to attr_to_dynamic_prop.
 757         (read_array_type): Likewise.
 758         (dwarf2_per_cu_addr_sized_int_type): New function.
 759         (read_subrange_index_type): Move type finding code to
 760         dwarf2_per_cu_addr_sized_int_type.
 761         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 762         (dwarf2_per_cu_addr_type): New function.
 763         (set_die_type): Update calls to attr_to_dynamic_prop.
 764
 765 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * dwarf2read.c (read_subrange_index_type): New function.
 768         (read_subrange_type): Move code into new function and call it.
 769         * gdbtypes.c (create_range_type): Add some asserts.
 770
 771 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 774         update return statements.
 775         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 776         declaration, and update comment to match.
 777         * gdbtypes.c (resolve_dynamic_array): Update call to
 778         dwarf2_evaluate_property to match new return type.
 779
 780 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * valarith.c (value_subscripted_rvalue): Change lowerbound
 783         parameter type from int to LONGEST.
 784         * value.h (value_subscripted_rvalue): Likewise in declaration.
 785
 786 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * cli/cli-utils.c (info_print_command_completer): New function.
 789         * cli/cli-utils.h: Add 'completer.h' include, and forward
 790         declaration for 'struct cmd_list_element'.
 791         (info_print_command_completer): Declare.
 792         * stack.c (_initialize_stack): Add completer for 'info locals' and
 793         'info args'.
 794         * symtab.c (_initialize_symtab): Add completer for 'info
 795         variables' and 'info functions'.
 796         * NEWS: Mention completion for additional info commands.
 797
 798 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * cli/cli-utils.c (extract_info_print_args): Delete.
 801         (extract_arg_maybe_quoted): Delete.
 802         (info_print_options_defs): New variable.
 803         (make_info_print_options_def_group): New function.
 804         (extract_info_print_options): Define new function.
 805         * cli/cli-utils.h (extract_info_print_args): Delete.
 806         (struct info_print_options): New structure.
 807         (extract_info_print_options): Declare new function.
 808         * stack.c (info_locals_command): Update to use new
 809         extract_info_print_options, also add a header comment.
 810         (info_args_command): Likewise.
 811         * symtab.c (info_variables_command): Likewise.
 812         (info_functions_command): Likewise.
 813
 814 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 815
 816         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 817         to extract string arguments.
 818         * common/common-utils.c (extract_string_maybe_quoted): New function.
 819         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 820
 821 2019-07-11  Tom Tromey  <tromey@adacore.com>
 822
 823         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 824         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 825         * top.h (gdbinit): Don't declare.
 826         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 827         into...
 828         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 829         * top.c (gdb_init): Don't call init_cli_cmds.
 830         (gdbinit): Remove.
 831         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 832
 833 2019-07-11  Tom Tromey  <tromey@adacore.com>
 834
 835         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 836         after it has been moved.
 837
 838 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 839
 840         * valops.c (value_must_coerce_to_target): Change return type to
 841         bool.
 842         * value.h (value_must_coerce_to_target): Likewise.
 843
 844 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 845
 846         * breakpoint.c (is_hardware_watchpoint): Remove
 847         forward-declaration.
 848         (is_masked_watchpoint): Change return type to bool.
 849         (is_tracepoint): Likewise.
 850         (is_breakpoint): Likewise.
 851         (is_hardware_watchpoint): Likewise.
 852         (is_watchpoint): Likewise.
 853         (is_no_memory_software_watchpoint): Likewise.
 854         (is_catchpoint): Likewise.
 855         (breakpoint_1): Make FILTER parameter's return type bool.
 856         is_masked_watchpoint): Change return type to bool.
 857         (save_breakpoints): Make FILTER parameter's return type bool.
 858         * breakpoint.h (is_breakpoint): Change return type to bool.
 859         (is_watchpoint): Likewise.
 860         (is_catchpoint): Likewise.
 861         (is_tracepoint): Likewise.
 862
 863 2019-07-10  Tom Tromey  <tom@tromey.com>
 864
 865         * defs.h: Don't include gdbarch.h.
 866         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 867         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 868         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 869         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 870         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 871         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 872         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 873         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 874         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 875         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 876         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 877         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 878         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 879         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 880         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 881         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 882         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 883         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 884         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 885         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 886         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 887         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 888         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 889         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 890         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 891         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 892         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 893
 894 2019-07-10  Tom Tromey  <tromey@adacore.com>
 895
 896         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 897         * breakpoint.c (init_ada_exception_breakpoint): Register as
 898         bp_catchpoint.
 899         (print_one_breakpoint_location, print_one_breakpoint): Use
 900         is_ada_exception_catchpoint.
 901         * ada-lang.c (class ada_catchpoint_location): Pass
 902         bp_loc_software_breakpoint to bp_location constructor.
 903         (is_ada_exception_catchpoint): New function.
 904
 905 2019-07-10  Tom Tromey  <tromey@adacore.com>
 906
 907         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 908         VEC.
 909         (struct arm_exidx_entry): New method operator<.
 910         (struct arm_exidx_data) <section_maps>: Change type.
 911         (arm_exidx_data_free): Remove.
 912         (arm_exidx_data_key): Change type.  Move lower.
 913         (arm_exidx_new_objfile): Update.
 914         (arm_compare_exidx_entries): Remove.
 915         (arm_find_exidx_entry, _initialize_arm_tdep)
 916
 917 2019-07-10  Tom Tromey  <tromey@adacore.com>
 918
 919         * solib-spu.c (ocl_program_data_key): Change type.
 920         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 921         Update.
 922
 923 2019-07-10  Tom Tromey  <tromey@adacore.com>
 924
 925         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 926         (struct solib_aix_inferior_data) <library_list>: Change type.
 927         (solib_aix_inferior_data_handle): Change type.
 928         (get_solib_aix_inferior_data): Update.
 929         (solib_aix_free_library_list): Remove.
 930         (library_list_start_library): Update.
 931         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 932         return type.
 933         (solib_aix_get_library_list)
 934         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 935         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 936
 937 2019-07-10  Tom Tromey  <tromey@adacore.com>
 938
 939         * solib-dsbt.c (struct dsbt_info): Add initializers.
 940         (solib_dsbt_pspace_data): Change type.
 941         (dsbt_pspace_data_cleanup): Remove.
 942         (get_dsbt_info, _initialize_dsbt_solib): Update.
 943
 944 2019-07-10  Tom Tromey  <tromey@adacore.com>
 945
 946         * spu-tdep.c (spu_overlay_data): Change type.
 947         (spu_get_overlay_table, spu_overlay_new_objfile)
 948         (_initialize_spu_tdep): Update.
 949
 950 2019-07-10  Tom Tromey  <tromey@adacore.com>
 951
 952         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 953         destructor.
 954         (dbx_objfile_data_key): Change type and declare later.
 955         (DBX_SYMFILE_INFO): Rewrite.
 956         * dbxread.c (dbx_objfile_data_key): Change type.
 957         (dbx_symfile_init): Update.
 958         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 959         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 960         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 961
 962 2019-07-10  Tom Tromey  <tromey@adacore.com>
 963
 964         * jit.c (jit_program_space_key): Change type.  Move lower.
 965         (get_jit_program_space_data): Update.
 966         (jit_program_space_data_cleanup): Remove.
 967         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 968         Update.
 969         (struct jit_program_space_data): Add initializers.
 970
 971 2019-07-10  Tom Tromey  <tromey@adacore.com>
 972
 973         * solib-darwin.c (struct darwin_info): Add initializers.
 974         (solib_darwin_pspace_data): Change type.
 975         (darwin_pspace_data_cleanup): Remove.
 976         (get_darwin_info, _initialize_darwin_solib): Update.
 977
 978 2019-07-10  Tom Tromey  <tromey@adacore.com>
 979
 980         * remote-sim.c (struct sim_inferior_data): Add initializers,
 981         constructor, and destructor.
 982         (sim_inferior_data_key): Change type.  Move lower.
 983         (check_for_duplicate_sim_descriptor): Update.
 984         (get_sim_inferior_data): Use new.  Update.
 985         (~sim_inferior_data_cleanup): Rename from
 986         sim_inferior_data_cleanup.  Simplify.
 987         (gdbsim_close_inferior, simulator_command)
 988         (sim_command_completer, _initialize_remote_sim): Update.
 989         (next_pid, INITIAL_PID): Move earlier.
 990
 991 2019-07-10  Tom Tromey  <tromey@adacore.com>
 992
 993         * python/python-internal.h (create_thread_object): Return
 994         gdbpy_ref.
 995         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 996         * python/py-inferior.c (struct threadlist_entry): Add
 997         constructor.
 998         <thread_obj>: Now a gdbpy_ref.
 999         (thread_to_thread_object): Update.
1000         (add_thread_object): Use new.
1001         (delete_thread_object): Use delete.
1002         (infpy_threads): Update.
1003         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1004         GIL.
1005
1006 2019-07-10  Tom Tromey  <tromey@adacore.com>
1007
1008         * valops.c (value_cast): Specialize error message for Ada.
1009
1010 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1011
1012         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1013
1014 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1015
1016         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1017         bpstat_should_step): Return bool, adjust comments.
1018         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1019         bpstat_should_step): Likewise.
1020
1021 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1022
1023         * features/Makefile: Use feature target descriptions for Arm.
1024         * features/arm/arm-core.c: Generate new file.
1025         * features/arm/arm-fpa.c: Likewise.
1026         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1027         * features/arm/arm-m-profile.c: Likewise.
1028         * features/arm/arm-vfpv2.c: Likewise.
1029         * features/arm/arm-vfpv3.c: Likewise.
1030         * features/arm/xscale-iwmmxt.c: Likewise.
1031         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1032
1033 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1034
1035         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1036         ptrace earlier.
1037
1038 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1039
1040         * features/aarch64-pauth.c: Regenerate.
1041
1042 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1043
1044         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1045         bool.
1046         (bpstat_what): Use false instead of 0.
1047
1048 2019-07-09  Pedro Alves  <palves@redhat.com>
1049
1050         * break-catch-throw.c (is_exception_catchpoint): New.
1051         * breakpoint.c (print_one_breakpoint_location): New parameter
1052         'raw_loc'.  Handle it.  Use
1053         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1054         looking at the breakpoint's type.
1055         (print_one_breakpoint): If handling "maint info breakpoints", also
1056         print locations of exception catchpoints.
1057         * breakpoint.h (is_exception_catchpoint): Declare.
1058
1059 2019-07-09  Pedro Alves  <palves@redhat.com>
1060
1061         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1062         "addr" field.
1063         (allocate_location_exception_catchpoint): New.
1064         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1065         (initialize_throw_catchpoint_ops): Install
1066         allocate_location_exception_catchpoint as allocate_location
1067         method.
1068         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1069         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1070         bp_loc_other.
1071         (breakpoint_address_is_meaningful): Delete.
1072         (bl_address_is_meaningful): New.
1073         (breakpoint_locations_match): Adjust comment.
1074         (bp_location_from_bp_type): New, factored out of...
1075         (bp_location::bp_location(breakpoint *)): ... this.
1076         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1077         factored out of...
1078         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1079         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1080         breakpoint_address_is_meaningful.
1081         (bp_locations_compare): Adjust comment.
1082         (update_global_location_list): Use bl_address_is_meaningful
1083         instead of breakpoint_address_is_meaningful.
1084         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1085         explicit.
1086         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1087         * python/py-breakpoint.c (bppy_get_location): No longer check
1088         whether location is null.
1089
1090 2019-07-09  Pedro Alves  <palves@redhat.com>
1091
1092         PR c++/15468
1093         * breakpoint.c (print_one_breakpoint_location): Remove
1094         single-location assert.
1095
1096 2019-07-09  Tom Tromey  <tom@tromey.com>
1097
1098         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1099         * configure: Rebuild.
1100         * configure.ac: Change common to gdbsupport.
1101         * gdbsupport: Rename from common.
1102         * acinclude.m4: Change common to gdbsupport.
1103         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1104         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1105         gdbsupport.
1106         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1107         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1108         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1109         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1110         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1111         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1112         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1113         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1114         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1115         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1116         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1117         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1118         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1119         coff-pe-read.c, command.h, compile/compile-c-support.c,
1120         compile/compile-c.h, compile/compile-cplus-symbols.c,
1121         compile/compile-cplus-types.c, compile/compile-cplus.h,
1122         compile/compile-loc2c.c, compile/compile.c, completer.c,
1123         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1124         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1125         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1126         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1127         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1128         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1129         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1130         features/aarch64-core.c, features/aarch64-fpu.c,
1131         features/aarch64-pauth.c, features/aarch64-sve.c,
1132         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1133         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1134         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1135         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1136         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1137         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1138         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1139         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1140         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1141         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1142         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1143         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1144         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1145         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1146         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1147         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1148         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1149         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1150         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1151         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1152         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1153         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1154         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1155         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1156         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1157         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1158         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1159         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1160         minsyms.c, mips-linux-tdep.c, namespace.h,
1161         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1162         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1163         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1164         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1165         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1166         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1167         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1168         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1169         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1170         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1171         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1172         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1173         procfs.c, producer.c, progspace.h, psymtab.h,
1174         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1175         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1176         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1177         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1178         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1179         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1180         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1181         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1182         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1183         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1184         target-memory.c, target.c, target.h, target/waitstatus.c,
1185         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1186         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1187         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1188         unittests/array-view-selftests.c,
1189         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1190         unittests/common-utils-selftests.c,
1191         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1192         unittests/format_pieces-selftests.c,
1193         unittests/function-view-selftests.c,
1194         unittests/lookup_name_info-selftests.c,
1195         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1196         unittests/mkdir-recursive-selftests.c,
1197         unittests/observable-selftests.c,
1198         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1199         unittests/parse-connection-spec-selftests.c,
1200         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1201         unittests/scoped_fd-selftests.c,
1202         unittests/scoped_mmap-selftests.c,
1203         unittests/scoped_restore-selftests.c,
1204         unittests/string_view-selftests.c, unittests/style-selftests.c,
1205         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1206         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1207         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1208         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1209         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1210         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1211
1212 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1215         bool value.
1216         (decode_digits_ordinary): Set explicit_line field in sal.
1217         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1218         symtab_and_line that was set on an explicit line number in
1219         assembler code.  Do always update the recorded symtab and line if
1220         we do skip the prologue.
1221
1222 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * breakpoint.c (set_breakpoint_location_function): Remove
1225         explicit_loc parameter.
1226         (momentary_breakpoint_from_master): Update call to
1227         set_breakpoint_location_function.
1228         (add_location_to_breakpoint): Likewise.
1229
1230 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1233         required features based on default bfd type when no specific bfd
1234         is present.
1235
1236 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1237
1238         * NEWS: Mention that GDB printf and eval commands can now print
1239         C-style and Ada-style convenience var strings without
1240         calling the inferior.
1241         * printcmd.c (printf_c_string): Locally print GDB internal var
1242         instead of transiting via the inferior.
1243         (printf_wide_c_string): Likewise.
1244
1245 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1246
1247         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1248
1249 2019-07-04  Tom Tromey  <tom@tromey.com>
1250
1251         PR tui/24724:
1252         * tui/tui-winsource.c (tui_clear_source_content): Update.
1253         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1254         (tui_update_breakpoint_info): Update.
1255         (tui_set_exec_info_content): Update.
1256         * tui/tui-source.c (tui_set_source_content_nil): Update.
1257         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1258         has_break.
1259         * tui/tui-data.h (enum tui_bp_flag): New.
1260         (tui_bp_flags): New enum flags type.
1261         (struct tui_source_element) <break_mode>: Change type.  Rename
1262         from has_break.
1263         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1264         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1265         constants.
1266         * tui/tui-winsource.h: Fix comment.
1267
1268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1271         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1272         (store_fpregs_to_thread)
1273         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1274         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1275         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1276         (IWMMXT_REGS_SIZE): Add define.
1277         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1278         (fetch_vfp_regs, store_vfp_regs)
1279         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1280         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1281
1282 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1285         defines.
1286         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1287         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1288         (ARM_INT_REGISTER_SIZE): ...to this.
1289         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1290         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1291         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1292         (arm_linux_collect_gregset, supply_nwfpe_register)
1293         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1294         defines.
1295         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1296         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1297         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1298         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1299         (arm_return_in_memory, arm_store_return_value)
1300         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1301         (arm_record_ld_st_multiple): Likewise.
1302         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1303         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1304
1305 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1308         AARCH64_DISPLACED_MODIFIED_INSNS.
1309         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1310         (aarch64_displaced_step_copy_insn): Likewise.
1311         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1312         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1313         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1314         ARM_DISPLACED_MODIFIED_INSNS.
1315         * arm-tdep.c (arm_gdbarch_init): Likewise.
1316         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1317         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1318         (struct arm_displaced_step_closure): Use
1319         ARM_DISPLACED_MODIFIED_INSNS.
1320
1321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1322
1323         * features/Makefile: Remove unused xml files.
1324         * features/aarch64.xml: Remove.
1325         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1326         * features/i386/amd64-avx-avx512.xml: Remove.
1327         * features/i386/amd64-avx-linux.xml: Remove.
1328         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1329         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1330         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1331         * features/i386/amd64-avx-mpx.xml: Remove.
1332         * features/i386/amd64-avx.xml: Remove.
1333         * features/i386/amd64-linux.xml: Remove.
1334         * features/i386/amd64-mpx-linux.xml: Remove.
1335         * features/i386/amd64-mpx.xml: Remove.
1336         * features/i386/amd64.xml: Remove.
1337         * features/i386/i386-avx-avx512-linux.xml: Remove.
1338         * features/i386/i386-avx-avx512.xml: Remove.
1339         * features/i386/i386-avx-linux.xml: Remove.
1340         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1341         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1342         * features/i386/i386-avx-mpx-linux.xml: Remove.
1343         * features/i386/i386-avx-mpx.xml: Remove.
1344         * features/i386/i386-avx.xml: Remove.
1345         * features/i386/i386-linux.xml: Remove.
1346         * features/i386/i386-mmx-linux.xml: Remove.
1347         * features/i386/i386-mmx.xml: Remove.
1348         * features/i386/i386-mpx-linux.xml: Remove.
1349         * features/i386/i386-mpx.xml: Remove.
1350         * features/i386/i386.xml: Remove.
1351         * features/i386/x32-avx-avx512-linux.xml: Remove.
1352         * features/i386/x32-avx-linux.xml: Remove.
1353         * features/i386/x32-linux.xml: Remove.
1354
1355 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1356
1357         * regformats/aarch64.dat: Remove.
1358         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1359         * regformats/i386/amd64-avx-linux.dat: Remove.
1360         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1361         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1362         * regformats/i386/amd64-linux.dat: Remove.
1363         * regformats/i386/amd64-mpx-linux.dat: Remove.
1364         * regformats/i386/amd64.dat: Remove.
1365         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1366         * regformats/i386/i386-avx-linux.dat: Remove.
1367         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1368         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1369         * regformats/i386/i386-linux.dat: Remove.
1370         * regformats/i386/i386-mmx-linux.dat: Remove.
1371         * regformats/i386/i386-mpx-linux.dat: Remove.
1372         * regformats/i386/i386.dat: Remove.
1373         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1374         * regformats/i386/x32-avx-linux.dat: Remove.
1375         * regformats/i386/x32-linux.dat: Remove.
1376
1377 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1378
1379         * aarch64-tdep.c: Remove xml self tests.
1380         * amd64-linux-tdep.c: Likewise.
1381         * amd64-tdep.c: Likewise.
1382         * i386-linux-tdep.c: Likewise.
1383         * i386-tdep.c: Likewise.
1384
1385 2019-07-03  Pedro Alves  <palves@redhat.com>
1386
1387         PR cli/24732
1388         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1389         (pipe_cmd_option_defs): New.
1390         (make_pipe_cmd_options_def_group): New.
1391         (pipe_command): Use gdb::option::process_options.
1392         (pipe_command_completer): New function.
1393         (_initialize_cli_cmds): Install completer for "pipe" command.
1394
1395 2019-07-03  Pedro Alves  <palves@redhat.com>
1396
1397         * cli/cli-option.c (union option_value) <string>: New field.
1398         (struct option_def_and_value): Add ctor, move ctor, dtor and
1399         use DISABLE_COPY_AND_ASSIGN.
1400         (option_def_and_value::clear_value): New.
1401         (parse_option, save_option_value_in_ctx, get_val_type_str)
1402         (add_setshow_cmds_for_options): Handle var_string.
1403         * cli-option.h (union option_def::var_address) <string>: New
1404         field.
1405         (struct string_option_def): New.
1406         * maint-test-options.c (struct test_options_opts): Add default
1407         ctor and use DISABLE_COPY_AND_ASSIGN.
1408         <string_opt>: New field.
1409         (test_options_opts::~test_options_opts): New.
1410         (test_options_opts::dump): Also dump "-string".
1411         (test_options_option_defs): Install "string.
1412
1413 2019-07-03  Pedro Alves  <palves@redhat.com>
1414
1415         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1416         option_value with a null enumeration.
1417         (complete_options): Save the option values in the context.
1418         (save_option_value_in_ctx): New, factored out from ...
1419         (process_options): ... here.
1420         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1421         of the function.
1422         * maint-test-options.c (test_options_opts::dump): New, factored
1423         out from ...
1424         (maintenance_test_options_command_mode): ... here.
1425         (maintenance_test_options_command_completion_result): Delete.
1426         (maintenance_test_options_command_completion_text): Update
1427         comment.
1428         (maintenance_show_test_options_completion_result): Change
1429         prototype.  Just print
1430         maintenance_test_options_command_completion_text.
1431         (save_completion_result): New.
1432         (maintenance_test_options_completer_mode): Pass options context to
1433         complete_options, and then save a dump.
1434         (_initialize_maint_test_options): Use add_cmd to install "maint
1435         show test-options-completion-result".
1436
1437 2019-07-03  Pedro Alves  <palves@redhat.com>
1438
1439         * NEWS (New commands): Mention "with" and "maint with".
1440         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1441         (with_command, with_command_completer): New.
1442         (pipe_command): Adjust to new repeat_previous
1443         interface.
1444         (_initialize_cli_cmds): Install the "with" command and its "w"
1445         alias.
1446         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1447         declarations.
1448         * cli/cli-setshow.c (parse_cli_var_uinteger)
1449         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1450         argument strings for all var_types.
1451         (get_setshow_command_value_string): New, factored out from ...
1452         (do_show_command): ... this.
1453         * cli/cli-setshow.h: Include <string>.
1454         (get_setshow_command_value_string): Declare.
1455         * command.h (repeat_previous): Now returns const char *.  Adjust
1456         comment.
1457         * maint.c: Include "cli/cli-cmds.h".
1458         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1459         (_initialize_maint_cmds): Register the "maintenance with" command.
1460         * top.c (repeat_previous): Move bits from pipe_command here:
1461         Return the saved command line, if any; error out if there's no
1462         command to relaunch.
1463
1464 2019-07-03  Pedro Alves  <palves@redhat.com>
1465
1466         * NEWS (New commands): Mention "maint set/show test-settings"
1467         instead of "maint test-settings".
1468         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1469         (maintenance_test_settings_set_list): Rename to ...
1470         (maintenance_set_test_settings_list): ... this.
1471         (maintenance_test_settings_show_list): Rename to  ...
1472         (maintenance_show_test_settings_list): ... this.
1473         (maintenance_test_settings_cmd): Delete.
1474         (maintenance_test_settings_set_cmd): ...
1475         (maintenance_set_test_settings_cmd): ... this.
1476         (maintenance_test_settings_show_cmd): ...
1477         (maintenance_show_test_settings_cmd): ... this.
1478         (maintenance_test_settings_show_value_cmd):
1479         (maintenance_show_test_settings_value_cmd): ... this.
1480         (_initialize_maint_test_settings): No longer install the "maint
1481         test-settings" prefix command.  Rename "maint test-settings set"
1482         to "maint set test-settings", and "maint test-settings show" to
1483         "maint show test-settings".  Adjust all subcommands.
1484
1485 2019-07-03  Pedro Alves  <palves@redhat.com>
1486
1487         * maint-test-settings.c: Fix file's intro comment.  Replace all
1488         references to "test-options" with references to "test-settings",
1489         in comments.
1490
1491 2019-07-03  Pedro Alves  <palves@redhat.com>
1492
1493         * maint-test-settings.c (maintenance_test_settings_xxx)
1494         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1495         New.
1496         (maintenance_test_settings_enums): Use them.
1497         (maintenance_test_settings_enum): Default to
1498         maintenance_test_settings_xxx.
1499         (_initialize_maint_test_settings): Initialize
1500         MAINTENANCE_TEST_SETTINGS_FILENAME.
1501
1502 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1503
1504         * breakpoint.h (remove_breakpoints_inf): Change return type to
1505         void, move function documentation here.
1506         * breakpoint.c (remove_breakpoints_inf): Change return type to
1507         void, move function documentation to header.
1508
1509 2019-07-02  Pedro Alves  <palves@redhat.com>
1510
1511         * NEWS (Completion improvements): Mention "info threads".
1512         * thread.c (struct info_threads_opts, info_threads_option_defs)
1513         (make_info_threads_options_def_group): New.
1514         (info_threads_command): Use gdb::option::process_options.
1515         (info_threads_command_completer): New.
1516         (_initialize_thread): Use gdb::option::build_help to build the
1517         help text for "info threads".
1518
1519 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1520
1521         * defs.h (generic_load): Move from here...
1522         * symfile.h (generic_load): ... to here.  Rename name parameter
1523         to args.
1524         * symfile.c (generic_load): Add comment.
1525
1526 2019-07-01  Tom Tromey  <tromey@adacore.com>
1527
1528         * dwarf2read.c
1529         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1530         declaration of without_params.  Fix formatting.
1531
1532 2019-07-01  Tom Tromey  <tromey@adacore.com>
1533
1534         * ada-exp.y (find_primitive_type): Update.
1535         * ada-lang.h (ada_lookup_symbol): Update.
1536         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1537         parameter.
1538         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1539
1540 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1541
1542         PR breakpoints/24541
1543         * gdbarch.c: Regenerate.
1544         * gdbarch.h: Regenerate.
1545         * gdbarch.sh: Add 'stap_adjust_register'.
1546         * i386-tdep.c: Include '<unordered_set>'.
1547         (i386_stap_adjust_register): New function.
1548         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1549         * stap-probe.c (stap_parse_register_operand): Call
1550         'gdbarch_stap_adjust_register'.
1551
1552 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1553
1554         PR python/24742
1555         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1556         * python/python.c (do_start_initialization): Use 'xmalloc'
1557         instead of 'PyMem_Malloc'.
1558
1559 2019-06-28  Tom Tromey  <tromey@adacore.com>
1560
1561         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1562         for Ada.
1563
1564 2019-06-27  Tom Tromey  <tromey@adacore.com>
1565
1566         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1567         objfile_key.
1568         (arm_find_mapping_symbol, arm_record_special_symbol)
1569         (_initialize_arm_tdep): Update.
1570         (arm_objfile_data_free): Remove.
1571
1572 2019-06-27  Tom Tromey  <tromey@adacore.com>
1573
1574         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1575         to cp_print_static_field.
1576
1577 2019-06-26  Tom Tromey  <tromey@adacore.com>
1578
1579         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1580         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1581         declare.
1582
1583 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1584
1585         * features/aarch64-core.c (create_feature_aarch64_core):
1586         Regenerate.
1587         * features/aarch64-core.xml: Add cpsr flags.
1588
1589 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1592         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1593
1594 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1595
1596         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1597         field.
1598         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1599         use.
1600         (arm_record_special_symbol): Don't insert new symbol in sorted
1601         position, push it at the end.
1602
1603 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1604
1605         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1606         (arm_mapping_symbol_s): Remove.
1607         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1608         (arm_mapping_symbol_vec): New typedef.
1609         (struct arm_per_objfile): Add constructor.
1610         <section_maps>: Change type to
1611         std::unique_ptr<arm_mapping_symbol_vec[]>.
1612         (arm_compare_mapping_symbols): Remove.
1613         (arm_find_mapping_symbol): Adjust to section_maps type change.
1614         (arm_objfile_data_free): Call delete on arm_per_objfile.
1615         (arm_record_special_symbol): Adjust to section_maps type change.
1616         Allocate arm_per_objfile with new.
1617
1618 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1619
1620         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1621         with the command prefix.
1622
1623 2019-06-25  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1626         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1627
1628 2019-06-25  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1631         type.
1632         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1633         protected.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-winsource.c
1638         (tui_source_window_base::set_is_exec_point_at): Add check against
1639         LOA_ADDRESS.
1640
1641 2019-06-25  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-source.c (tui_set_source_content): Don't check before
1644         xfree.
1645         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-winsource.h (tui_update_source_window_as_is)
1650         (tui_alloc_source_buffer, tui_line_is_displayed)
1651         (tui_addr_is_displayed): Change type of win_info.
1652         * tui/tui-winsource.c (tui_update_source_window_as_is)
1653         (tui_clear_source_content, tui_show_source_line)
1654         (tui_show_source_content, tui_source_window_base::refill)
1655         (tui_source_window_base::set_is_exec_point_at)
1656         (tui_source_window_base::set_is_exec_point_at)
1657         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1658         (tui_alloc_source_buffer, tui_line_is_displayed)
1659         (tui_addr_is_displayed): Change type of win_info.  Update.
1660         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1661         (tui_source_window_base::do_make_visible_with_new_height):
1662         Update.
1663         * tui/tui-source.c (tui_set_source_content)
1664         (tui_set_source_content_nil)
1665         (tui_source_window::do_scroll_vertical): Update.
1666         * tui/tui-layout.c (show_layout): Update.
1667         * tui/tui-disasm.c (tui_set_disassem_content)
1668         (tui_disasm_window::do_scroll_vertical): Update.
1669         * tui/tui-data.h (tui_win_content): Remove.
1670         (struct tui_gen_win_info) <content, content_size>: Remove.
1671         (struct tui_source_element): Add initializers and destructor.
1672         (union tui_which_element, struct tui_win_element): Remove.
1673         (struct tui_source_window_base) <content>: New field.
1674         (struct tui_data_window): Remove destructor.
1675         (tui_alloc_content, tui_free_win_content)
1676         (tui_free_all_source_wins_content): Don't declare.
1677         * tui/tui-data.c (tui_initialize_static_data): Update.
1678         (init_content_element, tui_alloc_content): Remove.
1679         (~tui_gen_win_info): Update.
1680         (~tui_data_window, tui_free_all_source_wins_content)
1681         (tui_free_win_content, free_content, free_content_elements):
1682         Remove.
1683
1684 2019-06-25  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-winsource.h (tui_clear_source_content)
1687         (tui_erase_source_content, tui_show_source_content): Change type
1688         of win_info.
1689         * tui/tui-winsource.c (tui_clear_source_content)
1690         (tui_erase_source_content, tui_show_source_content): Change type
1691         of win_info.
1692         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1693         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1694         win_info.
1695         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1696         win_info.
1697         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-winsource.c (tui_clear_source_content)
1702         (tui_source_window_base::set_is_exec_point_at): Update.
1703         * tui/tui-source.c (tui_set_source_content_nil): Update.
1704         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1705         a bool.
1706         * tui/tui-data.c (init_content_element): Update.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1711         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1712         * tui/tui-layout.c (init_and_make_win): Update.
1713         * tui/tui.h (enum tui_win_type): Update.
1714         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1715         tui_win_is_auxillary.
1716         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1717         tui_win_is_auxillary.
1718
1719 2019-06-25  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1722         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1723         (tui_delete_data_content_windows, tui_display_all_data)
1724         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1725         Update.
1726         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1727         * tui/tui-regs.c (tui_last_regs_line_no)
1728         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1729         (tui_show_registers): Update.
1730         (tui_show_register_group): Return void.  Update.
1731         (tui_display_registers_from, tui_display_reg_element_at_line)
1732         (tui_display_registers_from_line, tui_check_register_values):
1733         Update.
1734         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1735         member.
1736         (struct tui_data_window) <regs_content>: Now a std::vector.
1737         <regs_content_count>: Remove.
1738         (tui_add_content_elements, tui_free_data_content): Don't declare.
1739         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1740         (init_content_element): Remove DATA_WIN case.  Add assert.
1741         (tui_add_content_elements): Remove.
1742         (tui_data_window): Update.
1743         (tui_free_data_content): Remove.
1744         (free_content_elements): Remove DATA_WIN case.
1745
1746 2019-06-25  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-data.c (tui_data_item_window): Update.
1749         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1750         * tui/tui-windata.c (tui_display_all_data)
1751         (tui_display_data_from_line): Update.
1752         (tui_check_data_values): Remove.
1753         * tui/tui-regs.c (tui_show_register_group)
1754         (tui_display_reg_element_at_line): Update.
1755         * tui/tui-hooks.c (tui_register_changed)
1756         (tui_refresh_frame_and_register_information): Call
1757         tui_check_register_values.
1758         * tui/tui-data.h (struct tui_data_window) <data_content,
1759         data_content_count, data_type>: Remove.
1760         (enum tui_data_type): Remove.
1761
1762         * tui/tui-data.c (tui_data_window::clear_detail)
1763         (~tui_data_window): Update.
1764
1765 2019-06-25  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1768         declare.
1769         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1770         Rename from tui_first_data_item_displayed.  Update.
1771         (tui_data_window::refresh_all)
1772         (tui_data_window::do_scroll_vertical): Update.
1773         * tui/tui-data.h (struct tui_data_window)
1774         <first_data_item_displayed>: Declare new method.
1775
1776 2019-06-25  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1779         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1780         contents...
1781         (tui_initialize_static_data): ...here.
1782
1783 2019-06-25  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1786         (tui_display_registers_from, tui_check_register_values): Update.
1787         (tui_display_register): Remove win_info parameter; update.
1788         (tui_get_register): Change type of parameters.
1789         * tui/tui-data.h (struct tui_data_element): Remove.
1790         (union tui_which_element) <data>: Remove.
1791         <data_window>: Change type.
1792         (struct tui_data_item_window): New.
1793         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1794         case.  Add assert.
1795         (~tui_data_item_window): New destructor.
1796         (free_content_elements): Remove DATA_ITEM_WIN case.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1801         Remove.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.h (struct tui_command_element): Remove.
1806         (union tui_which_element) <command>: Remove.
1807         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1808         assert.
1809         (free_content_elements): Remove CMD_WIN case.
1810
1811 2019-06-25  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-layout.c (tui_set_layout): Update.
1814         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1815         * tui/tui-data.c (layout_def): Update.
1816
1817 2019-06-25  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1820         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1821         (tui_source_window_base::set_new_height): Update.
1822         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1823         Update.
1824         (tui_set_locator_fullname, tui_set_locator_info)
1825         (tui_show_frame_info): Update.
1826         * tui/tui-source.c (tui_set_source_content)
1827         (tui_source_is_displayed): Update.
1828         * tui/tui-layout.c (show_source_disasm_command, show_data)
1829         (show_source_or_disasm_and_command): Update.
1830         * tui/tui-disasm.c (tui_set_disassem_content)
1831         (tui_get_begin_asm_address): Update.
1832         * tui/tui-data.h (struct tui_locator_element): Remove.
1833         (union tui_which_element) <locator>: Remove.
1834         (struct tui_locator_window): New.
1835         (tui_locator_win_info_ptr): Change return type.
1836         * tui/tui-data.c (_locator): Change type.
1837         (tui_locator_win_info_ptr): Change return type.
1838         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1839         (tui_alloc_content): Add assert.
1840
1841 2019-06-25  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-winsource.c
1844         (tui_exec_info_window::maybe_allocate_content): New method.
1845         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1846         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1847         (make_source_or_disasm_window): Add cast.
1848         * tui/tui-data.h (union tui_which_element) <simple_string>:
1849         Remove.
1850         (struct tui_source_info): New.
1851         (struct tui_source_window_base) <execution_info>: Change type.
1852         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1853         case, and add assert.
1854         (tui_alloc_content): Add assert.
1855
1856 2019-06-25  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1859         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1860         * tui/tui-data.c (tui_alloc_win_info): Remove.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1865         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1866         can_highlight.
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1871         make_visible_with_new_height method.
1872         (tui_win_info::make_visible_with_new_height): New method.
1873         (tui_source_window_base::do_make_visible_with_new_height)
1874         (tui_data_window::do_make_visible_with_new_height)
1875         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1876         (make_visible_with_new_height): Remove.
1877         (tui_resize_all, tui_adjust_win_heights): Use
1878         make_visible_with_new_height method.
1879         * tui/tui-data.h (struct tui_win_info)
1880         <do_make_visible_with_new_height, make_visible_with_new_height>:
1881         New methods.
1882         (struct tui_source_window_base, struct tui_data_window)
1883         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1884         methods.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1889         method.
1890         (update_tab_width): Call update_tab_width method.
1891         * tui/tui-data.h (struct tui_win_info)
1892         (struct tui_source_window_base) <update_tab_width>: New methods.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1897         parameter.
1898         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1899         parameter.
1900         (tui_gen_win_info::make_visible): Update.
1901         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1902         parameter.
1903         * tui/tui-data.h (enum tui_box): New enum.
1904         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1909         init_and_make_win for EXEC_INFO_WIN.
1910         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1911         longer inline.
1912         (struct tui_win_info) <~tui_win_info>: Inline.
1913         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1914         Don't declare.
1915         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1916         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1917         Remove.
1918         (tui_initialize_static_data): Update.
1919         (~tui_gen_win_info): Handle more cleanup here.
1920         (~tui_source_window_base): Delete "execution_info".
1921         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-layout.c (make_command_window): Don't set
1926         can_highlight.
1927         (show_source_disasm_command): Call the reset method.
1928         (show_data): Don't set can_highlight.  Call the reset method.
1929         (tui_gen_win_info::reset): Rename from init_gen_win_info
1930         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1931         (show_source_or_disasm_and_command): Call the reset method.
1932         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1933         (struct tui_cmd_window): Set can_highlight.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1938         from make_visible.
1939         (tui_make_visible, tui_make_invisible): Rewrite.
1940         (tui_win_info::make_visible): Remove.
1941         (tui_source_window_base::make_visible): Update.
1942         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1943         method.  Moved from...
1944         (struct tui_win_info) <make_visible>: ...here.
1945
1946 2019-06-25  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-winsource.c
1949         (tui_source_window_base::do_scroll_horizontal): Remove direction
1950         parameter.
1951         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1952         direction parameter.
1953         * tui/tui-win.c (tui_win_info::forward_scroll)
1954         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1955         (tui_win_info::right_scroll): Update.
1956         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1957         direction parameter.
1958         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1959         direction parameter.
1960         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1961         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1962         Remove direction parameter.
1963         (struct tui_source_window_base, struct tui_source_window)
1964         (struct tui_disasm_window, struct tui_data_window)
1965         (struct tui_cmd_window): Update.
1966
1967 2019-06-25  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-winsource.h (tui_set_exec_info_content)
1970         (tui_show_exec_info_content, tui_erase_exec_info_content)
1971         (tui_clear_exec_info_content, tui_update_exec_info): Change
1972         argument to tui_source_window_base.
1973         * tui/tui-winsource.c (tui_set_exec_info_content)
1974         (tui_show_exec_info_content, tui_erase_exec_info_content)
1975         (tui_clear_exec_info_content, tui_update_exec_info): Change
1976         argument to tui_source_window_base.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1981         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1986         check.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1991         type to void.
1992         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1993         type to void.
1994         * tui/tui-source.c (tui_set_source_content): Update.
1995         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-win.c (window_name_completer, tui_set_focus)
2000         (tui_all_windows_info): Use name method.
2001         * tui/tui-data.h (struct tui_gen_win_info)
2002         (struct tui_source_window, struct tui_disasm_window)
2003         (struct tui_data_window, struct tui_cmd_window) <name>: New
2004         method.
2005         (tui_win_name): Don't declare.
2006         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2007         (tui_win_name): Remove.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-winsource.h (tui_update_source_window)
2012         (tui_update_source_window_as_is): Change parameter type.
2013         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2014         to be a tui_source_window_base.
2015         (tui_update_source_window_as_is): Likewise.
2016         * tui/tui-win.c (make_visible_with_new_height): Update.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-winsource.c (tui_erase_source_content)
2021         (tui_show_source_content, tui_show_exec_info_content)
2022         (tui_erase_exec_info_content): Use refresh_window method.
2023         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2024         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2025         from tui_refresh_win.
2026         (tui_data_window::refresh_window): New method.
2027         (tui_win_info::refresh, tui_source_window_base::refresh)
2028         (tui_refresh_all): Use refresh_window method.
2029         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2030         method.
2031         * tui/tui-regs.c (tui_display_register): Call refresh_window
2032         method.
2033         * tui/tui-layout.c (show_source_disasm_command)
2034         (show_source_or_disasm_and_command): Call refresh_window method.
2035         * tui/tui-data.h (struct tui_gen_win_info)
2036         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2037         New method.
2038
2039 2019-06-25  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui.c (tui_rl_other_window, tui_enable)
2042         (tui_is_window_visible, tui_get_command_dimension): Update.
2043         * tui/tui-winsource.c (tui_update_source_window_as_is)
2044         (tui_clear_source_content, tui_erase_source_content)
2045         (tui_show_source_line, tui_source_window_base::refill)
2046         (tui_source_window_base::do_scroll_horizontal)
2047         (tui_source_window_base::set_is_exec_point_at)
2048         (tui_update_breakpoint_info, tui_set_exec_info_content)
2049         (tui_alloc_source_buffer, tui_line_is_displayed)
2050         (tui_addr_is_displayed): Update.
2051         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2052         (tui_check_and_display_highlight_if_needed)
2053         (tui_win_info::make_visible, tui_win_info::refresh)
2054         (tui_refresh_all): Update.
2055         * tui/tui-windata.c (tui_first_data_item_displayed)
2056         (tui_delete_data_content_windows, tui_erase_data_content)
2057         (tui_display_all_data, tui_data_window::refresh_all)
2058         (tui_check_data_values): Update.
2059         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2060         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2061         (tui_win_info::backward_scroll, tui_refresh_all_win)
2062         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2063         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2064         (tui_source_window_base::set_new_height)
2065         (tui_data_window::set_new_height)
2066         (make_invisible_and_set_new_height)
2067         (make_visible_with_new_height, new_height_ok)
2068         (parse_scrolling_args): Update.
2069         * tui/tui-stack.c (tui_show_frame_info): Update.
2070         * tui/tui-source.c (tui_set_source_content)
2071         (tui_set_source_content_nil, tui_source_is_displayed)
2072         (tui_source_window::do_scroll_vertical): Update.
2073         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2074         (tui_display_registers_from, tui_display_reg_element_at_line)
2075         (tui_check_register_values, tui_reg_command): Update.
2076         * tui/tui-layout.c (tui_default_win_height)
2077         (show_source_disasm_command, show_data, init_and_make_win)
2078         (show_source_or_disasm_and_command): Update.
2079         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2080         (tui_redisplay_readline, tui_mld_flush)
2081         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2082         (tui_getc): Update.
2083         * tui/tui-disasm.c (tui_set_disassem_content)
2084         (tui_disasm_window::do_scroll_vertical): Update.
2085         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2086         Now virtual.
2087         (struct tui_win_info): Derive from tui_gen_win_info.
2088         <~tui_win_info>: Mark as override.
2089         <generic>: Remove member.
2090         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2091         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2092         (~tui_data_window, ~tui_win_info)
2093         (tui_free_all_source_wins_content): Update.
2094         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-layout.c (init_and_make_win): Use new.
2099         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2100         destructor, initializers.
2101         (tui_alloc_generic_win_info): Don't declare.
2102         * tui/tui-data.c (_locator): Add argument to constructor.
2103         (source_win, disasm_win): New globals.
2104         (exec_info): Remove.
2105         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2106         Update.
2107         (tui_alloc_generic_win_info): Remove.
2108         (init_content_element): Use new.
2109         (tui_win_info::tui_win_info): Update.
2110         (free_content_elements) <case DATA_WIN>: Use delete.
2111
2112 2019-06-25  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2115         * tui/tui-windata.c (tui_first_data_item_displayed)
2116         (tui_delete_data_content_windows): Update.
2117         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2118         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2119         (tui_display_registers_from, tui_check_register_values): Update.
2120         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2121         pointer.
2122         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2123         window.
2124         (tui_free_data_content): Update.
2125         (free_content_elements) <case DATA_WIN>: Free the window.
2126
2127 2019-06-25  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2130         Update.
2131         * tui/tui-layout.c (make_command_window)
2132         (show_source_disasm_command, show_data, init_and_make_win)
2133         (show_source_or_disasm_and_command): Update.
2134         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2135         method.
2136         <can_highight, is_highlighted>: Now bool.
2137         (tui_set_win_highlight): Don't declare.
2138         * tui/tui-data.c (tui_set_win_highlight): Remove.
2139
2140 2019-06-25  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-wingeneral.c (make_visible): Remove check of window
2143         type.
2144
2145 2019-06-25  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-win.c (tui_win_info::max_height)
2148         (tui_cmd_window::max_height): New methods.
2149         (new_height_ok): Call max_height.
2150         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2151         <max_height>: New method.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-win.c (tui_source_window_base::set_new_height)
2156         (tui_data_window::set_new_height): New methods.
2157         (make_invisible_and_set_new_height): Call set_new_height method.
2158         * tui/tui-data.h (struct tui_win_info)
2159         (struct tui_source_window_base, struct tui_data_window)
2160         <set_new_height>: New method.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2165         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2166         tui_refresh_data_win.
2167         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2168         method.
2169         (tui_refresh_all_win): Call the refresh_all method.
2170         (tui_set_focus): Likewise.
2171         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2172         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2173         Likewise.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (tui_refill_source_window)
2178         (tui_set_is_exec_point_at): Don't declare.
2179         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2180         (tui_source_window_base::refill): Rename from
2181         tui_refill_source_window.
2182         (tui_source_window_base::do_scroll_horizontal): Update.
2183         (tui_source_window_base::set_is_exec_point_at): Rename from
2184         tui_set_is_exec_point_at.
2185         (tui_update_all_breakpoint_info): Update.
2186         * tui/tui-stack.c (tui_show_frame_info): Update.
2187         * tui/tui-layout.c (show_data): Add cast.
2188         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2189         * tui/tui-data.h (struct tui_source_window_base) <refill,
2190         set_is_exec_point_at>: New methods.
2191         (tui_source_windows, tui_add_to_source_windows): Update types.
2192         (tui_add_to_source_windows): Remove redundant declaration.
2193         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2194         (tui_source_windows): Change return type.
2195         (tui_clear_source_windows_detail): Update.
2196         (tui_add_to_source_windows): Change type of parameter.
2197         (tui_free_all_source_wins_content): Update.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-wingeneral.c (tui_win_info::refresh)
2202         (tui_source_window_base::refresh): New methods.
2203         (tui_refresh_all): Call the refresh method.
2204         * tui/tui-data.h (struct tui_win_info)
2205         (struct tui_source_window_base) <refresh>: New method.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui.h (tui_is_window_visible): Return bool.
2210         * tui/tui.c (tui_is_window_visible): Return bool.
2211         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2212         (tui_make_visible, tui_make_invisible)
2213         (tui_win_info::make_visible)
2214         (tui_source_window_base::make_visible, make_all_visible)
2215         (tui_make_all_visible, tui_make_all_invisible): Update.
2216         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2217         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2218         bool.
2219         (struct tui_win_info, struct tui_source_window_base)
2220         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2221         * tui/tui-data.c (tui_init_generic_part): Update.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2226         (tui_source_window_base::make_visible): New methods.
2227         (make_all_visible): Make method call.
2228         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2229         (struct tui_source_window_base, struct tui_cmd_window): Override
2230         make_visible.
2231         (tui_win_is_source_type): Don't declare.
2232         * tui/tui-data.c (tui_win_is_source_type): Remove.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2237         NULL check.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2242         Inline constructor.  Add initializers for members.
2243         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2244         constructors; now inline in class.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-regs.c (tui_show_registers): Update.
2249         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2250         bool.
2251         * tui/tui-data.c (tui_data_window::clear_detail)
2252         (tui_data_window): Update.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-windata.c (tui_display_all_data)
2257         (tui_display_data_from_line, tui_display_data_from)
2258         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2259         Update.
2260         * tui/tui-regs.c (tui_last_regs_line_no)
2261         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2262         (tui_show_registers, tui_show_register_group)
2263         (tui_display_registers_from, tui_display_reg_element_at_line)
2264         (tui_display_registers_from_line, tui_check_register_values)
2265         (tui_reg_next, tui_reg_prev): Update.
2266         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2267         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2268         tui_data_window.
2269         (struct tui_win_info) <detail>: Remove.  Add new fields from
2270         tui_data_info.
2271         (TUI_DATA_WIN): Add cast.
2272         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2273         (~tui_data_window): Simplify.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-layout.c (show_source_disasm_command)
2278         (show_source_or_disasm_and_command): Update.
2279         * tui/tui-io.c (update_cmdwin_start_line)
2280         (tui_redisplay_readline): Update.
2281         * tui/tui-data.h (struct tui_command_info): Remove.
2282         (struct tui_win_info) <detail>: Remove command_info member.
2283         (struct tui_data_window) <start_line>: New member, from
2284         tui_command_info.
2285         (TUI_CMD_WIN): Add casts.
2286
2287 2019-06-25  Tom Tromey  <tom@tromey.com>
2288
2289         * tui/tui-winsource.c (tui_update_source_window)
2290         (tui_refill_source_window)
2291         (tui_source_window_base::do_scroll_horizontal)
2292         (tui_update_breakpoint_info, tui_set_exec_info_content)
2293         (tui_show_exec_info_content, tui_erase_exec_info_content)
2294         (tui_clear_exec_info_content): Update.
2295         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2296         Update.
2297         * tui/tui-win.c (make_invisible_and_set_new_height)
2298         (make_visible_with_new_height): Update.
2299         * tui/tui-source.c (tui_set_source_content)
2300         (tui_show_symtab_source): Update.
2301         * tui/tui-layout.c (extract_display_start_addr)
2302         (show_source_disasm_command, show_data)
2303         (make_source_or_disasm_window)
2304         (show_source_or_disasm_and_command): Update.
2305         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2306         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2307         "gdbarch".
2308         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2309         to tui_source_window_base.
2310         (struct tui_win_info) <detail>: Remove source_info member.
2311         (struct tui_source_window_base) <has_locator>: Inline.
2312         Move contents from tui_source_info; rename has_locator member to
2313         m_has_locator.
2314         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2315         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2316         header file.
2317         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2318         Simplify.
2319         (tui_free_all_source_wins_content): Cast to
2320         tui_source_window_base.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-win.c (make_invisible_and_set_new_height)
2325         (make_visible_with_new_height): Call has_locator method.
2326         * tui/tui-layout.c (show_source_disasm_command, show_data)
2327         (show_source_or_disasm_and_command): Update for bool change.
2328         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2329         (tui_win_info) <has_locator>: New method.
2330         (struct tui_source_window_base) <has_locator>: New method.
2331         (tui_win_has_locator): Don't declare.
2332         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2333         from tui_win_has_locator.
2334         (tui_source_window_base): Use false, not FALSE.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2339         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2340         clear_detail method directly.
2341         (tui_clear_win_detail): Remove.
2342
2343 2019-06-25  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2346         "this", not TUI_DISASM_WIN.
2347
2348 2019-06-25  Tom Tromey  <tom@tromey.com>
2349
2350         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2351         declare.
2352         * tui/tui-winsource.c
2353         (tui_source_window_base::do_scroll_horizontal): Rename from
2354         tui_horizontal_source_scroll.
2355         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2356         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2357         from tui_vertical_data_scroll.
2358         * tui/tui-win.h (tui_scroll): Don't declare.
2359         * tui/tui-win.c (tui_win_info::forward_scroll)
2360         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2361         (tui_win_info::right_scroll): Rename and update.
2362         (tui_scroll_forward_command, tui_scroll_backward_command)
2363         (tui_scroll_left_command, tui_scroll_right_command): Update.
2364         (tui_scroll): Remove.
2365         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2366         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2367         from tui_vertical_source_scroll.
2368         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2369         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2370         from tui_vertical_disassem_scroll.
2371         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2372         do_scroll_horizontal>: New methods.
2373         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2374         Likewise.
2375         (struct tui_source_window_base): Add do_scroll_horizontal.
2376         (struct tui_source_window, struct tui_disasm_window): Add
2377         do_scroll_vertical.
2378         (struct tui_data_window, struct tui_cmd_window): Add
2379         do_scroll_horizontal and do_scroll_vertical.
2380         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2381
2382 2019-06-25  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-data.h (struct tui_source_window_base): New struct.
2385         (struct tui_source_window): Derive from tui_source_window_base.
2386         (struct tui_disasm_window): New struct.
2387         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2388         from tui_source_window::clear_detail.
2389         (tui_source_window_base): Rename from tui_source_window.
2390         (~tui_source_window_base): Rename from ~tui_source_window.
2391         (tui_alloc_win_info): Create a tui_disasm_window.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-data.h (struct tui_source_window)
2396         (struct tui_data_window): Declare destructors.
2397         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2398         destructors.
2399         (tui_win_info): Simplify.
2400
2401 2019-06-25  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-winsource.c (tui_display_main)
2404         (tui_update_source_windows_with_addr)
2405         (tui_update_all_breakpoint_info): Update.
2406         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2407         (new_height_ok, parse_scrolling_args): Update.
2408         * tui/tui-stack.c (tui_show_frame_info): Update.
2409         * tui/tui-data.h (struct tui_list): Remove.
2410         (tui_source_windows): Return a reference to a std::vector.
2411         * tui/tui-data.c (source_windows): Now a std::vector.
2412         (tui_source_windows): Change return type.
2413         (tui_clear_source_windows): Rewrite.
2414         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2415         (tui_free_all_source_wins_content): Rewrite.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2420         (struct tui_data_window, struct tui_cmd_window): Declare
2421         clear_detail method.
2422         * tui/tui-data.c (tui_source_window::clear_detail)
2423         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2424         methods.
2425         (tui_clear_win_detail): Simplify.
2426
2427 2019-06-25  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-layout.c (make_source_window, make_disasm_window)
2430         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2431         Return the new window.
2432         (show_source_disasm_command, show_data)
2433         (show_source_or_disasm_and_command): Update.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2438         parameter.  Return the new window.
2439         (show_source_disasm_command): Update and remove NULL check.
2440         (show_source_or_disasm_and_command): Update.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-data.h (struct tui_win_info): Make constructor
2449         protected.  Make destructor virtual.  Add initializers.
2450         (tui_source_window, tui_data_window, tui_cmd_window): New
2451         classes.
2452         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2453         constructor.  Add "type" parameter.
2454         (tui_source_window, tui_data_window, tui_cmd_window): New
2455         constructors.
2456         (tui_alloc_win_info): Instantiate the appropriate subclass.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-win.c (tui_resize_all): Use delete.
2461         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2462         destructor.
2463         (tui_free_window): Don't declare.
2464         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2465         Update.
2466
2467 2019-06-25  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-data.h (struct tui_win_info): Add constructor.
2470         * tui/tui-data.c (tui_alloc_win_info): Use new.
2471         (tui_free_window): Use delete.
2472
2473 2019-06-22  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2476         declare.
2477         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2478
2479 2019-06-22  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2482         declare.
2483         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2484
2485 2019-06-22  Tom de Vries  <tdevries@suse.de>
2486
2487         * dwarf2read.c (create_addrmap_from_aranges)
2488         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2489         instead of '%zu'.
2490
2491 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2492
2493         * dwarf2read.h (dwarf2_section_info_def): Remove.
2494         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2495         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2496         std::vector<dwarf2_section_info>.
2497         (struct dwo_file) <~dwo_file>: Remove.
2498         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2499         types field.
2500         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2501         (dwarf2_read_debug_names): Likewise.
2502         (create_debug_types_hash_table): Change parameter type to
2503         array_view, adjust code accordingly.
2504         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2505         (partial_die_info::fixup): Likewise.
2506         (determine_prefix): Likewise.
2507         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2508
2509 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2510
2511         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2512         gdb_bfd_ref_ptr.
2513         <~dwo_file>: Remove call to gdb_bfd_unref.
2514         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2515         gdb_bfd_ref_ptr::get.
2516
2517 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2518
2519         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2520         type to htab_up.
2521         * dwarf2read.c (struct dwo_file): Initialize fields.
2522         <~dwo_file>: New.
2523         (free_dwo_file): Remove, move content to ~dwo_file.
2524         (struct dwo_file_deleter): Remove.
2525         (dwo_file_up>: Remove custom deleter.
2526         (free_dwo_files): Remove.
2527         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2528         dwo_files.
2529         (process_skeletonless_type_units): Call unique_ptr::get.
2530         (allocate_dwo_file_hash_table): Add deleter to created hash
2531         table.  Change return type to htab_up.
2532         (lookup_dwo_file_slot): Don't memset dwo_file, call
2533         unique_ptr::get.
2534         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2535         (create_dwo_unit_in_dwp_v2): Likewise.
2536         (open_and_init_dwo_file): Likewise.
2537         (free_dwo_file_from_slot): Remove.
2538
2539 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2540
2541         * dwarf2read.h (struct dwarf2_section_info) <readin,
2542         is_virtual>: Change type to bool.
2543         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2544         true instead of 1.
2545
2546 2019-06-19  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-data.h (tui_init_content_element): Don't declare.
2549
2550 2019-06-19  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-data.h (tui_init_win_info): Don't declare.
2553
2554 2019-06-19  Tom de Vries  <tdevries@suse.de>
2555
2556         * dwarf2read.h (abstract_to_concrete): Change type to
2557         std::unordered_map<sect_offset, std::vector<sect_offset>,
2558         gdb::hash_enum<sect_offset>>.
2559
2560 2019-06-19  Tom Tromey  <tromey@adacore.com>
2561
2562         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2563         EVAL_AVOID_SIDE_EFFECTS specially.
2564
2565 2019-06-19  Tom Tromey  <tromey@adacore.com>
2566
2567         * source-cache.c (highlighter): New global.
2568         (source_cache::get_source_lines): Create a highlighter on demand.
2569
2570 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * defs.h (deprecated_interactive_hook): Delete declaration.
2573         * interps.c (clear_interpreter_hooks): Remove use of
2574         deprecated_interactive_hook.
2575         * top.c (deprecated_interactive_hook): Delete definition.
2576         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2577
2578 2019-06-18  Tom de Vries  <tdevries@suse.de>
2579
2580         PR gdb/24515
2581         * dwarf2read.h (abstract_to_concrete): Change type from
2582         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2583         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2584         * dwarf2read.c (read_variable): Update.
2585         (dwarf2_fetch_die_loc_sect_off): Update.
2586
2587 2019-06-17  Tom de Vries  <tdevries@suse.de>
2588
2589         PR gdb/24617
2590         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2591         accessing parent[parent_len - 1].
2592
2593 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2594
2595         PR gdb/24364
2596         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2597         call dtrace_process_dof with NULL dof.
2598
2599 2019-06-16  Tom de Vries  <tdevries@suse.de>
2600
2601         PR gdb/24445
2602         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2603
2604 2019-06-16  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2607         (make_all_visible): Use address of member.
2608
2609 2019-06-16  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2612         (tui_free_window, free_content, free_content_elements): Remove
2613         unnecessary cast.
2614         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2615         cast.
2616         * tui/tui-regs.c (tui_show_register_group)
2617         (tui_display_registers_from, tui_display_reg_element_at_line):
2618         Remove unnecessary cast.
2619
2620 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * linux-nat.c (normal_mask): Delete.
2623         (_initialize_linux_nat): Don't initialise normal_mask.
2624
2625 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2626
2627         PR gdb/24445
2628         * dwarf-index-write.h (write_psymtabs_to_index): Add
2629         dwz_basename parameter.
2630         * dwarf-index-write.c (write_gdbindex): Move file writing to
2631         write_gdbindex_1.  Change return type void.
2632         (assert_file_size): Move up, remove filename parameter.
2633         (write_gdbindex_1): New function.
2634         (write_debug_names): Change return type to void, call
2635         assert_file_size.
2636         (struct index_wip_file): New struct.
2637         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2638         file logic to index_wip_file.  Write index for dwz file if
2639         needed.
2640         (save_gdb_index_command): Pass basename of dwz file, if present.
2641         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2642         build-id of dwz file, if present.
2643         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2644         (dwarf2_get_dwz_file): Likewise.
2645         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2646         (dwarf2_get_dwz_file): Likewise.
2647
2648 2019-06-16  Tom Tromey  <tom@tromey.com>
2649
2650         * coffread.c (process_coff_symbol): Use xstrdup.
2651         * value.c (create_internalvar): Use xstrdup.
2652
2653 2019-06-16  Tom Tromey  <tom@tromey.com>
2654
2655         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2656         * breakpoint.c (stopin_command, stopat_command)
2657         (until_break_command, decode_location_default): Remove unnecessary
2658         cast.
2659         * utils.c (subset_compare): Remove unnecessary cast.
2660         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2661         cast.
2662         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2663         cast.
2664         * infcmd.c (path_command): Remove unnecessary cast.
2665         * coffread.c (decode_type): Remove unnecessary cast.
2666         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2667         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2668         * tui/tui-stack.c (tui_show_locator_content)
2669         (tui_show_frame_info): Remove unnecessary cast.
2670         * tui/tui-win.c (tui_scroll_forward_command)
2671         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2672         (parse_scrolling_args): Remove unnecessary cast.
2673         * tui/tui-data.c (init_win_info, tui_del_window)
2674         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2675         (free_content_elements): Remove unnecessary cast.
2676         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2677         unnecessary cast.
2678         * tui/tui-source.c (tui_set_source_content)
2679         (tui_vertical_source_scroll): Remove unnecessary cast.
2680         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2681         cast.
2682         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2683         * tui/tui-regs.c (tui_display_registers_from)
2684         (tui_display_register): Remove unnecessary cast.
2685         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2686         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2687         (make_visible): Remove unnecessary cast.
2688         * tui/tui-winsource.c (tui_erase_source_content)
2689         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2690         unnecessary cast.
2691         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2692         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2693         * stabsread.c (read_type, read_array_type, read_range_type):
2694         Remove unnecessary cast.
2695         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2696         (parse_symbol, parse_type, upgrade_type, parse_external)
2697         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2698         unnecessary cast.
2699         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2700
2701 2019-06-16  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-data.c (tui_alloc_generic_win_info)
2704         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2705         checks.
2706
2707 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2708             Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * f-typeprint.c (f_print_type): Don't return early for not
2711         associated or not allocated types.
2712         (f_type_print_varspec_suffix): Add print_rank parameter and print
2713         ranks of array types in case they dangling.
2714         (f_type_print_base): Add print_rank parameter.
2715
2716 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2717
2718         * NEWS: Mention new MI commands.
2719         * break-catch-throw.c (enum exception_event_kind): Move to
2720         breakpoint.h.
2721         (print_mention_exception_catchpoint): Output text as a single
2722         message.
2723         (catch_exception_command_1): Rename to...
2724         (catch_exception_event): ...this, make non-static, update header
2725         command, and change some parameter types.
2726         (catch_catch_command): Update for changes to
2727         catch_exception_command_1.
2728         (catch_throw_command): Likewise.
2729         (catch_rethrow_command): Likewise.
2730         * breakpoint.c (enum exception_event_kind): Delete.
2731         * breakpoint.h (enum exception_event_kind): Moved here from
2732         break-catch-throw.c.
2733         (catch_exception_event): Declare.
2734         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2735         (mi_cmd_catch_throw): New function.
2736         (mi_cmd_catch_rethrow): New function.
2737         (mi_cmd_catch_catch): New function.
2738         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2739         'catch-catch' entries.
2740         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2741         (mi_cmd_catch_rethrow): Declare.
2742         (mi_cmd_catch_catch): Declare.
2743
2744 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * annotate.c (annotate_source_line): Change return type to void,
2747         update implementation to match.
2748         * annotate.h (annotate_source_line): Change return type to void,
2749         update header comment.
2750         * stack.c (print_frame_info): Don't change what frame information
2751         is printed based on whether annotations are on or not.
2752
2753 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2754
2755         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2756         (annotate_source): Make static.
2757         (annotate_source_line): Moved from source.c and renamed from
2758         identify_source_line.  Update the return type.
2759         * annotate.h (annotate_source): Delete declaration.
2760         (annotate_source_line): Declaration moved from source.h, and
2761         renamed from identify_source_line.  Return type updated.
2762         * source.c (identify_source_line): Moved to annotate.c and renamed
2763         to annotate_source_line.
2764         (info_line_command): Remove check of annotation_level.
2765         * source.h (identify_source_line): Move declaration to annotate.h
2766         and rename to annotate_source_line.
2767         * stack.c: Add 'annotate.h' include.
2768         (print_frame_info): Remove check of annotation_level before
2769         calling annotate_source_line.
2770
2771 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * source-cache.c (source_cache::get_plain_source_lines): Use
2774         open_source_file_with_line_charpos instead of just
2775         open_source_file, remove call to find_source_lines.
2776         (source_cache::get_source_lines): Likewise.
2777         * source.c (find_source_lines): Make static.
2778         (get_filename_and_charpos): Renamed into...
2779         (open_source_file_with_line_charpos): ..this along with changes to
2780         return a scoped_fd, and some other minor clean ups.
2781         (identify_source_line): Use open_source_file_with_line_charpos.
2782         (search_command_helper): Use open_source_file_with_line_charpos
2783         instead of just open_source_file, remove call to
2784         find_source_lines.
2785         * source.h (open_source_file_with_line_charpos): Declare new
2786         function.
2787         (find_source_lines): Delete declaration.
2788
2789 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * source.c (get_filename_and_charpos): Remove fullname
2792         parameter.
2793         (identify_source_line): Update call to get_filename_and_charpos.
2794
2795 2019-06-14  Tom Tromey  <tromey@adacore.com>
2796
2797         PR gdb/24502:
2798         * ui-style.h (skip_ansi_escape): Update comment.
2799         * ui-file.h (class no_terminal_escape_file): New class.
2800         * ui-file.c (no_terminal_escape_file::write)
2801         (no_terminal_escape_file::puts): New methods.
2802         * cli/cli-logging.c (handle_redirections): Use
2803         no_terminal_escape_file.
2804
2805 2019-06-14  Tom Tromey  <tromey@adacore.com>
2806
2807         * NEWS: Move convenience variable news above Python news.
2808
2809 2019-06-14  Tom Tromey  <tom@tromey.com>
2810
2811         * gnulib: Move directory to top-level.
2812         * configure.ac: Don't configure gnulib.
2813         * configure: Rebuild.
2814         * common/common-defs.h: Use new path to gnulib.
2815         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2816         (GNULIB_H): Remove.
2817         (INCGNU): Look in new gnulib location.
2818         (HFILES_NO_SRCDIR): Remove gnulib files.
2819         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2820         (generated_files): Remove GNULIB_H.
2821         ($(LIBGNU), all-lib): Remove targets.
2822         (distclean): Don't mention GNULIB_BUILDDIR.
2823         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2824
2825 2019-06-14  Tom Tromey  <tromey@adacore.com>
2826
2827         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2828         Warn if symbol file does not provide any symbols.
2829
2830 2019-06-14  Tom Tromey  <tromey@adacore.com>
2831
2832         * source.c (find_and_open_source): Respect basenames_may_differ.
2833
2834 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * annotate.c (annotate_breakpoints_invalid): Make use of
2837         scoped_restore_terminal_state.
2838         (annotate_frames_invalid): Likewise.
2839
2840 2019-06-14  Tom Tromey  <tromey@adacore.com>
2841
2842         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2843         allow assignment to an internalvar.
2844
2845 2019-06-14  Tom Tromey  <tromey@adacore.com>
2846
2847         * ada-lex.l: Allow "_" in attribute names.
2848
2849 2019-06-14  Tom Tromey  <tromey@adacore.com>
2850
2851         PR gdb/24653:
2852         * regcache.c (registers_changed): Don't call alloca.
2853         * top.c (execute_command): Don't call alloca.
2854
2855 2019-06-13  Pedro Alves  <palves@redhat.com>
2856
2857         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2858         'expression'.  When parsing an expression, error out if there's
2859         junk after "unlimited".
2860         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2861         (do_set_command): Adjust calls to is_unlimited_literal.
2862
2863 2019-06-13  Pedro Alves  <palves@redhat.com>
2864
2865         * compile/compile.c (make_compile_options_def_group): Add braces
2866         around array_view initializer.
2867         * thread.c (make_thread_apply_all_options_def_group)
2868         (make_thread_apply_all_options_def_group): Likewise.
2869
2870 2019-06-13  Pedro Alves  <palves@redhat.com>
2871
2872         * NEWS (New commands): Mention "maint test-options
2873         require-delimiter", "maint test-options unknown-is-error", "maint
2874         test-options unknown-is-operand" and "maint show
2875         test-options-completion-result".
2876         (New command options, command completion): New section.
2877         (Completion improvements): New section.
2878         Mention that you can abbreviate "unlimited".
2879
2880 2019-06-13  Pedro Alves  <palves@redhat.com>
2881
2882         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2883         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2884         * unittests/cli-utils-selftests.c (test_parse_flags)
2885         (test_parse_flags_qcs): Delete.
2886         (test_cli_utils): Don't call deleted functions.
2887
2888 2019-06-13  Pedro Alves  <palves@redhat.com>
2889
2890         * thread.c: Include "cli/cli-option.h".
2891         (tp_array_compar_ascending): Global.
2892         (tp_array_compar): Delete function.
2893         (tp_array_compar_ascending, tp_array_compar_descending): New
2894         functions.
2895         (ascending_option_def, qcs_flag_option_def)
2896         (thr_qcs_flags_option_defs)
2897         (make_thread_apply_all_options_def_group)
2898         (make_thread_apply_options_def_group): New.
2899         (thread_apply_all_command): Use gdb::option::process_options.
2900         (thread_apply_command_completer)
2901         (thread_apply_all_command_completer): New.
2902         (thread_apply_command): Use gdb::option::process_options.
2903         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2904         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2905         to generate help text of "thread apply".  Adjust "taas"'s help.
2906         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2907         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2908
2909 2019-06-13  Pedro Alves  <palves@redhat.com>
2910
2911         * thread.c (thread_apply_command): Check for invalid TID with
2912         isdigit instead of !isalpha.
2913
2914 2019-06-13  Pedro Alves  <palves@redhat.com>
2915
2916         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2917         (validate_flags_qcs): New.
2918         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2919         (validate_flags_qcs): Declare.
2920         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2921         (make_frame_apply_options_def_group): New.
2922         (frame_apply_command_count): Process options with
2923         gdb::option::process_options.
2924         (frame_apply_completer): New.
2925         (frame_apply_level_completer, frame_apply_all_completer)
2926         (frame_apply_completer): New.
2927         (_initialize_stack): Update help of "frame apply", "frame apply
2928         level", "frame apply all" and "faas" to mention supported options
2929         and install command completers.
2930         * stack.h (frame_apply_all_completer): Declare.
2931         * thread.c: Include "stack.h".
2932         (tfaas_command): Add "--".
2933         (_initialize_thread): Update help "tfaas" to mention supported
2934         options and install command completer.
2935
2936 2019-06-13  Pedro Alves  <palves@redhat.com>
2937
2938         * completer.c (complete_nested_command_line): New.
2939         (gdb_completion_word_break_characters_throw): Add assertion.
2940         * completer.h (complete_nested_command_line): Declare.
2941
2942 2019-06-13  Pedro Alves  <palves@redhat.com>
2943
2944         * stack.c (parse_backtrace_qualifiers): New.
2945         (backtrace_command): Use it.
2946         (backtrace_command_completer): Complete on qualifiers.
2947
2948 2019-06-13  Pedro Alves  <palves@redhat.com>
2949
2950         * frame.c: Include "cli/cli-option.h.
2951         (user_set_backtrace_options): New.
2952         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2953         Delete.
2954         (get_prev_frame): Adjust.
2955         (boolean_option_def, uinteger_option_def)
2956         (set_backtrace_option_defs): New.
2957         (_initialize_frame): Adjust and use
2958         gdb::option::add_setshow_cmds_for_options to install "set
2959         backtrace past-main" and "set backtrace past-entry".
2960         * frame.h: Include "cli/cli-option.h".
2961         (struct frame_print_options): Forward declare.
2962         (print_frame_arguments_all, print_frame_arguments_scalars)
2963         (print_frame_arguments_none): Declare.
2964         (print_entry_values): Delete declaration.
2965         (struct frame_print_options, user_frame_print_options): New.
2966         (struct set_backtrace_options): New.
2967         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2968         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2969         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2970         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2971         (list_args_or_locals): Add frame_print_options parameter.
2972         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2973         * python/py-framefilter.c (enumerate_args): Pass down
2974         USER_FRAME_PRINT_OPTIONS.
2975         * stack.c: Include "cli/cli-option.h".
2976         (print_frame_arguments_all, print_frame_arguments_scalars)
2977         (print_frame_arguments_none): Declare.
2978         (print_raw_frame_arguments, print_entry_values): Delete.
2979         (user_frame_print_options): New.
2980         (boolean_option_def, enum_option_def, frame_print_option_defs):
2981         New.
2982         (struct backtrace_cmd_options): New.
2983         (bt_flag_option_def): New.
2984         (backtrace_command_option_defs): New.
2985         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2986         (print_frame_arg, read_frame_arg, print_frame_args)
2987         (print_frame_info, print_frame): Add frame_print_options parameter
2988         and use it.
2989         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2990         (backtrace_command_1): Add frame_print_options and
2991         backtrace_cmd_options parameters and use them.
2992         (make_backtrace_options_def_group): New.
2993         (backtrace_command): Process command options with
2994         gdb::option::process_options.
2995         (backtrace_command_completer): New.
2996         (_initialize_stack): Extend "backtrace"'s help to mention
2997         supported options.  Install completer for "backtrace".
2998         Install some settings commands with add_setshow_cmds_for_options.
2999
3000 2019-06-13  Pedro Alves  <palves@redhat.com>
3001
3002         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3003         and that "set/show print raw frame-arguments" are now deprecated.
3004
3005         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3006         command.
3007         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3008         * stack.c (_initialize_stack): Install "set/show print
3009         raw-frame-arguments", and deprecate "set/show print raw
3010         frame-arguments".
3011         * valprint.c (_initialize_valprint): Deprecate "set/show print
3012         raw".
3013
3014 2019-06-13  Pedro Alves  <palves@redhat.com>
3015
3016         * compile/compile.c (struct compile_options): New.
3017         (compile_flag_option_def, compile_command_option_defs)
3018         (make_compile_options_def_group): New.
3019         (compile_file_command): Handle options with
3020         gdb::option::process_options.
3021         (compile_file_command_completer): New function.
3022         (compile_code_command): Handle options with
3023         gdb::option::process_options.
3024         (compile_code_command_completer): New function.
3025         (_initialize_compiler): Install completers for "compile code" and
3026         "compile file".  Mention available options in "compile code" and
3027         "compile code"'s help.
3028         * completer.c (advance_to_completion_word): New, factored out from
3029         ...
3030         (advance_to_expression_complete_word_point): ... this.
3031         (advance_to_filename_complete_word_point): New.
3032         * completer.h (advance_to_filename_complete_word_point): New
3033         declaration.
3034
3035 2019-06-13  Pedro Alves  <palves@redhat.com>
3036
3037         * compile/compile.c: Include "cli/cli-option.h".
3038         (compile_print_value): Scope data pointer is now a
3039         value_print_options pointer; adjust.
3040         (compile_print_command): Process options.  Scope data pointer is
3041         now a value_print_options pointer; adjust.
3042         (_initialize_compile): Update "compile print"'s help to include
3043         supported options.  Install a completer for "compile print".
3044         * cp-valprint.c (show_vtblprint, show_objectprint)
3045         (show_static_field_print): Delete.
3046         (_initialize_cp_valprint): Don't install "set print
3047         static-members", "set print vtbl", "set print object" here.
3048         * printcmd.c: Include "cli/cli-option.h" and
3049         "common/gdb_optional.h".
3050         (print_command_parse_format): Rework to fill in a
3051         value_print_options instead of a format_data.
3052         (print_value): Change parameter type from format_data pointer to
3053         value_print_options reference.  Adjust.
3054         (print_command_1): Process options.  Adjust to pass down a
3055         value_print_options.
3056         (print_command_completer): New.
3057         (_initialize_printcmd): Install print_command_completer as
3058         handle_brkchars completer for the "print" command.  Update
3059         "print"'s help to include supported options.
3060         * valprint.c: Include "cli/cli-option.h".
3061         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3062         here from cp-valprint.c.
3063         (boolean_option_def, uinteger_option_def)
3064         (value_print_option_defs, make_value_print_options_def_group):
3065         New.  Use gdb::option::add_setshow_cmds_for_options to install
3066         "set print elements", "set print null-stop", "set print repeats",
3067         "set print pretty", "set print union", "set print array", "set
3068         print address", "set print symbol", "set print array-indexes".
3069         * valprint.h: Include <string> and "cli/cli-option.h".
3070         (make_value_print_options_def_group): Declare.
3071         (print_value): Change parameter type from format_data pointer to
3072         value_print_options reference.
3073         (print_command_completer): Declare.
3074
3075 2019-06-13  Pedro Alves  <palves@redhat.com>
3076
3077         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3078         (COMMON_SFILES): Add maint-test-settings.c.
3079         * cli/cli-decode.c (boolean_enums): New global, factored out from
3080         ...
3081         (add_setshow_boolean_cmd): ... here.
3082         * cli/cli-decode.h (boolean_enums): Declare.
3083         * cli/cli-option.c: New file.
3084         * cli/cli-option.h: New file.
3085         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3086         factored out from ...
3087         (parse_cli_boolean_value(const char *)): ... this.
3088         (is_unlimited_literal): Change parameter type to pointer to
3089         pointer.  Adjust and advance ARG pointer.
3090         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3091         (parse_cli_var_enum): New, factored out from ...
3092         (do_set_command): ... this.  Adjust.
3093         * cli/cli-setshow.h (parse_cli_boolean_value)
3094         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3095         (parse_cli_var_enum): Declare.
3096         * cli/cli-utils.c: Include "cli/cli-option.h".
3097         (get_ulongest): New.
3098         * cli/cli-utils.h (get_ulongest): Declare.
3099         (check_for_argument): New overloads.
3100         * maint-test-options.c: New file.
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3105         parse a range if "-" is at the end of the string.
3106
3107 2019-06-13  Pedro Alves  <palves@redhat.com>
3108
3109         * cli/cli-setshow.c (parse_auto_binary_operation)
3110         (parse_cli_boolean_value): Don't allow "o".
3111
3112 2019-06-13  Pedro Alves  <palves@redhat.com>
3113
3114         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3115         * NEWS: Mention maint test-settings KIND.
3116         * maint-test-settings.c: New file.
3117
3118 2019-06-13  Pedro Alves  <palves@redhat.com>
3119
3120         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3121         completer.
3122         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3123         "set" completers.
3124
3125 2019-06-13  Pedro Alves  <palves@redhat.com>
3126
3127         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3128         after item.
3129
3130 2019-06-13  Pedro Alves  <palves@redhat.com>
3131
3132         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3133
3134 2019-06-13  Pedro Alves <palves@redhat.com>
3135
3136         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3137         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3138         call.
3139         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3140         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3141         calls.
3142         (check_for_argument): Skip spaces after argument.
3143
3144 2019-06-13  Pedro Alves  <palves@redhat.com>
3145
3146         * thread.c (thread_apply_command): Adjust TID parsing.
3147         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3148         detected before end of string.
3149         (tid_is_in_list): Error out if LIST is invalid.
3150
3151 2019-06-13  Pedro Alves  <palves@redhat.com>
3152
3153         * completer.c (complete_line_internal_1): Rewind completion word
3154         point.
3155         (completion_tracker::advance_custom_word_point_by): Change
3156         parameter type to int.
3157         * completer.h (completion_tracker::advance_custom_word_point_by):
3158         Likewise.
3159
3160 2019-06-13  Pedro Alves  <palves@redhat.com>
3161
3162         * completer.c (advance_to_completion_word): Handle delimiters.
3163
3164 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3165
3166         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3167
3168 2019-06-11  Tom Tromey  <tom@tromey.com>
3169
3170         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3171         (xmalloc_failed): Move to alloc.c.
3172         * alloc.c: New file.
3173         * Makefile.in (COMMON_SFILES): Add alloc.c.
3174
3175 2019-06-11  Tom Tromey  <tom@tromey.com>
3176
3177         * nat/linux-waitpid.c: Don't include server.h.
3178         (linux_debug): Remove.
3179         (my_waitpid): Update.
3180
3181 2019-06-11  Tom Tromey  <tromey@adacore.com>
3182
3183         * infcall.c (_initialize_infcall): Remove trailing newline from
3184         help.
3185         * user-regs.c (_initialize_user_regs): Remove trailing newline
3186         from help.
3187         * typeprint.c (_initialize_typeprint): Remove trailing newline
3188         from help.
3189         * reverse.c (_initialize_reverse): Remove trailing newlines from
3190         help.
3191         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3192         from help.
3193         * language.c (add_set_language_command): Remove trailing newline
3194         from help.
3195         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3196         help.
3197         * disasm.c (_initialize_disasm): Remove trailing newline from
3198         help.
3199         * top.c (init_main): Remove trailing newline from help.
3200         * interps.c (_initialize_interpreter): Remove trailing newline
3201         from help.
3202         * btrace.c (_initialize_btrace): Remove trailing newlines from
3203         help.
3204         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3205         from help.
3206         * python/python.c (_initialize_python): Remove trailing newline
3207         from help.
3208         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3209         help.
3210         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3211         from help.  Reformat some text.
3212         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3213         from help.
3214         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3215         newline from help.
3216
3217 2019-06-11  Tom Tromey  <tromey@adacore.com>
3218
3219         * darwin-nat.c (darwin_decode_exception_message)
3220         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3221
3222 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * valops.c (value_slice): Check for not allocated or not
3225         associated values.
3226
3227 2019-06-10  Tom de Vries  <tdevries@suse.de>
3228
3229         PR gdb/24618
3230         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3231         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3232         invalid.
3233
3234 2019-06-10  Tom de Vries  <tdevries@suse.de>
3235
3236         PR gdb/24611
3237         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3238         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3239
3240 2019-06-10  Tom de Vries  <tdevries@suse.de>
3241
3242         PR symtab/24545
3243         * symtab.c (struct demangled_name_entry): Add language field.
3244         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3245         static minimal symbol".  Set and use language field.
3246
3247 2019-06-10  Tom Tromey  <tromey@adacore.com>
3248
3249         * ada-lang.c (_initialize_ada_language): Update help text.
3250
3251 2019-06-10  Tom Tromey  <tromey@adacore.com>
3252
3253         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3254         with a newline.
3255         * guile/guile.c (handle_boot_error): Don't end warning with a
3256         newline.
3257         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3258         warning with a newline.
3259         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3260         newline.
3261         (s12z_frame_cache): Likewise.
3262         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3263         a newline.
3264         * solib-svr4.c (disable_probes_interface): Don't end warning with
3265         a newline.
3266         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3267         newline.
3268         * python/python.c (do_finish_initialization): Don't end warning
3269         with a newline.
3270
3271 2019-06-10  Tom Tromey  <tom@tromey.com>
3272
3273         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3274         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3275         gdbpy_enter.
3276
3277 2019-06-10  Tom Tromey  <tromey@adacore.com>
3278
3279         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3280         data.
3281         (elf_new_init): Don't call stabsread_new_init.
3282         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3283         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3284         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3285
3286 2019-06-10  Tom de Vries  <tdevries@suse.de>
3287
3288         PR symtab/16264
3289         PR symtab/24517
3290         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3291
3292 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3293
3294         * source.c (find_and_open_source): Also rewrite relative file
3295         names.
3296
3297 2019-04-26  Amos Bird  <amosbird@gmail.com>
3298
3299         * annotate.c (annotate_thread_exited): Add "thread-exited"
3300         annotation.
3301
3302 2019-06-06  Tom Tromey  <tromey@adacore.com>
3303
3304         * maint.h (class scoped_command_stats): Use
3305         DISABLE_COPY_AND_ASSIGN.
3306         <print_time>: New method.
3307         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3308         print_time.
3309         (scoped_command_stats::print_time): New method.
3310
3311 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3312
3313         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3314         instructions of lengths 6 or 8 bytes.
3315
3316 2019-06-04  Pedro Alves  <palves@redhat.com>
3317
3318         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3319
3320         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3321         * breakpoint.c (condition_completer): Likewise.
3322         * cli/cli-dump.c (scan_expression): Likewise.
3323         * common/filestuff.c (mkdir_recursive): Likewise.
3324         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3325         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3326         (gdb_abspath): Likewise.
3327         * compile/compile-cplus-types.c
3328         (compile_cplus_instance::decl_name): Likewise.
3329         * completer.c (complete_explicit_location):
3330         (signal_completer, reg_or_group_completer_1): Likewise.
3331         * cp-support.c (cp_remove_params_if_any): Likewise.
3332         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3333         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3334         * infcmd.c (strip_bg_char): Likewise.
3335         * linespec.c (copy_token_string): Likewise.
3336         * mi/mi-main.c (output_cores): Likewise.
3337         * psymtab.c (psymtab_search_name):
3338         * symfile.c (test_set_ext_lang_command): Likewise.
3339         * target.c (target_fileio_read_stralloc): Likewise.
3340         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3341         * value.c (complete_internalvar): Likewise.
3342
3343 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3344
3345         Add objfile property to gdb.Type.
3346         * NEWS: Mention Python API addition.
3347         * python/py-type.c (typy_get_objfile): New method.
3348
3349 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3350
3351         * NEWS: Mention the new set|show style [title|highlight].
3352         Mention changes to "show style", "help" and "apropos".
3353
3354 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355
3356         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3357         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3358         instead of print_help_for_command.
3359         (print_doc_of_command): New function.
3360         (help_list): Add 'apropos -v word' suggestion.
3361         (print_help_for_command): Style the command name using title style.
3362         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3363         (_initialize_cli_cmds): Describe -v in apropos_command help.
3364
3365 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3366
3367         * cli/cli-style.h (cli_style_option): Add name in constructor,
3368         add m_name class member, add constructor with intensity,
3369         add name class function.
3370         (cli_style_option::add_setshow_commands): Remove name argument.
3371         (highlight_style, title_style): New styles.
3372         * cli/cli-style.c (do_show): New function that shows a style
3373         characteristic styling the style name with itself.
3374         (set_style_name): New function.
3375         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3376         Update all callers according to the changes in cli/cli-style.h.
3377         * utils.h (fputs_highlighted): New function.
3378         * utils.c (fputs_highlighted): Likewise.
3379
3380 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3381
3382         * NEWS: Mention new pipe command and new convenience variables.
3383
3384 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3385
3386         * cli/cli-cmds.c (pipe_command): New function.
3387         (_initialize_cli_cmds): Call add_com for pipe_command.
3388         Define | as an alias for pipe.
3389         (exit_status_set_internal_vars): New function.
3390         (shell_escape): Call exit_status_set_internal_vars.
3391         cli/cli-decode.c (find_command_name_length): Recognize | as
3392         a single character command.
3393
3394 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3395
3396         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3397         top.c (execute_command_to_ui_file): New function, mostly a copy
3398         of execute_command_to_string.
3399         (execute_command_to_string): Implement by calling
3400         execute_command_to_ui_file.
3401
3402 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3403
3404         * top.h (saved_command_line): Remove declaration.
3405         * top.c (previous_saved_command_line, previous_repeat_arguments):
3406         New variables.
3407         (saved_command_line): Make static, define together with other
3408         'repeat variables'.
3409         (dont_repeat): Clear repeat_arguments.
3410         (repeat_previous, get_saved_command_line, save_command_line):
3411         New functions.
3412         (gdb_init): Initialize saved_command_line
3413         and previous_saved_command_line.
3414         * main.c (captured_main_1): Remove saved_command_line initialization.
3415         * event-top.c (handle_line_of_input): Update to use
3416         the new 'repeat' related functions instead of direct access to
3417         saved_command_line.
3418         * command.h (repeat_previous, get_saved_command_line,
3419         save_command_line): New declarations.
3420         (dont_repeat): Add comment.
3421
3422 2019-05-30  Tom Tromey  <tromey@adacore.com>
3423
3424         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3425         Fix comment.
3426         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3427
3428 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3429
3430         PR cli/24587
3431         * completer.c (complete): Initialize variable word.
3432
3433 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3434
3435         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3436         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3437         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3438         'body' is NULL to the outter 'if', protecting the '!is_define'
3439         situation as well.
3440
3441 2019-05-29  Tom Tromey  <tromey@adacore.com>
3442
3443         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3444         (dwarf_unknown): New function.
3445         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3446         (dwarf_type_encoding_name): Use dwarf_unknown.
3447
3448 2019-05-29  Tom Tromey  <tromey@adacore.com>
3449
3450         PR c++/20020:
3451         * cp-valprint.c (cp_print_value_fields): Call
3452         cp_print_static_field inside "try".
3453
3454 2019-05-29  Tom Tromey  <tromey@adacore.com>
3455
3456         * inflow.c (struct terminal_info): Add default operator=.
3457         * configure: Rebuild.
3458         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3459         -Wdeprecated-copy-dtor, -Wredundant-move.
3460
3461 2019-05-29  Tom Tromey  <tromey@adacore.com>
3462
3463         * NEWS: Add entry.
3464         * infcmd.c (print_return_value_1): Handle finish_print
3465         option.
3466         (show_print_finish): New function.
3467         (_initialize_infcmd): Add "set/show print finish" commands.
3468         * valprint.c (user_print_options): Initialize new member.
3469         * valprint.h (struct value_print_options) <finish_print>: New
3470         member.
3471
3472 2019-05-28  Tom Tromey  <tromey@adacore.com>
3473
3474         * ada-lang.c (ada_remove_Xbn_suffix)
3475         (find_old_style_renaming_symbol)
3476         (parse_old_style_renaming): Remove.
3477         (ada_find_renaming_symbol): Don't call
3478         find_old_style_renaming_symbol.
3479         (ada_is_renaming_symbol): Rename from
3480         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3481         bool.  Now static.
3482         (ada_read_var_value): Update and simplify.
3483         * ada-exp.y (write_var_or_type): Remove old code.
3484
3485 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * event-top.c: Remove include comment.
3488         * inflow.c (class scoped_ignore_sigttou): Move from here...
3489         * inflow.h (class scoped_ignore_sigttou): ...to here.
3490         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3491         * top.c:  Remove include comment.
3492
3493 2019-05-27  Tom Tromey  <tom@tromey.com>
3494
3495         * NEWS: Fix typo.
3496
3497 2019-05-22  Tom Tromey  <tromey@adacore.com>
3498
3499         * target.c (target_follow_exec): Constify parameter.
3500         * target-delegates.c: Rebuild.
3501         * remote.c (remote_target::follow_exec): Constify parameter.
3502         * infrun.c (follow_exec): Constify parameter.
3503         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3504         (target_follow_exec): Likewise.
3505
3506 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3507
3508         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3509         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3510
3511 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3512
3513         * NEWS: Add debugredirect and testsuite sections.
3514
3515 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3516
3517         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3518         target descriptions using exclusively floating point register name
3519         aliases.
3520
3521 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         PR gdb/18644:
3524         * f-lang.c (build_fortran_types): Handle the case where
3525         gdbarch_floatformat_for_type returns a nullptr.
3526
3527 2019-05-21  Tom de Vries  <tdevries@suse.de>
3528
3529         PR cli/24587
3530         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3531
3532 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3533
3534         PR gdb/18644:
3535         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3536         16-byte floats.
3537         * i386-tdep.c (i386_floatformat_for_type): Use
3538         floatformats_ia64_quad for the 16-byte floating point component
3539         within a fortran 32-byte complex number.
3540
3541 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3544         delete default constructor.
3545         (find_partial_die): Update to return const struct.
3546         (partial_die_parent_scope): Move variable declaration into scope
3547         of its use and change its type to auto.
3548         (guess_partial_die_structure_name): Likewise.
3549         (partial_die_info::fixup): Likewise.
3550
3551 2019-05-17  Tom Tromey  <tromey@adacore.com>
3552
3553         * source.c (find_and_open_source): Remove cast.
3554
3555 2019-05-17  Tom Tromey  <tromey@adacore.com>
3556
3557         * annotate.c (annotate_source): Make "filename" const.
3558         * annotate.h (annotate_source): Use const.
3559
3560 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3561
3562         * disasm.c (set_disassembler_options): Send errors to stderr.
3563
3564 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3565
3566         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3567         (cli_interp_base::set_logging): Check debug_redirect.
3568         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3569         * cli/cli-logging.c (debug_redirect): Add static variable.
3570         (pop_output_files): Add default param.
3571         (handle_redirections): Print debug setting.
3572         (show_logging_command): Likewise.
3573         (_initialize_cli_logging): Add debugredirect command.
3574         * interps.c (current_interp_set_logging): Add debug_redirect
3575         parameter.
3576         * interps.h (set_logging): Add debug_redirect parameter.
3577         (current_interp_set_logging): Likewise.
3578         * mi/mi-common.h: Likewise.
3579         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3580
3581 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3582             Tom Tromey  <tromey@adacore.com>
3583
3584         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3585         directly.
3586         * cli/cli-interp.h (make_logging_output): Remove declaration.
3587         * cli/cli-logging.c (make_logging_output): Remove function.
3588         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3589         directly.
3590         * ui-file.c (tee_file::tee_file): Remove bools.
3591         (tee_file::~tee_file): Remove deletes.
3592         * ui-file.h (tee_file): Remove bools.
3593
3594 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3595
3596         * mi/mi-cmds.h (mi_cmd_complete): New function.
3597         * mi/mi-main.c (mi_cmd_complete): Likewise.
3598         * mi/mi-cmds.c: Define new MI command -complete.
3599         * NEWS: Mention new -complete command.
3600
3601 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3602
3603         * completer.h (complete): New function.
3604         * completer.c (complete): Likewise.
3605         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3606         function defined in completer.h.
3607
3608 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3609
3610         * MAINTAINERS (Write After Approval): Add myself.
3611
3612 2019-05-17  Tom de Vries  <tdevries@suse.de>
3613
3614         PR gdb/24094
3615         * dwarf2read.c (struct cu_partial_die_info): New struct.
3616         (find_partial_die): Return cu_partial_die_info.
3617         (partial_die_parent_scope, guess_partial_die_structure_name)
3618         (partial_die_info::fixup): Handle new return type of find_partial_die.
3619
3620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3621
3622         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3623         "std::string", simplifying the algorithm.
3624
3625 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3626
3627         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3628         (stap_static_probe_ops::get_probes): Likewise.
3629
3630 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3631
3632         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3633         '-')" and "else if".
3634         (stap_parse_single_operand): Join checks for
3635         "gdbarch_stap_parse_special_token_p" and
3636         "gdbarch_stap_parse_special_token" in the same "if" statement.
3637         Invert check when verifying for operation on register
3638         displacement.
3639
3640 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3641
3642         * stap-probe.c (stap_get_opcode): Update comment.
3643         (stap_get_expected_argument_type): Likewise.
3644         (handle_stap_probe): Likewise.
3645
3646 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3647
3648         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3649         return type to 'bool'.  Adjust comment.  Use 'bool' when
3650         appropriate.
3651         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3652         * stap-probe.c (stap_parse_argument_1): Likewise.
3653         (stap_is_operator): Likewise.
3654         (stap_is_generic_prefix): Likewise.
3655         (stap_is_register_prefix): Likewise.
3656         (stap_is_register_indirection_prefix): Likewise.
3657         (stap_is_integer_prefix): Likewise.
3658         (stap_generic_check_suffix): Likewise.
3659         (stap_check_integer_suffix): Likewise.
3660         (stap_check_register_suffix): Likewise.
3661         (stap_check_register_indirection_suffix): Likewise.
3662         (stap_parse_register_operand): Likewise.
3663         (stap_parse_single_operand): Likewise.
3664         (stap_parse_argument_1): Likewise.
3665         (stap_probe::get_argument_count): Likewise.
3666         (stap_is_operator): Likewise.
3667
3668 2019-05-16  Tom Tromey  <tromey@adacore.com>
3669
3670         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3671         keyword to foreach.
3672
3673 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * linux-thread-db.c (try_thread_db_load_1): Change return type
3676         to bool.
3677         (try_thread_db_load): Likewise.
3678         (try_thread_db_load_from_pdir_1): Likewise.
3679         (try_thread_db_load_from_pdir): Likewise.
3680         (try_thread_db_load_from_sdir): Likewise.
3681         (try_thread_db_load_from_dir): Likewise.
3682         (thread_db_load_search): Likewise.
3683         (has_libpthread): Likewise.
3684         (thread_db_load): Likewise.
3685
3686 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3687
3688         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3689         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3690         NULL, and complain/return if that's the case.
3691
3692 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3693
3694         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3695         (advance, posn, abstract_read_memory): New functions.
3696         [struct mem_read_abstraction]: New struct.
3697         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3698
3699 2019-05-14  Tom Tromey  <tromey@adacore.com>
3700
3701         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3702         value is not lval_memory.
3703
3704 2019-05-14  Tom Tromey  <tromey@adacore.com>
3705
3706         * solib.c (info_sharedlibrary_command): Style the file name.
3707
3708 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3709
3710         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3711         (aarch64_vnv_type): Likewise.
3712         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3713         * common/tdesc.c: Likewise.
3714         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3715         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3716         * features/aarch64-fpu.xml: Add ieee half view.
3717         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3718         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3719         * gdbtypes.h (struct builtin_type): Likewise.
3720         (struct objfile_type): Likewise.
3721
3722 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3723
3724         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3725         typo.
3726         * location.h (string_to_event_location): Likewise.
3727
3728 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3729
3730         GDB 8.3 released.
3731
3732 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3733
3734         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3735         New variable declaration.
3736         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3737         New variable.
3738         (print_one_breakpoint): Use ui_out::test_flags and new global
3739         variable to compute use_fixed_output.
3740         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3741         Remove.
3742         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3743         (mi_multi_location_breakpoint_output_fixed): Remove.
3744         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3745         new variable.
3746         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3747         fix_multi_location_breakpoint_output flag if version >= 3.
3748         * ui-out.h (enum ui_out_flag)
3749         <fix_multi_location_breakpoint_output>: New enumerator.
3750
3751 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3752
3753         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3754
3755 2019-05-10  Tom Tromey  <tromey@adacore.com>
3756
3757         * ada-lang.c (catch_ada_completer): New function.
3758         (_initialize_ada_language): Use it.
3759
3760 2019-05-10  Tom Tromey  <tromey@adacore.com>
3761
3762         * thread.c (print_thread_info): Make "requested_threads" const.
3763         * gdbthread.h (print_thread_info): Make "requested_threads"
3764         const.
3765         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3766         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3767
3768 2019-05-08  Tom Tromey  <tom@tromey.com>
3769
3770         * gdbtypes.c (objfile_type_data): Change type.
3771         (objfile_type, _initialize_gdbtypes): Update.
3772
3773 2019-05-08  Tom Tromey  <tom@tromey.com>
3774
3775         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3776         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3777         (_initialize_dwarf2_frame): Update.
3778
3779 2019-05-08  Tom Tromey  <tom@tromey.com>
3780
3781         * objc-lang.c (objc_objfile_data): Change type.
3782         (find_methods): Update.
3783         (_initialize_objc_lang): Remove.
3784
3785 2019-05-08  Tom Tromey  <tom@tromey.com>
3786
3787         * stabsread.c (rs6000_builtin_type_data): Change type.
3788         (rs6000_builtin_type, _initialize_stabsread): Update.
3789
3790 2019-05-08  Tom Tromey  <tom@tromey.com>
3791
3792         * mips-tdep.c (mips_pdr_data): Remove.
3793         (_initialize_mips_tdep): Update.
3794
3795 2019-05-08  Tom Tromey  <tom@tromey.com>
3796
3797         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3798         (hppa_init_objfile_priv_data, read_unwind_info)
3799         (find_unwind_entry, _initialize_hppa_tdep): Update.
3800
3801 2019-05-08  Tom Tromey  <tom@tromey.com>
3802
3803         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3804         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3805         on obstack.
3806         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3807
3808 2019-05-08  Tom Tromey  <tom@tromey.com>
3809
3810         * mdebugread.c (basic_type_data): Change type.
3811         (basic_type, _initialize_mdebugread): Update.
3812
3813 2019-05-08  Tom Tromey  <tom@tromey.com>
3814
3815         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3816
3817 2019-05-08  Tom Tromey  <tom@tromey.com>
3818
3819         * nto-tdep.c (nto_inferior_data_reg): Change type.
3820         (nto_inferior_data): Update.
3821         (nto_inferior_data_cleanup, nto_new_inferior_data)
3822         (_initialize_nto_tdep): Remove.
3823         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * ada-lang.c (struct ada_inferior_data): Add initializers.
3828         (ada_inferior_data): Change type.
3829         (ada_inferior_data_cleanup): Remove.
3830         (get_ada_inferior_data, ada_inferior_exit)
3831         (struct ada_pspace_data): Add initializers, destructor.
3832         (ada_pspace_data_handle): Change type.
3833         (get_ada_pspace_data): Update.
3834         (ada_pspace_data_cleanup): Remove.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * coffread.c (struct coff_symfile_info): Add initializers.
3839         (coff_objfile_data_key): Move lower.  Change type.
3840         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3841         Update.
3842         (coff_free_info): Remove.
3843
3844 2019-05-08  Tom Tromey  <tom@tromey.com>
3845
3846         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3847         (fbsd_pspace_data_handle): Move lower.  Change type.
3848         (get_fbsd_pspace_data): Update.
3849         (fbsd_pspace_data_cleanup): Remove.
3850         (_initialize_fbsd_tdep): Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3855         (get_ada_tasks_pspace_data): Update.
3856         (ada_tasks_pspace_data_cleanup): Remove.
3857         (_initialize_tasks): Update.
3858         (ada_tasks_inferior_data_handle): Change type.
3859         (get_ada_tasks_inferior_data): Update.
3860         (ada_tasks_inferior_data_cleanup): Remove.
3861         (struct ada_tasks_pspace_data): Add initializers.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3866         * symfile-debug.c (debug_sym_get_probes): Change type.
3867         * stap-probe.c (handle_stap_probe):
3868         (stap_static_probe_ops::get_probes): Change type.
3869         * probe.h (class static_probe_ops) <get_probes>: Change type.
3870         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3871         (parse_probes_in_pspace): Update.
3872         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3873         Update.
3874         (any_static_probe_ops::get_probes): Change type.
3875         * elfread.c (elfread_data): New typedef.
3876         (probe_key): Change type.
3877         (elf_get_probes): Likewise.  Update.
3878         (probe_key_free): Remove.
3879         (_initialize_elfread): Update.
3880         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3881         Change type.
3882         (dtrace_process_dof_probe, dtrace_process_dof)
3883         (dtrace_static_probe_ops::get_probe): Change type.
3884
3885 2019-05-08  Tom Tromey  <tom@tromey.com>
3886
3887         * xcoffread.c (struct xcoff_symfile_info): Rename from
3888         coff_symfile_info.  Add initializers.
3889         (xcoff_objfile_data_key): Move lower.  Change type.
3890         (XCOFF_DATA): Rewrite.
3891         (xcoff_free_info): Remove.
3892         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3893         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3894         (xcoff_initial_scan): Update.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * solib-svr4.c (struct svr4_info): Add initializers and
3899         destructor.
3900         <probes_table>: Now an htab_up.
3901         (solib_svr4_pspace_data): Change type.
3902         (free_probes_table): Simplify.
3903         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3904         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3905         (probes_table_remove_objfile_probes, register_solib_event_probe)
3906         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3907         (_initialize_svr4_solib): Update.
3908
3909 2019-05-08  Tom Tromey  <tom@tromey.com>
3910
3911         * remote.c (remote_pspace_data): Change type.
3912         (remote_pspace_data_cleanup): Remove.
3913         (get_remote_exec_file, set_pspace_remote_exec_file)
3914         (_initialize_remote): Update.
3915
3916 2019-05-08  Tom Tromey  <tom@tromey.com>
3917
3918         * breakpoint.c (breakpoint_objfile_key): Change type.
3919         (get_breakpoint_objfile_data): Update.
3920         (free_breakpoint_objfile_data): Remove.
3921         (_initialize_breakpoint): Update.
3922
3923 2019-05-08  Tom Tromey  <tom@tromey.com>
3924
3925         * linux-tdep.c (struct linux_info): Add initializers.
3926         (linux_inferior_data): Move.  Change type.
3927         (invalidate_linux_cache_inf): Update.
3928         (linux_inferior_data_cleanup): Remove.
3929         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3930
3931 2019-05-08  Tom Tromey  <tom@tromey.com>
3932
3933         * auxv.c (auxv_inferior_data): Move.  Change type.
3934         (auxv_inferior_data_cleanup): Remove.
3935         (invalidate_auxv_cache_inf): Rewrite.
3936         (get_auxv_inferior_data, _initialize_auxv): Update.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3941         (symfile_debug_objfile_data_key): Change type.
3942         (symfile_debug_installed, debug_qf_has_symbols)
3943         (debug_qf_find_last_source_symtab)
3944         (debug_qf_forget_cached_source_info)
3945         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3946         (debug_qf_print_stats, debug_qf_dump)
3947         (debug_qf_expand_symtabs_for_function)
3948         (debug_qf_expand_all_symtabs)
3949         (debug_qf_expand_symtabs_with_fullname)
3950         (debug_qf_map_matching_symbols)
3951         (debug_qf_expand_symtabs_matching)
3952         (debug_qf_find_pc_sect_compunit_symtab)
3953         (debug_qf_map_symbol_filenames)
3954         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3955         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3956         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3957         (debug_sym_read_linetable, debug_sym_relocate): Update.
3958         (symfile_debug_free_objfile): Remove.
3959         (install_symfile_debug_logging, _initialize_symfile_debug):
3960         Update.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3965         allocate_on_obstack.
3966         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3967         (get_dwarf2_per_objfile): Update.
3968         (set_dwarf2_per_objfile): Remove.
3969         (dwarf2_has_info, dwarf2_get_section_info): Update.
3970         (dwarf2_free_objfile): Remove.
3971         (_initialize_dwarf2_read): Update.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3976         initializers.
3977         <unsupported_script_warning_printed,
3978         script_not_found_warning_printed>: Now bool.
3979         (auto_load_pspace_data): Change type.
3980         (~auto_load_pspace_info): Rename from
3981         auto_load_pspace_data_cleanup.
3982         (get_auto_load_pspace_data, init_loaded_scripts_info)
3983         (clear_section_scripts, maybe_print_unsupported_script_warning)
3984         (maybe_print_script_not_found_warning, _initialize_auto_load):
3985         Update.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * objfiles.c (objfile_pspace_info): Add destructor and
3990         initializers.
3991         (objfiles_pspace_data): Change type.
3992         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3993         (get_objfile_pspace_data): Update.
3994         (objfiles_bfd_data): Change type.
3995         (get_objfile_bfd_data): Update.
3996         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4001         Change type.
4002         (get_catch_syscall_inferior_data): Update.
4003         (catch_syscall_inferior_data_cleanup): Remove.
4004         (_initialize_break_catch_syscall): Update.
4005
4006 2019-05-08  Tom Tromey  <tom@tromey.com>
4007
4008         * inflow.c (struct terminal_info): Add destructor and
4009         initializers.
4010         (inflow_inferior_data): Change type.
4011         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4012         (get_inflow_inferior_data, inflow_inferior_exit)
4013         (swap_terminal_info, _initialize_inflow): Update.
4014
4015 2019-05-08  Tom Tromey  <tom@tromey.com>
4016
4017         * target-dcache.c (target_dcache_cleanup): Remove.
4018         (target_dcache_aspace_key): Change type.
4019         (target_dcache_init_p, target_dcache_invalidate)
4020         (target_dcache_get, target_dcache_get_or_init)
4021         (_initialize_target_dcache): Update.
4022         * dcache.h (struct dcache_deleter): New.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * symtab.c (struct symbol_cache): Add destructor and
4027         initializers.
4028         (symbol_cache_key): Move.  Change type.
4029         (make_symbol_cache, free_symbol_cache): Remove.
4030         (get_symbol_cache): Update.
4031         (symbol_cache_cleanup): Remove.
4032         (ALL_PSPACES, symbol_cache_flush)
4033         (maintenance_print_symbol_cache)
4034         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4035         Update.
4036
4037 2019-05-08  Tom Tromey  <tom@tromey.com>
4038
4039         * symtab.c (struct main_info): Add destructor and initializers.
4040         (main_progspace_key): Move.  Change type.
4041         (get_main_info): Update.
4042         (main_info_cleanup): Remove.
4043         (_initialize_symtab): Update.
4044
4045 2019-05-08  Tom Tromey  <tom@tromey.com>
4046
4047         * registry.h (DECLARE_REGISTRY): Define the _key class.
4048
4049 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * NEWS: Merge two 'New commands' sections.
4052
4053 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4054
4055         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4056         parameter and use Ada language definition instead.
4057         (ada_val_print_ptr): Remove unused language parameter.
4058         (ada_val_print_num): Remove language parameter and use Ada language
4059         definition instead.
4060         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4061         parameter.
4062         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4063         parameter and use Ada language definition instead.
4064         (ada_val_print_1): Update all ada_val_print_xxx calls.
4065         Remove language parameter.
4066         (ada_val_print): Update ada_val_print_1 call.
4067
4068 2019-05-08  Tom Tromey  <tromey@adacore.com>
4069
4070         * remote.c (remote_hw_watchpoint_limit)
4071         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4072         Now static.
4073
4074 2019-05-08  Tom Tromey  <tromey@adacore.com>
4075
4076         * maint.c (_initialize_maint_cmds): Move initialization code to
4077         remote.c.
4078         (watchdog, show_watchdog): Move to remote.c.
4079         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4080         "watchdog" static.
4081         (_initialize_remote): Move initialization code from maint.c.
4082         * defs.h (watchdog): Don't declare.
4083
4084 2019-05-08  Tom Tromey  <tromey@adacore.com>
4085
4086         * tui/tui-interp.c: Include main.h.
4087         * interps.c: Include main.h.
4088         * main.h (interpreter_p): Declare.
4089         * defs.h (interpreter_p): Don't declare.
4090
4091 2019-05-08  Tom Tromey  <tromey@adacore.com>
4092
4093         * dwarf2loc.c: Include dwarf2read.h.
4094         * defs.h (read_unsigned_leb128): Don't declare.
4095         * dwarf2read.h (read_unsigned_leb128): Declare.
4096
4097 2019-05-08  Tom Tromey  <tromey@adacore.com>
4098
4099         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4100         method.
4101
4102 2019-05-08  Tom Tromey  <tromey@adacore.com>
4103
4104         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4105         when no wrap column is set.
4106
4107 2019-05-08  Tom Tromey  <tromey@adacore.com>
4108
4109         * c-lang.c (c_get_string): Handle non-C-style arrays.
4110
4111 2019-05-08  Tom Tromey  <tromey@adacore.com>
4112
4113         * typeprint.c (print_offset_data::update): Print the bit offset,
4114         not the number of bits remaining.
4115
4116 2019-05-08  Tom Tromey  <tromey@adacore.com>
4117
4118         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4119         padding at end of comment.
4120
4121 2019-05-08  Tom Tromey  <tromey@adacore.com>
4122
4123         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4124         Compare main types.
4125
4126 2019-05-06  Tom Tromey  <tom@tromey.com>
4127
4128         * common/scoped_mmap.c: Include common-defs.h.
4129         * common/scoped_mmap.h: Don't include config.h.
4130
4131 2019-05-04  Tom Tromey  <tom@tromey.com>
4132
4133         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4134         (struct aarch64_call_info): Add initializers.
4135         <si>: Now a std::vector.
4136         (pass_on_stack, aarch64_push_dummy_call): Update.
4137
4138 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4139             Tom Tromey  <tom@tromey.com>
4140
4141         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4142         (ppc_threads): Now a std::vector.  Now static.
4143         (hwdebug_find_thread_points_by_tid)
4144         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4145         Update.
4146
4147 2019-05-04  Tom Tromey  <tom@tromey.com>
4148
4149         * arc-tdep.c (arc_tdesc_init): Return bool.
4150
4151 2019-05-04  Tom Tromey  <tom@tromey.com>
4152
4153         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4154         Use gdb_assert_not_reached.
4155
4156 2019-05-04  Tom Tromey  <tom@tromey.com>
4157
4158         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4159         "false".
4160
4161 2019-05-04  Tom Tromey  <tom@tromey.com>
4162
4163         * arc-tdep.c (arc_tdesc_init): Use bool.
4164
4165 2019-05-04  Tom Tromey  <tom@tromey.com>
4166
4167         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4168
4169 2019-05-04  Tom Tromey  <tom@tromey.com>
4170
4171         * cli/cli-cmds.c (valid_command_p): Return bool.
4172
4173 2019-05-04  Tom Tromey  <tom@tromey.com>
4174
4175         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4176         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4177
4178 2019-05-04  Raul Tambre  <raul@tambre.ee>
4179
4180         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4181         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4182         operator for comparison.
4183
4184 2019-05-04  Tom Tromey  <tom@tromey.com>
4185
4186         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4187         (lookup_partial_symbol, print_partial_symbols)
4188         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4189         (psymbol_compare): Update.
4190         (add_psymbol_to_bcache): Clear the entire psymbol.
4191         (maintenance_check_psymtabs): Update.
4192         * psympriv.h (struct partial_symbol): Don't derive from
4193         general_symbol_info.
4194         <obj_section, unrelocated_address, address,
4195         set_unrelocated_address>: Update.
4196         <ginfo>: New member.
4197         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4198         (debug_names::write_psymbols): Update.
4199
4200 2019-05-04  Tom de Vries  <tdevries@suse.de>
4201
4202         * contrib/cc-with-tweaks.sh: Support -n arg.
4203
4204 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4205
4206         * corelow.c (core_target::detach): Ensure frame cache and
4207         register caches are cleared.
4208         inferior.c (exit_inferior_1): Likewise.
4209
4210 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4211             Tom Tromey  <tom@tromey.com>
4212
4213         * dictionary.c (collate_pending_symbols_by_language): Remove
4214         "struct" from foreach.
4215         * symtab.c (lookup_global_symbol_from_objfile)
4216         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4217         foreach.
4218         * ser-tcp.c (net_open): Remove "struct" from foreach.
4219         * objfiles.c (objfile_relocate, objfile_rebase)
4220         (objfile_has_symbols): Remove "struct" from foreach.
4221         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4222         from foreach.
4223         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4224         foreach.
4225         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4226         "struct" from foreach.
4227         * ada-lang.c (create_excep_cond_exprs)
4228         (ada_exception_catchpoint_cond_string): Remove "struct" from
4229         foreach.
4230
4231 2019-05-03  Tom Tromey  <tromey@adacore.com>
4232
4233         * ada-exp.y (convert_char_literal): Check suffix of each
4234         enumerator.
4235
4236 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4237
4238         PR ada/21406:
4239         * ada-exp.y (yywrap): Don't define.
4240         * ada-lex.l (%option): Add noyywrap
4241         (yywrap): Remove.
4242
4243 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4244
4245         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4246         _WIN32_WINNT to the XP level, unless already defined to a higher
4247         level.
4248
4249         * unittests/parse-connection-spec-selftests.c:
4250         * ser-tcp.c:
4251         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4252         override.
4253
4254         * symfile.c (find_separate_debug_file): Remove colon from the
4255         drive spec of DOS/Windows file names of the target, so that the
4256         file name produced from DEBUGDIR and the target's directory will
4257         be valid on DOS/Windows systems.
4258
4259 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * rust-lang.c (val_print_struct): Handle printing structures
4262         containing strings.
4263
4264 2019-05-02  Tom Tromey  <tromey@adacore.com>
4265
4266         * valarith.c (_initialize_valarith): Remove.
4267
4268 2019-05-01  Tom Tromey  <tromey@adacore.com>
4269
4270         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4271         bitfields.
4272
4273 2019-05-01  Tom Tromey  <tromey@adacore.com>
4274
4275         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4276         for big-endian copies.
4277
4278 2019-04-30  Ali Tamur  <tamur@google.com>
4279         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4280         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4281         (read_3_bytes): New function.
4282
4283 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4284
4285         * windows-nat.c (main_thread_id): Delete.
4286         (handle_output_debug_string): Replace main_thread_id by
4287         current_event.dwThreadId.
4288         (fake_create_process): Likewise.
4289         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4290         Do not set main_thread_id.
4291         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4292         current_event.dwThreadId.
4293         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4294
4295 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4296
4297         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4298         Use current_event.dwThreadId instead of main_thread_id.
4299
4300 2019-04-30  Tom Tromey  <tromey@adacore.com>
4301
4302         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4303         (create_excep_cond_exprs): Iterate over program spaces.
4304         (ada_exception_catchpoint_cond_string): Examine all minimal
4305         symbols for exception types.
4306
4307 2019-04-30  Tom Tromey  <tromey@adacore.com>
4308
4309         PR c++/24470:
4310         * dwarf2read.c (process_structure_scope): Handle case where type
4311         has template parameters but no symbol was created.
4312
4313 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4314             Chris January  <chris.january@arm.com>
4315
4316         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4317         qualifier.
4318         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4319
4320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * f-typeprint.c (f_print_type): Update rules for printing
4323         whitespace.
4324         (f_type_print_varspec_suffix): Likewise.
4325
4326 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4327             Chris January  <chris.january@arm.com>
4328
4329         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4330         function arguments.
4331
4332 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * f-lang.c (build_fortran_types): Change name of void type to
4335         lower case.
4336         * f-typeprint.c (f_type_print_base): Print the name of the void
4337         type, rather than a fixed string.
4338         * f-valprint.c (f_decorations): Use lower case void string.
4339
4340 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4341             Chris January  <chris.january@arm.com>
4342
4343         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4344         types for Fortran.
4345
4346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4347             Chris January  <chris.january@arm.com>
4348             David Lecomber  <david.lecomber@arm.com>
4349
4350         * f-exp.y (BINOP_INTRINSIC): New token.
4351         (exp): New parser rule handling BINOP_INTRINSIC.
4352         (f77_keywords): Add new builtin procedures.
4353         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4354         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4355         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4356         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4357         (print_unop_subexp_f): New function.
4358         (print_binop_subexp_f): New function.
4359         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4360         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4361         (dump_subexp_body_f): Likewise.
4362         (operator_check_f): Likewise.
4363         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4364         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4365
4366 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4367
4368         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4369         UNOP_KIND.
4370         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4371         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4372         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4373         (operator_length_f): New fuction.
4374         (print_subexp_f): New function.
4375         (op_name_f): New function.
4376         (dump_subexp_body_f): New function.
4377         (operator_check_f): New function.
4378         (exp_descriptor_f): Replace standard expression handling functions
4379         with new functions.
4380         * gdb/fortran-operator.def: New file.
4381         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4382         * gdb/std-operator.def: Remove UNOP_KIND.
4383
4384 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * std-operator.def: Remove unbalanced, stray double quote
4387         character.
4388
4389 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4390             Chris January  <chris.january@arm.com>
4391             Daniel Everett  <daniel.everett@arm.com>
4392             Nick Forrington  <nick.forrington@arm.com>
4393             Richard Bunt  <richard.bunt@arm.com>
4394
4395         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4396         of depth when printing anonymous structs or unions.
4397         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4398         Don't print either the top-level value, or the children if the
4399         max-depth is exceeded.
4400         (ppscm_print_children): When printing the key of a map, allow one
4401         extra level of depth.
4402         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4403         print either the top-level value, or the children if the max-depth
4404         is exceeded.
4405         (print_children): When printing the key of a map, allow one extra
4406         level of depth.
4407         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4408         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4409         (user_print_options): Initialise max_depth field.
4410         (val_print_scalar_or_string_type_p): New function.
4411         (val_print): Check to see if the max depth has been reached.
4412         (val_print_check_max_depth): Define new function.
4413         (show_print_max_depth): New function.
4414         (_initialize_valprint): Add 'print max-depth' option.
4415         * valprint.h (struct value_print_options) <max_depth>: New field.
4416         (val_print_check_max_depth): Declare new function.
4417         * NEWS: Document new feature.
4418
4419 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * ada-lang.c (ada_language_defn): Initialise new field.
4422         * c-lang.c (c_is_string_type_p): New function.
4423         (c_language_defn): Initialise new field.
4424         (cplus_language_defn): Initialise new field.
4425         (asm_language_defn): Initialise new field.
4426         (minimal_language_defn): Initialise new field.
4427         * c-lang.h (c_is_string_type_p): Declare new function.
4428         * d-lang.c (d_language_defn): Initialise new field.
4429         * f-lang.c (f_is_string_type_p): New function.
4430         (f_language_defn): Initialise new field.
4431         * go-lang.c (go_is_string_type_p): New function.
4432         (go_language_defn): Initialise new field.
4433         * language.c (default_is_string_type_p): New function.
4434         (unknown_language_defn): Initialise new field.
4435         (auto_language_defn): Initialise new field.
4436         * language.h (struct language_defn) <la_is_string_type_p>: New
4437         member variable.
4438         (default_is_string_type_p): Declare new function.
4439         * m2-lang.c (m2_language_defn): Initialise new field.
4440         * objc-lang.c (objc_language_defn): Initialise new field.
4441         * opencl-lang.c (opencl_language_defn): Initialise new field.
4442         * p-lang.c (pascal_is_string_type_p): New function.
4443         (pascal_language_defn): Initialise new field.
4444         * rust-lang.c (rust_is_string_type_p): New function.
4445         (rust_language_defn): Initialise new field.
4446
4447 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4450         New field.
4451         * ada-lang.c (ada_language_defn): Initialise new field.
4452         * c-lang.c (c_language_defn): Likewise.
4453         (cplus_language_defn): Likewise.
4454         (asm_language_defn): Likewise.
4455         (minimal_language_defn): Likewise.
4456         * d-lang.c (d_language_defn): Likewise.
4457         * f-lang.c (f_language_defn): Likewise.
4458         * go-lang.c (go_language_defn): Likewise.
4459         * language.c (unknown_language_defn): Likewise.
4460         (auto_language_defn): Likewise.
4461         * m2-lang.c (m2_language_defn): Likewise.
4462         * objc-lang.c (objc_language_defn): Likewise.
4463         * opencl-lang.c (opencl_language_defn): Likewise.
4464         * p-lang.c (pascal_language_defn): Likewise.
4465         * rust-lang.c (rust_language_defn): Likewise.
4466
4467 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * ada-lang.c (ada_is_character_type): Change return type to bool.
4470         (ada_is_string_type): Likewise.
4471         * ada-lang.h (ada_is_character_type): Update declaration
4472         (ada_is_string_type): Likewise.
4473
4474 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4475
4476         Support style in 'frame|thread apply'
4477
4478         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4479         * record.c (record_start, record_stop): Update callers of
4480         execute_command_to_string with false.
4481         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4482         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4483         methods.
4484         (class string_file): New constructor with term_out parameter.
4485         Override methods term_out and can_emit_style_escape.  New member
4486         term_out.
4487         (class stdio_file): Override can_emit_style_escape.
4488         (class tee_file): Override term_out and can_emit_style_escape.
4489         * utils.h (can_emit_style_escape): Remove.
4490         * utils.c (can_emit_style_escape): Likewise.
4491         Update all callers of can_emit_style_escape (SOMESTREAM) to
4492         SOMESTREAM->can_emit_style_escape.
4493         * source-cache.c (source_cache::get_source_lines): Likewise.
4494         * stack.c (frame_apply_command_count): Call execute_command_to_string
4495         passing the term_out characteristic of the current gdb_stdout.
4496         * thread.c (thr_try_catch_cmd): Likewise.
4497         * top.c (execute_command_to_string): pass term_out parameter
4498         to construct the string_file for the command output.
4499         * ui-file.c (term_cli_styling): New function (most code moved
4500         from utils.c can_emit_style_escape).
4501         (string_file::string_file, string_file::can_emit_style_escape,
4502         stdio_file::can_emit_style_escape, tee_file::term_out,
4503         tee_file::can_emit_style_escape): New functions.
4504
4505 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4506
4507         * NEWS: Mention the new set|show may-call-functions.
4508         * infcall.c (may_call_functions_p): New variable.
4509         (show_may_call_functions_p): New function.
4510         (call_function_by_hand_dummy): Throws an error if not
4511         may-call-functions.
4512         (_initialize_infcall): Call add_setshow_boolean_cmd for
4513         may-call-functions.
4514
4515 2019-04-25  Keith Seitz  <keiths@redhat.com>
4516
4517         PR c++/24367
4518         * cp-support.c (inspect_type): Don't attempt substitutions
4519         of symbol with the same name.
4520
4521 2019-04-25  Tom Tromey  <tromey@adacore.com>
4522
4523         PR gdb/24475:
4524         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4525         static.
4526
4527 2019-04-25  Tom Tromey  <tromey@adacore.com>
4528
4529         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4530         rvalue reference.
4531         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4532         (gdb_xml_parser::parse): Use std::move.
4533         * python/python-internal.h (gdbpy_convert_exception): Take a const
4534         reference.
4535         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4536         std::move.
4537         * python/py-utils.c (gdbpy_convert_exception): Take a const
4538         reference.
4539         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4540         Use std::move.
4541         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4542         Use std::move.
4543         * mi/mi-main.c (mi_print_exception): Take a const reference.
4544         * main.c (handle_command_errors): Take a const reference.
4545         * linespec.c (parse_linespec): Use std::move.
4546         * infcall.c (run_inferior_call): Use std::move.
4547         (call_function_by_hand_dummy): Use std::move.
4548         * exec.c (try_open_exec_file): Use std::move.
4549         * exceptions.h (exception_print, exception_fprintf)
4550         (exception_print_same): Update.
4551         * exceptions.c (print_exception, exception_print)
4552         (exception_fprintf, exception_print_same): Change parameters to
4553         const reference.
4554         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4555         * common/new-op.c: Use std::move.
4556         * common/common-exceptions.h (struct gdb_exception): Add move
4557         constructor.
4558         (struct gdb_exception_error, struct gdb_exception_quit, struct
4559         gdb_quit_bad_alloc): Change constructor to move constructor.
4560         (throw_exception): Change parameter to rvalue reference.
4561         * common/common-exceptions.c (throw_exception): Take rvalue
4562         reference.
4563         * cli/cli-interp.c (safe_execute_command): Use std::move.
4564         * breakpoint.c (insert_bp_location, location_to_sals): Use
4565         std::move.
4566
4567 2019-04-25  Tom Tromey  <tromey@adacore.com>
4568
4569         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4570         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4571         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4572         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4573         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4574         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4575         guile/scm-value.c: Use unpack.
4576         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4577         gdbscm_gdb_exception.
4578         (gdbscm_throw_gdb_exception): Likewise.
4579         (struct gdbscm_gdb_exception): New.
4580         (unpack): New function.
4581         (gdbscm_wrap): Use unpack.
4582
4583 2019-04-25  Tom Tromey  <tromey@adacore.com>
4584
4585         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4586         (gdb_rl_callback_handler): Use std::move.
4587         * common/common-exceptions.h (struct gdb_exception): Add move
4588         assignment operator.
4589         (throw_exception_sjlj): Change "exception" to const reference.
4590         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4591         (throw_exception_sjlj): Change "exception" to const reference.
4592
4593 2019-04-25  Tom Tromey  <tromey@adacore.com>
4594
4595         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4596         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4597         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4598         Update.
4599         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4600         Update.
4601         * mi/mi-interp.c (mi_interp::exec): Update.
4602         * linespec.c (parse_linespec): Update.
4603         * infcall.c (run_inferior_call): Update.
4604         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4605         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4606         (gdbscm_lookup_global_symbol): Update.
4607         * guile/scm-param.c (gdbscm_parameter_value): Update.
4608         * guile/scm-frame.c (gdbscm_frame_read_register)
4609         (gdbscm_frame_read_var): Update.
4610         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4611         * exec.c (try_open_exec_file): Update.
4612         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4613         (gdb_rl_callback_handler): Update.
4614         * common/common-exceptions.h (exception_none): Don't declare.
4615         * common/common-exceptions.c (exception_none): Don't define.
4616         (struct catcher) <exception>: Update.
4617         * cli/cli-interp.c (safe_execute_command): Update.
4618         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4619
4620 2019-04-25  Ali Tamur  <tamur@google.com>
4621
4622         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4623         (read_attribute_value): Likewise.
4624         (dwarf2_read_addr_index): Update comment.
4625         (read_str_index): Add DW_FORM_strx.
4626         (dwarf2_string_attr): Likewise.
4627         (dwarf2_const_value_attr): Likewise.
4628         (dump_die_shallow): Likewise.
4629         (dwarf2_fetch_constant_bytes): Likewise.
4630         (skip_form_bytes): Likewise.
4631         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4632
4633 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4634
4635         PR corefiles/11608
4636         PR corefiles/18187
4637         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4638         OFFSET.  Verify if current mapping contains an ELF header.
4639         (linux_find_memory_regions_full): Adjust call to
4640         dump_mapping_p.
4641
4642 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4643             Kang Li <kanglictf@gmail.com>
4644
4645         PR gdb/21600
4646
4647         * dwarf2-frame.c (read_initial_length): Be consistent about using
4648         unsigned representation of length.
4649         (decode_frame_entry_1): Likewise.  Check for wraparound of
4650         end pointer as well as buffer overflow.
4651
4652 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4653
4654         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4655         "vq".
4656
4657 2019-04-24  Tom Tromey  <tromey@adacore.com>
4658
4659         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4660
4661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4662
4663         * s12z-tdep.c (s12z_unwind_pc): Delete.
4664         (s12z_unwind_sp): Delete.
4665         (s12z_gdbarch_init): Don't register deleted functions with
4666         gdbarch.
4667
4668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4669
4670         * rl78-tdep.c (rl78_unwind_sp): Delete.
4671         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4672
4673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4676         (xstormy16_unwind_pc): Delete.
4677         (xstormy16_dummy_id): Delete.
4678         (xstormy16_gdbarch_init): Don't register deleted functions with
4679         gdbarch.
4680
4681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * vax-tdep.c (vax_unwind_pc): Delete.
4684         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4685
4686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * v850-tdep.c (v850_unwind_sp): Delete.
4689         (v850_unwind_pc): Delete.
4690         (v850_dummy_id): Delete.
4691         (v850_gdbarch_init): Don't register deleted functions with
4692         gdbarch.
4693
4694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4695
4696         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4697         (tilegx_unwind_pc): Delete.
4698         (tilegx_unwind_dummy_id): Delete.
4699         (tilegx_gdbarch_init): Don't register deleted functions with
4700         gdbarch.
4701
4702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4703
4704         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4705         (tic6x_dummy_id): Delete.
4706         (tic6x_gdbarch_init): Don't register deleted functions with
4707         gdbarch.
4708
4709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4710
4711         * sparc-tdep.c (sparc_unwind_pc): Delete.
4712         (sparc32_gdbarch_init): Don't register deleted function with
4713         gdbarch.
4714
4715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         * sh-tdep.c (sh_unwind_sp): Delete.
4718         (sh_unwind_pc): Delete.
4719         (sh_dummy_id): Delete.
4720         (sh_gdbarch_init): Don't register deleted functions with
4721         gdbarch.
4722
4723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * score-tdep.c (score_unwind_sp): Delete.
4726         (score_unwind_pc): Delete.
4727         (score_dummy_id): Delete.
4728         (score_gdbarch_init): Don't register deleted functions with
4729         gdbarch.
4730
4731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4732
4733         * rx-tdep.c (rx_unwind_pc): Delete.
4734         (rx_unwind_sp): Delete.
4735         (rx_dummy_id): Delete.
4736         (rx_gdbarch_init): Don't register deleted functions with
4737         gdbarch.  Update comment.
4738
4739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4740
4741         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4742         (rs6000_dummy_id): Delete.
4743         (rs6000_gdbarch_init): Don't register deleted functions with
4744         gdbarch.
4745
4746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4747
4748         * or1k-tdep.c (or1k_dummy_id): Delete.
4749         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4750
4751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * nios2-tdep.c (nios2_dummy_id): Delete.
4754         (nios2_unwind_sp): Delete.
4755         (nios2_gdbarch_init): Don't register deleted functions with
4756         gdbarch.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * nds32-tdep.c (nds32_dummy_id): Delete.
4761         (nds32_unwind_pc): Delete.
4762         (nds32_unwind_sp): Delete.
4763         (nds32_gdbarch_init): Don't register deleted functions with
4764         gdbarch.
4765
4766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * msp430-tdep.c (msp430_unwind_pc): Delete.
4769         (msp430_unwind_sp): Delete.
4770         (msp430_dummy_id): Delete.
4771         (msp430_gdbarch_init): Don't register deleted functions with
4772         gdbarch.
4773
4774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * moxie-tdep.c (moxie_unwind_sp): Delete.
4777         (moxie_unwind_pc): Delete.
4778         (moxie_dummy_id): Delete.
4779         (moxie_gdbarch_init): Don't register deleted functions with
4780         gdbarch.
4781
4782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4785         (mn10300_unwind_pc): Delete.
4786         (mn10300_unwind_sp): Delete.
4787         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4788         mn10300_unwind_sp.
4789         (mn10300_frame_unwind_init): Don't register deleted functions with
4790         gdbarch.
4791
4792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4793
4794         * mep-tdep.c (mep_unwind_pc): Delete.
4795         (mep_unwind_sp): Delete.
4796         (mep_dummy_id): Delete.
4797         (mep_gdbarch_init): Don't register deleted functions with
4798         gdbarch.
4799
4800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4803         (m68hc11_unwind_sp): Delete.
4804         (m68hc11_gdbarch_init): Don't register deleted functions with
4805         gdbarch.
4806
4807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * m32r-tdep.c (m32r_unwind_sp): Delete.
4810         (m32r_unwind_pc): Delete.
4811         (m32r_dummy_id): Delete.
4812         (m32r_gdbarch_init): Don't register deleted functions with
4813         gdbarch.
4814
4815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * m32c-tdep.c (m32c_unwind_pc): Delete.
4818         (m32c_unwind_sp): Delete.
4819         (m32c_dummy_id): Delete.
4820         (m32c_gdbarch_init): Don't register deleted functions with
4821         gdbarch.
4822
4823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4826         (lm32_unwind_pc): Delete.
4827         (lm32_dummy_id): Delete.
4828         (lm32_gdbarch_init): Don't register deleted functions with
4829         gdbarch.
4830
4831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4834         (iq2000_unwind_pc): Delete.
4835         (iq2000_dummy_id): Delete.
4836         (iq2000_gdbarch_init): Don't register deleted functions with
4837         gdbarch.
4838
4839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * nds32-tdep.c (nds32_type_align): Delete.
4842         (nds32_push_dummy_call): Use type_align instead.
4843
4844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * arm-tdep.c (arm_type_align): Only handle vector override case.
4847         (arm_push_dummy_call): Use type_align.
4848         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4849
4850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4853         case.
4854         (pass_on_stack): Use type_align.
4855         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4856         function.
4857
4858 2019-04-23  Tom Tromey  <tromey@adacore.com>
4859
4860         * dwarf2read.c (line_header::file_name_at): Remove unused
4861         overload.
4862
4863 2019-04-23  Tom de Vries  <tdevries@suse.de>
4864
4865         PR gdb/24438
4866         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4867         invocation.
4868
4869
4870 2019-03-27  Ali Tamur  <tamur@google.com>
4871
4872         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4873         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4874         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4875         (dwarf_expr_context::get_addr_index): Likewise
4876         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4877         (symbol_needs_eval_context::get_addr_index): Likewise
4878         (disassemble_dwarf_expression): Add DW_OP_addrx
4879         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4880         (read_cutu_die_from_dwo): Update comment
4881         (skip_one_die): Add DW_FORM_addrx
4882         (read_attribute_value): Likewise
4883         (var_decode_location): Add DW_OP_addrx
4884         (dwarf2_const_value_attr): Add DW_FORM_addrx
4885         (dump_die_shallow): Likewise
4886         (dwarf2_fetch_constant_bytes): Likewise
4887         (decode_locdesc): Add DW_OP_addrx
4888         (skip_form_bytes): Add DW_FORM_addrx
4889
4890 2019-04-22  Ali Tamur  <tamur@google.com>
4891
4892         * MAINTAINERS (Write After Approval): Add self.
4893
4894 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4895
4896         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4897         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4898         (open_symbol_file_object): Likewise.
4899         (svr4_default_sos): Add info parameter.
4900         (svr4_read_so_list): Likewise.
4901         (svr4_current_sos_direct): Adjust functions calls to pass down
4902         info.
4903         (svr4_current_sos_1): Add info parameter.
4904         (svr4_current_sos): Call get_svr4_info, pass info down to
4905         svr4_current_sos_1.
4906         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4907         get_svr4_info.
4908         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4909         get_svr4_info.
4910         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4911         to get_svr4_info.
4912         (probes_table_remove_objfile_probes): Likewise.
4913         (register_solib_event_probe): Add info parameter.
4914         (solist_update_incremental): Pass info parameter down to
4915         svr4_read_so_list.
4916         (disable_probes_interface): Add info parameter.
4917         (svr4_handle_solib_event): Pass current_program_space to
4918         get_svr4_info.  Adjust disable_probes_interface cleanup.
4919         (svr4_create_probe_breakpoints): Add info parameter, pass it
4920         down to register_solib_event_probe.
4921         (svr4_create_solib_event_breakpoints): Add info parameter,
4922         pass it down to svr4_create_probe_breakpoints.
4923         (enable_break): Pass info down to
4924         svr4_create_solib_event_breakpoints.
4925         (svr4_solib_create_inferior_hook): Pass current_program_space to
4926         get_svr4_info.
4927         (svr4_clear_solib): Likewise.
4928
4929 2019-04-22  Pedro Alves  <palves@redhat.com>
4930
4931         * solib-svr4.c (svr4_free_objfile_observer): New.
4932         (probe_and_action::objfile): New field.
4933         (probes_table_htab_remove_objfile_probes)
4934         (probes_table_remove_objfile_probes): New functions.
4935         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4936         in the new probe_and_action.  Don't store the probe in 'lookup'.
4937         (svr4_create_probe_breakpoints): Pass objfile to
4938         register_solib_event_probe.
4939         (_initialize_svr4_solib): Register a free_objfile observer.
4940
4941 2019-04-19  Tom Tromey  <tom@tromey.com>
4942
4943         * common/queue.h: Remove.
4944
4945 2019-04-19  Tom Tromey  <tom@tromey.com>
4946
4947         * event-loop.c: Don't include "common/queue.h".
4948
4949 2019-04-19  Tom Tromey  <tom@tromey.com>
4950
4951         * remote.c (remote_target): Use delete.
4952         * remote-notif.h: Include <list>, not "common/queue.h".
4953         (notif_client_p): Remove typedef.
4954         (remote_notif_state): Add constructor, destructor, initializer.
4955         <notif_queue>: Now a std::list.
4956         (remote_notif_state_xfree): Don't declare.
4957         * remote-notif.c (remote_notif_process, handle_notification)
4958         (remote_notif_state_allocate): Update.
4959         (~remote_notif_state): Rename from remote_notif_state_xfree.
4960
4961 2019-04-19  Tom Tromey  <tom@tromey.com>
4962
4963         * symfile.c (reread_symbols): Update.
4964         * objfiles.c (objfile_register_static_link)
4965         (objfile_lookup_static_link): Update
4966         (~objfile) Don't delete static_links.
4967         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4968
4969 2019-04-19  Tom Tromey  <tom@tromey.com>
4970
4971         * type-stack.h (struct type_stack) <insert>: Constify string.
4972         * type-stack.c (type_stack::insert): Constify string.
4973         * gdbtypes.h (lookup_template_type): Update.
4974         (address_space_name_to_int): Update.
4975         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4976         const.
4977         (lookup_template_type): Make name const.
4978         * c-exp.y: Update rules.
4979         (lex_one_token, classify_name, classify_inner_name)
4980         (c_print_token): Update.
4981         * p-exp.y: Update rules.
4982         (yylex): Update.
4983         * f-exp.y: Update rules.
4984         (yylex): Update.
4985         * d-exp.y: Update rules.
4986         (lex_one_token, classify_name, classify_inner_name): Update.
4987         * parse.c (write_dollar_variable, copy_name): Return std::string.
4988         * parser-defs.h (copy_name): Change return type.
4989         * m2-exp.y: Update rules.
4990         (yylex): Update.
4991         * go-exp.y (lex_one_token): Update.
4992         Update rules.
4993         (classify_unsafe_function, classify_packaged_name)
4994         (classify_name, yylex): Update.
4995
4996 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4997
4998         * configure.ac: add --enable-source-highlight switch.
4999         * configure: Regenerate.
5000         * top.c (print_gdb_version): plumb --enable-source-highlight
5001         status to "show configuration".
5002
5003 2019-04-19  Tom Tromey  <tromey@adacore.com>
5004
5005         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5006         Check ADA_TYPE_P.
5007         (empty_record, ada_template_to_fixed_record_type_1)
5008         (template_to_static_fixed_type)
5009         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5010         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5011         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5012         macros.
5013
5014 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5015
5016         PR symtab/24423:
5017         * source.c (print_source_lines_base): Advance "iter" when a
5018         control character is seen.
5019
5020 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5021
5022         * inferior.h (struct infcall_suspend_state_deleter):
5023         Catch exception in destructor to avoid crash.
5024
5025 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026
5027         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5028         close to the add_com "shell".
5029
5030 2019-04-18  Tom Tromey  <tromey@adacore.com>
5031
5032         * process-stratum-target.h (class process_stratum_target)
5033         <stratum>: Add "final".
5034
5035 2019-04-17  Tom Tromey  <tromey@adacore.com>
5036
5037         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5038         against nullptr before use.
5039
5040 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5041
5042         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5043
5044 2019-04-17  Jim Wilson  <jimw@sifive.com>
5045             Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5048         code read might fail, assume 4-byte breakpoint in that case.
5049
5050 2019-04-15  Leszek Swirski  <leszeks@google.com>
5051
5052         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5053         rather than a hand-rolled POD check when checking for forced MEMORY
5054         classification.
5055
5056 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5057
5058         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5059         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5060         function.
5061         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5062         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5063         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5064         declaration.
5065
5066 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5067
5068         * aarch64-linux-nat.c
5069         (aarch64_linux_nat_target::thread_architecture): Add override.
5070         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5071         each VQ.
5072
5073 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5076
5077 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5080         target types of size 96-bits, add some additional comments, and
5081         check that the builtin type we found was the correct size.
5082
5083 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5084
5085         * utils.c (prompt_for_continue): Don't restore the styling at the
5086         end, as applied_style has the wrong value.  This fixes styling in
5087         long lists of file names that are interrupted by the "Continue?"
5088         prompt.
5089
5090 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5093         * c-lang.c (c_language_defn): Likewise.
5094         (cplus_language_defn): Likewise.
5095         (asm_language_defn): Likewise.
5096         (minimal_language_defn): Likewise.
5097         * d-lang.c (d_language_defn): Likewise.
5098         * f-lang.c (f_language_defn): Likewise.
5099         * go-lang.c (go_language_defn): Likewise.
5100         * language.c (unknown_language_defn): Likewise.
5101         (auto_language_defn): Likewise.
5102         * language.h (struct language_defn): Remove la_magic field.
5103         (LANG_MAGIC): Delete.
5104         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5105         * objc-lang.c (objc_language_defn): Likewise.
5106         * opencl-lang.c (opencl_language_defn): Likewise.
5107         * p-lang.c (pascal_language_defn): Likewise.
5108         * rust-lang.c (rust_language_defn): Likewise.
5109
5110 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * riscv-tdep.c (riscv_type_align): New function.
5113         (riscv_type_alignment): Delete.
5114         (riscv_arg_location): Use 'type_align'.
5115         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5116
5117 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * gdbtypes.c (type_align): A struct with no non-static fields also
5120         has alignment of 1.
5121
5122 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5123
5124         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5125         component to 0.
5126         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5127         member.
5128         (riscv_struct_info::analyse): New implementation using new
5129         analyse_inner member function.
5130         (riscv_struct_info::field_offset): New member function.
5131         (riscv_struct_info::m_offsets): New member variable.
5132         (riscv_struct_info::analyse_inner): New private member function,
5133         takes the old implementation of riscv_struct_info::analyse but
5134         extended to track field offsets.
5135         (riscv_call_arg_struct): Update the struct folding special cases
5136         to handle cases where empty C++ structs, which are non-zero
5137         length, are found.
5138         (riscv_arg_location): Initialise the length of each location, a
5139         non-zero length now indicates the location is in use.
5140         (riscv_push_dummy_call): Allow for the first location having a
5141         non-zero offset when setting up arguments.
5142         (riscv_return_value): Likewise, but for return values.
5143
5144 2019-04-11  Tom Tromey  <tromey@adacore.com>
5145
5146         * utils.c (internal_vproblem): Make "msg" const.
5147
5148 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5149
5150         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5151         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5152         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5153         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5154
5155 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5156
5157         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5158         function.
5159         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5160         of amd64_collect_native_gregset.
5161         (amd64_linux_nat_target::store_registers): Likewise.
5162
5163 2019-04-10  Tom Tromey  <tom@tromey.com>
5164
5165         * symtab.c (lookup_global_symbol_from_objfile)
5166         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5167         * objfiles.h (class separate_debug_iterator): New.
5168         (class separate_debug_range): New.
5169         (struct objfile) <separate_debug_objfiles>: New method.
5170         (objfile_separate_debug_iterate): Don't declare.
5171         * objfiles.c (separate_debug_iterator::operator++): Rename from
5172         objfile_separate_debug_iterate.
5173         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5174         iterator.
5175         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5176         iterator.
5177
5178 2019-04-10  Tom Tromey  <tom@tromey.com>
5179
5180         * symfile.c (reread_symbols): Remove old comment.
5181         * objfiles.c (free_all_objfiles): Fix a typo.
5182
5183 2019-04-10  Tom Tromey  <tom@tromey.com>
5184
5185         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5186         * minsyms.c (lookup_minimal_symbol): Use foreach.
5187         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5188         (lookup_minimal_symbol_solib_trampoline): Likewise.
5189         * symfile.c (reread_symbols): Use foreach.
5190
5191 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5192             Tom Tromey  <tromey@adacore.com>
5193
5194         PR rust/24414:
5195         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5196         (rust_lex_int_test): Change "value" to be LONGEST.
5197         (rust_lex_tests): Add test for long integer literal.
5198
5199 2019-04-09  Tom Tromey  <tromey@adacore.com>
5200
5201         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5202         to bool.
5203         (extended_remote_target::attach): Update.
5204         (remote_target::remote_notice_new_inferior): Update.
5205         (remote_target::add_current_inferior_and_thread): Update.
5206         * inferior.c (exit_inferior_1): Use "false".
5207         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5208
5209 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5210
5211         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5212         the "start" command.
5213
5214 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5215
5216         * python/py-inferior.c (infpy_thread_from_thread_handle):
5217         Adjust comments to reflect renaming of thread_from_thread_handle
5218         to thread_from_handle.  Adjust keywords.  Fix type error message.
5219         (inferior_object_methods): Add thread_from_handle.  Retain
5220         thread_from_thread_handle, but mark it as deprecated.
5221
5222 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5223
5224         * gdbthread.h (find_thread_by_handle): Revise declaration.
5225         * thread.c (find_thread_by_handle): Likewise.  Adjust
5226         implementation too.
5227         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5228         support for buffer objects as handles.
5229
5230 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5231
5232         * python/py-infthread.c (thpy_thread_handle): New function.
5233         (thread_object_methods): Register thpy_thread_handle.
5234
5235 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5236
5237         * gdbthread.h (thread_to_thread_handle): Declare.
5238         * thread.c (gdbtypes.h): Include.
5239         (thread_to_thread_handle): New function.
5240
5241         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5242         (target_thread_info_to_thread_handle): Declare.
5243         * target.c (target_thread_info_to_thread_handle): New function.
5244         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5245         * target-delegates.c: Regenerate.
5246
5247         * linux-thread-db.c (class thread_db_target): Add method
5248         thread_info_to_thread_handle.
5249         (thread_db_target::thread_info_to_thread_handle): Define.
5250         * remote.c (class remote_target): Add new method
5251         thread_info_to_thread_handle.
5252         (remote_target::thread_info_to_thread_handle): Define.
5253
5254 2019-04-08  Pedro Alves  <palves@redhat.com>
5255
5256         * common/common-exceptions.c (throw_exception): Don't create
5257         named object to throw; throw directly.
5258         (throw_it): Likewise.  Don't initialize gdb_exception::message
5259         here, with new; pass FMT and AP to the ctor instead.
5260         * common/common-exceptions.h: Include <string>.
5261         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5262         const char *, va_list)): New ctor.  Use std::make_shared.
5263         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5264         errors)): Delete.
5265         (gdb_exception_error::gdb_exception_error(enum errors, const char
5266         *, va_list)): New.
5267         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5268         Add assertion.
5269         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5270         errors)): Delete.
5271         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5272         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5273         Add assertion.
5274
5275 2019-04-08  Tom Tromey  <tom@tromey.com>
5276
5277         * valops.c (value_rtti_indirect_type): Replace throw_exception
5278         with throw.
5279         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5280         with throw.
5281         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5282         throw.
5283         * target.c (target_translate_tls_address): Replace throw_exception
5284         with throw.
5285         * stack.c (frame_apply_command_count): Replace throw_exception
5286         with throw.
5287         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5288         throw.
5289         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5290         with throw.
5291         * rs6000-tdep.c (rs6000_frame_cache)
5292         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5293         * remote.c: Replace throw_exception with throw.
5294         * record-full.c (record_full_message, record_full_wait_1)
5295         (record_full_restore): Replace throw_exception with throw.
5296         * record-btrace.c:
5297         (get_thread_current_frame_id, record_btrace_start_replaying)
5298         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5299         (cmd_record_btrace_start): Replace throw_exception with throw.
5300         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5301         throw.
5302         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5303         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5304         * linespec.c:
5305         (find_linespec_symbols): Replace throw_exception with throw.
5306         * infrun.c (displaced_step_prepare, resume): Replace
5307         throw_exception with throw.
5308         * infcmd.c (post_create_inferior): Replace throw_exception with
5309         throw.
5310         * inf-loop.c (inferior_event_handler): Replace throw_exception
5311         with throw.
5312         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5313         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5314         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5315         (get_prev_frame_always, get_frame_pc_if_available)
5316         (get_frame_address_in_block_if_available, get_frame_language):
5317         Replace throw_exception with throw.
5318         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5319         throw_exception with throw.
5320         * eval.c (fetch_subexp_value, evaluate_var_value)
5321         (evaluate_funcall, evaluate_subexp_standard): Replace
5322         throw_exception with throw.
5323         * dwarf2loc.c (call_site_find_chain)
5324         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5325         Replace throw_exception with throw.
5326         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5327         with throw.
5328         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5329         throw.
5330         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5331         * completer.c (complete_line_internal): Replace throw_exception
5332         with throw.
5333         * compile/compile-object-run.c (compile_object_run): Replace
5334         throw_exception with throw.
5335         * cli/cli-script.c (process_next_line): Replace throw_exception
5336         with throw.
5337         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5338         (btrace_enable, btrace_maint_update_pt_packets): Replace
5339         throw_exception with throw.
5340         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5341         throw_exception with throw.
5342         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5343         throw_exception with throw.
5344         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5345         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5346         * aarch64-tdep.c (aarch64_make_prologue_cache)
5347         (aarch64_make_stub_cache): Replace throw_exception with throw.
5348
5349 2019-04-08  Tom Tromey  <tom@tromey.com>
5350
5351         * common/common-exceptions.c (throw_exception): Rename from
5352         throw_exception_cxx.  Remove old copy.  Make argument const.
5353         (throw_it): Create and throw exception objects directly.
5354         * common/common-exceptions.h (throw_exception): Make argument
5355         const.
5356         (struct gdb_exception_error): Add constructor.
5357         (struct gdb_exception_quit): Add constructor.
5358
5359 2019-04-08  Tom Tromey  <tom@tromey.com>
5360
5361         * common/common-exceptions.h (exception_rethrow): Don't declare.
5362         (TRY_SJLJ): Update comment.
5363         (TRY, CATCH, END_CATCH): Remove.
5364         * common/common-exceptions.c (exception_rethrow): Remove.
5365
5366 2019-04-08  Tom Tromey  <tom@tromey.com>
5367
5368         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5369         Remove.
5370         (gdb_exception_error): Rename from
5371         gdb_exception_RETURN_MASK_ERROR.
5372         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5373         (gdb_quit_bad_alloc): Update.
5374         * aarch64-tdep.c: Update.
5375         * ada-lang.c: Update.
5376         * ada-typeprint.c: Update.
5377         * ada-valprint.c: Update.
5378         * amd64-tdep.c: Update.
5379         * arch-utils.c: Update.
5380         * break-catch-throw.c: Update.
5381         * breakpoint.c: Update.
5382         * btrace.c: Update.
5383         * c-varobj.c: Update.
5384         * cli/cli-cmds.c: Update.
5385         * cli/cli-interp.c: Update.
5386         * cli/cli-script.c: Update.
5387         * common/common-exceptions.c: Update.
5388         * common/new-op.c: Update.
5389         * common/selftest.c: Update.
5390         * compile/compile-c-symbols.c: Update.
5391         * compile/compile-cplus-symbols.c: Update.
5392         * compile/compile-object-load.c: Update.
5393         * compile/compile-object-run.c: Update.
5394         * completer.c: Update.
5395         * corelow.c: Update.
5396         * cp-abi.c: Update.
5397         * cp-support.c: Update.
5398         * cp-valprint.c: Update.
5399         * darwin-nat.c: Update.
5400         * disasm-selftests.c: Update.
5401         * dtrace-probe.c: Update.
5402         * dwarf-index-cache.c: Update.
5403         * dwarf-index-write.c: Update.
5404         * dwarf2-frame-tailcall.c: Update.
5405         * dwarf2-frame.c: Update.
5406         * dwarf2loc.c: Update.
5407         * dwarf2read.c: Update.
5408         * eval.c: Update.
5409         * event-loop.c: Update.
5410         * event-top.c: Update.
5411         * exec.c: Update.
5412         * f-valprint.c: Update.
5413         * fbsd-tdep.c: Update.
5414         * frame-unwind.c: Update.
5415         * frame.c: Update.
5416         * gdbtypes.c: Update.
5417         * gnu-v3-abi.c: Update.
5418         * guile/guile-internal.h: Update.
5419         * guile/scm-block.c: Update.
5420         * guile/scm-breakpoint.c: Update.
5421         * guile/scm-cmd.c: Update.
5422         * guile/scm-disasm.c: Update.
5423         * guile/scm-frame.c: Update.
5424         * guile/scm-lazy-string.c: Update.
5425         * guile/scm-math.c: Update.
5426         * guile/scm-param.c: Update.
5427         * guile/scm-ports.c: Update.
5428         * guile/scm-pretty-print.c: Update.
5429         * guile/scm-symbol.c: Update.
5430         * guile/scm-symtab.c: Update.
5431         * guile/scm-type.c: Update.
5432         * guile/scm-value.c: Update.
5433         * i386-linux-tdep.c: Update.
5434         * i386-tdep.c: Update.
5435         * inf-loop.c: Update.
5436         * infcall.c: Update.
5437         * infcmd.c: Update.
5438         * infrun.c: Update.
5439         * jit.c: Update.
5440         * language.c: Update.
5441         * linespec.c: Update.
5442         * linux-fork.c: Update.
5443         * linux-nat.c: Update.
5444         * linux-tdep.c: Update.
5445         * linux-thread-db.c: Update.
5446         * main.c: Update.
5447         * mi/mi-cmd-break.c: Update.
5448         * mi/mi-cmd-stack.c: Update.
5449         * mi/mi-interp.c: Update.
5450         * mi/mi-main.c: Update.
5451         * objc-lang.c: Update.
5452         * p-valprint.c: Update.
5453         * parse.c: Update.
5454         * ppc-linux-tdep.c: Update.
5455         * printcmd.c: Update.
5456         * python/py-arch.c: Update.
5457         * python/py-breakpoint.c: Update.
5458         * python/py-cmd.c: Update.
5459         * python/py-finishbreakpoint.c: Update.
5460         * python/py-frame.c: Update.
5461         * python/py-framefilter.c: Update.
5462         * python/py-gdb-readline.c: Update.
5463         * python/py-inferior.c: Update.
5464         * python/py-infthread.c: Update.
5465         * python/py-lazy-string.c: Update.
5466         * python/py-linetable.c: Update.
5467         * python/py-objfile.c: Update.
5468         * python/py-param.c: Update.
5469         * python/py-prettyprint.c: Update.
5470         * python/py-progspace.c: Update.
5471         * python/py-record-btrace.c: Update.
5472         * python/py-record.c: Update.
5473         * python/py-symbol.c: Update.
5474         * python/py-type.c: Update.
5475         * python/py-unwind.c: Update.
5476         * python/py-utils.c: Update.
5477         * python/py-value.c: Update.
5478         * python/python.c: Update.
5479         * record-btrace.c: Update.
5480         * record-full.c: Update.
5481         * remote-fileio.c: Update.
5482         * remote.c: Update.
5483         * riscv-tdep.c: Update.
5484         * rs6000-aix-tdep.c: Update.
5485         * rs6000-tdep.c: Update.
5486         * rust-exp.y: Update.
5487         * rust-lang.c: Update.
5488         * s390-tdep.c: Update.
5489         * selftest-arch.c: Update.
5490         * solib-dsbt.c: Update.
5491         * solib-frv.c: Update.
5492         * solib-spu.c: Update.
5493         * solib-svr4.c: Update.
5494         * solib.c: Update.
5495         * sparc64-linux-tdep.c: Update.
5496         * stack.c: Update.
5497         * symfile-mem.c: Update.
5498         * symmisc.c: Update.
5499         * target.c: Update.
5500         * thread.c: Update.
5501         * top.c: Update.
5502         * tracefile-tfile.c: Update.
5503         * tui/tui.c: Update.
5504         * typeprint.c: Update.
5505         * unittests/cli-utils-selftests.c: Update.
5506         * unittests/parse-connection-spec-selftests.c: Update.
5507         * valops.c: Update.
5508         * valprint.c: Update.
5509         * value.c: Update.
5510         * varobj.c: Update.
5511         * windows-nat.c: Update.
5512         * x86-linux-nat.c: Update.
5513         * xml-support.c: Update.
5514
5515 2019-04-08  Tom Tromey  <tom@tromey.com>
5516
5517         * xml-support.c: Use C++ exception handling.
5518         * x86-linux-nat.c: Use C++ exception handling.
5519         * windows-nat.c: Use C++ exception handling.
5520         * varobj.c: Use C++ exception handling.
5521         * value.c: Use C++ exception handling.
5522         * valprint.c: Use C++ exception handling.
5523         * valops.c: Use C++ exception handling.
5524         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5525         handling.
5526         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5527         * typeprint.c: Use C++ exception handling.
5528         * tui/tui.c: Use C++ exception handling.
5529         * tracefile-tfile.c: Use C++ exception handling.
5530         * top.c: Use C++ exception handling.
5531         * thread.c: Use C++ exception handling.
5532         * target.c: Use C++ exception handling.
5533         * symmisc.c: Use C++ exception handling.
5534         * symfile-mem.c: Use C++ exception handling.
5535         * stack.c: Use C++ exception handling.
5536         * sparc64-linux-tdep.c: Use C++ exception handling.
5537         * solib.c: Use C++ exception handling.
5538         * solib-svr4.c: Use C++ exception handling.
5539         * solib-spu.c: Use C++ exception handling.
5540         * solib-frv.c: Use C++ exception handling.
5541         * solib-dsbt.c: Use C++ exception handling.
5542         * selftest-arch.c: Use C++ exception handling.
5543         * s390-tdep.c: Use C++ exception handling.
5544         * rust-lang.c: Use C++ exception handling.
5545         * rust-exp.y: Use C++ exception handling.
5546         * rs6000-tdep.c: Use C++ exception handling.
5547         * rs6000-aix-tdep.c: Use C++ exception handling.
5548         * riscv-tdep.c: Use C++ exception handling.
5549         * remote.c: Use C++ exception handling.
5550         * remote-fileio.c: Use C++ exception handling.
5551         * record-full.c: Use C++ exception handling.
5552         * record-btrace.c: Use C++ exception handling.
5553         * python/python.c: Use C++ exception handling.
5554         * python/py-value.c: Use C++ exception handling.
5555         * python/py-utils.c: Use C++ exception handling.
5556         * python/py-unwind.c: Use C++ exception handling.
5557         * python/py-type.c: Use C++ exception handling.
5558         * python/py-symbol.c: Use C++ exception handling.
5559         * python/py-record.c: Use C++ exception handling.
5560         * python/py-record-btrace.c: Use C++ exception handling.
5561         * python/py-progspace.c: Use C++ exception handling.
5562         * python/py-prettyprint.c: Use C++ exception handling.
5563         * python/py-param.c: Use C++ exception handling.
5564         * python/py-objfile.c: Use C++ exception handling.
5565         * python/py-linetable.c: Use C++ exception handling.
5566         * python/py-lazy-string.c: Use C++ exception handling.
5567         * python/py-infthread.c: Use C++ exception handling.
5568         * python/py-inferior.c: Use C++ exception handling.
5569         * python/py-gdb-readline.c: Use C++ exception handling.
5570         * python/py-framefilter.c: Use C++ exception handling.
5571         * python/py-frame.c: Use C++ exception handling.
5572         * python/py-finishbreakpoint.c: Use C++ exception handling.
5573         * python/py-cmd.c: Use C++ exception handling.
5574         * python/py-breakpoint.c: Use C++ exception handling.
5575         * python/py-arch.c: Use C++ exception handling.
5576         * printcmd.c: Use C++ exception handling.
5577         * ppc-linux-tdep.c: Use C++ exception handling.
5578         * parse.c: Use C++ exception handling.
5579         * p-valprint.c: Use C++ exception handling.
5580         * objc-lang.c: Use C++ exception handling.
5581         * mi/mi-main.c: Use C++ exception handling.
5582         * mi/mi-interp.c: Use C++ exception handling.
5583         * mi/mi-cmd-stack.c: Use C++ exception handling.
5584         * mi/mi-cmd-break.c: Use C++ exception handling.
5585         * main.c: Use C++ exception handling.
5586         * linux-thread-db.c: Use C++ exception handling.
5587         * linux-tdep.c: Use C++ exception handling.
5588         * linux-nat.c: Use C++ exception handling.
5589         * linux-fork.c: Use C++ exception handling.
5590         * linespec.c: Use C++ exception handling.
5591         * language.c: Use C++ exception handling.
5592         * jit.c: Use C++ exception handling.
5593         * infrun.c: Use C++ exception handling.
5594         * infcmd.c: Use C++ exception handling.
5595         * infcall.c: Use C++ exception handling.
5596         * inf-loop.c: Use C++ exception handling.
5597         * i386-tdep.c: Use C++ exception handling.
5598         * i386-linux-tdep.c: Use C++ exception handling.
5599         * guile/scm-value.c: Use C++ exception handling.
5600         * guile/scm-type.c: Use C++ exception handling.
5601         * guile/scm-symtab.c: Use C++ exception handling.
5602         * guile/scm-symbol.c: Use C++ exception handling.
5603         * guile/scm-pretty-print.c: Use C++ exception handling.
5604         * guile/scm-ports.c: Use C++ exception handling.
5605         * guile/scm-param.c: Use C++ exception handling.
5606         * guile/scm-math.c: Use C++ exception handling.
5607         * guile/scm-lazy-string.c: Use C++ exception handling.
5608         * guile/scm-frame.c: Use C++ exception handling.
5609         * guile/scm-disasm.c: Use C++ exception handling.
5610         * guile/scm-cmd.c: Use C++ exception handling.
5611         * guile/scm-breakpoint.c: Use C++ exception handling.
5612         * guile/scm-block.c: Use C++ exception handling.
5613         * guile/guile-internal.h: Use C++ exception handling.
5614         * gnu-v3-abi.c: Use C++ exception handling.
5615         * gdbtypes.c: Use C++ exception handling.
5616         * frame.c: Use C++ exception handling.
5617         * frame-unwind.c: Use C++ exception handling.
5618         * fbsd-tdep.c: Use C++ exception handling.
5619         * f-valprint.c: Use C++ exception handling.
5620         * exec.c: Use C++ exception handling.
5621         * event-top.c: Use C++ exception handling.
5622         * event-loop.c: Use C++ exception handling.
5623         * eval.c: Use C++ exception handling.
5624         * dwarf2read.c: Use C++ exception handling.
5625         * dwarf2loc.c: Use C++ exception handling.
5626         * dwarf2-frame.c: Use C++ exception handling.
5627         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5628         * dwarf-index-write.c: Use C++ exception handling.
5629         * dwarf-index-cache.c: Use C++ exception handling.
5630         * dtrace-probe.c: Use C++ exception handling.
5631         * disasm-selftests.c: Use C++ exception handling.
5632         * darwin-nat.c: Use C++ exception handling.
5633         * cp-valprint.c: Use C++ exception handling.
5634         * cp-support.c: Use C++ exception handling.
5635         * cp-abi.c: Use C++ exception handling.
5636         * corelow.c: Use C++ exception handling.
5637         * completer.c: Use C++ exception handling.
5638         * compile/compile-object-run.c: Use C++ exception handling.
5639         * compile/compile-object-load.c: Use C++ exception handling.
5640         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5641         * compile/compile-c-symbols.c: Use C++ exception handling.
5642         * common/selftest.c: Use C++ exception handling.
5643         * common/new-op.c: Use C++ exception handling.
5644         * cli/cli-script.c: Use C++ exception handling.
5645         * cli/cli-interp.c: Use C++ exception handling.
5646         * cli/cli-cmds.c: Use C++ exception handling.
5647         * c-varobj.c: Use C++ exception handling.
5648         * btrace.c: Use C++ exception handling.
5649         * breakpoint.c: Use C++ exception handling.
5650         * break-catch-throw.c: Use C++ exception handling.
5651         * arch-utils.c: Use C++ exception handling.
5652         * amd64-tdep.c: Use C++ exception handling.
5653         * ada-valprint.c: Use C++ exception handling.
5654         * ada-typeprint.c: Use C++ exception handling.
5655         * ada-lang.c: Use C++ exception handling.
5656         * aarch64-tdep.c: Use C++ exception handling.
5657
5658 2019-04-08  Tom Tromey  <tom@tromey.com>
5659
5660         * xml-support.c (gdb_xml_parser::parse): Update.
5661         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5662         * value.c (show_convenience): Update.
5663         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5664         (test_parse_flags_qcs): Update.
5665         * thread.c (thr_try_catch_cmd): Update.
5666         * target.c (target_translate_tls_address): Update.
5667         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5668         (info_frame_command_core, frame_apply_command_count): Update.
5669         * rust-exp.y (rust_lex_exception_test): Update.
5670         * riscv-tdep.c (riscv_print_one_register_info): Update.
5671         * remote.c (remote_target::enable_btrace): Update.
5672         * record-btrace.c (record_btrace_enable_warn): Update.
5673         * python/py-utils.c (gdbpy_convert_exception): Update.
5674         * printcmd.c (do_one_display, print_variable_and_value): Update.
5675         * mi/mi-main.c (mi_print_exception): Update.
5676         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5677         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5678         * linux-nat.c (linux_nat_target::attach): Update.
5679         * linux-fork.c (class scoped_switch_fork_info): Update.
5680         * infrun.c (displaced_step_prepare): Update.
5681         * infcall.c (call_function_by_hand_dummy): Update.
5682         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5683         * gnu-v3-abi.c (print_one_vtable): Update.
5684         * frame.c (get_prev_frame_always): Update.
5685         * f-valprint.c (info_common_command_for_block): Update.
5686         * exec.c (try_open_exec_file): Update.
5687         * exceptions.c (print_exception, exception_print)
5688         (exception_fprintf, exception_print_same): Update.
5689         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5690         * dwarf-index-cache.c (index_cache::store)
5691         (index_cache::lookup_gdb_index): Update.
5692         * darwin-nat.c (maybe_cache_shell): Update.
5693         * cp-valprint.c (cp_print_value_fields): Update.
5694         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5695         (gcc_cplus_symbol_address): Update.
5696         * compile/compile-c-symbols.c (gcc_convert_symbol)
5697         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5698         * common/selftest.c: Update.
5699         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5700         a std::string.
5701         (exception_try_scope_entry, exception_try_scope_exit): Don't
5702         declare.
5703         (struct exception_try_scope): Remove.
5704         (TRY): Don't use exception_try_scope.
5705         (struct gdb_exception): Add constructor, operator=.
5706         <what>: New method.
5707         (struct gdb_exception_RETURN_MASK_ALL)
5708         (struct gdb_exception_RETURN_MASK_ERROR)
5709         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5710         (struct gdb_quit_bad_alloc): Update.
5711         * common/common-exceptions.c (exception_none): Change
5712         initializer.
5713         (struct catcher) <state, exception>: Initialize inline.
5714         <prev>: Remove member.
5715         (current_catcher): Remove.
5716         (catchers): New global.
5717         (exceptions_state_mc_init): Simplify.
5718         (catcher_pop): Remove.
5719         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5720         (try_scope_depth, exception_try_scope_entry)
5721         (exception_try_scope_exit): Remove.
5722         (throw_exception_sjlj): Update.
5723         (exception_messages, exception_messages_size): Remove.
5724         (throw_it): Simplify.
5725         (gdb_exception_sliced_copy): Remove.
5726         (throw_exception_cxx): Update.
5727         * cli/cli-script.c (script_from_file): Update.
5728         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5729         Update.
5730         * ada-valprint.c (ada_val_print): Update.
5731         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5732         (create_excep_cond_exprs): Update.
5733
5734 2019-04-08  Tom Tromey  <tom@tromey.com>
5735
5736         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5737         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5738         (TRY, CATCH, END_CATCH): Remove some definitions.
5739         * common/common-exceptions.c: Don't use GDB_XCPT.
5740         (catcher_list_size): Remove.
5741         (throw_exception, throw_it): Simplify.
5742
5743 2019-04-05  Tom Tromey  <tom@tromey.com>
5744
5745         Revert the header-sorting patch.
5746         * ft32-tdep.c: Revert.
5747         * frv-tdep.c: Revert.
5748         * frv-linux-tdep.c: Revert.
5749         * frame.c: Revert.
5750         * frame-unwind.c: Revert.
5751         * frame-base.c: Revert.
5752         * fork-child.c: Revert.
5753         * findvar.c: Revert.
5754         * findcmd.c: Revert.
5755         * filesystem.c: Revert.
5756         * filename-seen-cache.h: Revert.
5757         * filename-seen-cache.c: Revert.
5758         * fbsd-tdep.c: Revert.
5759         * fbsd-nat.h: Revert.
5760         * fbsd-nat.c: Revert.
5761         * f-valprint.c: Revert.
5762         * f-typeprint.c: Revert.
5763         * f-lang.c: Revert.
5764         * extension.h: Revert.
5765         * extension.c: Revert.
5766         * extension-priv.h: Revert.
5767         * expprint.c: Revert.
5768         * exec.h: Revert.
5769         * exec.c: Revert.
5770         * exceptions.c: Revert.
5771         * event-top.c: Revert.
5772         * event-loop.c: Revert.
5773         * eval.c: Revert.
5774         * elfread.c: Revert.
5775         * dwarf2read.h: Revert.
5776         * dwarf2read.c: Revert.
5777         * dwarf2loc.c: Revert.
5778         * dwarf2expr.h: Revert.
5779         * dwarf2expr.c: Revert.
5780         * dwarf2-frame.c: Revert.
5781         * dwarf2-frame-tailcall.c: Revert.
5782         * dwarf-index-write.h: Revert.
5783         * dwarf-index-write.c: Revert.
5784         * dwarf-index-common.c: Revert.
5785         * dwarf-index-cache.h: Revert.
5786         * dwarf-index-cache.c: Revert.
5787         * dummy-frame.c: Revert.
5788         * dtrace-probe.c: Revert.
5789         * disasm.h: Revert.
5790         * disasm.c: Revert.
5791         * disasm-selftests.c: Revert.
5792         * dictionary.c: Revert.
5793         * dicos-tdep.c: Revert.
5794         * demangle.c: Revert.
5795         * dcache.h: Revert.
5796         * dcache.c: Revert.
5797         * darwin-nat.h: Revert.
5798         * darwin-nat.c: Revert.
5799         * darwin-nat-info.c: Revert.
5800         * d-valprint.c: Revert.
5801         * d-namespace.c: Revert.
5802         * d-lang.c: Revert.
5803         * ctf.c: Revert.
5804         * csky-tdep.c: Revert.
5805         * csky-linux-tdep.c: Revert.
5806         * cris-tdep.c: Revert.
5807         * cris-linux-tdep.c: Revert.
5808         * cp-valprint.c: Revert.
5809         * cp-support.c: Revert.
5810         * cp-namespace.c: Revert.
5811         * cp-abi.c: Revert.
5812         * corelow.c: Revert.
5813         * corefile.c: Revert.
5814         * continuations.c: Revert.
5815         * completer.h: Revert.
5816         * completer.c: Revert.
5817         * complaints.c: Revert.
5818         * coffread.c: Revert.
5819         * coff-pe-read.c: Revert.
5820         * cli-out.h: Revert.
5821         * cli-out.c: Revert.
5822         * charset.c: Revert.
5823         * c-varobj.c: Revert.
5824         * c-valprint.c: Revert.
5825         * c-typeprint.c: Revert.
5826         * c-lang.c: Revert.
5827         * buildsym.c: Revert.
5828         * buildsym-legacy.c: Revert.
5829         * build-id.h: Revert.
5830         * build-id.c: Revert.
5831         * btrace.c: Revert.
5832         * bsd-uthread.c: Revert.
5833         * breakpoint.h: Revert.
5834         * breakpoint.c: Revert.
5835         * break-catch-throw.c: Revert.
5836         * break-catch-syscall.c: Revert.
5837         * break-catch-sig.c: Revert.
5838         * blockframe.c: Revert.
5839         * block.c: Revert.
5840         * bfin-tdep.c: Revert.
5841         * bfin-linux-tdep.c: Revert.
5842         * bfd-target.c: Revert.
5843         * bcache.c: Revert.
5844         * ax-general.c: Revert.
5845         * ax-gdb.h: Revert.
5846         * ax-gdb.c: Revert.
5847         * avr-tdep.c: Revert.
5848         * auxv.c: Revert.
5849         * auto-load.c: Revert.
5850         * arm-wince-tdep.c: Revert.
5851         * arm-tdep.c: Revert.
5852         * arm-symbian-tdep.c: Revert.
5853         * arm-pikeos-tdep.c: Revert.
5854         * arm-obsd-tdep.c: Revert.
5855         * arm-nbsd-tdep.c: Revert.
5856         * arm-nbsd-nat.c: Revert.
5857         * arm-linux-tdep.c: Revert.
5858         * arm-linux-nat.c: Revert.
5859         * arm-fbsd-tdep.c: Revert.
5860         * arm-fbsd-nat.c: Revert.
5861         * arm-bsd-tdep.c: Revert.
5862         * arch-utils.c: Revert.
5863         * arc-tdep.c: Revert.
5864         * arc-newlib-tdep.c: Revert.
5865         * annotate.h: Revert.
5866         * annotate.c: Revert.
5867         * amd64-windows-tdep.c: Revert.
5868         * amd64-windows-nat.c: Revert.
5869         * amd64-tdep.c: Revert.
5870         * amd64-sol2-tdep.c: Revert.
5871         * amd64-obsd-tdep.c: Revert.
5872         * amd64-obsd-nat.c: Revert.
5873         * amd64-nbsd-tdep.c: Revert.
5874         * amd64-nbsd-nat.c: Revert.
5875         * amd64-nat.c: Revert.
5876         * amd64-linux-tdep.c: Revert.
5877         * amd64-linux-nat.c: Revert.
5878         * amd64-fbsd-tdep.c: Revert.
5879         * amd64-fbsd-nat.c: Revert.
5880         * amd64-dicos-tdep.c: Revert.
5881         * amd64-darwin-tdep.c: Revert.
5882         * amd64-bsd-nat.c: Revert.
5883         * alpha-tdep.c: Revert.
5884         * alpha-obsd-tdep.c: Revert.
5885         * alpha-nbsd-tdep.c: Revert.
5886         * alpha-mdebug-tdep.c: Revert.
5887         * alpha-linux-tdep.c: Revert.
5888         * alpha-linux-nat.c: Revert.
5889         * alpha-bsd-tdep.c: Revert.
5890         * alpha-bsd-nat.c: Revert.
5891         * aix-thread.c: Revert.
5892         * agent.c: Revert.
5893         * addrmap.c: Revert.
5894         * ada-varobj.c: Revert.
5895         * ada-valprint.c: Revert.
5896         * ada-typeprint.c: Revert.
5897         * ada-tasks.c: Revert.
5898         * ada-lang.c: Revert.
5899         * aarch64-tdep.c: Revert.
5900         * aarch64-ravenscar-thread.c: Revert.
5901         * aarch64-newlib-tdep.c: Revert.
5902         * aarch64-linux-tdep.c: Revert.
5903         * aarch64-linux-nat.c: Revert.
5904         * aarch64-fbsd-tdep.c: Revert.
5905         * aarch64-fbsd-nat.c: Revert.
5906         * aarch32-linux-nat.c: Revert.
5907
5908 2019-04-05  Tom Tromey  <tom@tromey.com>
5909
5910         * ft32-tdep.c: Sort headers.
5911         * frv-tdep.c: Sort headers.
5912         * frv-linux-tdep.c: Sort headers.
5913         * frame.c: Sort headers.
5914         * frame-unwind.c: Sort headers.
5915         * frame-base.c: Sort headers.
5916         * fork-child.c: Sort headers.
5917         * findvar.c: Sort headers.
5918         * findcmd.c: Sort headers.
5919         * filesystem.c: Sort headers.
5920         * filename-seen-cache.h: Sort headers.
5921         * filename-seen-cache.c: Sort headers.
5922         * fbsd-tdep.c: Sort headers.
5923         * fbsd-nat.h: Sort headers.
5924         * fbsd-nat.c: Sort headers.
5925         * f-valprint.c: Sort headers.
5926         * f-typeprint.c: Sort headers.
5927         * f-lang.c: Sort headers.
5928         * extension.h: Sort headers.
5929         * extension.c: Sort headers.
5930         * extension-priv.h: Sort headers.
5931         * expprint.c: Sort headers.
5932         * exec.h: Sort headers.
5933         * exec.c: Sort headers.
5934         * exceptions.c: Sort headers.
5935         * event-top.c: Sort headers.
5936         * event-loop.c: Sort headers.
5937         * eval.c: Sort headers.
5938         * elfread.c: Sort headers.
5939         * dwarf2read.h: Sort headers.
5940         * dwarf2read.c: Sort headers.
5941         * dwarf2loc.c: Sort headers.
5942         * dwarf2expr.h: Sort headers.
5943         * dwarf2expr.c: Sort headers.
5944         * dwarf2-frame.c: Sort headers.
5945         * dwarf2-frame-tailcall.c: Sort headers.
5946         * dwarf-index-write.h: Sort headers.
5947         * dwarf-index-write.c: Sort headers.
5948         * dwarf-index-common.c: Sort headers.
5949         * dwarf-index-cache.h: Sort headers.
5950         * dwarf-index-cache.c: Sort headers.
5951         * dummy-frame.c: Sort headers.
5952         * dtrace-probe.c: Sort headers.
5953         * disasm.h: Sort headers.
5954         * disasm.c: Sort headers.
5955         * disasm-selftests.c: Sort headers.
5956         * dictionary.c: Sort headers.
5957         * dicos-tdep.c: Sort headers.
5958         * demangle.c: Sort headers.
5959         * dcache.h: Sort headers.
5960         * dcache.c: Sort headers.
5961         * darwin-nat.h: Sort headers.
5962         * darwin-nat.c: Sort headers.
5963         * darwin-nat-info.c: Sort headers.
5964         * d-valprint.c: Sort headers.
5965         * d-namespace.c: Sort headers.
5966         * d-lang.c: Sort headers.
5967         * ctf.c: Sort headers.
5968         * csky-tdep.c: Sort headers.
5969         * csky-linux-tdep.c: Sort headers.
5970         * cris-tdep.c: Sort headers.
5971         * cris-linux-tdep.c: Sort headers.
5972         * cp-valprint.c: Sort headers.
5973         * cp-support.c: Sort headers.
5974         * cp-namespace.c: Sort headers.
5975         * cp-abi.c: Sort headers.
5976         * corelow.c: Sort headers.
5977         * corefile.c: Sort headers.
5978         * continuations.c: Sort headers.
5979         * completer.h: Sort headers.
5980         * completer.c: Sort headers.
5981         * complaints.c: Sort headers.
5982         * coffread.c: Sort headers.
5983         * coff-pe-read.c: Sort headers.
5984         * cli-out.h: Sort headers.
5985         * cli-out.c: Sort headers.
5986         * charset.c: Sort headers.
5987         * c-varobj.c: Sort headers.
5988         * c-valprint.c: Sort headers.
5989         * c-typeprint.c: Sort headers.
5990         * c-lang.c: Sort headers.
5991         * buildsym.c: Sort headers.
5992         * buildsym-legacy.c: Sort headers.
5993         * build-id.h: Sort headers.
5994         * build-id.c: Sort headers.
5995         * btrace.c: Sort headers.
5996         * bsd-uthread.c: Sort headers.
5997         * breakpoint.h: Sort headers.
5998         * breakpoint.c: Sort headers.
5999         * break-catch-throw.c: Sort headers.
6000         * break-catch-syscall.c: Sort headers.
6001         * break-catch-sig.c: Sort headers.
6002         * blockframe.c: Sort headers.
6003         * block.c: Sort headers.
6004         * bfin-tdep.c: Sort headers.
6005         * bfin-linux-tdep.c: Sort headers.
6006         * bfd-target.c: Sort headers.
6007         * bcache.c: Sort headers.
6008         * ax-general.c: Sort headers.
6009         * ax-gdb.h: Sort headers.
6010         * ax-gdb.c: Sort headers.
6011         * avr-tdep.c: Sort headers.
6012         * auxv.c: Sort headers.
6013         * auto-load.c: Sort headers.
6014         * arm-wince-tdep.c: Sort headers.
6015         * arm-tdep.c: Sort headers.
6016         * arm-symbian-tdep.c: Sort headers.
6017         * arm-pikeos-tdep.c: Sort headers.
6018         * arm-obsd-tdep.c: Sort headers.
6019         * arm-nbsd-tdep.c: Sort headers.
6020         * arm-nbsd-nat.c: Sort headers.
6021         * arm-linux-tdep.c: Sort headers.
6022         * arm-linux-nat.c: Sort headers.
6023         * arm-fbsd-tdep.c: Sort headers.
6024         * arm-fbsd-nat.c: Sort headers.
6025         * arm-bsd-tdep.c: Sort headers.
6026         * arch-utils.c: Sort headers.
6027         * arc-tdep.c: Sort headers.
6028         * arc-newlib-tdep.c: Sort headers.
6029         * annotate.h: Sort headers.
6030         * annotate.c: Sort headers.
6031         * amd64-windows-tdep.c: Sort headers.
6032         * amd64-windows-nat.c: Sort headers.
6033         * amd64-tdep.c: Sort headers.
6034         * amd64-sol2-tdep.c: Sort headers.
6035         * amd64-obsd-tdep.c: Sort headers.
6036         * amd64-obsd-nat.c: Sort headers.
6037         * amd64-nbsd-tdep.c: Sort headers.
6038         * amd64-nbsd-nat.c: Sort headers.
6039         * amd64-nat.c: Sort headers.
6040         * amd64-linux-tdep.c: Sort headers.
6041         * amd64-linux-nat.c: Sort headers.
6042         * amd64-fbsd-tdep.c: Sort headers.
6043         * amd64-fbsd-nat.c: Sort headers.
6044         * amd64-dicos-tdep.c: Sort headers.
6045         * amd64-darwin-tdep.c: Sort headers.
6046         * amd64-bsd-nat.c: Sort headers.
6047         * alpha-tdep.c: Sort headers.
6048         * alpha-obsd-tdep.c: Sort headers.
6049         * alpha-nbsd-tdep.c: Sort headers.
6050         * alpha-mdebug-tdep.c: Sort headers.
6051         * alpha-linux-tdep.c: Sort headers.
6052         * alpha-linux-nat.c: Sort headers.
6053         * alpha-bsd-tdep.c: Sort headers.
6054         * alpha-bsd-nat.c: Sort headers.
6055         * aix-thread.c: Sort headers.
6056         * agent.c: Sort headers.
6057         * addrmap.c: Sort headers.
6058         * ada-varobj.c: Sort headers.
6059         * ada-valprint.c: Sort headers.
6060         * ada-typeprint.c: Sort headers.
6061         * ada-tasks.c: Sort headers.
6062         * ada-lang.c: Sort headers.
6063         * aarch64-tdep.c: Sort headers.
6064         * aarch64-ravenscar-thread.c: Sort headers.
6065         * aarch64-newlib-tdep.c: Sort headers.
6066         * aarch64-linux-tdep.c: Sort headers.
6067         * aarch64-linux-nat.c: Sort headers.
6068         * aarch64-fbsd-tdep.c: Sort headers.
6069         * aarch64-fbsd-nat.c: Sort headers.
6070         * aarch32-linux-nat.c: Sort headers.
6071
6072 2019-04-04  Tom Tromey  <tom@tromey.com>
6073
6074         * varobj.c (varobj_create): Update.
6075         * rust-exp.y (struct rust_parser) <update_innermost_block,
6076         lookup_symbol>: New methods.
6077         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6078         Rename.
6079         (rust_parser::rust_lookup_type)
6080         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6081         * printcmd.c (display_command, do_one_display): Update.
6082         * parser-defs.h (struct parser_state) <parser_state>: Add
6083         "tracker" parameter.
6084         (block_tracker): New member.
6085         (class innermost_block_tracker) <innermost_block_tracker>: Add
6086         "types" parameter.
6087         <reset>: Remove method.
6088         (innermost_block): Don't declare.
6089         (null_post_parser): Update.
6090         * parse.c (innermost_block): Remove global.
6091         (write_dollar_variable): Update.
6092         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6093         Remove "tracker_types" parameter.
6094         (parse_expression): Add "tracker" parameter.
6095         (parse_expression_for_completion): Update.
6096         (null_post_parser): Add "tracker" parameter.
6097         * p-exp.y: Update rules.
6098         * m2-exp.y: Update rules.
6099         * language.h (struct language_defn) <la_post_parser>: Add
6100         "tracker" parameter.
6101         * go-exp.y: Update rules.
6102         * f-exp.y: Update rules.
6103         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6104         parameter.
6105         * d-exp.y: Update rules.
6106         * c-exp.y: Update rules.
6107         * breakpoint.c (set_breakpoint_condition): Create an
6108         innermost_block_tracker.
6109         (watch_command_1): Likewise.
6110         * ada-lang.c (resolve): Add "tracker" parameter.
6111         (resolve_subexp): Likewise.
6112         * ada-exp.y (write_var_from_sym): Update.
6113
6114 2019-04-04  Tom Tromey  <tom@tromey.com>
6115
6116         * type-stack.h: New file.
6117         * type-stack.c: New file.
6118         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6119         type-stack.h.
6120         (insert_into_type_stack, insert_type, push_type, push_type_int)
6121         (insert_type_address_space, pop_type, pop_type_int)
6122         (pop_typelist, pop_type_stack, append_type_stack)
6123         (push_type_stack, get_type_stack, push_typelist)
6124         (follow_type_instance_flags, follow_types): Don't declare.
6125         * parse.c (type_stack): Remove global.
6126         (parse_exp_in_context): Update.
6127         (insert_into_type_stack, insert_type, push_type, push_type_int)
6128         (insert_type_address_space, pop_type, pop_type_int)
6129         (pop_typelist, pop_type_stack, append_type_stack)
6130         (push_type_stack, get_type_stack, push_typelist)
6131         (follow_type_instance_flags, follow_types): Remove (moved to
6132         type-stack.c).
6133         * f-exp.y (type_stack): New global.
6134         Update rules.
6135         (push_kind_type, f_parse): Update.
6136         * d-exp.y (type_stack): New global.
6137         Update rules.
6138         (d_parse): Update.
6139         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6140         Update rules.
6141         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6142         (HFILES_NO_SRCDIR): Add type-stack.h.
6143
6144 2019-04-04  Tom Tromey  <tom@tromey.com>
6145
6146         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6147         (rust_parser::convert_ast_to_expression, rust_parse)
6148         (rust_lex_test_completion, rust_lex_tests): Update.
6149         * parser-defs.h (struct expr_completion_state): New.
6150         (struct parser_state) <parser_state>: Add completion parameter.
6151         <mark_struct_expression, mark_completion_tag>: New methods.
6152         <parse_completion, m_completion_state>: New members.
6153         (prefixify_expression, null_post_parser): Update.
6154         (mark_struct_expression, mark_completion_tag): Don't declare.
6155         * parse.c (parse_completion, expout_last_struct)
6156         (expout_tag_completion_type, expout_completion_name): Remove
6157         globals.
6158         (parser_state::mark_struct_expression)
6159         (parser_state::mark_completion_tag): Now methods.
6160         (prefixify_expression): Add last_struct parameter.
6161         (prefixify_subexp): Likewise.
6162         (parse_exp_1): Update.
6163         (parse_exp_in_context): Add cstate parameter.  Update.
6164         (parse_expression_for_completion): Create an
6165         expr_completion_state.
6166         (null_post_parser): Add "completion" parameter.
6167         * p-exp.y: Update rules.
6168         (yylex): Update.
6169         * language.h (struct language_defn) <la_post_parser>: Add
6170         "completing" parameter.
6171         * go-exp.y: Update rules.
6172         (lex_one_token): Update.
6173         * expression.h (parse_completion): Don't declare.
6174         * d-exp.y: Update rules.
6175         (lex_one_token): Update rules.
6176         * c-exp.y: Update rules.
6177         (lex_one_token): Update.
6178         * ada-lang.c (resolve): Add "parse_completion" parameter.
6179         (resolve_subexp): Likewise.
6180         (ada_resolve_function): Likewise.
6181
6182 2019-04-04  Tom Tromey  <tom@tromey.com>
6183
6184         * parser-defs.h (struct parser_state) <start_arglist,
6185         end_arglist>: New methods.
6186         <arglist_len, m_funcall_chain>: New members.
6187         (arglist_len, start_arglist, end_arglist): Don't declare.
6188         * parse.c (arglist_len, funcall_chain): Remove global.
6189         (start_arglist, end_arglist): Remove functions.
6190         (parse_exp_in_context): Update.
6191         * p-exp.y: Update rules.
6192         * m2-exp.y: Update rules.
6193         * go-exp.y: Update rules.
6194         * f-exp.y: Update rules.
6195         * d-exp.y: Update rules.
6196         * c-exp.y: Update rules.
6197
6198 2019-04-04  Tom Tromey  <tom@tromey.com>
6199
6200         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6201         lex_operator, push_back>: New methods.
6202         Update all rules.
6203         (rust_parser::lex_hex, lex_escape): Rename and update.
6204         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6205         (rust_parser::lex_operator): Rename and update.
6206         (rust_parser::lex_number, rustyylex, rustyyerror)
6207         (rust_lex_test_init, rust_lex_test_sequence)
6208         (rust_lex_test_push_back, rust_lex_tests): Update.
6209         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6210         parameter.
6211         <lexptr, prev_lexptr>: New members.
6212         (lexptr, prev_lexptr): Don't declare.
6213         * parse.c (lexptr, prev_lexptr): Remove globals.
6214         (parse_exp_in_context): Update.
6215         * p-exp.y (yylex, yyerror): Update.
6216         * m2-exp.y (parse_number, yylex, yyerror): Update.
6217         * go-exp.y (lex_one_token, yyerror): Update.
6218         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6219         * d-exp.y (lex_one_token, yyerror): Update.
6220         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6221         (lex_one_token, yyerror): Update.
6222         * ada-lex.l (YY_INPUT): Update.
6223         (rewind_to_char): Update.
6224         * ada-exp.y (yyerror): Update.
6225
6226 2019-04-04  Tom Tromey  <tom@tromey.com>
6227
6228         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6229         * parser-defs.h (struct parser_state) <parser_state>: Add new
6230         parameter.
6231         <comma_terminates>: New member.
6232         (comma_terminates): Don't declare global.
6233         * parse.c (comma_terminates): Remove global.
6234         (parse_exp_in_context): Update.
6235         * p-exp.y (yylex): Update.
6236         * m2-exp.y (yylex): Update.
6237         * go-exp.y (lex_one_token): Update.
6238         * f-exp.y (yylex): Update.
6239         * d-exp.y (lex_one_token): Update.
6240         * c-exp.y (lex_one_token): Update.
6241         * ada-lex.l: Update.
6242
6243 2019-04-04  Tom Tromey  <tom@tromey.com>
6244
6245         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6246         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6247         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6248         * parser-defs.h (paren_depth): Don't declare.
6249         * parse.c (paren_depth): Remove global.
6250         (parse_exp_in_context): Update.
6251         * p-exp.y (paren_depth): New global.
6252         (pascal_parse): Initialize it.
6253         * m2-exp.y (paren_depth): New global.
6254         (m2_parse): Initialize it.
6255         * go-exp.y (paren_depth): New global.
6256         (go_parse): Initialize it.
6257         * f-exp.y (paren_depth): New global.
6258         (f_parse): Initialize it.
6259         * d-exp.y (paren_depth): New global.
6260         (d_parse): Initialize it.
6261         * c-exp.y (paren_depth): New global.
6262         (c_parse): Initialize it.
6263         * ada-lex.l (paren_depth): New global.
6264         (lexer_init): Initialize it.
6265
6266 2019-04-04  Tom Tromey  <tom@tromey.com>
6267
6268         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6269         (rust_parser::convert_ast_to_type)
6270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6271         * parser-defs.h (struct parser_state) <parser_state>: Add
6272         parameters.  Initialize new members.
6273         <expression_context_block, expression_context_pc>: New members.
6274         * parse.c (expression_context_block, expression_context_pc):
6275         Remove globals.
6276         (parse_exp_in_context): Update.
6277         * p-exp.y: Update all rules.
6278         (yylex): Update.
6279         * m2-exp.y: Update all rules.
6280         (yylex): Update.
6281         * go-exp.y (yylex): Update.
6282         * f-exp.y (yylex): Update.
6283         * d-exp.y: Update all rules.
6284         (yylex): Update.
6285         * c-exp.y: Update all rules.
6286         (lex_one_token, classify_name, yylex, c_parse): Update.
6287         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6288
6289 2019-04-04  Tom Tromey  <tom@tromey.com>
6290
6291         * gdbarch.h, gdbarch.c: Rebuild.
6292         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6293         * stap-probe.h:
6294         (struct stap_parse_info): Replace "parser_state" with
6295         "expr_builder".
6296         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6297         (parser_state): New class.
6298         * parse.c (expr_builder): Rename.
6299         (expr_builder::release): Rename.
6300         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6301         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6302         (write_exp_elt_longcst, write_exp_elt_floatcst)
6303         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6304         (write_exp_string_vector, write_exp_bitstring)
6305         (write_exp_msymbol, mark_struct_expression)
6306         (write_dollar_variable)
6307         (insert_type_address_space, increase_expout_size): Replace
6308         "parser_state" with "expr_builder".
6309         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6310         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6311         "parser_state" with "expr_builder".
6312
6313 2019-04-04  Tom Tromey  <tom@tromey.com>
6314
6315         * rust-exp.y: Replace "parse_language" with method call.
6316         * p-exp.y:
6317         (yylex): Replace "parse_language" with method call.
6318         * m2-exp.y:
6319         (yylex): Replace "parse_language" with method call.
6320         * go-exp.y (classify_name): Replace "parse_language" with method
6321         call.
6322         * f-exp.y (yylex): Replace "parse_language" with method call.
6323         * d-exp.y (lex_one_token): Replace "parse_language" with method
6324         call.
6325         * c-exp.y:
6326         (lex_one_token, classify_name, yylex): Replace "parse_language"
6327         with method call.
6328         * ada-exp.y (find_primitive_type, type_char)
6329         (type_system_address): Replace "parse_language" with method call.
6330
6331 2019-04-04  Tom Tromey  <tom@tromey.com>
6332
6333         * rust-exp.y: Replace "parse_gdbarch" with method call.
6334         * parse.c (write_dollar_variable, insert_type_address_space):
6335         Replace "parse_gdbarch" with method call.
6336         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6337         call.
6338         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6339         call.
6340         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6341         "parse_gdbarch" with method call.
6342         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6343         with method call.
6344         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6345         "parse_gdbarch" with method call.
6346         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6347         "parse_gdbarch" with method call.
6348         * c-exp.y (parse_type, parse_number, classify_name): Replace
6349         "parse_gdbarch" with method call.
6350         * ada-lex.l: Replace "parse_gdbarch" with method call.
6351         * ada-exp.y (parse_type, find_primitive_type, type_char)
6352         (type_system_address): Replace "parse_gdbarch" with method call.
6353
6354 2019-04-04  Tom Tromey  <tom@tromey.com>
6355
6356         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6357         * stap-probe.c (stap_parse_argument): Update.
6358         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6359         initial_size parameter.
6360         * rust-exp.y (rust_lex_tests): Update.
6361         * parse.c (parser_state): Update.
6362         (parse_exp_in_context): Update.
6363         * parser-defs.h (struct parser_state) <parser_state>: Remove
6364         "initial_size" parameter.
6365
6366 2019-04-04  Tom Tromey  <tom@tromey.com>
6367
6368         * parser-defs.h (increase_expout_size): Don't declare.
6369         * parse.c (increase_expout_size): Now static.
6370
6371 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6372
6373         * gnu-nat.c (gnu_nat_target::wait): Fix
6374         target_waitstatus_to_string call.
6375
6376 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * eval.c (evaluate_subexp_standard): Handle internal functions
6379         during Fortran function call handling.
6380
6381 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6382
6383         * NEWS: Mention new internal functions.
6384         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6385         (read_base_type): Use dwarf2_init_complex_target_type.
6386         * value.c (creal_internal_fn): New function.
6387         (cimag_internal_fn): New function.
6388         (_initialize_values): Register new internal functions.
6389
6390 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6391
6392         * infrun.c (stop_all_threads): If debug_infrun, always
6393         trace the wait status after wait_one, using
6394         target_waitstatus_to_string and target_pid_to_str.
6395         (handle_inferior_event): Replace various trace of
6396         wait status kind by a single trace.
6397         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6398         wait status kind image by target_waitstatus_to_string.
6399         * target/waitstatus.c (target_waitstatus_to_string): Fix
6400         obsolete comment.
6401
6402 2019-04-01  Tom Tromey  <tromey@adacore.com>
6403
6404         PR symtab/23331:
6405         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6406
6407 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6408             Pedro Alves  <palves@redhat.com>
6409
6410         * top.c (quit_force): Call 'finalize_values'.
6411         * value.c (finalize_values): New function.
6412         * value.h (finalize_values): Declare.
6413
6414 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6415
6416         * NEWS: Announce $_gdb_major and $_gdb_minor.
6417
6418         * top.c (init_gdb_version_vars): New function.
6419         (gdb_init): Call init_gdb_version_vars.
6420
6421 2019-03-29  Tom Tromey  <tromey@adacore.com>
6422
6423         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6424         help text.  Remove dead code.
6425
6426 2019-03-29  Keith Seitz  <keiths@redhat.com>
6427
6428         From Siddhesh Poyarekar:
6429         * f-lang.h (f77_get_upperbound): Return LONGEST.
6430         (f77_get_lowerbound): Likewise.
6431         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6432         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6433         print them.
6434         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6435         plongest to format print it.
6436         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6437         (f77_get_upperbound): Likewise.
6438         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6439         LOWER_BOUND to LONGEST.
6440         (f77_create_arrayprint_offset_tbl): Likewise.
6441
6442 2019-03-29  Keith Seitz  <keiths@redhat.com>
6443
6444         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6445         %s/pulongest for TYPE_LENGTH instead of %d in format
6446         strings.
6447         * ada-typerint.c (ada_print_type): Likewise.
6448         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6449         * compile/compile-c-support.c (generate_register_struct): Likewise.
6450         * gdbtypes.c (recursive_dump_type): Likewise.
6451         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6452         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6453         instead of %d in format strings.
6454         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6455         to std::min to ULONGEST.
6456         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6457         instead of %d in format strings.
6458         * tracepoint.c (info_scope_command): Likewise.
6459         * typeprint.c (print_offset_data::update)
6460         (print_offset_data::finish): Likewise.
6461         * xtensa-tdep.c (xtensa_store_return_value)
6462         (xtensa_push_dummy_call): Likewise.
6463
6464 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6465
6466         * windows-nat.c (display_selector): Fixed format specifications
6467         for 64-bit Cygwin.
6468
6469 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6470
6471         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6472
6473 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6474
6475         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6476         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6477         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6478         (nios2_linux_init_abi): Install it.
6479
6480 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6481
6482         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6483
6484 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6487
6488 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6489             Tom Tromey  <tromey@adacore.com>
6490
6491         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6492
6493 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6494
6495         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6496         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6497         method to compute the bounds of range types. Also print "[evaluated]"
6498         if the bounds' values come from a dynamic evaluation.
6499
6500 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6501
6502         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6503         whitespace when pretty printing is on.
6504
6505 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6506
6507         * ppc-linux-nat.c: Add include.
6508
6509 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6510
6511         * NEWS: Mention AArch64 Pointer Authentication.
6512
6513 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6514
6515         * arm-linux-nat.c: Add include.
6516
6517 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6518
6519         * source-cache.c (source_cache::get_source_lines): Re-read
6520         fullname after calling open_source_file.
6521
6522 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6523
6524         * NEWS: Mention TLS support for FreeBSD.
6525
6526 2019-03-25  Tom Tromey  <tromey@adacore.com>
6527
6528         * minsyms.c (BUNCH_SIZE): Update comment.
6529         (~minimal_symbol_reader): Remove old comment.
6530         (compact_minimal_symbols): Update comment.
6531         (minimal_symbol_reader::install): Remove old comment.  Update
6532         other comments.
6533
6534 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6535
6536         * s390-linux-nat.c: Add include.
6537
6538 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6539
6540         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6541         Call linux_get_hwcap.
6542         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6543         Likewise.
6544         (aarch64_linux_get_hwcap): Remove function.
6545         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6546         declaration.
6547         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6548         linux_get_hwcap.
6549         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6550         * linux-tdep.c (linux_get_hwcap): Add function.
6551         (linux_get_hwcap2): Likewise.
6552         * linux-tdep.h (linux_get_hwcap): Add declaration.
6553         (linux_get_hwcap2): Likewise.
6554         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6555         (ppc_linux_get_hwcap2): Likewise.
6556         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6557         linux_get_hwcap.
6558         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6559         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6560         (ppc_linux_nat_target::read_description): Likewise.
6561         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6562         * s390-linux-nat.c: Likewise.
6563         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6564
6565 2019-03-24  Tom Tromey  <tom@tromey.com>
6566
6567         * ada-lang.c (standard_lookup): Simplify initialization.
6568         (ada_lookup_symbol_nonlocal): Simplify return.
6569         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6570         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6571         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6572         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6573         initialization.
6574         * solib.c (solib_global_lookup): Simplify.
6575         * symtab.c (null_block_symbol): Remove.
6576         (symbol_cache_lookup): Simplify returns.
6577         (lookup_language_this): Simplify returns.
6578         (lookup_symbol_aux): Simplify return.
6579         (lookup_local_symbol): Simplify returns.
6580         (lookup_global_symbol_from_objfile): Simplify return.
6581         (lookup_symbol_in_objfile_symtabs)
6582         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6583         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6584         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6585         * cp-namespace.c (cp_lookup_bare_symbol)
6586         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6587         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6588         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6589         (cp_lookup_symbol_via_imports): Simplify initialization.
6590         (find_symbol_in_baseclass): Likewise.
6591         * symtab.h (null_block_symbol): Remove.
6592         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6593         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6594         (d_lookup_symbol_module): Likewise.
6595         (find_symbol_in_baseclass): Simplify initialization.
6596
6597 2019-03-24  Tom Tromey  <tom@tromey.com>
6598
6599         * expression.h: Don't include symtab.h.
6600         (struct block): Forward declare.
6601
6602 2019-03-24  Tom Tromey  <tom@tromey.com>
6603
6604         * c-exp.y (typebase): Remove casts.
6605         * gdbtypes.c (lookup_unsigned_typename, )
6606         (lookup_signed_typename): Remove cast.
6607         * eval.c (parse_to_comma_and_eval): Remove cast.
6608         * parse.c (write_dollar_variable): Remove cast.
6609         * block.h (struct block) <superblock>: Now const.
6610         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6611         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6612         (map_block): Make "block" const.
6613         * symfile.h (struct quick_symbol_functions)
6614         <map_matching_symbols>: Constify block argument to "callback".
6615         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6616         const.
6617         (find_pc_sect_compunit_symtab): Make "b" const.
6618         (find_symbol_at_address): Likewise.
6619         (search_symbols): Likewise.
6620         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6621         (dw2_debug_names_lookup_symbol): Likewise.
6622         (dw2_map_matching_symbols): Update.
6623         * p-valprint.c (pascal_val_print): Remove "block".
6624         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6625         (aux_add_nonlocal_symbols): Make "block" const.
6626         (resolve_subexp): Remove cast.
6627         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6628         const.
6629         (iterate_over_file_blocks): Likewise.
6630         * f-exp.y (%union) <bval>: Remove.
6631         * coffread.c (patch_opaque_types): Make "b" const.
6632         * spu-tdep.c (spu_catch_start): Make "block" const.
6633         * c-valprint.c (print_unpacked_pointer): Remove "block".
6634         * symmisc.c (dump_symtab_1): Make "b" const.
6635         (block_depth): Make "block" const.
6636         * d-exp.y (%union) <bval>: Remove.
6637         * cp-support.h (cp_lookup_rtti_type): Update.
6638         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6639         * psymtab.c (psym_lookup_symbol): Make "block" const.
6640         (maintenance_check_psymtabs): Make "b" const.
6641         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6642         (enumerate_locals, enumerate_args): Update.
6643         * python/py-symtab.c (stpy_global_block): Make "block" const.
6644         (stpy_static_block): Likewise.
6645         * inline-frame.c (block_starting_point_at): Make "new_block"
6646         const.
6647         * block.c (find_block_in_blockvector): Make return type const.
6648         (blockvector_for_pc_sect): Make "b" const.
6649         (find_block_in_blockvector): Make "b" const.
6650
6651 2019-03-23  Tom Tromey  <tom@tromey.com>
6652
6653         * varobj.c (varobj_create): Update.
6654         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6655         * printcmd.c (display_command, do_one_display): Don't reset
6656         innermost_block.
6657         * parser-defs.h (enum innermost_block_tracker_type): Move to
6658         expression.h.
6659         (innermost_block): Update comment.
6660         * parse.c (parse_exp_1): Add tracker_types parameter.
6661         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6662         tracker_types parameter.  Reset innermost_block.
6663         (parse_exp_in_context): Remove.
6664         (parse_expression_for_completion): Update.
6665         * objfiles.c (~objfile): Don't reset expression_context_block or
6666         innermost_block.
6667         * expression.h (enum innermost_block_tracker_type): Move from
6668         parser-defs.h.
6669         (parse_exp_1): Add tracker_types parameter.
6670         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6671         reset innermost_block.
6672
6673 2019-03-23  Tom Tromey  <tom@tromey.com>
6674
6675         * objfiles.h: Include bcache.h.
6676
6677 2019-03-23  Tom Tromey  <tom@tromey.com>
6678
6679         * linespec.c (get_current_search_block): Use
6680         scoped_restore_current_language.
6681         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6682
6683 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6684             Jiong Wang  <jiong.wang@arm.com>
6685
6686         * aarch64-linux-tdep.c
6687         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6688         section.
6689         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6690
6691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6692             Jiong Wang  <jiong.wang@arm.com>
6693
6694         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6695         instructions.
6696         (aarch64_analyze_prologue_test): Add PACIASP test.
6697         (aarch64_prologue_prev_register): Unmask PC value.
6698
6699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6700             Jiong Wang  <jiong.wang@arm.com>
6701
6702         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6703         (aarch64_dwarf2_prev_register): Unmask PC value.
6704         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6705         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6706         DW_CFA_AARCH64_negate_ra_state.
6707         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6708
6709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6710             Jiong Wang  <jiong.wang@arm.com>
6711
6712         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6713         registers.
6714         (aarch64_pseudo_register_name): Likewise.
6715         (aarch64_pseudo_register_type): Likewise.
6716         (aarch64_pseudo_register_reggroup_p): Likewise.
6717         (aarch64_gdbarch_init): Add pauth registers.
6718         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6719         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6720         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6721         (struct gdbarch_tdep): Add regnum for ra_state.
6722
6723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6724             Jiong Wang  <jiong.wang@arm.com>
6725
6726         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6727
6728 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6729             Jiong Wang  <jiong.wang@arm.com>
6730
6731         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6732         function.
6733         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6734         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6735         (aarch64_gdbarch_init): Add puth registers.
6736         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6737         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6738         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6739
6740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6741             Jiong Wang  <jiong.wang@arm.com>
6742
6743         * aarch64-linux-nat.c
6744         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6745         * aarch64-linux-tdep.c
6746         (aarch64_linux_core_read_description): Likewise.
6747         (aarch64_linux_get_hwcap): New function.
6748         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6749         (aarch64_linux_get_hwcap): New declaration.
6750
6751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6752             Jiong Wang  <jiong.wang@arm.com>
6753
6754         * aarch64-linux-nat.c
6755         (aarch64_linux_nat_target::read_description): Add pauth param.
6756         * aarch64-linux-tdep.c
6757         (aarch64_linux_core_read_description): Likewise.
6758         * aarch64-tdep.c (struct target_desc): Add in pauth.
6759         (aarch64_read_description): Add pauth param.
6760         (aarch64_gdbarch_init): Likewise.
6761         * aarch64-tdep.h (aarch64_read_description): Likewise.
6762         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6763         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6764         * features/Makefile: Add new files.
6765         * features/aarch64-pauth.c: New file.
6766         * features/aarch64-pauth.xml: New file.
6767
6768 2019-03-20  Tom Tromey  <tromey@adacore.com>
6769
6770         * infrun.c (handle_inferior_event): Rename from
6771         handle_inferior_event_1.  Create a scoped_value_mark.
6772         (handle_inferior_event): Remove.
6773
6774 2019-03-19  Tom Tromey  <tromey@adacore.com>
6775
6776         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6777         * infrun.h (print_stop_event): Add "displays" parameter.
6778         * infrun.c (print_stop_event): Add "displays" parameter.
6779
6780 2019-03-19  Pedro Alves  <palves@redhat.com>
6781
6782         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6783         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6784         to -1.  Fix TABs vs spaces.
6785         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6786         * tui/tui-out.h (tui_ui_out) Add intro comments.
6787         <m_line, m_start_of_line>: In-class initialize, and add describing
6788         comment.
6789
6790 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6791
6792         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6793         variable names.
6794         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6795
6796 2019-03-18  Pedro Alves  <palves@redhat.com>
6797             Eli Zaretskii <eliz@gnu.org>
6798
6799         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6800         m_line and m_start_of_line.
6801
6802 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6803
6804         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6805         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6806         it returns a newline.  This fixes a regression in TU mode, whereby
6807         the next line is output on the same screen line as the user input.
6808
6809 2019-03-18  Tom Tromey  <tromey@adacore.com>
6810
6811         * minsyms.c (minimal_symbol_reader::install): Remove call to
6812         obstack_blank.
6813
6814 2019-03-18  Pedro Alves  <palves@redhat.com>
6815
6816         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6817         New globals.
6818         (apply_style): New, factored out from ...
6819         (apply_ansi_escape): ... this.  Handle reverse video mode.
6820         (tui_set_reverse_mode): New function.
6821         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6822         * tui/tui-winsource.c (tui_show_source_line): Use
6823         tui_set_reverse_mode instead of setting A_STANDOUT.
6824         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6825         New setter methods.
6826
6827 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6828
6829         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6830         Handle tabs.
6831
6832 2019-03-18  Tom Tromey  <tromey@adacore.com>
6833
6834         * ada-lang.c (empty_array): Add "high" parameter.
6835         (ada_evaluate_subexp): Update.
6836
6837 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6838
6839         * unittests/string_view-selftests.c: Define
6840         _initialize_string_view_selftests unconditionally.
6841
6842 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6843
6844         PR gdb/24350
6845         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6846
6847 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6848
6849         PR gdb/24351
6850         * windows-nat.c (display_selector): Fix format specifiers.
6851
6852 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6853
6854         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6855         tui_refill_source_window instead of tui_refresh_win, to update the
6856         current execution line.  This fixes redisplay of the current line
6857         when stepping through the code with "next" or "step".
6858
6859 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6860
6861         * source-cache.c (source_cache::get_source_lines): Call
6862         find_source_lines to initialize s->nlines.  This fixes vertical
6863         scrolling of TUI source window when the DOWN arrow is pressed.
6864
6865 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6866
6867         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6868         linux-thread-db.c (_initialize_thread_db): Likewise.
6869
6870 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6871
6872         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6873         wclrtoeol in tui_show_source_line".  This reverts changes made in
6874         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6875
6876 2019-03-15  Tom Tromey  <tom@tromey.com>
6877
6878         * symtab.h (struct minimal_symbol): Derive from
6879         general_symbol_info.
6880         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6881         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6882         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6883         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6884         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6885         (MSYMBOL_SEARCH_NAME): Update.
6886         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6887         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6888         * minsyms.c (minimal_symbol_reader::record_full): Update.
6889
6890 2019-03-15  Tom Tromey  <tom@tromey.com>
6891
6892         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6893
6894 2019-03-15  Tom Tromey  <tom@tromey.com>
6895
6896         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6897         unique_xmalloc_ptr.
6898         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6899         Update.
6900         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6901         (build_minimal_symbol_hash_tables)
6902         (minimal_symbol_reader::install): Update.
6903
6904 2019-03-15  Tom Tromey  <tom@tromey.com>
6905
6906         * symtab.c (create_demangled_names_hash): Update.
6907         (symbol_set_names): Update.
6908         * objfiles.h (struct objfile_per_bfd_storage)
6909         <demangled_names_hash>: Now an htab_up.
6910         * objfiles.c (objfile_per_bfd_storage): Simplify.
6911
6912 2019-03-15  Tom Tromey  <tom@tromey.com>
6913
6914         * objfiles.h (struct objfile_per_bfd_storage): Declare
6915         destructor.
6916         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6917         New.
6918         (get_objfile_bfd_data): Use new.  Don't initialize
6919         language_of_main.
6920         (free_objfile_per_bfd_storage): Remove.
6921         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6922
6923 2019-03-15  Tom Tromey  <tom@tromey.com>
6924
6925         * symfile.c (reread_symbols): Update.
6926         * objfiles.c (objfile::objfile): Update.
6927         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6928         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6929         comment.
6930         (minimal_symbol_reader::install): Update.
6931         (terminate_minimal_symbol_table): Remove.
6932         * jit.c (jit_object_close_impl): Update.
6933
6934 2019-03-15  Tom Tromey  <tom@tromey.com>
6935
6936         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6937         initializations.
6938
6939 2019-03-15  Tom Tromey  <tom@tromey.com>
6940
6941         * objfiles.h (struct objfile_per_bfd_storage)
6942         <demangled_hash_languages>: Now a bitset.
6943         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6944         (lookup_minimal_symbol): Update.
6945
6946 2019-03-15  Tom Tromey  <tom@tromey.com>
6947
6948         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6949         Don't return the symbol.
6950         * coffread.c (record_minimal_symbol): Use record_full.
6951
6952 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6953
6954         The MS-Windows port of ncurses fails to switch to a color pair if
6955         one or both of the colors are the implicit default colors.  This
6956         change records the default colors when TUI is initialized, and
6957         then specifies them explicitly when a color pair uses the default
6958         colors.  This allows color styling in TUI mode on MS-Windows.
6959
6960         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6961         ncurses_norm_attr.
6962         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6963         colors in ncurses_norm_attr.
6964         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6965         "none", replace it with the default color recorded in
6966         ncurses_norm_attr.
6967
6968 2019-03-14  Tom Tromey  <tromey@adacore.com>
6969
6970         * source-cache.h (class source_cache) <get_source_lines>: Return
6971         std::string.
6972         * source-cache.c (source_cache::extract_lines): Handle case where
6973         first_pos==npos.  Return std::string.
6974         (source_cache::get_source_lines): Update.
6975
6976 2019-03-14  Tom Tromey  <tromey@adacore.com>
6977
6978         * NEWS: Add item for "style sources" commands.
6979         * source-cache.c (source_cache::get_source_lines): Check
6980         source_styling.
6981         * cli/cli-style.c (source_styling): New global.
6982         (_initialize_cli_style): Add "style sources" commands.
6983         (show_style_sources): New function.
6984         * cli/cli-style.h (source_styling): Declare.
6985
6986 2019-03-14  Pedro Alves  <palves@redhat.com>
6987             Tom Tromey  <tromey@adacore.com>
6988
6989         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6990         * tui/tui-winsource.c (tui_refill_source_window): New function,
6991         from...
6992         (tui_horizontal_source_scroll): ... here.  Move some logic.
6993         * cli/cli-style.c (set_style_enabled): Notify new observable.
6994         * tui/tui-hooks.c (tui_redisplay_source): New function.
6995         (tui_attach_detach_observers): Attach or detach
6996         tui_redisplay_source.
6997         * observable.h (source_styling_changed): New observable.
6998         * observable.c: Define source_styling_changed observable.
6999
7000 2019-03-13  Tom Tromey  <tromey@adacore.com>
7001
7002         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7003         (i386_gnu_nat_target::store_registers): Update.
7004         * target-debug.h (target_debug_print_std_string): New macro.
7005         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7006         * windows-tdep.c (display_one_tib): Update.
7007         * tui/tui-stack.c (tui_make_status_line): Update.
7008         * top.c (print_inferior_quit_action): Update.
7009         * thread.c (thr_try_catch_cmd): Update.
7010         (add_thread_with_info): Update.
7011         (thread_target_id_str): Update.
7012         (thr_try_catch_cmd): Update.
7013         (thread_command): Update.
7014         (thread_find_command): Update.
7015         * record-btrace.c (record_btrace_target::info_record)
7016         (record_btrace_resume_thread, record_btrace_target::resume)
7017         (record_btrace_cancel_resume, record_btrace_step_thread)
7018         (record_btrace_target::wait, record_btrace_target::wait)
7019         (record_btrace_target::wait, record_btrace_target::stop): Update.
7020         * progspace.c (print_program_space): Update.
7021         * process-stratum-target.c
7022         (process_stratum_target::thread_address_space): Update.
7023         * linux-fork.c (linux_fork_mourn_inferior)
7024         (detach_checkpoint_command, info_checkpoints_command)
7025         (linux_fork_context): Update.
7026         (linux_fork_detach): Update.
7027         (class scoped_switch_fork_info): Update.
7028         (delete_checkpoint_command): Update.
7029         * infrun.c (follow_fork_inferior): Update.
7030         (follow_fork_inferior): Update.
7031         (proceed_after_vfork_done): Update.
7032         (handle_vfork_child_exec_or_exit): Update.
7033         (follow_exec): Update.
7034         (displaced_step_prepare_throw): Update.
7035         (displaced_step_restore): Update.
7036         (start_step_over): Update.
7037         (resume_1): Update.
7038         (clear_proceed_status_thread): Update.
7039         (proceed): Update.
7040         (print_target_wait_results): Update.
7041         (do_target_wait): Update.
7042         (context_switch): Update.
7043         (stop_all_threads): Update.
7044         (restart_threads): Update.
7045         (finish_step_over): Update.
7046         (handle_signal_stop): Update.
7047         (switch_back_to_stepped_thread): Update.
7048         (keep_going_pass_signal): Update.
7049         (print_exited_reason): Update.
7050         (normal_stop): Update.
7051         * inferior.c (inferior_pid_to_str): Change return type.
7052         (print_selected_inferior): Update.
7053         (add_inferior): Update.
7054         (detach_inferior): Update.
7055         * dummy-frame.c (fprint_dummy_frames): Update.
7056         * dcache.c (dcache_info_1): Update.
7057         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7058         (btrace_fetch, btrace_clear): Update.
7059         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7060         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7061         type.
7062         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7063         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7064         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7065         * gdbarch.c, gdbarch.h: Rebuild.
7066         * gdbarch.sh (core_pid_to_str): Change return type.
7067         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7068         return type.
7069         (windows_nat_target::pid_to_str): Change return type.
7070         (windows_delete_thread): Update.
7071         (windows_nat_target::attach): Update.
7072         (windows_nat_target::files_info): Update.
7073         * target-delegates.c: Rebuild.
7074         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7075         return type.
7076         (sol_thread_target::pid_to_str): Change return type.
7077         * remote.c (class remote_target) <pid_to_str>: Change return
7078         type.
7079         (remote_target::pid_to_str): Change return type.
7080         (extended_remote_target::attach, remote_target::remote_stop_ns)
7081         (remote_target::remote_notif_remove_queued_reply)
7082         (remote_target::push_stop_reply, remote_target::disable_btrace):
7083         Update.
7084         (extended_remote_target::attach): Update.
7085         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7086         type.
7087         (gdbsim_target::pid_to_str): Change return type.
7088         * ravenscar-thread.c (struct ravenscar_thread_target)
7089         <pid_to_str>: Change return type.
7090         (ravenscar_thread_target::pid_to_str): Change return type.
7091         * procfs.c (class procfs_target) <pid_to_str>: Change return
7092         type.
7093         (procfs_target::pid_to_str): Change return type.
7094         (procfs_target::attach): Update.
7095         (procfs_target::detach): Update.
7096         (procfs_target::fetch_registers): Update.
7097         (procfs_target::store_registers): Update.
7098         (procfs_target::wait): Update.
7099         (procfs_target::files_info): Update.
7100         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7101         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7102         return type.
7103         (nto_procfs_target::pid_to_str): Change return type.
7104         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7105         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7106         return type.
7107         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7108         (exit_lwp): Update.
7109         (attach_proc_task_lwp_callback, get_detach_signal)
7110         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7111         (linux_nat_target::resume, wait_lwp, stop_callback)
7112         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7113         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7114         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7115         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7116         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7117         type.
7118         (inf_ptrace_target::attach): Update.
7119         (inf_ptrace_target::files_info): Update.
7120         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7121         type.
7122         (go32_nat_target::pid_to_str): Change return type.
7123         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7124         (gnu_nat_target::wait): Update.
7125         (gnu_nat_target::wait): Update.
7126         (gnu_nat_target::resume): Update.
7127         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7128         (fbsd_nat_target::wait): Update.
7129         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7130         type.
7131         (darwin_nat_target::attach): Update.
7132         * corelow.c (class core_target) <pid_to_str>: Change return type.
7133         (core_target::pid_to_str): Change return type.
7134         * target.c (normal_pid_to_str): Change return type.
7135         (default_pid_to_str): Likewise.
7136         (target_pid_to_str): Change return type.
7137         (target_translate_tls_address): Update.
7138         (target_announce_detach): Update.
7139         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7140         return type.
7141         (bsd_uthread_target::pid_to_str): Change return type.
7142         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7143         type.
7144         (bsd_kvm_target::pid_to_str): Change return type.
7145         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7146         return type.
7147         (aix_thread_target::pid_to_str): Change return type.
7148         * target.h (struct target_ops) <pid_to_str>: Change return type.
7149         (target_pid_to_str, normal_pid_to_str): Likewise.
7150         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7151         type.
7152         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7153         type.
7154         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7155         return type.
7156         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7157         type.
7158         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7159         type.
7160         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7161         return type.
7162
7163 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7164
7165         * NEWS: Mention that the new default MI version is 3.  Mention
7166         changes to the output of commands and events that deal with
7167         multi-location breakpoints.
7168         * breakpoint.c: Include "mi/mi-out.h".
7169         (print_one_breakpoint): Change output syntax if using MI version
7170         >= 3.
7171         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7172         New.
7173         (mi_multi_location_breakpoint_output_fixed): New.
7174         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7175         (mi_cmd_fix_multi_location_breakpoint_output): New.
7176         (mi_multi_location_breakpoint_output_fixed): New.
7177         * mi/mi-cmds.c (mi_cmds): Register command
7178         -fix-multi-location-breakpoint-output.
7179         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7180         interpreter "mi".
7181
7182 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7183
7184         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7185         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7186         instantiate mi_ui_out based on interpreter name.
7187         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7188         * mi/mi-main.c (mi_load_progress): Likewise.
7189
7190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * NEWS: Combine separate "New targets" sections for 8.3.
7193
7194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7195
7196         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7197         (ppcfbsd_init_abi): Install gdbarch
7198         "fetch_tls_load_module_address" and "get_thread_local_address"
7199         methods.
7200
7201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7202
7203         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7204         (riscv_fbsd_init_abi): Install gdbarch
7205         "fetch_tls_load_module_address" and "get_thread_local_address"
7206         methods.
7207
7208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7209
7210         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7211         (i386fbsd_init_abi): Install gdbarch
7212         "fetch_tls_load_module_address" and "get_thread_local_address"
7213         methods.
7214
7215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7216
7217         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7218         (amd64fbsd_init_abi): Install gdbarch
7219         "fetch_tls_load_module_address" and "get_thread_local_address"
7220         methods.
7221
7222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7223
7224         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7225         (struct fbsd_pspace_data): New type.
7226         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7227         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7228         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7229         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7230         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7231
7232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7233
7234         * gdbtypes.c (lookup_struct_elt): New function.
7235         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7236         * gdbtypes.h (struct struct_elt): New type.
7237         (lookup_struct_elt): New prototype.
7238
7239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7240
7241         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7242         remove disabled code block.
7243
7244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7245
7246         * gdbarch.sh (get_thread_local_address): New method.
7247         * gdbarch.h, gdbarch.c: Regenerate.
7248         * target.c (target_translate_tls_address): Use
7249         gdbarch_get_thread_local_address if present instead of
7250         target::get_thread_local_address.
7251
7252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7253
7254         * target.h (target::get_thread_local_address): Update comment.
7255
7256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7257
7258         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7259         objfile->separate_debug_objfile_backlink if not NULL.
7260
7261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7262
7263         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7264         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7265         (amd64bsd_store_inferior_registers): Likewise.
7266         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7267         Enable segment base registers.
7268         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7269         PT_GETFSBASE and PT_GETGSBASE.
7270         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7271         PT_SETGSBASE.
7272         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7273         segment base registers.
7274         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7275
7276 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7277
7278         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7279         Update calls to i386_target_description to add 'segments'
7280         parameter.
7281         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7282         add segment base registers.
7283         * arch/i386.c (i386_create_target_description): Add 'segments'
7284         parameter to enable segment base registers.
7285         * arch/i386.h (i386_create_target_description): Likewise.
7286         * features/i386/32bit-segments.xml: New file.
7287         * features/i386/32bit-segments.c: Generate.
7288         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7289         call to i386_target_description to add 'segments' parameter.
7290         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7291         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7292         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7293         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7294         if feature is present.
7295         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7296         Add 'segments' parameter to call to i386_target_description.
7297         (i386_target_description): Add 'segments' parameter to enable
7298         segment base registers.
7299         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7300         to call to i386_target_description.
7301         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7302         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7303         Define I386_NUM_REGS.
7304         (i386_target_description): Add 'segments' parameter to enable
7305         segment base registers.
7306
7307 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7308
7309         PR/24325
7310         * source-cache.c: #undef open and close, to avoid unresolved
7311         externals during linking.
7312
7313 2019-03-12  Tom Tromey  <tromey@adacore.com>
7314
7315         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7316         const.  Add initializers.
7317         (_initialize_remote): Don't initialize ptid globals.
7318
7319 2019-03-12  Pedro Alves  <palves@redhat.com>
7320
7321         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7322
7323 2019-03-12  Pedro Alves  <palves@redhat.com>
7324
7325         * cp-name-parser.y (main): Remove unused 'len' variable.
7326
7327 2019-03-12  Tom Tromey  <tromey@adacore.com>
7328
7329         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7330         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7331
7332 2019-03-12  Tom Tromey  <tromey@adacore.com>
7333
7334         * linux-nat.c (iterate_over_lwps): Update.
7335         (stop_callback): Remove parameter.
7336         (stop_wait_callback, detach_callback, resume_set_callback)
7337         (select_singlestep_lwp_callback, set_ignore_sigint)
7338         (status_callback, resumed_callback, resume_clear_callback)
7339         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7340         data parameter.
7341         (linux_nat_target::detach, linux_nat_target::resume)
7342         (linux_stop_and_wait_all_lwps, select_event_lwp)
7343         (linux_nat_filter_event, linux_nat_wait_1)
7344         (linux_nat_target::kill, linux_nat_target::stop)
7345         (linux_nat_target::stop): Update.
7346         (linux_nat_resume_callback): Change type.
7347         (resume_stopped_resumed_lwps, count_events_callback)
7348         (select_event_lwp_callback): Likewise.
7349         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7350         * arm-linux-nat.c (struct update_registers_data): Remove.
7351         (update_registers_callback): Change type.
7352         (arm_linux_insert_hw_breakpoint1): Update.
7353         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7354         parameter.
7355         (x86_linux_dr_set_addr): Update.
7356         (x86_linux_dr_set_control): Update.
7357         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7358         (iterate_over_lwps): Use gdb::function_view.
7359         * nat/aarch64-linux-hw-point.c (struct
7360         aarch64_dr_update_callback_param): Remove.
7361         (debug_reg_change_callback): Change type.
7362         (aarch64_notify_debug_reg_change): Update.
7363         * s390-linux-nat.c (s390_refresh_per_info): Update.
7364
7365 2019-03-11  Tom Tromey  <tromey@adacore.com>
7366
7367         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7368         redundant assignment to "this_cu".
7369
7370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7371
7372         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7373
7374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7375
7376         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7377         from...
7378         (rank_one_type): ... this.
7379
7380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7381
7382         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7383         from...
7384         (rank_one_type): ... this.
7385
7386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7387
7388         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7389         from...
7390         (rank_one_type): ... this.
7391
7392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7393
7394         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7395         from...
7396         (rank_one_type): ... this.
7397
7398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7399
7400         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7401         from...
7402         (rank_one_type): ... this.
7403
7404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7405
7406         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7407         from...
7408         (rank_one_type): ... this.
7409
7410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7411
7412         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7413         from...
7414         (rank_one_type): ... this.
7415
7416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7417
7418         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7419         from...
7420         (rank_one_type): ... this.
7421
7422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7423
7424         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7425         from...
7426         (rank_one_type): ... this.
7427
7428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7429
7430         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7431         from...
7432         (rank_one_type): ... this.
7433
7434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7435
7436         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7437         from...
7438         (rank_one_type): ... this.
7439
7440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7441
7442         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7443         from...
7444         (rank_one_type): ... this.
7445
7446 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7447
7448         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7449         inferior-events' shows the example events.
7450
7451 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7452
7453         Support styling on native MS-Windows console
7454
7455         PR/24315
7456         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7457         on MS-Windows if $TERM is not defined.
7458
7459         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7460
7461         * posix-hdep.c (gdb_console_fputs):
7462         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7463         functions.
7464         * ui-file.h (gdb_console_fputs): Add prototype.
7465
7466         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7467         back to fputs only if the former returns zero.
7468
7469 2019-03-07  Tom Tromey  <tom@tromey.com>
7470
7471         * symmisc.c (print_symbol_bcache_statistics): Update.
7472         (print_objfile_statistics): Update.
7473         * symfile.c (allocate_symtab): Update.
7474         * stabsread.c: Don't include bcache.h.
7475         * psymtab.h (struct psymbol_bcache): Don't declare.
7476         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7477         (psymbol_bcache_init, psymbol_bcache_free)
7478         (psymbol_bcache_get_bcache): Don't declare.
7479         * psymtab.c (struct psymbol_bcache): Remove.
7480         (psymtab_storage::psymtab_storage): Update.
7481         (psymtab_storage::~psymtab_storage): Update.
7482         (psymbol_bcache_init, psymbol_bcache_free)
7483         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7484         (add_psymbol_to_bcache): Update.
7485         (allocate_psymtab): Update.
7486         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7487         macro_cache>: No longer pointers.
7488         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7489         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7490         * macrotab.c (macro_bcache): Update.
7491         * macroexp.c: Don't include bcache.h.
7492         * gdbtypes.c (check_types_worklist): Update.
7493         (types_deeply_equal): Remove TRY/CATCH.  Update.
7494         * elfread.c (elf_symtab_read): Update.
7495         * dwarf2read.c: Don't include bcache.h.
7496         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7497         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7498         (print_bcache_statistics, bcache_memory_used): Don't declare.
7499         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7500         methods.  Rename all data members.
7501         * bcache.c (struct bcache): Move to bcache.h.
7502         (bcache::expand_hash_table): Rename from expand_hash_table.
7503         (bcache): Remove.
7504         (bcache::insert): Rename from bcache_full.
7505         (bcache::compare): Rename from bcache_compare.
7506         (bcache_xmalloc): Remove.
7507         (bcache::~bcache): Rename from bcache_xfree.
7508         (bcache::print_statistics): Rename from print_bcache_statistics.
7509         (bcache::memory_used): Rename from bcache_memory_used.
7510
7511 2019-03-07  Pedro Alves  <palves@redhat.com>
7512
7513         * infrun.c (normal_stop): Also check for
7514         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7515
7516 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7517
7518         * f-lang.c (value_from_host_double): Moved to...
7519         * value.c (value_from_host_double): ...here.
7520         * value.h (value_from_host_double): Declare.
7521         * guile/scm-math.c (vlscm_convert_typed_number): Use
7522         value_from_host_double.
7523         (vlscm_convert_number): Likewise.
7524         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7525         * python/py-value.c (convert_value_from_python): Likewise.
7526
7527 2019-03-06  Tom Tromey  <tom@tromey.com>
7528
7529         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7530
7531 2019-03-06  Tom Tromey  <tom@tromey.com>
7532
7533         * utils.h (free_current_contents): Don't declare.
7534         * utils.c (free_current_contents): Remove.
7535
7536 2019-03-06  Tom Tromey  <tom@tromey.com>
7537
7538         * top.c (quit_force): Update.
7539         * main.c (captured_command_loop): Update.
7540         * common/new-op.c (operator new): Update.
7541         * common/common-exceptions.c (struct catcher)
7542         <save_cleanup_chain>: Remove member.
7543         (exceptions_state_mc_init): Update.
7544         (exception_try_scope_entry): Return nullptr.
7545         (exception_try_scope_exit, exception_rethrow)
7546         (throw_exception_sjlj, throw_exception_cxx): Update.
7547         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7548         (all_cleanups, do_cleanups, discard_cleanups)
7549         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7550         (restore_cleanups, restore_final_cleanups): Don't declare.
7551         (do_final_cleanups): Remove parameter.
7552         * common/cleanups.c (cleanup_chain, make_cleanup)
7553         (make_cleanup_dtor, all_cleanups, do_cleanups)
7554         (discard_my_cleanups, discard_cleanups)
7555         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7556         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7557         (null_cleanup): Remove.
7558         (do_final_cleanups): Remove parameter.
7559
7560 2019-03-06  Tom Tromey  <tom@tromey.com>
7561
7562         * remote.c (remote_target::remote_parse_stop_reply): Use
7563         unique_xmalloc_ptr.
7564
7565 2019-03-06  Tom Tromey  <tom@tromey.com>
7566
7567         * stabsread.c (struct stabs_field_info): Rename from field_info.
7568         <list, fnlist>: Add initializers.
7569         <obstack>: New member.
7570         (read_member_functions, read_struct_fields, read_baseclasses):
7571         Allocate on obstack.  Don't use cleanups.
7572         (read_one_struct_field, read_member_functions, read_struct_fields)
7573         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7574         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7575         (read_struct_type): Update.
7576
7577 2019-03-06  Tom Tromey  <tom@tromey.com>
7578
7579         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7580         * common/filestuff.h (make_cleanup_close): Don't declare.
7581         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7582         Remove.
7583
7584 2019-03-06  Tom Tromey  <tom@tromey.com>
7585
7586         * solib-aix.c: Use make_scope_exit.
7587
7588 2019-03-06  Tom Tromey  <tom@tromey.com>
7589
7590         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7591         Use make_scope_exit.
7592
7593 2019-03-06  Tom Tromey  <tom@tromey.com>
7594
7595         * solib-svr4.c (disable_probes_interface): Remove parameter.
7596         (svr4_handle_solib_event): Use make_scope_exit.
7597
7598 2019-03-06  Tom Tromey  <tom@tromey.com>
7599
7600         * remote.c (struct stop_reply_deleter): Remove.
7601         (stop_reply_up): Update.
7602         (struct stop_reply): Derive from notif_event.  Don't typedef.
7603         <regcache>: Now a std::vector.
7604         (stop_reply_xfree): Remove.
7605         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7606         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7607         (remote_target::discard_pending_stop_replies): Use delete.
7608         (remote_target::remote_parse_stop_reply): Update.
7609         (remote_target::process_stop_reply): Update.
7610         * remote-notif.h (struct notif_event): Add virtual destructor.
7611         Remove "dtr" member.
7612         (struct notif_client) <alloc_event>: Return a unique_ptr.
7613         (notif_event_xfree): Don't declare.
7614         (notif_event_up): New typedef.
7615         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7616         (notif_event_xfree, do_notif_event_xfree): Remove.
7617         (remote_notif_state_xfree): Update.
7618
7619 2019-03-06  Tom Tromey  <tom@tromey.com>
7620
7621         * infrun.c (displaced_step_clear_cleanup): Now a
7622         forward_scope_exit type.
7623         (displaced_step_prepare_throw): Update.
7624         (displaced_step_fixup): Update.
7625
7626 2019-03-06  Tom Tromey  <tom@tromey.com>
7627
7628         * inferior.h (class inferior): Update comment.
7629         * gdbthread.h (class thread_info): Update comment.
7630
7631 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7632             Tom Tromey  <tom@tromey.com>
7633
7634         * stabsread.h (struct stab_section_list): Remove.
7635         (coffstab_build_psymtabs): Update.
7636         * dbxread.c (symbuf_sections): Now a std::vector.
7637         (sect_idx): New global.
7638         (fill_symbuf): Update.
7639         (coffstab_build_psymtabs): Change type of stabsects parameter.
7640         Update.
7641         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7642         std::vector.
7643         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7644         (coff_locate_sections): Update.
7645         (coff_symfile_read): Remove cleanups.  Update.
7646         (init_stringtab): Add storage parameter.
7647         (free_stringtab, free_stringtab_cleanup): Remove.
7648         (init_lineno): Add storage parameter.
7649         (free_linetab, free_linetab_cleanup): Remove.
7650
7651 2019-03-06  Pedro Alves  <palves@redhat.com>
7652
7653         * linux-fork.c (fork_info::clobber_regs): Delete.
7654         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7655         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7656         comment.  Adjust.
7657         (scoped_switch_fork_info::scoped_switch_fork_info)
7658         (checkpoint_command, linux_fork_context): Adjust
7659         fork_save_infrun_state calls.
7660
7661 2019-03-06  Pedro Alves  <palves@redhat.com>
7662
7663         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7664         (inf_has_multiple_threads): Return 'bool' and rewrite using
7665         inferior_info::threads().
7666
7667 2019-03-06  Pedro Alves  <palves@redhat.com>
7668
7669         * linux-fork.c: Include <list>.
7670         (fork_list): Now a std::list instance.
7671         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7672         (forks_exist_p, find_last_fork): Adjust.
7673         (new_fork): Delete.
7674         (one_fork_p): New.
7675         (add_fork): Adjust.
7676         (free_fork): Delete, folded into fork_info::~fork_info().
7677         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7678         Adjust.
7679         (init_fork_list): Delete.
7680         (linux_fork_killall, linux_fork_mourn_inferior)
7681         (linux_fork_detach, info_checkpoints_command): Adjust.
7682         (_initialize_linux_fork): No longer call init_fork_list.
7683
7684 2019-03-06  Pedro Alves  <palves@redhat.com>
7685
7686         * linux-fork.c (new_fork): New, split out of ...
7687         (add_fork): ... this.  Return void.  Move "first fork" special
7688         case from here, to ...
7689         (checkpoint_command): ... here.
7690         * linux-linux.h (add_fork): Return void.
7691
7692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7695
7696 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7697             Chris January  <chris.january@arm.com>
7698             David Lecomber  <david.lecomber@arm.com>
7699
7700         * f-exp.y: New token, UNOP_INTRINSIC.
7701         (exp): New pattern using UNOP_INTRINSIC token.
7702         (f77_keywords): Add 'abs' keyword.
7703         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7704         (value_from_host_double): New function.
7705         (evaluate_subexp_f): Support UNOP_ABS.
7706
7707 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7708
7709         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7710         types.
7711
7712 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7713
7714         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7715         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7716         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7717
7718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7721
7722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7723             Chris January  <chris.january@arm.com>
7724
7725         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7726         * f-exp.y: Define 'KIND' token.
7727         (exp): New pattern for KIND expressions.
7728         (ptype): Handle types with a kind extension.
7729         (direct_abs_decl): Extend to spot kind extensions.
7730         (f77_keywords): Add 'kind' to the list.
7731         (push_kind_type): New function.
7732         (convert_to_kind_type): New function.
7733         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7734         * parse.c (operator_length_standard): Likewise.
7735         * parser-defs.h (enum type_pieces): Add tp_kind.
7736         * std-operator.def: Add UNOP_KIND.
7737
7738 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * f-exp.y (f_parse): Set yydebug.
7741
7742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * f-lang.c (evaluate_subexp_f): New function.
7745         (exp_descriptor_f): New global.
7746         (f_language_defn): Use exp_descriptor_f instead of
7747         exp_descriptor_standard.
7748
7749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * f-exp.y (struct token): Add comments.
7752         (dot_ops): Remove uppercase versions and the end marker.
7753         (f77_keywords): Likewise.
7754         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7755         entries in the dot_ops array are case insensitive, and use
7756         strncasecmp to compare strings.  Also some whitespace cleanup in
7757         this area.  Similar for the f77_keywords array, except entries in
7758         this list might be case sensitive.
7759
7760 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7761
7762         * f-exp.y (struct f77_boolean_val): Add comments.
7763         (boolean_values): Remove uppercase versions, and end marker.
7764         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7765         and use strncasecmp to achieve case insensitivity.  Additionally,
7766         perform whitespace cleanup around this code.
7767
7768 2019-03-06  Tom Tromey  <tromey@adacore.com>
7769
7770         * remote-sim.c (gdbsim_target_open): Use result of
7771         gdb_argv::release.
7772
7773 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7774         Dirk Schubert  <dirk.schubert@arm.com>
7775         Chris January  <chris.january@arm.com>
7776
7777         * eval.c (evaluate_subexp_standard): Call Fortran argument
7778         wrapping logic.
7779         * f-lang.c (struct value): A value which can be passed into a
7780         Fortran function call.
7781         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7782         where appropriate.
7783         (struct type): Value ready for a Fortran function call.
7784         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7785         is needed.
7786         * f-lang.h (fortran_argument_convert): Declaration.
7787         (fortran_preserve_arg_pointer): Declaration.
7788         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7789
7790 2019-03-05  Tom Tromey  <tromey@adacore.com>
7791
7792         * python/py-prettyprint.c (print_string_repr): Remove #if.
7793         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7794
7795 2019-03-05  Tom Tromey  <tromey@adacore.com>
7796
7797         * target.c (the_dummy_target): Move later.  Change type to
7798         "dummy_target".
7799         (initialize_targets): Don't initialize the_dummy_target.
7800
7801 2019-03-05  Tom Tromey  <tromey@adacore.com>
7802
7803         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7804         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7805
7806 2019-03-05  Tom Tromey  <tromey@adacore.com>
7807
7808         * windows-nat.c (windows_nat_target::attach)
7809         (windows_nat_target::detach): Don't call gdb_flush.
7810         * valprint.c (generic_val_print, val_print, val_print_string):
7811         Don't call gdb_flush.
7812         * utils.c (defaulted_query): Don't call gdb_flush.
7813         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7814         * target.c (target_announce_detach): Don't call gdb_flush.
7815         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7816         * remote.c (extended_remote_target::attach): Don't call
7817         gdb_flush.
7818         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7819         * printcmd.c (do_examine): Don't call gdb_flush.
7820         (info_display_command): Don't call gdb_flush.
7821         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7822         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7823         * memattr.c (info_mem_command): Don't call gdb_flush.
7824         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7825         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7826         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7827         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7828         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7829         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7830         (gnu_nat_target::detach): Don't call gdb_flush.
7831         * f-valprint.c (f_val_print): Don't call gdb_flush.
7832         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7833         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7834         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7835         gdb_flush.
7836         * c-valprint.c (c_val_print): Don't call gdb_flush.
7837         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7838
7839 2019-03-05  Tom Tromey  <tromey@adacore.com>
7840
7841         * varobj.c (update_dynamic_varobj_children): Update.
7842         (install_default_visualizer): Use reset, not release.
7843         * value.c (set_internalvar): Update.
7844         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7845         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7846         ATTRIBUTE_UNUSED_RESULT.
7847
7848 2019-03-05  Tom Tromey  <tromey@adacore.com>
7849
7850         * remote.c (class scoped_remote_fd) <release>: Add
7851         ATTRIBUTE_UNUSED_RESULT.
7852
7853 2019-03-05  Tom Tromey  <tromey@adacore.com>
7854
7855         * macroexp.c (struct macro_buffer) <release>: Add
7856         ATTRIBUTE_UNUSED_RESULT.
7857
7858 2019-03-05  Tom Tromey  <tromey@adacore.com>
7859
7860         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7861         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7862         ATTRIBUTE_UNUSED_RESULT.
7863
7864 2019-03-05  Tom Tromey  <tromey@adacore.com>
7865
7866         * common/scoped_fd.h (class scoped_fd) <release>: Add
7867         ATTRIBUTE_UNUSED_RESULT.
7868
7869 2019-03-05  Tom Tromey  <tromey@adacore.com>
7870
7871         * parser-defs.h (struct parser_state) <release>: Add
7872         ATTRIBUTE_UNUSED_RESULT.
7873
7874 2019-03-05  Tom Tromey  <tromey@adacore.com>
7875
7876         * utils.h (class gdb_argv) <release>: Add
7877         ATTRIBUTE_UNUSED_RESULT.
7878         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7879
7880 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7881
7882         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7883         for-loop range, to avoid compiler warnings.
7884
7885         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7886         avoid compiler warnings about unused variables.
7887
7888         * NEWS: Mention end of support for native debugging on MS-Windows
7889         before XP.
7890
7891         PR gdb/24292
7892         * common/netstuff.c:
7893         * gdbserver/gdbreplay.c
7894         * gdbserver/remote-utils.c:
7895         * ser-tcp.c:
7896         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7897         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7898         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7899         'getaddrinfo' and 'freeaddrinfo' were not available before
7900         Windows XP, and mingw.org's MinGW headers by default define
7901         _WIN32_WINNT to 0x500.
7902
7903 2019-03-01  Gary Benson <gbenson@redhat.com>
7904
7905         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7906
7907 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7908             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7909
7910         PR gdb/8527
7911         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7912         set_sigint_trap, clear_sigint_trap.
7913
7914 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7915
7916         * target.c (target_detach): Clear the regcache and the
7917         frame cache.
7918
7919 2019-02-27  Pedro Alves  <palves@redhat.com>
7920
7921         * utils.c (set_screen_size): When we cap the height/width sizes,
7922         tweak the corresponding command variable to show "unlimited":
7923
7924 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7925             Pedro Alves  <palves@redhat.com>
7926
7927         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7928         before calling rl_set_screen_size.
7929
7930 2019-02-27  Tom Tromey  <tromey@adacore.com>
7931
7932         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7933         define.
7934         * python/py-value.c: Remove Python 2.4 workaround.
7935         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7936         workaround.
7937         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7938         Python 2.4 workaround.
7939         * python/python-internal.h: Remove Python 2.4 comment.
7940         (Py_ssize_t): Don't define.
7941         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7942         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7943         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7944         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7945         * python/python.c (do_start_initialization): Remove Python 2.4
7946         workaround.
7947         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7948         (print_children): Remove Python 2.4 workaround.
7949         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7950         workaround.
7951         (CHARBUFFERPROC_NAME): Remove.
7952         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7953         Python 2.4 workaround.
7954
7955 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7956
7957         * NEWS: Note minimum Python version.
7958
7959 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7960
7961         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7962         code from these functions.  Remove corresponding ifdefs.  Use
7963         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7964         Remove gotos and target of gotos.
7965         (infpy_search_memory): Likewise.
7966
7967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7968
7969         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7970         (hppa_gdbarch_init): Don't register deleted functions with
7971         gdbarch.
7972
7973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7974
7975         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7976         (h8300_unwind_sp): Delete.
7977         (h8300_dummy_id): Delete.
7978         (h8300_gdbarch_init): Don't register deleted functions with
7979         gdbarch.
7980
7981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7984         (ft32_unwind_pc): Delete.
7985         (ft32_unwind_sp): Delete.
7986         (ft32_gdbarch_init): Don't register deleted functions with
7987         gdbarch.
7988
7989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7990
7991         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7992         (frv_unwind_pc): Delete.
7993         (frv_unwind_sp): Delete.
7994         (frv_gdbarch_init): Don't register deleted functions with
7995         gdbarch.
7996
7997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7998
7999         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8000         (riscv_unwind_pc): Delete.
8001         (riscv_unwind_sp): Delete.
8002         (riscv_gdbarch_init): Don't register deleted functions with
8003         gdbarch.
8004
8005 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8006
8007         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8008         (csky_unwind_pc): Delete.
8009         (csky_unwind_sp): Delete.
8010         (csky_gdbarch_init): Don't register deleted functions with
8011         gdbarch.
8012
8013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8016         (cris_unwind_pc): Delete.
8017         (cris_unwind_sp): Delete.
8018         (cris_gdbarch_init): Don't register deleted functions with
8019         gdbarch.
8020
8021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8022
8023         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8024         (bfin_unwind_pc): Delete.
8025         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8026
8027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8028
8029         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8030         (arm_unwind_pc): Delete.
8031         (arm_unwind_sp): Delete.
8032         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8033
8034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8037         (arc_unwind_pc): Delete.
8038         (arc_unwind_sp): Delete.
8039         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8040
8041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8042
8043         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8044         (alpha_unwind_pc): Delete.
8045         (alpha_gdbarch_init): Don't register deleted functions with
8046         gdbarch.
8047
8048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8051         (aarch64_unwind_pc): Delete.
8052         (aarch64_unwind_sp): Delete.
8053         (aarch64_gdbarch_init): Don't register deleted functions with
8054         gdbarch.
8055
8056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * gdbtypes.c (type_align): Don't consider static members when
8059         computing structure alignment.
8060
8061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8064         return 0 for other types.
8065         * arch-utils.c (default_type_align): Always return 0.
8066         * gdbarch.h: Regenerate.
8067         * gdbarch.sh (type_align): Extend comment.
8068         * gdbtypes.c (type_align): Add additional comments, always call
8069         gdbarch_type_align before applying the default rules.
8070         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8071         generic code will then apply a suitable default.
8072         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8073         types, return 0 for other types.
8074
8075 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8076
8077         * NEWS: Create a new section for the next release branch.
8078         Rename the section of the current branch, now that it has
8079         been cut.
8080
8081 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8082
8083         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8084         * version.in: Bump version to 8.3.50.DATE-git.
8085
8086 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8087
8088         * aix-thread.c (ptid_cmp): Remove unused variable.
8089         (get_signaled_thread): Likewise.
8090         (store_regs_user_thread): Likewise.
8091         (store_regs_kernel_thread): Likewise.
8092         (fetch_regs_kernel_thread): Remove shadowed variable.
8093
8094 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * features/riscv/32bit-cpu.xml: Add register numbers.
8097         * features/riscv/32bit-fpu.c: Regenerate.
8098         * features/riscv/32bit-fpu.xml: Add register numbers.
8099         * features/riscv/64bit-cpu.xml: Add register numbers.
8100         * features/riscv/64bit-fpu.c: Regenerate.
8101         * features/riscv/64bit-fpu.xml: Add register numbers.
8102
8103 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8104
8105         * NEWS: Mention two argument form of gdb.Value constructor.
8106         * python/py-value.c (convert_buffer_and_type_to_value): New
8107         function.
8108         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8109         Add support for handling an optional second argument.  Call
8110         convert_buffer_and_type_to_value as appropriate.
8111         * python/python-internal.h (Py_buffer_deleter): New struct.
8112         (Py_buffer_up): New typedef.
8113
8114 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8115
8116         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8117         instead of releasing ownership.
8118
8119 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8120
8121         * dwarf2read.c (open_and_init_dwp_file): Call
8122         elf_numsections instead of bfd_count_sections to initialize
8123         dwp_file->num_sections.
8124
8125 2019-02-25  Tom Tromey  <tromey@adacore.com>
8126
8127         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8128
8129 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8130
8131         * gcore.in: Add '--readnever' option when invoking GDB.
8132
8133 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8134
8135         * MAINTAINERS: Update my email address.
8136
8137 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8138
8139         * build-id.c (build_id_to_debug_bfd_1): New function.
8140         (build_id_to_debug_bfd): Look for separate debug file in
8141         sysroot.
8142
8143 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * gdbarch.sh: Update the copyright year range that is placed into
8146         generated files.
8147
8148 2019-02-22  Keith Seitz  <keiths@redhat.com>
8149
8150         PR symtab/23853
8151         * linespec.c (create_sals_line_offset): Search for the default
8152         symtab's filename instead of its fullname.
8153
8154 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8155
8156         * NEWS: Update style defaults.
8157
8158 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8159
8160         * main.c (captured_main_1): Disable styling in batch mode.
8161
8162 2019-02-20  Tom Tromey  <tom@tromey.com>
8163
8164         * symtab.c (symtab_symbol_info): Fix typos.
8165
8166 2019-02-20  Tom Tromey  <tromey@adacore.com>
8167
8168         * findcmd.c (_initialize_mem_search): Use upper case for
8169         metasyntactic variables.
8170
8171 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8172
8173         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8174         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8175
8176 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8177
8178         * top.h (source_file_name): Change to std::string.
8179         * top.c (source_file_name): Likewise.
8180         (command_line_input): Adjust.
8181         * cli/cli-script.c (script_from_file): Adjust.
8182
8183 2019-02-19  Tom Tromey  <tromey@adacore.com>
8184
8185         * ravenscar-thread.c
8186         (ravenscar_thread_target::update_thread_list): Don't call
8187         ada_build_task_list.
8188         * ada-lang.h (ada_build_task_list): Don't declare.
8189         * ada-tasks.c (struct ada_tasks_inferior_data)
8190         <task_list_valid_p>: Now bool.
8191         (read_known_tasks, ada_task_list_changed)
8192         (ada_tasks_invalidate_inferior_data): Update.
8193         (read_known_tasks_array): Return bool.
8194         (read_known_tasks_list): Likewise.
8195         (read_known_tasks): Return void.
8196         (ada_build_task_list): Now static.
8197
8198 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8201         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8202
8203 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8204
8205         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8206         variant for ada_tasks_pspace_data_handle and
8207         ada_tasks_inferior_data_handle.
8208         (ada_tasks_pspace_data_cleanup): New function.
8209         (ada_tasks_inferior_data_cleanup): New function.
8210
8211 2019-02-17  Tom Tromey  <tom@tromey.com>
8212
8213         * macrotab.h (macro_source_fullname): Return a std::string.
8214         * macrotab.c (macro_include, check_for_redefinition)
8215         (macro_undef, macro_lookup_definition, foreach_macro)
8216         (foreach_macro_in_scope): Update.
8217         (macro_source_fullname): Return a std::string.
8218         * macrocmd.c (show_pp_source_pos): Update.
8219
8220 2019-02-17  Tom Tromey  <tom@tromey.com>
8221
8222         * macrocmd.c (show_pp_source_pos): Style the file names.
8223
8224 2019-02-17  Tom Tromey  <tom@tromey.com>
8225
8226         PR tui/24197:
8227         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8228
8229 2019-02-17  Tom Tromey  <tom@tromey.com>
8230
8231         * ada-lang.c (user_select_syms): Use filtered printing.
8232         * utils.c (wrap_style): New global.
8233         (desired_style): Remove.
8234         (emit_style_escape): Add stream parameter.
8235         (set_output_style, reset_terminal_style, prompt_for_continue):
8236         Update.
8237         (flush_wrap_buffer): Only flush gdb_stdout.
8238         (wrap_here): Set wrap_style.
8239         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8240         treat escape sequences as a character.  Change when wrap buffer is
8241         flushed.
8242         (fputs_styled): Do not set the output style when the default is
8243         requested.
8244         * ui-style.h (struct ui_file_style) <is_default>: New method.
8245         * source.c (print_source_lines_base): Emit escape sequences in one
8246         piece.
8247
8248 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8249
8250         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8251         integers and enumeration types.
8252
8253 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8254
8255         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8256         instead of lookup_symbol_in_language
8257         (do_exact_match): New function.
8258         (ada_get_symbol_name_matcher): Return do_exact_match when
8259         doing a verbatim match.
8260
8261 2019-02-15  Tom Tromey  <tromey@adacore.com>
8262
8263         * ravenscar-thread.c (ravenscar_thread_target::resume)
8264         (ravenscar_thread_target::wait): Special case wildcard requests.
8265
8266 2019-02-15  Tom Tromey  <tromey@adacore.com>
8267
8268         * ravenscar-thread.c (base_ptid): Remove.
8269         (struct ravenscar_thread_target) <close>: New method.
8270         <m_base_ptid>: New member.
8271         <update_inferior_ptid, active_task, task_is_currently_active,
8272         runtime_initialized>: Declare methods.
8273         <ravenscar_thread_target>: Add constructor.
8274         (ravenscar_thread_target::task_is_currently_active)
8275         (ravenscar_thread_target::update_inferior_ptid)
8276         (ravenscar_runtime_initialized): Rename.  Now methods.
8277         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8278         (ravenscar_thread_target::update_thread_list): Update.
8279         (ravenscar_thread_target::active_task): Now method.
8280         (ravenscar_thread_target::store_registers)
8281         (ravenscar_thread_target::prepare_to_store)
8282         (ravenscar_thread_target::prepare_to_store)
8283         (ravenscar_thread_target::mourn_inferior): Update.
8284         (ravenscar_inferior_created): Use "new" to create target.
8285         (ravenscar_thread_target::get_ada_task_ptid): Update.
8286         (_initialize_ravenscar): Don't initialize base_ptid.
8287         (ravenscar_ops): Remove global.
8288
8289 2019-02-15  Tom Tromey  <tromey@adacore.com>
8290
8291         * target.h (push_target): Declare new overload.
8292         * target.c (push_target): New overload, taking an rvalue reference.
8293         * remote.c (remote_target::open_1): Use push_target overload.
8294         * corelow.c (core_target_open): Use push_target overload.
8295
8296 2019-02-15  Tom Tromey  <tromey@adacore.com>
8297
8298         * ravenscar-thread.c (is_ravenscar_task)
8299         (ravenscar_task_is_currently_active): Return bool.
8300         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8301         (_initialize_ravenscar): Remove "(void)".
8302         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8303         Return bool.
8304
8305 2019-02-15  Tom Tromey  <tromey@adacore.com>
8306
8307         * ravenscar-thread.c (ravenscar_runtime_initializer)
8308         (has_ravenscar_runtime, get_running_thread_id)
8309         (ravenscar_thread_target::resume): Fix indentation.
8310
8311 2019-02-15  Tom Tromey  <tromey@adacore.com>
8312
8313         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8314         from ravenscar_arch_ops.
8315         (sparc_ravenscar_ops::fetch_registers)
8316         (sparc_ravenscar_ops::store_registers): Now methods.
8317         (sparc_ravenscar_prepare_to_store): Remove.
8318         (sparc_ravenscar_ops): Redefine.
8319         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8320         methods and destructor.  Remove members.
8321         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8322         (ravenscar_thread_target::store_registers)
8323         (ravenscar_thread_target::prepare_to_store): Update.
8324         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8325         Remove.
8326         (struct ppc_ravenscar_powerpc_ops): Derive from
8327         ravenscar_arch_ops.
8328         (ppc_ravenscar_powerpc_ops::fetch_registers)
8329         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8330         (ppc_ravenscar_powerpc_ops): Redefine.
8331         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8332         (ppc_ravenscar_e500_ops::fetch_registers)
8333         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8334         (ppc_ravenscar_e500_ops): Redefine.
8335         * aarch64-ravenscar-thread.c
8336         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8337         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8338         (aarch64_ravenscar_fetch_registers)
8339         (aarch64_ravenscar_store_registers): Now methods.
8340         (aarch64_ravenscar_ops): Redefine.
8341
8342 2019-02-15  Tom Tromey  <tromey@adacore.com>
8343
8344         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8345         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8346         (ravenscar_thread_target::stopped_by_watchpoint)
8347         (ravenscar_thread_target::stopped_data_address)
8348         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8349
8350 2019-02-15  Tom Tromey  <tromey@adacore.com>
8351
8352         * ravenscar-thread.c: Fix some typos.
8353
8354 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8355             Tom Tromey  <tromey@adacore.com>
8356
8357         * ada-lang.c (ada_exception_sal): Change addr_string to a
8358         std::string.
8359         (create_ada_exception_catchpoint): Update.
8360
8361 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8362             Tom Tromey  <tromey@adacore.com>
8363
8364         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8365         (bp_location_ops): Remove.
8366         (base_breakpoint_allocate_location): Update.
8367         (free_bp_location): Update.
8368         * ada-lang.c (class ada_catchpoint_location)
8369         <ada_catchpoint_location>: Remove ops parameter.
8370         (ada_catchpoint_location_dtor): Remove.
8371         (ada_catchpoint_location_ops): Remove.
8372         (allocate_location_exception): Update.
8373         * breakpoint.h (struct bp_location_ops): Remove.
8374         (class bp_location) <bp_location>: Remove bp_location_ops
8375         parameter.
8376         <~bp_location>: Add destructor.
8377         <ops>: Remove.
8378
8379 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8380             Pedro Alves  <palves@redhat.com>
8381
8382         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8383         'PATH_MAX'.
8384
8385 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8386             Samuel Thibault  <samuel.thibault@gnu.org>
8387             Thomas Schwinge  <thomas@codesourcery.com>
8388
8389         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8390         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8391
8392 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8393
8394         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8395         (check_empty): Use "const char *".
8396
8397         * gnu-nat.c (gnu_nat_target::detach): Instead of
8398         'detach_inferior (pid)' call
8399         'detach_inferior (find_inferior_pid (pid))'.
8400
8401         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8402         'nat/fork-inferior.o'.
8403         * gnu-nat.c: #include "nat/fork-inferior.h".
8404
8405         * gnu-nat.c (gnu_nat_target::detach): Instead of
8406         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8407         * gnu-nat.h: #include "inf-child.h".
8408         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8409         'i386_gnu_nat_target::fetch_registers'.
8410         (gnu_store_registers): Rename/move to
8411         'i386_gnu_nat_target::store_registers'.
8412
8413         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8414         * gnu-nat.h (mach_thread_info): New function.
8415         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8416
8417         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8418
8419 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8420
8421         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8422
8423 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8424
8425         * windows-nat.c (windows_add_thread): Add new parameter
8426         "main_thread_p" with default value set to false.  Update
8427         function documentation as well as all callers.
8428         (windows_delete_thread): Likewise.
8429         (fake_create_process): Update call to windows_add_thread.
8430         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8431         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8432         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8433         call to windows_delete_thread.
8434
8435 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8436
8437         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8438
8439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8440
8441         * symfile.c (find_separate_debug_file): Use canonical path of
8442         sysroot with child_path instead of gdb_sysroot if it is valid.
8443
8444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8445
8446         * symfile.c (find_separate_debug_file): Use child_path to
8447         determine if an object file is under a sysroot.
8448
8449 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8450
8451         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8452         unittests/child-path-selftests.c.
8453         * common/pathstuff.c (child_path): New function.
8454         * common/pathstuff.h (child_path): New prototype.
8455         * unittests/child-path-selftests.c: New file.
8456
8457 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8458
8459         * symfile.c (find_separate_debug_file): Look for separate debug
8460         files in debug directories under the sysroot.
8461
8462 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8463
8464         * symtab.h (struct minimal_symbol data_p): New const method.
8465         (struct minimal_symbol text_p): Likewise.
8466         * symtab.c (output_source_filename): Use file name style
8467         to print file name.
8468         (print_symbol_info): Likewise.
8469         (print_msymbol_info): Use address style to print addresses.
8470         Use function name style to print executable text symbols.
8471         (expand_symtab_containing_pc): Use data_p.
8472         (find_pc_sect_compunit_symtab): Likewise.
8473
8474 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8475
8476         * breakpoint.c (describe_other_breakpoints): Use address style
8477         to print addresses.
8478         (say_where): Likewise.
8479
8480 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8481
8482         * ada-typeprint.c (print_func_type): Print function name
8483         style to print function name.
8484         * c-typeprint.c (c_print_type_1): Likewise.
8485
8486 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8487
8488         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8489         for execve.
8490
8491 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8492
8493         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8494         type_stack.
8495
8496 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8497
8498         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8499         TYPE_CODE_REF types.
8500
8501 2019-02-08  Jim Wilson  <jimw@sifive.com>
8502
8503         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8504         (riscv_linux_fregset): New.
8505         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8506
8507 2019-02-07  Tom Tromey  <tom@tromey.com>
8508
8509         * thread.c (thread_cancel_execution_command): Update.
8510         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8511         methods.
8512         (struct thread_fsm_ops): Remove.
8513         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8514         (thread_fsm_should_stop, thread_fsm_return_value)
8515         (thread_fsm_set_finished, thread_fsm_finished_p)
8516         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8517         Don't declare.
8518         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8519         * infrun.c (clear_proceed_status_thread)
8520         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8521         (print_stop_event): Update.
8522         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8523         Add constructor.
8524         (step_command_fsm_ops): Remove.
8525         (new_step_command_fsm): Remove.
8526         (step_1): Update.
8527         (step_command_fsm::should_stop): Rename from
8528         step_command_fsm_should_stop.
8529         (step_command_fsm::clean_up): Rename from
8530         step_command_fsm_clean_up.
8531         (step_command_fsm::do_async_reply_reason): Rename from
8532         step_command_fsm_async_reply_reason.
8533         (struct until_next_fsm): Inherit from thread_fsm.  Add
8534         constructor.
8535         (until_next_fsm_ops): Remove.
8536         (new_until_next_fsm): Remove.
8537         (until_next_fsm::should_stop): Rename from
8538         until_next_fsm_should_stop.
8539         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8540         (until_next_fsm::do_async_reply_reason): Rename from
8541         until_next_fsm_async_reply_reason.
8542         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8543         constructor.  Change type of breakpoint.
8544         (finish_command_fsm_ops): Remove.
8545         (new_finish_command_fsm): Remove.
8546         (finish_command_fsm::should_stop): Rename from
8547         finish_command_fsm_should_stop.
8548         (finish_command_fsm::clean_up): Rename from
8549         finish_command_fsm_clean_up.
8550         (finish_command_fsm::return_value): Rename from
8551         finish_command_fsm_return_value.
8552         (finish_command_fsm::do_async_reply_reason): Rename from
8553         finish_command_fsm_async_reply_reason.
8554         (finish_command): Update.
8555         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8556         Add constructor.
8557         (call_thread_fsm_ops): Remove.
8558         (call_thread_fsm::call_thread_fsm): Rename from
8559         new_call_thread_fsm.
8560         (call_thread_fsm::should_stop): Rename from
8561         call_thread_fsm_should_stop.
8562         (call_thread_fsm::should_notify_stop): Rename from
8563         call_thread_fsm_should_notify_stop.
8564         (run_inferior_call, call_function_by_hand_dummy): Update.
8565         * cli/cli-interp.c (should_print_stop_to_console): Update.
8566         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8567         Add constructor.  Change type of location_breakpoint,
8568         caller_breakpoint.
8569         (until_break_fsm_ops): Remove.
8570         (new_until_break_fsm): Remove.
8571         (until_break_fsm::should_stop): Rename from
8572         until_break_fsm_should_stop.
8573         (until_break_fsm::clean_up): Rename from
8574         until_break_fsm_clean_up.
8575         (until_break_fsm::do_async_reply_reason): Rename from
8576         until_break_fsm_async_reply_reason.
8577         (until_break_command): Update.
8578         * thread-fsm.c: Remove.
8579         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8580
8581 2019-02-07  Tom Tromey  <tom@tromey.com>
8582
8583         * yy-remap.h: Add include guard.
8584         * xtensa-tdep.h: Add include guard.
8585         * xcoffread.h: Rename include guard.
8586         * varobj-iter.h: Add include guard.
8587         * tui/tui.h: Rename include guard.
8588         * tui/tui-winsource.h: Rename include guard.
8589         * tui/tui-wingeneral.h: Rename include guard.
8590         * tui/tui-windata.h: Rename include guard.
8591         * tui/tui-win.h: Rename include guard.
8592         * tui/tui-stack.h: Rename include guard.
8593         * tui/tui-source.h: Rename include guard.
8594         * tui/tui-regs.h: Rename include guard.
8595         * tui/tui-out.h: Rename include guard.
8596         * tui/tui-layout.h: Rename include guard.
8597         * tui/tui-io.h: Rename include guard.
8598         * tui/tui-hooks.h: Rename include guard.
8599         * tui/tui-file.h: Rename include guard.
8600         * tui/tui-disasm.h: Rename include guard.
8601         * tui/tui-data.h: Rename include guard.
8602         * tui/tui-command.h: Rename include guard.
8603         * tic6x-tdep.h: Add include guard.
8604         * target/waitstatus.h: Rename include guard.
8605         * target/wait.h: Rename include guard.
8606         * target/target.h: Rename include guard.
8607         * target/resume.h: Rename include guard.
8608         * target-float.h: Rename include guard.
8609         * stabsread.h: Add include guard.
8610         * rs6000-tdep.h: Add include guard.
8611         * riscv-fbsd-tdep.h: Add include guard.
8612         * regformats/regdef.h: Rename include guard.
8613         * record.h: Rename include guard.
8614         * python/python.h: Rename include guard.
8615         * python/python-internal.h: Rename include guard.
8616         * python/py-stopevent.h: Rename include guard.
8617         * python/py-ref.h: Rename include guard.
8618         * python/py-record.h: Rename include guard.
8619         * python/py-record-full.h: Rename include guard.
8620         * python/py-record-btrace.h: Rename include guard.
8621         * python/py-instruction.h: Rename include guard.
8622         * python/py-events.h: Rename include guard.
8623         * python/py-event.h: Rename include guard.
8624         * procfs.h: Add include guard.
8625         * proc-utils.h: Add include guard.
8626         * p-lang.h: Add include guard.
8627         * or1k-tdep.h: Rename include guard.
8628         * observable.h: Rename include guard.
8629         * nto-tdep.h: Rename include guard.
8630         * nat/x86-linux.h: Rename include guard.
8631         * nat/x86-linux-dregs.h: Rename include guard.
8632         * nat/x86-gcc-cpuid.h: Add include guard.
8633         * nat/x86-dregs.h: Rename include guard.
8634         * nat/x86-cpuid.h: Rename include guard.
8635         * nat/ppc-linux.h: Rename include guard.
8636         * nat/mips-linux-watch.h: Rename include guard.
8637         * nat/linux-waitpid.h: Rename include guard.
8638         * nat/linux-ptrace.h: Rename include guard.
8639         * nat/linux-procfs.h: Rename include guard.
8640         * nat/linux-osdata.h: Rename include guard.
8641         * nat/linux-nat.h: Rename include guard.
8642         * nat/linux-namespaces.h: Rename include guard.
8643         * nat/linux-btrace.h: Rename include guard.
8644         * nat/glibc_thread_db.h: Rename include guard.
8645         * nat/gdb_thread_db.h: Rename include guard.
8646         * nat/gdb_ptrace.h: Rename include guard.
8647         * nat/fork-inferior.h: Rename include guard.
8648         * nat/amd64-linux-siginfo.h: Rename include guard.
8649         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8650         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8651         * nat/aarch64-linux.h: Rename include guard.
8652         * nat/aarch64-linux-hw-point.h: Rename include guard.
8653         * mn10300-tdep.h: Add include guard.
8654         * mips-linux-tdep.h: Add include guard.
8655         * mi/mi-parse.h: Rename include guard.
8656         * mi/mi-out.h: Rename include guard.
8657         * mi/mi-main.h: Rename include guard.
8658         * mi/mi-interp.h: Rename include guard.
8659         * mi/mi-getopt.h: Rename include guard.
8660         * mi/mi-console.h: Rename include guard.
8661         * mi/mi-common.h: Rename include guard.
8662         * mi/mi-cmds.h: Rename include guard.
8663         * mi/mi-cmd-break.h: Rename include guard.
8664         * m2-lang.h: Add include guard.
8665         * location.h: Rename include guard.
8666         * linux-record.h: Rename include guard.
8667         * linux-nat.h: Add include guard.
8668         * linux-fork.h: Add include guard.
8669         * i386-darwin-tdep.h: Rename include guard.
8670         * hppa-linux-offsets.h: Add include guard.
8671         * guile/guile.h: Rename include guard.
8672         * guile/guile-internal.h: Rename include guard.
8673         * gnu-nat.h: Rename include guard.
8674         * gdb-stabs.h: Rename include guard.
8675         * frv-tdep.h: Add include guard.
8676         * f-lang.h: Add include guard.
8677         * event-loop.h: Add include guard.
8678         * darwin-nat.h: Rename include guard.
8679         * cp-abi.h: Rename include guard.
8680         * config/sparc/nm-sol2.h: Rename include guard.
8681         * config/nm-nto.h: Rename include guard.
8682         * config/nm-linux.h: Add include guard.
8683         * config/i386/nm-i386gnu.h: Rename include guard.
8684         * config/djgpp/nl_types.h: Rename include guard.
8685         * config/djgpp/langinfo.h: Rename include guard.
8686         * compile/gcc-cp-plugin.h: Add include guard.
8687         * compile/gcc-c-plugin.h: Add include guard.
8688         * compile/compile.h: Rename include guard.
8689         * compile/compile-object-run.h: Rename include guard.
8690         * compile/compile-object-load.h: Rename include guard.
8691         * compile/compile-internal.h: Rename include guard.
8692         * compile/compile-cplus.h: Rename include guard.
8693         * compile/compile-c.h: Rename include guard.
8694         * common/xml-utils.h: Rename include guard.
8695         * common/x86-xstate.h: Rename include guard.
8696         * common/version.h: Rename include guard.
8697         * common/vec.h: Rename include guard.
8698         * common/tdesc.h: Rename include guard.
8699         * common/selftest.h: Rename include guard.
8700         * common/scoped_restore.h: Rename include guard.
8701         * common/scoped_mmap.h: Rename include guard.
8702         * common/scoped_fd.h: Rename include guard.
8703         * common/safe-iterator.h: Rename include guard.
8704         * common/run-time-clock.h: Rename include guard.
8705         * common/refcounted-object.h: Rename include guard.
8706         * common/queue.h: Rename include guard.
8707         * common/ptid.h: Rename include guard.
8708         * common/print-utils.h: Rename include guard.
8709         * common/preprocessor.h: Rename include guard.
8710         * common/pathstuff.h: Rename include guard.
8711         * common/observable.h: Rename include guard.
8712         * common/netstuff.h: Rename include guard.
8713         * common/job-control.h: Rename include guard.
8714         * common/host-defs.h: Rename include guard.
8715         * common/gdb_wait.h: Rename include guard.
8716         * common/gdb_vecs.h: Rename include guard.
8717         * common/gdb_unlinker.h: Rename include guard.
8718         * common/gdb_unique_ptr.h: Rename include guard.
8719         * common/gdb_tilde_expand.h: Rename include guard.
8720         * common/gdb_sys_time.h: Rename include guard.
8721         * common/gdb_string_view.h: Rename include guard.
8722         * common/gdb_splay_tree.h: Rename include guard.
8723         * common/gdb_setjmp.h: Rename include guard.
8724         * common/gdb_ref_ptr.h: Rename include guard.
8725         * common/gdb_optional.h: Rename include guard.
8726         * common/gdb_locale.h: Rename include guard.
8727         * common/gdb_assert.h: Rename include guard.
8728         * common/filtered-iterator.h: Rename include guard.
8729         * common/filestuff.h: Rename include guard.
8730         * common/fileio.h: Rename include guard.
8731         * common/environ.h: Rename include guard.
8732         * common/common-utils.h: Rename include guard.
8733         * common/common-types.h: Rename include guard.
8734         * common/common-regcache.h: Rename include guard.
8735         * common/common-inferior.h: Rename include guard.
8736         * common/common-gdbthread.h: Rename include guard.
8737         * common/common-exceptions.h: Rename include guard.
8738         * common/common-defs.h: Rename include guard.
8739         * common/common-debug.h: Rename include guard.
8740         * common/cleanups.h: Rename include guard.
8741         * common/buffer.h: Rename include guard.
8742         * common/btrace-common.h: Rename include guard.
8743         * common/break-common.h: Rename include guard.
8744         * cli/cli-utils.h: Rename include guard.
8745         * cli/cli-style.h: Rename include guard.
8746         * cli/cli-setshow.h: Rename include guard.
8747         * cli/cli-script.h: Rename include guard.
8748         * cli/cli-interp.h: Rename include guard.
8749         * cli/cli-decode.h: Rename include guard.
8750         * cli/cli-cmds.h: Rename include guard.
8751         * charset-list.h: Add include guard.
8752         * buildsym-legacy.h: Rename include guard.
8753         * bfin-tdep.h: Add include guard.
8754         * ax.h: Rename include guard.
8755         * arm-linux-tdep.h: Add include guard.
8756         * arm-fbsd-tdep.h: Add include guard.
8757         * arch/xtensa.h: Rename include guard.
8758         * arch/tic6x.h: Add include guard.
8759         * arch/i386.h: Add include guard.
8760         * arch/arm.h: Rename include guard.
8761         * arch/arm-linux.h: Rename include guard.
8762         * arch/arm-get-next-pcs.h: Rename include guard.
8763         * arch/amd64.h: Add include guard.
8764         * arch/aarch64-insn.h: Rename include guard.
8765         * arch-utils.h: Rename include guard.
8766         * annotate.h: Add include guard.
8767         * amd64-darwin-tdep.h: Rename include guard.
8768         * aarch64-linux-tdep.h: Add include guard.
8769         * aarch64-fbsd-tdep.h: Add include guard.
8770         * aarch32-linux-nat.h: Add include guard.
8771
8772 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8773
8774         * macrotab.c (macro_define_internal): New function that
8775         factorizes macro_define_object_internal and macro_define_function
8776         code.
8777         (macro_define_object_internal): Use macro_define_internal.
8778         (macro_define_function): Likewise.
8779
8780 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8781
8782         * macrocmd.c (extract_identifier): Return
8783         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8784         callers.
8785
8786 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8787
8788         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8789
8790 2019-02-05  Tom Tromey  <tom@tromey.com>
8791
8792         * target.c (target_stack::unpush): Move assertion earlier.
8793
8794 2019-01-30  Tom Tromey  <tom@tromey.com>
8795
8796         PR python/23615:
8797         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8798         (gdbpy_parse_and_eval): Likewise.
8799         * python/python-internal.h (gdbpy_allow_threads): New class.
8800
8801 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8802
8803         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8804         (aarch64_fbsd_fpregmap): Move earlier.
8805         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8806         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8807         instead of individual calls to trad_frame_set_reg_addr.
8808         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8809         earlier.
8810         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8811         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8812         instead of individual calls to trad_frame_set_reg_addr.
8813
8814 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8815
8816         * CONTRIBUTE: Replace contribution list with wiki link.
8817
8818 2019-01-25  Tom Tromey  <tom@tromey.com>
8819
8820         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8821
8822 2019-01-25  Tom Tromey  <tom@tromey.com>
8823
8824         * xtensa-linux-nat.c: Fix common/ includes.
8825         * xml-support.h: Fix common/ includes.
8826         * xml-support.c: Fix common/ includes.
8827         * x86-linux-nat.c: Fix common/ includes.
8828         * windows-nat.c: Fix common/ includes.
8829         * varobj.h: Fix common/ includes.
8830         * varobj.c: Fix common/ includes.
8831         * value.c: Fix common/ includes.
8832         * valops.c: Fix common/ includes.
8833         * utils.c: Fix common/ includes.
8834         * unittests/xml-utils-selftests.c: Fix common/ includes.
8835         * unittests/utils-selftests.c: Fix common/ includes.
8836         * unittests/unpack-selftests.c: Fix common/ includes.
8837         * unittests/tracepoint-selftests.c: Fix common/ includes.
8838         * unittests/style-selftests.c: Fix common/ includes.
8839         * unittests/string_view-selftests.c: Fix common/ includes.
8840         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8841         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8842         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8843         * unittests/rsp-low-selftests.c: Fix common/ includes.
8844         * unittests/parse-connection-spec-selftests.c: Fix common/
8845         includes.
8846         * unittests/optional-selftests.c: Fix common/ includes.
8847         * unittests/offset-type-selftests.c: Fix common/ includes.
8848         * unittests/observable-selftests.c: Fix common/ includes.
8849         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8850         * unittests/memrange-selftests.c: Fix common/ includes.
8851         * unittests/memory-map-selftests.c: Fix common/ includes.
8852         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8853         * unittests/function-view-selftests.c: Fix common/ includes.
8854         * unittests/environ-selftests.c: Fix common/ includes.
8855         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8856         * unittests/common-utils-selftests.c: Fix common/ includes.
8857         * unittests/cli-utils-selftests.c: Fix common/ includes.
8858         * unittests/array-view-selftests.c: Fix common/ includes.
8859         * ui-file.c: Fix common/ includes.
8860         * tui/tui-io.c: Fix common/ includes.
8861         * tracepoint.h: Fix common/ includes.
8862         * tracepoint.c: Fix common/ includes.
8863         * tracefile-tfile.c: Fix common/ includes.
8864         * top.h: Fix common/ includes.
8865         * top.c: Fix common/ includes.
8866         * thread.c: Fix common/ includes.
8867         * target/waitstatus.h: Fix common/ includes.
8868         * target/waitstatus.c: Fix common/ includes.
8869         * target.h: Fix common/ includes.
8870         * target.c: Fix common/ includes.
8871         * target-memory.c: Fix common/ includes.
8872         * target-descriptions.c: Fix common/ includes.
8873         * symtab.h: Fix common/ includes.
8874         * symfile.c: Fix common/ includes.
8875         * stap-probe.c: Fix common/ includes.
8876         * spu-linux-nat.c: Fix common/ includes.
8877         * sparc-nat.c: Fix common/ includes.
8878         * source.c: Fix common/ includes.
8879         * solib.c: Fix common/ includes.
8880         * solib-target.c: Fix common/ includes.
8881         * ser-unix.c: Fix common/ includes.
8882         * ser-tcp.c: Fix common/ includes.
8883         * ser-pipe.c: Fix common/ includes.
8884         * ser-base.c: Fix common/ includes.
8885         * selftest-arch.c: Fix common/ includes.
8886         * s12z-tdep.c: Fix common/ includes.
8887         * rust-exp.y: Fix common/ includes.
8888         * rs6000-aix-tdep.c: Fix common/ includes.
8889         * riscv-tdep.c: Fix common/ includes.
8890         * remote.c: Fix common/ includes.
8891         * remote-notif.h: Fix common/ includes.
8892         * remote-fileio.h: Fix common/ includes.
8893         * remote-fileio.c: Fix common/ includes.
8894         * regcache.h: Fix common/ includes.
8895         * regcache.c: Fix common/ includes.
8896         * record-btrace.c: Fix common/ includes.
8897         * python/python.c: Fix common/ includes.
8898         * python/py-type.c: Fix common/ includes.
8899         * python/py-inferior.c: Fix common/ includes.
8900         * progspace.h: Fix common/ includes.
8901         * producer.c: Fix common/ includes.
8902         * procfs.c: Fix common/ includes.
8903         * proc-api.c: Fix common/ includes.
8904         * printcmd.c: Fix common/ includes.
8905         * ppc-linux-nat.c: Fix common/ includes.
8906         * parser-defs.h: Fix common/ includes.
8907         * osdata.c: Fix common/ includes.
8908         * obsd-nat.c: Fix common/ includes.
8909         * nat/x86-linux.c: Fix common/ includes.
8910         * nat/x86-linux-dregs.c: Fix common/ includes.
8911         * nat/x86-dregs.h: Fix common/ includes.
8912         * nat/x86-dregs.c: Fix common/ includes.
8913         * nat/ppc-linux.c: Fix common/ includes.
8914         * nat/mips-linux-watch.h: Fix common/ includes.
8915         * nat/mips-linux-watch.c: Fix common/ includes.
8916         * nat/linux-waitpid.c: Fix common/ includes.
8917         * nat/linux-ptrace.h: Fix common/ includes.
8918         * nat/linux-ptrace.c: Fix common/ includes.
8919         * nat/linux-procfs.c: Fix common/ includes.
8920         * nat/linux-personality.c: Fix common/ includes.
8921         * nat/linux-osdata.c: Fix common/ includes.
8922         * nat/linux-namespaces.c: Fix common/ includes.
8923         * nat/linux-btrace.h: Fix common/ includes.
8924         * nat/linux-btrace.c: Fix common/ includes.
8925         * nat/fork-inferior.c: Fix common/ includes.
8926         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8927         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8928         * nat/aarch64-linux.c: Fix common/ includes.
8929         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8930         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8931         * namespace.h: Fix common/ includes.
8932         * mips-linux-tdep.c: Fix common/ includes.
8933         * minsyms.c: Fix common/ includes.
8934         * mi/mi-parse.h: Fix common/ includes.
8935         * mi/mi-main.c: Fix common/ includes.
8936         * mi/mi-cmd-env.c: Fix common/ includes.
8937         * memrange.h: Fix common/ includes.
8938         * memattr.c: Fix common/ includes.
8939         * maint.h: Fix common/ includes.
8940         * maint.c: Fix common/ includes.
8941         * main.c: Fix common/ includes.
8942         * machoread.c: Fix common/ includes.
8943         * location.c: Fix common/ includes.
8944         * linux-thread-db.c: Fix common/ includes.
8945         * linux-nat.c: Fix common/ includes.
8946         * linux-fork.c: Fix common/ includes.
8947         * inline-frame.c: Fix common/ includes.
8948         * infrun.c: Fix common/ includes.
8949         * inflow.c: Fix common/ includes.
8950         * inferior.h: Fix common/ includes.
8951         * inferior.c: Fix common/ includes.
8952         * infcmd.c: Fix common/ includes.
8953         * inf-ptrace.c: Fix common/ includes.
8954         * inf-child.c: Fix common/ includes.
8955         * ia64-linux-nat.c: Fix common/ includes.
8956         * i387-tdep.c: Fix common/ includes.
8957         * i386-tdep.c: Fix common/ includes.
8958         * i386-linux-tdep.c: Fix common/ includes.
8959         * i386-linux-nat.c: Fix common/ includes.
8960         * i386-go32-tdep.c: Fix common/ includes.
8961         * i386-fbsd-tdep.c: Fix common/ includes.
8962         * i386-fbsd-nat.c: Fix common/ includes.
8963         * guile/scm-type.c: Fix common/ includes.
8964         * guile/guile.c: Fix common/ includes.
8965         * go32-nat.c: Fix common/ includes.
8966         * gnu-nat.c: Fix common/ includes.
8967         * gdbthread.h: Fix common/ includes.
8968         * gdbarch-selftests.c: Fix common/ includes.
8969         * gdb_usleep.c: Fix common/ includes.
8970         * gdb_select.h: Fix common/ includes.
8971         * gdb_bfd.c: Fix common/ includes.
8972         * gcore.c: Fix common/ includes.
8973         * fork-child.c: Fix common/ includes.
8974         * findvar.c: Fix common/ includes.
8975         * fbsd-nat.c: Fix common/ includes.
8976         * event-top.c: Fix common/ includes.
8977         * event-loop.c: Fix common/ includes.
8978         * dwarf2read.c: Fix common/ includes.
8979         * dwarf2loc.c: Fix common/ includes.
8980         * dwarf2-frame.c: Fix common/ includes.
8981         * dwarf-index-cache.c: Fix common/ includes.
8982         * dtrace-probe.c: Fix common/ includes.
8983         * disasm-selftests.c: Fix common/ includes.
8984         * defs.h: Fix common/ includes.
8985         * csky-tdep.c: Fix common/ includes.
8986         * cp-valprint.c: Fix common/ includes.
8987         * cp-support.h: Fix common/ includes.
8988         * cp-support.c: Fix common/ includes.
8989         * corelow.c: Fix common/ includes.
8990         * completer.h: Fix common/ includes.
8991         * completer.c: Fix common/ includes.
8992         * compile/compile.c: Fix common/ includes.
8993         * compile/compile-loc2c.c: Fix common/ includes.
8994         * compile/compile-cplus-types.c: Fix common/ includes.
8995         * compile/compile-cplus-symbols.c: Fix common/ includes.
8996         * command.h: Fix common/ includes.
8997         * cli/cli-dump.c: Fix common/ includes.
8998         * cli/cli-cmds.c: Fix common/ includes.
8999         * charset.c: Fix common/ includes.
9000         * build-id.c: Fix common/ includes.
9001         * btrace.h: Fix common/ includes.
9002         * btrace.c: Fix common/ includes.
9003         * breakpoint.h: Fix common/ includes.
9004         * breakpoint.c: Fix common/ includes.
9005         * ax.h:
9006         (enum agent_op): Fix common/ includes.
9007         * ax-general.c (struct aop_map): Fix common/ includes.
9008         * ax-gdb.c: Fix common/ includes.
9009         * auxv.c: Fix common/ includes.
9010         * auto-load.c: Fix common/ includes.
9011         * arm-tdep.c: Fix common/ includes.
9012         * arch/riscv.c: Fix common/ includes.
9013         * arch/ppc-linux-common.c: Fix common/ includes.
9014         * arch/i386.c: Fix common/ includes.
9015         * arch/arm.c: Fix common/ includes.
9016         * arch/arm-linux.c: Fix common/ includes.
9017         * arch/arm-get-next-pcs.c: Fix common/ includes.
9018         * arch/amd64.c: Fix common/ includes.
9019         * arch/aarch64.c: Fix common/ includes.
9020         * arch/aarch64-insn.c: Fix common/ includes.
9021         * arch-utils.c: Fix common/ includes.
9022         * amd64-windows-tdep.c: Fix common/ includes.
9023         * amd64-tdep.c: Fix common/ includes.
9024         * amd64-sol2-tdep.c: Fix common/ includes.
9025         * amd64-obsd-tdep.c: Fix common/ includes.
9026         * amd64-nbsd-tdep.c: Fix common/ includes.
9027         * amd64-linux-tdep.c: Fix common/ includes.
9028         * amd64-linux-nat.c: Fix common/ includes.
9029         * amd64-fbsd-tdep.c: Fix common/ includes.
9030         * amd64-fbsd-nat.c: Fix common/ includes.
9031         * amd64-dicos-tdep.c: Fix common/ includes.
9032         * amd64-darwin-tdep.c: Fix common/ includes.
9033         * agent.c: Fix common/ includes.
9034         * ada-lang.h: Fix common/ includes.
9035         * ada-lang.c: Fix common/ includes.
9036         * aarch64-tdep.c: Fix common/ includes.
9037
9038 2019-01-25  Tom Tromey  <tom@tromey.com>
9039
9040         * common/create-version.sh: Use common/version.h.
9041
9042 2019-01-24  Pedro Alves  <palves@redhat.com>
9043
9044         * infrun.c (signal_stop, signal_print, signal_program)
9045         (signal_catch, signal_pass): Now arrays instead of pointers.
9046         (update_signals_program_target, do_target_resume)
9047         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9048         * linux-nat.c (linux_nat_target::pass_signals)
9049         (linux_nat_target::create_inferior, linux_nat_target::attach):
9050         Adjust.
9051         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9052         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9053         * procfs.c (procfs_target::pass_signals): Adjust.
9054         * record-full.c (record_full_target::resume): Adjust.
9055         * remote.c (remote_target::pass_signals)
9056         (remote_target::program_signals): Adjust.
9057         * target-debug.h (target_debug_print_signals): Now takes a
9058         gdb::array_view as parameter.  Adjust.
9059         * target.h (target_ops) <pass_signals, program_signals>: Replace
9060         pointer and length parameters with gdb::array_view.
9061         (target_pass_signals, target_program_signals): Likewise.
9062         * target-delegates.c: Regenerate.
9063
9064 2019-01-24  Pedro Alves  <palves@redhat.com>
9065
9066         * common/forward-scope-exit.h
9067         (forward_scope_exit::forward_scope_exit): Pass arguments to
9068         m_bind_function directly, instead of creating a std::bind and
9069         copying that.
9070
9071 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9072
9073         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9074         for static members.
9075         (pass_in_v_vfp_candidate): Likewise.
9076
9077 2019-01-23  Tom Tromey  <tom@tromey.com>
9078             Pedro Alves  <palves@redhat.com>
9079
9080         * regcache.c (class regcache_invalidator): Remove.
9081         (regcache::raw_write): Use make_scope_exit.
9082
9083 2019-01-23  Tom Tromey  <tom@tromey.com>
9084
9085         * ui-out.h (class ui_out_emit_type): Update comment.
9086
9087 2019-01-23  Tom Tromey  <tom@tromey.com>
9088
9089         * infrun.c (fetch_inferior_event): Update comment.
9090
9091 2019-01-23  Tom Tromey  <tom@tromey.com>
9092             Pedro Alves  <palves@redhat.com>
9093
9094         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9095         parameter.
9096         (fetch_inferior_event): Use SCOPE_EXIT.
9097
9098
9099 2019-01-23  Tom Tromey  <tom@tromey.com>
9100             Pedro Alves  <palves@redhat.com>
9101
9102         * infrun.c (disable_thread_events): Delete.
9103         (stop_all_threads): Use SCOPE_EXIT.
9104
9105 2019-01-23  Tom Tromey  <tom@tromey.com>
9106             Pedro Alves  <palves@redhat.com>
9107
9108         * symfile.c: Include forward-scope-exit.h.
9109         (clear_symtab_users_cleanup): Replace forward declaration with
9110         a FORWARD_SCOPE_EXIT.
9111         (syms_from_objfile_1): Use the forward_scope_exit and
9112         gdb::optional instead of cleanup_function.
9113         (reread_symbols): Use the forward_scope_exit instead of
9114         cleanup_function.
9115         (clear_symtab_users_cleanup): Remove function.
9116
9117 2019-01-23  Tom Tromey  <tom@tromey.com>
9118             Pedro Alves  <palves@redhat.com>
9119
9120         * linux-nat.c: Include scope-exit.h.
9121         (cleanup_target_stop): Remove.
9122         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9123         SCOPE_EXIT.
9124
9125 2019-01-23  Tom Tromey  <tom@tromey.com>
9126             Pedro Alves  <palves@redhat.com>
9127
9128         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9129         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9130
9131 2019-01-23  Tom Tromey  <tom@tromey.com>
9132             Andrew Burgess  <andrew.burgess@embecosm.com>
9133             Pedro Alves  <palves@redhat.com>
9134
9135         * infrun.c (fetch_inferior_event): Use scope_exit.
9136         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9137         * top.c (execute_command): Use scope_exit.
9138         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9139         * utils.c (do_bpstat_clear_actions_cleanup)
9140         (make_bpstat_clear_actions_cleanup): Remove.
9141
9142 2019-01-23  Tom Tromey  <tom@tromey.com>
9143             Pedro Alves  <palves@redhat.com>
9144
9145         * infrun.c: Include "common/scope-exit.h"
9146         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9147         (wait_for_inferior): Use SCOPE_EXIT.
9148         (fetch_inferior_event): Use scope_exit.
9149
9150 2019-01-23  Tom Tromey  <tom@tromey.com>
9151             Pedro Alves  <palves@redhat.com>
9152
9153         * breakpoint.c (create_breakpoint): Remove cleanup.
9154
9155 2019-01-23  Tom Tromey  <tom@tromey.com>
9156             Andrew Burgess  <andrew.burgess@embecosm.com>
9157             Pedro Alves  <palves@redhat.com>
9158
9159 2019-01-23  Pedro Alves  <palves@redhat.com>
9160
9161         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9162
9163 2019-01-23  Pedro Alves  <palves@redhat.com>
9164             Andrew Burgess  <andrew.burgess@embecosm.com>
9165
9166         * gdbthread.h: Include "common/forward-scope-exit.h".
9167         (scoped_finish_thread_state): Redefine custom class in terms of
9168         forward_scope_exit.
9169
9170 2019-01-23  Pedro Alves  <palves@redhat.com>
9171             Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * common/forward-scope-exit.h: New file.
9174
9175 2019-01-23  Pedro Alves  <palves@redhat.com>
9176             Andrew Burgess  <andrew.burgess@embecosm.com>
9177             Tom Tromey  <tom@tromey.com>
9178
9179         * common/scope-exit.h: New file.
9180
9181 2019-01-23  Pedro Alves  <palves@redhat.com>
9182
9183         * common/preprocessor.h (ESC): Rename to ...
9184         (ESC_PARENS): ... this.
9185         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9186         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9187
9188 2019-01-23  Tom Tromey  <tom@tromey.com>
9189
9190         * language.h (class scoped_switch_to_sym_language_if_auto):
9191         Initialize m_lang in both cases.
9192
9193 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9194
9195         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9196         with XCNEW.
9197
9198 2019-01-22  Tom Tromey  <tom@tromey.com>
9199
9200         * corelow.c: Do not include sys/file.h.
9201
9202 2019-01-22  Tom Tromey  <tom@tromey.com>
9203
9204         * tui/tui-wingeneral.h: Include gdb_curses.h.
9205
9206 2019-01-22  Tom Tromey  <tom@tromey.com>
9207
9208         * source-cache.h (class source_cache) <get_source_lines,
9209         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9210
9211 2019-01-22  Tom Tromey  <tom@tromey.com>
9212
9213         * remote-fileio.h (struct remote_target): Declare.
9214
9215 2019-01-22  Tom Tromey  <tom@tromey.com>
9216
9217         * python/py-arch.c: Do not include py-ref.h.
9218         * python/py-bpevent.c: Do not include py-ref.h.
9219         * python/py-cmd.c: Do not include py-ref.h.
9220         * python/py-continueevent.c: Do not include py-ref.h.
9221         * python/py-event.h: Do not include py-ref.h.
9222         * python/py-evtregistry.c: Do not include py-ref.h.
9223         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9224         * python/py-frame.c: Do not include py-ref.h.
9225         * python/py-framefilter.c: Do not include py-ref.h.
9226         * python/py-function.c: Do not include py-ref.h.
9227         * python/py-infevents.c: Do not include py-ref.h.
9228         * python/py-linetable.c: Do not include py-ref.h.
9229         * python/py-objfile.c: Do not include py-ref.h.
9230         * python/py-param.c: Do not include py-ref.h.
9231         * python/py-prettyprint.c: Do not include py-ref.h.
9232         * python/py-progspace.c: Do not include py-ref.h.
9233         * python/py-symbol.c: Do not include py-ref.h.
9234         * python/py-symtab.c: Do not include py-ref.h.
9235         * python/py-type.c: Do not include py-ref.h.
9236         * python/py-unwind.c: Do not include py-ref.h.
9237         * python/py-utils.c: Do not include py-ref.h.
9238         * python/py-value.c: Do not include py-ref.h.
9239         * python/py-varobj.c: Do not include py-ref.h.
9240         * python/py-xmethods.c: Do not include py-ref.h.
9241         * python/python.c: Do not include py-ref.h.
9242         * varobj.c: Do not include py-ref.h.
9243
9244 2019-01-22  Tom Tromey  <tom@tromey.com>
9245
9246         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9247         keyword for bcache.
9248
9249 2019-01-22  Tom Tromey  <tom@tromey.com>
9250
9251         * compile/compile-cplus-types.c: Remove a comment by #include.
9252
9253 2019-01-22  Tom Tromey  <tom@tromey.com>
9254
9255         * compile/gcc-c-plugin.h: Include compile-internal.h.
9256
9257 2019-01-22  Tom Tromey  <tom@tromey.com>
9258
9259         * stabsread.c (EXTERN): Do not define.
9260         (symnum, next_symbol_text_func, processing_gcc_compilation)
9261         (within_function, global_sym_chain, global_stabs)
9262         (previous_stab_code, this_object_header_files)
9263         (n_this_object_header_files)
9264         (n_allocated_this_object_header_files): Define.
9265         * stabsread.h (EXTERN): Never define.  Use "extern".
9266
9267 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9268
9269         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9270         history_value.
9271
9272 2019-01-21  Tom Tromey  <tom@tromey.com>
9273
9274         * ui-out.c: Fix includes.
9275         * tui/tui-source.c: Fix includes.
9276         * target.c: Fix includes.
9277         * remote.c: Fix includes.
9278         * regcache.c: Fix includes.
9279         * python/py-block.c: Fix includes.
9280         * printcmd.c: Fix includes.
9281         * or1k-tdep.c: Fix includes.
9282         * mi/mi-main.c: Fix includes.
9283         * m32r-tdep.c: Fix includes.
9284         * csky-tdep.c: Fix includes.
9285         * compile/compile-cplus-types.c: Fix includes.
9286         * cli/cli-interp.c: Fix includes.
9287
9288 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9289
9290         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9291         for padding.
9292
9293 2019-01-16  Tom Tromey  <tom@tromey.com>
9294
9295         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9296         earlier.
9297         (struct objfile) <msymbols_range>: Move from top level.
9298         <msymbols>: New method.
9299         (class objfile_msymbols): Remove.
9300         * symtab.c (default_collect_symbol_completion_matches_break_on):
9301         Update.
9302         * symmisc.c (dump_msymbols): Update.
9303         * stabsread.c (scan_file_globals): Update.
9304         * objc-lang.c (info_selectors_command, info_classes_command)
9305         (find_methods): Update.
9306         * minsyms.c (find_solib_trampoline_target): Update.
9307         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9308         * coffread.c (coff_symfile_read): Update.
9309         * ada-lang.c (ada_lookup_simple_minsym)
9310         (ada_collect_symbol_completion_matches): Update.
9311
9312 2019-01-16  Tom Tromey  <tom@tromey.com>
9313
9314         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9315         type.  Remove no-argument constructor.
9316         <iterator::operator++>: Simplify.
9317         <begin>: Update.
9318         <end>: Use minimal_symbol_count.
9319
9320 2019-01-16  Tom Tromey  <tom@tromey.com>
9321
9322         * objfiles.h (struct objfile) <psymtabs>: New method.
9323         (class objfile_psymtabs): Remove.
9324         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9325         typedef.
9326         <range>: New method.
9327         (require_partial_symbols): Change return type.
9328         * psymtab.c (require_partial_symbols)
9329         (psym_expand_symtabs_matching): Update.
9330         * mdebugread.c (parse_partial_symbols): Update.
9331         * dbxread.c (dbx_end_psymtab): Update.
9332
9333 2019-01-15  Tom Tromey  <tom@tromey.com>
9334
9335         * symtab.c (lookup_objfile_from_block)
9336         (lookup_symbol_in_objfile_symtabs)
9337         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9338         (find_line_symtab, info_sources_command)
9339         (default_collect_symbol_completion_matches_break_on)
9340         (make_source_files_completion_list): Update.
9341         * symmisc.c (print_objfile_statistics, dump_objfile)
9342         (maintenance_print_symbols, maintenance_info_symtabs)
9343         (maintenance_check_symtabs, maintenance_info_line_tables):
9344         Update.
9345         * source.c (select_source_symtab)
9346         (forget_cached_source_info_for_objfile): Update.
9347         * objfiles.h (class objfile_compunits): Remove.
9348         (struct objfile) <compunits_range>: New typedef.
9349         (compunits): New method.
9350         * objfiles.c (objfile_relocate1): Update.
9351         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9352         * maint.c (count_symtabs_and_blocks): Update.
9353         * linespec.c (iterate_over_all_matching_symtabs): Update.
9354         * cp-support.c (add_symbol_overload_list_qualified): Update.
9355         * coffread.c (coff_symtab_read): Update.
9356         * ada-lang.c (add_nonlocal_symbols)
9357         (ada_collect_symbol_completion_matches)
9358         (ada_add_global_exceptions): Update.
9359
9360 2019-01-15  Tom Tromey  <tom@tromey.com>
9361
9362         * progspace.h (program_space) <objfiles_safe_range>: New
9363         typedef.
9364         <objfiles_safe>: New method.
9365         * objfiles.h (class all_objfiles_safe): Remove.
9366         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9367         * jit.c (jit_inferior_exit_hook): Update.
9368
9369 2019-01-17  Tom Tromey  <tom@tromey.com>
9370
9371         * progspace.h (program_space) <objfiles_range>: New typedef.
9372         <objfiles>: New method.
9373         <objfiles_head>: Rename from objfiles.
9374         (object_files): Update.
9375         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9376         * guile/scm-pretty-print.c
9377         (ppscm_find_pretty_printer_from_objfiles): Update.
9378         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9379         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9380         Update.
9381         * python/py-progspace.c (pspy_get_objfiles): Update.
9382         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9383         Update.
9384         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9385         (objfpy_lookup_objfile_by_build_id): Update.
9386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9387         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9388         Update.
9389         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9390         (expand_symtab_containing_pc, lookup_objfile_from_block)
9391         (lookup_static_symbol, basic_lookup_transparent_type)
9392         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9393         (find_line_symtab, info_sources_command)
9394         (default_collect_symbol_completion_matches_break_on)
9395         (make_source_files_completion_list, find_main_name): Update.
9396         * symmisc.c (print_symbol_bcache_statistics)
9397         (print_objfile_statistics, maintenance_print_symbols)
9398         (maintenance_print_msymbols, maintenance_print_objfiles)
9399         (maintenance_info_symtabs, maintenance_check_symtabs)
9400         (maintenance_expand_symtabs, maintenance_info_line_tables):
9401         Update.
9402         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9403         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9404         (map_overlay_command, unmap_overlay_command)
9405         (simple_overlay_update, expand_symtabs_matching)
9406         (map_symbol_filenames): Update.
9407         * symfile-debug.c (set_debug_symfile): Update.
9408         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9409         Update.
9410         * source.c (select_source_symtab, forget_cached_source_info):
9411         Update.
9412         * solib.c (solib_read_symbols): Update.
9413         * solib-spu.c (append_ocl_sos): Update.
9414         * psymtab.c (maintenance_print_psymbols)
9415         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9416         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9417         * printcmd.c (info_symbol_command): Update.
9418         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9419         Update.
9420         * objfiles.h (class all_objfiles): Remove.
9421         * objfiles.c (have_partial_symbols, have_full_symbols)
9422         (have_minimal_symbols, qsort_cmp, update_section_map)
9423         (shared_objfile_contains_address_p)
9424         (default_iterate_over_objfiles_in_search_order): Update.
9425         * objc-lang.c (info_selectors_command, info_classes_command)
9426         (find_methods): Update.
9427         * minsyms.c (find_solib_trampoline_target): Update.
9428         * maint.c (maintenance_info_sections)
9429         (maintenance_translate_address, count_symtabs_and_blocks):
9430         Update.
9431         * main.c (captured_main_1): Update.
9432         * linux-thread-db.c (try_thread_db_load_from_pdir)
9433         (has_libpthread): Update.
9434         * linespec.c (iterate_over_all_matching_symtabs)
9435         (search_minsyms_for_name): Update.
9436         * jit.c (jit_find_objf_with_entry_addr): Update.
9437         * hppa-tdep.c (find_unwind_entry)
9438         (hppa_lookup_stub_minimal_symbol): Update.
9439         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9440         Update.
9441         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9442         (elf_gnu_ifunc_resolve_by_got): Update.
9443         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9444         * dwarf-index-write.c (save_gdb_index_command): Update.
9445         * cp-support.c (add_symbol_overload_list_qualified): Update.
9446         * breakpoint.c (create_overlay_event_breakpoint)
9447         (create_longjmp_master_breakpoint)
9448         (create_std_terminate_master_breakpoint)
9449         (create_exception_master_breakpoint): Update.
9450         * blockframe.c (find_pc_partial_function): Update.
9451         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9452         (ada_collect_symbol_completion_matches)
9453         (ada_add_global_exceptions): Update.
9454
9455 2019-01-17  Tom Tromey  <tom@tromey.com>
9456
9457         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9458         declare VEC.
9459         (solib_target_parse_libraries): Change return type.
9460         (library_list_start_segment, library_list_start_section)
9461         (library_list_end_library, library_list_start_library); Update.
9462         (solib_target_free_library_list): Remove.
9463         (solib_target_parse_libraries): Remove cleanup.  Change return
9464         type.
9465         (solib_target_current_sos): Update.
9466
9467 2019-01-17  Tom Tromey  <tromey@bapiya>
9468
9469         * valprint.c: Replace "the the" with "the".
9470         * symtab.c: Replace "the the" with "the".
9471         * solib.c: Replace "the the" with "the".
9472         * solib-dsbt.c: Replace "the the" with "the".
9473         * linespec.c: Replace "the the" with "the".
9474         * dwarf2loc.h: Replace "the the" with "the".
9475         * amd64-windows-tdep.c: Replace "the the" with "the".
9476         * aarch64-tdep.c: Replace "the the" with "the".
9477
9478 2019-01-16  Keith Seitz  <keiths@redhat.com>
9479
9480         PR gdb/23773
9481         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9482         <builder>: Rename to ..
9483         <m_builder>: ... this and make private.
9484         (dwarf2_cu::get_builder): New method.  Change all users of
9485         `builder' to use this method.
9486         (dwarf2_start_symtab): Move to ...
9487         (dwarf2_cu::start_symtab): ... here.  Update all callers
9488         (setup_type_unit_groups): Move to ...
9489         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9490         callers.
9491         (dwarf2_cu::reset_builder): New method.
9492         (process_full_compunit, process_full_type_unit): Use
9493         dwarf2_cu::reset_builder.
9494         (follow_die_offset): Record the ancestor CU if it is different
9495         from the followed DIE's CU.
9496         (follow_die_sig_1): Likewise.
9497
9498 2019-01-15  Tom Tromey  <tom@tromey.com>
9499
9500         * remote.c (class remote_state) <buf>: Now a char_vector.
9501         <buf_size>: Remove.
9502         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9503         parameter.
9504         (remote_target::getpkt_or_notif_sane_1)
9505         (remote_target::getpkt_sane)
9506         (remote_target::getpkt_or_notif_sane): Likewise.
9507         (class remote_target) <putpkt>: New overload.
9508         (remote_target::read_frame): Change type of "buf_p".  Remove
9509         sizeof_p parameter.
9510         (packet_ok): New overload.
9511         (packet_check_result): New overload.
9512         Update all uses.
9513
9514 2019-01-14  Tom Tromey  <tom@tromey.com>
9515
9516         * remote-notif.c (handle_notification, remote_notif_ack)
9517         (remote_notif_parse): Make "buf" const.
9518         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9519         const.
9520         (remote_notif_parse, remote_notif_ack, handle_notification):
9521         Likewise.
9522         * remote.c (remote_notif_stop_parse): Make "buf" const.
9523         (remote_target::remote_parse_stop_reply): Make "buf" const.
9524         (remote_notif_stop_ack): Make "buf" const.
9525
9526 2019-01-14  Tom Tromey  <tom@tromey.com>
9527
9528         * remote.c (remote_console_output): Make parameter const.
9529
9530 2019-01-14  Tom Tromey  <tom@tromey.com>
9531
9532         * target-debug.h (target_debug_print_signals): Constify.
9533         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9534         * procfs.c (procfs_target::pass_signals): Update.
9535         * linux-nat.c (linux_nat_target::pass_signals): Update.
9536         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9537         * target-delegates.c: Rebuild.
9538         * remote.c (remote_target::program_signals): Update.
9539         (remote_target::pass_signals): Update.
9540         * target.c (target_pass_signals): Constify argument.
9541         (target_program_signals): Likewise.
9542         * target.h (struct target_ops) <pass_signals, program_signals>:
9543         Constify argument.
9544         (target_pass_signals, target_program_signals): Constify argument.
9545
9546 2019-01-14  Tom Tromey  <tom@tromey.com>
9547
9548         PR tui/28819:
9549         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9550
9551 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9552
9553         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9554         field.
9555         * rs6000-tdep.c: Include reggroups.h.
9556         (IS_V_ALIAS_PSEUDOREG): Define.
9557         (rs6000_register_name): Return names for the "vX" aliases.
9558         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9559         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9560         aliases.  Call default_register_reggroup_p for all other
9561         pseudo-registers.
9562         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9563         New functions.
9564         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9565         Handle "vX" aliases.
9566         (v_alias_pseudo_register_collect): New function.
9567         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9568         (rs6000_gdbarch_init): Initialize "vX" aliases as
9569         pseudo-registers.  Restore registration of
9570         rs6000_pseudo_register_reggroup_p with
9571         set_tdesc_pseudo_register_reggroup_p.
9572
9573 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9574
9575         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9576         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9577         set_gdbarch_num_pseudo_regs.
9578
9579 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9580
9581         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9582         Remove arg prefixname, add do_set and do_show.
9583         Add member functions set_list and show_list.
9584         * cli/cli-style.c (class cli_style_option): Update accordingly.
9585         (style_set_list): Move to file scope.
9586         (style_show_list): Likewise.
9587         (set_style): Call help_list.
9588         (show_style): Call cmd_show_list.
9589         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9590         Update to use the new macro.
9591
9592 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9593
9594         * ada-lang.c (_initialize_ada_language): Expand the help text
9595         for the "catch exception" command.
9596
9597 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9598
9599         * symtab.c (matching_obj_sections): Initialize obj,
9600         declare it closer to its usage.
9601
9602 2019-01-10  Tom Tromey  <tom@tromey.com>
9603
9604         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9605         (basic_inf_threads_range): Remove.
9606         (inf_threads_range, inf_non_exited_threads_range)
9607         (safe_inf_threads_range): Use next_adapter.
9608
9609 2019-01-10  Keith Seitz  <keiths@redhat.com>
9610
9611         PR gdb/23712
9612         PR symtab/23010
9613         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9614         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9615
9616 2019-01-10  Keith Seitz  <keiths@redhat.com>
9617
9618         PR gdb/23712
9619         PR symtab/23010
9620         * dictionary.c (pending_to_vector): Remove.
9621         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9622         Remove _1 suffix, replacing functions of the same name.  Update
9623         all callers.
9624         (dict_create_hashed, dict_create_hashed_expandable)
9625         (dict_create_linear, dict_create_linear_expandable, dict_free)
9626         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9627         Make functions static.
9628
9629 2019-01-10  Keith Seitz  <keiths@redhat.com>
9630
9631         PR gdb/23712
9632         PR symtab/23010
9633         * dictionary.h (struct dictionary): Replace declaration with
9634         multidictionary.
9635         (dict_create_hashed, dict_create_hashed_expandable)
9636         (dict_create_linear, dict_create_linear_expandable)
9637         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9638         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9639         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9640         taking multidictionary argument.
9641         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9642         * block.h (struct block) <dict>: Change to multidictionary
9643         and rename `multidict'.
9644         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9645         symmisc.c: Update all dictionary references to multidictionary.
9646
9647 2019-01-10  Keith Seitz  <keiths@redhat.com>
9648
9649         PR gdb/23712
9650         PR symtab/23010
9651         * dictionary.c: Include unordered_map.
9652         (pending_to_vector): New function.
9653         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9654         Rewrite the non-"_1" functions to take vector instead
9655         of linked list.
9656         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9657         "new" _1 versions of the same name.
9658         (multidictionary): Define.
9659         (std::hash<enum language): New definition.
9660         (collate_pending_symbols_by_language, mdict_create_hashed)
9661         (mdict_create_hashed_expandable, mdict_create_linear)
9662         (mdict_create_linear_expandable, mdict_free)
9663         (find_language_dictionary, create_new_language_dictionary)
9664         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9665         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9666         (mdict_size, mdict_empty): New functions.
9667         * dictionary.h (mdict_iterator): Define.
9668
9669 2019-01-10  Pedro Alves  <palves@redhat.com>
9670
9671         * breakpoint.c (read_uploaded_action)
9672         (create_tracepoint_from_upload): Adjust to use
9673         gdb::unique_xmalloc_ptr.
9674         * ctf.c (ctf_write_uploaded_tp):
9675         (SET_ARRAY_FIELD): Use emplace_back.
9676         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9677         * tracefile-tfile.c (tfile_write_uploaded_tp):
9678         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9679         gdb::unique_xmalloc_ptr.
9680         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9681         at_string, cond_string, cmd_strings>: Replace char pointers
9682         with gdb::unique_xmalloc_ptr.
9683
9684 2019-01-10  Pedro Alves  <palves@redhat.com>
9685
9686         * solib-target.c (library_list_start_library): Don't xstrdup name.
9687
9688 2019-01-10  Pedro Alves  <palves@redhat.com>
9689
9690         * mdebugread.c (parse_partial_symbols): Use
9691         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9692
9693 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9694
9695         * linux-fork.c (scoped_switch_fork_info)
9696         <~scoped_switch_fork_info>: Fix incorrect variable name.
9697
9698 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9699
9700         * linux-fork.c (scoped_switch_fork_info)
9701         <scoped_switch_fork_info>: Make explicit.
9702         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9703
9704 2019-01-10  Tom Tromey  <tom@tromey.com>
9705
9706         * objfiles.h (objfile::reset_psymtabs): Update.
9707         * objfiles.c (objfile::objfile): Update.
9708         * psymtab.h (psymtab_storage::obstack): Update.
9709         (psymtab_storage::m_obstack): Use gdb::optional.
9710         (class psymtab_storage): Update comment.  Remove objfile
9711         parameter.
9712         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9713
9714 2019-01-10  Tom Tromey  <tom@tromey.com>
9715
9716         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9717         <free_psymtabs>: Now private.
9718         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9719         (allocate_psymtab): Use new method.
9720
9721 2019-01-10  Tom Tromey  <tom@tromey.com>
9722
9723         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9724         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9725         * mdebugread.c (parse_partial_symbols): Use
9726         allocate_dependencies.
9727         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9728         allocate_dependencies.
9729         (process_psymtab_comp_unit_reader)
9730         (build_type_psymtab_dependencies): Likewise.
9731         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9732
9733 2019-01-10  Tom Tromey  <tom@tromey.com>
9734
9735         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9736         PSYMBOL_SET_LANGUAGE.
9737         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9738
9739 2019-01-10  Tom Tromey  <tom@tromey.com>
9740
9741         * psymtab.h (psymtab_storage::obstack): New method.
9742         <m_obstack>: Rename from obstack; now private.
9743         * psymtab.c (psymtab_storage): Update.
9744         * dwarf2read.c (create_addrmap_from_index)
9745         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9746         Update.
9747
9748 2019-01-10  Tom Tromey  <tom@tromey.com>
9749
9750         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9751         * objfiles.h (objfile::reset_psymtabs): New method.
9752
9753 2019-01-10  Tom Tromey  <tom@tromey.com>
9754
9755         * symmisc.c (print_symbol_bcache_statistics): Update.
9756         (print_objfile_statistics): Update.
9757         * symfile.c (reread_symbols): Update.
9758         * psymtab.h (class psymtab_storage): New.
9759         * psymtab.c (psymtab_storage): New constructor.
9760         (~psymtab_storage): New destructor.
9761         (require_partial_symbols): Update.
9762         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9763         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9764         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9765         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9766         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9767         (start_psymtab_common, end_psymtab_common)
9768         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9769         (allocate_psymtab): Update.
9770         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9771         Update.
9772         (dump_psymtab_addrmap, maintenance_print_psymbols)
9773         (maintenance_check_psymtabs): Update.
9774         (class objfile_psymtabs): Move to objfiles.h.
9775         * psympriv.h (discard_psymtab): Now inline.
9776         (psymtab_discarder::psymtab_discarder): Update.
9777         (psymtab_discarder::~psymtab_discarder): Update.
9778         (ALL_OBJFILE_PSYMTABS): Rewrite.
9779         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9780         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9781         Remove fields.
9782         <partial_symtabs>: New field.
9783         (class objfile_psymtabs): Move from psymtab.h.  Update.
9784         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9785         psymbol_cache.
9786         (objfile::~objfile): Don't destroy psymbol_cache.
9787         * mdebugread.c (parse_partial_symbols): Update.
9788         * dwarf2read.c (create_addrmap_from_index)
9789         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9790         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9791         (add_partial_subprogram, dwarf2_ranges_read): Update.
9792         * dwarf-index-write.c (write_address_map)
9793         (write_one_signatured_type, recursively_write_psymbols)
9794         (class debug_names, class debug_names, write_psymtabs_to_index):
9795         Update.
9796
9797 2019-01-10  Tom Tromey  <tom@tromey.com>
9798
9799         * symtab.h (SYMBOL_SET_NAMES): Update.
9800         (symbol_set_names): Update.
9801         (MSYMBOL_SET_NAMES): Update.
9802         * symtab.c (symbol_set_names): Change argument to be an
9803         objfile_per_bfd_storage.
9804         * psymtab.c (add_psymbol_to_bcache): Update.
9805         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9806
9807 2019-01-10  Tom Tromey  <tom@tromey.com>
9808
9809         * symtab.c (create_demangled_names_hash): Change argument to be an
9810         objfile_per_bfd_storage.
9811         (symbol_set_names): Update.
9812
9813 2019-01-10  Tom Tromey  <tom@tromey.com>
9814
9815         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9816         init_psymbol_list.
9817         * psymtab.c (init_psymbol_list): Do nothing if already called.
9818         * psympriv.h (init_psymbol_list): Add comment.
9819         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9820         init_psymbol_list.
9821         * dbxread.c (dbx_symfile_read): Unconditionally call
9822         init_psymbol_list.
9823
9824 2019-01-10  Tom Tromey  <tom@tromey.com>
9825
9826         * xcoffread.c (scan_xcoff_symtab): Update.
9827         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9828         "where".
9829         * mdebugread.c (parse_partial_symbols)
9830         (handle_psymbol_enumerators): Update.
9831         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9832         * dbxread.c (read_dbx_symtab): Update.
9833         * psympriv.h (psymbol_placement): New enum.
9834         (add_psymbol_to_list): Update.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9839         static_psymbols parameters.
9840         (scan_xcoff_symtab): Update.
9841         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9842         static_psymbols parameters.
9843         * psympriv.h (start_psymtab_common): Update.
9844         * mdebugread.c (parse_partial_symbols): Update.
9845         * dwarf2read.c (create_partial_symtab): Update.
9846         * dbxread.c (read_dbx_symtab): Update.
9847         (start_psymtab): Remove global_psymbols and static_psymbols
9848         parameters.
9849
9850 2019-01-10  Tom Tromey  <tom@tromey.com>
9851
9852         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9853         * psymtab.c (allocate_psymtab): Add comment.
9854         * psympriv.h (allocate_psymtab): Add comment.
9855         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9856         initializations.
9857         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9858
9859 2019-01-10  Tom Tromey  <tom@tromey.com>
9860
9861         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9862         Don't declare.
9863         * mipsread.c: Include mdebugread.h.
9864         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9865         Declare.
9866         * elfread.c: Include mdebugread.h.
9867
9868 2019-01-09  Tom Tromey  <tom@tromey.com>
9869
9870         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9871         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9872         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9873         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9874         (psym_lookup_symbol, psym_find_last_source_symtab)
9875         (psym_forget_cached_source_info, psym_print_stats)
9876         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9877         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9878         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9879         (psym_find_compunit_symtab_by_address)
9880         (maintenance_print_psymbols, maintenance_info_psymtabs)
9881         (maintenance_check_psymtabs): Use ranged for.
9882         * psymtab.h (class objfile_psymtabs): New.
9883         (require_partial_symbols): Return objfile_psymtabs.
9884         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9885
9886 2019-01-09  Tom Tromey  <tom@tromey.com>
9887
9888         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9889         (find_pc_mapped_section, list_overlays_command)
9890         (map_overlay_command, unmap_overlay_command)
9891         (simple_overlay_update): Use all_objfiles.
9892         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9893         * printcmd.c (info_symbol_command): Use all_objfiles.
9894         * objfiles.h (ALL_OBJSECTIONS): Remove.
9895         * maint.c (maintenance_translate_address): Use all_objfiles.
9896         * gcore.c (gcore_create_callback): Use all_objfiles.
9897         (objfile_find_memory_regions): Likewise.
9898
9899 2019-01-09  Tom Tromey  <tom@tromey.com>
9900
9901         * symtab.c (find_line_symtab, info_sources_command)
9902         (make_source_files_completion_list): Use objfile_compunits.
9903         * source.c (select_source_symtab): Use objfile_compunits.
9904         * objfiles.h (struct objfile): Update comment.
9905         (ALL_OBJFILES): Remove.
9906         (ALL_FILETABS): Remove.
9907         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9908         objfile_compunits.
9909
9910 2019-01-09  Tom Tromey  <tom@tromey.com>
9911
9912         * symmisc.c (print_objfile_statistics, dump_objfile)
9913         (maintenance_print_symbols): Use compunit_filetabs.
9914         * source.c (forget_cached_source_info_for_objfile): Use
9915         compunit_filetabs.
9916         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9917         (ALL_FILETABS): Use compunit_filetabs.
9918         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9919         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9920
9921 2019-01-09  Tom Tromey  <tom@tromey.com>
9922
9923         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9924         (compunit_filetabs): New.
9925         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9926         compunit_filetabs.
9927         (info_sources_command, make_source_files_completion_list): Remove
9928         declaration.
9929         * symmisc.c (print_objfile_statistics, dump_objfile)
9930         (maintenance_print_symbols): Remove declaration.
9931         (maintenance_info_symtabs): Use compunit_filetabs.
9932         (maintenance_info_line_tables): Likewise.
9933         * source.c (select_source_symtab): Change local variable name.
9934         (forget_cached_source_info_for_objfile): Remove declaration.
9935         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9936         * objfiles.c (objfile_relocate1): Remove declaration.
9937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9938         declaration.
9939         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9940         * coffread.c (coff_symtab_read): Remove declaration.
9941         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9942         compunit_filetabs.
9943
9944 2019-01-09  Tom Tromey  <tom@tromey.com>
9945
9946         * symtab.c (lookup_objfile_from_block)
9947         (find_pc_sect_compunit_symtab, search_symbols)
9948         (default_collect_symbol_completion_matches_break_on): Use
9949         objfile_compunits.
9950         * objfiles.h (ALL_COMPUNITS): Remove.
9951         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9952         * cp-support.c (add_symbol_overload_list_qualified): Use
9953         objfile_compunits.
9954         * ada-lang.c (ada_collect_symbol_completion_matches)
9955         (ada_add_global_exceptions): Use objfile_compunits.
9956
9957 2019-01-09  Tom Tromey  <tom@tromey.com>
9958
9959         * source.c (select_source_symtab)
9960         (forget_cached_source_info_for_objfile): Remove declaration.
9961         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9962         declaration.
9963         * maint.c (count_symtabs_and_blocks): Remove declaration.
9964         * cp-support.c (add_symbol_overload_list_qualified): Remove
9965         declaration.
9966         * coffread.c (coff_symtab_read): Remove declaration.
9967         * symtab.c (lookup_symbol_in_objfile_symtabs)
9968         (basic_lookup_transparent_type_1): Use objfile_compunits.
9969         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9970         (info_sources_command, search_symbols)
9971         (default_collect_symbol_completion_matches_break_on)
9972         (make_source_files_completion_list): Remove declaration.
9973         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9974         (ada_collect_symbol_completion_matches)
9975         (ada_add_global_exceptions): Remove declaration.
9976         * linespec.c (iterate_over_all_matching_symtabs): Use
9977         objfile_compunits.
9978         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9979         (class objfile_compunits): New.
9980         (ALL_COMPUNITS): Use objfile_compunits.
9981         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9982         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9983         objfile_compunits.
9984         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9985
9986 2019-01-09  Tom Tromey  <tom@tromey.com>
9987
9988         * symtab.c (search_symbols)
9989         (default_collect_symbol_completion_matches_break_on): Use
9990         objfile_msymbols.
9991         * ada-lang.c (ada_lookup_simple_minsym)
9992         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9993         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9994         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9995         objfile_msymbols.
9996         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9997         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9998         * objc-lang.c (find_methods): Use objfile_msymbols.
9999         (info_selectors_command, info_classes_command): Likewise.
10000         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10001         * objfiles.h (class objfile_msymbols): New.
10002         (ALL_OBJFILE_MSYMBOLS): Remove.
10003         (ALL_MSYMBOLS): Remove.
10004
10005 2019-01-09  Tom Tromey  <tom@tromey.com>
10006
10007         * common/next-iterator.h (next_adapter): Add Iterator template
10008         parameter.
10009         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10010         (class all_objfiles_safe): New.
10011         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10012         * objfiles.c (put_objfile_before): Update comment.
10013         (add_separate_debug_objfile): Likewise.
10014         (free_all_objfiles): Use all_objfiles_safe.
10015         (objfile_purge_solibs): Likewise.
10016
10017 2019-01-09  Tom Tromey  <tom@tromey.com>
10018
10019         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10020         (expand_symtab_containing_pc, lookup_static_symbol)
10021         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10022         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10023         all_objfiles.
10024         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10025         * breakpoint.c (create_overlay_event_breakpoint)
10026         (create_longjmp_master_breakpoint)
10027         (create_std_terminate_master_breakpoint)
10028         (create_exception_master_breakpoint): Use all_objfiles.
10029         * linux-thread-db.c (try_thread_db_load_from_pdir)
10030         (has_libpthread): Use all_objfiles.
10031         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10032         * linespec.c (iterate_over_all_matching_symtabs)
10033         (search_minsyms_for_name): Use all_objfiles.
10034         * maint.c (maintenance_info_sections): Use all_objfiles.
10035         * main.c (captured_main_1): Use all_objfiles.
10036         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10037         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10038         * guile/scm-pretty-print.c
10039         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10040         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10041         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10042         (maintenance_print_msymbols): Use all_objfiles.
10043         * source.c (select_source_symtab): Use all_objfiles.
10044         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10045         * symfile.c (remove_symbol_file_command)
10046         (expand_symtabs_matching, map_symbol_filenames): Use
10047         all_objfiles.
10048         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10049         all_objfiles.
10050         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10051         * objc-lang.c (find_methods): Use all_objfiles.
10052         * objfiles.c (have_partial_symbols, have_full_symbols)
10053         (have_minimal_symbols, qsort_cmp)
10054         (default_iterate_over_objfiles_in_search_order): Use
10055         all_objfiles.
10056         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10057         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10058         (maintenance_check_psymtabs): Use all_objfiles.
10059         (ALL_PSYMTABS): Remove.
10060         * compile/compile-object-run.c (do_module_cleanup): Use
10061         all_objfiles.
10062         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10063         * cp-support.c (add_symbol_overload_list_qualified): Use
10064         all_objfiles.
10065         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10066         Use all_objfiles.
10067         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10068         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10069         all_objfiles.
10070         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10071         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10072         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10073         Uses all_objfiles.
10074         * solib.c (solib_read_symbols): Use all_objfiles
10075
10076 2019-01-09  Tom Tromey  <tom@tromey.com>
10077
10078         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10079         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10080         all_objfiles.
10081         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10082         * symmisc.c (print_symbol_bcache_statistics)
10083         (print_objfile_statistics, maintenance_print_objfiles)
10084         (maintenance_info_symtabs, maintenance_check_symtabs)
10085         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10086         all_objfiles.
10087         * source.c (forget_cached_source_info): Use all_objfiles.
10088         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10089         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10090         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10091         * objfiles.c (update_section_map): Use all_objfiles.
10092         (shared_objfile_contains_address_p): Likewise.
10093         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10094         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10095
10096 2019-01-09  Tom Tromey  <tom@tromey.com>
10097
10098         * common/next-iterator.h: New file.
10099         * objfiles.h (class all_objfiles): New.
10100         (struct objfile_iterator): New.
10101
10102 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10103
10104         * NEWS: Move the description of the changed "frame", "select-frame",
10105          and "info frame" commands to the Changed commands section.
10106
10107 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10108
10109         * gdbtypes.c (check_stub_method_group): Remove handling of old
10110         mangling schemes.
10111         * linespec.c (find_methods): Likewise.
10112         * stabsread.c (read_member_functions): Likewise.
10113         * valops.c (search_struct_method): Likewise.
10114         (value_struct_elt_for_reference): Likewise.
10115         * NEWS: Mention this change.
10116
10117 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10120         print_source_lines.
10121         * source.c (print_source_lines_base): Update line number check.
10122         (print_source_lines): New function.
10123         (source_lines_range::source_lines_range): New function.
10124         * source.h (class source_lines_range): New class.
10125         (print_source_lines): New declaration.
10126
10127 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10128
10129         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10130
10131 2019-01-08  Tom Tromey  <tom@tromey.com>
10132             Simon Marchi  <simon.marchi@ericsson.com>
10133
10134         PR gdb/24060
10135         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10136         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10137         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10138         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10139         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10140         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10141
10142 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * source.c (select_source_symtab): Move header comment to
10145         declaration in source.h.
10146         (forget_cached_source_info_for_objfile): Likewise.
10147         (forget_cached_source_info): Likewise.
10148         (identify_source_line): Likewise.
10149         * source.h (identify_source_line): Move declaration from symtab.h
10150         and add comment from source.c
10151         (print_source_lines): Likewise.
10152         (forget_cached_source_info_for_objfile): Likewise.
10153         (forget_cached_source_info): Likewise.
10154         (select_source_symtab): Likewise.
10155         (enum print_source_lines_flag): Move definition from symtab.h.
10156         * symtab.h (identify_source_line): Move declaration to source.h.
10157         (print_source_lines): Likewise.
10158         (forget_cached_source_info_for_objfile): Likewise.
10159         (forget_cached_source_info): Likewise.
10160         (select_source_symtab): Likewise.
10161         (enum print_source_lines_flag): Move definition to source.h.
10162         * tui/tui-hooks.c: Add 'source.h' include.
10163
10164 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10165
10166         * source.c (print_source_lines_base): Handle requests to print
10167         reverse line number sequences, and guard against empty lines
10168         string.
10169
10170 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10171
10172         * source.c (print_source_lines_base): Fix skip of '\r' if next
10173         character is '\n'.
10174
10175 2019-01-06  Tom Tromey  <tom@tromey.com>
10176
10177         * c-exp.y (struct c_parse_state) <macro_original_text,
10178         expansion_obstack>: New member.
10179         (macro_original_text, expansion_obstack): Remove globals.
10180         (scan_macro_expansion, scanning_macro_expansion)
10181         (finished_macro_expansion): Update.
10182         (scan_macro_cleanup): Remove.
10183         (yylex, c_parse): Update.
10184
10185 2019-01-06  Tom Tromey  <tom@tromey.com>
10186
10187         * c-exp.y (struct c_parse_state) <strings>: New member.
10188         (operator_stoken): Update.
10189
10190 2019-01-06  Tom Tromey  <tom@tromey.com>
10191
10192         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10193         (union type_stack_elt) <typelist_val>: Now a pointer to
10194         std::vector.
10195         (type_stack_cleanup): Don't declare.
10196         (push_typelist): Update.
10197         * parse.c (pop_typelist): Return a std::vector.
10198         (push_typelist): Take a std::vector.
10199         (follow_types): Update.  Do not free args.
10200         (type_stack_cleanup): Remove.
10201         * c-exp.y (struct c_parse_state): New.
10202         (cpstate): New global.
10203         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10204         (nonempty_typelist): Update.
10205         (func_mod): Create a new vector.
10206         (c_parse): Create a c_parse_state.
10207         (check_parameter_typelist): Do not delete params.
10208         (function_method): Update.  Do not delete type_list.
10209
10210 2019-01-06  Tom Tromey  <tom@tromey.com>
10211
10212         PR gdb/28155:
10213         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10214         check_typedef.
10215         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10216         (print_return_value): Likewise.
10217
10218 2019-01-05  Tom Tromey  <tom@tromey.com>
10219
10220         * contrib/cleanup_check.py: Remove.
10221         * contrib/gcc-with-excheck: Remove.
10222         * contrib/exsummary.py: Remove.
10223         * contrib/excheck.py: Remove.
10224
10225 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10226
10227         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10228         NULL. Initialize tpprev to NULL instead of assigning it
10229         to NULL on the next statement.
10230         * windows-nat.c (windows_delete_thread): Remove check for
10231         main_thread_id before printing thread exit notifications.
10232         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10233         Remove thread ID check against main_thread_id.
10234         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10235         windows_delete_thread.
10236         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10237
10238 2019-01-04  Tom Tromey  <tom@tromey.com>
10239
10240         * compile/compile.c (_initialize_compile): Use upper case for
10241         metasyntactic variables.
10242         * symmisc.c (_initialize_symmisc): Use upper case for
10243         metasyntactic variables.
10244         * psymtab.c (_initialize_psymtab): Use upper case for
10245         metasyntactic variables.
10246         * demangle.c (demangle_command): Use upper case for metasyntactic
10247         variables.
10248         (_initialize_demangler): Likewise.
10249         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10250         variables.
10251
10252 2019-01-03  Tom Tromey  <tom@tromey.com>
10253
10254         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10255
10256 2019-01-03  Tom Tromey  <tom@tromey.com>
10257
10258         * python/py-symtab.c (salpy_str): Update.
10259         (struct salpy_sal_object) <symtab>: Now a PyObject.
10260         (salpy_dealloc): Update.
10261         (del_objfile_sal): Use gdbpy_ref.
10262
10263 2019-01-03  Tom Tromey  <tom@tromey.com>
10264
10265         * python/py-type.c (convert_field): Use new_reference.  Return
10266         gdbpy_ref.
10267         (make_fielditem): Return gdbpy_ref.
10268         (typy_fields): Update.
10269         (typy_getitem): Update.
10270         (field_name): Return gdbpy_ref.  Use new_reference.
10271         (typy_iterator_iternext): Update.
10272
10273 2019-01-03  Tom Tromey  <tom@tromey.com>
10274
10275         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10276
10277 2019-01-03  Tom Tromey  <tom@tromey.com>
10278
10279         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10280         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10281         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10282         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10283         (pspy_set_type_printers): Likewise.
10284         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10285         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10286         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10287         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10288         (objfpy_set_type_printers): Likewise.
10289
10290 2019-01-03  Tom Tromey  <tom@tromey.com>
10291
10292         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10293         (gdbpy_print_stack): Use gdbpy_err_fetch.
10294         * python/python-internal.h (class gdbpy_err_fetch): New class.
10295         (class gdbpy_enter) <m_error_type, m_error_value,
10296         m_error_traceback>: Remove.
10297         <m_error>: New member.
10298         (gdbpy_exception_to_string): Don't declare.
10299         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10300         * python/py-value.c (convert_value_from_python): Use
10301         gdbpy_err_fetch.
10302         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10303         gdbpy_exception_to_string.
10304         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10305         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10306         gdbpy_err_fetch.
10307
10308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10309
10310         * linux-nat.c (delete_lwp_cleanup): Delete.
10311         (struct lwp_deleter): New struct.
10312         (lwp_info_up): New typedef.
10313         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10314         lwp_info_up.
10315
10316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10317
10318         * linux-fork.c (class scoped_switch_fork_info): New class.
10319         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10320
10321 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * valops.c (find_overload_match): Remove use of null_cleanup, and
10324         calls to do_cleanups.
10325
10326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10327
10328         * compile/compile-cplus-types.c
10329         (compile_cplus_instance::decl_name): Handle changes to
10330         cp_func_name.
10331         * cp-support.c (cp_func_name): Update header comment, update
10332         return type.
10333         * cp-support.h (cp_func_name): Update return type in declaration.
10334         * valops.c (find_overload_match): Move temp_func local to top
10335         level of function and change its type.  Use temp_func to hold and
10336         delete temporary string obtained from cp_func_name.
10337
10338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10339
10340         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10341         gdb::char_vector, remove cleanup, and update uses of `msg`.
10342
10343 2019-01-03  Jim Wilson  <jimw@sifive.com>
10344
10345         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10346
10347 2019-01-02  Tom Tromey  <tom@tromey.com>
10348
10349         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10350         (tdesc_parse_xml): Remove cleanups.
10351         * target-descriptions.h (make_cleanup_free_target_description):
10352         Don't declare.
10353         (target_desc_deleter): New struct.
10354         (target_desc_up): New typedef.
10355         * target-descriptions.c (target_desc_deleter::operator()): Rename
10356         from free_target_description.
10357         (make_cleanup_free_target_description): Remove.
10358
10359 2019-01-02  Tom Tromey  <tom@tromey.com>
10360
10361         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10362         constructor, destructor.
10363         (linespec_parser): Remove typedef.
10364         (~linespec_parser): Rename from linespec_parser_delete.
10365         (linespec_lex_to_end, linespec_complete_label)
10366         (linespec_complete): Update.
10367         (decode_line_full): Remove cleanups.
10368         (decode_line_1): Update.
10369
10370 2019-01-02  Tom Tromey  <tom@tromey.com>
10371
10372         * python/python-internal.h (inferior_to_inferior_object): Change
10373         return type.
10374         * python/py-exitedevent.c (create_exited_event_object): Update.
10375         * python/py-inferior.c (inferior_to_inferior_object): Return
10376         gdbpy_ref.
10377         (python_new_inferior, python_inferior_deleted)
10378         (thread_to_thread_object, delete_thread_object)
10379         (build_inferior_list, gdbpy_selected_inferior): Update.
10380         * python/py-infthread.c (create_thread_object): Update.  Also fail
10381         if inferior_to_inferior_object fails.
10382
10383 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10384
10385         * inferior.h (class inferior) <displaced_step_state>: New field.
10386         * infrun.h (struct displaced_step_state): Move here from
10387         infrun.c.  Initialize fields, add constructor.
10388         <inf>: Remove field.
10389         <reset>: New method.
10390         * infrun.c (struct displaced_step_inferior_state): Move to
10391         infrun.h.
10392         (displaced_step_inferior_states): Remove.
10393         (get_displaced_stepping_state): Adust.
10394         (displaced_step_in_progress_any_inferior): Adjust.
10395         (displaced_step_in_progress_thread): Adjust.
10396         (displaced_step_in_progress): Adjust.
10397         (add_displaced_stepping_state): Remove.
10398         (get_displaced_step_closure_by_addr): Adjust.
10399         (remove_displaced_stepping_state): Remove.
10400         (infrun_inferior_exit): Call displaced_step_state.reset.
10401         (use_displaced_stepping): Don't check for NULL.
10402         (displaced_step_prepare_throw): Call
10403         get_displaced_stepping_state.
10404         (displaced_step_fixup): Don't check for NULL.
10405         (prepare_for_detach): Don't check for NULL.
10406
10407 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10408
10409         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10410          in case of call that did not complete.
10411
10412 2019-01-02  Andrey Utkin  <autkin@undo.io>
10413
10414         * symfile.c (find_separate_debug_file): Fix search of debug files for
10415         remote debuggee.
10416
10417 2019-01-02  Tom Tromey  <tom@tromey.com>
10418
10419         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10420         indentation.
10421         * python/py-frame.c (frapy_older): Remove cast.
10422         (frapy_newer): Likewise.
10423         * python/py-breakpoint.c (local_setattro): Remove cast.
10424         * python/py-arch.c (archpy_name): Remove local variable.
10425         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10426
10427 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10428
10429         * unittests/basic_string_view/element_access/char/empty.cc:
10430         Fix year range in copyright header.
10431
10432 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10433
10434         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10435         Delete.
10436         <operator==>: Update with for removed field.
10437         <hash>: Likewise.
10438         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10439         <isa_features>: ...this.
10440         <abi_features>: New field.
10441         (riscv_isa_flen): Update comment.
10442         (riscv_abi_xlen): New declaration.
10443         (riscv_abi_flen): New declaration.
10444         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10445         isa_features.
10446         (riscv_abi_xlen): New function.
10447         (riscv_isa_flen): Update to get answer from isa_features.
10448         (riscv_abi_flen): New function.
10449         (riscv_has_fp_abi): Update to get answer from abi_features.
10450         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10451         xlen and flen.
10452         (riscv_call_info) <xlen, flen>: Update comment.
10453         (riscv_call_arg_struct): Remove invalid assertions
10454         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10455         is removed.
10456         (riscv_gdbarch_init): Gather isa features and abi features
10457         separately, ensure both match on the gdbarch when reusing an old
10458         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10459         a target with 64-bit float hardware.
10460
10461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10462
10463         * source.c (search_command_helper): Stop reverse search
10464         when line 1 has been searched.
10465
10466 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10467
10468         * record-full.c (record_full_base_target::close): Rewrite
10469         record_full_core_buf_list free logic.
10470
10471 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10472
10473         * break-catch-syscall.c (print_one_catch_syscall): xfree
10474         the last text.
10475
10476 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10477
10478         * top.c (print_gdb_version): Update Copyright year in version
10479         message.
10480
10481 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10482
10483         Update copyright year range in all GDB files.
10484
10485 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10486
10487         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10488
10489 For older changes see ChangeLog-2018.
10490 \f
10491 Local Variables:
10492 mode: change-log
10493 left-margin: 8
10494 fill-column: 74
10495 version-control: never
10496 coding: utf-8
10497 End:
10498