gdb/ChangeLog

   1 2019-05-04  Raul Tambre  <raul@tambre.ee>
   2
   3         * python/lib/gdb/prompt.py (_ExtendedPrompt)
   4         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
   5         operator for comparison.
   6
   7 2019-05-04  Tom Tromey  <tom@tromey.com>
   8
   9         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  10         (lookup_partial_symbol, print_partial_symbols)
  11         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  12         (psymbol_compare): Update.
  13         (add_psymbol_to_bcache): Clear the entire psymbol.
  14         (maintenance_check_psymtabs): Update.
  15         * psympriv.h (struct partial_symbol): Don't derive from
  16         general_symbol_info.
  17         <obj_section, unrelocated_address, address,
  18         set_unrelocated_address>: Update.
  19         <ginfo>: New member.
  20         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  21         (debug_names::write_psymbols): Update.
  22
  23 2019-05-04  Tom de Vries  <tdevries@suse.de>
  24
  25         * contrib/cc-with-tweaks.sh: Support -n arg.
  26
  27 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  28
  29         * corelow.c (core_target::detach): Ensure frame cache and
  30         register caches are cleared.
  31         inferior.c (exit_inferior_1): Likewise.
  32
  33 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  34             Tom Tromey  <tom@tromey.com>
  35
  36         * dictionary.c (collate_pending_symbols_by_language): Remove
  37         "struct" from foreach.
  38         * symtab.c (lookup_global_symbol_from_objfile)
  39         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  40         foreach.
  41         * ser-tcp.c (net_open): Remove "struct" from foreach.
  42         * objfiles.c (objfile_relocate, objfile_rebase)
  43         (objfile_has_symbols): Remove "struct" from foreach.
  44         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  45         from foreach.
  46         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  47         foreach.
  48         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  49         "struct" from foreach.
  50         * ada-lang.c (create_excep_cond_exprs)
  51         (ada_exception_catchpoint_cond_string): Remove "struct" from
  52         foreach.
  53
  54 2019-05-03  Tom Tromey  <tromey@adacore.com>
  55
  56         * ada-exp.y (convert_char_literal): Check suffix of each
  57         enumerator.
  58
  59 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  60
  61         PR ada/21406:
  62         * ada-exp.y (yywrap): Don't define.
  63         * ada-lex.l (%option): Add noyywrap
  64         (yywrap): Remove.
  65
  66 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  67
  68         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  69         _WIN32_WINNT to the XP level, unless already defined to a higher
  70         level.
  71
  72         * unittests/parse-connection-spec-selftests.c:
  73         * ser-tcp.c:
  74         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  75         override.
  76
  77         * symfile.c (find_separate_debug_file): Remove colon from the
  78         drive spec of DOS/Windows file names of the target, so that the
  79         file name produced from DEBUGDIR and the target's directory will
  80         be valid on DOS/Windows systems.
  81
  82 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * rust-lang.c (val_print_struct): Handle printing structures
  85         containing strings.
  86
  87 2019-05-02  Tom Tromey  <tromey@adacore.com>
  88
  89         * valarith.c (_initialize_valarith): Remove.
  90
  91 2019-05-01  Tom Tromey  <tromey@adacore.com>
  92
  93         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  94         bitfields.
  95
  96 2019-05-01  Tom Tromey  <tromey@adacore.com>
  97
  98         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  99         for big-endian copies.
 100
 101 2019-04-30  Ali Tamur  <tamur@google.com>
 102         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 103         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 104         (read_3_bytes): New function.
 105
 106 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 107
 108         * windows-nat.c (main_thread_id): Delete.
 109         (handle_output_debug_string): Replace main_thread_id by
 110         current_event.dwThreadId.
 111         (fake_create_process): Likewise.
 112         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 113         Do not set main_thread_id.
 114         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 115         current_event.dwThreadId.
 116         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 117
 118 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 119
 120         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 121         Use current_event.dwThreadId instead of main_thread_id.
 122
 123 2019-04-30  Tom Tromey  <tromey@adacore.com>
 124
 125         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 126         (create_excep_cond_exprs): Iterate over program spaces.
 127         (ada_exception_catchpoint_cond_string): Examine all minimal
 128         symbols for exception types.
 129
 130 2019-04-30  Tom Tromey  <tromey@adacore.com>
 131
 132         PR c++/24470:
 133         * dwarf2read.c (process_structure_scope): Handle case where type
 134         has template parameters but no symbol was created.
 135
 136 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 137             Chris January  <chris.january@arm.com>
 138
 139         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 140         qualifier.
 141         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 142
 143 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 144
 145         * f-typeprint.c (f_print_type): Update rules for printing
 146         whitespace.
 147         (f_type_print_varspec_suffix): Likewise.
 148
 149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 150             Chris January  <chris.january@arm.com>
 151
 152         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 153         function arguments.
 154
 155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * f-lang.c (build_fortran_types): Change name of void type to
 158         lower case.
 159         * f-typeprint.c (f_type_print_base): Print the name of the void
 160         type, rather than a fixed string.
 161         * f-valprint.c (f_decorations): Use lower case void string.
 162
 163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 164             Chris January  <chris.january@arm.com>
 165
 166         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 167         types for Fortran.
 168
 169 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 170             Chris January  <chris.january@arm.com>
 171             David Lecomber  <david.lecomber@arm.com>
 172
 173         * f-exp.y (BINOP_INTRINSIC): New token.
 174         (exp): New parser rule handling BINOP_INTRINSIC.
 175         (f77_keywords): Add new builtin procedures.
 176         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 177         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 178         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 179         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 180         (print_unop_subexp_f): New function.
 181         (print_binop_subexp_f): New function.
 182         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 183         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 184         (dump_subexp_body_f): Likewise.
 185         (operator_check_f): Likewise.
 186         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 187         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 188
 189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 192         UNOP_KIND.
 193         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 194         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 195         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 196         (operator_length_f): New fuction.
 197         (print_subexp_f): New function.
 198         (op_name_f): New function.
 199         (dump_subexp_body_f): New function.
 200         (operator_check_f): New function.
 201         (exp_descriptor_f): Replace standard expression handling functions
 202         with new functions.
 203         * gdb/fortran-operator.def: New file.
 204         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 205         * gdb/std-operator.def: Remove UNOP_KIND.
 206
 207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * std-operator.def: Remove unbalanced, stray double quote
 210         character.
 211
 212 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 213             Chris January  <chris.january@arm.com>
 214             Daniel Everett  <daniel.everett@arm.com>
 215             Nick Forrington  <nick.forrington@arm.com>
 216             Richard Bunt  <richard.bunt@arm.com>
 217
 218         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 219         of depth when printing anonymous structs or unions.
 220         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 221         Don't print either the top-level value, or the children if the
 222         max-depth is exceeded.
 223         (ppscm_print_children): When printing the key of a map, allow one
 224         extra level of depth.
 225         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 226         print either the top-level value, or the children if the max-depth
 227         is exceeded.
 228         (print_children): When printing the key of a map, allow one extra
 229         level of depth.
 230         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 231         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 232         (user_print_options): Initialise max_depth field.
 233         (val_print_scalar_or_string_type_p): New function.
 234         (val_print): Check to see if the max depth has been reached.
 235         (val_print_check_max_depth): Define new function.
 236         (show_print_max_depth): New function.
 237         (_initialize_valprint): Add 'print max-depth' option.
 238         * valprint.h (struct value_print_options) <max_depth>: New field.
 239         (val_print_check_max_depth): Declare new function.
 240         * NEWS: Document new feature.
 241
 242 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * ada-lang.c (ada_language_defn): Initialise new field.
 245         * c-lang.c (c_is_string_type_p): New function.
 246         (c_language_defn): Initialise new field.
 247         (cplus_language_defn): Initialise new field.
 248         (asm_language_defn): Initialise new field.
 249         (minimal_language_defn): Initialise new field.
 250         * c-lang.h (c_is_string_type_p): Declare new function.
 251         * d-lang.c (d_language_defn): Initialise new field.
 252         * f-lang.c (f_is_string_type_p): New function.
 253         (f_language_defn): Initialise new field.
 254         * go-lang.c (go_is_string_type_p): New function.
 255         (go_language_defn): Initialise new field.
 256         * language.c (default_is_string_type_p): New function.
 257         (unknown_language_defn): Initialise new field.
 258         (auto_language_defn): Initialise new field.
 259         * language.h (struct language_defn) <la_is_string_type_p>: New
 260         member variable.
 261         (default_is_string_type_p): Declare new function.
 262         * m2-lang.c (m2_language_defn): Initialise new field.
 263         * objc-lang.c (objc_language_defn): Initialise new field.
 264         * opencl-lang.c (opencl_language_defn): Initialise new field.
 265         * p-lang.c (pascal_is_string_type_p): New function.
 266         (pascal_language_defn): Initialise new field.
 267         * rust-lang.c (rust_is_string_type_p): New function.
 268         (rust_language_defn): Initialise new field.
 269
 270 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 273         New field.
 274         * ada-lang.c (ada_language_defn): Initialise new field.
 275         * c-lang.c (c_language_defn): Likewise.
 276         (cplus_language_defn): Likewise.
 277         (asm_language_defn): Likewise.
 278         (minimal_language_defn): Likewise.
 279         * d-lang.c (d_language_defn): Likewise.
 280         * f-lang.c (f_language_defn): Likewise.
 281         * go-lang.c (go_language_defn): Likewise.
 282         * language.c (unknown_language_defn): Likewise.
 283         (auto_language_defn): Likewise.
 284         * m2-lang.c (m2_language_defn): Likewise.
 285         * objc-lang.c (objc_language_defn): Likewise.
 286         * opencl-lang.c (opencl_language_defn): Likewise.
 287         * p-lang.c (pascal_language_defn): Likewise.
 288         * rust-lang.c (rust_language_defn): Likewise.
 289
 290 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * ada-lang.c (ada_is_character_type): Change return type to bool.
 293         (ada_is_string_type): Likewise.
 294         * ada-lang.h (ada_is_character_type): Update declaration
 295         (ada_is_string_type): Likewise.
 296
 297 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 298
 299         Support style in 'frame|thread apply'
 300
 301         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 302         * record.c (record_start, record_stop): Update callers of
 303         execute_command_to_string with false.
 304         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 305         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 306         methods.
 307         (class string_file): New constructor with term_out parameter.
 308         Override methods term_out and can_emit_style_escape.  New member
 309         term_out.
 310         (class stdio_file): Override can_emit_style_escape.
 311         (class tee_file): Override term_out and can_emit_style_escape.
 312         * utils.h (can_emit_style_escape): Remove.
 313         * utils.c (can_emit_style_escape): Likewise.
 314         Update all callers of can_emit_style_escape (SOMESTREAM) to
 315         SOMESTREAM->can_emit_style_escape.
 316         * source-cache.c (source_cache::get_source_lines): Likewise.
 317         * stack.c (frame_apply_command_count): Call execute_command_to_string
 318         passing the term_out characteristic of the current gdb_stdout.
 319         * thread.c (thr_try_catch_cmd): Likewise.
 320         * top.c (execute_command_to_string): pass term_out parameter
 321         to construct the string_file for the command output.
 322         * ui-file.c (term_cli_styling): New function (most code moved
 323         from utils.c can_emit_style_escape).
 324         (string_file::string_file, string_file::can_emit_style_escape,
 325         stdio_file::can_emit_style_escape, tee_file::term_out,
 326         tee_file::can_emit_style_escape): New functions.
 327
 328 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 329
 330         * NEWS: Mention the new set|show may-call-functions.
 331         * infcall.c (may_call_functions_p): New variable.
 332         (show_may_call_functions_p): New function.
 333         (call_function_by_hand_dummy): Throws an error if not
 334         may-call-functions.
 335         (_initialize_infcall): Call add_setshow_boolean_cmd for
 336         may-call-functions.
 337
 338 2019-04-25  Keith Seitz  <keiths@redhat.com>
 339
 340         PR c++/24367
 341         * cp-support.c (inspect_type): Don't attempt substitutions
 342         of symbol with the same name.
 343
 344 2019-04-25  Tom Tromey  <tromey@adacore.com>
 345
 346         PR gdb/24475:
 347         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 348         static.
 349
 350 2019-04-25  Tom Tromey  <tromey@adacore.com>
 351
 352         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 353         rvalue reference.
 354         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 355         (gdb_xml_parser::parse): Use std::move.
 356         * python/python-internal.h (gdbpy_convert_exception): Take a const
 357         reference.
 358         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 359         std::move.
 360         * python/py-utils.c (gdbpy_convert_exception): Take a const
 361         reference.
 362         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 363         Use std::move.
 364         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 365         Use std::move.
 366         * mi/mi-main.c (mi_print_exception): Take a const reference.
 367         * main.c (handle_command_errors): Take a const reference.
 368         * linespec.c (parse_linespec): Use std::move.
 369         * infcall.c (run_inferior_call): Use std::move.
 370         (call_function_by_hand_dummy): Use std::move.
 371         * exec.c (try_open_exec_file): Use std::move.
 372         * exceptions.h (exception_print, exception_fprintf)
 373         (exception_print_same): Update.
 374         * exceptions.c (print_exception, exception_print)
 375         (exception_fprintf, exception_print_same): Change parameters to
 376         const reference.
 377         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 378         * common/new-op.c: Use std::move.
 379         * common/common-exceptions.h (struct gdb_exception): Add move
 380         constructor.
 381         (struct gdb_exception_error, struct gdb_exception_quit, struct
 382         gdb_quit_bad_alloc): Change constructor to move constructor.
 383         (throw_exception): Change parameter to rvalue reference.
 384         * common/common-exceptions.c (throw_exception): Take rvalue
 385         reference.
 386         * cli/cli-interp.c (safe_execute_command): Use std::move.
 387         * breakpoint.c (insert_bp_location, location_to_sals): Use
 388         std::move.
 389
 390 2019-04-25  Tom Tromey  <tromey@adacore.com>
 391
 392         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 393         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 394         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 395         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 396         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 397         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 398         guile/scm-value.c: Use unpack.
 399         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 400         gdbscm_gdb_exception.
 401         (gdbscm_throw_gdb_exception): Likewise.
 402         (struct gdbscm_gdb_exception): New.
 403         (unpack): New function.
 404         (gdbscm_wrap): Use unpack.
 405
 406 2019-04-25  Tom Tromey  <tromey@adacore.com>
 407
 408         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 409         (gdb_rl_callback_handler): Use std::move.
 410         * common/common-exceptions.h (struct gdb_exception): Add move
 411         assignment operator.
 412         (throw_exception_sjlj): Change "exception" to const reference.
 413         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 414         (throw_exception_sjlj): Change "exception" to const reference.
 415
 416 2019-04-25  Tom Tromey  <tromey@adacore.com>
 417
 418         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 419         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 420         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 421         Update.
 422         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 423         Update.
 424         * mi/mi-interp.c (mi_interp::exec): Update.
 425         * linespec.c (parse_linespec): Update.
 426         * infcall.c (run_inferior_call): Update.
 427         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 428         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 429         (gdbscm_lookup_global_symbol): Update.
 430         * guile/scm-param.c (gdbscm_parameter_value): Update.
 431         * guile/scm-frame.c (gdbscm_frame_read_register)
 432         (gdbscm_frame_read_var): Update.
 433         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 434         * exec.c (try_open_exec_file): Update.
 435         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 436         (gdb_rl_callback_handler): Update.
 437         * common/common-exceptions.h (exception_none): Don't declare.
 438         * common/common-exceptions.c (exception_none): Don't define.
 439         (struct catcher) <exception>: Update.
 440         * cli/cli-interp.c (safe_execute_command): Update.
 441         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 442
 443 2019-04-25  Ali Tamur  <tamur@google.com>
 444
 445         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 446         (read_attribute_value): Likewise.
 447         (dwarf2_read_addr_index): Update comment.
 448         (read_str_index): Add DW_FORM_strx.
 449         (dwarf2_string_attr): Likewise.
 450         (dwarf2_const_value_attr): Likewise.
 451         (dump_die_shallow): Likewise.
 452         (dwarf2_fetch_constant_bytes): Likewise.
 453         (skip_form_bytes): Likewise.
 454         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 455
 456 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 457
 458         PR corefiles/11608
 459         PR corefiles/18187
 460         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 461         OFFSET.  Verify if current mapping contains an ELF header.
 462         (linux_find_memory_regions_full): Adjust call to
 463         dump_mapping_p.
 464
 465 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 466             Kang Li <kanglictf@gmail.com>
 467
 468         PR gdb/21600
 469
 470         * dwarf2-frame.c (read_initial_length): Be consistent about using
 471         unsigned representation of length.
 472         (decode_frame_entry_1): Likewise.  Check for wraparound of
 473         end pointer as well as buffer overflow.
 474
 475 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 476
 477         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 478         "vq".
 479
 480 2019-04-24  Tom Tromey  <tromey@adacore.com>
 481
 482         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 483
 484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * s12z-tdep.c (s12z_unwind_pc): Delete.
 487         (s12z_unwind_sp): Delete.
 488         (s12z_gdbarch_init): Don't register deleted functions with
 489         gdbarch.
 490
 491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 492
 493         * rl78-tdep.c (rl78_unwind_sp): Delete.
 494         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 495
 496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 499         (xstormy16_unwind_pc): Delete.
 500         (xstormy16_dummy_id): Delete.
 501         (xstormy16_gdbarch_init): Don't register deleted functions with
 502         gdbarch.
 503
 504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * vax-tdep.c (vax_unwind_pc): Delete.
 507         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 508
 509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * v850-tdep.c (v850_unwind_sp): Delete.
 512         (v850_unwind_pc): Delete.
 513         (v850_dummy_id): Delete.
 514         (v850_gdbarch_init): Don't register deleted functions with
 515         gdbarch.
 516
 517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 520         (tilegx_unwind_pc): Delete.
 521         (tilegx_unwind_dummy_id): Delete.
 522         (tilegx_gdbarch_init): Don't register deleted functions with
 523         gdbarch.
 524
 525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 528         (tic6x_dummy_id): Delete.
 529         (tic6x_gdbarch_init): Don't register deleted functions with
 530         gdbarch.
 531
 532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * sparc-tdep.c (sparc_unwind_pc): Delete.
 535         (sparc32_gdbarch_init): Don't register deleted function with
 536         gdbarch.
 537
 538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * sh-tdep.c (sh_unwind_sp): Delete.
 541         (sh_unwind_pc): Delete.
 542         (sh_dummy_id): Delete.
 543         (sh_gdbarch_init): Don't register deleted functions with
 544         gdbarch.
 545
 546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * score-tdep.c (score_unwind_sp): Delete.
 549         (score_unwind_pc): Delete.
 550         (score_dummy_id): Delete.
 551         (score_gdbarch_init): Don't register deleted functions with
 552         gdbarch.
 553
 554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * rx-tdep.c (rx_unwind_pc): Delete.
 557         (rx_unwind_sp): Delete.
 558         (rx_dummy_id): Delete.
 559         (rx_gdbarch_init): Don't register deleted functions with
 560         gdbarch.  Update comment.
 561
 562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 565         (rs6000_dummy_id): Delete.
 566         (rs6000_gdbarch_init): Don't register deleted functions with
 567         gdbarch.
 568
 569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * or1k-tdep.c (or1k_dummy_id): Delete.
 572         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 573
 574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * nios2-tdep.c (nios2_dummy_id): Delete.
 577         (nios2_unwind_sp): Delete.
 578         (nios2_gdbarch_init): Don't register deleted functions with
 579         gdbarch.
 580
 581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * nds32-tdep.c (nds32_dummy_id): Delete.
 584         (nds32_unwind_pc): Delete.
 585         (nds32_unwind_sp): Delete.
 586         (nds32_gdbarch_init): Don't register deleted functions with
 587         gdbarch.
 588
 589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * msp430-tdep.c (msp430_unwind_pc): Delete.
 592         (msp430_unwind_sp): Delete.
 593         (msp430_dummy_id): Delete.
 594         (msp430_gdbarch_init): Don't register deleted functions with
 595         gdbarch.
 596
 597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * moxie-tdep.c (moxie_unwind_sp): Delete.
 600         (moxie_unwind_pc): Delete.
 601         (moxie_dummy_id): Delete.
 602         (moxie_gdbarch_init): Don't register deleted functions with
 603         gdbarch.
 604
 605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 608         (mn10300_unwind_pc): Delete.
 609         (mn10300_unwind_sp): Delete.
 610         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 611         mn10300_unwind_sp.
 612         (mn10300_frame_unwind_init): Don't register deleted functions with
 613         gdbarch.
 614
 615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 616
 617         * mep-tdep.c (mep_unwind_pc): Delete.
 618         (mep_unwind_sp): Delete.
 619         (mep_dummy_id): Delete.
 620         (mep_gdbarch_init): Don't register deleted functions with
 621         gdbarch.
 622
 623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 624
 625         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 626         (m68hc11_unwind_sp): Delete.
 627         (m68hc11_gdbarch_init): Don't register deleted functions with
 628         gdbarch.
 629
 630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * m32r-tdep.c (m32r_unwind_sp): Delete.
 633         (m32r_unwind_pc): Delete.
 634         (m32r_dummy_id): Delete.
 635         (m32r_gdbarch_init): Don't register deleted functions with
 636         gdbarch.
 637
 638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 639
 640         * m32c-tdep.c (m32c_unwind_pc): Delete.
 641         (m32c_unwind_sp): Delete.
 642         (m32c_dummy_id): Delete.
 643         (m32c_gdbarch_init): Don't register deleted functions with
 644         gdbarch.
 645
 646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 649         (lm32_unwind_pc): Delete.
 650         (lm32_dummy_id): Delete.
 651         (lm32_gdbarch_init): Don't register deleted functions with
 652         gdbarch.
 653
 654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 655
 656         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 657         (iq2000_unwind_pc): Delete.
 658         (iq2000_dummy_id): Delete.
 659         (iq2000_gdbarch_init): Don't register deleted functions with
 660         gdbarch.
 661
 662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * nds32-tdep.c (nds32_type_align): Delete.
 665         (nds32_push_dummy_call): Use type_align instead.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * arm-tdep.c (arm_type_align): Only handle vector override case.
 670         (arm_push_dummy_call): Use type_align.
 671         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 672
 673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 676         case.
 677         (pass_on_stack): Use type_align.
 678         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 679         function.
 680
 681 2019-04-23  Tom Tromey  <tromey@adacore.com>
 682
 683         * dwarf2read.c (line_header::file_name_at): Remove unused
 684         overload.
 685
 686 2019-04-23  Tom de Vries  <tdevries@suse.de>
 687
 688         PR gdb/24438
 689         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 690         invocation.
 691
 692
 693 2019-03-27  Ali Tamur  <tamur@google.com>
 694
 695         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 696         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 697         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 698         (dwarf_expr_context::get_addr_index): Likewise
 699         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 700         (symbol_needs_eval_context::get_addr_index): Likewise
 701         (disassemble_dwarf_expression): Add DW_OP_addrx
 702         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 703         (read_cutu_die_from_dwo): Update comment
 704         (skip_one_die): Add DW_FORM_addrx
 705         (read_attribute_value): Likewise
 706         (var_decode_location): Add DW_OP_addrx
 707         (dwarf2_const_value_attr): Add DW_FORM_addrx
 708         (dump_die_shallow): Likewise
 709         (dwarf2_fetch_constant_bytes): Likewise
 710         (decode_locdesc): Add DW_OP_addrx
 711         (skip_form_bytes): Add DW_FORM_addrx
 712
 713 2019-04-22  Ali Tamur  <tamur@google.com>
 714
 715         * MAINTAINERS (Write After Approval): Add self.
 716
 717 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 718
 719         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 720         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 721         (open_symbol_file_object): Likewise.
 722         (svr4_default_sos): Add info parameter.
 723         (svr4_read_so_list): Likewise.
 724         (svr4_current_sos_direct): Adjust functions calls to pass down
 725         info.
 726         (svr4_current_sos_1): Add info parameter.
 727         (svr4_current_sos): Call get_svr4_info, pass info down to
 728         svr4_current_sos_1.
 729         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 730         get_svr4_info.
 731         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 732         get_svr4_info.
 733         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 734         to get_svr4_info.
 735         (probes_table_remove_objfile_probes): Likewise.
 736         (register_solib_event_probe): Add info parameter.
 737         (solist_update_incremental): Pass info parameter down to
 738         svr4_read_so_list.
 739         (disable_probes_interface): Add info parameter.
 740         (svr4_handle_solib_event): Pass current_program_space to
 741         get_svr4_info.  Adjust disable_probes_interface cleanup.
 742         (svr4_create_probe_breakpoints): Add info parameter, pass it
 743         down to register_solib_event_probe.
 744         (svr4_create_solib_event_breakpoints): Add info parameter,
 745         pass it down to svr4_create_probe_breakpoints.
 746         (enable_break): Pass info down to
 747         svr4_create_solib_event_breakpoints.
 748         (svr4_solib_create_inferior_hook): Pass current_program_space to
 749         get_svr4_info.
 750         (svr4_clear_solib): Likewise.
 751
 752 2019-04-22  Pedro Alves  <palves@redhat.com>
 753
 754         * solib-svr4.c (svr4_free_objfile_observer): New.
 755         (probe_and_action::objfile): New field.
 756         (probes_table_htab_remove_objfile_probes)
 757         (probes_table_remove_objfile_probes): New functions.
 758         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 759         in the new probe_and_action.  Don't store the probe in 'lookup'.
 760         (svr4_create_probe_breakpoints): Pass objfile to
 761         register_solib_event_probe.
 762         (_initialize_svr4_solib): Register a free_objfile observer.
 763
 764 2019-04-19  Tom Tromey  <tom@tromey.com>
 765
 766         * common/queue.h: Remove.
 767
 768 2019-04-19  Tom Tromey  <tom@tromey.com>
 769
 770         * event-loop.c: Don't include "common/queue.h".
 771
 772 2019-04-19  Tom Tromey  <tom@tromey.com>
 773
 774         * remote.c (remote_target): Use delete.
 775         * remote-notif.h: Include <list>, not "common/queue.h".
 776         (notif_client_p): Remove typedef.
 777         (remote_notif_state): Add constructor, destructor, initializer.
 778         <notif_queue>: Now a std::list.
 779         (remote_notif_state_xfree): Don't declare.
 780         * remote-notif.c (remote_notif_process, handle_notification)
 781         (remote_notif_state_allocate): Update.
 782         (~remote_notif_state): Rename from remote_notif_state_xfree.
 783
 784 2019-04-19  Tom Tromey  <tom@tromey.com>
 785
 786         * symfile.c (reread_symbols): Update.
 787         * objfiles.c (objfile_register_static_link)
 788         (objfile_lookup_static_link): Update
 789         (~objfile) Don't delete static_links.
 790         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 791
 792 2019-04-19  Tom Tromey  <tom@tromey.com>
 793
 794         * type-stack.h (struct type_stack) <insert>: Constify string.
 795         * type-stack.c (type_stack::insert): Constify string.
 796         * gdbtypes.h (lookup_template_type): Update.
 797         (address_space_name_to_int): Update.
 798         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 799         const.
 800         (lookup_template_type): Make name const.
 801         * c-exp.y: Update rules.
 802         (lex_one_token, classify_name, classify_inner_name)
 803         (c_print_token): Update.
 804         * p-exp.y: Update rules.
 805         (yylex): Update.
 806         * f-exp.y: Update rules.
 807         (yylex): Update.
 808         * d-exp.y: Update rules.
 809         (lex_one_token, classify_name, classify_inner_name): Update.
 810         * parse.c (write_dollar_variable, copy_name): Return std::string.
 811         * parser-defs.h (copy_name): Change return type.
 812         * m2-exp.y: Update rules.
 813         (yylex): Update.
 814         * go-exp.y (lex_one_token): Update.
 815         Update rules.
 816         (classify_unsafe_function, classify_packaged_name)
 817         (classify_name, yylex): Update.
 818
 819 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 820
 821         * configure.ac: add --enable-source-highlight switch.
 822         * configure: Regenerate.
 823         * top.c (print_gdb_version): plumb --enable-source-highlight
 824         status to "show configuration".
 825
 826 2019-04-19  Tom Tromey  <tromey@adacore.com>
 827
 828         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 829         Check ADA_TYPE_P.
 830         (empty_record, ada_template_to_fixed_record_type_1)
 831         (template_to_static_fixed_type)
 832         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 833         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 834         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 835         macros.
 836
 837 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 838
 839         PR symtab/24423:
 840         * source.c (print_source_lines_base): Advance "iter" when a
 841         control character is seen.
 842
 843 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 844
 845         * inferior.h (struct infcall_suspend_state_deleter):
 846         Catch exception in destructor to avoid crash.
 847
 848 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 849
 850         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 851         close to the add_com "shell".
 852
 853 2019-04-18  Tom Tromey  <tromey@adacore.com>
 854
 855         * process-stratum-target.h (class process_stratum_target)
 856         <stratum>: Add "final".
 857
 858 2019-04-17  Tom Tromey  <tromey@adacore.com>
 859
 860         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 861         against nullptr before use.
 862
 863 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 864
 865         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 866
 867 2019-04-17  Jim Wilson  <jimw@sifive.com>
 868             Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 871         code read might fail, assume 4-byte breakpoint in that case.
 872
 873 2019-04-15  Leszek Swirski  <leszeks@google.com>
 874
 875         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 876         rather than a hand-rolled POD check when checking for forced MEMORY
 877         classification.
 878
 879 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 880
 881         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 882         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 883         function.
 884         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 885         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 886         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 887         declaration.
 888
 889 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 890
 891         * aarch64-linux-nat.c
 892         (aarch64_linux_nat_target::thread_architecture): Add override.
 893         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 894         each VQ.
 895
 896 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 899
 900 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 903         target types of size 96-bits, add some additional comments, and
 904         check that the builtin type we found was the correct size.
 905
 906 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 907
 908         * utils.c (prompt_for_continue): Don't restore the styling at the
 909         end, as applied_style has the wrong value.  This fixes styling in
 910         long lists of file names that are interrupted by the "Continue?"
 911         prompt.
 912
 913 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 916         * c-lang.c (c_language_defn): Likewise.
 917         (cplus_language_defn): Likewise.
 918         (asm_language_defn): Likewise.
 919         (minimal_language_defn): Likewise.
 920         * d-lang.c (d_language_defn): Likewise.
 921         * f-lang.c (f_language_defn): Likewise.
 922         * go-lang.c (go_language_defn): Likewise.
 923         * language.c (unknown_language_defn): Likewise.
 924         (auto_language_defn): Likewise.
 925         * language.h (struct language_defn): Remove la_magic field.
 926         (LANG_MAGIC): Delete.
 927         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 928         * objc-lang.c (objc_language_defn): Likewise.
 929         * opencl-lang.c (opencl_language_defn): Likewise.
 930         * p-lang.c (pascal_language_defn): Likewise.
 931         * rust-lang.c (rust_language_defn): Likewise.
 932
 933 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * riscv-tdep.c (riscv_type_align): New function.
 936         (riscv_type_alignment): Delete.
 937         (riscv_arg_location): Use 'type_align'.
 938         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 939
 940 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * gdbtypes.c (type_align): A struct with no non-static fields also
 943         has alignment of 1.
 944
 945 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 948         component to 0.
 949         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 950         member.
 951         (riscv_struct_info::analyse): New implementation using new
 952         analyse_inner member function.
 953         (riscv_struct_info::field_offset): New member function.
 954         (riscv_struct_info::m_offsets): New member variable.
 955         (riscv_struct_info::analyse_inner): New private member function,
 956         takes the old implementation of riscv_struct_info::analyse but
 957         extended to track field offsets.
 958         (riscv_call_arg_struct): Update the struct folding special cases
 959         to handle cases where empty C++ structs, which are non-zero
 960         length, are found.
 961         (riscv_arg_location): Initialise the length of each location, a
 962         non-zero length now indicates the location is in use.
 963         (riscv_push_dummy_call): Allow for the first location having a
 964         non-zero offset when setting up arguments.
 965         (riscv_return_value): Likewise, but for return values.
 966
 967 2019-04-11  Tom Tromey  <tromey@adacore.com>
 968
 969         * utils.c (internal_vproblem): Make "msg" const.
 970
 971 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 972
 973         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 974         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 975         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 976         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 977
 978 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 979
 980         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 981         function.
 982         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 983         of amd64_collect_native_gregset.
 984         (amd64_linux_nat_target::store_registers): Likewise.
 985
 986 2019-04-10  Tom Tromey  <tom@tromey.com>
 987
 988         * symtab.c (lookup_global_symbol_from_objfile)
 989         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 990         * objfiles.h (class separate_debug_iterator): New.
 991         (class separate_debug_range): New.
 992         (struct objfile) <separate_debug_objfiles>: New method.
 993         (objfile_separate_debug_iterate): Don't declare.
 994         * objfiles.c (separate_debug_iterator::operator++): Rename from
 995         objfile_separate_debug_iterate.
 996         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 997         iterator.
 998         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 999         iterator.
1000
1001 2019-04-10  Tom Tromey  <tom@tromey.com>
1002
1003         * symfile.c (reread_symbols): Remove old comment.
1004         * objfiles.c (free_all_objfiles): Fix a typo.
1005
1006 2019-04-10  Tom Tromey  <tom@tromey.com>
1007
1008         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1009         * minsyms.c (lookup_minimal_symbol): Use foreach.
1010         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1011         (lookup_minimal_symbol_solib_trampoline): Likewise.
1012         * symfile.c (reread_symbols): Use foreach.
1013
1014 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1015             Tom Tromey  <tromey@adacore.com>
1016
1017         PR rust/24414:
1018         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1019         (rust_lex_int_test): Change "value" to be LONGEST.
1020         (rust_lex_tests): Add test for long integer literal.
1021
1022 2019-04-09  Tom Tromey  <tromey@adacore.com>
1023
1024         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1025         to bool.
1026         (extended_remote_target::attach): Update.
1027         (remote_target::remote_notice_new_inferior): Update.
1028         (remote_target::add_current_inferior_and_thread): Update.
1029         * inferior.c (exit_inferior_1): Use "false".
1030         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1031
1032 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1033
1034         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1035         the "start" command.
1036
1037 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1038
1039         * python/py-inferior.c (infpy_thread_from_thread_handle):
1040         Adjust comments to reflect renaming of thread_from_thread_handle
1041         to thread_from_handle.  Adjust keywords.  Fix type error message.
1042         (inferior_object_methods): Add thread_from_handle.  Retain
1043         thread_from_thread_handle, but mark it as deprecated.
1044
1045 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1046
1047         * gdbthread.h (find_thread_by_handle): Revise declaration.
1048         * thread.c (find_thread_by_handle): Likewise.  Adjust
1049         implementation too.
1050         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1051         support for buffer objects as handles.
1052
1053 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1054
1055         * python/py-infthread.c (thpy_thread_handle): New function.
1056         (thread_object_methods): Register thpy_thread_handle.
1057
1058 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1059
1060         * gdbthread.h (thread_to_thread_handle): Declare.
1061         * thread.c (gdbtypes.h): Include.
1062         (thread_to_thread_handle): New function.
1063
1064         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1065         (target_thread_info_to_thread_handle): Declare.
1066         * target.c (target_thread_info_to_thread_handle): New function.
1067         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1068         * target-delegates.c: Regenerate.
1069
1070         * linux-thread-db.c (class thread_db_target): Add method
1071         thread_info_to_thread_handle.
1072         (thread_db_target::thread_info_to_thread_handle): Define.
1073         * remote.c (class remote_target): Add new method
1074         thread_info_to_thread_handle.
1075         (remote_target::thread_info_to_thread_handle): Define.
1076
1077 2019-04-08  Pedro Alves  <palves@redhat.com>
1078
1079         * common/common-exceptions.c (throw_exception): Don't create
1080         named object to throw; throw directly.
1081         (throw_it): Likewise.  Don't initialize gdb_exception::message
1082         here, with new; pass FMT and AP to the ctor instead.
1083         * common/common-exceptions.h: Include <string>.
1084         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1085         const char *, va_list)): New ctor.  Use std::make_shared.
1086         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1087         errors)): Delete.
1088         (gdb_exception_error::gdb_exception_error(enum errors, const char
1089         *, va_list)): New.
1090         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1091         Add assertion.
1092         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1093         errors)): Delete.
1094         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1095         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1096         Add assertion.
1097
1098 2019-04-08  Tom Tromey  <tom@tromey.com>
1099
1100         * valops.c (value_rtti_indirect_type): Replace throw_exception
1101         with throw.
1102         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1103         with throw.
1104         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1105         throw.
1106         * target.c (target_translate_tls_address): Replace throw_exception
1107         with throw.
1108         * stack.c (frame_apply_command_count): Replace throw_exception
1109         with throw.
1110         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1111         throw.
1112         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1113         with throw.
1114         * rs6000-tdep.c (rs6000_frame_cache)
1115         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1116         * remote.c: Replace throw_exception with throw.
1117         * record-full.c (record_full_message, record_full_wait_1)
1118         (record_full_restore): Replace throw_exception with throw.
1119         * record-btrace.c:
1120         (get_thread_current_frame_id, record_btrace_start_replaying)
1121         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1122         (cmd_record_btrace_start): Replace throw_exception with throw.
1123         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1124         throw.
1125         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1126         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1127         * linespec.c:
1128         (find_linespec_symbols): Replace throw_exception with throw.
1129         * infrun.c (displaced_step_prepare, resume): Replace
1130         throw_exception with throw.
1131         * infcmd.c (post_create_inferior): Replace throw_exception with
1132         throw.
1133         * inf-loop.c (inferior_event_handler): Replace throw_exception
1134         with throw.
1135         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1136         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1137         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1138         (get_prev_frame_always, get_frame_pc_if_available)
1139         (get_frame_address_in_block_if_available, get_frame_language):
1140         Replace throw_exception with throw.
1141         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1142         throw_exception with throw.
1143         * eval.c (fetch_subexp_value, evaluate_var_value)
1144         (evaluate_funcall, evaluate_subexp_standard): Replace
1145         throw_exception with throw.
1146         * dwarf2loc.c (call_site_find_chain)
1147         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1148         Replace throw_exception with throw.
1149         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1150         with throw.
1151         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1152         throw.
1153         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1154         * completer.c (complete_line_internal): Replace throw_exception
1155         with throw.
1156         * compile/compile-object-run.c (compile_object_run): Replace
1157         throw_exception with throw.
1158         * cli/cli-script.c (process_next_line): Replace throw_exception
1159         with throw.
1160         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1161         (btrace_enable, btrace_maint_update_pt_packets): Replace
1162         throw_exception with throw.
1163         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1164         throw_exception with throw.
1165         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1166         throw_exception with throw.
1167         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1168         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1169         * aarch64-tdep.c (aarch64_make_prologue_cache)
1170         (aarch64_make_stub_cache): Replace throw_exception with throw.
1171
1172 2019-04-08  Tom Tromey  <tom@tromey.com>
1173
1174         * common/common-exceptions.c (throw_exception): Rename from
1175         throw_exception_cxx.  Remove old copy.  Make argument const.
1176         (throw_it): Create and throw exception objects directly.
1177         * common/common-exceptions.h (throw_exception): Make argument
1178         const.
1179         (struct gdb_exception_error): Add constructor.
1180         (struct gdb_exception_quit): Add constructor.
1181
1182 2019-04-08  Tom Tromey  <tom@tromey.com>
1183
1184         * common/common-exceptions.h (exception_rethrow): Don't declare.
1185         (TRY_SJLJ): Update comment.
1186         (TRY, CATCH, END_CATCH): Remove.
1187         * common/common-exceptions.c (exception_rethrow): Remove.
1188
1189 2019-04-08  Tom Tromey  <tom@tromey.com>
1190
1191         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1192         Remove.
1193         (gdb_exception_error): Rename from
1194         gdb_exception_RETURN_MASK_ERROR.
1195         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1196         (gdb_quit_bad_alloc): Update.
1197         * aarch64-tdep.c: Update.
1198         * ada-lang.c: Update.
1199         * ada-typeprint.c: Update.
1200         * ada-valprint.c: Update.
1201         * amd64-tdep.c: Update.
1202         * arch-utils.c: Update.
1203         * break-catch-throw.c: Update.
1204         * breakpoint.c: Update.
1205         * btrace.c: Update.
1206         * c-varobj.c: Update.
1207         * cli/cli-cmds.c: Update.
1208         * cli/cli-interp.c: Update.
1209         * cli/cli-script.c: Update.
1210         * common/common-exceptions.c: Update.
1211         * common/new-op.c: Update.
1212         * common/selftest.c: Update.
1213         * compile/compile-c-symbols.c: Update.
1214         * compile/compile-cplus-symbols.c: Update.
1215         * compile/compile-object-load.c: Update.
1216         * compile/compile-object-run.c: Update.
1217         * completer.c: Update.
1218         * corelow.c: Update.
1219         * cp-abi.c: Update.
1220         * cp-support.c: Update.
1221         * cp-valprint.c: Update.
1222         * darwin-nat.c: Update.
1223         * disasm-selftests.c: Update.
1224         * dtrace-probe.c: Update.
1225         * dwarf-index-cache.c: Update.
1226         * dwarf-index-write.c: Update.
1227         * dwarf2-frame-tailcall.c: Update.
1228         * dwarf2-frame.c: Update.
1229         * dwarf2loc.c: Update.
1230         * dwarf2read.c: Update.
1231         * eval.c: Update.
1232         * event-loop.c: Update.
1233         * event-top.c: Update.
1234         * exec.c: Update.
1235         * f-valprint.c: Update.
1236         * fbsd-tdep.c: Update.
1237         * frame-unwind.c: Update.
1238         * frame.c: Update.
1239         * gdbtypes.c: Update.
1240         * gnu-v3-abi.c: Update.
1241         * guile/guile-internal.h: Update.
1242         * guile/scm-block.c: Update.
1243         * guile/scm-breakpoint.c: Update.
1244         * guile/scm-cmd.c: Update.
1245         * guile/scm-disasm.c: Update.
1246         * guile/scm-frame.c: Update.
1247         * guile/scm-lazy-string.c: Update.
1248         * guile/scm-math.c: Update.
1249         * guile/scm-param.c: Update.
1250         * guile/scm-ports.c: Update.
1251         * guile/scm-pretty-print.c: Update.
1252         * guile/scm-symbol.c: Update.
1253         * guile/scm-symtab.c: Update.
1254         * guile/scm-type.c: Update.
1255         * guile/scm-value.c: Update.
1256         * i386-linux-tdep.c: Update.
1257         * i386-tdep.c: Update.
1258         * inf-loop.c: Update.
1259         * infcall.c: Update.
1260         * infcmd.c: Update.
1261         * infrun.c: Update.
1262         * jit.c: Update.
1263         * language.c: Update.
1264         * linespec.c: Update.
1265         * linux-fork.c: Update.
1266         * linux-nat.c: Update.
1267         * linux-tdep.c: Update.
1268         * linux-thread-db.c: Update.
1269         * main.c: Update.
1270         * mi/mi-cmd-break.c: Update.
1271         * mi/mi-cmd-stack.c: Update.
1272         * mi/mi-interp.c: Update.
1273         * mi/mi-main.c: Update.
1274         * objc-lang.c: Update.
1275         * p-valprint.c: Update.
1276         * parse.c: Update.
1277         * ppc-linux-tdep.c: Update.
1278         * printcmd.c: Update.
1279         * python/py-arch.c: Update.
1280         * python/py-breakpoint.c: Update.
1281         * python/py-cmd.c: Update.
1282         * python/py-finishbreakpoint.c: Update.
1283         * python/py-frame.c: Update.
1284         * python/py-framefilter.c: Update.
1285         * python/py-gdb-readline.c: Update.
1286         * python/py-inferior.c: Update.
1287         * python/py-infthread.c: Update.
1288         * python/py-lazy-string.c: Update.
1289         * python/py-linetable.c: Update.
1290         * python/py-objfile.c: Update.
1291         * python/py-param.c: Update.
1292         * python/py-prettyprint.c: Update.
1293         * python/py-progspace.c: Update.
1294         * python/py-record-btrace.c: Update.
1295         * python/py-record.c: Update.
1296         * python/py-symbol.c: Update.
1297         * python/py-type.c: Update.
1298         * python/py-unwind.c: Update.
1299         * python/py-utils.c: Update.
1300         * python/py-value.c: Update.
1301         * python/python.c: Update.
1302         * record-btrace.c: Update.
1303         * record-full.c: Update.
1304         * remote-fileio.c: Update.
1305         * remote.c: Update.
1306         * riscv-tdep.c: Update.
1307         * rs6000-aix-tdep.c: Update.
1308         * rs6000-tdep.c: Update.
1309         * rust-exp.y: Update.
1310         * rust-lang.c: Update.
1311         * s390-tdep.c: Update.
1312         * selftest-arch.c: Update.
1313         * solib-dsbt.c: Update.
1314         * solib-frv.c: Update.
1315         * solib-spu.c: Update.
1316         * solib-svr4.c: Update.
1317         * solib.c: Update.
1318         * sparc64-linux-tdep.c: Update.
1319         * stack.c: Update.
1320         * symfile-mem.c: Update.
1321         * symmisc.c: Update.
1322         * target.c: Update.
1323         * thread.c: Update.
1324         * top.c: Update.
1325         * tracefile-tfile.c: Update.
1326         * tui/tui.c: Update.
1327         * typeprint.c: Update.
1328         * unittests/cli-utils-selftests.c: Update.
1329         * unittests/parse-connection-spec-selftests.c: Update.
1330         * valops.c: Update.
1331         * valprint.c: Update.
1332         * value.c: Update.
1333         * varobj.c: Update.
1334         * windows-nat.c: Update.
1335         * x86-linux-nat.c: Update.
1336         * xml-support.c: Update.
1337
1338 2019-04-08  Tom Tromey  <tom@tromey.com>
1339
1340         * xml-support.c: Use C++ exception handling.
1341         * x86-linux-nat.c: Use C++ exception handling.
1342         * windows-nat.c: Use C++ exception handling.
1343         * varobj.c: Use C++ exception handling.
1344         * value.c: Use C++ exception handling.
1345         * valprint.c: Use C++ exception handling.
1346         * valops.c: Use C++ exception handling.
1347         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1348         handling.
1349         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1350         * typeprint.c: Use C++ exception handling.
1351         * tui/tui.c: Use C++ exception handling.
1352         * tracefile-tfile.c: Use C++ exception handling.
1353         * top.c: Use C++ exception handling.
1354         * thread.c: Use C++ exception handling.
1355         * target.c: Use C++ exception handling.
1356         * symmisc.c: Use C++ exception handling.
1357         * symfile-mem.c: Use C++ exception handling.
1358         * stack.c: Use C++ exception handling.
1359         * sparc64-linux-tdep.c: Use C++ exception handling.
1360         * solib.c: Use C++ exception handling.
1361         * solib-svr4.c: Use C++ exception handling.
1362         * solib-spu.c: Use C++ exception handling.
1363         * solib-frv.c: Use C++ exception handling.
1364         * solib-dsbt.c: Use C++ exception handling.
1365         * selftest-arch.c: Use C++ exception handling.
1366         * s390-tdep.c: Use C++ exception handling.
1367         * rust-lang.c: Use C++ exception handling.
1368         * rust-exp.y: Use C++ exception handling.
1369         * rs6000-tdep.c: Use C++ exception handling.
1370         * rs6000-aix-tdep.c: Use C++ exception handling.
1371         * riscv-tdep.c: Use C++ exception handling.
1372         * remote.c: Use C++ exception handling.
1373         * remote-fileio.c: Use C++ exception handling.
1374         * record-full.c: Use C++ exception handling.
1375         * record-btrace.c: Use C++ exception handling.
1376         * python/python.c: Use C++ exception handling.
1377         * python/py-value.c: Use C++ exception handling.
1378         * python/py-utils.c: Use C++ exception handling.
1379         * python/py-unwind.c: Use C++ exception handling.
1380         * python/py-type.c: Use C++ exception handling.
1381         * python/py-symbol.c: Use C++ exception handling.
1382         * python/py-record.c: Use C++ exception handling.
1383         * python/py-record-btrace.c: Use C++ exception handling.
1384         * python/py-progspace.c: Use C++ exception handling.
1385         * python/py-prettyprint.c: Use C++ exception handling.
1386         * python/py-param.c: Use C++ exception handling.
1387         * python/py-objfile.c: Use C++ exception handling.
1388         * python/py-linetable.c: Use C++ exception handling.
1389         * python/py-lazy-string.c: Use C++ exception handling.
1390         * python/py-infthread.c: Use C++ exception handling.
1391         * python/py-inferior.c: Use C++ exception handling.
1392         * python/py-gdb-readline.c: Use C++ exception handling.
1393         * python/py-framefilter.c: Use C++ exception handling.
1394         * python/py-frame.c: Use C++ exception handling.
1395         * python/py-finishbreakpoint.c: Use C++ exception handling.
1396         * python/py-cmd.c: Use C++ exception handling.
1397         * python/py-breakpoint.c: Use C++ exception handling.
1398         * python/py-arch.c: Use C++ exception handling.
1399         * printcmd.c: Use C++ exception handling.
1400         * ppc-linux-tdep.c: Use C++ exception handling.
1401         * parse.c: Use C++ exception handling.
1402         * p-valprint.c: Use C++ exception handling.
1403         * objc-lang.c: Use C++ exception handling.
1404         * mi/mi-main.c: Use C++ exception handling.
1405         * mi/mi-interp.c: Use C++ exception handling.
1406         * mi/mi-cmd-stack.c: Use C++ exception handling.
1407         * mi/mi-cmd-break.c: Use C++ exception handling.
1408         * main.c: Use C++ exception handling.
1409         * linux-thread-db.c: Use C++ exception handling.
1410         * linux-tdep.c: Use C++ exception handling.
1411         * linux-nat.c: Use C++ exception handling.
1412         * linux-fork.c: Use C++ exception handling.
1413         * linespec.c: Use C++ exception handling.
1414         * language.c: Use C++ exception handling.
1415         * jit.c: Use C++ exception handling.
1416         * infrun.c: Use C++ exception handling.
1417         * infcmd.c: Use C++ exception handling.
1418         * infcall.c: Use C++ exception handling.
1419         * inf-loop.c: Use C++ exception handling.
1420         * i386-tdep.c: Use C++ exception handling.
1421         * i386-linux-tdep.c: Use C++ exception handling.
1422         * guile/scm-value.c: Use C++ exception handling.
1423         * guile/scm-type.c: Use C++ exception handling.
1424         * guile/scm-symtab.c: Use C++ exception handling.
1425         * guile/scm-symbol.c: Use C++ exception handling.
1426         * guile/scm-pretty-print.c: Use C++ exception handling.
1427         * guile/scm-ports.c: Use C++ exception handling.
1428         * guile/scm-param.c: Use C++ exception handling.
1429         * guile/scm-math.c: Use C++ exception handling.
1430         * guile/scm-lazy-string.c: Use C++ exception handling.
1431         * guile/scm-frame.c: Use C++ exception handling.
1432         * guile/scm-disasm.c: Use C++ exception handling.
1433         * guile/scm-cmd.c: Use C++ exception handling.
1434         * guile/scm-breakpoint.c: Use C++ exception handling.
1435         * guile/scm-block.c: Use C++ exception handling.
1436         * guile/guile-internal.h: Use C++ exception handling.
1437         * gnu-v3-abi.c: Use C++ exception handling.
1438         * gdbtypes.c: Use C++ exception handling.
1439         * frame.c: Use C++ exception handling.
1440         * frame-unwind.c: Use C++ exception handling.
1441         * fbsd-tdep.c: Use C++ exception handling.
1442         * f-valprint.c: Use C++ exception handling.
1443         * exec.c: Use C++ exception handling.
1444         * event-top.c: Use C++ exception handling.
1445         * event-loop.c: Use C++ exception handling.
1446         * eval.c: Use C++ exception handling.
1447         * dwarf2read.c: Use C++ exception handling.
1448         * dwarf2loc.c: Use C++ exception handling.
1449         * dwarf2-frame.c: Use C++ exception handling.
1450         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1451         * dwarf-index-write.c: Use C++ exception handling.
1452         * dwarf-index-cache.c: Use C++ exception handling.
1453         * dtrace-probe.c: Use C++ exception handling.
1454         * disasm-selftests.c: Use C++ exception handling.
1455         * darwin-nat.c: Use C++ exception handling.
1456         * cp-valprint.c: Use C++ exception handling.
1457         * cp-support.c: Use C++ exception handling.
1458         * cp-abi.c: Use C++ exception handling.
1459         * corelow.c: Use C++ exception handling.
1460         * completer.c: Use C++ exception handling.
1461         * compile/compile-object-run.c: Use C++ exception handling.
1462         * compile/compile-object-load.c: Use C++ exception handling.
1463         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1464         * compile/compile-c-symbols.c: Use C++ exception handling.
1465         * common/selftest.c: Use C++ exception handling.
1466         * common/new-op.c: Use C++ exception handling.
1467         * cli/cli-script.c: Use C++ exception handling.
1468         * cli/cli-interp.c: Use C++ exception handling.
1469         * cli/cli-cmds.c: Use C++ exception handling.
1470         * c-varobj.c: Use C++ exception handling.
1471         * btrace.c: Use C++ exception handling.
1472         * breakpoint.c: Use C++ exception handling.
1473         * break-catch-throw.c: Use C++ exception handling.
1474         * arch-utils.c: Use C++ exception handling.
1475         * amd64-tdep.c: Use C++ exception handling.
1476         * ada-valprint.c: Use C++ exception handling.
1477         * ada-typeprint.c: Use C++ exception handling.
1478         * ada-lang.c: Use C++ exception handling.
1479         * aarch64-tdep.c: Use C++ exception handling.
1480
1481 2019-04-08  Tom Tromey  <tom@tromey.com>
1482
1483         * xml-support.c (gdb_xml_parser::parse): Update.
1484         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1485         * value.c (show_convenience): Update.
1486         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1487         (test_parse_flags_qcs): Update.
1488         * thread.c (thr_try_catch_cmd): Update.
1489         * target.c (target_translate_tls_address): Update.
1490         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1491         (info_frame_command_core, frame_apply_command_count): Update.
1492         * rust-exp.y (rust_lex_exception_test): Update.
1493         * riscv-tdep.c (riscv_print_one_register_info): Update.
1494         * remote.c (remote_target::enable_btrace): Update.
1495         * record-btrace.c (record_btrace_enable_warn): Update.
1496         * python/py-utils.c (gdbpy_convert_exception): Update.
1497         * printcmd.c (do_one_display, print_variable_and_value): Update.
1498         * mi/mi-main.c (mi_print_exception): Update.
1499         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1500         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1501         * linux-nat.c (linux_nat_target::attach): Update.
1502         * linux-fork.c (class scoped_switch_fork_info): Update.
1503         * infrun.c (displaced_step_prepare): Update.
1504         * infcall.c (call_function_by_hand_dummy): Update.
1505         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1506         * gnu-v3-abi.c (print_one_vtable): Update.
1507         * frame.c (get_prev_frame_always): Update.
1508         * f-valprint.c (info_common_command_for_block): Update.
1509         * exec.c (try_open_exec_file): Update.
1510         * exceptions.c (print_exception, exception_print)
1511         (exception_fprintf, exception_print_same): Update.
1512         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1513         * dwarf-index-cache.c (index_cache::store)
1514         (index_cache::lookup_gdb_index): Update.
1515         * darwin-nat.c (maybe_cache_shell): Update.
1516         * cp-valprint.c (cp_print_value_fields): Update.
1517         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1518         (gcc_cplus_symbol_address): Update.
1519         * compile/compile-c-symbols.c (gcc_convert_symbol)
1520         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1521         * common/selftest.c: Update.
1522         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1523         a std::string.
1524         (exception_try_scope_entry, exception_try_scope_exit): Don't
1525         declare.
1526         (struct exception_try_scope): Remove.
1527         (TRY): Don't use exception_try_scope.
1528         (struct gdb_exception): Add constructor, operator=.
1529         <what>: New method.
1530         (struct gdb_exception_RETURN_MASK_ALL)
1531         (struct gdb_exception_RETURN_MASK_ERROR)
1532         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1533         (struct gdb_quit_bad_alloc): Update.
1534         * common/common-exceptions.c (exception_none): Change
1535         initializer.
1536         (struct catcher) <state, exception>: Initialize inline.
1537         <prev>: Remove member.
1538         (current_catcher): Remove.
1539         (catchers): New global.
1540         (exceptions_state_mc_init): Simplify.
1541         (catcher_pop): Remove.
1542         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1543         (try_scope_depth, exception_try_scope_entry)
1544         (exception_try_scope_exit): Remove.
1545         (throw_exception_sjlj): Update.
1546         (exception_messages, exception_messages_size): Remove.
1547         (throw_it): Simplify.
1548         (gdb_exception_sliced_copy): Remove.
1549         (throw_exception_cxx): Update.
1550         * cli/cli-script.c (script_from_file): Update.
1551         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1552         Update.
1553         * ada-valprint.c (ada_val_print): Update.
1554         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1555         (create_excep_cond_exprs): Update.
1556
1557 2019-04-08  Tom Tromey  <tom@tromey.com>
1558
1559         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1560         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1561         (TRY, CATCH, END_CATCH): Remove some definitions.
1562         * common/common-exceptions.c: Don't use GDB_XCPT.
1563         (catcher_list_size): Remove.
1564         (throw_exception, throw_it): Simplify.
1565
1566 2019-04-05  Tom Tromey  <tom@tromey.com>
1567
1568         Revert the header-sorting patch.
1569         * ft32-tdep.c: Revert.
1570         * frv-tdep.c: Revert.
1571         * frv-linux-tdep.c: Revert.
1572         * frame.c: Revert.
1573         * frame-unwind.c: Revert.
1574         * frame-base.c: Revert.
1575         * fork-child.c: Revert.
1576         * findvar.c: Revert.
1577         * findcmd.c: Revert.
1578         * filesystem.c: Revert.
1579         * filename-seen-cache.h: Revert.
1580         * filename-seen-cache.c: Revert.
1581         * fbsd-tdep.c: Revert.
1582         * fbsd-nat.h: Revert.
1583         * fbsd-nat.c: Revert.
1584         * f-valprint.c: Revert.
1585         * f-typeprint.c: Revert.
1586         * f-lang.c: Revert.
1587         * extension.h: Revert.
1588         * extension.c: Revert.
1589         * extension-priv.h: Revert.
1590         * expprint.c: Revert.
1591         * exec.h: Revert.
1592         * exec.c: Revert.
1593         * exceptions.c: Revert.
1594         * event-top.c: Revert.
1595         * event-loop.c: Revert.
1596         * eval.c: Revert.
1597         * elfread.c: Revert.
1598         * dwarf2read.h: Revert.
1599         * dwarf2read.c: Revert.
1600         * dwarf2loc.c: Revert.
1601         * dwarf2expr.h: Revert.
1602         * dwarf2expr.c: Revert.
1603         * dwarf2-frame.c: Revert.
1604         * dwarf2-frame-tailcall.c: Revert.
1605         * dwarf-index-write.h: Revert.
1606         * dwarf-index-write.c: Revert.
1607         * dwarf-index-common.c: Revert.
1608         * dwarf-index-cache.h: Revert.
1609         * dwarf-index-cache.c: Revert.
1610         * dummy-frame.c: Revert.
1611         * dtrace-probe.c: Revert.
1612         * disasm.h: Revert.
1613         * disasm.c: Revert.
1614         * disasm-selftests.c: Revert.
1615         * dictionary.c: Revert.
1616         * dicos-tdep.c: Revert.
1617         * demangle.c: Revert.
1618         * dcache.h: Revert.
1619         * dcache.c: Revert.
1620         * darwin-nat.h: Revert.
1621         * darwin-nat.c: Revert.
1622         * darwin-nat-info.c: Revert.
1623         * d-valprint.c: Revert.
1624         * d-namespace.c: Revert.
1625         * d-lang.c: Revert.
1626         * ctf.c: Revert.
1627         * csky-tdep.c: Revert.
1628         * csky-linux-tdep.c: Revert.
1629         * cris-tdep.c: Revert.
1630         * cris-linux-tdep.c: Revert.
1631         * cp-valprint.c: Revert.
1632         * cp-support.c: Revert.
1633         * cp-namespace.c: Revert.
1634         * cp-abi.c: Revert.
1635         * corelow.c: Revert.
1636         * corefile.c: Revert.
1637         * continuations.c: Revert.
1638         * completer.h: Revert.
1639         * completer.c: Revert.
1640         * complaints.c: Revert.
1641         * coffread.c: Revert.
1642         * coff-pe-read.c: Revert.
1643         * cli-out.h: Revert.
1644         * cli-out.c: Revert.
1645         * charset.c: Revert.
1646         * c-varobj.c: Revert.
1647         * c-valprint.c: Revert.
1648         * c-typeprint.c: Revert.
1649         * c-lang.c: Revert.
1650         * buildsym.c: Revert.
1651         * buildsym-legacy.c: Revert.
1652         * build-id.h: Revert.
1653         * build-id.c: Revert.
1654         * btrace.c: Revert.
1655         * bsd-uthread.c: Revert.
1656         * breakpoint.h: Revert.
1657         * breakpoint.c: Revert.
1658         * break-catch-throw.c: Revert.
1659         * break-catch-syscall.c: Revert.
1660         * break-catch-sig.c: Revert.
1661         * blockframe.c: Revert.
1662         * block.c: Revert.
1663         * bfin-tdep.c: Revert.
1664         * bfin-linux-tdep.c: Revert.
1665         * bfd-target.c: Revert.
1666         * bcache.c: Revert.
1667         * ax-general.c: Revert.
1668         * ax-gdb.h: Revert.
1669         * ax-gdb.c: Revert.
1670         * avr-tdep.c: Revert.
1671         * auxv.c: Revert.
1672         * auto-load.c: Revert.
1673         * arm-wince-tdep.c: Revert.
1674         * arm-tdep.c: Revert.
1675         * arm-symbian-tdep.c: Revert.
1676         * arm-pikeos-tdep.c: Revert.
1677         * arm-obsd-tdep.c: Revert.
1678         * arm-nbsd-tdep.c: Revert.
1679         * arm-nbsd-nat.c: Revert.
1680         * arm-linux-tdep.c: Revert.
1681         * arm-linux-nat.c: Revert.
1682         * arm-fbsd-tdep.c: Revert.
1683         * arm-fbsd-nat.c: Revert.
1684         * arm-bsd-tdep.c: Revert.
1685         * arch-utils.c: Revert.
1686         * arc-tdep.c: Revert.
1687         * arc-newlib-tdep.c: Revert.
1688         * annotate.h: Revert.
1689         * annotate.c: Revert.
1690         * amd64-windows-tdep.c: Revert.
1691         * amd64-windows-nat.c: Revert.
1692         * amd64-tdep.c: Revert.
1693         * amd64-sol2-tdep.c: Revert.
1694         * amd64-obsd-tdep.c: Revert.
1695         * amd64-obsd-nat.c: Revert.
1696         * amd64-nbsd-tdep.c: Revert.
1697         * amd64-nbsd-nat.c: Revert.
1698         * amd64-nat.c: Revert.
1699         * amd64-linux-tdep.c: Revert.
1700         * amd64-linux-nat.c: Revert.
1701         * amd64-fbsd-tdep.c: Revert.
1702         * amd64-fbsd-nat.c: Revert.
1703         * amd64-dicos-tdep.c: Revert.
1704         * amd64-darwin-tdep.c: Revert.
1705         * amd64-bsd-nat.c: Revert.
1706         * alpha-tdep.c: Revert.
1707         * alpha-obsd-tdep.c: Revert.
1708         * alpha-nbsd-tdep.c: Revert.
1709         * alpha-mdebug-tdep.c: Revert.
1710         * alpha-linux-tdep.c: Revert.
1711         * alpha-linux-nat.c: Revert.
1712         * alpha-bsd-tdep.c: Revert.
1713         * alpha-bsd-nat.c: Revert.
1714         * aix-thread.c: Revert.
1715         * agent.c: Revert.
1716         * addrmap.c: Revert.
1717         * ada-varobj.c: Revert.
1718         * ada-valprint.c: Revert.
1719         * ada-typeprint.c: Revert.
1720         * ada-tasks.c: Revert.
1721         * ada-lang.c: Revert.
1722         * aarch64-tdep.c: Revert.
1723         * aarch64-ravenscar-thread.c: Revert.
1724         * aarch64-newlib-tdep.c: Revert.
1725         * aarch64-linux-tdep.c: Revert.
1726         * aarch64-linux-nat.c: Revert.
1727         * aarch64-fbsd-tdep.c: Revert.
1728         * aarch64-fbsd-nat.c: Revert.
1729         * aarch32-linux-nat.c: Revert.
1730
1731 2019-04-05  Tom Tromey  <tom@tromey.com>
1732
1733         * ft32-tdep.c: Sort headers.
1734         * frv-tdep.c: Sort headers.
1735         * frv-linux-tdep.c: Sort headers.
1736         * frame.c: Sort headers.
1737         * frame-unwind.c: Sort headers.
1738         * frame-base.c: Sort headers.
1739         * fork-child.c: Sort headers.
1740         * findvar.c: Sort headers.
1741         * findcmd.c: Sort headers.
1742         * filesystem.c: Sort headers.
1743         * filename-seen-cache.h: Sort headers.
1744         * filename-seen-cache.c: Sort headers.
1745         * fbsd-tdep.c: Sort headers.
1746         * fbsd-nat.h: Sort headers.
1747         * fbsd-nat.c: Sort headers.
1748         * f-valprint.c: Sort headers.
1749         * f-typeprint.c: Sort headers.
1750         * f-lang.c: Sort headers.
1751         * extension.h: Sort headers.
1752         * extension.c: Sort headers.
1753         * extension-priv.h: Sort headers.
1754         * expprint.c: Sort headers.
1755         * exec.h: Sort headers.
1756         * exec.c: Sort headers.
1757         * exceptions.c: Sort headers.
1758         * event-top.c: Sort headers.
1759         * event-loop.c: Sort headers.
1760         * eval.c: Sort headers.
1761         * elfread.c: Sort headers.
1762         * dwarf2read.h: Sort headers.
1763         * dwarf2read.c: Sort headers.
1764         * dwarf2loc.c: Sort headers.
1765         * dwarf2expr.h: Sort headers.
1766         * dwarf2expr.c: Sort headers.
1767         * dwarf2-frame.c: Sort headers.
1768         * dwarf2-frame-tailcall.c: Sort headers.
1769         * dwarf-index-write.h: Sort headers.
1770         * dwarf-index-write.c: Sort headers.
1771         * dwarf-index-common.c: Sort headers.
1772         * dwarf-index-cache.h: Sort headers.
1773         * dwarf-index-cache.c: Sort headers.
1774         * dummy-frame.c: Sort headers.
1775         * dtrace-probe.c: Sort headers.
1776         * disasm.h: Sort headers.
1777         * disasm.c: Sort headers.
1778         * disasm-selftests.c: Sort headers.
1779         * dictionary.c: Sort headers.
1780         * dicos-tdep.c: Sort headers.
1781         * demangle.c: Sort headers.
1782         * dcache.h: Sort headers.
1783         * dcache.c: Sort headers.
1784         * darwin-nat.h: Sort headers.
1785         * darwin-nat.c: Sort headers.
1786         * darwin-nat-info.c: Sort headers.
1787         * d-valprint.c: Sort headers.
1788         * d-namespace.c: Sort headers.
1789         * d-lang.c: Sort headers.
1790         * ctf.c: Sort headers.
1791         * csky-tdep.c: Sort headers.
1792         * csky-linux-tdep.c: Sort headers.
1793         * cris-tdep.c: Sort headers.
1794         * cris-linux-tdep.c: Sort headers.
1795         * cp-valprint.c: Sort headers.
1796         * cp-support.c: Sort headers.
1797         * cp-namespace.c: Sort headers.
1798         * cp-abi.c: Sort headers.
1799         * corelow.c: Sort headers.
1800         * corefile.c: Sort headers.
1801         * continuations.c: Sort headers.
1802         * completer.h: Sort headers.
1803         * completer.c: Sort headers.
1804         * complaints.c: Sort headers.
1805         * coffread.c: Sort headers.
1806         * coff-pe-read.c: Sort headers.
1807         * cli-out.h: Sort headers.
1808         * cli-out.c: Sort headers.
1809         * charset.c: Sort headers.
1810         * c-varobj.c: Sort headers.
1811         * c-valprint.c: Sort headers.
1812         * c-typeprint.c: Sort headers.
1813         * c-lang.c: Sort headers.
1814         * buildsym.c: Sort headers.
1815         * buildsym-legacy.c: Sort headers.
1816         * build-id.h: Sort headers.
1817         * build-id.c: Sort headers.
1818         * btrace.c: Sort headers.
1819         * bsd-uthread.c: Sort headers.
1820         * breakpoint.h: Sort headers.
1821         * breakpoint.c: Sort headers.
1822         * break-catch-throw.c: Sort headers.
1823         * break-catch-syscall.c: Sort headers.
1824         * break-catch-sig.c: Sort headers.
1825         * blockframe.c: Sort headers.
1826         * block.c: Sort headers.
1827         * bfin-tdep.c: Sort headers.
1828         * bfin-linux-tdep.c: Sort headers.
1829         * bfd-target.c: Sort headers.
1830         * bcache.c: Sort headers.
1831         * ax-general.c: Sort headers.
1832         * ax-gdb.h: Sort headers.
1833         * ax-gdb.c: Sort headers.
1834         * avr-tdep.c: Sort headers.
1835         * auxv.c: Sort headers.
1836         * auto-load.c: Sort headers.
1837         * arm-wince-tdep.c: Sort headers.
1838         * arm-tdep.c: Sort headers.
1839         * arm-symbian-tdep.c: Sort headers.
1840         * arm-pikeos-tdep.c: Sort headers.
1841         * arm-obsd-tdep.c: Sort headers.
1842         * arm-nbsd-tdep.c: Sort headers.
1843         * arm-nbsd-nat.c: Sort headers.
1844         * arm-linux-tdep.c: Sort headers.
1845         * arm-linux-nat.c: Sort headers.
1846         * arm-fbsd-tdep.c: Sort headers.
1847         * arm-fbsd-nat.c: Sort headers.
1848         * arm-bsd-tdep.c: Sort headers.
1849         * arch-utils.c: Sort headers.
1850         * arc-tdep.c: Sort headers.
1851         * arc-newlib-tdep.c: Sort headers.
1852         * annotate.h: Sort headers.
1853         * annotate.c: Sort headers.
1854         * amd64-windows-tdep.c: Sort headers.
1855         * amd64-windows-nat.c: Sort headers.
1856         * amd64-tdep.c: Sort headers.
1857         * amd64-sol2-tdep.c: Sort headers.
1858         * amd64-obsd-tdep.c: Sort headers.
1859         * amd64-obsd-nat.c: Sort headers.
1860         * amd64-nbsd-tdep.c: Sort headers.
1861         * amd64-nbsd-nat.c: Sort headers.
1862         * amd64-nat.c: Sort headers.
1863         * amd64-linux-tdep.c: Sort headers.
1864         * amd64-linux-nat.c: Sort headers.
1865         * amd64-fbsd-tdep.c: Sort headers.
1866         * amd64-fbsd-nat.c: Sort headers.
1867         * amd64-dicos-tdep.c: Sort headers.
1868         * amd64-darwin-tdep.c: Sort headers.
1869         * amd64-bsd-nat.c: Sort headers.
1870         * alpha-tdep.c: Sort headers.
1871         * alpha-obsd-tdep.c: Sort headers.
1872         * alpha-nbsd-tdep.c: Sort headers.
1873         * alpha-mdebug-tdep.c: Sort headers.
1874         * alpha-linux-tdep.c: Sort headers.
1875         * alpha-linux-nat.c: Sort headers.
1876         * alpha-bsd-tdep.c: Sort headers.
1877         * alpha-bsd-nat.c: Sort headers.
1878         * aix-thread.c: Sort headers.
1879         * agent.c: Sort headers.
1880         * addrmap.c: Sort headers.
1881         * ada-varobj.c: Sort headers.
1882         * ada-valprint.c: Sort headers.
1883         * ada-typeprint.c: Sort headers.
1884         * ada-tasks.c: Sort headers.
1885         * ada-lang.c: Sort headers.
1886         * aarch64-tdep.c: Sort headers.
1887         * aarch64-ravenscar-thread.c: Sort headers.
1888         * aarch64-newlib-tdep.c: Sort headers.
1889         * aarch64-linux-tdep.c: Sort headers.
1890         * aarch64-linux-nat.c: Sort headers.
1891         * aarch64-fbsd-tdep.c: Sort headers.
1892         * aarch64-fbsd-nat.c: Sort headers.
1893         * aarch32-linux-nat.c: Sort headers.
1894
1895 2019-04-04  Tom Tromey  <tom@tromey.com>
1896
1897         * varobj.c (varobj_create): Update.
1898         * rust-exp.y (struct rust_parser) <update_innermost_block,
1899         lookup_symbol>: New methods.
1900         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1901         Rename.
1902         (rust_parser::rust_lookup_type)
1903         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1904         * printcmd.c (display_command, do_one_display): Update.
1905         * parser-defs.h (struct parser_state) <parser_state>: Add
1906         "tracker" parameter.
1907         (block_tracker): New member.
1908         (class innermost_block_tracker) <innermost_block_tracker>: Add
1909         "types" parameter.
1910         <reset>: Remove method.
1911         (innermost_block): Don't declare.
1912         (null_post_parser): Update.
1913         * parse.c (innermost_block): Remove global.
1914         (write_dollar_variable): Update.
1915         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1916         Remove "tracker_types" parameter.
1917         (parse_expression): Add "tracker" parameter.
1918         (parse_expression_for_completion): Update.
1919         (null_post_parser): Add "tracker" parameter.
1920         * p-exp.y: Update rules.
1921         * m2-exp.y: Update rules.
1922         * language.h (struct language_defn) <la_post_parser>: Add
1923         "tracker" parameter.
1924         * go-exp.y: Update rules.
1925         * f-exp.y: Update rules.
1926         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1927         parameter.
1928         * d-exp.y: Update rules.
1929         * c-exp.y: Update rules.
1930         * breakpoint.c (set_breakpoint_condition): Create an
1931         innermost_block_tracker.
1932         (watch_command_1): Likewise.
1933         * ada-lang.c (resolve): Add "tracker" parameter.
1934         (resolve_subexp): Likewise.
1935         * ada-exp.y (write_var_from_sym): Update.
1936
1937 2019-04-04  Tom Tromey  <tom@tromey.com>
1938
1939         * type-stack.h: New file.
1940         * type-stack.c: New file.
1941         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1942         type-stack.h.
1943         (insert_into_type_stack, insert_type, push_type, push_type_int)
1944         (insert_type_address_space, pop_type, pop_type_int)
1945         (pop_typelist, pop_type_stack, append_type_stack)
1946         (push_type_stack, get_type_stack, push_typelist)
1947         (follow_type_instance_flags, follow_types): Don't declare.
1948         * parse.c (type_stack): Remove global.
1949         (parse_exp_in_context): Update.
1950         (insert_into_type_stack, insert_type, push_type, push_type_int)
1951         (insert_type_address_space, pop_type, pop_type_int)
1952         (pop_typelist, pop_type_stack, append_type_stack)
1953         (push_type_stack, get_type_stack, push_typelist)
1954         (follow_type_instance_flags, follow_types): Remove (moved to
1955         type-stack.c).
1956         * f-exp.y (type_stack): New global.
1957         Update rules.
1958         (push_kind_type, f_parse): Update.
1959         * d-exp.y (type_stack): New global.
1960         Update rules.
1961         (d_parse): Update.
1962         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1963         Update rules.
1964         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1965         (HFILES_NO_SRCDIR): Add type-stack.h.
1966
1967 2019-04-04  Tom Tromey  <tom@tromey.com>
1968
1969         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1970         (rust_parser::convert_ast_to_expression, rust_parse)
1971         (rust_lex_test_completion, rust_lex_tests): Update.
1972         * parser-defs.h (struct expr_completion_state): New.
1973         (struct parser_state) <parser_state>: Add completion parameter.
1974         <mark_struct_expression, mark_completion_tag>: New methods.
1975         <parse_completion, m_completion_state>: New members.
1976         (prefixify_expression, null_post_parser): Update.
1977         (mark_struct_expression, mark_completion_tag): Don't declare.
1978         * parse.c (parse_completion, expout_last_struct)
1979         (expout_tag_completion_type, expout_completion_name): Remove
1980         globals.
1981         (parser_state::mark_struct_expression)
1982         (parser_state::mark_completion_tag): Now methods.
1983         (prefixify_expression): Add last_struct parameter.
1984         (prefixify_subexp): Likewise.
1985         (parse_exp_1): Update.
1986         (parse_exp_in_context): Add cstate parameter.  Update.
1987         (parse_expression_for_completion): Create an
1988         expr_completion_state.
1989         (null_post_parser): Add "completion" parameter.
1990         * p-exp.y: Update rules.
1991         (yylex): Update.
1992         * language.h (struct language_defn) <la_post_parser>: Add
1993         "completing" parameter.
1994         * go-exp.y: Update rules.
1995         (lex_one_token): Update.
1996         * expression.h (parse_completion): Don't declare.
1997         * d-exp.y: Update rules.
1998         (lex_one_token): Update rules.
1999         * c-exp.y: Update rules.
2000         (lex_one_token): Update.
2001         * ada-lang.c (resolve): Add "parse_completion" parameter.
2002         (resolve_subexp): Likewise.
2003         (ada_resolve_function): Likewise.
2004
2005 2019-04-04  Tom Tromey  <tom@tromey.com>
2006
2007         * parser-defs.h (struct parser_state) <start_arglist,
2008         end_arglist>: New methods.
2009         <arglist_len, m_funcall_chain>: New members.
2010         (arglist_len, start_arglist, end_arglist): Don't declare.
2011         * parse.c (arglist_len, funcall_chain): Remove global.
2012         (start_arglist, end_arglist): Remove functions.
2013         (parse_exp_in_context): Update.
2014         * p-exp.y: Update rules.
2015         * m2-exp.y: Update rules.
2016         * go-exp.y: Update rules.
2017         * f-exp.y: Update rules.
2018         * d-exp.y: Update rules.
2019         * c-exp.y: Update rules.
2020
2021 2019-04-04  Tom Tromey  <tom@tromey.com>
2022
2023         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2024         lex_operator, push_back>: New methods.
2025         Update all rules.
2026         (rust_parser::lex_hex, lex_escape): Rename and update.
2027         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2028         (rust_parser::lex_operator): Rename and update.
2029         (rust_parser::lex_number, rustyylex, rustyyerror)
2030         (rust_lex_test_init, rust_lex_test_sequence)
2031         (rust_lex_test_push_back, rust_lex_tests): Update.
2032         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2033         parameter.
2034         <lexptr, prev_lexptr>: New members.
2035         (lexptr, prev_lexptr): Don't declare.
2036         * parse.c (lexptr, prev_lexptr): Remove globals.
2037         (parse_exp_in_context): Update.
2038         * p-exp.y (yylex, yyerror): Update.
2039         * m2-exp.y (parse_number, yylex, yyerror): Update.
2040         * go-exp.y (lex_one_token, yyerror): Update.
2041         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2042         * d-exp.y (lex_one_token, yyerror): Update.
2043         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2044         (lex_one_token, yyerror): Update.
2045         * ada-lex.l (YY_INPUT): Update.
2046         (rewind_to_char): Update.
2047         * ada-exp.y (yyerror): Update.
2048
2049 2019-04-04  Tom Tromey  <tom@tromey.com>
2050
2051         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2052         * parser-defs.h (struct parser_state) <parser_state>: Add new
2053         parameter.
2054         <comma_terminates>: New member.
2055         (comma_terminates): Don't declare global.
2056         * parse.c (comma_terminates): Remove global.
2057         (parse_exp_in_context): Update.
2058         * p-exp.y (yylex): Update.
2059         * m2-exp.y (yylex): Update.
2060         * go-exp.y (lex_one_token): Update.
2061         * f-exp.y (yylex): Update.
2062         * d-exp.y (lex_one_token): Update.
2063         * c-exp.y (lex_one_token): Update.
2064         * ada-lex.l: Update.
2065
2066 2019-04-04  Tom Tromey  <tom@tromey.com>
2067
2068         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2069         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2070         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2071         * parser-defs.h (paren_depth): Don't declare.
2072         * parse.c (paren_depth): Remove global.
2073         (parse_exp_in_context): Update.
2074         * p-exp.y (paren_depth): New global.
2075         (pascal_parse): Initialize it.
2076         * m2-exp.y (paren_depth): New global.
2077         (m2_parse): Initialize it.
2078         * go-exp.y (paren_depth): New global.
2079         (go_parse): Initialize it.
2080         * f-exp.y (paren_depth): New global.
2081         (f_parse): Initialize it.
2082         * d-exp.y (paren_depth): New global.
2083         (d_parse): Initialize it.
2084         * c-exp.y (paren_depth): New global.
2085         (c_parse): Initialize it.
2086         * ada-lex.l (paren_depth): New global.
2087         (lexer_init): Initialize it.
2088
2089 2019-04-04  Tom Tromey  <tom@tromey.com>
2090
2091         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2092         (rust_parser::convert_ast_to_type)
2093         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2094         * parser-defs.h (struct parser_state) <parser_state>: Add
2095         parameters.  Initialize new members.
2096         <expression_context_block, expression_context_pc>: New members.
2097         * parse.c (expression_context_block, expression_context_pc):
2098         Remove globals.
2099         (parse_exp_in_context): Update.
2100         * p-exp.y: Update all rules.
2101         (yylex): Update.
2102         * m2-exp.y: Update all rules.
2103         (yylex): Update.
2104         * go-exp.y (yylex): Update.
2105         * f-exp.y (yylex): Update.
2106         * d-exp.y: Update all rules.
2107         (yylex): Update.
2108         * c-exp.y: Update all rules.
2109         (lex_one_token, classify_name, yylex, c_parse): Update.
2110         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2111
2112 2019-04-04  Tom Tromey  <tom@tromey.com>
2113
2114         * gdbarch.h, gdbarch.c: Rebuild.
2115         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2116         * stap-probe.h:
2117         (struct stap_parse_info): Replace "parser_state" with
2118         "expr_builder".
2119         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2120         (parser_state): New class.
2121         * parse.c (expr_builder): Rename.
2122         (expr_builder::release): Rename.
2123         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2124         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2125         (write_exp_elt_longcst, write_exp_elt_floatcst)
2126         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2127         (write_exp_string_vector, write_exp_bitstring)
2128         (write_exp_msymbol, mark_struct_expression)
2129         (write_dollar_variable)
2130         (insert_type_address_space, increase_expout_size): Replace
2131         "parser_state" with "expr_builder".
2132         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2133         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2134         "parser_state" with "expr_builder".
2135
2136 2019-04-04  Tom Tromey  <tom@tromey.com>
2137
2138         * rust-exp.y: Replace "parse_language" with method call.
2139         * p-exp.y:
2140         (yylex): Replace "parse_language" with method call.
2141         * m2-exp.y:
2142         (yylex): Replace "parse_language" with method call.
2143         * go-exp.y (classify_name): Replace "parse_language" with method
2144         call.
2145         * f-exp.y (yylex): Replace "parse_language" with method call.
2146         * d-exp.y (lex_one_token): Replace "parse_language" with method
2147         call.
2148         * c-exp.y:
2149         (lex_one_token, classify_name, yylex): Replace "parse_language"
2150         with method call.
2151         * ada-exp.y (find_primitive_type, type_char)
2152         (type_system_address): Replace "parse_language" with method call.
2153
2154 2019-04-04  Tom Tromey  <tom@tromey.com>
2155
2156         * rust-exp.y: Replace "parse_gdbarch" with method call.
2157         * parse.c (write_dollar_variable, insert_type_address_space):
2158         Replace "parse_gdbarch" with method call.
2159         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2160         call.
2161         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2162         call.
2163         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2164         "parse_gdbarch" with method call.
2165         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2166         with method call.
2167         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2168         "parse_gdbarch" with method call.
2169         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2170         "parse_gdbarch" with method call.
2171         * c-exp.y (parse_type, parse_number, classify_name): Replace
2172         "parse_gdbarch" with method call.
2173         * ada-lex.l: Replace "parse_gdbarch" with method call.
2174         * ada-exp.y (parse_type, find_primitive_type, type_char)
2175         (type_system_address): Replace "parse_gdbarch" with method call.
2176
2177 2019-04-04  Tom Tromey  <tom@tromey.com>
2178
2179         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2180         * stap-probe.c (stap_parse_argument): Update.
2181         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2182         initial_size parameter.
2183         * rust-exp.y (rust_lex_tests): Update.
2184         * parse.c (parser_state): Update.
2185         (parse_exp_in_context): Update.
2186         * parser-defs.h (struct parser_state) <parser_state>: Remove
2187         "initial_size" parameter.
2188
2189 2019-04-04  Tom Tromey  <tom@tromey.com>
2190
2191         * parser-defs.h (increase_expout_size): Don't declare.
2192         * parse.c (increase_expout_size): Now static.
2193
2194 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2195
2196         * gnu-nat.c (gnu_nat_target::wait): Fix
2197         target_waitstatus_to_string call.
2198
2199 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * eval.c (evaluate_subexp_standard): Handle internal functions
2202         during Fortran function call handling.
2203
2204 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * NEWS: Mention new internal functions.
2207         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2208         (read_base_type): Use dwarf2_init_complex_target_type.
2209         * value.c (creal_internal_fn): New function.
2210         (cimag_internal_fn): New function.
2211         (_initialize_values): Register new internal functions.
2212
2213 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2214
2215         * infrun.c (stop_all_threads): If debug_infrun, always
2216         trace the wait status after wait_one, using
2217         target_waitstatus_to_string and target_pid_to_str.
2218         (handle_inferior_event): Replace various trace of
2219         wait status kind by a single trace.
2220         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2221         wait status kind image by target_waitstatus_to_string.
2222         * target/waitstatus.c (target_waitstatus_to_string): Fix
2223         obsolete comment.
2224
2225 2019-04-01  Tom Tromey  <tromey@adacore.com>
2226
2227         PR symtab/23331:
2228         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2229
2230 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2231             Pedro Alves  <palves@redhat.com>
2232
2233         * top.c (quit_force): Call 'finalize_values'.
2234         * value.c (finalize_values): New function.
2235         * value.h (finalize_values): Declare.
2236
2237 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2238
2239         * NEWS: Announce $_gdb_major and $_gdb_minor.
2240
2241         * top.c (init_gdb_version_vars): New function.
2242         (gdb_init): Call init_gdb_version_vars.
2243
2244 2019-03-29  Tom Tromey  <tromey@adacore.com>
2245
2246         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2247         help text.  Remove dead code.
2248
2249 2019-03-29  Keith Seitz  <keiths@redhat.com>
2250
2251         From Siddhesh Poyarekar:
2252         * f-lang.h (f77_get_upperbound): Return LONGEST.
2253         (f77_get_lowerbound): Likewise.
2254         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2255         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2256         print them.
2257         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2258         plongest to format print it.
2259         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2260         (f77_get_upperbound): Likewise.
2261         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2262         LOWER_BOUND to LONGEST.
2263         (f77_create_arrayprint_offset_tbl): Likewise.
2264
2265 2019-03-29  Keith Seitz  <keiths@redhat.com>
2266
2267         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2268         %s/pulongest for TYPE_LENGTH instead of %d in format
2269         strings.
2270         * ada-typerint.c (ada_print_type): Likewise.
2271         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2272         * compile/compile-c-support.c (generate_register_struct): Likewise.
2273         * gdbtypes.c (recursive_dump_type): Likewise.
2274         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2275         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2276         instead of %d in format strings.
2277         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2278         to std::min to ULONGEST.
2279         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2280         instead of %d in format strings.
2281         * tracepoint.c (info_scope_command): Likewise.
2282         * typeprint.c (print_offset_data::update)
2283         (print_offset_data::finish): Likewise.
2284         * xtensa-tdep.c (xtensa_store_return_value)
2285         (xtensa_push_dummy_call): Likewise.
2286
2287 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2288
2289         * windows-nat.c (display_selector): Fixed format specifications
2290         for 64-bit Cygwin.
2291
2292 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2293
2294         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2295
2296 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2297
2298         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2299         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2300         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2301         (nios2_linux_init_abi): Install it.
2302
2303 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2304
2305         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2306
2307 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2308
2309         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2310
2311 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2312             Tom Tromey  <tromey@adacore.com>
2313
2314         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2315
2316 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2317
2318         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2319         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2320         method to compute the bounds of range types. Also print "[evaluated]"
2321         if the bounds' values come from a dynamic evaluation.
2322
2323 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2326         whitespace when pretty printing is on.
2327
2328 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2329
2330         * ppc-linux-nat.c: Add include.
2331
2332 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2333
2334         * NEWS: Mention AArch64 Pointer Authentication.
2335
2336 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2337
2338         * arm-linux-nat.c: Add include.
2339
2340 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2341
2342         * source-cache.c (source_cache::get_source_lines): Re-read
2343         fullname after calling open_source_file.
2344
2345 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2346
2347         * NEWS: Mention TLS support for FreeBSD.
2348
2349 2019-03-25  Tom Tromey  <tromey@adacore.com>
2350
2351         * minsyms.c (BUNCH_SIZE): Update comment.
2352         (~minimal_symbol_reader): Remove old comment.
2353         (compact_minimal_symbols): Update comment.
2354         (minimal_symbol_reader::install): Remove old comment.  Update
2355         other comments.
2356
2357 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2358
2359         * s390-linux-nat.c: Add include.
2360
2361 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2362
2363         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2364         Call linux_get_hwcap.
2365         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2366         Likewise.
2367         (aarch64_linux_get_hwcap): Remove function.
2368         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2369         declaration.
2370         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2371         linux_get_hwcap.
2372         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2373         * linux-tdep.c (linux_get_hwcap): Add function.
2374         (linux_get_hwcap2): Likewise.
2375         * linux-tdep.h (linux_get_hwcap): Add declaration.
2376         (linux_get_hwcap2): Likewise.
2377         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2378         (ppc_linux_get_hwcap2): Likewise.
2379         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2380         linux_get_hwcap.
2381         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2382         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2383         (ppc_linux_nat_target::read_description): Likewise.
2384         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2385         * s390-linux-nat.c: Likewise.
2386         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2387
2388 2019-03-24  Tom Tromey  <tom@tromey.com>
2389
2390         * ada-lang.c (standard_lookup): Simplify initialization.
2391         (ada_lookup_symbol_nonlocal): Simplify return.
2392         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2393         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2394         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2395         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2396         initialization.
2397         * solib.c (solib_global_lookup): Simplify.
2398         * symtab.c (null_block_symbol): Remove.
2399         (symbol_cache_lookup): Simplify returns.
2400         (lookup_language_this): Simplify returns.
2401         (lookup_symbol_aux): Simplify return.
2402         (lookup_local_symbol): Simplify returns.
2403         (lookup_global_symbol_from_objfile): Simplify return.
2404         (lookup_symbol_in_objfile_symtabs)
2405         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2406         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2407         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2408         * cp-namespace.c (cp_lookup_bare_symbol)
2409         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2410         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2411         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2412         (cp_lookup_symbol_via_imports): Simplify initialization.
2413         (find_symbol_in_baseclass): Likewise.
2414         * symtab.h (null_block_symbol): Remove.
2415         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2416         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2417         (d_lookup_symbol_module): Likewise.
2418         (find_symbol_in_baseclass): Simplify initialization.
2419
2420 2019-03-24  Tom Tromey  <tom@tromey.com>
2421
2422         * expression.h: Don't include symtab.h.
2423         (struct block): Forward declare.
2424
2425 2019-03-24  Tom Tromey  <tom@tromey.com>
2426
2427         * c-exp.y (typebase): Remove casts.
2428         * gdbtypes.c (lookup_unsigned_typename, )
2429         (lookup_signed_typename): Remove cast.
2430         * eval.c (parse_to_comma_and_eval): Remove cast.
2431         * parse.c (write_dollar_variable): Remove cast.
2432         * block.h (struct block) <superblock>: Now const.
2433         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2434         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2435         (map_block): Make "block" const.
2436         * symfile.h (struct quick_symbol_functions)
2437         <map_matching_symbols>: Constify block argument to "callback".
2438         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2439         const.
2440         (find_pc_sect_compunit_symtab): Make "b" const.
2441         (find_symbol_at_address): Likewise.
2442         (search_symbols): Likewise.
2443         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2444         (dw2_debug_names_lookup_symbol): Likewise.
2445         (dw2_map_matching_symbols): Update.
2446         * p-valprint.c (pascal_val_print): Remove "block".
2447         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2448         (aux_add_nonlocal_symbols): Make "block" const.
2449         (resolve_subexp): Remove cast.
2450         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2451         const.
2452         (iterate_over_file_blocks): Likewise.
2453         * f-exp.y (%union) <bval>: Remove.
2454         * coffread.c (patch_opaque_types): Make "b" const.
2455         * spu-tdep.c (spu_catch_start): Make "block" const.
2456         * c-valprint.c (print_unpacked_pointer): Remove "block".
2457         * symmisc.c (dump_symtab_1): Make "b" const.
2458         (block_depth): Make "block" const.
2459         * d-exp.y (%union) <bval>: Remove.
2460         * cp-support.h (cp_lookup_rtti_type): Update.
2461         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2462         * psymtab.c (psym_lookup_symbol): Make "block" const.
2463         (maintenance_check_psymtabs): Make "b" const.
2464         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2465         (enumerate_locals, enumerate_args): Update.
2466         * python/py-symtab.c (stpy_global_block): Make "block" const.
2467         (stpy_static_block): Likewise.
2468         * inline-frame.c (block_starting_point_at): Make "new_block"
2469         const.
2470         * block.c (find_block_in_blockvector): Make return type const.
2471         (blockvector_for_pc_sect): Make "b" const.
2472         (find_block_in_blockvector): Make "b" const.
2473
2474 2019-03-23  Tom Tromey  <tom@tromey.com>
2475
2476         * varobj.c (varobj_create): Update.
2477         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2478         * printcmd.c (display_command, do_one_display): Don't reset
2479         innermost_block.
2480         * parser-defs.h (enum innermost_block_tracker_type): Move to
2481         expression.h.
2482         (innermost_block): Update comment.
2483         * parse.c (parse_exp_1): Add tracker_types parameter.
2484         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2485         tracker_types parameter.  Reset innermost_block.
2486         (parse_exp_in_context): Remove.
2487         (parse_expression_for_completion): Update.
2488         * objfiles.c (~objfile): Don't reset expression_context_block or
2489         innermost_block.
2490         * expression.h (enum innermost_block_tracker_type): Move from
2491         parser-defs.h.
2492         (parse_exp_1): Add tracker_types parameter.
2493         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2494         reset innermost_block.
2495
2496 2019-03-23  Tom Tromey  <tom@tromey.com>
2497
2498         * objfiles.h: Include bcache.h.
2499
2500 2019-03-23  Tom Tromey  <tom@tromey.com>
2501
2502         * linespec.c (get_current_search_block): Use
2503         scoped_restore_current_language.
2504         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2505
2506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2507             Jiong Wang  <jiong.wang@arm.com>
2508
2509         * aarch64-linux-tdep.c
2510         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2511         section.
2512         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2513
2514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2515             Jiong Wang  <jiong.wang@arm.com>
2516
2517         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2518         instructions.
2519         (aarch64_analyze_prologue_test): Add PACIASP test.
2520         (aarch64_prologue_prev_register): Unmask PC value.
2521
2522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2523             Jiong Wang  <jiong.wang@arm.com>
2524
2525         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2526         (aarch64_dwarf2_prev_register): Unmask PC value.
2527         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2528         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2529         DW_CFA_AARCH64_negate_ra_state.
2530         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2531
2532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2533             Jiong Wang  <jiong.wang@arm.com>
2534
2535         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2536         registers.
2537         (aarch64_pseudo_register_name): Likewise.
2538         (aarch64_pseudo_register_type): Likewise.
2539         (aarch64_pseudo_register_reggroup_p): Likewise.
2540         (aarch64_gdbarch_init): Add pauth registers.
2541         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2542         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2543         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2544         (struct gdbarch_tdep): Add regnum for ra_state.
2545
2546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2547             Jiong Wang  <jiong.wang@arm.com>
2548
2549         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2550
2551 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2552             Jiong Wang  <jiong.wang@arm.com>
2553
2554         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2555         function.
2556         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2557         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2558         (aarch64_gdbarch_init): Add puth registers.
2559         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2560         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2561         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2562
2563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2564             Jiong Wang  <jiong.wang@arm.com>
2565
2566         * aarch64-linux-nat.c
2567         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2568         * aarch64-linux-tdep.c
2569         (aarch64_linux_core_read_description): Likewise.
2570         (aarch64_linux_get_hwcap): New function.
2571         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2572         (aarch64_linux_get_hwcap): New declaration.
2573
2574 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2575             Jiong Wang  <jiong.wang@arm.com>
2576
2577         * aarch64-linux-nat.c
2578         (aarch64_linux_nat_target::read_description): Add pauth param.
2579         * aarch64-linux-tdep.c
2580         (aarch64_linux_core_read_description): Likewise.
2581         * aarch64-tdep.c (struct target_desc): Add in pauth.
2582         (aarch64_read_description): Add pauth param.
2583         (aarch64_gdbarch_init): Likewise.
2584         * aarch64-tdep.h (aarch64_read_description): Likewise.
2585         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2586         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2587         * features/Makefile: Add new files.
2588         * features/aarch64-pauth.c: New file.
2589         * features/aarch64-pauth.xml: New file.
2590
2591 2019-03-20  Tom Tromey  <tromey@adacore.com>
2592
2593         * infrun.c (handle_inferior_event): Rename from
2594         handle_inferior_event_1.  Create a scoped_value_mark.
2595         (handle_inferior_event): Remove.
2596
2597 2019-03-19  Tom Tromey  <tromey@adacore.com>
2598
2599         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2600         * infrun.h (print_stop_event): Add "displays" parameter.
2601         * infrun.c (print_stop_event): Add "displays" parameter.
2602
2603 2019-03-19  Pedro Alves  <palves@redhat.com>
2604
2605         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2606         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2607         to -1.  Fix TABs vs spaces.
2608         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2609         * tui/tui-out.h (tui_ui_out) Add intro comments.
2610         <m_line, m_start_of_line>: In-class initialize, and add describing
2611         comment.
2612
2613 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2614
2615         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2616         variable names.
2617         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2618
2619 2019-03-18  Pedro Alves  <palves@redhat.com>
2620             Eli Zaretskii <eliz@gnu.org>
2621
2622         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2623         m_line and m_start_of_line.
2624
2625 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2626
2627         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2628         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2629         it returns a newline.  This fixes a regression in TU mode, whereby
2630         the next line is output on the same screen line as the user input.
2631
2632 2019-03-18  Tom Tromey  <tromey@adacore.com>
2633
2634         * minsyms.c (minimal_symbol_reader::install): Remove call to
2635         obstack_blank.
2636
2637 2019-03-18  Pedro Alves  <palves@redhat.com>
2638
2639         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2640         New globals.
2641         (apply_style): New, factored out from ...
2642         (apply_ansi_escape): ... this.  Handle reverse video mode.
2643         (tui_set_reverse_mode): New function.
2644         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2645         * tui/tui-winsource.c (tui_show_source_line): Use
2646         tui_set_reverse_mode instead of setting A_STANDOUT.
2647         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2648         New setter methods.
2649
2650 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2651
2652         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2653         Handle tabs.
2654
2655 2019-03-18  Tom Tromey  <tromey@adacore.com>
2656
2657         * ada-lang.c (empty_array): Add "high" parameter.
2658         (ada_evaluate_subexp): Update.
2659
2660 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2661
2662         * unittests/string_view-selftests.c: Define
2663         _initialize_string_view_selftests unconditionally.
2664
2665 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2666
2667         PR gdb/24350
2668         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2669
2670 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2671
2672         PR gdb/24351
2673         * windows-nat.c (display_selector): Fix format specifiers.
2674
2675 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2676
2677         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2678         tui_refill_source_window instead of tui_refresh_win, to update the
2679         current execution line.  This fixes redisplay of the current line
2680         when stepping through the code with "next" or "step".
2681
2682 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2683
2684         * source-cache.c (source_cache::get_source_lines): Call
2685         find_source_lines to initialize s->nlines.  This fixes vertical
2686         scrolling of TUI source window when the DOWN arrow is pressed.
2687
2688 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2689
2690         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2691         linux-thread-db.c (_initialize_thread_db): Likewise.
2692
2693 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2694
2695         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2696         wclrtoeol in tui_show_source_line".  This reverts changes made in
2697         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2698
2699 2019-03-15  Tom Tromey  <tom@tromey.com>
2700
2701         * symtab.h (struct minimal_symbol): Derive from
2702         general_symbol_info.
2703         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2704         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2705         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2706         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2707         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2708         (MSYMBOL_SEARCH_NAME): Update.
2709         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2710         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2711         * minsyms.c (minimal_symbol_reader::record_full): Update.
2712
2713 2019-03-15  Tom Tromey  <tom@tromey.com>
2714
2715         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2716
2717 2019-03-15  Tom Tromey  <tom@tromey.com>
2718
2719         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2720         unique_xmalloc_ptr.
2721         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2722         Update.
2723         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2724         (build_minimal_symbol_hash_tables)
2725         (minimal_symbol_reader::install): Update.
2726
2727 2019-03-15  Tom Tromey  <tom@tromey.com>
2728
2729         * symtab.c (create_demangled_names_hash): Update.
2730         (symbol_set_names): Update.
2731         * objfiles.h (struct objfile_per_bfd_storage)
2732         <demangled_names_hash>: Now an htab_up.
2733         * objfiles.c (objfile_per_bfd_storage): Simplify.
2734
2735 2019-03-15  Tom Tromey  <tom@tromey.com>
2736
2737         * objfiles.h (struct objfile_per_bfd_storage): Declare
2738         destructor.
2739         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2740         New.
2741         (get_objfile_bfd_data): Use new.  Don't initialize
2742         language_of_main.
2743         (free_objfile_per_bfd_storage): Remove.
2744         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2745
2746 2019-03-15  Tom Tromey  <tom@tromey.com>
2747
2748         * symfile.c (reread_symbols): Update.
2749         * objfiles.c (objfile::objfile): Update.
2750         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2751         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2752         comment.
2753         (minimal_symbol_reader::install): Update.
2754         (terminate_minimal_symbol_table): Remove.
2755         * jit.c (jit_object_close_impl): Update.
2756
2757 2019-03-15  Tom Tromey  <tom@tromey.com>
2758
2759         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2760         initializations.
2761
2762 2019-03-15  Tom Tromey  <tom@tromey.com>
2763
2764         * objfiles.h (struct objfile_per_bfd_storage)
2765         <demangled_hash_languages>: Now a bitset.
2766         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2767         (lookup_minimal_symbol): Update.
2768
2769 2019-03-15  Tom Tromey  <tom@tromey.com>
2770
2771         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2772         Don't return the symbol.
2773         * coffread.c (record_minimal_symbol): Use record_full.
2774
2775 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2776
2777         The MS-Windows port of ncurses fails to switch to a color pair if
2778         one or both of the colors are the implicit default colors.  This
2779         change records the default colors when TUI is initialized, and
2780         then specifies them explicitly when a color pair uses the default
2781         colors.  This allows color styling in TUI mode on MS-Windows.
2782
2783         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2784         ncurses_norm_attr.
2785         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2786         colors in ncurses_norm_attr.
2787         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2788         "none", replace it with the default color recorded in
2789         ncurses_norm_attr.
2790
2791 2019-03-14  Tom Tromey  <tromey@adacore.com>
2792
2793         * source-cache.h (class source_cache) <get_source_lines>: Return
2794         std::string.
2795         * source-cache.c (source_cache::extract_lines): Handle case where
2796         first_pos==npos.  Return std::string.
2797         (source_cache::get_source_lines): Update.
2798
2799 2019-03-14  Tom Tromey  <tromey@adacore.com>
2800
2801         * NEWS: Add item for "style sources" commands.
2802         * source-cache.c (source_cache::get_source_lines): Check
2803         source_styling.
2804         * cli/cli-style.c (source_styling): New global.
2805         (_initialize_cli_style): Add "style sources" commands.
2806         (show_style_sources): New function.
2807         * cli/cli-style.h (source_styling): Declare.
2808
2809 2019-03-14  Pedro Alves  <palves@redhat.com>
2810             Tom Tromey  <tromey@adacore.com>
2811
2812         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2813         * tui/tui-winsource.c (tui_refill_source_window): New function,
2814         from...
2815         (tui_horizontal_source_scroll): ... here.  Move some logic.
2816         * cli/cli-style.c (set_style_enabled): Notify new observable.
2817         * tui/tui-hooks.c (tui_redisplay_source): New function.
2818         (tui_attach_detach_observers): Attach or detach
2819         tui_redisplay_source.
2820         * observable.h (source_styling_changed): New observable.
2821         * observable.c: Define source_styling_changed observable.
2822
2823 2019-03-13  Tom Tromey  <tromey@adacore.com>
2824
2825         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2826         (i386_gnu_nat_target::store_registers): Update.
2827         * target-debug.h (target_debug_print_std_string): New macro.
2828         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2829         * windows-tdep.c (display_one_tib): Update.
2830         * tui/tui-stack.c (tui_make_status_line): Update.
2831         * top.c (print_inferior_quit_action): Update.
2832         * thread.c (thr_try_catch_cmd): Update.
2833         (add_thread_with_info): Update.
2834         (thread_target_id_str): Update.
2835         (thr_try_catch_cmd): Update.
2836         (thread_command): Update.
2837         (thread_find_command): Update.
2838         * record-btrace.c (record_btrace_target::info_record)
2839         (record_btrace_resume_thread, record_btrace_target::resume)
2840         (record_btrace_cancel_resume, record_btrace_step_thread)
2841         (record_btrace_target::wait, record_btrace_target::wait)
2842         (record_btrace_target::wait, record_btrace_target::stop): Update.
2843         * progspace.c (print_program_space): Update.
2844         * process-stratum-target.c
2845         (process_stratum_target::thread_address_space): Update.
2846         * linux-fork.c (linux_fork_mourn_inferior)
2847         (detach_checkpoint_command, info_checkpoints_command)
2848         (linux_fork_context): Update.
2849         (linux_fork_detach): Update.
2850         (class scoped_switch_fork_info): Update.
2851         (delete_checkpoint_command): Update.
2852         * infrun.c (follow_fork_inferior): Update.
2853         (follow_fork_inferior): Update.
2854         (proceed_after_vfork_done): Update.
2855         (handle_vfork_child_exec_or_exit): Update.
2856         (follow_exec): Update.
2857         (displaced_step_prepare_throw): Update.
2858         (displaced_step_restore): Update.
2859         (start_step_over): Update.
2860         (resume_1): Update.
2861         (clear_proceed_status_thread): Update.
2862         (proceed): Update.
2863         (print_target_wait_results): Update.
2864         (do_target_wait): Update.
2865         (context_switch): Update.
2866         (stop_all_threads): Update.
2867         (restart_threads): Update.
2868         (finish_step_over): Update.
2869         (handle_signal_stop): Update.
2870         (switch_back_to_stepped_thread): Update.
2871         (keep_going_pass_signal): Update.
2872         (print_exited_reason): Update.
2873         (normal_stop): Update.
2874         * inferior.c (inferior_pid_to_str): Change return type.
2875         (print_selected_inferior): Update.
2876         (add_inferior): Update.
2877         (detach_inferior): Update.
2878         * dummy-frame.c (fprint_dummy_frames): Update.
2879         * dcache.c (dcache_info_1): Update.
2880         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2881         (btrace_fetch, btrace_clear): Update.
2882         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2883         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2884         type.
2885         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2886         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2887         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2888         * gdbarch.c, gdbarch.h: Rebuild.
2889         * gdbarch.sh (core_pid_to_str): Change return type.
2890         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2891         return type.
2892         (windows_nat_target::pid_to_str): Change return type.
2893         (windows_delete_thread): Update.
2894         (windows_nat_target::attach): Update.
2895         (windows_nat_target::files_info): Update.
2896         * target-delegates.c: Rebuild.
2897         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2898         return type.
2899         (sol_thread_target::pid_to_str): Change return type.
2900         * remote.c (class remote_target) <pid_to_str>: Change return
2901         type.
2902         (remote_target::pid_to_str): Change return type.
2903         (extended_remote_target::attach, remote_target::remote_stop_ns)
2904         (remote_target::remote_notif_remove_queued_reply)
2905         (remote_target::push_stop_reply, remote_target::disable_btrace):
2906         Update.
2907         (extended_remote_target::attach): Update.
2908         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2909         type.
2910         (gdbsim_target::pid_to_str): Change return type.
2911         * ravenscar-thread.c (struct ravenscar_thread_target)
2912         <pid_to_str>: Change return type.
2913         (ravenscar_thread_target::pid_to_str): Change return type.
2914         * procfs.c (class procfs_target) <pid_to_str>: Change return
2915         type.
2916         (procfs_target::pid_to_str): Change return type.
2917         (procfs_target::attach): Update.
2918         (procfs_target::detach): Update.
2919         (procfs_target::fetch_registers): Update.
2920         (procfs_target::store_registers): Update.
2921         (procfs_target::wait): Update.
2922         (procfs_target::files_info): Update.
2923         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2924         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2925         return type.
2926         (nto_procfs_target::pid_to_str): Change return type.
2927         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2928         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2929         return type.
2930         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2931         (exit_lwp): Update.
2932         (attach_proc_task_lwp_callback, get_detach_signal)
2933         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2934         (linux_nat_target::resume, wait_lwp, stop_callback)
2935         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2936         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2937         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2938         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2939         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2940         type.
2941         (inf_ptrace_target::attach): Update.
2942         (inf_ptrace_target::files_info): Update.
2943         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2944         type.
2945         (go32_nat_target::pid_to_str): Change return type.
2946         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2947         (gnu_nat_target::wait): Update.
2948         (gnu_nat_target::wait): Update.
2949         (gnu_nat_target::resume): Update.
2950         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2951         (fbsd_nat_target::wait): Update.
2952         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2953         type.
2954         (darwin_nat_target::attach): Update.
2955         * corelow.c (class core_target) <pid_to_str>: Change return type.
2956         (core_target::pid_to_str): Change return type.
2957         * target.c (normal_pid_to_str): Change return type.
2958         (default_pid_to_str): Likewise.
2959         (target_pid_to_str): Change return type.
2960         (target_translate_tls_address): Update.
2961         (target_announce_detach): Update.
2962         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2963         return type.
2964         (bsd_uthread_target::pid_to_str): Change return type.
2965         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2966         type.
2967         (bsd_kvm_target::pid_to_str): Change return type.
2968         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2969         return type.
2970         (aix_thread_target::pid_to_str): Change return type.
2971         * target.h (struct target_ops) <pid_to_str>: Change return type.
2972         (target_pid_to_str, normal_pid_to_str): Likewise.
2973         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2974         type.
2975         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2976         type.
2977         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2978         return type.
2979         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2980         type.
2981         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2982         type.
2983         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2984         return type.
2985
2986 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2987
2988         * NEWS: Mention that the new default MI version is 3.  Mention
2989         changes to the output of commands and events that deal with
2990         multi-location breakpoints.
2991         * breakpoint.c: Include "mi/mi-out.h".
2992         (print_one_breakpoint): Change output syntax if using MI version
2993         >= 3.
2994         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2995         New.
2996         (mi_multi_location_breakpoint_output_fixed): New.
2997         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2998         (mi_cmd_fix_multi_location_breakpoint_output): New.
2999         (mi_multi_location_breakpoint_output_fixed): New.
3000         * mi/mi-cmds.c (mi_cmds): Register command
3001         -fix-multi-location-breakpoint-output.
3002         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3003         interpreter "mi".
3004
3005 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3006
3007         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3008         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3009         instantiate mi_ui_out based on interpreter name.
3010         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3011         * mi/mi-main.c (mi_load_progress): Likewise.
3012
3013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3014
3015         * NEWS: Combine separate "New targets" sections for 8.3.
3016
3017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3018
3019         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3020         (ppcfbsd_init_abi): Install gdbarch
3021         "fetch_tls_load_module_address" and "get_thread_local_address"
3022         methods.
3023
3024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3025
3026         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3027         (riscv_fbsd_init_abi): Install gdbarch
3028         "fetch_tls_load_module_address" and "get_thread_local_address"
3029         methods.
3030
3031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3032
3033         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3034         (i386fbsd_init_abi): Install gdbarch
3035         "fetch_tls_load_module_address" and "get_thread_local_address"
3036         methods.
3037
3038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3039
3040         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3041         (amd64fbsd_init_abi): Install gdbarch
3042         "fetch_tls_load_module_address" and "get_thread_local_address"
3043         methods.
3044
3045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3046
3047         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3048         (struct fbsd_pspace_data): New type.
3049         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3050         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3051         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3052         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3053         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3054
3055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3056
3057         * gdbtypes.c (lookup_struct_elt): New function.
3058         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3059         * gdbtypes.h (struct struct_elt): New type.
3060         (lookup_struct_elt): New prototype.
3061
3062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3063
3064         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3065         remove disabled code block.
3066
3067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3068
3069         * gdbarch.sh (get_thread_local_address): New method.
3070         * gdbarch.h, gdbarch.c: Regenerate.
3071         * target.c (target_translate_tls_address): Use
3072         gdbarch_get_thread_local_address if present instead of
3073         target::get_thread_local_address.
3074
3075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3076
3077         * target.h (target::get_thread_local_address): Update comment.
3078
3079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3080
3081         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3082         objfile->separate_debug_objfile_backlink if not NULL.
3083
3084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3087         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3088         (amd64bsd_store_inferior_registers): Likewise.
3089         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3090         Enable segment base registers.
3091         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3092         PT_GETFSBASE and PT_GETGSBASE.
3093         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3094         PT_SETGSBASE.
3095         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3096         segment base registers.
3097         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3098
3099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3100
3101         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3102         Update calls to i386_target_description to add 'segments'
3103         parameter.
3104         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3105         add segment base registers.
3106         * arch/i386.c (i386_create_target_description): Add 'segments'
3107         parameter to enable segment base registers.
3108         * arch/i386.h (i386_create_target_description): Likewise.
3109         * features/i386/32bit-segments.xml: New file.
3110         * features/i386/32bit-segments.c: Generate.
3111         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3112         call to i386_target_description to add 'segments' parameter.
3113         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3114         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3115         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3116         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3117         if feature is present.
3118         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3119         Add 'segments' parameter to call to i386_target_description.
3120         (i386_target_description): Add 'segments' parameter to enable
3121         segment base registers.
3122         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3123         to call to i386_target_description.
3124         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3125         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3126         Define I386_NUM_REGS.
3127         (i386_target_description): Add 'segments' parameter to enable
3128         segment base registers.
3129
3130 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3131
3132         PR/24325
3133         * source-cache.c: #undef open and close, to avoid unresolved
3134         externals during linking.
3135
3136 2019-03-12  Tom Tromey  <tromey@adacore.com>
3137
3138         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3139         const.  Add initializers.
3140         (_initialize_remote): Don't initialize ptid globals.
3141
3142 2019-03-12  Pedro Alves  <palves@redhat.com>
3143
3144         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3145
3146 2019-03-12  Pedro Alves  <palves@redhat.com>
3147
3148         * cp-name-parser.y (main): Remove unused 'len' variable.
3149
3150 2019-03-12  Tom Tromey  <tromey@adacore.com>
3151
3152         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3153         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3154
3155 2019-03-12  Tom Tromey  <tromey@adacore.com>
3156
3157         * linux-nat.c (iterate_over_lwps): Update.
3158         (stop_callback): Remove parameter.
3159         (stop_wait_callback, detach_callback, resume_set_callback)
3160         (select_singlestep_lwp_callback, set_ignore_sigint)
3161         (status_callback, resumed_callback, resume_clear_callback)
3162         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3163         data parameter.
3164         (linux_nat_target::detach, linux_nat_target::resume)
3165         (linux_stop_and_wait_all_lwps, select_event_lwp)
3166         (linux_nat_filter_event, linux_nat_wait_1)
3167         (linux_nat_target::kill, linux_nat_target::stop)
3168         (linux_nat_target::stop): Update.
3169         (linux_nat_resume_callback): Change type.
3170         (resume_stopped_resumed_lwps, count_events_callback)
3171         (select_event_lwp_callback): Likewise.
3172         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3173         * arm-linux-nat.c (struct update_registers_data): Remove.
3174         (update_registers_callback): Change type.
3175         (arm_linux_insert_hw_breakpoint1): Update.
3176         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3177         parameter.
3178         (x86_linux_dr_set_addr): Update.
3179         (x86_linux_dr_set_control): Update.
3180         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3181         (iterate_over_lwps): Use gdb::function_view.
3182         * nat/aarch64-linux-hw-point.c (struct
3183         aarch64_dr_update_callback_param): Remove.
3184         (debug_reg_change_callback): Change type.
3185         (aarch64_notify_debug_reg_change): Update.
3186         * s390-linux-nat.c (s390_refresh_per_info): Update.
3187
3188 2019-03-11  Tom Tromey  <tromey@adacore.com>
3189
3190         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3191         redundant assignment to "this_cu".
3192
3193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3194
3195         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3196
3197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3198
3199         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3200         from...
3201         (rank_one_type): ... this.
3202
3203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3204
3205         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3206         from...
3207         (rank_one_type): ... this.
3208
3209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3210
3211         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3212         from...
3213         (rank_one_type): ... this.
3214
3215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3216
3217         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3218         from...
3219         (rank_one_type): ... this.
3220
3221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3222
3223         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3224         from...
3225         (rank_one_type): ... this.
3226
3227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3228
3229         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3230         from...
3231         (rank_one_type): ... this.
3232
3233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3234
3235         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3236         from...
3237         (rank_one_type): ... this.
3238
3239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3240
3241         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3242         from...
3243         (rank_one_type): ... this.
3244
3245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3246
3247         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3248         from...
3249         (rank_one_type): ... this.
3250
3251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3252
3253         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3254         from...
3255         (rank_one_type): ... this.
3256
3257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3258
3259         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3260         from...
3261         (rank_one_type): ... this.
3262
3263 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3264
3265         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3266         from...
3267         (rank_one_type): ... this.
3268
3269 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3270
3271         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3272         inferior-events' shows the example events.
3273
3274 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3275
3276         Support styling on native MS-Windows console
3277
3278         PR/24315
3279         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3280         on MS-Windows if $TERM is not defined.
3281
3282         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3283
3284         * posix-hdep.c (gdb_console_fputs):
3285         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3286         functions.
3287         * ui-file.h (gdb_console_fputs): Add prototype.
3288
3289         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3290         back to fputs only if the former returns zero.
3291
3292 2019-03-07  Tom Tromey  <tom@tromey.com>
3293
3294         * symmisc.c (print_symbol_bcache_statistics): Update.
3295         (print_objfile_statistics): Update.
3296         * symfile.c (allocate_symtab): Update.
3297         * stabsread.c: Don't include bcache.h.
3298         * psymtab.h (struct psymbol_bcache): Don't declare.
3299         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3300         (psymbol_bcache_init, psymbol_bcache_free)
3301         (psymbol_bcache_get_bcache): Don't declare.
3302         * psymtab.c (struct psymbol_bcache): Remove.
3303         (psymtab_storage::psymtab_storage): Update.
3304         (psymtab_storage::~psymtab_storage): Update.
3305         (psymbol_bcache_init, psymbol_bcache_free)
3306         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3307         (add_psymbol_to_bcache): Update.
3308         (allocate_psymtab): Update.
3309         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3310         macro_cache>: No longer pointers.
3311         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3312         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3313         * macrotab.c (macro_bcache): Update.
3314         * macroexp.c: Don't include bcache.h.
3315         * gdbtypes.c (check_types_worklist): Update.
3316         (types_deeply_equal): Remove TRY/CATCH.  Update.
3317         * elfread.c (elf_symtab_read): Update.
3318         * dwarf2read.c: Don't include bcache.h.
3319         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3320         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3321         (print_bcache_statistics, bcache_memory_used): Don't declare.
3322         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3323         methods.  Rename all data members.
3324         * bcache.c (struct bcache): Move to bcache.h.
3325         (bcache::expand_hash_table): Rename from expand_hash_table.
3326         (bcache): Remove.
3327         (bcache::insert): Rename from bcache_full.
3328         (bcache::compare): Rename from bcache_compare.
3329         (bcache_xmalloc): Remove.
3330         (bcache::~bcache): Rename from bcache_xfree.
3331         (bcache::print_statistics): Rename from print_bcache_statistics.
3332         (bcache::memory_used): Rename from bcache_memory_used.
3333
3334 2019-03-07  Pedro Alves  <palves@redhat.com>
3335
3336         * infrun.c (normal_stop): Also check for
3337         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3338
3339 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * f-lang.c (value_from_host_double): Moved to...
3342         * value.c (value_from_host_double): ...here.
3343         * value.h (value_from_host_double): Declare.
3344         * guile/scm-math.c (vlscm_convert_typed_number): Use
3345         value_from_host_double.
3346         (vlscm_convert_number): Likewise.
3347         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3348         * python/py-value.c (convert_value_from_python): Likewise.
3349
3350 2019-03-06  Tom Tromey  <tom@tromey.com>
3351
3352         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3353
3354 2019-03-06  Tom Tromey  <tom@tromey.com>
3355
3356         * utils.h (free_current_contents): Don't declare.
3357         * utils.c (free_current_contents): Remove.
3358
3359 2019-03-06  Tom Tromey  <tom@tromey.com>
3360
3361         * top.c (quit_force): Update.
3362         * main.c (captured_command_loop): Update.
3363         * common/new-op.c (operator new): Update.
3364         * common/common-exceptions.c (struct catcher)
3365         <save_cleanup_chain>: Remove member.
3366         (exceptions_state_mc_init): Update.
3367         (exception_try_scope_entry): Return nullptr.
3368         (exception_try_scope_exit, exception_rethrow)
3369         (throw_exception_sjlj, throw_exception_cxx): Update.
3370         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3371         (all_cleanups, do_cleanups, discard_cleanups)
3372         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3373         (restore_cleanups, restore_final_cleanups): Don't declare.
3374         (do_final_cleanups): Remove parameter.
3375         * common/cleanups.c (cleanup_chain, make_cleanup)
3376         (make_cleanup_dtor, all_cleanups, do_cleanups)
3377         (discard_my_cleanups, discard_cleanups)
3378         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3379         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3380         (null_cleanup): Remove.
3381         (do_final_cleanups): Remove parameter.
3382
3383 2019-03-06  Tom Tromey  <tom@tromey.com>
3384
3385         * remote.c (remote_target::remote_parse_stop_reply): Use
3386         unique_xmalloc_ptr.
3387
3388 2019-03-06  Tom Tromey  <tom@tromey.com>
3389
3390         * stabsread.c (struct stabs_field_info): Rename from field_info.
3391         <list, fnlist>: Add initializers.
3392         <obstack>: New member.
3393         (read_member_functions, read_struct_fields, read_baseclasses):
3394         Allocate on obstack.  Don't use cleanups.
3395         (read_one_struct_field, read_member_functions, read_struct_fields)
3396         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3397         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3398         (read_struct_type): Update.
3399
3400 2019-03-06  Tom Tromey  <tom@tromey.com>
3401
3402         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3403         * common/filestuff.h (make_cleanup_close): Don't declare.
3404         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3405         Remove.
3406
3407 2019-03-06  Tom Tromey  <tom@tromey.com>
3408
3409         * solib-aix.c: Use make_scope_exit.
3410
3411 2019-03-06  Tom Tromey  <tom@tromey.com>
3412
3413         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3414         Use make_scope_exit.
3415
3416 2019-03-06  Tom Tromey  <tom@tromey.com>
3417
3418         * solib-svr4.c (disable_probes_interface): Remove parameter.
3419         (svr4_handle_solib_event): Use make_scope_exit.
3420
3421 2019-03-06  Tom Tromey  <tom@tromey.com>
3422
3423         * remote.c (struct stop_reply_deleter): Remove.
3424         (stop_reply_up): Update.
3425         (struct stop_reply): Derive from notif_event.  Don't typedef.
3426         <regcache>: Now a std::vector.
3427         (stop_reply_xfree): Remove.
3428         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3429         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3430         (remote_target::discard_pending_stop_replies): Use delete.
3431         (remote_target::remote_parse_stop_reply): Update.
3432         (remote_target::process_stop_reply): Update.
3433         * remote-notif.h (struct notif_event): Add virtual destructor.
3434         Remove "dtr" member.
3435         (struct notif_client) <alloc_event>: Return a unique_ptr.
3436         (notif_event_xfree): Don't declare.
3437         (notif_event_up): New typedef.
3438         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3439         (notif_event_xfree, do_notif_event_xfree): Remove.
3440         (remote_notif_state_xfree): Update.
3441
3442 2019-03-06  Tom Tromey  <tom@tromey.com>
3443
3444         * infrun.c (displaced_step_clear_cleanup): Now a
3445         forward_scope_exit type.
3446         (displaced_step_prepare_throw): Update.
3447         (displaced_step_fixup): Update.
3448
3449 2019-03-06  Tom Tromey  <tom@tromey.com>
3450
3451         * inferior.h (class inferior): Update comment.
3452         * gdbthread.h (class thread_info): Update comment.
3453
3454 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3455             Tom Tromey  <tom@tromey.com>
3456
3457         * stabsread.h (struct stab_section_list): Remove.
3458         (coffstab_build_psymtabs): Update.
3459         * dbxread.c (symbuf_sections): Now a std::vector.
3460         (sect_idx): New global.
3461         (fill_symbuf): Update.
3462         (coffstab_build_psymtabs): Change type of stabsects parameter.
3463         Update.
3464         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3465         std::vector.
3466         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3467         (coff_locate_sections): Update.
3468         (coff_symfile_read): Remove cleanups.  Update.
3469         (init_stringtab): Add storage parameter.
3470         (free_stringtab, free_stringtab_cleanup): Remove.
3471         (init_lineno): Add storage parameter.
3472         (free_linetab, free_linetab_cleanup): Remove.
3473
3474 2019-03-06  Pedro Alves  <palves@redhat.com>
3475
3476         * linux-fork.c (fork_info::clobber_regs): Delete.
3477         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3478         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3479         comment.  Adjust.
3480         (scoped_switch_fork_info::scoped_switch_fork_info)
3481         (checkpoint_command, linux_fork_context): Adjust
3482         fork_save_infrun_state calls.
3483
3484 2019-03-06  Pedro Alves  <palves@redhat.com>
3485
3486         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3487         (inf_has_multiple_threads): Return 'bool' and rewrite using
3488         inferior_info::threads().
3489
3490 2019-03-06  Pedro Alves  <palves@redhat.com>
3491
3492         * linux-fork.c: Include <list>.
3493         (fork_list): Now a std::list instance.
3494         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3495         (forks_exist_p, find_last_fork): Adjust.
3496         (new_fork): Delete.
3497         (one_fork_p): New.
3498         (add_fork): Adjust.
3499         (free_fork): Delete, folded into fork_info::~fork_info().
3500         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3501         Adjust.
3502         (init_fork_list): Delete.
3503         (linux_fork_killall, linux_fork_mourn_inferior)
3504         (linux_fork_detach, info_checkpoints_command): Adjust.
3505         (_initialize_linux_fork): No longer call init_fork_list.
3506
3507 2019-03-06  Pedro Alves  <palves@redhat.com>
3508
3509         * linux-fork.c (new_fork): New, split out of ...
3510         (add_fork): ... this.  Return void.  Move "first fork" special
3511         case from here, to ...
3512         (checkpoint_command): ... here.
3513         * linux-linux.h (add_fork): Return void.
3514
3515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3518
3519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3520             Chris January  <chris.january@arm.com>
3521             David Lecomber  <david.lecomber@arm.com>
3522
3523         * f-exp.y: New token, UNOP_INTRINSIC.
3524         (exp): New pattern using UNOP_INTRINSIC token.
3525         (f77_keywords): Add 'abs' keyword.
3526         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3527         (value_from_host_double): New function.
3528         (evaluate_subexp_f): Support UNOP_ABS.
3529
3530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3533         types.
3534
3535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3538         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3539         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3540
3541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3544
3545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3546             Chris January  <chris.january@arm.com>
3547
3548         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3549         * f-exp.y: Define 'KIND' token.
3550         (exp): New pattern for KIND expressions.
3551         (ptype): Handle types with a kind extension.
3552         (direct_abs_decl): Extend to spot kind extensions.
3553         (f77_keywords): Add 'kind' to the list.
3554         (push_kind_type): New function.
3555         (convert_to_kind_type): New function.
3556         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3557         * parse.c (operator_length_standard): Likewise.
3558         * parser-defs.h (enum type_pieces): Add tp_kind.
3559         * std-operator.def: Add UNOP_KIND.
3560
3561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * f-exp.y (f_parse): Set yydebug.
3564
3565 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * f-lang.c (evaluate_subexp_f): New function.
3568         (exp_descriptor_f): New global.
3569         (f_language_defn): Use exp_descriptor_f instead of
3570         exp_descriptor_standard.
3571
3572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * f-exp.y (struct token): Add comments.
3575         (dot_ops): Remove uppercase versions and the end marker.
3576         (f77_keywords): Likewise.
3577         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3578         entries in the dot_ops array are case insensitive, and use
3579         strncasecmp to compare strings.  Also some whitespace cleanup in
3580         this area.  Similar for the f77_keywords array, except entries in
3581         this list might be case sensitive.
3582
3583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * f-exp.y (struct f77_boolean_val): Add comments.
3586         (boolean_values): Remove uppercase versions, and end marker.
3587         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3588         and use strncasecmp to achieve case insensitivity.  Additionally,
3589         perform whitespace cleanup around this code.
3590
3591 2019-03-06  Tom Tromey  <tromey@adacore.com>
3592
3593         * remote-sim.c (gdbsim_target_open): Use result of
3594         gdb_argv::release.
3595
3596 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3597         Dirk Schubert  <dirk.schubert@arm.com>
3598         Chris January  <chris.january@arm.com>
3599
3600         * eval.c (evaluate_subexp_standard): Call Fortran argument
3601         wrapping logic.
3602         * f-lang.c (struct value): A value which can be passed into a
3603         Fortran function call.
3604         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3605         where appropriate.
3606         (struct type): Value ready for a Fortran function call.
3607         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3608         is needed.
3609         * f-lang.h (fortran_argument_convert): Declaration.
3610         (fortran_preserve_arg_pointer): Declaration.
3611         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3612
3613 2019-03-05  Tom Tromey  <tromey@adacore.com>
3614
3615         * python/py-prettyprint.c (print_string_repr): Remove #if.
3616         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3617
3618 2019-03-05  Tom Tromey  <tromey@adacore.com>
3619
3620         * target.c (the_dummy_target): Move later.  Change type to
3621         "dummy_target".
3622         (initialize_targets): Don't initialize the_dummy_target.
3623
3624 2019-03-05  Tom Tromey  <tromey@adacore.com>
3625
3626         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3627         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3628
3629 2019-03-05  Tom Tromey  <tromey@adacore.com>
3630
3631         * windows-nat.c (windows_nat_target::attach)
3632         (windows_nat_target::detach): Don't call gdb_flush.
3633         * valprint.c (generic_val_print, val_print, val_print_string):
3634         Don't call gdb_flush.
3635         * utils.c (defaulted_query): Don't call gdb_flush.
3636         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3637         * target.c (target_announce_detach): Don't call gdb_flush.
3638         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3639         * remote.c (extended_remote_target::attach): Don't call
3640         gdb_flush.
3641         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3642         * printcmd.c (do_examine): Don't call gdb_flush.
3643         (info_display_command): Don't call gdb_flush.
3644         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3645         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3646         * memattr.c (info_mem_command): Don't call gdb_flush.
3647         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3648         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3649         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3650         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3651         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3652         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3653         (gnu_nat_target::detach): Don't call gdb_flush.
3654         * f-valprint.c (f_val_print): Don't call gdb_flush.
3655         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3656         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3657         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3658         gdb_flush.
3659         * c-valprint.c (c_val_print): Don't call gdb_flush.
3660         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3661
3662 2019-03-05  Tom Tromey  <tromey@adacore.com>
3663
3664         * varobj.c (update_dynamic_varobj_children): Update.
3665         (install_default_visualizer): Use reset, not release.
3666         * value.c (set_internalvar): Update.
3667         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3668         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3669         ATTRIBUTE_UNUSED_RESULT.
3670
3671 2019-03-05  Tom Tromey  <tromey@adacore.com>
3672
3673         * remote.c (class scoped_remote_fd) <release>: Add
3674         ATTRIBUTE_UNUSED_RESULT.
3675
3676 2019-03-05  Tom Tromey  <tromey@adacore.com>
3677
3678         * macroexp.c (struct macro_buffer) <release>: Add
3679         ATTRIBUTE_UNUSED_RESULT.
3680
3681 2019-03-05  Tom Tromey  <tromey@adacore.com>
3682
3683         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3684         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3685         ATTRIBUTE_UNUSED_RESULT.
3686
3687 2019-03-05  Tom Tromey  <tromey@adacore.com>
3688
3689         * common/scoped_fd.h (class scoped_fd) <release>: Add
3690         ATTRIBUTE_UNUSED_RESULT.
3691
3692 2019-03-05  Tom Tromey  <tromey@adacore.com>
3693
3694         * parser-defs.h (struct parser_state) <release>: Add
3695         ATTRIBUTE_UNUSED_RESULT.
3696
3697 2019-03-05  Tom Tromey  <tromey@adacore.com>
3698
3699         * utils.h (class gdb_argv) <release>: Add
3700         ATTRIBUTE_UNUSED_RESULT.
3701         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3702
3703 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3704
3705         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3706         for-loop range, to avoid compiler warnings.
3707
3708         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3709         avoid compiler warnings about unused variables.
3710
3711         * NEWS: Mention end of support for native debugging on MS-Windows
3712         before XP.
3713
3714         PR gdb/24292
3715         * common/netstuff.c:
3716         * gdbserver/gdbreplay.c
3717         * gdbserver/remote-utils.c:
3718         * ser-tcp.c:
3719         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3720         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3721         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3722         'getaddrinfo' and 'freeaddrinfo' were not available before
3723         Windows XP, and mingw.org's MinGW headers by default define
3724         _WIN32_WINNT to 0x500.
3725
3726 2019-03-01  Gary Benson <gbenson@redhat.com>
3727
3728         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3729
3730 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3731             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3732
3733         PR gdb/8527
3734         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3735         set_sigint_trap, clear_sigint_trap.
3736
3737 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3738
3739         * target.c (target_detach): Clear the regcache and the
3740         frame cache.
3741
3742 2019-02-27  Pedro Alves  <palves@redhat.com>
3743
3744         * utils.c (set_screen_size): When we cap the height/width sizes,
3745         tweak the corresponding command variable to show "unlimited":
3746
3747 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3748             Pedro Alves  <palves@redhat.com>
3749
3750         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3751         before calling rl_set_screen_size.
3752
3753 2019-02-27  Tom Tromey  <tromey@adacore.com>
3754
3755         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3756         define.
3757         * python/py-value.c: Remove Python 2.4 workaround.
3758         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3759         workaround.
3760         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3761         Python 2.4 workaround.
3762         * python/python-internal.h: Remove Python 2.4 comment.
3763         (Py_ssize_t): Don't define.
3764         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3765         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3766         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3767         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3768         * python/python.c (do_start_initialization): Remove Python 2.4
3769         workaround.
3770         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3771         (print_children): Remove Python 2.4 workaround.
3772         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3773         workaround.
3774         (CHARBUFFERPROC_NAME): Remove.
3775         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3776         Python 2.4 workaround.
3777
3778 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3779
3780         * NEWS: Note minimum Python version.
3781
3782 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3783
3784         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3785         code from these functions.  Remove corresponding ifdefs.  Use
3786         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3787         Remove gotos and target of gotos.
3788         (infpy_search_memory): Likewise.
3789
3790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3793         (hppa_gdbarch_init): Don't register deleted functions with
3794         gdbarch.
3795
3796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3799         (h8300_unwind_sp): Delete.
3800         (h8300_dummy_id): Delete.
3801         (h8300_gdbarch_init): Don't register deleted functions with
3802         gdbarch.
3803
3804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3807         (ft32_unwind_pc): Delete.
3808         (ft32_unwind_sp): Delete.
3809         (ft32_gdbarch_init): Don't register deleted functions with
3810         gdbarch.
3811
3812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3815         (frv_unwind_pc): Delete.
3816         (frv_unwind_sp): Delete.
3817         (frv_gdbarch_init): Don't register deleted functions with
3818         gdbarch.
3819
3820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3821
3822         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3823         (riscv_unwind_pc): Delete.
3824         (riscv_unwind_sp): Delete.
3825         (riscv_gdbarch_init): Don't register deleted functions with
3826         gdbarch.
3827
3828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3829
3830         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3831         (csky_unwind_pc): Delete.
3832         (csky_unwind_sp): Delete.
3833         (csky_gdbarch_init): Don't register deleted functions with
3834         gdbarch.
3835
3836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3839         (cris_unwind_pc): Delete.
3840         (cris_unwind_sp): Delete.
3841         (cris_gdbarch_init): Don't register deleted functions with
3842         gdbarch.
3843
3844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3847         (bfin_unwind_pc): Delete.
3848         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3849
3850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3853         (arm_unwind_pc): Delete.
3854         (arm_unwind_sp): Delete.
3855         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3856
3857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3860         (arc_unwind_pc): Delete.
3861         (arc_unwind_sp): Delete.
3862         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3863
3864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3867         (alpha_unwind_pc): Delete.
3868         (alpha_gdbarch_init): Don't register deleted functions with
3869         gdbarch.
3870
3871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3874         (aarch64_unwind_pc): Delete.
3875         (aarch64_unwind_sp): Delete.
3876         (aarch64_gdbarch_init): Don't register deleted functions with
3877         gdbarch.
3878
3879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * gdbtypes.c (type_align): Don't consider static members when
3882         computing structure alignment.
3883
3884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3887         return 0 for other types.
3888         * arch-utils.c (default_type_align): Always return 0.
3889         * gdbarch.h: Regenerate.
3890         * gdbarch.sh (type_align): Extend comment.
3891         * gdbtypes.c (type_align): Add additional comments, always call
3892         gdbarch_type_align before applying the default rules.
3893         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3894         generic code will then apply a suitable default.
3895         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3896         types, return 0 for other types.
3897
3898 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3899
3900         * NEWS: Create a new section for the next release branch.
3901         Rename the section of the current branch, now that it has
3902         been cut.
3903
3904 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3905
3906         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3907         * version.in: Bump version to 8.3.50.DATE-git.
3908
3909 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3910
3911         * aix-thread.c (ptid_cmp): Remove unused variable.
3912         (get_signaled_thread): Likewise.
3913         (store_regs_user_thread): Likewise.
3914         (store_regs_kernel_thread): Likewise.
3915         (fetch_regs_kernel_thread): Remove shadowed variable.
3916
3917 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * features/riscv/32bit-cpu.xml: Add register numbers.
3920         * features/riscv/32bit-fpu.c: Regenerate.
3921         * features/riscv/32bit-fpu.xml: Add register numbers.
3922         * features/riscv/64bit-cpu.xml: Add register numbers.
3923         * features/riscv/64bit-fpu.c: Regenerate.
3924         * features/riscv/64bit-fpu.xml: Add register numbers.
3925
3926 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3927
3928         * NEWS: Mention two argument form of gdb.Value constructor.
3929         * python/py-value.c (convert_buffer_and_type_to_value): New
3930         function.
3931         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3932         Add support for handling an optional second argument.  Call
3933         convert_buffer_and_type_to_value as appropriate.
3934         * python/python-internal.h (Py_buffer_deleter): New struct.
3935         (Py_buffer_up): New typedef.
3936
3937 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3938
3939         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3940         instead of releasing ownership.
3941
3942 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3943
3944         * dwarf2read.c (open_and_init_dwp_file): Call
3945         elf_numsections instead of bfd_count_sections to initialize
3946         dwp_file->num_sections.
3947
3948 2019-02-25  Tom Tromey  <tromey@adacore.com>
3949
3950         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3951
3952 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3953
3954         * gcore.in: Add '--readnever' option when invoking GDB.
3955
3956 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * MAINTAINERS: Update my email address.
3959
3960 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3961
3962         * build-id.c (build_id_to_debug_bfd_1): New function.
3963         (build_id_to_debug_bfd): Look for separate debug file in
3964         sysroot.
3965
3966 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3967
3968         * gdbarch.sh: Update the copyright year range that is placed into
3969         generated files.
3970
3971 2019-02-22  Keith Seitz  <keiths@redhat.com>
3972
3973         PR symtab/23853
3974         * linespec.c (create_sals_line_offset): Search for the default
3975         symtab's filename instead of its fullname.
3976
3977 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3978
3979         * NEWS: Update style defaults.
3980
3981 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3982
3983         * main.c (captured_main_1): Disable styling in batch mode.
3984
3985 2019-02-20  Tom Tromey  <tom@tromey.com>
3986
3987         * symtab.c (symtab_symbol_info): Fix typos.
3988
3989 2019-02-20  Tom Tromey  <tromey@adacore.com>
3990
3991         * findcmd.c (_initialize_mem_search): Use upper case for
3992         metasyntactic variables.
3993
3994 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3997         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3998
3999 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4000
4001         * top.h (source_file_name): Change to std::string.
4002         * top.c (source_file_name): Likewise.
4003         (command_line_input): Adjust.
4004         * cli/cli-script.c (script_from_file): Adjust.
4005
4006 2019-02-19  Tom Tromey  <tromey@adacore.com>
4007
4008         * ravenscar-thread.c
4009         (ravenscar_thread_target::update_thread_list): Don't call
4010         ada_build_task_list.
4011         * ada-lang.h (ada_build_task_list): Don't declare.
4012         * ada-tasks.c (struct ada_tasks_inferior_data)
4013         <task_list_valid_p>: Now bool.
4014         (read_known_tasks, ada_task_list_changed)
4015         (ada_tasks_invalidate_inferior_data): Update.
4016         (read_known_tasks_array): Return bool.
4017         (read_known_tasks_list): Likewise.
4018         (read_known_tasks): Return void.
4019         (ada_build_task_list): Now static.
4020
4021 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4024         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4025
4026 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4027
4028         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4029         variant for ada_tasks_pspace_data_handle and
4030         ada_tasks_inferior_data_handle.
4031         (ada_tasks_pspace_data_cleanup): New function.
4032         (ada_tasks_inferior_data_cleanup): New function.
4033
4034 2019-02-17  Tom Tromey  <tom@tromey.com>
4035
4036         * macrotab.h (macro_source_fullname): Return a std::string.
4037         * macrotab.c (macro_include, check_for_redefinition)
4038         (macro_undef, macro_lookup_definition, foreach_macro)
4039         (foreach_macro_in_scope): Update.
4040         (macro_source_fullname): Return a std::string.
4041         * macrocmd.c (show_pp_source_pos): Update.
4042
4043 2019-02-17  Tom Tromey  <tom@tromey.com>
4044
4045         * macrocmd.c (show_pp_source_pos): Style the file names.
4046
4047 2019-02-17  Tom Tromey  <tom@tromey.com>
4048
4049         PR tui/24197:
4050         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4051
4052 2019-02-17  Tom Tromey  <tom@tromey.com>
4053
4054         * ada-lang.c (user_select_syms): Use filtered printing.
4055         * utils.c (wrap_style): New global.
4056         (desired_style): Remove.
4057         (emit_style_escape): Add stream parameter.
4058         (set_output_style, reset_terminal_style, prompt_for_continue):
4059         Update.
4060         (flush_wrap_buffer): Only flush gdb_stdout.
4061         (wrap_here): Set wrap_style.
4062         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4063         treat escape sequences as a character.  Change when wrap buffer is
4064         flushed.
4065         (fputs_styled): Do not set the output style when the default is
4066         requested.
4067         * ui-style.h (struct ui_file_style) <is_default>: New method.
4068         * source.c (print_source_lines_base): Emit escape sequences in one
4069         piece.
4070
4071 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4072
4073         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4074         integers and enumeration types.
4075
4076 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4077
4078         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4079         instead of lookup_symbol_in_language
4080         (do_exact_match): New function.
4081         (ada_get_symbol_name_matcher): Return do_exact_match when
4082         doing a verbatim match.
4083
4084 2019-02-15  Tom Tromey  <tromey@adacore.com>
4085
4086         * ravenscar-thread.c (ravenscar_thread_target::resume)
4087         (ravenscar_thread_target::wait): Special case wildcard requests.
4088
4089 2019-02-15  Tom Tromey  <tromey@adacore.com>
4090
4091         * ravenscar-thread.c (base_ptid): Remove.
4092         (struct ravenscar_thread_target) <close>: New method.
4093         <m_base_ptid>: New member.
4094         <update_inferior_ptid, active_task, task_is_currently_active,
4095         runtime_initialized>: Declare methods.
4096         <ravenscar_thread_target>: Add constructor.
4097         (ravenscar_thread_target::task_is_currently_active)
4098         (ravenscar_thread_target::update_inferior_ptid)
4099         (ravenscar_runtime_initialized): Rename.  Now methods.
4100         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4101         (ravenscar_thread_target::update_thread_list): Update.
4102         (ravenscar_thread_target::active_task): Now method.
4103         (ravenscar_thread_target::store_registers)
4104         (ravenscar_thread_target::prepare_to_store)
4105         (ravenscar_thread_target::prepare_to_store)
4106         (ravenscar_thread_target::mourn_inferior): Update.
4107         (ravenscar_inferior_created): Use "new" to create target.
4108         (ravenscar_thread_target::get_ada_task_ptid): Update.
4109         (_initialize_ravenscar): Don't initialize base_ptid.
4110         (ravenscar_ops): Remove global.
4111
4112 2019-02-15  Tom Tromey  <tromey@adacore.com>
4113
4114         * target.h (push_target): Declare new overload.
4115         * target.c (push_target): New overload, taking an rvalue reference.
4116         * remote.c (remote_target::open_1): Use push_target overload.
4117         * corelow.c (core_target_open): Use push_target overload.
4118
4119 2019-02-15  Tom Tromey  <tromey@adacore.com>
4120
4121         * ravenscar-thread.c (is_ravenscar_task)
4122         (ravenscar_task_is_currently_active): Return bool.
4123         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4124         (_initialize_ravenscar): Remove "(void)".
4125         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4126         Return bool.
4127
4128 2019-02-15  Tom Tromey  <tromey@adacore.com>
4129
4130         * ravenscar-thread.c (ravenscar_runtime_initializer)
4131         (has_ravenscar_runtime, get_running_thread_id)
4132         (ravenscar_thread_target::resume): Fix indentation.
4133
4134 2019-02-15  Tom Tromey  <tromey@adacore.com>
4135
4136         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4137         from ravenscar_arch_ops.
4138         (sparc_ravenscar_ops::fetch_registers)
4139         (sparc_ravenscar_ops::store_registers): Now methods.
4140         (sparc_ravenscar_prepare_to_store): Remove.
4141         (sparc_ravenscar_ops): Redefine.
4142         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4143         methods and destructor.  Remove members.
4144         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4145         (ravenscar_thread_target::store_registers)
4146         (ravenscar_thread_target::prepare_to_store): Update.
4147         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4148         Remove.
4149         (struct ppc_ravenscar_powerpc_ops): Derive from
4150         ravenscar_arch_ops.
4151         (ppc_ravenscar_powerpc_ops::fetch_registers)
4152         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4153         (ppc_ravenscar_powerpc_ops): Redefine.
4154         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4155         (ppc_ravenscar_e500_ops::fetch_registers)
4156         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4157         (ppc_ravenscar_e500_ops): Redefine.
4158         * aarch64-ravenscar-thread.c
4159         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4160         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4161         (aarch64_ravenscar_fetch_registers)
4162         (aarch64_ravenscar_store_registers): Now methods.
4163         (aarch64_ravenscar_ops): Redefine.
4164
4165 2019-02-15  Tom Tromey  <tromey@adacore.com>
4166
4167         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4168         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4169         (ravenscar_thread_target::stopped_by_watchpoint)
4170         (ravenscar_thread_target::stopped_data_address)
4171         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4172
4173 2019-02-15  Tom Tromey  <tromey@adacore.com>
4174
4175         * ravenscar-thread.c: Fix some typos.
4176
4177 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4178             Tom Tromey  <tromey@adacore.com>
4179
4180         * ada-lang.c (ada_exception_sal): Change addr_string to a
4181         std::string.
4182         (create_ada_exception_catchpoint): Update.
4183
4184 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4185             Tom Tromey  <tromey@adacore.com>
4186
4187         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4188         (bp_location_ops): Remove.
4189         (base_breakpoint_allocate_location): Update.
4190         (free_bp_location): Update.
4191         * ada-lang.c (class ada_catchpoint_location)
4192         <ada_catchpoint_location>: Remove ops parameter.
4193         (ada_catchpoint_location_dtor): Remove.
4194         (ada_catchpoint_location_ops): Remove.
4195         (allocate_location_exception): Update.
4196         * breakpoint.h (struct bp_location_ops): Remove.
4197         (class bp_location) <bp_location>: Remove bp_location_ops
4198         parameter.
4199         <~bp_location>: Add destructor.
4200         <ops>: Remove.
4201
4202 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4203             Pedro Alves  <palves@redhat.com>
4204
4205         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4206         'PATH_MAX'.
4207
4208 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4209             Samuel Thibault  <samuel.thibault@gnu.org>
4210             Thomas Schwinge  <thomas@codesourcery.com>
4211
4212         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4213         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4214
4215 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4216
4217         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4218         (check_empty): Use "const char *".
4219
4220         * gnu-nat.c (gnu_nat_target::detach): Instead of
4221         'detach_inferior (pid)' call
4222         'detach_inferior (find_inferior_pid (pid))'.
4223
4224         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4225         'nat/fork-inferior.o'.
4226         * gnu-nat.c: #include "nat/fork-inferior.h".
4227
4228         * gnu-nat.c (gnu_nat_target::detach): Instead of
4229         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4230         * gnu-nat.h: #include "inf-child.h".
4231         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4232         'i386_gnu_nat_target::fetch_registers'.
4233         (gnu_store_registers): Rename/move to
4234         'i386_gnu_nat_target::store_registers'.
4235
4236         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4237         * gnu-nat.h (mach_thread_info): New function.
4238         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4239
4240         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4241
4242 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4243
4244         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4245
4246 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4247
4248         * windows-nat.c (windows_add_thread): Add new parameter
4249         "main_thread_p" with default value set to false.  Update
4250         function documentation as well as all callers.
4251         (windows_delete_thread): Likewise.
4252         (fake_create_process): Update call to windows_add_thread.
4253         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4254         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4255         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4256         call to windows_delete_thread.
4257
4258 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4259
4260         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4261
4262 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4263
4264         * symfile.c (find_separate_debug_file): Use canonical path of
4265         sysroot with child_path instead of gdb_sysroot if it is valid.
4266
4267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4268
4269         * symfile.c (find_separate_debug_file): Use child_path to
4270         determine if an object file is under a sysroot.
4271
4272 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4273
4274         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4275         unittests/child-path-selftests.c.
4276         * common/pathstuff.c (child_path): New function.
4277         * common/pathstuff.h (child_path): New prototype.
4278         * unittests/child-path-selftests.c: New file.
4279
4280 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4281
4282         * symfile.c (find_separate_debug_file): Look for separate debug
4283         files in debug directories under the sysroot.
4284
4285 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4286
4287         * symtab.h (struct minimal_symbol data_p): New const method.
4288         (struct minimal_symbol text_p): Likewise.
4289         * symtab.c (output_source_filename): Use file name style
4290         to print file name.
4291         (print_symbol_info): Likewise.
4292         (print_msymbol_info): Use address style to print addresses.
4293         Use function name style to print executable text symbols.
4294         (expand_symtab_containing_pc): Use data_p.
4295         (find_pc_sect_compunit_symtab): Likewise.
4296
4297 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4298
4299         * breakpoint.c (describe_other_breakpoints): Use address style
4300         to print addresses.
4301         (say_where): Likewise.
4302
4303 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4304
4305         * ada-typeprint.c (print_func_type): Print function name
4306         style to print function name.
4307         * c-typeprint.c (c_print_type_1): Likewise.
4308
4309 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4310
4311         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4312         for execve.
4313
4314 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315
4316         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4317         type_stack.
4318
4319 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4320
4321         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4322         TYPE_CODE_REF types.
4323
4324 2019-02-08  Jim Wilson  <jimw@sifive.com>
4325
4326         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4327         (riscv_linux_fregset): New.
4328         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4329
4330 2019-02-07  Tom Tromey  <tom@tromey.com>
4331
4332         * thread.c (thread_cancel_execution_command): Update.
4333         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4334         methods.
4335         (struct thread_fsm_ops): Remove.
4336         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4337         (thread_fsm_should_stop, thread_fsm_return_value)
4338         (thread_fsm_set_finished, thread_fsm_finished_p)
4339         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4340         Don't declare.
4341         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4342         * infrun.c (clear_proceed_status_thread)
4343         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4344         (print_stop_event): Update.
4345         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4346         Add constructor.
4347         (step_command_fsm_ops): Remove.
4348         (new_step_command_fsm): Remove.
4349         (step_1): Update.
4350         (step_command_fsm::should_stop): Rename from
4351         step_command_fsm_should_stop.
4352         (step_command_fsm::clean_up): Rename from
4353         step_command_fsm_clean_up.
4354         (step_command_fsm::do_async_reply_reason): Rename from
4355         step_command_fsm_async_reply_reason.
4356         (struct until_next_fsm): Inherit from thread_fsm.  Add
4357         constructor.
4358         (until_next_fsm_ops): Remove.
4359         (new_until_next_fsm): Remove.
4360         (until_next_fsm::should_stop): Rename from
4361         until_next_fsm_should_stop.
4362         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4363         (until_next_fsm::do_async_reply_reason): Rename from
4364         until_next_fsm_async_reply_reason.
4365         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4366         constructor.  Change type of breakpoint.
4367         (finish_command_fsm_ops): Remove.
4368         (new_finish_command_fsm): Remove.
4369         (finish_command_fsm::should_stop): Rename from
4370         finish_command_fsm_should_stop.
4371         (finish_command_fsm::clean_up): Rename from
4372         finish_command_fsm_clean_up.
4373         (finish_command_fsm::return_value): Rename from
4374         finish_command_fsm_return_value.
4375         (finish_command_fsm::do_async_reply_reason): Rename from
4376         finish_command_fsm_async_reply_reason.
4377         (finish_command): Update.
4378         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4379         Add constructor.
4380         (call_thread_fsm_ops): Remove.
4381         (call_thread_fsm::call_thread_fsm): Rename from
4382         new_call_thread_fsm.
4383         (call_thread_fsm::should_stop): Rename from
4384         call_thread_fsm_should_stop.
4385         (call_thread_fsm::should_notify_stop): Rename from
4386         call_thread_fsm_should_notify_stop.
4387         (run_inferior_call, call_function_by_hand_dummy): Update.
4388         * cli/cli-interp.c (should_print_stop_to_console): Update.
4389         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4390         Add constructor.  Change type of location_breakpoint,
4391         caller_breakpoint.
4392         (until_break_fsm_ops): Remove.
4393         (new_until_break_fsm): Remove.
4394         (until_break_fsm::should_stop): Rename from
4395         until_break_fsm_should_stop.
4396         (until_break_fsm::clean_up): Rename from
4397         until_break_fsm_clean_up.
4398         (until_break_fsm::do_async_reply_reason): Rename from
4399         until_break_fsm_async_reply_reason.
4400         (until_break_command): Update.
4401         * thread-fsm.c: Remove.
4402         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4403
4404 2019-02-07  Tom Tromey  <tom@tromey.com>
4405
4406         * yy-remap.h: Add include guard.
4407         * xtensa-tdep.h: Add include guard.
4408         * xcoffread.h: Rename include guard.
4409         * varobj-iter.h: Add include guard.
4410         * tui/tui.h: Rename include guard.
4411         * tui/tui-winsource.h: Rename include guard.
4412         * tui/tui-wingeneral.h: Rename include guard.
4413         * tui/tui-windata.h: Rename include guard.
4414         * tui/tui-win.h: Rename include guard.
4415         * tui/tui-stack.h: Rename include guard.
4416         * tui/tui-source.h: Rename include guard.
4417         * tui/tui-regs.h: Rename include guard.
4418         * tui/tui-out.h: Rename include guard.
4419         * tui/tui-layout.h: Rename include guard.
4420         * tui/tui-io.h: Rename include guard.
4421         * tui/tui-hooks.h: Rename include guard.
4422         * tui/tui-file.h: Rename include guard.
4423         * tui/tui-disasm.h: Rename include guard.
4424         * tui/tui-data.h: Rename include guard.
4425         * tui/tui-command.h: Rename include guard.
4426         * tic6x-tdep.h: Add include guard.
4427         * target/waitstatus.h: Rename include guard.
4428         * target/wait.h: Rename include guard.
4429         * target/target.h: Rename include guard.
4430         * target/resume.h: Rename include guard.
4431         * target-float.h: Rename include guard.
4432         * stabsread.h: Add include guard.
4433         * rs6000-tdep.h: Add include guard.
4434         * riscv-fbsd-tdep.h: Add include guard.
4435         * regformats/regdef.h: Rename include guard.
4436         * record.h: Rename include guard.
4437         * python/python.h: Rename include guard.
4438         * python/python-internal.h: Rename include guard.
4439         * python/py-stopevent.h: Rename include guard.
4440         * python/py-ref.h: Rename include guard.
4441         * python/py-record.h: Rename include guard.
4442         * python/py-record-full.h: Rename include guard.
4443         * python/py-record-btrace.h: Rename include guard.
4444         * python/py-instruction.h: Rename include guard.
4445         * python/py-events.h: Rename include guard.
4446         * python/py-event.h: Rename include guard.
4447         * procfs.h: Add include guard.
4448         * proc-utils.h: Add include guard.
4449         * p-lang.h: Add include guard.
4450         * or1k-tdep.h: Rename include guard.
4451         * observable.h: Rename include guard.
4452         * nto-tdep.h: Rename include guard.
4453         * nat/x86-linux.h: Rename include guard.
4454         * nat/x86-linux-dregs.h: Rename include guard.
4455         * nat/x86-gcc-cpuid.h: Add include guard.
4456         * nat/x86-dregs.h: Rename include guard.
4457         * nat/x86-cpuid.h: Rename include guard.
4458         * nat/ppc-linux.h: Rename include guard.
4459         * nat/mips-linux-watch.h: Rename include guard.
4460         * nat/linux-waitpid.h: Rename include guard.
4461         * nat/linux-ptrace.h: Rename include guard.
4462         * nat/linux-procfs.h: Rename include guard.
4463         * nat/linux-osdata.h: Rename include guard.
4464         * nat/linux-nat.h: Rename include guard.
4465         * nat/linux-namespaces.h: Rename include guard.
4466         * nat/linux-btrace.h: Rename include guard.
4467         * nat/glibc_thread_db.h: Rename include guard.
4468         * nat/gdb_thread_db.h: Rename include guard.
4469         * nat/gdb_ptrace.h: Rename include guard.
4470         * nat/fork-inferior.h: Rename include guard.
4471         * nat/amd64-linux-siginfo.h: Rename include guard.
4472         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4473         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4474         * nat/aarch64-linux.h: Rename include guard.
4475         * nat/aarch64-linux-hw-point.h: Rename include guard.
4476         * mn10300-tdep.h: Add include guard.
4477         * mips-linux-tdep.h: Add include guard.
4478         * mi/mi-parse.h: Rename include guard.
4479         * mi/mi-out.h: Rename include guard.
4480         * mi/mi-main.h: Rename include guard.
4481         * mi/mi-interp.h: Rename include guard.
4482         * mi/mi-getopt.h: Rename include guard.
4483         * mi/mi-console.h: Rename include guard.
4484         * mi/mi-common.h: Rename include guard.
4485         * mi/mi-cmds.h: Rename include guard.
4486         * mi/mi-cmd-break.h: Rename include guard.
4487         * m2-lang.h: Add include guard.
4488         * location.h: Rename include guard.
4489         * linux-record.h: Rename include guard.
4490         * linux-nat.h: Add include guard.
4491         * linux-fork.h: Add include guard.
4492         * i386-darwin-tdep.h: Rename include guard.
4493         * hppa-linux-offsets.h: Add include guard.
4494         * guile/guile.h: Rename include guard.
4495         * guile/guile-internal.h: Rename include guard.
4496         * gnu-nat.h: Rename include guard.
4497         * gdb-stabs.h: Rename include guard.
4498         * frv-tdep.h: Add include guard.
4499         * f-lang.h: Add include guard.
4500         * event-loop.h: Add include guard.
4501         * darwin-nat.h: Rename include guard.
4502         * cp-abi.h: Rename include guard.
4503         * config/sparc/nm-sol2.h: Rename include guard.
4504         * config/nm-nto.h: Rename include guard.
4505         * config/nm-linux.h: Add include guard.
4506         * config/i386/nm-i386gnu.h: Rename include guard.
4507         * config/djgpp/nl_types.h: Rename include guard.
4508         * config/djgpp/langinfo.h: Rename include guard.
4509         * compile/gcc-cp-plugin.h: Add include guard.
4510         * compile/gcc-c-plugin.h: Add include guard.
4511         * compile/compile.h: Rename include guard.
4512         * compile/compile-object-run.h: Rename include guard.
4513         * compile/compile-object-load.h: Rename include guard.
4514         * compile/compile-internal.h: Rename include guard.
4515         * compile/compile-cplus.h: Rename include guard.
4516         * compile/compile-c.h: Rename include guard.
4517         * common/xml-utils.h: Rename include guard.
4518         * common/x86-xstate.h: Rename include guard.
4519         * common/version.h: Rename include guard.
4520         * common/vec.h: Rename include guard.
4521         * common/tdesc.h: Rename include guard.
4522         * common/selftest.h: Rename include guard.
4523         * common/scoped_restore.h: Rename include guard.
4524         * common/scoped_mmap.h: Rename include guard.
4525         * common/scoped_fd.h: Rename include guard.
4526         * common/safe-iterator.h: Rename include guard.
4527         * common/run-time-clock.h: Rename include guard.
4528         * common/refcounted-object.h: Rename include guard.
4529         * common/queue.h: Rename include guard.
4530         * common/ptid.h: Rename include guard.
4531         * common/print-utils.h: Rename include guard.
4532         * common/preprocessor.h: Rename include guard.
4533         * common/pathstuff.h: Rename include guard.
4534         * common/observable.h: Rename include guard.
4535         * common/netstuff.h: Rename include guard.
4536         * common/job-control.h: Rename include guard.
4537         * common/host-defs.h: Rename include guard.
4538         * common/gdb_wait.h: Rename include guard.
4539         * common/gdb_vecs.h: Rename include guard.
4540         * common/gdb_unlinker.h: Rename include guard.
4541         * common/gdb_unique_ptr.h: Rename include guard.
4542         * common/gdb_tilde_expand.h: Rename include guard.
4543         * common/gdb_sys_time.h: Rename include guard.
4544         * common/gdb_string_view.h: Rename include guard.
4545         * common/gdb_splay_tree.h: Rename include guard.
4546         * common/gdb_setjmp.h: Rename include guard.
4547         * common/gdb_ref_ptr.h: Rename include guard.
4548         * common/gdb_optional.h: Rename include guard.
4549         * common/gdb_locale.h: Rename include guard.
4550         * common/gdb_assert.h: Rename include guard.
4551         * common/filtered-iterator.h: Rename include guard.
4552         * common/filestuff.h: Rename include guard.
4553         * common/fileio.h: Rename include guard.
4554         * common/environ.h: Rename include guard.
4555         * common/common-utils.h: Rename include guard.
4556         * common/common-types.h: Rename include guard.
4557         * common/common-regcache.h: Rename include guard.
4558         * common/common-inferior.h: Rename include guard.
4559         * common/common-gdbthread.h: Rename include guard.
4560         * common/common-exceptions.h: Rename include guard.
4561         * common/common-defs.h: Rename include guard.
4562         * common/common-debug.h: Rename include guard.
4563         * common/cleanups.h: Rename include guard.
4564         * common/buffer.h: Rename include guard.
4565         * common/btrace-common.h: Rename include guard.
4566         * common/break-common.h: Rename include guard.
4567         * cli/cli-utils.h: Rename include guard.
4568         * cli/cli-style.h: Rename include guard.
4569         * cli/cli-setshow.h: Rename include guard.
4570         * cli/cli-script.h: Rename include guard.
4571         * cli/cli-interp.h: Rename include guard.
4572         * cli/cli-decode.h: Rename include guard.
4573         * cli/cli-cmds.h: Rename include guard.
4574         * charset-list.h: Add include guard.
4575         * buildsym-legacy.h: Rename include guard.
4576         * bfin-tdep.h: Add include guard.
4577         * ax.h: Rename include guard.
4578         * arm-linux-tdep.h: Add include guard.
4579         * arm-fbsd-tdep.h: Add include guard.
4580         * arch/xtensa.h: Rename include guard.
4581         * arch/tic6x.h: Add include guard.
4582         * arch/i386.h: Add include guard.
4583         * arch/arm.h: Rename include guard.
4584         * arch/arm-linux.h: Rename include guard.
4585         * arch/arm-get-next-pcs.h: Rename include guard.
4586         * arch/amd64.h: Add include guard.
4587         * arch/aarch64-insn.h: Rename include guard.
4588         * arch-utils.h: Rename include guard.
4589         * annotate.h: Add include guard.
4590         * amd64-darwin-tdep.h: Rename include guard.
4591         * aarch64-linux-tdep.h: Add include guard.
4592         * aarch64-fbsd-tdep.h: Add include guard.
4593         * aarch32-linux-nat.h: Add include guard.
4594
4595 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4596
4597         * macrotab.c (macro_define_internal): New function that
4598         factorizes macro_define_object_internal and macro_define_function
4599         code.
4600         (macro_define_object_internal): Use macro_define_internal.
4601         (macro_define_function): Likewise.
4602
4603 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4604
4605         * macrocmd.c (extract_identifier): Return
4606         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4607         callers.
4608
4609 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4610
4611         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4612
4613 2019-02-05  Tom Tromey  <tom@tromey.com>
4614
4615         * target.c (target_stack::unpush): Move assertion earlier.
4616
4617 2019-01-30  Tom Tromey  <tom@tromey.com>
4618
4619         PR python/23615:
4620         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4621         (gdbpy_parse_and_eval): Likewise.
4622         * python/python-internal.h (gdbpy_allow_threads): New class.
4623
4624 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4625
4626         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4627         (aarch64_fbsd_fpregmap): Move earlier.
4628         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4629         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4630         instead of individual calls to trad_frame_set_reg_addr.
4631         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4632         earlier.
4633         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4634         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4635         instead of individual calls to trad_frame_set_reg_addr.
4636
4637 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4638
4639         * CONTRIBUTE: Replace contribution list with wiki link.
4640
4641 2019-01-25  Tom Tromey  <tom@tromey.com>
4642
4643         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4644
4645 2019-01-25  Tom Tromey  <tom@tromey.com>
4646
4647         * xtensa-linux-nat.c: Fix common/ includes.
4648         * xml-support.h: Fix common/ includes.
4649         * xml-support.c: Fix common/ includes.
4650         * x86-linux-nat.c: Fix common/ includes.
4651         * windows-nat.c: Fix common/ includes.
4652         * varobj.h: Fix common/ includes.
4653         * varobj.c: Fix common/ includes.
4654         * value.c: Fix common/ includes.
4655         * valops.c: Fix common/ includes.
4656         * utils.c: Fix common/ includes.
4657         * unittests/xml-utils-selftests.c: Fix common/ includes.
4658         * unittests/utils-selftests.c: Fix common/ includes.
4659         * unittests/unpack-selftests.c: Fix common/ includes.
4660         * unittests/tracepoint-selftests.c: Fix common/ includes.
4661         * unittests/style-selftests.c: Fix common/ includes.
4662         * unittests/string_view-selftests.c: Fix common/ includes.
4663         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4664         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4665         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4666         * unittests/rsp-low-selftests.c: Fix common/ includes.
4667         * unittests/parse-connection-spec-selftests.c: Fix common/
4668         includes.
4669         * unittests/optional-selftests.c: Fix common/ includes.
4670         * unittests/offset-type-selftests.c: Fix common/ includes.
4671         * unittests/observable-selftests.c: Fix common/ includes.
4672         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4673         * unittests/memrange-selftests.c: Fix common/ includes.
4674         * unittests/memory-map-selftests.c: Fix common/ includes.
4675         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4676         * unittests/function-view-selftests.c: Fix common/ includes.
4677         * unittests/environ-selftests.c: Fix common/ includes.
4678         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4679         * unittests/common-utils-selftests.c: Fix common/ includes.
4680         * unittests/cli-utils-selftests.c: Fix common/ includes.
4681         * unittests/array-view-selftests.c: Fix common/ includes.
4682         * ui-file.c: Fix common/ includes.
4683         * tui/tui-io.c: Fix common/ includes.
4684         * tracepoint.h: Fix common/ includes.
4685         * tracepoint.c: Fix common/ includes.
4686         * tracefile-tfile.c: Fix common/ includes.
4687         * top.h: Fix common/ includes.
4688         * top.c: Fix common/ includes.
4689         * thread.c: Fix common/ includes.
4690         * target/waitstatus.h: Fix common/ includes.
4691         * target/waitstatus.c: Fix common/ includes.
4692         * target.h: Fix common/ includes.
4693         * target.c: Fix common/ includes.
4694         * target-memory.c: Fix common/ includes.
4695         * target-descriptions.c: Fix common/ includes.
4696         * symtab.h: Fix common/ includes.
4697         * symfile.c: Fix common/ includes.
4698         * stap-probe.c: Fix common/ includes.
4699         * spu-linux-nat.c: Fix common/ includes.
4700         * sparc-nat.c: Fix common/ includes.
4701         * source.c: Fix common/ includes.
4702         * solib.c: Fix common/ includes.
4703         * solib-target.c: Fix common/ includes.
4704         * ser-unix.c: Fix common/ includes.
4705         * ser-tcp.c: Fix common/ includes.
4706         * ser-pipe.c: Fix common/ includes.
4707         * ser-base.c: Fix common/ includes.
4708         * selftest-arch.c: Fix common/ includes.
4709         * s12z-tdep.c: Fix common/ includes.
4710         * rust-exp.y: Fix common/ includes.
4711         * rs6000-aix-tdep.c: Fix common/ includes.
4712         * riscv-tdep.c: Fix common/ includes.
4713         * remote.c: Fix common/ includes.
4714         * remote-notif.h: Fix common/ includes.
4715         * remote-fileio.h: Fix common/ includes.
4716         * remote-fileio.c: Fix common/ includes.
4717         * regcache.h: Fix common/ includes.
4718         * regcache.c: Fix common/ includes.
4719         * record-btrace.c: Fix common/ includes.
4720         * python/python.c: Fix common/ includes.
4721         * python/py-type.c: Fix common/ includes.
4722         * python/py-inferior.c: Fix common/ includes.
4723         * progspace.h: Fix common/ includes.
4724         * producer.c: Fix common/ includes.
4725         * procfs.c: Fix common/ includes.
4726         * proc-api.c: Fix common/ includes.
4727         * printcmd.c: Fix common/ includes.
4728         * ppc-linux-nat.c: Fix common/ includes.
4729         * parser-defs.h: Fix common/ includes.
4730         * osdata.c: Fix common/ includes.
4731         * obsd-nat.c: Fix common/ includes.
4732         * nat/x86-linux.c: Fix common/ includes.
4733         * nat/x86-linux-dregs.c: Fix common/ includes.
4734         * nat/x86-dregs.h: Fix common/ includes.
4735         * nat/x86-dregs.c: Fix common/ includes.
4736         * nat/ppc-linux.c: Fix common/ includes.
4737         * nat/mips-linux-watch.h: Fix common/ includes.
4738         * nat/mips-linux-watch.c: Fix common/ includes.
4739         * nat/linux-waitpid.c: Fix common/ includes.
4740         * nat/linux-ptrace.h: Fix common/ includes.
4741         * nat/linux-ptrace.c: Fix common/ includes.
4742         * nat/linux-procfs.c: Fix common/ includes.
4743         * nat/linux-personality.c: Fix common/ includes.
4744         * nat/linux-osdata.c: Fix common/ includes.
4745         * nat/linux-namespaces.c: Fix common/ includes.
4746         * nat/linux-btrace.h: Fix common/ includes.
4747         * nat/linux-btrace.c: Fix common/ includes.
4748         * nat/fork-inferior.c: Fix common/ includes.
4749         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4750         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4751         * nat/aarch64-linux.c: Fix common/ includes.
4752         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4753         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4754         * namespace.h: Fix common/ includes.
4755         * mips-linux-tdep.c: Fix common/ includes.
4756         * minsyms.c: Fix common/ includes.
4757         * mi/mi-parse.h: Fix common/ includes.
4758         * mi/mi-main.c: Fix common/ includes.
4759         * mi/mi-cmd-env.c: Fix common/ includes.
4760         * memrange.h: Fix common/ includes.
4761         * memattr.c: Fix common/ includes.
4762         * maint.h: Fix common/ includes.
4763         * maint.c: Fix common/ includes.
4764         * main.c: Fix common/ includes.
4765         * machoread.c: Fix common/ includes.
4766         * location.c: Fix common/ includes.
4767         * linux-thread-db.c: Fix common/ includes.
4768         * linux-nat.c: Fix common/ includes.
4769         * linux-fork.c: Fix common/ includes.
4770         * inline-frame.c: Fix common/ includes.
4771         * infrun.c: Fix common/ includes.
4772         * inflow.c: Fix common/ includes.
4773         * inferior.h: Fix common/ includes.
4774         * inferior.c: Fix common/ includes.
4775         * infcmd.c: Fix common/ includes.
4776         * inf-ptrace.c: Fix common/ includes.
4777         * inf-child.c: Fix common/ includes.
4778         * ia64-linux-nat.c: Fix common/ includes.
4779         * i387-tdep.c: Fix common/ includes.
4780         * i386-tdep.c: Fix common/ includes.
4781         * i386-linux-tdep.c: Fix common/ includes.
4782         * i386-linux-nat.c: Fix common/ includes.
4783         * i386-go32-tdep.c: Fix common/ includes.
4784         * i386-fbsd-tdep.c: Fix common/ includes.
4785         * i386-fbsd-nat.c: Fix common/ includes.
4786         * guile/scm-type.c: Fix common/ includes.
4787         * guile/guile.c: Fix common/ includes.
4788         * go32-nat.c: Fix common/ includes.
4789         * gnu-nat.c: Fix common/ includes.
4790         * gdbthread.h: Fix common/ includes.
4791         * gdbarch-selftests.c: Fix common/ includes.
4792         * gdb_usleep.c: Fix common/ includes.
4793         * gdb_select.h: Fix common/ includes.
4794         * gdb_bfd.c: Fix common/ includes.
4795         * gcore.c: Fix common/ includes.
4796         * fork-child.c: Fix common/ includes.
4797         * findvar.c: Fix common/ includes.
4798         * fbsd-nat.c: Fix common/ includes.
4799         * event-top.c: Fix common/ includes.
4800         * event-loop.c: Fix common/ includes.
4801         * dwarf2read.c: Fix common/ includes.
4802         * dwarf2loc.c: Fix common/ includes.
4803         * dwarf2-frame.c: Fix common/ includes.
4804         * dwarf-index-cache.c: Fix common/ includes.
4805         * dtrace-probe.c: Fix common/ includes.
4806         * disasm-selftests.c: Fix common/ includes.
4807         * defs.h: Fix common/ includes.
4808         * csky-tdep.c: Fix common/ includes.
4809         * cp-valprint.c: Fix common/ includes.
4810         * cp-support.h: Fix common/ includes.
4811         * cp-support.c: Fix common/ includes.
4812         * corelow.c: Fix common/ includes.
4813         * completer.h: Fix common/ includes.
4814         * completer.c: Fix common/ includes.
4815         * compile/compile.c: Fix common/ includes.
4816         * compile/compile-loc2c.c: Fix common/ includes.
4817         * compile/compile-cplus-types.c: Fix common/ includes.
4818         * compile/compile-cplus-symbols.c: Fix common/ includes.
4819         * command.h: Fix common/ includes.
4820         * cli/cli-dump.c: Fix common/ includes.
4821         * cli/cli-cmds.c: Fix common/ includes.
4822         * charset.c: Fix common/ includes.
4823         * build-id.c: Fix common/ includes.
4824         * btrace.h: Fix common/ includes.
4825         * btrace.c: Fix common/ includes.
4826         * breakpoint.h: Fix common/ includes.
4827         * breakpoint.c: Fix common/ includes.
4828         * ax.h:
4829         (enum agent_op): Fix common/ includes.
4830         * ax-general.c (struct aop_map): Fix common/ includes.
4831         * ax-gdb.c: Fix common/ includes.
4832         * auxv.c: Fix common/ includes.
4833         * auto-load.c: Fix common/ includes.
4834         * arm-tdep.c: Fix common/ includes.
4835         * arch/riscv.c: Fix common/ includes.
4836         * arch/ppc-linux-common.c: Fix common/ includes.
4837         * arch/i386.c: Fix common/ includes.
4838         * arch/arm.c: Fix common/ includes.
4839         * arch/arm-linux.c: Fix common/ includes.
4840         * arch/arm-get-next-pcs.c: Fix common/ includes.
4841         * arch/amd64.c: Fix common/ includes.
4842         * arch/aarch64.c: Fix common/ includes.
4843         * arch/aarch64-insn.c: Fix common/ includes.
4844         * arch-utils.c: Fix common/ includes.
4845         * amd64-windows-tdep.c: Fix common/ includes.
4846         * amd64-tdep.c: Fix common/ includes.
4847         * amd64-sol2-tdep.c: Fix common/ includes.
4848         * amd64-obsd-tdep.c: Fix common/ includes.
4849         * amd64-nbsd-tdep.c: Fix common/ includes.
4850         * amd64-linux-tdep.c: Fix common/ includes.
4851         * amd64-linux-nat.c: Fix common/ includes.
4852         * amd64-fbsd-tdep.c: Fix common/ includes.
4853         * amd64-fbsd-nat.c: Fix common/ includes.
4854         * amd64-dicos-tdep.c: Fix common/ includes.
4855         * amd64-darwin-tdep.c: Fix common/ includes.
4856         * agent.c: Fix common/ includes.
4857         * ada-lang.h: Fix common/ includes.
4858         * ada-lang.c: Fix common/ includes.
4859         * aarch64-tdep.c: Fix common/ includes.
4860
4861 2019-01-25  Tom Tromey  <tom@tromey.com>
4862
4863         * common/create-version.sh: Use common/version.h.
4864
4865 2019-01-24  Pedro Alves  <palves@redhat.com>
4866
4867         * infrun.c (signal_stop, signal_print, signal_program)
4868         (signal_catch, signal_pass): Now arrays instead of pointers.
4869         (update_signals_program_target, do_target_resume)
4870         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4871         * linux-nat.c (linux_nat_target::pass_signals)
4872         (linux_nat_target::create_inferior, linux_nat_target::attach):
4873         Adjust.
4874         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4875         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4876         * procfs.c (procfs_target::pass_signals): Adjust.
4877         * record-full.c (record_full_target::resume): Adjust.
4878         * remote.c (remote_target::pass_signals)
4879         (remote_target::program_signals): Adjust.
4880         * target-debug.h (target_debug_print_signals): Now takes a
4881         gdb::array_view as parameter.  Adjust.
4882         * target.h (target_ops) <pass_signals, program_signals>: Replace
4883         pointer and length parameters with gdb::array_view.
4884         (target_pass_signals, target_program_signals): Likewise.
4885         * target-delegates.c: Regenerate.
4886
4887 2019-01-24  Pedro Alves  <palves@redhat.com>
4888
4889         * common/forward-scope-exit.h
4890         (forward_scope_exit::forward_scope_exit): Pass arguments to
4891         m_bind_function directly, instead of creating a std::bind and
4892         copying that.
4893
4894 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4895
4896         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4897         for static members.
4898         (pass_in_v_vfp_candidate): Likewise.
4899
4900 2019-01-23  Tom Tromey  <tom@tromey.com>
4901             Pedro Alves  <palves@redhat.com>
4902
4903         * regcache.c (class regcache_invalidator): Remove.
4904         (regcache::raw_write): Use make_scope_exit.
4905
4906 2019-01-23  Tom Tromey  <tom@tromey.com>
4907
4908         * ui-out.h (class ui_out_emit_type): Update comment.
4909
4910 2019-01-23  Tom Tromey  <tom@tromey.com>
4911
4912         * infrun.c (fetch_inferior_event): Update comment.
4913
4914 2019-01-23  Tom Tromey  <tom@tromey.com>
4915             Pedro Alves  <palves@redhat.com>
4916
4917         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4918         parameter.
4919         (fetch_inferior_event): Use SCOPE_EXIT.
4920
4921
4922 2019-01-23  Tom Tromey  <tom@tromey.com>
4923             Pedro Alves  <palves@redhat.com>
4924
4925         * infrun.c (disable_thread_events): Delete.
4926         (stop_all_threads): Use SCOPE_EXIT.
4927
4928 2019-01-23  Tom Tromey  <tom@tromey.com>
4929             Pedro Alves  <palves@redhat.com>
4930
4931         * symfile.c: Include forward-scope-exit.h.
4932         (clear_symtab_users_cleanup): Replace forward declaration with
4933         a FORWARD_SCOPE_EXIT.
4934         (syms_from_objfile_1): Use the forward_scope_exit and
4935         gdb::optional instead of cleanup_function.
4936         (reread_symbols): Use the forward_scope_exit instead of
4937         cleanup_function.
4938         (clear_symtab_users_cleanup): Remove function.
4939
4940 2019-01-23  Tom Tromey  <tom@tromey.com>
4941             Pedro Alves  <palves@redhat.com>
4942
4943         * linux-nat.c: Include scope-exit.h.
4944         (cleanup_target_stop): Remove.
4945         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4946         SCOPE_EXIT.
4947
4948 2019-01-23  Tom Tromey  <tom@tromey.com>
4949             Pedro Alves  <palves@redhat.com>
4950
4951         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4952         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4953
4954 2019-01-23  Tom Tromey  <tom@tromey.com>
4955             Andrew Burgess  <andrew.burgess@embecosm.com>
4956             Pedro Alves  <palves@redhat.com>
4957
4958         * infrun.c (fetch_inferior_event): Use scope_exit.
4959         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4960         * top.c (execute_command): Use scope_exit.
4961         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4962         * utils.c (do_bpstat_clear_actions_cleanup)
4963         (make_bpstat_clear_actions_cleanup): Remove.
4964
4965 2019-01-23  Tom Tromey  <tom@tromey.com>
4966             Pedro Alves  <palves@redhat.com>
4967
4968         * infrun.c: Include "common/scope-exit.h"
4969         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4970         (wait_for_inferior): Use SCOPE_EXIT.
4971         (fetch_inferior_event): Use scope_exit.
4972
4973 2019-01-23  Tom Tromey  <tom@tromey.com>
4974             Pedro Alves  <palves@redhat.com>
4975
4976         * breakpoint.c (create_breakpoint): Remove cleanup.
4977
4978 2019-01-23  Tom Tromey  <tom@tromey.com>
4979             Andrew Burgess  <andrew.burgess@embecosm.com>
4980             Pedro Alves  <palves@redhat.com>
4981
4982 2019-01-23  Pedro Alves  <palves@redhat.com>
4983
4984         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4985
4986 2019-01-23  Pedro Alves  <palves@redhat.com>
4987             Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * gdbthread.h: Include "common/forward-scope-exit.h".
4990         (scoped_finish_thread_state): Redefine custom class in terms of
4991         forward_scope_exit.
4992
4993 2019-01-23  Pedro Alves  <palves@redhat.com>
4994             Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * common/forward-scope-exit.h: New file.
4997
4998 2019-01-23  Pedro Alves  <palves@redhat.com>
4999             Andrew Burgess  <andrew.burgess@embecosm.com>
5000             Tom Tromey  <tom@tromey.com>
5001
5002         * common/scope-exit.h: New file.
5003
5004 2019-01-23  Pedro Alves  <palves@redhat.com>
5005
5006         * common/preprocessor.h (ESC): Rename to ...
5007         (ESC_PARENS): ... this.
5008         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5009         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5010
5011 2019-01-23  Tom Tromey  <tom@tromey.com>
5012
5013         * language.h (class scoped_switch_to_sym_language_if_auto):
5014         Initialize m_lang in both cases.
5015
5016 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5017
5018         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5019         with XCNEW.
5020
5021 2019-01-22  Tom Tromey  <tom@tromey.com>
5022
5023         * corelow.c: Do not include sys/file.h.
5024
5025 2019-01-22  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-wingeneral.h: Include gdb_curses.h.
5028
5029 2019-01-22  Tom Tromey  <tom@tromey.com>
5030
5031         * source-cache.h (class source_cache) <get_source_lines,
5032         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5033
5034 2019-01-22  Tom Tromey  <tom@tromey.com>
5035
5036         * remote-fileio.h (struct remote_target): Declare.
5037
5038 2019-01-22  Tom Tromey  <tom@tromey.com>
5039
5040         * python/py-arch.c: Do not include py-ref.h.
5041         * python/py-bpevent.c: Do not include py-ref.h.
5042         * python/py-cmd.c: Do not include py-ref.h.
5043         * python/py-continueevent.c: Do not include py-ref.h.
5044         * python/py-event.h: Do not include py-ref.h.
5045         * python/py-evtregistry.c: Do not include py-ref.h.
5046         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5047         * python/py-frame.c: Do not include py-ref.h.
5048         * python/py-framefilter.c: Do not include py-ref.h.
5049         * python/py-function.c: Do not include py-ref.h.
5050         * python/py-infevents.c: Do not include py-ref.h.
5051         * python/py-linetable.c: Do not include py-ref.h.
5052         * python/py-objfile.c: Do not include py-ref.h.
5053         * python/py-param.c: Do not include py-ref.h.
5054         * python/py-prettyprint.c: Do not include py-ref.h.
5055         * python/py-progspace.c: Do not include py-ref.h.
5056         * python/py-symbol.c: Do not include py-ref.h.
5057         * python/py-symtab.c: Do not include py-ref.h.
5058         * python/py-type.c: Do not include py-ref.h.
5059         * python/py-unwind.c: Do not include py-ref.h.
5060         * python/py-utils.c: Do not include py-ref.h.
5061         * python/py-value.c: Do not include py-ref.h.
5062         * python/py-varobj.c: Do not include py-ref.h.
5063         * python/py-xmethods.c: Do not include py-ref.h.
5064         * python/python.c: Do not include py-ref.h.
5065         * varobj.c: Do not include py-ref.h.
5066
5067 2019-01-22  Tom Tromey  <tom@tromey.com>
5068
5069         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5070         keyword for bcache.
5071
5072 2019-01-22  Tom Tromey  <tom@tromey.com>
5073
5074         * compile/compile-cplus-types.c: Remove a comment by #include.
5075
5076 2019-01-22  Tom Tromey  <tom@tromey.com>
5077
5078         * compile/gcc-c-plugin.h: Include compile-internal.h.
5079
5080 2019-01-22  Tom Tromey  <tom@tromey.com>
5081
5082         * stabsread.c (EXTERN): Do not define.
5083         (symnum, next_symbol_text_func, processing_gcc_compilation)
5084         (within_function, global_sym_chain, global_stabs)
5085         (previous_stab_code, this_object_header_files)
5086         (n_this_object_header_files)
5087         (n_allocated_this_object_header_files): Define.
5088         * stabsread.h (EXTERN): Never define.  Use "extern".
5089
5090 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5091
5092         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5093         history_value.
5094
5095 2019-01-21  Tom Tromey  <tom@tromey.com>
5096
5097         * ui-out.c: Fix includes.
5098         * tui/tui-source.c: Fix includes.
5099         * target.c: Fix includes.
5100         * remote.c: Fix includes.
5101         * regcache.c: Fix includes.
5102         * python/py-block.c: Fix includes.
5103         * printcmd.c: Fix includes.
5104         * or1k-tdep.c: Fix includes.
5105         * mi/mi-main.c: Fix includes.
5106         * m32r-tdep.c: Fix includes.
5107         * csky-tdep.c: Fix includes.
5108         * compile/compile-cplus-types.c: Fix includes.
5109         * cli/cli-interp.c: Fix includes.
5110
5111 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5114         for padding.
5115
5116 2019-01-16  Tom Tromey  <tom@tromey.com>
5117
5118         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5119         earlier.
5120         (struct objfile) <msymbols_range>: Move from top level.
5121         <msymbols>: New method.
5122         (class objfile_msymbols): Remove.
5123         * symtab.c (default_collect_symbol_completion_matches_break_on):
5124         Update.
5125         * symmisc.c (dump_msymbols): Update.
5126         * stabsread.c (scan_file_globals): Update.
5127         * objc-lang.c (info_selectors_command, info_classes_command)
5128         (find_methods): Update.
5129         * minsyms.c (find_solib_trampoline_target): Update.
5130         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5131         * coffread.c (coff_symfile_read): Update.
5132         * ada-lang.c (ada_lookup_simple_minsym)
5133         (ada_collect_symbol_completion_matches): Update.
5134
5135 2019-01-16  Tom Tromey  <tom@tromey.com>
5136
5137         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5138         type.  Remove no-argument constructor.
5139         <iterator::operator++>: Simplify.
5140         <begin>: Update.
5141         <end>: Use minimal_symbol_count.
5142
5143 2019-01-16  Tom Tromey  <tom@tromey.com>
5144
5145         * objfiles.h (struct objfile) <psymtabs>: New method.
5146         (class objfile_psymtabs): Remove.
5147         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5148         typedef.
5149         <range>: New method.
5150         (require_partial_symbols): Change return type.
5151         * psymtab.c (require_partial_symbols)
5152         (psym_expand_symtabs_matching): Update.
5153         * mdebugread.c (parse_partial_symbols): Update.
5154         * dbxread.c (dbx_end_psymtab): Update.
5155
5156 2019-01-15  Tom Tromey  <tom@tromey.com>
5157
5158         * symtab.c (lookup_objfile_from_block)
5159         (lookup_symbol_in_objfile_symtabs)
5160         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5161         (find_line_symtab, info_sources_command)
5162         (default_collect_symbol_completion_matches_break_on)
5163         (make_source_files_completion_list): Update.
5164         * symmisc.c (print_objfile_statistics, dump_objfile)
5165         (maintenance_print_symbols, maintenance_info_symtabs)
5166         (maintenance_check_symtabs, maintenance_info_line_tables):
5167         Update.
5168         * source.c (select_source_symtab)
5169         (forget_cached_source_info_for_objfile): Update.
5170         * objfiles.h (class objfile_compunits): Remove.
5171         (struct objfile) <compunits_range>: New typedef.
5172         (compunits): New method.
5173         * objfiles.c (objfile_relocate1): Update.
5174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5175         * maint.c (count_symtabs_and_blocks): Update.
5176         * linespec.c (iterate_over_all_matching_symtabs): Update.
5177         * cp-support.c (add_symbol_overload_list_qualified): Update.
5178         * coffread.c (coff_symtab_read): Update.
5179         * ada-lang.c (add_nonlocal_symbols)
5180         (ada_collect_symbol_completion_matches)
5181         (ada_add_global_exceptions): Update.
5182
5183 2019-01-15  Tom Tromey  <tom@tromey.com>
5184
5185         * progspace.h (program_space) <objfiles_safe_range>: New
5186         typedef.
5187         <objfiles_safe>: New method.
5188         * objfiles.h (class all_objfiles_safe): Remove.
5189         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5190         * jit.c (jit_inferior_exit_hook): Update.
5191
5192 2019-01-17  Tom Tromey  <tom@tromey.com>
5193
5194         * progspace.h (program_space) <objfiles_range>: New typedef.
5195         <objfiles>: New method.
5196         <objfiles_head>: Rename from objfiles.
5197         (object_files): Update.
5198         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5199         * guile/scm-pretty-print.c
5200         (ppscm_find_pretty_printer_from_objfiles): Update.
5201         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5202         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5203         Update.
5204         * python/py-progspace.c (pspy_get_objfiles): Update.
5205         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5206         Update.
5207         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5208         (objfpy_lookup_objfile_by_build_id): Update.
5209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5210         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5211         Update.
5212         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5213         (expand_symtab_containing_pc, lookup_objfile_from_block)
5214         (lookup_static_symbol, basic_lookup_transparent_type)
5215         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5216         (find_line_symtab, info_sources_command)
5217         (default_collect_symbol_completion_matches_break_on)
5218         (make_source_files_completion_list, find_main_name): Update.
5219         * symmisc.c (print_symbol_bcache_statistics)
5220         (print_objfile_statistics, maintenance_print_symbols)
5221         (maintenance_print_msymbols, maintenance_print_objfiles)
5222         (maintenance_info_symtabs, maintenance_check_symtabs)
5223         (maintenance_expand_symtabs, maintenance_info_line_tables):
5224         Update.
5225         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5226         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5227         (map_overlay_command, unmap_overlay_command)
5228         (simple_overlay_update, expand_symtabs_matching)
5229         (map_symbol_filenames): Update.
5230         * symfile-debug.c (set_debug_symfile): Update.
5231         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5232         Update.
5233         * source.c (select_source_symtab, forget_cached_source_info):
5234         Update.
5235         * solib.c (solib_read_symbols): Update.
5236         * solib-spu.c (append_ocl_sos): Update.
5237         * psymtab.c (maintenance_print_psymbols)
5238         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5239         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5240         * printcmd.c (info_symbol_command): Update.
5241         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5242         Update.
5243         * objfiles.h (class all_objfiles): Remove.
5244         * objfiles.c (have_partial_symbols, have_full_symbols)
5245         (have_minimal_symbols, qsort_cmp, update_section_map)
5246         (shared_objfile_contains_address_p)
5247         (default_iterate_over_objfiles_in_search_order): Update.
5248         * objc-lang.c (info_selectors_command, info_classes_command)
5249         (find_methods): Update.
5250         * minsyms.c (find_solib_trampoline_target): Update.
5251         * maint.c (maintenance_info_sections)
5252         (maintenance_translate_address, count_symtabs_and_blocks):
5253         Update.
5254         * main.c (captured_main_1): Update.
5255         * linux-thread-db.c (try_thread_db_load_from_pdir)
5256         (has_libpthread): Update.
5257         * linespec.c (iterate_over_all_matching_symtabs)
5258         (search_minsyms_for_name): Update.
5259         * jit.c (jit_find_objf_with_entry_addr): Update.
5260         * hppa-tdep.c (find_unwind_entry)
5261         (hppa_lookup_stub_minimal_symbol): Update.
5262         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5263         Update.
5264         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5265         (elf_gnu_ifunc_resolve_by_got): Update.
5266         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5267         * dwarf-index-write.c (save_gdb_index_command): Update.
5268         * cp-support.c (add_symbol_overload_list_qualified): Update.
5269         * breakpoint.c (create_overlay_event_breakpoint)
5270         (create_longjmp_master_breakpoint)
5271         (create_std_terminate_master_breakpoint)
5272         (create_exception_master_breakpoint): Update.
5273         * blockframe.c (find_pc_partial_function): Update.
5274         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5275         (ada_collect_symbol_completion_matches)
5276         (ada_add_global_exceptions): Update.
5277
5278 2019-01-17  Tom Tromey  <tom@tromey.com>
5279
5280         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5281         declare VEC.
5282         (solib_target_parse_libraries): Change return type.
5283         (library_list_start_segment, library_list_start_section)
5284         (library_list_end_library, library_list_start_library); Update.
5285         (solib_target_free_library_list): Remove.
5286         (solib_target_parse_libraries): Remove cleanup.  Change return
5287         type.
5288         (solib_target_current_sos): Update.
5289
5290 2019-01-17  Tom Tromey  <tromey@bapiya>
5291
5292         * valprint.c: Replace "the the" with "the".
5293         * symtab.c: Replace "the the" with "the".
5294         * solib.c: Replace "the the" with "the".
5295         * solib-dsbt.c: Replace "the the" with "the".
5296         * linespec.c: Replace "the the" with "the".
5297         * dwarf2loc.h: Replace "the the" with "the".
5298         * amd64-windows-tdep.c: Replace "the the" with "the".
5299         * aarch64-tdep.c: Replace "the the" with "the".
5300
5301 2019-01-16  Keith Seitz  <keiths@redhat.com>
5302
5303         PR gdb/23773
5304         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5305         <builder>: Rename to ..
5306         <m_builder>: ... this and make private.
5307         (dwarf2_cu::get_builder): New method.  Change all users of
5308         `builder' to use this method.
5309         (dwarf2_start_symtab): Move to ...
5310         (dwarf2_cu::start_symtab): ... here.  Update all callers
5311         (setup_type_unit_groups): Move to ...
5312         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5313         callers.
5314         (dwarf2_cu::reset_builder): New method.
5315         (process_full_compunit, process_full_type_unit): Use
5316         dwarf2_cu::reset_builder.
5317         (follow_die_offset): Record the ancestor CU if it is different
5318         from the followed DIE's CU.
5319         (follow_die_sig_1): Likewise.
5320
5321 2019-01-15  Tom Tromey  <tom@tromey.com>
5322
5323         * remote.c (class remote_state) <buf>: Now a char_vector.
5324         <buf_size>: Remove.
5325         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5326         parameter.
5327         (remote_target::getpkt_or_notif_sane_1)
5328         (remote_target::getpkt_sane)
5329         (remote_target::getpkt_or_notif_sane): Likewise.
5330         (class remote_target) <putpkt>: New overload.
5331         (remote_target::read_frame): Change type of "buf_p".  Remove
5332         sizeof_p parameter.
5333         (packet_ok): New overload.
5334         (packet_check_result): New overload.
5335         Update all uses.
5336
5337 2019-01-14  Tom Tromey  <tom@tromey.com>
5338
5339         * remote-notif.c (handle_notification, remote_notif_ack)
5340         (remote_notif_parse): Make "buf" const.
5341         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5342         const.
5343         (remote_notif_parse, remote_notif_ack, handle_notification):
5344         Likewise.
5345         * remote.c (remote_notif_stop_parse): Make "buf" const.
5346         (remote_target::remote_parse_stop_reply): Make "buf" const.
5347         (remote_notif_stop_ack): Make "buf" const.
5348
5349 2019-01-14  Tom Tromey  <tom@tromey.com>
5350
5351         * remote.c (remote_console_output): Make parameter const.
5352
5353 2019-01-14  Tom Tromey  <tom@tromey.com>
5354
5355         * target-debug.h (target_debug_print_signals): Constify.
5356         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5357         * procfs.c (procfs_target::pass_signals): Update.
5358         * linux-nat.c (linux_nat_target::pass_signals): Update.
5359         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5360         * target-delegates.c: Rebuild.
5361         * remote.c (remote_target::program_signals): Update.
5362         (remote_target::pass_signals): Update.
5363         * target.c (target_pass_signals): Constify argument.
5364         (target_program_signals): Likewise.
5365         * target.h (struct target_ops) <pass_signals, program_signals>:
5366         Constify argument.
5367         (target_pass_signals, target_program_signals): Constify argument.
5368
5369 2019-01-14  Tom Tromey  <tom@tromey.com>
5370
5371         PR tui/28819:
5372         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5373
5374 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5375
5376         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5377         field.
5378         * rs6000-tdep.c: Include reggroups.h.
5379         (IS_V_ALIAS_PSEUDOREG): Define.
5380         (rs6000_register_name): Return names for the "vX" aliases.
5381         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5382         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5383         aliases.  Call default_register_reggroup_p for all other
5384         pseudo-registers.
5385         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5386         New functions.
5387         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5388         Handle "vX" aliases.
5389         (v_alias_pseudo_register_collect): New function.
5390         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5391         (rs6000_gdbarch_init): Initialize "vX" aliases as
5392         pseudo-registers.  Restore registration of
5393         rs6000_pseudo_register_reggroup_p with
5394         set_tdesc_pseudo_register_reggroup_p.
5395
5396 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5397
5398         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5399         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5400         set_gdbarch_num_pseudo_regs.
5401
5402 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5403
5404         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5405         Remove arg prefixname, add do_set and do_show.
5406         Add member functions set_list and show_list.
5407         * cli/cli-style.c (class cli_style_option): Update accordingly.
5408         (style_set_list): Move to file scope.
5409         (style_show_list): Likewise.
5410         (set_style): Call help_list.
5411         (show_style): Call cmd_show_list.
5412         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5413         Update to use the new macro.
5414
5415 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5416
5417         * ada-lang.c (_initialize_ada_language): Expand the help text
5418         for the "catch exception" command.
5419
5420 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5421
5422         * symtab.c (matching_obj_sections): Initialize obj,
5423         declare it closer to its usage.
5424
5425 2019-01-10  Tom Tromey  <tom@tromey.com>
5426
5427         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5428         (basic_inf_threads_range): Remove.
5429         (inf_threads_range, inf_non_exited_threads_range)
5430         (safe_inf_threads_range): Use next_adapter.
5431
5432 2019-01-10  Keith Seitz  <keiths@redhat.com>
5433
5434         PR gdb/23712
5435         PR symtab/23010
5436         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5437         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5438
5439 2019-01-10  Keith Seitz  <keiths@redhat.com>
5440
5441         PR gdb/23712
5442         PR symtab/23010
5443         * dictionary.c (pending_to_vector): Remove.
5444         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5445         Remove _1 suffix, replacing functions of the same name.  Update
5446         all callers.
5447         (dict_create_hashed, dict_create_hashed_expandable)
5448         (dict_create_linear, dict_create_linear_expandable, dict_free)
5449         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5450         Make functions static.
5451
5452 2019-01-10  Keith Seitz  <keiths@redhat.com>
5453
5454         PR gdb/23712
5455         PR symtab/23010
5456         * dictionary.h (struct dictionary): Replace declaration with
5457         multidictionary.
5458         (dict_create_hashed, dict_create_hashed_expandable)
5459         (dict_create_linear, dict_create_linear_expandable)
5460         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5461         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5462         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5463         taking multidictionary argument.
5464         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5465         * block.h (struct block) <dict>: Change to multidictionary
5466         and rename `multidict'.
5467         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5468         symmisc.c: Update all dictionary references to multidictionary.
5469
5470 2019-01-10  Keith Seitz  <keiths@redhat.com>
5471
5472         PR gdb/23712
5473         PR symtab/23010
5474         * dictionary.c: Include unordered_map.
5475         (pending_to_vector): New function.
5476         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5477         Rewrite the non-"_1" functions to take vector instead
5478         of linked list.
5479         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5480         "new" _1 versions of the same name.
5481         (multidictionary): Define.
5482         (std::hash<enum language): New definition.
5483         (collate_pending_symbols_by_language, mdict_create_hashed)
5484         (mdict_create_hashed_expandable, mdict_create_linear)
5485         (mdict_create_linear_expandable, mdict_free)
5486         (find_language_dictionary, create_new_language_dictionary)
5487         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5488         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5489         (mdict_size, mdict_empty): New functions.
5490         * dictionary.h (mdict_iterator): Define.
5491
5492 2019-01-10  Pedro Alves  <palves@redhat.com>
5493
5494         * breakpoint.c (read_uploaded_action)
5495         (create_tracepoint_from_upload): Adjust to use
5496         gdb::unique_xmalloc_ptr.
5497         * ctf.c (ctf_write_uploaded_tp):
5498         (SET_ARRAY_FIELD): Use emplace_back.
5499         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5500         * tracefile-tfile.c (tfile_write_uploaded_tp):
5501         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5502         gdb::unique_xmalloc_ptr.
5503         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5504         at_string, cond_string, cmd_strings>: Replace char pointers
5505         with gdb::unique_xmalloc_ptr.
5506
5507 2019-01-10  Pedro Alves  <palves@redhat.com>
5508
5509         * solib-target.c (library_list_start_library): Don't xstrdup name.
5510
5511 2019-01-10  Pedro Alves  <palves@redhat.com>
5512
5513         * mdebugread.c (parse_partial_symbols): Use
5514         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5515
5516 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * linux-fork.c (scoped_switch_fork_info)
5519         <~scoped_switch_fork_info>: Fix incorrect variable name.
5520
5521 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5522
5523         * linux-fork.c (scoped_switch_fork_info)
5524         <scoped_switch_fork_info>: Make explicit.
5525         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5526
5527 2019-01-10  Tom Tromey  <tom@tromey.com>
5528
5529         * objfiles.h (objfile::reset_psymtabs): Update.
5530         * objfiles.c (objfile::objfile): Update.
5531         * psymtab.h (psymtab_storage::obstack): Update.
5532         (psymtab_storage::m_obstack): Use gdb::optional.
5533         (class psymtab_storage): Update comment.  Remove objfile
5534         parameter.
5535         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5536
5537 2019-01-10  Tom Tromey  <tom@tromey.com>
5538
5539         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5540         <free_psymtabs>: Now private.
5541         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5542         (allocate_psymtab): Use new method.
5543
5544 2019-01-10  Tom Tromey  <tom@tromey.com>
5545
5546         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5547         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5548         * mdebugread.c (parse_partial_symbols): Use
5549         allocate_dependencies.
5550         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5551         allocate_dependencies.
5552         (process_psymtab_comp_unit_reader)
5553         (build_type_psymtab_dependencies): Likewise.
5554         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5555
5556 2019-01-10  Tom Tromey  <tom@tromey.com>
5557
5558         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5559         PSYMBOL_SET_LANGUAGE.
5560         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5561
5562 2019-01-10  Tom Tromey  <tom@tromey.com>
5563
5564         * psymtab.h (psymtab_storage::obstack): New method.
5565         <m_obstack>: Rename from obstack; now private.
5566         * psymtab.c (psymtab_storage): Update.
5567         * dwarf2read.c (create_addrmap_from_index)
5568         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5569         Update.
5570
5571 2019-01-10  Tom Tromey  <tom@tromey.com>
5572
5573         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5574         * objfiles.h (objfile::reset_psymtabs): New method.
5575
5576 2019-01-10  Tom Tromey  <tom@tromey.com>
5577
5578         * symmisc.c (print_symbol_bcache_statistics): Update.
5579         (print_objfile_statistics): Update.
5580         * symfile.c (reread_symbols): Update.
5581         * psymtab.h (class psymtab_storage): New.
5582         * psymtab.c (psymtab_storage): New constructor.
5583         (~psymtab_storage): New destructor.
5584         (require_partial_symbols): Update.
5585         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5586         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5587         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5588         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5589         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5590         (start_psymtab_common, end_psymtab_common)
5591         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5592         (allocate_psymtab): Update.
5593         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5594         Update.
5595         (dump_psymtab_addrmap, maintenance_print_psymbols)
5596         (maintenance_check_psymtabs): Update.
5597         (class objfile_psymtabs): Move to objfiles.h.
5598         * psympriv.h (discard_psymtab): Now inline.
5599         (psymtab_discarder::psymtab_discarder): Update.
5600         (psymtab_discarder::~psymtab_discarder): Update.
5601         (ALL_OBJFILE_PSYMTABS): Rewrite.
5602         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5603         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5604         Remove fields.
5605         <partial_symtabs>: New field.
5606         (class objfile_psymtabs): Move from psymtab.h.  Update.
5607         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5608         psymbol_cache.
5609         (objfile::~objfile): Don't destroy psymbol_cache.
5610         * mdebugread.c (parse_partial_symbols): Update.
5611         * dwarf2read.c (create_addrmap_from_index)
5612         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5613         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5614         (add_partial_subprogram, dwarf2_ranges_read): Update.
5615         * dwarf-index-write.c (write_address_map)
5616         (write_one_signatured_type, recursively_write_psymbols)
5617         (class debug_names, class debug_names, write_psymtabs_to_index):
5618         Update.
5619
5620 2019-01-10  Tom Tromey  <tom@tromey.com>
5621
5622         * symtab.h (SYMBOL_SET_NAMES): Update.
5623         (symbol_set_names): Update.
5624         (MSYMBOL_SET_NAMES): Update.
5625         * symtab.c (symbol_set_names): Change argument to be an
5626         objfile_per_bfd_storage.
5627         * psymtab.c (add_psymbol_to_bcache): Update.
5628         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5629
5630 2019-01-10  Tom Tromey  <tom@tromey.com>
5631
5632         * symtab.c (create_demangled_names_hash): Change argument to be an
5633         objfile_per_bfd_storage.
5634         (symbol_set_names): Update.
5635
5636 2019-01-10  Tom Tromey  <tom@tromey.com>
5637
5638         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5639         init_psymbol_list.
5640         * psymtab.c (init_psymbol_list): Do nothing if already called.
5641         * psympriv.h (init_psymbol_list): Add comment.
5642         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5643         init_psymbol_list.
5644         * dbxread.c (dbx_symfile_read): Unconditionally call
5645         init_psymbol_list.
5646
5647 2019-01-10  Tom Tromey  <tom@tromey.com>
5648
5649         * xcoffread.c (scan_xcoff_symtab): Update.
5650         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5651         "where".
5652         * mdebugread.c (parse_partial_symbols)
5653         (handle_psymbol_enumerators): Update.
5654         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5655         * dbxread.c (read_dbx_symtab): Update.
5656         * psympriv.h (psymbol_placement): New enum.
5657         (add_psymbol_to_list): Update.
5658
5659 2019-01-10  Tom Tromey  <tom@tromey.com>
5660
5661         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5662         static_psymbols parameters.
5663         (scan_xcoff_symtab): Update.
5664         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5665         static_psymbols parameters.
5666         * psympriv.h (start_psymtab_common): Update.
5667         * mdebugread.c (parse_partial_symbols): Update.
5668         * dwarf2read.c (create_partial_symtab): Update.
5669         * dbxread.c (read_dbx_symtab): Update.
5670         (start_psymtab): Remove global_psymbols and static_psymbols
5671         parameters.
5672
5673 2019-01-10  Tom Tromey  <tom@tromey.com>
5674
5675         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5676         * psymtab.c (allocate_psymtab): Add comment.
5677         * psympriv.h (allocate_psymtab): Add comment.
5678         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5679         initializations.
5680         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5681
5682 2019-01-10  Tom Tromey  <tom@tromey.com>
5683
5684         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5685         Don't declare.
5686         * mipsread.c: Include mdebugread.h.
5687         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5688         Declare.
5689         * elfread.c: Include mdebugread.h.
5690
5691 2019-01-09  Tom Tromey  <tom@tromey.com>
5692
5693         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5694         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5695         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5696         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5697         (psym_lookup_symbol, psym_find_last_source_symtab)
5698         (psym_forget_cached_source_info, psym_print_stats)
5699         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5700         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5701         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5702         (psym_find_compunit_symtab_by_address)
5703         (maintenance_print_psymbols, maintenance_info_psymtabs)
5704         (maintenance_check_psymtabs): Use ranged for.
5705         * psymtab.h (class objfile_psymtabs): New.
5706         (require_partial_symbols): Return objfile_psymtabs.
5707         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5708
5709 2019-01-09  Tom Tromey  <tom@tromey.com>
5710
5711         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5712         (find_pc_mapped_section, list_overlays_command)
5713         (map_overlay_command, unmap_overlay_command)
5714         (simple_overlay_update): Use all_objfiles.
5715         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5716         * printcmd.c (info_symbol_command): Use all_objfiles.
5717         * objfiles.h (ALL_OBJSECTIONS): Remove.
5718         * maint.c (maintenance_translate_address): Use all_objfiles.
5719         * gcore.c (gcore_create_callback): Use all_objfiles.
5720         (objfile_find_memory_regions): Likewise.
5721
5722 2019-01-09  Tom Tromey  <tom@tromey.com>
5723
5724         * symtab.c (find_line_symtab, info_sources_command)
5725         (make_source_files_completion_list): Use objfile_compunits.
5726         * source.c (select_source_symtab): Use objfile_compunits.
5727         * objfiles.h (struct objfile): Update comment.
5728         (ALL_OBJFILES): Remove.
5729         (ALL_FILETABS): Remove.
5730         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5731         objfile_compunits.
5732
5733 2019-01-09  Tom Tromey  <tom@tromey.com>
5734
5735         * symmisc.c (print_objfile_statistics, dump_objfile)
5736         (maintenance_print_symbols): Use compunit_filetabs.
5737         * source.c (forget_cached_source_info_for_objfile): Use
5738         compunit_filetabs.
5739         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5740         (ALL_FILETABS): Use compunit_filetabs.
5741         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5742         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5743
5744 2019-01-09  Tom Tromey  <tom@tromey.com>
5745
5746         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5747         (compunit_filetabs): New.
5748         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5749         compunit_filetabs.
5750         (info_sources_command, make_source_files_completion_list): Remove
5751         declaration.
5752         * symmisc.c (print_objfile_statistics, dump_objfile)
5753         (maintenance_print_symbols): Remove declaration.
5754         (maintenance_info_symtabs): Use compunit_filetabs.
5755         (maintenance_info_line_tables): Likewise.
5756         * source.c (select_source_symtab): Change local variable name.
5757         (forget_cached_source_info_for_objfile): Remove declaration.
5758         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5759         * objfiles.c (objfile_relocate1): Remove declaration.
5760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5761         declaration.
5762         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5763         * coffread.c (coff_symtab_read): Remove declaration.
5764         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5765         compunit_filetabs.
5766
5767 2019-01-09  Tom Tromey  <tom@tromey.com>
5768
5769         * symtab.c (lookup_objfile_from_block)
5770         (find_pc_sect_compunit_symtab, search_symbols)
5771         (default_collect_symbol_completion_matches_break_on): Use
5772         objfile_compunits.
5773         * objfiles.h (ALL_COMPUNITS): Remove.
5774         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5775         * cp-support.c (add_symbol_overload_list_qualified): Use
5776         objfile_compunits.
5777         * ada-lang.c (ada_collect_symbol_completion_matches)
5778         (ada_add_global_exceptions): Use objfile_compunits.
5779
5780 2019-01-09  Tom Tromey  <tom@tromey.com>
5781
5782         * source.c (select_source_symtab)
5783         (forget_cached_source_info_for_objfile): Remove declaration.
5784         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5785         declaration.
5786         * maint.c (count_symtabs_and_blocks): Remove declaration.
5787         * cp-support.c (add_symbol_overload_list_qualified): Remove
5788         declaration.
5789         * coffread.c (coff_symtab_read): Remove declaration.
5790         * symtab.c (lookup_symbol_in_objfile_symtabs)
5791         (basic_lookup_transparent_type_1): Use objfile_compunits.
5792         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5793         (info_sources_command, search_symbols)
5794         (default_collect_symbol_completion_matches_break_on)
5795         (make_source_files_completion_list): Remove declaration.
5796         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5797         (ada_collect_symbol_completion_matches)
5798         (ada_add_global_exceptions): Remove declaration.
5799         * linespec.c (iterate_over_all_matching_symtabs): Use
5800         objfile_compunits.
5801         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5802         (class objfile_compunits): New.
5803         (ALL_COMPUNITS): Use objfile_compunits.
5804         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5805         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5806         objfile_compunits.
5807         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5808
5809 2019-01-09  Tom Tromey  <tom@tromey.com>
5810
5811         * symtab.c (search_symbols)
5812         (default_collect_symbol_completion_matches_break_on): Use
5813         objfile_msymbols.
5814         * ada-lang.c (ada_lookup_simple_minsym)
5815         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5816         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5818         objfile_msymbols.
5819         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5820         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5821         * objc-lang.c (find_methods): Use objfile_msymbols.
5822         (info_selectors_command, info_classes_command): Likewise.
5823         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5824         * objfiles.h (class objfile_msymbols): New.
5825         (ALL_OBJFILE_MSYMBOLS): Remove.
5826         (ALL_MSYMBOLS): Remove.
5827
5828 2019-01-09  Tom Tromey  <tom@tromey.com>
5829
5830         * common/next-iterator.h (next_adapter): Add Iterator template
5831         parameter.
5832         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5833         (class all_objfiles_safe): New.
5834         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5835         * objfiles.c (put_objfile_before): Update comment.
5836         (add_separate_debug_objfile): Likewise.
5837         (free_all_objfiles): Use all_objfiles_safe.
5838         (objfile_purge_solibs): Likewise.
5839
5840 2019-01-09  Tom Tromey  <tom@tromey.com>
5841
5842         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5843         (expand_symtab_containing_pc, lookup_static_symbol)
5844         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5845         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5846         all_objfiles.
5847         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5848         * breakpoint.c (create_overlay_event_breakpoint)
5849         (create_longjmp_master_breakpoint)
5850         (create_std_terminate_master_breakpoint)
5851         (create_exception_master_breakpoint): Use all_objfiles.
5852         * linux-thread-db.c (try_thread_db_load_from_pdir)
5853         (has_libpthread): Use all_objfiles.
5854         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5855         * linespec.c (iterate_over_all_matching_symtabs)
5856         (search_minsyms_for_name): Use all_objfiles.
5857         * maint.c (maintenance_info_sections): Use all_objfiles.
5858         * main.c (captured_main_1): Use all_objfiles.
5859         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5860         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5861         * guile/scm-pretty-print.c
5862         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5863         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5864         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5865         (maintenance_print_msymbols): Use all_objfiles.
5866         * source.c (select_source_symtab): Use all_objfiles.
5867         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5868         * symfile.c (remove_symbol_file_command)
5869         (expand_symtabs_matching, map_symbol_filenames): Use
5870         all_objfiles.
5871         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5872         all_objfiles.
5873         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5874         * objc-lang.c (find_methods): Use all_objfiles.
5875         * objfiles.c (have_partial_symbols, have_full_symbols)
5876         (have_minimal_symbols, qsort_cmp)
5877         (default_iterate_over_objfiles_in_search_order): Use
5878         all_objfiles.
5879         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5880         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5881         (maintenance_check_psymtabs): Use all_objfiles.
5882         (ALL_PSYMTABS): Remove.
5883         * compile/compile-object-run.c (do_module_cleanup): Use
5884         all_objfiles.
5885         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5886         * cp-support.c (add_symbol_overload_list_qualified): Use
5887         all_objfiles.
5888         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5889         Use all_objfiles.
5890         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5891         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5892         all_objfiles.
5893         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5894         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5895         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5896         Uses all_objfiles.
5897         * solib.c (solib_read_symbols): Use all_objfiles
5898
5899 2019-01-09  Tom Tromey  <tom@tromey.com>
5900
5901         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5902         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5903         all_objfiles.
5904         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5905         * symmisc.c (print_symbol_bcache_statistics)
5906         (print_objfile_statistics, maintenance_print_objfiles)
5907         (maintenance_info_symtabs, maintenance_check_symtabs)
5908         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5909         all_objfiles.
5910         * source.c (forget_cached_source_info): Use all_objfiles.
5911         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5912         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5913         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5914         * objfiles.c (update_section_map): Use all_objfiles.
5915         (shared_objfile_contains_address_p): Likewise.
5916         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5917         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5918
5919 2019-01-09  Tom Tromey  <tom@tromey.com>
5920
5921         * common/next-iterator.h: New file.
5922         * objfiles.h (class all_objfiles): New.
5923         (struct objfile_iterator): New.
5924
5925 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5926
5927         * NEWS: Move the description of the changed "frame", "select-frame",
5928          and "info frame" commands to the Changed commands section.
5929
5930 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5931
5932         * gdbtypes.c (check_stub_method_group): Remove handling of old
5933         mangling schemes.
5934         * linespec.c (find_methods): Likewise.
5935         * stabsread.c (read_member_functions): Likewise.
5936         * valops.c (search_struct_method): Likewise.
5937         (value_struct_elt_for_reference): Likewise.
5938         * NEWS: Mention this change.
5939
5940 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5943         print_source_lines.
5944         * source.c (print_source_lines_base): Update line number check.
5945         (print_source_lines): New function.
5946         (source_lines_range::source_lines_range): New function.
5947         * source.h (class source_lines_range): New class.
5948         (print_source_lines): New declaration.
5949
5950 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5951
5952         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5953
5954 2019-01-08  Tom Tromey  <tom@tromey.com>
5955             Simon Marchi  <simon.marchi@ericsson.com>
5956
5957         PR gdb/24060
5958         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5959         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5960         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5961         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5962         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5963         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5964
5965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * source.c (select_source_symtab): Move header comment to
5968         declaration in source.h.
5969         (forget_cached_source_info_for_objfile): Likewise.
5970         (forget_cached_source_info): Likewise.
5971         (identify_source_line): Likewise.
5972         * source.h (identify_source_line): Move declaration from symtab.h
5973         and add comment from source.c
5974         (print_source_lines): Likewise.
5975         (forget_cached_source_info_for_objfile): Likewise.
5976         (forget_cached_source_info): Likewise.
5977         (select_source_symtab): Likewise.
5978         (enum print_source_lines_flag): Move definition from symtab.h.
5979         * symtab.h (identify_source_line): Move declaration to source.h.
5980         (print_source_lines): Likewise.
5981         (forget_cached_source_info_for_objfile): Likewise.
5982         (forget_cached_source_info): Likewise.
5983         (select_source_symtab): Likewise.
5984         (enum print_source_lines_flag): Move definition to source.h.
5985         * tui/tui-hooks.c: Add 'source.h' include.
5986
5987 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * source.c (print_source_lines_base): Handle requests to print
5990         reverse line number sequences, and guard against empty lines
5991         string.
5992
5993 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * source.c (print_source_lines_base): Fix skip of '\r' if next
5996         character is '\n'.
5997
5998 2019-01-06  Tom Tromey  <tom@tromey.com>
5999
6000         * c-exp.y (struct c_parse_state) <macro_original_text,
6001         expansion_obstack>: New member.
6002         (macro_original_text, expansion_obstack): Remove globals.
6003         (scan_macro_expansion, scanning_macro_expansion)
6004         (finished_macro_expansion): Update.
6005         (scan_macro_cleanup): Remove.
6006         (yylex, c_parse): Update.
6007
6008 2019-01-06  Tom Tromey  <tom@tromey.com>
6009
6010         * c-exp.y (struct c_parse_state) <strings>: New member.
6011         (operator_stoken): Update.
6012
6013 2019-01-06  Tom Tromey  <tom@tromey.com>
6014
6015         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6016         (union type_stack_elt) <typelist_val>: Now a pointer to
6017         std::vector.
6018         (type_stack_cleanup): Don't declare.
6019         (push_typelist): Update.
6020         * parse.c (pop_typelist): Return a std::vector.
6021         (push_typelist): Take a std::vector.
6022         (follow_types): Update.  Do not free args.
6023         (type_stack_cleanup): Remove.
6024         * c-exp.y (struct c_parse_state): New.
6025         (cpstate): New global.
6026         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6027         (nonempty_typelist): Update.
6028         (func_mod): Create a new vector.
6029         (c_parse): Create a c_parse_state.
6030         (check_parameter_typelist): Do not delete params.
6031         (function_method): Update.  Do not delete type_list.
6032
6033 2019-01-06  Tom Tromey  <tom@tromey.com>
6034
6035         PR gdb/28155:
6036         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6037         check_typedef.
6038         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6039         (print_return_value): Likewise.
6040
6041 2019-01-05  Tom Tromey  <tom@tromey.com>
6042
6043         * contrib/cleanup_check.py: Remove.
6044         * contrib/gcc-with-excheck: Remove.
6045         * contrib/exsummary.py: Remove.
6046         * contrib/excheck.py: Remove.
6047
6048 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6049
6050         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6051         NULL. Initialize tpprev to NULL instead of assigning it
6052         to NULL on the next statement.
6053         * windows-nat.c (windows_delete_thread): Remove check for
6054         main_thread_id before printing thread exit notifications.
6055         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6056         Remove thread ID check against main_thread_id.
6057         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6058         windows_delete_thread.
6059         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6060
6061 2019-01-04  Tom Tromey  <tom@tromey.com>
6062
6063         * compile/compile.c (_initialize_compile): Use upper case for
6064         metasyntactic variables.
6065         * symmisc.c (_initialize_symmisc): Use upper case for
6066         metasyntactic variables.
6067         * psymtab.c (_initialize_psymtab): Use upper case for
6068         metasyntactic variables.
6069         * demangle.c (demangle_command): Use upper case for metasyntactic
6070         variables.
6071         (_initialize_demangler): Likewise.
6072         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6073         variables.
6074
6075 2019-01-03  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6078
6079 2019-01-03  Tom Tromey  <tom@tromey.com>
6080
6081         * python/py-symtab.c (salpy_str): Update.
6082         (struct salpy_sal_object) <symtab>: Now a PyObject.
6083         (salpy_dealloc): Update.
6084         (del_objfile_sal): Use gdbpy_ref.
6085
6086 2019-01-03  Tom Tromey  <tom@tromey.com>
6087
6088         * python/py-type.c (convert_field): Use new_reference.  Return
6089         gdbpy_ref.
6090         (make_fielditem): Return gdbpy_ref.
6091         (typy_fields): Update.
6092         (typy_getitem): Update.
6093         (field_name): Return gdbpy_ref.  Use new_reference.
6094         (typy_iterator_iternext): Update.
6095
6096 2019-01-03  Tom Tromey  <tom@tromey.com>
6097
6098         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6099
6100 2019-01-03  Tom Tromey  <tom@tromey.com>
6101
6102         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6103         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6104         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6105         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6106         (pspy_set_type_printers): Likewise.
6107         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6108         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6109         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6110         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6111         (objfpy_set_type_printers): Likewise.
6112
6113 2019-01-03  Tom Tromey  <tom@tromey.com>
6114
6115         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6116         (gdbpy_print_stack): Use gdbpy_err_fetch.
6117         * python/python-internal.h (class gdbpy_err_fetch): New class.
6118         (class gdbpy_enter) <m_error_type, m_error_value,
6119         m_error_traceback>: Remove.
6120         <m_error>: New member.
6121         (gdbpy_exception_to_string): Don't declare.
6122         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6123         * python/py-value.c (convert_value_from_python): Use
6124         gdbpy_err_fetch.
6125         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6126         gdbpy_exception_to_string.
6127         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6128         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6129         gdbpy_err_fetch.
6130
6131 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         * linux-nat.c (delete_lwp_cleanup): Delete.
6134         (struct lwp_deleter): New struct.
6135         (lwp_info_up): New typedef.
6136         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6137         lwp_info_up.
6138
6139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * linux-fork.c (class scoped_switch_fork_info): New class.
6142         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6143
6144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6145
6146         * valops.c (find_overload_match): Remove use of null_cleanup, and
6147         calls to do_cleanups.
6148
6149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6150
6151         * compile/compile-cplus-types.c
6152         (compile_cplus_instance::decl_name): Handle changes to
6153         cp_func_name.
6154         * cp-support.c (cp_func_name): Update header comment, update
6155         return type.
6156         * cp-support.h (cp_func_name): Update return type in declaration.
6157         * valops.c (find_overload_match): Move temp_func local to top
6158         level of function and change its type.  Use temp_func to hold and
6159         delete temporary string obtained from cp_func_name.
6160
6161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6164         gdb::char_vector, remove cleanup, and update uses of `msg`.
6165
6166 2019-01-03  Jim Wilson  <jimw@sifive.com>
6167
6168         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6169
6170 2019-01-02  Tom Tromey  <tom@tromey.com>
6171
6172         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6173         (tdesc_parse_xml): Remove cleanups.
6174         * target-descriptions.h (make_cleanup_free_target_description):
6175         Don't declare.
6176         (target_desc_deleter): New struct.
6177         (target_desc_up): New typedef.
6178         * target-descriptions.c (target_desc_deleter::operator()): Rename
6179         from free_target_description.
6180         (make_cleanup_free_target_description): Remove.
6181
6182 2019-01-02  Tom Tromey  <tom@tromey.com>
6183
6184         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6185         constructor, destructor.
6186         (linespec_parser): Remove typedef.
6187         (~linespec_parser): Rename from linespec_parser_delete.
6188         (linespec_lex_to_end, linespec_complete_label)
6189         (linespec_complete): Update.
6190         (decode_line_full): Remove cleanups.
6191         (decode_line_1): Update.
6192
6193 2019-01-02  Tom Tromey  <tom@tromey.com>
6194
6195         * python/python-internal.h (inferior_to_inferior_object): Change
6196         return type.
6197         * python/py-exitedevent.c (create_exited_event_object): Update.
6198         * python/py-inferior.c (inferior_to_inferior_object): Return
6199         gdbpy_ref.
6200         (python_new_inferior, python_inferior_deleted)
6201         (thread_to_thread_object, delete_thread_object)
6202         (build_inferior_list, gdbpy_selected_inferior): Update.
6203         * python/py-infthread.c (create_thread_object): Update.  Also fail
6204         if inferior_to_inferior_object fails.
6205
6206 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6207
6208         * inferior.h (class inferior) <displaced_step_state>: New field.
6209         * infrun.h (struct displaced_step_state): Move here from
6210         infrun.c.  Initialize fields, add constructor.
6211         <inf>: Remove field.
6212         <reset>: New method.
6213         * infrun.c (struct displaced_step_inferior_state): Move to
6214         infrun.h.
6215         (displaced_step_inferior_states): Remove.
6216         (get_displaced_stepping_state): Adust.
6217         (displaced_step_in_progress_any_inferior): Adjust.
6218         (displaced_step_in_progress_thread): Adjust.
6219         (displaced_step_in_progress): Adjust.
6220         (add_displaced_stepping_state): Remove.
6221         (get_displaced_step_closure_by_addr): Adjust.
6222         (remove_displaced_stepping_state): Remove.
6223         (infrun_inferior_exit): Call displaced_step_state.reset.
6224         (use_displaced_stepping): Don't check for NULL.
6225         (displaced_step_prepare_throw): Call
6226         get_displaced_stepping_state.
6227         (displaced_step_fixup): Don't check for NULL.
6228         (prepare_for_detach): Don't check for NULL.
6229
6230 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6231
6232         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6233          in case of call that did not complete.
6234
6235 2019-01-02  Andrey Utkin  <autkin@undo.io>
6236
6237         * symfile.c (find_separate_debug_file): Fix search of debug files for
6238         remote debuggee.
6239
6240 2019-01-02  Tom Tromey  <tom@tromey.com>
6241
6242         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6243         indentation.
6244         * python/py-frame.c (frapy_older): Remove cast.
6245         (frapy_newer): Likewise.
6246         * python/py-breakpoint.c (local_setattro): Remove cast.
6247         * python/py-arch.c (archpy_name): Remove local variable.
6248         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6249
6250 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6251
6252         * unittests/basic_string_view/element_access/char/empty.cc:
6253         Fix year range in copyright header.
6254
6255 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6258         Delete.
6259         <operator==>: Update with for removed field.
6260         <hash>: Likewise.
6261         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6262         <isa_features>: ...this.
6263         <abi_features>: New field.
6264         (riscv_isa_flen): Update comment.
6265         (riscv_abi_xlen): New declaration.
6266         (riscv_abi_flen): New declaration.
6267         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6268         isa_features.
6269         (riscv_abi_xlen): New function.
6270         (riscv_isa_flen): Update to get answer from isa_features.
6271         (riscv_abi_flen): New function.
6272         (riscv_has_fp_abi): Update to get answer from abi_features.
6273         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6274         xlen and flen.
6275         (riscv_call_info) <xlen, flen>: Update comment.
6276         (riscv_call_arg_struct): Remove invalid assertions
6277         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6278         is removed.
6279         (riscv_gdbarch_init): Gather isa features and abi features
6280         separately, ensure both match on the gdbarch when reusing an old
6281         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6282         a target with 64-bit float hardware.
6283
6284 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * source.c (search_command_helper): Stop reverse search
6287         when line 1 has been searched.
6288
6289 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6290
6291         * record-full.c (record_full_base_target::close): Rewrite
6292         record_full_core_buf_list free logic.
6293
6294 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6295
6296         * break-catch-syscall.c (print_one_catch_syscall): xfree
6297         the last text.
6298
6299 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6300
6301         * top.c (print_gdb_version): Update Copyright year in version
6302         message.
6303
6304 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6305
6306         Update copyright year range in all GDB files.
6307
6308 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6309
6310         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6311
6312 For older changes see ChangeLog-2018.
6313 \f
6314 Local Variables:
6315 mode: change-log
6316 left-margin: 8
6317 fill-column: 74
6318 version-control: never
6319 coding: utf-8
6320 End:
6321