gdb/ChangeLog

   1 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
   2             Tom Tromey  <tom@tromey.com>
   3
   4         * dictionary.c (collate_pending_symbols_by_language): Remove
   5         "struct" from foreach.
   6         * symtab.c (lookup_global_symbol_from_objfile)
   7         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
   8         foreach.
   9         * ser-tcp.c (net_open): Remove "struct" from foreach.
  10         * objfiles.c (objfile_relocate, objfile_rebase)
  11         (objfile_has_symbols): Remove "struct" from foreach.
  12         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  13         from foreach.
  14         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  15         foreach.
  16         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  17         "struct" from foreach.
  18         * ada-lang.c (create_excep_cond_exprs)
  19         (ada_exception_catchpoint_cond_string): Remove "struct" from
  20         foreach.
  21
  22 2019-05-03  Tom Tromey  <tromey@adacore.com>
  23
  24         * ada-exp.y (convert_char_literal): Check suffix of each
  25         enumerator.
  26
  27 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  28
  29         PR ada/21406:
  30         * ada-exp.y (yywrap): Don't define.
  31         * ada-lex.l (%option): Add noyywrap
  32         (yywrap): Remove.
  33
  34 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  35
  36         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  37         _WIN32_WINNT to the XP level, unless already defined to a higher
  38         level.
  39
  40         * unittests/parse-connection-spec-selftests.c:
  41         * ser-tcp.c:
  42         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  43         override.
  44
  45         * symfile.c (find_separate_debug_file): Remove colon from the
  46         drive spec of DOS/Windows file names of the target, so that the
  47         file name produced from DEBUGDIR and the target's directory will
  48         be valid on DOS/Windows systems.
  49
  50 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * rust-lang.c (val_print_struct): Handle printing structures
  53         containing strings.
  54
  55 2019-05-02  Tom Tromey  <tromey@adacore.com>
  56
  57         * valarith.c (_initialize_valarith): Remove.
  58
  59 2019-05-01  Tom Tromey  <tromey@adacore.com>
  60
  61         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  62         bitfields.
  63
  64 2019-05-01  Tom Tromey  <tromey@adacore.com>
  65
  66         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  67         for big-endian copies.
  68
  69 2019-04-30  Ali Tamur  <tamur@google.com>
  70         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  71         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  72         (read_3_bytes): New function.
  73
  74 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  75
  76         * windows-nat.c (main_thread_id): Delete.
  77         (handle_output_debug_string): Replace main_thread_id by
  78         current_event.dwThreadId.
  79         (fake_create_process): Likewise.
  80         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  81         Do not set main_thread_id.
  82         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  83         current_event.dwThreadId.
  84         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  85
  86 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  87
  88         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  89         Use current_event.dwThreadId instead of main_thread_id.
  90
  91 2019-04-30  Tom Tromey  <tromey@adacore.com>
  92
  93         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  94         (create_excep_cond_exprs): Iterate over program spaces.
  95         (ada_exception_catchpoint_cond_string): Examine all minimal
  96         symbols for exception types.
  97
  98 2019-04-30  Tom Tromey  <tromey@adacore.com>
  99
 100         PR c++/24470:
 101         * dwarf2read.c (process_structure_scope): Handle case where type
 102         has template parameters but no symbol was created.
 103
 104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 105             Chris January  <chris.january@arm.com>
 106
 107         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 108         qualifier.
 109         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 110
 111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * f-typeprint.c (f_print_type): Update rules for printing
 114         whitespace.
 115         (f_type_print_varspec_suffix): Likewise.
 116
 117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 118             Chris January  <chris.january@arm.com>
 119
 120         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 121         function arguments.
 122
 123 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * f-lang.c (build_fortran_types): Change name of void type to
 126         lower case.
 127         * f-typeprint.c (f_type_print_base): Print the name of the void
 128         type, rather than a fixed string.
 129         * f-valprint.c (f_decorations): Use lower case void string.
 130
 131 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 132             Chris January  <chris.january@arm.com>
 133
 134         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 135         types for Fortran.
 136
 137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 138             Chris January  <chris.january@arm.com>
 139             David Lecomber  <david.lecomber@arm.com>
 140
 141         * f-exp.y (BINOP_INTRINSIC): New token.
 142         (exp): New parser rule handling BINOP_INTRINSIC.
 143         (f77_keywords): Add new builtin procedures.
 144         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 145         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 146         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 147         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 148         (print_unop_subexp_f): New function.
 149         (print_binop_subexp_f): New function.
 150         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 151         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 152         (dump_subexp_body_f): Likewise.
 153         (operator_check_f): Likewise.
 154         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 155         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 156
 157 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 160         UNOP_KIND.
 161         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 162         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 163         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 164         (operator_length_f): New fuction.
 165         (print_subexp_f): New function.
 166         (op_name_f): New function.
 167         (dump_subexp_body_f): New function.
 168         (operator_check_f): New function.
 169         (exp_descriptor_f): Replace standard expression handling functions
 170         with new functions.
 171         * gdb/fortran-operator.def: New file.
 172         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 173         * gdb/std-operator.def: Remove UNOP_KIND.
 174
 175 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * std-operator.def: Remove unbalanced, stray double quote
 178         character.
 179
 180 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 181             Chris January  <chris.january@arm.com>
 182             Daniel Everett  <daniel.everett@arm.com>
 183             Nick Forrington  <nick.forrington@arm.com>
 184             Richard Bunt  <richard.bunt@arm.com>
 185
 186         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 187         of depth when printing anonymous structs or unions.
 188         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 189         Don't print either the top-level value, or the children if the
 190         max-depth is exceeded.
 191         (ppscm_print_children): When printing the key of a map, allow one
 192         extra level of depth.
 193         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 194         print either the top-level value, or the children if the max-depth
 195         is exceeded.
 196         (print_children): When printing the key of a map, allow one extra
 197         level of depth.
 198         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 199         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 200         (user_print_options): Initialise max_depth field.
 201         (val_print_scalar_or_string_type_p): New function.
 202         (val_print): Check to see if the max depth has been reached.
 203         (val_print_check_max_depth): Define new function.
 204         (show_print_max_depth): New function.
 205         (_initialize_valprint): Add 'print max-depth' option.
 206         * valprint.h (struct value_print_options) <max_depth>: New field.
 207         (val_print_check_max_depth): Declare new function.
 208         * NEWS: Document new feature.
 209
 210 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * ada-lang.c (ada_language_defn): Initialise new field.
 213         * c-lang.c (c_is_string_type_p): New function.
 214         (c_language_defn): Initialise new field.
 215         (cplus_language_defn): Initialise new field.
 216         (asm_language_defn): Initialise new field.
 217         (minimal_language_defn): Initialise new field.
 218         * c-lang.h (c_is_string_type_p): Declare new function.
 219         * d-lang.c (d_language_defn): Initialise new field.
 220         * f-lang.c (f_is_string_type_p): New function.
 221         (f_language_defn): Initialise new field.
 222         * go-lang.c (go_is_string_type_p): New function.
 223         (go_language_defn): Initialise new field.
 224         * language.c (default_is_string_type_p): New function.
 225         (unknown_language_defn): Initialise new field.
 226         (auto_language_defn): Initialise new field.
 227         * language.h (struct language_defn) <la_is_string_type_p>: New
 228         member variable.
 229         (default_is_string_type_p): Declare new function.
 230         * m2-lang.c (m2_language_defn): Initialise new field.
 231         * objc-lang.c (objc_language_defn): Initialise new field.
 232         * opencl-lang.c (opencl_language_defn): Initialise new field.
 233         * p-lang.c (pascal_is_string_type_p): New function.
 234         (pascal_language_defn): Initialise new field.
 235         * rust-lang.c (rust_is_string_type_p): New function.
 236         (rust_language_defn): Initialise new field.
 237
 238 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 241         New field.
 242         * ada-lang.c (ada_language_defn): Initialise new field.
 243         * c-lang.c (c_language_defn): Likewise.
 244         (cplus_language_defn): Likewise.
 245         (asm_language_defn): Likewise.
 246         (minimal_language_defn): Likewise.
 247         * d-lang.c (d_language_defn): Likewise.
 248         * f-lang.c (f_language_defn): Likewise.
 249         * go-lang.c (go_language_defn): Likewise.
 250         * language.c (unknown_language_defn): Likewise.
 251         (auto_language_defn): Likewise.
 252         * m2-lang.c (m2_language_defn): Likewise.
 253         * objc-lang.c (objc_language_defn): Likewise.
 254         * opencl-lang.c (opencl_language_defn): Likewise.
 255         * p-lang.c (pascal_language_defn): Likewise.
 256         * rust-lang.c (rust_language_defn): Likewise.
 257
 258 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 259
 260         * ada-lang.c (ada_is_character_type): Change return type to bool.
 261         (ada_is_string_type): Likewise.
 262         * ada-lang.h (ada_is_character_type): Update declaration
 263         (ada_is_string_type): Likewise.
 264
 265 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         Support style in 'frame|thread apply'
 268
 269         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 270         * record.c (record_start, record_stop): Update callers of
 271         execute_command_to_string with false.
 272         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 273         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 274         methods.
 275         (class string_file): New constructor with term_out parameter.
 276         Override methods term_out and can_emit_style_escape.  New member
 277         term_out.
 278         (class stdio_file): Override can_emit_style_escape.
 279         (class tee_file): Override term_out and can_emit_style_escape.
 280         * utils.h (can_emit_style_escape): Remove.
 281         * utils.c (can_emit_style_escape): Likewise.
 282         Update all callers of can_emit_style_escape (SOMESTREAM) to
 283         SOMESTREAM->can_emit_style_escape.
 284         * source-cache.c (source_cache::get_source_lines): Likewise.
 285         * stack.c (frame_apply_command_count): Call execute_command_to_string
 286         passing the term_out characteristic of the current gdb_stdout.
 287         * thread.c (thr_try_catch_cmd): Likewise.
 288         * top.c (execute_command_to_string): pass term_out parameter
 289         to construct the string_file for the command output.
 290         * ui-file.c (term_cli_styling): New function (most code moved
 291         from utils.c can_emit_style_escape).
 292         (string_file::string_file, string_file::can_emit_style_escape,
 293         stdio_file::can_emit_style_escape, tee_file::term_out,
 294         tee_file::can_emit_style_escape): New functions.
 295
 296 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 297
 298         * NEWS: Mention the new set|show may-call-functions.
 299         * infcall.c (may_call_functions_p): New variable.
 300         (show_may_call_functions_p): New function.
 301         (call_function_by_hand_dummy): Throws an error if not
 302         may-call-functions.
 303         (_initialize_infcall): Call add_setshow_boolean_cmd for
 304         may-call-functions.
 305
 306 2019-04-25  Keith Seitz  <keiths@redhat.com>
 307
 308         PR c++/24367
 309         * cp-support.c (inspect_type): Don't attempt substitutions
 310         of symbol with the same name.
 311
 312 2019-04-25  Tom Tromey  <tromey@adacore.com>
 313
 314         PR gdb/24475:
 315         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 316         static.
 317
 318 2019-04-25  Tom Tromey  <tromey@adacore.com>
 319
 320         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 321         rvalue reference.
 322         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 323         (gdb_xml_parser::parse): Use std::move.
 324         * python/python-internal.h (gdbpy_convert_exception): Take a const
 325         reference.
 326         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 327         std::move.
 328         * python/py-utils.c (gdbpy_convert_exception): Take a const
 329         reference.
 330         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 331         Use std::move.
 332         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 333         Use std::move.
 334         * mi/mi-main.c (mi_print_exception): Take a const reference.
 335         * main.c (handle_command_errors): Take a const reference.
 336         * linespec.c (parse_linespec): Use std::move.
 337         * infcall.c (run_inferior_call): Use std::move.
 338         (call_function_by_hand_dummy): Use std::move.
 339         * exec.c (try_open_exec_file): Use std::move.
 340         * exceptions.h (exception_print, exception_fprintf)
 341         (exception_print_same): Update.
 342         * exceptions.c (print_exception, exception_print)
 343         (exception_fprintf, exception_print_same): Change parameters to
 344         const reference.
 345         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 346         * common/new-op.c: Use std::move.
 347         * common/common-exceptions.h (struct gdb_exception): Add move
 348         constructor.
 349         (struct gdb_exception_error, struct gdb_exception_quit, struct
 350         gdb_quit_bad_alloc): Change constructor to move constructor.
 351         (throw_exception): Change parameter to rvalue reference.
 352         * common/common-exceptions.c (throw_exception): Take rvalue
 353         reference.
 354         * cli/cli-interp.c (safe_execute_command): Use std::move.
 355         * breakpoint.c (insert_bp_location, location_to_sals): Use
 356         std::move.
 357
 358 2019-04-25  Tom Tromey  <tromey@adacore.com>
 359
 360         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 361         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 362         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 363         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 364         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 365         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 366         guile/scm-value.c: Use unpack.
 367         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 368         gdbscm_gdb_exception.
 369         (gdbscm_throw_gdb_exception): Likewise.
 370         (struct gdbscm_gdb_exception): New.
 371         (unpack): New function.
 372         (gdbscm_wrap): Use unpack.
 373
 374 2019-04-25  Tom Tromey  <tromey@adacore.com>
 375
 376         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 377         (gdb_rl_callback_handler): Use std::move.
 378         * common/common-exceptions.h (struct gdb_exception): Add move
 379         assignment operator.
 380         (throw_exception_sjlj): Change "exception" to const reference.
 381         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 382         (throw_exception_sjlj): Change "exception" to const reference.
 383
 384 2019-04-25  Tom Tromey  <tromey@adacore.com>
 385
 386         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 387         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 388         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 389         Update.
 390         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 391         Update.
 392         * mi/mi-interp.c (mi_interp::exec): Update.
 393         * linespec.c (parse_linespec): Update.
 394         * infcall.c (run_inferior_call): Update.
 395         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 396         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 397         (gdbscm_lookup_global_symbol): Update.
 398         * guile/scm-param.c (gdbscm_parameter_value): Update.
 399         * guile/scm-frame.c (gdbscm_frame_read_register)
 400         (gdbscm_frame_read_var): Update.
 401         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 402         * exec.c (try_open_exec_file): Update.
 403         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 404         (gdb_rl_callback_handler): Update.
 405         * common/common-exceptions.h (exception_none): Don't declare.
 406         * common/common-exceptions.c (exception_none): Don't define.
 407         (struct catcher) <exception>: Update.
 408         * cli/cli-interp.c (safe_execute_command): Update.
 409         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 410
 411 2019-04-25  Ali Tamur  <tamur@google.com>
 412
 413         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 414         (read_attribute_value): Likewise.
 415         (dwarf2_read_addr_index): Update comment.
 416         (read_str_index): Add DW_FORM_strx.
 417         (dwarf2_string_attr): Likewise.
 418         (dwarf2_const_value_attr): Likewise.
 419         (dump_die_shallow): Likewise.
 420         (dwarf2_fetch_constant_bytes): Likewise.
 421         (skip_form_bytes): Likewise.
 422         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 423
 424 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 425
 426         PR corefiles/11608
 427         PR corefiles/18187
 428         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 429         OFFSET.  Verify if current mapping contains an ELF header.
 430         (linux_find_memory_regions_full): Adjust call to
 431         dump_mapping_p.
 432
 433 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 434             Kang Li <kanglictf@gmail.com>
 435
 436         PR gdb/21600
 437
 438         * dwarf2-frame.c (read_initial_length): Be consistent about using
 439         unsigned representation of length.
 440         (decode_frame_entry_1): Likewise.  Check for wraparound of
 441         end pointer as well as buffer overflow.
 442
 443 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 444
 445         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 446         "vq".
 447
 448 2019-04-24  Tom Tromey  <tromey@adacore.com>
 449
 450         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 451
 452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * s12z-tdep.c (s12z_unwind_pc): Delete.
 455         (s12z_unwind_sp): Delete.
 456         (s12z_gdbarch_init): Don't register deleted functions with
 457         gdbarch.
 458
 459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * rl78-tdep.c (rl78_unwind_sp): Delete.
 462         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 463
 464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 467         (xstormy16_unwind_pc): Delete.
 468         (xstormy16_dummy_id): Delete.
 469         (xstormy16_gdbarch_init): Don't register deleted functions with
 470         gdbarch.
 471
 472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 473
 474         * vax-tdep.c (vax_unwind_pc): Delete.
 475         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 476
 477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 478
 479         * v850-tdep.c (v850_unwind_sp): Delete.
 480         (v850_unwind_pc): Delete.
 481         (v850_dummy_id): Delete.
 482         (v850_gdbarch_init): Don't register deleted functions with
 483         gdbarch.
 484
 485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 488         (tilegx_unwind_pc): Delete.
 489         (tilegx_unwind_dummy_id): Delete.
 490         (tilegx_gdbarch_init): Don't register deleted functions with
 491         gdbarch.
 492
 493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 496         (tic6x_dummy_id): Delete.
 497         (tic6x_gdbarch_init): Don't register deleted functions with
 498         gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * sparc-tdep.c (sparc_unwind_pc): Delete.
 503         (sparc32_gdbarch_init): Don't register deleted function with
 504         gdbarch.
 505
 506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * sh-tdep.c (sh_unwind_sp): Delete.
 509         (sh_unwind_pc): Delete.
 510         (sh_dummy_id): Delete.
 511         (sh_gdbarch_init): Don't register deleted functions with
 512         gdbarch.
 513
 514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 515
 516         * score-tdep.c (score_unwind_sp): Delete.
 517         (score_unwind_pc): Delete.
 518         (score_dummy_id): Delete.
 519         (score_gdbarch_init): Don't register deleted functions with
 520         gdbarch.
 521
 522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         * rx-tdep.c (rx_unwind_pc): Delete.
 525         (rx_unwind_sp): Delete.
 526         (rx_dummy_id): Delete.
 527         (rx_gdbarch_init): Don't register deleted functions with
 528         gdbarch.  Update comment.
 529
 530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 533         (rs6000_dummy_id): Delete.
 534         (rs6000_gdbarch_init): Don't register deleted functions with
 535         gdbarch.
 536
 537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * or1k-tdep.c (or1k_dummy_id): Delete.
 540         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 541
 542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * nios2-tdep.c (nios2_dummy_id): Delete.
 545         (nios2_unwind_sp): Delete.
 546         (nios2_gdbarch_init): Don't register deleted functions with
 547         gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * nds32-tdep.c (nds32_dummy_id): Delete.
 552         (nds32_unwind_pc): Delete.
 553         (nds32_unwind_sp): Delete.
 554         (nds32_gdbarch_init): Don't register deleted functions with
 555         gdbarch.
 556
 557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * msp430-tdep.c (msp430_unwind_pc): Delete.
 560         (msp430_unwind_sp): Delete.
 561         (msp430_dummy_id): Delete.
 562         (msp430_gdbarch_init): Don't register deleted functions with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * moxie-tdep.c (moxie_unwind_sp): Delete.
 568         (moxie_unwind_pc): Delete.
 569         (moxie_dummy_id): Delete.
 570         (moxie_gdbarch_init): Don't register deleted functions with
 571         gdbarch.
 572
 573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 576         (mn10300_unwind_pc): Delete.
 577         (mn10300_unwind_sp): Delete.
 578         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 579         mn10300_unwind_sp.
 580         (mn10300_frame_unwind_init): Don't register deleted functions with
 581         gdbarch.
 582
 583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * mep-tdep.c (mep_unwind_pc): Delete.
 586         (mep_unwind_sp): Delete.
 587         (mep_dummy_id): Delete.
 588         (mep_gdbarch_init): Don't register deleted functions with
 589         gdbarch.
 590
 591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 594         (m68hc11_unwind_sp): Delete.
 595         (m68hc11_gdbarch_init): Don't register deleted functions with
 596         gdbarch.
 597
 598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * m32r-tdep.c (m32r_unwind_sp): Delete.
 601         (m32r_unwind_pc): Delete.
 602         (m32r_dummy_id): Delete.
 603         (m32r_gdbarch_init): Don't register deleted functions with
 604         gdbarch.
 605
 606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * m32c-tdep.c (m32c_unwind_pc): Delete.
 609         (m32c_unwind_sp): Delete.
 610         (m32c_dummy_id): Delete.
 611         (m32c_gdbarch_init): Don't register deleted functions with
 612         gdbarch.
 613
 614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 617         (lm32_unwind_pc): Delete.
 618         (lm32_dummy_id): Delete.
 619         (lm32_gdbarch_init): Don't register deleted functions with
 620         gdbarch.
 621
 622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 623
 624         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 625         (iq2000_unwind_pc): Delete.
 626         (iq2000_dummy_id): Delete.
 627         (iq2000_gdbarch_init): Don't register deleted functions with
 628         gdbarch.
 629
 630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * nds32-tdep.c (nds32_type_align): Delete.
 633         (nds32_push_dummy_call): Use type_align instead.
 634
 635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * arm-tdep.c (arm_type_align): Only handle vector override case.
 638         (arm_push_dummy_call): Use type_align.
 639         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 640
 641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 644         case.
 645         (pass_on_stack): Use type_align.
 646         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 647         function.
 648
 649 2019-04-23  Tom Tromey  <tromey@adacore.com>
 650
 651         * dwarf2read.c (line_header::file_name_at): Remove unused
 652         overload.
 653
 654 2019-04-23  Tom de Vries  <tdevries@suse.de>
 655
 656         PR gdb/24438
 657         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 658         invocation.
 659
 660
 661 2019-03-27  Ali Tamur  <tamur@google.com>
 662
 663         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 664         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 665         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 666         (dwarf_expr_context::get_addr_index): Likewise
 667         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 668         (symbol_needs_eval_context::get_addr_index): Likewise
 669         (disassemble_dwarf_expression): Add DW_OP_addrx
 670         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 671         (read_cutu_die_from_dwo): Update comment
 672         (skip_one_die): Add DW_FORM_addrx
 673         (read_attribute_value): Likewise
 674         (var_decode_location): Add DW_OP_addrx
 675         (dwarf2_const_value_attr): Add DW_FORM_addrx
 676         (dump_die_shallow): Likewise
 677         (dwarf2_fetch_constant_bytes): Likewise
 678         (decode_locdesc): Add DW_OP_addrx
 679         (skip_form_bytes): Add DW_FORM_addrx
 680
 681 2019-04-22  Ali Tamur  <tamur@google.com>
 682
 683         * MAINTAINERS (Write After Approval): Add self.
 684
 685 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 686
 687         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 688         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 689         (open_symbol_file_object): Likewise.
 690         (svr4_default_sos): Add info parameter.
 691         (svr4_read_so_list): Likewise.
 692         (svr4_current_sos_direct): Adjust functions calls to pass down
 693         info.
 694         (svr4_current_sos_1): Add info parameter.
 695         (svr4_current_sos): Call get_svr4_info, pass info down to
 696         svr4_current_sos_1.
 697         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 698         get_svr4_info.
 699         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 700         get_svr4_info.
 701         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 702         to get_svr4_info.
 703         (probes_table_remove_objfile_probes): Likewise.
 704         (register_solib_event_probe): Add info parameter.
 705         (solist_update_incremental): Pass info parameter down to
 706         svr4_read_so_list.
 707         (disable_probes_interface): Add info parameter.
 708         (svr4_handle_solib_event): Pass current_program_space to
 709         get_svr4_info.  Adjust disable_probes_interface cleanup.
 710         (svr4_create_probe_breakpoints): Add info parameter, pass it
 711         down to register_solib_event_probe.
 712         (svr4_create_solib_event_breakpoints): Add info parameter,
 713         pass it down to svr4_create_probe_breakpoints.
 714         (enable_break): Pass info down to
 715         svr4_create_solib_event_breakpoints.
 716         (svr4_solib_create_inferior_hook): Pass current_program_space to
 717         get_svr4_info.
 718         (svr4_clear_solib): Likewise.
 719
 720 2019-04-22  Pedro Alves  <palves@redhat.com>
 721
 722         * solib-svr4.c (svr4_free_objfile_observer): New.
 723         (probe_and_action::objfile): New field.
 724         (probes_table_htab_remove_objfile_probes)
 725         (probes_table_remove_objfile_probes): New functions.
 726         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 727         in the new probe_and_action.  Don't store the probe in 'lookup'.
 728         (svr4_create_probe_breakpoints): Pass objfile to
 729         register_solib_event_probe.
 730         (_initialize_svr4_solib): Register a free_objfile observer.
 731
 732 2019-04-19  Tom Tromey  <tom@tromey.com>
 733
 734         * common/queue.h: Remove.
 735
 736 2019-04-19  Tom Tromey  <tom@tromey.com>
 737
 738         * event-loop.c: Don't include "common/queue.h".
 739
 740 2019-04-19  Tom Tromey  <tom@tromey.com>
 741
 742         * remote.c (remote_target): Use delete.
 743         * remote-notif.h: Include <list>, not "common/queue.h".
 744         (notif_client_p): Remove typedef.
 745         (remote_notif_state): Add constructor, destructor, initializer.
 746         <notif_queue>: Now a std::list.
 747         (remote_notif_state_xfree): Don't declare.
 748         * remote-notif.c (remote_notif_process, handle_notification)
 749         (remote_notif_state_allocate): Update.
 750         (~remote_notif_state): Rename from remote_notif_state_xfree.
 751
 752 2019-04-19  Tom Tromey  <tom@tromey.com>
 753
 754         * symfile.c (reread_symbols): Update.
 755         * objfiles.c (objfile_register_static_link)
 756         (objfile_lookup_static_link): Update
 757         (~objfile) Don't delete static_links.
 758         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 759
 760 2019-04-19  Tom Tromey  <tom@tromey.com>
 761
 762         * type-stack.h (struct type_stack) <insert>: Constify string.
 763         * type-stack.c (type_stack::insert): Constify string.
 764         * gdbtypes.h (lookup_template_type): Update.
 765         (address_space_name_to_int): Update.
 766         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 767         const.
 768         (lookup_template_type): Make name const.
 769         * c-exp.y: Update rules.
 770         (lex_one_token, classify_name, classify_inner_name)
 771         (c_print_token): Update.
 772         * p-exp.y: Update rules.
 773         (yylex): Update.
 774         * f-exp.y: Update rules.
 775         (yylex): Update.
 776         * d-exp.y: Update rules.
 777         (lex_one_token, classify_name, classify_inner_name): Update.
 778         * parse.c (write_dollar_variable, copy_name): Return std::string.
 779         * parser-defs.h (copy_name): Change return type.
 780         * m2-exp.y: Update rules.
 781         (yylex): Update.
 782         * go-exp.y (lex_one_token): Update.
 783         Update rules.
 784         (classify_unsafe_function, classify_packaged_name)
 785         (classify_name, yylex): Update.
 786
 787 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 788
 789         * configure.ac: add --enable-source-highlight switch.
 790         * configure: Regenerate.
 791         * top.c (print_gdb_version): plumb --enable-source-highlight
 792         status to "show configuration".
 793
 794 2019-04-19  Tom Tromey  <tromey@adacore.com>
 795
 796         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 797         Check ADA_TYPE_P.
 798         (empty_record, ada_template_to_fixed_record_type_1)
 799         (template_to_static_fixed_type)
 800         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 801         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 802         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 803         macros.
 804
 805 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 806
 807         PR symtab/24423:
 808         * source.c (print_source_lines_base): Advance "iter" when a
 809         control character is seen.
 810
 811 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 812
 813         * inferior.h (struct infcall_suspend_state_deleter):
 814         Catch exception in destructor to avoid crash.
 815
 816 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 819         close to the add_com "shell".
 820
 821 2019-04-18  Tom Tromey  <tromey@adacore.com>
 822
 823         * process-stratum-target.h (class process_stratum_target)
 824         <stratum>: Add "final".
 825
 826 2019-04-17  Tom Tromey  <tromey@adacore.com>
 827
 828         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 829         against nullptr before use.
 830
 831 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 834
 835 2019-04-17  Jim Wilson  <jimw@sifive.com>
 836             Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 839         code read might fail, assume 4-byte breakpoint in that case.
 840
 841 2019-04-15  Leszek Swirski  <leszeks@google.com>
 842
 843         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 844         rather than a hand-rolled POD check when checking for forced MEMORY
 845         classification.
 846
 847 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 848
 849         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 850         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 851         function.
 852         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 853         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 854         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 855         declaration.
 856
 857 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 858
 859         * aarch64-linux-nat.c
 860         (aarch64_linux_nat_target::thread_architecture): Add override.
 861         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 862         each VQ.
 863
 864 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 865
 866         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 867
 868 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 871         target types of size 96-bits, add some additional comments, and
 872         check that the builtin type we found was the correct size.
 873
 874 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 875
 876         * utils.c (prompt_for_continue): Don't restore the styling at the
 877         end, as applied_style has the wrong value.  This fixes styling in
 878         long lists of file names that are interrupted by the "Continue?"
 879         prompt.
 880
 881 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 884         * c-lang.c (c_language_defn): Likewise.
 885         (cplus_language_defn): Likewise.
 886         (asm_language_defn): Likewise.
 887         (minimal_language_defn): Likewise.
 888         * d-lang.c (d_language_defn): Likewise.
 889         * f-lang.c (f_language_defn): Likewise.
 890         * go-lang.c (go_language_defn): Likewise.
 891         * language.c (unknown_language_defn): Likewise.
 892         (auto_language_defn): Likewise.
 893         * language.h (struct language_defn): Remove la_magic field.
 894         (LANG_MAGIC): Delete.
 895         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 896         * objc-lang.c (objc_language_defn): Likewise.
 897         * opencl-lang.c (opencl_language_defn): Likewise.
 898         * p-lang.c (pascal_language_defn): Likewise.
 899         * rust-lang.c (rust_language_defn): Likewise.
 900
 901 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * riscv-tdep.c (riscv_type_align): New function.
 904         (riscv_type_alignment): Delete.
 905         (riscv_arg_location): Use 'type_align'.
 906         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 907
 908 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * gdbtypes.c (type_align): A struct with no non-static fields also
 911         has alignment of 1.
 912
 913 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 916         component to 0.
 917         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 918         member.
 919         (riscv_struct_info::analyse): New implementation using new
 920         analyse_inner member function.
 921         (riscv_struct_info::field_offset): New member function.
 922         (riscv_struct_info::m_offsets): New member variable.
 923         (riscv_struct_info::analyse_inner): New private member function,
 924         takes the old implementation of riscv_struct_info::analyse but
 925         extended to track field offsets.
 926         (riscv_call_arg_struct): Update the struct folding special cases
 927         to handle cases where empty C++ structs, which are non-zero
 928         length, are found.
 929         (riscv_arg_location): Initialise the length of each location, a
 930         non-zero length now indicates the location is in use.
 931         (riscv_push_dummy_call): Allow for the first location having a
 932         non-zero offset when setting up arguments.
 933         (riscv_return_value): Likewise, but for return values.
 934
 935 2019-04-11  Tom Tromey  <tromey@adacore.com>
 936
 937         * utils.c (internal_vproblem): Make "msg" const.
 938
 939 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 940
 941         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 942         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 943         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 944         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 945
 946 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 947
 948         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 949         function.
 950         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 951         of amd64_collect_native_gregset.
 952         (amd64_linux_nat_target::store_registers): Likewise.
 953
 954 2019-04-10  Tom Tromey  <tom@tromey.com>
 955
 956         * symtab.c (lookup_global_symbol_from_objfile)
 957         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 958         * objfiles.h (class separate_debug_iterator): New.
 959         (class separate_debug_range): New.
 960         (struct objfile) <separate_debug_objfiles>: New method.
 961         (objfile_separate_debug_iterate): Don't declare.
 962         * objfiles.c (separate_debug_iterator::operator++): Rename from
 963         objfile_separate_debug_iterate.
 964         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 965         iterator.
 966         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 967         iterator.
 968
 969 2019-04-10  Tom Tromey  <tom@tromey.com>
 970
 971         * symfile.c (reread_symbols): Remove old comment.
 972         * objfiles.c (free_all_objfiles): Fix a typo.
 973
 974 2019-04-10  Tom Tromey  <tom@tromey.com>
 975
 976         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 977         * minsyms.c (lookup_minimal_symbol): Use foreach.
 978         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 979         (lookup_minimal_symbol_solib_trampoline): Likewise.
 980         * symfile.c (reread_symbols): Use foreach.
 981
 982 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 983             Tom Tromey  <tromey@adacore.com>
 984
 985         PR rust/24414:
 986         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 987         (rust_lex_int_test): Change "value" to be LONGEST.
 988         (rust_lex_tests): Add test for long integer literal.
 989
 990 2019-04-09  Tom Tromey  <tromey@adacore.com>
 991
 992         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 993         to bool.
 994         (extended_remote_target::attach): Update.
 995         (remote_target::remote_notice_new_inferior): Update.
 996         (remote_target::add_current_inferior_and_thread): Update.
 997         * inferior.c (exit_inferior_1): Use "false".
 998         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 999
1000 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1001
1002         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1003         the "start" command.
1004
1005 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1006
1007         * python/py-inferior.c (infpy_thread_from_thread_handle):
1008         Adjust comments to reflect renaming of thread_from_thread_handle
1009         to thread_from_handle.  Adjust keywords.  Fix type error message.
1010         (inferior_object_methods): Add thread_from_handle.  Retain
1011         thread_from_thread_handle, but mark it as deprecated.
1012
1013 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1014
1015         * gdbthread.h (find_thread_by_handle): Revise declaration.
1016         * thread.c (find_thread_by_handle): Likewise.  Adjust
1017         implementation too.
1018         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1019         support for buffer objects as handles.
1020
1021 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1022
1023         * python/py-infthread.c (thpy_thread_handle): New function.
1024         (thread_object_methods): Register thpy_thread_handle.
1025
1026 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1027
1028         * gdbthread.h (thread_to_thread_handle): Declare.
1029         * thread.c (gdbtypes.h): Include.
1030         (thread_to_thread_handle): New function.
1031
1032         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1033         (target_thread_info_to_thread_handle): Declare.
1034         * target.c (target_thread_info_to_thread_handle): New function.
1035         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1036         * target-delegates.c: Regenerate.
1037
1038         * linux-thread-db.c (class thread_db_target): Add method
1039         thread_info_to_thread_handle.
1040         (thread_db_target::thread_info_to_thread_handle): Define.
1041         * remote.c (class remote_target): Add new method
1042         thread_info_to_thread_handle.
1043         (remote_target::thread_info_to_thread_handle): Define.
1044
1045 2019-04-08  Pedro Alves  <palves@redhat.com>
1046
1047         * common/common-exceptions.c (throw_exception): Don't create
1048         named object to throw; throw directly.
1049         (throw_it): Likewise.  Don't initialize gdb_exception::message
1050         here, with new; pass FMT and AP to the ctor instead.
1051         * common/common-exceptions.h: Include <string>.
1052         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1053         const char *, va_list)): New ctor.  Use std::make_shared.
1054         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1055         errors)): Delete.
1056         (gdb_exception_error::gdb_exception_error(enum errors, const char
1057         *, va_list)): New.
1058         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1059         Add assertion.
1060         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1061         errors)): Delete.
1062         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1063         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1064         Add assertion.
1065
1066 2019-04-08  Tom Tromey  <tom@tromey.com>
1067
1068         * valops.c (value_rtti_indirect_type): Replace throw_exception
1069         with throw.
1070         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1071         with throw.
1072         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1073         throw.
1074         * target.c (target_translate_tls_address): Replace throw_exception
1075         with throw.
1076         * stack.c (frame_apply_command_count): Replace throw_exception
1077         with throw.
1078         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1079         throw.
1080         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1081         with throw.
1082         * rs6000-tdep.c (rs6000_frame_cache)
1083         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1084         * remote.c: Replace throw_exception with throw.
1085         * record-full.c (record_full_message, record_full_wait_1)
1086         (record_full_restore): Replace throw_exception with throw.
1087         * record-btrace.c:
1088         (get_thread_current_frame_id, record_btrace_start_replaying)
1089         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1090         (cmd_record_btrace_start): Replace throw_exception with throw.
1091         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1092         throw.
1093         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1094         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1095         * linespec.c:
1096         (find_linespec_symbols): Replace throw_exception with throw.
1097         * infrun.c (displaced_step_prepare, resume): Replace
1098         throw_exception with throw.
1099         * infcmd.c (post_create_inferior): Replace throw_exception with
1100         throw.
1101         * inf-loop.c (inferior_event_handler): Replace throw_exception
1102         with throw.
1103         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1104         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1105         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1106         (get_prev_frame_always, get_frame_pc_if_available)
1107         (get_frame_address_in_block_if_available, get_frame_language):
1108         Replace throw_exception with throw.
1109         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1110         throw_exception with throw.
1111         * eval.c (fetch_subexp_value, evaluate_var_value)
1112         (evaluate_funcall, evaluate_subexp_standard): Replace
1113         throw_exception with throw.
1114         * dwarf2loc.c (call_site_find_chain)
1115         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1116         Replace throw_exception with throw.
1117         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1118         with throw.
1119         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1120         throw.
1121         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1122         * completer.c (complete_line_internal): Replace throw_exception
1123         with throw.
1124         * compile/compile-object-run.c (compile_object_run): Replace
1125         throw_exception with throw.
1126         * cli/cli-script.c (process_next_line): Replace throw_exception
1127         with throw.
1128         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1129         (btrace_enable, btrace_maint_update_pt_packets): Replace
1130         throw_exception with throw.
1131         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1132         throw_exception with throw.
1133         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1134         throw_exception with throw.
1135         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1136         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1137         * aarch64-tdep.c (aarch64_make_prologue_cache)
1138         (aarch64_make_stub_cache): Replace throw_exception with throw.
1139
1140 2019-04-08  Tom Tromey  <tom@tromey.com>
1141
1142         * common/common-exceptions.c (throw_exception): Rename from
1143         throw_exception_cxx.  Remove old copy.  Make argument const.
1144         (throw_it): Create and throw exception objects directly.
1145         * common/common-exceptions.h (throw_exception): Make argument
1146         const.
1147         (struct gdb_exception_error): Add constructor.
1148         (struct gdb_exception_quit): Add constructor.
1149
1150 2019-04-08  Tom Tromey  <tom@tromey.com>
1151
1152         * common/common-exceptions.h (exception_rethrow): Don't declare.
1153         (TRY_SJLJ): Update comment.
1154         (TRY, CATCH, END_CATCH): Remove.
1155         * common/common-exceptions.c (exception_rethrow): Remove.
1156
1157 2019-04-08  Tom Tromey  <tom@tromey.com>
1158
1159         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1160         Remove.
1161         (gdb_exception_error): Rename from
1162         gdb_exception_RETURN_MASK_ERROR.
1163         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1164         (gdb_quit_bad_alloc): Update.
1165         * aarch64-tdep.c: Update.
1166         * ada-lang.c: Update.
1167         * ada-typeprint.c: Update.
1168         * ada-valprint.c: Update.
1169         * amd64-tdep.c: Update.
1170         * arch-utils.c: Update.
1171         * break-catch-throw.c: Update.
1172         * breakpoint.c: Update.
1173         * btrace.c: Update.
1174         * c-varobj.c: Update.
1175         * cli/cli-cmds.c: Update.
1176         * cli/cli-interp.c: Update.
1177         * cli/cli-script.c: Update.
1178         * common/common-exceptions.c: Update.
1179         * common/new-op.c: Update.
1180         * common/selftest.c: Update.
1181         * compile/compile-c-symbols.c: Update.
1182         * compile/compile-cplus-symbols.c: Update.
1183         * compile/compile-object-load.c: Update.
1184         * compile/compile-object-run.c: Update.
1185         * completer.c: Update.
1186         * corelow.c: Update.
1187         * cp-abi.c: Update.
1188         * cp-support.c: Update.
1189         * cp-valprint.c: Update.
1190         * darwin-nat.c: Update.
1191         * disasm-selftests.c: Update.
1192         * dtrace-probe.c: Update.
1193         * dwarf-index-cache.c: Update.
1194         * dwarf-index-write.c: Update.
1195         * dwarf2-frame-tailcall.c: Update.
1196         * dwarf2-frame.c: Update.
1197         * dwarf2loc.c: Update.
1198         * dwarf2read.c: Update.
1199         * eval.c: Update.
1200         * event-loop.c: Update.
1201         * event-top.c: Update.
1202         * exec.c: Update.
1203         * f-valprint.c: Update.
1204         * fbsd-tdep.c: Update.
1205         * frame-unwind.c: Update.
1206         * frame.c: Update.
1207         * gdbtypes.c: Update.
1208         * gnu-v3-abi.c: Update.
1209         * guile/guile-internal.h: Update.
1210         * guile/scm-block.c: Update.
1211         * guile/scm-breakpoint.c: Update.
1212         * guile/scm-cmd.c: Update.
1213         * guile/scm-disasm.c: Update.
1214         * guile/scm-frame.c: Update.
1215         * guile/scm-lazy-string.c: Update.
1216         * guile/scm-math.c: Update.
1217         * guile/scm-param.c: Update.
1218         * guile/scm-ports.c: Update.
1219         * guile/scm-pretty-print.c: Update.
1220         * guile/scm-symbol.c: Update.
1221         * guile/scm-symtab.c: Update.
1222         * guile/scm-type.c: Update.
1223         * guile/scm-value.c: Update.
1224         * i386-linux-tdep.c: Update.
1225         * i386-tdep.c: Update.
1226         * inf-loop.c: Update.
1227         * infcall.c: Update.
1228         * infcmd.c: Update.
1229         * infrun.c: Update.
1230         * jit.c: Update.
1231         * language.c: Update.
1232         * linespec.c: Update.
1233         * linux-fork.c: Update.
1234         * linux-nat.c: Update.
1235         * linux-tdep.c: Update.
1236         * linux-thread-db.c: Update.
1237         * main.c: Update.
1238         * mi/mi-cmd-break.c: Update.
1239         * mi/mi-cmd-stack.c: Update.
1240         * mi/mi-interp.c: Update.
1241         * mi/mi-main.c: Update.
1242         * objc-lang.c: Update.
1243         * p-valprint.c: Update.
1244         * parse.c: Update.
1245         * ppc-linux-tdep.c: Update.
1246         * printcmd.c: Update.
1247         * python/py-arch.c: Update.
1248         * python/py-breakpoint.c: Update.
1249         * python/py-cmd.c: Update.
1250         * python/py-finishbreakpoint.c: Update.
1251         * python/py-frame.c: Update.
1252         * python/py-framefilter.c: Update.
1253         * python/py-gdb-readline.c: Update.
1254         * python/py-inferior.c: Update.
1255         * python/py-infthread.c: Update.
1256         * python/py-lazy-string.c: Update.
1257         * python/py-linetable.c: Update.
1258         * python/py-objfile.c: Update.
1259         * python/py-param.c: Update.
1260         * python/py-prettyprint.c: Update.
1261         * python/py-progspace.c: Update.
1262         * python/py-record-btrace.c: Update.
1263         * python/py-record.c: Update.
1264         * python/py-symbol.c: Update.
1265         * python/py-type.c: Update.
1266         * python/py-unwind.c: Update.
1267         * python/py-utils.c: Update.
1268         * python/py-value.c: Update.
1269         * python/python.c: Update.
1270         * record-btrace.c: Update.
1271         * record-full.c: Update.
1272         * remote-fileio.c: Update.
1273         * remote.c: Update.
1274         * riscv-tdep.c: Update.
1275         * rs6000-aix-tdep.c: Update.
1276         * rs6000-tdep.c: Update.
1277         * rust-exp.y: Update.
1278         * rust-lang.c: Update.
1279         * s390-tdep.c: Update.
1280         * selftest-arch.c: Update.
1281         * solib-dsbt.c: Update.
1282         * solib-frv.c: Update.
1283         * solib-spu.c: Update.
1284         * solib-svr4.c: Update.
1285         * solib.c: Update.
1286         * sparc64-linux-tdep.c: Update.
1287         * stack.c: Update.
1288         * symfile-mem.c: Update.
1289         * symmisc.c: Update.
1290         * target.c: Update.
1291         * thread.c: Update.
1292         * top.c: Update.
1293         * tracefile-tfile.c: Update.
1294         * tui/tui.c: Update.
1295         * typeprint.c: Update.
1296         * unittests/cli-utils-selftests.c: Update.
1297         * unittests/parse-connection-spec-selftests.c: Update.
1298         * valops.c: Update.
1299         * valprint.c: Update.
1300         * value.c: Update.
1301         * varobj.c: Update.
1302         * windows-nat.c: Update.
1303         * x86-linux-nat.c: Update.
1304         * xml-support.c: Update.
1305
1306 2019-04-08  Tom Tromey  <tom@tromey.com>
1307
1308         * xml-support.c: Use C++ exception handling.
1309         * x86-linux-nat.c: Use C++ exception handling.
1310         * windows-nat.c: Use C++ exception handling.
1311         * varobj.c: Use C++ exception handling.
1312         * value.c: Use C++ exception handling.
1313         * valprint.c: Use C++ exception handling.
1314         * valops.c: Use C++ exception handling.
1315         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1316         handling.
1317         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1318         * typeprint.c: Use C++ exception handling.
1319         * tui/tui.c: Use C++ exception handling.
1320         * tracefile-tfile.c: Use C++ exception handling.
1321         * top.c: Use C++ exception handling.
1322         * thread.c: Use C++ exception handling.
1323         * target.c: Use C++ exception handling.
1324         * symmisc.c: Use C++ exception handling.
1325         * symfile-mem.c: Use C++ exception handling.
1326         * stack.c: Use C++ exception handling.
1327         * sparc64-linux-tdep.c: Use C++ exception handling.
1328         * solib.c: Use C++ exception handling.
1329         * solib-svr4.c: Use C++ exception handling.
1330         * solib-spu.c: Use C++ exception handling.
1331         * solib-frv.c: Use C++ exception handling.
1332         * solib-dsbt.c: Use C++ exception handling.
1333         * selftest-arch.c: Use C++ exception handling.
1334         * s390-tdep.c: Use C++ exception handling.
1335         * rust-lang.c: Use C++ exception handling.
1336         * rust-exp.y: Use C++ exception handling.
1337         * rs6000-tdep.c: Use C++ exception handling.
1338         * rs6000-aix-tdep.c: Use C++ exception handling.
1339         * riscv-tdep.c: Use C++ exception handling.
1340         * remote.c: Use C++ exception handling.
1341         * remote-fileio.c: Use C++ exception handling.
1342         * record-full.c: Use C++ exception handling.
1343         * record-btrace.c: Use C++ exception handling.
1344         * python/python.c: Use C++ exception handling.
1345         * python/py-value.c: Use C++ exception handling.
1346         * python/py-utils.c: Use C++ exception handling.
1347         * python/py-unwind.c: Use C++ exception handling.
1348         * python/py-type.c: Use C++ exception handling.
1349         * python/py-symbol.c: Use C++ exception handling.
1350         * python/py-record.c: Use C++ exception handling.
1351         * python/py-record-btrace.c: Use C++ exception handling.
1352         * python/py-progspace.c: Use C++ exception handling.
1353         * python/py-prettyprint.c: Use C++ exception handling.
1354         * python/py-param.c: Use C++ exception handling.
1355         * python/py-objfile.c: Use C++ exception handling.
1356         * python/py-linetable.c: Use C++ exception handling.
1357         * python/py-lazy-string.c: Use C++ exception handling.
1358         * python/py-infthread.c: Use C++ exception handling.
1359         * python/py-inferior.c: Use C++ exception handling.
1360         * python/py-gdb-readline.c: Use C++ exception handling.
1361         * python/py-framefilter.c: Use C++ exception handling.
1362         * python/py-frame.c: Use C++ exception handling.
1363         * python/py-finishbreakpoint.c: Use C++ exception handling.
1364         * python/py-cmd.c: Use C++ exception handling.
1365         * python/py-breakpoint.c: Use C++ exception handling.
1366         * python/py-arch.c: Use C++ exception handling.
1367         * printcmd.c: Use C++ exception handling.
1368         * ppc-linux-tdep.c: Use C++ exception handling.
1369         * parse.c: Use C++ exception handling.
1370         * p-valprint.c: Use C++ exception handling.
1371         * objc-lang.c: Use C++ exception handling.
1372         * mi/mi-main.c: Use C++ exception handling.
1373         * mi/mi-interp.c: Use C++ exception handling.
1374         * mi/mi-cmd-stack.c: Use C++ exception handling.
1375         * mi/mi-cmd-break.c: Use C++ exception handling.
1376         * main.c: Use C++ exception handling.
1377         * linux-thread-db.c: Use C++ exception handling.
1378         * linux-tdep.c: Use C++ exception handling.
1379         * linux-nat.c: Use C++ exception handling.
1380         * linux-fork.c: Use C++ exception handling.
1381         * linespec.c: Use C++ exception handling.
1382         * language.c: Use C++ exception handling.
1383         * jit.c: Use C++ exception handling.
1384         * infrun.c: Use C++ exception handling.
1385         * infcmd.c: Use C++ exception handling.
1386         * infcall.c: Use C++ exception handling.
1387         * inf-loop.c: Use C++ exception handling.
1388         * i386-tdep.c: Use C++ exception handling.
1389         * i386-linux-tdep.c: Use C++ exception handling.
1390         * guile/scm-value.c: Use C++ exception handling.
1391         * guile/scm-type.c: Use C++ exception handling.
1392         * guile/scm-symtab.c: Use C++ exception handling.
1393         * guile/scm-symbol.c: Use C++ exception handling.
1394         * guile/scm-pretty-print.c: Use C++ exception handling.
1395         * guile/scm-ports.c: Use C++ exception handling.
1396         * guile/scm-param.c: Use C++ exception handling.
1397         * guile/scm-math.c: Use C++ exception handling.
1398         * guile/scm-lazy-string.c: Use C++ exception handling.
1399         * guile/scm-frame.c: Use C++ exception handling.
1400         * guile/scm-disasm.c: Use C++ exception handling.
1401         * guile/scm-cmd.c: Use C++ exception handling.
1402         * guile/scm-breakpoint.c: Use C++ exception handling.
1403         * guile/scm-block.c: Use C++ exception handling.
1404         * guile/guile-internal.h: Use C++ exception handling.
1405         * gnu-v3-abi.c: Use C++ exception handling.
1406         * gdbtypes.c: Use C++ exception handling.
1407         * frame.c: Use C++ exception handling.
1408         * frame-unwind.c: Use C++ exception handling.
1409         * fbsd-tdep.c: Use C++ exception handling.
1410         * f-valprint.c: Use C++ exception handling.
1411         * exec.c: Use C++ exception handling.
1412         * event-top.c: Use C++ exception handling.
1413         * event-loop.c: Use C++ exception handling.
1414         * eval.c: Use C++ exception handling.
1415         * dwarf2read.c: Use C++ exception handling.
1416         * dwarf2loc.c: Use C++ exception handling.
1417         * dwarf2-frame.c: Use C++ exception handling.
1418         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1419         * dwarf-index-write.c: Use C++ exception handling.
1420         * dwarf-index-cache.c: Use C++ exception handling.
1421         * dtrace-probe.c: Use C++ exception handling.
1422         * disasm-selftests.c: Use C++ exception handling.
1423         * darwin-nat.c: Use C++ exception handling.
1424         * cp-valprint.c: Use C++ exception handling.
1425         * cp-support.c: Use C++ exception handling.
1426         * cp-abi.c: Use C++ exception handling.
1427         * corelow.c: Use C++ exception handling.
1428         * completer.c: Use C++ exception handling.
1429         * compile/compile-object-run.c: Use C++ exception handling.
1430         * compile/compile-object-load.c: Use C++ exception handling.
1431         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1432         * compile/compile-c-symbols.c: Use C++ exception handling.
1433         * common/selftest.c: Use C++ exception handling.
1434         * common/new-op.c: Use C++ exception handling.
1435         * cli/cli-script.c: Use C++ exception handling.
1436         * cli/cli-interp.c: Use C++ exception handling.
1437         * cli/cli-cmds.c: Use C++ exception handling.
1438         * c-varobj.c: Use C++ exception handling.
1439         * btrace.c: Use C++ exception handling.
1440         * breakpoint.c: Use C++ exception handling.
1441         * break-catch-throw.c: Use C++ exception handling.
1442         * arch-utils.c: Use C++ exception handling.
1443         * amd64-tdep.c: Use C++ exception handling.
1444         * ada-valprint.c: Use C++ exception handling.
1445         * ada-typeprint.c: Use C++ exception handling.
1446         * ada-lang.c: Use C++ exception handling.
1447         * aarch64-tdep.c: Use C++ exception handling.
1448
1449 2019-04-08  Tom Tromey  <tom@tromey.com>
1450
1451         * xml-support.c (gdb_xml_parser::parse): Update.
1452         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1453         * value.c (show_convenience): Update.
1454         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1455         (test_parse_flags_qcs): Update.
1456         * thread.c (thr_try_catch_cmd): Update.
1457         * target.c (target_translate_tls_address): Update.
1458         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1459         (info_frame_command_core, frame_apply_command_count): Update.
1460         * rust-exp.y (rust_lex_exception_test): Update.
1461         * riscv-tdep.c (riscv_print_one_register_info): Update.
1462         * remote.c (remote_target::enable_btrace): Update.
1463         * record-btrace.c (record_btrace_enable_warn): Update.
1464         * python/py-utils.c (gdbpy_convert_exception): Update.
1465         * printcmd.c (do_one_display, print_variable_and_value): Update.
1466         * mi/mi-main.c (mi_print_exception): Update.
1467         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1468         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1469         * linux-nat.c (linux_nat_target::attach): Update.
1470         * linux-fork.c (class scoped_switch_fork_info): Update.
1471         * infrun.c (displaced_step_prepare): Update.
1472         * infcall.c (call_function_by_hand_dummy): Update.
1473         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1474         * gnu-v3-abi.c (print_one_vtable): Update.
1475         * frame.c (get_prev_frame_always): Update.
1476         * f-valprint.c (info_common_command_for_block): Update.
1477         * exec.c (try_open_exec_file): Update.
1478         * exceptions.c (print_exception, exception_print)
1479         (exception_fprintf, exception_print_same): Update.
1480         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1481         * dwarf-index-cache.c (index_cache::store)
1482         (index_cache::lookup_gdb_index): Update.
1483         * darwin-nat.c (maybe_cache_shell): Update.
1484         * cp-valprint.c (cp_print_value_fields): Update.
1485         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1486         (gcc_cplus_symbol_address): Update.
1487         * compile/compile-c-symbols.c (gcc_convert_symbol)
1488         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1489         * common/selftest.c: Update.
1490         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1491         a std::string.
1492         (exception_try_scope_entry, exception_try_scope_exit): Don't
1493         declare.
1494         (struct exception_try_scope): Remove.
1495         (TRY): Don't use exception_try_scope.
1496         (struct gdb_exception): Add constructor, operator=.
1497         <what>: New method.
1498         (struct gdb_exception_RETURN_MASK_ALL)
1499         (struct gdb_exception_RETURN_MASK_ERROR)
1500         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1501         (struct gdb_quit_bad_alloc): Update.
1502         * common/common-exceptions.c (exception_none): Change
1503         initializer.
1504         (struct catcher) <state, exception>: Initialize inline.
1505         <prev>: Remove member.
1506         (current_catcher): Remove.
1507         (catchers): New global.
1508         (exceptions_state_mc_init): Simplify.
1509         (catcher_pop): Remove.
1510         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1511         (try_scope_depth, exception_try_scope_entry)
1512         (exception_try_scope_exit): Remove.
1513         (throw_exception_sjlj): Update.
1514         (exception_messages, exception_messages_size): Remove.
1515         (throw_it): Simplify.
1516         (gdb_exception_sliced_copy): Remove.
1517         (throw_exception_cxx): Update.
1518         * cli/cli-script.c (script_from_file): Update.
1519         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1520         Update.
1521         * ada-valprint.c (ada_val_print): Update.
1522         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1523         (create_excep_cond_exprs): Update.
1524
1525 2019-04-08  Tom Tromey  <tom@tromey.com>
1526
1527         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1528         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1529         (TRY, CATCH, END_CATCH): Remove some definitions.
1530         * common/common-exceptions.c: Don't use GDB_XCPT.
1531         (catcher_list_size): Remove.
1532         (throw_exception, throw_it): Simplify.
1533
1534 2019-04-05  Tom Tromey  <tom@tromey.com>
1535
1536         Revert the header-sorting patch.
1537         * ft32-tdep.c: Revert.
1538         * frv-tdep.c: Revert.
1539         * frv-linux-tdep.c: Revert.
1540         * frame.c: Revert.
1541         * frame-unwind.c: Revert.
1542         * frame-base.c: Revert.
1543         * fork-child.c: Revert.
1544         * findvar.c: Revert.
1545         * findcmd.c: Revert.
1546         * filesystem.c: Revert.
1547         * filename-seen-cache.h: Revert.
1548         * filename-seen-cache.c: Revert.
1549         * fbsd-tdep.c: Revert.
1550         * fbsd-nat.h: Revert.
1551         * fbsd-nat.c: Revert.
1552         * f-valprint.c: Revert.
1553         * f-typeprint.c: Revert.
1554         * f-lang.c: Revert.
1555         * extension.h: Revert.
1556         * extension.c: Revert.
1557         * extension-priv.h: Revert.
1558         * expprint.c: Revert.
1559         * exec.h: Revert.
1560         * exec.c: Revert.
1561         * exceptions.c: Revert.
1562         * event-top.c: Revert.
1563         * event-loop.c: Revert.
1564         * eval.c: Revert.
1565         * elfread.c: Revert.
1566         * dwarf2read.h: Revert.
1567         * dwarf2read.c: Revert.
1568         * dwarf2loc.c: Revert.
1569         * dwarf2expr.h: Revert.
1570         * dwarf2expr.c: Revert.
1571         * dwarf2-frame.c: Revert.
1572         * dwarf2-frame-tailcall.c: Revert.
1573         * dwarf-index-write.h: Revert.
1574         * dwarf-index-write.c: Revert.
1575         * dwarf-index-common.c: Revert.
1576         * dwarf-index-cache.h: Revert.
1577         * dwarf-index-cache.c: Revert.
1578         * dummy-frame.c: Revert.
1579         * dtrace-probe.c: Revert.
1580         * disasm.h: Revert.
1581         * disasm.c: Revert.
1582         * disasm-selftests.c: Revert.
1583         * dictionary.c: Revert.
1584         * dicos-tdep.c: Revert.
1585         * demangle.c: Revert.
1586         * dcache.h: Revert.
1587         * dcache.c: Revert.
1588         * darwin-nat.h: Revert.
1589         * darwin-nat.c: Revert.
1590         * darwin-nat-info.c: Revert.
1591         * d-valprint.c: Revert.
1592         * d-namespace.c: Revert.
1593         * d-lang.c: Revert.
1594         * ctf.c: Revert.
1595         * csky-tdep.c: Revert.
1596         * csky-linux-tdep.c: Revert.
1597         * cris-tdep.c: Revert.
1598         * cris-linux-tdep.c: Revert.
1599         * cp-valprint.c: Revert.
1600         * cp-support.c: Revert.
1601         * cp-namespace.c: Revert.
1602         * cp-abi.c: Revert.
1603         * corelow.c: Revert.
1604         * corefile.c: Revert.
1605         * continuations.c: Revert.
1606         * completer.h: Revert.
1607         * completer.c: Revert.
1608         * complaints.c: Revert.
1609         * coffread.c: Revert.
1610         * coff-pe-read.c: Revert.
1611         * cli-out.h: Revert.
1612         * cli-out.c: Revert.
1613         * charset.c: Revert.
1614         * c-varobj.c: Revert.
1615         * c-valprint.c: Revert.
1616         * c-typeprint.c: Revert.
1617         * c-lang.c: Revert.
1618         * buildsym.c: Revert.
1619         * buildsym-legacy.c: Revert.
1620         * build-id.h: Revert.
1621         * build-id.c: Revert.
1622         * btrace.c: Revert.
1623         * bsd-uthread.c: Revert.
1624         * breakpoint.h: Revert.
1625         * breakpoint.c: Revert.
1626         * break-catch-throw.c: Revert.
1627         * break-catch-syscall.c: Revert.
1628         * break-catch-sig.c: Revert.
1629         * blockframe.c: Revert.
1630         * block.c: Revert.
1631         * bfin-tdep.c: Revert.
1632         * bfin-linux-tdep.c: Revert.
1633         * bfd-target.c: Revert.
1634         * bcache.c: Revert.
1635         * ax-general.c: Revert.
1636         * ax-gdb.h: Revert.
1637         * ax-gdb.c: Revert.
1638         * avr-tdep.c: Revert.
1639         * auxv.c: Revert.
1640         * auto-load.c: Revert.
1641         * arm-wince-tdep.c: Revert.
1642         * arm-tdep.c: Revert.
1643         * arm-symbian-tdep.c: Revert.
1644         * arm-pikeos-tdep.c: Revert.
1645         * arm-obsd-tdep.c: Revert.
1646         * arm-nbsd-tdep.c: Revert.
1647         * arm-nbsd-nat.c: Revert.
1648         * arm-linux-tdep.c: Revert.
1649         * arm-linux-nat.c: Revert.
1650         * arm-fbsd-tdep.c: Revert.
1651         * arm-fbsd-nat.c: Revert.
1652         * arm-bsd-tdep.c: Revert.
1653         * arch-utils.c: Revert.
1654         * arc-tdep.c: Revert.
1655         * arc-newlib-tdep.c: Revert.
1656         * annotate.h: Revert.
1657         * annotate.c: Revert.
1658         * amd64-windows-tdep.c: Revert.
1659         * amd64-windows-nat.c: Revert.
1660         * amd64-tdep.c: Revert.
1661         * amd64-sol2-tdep.c: Revert.
1662         * amd64-obsd-tdep.c: Revert.
1663         * amd64-obsd-nat.c: Revert.
1664         * amd64-nbsd-tdep.c: Revert.
1665         * amd64-nbsd-nat.c: Revert.
1666         * amd64-nat.c: Revert.
1667         * amd64-linux-tdep.c: Revert.
1668         * amd64-linux-nat.c: Revert.
1669         * amd64-fbsd-tdep.c: Revert.
1670         * amd64-fbsd-nat.c: Revert.
1671         * amd64-dicos-tdep.c: Revert.
1672         * amd64-darwin-tdep.c: Revert.
1673         * amd64-bsd-nat.c: Revert.
1674         * alpha-tdep.c: Revert.
1675         * alpha-obsd-tdep.c: Revert.
1676         * alpha-nbsd-tdep.c: Revert.
1677         * alpha-mdebug-tdep.c: Revert.
1678         * alpha-linux-tdep.c: Revert.
1679         * alpha-linux-nat.c: Revert.
1680         * alpha-bsd-tdep.c: Revert.
1681         * alpha-bsd-nat.c: Revert.
1682         * aix-thread.c: Revert.
1683         * agent.c: Revert.
1684         * addrmap.c: Revert.
1685         * ada-varobj.c: Revert.
1686         * ada-valprint.c: Revert.
1687         * ada-typeprint.c: Revert.
1688         * ada-tasks.c: Revert.
1689         * ada-lang.c: Revert.
1690         * aarch64-tdep.c: Revert.
1691         * aarch64-ravenscar-thread.c: Revert.
1692         * aarch64-newlib-tdep.c: Revert.
1693         * aarch64-linux-tdep.c: Revert.
1694         * aarch64-linux-nat.c: Revert.
1695         * aarch64-fbsd-tdep.c: Revert.
1696         * aarch64-fbsd-nat.c: Revert.
1697         * aarch32-linux-nat.c: Revert.
1698
1699 2019-04-05  Tom Tromey  <tom@tromey.com>
1700
1701         * ft32-tdep.c: Sort headers.
1702         * frv-tdep.c: Sort headers.
1703         * frv-linux-tdep.c: Sort headers.
1704         * frame.c: Sort headers.
1705         * frame-unwind.c: Sort headers.
1706         * frame-base.c: Sort headers.
1707         * fork-child.c: Sort headers.
1708         * findvar.c: Sort headers.
1709         * findcmd.c: Sort headers.
1710         * filesystem.c: Sort headers.
1711         * filename-seen-cache.h: Sort headers.
1712         * filename-seen-cache.c: Sort headers.
1713         * fbsd-tdep.c: Sort headers.
1714         * fbsd-nat.h: Sort headers.
1715         * fbsd-nat.c: Sort headers.
1716         * f-valprint.c: Sort headers.
1717         * f-typeprint.c: Sort headers.
1718         * f-lang.c: Sort headers.
1719         * extension.h: Sort headers.
1720         * extension.c: Sort headers.
1721         * extension-priv.h: Sort headers.
1722         * expprint.c: Sort headers.
1723         * exec.h: Sort headers.
1724         * exec.c: Sort headers.
1725         * exceptions.c: Sort headers.
1726         * event-top.c: Sort headers.
1727         * event-loop.c: Sort headers.
1728         * eval.c: Sort headers.
1729         * elfread.c: Sort headers.
1730         * dwarf2read.h: Sort headers.
1731         * dwarf2read.c: Sort headers.
1732         * dwarf2loc.c: Sort headers.
1733         * dwarf2expr.h: Sort headers.
1734         * dwarf2expr.c: Sort headers.
1735         * dwarf2-frame.c: Sort headers.
1736         * dwarf2-frame-tailcall.c: Sort headers.
1737         * dwarf-index-write.h: Sort headers.
1738         * dwarf-index-write.c: Sort headers.
1739         * dwarf-index-common.c: Sort headers.
1740         * dwarf-index-cache.h: Sort headers.
1741         * dwarf-index-cache.c: Sort headers.
1742         * dummy-frame.c: Sort headers.
1743         * dtrace-probe.c: Sort headers.
1744         * disasm.h: Sort headers.
1745         * disasm.c: Sort headers.
1746         * disasm-selftests.c: Sort headers.
1747         * dictionary.c: Sort headers.
1748         * dicos-tdep.c: Sort headers.
1749         * demangle.c: Sort headers.
1750         * dcache.h: Sort headers.
1751         * dcache.c: Sort headers.
1752         * darwin-nat.h: Sort headers.
1753         * darwin-nat.c: Sort headers.
1754         * darwin-nat-info.c: Sort headers.
1755         * d-valprint.c: Sort headers.
1756         * d-namespace.c: Sort headers.
1757         * d-lang.c: Sort headers.
1758         * ctf.c: Sort headers.
1759         * csky-tdep.c: Sort headers.
1760         * csky-linux-tdep.c: Sort headers.
1761         * cris-tdep.c: Sort headers.
1762         * cris-linux-tdep.c: Sort headers.
1763         * cp-valprint.c: Sort headers.
1764         * cp-support.c: Sort headers.
1765         * cp-namespace.c: Sort headers.
1766         * cp-abi.c: Sort headers.
1767         * corelow.c: Sort headers.
1768         * corefile.c: Sort headers.
1769         * continuations.c: Sort headers.
1770         * completer.h: Sort headers.
1771         * completer.c: Sort headers.
1772         * complaints.c: Sort headers.
1773         * coffread.c: Sort headers.
1774         * coff-pe-read.c: Sort headers.
1775         * cli-out.h: Sort headers.
1776         * cli-out.c: Sort headers.
1777         * charset.c: Sort headers.
1778         * c-varobj.c: Sort headers.
1779         * c-valprint.c: Sort headers.
1780         * c-typeprint.c: Sort headers.
1781         * c-lang.c: Sort headers.
1782         * buildsym.c: Sort headers.
1783         * buildsym-legacy.c: Sort headers.
1784         * build-id.h: Sort headers.
1785         * build-id.c: Sort headers.
1786         * btrace.c: Sort headers.
1787         * bsd-uthread.c: Sort headers.
1788         * breakpoint.h: Sort headers.
1789         * breakpoint.c: Sort headers.
1790         * break-catch-throw.c: Sort headers.
1791         * break-catch-syscall.c: Sort headers.
1792         * break-catch-sig.c: Sort headers.
1793         * blockframe.c: Sort headers.
1794         * block.c: Sort headers.
1795         * bfin-tdep.c: Sort headers.
1796         * bfin-linux-tdep.c: Sort headers.
1797         * bfd-target.c: Sort headers.
1798         * bcache.c: Sort headers.
1799         * ax-general.c: Sort headers.
1800         * ax-gdb.h: Sort headers.
1801         * ax-gdb.c: Sort headers.
1802         * avr-tdep.c: Sort headers.
1803         * auxv.c: Sort headers.
1804         * auto-load.c: Sort headers.
1805         * arm-wince-tdep.c: Sort headers.
1806         * arm-tdep.c: Sort headers.
1807         * arm-symbian-tdep.c: Sort headers.
1808         * arm-pikeos-tdep.c: Sort headers.
1809         * arm-obsd-tdep.c: Sort headers.
1810         * arm-nbsd-tdep.c: Sort headers.
1811         * arm-nbsd-nat.c: Sort headers.
1812         * arm-linux-tdep.c: Sort headers.
1813         * arm-linux-nat.c: Sort headers.
1814         * arm-fbsd-tdep.c: Sort headers.
1815         * arm-fbsd-nat.c: Sort headers.
1816         * arm-bsd-tdep.c: Sort headers.
1817         * arch-utils.c: Sort headers.
1818         * arc-tdep.c: Sort headers.
1819         * arc-newlib-tdep.c: Sort headers.
1820         * annotate.h: Sort headers.
1821         * annotate.c: Sort headers.
1822         * amd64-windows-tdep.c: Sort headers.
1823         * amd64-windows-nat.c: Sort headers.
1824         * amd64-tdep.c: Sort headers.
1825         * amd64-sol2-tdep.c: Sort headers.
1826         * amd64-obsd-tdep.c: Sort headers.
1827         * amd64-obsd-nat.c: Sort headers.
1828         * amd64-nbsd-tdep.c: Sort headers.
1829         * amd64-nbsd-nat.c: Sort headers.
1830         * amd64-nat.c: Sort headers.
1831         * amd64-linux-tdep.c: Sort headers.
1832         * amd64-linux-nat.c: Sort headers.
1833         * amd64-fbsd-tdep.c: Sort headers.
1834         * amd64-fbsd-nat.c: Sort headers.
1835         * amd64-dicos-tdep.c: Sort headers.
1836         * amd64-darwin-tdep.c: Sort headers.
1837         * amd64-bsd-nat.c: Sort headers.
1838         * alpha-tdep.c: Sort headers.
1839         * alpha-obsd-tdep.c: Sort headers.
1840         * alpha-nbsd-tdep.c: Sort headers.
1841         * alpha-mdebug-tdep.c: Sort headers.
1842         * alpha-linux-tdep.c: Sort headers.
1843         * alpha-linux-nat.c: Sort headers.
1844         * alpha-bsd-tdep.c: Sort headers.
1845         * alpha-bsd-nat.c: Sort headers.
1846         * aix-thread.c: Sort headers.
1847         * agent.c: Sort headers.
1848         * addrmap.c: Sort headers.
1849         * ada-varobj.c: Sort headers.
1850         * ada-valprint.c: Sort headers.
1851         * ada-typeprint.c: Sort headers.
1852         * ada-tasks.c: Sort headers.
1853         * ada-lang.c: Sort headers.
1854         * aarch64-tdep.c: Sort headers.
1855         * aarch64-ravenscar-thread.c: Sort headers.
1856         * aarch64-newlib-tdep.c: Sort headers.
1857         * aarch64-linux-tdep.c: Sort headers.
1858         * aarch64-linux-nat.c: Sort headers.
1859         * aarch64-fbsd-tdep.c: Sort headers.
1860         * aarch64-fbsd-nat.c: Sort headers.
1861         * aarch32-linux-nat.c: Sort headers.
1862
1863 2019-04-04  Tom Tromey  <tom@tromey.com>
1864
1865         * varobj.c (varobj_create): Update.
1866         * rust-exp.y (struct rust_parser) <update_innermost_block,
1867         lookup_symbol>: New methods.
1868         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1869         Rename.
1870         (rust_parser::rust_lookup_type)
1871         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1872         * printcmd.c (display_command, do_one_display): Update.
1873         * parser-defs.h (struct parser_state) <parser_state>: Add
1874         "tracker" parameter.
1875         (block_tracker): New member.
1876         (class innermost_block_tracker) <innermost_block_tracker>: Add
1877         "types" parameter.
1878         <reset>: Remove method.
1879         (innermost_block): Don't declare.
1880         (null_post_parser): Update.
1881         * parse.c (innermost_block): Remove global.
1882         (write_dollar_variable): Update.
1883         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1884         Remove "tracker_types" parameter.
1885         (parse_expression): Add "tracker" parameter.
1886         (parse_expression_for_completion): Update.
1887         (null_post_parser): Add "tracker" parameter.
1888         * p-exp.y: Update rules.
1889         * m2-exp.y: Update rules.
1890         * language.h (struct language_defn) <la_post_parser>: Add
1891         "tracker" parameter.
1892         * go-exp.y: Update rules.
1893         * f-exp.y: Update rules.
1894         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1895         parameter.
1896         * d-exp.y: Update rules.
1897         * c-exp.y: Update rules.
1898         * breakpoint.c (set_breakpoint_condition): Create an
1899         innermost_block_tracker.
1900         (watch_command_1): Likewise.
1901         * ada-lang.c (resolve): Add "tracker" parameter.
1902         (resolve_subexp): Likewise.
1903         * ada-exp.y (write_var_from_sym): Update.
1904
1905 2019-04-04  Tom Tromey  <tom@tromey.com>
1906
1907         * type-stack.h: New file.
1908         * type-stack.c: New file.
1909         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1910         type-stack.h.
1911         (insert_into_type_stack, insert_type, push_type, push_type_int)
1912         (insert_type_address_space, pop_type, pop_type_int)
1913         (pop_typelist, pop_type_stack, append_type_stack)
1914         (push_type_stack, get_type_stack, push_typelist)
1915         (follow_type_instance_flags, follow_types): Don't declare.
1916         * parse.c (type_stack): Remove global.
1917         (parse_exp_in_context): Update.
1918         (insert_into_type_stack, insert_type, push_type, push_type_int)
1919         (insert_type_address_space, pop_type, pop_type_int)
1920         (pop_typelist, pop_type_stack, append_type_stack)
1921         (push_type_stack, get_type_stack, push_typelist)
1922         (follow_type_instance_flags, follow_types): Remove (moved to
1923         type-stack.c).
1924         * f-exp.y (type_stack): New global.
1925         Update rules.
1926         (push_kind_type, f_parse): Update.
1927         * d-exp.y (type_stack): New global.
1928         Update rules.
1929         (d_parse): Update.
1930         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1931         Update rules.
1932         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1933         (HFILES_NO_SRCDIR): Add type-stack.h.
1934
1935 2019-04-04  Tom Tromey  <tom@tromey.com>
1936
1937         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1938         (rust_parser::convert_ast_to_expression, rust_parse)
1939         (rust_lex_test_completion, rust_lex_tests): Update.
1940         * parser-defs.h (struct expr_completion_state): New.
1941         (struct parser_state) <parser_state>: Add completion parameter.
1942         <mark_struct_expression, mark_completion_tag>: New methods.
1943         <parse_completion, m_completion_state>: New members.
1944         (prefixify_expression, null_post_parser): Update.
1945         (mark_struct_expression, mark_completion_tag): Don't declare.
1946         * parse.c (parse_completion, expout_last_struct)
1947         (expout_tag_completion_type, expout_completion_name): Remove
1948         globals.
1949         (parser_state::mark_struct_expression)
1950         (parser_state::mark_completion_tag): Now methods.
1951         (prefixify_expression): Add last_struct parameter.
1952         (prefixify_subexp): Likewise.
1953         (parse_exp_1): Update.
1954         (parse_exp_in_context): Add cstate parameter.  Update.
1955         (parse_expression_for_completion): Create an
1956         expr_completion_state.
1957         (null_post_parser): Add "completion" parameter.
1958         * p-exp.y: Update rules.
1959         (yylex): Update.
1960         * language.h (struct language_defn) <la_post_parser>: Add
1961         "completing" parameter.
1962         * go-exp.y: Update rules.
1963         (lex_one_token): Update.
1964         * expression.h (parse_completion): Don't declare.
1965         * d-exp.y: Update rules.
1966         (lex_one_token): Update rules.
1967         * c-exp.y: Update rules.
1968         (lex_one_token): Update.
1969         * ada-lang.c (resolve): Add "parse_completion" parameter.
1970         (resolve_subexp): Likewise.
1971         (ada_resolve_function): Likewise.
1972
1973 2019-04-04  Tom Tromey  <tom@tromey.com>
1974
1975         * parser-defs.h (struct parser_state) <start_arglist,
1976         end_arglist>: New methods.
1977         <arglist_len, m_funcall_chain>: New members.
1978         (arglist_len, start_arglist, end_arglist): Don't declare.
1979         * parse.c (arglist_len, funcall_chain): Remove global.
1980         (start_arglist, end_arglist): Remove functions.
1981         (parse_exp_in_context): Update.
1982         * p-exp.y: Update rules.
1983         * m2-exp.y: Update rules.
1984         * go-exp.y: Update rules.
1985         * f-exp.y: Update rules.
1986         * d-exp.y: Update rules.
1987         * c-exp.y: Update rules.
1988
1989 2019-04-04  Tom Tromey  <tom@tromey.com>
1990
1991         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1992         lex_operator, push_back>: New methods.
1993         Update all rules.
1994         (rust_parser::lex_hex, lex_escape): Rename and update.
1995         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1996         (rust_parser::lex_operator): Rename and update.
1997         (rust_parser::lex_number, rustyylex, rustyyerror)
1998         (rust_lex_test_init, rust_lex_test_sequence)
1999         (rust_lex_test_push_back, rust_lex_tests): Update.
2000         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2001         parameter.
2002         <lexptr, prev_lexptr>: New members.
2003         (lexptr, prev_lexptr): Don't declare.
2004         * parse.c (lexptr, prev_lexptr): Remove globals.
2005         (parse_exp_in_context): Update.
2006         * p-exp.y (yylex, yyerror): Update.
2007         * m2-exp.y (parse_number, yylex, yyerror): Update.
2008         * go-exp.y (lex_one_token, yyerror): Update.
2009         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2010         * d-exp.y (lex_one_token, yyerror): Update.
2011         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2012         (lex_one_token, yyerror): Update.
2013         * ada-lex.l (YY_INPUT): Update.
2014         (rewind_to_char): Update.
2015         * ada-exp.y (yyerror): Update.
2016
2017 2019-04-04  Tom Tromey  <tom@tromey.com>
2018
2019         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2020         * parser-defs.h (struct parser_state) <parser_state>: Add new
2021         parameter.
2022         <comma_terminates>: New member.
2023         (comma_terminates): Don't declare global.
2024         * parse.c (comma_terminates): Remove global.
2025         (parse_exp_in_context): Update.
2026         * p-exp.y (yylex): Update.
2027         * m2-exp.y (yylex): Update.
2028         * go-exp.y (lex_one_token): Update.
2029         * f-exp.y (yylex): Update.
2030         * d-exp.y (lex_one_token): Update.
2031         * c-exp.y (lex_one_token): Update.
2032         * ada-lex.l: Update.
2033
2034 2019-04-04  Tom Tromey  <tom@tromey.com>
2035
2036         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2037         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2038         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2039         * parser-defs.h (paren_depth): Don't declare.
2040         * parse.c (paren_depth): Remove global.
2041         (parse_exp_in_context): Update.
2042         * p-exp.y (paren_depth): New global.
2043         (pascal_parse): Initialize it.
2044         * m2-exp.y (paren_depth): New global.
2045         (m2_parse): Initialize it.
2046         * go-exp.y (paren_depth): New global.
2047         (go_parse): Initialize it.
2048         * f-exp.y (paren_depth): New global.
2049         (f_parse): Initialize it.
2050         * d-exp.y (paren_depth): New global.
2051         (d_parse): Initialize it.
2052         * c-exp.y (paren_depth): New global.
2053         (c_parse): Initialize it.
2054         * ada-lex.l (paren_depth): New global.
2055         (lexer_init): Initialize it.
2056
2057 2019-04-04  Tom Tromey  <tom@tromey.com>
2058
2059         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2060         (rust_parser::convert_ast_to_type)
2061         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2062         * parser-defs.h (struct parser_state) <parser_state>: Add
2063         parameters.  Initialize new members.
2064         <expression_context_block, expression_context_pc>: New members.
2065         * parse.c (expression_context_block, expression_context_pc):
2066         Remove globals.
2067         (parse_exp_in_context): Update.
2068         * p-exp.y: Update all rules.
2069         (yylex): Update.
2070         * m2-exp.y: Update all rules.
2071         (yylex): Update.
2072         * go-exp.y (yylex): Update.
2073         * f-exp.y (yylex): Update.
2074         * d-exp.y: Update all rules.
2075         (yylex): Update.
2076         * c-exp.y: Update all rules.
2077         (lex_one_token, classify_name, yylex, c_parse): Update.
2078         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2079
2080 2019-04-04  Tom Tromey  <tom@tromey.com>
2081
2082         * gdbarch.h, gdbarch.c: Rebuild.
2083         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2084         * stap-probe.h:
2085         (struct stap_parse_info): Replace "parser_state" with
2086         "expr_builder".
2087         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2088         (parser_state): New class.
2089         * parse.c (expr_builder): Rename.
2090         (expr_builder::release): Rename.
2091         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2092         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2093         (write_exp_elt_longcst, write_exp_elt_floatcst)
2094         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2095         (write_exp_string_vector, write_exp_bitstring)
2096         (write_exp_msymbol, mark_struct_expression)
2097         (write_dollar_variable)
2098         (insert_type_address_space, increase_expout_size): Replace
2099         "parser_state" with "expr_builder".
2100         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2101         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2102         "parser_state" with "expr_builder".
2103
2104 2019-04-04  Tom Tromey  <tom@tromey.com>
2105
2106         * rust-exp.y: Replace "parse_language" with method call.
2107         * p-exp.y:
2108         (yylex): Replace "parse_language" with method call.
2109         * m2-exp.y:
2110         (yylex): Replace "parse_language" with method call.
2111         * go-exp.y (classify_name): Replace "parse_language" with method
2112         call.
2113         * f-exp.y (yylex): Replace "parse_language" with method call.
2114         * d-exp.y (lex_one_token): Replace "parse_language" with method
2115         call.
2116         * c-exp.y:
2117         (lex_one_token, classify_name, yylex): Replace "parse_language"
2118         with method call.
2119         * ada-exp.y (find_primitive_type, type_char)
2120         (type_system_address): Replace "parse_language" with method call.
2121
2122 2019-04-04  Tom Tromey  <tom@tromey.com>
2123
2124         * rust-exp.y: Replace "parse_gdbarch" with method call.
2125         * parse.c (write_dollar_variable, insert_type_address_space):
2126         Replace "parse_gdbarch" with method call.
2127         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2128         call.
2129         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2130         call.
2131         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2132         "parse_gdbarch" with method call.
2133         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2134         with method call.
2135         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2136         "parse_gdbarch" with method call.
2137         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2138         "parse_gdbarch" with method call.
2139         * c-exp.y (parse_type, parse_number, classify_name): Replace
2140         "parse_gdbarch" with method call.
2141         * ada-lex.l: Replace "parse_gdbarch" with method call.
2142         * ada-exp.y (parse_type, find_primitive_type, type_char)
2143         (type_system_address): Replace "parse_gdbarch" with method call.
2144
2145 2019-04-04  Tom Tromey  <tom@tromey.com>
2146
2147         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2148         * stap-probe.c (stap_parse_argument): Update.
2149         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2150         initial_size parameter.
2151         * rust-exp.y (rust_lex_tests): Update.
2152         * parse.c (parser_state): Update.
2153         (parse_exp_in_context): Update.
2154         * parser-defs.h (struct parser_state) <parser_state>: Remove
2155         "initial_size" parameter.
2156
2157 2019-04-04  Tom Tromey  <tom@tromey.com>
2158
2159         * parser-defs.h (increase_expout_size): Don't declare.
2160         * parse.c (increase_expout_size): Now static.
2161
2162 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2163
2164         * gnu-nat.c (gnu_nat_target::wait): Fix
2165         target_waitstatus_to_string call.
2166
2167 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         * eval.c (evaluate_subexp_standard): Handle internal functions
2170         during Fortran function call handling.
2171
2172 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * NEWS: Mention new internal functions.
2175         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2176         (read_base_type): Use dwarf2_init_complex_target_type.
2177         * value.c (creal_internal_fn): New function.
2178         (cimag_internal_fn): New function.
2179         (_initialize_values): Register new internal functions.
2180
2181 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2182
2183         * infrun.c (stop_all_threads): If debug_infrun, always
2184         trace the wait status after wait_one, using
2185         target_waitstatus_to_string and target_pid_to_str.
2186         (handle_inferior_event): Replace various trace of
2187         wait status kind by a single trace.
2188         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2189         wait status kind image by target_waitstatus_to_string.
2190         * target/waitstatus.c (target_waitstatus_to_string): Fix
2191         obsolete comment.
2192
2193 2019-04-01  Tom Tromey  <tromey@adacore.com>
2194
2195         PR symtab/23331:
2196         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2197
2198 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2199             Pedro Alves  <palves@redhat.com>
2200
2201         * top.c (quit_force): Call 'finalize_values'.
2202         * value.c (finalize_values): New function.
2203         * value.h (finalize_values): Declare.
2204
2205 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2206
2207         * NEWS: Announce $_gdb_major and $_gdb_minor.
2208
2209         * top.c (init_gdb_version_vars): New function.
2210         (gdb_init): Call init_gdb_version_vars.
2211
2212 2019-03-29  Tom Tromey  <tromey@adacore.com>
2213
2214         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2215         help text.  Remove dead code.
2216
2217 2019-03-29  Keith Seitz  <keiths@redhat.com>
2218
2219         From Siddhesh Poyarekar:
2220         * f-lang.h (f77_get_upperbound): Return LONGEST.
2221         (f77_get_lowerbound): Likewise.
2222         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2223         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2224         print them.
2225         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2226         plongest to format print it.
2227         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2228         (f77_get_upperbound): Likewise.
2229         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2230         LOWER_BOUND to LONGEST.
2231         (f77_create_arrayprint_offset_tbl): Likewise.
2232
2233 2019-03-29  Keith Seitz  <keiths@redhat.com>
2234
2235         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2236         %s/pulongest for TYPE_LENGTH instead of %d in format
2237         strings.
2238         * ada-typerint.c (ada_print_type): Likewise.
2239         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2240         * compile/compile-c-support.c (generate_register_struct): Likewise.
2241         * gdbtypes.c (recursive_dump_type): Likewise.
2242         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2243         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2244         instead of %d in format strings.
2245         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2246         to std::min to ULONGEST.
2247         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2248         instead of %d in format strings.
2249         * tracepoint.c (info_scope_command): Likewise.
2250         * typeprint.c (print_offset_data::update)
2251         (print_offset_data::finish): Likewise.
2252         * xtensa-tdep.c (xtensa_store_return_value)
2253         (xtensa_push_dummy_call): Likewise.
2254
2255 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2256
2257         * windows-nat.c (display_selector): Fixed format specifications
2258         for 64-bit Cygwin.
2259
2260 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2261
2262         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2263
2264 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2265
2266         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2267         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2268         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2269         (nios2_linux_init_abi): Install it.
2270
2271 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2274
2275 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2276
2277         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2278
2279 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2280             Tom Tromey  <tromey@adacore.com>
2281
2282         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2283
2284 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2285
2286         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2287         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2288         method to compute the bounds of range types. Also print "[evaluated]"
2289         if the bounds' values come from a dynamic evaluation.
2290
2291 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2294         whitespace when pretty printing is on.
2295
2296 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2297
2298         * ppc-linux-nat.c: Add include.
2299
2300 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2301
2302         * NEWS: Mention AArch64 Pointer Authentication.
2303
2304 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2305
2306         * arm-linux-nat.c: Add include.
2307
2308 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2309
2310         * source-cache.c (source_cache::get_source_lines): Re-read
2311         fullname after calling open_source_file.
2312
2313 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2314
2315         * NEWS: Mention TLS support for FreeBSD.
2316
2317 2019-03-25  Tom Tromey  <tromey@adacore.com>
2318
2319         * minsyms.c (BUNCH_SIZE): Update comment.
2320         (~minimal_symbol_reader): Remove old comment.
2321         (compact_minimal_symbols): Update comment.
2322         (minimal_symbol_reader::install): Remove old comment.  Update
2323         other comments.
2324
2325 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2326
2327         * s390-linux-nat.c: Add include.
2328
2329 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2330
2331         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2332         Call linux_get_hwcap.
2333         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2334         Likewise.
2335         (aarch64_linux_get_hwcap): Remove function.
2336         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2337         declaration.
2338         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2339         linux_get_hwcap.
2340         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2341         * linux-tdep.c (linux_get_hwcap): Add function.
2342         (linux_get_hwcap2): Likewise.
2343         * linux-tdep.h (linux_get_hwcap): Add declaration.
2344         (linux_get_hwcap2): Likewise.
2345         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2346         (ppc_linux_get_hwcap2): Likewise.
2347         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2348         linux_get_hwcap.
2349         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2350         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2351         (ppc_linux_nat_target::read_description): Likewise.
2352         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2353         * s390-linux-nat.c: Likewise.
2354         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2355
2356 2019-03-24  Tom Tromey  <tom@tromey.com>
2357
2358         * ada-lang.c (standard_lookup): Simplify initialization.
2359         (ada_lookup_symbol_nonlocal): Simplify return.
2360         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2361         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2362         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2363         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2364         initialization.
2365         * solib.c (solib_global_lookup): Simplify.
2366         * symtab.c (null_block_symbol): Remove.
2367         (symbol_cache_lookup): Simplify returns.
2368         (lookup_language_this): Simplify returns.
2369         (lookup_symbol_aux): Simplify return.
2370         (lookup_local_symbol): Simplify returns.
2371         (lookup_global_symbol_from_objfile): Simplify return.
2372         (lookup_symbol_in_objfile_symtabs)
2373         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2374         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2375         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2376         * cp-namespace.c (cp_lookup_bare_symbol)
2377         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2378         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2379         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2380         (cp_lookup_symbol_via_imports): Simplify initialization.
2381         (find_symbol_in_baseclass): Likewise.
2382         * symtab.h (null_block_symbol): Remove.
2383         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2384         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2385         (d_lookup_symbol_module): Likewise.
2386         (find_symbol_in_baseclass): Simplify initialization.
2387
2388 2019-03-24  Tom Tromey  <tom@tromey.com>
2389
2390         * expression.h: Don't include symtab.h.
2391         (struct block): Forward declare.
2392
2393 2019-03-24  Tom Tromey  <tom@tromey.com>
2394
2395         * c-exp.y (typebase): Remove casts.
2396         * gdbtypes.c (lookup_unsigned_typename, )
2397         (lookup_signed_typename): Remove cast.
2398         * eval.c (parse_to_comma_and_eval): Remove cast.
2399         * parse.c (write_dollar_variable): Remove cast.
2400         * block.h (struct block) <superblock>: Now const.
2401         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2402         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2403         (map_block): Make "block" const.
2404         * symfile.h (struct quick_symbol_functions)
2405         <map_matching_symbols>: Constify block argument to "callback".
2406         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2407         const.
2408         (find_pc_sect_compunit_symtab): Make "b" const.
2409         (find_symbol_at_address): Likewise.
2410         (search_symbols): Likewise.
2411         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2412         (dw2_debug_names_lookup_symbol): Likewise.
2413         (dw2_map_matching_symbols): Update.
2414         * p-valprint.c (pascal_val_print): Remove "block".
2415         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2416         (aux_add_nonlocal_symbols): Make "block" const.
2417         (resolve_subexp): Remove cast.
2418         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2419         const.
2420         (iterate_over_file_blocks): Likewise.
2421         * f-exp.y (%union) <bval>: Remove.
2422         * coffread.c (patch_opaque_types): Make "b" const.
2423         * spu-tdep.c (spu_catch_start): Make "block" const.
2424         * c-valprint.c (print_unpacked_pointer): Remove "block".
2425         * symmisc.c (dump_symtab_1): Make "b" const.
2426         (block_depth): Make "block" const.
2427         * d-exp.y (%union) <bval>: Remove.
2428         * cp-support.h (cp_lookup_rtti_type): Update.
2429         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2430         * psymtab.c (psym_lookup_symbol): Make "block" const.
2431         (maintenance_check_psymtabs): Make "b" const.
2432         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2433         (enumerate_locals, enumerate_args): Update.
2434         * python/py-symtab.c (stpy_global_block): Make "block" const.
2435         (stpy_static_block): Likewise.
2436         * inline-frame.c (block_starting_point_at): Make "new_block"
2437         const.
2438         * block.c (find_block_in_blockvector): Make return type const.
2439         (blockvector_for_pc_sect): Make "b" const.
2440         (find_block_in_blockvector): Make "b" const.
2441
2442 2019-03-23  Tom Tromey  <tom@tromey.com>
2443
2444         * varobj.c (varobj_create): Update.
2445         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2446         * printcmd.c (display_command, do_one_display): Don't reset
2447         innermost_block.
2448         * parser-defs.h (enum innermost_block_tracker_type): Move to
2449         expression.h.
2450         (innermost_block): Update comment.
2451         * parse.c (parse_exp_1): Add tracker_types parameter.
2452         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2453         tracker_types parameter.  Reset innermost_block.
2454         (parse_exp_in_context): Remove.
2455         (parse_expression_for_completion): Update.
2456         * objfiles.c (~objfile): Don't reset expression_context_block or
2457         innermost_block.
2458         * expression.h (enum innermost_block_tracker_type): Move from
2459         parser-defs.h.
2460         (parse_exp_1): Add tracker_types parameter.
2461         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2462         reset innermost_block.
2463
2464 2019-03-23  Tom Tromey  <tom@tromey.com>
2465
2466         * objfiles.h: Include bcache.h.
2467
2468 2019-03-23  Tom Tromey  <tom@tromey.com>
2469
2470         * linespec.c (get_current_search_block): Use
2471         scoped_restore_current_language.
2472         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2473
2474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2475             Jiong Wang  <jiong.wang@arm.com>
2476
2477         * aarch64-linux-tdep.c
2478         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2479         section.
2480         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2481
2482 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2483             Jiong Wang  <jiong.wang@arm.com>
2484
2485         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2486         instructions.
2487         (aarch64_analyze_prologue_test): Add PACIASP test.
2488         (aarch64_prologue_prev_register): Unmask PC value.
2489
2490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2491             Jiong Wang  <jiong.wang@arm.com>
2492
2493         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2494         (aarch64_dwarf2_prev_register): Unmask PC value.
2495         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2496         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2497         DW_CFA_AARCH64_negate_ra_state.
2498         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2499
2500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2501             Jiong Wang  <jiong.wang@arm.com>
2502
2503         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2504         registers.
2505         (aarch64_pseudo_register_name): Likewise.
2506         (aarch64_pseudo_register_type): Likewise.
2507         (aarch64_pseudo_register_reggroup_p): Likewise.
2508         (aarch64_gdbarch_init): Add pauth registers.
2509         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2510         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2511         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2512         (struct gdbarch_tdep): Add regnum for ra_state.
2513
2514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2515             Jiong Wang  <jiong.wang@arm.com>
2516
2517         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2518
2519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2520             Jiong Wang  <jiong.wang@arm.com>
2521
2522         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2523         function.
2524         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2525         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2526         (aarch64_gdbarch_init): Add puth registers.
2527         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2528         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2529         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2530
2531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2532             Jiong Wang  <jiong.wang@arm.com>
2533
2534         * aarch64-linux-nat.c
2535         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2536         * aarch64-linux-tdep.c
2537         (aarch64_linux_core_read_description): Likewise.
2538         (aarch64_linux_get_hwcap): New function.
2539         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2540         (aarch64_linux_get_hwcap): New declaration.
2541
2542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2543             Jiong Wang  <jiong.wang@arm.com>
2544
2545         * aarch64-linux-nat.c
2546         (aarch64_linux_nat_target::read_description): Add pauth param.
2547         * aarch64-linux-tdep.c
2548         (aarch64_linux_core_read_description): Likewise.
2549         * aarch64-tdep.c (struct target_desc): Add in pauth.
2550         (aarch64_read_description): Add pauth param.
2551         (aarch64_gdbarch_init): Likewise.
2552         * aarch64-tdep.h (aarch64_read_description): Likewise.
2553         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2554         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2555         * features/Makefile: Add new files.
2556         * features/aarch64-pauth.c: New file.
2557         * features/aarch64-pauth.xml: New file.
2558
2559 2019-03-20  Tom Tromey  <tromey@adacore.com>
2560
2561         * infrun.c (handle_inferior_event): Rename from
2562         handle_inferior_event_1.  Create a scoped_value_mark.
2563         (handle_inferior_event): Remove.
2564
2565 2019-03-19  Tom Tromey  <tromey@adacore.com>
2566
2567         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2568         * infrun.h (print_stop_event): Add "displays" parameter.
2569         * infrun.c (print_stop_event): Add "displays" parameter.
2570
2571 2019-03-19  Pedro Alves  <palves@redhat.com>
2572
2573         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2574         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2575         to -1.  Fix TABs vs spaces.
2576         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2577         * tui/tui-out.h (tui_ui_out) Add intro comments.
2578         <m_line, m_start_of_line>: In-class initialize, and add describing
2579         comment.
2580
2581 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2582
2583         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2584         variable names.
2585         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2586
2587 2019-03-18  Pedro Alves  <palves@redhat.com>
2588             Eli Zaretskii <eliz@gnu.org>
2589
2590         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2591         m_line and m_start_of_line.
2592
2593 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2594
2595         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2596         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2597         it returns a newline.  This fixes a regression in TU mode, whereby
2598         the next line is output on the same screen line as the user input.
2599
2600 2019-03-18  Tom Tromey  <tromey@adacore.com>
2601
2602         * minsyms.c (minimal_symbol_reader::install): Remove call to
2603         obstack_blank.
2604
2605 2019-03-18  Pedro Alves  <palves@redhat.com>
2606
2607         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2608         New globals.
2609         (apply_style): New, factored out from ...
2610         (apply_ansi_escape): ... this.  Handle reverse video mode.
2611         (tui_set_reverse_mode): New function.
2612         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2613         * tui/tui-winsource.c (tui_show_source_line): Use
2614         tui_set_reverse_mode instead of setting A_STANDOUT.
2615         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2616         New setter methods.
2617
2618 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2619
2620         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2621         Handle tabs.
2622
2623 2019-03-18  Tom Tromey  <tromey@adacore.com>
2624
2625         * ada-lang.c (empty_array): Add "high" parameter.
2626         (ada_evaluate_subexp): Update.
2627
2628 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2629
2630         * unittests/string_view-selftests.c: Define
2631         _initialize_string_view_selftests unconditionally.
2632
2633 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2634
2635         PR gdb/24350
2636         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2637
2638 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2639
2640         PR gdb/24351
2641         * windows-nat.c (display_selector): Fix format specifiers.
2642
2643 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2644
2645         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2646         tui_refill_source_window instead of tui_refresh_win, to update the
2647         current execution line.  This fixes redisplay of the current line
2648         when stepping through the code with "next" or "step".
2649
2650 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2651
2652         * source-cache.c (source_cache::get_source_lines): Call
2653         find_source_lines to initialize s->nlines.  This fixes vertical
2654         scrolling of TUI source window when the DOWN arrow is pressed.
2655
2656 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2657
2658         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2659         linux-thread-db.c (_initialize_thread_db): Likewise.
2660
2661 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2662
2663         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2664         wclrtoeol in tui_show_source_line".  This reverts changes made in
2665         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2666
2667 2019-03-15  Tom Tromey  <tom@tromey.com>
2668
2669         * symtab.h (struct minimal_symbol): Derive from
2670         general_symbol_info.
2671         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2672         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2673         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2674         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2675         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2676         (MSYMBOL_SEARCH_NAME): Update.
2677         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2678         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2679         * minsyms.c (minimal_symbol_reader::record_full): Update.
2680
2681 2019-03-15  Tom Tromey  <tom@tromey.com>
2682
2683         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2684
2685 2019-03-15  Tom Tromey  <tom@tromey.com>
2686
2687         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2688         unique_xmalloc_ptr.
2689         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2690         Update.
2691         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2692         (build_minimal_symbol_hash_tables)
2693         (minimal_symbol_reader::install): Update.
2694
2695 2019-03-15  Tom Tromey  <tom@tromey.com>
2696
2697         * symtab.c (create_demangled_names_hash): Update.
2698         (symbol_set_names): Update.
2699         * objfiles.h (struct objfile_per_bfd_storage)
2700         <demangled_names_hash>: Now an htab_up.
2701         * objfiles.c (objfile_per_bfd_storage): Simplify.
2702
2703 2019-03-15  Tom Tromey  <tom@tromey.com>
2704
2705         * objfiles.h (struct objfile_per_bfd_storage): Declare
2706         destructor.
2707         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2708         New.
2709         (get_objfile_bfd_data): Use new.  Don't initialize
2710         language_of_main.
2711         (free_objfile_per_bfd_storage): Remove.
2712         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2713
2714 2019-03-15  Tom Tromey  <tom@tromey.com>
2715
2716         * symfile.c (reread_symbols): Update.
2717         * objfiles.c (objfile::objfile): Update.
2718         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2719         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2720         comment.
2721         (minimal_symbol_reader::install): Update.
2722         (terminate_minimal_symbol_table): Remove.
2723         * jit.c (jit_object_close_impl): Update.
2724
2725 2019-03-15  Tom Tromey  <tom@tromey.com>
2726
2727         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2728         initializations.
2729
2730 2019-03-15  Tom Tromey  <tom@tromey.com>
2731
2732         * objfiles.h (struct objfile_per_bfd_storage)
2733         <demangled_hash_languages>: Now a bitset.
2734         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2735         (lookup_minimal_symbol): Update.
2736
2737 2019-03-15  Tom Tromey  <tom@tromey.com>
2738
2739         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2740         Don't return the symbol.
2741         * coffread.c (record_minimal_symbol): Use record_full.
2742
2743 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2744
2745         The MS-Windows port of ncurses fails to switch to a color pair if
2746         one or both of the colors are the implicit default colors.  This
2747         change records the default colors when TUI is initialized, and
2748         then specifies them explicitly when a color pair uses the default
2749         colors.  This allows color styling in TUI mode on MS-Windows.
2750
2751         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2752         ncurses_norm_attr.
2753         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2754         colors in ncurses_norm_attr.
2755         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2756         "none", replace it with the default color recorded in
2757         ncurses_norm_attr.
2758
2759 2019-03-14  Tom Tromey  <tromey@adacore.com>
2760
2761         * source-cache.h (class source_cache) <get_source_lines>: Return
2762         std::string.
2763         * source-cache.c (source_cache::extract_lines): Handle case where
2764         first_pos==npos.  Return std::string.
2765         (source_cache::get_source_lines): Update.
2766
2767 2019-03-14  Tom Tromey  <tromey@adacore.com>
2768
2769         * NEWS: Add item for "style sources" commands.
2770         * source-cache.c (source_cache::get_source_lines): Check
2771         source_styling.
2772         * cli/cli-style.c (source_styling): New global.
2773         (_initialize_cli_style): Add "style sources" commands.
2774         (show_style_sources): New function.
2775         * cli/cli-style.h (source_styling): Declare.
2776
2777 2019-03-14  Pedro Alves  <palves@redhat.com>
2778             Tom Tromey  <tromey@adacore.com>
2779
2780         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2781         * tui/tui-winsource.c (tui_refill_source_window): New function,
2782         from...
2783         (tui_horizontal_source_scroll): ... here.  Move some logic.
2784         * cli/cli-style.c (set_style_enabled): Notify new observable.
2785         * tui/tui-hooks.c (tui_redisplay_source): New function.
2786         (tui_attach_detach_observers): Attach or detach
2787         tui_redisplay_source.
2788         * observable.h (source_styling_changed): New observable.
2789         * observable.c: Define source_styling_changed observable.
2790
2791 2019-03-13  Tom Tromey  <tromey@adacore.com>
2792
2793         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2794         (i386_gnu_nat_target::store_registers): Update.
2795         * target-debug.h (target_debug_print_std_string): New macro.
2796         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2797         * windows-tdep.c (display_one_tib): Update.
2798         * tui/tui-stack.c (tui_make_status_line): Update.
2799         * top.c (print_inferior_quit_action): Update.
2800         * thread.c (thr_try_catch_cmd): Update.
2801         (add_thread_with_info): Update.
2802         (thread_target_id_str): Update.
2803         (thr_try_catch_cmd): Update.
2804         (thread_command): Update.
2805         (thread_find_command): Update.
2806         * record-btrace.c (record_btrace_target::info_record)
2807         (record_btrace_resume_thread, record_btrace_target::resume)
2808         (record_btrace_cancel_resume, record_btrace_step_thread)
2809         (record_btrace_target::wait, record_btrace_target::wait)
2810         (record_btrace_target::wait, record_btrace_target::stop): Update.
2811         * progspace.c (print_program_space): Update.
2812         * process-stratum-target.c
2813         (process_stratum_target::thread_address_space): Update.
2814         * linux-fork.c (linux_fork_mourn_inferior)
2815         (detach_checkpoint_command, info_checkpoints_command)
2816         (linux_fork_context): Update.
2817         (linux_fork_detach): Update.
2818         (class scoped_switch_fork_info): Update.
2819         (delete_checkpoint_command): Update.
2820         * infrun.c (follow_fork_inferior): Update.
2821         (follow_fork_inferior): Update.
2822         (proceed_after_vfork_done): Update.
2823         (handle_vfork_child_exec_or_exit): Update.
2824         (follow_exec): Update.
2825         (displaced_step_prepare_throw): Update.
2826         (displaced_step_restore): Update.
2827         (start_step_over): Update.
2828         (resume_1): Update.
2829         (clear_proceed_status_thread): Update.
2830         (proceed): Update.
2831         (print_target_wait_results): Update.
2832         (do_target_wait): Update.
2833         (context_switch): Update.
2834         (stop_all_threads): Update.
2835         (restart_threads): Update.
2836         (finish_step_over): Update.
2837         (handle_signal_stop): Update.
2838         (switch_back_to_stepped_thread): Update.
2839         (keep_going_pass_signal): Update.
2840         (print_exited_reason): Update.
2841         (normal_stop): Update.
2842         * inferior.c (inferior_pid_to_str): Change return type.
2843         (print_selected_inferior): Update.
2844         (add_inferior): Update.
2845         (detach_inferior): Update.
2846         * dummy-frame.c (fprint_dummy_frames): Update.
2847         * dcache.c (dcache_info_1): Update.
2848         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2849         (btrace_fetch, btrace_clear): Update.
2850         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2851         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2852         type.
2853         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2854         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2855         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2856         * gdbarch.c, gdbarch.h: Rebuild.
2857         * gdbarch.sh (core_pid_to_str): Change return type.
2858         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2859         return type.
2860         (windows_nat_target::pid_to_str): Change return type.
2861         (windows_delete_thread): Update.
2862         (windows_nat_target::attach): Update.
2863         (windows_nat_target::files_info): Update.
2864         * target-delegates.c: Rebuild.
2865         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2866         return type.
2867         (sol_thread_target::pid_to_str): Change return type.
2868         * remote.c (class remote_target) <pid_to_str>: Change return
2869         type.
2870         (remote_target::pid_to_str): Change return type.
2871         (extended_remote_target::attach, remote_target::remote_stop_ns)
2872         (remote_target::remote_notif_remove_queued_reply)
2873         (remote_target::push_stop_reply, remote_target::disable_btrace):
2874         Update.
2875         (extended_remote_target::attach): Update.
2876         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2877         type.
2878         (gdbsim_target::pid_to_str): Change return type.
2879         * ravenscar-thread.c (struct ravenscar_thread_target)
2880         <pid_to_str>: Change return type.
2881         (ravenscar_thread_target::pid_to_str): Change return type.
2882         * procfs.c (class procfs_target) <pid_to_str>: Change return
2883         type.
2884         (procfs_target::pid_to_str): Change return type.
2885         (procfs_target::attach): Update.
2886         (procfs_target::detach): Update.
2887         (procfs_target::fetch_registers): Update.
2888         (procfs_target::store_registers): Update.
2889         (procfs_target::wait): Update.
2890         (procfs_target::files_info): Update.
2891         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2892         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2893         return type.
2894         (nto_procfs_target::pid_to_str): Change return type.
2895         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2896         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2897         return type.
2898         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2899         (exit_lwp): Update.
2900         (attach_proc_task_lwp_callback, get_detach_signal)
2901         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2902         (linux_nat_target::resume, wait_lwp, stop_callback)
2903         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2904         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2905         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2906         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2907         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2908         type.
2909         (inf_ptrace_target::attach): Update.
2910         (inf_ptrace_target::files_info): Update.
2911         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2912         type.
2913         (go32_nat_target::pid_to_str): Change return type.
2914         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2915         (gnu_nat_target::wait): Update.
2916         (gnu_nat_target::wait): Update.
2917         (gnu_nat_target::resume): Update.
2918         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2919         (fbsd_nat_target::wait): Update.
2920         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2921         type.
2922         (darwin_nat_target::attach): Update.
2923         * corelow.c (class core_target) <pid_to_str>: Change return type.
2924         (core_target::pid_to_str): Change return type.
2925         * target.c (normal_pid_to_str): Change return type.
2926         (default_pid_to_str): Likewise.
2927         (target_pid_to_str): Change return type.
2928         (target_translate_tls_address): Update.
2929         (target_announce_detach): Update.
2930         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2931         return type.
2932         (bsd_uthread_target::pid_to_str): Change return type.
2933         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2934         type.
2935         (bsd_kvm_target::pid_to_str): Change return type.
2936         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2937         return type.
2938         (aix_thread_target::pid_to_str): Change return type.
2939         * target.h (struct target_ops) <pid_to_str>: Change return type.
2940         (target_pid_to_str, normal_pid_to_str): Likewise.
2941         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2942         type.
2943         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2944         type.
2945         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2946         return type.
2947         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2948         type.
2949         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2950         type.
2951         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2952         return type.
2953
2954 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2955
2956         * NEWS: Mention that the new default MI version is 3.  Mention
2957         changes to the output of commands and events that deal with
2958         multi-location breakpoints.
2959         * breakpoint.c: Include "mi/mi-out.h".
2960         (print_one_breakpoint): Change output syntax if using MI version
2961         >= 3.
2962         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2963         New.
2964         (mi_multi_location_breakpoint_output_fixed): New.
2965         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2966         (mi_cmd_fix_multi_location_breakpoint_output): New.
2967         (mi_multi_location_breakpoint_output_fixed): New.
2968         * mi/mi-cmds.c (mi_cmds): Register command
2969         -fix-multi-location-breakpoint-output.
2970         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2971         interpreter "mi".
2972
2973 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2974
2975         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2976         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2977         instantiate mi_ui_out based on interpreter name.
2978         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2979         * mi/mi-main.c (mi_load_progress): Likewise.
2980
2981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2982
2983         * NEWS: Combine separate "New targets" sections for 8.3.
2984
2985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2986
2987         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2988         (ppcfbsd_init_abi): Install gdbarch
2989         "fetch_tls_load_module_address" and "get_thread_local_address"
2990         methods.
2991
2992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2993
2994         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2995         (riscv_fbsd_init_abi): Install gdbarch
2996         "fetch_tls_load_module_address" and "get_thread_local_address"
2997         methods.
2998
2999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3000
3001         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3002         (i386fbsd_init_abi): Install gdbarch
3003         "fetch_tls_load_module_address" and "get_thread_local_address"
3004         methods.
3005
3006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3007
3008         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3009         (amd64fbsd_init_abi): Install gdbarch
3010         "fetch_tls_load_module_address" and "get_thread_local_address"
3011         methods.
3012
3013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3014
3015         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3016         (struct fbsd_pspace_data): New type.
3017         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3018         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3019         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3020         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3021         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3022
3023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3024
3025         * gdbtypes.c (lookup_struct_elt): New function.
3026         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3027         * gdbtypes.h (struct struct_elt): New type.
3028         (lookup_struct_elt): New prototype.
3029
3030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3031
3032         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3033         remove disabled code block.
3034
3035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3036
3037         * gdbarch.sh (get_thread_local_address): New method.
3038         * gdbarch.h, gdbarch.c: Regenerate.
3039         * target.c (target_translate_tls_address): Use
3040         gdbarch_get_thread_local_address if present instead of
3041         target::get_thread_local_address.
3042
3043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3044
3045         * target.h (target::get_thread_local_address): Update comment.
3046
3047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3048
3049         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3050         objfile->separate_debug_objfile_backlink if not NULL.
3051
3052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3053
3054         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3055         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3056         (amd64bsd_store_inferior_registers): Likewise.
3057         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3058         Enable segment base registers.
3059         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3060         PT_GETFSBASE and PT_GETGSBASE.
3061         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3062         PT_SETGSBASE.
3063         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3064         segment base registers.
3065         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3066
3067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3068
3069         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3070         Update calls to i386_target_description to add 'segments'
3071         parameter.
3072         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3073         add segment base registers.
3074         * arch/i386.c (i386_create_target_description): Add 'segments'
3075         parameter to enable segment base registers.
3076         * arch/i386.h (i386_create_target_description): Likewise.
3077         * features/i386/32bit-segments.xml: New file.
3078         * features/i386/32bit-segments.c: Generate.
3079         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3080         call to i386_target_description to add 'segments' parameter.
3081         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3082         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3083         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3084         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3085         if feature is present.
3086         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3087         Add 'segments' parameter to call to i386_target_description.
3088         (i386_target_description): Add 'segments' parameter to enable
3089         segment base registers.
3090         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3091         to call to i386_target_description.
3092         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3093         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3094         Define I386_NUM_REGS.
3095         (i386_target_description): Add 'segments' parameter to enable
3096         segment base registers.
3097
3098 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3099
3100         PR/24325
3101         * source-cache.c: #undef open and close, to avoid unresolved
3102         externals during linking.
3103
3104 2019-03-12  Tom Tromey  <tromey@adacore.com>
3105
3106         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3107         const.  Add initializers.
3108         (_initialize_remote): Don't initialize ptid globals.
3109
3110 2019-03-12  Pedro Alves  <palves@redhat.com>
3111
3112         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3113
3114 2019-03-12  Pedro Alves  <palves@redhat.com>
3115
3116         * cp-name-parser.y (main): Remove unused 'len' variable.
3117
3118 2019-03-12  Tom Tromey  <tromey@adacore.com>
3119
3120         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3121         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3122
3123 2019-03-12  Tom Tromey  <tromey@adacore.com>
3124
3125         * linux-nat.c (iterate_over_lwps): Update.
3126         (stop_callback): Remove parameter.
3127         (stop_wait_callback, detach_callback, resume_set_callback)
3128         (select_singlestep_lwp_callback, set_ignore_sigint)
3129         (status_callback, resumed_callback, resume_clear_callback)
3130         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3131         data parameter.
3132         (linux_nat_target::detach, linux_nat_target::resume)
3133         (linux_stop_and_wait_all_lwps, select_event_lwp)
3134         (linux_nat_filter_event, linux_nat_wait_1)
3135         (linux_nat_target::kill, linux_nat_target::stop)
3136         (linux_nat_target::stop): Update.
3137         (linux_nat_resume_callback): Change type.
3138         (resume_stopped_resumed_lwps, count_events_callback)
3139         (select_event_lwp_callback): Likewise.
3140         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3141         * arm-linux-nat.c (struct update_registers_data): Remove.
3142         (update_registers_callback): Change type.
3143         (arm_linux_insert_hw_breakpoint1): Update.
3144         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3145         parameter.
3146         (x86_linux_dr_set_addr): Update.
3147         (x86_linux_dr_set_control): Update.
3148         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3149         (iterate_over_lwps): Use gdb::function_view.
3150         * nat/aarch64-linux-hw-point.c (struct
3151         aarch64_dr_update_callback_param): Remove.
3152         (debug_reg_change_callback): Change type.
3153         (aarch64_notify_debug_reg_change): Update.
3154         * s390-linux-nat.c (s390_refresh_per_info): Update.
3155
3156 2019-03-11  Tom Tromey  <tromey@adacore.com>
3157
3158         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3159         redundant assignment to "this_cu".
3160
3161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3162
3163         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3164
3165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3166
3167         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3168         from...
3169         (rank_one_type): ... this.
3170
3171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3174         from...
3175         (rank_one_type): ... this.
3176
3177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3178
3179         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3180         from...
3181         (rank_one_type): ... this.
3182
3183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3184
3185         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3186         from...
3187         (rank_one_type): ... this.
3188
3189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3190
3191         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3192         from...
3193         (rank_one_type): ... this.
3194
3195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3196
3197         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3198         from...
3199         (rank_one_type): ... this.
3200
3201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3204         from...
3205         (rank_one_type): ... this.
3206
3207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3208
3209         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3210         from...
3211         (rank_one_type): ... this.
3212
3213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3214
3215         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3216         from...
3217         (rank_one_type): ... this.
3218
3219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3220
3221         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3222         from...
3223         (rank_one_type): ... this.
3224
3225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3226
3227         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3228         from...
3229         (rank_one_type): ... this.
3230
3231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3232
3233         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3234         from...
3235         (rank_one_type): ... this.
3236
3237 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3238
3239         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3240         inferior-events' shows the example events.
3241
3242 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3243
3244         Support styling on native MS-Windows console
3245
3246         PR/24315
3247         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3248         on MS-Windows if $TERM is not defined.
3249
3250         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3251
3252         * posix-hdep.c (gdb_console_fputs):
3253         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3254         functions.
3255         * ui-file.h (gdb_console_fputs): Add prototype.
3256
3257         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3258         back to fputs only if the former returns zero.
3259
3260 2019-03-07  Tom Tromey  <tom@tromey.com>
3261
3262         * symmisc.c (print_symbol_bcache_statistics): Update.
3263         (print_objfile_statistics): Update.
3264         * symfile.c (allocate_symtab): Update.
3265         * stabsread.c: Don't include bcache.h.
3266         * psymtab.h (struct psymbol_bcache): Don't declare.
3267         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3268         (psymbol_bcache_init, psymbol_bcache_free)
3269         (psymbol_bcache_get_bcache): Don't declare.
3270         * psymtab.c (struct psymbol_bcache): Remove.
3271         (psymtab_storage::psymtab_storage): Update.
3272         (psymtab_storage::~psymtab_storage): Update.
3273         (psymbol_bcache_init, psymbol_bcache_free)
3274         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3275         (add_psymbol_to_bcache): Update.
3276         (allocate_psymtab): Update.
3277         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3278         macro_cache>: No longer pointers.
3279         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3280         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3281         * macrotab.c (macro_bcache): Update.
3282         * macroexp.c: Don't include bcache.h.
3283         * gdbtypes.c (check_types_worklist): Update.
3284         (types_deeply_equal): Remove TRY/CATCH.  Update.
3285         * elfread.c (elf_symtab_read): Update.
3286         * dwarf2read.c: Don't include bcache.h.
3287         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3288         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3289         (print_bcache_statistics, bcache_memory_used): Don't declare.
3290         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3291         methods.  Rename all data members.
3292         * bcache.c (struct bcache): Move to bcache.h.
3293         (bcache::expand_hash_table): Rename from expand_hash_table.
3294         (bcache): Remove.
3295         (bcache::insert): Rename from bcache_full.
3296         (bcache::compare): Rename from bcache_compare.
3297         (bcache_xmalloc): Remove.
3298         (bcache::~bcache): Rename from bcache_xfree.
3299         (bcache::print_statistics): Rename from print_bcache_statistics.
3300         (bcache::memory_used): Rename from bcache_memory_used.
3301
3302 2019-03-07  Pedro Alves  <palves@redhat.com>
3303
3304         * infrun.c (normal_stop): Also check for
3305         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3306
3307 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * f-lang.c (value_from_host_double): Moved to...
3310         * value.c (value_from_host_double): ...here.
3311         * value.h (value_from_host_double): Declare.
3312         * guile/scm-math.c (vlscm_convert_typed_number): Use
3313         value_from_host_double.
3314         (vlscm_convert_number): Likewise.
3315         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3316         * python/py-value.c (convert_value_from_python): Likewise.
3317
3318 2019-03-06  Tom Tromey  <tom@tromey.com>
3319
3320         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3321
3322 2019-03-06  Tom Tromey  <tom@tromey.com>
3323
3324         * utils.h (free_current_contents): Don't declare.
3325         * utils.c (free_current_contents): Remove.
3326
3327 2019-03-06  Tom Tromey  <tom@tromey.com>
3328
3329         * top.c (quit_force): Update.
3330         * main.c (captured_command_loop): Update.
3331         * common/new-op.c (operator new): Update.
3332         * common/common-exceptions.c (struct catcher)
3333         <save_cleanup_chain>: Remove member.
3334         (exceptions_state_mc_init): Update.
3335         (exception_try_scope_entry): Return nullptr.
3336         (exception_try_scope_exit, exception_rethrow)
3337         (throw_exception_sjlj, throw_exception_cxx): Update.
3338         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3339         (all_cleanups, do_cleanups, discard_cleanups)
3340         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3341         (restore_cleanups, restore_final_cleanups): Don't declare.
3342         (do_final_cleanups): Remove parameter.
3343         * common/cleanups.c (cleanup_chain, make_cleanup)
3344         (make_cleanup_dtor, all_cleanups, do_cleanups)
3345         (discard_my_cleanups, discard_cleanups)
3346         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3347         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3348         (null_cleanup): Remove.
3349         (do_final_cleanups): Remove parameter.
3350
3351 2019-03-06  Tom Tromey  <tom@tromey.com>
3352
3353         * remote.c (remote_target::remote_parse_stop_reply): Use
3354         unique_xmalloc_ptr.
3355
3356 2019-03-06  Tom Tromey  <tom@tromey.com>
3357
3358         * stabsread.c (struct stabs_field_info): Rename from field_info.
3359         <list, fnlist>: Add initializers.
3360         <obstack>: New member.
3361         (read_member_functions, read_struct_fields, read_baseclasses):
3362         Allocate on obstack.  Don't use cleanups.
3363         (read_one_struct_field, read_member_functions, read_struct_fields)
3364         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3365         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3366         (read_struct_type): Update.
3367
3368 2019-03-06  Tom Tromey  <tom@tromey.com>
3369
3370         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3371         * common/filestuff.h (make_cleanup_close): Don't declare.
3372         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3373         Remove.
3374
3375 2019-03-06  Tom Tromey  <tom@tromey.com>
3376
3377         * solib-aix.c: Use make_scope_exit.
3378
3379 2019-03-06  Tom Tromey  <tom@tromey.com>
3380
3381         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3382         Use make_scope_exit.
3383
3384 2019-03-06  Tom Tromey  <tom@tromey.com>
3385
3386         * solib-svr4.c (disable_probes_interface): Remove parameter.
3387         (svr4_handle_solib_event): Use make_scope_exit.
3388
3389 2019-03-06  Tom Tromey  <tom@tromey.com>
3390
3391         * remote.c (struct stop_reply_deleter): Remove.
3392         (stop_reply_up): Update.
3393         (struct stop_reply): Derive from notif_event.  Don't typedef.
3394         <regcache>: Now a std::vector.
3395         (stop_reply_xfree): Remove.
3396         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3397         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3398         (remote_target::discard_pending_stop_replies): Use delete.
3399         (remote_target::remote_parse_stop_reply): Update.
3400         (remote_target::process_stop_reply): Update.
3401         * remote-notif.h (struct notif_event): Add virtual destructor.
3402         Remove "dtr" member.
3403         (struct notif_client) <alloc_event>: Return a unique_ptr.
3404         (notif_event_xfree): Don't declare.
3405         (notif_event_up): New typedef.
3406         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3407         (notif_event_xfree, do_notif_event_xfree): Remove.
3408         (remote_notif_state_xfree): Update.
3409
3410 2019-03-06  Tom Tromey  <tom@tromey.com>
3411
3412         * infrun.c (displaced_step_clear_cleanup): Now a
3413         forward_scope_exit type.
3414         (displaced_step_prepare_throw): Update.
3415         (displaced_step_fixup): Update.
3416
3417 2019-03-06  Tom Tromey  <tom@tromey.com>
3418
3419         * inferior.h (class inferior): Update comment.
3420         * gdbthread.h (class thread_info): Update comment.
3421
3422 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3423             Tom Tromey  <tom@tromey.com>
3424
3425         * stabsread.h (struct stab_section_list): Remove.
3426         (coffstab_build_psymtabs): Update.
3427         * dbxread.c (symbuf_sections): Now a std::vector.
3428         (sect_idx): New global.
3429         (fill_symbuf): Update.
3430         (coffstab_build_psymtabs): Change type of stabsects parameter.
3431         Update.
3432         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3433         std::vector.
3434         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3435         (coff_locate_sections): Update.
3436         (coff_symfile_read): Remove cleanups.  Update.
3437         (init_stringtab): Add storage parameter.
3438         (free_stringtab, free_stringtab_cleanup): Remove.
3439         (init_lineno): Add storage parameter.
3440         (free_linetab, free_linetab_cleanup): Remove.
3441
3442 2019-03-06  Pedro Alves  <palves@redhat.com>
3443
3444         * linux-fork.c (fork_info::clobber_regs): Delete.
3445         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3446         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3447         comment.  Adjust.
3448         (scoped_switch_fork_info::scoped_switch_fork_info)
3449         (checkpoint_command, linux_fork_context): Adjust
3450         fork_save_infrun_state calls.
3451
3452 2019-03-06  Pedro Alves  <palves@redhat.com>
3453
3454         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3455         (inf_has_multiple_threads): Return 'bool' and rewrite using
3456         inferior_info::threads().
3457
3458 2019-03-06  Pedro Alves  <palves@redhat.com>
3459
3460         * linux-fork.c: Include <list>.
3461         (fork_list): Now a std::list instance.
3462         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3463         (forks_exist_p, find_last_fork): Adjust.
3464         (new_fork): Delete.
3465         (one_fork_p): New.
3466         (add_fork): Adjust.
3467         (free_fork): Delete, folded into fork_info::~fork_info().
3468         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3469         Adjust.
3470         (init_fork_list): Delete.
3471         (linux_fork_killall, linux_fork_mourn_inferior)
3472         (linux_fork_detach, info_checkpoints_command): Adjust.
3473         (_initialize_linux_fork): No longer call init_fork_list.
3474
3475 2019-03-06  Pedro Alves  <palves@redhat.com>
3476
3477         * linux-fork.c (new_fork): New, split out of ...
3478         (add_fork): ... this.  Return void.  Move "first fork" special
3479         case from here, to ...
3480         (checkpoint_command): ... here.
3481         * linux-linux.h (add_fork): Return void.
3482
3483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3486
3487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3488             Chris January  <chris.january@arm.com>
3489             David Lecomber  <david.lecomber@arm.com>
3490
3491         * f-exp.y: New token, UNOP_INTRINSIC.
3492         (exp): New pattern using UNOP_INTRINSIC token.
3493         (f77_keywords): Add 'abs' keyword.
3494         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3495         (value_from_host_double): New function.
3496         (evaluate_subexp_f): Support UNOP_ABS.
3497
3498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3501         types.
3502
3503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3506         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3507         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3508
3509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3512
3513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3514             Chris January  <chris.january@arm.com>
3515
3516         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3517         * f-exp.y: Define 'KIND' token.
3518         (exp): New pattern for KIND expressions.
3519         (ptype): Handle types with a kind extension.
3520         (direct_abs_decl): Extend to spot kind extensions.
3521         (f77_keywords): Add 'kind' to the list.
3522         (push_kind_type): New function.
3523         (convert_to_kind_type): New function.
3524         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3525         * parse.c (operator_length_standard): Likewise.
3526         * parser-defs.h (enum type_pieces): Add tp_kind.
3527         * std-operator.def: Add UNOP_KIND.
3528
3529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * f-exp.y (f_parse): Set yydebug.
3532
3533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3534
3535         * f-lang.c (evaluate_subexp_f): New function.
3536         (exp_descriptor_f): New global.
3537         (f_language_defn): Use exp_descriptor_f instead of
3538         exp_descriptor_standard.
3539
3540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * f-exp.y (struct token): Add comments.
3543         (dot_ops): Remove uppercase versions and the end marker.
3544         (f77_keywords): Likewise.
3545         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3546         entries in the dot_ops array are case insensitive, and use
3547         strncasecmp to compare strings.  Also some whitespace cleanup in
3548         this area.  Similar for the f77_keywords array, except entries in
3549         this list might be case sensitive.
3550
3551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * f-exp.y (struct f77_boolean_val): Add comments.
3554         (boolean_values): Remove uppercase versions, and end marker.
3555         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3556         and use strncasecmp to achieve case insensitivity.  Additionally,
3557         perform whitespace cleanup around this code.
3558
3559 2019-03-06  Tom Tromey  <tromey@adacore.com>
3560
3561         * remote-sim.c (gdbsim_target_open): Use result of
3562         gdb_argv::release.
3563
3564 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3565         Dirk Schubert  <dirk.schubert@arm.com>
3566         Chris January  <chris.january@arm.com>
3567
3568         * eval.c (evaluate_subexp_standard): Call Fortran argument
3569         wrapping logic.
3570         * f-lang.c (struct value): A value which can be passed into a
3571         Fortran function call.
3572         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3573         where appropriate.
3574         (struct type): Value ready for a Fortran function call.
3575         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3576         is needed.
3577         * f-lang.h (fortran_argument_convert): Declaration.
3578         (fortran_preserve_arg_pointer): Declaration.
3579         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3580
3581 2019-03-05  Tom Tromey  <tromey@adacore.com>
3582
3583         * python/py-prettyprint.c (print_string_repr): Remove #if.
3584         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3585
3586 2019-03-05  Tom Tromey  <tromey@adacore.com>
3587
3588         * target.c (the_dummy_target): Move later.  Change type to
3589         "dummy_target".
3590         (initialize_targets): Don't initialize the_dummy_target.
3591
3592 2019-03-05  Tom Tromey  <tromey@adacore.com>
3593
3594         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3595         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3596
3597 2019-03-05  Tom Tromey  <tromey@adacore.com>
3598
3599         * windows-nat.c (windows_nat_target::attach)
3600         (windows_nat_target::detach): Don't call gdb_flush.
3601         * valprint.c (generic_val_print, val_print, val_print_string):
3602         Don't call gdb_flush.
3603         * utils.c (defaulted_query): Don't call gdb_flush.
3604         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3605         * target.c (target_announce_detach): Don't call gdb_flush.
3606         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3607         * remote.c (extended_remote_target::attach): Don't call
3608         gdb_flush.
3609         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3610         * printcmd.c (do_examine): Don't call gdb_flush.
3611         (info_display_command): Don't call gdb_flush.
3612         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3613         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3614         * memattr.c (info_mem_command): Don't call gdb_flush.
3615         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3616         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3617         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3618         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3619         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3620         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3621         (gnu_nat_target::detach): Don't call gdb_flush.
3622         * f-valprint.c (f_val_print): Don't call gdb_flush.
3623         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3624         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3625         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3626         gdb_flush.
3627         * c-valprint.c (c_val_print): Don't call gdb_flush.
3628         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3629
3630 2019-03-05  Tom Tromey  <tromey@adacore.com>
3631
3632         * varobj.c (update_dynamic_varobj_children): Update.
3633         (install_default_visualizer): Use reset, not release.
3634         * value.c (set_internalvar): Update.
3635         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3636         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3637         ATTRIBUTE_UNUSED_RESULT.
3638
3639 2019-03-05  Tom Tromey  <tromey@adacore.com>
3640
3641         * remote.c (class scoped_remote_fd) <release>: Add
3642         ATTRIBUTE_UNUSED_RESULT.
3643
3644 2019-03-05  Tom Tromey  <tromey@adacore.com>
3645
3646         * macroexp.c (struct macro_buffer) <release>: Add
3647         ATTRIBUTE_UNUSED_RESULT.
3648
3649 2019-03-05  Tom Tromey  <tromey@adacore.com>
3650
3651         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3652         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3653         ATTRIBUTE_UNUSED_RESULT.
3654
3655 2019-03-05  Tom Tromey  <tromey@adacore.com>
3656
3657         * common/scoped_fd.h (class scoped_fd) <release>: Add
3658         ATTRIBUTE_UNUSED_RESULT.
3659
3660 2019-03-05  Tom Tromey  <tromey@adacore.com>
3661
3662         * parser-defs.h (struct parser_state) <release>: Add
3663         ATTRIBUTE_UNUSED_RESULT.
3664
3665 2019-03-05  Tom Tromey  <tromey@adacore.com>
3666
3667         * utils.h (class gdb_argv) <release>: Add
3668         ATTRIBUTE_UNUSED_RESULT.
3669         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3670
3671 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3672
3673         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3674         for-loop range, to avoid compiler warnings.
3675
3676         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3677         avoid compiler warnings about unused variables.
3678
3679         * NEWS: Mention end of support for native debugging on MS-Windows
3680         before XP.
3681
3682         PR gdb/24292
3683         * common/netstuff.c:
3684         * gdbserver/gdbreplay.c
3685         * gdbserver/remote-utils.c:
3686         * ser-tcp.c:
3687         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3688         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3689         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3690         'getaddrinfo' and 'freeaddrinfo' were not available before
3691         Windows XP, and mingw.org's MinGW headers by default define
3692         _WIN32_WINNT to 0x500.
3693
3694 2019-03-01  Gary Benson <gbenson@redhat.com>
3695
3696         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3697
3698 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3699             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3700
3701         PR gdb/8527
3702         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3703         set_sigint_trap, clear_sigint_trap.
3704
3705 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3706
3707         * target.c (target_detach): Clear the regcache and the
3708         frame cache.
3709
3710 2019-02-27  Pedro Alves  <palves@redhat.com>
3711
3712         * utils.c (set_screen_size): When we cap the height/width sizes,
3713         tweak the corresponding command variable to show "unlimited":
3714
3715 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3716             Pedro Alves  <palves@redhat.com>
3717
3718         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3719         before calling rl_set_screen_size.
3720
3721 2019-02-27  Tom Tromey  <tromey@adacore.com>
3722
3723         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3724         define.
3725         * python/py-value.c: Remove Python 2.4 workaround.
3726         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3727         workaround.
3728         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3729         Python 2.4 workaround.
3730         * python/python-internal.h: Remove Python 2.4 comment.
3731         (Py_ssize_t): Don't define.
3732         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3733         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3734         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3735         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3736         * python/python.c (do_start_initialization): Remove Python 2.4
3737         workaround.
3738         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3739         (print_children): Remove Python 2.4 workaround.
3740         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3741         workaround.
3742         (CHARBUFFERPROC_NAME): Remove.
3743         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3744         Python 2.4 workaround.
3745
3746 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3747
3748         * NEWS: Note minimum Python version.
3749
3750 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3751
3752         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3753         code from these functions.  Remove corresponding ifdefs.  Use
3754         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3755         Remove gotos and target of gotos.
3756         (infpy_search_memory): Likewise.
3757
3758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3761         (hppa_gdbarch_init): Don't register deleted functions with
3762         gdbarch.
3763
3764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3767         (h8300_unwind_sp): Delete.
3768         (h8300_dummy_id): Delete.
3769         (h8300_gdbarch_init): Don't register deleted functions with
3770         gdbarch.
3771
3772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3775         (ft32_unwind_pc): Delete.
3776         (ft32_unwind_sp): Delete.
3777         (ft32_gdbarch_init): Don't register deleted functions with
3778         gdbarch.
3779
3780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3781
3782         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3783         (frv_unwind_pc): Delete.
3784         (frv_unwind_sp): Delete.
3785         (frv_gdbarch_init): Don't register deleted functions with
3786         gdbarch.
3787
3788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3791         (riscv_unwind_pc): Delete.
3792         (riscv_unwind_sp): Delete.
3793         (riscv_gdbarch_init): Don't register deleted functions with
3794         gdbarch.
3795
3796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3799         (csky_unwind_pc): Delete.
3800         (csky_unwind_sp): Delete.
3801         (csky_gdbarch_init): Don't register deleted functions with
3802         gdbarch.
3803
3804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3807         (cris_unwind_pc): Delete.
3808         (cris_unwind_sp): Delete.
3809         (cris_gdbarch_init): Don't register deleted functions with
3810         gdbarch.
3811
3812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3815         (bfin_unwind_pc): Delete.
3816         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3817
3818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3821         (arm_unwind_pc): Delete.
3822         (arm_unwind_sp): Delete.
3823         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3824
3825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3828         (arc_unwind_pc): Delete.
3829         (arc_unwind_sp): Delete.
3830         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3831
3832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3833
3834         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3835         (alpha_unwind_pc): Delete.
3836         (alpha_gdbarch_init): Don't register deleted functions with
3837         gdbarch.
3838
3839 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3842         (aarch64_unwind_pc): Delete.
3843         (aarch64_unwind_sp): Delete.
3844         (aarch64_gdbarch_init): Don't register deleted functions with
3845         gdbarch.
3846
3847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * gdbtypes.c (type_align): Don't consider static members when
3850         computing structure alignment.
3851
3852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3855         return 0 for other types.
3856         * arch-utils.c (default_type_align): Always return 0.
3857         * gdbarch.h: Regenerate.
3858         * gdbarch.sh (type_align): Extend comment.
3859         * gdbtypes.c (type_align): Add additional comments, always call
3860         gdbarch_type_align before applying the default rules.
3861         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3862         generic code will then apply a suitable default.
3863         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3864         types, return 0 for other types.
3865
3866 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3867
3868         * NEWS: Create a new section for the next release branch.
3869         Rename the section of the current branch, now that it has
3870         been cut.
3871
3872 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3873
3874         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3875         * version.in: Bump version to 8.3.50.DATE-git.
3876
3877 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3878
3879         * aix-thread.c (ptid_cmp): Remove unused variable.
3880         (get_signaled_thread): Likewise.
3881         (store_regs_user_thread): Likewise.
3882         (store_regs_kernel_thread): Likewise.
3883         (fetch_regs_kernel_thread): Remove shadowed variable.
3884
3885 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * features/riscv/32bit-cpu.xml: Add register numbers.
3888         * features/riscv/32bit-fpu.c: Regenerate.
3889         * features/riscv/32bit-fpu.xml: Add register numbers.
3890         * features/riscv/64bit-cpu.xml: Add register numbers.
3891         * features/riscv/64bit-fpu.c: Regenerate.
3892         * features/riscv/64bit-fpu.xml: Add register numbers.
3893
3894 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3895
3896         * NEWS: Mention two argument form of gdb.Value constructor.
3897         * python/py-value.c (convert_buffer_and_type_to_value): New
3898         function.
3899         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3900         Add support for handling an optional second argument.  Call
3901         convert_buffer_and_type_to_value as appropriate.
3902         * python/python-internal.h (Py_buffer_deleter): New struct.
3903         (Py_buffer_up): New typedef.
3904
3905 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3906
3907         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3908         instead of releasing ownership.
3909
3910 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3911
3912         * dwarf2read.c (open_and_init_dwp_file): Call
3913         elf_numsections instead of bfd_count_sections to initialize
3914         dwp_file->num_sections.
3915
3916 2019-02-25  Tom Tromey  <tromey@adacore.com>
3917
3918         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3919
3920 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3921
3922         * gcore.in: Add '--readnever' option when invoking GDB.
3923
3924 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3925
3926         * MAINTAINERS: Update my email address.
3927
3928 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3929
3930         * build-id.c (build_id_to_debug_bfd_1): New function.
3931         (build_id_to_debug_bfd): Look for separate debug file in
3932         sysroot.
3933
3934 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * gdbarch.sh: Update the copyright year range that is placed into
3937         generated files.
3938
3939 2019-02-22  Keith Seitz  <keiths@redhat.com>
3940
3941         PR symtab/23853
3942         * linespec.c (create_sals_line_offset): Search for the default
3943         symtab's filename instead of its fullname.
3944
3945 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3946
3947         * NEWS: Update style defaults.
3948
3949 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3950
3951         * main.c (captured_main_1): Disable styling in batch mode.
3952
3953 2019-02-20  Tom Tromey  <tom@tromey.com>
3954
3955         * symtab.c (symtab_symbol_info): Fix typos.
3956
3957 2019-02-20  Tom Tromey  <tromey@adacore.com>
3958
3959         * findcmd.c (_initialize_mem_search): Use upper case for
3960         metasyntactic variables.
3961
3962 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3963
3964         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3965         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3966
3967 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3968
3969         * top.h (source_file_name): Change to std::string.
3970         * top.c (source_file_name): Likewise.
3971         (command_line_input): Adjust.
3972         * cli/cli-script.c (script_from_file): Adjust.
3973
3974 2019-02-19  Tom Tromey  <tromey@adacore.com>
3975
3976         * ravenscar-thread.c
3977         (ravenscar_thread_target::update_thread_list): Don't call
3978         ada_build_task_list.
3979         * ada-lang.h (ada_build_task_list): Don't declare.
3980         * ada-tasks.c (struct ada_tasks_inferior_data)
3981         <task_list_valid_p>: Now bool.
3982         (read_known_tasks, ada_task_list_changed)
3983         (ada_tasks_invalidate_inferior_data): Update.
3984         (read_known_tasks_array): Return bool.
3985         (read_known_tasks_list): Likewise.
3986         (read_known_tasks): Return void.
3987         (ada_build_task_list): Now static.
3988
3989 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3992         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3993
3994 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3995
3996         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3997         variant for ada_tasks_pspace_data_handle and
3998         ada_tasks_inferior_data_handle.
3999         (ada_tasks_pspace_data_cleanup): New function.
4000         (ada_tasks_inferior_data_cleanup): New function.
4001
4002 2019-02-17  Tom Tromey  <tom@tromey.com>
4003
4004         * macrotab.h (macro_source_fullname): Return a std::string.
4005         * macrotab.c (macro_include, check_for_redefinition)
4006         (macro_undef, macro_lookup_definition, foreach_macro)
4007         (foreach_macro_in_scope): Update.
4008         (macro_source_fullname): Return a std::string.
4009         * macrocmd.c (show_pp_source_pos): Update.
4010
4011 2019-02-17  Tom Tromey  <tom@tromey.com>
4012
4013         * macrocmd.c (show_pp_source_pos): Style the file names.
4014
4015 2019-02-17  Tom Tromey  <tom@tromey.com>
4016
4017         PR tui/24197:
4018         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4019
4020 2019-02-17  Tom Tromey  <tom@tromey.com>
4021
4022         * ada-lang.c (user_select_syms): Use filtered printing.
4023         * utils.c (wrap_style): New global.
4024         (desired_style): Remove.
4025         (emit_style_escape): Add stream parameter.
4026         (set_output_style, reset_terminal_style, prompt_for_continue):
4027         Update.
4028         (flush_wrap_buffer): Only flush gdb_stdout.
4029         (wrap_here): Set wrap_style.
4030         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4031         treat escape sequences as a character.  Change when wrap buffer is
4032         flushed.
4033         (fputs_styled): Do not set the output style when the default is
4034         requested.
4035         * ui-style.h (struct ui_file_style) <is_default>: New method.
4036         * source.c (print_source_lines_base): Emit escape sequences in one
4037         piece.
4038
4039 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4040
4041         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4042         integers and enumeration types.
4043
4044 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4045
4046         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4047         instead of lookup_symbol_in_language
4048         (do_exact_match): New function.
4049         (ada_get_symbol_name_matcher): Return do_exact_match when
4050         doing a verbatim match.
4051
4052 2019-02-15  Tom Tromey  <tromey@adacore.com>
4053
4054         * ravenscar-thread.c (ravenscar_thread_target::resume)
4055         (ravenscar_thread_target::wait): Special case wildcard requests.
4056
4057 2019-02-15  Tom Tromey  <tromey@adacore.com>
4058
4059         * ravenscar-thread.c (base_ptid): Remove.
4060         (struct ravenscar_thread_target) <close>: New method.
4061         <m_base_ptid>: New member.
4062         <update_inferior_ptid, active_task, task_is_currently_active,
4063         runtime_initialized>: Declare methods.
4064         <ravenscar_thread_target>: Add constructor.
4065         (ravenscar_thread_target::task_is_currently_active)
4066         (ravenscar_thread_target::update_inferior_ptid)
4067         (ravenscar_runtime_initialized): Rename.  Now methods.
4068         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4069         (ravenscar_thread_target::update_thread_list): Update.
4070         (ravenscar_thread_target::active_task): Now method.
4071         (ravenscar_thread_target::store_registers)
4072         (ravenscar_thread_target::prepare_to_store)
4073         (ravenscar_thread_target::prepare_to_store)
4074         (ravenscar_thread_target::mourn_inferior): Update.
4075         (ravenscar_inferior_created): Use "new" to create target.
4076         (ravenscar_thread_target::get_ada_task_ptid): Update.
4077         (_initialize_ravenscar): Don't initialize base_ptid.
4078         (ravenscar_ops): Remove global.
4079
4080 2019-02-15  Tom Tromey  <tromey@adacore.com>
4081
4082         * target.h (push_target): Declare new overload.
4083         * target.c (push_target): New overload, taking an rvalue reference.
4084         * remote.c (remote_target::open_1): Use push_target overload.
4085         * corelow.c (core_target_open): Use push_target overload.
4086
4087 2019-02-15  Tom Tromey  <tromey@adacore.com>
4088
4089         * ravenscar-thread.c (is_ravenscar_task)
4090         (ravenscar_task_is_currently_active): Return bool.
4091         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4092         (_initialize_ravenscar): Remove "(void)".
4093         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4094         Return bool.
4095
4096 2019-02-15  Tom Tromey  <tromey@adacore.com>
4097
4098         * ravenscar-thread.c (ravenscar_runtime_initializer)
4099         (has_ravenscar_runtime, get_running_thread_id)
4100         (ravenscar_thread_target::resume): Fix indentation.
4101
4102 2019-02-15  Tom Tromey  <tromey@adacore.com>
4103
4104         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4105         from ravenscar_arch_ops.
4106         (sparc_ravenscar_ops::fetch_registers)
4107         (sparc_ravenscar_ops::store_registers): Now methods.
4108         (sparc_ravenscar_prepare_to_store): Remove.
4109         (sparc_ravenscar_ops): Redefine.
4110         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4111         methods and destructor.  Remove members.
4112         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4113         (ravenscar_thread_target::store_registers)
4114         (ravenscar_thread_target::prepare_to_store): Update.
4115         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4116         Remove.
4117         (struct ppc_ravenscar_powerpc_ops): Derive from
4118         ravenscar_arch_ops.
4119         (ppc_ravenscar_powerpc_ops::fetch_registers)
4120         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4121         (ppc_ravenscar_powerpc_ops): Redefine.
4122         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4123         (ppc_ravenscar_e500_ops::fetch_registers)
4124         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4125         (ppc_ravenscar_e500_ops): Redefine.
4126         * aarch64-ravenscar-thread.c
4127         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4128         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4129         (aarch64_ravenscar_fetch_registers)
4130         (aarch64_ravenscar_store_registers): Now methods.
4131         (aarch64_ravenscar_ops): Redefine.
4132
4133 2019-02-15  Tom Tromey  <tromey@adacore.com>
4134
4135         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4136         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4137         (ravenscar_thread_target::stopped_by_watchpoint)
4138         (ravenscar_thread_target::stopped_data_address)
4139         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4140
4141 2019-02-15  Tom Tromey  <tromey@adacore.com>
4142
4143         * ravenscar-thread.c: Fix some typos.
4144
4145 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4146             Tom Tromey  <tromey@adacore.com>
4147
4148         * ada-lang.c (ada_exception_sal): Change addr_string to a
4149         std::string.
4150         (create_ada_exception_catchpoint): Update.
4151
4152 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4153             Tom Tromey  <tromey@adacore.com>
4154
4155         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4156         (bp_location_ops): Remove.
4157         (base_breakpoint_allocate_location): Update.
4158         (free_bp_location): Update.
4159         * ada-lang.c (class ada_catchpoint_location)
4160         <ada_catchpoint_location>: Remove ops parameter.
4161         (ada_catchpoint_location_dtor): Remove.
4162         (ada_catchpoint_location_ops): Remove.
4163         (allocate_location_exception): Update.
4164         * breakpoint.h (struct bp_location_ops): Remove.
4165         (class bp_location) <bp_location>: Remove bp_location_ops
4166         parameter.
4167         <~bp_location>: Add destructor.
4168         <ops>: Remove.
4169
4170 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4171             Pedro Alves  <palves@redhat.com>
4172
4173         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4174         'PATH_MAX'.
4175
4176 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4177             Samuel Thibault  <samuel.thibault@gnu.org>
4178             Thomas Schwinge  <thomas@codesourcery.com>
4179
4180         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4181         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4182
4183 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4184
4185         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4186         (check_empty): Use "const char *".
4187
4188         * gnu-nat.c (gnu_nat_target::detach): Instead of
4189         'detach_inferior (pid)' call
4190         'detach_inferior (find_inferior_pid (pid))'.
4191
4192         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4193         'nat/fork-inferior.o'.
4194         * gnu-nat.c: #include "nat/fork-inferior.h".
4195
4196         * gnu-nat.c (gnu_nat_target::detach): Instead of
4197         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4198         * gnu-nat.h: #include "inf-child.h".
4199         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4200         'i386_gnu_nat_target::fetch_registers'.
4201         (gnu_store_registers): Rename/move to
4202         'i386_gnu_nat_target::store_registers'.
4203
4204         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4205         * gnu-nat.h (mach_thread_info): New function.
4206         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4207
4208         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4209
4210 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4211
4212         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4213
4214 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4215
4216         * windows-nat.c (windows_add_thread): Add new parameter
4217         "main_thread_p" with default value set to false.  Update
4218         function documentation as well as all callers.
4219         (windows_delete_thread): Likewise.
4220         (fake_create_process): Update call to windows_add_thread.
4221         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4222         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4223         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4224         call to windows_delete_thread.
4225
4226 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4227
4228         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4229
4230 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4231
4232         * symfile.c (find_separate_debug_file): Use canonical path of
4233         sysroot with child_path instead of gdb_sysroot if it is valid.
4234
4235 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4236
4237         * symfile.c (find_separate_debug_file): Use child_path to
4238         determine if an object file is under a sysroot.
4239
4240 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4241
4242         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4243         unittests/child-path-selftests.c.
4244         * common/pathstuff.c (child_path): New function.
4245         * common/pathstuff.h (child_path): New prototype.
4246         * unittests/child-path-selftests.c: New file.
4247
4248 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4249
4250         * symfile.c (find_separate_debug_file): Look for separate debug
4251         files in debug directories under the sysroot.
4252
4253 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4254
4255         * symtab.h (struct minimal_symbol data_p): New const method.
4256         (struct minimal_symbol text_p): Likewise.
4257         * symtab.c (output_source_filename): Use file name style
4258         to print file name.
4259         (print_symbol_info): Likewise.
4260         (print_msymbol_info): Use address style to print addresses.
4261         Use function name style to print executable text symbols.
4262         (expand_symtab_containing_pc): Use data_p.
4263         (find_pc_sect_compunit_symtab): Likewise.
4264
4265 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4266
4267         * breakpoint.c (describe_other_breakpoints): Use address style
4268         to print addresses.
4269         (say_where): Likewise.
4270
4271 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4272
4273         * ada-typeprint.c (print_func_type): Print function name
4274         style to print function name.
4275         * c-typeprint.c (c_print_type_1): Likewise.
4276
4277 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4278
4279         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4280         for execve.
4281
4282 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4283
4284         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4285         type_stack.
4286
4287 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4288
4289         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4290         TYPE_CODE_REF types.
4291
4292 2019-02-08  Jim Wilson  <jimw@sifive.com>
4293
4294         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4295         (riscv_linux_fregset): New.
4296         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4297
4298 2019-02-07  Tom Tromey  <tom@tromey.com>
4299
4300         * thread.c (thread_cancel_execution_command): Update.
4301         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4302         methods.
4303         (struct thread_fsm_ops): Remove.
4304         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4305         (thread_fsm_should_stop, thread_fsm_return_value)
4306         (thread_fsm_set_finished, thread_fsm_finished_p)
4307         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4308         Don't declare.
4309         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4310         * infrun.c (clear_proceed_status_thread)
4311         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4312         (print_stop_event): Update.
4313         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4314         Add constructor.
4315         (step_command_fsm_ops): Remove.
4316         (new_step_command_fsm): Remove.
4317         (step_1): Update.
4318         (step_command_fsm::should_stop): Rename from
4319         step_command_fsm_should_stop.
4320         (step_command_fsm::clean_up): Rename from
4321         step_command_fsm_clean_up.
4322         (step_command_fsm::do_async_reply_reason): Rename from
4323         step_command_fsm_async_reply_reason.
4324         (struct until_next_fsm): Inherit from thread_fsm.  Add
4325         constructor.
4326         (until_next_fsm_ops): Remove.
4327         (new_until_next_fsm): Remove.
4328         (until_next_fsm::should_stop): Rename from
4329         until_next_fsm_should_stop.
4330         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4331         (until_next_fsm::do_async_reply_reason): Rename from
4332         until_next_fsm_async_reply_reason.
4333         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4334         constructor.  Change type of breakpoint.
4335         (finish_command_fsm_ops): Remove.
4336         (new_finish_command_fsm): Remove.
4337         (finish_command_fsm::should_stop): Rename from
4338         finish_command_fsm_should_stop.
4339         (finish_command_fsm::clean_up): Rename from
4340         finish_command_fsm_clean_up.
4341         (finish_command_fsm::return_value): Rename from
4342         finish_command_fsm_return_value.
4343         (finish_command_fsm::do_async_reply_reason): Rename from
4344         finish_command_fsm_async_reply_reason.
4345         (finish_command): Update.
4346         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4347         Add constructor.
4348         (call_thread_fsm_ops): Remove.
4349         (call_thread_fsm::call_thread_fsm): Rename from
4350         new_call_thread_fsm.
4351         (call_thread_fsm::should_stop): Rename from
4352         call_thread_fsm_should_stop.
4353         (call_thread_fsm::should_notify_stop): Rename from
4354         call_thread_fsm_should_notify_stop.
4355         (run_inferior_call, call_function_by_hand_dummy): Update.
4356         * cli/cli-interp.c (should_print_stop_to_console): Update.
4357         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4358         Add constructor.  Change type of location_breakpoint,
4359         caller_breakpoint.
4360         (until_break_fsm_ops): Remove.
4361         (new_until_break_fsm): Remove.
4362         (until_break_fsm::should_stop): Rename from
4363         until_break_fsm_should_stop.
4364         (until_break_fsm::clean_up): Rename from
4365         until_break_fsm_clean_up.
4366         (until_break_fsm::do_async_reply_reason): Rename from
4367         until_break_fsm_async_reply_reason.
4368         (until_break_command): Update.
4369         * thread-fsm.c: Remove.
4370         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4371
4372 2019-02-07  Tom Tromey  <tom@tromey.com>
4373
4374         * yy-remap.h: Add include guard.
4375         * xtensa-tdep.h: Add include guard.
4376         * xcoffread.h: Rename include guard.
4377         * varobj-iter.h: Add include guard.
4378         * tui/tui.h: Rename include guard.
4379         * tui/tui-winsource.h: Rename include guard.
4380         * tui/tui-wingeneral.h: Rename include guard.
4381         * tui/tui-windata.h: Rename include guard.
4382         * tui/tui-win.h: Rename include guard.
4383         * tui/tui-stack.h: Rename include guard.
4384         * tui/tui-source.h: Rename include guard.
4385         * tui/tui-regs.h: Rename include guard.
4386         * tui/tui-out.h: Rename include guard.
4387         * tui/tui-layout.h: Rename include guard.
4388         * tui/tui-io.h: Rename include guard.
4389         * tui/tui-hooks.h: Rename include guard.
4390         * tui/tui-file.h: Rename include guard.
4391         * tui/tui-disasm.h: Rename include guard.
4392         * tui/tui-data.h: Rename include guard.
4393         * tui/tui-command.h: Rename include guard.
4394         * tic6x-tdep.h: Add include guard.
4395         * target/waitstatus.h: Rename include guard.
4396         * target/wait.h: Rename include guard.
4397         * target/target.h: Rename include guard.
4398         * target/resume.h: Rename include guard.
4399         * target-float.h: Rename include guard.
4400         * stabsread.h: Add include guard.
4401         * rs6000-tdep.h: Add include guard.
4402         * riscv-fbsd-tdep.h: Add include guard.
4403         * regformats/regdef.h: Rename include guard.
4404         * record.h: Rename include guard.
4405         * python/python.h: Rename include guard.
4406         * python/python-internal.h: Rename include guard.
4407         * python/py-stopevent.h: Rename include guard.
4408         * python/py-ref.h: Rename include guard.
4409         * python/py-record.h: Rename include guard.
4410         * python/py-record-full.h: Rename include guard.
4411         * python/py-record-btrace.h: Rename include guard.
4412         * python/py-instruction.h: Rename include guard.
4413         * python/py-events.h: Rename include guard.
4414         * python/py-event.h: Rename include guard.
4415         * procfs.h: Add include guard.
4416         * proc-utils.h: Add include guard.
4417         * p-lang.h: Add include guard.
4418         * or1k-tdep.h: Rename include guard.
4419         * observable.h: Rename include guard.
4420         * nto-tdep.h: Rename include guard.
4421         * nat/x86-linux.h: Rename include guard.
4422         * nat/x86-linux-dregs.h: Rename include guard.
4423         * nat/x86-gcc-cpuid.h: Add include guard.
4424         * nat/x86-dregs.h: Rename include guard.
4425         * nat/x86-cpuid.h: Rename include guard.
4426         * nat/ppc-linux.h: Rename include guard.
4427         * nat/mips-linux-watch.h: Rename include guard.
4428         * nat/linux-waitpid.h: Rename include guard.
4429         * nat/linux-ptrace.h: Rename include guard.
4430         * nat/linux-procfs.h: Rename include guard.
4431         * nat/linux-osdata.h: Rename include guard.
4432         * nat/linux-nat.h: Rename include guard.
4433         * nat/linux-namespaces.h: Rename include guard.
4434         * nat/linux-btrace.h: Rename include guard.
4435         * nat/glibc_thread_db.h: Rename include guard.
4436         * nat/gdb_thread_db.h: Rename include guard.
4437         * nat/gdb_ptrace.h: Rename include guard.
4438         * nat/fork-inferior.h: Rename include guard.
4439         * nat/amd64-linux-siginfo.h: Rename include guard.
4440         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4441         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4442         * nat/aarch64-linux.h: Rename include guard.
4443         * nat/aarch64-linux-hw-point.h: Rename include guard.
4444         * mn10300-tdep.h: Add include guard.
4445         * mips-linux-tdep.h: Add include guard.
4446         * mi/mi-parse.h: Rename include guard.
4447         * mi/mi-out.h: Rename include guard.
4448         * mi/mi-main.h: Rename include guard.
4449         * mi/mi-interp.h: Rename include guard.
4450         * mi/mi-getopt.h: Rename include guard.
4451         * mi/mi-console.h: Rename include guard.
4452         * mi/mi-common.h: Rename include guard.
4453         * mi/mi-cmds.h: Rename include guard.
4454         * mi/mi-cmd-break.h: Rename include guard.
4455         * m2-lang.h: Add include guard.
4456         * location.h: Rename include guard.
4457         * linux-record.h: Rename include guard.
4458         * linux-nat.h: Add include guard.
4459         * linux-fork.h: Add include guard.
4460         * i386-darwin-tdep.h: Rename include guard.
4461         * hppa-linux-offsets.h: Add include guard.
4462         * guile/guile.h: Rename include guard.
4463         * guile/guile-internal.h: Rename include guard.
4464         * gnu-nat.h: Rename include guard.
4465         * gdb-stabs.h: Rename include guard.
4466         * frv-tdep.h: Add include guard.
4467         * f-lang.h: Add include guard.
4468         * event-loop.h: Add include guard.
4469         * darwin-nat.h: Rename include guard.
4470         * cp-abi.h: Rename include guard.
4471         * config/sparc/nm-sol2.h: Rename include guard.
4472         * config/nm-nto.h: Rename include guard.
4473         * config/nm-linux.h: Add include guard.
4474         * config/i386/nm-i386gnu.h: Rename include guard.
4475         * config/djgpp/nl_types.h: Rename include guard.
4476         * config/djgpp/langinfo.h: Rename include guard.
4477         * compile/gcc-cp-plugin.h: Add include guard.
4478         * compile/gcc-c-plugin.h: Add include guard.
4479         * compile/compile.h: Rename include guard.
4480         * compile/compile-object-run.h: Rename include guard.
4481         * compile/compile-object-load.h: Rename include guard.
4482         * compile/compile-internal.h: Rename include guard.
4483         * compile/compile-cplus.h: Rename include guard.
4484         * compile/compile-c.h: Rename include guard.
4485         * common/xml-utils.h: Rename include guard.
4486         * common/x86-xstate.h: Rename include guard.
4487         * common/version.h: Rename include guard.
4488         * common/vec.h: Rename include guard.
4489         * common/tdesc.h: Rename include guard.
4490         * common/selftest.h: Rename include guard.
4491         * common/scoped_restore.h: Rename include guard.
4492         * common/scoped_mmap.h: Rename include guard.
4493         * common/scoped_fd.h: Rename include guard.
4494         * common/safe-iterator.h: Rename include guard.
4495         * common/run-time-clock.h: Rename include guard.
4496         * common/refcounted-object.h: Rename include guard.
4497         * common/queue.h: Rename include guard.
4498         * common/ptid.h: Rename include guard.
4499         * common/print-utils.h: Rename include guard.
4500         * common/preprocessor.h: Rename include guard.
4501         * common/pathstuff.h: Rename include guard.
4502         * common/observable.h: Rename include guard.
4503         * common/netstuff.h: Rename include guard.
4504         * common/job-control.h: Rename include guard.
4505         * common/host-defs.h: Rename include guard.
4506         * common/gdb_wait.h: Rename include guard.
4507         * common/gdb_vecs.h: Rename include guard.
4508         * common/gdb_unlinker.h: Rename include guard.
4509         * common/gdb_unique_ptr.h: Rename include guard.
4510         * common/gdb_tilde_expand.h: Rename include guard.
4511         * common/gdb_sys_time.h: Rename include guard.
4512         * common/gdb_string_view.h: Rename include guard.
4513         * common/gdb_splay_tree.h: Rename include guard.
4514         * common/gdb_setjmp.h: Rename include guard.
4515         * common/gdb_ref_ptr.h: Rename include guard.
4516         * common/gdb_optional.h: Rename include guard.
4517         * common/gdb_locale.h: Rename include guard.
4518         * common/gdb_assert.h: Rename include guard.
4519         * common/filtered-iterator.h: Rename include guard.
4520         * common/filestuff.h: Rename include guard.
4521         * common/fileio.h: Rename include guard.
4522         * common/environ.h: Rename include guard.
4523         * common/common-utils.h: Rename include guard.
4524         * common/common-types.h: Rename include guard.
4525         * common/common-regcache.h: Rename include guard.
4526         * common/common-inferior.h: Rename include guard.
4527         * common/common-gdbthread.h: Rename include guard.
4528         * common/common-exceptions.h: Rename include guard.
4529         * common/common-defs.h: Rename include guard.
4530         * common/common-debug.h: Rename include guard.
4531         * common/cleanups.h: Rename include guard.
4532         * common/buffer.h: Rename include guard.
4533         * common/btrace-common.h: Rename include guard.
4534         * common/break-common.h: Rename include guard.
4535         * cli/cli-utils.h: Rename include guard.
4536         * cli/cli-style.h: Rename include guard.
4537         * cli/cli-setshow.h: Rename include guard.
4538         * cli/cli-script.h: Rename include guard.
4539         * cli/cli-interp.h: Rename include guard.
4540         * cli/cli-decode.h: Rename include guard.
4541         * cli/cli-cmds.h: Rename include guard.
4542         * charset-list.h: Add include guard.
4543         * buildsym-legacy.h: Rename include guard.
4544         * bfin-tdep.h: Add include guard.
4545         * ax.h: Rename include guard.
4546         * arm-linux-tdep.h: Add include guard.
4547         * arm-fbsd-tdep.h: Add include guard.
4548         * arch/xtensa.h: Rename include guard.
4549         * arch/tic6x.h: Add include guard.
4550         * arch/i386.h: Add include guard.
4551         * arch/arm.h: Rename include guard.
4552         * arch/arm-linux.h: Rename include guard.
4553         * arch/arm-get-next-pcs.h: Rename include guard.
4554         * arch/amd64.h: Add include guard.
4555         * arch/aarch64-insn.h: Rename include guard.
4556         * arch-utils.h: Rename include guard.
4557         * annotate.h: Add include guard.
4558         * amd64-darwin-tdep.h: Rename include guard.
4559         * aarch64-linux-tdep.h: Add include guard.
4560         * aarch64-fbsd-tdep.h: Add include guard.
4561         * aarch32-linux-nat.h: Add include guard.
4562
4563 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4564
4565         * macrotab.c (macro_define_internal): New function that
4566         factorizes macro_define_object_internal and macro_define_function
4567         code.
4568         (macro_define_object_internal): Use macro_define_internal.
4569         (macro_define_function): Likewise.
4570
4571 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4572
4573         * macrocmd.c (extract_identifier): Return
4574         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4575         callers.
4576
4577 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4578
4579         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4580
4581 2019-02-05  Tom Tromey  <tom@tromey.com>
4582
4583         * target.c (target_stack::unpush): Move assertion earlier.
4584
4585 2019-01-30  Tom Tromey  <tom@tromey.com>
4586
4587         PR python/23615:
4588         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4589         (gdbpy_parse_and_eval): Likewise.
4590         * python/python-internal.h (gdbpy_allow_threads): New class.
4591
4592 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4593
4594         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4595         (aarch64_fbsd_fpregmap): Move earlier.
4596         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4597         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4598         instead of individual calls to trad_frame_set_reg_addr.
4599         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4600         earlier.
4601         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4602         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4603         instead of individual calls to trad_frame_set_reg_addr.
4604
4605 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4606
4607         * CONTRIBUTE: Replace contribution list with wiki link.
4608
4609 2019-01-25  Tom Tromey  <tom@tromey.com>
4610
4611         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4612
4613 2019-01-25  Tom Tromey  <tom@tromey.com>
4614
4615         * xtensa-linux-nat.c: Fix common/ includes.
4616         * xml-support.h: Fix common/ includes.
4617         * xml-support.c: Fix common/ includes.
4618         * x86-linux-nat.c: Fix common/ includes.
4619         * windows-nat.c: Fix common/ includes.
4620         * varobj.h: Fix common/ includes.
4621         * varobj.c: Fix common/ includes.
4622         * value.c: Fix common/ includes.
4623         * valops.c: Fix common/ includes.
4624         * utils.c: Fix common/ includes.
4625         * unittests/xml-utils-selftests.c: Fix common/ includes.
4626         * unittests/utils-selftests.c: Fix common/ includes.
4627         * unittests/unpack-selftests.c: Fix common/ includes.
4628         * unittests/tracepoint-selftests.c: Fix common/ includes.
4629         * unittests/style-selftests.c: Fix common/ includes.
4630         * unittests/string_view-selftests.c: Fix common/ includes.
4631         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4632         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4633         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4634         * unittests/rsp-low-selftests.c: Fix common/ includes.
4635         * unittests/parse-connection-spec-selftests.c: Fix common/
4636         includes.
4637         * unittests/optional-selftests.c: Fix common/ includes.
4638         * unittests/offset-type-selftests.c: Fix common/ includes.
4639         * unittests/observable-selftests.c: Fix common/ includes.
4640         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4641         * unittests/memrange-selftests.c: Fix common/ includes.
4642         * unittests/memory-map-selftests.c: Fix common/ includes.
4643         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4644         * unittests/function-view-selftests.c: Fix common/ includes.
4645         * unittests/environ-selftests.c: Fix common/ includes.
4646         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4647         * unittests/common-utils-selftests.c: Fix common/ includes.
4648         * unittests/cli-utils-selftests.c: Fix common/ includes.
4649         * unittests/array-view-selftests.c: Fix common/ includes.
4650         * ui-file.c: Fix common/ includes.
4651         * tui/tui-io.c: Fix common/ includes.
4652         * tracepoint.h: Fix common/ includes.
4653         * tracepoint.c: Fix common/ includes.
4654         * tracefile-tfile.c: Fix common/ includes.
4655         * top.h: Fix common/ includes.
4656         * top.c: Fix common/ includes.
4657         * thread.c: Fix common/ includes.
4658         * target/waitstatus.h: Fix common/ includes.
4659         * target/waitstatus.c: Fix common/ includes.
4660         * target.h: Fix common/ includes.
4661         * target.c: Fix common/ includes.
4662         * target-memory.c: Fix common/ includes.
4663         * target-descriptions.c: Fix common/ includes.
4664         * symtab.h: Fix common/ includes.
4665         * symfile.c: Fix common/ includes.
4666         * stap-probe.c: Fix common/ includes.
4667         * spu-linux-nat.c: Fix common/ includes.
4668         * sparc-nat.c: Fix common/ includes.
4669         * source.c: Fix common/ includes.
4670         * solib.c: Fix common/ includes.
4671         * solib-target.c: Fix common/ includes.
4672         * ser-unix.c: Fix common/ includes.
4673         * ser-tcp.c: Fix common/ includes.
4674         * ser-pipe.c: Fix common/ includes.
4675         * ser-base.c: Fix common/ includes.
4676         * selftest-arch.c: Fix common/ includes.
4677         * s12z-tdep.c: Fix common/ includes.
4678         * rust-exp.y: Fix common/ includes.
4679         * rs6000-aix-tdep.c: Fix common/ includes.
4680         * riscv-tdep.c: Fix common/ includes.
4681         * remote.c: Fix common/ includes.
4682         * remote-notif.h: Fix common/ includes.
4683         * remote-fileio.h: Fix common/ includes.
4684         * remote-fileio.c: Fix common/ includes.
4685         * regcache.h: Fix common/ includes.
4686         * regcache.c: Fix common/ includes.
4687         * record-btrace.c: Fix common/ includes.
4688         * python/python.c: Fix common/ includes.
4689         * python/py-type.c: Fix common/ includes.
4690         * python/py-inferior.c: Fix common/ includes.
4691         * progspace.h: Fix common/ includes.
4692         * producer.c: Fix common/ includes.
4693         * procfs.c: Fix common/ includes.
4694         * proc-api.c: Fix common/ includes.
4695         * printcmd.c: Fix common/ includes.
4696         * ppc-linux-nat.c: Fix common/ includes.
4697         * parser-defs.h: Fix common/ includes.
4698         * osdata.c: Fix common/ includes.
4699         * obsd-nat.c: Fix common/ includes.
4700         * nat/x86-linux.c: Fix common/ includes.
4701         * nat/x86-linux-dregs.c: Fix common/ includes.
4702         * nat/x86-dregs.h: Fix common/ includes.
4703         * nat/x86-dregs.c: Fix common/ includes.
4704         * nat/ppc-linux.c: Fix common/ includes.
4705         * nat/mips-linux-watch.h: Fix common/ includes.
4706         * nat/mips-linux-watch.c: Fix common/ includes.
4707         * nat/linux-waitpid.c: Fix common/ includes.
4708         * nat/linux-ptrace.h: Fix common/ includes.
4709         * nat/linux-ptrace.c: Fix common/ includes.
4710         * nat/linux-procfs.c: Fix common/ includes.
4711         * nat/linux-personality.c: Fix common/ includes.
4712         * nat/linux-osdata.c: Fix common/ includes.
4713         * nat/linux-namespaces.c: Fix common/ includes.
4714         * nat/linux-btrace.h: Fix common/ includes.
4715         * nat/linux-btrace.c: Fix common/ includes.
4716         * nat/fork-inferior.c: Fix common/ includes.
4717         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4718         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4719         * nat/aarch64-linux.c: Fix common/ includes.
4720         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4721         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4722         * namespace.h: Fix common/ includes.
4723         * mips-linux-tdep.c: Fix common/ includes.
4724         * minsyms.c: Fix common/ includes.
4725         * mi/mi-parse.h: Fix common/ includes.
4726         * mi/mi-main.c: Fix common/ includes.
4727         * mi/mi-cmd-env.c: Fix common/ includes.
4728         * memrange.h: Fix common/ includes.
4729         * memattr.c: Fix common/ includes.
4730         * maint.h: Fix common/ includes.
4731         * maint.c: Fix common/ includes.
4732         * main.c: Fix common/ includes.
4733         * machoread.c: Fix common/ includes.
4734         * location.c: Fix common/ includes.
4735         * linux-thread-db.c: Fix common/ includes.
4736         * linux-nat.c: Fix common/ includes.
4737         * linux-fork.c: Fix common/ includes.
4738         * inline-frame.c: Fix common/ includes.
4739         * infrun.c: Fix common/ includes.
4740         * inflow.c: Fix common/ includes.
4741         * inferior.h: Fix common/ includes.
4742         * inferior.c: Fix common/ includes.
4743         * infcmd.c: Fix common/ includes.
4744         * inf-ptrace.c: Fix common/ includes.
4745         * inf-child.c: Fix common/ includes.
4746         * ia64-linux-nat.c: Fix common/ includes.
4747         * i387-tdep.c: Fix common/ includes.
4748         * i386-tdep.c: Fix common/ includes.
4749         * i386-linux-tdep.c: Fix common/ includes.
4750         * i386-linux-nat.c: Fix common/ includes.
4751         * i386-go32-tdep.c: Fix common/ includes.
4752         * i386-fbsd-tdep.c: Fix common/ includes.
4753         * i386-fbsd-nat.c: Fix common/ includes.
4754         * guile/scm-type.c: Fix common/ includes.
4755         * guile/guile.c: Fix common/ includes.
4756         * go32-nat.c: Fix common/ includes.
4757         * gnu-nat.c: Fix common/ includes.
4758         * gdbthread.h: Fix common/ includes.
4759         * gdbarch-selftests.c: Fix common/ includes.
4760         * gdb_usleep.c: Fix common/ includes.
4761         * gdb_select.h: Fix common/ includes.
4762         * gdb_bfd.c: Fix common/ includes.
4763         * gcore.c: Fix common/ includes.
4764         * fork-child.c: Fix common/ includes.
4765         * findvar.c: Fix common/ includes.
4766         * fbsd-nat.c: Fix common/ includes.
4767         * event-top.c: Fix common/ includes.
4768         * event-loop.c: Fix common/ includes.
4769         * dwarf2read.c: Fix common/ includes.
4770         * dwarf2loc.c: Fix common/ includes.
4771         * dwarf2-frame.c: Fix common/ includes.
4772         * dwarf-index-cache.c: Fix common/ includes.
4773         * dtrace-probe.c: Fix common/ includes.
4774         * disasm-selftests.c: Fix common/ includes.
4775         * defs.h: Fix common/ includes.
4776         * csky-tdep.c: Fix common/ includes.
4777         * cp-valprint.c: Fix common/ includes.
4778         * cp-support.h: Fix common/ includes.
4779         * cp-support.c: Fix common/ includes.
4780         * corelow.c: Fix common/ includes.
4781         * completer.h: Fix common/ includes.
4782         * completer.c: Fix common/ includes.
4783         * compile/compile.c: Fix common/ includes.
4784         * compile/compile-loc2c.c: Fix common/ includes.
4785         * compile/compile-cplus-types.c: Fix common/ includes.
4786         * compile/compile-cplus-symbols.c: Fix common/ includes.
4787         * command.h: Fix common/ includes.
4788         * cli/cli-dump.c: Fix common/ includes.
4789         * cli/cli-cmds.c: Fix common/ includes.
4790         * charset.c: Fix common/ includes.
4791         * build-id.c: Fix common/ includes.
4792         * btrace.h: Fix common/ includes.
4793         * btrace.c: Fix common/ includes.
4794         * breakpoint.h: Fix common/ includes.
4795         * breakpoint.c: Fix common/ includes.
4796         * ax.h:
4797         (enum agent_op): Fix common/ includes.
4798         * ax-general.c (struct aop_map): Fix common/ includes.
4799         * ax-gdb.c: Fix common/ includes.
4800         * auxv.c: Fix common/ includes.
4801         * auto-load.c: Fix common/ includes.
4802         * arm-tdep.c: Fix common/ includes.
4803         * arch/riscv.c: Fix common/ includes.
4804         * arch/ppc-linux-common.c: Fix common/ includes.
4805         * arch/i386.c: Fix common/ includes.
4806         * arch/arm.c: Fix common/ includes.
4807         * arch/arm-linux.c: Fix common/ includes.
4808         * arch/arm-get-next-pcs.c: Fix common/ includes.
4809         * arch/amd64.c: Fix common/ includes.
4810         * arch/aarch64.c: Fix common/ includes.
4811         * arch/aarch64-insn.c: Fix common/ includes.
4812         * arch-utils.c: Fix common/ includes.
4813         * amd64-windows-tdep.c: Fix common/ includes.
4814         * amd64-tdep.c: Fix common/ includes.
4815         * amd64-sol2-tdep.c: Fix common/ includes.
4816         * amd64-obsd-tdep.c: Fix common/ includes.
4817         * amd64-nbsd-tdep.c: Fix common/ includes.
4818         * amd64-linux-tdep.c: Fix common/ includes.
4819         * amd64-linux-nat.c: Fix common/ includes.
4820         * amd64-fbsd-tdep.c: Fix common/ includes.
4821         * amd64-fbsd-nat.c: Fix common/ includes.
4822         * amd64-dicos-tdep.c: Fix common/ includes.
4823         * amd64-darwin-tdep.c: Fix common/ includes.
4824         * agent.c: Fix common/ includes.
4825         * ada-lang.h: Fix common/ includes.
4826         * ada-lang.c: Fix common/ includes.
4827         * aarch64-tdep.c: Fix common/ includes.
4828
4829 2019-01-25  Tom Tromey  <tom@tromey.com>
4830
4831         * common/create-version.sh: Use common/version.h.
4832
4833 2019-01-24  Pedro Alves  <palves@redhat.com>
4834
4835         * infrun.c (signal_stop, signal_print, signal_program)
4836         (signal_catch, signal_pass): Now arrays instead of pointers.
4837         (update_signals_program_target, do_target_resume)
4838         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4839         * linux-nat.c (linux_nat_target::pass_signals)
4840         (linux_nat_target::create_inferior, linux_nat_target::attach):
4841         Adjust.
4842         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4843         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4844         * procfs.c (procfs_target::pass_signals): Adjust.
4845         * record-full.c (record_full_target::resume): Adjust.
4846         * remote.c (remote_target::pass_signals)
4847         (remote_target::program_signals): Adjust.
4848         * target-debug.h (target_debug_print_signals): Now takes a
4849         gdb::array_view as parameter.  Adjust.
4850         * target.h (target_ops) <pass_signals, program_signals>: Replace
4851         pointer and length parameters with gdb::array_view.
4852         (target_pass_signals, target_program_signals): Likewise.
4853         * target-delegates.c: Regenerate.
4854
4855 2019-01-24  Pedro Alves  <palves@redhat.com>
4856
4857         * common/forward-scope-exit.h
4858         (forward_scope_exit::forward_scope_exit): Pass arguments to
4859         m_bind_function directly, instead of creating a std::bind and
4860         copying that.
4861
4862 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4863
4864         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4865         for static members.
4866         (pass_in_v_vfp_candidate): Likewise.
4867
4868 2019-01-23  Tom Tromey  <tom@tromey.com>
4869             Pedro Alves  <palves@redhat.com>
4870
4871         * regcache.c (class regcache_invalidator): Remove.
4872         (regcache::raw_write): Use make_scope_exit.
4873
4874 2019-01-23  Tom Tromey  <tom@tromey.com>
4875
4876         * ui-out.h (class ui_out_emit_type): Update comment.
4877
4878 2019-01-23  Tom Tromey  <tom@tromey.com>
4879
4880         * infrun.c (fetch_inferior_event): Update comment.
4881
4882 2019-01-23  Tom Tromey  <tom@tromey.com>
4883             Pedro Alves  <palves@redhat.com>
4884
4885         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4886         parameter.
4887         (fetch_inferior_event): Use SCOPE_EXIT.
4888
4889
4890 2019-01-23  Tom Tromey  <tom@tromey.com>
4891             Pedro Alves  <palves@redhat.com>
4892
4893         * infrun.c (disable_thread_events): Delete.
4894         (stop_all_threads): Use SCOPE_EXIT.
4895
4896 2019-01-23  Tom Tromey  <tom@tromey.com>
4897             Pedro Alves  <palves@redhat.com>
4898
4899         * symfile.c: Include forward-scope-exit.h.
4900         (clear_symtab_users_cleanup): Replace forward declaration with
4901         a FORWARD_SCOPE_EXIT.
4902         (syms_from_objfile_1): Use the forward_scope_exit and
4903         gdb::optional instead of cleanup_function.
4904         (reread_symbols): Use the forward_scope_exit instead of
4905         cleanup_function.
4906         (clear_symtab_users_cleanup): Remove function.
4907
4908 2019-01-23  Tom Tromey  <tom@tromey.com>
4909             Pedro Alves  <palves@redhat.com>
4910
4911         * linux-nat.c: Include scope-exit.h.
4912         (cleanup_target_stop): Remove.
4913         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4914         SCOPE_EXIT.
4915
4916 2019-01-23  Tom Tromey  <tom@tromey.com>
4917             Pedro Alves  <palves@redhat.com>
4918
4919         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4920         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4921
4922 2019-01-23  Tom Tromey  <tom@tromey.com>
4923             Andrew Burgess  <andrew.burgess@embecosm.com>
4924             Pedro Alves  <palves@redhat.com>
4925
4926         * infrun.c (fetch_inferior_event): Use scope_exit.
4927         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4928         * top.c (execute_command): Use scope_exit.
4929         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4930         * utils.c (do_bpstat_clear_actions_cleanup)
4931         (make_bpstat_clear_actions_cleanup): Remove.
4932
4933 2019-01-23  Tom Tromey  <tom@tromey.com>
4934             Pedro Alves  <palves@redhat.com>
4935
4936         * infrun.c: Include "common/scope-exit.h"
4937         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4938         (wait_for_inferior): Use SCOPE_EXIT.
4939         (fetch_inferior_event): Use scope_exit.
4940
4941 2019-01-23  Tom Tromey  <tom@tromey.com>
4942             Pedro Alves  <palves@redhat.com>
4943
4944         * breakpoint.c (create_breakpoint): Remove cleanup.
4945
4946 2019-01-23  Tom Tromey  <tom@tromey.com>
4947             Andrew Burgess  <andrew.burgess@embecosm.com>
4948             Pedro Alves  <palves@redhat.com>
4949
4950 2019-01-23  Pedro Alves  <palves@redhat.com>
4951
4952         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4953
4954 2019-01-23  Pedro Alves  <palves@redhat.com>
4955             Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * gdbthread.h: Include "common/forward-scope-exit.h".
4958         (scoped_finish_thread_state): Redefine custom class in terms of
4959         forward_scope_exit.
4960
4961 2019-01-23  Pedro Alves  <palves@redhat.com>
4962             Andrew Burgess  <andrew.burgess@embecosm.com>
4963
4964         * common/forward-scope-exit.h: New file.
4965
4966 2019-01-23  Pedro Alves  <palves@redhat.com>
4967             Andrew Burgess  <andrew.burgess@embecosm.com>
4968             Tom Tromey  <tom@tromey.com>
4969
4970         * common/scope-exit.h: New file.
4971
4972 2019-01-23  Pedro Alves  <palves@redhat.com>
4973
4974         * common/preprocessor.h (ESC): Rename to ...
4975         (ESC_PARENS): ... this.
4976         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4977         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4978
4979 2019-01-23  Tom Tromey  <tom@tromey.com>
4980
4981         * language.h (class scoped_switch_to_sym_language_if_auto):
4982         Initialize m_lang in both cases.
4983
4984 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4985
4986         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4987         with XCNEW.
4988
4989 2019-01-22  Tom Tromey  <tom@tromey.com>
4990
4991         * corelow.c: Do not include sys/file.h.
4992
4993 2019-01-22  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-wingeneral.h: Include gdb_curses.h.
4996
4997 2019-01-22  Tom Tromey  <tom@tromey.com>
4998
4999         * source-cache.h (class source_cache) <get_source_lines,
5000         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5001
5002 2019-01-22  Tom Tromey  <tom@tromey.com>
5003
5004         * remote-fileio.h (struct remote_target): Declare.
5005
5006 2019-01-22  Tom Tromey  <tom@tromey.com>
5007
5008         * python/py-arch.c: Do not include py-ref.h.
5009         * python/py-bpevent.c: Do not include py-ref.h.
5010         * python/py-cmd.c: Do not include py-ref.h.
5011         * python/py-continueevent.c: Do not include py-ref.h.
5012         * python/py-event.h: Do not include py-ref.h.
5013         * python/py-evtregistry.c: Do not include py-ref.h.
5014         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5015         * python/py-frame.c: Do not include py-ref.h.
5016         * python/py-framefilter.c: Do not include py-ref.h.
5017         * python/py-function.c: Do not include py-ref.h.
5018         * python/py-infevents.c: Do not include py-ref.h.
5019         * python/py-linetable.c: Do not include py-ref.h.
5020         * python/py-objfile.c: Do not include py-ref.h.
5021         * python/py-param.c: Do not include py-ref.h.
5022         * python/py-prettyprint.c: Do not include py-ref.h.
5023         * python/py-progspace.c: Do not include py-ref.h.
5024         * python/py-symbol.c: Do not include py-ref.h.
5025         * python/py-symtab.c: Do not include py-ref.h.
5026         * python/py-type.c: Do not include py-ref.h.
5027         * python/py-unwind.c: Do not include py-ref.h.
5028         * python/py-utils.c: Do not include py-ref.h.
5029         * python/py-value.c: Do not include py-ref.h.
5030         * python/py-varobj.c: Do not include py-ref.h.
5031         * python/py-xmethods.c: Do not include py-ref.h.
5032         * python/python.c: Do not include py-ref.h.
5033         * varobj.c: Do not include py-ref.h.
5034
5035 2019-01-22  Tom Tromey  <tom@tromey.com>
5036
5037         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5038         keyword for bcache.
5039
5040 2019-01-22  Tom Tromey  <tom@tromey.com>
5041
5042         * compile/compile-cplus-types.c: Remove a comment by #include.
5043
5044 2019-01-22  Tom Tromey  <tom@tromey.com>
5045
5046         * compile/gcc-c-plugin.h: Include compile-internal.h.
5047
5048 2019-01-22  Tom Tromey  <tom@tromey.com>
5049
5050         * stabsread.c (EXTERN): Do not define.
5051         (symnum, next_symbol_text_func, processing_gcc_compilation)
5052         (within_function, global_sym_chain, global_stabs)
5053         (previous_stab_code, this_object_header_files)
5054         (n_this_object_header_files)
5055         (n_allocated_this_object_header_files): Define.
5056         * stabsread.h (EXTERN): Never define.  Use "extern".
5057
5058 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5059
5060         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5061         history_value.
5062
5063 2019-01-21  Tom Tromey  <tom@tromey.com>
5064
5065         * ui-out.c: Fix includes.
5066         * tui/tui-source.c: Fix includes.
5067         * target.c: Fix includes.
5068         * remote.c: Fix includes.
5069         * regcache.c: Fix includes.
5070         * python/py-block.c: Fix includes.
5071         * printcmd.c: Fix includes.
5072         * or1k-tdep.c: Fix includes.
5073         * mi/mi-main.c: Fix includes.
5074         * m32r-tdep.c: Fix includes.
5075         * csky-tdep.c: Fix includes.
5076         * compile/compile-cplus-types.c: Fix includes.
5077         * cli/cli-interp.c: Fix includes.
5078
5079 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5080
5081         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5082         for padding.
5083
5084 2019-01-16  Tom Tromey  <tom@tromey.com>
5085
5086         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5087         earlier.
5088         (struct objfile) <msymbols_range>: Move from top level.
5089         <msymbols>: New method.
5090         (class objfile_msymbols): Remove.
5091         * symtab.c (default_collect_symbol_completion_matches_break_on):
5092         Update.
5093         * symmisc.c (dump_msymbols): Update.
5094         * stabsread.c (scan_file_globals): Update.
5095         * objc-lang.c (info_selectors_command, info_classes_command)
5096         (find_methods): Update.
5097         * minsyms.c (find_solib_trampoline_target): Update.
5098         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5099         * coffread.c (coff_symfile_read): Update.
5100         * ada-lang.c (ada_lookup_simple_minsym)
5101         (ada_collect_symbol_completion_matches): Update.
5102
5103 2019-01-16  Tom Tromey  <tom@tromey.com>
5104
5105         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5106         type.  Remove no-argument constructor.
5107         <iterator::operator++>: Simplify.
5108         <begin>: Update.
5109         <end>: Use minimal_symbol_count.
5110
5111 2019-01-16  Tom Tromey  <tom@tromey.com>
5112
5113         * objfiles.h (struct objfile) <psymtabs>: New method.
5114         (class objfile_psymtabs): Remove.
5115         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5116         typedef.
5117         <range>: New method.
5118         (require_partial_symbols): Change return type.
5119         * psymtab.c (require_partial_symbols)
5120         (psym_expand_symtabs_matching): Update.
5121         * mdebugread.c (parse_partial_symbols): Update.
5122         * dbxread.c (dbx_end_psymtab): Update.
5123
5124 2019-01-15  Tom Tromey  <tom@tromey.com>
5125
5126         * symtab.c (lookup_objfile_from_block)
5127         (lookup_symbol_in_objfile_symtabs)
5128         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5129         (find_line_symtab, info_sources_command)
5130         (default_collect_symbol_completion_matches_break_on)
5131         (make_source_files_completion_list): Update.
5132         * symmisc.c (print_objfile_statistics, dump_objfile)
5133         (maintenance_print_symbols, maintenance_info_symtabs)
5134         (maintenance_check_symtabs, maintenance_info_line_tables):
5135         Update.
5136         * source.c (select_source_symtab)
5137         (forget_cached_source_info_for_objfile): Update.
5138         * objfiles.h (class objfile_compunits): Remove.
5139         (struct objfile) <compunits_range>: New typedef.
5140         (compunits): New method.
5141         * objfiles.c (objfile_relocate1): Update.
5142         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5143         * maint.c (count_symtabs_and_blocks): Update.
5144         * linespec.c (iterate_over_all_matching_symtabs): Update.
5145         * cp-support.c (add_symbol_overload_list_qualified): Update.
5146         * coffread.c (coff_symtab_read): Update.
5147         * ada-lang.c (add_nonlocal_symbols)
5148         (ada_collect_symbol_completion_matches)
5149         (ada_add_global_exceptions): Update.
5150
5151 2019-01-15  Tom Tromey  <tom@tromey.com>
5152
5153         * progspace.h (program_space) <objfiles_safe_range>: New
5154         typedef.
5155         <objfiles_safe>: New method.
5156         * objfiles.h (class all_objfiles_safe): Remove.
5157         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5158         * jit.c (jit_inferior_exit_hook): Update.
5159
5160 2019-01-17  Tom Tromey  <tom@tromey.com>
5161
5162         * progspace.h (program_space) <objfiles_range>: New typedef.
5163         <objfiles>: New method.
5164         <objfiles_head>: Rename from objfiles.
5165         (object_files): Update.
5166         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5167         * guile/scm-pretty-print.c
5168         (ppscm_find_pretty_printer_from_objfiles): Update.
5169         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5170         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5171         Update.
5172         * python/py-progspace.c (pspy_get_objfiles): Update.
5173         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5174         Update.
5175         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5176         (objfpy_lookup_objfile_by_build_id): Update.
5177         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5178         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5179         Update.
5180         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5181         (expand_symtab_containing_pc, lookup_objfile_from_block)
5182         (lookup_static_symbol, basic_lookup_transparent_type)
5183         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5184         (find_line_symtab, info_sources_command)
5185         (default_collect_symbol_completion_matches_break_on)
5186         (make_source_files_completion_list, find_main_name): Update.
5187         * symmisc.c (print_symbol_bcache_statistics)
5188         (print_objfile_statistics, maintenance_print_symbols)
5189         (maintenance_print_msymbols, maintenance_print_objfiles)
5190         (maintenance_info_symtabs, maintenance_check_symtabs)
5191         (maintenance_expand_symtabs, maintenance_info_line_tables):
5192         Update.
5193         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5194         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5195         (map_overlay_command, unmap_overlay_command)
5196         (simple_overlay_update, expand_symtabs_matching)
5197         (map_symbol_filenames): Update.
5198         * symfile-debug.c (set_debug_symfile): Update.
5199         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5200         Update.
5201         * source.c (select_source_symtab, forget_cached_source_info):
5202         Update.
5203         * solib.c (solib_read_symbols): Update.
5204         * solib-spu.c (append_ocl_sos): Update.
5205         * psymtab.c (maintenance_print_psymbols)
5206         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5207         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5208         * printcmd.c (info_symbol_command): Update.
5209         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5210         Update.
5211         * objfiles.h (class all_objfiles): Remove.
5212         * objfiles.c (have_partial_symbols, have_full_symbols)
5213         (have_minimal_symbols, qsort_cmp, update_section_map)
5214         (shared_objfile_contains_address_p)
5215         (default_iterate_over_objfiles_in_search_order): Update.
5216         * objc-lang.c (info_selectors_command, info_classes_command)
5217         (find_methods): Update.
5218         * minsyms.c (find_solib_trampoline_target): Update.
5219         * maint.c (maintenance_info_sections)
5220         (maintenance_translate_address, count_symtabs_and_blocks):
5221         Update.
5222         * main.c (captured_main_1): Update.
5223         * linux-thread-db.c (try_thread_db_load_from_pdir)
5224         (has_libpthread): Update.
5225         * linespec.c (iterate_over_all_matching_symtabs)
5226         (search_minsyms_for_name): Update.
5227         * jit.c (jit_find_objf_with_entry_addr): Update.
5228         * hppa-tdep.c (find_unwind_entry)
5229         (hppa_lookup_stub_minimal_symbol): Update.
5230         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5231         Update.
5232         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5233         (elf_gnu_ifunc_resolve_by_got): Update.
5234         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5235         * dwarf-index-write.c (save_gdb_index_command): Update.
5236         * cp-support.c (add_symbol_overload_list_qualified): Update.
5237         * breakpoint.c (create_overlay_event_breakpoint)
5238         (create_longjmp_master_breakpoint)
5239         (create_std_terminate_master_breakpoint)
5240         (create_exception_master_breakpoint): Update.
5241         * blockframe.c (find_pc_partial_function): Update.
5242         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5243         (ada_collect_symbol_completion_matches)
5244         (ada_add_global_exceptions): Update.
5245
5246 2019-01-17  Tom Tromey  <tom@tromey.com>
5247
5248         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5249         declare VEC.
5250         (solib_target_parse_libraries): Change return type.
5251         (library_list_start_segment, library_list_start_section)
5252         (library_list_end_library, library_list_start_library); Update.
5253         (solib_target_free_library_list): Remove.
5254         (solib_target_parse_libraries): Remove cleanup.  Change return
5255         type.
5256         (solib_target_current_sos): Update.
5257
5258 2019-01-17  Tom Tromey  <tromey@bapiya>
5259
5260         * valprint.c: Replace "the the" with "the".
5261         * symtab.c: Replace "the the" with "the".
5262         * solib.c: Replace "the the" with "the".
5263         * solib-dsbt.c: Replace "the the" with "the".
5264         * linespec.c: Replace "the the" with "the".
5265         * dwarf2loc.h: Replace "the the" with "the".
5266         * amd64-windows-tdep.c: Replace "the the" with "the".
5267         * aarch64-tdep.c: Replace "the the" with "the".
5268
5269 2019-01-16  Keith Seitz  <keiths@redhat.com>
5270
5271         PR gdb/23773
5272         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5273         <builder>: Rename to ..
5274         <m_builder>: ... this and make private.
5275         (dwarf2_cu::get_builder): New method.  Change all users of
5276         `builder' to use this method.
5277         (dwarf2_start_symtab): Move to ...
5278         (dwarf2_cu::start_symtab): ... here.  Update all callers
5279         (setup_type_unit_groups): Move to ...
5280         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5281         callers.
5282         (dwarf2_cu::reset_builder): New method.
5283         (process_full_compunit, process_full_type_unit): Use
5284         dwarf2_cu::reset_builder.
5285         (follow_die_offset): Record the ancestor CU if it is different
5286         from the followed DIE's CU.
5287         (follow_die_sig_1): Likewise.
5288
5289 2019-01-15  Tom Tromey  <tom@tromey.com>
5290
5291         * remote.c (class remote_state) <buf>: Now a char_vector.
5292         <buf_size>: Remove.
5293         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5294         parameter.
5295         (remote_target::getpkt_or_notif_sane_1)
5296         (remote_target::getpkt_sane)
5297         (remote_target::getpkt_or_notif_sane): Likewise.
5298         (class remote_target) <putpkt>: New overload.
5299         (remote_target::read_frame): Change type of "buf_p".  Remove
5300         sizeof_p parameter.
5301         (packet_ok): New overload.
5302         (packet_check_result): New overload.
5303         Update all uses.
5304
5305 2019-01-14  Tom Tromey  <tom@tromey.com>
5306
5307         * remote-notif.c (handle_notification, remote_notif_ack)
5308         (remote_notif_parse): Make "buf" const.
5309         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5310         const.
5311         (remote_notif_parse, remote_notif_ack, handle_notification):
5312         Likewise.
5313         * remote.c (remote_notif_stop_parse): Make "buf" const.
5314         (remote_target::remote_parse_stop_reply): Make "buf" const.
5315         (remote_notif_stop_ack): Make "buf" const.
5316
5317 2019-01-14  Tom Tromey  <tom@tromey.com>
5318
5319         * remote.c (remote_console_output): Make parameter const.
5320
5321 2019-01-14  Tom Tromey  <tom@tromey.com>
5322
5323         * target-debug.h (target_debug_print_signals): Constify.
5324         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5325         * procfs.c (procfs_target::pass_signals): Update.
5326         * linux-nat.c (linux_nat_target::pass_signals): Update.
5327         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5328         * target-delegates.c: Rebuild.
5329         * remote.c (remote_target::program_signals): Update.
5330         (remote_target::pass_signals): Update.
5331         * target.c (target_pass_signals): Constify argument.
5332         (target_program_signals): Likewise.
5333         * target.h (struct target_ops) <pass_signals, program_signals>:
5334         Constify argument.
5335         (target_pass_signals, target_program_signals): Constify argument.
5336
5337 2019-01-14  Tom Tromey  <tom@tromey.com>
5338
5339         PR tui/28819:
5340         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5341
5342 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5343
5344         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5345         field.
5346         * rs6000-tdep.c: Include reggroups.h.
5347         (IS_V_ALIAS_PSEUDOREG): Define.
5348         (rs6000_register_name): Return names for the "vX" aliases.
5349         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5350         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5351         aliases.  Call default_register_reggroup_p for all other
5352         pseudo-registers.
5353         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5354         New functions.
5355         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5356         Handle "vX" aliases.
5357         (v_alias_pseudo_register_collect): New function.
5358         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5359         (rs6000_gdbarch_init): Initialize "vX" aliases as
5360         pseudo-registers.  Restore registration of
5361         rs6000_pseudo_register_reggroup_p with
5362         set_tdesc_pseudo_register_reggroup_p.
5363
5364 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5365
5366         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5367         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5368         set_gdbarch_num_pseudo_regs.
5369
5370 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5371
5372         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5373         Remove arg prefixname, add do_set and do_show.
5374         Add member functions set_list and show_list.
5375         * cli/cli-style.c (class cli_style_option): Update accordingly.
5376         (style_set_list): Move to file scope.
5377         (style_show_list): Likewise.
5378         (set_style): Call help_list.
5379         (show_style): Call cmd_show_list.
5380         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5381         Update to use the new macro.
5382
5383 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5384
5385         * ada-lang.c (_initialize_ada_language): Expand the help text
5386         for the "catch exception" command.
5387
5388 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5389
5390         * symtab.c (matching_obj_sections): Initialize obj,
5391         declare it closer to its usage.
5392
5393 2019-01-10  Tom Tromey  <tom@tromey.com>
5394
5395         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5396         (basic_inf_threads_range): Remove.
5397         (inf_threads_range, inf_non_exited_threads_range)
5398         (safe_inf_threads_range): Use next_adapter.
5399
5400 2019-01-10  Keith Seitz  <keiths@redhat.com>
5401
5402         PR gdb/23712
5403         PR symtab/23010
5404         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5405         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5406
5407 2019-01-10  Keith Seitz  <keiths@redhat.com>
5408
5409         PR gdb/23712
5410         PR symtab/23010
5411         * dictionary.c (pending_to_vector): Remove.
5412         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5413         Remove _1 suffix, replacing functions of the same name.  Update
5414         all callers.
5415         (dict_create_hashed, dict_create_hashed_expandable)
5416         (dict_create_linear, dict_create_linear_expandable, dict_free)
5417         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5418         Make functions static.
5419
5420 2019-01-10  Keith Seitz  <keiths@redhat.com>
5421
5422         PR gdb/23712
5423         PR symtab/23010
5424         * dictionary.h (struct dictionary): Replace declaration with
5425         multidictionary.
5426         (dict_create_hashed, dict_create_hashed_expandable)
5427         (dict_create_linear, dict_create_linear_expandable)
5428         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5429         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5430         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5431         taking multidictionary argument.
5432         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5433         * block.h (struct block) <dict>: Change to multidictionary
5434         and rename `multidict'.
5435         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5436         symmisc.c: Update all dictionary references to multidictionary.
5437
5438 2019-01-10  Keith Seitz  <keiths@redhat.com>
5439
5440         PR gdb/23712
5441         PR symtab/23010
5442         * dictionary.c: Include unordered_map.
5443         (pending_to_vector): New function.
5444         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5445         Rewrite the non-"_1" functions to take vector instead
5446         of linked list.
5447         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5448         "new" _1 versions of the same name.
5449         (multidictionary): Define.
5450         (std::hash<enum language): New definition.
5451         (collate_pending_symbols_by_language, mdict_create_hashed)
5452         (mdict_create_hashed_expandable, mdict_create_linear)
5453         (mdict_create_linear_expandable, mdict_free)
5454         (find_language_dictionary, create_new_language_dictionary)
5455         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5456         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5457         (mdict_size, mdict_empty): New functions.
5458         * dictionary.h (mdict_iterator): Define.
5459
5460 2019-01-10  Pedro Alves  <palves@redhat.com>
5461
5462         * breakpoint.c (read_uploaded_action)
5463         (create_tracepoint_from_upload): Adjust to use
5464         gdb::unique_xmalloc_ptr.
5465         * ctf.c (ctf_write_uploaded_tp):
5466         (SET_ARRAY_FIELD): Use emplace_back.
5467         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5468         * tracefile-tfile.c (tfile_write_uploaded_tp):
5469         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5470         gdb::unique_xmalloc_ptr.
5471         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5472         at_string, cond_string, cmd_strings>: Replace char pointers
5473         with gdb::unique_xmalloc_ptr.
5474
5475 2019-01-10  Pedro Alves  <palves@redhat.com>
5476
5477         * solib-target.c (library_list_start_library): Don't xstrdup name.
5478
5479 2019-01-10  Pedro Alves  <palves@redhat.com>
5480
5481         * mdebugread.c (parse_partial_symbols): Use
5482         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5483
5484 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * linux-fork.c (scoped_switch_fork_info)
5487         <~scoped_switch_fork_info>: Fix incorrect variable name.
5488
5489 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * linux-fork.c (scoped_switch_fork_info)
5492         <scoped_switch_fork_info>: Make explicit.
5493         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5494
5495 2019-01-10  Tom Tromey  <tom@tromey.com>
5496
5497         * objfiles.h (objfile::reset_psymtabs): Update.
5498         * objfiles.c (objfile::objfile): Update.
5499         * psymtab.h (psymtab_storage::obstack): Update.
5500         (psymtab_storage::m_obstack): Use gdb::optional.
5501         (class psymtab_storage): Update comment.  Remove objfile
5502         parameter.
5503         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5504
5505 2019-01-10  Tom Tromey  <tom@tromey.com>
5506
5507         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5508         <free_psymtabs>: Now private.
5509         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5510         (allocate_psymtab): Use new method.
5511
5512 2019-01-10  Tom Tromey  <tom@tromey.com>
5513
5514         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5515         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5516         * mdebugread.c (parse_partial_symbols): Use
5517         allocate_dependencies.
5518         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5519         allocate_dependencies.
5520         (process_psymtab_comp_unit_reader)
5521         (build_type_psymtab_dependencies): Likewise.
5522         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5523
5524 2019-01-10  Tom Tromey  <tom@tromey.com>
5525
5526         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5527         PSYMBOL_SET_LANGUAGE.
5528         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5529
5530 2019-01-10  Tom Tromey  <tom@tromey.com>
5531
5532         * psymtab.h (psymtab_storage::obstack): New method.
5533         <m_obstack>: Rename from obstack; now private.
5534         * psymtab.c (psymtab_storage): Update.
5535         * dwarf2read.c (create_addrmap_from_index)
5536         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5537         Update.
5538
5539 2019-01-10  Tom Tromey  <tom@tromey.com>
5540
5541         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5542         * objfiles.h (objfile::reset_psymtabs): New method.
5543
5544 2019-01-10  Tom Tromey  <tom@tromey.com>
5545
5546         * symmisc.c (print_symbol_bcache_statistics): Update.
5547         (print_objfile_statistics): Update.
5548         * symfile.c (reread_symbols): Update.
5549         * psymtab.h (class psymtab_storage): New.
5550         * psymtab.c (psymtab_storage): New constructor.
5551         (~psymtab_storage): New destructor.
5552         (require_partial_symbols): Update.
5553         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5554         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5555         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5556         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5557         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5558         (start_psymtab_common, end_psymtab_common)
5559         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5560         (allocate_psymtab): Update.
5561         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5562         Update.
5563         (dump_psymtab_addrmap, maintenance_print_psymbols)
5564         (maintenance_check_psymtabs): Update.
5565         (class objfile_psymtabs): Move to objfiles.h.
5566         * psympriv.h (discard_psymtab): Now inline.
5567         (psymtab_discarder::psymtab_discarder): Update.
5568         (psymtab_discarder::~psymtab_discarder): Update.
5569         (ALL_OBJFILE_PSYMTABS): Rewrite.
5570         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5571         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5572         Remove fields.
5573         <partial_symtabs>: New field.
5574         (class objfile_psymtabs): Move from psymtab.h.  Update.
5575         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5576         psymbol_cache.
5577         (objfile::~objfile): Don't destroy psymbol_cache.
5578         * mdebugread.c (parse_partial_symbols): Update.
5579         * dwarf2read.c (create_addrmap_from_index)
5580         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5581         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5582         (add_partial_subprogram, dwarf2_ranges_read): Update.
5583         * dwarf-index-write.c (write_address_map)
5584         (write_one_signatured_type, recursively_write_psymbols)
5585         (class debug_names, class debug_names, write_psymtabs_to_index):
5586         Update.
5587
5588 2019-01-10  Tom Tromey  <tom@tromey.com>
5589
5590         * symtab.h (SYMBOL_SET_NAMES): Update.
5591         (symbol_set_names): Update.
5592         (MSYMBOL_SET_NAMES): Update.
5593         * symtab.c (symbol_set_names): Change argument to be an
5594         objfile_per_bfd_storage.
5595         * psymtab.c (add_psymbol_to_bcache): Update.
5596         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5597
5598 2019-01-10  Tom Tromey  <tom@tromey.com>
5599
5600         * symtab.c (create_demangled_names_hash): Change argument to be an
5601         objfile_per_bfd_storage.
5602         (symbol_set_names): Update.
5603
5604 2019-01-10  Tom Tromey  <tom@tromey.com>
5605
5606         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5607         init_psymbol_list.
5608         * psymtab.c (init_psymbol_list): Do nothing if already called.
5609         * psympriv.h (init_psymbol_list): Add comment.
5610         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5611         init_psymbol_list.
5612         * dbxread.c (dbx_symfile_read): Unconditionally call
5613         init_psymbol_list.
5614
5615 2019-01-10  Tom Tromey  <tom@tromey.com>
5616
5617         * xcoffread.c (scan_xcoff_symtab): Update.
5618         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5619         "where".
5620         * mdebugread.c (parse_partial_symbols)
5621         (handle_psymbol_enumerators): Update.
5622         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5623         * dbxread.c (read_dbx_symtab): Update.
5624         * psympriv.h (psymbol_placement): New enum.
5625         (add_psymbol_to_list): Update.
5626
5627 2019-01-10  Tom Tromey  <tom@tromey.com>
5628
5629         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5630         static_psymbols parameters.
5631         (scan_xcoff_symtab): Update.
5632         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5633         static_psymbols parameters.
5634         * psympriv.h (start_psymtab_common): Update.
5635         * mdebugread.c (parse_partial_symbols): Update.
5636         * dwarf2read.c (create_partial_symtab): Update.
5637         * dbxread.c (read_dbx_symtab): Update.
5638         (start_psymtab): Remove global_psymbols and static_psymbols
5639         parameters.
5640
5641 2019-01-10  Tom Tromey  <tom@tromey.com>
5642
5643         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5644         * psymtab.c (allocate_psymtab): Add comment.
5645         * psympriv.h (allocate_psymtab): Add comment.
5646         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5647         initializations.
5648         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5649
5650 2019-01-10  Tom Tromey  <tom@tromey.com>
5651
5652         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5653         Don't declare.
5654         * mipsread.c: Include mdebugread.h.
5655         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5656         Declare.
5657         * elfread.c: Include mdebugread.h.
5658
5659 2019-01-09  Tom Tromey  <tom@tromey.com>
5660
5661         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5662         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5663         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5664         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5665         (psym_lookup_symbol, psym_find_last_source_symtab)
5666         (psym_forget_cached_source_info, psym_print_stats)
5667         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5668         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5669         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5670         (psym_find_compunit_symtab_by_address)
5671         (maintenance_print_psymbols, maintenance_info_psymtabs)
5672         (maintenance_check_psymtabs): Use ranged for.
5673         * psymtab.h (class objfile_psymtabs): New.
5674         (require_partial_symbols): Return objfile_psymtabs.
5675         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5676
5677 2019-01-09  Tom Tromey  <tom@tromey.com>
5678
5679         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5680         (find_pc_mapped_section, list_overlays_command)
5681         (map_overlay_command, unmap_overlay_command)
5682         (simple_overlay_update): Use all_objfiles.
5683         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5684         * printcmd.c (info_symbol_command): Use all_objfiles.
5685         * objfiles.h (ALL_OBJSECTIONS): Remove.
5686         * maint.c (maintenance_translate_address): Use all_objfiles.
5687         * gcore.c (gcore_create_callback): Use all_objfiles.
5688         (objfile_find_memory_regions): Likewise.
5689
5690 2019-01-09  Tom Tromey  <tom@tromey.com>
5691
5692         * symtab.c (find_line_symtab, info_sources_command)
5693         (make_source_files_completion_list): Use objfile_compunits.
5694         * source.c (select_source_symtab): Use objfile_compunits.
5695         * objfiles.h (struct objfile): Update comment.
5696         (ALL_OBJFILES): Remove.
5697         (ALL_FILETABS): Remove.
5698         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5699         objfile_compunits.
5700
5701 2019-01-09  Tom Tromey  <tom@tromey.com>
5702
5703         * symmisc.c (print_objfile_statistics, dump_objfile)
5704         (maintenance_print_symbols): Use compunit_filetabs.
5705         * source.c (forget_cached_source_info_for_objfile): Use
5706         compunit_filetabs.
5707         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5708         (ALL_FILETABS): Use compunit_filetabs.
5709         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5710         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5711
5712 2019-01-09  Tom Tromey  <tom@tromey.com>
5713
5714         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5715         (compunit_filetabs): New.
5716         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5717         compunit_filetabs.
5718         (info_sources_command, make_source_files_completion_list): Remove
5719         declaration.
5720         * symmisc.c (print_objfile_statistics, dump_objfile)
5721         (maintenance_print_symbols): Remove declaration.
5722         (maintenance_info_symtabs): Use compunit_filetabs.
5723         (maintenance_info_line_tables): Likewise.
5724         * source.c (select_source_symtab): Change local variable name.
5725         (forget_cached_source_info_for_objfile): Remove declaration.
5726         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5727         * objfiles.c (objfile_relocate1): Remove declaration.
5728         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5729         declaration.
5730         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5731         * coffread.c (coff_symtab_read): Remove declaration.
5732         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5733         compunit_filetabs.
5734
5735 2019-01-09  Tom Tromey  <tom@tromey.com>
5736
5737         * symtab.c (lookup_objfile_from_block)
5738         (find_pc_sect_compunit_symtab, search_symbols)
5739         (default_collect_symbol_completion_matches_break_on): Use
5740         objfile_compunits.
5741         * objfiles.h (ALL_COMPUNITS): Remove.
5742         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5743         * cp-support.c (add_symbol_overload_list_qualified): Use
5744         objfile_compunits.
5745         * ada-lang.c (ada_collect_symbol_completion_matches)
5746         (ada_add_global_exceptions): Use objfile_compunits.
5747
5748 2019-01-09  Tom Tromey  <tom@tromey.com>
5749
5750         * source.c (select_source_symtab)
5751         (forget_cached_source_info_for_objfile): Remove declaration.
5752         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5753         declaration.
5754         * maint.c (count_symtabs_and_blocks): Remove declaration.
5755         * cp-support.c (add_symbol_overload_list_qualified): Remove
5756         declaration.
5757         * coffread.c (coff_symtab_read): Remove declaration.
5758         * symtab.c (lookup_symbol_in_objfile_symtabs)
5759         (basic_lookup_transparent_type_1): Use objfile_compunits.
5760         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5761         (info_sources_command, search_symbols)
5762         (default_collect_symbol_completion_matches_break_on)
5763         (make_source_files_completion_list): Remove declaration.
5764         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5765         (ada_collect_symbol_completion_matches)
5766         (ada_add_global_exceptions): Remove declaration.
5767         * linespec.c (iterate_over_all_matching_symtabs): Use
5768         objfile_compunits.
5769         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5770         (class objfile_compunits): New.
5771         (ALL_COMPUNITS): Use objfile_compunits.
5772         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5773         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5774         objfile_compunits.
5775         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5776
5777 2019-01-09  Tom Tromey  <tom@tromey.com>
5778
5779         * symtab.c (search_symbols)
5780         (default_collect_symbol_completion_matches_break_on): Use
5781         objfile_msymbols.
5782         * ada-lang.c (ada_lookup_simple_minsym)
5783         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5784         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5785         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5786         objfile_msymbols.
5787         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5788         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5789         * objc-lang.c (find_methods): Use objfile_msymbols.
5790         (info_selectors_command, info_classes_command): Likewise.
5791         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5792         * objfiles.h (class objfile_msymbols): New.
5793         (ALL_OBJFILE_MSYMBOLS): Remove.
5794         (ALL_MSYMBOLS): Remove.
5795
5796 2019-01-09  Tom Tromey  <tom@tromey.com>
5797
5798         * common/next-iterator.h (next_adapter): Add Iterator template
5799         parameter.
5800         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5801         (class all_objfiles_safe): New.
5802         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5803         * objfiles.c (put_objfile_before): Update comment.
5804         (add_separate_debug_objfile): Likewise.
5805         (free_all_objfiles): Use all_objfiles_safe.
5806         (objfile_purge_solibs): Likewise.
5807
5808 2019-01-09  Tom Tromey  <tom@tromey.com>
5809
5810         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5811         (expand_symtab_containing_pc, lookup_static_symbol)
5812         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5813         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5814         all_objfiles.
5815         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5816         * breakpoint.c (create_overlay_event_breakpoint)
5817         (create_longjmp_master_breakpoint)
5818         (create_std_terminate_master_breakpoint)
5819         (create_exception_master_breakpoint): Use all_objfiles.
5820         * linux-thread-db.c (try_thread_db_load_from_pdir)
5821         (has_libpthread): Use all_objfiles.
5822         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5823         * linespec.c (iterate_over_all_matching_symtabs)
5824         (search_minsyms_for_name): Use all_objfiles.
5825         * maint.c (maintenance_info_sections): Use all_objfiles.
5826         * main.c (captured_main_1): Use all_objfiles.
5827         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5828         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5829         * guile/scm-pretty-print.c
5830         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5831         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5832         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5833         (maintenance_print_msymbols): Use all_objfiles.
5834         * source.c (select_source_symtab): Use all_objfiles.
5835         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5836         * symfile.c (remove_symbol_file_command)
5837         (expand_symtabs_matching, map_symbol_filenames): Use
5838         all_objfiles.
5839         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5840         all_objfiles.
5841         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5842         * objc-lang.c (find_methods): Use all_objfiles.
5843         * objfiles.c (have_partial_symbols, have_full_symbols)
5844         (have_minimal_symbols, qsort_cmp)
5845         (default_iterate_over_objfiles_in_search_order): Use
5846         all_objfiles.
5847         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5848         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5849         (maintenance_check_psymtabs): Use all_objfiles.
5850         (ALL_PSYMTABS): Remove.
5851         * compile/compile-object-run.c (do_module_cleanup): Use
5852         all_objfiles.
5853         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5854         * cp-support.c (add_symbol_overload_list_qualified): Use
5855         all_objfiles.
5856         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5857         Use all_objfiles.
5858         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5859         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5860         all_objfiles.
5861         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5862         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5863         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5864         Uses all_objfiles.
5865         * solib.c (solib_read_symbols): Use all_objfiles
5866
5867 2019-01-09  Tom Tromey  <tom@tromey.com>
5868
5869         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5870         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5871         all_objfiles.
5872         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5873         * symmisc.c (print_symbol_bcache_statistics)
5874         (print_objfile_statistics, maintenance_print_objfiles)
5875         (maintenance_info_symtabs, maintenance_check_symtabs)
5876         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5877         all_objfiles.
5878         * source.c (forget_cached_source_info): Use all_objfiles.
5879         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5880         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5881         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5882         * objfiles.c (update_section_map): Use all_objfiles.
5883         (shared_objfile_contains_address_p): Likewise.
5884         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5885         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5886
5887 2019-01-09  Tom Tromey  <tom@tromey.com>
5888
5889         * common/next-iterator.h: New file.
5890         * objfiles.h (class all_objfiles): New.
5891         (struct objfile_iterator): New.
5892
5893 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5894
5895         * NEWS: Move the description of the changed "frame", "select-frame",
5896          and "info frame" commands to the Changed commands section.
5897
5898 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5899
5900         * gdbtypes.c (check_stub_method_group): Remove handling of old
5901         mangling schemes.
5902         * linespec.c (find_methods): Likewise.
5903         * stabsread.c (read_member_functions): Likewise.
5904         * valops.c (search_struct_method): Likewise.
5905         (value_struct_elt_for_reference): Likewise.
5906         * NEWS: Mention this change.
5907
5908 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5911         print_source_lines.
5912         * source.c (print_source_lines_base): Update line number check.
5913         (print_source_lines): New function.
5914         (source_lines_range::source_lines_range): New function.
5915         * source.h (class source_lines_range): New class.
5916         (print_source_lines): New declaration.
5917
5918 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5919
5920         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5921
5922 2019-01-08  Tom Tromey  <tom@tromey.com>
5923             Simon Marchi  <simon.marchi@ericsson.com>
5924
5925         PR gdb/24060
5926         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5927         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5928         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5929         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5930         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5931         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5932
5933 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * source.c (select_source_symtab): Move header comment to
5936         declaration in source.h.
5937         (forget_cached_source_info_for_objfile): Likewise.
5938         (forget_cached_source_info): Likewise.
5939         (identify_source_line): Likewise.
5940         * source.h (identify_source_line): Move declaration from symtab.h
5941         and add comment from source.c
5942         (print_source_lines): Likewise.
5943         (forget_cached_source_info_for_objfile): Likewise.
5944         (forget_cached_source_info): Likewise.
5945         (select_source_symtab): Likewise.
5946         (enum print_source_lines_flag): Move definition from symtab.h.
5947         * symtab.h (identify_source_line): Move declaration to source.h.
5948         (print_source_lines): Likewise.
5949         (forget_cached_source_info_for_objfile): Likewise.
5950         (forget_cached_source_info): Likewise.
5951         (select_source_symtab): Likewise.
5952         (enum print_source_lines_flag): Move definition to source.h.
5953         * tui/tui-hooks.c: Add 'source.h' include.
5954
5955 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5956
5957         * source.c (print_source_lines_base): Handle requests to print
5958         reverse line number sequences, and guard against empty lines
5959         string.
5960
5961 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5962
5963         * source.c (print_source_lines_base): Fix skip of '\r' if next
5964         character is '\n'.
5965
5966 2019-01-06  Tom Tromey  <tom@tromey.com>
5967
5968         * c-exp.y (struct c_parse_state) <macro_original_text,
5969         expansion_obstack>: New member.
5970         (macro_original_text, expansion_obstack): Remove globals.
5971         (scan_macro_expansion, scanning_macro_expansion)
5972         (finished_macro_expansion): Update.
5973         (scan_macro_cleanup): Remove.
5974         (yylex, c_parse): Update.
5975
5976 2019-01-06  Tom Tromey  <tom@tromey.com>
5977
5978         * c-exp.y (struct c_parse_state) <strings>: New member.
5979         (operator_stoken): Update.
5980
5981 2019-01-06  Tom Tromey  <tom@tromey.com>
5982
5983         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5984         (union type_stack_elt) <typelist_val>: Now a pointer to
5985         std::vector.
5986         (type_stack_cleanup): Don't declare.
5987         (push_typelist): Update.
5988         * parse.c (pop_typelist): Return a std::vector.
5989         (push_typelist): Take a std::vector.
5990         (follow_types): Update.  Do not free args.
5991         (type_stack_cleanup): Remove.
5992         * c-exp.y (struct c_parse_state): New.
5993         (cpstate): New global.
5994         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5995         (nonempty_typelist): Update.
5996         (func_mod): Create a new vector.
5997         (c_parse): Create a c_parse_state.
5998         (check_parameter_typelist): Do not delete params.
5999         (function_method): Update.  Do not delete type_list.
6000
6001 2019-01-06  Tom Tromey  <tom@tromey.com>
6002
6003         PR gdb/28155:
6004         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6005         check_typedef.
6006         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6007         (print_return_value): Likewise.
6008
6009 2019-01-05  Tom Tromey  <tom@tromey.com>
6010
6011         * contrib/cleanup_check.py: Remove.
6012         * contrib/gcc-with-excheck: Remove.
6013         * contrib/exsummary.py: Remove.
6014         * contrib/excheck.py: Remove.
6015
6016 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6017
6018         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6019         NULL. Initialize tpprev to NULL instead of assigning it
6020         to NULL on the next statement.
6021         * windows-nat.c (windows_delete_thread): Remove check for
6022         main_thread_id before printing thread exit notifications.
6023         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6024         Remove thread ID check against main_thread_id.
6025         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6026         windows_delete_thread.
6027         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6028
6029 2019-01-04  Tom Tromey  <tom@tromey.com>
6030
6031         * compile/compile.c (_initialize_compile): Use upper case for
6032         metasyntactic variables.
6033         * symmisc.c (_initialize_symmisc): Use upper case for
6034         metasyntactic variables.
6035         * psymtab.c (_initialize_psymtab): Use upper case for
6036         metasyntactic variables.
6037         * demangle.c (demangle_command): Use upper case for metasyntactic
6038         variables.
6039         (_initialize_demangler): Likewise.
6040         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6041         variables.
6042
6043 2019-01-03  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6046
6047 2019-01-03  Tom Tromey  <tom@tromey.com>
6048
6049         * python/py-symtab.c (salpy_str): Update.
6050         (struct salpy_sal_object) <symtab>: Now a PyObject.
6051         (salpy_dealloc): Update.
6052         (del_objfile_sal): Use gdbpy_ref.
6053
6054 2019-01-03  Tom Tromey  <tom@tromey.com>
6055
6056         * python/py-type.c (convert_field): Use new_reference.  Return
6057         gdbpy_ref.
6058         (make_fielditem): Return gdbpy_ref.
6059         (typy_fields): Update.
6060         (typy_getitem): Update.
6061         (field_name): Return gdbpy_ref.  Use new_reference.
6062         (typy_iterator_iternext): Update.
6063
6064 2019-01-03  Tom Tromey  <tom@tromey.com>
6065
6066         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6067
6068 2019-01-03  Tom Tromey  <tom@tromey.com>
6069
6070         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6071         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6072         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6073         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6074         (pspy_set_type_printers): Likewise.
6075         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6076         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6077         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6078         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6079         (objfpy_set_type_printers): Likewise.
6080
6081 2019-01-03  Tom Tromey  <tom@tromey.com>
6082
6083         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6084         (gdbpy_print_stack): Use gdbpy_err_fetch.
6085         * python/python-internal.h (class gdbpy_err_fetch): New class.
6086         (class gdbpy_enter) <m_error_type, m_error_value,
6087         m_error_traceback>: Remove.
6088         <m_error>: New member.
6089         (gdbpy_exception_to_string): Don't declare.
6090         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6091         * python/py-value.c (convert_value_from_python): Use
6092         gdbpy_err_fetch.
6093         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6094         gdbpy_exception_to_string.
6095         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6096         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6097         gdbpy_err_fetch.
6098
6099 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * linux-nat.c (delete_lwp_cleanup): Delete.
6102         (struct lwp_deleter): New struct.
6103         (lwp_info_up): New typedef.
6104         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6105         lwp_info_up.
6106
6107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * linux-fork.c (class scoped_switch_fork_info): New class.
6110         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6111
6112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * valops.c (find_overload_match): Remove use of null_cleanup, and
6115         calls to do_cleanups.
6116
6117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6118
6119         * compile/compile-cplus-types.c
6120         (compile_cplus_instance::decl_name): Handle changes to
6121         cp_func_name.
6122         * cp-support.c (cp_func_name): Update header comment, update
6123         return type.
6124         * cp-support.h (cp_func_name): Update return type in declaration.
6125         * valops.c (find_overload_match): Move temp_func local to top
6126         level of function and change its type.  Use temp_func to hold and
6127         delete temporary string obtained from cp_func_name.
6128
6129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6130
6131         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6132         gdb::char_vector, remove cleanup, and update uses of `msg`.
6133
6134 2019-01-03  Jim Wilson  <jimw@sifive.com>
6135
6136         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6137
6138 2019-01-02  Tom Tromey  <tom@tromey.com>
6139
6140         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6141         (tdesc_parse_xml): Remove cleanups.
6142         * target-descriptions.h (make_cleanup_free_target_description):
6143         Don't declare.
6144         (target_desc_deleter): New struct.
6145         (target_desc_up): New typedef.
6146         * target-descriptions.c (target_desc_deleter::operator()): Rename
6147         from free_target_description.
6148         (make_cleanup_free_target_description): Remove.
6149
6150 2019-01-02  Tom Tromey  <tom@tromey.com>
6151
6152         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6153         constructor, destructor.
6154         (linespec_parser): Remove typedef.
6155         (~linespec_parser): Rename from linespec_parser_delete.
6156         (linespec_lex_to_end, linespec_complete_label)
6157         (linespec_complete): Update.
6158         (decode_line_full): Remove cleanups.
6159         (decode_line_1): Update.
6160
6161 2019-01-02  Tom Tromey  <tom@tromey.com>
6162
6163         * python/python-internal.h (inferior_to_inferior_object): Change
6164         return type.
6165         * python/py-exitedevent.c (create_exited_event_object): Update.
6166         * python/py-inferior.c (inferior_to_inferior_object): Return
6167         gdbpy_ref.
6168         (python_new_inferior, python_inferior_deleted)
6169         (thread_to_thread_object, delete_thread_object)
6170         (build_inferior_list, gdbpy_selected_inferior): Update.
6171         * python/py-infthread.c (create_thread_object): Update.  Also fail
6172         if inferior_to_inferior_object fails.
6173
6174 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6175
6176         * inferior.h (class inferior) <displaced_step_state>: New field.
6177         * infrun.h (struct displaced_step_state): Move here from
6178         infrun.c.  Initialize fields, add constructor.
6179         <inf>: Remove field.
6180         <reset>: New method.
6181         * infrun.c (struct displaced_step_inferior_state): Move to
6182         infrun.h.
6183         (displaced_step_inferior_states): Remove.
6184         (get_displaced_stepping_state): Adust.
6185         (displaced_step_in_progress_any_inferior): Adjust.
6186         (displaced_step_in_progress_thread): Adjust.
6187         (displaced_step_in_progress): Adjust.
6188         (add_displaced_stepping_state): Remove.
6189         (get_displaced_step_closure_by_addr): Adjust.
6190         (remove_displaced_stepping_state): Remove.
6191         (infrun_inferior_exit): Call displaced_step_state.reset.
6192         (use_displaced_stepping): Don't check for NULL.
6193         (displaced_step_prepare_throw): Call
6194         get_displaced_stepping_state.
6195         (displaced_step_fixup): Don't check for NULL.
6196         (prepare_for_detach): Don't check for NULL.
6197
6198 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6199
6200         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6201          in case of call that did not complete.
6202
6203 2019-01-02  Andrey Utkin  <autkin@undo.io>
6204
6205         * symfile.c (find_separate_debug_file): Fix search of debug files for
6206         remote debuggee.
6207
6208 2019-01-02  Tom Tromey  <tom@tromey.com>
6209
6210         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6211         indentation.
6212         * python/py-frame.c (frapy_older): Remove cast.
6213         (frapy_newer): Likewise.
6214         * python/py-breakpoint.c (local_setattro): Remove cast.
6215         * python/py-arch.c (archpy_name): Remove local variable.
6216         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6217
6218 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6219
6220         * unittests/basic_string_view/element_access/char/empty.cc:
6221         Fix year range in copyright header.
6222
6223 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6226         Delete.
6227         <operator==>: Update with for removed field.
6228         <hash>: Likewise.
6229         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6230         <isa_features>: ...this.
6231         <abi_features>: New field.
6232         (riscv_isa_flen): Update comment.
6233         (riscv_abi_xlen): New declaration.
6234         (riscv_abi_flen): New declaration.
6235         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6236         isa_features.
6237         (riscv_abi_xlen): New function.
6238         (riscv_isa_flen): Update to get answer from isa_features.
6239         (riscv_abi_flen): New function.
6240         (riscv_has_fp_abi): Update to get answer from abi_features.
6241         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6242         xlen and flen.
6243         (riscv_call_info) <xlen, flen>: Update comment.
6244         (riscv_call_arg_struct): Remove invalid assertions
6245         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6246         is removed.
6247         (riscv_gdbarch_init): Gather isa features and abi features
6248         separately, ensure both match on the gdbarch when reusing an old
6249         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6250         a target with 64-bit float hardware.
6251
6252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6253
6254         * source.c (search_command_helper): Stop reverse search
6255         when line 1 has been searched.
6256
6257 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6258
6259         * record-full.c (record_full_base_target::close): Rewrite
6260         record_full_core_buf_list free logic.
6261
6262 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6263
6264         * break-catch-syscall.c (print_one_catch_syscall): xfree
6265         the last text.
6266
6267 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6268
6269         * top.c (print_gdb_version): Update Copyright year in version
6270         message.
6271
6272 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6273
6274         Update copyright year range in all GDB files.
6275
6276 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6277
6278         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6279
6280 For older changes see ChangeLog-2018.
6281 \f
6282 Local Variables:
6283 mode: change-log
6284 left-margin: 8
6285 fill-column: 74
6286 version-control: never
6287 coding: utf-8
6288 End:
6289