gdb/ChangeLog

   1 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * command.h (valid_cmd_char_p): Declare.
   4         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
   5         the check of valid command char.
   6         (find_command_name_length, valid_user_defined_cmd_name_p): Use
   7         valid_cmd_char_p.
   8         * cli/cli-script.c (validate_comname): Likewise.
   9         * completer.c (gdb_completer_command_word_break_characters):
  10         Do not remove . from the word break char, update comments.
  11         (complete_line_internal_1): Use valid_cmd_char_p.
  12         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  13         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  14
  15 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  16
  17         * cli/cli-script.c (do_define_command): Ensure a redefined
  18         prefix command is kept as a prefix command.
  19         (define_prefix_command): New function.
  20         (show_user_1): Report user defined prefixes.
  21         (_initialize_cli_script):  Create the new 'define-prefix' command.
  22         Add completers for 'define' and 'document'.
  23         * top.c (execute_command):  If command is a user-defined prefix only
  24         command, report the list of commands for this prefix command.
  25
  26 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  27
  28         * valops.c (find_oload_champ): Improve debug output.
  29
  30 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  31
  32         * valops.c (find_oload_champ): Print part of debug messages
  33         before the badness vector is std::move'd.
  34
  35 2019-11-28  Tom Tromey  <tom@tromey.com>
  36
  37         * value.c (creal_internal_fn): Fix comment.
  38
  39 2019-11-28  Tom Tromey  <tom@tromey.com>
  40
  41         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
  42         flag_bound_evaluated>: Now unsigned.
  43
  44 2019-11-28  Tom Tromey  <tom@tromey.com>
  45
  46         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
  47         declare.
  48
  49 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
  50
  51         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
  52         debug output.
  53         * jit.c (jit_unregister_code): Add debug print to match
  54         `jit_register_code`.
  55
  56 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * NEWS: Mention the new multithreaded symbol loading.
  59
  60 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  61
  62         * maint.c (n_worker_threads): Default to 0.
  63         (worker_threads_disabled): New function.
  64         * maint.h (worker_threads_disabled): New function.
  65         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
  66         here if worker_threads_disabled () is true.
  67         (minimal_symbol_reader::install): Skip all threading if
  68         worker_threads_disabled () is true.
  69
  70 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  71
  72         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
  73         hash code if possible.
  74         (add_minsym_to_demangled_hash_table): Likewise.
  75         (minimal_symbol_reader::install): Compute the hash codes for msymbol
  76         on the background thread.
  77         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
  78         Add these fields.
  79
  80 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  81
  82         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
  83         of the mangled name on the background thread.
  84         * symtab.c (symbol_set_names): Allow passing in the hash of the
  85         linkage_name.
  86         * symtab.h (symbol_set_names): Likewise.
  87
  88 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
  89
  90         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
  91         physnames are computed for inherited DIEs.
  92
  93 2019-11-27  Tom Tromey  <tromey@adacore.com>
  94
  95         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
  96         backslashes.
  97         * cp-support.c: Remove unnecessary backslashes.
  98
  99 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 100
 101         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 102         with sym->set_linkage_name.
 103         * coffread.c (coff_read_enum_type): Likewise.
 104         * mdebugread.c (parse_symbol): Likewise.
 105         * stabsread.c (patch_block_stabs): Likewise.
 106         (define_symbol): Likewise.
 107         (read_enum_type): Likewise.
 108         (common_block_end): Likewise.
 109         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 110         function.
 111         (SYMBOL_SET_LINKAGE_NAME): Remove.
 112         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 113         with sym->set_linkage_name.
 114
 115 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 116
 117         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 118         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 119         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 120         * NEWS: Mention new MI command.
 121
 122 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 123
 124         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 125         '-symbol-info-types', and '-symbol-info-variables'.
 126         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 127         (mi_cmd_symbol_info_types): Declare.
 128         (mi_cmd_symbol_info_variables): Declare.
 129         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 130         (output_debug_symbol): New function.
 131         (output_nondebug_symbol): New function.
 132         (mi_symbol_info): New function.
 133         (mi_info_functions_or_variables): New function.
 134         (mi_cmd_symbol_info_functions): New function.
 135         (mi_cmd_symbol_info_types): New function.
 136         (mi_cmd_symbol_info_variables): New function.
 137         * NEWS: Mention new commands.
 138
 139 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * symtab.c (symbol_to_info_string): New function, most content
 142         moved from print_symbol_info, but updated to return a std::string.
 143         (print_symbol_info): Update to use symbol_to_info_string and print
 144         returned string.
 145         * symtab.h (symbol_to_info_string): Declare new function.
 146
 147 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 148
 149         * python/python.c (gdbpy_rbreak): Convert to using
 150         global_symbol_searcher.
 151         * symtab.c (file_matches): Convert return type to bool, change
 152         file list to std::vector, update header comment.
 153         (search_symbols): Rename to...
 154         (global_symbol_searcher::search): ...this and update now its
 155         a member function of global_symbol_searcher.  Take account of the
 156         changes to file_matches.
 157         (symtab_symbol_info): Convert to using global_symbol_searcher.
 158         (rbreak_command): Likewise.
 159         (search_module_symbols): Likewise.
 160         * symtab.h (enum symbol_search): Update comment.
 161         (search_symbols): Remove declaration.
 162         (class global_symbol_searcher): New class.
 163
 164 2019-11-26  Tom Tromey  <tromey@adacore.com>
 165
 166         * cp-support.c (_initialize_cp_support): Conditionally initialize
 167         gdb_demangle_attempt_core_dump.
 168
 169 2019-11-26  Tom Tromey  <tom@tromey.com>
 170
 171         * python/py-function.c (fnpy_init): Update.
 172         * value.h (add_internal_function): Adjust declaration.
 173         * value.c (function_destroyer): Remove.
 174         (do_add_internal_function): Don't set destroyer or copy name.
 175         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 176         Set name_allocated.
 177         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 178         (cmdpy_init): Set name_allocated.
 179         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 180         member.
 181         (~cmd_list_element): Free "name" if needed.
 182
 183 2019-11-26  Tom Tromey  <tom@tromey.com>
 184
 185         * value.h (add_internal_function): Add new overload.  Move
 186         documentation from value.h.
 187         * value.c (do_add_internal_function): New function.
 188         (add_internal_function): Use it.  Add new overload.
 189         (function_destroyer): Don't free doc.
 190         * python/py-function.c (fnpy_init): Update.
 191
 192 2019-11-26  Tom Tromey  <tom@tromey.com>
 193
 194         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 195         (cmdpy_init): Set "doc_allocated".
 196
 197 2019-11-26  Tom Tromey  <tom@tromey.com>
 198
 199         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 200         name of worker thread.
 201         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 202         pthread_setname_np.
 203         * configure, config.in: Rebuild.
 204
 205 2019-11-26  Tom Tromey  <tom@tromey.com>
 206
 207         * python/python.c (class gdbpy_gil): New.
 208         (struct gdbpy_event): Add constructor, destructor, operator().
 209         (gdbpy_post_event): Use run_on_main_thread.
 210         (gdbpy_initialize_events): Remove.
 211         (do_start_initialization): Update.
 212
 213 2019-11-26  Tom Tromey  <tom@tromey.com>
 214
 215         * NEWS: Add entry.
 216         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 217         commands.  Call update_thread_pool_size.
 218         (update_thread_pool_size, maintenance_set_worker_threads): New
 219         functions.
 220         (n_worker_threads): New global.
 221
 222 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 223             Tom Tromey  <tom@tromey.com>
 224
 225         * minsyms.c (minimal_symbol_reader::install): Use
 226         parallel_for_each.
 227         * gdbsupport/parallel-for.h: New file.
 228         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 229
 230 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 231             Tom Tromey  <tom@tromey.com>
 232
 233         * gdbsupport/thread-pool.h: New file.
 234         * gdbsupport/thread-pool.c: New file.
 235         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 236         (HFILES_NO_SRCDIR): Add thread-pool.h.
 237
 238 2019-11-26  Tom Tromey  <tom@tromey.com>
 239
 240         * event-top.h (thread_local_segv_handler): Declare.
 241         * event-top.c (thread_local_segv_handler): New global.
 242         (install_handle_sigsegv, handle_sigsegv): New functions.
 243         (async_init_signals): Install SIGSEGV handler.
 244         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 245         thread-local.
 246         (report_failed_demangle): New function.
 247         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 248         handler-setting code, instead use segv_handler.  Run warning code
 249         on main thread.
 250
 251 2019-11-26  Tom Tromey  <tom@tromey.com>
 252
 253         * run-on-main-thread.c: New file.
 254         * run-on-main-thread.h: New file.
 255         * unittests/main-thread-selftests.c: New file.
 256         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 257         main-thread-selftests.c.
 258         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 259         (COMMON_SFILES): Add run-on-main-thread.c.
 260
 261 2019-11-26  Tom Tromey  <tom@tromey.com>
 262
 263         * main.c (setup_alternate_signal_stack): Remove.
 264         (captured_main_1): Use gdb::alternate_signal_stack.
 265         * gdbsupport/alt-stack.h: New file.
 266
 267 2019-11-26  Tom Tromey  <tom@tromey.com>
 268
 269         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 270         Remove comment.
 271         (save_original_signals_state, restore_original_signals_state): Use
 272         gdb_sigmask.
 273         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 274         (_initialize_linux_nat): Use gdb_sigmask.
 275         * guile/guile.c (_initialize_guile): Use block_signals.
 276         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 277         * gdbsupport/gdb-sigmask.h: New file.
 278         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 279         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 280         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 281         pthread_sigmask.
 282         * configure, config.in: Rebuild.
 283         * gdbsupport/block-signals.h: New file.
 284
 285 2019-11-26  Tom Tromey  <tom@tromey.com>
 286
 287         * acinclude.m4: Include ax_pthread.m4.
 288         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 289         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 290         (CLIBS): Use PTHREAD_LIBS.
 291         (aclocal_m4_deps): Add ax_pthread.m4.
 292         * config.in, configure: Rebuild.
 293         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 294
 295 2019-11-26  Tom Tromey  <tom@tromey.com>
 296
 297         * symtab.h (struct minimal_symbol) <name_set>: New member.
 298         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 299         Don't call symbol_set_names.
 300         (minimal_symbol_reader::install): Call symbol_set_names.
 301
 302 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 303
 304         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 305         restore_active_ext_lang, as GIL is needed for (indirectly)
 306         called PyOS_InterruptOccurred.
 307
 308 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 309
 310         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 311         definition.
 312
 313 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 314
 315         * remote-sim.c (simulator_command): Make static, remove
 316         declaration.
 317
 318 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 319
 320         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 321         static.
 322         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 323         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 324         (main): Likewise.
 325         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 326         (main): Likewise.
 327         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 328         (main): Likewise.
 329         * unittests/basic_string_view/element_access/char/1.cc (test01):
 330         Likewise.
 331         (main): Likewise.
 332         * unittests/basic_string_view/element_access/char/empty.cc (main):
 333         Likewise.
 334         * unittests/basic_string_view/element_access/char/front_back.cc
 335         (test01): Likewise.
 336         (main): Likewise.
 337         * unittests/basic_string_view/inserters/char/2.cc (test05):
 338         Likewise.
 339         (main): Likewise.
 340         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 341         (test01): Likewise.
 342         (main): Likewise.
 343         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 344         (test01): Likewise.
 345         (main): Likewise.
 346         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 347         Likewise.
 348         * unittests/basic_string_view/operations/compare/char/1.cc
 349         (test01): Likewise.
 350         (main): Likewise.
 351         * unittests/basic_string_view/operations/compare/char/13650.cc
 352         (test01): Likewise.
 353         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 354         Likewise.
 355         (main): Likewise.
 356         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 357         Likewise.
 358         (main): Likewise.
 359         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 360         Likewise.
 361         (main): Likewise.
 362         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 363         Likewise.
 364         (main): Likewise.
 365         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 366         Likewise.
 367         (main): Likewise.
 368         * unittests/basic_string_view/operations/find/char/4.cc (main):
 369         Likewise.
 370         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 371         Likewise.
 372         (main): Likewise.
 373         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 374         Likewise.
 375         (main): Likewise.
 376         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 377         Likewise.
 378         (main): Likewise.
 379         * unittests/basic_string_view/operations/substr/char/1.cc
 380         (test01): Likewise.
 381         (main): Likewise.
 382         * unittests/basic_string_view/operators/char/2.cc (main):
 383         Likewise.
 384         * unittests/optional/assignment/1.cc (test): Likewise.
 385         * unittests/optional/assignment/2.cc (test): Likewise.
 386         * unittests/optional/assignment/3.cc (test): Likewise.
 387         * unittests/optional/assignment/4.cc (test): Likewise.
 388         * unittests/optional/assignment/5.cc (test): Likewise.
 389         * unittests/optional/assignment/6.cc (test): Likewise.
 390         * unittests/optional/assignment/7.cc (test): Likewise.
 391         * unittests/optional/cons/copy.cc (test): Likewise.
 392         * unittests/optional/cons/default.cc (test): Likewise.
 393         * unittests/optional/cons/move.cc (test): Likewise.
 394         * unittests/optional/cons/value.cc (test): Likewise.
 395         * unittests/optional/in_place.cc (test): Likewise.
 396         * unittests/optional/observers/1.cc (test): Likewise.
 397         * unittests/optional/observers/2.cc (test): Likewise.
 398
 399 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 400
 401         * tui-win.h (tui_set_var_cmd): Remove.
 402         * tui-win.c (tui_set_var_cmd): Make static.
 403
 404 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 405
 406         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 407         rbreak_command_wrapper): Remove.
 408         * symtab.c (rbreak_command_wrapper): Remove.
 409
 410 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 411
 412         * inferior.h (info_terminal_command): Remove declaration.
 413         * inflow.c (info_terminal_command): Make static.
 414
 415 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 416
 417         * inferior.c (exit_inferior_silent): Remove.
 418
 419 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * dictionary.c (dict_empty, mdict_empty): Remove.
 422         * dictionary.c (mdict_empty): Remove.
 423
 424 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 425
 426          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 427          (arc_insn_get_memory_offset): Likewise.
 428          (arc_insn_dump): Likewise.
 429          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 430          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 431          * dictionary.c (dict_iterator_next): Likewise.
 432          (dict_iter_match_first): Likewise.
 433          (dict_iter_match_next): Likewise.
 434          * f-lang.c (evaluate_subexp_f): Likewise.
 435          * hppa-tdep.c (hppa_read_pc): Likewise.
 436          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 437          * parse.c (write_exp_elt_msym): Likewise.
 438          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 439          * remote.c (remote_packet_size): Likewise.
 440          (remote_notif_stop_parse): Likewise.
 441          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 442          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 443          * source.c (prepare_path_for_appending): Likewise.
 444          * sparc64-linux-tdep.c
 445          (sparc64_linux_handle_segmentation_fault); Likewise.
 446          * stack.c (frame_selection_by_function_completer): Likewise.
 447
 448 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 449
 450         * completer.c (set_gdb_completion_word_break_characters):
 451         Remove.
 452
 453 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * dwarf-index-write.c: Include dwarf-index-write.h.
 456         * mi/mi-interp.c: Include mi/mi-interp.h.
 457
 458 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 459
 460         * aarch32-tdep.c: Include aarch32-tdep.h.
 461         * aarch32-tdep.h: Forward-declare struct target_desc.
 462
 463 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 466         strerror.
 467         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 468         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 469
 470 2019-11-25  Tom de Vries  <tdevries@suse.de>
 471
 472         * contrib/words.sh: Add -c option.
 473
 474 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 475
 476         * solib.c (solib_find_1): Change int to bool.
 477         (exec_file_find): Change int to bool.
 478         (solib_find): Change int to bool.
 479         (solib_read_symbols): Change int to bool.
 480         (solib_used): Change int to bool.
 481         (solib_add): Change int to bool.
 482         (info_sharedlibrary_command): Change int to bool.
 483         (solib_contains_address_p): Change int to bool.
 484         (solib_keep_data_in_core): Change int to bool.
 485         (in_solib_dynsym_resolve_code): Change int to bool.
 486         (reload_shared_libraries_1): Change int to bool.
 487         (gdb_sysroot_changed): Change int to bool.
 488         * solib.h (solib_read_symbols): Change int to bool.
 489         (solib_contains_address_p): Change int to bool.
 490         (solib_keep_data_in_core): Change int to bool.
 491         (in_solib_dynsym_resolve_code): Change int to bool.
 492         (libpthread_name_p): Change int to bool.
 493
 494 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 495
 496         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 497         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 498         (remote_packet_max_chars): New static global.
 499         (show_remote_packet_max_chars): New function.
 500         (remote_target::putpkt_binary): Adjust to use new
 501         remote_packet_max_chars option.
 502         (remote_target::getpkt_or_notif_sane_1): Likewise.
 503         (_initialize_remote): Register new remote-packet-max-chars option.
 504
 505 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 506
 507         * m68k-linux-nat.c: Include gdbarch.h.
 508
 509 2019-11-24  Tom Tromey  <tom@tromey.com>
 510
 511         * symfile.c (read_symbols): Update.
 512         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 513         bool.
 514         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 515         (psym_lookup_symbol, psym_find_last_source_symtab)
 516         (psym_forget_cached_source_info, psym_print_stats)
 517         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 518         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 519         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 520         (psym_find_compunit_symtab_by_address)
 521         (maintenance_print_psymbols, maintenance_info_psymtabs)
 522         (maintenance_check_psymtabs): Update.
 523         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 524         bool.
 525
 526 2019-11-22  Tom Tromey  <tom@tromey.com>
 527
 528         * observable.h: Update comments.
 529
 530 2019-11-22  Tom Tromey  <tromey@adacore.com>
 531
 532         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 533         (print_ada_task_info): Don't try to fetch thread id if task is not
 534         alive.
 535
 536 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 537
 538         * ada-exp.y: Update.
 539         * ada-lang.c (sort_choices): Update.
 540         (ada_print_symbol_signature): Update.
 541         (resolve_subexp): Update.
 542         (ada_parse_renaming): Update.
 543         (ada_read_renaming_var_value): Update.
 544         (lesseq_defined_than): Update.
 545         (remove_extra_symbols): Update.
 546         (remove_irrelevant_renamings): Update.
 547         (ada_add_block_symbols): Update.
 548         (ada_collect_symbol_completion_matches): Update.
 549         (ada_is_renaming_symbol): Update.
 550         (aggregate_assign_from_choices): Update.
 551         (ada_evaluate_subexp): Update.
 552         (ada_has_this_exception_support): Update.
 553         (ada_is_non_standard_exception_sym): Update.
 554         (ada_add_exceptions_from_frame): Update.
 555         (ada_add_global_exceptions): Update.
 556         (ada_print_subexp): Update.
 557         * ax-gdb.c (gen_var_ref): Update.
 558         (gen_maybe_namespace_elt): Update.
 559         (gen_expr_for_cast): Update.
 560         (gen_expr): Update.
 561         * block.h: Update.
 562         * blockframe.c (find_pc_partial_function): Update.
 563         * breakpoint.c (print_breakpoint_location): Update.
 564         (update_static_tracepoint): Update.
 565         * btrace.c (ftrace_print_function_name): Update.
 566         (ftrace_function_switched): Update.
 567         * buildsym.c (find_symbol_in_list): Update.
 568         * c-exp.y: Update.
 569         * c-typeprint.c (c_print_typedef): Update.
 570         (c_type_print_template_args): Update.
 571         * cli/cli-cmds.c (edit_command): Update.
 572         (list_command): Update.
 573         (print_sal_location): Update.
 574         * coffread.c (patch_opaque_types): Update.
 575         (process_coff_symbol): Update.
 576         (coff_read_enum_type): Update.
 577         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 578         (convert_one_symbol): Update.
 579         (hash_symname): Update.
 580         (eq_symname): Update.
 581         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 582         * compile/compile-cplus-types.c (debug_print_scope): Update.
 583         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 584         * compile/compile-object-load.c (get_out_value_type): Update.
 585         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 586         (search_symbol_list): Update.
 587         (cp_lookup_symbol_imports_or_template): Update.
 588         * cp-support.c (overload_list_add_symbol): Update.
 589         * ctfread.c (psymtab_to_symtab): Update.
 590         * dbxread.c (cp_set_block_scope): Update.
 591         * dictionary.c (iter_match_first_hashed): Update.
 592         (iter_match_next_hashed): Update.
 593         (insert_symbol_hashed): Update.
 594         (iter_match_next_linear): Update.
 595         * dictionary.h: Update.
 596         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 597         (locexpr_describe_location_piece): Update.
 598         (locexpr_describe_location_1): Update.
 599         (locexpr_generate_c_location): Update.
 600         (loclist_describe_location): Update.
 601         (loclist_generate_c_location): Update.
 602         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 603         (read_func_scope): Update.
 604         (process_enumeration_scope): Update.
 605         (new_symbol): Update.
 606         (dwarf2_const_value): Update.
 607         (dwarf2_symbol_mark_computed): Update.
 608         * eval.c (evaluate_funcall): Update.
 609         (evaluate_subexp_standard): Update.
 610         * expprint.c (print_subexp_standard): Update.
 611         (dump_subexp_body_standard): Update.
 612         * f-valprint.c (info_common_command_for_block): Update.
 613         * findvar.c (get_hosting_frame): Update.
 614         (default_read_var_value): Update.
 615         * go-lang.c (go_symbol_package_name): Update.
 616         * guile/scm-block.c (bkscm_print_block_smob): Update.
 617         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 618         (gdbscm_symbol_name): Update.
 619         (gdbscm_symbol_linkage_name): Update.
 620         (gdbscm_symbol_print_name): Update.
 621         * infcall.c (get_function_name): Update.
 622         * infcmd.c (jump_command): Update.
 623         (finish_command): Update.
 624         * infrun.c (insert_exception_resume_breakpoint): Update.
 625         * linespec.c (canonicalize_linespec): Update.
 626         (create_sals_line_offset): Update.
 627         (convert_linespec_to_sals): Update.
 628         (complete_label): Update.
 629         (find_label_symbols_in_block): Update.
 630         * m2-typeprint.c (m2_print_typedef): Update.
 631         * mdebugread.c (mdebug_reg_to_regnum): Update.
 632         (parse_symbol): Update.
 633         (mylookup_symbol): Update.
 634         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 635         (list_args_or_locals): Update.
 636         * objc-lang.c (compare_selectors): Update.
 637         (info_selectors_command): Update.
 638         (compare_classes): Update.
 639         (info_classes_command): Update.
 640         (find_imps): Update.
 641         * p-typeprint.c (pascal_print_typedef): Update.
 642         * printcmd.c (build_address_symbolic): Update.
 643         (info_address_command): Update.
 644         (print_variable_and_value): Update.
 645         * python/py-framefilter.c (extract_sym): Update.
 646         (py_print_single_arg): Update.
 647         * python/py-symbol.c (sympy_str): Update.
 648         (sympy_get_name): Update.
 649         (sympy_get_linkage_name): Update.
 650         * python/python.c (gdbpy_rbreak): Update.
 651         * record-btrace.c (btrace_get_bfun_name): Update.
 652         (btrace_call_history): Update.
 653         * rust-lang.c (rust_print_typedef): Update.
 654         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 655         * stabsread.c (stab_reg_to_regnum): Update.
 656         (define_symbol): Update.
 657         (read_enum_type): Update.
 658         (common_block_end): Update.
 659         (cleanup_undefined_types_1): Update.
 660         (scan_file_globals): Update.
 661         * stack.c (print_frame_arg): Update.
 662         (print_frame_args): Update.
 663         (find_frame_funname): Update.
 664         (info_frame_command_core): Update.
 665         (iterate_over_block_locals): Update.
 666         (print_block_frame_labels): Update.
 667         (do_print_variable_and_value): Update.
 668         (iterate_over_block_arg_vars): Update.
 669         (return_command): Update.
 670         * symmisc.c (dump_symtab_1): Update.
 671         (print_symbol): Update.
 672         * symtab.c (eq_symbol_entry): Update.
 673         (symbol_cache_dump): Update.
 674         (lookup_language_this): Update.
 675         (find_pc_sect_line): Update.
 676         (skip_prologue_sal): Update.
 677         (symbol_search::compare_search_syms): Update.
 678         (treg_matches_sym_type_name): Update.
 679         (search_symbols): Update.
 680         (print_symbol_info): Update.
 681         (rbreak_command): Update.
 682         (completion_list_add_symbol): Update.
 683         (find_gnu_ifunc): Update.
 684         (get_symbol_address): Update.
 685         (search_module_symbols): Update.
 686         (info_module_subcommand): Update.
 687         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 688         (SYMBOL_LINKAGE_NAME): Remove.
 689         (SYMBOL_DEMANGLED_NAME): Remove.
 690         (SYMBOL_PRINT_NAME): Remove.
 691         (SYMBOL_SEARCH_NAME): Remove.
 692         * tracepoint.c (set_traceframe_context): Update.
 693         (validate_actionline): Update.
 694         (collection_list::collect_symbol): Update.
 695         (encode_actions_1): Update.
 696         (info_scope_command): Update.
 697         (print_one_static_tracepoint_marker): Update.
 698         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 699         * valops.c (address_of_variable): Update.
 700         (find_overload_match): Update.
 701         (find_oload_champ): Update.
 702
 703 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * ada-lang.c (ada_lookup_simple_minsym): Update.
 706         (ada_collect_symbol_completion_matches): Update.
 707         * ada-tasks.c (read_atcb): Update.
 708         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 709         (amd64_windows_skip_trampoline_code): Update.
 710         * arm-tdep.c (skip_prologue_function): Update.
 711         (arm_skip_stack_protector): Update.
 712         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 713         (arm_wince_skip_main_prologue): Update.
 714         * ax-gdb.c (gen_expr): Update.
 715         * block.c (call_site_for_pc): Update.
 716         * blockframe.c (find_pc_partial_function): Update.
 717         * breakpoint.c (set_breakpoint_location_function): Update.
 718         * btrace.c (ftrace_print_function_name): Update.
 719         (ftrace_function_switched): Update.
 720         * c-valprint.c (print_unpacked_pointer): Update.
 721         * coffread.c (coff_symfile_read): Update.
 722         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 723         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 724         * dwarf-index-write.c (write_psymbols): Update.
 725         * dwarf2loc.c (call_site_to_target_addr): Update.
 726         (func_verify_no_selftailcall): Update.
 727         (tailcall_dump): Update.
 728         (call_site_find_chain_1): Update.
 729         (dwarf_expr_reg_to_entry_parameter): Update.
 730         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 731         * eval.c (evaluate_funcall): Update.
 732         (evaluate_subexp_standard): Update.
 733         (evaluate_subexp_for_sizeof): Update.
 734         * expprint.c (print_subexp_standard): Update.
 735         (dump_subexp_body_standard): Update.
 736         * frame.c (get_prev_frame_always_1): Update.
 737         * frv-tdep.c (frv_skip_main_prologue): Update.
 738         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 739         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 740         (gnuv3_get_typename_from_type_info): Update.
 741         (gnuv3_skip_trampoline): Update.
 742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 743         * i386-tdep.c (i386_skip_main_prologue): Update.
 744         (i386_pe_skip_trampoline_code): Update.
 745         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 746         * infcall.c (get_function_name): Update.
 747         * linespec.c (minsym_found): Update.
 748         * linux-fork.c (info_checkpoints_command): Update.
 749         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 750         (m32c_m16c_pointer_to_address): Update.
 751         * maint.c (maintenance_translate_address): Update.
 752         * minsyms.c (add_minsym_to_hash_table): Update.
 753         (add_minsym_to_demangled_hash_table): Update.
 754         (lookup_minimal_symbol_mangled): Update.
 755         (lookup_minimal_symbol_demangled): Update.
 756         (lookup_minimal_symbol_linkage): Update.
 757         (lookup_minimal_symbol_text): Update.
 758         (lookup_minimal_symbol_by_pc_name): Update.
 759         (minimal_symbol_is_less_than): Update.
 760         (compact_minimal_symbols): Update.
 761         (build_minimal_symbol_hash_tables): Update.
 762         (find_solib_trampoline_target): Update.
 763         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 764         (mips_skip_pic_trampoline_code): Update.
 765         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 766         * objc-lang.c (info_selectors_command): Update.
 767         (info_classes_command): Update.
 768         (find_methods): Update.
 769         (find_imps): Update.
 770         * p-valprint.c (pascal_val_print): Update.
 771         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 772         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 773         * printcmd.c (build_address_symbolic): Update.
 774         (info_symbol_command): Update.
 775         * psymtab.c (psymbol_name_matches): Update.
 776         (match_partial_symbol): Update.
 777         (lookup_partial_symbol): Update.
 778         (print_partial_symbols): Update.
 779         (sort_pst_symbols): Update.
 780         (maintenance_check_psymtabs): Update.
 781         * python/py-framefilter.c (py_print_frame): Update.
 782         * python/python.c (gdbpy_rbreak): Update.
 783         * record-btrace.c (btrace_get_bfun_name): Update.
 784         (btrace_call_history): Update.
 785         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 786         (rs6000_skip_trampoline_code): Update.
 787         * sol-thread.c (info_cb): Update.
 788         * stabsread.c (scan_file_globals): Update.
 789         * stack.c (find_frame_funname): Update.
 790         (info_frame_command_core): Update.
 791         * symmisc.c (dump_msymbols): Update.
 792         * symtab.c (symbol_natural_name): Rename to..,
 793         (general_symbol_info::natural_name): ...this.
 794         (symbol_demangled_name): Rename to...
 795         (general_symbol_info::demangled_name): ...this.
 796         (symbol_search_name): Rename to...
 797         (general_symbol_info::search_name): ...this.
 798         (symbol_matches_search_name): Update.
 799         (find_pc_sect_line): Update.
 800         (skip_prologue_sal): Update.
 801         (search_symbols): Update.
 802         (print_msymbol_info): Update.
 803         (rbreak_command): Update.
 804         (completion_list_add_msymbol): Update.
 805         (completion_list_objc_symbol): Update.
 806         (get_msymbol_address): Update.
 807         * symtab.h (struct general_symbol_info): Add member functions
 808         natural_name (), linkage_name (), print_name (), demangled_name (),
 809         and search_name ().
 810         (SYMBOL_NATURAL_NAME): Update.
 811         (symbol_natural_name): Move to a member function on general_symbol_info.
 812         (SYMBOL_DEMANGLED_NAME): Update.
 813         (symbol_demangled_name): Move to a member function on
 814         general_symbol_info.
 815         (SYMBOL_SEARCH_NAME): Update.
 816         (symbol_search_name): Move to a member function on general_symbol_info.
 817         (MSYMBOL_NATURAL_NAME): Remove.
 818         (MSYMBOL_LINKAGE_NAME): Remove.
 819         (MSYMBOL_PRINT_NAME): Remove.
 820         (MSYMBOL_DEMANGLED_NAME): Remove.
 821         (MSYMBOL_SEARCH_NAME): Remove.
 822         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 823
 824 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 825
 826         * symtab.c (create_demangled_names_hash): Use per_bfd->
 827         minimal_symbol_count for computing the initial size, if greater
 828         than our default size.
 829
 830 2019-11-22  Tom de Vries  <tdevries@suse.de>
 831
 832         * contrib/words.sh: Improve words extraction.
 833
 834 2019-11-22  Tom de Vries  <tdevries@suse.de>
 835
 836         * contrib/words.sh: Combine sed invocations.
 837
 838 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 839
 840         * Makefile.in: Update.
 841         * demangle.c: Rename to...
 842         * gdb-demangle.c: ..this.
 843         (is_cplus_marker): Change return type to bool.
 844         (_initialize_demangler): Rename to...
 845         (_initialize_gdb_demangle): ...this.
 846         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 847         * symtab.h (demangle): Remove declaration; instead include
 848         gdb-demangle.h.
 849
 850 2019-11-21  Tom Tromey  <tromey@adacore.com>
 851
 852         * gdbsupport/format.c (format_pieces): Parse %I64d.
 853         * unittests/format_pieces-selftests.c (test_windows_formats): New
 854         function.
 855         (run_tests): Call it.
 856
 857 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 858
 859         Byte reverse display of variables with DW_END_big, DW_END_little
 860         (DW_AT_endianity) dwarf attributes if different than the native
 861         byte order.
 862         * ada-lang.c (ada_value_binop):
 863         Use type_byte_order instead of gdbarch_byte_order.
 864         * ada-valprint.c (printstr):
 865         (ada_val_print_string):
 866         * ada-lang.c (value_pointer):
 867         (ada_value_binop):
 868         Use type_byte_order instead of gdbarch_byte_order.
 869         * c-lang.c (c_get_string):
 870         Use type_byte_order instead of gdbarch_byte_order.
 871         * c-valprint.c (c_val_print_array):
 872         Use type_byte_order instead of gdbarch_byte_order.
 873         * cp-valprint.c (cp_print_class_member):
 874         Use type_byte_order instead of gdbarch_byte_order.
 875         * dwarf2loc.c (rw_pieced_value):
 876         Use type_byte_order instead of gdbarch_byte_order.
 877         * dwarf2read.c (read_base_type): Handle DW_END_big,
 878         DW_END_little
 879         * f-lang.c (f_get_encoding):
 880         Use type_byte_order instead of gdbarch_byte_order.
 881         * findvar.c (default_read_var_value):
 882         Use type_byte_order instead of gdbarch_byte_order.
 883         * gdbtypes.c (check_types_equal):
 884         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 885         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 886         and TYPE_ENDIANITY_LITTLE if set.
 887         (type_byte_order): new function.
 888         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 889         (struct main_type) <flag_endianity_not_default>:
 890         New field.
 891         (type_byte_order): New function.
 892         * infcmd.c (default_print_one_register_info):
 893         Use type_byte_order instead of gdbarch_byte_order.
 894         * p-lang.c (pascal_printstr):
 895         Use type_byte_order instead of gdbarch_byte_order.
 896         * p-valprint.c (pascal_val_print):
 897         Use type_byte_order instead of gdbarch_byte_order.
 898         * printcmd.c (print_scalar_formatted):
 899         Use type_byte_order instead of gdbarch_byte_order.
 900         * solib-darwin.c (darwin_current_sos):
 901         Use type_byte_order instead of gdbarch_byte_order.
 902         * solib-svr4.c (solib_svr4_r_ldsomap):
 903         Use type_byte_order instead of gdbarch_byte_order.
 904         * stap-probe.c (stap_modify_semaphore):
 905         Use type_byte_order instead of gdbarch_byte_order.
 906         * target-float.c (target_float_same_format_p):
 907         Use type_byte_order instead of gdbarch_byte_order.
 908         * valarith.c (scalar_binop):
 909         (value_bit_index):
 910         Use type_byte_order instead of gdbarch_byte_order.
 911         * valops.c (value_cast):
 912         Use type_byte_order instead of gdbarch_byte_order.
 913         * valprint.c (generic_emit_char):
 914         (generic_printstr):
 915         (val_print_string):
 916         Use type_byte_order instead of gdbarch_byte_order.
 917         * value.c (unpack_long):
 918         (unpack_bits_as_long):
 919         (unpack_value_bitfield):
 920         (modify_field):
 921         (pack_long):
 922         (pack_unsigned_long):
 923         Use type_byte_order instead of gdbarch_byte_order.
 924         * findvar.c (unsigned_pointer_to_address):
 925         (signed_pointer_to_address):
 926         (unsigned_address_to_pointer):
 927         (address_to_signed_pointer):
 928         (default_read_var_value):
 929         (default_value_from_register):
 930         Use type_byte_order instead of gdbarch_byte_order.
 931         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 932         Use type_byte_order instead of gdbarch_byte_order.
 933         * riscv-tdep.c (riscv_print_one_register_info):
 934         Use type_byte_order instead of gdbarch_byte_order.
 935
 936 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 937
 938         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 939         (current_ui_gdb_stdin_ptr): Likewise.
 940         (current_ui_gdb_stderr_ptr): Likewise.
 941         (current_ui_gdb_stdlog_ptr): Likewise.
 942         (current_ui_current_uiout_ptr): Likewise.
 943         (gen_ret_current_ui_field_ptr): Remove.
 944
 945 2019-11-21  Tom de Vries  <tdevries@suse.de>
 946
 947         PR gdb/24956
 948         * cli/cli-script.c (execute_control_command): Only switch to
 949         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 950
 951 2019-11-19  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 954         Now static.  Change type of "name".
 955         (tui_set_win_height_command): Don't copy "arg".
 956         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 957         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 958
 959 2019-11-19  Ali Tamur <tamur@google.com>
 960
 961         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 962         "if (attr != nullptr)".
 963         (dwarf2_find_base_address): Likewise.
 964         (dwarf2_build_include_psymtabs): Likewise.
 965         (read_cutu_die_from_dwo): Likewise.
 966         (read_func_scope): Likewise.
 967         (read_call_site_scope): Likewise.
 968         (dwarf2_get_pc_bounds): Likewise.
 969         (dwarf2_record_block_ranges): Likewise.
 970         (dwarf2_add_field): Likewise.
 971         (dwarf2_add_member_fn): Likewise.
 972         (read_structure_type): Likewise.
 973         (read_enumeration_type): Likewise.
 974         (read_array_type): Likewise.
 975         (read_array_order): Likewise.
 976         (read_set_type): Likewise.
 977         (read_common_block): Likewise.
 978         (read_tag_reference_type): Likewise.
 979         (read_tag_string_type): Likewise.
 980         (read_subroutine_type): Likewise.
 981         (read_base_type): Likewise.
 982         (read_subrange_type): Likewise.
 983         (new_symbol): Likewise.
 984         (prepare_one_comp_unit): Likewise.
 985
 986 2019-11-19  Tom Tromey  <tromey@adacore.com>
 987
 988         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 989         result in error when DebugActiveProcess fails.
 990
 991 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 992             Pedro Alves  <palves@redhat.com>
 993
 994         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 995         * target.c (target_stack::push): Call 'unpush' if there's a
 996         target on top of the stack.
 997
 998 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 999
1000         * python/py-block.c (blpy_dealloc): Call tp_free.
1001         (blpy_block_syms_dealloc): Likewise.
1002         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1003         * python/py-inferior.c (infpy_dealloc): Likewise.
1004         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1005         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1006         * python/py-symbol.c (sympy_dealloc): Likewise.
1007         * python/py-symtab.c (stpy_dealloc): Likewise.
1008         * python/py-type.c (typy_iterator_dealloc): Likewise.
1009
1010 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1011
1012         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1013         constructor instead of using a class initializer.
1014
1015 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1018         * configure: Regenerate.
1019         * configure.ac: Don't source common.host.
1020         * gdbsupport/common.host: Remove.
1021         * gdbsupport/mingw-strerror.c: Remove.
1022         * gdbsupport/posix-strerror.c: Rename to...
1023         * gdbsupport/safe-strerror.c: ...this.
1024
1025 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1026
1027         * maint.c (scoped_command_stats::print_time): Use localtime_r
1028         instead of localtime (provided through gnulib if necessary).
1029         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1030         of ctime.
1031
1032 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1033
1034         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1035         avoid compile errors.
1036
1037 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1038
1039         * config.in: Regenerate.
1040         * configure: Regenerate.
1041         * gdbsupport/common.m4: No longer check for strerror_r.
1042         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1043         POSIX version of strerror_r, now that gnulib provides it if
1044         necessary.
1045
1046 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1047
1048         * README (`configure' options): Update.
1049
1050 2019-11-14  Tom Tromey  <tromey@adacore.com>
1051
1052         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1053         expected type for the RHS if the LHS is a convenience variable.
1054
1055 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1056
1057         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1058         Provide explicit default and copy constructor.
1059
1060 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1061
1062         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1063         only call Py_INCREF (newbp) in the bppy_pending_object case.
1064
1065 2019-11-13  Tom Tromey  <tromey@adacore.com>
1066
1067         PR build/25182:
1068         * psympriv.h (partial_symbol): Remove static assert.
1069         * symtab.h (general_symbol_info, symbol): Remove static assert.
1070
1071 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1072
1073         * gdbsupport/format.c (format_pieces::format_pieces): Support
1074         printf 'z' size modifier.
1075         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1076         * printcmd.c (ui_printf):  Handle size_t_arg.
1077         * ui-out.c (ui_out::vmessage): Likewise.
1078         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1079         function.
1080         (run_tests): Call test_format_int_sizes.
1081
1082 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1083
1084         * ada-exp.y (write_ambiguous_var): Update.
1085         * buildsym.c (add_symbol_to_list): Update.
1086         * dwarf2read.c (read_variable): Update.
1087         (new_symbol): Update.
1088         * jit.c (finalize_symtab): Update.
1089         * language.c (language_alloc_type_symbol): Update.
1090         * symtab.c (fixup_symbol_section): Update.
1091         (initialize_objfile_symbol_1): Move code to...
1092         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1093         (allocate_symbol): Update.
1094         (allocate_template_symbol): Update.
1095         (get_symbol_address): Update.
1096         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1097         of having as a field, and add a constructor.
1098         (SYMBOL_VALUE): Update.
1099         (SYMBOL_VALUE_ADDRESS): Update.
1100         (SET_SYMBOL_VALUE_ADDRESS): Update.
1101         (SYMBOL_VALUE_BYTES): Update.
1102         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1103         (SYMBOL_BLOCK_VALUE): Update.
1104         (SYMBOL_VALUE_CHAIN): Update.
1105         (SYMBOL_LANGUAGE): Update.
1106         (SYMBOL_SECTION): Update.
1107         (SYMBOL_OBJ_SECTION): Update.
1108         (SYMBOL_SET_LANGUAGE): Update.
1109         (SYMBOL_SET_LINKAGE_NAME): Update.
1110         (SYMBOL_SET_NAMES): Update.
1111         (SYMBOL_NATURAL_NAME): Update.
1112         (SYMBOL_LINKAGE_NAME): Update.
1113         (SYMBOL_DEMANGLED_NAME): Update.
1114         (SYMBOL_SEARCH_NAME): Update.
1115         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1116         (struct symbol): Update.
1117         (struct template_symbol): Update.
1118         (struct rust_vtable_symbol): Update.
1119         * xcoffread.c (SYMBOL_DUP): Update.
1120
1121 2019-11-12  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-layout.c (show_layout): Set current_layout.
1124         (show_source_disasm_command, show_data)
1125         (show_source_or_disasm_and_command): Don't set current_layout.
1126
1127 2019-11-12  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1130
1131 2019-11-12  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-win.c (resize_message): New global.
1134         (show_tui_resize_message): New function.
1135         (tui_async_resize_screen): Print message if requested.
1136         (_initialize_tui_win): Add tui-resize-message setting.
1137         * NEWS: Add entry for new commands.
1138
1139 2019-11-11  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1142         functions.
1143
1144 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1145
1146         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1147
1148 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1151         function.
1152         * python/python-internal.h (gdbpy_lookup_static_symbols):
1153         Declare new function.
1154         * python/python.c (python_GdbMethods): Add
1155         gdb.lookup_static_symbols method.
1156         * NEWS: Mention gdb.lookup_static_symbols.
1157
1158 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1161         static block of current object file first.  Also fix typo in
1162         header comment.
1163
1164 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * stack.c (set_last_displayed_sal): Delete.
1167         (last_displayed_sal_valid): Delete.
1168         (last_displayed_pspace): Delete.
1169         (last_displayed_addr): Delete.
1170         (last_displayed_symtab): Delete.
1171         (last_displayed_line): Delete.
1172         (class last_displayed_symtab_info_type): New.
1173         (last_displayed_symtab_info): New static global variable.
1174         (print_frame_info): Call methods on last_displayed_symtab_info.
1175         (clear_last_displayed_sal): Update header comment, and make use of
1176         last_displayed_symtab_info.
1177         (last_displayed_sal_is_valid): Likewise.
1178         (get_last_displayed_pspace): Likewise.
1179         (get_last_displayed_addr): Likewise.
1180         (get_last_displayed_symtab): Likewise.
1181         (get_last_displayed_line): Likewise.
1182         (get_last_displayed_sal): Likewise.
1183         * stack.h (clear_last_displayed_sal): Update header comment.
1184         (last_displayed_sal_is_valid): Likewise.
1185         (get_last_displayed_pspace): Likewise.
1186         (get_last_displayed_addr): Likewise.
1187         (get_last_displayed_symtab): Likewise.
1188         (get_last_displayed_line): Likewise.
1189         (get_last_displayed_sal): Likewise.
1190
1191 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * stack.c (frame_show_address): Convert return type to bool.
1194         * stack.h (frame_show_address): Likewise, and update header
1195         comment.
1196
1197 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1200         * unittests/vec-utils-selftests.c: New file.
1201         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1202
1203 2019-11-10  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1206         (tui_highlight_win): Likewise.
1207         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1208         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1209         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1210         Don't set can_highlight.
1211
1212 2019-11-10  Tom Tromey  <tom@tromey.com>
1213
1214         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1215         Remove unused declaration.
1216
1217 2019-11-08  Tom Tromey  <tromey@adacore.com>
1218
1219         * top.c (read_command_file): Update.
1220         (command_line_input): Make return type const.
1221         * python/py-gdb-readline.c: Update.
1222         * linespec.c (decode_line_2): Update.
1223         * defs.h (command_line_input): Make return type const.
1224         * cli/cli-script.c (read_next_line): Make return type const.
1225         * ada-lang.c (get_selections): Update.
1226
1227 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1228
1229         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1230         * mi/mi-main.c (output_cores): Likewise.
1231         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1232         (linux_xfer_osdata_modules): Likewise.
1233         * remote.c (register_remote_support_xml): Likewise.
1234         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1235         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1236
1237 2019-11-06  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-interp.c: Don't include readline.h.
1240         * tui/tui-hooks.c: Don't include readline.h.
1241         * symmisc.c: Include tilde.h, not readline.h.
1242         * symfile.c: Include tilde.h, not readline.h.
1243         * source.c: Include tilde.h, not readline.h.
1244         * solib.c: Include tilde.h, not readline.h.
1245         * psymtab.c: Include tilde.h, not readline.h.
1246         * exec.c: Include tilde.h, not readline.h.
1247         * corelow.c: Include tilde.h, not readline.h.
1248         * cli/cli-dump.c: Include tilde.h, not readline.h.
1249         * cli/cli-cmds.c: Don't include readline.h.
1250
1251 2019-11-05  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1254         (tui_disassemble): Set addr_size.
1255         (tui_disasm_window::set_contents): Use addr_size.
1256
1257 2019-11-05  Tom Tromey  <tom@tromey.com>
1258
1259         * rust-lang.c (rust_language_defn): Update.
1260         * python/py-value.c (valpy_string): Call c_get_string.
1261         * p-lang.c (pascal_language_defn): Update.
1262         * opencl-lang.c (opencl_language_defn): Update.
1263         * objc-lang.c (objc_language_defn): Update.
1264         * m2-lang.c (m2_language_defn): Update.
1265         * language.c (unknown_language_defn, auto_language_defn): Update.
1266         (default_get_string): Remove.
1267         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1268         * go-lang.c (go_language_defn): Update.
1269         * f-lang.c (f_language_defn): Update.
1270         * d-lang.c (d_language_defn): Update.
1271         * c-lang.c (c_language_defn, cplus_language_defn)
1272         (asm_language_defn, minimal_language_defn): Update.
1273         * ada-lang.c (ada_language_defn): Update.
1274         * language.h (struct language_defn) <la_get_string>: Remove.
1275         (LA_GET_STRING): Remove.
1276         (default_get_string): Don't declare.
1277
1278 2019-11-05  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-source.h (struct tui_source_window): Inline
1281         constructor.  Remove destructor.
1282         <style_changed, m_observable>: Move to superclass.
1283         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1284         (struct tui_source_window_base): Move private members to end.
1285         <style_changed, m_observable>: Move from tui_source_window.
1286         * tui/tui-winsource.c (tui_copy_source_line): Move from
1287         tui-source.c.  Rename from copy_source_line.  Add special handling
1288         for negative line number.
1289         (tui_source_window_base::style_changed): Move from
1290         tui_source_window.
1291         (tui_source_window_base): Register observer.
1292         (~tui_source_window_base): New.
1293         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1294         rename.
1295         (tui_source_window::set_contents): Use tui_copy_source_line.
1296         (tui_source_window::tui_source_window): Move to tui-source.h.
1297         (tui_source_window::~tui_source_window): Remove.
1298         (tui_source_window::style_changed): Move to superclass.
1299         * tui/tui-disasm.c (tui_disassemble): Create string file with
1300         styling, when possible.  Add "addr_size" parameter.
1301         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1302         Don't compute maximum size.
1303         (len_without_escapes): New function
1304
1305 2019-11-05  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1308         std::string.
1309         * tui/tui-winsource.c (tui_show_source_line): Update.
1310         * tui/tui-source.c (tui_source_window::set_contents): Update.
1311         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1312
1313 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1314
1315         * symtab.h (gdb_static_assert): Put && operator at the beginning
1316         of the line instead of the end.
1317
1318 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1321         and sizeof (symbol).
1322         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1323
1324 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1325
1326         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1327         * configure.host: Mark *-*-solaris2.10* obsolete.
1328         * configure.tgt: Mark Solaris < 11 obsolete.
1329         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1330         Update target triplet.
1331
1332 2019-11-01  Tom Tromey  <tromey@adacore.com>
1333
1334         * utils.c (print_sys_errmsg): Simplify.
1335
1336 2019-11-01  Tom Tromey  <tromey@adacore.com>
1337
1338         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1339
1340 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1341
1342         * configure: Regenerate.
1343         * configure.ac: Remove check for strerror_r.
1344         * gdbsupport/common.m4: Check for strerror_r.
1345
1346 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1347
1348         PR gdb/25124
1349
1350         * arm-tdep.c (arm_per_objfile): Rename to ...
1351         (arm_per_bfd): ... this.
1352         (arm_objfile_data_key): Rename to ...
1353         (arm_bfd_data_key): ... this.
1354         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1355         data.
1356         (arm_record_special_symbol): Likewise.
1357
1358 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1361         end.
1362         * c-typeprint.c (c_print_typedef): Likewise.
1363         * f-typeprint.c (f_print_typedef): Likewise.
1364         * m2-typeprint.c (m2_print_typedef): Likewise.
1365         * p-typeprint.c (pascal_print_typedef): Likewise.
1366         * rust-lang.c (rust_print_typedef): Likewise.
1367         * symtab.c (print_symbol_info): Print a newline after calling
1368         typedef_print.
1369
1370 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * symtab.c (info_module_cmdlist): New variable.
1373         (info_module_command): New function.
1374         (search_module_symbols): New function.
1375         (info_module_subcommand): New function.
1376         (struct info_modules_var_func_options): New struct.
1377         (info_modules_var_func_options_defs): New variable.
1378         (make_info_modules_var_func_options_def_group): New function.
1379         (info_module_functions_command): New function.
1380         (info_module_variables_command): New function.
1381         (info_module_var_func_command_completer): New function.
1382         (_initialize_symtab): Register new 'info module functions' and
1383         'info module variables' commands.
1384         * symtab.h (typedef symbol_search_in_module): New typedef.
1385         (search_module_symbols): Declare new function.
1386         * NEWS: Mention new commands.
1387
1388 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1391         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1392         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1393         MODULES_DOMAIN.
1394         (scan_partial_symbols): Only create partial module symbols for non
1395         declarations.
1396         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1397         and MODULES_DOMAIN.
1398         * symtab.c (search_domain_name): Likewise.
1399         (search_symbols): Likewise.
1400         (print_symbol_info): Likewise.
1401         (symtab_symbol_info): Likewise.
1402         (info_modules_command): New function.
1403         (_initialize_symtab): Register 'info modules' command.
1404         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1405         * NEWS: Mention new 'info modules' command.
1406
1407 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1408
1409         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1410         and $_gdb_maint_setting_str.
1411
1412 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1413
1414         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1415         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1416         (str_value_from_setting, gdb_setting_str_internal_fn)
1417         (gdb_maint_setting_str_internal_fn): New functions.
1418         (_initialize_cli_cmds): Define the new convenience functions.
1419         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1420         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1421
1422 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * agent.c (set_can_use_agent): When the setting is turned on,
1425         look up agent symbols if we don't have them yet.
1426         (agent_new_objfile): Don't look up agent symbols when the agent
1427         setting is off.
1428
1429 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1430
1431         * config.in: Regenerate.
1432
1433 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * configure: Regenerate.
1436         * configure.ac: Check for strerror_r.
1437         * gdbsupport/common-utils.h (safe_strerror): Change return value
1438         to const char * and document that this function is now threadsafe.
1439         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1440         thread_local and call strerror_r, if available.
1441         * utils.c (perror_string): Update.
1442         (print_sys_errmsg): Update.
1443
1444 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1445
1446         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1447         objfile_key.
1448         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1449         objfile to fetch per-bfd data.
1450         (arm_find_exidx_entry): Likewise.
1451
1452 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1453
1454         * gdbsupport/agent.c (debug_agent): Change type to bool.
1455         (use_agent): Likewise.
1456         (all_agent_symbols_look_up): Likewise.
1457         (agent_loaded_p): Change return value to bool.
1458         (agent_look_up_symbols): Update.
1459         (agent_capability_check): Change return value to bool.
1460         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1461         (debug_agent): Change type to bool.
1462         (use_agent): Likewise.
1463         (agent_capability_check): Change return value to bool.
1464
1465 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1466
1467         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1468         (build_minimal_symbol_hash_tables): Code to clear the table moved
1469         to clear_minimal_symbol_hash_tables.
1470         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1471         when needed.
1472
1473 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1474
1475         * infcmd.c: Remove includes.
1476         * infrun.c: Remove includes.
1477
1478 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1479
1480         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1481         (grow_vect): Remove declaration.
1482         (ada_type_of_array): Remove declaration.
1483         (ada_update_initial_language): Remove declaration.
1484         (ada_fold_name): Remove declaration.
1485         (ada_fill_in_ada_prototype): Remove declaration.
1486         (user_select_syms): Remove declaration.
1487         (get_selections): Remove declaration.
1488         (ada_tag_type): Remove declaration.
1489         (ada_value_tag): Remove declaration.
1490         (ada_is_others_clause): Remove declaration.
1491         (ada_in_variant): Remove declaration.
1492         (ada_value_struct_elt): Remove declaration.
1493         (ada_attribute_name): Remove declaration.
1494         (ada_system_address_type): Remove declaration.
1495         * ada-lang.c (ada_watch_location_expression): Make static.
1496         (GROW_VECT): Move here from ada-lang.h.
1497         (grow_vect): Make static.
1498         (ada_update_initial_language): Make static.
1499         (ada_fold_name): Make static.
1500         (ada_type_of_array): Make static.
1501         (encoded_ordered_before): Move up.
1502         (sort_choices): Move up.
1503         (print_signatures): Move up.
1504         (ada_print_symbol_signature): Move up.
1505         (get_selections): Move up and make static.
1506         (user_select_syms): Move up and make static.
1507         (ada_value_struct_elt): Move up and make static.
1508         (ada_tag_type): Make static.
1509         (ada_value_tag): Make static.
1510         (ada_is_others_clause): Make static.
1511         (ada_in_variant): Make static.
1512         (ada_attribute_name): Make static.
1513
1514 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1515
1516         * ada-lang.c: Remove includes.
1517         * ada-typeprint.c: Remove includes.
1518         * ada-valprint.c: Remove includes.
1519
1520 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1521
1522         * addrmap.c: Add static assertions of type size, moved from
1523         _initialize_addrmap.
1524         (_initialize_addrmap): Remove.
1525
1526 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1527
1528         * coffread.c (record_minimal_symbol): Update.
1529         (process_coff_symbol): Update.
1530         * dbxread.c (read_dbx_symtab): Update.
1531         * dwarf2read.c (add_partial_symbol): Update.
1532         (fixup_go_packaging): Update.
1533         (load_partial_dies): Update.
1534         (new_symbol): Update.
1535         * elfread.c (record_minimal_symbol): Change signature to use
1536         gdb::string_view instead of name+len.
1537         (elf_symtab_read): Update.
1538         (elf_rel_plt_read): Update.
1539         * mdebugread.c (parse_partial_symbols): Update.
1540         (handle_psymbol_enumerators): Update.
1541         (new_symbol): Update.
1542         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1543         to use gdb::string_view instead of name+len.
1544         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1545         * psympriv.h (add_psymbol_to_list): Likewise.
1546         * psymtab.c (add_psymbol_to_bcache): Likewise.
1547         (add_psymbol_to_list): Likewise.
1548         * stabsread.c (define_symbol): Update.
1549         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1550         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1551         (symbol_set_names): Likewise.
1552         * xcoffread.c (scan_xcoff_symtab): Update.
1553
1554 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1555
1556         * symtab.h (symbol_set_names): Document that copy_name must be
1557         set to true for non-nullterminated strings.
1558         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1559         linkage_name if the entry was not found and we need to demangle.
1560
1561 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1562
1563         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1564         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1565         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1566         * gdbsupport/gdb_binary_search.h: New file.
1567
1568 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1569
1570         * NEWS: Mention new --with-system-gdbinit-dir option.
1571         * config.in: Regenerate.
1572         * configure: Regenerate.
1573         * configure.ac: Add new option --with-system-gdbinit-dir.
1574         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1575         for a ".gdb" suffix.
1576         * main.c (get_init_files): Change system_gdbinit argument to
1577         a vector and return the files in SYSTEM_GDBINIT_DIR in
1578         addition to SYSTEM_GDBINIT.
1579         (captured_main_1): Update.
1580         (print_gdb_help): Update.
1581         * top.c (print_gdb_configuration): Also print the value of
1582         SYSTEM_GDBINIT_DIR.
1583
1584 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1585
1586         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1587         that takes gdb::string_view arguments.
1588
1589 2019-10-26  Tom de Vries  <tdevries@suse.de>
1590
1591         * aarch64-linux-tdep.c: Fix typos in comments.
1592         * aarch64-tdep.c: Same.
1593         * ada-lang.c: Same.
1594         * amd64-nat.c: Same.
1595         * arc-tdep.c: Same.
1596         * arch/aarch64-insn.c: Same.
1597         * block.c: Same.
1598         * breakpoint.h: Same.
1599         * btrace.h: Same.
1600         * c-varobj.c: Same.
1601         * cli/cli-decode.c: Same.
1602         * cli/cli-script.c: Same.
1603         * cli/cli-utils.h: Same.
1604         * coff-pe-read.c: Same.
1605         * coffread.c: Same.
1606         * compile/compile-cplus-symbols.c: Same.
1607         * compile/compile-object-run.c: Same.
1608         * completer.c: Same.
1609         * corelow.c: Same.
1610         * cp-support.c: Same.
1611         * demangle.c: Same.
1612         * dwarf-index-write.c: Same.
1613         * dwarf2-frame.c: Same.
1614         * dwarf2-frame.h: Same.
1615         * eval.c: Same.
1616         * frame-base.h: Same.
1617         * frame.h: Same.
1618         * gdbcmd.h: Same.
1619         * gdbtypes.h: Same.
1620         * gnu-nat.c: Same.
1621         * guile/scm-objfile.c: Same.
1622         * i386-tdep.c: Same.
1623         * i386-tdep.h: Same.
1624         * infcall.c: Same.
1625         * infcall.h: Same.
1626         * linux-nat.c: Same.
1627         * m68k-tdep.c: Same.
1628         * macroexp.c: Same.
1629         * memattr.c: Same.
1630         * mi/mi-cmd-disas.c: Same.
1631         * mi/mi-getopt.h: Same.
1632         * mi/mi-main.c: Same.
1633         * minsyms.c: Same.
1634         * nat/aarch64-sve-linux-sigcontext.h: Same.
1635         * objfiles.h: Same.
1636         * ppc-linux-nat.c: Same.
1637         * ppc-linux-tdep.c: Same.
1638         * ppc-tdep.h: Same.
1639         * progspace.h: Same.
1640         * prologue-value.h: Same.
1641         * python/py-evtregistry.c: Same.
1642         * python/py-instruction.h: Same.
1643         * record-btrace.c: Same.
1644         * record-full.c: Same.
1645         * remote.c: Same.
1646         * rs6000-tdep.c: Same.
1647         * ser-tcp.c: Same.
1648         * sol-thread.c: Same.
1649         * sparc-sol2-tdep.c: Same.
1650         * sparc64-tdep.c: Same.
1651         * stabsread.c: Same.
1652         * symfile.c: Same.
1653         * symtab.h: Same.
1654         * target.c: Same.
1655         * tracepoint.c: Same.
1656         * tui/tui-data.h: Same.
1657         * tui/tui-io.c: Same.
1658         * tui/tui-win.c: Same.
1659         * tui/tui.c: Same.
1660         * unittests/rsp-low-selftests.c: Same.
1661         * user-regs.h: Same.
1662         * utils.c: Same.
1663         * utils.h: Same.
1664         * valarith.c: Same.
1665         * valops.c: Same.
1666         * valprint.c: Same.
1667         * valprint.h: Same.
1668         * value.c: Same.
1669         * value.h: Same.
1670         * varobj.c: Same.
1671         * x86-nat.h: Same.
1672         * xtensa-tdep.c: Same.
1673
1674 2019-10-25  Ali Tamur <tamur@google.com>
1675
1676         * charset.c (find_charset_names): Reflect API change.
1677
1678 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1679
1680         * symtab.c (struct demangled_name_entry): Change demangled name
1681         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1682         part of the struct anymore.
1683         (symbol_set_names): No longer obstack allocate + copy the demangled
1684         name, just store the allocated name from bfd.
1685
1686 2019-10-25  Tom Tromey  <tromey@adacore.com>
1687
1688         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1689         (bsearch_cie_cmp, add_cie): Remove.
1690         (find_cie): Reimplement.
1691         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1692         (dwarf2_build_frame_info): Update.
1693
1694 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1695
1696         PR gdb/25126
1697         * symfile.c (reread_symbols): Call forget_cached_source_info to
1698         clear the stale source cache.
1699
1700 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1701
1702         * configure: Regenerate.
1703         * configure.ac: Remove code that sets python_has_threads.
1704
1705 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1706
1707         * config.in: Regenerate.
1708         * configure: Regenerate.
1709         * configure.ac: Remove the code that uses sed to get the python
1710         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1711
1712 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1715         error paths.
1716
1717 2019-10-23  Tom Tromey  <tom@tromey.com>
1718
1719         * arc-tdep.c: Remove ".." from include.
1720         * frv-tdep.c: Remove ".." from include.
1721         * lm32-tdep.c: Remove ".." from include.
1722         * microblaze-tdep.c: Remove ".." from include.
1723         * or1k-tdep.h: Remove ".." from include.
1724         * s12z-tdep.c: Remove ".." from include.
1725         * Makefile.in (OPCODES_CFLAGS): Add comment.
1726         (TOP_CFLAGS): New variable.
1727         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1728
1729 2019-10-23  Tom Tromey  <tom@tromey.com>
1730
1731         * Makefile.in (READLINE_DIR): Update.
1732
1733 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1734
1735         * infcall.c (call_function_by_hand_dummy): Fix the function
1736         comment.  And extract out a code section into...
1737         (reserve_stack_space): ...this new function.
1738
1739 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1740
1741         * infcall.c (value_arg_coerce): Remove an unused parameter.
1742         (call_function_by_hand_dummy): Update the call to
1743         'value_arg_coerce'.
1744
1745 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1746
1747         * infcall.c (call_function_by_hand_dummy): Refactor.
1748
1749 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1750
1751         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1752
1753 2019-10-23  Tom Tromey  <tom@tromey.com>
1754
1755         * configure: Rebuild.
1756         * configure.ac: Don't check for sigprocmask.
1757         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1758
1759 2019-10-23  Tom Tromey  <tom@tromey.com>
1760
1761         * configure: Rebuild.
1762         * acinclude.m4: Use m4_include, not sinclude.
1763
1764 2019-10-23  Tom de Vries  <tdevries@suse.de>
1765
1766         PR breakpoints/24687
1767         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1768
1769 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1770
1771         * symtab.c (struct demangled_name_entry) <language>: Change from
1772         bitfield to regular variable.
1773
1774 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1775
1776         * symtab.c (struct demangled_name_entry): Add a constructor.
1777         (free_demangled_name_entry): New function to call the destructor
1778         for demangled_name_entry.
1779         (create_demangled_names_hash): Pass free_demangled_name_entry to
1780         htab_create_alloc.
1781         (symbol_set_names): Call placement new for demangled_name_entry.
1782         * utils.c: No longer include xxhash.h here, now that fast_hash
1783         is inlined in the header.
1784         * utils.h: Instead, include it here.
1785
1786 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1787
1788         * Makefile.in: Link with libxxhash.
1789         * config.in: Regenerate.
1790         * configure: Regenerate.
1791         * configure.ac: Search for libxxhash.
1792         * utils.c (fast_hash): Use xxhash if present.
1793
1794 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1795
1796         * utils.h (fast_hash): New function.
1797         * symtab.c (hash_demangled_name_entry): Call new function
1798         fast_hash.
1799
1800 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1801
1802         * symtab.c (struct demangled_name_entry): Change type of mangled
1803         to gdb::string_view. Also adds a constructor that takes the
1804         mangled name.
1805         (hash_demangled_name_entry): Update.
1806         (eq_demangled_name_entry): Update.
1807         (free_demangled_name_entry): New function to call the destructor
1808         now that this is not a POD anymore.
1809         (create_demangled_names_hash): Pass free_demangled_name_entry to
1810         htab_create_alloc.
1811         (symbol_set_names): Update.
1812
1813 2019-10-21  Ali Tamur  <tamu@google.com>
1814
1815         * dwarf2read.c (dir_index): Change type.
1816         (file_name_index): Likewise.
1817         (line_header::include_dir_at): Change comment and implementation on
1818         whether it is DWARF 5.
1819         (line_header::is_valid_file_index): New function.
1820         (line_header::file_name_at): Change comment and implementation on
1821         whether it is DWARF 5.
1822         (line_header::file_names): Change to private field renamed as
1823         m_file_names and introduce a new accessor method.
1824         (line_header::file_names_size): New method.
1825         (line_header::include_dirs): Change to private field and rename as
1826         m_include_dirs.
1827         (dw2_get_file_names_reader): Define local var at a smaller scope and
1828         reflect API change.
1829         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1830         (process_structure_scope): Likewise.
1831         (line_header::add_include_dir): Change message and reflect renaming.
1832         (line_header::add_file_name): Likewise.
1833         (read_formatted_entries): Handle DW_FORM_data16.
1834         (dwarf_decode_line_header): Fix line header length calculation.
1835         (psymtab_include_file_name): Change comment and API.
1836         (lnp_state_machine::m_file): Update comment and reflect type change.
1837         (lnp_state_machine::record_line): Reflect type change.
1838         (dwarf_decode_lines): Reflect API change.
1839         (file_file_name): Likewise.
1840         (file_full_name): Likewise.
1841
1842 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1845
1846 2019-10-21  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1849
1850 2019-10-21  Tom Tromey  <tom@tromey.com>
1851
1852         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1853         NM_H.   Use AC_CONFIG_LINKS.
1854         * configure: Rebuild.
1855         * Makefile.in (NM_H): New variable.
1856         (generated_files): Add NM_H.  Remove gcore.
1857         (nm.h, stamp-nmh): New targets.
1858
1859 2019-10-20  Tom Tromey  <tom@tromey.com>
1860
1861         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1862         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1863         obsolete comment.
1864         (put_objfile_before): Now static.
1865
1866 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1867
1868         * gdbsupport/common-utils.h (startswith): Change return type to
1869         bool.
1870
1871 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1872
1873         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1874         * breakpoint.c (bp_locations_compare): Rename to...
1875         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1876         (update_global_location_list): Use std::sort instead of qsort.
1877         * buildsym.c (compare_line_numbers): Rename to...
1878         (lte_is_less_than): ...this, and change to std::sort semantics.
1879         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1880         instead of qsort.
1881         * disasm.c (compare_lines): Rename to...
1882         (line_is_less_than): ...this, and change to std::sort semantics.
1883         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1884         of qsort.
1885         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1886         (fde_is_less_than): ...this, and change to std::sort semantics.
1887         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1888         * mdebugread.c (compare_blocks):
1889         (block_is_less_than): ...this, and change to std::sort semantics.
1890         (sort_blocks): Call std::sort instead of qsort.
1891         * objfiles.c (qsort_cmp): Rename to...
1892         (sort_cmp): ...this, and change to std::sort semantics.
1893         (update_section_map): Call std::sort instead of qsort.
1894         * remote.c (compare_pnums): Remove.
1895         (map_regcache_remote_table): Call std::sort instead of qsort.
1896         * utils.c (compare_positive_ints): Remove.
1897         * utils.h (compare_positive_ints): Remove.
1898         * xcoffread.c (compare_lte): Remove.
1899         (arrange_linetable): Call std::sort instead of qsort.
1900
1901 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1902
1903         * symfile.c (init_entry_point_info): Fix typo.
1904         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1905
1906 2019-10-18  Tom de Vries  <tdevries@suse.de>
1907
1908         * aarch64-tdep.c: Fix typos in comments.
1909         * ada-lang.c: Same.
1910         * ada-tasks.c: Same.
1911         * alpha-tdep.c: Same.
1912         * alpha-tdep.h: Same.
1913         * amd64-nat.c: Same.
1914         * amd64-windows-tdep.c: Same.
1915         * arc-tdep.c: Same.
1916         * arc-tdep.h: Same.
1917         * arch-utils.c: Same.
1918         * arm-nbsd-tdep.c: Same.
1919         * arm-tdep.c: Same.
1920         * ax-gdb.c: Same.
1921         * blockframe.c: Same.
1922         * btrace.c: Same.
1923         * c-varobj.c: Same.
1924         * coff-pe-read.c: Same.
1925         * coffread.c: Same.
1926         * cris-tdep.c: Same.
1927         * darwin-nat.c: Same.
1928         * dbxread.c: Same.
1929         * dcache.c: Same.
1930         * disasm.c: Same.
1931         * dtrace-probe.c: Same.
1932         * dwarf-index-write.c: Same.
1933         * dwarf2-frame-tailcall.c: Same.
1934         * dwarf2-frame.c: Same.
1935         * dwarf2read.c: Same.
1936         * eval.c: Same.
1937         * exceptions.c: Same.
1938         * fbsd-tdep.c: Same.
1939         * findvar.c: Same.
1940         * frame.c: Same.
1941         * frv-tdep.c: Same.
1942         * gnu-v3-abi.c: Same.
1943         * go32-nat.c: Same.
1944         * h8300-tdep.c: Same.
1945         * hppa-tdep.c: Same.
1946         * i386-linux-tdep.c: Same.
1947         * i386-tdep.c: Same.
1948         * ia64-libunwind-tdep.c: Same.
1949         * ia64-tdep.c: Same.
1950         * infcmd.c: Same.
1951         * infrun.c: Same.
1952         * linespec.c: Same.
1953         * linux-nat.c: Same.
1954         * linux-thread-db.c: Same.
1955         * machoread.c: Same.
1956         * mdebugread.c: Same.
1957         * mep-tdep.c: Same.
1958         * mn10300-tdep.c: Same.
1959         * namespace.c: Same.
1960         * objfiles.c: Same.
1961         * opencl-lang.c: Same.
1962         * or1k-tdep.c: Same.
1963         * osabi.c: Same.
1964         * ppc-linux-nat.c: Same.
1965         * ppc-linux-tdep.c: Same.
1966         * ppc-sysv-tdep.c: Same.
1967         * printcmd.c: Same.
1968         * procfs.c: Same.
1969         * record-btrace.c: Same.
1970         * record-full.c: Same.
1971         * remote-fileio.c: Same.
1972         * remote.c: Same.
1973         * rs6000-tdep.c: Same.
1974         * s12z-tdep.c: Same.
1975         * score-tdep.c: Same.
1976         * ser-base.c: Same.
1977         * ser-go32.c: Same.
1978         * skip.c: Same.
1979         * sol-thread.c: Same.
1980         * solib-svr4.c: Same.
1981         * solib.c: Same.
1982         * source.c: Same.
1983         * sparc-nat.c: Same.
1984         * sparc-sol2-tdep.c: Same.
1985         * sparc-tdep.c: Same.
1986         * sparc64-tdep.c: Same.
1987         * stabsread.c: Same.
1988         * stack.c: Same.
1989         * symfile.c: Same.
1990         * symtab.c: Same.
1991         * target-descriptions.c: Same.
1992         * target-float.c: Same.
1993         * thread.c: Same.
1994         * utils.c: Same.
1995         * valops.c: Same.
1996         * valprint.c: Same.
1997         * value.c: Same.
1998         * varobj.c: Same.
1999         * windows-nat.c: Same.
2000         * xcoffread.c: Same.
2001         * xstormy16-tdep.c: Same.
2002         * xtensa-tdep.c: Same.
2003
2004 2019-10-17  Tom Tromey  <tromey@adacore.com>
2005
2006         * configure: Rebuild.
2007         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2008         in AC_CONFIG_FILES invocation.
2009         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2010         new-style config.status invocation.
2011
2012 2019-10-17  Tom de Vries  <tdevries@suse.de>
2013
2014         * arm-nbsd-nat.c: Fix typos in comments.
2015         * arm-tdep.c: Same.
2016         * darwin-nat-info.c: Same.
2017         * dwarf2read.c: Same.
2018         * elfread.c: Same.
2019         * event-top.c: Same.
2020         * findvar.c: Same.
2021         * gdbtypes.c: Same.
2022         * hppa-tdep.c: Same.
2023         * i386-tdep.c: Same.
2024         * jit.c: Same.
2025         * main.c: Same.
2026         * mdebugread.c: Same.
2027         * moxie-tdep.c: Same.
2028         * nto-procfs.c: Same.
2029         * osabi.c: Same.
2030         * ppc-linux-tdep.c: Same.
2031         * remote.c: Same.
2032         * riscv-tdep.c: Same.
2033         * s390-tdep.c: Same.
2034         * sh-tdep.c: Same.
2035         * sparc-linux-tdep.c: Same.
2036         * sparc-nat.c: Same.
2037         * stack.c: Same.
2038         * target-descriptions.c: Same.
2039         * top.c: Same.
2040         * varobj.c: Same.
2041
2042 2019-10-16  Tom Tromey  <tom@tromey.com>
2043
2044         * objfiles.h (struct objfile) <original_name>: Now const.
2045
2046 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2047
2048         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2049         pass on to sigsetjmp's second argument.
2050         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2051
2052 2019-10-16  Keith Seitz  <keiths@redhat.com>
2053
2054         PR gdb/23567
2055         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2056         sections whose size is greater than the file size.
2057
2058 2019-10-16  Jim Wilson  <jimw@sifive.com>
2059
2060         * riscv-tdep.c (riscv_gcc_target_options): New.
2061         (riscv_gnu_triplet_regexp): New.
2062         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2063         set_gdbarch_gnu_triplet_regexp.
2064
2065 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2066
2067         * Makefile.in: Add xml-builtin.h.
2068         * features/feature_to_c.sh: Add an include for xml-builtin.h
2069         to ensure that the compiler checks that the types match.
2070         * xml-builtin.h: New file.
2071         * xml-support.c (fetch_xml_builtin): Add missing const.
2072         * xml-support.h: Remove declaration of xml_builtins.
2073
2074 2019-10-16  Tom de Vries  <tdevries@suse.de>
2075
2076         PR tdep/25096
2077         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2078         (amd64_classify_aggregate): ... here.
2079         (amd64_classify_aggregate_field): Handled fiels of nested structs
2080         recursively.
2081
2082 2019-10-16  Tom de Vries  <tdevries@suse.de>
2083
2084         PR tdep/24104
2085         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2086         that handles 'theclass'.
2087
2088 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * linespec.c (decode_digits_ordinary): Update comment.
2091         * make-target-delegates: No longer need to handle VEC case.
2092         * memrange.c (normalize_mem_ranges): Update comment.
2093         * namespace.c (add_using_directive): Update comment.
2094         * objc-lang.c (uniquify_strings): Update comment.
2095         * ppc-linux-nat.c (struct thread_points): Update comment.
2096         * probe.h (find_probes_in_objfile): Update comment.
2097         * target.h (enum flash_preserve_mode): Update comment.
2098         * varobj.c (varobj_restrict_range): Update comment.
2099         * varobj.h (varobj_list_children): Update comment.
2100
2101 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * Makefile.in: Remove references to vec.h and vec.c.
2104         * aarch64-tdep.c: No longer include vec.h.
2105         * ada-lang.c: Likewise.
2106         * ada-lang.h: Likewise.
2107         * arm-tdep.c: Likewise.
2108         * ax.h: Likewise.
2109         * breakpoint.h: Likewise.
2110         * charset.c: Likewise.
2111         * cp-support.h: Likewise.
2112         * dtrace-probe.c: Likewise.
2113         * dwarf2read.c: Likewise.
2114         * extension.h: Likewise.
2115         * gdb_bfd.c: Likewise.
2116         * gdbsupport/gdb_vecs.h: Likewise.
2117         * gdbsupport/vec.c: Remove.
2118         * gdbsupport/vec.h: Remove.
2119         * gdbthread.h: Likewise.
2120         * guile/scm-type.c: Likewise.
2121         * inline-frame.c: Likewise.
2122         * machoread.c: Likewise.
2123         * memattr.c: Likewise.
2124         * memrange.h: Likewise.
2125         * namespace.h: Likewise.
2126         * nat/linux-btrace.h: Likewise.
2127         * osdata.c: Likewise.
2128         * parser-defs.h: Likewise.
2129         * progspace.h: Likewise.
2130         * python/py-type.c: Likewise.
2131         * record-btrace.c: Likewise.
2132         * rust-exp.y: Likewise.
2133         * solib-target.c: Likewise.
2134         * stap-probe.c: Likewise.
2135         * target-descriptions.c: Likewise.
2136         * target-memory.c: Likewise.
2137         * target.h: Likewise.
2138         * varobj.c: Likewise.
2139         * varobj.h: Likewise.
2140         * xml-support.h: Likewise.
2141
2142 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2143
2144         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2145         Update for new std::vector based implementation.
2146         (process_psymtab_comp_unit_reader): Likewise.
2147         (scan_partial_symbols): Likewise.
2148         (recursively_compute_inclusions): Likewise.
2149         (compute_compunit_symtab_includes): Likewise.
2150         (process_imported_unit_die): Likewise.
2151         (queue_and_load_dwo_tu): Likewise.
2152         (follow_die_sig_1): Likewise.
2153         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2154         (typedef dwarf2_per_cu_ptr): Remove.
2155         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2156         function.
2157         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2158         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2159         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2160         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2161         std::vector.
2162
2163 2019-10-15  Tom Tromey  <tromey@adacore.com>
2164
2165         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2166         TID.
2167
2168 2019-10-15  Tom Tromey  <tromey@adacore.com>
2169
2170         * windows-nat.c (windows_nat_target::fetch_registers)
2171         (windows_nat_target::store_registers): Rename "pid" to "tid".
2172
2173 2019-10-15  Tom Tromey  <tromey@adacore.com>
2174
2175         * gdbarch.h, gdbarch.c: Rebuild.
2176         * gdbarch.sh (gcc_target_options): Change return type to
2177         std::string.
2178         * compile/compile.c (get_args): Update.
2179         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2180         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2181         std::string.
2182         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2183         std::string.
2184         * arch-utils.c (default_gcc_target_options): Return std::string.
2185         * arch-utils.h (default_gcc_target_options): Return std::string.
2186         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2187
2188 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2189
2190         * breakpoint.c (breakpoint_chain): Make static.
2191         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2192         of accessing breakpoint_chain.
2193
2194 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2195
2196         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2197         to a gdb::function_view and return value to bool.
2198         * breakpoint.h (iterate_over_breakpoints): Likewise.
2199         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2200         (pop_dummy_frame): Update.
2201         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2202         (gdbscm_breakpoints): Update.
2203         * python/py-breakpoint.c (build_bp_list): Update.
2204         (gdbpy_breakpoints): Update.
2205         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2206         Update.
2207         (bpfinishpy_handle_stop): Update.
2208         (bpfinishpy_handle_exit): Update.
2209         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2210         (svr4_update_solib_event_breakpoints): Update.
2211
2212 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2213
2214         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2215         when unwrapping single-field structs.
2216
2217 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2218
2219         * dwarf2read.c: Remove includes.
2220
2221 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2222
2223         * ui-out.c (ui_out::call_do_message): Silence
2224         -Wformat-nonliteral warning.
2225
2226 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2227
2228         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2229         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2230         include: readline/tilde.h.
2231
2232 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2233
2234         * remote.c (remote_target::get_trace_status): Remove declaration of
2235         trace_regblock_size.
2236
2237 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2238
2239         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2240         (show_user): Remove declaration of cmdlist.
2241         * cli/cli-cmds.h (max_user_call_depth): Declare.
2242         * cli/cli-script.c (execute_user_command): Remove declaration
2243         of max_user_call_depth.
2244
2245 2019-10-11  Jim Wilson  <jimw@sifive.com>
2246
2247         * gdbsupport/print-utils.h (pulongest): Fix comment.
2248         (plongest): Likewise.
2249         (phex): Add missing comment, mention leading zeros.
2250         (phex_nz): Add mention of no leading zeros to comment.
2251
2252         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2253         plongest instead of unsigned long long cast.
2254
2255 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2258         for external_editor_command and gdbtk_test.
2259
2260 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2261
2262         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2263         * varobj.c (varobjdebug): Move comment to...
2264         * varobj.h (varobjdebug): ...here, and declare.
2265
2266 2019-10-09  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2269         erase_data_content.
2270
2271 2019-10-09  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2274         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2275         * tui/tui-command.c (tui_cmd_window::resize)
2276         (tui_refresh_cmd_win): Update.
2277         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2278         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2279         * tui/tui-data.c (~tui_gen_win_info): Remove.
2280         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2281         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2282         (tui_redisplay_readline, tui_mld_flush)
2283         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2284         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2285         (tui_data_window::erase_data_content)
2286         (tui_data_item_window::rerender)
2287         (tui_data_item_window::refresh_window): Update.
2288         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2289         (box_win, tui_gen_win_info::make_window)
2290         (tui_gen_win_info::make_visible): Update.
2291         (tui_delete_win): Remove.
2292         * tui/tui-winsource.c
2293         (tui_source_window_base::do_erase_source_content): Update.
2294         (tui_show_source_line, tui_source_window_base::update_tab_width)
2295         (tui_source_window_base::update_exec_info): Update.
2296         * tui/tui-data.h (struct curses_deleter): New.
2297         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2298         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2299
2300 2019-10-09  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2303
2304 2019-10-09  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2307         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2308
2309 2019-10-09  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2312         window height directly.
2313         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2314         declare.
2315         * tui/tui-layout.c (tui_default_win_height): Remove.
2316         (tui_default_win_viewport_height): Remove.
2317
2318 2019-10-09  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui.h: Remove comments.
2321
2322 2019-10-09  Tom de Vries  <tdevries@suse.de>
2323
2324         * python/lib/gdb/printer/bound_registers.py: Use
2325         '^builtin_type_bound128' as regexp argument for
2326         add_builtin_pretty_printer.
2327
2328 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2329
2330         * guile/guile.c (guile_extension_script_ops): Remove forward
2331         declaration and mark as static.
2332         (guile_script_ops): Likewise.
2333         (extension_language_guile): Move further down in the file so
2334         it can reference the definitions for guile_{extension_,}script_ops.
2335
2336 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2337
2338         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2339         except SORTL, DFLTCC, and KDSA.
2340
2341 2019-10-08  Tom Tromey  <tromey@adacore.com>
2342
2343         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2344         (struct safe_symbol_file_add_args): Remove.
2345
2346 2019-10-08  Tom Tromey  <tromey@adacore.com>
2347
2348         * windows-nat.c: Don't include buildsym-legacy.h.
2349
2350 2019-10-08  Tom Tromey  <tromey@adacore.com>
2351
2352         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2353
2354 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2355
2356         * gdbtypes.c (overload_debug): Move comment to header.
2357         * gdbtypes.h (overload_debug): Declare.
2358         * valops.c: Remove declaration of overload_debug, instead
2359         include gdbtypes.h.
2360
2361 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2364         through _().
2365         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2366         move comment...
2367         * language.h (lang_frame_mismatch_warn): ... here. Also add
2368         declaration.
2369         * top.c (lang_frame_mismatch_warn): Remove declaration.
2370         (check_frame_language_change): Pass lang_frame_mismatch_warn
2371         through _().
2372
2373 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2374
2375         * c-lang.h (vtbl_ptr_name): Declare.
2376         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2377         it from the header.
2378         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2379
2380 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2381
2382         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2383         gdb_static_assert.
2384
2385 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2386
2387         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2388         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2389         * ctfread.c: New file.
2390         * ctfread.h: New file.
2391         * elfread.c: Include ctfread.h.
2392         (struct elfinfo text_p): New member ctfsect.
2393         (elf_locate_sections): Mark CTF section.
2394         (elf_symfile_read): Call elfctf_build_psymtabs.
2395         * Makefile.in (LIBCTF): Add.
2396         (CLIBS): Use it.
2397         (CDEPS): Likewise.
2398         (DIST): Add ctfread.c.
2399
2400 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * ctfread.c (struct nextfield): Renamed to ...
2403         (struct ctf_nextfield): ... this.
2404         (struct field_info): Renamed to ...
2405         (strut ctf_field_info): ... this.
2406         (attach_fields_to_type): Update for renamed structures.
2407         (ctf_add_member_cb): Likewise.
2408         (ctf_add_enum_member_cb): Likewise.
2409         (process_struct_members): Likewise.
2410         (process_enum_type): Likewise.
2411
2412 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2413
2414         * tracectf.h: Rename, was ctf.h.
2415         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2416         * tracefile.c: Likewise.
2417         * tracepoint.c: Remove unused include ctf.h.
2418         * mi/mi-main.c: Likewise.
2419         * Makefile.in Replace ctf.c with tracectf.c.
2420
2421 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2422
2423         * version.in: Change version number to "9.0.50.DATE-git".
2424
2425 2019-10-03  Tom Tromey  <tom@tromey.com>
2426
2427         PR rust/24976:
2428         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2429
2430 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2433         cp_search_name_hash.
2434         * NEWS: Add entry about nested function support.
2435
2436 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2437             Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2440         for nested static variables when searchin VAR_DOMAIN.
2441         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2442         global scope, update comment.
2443         (add_partial_subprogram): Call add_partial_subprogram recursively
2444         for nested subroutines when processinng Fortran.
2445         (load_partial_dies): Process the child entities of a subprogram
2446         when processing Fortran.
2447         (partial_die_parent_scope): Handle building scope
2448         for Fortran nested functions.
2449         (process_die): Record that nested functions have a scope.
2450         (new_symbol): Always record Fortran subprograms on the global
2451         symbol list.
2452         (determine_prefix): How to build the prefix for Fortran
2453         subprograms.
2454
2455 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2458         have just sent the thread a SIGSTOP and are waiting for it to
2459         arrive.
2460
2461 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * btrace.c (btrace_add_pc): Remove whitespace before the template
2464         parameter in 'std::vector <...>'.
2465         (parse_xml_btrace_block): Likewise.
2466         (btrace_maint_decode_pt): Likewise.
2467         (btrace_maint_update_packets): Likewise.
2468         (btrace_maint_print_packets): Likewise.
2469         * btrace.h (struct btrace_maint_info): Likewise.
2470         * dwarf2read.c (struct type_unit_group): Likewise.
2471         (build_type_psymtabs_reader): Likewise.
2472         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2473         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2474         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2475
2476 2019-10-03  Tom de Vries  <tdevries@suse.de>
2477
2478         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2479         the first line of the help text for set/show style metadata.
2480
2481 2019-10-02  Tom Tromey  <tromey@adacore.com>
2482
2483         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2484         * gdbsupport/common-inferior.c: New file.
2485         * infcmd.c (startup_with_shell): Don't define.
2486         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2487         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2488         * inferior.h (startup_with_shell): Don't declare.
2489
2490 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2491
2492         * gdbsupport/gdb_assert.h: Include errors.h.
2493         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2494
2495 2019-10-02  Tom Tromey  <tromey@adacore.com>
2496
2497         * NEWS: Add $_ada_exception entry.
2498         * ada-lang.c (struct ada_catchpoint): Add constructor.
2499         <m_kind>: New member.
2500         (allocate_location_exception, re_set_exception): Remove
2501         "ex" parameter.
2502         (should_stop_exception): Compute $_ada_exception.
2503         (check_status_exception, print_it_exception)
2504         (print_one_exception, print_mention_exception): Remove
2505         "ex" parameter.
2506         (allocate_location_catch_exception, re_set_catch_exception)
2507         (check_status_exception, print_it_catch_exception)
2508         (print_one_catch_exception, print_mention_catch_exception)
2509         (print_recreate_catch_exception)
2510         (allocate_location_catch_exception_unhandled)
2511         (re_set_catch_exception_unhandled)
2512         (check_status_exception, print_it_catch_exception_unhandled)
2513         (print_one_catch_exception_unhandled)
2514         (print_mention_catch_exception_unhandled)
2515         (print_recreate_catch_exception_unhandled)
2516         (allocate_location_catch_assert, re_set_catch_assert)
2517         (check_status_assert, print_it_catch_assert)
2518         (print_one_catch_assert, print_mention_catch_assert)
2519         (print_recreate_catch_assert)
2520         (allocate_location_catch_handlers, re_set_catch_handlers)
2521         (check_status_handlers, print_it_catch_handlers)
2522         (print_one_catch_handlers, print_mention_catch_handlers)
2523         (print_recreate_catch_handlers): Remove.
2524         (create_ada_exception_catchpoint): Update.
2525         (initialize_ada_catchpoint_ops): Update.
2526
2527 2019-10-02  Tom Tromey  <tromey@adacore.com>
2528
2529         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2530         (create_excep_cond_exprs): Simplify exception string computation.
2531         (ada_exception_catchpoint_cond_string): Likewise.
2532
2533 2019-10-02  Tom Tromey  <tromey@adacore.com>
2534
2535         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2536         * ada-lang.c (lesseq_defined_than): Handle
2537         LOC_STATIC.
2538         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2539         parameter.
2540         (dwarf2_has_info): Likewise.
2541         (new_symbol): Set maybe_copied on symbol when
2542         appropriate.
2543         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2544         parameter.
2545         <can_copy>: New member.
2546         * elfread.c (record_minimal_symbol): Set maybe_copied
2547         on symbol when appropriate.
2548         (elf_symfile_read): Update call to dwarf2_has_info.
2549         * minsyms.c (lookup_minimal_symbol_linkage): New
2550         function.
2551         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2552         * symtab.c (get_symbol_address, get_msymbol_address):
2553         New functions.
2554         * symtab.h (get_symbol_address, get_msymbol_address):
2555         Declare.
2556         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2557         maybe_copied.
2558         (struct symbol, struct minimal_symbol) <maybe_copied>:
2559         New member.
2560
2561 2019-10-02  Tom Tromey  <tromey@adacore.com>
2562
2563         * source.c (struct current_source_location): New.
2564         (current_source_key): New global.
2565         (current_source_symtab, current_source_line)
2566         (current_source_pspace): Remove.
2567         (get_source_location): New function.
2568         (get_current_source_symtab_and_line)
2569         (set_default_source_symtab_and_line)
2570         (set_current_source_symtab_and_line)
2571         (clear_current_source_symtab_and_line, select_source_symtab)
2572         (info_source_command, print_source_lines_base)
2573         (info_line_command, search_command_helper, _initialize_source):
2574         Update.
2575
2576 2019-10-02  Tom Tromey  <tromey@adacore.com>
2577
2578         * source.c (select_source_symtab): Don't call
2579         decode_line_with_current_source.
2580
2581 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * symtab.c (lookup_global_symbol): Search global block.
2584
2585 2019-10-02  Tom Tromey  <tromey@adacore.com>
2586
2587         * coffread.c (process_coff_symbol): Update.
2588         * dwarf2read.c (var_decode_location, new_symbol): Update.
2589         * mdebugread.c (parse_symbol): Update.
2590         * objfiles.c (relocate_one_symbol): Update.
2591         * stabsread.c (define_symbol, fix_common_block)
2592         (scan_file_globals): Update.
2593         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2594         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2595         * xcoffread.c (process_xcoff_symbol): Update.
2596
2597 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2598
2599         * MAINTAINERS: Update my email address.
2600
2601 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2604         std::vector.
2605         (build_type_psymtabs_reader): Update for std::vector.
2606         (build_type_psymtab_dependencies): Likewise.
2607         * dwarf2read.h: Remove use of DEF_VEC_P.
2608         (typedef sig_type_ptr): Delete.
2609
2610 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2613         to std::vector.
2614         (btrace_maint_decode_pt): Likewise, and move allocation of the
2615         vector outside of the loop.
2616         (btrace_maint_update_packets): Update to handle change from VEC to
2617         std::vector.
2618         (btrace_maint_print_packets): Likewise.
2619         (maint_info_btrace_cmd): Likewise.
2620         * btrace.h: Remove use of DEF_VEC_O.
2621         (typedef btrace_pt_packet_s): Delete.
2622         (struct btrace_maint_info) <packets>: Change fromm VEC to
2623         std::vector.
2624         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2625
2626 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2629         make accesses into the vector constant references.
2630         (btrace_add_pc): Update for std::vector.
2631         (btrace_stitch_bts): Likewise.
2632         (parse_xml_btrace_block): Likewise.
2633         (btrace_maint_update_packets): Likewise.
2634         (btrace_maint_print_packets): Likewise.
2635         (maint_info_btrace_cmd): Likewise.
2636         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2637         std::vector.
2638         (btrace_data::empty): Likewise.
2639         (btrace_data_append): Likewise.
2640         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2641         (typedef btrace_block_s): Delete.
2642         (struct btrace_block): Add constructor.
2643         (struct btrace_data_bts) <blocks>: Change to std::vector.
2644         * nat/linux-btrace.c (perf_event_read_bts): Update for
2645         std::vector.
2646         (linux_read_bts): Likewise.
2647
2648 2019-10-01  Tom Tromey  <tom@tromey.com>
2649
2650         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2651
2652 2019-10-01  Tom Tromey  <tom@tromey.com>
2653
2654         * stack.c (print_frame, info_frame_command_core): Use
2655         styled_string.
2656         * linux-thread-db.c (try_thread_db_load_1)
2657         (try_thread_db_load_from_pdir_1): Use styled_string.
2658         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2659         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2660         (maybe_print_unsupported_script_warning)
2661         (maybe_print_script_not_found_warning): Use styled_string.
2662         * ada-lang.c (user_select_syms): Use styled_string.
2663
2664 2019-10-01  Tom Tromey  <tom@tromey.com>
2665
2666         * p-lang.c (pascal_printstr): Use metadata style.
2667         * value.c (show_convenience): Use metadata style.
2668         * valprint.c (valprint_check_validity, val_print_optimized_out)
2669         (val_print_not_saved, val_print_unavailable)
2670         (val_print_invalid_address, generic_val_print, val_print)
2671         (value_check_printable, val_print_array_elements): Use metadata
2672         style.
2673         * ui-out.h (class ui_out) <field_fmt>: New overload.
2674         <do_field_fmt>: Add style parameter.
2675         * ui-out.c (ui_out::field_fmt): New overload.
2676         * typeprint.c (type_print_unknown_return_type)
2677         (val_print_not_allocated, val_print_not_associated): Use metadata
2678         style.
2679         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2680         parameter.
2681         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2682         * tracepoint.c (tvariables_info_1): Use metadata style.
2683         * stack.c (print_frame_arg, print_frame_info, print_frame)
2684         (info_frame_command_core): Use metadata style.
2685         * skip.c (info_skip_command): Use metadata style.
2686         * rust-lang.c (rust_print_enum): Use metadata style.
2687         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2688         metadata style.
2689         * python/py-framefilter.c (py_print_single_arg): Use metadata
2690         style.
2691         * printcmd.c (do_one_display, print_variable_and_value): Use
2692         metadata style.
2693         * p-valprint.c (pascal_val_print)
2694         (pascal_object_print_value_fields): Use metadata style.
2695         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2696         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2697         parameter.
2698         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2699         * m2-valprint.c (m2_print_long_set): Use metadata style.
2700         * m2-typeprint.c (m2_print_type): Use metadata style.
2701         * infcmd.c (print_return_value_1): Use metadata style.
2702         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2703         * f-valprint.c (info_common_command_for_block): Use metadata
2704         style.
2705         * f-typeprint.c (f_type_print_base): Use metadata style.
2706         * expprint.c (print_subexp_standard): Use metadata style.
2707         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2708         * cli/cli-style.h (class cli_style_option): Add constructor.
2709         (metadata_style): Declare.
2710         * cli/cli-style.c (metadata_style): New global.
2711         (_initialize_cli_style): Register metadata style.
2712         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2713         parameter.
2714         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2715         * c-typeprint.c (c_type_print_base_struct_union)
2716         (c_type_print_base_1): Use metadata style.
2717         * breakpoint.c (watchpoint_value_print)
2718         (print_one_breakpoint_location): Use metadata style.
2719         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2720         style.
2721         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2722         style.
2723         * ada-valprint.c (val_print_packed_array_elements, printstr)
2724         (print_field_values, ada_val_print_ref, ada_val_print): Use
2725         metadata style.
2726         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2727         style.
2728         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2729         style.
2730         * ada-lang.c (user_select_syms): Use metadata style.
2731
2732 2019-10-01  Tom Tromey  <tom@tromey.com>
2733
2734         * cli/cli-cmds.c (pwd_command): Style output.
2735
2736 2019-10-01  Pedro Alves  <palves@redhat.com>
2737             Tom Tromey  <tom@tromey.com>
2738
2739         * symtab.c (print_symbol_info): Use %ps.
2740         (print_msymbol_info): Use %ps.
2741         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2742         * printcmd.c (print_variable_and_value): Use %ps.
2743         * macrocmd.c (show_pp_source_pos): Use %ps.
2744         * infrun.c (print_exited_reason): Use ui_out::message.
2745         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2746         (describe_other_breakpoints): Use ui_out::message and new
2747         formats.
2748         (say_where): Use new formats.
2749         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2750         and new formats.
2751
2752 2019-10-01  Pedro Alves  <palves@redhat.com>
2753             Tom Tromey  <tom@tromey.com>
2754
2755         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2756         (test_gdb_formats): New function.
2757         (run_tests): Call it.
2758         (test_format_specifier): Update.
2759         * utils.h (fputs_filtered): Update comment.
2760         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2761         (fputs_styled_unfiltered): Declare.
2762         * utils.c (fputs_styled_unfiltered): New function.
2763         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2764         (vfprintf_filtered): Update.
2765         (vfprintf_unfiltered, vprintf_filtered): Update.
2766         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2767         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2768         disallow_ui_out_field>: New constants.
2769         (enum class field_kind): New.
2770         (struct base_field_s, struct signed_field_s): New.
2771         (signed_field): New function.
2772         (struct string_field_s): New.
2773         (string_field): New function.
2774         (struct styled_string_s): New.
2775         (styled_string): New function.
2776         (class ui_out) <message>: Add comment.
2777         <vmessage, call_do_message>: New methods.
2778         <do_message>: Add style parameter.
2779         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2780         methods.
2781         (ui_out::message): Rewrite.
2782         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2783         parameter.
2784         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2785         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2786         gdb_extensions parameter.
2787         (class format_piece): Add parameter to constructor.
2788         (n_int_args): New field.
2789         * gdbsupport/format.c (format_pieces::format_pieces): Add
2790         gdb_extensions parameter.  Handle '*'.
2791         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2792         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2793         vfprintf_styled_no_gdbfmt.
2794         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2795         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2796         unfiltered output.
2797         * ui-style.h (struct ui_file_style) <ptr>: New method.
2798
2799 2019-10-01  Tom Tromey  <tom@tromey.com>
2800
2801         * unittests/format_pieces-selftests.c: Update.  Add final format.
2802         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2803         empty literal pieces.
2804
2805 2019-10-01  Tom Tromey  <tom@tromey.com>
2806
2807         * ui-out.h (enum class ui_out_style_kind): Remove.
2808         (class ui_out) <field_string, field_stsream, do_field_string>:
2809         Change type of "style".
2810         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2811         (ui_out::field_string): Update.
2812         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2813         of "style".
2814         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2815         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2816         * stack.c (print_frame_arg, print_frame_info, print_frame):
2817         Update.
2818         * source.c (print_source_lines_base): Update.
2819         * solib.c (info_sharedlibrary_command): Update.
2820         * skip.c (info_skip_command): Update.
2821         * record-btrace.c (btrace_call_history_src_line)
2822         (btrace_call_history): Update.
2823         * python/py-framefilter.c (py_print_frame): Update.
2824         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2825         "style".
2826         * mi/mi-out.c (mi_ui_out::do_table_header)
2827         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2828         (mi_ui_out::do_field_string): Update.
2829         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2830         Update.
2831         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2832         "style".
2833         * cli-out.c (cli_ui_out::do_table_header)
2834         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2835         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2836         (cli_ui_out::do_field_fmt): Update.
2837         * breakpoint.c (print_breakpoint_location): Update.
2838         (update_static_tracepoint): Update.
2839
2840 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2841
2842         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2843         conversion of gdb_datadir.
2844         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2845         remove not needed c_str ().
2846
2847 2019-09-30  Ali Tamur <tamur@google.com>
2848
2849         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2850         (dwarf2_string_attr): Likewise.
2851
2852 2019-09-30  Ali Tamur <tamur@google.com>
2853
2854         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2855         (process_full_type_unit): Likewise.
2856         (dump_die_shallow): Likewise.
2857         (cu_debug_loc_section): Likewise.
2858
2859 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2860
2861         * minsyms.c (compare_minimal_symbols): Rename to...
2862         (minimal_symbol_is_less_than): ...this, and adjust to STL
2863         conventions (return bool, take arguments as references)
2864         (minimal_symbol_reader::install): Call std::sort instead
2865         of qsort.
2866
2867 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2868
2869         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2870         hash and why.
2871         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2872         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2873
2874 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2875
2876         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2877         * psympriv.h (add_psymbol_to_list): Move comment here and update
2878         it.
2879
2880 2019-09-29  Tom de Vries  <tdevries@suse.de>
2881
2882         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2883         Use $tmpdir/$(basename "$output_file").dwz instead of
2884         "${output_file}.dwz".
2885
2886 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2887
2888         PR gdb/25045
2889         * hppa-linux-nat.c: Include gdbarch.h.
2890
2891 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2892
2893         * blockframe.c (find_pc_partial_function): Change return type to bool.
2894         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2895         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2896         (stub_gnu_ifunc_resolve_name): Likewise.
2897         * symtab.c (compare_filenames_for_search): Likewise.
2898         (compare_glob_filenames_for_search): Likewise.
2899         (matching_obj_sections): Likewise.
2900         (symbol_matches_domain): Likewise.
2901         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2902         (find_line_pc): Change return type to bool.
2903         (find_line_pc_range): Likewise.
2904         (producer_is_realview): Likewise.
2905         * symtab.h (symbol_matches_domain): Likewise.
2906         (find_pc_partial_function): Likewise.
2907         (find_pc_line_pc_range): Likewise.
2908         (in_gnu_ifunc_stub): Likewise.
2909         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2910         (find_line_pc): Likewise.
2911         (find_line_pc_range): Likewise.
2912         (matching_obj_sections): Likewise.
2913         (find_line_symtab): Change out parameter to bool.
2914         (producer_is_realview): Change return type to bool.
2915         (compare_filenames_for_search): Likewise.
2916         (compare_glob_filenames_for_search): Likewise.
2917
2918 2019-09-26  Tom Tromey  <tom@tromey.com>
2919
2920         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2921         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2922         * gdb_usleep.h: Remove.
2923         * gdb_usleep.c: Remove.
2924         * utils.c: Don't include gdb_usleep.h.
2925
2926 2019-09-26  Tom Tromey  <tromey@adacore.com>
2927
2928         * python/py-type.c (type_to_type_object): Call check_typedef
2929         for stub types.
2930
2931 2019-09-26  Tom Tromey  <tom@tromey.com>
2932
2933         * utils.h (initialize_utils): Don't declare.
2934         * top.c (gdb_init): Don't call initialize_utils.
2935         * utils.c (initialize_utils): Remove.  Move contents...
2936         (_initialize_utils): ... here.
2937
2938 2019-09-25  Tom Tromey  <tom@tromey.com>
2939
2940         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2941         * utils.h (make_hex_string): Don't declare.
2942         * utils.c (make_hex_string): Remove.
2943
2944 2019-09-24  Tom de Vries  <tdevries@suse.de>
2945
2946         PR gdb/23815
2947         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2948         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2949
2950 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2951
2952         * NEWS: Mention new simulator port for PRU.
2953
2954 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2955
2956         * ada-exp.y (write_object_remaining): Update.
2957         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2958         and eliminate the static buffer.
2959         (ada_decode_symbol): Update.
2960         (ada_la_decode): Update.
2961         (ada_sniff_from_mangled_name): Update.
2962         (is_valid_name_for_wild_match): Update.
2963         (ada_lookup_name_info::matches): Update and simplify.
2964         (name_matches_regex): Update.
2965         (ada_add_global_exceptions): Update.
2966         * ada-lang.h (ada_decode): Update signature.
2967         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2968         * dwarf-index-write.c (debug_names::insert): Update.
2969
2970 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2971
2972         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2973         formatting.
2974
2975 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2976
2977         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2978         Change "nonzero" to "true" in documentation.
2979
2980 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2981
2982         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2983         (_initialize_darwin_solib): Don't set
2984         darwin_so_ops.lookup_lib_global_symbol.
2985         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2986         set_gdbarch_iterate_over_objfiles_in_search_order.
2987         (elf_lookup_lib_symbol): Rename to...
2988         (svr4_iterate_over_objfiles_in_search_order): this, and update
2989         to iterate semantics.
2990         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2991         * solib.c (solib_global_lookup): Remove.
2992         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2993         (solib_global_lookup): Remove.
2994         * symtab.c (lookup_global_or_static_symbol): Remove call to
2995         solib_global_lookup.
2996
2997 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2998
2999         * NEWS: Move entries about default MI version now being
3000         version 3, and about the GDB/MI fix for multi-location
3001         breakpoints to the "since GDB 8.3" section.
3002
3003 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3004
3005         GDB 8.3.1 released.
3006
3007 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3008
3009         * NEWS: Mention that Cell/B.E. debugging support was removed.
3010         * MAINTAINERS: Remove spu target.
3011
3012         * config/djgpp/fnchange.lst: Remove entries for removed files.
3013
3014         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3015         spu-multiarch.o, and spu-tdep.o.
3016         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3017         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3018         spu-multiarch.c, and spu-tdep.c.
3019         * spu-linux-nat.c: Remove file.
3020         * spu-multiarch.c: Remove file.
3021         * spu-tdep.c: Remove file.
3022         * spu-tdep.h: Remove file.
3023         * solib-spu.c: Remove file.
3024         * solib-spu.h: Remove file.
3025
3026         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3027         * configure.nat (spu-linux): Remove.
3028         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3029         solib-multiarch.o from gdb_target_obs.
3030         (spu*-*-*): Remove.
3031
3032         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3033         feature flag.
3034         (ppc_linux_no_features): Update.
3035         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3036         Cell/B.E. support.
3037         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3038         (tdesc_powerpc_cell64l): Likewise.
3039         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3040         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3041         Cell/B.E. support.
3042         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3043         Do not include "features/rs6000/powerpc-cell32l.c" or
3044         "features/rs6000/powerpc-cell64l.c".
3045         (ppc_linux_spu_section): Remove.
3046         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3047         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3048         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3049         (ppc_linux_spe_context_lookup): Remove.
3050         (ppc_linux_spe_context_inferior_created): Remove.
3051         (ppc_linux_spe_context_solib_loaded): Remove.
3052         (ppc_linux_spe_context_solib_unloaded): Remove.
3053         (ppc_linux_spe_context): Remove.
3054         (struct ppu2spu_cache): Remove.
3055         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3056         (struct ppu2spu_data): Remove.
3057         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3058         ppu2spu_unwind): Remove.
3059         (ppc_linux_init_abi): Remove Cell/B.E. support.
3060         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3061
3062         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3063         (rs6000/powerpc-cell64l-expedite): Likewise
3064         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3065         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3066         rs6000/powerpc-cell64l.xml.
3067         * features/rs6000/powerpc-cell32l.xml: Remove.
3068         * features/rs6000/powerpc-cell64l.xml: Likewise.
3069         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3070         * features/rs6000/powerpc-cell64l.c: Likewise.
3071         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3072         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3073         * regformats/reg-spu.dat: Remove.
3074
3075         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3076         * corelow.c (struct spuid_list): Remove.
3077         (add_to_spuid_list): Remove.
3078         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3079         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3080         (remote_protocol_features): Remove associated entries.
3081         (_initialize_remote): No longer initialize them.
3082         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3083         * linux-nat.c (SPUFS_MAGIC): Remove.
3084         (linux_proc_xfer_spu): Remove.
3085         (spu_enumerate_spu_ids): Remove.
3086         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3087         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3088         (linux_make_corefile_notes): No longer call it.
3089
3090         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3091         (cooked_write_test): Likewise.
3092
3093 2019-09-20  Tom Tromey  <tom@tromey.com>
3094
3095         * NEWS: Mention case-sensitivity of TUI commands.
3096         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3097         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3098         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3099
3100 2019-09-20  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-source.c (tui_source_window::set_contents): Use
3103         make_unique_xstrdup.
3104         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3105         make_unique_xstrdup.
3106
3107 2019-09-20  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-data.c: Remove separator comments.
3110         * tui/tui-layout.c: Remove separator comments.
3111         * tui/tui-win.c: Remove separator comments.
3112         * tui/tui-wingeneral.c: Remove separator comments.
3113
3114 2019-09-20  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui.h (strcat_to_buf): Don't declare.
3117         * tui/tui.c (strcat_to_buf): Remove.
3118
3119 2019-09-20  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3122         from "fullname".
3123         * tui/tui-source.c (tui_source_window::set_contents)
3124         (tui_source_window::location_matches_p)
3125         (tui_source_window::maybe_update): Update.
3126
3127 2019-09-20  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3130         Update.
3131         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3132         prefix.
3133         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3134         (tui_data_window::line_from_reg_element_no)
3135         (tui_data_window::first_reg_element_no_inline)
3136         (tui_data_window::show_registers)
3137         (tui_data_window::show_register_group)
3138         (tui_data_window::display_registers_from)
3139         (tui_data_window::display_registers_from_line)
3140         (tui_data_window::first_data_item_displayed)
3141         (tui_data_window::delete_data_content_windows)
3142         (tui_data_window::erase_data_content)
3143         (tui_data_window::do_scroll_vertical)
3144         (tui_data_window::refresh_window)
3145         (tui_data_window::check_register_values): Update.
3146
3147 2019-09-20  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3150         (struct tui_locator_window) <full_name, proc_name>: Now
3151         std::string.
3152         * tui/tui-stack.c (tui_locator_window::make_status_line)
3153         (tui_locator_window::set_locator_fullname)
3154         (tui_locator_window::set_locator_info): Update.
3155         * tui/tui-source.c (tui_source_window::set_contents)
3156         (tui_source_window::showing_source_p): Update.
3157
3158 2019-09-20  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3161         Don't call tui_locator_win_info_ptr.
3162
3163 2019-09-20  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3166
3167 2019-09-20  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3170         height for locator.
3171         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3172         * tui/tui-layout.c (show_source_disasm_command, show_data)
3173         (show_source_or_disasm_and_command): Use 1 as height for locator.
3174
3175 2019-09-20  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui.c (tui_enable): Update.
3178         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3179         Update.
3180         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3181         Update.
3182         * tui/tui-data.c (win_resized): Now bool.
3183         (tui_win_resized): Return bool.
3184         (tui_set_win_resized_to): Accept a bool.
3185
3186 2019-09-20  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3189         Change type of "refresh_values_only".
3190         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3191         type of "refresh_values_only".
3192
3193 2019-09-20  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3196         std::string.
3197         (tui_disassemble): Add "pos" parameter.
3198         (tui_disasm_window::set_contents): Simplify.
3199
3200 2019-09-20  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.h (struct tui_source_window_base)
3203         <show_source_content>: Now private.
3204         * tui/tui-winsource.c
3205         (tui_source_window_base::show_source_content): Don't handle empty
3206         content case.
3207
3208 2019-09-20  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-layout.c (show_source_disasm_command)
3211         (show_source_or_disasm_and_command): Don't call
3212         show_source_content.
3213
3214 2019-09-20  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3217         Declare.
3218         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3219         from tui_make_status_line.
3220         (tui_locator_window::rerender): Update.
3221
3222 2019-09-20  Tom Tromey  <tom@tromey.com>
3223
3224         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3225         (tui_locator_window::rerender): Update.
3226
3227 2019-09-20  Tom Tromey  <tom@tromey.com>
3228
3229         * tui/tui-winsource.h (struct tui_source_window_base)
3230         <~tui_source_window_base>: Don't declare.
3231         <fullname>: Remove.
3232         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3233         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3234         member.
3235         * tui/tui-source.c (tui_source_window::set_contents): Update.
3236         (tui_source_window::location_matches_p)
3237         (tui_source_window::maybe_update): Update.
3238
3239 2019-09-20  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-winsource.h (~tui_source_element): Remove.
3242         (tui_source_element): Update.
3243         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3244         * tui/tui-winsource.c (tui_show_source_line): Update.
3245         * tui/tui-source.c (tui_source_window::set_contents): Update.
3246         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3247
3248 2019-09-20  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3251         declare.
3252         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3253         tui_clear_source_windows_detail.
3254         * tui/tui-winsource.h (struct tui_source_window_base)
3255         <clear_detail>: Don't declare.
3256         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3257         Remove.
3258         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3259
3260 2019-09-20  Tom Tromey  <tromey@adacore.com>
3261
3262         PR ada/24919:
3263         * block.c (contained_in): Fix final return value.
3264
3265 2019-09-20  Alan Modra  <amodra@gmail.com>
3266
3267         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3268         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3269         (read_indirect_string_from_dwz): Use bfd accessor.
3270         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3271         * machoread.c (macho_symfile_read_all_oso): Likewise.
3272         * solib.c (solib_bfd_open): Likewise.
3273
3274 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3275
3276         * eval.c: Move declaration of overload_resolution to...
3277         * value.h: ...here.
3278
3279 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3280
3281         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3282         * arm-linux-tdep.c: Likewise.
3283         * arm-nbsd-nat.c: Likewise.
3284         * arm-tdep.h: Declare arm_apcs_32.
3285         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3286
3287 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3288
3289         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3290         * dwarf2read.h: Declare dwarf_always_disassemble.
3291
3292 2019-09-19  Tom de Vries  <tdevries@suse.de>
3293
3294         PR gdb/25009
3295         * source-cache.c (source_cache::ensure): Catch exception thrown during
3296         construction of the highlighter.
3297
3298 2019-09-18  Alan Modra  <amodra@gmail.com>
3299
3300         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3301         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3302         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3303         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3304         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3305         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3306         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3307         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3308         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3309         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3310         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3311         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3312         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3313         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3314         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3315         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3316         * mi/mi-interp.c: Update throughout for bfd section macro and
3317         function changes.
3318         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3319         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3320
3321 2019-09-18  Tom Tromey  <tom@tromey.com>
3322
3323         * NEWS: Add entry.
3324         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3325         call rl_initialize.
3326         (tui_enable): Do not call rl_initialize.
3327
3328 2019-09-18  Christian Groessler  <chris@groessler.org>
3329
3330         * alpha-linux-nat.c: Include gdbarch.h.
3331
3332 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3333
3334         * ui-file.c: Include cli/cli-style.h.
3335         (term_cli_styling): Remove cli_styling declaration.
3336
3337 2019-09-18  Alan Modra  <amodra@gmail.com>
3338
3339         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3340         to bfd_asymbol_section.
3341
3342 2019-09-18  Alan Modra  <amodra@gmail.com>
3343
3344         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3345         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3346         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3347
3348 2019-09-18  Alan Modra  <amodra@gmail.com>
3349
3350         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3351         * spu-linux-nat.c (spu_bfd_open): Likewise.
3352
3353 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3354
3355         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3356         to bool to match definition in dwarf2read.c.
3357
3358 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3359
3360         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3361         (print_signatures): Likewise.
3362         (trust_pad_over_xvs): Likewise.
3363         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3364         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3365         * arm-linux-nat.c (arm_apcs_32): Likewise.
3366         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3367         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3368         * arm-tdep.c (arm_debug): Likewise.
3369         (arm_apcs_32): Likewise.
3370         * auto-load.c (debug_auto_load): Likewise.
3371         (auto_load_gdb_scripts): Likewise.
3372         (global_auto_load): Likewise.
3373         (auto_load_local_gdbinit): Likewise.
3374         (auto_load_local_gdbinit_loaded): Likewise.
3375         * auto-load.h (global_auto_load): Likewise.
3376         (auto_load_local_gdbinit): Likewise.
3377         (auto_load_local_gdbinit_loaded): Likewise.
3378         * breakpoint.c (disconnected_dprintf): Likewise.
3379         (breakpoint_proceeded): Likewise.
3380         (automatic_hardware_breakpoints): Likewise.
3381         (always_inserted_mode): Likewise.
3382         (target_exact_watchpoints): Likewise.
3383         (_initialize_breakpoint): Update.
3384         * breakpoint.h (target_exact_watchpoints): Change to bool.
3385         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3386         * cli/cli-cmds.c (trace_commands): Likewise.
3387         * cli/cli-cmds.h (trace_commands): Likewise.
3388         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3389         to bool*.
3390         * cli/cli-logging.c (logging_overwrite): Change to bool.
3391         (logging_redirect): Likewise.
3392         (debug_redirect): Likewise.
3393         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3394         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3395         to bool.
3396         <boolean_option_def>: Update.
3397         (struct flag_option_def): Change default type of Context to bool
3398         from int.
3399         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3400         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3401         (get_setshow_command_value_string): Likewise.
3402         * cli/cli-style.c (cli_styling): Change to bool.
3403         (source_styling): Likewise.
3404         * cli/cli-style.h (source_styling): Likewise.
3405         (cli_styling): Likewise.
3406         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3407         to bool.
3408         * command.h (var_types): Update comment.
3409         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3410         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3411         bool.
3412         (debug_compile_cplus_scopes): Likewise.
3413         * compile/compile-internal.h (compile_debug): Likewise.
3414         * compile/compile.c (compile_debug): Likewise.
3415         (struct compile_options) <raw>: Likewise.
3416         * cp-support.c (catch_demangler_crashes): Likewise.
3417         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3418         (usr_cmd_cris_dwarf2_cfi): Likewise.
3419         * csky-tdep.c (csky_debug): Likewise.
3420         * darwin-nat.c (enable_mach_exceptions): Likewise.
3421         * dcache.c (dcache_enabled_p): Likewise.
3422         * defs.h (info_verbose): Likewise.
3423         * demangle.c (demangle): Likewise.
3424         (asm_demangle): Likewise.
3425         * dwarf-index-cache.c (debug_index_cache): Likewise.
3426         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3427         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3428         * dwarf2read.c (check_physname): Likewise.
3429         (use_deprecated_index_sections): Likewise.
3430         (dwarf_always_disassemble): Likewise.
3431         * eval.c (overload_resolution): Likewise.
3432         * event-top.c (set_editing_cmd_var): Likewise.
3433         (exec_done_display_p): Likewise.
3434         * event-top.h (set_editing_cmd_var): Likewise.
3435         (exec_done_display_p): Likewise.
3436         * exec.c (write_files): Likewise.
3437         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3438         (debug_fbsd_nat): Likewise.
3439         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3440         Likewise.
3441         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3442         <backtrace_past_entry> Likewise.
3443         * gdb-demangle.h (demangle): Likewise.
3444         (asm_demangle): Likewise.
3445         * gdb_bfd.c (bfd_sharing): Likewise.
3446         * gdbcore.h (write_files): Likewise.
3447         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3448         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3449         * gdbthread.h (print_thread_events): Likewise.
3450         * gdbtypes.c (opaque_type_resolution): Likewise.
3451         (strict_type_checking): Likewise.
3452         * gnu-nat.c (gnu_debug_flag): Likewise.
3453         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3454         * guile/scm-param.c (pascm_variable): Add boolval.
3455         (add_setshow_generic): Update.
3456         (pascm_param_value): Update.
3457         (pascm_set_param_value_x): Update.
3458         * hppa-tdep.c (hppa_debug): Change to bool..
3459         * infcall.c (may_call_functions_p): Likewise.
3460         (coerce_float_to_double_p): Likewise.
3461         (unwind_on_signal_p): Likewise.
3462         (unwind_on_terminating_exception_p): Likewise.
3463         * infcmd.c (startup_with_shell): Likewise.
3464         * inferior.c (print_inferior_events): Likewise.
3465         * inferior.h (startup_with_shell): Likewise.
3466         (print_inferior_events): Likewise.
3467         * infrun.c (step_stop_if_no_debug): Likewise.
3468         (detach_fork): Likewise.
3469         (debug_displaced): Likewise.
3470         (disable_randomization): Likewise.
3471         (non_stop): Likewise.
3472         (non_stop_1): Likewise.
3473         (observer_mode): Likewise.
3474         (observer_mode_1): Likewise.
3475         (set_observer_mode): Update.
3476         (sched_multi): Change to bool.
3477         * infrun.h (debug_displaced): Likewise.
3478         (sched_multi): Likewise.
3479         (step_stop_if_no_debug): Likewise.
3480         (non_stop): Likewise.
3481         (disable_randomization): Likewise.
3482         * linux-tdep.c (use_coredump_filter): Likewise.
3483         (dump_excluded_mappings): Likewise.
3484         * linux-thread-db.c (auto_load_thread_db): Likewise.
3485         (check_thread_db_on_load): Likewise.
3486         * main.c (captured_main_1): Update.
3487         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3488         xx2_opt, boolean_opt>: Change to bool.
3489         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3490         * maint.c (maintenance_profile_p): Likewise.
3491         (per_command_time): Likewise.
3492         (per_command_space): Likewise.
3493         (per_command_symtab): Likewise.
3494         * memattr.c (inaccessible_by_default): Likewise.
3495         * mi/mi-main.c (mi_async): Likewise.
3496         (mi_async_1): Likewise.
3497         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3498         * nat/fork-inferior.h (startup_with_shell): Likewise.
3499         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3500         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3501         * nios2-tdep.c (nios2_debug): Likewise.
3502         * or1k-tdep.c (or1k_debug): Likewise.
3503         * parse.c (parser_debug): Likewise.
3504         * parser-defs.h (parser_debug): Likewise.
3505         * printcmd.c (print_symbol_filename): Likewise.
3506         * proc-api.c (procfs_trace): Likewise.
3507         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3508         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3509         (set_parameter_value): Update.
3510         (add_setshow_generic): Update.
3511         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3512         to bool*.
3513         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3514         int*.
3515         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3516         * record-btrace.c (record_btrace_target::store_registers): Update.
3517         * record-full.c (record_full_memory_query): Change to bool.
3518         (record_full_stop_at_limit): Likewise.
3519         * record-full.h (record_full_memory_query): Likewise.
3520         * remote-notif.c (notif_debug): Likewise.
3521         * remote-notif.h (notif_debug): Likewise.
3522         * remote.c (use_range_stepping): Likewise.
3523         (interrupt_on_connect): Likewise.
3524         (remote_break): Likewise.
3525         * ser-tcp.c (tcp_auto_retry): Likewise.
3526         * ser-unix.c (serial_hwflow): Likewise.
3527         * skip.c (debug_skip): Likewise.
3528         * solib-aix.c (solib_aix_debug): Likewise.
3529         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3530         (spu_auto_flush_cache_p): Likewise.
3531         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3532         Likewise.
3533         (struct info_print_options) <quiet>: Likewise.
3534         * symfile-debug.c (debug_symfile): Likewise.
3535         * symfile.c (auto_solib_add): Likewise.
3536         (separate_debug_file_debug): Likewise.
3537         * symfile.h (auto_solib_add): Likewise.
3538         (separate_debug_file_debug): Likewise.
3539         * symtab.c (basenames_may_differ): Likewise.
3540         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3541         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3542         (struct info_types_options) <quiet>: Likewise.
3543         * symtab.h (demangle): Likewise.
3544         (basenames_may_differ): Likewise.
3545         * target-dcache.c (stack_cache_enabled_1): Likewise.
3546         (code_cache_enabled_1): Likewise.
3547         * target.c (trust_readonly): Likewise.
3548         (may_write_registers): Likewise.
3549         (may_write_memory): Likewise.
3550         (may_insert_breakpoints): Likewise.
3551         (may_insert_tracepoints): Likewise.
3552         (may_insert_fast_tracepoints): Likewise.
3553         (may_stop): Likewise.
3554         (auto_connect_native_target): Likewise.
3555         (target_stop_and_wait): Update.
3556         (target_async_permitted): Change to bool.
3557         (target_async_permitted_1): Likewise.
3558         (may_write_registers_1): Likewise.
3559         (may_write_memory_1): Likewise.
3560         (may_insert_breakpoints_1): Likewise.
3561         (may_insert_tracepoints_1): Likewise.
3562         (may_insert_fast_tracepoints_1): Likewise.
3563         (may_stop_1): Likewise.
3564         * target.h (target_async_permitted): Likewise.
3565         (may_write_registers): Likewise.
3566         (may_write_memory): Likewise.
3567         (may_insert_breakpoints): Likewise.
3568         (may_insert_tracepoints): Likewise.
3569         (may_insert_fast_tracepoints): Likewise.
3570         (may_stop): Likewise.
3571         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3572         (make_thread_apply_all_options_def_group): Change argument from int*
3573         to bool*.
3574         (thread_apply_all_command): Update.
3575         (print_thread_events): Change to bool.
3576         * top.c (confirm): Likewise.
3577         (command_editing_p): Likewise.
3578         (history_expansion_p): Likewise.
3579         (write_history_p): Likewise.
3580         (info_verbose): Likewise.
3581         * top.h (confirm): Likewise.
3582         (history_expansion_p): Likewise.
3583         * tracepoint.c (disconnected_tracing): Likewise.
3584         (circular_trace_buffer): Likewise.
3585         * typeprint.c (print_methods): Likewise.
3586         (print_typedefs): Likewise.
3587         * utils.c (debug_timestamp): Likewise.
3588         (sevenbit_strings): Likewise.
3589         (pagination_enabled): Likewise.
3590         * utils.h (sevenbit_strings): Likewise.
3591         (pagination_enabled): Likewise.
3592         * valops.c (overload_resolution): Likewise.
3593         * valprint.h (struct value_print_options) <prettyformat_arrays,
3594         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3595         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3596         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3597         Likewise.
3598         * windows-nat.c (new_console): Likewise.
3599         (cygwin_exceptions): Likewise.
3600         (new_group): Likewise.
3601         (debug_exec): Likewise.
3602         (debug_events): Likewise.
3603         (debug_memory): Likewise.
3604         (debug_exceptions): Likewise.
3605         (useshell): Likewise.
3606         * windows-tdep.c (maint_display_all_tib): Likewise.
3607         * xml-support.c (debug_xml): Likewise.
3608
3609 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3610
3611         * source.c (prepare_path_for_appending): New function.
3612         (openp): Make use of new function.
3613         (find_and_open_source): Search for the compilation directory and
3614         source file as a relative path beneath the directory search path.
3615
3616 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * source-cache.c (source_cache::get_line_charpos): Catch
3619         exceptions and return false, this matches the behaviour documented
3620         in the header file.
3621
3622 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3623
3624         * ada-tasks.c (info_task): Remove quoting of the task's name.
3625
3626 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3627
3628         * symfile.c (auto_solib_add): Replace comment with a reference
3629         to the header file.
3630
3631 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3632
3633         * NEWS: Mention that gdb can now be compiled with Python 3
3634         on Windows.
3635
3636 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * maint.c (maint_print_section_data::maint_print_section_data):
3639         Force use of 'float log10 (float)' by casting the argument to
3640         float.
3641
3642 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3643
3644         * maint.c: Add 'cmath' include.
3645         (struct maint_print_section_data): New structure.
3646         (print_section_index): New function.
3647         (print_bfd_section_info): Add header comment, small whitespace
3648         cleanup, and update to call new print_section_index function.
3649         (print_objfile_section_info): Likewise.
3650         (maint_obj_section_from_bfd_section): New function.
3651         (print_bfd_section_info_maybe_relocated): New function.
3652         (maintenance_info_sections): Add header comment, always use
3653         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3654
3655 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3658         inner scope, add check that the objfile has psymtabs before
3659         checking psymtabs_addrmap.
3660         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3661
3662 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3663
3664         * NEWS: Announce that Ada task names are now shown at more places,
3665         and between quotes (except in info task output).
3666         * gdb/ada-tasks.c (task_to_str): New function.
3667         (display_current_task_id): Call task_to_str.
3668         (task_command_1): Likewise.
3669         (print_ada_task_info): In non-mi mode, Properly align headers and data
3670         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3671
3672 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3673
3674         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3675         prstatus.pr_lwp.pr_info instead of making it up.
3676
3677 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3678
3679         * auto-load.c (auto_load_expand_dir_vars): Update.
3680         * defs.h (gdb_datadir): Change to std::string.
3681         (python_libdir): Likewise.
3682         (relocate_gdb_directory): Change return type to std::string.
3683         * guile/guile.c (gdbscm_data_directory): Update.
3684         (initialize_scheme_side): Update.
3685         * jit.c (jit_reader_dir): Change to std::string.
3686         (jit_reader_load_command): Update.
3687         * main.c (gdb_datadir): Change to std::string.
3688         (python_libdir): Likewise.
3689         (set_gdb_data_directory): Update.
3690         (relocate_path): Change to return std::string.
3691         (relocate_gdb_directory): Change to return std::string.
3692         (relocate_gdbinit_path_maybe_in_datadir): Update.
3693         (captured_main_1): Update.
3694         * python/python.c (do_start_initialization): Update.
3695         * top.c (show_gdb_datadir): Update.
3696         * xml-syscall.c (xml_init_syscalls_info): Update.
3697         (init_syscalls_info): Update.
3698
3699 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3700
3701         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3702         out of get_init_files.
3703         (get_init_files): Update.
3704
3705 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3706
3707         * main.c (get_init_files): Change to use std::string.
3708         (captured_main_1): Update.
3709         (print_gdb_help): Update.
3710
3711 2019-09-11  Ali Tamur  <tamur@google.com>
3712
3713         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3714         implementation.
3715
3716 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3717
3718         * dbxread.c (read_dbx_symtab): Update.
3719         * dwarf2read.c (load_partial_dies): Update.
3720         * mdebugread.c (parse_partial_symbols): Update.
3721         (handle_psymbol_enumerators): Update.
3722         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3723         * psymtab.c (add_psymbol_to_bcache): Likewise.
3724         (add_psymbol_to_list): Likewise.
3725         * symtab.c (symbol_set_names): Likewise.
3726         * symtab.h (symbol_set_names): Likewise.
3727         * xcoffread.c (scan_xcoff_symtab): Update.
3728
3729 2019-09-11  Tom Tromey  <tom@tromey.com>
3730
3731         * symfile-mem.c (symbol_file_add_from_memory): Use
3732         bfd_set_filename.
3733         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3734         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3735
3736 2019-09-10  Tom Tromey  <tromey@adacore.com>
3737
3738         * dwarf-index-write.c (write_psymbols): Extend error message.
3739         (debug_names::insert): Add Ada code.
3740         (debug_names::write_psymbols): Remove Ada check.
3741         (debug_names) <m_string_obstack>: New member.
3742         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3743         (gdb_index_symbol_name_matcher::matches): Remove.
3744         (mapped_index_base::find_name_components_bounds): Add "lang"
3745         parameter.
3746         (mapped_index_base::build_name_components): Also split names
3747         according to Ada syntax.
3748         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3749         type of "match_callback".
3750         (check_match, check_find_bounds_finds)
3751         (dw2_expand_symtabs_matching): Update.
3752         (dw2_debug_names_iterator): Add new constructor.
3753         (dw2_debug_names_map_matching_symbols): New function.
3754         (dw2_debug_names_expand_symtabs_matching): Update.
3755         (dwarf2_debug_names_functions): Use
3756         dw2_debug_names_map_matching_symbols.
3757
3758 2019-09-10  Tom Tromey  <tromey@adacore.com>
3759
3760         * dwarf2read.c (dw2_get_file_names_reader): Add the
3761         CU's file name to the results.
3762
3763 2019-09-10  Tom Tromey  <tromey@adacore.com>
3764
3765         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3766         map_matching_symbols.  Update.
3767         * dwarf2read.c (dw2_map_matching_symbols): Update.
3768         * psymtab.c (match_partial_symbol): Change type; update.
3769         (psym_map_matching_symbols): Likewise.
3770         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3771         type; update.
3772         * symfile.h (struct quick_symbol_functions)
3773         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3774         Remove "match".
3775
3776 2019-09-10  Tom Tromey  <tromey@adacore.com>
3777
3778         * psymtab.c (map_block): Remove.
3779         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3780         * symtab.c (iterate_over_symbols_terminated): New function.
3781         * symtab.c (iterate_over_symbols_terminated): Declare.
3782
3783 2019-09-10  Tom Tromey  <tromey@adacore.com>
3784
3785         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3786         * language.h (struct language_defn) <la_iterate_over_symbols>:
3787         Return bool.
3788         * symtab.c (iterate_over_symbols): Return bool.
3789         * symtab.h (iterate_over_symbols): Return bool.
3790
3791 2019-09-10  Tom Tromey  <tromey@adacore.com>
3792
3793         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3794         (add_nonlocal_symbols): Update.
3795         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3796         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3797         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3798         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3799         Change type of "callback".  Remove "data".
3800
3801
3802 2019-09-09  Ali Tamur  <tamur@google.com>
3803
3804         * dwarf2read.c (comp_unit_head): Update comment.
3805         (dwarf2_dwo_name): New function declaration.
3806         (dwarf_unit_type_name): New function declaration.
3807         (read_comp_unit_head): Add support for new compilation units,
3808         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3809         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3810         (currently named as "signature") in their header. Also clarify error
3811         messages.
3812         (lookup_dwo_id): New function. Returns the dwo id of the given
3813         compile unit.
3814         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3815         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3816         functions.
3817         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3818         (dwarf2_dwo_name): Get the dwo name if present.
3819         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3820         purposes.
3821
3822 2019-09-09  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3825
3826 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3827
3828         * python/python.c (do_start_initialization): Make progname_copy static,
3829         to avoid a leak report.
3830
3831 2019-09-08  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3834
3835 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3836
3837         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3838         Change type to gdb::optional<block_enum>.
3839         (dw2_symtab_iter_init): Change block_index parameter type
3840         to gdb::optional<block_enum>.
3841         (dw2_lookup_symbol): Change block_index parameter
3842         type to block_enum.c
3843         (dw2_debug_names_lookup_symbol): Likewise.
3844         * psymtab.c (psym_lookup_symbol): Likewise.
3845         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3846         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3847         Likewise.
3848
3849 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3850
3851         * defs.h (relocate_gdb_directory): Change int to bool in
3852         signature and rename flag to relocatable.
3853         * main.c (relocate_path): Likewise.
3854         (relocate_gdb_directory): Likewise.
3855
3856 2019-09-06  Alan Modra  <amodra@gmail.com>
3857
3858         * coffread.c (coff_symfile_read): Constify filename variable.
3859         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3860         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3861         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3862         * solib.c (reload_shared_libraries_1): Likewise.
3863         * symfile.c (reread_symbols): Likewise.
3864         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3865         * solib-darwin.c (darwin_bfd_open): Likewise.
3866         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3867
3868 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3871         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3872
3873 2019-09-03  Tom Tromey  <tromey@adacore.com>
3874
3875         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3876         types.
3877         (has_negatives): Unbias a range type bound.
3878         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3879         * gdbtypes.c (operator==): Handle new field.
3880         (create_range_type): Add "bias" parameter.
3881         (create_static_range_type, resolve_dynamic_range): Update.
3882         * gdbtypes.h (struct range_bounds) <bias>: New member.
3883         (create_range_type): Add bias parameter.
3884         * printcmd.c (print_scalar_formatted): Unbias range types.
3885         * value.c (unpack_long): Unbias range types.
3886         (pack_long): Bias range types.
3887
3888 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3889
3890         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3891         probe arguments.
3892
3893 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3894
3895         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3896         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3897         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3898         (compile_probe_arg): Likewise.
3899         * probe.h (get_argument_count): Likewise.
3900         * solib-svr4.c (solib_event_probe_action): Likewise.
3901         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3902
3903 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3904
3905         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3906         code to here...
3907         (svr4_create_solib_event_breakpoints): ...from here.
3908
3909 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3910
3911         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3912         suffix from warning message.
3913
3914 2019-08-30  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui-winsource.h (struct tui_source_window_base)
3917         <refresh_all>: Don't declare.
3918         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3919         Remove.
3920         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3921         tui_show_locator_content.
3922         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3923         declare.
3924         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3925         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3926         declare.
3927
3928 2019-08-30  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3931
3932 2019-08-30  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3935         Remove unnecessary forward declarations.
3936
3937 2019-08-30  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3940         rerender.
3941         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3942         tui_show_locator_content.
3943
3944 2019-08-30  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3947         (tui_locator_window::rerender): Rewrite using body of previous
3948         tui_show_locator_content.
3949
3950 2019-08-30  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3953         set_locator_fullname>: New methods.
3954         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3955         Rename from tui_set_locator_fullname.
3956         (tui_locator_window::set_locator_info): Rename from
3957         tui_set_locator_info.  Return bool.
3958         (tui_update_locator_fullname, tui_show_frame_info): Update.
3959
3960 2019-08-30  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3963
3964 2019-08-30  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3967         call touchwin.
3968
3969 2019-08-30  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-wingeneral.c (box_win): Assume win_info and
3972         win_info->handle cannot be NULL.
3973
3974 2019-08-30  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3977         refresh_window>: Declare.
3978         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3979         resize.
3980         (tui_data_item_window::rerender): Rename from
3981         tui_display_register.
3982         (tui_data_item_window::refresh_window): New method.
3983         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3984         no-op.
3985
3986 2019-08-30  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3989         regs_column_count, current_group>: Move later.  Now private.
3990         <get_current_group>: New method.
3991         * tui/tui-regs.c (tui_reg_command): Update.
3992         * tui/tui-layout.c (tui_set_layout): Update.
3993
3994 2019-08-30  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3997         (tui_data_window::rerender): Don't call
3998         check_and_display_highlight_if_needed.
3999         (tui_data_window::refresh_all): Remove call to
4000         erase_data_content.
4001
4002 2019-08-30  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4005         (tui_data_window::display_registers_from)
4006         (tui_data_window::display_reg_element_at_line)
4007         (tui_data_window::display_registers_from_line): Remove checks of
4008         "empty".
4009
4010 2019-08-30  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4013         Don't declare.
4014         * tui/tui-regs.c (tui_data_window::show_registers): Call
4015         rerender.
4016         (tui_data_window::rerender): Rename from display_all_data.
4017         (tui_data_window::rerender): Remove old implementation.
4018
4019 2019-08-30  Tom Tromey  <tom@tromey.com>
4020
4021         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4022         text.
4023         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4024
4025 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4026             Sergio Durigan Junior  <sergiodj@redhat.com>
4027
4028         PR win32/24284
4029         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4030
4031 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4034         when searching for types.
4035
4036 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * f-lang.c (f_language_defn): Use f_print_typedef.
4039         * f-lang.h (f_print_typedef): Declare.
4040         * f-typeprint.c (f_print_typedef): Define.
4041
4042 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4043
4044         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4045
4046 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * cli/cli-utils.c (info_print_options_defs): Delete.
4049         (make_info_print_options_def_group): Delete.
4050         (extract_info_print_options): Delete.
4051         (info_print_command_completer): Delete.
4052         (info_print_args_help): Add extra parameter, and optionally
4053         include text about -n flag.
4054         * cli/cli-utils.h (struct info_print_options): Delete.
4055         (extract_info_print_options): Delete declaration.
4056         (info_print_command_completer): Delete declaration.
4057         (info_print_args_help): Add extra parameter, extend header
4058         comment.
4059         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4060         search_symbols.
4061         * stack.c (struct info_print_options): New type.
4062         (info_print_options_defs): New file scoped variable.
4063         (make_info_print_options_def_group): New static function.
4064         (info_print_command_completer): New static function.
4065         (info_locals_command): Update to use new local functions.
4066         (info_args_command): Likewise.
4067         (_initialize_stack): Add extra parameter to calls to
4068         info_print_args_help.
4069         * symtab.c (search_symbols): Add extra parameter, use this to
4070         possibly excluse non-debug symbols.
4071         (symtab_symbol_info): Add extra parameter, which is passed on to
4072         search_symbols.
4073         (struct info_print_options): New type.
4074         (info_print_options_defs): New file scoped variable.
4075         (make_info_print_options_def_group): New static function.
4076         (info_print_command_completer): New static function.
4077         (info_variables_command): Update to use local functions, and pass
4078         extra parameter through to symtab_symbol_info.
4079         (info_functions_command): Likewise.
4080         (info_types_command): Pass additional argument through to
4081         symtab_symbol_info.
4082         (rbreak_command): Pass extra argument to search_symbols.
4083         (_initialize_symtab): Add extra arguments for calls to
4084         info_print_args_help, and update help text for 'info variables',
4085         'whereis', and 'info functions' commands.
4086         * symtab.h (search_symbols): Add extra argument to declaration.
4087         * NEWS: Mention new flags.
4088
4089 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4090
4091         * symtab.c (lookup_static_symbol): Call the new function (and move
4092         it down to be next to lookup_global_symbol).
4093         (struct global_sym_lookup_data): Add block_enum member and rename to...
4094         (struct global_or_static_sym_lookup_data): ...this.
4095         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4096         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4097         (lookup_symbol_global_or_static_iterator_cb): ...this.
4098         (lookup_global_or_static_symbol): New function.
4099         (lookup_global_symbol): Call new function.
4100
4101 2019-08-26  Tom de Vries  <tdevries@suse.de>
4102
4103         PR c++/24852
4104         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4105         when pc_probe.prob == NULL.
4106
4107 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4108
4109         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4110         variable symbol_linkage to symbol_linkage_.
4111
4112 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4113
4114         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4115         represent whether the symbol is static, dynamic, or we don't
4116         know.
4117
4118 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4119
4120         * gdb/rx-tdep.c (rx_register_names): New.
4121         (rx_register_name): Delete.
4122         (rx_psw_type): Delete.
4123         (rx_fpsw_type): Delete.
4124         (rx_register_type): Delete.
4125         (rx_gdbarch_init): Convert target-descriptions.
4126         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4127         * gdb/features/Makefile: Add rx.xml.
4128         * gdb/features/rx.xml: New.
4129         * gdb/features/rx.c: Generated.
4130         * gdb/NEWS: Mention target description support.
4131
4132 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4133
4134         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4135         *slot_ptr.
4136
4137 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4138
4139         * configure.ac: Don't check for 'dlfcn.h' (moved to
4140         gdbsupport/common.m4).
4141         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4142         'gdbsupport/'.
4143         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4144         * compile/compile-c-support.c: Include
4145         'gdbsupport/gdb-dlfcn.h'.
4146         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4147         * gdb-dlfcn.c: Move to...
4148         * gdbsupport/gdb-dlfcn.c: ... here.
4149         * gdb-dlfcn.h: Move to...
4150         * gdbsupport/gdb-dlfcn.h: ... here.
4151
4152 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4153
4154         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4155         the offset field signed.
4156
4157 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4158
4159         * python/lib/gdb/__init__.py (_execute_file): New function.
4160         * python/python.c (python_run_simple_file): Call gdb._execute_file
4161         on Windows.
4162
4163 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4164
4165         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4166         all uses as this was never set to anything but a zero value.
4167
4168 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4169
4170         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4171
4172 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4173
4174         * tui/tui-data.h (tui_gen_win_info): Add an =default
4175         move constructor, required by some GCC versions.
4176
4177 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4178
4179         * go32-nat.c (go32_sysinfo): Add hygon_p.
4180
4181 2019-08-20  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4184         line_from_reg_element_no, first_reg_element_no_inline,
4185         display_all_data, delete_data_content_windows,
4186         erase_data_content>: Now private.
4187
4188 2019-08-20  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4191         (tui_unhighlight_win, tui_highlight_win)
4192         (tui_win_info::make_window): Update.
4193         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4194
4195 2019-08-20  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4198         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4199         (MAX_PID_WIDTH): Move to tui-stack.c.
4200         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4201         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4202         (MAX_PID_WIDTH): Move from tui-data.h.
4203
4204 2019-08-20  Tom Tromey  <tom@tromey.com>
4205
4206         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4207         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4208         (box_win): Update.
4209         (tui_gen_win_info::make_window): Rename from tui_make_window.
4210         (tui_win_info::make_window): New method.
4211         (tui_gen_win_info::make_visible): Update.
4212         * tui/tui-source.c (tui_source_window::set_contents): Update.
4213         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4214         (tui_data_window::display_registers_from): Update.
4215         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4216         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4217         Declare.
4218         <can_box>: Remove.
4219         <title>: Remove.
4220         (struct tui_win_info) <make_window>: Declare.
4221         <can_box>: Now virtual.
4222         <title>: New member.
4223         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4224         * tui/tui-command.c (tui_cmd_window::resize): Update.
4225
4226 2019-08-20  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4229         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4230         (tui_data_window::check_register_values): Update.
4231
4232 2019-08-20  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-regs.h (struct tui_data_window): Use
4235         DISABLE_COPY_AND_ASSIGN.
4236         <regs_content>: Change type, removing unique_ptr.
4237         <tui_data_window>: Add move constructor.
4238         * tui/tui-regs.c (tui_data_window::show_registers)
4239         (tui_data_window::show_register_group)
4240         (tui_data_window::display_registers_from)
4241         (tui_data_window::display_registers_from)
4242         (tui_data_window::first_data_item_displayed)
4243         (tui_data_window::delete_data_content_windows)
4244         (tui_data_window::rerender, tui_data_window::refresh_window)
4245         (tui_data_window::check_register_values): Update.
4246
4247 2019-08-20  Tom Tromey  <tom@tromey.com>
4248
4249         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4250         show_register_group>: Declare.
4251         (tui_show_register_group): Don't declare.
4252         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4253         tui_show_registers.
4254         (tui_data_window::show_register_group): Rename from
4255         tui_show_register_group.
4256         (tui_data_window::check_register_values, tui_reg_command):
4257         Update.
4258         * tui/tui-layout.c (tui_set_layout): Update.
4259
4260 2019-08-20  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4263         Declare.
4264         (tui_check_register_values): Don't declare.
4265         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4266         from tui_check_register_values.
4267         * tui/tui-hooks.c (tui_register_changed): Update.
4268
4269 2019-08-20  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-regs.c (tui_reg_layout): Move later.
4272         (tui_show_registers): Don't enable TUI mode or change layout.
4273
4274 2019-08-20  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-regs.h (struct tui_data_item_window)
4277         <~tui_data_item_window>: Remove.
4278         <content>: Now a unique_xmalloc_ptr.
4279         * tui/tui-regs.c (tui_register_format): Return a
4280         unique_xmalloc_ptr.
4281         (tui_get_register): Update.
4282         (~tui_data_item_window): Remove.
4283         (tui_data_window::display_registers_from, tui_display_register):
4284         Update.
4285         * tui/tui-io.h (tui_expand_tabs): Update.
4286         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4287         Remove "col" parameter.
4288
4289 2019-08-20  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4292         field.
4293         * tui/tui-regs.c (~tui_data_item_window): Update.
4294
4295 2019-08-20  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4298         earlier.
4299
4300 2019-08-20  Tom Tromey  <tom@tromey.com>
4301
4302         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4303
4304 2019-08-20  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-source.h (struct tui_source_window): Update.
4307         * tui/tui-regs.c (tui_show_registers): Update.
4308         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4309         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4310         (NO_REGS_STRING): Remove defines.
4311
4312 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4313
4314         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4315         unnecessary thread walk if remote doesn't support the packet.
4316
4317 2019-08-19  Tom Tromey  <tromey@adacore.com>
4318
4319         * python/py-value.c (value_has_field): Fix indentation.
4320
4321 2019-08-19  Tom Tromey  <tromey@adacore.com>
4322
4323         * printcmd.c (do_one_display, info_display_command): Update.
4324         * block.h (contained_in): Return bool.  Add allow_nested
4325         parameter.
4326         * block.c (contained_in): Return bool.  Add allow_nested
4327         parameter.
4328
4329 2019-08-19  Tom Tromey  <tom@tromey.com>
4330
4331         * configure: Rebuild.
4332         * configure.ac: Disallow the combination of -static-libstdc++ and
4333         source highlight.
4334         * source-cache.c (get_language_name): Handle rust.
4335         (source_cache::get_source_lines): Ignore highlighting exceptions.
4336
4337 2019-08-16  Tom Tromey  <tom@tromey.com>
4338
4339         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4340         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4341         (struct tui_source_window_base) <make_visible, refresh_window,
4342         resize>: Remove methods.
4343         <execution_info>: Remove field.
4344         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4345         (tui_show_source_line, tui_source_window_base)
4346         (~tui_source_window_base): Update.
4347         (tui_source_window_base::resize)
4348         (tui_source_window_base::make_visible)
4349         (tui_source_window_base::refresh_window): Remove.
4350         (tui_source_window_base::update_exec_info): Update.
4351         * tui/tui-source.c (tui_source_window::set_contents): Update.
4352         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4353
4354 2019-08-16  Tom Tromey  <tom@tromey.com>
4355
4356         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4357         deprecated_query_hook.
4358
4359 2019-08-16  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4362         (tui_update_source_windows_with_line): Update.
4363         * tui/tui-source.h (struct tui_source_window)
4364         <show_symtab_source>: Declare.
4365         (tui_show_symtab_source): Don't declare.
4366         * tui/tui-source.c (tui_show_symtab_source): Rename from
4367         tui_show_symtab_source.
4368
4369 2019-08-16  Tom Tromey  <tom@tromey.com>
4370
4371         * tui/tui-winsource.h (struct tui_source_window_base)
4372         <set_contents>: Declare.
4373         * tui/tui-winsource.c
4374         (tui_source_window_base::update_source_window_as_is): Update.
4375         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4376         Declare.
4377         (tui_set_source_content): Don't declare.
4378         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4379         tui_set_source_content.
4380         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4381         Declare.
4382         (tui_set_disassem_content): Don't declare.
4383         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4384         tui_set_disassem_content.
4385
4386 2019-08-16  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-winsource.h (struct tui_source_window_base)
4389         <update_breakpoint_info>: Declare.
4390         (tui_update_breakpoint_info): Don't declare.
4391         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4392         (tui_update_all_breakpoint_info): Update.
4393         (tui_source_window_base::update_breakpoint_info): Rename from
4394         tui_update_breakpoint_info.
4395         (tui_source_window_base::update_exec_info): Update.
4396
4397 2019-08-16  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui-winsource.h (struct tui_source_window_base)
4400         <update_source_window>: Declare.
4401         (tui_update_source_window): Don't declare.
4402         * tui/tui-winsource.c
4403         (tui_source_window_base::update_source_window): Rename from
4404         tui_update_source_window.
4405         (tui_source_window_base::rerender): Update.
4406         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4407         * tui/tui-disasm.c (tui_show_disassem)
4408         (tui_show_disassem_and_update_source)
4409         (tui_disasm_window::maybe_update): Update.
4410
4411 2019-08-16  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-winsource.h (struct tui_source_window_base)
4414         <update_source_window_as_is>: Declare.
4415         (tui_update_source_window_as_is): Don't declare.
4416         * tui/tui-winsource.c (tui_update_source_window): Update
4417         (tui_source_window_base::update_source_window_as_is): Rename from
4418         tui_update_source_window_as_is.
4419         (tui_source_window_base::refill): Update.
4420         * tui/tui-source.c (tui_show_symtab_source): Update.
4421         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4422         Update.
4423
4424 2019-08-16  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-winsource.h (tui_update_source_window)
4427         (tui_update_source_window_as_is): Remove "noerror" parameter.
4428         * tui/tui-winsource.c (tui_update_source_window)
4429         (tui_update_source_window_as_is): Remove "noerror" parameter.
4430         (tui_update_source_windows_with_addr)
4431         (tui_update_source_windows_with_line)
4432         (tui_source_window_base::rerender)
4433         (tui_source_window_base::refill): Update.
4434         * tui/tui-source.h (tui_set_source_content)
4435         (tui_show_symtab_source): Remove "noerror" parameter.
4436         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4437         parameter.
4438         (tui_show_symtab_source): Likewise.
4439         (tui_source_window::maybe_update): Update.
4440         * tui/tui-disasm.c (tui_show_disassem)
4441         (tui_show_disassem_and_update_source)
4442         (tui_disasm_window::do_scroll_vertical)
4443         (tui_disasm_window::maybe_update): Update.
4444
4445 2019-08-16  Tom Tromey  <tom@tromey.com>
4446
4447         * tui/tui.c (tui_is_window_visible): Update.
4448         * tui/tui-wingeneral.c (tui_make_window)
4449         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4450         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4451         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4452         (tui_set_win_height_command, parse_scrolling_args): Update.
4453         * tui/tui-source.c (tui_source_window::style_changed): Update.
4454         * tui/tui-regs.c (tui_show_registers)
4455         (tui_data_window::first_data_item_displayed)
4456         (tui_data_window::delete_data_content_windows)
4457         (tui_check_register_values, tui_reg_command): Update.
4458         * tui/tui-disasm.c (tui_show_disassem): Update.
4459         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4460         method.
4461         <is_visible>: Remove field.
4462         * tui/tui-data.c (tui_next_win, tui_prev_win)
4463         (tui_delete_invisible_windows): Update.
4464
4465 2019-08-16  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui-winsource.h (struct tui_source_window_base)
4468         <m_has_locator>: Remove.
4469         * tui/tui-layout.c (show_source_disasm_command, show_data)
4470         (show_source_or_disasm_and_command): Update.
4471
4472 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4473
4474         * NEWS (Other MI changes): New subsection.
4475         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4476         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4477         * arch-utils.c (default_get_pc_address_flags): New function.
4478         * arch-utils.h (default_get_pc_address_flags): New declaration.
4479         * gdbarch.sh: Add get_pc_address_flags.
4480         * gdbarch.c: Regenerate.
4481         * gdbarch.h: Likewise.
4482         * stack.c (print_pc): New function.
4483         (print_frame_info) (print_frame): Call print_pc.
4484
4485 2019-08-16  Tom de Vries  <tdevries@suse.de>
4486
4487         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4488         print_objfile_section_info.
4489
4490 2019-08-15  Tom Tromey  <tom@tromey.com>
4491
4492         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4493         calling update_cmdwin_start_line.
4494         * tui/tui-winsource.h (struct tui_source_window_base)
4495         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4496         <rerender>: Declare.
4497         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4498         Call rerender.
4499         (tui_source_window_base::set_new_height): Remove.
4500         (tui_source_window_base::rerender): Rename from
4501         do_make_visible_with_new_height.
4502         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4503         resize method.
4504         (tui_win_info::make_invisible_and_set_new_height)
4505         (tui_win_info::make_visible_with_new_height): Remove.
4506         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4507         Declare.
4508         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4509         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4510         do_make_visible_with_new_height>: Don't declare.
4511         <rerender>: Declare.
4512         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4513         set_new_height.
4514         (tui_data_window::do_make_visible_with_new_height): Remove.
4515         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4516         call tui_show_locator_content.
4517         (tui_gen_win_info::resize): Call rerender.
4518         (show_source_or_disasm_and_command): Don't call
4519         tui_show_locator_content.
4520         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4521         method.
4522         (struct tui_win_info) <rerender>: Declare.
4523         <set_new_height, make_invisible_and_set_new_height,
4524         make_visible_with_new_height>: Don't declare.
4525         * tui/tui-data.c (tui_win_list::rerender): New method.
4526         * tui/tui-command.h (struct tui_cmd_window)
4527         <do_make_visible_with_new_height>: Don't declare.
4528         * tui/tui-command.c
4529         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4530
4531 2019-08-15  Tom Tromey  <tromey@adacore.com>
4532
4533         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4534         * ada-lang.c (ada_enum_name): Likewise.
4535
4536 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4537
4538         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4539         leading underscore.
4540         (GdbOutputErrorFile): Likewise.
4541         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4542         accordingly.
4543         (execute_unwinders): Rename to have a leading underscore.
4544         (auto_load_packages): Likewise.
4545         (global scope): Adjust call to auto_load_packages accordingly.
4546         (GdbSetPythonDirectory): Likewise.
4547         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4548         instead of execute_unwinders.
4549
4550 2019-08-15  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4553         (show_data): Don't change window visibility.
4554         (tui_gen_win_info::resize): Remove special case for command
4555         window.  Use wresize, when available.
4556         (show_source_or_disasm_and_command): Don't change window
4557         visibility.
4558         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4559         <make_visible>: New method.
4560         * tui/tui-command.c (tui_cmd_window::resize): New method.
4561
4562 2019-08-15  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4565         (struct tui_source_windows): New.
4566         * tui/tui-winsource.c (tui_display_main): Update.
4567         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4568         (new_height_ok, parse_scrolling_args): Update.
4569         * tui/tui-layout.c (show_layout, show_data): Update.
4570         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4571         (tui_add_to_source_windows): Don't declare.
4572         * tui/tui-data.c (source_windows, tui_source_windows)
4573         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4574
4575 2019-08-15  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4578         Rename from reset.
4579         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4580         * tui/tui-layout.c (show_source_disasm_command, show_data):
4581         Update.
4582         (tui_gen_win_info::resize): Rename.
4583         (show_source_or_disasm_and_command): Update.
4584         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4585         reset.
4586
4587 2019-08-15  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4590         * tui/tui-interp.c (tui_interp::init): Don't call
4591         tui_initialize_static_data.
4592         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4593
4594 2019-08-15  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4597         examine tui_win_list.
4598
4599 2019-08-15  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4602         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4603         tui_clear_source_content.
4604         (tui_clear_source_content): Remove.
4605         (tui_source_window_base::do_erase_source_content): Hoist call to
4606         content.clear().
4607         * tui/tui-stack.c (tui_show_frame_info): Don't call
4608         tui_clear_source_content.
4609
4610 2019-08-15  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-winsource.h (struct tui_source_window_base)
4613         <do_erase_source_content>: New method.
4614         <erase_source_content>: New method.
4615         (tui_erase_source_content): Don't declare.
4616         * tui/tui-winsource.c (tui_clear_source_content): Update.
4617         (tui_source_window_base::do_erase_source_content): Rename from
4618         tui_erase_source_content.
4619         (tui_source_window_base::show_source_content): Update.
4620         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4621         * tui/tui-source.h (struct tui_source_window)
4622         <erase_source_content>: New method.
4623         * tui/tui-disasm.h (struct tui_disasm_window)
4624         <erase_source_content>: New method.
4625
4626 2019-08-15  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4629         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4630         constructor.
4631         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4632         * tui/tui-source.c (tui_set_source_content): Update.
4633         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4634
4635 2019-08-15  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4638         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4639         tui-source.c.
4640         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4641         Declare.
4642         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4643         method.
4644         (tui_source_window::maybe_update): Update.
4645
4646 2019-08-15  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4649         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4650         tui-disasm.c.
4651         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4652         Declare.
4653         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4654         method.
4655         (tui_disasm_window::maybe_update): Update.
4656
4657 2019-08-15  Tom Tromey  <tom@tromey.com>
4658
4659         * tui/tui-winsource.h (struct tui_source_window_base)
4660         <maybe_update>: Declare.
4661         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4662         method.
4663         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4664         Declare.
4665         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4666         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4667         Declare.
4668         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4669
4670 2019-08-15  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4673
4674 2019-08-15  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-wingeneral.c: Include tui-stack.h.
4677         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4678         (struct tui_locator_window): Move from tui-data.h.
4679         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4680         (tui_initialize_static_data): Move from tui-data.c.
4681         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4682         (struct tui_locator_window): Move to tui-stack.c.
4683         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4684         (tui_initialize_static_data): Move to tui-stack.c.
4685
4686 2019-08-15  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-layout.c (show_source_disasm_command)
4689         (show_source_or_disasm_and_command): Use make_visible method, not
4690         tui_make_window.
4691         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4692         Remove.
4693
4694 2019-08-15  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-wingeneral.h (tui_make_window): Update.
4697         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4698         parameter.
4699         (tui_gen_win_info::make_visible): Update.
4700         * tui/tui-regs.c (tui_data_window::display_registers_from):
4701         Update.
4702         * tui/tui-layout.c (show_source_disasm_command)
4703         (show_source_or_disasm_and_command): Update.
4704         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4705         (enum tui_box): Remove.
4706         (struct tui_win_info) <can_box>: New method.
4707         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4708         method.
4709
4710 2019-08-15  Tom de Vries  <tdevries@suse.de>
4711
4712         * linux-nat-trad.c: Include gdbarch.h.
4713
4714 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4715
4716         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4717         register sizes.
4718
4719 2019-08-14  Tom Tromey  <tromey@adacore.com>
4720
4721         * darwin-nat.c: Include gdbarch.h.
4722         * darwin-nat-info.c: Include gdbarch.h.
4723
4724 2019-08-13  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4727         Remove.
4728         * tui/tui-data.c (tui_initialize_static_data): Update.
4729
4730 2019-08-13  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui-winsource.h (struct tui_exec_info_window)
4733         <~tui_exec_info_window, maybe_allocate_content, get_content,
4734         m_content>: Remove.
4735         (struct tui_source_window_base) <set_exec_info_content,
4736         show_exec_info_content>: Don't declare.
4737         * tui/tui-winsource.c
4738         (tui_exec_info_window::maybe_allocate_content): Remove.
4739         (tui_source_window_base::update_exec_info): Rename from
4740         set_exec_info_content.
4741         (tui_source_window_base::show_exec_info_content)
4742         (tui_source_window_base::update_exec_info): Remove.
4743
4744 2019-08-13  Tom Tromey  <tom@tromey.com>
4745
4746         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4747         declare.
4748         * tui/tui-winsource.c (tui_update_source_window_as_is)
4749         (tui_update_source_windows_with_addr, tui_erase_source_content):
4750         Update.
4751         (tui_clear_exec_info_content): Remove.
4752
4753 2019-08-13  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4756         declare.
4757         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4758         call tui_erase_exec_info_content.
4759         (tui_clear_exec_info_content): Rename from
4760         tui_erase_exec_info_content.
4761         (tui_clear_exec_info_content): Delete.
4762
4763 2019-08-13  Tom Tromey  <tom@tromey.com>
4764
4765         * tui/tui-winsource.h (struct tui_source_window_base)
4766         <show_exec_info_content>: Declare.
4767         (tui_show_exec_info_content): Don't declare.
4768         * tui/tui-winsource.c
4769         (tui_source_window_base::show_exec_info_content): Rename from
4770         tui_show_exec_info_content.
4771         (tui_source_window_base::update_exec_info): Update.
4772
4773 2019-08-13  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4776         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4777         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4778         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4779         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4780         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4781         ... here.
4782
4783 2019-08-13  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-winsource.h (struct tui_source_window_base)
4786         <update_exec_info>: Declare.
4787         (tui_update_exec_info): Don't declare.
4788         * tui/tui-winsource.c (tui_update_source_window_as_is)
4789         (tui_source_window_base::refresh_all)
4790         (tui_update_all_breakpoint_info): Update.
4791         (tui_source_window_base::update_exec_info): Rename from
4792         tui_update_exec_info.
4793         * tui/tui-stack.c (tui_show_frame_info): Update.
4794
4795 2019-08-13  Tom Tromey  <tom@tromey.com>
4796
4797         * tui/tui-winsource.h (struct tui_source_window_base)
4798         <set_exec_info_content>: Declare.
4799         (tui_set_exec_info_content): Don't declare.
4800         * tui/tui-winsource.c
4801         (tui_source_window_base::set_exec_info_content): Rename from
4802         tui_set_exec_info_content.
4803         (tui_update_exec_info): Update.
4804
4805 2019-08-13  Tom Tromey  <tom@tromey.com>
4806
4807         * tui/tui-winsource.h (struct tui_source_window_base)
4808         <show_source_content>: Declare.
4809         (tui_show_source_content): Don't declare.
4810         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4811         (tui_source_window_base::show_source_content): Rename from
4812         tui_show_source_content.
4813         (tui_source_window_base::refresh_all): Update.
4814         * tui/tui-layout.c (show_source_disasm_command)
4815         (show_source_or_disasm_and_command): Update.
4816
4817 2019-08-13  Tom Tromey  <tom@tromey.com>
4818
4819         * tui/tui-winsource.c (tui_erase_source_content)
4820         (tui_show_source_content, tui_source_window_base::refresh_all):
4821         Update.
4822         * tui/tui-wingeneral.h
4823         (tui_check_and_display_highlight_if_needed): Don't declare.
4824         * tui/tui-wingeneral.c
4825         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4826         check_and_display_highlight_if_needed.
4827         * tui/tui-win.c (tui_rehighlight_all)
4828         (tui_win_info::make_visible_with_new_height): Update.
4829         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4830         (tui_data_window::erase_data_content)
4831         (tui_data_window::display_all_data): Update.
4832         * tui/tui-data.h (struct tui_win_info)
4833         <check_and_display_highlight_if_needed>: Declare.
4834
4835 2019-08-13  Tom Tromey  <tom@tromey.com>
4836
4837         * tui/tui-win.c (tui_resize_all): Call
4838         tui_delete_invisible_windows.
4839         * tui/tui-layout.c (show_layout): Call
4840         tui_delete_invisible_windows.
4841         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4842         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4843
4844 2019-08-13  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4847         tui_add_win_to_layout.
4848
4849 2019-08-13  Tom Tromey  <tom@tromey.com>
4850
4851         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4852         * tui/tui-layout.c (tui_default_win_height): Now static.
4853
4854 2019-08-13  Tom Tromey  <tom@tromey.com>
4855
4856         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4857         single switch.
4858         (show_source_disasm_command, show_source_or_disasm_and_command):
4859         Don't check current layout.
4860
4861 2019-08-13  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-wingeneral.c (make_all_visible): Remove.
4864         (tui_make_all_invisible): Simplify.
4865         * tui/tui-layout.c (tui_make_all_invisible): Move from
4866         tui-wingeneral.c; simplify.
4867         (show_layout): Hoist call to tui_make_all_invisible.
4868         (show_data): Don't call tui_make_all_invisible.
4869
4870 2019-08-13  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4873         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4874
4875 2019-08-13  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4878         tui-data.c.
4879         (show_source_disasm_command, show_data)
4880         (show_source_or_disasm_and_command): Don't use
4881         tui_set_current_layout_to.
4882         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4883         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4884         tui-layout.c.
4885         (tui_set_current_layout_to): Remove.
4886
4887 2019-08-13  Tom Tromey  <tom@tromey.com>
4888
4889         * tui/tui-layout.c (tui_set_layout): Update.
4890         * tui/tui-data.h (struct tui_layout_def): Remove.
4891         (tui_layout_def): Don't declare.
4892         * tui/tui-data.c (layout_def): Remove.
4893         (tui_layout_def): Remove.
4894
4895 2019-08-13  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-winsource.h (struct tui_source_window_base)
4898         <clear_detail>: No longer "override".
4899         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4900         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4901         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4902         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4903         Remove.
4904         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4905
4906 2019-08-13  Tom Tromey  <tromey@adacore.com>
4907
4908         * tracepoint.c: Don't include readline.h or history.h.
4909
4910 2019-08-12  Tom Tromey  <tom@tromey.com>
4911
4912         * configure: Rebuild.
4913         * configure.ac: Check for readline 7.
4914         * NEWS: Mention readline 7 requirement.
4915         * README: Update.
4916
4917 2019-08-12  Tom Tromey  <tom@tromey.com>
4918
4919         * mingw-hdep.c (gdb_select): Remove readline hack.
4920
4921 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4922
4923         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4924         when the function fails.
4925
4926 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4927
4928         * s390-tdep.c (s390_type_align): New function.
4929         (s390_gdbarch_init): Set it as type_align gdbarch method.
4930
4931 2019-08-09  Tom de Vries  <tdevries@suse.de>
4932
4933         PR gdb/24591
4934         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4935         pc_low with relocation offset.
4936
4937 2019-08-07  Tom Tromey  <tromey@adacore.com>
4938
4939         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4940         (print_frame_args): Update.
4941         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4942         Update.
4943         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4944         * frame.h (struct frame_arg): Add initializers.
4945         <error>: Now a unique_xmalloc_ptr.
4946
4947 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4948
4949         * NEWS: Expand the Pointer Authentication entry.
4950         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4951         (aarch64_frame_unmask_lr): ... to this.
4952         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4953         Call aarch64_frame_unmask_lr.
4954         * frame.c (struct frame_info): Add "masked" variable.
4955         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4956         (fprint_frame): Check for masked pc.
4957         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4958         declarations.
4959         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4960         * stack.c (print_frame): Check for masked pc.
4961
4962 2019-08-06  Tom Tromey  <tom@tromey.com>
4963
4964         * stabsread.c (patch_block_stabs, read_one_struct_field)
4965         (read_enum_type): Use obstack_strndup.
4966         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4967         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4968         * dwarf2read.c (guess_full_die_structure_name)
4969         (anonymous_struct_prefix): Use obstack_strndup.
4970         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4971         * c-exp.y (yylex): Use obstack_strndup.
4972         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4973         (write_var_or_type): Use obstack_strndup.
4974
4975 2019-08-06  Tom Tromey  <tom@tromey.com>
4976
4977         * symfile.c (reread_symbols): Use obstack_strdup.
4978         * stabsread.c (read_type): Use obstack_strdup.
4979         * gdb_obstack.h (obstack_strdup): New overload.
4980         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4981         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4982         (dwarf2_canonicalize_name): Use obstack_strdup.
4983         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4984         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4985         Use obstack_strdup.
4986
4987 2019-08-06  Tom Tromey  <tom@tromey.com>
4988
4989         * gdb_obstack.h (obstack_strdup): Define.
4990         * gdb_obstack.c (obstack_strdup): Don't define.
4991
4992 2019-08-06  Tom Tromey  <tom@tromey.com>
4993
4994         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4995         obstack_strdup.
4996         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4997         obstack_strdup.
4998         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4999         * stabsread.c (common_block_start): Use obstack_strdup.
5000         * objfiles.c (set_objfile_main_name, objfile): Use
5001         obstack_strdup.
5002         * namespace.c (add_using_directive): Use obstack_strdup.
5003         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5004         * jit.c (finalize_symtab): Use obstack_strdup.
5005         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5006         (guess_partial_die_structure_name, partial_die_info::fixup)
5007         (dwarf2_name): Use obstack_strdup.
5008         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5009         obstack_strdup.
5010         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5011         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5012         obstack_strdup.
5013         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5014
5015 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5016
5017         * unittests/help-doc-selftests.c: New file.
5018         * Makefile.in: Add the new file.
5019
5020 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5021
5022         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5023         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5024         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5025         the trailing '.' is not output, and the first character is uppercased.
5026         (print_help_for_command): Update call to print_doc_line.
5027         (print_doc_of_command): Likewise.
5028         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5029         * cli/cli-option.c (append_indented_doc): Do not append newline.
5030         (build_help_option): Append newline after first appended_indented_doc
5031         only if a second call is done.
5032         (build_help): Append 2 new lines before each option, except the first
5033         one.
5034         * compile/compile.c (_initialize_compile): Add new lines after
5035         %OPTIONS%, when not at the end of the help.
5036         Change help doc or code
5037         producing the help doc to respect the invariants.
5038         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5039         Also removed the new line after 'Options:', as all other commands
5040         do not put an empty line between 'Options:' and the first option.
5041         * printcmd.c (_initialize_printcmd): Likewise.
5042         * stack.c (_initialize_stack): Likewise.
5043         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5044         incorrectly telling COMMAND is optional.
5045         * ada-lang.c (_initialize_ada_language): Change help doc or code
5046         producing the help doc to respect the invariants.
5047         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5048         * breakpoint.c (_initialize_breakpoint): Likewise.
5049         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5050         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5051         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5052         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5053         _initialize_cli_style): Likewise.
5054         * corelow.c (core_target_info): Likewise.
5055         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5056         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5057         * filesystem.c (_initialize_filesystem): Likewise.
5058         * frame.c (_initialize_frame): Likewise.
5059         * gnu-nat.c (add_task_commands): Likewise.
5060         * infcall.c (_initialize_infcall): Likewise.
5061         * infcmd.c (_initialize_infcmd): Likewise.
5062         * interps.c (_initialize_interpreter): Likewise.
5063         * language.c (_initialize_language): Likewise.
5064         * linux-fork.c (_initialize_linux_fork): Likewise.
5065         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5066         * maint.c (_initialize_maint_cmds): Likewise.
5067         * memattr.c (_initialize_mem): Likewise.
5068         * printcmd.c (_initialize_printcmd): Likewise.
5069         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5070         _RegEx): Likewise.
5071         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5072         * record-btrace.c (_initialize_record_btrace): Likewise.
5073         * record-full.c (_initialize_record_full): Likewise.
5074         * record.c (_initialize_record): Likewise.
5075         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5076         * regcache.c (_initialize_regcache): Likewise.
5077         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5078         _initialize_remote): Likewise.
5079         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5080         * serial.c (_initialize_serial): Likewise.
5081         * skip.c (_initialize_step_skip): Likewise.
5082         * source.c (_initialize_source): Likewise.
5083         * stack.c (_initialize_stack): Likewise.
5084         * symfile.c (_initialize_symfile): Likewise.
5085         * symtab.c (_initialize_symtab): Likewise.
5086         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5087         * top.c (init_main): Likewise.
5088         * tracefile-tfile.c (tfile_target_info): Likewise.
5089         * tracepoint.c (_initialize_tracepoint): Likewise.
5090         * tui/tui-win.c (_initialize_tui_win): Likewise.
5091         * utils.c (add_internal_problem_command): Likewise.
5092         * valprint.c (value_print_option_defs): Likewise.
5093
5094 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5095
5096         PR build/24886
5097         * configure.ac: Drop enable-libmcheck support.
5098         * configure, config.in: Rebuild.
5099         * libmcheck.m4: Remove.
5100         * acinclude.m4: Don't include it.
5101         * Makefile.in: Don't distribute it.
5102         * top.c (print_gdb_configuration): Don't mention it.
5103
5104 2019-08-06  Tom Tromey  <tom@tromey.com>
5105
5106         * utils.c (set_output_style): Sometimes pass stream to
5107         emit_style_escape.
5108         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5109         * record-btrace.c (btrace_insn_history): Update.
5110         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5111         method.
5112         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5113         Update initializers.
5114         <m_uiout>: New field.
5115         <m_di>: Move lower.
5116         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5117         Remove "uiout" parameter.
5118         (dump_insns): Update.
5119         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5120         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5121
5122 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5123
5124         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5125         (error_in_psymtab_expansion): Likewise.
5126         (lookup_symbol_via_quick_fns): Likewise.
5127         (basic_lookup_transparent_type_quick): Likewise.
5128         (basic_lookup_transparent_type_1): Likewise.
5129
5130 2019-08-06  Tom Tromey  <tromey@adacore.com>
5131
5132         * source.c (last_source_error): Now bool.
5133         (print_source_lines_base): Make "noprint" bool.  Only open
5134         source file when last_source_visited changes.
5135
5136 2019-08-06  Tom Tromey  <tromey@adacore.com>
5137
5138         * annotate.c (annotate_source_line): Use g_source_cache.
5139         * source-cache.c (source_cache::get_plain_source_lines): Change
5140         parameters.  Populate m_offset_cache.
5141         (source_cache::ensure): New method.
5142         (source_cache::get_line_charpos): New method.
5143         (extract_lines): Move lower.  Change parameters.
5144         (source_cache::get_source_lines): Move lower.
5145         * source-cache.h (class source_cache): Update comment.
5146         <get_line_charpos>: New method.
5147         <get_source_lines>: Update comment.
5148         <clear>: Clear m_offset_cache.
5149         <get_plain_source_lines>: Change parameters.
5150         <ensure>: New method
5151         <m_offset_cache>: New member.
5152         * source.c (forget_cached_source_info_for_objfile): Update.
5153         (info_source_command): Use g_source_cache.
5154         (find_source_lines, open_source_file_with_line_charpos): Remove.
5155         (print_source_lines_base, search_command_helper): Use g_source_cache.
5156         * source.h (open_source_file_with_line_charpos): Don't declare.
5157         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5158         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5159         Use g_source_cache.
5160
5161 2019-08-06  Tom Tromey  <tromey@adacore.com>
5162
5163         * source-cache.c (source_cache::get_plain_source_lines):
5164         Remove "first_line" and "last_line" parameters.
5165         (source_cache::get_source_lines): Cache plain text.
5166         * source-cache.h (class source_cache)
5167         <get_plain_source_lines>: Update.
5168
5169 2019-08-06  Tom Tromey  <tromey@adacore.com>
5170
5171         * source-cache.c (extract_lines): No longer a method.
5172         Changed type of parameter.  Include final newline.
5173         (selftests::extract_lines_test): New function.
5174         (_initialize_source_cache): Likewise.
5175         * source-cache.h (class source_cache)
5176         <extract_lines>: Don't declare.
5177
5178 2019-08-06  Tom Tromey  <tromey@adacore.com>
5179
5180         * breakpoint.c (init_breakpoint_sal): Update.
5181         (breakpoint): Update.
5182         * breakpoint.h (struct breakpoint) <filter>: Now a
5183         unique_xmalloc_ptr.
5184
5185 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5186
5187         * NEWS: Mention dictionary access on blocks.
5188         * python/py-block.c (blpy_getitem): New function.
5189         (block_object_as_mapping): New struct.
5190         (block_object_type): Use new struct for tp_as_mapping field.
5191
5192 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5193
5194         * objfiles.h (objfile): Add a comment describing partial symbols.
5195
5196 2019-08-05  Tom Tromey  <tromey@adacore.com>
5197
5198         * compile/compile.c (_initialize_compile): Use _(), not N_().
5199         * thread.c (_initialize_thread): Use _(), not N_().
5200         * stack.c (_initialize_stack): Use _(), not N_().
5201         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5202
5203 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5204
5205         * dwarf2read.c (struct dw2_symtab_iterator):
5206         <want_specific_block>: Remove.
5207         <block_index>: Change type to gdb::optional.
5208         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5209         change type of BLOCK_INDEX parameter to gdb::optional.
5210         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5211         (dw2_lookup_symbol): Don't pass argument for
5212         WANT_SPECIFIC_BLOCK.
5213         (dw2_expand_symtabs_for_function): Don't pass argument for
5214         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5215         (class dw2_debug_names_iterator)
5216         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5217         parameter, change BLOCK_INDEX type to gdb::optional.
5218         <m_want_specific_block>: Remove.
5219         <m_block_index>: Change type to gdb::optional.
5220         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5221         gdb::optional.  Re-write in function of gdb::optional.
5222         (dw2_debug_names_lookup_symbol): Don't pass argument for
5223         WANT_SPECIFIC_BLOCK.
5224         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5225         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5226         BLOCK_INDEX.
5227
5228 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5229
5230         * NEWS: Mention changes to "info sources" command.
5231
5232 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * symtab.c (filename_partial_match_opts): New struct type.
5235         (struct output_source_filename_data): New members
5236         regexp, c_regexp, partial_match.
5237         (output_source_filename): Use new members to decide to print file.
5238         (info_sources_option_defs): New variable.
5239         (make_info_sources_options_def_group, print_info_sources_header,
5240         info_sources_command_completer):
5241         New functions.
5242         (info_sources_command): Read new optional arguments.
5243         (_initialize_symtab): Update info sources help.
5244
5245 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5246
5247         * ada-lang.c (exception_support_info_v0): Renamed from...
5248         (default_exception_support_info): ... this.  Create new
5249         definition for v1.
5250         (ada_has_this_exception_support): Look up catch_handlers_sym.
5251         (ada_exception_support_info_sniffer): Try v0 after default.
5252
5253 2019-08-01  Tom Tromey  <tromey@adacore.com>
5254
5255         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5256         gdbarch.h.
5257
5258 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5259
5260         * s12z-tdep.c: Fix include path for s12z-opc.h.
5261
5262 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5263
5264         * NEWS: Require GNU make 3.82.
5265
5266 2019-07-16  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5269         declare.
5270
5271 2019-07-30  Tom Tromey  <tromey@adacore.com>
5272
5273         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5274
5275 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5276
5277         * printcmd.c (print_address_symbolic): Print negative offsets.
5278         (build_address_symbolic): Force signed arithmetic when computing
5279         offset.
5280
5281 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5282
5283         PR/24474: Add a function to lookup static variables.
5284         * NEWS: Mention this new function.
5285         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5286         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5287         * python/python.c (python_GdbMethods): Add new function.
5288
5289 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5290
5291         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5292         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5293         (objfpy_lookup_static_symbol): New function.
5294         (objfile_object_methods): Add new functions.
5295
5296 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5297
5298         * NEWS: Mention 'set|show print frame-info'.  Mention new
5299         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5300         backtrace argument.  Mention that python frame filtering code
5301         is now consistent with what 'backtrace' command prints.
5302
5303 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5304
5305         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5306         comments.
5307         (print_frame_info_auto, print_frame_info_source_line,
5308         print_frame_info_location, print_frame_info_source_and_location,
5309         print_frame_info_location_and_address, print_frame_info_short_location):
5310         New declarations.
5311         (struct frame_print_options): New member print_frame_info.
5312         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5313         * stack.h (get_user_print_what_frame_info): New declaration.
5314         (frame_show_address): New declaration.
5315         * stack.c (print_frame_arguments_choices): New value 'presence'.
5316         (print_frame_info_auto, print_frame_info_source_line,
5317         print_frame_info_location, print_frame_info_source_and_location,
5318         print_frame_info_location_and_address, print_frame_info_short_location,
5319         print_frame_info_choices, print_frame_info_print_what): New definitions.
5320         (print_frame_args): Only print dots for args if print frame-arguments
5321         is 'presence'.
5322         (frame_print_option_defs): New element for "frame-info".
5323         (get_user_print_what_frame_info): New function.
5324         (frame_show_address): Make non static.  Move comment to stack.h.
5325         (print_frame_info_to_print_what): New function.
5326         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5327         to decide what to print.
5328         (backtrace_command_1): Handle the new print_frame_arguments_presence
5329         value.
5330         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5331         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5332         (py_print_frame): In non-mi mode, use LOCATION as default for
5333         print_what, similarly to frame information printed directly by
5334         backtrace command. Handle frame-info user option in non MI mode.
5335
5336 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5337
5338         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5339         Add case for debugging 32-bit target on 64-bit host.  Revise
5340         comment.
5341
5342 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5343
5344         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5345         instead of find_function_entry_range_from_pc.
5346
5347 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5348
5349         * stack.c (find_frame_funname): Remove code which preferred
5350         minsym over symtab sym in "certain pathological cases".
5351
5352         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5353         parameter.  Change type of "do_demangle" to bool.
5354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5355         Pass suitable "prefer_sym_over_minsym" flag to
5356         build_address_symbolic().  Don't output "+" for negative offsets.
5357         * printcmd.c (print_address_symbolic): Update invocation of
5358         build_address_symbolic to include a "prefer_sym_over_minsym"
5359         flag.
5360         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5361         Restrict cases in which use of minimal symbol is preferred to that
5362         of a found symbol.  Update comments.
5363
5364         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5365         for entry pc when entry pc is out of range for that FDE.
5366
5367 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5368
5369         PR gdb/24839:
5370         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5371         type.
5372
5373 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5374
5375         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5376         this function's Python signature.
5377
5378
5379 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5380
5381         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5382         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5383         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5384         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5385         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5386
5387
5388 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5389
5390         * h8300-tdep.c (h8300_register_name_common): New.
5391         h8300_register_name): Use h8300_register_name_common.
5392         (h8300s_register_name): Likewise.
5393         (h8300sx_register_name): Likewise.
5394         (h8300h_register_nam): New.
5395         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5396
5397
5398 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5399
5400         * arm-tdep.c (arm_skip_cmse_entry): New function.
5401         (arm_is_sgstubs_section): New function.
5402         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5403
5404 2019-07-22  Tom Tromey  <tom@tromey.com>
5405
5406         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5407         Don't self-assign.
5408
5409 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5412         type_print.
5413
5414 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5417         so that GDB doesn't match any msymbols when searching in the
5418         TYPES_DOMAIN.
5419         (print_symbol_info): Print using typedef_print or type_print based
5420         on the type of the symbol.  Add updated FIXME comment moved from...
5421         (_initialize_symtab): ... move and update FIXME comment to above.
5422
5423 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * NEWS: Mention adding -q option to "info types".
5426         * symtab.c (struct info_types_options): New struct.
5427         (info_types_options_defs): New variable.
5428         (make_info_types_options_def_group): New function.
5429         (info_types_command): Use gdb::option framework to parse options.
5430         (info_types_command_completer): New function.
5431         (_initialize_symtab): Extend the help text on "info types" and
5432         register command completer.
5433
5434 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5435
5436         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5437         (lookup_symbol_in_objfile): Change int to block_enum and add a
5438         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5439
5440 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5441
5442         * MAINTAINERS (Write After Approval): Add self.
5443
5444 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5447         instruction to the dummy code region.
5448
5449 2019-07-19  Tom Tromey  <tromey@adacore.com>
5450
5451         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5452         (ARGSUSED, PARAMS, __func__): Remove rules.
5453
5454 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5455
5456         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5457         * features/arm/arm-with-iwmmxt.c: Remove.
5458         * features/arm/arm-with-iwmmxt.xml: Remove.
5459         * features/arm/arm-with-m-fpa-layout.c: Remove.
5460         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5461         * features/arm/arm-with-m-vfp-d16.c: Remove.
5462         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5463         * features/arm/arm-with-m.c: Remove.
5464         * features/arm/arm-with-m.xml: Remove.
5465         * features/arm/arm-with-neon.c: Remove.
5466         * features/arm/arm-with-neon.xml: Remove.
5467         * features/arm/arm-with-vfpv2.c: Remove.
5468         * features/arm/arm-with-vfpv2.xml: Remove.
5469         * features/arm/arm-with-vfpv3.c: Remove.
5470         * features/arm/arm-with-vfpv3.xml: Remove.
5471
5472 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5473
5474         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5475
5476 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5477
5478         * arch/aarch32.c (aarch32_create_target_description): Create
5479         target descriptions using features.
5480         * arch/arm.c (arm_create_target_description)
5481         (arm_create_mprofile_target_description): Likewise.
5482         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5483
5484 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5485
5486         * Makefile.in: Add new files.
5487         * aarch32-tdep.c: New file.
5488         * aarch32-tdep.h: New file.
5489         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5490         Call aarch32_read_description.
5491         * arch/aarch32.c: New file.
5492         * arch/aarch32.h: New file.
5493         * arch/arm.c (arm_create_target_description)
5494         (arm_create_mprofile_target_description): New function.
5495         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5496         (arm_create_target_description)
5497         (arm_create_mprofile_target_description): New declaration.
5498         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5499         read_description functions.
5500         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5501         Likewise.
5502         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5503         * arm-tdep.c (tdesc_arm_list): New variable.
5504         (arm_register_g_packet_guesses): Call create description functions.
5505         (arm_read_description) (arm_read_mprofile_description): New
5506         function.
5507         * arm-tdep.h (arm_read_description)
5508         (arm_read_mprofile_description): Add declaration.
5509         * configure.tgt: Add new files.
5510
5511 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5512
5513         * top.c (new_ui_command): Open specified terminal just once.
5514
5515 2019-07-18  Tom Tromey  <tromey@adacore.com>
5516
5517         * symtab.c (main_name): Constify return type.
5518         * symfile.c (set_initial_language): Update.
5519         * symtab.h (main_name): Constify return type.
5520
5521 2019-07-17  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-winsource.c (tui_update_source_window)
5524         (tui_update_source_window_as_is)
5525         (tui_update_source_windows_with_line): Remove return.
5526         * tui/tui-disasm.c (tui_show_disassem)
5527         (tui_show_disassem_and_update_source): Remove return.
5528         * tui/tui.c (tui_reset): Remove return.
5529         * tui/tui-wingeneral.c
5530         (tui_check_and_display_highlight_if_needed): Remove return.
5531
5532 2019-07-17  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5535
5536 2019-07-17  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui-winsource.h (struct tui_exec_info_window)
5539         (struct tui_source_window_base): Move from tui-data.h.
5540         * tui/tui-winsource.c: Move many method definitions from
5541         elsewhere.  Remove "structuring" comments.
5542         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5543         (tui_source_window_base::refresh_window): Move to
5544         tui-winsource.c.
5545         * tui/tui-win.c (tui_source_window_base::refresh_all)
5546         (tui_source_window_base::update_tab_width)
5547         (tui_source_window_base::set_new_height)
5548         (tui_source_window_base::do_make_visible_with_new_height): Move to
5549         tui-winsource.c.
5550         * tui/tui-source.h: Update.
5551         * tui/tui-source.c (tui_source_window_base::reset): Move to
5552         tui-winsource.c.
5553         * tui/tui-disasm.h: Update.
5554         * tui/tui-data.h (struct tui_exec_info_window): Move to
5555         tui-winsource.h.
5556         (struct tui_source_window_base): Likewise.
5557         * tui/tui-data.c (tui_source_window_base::clear_detail)
5558         (tui_source_window_base, ~tui_source_window_base): Move to
5559         tui-winsource.c.
5560
5561 2019-07-17  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-win.c (tui_resize_all)
5564         (tui_source_window_base::update_tab_width)
5565         (tui_adjust_win_heights): Update.
5566         (tui_win_info::make_invisible_and_set_new_height): Rename from
5567         make_invisible_and_set_new_height.
5568         * tui/tui-data.h (struct tui_win_info)
5569         <make_invisible_and_set_new_height>: New method.
5570
5571 2019-07-17  Tom Tromey  <tom@tromey.com>
5572
5573         * tui/tui.c: Update.
5574         * tui/tui-source.h (struct tui_source_window): Move from
5575         tui-data.h.
5576         * tui/tui-layout.c: Update.
5577         * tui/tui-disasm.c: Update.
5578         * tui/tui-data.h (struct tui_source_window): Move to
5579         tui-source.h.
5580
5581 2019-07-17  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5584         tui-data.h.
5585         * tui/tui-data.h (struct tui_disasm_window): Move to
5586         tui-disasm.h.
5587
5588 2019-07-17  Tom Tromey  <tom@tromey.com>
5589
5590         * tui/tui-regs.h (struct tui_data_item_window): Move from
5591         tui-data.h.
5592         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5593         * tui/tui-data.h (struct tui_data_item_window): Move to
5594         tui-regs.h.
5595         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5596
5597 2019-07-17  Tom Tromey  <tom@tromey.com>
5598
5599         * tui/tui.c: Update.
5600         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5601         (tui_cmd_window::max_height): Move to tui-command.c.
5602         * tui/tui-layout.c: Update.
5603         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5604         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5605         tui-command.c.
5606         * tui/tui-command.h (struct tui_cmd_window): Move from
5607         tui-data.h.
5608         * tui/tui-command.c: Remove "structuring" comments.
5609         (tui_cmd_window::clear_detail)
5610         (tui_cmd_window::do_make_visible_with_new_height)
5611         (tui_cmd_window::max_height): Move from elsewhere.
5612
5613 2019-07-17  Tom Tromey  <tom@tromey.com>
5614
5615         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5616         Now static.
5617         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5618         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5619
5620 2019-07-17  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui.c: Update.
5623         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5624         tui-regs.c.
5625         * tui/tui-windata.h: Remove file.
5626         * tui/tui-windata.c: Remove file.
5627         * tui/tui-win.c (tui_data_window::set_new_height)
5628         (tui_data_window::do_make_visible_with_new_height): Move to
5629         tui-regs.c.
5630         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5631         * tui/tui-regs.c: Remove "structuring" comments.
5632         (tui_data_window::first_data_item_displayed)
5633         (tui_data_window::delete_data_content_windows)
5634         (tui_data_window::erase_data_content)
5635         (tui_data_window::display_all_data)
5636         (tui_data_window::refresh_all)
5637         (tui_data_window::do_scroll_vertical)
5638         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5639         (tui_data_window::do_make_visible_with_new_height)
5640         (tui_data_window::refresh_window): Move from elsewhere.
5641         (_initialize_tui_regs): Move to end of file.
5642         * tui/tui-layout.c: Update.
5643         * tui/tui-hooks.c: Update.
5644         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5645         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5646         tui-regs.c.
5647         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5648
5649 2019-07-17  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5652         seen.
5653
5654 2019-07-17  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-win.c (tui_source_window_base::set_new_height)
5657         (tui_source_window_base::do_make_visible_with_new_height): Use
5658         m_has_locator field directly.
5659         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5660         method.
5661         (struct tui_source_window_base) <has_locator>: Likewise.
5662
5663 2019-07-17  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5666         Don't declare.
5667         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5668         Remove.
5669         * tui/tui-win.c (tui_source_window_base::set_new_height)
5670         (tui_source_window_base::set_new_height)
5671         (make_invisible_and_set_new_height)
5672         (tui_source_window_base::do_make_visible_with_new_height)
5673         (tui_source_window_base::do_make_visible_with_new_height):
5674         Update.
5675         * tui/tui-layout.c (show_source_disasm_command, show_data)
5676         (show_source_or_disasm_and_command): Update.
5677         * tui/tui-layout.c (show_layout): Update.
5678
5679 2019-07-17  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-layout.c (make_data_window): Remove.
5682         (show_data): Unify creation and re-initialization cases.
5683
5684 2019-07-17  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-layout.c (make_source_window, make_disasm_window):
5687         Remove.
5688         (show_data): Unify creation and re-initialization cases.
5689
5690 2019-07-17  Tom Tromey  <tom@tromey.com>
5691
5692         * tui/tui-layout.c (make_command_window): Remove.
5693         (show_source_disasm_command, show_source_or_disasm_and_command):
5694         Unify creation and re-initialization cases.
5695
5696 2019-07-17  Tom Tromey  <tom@tromey.com>
5697
5698         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5699         creation and re-initialization cases.
5700
5701 2019-07-17  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-regs.c (tui_get_register): Return void.
5704
5705 2019-07-17  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5708         Simplify.
5709
5710 2019-07-17  Tom Tromey  <tom@tromey.com>
5711
5712         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5713         resetting.
5714
5715 2019-07-17  Tom Tromey  <tom@tromey.com>
5716
5717         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5718         * tui/tui-regs.c (tui_reg_layout): New function.
5719         (tui_show_registers, tui_reg_command): Use it.
5720         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5721         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5722         parameters.
5723         (tui_layout_command): Remove.
5724
5725 2019-07-17  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-layout.h (tui/tui-layout): Return void.
5728         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5729
5730 2019-07-17  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-layout.c (show_source_disasm_command, show_data):
5733         Update.
5734         (reset_locator): Remove.
5735         (show_source_or_disasm_and_command): Update.
5736
5737 2019-07-17  Tom Tromey  <tom@tromey.com>
5738
5739         * tui/tui-source.c (tui_source_window_base::reset): Remove
5740         win_type parameter.
5741         * tui/tui-layout.c (make_command_window, make_source_window)
5742         (make_disasm_window, make_data_window)
5743         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5744         (reset_locator, show_source_or_disasm_and_command): Update.
5745         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5746         win_type parameter.
5747         (struct tui_source_window_base) <reset>: Likewise.
5748
5749 2019-07-17  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-layout.c (show_source_disasm_command): Use
5752         reset_locator.
5753         (reset_locator): New function.
5754         (init_and_make_win): Remove.
5755         (show_source_or_disasm_and_command): Use reset_locator.
5756
5757 2019-07-17  Tom Tromey  <tom@tromey.com>
5758
5759         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5760         condition.
5761         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5762         Remove condition.
5763         * tui/tui-source.c (tui_source_window_base::reset): New method.
5764         * tui/tui-layout.c (make_command_window): Don't call
5765         init_and_make_win.
5766         (make_source_window, make_disasm_window): Don't call
5767         make_source_or_disasm_window.
5768         (make_data_window): Don't call init_and_make_win.  Change calling
5769         convention.
5770         (show_source_disasm_command, show_data): Simplify.
5771         (make_source_or_disasm_window): Remove.
5772         (show_source_or_disasm_and_command): Simplify.
5773         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5774         (struct tui_source_window_base) <reset>: Likewise.
5775         <execution_info>: Remove initializer.
5776         * tui/tui-data.c (tui_source_window_base): Initialize
5777         execution_info.
5778
5779 2019-07-17  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5782         variable.
5783
5784 2019-07-17  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui.c (tui_rl_other_window): Update.
5787         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5788         superclass method first.  Always iterate over regs_content.
5789         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5790         method.
5791         * tui/tui-win.c (tui_set_focus_command): Update.
5792
5793 2019-07-17  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-win.c (tui_set_focus_command): Rename from
5796         tui_set_focus.  Call tui_enable.
5797         (tui_set_focus_command): Remove.
5798
5799 2019-07-17  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5802         refresh_window.
5803         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5804         touchwin.
5805         (tui_data_window::refresh_window): Call refresh_window on data
5806         items.  Always call superclass refresh_window.
5807         (tui_win_info::refresh): Remove.
5808         (tui_source_window_base::refresh_window): Update.
5809         (tui_refresh_all): Update.
5810         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5811         refresh_window.
5812         (show_source_or_disasm_and_command): Likewise.
5813         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5814         (struct tui_source_window_base) <refresh>: Likewise.
5815
5816 2019-07-17  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-winsource.c (tui_clear_source_content)
5819         (tui_show_source_content): Update.
5820         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5821         whether content is empty.
5822         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5823         Remove.
5824
5825 2019-07-17  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5828         window's contents.
5829         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5830         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5831
5832 2019-07-17  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5835         (struct tui_data_item_window): Update.
5836
5837 2019-07-17  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5840         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5841         defines.
5842
5843 2019-07-17  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-winsource.h (tui_erase_source_content)
5846         (tui_clear_source_content): Remove "display_prompt" parameter.
5847         * tui/tui-winsource.c (tui_update_source_window_as_is)
5848         (tui_update_source_windows_with_addr): Update.
5849         (tui_clear_source_content): Remove "display_prompt" parameter.
5850         (tui_erase_source_content): Likewise.  Simplify.
5851         (tui_show_source_content): Update.
5852         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5853         * tui/tui-stack.c (tui_show_frame_info): Update.
5854         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5855         Remove defines.
5856
5857 2019-07-17  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5860         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5861         parameter.
5862         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5863         parameter.
5864
5865 2019-07-17  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-winsource.c (tui_clear_source_content)
5868         (tui_show_source_content, tui_show_exec_info_content)
5869         (tui_clear_exec_info_content): Update.
5870         * tui/tui-stack.c (tui_show_locator_content): Update.
5871         (tui_show_frame_info): Update.
5872         * tui/tui-source.h (tui_source_window): Don't declare.
5873         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5874         from tui_source_is_displayed.
5875         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5876         Remove field.
5877         (struct tui_source_window_base) <content_in_use>: New field.  Now
5878         bool.
5879         (struct tui_source_window) <showing_source_p>: New method.
5880         (TUI_SRC_WIN): Change cast.
5881         * tui/tui-data.c (tui_initialize_static_data): Update.
5882
5883 2019-07-17  Tom Tromey  <tom@tromey.com>
5884
5885         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5886         location_matches_p.
5887         * tui/tui-source.c (tui_source_window::location_matches_p): New
5888         method.
5889         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5890         method.
5891         * tui/tui-data.h (struct tui_source_window_base)
5892         <location_matches_p>: New method.
5893         (struct tui_source_window, struct tui_disasm_window)
5894         <location_matches_p>: Likewise.
5895
5896 2019-07-17  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-win.c (tui_set_win_height_command): Rename from
5899         tui_set_win_height.
5900         (tui_set_win_height_command): Remove.
5901
5902 2019-07-17  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-source.c (tui_source_window): New constructor.  Add
5905         observer.
5906         (~tui_source_window): New destructor.
5907         (tui_source_window::style_changed): New method.
5908         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5909         (tui_attach_detach_observers): Update.
5910         * tui/tui-data.h (struct tui_source_window): Make constructor not
5911         inline.  Add destructor.
5912         (struct tui_source_window) <style_changed>: New method.
5913         <m_observable>: New member.
5914
5915 2019-07-17  Tom Tromey  <tom@tromey.com>
5916
5917         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5918         * tui/tui-win.c (tui_resize_all): Fix typo.
5919
5920 2019-07-17  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5923         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5924         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5925         * tui/tui-win.c (window_name_completer): Use foreach.
5926         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5927         (update_tab_width): Likewise.
5928         * tui/tui-layout.c (show_layout): Update.
5929         * tui/tui-data.h (class tui_window_iterator): New.
5930         (struct all_tui_windows): New.
5931         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5932
5933 2019-07-17  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5936         parameter.  Don't reference globals.
5937         (tui_reg_command): Update.
5938
5939 2019-07-17  Tom Tromey  <tom@tromey.com>
5940
5941         * tui/tui-regs.c (tui_show_registers): Simplify.
5942
5943 2019-07-17  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-regs.c (tui_show_registers): Update.
5946         (tui_show_register_group): Add win_info parameter.
5947
5948 2019-07-17  Tom Tromey  <tom@tromey.com>
5949
5950         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5951         Rename from tui_display_reg_element_at_line.
5952         (tui_data_window::display_registers_from_line): Update.
5953         * tui/tui-data.h (struct tui_data_window)
5954         <display_reg_element_at_line>: New method.
5955
5956 2019-07-17  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-regs.h (tui_display_registers_from)
5959         (tui_display_registers_from_line): Don't declare.
5960         * tui/tui-windata.c (tui_data_window::display_all_data)
5961         (tui_data_window::refresh_all)
5962         (tui_data_window::do_scroll_vertical): Update.
5963         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5964         from tui_display_registers_from.
5965         (tui_display_reg_element_at_line): Update.
5966         (tui_data_window::display_registers_from_line): Rename from
5967         tui_display_registers_from_line.
5968         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5969         display_registers_from_line>: New methods.
5970
5971 2019-07-17  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5974         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5975         from tui_erase_data_content.
5976         (tui_data_window::display_all_data)
5977         (tui_data_window::refresh_all)
5978         (tui_data_window::do_scroll_vertical): Update.
5979         * tui/tui-regs.c (tui_show_registers): Update.
5980         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5981         New method.
5982
5983 2019-07-17  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5986         declare.
5987         * tui/tui-windata.c
5988         (tui_data_window::delete_data_content_windows): Rename from
5989         tui_delete_data_content_windows.
5990         (tui_data_window::display_all_data)
5991         (tui_data_window::do_scroll_vertical): Update.
5992         * tui/tui-data.h (struct tui_data_window)
5993         <delete_data_content_windows>: New method.
5994
5995 2019-07-17  Tom Tromey  <tom@tromey.com>
5996
5997         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5998         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5999
6000 2019-07-17  Tom Tromey  <tom@tromey.com>
6001
6002         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6003         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6004         from tui_display_all_data.
6005         * tui/tui-win.c
6006         (tui_data_window::do_make_visible_with_new_height): Update.
6007         * tui/tui-regs.c (tui_show_registers): Update.
6008         * tui/tui-layout.c (tui_set_layout): Update.
6009         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6010         method.
6011
6012 2019-07-17  Tom Tromey  <tom@tromey.com>
6013
6014         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6015         * tui/tui-windata.c (tui_display_data_from): Remove.
6016         (tui_data_window::refresh_all): Update.
6017
6018 2019-07-17  Tom Tromey  <tom@tromey.com>
6019
6020         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6021         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6022         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6023         tui_display_registers_from_line.
6024         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6025         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6026         "force_display" parameter.
6027
6028 2019-07-17  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6031         declare.
6032         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6033         Rename from tui_first_reg_element_no_inline.
6034         (tui_display_reg_element_at_line)
6035         (tui_display_registers_from_line): Update.
6036         * tui/tui-data.h (struct tui_data_window)
6037         <first_reg_element_no_inline>: New method.
6038
6039 2019-07-17  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-windata.c (tui_display_data_from)
6042         (tui_data_window::do_scroll_vertical): Update.
6043         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6044         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6045         Rename from tui_line_from_reg_element_no.
6046         (tui_display_registers_from_line): Update.
6047         * tui/tui-data.h (struct tui_data_window)
6048         <line_from_reg_element_no>: New method.
6049
6050 2019-07-17  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6053         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6054         tui_last_regs_line_no.
6055         (tui_display_reg_element_at_line)
6056         (tui_display_registers_from_line): Update.
6057         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6058         method.
6059
6060 2019-07-17  Tom Tromey  <tom@tromey.com>
6061
6062         PR tui/24722:
6063         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6064         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6065         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6066         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6067         (tui_update_breakpoint_info): Likewise.
6068         * tui/tui-hooks.c (tui_event_create_breakpoint)
6069         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6070         Update.
6071
6072 2019-07-17  Tom Tromey  <tom@tromey.com>
6073
6074         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6075
6076 2019-07-17  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-winsource.c (tui_update_source_window_as_is)
6079         (tui_update_source_windows_with_addr): Update.
6080         * tui/tui-source.h (tui_set_source_content)
6081         (tui_show_symtab_source): Add "win_info" parameter.
6082         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6083         parameter.
6084         (tui_show_symtab_source): Likewise.
6085
6086 2019-07-17  Tom Tromey  <tom@tromey.com>
6087
6088         * tui/tui-wingeneral.c
6089         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6090
6091 2019-07-17  Tom Tromey  <tom@tromey.com>
6092
6093         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6094         (struct tui_cmd_window) <can_scroll>: New method.
6095         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6096         method.
6097
6098 2019-07-17  Tom Tromey  <tromey@adacore.com>
6099
6100         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6101         do_field_signed>: Rename.  Change type of "value".
6102         * ui-out.c (ui_out::field_signed): Rename from field_int.
6103         Change type of "value".
6104         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6105         type of "value".
6106         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6107         do_field_int.  Change type of "value".
6108         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6109         do_field_int.  Change type of "value".
6110         * tracepoint.c (trace_status_mi, tfind_1)
6111         (print_one_static_tracepoint_marker): Update.
6112         * thread.c (print_thread_info_1, print_selected_thread_frame):
6113         Update.
6114         * stack.c (print_frame, print_frame_info): Update.
6115         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6116         Update.
6117         * source.c (print_source_lines_base): Update.
6118         * skip.c (info_skip_command): Update.
6119         * record-btrace.c (btrace_ui_out_decode_error)
6120         (btrace_call_history_src_line): Update.
6121         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6122         Update.
6123         * progspace.c (print_program_space): Update.
6124         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6125         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6126         do_field_int.  Change type of "value".
6127         * mi/mi-out.c (mi_ui_out::do_table_begin)
6128         (mi_ui_out::do_table_header): Update.
6129         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6130         type of "value".
6131         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6132         (mi_cmd_data_list_changed_registers, output_register)
6133         (mi_cmd_data_read_memory, mi_load_progress)
6134         (mi_cmd_trace_frame_collected): Update.
6135         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6136         Update.
6137         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6138         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6139         (mi_cmd_var_list_children, varobj_update_one): Update.
6140         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6141         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6142         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6143         * inferior.c (print_inferior): Update.
6144         * gdb_bfd.c (print_one_bfd): Update.
6145         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6146         Update.
6147         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6148         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6149         do_field_int.  Change type of "value".
6150         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6151         do_field_int.  Change type of "value".
6152         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6153         (print_one_breakpoint_location, print_it_catch_fork)
6154         (print_one_catch_fork, print_it_catch_vfork)
6155         (print_one_catch_vfork, print_it_catch_solib)
6156         (print_it_catch_exec, print_it_ranged_breakpoint)
6157         (print_mention_watchpoint, print_mention_masked_watchpoint)
6158         (bkpt_print_it, update_static_tracepoint): Update.
6159         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6160         * break-catch-syscall.c (print_it_catch_syscall): Update.
6161         * ada-tasks.c (print_ada_task_info): Update.
6162         * ada-lang.c (print_it_exception, print_mention_exception):
6163         Update.
6164
6165 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         PR breakpoints/24541
6168         * gdbarch.c: Regenerate.
6169         * gdbarch.h: Regenerate.
6170         * gdbarch.sh: Adjust return type and parameter types for
6171         'stap_adjust_register'.
6172         (i386_stap_adjust_register): Adjust signature and return new
6173         register name.
6174         * stap-probe.c (stap_parse_register_operand): Adjust use of
6175         'gdbarch_stap_adjust_register'.
6176
6177 2019-07-17  Tom Tromey  <tromey@adacore.com>
6178
6179         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6180         declare VEC.
6181         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6182         std::vector.
6183         (struct s390_process_info): Add initializers.
6184         (s390_add_process): Use new.
6185         (s390_linux_nat_target::low_forget_process): Use delete.
6186         (s390_linux_nat_target::low_new_fork)
6187         (s390_linux_nat_target::stopped_by_watchpoint)
6188         (s390_linux_nat_target::low_prepare_to_resume)
6189         (s390_linux_nat_target::insert_watchpoint)
6190         (s390_linux_nat_target::insert_hw_breakpoint)
6191         (s390_linux_nat_target::remove_watchpoint)
6192         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6193
6194 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6195
6196         * aarch64-fbsd-nat.c: Include regcache.h.
6197         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6198         argument.
6199         (aarch64_fbsd_nat_target::fetch_registers)
6200         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6201         variable.
6202         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6203
6204 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6205
6206         * fbsd-nat.c: Include gdbarch.h.
6207
6208 2019-07-15  Tom Tromey  <tromey@adacore.com>
6209
6210         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6211
6212 2019-07-15  Tom Tromey  <tromey@adacore.com>
6213
6214         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6215         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6216         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6217         * cli-out.c (cli_ui_out::do_field_int): New method.
6218         * ui-out.c (ui_out::field_unsigned): New method.
6219         * symfile.c (generic_load): Use field_unsigned.
6220         (print_transfer_performance): Likewise.
6221         * record-btrace.c (ui_out_field_uint): Remove.
6222         (btrace_call_history_insn_range, btrace_call_history): Use
6223         field_unsigned.
6224         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6225         field_unsigned.
6226         * ui-out.h (class ui_out) <field_unsigned>: New method.
6227         <do_field_unsigned>: Likewise.
6228
6229 2019-07-15  Tom Tromey  <tromey@adacore.com>
6230
6231         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6232         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6233         * target.c (flash_erase_command): Use field_string.
6234         * infrun.c (print_signal_received_reason): Use field_string.
6235         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6236         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6237         field_string.
6238         * ada-tasks.c (print_ada_task_info): Use field_string.
6239
6240 2019-07-15  Tom Tromey  <tromey@adacore.com>
6241
6242         * target.c (flash_erase_command): Use field_core_addr.
6243         * symfile.c (generic_load): Use field_core_addr.
6244         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6245         Use field_core_addr.
6246         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6247         field_core_addr.
6248
6249 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6252         value if its desired type is smaller than a CORE_ADDR and signed.
6253
6254 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6255
6256         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6257         of changes to field names, and use new is_reference field to
6258         decide if a property is a reference or not.
6259         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6260         field.
6261         (struct dwarf2_property_baton): Update header comment, rename
6262         'referenced_type' to 'property_type' and update comments.
6263         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6264         default property type, store in property baton, update to take
6265         accound of renamed field.
6266         (read_func_scope): Update call to attr_to_dynamic_prop.
6267         (read_array_type): Likewise.
6268         (dwarf2_per_cu_addr_sized_int_type): New function.
6269         (read_subrange_index_type): Move type finding code to
6270         dwarf2_per_cu_addr_sized_int_type.
6271         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6272         (dwarf2_per_cu_addr_type): New function.
6273         (set_die_type): Update calls to attr_to_dynamic_prop.
6274
6275 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * dwarf2read.c (read_subrange_index_type): New function.
6278         (read_subrange_type): Move code into new function and call it.
6279         * gdbtypes.c (create_range_type): Add some asserts.
6280
6281 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6282
6283         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6284         update return statements.
6285         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6286         declaration, and update comment to match.
6287         * gdbtypes.c (resolve_dynamic_array): Update call to
6288         dwarf2_evaluate_property to match new return type.
6289
6290 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * valarith.c (value_subscripted_rvalue): Change lowerbound
6293         parameter type from int to LONGEST.
6294         * value.h (value_subscripted_rvalue): Likewise in declaration.
6295
6296 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * cli/cli-utils.c (info_print_command_completer): New function.
6299         * cli/cli-utils.h: Add 'completer.h' include, and forward
6300         declaration for 'struct cmd_list_element'.
6301         (info_print_command_completer): Declare.
6302         * stack.c (_initialize_stack): Add completer for 'info locals' and
6303         'info args'.
6304         * symtab.c (_initialize_symtab): Add completer for 'info
6305         variables' and 'info functions'.
6306         * NEWS: Mention completion for additional info commands.
6307
6308 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6309
6310         * cli/cli-utils.c (extract_info_print_args): Delete.
6311         (extract_arg_maybe_quoted): Delete.
6312         (info_print_options_defs): New variable.
6313         (make_info_print_options_def_group): New function.
6314         (extract_info_print_options): Define new function.
6315         * cli/cli-utils.h (extract_info_print_args): Delete.
6316         (struct info_print_options): New structure.
6317         (extract_info_print_options): Declare new function.
6318         * stack.c (info_locals_command): Update to use new
6319         extract_info_print_options, also add a header comment.
6320         (info_args_command): Likewise.
6321         * symtab.c (info_variables_command): Likewise.
6322         (info_functions_command): Likewise.
6323
6324 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6327         to extract string arguments.
6328         * common/common-utils.c (extract_string_maybe_quoted): New function.
6329         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6330
6331 2019-07-11  Tom Tromey  <tromey@adacore.com>
6332
6333         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6334         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6335         * top.h (gdbinit): Don't declare.
6336         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6337         into...
6338         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6339         * top.c (gdb_init): Don't call init_cli_cmds.
6340         (gdbinit): Remove.
6341         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6342
6343 2019-07-11  Tom Tromey  <tromey@adacore.com>
6344
6345         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6346         after it has been moved.
6347
6348 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6349
6350         * valops.c (value_must_coerce_to_target): Change return type to
6351         bool.
6352         * value.h (value_must_coerce_to_target): Likewise.
6353
6354 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6355
6356         * breakpoint.c (is_hardware_watchpoint): Remove
6357         forward-declaration.
6358         (is_masked_watchpoint): Change return type to bool.
6359         (is_tracepoint): Likewise.
6360         (is_breakpoint): Likewise.
6361         (is_hardware_watchpoint): Likewise.
6362         (is_watchpoint): Likewise.
6363         (is_no_memory_software_watchpoint): Likewise.
6364         (is_catchpoint): Likewise.
6365         (breakpoint_1): Make FILTER parameter's return type bool.
6366         is_masked_watchpoint): Change return type to bool.
6367         (save_breakpoints): Make FILTER parameter's return type bool.
6368         * breakpoint.h (is_breakpoint): Change return type to bool.
6369         (is_watchpoint): Likewise.
6370         (is_catchpoint): Likewise.
6371         (is_tracepoint): Likewise.
6372
6373 2019-07-10  Tom Tromey  <tom@tromey.com>
6374
6375         * defs.h: Don't include gdbarch.h.
6376         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6377         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6378         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6379         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6380         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6381         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6382         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6383         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6384         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6385         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6386         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6387         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6388         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6389         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6390         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6391         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6392         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6393         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6394         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6395         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6396         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6397         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6398         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6399         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6400         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6401         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6402         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6403
6404 2019-07-10  Tom Tromey  <tromey@adacore.com>
6405
6406         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6407         * breakpoint.c (init_ada_exception_breakpoint): Register as
6408         bp_catchpoint.
6409         (print_one_breakpoint_location, print_one_breakpoint): Use
6410         is_ada_exception_catchpoint.
6411         * ada-lang.c (class ada_catchpoint_location): Pass
6412         bp_loc_software_breakpoint to bp_location constructor.
6413         (is_ada_exception_catchpoint): New function.
6414
6415 2019-07-10  Tom Tromey  <tromey@adacore.com>
6416
6417         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6418         VEC.
6419         (struct arm_exidx_entry): New method operator<.
6420         (struct arm_exidx_data) <section_maps>: Change type.
6421         (arm_exidx_data_free): Remove.
6422         (arm_exidx_data_key): Change type.  Move lower.
6423         (arm_exidx_new_objfile): Update.
6424         (arm_compare_exidx_entries): Remove.
6425         (arm_find_exidx_entry, _initialize_arm_tdep)
6426
6427 2019-07-10  Tom Tromey  <tromey@adacore.com>
6428
6429         * solib-spu.c (ocl_program_data_key): Change type.
6430         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6431         Update.
6432
6433 2019-07-10  Tom Tromey  <tromey@adacore.com>
6434
6435         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6436         (struct solib_aix_inferior_data) <library_list>: Change type.
6437         (solib_aix_inferior_data_handle): Change type.
6438         (get_solib_aix_inferior_data): Update.
6439         (solib_aix_free_library_list): Remove.
6440         (library_list_start_library): Update.
6441         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6442         return type.
6443         (solib_aix_get_library_list)
6444         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6445         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6446
6447 2019-07-10  Tom Tromey  <tromey@adacore.com>
6448
6449         * solib-dsbt.c (struct dsbt_info): Add initializers.
6450         (solib_dsbt_pspace_data): Change type.
6451         (dsbt_pspace_data_cleanup): Remove.
6452         (get_dsbt_info, _initialize_dsbt_solib): Update.
6453
6454 2019-07-10  Tom Tromey  <tromey@adacore.com>
6455
6456         * spu-tdep.c (spu_overlay_data): Change type.
6457         (spu_get_overlay_table, spu_overlay_new_objfile)
6458         (_initialize_spu_tdep): Update.
6459
6460 2019-07-10  Tom Tromey  <tromey@adacore.com>
6461
6462         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6463         destructor.
6464         (dbx_objfile_data_key): Change type and declare later.
6465         (DBX_SYMFILE_INFO): Rewrite.
6466         * dbxread.c (dbx_objfile_data_key): Change type.
6467         (dbx_symfile_init): Update.
6468         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6469         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6470         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6471
6472 2019-07-10  Tom Tromey  <tromey@adacore.com>
6473
6474         * jit.c (jit_program_space_key): Change type.  Move lower.
6475         (get_jit_program_space_data): Update.
6476         (jit_program_space_data_cleanup): Remove.
6477         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6478         Update.
6479         (struct jit_program_space_data): Add initializers.
6480
6481 2019-07-10  Tom Tromey  <tromey@adacore.com>
6482
6483         * solib-darwin.c (struct darwin_info): Add initializers.
6484         (solib_darwin_pspace_data): Change type.
6485         (darwin_pspace_data_cleanup): Remove.
6486         (get_darwin_info, _initialize_darwin_solib): Update.
6487
6488 2019-07-10  Tom Tromey  <tromey@adacore.com>
6489
6490         * remote-sim.c (struct sim_inferior_data): Add initializers,
6491         constructor, and destructor.
6492         (sim_inferior_data_key): Change type.  Move lower.
6493         (check_for_duplicate_sim_descriptor): Update.
6494         (get_sim_inferior_data): Use new.  Update.
6495         (~sim_inferior_data_cleanup): Rename from
6496         sim_inferior_data_cleanup.  Simplify.
6497         (gdbsim_close_inferior, simulator_command)
6498         (sim_command_completer, _initialize_remote_sim): Update.
6499         (next_pid, INITIAL_PID): Move earlier.
6500
6501 2019-07-10  Tom Tromey  <tromey@adacore.com>
6502
6503         * python/python-internal.h (create_thread_object): Return
6504         gdbpy_ref.
6505         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6506         * python/py-inferior.c (struct threadlist_entry): Add
6507         constructor.
6508         <thread_obj>: Now a gdbpy_ref.
6509         (thread_to_thread_object): Update.
6510         (add_thread_object): Use new.
6511         (delete_thread_object): Use delete.
6512         (infpy_threads): Update.
6513         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6514         GIL.
6515
6516 2019-07-10  Tom Tromey  <tromey@adacore.com>
6517
6518         * valops.c (value_cast): Specialize error message for Ada.
6519
6520 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6521
6522         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6523
6524 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6525
6526         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6527         bpstat_should_step): Return bool, adjust comments.
6528         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6529         bpstat_should_step): Likewise.
6530
6531 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6532
6533         * features/Makefile: Use feature target descriptions for Arm.
6534         * features/arm/arm-core.c: Generate new file.
6535         * features/arm/arm-fpa.c: Likewise.
6536         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6537         * features/arm/arm-m-profile.c: Likewise.
6538         * features/arm/arm-vfpv2.c: Likewise.
6539         * features/arm/arm-vfpv3.c: Likewise.
6540         * features/arm/xscale-iwmmxt.c: Likewise.
6541         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6542
6543 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6544
6545         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6546         ptrace earlier.
6547
6548 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6549
6550         * features/aarch64-pauth.c: Regenerate.
6551
6552 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6553
6554         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6555         bool.
6556         (bpstat_what): Use false instead of 0.
6557
6558 2019-07-09  Pedro Alves  <palves@redhat.com>
6559
6560         * break-catch-throw.c (is_exception_catchpoint): New.
6561         * breakpoint.c (print_one_breakpoint_location): New parameter
6562         'raw_loc'.  Handle it.  Use
6563         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6564         looking at the breakpoint's type.
6565         (print_one_breakpoint): If handling "maint info breakpoints", also
6566         print locations of exception catchpoints.
6567         * breakpoint.h (is_exception_catchpoint): Declare.
6568
6569 2019-07-09  Pedro Alves  <palves@redhat.com>
6570
6571         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6572         "addr" field.
6573         (allocate_location_exception_catchpoint): New.
6574         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6575         (initialize_throw_catchpoint_ops): Install
6576         allocate_location_exception_catchpoint as allocate_location
6577         method.
6578         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6579         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6580         bp_loc_other.
6581         (breakpoint_address_is_meaningful): Delete.
6582         (bl_address_is_meaningful): New.
6583         (breakpoint_locations_match): Adjust comment.
6584         (bp_location_from_bp_type): New, factored out of...
6585         (bp_location::bp_location(breakpoint *)): ... this.
6586         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6587         factored out of...
6588         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6589         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6590         breakpoint_address_is_meaningful.
6591         (bp_locations_compare): Adjust comment.
6592         (update_global_location_list): Use bl_address_is_meaningful
6593         instead of breakpoint_address_is_meaningful.
6594         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6595         explicit.
6596         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6597         * python/py-breakpoint.c (bppy_get_location): No longer check
6598         whether location is null.
6599
6600 2019-07-09  Pedro Alves  <palves@redhat.com>
6601
6602         PR c++/15468
6603         * breakpoint.c (print_one_breakpoint_location): Remove
6604         single-location assert.
6605
6606 2019-07-09  Tom Tromey  <tom@tromey.com>
6607
6608         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6609         * configure: Rebuild.
6610         * configure.ac: Change common to gdbsupport.
6611         * gdbsupport: Rename from common.
6612         * acinclude.m4: Change common to gdbsupport.
6613         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6614         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6615         gdbsupport.
6616         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6617         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6618         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6619         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6620         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6621         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6622         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6623         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6624         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6625         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6626         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6627         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6628         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6629         coff-pe-read.c, command.h, compile/compile-c-support.c,
6630         compile/compile-c.h, compile/compile-cplus-symbols.c,
6631         compile/compile-cplus-types.c, compile/compile-cplus.h,
6632         compile/compile-loc2c.c, compile/compile.c, completer.c,
6633         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6634         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6635         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6636         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6637         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6638         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6639         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6640         features/aarch64-core.c, features/aarch64-fpu.c,
6641         features/aarch64-pauth.c, features/aarch64-sve.c,
6642         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6643         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6644         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6645         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6646         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6647         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6648         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6649         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6650         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6651         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6652         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6653         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6654         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6655         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6656         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6657         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6658         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6659         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6660         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6661         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6662         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6663         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6664         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6665         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6666         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6667         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6668         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6669         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6670         minsyms.c, mips-linux-tdep.c, namespace.h,
6671         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6672         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6673         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6674         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6675         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6676         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6677         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6678         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6679         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6680         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6681         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6682         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6683         procfs.c, producer.c, progspace.h, psymtab.h,
6684         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6685         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6686         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6687         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6688         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6689         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6690         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6691         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6692         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6693         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6694         target-memory.c, target.c, target.h, target/waitstatus.c,
6695         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6696         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6697         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6698         unittests/array-view-selftests.c,
6699         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6700         unittests/common-utils-selftests.c,
6701         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6702         unittests/format_pieces-selftests.c,
6703         unittests/function-view-selftests.c,
6704         unittests/lookup_name_info-selftests.c,
6705         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6706         unittests/mkdir-recursive-selftests.c,
6707         unittests/observable-selftests.c,
6708         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6709         unittests/parse-connection-spec-selftests.c,
6710         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6711         unittests/scoped_fd-selftests.c,
6712         unittests/scoped_mmap-selftests.c,
6713         unittests/scoped_restore-selftests.c,
6714         unittests/string_view-selftests.c, unittests/style-selftests.c,
6715         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6716         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6717         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6718         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6719         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6720         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6721
6722 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6725         bool value.
6726         (decode_digits_ordinary): Set explicit_line field in sal.
6727         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6728         symtab_and_line that was set on an explicit line number in
6729         assembler code.  Do always update the recorded symtab and line if
6730         we do skip the prologue.
6731
6732 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6733
6734         * breakpoint.c (set_breakpoint_location_function): Remove
6735         explicit_loc parameter.
6736         (momentary_breakpoint_from_master): Update call to
6737         set_breakpoint_location_function.
6738         (add_location_to_breakpoint): Likewise.
6739
6740 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6743         required features based on default bfd type when no specific bfd
6744         is present.
6745
6746 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6747
6748         * NEWS: Mention that GDB printf and eval commands can now print
6749         C-style and Ada-style convenience var strings without
6750         calling the inferior.
6751         * printcmd.c (printf_c_string): Locally print GDB internal var
6752         instead of transiting via the inferior.
6753         (printf_wide_c_string): Likewise.
6754
6755 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6756
6757         PR breakpoints/25011
6758         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6759
6760 2019-07-04  Tom Tromey  <tom@tromey.com>
6761
6762         PR tui/24724:
6763         * tui/tui-winsource.c (tui_clear_source_content): Update.
6764         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6765         (tui_update_breakpoint_info): Update.
6766         (tui_set_exec_info_content): Update.
6767         * tui/tui-source.c (tui_set_source_content_nil): Update.
6768         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6769         has_break.
6770         * tui/tui-data.h (enum tui_bp_flag): New.
6771         (tui_bp_flags): New enum flags type.
6772         (struct tui_source_element) <break_mode>: Change type.  Rename
6773         from has_break.
6774         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6775         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6776         constants.
6777         * tui/tui-winsource.h: Fix comment.
6778
6779 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6780
6781         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6782         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6783         (store_fpregs_to_thread)
6784         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6785         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6786         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6787         (IWMMXT_REGS_SIZE): Add define.
6788         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6789         (fetch_vfp_regs, store_vfp_regs)
6790         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6791         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6792
6793 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6794
6795         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6796         defines.
6797         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6798         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6799         (ARM_INT_REGISTER_SIZE): ...to this.
6800         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6801         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6802         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6803         (arm_linux_collect_gregset, supply_nwfpe_register)
6804         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6805         defines.
6806         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6807         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6808         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6809         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6810         (arm_return_in_memory, arm_store_return_value)
6811         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6812         (arm_record_ld_st_multiple): Likewise.
6813         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6814         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6815
6816 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6817
6818         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6819         AARCH64_DISPLACED_MODIFIED_INSNS.
6820         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6821         (aarch64_displaced_step_copy_insn): Likewise.
6822         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6823         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6824         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6825         ARM_DISPLACED_MODIFIED_INSNS.
6826         * arm-tdep.c (arm_gdbarch_init): Likewise.
6827         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6828         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6829         (struct arm_displaced_step_closure): Use
6830         ARM_DISPLACED_MODIFIED_INSNS.
6831
6832 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6833
6834         * features/Makefile: Remove unused xml files.
6835         * features/aarch64.xml: Remove.
6836         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6837         * features/i386/amd64-avx-avx512.xml: Remove.
6838         * features/i386/amd64-avx-linux.xml: Remove.
6839         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6840         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6841         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6842         * features/i386/amd64-avx-mpx.xml: Remove.
6843         * features/i386/amd64-avx.xml: Remove.
6844         * features/i386/amd64-linux.xml: Remove.
6845         * features/i386/amd64-mpx-linux.xml: Remove.
6846         * features/i386/amd64-mpx.xml: Remove.
6847         * features/i386/amd64.xml: Remove.
6848         * features/i386/i386-avx-avx512-linux.xml: Remove.
6849         * features/i386/i386-avx-avx512.xml: Remove.
6850         * features/i386/i386-avx-linux.xml: Remove.
6851         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6852         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6853         * features/i386/i386-avx-mpx-linux.xml: Remove.
6854         * features/i386/i386-avx-mpx.xml: Remove.
6855         * features/i386/i386-avx.xml: Remove.
6856         * features/i386/i386-linux.xml: Remove.
6857         * features/i386/i386-mmx-linux.xml: Remove.
6858         * features/i386/i386-mmx.xml: Remove.
6859         * features/i386/i386-mpx-linux.xml: Remove.
6860         * features/i386/i386-mpx.xml: Remove.
6861         * features/i386/i386.xml: Remove.
6862         * features/i386/x32-avx-avx512-linux.xml: Remove.
6863         * features/i386/x32-avx-linux.xml: Remove.
6864         * features/i386/x32-linux.xml: Remove.
6865
6866 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6867
6868         * regformats/aarch64.dat: Remove.
6869         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6870         * regformats/i386/amd64-avx-linux.dat: Remove.
6871         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6872         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6873         * regformats/i386/amd64-linux.dat: Remove.
6874         * regformats/i386/amd64-mpx-linux.dat: Remove.
6875         * regformats/i386/amd64.dat: Remove.
6876         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6877         * regformats/i386/i386-avx-linux.dat: Remove.
6878         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6879         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6880         * regformats/i386/i386-linux.dat: Remove.
6881         * regformats/i386/i386-mmx-linux.dat: Remove.
6882         * regformats/i386/i386-mpx-linux.dat: Remove.
6883         * regformats/i386/i386.dat: Remove.
6884         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6885         * regformats/i386/x32-avx-linux.dat: Remove.
6886         * regformats/i386/x32-linux.dat: Remove.
6887
6888 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6889
6890         * aarch64-tdep.c: Remove xml self tests.
6891         * amd64-linux-tdep.c: Likewise.
6892         * amd64-tdep.c: Likewise.
6893         * i386-linux-tdep.c: Likewise.
6894         * i386-tdep.c: Likewise.
6895
6896 2019-07-03  Pedro Alves  <palves@redhat.com>
6897
6898         PR cli/24732
6899         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6900         (pipe_cmd_option_defs): New.
6901         (make_pipe_cmd_options_def_group): New.
6902         (pipe_command): Use gdb::option::process_options.
6903         (pipe_command_completer): New function.
6904         (_initialize_cli_cmds): Install completer for "pipe" command.
6905
6906 2019-07-03  Pedro Alves  <palves@redhat.com>
6907
6908         * cli/cli-option.c (union option_value) <string>: New field.
6909         (struct option_def_and_value): Add ctor, move ctor, dtor and
6910         use DISABLE_COPY_AND_ASSIGN.
6911         (option_def_and_value::clear_value): New.
6912         (parse_option, save_option_value_in_ctx, get_val_type_str)
6913         (add_setshow_cmds_for_options): Handle var_string.
6914         * cli-option.h (union option_def::var_address) <string>: New
6915         field.
6916         (struct string_option_def): New.
6917         * maint-test-options.c (struct test_options_opts): Add default
6918         ctor and use DISABLE_COPY_AND_ASSIGN.
6919         <string_opt>: New field.
6920         (test_options_opts::~test_options_opts): New.
6921         (test_options_opts::dump): Also dump "-string".
6922         (test_options_option_defs): Install "string.
6923
6924 2019-07-03  Pedro Alves  <palves@redhat.com>
6925
6926         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6927         option_value with a null enumeration.
6928         (complete_options): Save the option values in the context.
6929         (save_option_value_in_ctx): New, factored out from ...
6930         (process_options): ... here.
6931         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6932         of the function.
6933         * maint-test-options.c (test_options_opts::dump): New, factored
6934         out from ...
6935         (maintenance_test_options_command_mode): ... here.
6936         (maintenance_test_options_command_completion_result): Delete.
6937         (maintenance_test_options_command_completion_text): Update
6938         comment.
6939         (maintenance_show_test_options_completion_result): Change
6940         prototype.  Just print
6941         maintenance_test_options_command_completion_text.
6942         (save_completion_result): New.
6943         (maintenance_test_options_completer_mode): Pass options context to
6944         complete_options, and then save a dump.
6945         (_initialize_maint_test_options): Use add_cmd to install "maint
6946         show test-options-completion-result".
6947
6948 2019-07-03  Pedro Alves  <palves@redhat.com>
6949
6950         * NEWS (New commands): Mention "with" and "maint with".
6951         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6952         (with_command, with_command_completer): New.
6953         (pipe_command): Adjust to new repeat_previous
6954         interface.
6955         (_initialize_cli_cmds): Install the "with" command and its "w"
6956         alias.
6957         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6958         declarations.
6959         * cli/cli-setshow.c (parse_cli_var_uinteger)
6960         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6961         argument strings for all var_types.
6962         (get_setshow_command_value_string): New, factored out from ...
6963         (do_show_command): ... this.
6964         * cli/cli-setshow.h: Include <string>.
6965         (get_setshow_command_value_string): Declare.
6966         * command.h (repeat_previous): Now returns const char *.  Adjust
6967         comment.
6968         * maint.c: Include "cli/cli-cmds.h".
6969         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6970         (_initialize_maint_cmds): Register the "maintenance with" command.
6971         * top.c (repeat_previous): Move bits from pipe_command here:
6972         Return the saved command line, if any; error out if there's no
6973         command to relaunch.
6974
6975 2019-07-03  Pedro Alves  <palves@redhat.com>
6976
6977         * NEWS (New commands): Mention "maint set/show test-settings"
6978         instead of "maint test-settings".
6979         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6980         (maintenance_test_settings_set_list): Rename to ...
6981         (maintenance_set_test_settings_list): ... this.
6982         (maintenance_test_settings_show_list): Rename to  ...
6983         (maintenance_show_test_settings_list): ... this.
6984         (maintenance_test_settings_cmd): Delete.
6985         (maintenance_test_settings_set_cmd): ...
6986         (maintenance_set_test_settings_cmd): ... this.
6987         (maintenance_test_settings_show_cmd): ...
6988         (maintenance_show_test_settings_cmd): ... this.
6989         (maintenance_test_settings_show_value_cmd):
6990         (maintenance_show_test_settings_value_cmd): ... this.
6991         (_initialize_maint_test_settings): No longer install the "maint
6992         test-settings" prefix command.  Rename "maint test-settings set"
6993         to "maint set test-settings", and "maint test-settings show" to
6994         "maint show test-settings".  Adjust all subcommands.
6995
6996 2019-07-03  Pedro Alves  <palves@redhat.com>
6997
6998         * maint-test-settings.c: Fix file's intro comment.  Replace all
6999         references to "test-options" with references to "test-settings",
7000         in comments.
7001
7002 2019-07-03  Pedro Alves  <palves@redhat.com>
7003
7004         * maint-test-settings.c (maintenance_test_settings_xxx)
7005         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7006         New.
7007         (maintenance_test_settings_enums): Use them.
7008         (maintenance_test_settings_enum): Default to
7009         maintenance_test_settings_xxx.
7010         (_initialize_maint_test_settings): Initialize
7011         MAINTENANCE_TEST_SETTINGS_FILENAME.
7012
7013 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7014
7015         * breakpoint.h (remove_breakpoints_inf): Change return type to
7016         void, move function documentation here.
7017         * breakpoint.c (remove_breakpoints_inf): Change return type to
7018         void, move function documentation to header.
7019
7020 2019-07-02  Pedro Alves  <palves@redhat.com>
7021
7022         * NEWS (Completion improvements): Mention "info threads".
7023         * thread.c (struct info_threads_opts, info_threads_option_defs)
7024         (make_info_threads_options_def_group): New.
7025         (info_threads_command): Use gdb::option::process_options.
7026         (info_threads_command_completer): New.
7027         (_initialize_thread): Use gdb::option::build_help to build the
7028         help text for "info threads".
7029
7030 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7031
7032         * defs.h (generic_load): Move from here...
7033         * symfile.h (generic_load): ... to here.  Rename name parameter
7034         to args.
7035         * symfile.c (generic_load): Add comment.
7036
7037 2019-07-01  Tom Tromey  <tromey@adacore.com>
7038
7039         * dwarf2read.c
7040         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7041         declaration of without_params.  Fix formatting.
7042
7043 2019-07-01  Tom Tromey  <tromey@adacore.com>
7044
7045         * ada-exp.y (find_primitive_type): Update.
7046         * ada-lang.h (ada_lookup_symbol): Update.
7047         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7048         parameter.
7049         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7050
7051 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7052
7053         PR breakpoints/24541
7054         * gdbarch.c: Regenerate.
7055         * gdbarch.h: Regenerate.
7056         * gdbarch.sh: Add 'stap_adjust_register'.
7057         * i386-tdep.c: Include '<unordered_set>'.
7058         (i386_stap_adjust_register): New function.
7059         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7060         * stap-probe.c (stap_parse_register_operand): Call
7061         'gdbarch_stap_adjust_register'.
7062
7063 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7064
7065         PR python/24742
7066         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7067         * python/python.c (do_start_initialization): Use 'xmalloc'
7068         instead of 'PyMem_Malloc'.
7069
7070 2019-06-28  Tom Tromey  <tromey@adacore.com>
7071
7072         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7073         for Ada.
7074
7075 2019-06-27  Tom Tromey  <tromey@adacore.com>
7076
7077         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7078         objfile_key.
7079         (arm_find_mapping_symbol, arm_record_special_symbol)
7080         (_initialize_arm_tdep): Update.
7081         (arm_objfile_data_free): Remove.
7082
7083 2019-06-27  Tom Tromey  <tromey@adacore.com>
7084
7085         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7086         to cp_print_static_field.
7087
7088 2019-06-26  Tom Tromey  <tromey@adacore.com>
7089
7090         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7091         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7092         declare.
7093
7094 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7095
7096         * features/aarch64-core.c (create_feature_aarch64_core):
7097         Regenerate.
7098         * features/aarch64-core.xml: Add cpsr flags.
7099
7100 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7101
7102         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7103         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7104
7105 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7106
7107         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7108         field.
7109         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7110         use.
7111         (arm_record_special_symbol): Don't insert new symbol in sorted
7112         position, push it at the end.
7113
7114 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7115
7116         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7117         (arm_mapping_symbol_s): Remove.
7118         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7119         (arm_mapping_symbol_vec): New typedef.
7120         (struct arm_per_objfile): Add constructor.
7121         <section_maps>: Change type to
7122         std::unique_ptr<arm_mapping_symbol_vec[]>.
7123         (arm_compare_mapping_symbols): Remove.
7124         (arm_find_mapping_symbol): Adjust to section_maps type change.
7125         (arm_objfile_data_free): Call delete on arm_per_objfile.
7126         (arm_record_special_symbol): Adjust to section_maps type change.
7127         Allocate arm_per_objfile with new.
7128
7129 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7130
7131         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7132         with the command prefix.
7133
7134 2019-06-25  Tom Tromey  <tom@tromey.com>
7135
7136         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7137         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7138
7139 2019-06-25  Tom Tromey  <tom@tromey.com>
7140
7141         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7142         type.
7143         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7144         protected.
7145
7146 2019-06-25  Tom Tromey  <tom@tromey.com>
7147
7148         * tui/tui-winsource.c
7149         (tui_source_window_base::set_is_exec_point_at): Add check against
7150         LOA_ADDRESS.
7151
7152 2019-06-25  Tom Tromey  <tom@tromey.com>
7153
7154         * tui/tui-source.c (tui_set_source_content): Don't check before
7155         xfree.
7156         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7157
7158 2019-06-25  Tom Tromey  <tom@tromey.com>
7159
7160         * tui/tui-winsource.h (tui_update_source_window_as_is)
7161         (tui_alloc_source_buffer, tui_line_is_displayed)
7162         (tui_addr_is_displayed): Change type of win_info.
7163         * tui/tui-winsource.c (tui_update_source_window_as_is)
7164         (tui_clear_source_content, tui_show_source_line)
7165         (tui_show_source_content, tui_source_window_base::refill)
7166         (tui_source_window_base::set_is_exec_point_at)
7167         (tui_source_window_base::set_is_exec_point_at)
7168         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7169         (tui_alloc_source_buffer, tui_line_is_displayed)
7170         (tui_addr_is_displayed): Change type of win_info.  Update.
7171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7172         (tui_source_window_base::do_make_visible_with_new_height):
7173         Update.
7174         * tui/tui-source.c (tui_set_source_content)
7175         (tui_set_source_content_nil)
7176         (tui_source_window::do_scroll_vertical): Update.
7177         * tui/tui-layout.c (show_layout): Update.
7178         * tui/tui-disasm.c (tui_set_disassem_content)
7179         (tui_disasm_window::do_scroll_vertical): Update.
7180         * tui/tui-data.h (tui_win_content): Remove.
7181         (struct tui_gen_win_info) <content, content_size>: Remove.
7182         (struct tui_source_element): Add initializers and destructor.
7183         (union tui_which_element, struct tui_win_element): Remove.
7184         (struct tui_source_window_base) <content>: New field.
7185         (struct tui_data_window): Remove destructor.
7186         (tui_alloc_content, tui_free_win_content)
7187         (tui_free_all_source_wins_content): Don't declare.
7188         * tui/tui-data.c (tui_initialize_static_data): Update.
7189         (init_content_element, tui_alloc_content): Remove.
7190         (~tui_gen_win_info): Update.
7191         (~tui_data_window, tui_free_all_source_wins_content)
7192         (tui_free_win_content, free_content, free_content_elements):
7193         Remove.
7194
7195 2019-06-25  Tom Tromey  <tom@tromey.com>
7196
7197         * tui/tui-winsource.h (tui_clear_source_content)
7198         (tui_erase_source_content, tui_show_source_content): Change type
7199         of win_info.
7200         * tui/tui-winsource.c (tui_clear_source_content)
7201         (tui_erase_source_content, tui_show_source_content): Change type
7202         of win_info.
7203         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7204         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7205         win_info.
7206         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7207         win_info.
7208         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7209
7210 2019-06-25  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-winsource.c (tui_clear_source_content)
7213         (tui_source_window_base::set_is_exec_point_at): Update.
7214         * tui/tui-source.c (tui_set_source_content_nil): Update.
7215         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7216         a bool.
7217         * tui/tui-data.c (init_content_element): Update.
7218
7219 2019-06-25  Tom Tromey  <tom@tromey.com>
7220
7221         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7222         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7223         * tui/tui-layout.c (init_and_make_win): Update.
7224         * tui/tui.h (enum tui_win_type): Update.
7225         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7226         tui_win_is_auxillary.
7227         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7228         tui_win_is_auxillary.
7229
7230 2019-06-25  Tom Tromey  <tom@tromey.com>
7231
7232         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7233         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7234         (tui_delete_data_content_windows, tui_display_all_data)
7235         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7236         Update.
7237         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7238         * tui/tui-regs.c (tui_last_regs_line_no)
7239         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7240         (tui_show_registers): Update.
7241         (tui_show_register_group): Return void.  Update.
7242         (tui_display_registers_from, tui_display_reg_element_at_line)
7243         (tui_display_registers_from_line, tui_check_register_values):
7244         Update.
7245         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7246         member.
7247         (struct tui_data_window) <regs_content>: Now a std::vector.
7248         <regs_content_count>: Remove.
7249         (tui_add_content_elements, tui_free_data_content): Don't declare.
7250         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7251         (init_content_element): Remove DATA_WIN case.  Add assert.
7252         (tui_add_content_elements): Remove.
7253         (tui_data_window): Update.
7254         (tui_free_data_content): Remove.
7255         (free_content_elements): Remove DATA_WIN case.
7256
7257 2019-06-25  Tom Tromey  <tom@tromey.com>
7258
7259         * tui/tui-data.c (tui_data_item_window): Update.
7260         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7261         * tui/tui-windata.c (tui_display_all_data)
7262         (tui_display_data_from_line): Update.
7263         (tui_check_data_values): Remove.
7264         * tui/tui-regs.c (tui_show_register_group)
7265         (tui_display_reg_element_at_line): Update.
7266         * tui/tui-hooks.c (tui_register_changed)
7267         (tui_refresh_frame_and_register_information): Call
7268         tui_check_register_values.
7269         * tui/tui-data.h (struct tui_data_window) <data_content,
7270         data_content_count, data_type>: Remove.
7271         (enum tui_data_type): Remove.
7272
7273         * tui/tui-data.c (tui_data_window::clear_detail)
7274         (~tui_data_window): Update.
7275
7276 2019-06-25  Tom Tromey  <tom@tromey.com>
7277
7278         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7279         declare.
7280         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7281         Rename from tui_first_data_item_displayed.  Update.
7282         (tui_data_window::refresh_all)
7283         (tui_data_window::do_scroll_vertical): Update.
7284         * tui/tui-data.h (struct tui_data_window)
7285         <first_data_item_displayed>: Declare new method.
7286
7287 2019-06-25  Tom Tromey  <tom@tromey.com>
7288
7289         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7290         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7291         contents...
7292         (tui_initialize_static_data): ...here.
7293
7294 2019-06-25  Tom Tromey  <tom@tromey.com>
7295
7296         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7297         (tui_display_registers_from, tui_check_register_values): Update.
7298         (tui_display_register): Remove win_info parameter; update.
7299         (tui_get_register): Change type of parameters.
7300         * tui/tui-data.h (struct tui_data_element): Remove.
7301         (union tui_which_element) <data>: Remove.
7302         <data_window>: Change type.
7303         (struct tui_data_item_window): New.
7304         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7305         case.  Add assert.
7306         (~tui_data_item_window): New destructor.
7307         (free_content_elements): Remove DATA_ITEM_WIN case.
7308
7309 2019-06-25  Tom Tromey  <tom@tromey.com>
7310
7311         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7312         Remove.
7313
7314 2019-06-25  Tom Tromey  <tom@tromey.com>
7315
7316         * tui/tui-data.h (struct tui_command_element): Remove.
7317         (union tui_which_element) <command>: Remove.
7318         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7319         assert.
7320         (free_content_elements): Remove CMD_WIN case.
7321
7322 2019-06-25  Tom Tromey  <tom@tromey.com>
7323
7324         * tui/tui-layout.c (tui_set_layout): Update.
7325         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7326         * tui/tui-data.c (layout_def): Update.
7327
7328 2019-06-25  Tom Tromey  <tom@tromey.com>
7329
7330         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7331         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7332         (tui_source_window_base::set_new_height): Update.
7333         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7334         Update.
7335         (tui_set_locator_fullname, tui_set_locator_info)
7336         (tui_show_frame_info): Update.
7337         * tui/tui-source.c (tui_set_source_content)
7338         (tui_source_is_displayed): Update.
7339         * tui/tui-layout.c (show_source_disasm_command, show_data)
7340         (show_source_or_disasm_and_command): Update.
7341         * tui/tui-disasm.c (tui_set_disassem_content)
7342         (tui_get_begin_asm_address): Update.
7343         * tui/tui-data.h (struct tui_locator_element): Remove.
7344         (union tui_which_element) <locator>: Remove.
7345         (struct tui_locator_window): New.
7346         (tui_locator_win_info_ptr): Change return type.
7347         * tui/tui-data.c (_locator): Change type.
7348         (tui_locator_win_info_ptr): Change return type.
7349         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7350         (tui_alloc_content): Add assert.
7351
7352 2019-06-25  Tom Tromey  <tom@tromey.com>
7353
7354         * tui/tui-winsource.c
7355         (tui_exec_info_window::maybe_allocate_content): New method.
7356         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7357         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7358         (make_source_or_disasm_window): Add cast.
7359         * tui/tui-data.h (union tui_which_element) <simple_string>:
7360         Remove.
7361         (struct tui_source_info): New.
7362         (struct tui_source_window_base) <execution_info>: Change type.
7363         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7364         case, and add assert.
7365         (tui_alloc_content): Add assert.
7366
7367 2019-06-25  Tom Tromey  <tom@tromey.com>
7368
7369         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7370         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7371         * tui/tui-data.c (tui_alloc_win_info): Remove.
7372
7373 2019-06-25  Tom Tromey  <tom@tromey.com>
7374
7375         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7376         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7377         can_highlight.
7378
7379 2019-06-25  Tom Tromey  <tom@tromey.com>
7380
7381         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7382         make_visible_with_new_height method.
7383         (tui_win_info::make_visible_with_new_height): New method.
7384         (tui_source_window_base::do_make_visible_with_new_height)
7385         (tui_data_window::do_make_visible_with_new_height)
7386         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7387         (make_visible_with_new_height): Remove.
7388         (tui_resize_all, tui_adjust_win_heights): Use
7389         make_visible_with_new_height method.
7390         * tui/tui-data.h (struct tui_win_info)
7391         <do_make_visible_with_new_height, make_visible_with_new_height>:
7392         New methods.
7393         (struct tui_source_window_base, struct tui_data_window)
7394         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7395         methods.
7396
7397 2019-06-25  Tom Tromey  <tom@tromey.com>
7398
7399         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7400         method.
7401         (update_tab_width): Call update_tab_width method.
7402         * tui/tui-data.h (struct tui_win_info)
7403         (struct tui_source_window_base) <update_tab_width>: New methods.
7404
7405 2019-06-25  Tom Tromey  <tom@tromey.com>
7406
7407         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7408         parameter.
7409         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7410         parameter.
7411         (tui_gen_win_info::make_visible): Update.
7412         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7413         parameter.
7414         * tui/tui-data.h (enum tui_box): New enum.
7415         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7416
7417 2019-06-25  Tom Tromey  <tom@tromey.com>
7418
7419         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7420         init_and_make_win for EXEC_INFO_WIN.
7421         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7422         longer inline.
7423         (struct tui_win_info) <~tui_win_info>: Inline.
7424         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7425         Don't declare.
7426         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7427         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7428         Remove.
7429         (tui_initialize_static_data): Update.
7430         (~tui_gen_win_info): Handle more cleanup here.
7431         (~tui_source_window_base): Delete "execution_info".
7432         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7433
7434 2019-06-25  Tom Tromey  <tom@tromey.com>
7435
7436         * tui/tui-layout.c (make_command_window): Don't set
7437         can_highlight.
7438         (show_source_disasm_command): Call the reset method.
7439         (show_data): Don't set can_highlight.  Call the reset method.
7440         (tui_gen_win_info::reset): Rename from init_gen_win_info
7441         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7442         (show_source_or_disasm_and_command): Call the reset method.
7443         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7444         (struct tui_cmd_window): Set can_highlight.
7445
7446 2019-06-25  Tom Tromey  <tom@tromey.com>
7447
7448         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7449         from make_visible.
7450         (tui_make_visible, tui_make_invisible): Rewrite.
7451         (tui_win_info::make_visible): Remove.
7452         (tui_source_window_base::make_visible): Update.
7453         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7454         method.  Moved from...
7455         (struct tui_win_info) <make_visible>: ...here.
7456
7457 2019-06-25  Tom Tromey  <tom@tromey.com>
7458
7459         * tui/tui-winsource.c
7460         (tui_source_window_base::do_scroll_horizontal): Remove direction
7461         parameter.
7462         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7463         direction parameter.
7464         * tui/tui-win.c (tui_win_info::forward_scroll)
7465         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7466         (tui_win_info::right_scroll): Update.
7467         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7468         direction parameter.
7469         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7470         direction parameter.
7471         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7472         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7473         Remove direction parameter.
7474         (struct tui_source_window_base, struct tui_source_window)
7475         (struct tui_disasm_window, struct tui_data_window)
7476         (struct tui_cmd_window): Update.
7477
7478 2019-06-25  Tom Tromey  <tom@tromey.com>
7479
7480         * tui/tui-winsource.h (tui_set_exec_info_content)
7481         (tui_show_exec_info_content, tui_erase_exec_info_content)
7482         (tui_clear_exec_info_content, tui_update_exec_info): Change
7483         argument to tui_source_window_base.
7484         * tui/tui-winsource.c (tui_set_exec_info_content)
7485         (tui_show_exec_info_content, tui_erase_exec_info_content)
7486         (tui_clear_exec_info_content, tui_update_exec_info): Change
7487         argument to tui_source_window_base.
7488
7489 2019-06-25  Tom Tromey  <tom@tromey.com>
7490
7491         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7492         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7493
7494 2019-06-25  Tom Tromey  <tom@tromey.com>
7495
7496         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7497         check.
7498
7499 2019-06-25  Tom Tromey  <tom@tromey.com>
7500
7501         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7502         type to void.
7503         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7504         type to void.
7505         * tui/tui-source.c (tui_set_source_content): Update.
7506         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7507
7508 2019-06-25  Tom Tromey  <tom@tromey.com>
7509
7510         * tui/tui-win.c (window_name_completer, tui_set_focus)
7511         (tui_all_windows_info): Use name method.
7512         * tui/tui-data.h (struct tui_gen_win_info)
7513         (struct tui_source_window, struct tui_disasm_window)
7514         (struct tui_data_window, struct tui_cmd_window) <name>: New
7515         method.
7516         (tui_win_name): Don't declare.
7517         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7518         (tui_win_name): Remove.
7519
7520 2019-06-25  Tom Tromey  <tom@tromey.com>
7521
7522         * tui/tui-winsource.h (tui_update_source_window)
7523         (tui_update_source_window_as_is): Change parameter type.
7524         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7525         to be a tui_source_window_base.
7526         (tui_update_source_window_as_is): Likewise.
7527         * tui/tui-win.c (make_visible_with_new_height): Update.
7528
7529 2019-06-25  Tom Tromey  <tom@tromey.com>
7530
7531         * tui/tui-winsource.c (tui_erase_source_content)
7532         (tui_show_source_content, tui_show_exec_info_content)
7533         (tui_erase_exec_info_content): Use refresh_window method.
7534         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7535         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7536         from tui_refresh_win.
7537         (tui_data_window::refresh_window): New method.
7538         (tui_win_info::refresh, tui_source_window_base::refresh)
7539         (tui_refresh_all): Use refresh_window method.
7540         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7541         method.
7542         * tui/tui-regs.c (tui_display_register): Call refresh_window
7543         method.
7544         * tui/tui-layout.c (show_source_disasm_command)
7545         (show_source_or_disasm_and_command): Call refresh_window method.
7546         * tui/tui-data.h (struct tui_gen_win_info)
7547         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7548         New method.
7549
7550 2019-06-25  Tom Tromey  <tom@tromey.com>
7551
7552         * tui/tui.c (tui_rl_other_window, tui_enable)
7553         (tui_is_window_visible, tui_get_command_dimension): Update.
7554         * tui/tui-winsource.c (tui_update_source_window_as_is)
7555         (tui_clear_source_content, tui_erase_source_content)
7556         (tui_show_source_line, tui_source_window_base::refill)
7557         (tui_source_window_base::do_scroll_horizontal)
7558         (tui_source_window_base::set_is_exec_point_at)
7559         (tui_update_breakpoint_info, tui_set_exec_info_content)
7560         (tui_alloc_source_buffer, tui_line_is_displayed)
7561         (tui_addr_is_displayed): Update.
7562         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7563         (tui_check_and_display_highlight_if_needed)
7564         (tui_win_info::make_visible, tui_win_info::refresh)
7565         (tui_refresh_all): Update.
7566         * tui/tui-windata.c (tui_first_data_item_displayed)
7567         (tui_delete_data_content_windows, tui_erase_data_content)
7568         (tui_display_all_data, tui_data_window::refresh_all)
7569         (tui_check_data_values): Update.
7570         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7571         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7572         (tui_win_info::backward_scroll, tui_refresh_all_win)
7573         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7574         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7575         (tui_source_window_base::set_new_height)
7576         (tui_data_window::set_new_height)
7577         (make_invisible_and_set_new_height)
7578         (make_visible_with_new_height, new_height_ok)
7579         (parse_scrolling_args): Update.
7580         * tui/tui-stack.c (tui_show_frame_info): Update.
7581         * tui/tui-source.c (tui_set_source_content)
7582         (tui_set_source_content_nil, tui_source_is_displayed)
7583         (tui_source_window::do_scroll_vertical): Update.
7584         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7585         (tui_display_registers_from, tui_display_reg_element_at_line)
7586         (tui_check_register_values, tui_reg_command): Update.
7587         * tui/tui-layout.c (tui_default_win_height)
7588         (show_source_disasm_command, show_data, init_and_make_win)
7589         (show_source_or_disasm_and_command): Update.
7590         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7591         (tui_redisplay_readline, tui_mld_flush)
7592         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7593         (tui_getc): Update.
7594         * tui/tui-disasm.c (tui_set_disassem_content)
7595         (tui_disasm_window::do_scroll_vertical): Update.
7596         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7597         Now virtual.
7598         (struct tui_win_info): Derive from tui_gen_win_info.
7599         <~tui_win_info>: Mark as override.
7600         <generic>: Remove member.
7601         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7602         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7603         (~tui_data_window, ~tui_win_info)
7604         (tui_free_all_source_wins_content): Update.
7605         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7606
7607 2019-06-25  Tom Tromey  <tom@tromey.com>
7608
7609         * tui/tui-layout.c (init_and_make_win): Use new.
7610         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7611         destructor, initializers.
7612         (tui_alloc_generic_win_info): Don't declare.
7613         * tui/tui-data.c (_locator): Add argument to constructor.
7614         (source_win, disasm_win): New globals.
7615         (exec_info): Remove.
7616         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7617         Update.
7618         (tui_alloc_generic_win_info): Remove.
7619         (init_content_element): Use new.
7620         (tui_win_info::tui_win_info): Update.
7621         (free_content_elements) <case DATA_WIN>: Use delete.
7622
7623 2019-06-25  Tom Tromey  <tom@tromey.com>
7624
7625         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7626         * tui/tui-windata.c (tui_first_data_item_displayed)
7627         (tui_delete_data_content_windows): Update.
7628         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7629         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7630         (tui_display_registers_from, tui_check_register_values): Update.
7631         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7632         pointer.
7633         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7634         window.
7635         (tui_free_data_content): Update.
7636         (free_content_elements) <case DATA_WIN>: Free the window.
7637
7638 2019-06-25  Tom Tromey  <tom@tromey.com>
7639
7640         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7641         Update.
7642         * tui/tui-layout.c (make_command_window)
7643         (show_source_disasm_command, show_data, init_and_make_win)
7644         (show_source_or_disasm_and_command): Update.
7645         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7646         method.
7647         <can_highight, is_highlighted>: Now bool.
7648         (tui_set_win_highlight): Don't declare.
7649         * tui/tui-data.c (tui_set_win_highlight): Remove.
7650
7651 2019-06-25  Tom Tromey  <tom@tromey.com>
7652
7653         * tui/tui-wingeneral.c (make_visible): Remove check of window
7654         type.
7655
7656 2019-06-25  Tom Tromey  <tom@tromey.com>
7657
7658         * tui/tui-win.c (tui_win_info::max_height)
7659         (tui_cmd_window::max_height): New methods.
7660         (new_height_ok): Call max_height.
7661         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7662         <max_height>: New method.
7663
7664 2019-06-25  Tom Tromey  <tom@tromey.com>
7665
7666         * tui/tui-win.c (tui_source_window_base::set_new_height)
7667         (tui_data_window::set_new_height): New methods.
7668         (make_invisible_and_set_new_height): Call set_new_height method.
7669         * tui/tui-data.h (struct tui_win_info)
7670         (struct tui_source_window_base, struct tui_data_window)
7671         <set_new_height>: New method.
7672
7673 2019-06-25  Tom Tromey  <tom@tromey.com>
7674
7675         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7676         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7677         tui_refresh_data_win.
7678         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7679         method.
7680         (tui_refresh_all_win): Call the refresh_all method.
7681         (tui_set_focus): Likewise.
7682         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7683         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7684         Likewise.
7685
7686 2019-06-25  Tom Tromey  <tom@tromey.com>
7687
7688         * tui/tui-winsource.h (tui_refill_source_window)
7689         (tui_set_is_exec_point_at): Don't declare.
7690         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7691         (tui_source_window_base::refill): Rename from
7692         tui_refill_source_window.
7693         (tui_source_window_base::do_scroll_horizontal): Update.
7694         (tui_source_window_base::set_is_exec_point_at): Rename from
7695         tui_set_is_exec_point_at.
7696         (tui_update_all_breakpoint_info): Update.
7697         * tui/tui-stack.c (tui_show_frame_info): Update.
7698         * tui/tui-layout.c (show_data): Add cast.
7699         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7700         * tui/tui-data.h (struct tui_source_window_base) <refill,
7701         set_is_exec_point_at>: New methods.
7702         (tui_source_windows, tui_add_to_source_windows): Update types.
7703         (tui_add_to_source_windows): Remove redundant declaration.
7704         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7705         (tui_source_windows): Change return type.
7706         (tui_clear_source_windows_detail): Update.
7707         (tui_add_to_source_windows): Change type of parameter.
7708         (tui_free_all_source_wins_content): Update.
7709
7710 2019-06-25  Tom Tromey  <tom@tromey.com>
7711
7712         * tui/tui-wingeneral.c (tui_win_info::refresh)
7713         (tui_source_window_base::refresh): New methods.
7714         (tui_refresh_all): Call the refresh method.
7715         * tui/tui-data.h (struct tui_win_info)
7716         (struct tui_source_window_base) <refresh>: New method.
7717
7718 2019-06-25  Tom Tromey  <tom@tromey.com>
7719
7720         * tui/tui.h (tui_is_window_visible): Return bool.
7721         * tui/tui.c (tui_is_window_visible): Return bool.
7722         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7723         (tui_make_visible, tui_make_invisible)
7724         (tui_win_info::make_visible)
7725         (tui_source_window_base::make_visible, make_all_visible)
7726         (tui_make_all_visible, tui_make_all_invisible): Update.
7727         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7728         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7729         bool.
7730         (struct tui_win_info, struct tui_source_window_base)
7731         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7732         * tui/tui-data.c (tui_init_generic_part): Update.
7733
7734 2019-06-25  Tom Tromey  <tom@tromey.com>
7735
7736         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7737         (tui_source_window_base::make_visible): New methods.
7738         (make_all_visible): Make method call.
7739         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7740         (struct tui_source_window_base, struct tui_cmd_window): Override
7741         make_visible.
7742         (tui_win_is_source_type): Don't declare.
7743         * tui/tui-data.c (tui_win_is_source_type): Remove.
7744
7745 2019-06-25  Tom Tromey  <tom@tromey.com>
7746
7747         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7748         NULL check.
7749
7750 2019-06-25  Tom Tromey  <tom@tromey.com>
7751
7752         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7753         Inline constructor.  Add initializers for members.
7754         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7755         constructors; now inline in class.
7756
7757 2019-06-25  Tom Tromey  <tom@tromey.com>
7758
7759         * tui/tui-regs.c (tui_show_registers): Update.
7760         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7761         bool.
7762         * tui/tui-data.c (tui_data_window::clear_detail)
7763         (tui_data_window): Update.
7764
7765 2019-06-25  Tom Tromey  <tom@tromey.com>
7766
7767         * tui/tui-windata.c (tui_display_all_data)
7768         (tui_display_data_from_line, tui_display_data_from)
7769         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7770         Update.
7771         * tui/tui-regs.c (tui_last_regs_line_no)
7772         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7773         (tui_show_registers, tui_show_register_group)
7774         (tui_display_registers_from, tui_display_reg_element_at_line)
7775         (tui_display_registers_from_line, tui_check_register_values)
7776         (tui_reg_next, tui_reg_prev): Update.
7777         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7778         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7779         tui_data_window.
7780         (struct tui_win_info) <detail>: Remove.  Add new fields from
7781         tui_data_info.
7782         (TUI_DATA_WIN): Add cast.
7783         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7784         (~tui_data_window): Simplify.
7785
7786 2019-06-25  Tom Tromey  <tom@tromey.com>
7787
7788         * tui/tui-layout.c (show_source_disasm_command)
7789         (show_source_or_disasm_and_command): Update.
7790         * tui/tui-io.c (update_cmdwin_start_line)
7791         (tui_redisplay_readline): Update.
7792         * tui/tui-data.h (struct tui_command_info): Remove.
7793         (struct tui_win_info) <detail>: Remove command_info member.
7794         (struct tui_data_window) <start_line>: New member, from
7795         tui_command_info.
7796         (TUI_CMD_WIN): Add casts.
7797
7798 2019-06-25  Tom Tromey  <tom@tromey.com>
7799
7800         * tui/tui-winsource.c (tui_update_source_window)
7801         (tui_refill_source_window)
7802         (tui_source_window_base::do_scroll_horizontal)
7803         (tui_update_breakpoint_info, tui_set_exec_info_content)
7804         (tui_show_exec_info_content, tui_erase_exec_info_content)
7805         (tui_clear_exec_info_content): Update.
7806         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7807         Update.
7808         * tui/tui-win.c (make_invisible_and_set_new_height)
7809         (make_visible_with_new_height): Update.
7810         * tui/tui-source.c (tui_set_source_content)
7811         (tui_show_symtab_source): Update.
7812         * tui/tui-layout.c (extract_display_start_addr)
7813         (show_source_disasm_command, show_data)
7814         (make_source_or_disasm_window)
7815         (show_source_or_disasm_and_command): Update.
7816         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7817         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7818         "gdbarch".
7819         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7820         to tui_source_window_base.
7821         (struct tui_win_info) <detail>: Remove source_info member.
7822         (struct tui_source_window_base) <has_locator>: Inline.
7823         Move contents from tui_source_info; rename has_locator member to
7824         m_has_locator.
7825         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7826         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7827         header file.
7828         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7829         Simplify.
7830         (tui_free_all_source_wins_content): Cast to
7831         tui_source_window_base.
7832
7833 2019-06-25  Tom Tromey  <tom@tromey.com>
7834
7835         * tui/tui-win.c (make_invisible_and_set_new_height)
7836         (make_visible_with_new_height): Call has_locator method.
7837         * tui/tui-layout.c (show_source_disasm_command, show_data)
7838         (show_source_or_disasm_and_command): Update for bool change.
7839         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7840         (tui_win_info) <has_locator>: New method.
7841         (struct tui_source_window_base) <has_locator>: New method.
7842         (tui_win_has_locator): Don't declare.
7843         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7844         from tui_win_has_locator.
7845         (tui_source_window_base): Use false, not FALSE.
7846
7847 2019-06-25  Tom Tromey  <tom@tromey.com>
7848
7849         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7850         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7851         clear_detail method directly.
7852         (tui_clear_win_detail): Remove.
7853
7854 2019-06-25  Tom Tromey  <tom@tromey.com>
7855
7856         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7857         "this", not TUI_DISASM_WIN.
7858
7859 2019-06-25  Tom Tromey  <tom@tromey.com>
7860
7861         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7862         declare.
7863         * tui/tui-winsource.c
7864         (tui_source_window_base::do_scroll_horizontal): Rename from
7865         tui_horizontal_source_scroll.
7866         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7867         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7868         from tui_vertical_data_scroll.
7869         * tui/tui-win.h (tui_scroll): Don't declare.
7870         * tui/tui-win.c (tui_win_info::forward_scroll)
7871         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7872         (tui_win_info::right_scroll): Rename and update.
7873         (tui_scroll_forward_command, tui_scroll_backward_command)
7874         (tui_scroll_left_command, tui_scroll_right_command): Update.
7875         (tui_scroll): Remove.
7876         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7877         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7878         from tui_vertical_source_scroll.
7879         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7880         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7881         from tui_vertical_disassem_scroll.
7882         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7883         do_scroll_horizontal>: New methods.
7884         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7885         Likewise.
7886         (struct tui_source_window_base): Add do_scroll_horizontal.
7887         (struct tui_source_window, struct tui_disasm_window): Add
7888         do_scroll_vertical.
7889         (struct tui_data_window, struct tui_cmd_window): Add
7890         do_scroll_horizontal and do_scroll_vertical.
7891         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7892
7893 2019-06-25  Tom Tromey  <tom@tromey.com>
7894
7895         * tui/tui-data.h (struct tui_source_window_base): New struct.
7896         (struct tui_source_window): Derive from tui_source_window_base.
7897         (struct tui_disasm_window): New struct.
7898         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7899         from tui_source_window::clear_detail.
7900         (tui_source_window_base): Rename from tui_source_window.
7901         (~tui_source_window_base): Rename from ~tui_source_window.
7902         (tui_alloc_win_info): Create a tui_disasm_window.
7903
7904 2019-06-25  Tom Tromey  <tom@tromey.com>
7905
7906         * tui/tui-data.h (struct tui_source_window)
7907         (struct tui_data_window): Declare destructors.
7908         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7909         destructors.
7910         (tui_win_info): Simplify.
7911
7912 2019-06-25  Tom Tromey  <tom@tromey.com>
7913
7914         * tui/tui-winsource.c (tui_display_main)
7915         (tui_update_source_windows_with_addr)
7916         (tui_update_all_breakpoint_info): Update.
7917         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7918         (new_height_ok, parse_scrolling_args): Update.
7919         * tui/tui-stack.c (tui_show_frame_info): Update.
7920         * tui/tui-data.h (struct tui_list): Remove.
7921         (tui_source_windows): Return a reference to a std::vector.
7922         * tui/tui-data.c (source_windows): Now a std::vector.
7923         (tui_source_windows): Change return type.
7924         (tui_clear_source_windows): Rewrite.
7925         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7926         (tui_free_all_source_wins_content): Rewrite.
7927
7928 2019-06-25  Tom Tromey  <tom@tromey.com>
7929
7930         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7931         (struct tui_data_window, struct tui_cmd_window): Declare
7932         clear_detail method.
7933         * tui/tui-data.c (tui_source_window::clear_detail)
7934         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7935         methods.
7936         (tui_clear_win_detail): Simplify.
7937
7938 2019-06-25  Tom Tromey  <tom@tromey.com>
7939
7940         * tui/tui-layout.c (make_source_window, make_disasm_window)
7941         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7942         Return the new window.
7943         (show_source_disasm_command, show_data)
7944         (show_source_or_disasm_and_command): Update.
7945
7946 2019-06-25  Tom Tromey  <tom@tromey.com>
7947
7948         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7949         parameter.  Return the new window.
7950         (show_source_disasm_command): Update and remove NULL check.
7951         (show_source_or_disasm_and_command): Update.
7952
7953 2019-06-25  Tom Tromey  <tom@tromey.com>
7954
7955         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7956
7957 2019-06-25  Tom Tromey  <tom@tromey.com>
7958
7959         * tui/tui-data.h (struct tui_win_info): Make constructor
7960         protected.  Make destructor virtual.  Add initializers.
7961         (tui_source_window, tui_data_window, tui_cmd_window): New
7962         classes.
7963         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7964         constructor.  Add "type" parameter.
7965         (tui_source_window, tui_data_window, tui_cmd_window): New
7966         constructors.
7967         (tui_alloc_win_info): Instantiate the appropriate subclass.
7968
7969 2019-06-25  Tom Tromey  <tom@tromey.com>
7970
7971         * tui/tui-win.c (tui_resize_all): Use delete.
7972         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7973         destructor.
7974         (tui_free_window): Don't declare.
7975         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7976         Update.
7977
7978 2019-06-25  Tom Tromey  <tom@tromey.com>
7979
7980         * tui/tui-data.h (struct tui_win_info): Add constructor.
7981         * tui/tui-data.c (tui_alloc_win_info): Use new.
7982         (tui_free_window): Use delete.
7983
7984 2019-06-22  Tom Tromey  <tom@tromey.com>
7985
7986         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7987         declare.
7988         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7989
7990 2019-06-22  Tom Tromey  <tom@tromey.com>
7991
7992         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7993         declare.
7994         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7995
7996 2019-06-22  Tom de Vries  <tdevries@suse.de>
7997
7998         * dwarf2read.c (create_addrmap_from_aranges)
7999         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8000         instead of '%zu'.
8001
8002 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8003
8004         * dwarf2read.h (dwarf2_section_info_def): Remove.
8005         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8006         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8007         std::vector<dwarf2_section_info>.
8008         (struct dwo_file) <~dwo_file>: Remove.
8009         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8010         types field.
8011         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8012         (dwarf2_read_debug_names): Likewise.
8013         (create_debug_types_hash_table): Change parameter type to
8014         array_view, adjust code accordingly.
8015         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8016         (partial_die_info::fixup): Likewise.
8017         (determine_prefix): Likewise.
8018         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8019
8020 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8021
8022         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8023         gdb_bfd_ref_ptr.
8024         <~dwo_file>: Remove call to gdb_bfd_unref.
8025         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8026         gdb_bfd_ref_ptr::get.
8027
8028 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8029
8030         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8031         type to htab_up.
8032         * dwarf2read.c (struct dwo_file): Initialize fields.
8033         <~dwo_file>: New.
8034         (free_dwo_file): Remove, move content to ~dwo_file.
8035         (struct dwo_file_deleter): Remove.
8036         (dwo_file_up>: Remove custom deleter.
8037         (free_dwo_files): Remove.
8038         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8039         dwo_files.
8040         (process_skeletonless_type_units): Call unique_ptr::get.
8041         (allocate_dwo_file_hash_table): Add deleter to created hash
8042         table.  Change return type to htab_up.
8043         (lookup_dwo_file_slot): Don't memset dwo_file, call
8044         unique_ptr::get.
8045         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8046         (create_dwo_unit_in_dwp_v2): Likewise.
8047         (open_and_init_dwo_file): Likewise.
8048         (free_dwo_file_from_slot): Remove.
8049
8050 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8051
8052         * dwarf2read.h (struct dwarf2_section_info) <readin,
8053         is_virtual>: Change type to bool.
8054         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8055         true instead of 1.
8056
8057 2019-06-19  Tom Tromey  <tom@tromey.com>
8058
8059         * tui/tui-data.h (tui_init_content_element): Don't declare.
8060
8061 2019-06-19  Tom Tromey  <tom@tromey.com>
8062
8063         * tui/tui-data.h (tui_init_win_info): Don't declare.
8064
8065 2019-06-19  Tom de Vries  <tdevries@suse.de>
8066
8067         * dwarf2read.h (abstract_to_concrete): Change type to
8068         std::unordered_map<sect_offset, std::vector<sect_offset>,
8069         gdb::hash_enum<sect_offset>>.
8070
8071 2019-06-19  Tom Tromey  <tromey@adacore.com>
8072
8073         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8074         EVAL_AVOID_SIDE_EFFECTS specially.
8075
8076 2019-06-19  Tom Tromey  <tromey@adacore.com>
8077
8078         * source-cache.c (highlighter): New global.
8079         (source_cache::get_source_lines): Create a highlighter on demand.
8080
8081 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * defs.h (deprecated_interactive_hook): Delete declaration.
8084         * interps.c (clear_interpreter_hooks): Remove use of
8085         deprecated_interactive_hook.
8086         * top.c (deprecated_interactive_hook): Delete definition.
8087         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8088
8089 2019-06-18  Tom de Vries  <tdevries@suse.de>
8090
8091         PR gdb/24515
8092         * dwarf2read.h (abstract_to_concrete): Change type from
8093         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8094         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8095         * dwarf2read.c (read_variable): Update.
8096         (dwarf2_fetch_die_loc_sect_off): Update.
8097
8098 2019-06-17  Tom de Vries  <tdevries@suse.de>
8099
8100         PR gdb/24617
8101         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8102         accessing parent[parent_len - 1].
8103
8104 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8105
8106         PR gdb/24364
8107         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8108         call dtrace_process_dof with NULL dof.
8109
8110 2019-06-16  Tom de Vries  <tdevries@suse.de>
8111
8112         PR gdb/24445
8113         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8114
8115 2019-06-16  Tom Tromey  <tom@tromey.com>
8116
8117         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8118         (make_all_visible): Use address of member.
8119
8120 2019-06-16  Tom Tromey  <tom@tromey.com>
8121
8122         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8123         (tui_free_window, free_content, free_content_elements): Remove
8124         unnecessary cast.
8125         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8126         cast.
8127         * tui/tui-regs.c (tui_show_register_group)
8128         (tui_display_registers_from, tui_display_reg_element_at_line):
8129         Remove unnecessary cast.
8130
8131 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8132
8133         * linux-nat.c (normal_mask): Delete.
8134         (_initialize_linux_nat): Don't initialise normal_mask.
8135
8136 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8137
8138         PR gdb/24445
8139         * dwarf-index-write.h (write_psymtabs_to_index): Add
8140         dwz_basename parameter.
8141         * dwarf-index-write.c (write_gdbindex): Move file writing to
8142         write_gdbindex_1.  Change return type void.
8143         (assert_file_size): Move up, remove filename parameter.
8144         (write_gdbindex_1): New function.
8145         (write_debug_names): Change return type to void, call
8146         assert_file_size.
8147         (struct index_wip_file): New struct.
8148         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8149         file logic to index_wip_file.  Write index for dwz file if
8150         needed.
8151         (save_gdb_index_command): Pass basename of dwz file, if present.
8152         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8153         build-id of dwz file, if present.
8154         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8155         (dwarf2_get_dwz_file): Likewise.
8156         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8157         (dwarf2_get_dwz_file): Likewise.
8158
8159 2019-06-16  Tom Tromey  <tom@tromey.com>
8160
8161         * coffread.c (process_coff_symbol): Use xstrdup.
8162         * value.c (create_internalvar): Use xstrdup.
8163
8164 2019-06-16  Tom Tromey  <tom@tromey.com>
8165
8166         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8167         * breakpoint.c (stopin_command, stopat_command)
8168         (until_break_command, decode_location_default): Remove unnecessary
8169         cast.
8170         * utils.c (subset_compare): Remove unnecessary cast.
8171         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8172         cast.
8173         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8174         cast.
8175         * infcmd.c (path_command): Remove unnecessary cast.
8176         * coffread.c (decode_type): Remove unnecessary cast.
8177         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8178         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8179         * tui/tui-stack.c (tui_show_locator_content)
8180         (tui_show_frame_info): Remove unnecessary cast.
8181         * tui/tui-win.c (tui_scroll_forward_command)
8182         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8183         (parse_scrolling_args): Remove unnecessary cast.
8184         * tui/tui-data.c (init_win_info, tui_del_window)
8185         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8186         (free_content_elements): Remove unnecessary cast.
8187         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8188         unnecessary cast.
8189         * tui/tui-source.c (tui_set_source_content)
8190         (tui_vertical_source_scroll): Remove unnecessary cast.
8191         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8192         cast.
8193         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8194         * tui/tui-regs.c (tui_display_registers_from)
8195         (tui_display_register): Remove unnecessary cast.
8196         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8197         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8198         (make_visible): Remove unnecessary cast.
8199         * tui/tui-winsource.c (tui_erase_source_content)
8200         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8201         unnecessary cast.
8202         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8203         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8204         * stabsread.c (read_type, read_array_type, read_range_type):
8205         Remove unnecessary cast.
8206         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8207         (parse_symbol, parse_type, upgrade_type, parse_external)
8208         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8209         unnecessary cast.
8210         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8211
8212 2019-06-16  Tom Tromey  <tom@tromey.com>
8213
8214         * tui/tui-data.c (tui_alloc_generic_win_info)
8215         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8216         checks.
8217
8218 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8219             Andrew Burgess  <andrew.burgess@embecosm.com>
8220
8221         * f-typeprint.c (f_print_type): Don't return early for not
8222         associated or not allocated types.
8223         (f_type_print_varspec_suffix): Add print_rank parameter and print
8224         ranks of array types in case they dangling.
8225         (f_type_print_base): Add print_rank parameter.
8226
8227 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8228
8229         * NEWS: Mention new MI commands.
8230         * break-catch-throw.c (enum exception_event_kind): Move to
8231         breakpoint.h.
8232         (print_mention_exception_catchpoint): Output text as a single
8233         message.
8234         (catch_exception_command_1): Rename to...
8235         (catch_exception_event): ...this, make non-static, update header
8236         command, and change some parameter types.
8237         (catch_catch_command): Update for changes to
8238         catch_exception_command_1.
8239         (catch_throw_command): Likewise.
8240         (catch_rethrow_command): Likewise.
8241         * breakpoint.c (enum exception_event_kind): Delete.
8242         * breakpoint.h (enum exception_event_kind): Moved here from
8243         break-catch-throw.c.
8244         (catch_exception_event): Declare.
8245         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8246         (mi_cmd_catch_throw): New function.
8247         (mi_cmd_catch_rethrow): New function.
8248         (mi_cmd_catch_catch): New function.
8249         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8250         'catch-catch' entries.
8251         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8252         (mi_cmd_catch_rethrow): Declare.
8253         (mi_cmd_catch_catch): Declare.
8254
8255 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * annotate.c (annotate_source_line): Change return type to void,
8258         update implementation to match.
8259         * annotate.h (annotate_source_line): Change return type to void,
8260         update header comment.
8261         * stack.c (print_frame_info): Don't change what frame information
8262         is printed based on whether annotations are on or not.
8263
8264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8265
8266         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8267         (annotate_source): Make static.
8268         (annotate_source_line): Moved from source.c and renamed from
8269         identify_source_line.  Update the return type.
8270         * annotate.h (annotate_source): Delete declaration.
8271         (annotate_source_line): Declaration moved from source.h, and
8272         renamed from identify_source_line.  Return type updated.
8273         * source.c (identify_source_line): Moved to annotate.c and renamed
8274         to annotate_source_line.
8275         (info_line_command): Remove check of annotation_level.
8276         * source.h (identify_source_line): Move declaration to annotate.h
8277         and rename to annotate_source_line.
8278         * stack.c: Add 'annotate.h' include.
8279         (print_frame_info): Remove check of annotation_level before
8280         calling annotate_source_line.
8281
8282 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * source-cache.c (source_cache::get_plain_source_lines): Use
8285         open_source_file_with_line_charpos instead of just
8286         open_source_file, remove call to find_source_lines.
8287         (source_cache::get_source_lines): Likewise.
8288         * source.c (find_source_lines): Make static.
8289         (get_filename_and_charpos): Renamed into...
8290         (open_source_file_with_line_charpos): ..this along with changes to
8291         return a scoped_fd, and some other minor clean ups.
8292         (identify_source_line): Use open_source_file_with_line_charpos.
8293         (search_command_helper): Use open_source_file_with_line_charpos
8294         instead of just open_source_file, remove call to
8295         find_source_lines.
8296         * source.h (open_source_file_with_line_charpos): Declare new
8297         function.
8298         (find_source_lines): Delete declaration.
8299
8300 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * source.c (get_filename_and_charpos): Remove fullname
8303         parameter.
8304         (identify_source_line): Update call to get_filename_and_charpos.
8305
8306 2019-06-14  Tom Tromey  <tromey@adacore.com>
8307
8308         PR gdb/24502:
8309         * ui-style.h (skip_ansi_escape): Update comment.
8310         * ui-file.h (class no_terminal_escape_file): New class.
8311         * ui-file.c (no_terminal_escape_file::write)
8312         (no_terminal_escape_file::puts): New methods.
8313         * cli/cli-logging.c (handle_redirections): Use
8314         no_terminal_escape_file.
8315
8316 2019-06-14  Tom Tromey  <tromey@adacore.com>
8317
8318         * NEWS: Move convenience variable news above Python news.
8319
8320 2019-06-14  Tom Tromey  <tom@tromey.com>
8321
8322         * gnulib: Move directory to top-level.
8323         * configure.ac: Don't configure gnulib.
8324         * configure: Rebuild.
8325         * common/common-defs.h: Use new path to gnulib.
8326         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8327         (GNULIB_H): Remove.
8328         (INCGNU): Look in new gnulib location.
8329         (HFILES_NO_SRCDIR): Remove gnulib files.
8330         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8331         (generated_files): Remove GNULIB_H.
8332         ($(LIBGNU), all-lib): Remove targets.
8333         (distclean): Don't mention GNULIB_BUILDDIR.
8334         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8335
8336 2019-06-14  Tom Tromey  <tromey@adacore.com>
8337
8338         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8339         Warn if symbol file does not provide any symbols.
8340
8341 2019-06-14  Tom Tromey  <tromey@adacore.com>
8342
8343         * source.c (find_and_open_source): Respect basenames_may_differ.
8344
8345 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8346
8347         * annotate.c (annotate_breakpoints_invalid): Make use of
8348         scoped_restore_terminal_state.
8349         (annotate_frames_invalid): Likewise.
8350
8351 2019-06-14  Tom Tromey  <tromey@adacore.com>
8352
8353         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8354         allow assignment to an internalvar.
8355
8356 2019-06-14  Tom Tromey  <tromey@adacore.com>
8357
8358         * ada-lex.l: Allow "_" in attribute names.
8359
8360 2019-06-14  Tom Tromey  <tromey@adacore.com>
8361
8362         PR gdb/24653:
8363         * regcache.c (registers_changed): Don't call alloca.
8364         * top.c (execute_command): Don't call alloca.
8365
8366 2019-06-13  Pedro Alves  <palves@redhat.com>
8367
8368         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8369         'expression'.  When parsing an expression, error out if there's
8370         junk after "unlimited".
8371         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8372         (do_set_command): Adjust calls to is_unlimited_literal.
8373
8374 2019-06-13  Pedro Alves  <palves@redhat.com>
8375
8376         * compile/compile.c (make_compile_options_def_group): Add braces
8377         around array_view initializer.
8378         * thread.c (make_thread_apply_all_options_def_group)
8379         (make_thread_apply_all_options_def_group): Likewise.
8380
8381 2019-06-13  Pedro Alves  <palves@redhat.com>
8382
8383         * NEWS (New commands): Mention "maint test-options
8384         require-delimiter", "maint test-options unknown-is-error", "maint
8385         test-options unknown-is-operand" and "maint show
8386         test-options-completion-result".
8387         (New command options, command completion): New section.
8388         (Completion improvements): New section.
8389         Mention that you can abbreviate "unlimited".
8390
8391 2019-06-13  Pedro Alves  <palves@redhat.com>
8392
8393         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8394         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8395         * unittests/cli-utils-selftests.c (test_parse_flags)
8396         (test_parse_flags_qcs): Delete.
8397         (test_cli_utils): Don't call deleted functions.
8398
8399 2019-06-13  Pedro Alves  <palves@redhat.com>
8400
8401         * thread.c: Include "cli/cli-option.h".
8402         (tp_array_compar_ascending): Global.
8403         (tp_array_compar): Delete function.
8404         (tp_array_compar_ascending, tp_array_compar_descending): New
8405         functions.
8406         (ascending_option_def, qcs_flag_option_def)
8407         (thr_qcs_flags_option_defs)
8408         (make_thread_apply_all_options_def_group)
8409         (make_thread_apply_options_def_group): New.
8410         (thread_apply_all_command): Use gdb::option::process_options.
8411         (thread_apply_command_completer)
8412         (thread_apply_all_command_completer): New.
8413         (thread_apply_command): Use gdb::option::process_options.
8414         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8415         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8416         to generate help text of "thread apply".  Adjust "taas"'s help.
8417         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8418         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8419
8420 2019-06-13  Pedro Alves  <palves@redhat.com>
8421
8422         * thread.c (thread_apply_command): Check for invalid TID with
8423         isdigit instead of !isalpha.
8424
8425 2019-06-13  Pedro Alves  <palves@redhat.com>
8426
8427         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8428         (validate_flags_qcs): New.
8429         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8430         (validate_flags_qcs): Declare.
8431         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8432         (make_frame_apply_options_def_group): New.
8433         (frame_apply_command_count): Process options with
8434         gdb::option::process_options.
8435         (frame_apply_completer): New.
8436         (frame_apply_level_completer, frame_apply_all_completer)
8437         (frame_apply_completer): New.
8438         (_initialize_stack): Update help of "frame apply", "frame apply
8439         level", "frame apply all" and "faas" to mention supported options
8440         and install command completers.
8441         * stack.h (frame_apply_all_completer): Declare.
8442         * thread.c: Include "stack.h".
8443         (tfaas_command): Add "--".
8444         (_initialize_thread): Update help "tfaas" to mention supported
8445         options and install command completer.
8446
8447 2019-06-13  Pedro Alves  <palves@redhat.com>
8448
8449         * completer.c (complete_nested_command_line): New.
8450         (gdb_completion_word_break_characters_throw): Add assertion.
8451         * completer.h (complete_nested_command_line): Declare.
8452
8453 2019-06-13  Pedro Alves  <palves@redhat.com>
8454
8455         * stack.c (parse_backtrace_qualifiers): New.
8456         (backtrace_command): Use it.
8457         (backtrace_command_completer): Complete on qualifiers.
8458
8459 2019-06-13  Pedro Alves  <palves@redhat.com>
8460
8461         * frame.c: Include "cli/cli-option.h.
8462         (user_set_backtrace_options): New.
8463         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8464         Delete.
8465         (get_prev_frame): Adjust.
8466         (boolean_option_def, uinteger_option_def)
8467         (set_backtrace_option_defs): New.
8468         (_initialize_frame): Adjust and use
8469         gdb::option::add_setshow_cmds_for_options to install "set
8470         backtrace past-main" and "set backtrace past-entry".
8471         * frame.h: Include "cli/cli-option.h".
8472         (struct frame_print_options): Forward declare.
8473         (print_frame_arguments_all, print_frame_arguments_scalars)
8474         (print_frame_arguments_none): Declare.
8475         (print_entry_values): Delete declaration.
8476         (struct frame_print_options, user_frame_print_options): New.
8477         (struct set_backtrace_options): New.
8478         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8479         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8480         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8481         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8482         (list_args_or_locals): Add frame_print_options parameter.
8483         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8484         * python/py-framefilter.c (enumerate_args): Pass down
8485         USER_FRAME_PRINT_OPTIONS.
8486         * stack.c: Include "cli/cli-option.h".
8487         (print_frame_arguments_all, print_frame_arguments_scalars)
8488         (print_frame_arguments_none): Declare.
8489         (print_raw_frame_arguments, print_entry_values): Delete.
8490         (user_frame_print_options): New.
8491         (boolean_option_def, enum_option_def, frame_print_option_defs):
8492         New.
8493         (struct backtrace_cmd_options): New.
8494         (bt_flag_option_def): New.
8495         (backtrace_command_option_defs): New.
8496         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8497         (print_frame_arg, read_frame_arg, print_frame_args)
8498         (print_frame_info, print_frame): Add frame_print_options parameter
8499         and use it.
8500         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8501         (backtrace_command_1): Add frame_print_options and
8502         backtrace_cmd_options parameters and use them.
8503         (make_backtrace_options_def_group): New.
8504         (backtrace_command): Process command options with
8505         gdb::option::process_options.
8506         (backtrace_command_completer): New.
8507         (_initialize_stack): Extend "backtrace"'s help to mention
8508         supported options.  Install completer for "backtrace".
8509         Install some settings commands with add_setshow_cmds_for_options.
8510
8511 2019-06-13  Pedro Alves  <palves@redhat.com>
8512
8513         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8514         and that "set/show print raw frame-arguments" are now deprecated.
8515
8516         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8517         command.
8518         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8519         * stack.c (_initialize_stack): Install "set/show print
8520         raw-frame-arguments", and deprecate "set/show print raw
8521         frame-arguments".
8522         * valprint.c (_initialize_valprint): Deprecate "set/show print
8523         raw".
8524
8525 2019-06-13  Pedro Alves  <palves@redhat.com>
8526
8527         * compile/compile.c (struct compile_options): New.
8528         (compile_flag_option_def, compile_command_option_defs)
8529         (make_compile_options_def_group): New.
8530         (compile_file_command): Handle options with
8531         gdb::option::process_options.
8532         (compile_file_command_completer): New function.
8533         (compile_code_command): Handle options with
8534         gdb::option::process_options.
8535         (compile_code_command_completer): New function.
8536         (_initialize_compiler): Install completers for "compile code" and
8537         "compile file".  Mention available options in "compile code" and
8538         "compile code"'s help.
8539         * completer.c (advance_to_completion_word): New, factored out from
8540         ...
8541         (advance_to_expression_complete_word_point): ... this.
8542         (advance_to_filename_complete_word_point): New.
8543         * completer.h (advance_to_filename_complete_word_point): New
8544         declaration.
8545
8546 2019-06-13  Pedro Alves  <palves@redhat.com>
8547
8548         * compile/compile.c: Include "cli/cli-option.h".
8549         (compile_print_value): Scope data pointer is now a
8550         value_print_options pointer; adjust.
8551         (compile_print_command): Process options.  Scope data pointer is
8552         now a value_print_options pointer; adjust.
8553         (_initialize_compile): Update "compile print"'s help to include
8554         supported options.  Install a completer for "compile print".
8555         * cp-valprint.c (show_vtblprint, show_objectprint)
8556         (show_static_field_print): Delete.
8557         (_initialize_cp_valprint): Don't install "set print
8558         static-members", "set print vtbl", "set print object" here.
8559         * printcmd.c: Include "cli/cli-option.h" and
8560         "common/gdb_optional.h".
8561         (print_command_parse_format): Rework to fill in a
8562         value_print_options instead of a format_data.
8563         (print_value): Change parameter type from format_data pointer to
8564         value_print_options reference.  Adjust.
8565         (print_command_1): Process options.  Adjust to pass down a
8566         value_print_options.
8567         (print_command_completer): New.
8568         (_initialize_printcmd): Install print_command_completer as
8569         handle_brkchars completer for the "print" command.  Update
8570         "print"'s help to include supported options.
8571         * valprint.c: Include "cli/cli-option.h".
8572         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8573         here from cp-valprint.c.
8574         (boolean_option_def, uinteger_option_def)
8575         (value_print_option_defs, make_value_print_options_def_group):
8576         New.  Use gdb::option::add_setshow_cmds_for_options to install
8577         "set print elements", "set print null-stop", "set print repeats",
8578         "set print pretty", "set print union", "set print array", "set
8579         print address", "set print symbol", "set print array-indexes".
8580         * valprint.h: Include <string> and "cli/cli-option.h".
8581         (make_value_print_options_def_group): Declare.
8582         (print_value): Change parameter type from format_data pointer to
8583         value_print_options reference.
8584         (print_command_completer): Declare.
8585
8586 2019-06-13  Pedro Alves  <palves@redhat.com>
8587
8588         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8589         (COMMON_SFILES): Add maint-test-settings.c.
8590         * cli/cli-decode.c (boolean_enums): New global, factored out from
8591         ...
8592         (add_setshow_boolean_cmd): ... here.
8593         * cli/cli-decode.h (boolean_enums): Declare.
8594         * cli/cli-option.c: New file.
8595         * cli/cli-option.h: New file.
8596         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8597         factored out from ...
8598         (parse_cli_boolean_value(const char *)): ... this.
8599         (is_unlimited_literal): Change parameter type to pointer to
8600         pointer.  Adjust and advance ARG pointer.
8601         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8602         (parse_cli_var_enum): New, factored out from ...
8603         (do_set_command): ... this.  Adjust.
8604         * cli/cli-setshow.h (parse_cli_boolean_value)
8605         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8606         (parse_cli_var_enum): Declare.
8607         * cli/cli-utils.c: Include "cli/cli-option.h".
8608         (get_ulongest): New.
8609         * cli/cli-utils.h (get_ulongest): Declare.
8610         (check_for_argument): New overloads.
8611         * maint-test-options.c: New file.
8612
8613 2019-06-13  Pedro Alves  <palves@redhat.com>
8614
8615         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8616         parse a range if "-" is at the end of the string.
8617
8618 2019-06-13  Pedro Alves  <palves@redhat.com>
8619
8620         * cli/cli-setshow.c (parse_auto_binary_operation)
8621         (parse_cli_boolean_value): Don't allow "o".
8622
8623 2019-06-13  Pedro Alves  <palves@redhat.com>
8624
8625         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8626         * NEWS: Mention maint test-settings KIND.
8627         * maint-test-settings.c: New file.
8628
8629 2019-06-13  Pedro Alves  <palves@redhat.com>
8630
8631         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8632         completer.
8633         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8634         "set" completers.
8635
8636 2019-06-13  Pedro Alves  <palves@redhat.com>
8637
8638         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8639         after item.
8640
8641 2019-06-13  Pedro Alves  <palves@redhat.com>
8642
8643         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8644
8645 2019-06-13  Pedro Alves <palves@redhat.com>
8646
8647         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8648         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8649         call.
8650         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8651         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8652         calls.
8653         (check_for_argument): Skip spaces after argument.
8654
8655 2019-06-13  Pedro Alves  <palves@redhat.com>
8656
8657         * thread.c (thread_apply_command): Adjust TID parsing.
8658         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8659         detected before end of string.
8660         (tid_is_in_list): Error out if LIST is invalid.
8661
8662 2019-06-13  Pedro Alves  <palves@redhat.com>
8663
8664         * completer.c (complete_line_internal_1): Rewind completion word
8665         point.
8666         (completion_tracker::advance_custom_word_point_by): Change
8667         parameter type to int.
8668         * completer.h (completion_tracker::advance_custom_word_point_by):
8669         Likewise.
8670
8671 2019-06-13  Pedro Alves  <palves@redhat.com>
8672
8673         * completer.c (advance_to_completion_word): Handle delimiters.
8674
8675 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8676
8677         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8678
8679 2019-06-11  Tom Tromey  <tom@tromey.com>
8680
8681         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8682         (xmalloc_failed): Move to alloc.c.
8683         * alloc.c: New file.
8684         * Makefile.in (COMMON_SFILES): Add alloc.c.
8685
8686 2019-06-11  Tom Tromey  <tom@tromey.com>
8687
8688         * nat/linux-waitpid.c: Don't include server.h.
8689         (linux_debug): Remove.
8690         (my_waitpid): Update.
8691
8692 2019-06-11  Tom Tromey  <tromey@adacore.com>
8693
8694         * infcall.c (_initialize_infcall): Remove trailing newline from
8695         help.
8696         * user-regs.c (_initialize_user_regs): Remove trailing newline
8697         from help.
8698         * typeprint.c (_initialize_typeprint): Remove trailing newline
8699         from help.
8700         * reverse.c (_initialize_reverse): Remove trailing newlines from
8701         help.
8702         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8703         from help.
8704         * language.c (add_set_language_command): Remove trailing newline
8705         from help.
8706         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8707         help.
8708         * disasm.c (_initialize_disasm): Remove trailing newline from
8709         help.
8710         * top.c (init_main): Remove trailing newline from help.
8711         * interps.c (_initialize_interpreter): Remove trailing newline
8712         from help.
8713         * btrace.c (_initialize_btrace): Remove trailing newlines from
8714         help.
8715         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8716         from help.
8717         * python/python.c (_initialize_python): Remove trailing newline
8718         from help.
8719         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8720         help.
8721         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8722         from help.  Reformat some text.
8723         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8724         from help.
8725         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8726         newline from help.
8727
8728 2019-06-11  Tom Tromey  <tromey@adacore.com>
8729
8730         * darwin-nat.c (darwin_decode_exception_message)
8731         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8732
8733 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * valops.c (value_slice): Check for not allocated or not
8736         associated values.
8737
8738 2019-06-10  Tom de Vries  <tdevries@suse.de>
8739
8740         PR gdb/24618
8741         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8742         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8743         invalid.
8744
8745 2019-06-10  Tom de Vries  <tdevries@suse.de>
8746
8747         PR gdb/24611
8748         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8749         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8750
8751 2019-06-10  Tom de Vries  <tdevries@suse.de>
8752
8753         PR symtab/24545
8754         * symtab.c (struct demangled_name_entry): Add language field.
8755         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8756         static minimal symbol".  Set and use language field.
8757
8758 2019-06-10  Tom Tromey  <tromey@adacore.com>
8759
8760         * ada-lang.c (_initialize_ada_language): Update help text.
8761
8762 2019-06-10  Tom Tromey  <tromey@adacore.com>
8763
8764         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8765         with a newline.
8766         * guile/guile.c (handle_boot_error): Don't end warning with a
8767         newline.
8768         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8769         warning with a newline.
8770         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8771         newline.
8772         (s12z_frame_cache): Likewise.
8773         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8774         a newline.
8775         * solib-svr4.c (disable_probes_interface): Don't end warning with
8776         a newline.
8777         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8778         newline.
8779         * python/python.c (do_finish_initialization): Don't end warning
8780         with a newline.
8781
8782 2019-06-10  Tom Tromey  <tom@tromey.com>
8783
8784         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8785         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8786         gdbpy_enter.
8787
8788 2019-06-10  Tom Tromey  <tromey@adacore.com>
8789
8790         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8791         data.
8792         (elf_new_init): Don't call stabsread_new_init.
8793         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8794         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8795         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8796
8797 2019-06-10  Tom de Vries  <tdevries@suse.de>
8798
8799         PR symtab/16264
8800         PR symtab/24517
8801         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8802
8803 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8804
8805         * source.c (find_and_open_source): Also rewrite relative file
8806         names.
8807
8808 2019-04-26  Amos Bird  <amosbird@gmail.com>
8809
8810         * annotate.c (annotate_thread_exited): Add "thread-exited"
8811         annotation.
8812
8813 2019-06-06  Tom Tromey  <tromey@adacore.com>
8814
8815         * maint.h (class scoped_command_stats): Use
8816         DISABLE_COPY_AND_ASSIGN.
8817         <print_time>: New method.
8818         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8819         print_time.
8820         (scoped_command_stats::print_time): New method.
8821
8822 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8825         instructions of lengths 6 or 8 bytes.
8826
8827 2019-06-04  Pedro Alves  <palves@redhat.com>
8828
8829         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8830
8831         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8832         * breakpoint.c (condition_completer): Likewise.
8833         * cli/cli-dump.c (scan_expression): Likewise.
8834         * common/filestuff.c (mkdir_recursive): Likewise.
8835         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8836         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8837         (gdb_abspath): Likewise.
8838         * compile/compile-cplus-types.c
8839         (compile_cplus_instance::decl_name): Likewise.
8840         * completer.c (complete_explicit_location):
8841         (signal_completer, reg_or_group_completer_1): Likewise.
8842         * cp-support.c (cp_remove_params_if_any): Likewise.
8843         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8844         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8845         * infcmd.c (strip_bg_char): Likewise.
8846         * linespec.c (copy_token_string): Likewise.
8847         * mi/mi-main.c (output_cores): Likewise.
8848         * psymtab.c (psymtab_search_name):
8849         * symfile.c (test_set_ext_lang_command): Likewise.
8850         * target.c (target_fileio_read_stralloc): Likewise.
8851         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8852         * value.c (complete_internalvar): Likewise.
8853
8854 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8855
8856         Add objfile property to gdb.Type.
8857         * NEWS: Mention Python API addition.
8858         * python/py-type.c (typy_get_objfile): New method.
8859
8860 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8861
8862         * NEWS: Mention the new set|show style [title|highlight].
8863         Mention changes to "show style", "help" and "apropos".
8864
8865 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8866
8867         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8868         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8869         instead of print_help_for_command.
8870         (print_doc_of_command): New function.
8871         (help_list): Add 'apropos -v word' suggestion.
8872         (print_help_for_command): Style the command name using title style.
8873         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8874         (_initialize_cli_cmds): Describe -v in apropos_command help.
8875
8876 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8877
8878         * cli/cli-style.h (cli_style_option): Add name in constructor,
8879         add m_name class member, add constructor with intensity,
8880         add name class function.
8881         (cli_style_option::add_setshow_commands): Remove name argument.
8882         (highlight_style, title_style): New styles.
8883         * cli/cli-style.c (do_show): New function that shows a style
8884         characteristic styling the style name with itself.
8885         (set_style_name): New function.
8886         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8887         Update all callers according to the changes in cli/cli-style.h.
8888         * utils.h (fputs_highlighted): New function.
8889         * utils.c (fputs_highlighted): Likewise.
8890
8891 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8892
8893         * NEWS: Mention new pipe command and new convenience variables.
8894
8895 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * cli/cli-cmds.c (pipe_command): New function.
8898         (_initialize_cli_cmds): Call add_com for pipe_command.
8899         Define | as an alias for pipe.
8900         (exit_status_set_internal_vars): New function.
8901         (shell_escape): Call exit_status_set_internal_vars.
8902         cli/cli-decode.c (find_command_name_length): Recognize | as
8903         a single character command.
8904
8905 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8906
8907         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8908         top.c (execute_command_to_ui_file): New function, mostly a copy
8909         of execute_command_to_string.
8910         (execute_command_to_string): Implement by calling
8911         execute_command_to_ui_file.
8912
8913 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8914
8915         * top.h (saved_command_line): Remove declaration.
8916         * top.c (previous_saved_command_line, previous_repeat_arguments):
8917         New variables.
8918         (saved_command_line): Make static, define together with other
8919         'repeat variables'.
8920         (dont_repeat): Clear repeat_arguments.
8921         (repeat_previous, get_saved_command_line, save_command_line):
8922         New functions.
8923         (gdb_init): Initialize saved_command_line
8924         and previous_saved_command_line.
8925         * main.c (captured_main_1): Remove saved_command_line initialization.
8926         * event-top.c (handle_line_of_input): Update to use
8927         the new 'repeat' related functions instead of direct access to
8928         saved_command_line.
8929         * command.h (repeat_previous, get_saved_command_line,
8930         save_command_line): New declarations.
8931         (dont_repeat): Add comment.
8932
8933 2019-05-30  Tom Tromey  <tromey@adacore.com>
8934
8935         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8936         Fix comment.
8937         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8938
8939 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8940
8941         PR cli/24587
8942         * completer.c (complete): Initialize variable word.
8943
8944 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8945
8946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8947         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8948         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8949         'body' is NULL to the outter 'if', protecting the '!is_define'
8950         situation as well.
8951
8952 2019-05-29  Tom Tromey  <tromey@adacore.com>
8953
8954         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8955         (dwarf_unknown): New function.
8956         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8957         (dwarf_type_encoding_name): Use dwarf_unknown.
8958
8959 2019-05-29  Tom Tromey  <tromey@adacore.com>
8960
8961         PR c++/20020:
8962         * cp-valprint.c (cp_print_value_fields): Call
8963         cp_print_static_field inside "try".
8964
8965 2019-05-29  Tom Tromey  <tromey@adacore.com>
8966
8967         * inflow.c (struct terminal_info): Add default operator=.
8968         * configure: Rebuild.
8969         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8970         -Wdeprecated-copy-dtor, -Wredundant-move.
8971
8972 2019-05-29  Tom Tromey  <tromey@adacore.com>
8973
8974         * NEWS: Add entry.
8975         * infcmd.c (print_return_value_1): Handle finish_print
8976         option.
8977         (show_print_finish): New function.
8978         (_initialize_infcmd): Add "set/show print finish" commands.
8979         * valprint.c (user_print_options): Initialize new member.
8980         * valprint.h (struct value_print_options) <finish_print>: New
8981         member.
8982
8983 2019-05-28  Tom Tromey  <tromey@adacore.com>
8984
8985         * ada-lang.c (ada_remove_Xbn_suffix)
8986         (find_old_style_renaming_symbol)
8987         (parse_old_style_renaming): Remove.
8988         (ada_find_renaming_symbol): Don't call
8989         find_old_style_renaming_symbol.
8990         (ada_is_renaming_symbol): Rename from
8991         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8992         bool.  Now static.
8993         (ada_read_var_value): Update and simplify.
8994         * ada-exp.y (write_var_or_type): Remove old code.
8995
8996 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8997
8998         PR gdb/25010
8999         * event-top.c: Remove include comment.
9000         * inflow.c (class scoped_ignore_sigttou): Move from here...
9001         * inflow.h (class scoped_ignore_sigttou): ...to here.
9002         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9003         * top.c:  Remove include comment.
9004
9005 2019-05-27  Tom Tromey  <tom@tromey.com>
9006
9007         * NEWS: Fix typo.
9008
9009 2019-05-22  Tom Tromey  <tromey@adacore.com>
9010
9011         * target.c (target_follow_exec): Constify parameter.
9012         * target-delegates.c: Rebuild.
9013         * remote.c (remote_target::follow_exec): Constify parameter.
9014         * infrun.c (follow_exec): Constify parameter.
9015         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9016         (target_follow_exec): Likewise.
9017
9018 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9019
9020         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9021         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9022
9023 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9024
9025         * NEWS: Add debugredirect and testsuite sections.
9026
9027 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9028
9029         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9030         target descriptions using exclusively floating point register name
9031         aliases.
9032
9033 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9034
9035         PR gdb/18644:
9036         * f-lang.c (build_fortran_types): Handle the case where
9037         gdbarch_floatformat_for_type returns a nullptr.
9038
9039 2019-05-21  Tom de Vries  <tdevries@suse.de>
9040
9041         PR cli/24587
9042         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9043
9044 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9045
9046         PR gdb/18644:
9047         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9048         16-byte floats.
9049         * i386-tdep.c (i386_floatformat_for_type): Use
9050         floatformats_ia64_quad for the 16-byte floating point component
9051         within a fortran 32-byte complex number.
9052
9053 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9054
9055         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9056         delete default constructor.
9057         (find_partial_die): Update to return const struct.
9058         (partial_die_parent_scope): Move variable declaration into scope
9059         of its use and change its type to auto.
9060         (guess_partial_die_structure_name): Likewise.
9061         (partial_die_info::fixup): Likewise.
9062
9063 2019-05-17  Tom Tromey  <tromey@adacore.com>
9064
9065         * source.c (find_and_open_source): Remove cast.
9066
9067 2019-05-17  Tom Tromey  <tromey@adacore.com>
9068
9069         * annotate.c (annotate_source): Make "filename" const.
9070         * annotate.h (annotate_source): Use const.
9071
9072 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9073
9074         * disasm.c (set_disassembler_options): Send errors to stderr.
9075
9076 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9077
9078         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9079         (cli_interp_base::set_logging): Check debug_redirect.
9080         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9081         * cli/cli-logging.c (debug_redirect): Add static variable.
9082         (pop_output_files): Add default param.
9083         (handle_redirections): Print debug setting.
9084         (show_logging_command): Likewise.
9085         (_initialize_cli_logging): Add debugredirect command.
9086         * interps.c (current_interp_set_logging): Add debug_redirect
9087         parameter.
9088         * interps.h (set_logging): Add debug_redirect parameter.
9089         (current_interp_set_logging): Likewise.
9090         * mi/mi-common.h: Likewise.
9091         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9092
9093 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9094             Tom Tromey  <tromey@adacore.com>
9095
9096         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9097         directly.
9098         * cli/cli-interp.h (make_logging_output): Remove declaration.
9099         * cli/cli-logging.c (make_logging_output): Remove function.
9100         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9101         directly.
9102         * ui-file.c (tee_file::tee_file): Remove bools.
9103         (tee_file::~tee_file): Remove deletes.
9104         * ui-file.h (tee_file): Remove bools.
9105
9106 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9107
9108         * mi/mi-cmds.h (mi_cmd_complete): New function.
9109         * mi/mi-main.c (mi_cmd_complete): Likewise.
9110         * mi/mi-cmds.c: Define new MI command -complete.
9111         * NEWS: Mention new -complete command.
9112
9113 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9114
9115         * completer.h (complete): New function.
9116         * completer.c (complete): Likewise.
9117         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9118         function defined in completer.h.
9119
9120 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9121
9122         * MAINTAINERS (Write After Approval): Add myself.
9123
9124 2019-05-17  Tom de Vries  <tdevries@suse.de>
9125
9126         PR gdb/24094
9127         * dwarf2read.c (struct cu_partial_die_info): New struct.
9128         (find_partial_die): Return cu_partial_die_info.
9129         (partial_die_parent_scope, guess_partial_die_structure_name)
9130         (partial_die_info::fixup): Handle new return type of find_partial_die.
9131
9132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9133
9134         PR breakpoints/24541
9135         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9136         "std::string", simplifying the algorithm.
9137
9138 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9139
9140         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9141         (stap_static_probe_ops::get_probes): Likewise.
9142
9143 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9144
9145         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9146         '-')" and "else if".
9147         (stap_parse_single_operand): Join checks for
9148         "gdbarch_stap_parse_special_token_p" and
9149         "gdbarch_stap_parse_special_token" in the same "if" statement.
9150         Invert check when verifying for operation on register
9151         displacement.
9152
9153 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9154
9155         * stap-probe.c (stap_get_opcode): Update comment.
9156         (stap_get_expected_argument_type): Likewise.
9157         (handle_stap_probe): Likewise.
9158
9159 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9160
9161         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9162         return type to 'bool'.  Adjust comment.  Use 'bool' when
9163         appropriate.
9164         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9165         * stap-probe.c (stap_parse_argument_1): Likewise.
9166         (stap_is_operator): Likewise.
9167         (stap_is_generic_prefix): Likewise.
9168         (stap_is_register_prefix): Likewise.
9169         (stap_is_register_indirection_prefix): Likewise.
9170         (stap_is_integer_prefix): Likewise.
9171         (stap_generic_check_suffix): Likewise.
9172         (stap_check_integer_suffix): Likewise.
9173         (stap_check_register_suffix): Likewise.
9174         (stap_check_register_indirection_suffix): Likewise.
9175         (stap_parse_register_operand): Likewise.
9176         (stap_parse_single_operand): Likewise.
9177         (stap_parse_argument_1): Likewise.
9178         (stap_probe::get_argument_count): Likewise.
9179         (stap_is_operator): Likewise.
9180
9181 2019-05-16  Tom Tromey  <tromey@adacore.com>
9182
9183         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9184         keyword to foreach.
9185
9186 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9187
9188         * linux-thread-db.c (try_thread_db_load_1): Change return type
9189         to bool.
9190         (try_thread_db_load): Likewise.
9191         (try_thread_db_load_from_pdir_1): Likewise.
9192         (try_thread_db_load_from_pdir): Likewise.
9193         (try_thread_db_load_from_sdir): Likewise.
9194         (try_thread_db_load_from_dir): Likewise.
9195         (thread_db_load_search): Likewise.
9196         (has_libpthread): Likewise.
9197         (thread_db_load): Likewise.
9198
9199 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9200
9201         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9202         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9203         NULL, and complain/return if that's the case.
9204
9205 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9206
9207         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9208         (advance, posn, abstract_read_memory): New functions.
9209         [struct mem_read_abstraction]: New struct.
9210         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9211
9212 2019-05-14  Tom Tromey  <tromey@adacore.com>
9213
9214         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9215         value is not lval_memory.
9216
9217 2019-05-14  Tom Tromey  <tromey@adacore.com>
9218
9219         * solib.c (info_sharedlibrary_command): Style the file name.
9220
9221 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9222
9223         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9224         (aarch64_vnv_type): Likewise.
9225         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9226         * common/tdesc.c: Likewise.
9227         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9228         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9229         * features/aarch64-fpu.xml: Add ieee half view.
9230         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9231         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9232         * gdbtypes.h (struct builtin_type): Likewise.
9233         (struct objfile_type): Likewise.
9234
9235 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9236
9237         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9238         typo.
9239         * location.h (string_to_event_location): Likewise.
9240
9241 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9242
9243         GDB 8.3 released.
9244
9245 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9246
9247         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9248         New variable declaration.
9249         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9250         New variable.
9251         (print_one_breakpoint): Use ui_out::test_flags and new global
9252         variable to compute use_fixed_output.
9253         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9254         Remove.
9255         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9256         (mi_multi_location_breakpoint_output_fixed): Remove.
9257         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9258         new variable.
9259         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9260         fix_multi_location_breakpoint_output flag if version >= 3.
9261         * ui-out.h (enum ui_out_flag)
9262         <fix_multi_location_breakpoint_output>: New enumerator.
9263
9264 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9265
9266         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9267
9268 2019-05-10  Tom Tromey  <tromey@adacore.com>
9269
9270         * ada-lang.c (catch_ada_completer): New function.
9271         (_initialize_ada_language): Use it.
9272
9273 2019-05-10  Tom Tromey  <tromey@adacore.com>
9274
9275         * thread.c (print_thread_info): Make "requested_threads" const.
9276         * gdbthread.h (print_thread_info): Make "requested_threads"
9277         const.
9278         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9279         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9280
9281 2019-05-08  Tom Tromey  <tom@tromey.com>
9282
9283         * gdbtypes.c (objfile_type_data): Change type.
9284         (objfile_type, _initialize_gdbtypes): Update.
9285
9286 2019-05-08  Tom Tromey  <tom@tromey.com>
9287
9288         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9289         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9290         (_initialize_dwarf2_frame): Update.
9291
9292 2019-05-08  Tom Tromey  <tom@tromey.com>
9293
9294         * objc-lang.c (objc_objfile_data): Change type.
9295         (find_methods): Update.
9296         (_initialize_objc_lang): Remove.
9297
9298 2019-05-08  Tom Tromey  <tom@tromey.com>
9299
9300         * stabsread.c (rs6000_builtin_type_data): Change type.
9301         (rs6000_builtin_type, _initialize_stabsread): Update.
9302
9303 2019-05-08  Tom Tromey  <tom@tromey.com>
9304
9305         * mips-tdep.c (mips_pdr_data): Remove.
9306         (_initialize_mips_tdep): Update.
9307
9308 2019-05-08  Tom Tromey  <tom@tromey.com>
9309
9310         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9311         (hppa_init_objfile_priv_data, read_unwind_info)
9312         (find_unwind_entry, _initialize_hppa_tdep): Update.
9313
9314 2019-05-08  Tom Tromey  <tom@tromey.com>
9315
9316         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9317         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9318         on obstack.
9319         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9320
9321 2019-05-08  Tom Tromey  <tom@tromey.com>
9322
9323         * mdebugread.c (basic_type_data): Change type.
9324         (basic_type, _initialize_mdebugread): Update.
9325
9326 2019-05-08  Tom Tromey  <tom@tromey.com>
9327
9328         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9329
9330 2019-05-08  Tom Tromey  <tom@tromey.com>
9331
9332         * nto-tdep.c (nto_inferior_data_reg): Change type.
9333         (nto_inferior_data): Update.
9334         (nto_inferior_data_cleanup, nto_new_inferior_data)
9335         (_initialize_nto_tdep): Remove.
9336         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9337
9338 2019-05-08  Tom Tromey  <tom@tromey.com>
9339
9340         * ada-lang.c (struct ada_inferior_data): Add initializers.
9341         (ada_inferior_data): Change type.
9342         (ada_inferior_data_cleanup): Remove.
9343         (get_ada_inferior_data, ada_inferior_exit)
9344         (struct ada_pspace_data): Add initializers, destructor.
9345         (ada_pspace_data_handle): Change type.
9346         (get_ada_pspace_data): Update.
9347         (ada_pspace_data_cleanup): Remove.
9348
9349 2019-05-08  Tom Tromey  <tom@tromey.com>
9350
9351         * coffread.c (struct coff_symfile_info): Add initializers.
9352         (coff_objfile_data_key): Move lower.  Change type.
9353         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9354         Update.
9355         (coff_free_info): Remove.
9356
9357 2019-05-08  Tom Tromey  <tom@tromey.com>
9358
9359         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9360         (fbsd_pspace_data_handle): Move lower.  Change type.
9361         (get_fbsd_pspace_data): Update.
9362         (fbsd_pspace_data_cleanup): Remove.
9363         (_initialize_fbsd_tdep): Update.
9364
9365 2019-05-08  Tom Tromey  <tom@tromey.com>
9366
9367         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9368         (get_ada_tasks_pspace_data): Update.
9369         (ada_tasks_pspace_data_cleanup): Remove.
9370         (_initialize_tasks): Update.
9371         (ada_tasks_inferior_data_handle): Change type.
9372         (get_ada_tasks_inferior_data): Update.
9373         (ada_tasks_inferior_data_cleanup): Remove.
9374         (struct ada_tasks_pspace_data): Add initializers.
9375
9376 2019-05-08  Tom Tromey  <tom@tromey.com>
9377
9378         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9379         * symfile-debug.c (debug_sym_get_probes): Change type.
9380         * stap-probe.c (handle_stap_probe):
9381         (stap_static_probe_ops::get_probes): Change type.
9382         * probe.h (class static_probe_ops) <get_probes>: Change type.
9383         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9384         (parse_probes_in_pspace): Update.
9385         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9386         Update.
9387         (any_static_probe_ops::get_probes): Change type.
9388         * elfread.c (elfread_data): New typedef.
9389         (probe_key): Change type.
9390         (elf_get_probes): Likewise.  Update.
9391         (probe_key_free): Remove.
9392         (_initialize_elfread): Update.
9393         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9394         Change type.
9395         (dtrace_process_dof_probe, dtrace_process_dof)
9396         (dtrace_static_probe_ops::get_probe): Change type.
9397
9398 2019-05-08  Tom Tromey  <tom@tromey.com>
9399
9400         * xcoffread.c (struct xcoff_symfile_info): Rename from
9401         coff_symfile_info.  Add initializers.
9402         (xcoff_objfile_data_key): Move lower.  Change type.
9403         (XCOFF_DATA): Rewrite.
9404         (xcoff_free_info): Remove.
9405         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9406         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9407         (xcoff_initial_scan): Update.
9408
9409 2019-05-08  Tom Tromey  <tom@tromey.com>
9410
9411         * solib-svr4.c (struct svr4_info): Add initializers and
9412         destructor.
9413         <probes_table>: Now an htab_up.
9414         (solib_svr4_pspace_data): Change type.
9415         (free_probes_table): Simplify.
9416         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9417         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9418         (probes_table_remove_objfile_probes, register_solib_event_probe)
9419         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9420         (_initialize_svr4_solib): Update.
9421
9422 2019-05-08  Tom Tromey  <tom@tromey.com>
9423
9424         * remote.c (remote_pspace_data): Change type.
9425         (remote_pspace_data_cleanup): Remove.
9426         (get_remote_exec_file, set_pspace_remote_exec_file)
9427         (_initialize_remote): Update.
9428
9429 2019-05-08  Tom Tromey  <tom@tromey.com>
9430
9431         * breakpoint.c (breakpoint_objfile_key): Change type.
9432         (get_breakpoint_objfile_data): Update.
9433         (free_breakpoint_objfile_data): Remove.
9434         (_initialize_breakpoint): Update.
9435
9436 2019-05-08  Tom Tromey  <tom@tromey.com>
9437
9438         * linux-tdep.c (struct linux_info): Add initializers.
9439         (linux_inferior_data): Move.  Change type.
9440         (invalidate_linux_cache_inf): Update.
9441         (linux_inferior_data_cleanup): Remove.
9442         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9443
9444 2019-05-08  Tom Tromey  <tom@tromey.com>
9445
9446         * auxv.c (auxv_inferior_data): Move.  Change type.
9447         (auxv_inferior_data_cleanup): Remove.
9448         (invalidate_auxv_cache_inf): Rewrite.
9449         (get_auxv_inferior_data, _initialize_auxv): Update.
9450
9451 2019-05-08  Tom Tromey  <tom@tromey.com>
9452
9453         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9454         (symfile_debug_objfile_data_key): Change type.
9455         (symfile_debug_installed, debug_qf_has_symbols)
9456         (debug_qf_find_last_source_symtab)
9457         (debug_qf_forget_cached_source_info)
9458         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9459         (debug_qf_print_stats, debug_qf_dump)
9460         (debug_qf_expand_symtabs_for_function)
9461         (debug_qf_expand_all_symtabs)
9462         (debug_qf_expand_symtabs_with_fullname)
9463         (debug_qf_map_matching_symbols)
9464         (debug_qf_expand_symtabs_matching)
9465         (debug_qf_find_pc_sect_compunit_symtab)
9466         (debug_qf_map_symbol_filenames)
9467         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9468         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9469         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9470         (debug_sym_read_linetable, debug_sym_relocate): Update.
9471         (symfile_debug_free_objfile): Remove.
9472         (install_symfile_debug_logging, _initialize_symfile_debug):
9473         Update.
9474
9475 2019-05-08  Tom Tromey  <tom@tromey.com>
9476
9477         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9478         allocate_on_obstack.
9479         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9480         (get_dwarf2_per_objfile): Update.
9481         (set_dwarf2_per_objfile): Remove.
9482         (dwarf2_has_info, dwarf2_get_section_info): Update.
9483         (dwarf2_free_objfile): Remove.
9484         (_initialize_dwarf2_read): Update.
9485
9486 2019-05-08  Tom Tromey  <tom@tromey.com>
9487
9488         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9489         initializers.
9490         <unsupported_script_warning_printed,
9491         script_not_found_warning_printed>: Now bool.
9492         (auto_load_pspace_data): Change type.
9493         (~auto_load_pspace_info): Rename from
9494         auto_load_pspace_data_cleanup.
9495         (get_auto_load_pspace_data, init_loaded_scripts_info)
9496         (clear_section_scripts, maybe_print_unsupported_script_warning)
9497         (maybe_print_script_not_found_warning, _initialize_auto_load):
9498         Update.
9499
9500 2019-05-08  Tom Tromey  <tom@tromey.com>
9501
9502         * objfiles.c (objfile_pspace_info): Add destructor and
9503         initializers.
9504         (objfiles_pspace_data): Change type.
9505         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9506         (get_objfile_pspace_data): Update.
9507         (objfiles_bfd_data): Change type.
9508         (get_objfile_bfd_data): Update.
9509         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9510
9511 2019-05-08  Tom Tromey  <tom@tromey.com>
9512
9513         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9514         Change type.
9515         (get_catch_syscall_inferior_data): Update.
9516         (catch_syscall_inferior_data_cleanup): Remove.
9517         (_initialize_break_catch_syscall): Update.
9518
9519 2019-05-08  Tom Tromey  <tom@tromey.com>
9520
9521         * inflow.c (struct terminal_info): Add destructor and
9522         initializers.
9523         (inflow_inferior_data): Change type.
9524         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9525         (get_inflow_inferior_data, inflow_inferior_exit)
9526         (swap_terminal_info, _initialize_inflow): Update.
9527
9528 2019-05-08  Tom Tromey  <tom@tromey.com>
9529
9530         * target-dcache.c (target_dcache_cleanup): Remove.
9531         (target_dcache_aspace_key): Change type.
9532         (target_dcache_init_p, target_dcache_invalidate)
9533         (target_dcache_get, target_dcache_get_or_init)
9534         (_initialize_target_dcache): Update.
9535         * dcache.h (struct dcache_deleter): New.
9536
9537 2019-05-08  Tom Tromey  <tom@tromey.com>
9538
9539         * symtab.c (struct symbol_cache): Add destructor and
9540         initializers.
9541         (symbol_cache_key): Move.  Change type.
9542         (make_symbol_cache, free_symbol_cache): Remove.
9543         (get_symbol_cache): Update.
9544         (symbol_cache_cleanup): Remove.
9545         (ALL_PSPACES, symbol_cache_flush)
9546         (maintenance_print_symbol_cache)
9547         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9548         Update.
9549
9550 2019-05-08  Tom Tromey  <tom@tromey.com>
9551
9552         * symtab.c (struct main_info): Add destructor and initializers.
9553         (main_progspace_key): Move.  Change type.
9554         (get_main_info): Update.
9555         (main_info_cleanup): Remove.
9556         (_initialize_symtab): Update.
9557
9558 2019-05-08  Tom Tromey  <tom@tromey.com>
9559
9560         * registry.h (DECLARE_REGISTRY): Define the _key class.
9561
9562 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9563
9564         * NEWS: Merge two 'New commands' sections.
9565
9566 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9567
9568         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9569         parameter and use Ada language definition instead.
9570         (ada_val_print_ptr): Remove unused language parameter.
9571         (ada_val_print_num): Remove language parameter and use Ada language
9572         definition instead.
9573         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9574         parameter.
9575         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9576         parameter and use Ada language definition instead.
9577         (ada_val_print_1): Update all ada_val_print_xxx calls.
9578         Remove language parameter.
9579         (ada_val_print): Update ada_val_print_1 call.
9580
9581 2019-05-08  Tom Tromey  <tromey@adacore.com>
9582
9583         * remote.c (remote_hw_watchpoint_limit)
9584         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9585         Now static.
9586
9587 2019-05-08  Tom Tromey  <tromey@adacore.com>
9588
9589         * maint.c (_initialize_maint_cmds): Move initialization code to
9590         remote.c.
9591         (watchdog, show_watchdog): Move to remote.c.
9592         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9593         "watchdog" static.
9594         (_initialize_remote): Move initialization code from maint.c.
9595         * defs.h (watchdog): Don't declare.
9596
9597 2019-05-08  Tom Tromey  <tromey@adacore.com>
9598
9599         * tui/tui-interp.c: Include main.h.
9600         * interps.c: Include main.h.
9601         * main.h (interpreter_p): Declare.
9602         * defs.h (interpreter_p): Don't declare.
9603
9604 2019-05-08  Tom Tromey  <tromey@adacore.com>
9605
9606         * dwarf2loc.c: Include dwarf2read.h.
9607         * defs.h (read_unsigned_leb128): Don't declare.
9608         * dwarf2read.h (read_unsigned_leb128): Declare.
9609
9610 2019-05-08  Tom Tromey  <tromey@adacore.com>
9611
9612         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9613         method.
9614
9615 2019-05-08  Tom Tromey  <tromey@adacore.com>
9616
9617         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9618         when no wrap column is set.
9619
9620 2019-05-08  Tom Tromey  <tromey@adacore.com>
9621
9622         * c-lang.c (c_get_string): Handle non-C-style arrays.
9623
9624 2019-05-08  Tom Tromey  <tromey@adacore.com>
9625
9626         * typeprint.c (print_offset_data::update): Print the bit offset,
9627         not the number of bits remaining.
9628
9629 2019-05-08  Tom Tromey  <tromey@adacore.com>
9630
9631         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9632         padding at end of comment.
9633
9634 2019-05-08  Tom Tromey  <tromey@adacore.com>
9635
9636         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9637         Compare main types.
9638
9639 2019-05-06  Tom Tromey  <tom@tromey.com>
9640
9641         * common/scoped_mmap.c: Include common-defs.h.
9642         * common/scoped_mmap.h: Don't include config.h.
9643
9644 2019-05-04  Tom Tromey  <tom@tromey.com>
9645
9646         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9647         (struct aarch64_call_info): Add initializers.
9648         <si>: Now a std::vector.
9649         (pass_on_stack, aarch64_push_dummy_call): Update.
9650
9651 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9652             Tom Tromey  <tom@tromey.com>
9653
9654         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9655         (ppc_threads): Now a std::vector.  Now static.
9656         (hwdebug_find_thread_points_by_tid)
9657         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9658         Update.
9659
9660 2019-05-04  Tom Tromey  <tom@tromey.com>
9661
9662         * arc-tdep.c (arc_tdesc_init): Return bool.
9663
9664 2019-05-04  Tom Tromey  <tom@tromey.com>
9665
9666         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9667         Use gdb_assert_not_reached.
9668
9669 2019-05-04  Tom Tromey  <tom@tromey.com>
9670
9671         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9672         "false".
9673
9674 2019-05-04  Tom Tromey  <tom@tromey.com>
9675
9676         * arc-tdep.c (arc_tdesc_init): Use bool.
9677
9678 2019-05-04  Tom Tromey  <tom@tromey.com>
9679
9680         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9681
9682 2019-05-04  Tom Tromey  <tom@tromey.com>
9683
9684         * cli/cli-cmds.c (valid_command_p): Return bool.
9685
9686 2019-05-04  Tom Tromey  <tom@tromey.com>
9687
9688         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9689         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9690
9691 2019-05-04  Raul Tambre  <raul@tambre.ee>
9692
9693         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9694         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9695         operator for comparison.
9696
9697 2019-05-04  Tom Tromey  <tom@tromey.com>
9698
9699         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9700         (lookup_partial_symbol, print_partial_symbols)
9701         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9702         (psymbol_compare): Update.
9703         (add_psymbol_to_bcache): Clear the entire psymbol.
9704         (maintenance_check_psymtabs): Update.
9705         * psympriv.h (struct partial_symbol): Don't derive from
9706         general_symbol_info.
9707         <obj_section, unrelocated_address, address,
9708         set_unrelocated_address>: Update.
9709         <ginfo>: New member.
9710         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9711         (debug_names::write_psymbols): Update.
9712
9713 2019-05-04  Tom de Vries  <tdevries@suse.de>
9714
9715         * contrib/cc-with-tweaks.sh: Support -n arg.
9716
9717 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9718
9719         * corelow.c (core_target::detach): Ensure frame cache and
9720         register caches are cleared.
9721         inferior.c (exit_inferior_1): Likewise.
9722
9723 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9724             Tom Tromey  <tom@tromey.com>
9725
9726         * dictionary.c (collate_pending_symbols_by_language): Remove
9727         "struct" from foreach.
9728         * symtab.c (lookup_global_symbol_from_objfile)
9729         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9730         foreach.
9731         * ser-tcp.c (net_open): Remove "struct" from foreach.
9732         * objfiles.c (objfile_relocate, objfile_rebase)
9733         (objfile_has_symbols): Remove "struct" from foreach.
9734         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9735         from foreach.
9736         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9737         foreach.
9738         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9739         "struct" from foreach.
9740         * ada-lang.c (create_excep_cond_exprs)
9741         (ada_exception_catchpoint_cond_string): Remove "struct" from
9742         foreach.
9743
9744 2019-05-03  Tom Tromey  <tromey@adacore.com>
9745
9746         * ada-exp.y (convert_char_literal): Check suffix of each
9747         enumerator.
9748
9749 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9750
9751         PR ada/21406:
9752         * ada-exp.y (yywrap): Don't define.
9753         * ada-lex.l (%option): Add noyywrap
9754         (yywrap): Remove.
9755
9756 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9757
9758         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9759         _WIN32_WINNT to the XP level, unless already defined to a higher
9760         level.
9761
9762         * unittests/parse-connection-spec-selftests.c:
9763         * ser-tcp.c:
9764         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9765         override.
9766
9767         * symfile.c (find_separate_debug_file): Remove colon from the
9768         drive spec of DOS/Windows file names of the target, so that the
9769         file name produced from DEBUGDIR and the target's directory will
9770         be valid on DOS/Windows systems.
9771
9772 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9773
9774         * rust-lang.c (val_print_struct): Handle printing structures
9775         containing strings.
9776
9777 2019-05-02  Tom Tromey  <tromey@adacore.com>
9778
9779         * valarith.c (_initialize_valarith): Remove.
9780
9781 2019-05-01  Tom Tromey  <tromey@adacore.com>
9782
9783         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9784         bitfields.
9785
9786 2019-05-01  Tom Tromey  <tromey@adacore.com>
9787
9788         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9789         for big-endian copies.
9790
9791 2019-04-30  Ali Tamur  <tamur@google.com>
9792         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9793         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9794         (read_3_bytes): New function.
9795
9796 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9797
9798         * windows-nat.c (main_thread_id): Delete.
9799         (handle_output_debug_string): Replace main_thread_id by
9800         current_event.dwThreadId.
9801         (fake_create_process): Likewise.
9802         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9803         Do not set main_thread_id.
9804         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9805         current_event.dwThreadId.
9806         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9807
9808 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9809
9810         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9811         Use current_event.dwThreadId instead of main_thread_id.
9812
9813 2019-04-30  Tom Tromey  <tromey@adacore.com>
9814
9815         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9816         (create_excep_cond_exprs): Iterate over program spaces.
9817         (ada_exception_catchpoint_cond_string): Examine all minimal
9818         symbols for exception types.
9819
9820 2019-04-30  Tom Tromey  <tromey@adacore.com>
9821
9822         PR c++/24470:
9823         * dwarf2read.c (process_structure_scope): Handle case where type
9824         has template parameters but no symbol was created.
9825
9826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9827             Chris January  <chris.january@arm.com>
9828
9829         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9830         qualifier.
9831         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9832
9833 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9834
9835         * f-typeprint.c (f_print_type): Update rules for printing
9836         whitespace.
9837         (f_type_print_varspec_suffix): Likewise.
9838
9839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9840             Chris January  <chris.january@arm.com>
9841
9842         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9843         function arguments.
9844
9845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9846
9847         * f-lang.c (build_fortran_types): Change name of void type to
9848         lower case.
9849         * f-typeprint.c (f_type_print_base): Print the name of the void
9850         type, rather than a fixed string.
9851         * f-valprint.c (f_decorations): Use lower case void string.
9852
9853 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9854             Chris January  <chris.january@arm.com>
9855
9856         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9857         types for Fortran.
9858
9859 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9860             Chris January  <chris.january@arm.com>
9861             David Lecomber  <david.lecomber@arm.com>
9862
9863         * f-exp.y (BINOP_INTRINSIC): New token.
9864         (exp): New parser rule handling BINOP_INTRINSIC.
9865         (f77_keywords): Add new builtin procedures.
9866         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9867         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9868         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9869         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9870         (print_unop_subexp_f): New function.
9871         (print_binop_subexp_f): New function.
9872         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9873         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9874         (dump_subexp_body_f): Likewise.
9875         (operator_check_f): Likewise.
9876         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9877         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9878
9879 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9880
9881         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9882         UNOP_KIND.
9883         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9884         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9885         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9886         (operator_length_f): New fuction.
9887         (print_subexp_f): New function.
9888         (op_name_f): New function.
9889         (dump_subexp_body_f): New function.
9890         (operator_check_f): New function.
9891         (exp_descriptor_f): Replace standard expression handling functions
9892         with new functions.
9893         * gdb/fortran-operator.def: New file.
9894         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9895         * gdb/std-operator.def: Remove UNOP_KIND.
9896
9897 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9898
9899         * std-operator.def: Remove unbalanced, stray double quote
9900         character.
9901
9902 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9903             Chris January  <chris.january@arm.com>
9904             Daniel Everett  <daniel.everett@arm.com>
9905             Nick Forrington  <nick.forrington@arm.com>
9906             Richard Bunt  <richard.bunt@arm.com>
9907
9908         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9909         of depth when printing anonymous structs or unions.
9910         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9911         Don't print either the top-level value, or the children if the
9912         max-depth is exceeded.
9913         (ppscm_print_children): When printing the key of a map, allow one
9914         extra level of depth.
9915         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9916         print either the top-level value, or the children if the max-depth
9917         is exceeded.
9918         (print_children): When printing the key of a map, allow one extra
9919         level of depth.
9920         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9921         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9922         (user_print_options): Initialise max_depth field.
9923         (val_print_scalar_or_string_type_p): New function.
9924         (val_print): Check to see if the max depth has been reached.
9925         (val_print_check_max_depth): Define new function.
9926         (show_print_max_depth): New function.
9927         (_initialize_valprint): Add 'print max-depth' option.
9928         * valprint.h (struct value_print_options) <max_depth>: New field.
9929         (val_print_check_max_depth): Declare new function.
9930         * NEWS: Document new feature.
9931
9932 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * ada-lang.c (ada_language_defn): Initialise new field.
9935         * c-lang.c (c_is_string_type_p): New function.
9936         (c_language_defn): Initialise new field.
9937         (cplus_language_defn): Initialise new field.
9938         (asm_language_defn): Initialise new field.
9939         (minimal_language_defn): Initialise new field.
9940         * c-lang.h (c_is_string_type_p): Declare new function.
9941         * d-lang.c (d_language_defn): Initialise new field.
9942         * f-lang.c (f_is_string_type_p): New function.
9943         (f_language_defn): Initialise new field.
9944         * go-lang.c (go_is_string_type_p): New function.
9945         (go_language_defn): Initialise new field.
9946         * language.c (default_is_string_type_p): New function.
9947         (unknown_language_defn): Initialise new field.
9948         (auto_language_defn): Initialise new field.
9949         * language.h (struct language_defn) <la_is_string_type_p>: New
9950         member variable.
9951         (default_is_string_type_p): Declare new function.
9952         * m2-lang.c (m2_language_defn): Initialise new field.
9953         * objc-lang.c (objc_language_defn): Initialise new field.
9954         * opencl-lang.c (opencl_language_defn): Initialise new field.
9955         * p-lang.c (pascal_is_string_type_p): New function.
9956         (pascal_language_defn): Initialise new field.
9957         * rust-lang.c (rust_is_string_type_p): New function.
9958         (rust_language_defn): Initialise new field.
9959
9960 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9961
9962         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9963         New field.
9964         * ada-lang.c (ada_language_defn): Initialise new field.
9965         * c-lang.c (c_language_defn): Likewise.
9966         (cplus_language_defn): Likewise.
9967         (asm_language_defn): Likewise.
9968         (minimal_language_defn): Likewise.
9969         * d-lang.c (d_language_defn): Likewise.
9970         * f-lang.c (f_language_defn): Likewise.
9971         * go-lang.c (go_language_defn): Likewise.
9972         * language.c (unknown_language_defn): Likewise.
9973         (auto_language_defn): Likewise.
9974         * m2-lang.c (m2_language_defn): Likewise.
9975         * objc-lang.c (objc_language_defn): Likewise.
9976         * opencl-lang.c (opencl_language_defn): Likewise.
9977         * p-lang.c (pascal_language_defn): Likewise.
9978         * rust-lang.c (rust_language_defn): Likewise.
9979
9980 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9981
9982         * ada-lang.c (ada_is_character_type): Change return type to bool.
9983         (ada_is_string_type): Likewise.
9984         * ada-lang.h (ada_is_character_type): Update declaration
9985         (ada_is_string_type): Likewise.
9986
9987 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9988
9989         Support style in 'frame|thread apply'
9990
9991         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9992         * record.c (record_start, record_stop): Update callers of
9993         execute_command_to_string with false.
9994         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9995         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9996         methods.
9997         (class string_file): New constructor with term_out parameter.
9998         Override methods term_out and can_emit_style_escape.  New member
9999         term_out.
10000         (class stdio_file): Override can_emit_style_escape.
10001         (class tee_file): Override term_out and can_emit_style_escape.
10002         * utils.h (can_emit_style_escape): Remove.
10003         * utils.c (can_emit_style_escape): Likewise.
10004         Update all callers of can_emit_style_escape (SOMESTREAM) to
10005         SOMESTREAM->can_emit_style_escape.
10006         * source-cache.c (source_cache::get_source_lines): Likewise.
10007         * stack.c (frame_apply_command_count): Call execute_command_to_string
10008         passing the term_out characteristic of the current gdb_stdout.
10009         * thread.c (thr_try_catch_cmd): Likewise.
10010         * top.c (execute_command_to_string): pass term_out parameter
10011         to construct the string_file for the command output.
10012         * ui-file.c (term_cli_styling): New function (most code moved
10013         from utils.c can_emit_style_escape).
10014         (string_file::string_file, string_file::can_emit_style_escape,
10015         stdio_file::can_emit_style_escape, tee_file::term_out,
10016         tee_file::can_emit_style_escape): New functions.
10017
10018 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10019
10020         * NEWS: Mention the new set|show may-call-functions.
10021         * infcall.c (may_call_functions_p): New variable.
10022         (show_may_call_functions_p): New function.
10023         (call_function_by_hand_dummy): Throws an error if not
10024         may-call-functions.
10025         (_initialize_infcall): Call add_setshow_boolean_cmd for
10026         may-call-functions.
10027
10028 2019-04-25  Keith Seitz  <keiths@redhat.com>
10029
10030         PR c++/24367
10031         * cp-support.c (inspect_type): Don't attempt substitutions
10032         of symbol with the same name.
10033
10034 2019-04-25  Tom Tromey  <tromey@adacore.com>
10035
10036         PR gdb/24475:
10037         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10038         static.
10039
10040 2019-04-25  Tom Tromey  <tromey@adacore.com>
10041
10042         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10043         rvalue reference.
10044         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10045         (gdb_xml_parser::parse): Use std::move.
10046         * python/python-internal.h (gdbpy_convert_exception): Take a const
10047         reference.
10048         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10049         std::move.
10050         * python/py-utils.c (gdbpy_convert_exception): Take a const
10051         reference.
10052         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10053         Use std::move.
10054         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10055         Use std::move.
10056         * mi/mi-main.c (mi_print_exception): Take a const reference.
10057         * main.c (handle_command_errors): Take a const reference.
10058         * linespec.c (parse_linespec): Use std::move.
10059         * infcall.c (run_inferior_call): Use std::move.
10060         (call_function_by_hand_dummy): Use std::move.
10061         * exec.c (try_open_exec_file): Use std::move.
10062         * exceptions.h (exception_print, exception_fprintf)
10063         (exception_print_same): Update.
10064         * exceptions.c (print_exception, exception_print)
10065         (exception_fprintf, exception_print_same): Change parameters to
10066         const reference.
10067         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10068         * common/new-op.c: Use std::move.
10069         * common/common-exceptions.h (struct gdb_exception): Add move
10070         constructor.
10071         (struct gdb_exception_error, struct gdb_exception_quit, struct
10072         gdb_quit_bad_alloc): Change constructor to move constructor.
10073         (throw_exception): Change parameter to rvalue reference.
10074         * common/common-exceptions.c (throw_exception): Take rvalue
10075         reference.
10076         * cli/cli-interp.c (safe_execute_command): Use std::move.
10077         * breakpoint.c (insert_bp_location, location_to_sals): Use
10078         std::move.
10079
10080 2019-04-25  Tom Tromey  <tromey@adacore.com>
10081
10082         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10083         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10084         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10085         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10086         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10087         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10088         guile/scm-value.c: Use unpack.
10089         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10090         gdbscm_gdb_exception.
10091         (gdbscm_throw_gdb_exception): Likewise.
10092         (struct gdbscm_gdb_exception): New.
10093         (unpack): New function.
10094         (gdbscm_wrap): Use unpack.
10095
10096 2019-04-25  Tom Tromey  <tromey@adacore.com>
10097
10098         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10099         (gdb_rl_callback_handler): Use std::move.
10100         * common/common-exceptions.h (struct gdb_exception): Add move
10101         assignment operator.
10102         (throw_exception_sjlj): Change "exception" to const reference.
10103         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10104         (throw_exception_sjlj): Change "exception" to const reference.
10105
10106 2019-04-25  Tom Tromey  <tromey@adacore.com>
10107
10108         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10109         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10110         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10111         Update.
10112         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10113         Update.
10114         * mi/mi-interp.c (mi_interp::exec): Update.
10115         * linespec.c (parse_linespec): Update.
10116         * infcall.c (run_inferior_call): Update.
10117         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10118         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10119         (gdbscm_lookup_global_symbol): Update.
10120         * guile/scm-param.c (gdbscm_parameter_value): Update.
10121         * guile/scm-frame.c (gdbscm_frame_read_register)
10122         (gdbscm_frame_read_var): Update.
10123         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10124         * exec.c (try_open_exec_file): Update.
10125         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10126         (gdb_rl_callback_handler): Update.
10127         * common/common-exceptions.h (exception_none): Don't declare.
10128         * common/common-exceptions.c (exception_none): Don't define.
10129         (struct catcher) <exception>: Update.
10130         * cli/cli-interp.c (safe_execute_command): Update.
10131         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10132
10133 2019-04-25  Ali Tamur  <tamur@google.com>
10134
10135         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10136         (read_attribute_value): Likewise.
10137         (dwarf2_read_addr_index): Update comment.
10138         (read_str_index): Add DW_FORM_strx.
10139         (dwarf2_string_attr): Likewise.
10140         (dwarf2_const_value_attr): Likewise.
10141         (dump_die_shallow): Likewise.
10142         (dwarf2_fetch_constant_bytes): Likewise.
10143         (skip_form_bytes): Likewise.
10144         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10145
10146 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10147
10148         PR corefiles/11608
10149         PR corefiles/18187
10150         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10151         OFFSET.  Verify if current mapping contains an ELF header.
10152         (linux_find_memory_regions_full): Adjust call to
10153         dump_mapping_p.
10154
10155 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10156             Kang Li <kanglictf@gmail.com>
10157
10158         PR gdb/21600
10159
10160         * dwarf2-frame.c (read_initial_length): Be consistent about using
10161         unsigned representation of length.
10162         (decode_frame_entry_1): Likewise.  Check for wraparound of
10163         end pointer as well as buffer overflow.
10164
10165 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10166
10167         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10168         "vq".
10169
10170 2019-04-24  Tom Tromey  <tromey@adacore.com>
10171
10172         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10173
10174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * s12z-tdep.c (s12z_unwind_pc): Delete.
10177         (s12z_unwind_sp): Delete.
10178         (s12z_gdbarch_init): Don't register deleted functions with
10179         gdbarch.
10180
10181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10182
10183         * rl78-tdep.c (rl78_unwind_sp): Delete.
10184         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10185
10186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10187
10188         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10189         (xstormy16_unwind_pc): Delete.
10190         (xstormy16_dummy_id): Delete.
10191         (xstormy16_gdbarch_init): Don't register deleted functions with
10192         gdbarch.
10193
10194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * vax-tdep.c (vax_unwind_pc): Delete.
10197         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10198
10199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10200
10201         * v850-tdep.c (v850_unwind_sp): Delete.
10202         (v850_unwind_pc): Delete.
10203         (v850_dummy_id): Delete.
10204         (v850_gdbarch_init): Don't register deleted functions with
10205         gdbarch.
10206
10207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10208
10209         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10210         (tilegx_unwind_pc): Delete.
10211         (tilegx_unwind_dummy_id): Delete.
10212         (tilegx_gdbarch_init): Don't register deleted functions with
10213         gdbarch.
10214
10215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10216
10217         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10218         (tic6x_dummy_id): Delete.
10219         (tic6x_gdbarch_init): Don't register deleted functions with
10220         gdbarch.
10221
10222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10223
10224         * sparc-tdep.c (sparc_unwind_pc): Delete.
10225         (sparc32_gdbarch_init): Don't register deleted function with
10226         gdbarch.
10227
10228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10229
10230         * sh-tdep.c (sh_unwind_sp): Delete.
10231         (sh_unwind_pc): Delete.
10232         (sh_dummy_id): Delete.
10233         (sh_gdbarch_init): Don't register deleted functions with
10234         gdbarch.
10235
10236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10237
10238         * score-tdep.c (score_unwind_sp): Delete.
10239         (score_unwind_pc): Delete.
10240         (score_dummy_id): Delete.
10241         (score_gdbarch_init): Don't register deleted functions with
10242         gdbarch.
10243
10244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10245
10246         * rx-tdep.c (rx_unwind_pc): Delete.
10247         (rx_unwind_sp): Delete.
10248         (rx_dummy_id): Delete.
10249         (rx_gdbarch_init): Don't register deleted functions with
10250         gdbarch.  Update comment.
10251
10252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10253
10254         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10255         (rs6000_dummy_id): Delete.
10256         (rs6000_gdbarch_init): Don't register deleted functions with
10257         gdbarch.
10258
10259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10260
10261         * or1k-tdep.c (or1k_dummy_id): Delete.
10262         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10263
10264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * nios2-tdep.c (nios2_dummy_id): Delete.
10267         (nios2_unwind_sp): Delete.
10268         (nios2_gdbarch_init): Don't register deleted functions with
10269         gdbarch.
10270
10271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * nds32-tdep.c (nds32_dummy_id): Delete.
10274         (nds32_unwind_pc): Delete.
10275         (nds32_unwind_sp): Delete.
10276         (nds32_gdbarch_init): Don't register deleted functions with
10277         gdbarch.
10278
10279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10280
10281         * msp430-tdep.c (msp430_unwind_pc): Delete.
10282         (msp430_unwind_sp): Delete.
10283         (msp430_dummy_id): Delete.
10284         (msp430_gdbarch_init): Don't register deleted functions with
10285         gdbarch.
10286
10287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * moxie-tdep.c (moxie_unwind_sp): Delete.
10290         (moxie_unwind_pc): Delete.
10291         (moxie_dummy_id): Delete.
10292         (moxie_gdbarch_init): Don't register deleted functions with
10293         gdbarch.
10294
10295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10296
10297         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10298         (mn10300_unwind_pc): Delete.
10299         (mn10300_unwind_sp): Delete.
10300         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10301         mn10300_unwind_sp.
10302         (mn10300_frame_unwind_init): Don't register deleted functions with
10303         gdbarch.
10304
10305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10306
10307         * mep-tdep.c (mep_unwind_pc): Delete.
10308         (mep_unwind_sp): Delete.
10309         (mep_dummy_id): Delete.
10310         (mep_gdbarch_init): Don't register deleted functions with
10311         gdbarch.
10312
10313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10314
10315         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10316         (m68hc11_unwind_sp): Delete.
10317         (m68hc11_gdbarch_init): Don't register deleted functions with
10318         gdbarch.
10319
10320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10321
10322         * m32r-tdep.c (m32r_unwind_sp): Delete.
10323         (m32r_unwind_pc): Delete.
10324         (m32r_dummy_id): Delete.
10325         (m32r_gdbarch_init): Don't register deleted functions with
10326         gdbarch.
10327
10328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         * m32c-tdep.c (m32c_unwind_pc): Delete.
10331         (m32c_unwind_sp): Delete.
10332         (m32c_dummy_id): Delete.
10333         (m32c_gdbarch_init): Don't register deleted functions with
10334         gdbarch.
10335
10336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10339         (lm32_unwind_pc): Delete.
10340         (lm32_dummy_id): Delete.
10341         (lm32_gdbarch_init): Don't register deleted functions with
10342         gdbarch.
10343
10344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10345
10346         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10347         (iq2000_unwind_pc): Delete.
10348         (iq2000_dummy_id): Delete.
10349         (iq2000_gdbarch_init): Don't register deleted functions with
10350         gdbarch.
10351
10352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * nds32-tdep.c (nds32_type_align): Delete.
10355         (nds32_push_dummy_call): Use type_align instead.
10356
10357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10358
10359         * arm-tdep.c (arm_type_align): Only handle vector override case.
10360         (arm_push_dummy_call): Use type_align.
10361         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10362
10363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10364
10365         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10366         case.
10367         (pass_on_stack): Use type_align.
10368         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10369         function.
10370
10371 2019-04-23  Tom Tromey  <tromey@adacore.com>
10372
10373         * dwarf2read.c (line_header::file_name_at): Remove unused
10374         overload.
10375
10376 2019-04-23  Tom de Vries  <tdevries@suse.de>
10377
10378         PR gdb/24438
10379         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10380         invocation.
10381
10382
10383 2019-03-27  Ali Tamur  <tamur@google.com>
10384
10385         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10386         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10387         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10388         (dwarf_expr_context::get_addr_index): Likewise
10389         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10390         (symbol_needs_eval_context::get_addr_index): Likewise
10391         (disassemble_dwarf_expression): Add DW_OP_addrx
10392         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10393         (read_cutu_die_from_dwo): Update comment
10394         (skip_one_die): Add DW_FORM_addrx
10395         (read_attribute_value): Likewise
10396         (var_decode_location): Add DW_OP_addrx
10397         (dwarf2_const_value_attr): Add DW_FORM_addrx
10398         (dump_die_shallow): Likewise
10399         (dwarf2_fetch_constant_bytes): Likewise
10400         (decode_locdesc): Add DW_OP_addrx
10401         (skip_form_bytes): Add DW_FORM_addrx
10402
10403 2019-04-22  Ali Tamur  <tamur@google.com>
10404
10405         * MAINTAINERS (Write After Approval): Add self.
10406
10407 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10408
10409         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10410         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10411         (open_symbol_file_object): Likewise.
10412         (svr4_default_sos): Add info parameter.
10413         (svr4_read_so_list): Likewise.
10414         (svr4_current_sos_direct): Adjust functions calls to pass down
10415         info.
10416         (svr4_current_sos_1): Add info parameter.
10417         (svr4_current_sos): Call get_svr4_info, pass info down to
10418         svr4_current_sos_1.
10419         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10420         get_svr4_info.
10421         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10422         get_svr4_info.
10423         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10424         to get_svr4_info.
10425         (probes_table_remove_objfile_probes): Likewise.
10426         (register_solib_event_probe): Add info parameter.
10427         (solist_update_incremental): Pass info parameter down to
10428         svr4_read_so_list.
10429         (disable_probes_interface): Add info parameter.
10430         (svr4_handle_solib_event): Pass current_program_space to
10431         get_svr4_info.  Adjust disable_probes_interface cleanup.
10432         (svr4_create_probe_breakpoints): Add info parameter, pass it
10433         down to register_solib_event_probe.
10434         (svr4_create_solib_event_breakpoints): Add info parameter,
10435         pass it down to svr4_create_probe_breakpoints.
10436         (enable_break): Pass info down to
10437         svr4_create_solib_event_breakpoints.
10438         (svr4_solib_create_inferior_hook): Pass current_program_space to
10439         get_svr4_info.
10440         (svr4_clear_solib): Likewise.
10441
10442 2019-04-22  Pedro Alves  <palves@redhat.com>
10443
10444         * solib-svr4.c (svr4_free_objfile_observer): New.
10445         (probe_and_action::objfile): New field.
10446         (probes_table_htab_remove_objfile_probes)
10447         (probes_table_remove_objfile_probes): New functions.
10448         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10449         in the new probe_and_action.  Don't store the probe in 'lookup'.
10450         (svr4_create_probe_breakpoints): Pass objfile to
10451         register_solib_event_probe.
10452         (_initialize_svr4_solib): Register a free_objfile observer.
10453
10454 2019-04-19  Tom Tromey  <tom@tromey.com>
10455
10456         * common/queue.h: Remove.
10457
10458 2019-04-19  Tom Tromey  <tom@tromey.com>
10459
10460         * event-loop.c: Don't include "common/queue.h".
10461
10462 2019-04-19  Tom Tromey  <tom@tromey.com>
10463
10464         * remote.c (remote_target): Use delete.
10465         * remote-notif.h: Include <list>, not "common/queue.h".
10466         (notif_client_p): Remove typedef.
10467         (remote_notif_state): Add constructor, destructor, initializer.
10468         <notif_queue>: Now a std::list.
10469         (remote_notif_state_xfree): Don't declare.
10470         * remote-notif.c (remote_notif_process, handle_notification)
10471         (remote_notif_state_allocate): Update.
10472         (~remote_notif_state): Rename from remote_notif_state_xfree.
10473
10474 2019-04-19  Tom Tromey  <tom@tromey.com>
10475
10476         * symfile.c (reread_symbols): Update.
10477         * objfiles.c (objfile_register_static_link)
10478         (objfile_lookup_static_link): Update
10479         (~objfile) Don't delete static_links.
10480         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10481
10482 2019-04-19  Tom Tromey  <tom@tromey.com>
10483
10484         * type-stack.h (struct type_stack) <insert>: Constify string.
10485         * type-stack.c (type_stack::insert): Constify string.
10486         * gdbtypes.h (lookup_template_type): Update.
10487         (address_space_name_to_int): Update.
10488         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10489         const.
10490         (lookup_template_type): Make name const.
10491         * c-exp.y: Update rules.
10492         (lex_one_token, classify_name, classify_inner_name)
10493         (c_print_token): Update.
10494         * p-exp.y: Update rules.
10495         (yylex): Update.
10496         * f-exp.y: Update rules.
10497         (yylex): Update.
10498         * d-exp.y: Update rules.
10499         (lex_one_token, classify_name, classify_inner_name): Update.
10500         * parse.c (write_dollar_variable, copy_name): Return std::string.
10501         * parser-defs.h (copy_name): Change return type.
10502         * m2-exp.y: Update rules.
10503         (yylex): Update.
10504         * go-exp.y (lex_one_token): Update.
10505         Update rules.
10506         (classify_unsafe_function, classify_packaged_name)
10507         (classify_name, yylex): Update.
10508
10509 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10510
10511         * configure.ac: add --enable-source-highlight switch.
10512         * configure: Regenerate.
10513         * top.c (print_gdb_version): plumb --enable-source-highlight
10514         status to "show configuration".
10515
10516 2019-04-19  Tom Tromey  <tromey@adacore.com>
10517
10518         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10519         Check ADA_TYPE_P.
10520         (empty_record, ada_template_to_fixed_record_type_1)
10521         (template_to_static_fixed_type)
10522         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10523         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10524         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10525         macros.
10526
10527 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10528
10529         PR symtab/24423:
10530         * source.c (print_source_lines_base): Advance "iter" when a
10531         control character is seen.
10532
10533 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10534
10535         * inferior.h (struct infcall_suspend_state_deleter):
10536         Catch exception in destructor to avoid crash.
10537
10538 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10539
10540         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10541         close to the add_com "shell".
10542
10543 2019-04-18  Tom Tromey  <tromey@adacore.com>
10544
10545         * process-stratum-target.h (class process_stratum_target)
10546         <stratum>: Add "final".
10547
10548 2019-04-17  Tom Tromey  <tromey@adacore.com>
10549
10550         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10551         against nullptr before use.
10552
10553 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10554
10555         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10556
10557 2019-04-17  Jim Wilson  <jimw@sifive.com>
10558             Andrew Burgess  <andrew.burgess@embecosm.com>
10559
10560         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10561         code read might fail, assume 4-byte breakpoint in that case.
10562
10563 2019-04-15  Leszek Swirski  <leszeks@google.com>
10564
10565         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10566         rather than a hand-rolled POD check when checking for forced MEMORY
10567         classification.
10568
10569 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10570
10571         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10572         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10573         function.
10574         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10575         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10576         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10577         declaration.
10578
10579 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10580
10581         * aarch64-linux-nat.c
10582         (aarch64_linux_nat_target::thread_architecture): Add override.
10583         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10584         each VQ.
10585
10586 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10587
10588         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10589
10590 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10591
10592         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10593         target types of size 96-bits, add some additional comments, and
10594         check that the builtin type we found was the correct size.
10595
10596 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10597
10598         * utils.c (prompt_for_continue): Don't restore the styling at the
10599         end, as applied_style has the wrong value.  This fixes styling in
10600         long lists of file names that are interrupted by the "Continue?"
10601         prompt.
10602
10603 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10604
10605         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10606         * c-lang.c (c_language_defn): Likewise.
10607         (cplus_language_defn): Likewise.
10608         (asm_language_defn): Likewise.
10609         (minimal_language_defn): Likewise.
10610         * d-lang.c (d_language_defn): Likewise.
10611         * f-lang.c (f_language_defn): Likewise.
10612         * go-lang.c (go_language_defn): Likewise.
10613         * language.c (unknown_language_defn): Likewise.
10614         (auto_language_defn): Likewise.
10615         * language.h (struct language_defn): Remove la_magic field.
10616         (LANG_MAGIC): Delete.
10617         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10618         * objc-lang.c (objc_language_defn): Likewise.
10619         * opencl-lang.c (opencl_language_defn): Likewise.
10620         * p-lang.c (pascal_language_defn): Likewise.
10621         * rust-lang.c (rust_language_defn): Likewise.
10622
10623 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10624
10625         * riscv-tdep.c (riscv_type_align): New function.
10626         (riscv_type_alignment): Delete.
10627         (riscv_arg_location): Use 'type_align'.
10628         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10629
10630 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10631
10632         * gdbtypes.c (type_align): A struct with no non-static fields also
10633         has alignment of 1.
10634
10635 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10636
10637         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10638         component to 0.
10639         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10640         member.
10641         (riscv_struct_info::analyse): New implementation using new
10642         analyse_inner member function.
10643         (riscv_struct_info::field_offset): New member function.
10644         (riscv_struct_info::m_offsets): New member variable.
10645         (riscv_struct_info::analyse_inner): New private member function,
10646         takes the old implementation of riscv_struct_info::analyse but
10647         extended to track field offsets.
10648         (riscv_call_arg_struct): Update the struct folding special cases
10649         to handle cases where empty C++ structs, which are non-zero
10650         length, are found.
10651         (riscv_arg_location): Initialise the length of each location, a
10652         non-zero length now indicates the location is in use.
10653         (riscv_push_dummy_call): Allow for the first location having a
10654         non-zero offset when setting up arguments.
10655         (riscv_return_value): Likewise, but for return values.
10656
10657 2019-04-11  Tom Tromey  <tromey@adacore.com>
10658
10659         * utils.c (internal_vproblem): Make "msg" const.
10660
10661 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10662
10663         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10664         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10665         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10666         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10667
10668 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10669
10670         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10671         function.
10672         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10673         of amd64_collect_native_gregset.
10674         (amd64_linux_nat_target::store_registers): Likewise.
10675
10676 2019-04-10  Tom Tromey  <tom@tromey.com>
10677
10678         * symtab.c (lookup_global_symbol_from_objfile)
10679         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10680         * objfiles.h (class separate_debug_iterator): New.
10681         (class separate_debug_range): New.
10682         (struct objfile) <separate_debug_objfiles>: New method.
10683         (objfile_separate_debug_iterate): Don't declare.
10684         * objfiles.c (separate_debug_iterator::operator++): Rename from
10685         objfile_separate_debug_iterate.
10686         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10687         iterator.
10688         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10689         iterator.
10690
10691 2019-04-10  Tom Tromey  <tom@tromey.com>
10692
10693         * symfile.c (reread_symbols): Remove old comment.
10694         * objfiles.c (free_all_objfiles): Fix a typo.
10695
10696 2019-04-10  Tom Tromey  <tom@tromey.com>
10697
10698         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10699         * minsyms.c (lookup_minimal_symbol): Use foreach.
10700         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10701         (lookup_minimal_symbol_solib_trampoline): Likewise.
10702         * symfile.c (reread_symbols): Use foreach.
10703
10704 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10705             Tom Tromey  <tromey@adacore.com>
10706
10707         PR rust/24414:
10708         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10709         (rust_lex_int_test): Change "value" to be LONGEST.
10710         (rust_lex_tests): Add test for long integer literal.
10711
10712 2019-04-09  Tom Tromey  <tromey@adacore.com>
10713
10714         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10715         to bool.
10716         (extended_remote_target::attach): Update.
10717         (remote_target::remote_notice_new_inferior): Update.
10718         (remote_target::add_current_inferior_and_thread): Update.
10719         * inferior.c (exit_inferior_1): Use "false".
10720         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10721
10722 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10723
10724         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10725         the "start" command.
10726
10727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10728
10729         * python/py-inferior.c (infpy_thread_from_thread_handle):
10730         Adjust comments to reflect renaming of thread_from_thread_handle
10731         to thread_from_handle.  Adjust keywords.  Fix type error message.
10732         (inferior_object_methods): Add thread_from_handle.  Retain
10733         thread_from_thread_handle, but mark it as deprecated.
10734
10735 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10736
10737         * gdbthread.h (find_thread_by_handle): Revise declaration.
10738         * thread.c (find_thread_by_handle): Likewise.  Adjust
10739         implementation too.
10740         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10741         support for buffer objects as handles.
10742
10743 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10744
10745         * python/py-infthread.c (thpy_thread_handle): New function.
10746         (thread_object_methods): Register thpy_thread_handle.
10747
10748 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10749
10750         * gdbthread.h (thread_to_thread_handle): Declare.
10751         * thread.c (gdbtypes.h): Include.
10752         (thread_to_thread_handle): New function.
10753
10754         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10755         (target_thread_info_to_thread_handle): Declare.
10756         * target.c (target_thread_info_to_thread_handle): New function.
10757         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10758         * target-delegates.c: Regenerate.
10759
10760         * linux-thread-db.c (class thread_db_target): Add method
10761         thread_info_to_thread_handle.
10762         (thread_db_target::thread_info_to_thread_handle): Define.
10763         * remote.c (class remote_target): Add new method
10764         thread_info_to_thread_handle.
10765         (remote_target::thread_info_to_thread_handle): Define.
10766
10767 2019-04-08  Pedro Alves  <palves@redhat.com>
10768
10769         * common/common-exceptions.c (throw_exception): Don't create
10770         named object to throw; throw directly.
10771         (throw_it): Likewise.  Don't initialize gdb_exception::message
10772         here, with new; pass FMT and AP to the ctor instead.
10773         * common/common-exceptions.h: Include <string>.
10774         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10775         const char *, va_list)): New ctor.  Use std::make_shared.
10776         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10777         errors)): Delete.
10778         (gdb_exception_error::gdb_exception_error(enum errors, const char
10779         *, va_list)): New.
10780         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10781         Add assertion.
10782         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10783         errors)): Delete.
10784         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10785         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10786         Add assertion.
10787
10788 2019-04-08  Tom Tromey  <tom@tromey.com>
10789
10790         * valops.c (value_rtti_indirect_type): Replace throw_exception
10791         with throw.
10792         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10793         with throw.
10794         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10795         throw.
10796         * target.c (target_translate_tls_address): Replace throw_exception
10797         with throw.
10798         * stack.c (frame_apply_command_count): Replace throw_exception
10799         with throw.
10800         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10801         throw.
10802         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10803         with throw.
10804         * rs6000-tdep.c (rs6000_frame_cache)
10805         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10806         * remote.c: Replace throw_exception with throw.
10807         * record-full.c (record_full_message, record_full_wait_1)
10808         (record_full_restore): Replace throw_exception with throw.
10809         * record-btrace.c:
10810         (get_thread_current_frame_id, record_btrace_start_replaying)
10811         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10812         (cmd_record_btrace_start): Replace throw_exception with throw.
10813         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10814         throw.
10815         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10816         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10817         * linespec.c:
10818         (find_linespec_symbols): Replace throw_exception with throw.
10819         * infrun.c (displaced_step_prepare, resume): Replace
10820         throw_exception with throw.
10821         * infcmd.c (post_create_inferior): Replace throw_exception with
10822         throw.
10823         * inf-loop.c (inferior_event_handler): Replace throw_exception
10824         with throw.
10825         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10826         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10827         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10828         (get_prev_frame_always, get_frame_pc_if_available)
10829         (get_frame_address_in_block_if_available, get_frame_language):
10830         Replace throw_exception with throw.
10831         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10832         throw_exception with throw.
10833         * eval.c (fetch_subexp_value, evaluate_var_value)
10834         (evaluate_funcall, evaluate_subexp_standard): Replace
10835         throw_exception with throw.
10836         * dwarf2loc.c (call_site_find_chain)
10837         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10838         Replace throw_exception with throw.
10839         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10840         with throw.
10841         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10842         throw.
10843         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10844         * completer.c (complete_line_internal): Replace throw_exception
10845         with throw.
10846         * compile/compile-object-run.c (compile_object_run): Replace
10847         throw_exception with throw.
10848         * cli/cli-script.c (process_next_line): Replace throw_exception
10849         with throw.
10850         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10851         (btrace_enable, btrace_maint_update_pt_packets): Replace
10852         throw_exception with throw.
10853         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10854         throw_exception with throw.
10855         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10856         throw_exception with throw.
10857         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10858         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10859         * aarch64-tdep.c (aarch64_make_prologue_cache)
10860         (aarch64_make_stub_cache): Replace throw_exception with throw.
10861
10862 2019-04-08  Tom Tromey  <tom@tromey.com>
10863
10864         * common/common-exceptions.c (throw_exception): Rename from
10865         throw_exception_cxx.  Remove old copy.  Make argument const.
10866         (throw_it): Create and throw exception objects directly.
10867         * common/common-exceptions.h (throw_exception): Make argument
10868         const.
10869         (struct gdb_exception_error): Add constructor.
10870         (struct gdb_exception_quit): Add constructor.
10871
10872 2019-04-08  Tom Tromey  <tom@tromey.com>
10873
10874         * common/common-exceptions.h (exception_rethrow): Don't declare.
10875         (TRY_SJLJ): Update comment.
10876         (TRY, CATCH, END_CATCH): Remove.
10877         * common/common-exceptions.c (exception_rethrow): Remove.
10878
10879 2019-04-08  Tom Tromey  <tom@tromey.com>
10880
10881         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10882         Remove.
10883         (gdb_exception_error): Rename from
10884         gdb_exception_RETURN_MASK_ERROR.
10885         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10886         (gdb_quit_bad_alloc): Update.
10887         * aarch64-tdep.c: Update.
10888         * ada-lang.c: Update.
10889         * ada-typeprint.c: Update.
10890         * ada-valprint.c: Update.
10891         * amd64-tdep.c: Update.
10892         * arch-utils.c: Update.
10893         * break-catch-throw.c: Update.
10894         * breakpoint.c: Update.
10895         * btrace.c: Update.
10896         * c-varobj.c: Update.
10897         * cli/cli-cmds.c: Update.
10898         * cli/cli-interp.c: Update.
10899         * cli/cli-script.c: Update.
10900         * common/common-exceptions.c: Update.
10901         * common/new-op.c: Update.
10902         * common/selftest.c: Update.
10903         * compile/compile-c-symbols.c: Update.
10904         * compile/compile-cplus-symbols.c: Update.
10905         * compile/compile-object-load.c: Update.
10906         * compile/compile-object-run.c: Update.
10907         * completer.c: Update.
10908         * corelow.c: Update.
10909         * cp-abi.c: Update.
10910         * cp-support.c: Update.
10911         * cp-valprint.c: Update.
10912         * darwin-nat.c: Update.
10913         * disasm-selftests.c: Update.
10914         * dtrace-probe.c: Update.
10915         * dwarf-index-cache.c: Update.
10916         * dwarf-index-write.c: Update.
10917         * dwarf2-frame-tailcall.c: Update.
10918         * dwarf2-frame.c: Update.
10919         * dwarf2loc.c: Update.
10920         * dwarf2read.c: Update.
10921         * eval.c: Update.
10922         * event-loop.c: Update.
10923         * event-top.c: Update.
10924         * exec.c: Update.
10925         * f-valprint.c: Update.
10926         * fbsd-tdep.c: Update.
10927         * frame-unwind.c: Update.
10928         * frame.c: Update.
10929         * gdbtypes.c: Update.
10930         * gnu-v3-abi.c: Update.
10931         * guile/guile-internal.h: Update.
10932         * guile/scm-block.c: Update.
10933         * guile/scm-breakpoint.c: Update.
10934         * guile/scm-cmd.c: Update.
10935         * guile/scm-disasm.c: Update.
10936         * guile/scm-frame.c: Update.
10937         * guile/scm-lazy-string.c: Update.
10938         * guile/scm-math.c: Update.
10939         * guile/scm-param.c: Update.
10940         * guile/scm-ports.c: Update.
10941         * guile/scm-pretty-print.c: Update.
10942         * guile/scm-symbol.c: Update.
10943         * guile/scm-symtab.c: Update.
10944         * guile/scm-type.c: Update.
10945         * guile/scm-value.c: Update.
10946         * i386-linux-tdep.c: Update.
10947         * i386-tdep.c: Update.
10948         * inf-loop.c: Update.
10949         * infcall.c: Update.
10950         * infcmd.c: Update.
10951         * infrun.c: Update.
10952         * jit.c: Update.
10953         * language.c: Update.
10954         * linespec.c: Update.
10955         * linux-fork.c: Update.
10956         * linux-nat.c: Update.
10957         * linux-tdep.c: Update.
10958         * linux-thread-db.c: Update.
10959         * main.c: Update.
10960         * mi/mi-cmd-break.c: Update.
10961         * mi/mi-cmd-stack.c: Update.
10962         * mi/mi-interp.c: Update.
10963         * mi/mi-main.c: Update.
10964         * objc-lang.c: Update.
10965         * p-valprint.c: Update.
10966         * parse.c: Update.
10967         * ppc-linux-tdep.c: Update.
10968         * printcmd.c: Update.
10969         * python/py-arch.c: Update.
10970         * python/py-breakpoint.c: Update.
10971         * python/py-cmd.c: Update.
10972         * python/py-finishbreakpoint.c: Update.
10973         * python/py-frame.c: Update.
10974         * python/py-framefilter.c: Update.
10975         * python/py-gdb-readline.c: Update.
10976         * python/py-inferior.c: Update.
10977         * python/py-infthread.c: Update.
10978         * python/py-lazy-string.c: Update.
10979         * python/py-linetable.c: Update.
10980         * python/py-objfile.c: Update.
10981         * python/py-param.c: Update.
10982         * python/py-prettyprint.c: Update.
10983         * python/py-progspace.c: Update.
10984         * python/py-record-btrace.c: Update.
10985         * python/py-record.c: Update.
10986         * python/py-symbol.c: Update.
10987         * python/py-type.c: Update.
10988         * python/py-unwind.c: Update.
10989         * python/py-utils.c: Update.
10990         * python/py-value.c: Update.
10991         * python/python.c: Update.
10992         * record-btrace.c: Update.
10993         * record-full.c: Update.
10994         * remote-fileio.c: Update.
10995         * remote.c: Update.
10996         * riscv-tdep.c: Update.
10997         * rs6000-aix-tdep.c: Update.
10998         * rs6000-tdep.c: Update.
10999         * rust-exp.y: Update.
11000         * rust-lang.c: Update.
11001         * s390-tdep.c: Update.
11002         * selftest-arch.c: Update.
11003         * solib-dsbt.c: Update.
11004         * solib-frv.c: Update.
11005         * solib-spu.c: Update.
11006         * solib-svr4.c: Update.
11007         * solib.c: Update.
11008         * sparc64-linux-tdep.c: Update.
11009         * stack.c: Update.
11010         * symfile-mem.c: Update.
11011         * symmisc.c: Update.
11012         * target.c: Update.
11013         * thread.c: Update.
11014         * top.c: Update.
11015         * tracefile-tfile.c: Update.
11016         * tui/tui.c: Update.
11017         * typeprint.c: Update.
11018         * unittests/cli-utils-selftests.c: Update.
11019         * unittests/parse-connection-spec-selftests.c: Update.
11020         * valops.c: Update.
11021         * valprint.c: Update.
11022         * value.c: Update.
11023         * varobj.c: Update.
11024         * windows-nat.c: Update.
11025         * x86-linux-nat.c: Update.
11026         * xml-support.c: Update.
11027
11028 2019-04-08  Tom Tromey  <tom@tromey.com>
11029
11030         * xml-support.c: Use C++ exception handling.
11031         * x86-linux-nat.c: Use C++ exception handling.
11032         * windows-nat.c: Use C++ exception handling.
11033         * varobj.c: Use C++ exception handling.
11034         * value.c: Use C++ exception handling.
11035         * valprint.c: Use C++ exception handling.
11036         * valops.c: Use C++ exception handling.
11037         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11038         handling.
11039         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11040         * typeprint.c: Use C++ exception handling.
11041         * tui/tui.c: Use C++ exception handling.
11042         * tracefile-tfile.c: Use C++ exception handling.
11043         * top.c: Use C++ exception handling.
11044         * thread.c: Use C++ exception handling.
11045         * target.c: Use C++ exception handling.
11046         * symmisc.c: Use C++ exception handling.
11047         * symfile-mem.c: Use C++ exception handling.
11048         * stack.c: Use C++ exception handling.
11049         * sparc64-linux-tdep.c: Use C++ exception handling.
11050         * solib.c: Use C++ exception handling.
11051         * solib-svr4.c: Use C++ exception handling.
11052         * solib-spu.c: Use C++ exception handling.
11053         * solib-frv.c: Use C++ exception handling.
11054         * solib-dsbt.c: Use C++ exception handling.
11055         * selftest-arch.c: Use C++ exception handling.
11056         * s390-tdep.c: Use C++ exception handling.
11057         * rust-lang.c: Use C++ exception handling.
11058         * rust-exp.y: Use C++ exception handling.
11059         * rs6000-tdep.c: Use C++ exception handling.
11060         * rs6000-aix-tdep.c: Use C++ exception handling.
11061         * riscv-tdep.c: Use C++ exception handling.
11062         * remote.c: Use C++ exception handling.
11063         * remote-fileio.c: Use C++ exception handling.
11064         * record-full.c: Use C++ exception handling.
11065         * record-btrace.c: Use C++ exception handling.
11066         * python/python.c: Use C++ exception handling.
11067         * python/py-value.c: Use C++ exception handling.
11068         * python/py-utils.c: Use C++ exception handling.
11069         * python/py-unwind.c: Use C++ exception handling.
11070         * python/py-type.c: Use C++ exception handling.
11071         * python/py-symbol.c: Use C++ exception handling.
11072         * python/py-record.c: Use C++ exception handling.
11073         * python/py-record-btrace.c: Use C++ exception handling.
11074         * python/py-progspace.c: Use C++ exception handling.
11075         * python/py-prettyprint.c: Use C++ exception handling.
11076         * python/py-param.c: Use C++ exception handling.
11077         * python/py-objfile.c: Use C++ exception handling.
11078         * python/py-linetable.c: Use C++ exception handling.
11079         * python/py-lazy-string.c: Use C++ exception handling.
11080         * python/py-infthread.c: Use C++ exception handling.
11081         * python/py-inferior.c: Use C++ exception handling.
11082         * python/py-gdb-readline.c: Use C++ exception handling.
11083         * python/py-framefilter.c: Use C++ exception handling.
11084         * python/py-frame.c: Use C++ exception handling.
11085         * python/py-finishbreakpoint.c: Use C++ exception handling.
11086         * python/py-cmd.c: Use C++ exception handling.
11087         * python/py-breakpoint.c: Use C++ exception handling.
11088         * python/py-arch.c: Use C++ exception handling.
11089         * printcmd.c: Use C++ exception handling.
11090         * ppc-linux-tdep.c: Use C++ exception handling.
11091         * parse.c: Use C++ exception handling.
11092         * p-valprint.c: Use C++ exception handling.
11093         * objc-lang.c: Use C++ exception handling.
11094         * mi/mi-main.c: Use C++ exception handling.
11095         * mi/mi-interp.c: Use C++ exception handling.
11096         * mi/mi-cmd-stack.c: Use C++ exception handling.
11097         * mi/mi-cmd-break.c: Use C++ exception handling.
11098         * main.c: Use C++ exception handling.
11099         * linux-thread-db.c: Use C++ exception handling.
11100         * linux-tdep.c: Use C++ exception handling.
11101         * linux-nat.c: Use C++ exception handling.
11102         * linux-fork.c: Use C++ exception handling.
11103         * linespec.c: Use C++ exception handling.
11104         * language.c: Use C++ exception handling.
11105         * jit.c: Use C++ exception handling.
11106         * infrun.c: Use C++ exception handling.
11107         * infcmd.c: Use C++ exception handling.
11108         * infcall.c: Use C++ exception handling.
11109         * inf-loop.c: Use C++ exception handling.
11110         * i386-tdep.c: Use C++ exception handling.
11111         * i386-linux-tdep.c: Use C++ exception handling.
11112         * guile/scm-value.c: Use C++ exception handling.
11113         * guile/scm-type.c: Use C++ exception handling.
11114         * guile/scm-symtab.c: Use C++ exception handling.
11115         * guile/scm-symbol.c: Use C++ exception handling.
11116         * guile/scm-pretty-print.c: Use C++ exception handling.
11117         * guile/scm-ports.c: Use C++ exception handling.
11118         * guile/scm-param.c: Use C++ exception handling.
11119         * guile/scm-math.c: Use C++ exception handling.
11120         * guile/scm-lazy-string.c: Use C++ exception handling.
11121         * guile/scm-frame.c: Use C++ exception handling.
11122         * guile/scm-disasm.c: Use C++ exception handling.
11123         * guile/scm-cmd.c: Use C++ exception handling.
11124         * guile/scm-breakpoint.c: Use C++ exception handling.
11125         * guile/scm-block.c: Use C++ exception handling.
11126         * guile/guile-internal.h: Use C++ exception handling.
11127         * gnu-v3-abi.c: Use C++ exception handling.
11128         * gdbtypes.c: Use C++ exception handling.
11129         * frame.c: Use C++ exception handling.
11130         * frame-unwind.c: Use C++ exception handling.
11131         * fbsd-tdep.c: Use C++ exception handling.
11132         * f-valprint.c: Use C++ exception handling.
11133         * exec.c: Use C++ exception handling.
11134         * event-top.c: Use C++ exception handling.
11135         * event-loop.c: Use C++ exception handling.
11136         * eval.c: Use C++ exception handling.
11137         * dwarf2read.c: Use C++ exception handling.
11138         * dwarf2loc.c: Use C++ exception handling.
11139         * dwarf2-frame.c: Use C++ exception handling.
11140         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11141         * dwarf-index-write.c: Use C++ exception handling.
11142         * dwarf-index-cache.c: Use C++ exception handling.
11143         * dtrace-probe.c: Use C++ exception handling.
11144         * disasm-selftests.c: Use C++ exception handling.
11145         * darwin-nat.c: Use C++ exception handling.
11146         * cp-valprint.c: Use C++ exception handling.
11147         * cp-support.c: Use C++ exception handling.
11148         * cp-abi.c: Use C++ exception handling.
11149         * corelow.c: Use C++ exception handling.
11150         * completer.c: Use C++ exception handling.
11151         * compile/compile-object-run.c: Use C++ exception handling.
11152         * compile/compile-object-load.c: Use C++ exception handling.
11153         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11154         * compile/compile-c-symbols.c: Use C++ exception handling.
11155         * common/selftest.c: Use C++ exception handling.
11156         * common/new-op.c: Use C++ exception handling.
11157         * cli/cli-script.c: Use C++ exception handling.
11158         * cli/cli-interp.c: Use C++ exception handling.
11159         * cli/cli-cmds.c: Use C++ exception handling.
11160         * c-varobj.c: Use C++ exception handling.
11161         * btrace.c: Use C++ exception handling.
11162         * breakpoint.c: Use C++ exception handling.
11163         * break-catch-throw.c: Use C++ exception handling.
11164         * arch-utils.c: Use C++ exception handling.
11165         * amd64-tdep.c: Use C++ exception handling.
11166         * ada-valprint.c: Use C++ exception handling.
11167         * ada-typeprint.c: Use C++ exception handling.
11168         * ada-lang.c: Use C++ exception handling.
11169         * aarch64-tdep.c: Use C++ exception handling.
11170
11171 2019-04-08  Tom Tromey  <tom@tromey.com>
11172
11173         * xml-support.c (gdb_xml_parser::parse): Update.
11174         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11175         * value.c (show_convenience): Update.
11176         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11177         (test_parse_flags_qcs): Update.
11178         * thread.c (thr_try_catch_cmd): Update.
11179         * target.c (target_translate_tls_address): Update.
11180         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11181         (info_frame_command_core, frame_apply_command_count): Update.
11182         * rust-exp.y (rust_lex_exception_test): Update.
11183         * riscv-tdep.c (riscv_print_one_register_info): Update.
11184         * remote.c (remote_target::enable_btrace): Update.
11185         * record-btrace.c (record_btrace_enable_warn): Update.
11186         * python/py-utils.c (gdbpy_convert_exception): Update.
11187         * printcmd.c (do_one_display, print_variable_and_value): Update.
11188         * mi/mi-main.c (mi_print_exception): Update.
11189         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11190         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11191         * linux-nat.c (linux_nat_target::attach): Update.
11192         * linux-fork.c (class scoped_switch_fork_info): Update.
11193         * infrun.c (displaced_step_prepare): Update.
11194         * infcall.c (call_function_by_hand_dummy): Update.
11195         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11196         * gnu-v3-abi.c (print_one_vtable): Update.
11197         * frame.c (get_prev_frame_always): Update.
11198         * f-valprint.c (info_common_command_for_block): Update.
11199         * exec.c (try_open_exec_file): Update.
11200         * exceptions.c (print_exception, exception_print)
11201         (exception_fprintf, exception_print_same): Update.
11202         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11203         * dwarf-index-cache.c (index_cache::store)
11204         (index_cache::lookup_gdb_index): Update.
11205         * darwin-nat.c (maybe_cache_shell): Update.
11206         * cp-valprint.c (cp_print_value_fields): Update.
11207         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11208         (gcc_cplus_symbol_address): Update.
11209         * compile/compile-c-symbols.c (gcc_convert_symbol)
11210         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11211         * common/selftest.c: Update.
11212         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11213         a std::string.
11214         (exception_try_scope_entry, exception_try_scope_exit): Don't
11215         declare.
11216         (struct exception_try_scope): Remove.
11217         (TRY): Don't use exception_try_scope.
11218         (struct gdb_exception): Add constructor, operator=.
11219         <what>: New method.
11220         (struct gdb_exception_RETURN_MASK_ALL)
11221         (struct gdb_exception_RETURN_MASK_ERROR)
11222         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11223         (struct gdb_quit_bad_alloc): Update.
11224         * common/common-exceptions.c (exception_none): Change
11225         initializer.
11226         (struct catcher) <state, exception>: Initialize inline.
11227         <prev>: Remove member.
11228         (current_catcher): Remove.
11229         (catchers): New global.
11230         (exceptions_state_mc_init): Simplify.
11231         (catcher_pop): Remove.
11232         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11233         (try_scope_depth, exception_try_scope_entry)
11234         (exception_try_scope_exit): Remove.
11235         (throw_exception_sjlj): Update.
11236         (exception_messages, exception_messages_size): Remove.
11237         (throw_it): Simplify.
11238         (gdb_exception_sliced_copy): Remove.
11239         (throw_exception_cxx): Update.
11240         * cli/cli-script.c (script_from_file): Update.
11241         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11242         Update.
11243         * ada-valprint.c (ada_val_print): Update.
11244         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11245         (create_excep_cond_exprs): Update.
11246
11247 2019-04-08  Tom Tromey  <tom@tromey.com>
11248
11249         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11250         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11251         (TRY, CATCH, END_CATCH): Remove some definitions.
11252         * common/common-exceptions.c: Don't use GDB_XCPT.
11253         (catcher_list_size): Remove.
11254         (throw_exception, throw_it): Simplify.
11255
11256 2019-04-05  Tom Tromey  <tom@tromey.com>
11257
11258         Revert the header-sorting patch.
11259         * ft32-tdep.c: Revert.
11260         * frv-tdep.c: Revert.
11261         * frv-linux-tdep.c: Revert.
11262         * frame.c: Revert.
11263         * frame-unwind.c: Revert.
11264         * frame-base.c: Revert.
11265         * fork-child.c: Revert.
11266         * findvar.c: Revert.
11267         * findcmd.c: Revert.
11268         * filesystem.c: Revert.
11269         * filename-seen-cache.h: Revert.
11270         * filename-seen-cache.c: Revert.
11271         * fbsd-tdep.c: Revert.
11272         * fbsd-nat.h: Revert.
11273         * fbsd-nat.c: Revert.
11274         * f-valprint.c: Revert.
11275         * f-typeprint.c: Revert.
11276         * f-lang.c: Revert.
11277         * extension.h: Revert.
11278         * extension.c: Revert.
11279         * extension-priv.h: Revert.
11280         * expprint.c: Revert.
11281         * exec.h: Revert.
11282         * exec.c: Revert.
11283         * exceptions.c: Revert.
11284         * event-top.c: Revert.
11285         * event-loop.c: Revert.
11286         * eval.c: Revert.
11287         * elfread.c: Revert.
11288         * dwarf2read.h: Revert.
11289         * dwarf2read.c: Revert.
11290         * dwarf2loc.c: Revert.
11291         * dwarf2expr.h: Revert.
11292         * dwarf2expr.c: Revert.
11293         * dwarf2-frame.c: Revert.
11294         * dwarf2-frame-tailcall.c: Revert.
11295         * dwarf-index-write.h: Revert.
11296         * dwarf-index-write.c: Revert.
11297         * dwarf-index-common.c: Revert.
11298         * dwarf-index-cache.h: Revert.
11299         * dwarf-index-cache.c: Revert.
11300         * dummy-frame.c: Revert.
11301         * dtrace-probe.c: Revert.
11302         * disasm.h: Revert.
11303         * disasm.c: Revert.
11304         * disasm-selftests.c: Revert.
11305         * dictionary.c: Revert.
11306         * dicos-tdep.c: Revert.
11307         * demangle.c: Revert.
11308         * dcache.h: Revert.
11309         * dcache.c: Revert.
11310         * darwin-nat.h: Revert.
11311         * darwin-nat.c: Revert.
11312         * darwin-nat-info.c: Revert.
11313         * d-valprint.c: Revert.
11314         * d-namespace.c: Revert.
11315         * d-lang.c: Revert.
11316         * ctf.c: Revert.
11317         * csky-tdep.c: Revert.
11318         * csky-linux-tdep.c: Revert.
11319         * cris-tdep.c: Revert.
11320         * cris-linux-tdep.c: Revert.
11321         * cp-valprint.c: Revert.
11322         * cp-support.c: Revert.
11323         * cp-namespace.c: Revert.
11324         * cp-abi.c: Revert.
11325         * corelow.c: Revert.
11326         * corefile.c: Revert.
11327         * continuations.c: Revert.
11328         * completer.h: Revert.
11329         * completer.c: Revert.
11330         * complaints.c: Revert.
11331         * coffread.c: Revert.
11332         * coff-pe-read.c: Revert.
11333         * cli-out.h: Revert.
11334         * cli-out.c: Revert.
11335         * charset.c: Revert.
11336         * c-varobj.c: Revert.
11337         * c-valprint.c: Revert.
11338         * c-typeprint.c: Revert.
11339         * c-lang.c: Revert.
11340         * buildsym.c: Revert.
11341         * buildsym-legacy.c: Revert.
11342         * build-id.h: Revert.
11343         * build-id.c: Revert.
11344         * btrace.c: Revert.
11345         * bsd-uthread.c: Revert.
11346         * breakpoint.h: Revert.
11347         * breakpoint.c: Revert.
11348         * break-catch-throw.c: Revert.
11349         * break-catch-syscall.c: Revert.
11350         * break-catch-sig.c: Revert.
11351         * blockframe.c: Revert.
11352         * block.c: Revert.
11353         * bfin-tdep.c: Revert.
11354         * bfin-linux-tdep.c: Revert.
11355         * bfd-target.c: Revert.
11356         * bcache.c: Revert.
11357         * ax-general.c: Revert.
11358         * ax-gdb.h: Revert.
11359         * ax-gdb.c: Revert.
11360         * avr-tdep.c: Revert.
11361         * auxv.c: Revert.
11362         * auto-load.c: Revert.
11363         * arm-wince-tdep.c: Revert.
11364         * arm-tdep.c: Revert.
11365         * arm-symbian-tdep.c: Revert.
11366         * arm-pikeos-tdep.c: Revert.
11367         * arm-obsd-tdep.c: Revert.
11368         * arm-nbsd-tdep.c: Revert.
11369         * arm-nbsd-nat.c: Revert.
11370         * arm-linux-tdep.c: Revert.
11371         * arm-linux-nat.c: Revert.
11372         * arm-fbsd-tdep.c: Revert.
11373         * arm-fbsd-nat.c: Revert.
11374         * arm-bsd-tdep.c: Revert.
11375         * arch-utils.c: Revert.
11376         * arc-tdep.c: Revert.
11377         * arc-newlib-tdep.c: Revert.
11378         * annotate.h: Revert.
11379         * annotate.c: Revert.
11380         * amd64-windows-tdep.c: Revert.
11381         * amd64-windows-nat.c: Revert.
11382         * amd64-tdep.c: Revert.
11383         * amd64-sol2-tdep.c: Revert.
11384         * amd64-obsd-tdep.c: Revert.
11385         * amd64-obsd-nat.c: Revert.
11386         * amd64-nbsd-tdep.c: Revert.
11387         * amd64-nbsd-nat.c: Revert.
11388         * amd64-nat.c: Revert.
11389         * amd64-linux-tdep.c: Revert.
11390         * amd64-linux-nat.c: Revert.
11391         * amd64-fbsd-tdep.c: Revert.
11392         * amd64-fbsd-nat.c: Revert.
11393         * amd64-dicos-tdep.c: Revert.
11394         * amd64-darwin-tdep.c: Revert.
11395         * amd64-bsd-nat.c: Revert.
11396         * alpha-tdep.c: Revert.
11397         * alpha-obsd-tdep.c: Revert.
11398         * alpha-nbsd-tdep.c: Revert.
11399         * alpha-mdebug-tdep.c: Revert.
11400         * alpha-linux-tdep.c: Revert.
11401         * alpha-linux-nat.c: Revert.
11402         * alpha-bsd-tdep.c: Revert.
11403         * alpha-bsd-nat.c: Revert.
11404         * aix-thread.c: Revert.
11405         * agent.c: Revert.
11406         * addrmap.c: Revert.
11407         * ada-varobj.c: Revert.
11408         * ada-valprint.c: Revert.
11409         * ada-typeprint.c: Revert.
11410         * ada-tasks.c: Revert.
11411         * ada-lang.c: Revert.
11412         * aarch64-tdep.c: Revert.
11413         * aarch64-ravenscar-thread.c: Revert.
11414         * aarch64-newlib-tdep.c: Revert.
11415         * aarch64-linux-tdep.c: Revert.
11416         * aarch64-linux-nat.c: Revert.
11417         * aarch64-fbsd-tdep.c: Revert.
11418         * aarch64-fbsd-nat.c: Revert.
11419         * aarch32-linux-nat.c: Revert.
11420
11421 2019-04-05  Tom Tromey  <tom@tromey.com>
11422
11423         * ft32-tdep.c: Sort headers.
11424         * frv-tdep.c: Sort headers.
11425         * frv-linux-tdep.c: Sort headers.
11426         * frame.c: Sort headers.
11427         * frame-unwind.c: Sort headers.
11428         * frame-base.c: Sort headers.
11429         * fork-child.c: Sort headers.
11430         * findvar.c: Sort headers.
11431         * findcmd.c: Sort headers.
11432         * filesystem.c: Sort headers.
11433         * filename-seen-cache.h: Sort headers.
11434         * filename-seen-cache.c: Sort headers.
11435         * fbsd-tdep.c: Sort headers.
11436         * fbsd-nat.h: Sort headers.
11437         * fbsd-nat.c: Sort headers.
11438         * f-valprint.c: Sort headers.
11439         * f-typeprint.c: Sort headers.
11440         * f-lang.c: Sort headers.
11441         * extension.h: Sort headers.
11442         * extension.c: Sort headers.
11443         * extension-priv.h: Sort headers.
11444         * expprint.c: Sort headers.
11445         * exec.h: Sort headers.
11446         * exec.c: Sort headers.
11447         * exceptions.c: Sort headers.
11448         * event-top.c: Sort headers.
11449         * event-loop.c: Sort headers.
11450         * eval.c: Sort headers.
11451         * elfread.c: Sort headers.
11452         * dwarf2read.h: Sort headers.
11453         * dwarf2read.c: Sort headers.
11454         * dwarf2loc.c: Sort headers.
11455         * dwarf2expr.h: Sort headers.
11456         * dwarf2expr.c: Sort headers.
11457         * dwarf2-frame.c: Sort headers.
11458         * dwarf2-frame-tailcall.c: Sort headers.
11459         * dwarf-index-write.h: Sort headers.
11460         * dwarf-index-write.c: Sort headers.
11461         * dwarf-index-common.c: Sort headers.
11462         * dwarf-index-cache.h: Sort headers.
11463         * dwarf-index-cache.c: Sort headers.
11464         * dummy-frame.c: Sort headers.
11465         * dtrace-probe.c: Sort headers.
11466         * disasm.h: Sort headers.
11467         * disasm.c: Sort headers.
11468         * disasm-selftests.c: Sort headers.
11469         * dictionary.c: Sort headers.
11470         * dicos-tdep.c: Sort headers.
11471         * demangle.c: Sort headers.
11472         * dcache.h: Sort headers.
11473         * dcache.c: Sort headers.
11474         * darwin-nat.h: Sort headers.
11475         * darwin-nat.c: Sort headers.
11476         * darwin-nat-info.c: Sort headers.
11477         * d-valprint.c: Sort headers.
11478         * d-namespace.c: Sort headers.
11479         * d-lang.c: Sort headers.
11480         * ctf.c: Sort headers.
11481         * csky-tdep.c: Sort headers.
11482         * csky-linux-tdep.c: Sort headers.
11483         * cris-tdep.c: Sort headers.
11484         * cris-linux-tdep.c: Sort headers.
11485         * cp-valprint.c: Sort headers.
11486         * cp-support.c: Sort headers.
11487         * cp-namespace.c: Sort headers.
11488         * cp-abi.c: Sort headers.
11489         * corelow.c: Sort headers.
11490         * corefile.c: Sort headers.
11491         * continuations.c: Sort headers.
11492         * completer.h: Sort headers.
11493         * completer.c: Sort headers.
11494         * complaints.c: Sort headers.
11495         * coffread.c: Sort headers.
11496         * coff-pe-read.c: Sort headers.
11497         * cli-out.h: Sort headers.
11498         * cli-out.c: Sort headers.
11499         * charset.c: Sort headers.
11500         * c-varobj.c: Sort headers.
11501         * c-valprint.c: Sort headers.
11502         * c-typeprint.c: Sort headers.
11503         * c-lang.c: Sort headers.
11504         * buildsym.c: Sort headers.
11505         * buildsym-legacy.c: Sort headers.
11506         * build-id.h: Sort headers.
11507         * build-id.c: Sort headers.
11508         * btrace.c: Sort headers.
11509         * bsd-uthread.c: Sort headers.
11510         * breakpoint.h: Sort headers.
11511         * breakpoint.c: Sort headers.
11512         * break-catch-throw.c: Sort headers.
11513         * break-catch-syscall.c: Sort headers.
11514         * break-catch-sig.c: Sort headers.
11515         * blockframe.c: Sort headers.
11516         * block.c: Sort headers.
11517         * bfin-tdep.c: Sort headers.
11518         * bfin-linux-tdep.c: Sort headers.
11519         * bfd-target.c: Sort headers.
11520         * bcache.c: Sort headers.
11521         * ax-general.c: Sort headers.
11522         * ax-gdb.h: Sort headers.
11523         * ax-gdb.c: Sort headers.
11524         * avr-tdep.c: Sort headers.
11525         * auxv.c: Sort headers.
11526         * auto-load.c: Sort headers.
11527         * arm-wince-tdep.c: Sort headers.
11528         * arm-tdep.c: Sort headers.
11529         * arm-symbian-tdep.c: Sort headers.
11530         * arm-pikeos-tdep.c: Sort headers.
11531         * arm-obsd-tdep.c: Sort headers.
11532         * arm-nbsd-tdep.c: Sort headers.
11533         * arm-nbsd-nat.c: Sort headers.
11534         * arm-linux-tdep.c: Sort headers.
11535         * arm-linux-nat.c: Sort headers.
11536         * arm-fbsd-tdep.c: Sort headers.
11537         * arm-fbsd-nat.c: Sort headers.
11538         * arm-bsd-tdep.c: Sort headers.
11539         * arch-utils.c: Sort headers.
11540         * arc-tdep.c: Sort headers.
11541         * arc-newlib-tdep.c: Sort headers.
11542         * annotate.h: Sort headers.
11543         * annotate.c: Sort headers.
11544         * amd64-windows-tdep.c: Sort headers.
11545         * amd64-windows-nat.c: Sort headers.
11546         * amd64-tdep.c: Sort headers.
11547         * amd64-sol2-tdep.c: Sort headers.
11548         * amd64-obsd-tdep.c: Sort headers.
11549         * amd64-obsd-nat.c: Sort headers.
11550         * amd64-nbsd-tdep.c: Sort headers.
11551         * amd64-nbsd-nat.c: Sort headers.
11552         * amd64-nat.c: Sort headers.
11553         * amd64-linux-tdep.c: Sort headers.
11554         * amd64-linux-nat.c: Sort headers.
11555         * amd64-fbsd-tdep.c: Sort headers.
11556         * amd64-fbsd-nat.c: Sort headers.
11557         * amd64-dicos-tdep.c: Sort headers.
11558         * amd64-darwin-tdep.c: Sort headers.
11559         * amd64-bsd-nat.c: Sort headers.
11560         * alpha-tdep.c: Sort headers.
11561         * alpha-obsd-tdep.c: Sort headers.
11562         * alpha-nbsd-tdep.c: Sort headers.
11563         * alpha-mdebug-tdep.c: Sort headers.
11564         * alpha-linux-tdep.c: Sort headers.
11565         * alpha-linux-nat.c: Sort headers.
11566         * alpha-bsd-tdep.c: Sort headers.
11567         * alpha-bsd-nat.c: Sort headers.
11568         * aix-thread.c: Sort headers.
11569         * agent.c: Sort headers.
11570         * addrmap.c: Sort headers.
11571         * ada-varobj.c: Sort headers.
11572         * ada-valprint.c: Sort headers.
11573         * ada-typeprint.c: Sort headers.
11574         * ada-tasks.c: Sort headers.
11575         * ada-lang.c: Sort headers.
11576         * aarch64-tdep.c: Sort headers.
11577         * aarch64-ravenscar-thread.c: Sort headers.
11578         * aarch64-newlib-tdep.c: Sort headers.
11579         * aarch64-linux-tdep.c: Sort headers.
11580         * aarch64-linux-nat.c: Sort headers.
11581         * aarch64-fbsd-tdep.c: Sort headers.
11582         * aarch64-fbsd-nat.c: Sort headers.
11583         * aarch32-linux-nat.c: Sort headers.
11584
11585 2019-04-04  Tom Tromey  <tom@tromey.com>
11586
11587         * varobj.c (varobj_create): Update.
11588         * rust-exp.y (struct rust_parser) <update_innermost_block,
11589         lookup_symbol>: New methods.
11590         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11591         Rename.
11592         (rust_parser::rust_lookup_type)
11593         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11594         * printcmd.c (display_command, do_one_display): Update.
11595         * parser-defs.h (struct parser_state) <parser_state>: Add
11596         "tracker" parameter.
11597         (block_tracker): New member.
11598         (class innermost_block_tracker) <innermost_block_tracker>: Add
11599         "types" parameter.
11600         <reset>: Remove method.
11601         (innermost_block): Don't declare.
11602         (null_post_parser): Update.
11603         * parse.c (innermost_block): Remove global.
11604         (write_dollar_variable): Update.
11605         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11606         Remove "tracker_types" parameter.
11607         (parse_expression): Add "tracker" parameter.
11608         (parse_expression_for_completion): Update.
11609         (null_post_parser): Add "tracker" parameter.
11610         * p-exp.y: Update rules.
11611         * m2-exp.y: Update rules.
11612         * language.h (struct language_defn) <la_post_parser>: Add
11613         "tracker" parameter.
11614         * go-exp.y: Update rules.
11615         * f-exp.y: Update rules.
11616         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11617         parameter.
11618         * d-exp.y: Update rules.
11619         * c-exp.y: Update rules.
11620         * breakpoint.c (set_breakpoint_condition): Create an
11621         innermost_block_tracker.
11622         (watch_command_1): Likewise.
11623         * ada-lang.c (resolve): Add "tracker" parameter.
11624         (resolve_subexp): Likewise.
11625         * ada-exp.y (write_var_from_sym): Update.
11626
11627 2019-04-04  Tom Tromey  <tom@tromey.com>
11628
11629         * type-stack.h: New file.
11630         * type-stack.c: New file.
11631         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11632         type-stack.h.
11633         (insert_into_type_stack, insert_type, push_type, push_type_int)
11634         (insert_type_address_space, pop_type, pop_type_int)
11635         (pop_typelist, pop_type_stack, append_type_stack)
11636         (push_type_stack, get_type_stack, push_typelist)
11637         (follow_type_instance_flags, follow_types): Don't declare.
11638         * parse.c (type_stack): Remove global.
11639         (parse_exp_in_context): Update.
11640         (insert_into_type_stack, insert_type, push_type, push_type_int)
11641         (insert_type_address_space, pop_type, pop_type_int)
11642         (pop_typelist, pop_type_stack, append_type_stack)
11643         (push_type_stack, get_type_stack, push_typelist)
11644         (follow_type_instance_flags, follow_types): Remove (moved to
11645         type-stack.c).
11646         * f-exp.y (type_stack): New global.
11647         Update rules.
11648         (push_kind_type, f_parse): Update.
11649         * d-exp.y (type_stack): New global.
11650         Update rules.
11651         (d_parse): Update.
11652         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11653         Update rules.
11654         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11655         (HFILES_NO_SRCDIR): Add type-stack.h.
11656
11657 2019-04-04  Tom Tromey  <tom@tromey.com>
11658
11659         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11660         (rust_parser::convert_ast_to_expression, rust_parse)
11661         (rust_lex_test_completion, rust_lex_tests): Update.
11662         * parser-defs.h (struct expr_completion_state): New.
11663         (struct parser_state) <parser_state>: Add completion parameter.
11664         <mark_struct_expression, mark_completion_tag>: New methods.
11665         <parse_completion, m_completion_state>: New members.
11666         (prefixify_expression, null_post_parser): Update.
11667         (mark_struct_expression, mark_completion_tag): Don't declare.
11668         * parse.c (parse_completion, expout_last_struct)
11669         (expout_tag_completion_type, expout_completion_name): Remove
11670         globals.
11671         (parser_state::mark_struct_expression)
11672         (parser_state::mark_completion_tag): Now methods.
11673         (prefixify_expression): Add last_struct parameter.
11674         (prefixify_subexp): Likewise.
11675         (parse_exp_1): Update.
11676         (parse_exp_in_context): Add cstate parameter.  Update.
11677         (parse_expression_for_completion): Create an
11678         expr_completion_state.
11679         (null_post_parser): Add "completion" parameter.
11680         * p-exp.y: Update rules.
11681         (yylex): Update.
11682         * language.h (struct language_defn) <la_post_parser>: Add
11683         "completing" parameter.
11684         * go-exp.y: Update rules.
11685         (lex_one_token): Update.
11686         * expression.h (parse_completion): Don't declare.
11687         * d-exp.y: Update rules.
11688         (lex_one_token): Update rules.
11689         * c-exp.y: Update rules.
11690         (lex_one_token): Update.
11691         * ada-lang.c (resolve): Add "parse_completion" parameter.
11692         (resolve_subexp): Likewise.
11693         (ada_resolve_function): Likewise.
11694
11695 2019-04-04  Tom Tromey  <tom@tromey.com>
11696
11697         * parser-defs.h (struct parser_state) <start_arglist,
11698         end_arglist>: New methods.
11699         <arglist_len, m_funcall_chain>: New members.
11700         (arglist_len, start_arglist, end_arglist): Don't declare.
11701         * parse.c (arglist_len, funcall_chain): Remove global.
11702         (start_arglist, end_arglist): Remove functions.
11703         (parse_exp_in_context): Update.
11704         * p-exp.y: Update rules.
11705         * m2-exp.y: Update rules.
11706         * go-exp.y: Update rules.
11707         * f-exp.y: Update rules.
11708         * d-exp.y: Update rules.
11709         * c-exp.y: Update rules.
11710
11711 2019-04-04  Tom Tromey  <tom@tromey.com>
11712
11713         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11714         lex_operator, push_back>: New methods.
11715         Update all rules.
11716         (rust_parser::lex_hex, lex_escape): Rename and update.
11717         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11718         (rust_parser::lex_operator): Rename and update.
11719         (rust_parser::lex_number, rustyylex, rustyyerror)
11720         (rust_lex_test_init, rust_lex_test_sequence)
11721         (rust_lex_test_push_back, rust_lex_tests): Update.
11722         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11723         parameter.
11724         <lexptr, prev_lexptr>: New members.
11725         (lexptr, prev_lexptr): Don't declare.
11726         * parse.c (lexptr, prev_lexptr): Remove globals.
11727         (parse_exp_in_context): Update.
11728         * p-exp.y (yylex, yyerror): Update.
11729         * m2-exp.y (parse_number, yylex, yyerror): Update.
11730         * go-exp.y (lex_one_token, yyerror): Update.
11731         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11732         * d-exp.y (lex_one_token, yyerror): Update.
11733         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11734         (lex_one_token, yyerror): Update.
11735         * ada-lex.l (YY_INPUT): Update.
11736         (rewind_to_char): Update.
11737         * ada-exp.y (yyerror): Update.
11738
11739 2019-04-04  Tom Tromey  <tom@tromey.com>
11740
11741         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11742         * parser-defs.h (struct parser_state) <parser_state>: Add new
11743         parameter.
11744         <comma_terminates>: New member.
11745         (comma_terminates): Don't declare global.
11746         * parse.c (comma_terminates): Remove global.
11747         (parse_exp_in_context): Update.
11748         * p-exp.y (yylex): Update.
11749         * m2-exp.y (yylex): Update.
11750         * go-exp.y (lex_one_token): Update.
11751         * f-exp.y (yylex): Update.
11752         * d-exp.y (lex_one_token): Update.
11753         * c-exp.y (lex_one_token): Update.
11754         * ada-lex.l: Update.
11755
11756 2019-04-04  Tom Tromey  <tom@tromey.com>
11757
11758         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11759         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11760         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11761         * parser-defs.h (paren_depth): Don't declare.
11762         * parse.c (paren_depth): Remove global.
11763         (parse_exp_in_context): Update.
11764         * p-exp.y (paren_depth): New global.
11765         (pascal_parse): Initialize it.
11766         * m2-exp.y (paren_depth): New global.
11767         (m2_parse): Initialize it.
11768         * go-exp.y (paren_depth): New global.
11769         (go_parse): Initialize it.
11770         * f-exp.y (paren_depth): New global.
11771         (f_parse): Initialize it.
11772         * d-exp.y (paren_depth): New global.
11773         (d_parse): Initialize it.
11774         * c-exp.y (paren_depth): New global.
11775         (c_parse): Initialize it.
11776         * ada-lex.l (paren_depth): New global.
11777         (lexer_init): Initialize it.
11778
11779 2019-04-04  Tom Tromey  <tom@tromey.com>
11780
11781         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11782         (rust_parser::convert_ast_to_type)
11783         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11784         * parser-defs.h (struct parser_state) <parser_state>: Add
11785         parameters.  Initialize new members.
11786         <expression_context_block, expression_context_pc>: New members.
11787         * parse.c (expression_context_block, expression_context_pc):
11788         Remove globals.
11789         (parse_exp_in_context): Update.
11790         * p-exp.y: Update all rules.
11791         (yylex): Update.
11792         * m2-exp.y: Update all rules.
11793         (yylex): Update.
11794         * go-exp.y (yylex): Update.
11795         * f-exp.y (yylex): Update.
11796         * d-exp.y: Update all rules.
11797         (yylex): Update.
11798         * c-exp.y: Update all rules.
11799         (lex_one_token, classify_name, yylex, c_parse): Update.
11800         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11801
11802 2019-04-04  Tom Tromey  <tom@tromey.com>
11803
11804         * gdbarch.h, gdbarch.c: Rebuild.
11805         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11806         * stap-probe.h:
11807         (struct stap_parse_info): Replace "parser_state" with
11808         "expr_builder".
11809         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11810         (parser_state): New class.
11811         * parse.c (expr_builder): Rename.
11812         (expr_builder::release): Rename.
11813         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11814         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11815         (write_exp_elt_longcst, write_exp_elt_floatcst)
11816         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11817         (write_exp_string_vector, write_exp_bitstring)
11818         (write_exp_msymbol, mark_struct_expression)
11819         (write_dollar_variable)
11820         (insert_type_address_space, increase_expout_size): Replace
11821         "parser_state" with "expr_builder".
11822         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11823         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11824         "parser_state" with "expr_builder".
11825
11826 2019-04-04  Tom Tromey  <tom@tromey.com>
11827
11828         * rust-exp.y: Replace "parse_language" with method call.
11829         * p-exp.y:
11830         (yylex): Replace "parse_language" with method call.
11831         * m2-exp.y:
11832         (yylex): Replace "parse_language" with method call.
11833         * go-exp.y (classify_name): Replace "parse_language" with method
11834         call.
11835         * f-exp.y (yylex): Replace "parse_language" with method call.
11836         * d-exp.y (lex_one_token): Replace "parse_language" with method
11837         call.
11838         * c-exp.y:
11839         (lex_one_token, classify_name, yylex): Replace "parse_language"
11840         with method call.
11841         * ada-exp.y (find_primitive_type, type_char)
11842         (type_system_address): Replace "parse_language" with method call.
11843
11844 2019-04-04  Tom Tromey  <tom@tromey.com>
11845
11846         * rust-exp.y: Replace "parse_gdbarch" with method call.
11847         * parse.c (write_dollar_variable, insert_type_address_space):
11848         Replace "parse_gdbarch" with method call.
11849         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11850         call.
11851         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11852         call.
11853         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11854         "parse_gdbarch" with method call.
11855         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11856         with method call.
11857         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11858         "parse_gdbarch" with method call.
11859         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11860         "parse_gdbarch" with method call.
11861         * c-exp.y (parse_type, parse_number, classify_name): Replace
11862         "parse_gdbarch" with method call.
11863         * ada-lex.l: Replace "parse_gdbarch" with method call.
11864         * ada-exp.y (parse_type, find_primitive_type, type_char)
11865         (type_system_address): Replace "parse_gdbarch" with method call.
11866
11867 2019-04-04  Tom Tromey  <tom@tromey.com>
11868
11869         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11870         * stap-probe.c (stap_parse_argument): Update.
11871         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11872         initial_size parameter.
11873         * rust-exp.y (rust_lex_tests): Update.
11874         * parse.c (parser_state): Update.
11875         (parse_exp_in_context): Update.
11876         * parser-defs.h (struct parser_state) <parser_state>: Remove
11877         "initial_size" parameter.
11878
11879 2019-04-04  Tom Tromey  <tom@tromey.com>
11880
11881         * parser-defs.h (increase_expout_size): Don't declare.
11882         * parse.c (increase_expout_size): Now static.
11883
11884 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11885
11886         * gnu-nat.c (gnu_nat_target::wait): Fix
11887         target_waitstatus_to_string call.
11888
11889 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11890
11891         * eval.c (evaluate_subexp_standard): Handle internal functions
11892         during Fortran function call handling.
11893
11894 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11895
11896         * NEWS: Mention new internal functions.
11897         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11898         (read_base_type): Use dwarf2_init_complex_target_type.
11899         * value.c (creal_internal_fn): New function.
11900         (cimag_internal_fn): New function.
11901         (_initialize_values): Register new internal functions.
11902
11903 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11904
11905         * infrun.c (stop_all_threads): If debug_infrun, always
11906         trace the wait status after wait_one, using
11907         target_waitstatus_to_string and target_pid_to_str.
11908         (handle_inferior_event): Replace various trace of
11909         wait status kind by a single trace.
11910         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11911         wait status kind image by target_waitstatus_to_string.
11912         * target/waitstatus.c (target_waitstatus_to_string): Fix
11913         obsolete comment.
11914
11915 2019-04-01  Tom Tromey  <tromey@adacore.com>
11916
11917         PR symtab/23331:
11918         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11919
11920 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11921             Pedro Alves  <palves@redhat.com>
11922
11923         * top.c (quit_force): Call 'finalize_values'.
11924         * value.c (finalize_values): New function.
11925         * value.h (finalize_values): Declare.
11926
11927 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11928
11929         * NEWS: Announce $_gdb_major and $_gdb_minor.
11930
11931         * top.c (init_gdb_version_vars): New function.
11932         (gdb_init): Call init_gdb_version_vars.
11933
11934 2019-03-29  Tom Tromey  <tromey@adacore.com>
11935
11936         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11937         help text.  Remove dead code.
11938
11939 2019-03-29  Keith Seitz  <keiths@redhat.com>
11940
11941         From Siddhesh Poyarekar:
11942         * f-lang.h (f77_get_upperbound): Return LONGEST.
11943         (f77_get_lowerbound): Likewise.
11944         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11945         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11946         print them.
11947         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11948         plongest to format print it.
11949         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11950         (f77_get_upperbound): Likewise.
11951         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11952         LOWER_BOUND to LONGEST.
11953         (f77_create_arrayprint_offset_tbl): Likewise.
11954
11955 2019-03-29  Keith Seitz  <keiths@redhat.com>
11956
11957         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11958         %s/pulongest for TYPE_LENGTH instead of %d in format
11959         strings.
11960         * ada-typerint.c (ada_print_type): Likewise.
11961         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11962         * compile/compile-c-support.c (generate_register_struct): Likewise.
11963         * gdbtypes.c (recursive_dump_type): Likewise.
11964         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11965         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11966         instead of %d in format strings.
11967         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11968         to std::min to ULONGEST.
11969         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11970         instead of %d in format strings.
11971         * tracepoint.c (info_scope_command): Likewise.
11972         * typeprint.c (print_offset_data::update)
11973         (print_offset_data::finish): Likewise.
11974         * xtensa-tdep.c (xtensa_store_return_value)
11975         (xtensa_push_dummy_call): Likewise.
11976
11977 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11978
11979         * windows-nat.c (display_selector): Fixed format specifications
11980         for 64-bit Cygwin.
11981
11982 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11983
11984         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11985
11986 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11987
11988         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11989         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11990         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11991         (nios2_linux_init_abi): Install it.
11992
11993 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11994
11995         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11996
11997 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11998
11999         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12000
12001 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12002             Tom Tromey  <tromey@adacore.com>
12003
12004         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12005
12006 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12007
12008         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12009         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12010         method to compute the bounds of range types. Also print "[evaluated]"
12011         if the bounds' values come from a dynamic evaluation.
12012
12013 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12014
12015         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12016         whitespace when pretty printing is on.
12017
12018 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12019
12020         * ppc-linux-nat.c: Add include.
12021
12022 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12023
12024         * NEWS: Mention AArch64 Pointer Authentication.
12025
12026 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12027
12028         * arm-linux-nat.c: Add include.
12029
12030 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12031
12032         * source-cache.c (source_cache::get_source_lines): Re-read
12033         fullname after calling open_source_file.
12034
12035 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12036
12037         * NEWS: Mention TLS support for FreeBSD.
12038
12039 2019-03-25  Tom Tromey  <tromey@adacore.com>
12040
12041         * minsyms.c (BUNCH_SIZE): Update comment.
12042         (~minimal_symbol_reader): Remove old comment.
12043         (compact_minimal_symbols): Update comment.
12044         (minimal_symbol_reader::install): Remove old comment.  Update
12045         other comments.
12046
12047 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12048
12049         * s390-linux-nat.c: Add include.
12050
12051 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12052
12053         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12054         Call linux_get_hwcap.
12055         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12056         Likewise.
12057         (aarch64_linux_get_hwcap): Remove function.
12058         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12059         declaration.
12060         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12061         linux_get_hwcap.
12062         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12063         * linux-tdep.c (linux_get_hwcap): Add function.
12064         (linux_get_hwcap2): Likewise.
12065         * linux-tdep.h (linux_get_hwcap): Add declaration.
12066         (linux_get_hwcap2): Likewise.
12067         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12068         (ppc_linux_get_hwcap2): Likewise.
12069         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12070         linux_get_hwcap.
12071         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12072         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12073         (ppc_linux_nat_target::read_description): Likewise.
12074         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12075         * s390-linux-nat.c: Likewise.
12076         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12077
12078 2019-03-24  Tom Tromey  <tom@tromey.com>
12079
12080         * ada-lang.c (standard_lookup): Simplify initialization.
12081         (ada_lookup_symbol_nonlocal): Simplify return.
12082         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12083         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12084         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12085         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12086         initialization.
12087         * solib.c (solib_global_lookup): Simplify.
12088         * symtab.c (null_block_symbol): Remove.
12089         (symbol_cache_lookup): Simplify returns.
12090         (lookup_language_this): Simplify returns.
12091         (lookup_symbol_aux): Simplify return.
12092         (lookup_local_symbol): Simplify returns.
12093         (lookup_global_symbol_from_objfile): Simplify return.
12094         (lookup_symbol_in_objfile_symtabs)
12095         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12096         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12097         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12098         * cp-namespace.c (cp_lookup_bare_symbol)
12099         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12100         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12101         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12102         (cp_lookup_symbol_via_imports): Simplify initialization.
12103         (find_symbol_in_baseclass): Likewise.
12104         * symtab.h (null_block_symbol): Remove.
12105         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12106         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12107         (d_lookup_symbol_module): Likewise.
12108         (find_symbol_in_baseclass): Simplify initialization.
12109
12110 2019-03-24  Tom Tromey  <tom@tromey.com>
12111
12112         * expression.h: Don't include symtab.h.
12113         (struct block): Forward declare.
12114
12115 2019-03-24  Tom Tromey  <tom@tromey.com>
12116
12117         * c-exp.y (typebase): Remove casts.
12118         * gdbtypes.c (lookup_unsigned_typename, )
12119         (lookup_signed_typename): Remove cast.
12120         * eval.c (parse_to_comma_and_eval): Remove cast.
12121         * parse.c (write_dollar_variable): Remove cast.
12122         * block.h (struct block) <superblock>: Now const.
12123         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12124         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12125         (map_block): Make "block" const.
12126         * symfile.h (struct quick_symbol_functions)
12127         <map_matching_symbols>: Constify block argument to "callback".
12128         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12129         const.
12130         (find_pc_sect_compunit_symtab): Make "b" const.
12131         (find_symbol_at_address): Likewise.
12132         (search_symbols): Likewise.
12133         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12134         (dw2_debug_names_lookup_symbol): Likewise.
12135         (dw2_map_matching_symbols): Update.
12136         * p-valprint.c (pascal_val_print): Remove "block".
12137         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12138         (aux_add_nonlocal_symbols): Make "block" const.
12139         (resolve_subexp): Remove cast.
12140         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12141         const.
12142         (iterate_over_file_blocks): Likewise.
12143         * f-exp.y (%union) <bval>: Remove.
12144         * coffread.c (patch_opaque_types): Make "b" const.
12145         * spu-tdep.c (spu_catch_start): Make "block" const.
12146         * c-valprint.c (print_unpacked_pointer): Remove "block".
12147         * symmisc.c (dump_symtab_1): Make "b" const.
12148         (block_depth): Make "block" const.
12149         * d-exp.y (%union) <bval>: Remove.
12150         * cp-support.h (cp_lookup_rtti_type): Update.
12151         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12152         * psymtab.c (psym_lookup_symbol): Make "block" const.
12153         (maintenance_check_psymtabs): Make "b" const.
12154         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12155         (enumerate_locals, enumerate_args): Update.
12156         * python/py-symtab.c (stpy_global_block): Make "block" const.
12157         (stpy_static_block): Likewise.
12158         * inline-frame.c (block_starting_point_at): Make "new_block"
12159         const.
12160         * block.c (find_block_in_blockvector): Make return type const.
12161         (blockvector_for_pc_sect): Make "b" const.
12162         (find_block_in_blockvector): Make "b" const.
12163
12164 2019-03-23  Tom Tromey  <tom@tromey.com>
12165
12166         * varobj.c (varobj_create): Update.
12167         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12168         * printcmd.c (display_command, do_one_display): Don't reset
12169         innermost_block.
12170         * parser-defs.h (enum innermost_block_tracker_type): Move to
12171         expression.h.
12172         (innermost_block): Update comment.
12173         * parse.c (parse_exp_1): Add tracker_types parameter.
12174         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12175         tracker_types parameter.  Reset innermost_block.
12176         (parse_exp_in_context): Remove.
12177         (parse_expression_for_completion): Update.
12178         * objfiles.c (~objfile): Don't reset expression_context_block or
12179         innermost_block.
12180         * expression.h (enum innermost_block_tracker_type): Move from
12181         parser-defs.h.
12182         (parse_exp_1): Add tracker_types parameter.
12183         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12184         reset innermost_block.
12185
12186 2019-03-23  Tom Tromey  <tom@tromey.com>
12187
12188         * objfiles.h: Include bcache.h.
12189
12190 2019-03-23  Tom Tromey  <tom@tromey.com>
12191
12192         * linespec.c (get_current_search_block): Use
12193         scoped_restore_current_language.
12194         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12195
12196 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12197             Jiong Wang  <jiong.wang@arm.com>
12198
12199         * aarch64-linux-tdep.c
12200         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12201         section.
12202         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12203
12204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12205             Jiong Wang  <jiong.wang@arm.com>
12206
12207         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12208         instructions.
12209         (aarch64_analyze_prologue_test): Add PACIASP test.
12210         (aarch64_prologue_prev_register): Unmask PC value.
12211
12212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12213             Jiong Wang  <jiong.wang@arm.com>
12214
12215         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12216         (aarch64_dwarf2_prev_register): Unmask PC value.
12217         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12218         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12219         DW_CFA_AARCH64_negate_ra_state.
12220         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12221
12222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12223             Jiong Wang  <jiong.wang@arm.com>
12224
12225         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12226         registers.
12227         (aarch64_pseudo_register_name): Likewise.
12228         (aarch64_pseudo_register_type): Likewise.
12229         (aarch64_pseudo_register_reggroup_p): Likewise.
12230         (aarch64_gdbarch_init): Add pauth registers.
12231         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12232         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12233         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12234         (struct gdbarch_tdep): Add regnum for ra_state.
12235
12236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12237             Jiong Wang  <jiong.wang@arm.com>
12238
12239         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12240
12241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12242             Jiong Wang  <jiong.wang@arm.com>
12243
12244         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12245         function.
12246         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12247         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12248         (aarch64_gdbarch_init): Add puth registers.
12249         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12250         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12251         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12252
12253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12254             Jiong Wang  <jiong.wang@arm.com>
12255
12256         * aarch64-linux-nat.c
12257         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12258         * aarch64-linux-tdep.c
12259         (aarch64_linux_core_read_description): Likewise.
12260         (aarch64_linux_get_hwcap): New function.
12261         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12262         (aarch64_linux_get_hwcap): New declaration.
12263
12264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12265             Jiong Wang  <jiong.wang@arm.com>
12266
12267         * aarch64-linux-nat.c
12268         (aarch64_linux_nat_target::read_description): Add pauth param.
12269         * aarch64-linux-tdep.c
12270         (aarch64_linux_core_read_description): Likewise.
12271         * aarch64-tdep.c (struct target_desc): Add in pauth.
12272         (aarch64_read_description): Add pauth param.
12273         (aarch64_gdbarch_init): Likewise.
12274         * aarch64-tdep.h (aarch64_read_description): Likewise.
12275         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12276         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12277         * features/Makefile: Add new files.
12278         * features/aarch64-pauth.c: New file.
12279         * features/aarch64-pauth.xml: New file.
12280
12281 2019-03-20  Tom Tromey  <tromey@adacore.com>
12282
12283         * infrun.c (handle_inferior_event): Rename from
12284         handle_inferior_event_1.  Create a scoped_value_mark.
12285         (handle_inferior_event): Remove.
12286
12287 2019-03-19  Tom Tromey  <tromey@adacore.com>
12288
12289         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12290         * infrun.h (print_stop_event): Add "displays" parameter.
12291         * infrun.c (print_stop_event): Add "displays" parameter.
12292
12293 2019-03-19  Pedro Alves  <palves@redhat.com>
12294
12295         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12296         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12297         to -1.  Fix TABs vs spaces.
12298         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12299         * tui/tui-out.h (tui_ui_out) Add intro comments.
12300         <m_line, m_start_of_line>: In-class initialize, and add describing
12301         comment.
12302
12303 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12304
12305         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12306         variable names.
12307         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12308
12309 2019-03-18  Pedro Alves  <palves@redhat.com>
12310             Eli Zaretskii <eliz@gnu.org>
12311
12312         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12313         m_line and m_start_of_line.
12314
12315 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12316
12317         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12318         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12319         it returns a newline.  This fixes a regression in TU mode, whereby
12320         the next line is output on the same screen line as the user input.
12321
12322 2019-03-18  Tom Tromey  <tromey@adacore.com>
12323
12324         * minsyms.c (minimal_symbol_reader::install): Remove call to
12325         obstack_blank.
12326
12327 2019-03-18  Pedro Alves  <palves@redhat.com>
12328
12329         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12330         New globals.
12331         (apply_style): New, factored out from ...
12332         (apply_ansi_escape): ... this.  Handle reverse video mode.
12333         (tui_set_reverse_mode): New function.
12334         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12335         * tui/tui-winsource.c (tui_show_source_line): Use
12336         tui_set_reverse_mode instead of setting A_STANDOUT.
12337         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12338         New setter methods.
12339
12340 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12341
12342         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12343         Handle tabs.
12344
12345 2019-03-18  Tom Tromey  <tromey@adacore.com>
12346
12347         * ada-lang.c (empty_array): Add "high" parameter.
12348         (ada_evaluate_subexp): Update.
12349
12350 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12351
12352         * unittests/string_view-selftests.c: Define
12353         _initialize_string_view_selftests unconditionally.
12354
12355 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12356
12357         PR gdb/24350
12358         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12359
12360 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12361
12362         PR gdb/24351
12363         * windows-nat.c (display_selector): Fix format specifiers.
12364
12365 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12366
12367         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12368         tui_refill_source_window instead of tui_refresh_win, to update the
12369         current execution line.  This fixes redisplay of the current line
12370         when stepping through the code with "next" or "step".
12371
12372 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12373
12374         * source-cache.c (source_cache::get_source_lines): Call
12375         find_source_lines to initialize s->nlines.  This fixes vertical
12376         scrolling of TUI source window when the DOWN arrow is pressed.
12377
12378 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12379
12380         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12381         linux-thread-db.c (_initialize_thread_db): Likewise.
12382
12383 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12384
12385         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12386         wclrtoeol in tui_show_source_line".  This reverts changes made in
12387         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12388
12389 2019-03-15  Tom Tromey  <tom@tromey.com>
12390
12391         * symtab.h (struct minimal_symbol): Derive from
12392         general_symbol_info.
12393         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12394         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12395         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12396         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12397         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12398         (MSYMBOL_SEARCH_NAME): Update.
12399         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12400         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12401         * minsyms.c (minimal_symbol_reader::record_full): Update.
12402
12403 2019-03-15  Tom Tromey  <tom@tromey.com>
12404
12405         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12406
12407 2019-03-15  Tom Tromey  <tom@tromey.com>
12408
12409         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12410         unique_xmalloc_ptr.
12411         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12412         Update.
12413         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12414         (build_minimal_symbol_hash_tables)
12415         (minimal_symbol_reader::install): Update.
12416
12417 2019-03-15  Tom Tromey  <tom@tromey.com>
12418
12419         * symtab.c (create_demangled_names_hash): Update.
12420         (symbol_set_names): Update.
12421         * objfiles.h (struct objfile_per_bfd_storage)
12422         <demangled_names_hash>: Now an htab_up.
12423         * objfiles.c (objfile_per_bfd_storage): Simplify.
12424
12425 2019-03-15  Tom Tromey  <tom@tromey.com>
12426
12427         * objfiles.h (struct objfile_per_bfd_storage): Declare
12428         destructor.
12429         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12430         New.
12431         (get_objfile_bfd_data): Use new.  Don't initialize
12432         language_of_main.
12433         (free_objfile_per_bfd_storage): Remove.
12434         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12435
12436 2019-03-15  Tom Tromey  <tom@tromey.com>
12437
12438         * symfile.c (reread_symbols): Update.
12439         * objfiles.c (objfile::objfile): Update.
12440         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12441         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12442         comment.
12443         (minimal_symbol_reader::install): Update.
12444         (terminate_minimal_symbol_table): Remove.
12445         * jit.c (jit_object_close_impl): Update.
12446
12447 2019-03-15  Tom Tromey  <tom@tromey.com>
12448
12449         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12450         initializations.
12451
12452 2019-03-15  Tom Tromey  <tom@tromey.com>
12453
12454         * objfiles.h (struct objfile_per_bfd_storage)
12455         <demangled_hash_languages>: Now a bitset.
12456         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12457         (lookup_minimal_symbol): Update.
12458
12459 2019-03-15  Tom Tromey  <tom@tromey.com>
12460
12461         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12462         Don't return the symbol.
12463         * coffread.c (record_minimal_symbol): Use record_full.
12464
12465 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12466
12467         The MS-Windows port of ncurses fails to switch to a color pair if
12468         one or both of the colors are the implicit default colors.  This
12469         change records the default colors when TUI is initialized, and
12470         then specifies them explicitly when a color pair uses the default
12471         colors.  This allows color styling in TUI mode on MS-Windows.
12472
12473         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12474         ncurses_norm_attr.
12475         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12476         colors in ncurses_norm_attr.
12477         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12478         "none", replace it with the default color recorded in
12479         ncurses_norm_attr.
12480
12481 2019-03-14  Tom Tromey  <tromey@adacore.com>
12482
12483         * source-cache.h (class source_cache) <get_source_lines>: Return
12484         std::string.
12485         * source-cache.c (source_cache::extract_lines): Handle case where
12486         first_pos==npos.  Return std::string.
12487         (source_cache::get_source_lines): Update.
12488
12489 2019-03-14  Tom Tromey  <tromey@adacore.com>
12490
12491         * NEWS: Add item for "style sources" commands.
12492         * source-cache.c (source_cache::get_source_lines): Check
12493         source_styling.
12494         * cli/cli-style.c (source_styling): New global.
12495         (_initialize_cli_style): Add "style sources" commands.
12496         (show_style_sources): New function.
12497         * cli/cli-style.h (source_styling): Declare.
12498
12499 2019-03-14  Pedro Alves  <palves@redhat.com>
12500             Tom Tromey  <tromey@adacore.com>
12501
12502         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12503         * tui/tui-winsource.c (tui_refill_source_window): New function,
12504         from...
12505         (tui_horizontal_source_scroll): ... here.  Move some logic.
12506         * cli/cli-style.c (set_style_enabled): Notify new observable.
12507         * tui/tui-hooks.c (tui_redisplay_source): New function.
12508         (tui_attach_detach_observers): Attach or detach
12509         tui_redisplay_source.
12510         * observable.h (source_styling_changed): New observable.
12511         * observable.c: Define source_styling_changed observable.
12512
12513 2019-03-13  Tom Tromey  <tromey@adacore.com>
12514
12515         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12516         (i386_gnu_nat_target::store_registers): Update.
12517         * target-debug.h (target_debug_print_std_string): New macro.
12518         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12519         * windows-tdep.c (display_one_tib): Update.
12520         * tui/tui-stack.c (tui_make_status_line): Update.
12521         * top.c (print_inferior_quit_action): Update.
12522         * thread.c (thr_try_catch_cmd): Update.
12523         (add_thread_with_info): Update.
12524         (thread_target_id_str): Update.
12525         (thr_try_catch_cmd): Update.
12526         (thread_command): Update.
12527         (thread_find_command): Update.
12528         * record-btrace.c (record_btrace_target::info_record)
12529         (record_btrace_resume_thread, record_btrace_target::resume)
12530         (record_btrace_cancel_resume, record_btrace_step_thread)
12531         (record_btrace_target::wait, record_btrace_target::wait)
12532         (record_btrace_target::wait, record_btrace_target::stop): Update.
12533         * progspace.c (print_program_space): Update.
12534         * process-stratum-target.c
12535         (process_stratum_target::thread_address_space): Update.
12536         * linux-fork.c (linux_fork_mourn_inferior)
12537         (detach_checkpoint_command, info_checkpoints_command)
12538         (linux_fork_context): Update.
12539         (linux_fork_detach): Update.
12540         (class scoped_switch_fork_info): Update.
12541         (delete_checkpoint_command): Update.
12542         * infrun.c (follow_fork_inferior): Update.
12543         (follow_fork_inferior): Update.
12544         (proceed_after_vfork_done): Update.
12545         (handle_vfork_child_exec_or_exit): Update.
12546         (follow_exec): Update.
12547         (displaced_step_prepare_throw): Update.
12548         (displaced_step_restore): Update.
12549         (start_step_over): Update.
12550         (resume_1): Update.
12551         (clear_proceed_status_thread): Update.
12552         (proceed): Update.
12553         (print_target_wait_results): Update.
12554         (do_target_wait): Update.
12555         (context_switch): Update.
12556         (stop_all_threads): Update.
12557         (restart_threads): Update.
12558         (finish_step_over): Update.
12559         (handle_signal_stop): Update.
12560         (switch_back_to_stepped_thread): Update.
12561         (keep_going_pass_signal): Update.
12562         (print_exited_reason): Update.
12563         (normal_stop): Update.
12564         * inferior.c (inferior_pid_to_str): Change return type.
12565         (print_selected_inferior): Update.
12566         (add_inferior): Update.
12567         (detach_inferior): Update.
12568         * dummy-frame.c (fprint_dummy_frames): Update.
12569         * dcache.c (dcache_info_1): Update.
12570         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12571         (btrace_fetch, btrace_clear): Update.
12572         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12573         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12574         type.
12575         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12576         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12577         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12578         * gdbarch.c, gdbarch.h: Rebuild.
12579         * gdbarch.sh (core_pid_to_str): Change return type.
12580         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12581         return type.
12582         (windows_nat_target::pid_to_str): Change return type.
12583         (windows_delete_thread): Update.
12584         (windows_nat_target::attach): Update.
12585         (windows_nat_target::files_info): Update.
12586         * target-delegates.c: Rebuild.
12587         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12588         return type.
12589         (sol_thread_target::pid_to_str): Change return type.
12590         * remote.c (class remote_target) <pid_to_str>: Change return
12591         type.
12592         (remote_target::pid_to_str): Change return type.
12593         (extended_remote_target::attach, remote_target::remote_stop_ns)
12594         (remote_target::remote_notif_remove_queued_reply)
12595         (remote_target::push_stop_reply, remote_target::disable_btrace):
12596         Update.
12597         (extended_remote_target::attach): Update.
12598         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12599         type.
12600         (gdbsim_target::pid_to_str): Change return type.
12601         * ravenscar-thread.c (struct ravenscar_thread_target)
12602         <pid_to_str>: Change return type.
12603         (ravenscar_thread_target::pid_to_str): Change return type.
12604         * procfs.c (class procfs_target) <pid_to_str>: Change return
12605         type.
12606         (procfs_target::pid_to_str): Change return type.
12607         (procfs_target::attach): Update.
12608         (procfs_target::detach): Update.
12609         (procfs_target::fetch_registers): Update.
12610         (procfs_target::store_registers): Update.
12611         (procfs_target::wait): Update.
12612         (procfs_target::files_info): Update.
12613         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12614         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12615         return type.
12616         (nto_procfs_target::pid_to_str): Change return type.
12617         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12618         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12619         return type.
12620         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12621         (exit_lwp): Update.
12622         (attach_proc_task_lwp_callback, get_detach_signal)
12623         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12624         (linux_nat_target::resume, wait_lwp, stop_callback)
12625         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12626         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12627         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12628         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12629         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12630         type.
12631         (inf_ptrace_target::attach): Update.
12632         (inf_ptrace_target::files_info): Update.
12633         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12634         type.
12635         (go32_nat_target::pid_to_str): Change return type.
12636         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12637         (gnu_nat_target::wait): Update.
12638         (gnu_nat_target::wait): Update.
12639         (gnu_nat_target::resume): Update.
12640         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12641         (fbsd_nat_target::wait): Update.
12642         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12643         type.
12644         (darwin_nat_target::attach): Update.
12645         * corelow.c (class core_target) <pid_to_str>: Change return type.
12646         (core_target::pid_to_str): Change return type.
12647         * target.c (normal_pid_to_str): Change return type.
12648         (default_pid_to_str): Likewise.
12649         (target_pid_to_str): Change return type.
12650         (target_translate_tls_address): Update.
12651         (target_announce_detach): Update.
12652         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12653         return type.
12654         (bsd_uthread_target::pid_to_str): Change return type.
12655         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12656         type.
12657         (bsd_kvm_target::pid_to_str): Change return type.
12658         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12659         return type.
12660         (aix_thread_target::pid_to_str): Change return type.
12661         * target.h (struct target_ops) <pid_to_str>: Change return type.
12662         (target_pid_to_str, normal_pid_to_str): Likewise.
12663         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12664         type.
12665         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12666         type.
12667         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12668         return type.
12669         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12670         type.
12671         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12672         type.
12673         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12674         return type.
12675
12676 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12677
12678         * NEWS: Mention that the new default MI version is 3.  Mention
12679         changes to the output of commands and events that deal with
12680         multi-location breakpoints.
12681         * breakpoint.c: Include "mi/mi-out.h".
12682         (print_one_breakpoint): Change output syntax if using MI version
12683         >= 3.
12684         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12685         New.
12686         (mi_multi_location_breakpoint_output_fixed): New.
12687         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12688         (mi_cmd_fix_multi_location_breakpoint_output): New.
12689         (mi_multi_location_breakpoint_output_fixed): New.
12690         * mi/mi-cmds.c (mi_cmds): Register command
12691         -fix-multi-location-breakpoint-output.
12692         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12693         interpreter "mi".
12694
12695 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12696
12697         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12698         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12699         instantiate mi_ui_out based on interpreter name.
12700         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12701         * mi/mi-main.c (mi_load_progress): Likewise.
12702
12703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12704
12705         * NEWS: Combine separate "New targets" sections for 8.3.
12706
12707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12708
12709         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12710         (ppcfbsd_init_abi): Install gdbarch
12711         "fetch_tls_load_module_address" and "get_thread_local_address"
12712         methods.
12713
12714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12715
12716         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12717         (riscv_fbsd_init_abi): Install gdbarch
12718         "fetch_tls_load_module_address" and "get_thread_local_address"
12719         methods.
12720
12721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12722
12723         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12724         (i386fbsd_init_abi): Install gdbarch
12725         "fetch_tls_load_module_address" and "get_thread_local_address"
12726         methods.
12727
12728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12729
12730         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12731         (amd64fbsd_init_abi): Install gdbarch
12732         "fetch_tls_load_module_address" and "get_thread_local_address"
12733         methods.
12734
12735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12736
12737         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12738         (struct fbsd_pspace_data): New type.
12739         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12740         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12741         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12742         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12743         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12744
12745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12746
12747         * gdbtypes.c (lookup_struct_elt): New function.
12748         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12749         * gdbtypes.h (struct struct_elt): New type.
12750         (lookup_struct_elt): New prototype.
12751
12752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12753
12754         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12755         remove disabled code block.
12756
12757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12758
12759         * gdbarch.sh (get_thread_local_address): New method.
12760         * gdbarch.h, gdbarch.c: Regenerate.
12761         * target.c (target_translate_tls_address): Use
12762         gdbarch_get_thread_local_address if present instead of
12763         target::get_thread_local_address.
12764
12765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12766
12767         * target.h (target::get_thread_local_address): Update comment.
12768
12769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12770
12771         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12772         objfile->separate_debug_objfile_backlink if not NULL.
12773
12774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12775
12776         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12777         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12778         (amd64bsd_store_inferior_registers): Likewise.
12779         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12780         Enable segment base registers.
12781         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12782         PT_GETFSBASE and PT_GETGSBASE.
12783         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12784         PT_SETGSBASE.
12785         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12786         segment base registers.
12787         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12788
12789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12790
12791         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12792         Update calls to i386_target_description to add 'segments'
12793         parameter.
12794         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12795         add segment base registers.
12796         * arch/i386.c (i386_create_target_description): Add 'segments'
12797         parameter to enable segment base registers.
12798         * arch/i386.h (i386_create_target_description): Likewise.
12799         * features/i386/32bit-segments.xml: New file.
12800         * features/i386/32bit-segments.c: Generate.
12801         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12802         call to i386_target_description to add 'segments' parameter.
12803         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12804         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12805         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12806         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12807         if feature is present.
12808         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12809         Add 'segments' parameter to call to i386_target_description.
12810         (i386_target_description): Add 'segments' parameter to enable
12811         segment base registers.
12812         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12813         to call to i386_target_description.
12814         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12815         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12816         Define I386_NUM_REGS.
12817         (i386_target_description): Add 'segments' parameter to enable
12818         segment base registers.
12819
12820 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12821
12822         PR/24325
12823         * source-cache.c: #undef open and close, to avoid unresolved
12824         externals during linking.
12825
12826 2019-03-12  Tom Tromey  <tromey@adacore.com>
12827
12828         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12829         const.  Add initializers.
12830         (_initialize_remote): Don't initialize ptid globals.
12831
12832 2019-03-12  Pedro Alves  <palves@redhat.com>
12833
12834         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12835
12836 2019-03-12  Pedro Alves  <palves@redhat.com>
12837
12838         * cp-name-parser.y (main): Remove unused 'len' variable.
12839
12840 2019-03-12  Tom Tromey  <tromey@adacore.com>
12841
12842         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12843         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12844
12845 2019-03-12  Tom Tromey  <tromey@adacore.com>
12846
12847         * linux-nat.c (iterate_over_lwps): Update.
12848         (stop_callback): Remove parameter.
12849         (stop_wait_callback, detach_callback, resume_set_callback)
12850         (select_singlestep_lwp_callback, set_ignore_sigint)
12851         (status_callback, resumed_callback, resume_clear_callback)
12852         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12853         data parameter.
12854         (linux_nat_target::detach, linux_nat_target::resume)
12855         (linux_stop_and_wait_all_lwps, select_event_lwp)
12856         (linux_nat_filter_event, linux_nat_wait_1)
12857         (linux_nat_target::kill, linux_nat_target::stop)
12858         (linux_nat_target::stop): Update.
12859         (linux_nat_resume_callback): Change type.
12860         (resume_stopped_resumed_lwps, count_events_callback)
12861         (select_event_lwp_callback): Likewise.
12862         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12863         * arm-linux-nat.c (struct update_registers_data): Remove.
12864         (update_registers_callback): Change type.
12865         (arm_linux_insert_hw_breakpoint1): Update.
12866         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12867         parameter.
12868         (x86_linux_dr_set_addr): Update.
12869         (x86_linux_dr_set_control): Update.
12870         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12871         (iterate_over_lwps): Use gdb::function_view.
12872         * nat/aarch64-linux-hw-point.c (struct
12873         aarch64_dr_update_callback_param): Remove.
12874         (debug_reg_change_callback): Change type.
12875         (aarch64_notify_debug_reg_change): Update.
12876         * s390-linux-nat.c (s390_refresh_per_info): Update.
12877
12878 2019-03-11  Tom Tromey  <tromey@adacore.com>
12879
12880         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12881         redundant assignment to "this_cu".
12882
12883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12884
12885         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12886
12887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12888
12889         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12890         from...
12891         (rank_one_type): ... this.
12892
12893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12894
12895         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12896         from...
12897         (rank_one_type): ... this.
12898
12899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12900
12901         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12902         from...
12903         (rank_one_type): ... this.
12904
12905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12906
12907         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12908         from...
12909         (rank_one_type): ... this.
12910
12911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12912
12913         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12914         from...
12915         (rank_one_type): ... this.
12916
12917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12918
12919         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12920         from...
12921         (rank_one_type): ... this.
12922
12923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12924
12925         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12926         from...
12927         (rank_one_type): ... this.
12928
12929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12930
12931         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12932         from...
12933         (rank_one_type): ... this.
12934
12935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12936
12937         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12938         from...
12939         (rank_one_type): ... this.
12940
12941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12942
12943         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12944         from...
12945         (rank_one_type): ... this.
12946
12947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12948
12949         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12950         from...
12951         (rank_one_type): ... this.
12952
12953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12954
12955         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12956         from...
12957         (rank_one_type): ... this.
12958
12959 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12960
12961         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12962         inferior-events' shows the example events.
12963
12964 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12965
12966         Support styling on native MS-Windows console
12967
12968         PR/24315
12969         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12970         on MS-Windows if $TERM is not defined.
12971
12972         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12973
12974         * posix-hdep.c (gdb_console_fputs):
12975         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12976         functions.
12977         * ui-file.h (gdb_console_fputs): Add prototype.
12978
12979         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12980         back to fputs only if the former returns zero.
12981
12982 2019-03-07  Tom Tromey  <tom@tromey.com>
12983
12984         * symmisc.c (print_symbol_bcache_statistics): Update.
12985         (print_objfile_statistics): Update.
12986         * symfile.c (allocate_symtab): Update.
12987         * stabsread.c: Don't include bcache.h.
12988         * psymtab.h (struct psymbol_bcache): Don't declare.
12989         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12990         (psymbol_bcache_init, psymbol_bcache_free)
12991         (psymbol_bcache_get_bcache): Don't declare.
12992         * psymtab.c (struct psymbol_bcache): Remove.
12993         (psymtab_storage::psymtab_storage): Update.
12994         (psymtab_storage::~psymtab_storage): Update.
12995         (psymbol_bcache_init, psymbol_bcache_free)
12996         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12997         (add_psymbol_to_bcache): Update.
12998         (allocate_psymtab): Update.
12999         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13000         macro_cache>: No longer pointers.
13001         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13002         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13003         * macrotab.c (macro_bcache): Update.
13004         * macroexp.c: Don't include bcache.h.
13005         * gdbtypes.c (check_types_worklist): Update.
13006         (types_deeply_equal): Remove TRY/CATCH.  Update.
13007         * elfread.c (elf_symtab_read): Update.
13008         * dwarf2read.c: Don't include bcache.h.
13009         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13010         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13011         (print_bcache_statistics, bcache_memory_used): Don't declare.
13012         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13013         methods.  Rename all data members.
13014         * bcache.c (struct bcache): Move to bcache.h.
13015         (bcache::expand_hash_table): Rename from expand_hash_table.
13016         (bcache): Remove.
13017         (bcache::insert): Rename from bcache_full.
13018         (bcache::compare): Rename from bcache_compare.
13019         (bcache_xmalloc): Remove.
13020         (bcache::~bcache): Rename from bcache_xfree.
13021         (bcache::print_statistics): Rename from print_bcache_statistics.
13022         (bcache::memory_used): Rename from bcache_memory_used.
13023
13024 2019-03-07  Pedro Alves  <palves@redhat.com>
13025
13026         * infrun.c (normal_stop): Also check for
13027         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13028
13029 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13030
13031         * f-lang.c (value_from_host_double): Moved to...
13032         * value.c (value_from_host_double): ...here.
13033         * value.h (value_from_host_double): Declare.
13034         * guile/scm-math.c (vlscm_convert_typed_number): Use
13035         value_from_host_double.
13036         (vlscm_convert_number): Likewise.
13037         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13038         * python/py-value.c (convert_value_from_python): Likewise.
13039
13040 2019-03-06  Tom Tromey  <tom@tromey.com>
13041
13042         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13043
13044 2019-03-06  Tom Tromey  <tom@tromey.com>
13045
13046         * utils.h (free_current_contents): Don't declare.
13047         * utils.c (free_current_contents): Remove.
13048
13049 2019-03-06  Tom Tromey  <tom@tromey.com>
13050
13051         * top.c (quit_force): Update.
13052         * main.c (captured_command_loop): Update.
13053         * common/new-op.c (operator new): Update.
13054         * common/common-exceptions.c (struct catcher)
13055         <save_cleanup_chain>: Remove member.
13056         (exceptions_state_mc_init): Update.
13057         (exception_try_scope_entry): Return nullptr.
13058         (exception_try_scope_exit, exception_rethrow)
13059         (throw_exception_sjlj, throw_exception_cxx): Update.
13060         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13061         (all_cleanups, do_cleanups, discard_cleanups)
13062         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13063         (restore_cleanups, restore_final_cleanups): Don't declare.
13064         (do_final_cleanups): Remove parameter.
13065         * common/cleanups.c (cleanup_chain, make_cleanup)
13066         (make_cleanup_dtor, all_cleanups, do_cleanups)
13067         (discard_my_cleanups, discard_cleanups)
13068         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13069         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13070         (null_cleanup): Remove.
13071         (do_final_cleanups): Remove parameter.
13072
13073 2019-03-06  Tom Tromey  <tom@tromey.com>
13074
13075         * remote.c (remote_target::remote_parse_stop_reply): Use
13076         unique_xmalloc_ptr.
13077
13078 2019-03-06  Tom Tromey  <tom@tromey.com>
13079
13080         * stabsread.c (struct stabs_field_info): Rename from field_info.
13081         <list, fnlist>: Add initializers.
13082         <obstack>: New member.
13083         (read_member_functions, read_struct_fields, read_baseclasses):
13084         Allocate on obstack.  Don't use cleanups.
13085         (read_one_struct_field, read_member_functions, read_struct_fields)
13086         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13087         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13088         (read_struct_type): Update.
13089
13090 2019-03-06  Tom Tromey  <tom@tromey.com>
13091
13092         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13093         * common/filestuff.h (make_cleanup_close): Don't declare.
13094         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13095         Remove.
13096
13097 2019-03-06  Tom Tromey  <tom@tromey.com>
13098
13099         * solib-aix.c: Use make_scope_exit.
13100
13101 2019-03-06  Tom Tromey  <tom@tromey.com>
13102
13103         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13104         Use make_scope_exit.
13105
13106 2019-03-06  Tom Tromey  <tom@tromey.com>
13107
13108         * solib-svr4.c (disable_probes_interface): Remove parameter.
13109         (svr4_handle_solib_event): Use make_scope_exit.
13110
13111 2019-03-06  Tom Tromey  <tom@tromey.com>
13112
13113         * remote.c (struct stop_reply_deleter): Remove.
13114         (stop_reply_up): Update.
13115         (struct stop_reply): Derive from notif_event.  Don't typedef.
13116         <regcache>: Now a std::vector.
13117         (stop_reply_xfree): Remove.
13118         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13119         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13120         (remote_target::discard_pending_stop_replies): Use delete.
13121         (remote_target::remote_parse_stop_reply): Update.
13122         (remote_target::process_stop_reply): Update.
13123         * remote-notif.h (struct notif_event): Add virtual destructor.
13124         Remove "dtr" member.
13125         (struct notif_client) <alloc_event>: Return a unique_ptr.
13126         (notif_event_xfree): Don't declare.
13127         (notif_event_up): New typedef.
13128         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13129         (notif_event_xfree, do_notif_event_xfree): Remove.
13130         (remote_notif_state_xfree): Update.
13131
13132 2019-03-06  Tom Tromey  <tom@tromey.com>
13133
13134         * infrun.c (displaced_step_clear_cleanup): Now a
13135         forward_scope_exit type.
13136         (displaced_step_prepare_throw): Update.
13137         (displaced_step_fixup): Update.
13138
13139 2019-03-06  Tom Tromey  <tom@tromey.com>
13140
13141         * inferior.h (class inferior): Update comment.
13142         * gdbthread.h (class thread_info): Update comment.
13143
13144 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13145             Tom Tromey  <tom@tromey.com>
13146
13147         * stabsread.h (struct stab_section_list): Remove.
13148         (coffstab_build_psymtabs): Update.
13149         * dbxread.c (symbuf_sections): Now a std::vector.
13150         (sect_idx): New global.
13151         (fill_symbuf): Update.
13152         (coffstab_build_psymtabs): Change type of stabsects parameter.
13153         Update.
13154         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13155         std::vector.
13156         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13157         (coff_locate_sections): Update.
13158         (coff_symfile_read): Remove cleanups.  Update.
13159         (init_stringtab): Add storage parameter.
13160         (free_stringtab, free_stringtab_cleanup): Remove.
13161         (init_lineno): Add storage parameter.
13162         (free_linetab, free_linetab_cleanup): Remove.
13163
13164 2019-03-06  Pedro Alves  <palves@redhat.com>
13165
13166         * linux-fork.c (fork_info::clobber_regs): Delete.
13167         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13168         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13169         comment.  Adjust.
13170         (scoped_switch_fork_info::scoped_switch_fork_info)
13171         (checkpoint_command, linux_fork_context): Adjust
13172         fork_save_infrun_state calls.
13173
13174 2019-03-06  Pedro Alves  <palves@redhat.com>
13175
13176         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13177         (inf_has_multiple_threads): Return 'bool' and rewrite using
13178         inferior_info::threads().
13179
13180 2019-03-06  Pedro Alves  <palves@redhat.com>
13181
13182         * linux-fork.c: Include <list>.
13183         (fork_list): Now a std::list instance.
13184         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13185         (forks_exist_p, find_last_fork): Adjust.
13186         (new_fork): Delete.
13187         (one_fork_p): New.
13188         (add_fork): Adjust.
13189         (free_fork): Delete, folded into fork_info::~fork_info().
13190         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13191         Adjust.
13192         (init_fork_list): Delete.
13193         (linux_fork_killall, linux_fork_mourn_inferior)
13194         (linux_fork_detach, info_checkpoints_command): Adjust.
13195         (_initialize_linux_fork): No longer call init_fork_list.
13196
13197 2019-03-06  Pedro Alves  <palves@redhat.com>
13198
13199         * linux-fork.c (new_fork): New, split out of ...
13200         (add_fork): ... this.  Return void.  Move "first fork" special
13201         case from here, to ...
13202         (checkpoint_command): ... here.
13203         * linux-linux.h (add_fork): Return void.
13204
13205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13206
13207         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13208
13209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13210             Chris January  <chris.january@arm.com>
13211             David Lecomber  <david.lecomber@arm.com>
13212
13213         * f-exp.y: New token, UNOP_INTRINSIC.
13214         (exp): New pattern using UNOP_INTRINSIC token.
13215         (f77_keywords): Add 'abs' keyword.
13216         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13217         (value_from_host_double): New function.
13218         (evaluate_subexp_f): Support UNOP_ABS.
13219
13220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13221
13222         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13223         types.
13224
13225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13226
13227         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13228         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13229         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13230
13231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13232
13233         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13234
13235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13236             Chris January  <chris.january@arm.com>
13237
13238         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13239         * f-exp.y: Define 'KIND' token.
13240         (exp): New pattern for KIND expressions.
13241         (ptype): Handle types with a kind extension.
13242         (direct_abs_decl): Extend to spot kind extensions.
13243         (f77_keywords): Add 'kind' to the list.
13244         (push_kind_type): New function.
13245         (convert_to_kind_type): New function.
13246         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13247         * parse.c (operator_length_standard): Likewise.
13248         * parser-defs.h (enum type_pieces): Add tp_kind.
13249         * std-operator.def: Add UNOP_KIND.
13250
13251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13252
13253         * f-exp.y (f_parse): Set yydebug.
13254
13255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13256
13257         * f-lang.c (evaluate_subexp_f): New function.
13258         (exp_descriptor_f): New global.
13259         (f_language_defn): Use exp_descriptor_f instead of
13260         exp_descriptor_standard.
13261
13262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13263
13264         * f-exp.y (struct token): Add comments.
13265         (dot_ops): Remove uppercase versions and the end marker.
13266         (f77_keywords): Likewise.
13267         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13268         entries in the dot_ops array are case insensitive, and use
13269         strncasecmp to compare strings.  Also some whitespace cleanup in
13270         this area.  Similar for the f77_keywords array, except entries in
13271         this list might be case sensitive.
13272
13273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13274
13275         * f-exp.y (struct f77_boolean_val): Add comments.
13276         (boolean_values): Remove uppercase versions, and end marker.
13277         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13278         and use strncasecmp to achieve case insensitivity.  Additionally,
13279         perform whitespace cleanup around this code.
13280
13281 2019-03-06  Tom Tromey  <tromey@adacore.com>
13282
13283         * remote-sim.c (gdbsim_target_open): Use result of
13284         gdb_argv::release.
13285
13286 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13287         Dirk Schubert  <dirk.schubert@arm.com>
13288         Chris January  <chris.january@arm.com>
13289
13290         * eval.c (evaluate_subexp_standard): Call Fortran argument
13291         wrapping logic.
13292         * f-lang.c (struct value): A value which can be passed into a
13293         Fortran function call.
13294         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13295         where appropriate.
13296         (struct type): Value ready for a Fortran function call.
13297         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13298         is needed.
13299         * f-lang.h (fortran_argument_convert): Declaration.
13300         (fortran_preserve_arg_pointer): Declaration.
13301         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13302
13303 2019-03-05  Tom Tromey  <tromey@adacore.com>
13304
13305         * python/py-prettyprint.c (print_string_repr): Remove #if.
13306         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13307
13308 2019-03-05  Tom Tromey  <tromey@adacore.com>
13309
13310         * target.c (the_dummy_target): Move later.  Change type to
13311         "dummy_target".
13312         (initialize_targets): Don't initialize the_dummy_target.
13313
13314 2019-03-05  Tom Tromey  <tromey@adacore.com>
13315
13316         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13317         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13318
13319 2019-03-05  Tom Tromey  <tromey@adacore.com>
13320
13321         * windows-nat.c (windows_nat_target::attach)
13322         (windows_nat_target::detach): Don't call gdb_flush.
13323         * valprint.c (generic_val_print, val_print, val_print_string):
13324         Don't call gdb_flush.
13325         * utils.c (defaulted_query): Don't call gdb_flush.
13326         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13327         * target.c (target_announce_detach): Don't call gdb_flush.
13328         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13329         * remote.c (extended_remote_target::attach): Don't call
13330         gdb_flush.
13331         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13332         * printcmd.c (do_examine): Don't call gdb_flush.
13333         (info_display_command): Don't call gdb_flush.
13334         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13335         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13336         * memattr.c (info_mem_command): Don't call gdb_flush.
13337         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13338         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13339         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13340         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13341         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13342         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13343         (gnu_nat_target::detach): Don't call gdb_flush.
13344         * f-valprint.c (f_val_print): Don't call gdb_flush.
13345         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13346         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13347         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13348         gdb_flush.
13349         * c-valprint.c (c_val_print): Don't call gdb_flush.
13350         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13351
13352 2019-03-05  Tom Tromey  <tromey@adacore.com>
13353
13354         * varobj.c (update_dynamic_varobj_children): Update.
13355         (install_default_visualizer): Use reset, not release.
13356         * value.c (set_internalvar): Update.
13357         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13358         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13359         ATTRIBUTE_UNUSED_RESULT.
13360
13361 2019-03-05  Tom Tromey  <tromey@adacore.com>
13362
13363         * remote.c (class scoped_remote_fd) <release>: Add
13364         ATTRIBUTE_UNUSED_RESULT.
13365
13366 2019-03-05  Tom Tromey  <tromey@adacore.com>
13367
13368         * macroexp.c (struct macro_buffer) <release>: Add
13369         ATTRIBUTE_UNUSED_RESULT.
13370
13371 2019-03-05  Tom Tromey  <tromey@adacore.com>
13372
13373         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13374         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13375         ATTRIBUTE_UNUSED_RESULT.
13376
13377 2019-03-05  Tom Tromey  <tromey@adacore.com>
13378
13379         * common/scoped_fd.h (class scoped_fd) <release>: Add
13380         ATTRIBUTE_UNUSED_RESULT.
13381
13382 2019-03-05  Tom Tromey  <tromey@adacore.com>
13383
13384         * parser-defs.h (struct parser_state) <release>: Add
13385         ATTRIBUTE_UNUSED_RESULT.
13386
13387 2019-03-05  Tom Tromey  <tromey@adacore.com>
13388
13389         * utils.h (class gdb_argv) <release>: Add
13390         ATTRIBUTE_UNUSED_RESULT.
13391         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13392
13393 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13394
13395         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13396         for-loop range, to avoid compiler warnings.
13397
13398         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13399         avoid compiler warnings about unused variables.
13400
13401         * NEWS: Mention end of support for native debugging on MS-Windows
13402         before XP.
13403
13404         PR gdb/24292
13405         * common/netstuff.c:
13406         * gdbserver/gdbreplay.c
13407         * gdbserver/remote-utils.c:
13408         * ser-tcp.c:
13409         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13410         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13411         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13412         'getaddrinfo' and 'freeaddrinfo' were not available before
13413         Windows XP, and mingw.org's MinGW headers by default define
13414         _WIN32_WINNT to 0x500.
13415
13416 2019-03-01  Gary Benson <gbenson@redhat.com>
13417
13418         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13419
13420 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13421             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13422
13423         PR gdb/8527
13424         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13425         set_sigint_trap, clear_sigint_trap.
13426
13427 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13428
13429         * target.c (target_detach): Clear the regcache and the
13430         frame cache.
13431
13432 2019-02-27  Pedro Alves  <palves@redhat.com>
13433
13434         * utils.c (set_screen_size): When we cap the height/width sizes,
13435         tweak the corresponding command variable to show "unlimited":
13436
13437 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13438             Pedro Alves  <palves@redhat.com>
13439
13440         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13441         before calling rl_set_screen_size.
13442
13443 2019-02-27  Tom Tromey  <tromey@adacore.com>
13444
13445         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13446         define.
13447         * python/py-value.c: Remove Python 2.4 workaround.
13448         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13449         workaround.
13450         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13451         Python 2.4 workaround.
13452         * python/python-internal.h: Remove Python 2.4 comment.
13453         (Py_ssize_t): Don't define.
13454         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13455         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13456         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13457         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13458         * python/python.c (do_start_initialization): Remove Python 2.4
13459         workaround.
13460         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13461         (print_children): Remove Python 2.4 workaround.
13462         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13463         workaround.
13464         (CHARBUFFERPROC_NAME): Remove.
13465         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13466         Python 2.4 workaround.
13467
13468 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13469
13470         * NEWS: Note minimum Python version.
13471
13472 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13473
13474         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13475         code from these functions.  Remove corresponding ifdefs.  Use
13476         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13477         Remove gotos and target of gotos.
13478         (infpy_search_memory): Likewise.
13479
13480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13481
13482         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13483         (hppa_gdbarch_init): Don't register deleted functions with
13484         gdbarch.
13485
13486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13487
13488         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13489         (h8300_unwind_sp): Delete.
13490         (h8300_dummy_id): Delete.
13491         (h8300_gdbarch_init): Don't register deleted functions with
13492         gdbarch.
13493
13494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13495
13496         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13497         (ft32_unwind_pc): Delete.
13498         (ft32_unwind_sp): Delete.
13499         (ft32_gdbarch_init): Don't register deleted functions with
13500         gdbarch.
13501
13502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13503
13504         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13505         (frv_unwind_pc): Delete.
13506         (frv_unwind_sp): Delete.
13507         (frv_gdbarch_init): Don't register deleted functions with
13508         gdbarch.
13509
13510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13511
13512         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13513         (riscv_unwind_pc): Delete.
13514         (riscv_unwind_sp): Delete.
13515         (riscv_gdbarch_init): Don't register deleted functions with
13516         gdbarch.
13517
13518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13519
13520         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13521         (csky_unwind_pc): Delete.
13522         (csky_unwind_sp): Delete.
13523         (csky_gdbarch_init): Don't register deleted functions with
13524         gdbarch.
13525
13526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13527
13528         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13529         (cris_unwind_pc): Delete.
13530         (cris_unwind_sp): Delete.
13531         (cris_gdbarch_init): Don't register deleted functions with
13532         gdbarch.
13533
13534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13535
13536         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13537         (bfin_unwind_pc): Delete.
13538         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13539
13540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13541
13542         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13543         (arm_unwind_pc): Delete.
13544         (arm_unwind_sp): Delete.
13545         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13546
13547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13548
13549         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13550         (arc_unwind_pc): Delete.
13551         (arc_unwind_sp): Delete.
13552         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13553
13554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13555
13556         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13557         (alpha_unwind_pc): Delete.
13558         (alpha_gdbarch_init): Don't register deleted functions with
13559         gdbarch.
13560
13561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13562
13563         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13564         (aarch64_unwind_pc): Delete.
13565         (aarch64_unwind_sp): Delete.
13566         (aarch64_gdbarch_init): Don't register deleted functions with
13567         gdbarch.
13568
13569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13570
13571         * gdbtypes.c (type_align): Don't consider static members when
13572         computing structure alignment.
13573
13574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13575
13576         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13577         return 0 for other types.
13578         * arch-utils.c (default_type_align): Always return 0.
13579         * gdbarch.h: Regenerate.
13580         * gdbarch.sh (type_align): Extend comment.
13581         * gdbtypes.c (type_align): Add additional comments, always call
13582         gdbarch_type_align before applying the default rules.
13583         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13584         generic code will then apply a suitable default.
13585         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13586         types, return 0 for other types.
13587
13588 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13589
13590         * NEWS: Create a new section for the next release branch.
13591         Rename the section of the current branch, now that it has
13592         been cut.
13593
13594 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13595
13596         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13597         * version.in: Bump version to 8.3.50.DATE-git.
13598
13599 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13600
13601         * aix-thread.c (ptid_cmp): Remove unused variable.
13602         (get_signaled_thread): Likewise.
13603         (store_regs_user_thread): Likewise.
13604         (store_regs_kernel_thread): Likewise.
13605         (fetch_regs_kernel_thread): Remove shadowed variable.
13606
13607 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13608
13609         * features/riscv/32bit-cpu.xml: Add register numbers.
13610         * features/riscv/32bit-fpu.c: Regenerate.
13611         * features/riscv/32bit-fpu.xml: Add register numbers.
13612         * features/riscv/64bit-cpu.xml: Add register numbers.
13613         * features/riscv/64bit-fpu.c: Regenerate.
13614         * features/riscv/64bit-fpu.xml: Add register numbers.
13615
13616 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13617
13618         * NEWS: Mention two argument form of gdb.Value constructor.
13619         * python/py-value.c (convert_buffer_and_type_to_value): New
13620         function.
13621         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13622         Add support for handling an optional second argument.  Call
13623         convert_buffer_and_type_to_value as appropriate.
13624         * python/python-internal.h (Py_buffer_deleter): New struct.
13625         (Py_buffer_up): New typedef.
13626
13627 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13628
13629         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13630         instead of releasing ownership.
13631
13632 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13633
13634         * dwarf2read.c (open_and_init_dwp_file): Call
13635         elf_numsections instead of bfd_count_sections to initialize
13636         dwp_file->num_sections.
13637
13638 2019-02-25  Tom Tromey  <tromey@adacore.com>
13639
13640         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13641
13642 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13643
13644         * gcore.in: Add '--readnever' option when invoking GDB.
13645
13646 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13647
13648         * MAINTAINERS: Update my email address.
13649
13650 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13651
13652         * build-id.c (build_id_to_debug_bfd_1): New function.
13653         (build_id_to_debug_bfd): Look for separate debug file in
13654         sysroot.
13655
13656 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13657
13658         * gdbarch.sh: Update the copyright year range that is placed into
13659         generated files.
13660
13661 2019-02-22  Keith Seitz  <keiths@redhat.com>
13662
13663         PR symtab/23853
13664         * linespec.c (create_sals_line_offset): Search for the default
13665         symtab's filename instead of its fullname.
13666
13667 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13668
13669         * NEWS: Update style defaults.
13670
13671 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13672
13673         * main.c (captured_main_1): Disable styling in batch mode.
13674
13675 2019-02-20  Tom Tromey  <tom@tromey.com>
13676
13677         * symtab.c (symtab_symbol_info): Fix typos.
13678
13679 2019-02-20  Tom Tromey  <tromey@adacore.com>
13680
13681         * findcmd.c (_initialize_mem_search): Use upper case for
13682         metasyntactic variables.
13683
13684 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13685
13686         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13687         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13688
13689 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13690
13691         * top.h (source_file_name): Change to std::string.
13692         * top.c (source_file_name): Likewise.
13693         (command_line_input): Adjust.
13694         * cli/cli-script.c (script_from_file): Adjust.
13695
13696 2019-02-19  Tom Tromey  <tromey@adacore.com>
13697
13698         * ravenscar-thread.c
13699         (ravenscar_thread_target::update_thread_list): Don't call
13700         ada_build_task_list.
13701         * ada-lang.h (ada_build_task_list): Don't declare.
13702         * ada-tasks.c (struct ada_tasks_inferior_data)
13703         <task_list_valid_p>: Now bool.
13704         (read_known_tasks, ada_task_list_changed)
13705         (ada_tasks_invalidate_inferior_data): Update.
13706         (read_known_tasks_array): Return bool.
13707         (read_known_tasks_list): Likewise.
13708         (read_known_tasks): Return void.
13709         (ada_build_task_list): Now static.
13710
13711 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13712
13713         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13714         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13715
13716 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13717
13718         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13719         variant for ada_tasks_pspace_data_handle and
13720         ada_tasks_inferior_data_handle.
13721         (ada_tasks_pspace_data_cleanup): New function.
13722         (ada_tasks_inferior_data_cleanup): New function.
13723
13724 2019-02-17  Tom Tromey  <tom@tromey.com>
13725
13726         * macrotab.h (macro_source_fullname): Return a std::string.
13727         * macrotab.c (macro_include, check_for_redefinition)
13728         (macro_undef, macro_lookup_definition, foreach_macro)
13729         (foreach_macro_in_scope): Update.
13730         (macro_source_fullname): Return a std::string.
13731         * macrocmd.c (show_pp_source_pos): Update.
13732
13733 2019-02-17  Tom Tromey  <tom@tromey.com>
13734
13735         * macrocmd.c (show_pp_source_pos): Style the file names.
13736
13737 2019-02-17  Tom Tromey  <tom@tromey.com>
13738
13739         PR tui/24197:
13740         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13741
13742 2019-02-17  Tom Tromey  <tom@tromey.com>
13743
13744         * ada-lang.c (user_select_syms): Use filtered printing.
13745         * utils.c (wrap_style): New global.
13746         (desired_style): Remove.
13747         (emit_style_escape): Add stream parameter.
13748         (set_output_style, reset_terminal_style, prompt_for_continue):
13749         Update.
13750         (flush_wrap_buffer): Only flush gdb_stdout.
13751         (wrap_here): Set wrap_style.
13752         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13753         treat escape sequences as a character.  Change when wrap buffer is
13754         flushed.
13755         (fputs_styled): Do not set the output style when the default is
13756         requested.
13757         * ui-style.h (struct ui_file_style) <is_default>: New method.
13758         * source.c (print_source_lines_base): Emit escape sequences in one
13759         piece.
13760
13761 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13762
13763         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13764         integers and enumeration types.
13765
13766 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13767
13768         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13769         instead of lookup_symbol_in_language
13770         (do_exact_match): New function.
13771         (ada_get_symbol_name_matcher): Return do_exact_match when
13772         doing a verbatim match.
13773
13774 2019-02-15  Tom Tromey  <tromey@adacore.com>
13775
13776         * ravenscar-thread.c (ravenscar_thread_target::resume)
13777         (ravenscar_thread_target::wait): Special case wildcard requests.
13778
13779 2019-02-15  Tom Tromey  <tromey@adacore.com>
13780
13781         * ravenscar-thread.c (base_ptid): Remove.
13782         (struct ravenscar_thread_target) <close>: New method.
13783         <m_base_ptid>: New member.
13784         <update_inferior_ptid, active_task, task_is_currently_active,
13785         runtime_initialized>: Declare methods.
13786         <ravenscar_thread_target>: Add constructor.
13787         (ravenscar_thread_target::task_is_currently_active)
13788         (ravenscar_thread_target::update_inferior_ptid)
13789         (ravenscar_runtime_initialized): Rename.  Now methods.
13790         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13791         (ravenscar_thread_target::update_thread_list): Update.
13792         (ravenscar_thread_target::active_task): Now method.
13793         (ravenscar_thread_target::store_registers)
13794         (ravenscar_thread_target::prepare_to_store)
13795         (ravenscar_thread_target::prepare_to_store)
13796         (ravenscar_thread_target::mourn_inferior): Update.
13797         (ravenscar_inferior_created): Use "new" to create target.
13798         (ravenscar_thread_target::get_ada_task_ptid): Update.
13799         (_initialize_ravenscar): Don't initialize base_ptid.
13800         (ravenscar_ops): Remove global.
13801
13802 2019-02-15  Tom Tromey  <tromey@adacore.com>
13803
13804         * target.h (push_target): Declare new overload.
13805         * target.c (push_target): New overload, taking an rvalue reference.
13806         * remote.c (remote_target::open_1): Use push_target overload.
13807         * corelow.c (core_target_open): Use push_target overload.
13808
13809 2019-02-15  Tom Tromey  <tromey@adacore.com>
13810
13811         * ravenscar-thread.c (is_ravenscar_task)
13812         (ravenscar_task_is_currently_active): Return bool.
13813         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13814         (_initialize_ravenscar): Remove "(void)".
13815         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13816         Return bool.
13817
13818 2019-02-15  Tom Tromey  <tromey@adacore.com>
13819
13820         * ravenscar-thread.c (ravenscar_runtime_initializer)
13821         (has_ravenscar_runtime, get_running_thread_id)
13822         (ravenscar_thread_target::resume): Fix indentation.
13823
13824 2019-02-15  Tom Tromey  <tromey@adacore.com>
13825
13826         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13827         from ravenscar_arch_ops.
13828         (sparc_ravenscar_ops::fetch_registers)
13829         (sparc_ravenscar_ops::store_registers): Now methods.
13830         (sparc_ravenscar_prepare_to_store): Remove.
13831         (sparc_ravenscar_ops): Redefine.
13832         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13833         methods and destructor.  Remove members.
13834         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13835         (ravenscar_thread_target::store_registers)
13836         (ravenscar_thread_target::prepare_to_store): Update.
13837         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13838         Remove.
13839         (struct ppc_ravenscar_powerpc_ops): Derive from
13840         ravenscar_arch_ops.
13841         (ppc_ravenscar_powerpc_ops::fetch_registers)
13842         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13843         (ppc_ravenscar_powerpc_ops): Redefine.
13844         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13845         (ppc_ravenscar_e500_ops::fetch_registers)
13846         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13847         (ppc_ravenscar_e500_ops): Redefine.
13848         * aarch64-ravenscar-thread.c
13849         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13850         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13851         (aarch64_ravenscar_fetch_registers)
13852         (aarch64_ravenscar_store_registers): Now methods.
13853         (aarch64_ravenscar_ops): Redefine.
13854
13855 2019-02-15  Tom Tromey  <tromey@adacore.com>
13856
13857         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13858         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13859         (ravenscar_thread_target::stopped_by_watchpoint)
13860         (ravenscar_thread_target::stopped_data_address)
13861         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13862
13863 2019-02-15  Tom Tromey  <tromey@adacore.com>
13864
13865         * ravenscar-thread.c: Fix some typos.
13866
13867 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13868             Tom Tromey  <tromey@adacore.com>
13869
13870         * ada-lang.c (ada_exception_sal): Change addr_string to a
13871         std::string.
13872         (create_ada_exception_catchpoint): Update.
13873
13874 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13875             Tom Tromey  <tromey@adacore.com>
13876
13877         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13878         (bp_location_ops): Remove.
13879         (base_breakpoint_allocate_location): Update.
13880         (free_bp_location): Update.
13881         * ada-lang.c (class ada_catchpoint_location)
13882         <ada_catchpoint_location>: Remove ops parameter.
13883         (ada_catchpoint_location_dtor): Remove.
13884         (ada_catchpoint_location_ops): Remove.
13885         (allocate_location_exception): Update.
13886         * breakpoint.h (struct bp_location_ops): Remove.
13887         (class bp_location) <bp_location>: Remove bp_location_ops
13888         parameter.
13889         <~bp_location>: Add destructor.
13890         <ops>: Remove.
13891
13892 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13893             Pedro Alves  <palves@redhat.com>
13894
13895         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13896         'PATH_MAX'.
13897
13898 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13899             Samuel Thibault  <samuel.thibault@gnu.org>
13900             Thomas Schwinge  <thomas@codesourcery.com>
13901
13902         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13903         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13904
13905 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13906
13907         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13908         (check_empty): Use "const char *".
13909
13910         * gnu-nat.c (gnu_nat_target::detach): Instead of
13911         'detach_inferior (pid)' call
13912         'detach_inferior (find_inferior_pid (pid))'.
13913
13914         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13915         'nat/fork-inferior.o'.
13916         * gnu-nat.c: #include "nat/fork-inferior.h".
13917
13918         * gnu-nat.c (gnu_nat_target::detach): Instead of
13919         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13920         * gnu-nat.h: #include "inf-child.h".
13921         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13922         'i386_gnu_nat_target::fetch_registers'.
13923         (gnu_store_registers): Rename/move to
13924         'i386_gnu_nat_target::store_registers'.
13925
13926         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13927         * gnu-nat.h (mach_thread_info): New function.
13928         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13929
13930         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13931
13932 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13933
13934         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13935
13936 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13937
13938         * windows-nat.c (windows_add_thread): Add new parameter
13939         "main_thread_p" with default value set to false.  Update
13940         function documentation as well as all callers.
13941         (windows_delete_thread): Likewise.
13942         (fake_create_process): Update call to windows_add_thread.
13943         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13944         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13945         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13946         call to windows_delete_thread.
13947
13948 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13949
13950         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13951
13952 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13953
13954         * symfile.c (find_separate_debug_file): Use canonical path of
13955         sysroot with child_path instead of gdb_sysroot if it is valid.
13956
13957 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13958
13959         * symfile.c (find_separate_debug_file): Use child_path to
13960         determine if an object file is under a sysroot.
13961
13962 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13963
13964         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13965         unittests/child-path-selftests.c.
13966         * common/pathstuff.c (child_path): New function.
13967         * common/pathstuff.h (child_path): New prototype.
13968         * unittests/child-path-selftests.c: New file.
13969
13970 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13971
13972         * symfile.c (find_separate_debug_file): Look for separate debug
13973         files in debug directories under the sysroot.
13974
13975 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13976
13977         * symtab.h (struct minimal_symbol data_p): New const method.
13978         (struct minimal_symbol text_p): Likewise.
13979         * symtab.c (output_source_filename): Use file name style
13980         to print file name.
13981         (print_symbol_info): Likewise.
13982         (print_msymbol_info): Use address style to print addresses.
13983         Use function name style to print executable text symbols.
13984         (expand_symtab_containing_pc): Use data_p.
13985         (find_pc_sect_compunit_symtab): Likewise.
13986
13987 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13988
13989         * breakpoint.c (describe_other_breakpoints): Use address style
13990         to print addresses.
13991         (say_where): Likewise.
13992
13993 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13994
13995         * ada-typeprint.c (print_func_type): Print function name
13996         style to print function name.
13997         * c-typeprint.c (c_print_type_1): Likewise.
13998
13999 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14000
14001         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14002         for execve.
14003
14004 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14005
14006         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14007         type_stack.
14008
14009 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14010
14011         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14012         TYPE_CODE_REF types.
14013
14014 2019-02-08  Jim Wilson  <jimw@sifive.com>
14015
14016         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14017         (riscv_linux_fregset): New.
14018         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14019
14020 2019-02-07  Tom Tromey  <tom@tromey.com>
14021
14022         * thread.c (thread_cancel_execution_command): Update.
14023         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14024         methods.
14025         (struct thread_fsm_ops): Remove.
14026         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14027         (thread_fsm_should_stop, thread_fsm_return_value)
14028         (thread_fsm_set_finished, thread_fsm_finished_p)
14029         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14030         Don't declare.
14031         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14032         * infrun.c (clear_proceed_status_thread)
14033         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14034         (print_stop_event): Update.
14035         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14036         Add constructor.
14037         (step_command_fsm_ops): Remove.
14038         (new_step_command_fsm): Remove.
14039         (step_1): Update.
14040         (step_command_fsm::should_stop): Rename from
14041         step_command_fsm_should_stop.
14042         (step_command_fsm::clean_up): Rename from
14043         step_command_fsm_clean_up.
14044         (step_command_fsm::do_async_reply_reason): Rename from
14045         step_command_fsm_async_reply_reason.
14046         (struct until_next_fsm): Inherit from thread_fsm.  Add
14047         constructor.
14048         (until_next_fsm_ops): Remove.
14049         (new_until_next_fsm): Remove.
14050         (until_next_fsm::should_stop): Rename from
14051         until_next_fsm_should_stop.
14052         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14053         (until_next_fsm::do_async_reply_reason): Rename from
14054         until_next_fsm_async_reply_reason.
14055         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14056         constructor.  Change type of breakpoint.
14057         (finish_command_fsm_ops): Remove.
14058         (new_finish_command_fsm): Remove.
14059         (finish_command_fsm::should_stop): Rename from
14060         finish_command_fsm_should_stop.
14061         (finish_command_fsm::clean_up): Rename from
14062         finish_command_fsm_clean_up.
14063         (finish_command_fsm::return_value): Rename from
14064         finish_command_fsm_return_value.
14065         (finish_command_fsm::do_async_reply_reason): Rename from
14066         finish_command_fsm_async_reply_reason.
14067         (finish_command): Update.
14068         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14069         Add constructor.
14070         (call_thread_fsm_ops): Remove.
14071         (call_thread_fsm::call_thread_fsm): Rename from
14072         new_call_thread_fsm.
14073         (call_thread_fsm::should_stop): Rename from
14074         call_thread_fsm_should_stop.
14075         (call_thread_fsm::should_notify_stop): Rename from
14076         call_thread_fsm_should_notify_stop.
14077         (run_inferior_call, call_function_by_hand_dummy): Update.
14078         * cli/cli-interp.c (should_print_stop_to_console): Update.
14079         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14080         Add constructor.  Change type of location_breakpoint,
14081         caller_breakpoint.
14082         (until_break_fsm_ops): Remove.
14083         (new_until_break_fsm): Remove.
14084         (until_break_fsm::should_stop): Rename from
14085         until_break_fsm_should_stop.
14086         (until_break_fsm::clean_up): Rename from
14087         until_break_fsm_clean_up.
14088         (until_break_fsm::do_async_reply_reason): Rename from
14089         until_break_fsm_async_reply_reason.
14090         (until_break_command): Update.
14091         * thread-fsm.c: Remove.
14092         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14093
14094 2019-02-07  Tom Tromey  <tom@tromey.com>
14095
14096         * yy-remap.h: Add include guard.
14097         * xtensa-tdep.h: Add include guard.
14098         * xcoffread.h: Rename include guard.
14099         * varobj-iter.h: Add include guard.
14100         * tui/tui.h: Rename include guard.
14101         * tui/tui-winsource.h: Rename include guard.
14102         * tui/tui-wingeneral.h: Rename include guard.
14103         * tui/tui-windata.h: Rename include guard.
14104         * tui/tui-win.h: Rename include guard.
14105         * tui/tui-stack.h: Rename include guard.
14106         * tui/tui-source.h: Rename include guard.
14107         * tui/tui-regs.h: Rename include guard.
14108         * tui/tui-out.h: Rename include guard.
14109         * tui/tui-layout.h: Rename include guard.
14110         * tui/tui-io.h: Rename include guard.
14111         * tui/tui-hooks.h: Rename include guard.
14112         * tui/tui-file.h: Rename include guard.
14113         * tui/tui-disasm.h: Rename include guard.
14114         * tui/tui-data.h: Rename include guard.
14115         * tui/tui-command.h: Rename include guard.
14116         * tic6x-tdep.h: Add include guard.
14117         * target/waitstatus.h: Rename include guard.
14118         * target/wait.h: Rename include guard.
14119         * target/target.h: Rename include guard.
14120         * target/resume.h: Rename include guard.
14121         * target-float.h: Rename include guard.
14122         * stabsread.h: Add include guard.
14123         * rs6000-tdep.h: Add include guard.
14124         * riscv-fbsd-tdep.h: Add include guard.
14125         * regformats/regdef.h: Rename include guard.
14126         * record.h: Rename include guard.
14127         * python/python.h: Rename include guard.
14128         * python/python-internal.h: Rename include guard.
14129         * python/py-stopevent.h: Rename include guard.
14130         * python/py-ref.h: Rename include guard.
14131         * python/py-record.h: Rename include guard.
14132         * python/py-record-full.h: Rename include guard.
14133         * python/py-record-btrace.h: Rename include guard.
14134         * python/py-instruction.h: Rename include guard.
14135         * python/py-events.h: Rename include guard.
14136         * python/py-event.h: Rename include guard.
14137         * procfs.h: Add include guard.
14138         * proc-utils.h: Add include guard.
14139         * p-lang.h: Add include guard.
14140         * or1k-tdep.h: Rename include guard.
14141         * observable.h: Rename include guard.
14142         * nto-tdep.h: Rename include guard.
14143         * nat/x86-linux.h: Rename include guard.
14144         * nat/x86-linux-dregs.h: Rename include guard.
14145         * nat/x86-gcc-cpuid.h: Add include guard.
14146         * nat/x86-dregs.h: Rename include guard.
14147         * nat/x86-cpuid.h: Rename include guard.
14148         * nat/ppc-linux.h: Rename include guard.
14149         * nat/mips-linux-watch.h: Rename include guard.
14150         * nat/linux-waitpid.h: Rename include guard.
14151         * nat/linux-ptrace.h: Rename include guard.
14152         * nat/linux-procfs.h: Rename include guard.
14153         * nat/linux-osdata.h: Rename include guard.
14154         * nat/linux-nat.h: Rename include guard.
14155         * nat/linux-namespaces.h: Rename include guard.
14156         * nat/linux-btrace.h: Rename include guard.
14157         * nat/glibc_thread_db.h: Rename include guard.
14158         * nat/gdb_thread_db.h: Rename include guard.
14159         * nat/gdb_ptrace.h: Rename include guard.
14160         * nat/fork-inferior.h: Rename include guard.
14161         * nat/amd64-linux-siginfo.h: Rename include guard.
14162         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14163         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14164         * nat/aarch64-linux.h: Rename include guard.
14165         * nat/aarch64-linux-hw-point.h: Rename include guard.
14166         * mn10300-tdep.h: Add include guard.
14167         * mips-linux-tdep.h: Add include guard.
14168         * mi/mi-parse.h: Rename include guard.
14169         * mi/mi-out.h: Rename include guard.
14170         * mi/mi-main.h: Rename include guard.
14171         * mi/mi-interp.h: Rename include guard.
14172         * mi/mi-getopt.h: Rename include guard.
14173         * mi/mi-console.h: Rename include guard.
14174         * mi/mi-common.h: Rename include guard.
14175         * mi/mi-cmds.h: Rename include guard.
14176         * mi/mi-cmd-break.h: Rename include guard.
14177         * m2-lang.h: Add include guard.
14178         * location.h: Rename include guard.
14179         * linux-record.h: Rename include guard.
14180         * linux-nat.h: Add include guard.
14181         * linux-fork.h: Add include guard.
14182         * i386-darwin-tdep.h: Rename include guard.
14183         * hppa-linux-offsets.h: Add include guard.
14184         * guile/guile.h: Rename include guard.
14185         * guile/guile-internal.h: Rename include guard.
14186         * gnu-nat.h: Rename include guard.
14187         * gdb-stabs.h: Rename include guard.
14188         * frv-tdep.h: Add include guard.
14189         * f-lang.h: Add include guard.
14190         * event-loop.h: Add include guard.
14191         * darwin-nat.h: Rename include guard.
14192         * cp-abi.h: Rename include guard.
14193         * config/sparc/nm-sol2.h: Rename include guard.
14194         * config/nm-nto.h: Rename include guard.
14195         * config/nm-linux.h: Add include guard.
14196         * config/i386/nm-i386gnu.h: Rename include guard.
14197         * config/djgpp/nl_types.h: Rename include guard.
14198         * config/djgpp/langinfo.h: Rename include guard.
14199         * compile/gcc-cp-plugin.h: Add include guard.
14200         * compile/gcc-c-plugin.h: Add include guard.
14201         * compile/compile.h: Rename include guard.
14202         * compile/compile-object-run.h: Rename include guard.
14203         * compile/compile-object-load.h: Rename include guard.
14204         * compile/compile-internal.h: Rename include guard.
14205         * compile/compile-cplus.h: Rename include guard.
14206         * compile/compile-c.h: Rename include guard.
14207         * common/xml-utils.h: Rename include guard.
14208         * common/x86-xstate.h: Rename include guard.
14209         * common/version.h: Rename include guard.
14210         * common/vec.h: Rename include guard.
14211         * common/tdesc.h: Rename include guard.
14212         * common/selftest.h: Rename include guard.
14213         * common/scoped_restore.h: Rename include guard.
14214         * common/scoped_mmap.h: Rename include guard.
14215         * common/scoped_fd.h: Rename include guard.
14216         * common/safe-iterator.h: Rename include guard.
14217         * common/run-time-clock.h: Rename include guard.
14218         * common/refcounted-object.h: Rename include guard.
14219         * common/queue.h: Rename include guard.
14220         * common/ptid.h: Rename include guard.
14221         * common/print-utils.h: Rename include guard.
14222         * common/preprocessor.h: Rename include guard.
14223         * common/pathstuff.h: Rename include guard.
14224         * common/observable.h: Rename include guard.
14225         * common/netstuff.h: Rename include guard.
14226         * common/job-control.h: Rename include guard.
14227         * common/host-defs.h: Rename include guard.
14228         * common/gdb_wait.h: Rename include guard.
14229         * common/gdb_vecs.h: Rename include guard.
14230         * common/gdb_unlinker.h: Rename include guard.
14231         * common/gdb_unique_ptr.h: Rename include guard.
14232         * common/gdb_tilde_expand.h: Rename include guard.
14233         * common/gdb_sys_time.h: Rename include guard.
14234         * common/gdb_string_view.h: Rename include guard.
14235         * common/gdb_splay_tree.h: Rename include guard.
14236         * common/gdb_setjmp.h: Rename include guard.
14237         * common/gdb_ref_ptr.h: Rename include guard.
14238         * common/gdb_optional.h: Rename include guard.
14239         * common/gdb_locale.h: Rename include guard.
14240         * common/gdb_assert.h: Rename include guard.
14241         * common/filtered-iterator.h: Rename include guard.
14242         * common/filestuff.h: Rename include guard.
14243         * common/fileio.h: Rename include guard.
14244         * common/environ.h: Rename include guard.
14245         * common/common-utils.h: Rename include guard.
14246         * common/common-types.h: Rename include guard.
14247         * common/common-regcache.h: Rename include guard.
14248         * common/common-inferior.h: Rename include guard.
14249         * common/common-gdbthread.h: Rename include guard.
14250         * common/common-exceptions.h: Rename include guard.
14251         * common/common-defs.h: Rename include guard.
14252         * common/common-debug.h: Rename include guard.
14253         * common/cleanups.h: Rename include guard.
14254         * common/buffer.h: Rename include guard.
14255         * common/btrace-common.h: Rename include guard.
14256         * common/break-common.h: Rename include guard.
14257         * cli/cli-utils.h: Rename include guard.
14258         * cli/cli-style.h: Rename include guard.
14259         * cli/cli-setshow.h: Rename include guard.
14260         * cli/cli-script.h: Rename include guard.
14261         * cli/cli-interp.h: Rename include guard.
14262         * cli/cli-decode.h: Rename include guard.
14263         * cli/cli-cmds.h: Rename include guard.
14264         * charset-list.h: Add include guard.
14265         * buildsym-legacy.h: Rename include guard.
14266         * bfin-tdep.h: Add include guard.
14267         * ax.h: Rename include guard.
14268         * arm-linux-tdep.h: Add include guard.
14269         * arm-fbsd-tdep.h: Add include guard.
14270         * arch/xtensa.h: Rename include guard.
14271         * arch/tic6x.h: Add include guard.
14272         * arch/i386.h: Add include guard.
14273         * arch/arm.h: Rename include guard.
14274         * arch/arm-linux.h: Rename include guard.
14275         * arch/arm-get-next-pcs.h: Rename include guard.
14276         * arch/amd64.h: Add include guard.
14277         * arch/aarch64-insn.h: Rename include guard.
14278         * arch-utils.h: Rename include guard.
14279         * annotate.h: Add include guard.
14280         * amd64-darwin-tdep.h: Rename include guard.
14281         * aarch64-linux-tdep.h: Add include guard.
14282         * aarch64-fbsd-tdep.h: Add include guard.
14283         * aarch32-linux-nat.h: Add include guard.
14284
14285 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14286
14287         * macrotab.c (macro_define_internal): New function that
14288         factorizes macro_define_object_internal and macro_define_function
14289         code.
14290         (macro_define_object_internal): Use macro_define_internal.
14291         (macro_define_function): Likewise.
14292
14293 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14294
14295         * macrocmd.c (extract_identifier): Return
14296         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14297         callers.
14298
14299 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14300
14301         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14302
14303 2019-02-05  Tom Tromey  <tom@tromey.com>
14304
14305         * target.c (target_stack::unpush): Move assertion earlier.
14306
14307 2019-01-30  Tom Tromey  <tom@tromey.com>
14308
14309         PR python/23615:
14310         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14311         (gdbpy_parse_and_eval): Likewise.
14312         * python/python-internal.h (gdbpy_allow_threads): New class.
14313
14314 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14315
14316         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14317         (aarch64_fbsd_fpregmap): Move earlier.
14318         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14319         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14320         instead of individual calls to trad_frame_set_reg_addr.
14321         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14322         earlier.
14323         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14324         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14325         instead of individual calls to trad_frame_set_reg_addr.
14326
14327 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14328
14329         * CONTRIBUTE: Replace contribution list with wiki link.
14330
14331 2019-01-25  Tom Tromey  <tom@tromey.com>
14332
14333         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14334
14335 2019-01-25  Tom Tromey  <tom@tromey.com>
14336
14337         * xtensa-linux-nat.c: Fix common/ includes.
14338         * xml-support.h: Fix common/ includes.
14339         * xml-support.c: Fix common/ includes.
14340         * x86-linux-nat.c: Fix common/ includes.
14341         * windows-nat.c: Fix common/ includes.
14342         * varobj.h: Fix common/ includes.
14343         * varobj.c: Fix common/ includes.
14344         * value.c: Fix common/ includes.
14345         * valops.c: Fix common/ includes.
14346         * utils.c: Fix common/ includes.
14347         * unittests/xml-utils-selftests.c: Fix common/ includes.
14348         * unittests/utils-selftests.c: Fix common/ includes.
14349         * unittests/unpack-selftests.c: Fix common/ includes.
14350         * unittests/tracepoint-selftests.c: Fix common/ includes.
14351         * unittests/style-selftests.c: Fix common/ includes.
14352         * unittests/string_view-selftests.c: Fix common/ includes.
14353         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14354         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14355         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14356         * unittests/rsp-low-selftests.c: Fix common/ includes.
14357         * unittests/parse-connection-spec-selftests.c: Fix common/
14358         includes.
14359         * unittests/optional-selftests.c: Fix common/ includes.
14360         * unittests/offset-type-selftests.c: Fix common/ includes.
14361         * unittests/observable-selftests.c: Fix common/ includes.
14362         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14363         * unittests/memrange-selftests.c: Fix common/ includes.
14364         * unittests/memory-map-selftests.c: Fix common/ includes.
14365         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14366         * unittests/function-view-selftests.c: Fix common/ includes.
14367         * unittests/environ-selftests.c: Fix common/ includes.
14368         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14369         * unittests/common-utils-selftests.c: Fix common/ includes.
14370         * unittests/cli-utils-selftests.c: Fix common/ includes.
14371         * unittests/array-view-selftests.c: Fix common/ includes.
14372         * ui-file.c: Fix common/ includes.
14373         * tui/tui-io.c: Fix common/ includes.
14374         * tracepoint.h: Fix common/ includes.
14375         * tracepoint.c: Fix common/ includes.
14376         * tracefile-tfile.c: Fix common/ includes.
14377         * top.h: Fix common/ includes.
14378         * top.c: Fix common/ includes.
14379         * thread.c: Fix common/ includes.
14380         * target/waitstatus.h: Fix common/ includes.
14381         * target/waitstatus.c: Fix common/ includes.
14382         * target.h: Fix common/ includes.
14383         * target.c: Fix common/ includes.
14384         * target-memory.c: Fix common/ includes.
14385         * target-descriptions.c: Fix common/ includes.
14386         * symtab.h: Fix common/ includes.
14387         * symfile.c: Fix common/ includes.
14388         * stap-probe.c: Fix common/ includes.
14389         * spu-linux-nat.c: Fix common/ includes.
14390         * sparc-nat.c: Fix common/ includes.
14391         * source.c: Fix common/ includes.
14392         * solib.c: Fix common/ includes.
14393         * solib-target.c: Fix common/ includes.
14394         * ser-unix.c: Fix common/ includes.
14395         * ser-tcp.c: Fix common/ includes.
14396         * ser-pipe.c: Fix common/ includes.
14397         * ser-base.c: Fix common/ includes.
14398         * selftest-arch.c: Fix common/ includes.
14399         * s12z-tdep.c: Fix common/ includes.
14400         * rust-exp.y: Fix common/ includes.
14401         * rs6000-aix-tdep.c: Fix common/ includes.
14402         * riscv-tdep.c: Fix common/ includes.
14403         * remote.c: Fix common/ includes.
14404         * remote-notif.h: Fix common/ includes.
14405         * remote-fileio.h: Fix common/ includes.
14406         * remote-fileio.c: Fix common/ includes.
14407         * regcache.h: Fix common/ includes.
14408         * regcache.c: Fix common/ includes.
14409         * record-btrace.c: Fix common/ includes.
14410         * python/python.c: Fix common/ includes.
14411         * python/py-type.c: Fix common/ includes.
14412         * python/py-inferior.c: Fix common/ includes.
14413         * progspace.h: Fix common/ includes.
14414         * producer.c: Fix common/ includes.
14415         * procfs.c: Fix common/ includes.
14416         * proc-api.c: Fix common/ includes.
14417         * printcmd.c: Fix common/ includes.
14418         * ppc-linux-nat.c: Fix common/ includes.
14419         * parser-defs.h: Fix common/ includes.
14420         * osdata.c: Fix common/ includes.
14421         * obsd-nat.c: Fix common/ includes.
14422         * nat/x86-linux.c: Fix common/ includes.
14423         * nat/x86-linux-dregs.c: Fix common/ includes.
14424         * nat/x86-dregs.h: Fix common/ includes.
14425         * nat/x86-dregs.c: Fix common/ includes.
14426         * nat/ppc-linux.c: Fix common/ includes.
14427         * nat/mips-linux-watch.h: Fix common/ includes.
14428         * nat/mips-linux-watch.c: Fix common/ includes.
14429         * nat/linux-waitpid.c: Fix common/ includes.
14430         * nat/linux-ptrace.h: Fix common/ includes.
14431         * nat/linux-ptrace.c: Fix common/ includes.
14432         * nat/linux-procfs.c: Fix common/ includes.
14433         * nat/linux-personality.c: Fix common/ includes.
14434         * nat/linux-osdata.c: Fix common/ includes.
14435         * nat/linux-namespaces.c: Fix common/ includes.
14436         * nat/linux-btrace.h: Fix common/ includes.
14437         * nat/linux-btrace.c: Fix common/ includes.
14438         * nat/fork-inferior.c: Fix common/ includes.
14439         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14440         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14441         * nat/aarch64-linux.c: Fix common/ includes.
14442         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14443         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14444         * namespace.h: Fix common/ includes.
14445         * mips-linux-tdep.c: Fix common/ includes.
14446         * minsyms.c: Fix common/ includes.
14447         * mi/mi-parse.h: Fix common/ includes.
14448         * mi/mi-main.c: Fix common/ includes.
14449         * mi/mi-cmd-env.c: Fix common/ includes.
14450         * memrange.h: Fix common/ includes.
14451         * memattr.c: Fix common/ includes.
14452         * maint.h: Fix common/ includes.
14453         * maint.c: Fix common/ includes.
14454         * main.c: Fix common/ includes.
14455         * machoread.c: Fix common/ includes.
14456         * location.c: Fix common/ includes.
14457         * linux-thread-db.c: Fix common/ includes.
14458         * linux-nat.c: Fix common/ includes.
14459         * linux-fork.c: Fix common/ includes.
14460         * inline-frame.c: Fix common/ includes.
14461         * infrun.c: Fix common/ includes.
14462         * inflow.c: Fix common/ includes.
14463         * inferior.h: Fix common/ includes.
14464         * inferior.c: Fix common/ includes.
14465         * infcmd.c: Fix common/ includes.
14466         * inf-ptrace.c: Fix common/ includes.
14467         * inf-child.c: Fix common/ includes.
14468         * ia64-linux-nat.c: Fix common/ includes.
14469         * i387-tdep.c: Fix common/ includes.
14470         * i386-tdep.c: Fix common/ includes.
14471         * i386-linux-tdep.c: Fix common/ includes.
14472         * i386-linux-nat.c: Fix common/ includes.
14473         * i386-go32-tdep.c: Fix common/ includes.
14474         * i386-fbsd-tdep.c: Fix common/ includes.
14475         * i386-fbsd-nat.c: Fix common/ includes.
14476         * guile/scm-type.c: Fix common/ includes.
14477         * guile/guile.c: Fix common/ includes.
14478         * go32-nat.c: Fix common/ includes.
14479         * gnu-nat.c: Fix common/ includes.
14480         * gdbthread.h: Fix common/ includes.
14481         * gdbarch-selftests.c: Fix common/ includes.
14482         * gdb_usleep.c: Fix common/ includes.
14483         * gdb_select.h: Fix common/ includes.
14484         * gdb_bfd.c: Fix common/ includes.
14485         * gcore.c: Fix common/ includes.
14486         * fork-child.c: Fix common/ includes.
14487         * findvar.c: Fix common/ includes.
14488         * fbsd-nat.c: Fix common/ includes.
14489         * event-top.c: Fix common/ includes.
14490         * event-loop.c: Fix common/ includes.
14491         * dwarf2read.c: Fix common/ includes.
14492         * dwarf2loc.c: Fix common/ includes.
14493         * dwarf2-frame.c: Fix common/ includes.
14494         * dwarf-index-cache.c: Fix common/ includes.
14495         * dtrace-probe.c: Fix common/ includes.
14496         * disasm-selftests.c: Fix common/ includes.
14497         * defs.h: Fix common/ includes.
14498         * csky-tdep.c: Fix common/ includes.
14499         * cp-valprint.c: Fix common/ includes.
14500         * cp-support.h: Fix common/ includes.
14501         * cp-support.c: Fix common/ includes.
14502         * corelow.c: Fix common/ includes.
14503         * completer.h: Fix common/ includes.
14504         * completer.c: Fix common/ includes.
14505         * compile/compile.c: Fix common/ includes.
14506         * compile/compile-loc2c.c: Fix common/ includes.
14507         * compile/compile-cplus-types.c: Fix common/ includes.
14508         * compile/compile-cplus-symbols.c: Fix common/ includes.
14509         * command.h: Fix common/ includes.
14510         * cli/cli-dump.c: Fix common/ includes.
14511         * cli/cli-cmds.c: Fix common/ includes.
14512         * charset.c: Fix common/ includes.
14513         * build-id.c: Fix common/ includes.
14514         * btrace.h: Fix common/ includes.
14515         * btrace.c: Fix common/ includes.
14516         * breakpoint.h: Fix common/ includes.
14517         * breakpoint.c: Fix common/ includes.
14518         * ax.h:
14519         (enum agent_op): Fix common/ includes.
14520         * ax-general.c (struct aop_map): Fix common/ includes.
14521         * ax-gdb.c: Fix common/ includes.
14522         * auxv.c: Fix common/ includes.
14523         * auto-load.c: Fix common/ includes.
14524         * arm-tdep.c: Fix common/ includes.
14525         * arch/riscv.c: Fix common/ includes.
14526         * arch/ppc-linux-common.c: Fix common/ includes.
14527         * arch/i386.c: Fix common/ includes.
14528         * arch/arm.c: Fix common/ includes.
14529         * arch/arm-linux.c: Fix common/ includes.
14530         * arch/arm-get-next-pcs.c: Fix common/ includes.
14531         * arch/amd64.c: Fix common/ includes.
14532         * arch/aarch64.c: Fix common/ includes.
14533         * arch/aarch64-insn.c: Fix common/ includes.
14534         * arch-utils.c: Fix common/ includes.
14535         * amd64-windows-tdep.c: Fix common/ includes.
14536         * amd64-tdep.c: Fix common/ includes.
14537         * amd64-sol2-tdep.c: Fix common/ includes.
14538         * amd64-obsd-tdep.c: Fix common/ includes.
14539         * amd64-nbsd-tdep.c: Fix common/ includes.
14540         * amd64-linux-tdep.c: Fix common/ includes.
14541         * amd64-linux-nat.c: Fix common/ includes.
14542         * amd64-fbsd-tdep.c: Fix common/ includes.
14543         * amd64-fbsd-nat.c: Fix common/ includes.
14544         * amd64-dicos-tdep.c: Fix common/ includes.
14545         * amd64-darwin-tdep.c: Fix common/ includes.
14546         * agent.c: Fix common/ includes.
14547         * ada-lang.h: Fix common/ includes.
14548         * ada-lang.c: Fix common/ includes.
14549         * aarch64-tdep.c: Fix common/ includes.
14550
14551 2019-01-25  Tom Tromey  <tom@tromey.com>
14552
14553         * common/create-version.sh: Use common/version.h.
14554
14555 2019-01-24  Pedro Alves  <palves@redhat.com>
14556
14557         * infrun.c (signal_stop, signal_print, signal_program)
14558         (signal_catch, signal_pass): Now arrays instead of pointers.
14559         (update_signals_program_target, do_target_resume)
14560         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14561         * linux-nat.c (linux_nat_target::pass_signals)
14562         (linux_nat_target::create_inferior, linux_nat_target::attach):
14563         Adjust.
14564         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14565         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14566         * procfs.c (procfs_target::pass_signals): Adjust.
14567         * record-full.c (record_full_target::resume): Adjust.
14568         * remote.c (remote_target::pass_signals)
14569         (remote_target::program_signals): Adjust.
14570         * target-debug.h (target_debug_print_signals): Now takes a
14571         gdb::array_view as parameter.  Adjust.
14572         * target.h (target_ops) <pass_signals, program_signals>: Replace
14573         pointer and length parameters with gdb::array_view.
14574         (target_pass_signals, target_program_signals): Likewise.
14575         * target-delegates.c: Regenerate.
14576
14577 2019-01-24  Pedro Alves  <palves@redhat.com>
14578
14579         * common/forward-scope-exit.h
14580         (forward_scope_exit::forward_scope_exit): Pass arguments to
14581         m_bind_function directly, instead of creating a std::bind and
14582         copying that.
14583
14584 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14585
14586         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14587         for static members.
14588         (pass_in_v_vfp_candidate): Likewise.
14589
14590 2019-01-23  Tom Tromey  <tom@tromey.com>
14591             Pedro Alves  <palves@redhat.com>
14592
14593         * regcache.c (class regcache_invalidator): Remove.
14594         (regcache::raw_write): Use make_scope_exit.
14595
14596 2019-01-23  Tom Tromey  <tom@tromey.com>
14597
14598         * ui-out.h (class ui_out_emit_type): Update comment.
14599
14600 2019-01-23  Tom Tromey  <tom@tromey.com>
14601
14602         * infrun.c (fetch_inferior_event): Update comment.
14603
14604 2019-01-23  Tom Tromey  <tom@tromey.com>
14605             Pedro Alves  <palves@redhat.com>
14606
14607         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14608         parameter.
14609         (fetch_inferior_event): Use SCOPE_EXIT.
14610
14611
14612 2019-01-23  Tom Tromey  <tom@tromey.com>
14613             Pedro Alves  <palves@redhat.com>
14614
14615         * infrun.c (disable_thread_events): Delete.
14616         (stop_all_threads): Use SCOPE_EXIT.
14617
14618 2019-01-23  Tom Tromey  <tom@tromey.com>
14619             Pedro Alves  <palves@redhat.com>
14620
14621         * symfile.c: Include forward-scope-exit.h.
14622         (clear_symtab_users_cleanup): Replace forward declaration with
14623         a FORWARD_SCOPE_EXIT.
14624         (syms_from_objfile_1): Use the forward_scope_exit and
14625         gdb::optional instead of cleanup_function.
14626         (reread_symbols): Use the forward_scope_exit instead of
14627         cleanup_function.
14628         (clear_symtab_users_cleanup): Remove function.
14629
14630 2019-01-23  Tom Tromey  <tom@tromey.com>
14631             Pedro Alves  <palves@redhat.com>
14632
14633         * linux-nat.c: Include scope-exit.h.
14634         (cleanup_target_stop): Remove.
14635         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14636         SCOPE_EXIT.
14637
14638 2019-01-23  Tom Tromey  <tom@tromey.com>
14639             Pedro Alves  <palves@redhat.com>
14640
14641         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14642         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14643
14644 2019-01-23  Tom Tromey  <tom@tromey.com>
14645             Andrew Burgess  <andrew.burgess@embecosm.com>
14646             Pedro Alves  <palves@redhat.com>
14647
14648         * infrun.c (fetch_inferior_event): Use scope_exit.
14649         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14650         * top.c (execute_command): Use scope_exit.
14651         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14652         * utils.c (do_bpstat_clear_actions_cleanup)
14653         (make_bpstat_clear_actions_cleanup): Remove.
14654
14655 2019-01-23  Tom Tromey  <tom@tromey.com>
14656             Pedro Alves  <palves@redhat.com>
14657
14658         * infrun.c: Include "common/scope-exit.h"
14659         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14660         (wait_for_inferior): Use SCOPE_EXIT.
14661         (fetch_inferior_event): Use scope_exit.
14662
14663 2019-01-23  Tom Tromey  <tom@tromey.com>
14664             Pedro Alves  <palves@redhat.com>
14665
14666         * breakpoint.c (create_breakpoint): Remove cleanup.
14667
14668 2019-01-23  Tom Tromey  <tom@tromey.com>
14669             Andrew Burgess  <andrew.burgess@embecosm.com>
14670             Pedro Alves  <palves@redhat.com>
14671
14672 2019-01-23  Pedro Alves  <palves@redhat.com>
14673
14674         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14675
14676 2019-01-23  Pedro Alves  <palves@redhat.com>
14677             Andrew Burgess  <andrew.burgess@embecosm.com>
14678
14679         * gdbthread.h: Include "common/forward-scope-exit.h".
14680         (scoped_finish_thread_state): Redefine custom class in terms of
14681         forward_scope_exit.
14682
14683 2019-01-23  Pedro Alves  <palves@redhat.com>
14684             Andrew Burgess  <andrew.burgess@embecosm.com>
14685
14686         * common/forward-scope-exit.h: New file.
14687
14688 2019-01-23  Pedro Alves  <palves@redhat.com>
14689             Andrew Burgess  <andrew.burgess@embecosm.com>
14690             Tom Tromey  <tom@tromey.com>
14691
14692         * common/scope-exit.h: New file.
14693
14694 2019-01-23  Pedro Alves  <palves@redhat.com>
14695
14696         * common/preprocessor.h (ESC): Rename to ...
14697         (ESC_PARENS): ... this.
14698         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14699         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14700
14701 2019-01-23  Tom Tromey  <tom@tromey.com>
14702
14703         * language.h (class scoped_switch_to_sym_language_if_auto):
14704         Initialize m_lang in both cases.
14705
14706 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14707
14708         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14709         with XCNEW.
14710
14711 2019-01-22  Tom Tromey  <tom@tromey.com>
14712
14713         * corelow.c: Do not include sys/file.h.
14714
14715 2019-01-22  Tom Tromey  <tom@tromey.com>
14716
14717         * tui/tui-wingeneral.h: Include gdb_curses.h.
14718
14719 2019-01-22  Tom Tromey  <tom@tromey.com>
14720
14721         * source-cache.h (class source_cache) <get_source_lines,
14722         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14723
14724 2019-01-22  Tom Tromey  <tom@tromey.com>
14725
14726         * remote-fileio.h (struct remote_target): Declare.
14727
14728 2019-01-22  Tom Tromey  <tom@tromey.com>
14729
14730         * python/py-arch.c: Do not include py-ref.h.
14731         * python/py-bpevent.c: Do not include py-ref.h.
14732         * python/py-cmd.c: Do not include py-ref.h.
14733         * python/py-continueevent.c: Do not include py-ref.h.
14734         * python/py-event.h: Do not include py-ref.h.
14735         * python/py-evtregistry.c: Do not include py-ref.h.
14736         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14737         * python/py-frame.c: Do not include py-ref.h.
14738         * python/py-framefilter.c: Do not include py-ref.h.
14739         * python/py-function.c: Do not include py-ref.h.
14740         * python/py-infevents.c: Do not include py-ref.h.
14741         * python/py-linetable.c: Do not include py-ref.h.
14742         * python/py-objfile.c: Do not include py-ref.h.
14743         * python/py-param.c: Do not include py-ref.h.
14744         * python/py-prettyprint.c: Do not include py-ref.h.
14745         * python/py-progspace.c: Do not include py-ref.h.
14746         * python/py-symbol.c: Do not include py-ref.h.
14747         * python/py-symtab.c: Do not include py-ref.h.
14748         * python/py-type.c: Do not include py-ref.h.
14749         * python/py-unwind.c: Do not include py-ref.h.
14750         * python/py-utils.c: Do not include py-ref.h.
14751         * python/py-value.c: Do not include py-ref.h.
14752         * python/py-varobj.c: Do not include py-ref.h.
14753         * python/py-xmethods.c: Do not include py-ref.h.
14754         * python/python.c: Do not include py-ref.h.
14755         * varobj.c: Do not include py-ref.h.
14756
14757 2019-01-22  Tom Tromey  <tom@tromey.com>
14758
14759         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14760         keyword for bcache.
14761
14762 2019-01-22  Tom Tromey  <tom@tromey.com>
14763
14764         * compile/compile-cplus-types.c: Remove a comment by #include.
14765
14766 2019-01-22  Tom Tromey  <tom@tromey.com>
14767
14768         * compile/gcc-c-plugin.h: Include compile-internal.h.
14769
14770 2019-01-22  Tom Tromey  <tom@tromey.com>
14771
14772         * stabsread.c (EXTERN): Do not define.
14773         (symnum, next_symbol_text_func, processing_gcc_compilation)
14774         (within_function, global_sym_chain, global_stabs)
14775         (previous_stab_code, this_object_header_files)
14776         (n_this_object_header_files)
14777         (n_allocated_this_object_header_files): Define.
14778         * stabsread.h (EXTERN): Never define.  Use "extern".
14779
14780 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14781
14782         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14783         history_value.
14784
14785 2019-01-21  Tom Tromey  <tom@tromey.com>
14786
14787         * ui-out.c: Fix includes.
14788         * tui/tui-source.c: Fix includes.
14789         * target.c: Fix includes.
14790         * remote.c: Fix includes.
14791         * regcache.c: Fix includes.
14792         * python/py-block.c: Fix includes.
14793         * printcmd.c: Fix includes.
14794         * or1k-tdep.c: Fix includes.
14795         * mi/mi-main.c: Fix includes.
14796         * m32r-tdep.c: Fix includes.
14797         * csky-tdep.c: Fix includes.
14798         * compile/compile-cplus-types.c: Fix includes.
14799         * cli/cli-interp.c: Fix includes.
14800
14801 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14802
14803         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14804         for padding.
14805
14806 2019-01-16  Tom Tromey  <tom@tromey.com>
14807
14808         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14809         earlier.
14810         (struct objfile) <msymbols_range>: Move from top level.
14811         <msymbols>: New method.
14812         (class objfile_msymbols): Remove.
14813         * symtab.c (default_collect_symbol_completion_matches_break_on):
14814         Update.
14815         * symmisc.c (dump_msymbols): Update.
14816         * stabsread.c (scan_file_globals): Update.
14817         * objc-lang.c (info_selectors_command, info_classes_command)
14818         (find_methods): Update.
14819         * minsyms.c (find_solib_trampoline_target): Update.
14820         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14821         * coffread.c (coff_symfile_read): Update.
14822         * ada-lang.c (ada_lookup_simple_minsym)
14823         (ada_collect_symbol_completion_matches): Update.
14824
14825 2019-01-16  Tom Tromey  <tom@tromey.com>
14826
14827         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14828         type.  Remove no-argument constructor.
14829         <iterator::operator++>: Simplify.
14830         <begin>: Update.
14831         <end>: Use minimal_symbol_count.
14832
14833 2019-01-16  Tom Tromey  <tom@tromey.com>
14834
14835         * objfiles.h (struct objfile) <psymtabs>: New method.
14836         (class objfile_psymtabs): Remove.
14837         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14838         typedef.
14839         <range>: New method.
14840         (require_partial_symbols): Change return type.
14841         * psymtab.c (require_partial_symbols)
14842         (psym_expand_symtabs_matching): Update.
14843         * mdebugread.c (parse_partial_symbols): Update.
14844         * dbxread.c (dbx_end_psymtab): Update.
14845
14846 2019-01-15  Tom Tromey  <tom@tromey.com>
14847
14848         * symtab.c (lookup_objfile_from_block)
14849         (lookup_symbol_in_objfile_symtabs)
14850         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14851         (find_line_symtab, info_sources_command)
14852         (default_collect_symbol_completion_matches_break_on)
14853         (make_source_files_completion_list): Update.
14854         * symmisc.c (print_objfile_statistics, dump_objfile)
14855         (maintenance_print_symbols, maintenance_info_symtabs)
14856         (maintenance_check_symtabs, maintenance_info_line_tables):
14857         Update.
14858         * source.c (select_source_symtab)
14859         (forget_cached_source_info_for_objfile): Update.
14860         * objfiles.h (class objfile_compunits): Remove.
14861         (struct objfile) <compunits_range>: New typedef.
14862         (compunits): New method.
14863         * objfiles.c (objfile_relocate1): Update.
14864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14865         * maint.c (count_symtabs_and_blocks): Update.
14866         * linespec.c (iterate_over_all_matching_symtabs): Update.
14867         * cp-support.c (add_symbol_overload_list_qualified): Update.
14868         * coffread.c (coff_symtab_read): Update.
14869         * ada-lang.c (add_nonlocal_symbols)
14870         (ada_collect_symbol_completion_matches)
14871         (ada_add_global_exceptions): Update.
14872
14873 2019-01-15  Tom Tromey  <tom@tromey.com>
14874
14875         * progspace.h (program_space) <objfiles_safe_range>: New
14876         typedef.
14877         <objfiles_safe>: New method.
14878         * objfiles.h (class all_objfiles_safe): Remove.
14879         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14880         * jit.c (jit_inferior_exit_hook): Update.
14881
14882 2019-01-17  Tom Tromey  <tom@tromey.com>
14883
14884         * progspace.h (program_space) <objfiles_range>: New typedef.
14885         <objfiles>: New method.
14886         <objfiles_head>: Rename from objfiles.
14887         (object_files): Update.
14888         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14889         * guile/scm-pretty-print.c
14890         (ppscm_find_pretty_printer_from_objfiles): Update.
14891         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14892         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14893         Update.
14894         * python/py-progspace.c (pspy_get_objfiles): Update.
14895         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14896         Update.
14897         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14898         (objfpy_lookup_objfile_by_build_id): Update.
14899         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14900         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14901         Update.
14902         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14903         (expand_symtab_containing_pc, lookup_objfile_from_block)
14904         (lookup_static_symbol, basic_lookup_transparent_type)
14905         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14906         (find_line_symtab, info_sources_command)
14907         (default_collect_symbol_completion_matches_break_on)
14908         (make_source_files_completion_list, find_main_name): Update.
14909         * symmisc.c (print_symbol_bcache_statistics)
14910         (print_objfile_statistics, maintenance_print_symbols)
14911         (maintenance_print_msymbols, maintenance_print_objfiles)
14912         (maintenance_info_symtabs, maintenance_check_symtabs)
14913         (maintenance_expand_symtabs, maintenance_info_line_tables):
14914         Update.
14915         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14916         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14917         (map_overlay_command, unmap_overlay_command)
14918         (simple_overlay_update, expand_symtabs_matching)
14919         (map_symbol_filenames): Update.
14920         * symfile-debug.c (set_debug_symfile): Update.
14921         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14922         Update.
14923         * source.c (select_source_symtab, forget_cached_source_info):
14924         Update.
14925         * solib.c (solib_read_symbols): Update.
14926         * solib-spu.c (append_ocl_sos): Update.
14927         * psymtab.c (maintenance_print_psymbols)
14928         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14929         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14930         * printcmd.c (info_symbol_command): Update.
14931         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14932         Update.
14933         * objfiles.h (class all_objfiles): Remove.
14934         * objfiles.c (have_partial_symbols, have_full_symbols)
14935         (have_minimal_symbols, qsort_cmp, update_section_map)
14936         (shared_objfile_contains_address_p)
14937         (default_iterate_over_objfiles_in_search_order): Update.
14938         * objc-lang.c (info_selectors_command, info_classes_command)
14939         (find_methods): Update.
14940         * minsyms.c (find_solib_trampoline_target): Update.
14941         * maint.c (maintenance_info_sections)
14942         (maintenance_translate_address, count_symtabs_and_blocks):
14943         Update.
14944         * main.c (captured_main_1): Update.
14945         * linux-thread-db.c (try_thread_db_load_from_pdir)
14946         (has_libpthread): Update.
14947         * linespec.c (iterate_over_all_matching_symtabs)
14948         (search_minsyms_for_name): Update.
14949         * jit.c (jit_find_objf_with_entry_addr): Update.
14950         * hppa-tdep.c (find_unwind_entry)
14951         (hppa_lookup_stub_minimal_symbol): Update.
14952         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14953         Update.
14954         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14955         (elf_gnu_ifunc_resolve_by_got): Update.
14956         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14957         * dwarf-index-write.c (save_gdb_index_command): Update.
14958         * cp-support.c (add_symbol_overload_list_qualified): Update.
14959         * breakpoint.c (create_overlay_event_breakpoint)
14960         (create_longjmp_master_breakpoint)
14961         (create_std_terminate_master_breakpoint)
14962         (create_exception_master_breakpoint): Update.
14963         * blockframe.c (find_pc_partial_function): Update.
14964         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14965         (ada_collect_symbol_completion_matches)
14966         (ada_add_global_exceptions): Update.
14967
14968 2019-01-17  Tom Tromey  <tom@tromey.com>
14969
14970         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14971         declare VEC.
14972         (solib_target_parse_libraries): Change return type.
14973         (library_list_start_segment, library_list_start_section)
14974         (library_list_end_library, library_list_start_library); Update.
14975         (solib_target_free_library_list): Remove.
14976         (solib_target_parse_libraries): Remove cleanup.  Change return
14977         type.
14978         (solib_target_current_sos): Update.
14979
14980 2019-01-17  Tom Tromey  <tromey@bapiya>
14981
14982         * valprint.c: Replace "the the" with "the".
14983         * symtab.c: Replace "the the" with "the".
14984         * solib.c: Replace "the the" with "the".
14985         * solib-dsbt.c: Replace "the the" with "the".
14986         * linespec.c: Replace "the the" with "the".
14987         * dwarf2loc.h: Replace "the the" with "the".
14988         * amd64-windows-tdep.c: Replace "the the" with "the".
14989         * aarch64-tdep.c: Replace "the the" with "the".
14990
14991 2019-01-16  Keith Seitz  <keiths@redhat.com>
14992
14993         PR gdb/23773
14994         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14995         <builder>: Rename to ..
14996         <m_builder>: ... this and make private.
14997         (dwarf2_cu::get_builder): New method.  Change all users of
14998         `builder' to use this method.
14999         (dwarf2_start_symtab): Move to ...
15000         (dwarf2_cu::start_symtab): ... here.  Update all callers
15001         (setup_type_unit_groups): Move to ...
15002         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15003         callers.
15004         (dwarf2_cu::reset_builder): New method.
15005         (process_full_compunit, process_full_type_unit): Use
15006         dwarf2_cu::reset_builder.
15007         (follow_die_offset): Record the ancestor CU if it is different
15008         from the followed DIE's CU.
15009         (follow_die_sig_1): Likewise.
15010
15011 2019-01-15  Tom Tromey  <tom@tromey.com>
15012
15013         * remote.c (class remote_state) <buf>: Now a char_vector.
15014         <buf_size>: Remove.
15015         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15016         parameter.
15017         (remote_target::getpkt_or_notif_sane_1)
15018         (remote_target::getpkt_sane)
15019         (remote_target::getpkt_or_notif_sane): Likewise.
15020         (class remote_target) <putpkt>: New overload.
15021         (remote_target::read_frame): Change type of "buf_p".  Remove
15022         sizeof_p parameter.
15023         (packet_ok): New overload.
15024         (packet_check_result): New overload.
15025         Update all uses.
15026
15027 2019-01-14  Tom Tromey  <tom@tromey.com>
15028
15029         * remote-notif.c (handle_notification, remote_notif_ack)
15030         (remote_notif_parse): Make "buf" const.
15031         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15032         const.
15033         (remote_notif_parse, remote_notif_ack, handle_notification):
15034         Likewise.
15035         * remote.c (remote_notif_stop_parse): Make "buf" const.
15036         (remote_target::remote_parse_stop_reply): Make "buf" const.
15037         (remote_notif_stop_ack): Make "buf" const.
15038
15039 2019-01-14  Tom Tromey  <tom@tromey.com>
15040
15041         * remote.c (remote_console_output): Make parameter const.
15042
15043 2019-01-14  Tom Tromey  <tom@tromey.com>
15044
15045         * target-debug.h (target_debug_print_signals): Constify.
15046         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15047         * procfs.c (procfs_target::pass_signals): Update.
15048         * linux-nat.c (linux_nat_target::pass_signals): Update.
15049         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15050         * target-delegates.c: Rebuild.
15051         * remote.c (remote_target::program_signals): Update.
15052         (remote_target::pass_signals): Update.
15053         * target.c (target_pass_signals): Constify argument.
15054         (target_program_signals): Likewise.
15055         * target.h (struct target_ops) <pass_signals, program_signals>:
15056         Constify argument.
15057         (target_pass_signals, target_program_signals): Constify argument.
15058
15059 2019-01-14  Tom Tromey  <tom@tromey.com>
15060
15061         PR tui/28819:
15062         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15063
15064 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15065
15066         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15067         field.
15068         * rs6000-tdep.c: Include reggroups.h.
15069         (IS_V_ALIAS_PSEUDOREG): Define.
15070         (rs6000_register_name): Return names for the "vX" aliases.
15071         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15072         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15073         aliases.  Call default_register_reggroup_p for all other
15074         pseudo-registers.
15075         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15076         New functions.
15077         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15078         Handle "vX" aliases.
15079         (v_alias_pseudo_register_collect): New function.
15080         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15081         (rs6000_gdbarch_init): Initialize "vX" aliases as
15082         pseudo-registers.  Restore registration of
15083         rs6000_pseudo_register_reggroup_p with
15084         set_tdesc_pseudo_register_reggroup_p.
15085
15086 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15087
15088         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15089         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15090         set_gdbarch_num_pseudo_regs.
15091
15092 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15093
15094         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15095         Remove arg prefixname, add do_set and do_show.
15096         Add member functions set_list and show_list.
15097         * cli/cli-style.c (class cli_style_option): Update accordingly.
15098         (style_set_list): Move to file scope.
15099         (style_show_list): Likewise.
15100         (set_style): Call help_list.
15101         (show_style): Call cmd_show_list.
15102         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15103         Update to use the new macro.
15104
15105 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15106
15107         * ada-lang.c (_initialize_ada_language): Expand the help text
15108         for the "catch exception" command.
15109
15110 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15111
15112         * symtab.c (matching_obj_sections): Initialize obj,
15113         declare it closer to its usage.
15114
15115 2019-01-10  Tom Tromey  <tom@tromey.com>
15116
15117         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15118         (basic_inf_threads_range): Remove.
15119         (inf_threads_range, inf_non_exited_threads_range)
15120         (safe_inf_threads_range): Use next_adapter.
15121
15122 2019-01-10  Keith Seitz  <keiths@redhat.com>
15123
15124         PR gdb/23712
15125         PR symtab/23010
15126         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15127         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15128
15129 2019-01-10  Keith Seitz  <keiths@redhat.com>
15130
15131         PR gdb/23712
15132         PR symtab/23010
15133         * dictionary.c (pending_to_vector): Remove.
15134         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15135         Remove _1 suffix, replacing functions of the same name.  Update
15136         all callers.
15137         (dict_create_hashed, dict_create_hashed_expandable)
15138         (dict_create_linear, dict_create_linear_expandable, dict_free)
15139         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15140         Make functions static.
15141
15142 2019-01-10  Keith Seitz  <keiths@redhat.com>
15143
15144         PR gdb/23712
15145         PR symtab/23010
15146         * dictionary.h (struct dictionary): Replace declaration with
15147         multidictionary.
15148         (dict_create_hashed, dict_create_hashed_expandable)
15149         (dict_create_linear, dict_create_linear_expandable)
15150         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15151         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15152         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15153         taking multidictionary argument.
15154         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15155         * block.h (struct block) <dict>: Change to multidictionary
15156         and rename `multidict'.
15157         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15158         symmisc.c: Update all dictionary references to multidictionary.
15159
15160 2019-01-10  Keith Seitz  <keiths@redhat.com>
15161
15162         PR gdb/23712
15163         PR symtab/23010
15164         * dictionary.c: Include unordered_map.
15165         (pending_to_vector): New function.
15166         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15167         Rewrite the non-"_1" functions to take vector instead
15168         of linked list.
15169         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15170         "new" _1 versions of the same name.
15171         (multidictionary): Define.
15172         (std::hash<enum language): New definition.
15173         (collate_pending_symbols_by_language, mdict_create_hashed)
15174         (mdict_create_hashed_expandable, mdict_create_linear)
15175         (mdict_create_linear_expandable, mdict_free)
15176         (find_language_dictionary, create_new_language_dictionary)
15177         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15178         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15179         (mdict_size, mdict_empty): New functions.
15180         * dictionary.h (mdict_iterator): Define.
15181
15182 2019-01-10  Pedro Alves  <palves@redhat.com>
15183
15184         * breakpoint.c (read_uploaded_action)
15185         (create_tracepoint_from_upload): Adjust to use
15186         gdb::unique_xmalloc_ptr.
15187         * ctf.c (ctf_write_uploaded_tp):
15188         (SET_ARRAY_FIELD): Use emplace_back.
15189         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15190         * tracefile-tfile.c (tfile_write_uploaded_tp):
15191         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15192         gdb::unique_xmalloc_ptr.
15193         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15194         at_string, cond_string, cmd_strings>: Replace char pointers
15195         with gdb::unique_xmalloc_ptr.
15196
15197 2019-01-10  Pedro Alves  <palves@redhat.com>
15198
15199         * solib-target.c (library_list_start_library): Don't xstrdup name.
15200
15201 2019-01-10  Pedro Alves  <palves@redhat.com>
15202
15203         * mdebugread.c (parse_partial_symbols): Use
15204         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15205
15206 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15207
15208         * linux-fork.c (scoped_switch_fork_info)
15209         <~scoped_switch_fork_info>: Fix incorrect variable name.
15210
15211 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15212
15213         * linux-fork.c (scoped_switch_fork_info)
15214         <scoped_switch_fork_info>: Make explicit.
15215         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15216
15217 2019-01-10  Tom Tromey  <tom@tromey.com>
15218
15219         * objfiles.h (objfile::reset_psymtabs): Update.
15220         * objfiles.c (objfile::objfile): Update.
15221         * psymtab.h (psymtab_storage::obstack): Update.
15222         (psymtab_storage::m_obstack): Use gdb::optional.
15223         (class psymtab_storage): Update comment.  Remove objfile
15224         parameter.
15225         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15226
15227 2019-01-10  Tom Tromey  <tom@tromey.com>
15228
15229         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15230         <free_psymtabs>: Now private.
15231         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15232         (allocate_psymtab): Use new method.
15233
15234 2019-01-10  Tom Tromey  <tom@tromey.com>
15235
15236         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15237         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15238         * mdebugread.c (parse_partial_symbols): Use
15239         allocate_dependencies.
15240         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15241         allocate_dependencies.
15242         (process_psymtab_comp_unit_reader)
15243         (build_type_psymtab_dependencies): Likewise.
15244         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15245
15246 2019-01-10  Tom Tromey  <tom@tromey.com>
15247
15248         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15249         PSYMBOL_SET_LANGUAGE.
15250         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15251
15252 2019-01-10  Tom Tromey  <tom@tromey.com>
15253
15254         * psymtab.h (psymtab_storage::obstack): New method.
15255         <m_obstack>: Rename from obstack; now private.
15256         * psymtab.c (psymtab_storage): Update.
15257         * dwarf2read.c (create_addrmap_from_index)
15258         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15259         Update.
15260
15261 2019-01-10  Tom Tromey  <tom@tromey.com>
15262
15263         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15264         * objfiles.h (objfile::reset_psymtabs): New method.
15265
15266 2019-01-10  Tom Tromey  <tom@tromey.com>
15267
15268         * symmisc.c (print_symbol_bcache_statistics): Update.
15269         (print_objfile_statistics): Update.
15270         * symfile.c (reread_symbols): Update.
15271         * psymtab.h (class psymtab_storage): New.
15272         * psymtab.c (psymtab_storage): New constructor.
15273         (~psymtab_storage): New destructor.
15274         (require_partial_symbols): Update.
15275         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15276         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15277         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15278         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15279         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15280         (start_psymtab_common, end_psymtab_common)
15281         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15282         (allocate_psymtab): Update.
15283         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15284         Update.
15285         (dump_psymtab_addrmap, maintenance_print_psymbols)
15286         (maintenance_check_psymtabs): Update.
15287         (class objfile_psymtabs): Move to objfiles.h.
15288         * psympriv.h (discard_psymtab): Now inline.
15289         (psymtab_discarder::psymtab_discarder): Update.
15290         (psymtab_discarder::~psymtab_discarder): Update.
15291         (ALL_OBJFILE_PSYMTABS): Rewrite.
15292         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15293         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15294         Remove fields.
15295         <partial_symtabs>: New field.
15296         (class objfile_psymtabs): Move from psymtab.h.  Update.
15297         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15298         psymbol_cache.
15299         (objfile::~objfile): Don't destroy psymbol_cache.
15300         * mdebugread.c (parse_partial_symbols): Update.
15301         * dwarf2read.c (create_addrmap_from_index)
15302         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15303         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15304         (add_partial_subprogram, dwarf2_ranges_read): Update.
15305         * dwarf-index-write.c (write_address_map)
15306         (write_one_signatured_type, recursively_write_psymbols)
15307         (class debug_names, class debug_names, write_psymtabs_to_index):
15308         Update.
15309
15310 2019-01-10  Tom Tromey  <tom@tromey.com>
15311
15312         * symtab.h (SYMBOL_SET_NAMES): Update.
15313         (symbol_set_names): Update.
15314         (MSYMBOL_SET_NAMES): Update.
15315         * symtab.c (symbol_set_names): Change argument to be an
15316         objfile_per_bfd_storage.
15317         * psymtab.c (add_psymbol_to_bcache): Update.
15318         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15319
15320 2019-01-10  Tom Tromey  <tom@tromey.com>
15321
15322         * symtab.c (create_demangled_names_hash): Change argument to be an
15323         objfile_per_bfd_storage.
15324         (symbol_set_names): Update.
15325
15326 2019-01-10  Tom Tromey  <tom@tromey.com>
15327
15328         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15329         init_psymbol_list.
15330         * psymtab.c (init_psymbol_list): Do nothing if already called.
15331         * psympriv.h (init_psymbol_list): Add comment.
15332         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15333         init_psymbol_list.
15334         * dbxread.c (dbx_symfile_read): Unconditionally call
15335         init_psymbol_list.
15336
15337 2019-01-10  Tom Tromey  <tom@tromey.com>
15338
15339         * xcoffread.c (scan_xcoff_symtab): Update.
15340         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15341         "where".
15342         * mdebugread.c (parse_partial_symbols)
15343         (handle_psymbol_enumerators): Update.
15344         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15345         * dbxread.c (read_dbx_symtab): Update.
15346         * psympriv.h (psymbol_placement): New enum.
15347         (add_psymbol_to_list): Update.
15348
15349 2019-01-10  Tom Tromey  <tom@tromey.com>
15350
15351         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15352         static_psymbols parameters.
15353         (scan_xcoff_symtab): Update.
15354         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15355         static_psymbols parameters.
15356         * psympriv.h (start_psymtab_common): Update.
15357         * mdebugread.c (parse_partial_symbols): Update.
15358         * dwarf2read.c (create_partial_symtab): Update.
15359         * dbxread.c (read_dbx_symtab): Update.
15360         (start_psymtab): Remove global_psymbols and static_psymbols
15361         parameters.
15362
15363 2019-01-10  Tom Tromey  <tom@tromey.com>
15364
15365         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15366         * psymtab.c (allocate_psymtab): Add comment.
15367         * psympriv.h (allocate_psymtab): Add comment.
15368         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15369         initializations.
15370         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15371
15372 2019-01-10  Tom Tromey  <tom@tromey.com>
15373
15374         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15375         Don't declare.
15376         * mipsread.c: Include mdebugread.h.
15377         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15378         Declare.
15379         * elfread.c: Include mdebugread.h.
15380
15381 2019-01-09  Tom Tromey  <tom@tromey.com>
15382
15383         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15384         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15385         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15386         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15387         (psym_lookup_symbol, psym_find_last_source_symtab)
15388         (psym_forget_cached_source_info, psym_print_stats)
15389         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15390         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15391         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15392         (psym_find_compunit_symtab_by_address)
15393         (maintenance_print_psymbols, maintenance_info_psymtabs)
15394         (maintenance_check_psymtabs): Use ranged for.
15395         * psymtab.h (class objfile_psymtabs): New.
15396         (require_partial_symbols): Return objfile_psymtabs.
15397         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15398
15399 2019-01-09  Tom Tromey  <tom@tromey.com>
15400
15401         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15402         (find_pc_mapped_section, list_overlays_command)
15403         (map_overlay_command, unmap_overlay_command)
15404         (simple_overlay_update): Use all_objfiles.
15405         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15406         * printcmd.c (info_symbol_command): Use all_objfiles.
15407         * objfiles.h (ALL_OBJSECTIONS): Remove.
15408         * maint.c (maintenance_translate_address): Use all_objfiles.
15409         * gcore.c (gcore_create_callback): Use all_objfiles.
15410         (objfile_find_memory_regions): Likewise.
15411
15412 2019-01-09  Tom Tromey  <tom@tromey.com>
15413
15414         * symtab.c (find_line_symtab, info_sources_command)
15415         (make_source_files_completion_list): Use objfile_compunits.
15416         * source.c (select_source_symtab): Use objfile_compunits.
15417         * objfiles.h (struct objfile): Update comment.
15418         (ALL_OBJFILES): Remove.
15419         (ALL_FILETABS): Remove.
15420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15421         objfile_compunits.
15422
15423 2019-01-09  Tom Tromey  <tom@tromey.com>
15424
15425         * symmisc.c (print_objfile_statistics, dump_objfile)
15426         (maintenance_print_symbols): Use compunit_filetabs.
15427         * source.c (forget_cached_source_info_for_objfile): Use
15428         compunit_filetabs.
15429         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15430         (ALL_FILETABS): Use compunit_filetabs.
15431         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15432         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15433
15434 2019-01-09  Tom Tromey  <tom@tromey.com>
15435
15436         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15437         (compunit_filetabs): New.
15438         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15439         compunit_filetabs.
15440         (info_sources_command, make_source_files_completion_list): Remove
15441         declaration.
15442         * symmisc.c (print_objfile_statistics, dump_objfile)
15443         (maintenance_print_symbols): Remove declaration.
15444         (maintenance_info_symtabs): Use compunit_filetabs.
15445         (maintenance_info_line_tables): Likewise.
15446         * source.c (select_source_symtab): Change local variable name.
15447         (forget_cached_source_info_for_objfile): Remove declaration.
15448         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15449         * objfiles.c (objfile_relocate1): Remove declaration.
15450         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15451         declaration.
15452         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15453         * coffread.c (coff_symtab_read): Remove declaration.
15454         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15455         compunit_filetabs.
15456
15457 2019-01-09  Tom Tromey  <tom@tromey.com>
15458
15459         * symtab.c (lookup_objfile_from_block)
15460         (find_pc_sect_compunit_symtab, search_symbols)
15461         (default_collect_symbol_completion_matches_break_on): Use
15462         objfile_compunits.
15463         * objfiles.h (ALL_COMPUNITS): Remove.
15464         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15465         * cp-support.c (add_symbol_overload_list_qualified): Use
15466         objfile_compunits.
15467         * ada-lang.c (ada_collect_symbol_completion_matches)
15468         (ada_add_global_exceptions): Use objfile_compunits.
15469
15470 2019-01-09  Tom Tromey  <tom@tromey.com>
15471
15472         * source.c (select_source_symtab)
15473         (forget_cached_source_info_for_objfile): Remove declaration.
15474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15475         declaration.
15476         * maint.c (count_symtabs_and_blocks): Remove declaration.
15477         * cp-support.c (add_symbol_overload_list_qualified): Remove
15478         declaration.
15479         * coffread.c (coff_symtab_read): Remove declaration.
15480         * symtab.c (lookup_symbol_in_objfile_symtabs)
15481         (basic_lookup_transparent_type_1): Use objfile_compunits.
15482         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15483         (info_sources_command, search_symbols)
15484         (default_collect_symbol_completion_matches_break_on)
15485         (make_source_files_completion_list): Remove declaration.
15486         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15487         (ada_collect_symbol_completion_matches)
15488         (ada_add_global_exceptions): Remove declaration.
15489         * linespec.c (iterate_over_all_matching_symtabs): Use
15490         objfile_compunits.
15491         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15492         (class objfile_compunits): New.
15493         (ALL_COMPUNITS): Use objfile_compunits.
15494         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15495         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15496         objfile_compunits.
15497         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15498
15499 2019-01-09  Tom Tromey  <tom@tromey.com>
15500
15501         * symtab.c (search_symbols)
15502         (default_collect_symbol_completion_matches_break_on): Use
15503         objfile_msymbols.
15504         * ada-lang.c (ada_lookup_simple_minsym)
15505         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15506         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15507         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15508         objfile_msymbols.
15509         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15510         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15511         * objc-lang.c (find_methods): Use objfile_msymbols.
15512         (info_selectors_command, info_classes_command): Likewise.
15513         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15514         * objfiles.h (class objfile_msymbols): New.
15515         (ALL_OBJFILE_MSYMBOLS): Remove.
15516         (ALL_MSYMBOLS): Remove.
15517
15518 2019-01-09  Tom Tromey  <tom@tromey.com>
15519
15520         * common/next-iterator.h (next_adapter): Add Iterator template
15521         parameter.
15522         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15523         (class all_objfiles_safe): New.
15524         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15525         * objfiles.c (put_objfile_before): Update comment.
15526         (add_separate_debug_objfile): Likewise.
15527         (free_all_objfiles): Use all_objfiles_safe.
15528         (objfile_purge_solibs): Likewise.
15529
15530 2019-01-09  Tom Tromey  <tom@tromey.com>
15531
15532         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15533         (expand_symtab_containing_pc, lookup_static_symbol)
15534         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15535         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15536         all_objfiles.
15537         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15538         * breakpoint.c (create_overlay_event_breakpoint)
15539         (create_longjmp_master_breakpoint)
15540         (create_std_terminate_master_breakpoint)
15541         (create_exception_master_breakpoint): Use all_objfiles.
15542         * linux-thread-db.c (try_thread_db_load_from_pdir)
15543         (has_libpthread): Use all_objfiles.
15544         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15545         * linespec.c (iterate_over_all_matching_symtabs)
15546         (search_minsyms_for_name): Use all_objfiles.
15547         * maint.c (maintenance_info_sections): Use all_objfiles.
15548         * main.c (captured_main_1): Use all_objfiles.
15549         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15550         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15551         * guile/scm-pretty-print.c
15552         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15553         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15554         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15555         (maintenance_print_msymbols): Use all_objfiles.
15556         * source.c (select_source_symtab): Use all_objfiles.
15557         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15558         * symfile.c (remove_symbol_file_command)
15559         (expand_symtabs_matching, map_symbol_filenames): Use
15560         all_objfiles.
15561         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15562         all_objfiles.
15563         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15564         * objc-lang.c (find_methods): Use all_objfiles.
15565         * objfiles.c (have_partial_symbols, have_full_symbols)
15566         (have_minimal_symbols, qsort_cmp)
15567         (default_iterate_over_objfiles_in_search_order): Use
15568         all_objfiles.
15569         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15570         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15571         (maintenance_check_psymtabs): Use all_objfiles.
15572         (ALL_PSYMTABS): Remove.
15573         * compile/compile-object-run.c (do_module_cleanup): Use
15574         all_objfiles.
15575         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15576         * cp-support.c (add_symbol_overload_list_qualified): Use
15577         all_objfiles.
15578         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15579         Use all_objfiles.
15580         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15581         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15582         all_objfiles.
15583         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15584         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15585         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15586         Uses all_objfiles.
15587         * solib.c (solib_read_symbols): Use all_objfiles
15588
15589 2019-01-09  Tom Tromey  <tom@tromey.com>
15590
15591         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15592         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15593         all_objfiles.
15594         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15595         * symmisc.c (print_symbol_bcache_statistics)
15596         (print_objfile_statistics, maintenance_print_objfiles)
15597         (maintenance_info_symtabs, maintenance_check_symtabs)
15598         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15599         all_objfiles.
15600         * source.c (forget_cached_source_info): Use all_objfiles.
15601         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15602         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15603         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15604         * objfiles.c (update_section_map): Use all_objfiles.
15605         (shared_objfile_contains_address_p): Likewise.
15606         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15607         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15608
15609 2019-01-09  Tom Tromey  <tom@tromey.com>
15610
15611         * common/next-iterator.h: New file.
15612         * objfiles.h (class all_objfiles): New.
15613         (struct objfile_iterator): New.
15614
15615 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15616
15617         * NEWS: Move the description of the changed "frame", "select-frame",
15618          and "info frame" commands to the Changed commands section.
15619
15620 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15621
15622         * gdbtypes.c (check_stub_method_group): Remove handling of old
15623         mangling schemes.
15624         * linespec.c (find_methods): Likewise.
15625         * stabsread.c (read_member_functions): Likewise.
15626         * valops.c (search_struct_method): Likewise.
15627         (value_struct_elt_for_reference): Likewise.
15628         * NEWS: Mention this change.
15629
15630 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15631
15632         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15633         print_source_lines.
15634         * source.c (print_source_lines_base): Update line number check.
15635         (print_source_lines): New function.
15636         (source_lines_range::source_lines_range): New function.
15637         * source.h (class source_lines_range): New class.
15638         (print_source_lines): New declaration.
15639
15640 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15641
15642         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15643
15644 2019-01-08  Tom Tromey  <tom@tromey.com>
15645             Simon Marchi  <simon.marchi@ericsson.com>
15646
15647         PR gdb/24060
15648         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15649         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15650         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15651         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15652         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15653         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15654
15655 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15656
15657         * source.c (select_source_symtab): Move header comment to
15658         declaration in source.h.
15659         (forget_cached_source_info_for_objfile): Likewise.
15660         (forget_cached_source_info): Likewise.
15661         (identify_source_line): Likewise.
15662         * source.h (identify_source_line): Move declaration from symtab.h
15663         and add comment from source.c
15664         (print_source_lines): Likewise.
15665         (forget_cached_source_info_for_objfile): Likewise.
15666         (forget_cached_source_info): Likewise.
15667         (select_source_symtab): Likewise.
15668         (enum print_source_lines_flag): Move definition from symtab.h.
15669         * symtab.h (identify_source_line): Move declaration to source.h.
15670         (print_source_lines): Likewise.
15671         (forget_cached_source_info_for_objfile): Likewise.
15672         (forget_cached_source_info): Likewise.
15673         (select_source_symtab): Likewise.
15674         (enum print_source_lines_flag): Move definition to source.h.
15675         * tui/tui-hooks.c: Add 'source.h' include.
15676
15677 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15678
15679         * source.c (print_source_lines_base): Handle requests to print
15680         reverse line number sequences, and guard against empty lines
15681         string.
15682
15683 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15684
15685         * source.c (print_source_lines_base): Fix skip of '\r' if next
15686         character is '\n'.
15687
15688 2019-01-06  Tom Tromey  <tom@tromey.com>
15689
15690         * c-exp.y (struct c_parse_state) <macro_original_text,
15691         expansion_obstack>: New member.
15692         (macro_original_text, expansion_obstack): Remove globals.
15693         (scan_macro_expansion, scanning_macro_expansion)
15694         (finished_macro_expansion): Update.
15695         (scan_macro_cleanup): Remove.
15696         (yylex, c_parse): Update.
15697
15698 2019-01-06  Tom Tromey  <tom@tromey.com>
15699
15700         * c-exp.y (struct c_parse_state) <strings>: New member.
15701         (operator_stoken): Update.
15702
15703 2019-01-06  Tom Tromey  <tom@tromey.com>
15704
15705         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15706         (union type_stack_elt) <typelist_val>: Now a pointer to
15707         std::vector.
15708         (type_stack_cleanup): Don't declare.
15709         (push_typelist): Update.
15710         * parse.c (pop_typelist): Return a std::vector.
15711         (push_typelist): Take a std::vector.
15712         (follow_types): Update.  Do not free args.
15713         (type_stack_cleanup): Remove.
15714         * c-exp.y (struct c_parse_state): New.
15715         (cpstate): New global.
15716         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15717         (nonempty_typelist): Update.
15718         (func_mod): Create a new vector.
15719         (c_parse): Create a c_parse_state.
15720         (check_parameter_typelist): Do not delete params.
15721         (function_method): Update.  Do not delete type_list.
15722
15723 2019-01-06  Tom Tromey  <tom@tromey.com>
15724
15725         PR gdb/28155:
15726         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15727         check_typedef.
15728         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15729         (print_return_value): Likewise.
15730
15731 2019-01-05  Tom Tromey  <tom@tromey.com>
15732
15733         * contrib/cleanup_check.py: Remove.
15734         * contrib/gcc-with-excheck: Remove.
15735         * contrib/exsummary.py: Remove.
15736         * contrib/excheck.py: Remove.
15737
15738 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15739
15740         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15741         NULL. Initialize tpprev to NULL instead of assigning it
15742         to NULL on the next statement.
15743         * windows-nat.c (windows_delete_thread): Remove check for
15744         main_thread_id before printing thread exit notifications.
15745         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15746         Remove thread ID check against main_thread_id.
15747         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15748         windows_delete_thread.
15749         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15750
15751 2019-01-04  Tom Tromey  <tom@tromey.com>
15752
15753         * compile/compile.c (_initialize_compile): Use upper case for
15754         metasyntactic variables.
15755         * symmisc.c (_initialize_symmisc): Use upper case for
15756         metasyntactic variables.
15757         * psymtab.c (_initialize_psymtab): Use upper case for
15758         metasyntactic variables.
15759         * demangle.c (demangle_command): Use upper case for metasyntactic
15760         variables.
15761         (_initialize_demangler): Likewise.
15762         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15763         variables.
15764
15765 2019-01-03  Tom Tromey  <tom@tromey.com>
15766
15767         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15768
15769 2019-01-03  Tom Tromey  <tom@tromey.com>
15770
15771         * python/py-symtab.c (salpy_str): Update.
15772         (struct salpy_sal_object) <symtab>: Now a PyObject.
15773         (salpy_dealloc): Update.
15774         (del_objfile_sal): Use gdbpy_ref.
15775
15776 2019-01-03  Tom Tromey  <tom@tromey.com>
15777
15778         * python/py-type.c (convert_field): Use new_reference.  Return
15779         gdbpy_ref.
15780         (make_fielditem): Return gdbpy_ref.
15781         (typy_fields): Update.
15782         (typy_getitem): Update.
15783         (field_name): Return gdbpy_ref.  Use new_reference.
15784         (typy_iterator_iternext): Update.
15785
15786 2019-01-03  Tom Tromey  <tom@tromey.com>
15787
15788         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15789
15790 2019-01-03  Tom Tromey  <tom@tromey.com>
15791
15792         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15793         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15794         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15795         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15796         (pspy_set_type_printers): Likewise.
15797         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15798         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15799         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15800         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15801         (objfpy_set_type_printers): Likewise.
15802
15803 2019-01-03  Tom Tromey  <tom@tromey.com>
15804
15805         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15806         (gdbpy_print_stack): Use gdbpy_err_fetch.
15807         * python/python-internal.h (class gdbpy_err_fetch): New class.
15808         (class gdbpy_enter) <m_error_type, m_error_value,
15809         m_error_traceback>: Remove.
15810         <m_error>: New member.
15811         (gdbpy_exception_to_string): Don't declare.
15812         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15813         * python/py-value.c (convert_value_from_python): Use
15814         gdbpy_err_fetch.
15815         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15816         gdbpy_exception_to_string.
15817         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15818         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15819         gdbpy_err_fetch.
15820
15821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15822
15823         * linux-nat.c (delete_lwp_cleanup): Delete.
15824         (struct lwp_deleter): New struct.
15825         (lwp_info_up): New typedef.
15826         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15827         lwp_info_up.
15828
15829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15830
15831         * linux-fork.c (class scoped_switch_fork_info): New class.
15832         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15833
15834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15835
15836         * valops.c (find_overload_match): Remove use of null_cleanup, and
15837         calls to do_cleanups.
15838
15839 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15840
15841         * compile/compile-cplus-types.c
15842         (compile_cplus_instance::decl_name): Handle changes to
15843         cp_func_name.
15844         * cp-support.c (cp_func_name): Update header comment, update
15845         return type.
15846         * cp-support.h (cp_func_name): Update return type in declaration.
15847         * valops.c (find_overload_match): Move temp_func local to top
15848         level of function and change its type.  Use temp_func to hold and
15849         delete temporary string obtained from cp_func_name.
15850
15851 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15852
15853         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15854         gdb::char_vector, remove cleanup, and update uses of `msg`.
15855
15856 2019-01-03  Jim Wilson  <jimw@sifive.com>
15857
15858         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15859
15860 2019-01-02  Tom Tromey  <tom@tromey.com>
15861
15862         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15863         (tdesc_parse_xml): Remove cleanups.
15864         * target-descriptions.h (make_cleanup_free_target_description):
15865         Don't declare.
15866         (target_desc_deleter): New struct.
15867         (target_desc_up): New typedef.
15868         * target-descriptions.c (target_desc_deleter::operator()): Rename
15869         from free_target_description.
15870         (make_cleanup_free_target_description): Remove.
15871
15872 2019-01-02  Tom Tromey  <tom@tromey.com>
15873
15874         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15875         constructor, destructor.
15876         (linespec_parser): Remove typedef.
15877         (~linespec_parser): Rename from linespec_parser_delete.
15878         (linespec_lex_to_end, linespec_complete_label)
15879         (linespec_complete): Update.
15880         (decode_line_full): Remove cleanups.
15881         (decode_line_1): Update.
15882
15883 2019-01-02  Tom Tromey  <tom@tromey.com>
15884
15885         * python/python-internal.h (inferior_to_inferior_object): Change
15886         return type.
15887         * python/py-exitedevent.c (create_exited_event_object): Update.
15888         * python/py-inferior.c (inferior_to_inferior_object): Return
15889         gdbpy_ref.
15890         (python_new_inferior, python_inferior_deleted)
15891         (thread_to_thread_object, delete_thread_object)
15892         (build_inferior_list, gdbpy_selected_inferior): Update.
15893         * python/py-infthread.c (create_thread_object): Update.  Also fail
15894         if inferior_to_inferior_object fails.
15895
15896 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15897
15898         * inferior.h (class inferior) <displaced_step_state>: New field.
15899         * infrun.h (struct displaced_step_state): Move here from
15900         infrun.c.  Initialize fields, add constructor.
15901         <inf>: Remove field.
15902         <reset>: New method.
15903         * infrun.c (struct displaced_step_inferior_state): Move to
15904         infrun.h.
15905         (displaced_step_inferior_states): Remove.
15906         (get_displaced_stepping_state): Adust.
15907         (displaced_step_in_progress_any_inferior): Adjust.
15908         (displaced_step_in_progress_thread): Adjust.
15909         (displaced_step_in_progress): Adjust.
15910         (add_displaced_stepping_state): Remove.
15911         (get_displaced_step_closure_by_addr): Adjust.
15912         (remove_displaced_stepping_state): Remove.
15913         (infrun_inferior_exit): Call displaced_step_state.reset.
15914         (use_displaced_stepping): Don't check for NULL.
15915         (displaced_step_prepare_throw): Call
15916         get_displaced_stepping_state.
15917         (displaced_step_fixup): Don't check for NULL.
15918         (prepare_for_detach): Don't check for NULL.
15919
15920 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15921
15922         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15923          in case of call that did not complete.
15924
15925 2019-01-02  Andrey Utkin  <autkin@undo.io>
15926
15927         * symfile.c (find_separate_debug_file): Fix search of debug files for
15928         remote debuggee.
15929
15930 2019-01-02  Tom Tromey  <tom@tromey.com>
15931
15932         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15933         indentation.
15934         * python/py-frame.c (frapy_older): Remove cast.
15935         (frapy_newer): Likewise.
15936         * python/py-breakpoint.c (local_setattro): Remove cast.
15937         * python/py-arch.c (archpy_name): Remove local variable.
15938         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15939
15940 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15941
15942         * unittests/basic_string_view/element_access/char/empty.cc:
15943         Fix year range in copyright header.
15944
15945 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15946
15947         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15948         Delete.
15949         <operator==>: Update with for removed field.
15950         <hash>: Likewise.
15951         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15952         <isa_features>: ...this.
15953         <abi_features>: New field.
15954         (riscv_isa_flen): Update comment.
15955         (riscv_abi_xlen): New declaration.
15956         (riscv_abi_flen): New declaration.
15957         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15958         isa_features.
15959         (riscv_abi_xlen): New function.
15960         (riscv_isa_flen): Update to get answer from isa_features.
15961         (riscv_abi_flen): New function.
15962         (riscv_has_fp_abi): Update to get answer from abi_features.
15963         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15964         xlen and flen.
15965         (riscv_call_info) <xlen, flen>: Update comment.
15966         (riscv_call_arg_struct): Remove invalid assertions
15967         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15968         is removed.
15969         (riscv_gdbarch_init): Gather isa features and abi features
15970         separately, ensure both match on the gdbarch when reusing an old
15971         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15972         a target with 64-bit float hardware.
15973
15974 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15975
15976         * source.c (search_command_helper): Stop reverse search
15977         when line 1 has been searched.
15978
15979 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15980
15981         * record-full.c (record_full_base_target::close): Rewrite
15982         record_full_core_buf_list free logic.
15983
15984 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15985
15986         * break-catch-syscall.c (print_one_catch_syscall): xfree
15987         the last text.
15988
15989 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15990
15991         * top.c (print_gdb_version): Update Copyright year in version
15992         message.
15993
15994 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15995
15996         Update copyright year range in all GDB files.
15997
15998 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15999
16000         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16001
16002 For older changes see ChangeLog-2018.
16003 \f
16004 Local Variables:
16005 mode: change-log
16006 left-margin: 8
16007 fill-column: 74
16008 version-control: never
16009 coding: utf-8
16010 End:
16011