gdb/ChangeLog

   1 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2         * NEWS:  Mention define-prefix.  Tell that command names can now
   3         contain a . character.
   4
   5 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6
   7         * command.h (valid_cmd_char_p): Declare.
   8         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
   9         the check of valid command char.
  10         (find_command_name_length, valid_user_defined_cmd_name_p): Use
  11         valid_cmd_char_p.
  12         * cli/cli-script.c (validate_comname): Likewise.
  13         * completer.c (gdb_completer_command_word_break_characters):
  14         Do not remove . from the word break char, update comments.
  15         (complete_line_internal_1): Use valid_cmd_char_p.
  16         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  17         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  18
  19 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  20
  21         * cli/cli-script.c (do_define_command): Ensure a redefined
  22         prefix command is kept as a prefix command.
  23         (define_prefix_command): New function.
  24         (show_user_1): Report user defined prefixes.
  25         (_initialize_cli_script):  Create the new 'define-prefix' command.
  26         Add completers for 'define' and 'document'.
  27         * top.c (execute_command):  If command is a user-defined prefix only
  28         command, report the list of commands for this prefix command.
  29
  30 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  31
  32         * valops.c (find_oload_champ): Improve debug output.
  33
  34 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  35
  36         * valops.c (find_oload_champ): Print part of debug messages
  37         before the badness vector is std::move'd.
  38
  39 2019-11-28  Tom Tromey  <tom@tromey.com>
  40
  41         * value.c (creal_internal_fn): Fix comment.
  42
  43 2019-11-28  Tom Tromey  <tom@tromey.com>
  44
  45         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
  46         flag_bound_evaluated>: Now unsigned.
  47
  48 2019-11-28  Tom Tromey  <tom@tromey.com>
  49
  50         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
  51         declare.
  52
  53 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
  54
  55         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
  56         debug output.
  57         * jit.c (jit_unregister_code): Add debug print to match
  58         `jit_register_code`.
  59
  60 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  61
  62         * NEWS: Mention the new multithreaded symbol loading.
  63
  64 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  65
  66         * maint.c (n_worker_threads): Default to 0.
  67         (worker_threads_disabled): New function.
  68         * maint.h (worker_threads_disabled): New function.
  69         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
  70         here if worker_threads_disabled () is true.
  71         (minimal_symbol_reader::install): Skip all threading if
  72         worker_threads_disabled () is true.
  73
  74 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
  77         hash code if possible.
  78         (add_minsym_to_demangled_hash_table): Likewise.
  79         (minimal_symbol_reader::install): Compute the hash codes for msymbol
  80         on the background thread.
  81         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
  82         Add these fields.
  83
  84 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  85
  86         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
  87         of the mangled name on the background thread.
  88         * symtab.c (symbol_set_names): Allow passing in the hash of the
  89         linkage_name.
  90         * symtab.h (symbol_set_names): Likewise.
  91
  92 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
  93
  94         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
  95         physnames are computed for inherited DIEs.
  96
  97 2019-11-27  Tom Tromey  <tromey@adacore.com>
  98
  99         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 100         backslashes.
 101         * cp-support.c: Remove unnecessary backslashes.
 102
 103 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 106         with sym->set_linkage_name.
 107         * coffread.c (coff_read_enum_type): Likewise.
 108         * mdebugread.c (parse_symbol): Likewise.
 109         * stabsread.c (patch_block_stabs): Likewise.
 110         (define_symbol): Likewise.
 111         (read_enum_type): Likewise.
 112         (common_block_end): Likewise.
 113         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 114         function.
 115         (SYMBOL_SET_LINKAGE_NAME): Remove.
 116         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 117         with sym->set_linkage_name.
 118
 119 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 122         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 123         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 124         * NEWS: Mention new MI command.
 125
 126 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 127
 128         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 129         '-symbol-info-types', and '-symbol-info-variables'.
 130         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 131         (mi_cmd_symbol_info_types): Declare.
 132         (mi_cmd_symbol_info_variables): Declare.
 133         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 134         (output_debug_symbol): New function.
 135         (output_nondebug_symbol): New function.
 136         (mi_symbol_info): New function.
 137         (mi_info_functions_or_variables): New function.
 138         (mi_cmd_symbol_info_functions): New function.
 139         (mi_cmd_symbol_info_types): New function.
 140         (mi_cmd_symbol_info_variables): New function.
 141         * NEWS: Mention new commands.
 142
 143 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 144
 145         * symtab.c (symbol_to_info_string): New function, most content
 146         moved from print_symbol_info, but updated to return a std::string.
 147         (print_symbol_info): Update to use symbol_to_info_string and print
 148         returned string.
 149         * symtab.h (symbol_to_info_string): Declare new function.
 150
 151 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 152
 153         * python/python.c (gdbpy_rbreak): Convert to using
 154         global_symbol_searcher.
 155         * symtab.c (file_matches): Convert return type to bool, change
 156         file list to std::vector, update header comment.
 157         (search_symbols): Rename to...
 158         (global_symbol_searcher::search): ...this and update now its
 159         a member function of global_symbol_searcher.  Take account of the
 160         changes to file_matches.
 161         (symtab_symbol_info): Convert to using global_symbol_searcher.
 162         (rbreak_command): Likewise.
 163         (search_module_symbols): Likewise.
 164         * symtab.h (enum symbol_search): Update comment.
 165         (search_symbols): Remove declaration.
 166         (class global_symbol_searcher): New class.
 167
 168 2019-11-26  Tom Tromey  <tromey@adacore.com>
 169
 170         * cp-support.c (_initialize_cp_support): Conditionally initialize
 171         gdb_demangle_attempt_core_dump.
 172
 173 2019-11-26  Tom Tromey  <tom@tromey.com>
 174
 175         * python/py-function.c (fnpy_init): Update.
 176         * value.h (add_internal_function): Adjust declaration.
 177         * value.c (function_destroyer): Remove.
 178         (do_add_internal_function): Don't set destroyer or copy name.
 179         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 180         Set name_allocated.
 181         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 182         (cmdpy_init): Set name_allocated.
 183         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 184         member.
 185         (~cmd_list_element): Free "name" if needed.
 186
 187 2019-11-26  Tom Tromey  <tom@tromey.com>
 188
 189         * value.h (add_internal_function): Add new overload.  Move
 190         documentation from value.h.
 191         * value.c (do_add_internal_function): New function.
 192         (add_internal_function): Use it.  Add new overload.
 193         (function_destroyer): Don't free doc.
 194         * python/py-function.c (fnpy_init): Update.
 195
 196 2019-11-26  Tom Tromey  <tom@tromey.com>
 197
 198         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 199         (cmdpy_init): Set "doc_allocated".
 200
 201 2019-11-26  Tom Tromey  <tom@tromey.com>
 202
 203         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 204         name of worker thread.
 205         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 206         pthread_setname_np.
 207         * configure, config.in: Rebuild.
 208
 209 2019-11-26  Tom Tromey  <tom@tromey.com>
 210
 211         * python/python.c (class gdbpy_gil): New.
 212         (struct gdbpy_event): Add constructor, destructor, operator().
 213         (gdbpy_post_event): Use run_on_main_thread.
 214         (gdbpy_initialize_events): Remove.
 215         (do_start_initialization): Update.
 216
 217 2019-11-26  Tom Tromey  <tom@tromey.com>
 218
 219         * NEWS: Add entry.
 220         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 221         commands.  Call update_thread_pool_size.
 222         (update_thread_pool_size, maintenance_set_worker_threads): New
 223         functions.
 224         (n_worker_threads): New global.
 225
 226 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 227             Tom Tromey  <tom@tromey.com>
 228
 229         * minsyms.c (minimal_symbol_reader::install): Use
 230         parallel_for_each.
 231         * gdbsupport/parallel-for.h: New file.
 232         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 233
 234 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 235             Tom Tromey  <tom@tromey.com>
 236
 237         * gdbsupport/thread-pool.h: New file.
 238         * gdbsupport/thread-pool.c: New file.
 239         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 240         (HFILES_NO_SRCDIR): Add thread-pool.h.
 241
 242 2019-11-26  Tom Tromey  <tom@tromey.com>
 243
 244         * event-top.h (thread_local_segv_handler): Declare.
 245         * event-top.c (thread_local_segv_handler): New global.
 246         (install_handle_sigsegv, handle_sigsegv): New functions.
 247         (async_init_signals): Install SIGSEGV handler.
 248         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 249         thread-local.
 250         (report_failed_demangle): New function.
 251         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 252         handler-setting code, instead use segv_handler.  Run warning code
 253         on main thread.
 254
 255 2019-11-26  Tom Tromey  <tom@tromey.com>
 256
 257         * run-on-main-thread.c: New file.
 258         * run-on-main-thread.h: New file.
 259         * unittests/main-thread-selftests.c: New file.
 260         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 261         main-thread-selftests.c.
 262         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 263         (COMMON_SFILES): Add run-on-main-thread.c.
 264
 265 2019-11-26  Tom Tromey  <tom@tromey.com>
 266
 267         * main.c (setup_alternate_signal_stack): Remove.
 268         (captured_main_1): Use gdb::alternate_signal_stack.
 269         * gdbsupport/alt-stack.h: New file.
 270
 271 2019-11-26  Tom Tromey  <tom@tromey.com>
 272
 273         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 274         Remove comment.
 275         (save_original_signals_state, restore_original_signals_state): Use
 276         gdb_sigmask.
 277         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 278         (_initialize_linux_nat): Use gdb_sigmask.
 279         * guile/guile.c (_initialize_guile): Use block_signals.
 280         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 281         * gdbsupport/gdb-sigmask.h: New file.
 282         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 283         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 284         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 285         pthread_sigmask.
 286         * configure, config.in: Rebuild.
 287         * gdbsupport/block-signals.h: New file.
 288
 289 2019-11-26  Tom Tromey  <tom@tromey.com>
 290
 291         * acinclude.m4: Include ax_pthread.m4.
 292         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 293         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 294         (CLIBS): Use PTHREAD_LIBS.
 295         (aclocal_m4_deps): Add ax_pthread.m4.
 296         * config.in, configure: Rebuild.
 297         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 298
 299 2019-11-26  Tom Tromey  <tom@tromey.com>
 300
 301         * symtab.h (struct minimal_symbol) <name_set>: New member.
 302         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 303         Don't call symbol_set_names.
 304         (minimal_symbol_reader::install): Call symbol_set_names.
 305
 306 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 307
 308         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 309         restore_active_ext_lang, as GIL is needed for (indirectly)
 310         called PyOS_InterruptOccurred.
 311
 312 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 313
 314         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 315         definition.
 316
 317 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 318
 319         * remote-sim.c (simulator_command): Make static, remove
 320         declaration.
 321
 322 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 323
 324         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 325         static.
 326         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 327         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 328         (main): Likewise.
 329         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 330         (main): Likewise.
 331         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 332         (main): Likewise.
 333         * unittests/basic_string_view/element_access/char/1.cc (test01):
 334         Likewise.
 335         (main): Likewise.
 336         * unittests/basic_string_view/element_access/char/empty.cc (main):
 337         Likewise.
 338         * unittests/basic_string_view/element_access/char/front_back.cc
 339         (test01): Likewise.
 340         (main): Likewise.
 341         * unittests/basic_string_view/inserters/char/2.cc (test05):
 342         Likewise.
 343         (main): Likewise.
 344         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 345         (test01): Likewise.
 346         (main): Likewise.
 347         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 348         (test01): Likewise.
 349         (main): Likewise.
 350         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 351         Likewise.
 352         * unittests/basic_string_view/operations/compare/char/1.cc
 353         (test01): Likewise.
 354         (main): Likewise.
 355         * unittests/basic_string_view/operations/compare/char/13650.cc
 356         (test01): Likewise.
 357         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 358         Likewise.
 359         (main): Likewise.
 360         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 361         Likewise.
 362         (main): Likewise.
 363         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 364         Likewise.
 365         (main): Likewise.
 366         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 367         Likewise.
 368         (main): Likewise.
 369         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 370         Likewise.
 371         (main): Likewise.
 372         * unittests/basic_string_view/operations/find/char/4.cc (main):
 373         Likewise.
 374         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 375         Likewise.
 376         (main): Likewise.
 377         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 378         Likewise.
 379         (main): Likewise.
 380         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 381         Likewise.
 382         (main): Likewise.
 383         * unittests/basic_string_view/operations/substr/char/1.cc
 384         (test01): Likewise.
 385         (main): Likewise.
 386         * unittests/basic_string_view/operators/char/2.cc (main):
 387         Likewise.
 388         * unittests/optional/assignment/1.cc (test): Likewise.
 389         * unittests/optional/assignment/2.cc (test): Likewise.
 390         * unittests/optional/assignment/3.cc (test): Likewise.
 391         * unittests/optional/assignment/4.cc (test): Likewise.
 392         * unittests/optional/assignment/5.cc (test): Likewise.
 393         * unittests/optional/assignment/6.cc (test): Likewise.
 394         * unittests/optional/assignment/7.cc (test): Likewise.
 395         * unittests/optional/cons/copy.cc (test): Likewise.
 396         * unittests/optional/cons/default.cc (test): Likewise.
 397         * unittests/optional/cons/move.cc (test): Likewise.
 398         * unittests/optional/cons/value.cc (test): Likewise.
 399         * unittests/optional/in_place.cc (test): Likewise.
 400         * unittests/optional/observers/1.cc (test): Likewise.
 401         * unittests/optional/observers/2.cc (test): Likewise.
 402
 403 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 404
 405         * tui-win.h (tui_set_var_cmd): Remove.
 406         * tui-win.c (tui_set_var_cmd): Make static.
 407
 408 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 409
 410         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 411         rbreak_command_wrapper): Remove.
 412         * symtab.c (rbreak_command_wrapper): Remove.
 413
 414 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 415
 416         * inferior.h (info_terminal_command): Remove declaration.
 417         * inflow.c (info_terminal_command): Make static.
 418
 419 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * inferior.c (exit_inferior_silent): Remove.
 422
 423 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 424
 425         * dictionary.c (dict_empty, mdict_empty): Remove.
 426         * dictionary.c (mdict_empty): Remove.
 427
 428 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 429
 430          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 431          (arc_insn_get_memory_offset): Likewise.
 432          (arc_insn_dump): Likewise.
 433          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 434          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 435          * dictionary.c (dict_iterator_next): Likewise.
 436          (dict_iter_match_first): Likewise.
 437          (dict_iter_match_next): Likewise.
 438          * f-lang.c (evaluate_subexp_f): Likewise.
 439          * hppa-tdep.c (hppa_read_pc): Likewise.
 440          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 441          * parse.c (write_exp_elt_msym): Likewise.
 442          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 443          * remote.c (remote_packet_size): Likewise.
 444          (remote_notif_stop_parse): Likewise.
 445          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 446          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 447          * source.c (prepare_path_for_appending): Likewise.
 448          * sparc64-linux-tdep.c
 449          (sparc64_linux_handle_segmentation_fault); Likewise.
 450          * stack.c (frame_selection_by_function_completer): Likewise.
 451
 452 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 453
 454         * completer.c (set_gdb_completion_word_break_characters):
 455         Remove.
 456
 457 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 458
 459         * dwarf-index-write.c: Include dwarf-index-write.h.
 460         * mi/mi-interp.c: Include mi/mi-interp.h.
 461
 462 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 463
 464         * aarch32-tdep.c: Include aarch32-tdep.h.
 465         * aarch32-tdep.h: Forward-declare struct target_desc.
 466
 467 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 468
 469         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 470         strerror.
 471         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 472         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 473
 474 2019-11-25  Tom de Vries  <tdevries@suse.de>
 475
 476         * contrib/words.sh: Add -c option.
 477
 478 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 479
 480         * solib.c (solib_find_1): Change int to bool.
 481         (exec_file_find): Change int to bool.
 482         (solib_find): Change int to bool.
 483         (solib_read_symbols): Change int to bool.
 484         (solib_used): Change int to bool.
 485         (solib_add): Change int to bool.
 486         (info_sharedlibrary_command): Change int to bool.
 487         (solib_contains_address_p): Change int to bool.
 488         (solib_keep_data_in_core): Change int to bool.
 489         (in_solib_dynsym_resolve_code): Change int to bool.
 490         (reload_shared_libraries_1): Change int to bool.
 491         (gdb_sysroot_changed): Change int to bool.
 492         * solib.h (solib_read_symbols): Change int to bool.
 493         (solib_contains_address_p): Change int to bool.
 494         (solib_keep_data_in_core): Change int to bool.
 495         (in_solib_dynsym_resolve_code): Change int to bool.
 496         (libpthread_name_p): Change int to bool.
 497
 498 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 499
 500         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 501         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 502         (remote_packet_max_chars): New static global.
 503         (show_remote_packet_max_chars): New function.
 504         (remote_target::putpkt_binary): Adjust to use new
 505         remote_packet_max_chars option.
 506         (remote_target::getpkt_or_notif_sane_1): Likewise.
 507         (_initialize_remote): Register new remote-packet-max-chars option.
 508
 509 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 510
 511         * m68k-linux-nat.c: Include gdbarch.h.
 512
 513 2019-11-24  Tom Tromey  <tom@tromey.com>
 514
 515         * symfile.c (read_symbols): Update.
 516         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 517         bool.
 518         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 519         (psym_lookup_symbol, psym_find_last_source_symtab)
 520         (psym_forget_cached_source_info, psym_print_stats)
 521         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 522         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 523         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 524         (psym_find_compunit_symtab_by_address)
 525         (maintenance_print_psymbols, maintenance_info_psymtabs)
 526         (maintenance_check_psymtabs): Update.
 527         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 528         bool.
 529
 530 2019-11-22  Tom Tromey  <tom@tromey.com>
 531
 532         * observable.h: Update comments.
 533
 534 2019-11-22  Tom Tromey  <tromey@adacore.com>
 535
 536         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 537         (print_ada_task_info): Don't try to fetch thread id if task is not
 538         alive.
 539
 540 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * ada-exp.y: Update.
 543         * ada-lang.c (sort_choices): Update.
 544         (ada_print_symbol_signature): Update.
 545         (resolve_subexp): Update.
 546         (ada_parse_renaming): Update.
 547         (ada_read_renaming_var_value): Update.
 548         (lesseq_defined_than): Update.
 549         (remove_extra_symbols): Update.
 550         (remove_irrelevant_renamings): Update.
 551         (ada_add_block_symbols): Update.
 552         (ada_collect_symbol_completion_matches): Update.
 553         (ada_is_renaming_symbol): Update.
 554         (aggregate_assign_from_choices): Update.
 555         (ada_evaluate_subexp): Update.
 556         (ada_has_this_exception_support): Update.
 557         (ada_is_non_standard_exception_sym): Update.
 558         (ada_add_exceptions_from_frame): Update.
 559         (ada_add_global_exceptions): Update.
 560         (ada_print_subexp): Update.
 561         * ax-gdb.c (gen_var_ref): Update.
 562         (gen_maybe_namespace_elt): Update.
 563         (gen_expr_for_cast): Update.
 564         (gen_expr): Update.
 565         * block.h: Update.
 566         * blockframe.c (find_pc_partial_function): Update.
 567         * breakpoint.c (print_breakpoint_location): Update.
 568         (update_static_tracepoint): Update.
 569         * btrace.c (ftrace_print_function_name): Update.
 570         (ftrace_function_switched): Update.
 571         * buildsym.c (find_symbol_in_list): Update.
 572         * c-exp.y: Update.
 573         * c-typeprint.c (c_print_typedef): Update.
 574         (c_type_print_template_args): Update.
 575         * cli/cli-cmds.c (edit_command): Update.
 576         (list_command): Update.
 577         (print_sal_location): Update.
 578         * coffread.c (patch_opaque_types): Update.
 579         (process_coff_symbol): Update.
 580         (coff_read_enum_type): Update.
 581         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 582         (convert_one_symbol): Update.
 583         (hash_symname): Update.
 584         (eq_symname): Update.
 585         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 586         * compile/compile-cplus-types.c (debug_print_scope): Update.
 587         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 588         * compile/compile-object-load.c (get_out_value_type): Update.
 589         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 590         (search_symbol_list): Update.
 591         (cp_lookup_symbol_imports_or_template): Update.
 592         * cp-support.c (overload_list_add_symbol): Update.
 593         * ctfread.c (psymtab_to_symtab): Update.
 594         * dbxread.c (cp_set_block_scope): Update.
 595         * dictionary.c (iter_match_first_hashed): Update.
 596         (iter_match_next_hashed): Update.
 597         (insert_symbol_hashed): Update.
 598         (iter_match_next_linear): Update.
 599         * dictionary.h: Update.
 600         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 601         (locexpr_describe_location_piece): Update.
 602         (locexpr_describe_location_1): Update.
 603         (locexpr_generate_c_location): Update.
 604         (loclist_describe_location): Update.
 605         (loclist_generate_c_location): Update.
 606         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 607         (read_func_scope): Update.
 608         (process_enumeration_scope): Update.
 609         (new_symbol): Update.
 610         (dwarf2_const_value): Update.
 611         (dwarf2_symbol_mark_computed): Update.
 612         * eval.c (evaluate_funcall): Update.
 613         (evaluate_subexp_standard): Update.
 614         * expprint.c (print_subexp_standard): Update.
 615         (dump_subexp_body_standard): Update.
 616         * f-valprint.c (info_common_command_for_block): Update.
 617         * findvar.c (get_hosting_frame): Update.
 618         (default_read_var_value): Update.
 619         * go-lang.c (go_symbol_package_name): Update.
 620         * guile/scm-block.c (bkscm_print_block_smob): Update.
 621         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 622         (gdbscm_symbol_name): Update.
 623         (gdbscm_symbol_linkage_name): Update.
 624         (gdbscm_symbol_print_name): Update.
 625         * infcall.c (get_function_name): Update.
 626         * infcmd.c (jump_command): Update.
 627         (finish_command): Update.
 628         * infrun.c (insert_exception_resume_breakpoint): Update.
 629         * linespec.c (canonicalize_linespec): Update.
 630         (create_sals_line_offset): Update.
 631         (convert_linespec_to_sals): Update.
 632         (complete_label): Update.
 633         (find_label_symbols_in_block): Update.
 634         * m2-typeprint.c (m2_print_typedef): Update.
 635         * mdebugread.c (mdebug_reg_to_regnum): Update.
 636         (parse_symbol): Update.
 637         (mylookup_symbol): Update.
 638         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 639         (list_args_or_locals): Update.
 640         * objc-lang.c (compare_selectors): Update.
 641         (info_selectors_command): Update.
 642         (compare_classes): Update.
 643         (info_classes_command): Update.
 644         (find_imps): Update.
 645         * p-typeprint.c (pascal_print_typedef): Update.
 646         * printcmd.c (build_address_symbolic): Update.
 647         (info_address_command): Update.
 648         (print_variable_and_value): Update.
 649         * python/py-framefilter.c (extract_sym): Update.
 650         (py_print_single_arg): Update.
 651         * python/py-symbol.c (sympy_str): Update.
 652         (sympy_get_name): Update.
 653         (sympy_get_linkage_name): Update.
 654         * python/python.c (gdbpy_rbreak): Update.
 655         * record-btrace.c (btrace_get_bfun_name): Update.
 656         (btrace_call_history): Update.
 657         * rust-lang.c (rust_print_typedef): Update.
 658         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 659         * stabsread.c (stab_reg_to_regnum): Update.
 660         (define_symbol): Update.
 661         (read_enum_type): Update.
 662         (common_block_end): Update.
 663         (cleanup_undefined_types_1): Update.
 664         (scan_file_globals): Update.
 665         * stack.c (print_frame_arg): Update.
 666         (print_frame_args): Update.
 667         (find_frame_funname): Update.
 668         (info_frame_command_core): Update.
 669         (iterate_over_block_locals): Update.
 670         (print_block_frame_labels): Update.
 671         (do_print_variable_and_value): Update.
 672         (iterate_over_block_arg_vars): Update.
 673         (return_command): Update.
 674         * symmisc.c (dump_symtab_1): Update.
 675         (print_symbol): Update.
 676         * symtab.c (eq_symbol_entry): Update.
 677         (symbol_cache_dump): Update.
 678         (lookup_language_this): Update.
 679         (find_pc_sect_line): Update.
 680         (skip_prologue_sal): Update.
 681         (symbol_search::compare_search_syms): Update.
 682         (treg_matches_sym_type_name): Update.
 683         (search_symbols): Update.
 684         (print_symbol_info): Update.
 685         (rbreak_command): Update.
 686         (completion_list_add_symbol): Update.
 687         (find_gnu_ifunc): Update.
 688         (get_symbol_address): Update.
 689         (search_module_symbols): Update.
 690         (info_module_subcommand): Update.
 691         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 692         (SYMBOL_LINKAGE_NAME): Remove.
 693         (SYMBOL_DEMANGLED_NAME): Remove.
 694         (SYMBOL_PRINT_NAME): Remove.
 695         (SYMBOL_SEARCH_NAME): Remove.
 696         * tracepoint.c (set_traceframe_context): Update.
 697         (validate_actionline): Update.
 698         (collection_list::collect_symbol): Update.
 699         (encode_actions_1): Update.
 700         (info_scope_command): Update.
 701         (print_one_static_tracepoint_marker): Update.
 702         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 703         * valops.c (address_of_variable): Update.
 704         (find_overload_match): Update.
 705         (find_oload_champ): Update.
 706
 707 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 708
 709         * ada-lang.c (ada_lookup_simple_minsym): Update.
 710         (ada_collect_symbol_completion_matches): Update.
 711         * ada-tasks.c (read_atcb): Update.
 712         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 713         (amd64_windows_skip_trampoline_code): Update.
 714         * arm-tdep.c (skip_prologue_function): Update.
 715         (arm_skip_stack_protector): Update.
 716         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 717         (arm_wince_skip_main_prologue): Update.
 718         * ax-gdb.c (gen_expr): Update.
 719         * block.c (call_site_for_pc): Update.
 720         * blockframe.c (find_pc_partial_function): Update.
 721         * breakpoint.c (set_breakpoint_location_function): Update.
 722         * btrace.c (ftrace_print_function_name): Update.
 723         (ftrace_function_switched): Update.
 724         * c-valprint.c (print_unpacked_pointer): Update.
 725         * coffread.c (coff_symfile_read): Update.
 726         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 727         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 728         * dwarf-index-write.c (write_psymbols): Update.
 729         * dwarf2loc.c (call_site_to_target_addr): Update.
 730         (func_verify_no_selftailcall): Update.
 731         (tailcall_dump): Update.
 732         (call_site_find_chain_1): Update.
 733         (dwarf_expr_reg_to_entry_parameter): Update.
 734         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 735         * eval.c (evaluate_funcall): Update.
 736         (evaluate_subexp_standard): Update.
 737         (evaluate_subexp_for_sizeof): Update.
 738         * expprint.c (print_subexp_standard): Update.
 739         (dump_subexp_body_standard): Update.
 740         * frame.c (get_prev_frame_always_1): Update.
 741         * frv-tdep.c (frv_skip_main_prologue): Update.
 742         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 743         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 744         (gnuv3_get_typename_from_type_info): Update.
 745         (gnuv3_skip_trampoline): Update.
 746         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 747         * i386-tdep.c (i386_skip_main_prologue): Update.
 748         (i386_pe_skip_trampoline_code): Update.
 749         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 750         * infcall.c (get_function_name): Update.
 751         * linespec.c (minsym_found): Update.
 752         * linux-fork.c (info_checkpoints_command): Update.
 753         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 754         (m32c_m16c_pointer_to_address): Update.
 755         * maint.c (maintenance_translate_address): Update.
 756         * minsyms.c (add_minsym_to_hash_table): Update.
 757         (add_minsym_to_demangled_hash_table): Update.
 758         (lookup_minimal_symbol_mangled): Update.
 759         (lookup_minimal_symbol_demangled): Update.
 760         (lookup_minimal_symbol_linkage): Update.
 761         (lookup_minimal_symbol_text): Update.
 762         (lookup_minimal_symbol_by_pc_name): Update.
 763         (minimal_symbol_is_less_than): Update.
 764         (compact_minimal_symbols): Update.
 765         (build_minimal_symbol_hash_tables): Update.
 766         (find_solib_trampoline_target): Update.
 767         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 768         (mips_skip_pic_trampoline_code): Update.
 769         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 770         * objc-lang.c (info_selectors_command): Update.
 771         (info_classes_command): Update.
 772         (find_methods): Update.
 773         (find_imps): Update.
 774         * p-valprint.c (pascal_val_print): Update.
 775         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 776         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 777         * printcmd.c (build_address_symbolic): Update.
 778         (info_symbol_command): Update.
 779         * psymtab.c (psymbol_name_matches): Update.
 780         (match_partial_symbol): Update.
 781         (lookup_partial_symbol): Update.
 782         (print_partial_symbols): Update.
 783         (sort_pst_symbols): Update.
 784         (maintenance_check_psymtabs): Update.
 785         * python/py-framefilter.c (py_print_frame): Update.
 786         * python/python.c (gdbpy_rbreak): Update.
 787         * record-btrace.c (btrace_get_bfun_name): Update.
 788         (btrace_call_history): Update.
 789         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 790         (rs6000_skip_trampoline_code): Update.
 791         * sol-thread.c (info_cb): Update.
 792         * stabsread.c (scan_file_globals): Update.
 793         * stack.c (find_frame_funname): Update.
 794         (info_frame_command_core): Update.
 795         * symmisc.c (dump_msymbols): Update.
 796         * symtab.c (symbol_natural_name): Rename to..,
 797         (general_symbol_info::natural_name): ...this.
 798         (symbol_demangled_name): Rename to...
 799         (general_symbol_info::demangled_name): ...this.
 800         (symbol_search_name): Rename to...
 801         (general_symbol_info::search_name): ...this.
 802         (symbol_matches_search_name): Update.
 803         (find_pc_sect_line): Update.
 804         (skip_prologue_sal): Update.
 805         (search_symbols): Update.
 806         (print_msymbol_info): Update.
 807         (rbreak_command): Update.
 808         (completion_list_add_msymbol): Update.
 809         (completion_list_objc_symbol): Update.
 810         (get_msymbol_address): Update.
 811         * symtab.h (struct general_symbol_info): Add member functions
 812         natural_name (), linkage_name (), print_name (), demangled_name (),
 813         and search_name ().
 814         (SYMBOL_NATURAL_NAME): Update.
 815         (symbol_natural_name): Move to a member function on general_symbol_info.
 816         (SYMBOL_DEMANGLED_NAME): Update.
 817         (symbol_demangled_name): Move to a member function on
 818         general_symbol_info.
 819         (SYMBOL_SEARCH_NAME): Update.
 820         (symbol_search_name): Move to a member function on general_symbol_info.
 821         (MSYMBOL_NATURAL_NAME): Remove.
 822         (MSYMBOL_LINKAGE_NAME): Remove.
 823         (MSYMBOL_PRINT_NAME): Remove.
 824         (MSYMBOL_DEMANGLED_NAME): Remove.
 825         (MSYMBOL_SEARCH_NAME): Remove.
 826         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 827
 828 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 829
 830         * symtab.c (create_demangled_names_hash): Use per_bfd->
 831         minimal_symbol_count for computing the initial size, if greater
 832         than our default size.
 833
 834 2019-11-22  Tom de Vries  <tdevries@suse.de>
 835
 836         * contrib/words.sh: Improve words extraction.
 837
 838 2019-11-22  Tom de Vries  <tdevries@suse.de>
 839
 840         * contrib/words.sh: Combine sed invocations.
 841
 842 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 843
 844         * Makefile.in: Update.
 845         * demangle.c: Rename to...
 846         * gdb-demangle.c: ..this.
 847         (is_cplus_marker): Change return type to bool.
 848         (_initialize_demangler): Rename to...
 849         (_initialize_gdb_demangle): ...this.
 850         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 851         * symtab.h (demangle): Remove declaration; instead include
 852         gdb-demangle.h.
 853
 854 2019-11-21  Tom Tromey  <tromey@adacore.com>
 855
 856         * gdbsupport/format.c (format_pieces): Parse %I64d.
 857         * unittests/format_pieces-selftests.c (test_windows_formats): New
 858         function.
 859         (run_tests): Call it.
 860
 861 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 862
 863         Byte reverse display of variables with DW_END_big, DW_END_little
 864         (DW_AT_endianity) dwarf attributes if different than the native
 865         byte order.
 866         * ada-lang.c (ada_value_binop):
 867         Use type_byte_order instead of gdbarch_byte_order.
 868         * ada-valprint.c (printstr):
 869         (ada_val_print_string):
 870         * ada-lang.c (value_pointer):
 871         (ada_value_binop):
 872         Use type_byte_order instead of gdbarch_byte_order.
 873         * c-lang.c (c_get_string):
 874         Use type_byte_order instead of gdbarch_byte_order.
 875         * c-valprint.c (c_val_print_array):
 876         Use type_byte_order instead of gdbarch_byte_order.
 877         * cp-valprint.c (cp_print_class_member):
 878         Use type_byte_order instead of gdbarch_byte_order.
 879         * dwarf2loc.c (rw_pieced_value):
 880         Use type_byte_order instead of gdbarch_byte_order.
 881         * dwarf2read.c (read_base_type): Handle DW_END_big,
 882         DW_END_little
 883         * f-lang.c (f_get_encoding):
 884         Use type_byte_order instead of gdbarch_byte_order.
 885         * findvar.c (default_read_var_value):
 886         Use type_byte_order instead of gdbarch_byte_order.
 887         * gdbtypes.c (check_types_equal):
 888         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 889         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 890         and TYPE_ENDIANITY_LITTLE if set.
 891         (type_byte_order): new function.
 892         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 893         (struct main_type) <flag_endianity_not_default>:
 894         New field.
 895         (type_byte_order): New function.
 896         * infcmd.c (default_print_one_register_info):
 897         Use type_byte_order instead of gdbarch_byte_order.
 898         * p-lang.c (pascal_printstr):
 899         Use type_byte_order instead of gdbarch_byte_order.
 900         * p-valprint.c (pascal_val_print):
 901         Use type_byte_order instead of gdbarch_byte_order.
 902         * printcmd.c (print_scalar_formatted):
 903         Use type_byte_order instead of gdbarch_byte_order.
 904         * solib-darwin.c (darwin_current_sos):
 905         Use type_byte_order instead of gdbarch_byte_order.
 906         * solib-svr4.c (solib_svr4_r_ldsomap):
 907         Use type_byte_order instead of gdbarch_byte_order.
 908         * stap-probe.c (stap_modify_semaphore):
 909         Use type_byte_order instead of gdbarch_byte_order.
 910         * target-float.c (target_float_same_format_p):
 911         Use type_byte_order instead of gdbarch_byte_order.
 912         * valarith.c (scalar_binop):
 913         (value_bit_index):
 914         Use type_byte_order instead of gdbarch_byte_order.
 915         * valops.c (value_cast):
 916         Use type_byte_order instead of gdbarch_byte_order.
 917         * valprint.c (generic_emit_char):
 918         (generic_printstr):
 919         (val_print_string):
 920         Use type_byte_order instead of gdbarch_byte_order.
 921         * value.c (unpack_long):
 922         (unpack_bits_as_long):
 923         (unpack_value_bitfield):
 924         (modify_field):
 925         (pack_long):
 926         (pack_unsigned_long):
 927         Use type_byte_order instead of gdbarch_byte_order.
 928         * findvar.c (unsigned_pointer_to_address):
 929         (signed_pointer_to_address):
 930         (unsigned_address_to_pointer):
 931         (address_to_signed_pointer):
 932         (default_read_var_value):
 933         (default_value_from_register):
 934         Use type_byte_order instead of gdbarch_byte_order.
 935         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 936         Use type_byte_order instead of gdbarch_byte_order.
 937         * riscv-tdep.c (riscv_print_one_register_info):
 938         Use type_byte_order instead of gdbarch_byte_order.
 939
 940 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 943         (current_ui_gdb_stdin_ptr): Likewise.
 944         (current_ui_gdb_stderr_ptr): Likewise.
 945         (current_ui_gdb_stdlog_ptr): Likewise.
 946         (current_ui_current_uiout_ptr): Likewise.
 947         (gen_ret_current_ui_field_ptr): Remove.
 948
 949 2019-11-21  Tom de Vries  <tdevries@suse.de>
 950
 951         PR gdb/24956
 952         * cli/cli-script.c (execute_control_command): Only switch to
 953         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 954
 955 2019-11-19  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 958         Now static.  Change type of "name".
 959         (tui_set_win_height_command): Don't copy "arg".
 960         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 961         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 962
 963 2019-11-19  Ali Tamur <tamur@google.com>
 964
 965         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 966         "if (attr != nullptr)".
 967         (dwarf2_find_base_address): Likewise.
 968         (dwarf2_build_include_psymtabs): Likewise.
 969         (read_cutu_die_from_dwo): Likewise.
 970         (read_func_scope): Likewise.
 971         (read_call_site_scope): Likewise.
 972         (dwarf2_get_pc_bounds): Likewise.
 973         (dwarf2_record_block_ranges): Likewise.
 974         (dwarf2_add_field): Likewise.
 975         (dwarf2_add_member_fn): Likewise.
 976         (read_structure_type): Likewise.
 977         (read_enumeration_type): Likewise.
 978         (read_array_type): Likewise.
 979         (read_array_order): Likewise.
 980         (read_set_type): Likewise.
 981         (read_common_block): Likewise.
 982         (read_tag_reference_type): Likewise.
 983         (read_tag_string_type): Likewise.
 984         (read_subroutine_type): Likewise.
 985         (read_base_type): Likewise.
 986         (read_subrange_type): Likewise.
 987         (new_symbol): Likewise.
 988         (prepare_one_comp_unit): Likewise.
 989
 990 2019-11-19  Tom Tromey  <tromey@adacore.com>
 991
 992         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 993         result in error when DebugActiveProcess fails.
 994
 995 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 996             Pedro Alves  <palves@redhat.com>
 997
 998         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 999         * target.c (target_stack::push): Call 'unpush' if there's a
1000         target on top of the stack.
1001
1002 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * python/py-block.c (blpy_dealloc): Call tp_free.
1005         (blpy_block_syms_dealloc): Likewise.
1006         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1007         * python/py-inferior.c (infpy_dealloc): Likewise.
1008         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1009         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1010         * python/py-symbol.c (sympy_dealloc): Likewise.
1011         * python/py-symtab.c (stpy_dealloc): Likewise.
1012         * python/py-type.c (typy_iterator_dealloc): Likewise.
1013
1014 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1015
1016         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1017         constructor instead of using a class initializer.
1018
1019 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1020
1021         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1022         * configure: Regenerate.
1023         * configure.ac: Don't source common.host.
1024         * gdbsupport/common.host: Remove.
1025         * gdbsupport/mingw-strerror.c: Remove.
1026         * gdbsupport/posix-strerror.c: Rename to...
1027         * gdbsupport/safe-strerror.c: ...this.
1028
1029 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1030
1031         * maint.c (scoped_command_stats::print_time): Use localtime_r
1032         instead of localtime (provided through gnulib if necessary).
1033         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1034         of ctime.
1035
1036 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1037
1038         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1039         avoid compile errors.
1040
1041 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * config.in: Regenerate.
1044         * configure: Regenerate.
1045         * gdbsupport/common.m4: No longer check for strerror_r.
1046         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1047         POSIX version of strerror_r, now that gnulib provides it if
1048         necessary.
1049
1050 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1051
1052         * README (`configure' options): Update.
1053
1054 2019-11-14  Tom Tromey  <tromey@adacore.com>
1055
1056         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1057         expected type for the RHS if the LHS is a convenience variable.
1058
1059 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1060
1061         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1062         Provide explicit default and copy constructor.
1063
1064 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1065
1066         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1067         only call Py_INCREF (newbp) in the bppy_pending_object case.
1068
1069 2019-11-13  Tom Tromey  <tromey@adacore.com>
1070
1071         PR build/25182:
1072         * psympriv.h (partial_symbol): Remove static assert.
1073         * symtab.h (general_symbol_info, symbol): Remove static assert.
1074
1075 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * gdbsupport/format.c (format_pieces::format_pieces): Support
1078         printf 'z' size modifier.
1079         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1080         * printcmd.c (ui_printf):  Handle size_t_arg.
1081         * ui-out.c (ui_out::vmessage): Likewise.
1082         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1083         function.
1084         (run_tests): Call test_format_int_sizes.
1085
1086 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * ada-exp.y (write_ambiguous_var): Update.
1089         * buildsym.c (add_symbol_to_list): Update.
1090         * dwarf2read.c (read_variable): Update.
1091         (new_symbol): Update.
1092         * jit.c (finalize_symtab): Update.
1093         * language.c (language_alloc_type_symbol): Update.
1094         * symtab.c (fixup_symbol_section): Update.
1095         (initialize_objfile_symbol_1): Move code to...
1096         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1097         (allocate_symbol): Update.
1098         (allocate_template_symbol): Update.
1099         (get_symbol_address): Update.
1100         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1101         of having as a field, and add a constructor.
1102         (SYMBOL_VALUE): Update.
1103         (SYMBOL_VALUE_ADDRESS): Update.
1104         (SET_SYMBOL_VALUE_ADDRESS): Update.
1105         (SYMBOL_VALUE_BYTES): Update.
1106         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1107         (SYMBOL_BLOCK_VALUE): Update.
1108         (SYMBOL_VALUE_CHAIN): Update.
1109         (SYMBOL_LANGUAGE): Update.
1110         (SYMBOL_SECTION): Update.
1111         (SYMBOL_OBJ_SECTION): Update.
1112         (SYMBOL_SET_LANGUAGE): Update.
1113         (SYMBOL_SET_LINKAGE_NAME): Update.
1114         (SYMBOL_SET_NAMES): Update.
1115         (SYMBOL_NATURAL_NAME): Update.
1116         (SYMBOL_LINKAGE_NAME): Update.
1117         (SYMBOL_DEMANGLED_NAME): Update.
1118         (SYMBOL_SEARCH_NAME): Update.
1119         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1120         (struct symbol): Update.
1121         (struct template_symbol): Update.
1122         (struct rust_vtable_symbol): Update.
1123         * xcoffread.c (SYMBOL_DUP): Update.
1124
1125 2019-11-12  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-layout.c (show_layout): Set current_layout.
1128         (show_source_disasm_command, show_data)
1129         (show_source_or_disasm_and_command): Don't set current_layout.
1130
1131 2019-11-12  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1134
1135 2019-11-12  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-win.c (resize_message): New global.
1138         (show_tui_resize_message): New function.
1139         (tui_async_resize_screen): Print message if requested.
1140         (_initialize_tui_win): Add tui-resize-message setting.
1141         * NEWS: Add entry for new commands.
1142
1143 2019-11-11  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1146         functions.
1147
1148 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1151
1152 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1155         function.
1156         * python/python-internal.h (gdbpy_lookup_static_symbols):
1157         Declare new function.
1158         * python/python.c (python_GdbMethods): Add
1159         gdb.lookup_static_symbols method.
1160         * NEWS: Mention gdb.lookup_static_symbols.
1161
1162 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1165         static block of current object file first.  Also fix typo in
1166         header comment.
1167
1168 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * stack.c (set_last_displayed_sal): Delete.
1171         (last_displayed_sal_valid): Delete.
1172         (last_displayed_pspace): Delete.
1173         (last_displayed_addr): Delete.
1174         (last_displayed_symtab): Delete.
1175         (last_displayed_line): Delete.
1176         (class last_displayed_symtab_info_type): New.
1177         (last_displayed_symtab_info): New static global variable.
1178         (print_frame_info): Call methods on last_displayed_symtab_info.
1179         (clear_last_displayed_sal): Update header comment, and make use of
1180         last_displayed_symtab_info.
1181         (last_displayed_sal_is_valid): Likewise.
1182         (get_last_displayed_pspace): Likewise.
1183         (get_last_displayed_addr): Likewise.
1184         (get_last_displayed_symtab): Likewise.
1185         (get_last_displayed_line): Likewise.
1186         (get_last_displayed_sal): Likewise.
1187         * stack.h (clear_last_displayed_sal): Update header comment.
1188         (last_displayed_sal_is_valid): Likewise.
1189         (get_last_displayed_pspace): Likewise.
1190         (get_last_displayed_addr): Likewise.
1191         (get_last_displayed_symtab): Likewise.
1192         (get_last_displayed_line): Likewise.
1193         (get_last_displayed_sal): Likewise.
1194
1195 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * stack.c (frame_show_address): Convert return type to bool.
1198         * stack.h (frame_show_address): Likewise, and update header
1199         comment.
1200
1201 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1204         * unittests/vec-utils-selftests.c: New file.
1205         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1206
1207 2019-11-10  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1210         (tui_highlight_win): Likewise.
1211         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1212         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1213         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1214         Don't set can_highlight.
1215
1216 2019-11-10  Tom Tromey  <tom@tromey.com>
1217
1218         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1219         Remove unused declaration.
1220
1221 2019-11-08  Tom Tromey  <tromey@adacore.com>
1222
1223         * top.c (read_command_file): Update.
1224         (command_line_input): Make return type const.
1225         * python/py-gdb-readline.c: Update.
1226         * linespec.c (decode_line_2): Update.
1227         * defs.h (command_line_input): Make return type const.
1228         * cli/cli-script.c (read_next_line): Make return type const.
1229         * ada-lang.c (get_selections): Update.
1230
1231 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1232
1233         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1234         * mi/mi-main.c (output_cores): Likewise.
1235         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1236         (linux_xfer_osdata_modules): Likewise.
1237         * remote.c (register_remote_support_xml): Likewise.
1238         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1239         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1240
1241 2019-11-06  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-interp.c: Don't include readline.h.
1244         * tui/tui-hooks.c: Don't include readline.h.
1245         * symmisc.c: Include tilde.h, not readline.h.
1246         * symfile.c: Include tilde.h, not readline.h.
1247         * source.c: Include tilde.h, not readline.h.
1248         * solib.c: Include tilde.h, not readline.h.
1249         * psymtab.c: Include tilde.h, not readline.h.
1250         * exec.c: Include tilde.h, not readline.h.
1251         * corelow.c: Include tilde.h, not readline.h.
1252         * cli/cli-dump.c: Include tilde.h, not readline.h.
1253         * cli/cli-cmds.c: Don't include readline.h.
1254
1255 2019-11-05  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1258         (tui_disassemble): Set addr_size.
1259         (tui_disasm_window::set_contents): Use addr_size.
1260
1261 2019-11-05  Tom Tromey  <tom@tromey.com>
1262
1263         * rust-lang.c (rust_language_defn): Update.
1264         * python/py-value.c (valpy_string): Call c_get_string.
1265         * p-lang.c (pascal_language_defn): Update.
1266         * opencl-lang.c (opencl_language_defn): Update.
1267         * objc-lang.c (objc_language_defn): Update.
1268         * m2-lang.c (m2_language_defn): Update.
1269         * language.c (unknown_language_defn, auto_language_defn): Update.
1270         (default_get_string): Remove.
1271         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1272         * go-lang.c (go_language_defn): Update.
1273         * f-lang.c (f_language_defn): Update.
1274         * d-lang.c (d_language_defn): Update.
1275         * c-lang.c (c_language_defn, cplus_language_defn)
1276         (asm_language_defn, minimal_language_defn): Update.
1277         * ada-lang.c (ada_language_defn): Update.
1278         * language.h (struct language_defn) <la_get_string>: Remove.
1279         (LA_GET_STRING): Remove.
1280         (default_get_string): Don't declare.
1281
1282 2019-11-05  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-source.h (struct tui_source_window): Inline
1285         constructor.  Remove destructor.
1286         <style_changed, m_observable>: Move to superclass.
1287         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1288         (struct tui_source_window_base): Move private members to end.
1289         <style_changed, m_observable>: Move from tui_source_window.
1290         * tui/tui-winsource.c (tui_copy_source_line): Move from
1291         tui-source.c.  Rename from copy_source_line.  Add special handling
1292         for negative line number.
1293         (tui_source_window_base::style_changed): Move from
1294         tui_source_window.
1295         (tui_source_window_base): Register observer.
1296         (~tui_source_window_base): New.
1297         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1298         rename.
1299         (tui_source_window::set_contents): Use tui_copy_source_line.
1300         (tui_source_window::tui_source_window): Move to tui-source.h.
1301         (tui_source_window::~tui_source_window): Remove.
1302         (tui_source_window::style_changed): Move to superclass.
1303         * tui/tui-disasm.c (tui_disassemble): Create string file with
1304         styling, when possible.  Add "addr_size" parameter.
1305         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1306         Don't compute maximum size.
1307         (len_without_escapes): New function
1308
1309 2019-11-05  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1312         std::string.
1313         * tui/tui-winsource.c (tui_show_source_line): Update.
1314         * tui/tui-source.c (tui_source_window::set_contents): Update.
1315         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1316
1317 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1318
1319         * symtab.h (gdb_static_assert): Put && operator at the beginning
1320         of the line instead of the end.
1321
1322 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1323
1324         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1325         and sizeof (symbol).
1326         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1327
1328 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1329
1330         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1331         * configure.host: Mark *-*-solaris2.10* obsolete.
1332         * configure.tgt: Mark Solaris < 11 obsolete.
1333         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1334         Update target triplet.
1335
1336 2019-11-01  Tom Tromey  <tromey@adacore.com>
1337
1338         * utils.c (print_sys_errmsg): Simplify.
1339
1340 2019-11-01  Tom Tromey  <tromey@adacore.com>
1341
1342         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1343
1344 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1345
1346         * configure: Regenerate.
1347         * configure.ac: Remove check for strerror_r.
1348         * gdbsupport/common.m4: Check for strerror_r.
1349
1350 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1351
1352         PR gdb/25124
1353
1354         * arm-tdep.c (arm_per_objfile): Rename to ...
1355         (arm_per_bfd): ... this.
1356         (arm_objfile_data_key): Rename to ...
1357         (arm_bfd_data_key): ... this.
1358         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1359         data.
1360         (arm_record_special_symbol): Likewise.
1361
1362 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1365         end.
1366         * c-typeprint.c (c_print_typedef): Likewise.
1367         * f-typeprint.c (f_print_typedef): Likewise.
1368         * m2-typeprint.c (m2_print_typedef): Likewise.
1369         * p-typeprint.c (pascal_print_typedef): Likewise.
1370         * rust-lang.c (rust_print_typedef): Likewise.
1371         * symtab.c (print_symbol_info): Print a newline after calling
1372         typedef_print.
1373
1374 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * symtab.c (info_module_cmdlist): New variable.
1377         (info_module_command): New function.
1378         (search_module_symbols): New function.
1379         (info_module_subcommand): New function.
1380         (struct info_modules_var_func_options): New struct.
1381         (info_modules_var_func_options_defs): New variable.
1382         (make_info_modules_var_func_options_def_group): New function.
1383         (info_module_functions_command): New function.
1384         (info_module_variables_command): New function.
1385         (info_module_var_func_command_completer): New function.
1386         (_initialize_symtab): Register new 'info module functions' and
1387         'info module variables' commands.
1388         * symtab.h (typedef symbol_search_in_module): New typedef.
1389         (search_module_symbols): Declare new function.
1390         * NEWS: Mention new commands.
1391
1392 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1393
1394         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1395         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1396         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1397         MODULES_DOMAIN.
1398         (scan_partial_symbols): Only create partial module symbols for non
1399         declarations.
1400         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1401         and MODULES_DOMAIN.
1402         * symtab.c (search_domain_name): Likewise.
1403         (search_symbols): Likewise.
1404         (print_symbol_info): Likewise.
1405         (symtab_symbol_info): Likewise.
1406         (info_modules_command): New function.
1407         (_initialize_symtab): Register 'info modules' command.
1408         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1409         * NEWS: Mention new 'info modules' command.
1410
1411 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1412
1413         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1414         and $_gdb_maint_setting_str.
1415
1416 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417
1418         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1419         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1420         (str_value_from_setting, gdb_setting_str_internal_fn)
1421         (gdb_maint_setting_str_internal_fn): New functions.
1422         (_initialize_cli_cmds): Define the new convenience functions.
1423         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1424         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1425
1426 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1427
1428         * agent.c (set_can_use_agent): When the setting is turned on,
1429         look up agent symbols if we don't have them yet.
1430         (agent_new_objfile): Don't look up agent symbols when the agent
1431         setting is off.
1432
1433 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * config.in: Regenerate.
1436
1437 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * configure: Regenerate.
1440         * configure.ac: Check for strerror_r.
1441         * gdbsupport/common-utils.h (safe_strerror): Change return value
1442         to const char * and document that this function is now threadsafe.
1443         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1444         thread_local and call strerror_r, if available.
1445         * utils.c (perror_string): Update.
1446         (print_sys_errmsg): Update.
1447
1448 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1449
1450         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1451         objfile_key.
1452         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1453         objfile to fetch per-bfd data.
1454         (arm_find_exidx_entry): Likewise.
1455
1456 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1457
1458         * gdbsupport/agent.c (debug_agent): Change type to bool.
1459         (use_agent): Likewise.
1460         (all_agent_symbols_look_up): Likewise.
1461         (agent_loaded_p): Change return value to bool.
1462         (agent_look_up_symbols): Update.
1463         (agent_capability_check): Change return value to bool.
1464         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1465         (debug_agent): Change type to bool.
1466         (use_agent): Likewise.
1467         (agent_capability_check): Change return value to bool.
1468
1469 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1470
1471         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1472         (build_minimal_symbol_hash_tables): Code to clear the table moved
1473         to clear_minimal_symbol_hash_tables.
1474         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1475         when needed.
1476
1477 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1478
1479         * infcmd.c: Remove includes.
1480         * infrun.c: Remove includes.
1481
1482 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1483
1484         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1485         (grow_vect): Remove declaration.
1486         (ada_type_of_array): Remove declaration.
1487         (ada_update_initial_language): Remove declaration.
1488         (ada_fold_name): Remove declaration.
1489         (ada_fill_in_ada_prototype): Remove declaration.
1490         (user_select_syms): Remove declaration.
1491         (get_selections): Remove declaration.
1492         (ada_tag_type): Remove declaration.
1493         (ada_value_tag): Remove declaration.
1494         (ada_is_others_clause): Remove declaration.
1495         (ada_in_variant): Remove declaration.
1496         (ada_value_struct_elt): Remove declaration.
1497         (ada_attribute_name): Remove declaration.
1498         (ada_system_address_type): Remove declaration.
1499         * ada-lang.c (ada_watch_location_expression): Make static.
1500         (GROW_VECT): Move here from ada-lang.h.
1501         (grow_vect): Make static.
1502         (ada_update_initial_language): Make static.
1503         (ada_fold_name): Make static.
1504         (ada_type_of_array): Make static.
1505         (encoded_ordered_before): Move up.
1506         (sort_choices): Move up.
1507         (print_signatures): Move up.
1508         (ada_print_symbol_signature): Move up.
1509         (get_selections): Move up and make static.
1510         (user_select_syms): Move up and make static.
1511         (ada_value_struct_elt): Move up and make static.
1512         (ada_tag_type): Make static.
1513         (ada_value_tag): Make static.
1514         (ada_is_others_clause): Make static.
1515         (ada_in_variant): Make static.
1516         (ada_attribute_name): Make static.
1517
1518 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1519
1520         * ada-lang.c: Remove includes.
1521         * ada-typeprint.c: Remove includes.
1522         * ada-valprint.c: Remove includes.
1523
1524 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1525
1526         * addrmap.c: Add static assertions of type size, moved from
1527         _initialize_addrmap.
1528         (_initialize_addrmap): Remove.
1529
1530 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1531
1532         * coffread.c (record_minimal_symbol): Update.
1533         (process_coff_symbol): Update.
1534         * dbxread.c (read_dbx_symtab): Update.
1535         * dwarf2read.c (add_partial_symbol): Update.
1536         (fixup_go_packaging): Update.
1537         (load_partial_dies): Update.
1538         (new_symbol): Update.
1539         * elfread.c (record_minimal_symbol): Change signature to use
1540         gdb::string_view instead of name+len.
1541         (elf_symtab_read): Update.
1542         (elf_rel_plt_read): Update.
1543         * mdebugread.c (parse_partial_symbols): Update.
1544         (handle_psymbol_enumerators): Update.
1545         (new_symbol): Update.
1546         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1547         to use gdb::string_view instead of name+len.
1548         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1549         * psympriv.h (add_psymbol_to_list): Likewise.
1550         * psymtab.c (add_psymbol_to_bcache): Likewise.
1551         (add_psymbol_to_list): Likewise.
1552         * stabsread.c (define_symbol): Update.
1553         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1554         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1555         (symbol_set_names): Likewise.
1556         * xcoffread.c (scan_xcoff_symtab): Update.
1557
1558 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1559
1560         * symtab.h (symbol_set_names): Document that copy_name must be
1561         set to true for non-nullterminated strings.
1562         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1563         linkage_name if the entry was not found and we need to demangle.
1564
1565 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1566
1567         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1568         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1569         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1570         * gdbsupport/gdb_binary_search.h: New file.
1571
1572 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1573
1574         * NEWS: Mention new --with-system-gdbinit-dir option.
1575         * config.in: Regenerate.
1576         * configure: Regenerate.
1577         * configure.ac: Add new option --with-system-gdbinit-dir.
1578         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1579         for a ".gdb" suffix.
1580         * main.c (get_init_files): Change system_gdbinit argument to
1581         a vector and return the files in SYSTEM_GDBINIT_DIR in
1582         addition to SYSTEM_GDBINIT.
1583         (captured_main_1): Update.
1584         (print_gdb_help): Update.
1585         * top.c (print_gdb_configuration): Also print the value of
1586         SYSTEM_GDBINIT_DIR.
1587
1588 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1589
1590         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1591         that takes gdb::string_view arguments.
1592
1593 2019-10-26  Tom de Vries  <tdevries@suse.de>
1594
1595         * aarch64-linux-tdep.c: Fix typos in comments.
1596         * aarch64-tdep.c: Same.
1597         * ada-lang.c: Same.
1598         * amd64-nat.c: Same.
1599         * arc-tdep.c: Same.
1600         * arch/aarch64-insn.c: Same.
1601         * block.c: Same.
1602         * breakpoint.h: Same.
1603         * btrace.h: Same.
1604         * c-varobj.c: Same.
1605         * cli/cli-decode.c: Same.
1606         * cli/cli-script.c: Same.
1607         * cli/cli-utils.h: Same.
1608         * coff-pe-read.c: Same.
1609         * coffread.c: Same.
1610         * compile/compile-cplus-symbols.c: Same.
1611         * compile/compile-object-run.c: Same.
1612         * completer.c: Same.
1613         * corelow.c: Same.
1614         * cp-support.c: Same.
1615         * demangle.c: Same.
1616         * dwarf-index-write.c: Same.
1617         * dwarf2-frame.c: Same.
1618         * dwarf2-frame.h: Same.
1619         * eval.c: Same.
1620         * frame-base.h: Same.
1621         * frame.h: Same.
1622         * gdbcmd.h: Same.
1623         * gdbtypes.h: Same.
1624         * gnu-nat.c: Same.
1625         * guile/scm-objfile.c: Same.
1626         * i386-tdep.c: Same.
1627         * i386-tdep.h: Same.
1628         * infcall.c: Same.
1629         * infcall.h: Same.
1630         * linux-nat.c: Same.
1631         * m68k-tdep.c: Same.
1632         * macroexp.c: Same.
1633         * memattr.c: Same.
1634         * mi/mi-cmd-disas.c: Same.
1635         * mi/mi-getopt.h: Same.
1636         * mi/mi-main.c: Same.
1637         * minsyms.c: Same.
1638         * nat/aarch64-sve-linux-sigcontext.h: Same.
1639         * objfiles.h: Same.
1640         * ppc-linux-nat.c: Same.
1641         * ppc-linux-tdep.c: Same.
1642         * ppc-tdep.h: Same.
1643         * progspace.h: Same.
1644         * prologue-value.h: Same.
1645         * python/py-evtregistry.c: Same.
1646         * python/py-instruction.h: Same.
1647         * record-btrace.c: Same.
1648         * record-full.c: Same.
1649         * remote.c: Same.
1650         * rs6000-tdep.c: Same.
1651         * ser-tcp.c: Same.
1652         * sol-thread.c: Same.
1653         * sparc-sol2-tdep.c: Same.
1654         * sparc64-tdep.c: Same.
1655         * stabsread.c: Same.
1656         * symfile.c: Same.
1657         * symtab.h: Same.
1658         * target.c: Same.
1659         * tracepoint.c: Same.
1660         * tui/tui-data.h: Same.
1661         * tui/tui-io.c: Same.
1662         * tui/tui-win.c: Same.
1663         * tui/tui.c: Same.
1664         * unittests/rsp-low-selftests.c: Same.
1665         * user-regs.h: Same.
1666         * utils.c: Same.
1667         * utils.h: Same.
1668         * valarith.c: Same.
1669         * valops.c: Same.
1670         * valprint.c: Same.
1671         * valprint.h: Same.
1672         * value.c: Same.
1673         * value.h: Same.
1674         * varobj.c: Same.
1675         * x86-nat.h: Same.
1676         * xtensa-tdep.c: Same.
1677
1678 2019-10-25  Ali Tamur <tamur@google.com>
1679
1680         * charset.c (find_charset_names): Reflect API change.
1681
1682 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1683
1684         * symtab.c (struct demangled_name_entry): Change demangled name
1685         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1686         part of the struct anymore.
1687         (symbol_set_names): No longer obstack allocate + copy the demangled
1688         name, just store the allocated name from bfd.
1689
1690 2019-10-25  Tom Tromey  <tromey@adacore.com>
1691
1692         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1693         (bsearch_cie_cmp, add_cie): Remove.
1694         (find_cie): Reimplement.
1695         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1696         (dwarf2_build_frame_info): Update.
1697
1698 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1699
1700         PR gdb/25126
1701         * symfile.c (reread_symbols): Call forget_cached_source_info to
1702         clear the stale source cache.
1703
1704 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1705
1706         * configure: Regenerate.
1707         * configure.ac: Remove code that sets python_has_threads.
1708
1709 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1710
1711         * config.in: Regenerate.
1712         * configure: Regenerate.
1713         * configure.ac: Remove the code that uses sed to get the python
1714         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1715
1716 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1719         error paths.
1720
1721 2019-10-23  Tom Tromey  <tom@tromey.com>
1722
1723         * arc-tdep.c: Remove ".." from include.
1724         * frv-tdep.c: Remove ".." from include.
1725         * lm32-tdep.c: Remove ".." from include.
1726         * microblaze-tdep.c: Remove ".." from include.
1727         * or1k-tdep.h: Remove ".." from include.
1728         * s12z-tdep.c: Remove ".." from include.
1729         * Makefile.in (OPCODES_CFLAGS): Add comment.
1730         (TOP_CFLAGS): New variable.
1731         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1732
1733 2019-10-23  Tom Tromey  <tom@tromey.com>
1734
1735         * Makefile.in (READLINE_DIR): Update.
1736
1737 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1738
1739         * infcall.c (call_function_by_hand_dummy): Fix the function
1740         comment.  And extract out a code section into...
1741         (reserve_stack_space): ...this new function.
1742
1743 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1744
1745         * infcall.c (value_arg_coerce): Remove an unused parameter.
1746         (call_function_by_hand_dummy): Update the call to
1747         'value_arg_coerce'.
1748
1749 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1750
1751         * infcall.c (call_function_by_hand_dummy): Refactor.
1752
1753 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1754
1755         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1756
1757 2019-10-23  Tom Tromey  <tom@tromey.com>
1758
1759         * configure: Rebuild.
1760         * configure.ac: Don't check for sigprocmask.
1761         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1762
1763 2019-10-23  Tom Tromey  <tom@tromey.com>
1764
1765         * configure: Rebuild.
1766         * acinclude.m4: Use m4_include, not sinclude.
1767
1768 2019-10-23  Tom de Vries  <tdevries@suse.de>
1769
1770         PR breakpoints/24687
1771         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1772
1773 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1774
1775         * symtab.c (struct demangled_name_entry) <language>: Change from
1776         bitfield to regular variable.
1777
1778 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1779
1780         * symtab.c (struct demangled_name_entry): Add a constructor.
1781         (free_demangled_name_entry): New function to call the destructor
1782         for demangled_name_entry.
1783         (create_demangled_names_hash): Pass free_demangled_name_entry to
1784         htab_create_alloc.
1785         (symbol_set_names): Call placement new for demangled_name_entry.
1786         * utils.c: No longer include xxhash.h here, now that fast_hash
1787         is inlined in the header.
1788         * utils.h: Instead, include it here.
1789
1790 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1791
1792         * Makefile.in: Link with libxxhash.
1793         * config.in: Regenerate.
1794         * configure: Regenerate.
1795         * configure.ac: Search for libxxhash.
1796         * utils.c (fast_hash): Use xxhash if present.
1797
1798 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1799
1800         * utils.h (fast_hash): New function.
1801         * symtab.c (hash_demangled_name_entry): Call new function
1802         fast_hash.
1803
1804 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1805
1806         * symtab.c (struct demangled_name_entry): Change type of mangled
1807         to gdb::string_view. Also adds a constructor that takes the
1808         mangled name.
1809         (hash_demangled_name_entry): Update.
1810         (eq_demangled_name_entry): Update.
1811         (free_demangled_name_entry): New function to call the destructor
1812         now that this is not a POD anymore.
1813         (create_demangled_names_hash): Pass free_demangled_name_entry to
1814         htab_create_alloc.
1815         (symbol_set_names): Update.
1816
1817 2019-10-21  Ali Tamur  <tamu@google.com>
1818
1819         * dwarf2read.c (dir_index): Change type.
1820         (file_name_index): Likewise.
1821         (line_header::include_dir_at): Change comment and implementation on
1822         whether it is DWARF 5.
1823         (line_header::is_valid_file_index): New function.
1824         (line_header::file_name_at): Change comment and implementation on
1825         whether it is DWARF 5.
1826         (line_header::file_names): Change to private field renamed as
1827         m_file_names and introduce a new accessor method.
1828         (line_header::file_names_size): New method.
1829         (line_header::include_dirs): Change to private field and rename as
1830         m_include_dirs.
1831         (dw2_get_file_names_reader): Define local var at a smaller scope and
1832         reflect API change.
1833         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1834         (process_structure_scope): Likewise.
1835         (line_header::add_include_dir): Change message and reflect renaming.
1836         (line_header::add_file_name): Likewise.
1837         (read_formatted_entries): Handle DW_FORM_data16.
1838         (dwarf_decode_line_header): Fix line header length calculation.
1839         (psymtab_include_file_name): Change comment and API.
1840         (lnp_state_machine::m_file): Update comment and reflect type change.
1841         (lnp_state_machine::record_line): Reflect type change.
1842         (dwarf_decode_lines): Reflect API change.
1843         (file_file_name): Likewise.
1844         (file_full_name): Likewise.
1845
1846 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1849
1850 2019-10-21  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1853
1854 2019-10-21  Tom Tromey  <tom@tromey.com>
1855
1856         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1857         NM_H.   Use AC_CONFIG_LINKS.
1858         * configure: Rebuild.
1859         * Makefile.in (NM_H): New variable.
1860         (generated_files): Add NM_H.  Remove gcore.
1861         (nm.h, stamp-nmh): New targets.
1862
1863 2019-10-20  Tom Tromey  <tom@tromey.com>
1864
1865         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1866         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1867         obsolete comment.
1868         (put_objfile_before): Now static.
1869
1870 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1871
1872         * gdbsupport/common-utils.h (startswith): Change return type to
1873         bool.
1874
1875 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1876
1877         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1878         * breakpoint.c (bp_locations_compare): Rename to...
1879         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1880         (update_global_location_list): Use std::sort instead of qsort.
1881         * buildsym.c (compare_line_numbers): Rename to...
1882         (lte_is_less_than): ...this, and change to std::sort semantics.
1883         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1884         instead of qsort.
1885         * disasm.c (compare_lines): Rename to...
1886         (line_is_less_than): ...this, and change to std::sort semantics.
1887         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1888         of qsort.
1889         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1890         (fde_is_less_than): ...this, and change to std::sort semantics.
1891         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1892         * mdebugread.c (compare_blocks):
1893         (block_is_less_than): ...this, and change to std::sort semantics.
1894         (sort_blocks): Call std::sort instead of qsort.
1895         * objfiles.c (qsort_cmp): Rename to...
1896         (sort_cmp): ...this, and change to std::sort semantics.
1897         (update_section_map): Call std::sort instead of qsort.
1898         * remote.c (compare_pnums): Remove.
1899         (map_regcache_remote_table): Call std::sort instead of qsort.
1900         * utils.c (compare_positive_ints): Remove.
1901         * utils.h (compare_positive_ints): Remove.
1902         * xcoffread.c (compare_lte): Remove.
1903         (arrange_linetable): Call std::sort instead of qsort.
1904
1905 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1906
1907         * symfile.c (init_entry_point_info): Fix typo.
1908         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1909
1910 2019-10-18  Tom de Vries  <tdevries@suse.de>
1911
1912         * aarch64-tdep.c: Fix typos in comments.
1913         * ada-lang.c: Same.
1914         * ada-tasks.c: Same.
1915         * alpha-tdep.c: Same.
1916         * alpha-tdep.h: Same.
1917         * amd64-nat.c: Same.
1918         * amd64-windows-tdep.c: Same.
1919         * arc-tdep.c: Same.
1920         * arc-tdep.h: Same.
1921         * arch-utils.c: Same.
1922         * arm-nbsd-tdep.c: Same.
1923         * arm-tdep.c: Same.
1924         * ax-gdb.c: Same.
1925         * blockframe.c: Same.
1926         * btrace.c: Same.
1927         * c-varobj.c: Same.
1928         * coff-pe-read.c: Same.
1929         * coffread.c: Same.
1930         * cris-tdep.c: Same.
1931         * darwin-nat.c: Same.
1932         * dbxread.c: Same.
1933         * dcache.c: Same.
1934         * disasm.c: Same.
1935         * dtrace-probe.c: Same.
1936         * dwarf-index-write.c: Same.
1937         * dwarf2-frame-tailcall.c: Same.
1938         * dwarf2-frame.c: Same.
1939         * dwarf2read.c: Same.
1940         * eval.c: Same.
1941         * exceptions.c: Same.
1942         * fbsd-tdep.c: Same.
1943         * findvar.c: Same.
1944         * frame.c: Same.
1945         * frv-tdep.c: Same.
1946         * gnu-v3-abi.c: Same.
1947         * go32-nat.c: Same.
1948         * h8300-tdep.c: Same.
1949         * hppa-tdep.c: Same.
1950         * i386-linux-tdep.c: Same.
1951         * i386-tdep.c: Same.
1952         * ia64-libunwind-tdep.c: Same.
1953         * ia64-tdep.c: Same.
1954         * infcmd.c: Same.
1955         * infrun.c: Same.
1956         * linespec.c: Same.
1957         * linux-nat.c: Same.
1958         * linux-thread-db.c: Same.
1959         * machoread.c: Same.
1960         * mdebugread.c: Same.
1961         * mep-tdep.c: Same.
1962         * mn10300-tdep.c: Same.
1963         * namespace.c: Same.
1964         * objfiles.c: Same.
1965         * opencl-lang.c: Same.
1966         * or1k-tdep.c: Same.
1967         * osabi.c: Same.
1968         * ppc-linux-nat.c: Same.
1969         * ppc-linux-tdep.c: Same.
1970         * ppc-sysv-tdep.c: Same.
1971         * printcmd.c: Same.
1972         * procfs.c: Same.
1973         * record-btrace.c: Same.
1974         * record-full.c: Same.
1975         * remote-fileio.c: Same.
1976         * remote.c: Same.
1977         * rs6000-tdep.c: Same.
1978         * s12z-tdep.c: Same.
1979         * score-tdep.c: Same.
1980         * ser-base.c: Same.
1981         * ser-go32.c: Same.
1982         * skip.c: Same.
1983         * sol-thread.c: Same.
1984         * solib-svr4.c: Same.
1985         * solib.c: Same.
1986         * source.c: Same.
1987         * sparc-nat.c: Same.
1988         * sparc-sol2-tdep.c: Same.
1989         * sparc-tdep.c: Same.
1990         * sparc64-tdep.c: Same.
1991         * stabsread.c: Same.
1992         * stack.c: Same.
1993         * symfile.c: Same.
1994         * symtab.c: Same.
1995         * target-descriptions.c: Same.
1996         * target-float.c: Same.
1997         * thread.c: Same.
1998         * utils.c: Same.
1999         * valops.c: Same.
2000         * valprint.c: Same.
2001         * value.c: Same.
2002         * varobj.c: Same.
2003         * windows-nat.c: Same.
2004         * xcoffread.c: Same.
2005         * xstormy16-tdep.c: Same.
2006         * xtensa-tdep.c: Same.
2007
2008 2019-10-17  Tom Tromey  <tromey@adacore.com>
2009
2010         * configure: Rebuild.
2011         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2012         in AC_CONFIG_FILES invocation.
2013         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2014         new-style config.status invocation.
2015
2016 2019-10-17  Tom de Vries  <tdevries@suse.de>
2017
2018         * arm-nbsd-nat.c: Fix typos in comments.
2019         * arm-tdep.c: Same.
2020         * darwin-nat-info.c: Same.
2021         * dwarf2read.c: Same.
2022         * elfread.c: Same.
2023         * event-top.c: Same.
2024         * findvar.c: Same.
2025         * gdbtypes.c: Same.
2026         * hppa-tdep.c: Same.
2027         * i386-tdep.c: Same.
2028         * jit.c: Same.
2029         * main.c: Same.
2030         * mdebugread.c: Same.
2031         * moxie-tdep.c: Same.
2032         * nto-procfs.c: Same.
2033         * osabi.c: Same.
2034         * ppc-linux-tdep.c: Same.
2035         * remote.c: Same.
2036         * riscv-tdep.c: Same.
2037         * s390-tdep.c: Same.
2038         * sh-tdep.c: Same.
2039         * sparc-linux-tdep.c: Same.
2040         * sparc-nat.c: Same.
2041         * stack.c: Same.
2042         * target-descriptions.c: Same.
2043         * top.c: Same.
2044         * varobj.c: Same.
2045
2046 2019-10-16  Tom Tromey  <tom@tromey.com>
2047
2048         * objfiles.h (struct objfile) <original_name>: Now const.
2049
2050 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2051
2052         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2053         pass on to sigsetjmp's second argument.
2054         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2055
2056 2019-10-16  Keith Seitz  <keiths@redhat.com>
2057
2058         PR gdb/23567
2059         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2060         sections whose size is greater than the file size.
2061
2062 2019-10-16  Jim Wilson  <jimw@sifive.com>
2063
2064         * riscv-tdep.c (riscv_gcc_target_options): New.
2065         (riscv_gnu_triplet_regexp): New.
2066         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2067         set_gdbarch_gnu_triplet_regexp.
2068
2069 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2070
2071         * Makefile.in: Add xml-builtin.h.
2072         * features/feature_to_c.sh: Add an include for xml-builtin.h
2073         to ensure that the compiler checks that the types match.
2074         * xml-builtin.h: New file.
2075         * xml-support.c (fetch_xml_builtin): Add missing const.
2076         * xml-support.h: Remove declaration of xml_builtins.
2077
2078 2019-10-16  Tom de Vries  <tdevries@suse.de>
2079
2080         PR tdep/25096
2081         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2082         (amd64_classify_aggregate): ... here.
2083         (amd64_classify_aggregate_field): Handled fiels of nested structs
2084         recursively.
2085
2086 2019-10-16  Tom de Vries  <tdevries@suse.de>
2087
2088         PR tdep/24104
2089         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2090         that handles 'theclass'.
2091
2092 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2093
2094         * linespec.c (decode_digits_ordinary): Update comment.
2095         * make-target-delegates: No longer need to handle VEC case.
2096         * memrange.c (normalize_mem_ranges): Update comment.
2097         * namespace.c (add_using_directive): Update comment.
2098         * objc-lang.c (uniquify_strings): Update comment.
2099         * ppc-linux-nat.c (struct thread_points): Update comment.
2100         * probe.h (find_probes_in_objfile): Update comment.
2101         * target.h (enum flash_preserve_mode): Update comment.
2102         * varobj.c (varobj_restrict_range): Update comment.
2103         * varobj.h (varobj_list_children): Update comment.
2104
2105 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2106
2107         * Makefile.in: Remove references to vec.h and vec.c.
2108         * aarch64-tdep.c: No longer include vec.h.
2109         * ada-lang.c: Likewise.
2110         * ada-lang.h: Likewise.
2111         * arm-tdep.c: Likewise.
2112         * ax.h: Likewise.
2113         * breakpoint.h: Likewise.
2114         * charset.c: Likewise.
2115         * cp-support.h: Likewise.
2116         * dtrace-probe.c: Likewise.
2117         * dwarf2read.c: Likewise.
2118         * extension.h: Likewise.
2119         * gdb_bfd.c: Likewise.
2120         * gdbsupport/gdb_vecs.h: Likewise.
2121         * gdbsupport/vec.c: Remove.
2122         * gdbsupport/vec.h: Remove.
2123         * gdbthread.h: Likewise.
2124         * guile/scm-type.c: Likewise.
2125         * inline-frame.c: Likewise.
2126         * machoread.c: Likewise.
2127         * memattr.c: Likewise.
2128         * memrange.h: Likewise.
2129         * namespace.h: Likewise.
2130         * nat/linux-btrace.h: Likewise.
2131         * osdata.c: Likewise.
2132         * parser-defs.h: Likewise.
2133         * progspace.h: Likewise.
2134         * python/py-type.c: Likewise.
2135         * record-btrace.c: Likewise.
2136         * rust-exp.y: Likewise.
2137         * solib-target.c: Likewise.
2138         * stap-probe.c: Likewise.
2139         * target-descriptions.c: Likewise.
2140         * target-memory.c: Likewise.
2141         * target.h: Likewise.
2142         * varobj.c: Likewise.
2143         * varobj.h: Likewise.
2144         * xml-support.h: Likewise.
2145
2146 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2149         Update for new std::vector based implementation.
2150         (process_psymtab_comp_unit_reader): Likewise.
2151         (scan_partial_symbols): Likewise.
2152         (recursively_compute_inclusions): Likewise.
2153         (compute_compunit_symtab_includes): Likewise.
2154         (process_imported_unit_die): Likewise.
2155         (queue_and_load_dwo_tu): Likewise.
2156         (follow_die_sig_1): Likewise.
2157         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2158         (typedef dwarf2_per_cu_ptr): Remove.
2159         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2160         function.
2161         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2162         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2163         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2164         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2165         std::vector.
2166
2167 2019-10-15  Tom Tromey  <tromey@adacore.com>
2168
2169         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2170         TID.
2171
2172 2019-10-15  Tom Tromey  <tromey@adacore.com>
2173
2174         * windows-nat.c (windows_nat_target::fetch_registers)
2175         (windows_nat_target::store_registers): Rename "pid" to "tid".
2176
2177 2019-10-15  Tom Tromey  <tromey@adacore.com>
2178
2179         * gdbarch.h, gdbarch.c: Rebuild.
2180         * gdbarch.sh (gcc_target_options): Change return type to
2181         std::string.
2182         * compile/compile.c (get_args): Update.
2183         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2184         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2185         std::string.
2186         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2187         std::string.
2188         * arch-utils.c (default_gcc_target_options): Return std::string.
2189         * arch-utils.h (default_gcc_target_options): Return std::string.
2190         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2191
2192 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2193
2194         * breakpoint.c (breakpoint_chain): Make static.
2195         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2196         of accessing breakpoint_chain.
2197
2198 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2199
2200         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2201         to a gdb::function_view and return value to bool.
2202         * breakpoint.h (iterate_over_breakpoints): Likewise.
2203         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2204         (pop_dummy_frame): Update.
2205         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2206         (gdbscm_breakpoints): Update.
2207         * python/py-breakpoint.c (build_bp_list): Update.
2208         (gdbpy_breakpoints): Update.
2209         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2210         Update.
2211         (bpfinishpy_handle_stop): Update.
2212         (bpfinishpy_handle_exit): Update.
2213         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2214         (svr4_update_solib_event_breakpoints): Update.
2215
2216 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2217
2218         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2219         when unwrapping single-field structs.
2220
2221 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2222
2223         * dwarf2read.c: Remove includes.
2224
2225 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2226
2227         * ui-out.c (ui_out::call_do_message): Silence
2228         -Wformat-nonliteral warning.
2229
2230 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2231
2232         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2233         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2234         include: readline/tilde.h.
2235
2236 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2237
2238         * remote.c (remote_target::get_trace_status): Remove declaration of
2239         trace_regblock_size.
2240
2241 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2242
2243         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2244         (show_user): Remove declaration of cmdlist.
2245         * cli/cli-cmds.h (max_user_call_depth): Declare.
2246         * cli/cli-script.c (execute_user_command): Remove declaration
2247         of max_user_call_depth.
2248
2249 2019-10-11  Jim Wilson  <jimw@sifive.com>
2250
2251         * gdbsupport/print-utils.h (pulongest): Fix comment.
2252         (plongest): Likewise.
2253         (phex): Add missing comment, mention leading zeros.
2254         (phex_nz): Add mention of no leading zeros to comment.
2255
2256         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2257         plongest instead of unsigned long long cast.
2258
2259 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2260
2261         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2262         for external_editor_command and gdbtk_test.
2263
2264 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2265
2266         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2267         * varobj.c (varobjdebug): Move comment to...
2268         * varobj.h (varobjdebug): ...here, and declare.
2269
2270 2019-10-09  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2273         erase_data_content.
2274
2275 2019-10-09  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2278         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2279         * tui/tui-command.c (tui_cmd_window::resize)
2280         (tui_refresh_cmd_win): Update.
2281         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2282         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2283         * tui/tui-data.c (~tui_gen_win_info): Remove.
2284         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2285         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2286         (tui_redisplay_readline, tui_mld_flush)
2287         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2288         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2289         (tui_data_window::erase_data_content)
2290         (tui_data_item_window::rerender)
2291         (tui_data_item_window::refresh_window): Update.
2292         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2293         (box_win, tui_gen_win_info::make_window)
2294         (tui_gen_win_info::make_visible): Update.
2295         (tui_delete_win): Remove.
2296         * tui/tui-winsource.c
2297         (tui_source_window_base::do_erase_source_content): Update.
2298         (tui_show_source_line, tui_source_window_base::update_tab_width)
2299         (tui_source_window_base::update_exec_info): Update.
2300         * tui/tui-data.h (struct curses_deleter): New.
2301         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2302         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2303
2304 2019-10-09  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2307
2308 2019-10-09  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2311         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2312
2313 2019-10-09  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2316         window height directly.
2317         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2318         declare.
2319         * tui/tui-layout.c (tui_default_win_height): Remove.
2320         (tui_default_win_viewport_height): Remove.
2321
2322 2019-10-09  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui.h: Remove comments.
2325
2326 2019-10-09  Tom de Vries  <tdevries@suse.de>
2327
2328         * python/lib/gdb/printer/bound_registers.py: Use
2329         '^builtin_type_bound128' as regexp argument for
2330         add_builtin_pretty_printer.
2331
2332 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2333
2334         * guile/guile.c (guile_extension_script_ops): Remove forward
2335         declaration and mark as static.
2336         (guile_script_ops): Likewise.
2337         (extension_language_guile): Move further down in the file so
2338         it can reference the definitions for guile_{extension_,}script_ops.
2339
2340 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2341
2342         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2343         except SORTL, DFLTCC, and KDSA.
2344
2345 2019-10-08  Tom Tromey  <tromey@adacore.com>
2346
2347         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2348         (struct safe_symbol_file_add_args): Remove.
2349
2350 2019-10-08  Tom Tromey  <tromey@adacore.com>
2351
2352         * windows-nat.c: Don't include buildsym-legacy.h.
2353
2354 2019-10-08  Tom Tromey  <tromey@adacore.com>
2355
2356         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2357
2358 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2359
2360         * gdbtypes.c (overload_debug): Move comment to header.
2361         * gdbtypes.h (overload_debug): Declare.
2362         * valops.c: Remove declaration of overload_debug, instead
2363         include gdbtypes.h.
2364
2365 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2366
2367         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2368         through _().
2369         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2370         move comment...
2371         * language.h (lang_frame_mismatch_warn): ... here. Also add
2372         declaration.
2373         * top.c (lang_frame_mismatch_warn): Remove declaration.
2374         (check_frame_language_change): Pass lang_frame_mismatch_warn
2375         through _().
2376
2377 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * c-lang.h (vtbl_ptr_name): Declare.
2380         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2381         it from the header.
2382         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2383
2384 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2385
2386         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2387         gdb_static_assert.
2388
2389 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2390
2391         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2392         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2393         * ctfread.c: New file.
2394         * ctfread.h: New file.
2395         * elfread.c: Include ctfread.h.
2396         (struct elfinfo text_p): New member ctfsect.
2397         (elf_locate_sections): Mark CTF section.
2398         (elf_symfile_read): Call elfctf_build_psymtabs.
2399         * Makefile.in (LIBCTF): Add.
2400         (CLIBS): Use it.
2401         (CDEPS): Likewise.
2402         (DIST): Add ctfread.c.
2403
2404 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * ctfread.c (struct nextfield): Renamed to ...
2407         (struct ctf_nextfield): ... this.
2408         (struct field_info): Renamed to ...
2409         (strut ctf_field_info): ... this.
2410         (attach_fields_to_type): Update for renamed structures.
2411         (ctf_add_member_cb): Likewise.
2412         (ctf_add_enum_member_cb): Likewise.
2413         (process_struct_members): Likewise.
2414         (process_enum_type): Likewise.
2415
2416 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2417
2418         * tracectf.h: Rename, was ctf.h.
2419         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2420         * tracefile.c: Likewise.
2421         * tracepoint.c: Remove unused include ctf.h.
2422         * mi/mi-main.c: Likewise.
2423         * Makefile.in Replace ctf.c with tracectf.c.
2424
2425 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2426
2427         * version.in: Change version number to "9.0.50.DATE-git".
2428
2429 2019-10-03  Tom Tromey  <tom@tromey.com>
2430
2431         PR rust/24976:
2432         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2433
2434 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2437         cp_search_name_hash.
2438         * NEWS: Add entry about nested function support.
2439
2440 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2441             Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2444         for nested static variables when searchin VAR_DOMAIN.
2445         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2446         global scope, update comment.
2447         (add_partial_subprogram): Call add_partial_subprogram recursively
2448         for nested subroutines when processinng Fortran.
2449         (load_partial_dies): Process the child entities of a subprogram
2450         when processing Fortran.
2451         (partial_die_parent_scope): Handle building scope
2452         for Fortran nested functions.
2453         (process_die): Record that nested functions have a scope.
2454         (new_symbol): Always record Fortran subprograms on the global
2455         symbol list.
2456         (determine_prefix): How to build the prefix for Fortran
2457         subprograms.
2458
2459 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2462         have just sent the thread a SIGSTOP and are waiting for it to
2463         arrive.
2464
2465 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * btrace.c (btrace_add_pc): Remove whitespace before the template
2468         parameter in 'std::vector <...>'.
2469         (parse_xml_btrace_block): Likewise.
2470         (btrace_maint_decode_pt): Likewise.
2471         (btrace_maint_update_packets): Likewise.
2472         (btrace_maint_print_packets): Likewise.
2473         * btrace.h (struct btrace_maint_info): Likewise.
2474         * dwarf2read.c (struct type_unit_group): Likewise.
2475         (build_type_psymtabs_reader): Likewise.
2476         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2477         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2478         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2479
2480 2019-10-03  Tom de Vries  <tdevries@suse.de>
2481
2482         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2483         the first line of the help text for set/show style metadata.
2484
2485 2019-10-02  Tom Tromey  <tromey@adacore.com>
2486
2487         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2488         * gdbsupport/common-inferior.c: New file.
2489         * infcmd.c (startup_with_shell): Don't define.
2490         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2491         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2492         * inferior.h (startup_with_shell): Don't declare.
2493
2494 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2495
2496         * gdbsupport/gdb_assert.h: Include errors.h.
2497         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2498
2499 2019-10-02  Tom Tromey  <tromey@adacore.com>
2500
2501         * NEWS: Add $_ada_exception entry.
2502         * ada-lang.c (struct ada_catchpoint): Add constructor.
2503         <m_kind>: New member.
2504         (allocate_location_exception, re_set_exception): Remove
2505         "ex" parameter.
2506         (should_stop_exception): Compute $_ada_exception.
2507         (check_status_exception, print_it_exception)
2508         (print_one_exception, print_mention_exception): Remove
2509         "ex" parameter.
2510         (allocate_location_catch_exception, re_set_catch_exception)
2511         (check_status_exception, print_it_catch_exception)
2512         (print_one_catch_exception, print_mention_catch_exception)
2513         (print_recreate_catch_exception)
2514         (allocate_location_catch_exception_unhandled)
2515         (re_set_catch_exception_unhandled)
2516         (check_status_exception, print_it_catch_exception_unhandled)
2517         (print_one_catch_exception_unhandled)
2518         (print_mention_catch_exception_unhandled)
2519         (print_recreate_catch_exception_unhandled)
2520         (allocate_location_catch_assert, re_set_catch_assert)
2521         (check_status_assert, print_it_catch_assert)
2522         (print_one_catch_assert, print_mention_catch_assert)
2523         (print_recreate_catch_assert)
2524         (allocate_location_catch_handlers, re_set_catch_handlers)
2525         (check_status_handlers, print_it_catch_handlers)
2526         (print_one_catch_handlers, print_mention_catch_handlers)
2527         (print_recreate_catch_handlers): Remove.
2528         (create_ada_exception_catchpoint): Update.
2529         (initialize_ada_catchpoint_ops): Update.
2530
2531 2019-10-02  Tom Tromey  <tromey@adacore.com>
2532
2533         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2534         (create_excep_cond_exprs): Simplify exception string computation.
2535         (ada_exception_catchpoint_cond_string): Likewise.
2536
2537 2019-10-02  Tom Tromey  <tromey@adacore.com>
2538
2539         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2540         * ada-lang.c (lesseq_defined_than): Handle
2541         LOC_STATIC.
2542         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2543         parameter.
2544         (dwarf2_has_info): Likewise.
2545         (new_symbol): Set maybe_copied on symbol when
2546         appropriate.
2547         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2548         parameter.
2549         <can_copy>: New member.
2550         * elfread.c (record_minimal_symbol): Set maybe_copied
2551         on symbol when appropriate.
2552         (elf_symfile_read): Update call to dwarf2_has_info.
2553         * minsyms.c (lookup_minimal_symbol_linkage): New
2554         function.
2555         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2556         * symtab.c (get_symbol_address, get_msymbol_address):
2557         New functions.
2558         * symtab.h (get_symbol_address, get_msymbol_address):
2559         Declare.
2560         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2561         maybe_copied.
2562         (struct symbol, struct minimal_symbol) <maybe_copied>:
2563         New member.
2564
2565 2019-10-02  Tom Tromey  <tromey@adacore.com>
2566
2567         * source.c (struct current_source_location): New.
2568         (current_source_key): New global.
2569         (current_source_symtab, current_source_line)
2570         (current_source_pspace): Remove.
2571         (get_source_location): New function.
2572         (get_current_source_symtab_and_line)
2573         (set_default_source_symtab_and_line)
2574         (set_current_source_symtab_and_line)
2575         (clear_current_source_symtab_and_line, select_source_symtab)
2576         (info_source_command, print_source_lines_base)
2577         (info_line_command, search_command_helper, _initialize_source):
2578         Update.
2579
2580 2019-10-02  Tom Tromey  <tromey@adacore.com>
2581
2582         * source.c (select_source_symtab): Don't call
2583         decode_line_with_current_source.
2584
2585 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * symtab.c (lookup_global_symbol): Search global block.
2588
2589 2019-10-02  Tom Tromey  <tromey@adacore.com>
2590
2591         * coffread.c (process_coff_symbol): Update.
2592         * dwarf2read.c (var_decode_location, new_symbol): Update.
2593         * mdebugread.c (parse_symbol): Update.
2594         * objfiles.c (relocate_one_symbol): Update.
2595         * stabsread.c (define_symbol, fix_common_block)
2596         (scan_file_globals): Update.
2597         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2598         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2599         * xcoffread.c (process_xcoff_symbol): Update.
2600
2601 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2602
2603         * MAINTAINERS: Update my email address.
2604
2605 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2608         std::vector.
2609         (build_type_psymtabs_reader): Update for std::vector.
2610         (build_type_psymtab_dependencies): Likewise.
2611         * dwarf2read.h: Remove use of DEF_VEC_P.
2612         (typedef sig_type_ptr): Delete.
2613
2614 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2617         to std::vector.
2618         (btrace_maint_decode_pt): Likewise, and move allocation of the
2619         vector outside of the loop.
2620         (btrace_maint_update_packets): Update to handle change from VEC to
2621         std::vector.
2622         (btrace_maint_print_packets): Likewise.
2623         (maint_info_btrace_cmd): Likewise.
2624         * btrace.h: Remove use of DEF_VEC_O.
2625         (typedef btrace_pt_packet_s): Delete.
2626         (struct btrace_maint_info) <packets>: Change fromm VEC to
2627         std::vector.
2628         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2629
2630 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2633         make accesses into the vector constant references.
2634         (btrace_add_pc): Update for std::vector.
2635         (btrace_stitch_bts): Likewise.
2636         (parse_xml_btrace_block): Likewise.
2637         (btrace_maint_update_packets): Likewise.
2638         (btrace_maint_print_packets): Likewise.
2639         (maint_info_btrace_cmd): Likewise.
2640         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2641         std::vector.
2642         (btrace_data::empty): Likewise.
2643         (btrace_data_append): Likewise.
2644         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2645         (typedef btrace_block_s): Delete.
2646         (struct btrace_block): Add constructor.
2647         (struct btrace_data_bts) <blocks>: Change to std::vector.
2648         * nat/linux-btrace.c (perf_event_read_bts): Update for
2649         std::vector.
2650         (linux_read_bts): Likewise.
2651
2652 2019-10-01  Tom Tromey  <tom@tromey.com>
2653
2654         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2655
2656 2019-10-01  Tom Tromey  <tom@tromey.com>
2657
2658         * stack.c (print_frame, info_frame_command_core): Use
2659         styled_string.
2660         * linux-thread-db.c (try_thread_db_load_1)
2661         (try_thread_db_load_from_pdir_1): Use styled_string.
2662         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2663         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2664         (maybe_print_unsupported_script_warning)
2665         (maybe_print_script_not_found_warning): Use styled_string.
2666         * ada-lang.c (user_select_syms): Use styled_string.
2667
2668 2019-10-01  Tom Tromey  <tom@tromey.com>
2669
2670         * p-lang.c (pascal_printstr): Use metadata style.
2671         * value.c (show_convenience): Use metadata style.
2672         * valprint.c (valprint_check_validity, val_print_optimized_out)
2673         (val_print_not_saved, val_print_unavailable)
2674         (val_print_invalid_address, generic_val_print, val_print)
2675         (value_check_printable, val_print_array_elements): Use metadata
2676         style.
2677         * ui-out.h (class ui_out) <field_fmt>: New overload.
2678         <do_field_fmt>: Add style parameter.
2679         * ui-out.c (ui_out::field_fmt): New overload.
2680         * typeprint.c (type_print_unknown_return_type)
2681         (val_print_not_allocated, val_print_not_associated): Use metadata
2682         style.
2683         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2684         parameter.
2685         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2686         * tracepoint.c (tvariables_info_1): Use metadata style.
2687         * stack.c (print_frame_arg, print_frame_info, print_frame)
2688         (info_frame_command_core): Use metadata style.
2689         * skip.c (info_skip_command): Use metadata style.
2690         * rust-lang.c (rust_print_enum): Use metadata style.
2691         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2692         metadata style.
2693         * python/py-framefilter.c (py_print_single_arg): Use metadata
2694         style.
2695         * printcmd.c (do_one_display, print_variable_and_value): Use
2696         metadata style.
2697         * p-valprint.c (pascal_val_print)
2698         (pascal_object_print_value_fields): Use metadata style.
2699         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2700         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2701         parameter.
2702         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2703         * m2-valprint.c (m2_print_long_set): Use metadata style.
2704         * m2-typeprint.c (m2_print_type): Use metadata style.
2705         * infcmd.c (print_return_value_1): Use metadata style.
2706         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2707         * f-valprint.c (info_common_command_for_block): Use metadata
2708         style.
2709         * f-typeprint.c (f_type_print_base): Use metadata style.
2710         * expprint.c (print_subexp_standard): Use metadata style.
2711         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2712         * cli/cli-style.h (class cli_style_option): Add constructor.
2713         (metadata_style): Declare.
2714         * cli/cli-style.c (metadata_style): New global.
2715         (_initialize_cli_style): Register metadata style.
2716         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2717         parameter.
2718         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2719         * c-typeprint.c (c_type_print_base_struct_union)
2720         (c_type_print_base_1): Use metadata style.
2721         * breakpoint.c (watchpoint_value_print)
2722         (print_one_breakpoint_location): Use metadata style.
2723         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2724         style.
2725         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2726         style.
2727         * ada-valprint.c (val_print_packed_array_elements, printstr)
2728         (print_field_values, ada_val_print_ref, ada_val_print): Use
2729         metadata style.
2730         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2731         style.
2732         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2733         style.
2734         * ada-lang.c (user_select_syms): Use metadata style.
2735
2736 2019-10-01  Tom Tromey  <tom@tromey.com>
2737
2738         * cli/cli-cmds.c (pwd_command): Style output.
2739
2740 2019-10-01  Pedro Alves  <palves@redhat.com>
2741             Tom Tromey  <tom@tromey.com>
2742
2743         * symtab.c (print_symbol_info): Use %ps.
2744         (print_msymbol_info): Use %ps.
2745         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2746         * printcmd.c (print_variable_and_value): Use %ps.
2747         * macrocmd.c (show_pp_source_pos): Use %ps.
2748         * infrun.c (print_exited_reason): Use ui_out::message.
2749         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2750         (describe_other_breakpoints): Use ui_out::message and new
2751         formats.
2752         (say_where): Use new formats.
2753         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2754         and new formats.
2755
2756 2019-10-01  Pedro Alves  <palves@redhat.com>
2757             Tom Tromey  <tom@tromey.com>
2758
2759         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2760         (test_gdb_formats): New function.
2761         (run_tests): Call it.
2762         (test_format_specifier): Update.
2763         * utils.h (fputs_filtered): Update comment.
2764         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2765         (fputs_styled_unfiltered): Declare.
2766         * utils.c (fputs_styled_unfiltered): New function.
2767         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2768         (vfprintf_filtered): Update.
2769         (vfprintf_unfiltered, vprintf_filtered): Update.
2770         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2771         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2772         disallow_ui_out_field>: New constants.
2773         (enum class field_kind): New.
2774         (struct base_field_s, struct signed_field_s): New.
2775         (signed_field): New function.
2776         (struct string_field_s): New.
2777         (string_field): New function.
2778         (struct styled_string_s): New.
2779         (styled_string): New function.
2780         (class ui_out) <message>: Add comment.
2781         <vmessage, call_do_message>: New methods.
2782         <do_message>: Add style parameter.
2783         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2784         methods.
2785         (ui_out::message): Rewrite.
2786         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2787         parameter.
2788         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2789         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2790         gdb_extensions parameter.
2791         (class format_piece): Add parameter to constructor.
2792         (n_int_args): New field.
2793         * gdbsupport/format.c (format_pieces::format_pieces): Add
2794         gdb_extensions parameter.  Handle '*'.
2795         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2796         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2797         vfprintf_styled_no_gdbfmt.
2798         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2799         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2800         unfiltered output.
2801         * ui-style.h (struct ui_file_style) <ptr>: New method.
2802
2803 2019-10-01  Tom Tromey  <tom@tromey.com>
2804
2805         * unittests/format_pieces-selftests.c: Update.  Add final format.
2806         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2807         empty literal pieces.
2808
2809 2019-10-01  Tom Tromey  <tom@tromey.com>
2810
2811         * ui-out.h (enum class ui_out_style_kind): Remove.
2812         (class ui_out) <field_string, field_stsream, do_field_string>:
2813         Change type of "style".
2814         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2815         (ui_out::field_string): Update.
2816         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2817         of "style".
2818         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2819         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2820         * stack.c (print_frame_arg, print_frame_info, print_frame):
2821         Update.
2822         * source.c (print_source_lines_base): Update.
2823         * solib.c (info_sharedlibrary_command): Update.
2824         * skip.c (info_skip_command): Update.
2825         * record-btrace.c (btrace_call_history_src_line)
2826         (btrace_call_history): Update.
2827         * python/py-framefilter.c (py_print_frame): Update.
2828         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2829         "style".
2830         * mi/mi-out.c (mi_ui_out::do_table_header)
2831         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2832         (mi_ui_out::do_field_string): Update.
2833         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2834         Update.
2835         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2836         "style".
2837         * cli-out.c (cli_ui_out::do_table_header)
2838         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2839         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2840         (cli_ui_out::do_field_fmt): Update.
2841         * breakpoint.c (print_breakpoint_location): Update.
2842         (update_static_tracepoint): Update.
2843
2844 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2845
2846         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2847         conversion of gdb_datadir.
2848         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2849         remove not needed c_str ().
2850
2851 2019-09-30  Ali Tamur <tamur@google.com>
2852
2853         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2854         (dwarf2_string_attr): Likewise.
2855
2856 2019-09-30  Ali Tamur <tamur@google.com>
2857
2858         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2859         (process_full_type_unit): Likewise.
2860         (dump_die_shallow): Likewise.
2861         (cu_debug_loc_section): Likewise.
2862
2863 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2864
2865         * minsyms.c (compare_minimal_symbols): Rename to...
2866         (minimal_symbol_is_less_than): ...this, and adjust to STL
2867         conventions (return bool, take arguments as references)
2868         (minimal_symbol_reader::install): Call std::sort instead
2869         of qsort.
2870
2871 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2872
2873         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2874         hash and why.
2875         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2876         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2877
2878 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2879
2880         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2881         * psympriv.h (add_psymbol_to_list): Move comment here and update
2882         it.
2883
2884 2019-09-29  Tom de Vries  <tdevries@suse.de>
2885
2886         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2887         Use $tmpdir/$(basename "$output_file").dwz instead of
2888         "${output_file}.dwz".
2889
2890 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2891
2892         PR gdb/25045
2893         * hppa-linux-nat.c: Include gdbarch.h.
2894
2895 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2896
2897         * blockframe.c (find_pc_partial_function): Change return type to bool.
2898         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2899         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2900         (stub_gnu_ifunc_resolve_name): Likewise.
2901         * symtab.c (compare_filenames_for_search): Likewise.
2902         (compare_glob_filenames_for_search): Likewise.
2903         (matching_obj_sections): Likewise.
2904         (symbol_matches_domain): Likewise.
2905         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2906         (find_line_pc): Change return type to bool.
2907         (find_line_pc_range): Likewise.
2908         (producer_is_realview): Likewise.
2909         * symtab.h (symbol_matches_domain): Likewise.
2910         (find_pc_partial_function): Likewise.
2911         (find_pc_line_pc_range): Likewise.
2912         (in_gnu_ifunc_stub): Likewise.
2913         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2914         (find_line_pc): Likewise.
2915         (find_line_pc_range): Likewise.
2916         (matching_obj_sections): Likewise.
2917         (find_line_symtab): Change out parameter to bool.
2918         (producer_is_realview): Change return type to bool.
2919         (compare_filenames_for_search): Likewise.
2920         (compare_glob_filenames_for_search): Likewise.
2921
2922 2019-09-26  Tom Tromey  <tom@tromey.com>
2923
2924         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2925         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2926         * gdb_usleep.h: Remove.
2927         * gdb_usleep.c: Remove.
2928         * utils.c: Don't include gdb_usleep.h.
2929
2930 2019-09-26  Tom Tromey  <tromey@adacore.com>
2931
2932         * python/py-type.c (type_to_type_object): Call check_typedef
2933         for stub types.
2934
2935 2019-09-26  Tom Tromey  <tom@tromey.com>
2936
2937         * utils.h (initialize_utils): Don't declare.
2938         * top.c (gdb_init): Don't call initialize_utils.
2939         * utils.c (initialize_utils): Remove.  Move contents...
2940         (_initialize_utils): ... here.
2941
2942 2019-09-25  Tom Tromey  <tom@tromey.com>
2943
2944         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2945         * utils.h (make_hex_string): Don't declare.
2946         * utils.c (make_hex_string): Remove.
2947
2948 2019-09-24  Tom de Vries  <tdevries@suse.de>
2949
2950         PR gdb/23815
2951         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2952         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2953
2954 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2955
2956         * NEWS: Mention new simulator port for PRU.
2957
2958 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2959
2960         * ada-exp.y (write_object_remaining): Update.
2961         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2962         and eliminate the static buffer.
2963         (ada_decode_symbol): Update.
2964         (ada_la_decode): Update.
2965         (ada_sniff_from_mangled_name): Update.
2966         (is_valid_name_for_wild_match): Update.
2967         (ada_lookup_name_info::matches): Update and simplify.
2968         (name_matches_regex): Update.
2969         (ada_add_global_exceptions): Update.
2970         * ada-lang.h (ada_decode): Update signature.
2971         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2972         * dwarf-index-write.c (debug_names::insert): Update.
2973
2974 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2975
2976         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2977         formatting.
2978
2979 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2980
2981         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2982         Change "nonzero" to "true" in documentation.
2983
2984 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2985
2986         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2987         (_initialize_darwin_solib): Don't set
2988         darwin_so_ops.lookup_lib_global_symbol.
2989         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2990         set_gdbarch_iterate_over_objfiles_in_search_order.
2991         (elf_lookup_lib_symbol): Rename to...
2992         (svr4_iterate_over_objfiles_in_search_order): this, and update
2993         to iterate semantics.
2994         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2995         * solib.c (solib_global_lookup): Remove.
2996         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2997         (solib_global_lookup): Remove.
2998         * symtab.c (lookup_global_or_static_symbol): Remove call to
2999         solib_global_lookup.
3000
3001 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3002
3003         * NEWS: Move entries about default MI version now being
3004         version 3, and about the GDB/MI fix for multi-location
3005         breakpoints to the "since GDB 8.3" section.
3006
3007 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3008
3009         GDB 8.3.1 released.
3010
3011 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3012
3013         * NEWS: Mention that Cell/B.E. debugging support was removed.
3014         * MAINTAINERS: Remove spu target.
3015
3016         * config/djgpp/fnchange.lst: Remove entries for removed files.
3017
3018         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3019         spu-multiarch.o, and spu-tdep.o.
3020         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3021         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3022         spu-multiarch.c, and spu-tdep.c.
3023         * spu-linux-nat.c: Remove file.
3024         * spu-multiarch.c: Remove file.
3025         * spu-tdep.c: Remove file.
3026         * spu-tdep.h: Remove file.
3027         * solib-spu.c: Remove file.
3028         * solib-spu.h: Remove file.
3029
3030         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3031         * configure.nat (spu-linux): Remove.
3032         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3033         solib-multiarch.o from gdb_target_obs.
3034         (spu*-*-*): Remove.
3035
3036         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3037         feature flag.
3038         (ppc_linux_no_features): Update.
3039         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3040         Cell/B.E. support.
3041         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3042         (tdesc_powerpc_cell64l): Likewise.
3043         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3044         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3045         Cell/B.E. support.
3046         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3047         Do not include "features/rs6000/powerpc-cell32l.c" or
3048         "features/rs6000/powerpc-cell64l.c".
3049         (ppc_linux_spu_section): Remove.
3050         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3051         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3052         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3053         (ppc_linux_spe_context_lookup): Remove.
3054         (ppc_linux_spe_context_inferior_created): Remove.
3055         (ppc_linux_spe_context_solib_loaded): Remove.
3056         (ppc_linux_spe_context_solib_unloaded): Remove.
3057         (ppc_linux_spe_context): Remove.
3058         (struct ppu2spu_cache): Remove.
3059         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3060         (struct ppu2spu_data): Remove.
3061         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3062         ppu2spu_unwind): Remove.
3063         (ppc_linux_init_abi): Remove Cell/B.E. support.
3064         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3065
3066         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3067         (rs6000/powerpc-cell64l-expedite): Likewise
3068         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3069         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3070         rs6000/powerpc-cell64l.xml.
3071         * features/rs6000/powerpc-cell32l.xml: Remove.
3072         * features/rs6000/powerpc-cell64l.xml: Likewise.
3073         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3074         * features/rs6000/powerpc-cell64l.c: Likewise.
3075         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3076         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3077         * regformats/reg-spu.dat: Remove.
3078
3079         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3080         * corelow.c (struct spuid_list): Remove.
3081         (add_to_spuid_list): Remove.
3082         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3083         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3084         (remote_protocol_features): Remove associated entries.
3085         (_initialize_remote): No longer initialize them.
3086         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3087         * linux-nat.c (SPUFS_MAGIC): Remove.
3088         (linux_proc_xfer_spu): Remove.
3089         (spu_enumerate_spu_ids): Remove.
3090         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3091         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3092         (linux_make_corefile_notes): No longer call it.
3093
3094         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3095         (cooked_write_test): Likewise.
3096
3097 2019-09-20  Tom Tromey  <tom@tromey.com>
3098
3099         * NEWS: Mention case-sensitivity of TUI commands.
3100         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3101         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3102         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3103
3104 2019-09-20  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-source.c (tui_source_window::set_contents): Use
3107         make_unique_xstrdup.
3108         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3109         make_unique_xstrdup.
3110
3111 2019-09-20  Tom Tromey  <tom@tromey.com>
3112
3113         * tui/tui-data.c: Remove separator comments.
3114         * tui/tui-layout.c: Remove separator comments.
3115         * tui/tui-win.c: Remove separator comments.
3116         * tui/tui-wingeneral.c: Remove separator comments.
3117
3118 2019-09-20  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui.h (strcat_to_buf): Don't declare.
3121         * tui/tui.c (strcat_to_buf): Remove.
3122
3123 2019-09-20  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3126         from "fullname".
3127         * tui/tui-source.c (tui_source_window::set_contents)
3128         (tui_source_window::location_matches_p)
3129         (tui_source_window::maybe_update): Update.
3130
3131 2019-09-20  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3134         Update.
3135         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3136         prefix.
3137         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3138         (tui_data_window::line_from_reg_element_no)
3139         (tui_data_window::first_reg_element_no_inline)
3140         (tui_data_window::show_registers)
3141         (tui_data_window::show_register_group)
3142         (tui_data_window::display_registers_from)
3143         (tui_data_window::display_registers_from_line)
3144         (tui_data_window::first_data_item_displayed)
3145         (tui_data_window::delete_data_content_windows)
3146         (tui_data_window::erase_data_content)
3147         (tui_data_window::do_scroll_vertical)
3148         (tui_data_window::refresh_window)
3149         (tui_data_window::check_register_values): Update.
3150
3151 2019-09-20  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3154         (struct tui_locator_window) <full_name, proc_name>: Now
3155         std::string.
3156         * tui/tui-stack.c (tui_locator_window::make_status_line)
3157         (tui_locator_window::set_locator_fullname)
3158         (tui_locator_window::set_locator_info): Update.
3159         * tui/tui-source.c (tui_source_window::set_contents)
3160         (tui_source_window::showing_source_p): Update.
3161
3162 2019-09-20  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3165         Don't call tui_locator_win_info_ptr.
3166
3167 2019-09-20  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3170
3171 2019-09-20  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3174         height for locator.
3175         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3176         * tui/tui-layout.c (show_source_disasm_command, show_data)
3177         (show_source_or_disasm_and_command): Use 1 as height for locator.
3178
3179 2019-09-20  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui.c (tui_enable): Update.
3182         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3183         Update.
3184         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3185         Update.
3186         * tui/tui-data.c (win_resized): Now bool.
3187         (tui_win_resized): Return bool.
3188         (tui_set_win_resized_to): Accept a bool.
3189
3190 2019-09-20  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3193         Change type of "refresh_values_only".
3194         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3195         type of "refresh_values_only".
3196
3197 2019-09-20  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3200         std::string.
3201         (tui_disassemble): Add "pos" parameter.
3202         (tui_disasm_window::set_contents): Simplify.
3203
3204 2019-09-20  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-winsource.h (struct tui_source_window_base)
3207         <show_source_content>: Now private.
3208         * tui/tui-winsource.c
3209         (tui_source_window_base::show_source_content): Don't handle empty
3210         content case.
3211
3212 2019-09-20  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-layout.c (show_source_disasm_command)
3215         (show_source_or_disasm_and_command): Don't call
3216         show_source_content.
3217
3218 2019-09-20  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3221         Declare.
3222         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3223         from tui_make_status_line.
3224         (tui_locator_window::rerender): Update.
3225
3226 2019-09-20  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3229         (tui_locator_window::rerender): Update.
3230
3231 2019-09-20  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.h (struct tui_source_window_base)
3234         <~tui_source_window_base>: Don't declare.
3235         <fullname>: Remove.
3236         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3237         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3238         member.
3239         * tui/tui-source.c (tui_source_window::set_contents): Update.
3240         (tui_source_window::location_matches_p)
3241         (tui_source_window::maybe_update): Update.
3242
3243 2019-09-20  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-winsource.h (~tui_source_element): Remove.
3246         (tui_source_element): Update.
3247         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3248         * tui/tui-winsource.c (tui_show_source_line): Update.
3249         * tui/tui-source.c (tui_source_window::set_contents): Update.
3250         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3251
3252 2019-09-20  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3255         declare.
3256         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3257         tui_clear_source_windows_detail.
3258         * tui/tui-winsource.h (struct tui_source_window_base)
3259         <clear_detail>: Don't declare.
3260         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3261         Remove.
3262         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3263
3264 2019-09-20  Tom Tromey  <tromey@adacore.com>
3265
3266         PR ada/24919:
3267         * block.c (contained_in): Fix final return value.
3268
3269 2019-09-20  Alan Modra  <amodra@gmail.com>
3270
3271         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3272         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3273         (read_indirect_string_from_dwz): Use bfd accessor.
3274         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3275         * machoread.c (macho_symfile_read_all_oso): Likewise.
3276         * solib.c (solib_bfd_open): Likewise.
3277
3278 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3279
3280         * eval.c: Move declaration of overload_resolution to...
3281         * value.h: ...here.
3282
3283 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3284
3285         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3286         * arm-linux-tdep.c: Likewise.
3287         * arm-nbsd-nat.c: Likewise.
3288         * arm-tdep.h: Declare arm_apcs_32.
3289         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3290
3291 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3292
3293         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3294         * dwarf2read.h: Declare dwarf_always_disassemble.
3295
3296 2019-09-19  Tom de Vries  <tdevries@suse.de>
3297
3298         PR gdb/25009
3299         * source-cache.c (source_cache::ensure): Catch exception thrown during
3300         construction of the highlighter.
3301
3302 2019-09-18  Alan Modra  <amodra@gmail.com>
3303
3304         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3305         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3306         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3307         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3308         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3309         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3310         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3311         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3312         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3313         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3314         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3315         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3316         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3317         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3318         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3319         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3320         * mi/mi-interp.c: Update throughout for bfd section macro and
3321         function changes.
3322         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3323         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3324
3325 2019-09-18  Tom Tromey  <tom@tromey.com>
3326
3327         * NEWS: Add entry.
3328         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3329         call rl_initialize.
3330         (tui_enable): Do not call rl_initialize.
3331
3332 2019-09-18  Christian Groessler  <chris@groessler.org>
3333
3334         * alpha-linux-nat.c: Include gdbarch.h.
3335
3336 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3337
3338         * ui-file.c: Include cli/cli-style.h.
3339         (term_cli_styling): Remove cli_styling declaration.
3340
3341 2019-09-18  Alan Modra  <amodra@gmail.com>
3342
3343         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3344         to bfd_asymbol_section.
3345
3346 2019-09-18  Alan Modra  <amodra@gmail.com>
3347
3348         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3349         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3350         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3351
3352 2019-09-18  Alan Modra  <amodra@gmail.com>
3353
3354         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3355         * spu-linux-nat.c (spu_bfd_open): Likewise.
3356
3357 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3358
3359         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3360         to bool to match definition in dwarf2read.c.
3361
3362 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3363
3364         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3365         (print_signatures): Likewise.
3366         (trust_pad_over_xvs): Likewise.
3367         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3368         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3369         * arm-linux-nat.c (arm_apcs_32): Likewise.
3370         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3371         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3372         * arm-tdep.c (arm_debug): Likewise.
3373         (arm_apcs_32): Likewise.
3374         * auto-load.c (debug_auto_load): Likewise.
3375         (auto_load_gdb_scripts): Likewise.
3376         (global_auto_load): Likewise.
3377         (auto_load_local_gdbinit): Likewise.
3378         (auto_load_local_gdbinit_loaded): Likewise.
3379         * auto-load.h (global_auto_load): Likewise.
3380         (auto_load_local_gdbinit): Likewise.
3381         (auto_load_local_gdbinit_loaded): Likewise.
3382         * breakpoint.c (disconnected_dprintf): Likewise.
3383         (breakpoint_proceeded): Likewise.
3384         (automatic_hardware_breakpoints): Likewise.
3385         (always_inserted_mode): Likewise.
3386         (target_exact_watchpoints): Likewise.
3387         (_initialize_breakpoint): Update.
3388         * breakpoint.h (target_exact_watchpoints): Change to bool.
3389         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3390         * cli/cli-cmds.c (trace_commands): Likewise.
3391         * cli/cli-cmds.h (trace_commands): Likewise.
3392         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3393         to bool*.
3394         * cli/cli-logging.c (logging_overwrite): Change to bool.
3395         (logging_redirect): Likewise.
3396         (debug_redirect): Likewise.
3397         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3398         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3399         to bool.
3400         <boolean_option_def>: Update.
3401         (struct flag_option_def): Change default type of Context to bool
3402         from int.
3403         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3404         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3405         (get_setshow_command_value_string): Likewise.
3406         * cli/cli-style.c (cli_styling): Change to bool.
3407         (source_styling): Likewise.
3408         * cli/cli-style.h (source_styling): Likewise.
3409         (cli_styling): Likewise.
3410         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3411         to bool.
3412         * command.h (var_types): Update comment.
3413         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3414         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3415         bool.
3416         (debug_compile_cplus_scopes): Likewise.
3417         * compile/compile-internal.h (compile_debug): Likewise.
3418         * compile/compile.c (compile_debug): Likewise.
3419         (struct compile_options) <raw>: Likewise.
3420         * cp-support.c (catch_demangler_crashes): Likewise.
3421         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3422         (usr_cmd_cris_dwarf2_cfi): Likewise.
3423         * csky-tdep.c (csky_debug): Likewise.
3424         * darwin-nat.c (enable_mach_exceptions): Likewise.
3425         * dcache.c (dcache_enabled_p): Likewise.
3426         * defs.h (info_verbose): Likewise.
3427         * demangle.c (demangle): Likewise.
3428         (asm_demangle): Likewise.
3429         * dwarf-index-cache.c (debug_index_cache): Likewise.
3430         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3431         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3432         * dwarf2read.c (check_physname): Likewise.
3433         (use_deprecated_index_sections): Likewise.
3434         (dwarf_always_disassemble): Likewise.
3435         * eval.c (overload_resolution): Likewise.
3436         * event-top.c (set_editing_cmd_var): Likewise.
3437         (exec_done_display_p): Likewise.
3438         * event-top.h (set_editing_cmd_var): Likewise.
3439         (exec_done_display_p): Likewise.
3440         * exec.c (write_files): Likewise.
3441         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3442         (debug_fbsd_nat): Likewise.
3443         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3444         Likewise.
3445         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3446         <backtrace_past_entry> Likewise.
3447         * gdb-demangle.h (demangle): Likewise.
3448         (asm_demangle): Likewise.
3449         * gdb_bfd.c (bfd_sharing): Likewise.
3450         * gdbcore.h (write_files): Likewise.
3451         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3452         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3453         * gdbthread.h (print_thread_events): Likewise.
3454         * gdbtypes.c (opaque_type_resolution): Likewise.
3455         (strict_type_checking): Likewise.
3456         * gnu-nat.c (gnu_debug_flag): Likewise.
3457         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3458         * guile/scm-param.c (pascm_variable): Add boolval.
3459         (add_setshow_generic): Update.
3460         (pascm_param_value): Update.
3461         (pascm_set_param_value_x): Update.
3462         * hppa-tdep.c (hppa_debug): Change to bool..
3463         * infcall.c (may_call_functions_p): Likewise.
3464         (coerce_float_to_double_p): Likewise.
3465         (unwind_on_signal_p): Likewise.
3466         (unwind_on_terminating_exception_p): Likewise.
3467         * infcmd.c (startup_with_shell): Likewise.
3468         * inferior.c (print_inferior_events): Likewise.
3469         * inferior.h (startup_with_shell): Likewise.
3470         (print_inferior_events): Likewise.
3471         * infrun.c (step_stop_if_no_debug): Likewise.
3472         (detach_fork): Likewise.
3473         (debug_displaced): Likewise.
3474         (disable_randomization): Likewise.
3475         (non_stop): Likewise.
3476         (non_stop_1): Likewise.
3477         (observer_mode): Likewise.
3478         (observer_mode_1): Likewise.
3479         (set_observer_mode): Update.
3480         (sched_multi): Change to bool.
3481         * infrun.h (debug_displaced): Likewise.
3482         (sched_multi): Likewise.
3483         (step_stop_if_no_debug): Likewise.
3484         (non_stop): Likewise.
3485         (disable_randomization): Likewise.
3486         * linux-tdep.c (use_coredump_filter): Likewise.
3487         (dump_excluded_mappings): Likewise.
3488         * linux-thread-db.c (auto_load_thread_db): Likewise.
3489         (check_thread_db_on_load): Likewise.
3490         * main.c (captured_main_1): Update.
3491         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3492         xx2_opt, boolean_opt>: Change to bool.
3493         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3494         * maint.c (maintenance_profile_p): Likewise.
3495         (per_command_time): Likewise.
3496         (per_command_space): Likewise.
3497         (per_command_symtab): Likewise.
3498         * memattr.c (inaccessible_by_default): Likewise.
3499         * mi/mi-main.c (mi_async): Likewise.
3500         (mi_async_1): Likewise.
3501         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3502         * nat/fork-inferior.h (startup_with_shell): Likewise.
3503         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3504         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3505         * nios2-tdep.c (nios2_debug): Likewise.
3506         * or1k-tdep.c (or1k_debug): Likewise.
3507         * parse.c (parser_debug): Likewise.
3508         * parser-defs.h (parser_debug): Likewise.
3509         * printcmd.c (print_symbol_filename): Likewise.
3510         * proc-api.c (procfs_trace): Likewise.
3511         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3512         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3513         (set_parameter_value): Update.
3514         (add_setshow_generic): Update.
3515         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3516         to bool*.
3517         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3518         int*.
3519         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3520         * record-btrace.c (record_btrace_target::store_registers): Update.
3521         * record-full.c (record_full_memory_query): Change to bool.
3522         (record_full_stop_at_limit): Likewise.
3523         * record-full.h (record_full_memory_query): Likewise.
3524         * remote-notif.c (notif_debug): Likewise.
3525         * remote-notif.h (notif_debug): Likewise.
3526         * remote.c (use_range_stepping): Likewise.
3527         (interrupt_on_connect): Likewise.
3528         (remote_break): Likewise.
3529         * ser-tcp.c (tcp_auto_retry): Likewise.
3530         * ser-unix.c (serial_hwflow): Likewise.
3531         * skip.c (debug_skip): Likewise.
3532         * solib-aix.c (solib_aix_debug): Likewise.
3533         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3534         (spu_auto_flush_cache_p): Likewise.
3535         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3536         Likewise.
3537         (struct info_print_options) <quiet>: Likewise.
3538         * symfile-debug.c (debug_symfile): Likewise.
3539         * symfile.c (auto_solib_add): Likewise.
3540         (separate_debug_file_debug): Likewise.
3541         * symfile.h (auto_solib_add): Likewise.
3542         (separate_debug_file_debug): Likewise.
3543         * symtab.c (basenames_may_differ): Likewise.
3544         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3545         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3546         (struct info_types_options) <quiet>: Likewise.
3547         * symtab.h (demangle): Likewise.
3548         (basenames_may_differ): Likewise.
3549         * target-dcache.c (stack_cache_enabled_1): Likewise.
3550         (code_cache_enabled_1): Likewise.
3551         * target.c (trust_readonly): Likewise.
3552         (may_write_registers): Likewise.
3553         (may_write_memory): Likewise.
3554         (may_insert_breakpoints): Likewise.
3555         (may_insert_tracepoints): Likewise.
3556         (may_insert_fast_tracepoints): Likewise.
3557         (may_stop): Likewise.
3558         (auto_connect_native_target): Likewise.
3559         (target_stop_and_wait): Update.
3560         (target_async_permitted): Change to bool.
3561         (target_async_permitted_1): Likewise.
3562         (may_write_registers_1): Likewise.
3563         (may_write_memory_1): Likewise.
3564         (may_insert_breakpoints_1): Likewise.
3565         (may_insert_tracepoints_1): Likewise.
3566         (may_insert_fast_tracepoints_1): Likewise.
3567         (may_stop_1): Likewise.
3568         * target.h (target_async_permitted): Likewise.
3569         (may_write_registers): Likewise.
3570         (may_write_memory): Likewise.
3571         (may_insert_breakpoints): Likewise.
3572         (may_insert_tracepoints): Likewise.
3573         (may_insert_fast_tracepoints): Likewise.
3574         (may_stop): Likewise.
3575         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3576         (make_thread_apply_all_options_def_group): Change argument from int*
3577         to bool*.
3578         (thread_apply_all_command): Update.
3579         (print_thread_events): Change to bool.
3580         * top.c (confirm): Likewise.
3581         (command_editing_p): Likewise.
3582         (history_expansion_p): Likewise.
3583         (write_history_p): Likewise.
3584         (info_verbose): Likewise.
3585         * top.h (confirm): Likewise.
3586         (history_expansion_p): Likewise.
3587         * tracepoint.c (disconnected_tracing): Likewise.
3588         (circular_trace_buffer): Likewise.
3589         * typeprint.c (print_methods): Likewise.
3590         (print_typedefs): Likewise.
3591         * utils.c (debug_timestamp): Likewise.
3592         (sevenbit_strings): Likewise.
3593         (pagination_enabled): Likewise.
3594         * utils.h (sevenbit_strings): Likewise.
3595         (pagination_enabled): Likewise.
3596         * valops.c (overload_resolution): Likewise.
3597         * valprint.h (struct value_print_options) <prettyformat_arrays,
3598         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3599         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3600         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3601         Likewise.
3602         * windows-nat.c (new_console): Likewise.
3603         (cygwin_exceptions): Likewise.
3604         (new_group): Likewise.
3605         (debug_exec): Likewise.
3606         (debug_events): Likewise.
3607         (debug_memory): Likewise.
3608         (debug_exceptions): Likewise.
3609         (useshell): Likewise.
3610         * windows-tdep.c (maint_display_all_tib): Likewise.
3611         * xml-support.c (debug_xml): Likewise.
3612
3613 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3614
3615         * source.c (prepare_path_for_appending): New function.
3616         (openp): Make use of new function.
3617         (find_and_open_source): Search for the compilation directory and
3618         source file as a relative path beneath the directory search path.
3619
3620 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * source-cache.c (source_cache::get_line_charpos): Catch
3623         exceptions and return false, this matches the behaviour documented
3624         in the header file.
3625
3626 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3627
3628         * ada-tasks.c (info_task): Remove quoting of the task's name.
3629
3630 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3631
3632         * symfile.c (auto_solib_add): Replace comment with a reference
3633         to the header file.
3634
3635 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3636
3637         * NEWS: Mention that gdb can now be compiled with Python 3
3638         on Windows.
3639
3640 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * maint.c (maint_print_section_data::maint_print_section_data):
3643         Force use of 'float log10 (float)' by casting the argument to
3644         float.
3645
3646 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * maint.c: Add 'cmath' include.
3649         (struct maint_print_section_data): New structure.
3650         (print_section_index): New function.
3651         (print_bfd_section_info): Add header comment, small whitespace
3652         cleanup, and update to call new print_section_index function.
3653         (print_objfile_section_info): Likewise.
3654         (maint_obj_section_from_bfd_section): New function.
3655         (print_bfd_section_info_maybe_relocated): New function.
3656         (maintenance_info_sections): Add header comment, always use
3657         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3658
3659 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3660
3661         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3662         inner scope, add check that the objfile has psymtabs before
3663         checking psymtabs_addrmap.
3664         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3665
3666 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3667
3668         * NEWS: Announce that Ada task names are now shown at more places,
3669         and between quotes (except in info task output).
3670         * gdb/ada-tasks.c (task_to_str): New function.
3671         (display_current_task_id): Call task_to_str.
3672         (task_command_1): Likewise.
3673         (print_ada_task_info): In non-mi mode, Properly align headers and data
3674         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3675
3676 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3677
3678         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3679         prstatus.pr_lwp.pr_info instead of making it up.
3680
3681 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3682
3683         * auto-load.c (auto_load_expand_dir_vars): Update.
3684         * defs.h (gdb_datadir): Change to std::string.
3685         (python_libdir): Likewise.
3686         (relocate_gdb_directory): Change return type to std::string.
3687         * guile/guile.c (gdbscm_data_directory): Update.
3688         (initialize_scheme_side): Update.
3689         * jit.c (jit_reader_dir): Change to std::string.
3690         (jit_reader_load_command): Update.
3691         * main.c (gdb_datadir): Change to std::string.
3692         (python_libdir): Likewise.
3693         (set_gdb_data_directory): Update.
3694         (relocate_path): Change to return std::string.
3695         (relocate_gdb_directory): Change to return std::string.
3696         (relocate_gdbinit_path_maybe_in_datadir): Update.
3697         (captured_main_1): Update.
3698         * python/python.c (do_start_initialization): Update.
3699         * top.c (show_gdb_datadir): Update.
3700         * xml-syscall.c (xml_init_syscalls_info): Update.
3701         (init_syscalls_info): Update.
3702
3703 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3704
3705         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3706         out of get_init_files.
3707         (get_init_files): Update.
3708
3709 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3710
3711         * main.c (get_init_files): Change to use std::string.
3712         (captured_main_1): Update.
3713         (print_gdb_help): Update.
3714
3715 2019-09-11  Ali Tamur  <tamur@google.com>
3716
3717         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3718         implementation.
3719
3720 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3721
3722         * dbxread.c (read_dbx_symtab): Update.
3723         * dwarf2read.c (load_partial_dies): Update.
3724         * mdebugread.c (parse_partial_symbols): Update.
3725         (handle_psymbol_enumerators): Update.
3726         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3727         * psymtab.c (add_psymbol_to_bcache): Likewise.
3728         (add_psymbol_to_list): Likewise.
3729         * symtab.c (symbol_set_names): Likewise.
3730         * symtab.h (symbol_set_names): Likewise.
3731         * xcoffread.c (scan_xcoff_symtab): Update.
3732
3733 2019-09-11  Tom Tromey  <tom@tromey.com>
3734
3735         * symfile-mem.c (symbol_file_add_from_memory): Use
3736         bfd_set_filename.
3737         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3738         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3739
3740 2019-09-10  Tom Tromey  <tromey@adacore.com>
3741
3742         * dwarf-index-write.c (write_psymbols): Extend error message.
3743         (debug_names::insert): Add Ada code.
3744         (debug_names::write_psymbols): Remove Ada check.
3745         (debug_names) <m_string_obstack>: New member.
3746         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3747         (gdb_index_symbol_name_matcher::matches): Remove.
3748         (mapped_index_base::find_name_components_bounds): Add "lang"
3749         parameter.
3750         (mapped_index_base::build_name_components): Also split names
3751         according to Ada syntax.
3752         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3753         type of "match_callback".
3754         (check_match, check_find_bounds_finds)
3755         (dw2_expand_symtabs_matching): Update.
3756         (dw2_debug_names_iterator): Add new constructor.
3757         (dw2_debug_names_map_matching_symbols): New function.
3758         (dw2_debug_names_expand_symtabs_matching): Update.
3759         (dwarf2_debug_names_functions): Use
3760         dw2_debug_names_map_matching_symbols.
3761
3762 2019-09-10  Tom Tromey  <tromey@adacore.com>
3763
3764         * dwarf2read.c (dw2_get_file_names_reader): Add the
3765         CU's file name to the results.
3766
3767 2019-09-10  Tom Tromey  <tromey@adacore.com>
3768
3769         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3770         map_matching_symbols.  Update.
3771         * dwarf2read.c (dw2_map_matching_symbols): Update.
3772         * psymtab.c (match_partial_symbol): Change type; update.
3773         (psym_map_matching_symbols): Likewise.
3774         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3775         type; update.
3776         * symfile.h (struct quick_symbol_functions)
3777         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3778         Remove "match".
3779
3780 2019-09-10  Tom Tromey  <tromey@adacore.com>
3781
3782         * psymtab.c (map_block): Remove.
3783         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3784         * symtab.c (iterate_over_symbols_terminated): New function.
3785         * symtab.c (iterate_over_symbols_terminated): Declare.
3786
3787 2019-09-10  Tom Tromey  <tromey@adacore.com>
3788
3789         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3790         * language.h (struct language_defn) <la_iterate_over_symbols>:
3791         Return bool.
3792         * symtab.c (iterate_over_symbols): Return bool.
3793         * symtab.h (iterate_over_symbols): Return bool.
3794
3795 2019-09-10  Tom Tromey  <tromey@adacore.com>
3796
3797         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3798         (add_nonlocal_symbols): Update.
3799         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3800         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3801         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3802         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3803         Change type of "callback".  Remove "data".
3804
3805
3806 2019-09-09  Ali Tamur  <tamur@google.com>
3807
3808         * dwarf2read.c (comp_unit_head): Update comment.
3809         (dwarf2_dwo_name): New function declaration.
3810         (dwarf_unit_type_name): New function declaration.
3811         (read_comp_unit_head): Add support for new compilation units,
3812         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3813         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3814         (currently named as "signature") in their header. Also clarify error
3815         messages.
3816         (lookup_dwo_id): New function. Returns the dwo id of the given
3817         compile unit.
3818         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3819         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3820         functions.
3821         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3822         (dwarf2_dwo_name): Get the dwo name if present.
3823         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3824         purposes.
3825
3826 2019-09-09  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3829
3830 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3831
3832         * python/python.c (do_start_initialization): Make progname_copy static,
3833         to avoid a leak report.
3834
3835 2019-09-08  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3838
3839 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3840
3841         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3842         Change type to gdb::optional<block_enum>.
3843         (dw2_symtab_iter_init): Change block_index parameter type
3844         to gdb::optional<block_enum>.
3845         (dw2_lookup_symbol): Change block_index parameter
3846         type to block_enum.c
3847         (dw2_debug_names_lookup_symbol): Likewise.
3848         * psymtab.c (psym_lookup_symbol): Likewise.
3849         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3850         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3851         Likewise.
3852
3853 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3854
3855         * defs.h (relocate_gdb_directory): Change int to bool in
3856         signature and rename flag to relocatable.
3857         * main.c (relocate_path): Likewise.
3858         (relocate_gdb_directory): Likewise.
3859
3860 2019-09-06  Alan Modra  <amodra@gmail.com>
3861
3862         * coffread.c (coff_symfile_read): Constify filename variable.
3863         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3864         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3865         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3866         * solib.c (reload_shared_libraries_1): Likewise.
3867         * symfile.c (reread_symbols): Likewise.
3868         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3869         * solib-darwin.c (darwin_bfd_open): Likewise.
3870         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3871
3872 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3875         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3876
3877 2019-09-03  Tom Tromey  <tromey@adacore.com>
3878
3879         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3880         types.
3881         (has_negatives): Unbias a range type bound.
3882         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3883         * gdbtypes.c (operator==): Handle new field.
3884         (create_range_type): Add "bias" parameter.
3885         (create_static_range_type, resolve_dynamic_range): Update.
3886         * gdbtypes.h (struct range_bounds) <bias>: New member.
3887         (create_range_type): Add bias parameter.
3888         * printcmd.c (print_scalar_formatted): Unbias range types.
3889         * value.c (unpack_long): Unbias range types.
3890         (pack_long): Bias range types.
3891
3892 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3893
3894         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3895         probe arguments.
3896
3897 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3898
3899         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3900         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3901         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3902         (compile_probe_arg): Likewise.
3903         * probe.h (get_argument_count): Likewise.
3904         * solib-svr4.c (solib_event_probe_action): Likewise.
3905         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3906
3907 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3908
3909         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3910         code to here...
3911         (svr4_create_solib_event_breakpoints): ...from here.
3912
3913 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3914
3915         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3916         suffix from warning message.
3917
3918 2019-08-30  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-winsource.h (struct tui_source_window_base)
3921         <refresh_all>: Don't declare.
3922         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3923         Remove.
3924         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3925         tui_show_locator_content.
3926         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3927         declare.
3928         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3929         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3930         declare.
3931
3932 2019-08-30  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3935
3936 2019-08-30  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3939         Remove unnecessary forward declarations.
3940
3941 2019-08-30  Tom Tromey  <tom@tromey.com>
3942
3943         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3944         rerender.
3945         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3946         tui_show_locator_content.
3947
3948 2019-08-30  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3951         (tui_locator_window::rerender): Rewrite using body of previous
3952         tui_show_locator_content.
3953
3954 2019-08-30  Tom Tromey  <tom@tromey.com>
3955
3956         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3957         set_locator_fullname>: New methods.
3958         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3959         Rename from tui_set_locator_fullname.
3960         (tui_locator_window::set_locator_info): Rename from
3961         tui_set_locator_info.  Return bool.
3962         (tui_update_locator_fullname, tui_show_frame_info): Update.
3963
3964 2019-08-30  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3967
3968 2019-08-30  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3971         call touchwin.
3972
3973 2019-08-30  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-wingeneral.c (box_win): Assume win_info and
3976         win_info->handle cannot be NULL.
3977
3978 2019-08-30  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3981         refresh_window>: Declare.
3982         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3983         resize.
3984         (tui_data_item_window::rerender): Rename from
3985         tui_display_register.
3986         (tui_data_item_window::refresh_window): New method.
3987         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3988         no-op.
3989
3990 2019-08-30  Tom Tromey  <tom@tromey.com>
3991
3992         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3993         regs_column_count, current_group>: Move later.  Now private.
3994         <get_current_group>: New method.
3995         * tui/tui-regs.c (tui_reg_command): Update.
3996         * tui/tui-layout.c (tui_set_layout): Update.
3997
3998 2019-08-30  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4001         (tui_data_window::rerender): Don't call
4002         check_and_display_highlight_if_needed.
4003         (tui_data_window::refresh_all): Remove call to
4004         erase_data_content.
4005
4006 2019-08-30  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4009         (tui_data_window::display_registers_from)
4010         (tui_data_window::display_reg_element_at_line)
4011         (tui_data_window::display_registers_from_line): Remove checks of
4012         "empty".
4013
4014 2019-08-30  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4017         Don't declare.
4018         * tui/tui-regs.c (tui_data_window::show_registers): Call
4019         rerender.
4020         (tui_data_window::rerender): Rename from display_all_data.
4021         (tui_data_window::rerender): Remove old implementation.
4022
4023 2019-08-30  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4026         text.
4027         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4028
4029 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4030             Sergio Durigan Junior  <sergiodj@redhat.com>
4031
4032         PR win32/24284
4033         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4034
4035 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4038         when searching for types.
4039
4040 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * f-lang.c (f_language_defn): Use f_print_typedef.
4043         * f-lang.h (f_print_typedef): Declare.
4044         * f-typeprint.c (f_print_typedef): Define.
4045
4046 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4047
4048         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4049
4050 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * cli/cli-utils.c (info_print_options_defs): Delete.
4053         (make_info_print_options_def_group): Delete.
4054         (extract_info_print_options): Delete.
4055         (info_print_command_completer): Delete.
4056         (info_print_args_help): Add extra parameter, and optionally
4057         include text about -n flag.
4058         * cli/cli-utils.h (struct info_print_options): Delete.
4059         (extract_info_print_options): Delete declaration.
4060         (info_print_command_completer): Delete declaration.
4061         (info_print_args_help): Add extra parameter, extend header
4062         comment.
4063         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4064         search_symbols.
4065         * stack.c (struct info_print_options): New type.
4066         (info_print_options_defs): New file scoped variable.
4067         (make_info_print_options_def_group): New static function.
4068         (info_print_command_completer): New static function.
4069         (info_locals_command): Update to use new local functions.
4070         (info_args_command): Likewise.
4071         (_initialize_stack): Add extra parameter to calls to
4072         info_print_args_help.
4073         * symtab.c (search_symbols): Add extra parameter, use this to
4074         possibly excluse non-debug symbols.
4075         (symtab_symbol_info): Add extra parameter, which is passed on to
4076         search_symbols.
4077         (struct info_print_options): New type.
4078         (info_print_options_defs): New file scoped variable.
4079         (make_info_print_options_def_group): New static function.
4080         (info_print_command_completer): New static function.
4081         (info_variables_command): Update to use local functions, and pass
4082         extra parameter through to symtab_symbol_info.
4083         (info_functions_command): Likewise.
4084         (info_types_command): Pass additional argument through to
4085         symtab_symbol_info.
4086         (rbreak_command): Pass extra argument to search_symbols.
4087         (_initialize_symtab): Add extra arguments for calls to
4088         info_print_args_help, and update help text for 'info variables',
4089         'whereis', and 'info functions' commands.
4090         * symtab.h (search_symbols): Add extra argument to declaration.
4091         * NEWS: Mention new flags.
4092
4093 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4094
4095         * symtab.c (lookup_static_symbol): Call the new function (and move
4096         it down to be next to lookup_global_symbol).
4097         (struct global_sym_lookup_data): Add block_enum member and rename to...
4098         (struct global_or_static_sym_lookup_data): ...this.
4099         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4100         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4101         (lookup_symbol_global_or_static_iterator_cb): ...this.
4102         (lookup_global_or_static_symbol): New function.
4103         (lookup_global_symbol): Call new function.
4104
4105 2019-08-26  Tom de Vries  <tdevries@suse.de>
4106
4107         PR c++/24852
4108         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4109         when pc_probe.prob == NULL.
4110
4111 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4112
4113         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4114         variable symbol_linkage to symbol_linkage_.
4115
4116 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4117
4118         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4119         represent whether the symbol is static, dynamic, or we don't
4120         know.
4121
4122 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4123
4124         * gdb/rx-tdep.c (rx_register_names): New.
4125         (rx_register_name): Delete.
4126         (rx_psw_type): Delete.
4127         (rx_fpsw_type): Delete.
4128         (rx_register_type): Delete.
4129         (rx_gdbarch_init): Convert target-descriptions.
4130         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4131         * gdb/features/Makefile: Add rx.xml.
4132         * gdb/features/rx.xml: New.
4133         * gdb/features/rx.c: Generated.
4134         * gdb/NEWS: Mention target description support.
4135
4136 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4137
4138         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4139         *slot_ptr.
4140
4141 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4142
4143         * configure.ac: Don't check for 'dlfcn.h' (moved to
4144         gdbsupport/common.m4).
4145         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4146         'gdbsupport/'.
4147         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4148         * compile/compile-c-support.c: Include
4149         'gdbsupport/gdb-dlfcn.h'.
4150         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4151         * gdb-dlfcn.c: Move to...
4152         * gdbsupport/gdb-dlfcn.c: ... here.
4153         * gdb-dlfcn.h: Move to...
4154         * gdbsupport/gdb-dlfcn.h: ... here.
4155
4156 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4157
4158         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4159         the offset field signed.
4160
4161 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4162
4163         * python/lib/gdb/__init__.py (_execute_file): New function.
4164         * python/python.c (python_run_simple_file): Call gdb._execute_file
4165         on Windows.
4166
4167 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4170         all uses as this was never set to anything but a zero value.
4171
4172 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4173
4174         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4175
4176 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4177
4178         * tui/tui-data.h (tui_gen_win_info): Add an =default
4179         move constructor, required by some GCC versions.
4180
4181 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4182
4183         * go32-nat.c (go32_sysinfo): Add hygon_p.
4184
4185 2019-08-20  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4188         line_from_reg_element_no, first_reg_element_no_inline,
4189         display_all_data, delete_data_content_windows,
4190         erase_data_content>: Now private.
4191
4192 2019-08-20  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4195         (tui_unhighlight_win, tui_highlight_win)
4196         (tui_win_info::make_window): Update.
4197         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4198
4199 2019-08-20  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4202         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4203         (MAX_PID_WIDTH): Move to tui-stack.c.
4204         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4205         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4206         (MAX_PID_WIDTH): Move from tui-data.h.
4207
4208 2019-08-20  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4211         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4212         (box_win): Update.
4213         (tui_gen_win_info::make_window): Rename from tui_make_window.
4214         (tui_win_info::make_window): New method.
4215         (tui_gen_win_info::make_visible): Update.
4216         * tui/tui-source.c (tui_source_window::set_contents): Update.
4217         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4218         (tui_data_window::display_registers_from): Update.
4219         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4220         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4221         Declare.
4222         <can_box>: Remove.
4223         <title>: Remove.
4224         (struct tui_win_info) <make_window>: Declare.
4225         <can_box>: Now virtual.
4226         <title>: New member.
4227         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4228         * tui/tui-command.c (tui_cmd_window::resize): Update.
4229
4230 2019-08-20  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4233         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4234         (tui_data_window::check_register_values): Update.
4235
4236 2019-08-20  Tom Tromey  <tom@tromey.com>
4237
4238         * tui/tui-regs.h (struct tui_data_window): Use
4239         DISABLE_COPY_AND_ASSIGN.
4240         <regs_content>: Change type, removing unique_ptr.
4241         <tui_data_window>: Add move constructor.
4242         * tui/tui-regs.c (tui_data_window::show_registers)
4243         (tui_data_window::show_register_group)
4244         (tui_data_window::display_registers_from)
4245         (tui_data_window::display_registers_from)
4246         (tui_data_window::first_data_item_displayed)
4247         (tui_data_window::delete_data_content_windows)
4248         (tui_data_window::rerender, tui_data_window::refresh_window)
4249         (tui_data_window::check_register_values): Update.
4250
4251 2019-08-20  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4254         show_register_group>: Declare.
4255         (tui_show_register_group): Don't declare.
4256         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4257         tui_show_registers.
4258         (tui_data_window::show_register_group): Rename from
4259         tui_show_register_group.
4260         (tui_data_window::check_register_values, tui_reg_command):
4261         Update.
4262         * tui/tui-layout.c (tui_set_layout): Update.
4263
4264 2019-08-20  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4267         Declare.
4268         (tui_check_register_values): Don't declare.
4269         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4270         from tui_check_register_values.
4271         * tui/tui-hooks.c (tui_register_changed): Update.
4272
4273 2019-08-20  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-regs.c (tui_reg_layout): Move later.
4276         (tui_show_registers): Don't enable TUI mode or change layout.
4277
4278 2019-08-20  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-regs.h (struct tui_data_item_window)
4281         <~tui_data_item_window>: Remove.
4282         <content>: Now a unique_xmalloc_ptr.
4283         * tui/tui-regs.c (tui_register_format): Return a
4284         unique_xmalloc_ptr.
4285         (tui_get_register): Update.
4286         (~tui_data_item_window): Remove.
4287         (tui_data_window::display_registers_from, tui_display_register):
4288         Update.
4289         * tui/tui-io.h (tui_expand_tabs): Update.
4290         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4291         Remove "col" parameter.
4292
4293 2019-08-20  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4296         field.
4297         * tui/tui-regs.c (~tui_data_item_window): Update.
4298
4299 2019-08-20  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4302         earlier.
4303
4304 2019-08-20  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4307
4308 2019-08-20  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-source.h (struct tui_source_window): Update.
4311         * tui/tui-regs.c (tui_show_registers): Update.
4312         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4313         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4314         (NO_REGS_STRING): Remove defines.
4315
4316 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4317
4318         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4319         unnecessary thread walk if remote doesn't support the packet.
4320
4321 2019-08-19  Tom Tromey  <tromey@adacore.com>
4322
4323         * python/py-value.c (value_has_field): Fix indentation.
4324
4325 2019-08-19  Tom Tromey  <tromey@adacore.com>
4326
4327         * printcmd.c (do_one_display, info_display_command): Update.
4328         * block.h (contained_in): Return bool.  Add allow_nested
4329         parameter.
4330         * block.c (contained_in): Return bool.  Add allow_nested
4331         parameter.
4332
4333 2019-08-19  Tom Tromey  <tom@tromey.com>
4334
4335         * configure: Rebuild.
4336         * configure.ac: Disallow the combination of -static-libstdc++ and
4337         source highlight.
4338         * source-cache.c (get_language_name): Handle rust.
4339         (source_cache::get_source_lines): Ignore highlighting exceptions.
4340
4341 2019-08-16  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4344         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4345         (struct tui_source_window_base) <make_visible, refresh_window,
4346         resize>: Remove methods.
4347         <execution_info>: Remove field.
4348         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4349         (tui_show_source_line, tui_source_window_base)
4350         (~tui_source_window_base): Update.
4351         (tui_source_window_base::resize)
4352         (tui_source_window_base::make_visible)
4353         (tui_source_window_base::refresh_window): Remove.
4354         (tui_source_window_base::update_exec_info): Update.
4355         * tui/tui-source.c (tui_source_window::set_contents): Update.
4356         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4357
4358 2019-08-16  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4361         deprecated_query_hook.
4362
4363 2019-08-16  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4366         (tui_update_source_windows_with_line): Update.
4367         * tui/tui-source.h (struct tui_source_window)
4368         <show_symtab_source>: Declare.
4369         (tui_show_symtab_source): Don't declare.
4370         * tui/tui-source.c (tui_show_symtab_source): Rename from
4371         tui_show_symtab_source.
4372
4373 2019-08-16  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-winsource.h (struct tui_source_window_base)
4376         <set_contents>: Declare.
4377         * tui/tui-winsource.c
4378         (tui_source_window_base::update_source_window_as_is): Update.
4379         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4380         Declare.
4381         (tui_set_source_content): Don't declare.
4382         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4383         tui_set_source_content.
4384         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4385         Declare.
4386         (tui_set_disassem_content): Don't declare.
4387         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4388         tui_set_disassem_content.
4389
4390 2019-08-16  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-winsource.h (struct tui_source_window_base)
4393         <update_breakpoint_info>: Declare.
4394         (tui_update_breakpoint_info): Don't declare.
4395         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4396         (tui_update_all_breakpoint_info): Update.
4397         (tui_source_window_base::update_breakpoint_info): Rename from
4398         tui_update_breakpoint_info.
4399         (tui_source_window_base::update_exec_info): Update.
4400
4401 2019-08-16  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-winsource.h (struct tui_source_window_base)
4404         <update_source_window>: Declare.
4405         (tui_update_source_window): Don't declare.
4406         * tui/tui-winsource.c
4407         (tui_source_window_base::update_source_window): Rename from
4408         tui_update_source_window.
4409         (tui_source_window_base::rerender): Update.
4410         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4411         * tui/tui-disasm.c (tui_show_disassem)
4412         (tui_show_disassem_and_update_source)
4413         (tui_disasm_window::maybe_update): Update.
4414
4415 2019-08-16  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-winsource.h (struct tui_source_window_base)
4418         <update_source_window_as_is>: Declare.
4419         (tui_update_source_window_as_is): Don't declare.
4420         * tui/tui-winsource.c (tui_update_source_window): Update
4421         (tui_source_window_base::update_source_window_as_is): Rename from
4422         tui_update_source_window_as_is.
4423         (tui_source_window_base::refill): Update.
4424         * tui/tui-source.c (tui_show_symtab_source): Update.
4425         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4426         Update.
4427
4428 2019-08-16  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-winsource.h (tui_update_source_window)
4431         (tui_update_source_window_as_is): Remove "noerror" parameter.
4432         * tui/tui-winsource.c (tui_update_source_window)
4433         (tui_update_source_window_as_is): Remove "noerror" parameter.
4434         (tui_update_source_windows_with_addr)
4435         (tui_update_source_windows_with_line)
4436         (tui_source_window_base::rerender)
4437         (tui_source_window_base::refill): Update.
4438         * tui/tui-source.h (tui_set_source_content)
4439         (tui_show_symtab_source): Remove "noerror" parameter.
4440         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4441         parameter.
4442         (tui_show_symtab_source): Likewise.
4443         (tui_source_window::maybe_update): Update.
4444         * tui/tui-disasm.c (tui_show_disassem)
4445         (tui_show_disassem_and_update_source)
4446         (tui_disasm_window::do_scroll_vertical)
4447         (tui_disasm_window::maybe_update): Update.
4448
4449 2019-08-16  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui.c (tui_is_window_visible): Update.
4452         * tui/tui-wingeneral.c (tui_make_window)
4453         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4454         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4455         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4456         (tui_set_win_height_command, parse_scrolling_args): Update.
4457         * tui/tui-source.c (tui_source_window::style_changed): Update.
4458         * tui/tui-regs.c (tui_show_registers)
4459         (tui_data_window::first_data_item_displayed)
4460         (tui_data_window::delete_data_content_windows)
4461         (tui_check_register_values, tui_reg_command): Update.
4462         * tui/tui-disasm.c (tui_show_disassem): Update.
4463         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4464         method.
4465         <is_visible>: Remove field.
4466         * tui/tui-data.c (tui_next_win, tui_prev_win)
4467         (tui_delete_invisible_windows): Update.
4468
4469 2019-08-16  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui-winsource.h (struct tui_source_window_base)
4472         <m_has_locator>: Remove.
4473         * tui/tui-layout.c (show_source_disasm_command, show_data)
4474         (show_source_or_disasm_and_command): Update.
4475
4476 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4477
4478         * NEWS (Other MI changes): New subsection.
4479         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4480         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4481         * arch-utils.c (default_get_pc_address_flags): New function.
4482         * arch-utils.h (default_get_pc_address_flags): New declaration.
4483         * gdbarch.sh: Add get_pc_address_flags.
4484         * gdbarch.c: Regenerate.
4485         * gdbarch.h: Likewise.
4486         * stack.c (print_pc): New function.
4487         (print_frame_info) (print_frame): Call print_pc.
4488
4489 2019-08-16  Tom de Vries  <tdevries@suse.de>
4490
4491         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4492         print_objfile_section_info.
4493
4494 2019-08-15  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4497         calling update_cmdwin_start_line.
4498         * tui/tui-winsource.h (struct tui_source_window_base)
4499         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4500         <rerender>: Declare.
4501         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4502         Call rerender.
4503         (tui_source_window_base::set_new_height): Remove.
4504         (tui_source_window_base::rerender): Rename from
4505         do_make_visible_with_new_height.
4506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4507         resize method.
4508         (tui_win_info::make_invisible_and_set_new_height)
4509         (tui_win_info::make_visible_with_new_height): Remove.
4510         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4511         Declare.
4512         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4513         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4514         do_make_visible_with_new_height>: Don't declare.
4515         <rerender>: Declare.
4516         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4517         set_new_height.
4518         (tui_data_window::do_make_visible_with_new_height): Remove.
4519         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4520         call tui_show_locator_content.
4521         (tui_gen_win_info::resize): Call rerender.
4522         (show_source_or_disasm_and_command): Don't call
4523         tui_show_locator_content.
4524         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4525         method.
4526         (struct tui_win_info) <rerender>: Declare.
4527         <set_new_height, make_invisible_and_set_new_height,
4528         make_visible_with_new_height>: Don't declare.
4529         * tui/tui-data.c (tui_win_list::rerender): New method.
4530         * tui/tui-command.h (struct tui_cmd_window)
4531         <do_make_visible_with_new_height>: Don't declare.
4532         * tui/tui-command.c
4533         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4534
4535 2019-08-15  Tom Tromey  <tromey@adacore.com>
4536
4537         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4538         * ada-lang.c (ada_enum_name): Likewise.
4539
4540 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4541
4542         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4543         leading underscore.
4544         (GdbOutputErrorFile): Likewise.
4545         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4546         accordingly.
4547         (execute_unwinders): Rename to have a leading underscore.
4548         (auto_load_packages): Likewise.
4549         (global scope): Adjust call to auto_load_packages accordingly.
4550         (GdbSetPythonDirectory): Likewise.
4551         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4552         instead of execute_unwinders.
4553
4554 2019-08-15  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4557         (show_data): Don't change window visibility.
4558         (tui_gen_win_info::resize): Remove special case for command
4559         window.  Use wresize, when available.
4560         (show_source_or_disasm_and_command): Don't change window
4561         visibility.
4562         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4563         <make_visible>: New method.
4564         * tui/tui-command.c (tui_cmd_window::resize): New method.
4565
4566 2019-08-15  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4569         (struct tui_source_windows): New.
4570         * tui/tui-winsource.c (tui_display_main): Update.
4571         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4572         (new_height_ok, parse_scrolling_args): Update.
4573         * tui/tui-layout.c (show_layout, show_data): Update.
4574         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4575         (tui_add_to_source_windows): Don't declare.
4576         * tui/tui-data.c (source_windows, tui_source_windows)
4577         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4578
4579 2019-08-15  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4582         Rename from reset.
4583         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4584         * tui/tui-layout.c (show_source_disasm_command, show_data):
4585         Update.
4586         (tui_gen_win_info::resize): Rename.
4587         (show_source_or_disasm_and_command): Update.
4588         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4589         reset.
4590
4591 2019-08-15  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4594         * tui/tui-interp.c (tui_interp::init): Don't call
4595         tui_initialize_static_data.
4596         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4597
4598 2019-08-15  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4601         examine tui_win_list.
4602
4603 2019-08-15  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4606         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4607         tui_clear_source_content.
4608         (tui_clear_source_content): Remove.
4609         (tui_source_window_base::do_erase_source_content): Hoist call to
4610         content.clear().
4611         * tui/tui-stack.c (tui_show_frame_info): Don't call
4612         tui_clear_source_content.
4613
4614 2019-08-15  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-winsource.h (struct tui_source_window_base)
4617         <do_erase_source_content>: New method.
4618         <erase_source_content>: New method.
4619         (tui_erase_source_content): Don't declare.
4620         * tui/tui-winsource.c (tui_clear_source_content): Update.
4621         (tui_source_window_base::do_erase_source_content): Rename from
4622         tui_erase_source_content.
4623         (tui_source_window_base::show_source_content): Update.
4624         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4625         * tui/tui-source.h (struct tui_source_window)
4626         <erase_source_content>: New method.
4627         * tui/tui-disasm.h (struct tui_disasm_window)
4628         <erase_source_content>: New method.
4629
4630 2019-08-15  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4633         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4634         constructor.
4635         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4636         * tui/tui-source.c (tui_set_source_content): Update.
4637         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4638
4639 2019-08-15  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4642         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4643         tui-source.c.
4644         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4645         Declare.
4646         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4647         method.
4648         (tui_source_window::maybe_update): Update.
4649
4650 2019-08-15  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4653         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4654         tui-disasm.c.
4655         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4656         Declare.
4657         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4658         method.
4659         (tui_disasm_window::maybe_update): Update.
4660
4661 2019-08-15  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-winsource.h (struct tui_source_window_base)
4664         <maybe_update>: Declare.
4665         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4666         method.
4667         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4668         Declare.
4669         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4670         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4671         Declare.
4672         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4673
4674 2019-08-15  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4677
4678 2019-08-15  Tom Tromey  <tom@tromey.com>
4679
4680         * tui/tui-wingeneral.c: Include tui-stack.h.
4681         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4682         (struct tui_locator_window): Move from tui-data.h.
4683         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4684         (tui_initialize_static_data): Move from tui-data.c.
4685         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4686         (struct tui_locator_window): Move to tui-stack.c.
4687         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4688         (tui_initialize_static_data): Move to tui-stack.c.
4689
4690 2019-08-15  Tom Tromey  <tom@tromey.com>
4691
4692         * tui/tui-layout.c (show_source_disasm_command)
4693         (show_source_or_disasm_and_command): Use make_visible method, not
4694         tui_make_window.
4695         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4696         Remove.
4697
4698 2019-08-15  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-wingeneral.h (tui_make_window): Update.
4701         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4702         parameter.
4703         (tui_gen_win_info::make_visible): Update.
4704         * tui/tui-regs.c (tui_data_window::display_registers_from):
4705         Update.
4706         * tui/tui-layout.c (show_source_disasm_command)
4707         (show_source_or_disasm_and_command): Update.
4708         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4709         (enum tui_box): Remove.
4710         (struct tui_win_info) <can_box>: New method.
4711         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4712         method.
4713
4714 2019-08-15  Tom de Vries  <tdevries@suse.de>
4715
4716         * linux-nat-trad.c: Include gdbarch.h.
4717
4718 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4719
4720         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4721         register sizes.
4722
4723 2019-08-14  Tom Tromey  <tromey@adacore.com>
4724
4725         * darwin-nat.c: Include gdbarch.h.
4726         * darwin-nat-info.c: Include gdbarch.h.
4727
4728 2019-08-13  Tom Tromey  <tom@tromey.com>
4729
4730         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4731         Remove.
4732         * tui/tui-data.c (tui_initialize_static_data): Update.
4733
4734 2019-08-13  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-winsource.h (struct tui_exec_info_window)
4737         <~tui_exec_info_window, maybe_allocate_content, get_content,
4738         m_content>: Remove.
4739         (struct tui_source_window_base) <set_exec_info_content,
4740         show_exec_info_content>: Don't declare.
4741         * tui/tui-winsource.c
4742         (tui_exec_info_window::maybe_allocate_content): Remove.
4743         (tui_source_window_base::update_exec_info): Rename from
4744         set_exec_info_content.
4745         (tui_source_window_base::show_exec_info_content)
4746         (tui_source_window_base::update_exec_info): Remove.
4747
4748 2019-08-13  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4751         declare.
4752         * tui/tui-winsource.c (tui_update_source_window_as_is)
4753         (tui_update_source_windows_with_addr, tui_erase_source_content):
4754         Update.
4755         (tui_clear_exec_info_content): Remove.
4756
4757 2019-08-13  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4760         declare.
4761         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4762         call tui_erase_exec_info_content.
4763         (tui_clear_exec_info_content): Rename from
4764         tui_erase_exec_info_content.
4765         (tui_clear_exec_info_content): Delete.
4766
4767 2019-08-13  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-winsource.h (struct tui_source_window_base)
4770         <show_exec_info_content>: Declare.
4771         (tui_show_exec_info_content): Don't declare.
4772         * tui/tui-winsource.c
4773         (tui_source_window_base::show_exec_info_content): Rename from
4774         tui_show_exec_info_content.
4775         (tui_source_window_base::update_exec_info): Update.
4776
4777 2019-08-13  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4780         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4781         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4782         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4783         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4784         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4785         ... here.
4786
4787 2019-08-13  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-winsource.h (struct tui_source_window_base)
4790         <update_exec_info>: Declare.
4791         (tui_update_exec_info): Don't declare.
4792         * tui/tui-winsource.c (tui_update_source_window_as_is)
4793         (tui_source_window_base::refresh_all)
4794         (tui_update_all_breakpoint_info): Update.
4795         (tui_source_window_base::update_exec_info): Rename from
4796         tui_update_exec_info.
4797         * tui/tui-stack.c (tui_show_frame_info): Update.
4798
4799 2019-08-13  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-winsource.h (struct tui_source_window_base)
4802         <set_exec_info_content>: Declare.
4803         (tui_set_exec_info_content): Don't declare.
4804         * tui/tui-winsource.c
4805         (tui_source_window_base::set_exec_info_content): Rename from
4806         tui_set_exec_info_content.
4807         (tui_update_exec_info): Update.
4808
4809 2019-08-13  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-winsource.h (struct tui_source_window_base)
4812         <show_source_content>: Declare.
4813         (tui_show_source_content): Don't declare.
4814         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4815         (tui_source_window_base::show_source_content): Rename from
4816         tui_show_source_content.
4817         (tui_source_window_base::refresh_all): Update.
4818         * tui/tui-layout.c (show_source_disasm_command)
4819         (show_source_or_disasm_and_command): Update.
4820
4821 2019-08-13  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-winsource.c (tui_erase_source_content)
4824         (tui_show_source_content, tui_source_window_base::refresh_all):
4825         Update.
4826         * tui/tui-wingeneral.h
4827         (tui_check_and_display_highlight_if_needed): Don't declare.
4828         * tui/tui-wingeneral.c
4829         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4830         check_and_display_highlight_if_needed.
4831         * tui/tui-win.c (tui_rehighlight_all)
4832         (tui_win_info::make_visible_with_new_height): Update.
4833         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4834         (tui_data_window::erase_data_content)
4835         (tui_data_window::display_all_data): Update.
4836         * tui/tui-data.h (struct tui_win_info)
4837         <check_and_display_highlight_if_needed>: Declare.
4838
4839 2019-08-13  Tom Tromey  <tom@tromey.com>
4840
4841         * tui/tui-win.c (tui_resize_all): Call
4842         tui_delete_invisible_windows.
4843         * tui/tui-layout.c (show_layout): Call
4844         tui_delete_invisible_windows.
4845         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4846         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4847
4848 2019-08-13  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4851         tui_add_win_to_layout.
4852
4853 2019-08-13  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4856         * tui/tui-layout.c (tui_default_win_height): Now static.
4857
4858 2019-08-13  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4861         single switch.
4862         (show_source_disasm_command, show_source_or_disasm_and_command):
4863         Don't check current layout.
4864
4865 2019-08-13  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-wingeneral.c (make_all_visible): Remove.
4868         (tui_make_all_invisible): Simplify.
4869         * tui/tui-layout.c (tui_make_all_invisible): Move from
4870         tui-wingeneral.c; simplify.
4871         (show_layout): Hoist call to tui_make_all_invisible.
4872         (show_data): Don't call tui_make_all_invisible.
4873
4874 2019-08-13  Tom Tromey  <tom@tromey.com>
4875
4876         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4877         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4878
4879 2019-08-13  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4882         tui-data.c.
4883         (show_source_disasm_command, show_data)
4884         (show_source_or_disasm_and_command): Don't use
4885         tui_set_current_layout_to.
4886         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4887         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4888         tui-layout.c.
4889         (tui_set_current_layout_to): Remove.
4890
4891 2019-08-13  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-layout.c (tui_set_layout): Update.
4894         * tui/tui-data.h (struct tui_layout_def): Remove.
4895         (tui_layout_def): Don't declare.
4896         * tui/tui-data.c (layout_def): Remove.
4897         (tui_layout_def): Remove.
4898
4899 2019-08-13  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-winsource.h (struct tui_source_window_base)
4902         <clear_detail>: No longer "override".
4903         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4904         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4905         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4906         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4907         Remove.
4908         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4909
4910 2019-08-13  Tom Tromey  <tromey@adacore.com>
4911
4912         * tracepoint.c: Don't include readline.h or history.h.
4913
4914 2019-08-12  Tom Tromey  <tom@tromey.com>
4915
4916         * configure: Rebuild.
4917         * configure.ac: Check for readline 7.
4918         * NEWS: Mention readline 7 requirement.
4919         * README: Update.
4920
4921 2019-08-12  Tom Tromey  <tom@tromey.com>
4922
4923         * mingw-hdep.c (gdb_select): Remove readline hack.
4924
4925 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4926
4927         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4928         when the function fails.
4929
4930 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4931
4932         * s390-tdep.c (s390_type_align): New function.
4933         (s390_gdbarch_init): Set it as type_align gdbarch method.
4934
4935 2019-08-09  Tom de Vries  <tdevries@suse.de>
4936
4937         PR gdb/24591
4938         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4939         pc_low with relocation offset.
4940
4941 2019-08-07  Tom Tromey  <tromey@adacore.com>
4942
4943         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4944         (print_frame_args): Update.
4945         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4946         Update.
4947         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4948         * frame.h (struct frame_arg): Add initializers.
4949         <error>: Now a unique_xmalloc_ptr.
4950
4951 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * NEWS: Expand the Pointer Authentication entry.
4954         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4955         (aarch64_frame_unmask_lr): ... to this.
4956         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4957         Call aarch64_frame_unmask_lr.
4958         * frame.c (struct frame_info): Add "masked" variable.
4959         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4960         (fprint_frame): Check for masked pc.
4961         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4962         declarations.
4963         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4964         * stack.c (print_frame): Check for masked pc.
4965
4966 2019-08-06  Tom Tromey  <tom@tromey.com>
4967
4968         * stabsread.c (patch_block_stabs, read_one_struct_field)
4969         (read_enum_type): Use obstack_strndup.
4970         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4971         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4972         * dwarf2read.c (guess_full_die_structure_name)
4973         (anonymous_struct_prefix): Use obstack_strndup.
4974         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4975         * c-exp.y (yylex): Use obstack_strndup.
4976         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4977         (write_var_or_type): Use obstack_strndup.
4978
4979 2019-08-06  Tom Tromey  <tom@tromey.com>
4980
4981         * symfile.c (reread_symbols): Use obstack_strdup.
4982         * stabsread.c (read_type): Use obstack_strdup.
4983         * gdb_obstack.h (obstack_strdup): New overload.
4984         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4985         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4986         (dwarf2_canonicalize_name): Use obstack_strdup.
4987         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4988         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4989         Use obstack_strdup.
4990
4991 2019-08-06  Tom Tromey  <tom@tromey.com>
4992
4993         * gdb_obstack.h (obstack_strdup): Define.
4994         * gdb_obstack.c (obstack_strdup): Don't define.
4995
4996 2019-08-06  Tom Tromey  <tom@tromey.com>
4997
4998         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4999         obstack_strdup.
5000         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5001         obstack_strdup.
5002         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5003         * stabsread.c (common_block_start): Use obstack_strdup.
5004         * objfiles.c (set_objfile_main_name, objfile): Use
5005         obstack_strdup.
5006         * namespace.c (add_using_directive): Use obstack_strdup.
5007         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5008         * jit.c (finalize_symtab): Use obstack_strdup.
5009         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5010         (guess_partial_die_structure_name, partial_die_info::fixup)
5011         (dwarf2_name): Use obstack_strdup.
5012         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5013         obstack_strdup.
5014         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5015         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5016         obstack_strdup.
5017         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5018
5019 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5020
5021         * unittests/help-doc-selftests.c: New file.
5022         * Makefile.in: Add the new file.
5023
5024 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5025
5026         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5027         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5028         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5029         the trailing '.' is not output, and the first character is uppercased.
5030         (print_help_for_command): Update call to print_doc_line.
5031         (print_doc_of_command): Likewise.
5032         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5033         * cli/cli-option.c (append_indented_doc): Do not append newline.
5034         (build_help_option): Append newline after first appended_indented_doc
5035         only if a second call is done.
5036         (build_help): Append 2 new lines before each option, except the first
5037         one.
5038         * compile/compile.c (_initialize_compile): Add new lines after
5039         %OPTIONS%, when not at the end of the help.
5040         Change help doc or code
5041         producing the help doc to respect the invariants.
5042         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5043         Also removed the new line after 'Options:', as all other commands
5044         do not put an empty line between 'Options:' and the first option.
5045         * printcmd.c (_initialize_printcmd): Likewise.
5046         * stack.c (_initialize_stack): Likewise.
5047         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5048         incorrectly telling COMMAND is optional.
5049         * ada-lang.c (_initialize_ada_language): Change help doc or code
5050         producing the help doc to respect the invariants.
5051         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5052         * breakpoint.c (_initialize_breakpoint): Likewise.
5053         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5054         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5055         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5056         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5057         _initialize_cli_style): Likewise.
5058         * corelow.c (core_target_info): Likewise.
5059         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5060         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5061         * filesystem.c (_initialize_filesystem): Likewise.
5062         * frame.c (_initialize_frame): Likewise.
5063         * gnu-nat.c (add_task_commands): Likewise.
5064         * infcall.c (_initialize_infcall): Likewise.
5065         * infcmd.c (_initialize_infcmd): Likewise.
5066         * interps.c (_initialize_interpreter): Likewise.
5067         * language.c (_initialize_language): Likewise.
5068         * linux-fork.c (_initialize_linux_fork): Likewise.
5069         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5070         * maint.c (_initialize_maint_cmds): Likewise.
5071         * memattr.c (_initialize_mem): Likewise.
5072         * printcmd.c (_initialize_printcmd): Likewise.
5073         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5074         _RegEx): Likewise.
5075         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5076         * record-btrace.c (_initialize_record_btrace): Likewise.
5077         * record-full.c (_initialize_record_full): Likewise.
5078         * record.c (_initialize_record): Likewise.
5079         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5080         * regcache.c (_initialize_regcache): Likewise.
5081         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5082         _initialize_remote): Likewise.
5083         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5084         * serial.c (_initialize_serial): Likewise.
5085         * skip.c (_initialize_step_skip): Likewise.
5086         * source.c (_initialize_source): Likewise.
5087         * stack.c (_initialize_stack): Likewise.
5088         * symfile.c (_initialize_symfile): Likewise.
5089         * symtab.c (_initialize_symtab): Likewise.
5090         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5091         * top.c (init_main): Likewise.
5092         * tracefile-tfile.c (tfile_target_info): Likewise.
5093         * tracepoint.c (_initialize_tracepoint): Likewise.
5094         * tui/tui-win.c (_initialize_tui_win): Likewise.
5095         * utils.c (add_internal_problem_command): Likewise.
5096         * valprint.c (value_print_option_defs): Likewise.
5097
5098 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5099
5100         PR build/24886
5101         * configure.ac: Drop enable-libmcheck support.
5102         * configure, config.in: Rebuild.
5103         * libmcheck.m4: Remove.
5104         * acinclude.m4: Don't include it.
5105         * Makefile.in: Don't distribute it.
5106         * top.c (print_gdb_configuration): Don't mention it.
5107
5108 2019-08-06  Tom Tromey  <tom@tromey.com>
5109
5110         * utils.c (set_output_style): Sometimes pass stream to
5111         emit_style_escape.
5112         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5113         * record-btrace.c (btrace_insn_history): Update.
5114         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5115         method.
5116         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5117         Update initializers.
5118         <m_uiout>: New field.
5119         <m_di>: Move lower.
5120         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5121         Remove "uiout" parameter.
5122         (dump_insns): Update.
5123         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5124         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5125
5126 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5127
5128         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5129         (error_in_psymtab_expansion): Likewise.
5130         (lookup_symbol_via_quick_fns): Likewise.
5131         (basic_lookup_transparent_type_quick): Likewise.
5132         (basic_lookup_transparent_type_1): Likewise.
5133
5134 2019-08-06  Tom Tromey  <tromey@adacore.com>
5135
5136         * source.c (last_source_error): Now bool.
5137         (print_source_lines_base): Make "noprint" bool.  Only open
5138         source file when last_source_visited changes.
5139
5140 2019-08-06  Tom Tromey  <tromey@adacore.com>
5141
5142         * annotate.c (annotate_source_line): Use g_source_cache.
5143         * source-cache.c (source_cache::get_plain_source_lines): Change
5144         parameters.  Populate m_offset_cache.
5145         (source_cache::ensure): New method.
5146         (source_cache::get_line_charpos): New method.
5147         (extract_lines): Move lower.  Change parameters.
5148         (source_cache::get_source_lines): Move lower.
5149         * source-cache.h (class source_cache): Update comment.
5150         <get_line_charpos>: New method.
5151         <get_source_lines>: Update comment.
5152         <clear>: Clear m_offset_cache.
5153         <get_plain_source_lines>: Change parameters.
5154         <ensure>: New method
5155         <m_offset_cache>: New member.
5156         * source.c (forget_cached_source_info_for_objfile): Update.
5157         (info_source_command): Use g_source_cache.
5158         (find_source_lines, open_source_file_with_line_charpos): Remove.
5159         (print_source_lines_base, search_command_helper): Use g_source_cache.
5160         * source.h (open_source_file_with_line_charpos): Don't declare.
5161         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5162         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5163         Use g_source_cache.
5164
5165 2019-08-06  Tom Tromey  <tromey@adacore.com>
5166
5167         * source-cache.c (source_cache::get_plain_source_lines):
5168         Remove "first_line" and "last_line" parameters.
5169         (source_cache::get_source_lines): Cache plain text.
5170         * source-cache.h (class source_cache)
5171         <get_plain_source_lines>: Update.
5172
5173 2019-08-06  Tom Tromey  <tromey@adacore.com>
5174
5175         * source-cache.c (extract_lines): No longer a method.
5176         Changed type of parameter.  Include final newline.
5177         (selftests::extract_lines_test): New function.
5178         (_initialize_source_cache): Likewise.
5179         * source-cache.h (class source_cache)
5180         <extract_lines>: Don't declare.
5181
5182 2019-08-06  Tom Tromey  <tromey@adacore.com>
5183
5184         * breakpoint.c (init_breakpoint_sal): Update.
5185         (breakpoint): Update.
5186         * breakpoint.h (struct breakpoint) <filter>: Now a
5187         unique_xmalloc_ptr.
5188
5189 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5190
5191         * NEWS: Mention dictionary access on blocks.
5192         * python/py-block.c (blpy_getitem): New function.
5193         (block_object_as_mapping): New struct.
5194         (block_object_type): Use new struct for tp_as_mapping field.
5195
5196 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5197
5198         * objfiles.h (objfile): Add a comment describing partial symbols.
5199
5200 2019-08-05  Tom Tromey  <tromey@adacore.com>
5201
5202         * compile/compile.c (_initialize_compile): Use _(), not N_().
5203         * thread.c (_initialize_thread): Use _(), not N_().
5204         * stack.c (_initialize_stack): Use _(), not N_().
5205         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5206
5207 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5208
5209         * dwarf2read.c (struct dw2_symtab_iterator):
5210         <want_specific_block>: Remove.
5211         <block_index>: Change type to gdb::optional.
5212         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5213         change type of BLOCK_INDEX parameter to gdb::optional.
5214         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5215         (dw2_lookup_symbol): Don't pass argument for
5216         WANT_SPECIFIC_BLOCK.
5217         (dw2_expand_symtabs_for_function): Don't pass argument for
5218         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5219         (class dw2_debug_names_iterator)
5220         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5221         parameter, change BLOCK_INDEX type to gdb::optional.
5222         <m_want_specific_block>: Remove.
5223         <m_block_index>: Change type to gdb::optional.
5224         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5225         gdb::optional.  Re-write in function of gdb::optional.
5226         (dw2_debug_names_lookup_symbol): Don't pass argument for
5227         WANT_SPECIFIC_BLOCK.
5228         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5229         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5230         BLOCK_INDEX.
5231
5232 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * NEWS: Mention changes to "info sources" command.
5235
5236 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5237
5238         * symtab.c (filename_partial_match_opts): New struct type.
5239         (struct output_source_filename_data): New members
5240         regexp, c_regexp, partial_match.
5241         (output_source_filename): Use new members to decide to print file.
5242         (info_sources_option_defs): New variable.
5243         (make_info_sources_options_def_group, print_info_sources_header,
5244         info_sources_command_completer):
5245         New functions.
5246         (info_sources_command): Read new optional arguments.
5247         (_initialize_symtab): Update info sources help.
5248
5249 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5250
5251         * ada-lang.c (exception_support_info_v0): Renamed from...
5252         (default_exception_support_info): ... this.  Create new
5253         definition for v1.
5254         (ada_has_this_exception_support): Look up catch_handlers_sym.
5255         (ada_exception_support_info_sniffer): Try v0 after default.
5256
5257 2019-08-01  Tom Tromey  <tromey@adacore.com>
5258
5259         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5260         gdbarch.h.
5261
5262 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5263
5264         * s12z-tdep.c: Fix include path for s12z-opc.h.
5265
5266 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5267
5268         * NEWS: Require GNU make 3.82.
5269
5270 2019-07-16  Tom Tromey  <tom@tromey.com>
5271
5272         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5273         declare.
5274
5275 2019-07-30  Tom Tromey  <tromey@adacore.com>
5276
5277         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5278
5279 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5280
5281         * printcmd.c (print_address_symbolic): Print negative offsets.
5282         (build_address_symbolic): Force signed arithmetic when computing
5283         offset.
5284
5285 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5286
5287         PR/24474: Add a function to lookup static variables.
5288         * NEWS: Mention this new function.
5289         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5290         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5291         * python/python.c (python_GdbMethods): Add new function.
5292
5293 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5294
5295         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5296         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5297         (objfpy_lookup_static_symbol): New function.
5298         (objfile_object_methods): Add new functions.
5299
5300 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5301
5302         * NEWS: Mention 'set|show print frame-info'.  Mention new
5303         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5304         backtrace argument.  Mention that python frame filtering code
5305         is now consistent with what 'backtrace' command prints.
5306
5307 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5308
5309         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5310         comments.
5311         (print_frame_info_auto, print_frame_info_source_line,
5312         print_frame_info_location, print_frame_info_source_and_location,
5313         print_frame_info_location_and_address, print_frame_info_short_location):
5314         New declarations.
5315         (struct frame_print_options): New member print_frame_info.
5316         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5317         * stack.h (get_user_print_what_frame_info): New declaration.
5318         (frame_show_address): New declaration.
5319         * stack.c (print_frame_arguments_choices): New value 'presence'.
5320         (print_frame_info_auto, print_frame_info_source_line,
5321         print_frame_info_location, print_frame_info_source_and_location,
5322         print_frame_info_location_and_address, print_frame_info_short_location,
5323         print_frame_info_choices, print_frame_info_print_what): New definitions.
5324         (print_frame_args): Only print dots for args if print frame-arguments
5325         is 'presence'.
5326         (frame_print_option_defs): New element for "frame-info".
5327         (get_user_print_what_frame_info): New function.
5328         (frame_show_address): Make non static.  Move comment to stack.h.
5329         (print_frame_info_to_print_what): New function.
5330         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5331         to decide what to print.
5332         (backtrace_command_1): Handle the new print_frame_arguments_presence
5333         value.
5334         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5335         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5336         (py_print_frame): In non-mi mode, use LOCATION as default for
5337         print_what, similarly to frame information printed directly by
5338         backtrace command. Handle frame-info user option in non MI mode.
5339
5340 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5341
5342         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5343         Add case for debugging 32-bit target on 64-bit host.  Revise
5344         comment.
5345
5346 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5347
5348         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5349         instead of find_function_entry_range_from_pc.
5350
5351 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5352
5353         * stack.c (find_frame_funname): Remove code which preferred
5354         minsym over symtab sym in "certain pathological cases".
5355
5356         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5357         parameter.  Change type of "do_demangle" to bool.
5358         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5359         Pass suitable "prefer_sym_over_minsym" flag to
5360         build_address_symbolic().  Don't output "+" for negative offsets.
5361         * printcmd.c (print_address_symbolic): Update invocation of
5362         build_address_symbolic to include a "prefer_sym_over_minsym"
5363         flag.
5364         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5365         Restrict cases in which use of minimal symbol is preferred to that
5366         of a found symbol.  Update comments.
5367
5368         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5369         for entry pc when entry pc is out of range for that FDE.
5370
5371 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5372
5373         PR gdb/24839:
5374         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5375         type.
5376
5377 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5378
5379         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5380         this function's Python signature.
5381
5382
5383 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5384
5385         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5386         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5387         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5388         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5389         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5390
5391
5392 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5393
5394         * h8300-tdep.c (h8300_register_name_common): New.
5395         h8300_register_name): Use h8300_register_name_common.
5396         (h8300s_register_name): Likewise.
5397         (h8300sx_register_name): Likewise.
5398         (h8300h_register_nam): New.
5399         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5400
5401
5402 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5403
5404         * arm-tdep.c (arm_skip_cmse_entry): New function.
5405         (arm_is_sgstubs_section): New function.
5406         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5407
5408 2019-07-22  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5411         Don't self-assign.
5412
5413 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5414
5415         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5416         type_print.
5417
5418 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5421         so that GDB doesn't match any msymbols when searching in the
5422         TYPES_DOMAIN.
5423         (print_symbol_info): Print using typedef_print or type_print based
5424         on the type of the symbol.  Add updated FIXME comment moved from...
5425         (_initialize_symtab): ... move and update FIXME comment to above.
5426
5427 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5428
5429         * NEWS: Mention adding -q option to "info types".
5430         * symtab.c (struct info_types_options): New struct.
5431         (info_types_options_defs): New variable.
5432         (make_info_types_options_def_group): New function.
5433         (info_types_command): Use gdb::option framework to parse options.
5434         (info_types_command_completer): New function.
5435         (_initialize_symtab): Extend the help text on "info types" and
5436         register command completer.
5437
5438 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5439
5440         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5441         (lookup_symbol_in_objfile): Change int to block_enum and add a
5442         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5443
5444 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5445
5446         * MAINTAINERS (Write After Approval): Add self.
5447
5448 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5451         instruction to the dummy code region.
5452
5453 2019-07-19  Tom Tromey  <tromey@adacore.com>
5454
5455         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5456         (ARGSUSED, PARAMS, __func__): Remove rules.
5457
5458 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5459
5460         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5461         * features/arm/arm-with-iwmmxt.c: Remove.
5462         * features/arm/arm-with-iwmmxt.xml: Remove.
5463         * features/arm/arm-with-m-fpa-layout.c: Remove.
5464         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5465         * features/arm/arm-with-m-vfp-d16.c: Remove.
5466         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5467         * features/arm/arm-with-m.c: Remove.
5468         * features/arm/arm-with-m.xml: Remove.
5469         * features/arm/arm-with-neon.c: Remove.
5470         * features/arm/arm-with-neon.xml: Remove.
5471         * features/arm/arm-with-vfpv2.c: Remove.
5472         * features/arm/arm-with-vfpv2.xml: Remove.
5473         * features/arm/arm-with-vfpv3.c: Remove.
5474         * features/arm/arm-with-vfpv3.xml: Remove.
5475
5476 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5477
5478         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5479
5480 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5481
5482         * arch/aarch32.c (aarch32_create_target_description): Create
5483         target descriptions using features.
5484         * arch/arm.c (arm_create_target_description)
5485         (arm_create_mprofile_target_description): Likewise.
5486         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5487
5488 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5489
5490         * Makefile.in: Add new files.
5491         * aarch32-tdep.c: New file.
5492         * aarch32-tdep.h: New file.
5493         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5494         Call aarch32_read_description.
5495         * arch/aarch32.c: New file.
5496         * arch/aarch32.h: New file.
5497         * arch/arm.c (arm_create_target_description)
5498         (arm_create_mprofile_target_description): New function.
5499         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5500         (arm_create_target_description)
5501         (arm_create_mprofile_target_description): New declaration.
5502         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5503         read_description functions.
5504         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5505         Likewise.
5506         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5507         * arm-tdep.c (tdesc_arm_list): New variable.
5508         (arm_register_g_packet_guesses): Call create description functions.
5509         (arm_read_description) (arm_read_mprofile_description): New
5510         function.
5511         * arm-tdep.h (arm_read_description)
5512         (arm_read_mprofile_description): Add declaration.
5513         * configure.tgt: Add new files.
5514
5515 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5516
5517         * top.c (new_ui_command): Open specified terminal just once.
5518
5519 2019-07-18  Tom Tromey  <tromey@adacore.com>
5520
5521         * symtab.c (main_name): Constify return type.
5522         * symfile.c (set_initial_language): Update.
5523         * symtab.h (main_name): Constify return type.
5524
5525 2019-07-17  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-winsource.c (tui_update_source_window)
5528         (tui_update_source_window_as_is)
5529         (tui_update_source_windows_with_line): Remove return.
5530         * tui/tui-disasm.c (tui_show_disassem)
5531         (tui_show_disassem_and_update_source): Remove return.
5532         * tui/tui.c (tui_reset): Remove return.
5533         * tui/tui-wingeneral.c
5534         (tui_check_and_display_highlight_if_needed): Remove return.
5535
5536 2019-07-17  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5539
5540 2019-07-17  Tom Tromey  <tom@tromey.com>
5541
5542         * tui/tui-winsource.h (struct tui_exec_info_window)
5543         (struct tui_source_window_base): Move from tui-data.h.
5544         * tui/tui-winsource.c: Move many method definitions from
5545         elsewhere.  Remove "structuring" comments.
5546         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5547         (tui_source_window_base::refresh_window): Move to
5548         tui-winsource.c.
5549         * tui/tui-win.c (tui_source_window_base::refresh_all)
5550         (tui_source_window_base::update_tab_width)
5551         (tui_source_window_base::set_new_height)
5552         (tui_source_window_base::do_make_visible_with_new_height): Move to
5553         tui-winsource.c.
5554         * tui/tui-source.h: Update.
5555         * tui/tui-source.c (tui_source_window_base::reset): Move to
5556         tui-winsource.c.
5557         * tui/tui-disasm.h: Update.
5558         * tui/tui-data.h (struct tui_exec_info_window): Move to
5559         tui-winsource.h.
5560         (struct tui_source_window_base): Likewise.
5561         * tui/tui-data.c (tui_source_window_base::clear_detail)
5562         (tui_source_window_base, ~tui_source_window_base): Move to
5563         tui-winsource.c.
5564
5565 2019-07-17  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-win.c (tui_resize_all)
5568         (tui_source_window_base::update_tab_width)
5569         (tui_adjust_win_heights): Update.
5570         (tui_win_info::make_invisible_and_set_new_height): Rename from
5571         make_invisible_and_set_new_height.
5572         * tui/tui-data.h (struct tui_win_info)
5573         <make_invisible_and_set_new_height>: New method.
5574
5575 2019-07-17  Tom Tromey  <tom@tromey.com>
5576
5577         * tui/tui.c: Update.
5578         * tui/tui-source.h (struct tui_source_window): Move from
5579         tui-data.h.
5580         * tui/tui-layout.c: Update.
5581         * tui/tui-disasm.c: Update.
5582         * tui/tui-data.h (struct tui_source_window): Move to
5583         tui-source.h.
5584
5585 2019-07-17  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5588         tui-data.h.
5589         * tui/tui-data.h (struct tui_disasm_window): Move to
5590         tui-disasm.h.
5591
5592 2019-07-17  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-regs.h (struct tui_data_item_window): Move from
5595         tui-data.h.
5596         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5597         * tui/tui-data.h (struct tui_data_item_window): Move to
5598         tui-regs.h.
5599         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5600
5601 2019-07-17  Tom Tromey  <tom@tromey.com>
5602
5603         * tui/tui.c: Update.
5604         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5605         (tui_cmd_window::max_height): Move to tui-command.c.
5606         * tui/tui-layout.c: Update.
5607         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5608         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5609         tui-command.c.
5610         * tui/tui-command.h (struct tui_cmd_window): Move from
5611         tui-data.h.
5612         * tui/tui-command.c: Remove "structuring" comments.
5613         (tui_cmd_window::clear_detail)
5614         (tui_cmd_window::do_make_visible_with_new_height)
5615         (tui_cmd_window::max_height): Move from elsewhere.
5616
5617 2019-07-17  Tom Tromey  <tom@tromey.com>
5618
5619         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5620         Now static.
5621         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5622         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5623
5624 2019-07-17  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui.c: Update.
5627         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5628         tui-regs.c.
5629         * tui/tui-windata.h: Remove file.
5630         * tui/tui-windata.c: Remove file.
5631         * tui/tui-win.c (tui_data_window::set_new_height)
5632         (tui_data_window::do_make_visible_with_new_height): Move to
5633         tui-regs.c.
5634         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5635         * tui/tui-regs.c: Remove "structuring" comments.
5636         (tui_data_window::first_data_item_displayed)
5637         (tui_data_window::delete_data_content_windows)
5638         (tui_data_window::erase_data_content)
5639         (tui_data_window::display_all_data)
5640         (tui_data_window::refresh_all)
5641         (tui_data_window::do_scroll_vertical)
5642         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5643         (tui_data_window::do_make_visible_with_new_height)
5644         (tui_data_window::refresh_window): Move from elsewhere.
5645         (_initialize_tui_regs): Move to end of file.
5646         * tui/tui-layout.c: Update.
5647         * tui/tui-hooks.c: Update.
5648         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5649         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5650         tui-regs.c.
5651         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5652
5653 2019-07-17  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5656         seen.
5657
5658 2019-07-17  Tom Tromey  <tom@tromey.com>
5659
5660         * tui/tui-win.c (tui_source_window_base::set_new_height)
5661         (tui_source_window_base::do_make_visible_with_new_height): Use
5662         m_has_locator field directly.
5663         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5664         method.
5665         (struct tui_source_window_base) <has_locator>: Likewise.
5666
5667 2019-07-17  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5670         Don't declare.
5671         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5672         Remove.
5673         * tui/tui-win.c (tui_source_window_base::set_new_height)
5674         (tui_source_window_base::set_new_height)
5675         (make_invisible_and_set_new_height)
5676         (tui_source_window_base::do_make_visible_with_new_height)
5677         (tui_source_window_base::do_make_visible_with_new_height):
5678         Update.
5679         * tui/tui-layout.c (show_source_disasm_command, show_data)
5680         (show_source_or_disasm_and_command): Update.
5681         * tui/tui-layout.c (show_layout): Update.
5682
5683 2019-07-17  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-layout.c (make_data_window): Remove.
5686         (show_data): Unify creation and re-initialization cases.
5687
5688 2019-07-17  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-layout.c (make_source_window, make_disasm_window):
5691         Remove.
5692         (show_data): Unify creation and re-initialization cases.
5693
5694 2019-07-17  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-layout.c (make_command_window): Remove.
5697         (show_source_disasm_command, show_source_or_disasm_and_command):
5698         Unify creation and re-initialization cases.
5699
5700 2019-07-17  Tom Tromey  <tom@tromey.com>
5701
5702         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5703         creation and re-initialization cases.
5704
5705 2019-07-17  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-regs.c (tui_get_register): Return void.
5708
5709 2019-07-17  Tom Tromey  <tom@tromey.com>
5710
5711         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5712         Simplify.
5713
5714 2019-07-17  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5717         resetting.
5718
5719 2019-07-17  Tom Tromey  <tom@tromey.com>
5720
5721         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5722         * tui/tui-regs.c (tui_reg_layout): New function.
5723         (tui_show_registers, tui_reg_command): Use it.
5724         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5725         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5726         parameters.
5727         (tui_layout_command): Remove.
5728
5729 2019-07-17  Tom Tromey  <tom@tromey.com>
5730
5731         * tui/tui-layout.h (tui/tui-layout): Return void.
5732         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5733
5734 2019-07-17  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-layout.c (show_source_disasm_command, show_data):
5737         Update.
5738         (reset_locator): Remove.
5739         (show_source_or_disasm_and_command): Update.
5740
5741 2019-07-17  Tom Tromey  <tom@tromey.com>
5742
5743         * tui/tui-source.c (tui_source_window_base::reset): Remove
5744         win_type parameter.
5745         * tui/tui-layout.c (make_command_window, make_source_window)
5746         (make_disasm_window, make_data_window)
5747         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5748         (reset_locator, show_source_or_disasm_and_command): Update.
5749         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5750         win_type parameter.
5751         (struct tui_source_window_base) <reset>: Likewise.
5752
5753 2019-07-17  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-layout.c (show_source_disasm_command): Use
5756         reset_locator.
5757         (reset_locator): New function.
5758         (init_and_make_win): Remove.
5759         (show_source_or_disasm_and_command): Use reset_locator.
5760
5761 2019-07-17  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5764         condition.
5765         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5766         Remove condition.
5767         * tui/tui-source.c (tui_source_window_base::reset): New method.
5768         * tui/tui-layout.c (make_command_window): Don't call
5769         init_and_make_win.
5770         (make_source_window, make_disasm_window): Don't call
5771         make_source_or_disasm_window.
5772         (make_data_window): Don't call init_and_make_win.  Change calling
5773         convention.
5774         (show_source_disasm_command, show_data): Simplify.
5775         (make_source_or_disasm_window): Remove.
5776         (show_source_or_disasm_and_command): Simplify.
5777         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5778         (struct tui_source_window_base) <reset>: Likewise.
5779         <execution_info>: Remove initializer.
5780         * tui/tui-data.c (tui_source_window_base): Initialize
5781         execution_info.
5782
5783 2019-07-17  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5786         variable.
5787
5788 2019-07-17  Tom Tromey  <tom@tromey.com>
5789
5790         * tui/tui.c (tui_rl_other_window): Update.
5791         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5792         superclass method first.  Always iterate over regs_content.
5793         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5794         method.
5795         * tui/tui-win.c (tui_set_focus_command): Update.
5796
5797 2019-07-17  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-win.c (tui_set_focus_command): Rename from
5800         tui_set_focus.  Call tui_enable.
5801         (tui_set_focus_command): Remove.
5802
5803 2019-07-17  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5806         refresh_window.
5807         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5808         touchwin.
5809         (tui_data_window::refresh_window): Call refresh_window on data
5810         items.  Always call superclass refresh_window.
5811         (tui_win_info::refresh): Remove.
5812         (tui_source_window_base::refresh_window): Update.
5813         (tui_refresh_all): Update.
5814         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5815         refresh_window.
5816         (show_source_or_disasm_and_command): Likewise.
5817         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5818         (struct tui_source_window_base) <refresh>: Likewise.
5819
5820 2019-07-17  Tom Tromey  <tom@tromey.com>
5821
5822         * tui/tui-winsource.c (tui_clear_source_content)
5823         (tui_show_source_content): Update.
5824         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5825         whether content is empty.
5826         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5827         Remove.
5828
5829 2019-07-17  Tom Tromey  <tom@tromey.com>
5830
5831         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5832         window's contents.
5833         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5834         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5835
5836 2019-07-17  Tom Tromey  <tom@tromey.com>
5837
5838         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5839         (struct tui_data_item_window): Update.
5840
5841 2019-07-17  Tom Tromey  <tom@tromey.com>
5842
5843         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5844         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5845         defines.
5846
5847 2019-07-17  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-winsource.h (tui_erase_source_content)
5850         (tui_clear_source_content): Remove "display_prompt" parameter.
5851         * tui/tui-winsource.c (tui_update_source_window_as_is)
5852         (tui_update_source_windows_with_addr): Update.
5853         (tui_clear_source_content): Remove "display_prompt" parameter.
5854         (tui_erase_source_content): Likewise.  Simplify.
5855         (tui_show_source_content): Update.
5856         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5857         * tui/tui-stack.c (tui_show_frame_info): Update.
5858         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5859         Remove defines.
5860
5861 2019-07-17  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5864         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5865         parameter.
5866         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5867         parameter.
5868
5869 2019-07-17  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-winsource.c (tui_clear_source_content)
5872         (tui_show_source_content, tui_show_exec_info_content)
5873         (tui_clear_exec_info_content): Update.
5874         * tui/tui-stack.c (tui_show_locator_content): Update.
5875         (tui_show_frame_info): Update.
5876         * tui/tui-source.h (tui_source_window): Don't declare.
5877         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5878         from tui_source_is_displayed.
5879         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5880         Remove field.
5881         (struct tui_source_window_base) <content_in_use>: New field.  Now
5882         bool.
5883         (struct tui_source_window) <showing_source_p>: New method.
5884         (TUI_SRC_WIN): Change cast.
5885         * tui/tui-data.c (tui_initialize_static_data): Update.
5886
5887 2019-07-17  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5890         location_matches_p.
5891         * tui/tui-source.c (tui_source_window::location_matches_p): New
5892         method.
5893         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5894         method.
5895         * tui/tui-data.h (struct tui_source_window_base)
5896         <location_matches_p>: New method.
5897         (struct tui_source_window, struct tui_disasm_window)
5898         <location_matches_p>: Likewise.
5899
5900 2019-07-17  Tom Tromey  <tom@tromey.com>
5901
5902         * tui/tui-win.c (tui_set_win_height_command): Rename from
5903         tui_set_win_height.
5904         (tui_set_win_height_command): Remove.
5905
5906 2019-07-17  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-source.c (tui_source_window): New constructor.  Add
5909         observer.
5910         (~tui_source_window): New destructor.
5911         (tui_source_window::style_changed): New method.
5912         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5913         (tui_attach_detach_observers): Update.
5914         * tui/tui-data.h (struct tui_source_window): Make constructor not
5915         inline.  Add destructor.
5916         (struct tui_source_window) <style_changed>: New method.
5917         <m_observable>: New member.
5918
5919 2019-07-17  Tom Tromey  <tom@tromey.com>
5920
5921         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5922         * tui/tui-win.c (tui_resize_all): Fix typo.
5923
5924 2019-07-17  Tom Tromey  <tom@tromey.com>
5925
5926         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5927         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5928         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5929         * tui/tui-win.c (window_name_completer): Use foreach.
5930         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5931         (update_tab_width): Likewise.
5932         * tui/tui-layout.c (show_layout): Update.
5933         * tui/tui-data.h (class tui_window_iterator): New.
5934         (struct all_tui_windows): New.
5935         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5936
5937 2019-07-17  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5940         parameter.  Don't reference globals.
5941         (tui_reg_command): Update.
5942
5943 2019-07-17  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-regs.c (tui_show_registers): Simplify.
5946
5947 2019-07-17  Tom Tromey  <tom@tromey.com>
5948
5949         * tui/tui-regs.c (tui_show_registers): Update.
5950         (tui_show_register_group): Add win_info parameter.
5951
5952 2019-07-17  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5955         Rename from tui_display_reg_element_at_line.
5956         (tui_data_window::display_registers_from_line): Update.
5957         * tui/tui-data.h (struct tui_data_window)
5958         <display_reg_element_at_line>: New method.
5959
5960 2019-07-17  Tom Tromey  <tom@tromey.com>
5961
5962         * tui/tui-regs.h (tui_display_registers_from)
5963         (tui_display_registers_from_line): Don't declare.
5964         * tui/tui-windata.c (tui_data_window::display_all_data)
5965         (tui_data_window::refresh_all)
5966         (tui_data_window::do_scroll_vertical): Update.
5967         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5968         from tui_display_registers_from.
5969         (tui_display_reg_element_at_line): Update.
5970         (tui_data_window::display_registers_from_line): Rename from
5971         tui_display_registers_from_line.
5972         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5973         display_registers_from_line>: New methods.
5974
5975 2019-07-17  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5978         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5979         from tui_erase_data_content.
5980         (tui_data_window::display_all_data)
5981         (tui_data_window::refresh_all)
5982         (tui_data_window::do_scroll_vertical): Update.
5983         * tui/tui-regs.c (tui_show_registers): Update.
5984         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5985         New method.
5986
5987 2019-07-17  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5990         declare.
5991         * tui/tui-windata.c
5992         (tui_data_window::delete_data_content_windows): Rename from
5993         tui_delete_data_content_windows.
5994         (tui_data_window::display_all_data)
5995         (tui_data_window::do_scroll_vertical): Update.
5996         * tui/tui-data.h (struct tui_data_window)
5997         <delete_data_content_windows>: New method.
5998
5999 2019-07-17  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6002         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6003
6004 2019-07-17  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6007         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6008         from tui_display_all_data.
6009         * tui/tui-win.c
6010         (tui_data_window::do_make_visible_with_new_height): Update.
6011         * tui/tui-regs.c (tui_show_registers): Update.
6012         * tui/tui-layout.c (tui_set_layout): Update.
6013         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6014         method.
6015
6016 2019-07-17  Tom Tromey  <tom@tromey.com>
6017
6018         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6019         * tui/tui-windata.c (tui_display_data_from): Remove.
6020         (tui_data_window::refresh_all): Update.
6021
6022 2019-07-17  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6025         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6026         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6027         tui_display_registers_from_line.
6028         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6029         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6030         "force_display" parameter.
6031
6032 2019-07-17  Tom Tromey  <tom@tromey.com>
6033
6034         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6035         declare.
6036         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6037         Rename from tui_first_reg_element_no_inline.
6038         (tui_display_reg_element_at_line)
6039         (tui_display_registers_from_line): Update.
6040         * tui/tui-data.h (struct tui_data_window)
6041         <first_reg_element_no_inline>: New method.
6042
6043 2019-07-17  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-windata.c (tui_display_data_from)
6046         (tui_data_window::do_scroll_vertical): Update.
6047         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6048         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6049         Rename from tui_line_from_reg_element_no.
6050         (tui_display_registers_from_line): Update.
6051         * tui/tui-data.h (struct tui_data_window)
6052         <line_from_reg_element_no>: New method.
6053
6054 2019-07-17  Tom Tromey  <tom@tromey.com>
6055
6056         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6057         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6058         tui_last_regs_line_no.
6059         (tui_display_reg_element_at_line)
6060         (tui_display_registers_from_line): Update.
6061         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6062         method.
6063
6064 2019-07-17  Tom Tromey  <tom@tromey.com>
6065
6066         PR tui/24722:
6067         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6068         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6069         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6070         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6071         (tui_update_breakpoint_info): Likewise.
6072         * tui/tui-hooks.c (tui_event_create_breakpoint)
6073         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6074         Update.
6075
6076 2019-07-17  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6079
6080 2019-07-17  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-winsource.c (tui_update_source_window_as_is)
6083         (tui_update_source_windows_with_addr): Update.
6084         * tui/tui-source.h (tui_set_source_content)
6085         (tui_show_symtab_source): Add "win_info" parameter.
6086         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6087         parameter.
6088         (tui_show_symtab_source): Likewise.
6089
6090 2019-07-17  Tom Tromey  <tom@tromey.com>
6091
6092         * tui/tui-wingeneral.c
6093         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6094
6095 2019-07-17  Tom Tromey  <tom@tromey.com>
6096
6097         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6098         (struct tui_cmd_window) <can_scroll>: New method.
6099         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6100         method.
6101
6102 2019-07-17  Tom Tromey  <tromey@adacore.com>
6103
6104         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6105         do_field_signed>: Rename.  Change type of "value".
6106         * ui-out.c (ui_out::field_signed): Rename from field_int.
6107         Change type of "value".
6108         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6109         type of "value".
6110         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6111         do_field_int.  Change type of "value".
6112         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6113         do_field_int.  Change type of "value".
6114         * tracepoint.c (trace_status_mi, tfind_1)
6115         (print_one_static_tracepoint_marker): Update.
6116         * thread.c (print_thread_info_1, print_selected_thread_frame):
6117         Update.
6118         * stack.c (print_frame, print_frame_info): Update.
6119         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6120         Update.
6121         * source.c (print_source_lines_base): Update.
6122         * skip.c (info_skip_command): Update.
6123         * record-btrace.c (btrace_ui_out_decode_error)
6124         (btrace_call_history_src_line): Update.
6125         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6126         Update.
6127         * progspace.c (print_program_space): Update.
6128         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6129         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6130         do_field_int.  Change type of "value".
6131         * mi/mi-out.c (mi_ui_out::do_table_begin)
6132         (mi_ui_out::do_table_header): Update.
6133         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6134         type of "value".
6135         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6136         (mi_cmd_data_list_changed_registers, output_register)
6137         (mi_cmd_data_read_memory, mi_load_progress)
6138         (mi_cmd_trace_frame_collected): Update.
6139         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6140         Update.
6141         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6142         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6143         (mi_cmd_var_list_children, varobj_update_one): Update.
6144         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6145         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6146         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6147         * inferior.c (print_inferior): Update.
6148         * gdb_bfd.c (print_one_bfd): Update.
6149         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6150         Update.
6151         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6152         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6153         do_field_int.  Change type of "value".
6154         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6155         do_field_int.  Change type of "value".
6156         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6157         (print_one_breakpoint_location, print_it_catch_fork)
6158         (print_one_catch_fork, print_it_catch_vfork)
6159         (print_one_catch_vfork, print_it_catch_solib)
6160         (print_it_catch_exec, print_it_ranged_breakpoint)
6161         (print_mention_watchpoint, print_mention_masked_watchpoint)
6162         (bkpt_print_it, update_static_tracepoint): Update.
6163         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6164         * break-catch-syscall.c (print_it_catch_syscall): Update.
6165         * ada-tasks.c (print_ada_task_info): Update.
6166         * ada-lang.c (print_it_exception, print_mention_exception):
6167         Update.
6168
6169 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         PR breakpoints/24541
6172         * gdbarch.c: Regenerate.
6173         * gdbarch.h: Regenerate.
6174         * gdbarch.sh: Adjust return type and parameter types for
6175         'stap_adjust_register'.
6176         (i386_stap_adjust_register): Adjust signature and return new
6177         register name.
6178         * stap-probe.c (stap_parse_register_operand): Adjust use of
6179         'gdbarch_stap_adjust_register'.
6180
6181 2019-07-17  Tom Tromey  <tromey@adacore.com>
6182
6183         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6184         declare VEC.
6185         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6186         std::vector.
6187         (struct s390_process_info): Add initializers.
6188         (s390_add_process): Use new.
6189         (s390_linux_nat_target::low_forget_process): Use delete.
6190         (s390_linux_nat_target::low_new_fork)
6191         (s390_linux_nat_target::stopped_by_watchpoint)
6192         (s390_linux_nat_target::low_prepare_to_resume)
6193         (s390_linux_nat_target::insert_watchpoint)
6194         (s390_linux_nat_target::insert_hw_breakpoint)
6195         (s390_linux_nat_target::remove_watchpoint)
6196         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6197
6198 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6199
6200         * aarch64-fbsd-nat.c: Include regcache.h.
6201         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6202         argument.
6203         (aarch64_fbsd_nat_target::fetch_registers)
6204         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6205         variable.
6206         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6207
6208 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6209
6210         * fbsd-nat.c: Include gdbarch.h.
6211
6212 2019-07-15  Tom Tromey  <tromey@adacore.com>
6213
6214         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6215
6216 2019-07-15  Tom Tromey  <tromey@adacore.com>
6217
6218         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6219         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6220         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6221         * cli-out.c (cli_ui_out::do_field_int): New method.
6222         * ui-out.c (ui_out::field_unsigned): New method.
6223         * symfile.c (generic_load): Use field_unsigned.
6224         (print_transfer_performance): Likewise.
6225         * record-btrace.c (ui_out_field_uint): Remove.
6226         (btrace_call_history_insn_range, btrace_call_history): Use
6227         field_unsigned.
6228         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6229         field_unsigned.
6230         * ui-out.h (class ui_out) <field_unsigned>: New method.
6231         <do_field_unsigned>: Likewise.
6232
6233 2019-07-15  Tom Tromey  <tromey@adacore.com>
6234
6235         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6236         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6237         * target.c (flash_erase_command): Use field_string.
6238         * infrun.c (print_signal_received_reason): Use field_string.
6239         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6240         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6241         field_string.
6242         * ada-tasks.c (print_ada_task_info): Use field_string.
6243
6244 2019-07-15  Tom Tromey  <tromey@adacore.com>
6245
6246         * target.c (flash_erase_command): Use field_core_addr.
6247         * symfile.c (generic_load): Use field_core_addr.
6248         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6249         Use field_core_addr.
6250         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6251         field_core_addr.
6252
6253 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6254
6255         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6256         value if its desired type is smaller than a CORE_ADDR and signed.
6257
6258 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6261         of changes to field names, and use new is_reference field to
6262         decide if a property is a reference or not.
6263         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6264         field.
6265         (struct dwarf2_property_baton): Update header comment, rename
6266         'referenced_type' to 'property_type' and update comments.
6267         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6268         default property type, store in property baton, update to take
6269         accound of renamed field.
6270         (read_func_scope): Update call to attr_to_dynamic_prop.
6271         (read_array_type): Likewise.
6272         (dwarf2_per_cu_addr_sized_int_type): New function.
6273         (read_subrange_index_type): Move type finding code to
6274         dwarf2_per_cu_addr_sized_int_type.
6275         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6276         (dwarf2_per_cu_addr_type): New function.
6277         (set_die_type): Update calls to attr_to_dynamic_prop.
6278
6279 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * dwarf2read.c (read_subrange_index_type): New function.
6282         (read_subrange_type): Move code into new function and call it.
6283         * gdbtypes.c (create_range_type): Add some asserts.
6284
6285 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6286
6287         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6288         update return statements.
6289         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6290         declaration, and update comment to match.
6291         * gdbtypes.c (resolve_dynamic_array): Update call to
6292         dwarf2_evaluate_property to match new return type.
6293
6294 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * valarith.c (value_subscripted_rvalue): Change lowerbound
6297         parameter type from int to LONGEST.
6298         * value.h (value_subscripted_rvalue): Likewise in declaration.
6299
6300 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6301
6302         * cli/cli-utils.c (info_print_command_completer): New function.
6303         * cli/cli-utils.h: Add 'completer.h' include, and forward
6304         declaration for 'struct cmd_list_element'.
6305         (info_print_command_completer): Declare.
6306         * stack.c (_initialize_stack): Add completer for 'info locals' and
6307         'info args'.
6308         * symtab.c (_initialize_symtab): Add completer for 'info
6309         variables' and 'info functions'.
6310         * NEWS: Mention completion for additional info commands.
6311
6312 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * cli/cli-utils.c (extract_info_print_args): Delete.
6315         (extract_arg_maybe_quoted): Delete.
6316         (info_print_options_defs): New variable.
6317         (make_info_print_options_def_group): New function.
6318         (extract_info_print_options): Define new function.
6319         * cli/cli-utils.h (extract_info_print_args): Delete.
6320         (struct info_print_options): New structure.
6321         (extract_info_print_options): Declare new function.
6322         * stack.c (info_locals_command): Update to use new
6323         extract_info_print_options, also add a header comment.
6324         (info_args_command): Likewise.
6325         * symtab.c (info_variables_command): Likewise.
6326         (info_functions_command): Likewise.
6327
6328 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6329
6330         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6331         to extract string arguments.
6332         * common/common-utils.c (extract_string_maybe_quoted): New function.
6333         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6334
6335 2019-07-11  Tom Tromey  <tromey@adacore.com>
6336
6337         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6338         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6339         * top.h (gdbinit): Don't declare.
6340         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6341         into...
6342         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6343         * top.c (gdb_init): Don't call init_cli_cmds.
6344         (gdbinit): Remove.
6345         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6346
6347 2019-07-11  Tom Tromey  <tromey@adacore.com>
6348
6349         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6350         after it has been moved.
6351
6352 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6353
6354         * valops.c (value_must_coerce_to_target): Change return type to
6355         bool.
6356         * value.h (value_must_coerce_to_target): Likewise.
6357
6358 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6359
6360         * breakpoint.c (is_hardware_watchpoint): Remove
6361         forward-declaration.
6362         (is_masked_watchpoint): Change return type to bool.
6363         (is_tracepoint): Likewise.
6364         (is_breakpoint): Likewise.
6365         (is_hardware_watchpoint): Likewise.
6366         (is_watchpoint): Likewise.
6367         (is_no_memory_software_watchpoint): Likewise.
6368         (is_catchpoint): Likewise.
6369         (breakpoint_1): Make FILTER parameter's return type bool.
6370         is_masked_watchpoint): Change return type to bool.
6371         (save_breakpoints): Make FILTER parameter's return type bool.
6372         * breakpoint.h (is_breakpoint): Change return type to bool.
6373         (is_watchpoint): Likewise.
6374         (is_catchpoint): Likewise.
6375         (is_tracepoint): Likewise.
6376
6377 2019-07-10  Tom Tromey  <tom@tromey.com>
6378
6379         * defs.h: Don't include gdbarch.h.
6380         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6381         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6382         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6383         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6384         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6385         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6386         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6387         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6388         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6389         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6390         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6391         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6392         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6393         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6394         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6395         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6396         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6397         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6398         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6399         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6400         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6401         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6402         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6403         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6404         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6405         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6406         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6407
6408 2019-07-10  Tom Tromey  <tromey@adacore.com>
6409
6410         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6411         * breakpoint.c (init_ada_exception_breakpoint): Register as
6412         bp_catchpoint.
6413         (print_one_breakpoint_location, print_one_breakpoint): Use
6414         is_ada_exception_catchpoint.
6415         * ada-lang.c (class ada_catchpoint_location): Pass
6416         bp_loc_software_breakpoint to bp_location constructor.
6417         (is_ada_exception_catchpoint): New function.
6418
6419 2019-07-10  Tom Tromey  <tromey@adacore.com>
6420
6421         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6422         VEC.
6423         (struct arm_exidx_entry): New method operator<.
6424         (struct arm_exidx_data) <section_maps>: Change type.
6425         (arm_exidx_data_free): Remove.
6426         (arm_exidx_data_key): Change type.  Move lower.
6427         (arm_exidx_new_objfile): Update.
6428         (arm_compare_exidx_entries): Remove.
6429         (arm_find_exidx_entry, _initialize_arm_tdep)
6430
6431 2019-07-10  Tom Tromey  <tromey@adacore.com>
6432
6433         * solib-spu.c (ocl_program_data_key): Change type.
6434         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6435         Update.
6436
6437 2019-07-10  Tom Tromey  <tromey@adacore.com>
6438
6439         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6440         (struct solib_aix_inferior_data) <library_list>: Change type.
6441         (solib_aix_inferior_data_handle): Change type.
6442         (get_solib_aix_inferior_data): Update.
6443         (solib_aix_free_library_list): Remove.
6444         (library_list_start_library): Update.
6445         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6446         return type.
6447         (solib_aix_get_library_list)
6448         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6449         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6450
6451 2019-07-10  Tom Tromey  <tromey@adacore.com>
6452
6453         * solib-dsbt.c (struct dsbt_info): Add initializers.
6454         (solib_dsbt_pspace_data): Change type.
6455         (dsbt_pspace_data_cleanup): Remove.
6456         (get_dsbt_info, _initialize_dsbt_solib): Update.
6457
6458 2019-07-10  Tom Tromey  <tromey@adacore.com>
6459
6460         * spu-tdep.c (spu_overlay_data): Change type.
6461         (spu_get_overlay_table, spu_overlay_new_objfile)
6462         (_initialize_spu_tdep): Update.
6463
6464 2019-07-10  Tom Tromey  <tromey@adacore.com>
6465
6466         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6467         destructor.
6468         (dbx_objfile_data_key): Change type and declare later.
6469         (DBX_SYMFILE_INFO): Rewrite.
6470         * dbxread.c (dbx_objfile_data_key): Change type.
6471         (dbx_symfile_init): Update.
6472         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6473         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6474         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6475
6476 2019-07-10  Tom Tromey  <tromey@adacore.com>
6477
6478         * jit.c (jit_program_space_key): Change type.  Move lower.
6479         (get_jit_program_space_data): Update.
6480         (jit_program_space_data_cleanup): Remove.
6481         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6482         Update.
6483         (struct jit_program_space_data): Add initializers.
6484
6485 2019-07-10  Tom Tromey  <tromey@adacore.com>
6486
6487         * solib-darwin.c (struct darwin_info): Add initializers.
6488         (solib_darwin_pspace_data): Change type.
6489         (darwin_pspace_data_cleanup): Remove.
6490         (get_darwin_info, _initialize_darwin_solib): Update.
6491
6492 2019-07-10  Tom Tromey  <tromey@adacore.com>
6493
6494         * remote-sim.c (struct sim_inferior_data): Add initializers,
6495         constructor, and destructor.
6496         (sim_inferior_data_key): Change type.  Move lower.
6497         (check_for_duplicate_sim_descriptor): Update.
6498         (get_sim_inferior_data): Use new.  Update.
6499         (~sim_inferior_data_cleanup): Rename from
6500         sim_inferior_data_cleanup.  Simplify.
6501         (gdbsim_close_inferior, simulator_command)
6502         (sim_command_completer, _initialize_remote_sim): Update.
6503         (next_pid, INITIAL_PID): Move earlier.
6504
6505 2019-07-10  Tom Tromey  <tromey@adacore.com>
6506
6507         * python/python-internal.h (create_thread_object): Return
6508         gdbpy_ref.
6509         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6510         * python/py-inferior.c (struct threadlist_entry): Add
6511         constructor.
6512         <thread_obj>: Now a gdbpy_ref.
6513         (thread_to_thread_object): Update.
6514         (add_thread_object): Use new.
6515         (delete_thread_object): Use delete.
6516         (infpy_threads): Update.
6517         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6518         GIL.
6519
6520 2019-07-10  Tom Tromey  <tromey@adacore.com>
6521
6522         * valops.c (value_cast): Specialize error message for Ada.
6523
6524 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6525
6526         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6527
6528 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6529
6530         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6531         bpstat_should_step): Return bool, adjust comments.
6532         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6533         bpstat_should_step): Likewise.
6534
6535 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6536
6537         * features/Makefile: Use feature target descriptions for Arm.
6538         * features/arm/arm-core.c: Generate new file.
6539         * features/arm/arm-fpa.c: Likewise.
6540         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6541         * features/arm/arm-m-profile.c: Likewise.
6542         * features/arm/arm-vfpv2.c: Likewise.
6543         * features/arm/arm-vfpv3.c: Likewise.
6544         * features/arm/xscale-iwmmxt.c: Likewise.
6545         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6546
6547 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6548
6549         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6550         ptrace earlier.
6551
6552 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * features/aarch64-pauth.c: Regenerate.
6555
6556 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6557
6558         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6559         bool.
6560         (bpstat_what): Use false instead of 0.
6561
6562 2019-07-09  Pedro Alves  <palves@redhat.com>
6563
6564         * break-catch-throw.c (is_exception_catchpoint): New.
6565         * breakpoint.c (print_one_breakpoint_location): New parameter
6566         'raw_loc'.  Handle it.  Use
6567         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6568         looking at the breakpoint's type.
6569         (print_one_breakpoint): If handling "maint info breakpoints", also
6570         print locations of exception catchpoints.
6571         * breakpoint.h (is_exception_catchpoint): Declare.
6572
6573 2019-07-09  Pedro Alves  <palves@redhat.com>
6574
6575         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6576         "addr" field.
6577         (allocate_location_exception_catchpoint): New.
6578         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6579         (initialize_throw_catchpoint_ops): Install
6580         allocate_location_exception_catchpoint as allocate_location
6581         method.
6582         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6583         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6584         bp_loc_other.
6585         (breakpoint_address_is_meaningful): Delete.
6586         (bl_address_is_meaningful): New.
6587         (breakpoint_locations_match): Adjust comment.
6588         (bp_location_from_bp_type): New, factored out of...
6589         (bp_location::bp_location(breakpoint *)): ... this.
6590         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6591         factored out of...
6592         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6593         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6594         breakpoint_address_is_meaningful.
6595         (bp_locations_compare): Adjust comment.
6596         (update_global_location_list): Use bl_address_is_meaningful
6597         instead of breakpoint_address_is_meaningful.
6598         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6599         explicit.
6600         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6601         * python/py-breakpoint.c (bppy_get_location): No longer check
6602         whether location is null.
6603
6604 2019-07-09  Pedro Alves  <palves@redhat.com>
6605
6606         PR c++/15468
6607         * breakpoint.c (print_one_breakpoint_location): Remove
6608         single-location assert.
6609
6610 2019-07-09  Tom Tromey  <tom@tromey.com>
6611
6612         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6613         * configure: Rebuild.
6614         * configure.ac: Change common to gdbsupport.
6615         * gdbsupport: Rename from common.
6616         * acinclude.m4: Change common to gdbsupport.
6617         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6618         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6619         gdbsupport.
6620         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6621         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6622         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6623         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6624         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6625         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6626         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6627         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6628         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6629         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6630         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6631         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6632         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6633         coff-pe-read.c, command.h, compile/compile-c-support.c,
6634         compile/compile-c.h, compile/compile-cplus-symbols.c,
6635         compile/compile-cplus-types.c, compile/compile-cplus.h,
6636         compile/compile-loc2c.c, compile/compile.c, completer.c,
6637         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6638         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6639         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6640         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6641         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6642         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6643         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6644         features/aarch64-core.c, features/aarch64-fpu.c,
6645         features/aarch64-pauth.c, features/aarch64-sve.c,
6646         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6647         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6648         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6649         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6650         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6651         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6652         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6653         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6654         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6655         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6656         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6657         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6658         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6659         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6660         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6661         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6662         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6663         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6664         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6665         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6666         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6667         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6668         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6669         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6670         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6671         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6672         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6673         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6674         minsyms.c, mips-linux-tdep.c, namespace.h,
6675         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6676         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6677         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6678         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6679         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6680         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6681         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6682         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6683         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6684         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6685         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6686         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6687         procfs.c, producer.c, progspace.h, psymtab.h,
6688         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6689         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6690         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6691         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6692         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6693         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6694         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6695         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6696         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6697         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6698         target-memory.c, target.c, target.h, target/waitstatus.c,
6699         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6700         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6701         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6702         unittests/array-view-selftests.c,
6703         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6704         unittests/common-utils-selftests.c,
6705         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6706         unittests/format_pieces-selftests.c,
6707         unittests/function-view-selftests.c,
6708         unittests/lookup_name_info-selftests.c,
6709         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6710         unittests/mkdir-recursive-selftests.c,
6711         unittests/observable-selftests.c,
6712         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6713         unittests/parse-connection-spec-selftests.c,
6714         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6715         unittests/scoped_fd-selftests.c,
6716         unittests/scoped_mmap-selftests.c,
6717         unittests/scoped_restore-selftests.c,
6718         unittests/string_view-selftests.c, unittests/style-selftests.c,
6719         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6720         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6721         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6722         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6723         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6724         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6725
6726 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6729         bool value.
6730         (decode_digits_ordinary): Set explicit_line field in sal.
6731         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6732         symtab_and_line that was set on an explicit line number in
6733         assembler code.  Do always update the recorded symtab and line if
6734         we do skip the prologue.
6735
6736 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6737
6738         * breakpoint.c (set_breakpoint_location_function): Remove
6739         explicit_loc parameter.
6740         (momentary_breakpoint_from_master): Update call to
6741         set_breakpoint_location_function.
6742         (add_location_to_breakpoint): Likewise.
6743
6744 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6745
6746         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6747         required features based on default bfd type when no specific bfd
6748         is present.
6749
6750 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6751
6752         * NEWS: Mention that GDB printf and eval commands can now print
6753         C-style and Ada-style convenience var strings without
6754         calling the inferior.
6755         * printcmd.c (printf_c_string): Locally print GDB internal var
6756         instead of transiting via the inferior.
6757         (printf_wide_c_string): Likewise.
6758
6759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6760
6761         PR breakpoints/25011
6762         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6763
6764 2019-07-04  Tom Tromey  <tom@tromey.com>
6765
6766         PR tui/24724:
6767         * tui/tui-winsource.c (tui_clear_source_content): Update.
6768         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6769         (tui_update_breakpoint_info): Update.
6770         (tui_set_exec_info_content): Update.
6771         * tui/tui-source.c (tui_set_source_content_nil): Update.
6772         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6773         has_break.
6774         * tui/tui-data.h (enum tui_bp_flag): New.
6775         (tui_bp_flags): New enum flags type.
6776         (struct tui_source_element) <break_mode>: Change type.  Rename
6777         from has_break.
6778         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6779         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6780         constants.
6781         * tui/tui-winsource.h: Fix comment.
6782
6783 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6784
6785         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6786         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6787         (store_fpregs_to_thread)
6788         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6789         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6790         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6791         (IWMMXT_REGS_SIZE): Add define.
6792         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6793         (fetch_vfp_regs, store_vfp_regs)
6794         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6795         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6796
6797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6798
6799         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6800         defines.
6801         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6802         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6803         (ARM_INT_REGISTER_SIZE): ...to this.
6804         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6805         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6806         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6807         (arm_linux_collect_gregset, supply_nwfpe_register)
6808         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6809         defines.
6810         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6811         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6812         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6813         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6814         (arm_return_in_memory, arm_store_return_value)
6815         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6816         (arm_record_ld_st_multiple): Likewise.
6817         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6818         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6819
6820 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6821
6822         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6823         AARCH64_DISPLACED_MODIFIED_INSNS.
6824         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6825         (aarch64_displaced_step_copy_insn): Likewise.
6826         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6827         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6828         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6829         ARM_DISPLACED_MODIFIED_INSNS.
6830         * arm-tdep.c (arm_gdbarch_init): Likewise.
6831         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6832         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6833         (struct arm_displaced_step_closure): Use
6834         ARM_DISPLACED_MODIFIED_INSNS.
6835
6836 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6837
6838         * features/Makefile: Remove unused xml files.
6839         * features/aarch64.xml: Remove.
6840         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6841         * features/i386/amd64-avx-avx512.xml: Remove.
6842         * features/i386/amd64-avx-linux.xml: Remove.
6843         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6844         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6845         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6846         * features/i386/amd64-avx-mpx.xml: Remove.
6847         * features/i386/amd64-avx.xml: Remove.
6848         * features/i386/amd64-linux.xml: Remove.
6849         * features/i386/amd64-mpx-linux.xml: Remove.
6850         * features/i386/amd64-mpx.xml: Remove.
6851         * features/i386/amd64.xml: Remove.
6852         * features/i386/i386-avx-avx512-linux.xml: Remove.
6853         * features/i386/i386-avx-avx512.xml: Remove.
6854         * features/i386/i386-avx-linux.xml: Remove.
6855         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6856         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6857         * features/i386/i386-avx-mpx-linux.xml: Remove.
6858         * features/i386/i386-avx-mpx.xml: Remove.
6859         * features/i386/i386-avx.xml: Remove.
6860         * features/i386/i386-linux.xml: Remove.
6861         * features/i386/i386-mmx-linux.xml: Remove.
6862         * features/i386/i386-mmx.xml: Remove.
6863         * features/i386/i386-mpx-linux.xml: Remove.
6864         * features/i386/i386-mpx.xml: Remove.
6865         * features/i386/i386.xml: Remove.
6866         * features/i386/x32-avx-avx512-linux.xml: Remove.
6867         * features/i386/x32-avx-linux.xml: Remove.
6868         * features/i386/x32-linux.xml: Remove.
6869
6870 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6871
6872         * regformats/aarch64.dat: Remove.
6873         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6874         * regformats/i386/amd64-avx-linux.dat: Remove.
6875         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6876         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6877         * regformats/i386/amd64-linux.dat: Remove.
6878         * regformats/i386/amd64-mpx-linux.dat: Remove.
6879         * regformats/i386/amd64.dat: Remove.
6880         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6881         * regformats/i386/i386-avx-linux.dat: Remove.
6882         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6883         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6884         * regformats/i386/i386-linux.dat: Remove.
6885         * regformats/i386/i386-mmx-linux.dat: Remove.
6886         * regformats/i386/i386-mpx-linux.dat: Remove.
6887         * regformats/i386/i386.dat: Remove.
6888         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6889         * regformats/i386/x32-avx-linux.dat: Remove.
6890         * regformats/i386/x32-linux.dat: Remove.
6891
6892 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6893
6894         * aarch64-tdep.c: Remove xml self tests.
6895         * amd64-linux-tdep.c: Likewise.
6896         * amd64-tdep.c: Likewise.
6897         * i386-linux-tdep.c: Likewise.
6898         * i386-tdep.c: Likewise.
6899
6900 2019-07-03  Pedro Alves  <palves@redhat.com>
6901
6902         PR cli/24732
6903         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6904         (pipe_cmd_option_defs): New.
6905         (make_pipe_cmd_options_def_group): New.
6906         (pipe_command): Use gdb::option::process_options.
6907         (pipe_command_completer): New function.
6908         (_initialize_cli_cmds): Install completer for "pipe" command.
6909
6910 2019-07-03  Pedro Alves  <palves@redhat.com>
6911
6912         * cli/cli-option.c (union option_value) <string>: New field.
6913         (struct option_def_and_value): Add ctor, move ctor, dtor and
6914         use DISABLE_COPY_AND_ASSIGN.
6915         (option_def_and_value::clear_value): New.
6916         (parse_option, save_option_value_in_ctx, get_val_type_str)
6917         (add_setshow_cmds_for_options): Handle var_string.
6918         * cli-option.h (union option_def::var_address) <string>: New
6919         field.
6920         (struct string_option_def): New.
6921         * maint-test-options.c (struct test_options_opts): Add default
6922         ctor and use DISABLE_COPY_AND_ASSIGN.
6923         <string_opt>: New field.
6924         (test_options_opts::~test_options_opts): New.
6925         (test_options_opts::dump): Also dump "-string".
6926         (test_options_option_defs): Install "string.
6927
6928 2019-07-03  Pedro Alves  <palves@redhat.com>
6929
6930         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6931         option_value with a null enumeration.
6932         (complete_options): Save the option values in the context.
6933         (save_option_value_in_ctx): New, factored out from ...
6934         (process_options): ... here.
6935         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6936         of the function.
6937         * maint-test-options.c (test_options_opts::dump): New, factored
6938         out from ...
6939         (maintenance_test_options_command_mode): ... here.
6940         (maintenance_test_options_command_completion_result): Delete.
6941         (maintenance_test_options_command_completion_text): Update
6942         comment.
6943         (maintenance_show_test_options_completion_result): Change
6944         prototype.  Just print
6945         maintenance_test_options_command_completion_text.
6946         (save_completion_result): New.
6947         (maintenance_test_options_completer_mode): Pass options context to
6948         complete_options, and then save a dump.
6949         (_initialize_maint_test_options): Use add_cmd to install "maint
6950         show test-options-completion-result".
6951
6952 2019-07-03  Pedro Alves  <palves@redhat.com>
6953
6954         * NEWS (New commands): Mention "with" and "maint with".
6955         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6956         (with_command, with_command_completer): New.
6957         (pipe_command): Adjust to new repeat_previous
6958         interface.
6959         (_initialize_cli_cmds): Install the "with" command and its "w"
6960         alias.
6961         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6962         declarations.
6963         * cli/cli-setshow.c (parse_cli_var_uinteger)
6964         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6965         argument strings for all var_types.
6966         (get_setshow_command_value_string): New, factored out from ...
6967         (do_show_command): ... this.
6968         * cli/cli-setshow.h: Include <string>.
6969         (get_setshow_command_value_string): Declare.
6970         * command.h (repeat_previous): Now returns const char *.  Adjust
6971         comment.
6972         * maint.c: Include "cli/cli-cmds.h".
6973         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6974         (_initialize_maint_cmds): Register the "maintenance with" command.
6975         * top.c (repeat_previous): Move bits from pipe_command here:
6976         Return the saved command line, if any; error out if there's no
6977         command to relaunch.
6978
6979 2019-07-03  Pedro Alves  <palves@redhat.com>
6980
6981         * NEWS (New commands): Mention "maint set/show test-settings"
6982         instead of "maint test-settings".
6983         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6984         (maintenance_test_settings_set_list): Rename to ...
6985         (maintenance_set_test_settings_list): ... this.
6986         (maintenance_test_settings_show_list): Rename to  ...
6987         (maintenance_show_test_settings_list): ... this.
6988         (maintenance_test_settings_cmd): Delete.
6989         (maintenance_test_settings_set_cmd): ...
6990         (maintenance_set_test_settings_cmd): ... this.
6991         (maintenance_test_settings_show_cmd): ...
6992         (maintenance_show_test_settings_cmd): ... this.
6993         (maintenance_test_settings_show_value_cmd):
6994         (maintenance_show_test_settings_value_cmd): ... this.
6995         (_initialize_maint_test_settings): No longer install the "maint
6996         test-settings" prefix command.  Rename "maint test-settings set"
6997         to "maint set test-settings", and "maint test-settings show" to
6998         "maint show test-settings".  Adjust all subcommands.
6999
7000 2019-07-03  Pedro Alves  <palves@redhat.com>
7001
7002         * maint-test-settings.c: Fix file's intro comment.  Replace all
7003         references to "test-options" with references to "test-settings",
7004         in comments.
7005
7006 2019-07-03  Pedro Alves  <palves@redhat.com>
7007
7008         * maint-test-settings.c (maintenance_test_settings_xxx)
7009         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7010         New.
7011         (maintenance_test_settings_enums): Use them.
7012         (maintenance_test_settings_enum): Default to
7013         maintenance_test_settings_xxx.
7014         (_initialize_maint_test_settings): Initialize
7015         MAINTENANCE_TEST_SETTINGS_FILENAME.
7016
7017 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7018
7019         * breakpoint.h (remove_breakpoints_inf): Change return type to
7020         void, move function documentation here.
7021         * breakpoint.c (remove_breakpoints_inf): Change return type to
7022         void, move function documentation to header.
7023
7024 2019-07-02  Pedro Alves  <palves@redhat.com>
7025
7026         * NEWS (Completion improvements): Mention "info threads".
7027         * thread.c (struct info_threads_opts, info_threads_option_defs)
7028         (make_info_threads_options_def_group): New.
7029         (info_threads_command): Use gdb::option::process_options.
7030         (info_threads_command_completer): New.
7031         (_initialize_thread): Use gdb::option::build_help to build the
7032         help text for "info threads".
7033
7034 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7035
7036         * defs.h (generic_load): Move from here...
7037         * symfile.h (generic_load): ... to here.  Rename name parameter
7038         to args.
7039         * symfile.c (generic_load): Add comment.
7040
7041 2019-07-01  Tom Tromey  <tromey@adacore.com>
7042
7043         * dwarf2read.c
7044         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7045         declaration of without_params.  Fix formatting.
7046
7047 2019-07-01  Tom Tromey  <tromey@adacore.com>
7048
7049         * ada-exp.y (find_primitive_type): Update.
7050         * ada-lang.h (ada_lookup_symbol): Update.
7051         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7052         parameter.
7053         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7054
7055 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7056
7057         PR breakpoints/24541
7058         * gdbarch.c: Regenerate.
7059         * gdbarch.h: Regenerate.
7060         * gdbarch.sh: Add 'stap_adjust_register'.
7061         * i386-tdep.c: Include '<unordered_set>'.
7062         (i386_stap_adjust_register): New function.
7063         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7064         * stap-probe.c (stap_parse_register_operand): Call
7065         'gdbarch_stap_adjust_register'.
7066
7067 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7068
7069         PR python/24742
7070         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7071         * python/python.c (do_start_initialization): Use 'xmalloc'
7072         instead of 'PyMem_Malloc'.
7073
7074 2019-06-28  Tom Tromey  <tromey@adacore.com>
7075
7076         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7077         for Ada.
7078
7079 2019-06-27  Tom Tromey  <tromey@adacore.com>
7080
7081         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7082         objfile_key.
7083         (arm_find_mapping_symbol, arm_record_special_symbol)
7084         (_initialize_arm_tdep): Update.
7085         (arm_objfile_data_free): Remove.
7086
7087 2019-06-27  Tom Tromey  <tromey@adacore.com>
7088
7089         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7090         to cp_print_static_field.
7091
7092 2019-06-26  Tom Tromey  <tromey@adacore.com>
7093
7094         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7095         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7096         declare.
7097
7098 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7099
7100         * features/aarch64-core.c (create_feature_aarch64_core):
7101         Regenerate.
7102         * features/aarch64-core.xml: Add cpsr flags.
7103
7104 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7105
7106         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7107         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7108
7109 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7110
7111         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7112         field.
7113         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7114         use.
7115         (arm_record_special_symbol): Don't insert new symbol in sorted
7116         position, push it at the end.
7117
7118 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7119
7120         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7121         (arm_mapping_symbol_s): Remove.
7122         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7123         (arm_mapping_symbol_vec): New typedef.
7124         (struct arm_per_objfile): Add constructor.
7125         <section_maps>: Change type to
7126         std::unique_ptr<arm_mapping_symbol_vec[]>.
7127         (arm_compare_mapping_symbols): Remove.
7128         (arm_find_mapping_symbol): Adjust to section_maps type change.
7129         (arm_objfile_data_free): Call delete on arm_per_objfile.
7130         (arm_record_special_symbol): Adjust to section_maps type change.
7131         Allocate arm_per_objfile with new.
7132
7133 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7134
7135         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7136         with the command prefix.
7137
7138 2019-06-25  Tom Tromey  <tom@tromey.com>
7139
7140         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7141         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7142
7143 2019-06-25  Tom Tromey  <tom@tromey.com>
7144
7145         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7146         type.
7147         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7148         protected.
7149
7150 2019-06-25  Tom Tromey  <tom@tromey.com>
7151
7152         * tui/tui-winsource.c
7153         (tui_source_window_base::set_is_exec_point_at): Add check against
7154         LOA_ADDRESS.
7155
7156 2019-06-25  Tom Tromey  <tom@tromey.com>
7157
7158         * tui/tui-source.c (tui_set_source_content): Don't check before
7159         xfree.
7160         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7161
7162 2019-06-25  Tom Tromey  <tom@tromey.com>
7163
7164         * tui/tui-winsource.h (tui_update_source_window_as_is)
7165         (tui_alloc_source_buffer, tui_line_is_displayed)
7166         (tui_addr_is_displayed): Change type of win_info.
7167         * tui/tui-winsource.c (tui_update_source_window_as_is)
7168         (tui_clear_source_content, tui_show_source_line)
7169         (tui_show_source_content, tui_source_window_base::refill)
7170         (tui_source_window_base::set_is_exec_point_at)
7171         (tui_source_window_base::set_is_exec_point_at)
7172         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7173         (tui_alloc_source_buffer, tui_line_is_displayed)
7174         (tui_addr_is_displayed): Change type of win_info.  Update.
7175         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7176         (tui_source_window_base::do_make_visible_with_new_height):
7177         Update.
7178         * tui/tui-source.c (tui_set_source_content)
7179         (tui_set_source_content_nil)
7180         (tui_source_window::do_scroll_vertical): Update.
7181         * tui/tui-layout.c (show_layout): Update.
7182         * tui/tui-disasm.c (tui_set_disassem_content)
7183         (tui_disasm_window::do_scroll_vertical): Update.
7184         * tui/tui-data.h (tui_win_content): Remove.
7185         (struct tui_gen_win_info) <content, content_size>: Remove.
7186         (struct tui_source_element): Add initializers and destructor.
7187         (union tui_which_element, struct tui_win_element): Remove.
7188         (struct tui_source_window_base) <content>: New field.
7189         (struct tui_data_window): Remove destructor.
7190         (tui_alloc_content, tui_free_win_content)
7191         (tui_free_all_source_wins_content): Don't declare.
7192         * tui/tui-data.c (tui_initialize_static_data): Update.
7193         (init_content_element, tui_alloc_content): Remove.
7194         (~tui_gen_win_info): Update.
7195         (~tui_data_window, tui_free_all_source_wins_content)
7196         (tui_free_win_content, free_content, free_content_elements):
7197         Remove.
7198
7199 2019-06-25  Tom Tromey  <tom@tromey.com>
7200
7201         * tui/tui-winsource.h (tui_clear_source_content)
7202         (tui_erase_source_content, tui_show_source_content): Change type
7203         of win_info.
7204         * tui/tui-winsource.c (tui_clear_source_content)
7205         (tui_erase_source_content, tui_show_source_content): Change type
7206         of win_info.
7207         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7208         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7209         win_info.
7210         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7211         win_info.
7212         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7213
7214 2019-06-25  Tom Tromey  <tom@tromey.com>
7215
7216         * tui/tui-winsource.c (tui_clear_source_content)
7217         (tui_source_window_base::set_is_exec_point_at): Update.
7218         * tui/tui-source.c (tui_set_source_content_nil): Update.
7219         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7220         a bool.
7221         * tui/tui-data.c (init_content_element): Update.
7222
7223 2019-06-25  Tom Tromey  <tom@tromey.com>
7224
7225         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7226         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7227         * tui/tui-layout.c (init_and_make_win): Update.
7228         * tui/tui.h (enum tui_win_type): Update.
7229         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7230         tui_win_is_auxillary.
7231         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7232         tui_win_is_auxillary.
7233
7234 2019-06-25  Tom Tromey  <tom@tromey.com>
7235
7236         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7237         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7238         (tui_delete_data_content_windows, tui_display_all_data)
7239         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7240         Update.
7241         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7242         * tui/tui-regs.c (tui_last_regs_line_no)
7243         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7244         (tui_show_registers): Update.
7245         (tui_show_register_group): Return void.  Update.
7246         (tui_display_registers_from, tui_display_reg_element_at_line)
7247         (tui_display_registers_from_line, tui_check_register_values):
7248         Update.
7249         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7250         member.
7251         (struct tui_data_window) <regs_content>: Now a std::vector.
7252         <regs_content_count>: Remove.
7253         (tui_add_content_elements, tui_free_data_content): Don't declare.
7254         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7255         (init_content_element): Remove DATA_WIN case.  Add assert.
7256         (tui_add_content_elements): Remove.
7257         (tui_data_window): Update.
7258         (tui_free_data_content): Remove.
7259         (free_content_elements): Remove DATA_WIN case.
7260
7261 2019-06-25  Tom Tromey  <tom@tromey.com>
7262
7263         * tui/tui-data.c (tui_data_item_window): Update.
7264         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7265         * tui/tui-windata.c (tui_display_all_data)
7266         (tui_display_data_from_line): Update.
7267         (tui_check_data_values): Remove.
7268         * tui/tui-regs.c (tui_show_register_group)
7269         (tui_display_reg_element_at_line): Update.
7270         * tui/tui-hooks.c (tui_register_changed)
7271         (tui_refresh_frame_and_register_information): Call
7272         tui_check_register_values.
7273         * tui/tui-data.h (struct tui_data_window) <data_content,
7274         data_content_count, data_type>: Remove.
7275         (enum tui_data_type): Remove.
7276
7277         * tui/tui-data.c (tui_data_window::clear_detail)
7278         (~tui_data_window): Update.
7279
7280 2019-06-25  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7283         declare.
7284         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7285         Rename from tui_first_data_item_displayed.  Update.
7286         (tui_data_window::refresh_all)
7287         (tui_data_window::do_scroll_vertical): Update.
7288         * tui/tui-data.h (struct tui_data_window)
7289         <first_data_item_displayed>: Declare new method.
7290
7291 2019-06-25  Tom Tromey  <tom@tromey.com>
7292
7293         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7294         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7295         contents...
7296         (tui_initialize_static_data): ...here.
7297
7298 2019-06-25  Tom Tromey  <tom@tromey.com>
7299
7300         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7301         (tui_display_registers_from, tui_check_register_values): Update.
7302         (tui_display_register): Remove win_info parameter; update.
7303         (tui_get_register): Change type of parameters.
7304         * tui/tui-data.h (struct tui_data_element): Remove.
7305         (union tui_which_element) <data>: Remove.
7306         <data_window>: Change type.
7307         (struct tui_data_item_window): New.
7308         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7309         case.  Add assert.
7310         (~tui_data_item_window): New destructor.
7311         (free_content_elements): Remove DATA_ITEM_WIN case.
7312
7313 2019-06-25  Tom Tromey  <tom@tromey.com>
7314
7315         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7316         Remove.
7317
7318 2019-06-25  Tom Tromey  <tom@tromey.com>
7319
7320         * tui/tui-data.h (struct tui_command_element): Remove.
7321         (union tui_which_element) <command>: Remove.
7322         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7323         assert.
7324         (free_content_elements): Remove CMD_WIN case.
7325
7326 2019-06-25  Tom Tromey  <tom@tromey.com>
7327
7328         * tui/tui-layout.c (tui_set_layout): Update.
7329         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7330         * tui/tui-data.c (layout_def): Update.
7331
7332 2019-06-25  Tom Tromey  <tom@tromey.com>
7333
7334         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7335         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7336         (tui_source_window_base::set_new_height): Update.
7337         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7338         Update.
7339         (tui_set_locator_fullname, tui_set_locator_info)
7340         (tui_show_frame_info): Update.
7341         * tui/tui-source.c (tui_set_source_content)
7342         (tui_source_is_displayed): Update.
7343         * tui/tui-layout.c (show_source_disasm_command, show_data)
7344         (show_source_or_disasm_and_command): Update.
7345         * tui/tui-disasm.c (tui_set_disassem_content)
7346         (tui_get_begin_asm_address): Update.
7347         * tui/tui-data.h (struct tui_locator_element): Remove.
7348         (union tui_which_element) <locator>: Remove.
7349         (struct tui_locator_window): New.
7350         (tui_locator_win_info_ptr): Change return type.
7351         * tui/tui-data.c (_locator): Change type.
7352         (tui_locator_win_info_ptr): Change return type.
7353         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7354         (tui_alloc_content): Add assert.
7355
7356 2019-06-25  Tom Tromey  <tom@tromey.com>
7357
7358         * tui/tui-winsource.c
7359         (tui_exec_info_window::maybe_allocate_content): New method.
7360         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7361         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7362         (make_source_or_disasm_window): Add cast.
7363         * tui/tui-data.h (union tui_which_element) <simple_string>:
7364         Remove.
7365         (struct tui_source_info): New.
7366         (struct tui_source_window_base) <execution_info>: Change type.
7367         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7368         case, and add assert.
7369         (tui_alloc_content): Add assert.
7370
7371 2019-06-25  Tom Tromey  <tom@tromey.com>
7372
7373         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7374         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7375         * tui/tui-data.c (tui_alloc_win_info): Remove.
7376
7377 2019-06-25  Tom Tromey  <tom@tromey.com>
7378
7379         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7380         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7381         can_highlight.
7382
7383 2019-06-25  Tom Tromey  <tom@tromey.com>
7384
7385         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7386         make_visible_with_new_height method.
7387         (tui_win_info::make_visible_with_new_height): New method.
7388         (tui_source_window_base::do_make_visible_with_new_height)
7389         (tui_data_window::do_make_visible_with_new_height)
7390         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7391         (make_visible_with_new_height): Remove.
7392         (tui_resize_all, tui_adjust_win_heights): Use
7393         make_visible_with_new_height method.
7394         * tui/tui-data.h (struct tui_win_info)
7395         <do_make_visible_with_new_height, make_visible_with_new_height>:
7396         New methods.
7397         (struct tui_source_window_base, struct tui_data_window)
7398         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7399         methods.
7400
7401 2019-06-25  Tom Tromey  <tom@tromey.com>
7402
7403         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7404         method.
7405         (update_tab_width): Call update_tab_width method.
7406         * tui/tui-data.h (struct tui_win_info)
7407         (struct tui_source_window_base) <update_tab_width>: New methods.
7408
7409 2019-06-25  Tom Tromey  <tom@tromey.com>
7410
7411         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7412         parameter.
7413         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7414         parameter.
7415         (tui_gen_win_info::make_visible): Update.
7416         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7417         parameter.
7418         * tui/tui-data.h (enum tui_box): New enum.
7419         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7420
7421 2019-06-25  Tom Tromey  <tom@tromey.com>
7422
7423         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7424         init_and_make_win for EXEC_INFO_WIN.
7425         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7426         longer inline.
7427         (struct tui_win_info) <~tui_win_info>: Inline.
7428         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7429         Don't declare.
7430         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7431         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7432         Remove.
7433         (tui_initialize_static_data): Update.
7434         (~tui_gen_win_info): Handle more cleanup here.
7435         (~tui_source_window_base): Delete "execution_info".
7436         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7437
7438 2019-06-25  Tom Tromey  <tom@tromey.com>
7439
7440         * tui/tui-layout.c (make_command_window): Don't set
7441         can_highlight.
7442         (show_source_disasm_command): Call the reset method.
7443         (show_data): Don't set can_highlight.  Call the reset method.
7444         (tui_gen_win_info::reset): Rename from init_gen_win_info
7445         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7446         (show_source_or_disasm_and_command): Call the reset method.
7447         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7448         (struct tui_cmd_window): Set can_highlight.
7449
7450 2019-06-25  Tom Tromey  <tom@tromey.com>
7451
7452         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7453         from make_visible.
7454         (tui_make_visible, tui_make_invisible): Rewrite.
7455         (tui_win_info::make_visible): Remove.
7456         (tui_source_window_base::make_visible): Update.
7457         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7458         method.  Moved from...
7459         (struct tui_win_info) <make_visible>: ...here.
7460
7461 2019-06-25  Tom Tromey  <tom@tromey.com>
7462
7463         * tui/tui-winsource.c
7464         (tui_source_window_base::do_scroll_horizontal): Remove direction
7465         parameter.
7466         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7467         direction parameter.
7468         * tui/tui-win.c (tui_win_info::forward_scroll)
7469         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7470         (tui_win_info::right_scroll): Update.
7471         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7472         direction parameter.
7473         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7474         direction parameter.
7475         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7476         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7477         Remove direction parameter.
7478         (struct tui_source_window_base, struct tui_source_window)
7479         (struct tui_disasm_window, struct tui_data_window)
7480         (struct tui_cmd_window): Update.
7481
7482 2019-06-25  Tom Tromey  <tom@tromey.com>
7483
7484         * tui/tui-winsource.h (tui_set_exec_info_content)
7485         (tui_show_exec_info_content, tui_erase_exec_info_content)
7486         (tui_clear_exec_info_content, tui_update_exec_info): Change
7487         argument to tui_source_window_base.
7488         * tui/tui-winsource.c (tui_set_exec_info_content)
7489         (tui_show_exec_info_content, tui_erase_exec_info_content)
7490         (tui_clear_exec_info_content, tui_update_exec_info): Change
7491         argument to tui_source_window_base.
7492
7493 2019-06-25  Tom Tromey  <tom@tromey.com>
7494
7495         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7496         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7497
7498 2019-06-25  Tom Tromey  <tom@tromey.com>
7499
7500         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7501         check.
7502
7503 2019-06-25  Tom Tromey  <tom@tromey.com>
7504
7505         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7506         type to void.
7507         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7508         type to void.
7509         * tui/tui-source.c (tui_set_source_content): Update.
7510         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7511
7512 2019-06-25  Tom Tromey  <tom@tromey.com>
7513
7514         * tui/tui-win.c (window_name_completer, tui_set_focus)
7515         (tui_all_windows_info): Use name method.
7516         * tui/tui-data.h (struct tui_gen_win_info)
7517         (struct tui_source_window, struct tui_disasm_window)
7518         (struct tui_data_window, struct tui_cmd_window) <name>: New
7519         method.
7520         (tui_win_name): Don't declare.
7521         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7522         (tui_win_name): Remove.
7523
7524 2019-06-25  Tom Tromey  <tom@tromey.com>
7525
7526         * tui/tui-winsource.h (tui_update_source_window)
7527         (tui_update_source_window_as_is): Change parameter type.
7528         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7529         to be a tui_source_window_base.
7530         (tui_update_source_window_as_is): Likewise.
7531         * tui/tui-win.c (make_visible_with_new_height): Update.
7532
7533 2019-06-25  Tom Tromey  <tom@tromey.com>
7534
7535         * tui/tui-winsource.c (tui_erase_source_content)
7536         (tui_show_source_content, tui_show_exec_info_content)
7537         (tui_erase_exec_info_content): Use refresh_window method.
7538         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7539         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7540         from tui_refresh_win.
7541         (tui_data_window::refresh_window): New method.
7542         (tui_win_info::refresh, tui_source_window_base::refresh)
7543         (tui_refresh_all): Use refresh_window method.
7544         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7545         method.
7546         * tui/tui-regs.c (tui_display_register): Call refresh_window
7547         method.
7548         * tui/tui-layout.c (show_source_disasm_command)
7549         (show_source_or_disasm_and_command): Call refresh_window method.
7550         * tui/tui-data.h (struct tui_gen_win_info)
7551         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7552         New method.
7553
7554 2019-06-25  Tom Tromey  <tom@tromey.com>
7555
7556         * tui/tui.c (tui_rl_other_window, tui_enable)
7557         (tui_is_window_visible, tui_get_command_dimension): Update.
7558         * tui/tui-winsource.c (tui_update_source_window_as_is)
7559         (tui_clear_source_content, tui_erase_source_content)
7560         (tui_show_source_line, tui_source_window_base::refill)
7561         (tui_source_window_base::do_scroll_horizontal)
7562         (tui_source_window_base::set_is_exec_point_at)
7563         (tui_update_breakpoint_info, tui_set_exec_info_content)
7564         (tui_alloc_source_buffer, tui_line_is_displayed)
7565         (tui_addr_is_displayed): Update.
7566         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7567         (tui_check_and_display_highlight_if_needed)
7568         (tui_win_info::make_visible, tui_win_info::refresh)
7569         (tui_refresh_all): Update.
7570         * tui/tui-windata.c (tui_first_data_item_displayed)
7571         (tui_delete_data_content_windows, tui_erase_data_content)
7572         (tui_display_all_data, tui_data_window::refresh_all)
7573         (tui_check_data_values): Update.
7574         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7575         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7576         (tui_win_info::backward_scroll, tui_refresh_all_win)
7577         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7578         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7579         (tui_source_window_base::set_new_height)
7580         (tui_data_window::set_new_height)
7581         (make_invisible_and_set_new_height)
7582         (make_visible_with_new_height, new_height_ok)
7583         (parse_scrolling_args): Update.
7584         * tui/tui-stack.c (tui_show_frame_info): Update.
7585         * tui/tui-source.c (tui_set_source_content)
7586         (tui_set_source_content_nil, tui_source_is_displayed)
7587         (tui_source_window::do_scroll_vertical): Update.
7588         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7589         (tui_display_registers_from, tui_display_reg_element_at_line)
7590         (tui_check_register_values, tui_reg_command): Update.
7591         * tui/tui-layout.c (tui_default_win_height)
7592         (show_source_disasm_command, show_data, init_and_make_win)
7593         (show_source_or_disasm_and_command): Update.
7594         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7595         (tui_redisplay_readline, tui_mld_flush)
7596         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7597         (tui_getc): Update.
7598         * tui/tui-disasm.c (tui_set_disassem_content)
7599         (tui_disasm_window::do_scroll_vertical): Update.
7600         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7601         Now virtual.
7602         (struct tui_win_info): Derive from tui_gen_win_info.
7603         <~tui_win_info>: Mark as override.
7604         <generic>: Remove member.
7605         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7606         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7607         (~tui_data_window, ~tui_win_info)
7608         (tui_free_all_source_wins_content): Update.
7609         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7610
7611 2019-06-25  Tom Tromey  <tom@tromey.com>
7612
7613         * tui/tui-layout.c (init_and_make_win): Use new.
7614         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7615         destructor, initializers.
7616         (tui_alloc_generic_win_info): Don't declare.
7617         * tui/tui-data.c (_locator): Add argument to constructor.
7618         (source_win, disasm_win): New globals.
7619         (exec_info): Remove.
7620         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7621         Update.
7622         (tui_alloc_generic_win_info): Remove.
7623         (init_content_element): Use new.
7624         (tui_win_info::tui_win_info): Update.
7625         (free_content_elements) <case DATA_WIN>: Use delete.
7626
7627 2019-06-25  Tom Tromey  <tom@tromey.com>
7628
7629         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7630         * tui/tui-windata.c (tui_first_data_item_displayed)
7631         (tui_delete_data_content_windows): Update.
7632         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7633         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7634         (tui_display_registers_from, tui_check_register_values): Update.
7635         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7636         pointer.
7637         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7638         window.
7639         (tui_free_data_content): Update.
7640         (free_content_elements) <case DATA_WIN>: Free the window.
7641
7642 2019-06-25  Tom Tromey  <tom@tromey.com>
7643
7644         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7645         Update.
7646         * tui/tui-layout.c (make_command_window)
7647         (show_source_disasm_command, show_data, init_and_make_win)
7648         (show_source_or_disasm_and_command): Update.
7649         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7650         method.
7651         <can_highight, is_highlighted>: Now bool.
7652         (tui_set_win_highlight): Don't declare.
7653         * tui/tui-data.c (tui_set_win_highlight): Remove.
7654
7655 2019-06-25  Tom Tromey  <tom@tromey.com>
7656
7657         * tui/tui-wingeneral.c (make_visible): Remove check of window
7658         type.
7659
7660 2019-06-25  Tom Tromey  <tom@tromey.com>
7661
7662         * tui/tui-win.c (tui_win_info::max_height)
7663         (tui_cmd_window::max_height): New methods.
7664         (new_height_ok): Call max_height.
7665         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7666         <max_height>: New method.
7667
7668 2019-06-25  Tom Tromey  <tom@tromey.com>
7669
7670         * tui/tui-win.c (tui_source_window_base::set_new_height)
7671         (tui_data_window::set_new_height): New methods.
7672         (make_invisible_and_set_new_height): Call set_new_height method.
7673         * tui/tui-data.h (struct tui_win_info)
7674         (struct tui_source_window_base, struct tui_data_window)
7675         <set_new_height>: New method.
7676
7677 2019-06-25  Tom Tromey  <tom@tromey.com>
7678
7679         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7680         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7681         tui_refresh_data_win.
7682         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7683         method.
7684         (tui_refresh_all_win): Call the refresh_all method.
7685         (tui_set_focus): Likewise.
7686         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7687         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7688         Likewise.
7689
7690 2019-06-25  Tom Tromey  <tom@tromey.com>
7691
7692         * tui/tui-winsource.h (tui_refill_source_window)
7693         (tui_set_is_exec_point_at): Don't declare.
7694         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7695         (tui_source_window_base::refill): Rename from
7696         tui_refill_source_window.
7697         (tui_source_window_base::do_scroll_horizontal): Update.
7698         (tui_source_window_base::set_is_exec_point_at): Rename from
7699         tui_set_is_exec_point_at.
7700         (tui_update_all_breakpoint_info): Update.
7701         * tui/tui-stack.c (tui_show_frame_info): Update.
7702         * tui/tui-layout.c (show_data): Add cast.
7703         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7704         * tui/tui-data.h (struct tui_source_window_base) <refill,
7705         set_is_exec_point_at>: New methods.
7706         (tui_source_windows, tui_add_to_source_windows): Update types.
7707         (tui_add_to_source_windows): Remove redundant declaration.
7708         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7709         (tui_source_windows): Change return type.
7710         (tui_clear_source_windows_detail): Update.
7711         (tui_add_to_source_windows): Change type of parameter.
7712         (tui_free_all_source_wins_content): Update.
7713
7714 2019-06-25  Tom Tromey  <tom@tromey.com>
7715
7716         * tui/tui-wingeneral.c (tui_win_info::refresh)
7717         (tui_source_window_base::refresh): New methods.
7718         (tui_refresh_all): Call the refresh method.
7719         * tui/tui-data.h (struct tui_win_info)
7720         (struct tui_source_window_base) <refresh>: New method.
7721
7722 2019-06-25  Tom Tromey  <tom@tromey.com>
7723
7724         * tui/tui.h (tui_is_window_visible): Return bool.
7725         * tui/tui.c (tui_is_window_visible): Return bool.
7726         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7727         (tui_make_visible, tui_make_invisible)
7728         (tui_win_info::make_visible)
7729         (tui_source_window_base::make_visible, make_all_visible)
7730         (tui_make_all_visible, tui_make_all_invisible): Update.
7731         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7732         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7733         bool.
7734         (struct tui_win_info, struct tui_source_window_base)
7735         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7736         * tui/tui-data.c (tui_init_generic_part): Update.
7737
7738 2019-06-25  Tom Tromey  <tom@tromey.com>
7739
7740         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7741         (tui_source_window_base::make_visible): New methods.
7742         (make_all_visible): Make method call.
7743         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7744         (struct tui_source_window_base, struct tui_cmd_window): Override
7745         make_visible.
7746         (tui_win_is_source_type): Don't declare.
7747         * tui/tui-data.c (tui_win_is_source_type): Remove.
7748
7749 2019-06-25  Tom Tromey  <tom@tromey.com>
7750
7751         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7752         NULL check.
7753
7754 2019-06-25  Tom Tromey  <tom@tromey.com>
7755
7756         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7757         Inline constructor.  Add initializers for members.
7758         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7759         constructors; now inline in class.
7760
7761 2019-06-25  Tom Tromey  <tom@tromey.com>
7762
7763         * tui/tui-regs.c (tui_show_registers): Update.
7764         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7765         bool.
7766         * tui/tui-data.c (tui_data_window::clear_detail)
7767         (tui_data_window): Update.
7768
7769 2019-06-25  Tom Tromey  <tom@tromey.com>
7770
7771         * tui/tui-windata.c (tui_display_all_data)
7772         (tui_display_data_from_line, tui_display_data_from)
7773         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7774         Update.
7775         * tui/tui-regs.c (tui_last_regs_line_no)
7776         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7777         (tui_show_registers, tui_show_register_group)
7778         (tui_display_registers_from, tui_display_reg_element_at_line)
7779         (tui_display_registers_from_line, tui_check_register_values)
7780         (tui_reg_next, tui_reg_prev): Update.
7781         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7782         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7783         tui_data_window.
7784         (struct tui_win_info) <detail>: Remove.  Add new fields from
7785         tui_data_info.
7786         (TUI_DATA_WIN): Add cast.
7787         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7788         (~tui_data_window): Simplify.
7789
7790 2019-06-25  Tom Tromey  <tom@tromey.com>
7791
7792         * tui/tui-layout.c (show_source_disasm_command)
7793         (show_source_or_disasm_and_command): Update.
7794         * tui/tui-io.c (update_cmdwin_start_line)
7795         (tui_redisplay_readline): Update.
7796         * tui/tui-data.h (struct tui_command_info): Remove.
7797         (struct tui_win_info) <detail>: Remove command_info member.
7798         (struct tui_data_window) <start_line>: New member, from
7799         tui_command_info.
7800         (TUI_CMD_WIN): Add casts.
7801
7802 2019-06-25  Tom Tromey  <tom@tromey.com>
7803
7804         * tui/tui-winsource.c (tui_update_source_window)
7805         (tui_refill_source_window)
7806         (tui_source_window_base::do_scroll_horizontal)
7807         (tui_update_breakpoint_info, tui_set_exec_info_content)
7808         (tui_show_exec_info_content, tui_erase_exec_info_content)
7809         (tui_clear_exec_info_content): Update.
7810         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7811         Update.
7812         * tui/tui-win.c (make_invisible_and_set_new_height)
7813         (make_visible_with_new_height): Update.
7814         * tui/tui-source.c (tui_set_source_content)
7815         (tui_show_symtab_source): Update.
7816         * tui/tui-layout.c (extract_display_start_addr)
7817         (show_source_disasm_command, show_data)
7818         (make_source_or_disasm_window)
7819         (show_source_or_disasm_and_command): Update.
7820         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7821         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7822         "gdbarch".
7823         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7824         to tui_source_window_base.
7825         (struct tui_win_info) <detail>: Remove source_info member.
7826         (struct tui_source_window_base) <has_locator>: Inline.
7827         Move contents from tui_source_info; rename has_locator member to
7828         m_has_locator.
7829         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7830         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7831         header file.
7832         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7833         Simplify.
7834         (tui_free_all_source_wins_content): Cast to
7835         tui_source_window_base.
7836
7837 2019-06-25  Tom Tromey  <tom@tromey.com>
7838
7839         * tui/tui-win.c (make_invisible_and_set_new_height)
7840         (make_visible_with_new_height): Call has_locator method.
7841         * tui/tui-layout.c (show_source_disasm_command, show_data)
7842         (show_source_or_disasm_and_command): Update for bool change.
7843         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7844         (tui_win_info) <has_locator>: New method.
7845         (struct tui_source_window_base) <has_locator>: New method.
7846         (tui_win_has_locator): Don't declare.
7847         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7848         from tui_win_has_locator.
7849         (tui_source_window_base): Use false, not FALSE.
7850
7851 2019-06-25  Tom Tromey  <tom@tromey.com>
7852
7853         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7854         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7855         clear_detail method directly.
7856         (tui_clear_win_detail): Remove.
7857
7858 2019-06-25  Tom Tromey  <tom@tromey.com>
7859
7860         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7861         "this", not TUI_DISASM_WIN.
7862
7863 2019-06-25  Tom Tromey  <tom@tromey.com>
7864
7865         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7866         declare.
7867         * tui/tui-winsource.c
7868         (tui_source_window_base::do_scroll_horizontal): Rename from
7869         tui_horizontal_source_scroll.
7870         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7871         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7872         from tui_vertical_data_scroll.
7873         * tui/tui-win.h (tui_scroll): Don't declare.
7874         * tui/tui-win.c (tui_win_info::forward_scroll)
7875         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7876         (tui_win_info::right_scroll): Rename and update.
7877         (tui_scroll_forward_command, tui_scroll_backward_command)
7878         (tui_scroll_left_command, tui_scroll_right_command): Update.
7879         (tui_scroll): Remove.
7880         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7881         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7882         from tui_vertical_source_scroll.
7883         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7884         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7885         from tui_vertical_disassem_scroll.
7886         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7887         do_scroll_horizontal>: New methods.
7888         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7889         Likewise.
7890         (struct tui_source_window_base): Add do_scroll_horizontal.
7891         (struct tui_source_window, struct tui_disasm_window): Add
7892         do_scroll_vertical.
7893         (struct tui_data_window, struct tui_cmd_window): Add
7894         do_scroll_horizontal and do_scroll_vertical.
7895         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7896
7897 2019-06-25  Tom Tromey  <tom@tromey.com>
7898
7899         * tui/tui-data.h (struct tui_source_window_base): New struct.
7900         (struct tui_source_window): Derive from tui_source_window_base.
7901         (struct tui_disasm_window): New struct.
7902         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7903         from tui_source_window::clear_detail.
7904         (tui_source_window_base): Rename from tui_source_window.
7905         (~tui_source_window_base): Rename from ~tui_source_window.
7906         (tui_alloc_win_info): Create a tui_disasm_window.
7907
7908 2019-06-25  Tom Tromey  <tom@tromey.com>
7909
7910         * tui/tui-data.h (struct tui_source_window)
7911         (struct tui_data_window): Declare destructors.
7912         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7913         destructors.
7914         (tui_win_info): Simplify.
7915
7916 2019-06-25  Tom Tromey  <tom@tromey.com>
7917
7918         * tui/tui-winsource.c (tui_display_main)
7919         (tui_update_source_windows_with_addr)
7920         (tui_update_all_breakpoint_info): Update.
7921         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7922         (new_height_ok, parse_scrolling_args): Update.
7923         * tui/tui-stack.c (tui_show_frame_info): Update.
7924         * tui/tui-data.h (struct tui_list): Remove.
7925         (tui_source_windows): Return a reference to a std::vector.
7926         * tui/tui-data.c (source_windows): Now a std::vector.
7927         (tui_source_windows): Change return type.
7928         (tui_clear_source_windows): Rewrite.
7929         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7930         (tui_free_all_source_wins_content): Rewrite.
7931
7932 2019-06-25  Tom Tromey  <tom@tromey.com>
7933
7934         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7935         (struct tui_data_window, struct tui_cmd_window): Declare
7936         clear_detail method.
7937         * tui/tui-data.c (tui_source_window::clear_detail)
7938         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7939         methods.
7940         (tui_clear_win_detail): Simplify.
7941
7942 2019-06-25  Tom Tromey  <tom@tromey.com>
7943
7944         * tui/tui-layout.c (make_source_window, make_disasm_window)
7945         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7946         Return the new window.
7947         (show_source_disasm_command, show_data)
7948         (show_source_or_disasm_and_command): Update.
7949
7950 2019-06-25  Tom Tromey  <tom@tromey.com>
7951
7952         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7953         parameter.  Return the new window.
7954         (show_source_disasm_command): Update and remove NULL check.
7955         (show_source_or_disasm_and_command): Update.
7956
7957 2019-06-25  Tom Tromey  <tom@tromey.com>
7958
7959         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7960
7961 2019-06-25  Tom Tromey  <tom@tromey.com>
7962
7963         * tui/tui-data.h (struct tui_win_info): Make constructor
7964         protected.  Make destructor virtual.  Add initializers.
7965         (tui_source_window, tui_data_window, tui_cmd_window): New
7966         classes.
7967         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7968         constructor.  Add "type" parameter.
7969         (tui_source_window, tui_data_window, tui_cmd_window): New
7970         constructors.
7971         (tui_alloc_win_info): Instantiate the appropriate subclass.
7972
7973 2019-06-25  Tom Tromey  <tom@tromey.com>
7974
7975         * tui/tui-win.c (tui_resize_all): Use delete.
7976         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7977         destructor.
7978         (tui_free_window): Don't declare.
7979         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7980         Update.
7981
7982 2019-06-25  Tom Tromey  <tom@tromey.com>
7983
7984         * tui/tui-data.h (struct tui_win_info): Add constructor.
7985         * tui/tui-data.c (tui_alloc_win_info): Use new.
7986         (tui_free_window): Use delete.
7987
7988 2019-06-22  Tom Tromey  <tom@tromey.com>
7989
7990         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7991         declare.
7992         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7993
7994 2019-06-22  Tom Tromey  <tom@tromey.com>
7995
7996         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7997         declare.
7998         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7999
8000 2019-06-22  Tom de Vries  <tdevries@suse.de>
8001
8002         * dwarf2read.c (create_addrmap_from_aranges)
8003         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8004         instead of '%zu'.
8005
8006 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8007
8008         * dwarf2read.h (dwarf2_section_info_def): Remove.
8009         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8010         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8011         std::vector<dwarf2_section_info>.
8012         (struct dwo_file) <~dwo_file>: Remove.
8013         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8014         types field.
8015         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8016         (dwarf2_read_debug_names): Likewise.
8017         (create_debug_types_hash_table): Change parameter type to
8018         array_view, adjust code accordingly.
8019         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8020         (partial_die_info::fixup): Likewise.
8021         (determine_prefix): Likewise.
8022         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8023
8024 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8025
8026         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8027         gdb_bfd_ref_ptr.
8028         <~dwo_file>: Remove call to gdb_bfd_unref.
8029         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8030         gdb_bfd_ref_ptr::get.
8031
8032 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8033
8034         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8035         type to htab_up.
8036         * dwarf2read.c (struct dwo_file): Initialize fields.
8037         <~dwo_file>: New.
8038         (free_dwo_file): Remove, move content to ~dwo_file.
8039         (struct dwo_file_deleter): Remove.
8040         (dwo_file_up>: Remove custom deleter.
8041         (free_dwo_files): Remove.
8042         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8043         dwo_files.
8044         (process_skeletonless_type_units): Call unique_ptr::get.
8045         (allocate_dwo_file_hash_table): Add deleter to created hash
8046         table.  Change return type to htab_up.
8047         (lookup_dwo_file_slot): Don't memset dwo_file, call
8048         unique_ptr::get.
8049         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8050         (create_dwo_unit_in_dwp_v2): Likewise.
8051         (open_and_init_dwo_file): Likewise.
8052         (free_dwo_file_from_slot): Remove.
8053
8054 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8055
8056         * dwarf2read.h (struct dwarf2_section_info) <readin,
8057         is_virtual>: Change type to bool.
8058         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8059         true instead of 1.
8060
8061 2019-06-19  Tom Tromey  <tom@tromey.com>
8062
8063         * tui/tui-data.h (tui_init_content_element): Don't declare.
8064
8065 2019-06-19  Tom Tromey  <tom@tromey.com>
8066
8067         * tui/tui-data.h (tui_init_win_info): Don't declare.
8068
8069 2019-06-19  Tom de Vries  <tdevries@suse.de>
8070
8071         * dwarf2read.h (abstract_to_concrete): Change type to
8072         std::unordered_map<sect_offset, std::vector<sect_offset>,
8073         gdb::hash_enum<sect_offset>>.
8074
8075 2019-06-19  Tom Tromey  <tromey@adacore.com>
8076
8077         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8078         EVAL_AVOID_SIDE_EFFECTS specially.
8079
8080 2019-06-19  Tom Tromey  <tromey@adacore.com>
8081
8082         * source-cache.c (highlighter): New global.
8083         (source_cache::get_source_lines): Create a highlighter on demand.
8084
8085 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8086
8087         * defs.h (deprecated_interactive_hook): Delete declaration.
8088         * interps.c (clear_interpreter_hooks): Remove use of
8089         deprecated_interactive_hook.
8090         * top.c (deprecated_interactive_hook): Delete definition.
8091         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8092
8093 2019-06-18  Tom de Vries  <tdevries@suse.de>
8094
8095         PR gdb/24515
8096         * dwarf2read.h (abstract_to_concrete): Change type from
8097         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8098         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8099         * dwarf2read.c (read_variable): Update.
8100         (dwarf2_fetch_die_loc_sect_off): Update.
8101
8102 2019-06-17  Tom de Vries  <tdevries@suse.de>
8103
8104         PR gdb/24617
8105         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8106         accessing parent[parent_len - 1].
8107
8108 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8109
8110         PR gdb/24364
8111         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8112         call dtrace_process_dof with NULL dof.
8113
8114 2019-06-16  Tom de Vries  <tdevries@suse.de>
8115
8116         PR gdb/24445
8117         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8118
8119 2019-06-16  Tom Tromey  <tom@tromey.com>
8120
8121         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8122         (make_all_visible): Use address of member.
8123
8124 2019-06-16  Tom Tromey  <tom@tromey.com>
8125
8126         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8127         (tui_free_window, free_content, free_content_elements): Remove
8128         unnecessary cast.
8129         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8130         cast.
8131         * tui/tui-regs.c (tui_show_register_group)
8132         (tui_display_registers_from, tui_display_reg_element_at_line):
8133         Remove unnecessary cast.
8134
8135 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * linux-nat.c (normal_mask): Delete.
8138         (_initialize_linux_nat): Don't initialise normal_mask.
8139
8140 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8141
8142         PR gdb/24445
8143         * dwarf-index-write.h (write_psymtabs_to_index): Add
8144         dwz_basename parameter.
8145         * dwarf-index-write.c (write_gdbindex): Move file writing to
8146         write_gdbindex_1.  Change return type void.
8147         (assert_file_size): Move up, remove filename parameter.
8148         (write_gdbindex_1): New function.
8149         (write_debug_names): Change return type to void, call
8150         assert_file_size.
8151         (struct index_wip_file): New struct.
8152         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8153         file logic to index_wip_file.  Write index for dwz file if
8154         needed.
8155         (save_gdb_index_command): Pass basename of dwz file, if present.
8156         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8157         build-id of dwz file, if present.
8158         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8159         (dwarf2_get_dwz_file): Likewise.
8160         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8161         (dwarf2_get_dwz_file): Likewise.
8162
8163 2019-06-16  Tom Tromey  <tom@tromey.com>
8164
8165         * coffread.c (process_coff_symbol): Use xstrdup.
8166         * value.c (create_internalvar): Use xstrdup.
8167
8168 2019-06-16  Tom Tromey  <tom@tromey.com>
8169
8170         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8171         * breakpoint.c (stopin_command, stopat_command)
8172         (until_break_command, decode_location_default): Remove unnecessary
8173         cast.
8174         * utils.c (subset_compare): Remove unnecessary cast.
8175         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8176         cast.
8177         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8178         cast.
8179         * infcmd.c (path_command): Remove unnecessary cast.
8180         * coffread.c (decode_type): Remove unnecessary cast.
8181         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8182         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8183         * tui/tui-stack.c (tui_show_locator_content)
8184         (tui_show_frame_info): Remove unnecessary cast.
8185         * tui/tui-win.c (tui_scroll_forward_command)
8186         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8187         (parse_scrolling_args): Remove unnecessary cast.
8188         * tui/tui-data.c (init_win_info, tui_del_window)
8189         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8190         (free_content_elements): Remove unnecessary cast.
8191         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8192         unnecessary cast.
8193         * tui/tui-source.c (tui_set_source_content)
8194         (tui_vertical_source_scroll): Remove unnecessary cast.
8195         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8196         cast.
8197         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8198         * tui/tui-regs.c (tui_display_registers_from)
8199         (tui_display_register): Remove unnecessary cast.
8200         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8201         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8202         (make_visible): Remove unnecessary cast.
8203         * tui/tui-winsource.c (tui_erase_source_content)
8204         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8205         unnecessary cast.
8206         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8207         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8208         * stabsread.c (read_type, read_array_type, read_range_type):
8209         Remove unnecessary cast.
8210         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8211         (parse_symbol, parse_type, upgrade_type, parse_external)
8212         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8213         unnecessary cast.
8214         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8215
8216 2019-06-16  Tom Tromey  <tom@tromey.com>
8217
8218         * tui/tui-data.c (tui_alloc_generic_win_info)
8219         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8220         checks.
8221
8222 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8223             Andrew Burgess  <andrew.burgess@embecosm.com>
8224
8225         * f-typeprint.c (f_print_type): Don't return early for not
8226         associated or not allocated types.
8227         (f_type_print_varspec_suffix): Add print_rank parameter and print
8228         ranks of array types in case they dangling.
8229         (f_type_print_base): Add print_rank parameter.
8230
8231 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * NEWS: Mention new MI commands.
8234         * break-catch-throw.c (enum exception_event_kind): Move to
8235         breakpoint.h.
8236         (print_mention_exception_catchpoint): Output text as a single
8237         message.
8238         (catch_exception_command_1): Rename to...
8239         (catch_exception_event): ...this, make non-static, update header
8240         command, and change some parameter types.
8241         (catch_catch_command): Update for changes to
8242         catch_exception_command_1.
8243         (catch_throw_command): Likewise.
8244         (catch_rethrow_command): Likewise.
8245         * breakpoint.c (enum exception_event_kind): Delete.
8246         * breakpoint.h (enum exception_event_kind): Moved here from
8247         break-catch-throw.c.
8248         (catch_exception_event): Declare.
8249         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8250         (mi_cmd_catch_throw): New function.
8251         (mi_cmd_catch_rethrow): New function.
8252         (mi_cmd_catch_catch): New function.
8253         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8254         'catch-catch' entries.
8255         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8256         (mi_cmd_catch_rethrow): Declare.
8257         (mi_cmd_catch_catch): Declare.
8258
8259 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8260
8261         * annotate.c (annotate_source_line): Change return type to void,
8262         update implementation to match.
8263         * annotate.h (annotate_source_line): Change return type to void,
8264         update header comment.
8265         * stack.c (print_frame_info): Don't change what frame information
8266         is printed based on whether annotations are on or not.
8267
8268 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8271         (annotate_source): Make static.
8272         (annotate_source_line): Moved from source.c and renamed from
8273         identify_source_line.  Update the return type.
8274         * annotate.h (annotate_source): Delete declaration.
8275         (annotate_source_line): Declaration moved from source.h, and
8276         renamed from identify_source_line.  Return type updated.
8277         * source.c (identify_source_line): Moved to annotate.c and renamed
8278         to annotate_source_line.
8279         (info_line_command): Remove check of annotation_level.
8280         * source.h (identify_source_line): Move declaration to annotate.h
8281         and rename to annotate_source_line.
8282         * stack.c: Add 'annotate.h' include.
8283         (print_frame_info): Remove check of annotation_level before
8284         calling annotate_source_line.
8285
8286 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8287
8288         * source-cache.c (source_cache::get_plain_source_lines): Use
8289         open_source_file_with_line_charpos instead of just
8290         open_source_file, remove call to find_source_lines.
8291         (source_cache::get_source_lines): Likewise.
8292         * source.c (find_source_lines): Make static.
8293         (get_filename_and_charpos): Renamed into...
8294         (open_source_file_with_line_charpos): ..this along with changes to
8295         return a scoped_fd, and some other minor clean ups.
8296         (identify_source_line): Use open_source_file_with_line_charpos.
8297         (search_command_helper): Use open_source_file_with_line_charpos
8298         instead of just open_source_file, remove call to
8299         find_source_lines.
8300         * source.h (open_source_file_with_line_charpos): Declare new
8301         function.
8302         (find_source_lines): Delete declaration.
8303
8304 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * source.c (get_filename_and_charpos): Remove fullname
8307         parameter.
8308         (identify_source_line): Update call to get_filename_and_charpos.
8309
8310 2019-06-14  Tom Tromey  <tromey@adacore.com>
8311
8312         PR gdb/24502:
8313         * ui-style.h (skip_ansi_escape): Update comment.
8314         * ui-file.h (class no_terminal_escape_file): New class.
8315         * ui-file.c (no_terminal_escape_file::write)
8316         (no_terminal_escape_file::puts): New methods.
8317         * cli/cli-logging.c (handle_redirections): Use
8318         no_terminal_escape_file.
8319
8320 2019-06-14  Tom Tromey  <tromey@adacore.com>
8321
8322         * NEWS: Move convenience variable news above Python news.
8323
8324 2019-06-14  Tom Tromey  <tom@tromey.com>
8325
8326         * gnulib: Move directory to top-level.
8327         * configure.ac: Don't configure gnulib.
8328         * configure: Rebuild.
8329         * common/common-defs.h: Use new path to gnulib.
8330         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8331         (GNULIB_H): Remove.
8332         (INCGNU): Look in new gnulib location.
8333         (HFILES_NO_SRCDIR): Remove gnulib files.
8334         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8335         (generated_files): Remove GNULIB_H.
8336         ($(LIBGNU), all-lib): Remove targets.
8337         (distclean): Don't mention GNULIB_BUILDDIR.
8338         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8339
8340 2019-06-14  Tom Tromey  <tromey@adacore.com>
8341
8342         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8343         Warn if symbol file does not provide any symbols.
8344
8345 2019-06-14  Tom Tromey  <tromey@adacore.com>
8346
8347         * source.c (find_and_open_source): Respect basenames_may_differ.
8348
8349 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * annotate.c (annotate_breakpoints_invalid): Make use of
8352         scoped_restore_terminal_state.
8353         (annotate_frames_invalid): Likewise.
8354
8355 2019-06-14  Tom Tromey  <tromey@adacore.com>
8356
8357         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8358         allow assignment to an internalvar.
8359
8360 2019-06-14  Tom Tromey  <tromey@adacore.com>
8361
8362         * ada-lex.l: Allow "_" in attribute names.
8363
8364 2019-06-14  Tom Tromey  <tromey@adacore.com>
8365
8366         PR gdb/24653:
8367         * regcache.c (registers_changed): Don't call alloca.
8368         * top.c (execute_command): Don't call alloca.
8369
8370 2019-06-13  Pedro Alves  <palves@redhat.com>
8371
8372         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8373         'expression'.  When parsing an expression, error out if there's
8374         junk after "unlimited".
8375         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8376         (do_set_command): Adjust calls to is_unlimited_literal.
8377
8378 2019-06-13  Pedro Alves  <palves@redhat.com>
8379
8380         * compile/compile.c (make_compile_options_def_group): Add braces
8381         around array_view initializer.
8382         * thread.c (make_thread_apply_all_options_def_group)
8383         (make_thread_apply_all_options_def_group): Likewise.
8384
8385 2019-06-13  Pedro Alves  <palves@redhat.com>
8386
8387         * NEWS (New commands): Mention "maint test-options
8388         require-delimiter", "maint test-options unknown-is-error", "maint
8389         test-options unknown-is-operand" and "maint show
8390         test-options-completion-result".
8391         (New command options, command completion): New section.
8392         (Completion improvements): New section.
8393         Mention that you can abbreviate "unlimited".
8394
8395 2019-06-13  Pedro Alves  <palves@redhat.com>
8396
8397         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8398         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8399         * unittests/cli-utils-selftests.c (test_parse_flags)
8400         (test_parse_flags_qcs): Delete.
8401         (test_cli_utils): Don't call deleted functions.
8402
8403 2019-06-13  Pedro Alves  <palves@redhat.com>
8404
8405         * thread.c: Include "cli/cli-option.h".
8406         (tp_array_compar_ascending): Global.
8407         (tp_array_compar): Delete function.
8408         (tp_array_compar_ascending, tp_array_compar_descending): New
8409         functions.
8410         (ascending_option_def, qcs_flag_option_def)
8411         (thr_qcs_flags_option_defs)
8412         (make_thread_apply_all_options_def_group)
8413         (make_thread_apply_options_def_group): New.
8414         (thread_apply_all_command): Use gdb::option::process_options.
8415         (thread_apply_command_completer)
8416         (thread_apply_all_command_completer): New.
8417         (thread_apply_command): Use gdb::option::process_options.
8418         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8419         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8420         to generate help text of "thread apply".  Adjust "taas"'s help.
8421         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8422         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8423
8424 2019-06-13  Pedro Alves  <palves@redhat.com>
8425
8426         * thread.c (thread_apply_command): Check for invalid TID with
8427         isdigit instead of !isalpha.
8428
8429 2019-06-13  Pedro Alves  <palves@redhat.com>
8430
8431         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8432         (validate_flags_qcs): New.
8433         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8434         (validate_flags_qcs): Declare.
8435         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8436         (make_frame_apply_options_def_group): New.
8437         (frame_apply_command_count): Process options with
8438         gdb::option::process_options.
8439         (frame_apply_completer): New.
8440         (frame_apply_level_completer, frame_apply_all_completer)
8441         (frame_apply_completer): New.
8442         (_initialize_stack): Update help of "frame apply", "frame apply
8443         level", "frame apply all" and "faas" to mention supported options
8444         and install command completers.
8445         * stack.h (frame_apply_all_completer): Declare.
8446         * thread.c: Include "stack.h".
8447         (tfaas_command): Add "--".
8448         (_initialize_thread): Update help "tfaas" to mention supported
8449         options and install command completer.
8450
8451 2019-06-13  Pedro Alves  <palves@redhat.com>
8452
8453         * completer.c (complete_nested_command_line): New.
8454         (gdb_completion_word_break_characters_throw): Add assertion.
8455         * completer.h (complete_nested_command_line): Declare.
8456
8457 2019-06-13  Pedro Alves  <palves@redhat.com>
8458
8459         * stack.c (parse_backtrace_qualifiers): New.
8460         (backtrace_command): Use it.
8461         (backtrace_command_completer): Complete on qualifiers.
8462
8463 2019-06-13  Pedro Alves  <palves@redhat.com>
8464
8465         * frame.c: Include "cli/cli-option.h.
8466         (user_set_backtrace_options): New.
8467         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8468         Delete.
8469         (get_prev_frame): Adjust.
8470         (boolean_option_def, uinteger_option_def)
8471         (set_backtrace_option_defs): New.
8472         (_initialize_frame): Adjust and use
8473         gdb::option::add_setshow_cmds_for_options to install "set
8474         backtrace past-main" and "set backtrace past-entry".
8475         * frame.h: Include "cli/cli-option.h".
8476         (struct frame_print_options): Forward declare.
8477         (print_frame_arguments_all, print_frame_arguments_scalars)
8478         (print_frame_arguments_none): Declare.
8479         (print_entry_values): Delete declaration.
8480         (struct frame_print_options, user_frame_print_options): New.
8481         (struct set_backtrace_options): New.
8482         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8483         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8484         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8485         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8486         (list_args_or_locals): Add frame_print_options parameter.
8487         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8488         * python/py-framefilter.c (enumerate_args): Pass down
8489         USER_FRAME_PRINT_OPTIONS.
8490         * stack.c: Include "cli/cli-option.h".
8491         (print_frame_arguments_all, print_frame_arguments_scalars)
8492         (print_frame_arguments_none): Declare.
8493         (print_raw_frame_arguments, print_entry_values): Delete.
8494         (user_frame_print_options): New.
8495         (boolean_option_def, enum_option_def, frame_print_option_defs):
8496         New.
8497         (struct backtrace_cmd_options): New.
8498         (bt_flag_option_def): New.
8499         (backtrace_command_option_defs): New.
8500         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8501         (print_frame_arg, read_frame_arg, print_frame_args)
8502         (print_frame_info, print_frame): Add frame_print_options parameter
8503         and use it.
8504         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8505         (backtrace_command_1): Add frame_print_options and
8506         backtrace_cmd_options parameters and use them.
8507         (make_backtrace_options_def_group): New.
8508         (backtrace_command): Process command options with
8509         gdb::option::process_options.
8510         (backtrace_command_completer): New.
8511         (_initialize_stack): Extend "backtrace"'s help to mention
8512         supported options.  Install completer for "backtrace".
8513         Install some settings commands with add_setshow_cmds_for_options.
8514
8515 2019-06-13  Pedro Alves  <palves@redhat.com>
8516
8517         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8518         and that "set/show print raw frame-arguments" are now deprecated.
8519
8520         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8521         command.
8522         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8523         * stack.c (_initialize_stack): Install "set/show print
8524         raw-frame-arguments", and deprecate "set/show print raw
8525         frame-arguments".
8526         * valprint.c (_initialize_valprint): Deprecate "set/show print
8527         raw".
8528
8529 2019-06-13  Pedro Alves  <palves@redhat.com>
8530
8531         * compile/compile.c (struct compile_options): New.
8532         (compile_flag_option_def, compile_command_option_defs)
8533         (make_compile_options_def_group): New.
8534         (compile_file_command): Handle options with
8535         gdb::option::process_options.
8536         (compile_file_command_completer): New function.
8537         (compile_code_command): Handle options with
8538         gdb::option::process_options.
8539         (compile_code_command_completer): New function.
8540         (_initialize_compiler): Install completers for "compile code" and
8541         "compile file".  Mention available options in "compile code" and
8542         "compile code"'s help.
8543         * completer.c (advance_to_completion_word): New, factored out from
8544         ...
8545         (advance_to_expression_complete_word_point): ... this.
8546         (advance_to_filename_complete_word_point): New.
8547         * completer.h (advance_to_filename_complete_word_point): New
8548         declaration.
8549
8550 2019-06-13  Pedro Alves  <palves@redhat.com>
8551
8552         * compile/compile.c: Include "cli/cli-option.h".
8553         (compile_print_value): Scope data pointer is now a
8554         value_print_options pointer; adjust.
8555         (compile_print_command): Process options.  Scope data pointer is
8556         now a value_print_options pointer; adjust.
8557         (_initialize_compile): Update "compile print"'s help to include
8558         supported options.  Install a completer for "compile print".
8559         * cp-valprint.c (show_vtblprint, show_objectprint)
8560         (show_static_field_print): Delete.
8561         (_initialize_cp_valprint): Don't install "set print
8562         static-members", "set print vtbl", "set print object" here.
8563         * printcmd.c: Include "cli/cli-option.h" and
8564         "common/gdb_optional.h".
8565         (print_command_parse_format): Rework to fill in a
8566         value_print_options instead of a format_data.
8567         (print_value): Change parameter type from format_data pointer to
8568         value_print_options reference.  Adjust.
8569         (print_command_1): Process options.  Adjust to pass down a
8570         value_print_options.
8571         (print_command_completer): New.
8572         (_initialize_printcmd): Install print_command_completer as
8573         handle_brkchars completer for the "print" command.  Update
8574         "print"'s help to include supported options.
8575         * valprint.c: Include "cli/cli-option.h".
8576         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8577         here from cp-valprint.c.
8578         (boolean_option_def, uinteger_option_def)
8579         (value_print_option_defs, make_value_print_options_def_group):
8580         New.  Use gdb::option::add_setshow_cmds_for_options to install
8581         "set print elements", "set print null-stop", "set print repeats",
8582         "set print pretty", "set print union", "set print array", "set
8583         print address", "set print symbol", "set print array-indexes".
8584         * valprint.h: Include <string> and "cli/cli-option.h".
8585         (make_value_print_options_def_group): Declare.
8586         (print_value): Change parameter type from format_data pointer to
8587         value_print_options reference.
8588         (print_command_completer): Declare.
8589
8590 2019-06-13  Pedro Alves  <palves@redhat.com>
8591
8592         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8593         (COMMON_SFILES): Add maint-test-settings.c.
8594         * cli/cli-decode.c (boolean_enums): New global, factored out from
8595         ...
8596         (add_setshow_boolean_cmd): ... here.
8597         * cli/cli-decode.h (boolean_enums): Declare.
8598         * cli/cli-option.c: New file.
8599         * cli/cli-option.h: New file.
8600         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8601         factored out from ...
8602         (parse_cli_boolean_value(const char *)): ... this.
8603         (is_unlimited_literal): Change parameter type to pointer to
8604         pointer.  Adjust and advance ARG pointer.
8605         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8606         (parse_cli_var_enum): New, factored out from ...
8607         (do_set_command): ... this.  Adjust.
8608         * cli/cli-setshow.h (parse_cli_boolean_value)
8609         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8610         (parse_cli_var_enum): Declare.
8611         * cli/cli-utils.c: Include "cli/cli-option.h".
8612         (get_ulongest): New.
8613         * cli/cli-utils.h (get_ulongest): Declare.
8614         (check_for_argument): New overloads.
8615         * maint-test-options.c: New file.
8616
8617 2019-06-13  Pedro Alves  <palves@redhat.com>
8618
8619         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8620         parse a range if "-" is at the end of the string.
8621
8622 2019-06-13  Pedro Alves  <palves@redhat.com>
8623
8624         * cli/cli-setshow.c (parse_auto_binary_operation)
8625         (parse_cli_boolean_value): Don't allow "o".
8626
8627 2019-06-13  Pedro Alves  <palves@redhat.com>
8628
8629         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8630         * NEWS: Mention maint test-settings KIND.
8631         * maint-test-settings.c: New file.
8632
8633 2019-06-13  Pedro Alves  <palves@redhat.com>
8634
8635         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8636         completer.
8637         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8638         "set" completers.
8639
8640 2019-06-13  Pedro Alves  <palves@redhat.com>
8641
8642         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8643         after item.
8644
8645 2019-06-13  Pedro Alves  <palves@redhat.com>
8646
8647         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8648
8649 2019-06-13  Pedro Alves <palves@redhat.com>
8650
8651         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8652         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8653         call.
8654         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8655         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8656         calls.
8657         (check_for_argument): Skip spaces after argument.
8658
8659 2019-06-13  Pedro Alves  <palves@redhat.com>
8660
8661         * thread.c (thread_apply_command): Adjust TID parsing.
8662         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8663         detected before end of string.
8664         (tid_is_in_list): Error out if LIST is invalid.
8665
8666 2019-06-13  Pedro Alves  <palves@redhat.com>
8667
8668         * completer.c (complete_line_internal_1): Rewind completion word
8669         point.
8670         (completion_tracker::advance_custom_word_point_by): Change
8671         parameter type to int.
8672         * completer.h (completion_tracker::advance_custom_word_point_by):
8673         Likewise.
8674
8675 2019-06-13  Pedro Alves  <palves@redhat.com>
8676
8677         * completer.c (advance_to_completion_word): Handle delimiters.
8678
8679 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8680
8681         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8682
8683 2019-06-11  Tom Tromey  <tom@tromey.com>
8684
8685         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8686         (xmalloc_failed): Move to alloc.c.
8687         * alloc.c: New file.
8688         * Makefile.in (COMMON_SFILES): Add alloc.c.
8689
8690 2019-06-11  Tom Tromey  <tom@tromey.com>
8691
8692         * nat/linux-waitpid.c: Don't include server.h.
8693         (linux_debug): Remove.
8694         (my_waitpid): Update.
8695
8696 2019-06-11  Tom Tromey  <tromey@adacore.com>
8697
8698         * infcall.c (_initialize_infcall): Remove trailing newline from
8699         help.
8700         * user-regs.c (_initialize_user_regs): Remove trailing newline
8701         from help.
8702         * typeprint.c (_initialize_typeprint): Remove trailing newline
8703         from help.
8704         * reverse.c (_initialize_reverse): Remove trailing newlines from
8705         help.
8706         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8707         from help.
8708         * language.c (add_set_language_command): Remove trailing newline
8709         from help.
8710         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8711         help.
8712         * disasm.c (_initialize_disasm): Remove trailing newline from
8713         help.
8714         * top.c (init_main): Remove trailing newline from help.
8715         * interps.c (_initialize_interpreter): Remove trailing newline
8716         from help.
8717         * btrace.c (_initialize_btrace): Remove trailing newlines from
8718         help.
8719         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8720         from help.
8721         * python/python.c (_initialize_python): Remove trailing newline
8722         from help.
8723         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8724         help.
8725         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8726         from help.  Reformat some text.
8727         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8728         from help.
8729         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8730         newline from help.
8731
8732 2019-06-11  Tom Tromey  <tromey@adacore.com>
8733
8734         * darwin-nat.c (darwin_decode_exception_message)
8735         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8736
8737 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * valops.c (value_slice): Check for not allocated or not
8740         associated values.
8741
8742 2019-06-10  Tom de Vries  <tdevries@suse.de>
8743
8744         PR gdb/24618
8745         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8746         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8747         invalid.
8748
8749 2019-06-10  Tom de Vries  <tdevries@suse.de>
8750
8751         PR gdb/24611
8752         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8753         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8754
8755 2019-06-10  Tom de Vries  <tdevries@suse.de>
8756
8757         PR symtab/24545
8758         * symtab.c (struct demangled_name_entry): Add language field.
8759         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8760         static minimal symbol".  Set and use language field.
8761
8762 2019-06-10  Tom Tromey  <tromey@adacore.com>
8763
8764         * ada-lang.c (_initialize_ada_language): Update help text.
8765
8766 2019-06-10  Tom Tromey  <tromey@adacore.com>
8767
8768         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8769         with a newline.
8770         * guile/guile.c (handle_boot_error): Don't end warning with a
8771         newline.
8772         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8773         warning with a newline.
8774         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8775         newline.
8776         (s12z_frame_cache): Likewise.
8777         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8778         a newline.
8779         * solib-svr4.c (disable_probes_interface): Don't end warning with
8780         a newline.
8781         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8782         newline.
8783         * python/python.c (do_finish_initialization): Don't end warning
8784         with a newline.
8785
8786 2019-06-10  Tom Tromey  <tom@tromey.com>
8787
8788         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8789         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8790         gdbpy_enter.
8791
8792 2019-06-10  Tom Tromey  <tromey@adacore.com>
8793
8794         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8795         data.
8796         (elf_new_init): Don't call stabsread_new_init.
8797         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8798         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8799         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8800
8801 2019-06-10  Tom de Vries  <tdevries@suse.de>
8802
8803         PR symtab/16264
8804         PR symtab/24517
8805         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8806
8807 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8808
8809         * source.c (find_and_open_source): Also rewrite relative file
8810         names.
8811
8812 2019-04-26  Amos Bird  <amosbird@gmail.com>
8813
8814         * annotate.c (annotate_thread_exited): Add "thread-exited"
8815         annotation.
8816
8817 2019-06-06  Tom Tromey  <tromey@adacore.com>
8818
8819         * maint.h (class scoped_command_stats): Use
8820         DISABLE_COPY_AND_ASSIGN.
8821         <print_time>: New method.
8822         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8823         print_time.
8824         (scoped_command_stats::print_time): New method.
8825
8826 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8829         instructions of lengths 6 or 8 bytes.
8830
8831 2019-06-04  Pedro Alves  <palves@redhat.com>
8832
8833         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8834
8835         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8836         * breakpoint.c (condition_completer): Likewise.
8837         * cli/cli-dump.c (scan_expression): Likewise.
8838         * common/filestuff.c (mkdir_recursive): Likewise.
8839         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8840         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8841         (gdb_abspath): Likewise.
8842         * compile/compile-cplus-types.c
8843         (compile_cplus_instance::decl_name): Likewise.
8844         * completer.c (complete_explicit_location):
8845         (signal_completer, reg_or_group_completer_1): Likewise.
8846         * cp-support.c (cp_remove_params_if_any): Likewise.
8847         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8848         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8849         * infcmd.c (strip_bg_char): Likewise.
8850         * linespec.c (copy_token_string): Likewise.
8851         * mi/mi-main.c (output_cores): Likewise.
8852         * psymtab.c (psymtab_search_name):
8853         * symfile.c (test_set_ext_lang_command): Likewise.
8854         * target.c (target_fileio_read_stralloc): Likewise.
8855         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8856         * value.c (complete_internalvar): Likewise.
8857
8858 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8859
8860         Add objfile property to gdb.Type.
8861         * NEWS: Mention Python API addition.
8862         * python/py-type.c (typy_get_objfile): New method.
8863
8864 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8865
8866         * NEWS: Mention the new set|show style [title|highlight].
8867         Mention changes to "show style", "help" and "apropos".
8868
8869 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8870
8871         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8872         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8873         instead of print_help_for_command.
8874         (print_doc_of_command): New function.
8875         (help_list): Add 'apropos -v word' suggestion.
8876         (print_help_for_command): Style the command name using title style.
8877         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8878         (_initialize_cli_cmds): Describe -v in apropos_command help.
8879
8880 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8881
8882         * cli/cli-style.h (cli_style_option): Add name in constructor,
8883         add m_name class member, add constructor with intensity,
8884         add name class function.
8885         (cli_style_option::add_setshow_commands): Remove name argument.
8886         (highlight_style, title_style): New styles.
8887         * cli/cli-style.c (do_show): New function that shows a style
8888         characteristic styling the style name with itself.
8889         (set_style_name): New function.
8890         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8891         Update all callers according to the changes in cli/cli-style.h.
8892         * utils.h (fputs_highlighted): New function.
8893         * utils.c (fputs_highlighted): Likewise.
8894
8895 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * NEWS: Mention new pipe command and new convenience variables.
8898
8899 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8900
8901         * cli/cli-cmds.c (pipe_command): New function.
8902         (_initialize_cli_cmds): Call add_com for pipe_command.
8903         Define | as an alias for pipe.
8904         (exit_status_set_internal_vars): New function.
8905         (shell_escape): Call exit_status_set_internal_vars.
8906         cli/cli-decode.c (find_command_name_length): Recognize | as
8907         a single character command.
8908
8909 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8910
8911         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8912         top.c (execute_command_to_ui_file): New function, mostly a copy
8913         of execute_command_to_string.
8914         (execute_command_to_string): Implement by calling
8915         execute_command_to_ui_file.
8916
8917 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8918
8919         * top.h (saved_command_line): Remove declaration.
8920         * top.c (previous_saved_command_line, previous_repeat_arguments):
8921         New variables.
8922         (saved_command_line): Make static, define together with other
8923         'repeat variables'.
8924         (dont_repeat): Clear repeat_arguments.
8925         (repeat_previous, get_saved_command_line, save_command_line):
8926         New functions.
8927         (gdb_init): Initialize saved_command_line
8928         and previous_saved_command_line.
8929         * main.c (captured_main_1): Remove saved_command_line initialization.
8930         * event-top.c (handle_line_of_input): Update to use
8931         the new 'repeat' related functions instead of direct access to
8932         saved_command_line.
8933         * command.h (repeat_previous, get_saved_command_line,
8934         save_command_line): New declarations.
8935         (dont_repeat): Add comment.
8936
8937 2019-05-30  Tom Tromey  <tromey@adacore.com>
8938
8939         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8940         Fix comment.
8941         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8942
8943 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8944
8945         PR cli/24587
8946         * completer.c (complete): Initialize variable word.
8947
8948 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8949
8950         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8951         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8952         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8953         'body' is NULL to the outter 'if', protecting the '!is_define'
8954         situation as well.
8955
8956 2019-05-29  Tom Tromey  <tromey@adacore.com>
8957
8958         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8959         (dwarf_unknown): New function.
8960         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8961         (dwarf_type_encoding_name): Use dwarf_unknown.
8962
8963 2019-05-29  Tom Tromey  <tromey@adacore.com>
8964
8965         PR c++/20020:
8966         * cp-valprint.c (cp_print_value_fields): Call
8967         cp_print_static_field inside "try".
8968
8969 2019-05-29  Tom Tromey  <tromey@adacore.com>
8970
8971         * inflow.c (struct terminal_info): Add default operator=.
8972         * configure: Rebuild.
8973         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8974         -Wdeprecated-copy-dtor, -Wredundant-move.
8975
8976 2019-05-29  Tom Tromey  <tromey@adacore.com>
8977
8978         * NEWS: Add entry.
8979         * infcmd.c (print_return_value_1): Handle finish_print
8980         option.
8981         (show_print_finish): New function.
8982         (_initialize_infcmd): Add "set/show print finish" commands.
8983         * valprint.c (user_print_options): Initialize new member.
8984         * valprint.h (struct value_print_options) <finish_print>: New
8985         member.
8986
8987 2019-05-28  Tom Tromey  <tromey@adacore.com>
8988
8989         * ada-lang.c (ada_remove_Xbn_suffix)
8990         (find_old_style_renaming_symbol)
8991         (parse_old_style_renaming): Remove.
8992         (ada_find_renaming_symbol): Don't call
8993         find_old_style_renaming_symbol.
8994         (ada_is_renaming_symbol): Rename from
8995         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8996         bool.  Now static.
8997         (ada_read_var_value): Update and simplify.
8998         * ada-exp.y (write_var_or_type): Remove old code.
8999
9000 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9001
9002         PR gdb/25010
9003         * event-top.c: Remove include comment.
9004         * inflow.c (class scoped_ignore_sigttou): Move from here...
9005         * inflow.h (class scoped_ignore_sigttou): ...to here.
9006         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9007         * top.c:  Remove include comment.
9008
9009 2019-05-27  Tom Tromey  <tom@tromey.com>
9010
9011         * NEWS: Fix typo.
9012
9013 2019-05-22  Tom Tromey  <tromey@adacore.com>
9014
9015         * target.c (target_follow_exec): Constify parameter.
9016         * target-delegates.c: Rebuild.
9017         * remote.c (remote_target::follow_exec): Constify parameter.
9018         * infrun.c (follow_exec): Constify parameter.
9019         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9020         (target_follow_exec): Likewise.
9021
9022 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9023
9024         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9025         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9026
9027 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9028
9029         * NEWS: Add debugredirect and testsuite sections.
9030
9031 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9032
9033         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9034         target descriptions using exclusively floating point register name
9035         aliases.
9036
9037 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9038
9039         PR gdb/18644:
9040         * f-lang.c (build_fortran_types): Handle the case where
9041         gdbarch_floatformat_for_type returns a nullptr.
9042
9043 2019-05-21  Tom de Vries  <tdevries@suse.de>
9044
9045         PR cli/24587
9046         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9047
9048 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         PR gdb/18644:
9051         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9052         16-byte floats.
9053         * i386-tdep.c (i386_floatformat_for_type): Use
9054         floatformats_ia64_quad for the 16-byte floating point component
9055         within a fortran 32-byte complex number.
9056
9057 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9058
9059         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9060         delete default constructor.
9061         (find_partial_die): Update to return const struct.
9062         (partial_die_parent_scope): Move variable declaration into scope
9063         of its use and change its type to auto.
9064         (guess_partial_die_structure_name): Likewise.
9065         (partial_die_info::fixup): Likewise.
9066
9067 2019-05-17  Tom Tromey  <tromey@adacore.com>
9068
9069         * source.c (find_and_open_source): Remove cast.
9070
9071 2019-05-17  Tom Tromey  <tromey@adacore.com>
9072
9073         * annotate.c (annotate_source): Make "filename" const.
9074         * annotate.h (annotate_source): Use const.
9075
9076 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9077
9078         * disasm.c (set_disassembler_options): Send errors to stderr.
9079
9080 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9081
9082         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9083         (cli_interp_base::set_logging): Check debug_redirect.
9084         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9085         * cli/cli-logging.c (debug_redirect): Add static variable.
9086         (pop_output_files): Add default param.
9087         (handle_redirections): Print debug setting.
9088         (show_logging_command): Likewise.
9089         (_initialize_cli_logging): Add debugredirect command.
9090         * interps.c (current_interp_set_logging): Add debug_redirect
9091         parameter.
9092         * interps.h (set_logging): Add debug_redirect parameter.
9093         (current_interp_set_logging): Likewise.
9094         * mi/mi-common.h: Likewise.
9095         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9096
9097 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9098             Tom Tromey  <tromey@adacore.com>
9099
9100         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9101         directly.
9102         * cli/cli-interp.h (make_logging_output): Remove declaration.
9103         * cli/cli-logging.c (make_logging_output): Remove function.
9104         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9105         directly.
9106         * ui-file.c (tee_file::tee_file): Remove bools.
9107         (tee_file::~tee_file): Remove deletes.
9108         * ui-file.h (tee_file): Remove bools.
9109
9110 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9111
9112         * mi/mi-cmds.h (mi_cmd_complete): New function.
9113         * mi/mi-main.c (mi_cmd_complete): Likewise.
9114         * mi/mi-cmds.c: Define new MI command -complete.
9115         * NEWS: Mention new -complete command.
9116
9117 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9118
9119         * completer.h (complete): New function.
9120         * completer.c (complete): Likewise.
9121         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9122         function defined in completer.h.
9123
9124 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9125
9126         * MAINTAINERS (Write After Approval): Add myself.
9127
9128 2019-05-17  Tom de Vries  <tdevries@suse.de>
9129
9130         PR gdb/24094
9131         * dwarf2read.c (struct cu_partial_die_info): New struct.
9132         (find_partial_die): Return cu_partial_die_info.
9133         (partial_die_parent_scope, guess_partial_die_structure_name)
9134         (partial_die_info::fixup): Handle new return type of find_partial_die.
9135
9136 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9137
9138         PR breakpoints/24541
9139         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9140         "std::string", simplifying the algorithm.
9141
9142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9143
9144         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9145         (stap_static_probe_ops::get_probes): Likewise.
9146
9147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9148
9149         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9150         '-')" and "else if".
9151         (stap_parse_single_operand): Join checks for
9152         "gdbarch_stap_parse_special_token_p" and
9153         "gdbarch_stap_parse_special_token" in the same "if" statement.
9154         Invert check when verifying for operation on register
9155         displacement.
9156
9157 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9158
9159         * stap-probe.c (stap_get_opcode): Update comment.
9160         (stap_get_expected_argument_type): Likewise.
9161         (handle_stap_probe): Likewise.
9162
9163 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9164
9165         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9166         return type to 'bool'.  Adjust comment.  Use 'bool' when
9167         appropriate.
9168         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9169         * stap-probe.c (stap_parse_argument_1): Likewise.
9170         (stap_is_operator): Likewise.
9171         (stap_is_generic_prefix): Likewise.
9172         (stap_is_register_prefix): Likewise.
9173         (stap_is_register_indirection_prefix): Likewise.
9174         (stap_is_integer_prefix): Likewise.
9175         (stap_generic_check_suffix): Likewise.
9176         (stap_check_integer_suffix): Likewise.
9177         (stap_check_register_suffix): Likewise.
9178         (stap_check_register_indirection_suffix): Likewise.
9179         (stap_parse_register_operand): Likewise.
9180         (stap_parse_single_operand): Likewise.
9181         (stap_parse_argument_1): Likewise.
9182         (stap_probe::get_argument_count): Likewise.
9183         (stap_is_operator): Likewise.
9184
9185 2019-05-16  Tom Tromey  <tromey@adacore.com>
9186
9187         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9188         keyword to foreach.
9189
9190 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9191
9192         * linux-thread-db.c (try_thread_db_load_1): Change return type
9193         to bool.
9194         (try_thread_db_load): Likewise.
9195         (try_thread_db_load_from_pdir_1): Likewise.
9196         (try_thread_db_load_from_pdir): Likewise.
9197         (try_thread_db_load_from_sdir): Likewise.
9198         (try_thread_db_load_from_dir): Likewise.
9199         (thread_db_load_search): Likewise.
9200         (has_libpthread): Likewise.
9201         (thread_db_load): Likewise.
9202
9203 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9204
9205         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9206         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9207         NULL, and complain/return if that's the case.
9208
9209 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9210
9211         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9212         (advance, posn, abstract_read_memory): New functions.
9213         [struct mem_read_abstraction]: New struct.
9214         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9215
9216 2019-05-14  Tom Tromey  <tromey@adacore.com>
9217
9218         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9219         value is not lval_memory.
9220
9221 2019-05-14  Tom Tromey  <tromey@adacore.com>
9222
9223         * solib.c (info_sharedlibrary_command): Style the file name.
9224
9225 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9226
9227         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9228         (aarch64_vnv_type): Likewise.
9229         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9230         * common/tdesc.c: Likewise.
9231         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9232         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9233         * features/aarch64-fpu.xml: Add ieee half view.
9234         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9235         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9236         * gdbtypes.h (struct builtin_type): Likewise.
9237         (struct objfile_type): Likewise.
9238
9239 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9240
9241         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9242         typo.
9243         * location.h (string_to_event_location): Likewise.
9244
9245 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9246
9247         GDB 8.3 released.
9248
9249 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9250
9251         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9252         New variable declaration.
9253         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9254         New variable.
9255         (print_one_breakpoint): Use ui_out::test_flags and new global
9256         variable to compute use_fixed_output.
9257         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9258         Remove.
9259         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9260         (mi_multi_location_breakpoint_output_fixed): Remove.
9261         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9262         new variable.
9263         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9264         fix_multi_location_breakpoint_output flag if version >= 3.
9265         * ui-out.h (enum ui_out_flag)
9266         <fix_multi_location_breakpoint_output>: New enumerator.
9267
9268 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9269
9270         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9271
9272 2019-05-10  Tom Tromey  <tromey@adacore.com>
9273
9274         * ada-lang.c (catch_ada_completer): New function.
9275         (_initialize_ada_language): Use it.
9276
9277 2019-05-10  Tom Tromey  <tromey@adacore.com>
9278
9279         * thread.c (print_thread_info): Make "requested_threads" const.
9280         * gdbthread.h (print_thread_info): Make "requested_threads"
9281         const.
9282         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9283         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9284
9285 2019-05-08  Tom Tromey  <tom@tromey.com>
9286
9287         * gdbtypes.c (objfile_type_data): Change type.
9288         (objfile_type, _initialize_gdbtypes): Update.
9289
9290 2019-05-08  Tom Tromey  <tom@tromey.com>
9291
9292         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9293         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9294         (_initialize_dwarf2_frame): Update.
9295
9296 2019-05-08  Tom Tromey  <tom@tromey.com>
9297
9298         * objc-lang.c (objc_objfile_data): Change type.
9299         (find_methods): Update.
9300         (_initialize_objc_lang): Remove.
9301
9302 2019-05-08  Tom Tromey  <tom@tromey.com>
9303
9304         * stabsread.c (rs6000_builtin_type_data): Change type.
9305         (rs6000_builtin_type, _initialize_stabsread): Update.
9306
9307 2019-05-08  Tom Tromey  <tom@tromey.com>
9308
9309         * mips-tdep.c (mips_pdr_data): Remove.
9310         (_initialize_mips_tdep): Update.
9311
9312 2019-05-08  Tom Tromey  <tom@tromey.com>
9313
9314         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9315         (hppa_init_objfile_priv_data, read_unwind_info)
9316         (find_unwind_entry, _initialize_hppa_tdep): Update.
9317
9318 2019-05-08  Tom Tromey  <tom@tromey.com>
9319
9320         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9321         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9322         on obstack.
9323         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9324
9325 2019-05-08  Tom Tromey  <tom@tromey.com>
9326
9327         * mdebugread.c (basic_type_data): Change type.
9328         (basic_type, _initialize_mdebugread): Update.
9329
9330 2019-05-08  Tom Tromey  <tom@tromey.com>
9331
9332         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9333
9334 2019-05-08  Tom Tromey  <tom@tromey.com>
9335
9336         * nto-tdep.c (nto_inferior_data_reg): Change type.
9337         (nto_inferior_data): Update.
9338         (nto_inferior_data_cleanup, nto_new_inferior_data)
9339         (_initialize_nto_tdep): Remove.
9340         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9341
9342 2019-05-08  Tom Tromey  <tom@tromey.com>
9343
9344         * ada-lang.c (struct ada_inferior_data): Add initializers.
9345         (ada_inferior_data): Change type.
9346         (ada_inferior_data_cleanup): Remove.
9347         (get_ada_inferior_data, ada_inferior_exit)
9348         (struct ada_pspace_data): Add initializers, destructor.
9349         (ada_pspace_data_handle): Change type.
9350         (get_ada_pspace_data): Update.
9351         (ada_pspace_data_cleanup): Remove.
9352
9353 2019-05-08  Tom Tromey  <tom@tromey.com>
9354
9355         * coffread.c (struct coff_symfile_info): Add initializers.
9356         (coff_objfile_data_key): Move lower.  Change type.
9357         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9358         Update.
9359         (coff_free_info): Remove.
9360
9361 2019-05-08  Tom Tromey  <tom@tromey.com>
9362
9363         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9364         (fbsd_pspace_data_handle): Move lower.  Change type.
9365         (get_fbsd_pspace_data): Update.
9366         (fbsd_pspace_data_cleanup): Remove.
9367         (_initialize_fbsd_tdep): Update.
9368
9369 2019-05-08  Tom Tromey  <tom@tromey.com>
9370
9371         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9372         (get_ada_tasks_pspace_data): Update.
9373         (ada_tasks_pspace_data_cleanup): Remove.
9374         (_initialize_tasks): Update.
9375         (ada_tasks_inferior_data_handle): Change type.
9376         (get_ada_tasks_inferior_data): Update.
9377         (ada_tasks_inferior_data_cleanup): Remove.
9378         (struct ada_tasks_pspace_data): Add initializers.
9379
9380 2019-05-08  Tom Tromey  <tom@tromey.com>
9381
9382         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9383         * symfile-debug.c (debug_sym_get_probes): Change type.
9384         * stap-probe.c (handle_stap_probe):
9385         (stap_static_probe_ops::get_probes): Change type.
9386         * probe.h (class static_probe_ops) <get_probes>: Change type.
9387         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9388         (parse_probes_in_pspace): Update.
9389         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9390         Update.
9391         (any_static_probe_ops::get_probes): Change type.
9392         * elfread.c (elfread_data): New typedef.
9393         (probe_key): Change type.
9394         (elf_get_probes): Likewise.  Update.
9395         (probe_key_free): Remove.
9396         (_initialize_elfread): Update.
9397         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9398         Change type.
9399         (dtrace_process_dof_probe, dtrace_process_dof)
9400         (dtrace_static_probe_ops::get_probe): Change type.
9401
9402 2019-05-08  Tom Tromey  <tom@tromey.com>
9403
9404         * xcoffread.c (struct xcoff_symfile_info): Rename from
9405         coff_symfile_info.  Add initializers.
9406         (xcoff_objfile_data_key): Move lower.  Change type.
9407         (XCOFF_DATA): Rewrite.
9408         (xcoff_free_info): Remove.
9409         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9410         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9411         (xcoff_initial_scan): Update.
9412
9413 2019-05-08  Tom Tromey  <tom@tromey.com>
9414
9415         * solib-svr4.c (struct svr4_info): Add initializers and
9416         destructor.
9417         <probes_table>: Now an htab_up.
9418         (solib_svr4_pspace_data): Change type.
9419         (free_probes_table): Simplify.
9420         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9421         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9422         (probes_table_remove_objfile_probes, register_solib_event_probe)
9423         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9424         (_initialize_svr4_solib): Update.
9425
9426 2019-05-08  Tom Tromey  <tom@tromey.com>
9427
9428         * remote.c (remote_pspace_data): Change type.
9429         (remote_pspace_data_cleanup): Remove.
9430         (get_remote_exec_file, set_pspace_remote_exec_file)
9431         (_initialize_remote): Update.
9432
9433 2019-05-08  Tom Tromey  <tom@tromey.com>
9434
9435         * breakpoint.c (breakpoint_objfile_key): Change type.
9436         (get_breakpoint_objfile_data): Update.
9437         (free_breakpoint_objfile_data): Remove.
9438         (_initialize_breakpoint): Update.
9439
9440 2019-05-08  Tom Tromey  <tom@tromey.com>
9441
9442         * linux-tdep.c (struct linux_info): Add initializers.
9443         (linux_inferior_data): Move.  Change type.
9444         (invalidate_linux_cache_inf): Update.
9445         (linux_inferior_data_cleanup): Remove.
9446         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9447
9448 2019-05-08  Tom Tromey  <tom@tromey.com>
9449
9450         * auxv.c (auxv_inferior_data): Move.  Change type.
9451         (auxv_inferior_data_cleanup): Remove.
9452         (invalidate_auxv_cache_inf): Rewrite.
9453         (get_auxv_inferior_data, _initialize_auxv): Update.
9454
9455 2019-05-08  Tom Tromey  <tom@tromey.com>
9456
9457         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9458         (symfile_debug_objfile_data_key): Change type.
9459         (symfile_debug_installed, debug_qf_has_symbols)
9460         (debug_qf_find_last_source_symtab)
9461         (debug_qf_forget_cached_source_info)
9462         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9463         (debug_qf_print_stats, debug_qf_dump)
9464         (debug_qf_expand_symtabs_for_function)
9465         (debug_qf_expand_all_symtabs)
9466         (debug_qf_expand_symtabs_with_fullname)
9467         (debug_qf_map_matching_symbols)
9468         (debug_qf_expand_symtabs_matching)
9469         (debug_qf_find_pc_sect_compunit_symtab)
9470         (debug_qf_map_symbol_filenames)
9471         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9472         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9473         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9474         (debug_sym_read_linetable, debug_sym_relocate): Update.
9475         (symfile_debug_free_objfile): Remove.
9476         (install_symfile_debug_logging, _initialize_symfile_debug):
9477         Update.
9478
9479 2019-05-08  Tom Tromey  <tom@tromey.com>
9480
9481         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9482         allocate_on_obstack.
9483         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9484         (get_dwarf2_per_objfile): Update.
9485         (set_dwarf2_per_objfile): Remove.
9486         (dwarf2_has_info, dwarf2_get_section_info): Update.
9487         (dwarf2_free_objfile): Remove.
9488         (_initialize_dwarf2_read): Update.
9489
9490 2019-05-08  Tom Tromey  <tom@tromey.com>
9491
9492         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9493         initializers.
9494         <unsupported_script_warning_printed,
9495         script_not_found_warning_printed>: Now bool.
9496         (auto_load_pspace_data): Change type.
9497         (~auto_load_pspace_info): Rename from
9498         auto_load_pspace_data_cleanup.
9499         (get_auto_load_pspace_data, init_loaded_scripts_info)
9500         (clear_section_scripts, maybe_print_unsupported_script_warning)
9501         (maybe_print_script_not_found_warning, _initialize_auto_load):
9502         Update.
9503
9504 2019-05-08  Tom Tromey  <tom@tromey.com>
9505
9506         * objfiles.c (objfile_pspace_info): Add destructor and
9507         initializers.
9508         (objfiles_pspace_data): Change type.
9509         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9510         (get_objfile_pspace_data): Update.
9511         (objfiles_bfd_data): Change type.
9512         (get_objfile_bfd_data): Update.
9513         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9514
9515 2019-05-08  Tom Tromey  <tom@tromey.com>
9516
9517         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9518         Change type.
9519         (get_catch_syscall_inferior_data): Update.
9520         (catch_syscall_inferior_data_cleanup): Remove.
9521         (_initialize_break_catch_syscall): Update.
9522
9523 2019-05-08  Tom Tromey  <tom@tromey.com>
9524
9525         * inflow.c (struct terminal_info): Add destructor and
9526         initializers.
9527         (inflow_inferior_data): Change type.
9528         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9529         (get_inflow_inferior_data, inflow_inferior_exit)
9530         (swap_terminal_info, _initialize_inflow): Update.
9531
9532 2019-05-08  Tom Tromey  <tom@tromey.com>
9533
9534         * target-dcache.c (target_dcache_cleanup): Remove.
9535         (target_dcache_aspace_key): Change type.
9536         (target_dcache_init_p, target_dcache_invalidate)
9537         (target_dcache_get, target_dcache_get_or_init)
9538         (_initialize_target_dcache): Update.
9539         * dcache.h (struct dcache_deleter): New.
9540
9541 2019-05-08  Tom Tromey  <tom@tromey.com>
9542
9543         * symtab.c (struct symbol_cache): Add destructor and
9544         initializers.
9545         (symbol_cache_key): Move.  Change type.
9546         (make_symbol_cache, free_symbol_cache): Remove.
9547         (get_symbol_cache): Update.
9548         (symbol_cache_cleanup): Remove.
9549         (ALL_PSPACES, symbol_cache_flush)
9550         (maintenance_print_symbol_cache)
9551         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9552         Update.
9553
9554 2019-05-08  Tom Tromey  <tom@tromey.com>
9555
9556         * symtab.c (struct main_info): Add destructor and initializers.
9557         (main_progspace_key): Move.  Change type.
9558         (get_main_info): Update.
9559         (main_info_cleanup): Remove.
9560         (_initialize_symtab): Update.
9561
9562 2019-05-08  Tom Tromey  <tom@tromey.com>
9563
9564         * registry.h (DECLARE_REGISTRY): Define the _key class.
9565
9566 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * NEWS: Merge two 'New commands' sections.
9569
9570 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9571
9572         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9573         parameter and use Ada language definition instead.
9574         (ada_val_print_ptr): Remove unused language parameter.
9575         (ada_val_print_num): Remove language parameter and use Ada language
9576         definition instead.
9577         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9578         parameter.
9579         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9580         parameter and use Ada language definition instead.
9581         (ada_val_print_1): Update all ada_val_print_xxx calls.
9582         Remove language parameter.
9583         (ada_val_print): Update ada_val_print_1 call.
9584
9585 2019-05-08  Tom Tromey  <tromey@adacore.com>
9586
9587         * remote.c (remote_hw_watchpoint_limit)
9588         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9589         Now static.
9590
9591 2019-05-08  Tom Tromey  <tromey@adacore.com>
9592
9593         * maint.c (_initialize_maint_cmds): Move initialization code to
9594         remote.c.
9595         (watchdog, show_watchdog): Move to remote.c.
9596         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9597         "watchdog" static.
9598         (_initialize_remote): Move initialization code from maint.c.
9599         * defs.h (watchdog): Don't declare.
9600
9601 2019-05-08  Tom Tromey  <tromey@adacore.com>
9602
9603         * tui/tui-interp.c: Include main.h.
9604         * interps.c: Include main.h.
9605         * main.h (interpreter_p): Declare.
9606         * defs.h (interpreter_p): Don't declare.
9607
9608 2019-05-08  Tom Tromey  <tromey@adacore.com>
9609
9610         * dwarf2loc.c: Include dwarf2read.h.
9611         * defs.h (read_unsigned_leb128): Don't declare.
9612         * dwarf2read.h (read_unsigned_leb128): Declare.
9613
9614 2019-05-08  Tom Tromey  <tromey@adacore.com>
9615
9616         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9617         method.
9618
9619 2019-05-08  Tom Tromey  <tromey@adacore.com>
9620
9621         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9622         when no wrap column is set.
9623
9624 2019-05-08  Tom Tromey  <tromey@adacore.com>
9625
9626         * c-lang.c (c_get_string): Handle non-C-style arrays.
9627
9628 2019-05-08  Tom Tromey  <tromey@adacore.com>
9629
9630         * typeprint.c (print_offset_data::update): Print the bit offset,
9631         not the number of bits remaining.
9632
9633 2019-05-08  Tom Tromey  <tromey@adacore.com>
9634
9635         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9636         padding at end of comment.
9637
9638 2019-05-08  Tom Tromey  <tromey@adacore.com>
9639
9640         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9641         Compare main types.
9642
9643 2019-05-06  Tom Tromey  <tom@tromey.com>
9644
9645         * common/scoped_mmap.c: Include common-defs.h.
9646         * common/scoped_mmap.h: Don't include config.h.
9647
9648 2019-05-04  Tom Tromey  <tom@tromey.com>
9649
9650         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9651         (struct aarch64_call_info): Add initializers.
9652         <si>: Now a std::vector.
9653         (pass_on_stack, aarch64_push_dummy_call): Update.
9654
9655 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9656             Tom Tromey  <tom@tromey.com>
9657
9658         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9659         (ppc_threads): Now a std::vector.  Now static.
9660         (hwdebug_find_thread_points_by_tid)
9661         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9662         Update.
9663
9664 2019-05-04  Tom Tromey  <tom@tromey.com>
9665
9666         * arc-tdep.c (arc_tdesc_init): Return bool.
9667
9668 2019-05-04  Tom Tromey  <tom@tromey.com>
9669
9670         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9671         Use gdb_assert_not_reached.
9672
9673 2019-05-04  Tom Tromey  <tom@tromey.com>
9674
9675         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9676         "false".
9677
9678 2019-05-04  Tom Tromey  <tom@tromey.com>
9679
9680         * arc-tdep.c (arc_tdesc_init): Use bool.
9681
9682 2019-05-04  Tom Tromey  <tom@tromey.com>
9683
9684         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9685
9686 2019-05-04  Tom Tromey  <tom@tromey.com>
9687
9688         * cli/cli-cmds.c (valid_command_p): Return bool.
9689
9690 2019-05-04  Tom Tromey  <tom@tromey.com>
9691
9692         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9693         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9694
9695 2019-05-04  Raul Tambre  <raul@tambre.ee>
9696
9697         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9698         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9699         operator for comparison.
9700
9701 2019-05-04  Tom Tromey  <tom@tromey.com>
9702
9703         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9704         (lookup_partial_symbol, print_partial_symbols)
9705         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9706         (psymbol_compare): Update.
9707         (add_psymbol_to_bcache): Clear the entire psymbol.
9708         (maintenance_check_psymtabs): Update.
9709         * psympriv.h (struct partial_symbol): Don't derive from
9710         general_symbol_info.
9711         <obj_section, unrelocated_address, address,
9712         set_unrelocated_address>: Update.
9713         <ginfo>: New member.
9714         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9715         (debug_names::write_psymbols): Update.
9716
9717 2019-05-04  Tom de Vries  <tdevries@suse.de>
9718
9719         * contrib/cc-with-tweaks.sh: Support -n arg.
9720
9721 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9722
9723         * corelow.c (core_target::detach): Ensure frame cache and
9724         register caches are cleared.
9725         inferior.c (exit_inferior_1): Likewise.
9726
9727 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9728             Tom Tromey  <tom@tromey.com>
9729
9730         * dictionary.c (collate_pending_symbols_by_language): Remove
9731         "struct" from foreach.
9732         * symtab.c (lookup_global_symbol_from_objfile)
9733         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9734         foreach.
9735         * ser-tcp.c (net_open): Remove "struct" from foreach.
9736         * objfiles.c (objfile_relocate, objfile_rebase)
9737         (objfile_has_symbols): Remove "struct" from foreach.
9738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9739         from foreach.
9740         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9741         foreach.
9742         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9743         "struct" from foreach.
9744         * ada-lang.c (create_excep_cond_exprs)
9745         (ada_exception_catchpoint_cond_string): Remove "struct" from
9746         foreach.
9747
9748 2019-05-03  Tom Tromey  <tromey@adacore.com>
9749
9750         * ada-exp.y (convert_char_literal): Check suffix of each
9751         enumerator.
9752
9753 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9754
9755         PR ada/21406:
9756         * ada-exp.y (yywrap): Don't define.
9757         * ada-lex.l (%option): Add noyywrap
9758         (yywrap): Remove.
9759
9760 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9761
9762         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9763         _WIN32_WINNT to the XP level, unless already defined to a higher
9764         level.
9765
9766         * unittests/parse-connection-spec-selftests.c:
9767         * ser-tcp.c:
9768         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9769         override.
9770
9771         * symfile.c (find_separate_debug_file): Remove colon from the
9772         drive spec of DOS/Windows file names of the target, so that the
9773         file name produced from DEBUGDIR and the target's directory will
9774         be valid on DOS/Windows systems.
9775
9776 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * rust-lang.c (val_print_struct): Handle printing structures
9779         containing strings.
9780
9781 2019-05-02  Tom Tromey  <tromey@adacore.com>
9782
9783         * valarith.c (_initialize_valarith): Remove.
9784
9785 2019-05-01  Tom Tromey  <tromey@adacore.com>
9786
9787         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9788         bitfields.
9789
9790 2019-05-01  Tom Tromey  <tromey@adacore.com>
9791
9792         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9793         for big-endian copies.
9794
9795 2019-04-30  Ali Tamur  <tamur@google.com>
9796         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9797         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9798         (read_3_bytes): New function.
9799
9800 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9801
9802         * windows-nat.c (main_thread_id): Delete.
9803         (handle_output_debug_string): Replace main_thread_id by
9804         current_event.dwThreadId.
9805         (fake_create_process): Likewise.
9806         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9807         Do not set main_thread_id.
9808         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9809         current_event.dwThreadId.
9810         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9811
9812 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9813
9814         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9815         Use current_event.dwThreadId instead of main_thread_id.
9816
9817 2019-04-30  Tom Tromey  <tromey@adacore.com>
9818
9819         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9820         (create_excep_cond_exprs): Iterate over program spaces.
9821         (ada_exception_catchpoint_cond_string): Examine all minimal
9822         symbols for exception types.
9823
9824 2019-04-30  Tom Tromey  <tromey@adacore.com>
9825
9826         PR c++/24470:
9827         * dwarf2read.c (process_structure_scope): Handle case where type
9828         has template parameters but no symbol was created.
9829
9830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9831             Chris January  <chris.january@arm.com>
9832
9833         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9834         qualifier.
9835         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9836
9837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * f-typeprint.c (f_print_type): Update rules for printing
9840         whitespace.
9841         (f_type_print_varspec_suffix): Likewise.
9842
9843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9844             Chris January  <chris.january@arm.com>
9845
9846         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9847         function arguments.
9848
9849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * f-lang.c (build_fortran_types): Change name of void type to
9852         lower case.
9853         * f-typeprint.c (f_type_print_base): Print the name of the void
9854         type, rather than a fixed string.
9855         * f-valprint.c (f_decorations): Use lower case void string.
9856
9857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9858             Chris January  <chris.january@arm.com>
9859
9860         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9861         types for Fortran.
9862
9863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9864             Chris January  <chris.january@arm.com>
9865             David Lecomber  <david.lecomber@arm.com>
9866
9867         * f-exp.y (BINOP_INTRINSIC): New token.
9868         (exp): New parser rule handling BINOP_INTRINSIC.
9869         (f77_keywords): Add new builtin procedures.
9870         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9871         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9872         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9873         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9874         (print_unop_subexp_f): New function.
9875         (print_binop_subexp_f): New function.
9876         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9877         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9878         (dump_subexp_body_f): Likewise.
9879         (operator_check_f): Likewise.
9880         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9881         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9882
9883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9884
9885         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9886         UNOP_KIND.
9887         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9888         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9889         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9890         (operator_length_f): New fuction.
9891         (print_subexp_f): New function.
9892         (op_name_f): New function.
9893         (dump_subexp_body_f): New function.
9894         (operator_check_f): New function.
9895         (exp_descriptor_f): Replace standard expression handling functions
9896         with new functions.
9897         * gdb/fortran-operator.def: New file.
9898         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9899         * gdb/std-operator.def: Remove UNOP_KIND.
9900
9901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9902
9903         * std-operator.def: Remove unbalanced, stray double quote
9904         character.
9905
9906 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9907             Chris January  <chris.january@arm.com>
9908             Daniel Everett  <daniel.everett@arm.com>
9909             Nick Forrington  <nick.forrington@arm.com>
9910             Richard Bunt  <richard.bunt@arm.com>
9911
9912         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9913         of depth when printing anonymous structs or unions.
9914         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9915         Don't print either the top-level value, or the children if the
9916         max-depth is exceeded.
9917         (ppscm_print_children): When printing the key of a map, allow one
9918         extra level of depth.
9919         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9920         print either the top-level value, or the children if the max-depth
9921         is exceeded.
9922         (print_children): When printing the key of a map, allow one extra
9923         level of depth.
9924         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9925         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9926         (user_print_options): Initialise max_depth field.
9927         (val_print_scalar_or_string_type_p): New function.
9928         (val_print): Check to see if the max depth has been reached.
9929         (val_print_check_max_depth): Define new function.
9930         (show_print_max_depth): New function.
9931         (_initialize_valprint): Add 'print max-depth' option.
9932         * valprint.h (struct value_print_options) <max_depth>: New field.
9933         (val_print_check_max_depth): Declare new function.
9934         * NEWS: Document new feature.
9935
9936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         * ada-lang.c (ada_language_defn): Initialise new field.
9939         * c-lang.c (c_is_string_type_p): New function.
9940         (c_language_defn): Initialise new field.
9941         (cplus_language_defn): Initialise new field.
9942         (asm_language_defn): Initialise new field.
9943         (minimal_language_defn): Initialise new field.
9944         * c-lang.h (c_is_string_type_p): Declare new function.
9945         * d-lang.c (d_language_defn): Initialise new field.
9946         * f-lang.c (f_is_string_type_p): New function.
9947         (f_language_defn): Initialise new field.
9948         * go-lang.c (go_is_string_type_p): New function.
9949         (go_language_defn): Initialise new field.
9950         * language.c (default_is_string_type_p): New function.
9951         (unknown_language_defn): Initialise new field.
9952         (auto_language_defn): Initialise new field.
9953         * language.h (struct language_defn) <la_is_string_type_p>: New
9954         member variable.
9955         (default_is_string_type_p): Declare new function.
9956         * m2-lang.c (m2_language_defn): Initialise new field.
9957         * objc-lang.c (objc_language_defn): Initialise new field.
9958         * opencl-lang.c (opencl_language_defn): Initialise new field.
9959         * p-lang.c (pascal_is_string_type_p): New function.
9960         (pascal_language_defn): Initialise new field.
9961         * rust-lang.c (rust_is_string_type_p): New function.
9962         (rust_language_defn): Initialise new field.
9963
9964 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9965
9966         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9967         New field.
9968         * ada-lang.c (ada_language_defn): Initialise new field.
9969         * c-lang.c (c_language_defn): Likewise.
9970         (cplus_language_defn): Likewise.
9971         (asm_language_defn): Likewise.
9972         (minimal_language_defn): Likewise.
9973         * d-lang.c (d_language_defn): Likewise.
9974         * f-lang.c (f_language_defn): Likewise.
9975         * go-lang.c (go_language_defn): Likewise.
9976         * language.c (unknown_language_defn): Likewise.
9977         (auto_language_defn): Likewise.
9978         * m2-lang.c (m2_language_defn): Likewise.
9979         * objc-lang.c (objc_language_defn): Likewise.
9980         * opencl-lang.c (opencl_language_defn): Likewise.
9981         * p-lang.c (pascal_language_defn): Likewise.
9982         * rust-lang.c (rust_language_defn): Likewise.
9983
9984 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9985
9986         * ada-lang.c (ada_is_character_type): Change return type to bool.
9987         (ada_is_string_type): Likewise.
9988         * ada-lang.h (ada_is_character_type): Update declaration
9989         (ada_is_string_type): Likewise.
9990
9991 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9992
9993         Support style in 'frame|thread apply'
9994
9995         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9996         * record.c (record_start, record_stop): Update callers of
9997         execute_command_to_string with false.
9998         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9999         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10000         methods.
10001         (class string_file): New constructor with term_out parameter.
10002         Override methods term_out and can_emit_style_escape.  New member
10003         term_out.
10004         (class stdio_file): Override can_emit_style_escape.
10005         (class tee_file): Override term_out and can_emit_style_escape.
10006         * utils.h (can_emit_style_escape): Remove.
10007         * utils.c (can_emit_style_escape): Likewise.
10008         Update all callers of can_emit_style_escape (SOMESTREAM) to
10009         SOMESTREAM->can_emit_style_escape.
10010         * source-cache.c (source_cache::get_source_lines): Likewise.
10011         * stack.c (frame_apply_command_count): Call execute_command_to_string
10012         passing the term_out characteristic of the current gdb_stdout.
10013         * thread.c (thr_try_catch_cmd): Likewise.
10014         * top.c (execute_command_to_string): pass term_out parameter
10015         to construct the string_file for the command output.
10016         * ui-file.c (term_cli_styling): New function (most code moved
10017         from utils.c can_emit_style_escape).
10018         (string_file::string_file, string_file::can_emit_style_escape,
10019         stdio_file::can_emit_style_escape, tee_file::term_out,
10020         tee_file::can_emit_style_escape): New functions.
10021
10022 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10023
10024         * NEWS: Mention the new set|show may-call-functions.
10025         * infcall.c (may_call_functions_p): New variable.
10026         (show_may_call_functions_p): New function.
10027         (call_function_by_hand_dummy): Throws an error if not
10028         may-call-functions.
10029         (_initialize_infcall): Call add_setshow_boolean_cmd for
10030         may-call-functions.
10031
10032 2019-04-25  Keith Seitz  <keiths@redhat.com>
10033
10034         PR c++/24367
10035         * cp-support.c (inspect_type): Don't attempt substitutions
10036         of symbol with the same name.
10037
10038 2019-04-25  Tom Tromey  <tromey@adacore.com>
10039
10040         PR gdb/24475:
10041         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10042         static.
10043
10044 2019-04-25  Tom Tromey  <tromey@adacore.com>
10045
10046         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10047         rvalue reference.
10048         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10049         (gdb_xml_parser::parse): Use std::move.
10050         * python/python-internal.h (gdbpy_convert_exception): Take a const
10051         reference.
10052         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10053         std::move.
10054         * python/py-utils.c (gdbpy_convert_exception): Take a const
10055         reference.
10056         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10057         Use std::move.
10058         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10059         Use std::move.
10060         * mi/mi-main.c (mi_print_exception): Take a const reference.
10061         * main.c (handle_command_errors): Take a const reference.
10062         * linespec.c (parse_linespec): Use std::move.
10063         * infcall.c (run_inferior_call): Use std::move.
10064         (call_function_by_hand_dummy): Use std::move.
10065         * exec.c (try_open_exec_file): Use std::move.
10066         * exceptions.h (exception_print, exception_fprintf)
10067         (exception_print_same): Update.
10068         * exceptions.c (print_exception, exception_print)
10069         (exception_fprintf, exception_print_same): Change parameters to
10070         const reference.
10071         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10072         * common/new-op.c: Use std::move.
10073         * common/common-exceptions.h (struct gdb_exception): Add move
10074         constructor.
10075         (struct gdb_exception_error, struct gdb_exception_quit, struct
10076         gdb_quit_bad_alloc): Change constructor to move constructor.
10077         (throw_exception): Change parameter to rvalue reference.
10078         * common/common-exceptions.c (throw_exception): Take rvalue
10079         reference.
10080         * cli/cli-interp.c (safe_execute_command): Use std::move.
10081         * breakpoint.c (insert_bp_location, location_to_sals): Use
10082         std::move.
10083
10084 2019-04-25  Tom Tromey  <tromey@adacore.com>
10085
10086         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10087         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10088         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10089         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10090         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10091         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10092         guile/scm-value.c: Use unpack.
10093         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10094         gdbscm_gdb_exception.
10095         (gdbscm_throw_gdb_exception): Likewise.
10096         (struct gdbscm_gdb_exception): New.
10097         (unpack): New function.
10098         (gdbscm_wrap): Use unpack.
10099
10100 2019-04-25  Tom Tromey  <tromey@adacore.com>
10101
10102         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10103         (gdb_rl_callback_handler): Use std::move.
10104         * common/common-exceptions.h (struct gdb_exception): Add move
10105         assignment operator.
10106         (throw_exception_sjlj): Change "exception" to const reference.
10107         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10108         (throw_exception_sjlj): Change "exception" to const reference.
10109
10110 2019-04-25  Tom Tromey  <tromey@adacore.com>
10111
10112         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10113         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10114         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10115         Update.
10116         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10117         Update.
10118         * mi/mi-interp.c (mi_interp::exec): Update.
10119         * linespec.c (parse_linespec): Update.
10120         * infcall.c (run_inferior_call): Update.
10121         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10122         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10123         (gdbscm_lookup_global_symbol): Update.
10124         * guile/scm-param.c (gdbscm_parameter_value): Update.
10125         * guile/scm-frame.c (gdbscm_frame_read_register)
10126         (gdbscm_frame_read_var): Update.
10127         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10128         * exec.c (try_open_exec_file): Update.
10129         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10130         (gdb_rl_callback_handler): Update.
10131         * common/common-exceptions.h (exception_none): Don't declare.
10132         * common/common-exceptions.c (exception_none): Don't define.
10133         (struct catcher) <exception>: Update.
10134         * cli/cli-interp.c (safe_execute_command): Update.
10135         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10136
10137 2019-04-25  Ali Tamur  <tamur@google.com>
10138
10139         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10140         (read_attribute_value): Likewise.
10141         (dwarf2_read_addr_index): Update comment.
10142         (read_str_index): Add DW_FORM_strx.
10143         (dwarf2_string_attr): Likewise.
10144         (dwarf2_const_value_attr): Likewise.
10145         (dump_die_shallow): Likewise.
10146         (dwarf2_fetch_constant_bytes): Likewise.
10147         (skip_form_bytes): Likewise.
10148         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10149
10150 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10151
10152         PR corefiles/11608
10153         PR corefiles/18187
10154         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10155         OFFSET.  Verify if current mapping contains an ELF header.
10156         (linux_find_memory_regions_full): Adjust call to
10157         dump_mapping_p.
10158
10159 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10160             Kang Li <kanglictf@gmail.com>
10161
10162         PR gdb/21600
10163
10164         * dwarf2-frame.c (read_initial_length): Be consistent about using
10165         unsigned representation of length.
10166         (decode_frame_entry_1): Likewise.  Check for wraparound of
10167         end pointer as well as buffer overflow.
10168
10169 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10170
10171         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10172         "vq".
10173
10174 2019-04-24  Tom Tromey  <tromey@adacore.com>
10175
10176         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10177
10178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10179
10180         * s12z-tdep.c (s12z_unwind_pc): Delete.
10181         (s12z_unwind_sp): Delete.
10182         (s12z_gdbarch_init): Don't register deleted functions with
10183         gdbarch.
10184
10185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10186
10187         * rl78-tdep.c (rl78_unwind_sp): Delete.
10188         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10189
10190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10191
10192         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10193         (xstormy16_unwind_pc): Delete.
10194         (xstormy16_dummy_id): Delete.
10195         (xstormy16_gdbarch_init): Don't register deleted functions with
10196         gdbarch.
10197
10198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10199
10200         * vax-tdep.c (vax_unwind_pc): Delete.
10201         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10202
10203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10204
10205         * v850-tdep.c (v850_unwind_sp): Delete.
10206         (v850_unwind_pc): Delete.
10207         (v850_dummy_id): Delete.
10208         (v850_gdbarch_init): Don't register deleted functions with
10209         gdbarch.
10210
10211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10212
10213         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10214         (tilegx_unwind_pc): Delete.
10215         (tilegx_unwind_dummy_id): Delete.
10216         (tilegx_gdbarch_init): Don't register deleted functions with
10217         gdbarch.
10218
10219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10220
10221         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10222         (tic6x_dummy_id): Delete.
10223         (tic6x_gdbarch_init): Don't register deleted functions with
10224         gdbarch.
10225
10226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10227
10228         * sparc-tdep.c (sparc_unwind_pc): Delete.
10229         (sparc32_gdbarch_init): Don't register deleted function with
10230         gdbarch.
10231
10232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10233
10234         * sh-tdep.c (sh_unwind_sp): Delete.
10235         (sh_unwind_pc): Delete.
10236         (sh_dummy_id): Delete.
10237         (sh_gdbarch_init): Don't register deleted functions with
10238         gdbarch.
10239
10240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * score-tdep.c (score_unwind_sp): Delete.
10243         (score_unwind_pc): Delete.
10244         (score_dummy_id): Delete.
10245         (score_gdbarch_init): Don't register deleted functions with
10246         gdbarch.
10247
10248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10249
10250         * rx-tdep.c (rx_unwind_pc): Delete.
10251         (rx_unwind_sp): Delete.
10252         (rx_dummy_id): Delete.
10253         (rx_gdbarch_init): Don't register deleted functions with
10254         gdbarch.  Update comment.
10255
10256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10257
10258         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10259         (rs6000_dummy_id): Delete.
10260         (rs6000_gdbarch_init): Don't register deleted functions with
10261         gdbarch.
10262
10263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10264
10265         * or1k-tdep.c (or1k_dummy_id): Delete.
10266         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10267
10268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10269
10270         * nios2-tdep.c (nios2_dummy_id): Delete.
10271         (nios2_unwind_sp): Delete.
10272         (nios2_gdbarch_init): Don't register deleted functions with
10273         gdbarch.
10274
10275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10276
10277         * nds32-tdep.c (nds32_dummy_id): Delete.
10278         (nds32_unwind_pc): Delete.
10279         (nds32_unwind_sp): Delete.
10280         (nds32_gdbarch_init): Don't register deleted functions with
10281         gdbarch.
10282
10283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * msp430-tdep.c (msp430_unwind_pc): Delete.
10286         (msp430_unwind_sp): Delete.
10287         (msp430_dummy_id): Delete.
10288         (msp430_gdbarch_init): Don't register deleted functions with
10289         gdbarch.
10290
10291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10292
10293         * moxie-tdep.c (moxie_unwind_sp): Delete.
10294         (moxie_unwind_pc): Delete.
10295         (moxie_dummy_id): Delete.
10296         (moxie_gdbarch_init): Don't register deleted functions with
10297         gdbarch.
10298
10299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10300
10301         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10302         (mn10300_unwind_pc): Delete.
10303         (mn10300_unwind_sp): Delete.
10304         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10305         mn10300_unwind_sp.
10306         (mn10300_frame_unwind_init): Don't register deleted functions with
10307         gdbarch.
10308
10309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * mep-tdep.c (mep_unwind_pc): Delete.
10312         (mep_unwind_sp): Delete.
10313         (mep_dummy_id): Delete.
10314         (mep_gdbarch_init): Don't register deleted functions with
10315         gdbarch.
10316
10317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10318
10319         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10320         (m68hc11_unwind_sp): Delete.
10321         (m68hc11_gdbarch_init): Don't register deleted functions with
10322         gdbarch.
10323
10324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10325
10326         * m32r-tdep.c (m32r_unwind_sp): Delete.
10327         (m32r_unwind_pc): Delete.
10328         (m32r_dummy_id): Delete.
10329         (m32r_gdbarch_init): Don't register deleted functions with
10330         gdbarch.
10331
10332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10333
10334         * m32c-tdep.c (m32c_unwind_pc): Delete.
10335         (m32c_unwind_sp): Delete.
10336         (m32c_dummy_id): Delete.
10337         (m32c_gdbarch_init): Don't register deleted functions with
10338         gdbarch.
10339
10340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10341
10342         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10343         (lm32_unwind_pc): Delete.
10344         (lm32_dummy_id): Delete.
10345         (lm32_gdbarch_init): Don't register deleted functions with
10346         gdbarch.
10347
10348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10349
10350         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10351         (iq2000_unwind_pc): Delete.
10352         (iq2000_dummy_id): Delete.
10353         (iq2000_gdbarch_init): Don't register deleted functions with
10354         gdbarch.
10355
10356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10357
10358         * nds32-tdep.c (nds32_type_align): Delete.
10359         (nds32_push_dummy_call): Use type_align instead.
10360
10361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10362
10363         * arm-tdep.c (arm_type_align): Only handle vector override case.
10364         (arm_push_dummy_call): Use type_align.
10365         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10366
10367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10370         case.
10371         (pass_on_stack): Use type_align.
10372         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10373         function.
10374
10375 2019-04-23  Tom Tromey  <tromey@adacore.com>
10376
10377         * dwarf2read.c (line_header::file_name_at): Remove unused
10378         overload.
10379
10380 2019-04-23  Tom de Vries  <tdevries@suse.de>
10381
10382         PR gdb/24438
10383         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10384         invocation.
10385
10386
10387 2019-03-27  Ali Tamur  <tamur@google.com>
10388
10389         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10390         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10391         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10392         (dwarf_expr_context::get_addr_index): Likewise
10393         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10394         (symbol_needs_eval_context::get_addr_index): Likewise
10395         (disassemble_dwarf_expression): Add DW_OP_addrx
10396         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10397         (read_cutu_die_from_dwo): Update comment
10398         (skip_one_die): Add DW_FORM_addrx
10399         (read_attribute_value): Likewise
10400         (var_decode_location): Add DW_OP_addrx
10401         (dwarf2_const_value_attr): Add DW_FORM_addrx
10402         (dump_die_shallow): Likewise
10403         (dwarf2_fetch_constant_bytes): Likewise
10404         (decode_locdesc): Add DW_OP_addrx
10405         (skip_form_bytes): Add DW_FORM_addrx
10406
10407 2019-04-22  Ali Tamur  <tamur@google.com>
10408
10409         * MAINTAINERS (Write After Approval): Add self.
10410
10411 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10412
10413         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10414         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10415         (open_symbol_file_object): Likewise.
10416         (svr4_default_sos): Add info parameter.
10417         (svr4_read_so_list): Likewise.
10418         (svr4_current_sos_direct): Adjust functions calls to pass down
10419         info.
10420         (svr4_current_sos_1): Add info parameter.
10421         (svr4_current_sos): Call get_svr4_info, pass info down to
10422         svr4_current_sos_1.
10423         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10424         get_svr4_info.
10425         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10426         get_svr4_info.
10427         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10428         to get_svr4_info.
10429         (probes_table_remove_objfile_probes): Likewise.
10430         (register_solib_event_probe): Add info parameter.
10431         (solist_update_incremental): Pass info parameter down to
10432         svr4_read_so_list.
10433         (disable_probes_interface): Add info parameter.
10434         (svr4_handle_solib_event): Pass current_program_space to
10435         get_svr4_info.  Adjust disable_probes_interface cleanup.
10436         (svr4_create_probe_breakpoints): Add info parameter, pass it
10437         down to register_solib_event_probe.
10438         (svr4_create_solib_event_breakpoints): Add info parameter,
10439         pass it down to svr4_create_probe_breakpoints.
10440         (enable_break): Pass info down to
10441         svr4_create_solib_event_breakpoints.
10442         (svr4_solib_create_inferior_hook): Pass current_program_space to
10443         get_svr4_info.
10444         (svr4_clear_solib): Likewise.
10445
10446 2019-04-22  Pedro Alves  <palves@redhat.com>
10447
10448         * solib-svr4.c (svr4_free_objfile_observer): New.
10449         (probe_and_action::objfile): New field.
10450         (probes_table_htab_remove_objfile_probes)
10451         (probes_table_remove_objfile_probes): New functions.
10452         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10453         in the new probe_and_action.  Don't store the probe in 'lookup'.
10454         (svr4_create_probe_breakpoints): Pass objfile to
10455         register_solib_event_probe.
10456         (_initialize_svr4_solib): Register a free_objfile observer.
10457
10458 2019-04-19  Tom Tromey  <tom@tromey.com>
10459
10460         * common/queue.h: Remove.
10461
10462 2019-04-19  Tom Tromey  <tom@tromey.com>
10463
10464         * event-loop.c: Don't include "common/queue.h".
10465
10466 2019-04-19  Tom Tromey  <tom@tromey.com>
10467
10468         * remote.c (remote_target): Use delete.
10469         * remote-notif.h: Include <list>, not "common/queue.h".
10470         (notif_client_p): Remove typedef.
10471         (remote_notif_state): Add constructor, destructor, initializer.
10472         <notif_queue>: Now a std::list.
10473         (remote_notif_state_xfree): Don't declare.
10474         * remote-notif.c (remote_notif_process, handle_notification)
10475         (remote_notif_state_allocate): Update.
10476         (~remote_notif_state): Rename from remote_notif_state_xfree.
10477
10478 2019-04-19  Tom Tromey  <tom@tromey.com>
10479
10480         * symfile.c (reread_symbols): Update.
10481         * objfiles.c (objfile_register_static_link)
10482         (objfile_lookup_static_link): Update
10483         (~objfile) Don't delete static_links.
10484         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10485
10486 2019-04-19  Tom Tromey  <tom@tromey.com>
10487
10488         * type-stack.h (struct type_stack) <insert>: Constify string.
10489         * type-stack.c (type_stack::insert): Constify string.
10490         * gdbtypes.h (lookup_template_type): Update.
10491         (address_space_name_to_int): Update.
10492         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10493         const.
10494         (lookup_template_type): Make name const.
10495         * c-exp.y: Update rules.
10496         (lex_one_token, classify_name, classify_inner_name)
10497         (c_print_token): Update.
10498         * p-exp.y: Update rules.
10499         (yylex): Update.
10500         * f-exp.y: Update rules.
10501         (yylex): Update.
10502         * d-exp.y: Update rules.
10503         (lex_one_token, classify_name, classify_inner_name): Update.
10504         * parse.c (write_dollar_variable, copy_name): Return std::string.
10505         * parser-defs.h (copy_name): Change return type.
10506         * m2-exp.y: Update rules.
10507         (yylex): Update.
10508         * go-exp.y (lex_one_token): Update.
10509         Update rules.
10510         (classify_unsafe_function, classify_packaged_name)
10511         (classify_name, yylex): Update.
10512
10513 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10514
10515         * configure.ac: add --enable-source-highlight switch.
10516         * configure: Regenerate.
10517         * top.c (print_gdb_version): plumb --enable-source-highlight
10518         status to "show configuration".
10519
10520 2019-04-19  Tom Tromey  <tromey@adacore.com>
10521
10522         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10523         Check ADA_TYPE_P.
10524         (empty_record, ada_template_to_fixed_record_type_1)
10525         (template_to_static_fixed_type)
10526         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10527         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10528         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10529         macros.
10530
10531 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10532
10533         PR symtab/24423:
10534         * source.c (print_source_lines_base): Advance "iter" when a
10535         control character is seen.
10536
10537 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10538
10539         * inferior.h (struct infcall_suspend_state_deleter):
10540         Catch exception in destructor to avoid crash.
10541
10542 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10543
10544         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10545         close to the add_com "shell".
10546
10547 2019-04-18  Tom Tromey  <tromey@adacore.com>
10548
10549         * process-stratum-target.h (class process_stratum_target)
10550         <stratum>: Add "final".
10551
10552 2019-04-17  Tom Tromey  <tromey@adacore.com>
10553
10554         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10555         against nullptr before use.
10556
10557 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10558
10559         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10560
10561 2019-04-17  Jim Wilson  <jimw@sifive.com>
10562             Andrew Burgess  <andrew.burgess@embecosm.com>
10563
10564         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10565         code read might fail, assume 4-byte breakpoint in that case.
10566
10567 2019-04-15  Leszek Swirski  <leszeks@google.com>
10568
10569         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10570         rather than a hand-rolled POD check when checking for forced MEMORY
10571         classification.
10572
10573 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10574
10575         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10576         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10577         function.
10578         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10579         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10580         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10581         declaration.
10582
10583 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10584
10585         * aarch64-linux-nat.c
10586         (aarch64_linux_nat_target::thread_architecture): Add override.
10587         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10588         each VQ.
10589
10590 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10591
10592         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10593
10594 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10595
10596         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10597         target types of size 96-bits, add some additional comments, and
10598         check that the builtin type we found was the correct size.
10599
10600 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10601
10602         * utils.c (prompt_for_continue): Don't restore the styling at the
10603         end, as applied_style has the wrong value.  This fixes styling in
10604         long lists of file names that are interrupted by the "Continue?"
10605         prompt.
10606
10607 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10608
10609         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10610         * c-lang.c (c_language_defn): Likewise.
10611         (cplus_language_defn): Likewise.
10612         (asm_language_defn): Likewise.
10613         (minimal_language_defn): Likewise.
10614         * d-lang.c (d_language_defn): Likewise.
10615         * f-lang.c (f_language_defn): Likewise.
10616         * go-lang.c (go_language_defn): Likewise.
10617         * language.c (unknown_language_defn): Likewise.
10618         (auto_language_defn): Likewise.
10619         * language.h (struct language_defn): Remove la_magic field.
10620         (LANG_MAGIC): Delete.
10621         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10622         * objc-lang.c (objc_language_defn): Likewise.
10623         * opencl-lang.c (opencl_language_defn): Likewise.
10624         * p-lang.c (pascal_language_defn): Likewise.
10625         * rust-lang.c (rust_language_defn): Likewise.
10626
10627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10628
10629         * riscv-tdep.c (riscv_type_align): New function.
10630         (riscv_type_alignment): Delete.
10631         (riscv_arg_location): Use 'type_align'.
10632         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10633
10634 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * gdbtypes.c (type_align): A struct with no non-static fields also
10637         has alignment of 1.
10638
10639 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10642         component to 0.
10643         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10644         member.
10645         (riscv_struct_info::analyse): New implementation using new
10646         analyse_inner member function.
10647         (riscv_struct_info::field_offset): New member function.
10648         (riscv_struct_info::m_offsets): New member variable.
10649         (riscv_struct_info::analyse_inner): New private member function,
10650         takes the old implementation of riscv_struct_info::analyse but
10651         extended to track field offsets.
10652         (riscv_call_arg_struct): Update the struct folding special cases
10653         to handle cases where empty C++ structs, which are non-zero
10654         length, are found.
10655         (riscv_arg_location): Initialise the length of each location, a
10656         non-zero length now indicates the location is in use.
10657         (riscv_push_dummy_call): Allow for the first location having a
10658         non-zero offset when setting up arguments.
10659         (riscv_return_value): Likewise, but for return values.
10660
10661 2019-04-11  Tom Tromey  <tromey@adacore.com>
10662
10663         * utils.c (internal_vproblem): Make "msg" const.
10664
10665 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10666
10667         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10668         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10669         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10670         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10671
10672 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10673
10674         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10675         function.
10676         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10677         of amd64_collect_native_gregset.
10678         (amd64_linux_nat_target::store_registers): Likewise.
10679
10680 2019-04-10  Tom Tromey  <tom@tromey.com>
10681
10682         * symtab.c (lookup_global_symbol_from_objfile)
10683         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10684         * objfiles.h (class separate_debug_iterator): New.
10685         (class separate_debug_range): New.
10686         (struct objfile) <separate_debug_objfiles>: New method.
10687         (objfile_separate_debug_iterate): Don't declare.
10688         * objfiles.c (separate_debug_iterator::operator++): Rename from
10689         objfile_separate_debug_iterate.
10690         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10691         iterator.
10692         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10693         iterator.
10694
10695 2019-04-10  Tom Tromey  <tom@tromey.com>
10696
10697         * symfile.c (reread_symbols): Remove old comment.
10698         * objfiles.c (free_all_objfiles): Fix a typo.
10699
10700 2019-04-10  Tom Tromey  <tom@tromey.com>
10701
10702         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10703         * minsyms.c (lookup_minimal_symbol): Use foreach.
10704         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10705         (lookup_minimal_symbol_solib_trampoline): Likewise.
10706         * symfile.c (reread_symbols): Use foreach.
10707
10708 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10709             Tom Tromey  <tromey@adacore.com>
10710
10711         PR rust/24414:
10712         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10713         (rust_lex_int_test): Change "value" to be LONGEST.
10714         (rust_lex_tests): Add test for long integer literal.
10715
10716 2019-04-09  Tom Tromey  <tromey@adacore.com>
10717
10718         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10719         to bool.
10720         (extended_remote_target::attach): Update.
10721         (remote_target::remote_notice_new_inferior): Update.
10722         (remote_target::add_current_inferior_and_thread): Update.
10723         * inferior.c (exit_inferior_1): Use "false".
10724         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10725
10726 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10727
10728         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10729         the "start" command.
10730
10731 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10732
10733         * python/py-inferior.c (infpy_thread_from_thread_handle):
10734         Adjust comments to reflect renaming of thread_from_thread_handle
10735         to thread_from_handle.  Adjust keywords.  Fix type error message.
10736         (inferior_object_methods): Add thread_from_handle.  Retain
10737         thread_from_thread_handle, but mark it as deprecated.
10738
10739 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10740
10741         * gdbthread.h (find_thread_by_handle): Revise declaration.
10742         * thread.c (find_thread_by_handle): Likewise.  Adjust
10743         implementation too.
10744         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10745         support for buffer objects as handles.
10746
10747 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10748
10749         * python/py-infthread.c (thpy_thread_handle): New function.
10750         (thread_object_methods): Register thpy_thread_handle.
10751
10752 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10753
10754         * gdbthread.h (thread_to_thread_handle): Declare.
10755         * thread.c (gdbtypes.h): Include.
10756         (thread_to_thread_handle): New function.
10757
10758         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10759         (target_thread_info_to_thread_handle): Declare.
10760         * target.c (target_thread_info_to_thread_handle): New function.
10761         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10762         * target-delegates.c: Regenerate.
10763
10764         * linux-thread-db.c (class thread_db_target): Add method
10765         thread_info_to_thread_handle.
10766         (thread_db_target::thread_info_to_thread_handle): Define.
10767         * remote.c (class remote_target): Add new method
10768         thread_info_to_thread_handle.
10769         (remote_target::thread_info_to_thread_handle): Define.
10770
10771 2019-04-08  Pedro Alves  <palves@redhat.com>
10772
10773         * common/common-exceptions.c (throw_exception): Don't create
10774         named object to throw; throw directly.
10775         (throw_it): Likewise.  Don't initialize gdb_exception::message
10776         here, with new; pass FMT and AP to the ctor instead.
10777         * common/common-exceptions.h: Include <string>.
10778         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10779         const char *, va_list)): New ctor.  Use std::make_shared.
10780         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10781         errors)): Delete.
10782         (gdb_exception_error::gdb_exception_error(enum errors, const char
10783         *, va_list)): New.
10784         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10785         Add assertion.
10786         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10787         errors)): Delete.
10788         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10789         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10790         Add assertion.
10791
10792 2019-04-08  Tom Tromey  <tom@tromey.com>
10793
10794         * valops.c (value_rtti_indirect_type): Replace throw_exception
10795         with throw.
10796         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10797         with throw.
10798         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10799         throw.
10800         * target.c (target_translate_tls_address): Replace throw_exception
10801         with throw.
10802         * stack.c (frame_apply_command_count): Replace throw_exception
10803         with throw.
10804         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10805         throw.
10806         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10807         with throw.
10808         * rs6000-tdep.c (rs6000_frame_cache)
10809         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10810         * remote.c: Replace throw_exception with throw.
10811         * record-full.c (record_full_message, record_full_wait_1)
10812         (record_full_restore): Replace throw_exception with throw.
10813         * record-btrace.c:
10814         (get_thread_current_frame_id, record_btrace_start_replaying)
10815         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10816         (cmd_record_btrace_start): Replace throw_exception with throw.
10817         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10818         throw.
10819         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10820         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10821         * linespec.c:
10822         (find_linespec_symbols): Replace throw_exception with throw.
10823         * infrun.c (displaced_step_prepare, resume): Replace
10824         throw_exception with throw.
10825         * infcmd.c (post_create_inferior): Replace throw_exception with
10826         throw.
10827         * inf-loop.c (inferior_event_handler): Replace throw_exception
10828         with throw.
10829         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10830         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10831         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10832         (get_prev_frame_always, get_frame_pc_if_available)
10833         (get_frame_address_in_block_if_available, get_frame_language):
10834         Replace throw_exception with throw.
10835         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10836         throw_exception with throw.
10837         * eval.c (fetch_subexp_value, evaluate_var_value)
10838         (evaluate_funcall, evaluate_subexp_standard): Replace
10839         throw_exception with throw.
10840         * dwarf2loc.c (call_site_find_chain)
10841         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10842         Replace throw_exception with throw.
10843         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10844         with throw.
10845         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10846         throw.
10847         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10848         * completer.c (complete_line_internal): Replace throw_exception
10849         with throw.
10850         * compile/compile-object-run.c (compile_object_run): Replace
10851         throw_exception with throw.
10852         * cli/cli-script.c (process_next_line): Replace throw_exception
10853         with throw.
10854         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10855         (btrace_enable, btrace_maint_update_pt_packets): Replace
10856         throw_exception with throw.
10857         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10858         throw_exception with throw.
10859         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10860         throw_exception with throw.
10861         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10862         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10863         * aarch64-tdep.c (aarch64_make_prologue_cache)
10864         (aarch64_make_stub_cache): Replace throw_exception with throw.
10865
10866 2019-04-08  Tom Tromey  <tom@tromey.com>
10867
10868         * common/common-exceptions.c (throw_exception): Rename from
10869         throw_exception_cxx.  Remove old copy.  Make argument const.
10870         (throw_it): Create and throw exception objects directly.
10871         * common/common-exceptions.h (throw_exception): Make argument
10872         const.
10873         (struct gdb_exception_error): Add constructor.
10874         (struct gdb_exception_quit): Add constructor.
10875
10876 2019-04-08  Tom Tromey  <tom@tromey.com>
10877
10878         * common/common-exceptions.h (exception_rethrow): Don't declare.
10879         (TRY_SJLJ): Update comment.
10880         (TRY, CATCH, END_CATCH): Remove.
10881         * common/common-exceptions.c (exception_rethrow): Remove.
10882
10883 2019-04-08  Tom Tromey  <tom@tromey.com>
10884
10885         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10886         Remove.
10887         (gdb_exception_error): Rename from
10888         gdb_exception_RETURN_MASK_ERROR.
10889         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10890         (gdb_quit_bad_alloc): Update.
10891         * aarch64-tdep.c: Update.
10892         * ada-lang.c: Update.
10893         * ada-typeprint.c: Update.
10894         * ada-valprint.c: Update.
10895         * amd64-tdep.c: Update.
10896         * arch-utils.c: Update.
10897         * break-catch-throw.c: Update.
10898         * breakpoint.c: Update.
10899         * btrace.c: Update.
10900         * c-varobj.c: Update.
10901         * cli/cli-cmds.c: Update.
10902         * cli/cli-interp.c: Update.
10903         * cli/cli-script.c: Update.
10904         * common/common-exceptions.c: Update.
10905         * common/new-op.c: Update.
10906         * common/selftest.c: Update.
10907         * compile/compile-c-symbols.c: Update.
10908         * compile/compile-cplus-symbols.c: Update.
10909         * compile/compile-object-load.c: Update.
10910         * compile/compile-object-run.c: Update.
10911         * completer.c: Update.
10912         * corelow.c: Update.
10913         * cp-abi.c: Update.
10914         * cp-support.c: Update.
10915         * cp-valprint.c: Update.
10916         * darwin-nat.c: Update.
10917         * disasm-selftests.c: Update.
10918         * dtrace-probe.c: Update.
10919         * dwarf-index-cache.c: Update.
10920         * dwarf-index-write.c: Update.
10921         * dwarf2-frame-tailcall.c: Update.
10922         * dwarf2-frame.c: Update.
10923         * dwarf2loc.c: Update.
10924         * dwarf2read.c: Update.
10925         * eval.c: Update.
10926         * event-loop.c: Update.
10927         * event-top.c: Update.
10928         * exec.c: Update.
10929         * f-valprint.c: Update.
10930         * fbsd-tdep.c: Update.
10931         * frame-unwind.c: Update.
10932         * frame.c: Update.
10933         * gdbtypes.c: Update.
10934         * gnu-v3-abi.c: Update.
10935         * guile/guile-internal.h: Update.
10936         * guile/scm-block.c: Update.
10937         * guile/scm-breakpoint.c: Update.
10938         * guile/scm-cmd.c: Update.
10939         * guile/scm-disasm.c: Update.
10940         * guile/scm-frame.c: Update.
10941         * guile/scm-lazy-string.c: Update.
10942         * guile/scm-math.c: Update.
10943         * guile/scm-param.c: Update.
10944         * guile/scm-ports.c: Update.
10945         * guile/scm-pretty-print.c: Update.
10946         * guile/scm-symbol.c: Update.
10947         * guile/scm-symtab.c: Update.
10948         * guile/scm-type.c: Update.
10949         * guile/scm-value.c: Update.
10950         * i386-linux-tdep.c: Update.
10951         * i386-tdep.c: Update.
10952         * inf-loop.c: Update.
10953         * infcall.c: Update.
10954         * infcmd.c: Update.
10955         * infrun.c: Update.
10956         * jit.c: Update.
10957         * language.c: Update.
10958         * linespec.c: Update.
10959         * linux-fork.c: Update.
10960         * linux-nat.c: Update.
10961         * linux-tdep.c: Update.
10962         * linux-thread-db.c: Update.
10963         * main.c: Update.
10964         * mi/mi-cmd-break.c: Update.
10965         * mi/mi-cmd-stack.c: Update.
10966         * mi/mi-interp.c: Update.
10967         * mi/mi-main.c: Update.
10968         * objc-lang.c: Update.
10969         * p-valprint.c: Update.
10970         * parse.c: Update.
10971         * ppc-linux-tdep.c: Update.
10972         * printcmd.c: Update.
10973         * python/py-arch.c: Update.
10974         * python/py-breakpoint.c: Update.
10975         * python/py-cmd.c: Update.
10976         * python/py-finishbreakpoint.c: Update.
10977         * python/py-frame.c: Update.
10978         * python/py-framefilter.c: Update.
10979         * python/py-gdb-readline.c: Update.
10980         * python/py-inferior.c: Update.
10981         * python/py-infthread.c: Update.
10982         * python/py-lazy-string.c: Update.
10983         * python/py-linetable.c: Update.
10984         * python/py-objfile.c: Update.
10985         * python/py-param.c: Update.
10986         * python/py-prettyprint.c: Update.
10987         * python/py-progspace.c: Update.
10988         * python/py-record-btrace.c: Update.
10989         * python/py-record.c: Update.
10990         * python/py-symbol.c: Update.
10991         * python/py-type.c: Update.
10992         * python/py-unwind.c: Update.
10993         * python/py-utils.c: Update.
10994         * python/py-value.c: Update.
10995         * python/python.c: Update.
10996         * record-btrace.c: Update.
10997         * record-full.c: Update.
10998         * remote-fileio.c: Update.
10999         * remote.c: Update.
11000         * riscv-tdep.c: Update.
11001         * rs6000-aix-tdep.c: Update.
11002         * rs6000-tdep.c: Update.
11003         * rust-exp.y: Update.
11004         * rust-lang.c: Update.
11005         * s390-tdep.c: Update.
11006         * selftest-arch.c: Update.
11007         * solib-dsbt.c: Update.
11008         * solib-frv.c: Update.
11009         * solib-spu.c: Update.
11010         * solib-svr4.c: Update.
11011         * solib.c: Update.
11012         * sparc64-linux-tdep.c: Update.
11013         * stack.c: Update.
11014         * symfile-mem.c: Update.
11015         * symmisc.c: Update.
11016         * target.c: Update.
11017         * thread.c: Update.
11018         * top.c: Update.
11019         * tracefile-tfile.c: Update.
11020         * tui/tui.c: Update.
11021         * typeprint.c: Update.
11022         * unittests/cli-utils-selftests.c: Update.
11023         * unittests/parse-connection-spec-selftests.c: Update.
11024         * valops.c: Update.
11025         * valprint.c: Update.
11026         * value.c: Update.
11027         * varobj.c: Update.
11028         * windows-nat.c: Update.
11029         * x86-linux-nat.c: Update.
11030         * xml-support.c: Update.
11031
11032 2019-04-08  Tom Tromey  <tom@tromey.com>
11033
11034         * xml-support.c: Use C++ exception handling.
11035         * x86-linux-nat.c: Use C++ exception handling.
11036         * windows-nat.c: Use C++ exception handling.
11037         * varobj.c: Use C++ exception handling.
11038         * value.c: Use C++ exception handling.
11039         * valprint.c: Use C++ exception handling.
11040         * valops.c: Use C++ exception handling.
11041         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11042         handling.
11043         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11044         * typeprint.c: Use C++ exception handling.
11045         * tui/tui.c: Use C++ exception handling.
11046         * tracefile-tfile.c: Use C++ exception handling.
11047         * top.c: Use C++ exception handling.
11048         * thread.c: Use C++ exception handling.
11049         * target.c: Use C++ exception handling.
11050         * symmisc.c: Use C++ exception handling.
11051         * symfile-mem.c: Use C++ exception handling.
11052         * stack.c: Use C++ exception handling.
11053         * sparc64-linux-tdep.c: Use C++ exception handling.
11054         * solib.c: Use C++ exception handling.
11055         * solib-svr4.c: Use C++ exception handling.
11056         * solib-spu.c: Use C++ exception handling.
11057         * solib-frv.c: Use C++ exception handling.
11058         * solib-dsbt.c: Use C++ exception handling.
11059         * selftest-arch.c: Use C++ exception handling.
11060         * s390-tdep.c: Use C++ exception handling.
11061         * rust-lang.c: Use C++ exception handling.
11062         * rust-exp.y: Use C++ exception handling.
11063         * rs6000-tdep.c: Use C++ exception handling.
11064         * rs6000-aix-tdep.c: Use C++ exception handling.
11065         * riscv-tdep.c: Use C++ exception handling.
11066         * remote.c: Use C++ exception handling.
11067         * remote-fileio.c: Use C++ exception handling.
11068         * record-full.c: Use C++ exception handling.
11069         * record-btrace.c: Use C++ exception handling.
11070         * python/python.c: Use C++ exception handling.
11071         * python/py-value.c: Use C++ exception handling.
11072         * python/py-utils.c: Use C++ exception handling.
11073         * python/py-unwind.c: Use C++ exception handling.
11074         * python/py-type.c: Use C++ exception handling.
11075         * python/py-symbol.c: Use C++ exception handling.
11076         * python/py-record.c: Use C++ exception handling.
11077         * python/py-record-btrace.c: Use C++ exception handling.
11078         * python/py-progspace.c: Use C++ exception handling.
11079         * python/py-prettyprint.c: Use C++ exception handling.
11080         * python/py-param.c: Use C++ exception handling.
11081         * python/py-objfile.c: Use C++ exception handling.
11082         * python/py-linetable.c: Use C++ exception handling.
11083         * python/py-lazy-string.c: Use C++ exception handling.
11084         * python/py-infthread.c: Use C++ exception handling.
11085         * python/py-inferior.c: Use C++ exception handling.
11086         * python/py-gdb-readline.c: Use C++ exception handling.
11087         * python/py-framefilter.c: Use C++ exception handling.
11088         * python/py-frame.c: Use C++ exception handling.
11089         * python/py-finishbreakpoint.c: Use C++ exception handling.
11090         * python/py-cmd.c: Use C++ exception handling.
11091         * python/py-breakpoint.c: Use C++ exception handling.
11092         * python/py-arch.c: Use C++ exception handling.
11093         * printcmd.c: Use C++ exception handling.
11094         * ppc-linux-tdep.c: Use C++ exception handling.
11095         * parse.c: Use C++ exception handling.
11096         * p-valprint.c: Use C++ exception handling.
11097         * objc-lang.c: Use C++ exception handling.
11098         * mi/mi-main.c: Use C++ exception handling.
11099         * mi/mi-interp.c: Use C++ exception handling.
11100         * mi/mi-cmd-stack.c: Use C++ exception handling.
11101         * mi/mi-cmd-break.c: Use C++ exception handling.
11102         * main.c: Use C++ exception handling.
11103         * linux-thread-db.c: Use C++ exception handling.
11104         * linux-tdep.c: Use C++ exception handling.
11105         * linux-nat.c: Use C++ exception handling.
11106         * linux-fork.c: Use C++ exception handling.
11107         * linespec.c: Use C++ exception handling.
11108         * language.c: Use C++ exception handling.
11109         * jit.c: Use C++ exception handling.
11110         * infrun.c: Use C++ exception handling.
11111         * infcmd.c: Use C++ exception handling.
11112         * infcall.c: Use C++ exception handling.
11113         * inf-loop.c: Use C++ exception handling.
11114         * i386-tdep.c: Use C++ exception handling.
11115         * i386-linux-tdep.c: Use C++ exception handling.
11116         * guile/scm-value.c: Use C++ exception handling.
11117         * guile/scm-type.c: Use C++ exception handling.
11118         * guile/scm-symtab.c: Use C++ exception handling.
11119         * guile/scm-symbol.c: Use C++ exception handling.
11120         * guile/scm-pretty-print.c: Use C++ exception handling.
11121         * guile/scm-ports.c: Use C++ exception handling.
11122         * guile/scm-param.c: Use C++ exception handling.
11123         * guile/scm-math.c: Use C++ exception handling.
11124         * guile/scm-lazy-string.c: Use C++ exception handling.
11125         * guile/scm-frame.c: Use C++ exception handling.
11126         * guile/scm-disasm.c: Use C++ exception handling.
11127         * guile/scm-cmd.c: Use C++ exception handling.
11128         * guile/scm-breakpoint.c: Use C++ exception handling.
11129         * guile/scm-block.c: Use C++ exception handling.
11130         * guile/guile-internal.h: Use C++ exception handling.
11131         * gnu-v3-abi.c: Use C++ exception handling.
11132         * gdbtypes.c: Use C++ exception handling.
11133         * frame.c: Use C++ exception handling.
11134         * frame-unwind.c: Use C++ exception handling.
11135         * fbsd-tdep.c: Use C++ exception handling.
11136         * f-valprint.c: Use C++ exception handling.
11137         * exec.c: Use C++ exception handling.
11138         * event-top.c: Use C++ exception handling.
11139         * event-loop.c: Use C++ exception handling.
11140         * eval.c: Use C++ exception handling.
11141         * dwarf2read.c: Use C++ exception handling.
11142         * dwarf2loc.c: Use C++ exception handling.
11143         * dwarf2-frame.c: Use C++ exception handling.
11144         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11145         * dwarf-index-write.c: Use C++ exception handling.
11146         * dwarf-index-cache.c: Use C++ exception handling.
11147         * dtrace-probe.c: Use C++ exception handling.
11148         * disasm-selftests.c: Use C++ exception handling.
11149         * darwin-nat.c: Use C++ exception handling.
11150         * cp-valprint.c: Use C++ exception handling.
11151         * cp-support.c: Use C++ exception handling.
11152         * cp-abi.c: Use C++ exception handling.
11153         * corelow.c: Use C++ exception handling.
11154         * completer.c: Use C++ exception handling.
11155         * compile/compile-object-run.c: Use C++ exception handling.
11156         * compile/compile-object-load.c: Use C++ exception handling.
11157         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11158         * compile/compile-c-symbols.c: Use C++ exception handling.
11159         * common/selftest.c: Use C++ exception handling.
11160         * common/new-op.c: Use C++ exception handling.
11161         * cli/cli-script.c: Use C++ exception handling.
11162         * cli/cli-interp.c: Use C++ exception handling.
11163         * cli/cli-cmds.c: Use C++ exception handling.
11164         * c-varobj.c: Use C++ exception handling.
11165         * btrace.c: Use C++ exception handling.
11166         * breakpoint.c: Use C++ exception handling.
11167         * break-catch-throw.c: Use C++ exception handling.
11168         * arch-utils.c: Use C++ exception handling.
11169         * amd64-tdep.c: Use C++ exception handling.
11170         * ada-valprint.c: Use C++ exception handling.
11171         * ada-typeprint.c: Use C++ exception handling.
11172         * ada-lang.c: Use C++ exception handling.
11173         * aarch64-tdep.c: Use C++ exception handling.
11174
11175 2019-04-08  Tom Tromey  <tom@tromey.com>
11176
11177         * xml-support.c (gdb_xml_parser::parse): Update.
11178         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11179         * value.c (show_convenience): Update.
11180         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11181         (test_parse_flags_qcs): Update.
11182         * thread.c (thr_try_catch_cmd): Update.
11183         * target.c (target_translate_tls_address): Update.
11184         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11185         (info_frame_command_core, frame_apply_command_count): Update.
11186         * rust-exp.y (rust_lex_exception_test): Update.
11187         * riscv-tdep.c (riscv_print_one_register_info): Update.
11188         * remote.c (remote_target::enable_btrace): Update.
11189         * record-btrace.c (record_btrace_enable_warn): Update.
11190         * python/py-utils.c (gdbpy_convert_exception): Update.
11191         * printcmd.c (do_one_display, print_variable_and_value): Update.
11192         * mi/mi-main.c (mi_print_exception): Update.
11193         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11194         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11195         * linux-nat.c (linux_nat_target::attach): Update.
11196         * linux-fork.c (class scoped_switch_fork_info): Update.
11197         * infrun.c (displaced_step_prepare): Update.
11198         * infcall.c (call_function_by_hand_dummy): Update.
11199         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11200         * gnu-v3-abi.c (print_one_vtable): Update.
11201         * frame.c (get_prev_frame_always): Update.
11202         * f-valprint.c (info_common_command_for_block): Update.
11203         * exec.c (try_open_exec_file): Update.
11204         * exceptions.c (print_exception, exception_print)
11205         (exception_fprintf, exception_print_same): Update.
11206         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11207         * dwarf-index-cache.c (index_cache::store)
11208         (index_cache::lookup_gdb_index): Update.
11209         * darwin-nat.c (maybe_cache_shell): Update.
11210         * cp-valprint.c (cp_print_value_fields): Update.
11211         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11212         (gcc_cplus_symbol_address): Update.
11213         * compile/compile-c-symbols.c (gcc_convert_symbol)
11214         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11215         * common/selftest.c: Update.
11216         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11217         a std::string.
11218         (exception_try_scope_entry, exception_try_scope_exit): Don't
11219         declare.
11220         (struct exception_try_scope): Remove.
11221         (TRY): Don't use exception_try_scope.
11222         (struct gdb_exception): Add constructor, operator=.
11223         <what>: New method.
11224         (struct gdb_exception_RETURN_MASK_ALL)
11225         (struct gdb_exception_RETURN_MASK_ERROR)
11226         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11227         (struct gdb_quit_bad_alloc): Update.
11228         * common/common-exceptions.c (exception_none): Change
11229         initializer.
11230         (struct catcher) <state, exception>: Initialize inline.
11231         <prev>: Remove member.
11232         (current_catcher): Remove.
11233         (catchers): New global.
11234         (exceptions_state_mc_init): Simplify.
11235         (catcher_pop): Remove.
11236         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11237         (try_scope_depth, exception_try_scope_entry)
11238         (exception_try_scope_exit): Remove.
11239         (throw_exception_sjlj): Update.
11240         (exception_messages, exception_messages_size): Remove.
11241         (throw_it): Simplify.
11242         (gdb_exception_sliced_copy): Remove.
11243         (throw_exception_cxx): Update.
11244         * cli/cli-script.c (script_from_file): Update.
11245         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11246         Update.
11247         * ada-valprint.c (ada_val_print): Update.
11248         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11249         (create_excep_cond_exprs): Update.
11250
11251 2019-04-08  Tom Tromey  <tom@tromey.com>
11252
11253         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11254         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11255         (TRY, CATCH, END_CATCH): Remove some definitions.
11256         * common/common-exceptions.c: Don't use GDB_XCPT.
11257         (catcher_list_size): Remove.
11258         (throw_exception, throw_it): Simplify.
11259
11260 2019-04-05  Tom Tromey  <tom@tromey.com>
11261
11262         Revert the header-sorting patch.
11263         * ft32-tdep.c: Revert.
11264         * frv-tdep.c: Revert.
11265         * frv-linux-tdep.c: Revert.
11266         * frame.c: Revert.
11267         * frame-unwind.c: Revert.
11268         * frame-base.c: Revert.
11269         * fork-child.c: Revert.
11270         * findvar.c: Revert.
11271         * findcmd.c: Revert.
11272         * filesystem.c: Revert.
11273         * filename-seen-cache.h: Revert.
11274         * filename-seen-cache.c: Revert.
11275         * fbsd-tdep.c: Revert.
11276         * fbsd-nat.h: Revert.
11277         * fbsd-nat.c: Revert.
11278         * f-valprint.c: Revert.
11279         * f-typeprint.c: Revert.
11280         * f-lang.c: Revert.
11281         * extension.h: Revert.
11282         * extension.c: Revert.
11283         * extension-priv.h: Revert.
11284         * expprint.c: Revert.
11285         * exec.h: Revert.
11286         * exec.c: Revert.
11287         * exceptions.c: Revert.
11288         * event-top.c: Revert.
11289         * event-loop.c: Revert.
11290         * eval.c: Revert.
11291         * elfread.c: Revert.
11292         * dwarf2read.h: Revert.
11293         * dwarf2read.c: Revert.
11294         * dwarf2loc.c: Revert.
11295         * dwarf2expr.h: Revert.
11296         * dwarf2expr.c: Revert.
11297         * dwarf2-frame.c: Revert.
11298         * dwarf2-frame-tailcall.c: Revert.
11299         * dwarf-index-write.h: Revert.
11300         * dwarf-index-write.c: Revert.
11301         * dwarf-index-common.c: Revert.
11302         * dwarf-index-cache.h: Revert.
11303         * dwarf-index-cache.c: Revert.
11304         * dummy-frame.c: Revert.
11305         * dtrace-probe.c: Revert.
11306         * disasm.h: Revert.
11307         * disasm.c: Revert.
11308         * disasm-selftests.c: Revert.
11309         * dictionary.c: Revert.
11310         * dicos-tdep.c: Revert.
11311         * demangle.c: Revert.
11312         * dcache.h: Revert.
11313         * dcache.c: Revert.
11314         * darwin-nat.h: Revert.
11315         * darwin-nat.c: Revert.
11316         * darwin-nat-info.c: Revert.
11317         * d-valprint.c: Revert.
11318         * d-namespace.c: Revert.
11319         * d-lang.c: Revert.
11320         * ctf.c: Revert.
11321         * csky-tdep.c: Revert.
11322         * csky-linux-tdep.c: Revert.
11323         * cris-tdep.c: Revert.
11324         * cris-linux-tdep.c: Revert.
11325         * cp-valprint.c: Revert.
11326         * cp-support.c: Revert.
11327         * cp-namespace.c: Revert.
11328         * cp-abi.c: Revert.
11329         * corelow.c: Revert.
11330         * corefile.c: Revert.
11331         * continuations.c: Revert.
11332         * completer.h: Revert.
11333         * completer.c: Revert.
11334         * complaints.c: Revert.
11335         * coffread.c: Revert.
11336         * coff-pe-read.c: Revert.
11337         * cli-out.h: Revert.
11338         * cli-out.c: Revert.
11339         * charset.c: Revert.
11340         * c-varobj.c: Revert.
11341         * c-valprint.c: Revert.
11342         * c-typeprint.c: Revert.
11343         * c-lang.c: Revert.
11344         * buildsym.c: Revert.
11345         * buildsym-legacy.c: Revert.
11346         * build-id.h: Revert.
11347         * build-id.c: Revert.
11348         * btrace.c: Revert.
11349         * bsd-uthread.c: Revert.
11350         * breakpoint.h: Revert.
11351         * breakpoint.c: Revert.
11352         * break-catch-throw.c: Revert.
11353         * break-catch-syscall.c: Revert.
11354         * break-catch-sig.c: Revert.
11355         * blockframe.c: Revert.
11356         * block.c: Revert.
11357         * bfin-tdep.c: Revert.
11358         * bfin-linux-tdep.c: Revert.
11359         * bfd-target.c: Revert.
11360         * bcache.c: Revert.
11361         * ax-general.c: Revert.
11362         * ax-gdb.h: Revert.
11363         * ax-gdb.c: Revert.
11364         * avr-tdep.c: Revert.
11365         * auxv.c: Revert.
11366         * auto-load.c: Revert.
11367         * arm-wince-tdep.c: Revert.
11368         * arm-tdep.c: Revert.
11369         * arm-symbian-tdep.c: Revert.
11370         * arm-pikeos-tdep.c: Revert.
11371         * arm-obsd-tdep.c: Revert.
11372         * arm-nbsd-tdep.c: Revert.
11373         * arm-nbsd-nat.c: Revert.
11374         * arm-linux-tdep.c: Revert.
11375         * arm-linux-nat.c: Revert.
11376         * arm-fbsd-tdep.c: Revert.
11377         * arm-fbsd-nat.c: Revert.
11378         * arm-bsd-tdep.c: Revert.
11379         * arch-utils.c: Revert.
11380         * arc-tdep.c: Revert.
11381         * arc-newlib-tdep.c: Revert.
11382         * annotate.h: Revert.
11383         * annotate.c: Revert.
11384         * amd64-windows-tdep.c: Revert.
11385         * amd64-windows-nat.c: Revert.
11386         * amd64-tdep.c: Revert.
11387         * amd64-sol2-tdep.c: Revert.
11388         * amd64-obsd-tdep.c: Revert.
11389         * amd64-obsd-nat.c: Revert.
11390         * amd64-nbsd-tdep.c: Revert.
11391         * amd64-nbsd-nat.c: Revert.
11392         * amd64-nat.c: Revert.
11393         * amd64-linux-tdep.c: Revert.
11394         * amd64-linux-nat.c: Revert.
11395         * amd64-fbsd-tdep.c: Revert.
11396         * amd64-fbsd-nat.c: Revert.
11397         * amd64-dicos-tdep.c: Revert.
11398         * amd64-darwin-tdep.c: Revert.
11399         * amd64-bsd-nat.c: Revert.
11400         * alpha-tdep.c: Revert.
11401         * alpha-obsd-tdep.c: Revert.
11402         * alpha-nbsd-tdep.c: Revert.
11403         * alpha-mdebug-tdep.c: Revert.
11404         * alpha-linux-tdep.c: Revert.
11405         * alpha-linux-nat.c: Revert.
11406         * alpha-bsd-tdep.c: Revert.
11407         * alpha-bsd-nat.c: Revert.
11408         * aix-thread.c: Revert.
11409         * agent.c: Revert.
11410         * addrmap.c: Revert.
11411         * ada-varobj.c: Revert.
11412         * ada-valprint.c: Revert.
11413         * ada-typeprint.c: Revert.
11414         * ada-tasks.c: Revert.
11415         * ada-lang.c: Revert.
11416         * aarch64-tdep.c: Revert.
11417         * aarch64-ravenscar-thread.c: Revert.
11418         * aarch64-newlib-tdep.c: Revert.
11419         * aarch64-linux-tdep.c: Revert.
11420         * aarch64-linux-nat.c: Revert.
11421         * aarch64-fbsd-tdep.c: Revert.
11422         * aarch64-fbsd-nat.c: Revert.
11423         * aarch32-linux-nat.c: Revert.
11424
11425 2019-04-05  Tom Tromey  <tom@tromey.com>
11426
11427         * ft32-tdep.c: Sort headers.
11428         * frv-tdep.c: Sort headers.
11429         * frv-linux-tdep.c: Sort headers.
11430         * frame.c: Sort headers.
11431         * frame-unwind.c: Sort headers.
11432         * frame-base.c: Sort headers.
11433         * fork-child.c: Sort headers.
11434         * findvar.c: Sort headers.
11435         * findcmd.c: Sort headers.
11436         * filesystem.c: Sort headers.
11437         * filename-seen-cache.h: Sort headers.
11438         * filename-seen-cache.c: Sort headers.
11439         * fbsd-tdep.c: Sort headers.
11440         * fbsd-nat.h: Sort headers.
11441         * fbsd-nat.c: Sort headers.
11442         * f-valprint.c: Sort headers.
11443         * f-typeprint.c: Sort headers.
11444         * f-lang.c: Sort headers.
11445         * extension.h: Sort headers.
11446         * extension.c: Sort headers.
11447         * extension-priv.h: Sort headers.
11448         * expprint.c: Sort headers.
11449         * exec.h: Sort headers.
11450         * exec.c: Sort headers.
11451         * exceptions.c: Sort headers.
11452         * event-top.c: Sort headers.
11453         * event-loop.c: Sort headers.
11454         * eval.c: Sort headers.
11455         * elfread.c: Sort headers.
11456         * dwarf2read.h: Sort headers.
11457         * dwarf2read.c: Sort headers.
11458         * dwarf2loc.c: Sort headers.
11459         * dwarf2expr.h: Sort headers.
11460         * dwarf2expr.c: Sort headers.
11461         * dwarf2-frame.c: Sort headers.
11462         * dwarf2-frame-tailcall.c: Sort headers.
11463         * dwarf-index-write.h: Sort headers.
11464         * dwarf-index-write.c: Sort headers.
11465         * dwarf-index-common.c: Sort headers.
11466         * dwarf-index-cache.h: Sort headers.
11467         * dwarf-index-cache.c: Sort headers.
11468         * dummy-frame.c: Sort headers.
11469         * dtrace-probe.c: Sort headers.
11470         * disasm.h: Sort headers.
11471         * disasm.c: Sort headers.
11472         * disasm-selftests.c: Sort headers.
11473         * dictionary.c: Sort headers.
11474         * dicos-tdep.c: Sort headers.
11475         * demangle.c: Sort headers.
11476         * dcache.h: Sort headers.
11477         * dcache.c: Sort headers.
11478         * darwin-nat.h: Sort headers.
11479         * darwin-nat.c: Sort headers.
11480         * darwin-nat-info.c: Sort headers.
11481         * d-valprint.c: Sort headers.
11482         * d-namespace.c: Sort headers.
11483         * d-lang.c: Sort headers.
11484         * ctf.c: Sort headers.
11485         * csky-tdep.c: Sort headers.
11486         * csky-linux-tdep.c: Sort headers.
11487         * cris-tdep.c: Sort headers.
11488         * cris-linux-tdep.c: Sort headers.
11489         * cp-valprint.c: Sort headers.
11490         * cp-support.c: Sort headers.
11491         * cp-namespace.c: Sort headers.
11492         * cp-abi.c: Sort headers.
11493         * corelow.c: Sort headers.
11494         * corefile.c: Sort headers.
11495         * continuations.c: Sort headers.
11496         * completer.h: Sort headers.
11497         * completer.c: Sort headers.
11498         * complaints.c: Sort headers.
11499         * coffread.c: Sort headers.
11500         * coff-pe-read.c: Sort headers.
11501         * cli-out.h: Sort headers.
11502         * cli-out.c: Sort headers.
11503         * charset.c: Sort headers.
11504         * c-varobj.c: Sort headers.
11505         * c-valprint.c: Sort headers.
11506         * c-typeprint.c: Sort headers.
11507         * c-lang.c: Sort headers.
11508         * buildsym.c: Sort headers.
11509         * buildsym-legacy.c: Sort headers.
11510         * build-id.h: Sort headers.
11511         * build-id.c: Sort headers.
11512         * btrace.c: Sort headers.
11513         * bsd-uthread.c: Sort headers.
11514         * breakpoint.h: Sort headers.
11515         * breakpoint.c: Sort headers.
11516         * break-catch-throw.c: Sort headers.
11517         * break-catch-syscall.c: Sort headers.
11518         * break-catch-sig.c: Sort headers.
11519         * blockframe.c: Sort headers.
11520         * block.c: Sort headers.
11521         * bfin-tdep.c: Sort headers.
11522         * bfin-linux-tdep.c: Sort headers.
11523         * bfd-target.c: Sort headers.
11524         * bcache.c: Sort headers.
11525         * ax-general.c: Sort headers.
11526         * ax-gdb.h: Sort headers.
11527         * ax-gdb.c: Sort headers.
11528         * avr-tdep.c: Sort headers.
11529         * auxv.c: Sort headers.
11530         * auto-load.c: Sort headers.
11531         * arm-wince-tdep.c: Sort headers.
11532         * arm-tdep.c: Sort headers.
11533         * arm-symbian-tdep.c: Sort headers.
11534         * arm-pikeos-tdep.c: Sort headers.
11535         * arm-obsd-tdep.c: Sort headers.
11536         * arm-nbsd-tdep.c: Sort headers.
11537         * arm-nbsd-nat.c: Sort headers.
11538         * arm-linux-tdep.c: Sort headers.
11539         * arm-linux-nat.c: Sort headers.
11540         * arm-fbsd-tdep.c: Sort headers.
11541         * arm-fbsd-nat.c: Sort headers.
11542         * arm-bsd-tdep.c: Sort headers.
11543         * arch-utils.c: Sort headers.
11544         * arc-tdep.c: Sort headers.
11545         * arc-newlib-tdep.c: Sort headers.
11546         * annotate.h: Sort headers.
11547         * annotate.c: Sort headers.
11548         * amd64-windows-tdep.c: Sort headers.
11549         * amd64-windows-nat.c: Sort headers.
11550         * amd64-tdep.c: Sort headers.
11551         * amd64-sol2-tdep.c: Sort headers.
11552         * amd64-obsd-tdep.c: Sort headers.
11553         * amd64-obsd-nat.c: Sort headers.
11554         * amd64-nbsd-tdep.c: Sort headers.
11555         * amd64-nbsd-nat.c: Sort headers.
11556         * amd64-nat.c: Sort headers.
11557         * amd64-linux-tdep.c: Sort headers.
11558         * amd64-linux-nat.c: Sort headers.
11559         * amd64-fbsd-tdep.c: Sort headers.
11560         * amd64-fbsd-nat.c: Sort headers.
11561         * amd64-dicos-tdep.c: Sort headers.
11562         * amd64-darwin-tdep.c: Sort headers.
11563         * amd64-bsd-nat.c: Sort headers.
11564         * alpha-tdep.c: Sort headers.
11565         * alpha-obsd-tdep.c: Sort headers.
11566         * alpha-nbsd-tdep.c: Sort headers.
11567         * alpha-mdebug-tdep.c: Sort headers.
11568         * alpha-linux-tdep.c: Sort headers.
11569         * alpha-linux-nat.c: Sort headers.
11570         * alpha-bsd-tdep.c: Sort headers.
11571         * alpha-bsd-nat.c: Sort headers.
11572         * aix-thread.c: Sort headers.
11573         * agent.c: Sort headers.
11574         * addrmap.c: Sort headers.
11575         * ada-varobj.c: Sort headers.
11576         * ada-valprint.c: Sort headers.
11577         * ada-typeprint.c: Sort headers.
11578         * ada-tasks.c: Sort headers.
11579         * ada-lang.c: Sort headers.
11580         * aarch64-tdep.c: Sort headers.
11581         * aarch64-ravenscar-thread.c: Sort headers.
11582         * aarch64-newlib-tdep.c: Sort headers.
11583         * aarch64-linux-tdep.c: Sort headers.
11584         * aarch64-linux-nat.c: Sort headers.
11585         * aarch64-fbsd-tdep.c: Sort headers.
11586         * aarch64-fbsd-nat.c: Sort headers.
11587         * aarch32-linux-nat.c: Sort headers.
11588
11589 2019-04-04  Tom Tromey  <tom@tromey.com>
11590
11591         * varobj.c (varobj_create): Update.
11592         * rust-exp.y (struct rust_parser) <update_innermost_block,
11593         lookup_symbol>: New methods.
11594         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11595         Rename.
11596         (rust_parser::rust_lookup_type)
11597         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11598         * printcmd.c (display_command, do_one_display): Update.
11599         * parser-defs.h (struct parser_state) <parser_state>: Add
11600         "tracker" parameter.
11601         (block_tracker): New member.
11602         (class innermost_block_tracker) <innermost_block_tracker>: Add
11603         "types" parameter.
11604         <reset>: Remove method.
11605         (innermost_block): Don't declare.
11606         (null_post_parser): Update.
11607         * parse.c (innermost_block): Remove global.
11608         (write_dollar_variable): Update.
11609         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11610         Remove "tracker_types" parameter.
11611         (parse_expression): Add "tracker" parameter.
11612         (parse_expression_for_completion): Update.
11613         (null_post_parser): Add "tracker" parameter.
11614         * p-exp.y: Update rules.
11615         * m2-exp.y: Update rules.
11616         * language.h (struct language_defn) <la_post_parser>: Add
11617         "tracker" parameter.
11618         * go-exp.y: Update rules.
11619         * f-exp.y: Update rules.
11620         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11621         parameter.
11622         * d-exp.y: Update rules.
11623         * c-exp.y: Update rules.
11624         * breakpoint.c (set_breakpoint_condition): Create an
11625         innermost_block_tracker.
11626         (watch_command_1): Likewise.
11627         * ada-lang.c (resolve): Add "tracker" parameter.
11628         (resolve_subexp): Likewise.
11629         * ada-exp.y (write_var_from_sym): Update.
11630
11631 2019-04-04  Tom Tromey  <tom@tromey.com>
11632
11633         * type-stack.h: New file.
11634         * type-stack.c: New file.
11635         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11636         type-stack.h.
11637         (insert_into_type_stack, insert_type, push_type, push_type_int)
11638         (insert_type_address_space, pop_type, pop_type_int)
11639         (pop_typelist, pop_type_stack, append_type_stack)
11640         (push_type_stack, get_type_stack, push_typelist)
11641         (follow_type_instance_flags, follow_types): Don't declare.
11642         * parse.c (type_stack): Remove global.
11643         (parse_exp_in_context): Update.
11644         (insert_into_type_stack, insert_type, push_type, push_type_int)
11645         (insert_type_address_space, pop_type, pop_type_int)
11646         (pop_typelist, pop_type_stack, append_type_stack)
11647         (push_type_stack, get_type_stack, push_typelist)
11648         (follow_type_instance_flags, follow_types): Remove (moved to
11649         type-stack.c).
11650         * f-exp.y (type_stack): New global.
11651         Update rules.
11652         (push_kind_type, f_parse): Update.
11653         * d-exp.y (type_stack): New global.
11654         Update rules.
11655         (d_parse): Update.
11656         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11657         Update rules.
11658         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11659         (HFILES_NO_SRCDIR): Add type-stack.h.
11660
11661 2019-04-04  Tom Tromey  <tom@tromey.com>
11662
11663         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11664         (rust_parser::convert_ast_to_expression, rust_parse)
11665         (rust_lex_test_completion, rust_lex_tests): Update.
11666         * parser-defs.h (struct expr_completion_state): New.
11667         (struct parser_state) <parser_state>: Add completion parameter.
11668         <mark_struct_expression, mark_completion_tag>: New methods.
11669         <parse_completion, m_completion_state>: New members.
11670         (prefixify_expression, null_post_parser): Update.
11671         (mark_struct_expression, mark_completion_tag): Don't declare.
11672         * parse.c (parse_completion, expout_last_struct)
11673         (expout_tag_completion_type, expout_completion_name): Remove
11674         globals.
11675         (parser_state::mark_struct_expression)
11676         (parser_state::mark_completion_tag): Now methods.
11677         (prefixify_expression): Add last_struct parameter.
11678         (prefixify_subexp): Likewise.
11679         (parse_exp_1): Update.
11680         (parse_exp_in_context): Add cstate parameter.  Update.
11681         (parse_expression_for_completion): Create an
11682         expr_completion_state.
11683         (null_post_parser): Add "completion" parameter.
11684         * p-exp.y: Update rules.
11685         (yylex): Update.
11686         * language.h (struct language_defn) <la_post_parser>: Add
11687         "completing" parameter.
11688         * go-exp.y: Update rules.
11689         (lex_one_token): Update.
11690         * expression.h (parse_completion): Don't declare.
11691         * d-exp.y: Update rules.
11692         (lex_one_token): Update rules.
11693         * c-exp.y: Update rules.
11694         (lex_one_token): Update.
11695         * ada-lang.c (resolve): Add "parse_completion" parameter.
11696         (resolve_subexp): Likewise.
11697         (ada_resolve_function): Likewise.
11698
11699 2019-04-04  Tom Tromey  <tom@tromey.com>
11700
11701         * parser-defs.h (struct parser_state) <start_arglist,
11702         end_arglist>: New methods.
11703         <arglist_len, m_funcall_chain>: New members.
11704         (arglist_len, start_arglist, end_arglist): Don't declare.
11705         * parse.c (arglist_len, funcall_chain): Remove global.
11706         (start_arglist, end_arglist): Remove functions.
11707         (parse_exp_in_context): Update.
11708         * p-exp.y: Update rules.
11709         * m2-exp.y: Update rules.
11710         * go-exp.y: Update rules.
11711         * f-exp.y: Update rules.
11712         * d-exp.y: Update rules.
11713         * c-exp.y: Update rules.
11714
11715 2019-04-04  Tom Tromey  <tom@tromey.com>
11716
11717         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11718         lex_operator, push_back>: New methods.
11719         Update all rules.
11720         (rust_parser::lex_hex, lex_escape): Rename and update.
11721         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11722         (rust_parser::lex_operator): Rename and update.
11723         (rust_parser::lex_number, rustyylex, rustyyerror)
11724         (rust_lex_test_init, rust_lex_test_sequence)
11725         (rust_lex_test_push_back, rust_lex_tests): Update.
11726         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11727         parameter.
11728         <lexptr, prev_lexptr>: New members.
11729         (lexptr, prev_lexptr): Don't declare.
11730         * parse.c (lexptr, prev_lexptr): Remove globals.
11731         (parse_exp_in_context): Update.
11732         * p-exp.y (yylex, yyerror): Update.
11733         * m2-exp.y (parse_number, yylex, yyerror): Update.
11734         * go-exp.y (lex_one_token, yyerror): Update.
11735         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11736         * d-exp.y (lex_one_token, yyerror): Update.
11737         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11738         (lex_one_token, yyerror): Update.
11739         * ada-lex.l (YY_INPUT): Update.
11740         (rewind_to_char): Update.
11741         * ada-exp.y (yyerror): Update.
11742
11743 2019-04-04  Tom Tromey  <tom@tromey.com>
11744
11745         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11746         * parser-defs.h (struct parser_state) <parser_state>: Add new
11747         parameter.
11748         <comma_terminates>: New member.
11749         (comma_terminates): Don't declare global.
11750         * parse.c (comma_terminates): Remove global.
11751         (parse_exp_in_context): Update.
11752         * p-exp.y (yylex): Update.
11753         * m2-exp.y (yylex): Update.
11754         * go-exp.y (lex_one_token): Update.
11755         * f-exp.y (yylex): Update.
11756         * d-exp.y (lex_one_token): Update.
11757         * c-exp.y (lex_one_token): Update.
11758         * ada-lex.l: Update.
11759
11760 2019-04-04  Tom Tromey  <tom@tromey.com>
11761
11762         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11763         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11764         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11765         * parser-defs.h (paren_depth): Don't declare.
11766         * parse.c (paren_depth): Remove global.
11767         (parse_exp_in_context): Update.
11768         * p-exp.y (paren_depth): New global.
11769         (pascal_parse): Initialize it.
11770         * m2-exp.y (paren_depth): New global.
11771         (m2_parse): Initialize it.
11772         * go-exp.y (paren_depth): New global.
11773         (go_parse): Initialize it.
11774         * f-exp.y (paren_depth): New global.
11775         (f_parse): Initialize it.
11776         * d-exp.y (paren_depth): New global.
11777         (d_parse): Initialize it.
11778         * c-exp.y (paren_depth): New global.
11779         (c_parse): Initialize it.
11780         * ada-lex.l (paren_depth): New global.
11781         (lexer_init): Initialize it.
11782
11783 2019-04-04  Tom Tromey  <tom@tromey.com>
11784
11785         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11786         (rust_parser::convert_ast_to_type)
11787         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11788         * parser-defs.h (struct parser_state) <parser_state>: Add
11789         parameters.  Initialize new members.
11790         <expression_context_block, expression_context_pc>: New members.
11791         * parse.c (expression_context_block, expression_context_pc):
11792         Remove globals.
11793         (parse_exp_in_context): Update.
11794         * p-exp.y: Update all rules.
11795         (yylex): Update.
11796         * m2-exp.y: Update all rules.
11797         (yylex): Update.
11798         * go-exp.y (yylex): Update.
11799         * f-exp.y (yylex): Update.
11800         * d-exp.y: Update all rules.
11801         (yylex): Update.
11802         * c-exp.y: Update all rules.
11803         (lex_one_token, classify_name, yylex, c_parse): Update.
11804         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11805
11806 2019-04-04  Tom Tromey  <tom@tromey.com>
11807
11808         * gdbarch.h, gdbarch.c: Rebuild.
11809         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11810         * stap-probe.h:
11811         (struct stap_parse_info): Replace "parser_state" with
11812         "expr_builder".
11813         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11814         (parser_state): New class.
11815         * parse.c (expr_builder): Rename.
11816         (expr_builder::release): Rename.
11817         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11818         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11819         (write_exp_elt_longcst, write_exp_elt_floatcst)
11820         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11821         (write_exp_string_vector, write_exp_bitstring)
11822         (write_exp_msymbol, mark_struct_expression)
11823         (write_dollar_variable)
11824         (insert_type_address_space, increase_expout_size): Replace
11825         "parser_state" with "expr_builder".
11826         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11827         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11828         "parser_state" with "expr_builder".
11829
11830 2019-04-04  Tom Tromey  <tom@tromey.com>
11831
11832         * rust-exp.y: Replace "parse_language" with method call.
11833         * p-exp.y:
11834         (yylex): Replace "parse_language" with method call.
11835         * m2-exp.y:
11836         (yylex): Replace "parse_language" with method call.
11837         * go-exp.y (classify_name): Replace "parse_language" with method
11838         call.
11839         * f-exp.y (yylex): Replace "parse_language" with method call.
11840         * d-exp.y (lex_one_token): Replace "parse_language" with method
11841         call.
11842         * c-exp.y:
11843         (lex_one_token, classify_name, yylex): Replace "parse_language"
11844         with method call.
11845         * ada-exp.y (find_primitive_type, type_char)
11846         (type_system_address): Replace "parse_language" with method call.
11847
11848 2019-04-04  Tom Tromey  <tom@tromey.com>
11849
11850         * rust-exp.y: Replace "parse_gdbarch" with method call.
11851         * parse.c (write_dollar_variable, insert_type_address_space):
11852         Replace "parse_gdbarch" with method call.
11853         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11854         call.
11855         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11856         call.
11857         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11858         "parse_gdbarch" with method call.
11859         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11860         with method call.
11861         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11862         "parse_gdbarch" with method call.
11863         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11864         "parse_gdbarch" with method call.
11865         * c-exp.y (parse_type, parse_number, classify_name): Replace
11866         "parse_gdbarch" with method call.
11867         * ada-lex.l: Replace "parse_gdbarch" with method call.
11868         * ada-exp.y (parse_type, find_primitive_type, type_char)
11869         (type_system_address): Replace "parse_gdbarch" with method call.
11870
11871 2019-04-04  Tom Tromey  <tom@tromey.com>
11872
11873         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11874         * stap-probe.c (stap_parse_argument): Update.
11875         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11876         initial_size parameter.
11877         * rust-exp.y (rust_lex_tests): Update.
11878         * parse.c (parser_state): Update.
11879         (parse_exp_in_context): Update.
11880         * parser-defs.h (struct parser_state) <parser_state>: Remove
11881         "initial_size" parameter.
11882
11883 2019-04-04  Tom Tromey  <tom@tromey.com>
11884
11885         * parser-defs.h (increase_expout_size): Don't declare.
11886         * parse.c (increase_expout_size): Now static.
11887
11888 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11889
11890         * gnu-nat.c (gnu_nat_target::wait): Fix
11891         target_waitstatus_to_string call.
11892
11893 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11894
11895         * eval.c (evaluate_subexp_standard): Handle internal functions
11896         during Fortran function call handling.
11897
11898 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * NEWS: Mention new internal functions.
11901         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11902         (read_base_type): Use dwarf2_init_complex_target_type.
11903         * value.c (creal_internal_fn): New function.
11904         (cimag_internal_fn): New function.
11905         (_initialize_values): Register new internal functions.
11906
11907 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11908
11909         * infrun.c (stop_all_threads): If debug_infrun, always
11910         trace the wait status after wait_one, using
11911         target_waitstatus_to_string and target_pid_to_str.
11912         (handle_inferior_event): Replace various trace of
11913         wait status kind by a single trace.
11914         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11915         wait status kind image by target_waitstatus_to_string.
11916         * target/waitstatus.c (target_waitstatus_to_string): Fix
11917         obsolete comment.
11918
11919 2019-04-01  Tom Tromey  <tromey@adacore.com>
11920
11921         PR symtab/23331:
11922         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11923
11924 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11925             Pedro Alves  <palves@redhat.com>
11926
11927         * top.c (quit_force): Call 'finalize_values'.
11928         * value.c (finalize_values): New function.
11929         * value.h (finalize_values): Declare.
11930
11931 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11932
11933         * NEWS: Announce $_gdb_major and $_gdb_minor.
11934
11935         * top.c (init_gdb_version_vars): New function.
11936         (gdb_init): Call init_gdb_version_vars.
11937
11938 2019-03-29  Tom Tromey  <tromey@adacore.com>
11939
11940         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11941         help text.  Remove dead code.
11942
11943 2019-03-29  Keith Seitz  <keiths@redhat.com>
11944
11945         From Siddhesh Poyarekar:
11946         * f-lang.h (f77_get_upperbound): Return LONGEST.
11947         (f77_get_lowerbound): Likewise.
11948         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11949         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11950         print them.
11951         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11952         plongest to format print it.
11953         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11954         (f77_get_upperbound): Likewise.
11955         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11956         LOWER_BOUND to LONGEST.
11957         (f77_create_arrayprint_offset_tbl): Likewise.
11958
11959 2019-03-29  Keith Seitz  <keiths@redhat.com>
11960
11961         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11962         %s/pulongest for TYPE_LENGTH instead of %d in format
11963         strings.
11964         * ada-typerint.c (ada_print_type): Likewise.
11965         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11966         * compile/compile-c-support.c (generate_register_struct): Likewise.
11967         * gdbtypes.c (recursive_dump_type): Likewise.
11968         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11969         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11970         instead of %d in format strings.
11971         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11972         to std::min to ULONGEST.
11973         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11974         instead of %d in format strings.
11975         * tracepoint.c (info_scope_command): Likewise.
11976         * typeprint.c (print_offset_data::update)
11977         (print_offset_data::finish): Likewise.
11978         * xtensa-tdep.c (xtensa_store_return_value)
11979         (xtensa_push_dummy_call): Likewise.
11980
11981 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11982
11983         * windows-nat.c (display_selector): Fixed format specifications
11984         for 64-bit Cygwin.
11985
11986 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11987
11988         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11989
11990 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11991
11992         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11993         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11994         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11995         (nios2_linux_init_abi): Install it.
11996
11997 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11998
11999         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12000
12001 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12002
12003         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12004
12005 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12006             Tom Tromey  <tromey@adacore.com>
12007
12008         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12009
12010 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12011
12012         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12013         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12014         method to compute the bounds of range types. Also print "[evaluated]"
12015         if the bounds' values come from a dynamic evaluation.
12016
12017 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12018
12019         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12020         whitespace when pretty printing is on.
12021
12022 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12023
12024         * ppc-linux-nat.c: Add include.
12025
12026 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12027
12028         * NEWS: Mention AArch64 Pointer Authentication.
12029
12030 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12031
12032         * arm-linux-nat.c: Add include.
12033
12034 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12035
12036         * source-cache.c (source_cache::get_source_lines): Re-read
12037         fullname after calling open_source_file.
12038
12039 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12040
12041         * NEWS: Mention TLS support for FreeBSD.
12042
12043 2019-03-25  Tom Tromey  <tromey@adacore.com>
12044
12045         * minsyms.c (BUNCH_SIZE): Update comment.
12046         (~minimal_symbol_reader): Remove old comment.
12047         (compact_minimal_symbols): Update comment.
12048         (minimal_symbol_reader::install): Remove old comment.  Update
12049         other comments.
12050
12051 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12052
12053         * s390-linux-nat.c: Add include.
12054
12055 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12056
12057         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12058         Call linux_get_hwcap.
12059         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12060         Likewise.
12061         (aarch64_linux_get_hwcap): Remove function.
12062         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12063         declaration.
12064         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12065         linux_get_hwcap.
12066         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12067         * linux-tdep.c (linux_get_hwcap): Add function.
12068         (linux_get_hwcap2): Likewise.
12069         * linux-tdep.h (linux_get_hwcap): Add declaration.
12070         (linux_get_hwcap2): Likewise.
12071         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12072         (ppc_linux_get_hwcap2): Likewise.
12073         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12074         linux_get_hwcap.
12075         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12076         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12077         (ppc_linux_nat_target::read_description): Likewise.
12078         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12079         * s390-linux-nat.c: Likewise.
12080         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12081
12082 2019-03-24  Tom Tromey  <tom@tromey.com>
12083
12084         * ada-lang.c (standard_lookup): Simplify initialization.
12085         (ada_lookup_symbol_nonlocal): Simplify return.
12086         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12087         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12088         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12089         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12090         initialization.
12091         * solib.c (solib_global_lookup): Simplify.
12092         * symtab.c (null_block_symbol): Remove.
12093         (symbol_cache_lookup): Simplify returns.
12094         (lookup_language_this): Simplify returns.
12095         (lookup_symbol_aux): Simplify return.
12096         (lookup_local_symbol): Simplify returns.
12097         (lookup_global_symbol_from_objfile): Simplify return.
12098         (lookup_symbol_in_objfile_symtabs)
12099         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12100         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12101         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12102         * cp-namespace.c (cp_lookup_bare_symbol)
12103         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12104         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12105         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12106         (cp_lookup_symbol_via_imports): Simplify initialization.
12107         (find_symbol_in_baseclass): Likewise.
12108         * symtab.h (null_block_symbol): Remove.
12109         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12110         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12111         (d_lookup_symbol_module): Likewise.
12112         (find_symbol_in_baseclass): Simplify initialization.
12113
12114 2019-03-24  Tom Tromey  <tom@tromey.com>
12115
12116         * expression.h: Don't include symtab.h.
12117         (struct block): Forward declare.
12118
12119 2019-03-24  Tom Tromey  <tom@tromey.com>
12120
12121         * c-exp.y (typebase): Remove casts.
12122         * gdbtypes.c (lookup_unsigned_typename, )
12123         (lookup_signed_typename): Remove cast.
12124         * eval.c (parse_to_comma_and_eval): Remove cast.
12125         * parse.c (write_dollar_variable): Remove cast.
12126         * block.h (struct block) <superblock>: Now const.
12127         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12128         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12129         (map_block): Make "block" const.
12130         * symfile.h (struct quick_symbol_functions)
12131         <map_matching_symbols>: Constify block argument to "callback".
12132         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12133         const.
12134         (find_pc_sect_compunit_symtab): Make "b" const.
12135         (find_symbol_at_address): Likewise.
12136         (search_symbols): Likewise.
12137         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12138         (dw2_debug_names_lookup_symbol): Likewise.
12139         (dw2_map_matching_symbols): Update.
12140         * p-valprint.c (pascal_val_print): Remove "block".
12141         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12142         (aux_add_nonlocal_symbols): Make "block" const.
12143         (resolve_subexp): Remove cast.
12144         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12145         const.
12146         (iterate_over_file_blocks): Likewise.
12147         * f-exp.y (%union) <bval>: Remove.
12148         * coffread.c (patch_opaque_types): Make "b" const.
12149         * spu-tdep.c (spu_catch_start): Make "block" const.
12150         * c-valprint.c (print_unpacked_pointer): Remove "block".
12151         * symmisc.c (dump_symtab_1): Make "b" const.
12152         (block_depth): Make "block" const.
12153         * d-exp.y (%union) <bval>: Remove.
12154         * cp-support.h (cp_lookup_rtti_type): Update.
12155         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12156         * psymtab.c (psym_lookup_symbol): Make "block" const.
12157         (maintenance_check_psymtabs): Make "b" const.
12158         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12159         (enumerate_locals, enumerate_args): Update.
12160         * python/py-symtab.c (stpy_global_block): Make "block" const.
12161         (stpy_static_block): Likewise.
12162         * inline-frame.c (block_starting_point_at): Make "new_block"
12163         const.
12164         * block.c (find_block_in_blockvector): Make return type const.
12165         (blockvector_for_pc_sect): Make "b" const.
12166         (find_block_in_blockvector): Make "b" const.
12167
12168 2019-03-23  Tom Tromey  <tom@tromey.com>
12169
12170         * varobj.c (varobj_create): Update.
12171         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12172         * printcmd.c (display_command, do_one_display): Don't reset
12173         innermost_block.
12174         * parser-defs.h (enum innermost_block_tracker_type): Move to
12175         expression.h.
12176         (innermost_block): Update comment.
12177         * parse.c (parse_exp_1): Add tracker_types parameter.
12178         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12179         tracker_types parameter.  Reset innermost_block.
12180         (parse_exp_in_context): Remove.
12181         (parse_expression_for_completion): Update.
12182         * objfiles.c (~objfile): Don't reset expression_context_block or
12183         innermost_block.
12184         * expression.h (enum innermost_block_tracker_type): Move from
12185         parser-defs.h.
12186         (parse_exp_1): Add tracker_types parameter.
12187         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12188         reset innermost_block.
12189
12190 2019-03-23  Tom Tromey  <tom@tromey.com>
12191
12192         * objfiles.h: Include bcache.h.
12193
12194 2019-03-23  Tom Tromey  <tom@tromey.com>
12195
12196         * linespec.c (get_current_search_block): Use
12197         scoped_restore_current_language.
12198         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12199
12200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12201             Jiong Wang  <jiong.wang@arm.com>
12202
12203         * aarch64-linux-tdep.c
12204         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12205         section.
12206         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12207
12208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12209             Jiong Wang  <jiong.wang@arm.com>
12210
12211         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12212         instructions.
12213         (aarch64_analyze_prologue_test): Add PACIASP test.
12214         (aarch64_prologue_prev_register): Unmask PC value.
12215
12216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12217             Jiong Wang  <jiong.wang@arm.com>
12218
12219         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12220         (aarch64_dwarf2_prev_register): Unmask PC value.
12221         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12222         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12223         DW_CFA_AARCH64_negate_ra_state.
12224         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12225
12226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12227             Jiong Wang  <jiong.wang@arm.com>
12228
12229         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12230         registers.
12231         (aarch64_pseudo_register_name): Likewise.
12232         (aarch64_pseudo_register_type): Likewise.
12233         (aarch64_pseudo_register_reggroup_p): Likewise.
12234         (aarch64_gdbarch_init): Add pauth registers.
12235         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12236         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12237         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12238         (struct gdbarch_tdep): Add regnum for ra_state.
12239
12240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12241             Jiong Wang  <jiong.wang@arm.com>
12242
12243         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12244
12245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12246             Jiong Wang  <jiong.wang@arm.com>
12247
12248         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12249         function.
12250         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12251         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12252         (aarch64_gdbarch_init): Add puth registers.
12253         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12254         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12255         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12256
12257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12258             Jiong Wang  <jiong.wang@arm.com>
12259
12260         * aarch64-linux-nat.c
12261         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12262         * aarch64-linux-tdep.c
12263         (aarch64_linux_core_read_description): Likewise.
12264         (aarch64_linux_get_hwcap): New function.
12265         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12266         (aarch64_linux_get_hwcap): New declaration.
12267
12268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12269             Jiong Wang  <jiong.wang@arm.com>
12270
12271         * aarch64-linux-nat.c
12272         (aarch64_linux_nat_target::read_description): Add pauth param.
12273         * aarch64-linux-tdep.c
12274         (aarch64_linux_core_read_description): Likewise.
12275         * aarch64-tdep.c (struct target_desc): Add in pauth.
12276         (aarch64_read_description): Add pauth param.
12277         (aarch64_gdbarch_init): Likewise.
12278         * aarch64-tdep.h (aarch64_read_description): Likewise.
12279         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12280         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12281         * features/Makefile: Add new files.
12282         * features/aarch64-pauth.c: New file.
12283         * features/aarch64-pauth.xml: New file.
12284
12285 2019-03-20  Tom Tromey  <tromey@adacore.com>
12286
12287         * infrun.c (handle_inferior_event): Rename from
12288         handle_inferior_event_1.  Create a scoped_value_mark.
12289         (handle_inferior_event): Remove.
12290
12291 2019-03-19  Tom Tromey  <tromey@adacore.com>
12292
12293         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12294         * infrun.h (print_stop_event): Add "displays" parameter.
12295         * infrun.c (print_stop_event): Add "displays" parameter.
12296
12297 2019-03-19  Pedro Alves  <palves@redhat.com>
12298
12299         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12300         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12301         to -1.  Fix TABs vs spaces.
12302         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12303         * tui/tui-out.h (tui_ui_out) Add intro comments.
12304         <m_line, m_start_of_line>: In-class initialize, and add describing
12305         comment.
12306
12307 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12308
12309         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12310         variable names.
12311         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12312
12313 2019-03-18  Pedro Alves  <palves@redhat.com>
12314             Eli Zaretskii <eliz@gnu.org>
12315
12316         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12317         m_line and m_start_of_line.
12318
12319 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12320
12321         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12322         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12323         it returns a newline.  This fixes a regression in TU mode, whereby
12324         the next line is output on the same screen line as the user input.
12325
12326 2019-03-18  Tom Tromey  <tromey@adacore.com>
12327
12328         * minsyms.c (minimal_symbol_reader::install): Remove call to
12329         obstack_blank.
12330
12331 2019-03-18  Pedro Alves  <palves@redhat.com>
12332
12333         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12334         New globals.
12335         (apply_style): New, factored out from ...
12336         (apply_ansi_escape): ... this.  Handle reverse video mode.
12337         (tui_set_reverse_mode): New function.
12338         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12339         * tui/tui-winsource.c (tui_show_source_line): Use
12340         tui_set_reverse_mode instead of setting A_STANDOUT.
12341         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12342         New setter methods.
12343
12344 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12345
12346         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12347         Handle tabs.
12348
12349 2019-03-18  Tom Tromey  <tromey@adacore.com>
12350
12351         * ada-lang.c (empty_array): Add "high" parameter.
12352         (ada_evaluate_subexp): Update.
12353
12354 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12355
12356         * unittests/string_view-selftests.c: Define
12357         _initialize_string_view_selftests unconditionally.
12358
12359 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12360
12361         PR gdb/24350
12362         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12363
12364 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12365
12366         PR gdb/24351
12367         * windows-nat.c (display_selector): Fix format specifiers.
12368
12369 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12370
12371         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12372         tui_refill_source_window instead of tui_refresh_win, to update the
12373         current execution line.  This fixes redisplay of the current line
12374         when stepping through the code with "next" or "step".
12375
12376 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12377
12378         * source-cache.c (source_cache::get_source_lines): Call
12379         find_source_lines to initialize s->nlines.  This fixes vertical
12380         scrolling of TUI source window when the DOWN arrow is pressed.
12381
12382 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12383
12384         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12385         linux-thread-db.c (_initialize_thread_db): Likewise.
12386
12387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12388
12389         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12390         wclrtoeol in tui_show_source_line".  This reverts changes made in
12391         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12392
12393 2019-03-15  Tom Tromey  <tom@tromey.com>
12394
12395         * symtab.h (struct minimal_symbol): Derive from
12396         general_symbol_info.
12397         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12398         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12399         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12400         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12401         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12402         (MSYMBOL_SEARCH_NAME): Update.
12403         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12404         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12405         * minsyms.c (minimal_symbol_reader::record_full): Update.
12406
12407 2019-03-15  Tom Tromey  <tom@tromey.com>
12408
12409         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12410
12411 2019-03-15  Tom Tromey  <tom@tromey.com>
12412
12413         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12414         unique_xmalloc_ptr.
12415         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12416         Update.
12417         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12418         (build_minimal_symbol_hash_tables)
12419         (minimal_symbol_reader::install): Update.
12420
12421 2019-03-15  Tom Tromey  <tom@tromey.com>
12422
12423         * symtab.c (create_demangled_names_hash): Update.
12424         (symbol_set_names): Update.
12425         * objfiles.h (struct objfile_per_bfd_storage)
12426         <demangled_names_hash>: Now an htab_up.
12427         * objfiles.c (objfile_per_bfd_storage): Simplify.
12428
12429 2019-03-15  Tom Tromey  <tom@tromey.com>
12430
12431         * objfiles.h (struct objfile_per_bfd_storage): Declare
12432         destructor.
12433         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12434         New.
12435         (get_objfile_bfd_data): Use new.  Don't initialize
12436         language_of_main.
12437         (free_objfile_per_bfd_storage): Remove.
12438         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12439
12440 2019-03-15  Tom Tromey  <tom@tromey.com>
12441
12442         * symfile.c (reread_symbols): Update.
12443         * objfiles.c (objfile::objfile): Update.
12444         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12445         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12446         comment.
12447         (minimal_symbol_reader::install): Update.
12448         (terminate_minimal_symbol_table): Remove.
12449         * jit.c (jit_object_close_impl): Update.
12450
12451 2019-03-15  Tom Tromey  <tom@tromey.com>
12452
12453         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12454         initializations.
12455
12456 2019-03-15  Tom Tromey  <tom@tromey.com>
12457
12458         * objfiles.h (struct objfile_per_bfd_storage)
12459         <demangled_hash_languages>: Now a bitset.
12460         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12461         (lookup_minimal_symbol): Update.
12462
12463 2019-03-15  Tom Tromey  <tom@tromey.com>
12464
12465         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12466         Don't return the symbol.
12467         * coffread.c (record_minimal_symbol): Use record_full.
12468
12469 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12470
12471         The MS-Windows port of ncurses fails to switch to a color pair if
12472         one or both of the colors are the implicit default colors.  This
12473         change records the default colors when TUI is initialized, and
12474         then specifies them explicitly when a color pair uses the default
12475         colors.  This allows color styling in TUI mode on MS-Windows.
12476
12477         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12478         ncurses_norm_attr.
12479         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12480         colors in ncurses_norm_attr.
12481         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12482         "none", replace it with the default color recorded in
12483         ncurses_norm_attr.
12484
12485 2019-03-14  Tom Tromey  <tromey@adacore.com>
12486
12487         * source-cache.h (class source_cache) <get_source_lines>: Return
12488         std::string.
12489         * source-cache.c (source_cache::extract_lines): Handle case where
12490         first_pos==npos.  Return std::string.
12491         (source_cache::get_source_lines): Update.
12492
12493 2019-03-14  Tom Tromey  <tromey@adacore.com>
12494
12495         * NEWS: Add item for "style sources" commands.
12496         * source-cache.c (source_cache::get_source_lines): Check
12497         source_styling.
12498         * cli/cli-style.c (source_styling): New global.
12499         (_initialize_cli_style): Add "style sources" commands.
12500         (show_style_sources): New function.
12501         * cli/cli-style.h (source_styling): Declare.
12502
12503 2019-03-14  Pedro Alves  <palves@redhat.com>
12504             Tom Tromey  <tromey@adacore.com>
12505
12506         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12507         * tui/tui-winsource.c (tui_refill_source_window): New function,
12508         from...
12509         (tui_horizontal_source_scroll): ... here.  Move some logic.
12510         * cli/cli-style.c (set_style_enabled): Notify new observable.
12511         * tui/tui-hooks.c (tui_redisplay_source): New function.
12512         (tui_attach_detach_observers): Attach or detach
12513         tui_redisplay_source.
12514         * observable.h (source_styling_changed): New observable.
12515         * observable.c: Define source_styling_changed observable.
12516
12517 2019-03-13  Tom Tromey  <tromey@adacore.com>
12518
12519         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12520         (i386_gnu_nat_target::store_registers): Update.
12521         * target-debug.h (target_debug_print_std_string): New macro.
12522         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12523         * windows-tdep.c (display_one_tib): Update.
12524         * tui/tui-stack.c (tui_make_status_line): Update.
12525         * top.c (print_inferior_quit_action): Update.
12526         * thread.c (thr_try_catch_cmd): Update.
12527         (add_thread_with_info): Update.
12528         (thread_target_id_str): Update.
12529         (thr_try_catch_cmd): Update.
12530         (thread_command): Update.
12531         (thread_find_command): Update.
12532         * record-btrace.c (record_btrace_target::info_record)
12533         (record_btrace_resume_thread, record_btrace_target::resume)
12534         (record_btrace_cancel_resume, record_btrace_step_thread)
12535         (record_btrace_target::wait, record_btrace_target::wait)
12536         (record_btrace_target::wait, record_btrace_target::stop): Update.
12537         * progspace.c (print_program_space): Update.
12538         * process-stratum-target.c
12539         (process_stratum_target::thread_address_space): Update.
12540         * linux-fork.c (linux_fork_mourn_inferior)
12541         (detach_checkpoint_command, info_checkpoints_command)
12542         (linux_fork_context): Update.
12543         (linux_fork_detach): Update.
12544         (class scoped_switch_fork_info): Update.
12545         (delete_checkpoint_command): Update.
12546         * infrun.c (follow_fork_inferior): Update.
12547         (follow_fork_inferior): Update.
12548         (proceed_after_vfork_done): Update.
12549         (handle_vfork_child_exec_or_exit): Update.
12550         (follow_exec): Update.
12551         (displaced_step_prepare_throw): Update.
12552         (displaced_step_restore): Update.
12553         (start_step_over): Update.
12554         (resume_1): Update.
12555         (clear_proceed_status_thread): Update.
12556         (proceed): Update.
12557         (print_target_wait_results): Update.
12558         (do_target_wait): Update.
12559         (context_switch): Update.
12560         (stop_all_threads): Update.
12561         (restart_threads): Update.
12562         (finish_step_over): Update.
12563         (handle_signal_stop): Update.
12564         (switch_back_to_stepped_thread): Update.
12565         (keep_going_pass_signal): Update.
12566         (print_exited_reason): Update.
12567         (normal_stop): Update.
12568         * inferior.c (inferior_pid_to_str): Change return type.
12569         (print_selected_inferior): Update.
12570         (add_inferior): Update.
12571         (detach_inferior): Update.
12572         * dummy-frame.c (fprint_dummy_frames): Update.
12573         * dcache.c (dcache_info_1): Update.
12574         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12575         (btrace_fetch, btrace_clear): Update.
12576         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12577         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12578         type.
12579         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12580         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12581         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12582         * gdbarch.c, gdbarch.h: Rebuild.
12583         * gdbarch.sh (core_pid_to_str): Change return type.
12584         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12585         return type.
12586         (windows_nat_target::pid_to_str): Change return type.
12587         (windows_delete_thread): Update.
12588         (windows_nat_target::attach): Update.
12589         (windows_nat_target::files_info): Update.
12590         * target-delegates.c: Rebuild.
12591         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12592         return type.
12593         (sol_thread_target::pid_to_str): Change return type.
12594         * remote.c (class remote_target) <pid_to_str>: Change return
12595         type.
12596         (remote_target::pid_to_str): Change return type.
12597         (extended_remote_target::attach, remote_target::remote_stop_ns)
12598         (remote_target::remote_notif_remove_queued_reply)
12599         (remote_target::push_stop_reply, remote_target::disable_btrace):
12600         Update.
12601         (extended_remote_target::attach): Update.
12602         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12603         type.
12604         (gdbsim_target::pid_to_str): Change return type.
12605         * ravenscar-thread.c (struct ravenscar_thread_target)
12606         <pid_to_str>: Change return type.
12607         (ravenscar_thread_target::pid_to_str): Change return type.
12608         * procfs.c (class procfs_target) <pid_to_str>: Change return
12609         type.
12610         (procfs_target::pid_to_str): Change return type.
12611         (procfs_target::attach): Update.
12612         (procfs_target::detach): Update.
12613         (procfs_target::fetch_registers): Update.
12614         (procfs_target::store_registers): Update.
12615         (procfs_target::wait): Update.
12616         (procfs_target::files_info): Update.
12617         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12618         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12619         return type.
12620         (nto_procfs_target::pid_to_str): Change return type.
12621         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12622         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12623         return type.
12624         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12625         (exit_lwp): Update.
12626         (attach_proc_task_lwp_callback, get_detach_signal)
12627         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12628         (linux_nat_target::resume, wait_lwp, stop_callback)
12629         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12630         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12631         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12632         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12633         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12634         type.
12635         (inf_ptrace_target::attach): Update.
12636         (inf_ptrace_target::files_info): Update.
12637         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12638         type.
12639         (go32_nat_target::pid_to_str): Change return type.
12640         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12641         (gnu_nat_target::wait): Update.
12642         (gnu_nat_target::wait): Update.
12643         (gnu_nat_target::resume): Update.
12644         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12645         (fbsd_nat_target::wait): Update.
12646         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12647         type.
12648         (darwin_nat_target::attach): Update.
12649         * corelow.c (class core_target) <pid_to_str>: Change return type.
12650         (core_target::pid_to_str): Change return type.
12651         * target.c (normal_pid_to_str): Change return type.
12652         (default_pid_to_str): Likewise.
12653         (target_pid_to_str): Change return type.
12654         (target_translate_tls_address): Update.
12655         (target_announce_detach): Update.
12656         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12657         return type.
12658         (bsd_uthread_target::pid_to_str): Change return type.
12659         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12660         type.
12661         (bsd_kvm_target::pid_to_str): Change return type.
12662         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12663         return type.
12664         (aix_thread_target::pid_to_str): Change return type.
12665         * target.h (struct target_ops) <pid_to_str>: Change return type.
12666         (target_pid_to_str, normal_pid_to_str): Likewise.
12667         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12668         type.
12669         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12670         type.
12671         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12672         return type.
12673         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12674         type.
12675         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12676         type.
12677         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12678         return type.
12679
12680 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12681
12682         * NEWS: Mention that the new default MI version is 3.  Mention
12683         changes to the output of commands and events that deal with
12684         multi-location breakpoints.
12685         * breakpoint.c: Include "mi/mi-out.h".
12686         (print_one_breakpoint): Change output syntax if using MI version
12687         >= 3.
12688         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12689         New.
12690         (mi_multi_location_breakpoint_output_fixed): New.
12691         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12692         (mi_cmd_fix_multi_location_breakpoint_output): New.
12693         (mi_multi_location_breakpoint_output_fixed): New.
12694         * mi/mi-cmds.c (mi_cmds): Register command
12695         -fix-multi-location-breakpoint-output.
12696         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12697         interpreter "mi".
12698
12699 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12700
12701         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12702         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12703         instantiate mi_ui_out based on interpreter name.
12704         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12705         * mi/mi-main.c (mi_load_progress): Likewise.
12706
12707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12708
12709         * NEWS: Combine separate "New targets" sections for 8.3.
12710
12711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12712
12713         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12714         (ppcfbsd_init_abi): Install gdbarch
12715         "fetch_tls_load_module_address" and "get_thread_local_address"
12716         methods.
12717
12718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12719
12720         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12721         (riscv_fbsd_init_abi): Install gdbarch
12722         "fetch_tls_load_module_address" and "get_thread_local_address"
12723         methods.
12724
12725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12726
12727         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12728         (i386fbsd_init_abi): Install gdbarch
12729         "fetch_tls_load_module_address" and "get_thread_local_address"
12730         methods.
12731
12732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12733
12734         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12735         (amd64fbsd_init_abi): Install gdbarch
12736         "fetch_tls_load_module_address" and "get_thread_local_address"
12737         methods.
12738
12739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12740
12741         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12742         (struct fbsd_pspace_data): New type.
12743         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12744         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12745         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12746         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12747         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12748
12749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12750
12751         * gdbtypes.c (lookup_struct_elt): New function.
12752         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12753         * gdbtypes.h (struct struct_elt): New type.
12754         (lookup_struct_elt): New prototype.
12755
12756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12757
12758         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12759         remove disabled code block.
12760
12761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12762
12763         * gdbarch.sh (get_thread_local_address): New method.
12764         * gdbarch.h, gdbarch.c: Regenerate.
12765         * target.c (target_translate_tls_address): Use
12766         gdbarch_get_thread_local_address if present instead of
12767         target::get_thread_local_address.
12768
12769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12770
12771         * target.h (target::get_thread_local_address): Update comment.
12772
12773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12774
12775         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12776         objfile->separate_debug_objfile_backlink if not NULL.
12777
12778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12779
12780         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12781         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12782         (amd64bsd_store_inferior_registers): Likewise.
12783         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12784         Enable segment base registers.
12785         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12786         PT_GETFSBASE and PT_GETGSBASE.
12787         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12788         PT_SETGSBASE.
12789         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12790         segment base registers.
12791         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12792
12793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12794
12795         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12796         Update calls to i386_target_description to add 'segments'
12797         parameter.
12798         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12799         add segment base registers.
12800         * arch/i386.c (i386_create_target_description): Add 'segments'
12801         parameter to enable segment base registers.
12802         * arch/i386.h (i386_create_target_description): Likewise.
12803         * features/i386/32bit-segments.xml: New file.
12804         * features/i386/32bit-segments.c: Generate.
12805         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12806         call to i386_target_description to add 'segments' parameter.
12807         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12808         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12809         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12810         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12811         if feature is present.
12812         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12813         Add 'segments' parameter to call to i386_target_description.
12814         (i386_target_description): Add 'segments' parameter to enable
12815         segment base registers.
12816         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12817         to call to i386_target_description.
12818         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12819         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12820         Define I386_NUM_REGS.
12821         (i386_target_description): Add 'segments' parameter to enable
12822         segment base registers.
12823
12824 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12825
12826         PR/24325
12827         * source-cache.c: #undef open and close, to avoid unresolved
12828         externals during linking.
12829
12830 2019-03-12  Tom Tromey  <tromey@adacore.com>
12831
12832         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12833         const.  Add initializers.
12834         (_initialize_remote): Don't initialize ptid globals.
12835
12836 2019-03-12  Pedro Alves  <palves@redhat.com>
12837
12838         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12839
12840 2019-03-12  Pedro Alves  <palves@redhat.com>
12841
12842         * cp-name-parser.y (main): Remove unused 'len' variable.
12843
12844 2019-03-12  Tom Tromey  <tromey@adacore.com>
12845
12846         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12847         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12848
12849 2019-03-12  Tom Tromey  <tromey@adacore.com>
12850
12851         * linux-nat.c (iterate_over_lwps): Update.
12852         (stop_callback): Remove parameter.
12853         (stop_wait_callback, detach_callback, resume_set_callback)
12854         (select_singlestep_lwp_callback, set_ignore_sigint)
12855         (status_callback, resumed_callback, resume_clear_callback)
12856         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12857         data parameter.
12858         (linux_nat_target::detach, linux_nat_target::resume)
12859         (linux_stop_and_wait_all_lwps, select_event_lwp)
12860         (linux_nat_filter_event, linux_nat_wait_1)
12861         (linux_nat_target::kill, linux_nat_target::stop)
12862         (linux_nat_target::stop): Update.
12863         (linux_nat_resume_callback): Change type.
12864         (resume_stopped_resumed_lwps, count_events_callback)
12865         (select_event_lwp_callback): Likewise.
12866         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12867         * arm-linux-nat.c (struct update_registers_data): Remove.
12868         (update_registers_callback): Change type.
12869         (arm_linux_insert_hw_breakpoint1): Update.
12870         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12871         parameter.
12872         (x86_linux_dr_set_addr): Update.
12873         (x86_linux_dr_set_control): Update.
12874         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12875         (iterate_over_lwps): Use gdb::function_view.
12876         * nat/aarch64-linux-hw-point.c (struct
12877         aarch64_dr_update_callback_param): Remove.
12878         (debug_reg_change_callback): Change type.
12879         (aarch64_notify_debug_reg_change): Update.
12880         * s390-linux-nat.c (s390_refresh_per_info): Update.
12881
12882 2019-03-11  Tom Tromey  <tromey@adacore.com>
12883
12884         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12885         redundant assignment to "this_cu".
12886
12887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12888
12889         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12890
12891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12892
12893         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12894         from...
12895         (rank_one_type): ... this.
12896
12897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12898
12899         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12900         from...
12901         (rank_one_type): ... this.
12902
12903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12904
12905         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12906         from...
12907         (rank_one_type): ... this.
12908
12909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12910
12911         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12912         from...
12913         (rank_one_type): ... this.
12914
12915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12916
12917         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12918         from...
12919         (rank_one_type): ... this.
12920
12921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12922
12923         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12924         from...
12925         (rank_one_type): ... this.
12926
12927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12928
12929         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12930         from...
12931         (rank_one_type): ... this.
12932
12933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12934
12935         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12936         from...
12937         (rank_one_type): ... this.
12938
12939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12940
12941         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12942         from...
12943         (rank_one_type): ... this.
12944
12945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12946
12947         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12948         from...
12949         (rank_one_type): ... this.
12950
12951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12952
12953         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12954         from...
12955         (rank_one_type): ... this.
12956
12957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12958
12959         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12960         from...
12961         (rank_one_type): ... this.
12962
12963 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12964
12965         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12966         inferior-events' shows the example events.
12967
12968 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12969
12970         Support styling on native MS-Windows console
12971
12972         PR/24315
12973         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12974         on MS-Windows if $TERM is not defined.
12975
12976         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12977
12978         * posix-hdep.c (gdb_console_fputs):
12979         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12980         functions.
12981         * ui-file.h (gdb_console_fputs): Add prototype.
12982
12983         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12984         back to fputs only if the former returns zero.
12985
12986 2019-03-07  Tom Tromey  <tom@tromey.com>
12987
12988         * symmisc.c (print_symbol_bcache_statistics): Update.
12989         (print_objfile_statistics): Update.
12990         * symfile.c (allocate_symtab): Update.
12991         * stabsread.c: Don't include bcache.h.
12992         * psymtab.h (struct psymbol_bcache): Don't declare.
12993         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12994         (psymbol_bcache_init, psymbol_bcache_free)
12995         (psymbol_bcache_get_bcache): Don't declare.
12996         * psymtab.c (struct psymbol_bcache): Remove.
12997         (psymtab_storage::psymtab_storage): Update.
12998         (psymtab_storage::~psymtab_storage): Update.
12999         (psymbol_bcache_init, psymbol_bcache_free)
13000         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13001         (add_psymbol_to_bcache): Update.
13002         (allocate_psymtab): Update.
13003         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13004         macro_cache>: No longer pointers.
13005         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13006         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13007         * macrotab.c (macro_bcache): Update.
13008         * macroexp.c: Don't include bcache.h.
13009         * gdbtypes.c (check_types_worklist): Update.
13010         (types_deeply_equal): Remove TRY/CATCH.  Update.
13011         * elfread.c (elf_symtab_read): Update.
13012         * dwarf2read.c: Don't include bcache.h.
13013         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13014         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13015         (print_bcache_statistics, bcache_memory_used): Don't declare.
13016         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13017         methods.  Rename all data members.
13018         * bcache.c (struct bcache): Move to bcache.h.
13019         (bcache::expand_hash_table): Rename from expand_hash_table.
13020         (bcache): Remove.
13021         (bcache::insert): Rename from bcache_full.
13022         (bcache::compare): Rename from bcache_compare.
13023         (bcache_xmalloc): Remove.
13024         (bcache::~bcache): Rename from bcache_xfree.
13025         (bcache::print_statistics): Rename from print_bcache_statistics.
13026         (bcache::memory_used): Rename from bcache_memory_used.
13027
13028 2019-03-07  Pedro Alves  <palves@redhat.com>
13029
13030         * infrun.c (normal_stop): Also check for
13031         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13032
13033 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13034
13035         * f-lang.c (value_from_host_double): Moved to...
13036         * value.c (value_from_host_double): ...here.
13037         * value.h (value_from_host_double): Declare.
13038         * guile/scm-math.c (vlscm_convert_typed_number): Use
13039         value_from_host_double.
13040         (vlscm_convert_number): Likewise.
13041         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13042         * python/py-value.c (convert_value_from_python): Likewise.
13043
13044 2019-03-06  Tom Tromey  <tom@tromey.com>
13045
13046         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13047
13048 2019-03-06  Tom Tromey  <tom@tromey.com>
13049
13050         * utils.h (free_current_contents): Don't declare.
13051         * utils.c (free_current_contents): Remove.
13052
13053 2019-03-06  Tom Tromey  <tom@tromey.com>
13054
13055         * top.c (quit_force): Update.
13056         * main.c (captured_command_loop): Update.
13057         * common/new-op.c (operator new): Update.
13058         * common/common-exceptions.c (struct catcher)
13059         <save_cleanup_chain>: Remove member.
13060         (exceptions_state_mc_init): Update.
13061         (exception_try_scope_entry): Return nullptr.
13062         (exception_try_scope_exit, exception_rethrow)
13063         (throw_exception_sjlj, throw_exception_cxx): Update.
13064         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13065         (all_cleanups, do_cleanups, discard_cleanups)
13066         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13067         (restore_cleanups, restore_final_cleanups): Don't declare.
13068         (do_final_cleanups): Remove parameter.
13069         * common/cleanups.c (cleanup_chain, make_cleanup)
13070         (make_cleanup_dtor, all_cleanups, do_cleanups)
13071         (discard_my_cleanups, discard_cleanups)
13072         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13073         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13074         (null_cleanup): Remove.
13075         (do_final_cleanups): Remove parameter.
13076
13077 2019-03-06  Tom Tromey  <tom@tromey.com>
13078
13079         * remote.c (remote_target::remote_parse_stop_reply): Use
13080         unique_xmalloc_ptr.
13081
13082 2019-03-06  Tom Tromey  <tom@tromey.com>
13083
13084         * stabsread.c (struct stabs_field_info): Rename from field_info.
13085         <list, fnlist>: Add initializers.
13086         <obstack>: New member.
13087         (read_member_functions, read_struct_fields, read_baseclasses):
13088         Allocate on obstack.  Don't use cleanups.
13089         (read_one_struct_field, read_member_functions, read_struct_fields)
13090         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13091         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13092         (read_struct_type): Update.
13093
13094 2019-03-06  Tom Tromey  <tom@tromey.com>
13095
13096         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13097         * common/filestuff.h (make_cleanup_close): Don't declare.
13098         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13099         Remove.
13100
13101 2019-03-06  Tom Tromey  <tom@tromey.com>
13102
13103         * solib-aix.c: Use make_scope_exit.
13104
13105 2019-03-06  Tom Tromey  <tom@tromey.com>
13106
13107         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13108         Use make_scope_exit.
13109
13110 2019-03-06  Tom Tromey  <tom@tromey.com>
13111
13112         * solib-svr4.c (disable_probes_interface): Remove parameter.
13113         (svr4_handle_solib_event): Use make_scope_exit.
13114
13115 2019-03-06  Tom Tromey  <tom@tromey.com>
13116
13117         * remote.c (struct stop_reply_deleter): Remove.
13118         (stop_reply_up): Update.
13119         (struct stop_reply): Derive from notif_event.  Don't typedef.
13120         <regcache>: Now a std::vector.
13121         (stop_reply_xfree): Remove.
13122         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13123         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13124         (remote_target::discard_pending_stop_replies): Use delete.
13125         (remote_target::remote_parse_stop_reply): Update.
13126         (remote_target::process_stop_reply): Update.
13127         * remote-notif.h (struct notif_event): Add virtual destructor.
13128         Remove "dtr" member.
13129         (struct notif_client) <alloc_event>: Return a unique_ptr.
13130         (notif_event_xfree): Don't declare.
13131         (notif_event_up): New typedef.
13132         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13133         (notif_event_xfree, do_notif_event_xfree): Remove.
13134         (remote_notif_state_xfree): Update.
13135
13136 2019-03-06  Tom Tromey  <tom@tromey.com>
13137
13138         * infrun.c (displaced_step_clear_cleanup): Now a
13139         forward_scope_exit type.
13140         (displaced_step_prepare_throw): Update.
13141         (displaced_step_fixup): Update.
13142
13143 2019-03-06  Tom Tromey  <tom@tromey.com>
13144
13145         * inferior.h (class inferior): Update comment.
13146         * gdbthread.h (class thread_info): Update comment.
13147
13148 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13149             Tom Tromey  <tom@tromey.com>
13150
13151         * stabsread.h (struct stab_section_list): Remove.
13152         (coffstab_build_psymtabs): Update.
13153         * dbxread.c (symbuf_sections): Now a std::vector.
13154         (sect_idx): New global.
13155         (fill_symbuf): Update.
13156         (coffstab_build_psymtabs): Change type of stabsects parameter.
13157         Update.
13158         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13159         std::vector.
13160         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13161         (coff_locate_sections): Update.
13162         (coff_symfile_read): Remove cleanups.  Update.
13163         (init_stringtab): Add storage parameter.
13164         (free_stringtab, free_stringtab_cleanup): Remove.
13165         (init_lineno): Add storage parameter.
13166         (free_linetab, free_linetab_cleanup): Remove.
13167
13168 2019-03-06  Pedro Alves  <palves@redhat.com>
13169
13170         * linux-fork.c (fork_info::clobber_regs): Delete.
13171         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13172         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13173         comment.  Adjust.
13174         (scoped_switch_fork_info::scoped_switch_fork_info)
13175         (checkpoint_command, linux_fork_context): Adjust
13176         fork_save_infrun_state calls.
13177
13178 2019-03-06  Pedro Alves  <palves@redhat.com>
13179
13180         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13181         (inf_has_multiple_threads): Return 'bool' and rewrite using
13182         inferior_info::threads().
13183
13184 2019-03-06  Pedro Alves  <palves@redhat.com>
13185
13186         * linux-fork.c: Include <list>.
13187         (fork_list): Now a std::list instance.
13188         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13189         (forks_exist_p, find_last_fork): Adjust.
13190         (new_fork): Delete.
13191         (one_fork_p): New.
13192         (add_fork): Adjust.
13193         (free_fork): Delete, folded into fork_info::~fork_info().
13194         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13195         Adjust.
13196         (init_fork_list): Delete.
13197         (linux_fork_killall, linux_fork_mourn_inferior)
13198         (linux_fork_detach, info_checkpoints_command): Adjust.
13199         (_initialize_linux_fork): No longer call init_fork_list.
13200
13201 2019-03-06  Pedro Alves  <palves@redhat.com>
13202
13203         * linux-fork.c (new_fork): New, split out of ...
13204         (add_fork): ... this.  Return void.  Move "first fork" special
13205         case from here, to ...
13206         (checkpoint_command): ... here.
13207         * linux-linux.h (add_fork): Return void.
13208
13209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13210
13211         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13212
13213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13214             Chris January  <chris.january@arm.com>
13215             David Lecomber  <david.lecomber@arm.com>
13216
13217         * f-exp.y: New token, UNOP_INTRINSIC.
13218         (exp): New pattern using UNOP_INTRINSIC token.
13219         (f77_keywords): Add 'abs' keyword.
13220         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13221         (value_from_host_double): New function.
13222         (evaluate_subexp_f): Support UNOP_ABS.
13223
13224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13225
13226         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13227         types.
13228
13229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13230
13231         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13232         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13233         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13234
13235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13236
13237         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13238
13239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13240             Chris January  <chris.january@arm.com>
13241
13242         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13243         * f-exp.y: Define 'KIND' token.
13244         (exp): New pattern for KIND expressions.
13245         (ptype): Handle types with a kind extension.
13246         (direct_abs_decl): Extend to spot kind extensions.
13247         (f77_keywords): Add 'kind' to the list.
13248         (push_kind_type): New function.
13249         (convert_to_kind_type): New function.
13250         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13251         * parse.c (operator_length_standard): Likewise.
13252         * parser-defs.h (enum type_pieces): Add tp_kind.
13253         * std-operator.def: Add UNOP_KIND.
13254
13255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13256
13257         * f-exp.y (f_parse): Set yydebug.
13258
13259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13260
13261         * f-lang.c (evaluate_subexp_f): New function.
13262         (exp_descriptor_f): New global.
13263         (f_language_defn): Use exp_descriptor_f instead of
13264         exp_descriptor_standard.
13265
13266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13267
13268         * f-exp.y (struct token): Add comments.
13269         (dot_ops): Remove uppercase versions and the end marker.
13270         (f77_keywords): Likewise.
13271         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13272         entries in the dot_ops array are case insensitive, and use
13273         strncasecmp to compare strings.  Also some whitespace cleanup in
13274         this area.  Similar for the f77_keywords array, except entries in
13275         this list might be case sensitive.
13276
13277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13278
13279         * f-exp.y (struct f77_boolean_val): Add comments.
13280         (boolean_values): Remove uppercase versions, and end marker.
13281         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13282         and use strncasecmp to achieve case insensitivity.  Additionally,
13283         perform whitespace cleanup around this code.
13284
13285 2019-03-06  Tom Tromey  <tromey@adacore.com>
13286
13287         * remote-sim.c (gdbsim_target_open): Use result of
13288         gdb_argv::release.
13289
13290 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13291         Dirk Schubert  <dirk.schubert@arm.com>
13292         Chris January  <chris.january@arm.com>
13293
13294         * eval.c (evaluate_subexp_standard): Call Fortran argument
13295         wrapping logic.
13296         * f-lang.c (struct value): A value which can be passed into a
13297         Fortran function call.
13298         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13299         where appropriate.
13300         (struct type): Value ready for a Fortran function call.
13301         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13302         is needed.
13303         * f-lang.h (fortran_argument_convert): Declaration.
13304         (fortran_preserve_arg_pointer): Declaration.
13305         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13306
13307 2019-03-05  Tom Tromey  <tromey@adacore.com>
13308
13309         * python/py-prettyprint.c (print_string_repr): Remove #if.
13310         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13311
13312 2019-03-05  Tom Tromey  <tromey@adacore.com>
13313
13314         * target.c (the_dummy_target): Move later.  Change type to
13315         "dummy_target".
13316         (initialize_targets): Don't initialize the_dummy_target.
13317
13318 2019-03-05  Tom Tromey  <tromey@adacore.com>
13319
13320         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13321         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13322
13323 2019-03-05  Tom Tromey  <tromey@adacore.com>
13324
13325         * windows-nat.c (windows_nat_target::attach)
13326         (windows_nat_target::detach): Don't call gdb_flush.
13327         * valprint.c (generic_val_print, val_print, val_print_string):
13328         Don't call gdb_flush.
13329         * utils.c (defaulted_query): Don't call gdb_flush.
13330         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13331         * target.c (target_announce_detach): Don't call gdb_flush.
13332         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13333         * remote.c (extended_remote_target::attach): Don't call
13334         gdb_flush.
13335         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13336         * printcmd.c (do_examine): Don't call gdb_flush.
13337         (info_display_command): Don't call gdb_flush.
13338         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13339         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13340         * memattr.c (info_mem_command): Don't call gdb_flush.
13341         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13342         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13343         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13344         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13345         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13346         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13347         (gnu_nat_target::detach): Don't call gdb_flush.
13348         * f-valprint.c (f_val_print): Don't call gdb_flush.
13349         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13350         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13351         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13352         gdb_flush.
13353         * c-valprint.c (c_val_print): Don't call gdb_flush.
13354         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13355
13356 2019-03-05  Tom Tromey  <tromey@adacore.com>
13357
13358         * varobj.c (update_dynamic_varobj_children): Update.
13359         (install_default_visualizer): Use reset, not release.
13360         * value.c (set_internalvar): Update.
13361         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13362         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13363         ATTRIBUTE_UNUSED_RESULT.
13364
13365 2019-03-05  Tom Tromey  <tromey@adacore.com>
13366
13367         * remote.c (class scoped_remote_fd) <release>: Add
13368         ATTRIBUTE_UNUSED_RESULT.
13369
13370 2019-03-05  Tom Tromey  <tromey@adacore.com>
13371
13372         * macroexp.c (struct macro_buffer) <release>: Add
13373         ATTRIBUTE_UNUSED_RESULT.
13374
13375 2019-03-05  Tom Tromey  <tromey@adacore.com>
13376
13377         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13378         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13379         ATTRIBUTE_UNUSED_RESULT.
13380
13381 2019-03-05  Tom Tromey  <tromey@adacore.com>
13382
13383         * common/scoped_fd.h (class scoped_fd) <release>: Add
13384         ATTRIBUTE_UNUSED_RESULT.
13385
13386 2019-03-05  Tom Tromey  <tromey@adacore.com>
13387
13388         * parser-defs.h (struct parser_state) <release>: Add
13389         ATTRIBUTE_UNUSED_RESULT.
13390
13391 2019-03-05  Tom Tromey  <tromey@adacore.com>
13392
13393         * utils.h (class gdb_argv) <release>: Add
13394         ATTRIBUTE_UNUSED_RESULT.
13395         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13396
13397 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13398
13399         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13400         for-loop range, to avoid compiler warnings.
13401
13402         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13403         avoid compiler warnings about unused variables.
13404
13405         * NEWS: Mention end of support for native debugging on MS-Windows
13406         before XP.
13407
13408         PR gdb/24292
13409         * common/netstuff.c:
13410         * gdbserver/gdbreplay.c
13411         * gdbserver/remote-utils.c:
13412         * ser-tcp.c:
13413         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13414         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13415         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13416         'getaddrinfo' and 'freeaddrinfo' were not available before
13417         Windows XP, and mingw.org's MinGW headers by default define
13418         _WIN32_WINNT to 0x500.
13419
13420 2019-03-01  Gary Benson <gbenson@redhat.com>
13421
13422         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13423
13424 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13425             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13426
13427         PR gdb/8527
13428         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13429         set_sigint_trap, clear_sigint_trap.
13430
13431 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13432
13433         * target.c (target_detach): Clear the regcache and the
13434         frame cache.
13435
13436 2019-02-27  Pedro Alves  <palves@redhat.com>
13437
13438         * utils.c (set_screen_size): When we cap the height/width sizes,
13439         tweak the corresponding command variable to show "unlimited":
13440
13441 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13442             Pedro Alves  <palves@redhat.com>
13443
13444         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13445         before calling rl_set_screen_size.
13446
13447 2019-02-27  Tom Tromey  <tromey@adacore.com>
13448
13449         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13450         define.
13451         * python/py-value.c: Remove Python 2.4 workaround.
13452         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13453         workaround.
13454         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13455         Python 2.4 workaround.
13456         * python/python-internal.h: Remove Python 2.4 comment.
13457         (Py_ssize_t): Don't define.
13458         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13459         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13460         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13461         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13462         * python/python.c (do_start_initialization): Remove Python 2.4
13463         workaround.
13464         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13465         (print_children): Remove Python 2.4 workaround.
13466         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13467         workaround.
13468         (CHARBUFFERPROC_NAME): Remove.
13469         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13470         Python 2.4 workaround.
13471
13472 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13473
13474         * NEWS: Note minimum Python version.
13475
13476 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13477
13478         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13479         code from these functions.  Remove corresponding ifdefs.  Use
13480         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13481         Remove gotos and target of gotos.
13482         (infpy_search_memory): Likewise.
13483
13484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13485
13486         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13487         (hppa_gdbarch_init): Don't register deleted functions with
13488         gdbarch.
13489
13490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13491
13492         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13493         (h8300_unwind_sp): Delete.
13494         (h8300_dummy_id): Delete.
13495         (h8300_gdbarch_init): Don't register deleted functions with
13496         gdbarch.
13497
13498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13499
13500         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13501         (ft32_unwind_pc): Delete.
13502         (ft32_unwind_sp): Delete.
13503         (ft32_gdbarch_init): Don't register deleted functions with
13504         gdbarch.
13505
13506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13507
13508         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13509         (frv_unwind_pc): Delete.
13510         (frv_unwind_sp): Delete.
13511         (frv_gdbarch_init): Don't register deleted functions with
13512         gdbarch.
13513
13514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13515
13516         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13517         (riscv_unwind_pc): Delete.
13518         (riscv_unwind_sp): Delete.
13519         (riscv_gdbarch_init): Don't register deleted functions with
13520         gdbarch.
13521
13522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13523
13524         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13525         (csky_unwind_pc): Delete.
13526         (csky_unwind_sp): Delete.
13527         (csky_gdbarch_init): Don't register deleted functions with
13528         gdbarch.
13529
13530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13531
13532         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13533         (cris_unwind_pc): Delete.
13534         (cris_unwind_sp): Delete.
13535         (cris_gdbarch_init): Don't register deleted functions with
13536         gdbarch.
13537
13538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13539
13540         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13541         (bfin_unwind_pc): Delete.
13542         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13543
13544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13545
13546         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13547         (arm_unwind_pc): Delete.
13548         (arm_unwind_sp): Delete.
13549         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13550
13551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13552
13553         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13554         (arc_unwind_pc): Delete.
13555         (arc_unwind_sp): Delete.
13556         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13557
13558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13559
13560         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13561         (alpha_unwind_pc): Delete.
13562         (alpha_gdbarch_init): Don't register deleted functions with
13563         gdbarch.
13564
13565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13566
13567         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13568         (aarch64_unwind_pc): Delete.
13569         (aarch64_unwind_sp): Delete.
13570         (aarch64_gdbarch_init): Don't register deleted functions with
13571         gdbarch.
13572
13573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13574
13575         * gdbtypes.c (type_align): Don't consider static members when
13576         computing structure alignment.
13577
13578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13579
13580         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13581         return 0 for other types.
13582         * arch-utils.c (default_type_align): Always return 0.
13583         * gdbarch.h: Regenerate.
13584         * gdbarch.sh (type_align): Extend comment.
13585         * gdbtypes.c (type_align): Add additional comments, always call
13586         gdbarch_type_align before applying the default rules.
13587         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13588         generic code will then apply a suitable default.
13589         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13590         types, return 0 for other types.
13591
13592 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13593
13594         * NEWS: Create a new section for the next release branch.
13595         Rename the section of the current branch, now that it has
13596         been cut.
13597
13598 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13599
13600         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13601         * version.in: Bump version to 8.3.50.DATE-git.
13602
13603 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13604
13605         * aix-thread.c (ptid_cmp): Remove unused variable.
13606         (get_signaled_thread): Likewise.
13607         (store_regs_user_thread): Likewise.
13608         (store_regs_kernel_thread): Likewise.
13609         (fetch_regs_kernel_thread): Remove shadowed variable.
13610
13611 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13612
13613         * features/riscv/32bit-cpu.xml: Add register numbers.
13614         * features/riscv/32bit-fpu.c: Regenerate.
13615         * features/riscv/32bit-fpu.xml: Add register numbers.
13616         * features/riscv/64bit-cpu.xml: Add register numbers.
13617         * features/riscv/64bit-fpu.c: Regenerate.
13618         * features/riscv/64bit-fpu.xml: Add register numbers.
13619
13620 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13621
13622         * NEWS: Mention two argument form of gdb.Value constructor.
13623         * python/py-value.c (convert_buffer_and_type_to_value): New
13624         function.
13625         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13626         Add support for handling an optional second argument.  Call
13627         convert_buffer_and_type_to_value as appropriate.
13628         * python/python-internal.h (Py_buffer_deleter): New struct.
13629         (Py_buffer_up): New typedef.
13630
13631 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13632
13633         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13634         instead of releasing ownership.
13635
13636 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13637
13638         * dwarf2read.c (open_and_init_dwp_file): Call
13639         elf_numsections instead of bfd_count_sections to initialize
13640         dwp_file->num_sections.
13641
13642 2019-02-25  Tom Tromey  <tromey@adacore.com>
13643
13644         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13645
13646 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13647
13648         * gcore.in: Add '--readnever' option when invoking GDB.
13649
13650 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13651
13652         * MAINTAINERS: Update my email address.
13653
13654 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13655
13656         * build-id.c (build_id_to_debug_bfd_1): New function.
13657         (build_id_to_debug_bfd): Look for separate debug file in
13658         sysroot.
13659
13660 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13661
13662         * gdbarch.sh: Update the copyright year range that is placed into
13663         generated files.
13664
13665 2019-02-22  Keith Seitz  <keiths@redhat.com>
13666
13667         PR symtab/23853
13668         * linespec.c (create_sals_line_offset): Search for the default
13669         symtab's filename instead of its fullname.
13670
13671 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13672
13673         * NEWS: Update style defaults.
13674
13675 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13676
13677         * main.c (captured_main_1): Disable styling in batch mode.
13678
13679 2019-02-20  Tom Tromey  <tom@tromey.com>
13680
13681         * symtab.c (symtab_symbol_info): Fix typos.
13682
13683 2019-02-20  Tom Tromey  <tromey@adacore.com>
13684
13685         * findcmd.c (_initialize_mem_search): Use upper case for
13686         metasyntactic variables.
13687
13688 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13689
13690         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13691         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13692
13693 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13694
13695         * top.h (source_file_name): Change to std::string.
13696         * top.c (source_file_name): Likewise.
13697         (command_line_input): Adjust.
13698         * cli/cli-script.c (script_from_file): Adjust.
13699
13700 2019-02-19  Tom Tromey  <tromey@adacore.com>
13701
13702         * ravenscar-thread.c
13703         (ravenscar_thread_target::update_thread_list): Don't call
13704         ada_build_task_list.
13705         * ada-lang.h (ada_build_task_list): Don't declare.
13706         * ada-tasks.c (struct ada_tasks_inferior_data)
13707         <task_list_valid_p>: Now bool.
13708         (read_known_tasks, ada_task_list_changed)
13709         (ada_tasks_invalidate_inferior_data): Update.
13710         (read_known_tasks_array): Return bool.
13711         (read_known_tasks_list): Likewise.
13712         (read_known_tasks): Return void.
13713         (ada_build_task_list): Now static.
13714
13715 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13716
13717         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13718         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13719
13720 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13721
13722         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13723         variant for ada_tasks_pspace_data_handle and
13724         ada_tasks_inferior_data_handle.
13725         (ada_tasks_pspace_data_cleanup): New function.
13726         (ada_tasks_inferior_data_cleanup): New function.
13727
13728 2019-02-17  Tom Tromey  <tom@tromey.com>
13729
13730         * macrotab.h (macro_source_fullname): Return a std::string.
13731         * macrotab.c (macro_include, check_for_redefinition)
13732         (macro_undef, macro_lookup_definition, foreach_macro)
13733         (foreach_macro_in_scope): Update.
13734         (macro_source_fullname): Return a std::string.
13735         * macrocmd.c (show_pp_source_pos): Update.
13736
13737 2019-02-17  Tom Tromey  <tom@tromey.com>
13738
13739         * macrocmd.c (show_pp_source_pos): Style the file names.
13740
13741 2019-02-17  Tom Tromey  <tom@tromey.com>
13742
13743         PR tui/24197:
13744         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13745
13746 2019-02-17  Tom Tromey  <tom@tromey.com>
13747
13748         * ada-lang.c (user_select_syms): Use filtered printing.
13749         * utils.c (wrap_style): New global.
13750         (desired_style): Remove.
13751         (emit_style_escape): Add stream parameter.
13752         (set_output_style, reset_terminal_style, prompt_for_continue):
13753         Update.
13754         (flush_wrap_buffer): Only flush gdb_stdout.
13755         (wrap_here): Set wrap_style.
13756         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13757         treat escape sequences as a character.  Change when wrap buffer is
13758         flushed.
13759         (fputs_styled): Do not set the output style when the default is
13760         requested.
13761         * ui-style.h (struct ui_file_style) <is_default>: New method.
13762         * source.c (print_source_lines_base): Emit escape sequences in one
13763         piece.
13764
13765 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13766
13767         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13768         integers and enumeration types.
13769
13770 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13771
13772         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13773         instead of lookup_symbol_in_language
13774         (do_exact_match): New function.
13775         (ada_get_symbol_name_matcher): Return do_exact_match when
13776         doing a verbatim match.
13777
13778 2019-02-15  Tom Tromey  <tromey@adacore.com>
13779
13780         * ravenscar-thread.c (ravenscar_thread_target::resume)
13781         (ravenscar_thread_target::wait): Special case wildcard requests.
13782
13783 2019-02-15  Tom Tromey  <tromey@adacore.com>
13784
13785         * ravenscar-thread.c (base_ptid): Remove.
13786         (struct ravenscar_thread_target) <close>: New method.
13787         <m_base_ptid>: New member.
13788         <update_inferior_ptid, active_task, task_is_currently_active,
13789         runtime_initialized>: Declare methods.
13790         <ravenscar_thread_target>: Add constructor.
13791         (ravenscar_thread_target::task_is_currently_active)
13792         (ravenscar_thread_target::update_inferior_ptid)
13793         (ravenscar_runtime_initialized): Rename.  Now methods.
13794         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13795         (ravenscar_thread_target::update_thread_list): Update.
13796         (ravenscar_thread_target::active_task): Now method.
13797         (ravenscar_thread_target::store_registers)
13798         (ravenscar_thread_target::prepare_to_store)
13799         (ravenscar_thread_target::prepare_to_store)
13800         (ravenscar_thread_target::mourn_inferior): Update.
13801         (ravenscar_inferior_created): Use "new" to create target.
13802         (ravenscar_thread_target::get_ada_task_ptid): Update.
13803         (_initialize_ravenscar): Don't initialize base_ptid.
13804         (ravenscar_ops): Remove global.
13805
13806 2019-02-15  Tom Tromey  <tromey@adacore.com>
13807
13808         * target.h (push_target): Declare new overload.
13809         * target.c (push_target): New overload, taking an rvalue reference.
13810         * remote.c (remote_target::open_1): Use push_target overload.
13811         * corelow.c (core_target_open): Use push_target overload.
13812
13813 2019-02-15  Tom Tromey  <tromey@adacore.com>
13814
13815         * ravenscar-thread.c (is_ravenscar_task)
13816         (ravenscar_task_is_currently_active): Return bool.
13817         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13818         (_initialize_ravenscar): Remove "(void)".
13819         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13820         Return bool.
13821
13822 2019-02-15  Tom Tromey  <tromey@adacore.com>
13823
13824         * ravenscar-thread.c (ravenscar_runtime_initializer)
13825         (has_ravenscar_runtime, get_running_thread_id)
13826         (ravenscar_thread_target::resume): Fix indentation.
13827
13828 2019-02-15  Tom Tromey  <tromey@adacore.com>
13829
13830         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13831         from ravenscar_arch_ops.
13832         (sparc_ravenscar_ops::fetch_registers)
13833         (sparc_ravenscar_ops::store_registers): Now methods.
13834         (sparc_ravenscar_prepare_to_store): Remove.
13835         (sparc_ravenscar_ops): Redefine.
13836         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13837         methods and destructor.  Remove members.
13838         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13839         (ravenscar_thread_target::store_registers)
13840         (ravenscar_thread_target::prepare_to_store): Update.
13841         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13842         Remove.
13843         (struct ppc_ravenscar_powerpc_ops): Derive from
13844         ravenscar_arch_ops.
13845         (ppc_ravenscar_powerpc_ops::fetch_registers)
13846         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13847         (ppc_ravenscar_powerpc_ops): Redefine.
13848         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13849         (ppc_ravenscar_e500_ops::fetch_registers)
13850         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13851         (ppc_ravenscar_e500_ops): Redefine.
13852         * aarch64-ravenscar-thread.c
13853         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13854         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13855         (aarch64_ravenscar_fetch_registers)
13856         (aarch64_ravenscar_store_registers): Now methods.
13857         (aarch64_ravenscar_ops): Redefine.
13858
13859 2019-02-15  Tom Tromey  <tromey@adacore.com>
13860
13861         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13862         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13863         (ravenscar_thread_target::stopped_by_watchpoint)
13864         (ravenscar_thread_target::stopped_data_address)
13865         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13866
13867 2019-02-15  Tom Tromey  <tromey@adacore.com>
13868
13869         * ravenscar-thread.c: Fix some typos.
13870
13871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13872             Tom Tromey  <tromey@adacore.com>
13873
13874         * ada-lang.c (ada_exception_sal): Change addr_string to a
13875         std::string.
13876         (create_ada_exception_catchpoint): Update.
13877
13878 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13879             Tom Tromey  <tromey@adacore.com>
13880
13881         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13882         (bp_location_ops): Remove.
13883         (base_breakpoint_allocate_location): Update.
13884         (free_bp_location): Update.
13885         * ada-lang.c (class ada_catchpoint_location)
13886         <ada_catchpoint_location>: Remove ops parameter.
13887         (ada_catchpoint_location_dtor): Remove.
13888         (ada_catchpoint_location_ops): Remove.
13889         (allocate_location_exception): Update.
13890         * breakpoint.h (struct bp_location_ops): Remove.
13891         (class bp_location) <bp_location>: Remove bp_location_ops
13892         parameter.
13893         <~bp_location>: Add destructor.
13894         <ops>: Remove.
13895
13896 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13897             Pedro Alves  <palves@redhat.com>
13898
13899         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13900         'PATH_MAX'.
13901
13902 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13903             Samuel Thibault  <samuel.thibault@gnu.org>
13904             Thomas Schwinge  <thomas@codesourcery.com>
13905
13906         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13907         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13908
13909 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13910
13911         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13912         (check_empty): Use "const char *".
13913
13914         * gnu-nat.c (gnu_nat_target::detach): Instead of
13915         'detach_inferior (pid)' call
13916         'detach_inferior (find_inferior_pid (pid))'.
13917
13918         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13919         'nat/fork-inferior.o'.
13920         * gnu-nat.c: #include "nat/fork-inferior.h".
13921
13922         * gnu-nat.c (gnu_nat_target::detach): Instead of
13923         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13924         * gnu-nat.h: #include "inf-child.h".
13925         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13926         'i386_gnu_nat_target::fetch_registers'.
13927         (gnu_store_registers): Rename/move to
13928         'i386_gnu_nat_target::store_registers'.
13929
13930         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13931         * gnu-nat.h (mach_thread_info): New function.
13932         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13933
13934         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13935
13936 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13937
13938         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13939
13940 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13941
13942         * windows-nat.c (windows_add_thread): Add new parameter
13943         "main_thread_p" with default value set to false.  Update
13944         function documentation as well as all callers.
13945         (windows_delete_thread): Likewise.
13946         (fake_create_process): Update call to windows_add_thread.
13947         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13948         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13949         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13950         call to windows_delete_thread.
13951
13952 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13953
13954         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13955
13956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13957
13958         * symfile.c (find_separate_debug_file): Use canonical path of
13959         sysroot with child_path instead of gdb_sysroot if it is valid.
13960
13961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13962
13963         * symfile.c (find_separate_debug_file): Use child_path to
13964         determine if an object file is under a sysroot.
13965
13966 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13967
13968         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13969         unittests/child-path-selftests.c.
13970         * common/pathstuff.c (child_path): New function.
13971         * common/pathstuff.h (child_path): New prototype.
13972         * unittests/child-path-selftests.c: New file.
13973
13974 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13975
13976         * symfile.c (find_separate_debug_file): Look for separate debug
13977         files in debug directories under the sysroot.
13978
13979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13980
13981         * symtab.h (struct minimal_symbol data_p): New const method.
13982         (struct minimal_symbol text_p): Likewise.
13983         * symtab.c (output_source_filename): Use file name style
13984         to print file name.
13985         (print_symbol_info): Likewise.
13986         (print_msymbol_info): Use address style to print addresses.
13987         Use function name style to print executable text symbols.
13988         (expand_symtab_containing_pc): Use data_p.
13989         (find_pc_sect_compunit_symtab): Likewise.
13990
13991 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13992
13993         * breakpoint.c (describe_other_breakpoints): Use address style
13994         to print addresses.
13995         (say_where): Likewise.
13996
13997 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13998
13999         * ada-typeprint.c (print_func_type): Print function name
14000         style to print function name.
14001         * c-typeprint.c (c_print_type_1): Likewise.
14002
14003 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14004
14005         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14006         for execve.
14007
14008 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14009
14010         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14011         type_stack.
14012
14013 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14014
14015         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14016         TYPE_CODE_REF types.
14017
14018 2019-02-08  Jim Wilson  <jimw@sifive.com>
14019
14020         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14021         (riscv_linux_fregset): New.
14022         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14023
14024 2019-02-07  Tom Tromey  <tom@tromey.com>
14025
14026         * thread.c (thread_cancel_execution_command): Update.
14027         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14028         methods.
14029         (struct thread_fsm_ops): Remove.
14030         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14031         (thread_fsm_should_stop, thread_fsm_return_value)
14032         (thread_fsm_set_finished, thread_fsm_finished_p)
14033         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14034         Don't declare.
14035         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14036         * infrun.c (clear_proceed_status_thread)
14037         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14038         (print_stop_event): Update.
14039         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14040         Add constructor.
14041         (step_command_fsm_ops): Remove.
14042         (new_step_command_fsm): Remove.
14043         (step_1): Update.
14044         (step_command_fsm::should_stop): Rename from
14045         step_command_fsm_should_stop.
14046         (step_command_fsm::clean_up): Rename from
14047         step_command_fsm_clean_up.
14048         (step_command_fsm::do_async_reply_reason): Rename from
14049         step_command_fsm_async_reply_reason.
14050         (struct until_next_fsm): Inherit from thread_fsm.  Add
14051         constructor.
14052         (until_next_fsm_ops): Remove.
14053         (new_until_next_fsm): Remove.
14054         (until_next_fsm::should_stop): Rename from
14055         until_next_fsm_should_stop.
14056         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14057         (until_next_fsm::do_async_reply_reason): Rename from
14058         until_next_fsm_async_reply_reason.
14059         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14060         constructor.  Change type of breakpoint.
14061         (finish_command_fsm_ops): Remove.
14062         (new_finish_command_fsm): Remove.
14063         (finish_command_fsm::should_stop): Rename from
14064         finish_command_fsm_should_stop.
14065         (finish_command_fsm::clean_up): Rename from
14066         finish_command_fsm_clean_up.
14067         (finish_command_fsm::return_value): Rename from
14068         finish_command_fsm_return_value.
14069         (finish_command_fsm::do_async_reply_reason): Rename from
14070         finish_command_fsm_async_reply_reason.
14071         (finish_command): Update.
14072         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14073         Add constructor.
14074         (call_thread_fsm_ops): Remove.
14075         (call_thread_fsm::call_thread_fsm): Rename from
14076         new_call_thread_fsm.
14077         (call_thread_fsm::should_stop): Rename from
14078         call_thread_fsm_should_stop.
14079         (call_thread_fsm::should_notify_stop): Rename from
14080         call_thread_fsm_should_notify_stop.
14081         (run_inferior_call, call_function_by_hand_dummy): Update.
14082         * cli/cli-interp.c (should_print_stop_to_console): Update.
14083         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14084         Add constructor.  Change type of location_breakpoint,
14085         caller_breakpoint.
14086         (until_break_fsm_ops): Remove.
14087         (new_until_break_fsm): Remove.
14088         (until_break_fsm::should_stop): Rename from
14089         until_break_fsm_should_stop.
14090         (until_break_fsm::clean_up): Rename from
14091         until_break_fsm_clean_up.
14092         (until_break_fsm::do_async_reply_reason): Rename from
14093         until_break_fsm_async_reply_reason.
14094         (until_break_command): Update.
14095         * thread-fsm.c: Remove.
14096         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14097
14098 2019-02-07  Tom Tromey  <tom@tromey.com>
14099
14100         * yy-remap.h: Add include guard.
14101         * xtensa-tdep.h: Add include guard.
14102         * xcoffread.h: Rename include guard.
14103         * varobj-iter.h: Add include guard.
14104         * tui/tui.h: Rename include guard.
14105         * tui/tui-winsource.h: Rename include guard.
14106         * tui/tui-wingeneral.h: Rename include guard.
14107         * tui/tui-windata.h: Rename include guard.
14108         * tui/tui-win.h: Rename include guard.
14109         * tui/tui-stack.h: Rename include guard.
14110         * tui/tui-source.h: Rename include guard.
14111         * tui/tui-regs.h: Rename include guard.
14112         * tui/tui-out.h: Rename include guard.
14113         * tui/tui-layout.h: Rename include guard.
14114         * tui/tui-io.h: Rename include guard.
14115         * tui/tui-hooks.h: Rename include guard.
14116         * tui/tui-file.h: Rename include guard.
14117         * tui/tui-disasm.h: Rename include guard.
14118         * tui/tui-data.h: Rename include guard.
14119         * tui/tui-command.h: Rename include guard.
14120         * tic6x-tdep.h: Add include guard.
14121         * target/waitstatus.h: Rename include guard.
14122         * target/wait.h: Rename include guard.
14123         * target/target.h: Rename include guard.
14124         * target/resume.h: Rename include guard.
14125         * target-float.h: Rename include guard.
14126         * stabsread.h: Add include guard.
14127         * rs6000-tdep.h: Add include guard.
14128         * riscv-fbsd-tdep.h: Add include guard.
14129         * regformats/regdef.h: Rename include guard.
14130         * record.h: Rename include guard.
14131         * python/python.h: Rename include guard.
14132         * python/python-internal.h: Rename include guard.
14133         * python/py-stopevent.h: Rename include guard.
14134         * python/py-ref.h: Rename include guard.
14135         * python/py-record.h: Rename include guard.
14136         * python/py-record-full.h: Rename include guard.
14137         * python/py-record-btrace.h: Rename include guard.
14138         * python/py-instruction.h: Rename include guard.
14139         * python/py-events.h: Rename include guard.
14140         * python/py-event.h: Rename include guard.
14141         * procfs.h: Add include guard.
14142         * proc-utils.h: Add include guard.
14143         * p-lang.h: Add include guard.
14144         * or1k-tdep.h: Rename include guard.
14145         * observable.h: Rename include guard.
14146         * nto-tdep.h: Rename include guard.
14147         * nat/x86-linux.h: Rename include guard.
14148         * nat/x86-linux-dregs.h: Rename include guard.
14149         * nat/x86-gcc-cpuid.h: Add include guard.
14150         * nat/x86-dregs.h: Rename include guard.
14151         * nat/x86-cpuid.h: Rename include guard.
14152         * nat/ppc-linux.h: Rename include guard.
14153         * nat/mips-linux-watch.h: Rename include guard.
14154         * nat/linux-waitpid.h: Rename include guard.
14155         * nat/linux-ptrace.h: Rename include guard.
14156         * nat/linux-procfs.h: Rename include guard.
14157         * nat/linux-osdata.h: Rename include guard.
14158         * nat/linux-nat.h: Rename include guard.
14159         * nat/linux-namespaces.h: Rename include guard.
14160         * nat/linux-btrace.h: Rename include guard.
14161         * nat/glibc_thread_db.h: Rename include guard.
14162         * nat/gdb_thread_db.h: Rename include guard.
14163         * nat/gdb_ptrace.h: Rename include guard.
14164         * nat/fork-inferior.h: Rename include guard.
14165         * nat/amd64-linux-siginfo.h: Rename include guard.
14166         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14167         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14168         * nat/aarch64-linux.h: Rename include guard.
14169         * nat/aarch64-linux-hw-point.h: Rename include guard.
14170         * mn10300-tdep.h: Add include guard.
14171         * mips-linux-tdep.h: Add include guard.
14172         * mi/mi-parse.h: Rename include guard.
14173         * mi/mi-out.h: Rename include guard.
14174         * mi/mi-main.h: Rename include guard.
14175         * mi/mi-interp.h: Rename include guard.
14176         * mi/mi-getopt.h: Rename include guard.
14177         * mi/mi-console.h: Rename include guard.
14178         * mi/mi-common.h: Rename include guard.
14179         * mi/mi-cmds.h: Rename include guard.
14180         * mi/mi-cmd-break.h: Rename include guard.
14181         * m2-lang.h: Add include guard.
14182         * location.h: Rename include guard.
14183         * linux-record.h: Rename include guard.
14184         * linux-nat.h: Add include guard.
14185         * linux-fork.h: Add include guard.
14186         * i386-darwin-tdep.h: Rename include guard.
14187         * hppa-linux-offsets.h: Add include guard.
14188         * guile/guile.h: Rename include guard.
14189         * guile/guile-internal.h: Rename include guard.
14190         * gnu-nat.h: Rename include guard.
14191         * gdb-stabs.h: Rename include guard.
14192         * frv-tdep.h: Add include guard.
14193         * f-lang.h: Add include guard.
14194         * event-loop.h: Add include guard.
14195         * darwin-nat.h: Rename include guard.
14196         * cp-abi.h: Rename include guard.
14197         * config/sparc/nm-sol2.h: Rename include guard.
14198         * config/nm-nto.h: Rename include guard.
14199         * config/nm-linux.h: Add include guard.
14200         * config/i386/nm-i386gnu.h: Rename include guard.
14201         * config/djgpp/nl_types.h: Rename include guard.
14202         * config/djgpp/langinfo.h: Rename include guard.
14203         * compile/gcc-cp-plugin.h: Add include guard.
14204         * compile/gcc-c-plugin.h: Add include guard.
14205         * compile/compile.h: Rename include guard.
14206         * compile/compile-object-run.h: Rename include guard.
14207         * compile/compile-object-load.h: Rename include guard.
14208         * compile/compile-internal.h: Rename include guard.
14209         * compile/compile-cplus.h: Rename include guard.
14210         * compile/compile-c.h: Rename include guard.
14211         * common/xml-utils.h: Rename include guard.
14212         * common/x86-xstate.h: Rename include guard.
14213         * common/version.h: Rename include guard.
14214         * common/vec.h: Rename include guard.
14215         * common/tdesc.h: Rename include guard.
14216         * common/selftest.h: Rename include guard.
14217         * common/scoped_restore.h: Rename include guard.
14218         * common/scoped_mmap.h: Rename include guard.
14219         * common/scoped_fd.h: Rename include guard.
14220         * common/safe-iterator.h: Rename include guard.
14221         * common/run-time-clock.h: Rename include guard.
14222         * common/refcounted-object.h: Rename include guard.
14223         * common/queue.h: Rename include guard.
14224         * common/ptid.h: Rename include guard.
14225         * common/print-utils.h: Rename include guard.
14226         * common/preprocessor.h: Rename include guard.
14227         * common/pathstuff.h: Rename include guard.
14228         * common/observable.h: Rename include guard.
14229         * common/netstuff.h: Rename include guard.
14230         * common/job-control.h: Rename include guard.
14231         * common/host-defs.h: Rename include guard.
14232         * common/gdb_wait.h: Rename include guard.
14233         * common/gdb_vecs.h: Rename include guard.
14234         * common/gdb_unlinker.h: Rename include guard.
14235         * common/gdb_unique_ptr.h: Rename include guard.
14236         * common/gdb_tilde_expand.h: Rename include guard.
14237         * common/gdb_sys_time.h: Rename include guard.
14238         * common/gdb_string_view.h: Rename include guard.
14239         * common/gdb_splay_tree.h: Rename include guard.
14240         * common/gdb_setjmp.h: Rename include guard.
14241         * common/gdb_ref_ptr.h: Rename include guard.
14242         * common/gdb_optional.h: Rename include guard.
14243         * common/gdb_locale.h: Rename include guard.
14244         * common/gdb_assert.h: Rename include guard.
14245         * common/filtered-iterator.h: Rename include guard.
14246         * common/filestuff.h: Rename include guard.
14247         * common/fileio.h: Rename include guard.
14248         * common/environ.h: Rename include guard.
14249         * common/common-utils.h: Rename include guard.
14250         * common/common-types.h: Rename include guard.
14251         * common/common-regcache.h: Rename include guard.
14252         * common/common-inferior.h: Rename include guard.
14253         * common/common-gdbthread.h: Rename include guard.
14254         * common/common-exceptions.h: Rename include guard.
14255         * common/common-defs.h: Rename include guard.
14256         * common/common-debug.h: Rename include guard.
14257         * common/cleanups.h: Rename include guard.
14258         * common/buffer.h: Rename include guard.
14259         * common/btrace-common.h: Rename include guard.
14260         * common/break-common.h: Rename include guard.
14261         * cli/cli-utils.h: Rename include guard.
14262         * cli/cli-style.h: Rename include guard.
14263         * cli/cli-setshow.h: Rename include guard.
14264         * cli/cli-script.h: Rename include guard.
14265         * cli/cli-interp.h: Rename include guard.
14266         * cli/cli-decode.h: Rename include guard.
14267         * cli/cli-cmds.h: Rename include guard.
14268         * charset-list.h: Add include guard.
14269         * buildsym-legacy.h: Rename include guard.
14270         * bfin-tdep.h: Add include guard.
14271         * ax.h: Rename include guard.
14272         * arm-linux-tdep.h: Add include guard.
14273         * arm-fbsd-tdep.h: Add include guard.
14274         * arch/xtensa.h: Rename include guard.
14275         * arch/tic6x.h: Add include guard.
14276         * arch/i386.h: Add include guard.
14277         * arch/arm.h: Rename include guard.
14278         * arch/arm-linux.h: Rename include guard.
14279         * arch/arm-get-next-pcs.h: Rename include guard.
14280         * arch/amd64.h: Add include guard.
14281         * arch/aarch64-insn.h: Rename include guard.
14282         * arch-utils.h: Rename include guard.
14283         * annotate.h: Add include guard.
14284         * amd64-darwin-tdep.h: Rename include guard.
14285         * aarch64-linux-tdep.h: Add include guard.
14286         * aarch64-fbsd-tdep.h: Add include guard.
14287         * aarch32-linux-nat.h: Add include guard.
14288
14289 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14290
14291         * macrotab.c (macro_define_internal): New function that
14292         factorizes macro_define_object_internal and macro_define_function
14293         code.
14294         (macro_define_object_internal): Use macro_define_internal.
14295         (macro_define_function): Likewise.
14296
14297 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14298
14299         * macrocmd.c (extract_identifier): Return
14300         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14301         callers.
14302
14303 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14304
14305         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14306
14307 2019-02-05  Tom Tromey  <tom@tromey.com>
14308
14309         * target.c (target_stack::unpush): Move assertion earlier.
14310
14311 2019-01-30  Tom Tromey  <tom@tromey.com>
14312
14313         PR python/23615:
14314         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14315         (gdbpy_parse_and_eval): Likewise.
14316         * python/python-internal.h (gdbpy_allow_threads): New class.
14317
14318 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14319
14320         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14321         (aarch64_fbsd_fpregmap): Move earlier.
14322         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14323         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14324         instead of individual calls to trad_frame_set_reg_addr.
14325         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14326         earlier.
14327         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14328         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14329         instead of individual calls to trad_frame_set_reg_addr.
14330
14331 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14332
14333         * CONTRIBUTE: Replace contribution list with wiki link.
14334
14335 2019-01-25  Tom Tromey  <tom@tromey.com>
14336
14337         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14338
14339 2019-01-25  Tom Tromey  <tom@tromey.com>
14340
14341         * xtensa-linux-nat.c: Fix common/ includes.
14342         * xml-support.h: Fix common/ includes.
14343         * xml-support.c: Fix common/ includes.
14344         * x86-linux-nat.c: Fix common/ includes.
14345         * windows-nat.c: Fix common/ includes.
14346         * varobj.h: Fix common/ includes.
14347         * varobj.c: Fix common/ includes.
14348         * value.c: Fix common/ includes.
14349         * valops.c: Fix common/ includes.
14350         * utils.c: Fix common/ includes.
14351         * unittests/xml-utils-selftests.c: Fix common/ includes.
14352         * unittests/utils-selftests.c: Fix common/ includes.
14353         * unittests/unpack-selftests.c: Fix common/ includes.
14354         * unittests/tracepoint-selftests.c: Fix common/ includes.
14355         * unittests/style-selftests.c: Fix common/ includes.
14356         * unittests/string_view-selftests.c: Fix common/ includes.
14357         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14358         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14359         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14360         * unittests/rsp-low-selftests.c: Fix common/ includes.
14361         * unittests/parse-connection-spec-selftests.c: Fix common/
14362         includes.
14363         * unittests/optional-selftests.c: Fix common/ includes.
14364         * unittests/offset-type-selftests.c: Fix common/ includes.
14365         * unittests/observable-selftests.c: Fix common/ includes.
14366         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14367         * unittests/memrange-selftests.c: Fix common/ includes.
14368         * unittests/memory-map-selftests.c: Fix common/ includes.
14369         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14370         * unittests/function-view-selftests.c: Fix common/ includes.
14371         * unittests/environ-selftests.c: Fix common/ includes.
14372         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14373         * unittests/common-utils-selftests.c: Fix common/ includes.
14374         * unittests/cli-utils-selftests.c: Fix common/ includes.
14375         * unittests/array-view-selftests.c: Fix common/ includes.
14376         * ui-file.c: Fix common/ includes.
14377         * tui/tui-io.c: Fix common/ includes.
14378         * tracepoint.h: Fix common/ includes.
14379         * tracepoint.c: Fix common/ includes.
14380         * tracefile-tfile.c: Fix common/ includes.
14381         * top.h: Fix common/ includes.
14382         * top.c: Fix common/ includes.
14383         * thread.c: Fix common/ includes.
14384         * target/waitstatus.h: Fix common/ includes.
14385         * target/waitstatus.c: Fix common/ includes.
14386         * target.h: Fix common/ includes.
14387         * target.c: Fix common/ includes.
14388         * target-memory.c: Fix common/ includes.
14389         * target-descriptions.c: Fix common/ includes.
14390         * symtab.h: Fix common/ includes.
14391         * symfile.c: Fix common/ includes.
14392         * stap-probe.c: Fix common/ includes.
14393         * spu-linux-nat.c: Fix common/ includes.
14394         * sparc-nat.c: Fix common/ includes.
14395         * source.c: Fix common/ includes.
14396         * solib.c: Fix common/ includes.
14397         * solib-target.c: Fix common/ includes.
14398         * ser-unix.c: Fix common/ includes.
14399         * ser-tcp.c: Fix common/ includes.
14400         * ser-pipe.c: Fix common/ includes.
14401         * ser-base.c: Fix common/ includes.
14402         * selftest-arch.c: Fix common/ includes.
14403         * s12z-tdep.c: Fix common/ includes.
14404         * rust-exp.y: Fix common/ includes.
14405         * rs6000-aix-tdep.c: Fix common/ includes.
14406         * riscv-tdep.c: Fix common/ includes.
14407         * remote.c: Fix common/ includes.
14408         * remote-notif.h: Fix common/ includes.
14409         * remote-fileio.h: Fix common/ includes.
14410         * remote-fileio.c: Fix common/ includes.
14411         * regcache.h: Fix common/ includes.
14412         * regcache.c: Fix common/ includes.
14413         * record-btrace.c: Fix common/ includes.
14414         * python/python.c: Fix common/ includes.
14415         * python/py-type.c: Fix common/ includes.
14416         * python/py-inferior.c: Fix common/ includes.
14417         * progspace.h: Fix common/ includes.
14418         * producer.c: Fix common/ includes.
14419         * procfs.c: Fix common/ includes.
14420         * proc-api.c: Fix common/ includes.
14421         * printcmd.c: Fix common/ includes.
14422         * ppc-linux-nat.c: Fix common/ includes.
14423         * parser-defs.h: Fix common/ includes.
14424         * osdata.c: Fix common/ includes.
14425         * obsd-nat.c: Fix common/ includes.
14426         * nat/x86-linux.c: Fix common/ includes.
14427         * nat/x86-linux-dregs.c: Fix common/ includes.
14428         * nat/x86-dregs.h: Fix common/ includes.
14429         * nat/x86-dregs.c: Fix common/ includes.
14430         * nat/ppc-linux.c: Fix common/ includes.
14431         * nat/mips-linux-watch.h: Fix common/ includes.
14432         * nat/mips-linux-watch.c: Fix common/ includes.
14433         * nat/linux-waitpid.c: Fix common/ includes.
14434         * nat/linux-ptrace.h: Fix common/ includes.
14435         * nat/linux-ptrace.c: Fix common/ includes.
14436         * nat/linux-procfs.c: Fix common/ includes.
14437         * nat/linux-personality.c: Fix common/ includes.
14438         * nat/linux-osdata.c: Fix common/ includes.
14439         * nat/linux-namespaces.c: Fix common/ includes.
14440         * nat/linux-btrace.h: Fix common/ includes.
14441         * nat/linux-btrace.c: Fix common/ includes.
14442         * nat/fork-inferior.c: Fix common/ includes.
14443         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14444         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14445         * nat/aarch64-linux.c: Fix common/ includes.
14446         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14447         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14448         * namespace.h: Fix common/ includes.
14449         * mips-linux-tdep.c: Fix common/ includes.
14450         * minsyms.c: Fix common/ includes.
14451         * mi/mi-parse.h: Fix common/ includes.
14452         * mi/mi-main.c: Fix common/ includes.
14453         * mi/mi-cmd-env.c: Fix common/ includes.
14454         * memrange.h: Fix common/ includes.
14455         * memattr.c: Fix common/ includes.
14456         * maint.h: Fix common/ includes.
14457         * maint.c: Fix common/ includes.
14458         * main.c: Fix common/ includes.
14459         * machoread.c: Fix common/ includes.
14460         * location.c: Fix common/ includes.
14461         * linux-thread-db.c: Fix common/ includes.
14462         * linux-nat.c: Fix common/ includes.
14463         * linux-fork.c: Fix common/ includes.
14464         * inline-frame.c: Fix common/ includes.
14465         * infrun.c: Fix common/ includes.
14466         * inflow.c: Fix common/ includes.
14467         * inferior.h: Fix common/ includes.
14468         * inferior.c: Fix common/ includes.
14469         * infcmd.c: Fix common/ includes.
14470         * inf-ptrace.c: Fix common/ includes.
14471         * inf-child.c: Fix common/ includes.
14472         * ia64-linux-nat.c: Fix common/ includes.
14473         * i387-tdep.c: Fix common/ includes.
14474         * i386-tdep.c: Fix common/ includes.
14475         * i386-linux-tdep.c: Fix common/ includes.
14476         * i386-linux-nat.c: Fix common/ includes.
14477         * i386-go32-tdep.c: Fix common/ includes.
14478         * i386-fbsd-tdep.c: Fix common/ includes.
14479         * i386-fbsd-nat.c: Fix common/ includes.
14480         * guile/scm-type.c: Fix common/ includes.
14481         * guile/guile.c: Fix common/ includes.
14482         * go32-nat.c: Fix common/ includes.
14483         * gnu-nat.c: Fix common/ includes.
14484         * gdbthread.h: Fix common/ includes.
14485         * gdbarch-selftests.c: Fix common/ includes.
14486         * gdb_usleep.c: Fix common/ includes.
14487         * gdb_select.h: Fix common/ includes.
14488         * gdb_bfd.c: Fix common/ includes.
14489         * gcore.c: Fix common/ includes.
14490         * fork-child.c: Fix common/ includes.
14491         * findvar.c: Fix common/ includes.
14492         * fbsd-nat.c: Fix common/ includes.
14493         * event-top.c: Fix common/ includes.
14494         * event-loop.c: Fix common/ includes.
14495         * dwarf2read.c: Fix common/ includes.
14496         * dwarf2loc.c: Fix common/ includes.
14497         * dwarf2-frame.c: Fix common/ includes.
14498         * dwarf-index-cache.c: Fix common/ includes.
14499         * dtrace-probe.c: Fix common/ includes.
14500         * disasm-selftests.c: Fix common/ includes.
14501         * defs.h: Fix common/ includes.
14502         * csky-tdep.c: Fix common/ includes.
14503         * cp-valprint.c: Fix common/ includes.
14504         * cp-support.h: Fix common/ includes.
14505         * cp-support.c: Fix common/ includes.
14506         * corelow.c: Fix common/ includes.
14507         * completer.h: Fix common/ includes.
14508         * completer.c: Fix common/ includes.
14509         * compile/compile.c: Fix common/ includes.
14510         * compile/compile-loc2c.c: Fix common/ includes.
14511         * compile/compile-cplus-types.c: Fix common/ includes.
14512         * compile/compile-cplus-symbols.c: Fix common/ includes.
14513         * command.h: Fix common/ includes.
14514         * cli/cli-dump.c: Fix common/ includes.
14515         * cli/cli-cmds.c: Fix common/ includes.
14516         * charset.c: Fix common/ includes.
14517         * build-id.c: Fix common/ includes.
14518         * btrace.h: Fix common/ includes.
14519         * btrace.c: Fix common/ includes.
14520         * breakpoint.h: Fix common/ includes.
14521         * breakpoint.c: Fix common/ includes.
14522         * ax.h:
14523         (enum agent_op): Fix common/ includes.
14524         * ax-general.c (struct aop_map): Fix common/ includes.
14525         * ax-gdb.c: Fix common/ includes.
14526         * auxv.c: Fix common/ includes.
14527         * auto-load.c: Fix common/ includes.
14528         * arm-tdep.c: Fix common/ includes.
14529         * arch/riscv.c: Fix common/ includes.
14530         * arch/ppc-linux-common.c: Fix common/ includes.
14531         * arch/i386.c: Fix common/ includes.
14532         * arch/arm.c: Fix common/ includes.
14533         * arch/arm-linux.c: Fix common/ includes.
14534         * arch/arm-get-next-pcs.c: Fix common/ includes.
14535         * arch/amd64.c: Fix common/ includes.
14536         * arch/aarch64.c: Fix common/ includes.
14537         * arch/aarch64-insn.c: Fix common/ includes.
14538         * arch-utils.c: Fix common/ includes.
14539         * amd64-windows-tdep.c: Fix common/ includes.
14540         * amd64-tdep.c: Fix common/ includes.
14541         * amd64-sol2-tdep.c: Fix common/ includes.
14542         * amd64-obsd-tdep.c: Fix common/ includes.
14543         * amd64-nbsd-tdep.c: Fix common/ includes.
14544         * amd64-linux-tdep.c: Fix common/ includes.
14545         * amd64-linux-nat.c: Fix common/ includes.
14546         * amd64-fbsd-tdep.c: Fix common/ includes.
14547         * amd64-fbsd-nat.c: Fix common/ includes.
14548         * amd64-dicos-tdep.c: Fix common/ includes.
14549         * amd64-darwin-tdep.c: Fix common/ includes.
14550         * agent.c: Fix common/ includes.
14551         * ada-lang.h: Fix common/ includes.
14552         * ada-lang.c: Fix common/ includes.
14553         * aarch64-tdep.c: Fix common/ includes.
14554
14555 2019-01-25  Tom Tromey  <tom@tromey.com>
14556
14557         * common/create-version.sh: Use common/version.h.
14558
14559 2019-01-24  Pedro Alves  <palves@redhat.com>
14560
14561         * infrun.c (signal_stop, signal_print, signal_program)
14562         (signal_catch, signal_pass): Now arrays instead of pointers.
14563         (update_signals_program_target, do_target_resume)
14564         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14565         * linux-nat.c (linux_nat_target::pass_signals)
14566         (linux_nat_target::create_inferior, linux_nat_target::attach):
14567         Adjust.
14568         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14569         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14570         * procfs.c (procfs_target::pass_signals): Adjust.
14571         * record-full.c (record_full_target::resume): Adjust.
14572         * remote.c (remote_target::pass_signals)
14573         (remote_target::program_signals): Adjust.
14574         * target-debug.h (target_debug_print_signals): Now takes a
14575         gdb::array_view as parameter.  Adjust.
14576         * target.h (target_ops) <pass_signals, program_signals>: Replace
14577         pointer and length parameters with gdb::array_view.
14578         (target_pass_signals, target_program_signals): Likewise.
14579         * target-delegates.c: Regenerate.
14580
14581 2019-01-24  Pedro Alves  <palves@redhat.com>
14582
14583         * common/forward-scope-exit.h
14584         (forward_scope_exit::forward_scope_exit): Pass arguments to
14585         m_bind_function directly, instead of creating a std::bind and
14586         copying that.
14587
14588 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14589
14590         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14591         for static members.
14592         (pass_in_v_vfp_candidate): Likewise.
14593
14594 2019-01-23  Tom Tromey  <tom@tromey.com>
14595             Pedro Alves  <palves@redhat.com>
14596
14597         * regcache.c (class regcache_invalidator): Remove.
14598         (regcache::raw_write): Use make_scope_exit.
14599
14600 2019-01-23  Tom Tromey  <tom@tromey.com>
14601
14602         * ui-out.h (class ui_out_emit_type): Update comment.
14603
14604 2019-01-23  Tom Tromey  <tom@tromey.com>
14605
14606         * infrun.c (fetch_inferior_event): Update comment.
14607
14608 2019-01-23  Tom Tromey  <tom@tromey.com>
14609             Pedro Alves  <palves@redhat.com>
14610
14611         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14612         parameter.
14613         (fetch_inferior_event): Use SCOPE_EXIT.
14614
14615
14616 2019-01-23  Tom Tromey  <tom@tromey.com>
14617             Pedro Alves  <palves@redhat.com>
14618
14619         * infrun.c (disable_thread_events): Delete.
14620         (stop_all_threads): Use SCOPE_EXIT.
14621
14622 2019-01-23  Tom Tromey  <tom@tromey.com>
14623             Pedro Alves  <palves@redhat.com>
14624
14625         * symfile.c: Include forward-scope-exit.h.
14626         (clear_symtab_users_cleanup): Replace forward declaration with
14627         a FORWARD_SCOPE_EXIT.
14628         (syms_from_objfile_1): Use the forward_scope_exit and
14629         gdb::optional instead of cleanup_function.
14630         (reread_symbols): Use the forward_scope_exit instead of
14631         cleanup_function.
14632         (clear_symtab_users_cleanup): Remove function.
14633
14634 2019-01-23  Tom Tromey  <tom@tromey.com>
14635             Pedro Alves  <palves@redhat.com>
14636
14637         * linux-nat.c: Include scope-exit.h.
14638         (cleanup_target_stop): Remove.
14639         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14640         SCOPE_EXIT.
14641
14642 2019-01-23  Tom Tromey  <tom@tromey.com>
14643             Pedro Alves  <palves@redhat.com>
14644
14645         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14646         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14647
14648 2019-01-23  Tom Tromey  <tom@tromey.com>
14649             Andrew Burgess  <andrew.burgess@embecosm.com>
14650             Pedro Alves  <palves@redhat.com>
14651
14652         * infrun.c (fetch_inferior_event): Use scope_exit.
14653         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14654         * top.c (execute_command): Use scope_exit.
14655         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14656         * utils.c (do_bpstat_clear_actions_cleanup)
14657         (make_bpstat_clear_actions_cleanup): Remove.
14658
14659 2019-01-23  Tom Tromey  <tom@tromey.com>
14660             Pedro Alves  <palves@redhat.com>
14661
14662         * infrun.c: Include "common/scope-exit.h"
14663         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14664         (wait_for_inferior): Use SCOPE_EXIT.
14665         (fetch_inferior_event): Use scope_exit.
14666
14667 2019-01-23  Tom Tromey  <tom@tromey.com>
14668             Pedro Alves  <palves@redhat.com>
14669
14670         * breakpoint.c (create_breakpoint): Remove cleanup.
14671
14672 2019-01-23  Tom Tromey  <tom@tromey.com>
14673             Andrew Burgess  <andrew.burgess@embecosm.com>
14674             Pedro Alves  <palves@redhat.com>
14675
14676 2019-01-23  Pedro Alves  <palves@redhat.com>
14677
14678         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14679
14680 2019-01-23  Pedro Alves  <palves@redhat.com>
14681             Andrew Burgess  <andrew.burgess@embecosm.com>
14682
14683         * gdbthread.h: Include "common/forward-scope-exit.h".
14684         (scoped_finish_thread_state): Redefine custom class in terms of
14685         forward_scope_exit.
14686
14687 2019-01-23  Pedro Alves  <palves@redhat.com>
14688             Andrew Burgess  <andrew.burgess@embecosm.com>
14689
14690         * common/forward-scope-exit.h: New file.
14691
14692 2019-01-23  Pedro Alves  <palves@redhat.com>
14693             Andrew Burgess  <andrew.burgess@embecosm.com>
14694             Tom Tromey  <tom@tromey.com>
14695
14696         * common/scope-exit.h: New file.
14697
14698 2019-01-23  Pedro Alves  <palves@redhat.com>
14699
14700         * common/preprocessor.h (ESC): Rename to ...
14701         (ESC_PARENS): ... this.
14702         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14703         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14704
14705 2019-01-23  Tom Tromey  <tom@tromey.com>
14706
14707         * language.h (class scoped_switch_to_sym_language_if_auto):
14708         Initialize m_lang in both cases.
14709
14710 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14711
14712         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14713         with XCNEW.
14714
14715 2019-01-22  Tom Tromey  <tom@tromey.com>
14716
14717         * corelow.c: Do not include sys/file.h.
14718
14719 2019-01-22  Tom Tromey  <tom@tromey.com>
14720
14721         * tui/tui-wingeneral.h: Include gdb_curses.h.
14722
14723 2019-01-22  Tom Tromey  <tom@tromey.com>
14724
14725         * source-cache.h (class source_cache) <get_source_lines,
14726         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14727
14728 2019-01-22  Tom Tromey  <tom@tromey.com>
14729
14730         * remote-fileio.h (struct remote_target): Declare.
14731
14732 2019-01-22  Tom Tromey  <tom@tromey.com>
14733
14734         * python/py-arch.c: Do not include py-ref.h.
14735         * python/py-bpevent.c: Do not include py-ref.h.
14736         * python/py-cmd.c: Do not include py-ref.h.
14737         * python/py-continueevent.c: Do not include py-ref.h.
14738         * python/py-event.h: Do not include py-ref.h.
14739         * python/py-evtregistry.c: Do not include py-ref.h.
14740         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14741         * python/py-frame.c: Do not include py-ref.h.
14742         * python/py-framefilter.c: Do not include py-ref.h.
14743         * python/py-function.c: Do not include py-ref.h.
14744         * python/py-infevents.c: Do not include py-ref.h.
14745         * python/py-linetable.c: Do not include py-ref.h.
14746         * python/py-objfile.c: Do not include py-ref.h.
14747         * python/py-param.c: Do not include py-ref.h.
14748         * python/py-prettyprint.c: Do not include py-ref.h.
14749         * python/py-progspace.c: Do not include py-ref.h.
14750         * python/py-symbol.c: Do not include py-ref.h.
14751         * python/py-symtab.c: Do not include py-ref.h.
14752         * python/py-type.c: Do not include py-ref.h.
14753         * python/py-unwind.c: Do not include py-ref.h.
14754         * python/py-utils.c: Do not include py-ref.h.
14755         * python/py-value.c: Do not include py-ref.h.
14756         * python/py-varobj.c: Do not include py-ref.h.
14757         * python/py-xmethods.c: Do not include py-ref.h.
14758         * python/python.c: Do not include py-ref.h.
14759         * varobj.c: Do not include py-ref.h.
14760
14761 2019-01-22  Tom Tromey  <tom@tromey.com>
14762
14763         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14764         keyword for bcache.
14765
14766 2019-01-22  Tom Tromey  <tom@tromey.com>
14767
14768         * compile/compile-cplus-types.c: Remove a comment by #include.
14769
14770 2019-01-22  Tom Tromey  <tom@tromey.com>
14771
14772         * compile/gcc-c-plugin.h: Include compile-internal.h.
14773
14774 2019-01-22  Tom Tromey  <tom@tromey.com>
14775
14776         * stabsread.c (EXTERN): Do not define.
14777         (symnum, next_symbol_text_func, processing_gcc_compilation)
14778         (within_function, global_sym_chain, global_stabs)
14779         (previous_stab_code, this_object_header_files)
14780         (n_this_object_header_files)
14781         (n_allocated_this_object_header_files): Define.
14782         * stabsread.h (EXTERN): Never define.  Use "extern".
14783
14784 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14785
14786         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14787         history_value.
14788
14789 2019-01-21  Tom Tromey  <tom@tromey.com>
14790
14791         * ui-out.c: Fix includes.
14792         * tui/tui-source.c: Fix includes.
14793         * target.c: Fix includes.
14794         * remote.c: Fix includes.
14795         * regcache.c: Fix includes.
14796         * python/py-block.c: Fix includes.
14797         * printcmd.c: Fix includes.
14798         * or1k-tdep.c: Fix includes.
14799         * mi/mi-main.c: Fix includes.
14800         * m32r-tdep.c: Fix includes.
14801         * csky-tdep.c: Fix includes.
14802         * compile/compile-cplus-types.c: Fix includes.
14803         * cli/cli-interp.c: Fix includes.
14804
14805 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14806
14807         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14808         for padding.
14809
14810 2019-01-16  Tom Tromey  <tom@tromey.com>
14811
14812         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14813         earlier.
14814         (struct objfile) <msymbols_range>: Move from top level.
14815         <msymbols>: New method.
14816         (class objfile_msymbols): Remove.
14817         * symtab.c (default_collect_symbol_completion_matches_break_on):
14818         Update.
14819         * symmisc.c (dump_msymbols): Update.
14820         * stabsread.c (scan_file_globals): Update.
14821         * objc-lang.c (info_selectors_command, info_classes_command)
14822         (find_methods): Update.
14823         * minsyms.c (find_solib_trampoline_target): Update.
14824         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14825         * coffread.c (coff_symfile_read): Update.
14826         * ada-lang.c (ada_lookup_simple_minsym)
14827         (ada_collect_symbol_completion_matches): Update.
14828
14829 2019-01-16  Tom Tromey  <tom@tromey.com>
14830
14831         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14832         type.  Remove no-argument constructor.
14833         <iterator::operator++>: Simplify.
14834         <begin>: Update.
14835         <end>: Use minimal_symbol_count.
14836
14837 2019-01-16  Tom Tromey  <tom@tromey.com>
14838
14839         * objfiles.h (struct objfile) <psymtabs>: New method.
14840         (class objfile_psymtabs): Remove.
14841         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14842         typedef.
14843         <range>: New method.
14844         (require_partial_symbols): Change return type.
14845         * psymtab.c (require_partial_symbols)
14846         (psym_expand_symtabs_matching): Update.
14847         * mdebugread.c (parse_partial_symbols): Update.
14848         * dbxread.c (dbx_end_psymtab): Update.
14849
14850 2019-01-15  Tom Tromey  <tom@tromey.com>
14851
14852         * symtab.c (lookup_objfile_from_block)
14853         (lookup_symbol_in_objfile_symtabs)
14854         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14855         (find_line_symtab, info_sources_command)
14856         (default_collect_symbol_completion_matches_break_on)
14857         (make_source_files_completion_list): Update.
14858         * symmisc.c (print_objfile_statistics, dump_objfile)
14859         (maintenance_print_symbols, maintenance_info_symtabs)
14860         (maintenance_check_symtabs, maintenance_info_line_tables):
14861         Update.
14862         * source.c (select_source_symtab)
14863         (forget_cached_source_info_for_objfile): Update.
14864         * objfiles.h (class objfile_compunits): Remove.
14865         (struct objfile) <compunits_range>: New typedef.
14866         (compunits): New method.
14867         * objfiles.c (objfile_relocate1): Update.
14868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14869         * maint.c (count_symtabs_and_blocks): Update.
14870         * linespec.c (iterate_over_all_matching_symtabs): Update.
14871         * cp-support.c (add_symbol_overload_list_qualified): Update.
14872         * coffread.c (coff_symtab_read): Update.
14873         * ada-lang.c (add_nonlocal_symbols)
14874         (ada_collect_symbol_completion_matches)
14875         (ada_add_global_exceptions): Update.
14876
14877 2019-01-15  Tom Tromey  <tom@tromey.com>
14878
14879         * progspace.h (program_space) <objfiles_safe_range>: New
14880         typedef.
14881         <objfiles_safe>: New method.
14882         * objfiles.h (class all_objfiles_safe): Remove.
14883         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14884         * jit.c (jit_inferior_exit_hook): Update.
14885
14886 2019-01-17  Tom Tromey  <tom@tromey.com>
14887
14888         * progspace.h (program_space) <objfiles_range>: New typedef.
14889         <objfiles>: New method.
14890         <objfiles_head>: Rename from objfiles.
14891         (object_files): Update.
14892         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14893         * guile/scm-pretty-print.c
14894         (ppscm_find_pretty_printer_from_objfiles): Update.
14895         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14896         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14897         Update.
14898         * python/py-progspace.c (pspy_get_objfiles): Update.
14899         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14900         Update.
14901         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14902         (objfpy_lookup_objfile_by_build_id): Update.
14903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14904         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14905         Update.
14906         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14907         (expand_symtab_containing_pc, lookup_objfile_from_block)
14908         (lookup_static_symbol, basic_lookup_transparent_type)
14909         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14910         (find_line_symtab, info_sources_command)
14911         (default_collect_symbol_completion_matches_break_on)
14912         (make_source_files_completion_list, find_main_name): Update.
14913         * symmisc.c (print_symbol_bcache_statistics)
14914         (print_objfile_statistics, maintenance_print_symbols)
14915         (maintenance_print_msymbols, maintenance_print_objfiles)
14916         (maintenance_info_symtabs, maintenance_check_symtabs)
14917         (maintenance_expand_symtabs, maintenance_info_line_tables):
14918         Update.
14919         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14920         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14921         (map_overlay_command, unmap_overlay_command)
14922         (simple_overlay_update, expand_symtabs_matching)
14923         (map_symbol_filenames): Update.
14924         * symfile-debug.c (set_debug_symfile): Update.
14925         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14926         Update.
14927         * source.c (select_source_symtab, forget_cached_source_info):
14928         Update.
14929         * solib.c (solib_read_symbols): Update.
14930         * solib-spu.c (append_ocl_sos): Update.
14931         * psymtab.c (maintenance_print_psymbols)
14932         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14933         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14934         * printcmd.c (info_symbol_command): Update.
14935         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14936         Update.
14937         * objfiles.h (class all_objfiles): Remove.
14938         * objfiles.c (have_partial_symbols, have_full_symbols)
14939         (have_minimal_symbols, qsort_cmp, update_section_map)
14940         (shared_objfile_contains_address_p)
14941         (default_iterate_over_objfiles_in_search_order): Update.
14942         * objc-lang.c (info_selectors_command, info_classes_command)
14943         (find_methods): Update.
14944         * minsyms.c (find_solib_trampoline_target): Update.
14945         * maint.c (maintenance_info_sections)
14946         (maintenance_translate_address, count_symtabs_and_blocks):
14947         Update.
14948         * main.c (captured_main_1): Update.
14949         * linux-thread-db.c (try_thread_db_load_from_pdir)
14950         (has_libpthread): Update.
14951         * linespec.c (iterate_over_all_matching_symtabs)
14952         (search_minsyms_for_name): Update.
14953         * jit.c (jit_find_objf_with_entry_addr): Update.
14954         * hppa-tdep.c (find_unwind_entry)
14955         (hppa_lookup_stub_minimal_symbol): Update.
14956         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14957         Update.
14958         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14959         (elf_gnu_ifunc_resolve_by_got): Update.
14960         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14961         * dwarf-index-write.c (save_gdb_index_command): Update.
14962         * cp-support.c (add_symbol_overload_list_qualified): Update.
14963         * breakpoint.c (create_overlay_event_breakpoint)
14964         (create_longjmp_master_breakpoint)
14965         (create_std_terminate_master_breakpoint)
14966         (create_exception_master_breakpoint): Update.
14967         * blockframe.c (find_pc_partial_function): Update.
14968         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14969         (ada_collect_symbol_completion_matches)
14970         (ada_add_global_exceptions): Update.
14971
14972 2019-01-17  Tom Tromey  <tom@tromey.com>
14973
14974         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14975         declare VEC.
14976         (solib_target_parse_libraries): Change return type.
14977         (library_list_start_segment, library_list_start_section)
14978         (library_list_end_library, library_list_start_library); Update.
14979         (solib_target_free_library_list): Remove.
14980         (solib_target_parse_libraries): Remove cleanup.  Change return
14981         type.
14982         (solib_target_current_sos): Update.
14983
14984 2019-01-17  Tom Tromey  <tromey@bapiya>
14985
14986         * valprint.c: Replace "the the" with "the".
14987         * symtab.c: Replace "the the" with "the".
14988         * solib.c: Replace "the the" with "the".
14989         * solib-dsbt.c: Replace "the the" with "the".
14990         * linespec.c: Replace "the the" with "the".
14991         * dwarf2loc.h: Replace "the the" with "the".
14992         * amd64-windows-tdep.c: Replace "the the" with "the".
14993         * aarch64-tdep.c: Replace "the the" with "the".
14994
14995 2019-01-16  Keith Seitz  <keiths@redhat.com>
14996
14997         PR gdb/23773
14998         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14999         <builder>: Rename to ..
15000         <m_builder>: ... this and make private.
15001         (dwarf2_cu::get_builder): New method.  Change all users of
15002         `builder' to use this method.
15003         (dwarf2_start_symtab): Move to ...
15004         (dwarf2_cu::start_symtab): ... here.  Update all callers
15005         (setup_type_unit_groups): Move to ...
15006         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15007         callers.
15008         (dwarf2_cu::reset_builder): New method.
15009         (process_full_compunit, process_full_type_unit): Use
15010         dwarf2_cu::reset_builder.
15011         (follow_die_offset): Record the ancestor CU if it is different
15012         from the followed DIE's CU.
15013         (follow_die_sig_1): Likewise.
15014
15015 2019-01-15  Tom Tromey  <tom@tromey.com>
15016
15017         * remote.c (class remote_state) <buf>: Now a char_vector.
15018         <buf_size>: Remove.
15019         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15020         parameter.
15021         (remote_target::getpkt_or_notif_sane_1)
15022         (remote_target::getpkt_sane)
15023         (remote_target::getpkt_or_notif_sane): Likewise.
15024         (class remote_target) <putpkt>: New overload.
15025         (remote_target::read_frame): Change type of "buf_p".  Remove
15026         sizeof_p parameter.
15027         (packet_ok): New overload.
15028         (packet_check_result): New overload.
15029         Update all uses.
15030
15031 2019-01-14  Tom Tromey  <tom@tromey.com>
15032
15033         * remote-notif.c (handle_notification, remote_notif_ack)
15034         (remote_notif_parse): Make "buf" const.
15035         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15036         const.
15037         (remote_notif_parse, remote_notif_ack, handle_notification):
15038         Likewise.
15039         * remote.c (remote_notif_stop_parse): Make "buf" const.
15040         (remote_target::remote_parse_stop_reply): Make "buf" const.
15041         (remote_notif_stop_ack): Make "buf" const.
15042
15043 2019-01-14  Tom Tromey  <tom@tromey.com>
15044
15045         * remote.c (remote_console_output): Make parameter const.
15046
15047 2019-01-14  Tom Tromey  <tom@tromey.com>
15048
15049         * target-debug.h (target_debug_print_signals): Constify.
15050         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15051         * procfs.c (procfs_target::pass_signals): Update.
15052         * linux-nat.c (linux_nat_target::pass_signals): Update.
15053         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15054         * target-delegates.c: Rebuild.
15055         * remote.c (remote_target::program_signals): Update.
15056         (remote_target::pass_signals): Update.
15057         * target.c (target_pass_signals): Constify argument.
15058         (target_program_signals): Likewise.
15059         * target.h (struct target_ops) <pass_signals, program_signals>:
15060         Constify argument.
15061         (target_pass_signals, target_program_signals): Constify argument.
15062
15063 2019-01-14  Tom Tromey  <tom@tromey.com>
15064
15065         PR tui/28819:
15066         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15067
15068 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15069
15070         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15071         field.
15072         * rs6000-tdep.c: Include reggroups.h.
15073         (IS_V_ALIAS_PSEUDOREG): Define.
15074         (rs6000_register_name): Return names for the "vX" aliases.
15075         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15076         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15077         aliases.  Call default_register_reggroup_p for all other
15078         pseudo-registers.
15079         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15080         New functions.
15081         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15082         Handle "vX" aliases.
15083         (v_alias_pseudo_register_collect): New function.
15084         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15085         (rs6000_gdbarch_init): Initialize "vX" aliases as
15086         pseudo-registers.  Restore registration of
15087         rs6000_pseudo_register_reggroup_p with
15088         set_tdesc_pseudo_register_reggroup_p.
15089
15090 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15091
15092         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15093         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15094         set_gdbarch_num_pseudo_regs.
15095
15096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15097
15098         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15099         Remove arg prefixname, add do_set and do_show.
15100         Add member functions set_list and show_list.
15101         * cli/cli-style.c (class cli_style_option): Update accordingly.
15102         (style_set_list): Move to file scope.
15103         (style_show_list): Likewise.
15104         (set_style): Call help_list.
15105         (show_style): Call cmd_show_list.
15106         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15107         Update to use the new macro.
15108
15109 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15110
15111         * ada-lang.c (_initialize_ada_language): Expand the help text
15112         for the "catch exception" command.
15113
15114 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15115
15116         * symtab.c (matching_obj_sections): Initialize obj,
15117         declare it closer to its usage.
15118
15119 2019-01-10  Tom Tromey  <tom@tromey.com>
15120
15121         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15122         (basic_inf_threads_range): Remove.
15123         (inf_threads_range, inf_non_exited_threads_range)
15124         (safe_inf_threads_range): Use next_adapter.
15125
15126 2019-01-10  Keith Seitz  <keiths@redhat.com>
15127
15128         PR gdb/23712
15129         PR symtab/23010
15130         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15131         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15132
15133 2019-01-10  Keith Seitz  <keiths@redhat.com>
15134
15135         PR gdb/23712
15136         PR symtab/23010
15137         * dictionary.c (pending_to_vector): Remove.
15138         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15139         Remove _1 suffix, replacing functions of the same name.  Update
15140         all callers.
15141         (dict_create_hashed, dict_create_hashed_expandable)
15142         (dict_create_linear, dict_create_linear_expandable, dict_free)
15143         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15144         Make functions static.
15145
15146 2019-01-10  Keith Seitz  <keiths@redhat.com>
15147
15148         PR gdb/23712
15149         PR symtab/23010
15150         * dictionary.h (struct dictionary): Replace declaration with
15151         multidictionary.
15152         (dict_create_hashed, dict_create_hashed_expandable)
15153         (dict_create_linear, dict_create_linear_expandable)
15154         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15155         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15156         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15157         taking multidictionary argument.
15158         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15159         * block.h (struct block) <dict>: Change to multidictionary
15160         and rename `multidict'.
15161         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15162         symmisc.c: Update all dictionary references to multidictionary.
15163
15164 2019-01-10  Keith Seitz  <keiths@redhat.com>
15165
15166         PR gdb/23712
15167         PR symtab/23010
15168         * dictionary.c: Include unordered_map.
15169         (pending_to_vector): New function.
15170         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15171         Rewrite the non-"_1" functions to take vector instead
15172         of linked list.
15173         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15174         "new" _1 versions of the same name.
15175         (multidictionary): Define.
15176         (std::hash<enum language): New definition.
15177         (collate_pending_symbols_by_language, mdict_create_hashed)
15178         (mdict_create_hashed_expandable, mdict_create_linear)
15179         (mdict_create_linear_expandable, mdict_free)
15180         (find_language_dictionary, create_new_language_dictionary)
15181         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15182         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15183         (mdict_size, mdict_empty): New functions.
15184         * dictionary.h (mdict_iterator): Define.
15185
15186 2019-01-10  Pedro Alves  <palves@redhat.com>
15187
15188         * breakpoint.c (read_uploaded_action)
15189         (create_tracepoint_from_upload): Adjust to use
15190         gdb::unique_xmalloc_ptr.
15191         * ctf.c (ctf_write_uploaded_tp):
15192         (SET_ARRAY_FIELD): Use emplace_back.
15193         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15194         * tracefile-tfile.c (tfile_write_uploaded_tp):
15195         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15196         gdb::unique_xmalloc_ptr.
15197         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15198         at_string, cond_string, cmd_strings>: Replace char pointers
15199         with gdb::unique_xmalloc_ptr.
15200
15201 2019-01-10  Pedro Alves  <palves@redhat.com>
15202
15203         * solib-target.c (library_list_start_library): Don't xstrdup name.
15204
15205 2019-01-10  Pedro Alves  <palves@redhat.com>
15206
15207         * mdebugread.c (parse_partial_symbols): Use
15208         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15209
15210 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15211
15212         * linux-fork.c (scoped_switch_fork_info)
15213         <~scoped_switch_fork_info>: Fix incorrect variable name.
15214
15215 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15216
15217         * linux-fork.c (scoped_switch_fork_info)
15218         <scoped_switch_fork_info>: Make explicit.
15219         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15220
15221 2019-01-10  Tom Tromey  <tom@tromey.com>
15222
15223         * objfiles.h (objfile::reset_psymtabs): Update.
15224         * objfiles.c (objfile::objfile): Update.
15225         * psymtab.h (psymtab_storage::obstack): Update.
15226         (psymtab_storage::m_obstack): Use gdb::optional.
15227         (class psymtab_storage): Update comment.  Remove objfile
15228         parameter.
15229         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15230
15231 2019-01-10  Tom Tromey  <tom@tromey.com>
15232
15233         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15234         <free_psymtabs>: Now private.
15235         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15236         (allocate_psymtab): Use new method.
15237
15238 2019-01-10  Tom Tromey  <tom@tromey.com>
15239
15240         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15241         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15242         * mdebugread.c (parse_partial_symbols): Use
15243         allocate_dependencies.
15244         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15245         allocate_dependencies.
15246         (process_psymtab_comp_unit_reader)
15247         (build_type_psymtab_dependencies): Likewise.
15248         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15249
15250 2019-01-10  Tom Tromey  <tom@tromey.com>
15251
15252         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15253         PSYMBOL_SET_LANGUAGE.
15254         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15255
15256 2019-01-10  Tom Tromey  <tom@tromey.com>
15257
15258         * psymtab.h (psymtab_storage::obstack): New method.
15259         <m_obstack>: Rename from obstack; now private.
15260         * psymtab.c (psymtab_storage): Update.
15261         * dwarf2read.c (create_addrmap_from_index)
15262         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15263         Update.
15264
15265 2019-01-10  Tom Tromey  <tom@tromey.com>
15266
15267         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15268         * objfiles.h (objfile::reset_psymtabs): New method.
15269
15270 2019-01-10  Tom Tromey  <tom@tromey.com>
15271
15272         * symmisc.c (print_symbol_bcache_statistics): Update.
15273         (print_objfile_statistics): Update.
15274         * symfile.c (reread_symbols): Update.
15275         * psymtab.h (class psymtab_storage): New.
15276         * psymtab.c (psymtab_storage): New constructor.
15277         (~psymtab_storage): New destructor.
15278         (require_partial_symbols): Update.
15279         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15280         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15281         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15282         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15283         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15284         (start_psymtab_common, end_psymtab_common)
15285         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15286         (allocate_psymtab): Update.
15287         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15288         Update.
15289         (dump_psymtab_addrmap, maintenance_print_psymbols)
15290         (maintenance_check_psymtabs): Update.
15291         (class objfile_psymtabs): Move to objfiles.h.
15292         * psympriv.h (discard_psymtab): Now inline.
15293         (psymtab_discarder::psymtab_discarder): Update.
15294         (psymtab_discarder::~psymtab_discarder): Update.
15295         (ALL_OBJFILE_PSYMTABS): Rewrite.
15296         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15297         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15298         Remove fields.
15299         <partial_symtabs>: New field.
15300         (class objfile_psymtabs): Move from psymtab.h.  Update.
15301         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15302         psymbol_cache.
15303         (objfile::~objfile): Don't destroy psymbol_cache.
15304         * mdebugread.c (parse_partial_symbols): Update.
15305         * dwarf2read.c (create_addrmap_from_index)
15306         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15307         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15308         (add_partial_subprogram, dwarf2_ranges_read): Update.
15309         * dwarf-index-write.c (write_address_map)
15310         (write_one_signatured_type, recursively_write_psymbols)
15311         (class debug_names, class debug_names, write_psymtabs_to_index):
15312         Update.
15313
15314 2019-01-10  Tom Tromey  <tom@tromey.com>
15315
15316         * symtab.h (SYMBOL_SET_NAMES): Update.
15317         (symbol_set_names): Update.
15318         (MSYMBOL_SET_NAMES): Update.
15319         * symtab.c (symbol_set_names): Change argument to be an
15320         objfile_per_bfd_storage.
15321         * psymtab.c (add_psymbol_to_bcache): Update.
15322         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15323
15324 2019-01-10  Tom Tromey  <tom@tromey.com>
15325
15326         * symtab.c (create_demangled_names_hash): Change argument to be an
15327         objfile_per_bfd_storage.
15328         (symbol_set_names): Update.
15329
15330 2019-01-10  Tom Tromey  <tom@tromey.com>
15331
15332         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15333         init_psymbol_list.
15334         * psymtab.c (init_psymbol_list): Do nothing if already called.
15335         * psympriv.h (init_psymbol_list): Add comment.
15336         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15337         init_psymbol_list.
15338         * dbxread.c (dbx_symfile_read): Unconditionally call
15339         init_psymbol_list.
15340
15341 2019-01-10  Tom Tromey  <tom@tromey.com>
15342
15343         * xcoffread.c (scan_xcoff_symtab): Update.
15344         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15345         "where".
15346         * mdebugread.c (parse_partial_symbols)
15347         (handle_psymbol_enumerators): Update.
15348         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15349         * dbxread.c (read_dbx_symtab): Update.
15350         * psympriv.h (psymbol_placement): New enum.
15351         (add_psymbol_to_list): Update.
15352
15353 2019-01-10  Tom Tromey  <tom@tromey.com>
15354
15355         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15356         static_psymbols parameters.
15357         (scan_xcoff_symtab): Update.
15358         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15359         static_psymbols parameters.
15360         * psympriv.h (start_psymtab_common): Update.
15361         * mdebugread.c (parse_partial_symbols): Update.
15362         * dwarf2read.c (create_partial_symtab): Update.
15363         * dbxread.c (read_dbx_symtab): Update.
15364         (start_psymtab): Remove global_psymbols and static_psymbols
15365         parameters.
15366
15367 2019-01-10  Tom Tromey  <tom@tromey.com>
15368
15369         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15370         * psymtab.c (allocate_psymtab): Add comment.
15371         * psympriv.h (allocate_psymtab): Add comment.
15372         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15373         initializations.
15374         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15375
15376 2019-01-10  Tom Tromey  <tom@tromey.com>
15377
15378         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15379         Don't declare.
15380         * mipsread.c: Include mdebugread.h.
15381         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15382         Declare.
15383         * elfread.c: Include mdebugread.h.
15384
15385 2019-01-09  Tom Tromey  <tom@tromey.com>
15386
15387         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15388         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15389         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15390         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15391         (psym_lookup_symbol, psym_find_last_source_symtab)
15392         (psym_forget_cached_source_info, psym_print_stats)
15393         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15394         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15395         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15396         (psym_find_compunit_symtab_by_address)
15397         (maintenance_print_psymbols, maintenance_info_psymtabs)
15398         (maintenance_check_psymtabs): Use ranged for.
15399         * psymtab.h (class objfile_psymtabs): New.
15400         (require_partial_symbols): Return objfile_psymtabs.
15401         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15402
15403 2019-01-09  Tom Tromey  <tom@tromey.com>
15404
15405         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15406         (find_pc_mapped_section, list_overlays_command)
15407         (map_overlay_command, unmap_overlay_command)
15408         (simple_overlay_update): Use all_objfiles.
15409         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15410         * printcmd.c (info_symbol_command): Use all_objfiles.
15411         * objfiles.h (ALL_OBJSECTIONS): Remove.
15412         * maint.c (maintenance_translate_address): Use all_objfiles.
15413         * gcore.c (gcore_create_callback): Use all_objfiles.
15414         (objfile_find_memory_regions): Likewise.
15415
15416 2019-01-09  Tom Tromey  <tom@tromey.com>
15417
15418         * symtab.c (find_line_symtab, info_sources_command)
15419         (make_source_files_completion_list): Use objfile_compunits.
15420         * source.c (select_source_symtab): Use objfile_compunits.
15421         * objfiles.h (struct objfile): Update comment.
15422         (ALL_OBJFILES): Remove.
15423         (ALL_FILETABS): Remove.
15424         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15425         objfile_compunits.
15426
15427 2019-01-09  Tom Tromey  <tom@tromey.com>
15428
15429         * symmisc.c (print_objfile_statistics, dump_objfile)
15430         (maintenance_print_symbols): Use compunit_filetabs.
15431         * source.c (forget_cached_source_info_for_objfile): Use
15432         compunit_filetabs.
15433         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15434         (ALL_FILETABS): Use compunit_filetabs.
15435         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15436         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15437
15438 2019-01-09  Tom Tromey  <tom@tromey.com>
15439
15440         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15441         (compunit_filetabs): New.
15442         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15443         compunit_filetabs.
15444         (info_sources_command, make_source_files_completion_list): Remove
15445         declaration.
15446         * symmisc.c (print_objfile_statistics, dump_objfile)
15447         (maintenance_print_symbols): Remove declaration.
15448         (maintenance_info_symtabs): Use compunit_filetabs.
15449         (maintenance_info_line_tables): Likewise.
15450         * source.c (select_source_symtab): Change local variable name.
15451         (forget_cached_source_info_for_objfile): Remove declaration.
15452         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15453         * objfiles.c (objfile_relocate1): Remove declaration.
15454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15455         declaration.
15456         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15457         * coffread.c (coff_symtab_read): Remove declaration.
15458         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15459         compunit_filetabs.
15460
15461 2019-01-09  Tom Tromey  <tom@tromey.com>
15462
15463         * symtab.c (lookup_objfile_from_block)
15464         (find_pc_sect_compunit_symtab, search_symbols)
15465         (default_collect_symbol_completion_matches_break_on): Use
15466         objfile_compunits.
15467         * objfiles.h (ALL_COMPUNITS): Remove.
15468         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15469         * cp-support.c (add_symbol_overload_list_qualified): Use
15470         objfile_compunits.
15471         * ada-lang.c (ada_collect_symbol_completion_matches)
15472         (ada_add_global_exceptions): Use objfile_compunits.
15473
15474 2019-01-09  Tom Tromey  <tom@tromey.com>
15475
15476         * source.c (select_source_symtab)
15477         (forget_cached_source_info_for_objfile): Remove declaration.
15478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15479         declaration.
15480         * maint.c (count_symtabs_and_blocks): Remove declaration.
15481         * cp-support.c (add_symbol_overload_list_qualified): Remove
15482         declaration.
15483         * coffread.c (coff_symtab_read): Remove declaration.
15484         * symtab.c (lookup_symbol_in_objfile_symtabs)
15485         (basic_lookup_transparent_type_1): Use objfile_compunits.
15486         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15487         (info_sources_command, search_symbols)
15488         (default_collect_symbol_completion_matches_break_on)
15489         (make_source_files_completion_list): Remove declaration.
15490         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15491         (ada_collect_symbol_completion_matches)
15492         (ada_add_global_exceptions): Remove declaration.
15493         * linespec.c (iterate_over_all_matching_symtabs): Use
15494         objfile_compunits.
15495         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15496         (class objfile_compunits): New.
15497         (ALL_COMPUNITS): Use objfile_compunits.
15498         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15499         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15500         objfile_compunits.
15501         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15502
15503 2019-01-09  Tom Tromey  <tom@tromey.com>
15504
15505         * symtab.c (search_symbols)
15506         (default_collect_symbol_completion_matches_break_on): Use
15507         objfile_msymbols.
15508         * ada-lang.c (ada_lookup_simple_minsym)
15509         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15510         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15511         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15512         objfile_msymbols.
15513         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15514         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15515         * objc-lang.c (find_methods): Use objfile_msymbols.
15516         (info_selectors_command, info_classes_command): Likewise.
15517         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15518         * objfiles.h (class objfile_msymbols): New.
15519         (ALL_OBJFILE_MSYMBOLS): Remove.
15520         (ALL_MSYMBOLS): Remove.
15521
15522 2019-01-09  Tom Tromey  <tom@tromey.com>
15523
15524         * common/next-iterator.h (next_adapter): Add Iterator template
15525         parameter.
15526         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15527         (class all_objfiles_safe): New.
15528         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15529         * objfiles.c (put_objfile_before): Update comment.
15530         (add_separate_debug_objfile): Likewise.
15531         (free_all_objfiles): Use all_objfiles_safe.
15532         (objfile_purge_solibs): Likewise.
15533
15534 2019-01-09  Tom Tromey  <tom@tromey.com>
15535
15536         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15537         (expand_symtab_containing_pc, lookup_static_symbol)
15538         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15539         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15540         all_objfiles.
15541         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15542         * breakpoint.c (create_overlay_event_breakpoint)
15543         (create_longjmp_master_breakpoint)
15544         (create_std_terminate_master_breakpoint)
15545         (create_exception_master_breakpoint): Use all_objfiles.
15546         * linux-thread-db.c (try_thread_db_load_from_pdir)
15547         (has_libpthread): Use all_objfiles.
15548         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15549         * linespec.c (iterate_over_all_matching_symtabs)
15550         (search_minsyms_for_name): Use all_objfiles.
15551         * maint.c (maintenance_info_sections): Use all_objfiles.
15552         * main.c (captured_main_1): Use all_objfiles.
15553         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15554         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15555         * guile/scm-pretty-print.c
15556         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15557         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15558         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15559         (maintenance_print_msymbols): Use all_objfiles.
15560         * source.c (select_source_symtab): Use all_objfiles.
15561         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15562         * symfile.c (remove_symbol_file_command)
15563         (expand_symtabs_matching, map_symbol_filenames): Use
15564         all_objfiles.
15565         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15566         all_objfiles.
15567         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15568         * objc-lang.c (find_methods): Use all_objfiles.
15569         * objfiles.c (have_partial_symbols, have_full_symbols)
15570         (have_minimal_symbols, qsort_cmp)
15571         (default_iterate_over_objfiles_in_search_order): Use
15572         all_objfiles.
15573         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15574         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15575         (maintenance_check_psymtabs): Use all_objfiles.
15576         (ALL_PSYMTABS): Remove.
15577         * compile/compile-object-run.c (do_module_cleanup): Use
15578         all_objfiles.
15579         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15580         * cp-support.c (add_symbol_overload_list_qualified): Use
15581         all_objfiles.
15582         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15583         Use all_objfiles.
15584         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15585         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15586         all_objfiles.
15587         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15588         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15589         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15590         Uses all_objfiles.
15591         * solib.c (solib_read_symbols): Use all_objfiles
15592
15593 2019-01-09  Tom Tromey  <tom@tromey.com>
15594
15595         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15596         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15597         all_objfiles.
15598         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15599         * symmisc.c (print_symbol_bcache_statistics)
15600         (print_objfile_statistics, maintenance_print_objfiles)
15601         (maintenance_info_symtabs, maintenance_check_symtabs)
15602         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15603         all_objfiles.
15604         * source.c (forget_cached_source_info): Use all_objfiles.
15605         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15606         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15607         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15608         * objfiles.c (update_section_map): Use all_objfiles.
15609         (shared_objfile_contains_address_p): Likewise.
15610         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15611         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15612
15613 2019-01-09  Tom Tromey  <tom@tromey.com>
15614
15615         * common/next-iterator.h: New file.
15616         * objfiles.h (class all_objfiles): New.
15617         (struct objfile_iterator): New.
15618
15619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15620
15621         * NEWS: Move the description of the changed "frame", "select-frame",
15622          and "info frame" commands to the Changed commands section.
15623
15624 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15625
15626         * gdbtypes.c (check_stub_method_group): Remove handling of old
15627         mangling schemes.
15628         * linespec.c (find_methods): Likewise.
15629         * stabsread.c (read_member_functions): Likewise.
15630         * valops.c (search_struct_method): Likewise.
15631         (value_struct_elt_for_reference): Likewise.
15632         * NEWS: Mention this change.
15633
15634 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15635
15636         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15637         print_source_lines.
15638         * source.c (print_source_lines_base): Update line number check.
15639         (print_source_lines): New function.
15640         (source_lines_range::source_lines_range): New function.
15641         * source.h (class source_lines_range): New class.
15642         (print_source_lines): New declaration.
15643
15644 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15645
15646         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15647
15648 2019-01-08  Tom Tromey  <tom@tromey.com>
15649             Simon Marchi  <simon.marchi@ericsson.com>
15650
15651         PR gdb/24060
15652         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15653         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15654         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15655         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15656         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15657         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15658
15659 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15660
15661         * source.c (select_source_symtab): Move header comment to
15662         declaration in source.h.
15663         (forget_cached_source_info_for_objfile): Likewise.
15664         (forget_cached_source_info): Likewise.
15665         (identify_source_line): Likewise.
15666         * source.h (identify_source_line): Move declaration from symtab.h
15667         and add comment from source.c
15668         (print_source_lines): Likewise.
15669         (forget_cached_source_info_for_objfile): Likewise.
15670         (forget_cached_source_info): Likewise.
15671         (select_source_symtab): Likewise.
15672         (enum print_source_lines_flag): Move definition from symtab.h.
15673         * symtab.h (identify_source_line): Move declaration to source.h.
15674         (print_source_lines): Likewise.
15675         (forget_cached_source_info_for_objfile): Likewise.
15676         (forget_cached_source_info): Likewise.
15677         (select_source_symtab): Likewise.
15678         (enum print_source_lines_flag): Move definition to source.h.
15679         * tui/tui-hooks.c: Add 'source.h' include.
15680
15681 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15682
15683         * source.c (print_source_lines_base): Handle requests to print
15684         reverse line number sequences, and guard against empty lines
15685         string.
15686
15687 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15688
15689         * source.c (print_source_lines_base): Fix skip of '\r' if next
15690         character is '\n'.
15691
15692 2019-01-06  Tom Tromey  <tom@tromey.com>
15693
15694         * c-exp.y (struct c_parse_state) <macro_original_text,
15695         expansion_obstack>: New member.
15696         (macro_original_text, expansion_obstack): Remove globals.
15697         (scan_macro_expansion, scanning_macro_expansion)
15698         (finished_macro_expansion): Update.
15699         (scan_macro_cleanup): Remove.
15700         (yylex, c_parse): Update.
15701
15702 2019-01-06  Tom Tromey  <tom@tromey.com>
15703
15704         * c-exp.y (struct c_parse_state) <strings>: New member.
15705         (operator_stoken): Update.
15706
15707 2019-01-06  Tom Tromey  <tom@tromey.com>
15708
15709         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15710         (union type_stack_elt) <typelist_val>: Now a pointer to
15711         std::vector.
15712         (type_stack_cleanup): Don't declare.
15713         (push_typelist): Update.
15714         * parse.c (pop_typelist): Return a std::vector.
15715         (push_typelist): Take a std::vector.
15716         (follow_types): Update.  Do not free args.
15717         (type_stack_cleanup): Remove.
15718         * c-exp.y (struct c_parse_state): New.
15719         (cpstate): New global.
15720         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15721         (nonempty_typelist): Update.
15722         (func_mod): Create a new vector.
15723         (c_parse): Create a c_parse_state.
15724         (check_parameter_typelist): Do not delete params.
15725         (function_method): Update.  Do not delete type_list.
15726
15727 2019-01-06  Tom Tromey  <tom@tromey.com>
15728
15729         PR gdb/28155:
15730         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15731         check_typedef.
15732         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15733         (print_return_value): Likewise.
15734
15735 2019-01-05  Tom Tromey  <tom@tromey.com>
15736
15737         * contrib/cleanup_check.py: Remove.
15738         * contrib/gcc-with-excheck: Remove.
15739         * contrib/exsummary.py: Remove.
15740         * contrib/excheck.py: Remove.
15741
15742 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15743
15744         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15745         NULL. Initialize tpprev to NULL instead of assigning it
15746         to NULL on the next statement.
15747         * windows-nat.c (windows_delete_thread): Remove check for
15748         main_thread_id before printing thread exit notifications.
15749         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15750         Remove thread ID check against main_thread_id.
15751         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15752         windows_delete_thread.
15753         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15754
15755 2019-01-04  Tom Tromey  <tom@tromey.com>
15756
15757         * compile/compile.c (_initialize_compile): Use upper case for
15758         metasyntactic variables.
15759         * symmisc.c (_initialize_symmisc): Use upper case for
15760         metasyntactic variables.
15761         * psymtab.c (_initialize_psymtab): Use upper case for
15762         metasyntactic variables.
15763         * demangle.c (demangle_command): Use upper case for metasyntactic
15764         variables.
15765         (_initialize_demangler): Likewise.
15766         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15767         variables.
15768
15769 2019-01-03  Tom Tromey  <tom@tromey.com>
15770
15771         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15772
15773 2019-01-03  Tom Tromey  <tom@tromey.com>
15774
15775         * python/py-symtab.c (salpy_str): Update.
15776         (struct salpy_sal_object) <symtab>: Now a PyObject.
15777         (salpy_dealloc): Update.
15778         (del_objfile_sal): Use gdbpy_ref.
15779
15780 2019-01-03  Tom Tromey  <tom@tromey.com>
15781
15782         * python/py-type.c (convert_field): Use new_reference.  Return
15783         gdbpy_ref.
15784         (make_fielditem): Return gdbpy_ref.
15785         (typy_fields): Update.
15786         (typy_getitem): Update.
15787         (field_name): Return gdbpy_ref.  Use new_reference.
15788         (typy_iterator_iternext): Update.
15789
15790 2019-01-03  Tom Tromey  <tom@tromey.com>
15791
15792         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15793
15794 2019-01-03  Tom Tromey  <tom@tromey.com>
15795
15796         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15797         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15798         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15799         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15800         (pspy_set_type_printers): Likewise.
15801         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15802         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15803         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15804         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15805         (objfpy_set_type_printers): Likewise.
15806
15807 2019-01-03  Tom Tromey  <tom@tromey.com>
15808
15809         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15810         (gdbpy_print_stack): Use gdbpy_err_fetch.
15811         * python/python-internal.h (class gdbpy_err_fetch): New class.
15812         (class gdbpy_enter) <m_error_type, m_error_value,
15813         m_error_traceback>: Remove.
15814         <m_error>: New member.
15815         (gdbpy_exception_to_string): Don't declare.
15816         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15817         * python/py-value.c (convert_value_from_python): Use
15818         gdbpy_err_fetch.
15819         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15820         gdbpy_exception_to_string.
15821         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15822         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15823         gdbpy_err_fetch.
15824
15825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15826
15827         * linux-nat.c (delete_lwp_cleanup): Delete.
15828         (struct lwp_deleter): New struct.
15829         (lwp_info_up): New typedef.
15830         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15831         lwp_info_up.
15832
15833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15834
15835         * linux-fork.c (class scoped_switch_fork_info): New class.
15836         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15837
15838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15839
15840         * valops.c (find_overload_match): Remove use of null_cleanup, and
15841         calls to do_cleanups.
15842
15843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15844
15845         * compile/compile-cplus-types.c
15846         (compile_cplus_instance::decl_name): Handle changes to
15847         cp_func_name.
15848         * cp-support.c (cp_func_name): Update header comment, update
15849         return type.
15850         * cp-support.h (cp_func_name): Update return type in declaration.
15851         * valops.c (find_overload_match): Move temp_func local to top
15852         level of function and change its type.  Use temp_func to hold and
15853         delete temporary string obtained from cp_func_name.
15854
15855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15856
15857         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15858         gdb::char_vector, remove cleanup, and update uses of `msg`.
15859
15860 2019-01-03  Jim Wilson  <jimw@sifive.com>
15861
15862         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15863
15864 2019-01-02  Tom Tromey  <tom@tromey.com>
15865
15866         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15867         (tdesc_parse_xml): Remove cleanups.
15868         * target-descriptions.h (make_cleanup_free_target_description):
15869         Don't declare.
15870         (target_desc_deleter): New struct.
15871         (target_desc_up): New typedef.
15872         * target-descriptions.c (target_desc_deleter::operator()): Rename
15873         from free_target_description.
15874         (make_cleanup_free_target_description): Remove.
15875
15876 2019-01-02  Tom Tromey  <tom@tromey.com>
15877
15878         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15879         constructor, destructor.
15880         (linespec_parser): Remove typedef.
15881         (~linespec_parser): Rename from linespec_parser_delete.
15882         (linespec_lex_to_end, linespec_complete_label)
15883         (linespec_complete): Update.
15884         (decode_line_full): Remove cleanups.
15885         (decode_line_1): Update.
15886
15887 2019-01-02  Tom Tromey  <tom@tromey.com>
15888
15889         * python/python-internal.h (inferior_to_inferior_object): Change
15890         return type.
15891         * python/py-exitedevent.c (create_exited_event_object): Update.
15892         * python/py-inferior.c (inferior_to_inferior_object): Return
15893         gdbpy_ref.
15894         (python_new_inferior, python_inferior_deleted)
15895         (thread_to_thread_object, delete_thread_object)
15896         (build_inferior_list, gdbpy_selected_inferior): Update.
15897         * python/py-infthread.c (create_thread_object): Update.  Also fail
15898         if inferior_to_inferior_object fails.
15899
15900 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15901
15902         * inferior.h (class inferior) <displaced_step_state>: New field.
15903         * infrun.h (struct displaced_step_state): Move here from
15904         infrun.c.  Initialize fields, add constructor.
15905         <inf>: Remove field.
15906         <reset>: New method.
15907         * infrun.c (struct displaced_step_inferior_state): Move to
15908         infrun.h.
15909         (displaced_step_inferior_states): Remove.
15910         (get_displaced_stepping_state): Adust.
15911         (displaced_step_in_progress_any_inferior): Adjust.
15912         (displaced_step_in_progress_thread): Adjust.
15913         (displaced_step_in_progress): Adjust.
15914         (add_displaced_stepping_state): Remove.
15915         (get_displaced_step_closure_by_addr): Adjust.
15916         (remove_displaced_stepping_state): Remove.
15917         (infrun_inferior_exit): Call displaced_step_state.reset.
15918         (use_displaced_stepping): Don't check for NULL.
15919         (displaced_step_prepare_throw): Call
15920         get_displaced_stepping_state.
15921         (displaced_step_fixup): Don't check for NULL.
15922         (prepare_for_detach): Don't check for NULL.
15923
15924 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15925
15926         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15927          in case of call that did not complete.
15928
15929 2019-01-02  Andrey Utkin  <autkin@undo.io>
15930
15931         * symfile.c (find_separate_debug_file): Fix search of debug files for
15932         remote debuggee.
15933
15934 2019-01-02  Tom Tromey  <tom@tromey.com>
15935
15936         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15937         indentation.
15938         * python/py-frame.c (frapy_older): Remove cast.
15939         (frapy_newer): Likewise.
15940         * python/py-breakpoint.c (local_setattro): Remove cast.
15941         * python/py-arch.c (archpy_name): Remove local variable.
15942         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15943
15944 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15945
15946         * unittests/basic_string_view/element_access/char/empty.cc:
15947         Fix year range in copyright header.
15948
15949 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15950
15951         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15952         Delete.
15953         <operator==>: Update with for removed field.
15954         <hash>: Likewise.
15955         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15956         <isa_features>: ...this.
15957         <abi_features>: New field.
15958         (riscv_isa_flen): Update comment.
15959         (riscv_abi_xlen): New declaration.
15960         (riscv_abi_flen): New declaration.
15961         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15962         isa_features.
15963         (riscv_abi_xlen): New function.
15964         (riscv_isa_flen): Update to get answer from isa_features.
15965         (riscv_abi_flen): New function.
15966         (riscv_has_fp_abi): Update to get answer from abi_features.
15967         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15968         xlen and flen.
15969         (riscv_call_info) <xlen, flen>: Update comment.
15970         (riscv_call_arg_struct): Remove invalid assertions
15971         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15972         is removed.
15973         (riscv_gdbarch_init): Gather isa features and abi features
15974         separately, ensure both match on the gdbarch when reusing an old
15975         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15976         a target with 64-bit float hardware.
15977
15978 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15979
15980         * source.c (search_command_helper): Stop reverse search
15981         when line 1 has been searched.
15982
15983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15984
15985         * record-full.c (record_full_base_target::close): Rewrite
15986         record_full_core_buf_list free logic.
15987
15988 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15989
15990         * break-catch-syscall.c (print_one_catch_syscall): xfree
15991         the last text.
15992
15993 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15994
15995         * top.c (print_gdb_version): Update Copyright year in version
15996         message.
15997
15998 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15999
16000         Update copyright year range in all GDB files.
16001
16002 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16003
16004         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16005
16006 For older changes see ChangeLog-2018.
16007 \f
16008 Local Variables:
16009 mode: change-log
16010 left-margin: 8
16011 fill-column: 74
16012 version-control: never
16013 coding: utf-8
16014 End:
16015