gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
   4         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
   9         type.
  10         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  11         protected.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.c
  16         (tui_source_window_base::set_is_exec_point_at): Add check against
  17         LOA_ADDRESS.
  18
  19 2019-06-25  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-source.c (tui_set_source_content): Don't check before
  22         xfree.
  23         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  24
  25 2019-06-25  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-winsource.h (tui_update_source_window_as_is)
  28         (tui_alloc_source_buffer, tui_line_is_displayed)
  29         (tui_addr_is_displayed): Change type of win_info.
  30         * tui/tui-winsource.c (tui_update_source_window_as_is)
  31         (tui_clear_source_content, tui_show_source_line)
  32         (tui_show_source_content, tui_source_window_base::refill)
  33         (tui_source_window_base::set_is_exec_point_at)
  34         (tui_source_window_base::set_is_exec_point_at)
  35         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  36         (tui_alloc_source_buffer, tui_line_is_displayed)
  37         (tui_addr_is_displayed): Change type of win_info.  Update.
  38         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  39         (tui_source_window_base::do_make_visible_with_new_height):
  40         Update.
  41         * tui/tui-source.c (tui_set_source_content)
  42         (tui_set_source_content_nil)
  43         (tui_source_window::do_scroll_vertical): Update.
  44         * tui/tui-layout.c (show_layout): Update.
  45         * tui/tui-disasm.c (tui_set_disassem_content)
  46         (tui_disasm_window::do_scroll_vertical): Update.
  47         * tui/tui-data.h (tui_win_content): Remove.
  48         (struct tui_gen_win_info) <content, content_size>: Remove.
  49         (struct tui_source_element): Add initializers and destructor.
  50         (union tui_which_element, struct tui_win_element): Remove.
  51         (struct tui_source_window_base) <content>: New field.
  52         (struct tui_data_window): Remove destructor.
  53         (tui_alloc_content, tui_free_win_content)
  54         (tui_free_all_source_wins_content): Don't declare.
  55         * tui/tui-data.c (tui_initialize_static_data): Update.
  56         (init_content_element, tui_alloc_content): Remove.
  57         (~tui_gen_win_info): Update.
  58         (~tui_data_window, tui_free_all_source_wins_content)
  59         (tui_free_win_content, free_content, free_content_elements):
  60         Remove.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-winsource.h (tui_clear_source_content)
  65         (tui_erase_source_content, tui_show_source_content): Change type
  66         of win_info.
  67         * tui/tui-winsource.c (tui_clear_source_content)
  68         (tui_erase_source_content, tui_show_source_content): Change type
  69         of win_info.
  70         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  71         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  72         win_info.
  73         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  74         win_info.
  75         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  76
  77 2019-06-25  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c (tui_clear_source_content)
  80         (tui_source_window_base::set_is_exec_point_at): Update.
  81         * tui/tui-source.c (tui_set_source_content_nil): Update.
  82         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  83         a bool.
  84         * tui/tui-data.c (init_content_element): Update.
  85
  86 2019-06-25  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  89         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  90         * tui/tui-layout.c (init_and_make_win): Update.
  91         * tui/tui.h (enum tui_win_type): Update.
  92         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  93         tui_win_is_auxillary.
  94         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  95         tui_win_is_auxillary.
  96
  97 2019-06-25  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 100         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 101         (tui_delete_data_content_windows, tui_display_all_data)
 102         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 103         Update.
 104         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 105         * tui/tui-regs.c (tui_last_regs_line_no)
 106         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 107         (tui_show_registers): Update.
 108         (tui_show_register_group): Return void.  Update.
 109         (tui_display_registers_from, tui_display_reg_element_at_line)
 110         (tui_display_registers_from_line, tui_check_register_values):
 111         Update.
 112         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 113         member.
 114         (struct tui_data_window) <regs_content>: Now a std::vector.
 115         <regs_content_count>: Remove.
 116         (tui_add_content_elements, tui_free_data_content): Don't declare.
 117         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 118         (init_content_element): Remove DATA_WIN case.  Add assert.
 119         (tui_add_content_elements): Remove.
 120         (tui_data_window): Update.
 121         (tui_free_data_content): Remove.
 122         (free_content_elements): Remove DATA_WIN case.
 123
 124 2019-06-25  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-data.c (tui_data_item_window): Update.
 127         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 128         * tui/tui-windata.c (tui_display_all_data)
 129         (tui_display_data_from_line): Update.
 130         (tui_check_data_values): Remove.
 131         * tui/tui-regs.c (tui_show_register_group)
 132         (tui_display_reg_element_at_line): Update.
 133         * tui/tui-hooks.c (tui_register_changed)
 134         (tui_refresh_frame_and_register_information): Call
 135         tui_check_register_values.
 136         * tui/tui-data.h (struct tui_data_window) <data_content,
 137         data_content_count, data_type>: Remove.
 138         (enum tui_data_type): Remove.
 139
 140         * tui/tui-data.c (tui_data_window::clear_detail)
 141         (~tui_data_window): Update.
 142
 143 2019-06-25  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 146         declare.
 147         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 148         Rename from tui_first_data_item_displayed.  Update.
 149         (tui_data_window::refresh_all)
 150         (tui_data_window::do_scroll_vertical): Update.
 151         * tui/tui-data.h (struct tui_data_window)
 152         <first_data_item_displayed>: Declare new method.
 153
 154 2019-06-25  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 157         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 158         contents...
 159         (tui_initialize_static_data): ...here.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 164         (tui_display_registers_from, tui_check_register_values): Update.
 165         (tui_display_register): Remove win_info parameter; update.
 166         (tui_get_register): Change type of parameters.
 167         * tui/tui-data.h (struct tui_data_element): Remove.
 168         (union tui_which_element) <data>: Remove.
 169         <data_window>: Change type.
 170         (struct tui_data_item_window): New.
 171         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 172         case.  Add assert.
 173         (~tui_data_item_window): New destructor.
 174         (free_content_elements): Remove DATA_ITEM_WIN case.
 175
 176 2019-06-25  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 179         Remove.
 180
 181 2019-06-25  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-data.h (struct tui_command_element): Remove.
 184         (union tui_which_element) <command>: Remove.
 185         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 186         assert.
 187         (free_content_elements): Remove CMD_WIN case.
 188
 189 2019-06-25  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-layout.c (tui_set_layout): Update.
 192         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 193         * tui/tui-data.c (layout_def): Update.
 194
 195 2019-06-25  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 198         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 199         (tui_source_window_base::set_new_height): Update.
 200         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 201         Update.
 202         (tui_set_locator_fullname, tui_set_locator_info)
 203         (tui_show_frame_info): Update.
 204         * tui/tui-source.c (tui_set_source_content)
 205         (tui_source_is_displayed): Update.
 206         * tui/tui-layout.c (show_source_disasm_command, show_data)
 207         (show_source_or_disasm_and_command): Update.
 208         * tui/tui-disasm.c (tui_set_disassem_content)
 209         (tui_get_begin_asm_address): Update.
 210         * tui/tui-data.h (struct tui_locator_element): Remove.
 211         (union tui_which_element) <locator>: Remove.
 212         (struct tui_locator_window): New.
 213         (tui_locator_win_info_ptr): Change return type.
 214         * tui/tui-data.c (_locator): Change type.
 215         (tui_locator_win_info_ptr): Change return type.
 216         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 217         (tui_alloc_content): Add assert.
 218
 219 2019-06-25  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-winsource.c
 222         (tui_exec_info_window::maybe_allocate_content): New method.
 223         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 224         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 225         (make_source_or_disasm_window): Add cast.
 226         * tui/tui-data.h (union tui_which_element) <simple_string>:
 227         Remove.
 228         (struct tui_source_info): New.
 229         (struct tui_source_window_base) <execution_info>: Change type.
 230         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 231         case, and add assert.
 232         (tui_alloc_content): Add assert.
 233
 234 2019-06-25  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 237         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 238         * tui/tui-data.c (tui_alloc_win_info): Remove.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 243         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 244         can_highlight.
 245
 246 2019-06-25  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 249         make_visible_with_new_height method.
 250         (tui_win_info::make_visible_with_new_height): New method.
 251         (tui_source_window_base::do_make_visible_with_new_height)
 252         (tui_data_window::do_make_visible_with_new_height)
 253         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 254         (make_visible_with_new_height): Remove.
 255         (tui_resize_all, tui_adjust_win_heights): Use
 256         make_visible_with_new_height method.
 257         * tui/tui-data.h (struct tui_win_info)
 258         <do_make_visible_with_new_height, make_visible_with_new_height>:
 259         New methods.
 260         (struct tui_source_window_base, struct tui_data_window)
 261         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 262         methods.
 263
 264 2019-06-25  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 267         method.
 268         (update_tab_width): Call update_tab_width method.
 269         * tui/tui-data.h (struct tui_win_info)
 270         (struct tui_source_window_base) <update_tab_width>: New methods.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 275         parameter.
 276         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 277         parameter.
 278         (tui_gen_win_info::make_visible): Update.
 279         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 280         parameter.
 281         * tui/tui-data.h (enum tui_box): New enum.
 282         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 283
 284 2019-06-25  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 287         init_and_make_win for EXEC_INFO_WIN.
 288         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 289         longer inline.
 290         (struct tui_win_info) <~tui_win_info>: Inline.
 291         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 292         Don't declare.
 293         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 294         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 295         Remove.
 296         (tui_initialize_static_data): Update.
 297         (~tui_gen_win_info): Handle more cleanup here.
 298         (~tui_source_window_base): Delete "execution_info".
 299         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 300
 301 2019-06-25  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-layout.c (make_command_window): Don't set
 304         can_highlight.
 305         (show_source_disasm_command): Call the reset method.
 306         (show_data): Don't set can_highlight.  Call the reset method.
 307         (tui_gen_win_info::reset): Rename from init_gen_win_info
 308         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 309         (show_source_or_disasm_and_command): Call the reset method.
 310         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 311         (struct tui_cmd_window): Set can_highlight.
 312
 313 2019-06-25  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 316         from make_visible.
 317         (tui_make_visible, tui_make_invisible): Rewrite.
 318         (tui_win_info::make_visible): Remove.
 319         (tui_source_window_base::make_visible): Update.
 320         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 321         method.  Moved from...
 322         (struct tui_win_info) <make_visible>: ...here.
 323
 324 2019-06-25  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-winsource.c
 327         (tui_source_window_base::do_scroll_horizontal): Remove direction
 328         parameter.
 329         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 330         direction parameter.
 331         * tui/tui-win.c (tui_win_info::forward_scroll)
 332         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 333         (tui_win_info::right_scroll): Update.
 334         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 335         direction parameter.
 336         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 337         direction parameter.
 338         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 339         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 340         Remove direction parameter.
 341         (struct tui_source_window_base, struct tui_source_window)
 342         (struct tui_disasm_window, struct tui_data_window)
 343         (struct tui_cmd_window): Update.
 344
 345 2019-06-25  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.h (tui_set_exec_info_content)
 348         (tui_show_exec_info_content, tui_erase_exec_info_content)
 349         (tui_clear_exec_info_content, tui_update_exec_info): Change
 350         argument to tui_source_window_base.
 351         * tui/tui-winsource.c (tui_set_exec_info_content)
 352         (tui_show_exec_info_content, tui_erase_exec_info_content)
 353         (tui_clear_exec_info_content, tui_update_exec_info): Change
 354         argument to tui_source_window_base.
 355
 356 2019-06-25  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 359         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 364         check.
 365
 366 2019-06-25  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 369         type to void.
 370         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 371         type to void.
 372         * tui/tui-source.c (tui_set_source_content): Update.
 373         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 374
 375 2019-06-25  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-win.c (window_name_completer, tui_set_focus)
 378         (tui_all_windows_info): Use name method.
 379         * tui/tui-data.h (struct tui_gen_win_info)
 380         (struct tui_source_window, struct tui_disasm_window)
 381         (struct tui_data_window, struct tui_cmd_window) <name>: New
 382         method.
 383         (tui_win_name): Don't declare.
 384         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 385         (tui_win_name): Remove.
 386
 387 2019-06-25  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-winsource.h (tui_update_source_window)
 390         (tui_update_source_window_as_is): Change parameter type.
 391         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 392         to be a tui_source_window_base.
 393         (tui_update_source_window_as_is): Likewise.
 394         * tui/tui-win.c (make_visible_with_new_height): Update.
 395
 396 2019-06-25  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.c (tui_erase_source_content)
 399         (tui_show_source_content, tui_show_exec_info_content)
 400         (tui_erase_exec_info_content): Use refresh_window method.
 401         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 402         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 403         from tui_refresh_win.
 404         (tui_data_window::refresh_window): New method.
 405         (tui_win_info::refresh, tui_source_window_base::refresh)
 406         (tui_refresh_all): Use refresh_window method.
 407         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 408         method.
 409         * tui/tui-regs.c (tui_display_register): Call refresh_window
 410         method.
 411         * tui/tui-layout.c (show_source_disasm_command)
 412         (show_source_or_disasm_and_command): Call refresh_window method.
 413         * tui/tui-data.h (struct tui_gen_win_info)
 414         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 415         New method.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui.c (tui_rl_other_window, tui_enable)
 420         (tui_is_window_visible, tui_get_command_dimension): Update.
 421         * tui/tui-winsource.c (tui_update_source_window_as_is)
 422         (tui_clear_source_content, tui_erase_source_content)
 423         (tui_show_source_line, tui_source_window_base::refill)
 424         (tui_source_window_base::do_scroll_horizontal)
 425         (tui_source_window_base::set_is_exec_point_at)
 426         (tui_update_breakpoint_info, tui_set_exec_info_content)
 427         (tui_alloc_source_buffer, tui_line_is_displayed)
 428         (tui_addr_is_displayed): Update.
 429         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 430         (tui_check_and_display_highlight_if_needed)
 431         (tui_win_info::make_visible, tui_win_info::refresh)
 432         (tui_refresh_all): Update.
 433         * tui/tui-windata.c (tui_first_data_item_displayed)
 434         (tui_delete_data_content_windows, tui_erase_data_content)
 435         (tui_display_all_data, tui_data_window::refresh_all)
 436         (tui_check_data_values): Update.
 437         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 438         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 439         (tui_win_info::backward_scroll, tui_refresh_all_win)
 440         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 441         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 442         (tui_source_window_base::set_new_height)
 443         (tui_data_window::set_new_height)
 444         (make_invisible_and_set_new_height)
 445         (make_visible_with_new_height, new_height_ok)
 446         (parse_scrolling_args): Update.
 447         * tui/tui-stack.c (tui_show_frame_info): Update.
 448         * tui/tui-source.c (tui_set_source_content)
 449         (tui_set_source_content_nil, tui_source_is_displayed)
 450         (tui_source_window::do_scroll_vertical): Update.
 451         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 452         (tui_display_registers_from, tui_display_reg_element_at_line)
 453         (tui_check_register_values, tui_reg_command): Update.
 454         * tui/tui-layout.c (tui_default_win_height)
 455         (show_source_disasm_command, show_data, init_and_make_win)
 456         (show_source_or_disasm_and_command): Update.
 457         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 458         (tui_redisplay_readline, tui_mld_flush)
 459         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 460         (tui_getc): Update.
 461         * tui/tui-disasm.c (tui_set_disassem_content)
 462         (tui_disasm_window::do_scroll_vertical): Update.
 463         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 464         Now virtual.
 465         (struct tui_win_info): Derive from tui_gen_win_info.
 466         <~tui_win_info>: Mark as override.
 467         <generic>: Remove member.
 468         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 469         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 470         (~tui_data_window, ~tui_win_info)
 471         (tui_free_all_source_wins_content): Update.
 472         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 473
 474 2019-06-25  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-layout.c (init_and_make_win): Use new.
 477         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 478         destructor, initializers.
 479         (tui_alloc_generic_win_info): Don't declare.
 480         * tui/tui-data.c (_locator): Add argument to constructor.
 481         (source_win, disasm_win): New globals.
 482         (exec_info): Remove.
 483         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 484         Update.
 485         (tui_alloc_generic_win_info): Remove.
 486         (init_content_element): Use new.
 487         (tui_win_info::tui_win_info): Update.
 488         (free_content_elements) <case DATA_WIN>: Use delete.
 489
 490 2019-06-25  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 493         * tui/tui-windata.c (tui_first_data_item_displayed)
 494         (tui_delete_data_content_windows): Update.
 495         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 496         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 497         (tui_display_registers_from, tui_check_register_values): Update.
 498         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 499         pointer.
 500         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 501         window.
 502         (tui_free_data_content): Update.
 503         (free_content_elements) <case DATA_WIN>: Free the window.
 504
 505 2019-06-25  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 508         Update.
 509         * tui/tui-layout.c (make_command_window)
 510         (show_source_disasm_command, show_data, init_and_make_win)
 511         (show_source_or_disasm_and_command): Update.
 512         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 513         method.
 514         <can_highight, is_highlighted>: Now bool.
 515         (tui_set_win_highlight): Don't declare.
 516         * tui/tui-data.c (tui_set_win_highlight): Remove.
 517
 518 2019-06-25  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-wingeneral.c (make_visible): Remove check of window
 521         type.
 522
 523 2019-06-25  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-win.c (tui_win_info::max_height)
 526         (tui_cmd_window::max_height): New methods.
 527         (new_height_ok): Call max_height.
 528         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 529         <max_height>: New method.
 530
 531 2019-06-25  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-win.c (tui_source_window_base::set_new_height)
 534         (tui_data_window::set_new_height): New methods.
 535         (make_invisible_and_set_new_height): Call set_new_height method.
 536         * tui/tui-data.h (struct tui_win_info)
 537         (struct tui_source_window_base, struct tui_data_window)
 538         <set_new_height>: New method.
 539
 540 2019-06-25  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 543         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 544         tui_refresh_data_win.
 545         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 546         method.
 547         (tui_refresh_all_win): Call the refresh_all method.
 548         (tui_set_focus): Likewise.
 549         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 550         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 551         Likewise.
 552
 553 2019-06-25  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-winsource.h (tui_refill_source_window)
 556         (tui_set_is_exec_point_at): Don't declare.
 557         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 558         (tui_source_window_base::refill): Rename from
 559         tui_refill_source_window.
 560         (tui_source_window_base::do_scroll_horizontal): Update.
 561         (tui_source_window_base::set_is_exec_point_at): Rename from
 562         tui_set_is_exec_point_at.
 563         (tui_update_all_breakpoint_info): Update.
 564         * tui/tui-stack.c (tui_show_frame_info): Update.
 565         * tui/tui-layout.c (show_data): Add cast.
 566         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 567         * tui/tui-data.h (struct tui_source_window_base) <refill,
 568         set_is_exec_point_at>: New methods.
 569         (tui_source_windows, tui_add_to_source_windows): Update types.
 570         (tui_add_to_source_windows): Remove redundant declaration.
 571         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 572         (tui_source_windows): Change return type.
 573         (tui_clear_source_windows_detail): Update.
 574         (tui_add_to_source_windows): Change type of parameter.
 575         (tui_free_all_source_wins_content): Update.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-wingeneral.c (tui_win_info::refresh)
 580         (tui_source_window_base::refresh): New methods.
 581         (tui_refresh_all): Call the refresh method.
 582         * tui/tui-data.h (struct tui_win_info)
 583         (struct tui_source_window_base) <refresh>: New method.
 584
 585 2019-06-25  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui.h (tui_is_window_visible): Return bool.
 588         * tui/tui.c (tui_is_window_visible): Return bool.
 589         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 590         (tui_make_visible, tui_make_invisible)
 591         (tui_win_info::make_visible)
 592         (tui_source_window_base::make_visible, make_all_visible)
 593         (tui_make_all_visible, tui_make_all_invisible): Update.
 594         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 595         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 596         bool.
 597         (struct tui_win_info, struct tui_source_window_base)
 598         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 599         * tui/tui-data.c (tui_init_generic_part): Update.
 600
 601 2019-06-25  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 604         (tui_source_window_base::make_visible): New methods.
 605         (make_all_visible): Make method call.
 606         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 607         (struct tui_source_window_base, struct tui_cmd_window): Override
 608         make_visible.
 609         (tui_win_is_source_type): Don't declare.
 610         * tui/tui-data.c (tui_win_is_source_type): Remove.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 615         NULL check.
 616
 617 2019-06-25  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 620         Inline constructor.  Add initializers for members.
 621         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 622         constructors; now inline in class.
 623
 624 2019-06-25  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-regs.c (tui_show_registers): Update.
 627         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 628         bool.
 629         * tui/tui-data.c (tui_data_window::clear_detail)
 630         (tui_data_window): Update.
 631
 632 2019-06-25  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-windata.c (tui_display_all_data)
 635         (tui_display_data_from_line, tui_display_data_from)
 636         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 637         Update.
 638         * tui/tui-regs.c (tui_last_regs_line_no)
 639         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 640         (tui_show_registers, tui_show_register_group)
 641         (tui_display_registers_from, tui_display_reg_element_at_line)
 642         (tui_display_registers_from_line, tui_check_register_values)
 643         (tui_reg_next, tui_reg_prev): Update.
 644         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 645         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 646         tui_data_window.
 647         (struct tui_win_info) <detail>: Remove.  Add new fields from
 648         tui_data_info.
 649         (TUI_DATA_WIN): Add cast.
 650         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 651         (~tui_data_window): Simplify.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-layout.c (show_source_disasm_command)
 656         (show_source_or_disasm_and_command): Update.
 657         * tui/tui-io.c (update_cmdwin_start_line)
 658         (tui_redisplay_readline): Update.
 659         * tui/tui-data.h (struct tui_command_info): Remove.
 660         (struct tui_win_info) <detail>: Remove command_info member.
 661         (struct tui_data_window) <start_line>: New member, from
 662         tui_command_info.
 663         (TUI_CMD_WIN): Add casts.
 664
 665 2019-06-25  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.c (tui_update_source_window)
 668         (tui_refill_source_window)
 669         (tui_source_window_base::do_scroll_horizontal)
 670         (tui_update_breakpoint_info, tui_set_exec_info_content)
 671         (tui_show_exec_info_content, tui_erase_exec_info_content)
 672         (tui_clear_exec_info_content): Update.
 673         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 674         Update.
 675         * tui/tui-win.c (make_invisible_and_set_new_height)
 676         (make_visible_with_new_height): Update.
 677         * tui/tui-source.c (tui_set_source_content)
 678         (tui_show_symtab_source): Update.
 679         * tui/tui-layout.c (extract_display_start_addr)
 680         (show_source_disasm_command, show_data)
 681         (make_source_or_disasm_window)
 682         (show_source_or_disasm_and_command): Update.
 683         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 684         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 685         "gdbarch".
 686         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 687         to tui_source_window_base.
 688         (struct tui_win_info) <detail>: Remove source_info member.
 689         (struct tui_source_window_base) <has_locator>: Inline.
 690         Move contents from tui_source_info; rename has_locator member to
 691         m_has_locator.
 692         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 693         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 694         header file.
 695         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 696         Simplify.
 697         (tui_free_all_source_wins_content): Cast to
 698         tui_source_window_base.
 699
 700 2019-06-25  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-win.c (make_invisible_and_set_new_height)
 703         (make_visible_with_new_height): Call has_locator method.
 704         * tui/tui-layout.c (show_source_disasm_command, show_data)
 705         (show_source_or_disasm_and_command): Update for bool change.
 706         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 707         (tui_win_info) <has_locator>: New method.
 708         (struct tui_source_window_base) <has_locator>: New method.
 709         (tui_win_has_locator): Don't declare.
 710         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 711         from tui_win_has_locator.
 712         (tui_source_window_base): Use false, not FALSE.
 713
 714 2019-06-25  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 717         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 718         clear_detail method directly.
 719         (tui_clear_win_detail): Remove.
 720
 721 2019-06-25  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 724         "this", not TUI_DISASM_WIN.
 725
 726 2019-06-25  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 729         declare.
 730         * tui/tui-winsource.c
 731         (tui_source_window_base::do_scroll_horizontal): Rename from
 732         tui_horizontal_source_scroll.
 733         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 734         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 735         from tui_vertical_data_scroll.
 736         * tui/tui-win.h (tui_scroll): Don't declare.
 737         * tui/tui-win.c (tui_win_info::forward_scroll)
 738         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 739         (tui_win_info::right_scroll): Rename and update.
 740         (tui_scroll_forward_command, tui_scroll_backward_command)
 741         (tui_scroll_left_command, tui_scroll_right_command): Update.
 742         (tui_scroll): Remove.
 743         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 744         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 745         from tui_vertical_source_scroll.
 746         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 747         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 748         from tui_vertical_disassem_scroll.
 749         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 750         do_scroll_horizontal>: New methods.
 751         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 752         Likewise.
 753         (struct tui_source_window_base): Add do_scroll_horizontal.
 754         (struct tui_source_window, struct tui_disasm_window): Add
 755         do_scroll_vertical.
 756         (struct tui_data_window, struct tui_cmd_window): Add
 757         do_scroll_horizontal and do_scroll_vertical.
 758         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 759
 760 2019-06-25  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-data.h (struct tui_source_window_base): New struct.
 763         (struct tui_source_window): Derive from tui_source_window_base.
 764         (struct tui_disasm_window): New struct.
 765         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 766         from tui_source_window::clear_detail.
 767         (tui_source_window_base): Rename from tui_source_window.
 768         (~tui_source_window_base): Rename from ~tui_source_window.
 769         (tui_alloc_win_info): Create a tui_disasm_window.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-data.h (struct tui_source_window)
 774         (struct tui_data_window): Declare destructors.
 775         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 776         destructors.
 777         (tui_win_info): Simplify.
 778
 779 2019-06-25  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-winsource.c (tui_display_main)
 782         (tui_update_source_windows_with_addr)
 783         (tui_update_all_breakpoint_info): Update.
 784         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 785         (new_height_ok, parse_scrolling_args): Update.
 786         * tui/tui-stack.c (tui_show_frame_info): Update.
 787         * tui/tui-data.h (struct tui_list): Remove.
 788         (tui_source_windows): Return a reference to a std::vector.
 789         * tui/tui-data.c (source_windows): Now a std::vector.
 790         (tui_source_windows): Change return type.
 791         (tui_clear_source_windows): Rewrite.
 792         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 793         (tui_free_all_source_wins_content): Rewrite.
 794
 795 2019-06-25  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 798         (struct tui_data_window, struct tui_cmd_window): Declare
 799         clear_detail method.
 800         * tui/tui-data.c (tui_source_window::clear_detail)
 801         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 802         methods.
 803         (tui_clear_win_detail): Simplify.
 804
 805 2019-06-25  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-layout.c (make_source_window, make_disasm_window)
 808         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 809         Return the new window.
 810         (show_source_disasm_command, show_data)
 811         (show_source_or_disasm_and_command): Update.
 812
 813 2019-06-25  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 816         parameter.  Return the new window.
 817         (show_source_disasm_command): Update and remove NULL check.
 818         (show_source_or_disasm_and_command): Update.
 819
 820 2019-06-25  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.h (struct tui_win_info): Make constructor
 827         protected.  Make destructor virtual.  Add initializers.
 828         (tui_source_window, tui_data_window, tui_cmd_window): New
 829         classes.
 830         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 831         constructor.  Add "type" parameter.
 832         (tui_source_window, tui_data_window, tui_cmd_window): New
 833         constructors.
 834         (tui_alloc_win_info): Instantiate the appropriate subclass.
 835
 836 2019-06-25  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-win.c (tui_resize_all): Use delete.
 839         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 840         destructor.
 841         (tui_free_window): Don't declare.
 842         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 843         Update.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-data.h (struct tui_win_info): Add constructor.
 848         * tui/tui-data.c (tui_alloc_win_info): Use new.
 849         (tui_free_window): Use delete.
 850
 851 2019-06-22  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 854         declare.
 855         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 856
 857 2019-06-22  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 860         declare.
 861         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 862
 863 2019-06-22  Tom de Vries  <tdevries@suse.de>
 864
 865         * dwarf2read.c (create_addrmap_from_aranges)
 866         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 867         instead of '%zu'.
 868
 869 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 870
 871         * dwarf2read.h (dwarf2_section_info_def): Remove.
 872         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 873         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 874         std::vector<dwarf2_section_info>.
 875         (struct dwo_file) <~dwo_file>: Remove.
 876         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 877         types field.
 878         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 879         (dwarf2_read_debug_names): Likewise.
 880         (create_debug_types_hash_table): Change parameter type to
 881         array_view, adjust code accordingly.
 882         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 883         (partial_die_info::fixup): Likewise.
 884         (determine_prefix): Likewise.
 885         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 886
 887 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 888
 889         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 890         gdb_bfd_ref_ptr.
 891         <~dwo_file>: Remove call to gdb_bfd_unref.
 892         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 893         gdb_bfd_ref_ptr::get.
 894
 895 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 896
 897         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 898         type to htab_up.
 899         * dwarf2read.c (struct dwo_file): Initialize fields.
 900         <~dwo_file>: New.
 901         (free_dwo_file): Remove, move content to ~dwo_file.
 902         (struct dwo_file_deleter): Remove.
 903         (dwo_file_up>: Remove custom deleter.
 904         (free_dwo_files): Remove.
 905         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 906         dwo_files.
 907         (process_skeletonless_type_units): Call unique_ptr::get.
 908         (allocate_dwo_file_hash_table): Add deleter to created hash
 909         table.  Change return type to htab_up.
 910         (lookup_dwo_file_slot): Don't memset dwo_file, call
 911         unique_ptr::get.
 912         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 913         (create_dwo_unit_in_dwp_v2): Likewise.
 914         (open_and_init_dwo_file): Likewise.
 915         (free_dwo_file_from_slot): Remove.
 916
 917 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 918
 919         * dwarf2read.h (struct dwarf2_section_info) <readin,
 920         is_virtual>: Change type to bool.
 921         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 922         true instead of 1.
 923
 924 2019-06-19  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-data.h (tui_init_content_element): Don't declare.
 927
 928 2019-06-19  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-data.h (tui_init_win_info): Don't declare.
 931
 932 2019-06-19  Tom de Vries  <tdevries@suse.de>
 933
 934         * dwarf2read.h (abstract_to_concrete): Change type to
 935         std::unordered_map<sect_offset, std::vector<sect_offset>,
 936         gdb::hash_enum<sect_offset>>.
 937
 938 2019-06-19  Tom Tromey  <tromey@adacore.com>
 939
 940         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 941         EVAL_AVOID_SIDE_EFFECTS specially.
 942
 943 2019-06-19  Tom Tromey  <tromey@adacore.com>
 944
 945         * source-cache.c (highlighter): New global.
 946         (source_cache::get_source_lines): Create a highlighter on demand.
 947
 948 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * defs.h (deprecated_interactive_hook): Delete declaration.
 951         * interps.c (clear_interpreter_hooks): Remove use of
 952         deprecated_interactive_hook.
 953         * top.c (deprecated_interactive_hook): Delete definition.
 954         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 955
 956 2019-06-18  Tom de Vries  <tdevries@suse.de>
 957
 958         PR gdb/24515
 959         * dwarf2read.h (abstract_to_concrete): Change type from
 960         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 961         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 962         * dwarf2read.c (read_variable): Update.
 963         (dwarf2_fetch_die_loc_sect_off): Update.
 964
 965 2019-06-17  Tom de Vries  <tdevries@suse.de>
 966
 967         PR gdb/24617
 968         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 969         accessing parent[parent_len - 1].
 970
 971 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 972
 973         PR gdb/24364
 974         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 975         call dtrace_process_dof with NULL dof.
 976
 977 2019-06-16  Tom de Vries  <tdevries@suse.de>
 978
 979         PR gdb/24445
 980         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 981
 982 2019-06-16  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 985         (make_all_visible): Use address of member.
 986
 987 2019-06-16  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 990         (tui_free_window, free_content, free_content_elements): Remove
 991         unnecessary cast.
 992         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 993         cast.
 994         * tui/tui-regs.c (tui_show_register_group)
 995         (tui_display_registers_from, tui_display_reg_element_at_line):
 996         Remove unnecessary cast.
 997
 998 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * linux-nat.c (normal_mask): Delete.
1001         (_initialize_linux_nat): Don't initialise normal_mask.
1002
1003 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1004
1005         PR gdb/24445
1006         * dwarf-index-write.h (write_psymtabs_to_index): Add
1007         dwz_basename parameter.
1008         * dwarf-index-write.c (write_gdbindex): Move file writing to
1009         write_gdbindex_1.  Change return type void.
1010         (assert_file_size): Move up, remove filename parameter.
1011         (write_gdbindex_1): New function.
1012         (write_debug_names): Change return type to void, call
1013         assert_file_size.
1014         (struct index_wip_file): New struct.
1015         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1016         file logic to index_wip_file.  Write index for dwz file if
1017         needed.
1018         (save_gdb_index_command): Pass basename of dwz file, if present.
1019         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1020         build-id of dwz file, if present.
1021         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1022         (dwarf2_get_dwz_file): Likewise.
1023         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1024         (dwarf2_get_dwz_file): Likewise.
1025
1026 2019-06-16  Tom Tromey  <tom@tromey.com>
1027
1028         * coffread.c (process_coff_symbol): Use xstrdup.
1029         * value.c (create_internalvar): Use xstrdup.
1030
1031 2019-06-16  Tom Tromey  <tom@tromey.com>
1032
1033         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1034         * breakpoint.c (stopin_command, stopat_command)
1035         (until_break_command, decode_location_default): Remove unnecessary
1036         cast.
1037         * utils.c (subset_compare): Remove unnecessary cast.
1038         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1039         cast.
1040         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1041         cast.
1042         * infcmd.c (path_command): Remove unnecessary cast.
1043         * coffread.c (decode_type): Remove unnecessary cast.
1044         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1045         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1046         * tui/tui-stack.c (tui_show_locator_content)
1047         (tui_show_frame_info): Remove unnecessary cast.
1048         * tui/tui-win.c (tui_scroll_forward_command)
1049         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1050         (parse_scrolling_args): Remove unnecessary cast.
1051         * tui/tui-data.c (init_win_info, tui_del_window)
1052         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1053         (free_content_elements): Remove unnecessary cast.
1054         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1055         unnecessary cast.
1056         * tui/tui-source.c (tui_set_source_content)
1057         (tui_vertical_source_scroll): Remove unnecessary cast.
1058         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1059         cast.
1060         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1061         * tui/tui-regs.c (tui_display_registers_from)
1062         (tui_display_register): Remove unnecessary cast.
1063         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1064         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1065         (make_visible): Remove unnecessary cast.
1066         * tui/tui-winsource.c (tui_erase_source_content)
1067         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1068         unnecessary cast.
1069         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1070         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1071         * stabsread.c (read_type, read_array_type, read_range_type):
1072         Remove unnecessary cast.
1073         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1074         (parse_symbol, parse_type, upgrade_type, parse_external)
1075         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1076         unnecessary cast.
1077         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1078
1079 2019-06-16  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-data.c (tui_alloc_generic_win_info)
1082         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1083         checks.
1084
1085 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1086             Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * f-typeprint.c (f_print_type): Don't return early for not
1089         associated or not allocated types.
1090         (f_type_print_varspec_suffix): Add print_rank parameter and print
1091         ranks of array types in case they dangling.
1092         (f_type_print_base): Add print_rank parameter.
1093
1094 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * NEWS: Mention new MI commands.
1097         * break-catch-throw.c (enum exception_event_kind): Move to
1098         breakpoint.h.
1099         (print_mention_exception_catchpoint): Output text as a single
1100         message.
1101         (catch_exception_command_1): Rename to...
1102         (catch_exception_event): ...this, make non-static, update header
1103         command, and change some parameter types.
1104         (catch_catch_command): Update for changes to
1105         catch_exception_command_1.
1106         (catch_throw_command): Likewise.
1107         (catch_rethrow_command): Likewise.
1108         * breakpoint.c (enum exception_event_kind): Delete.
1109         * breakpoint.h (enum exception_event_kind): Moved here from
1110         break-catch-throw.c.
1111         (catch_exception_event): Declare.
1112         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1113         (mi_cmd_catch_throw): New function.
1114         (mi_cmd_catch_rethrow): New function.
1115         (mi_cmd_catch_catch): New function.
1116         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1117         'catch-catch' entries.
1118         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1119         (mi_cmd_catch_rethrow): Declare.
1120         (mi_cmd_catch_catch): Declare.
1121
1122 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * annotate.c (annotate_source_line): Change return type to void,
1125         update implementation to match.
1126         * annotate.h (annotate_source_line): Change return type to void,
1127         update header comment.
1128         * stack.c (print_frame_info): Don't change what frame information
1129         is printed based on whether annotations are on or not.
1130
1131 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1134         (annotate_source): Make static.
1135         (annotate_source_line): Moved from source.c and renamed from
1136         identify_source_line.  Update the return type.
1137         * annotate.h (annotate_source): Delete declaration.
1138         (annotate_source_line): Declaration moved from source.h, and
1139         renamed from identify_source_line.  Return type updated.
1140         * source.c (identify_source_line): Moved to annotate.c and renamed
1141         to annotate_source_line.
1142         (info_line_command): Remove check of annotation_level.
1143         * source.h (identify_source_line): Move declaration to annotate.h
1144         and rename to annotate_source_line.
1145         * stack.c: Add 'annotate.h' include.
1146         (print_frame_info): Remove check of annotation_level before
1147         calling annotate_source_line.
1148
1149 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * source-cache.c (source_cache::get_plain_source_lines): Use
1152         open_source_file_with_line_charpos instead of just
1153         open_source_file, remove call to find_source_lines.
1154         (source_cache::get_source_lines): Likewise.
1155         * source.c (find_source_lines): Make static.
1156         (get_filename_and_charpos): Renamed into...
1157         (open_source_file_with_line_charpos): ..this along with changes to
1158         return a scoped_fd, and some other minor clean ups.
1159         (identify_source_line): Use open_source_file_with_line_charpos.
1160         (search_command_helper): Use open_source_file_with_line_charpos
1161         instead of just open_source_file, remove call to
1162         find_source_lines.
1163         * source.h (open_source_file_with_line_charpos): Declare new
1164         function.
1165         (find_source_lines): Delete declaration.
1166
1167 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * source.c (get_filename_and_charpos): Remove fullname
1170         parameter.
1171         (identify_source_line): Update call to get_filename_and_charpos.
1172
1173 2019-06-14  Tom Tromey  <tromey@adacore.com>
1174
1175         PR gdb/24502:
1176         * ui-style.h (skip_ansi_escape): Update comment.
1177         * ui-file.h (class no_terminal_escape_file): New class.
1178         * ui-file.c (no_terminal_escape_file::write)
1179         (no_terminal_escape_file::puts): New methods.
1180         * cli/cli-logging.c (handle_redirections): Use
1181         no_terminal_escape_file.
1182
1183 2019-06-14  Tom Tromey  <tromey@adacore.com>
1184
1185         * NEWS: Move convenience variable news above Python news.
1186
1187 2019-06-14  Tom Tromey  <tom@tromey.com>
1188
1189         * gnulib: Move directory to top-level.
1190         * configure.ac: Don't configure gnulib.
1191         * configure: Rebuild.
1192         * common/common-defs.h: Use new path to gnulib.
1193         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1194         (GNULIB_H): Remove.
1195         (INCGNU): Look in new gnulib location.
1196         (HFILES_NO_SRCDIR): Remove gnulib files.
1197         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1198         (generated_files): Remove GNULIB_H.
1199         ($(LIBGNU), all-lib): Remove targets.
1200         (distclean): Don't mention GNULIB_BUILDDIR.
1201         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1202
1203 2019-06-14  Tom Tromey  <tromey@adacore.com>
1204
1205         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1206         Warn if symbol file does not provide any symbols.
1207
1208 2019-06-14  Tom Tromey  <tromey@adacore.com>
1209
1210         * source.c (find_and_open_source): Respect basenames_may_differ.
1211
1212 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * annotate.c (annotate_breakpoints_invalid): Make use of
1215         scoped_restore_terminal_state.
1216         (annotate_frames_invalid): Likewise.
1217
1218 2019-06-14  Tom Tromey  <tromey@adacore.com>
1219
1220         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1221         allow assignment to an internalvar.
1222
1223 2019-06-14  Tom Tromey  <tromey@adacore.com>
1224
1225         * ada-lex.l: Allow "_" in attribute names.
1226
1227 2019-06-14  Tom Tromey  <tromey@adacore.com>
1228
1229         PR gdb/24653:
1230         * regcache.c (registers_changed): Don't call alloca.
1231         * top.c (execute_command): Don't call alloca.
1232
1233 2019-06-13  Pedro Alves  <palves@redhat.com>
1234
1235         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1236         'expression'.  When parsing an expression, error out if there's
1237         junk after "unlimited".
1238         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1239         (do_set_command): Adjust calls to is_unlimited_literal.
1240
1241 2019-06-13  Pedro Alves  <palves@redhat.com>
1242
1243         * compile/compile.c (make_compile_options_def_group): Add braces
1244         around array_view initializer.
1245         * thread.c (make_thread_apply_all_options_def_group)
1246         (make_thread_apply_all_options_def_group): Likewise.
1247
1248 2019-06-13  Pedro Alves  <palves@redhat.com>
1249
1250         * NEWS (New commands): Mention "maint test-options
1251         require-delimiter", "maint test-options unknown-is-error", "maint
1252         test-options unknown-is-operand" and "maint show
1253         test-options-completion-result".
1254         (New command options, command completion): New section.
1255         (Completion improvements): New section.
1256         Mention that you can abbreviate "unlimited".
1257
1258 2019-06-13  Pedro Alves  <palves@redhat.com>
1259
1260         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1261         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1262         * unittests/cli-utils-selftests.c (test_parse_flags)
1263         (test_parse_flags_qcs): Delete.
1264         (test_cli_utils): Don't call deleted functions.
1265
1266 2019-06-13  Pedro Alves  <palves@redhat.com>
1267
1268         * thread.c: Include "cli/cli-option.h".
1269         (tp_array_compar_ascending): Global.
1270         (tp_array_compar): Delete function.
1271         (tp_array_compar_ascending, tp_array_compar_descending): New
1272         functions.
1273         (ascending_option_def, qcs_flag_option_def)
1274         (thr_qcs_flags_option_defs)
1275         (make_thread_apply_all_options_def_group)
1276         (make_thread_apply_options_def_group): New.
1277         (thread_apply_all_command): Use gdb::option::process_options.
1278         (thread_apply_command_completer)
1279         (thread_apply_all_command_completer): New.
1280         (thread_apply_command): Use gdb::option::process_options.
1281         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1282         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1283         to generate help text of "thread apply".  Adjust "taas"'s help.
1284         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1285         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1286
1287 2019-06-13  Pedro Alves  <palves@redhat.com>
1288
1289         * thread.c (thread_apply_command): Check for invalid TID with
1290         isdigit instead of !isalpha.
1291
1292 2019-06-13  Pedro Alves  <palves@redhat.com>
1293
1294         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1295         (validate_flags_qcs): New.
1296         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1297         (validate_flags_qcs): Declare.
1298         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1299         (make_frame_apply_options_def_group): New.
1300         (frame_apply_command_count): Process options with
1301         gdb::option::process_options.
1302         (frame_apply_completer): New.
1303         (frame_apply_level_completer, frame_apply_all_completer)
1304         (frame_apply_completer): New.
1305         (_initialize_stack): Update help of "frame apply", "frame apply
1306         level", "frame apply all" and "faas" to mention supported options
1307         and install command completers.
1308         * stack.h (frame_apply_all_completer): Declare.
1309         * thread.c: Include "stack.h".
1310         (tfaas_command): Add "--".
1311         (_initialize_thread): Update help "tfaas" to mention supported
1312         options and install command completer.
1313
1314 2019-06-13  Pedro Alves  <palves@redhat.com>
1315
1316         * completer.c (complete_nested_command_line): New.
1317         (gdb_completion_word_break_characters_throw): Add assertion.
1318         * completer.h (complete_nested_command_line): Declare.
1319
1320 2019-06-13  Pedro Alves  <palves@redhat.com>
1321
1322         * stack.c (parse_backtrace_qualifiers): New.
1323         (backtrace_command): Use it.
1324         (backtrace_command_completer): Complete on qualifiers.
1325
1326 2019-06-13  Pedro Alves  <palves@redhat.com>
1327
1328         * frame.c: Include "cli/cli-option.h.
1329         (user_set_backtrace_options): New.
1330         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1331         Delete.
1332         (get_prev_frame): Adjust.
1333         (boolean_option_def, uinteger_option_def)
1334         (set_backtrace_option_defs): New.
1335         (_initialize_frame): Adjust and use
1336         gdb::option::add_setshow_cmds_for_options to install "set
1337         backtrace past-main" and "set backtrace past-entry".
1338         * frame.h: Include "cli/cli-option.h".
1339         (struct frame_print_options): Forward declare.
1340         (print_frame_arguments_all, print_frame_arguments_scalars)
1341         (print_frame_arguments_none): Declare.
1342         (print_entry_values): Delete declaration.
1343         (struct frame_print_options, user_frame_print_options): New.
1344         (struct set_backtrace_options): New.
1345         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1346         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1347         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1348         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1349         (list_args_or_locals): Add frame_print_options parameter.
1350         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1351         * python/py-framefilter.c (enumerate_args): Pass down
1352         USER_FRAME_PRINT_OPTIONS.
1353         * stack.c: Include "cli/cli-option.h".
1354         (print_frame_arguments_all, print_frame_arguments_scalars)
1355         (print_frame_arguments_none): Declare.
1356         (print_raw_frame_arguments, print_entry_values): Delete.
1357         (user_frame_print_options): New.
1358         (boolean_option_def, enum_option_def, frame_print_option_defs):
1359         New.
1360         (struct backtrace_cmd_options): New.
1361         (bt_flag_option_def): New.
1362         (backtrace_command_option_defs): New.
1363         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1364         (print_frame_arg, read_frame_arg, print_frame_args)
1365         (print_frame_info, print_frame): Add frame_print_options parameter
1366         and use it.
1367         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1368         (backtrace_command_1): Add frame_print_options and
1369         backtrace_cmd_options parameters and use them.
1370         (make_backtrace_options_def_group): New.
1371         (backtrace_command): Process command options with
1372         gdb::option::process_options.
1373         (backtrace_command_completer): New.
1374         (_initialize_stack): Extend "backtrace"'s help to mention
1375         supported options.  Install completer for "backtrace".
1376         Install some settings commands with add_setshow_cmds_for_options.
1377
1378 2019-06-13  Pedro Alves  <palves@redhat.com>
1379
1380         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1381         and that "set/show print raw frame-arguments" are now deprecated.
1382
1383         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1384         command.
1385         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1386         * stack.c (_initialize_stack): Install "set/show print
1387         raw-frame-arguments", and deprecate "set/show print raw
1388         frame-arguments".
1389         * valprint.c (_initialize_valprint): Deprecate "set/show print
1390         raw".
1391
1392 2019-06-13  Pedro Alves  <palves@redhat.com>
1393
1394         * compile/compile.c (struct compile_options): New.
1395         (compile_flag_option_def, compile_command_option_defs)
1396         (make_compile_options_def_group): New.
1397         (compile_file_command): Handle options with
1398         gdb::option::process_options.
1399         (compile_file_command_completer): New function.
1400         (compile_code_command): Handle options with
1401         gdb::option::process_options.
1402         (compile_code_command_completer): New function.
1403         (_initialize_compiler): Install completers for "compile code" and
1404         "compile file".  Mention available options in "compile code" and
1405         "compile code"'s help.
1406         * completer.c (advance_to_completion_word): New, factored out from
1407         ...
1408         (advance_to_expression_complete_word_point): ... this.
1409         (advance_to_filename_complete_word_point): New.
1410         * completer.h (advance_to_filename_complete_word_point): New
1411         declaration.
1412
1413 2019-06-13  Pedro Alves  <palves@redhat.com>
1414
1415         * compile/compile.c: Include "cli/cli-option.h".
1416         (compile_print_value): Scope data pointer is now a
1417         value_print_options pointer; adjust.
1418         (compile_print_command): Process options.  Scope data pointer is
1419         now a value_print_options pointer; adjust.
1420         (_initialize_compile): Update "compile print"'s help to include
1421         supported options.  Install a completer for "compile print".
1422         * cp-valprint.c (show_vtblprint, show_objectprint)
1423         (show_static_field_print): Delete.
1424         (_initialize_cp_valprint): Don't install "set print
1425         static-members", "set print vtbl", "set print object" here.
1426         * printcmd.c: Include "cli/cli-option.h" and
1427         "common/gdb_optional.h".
1428         (print_command_parse_format): Rework to fill in a
1429         value_print_options instead of a format_data.
1430         (print_value): Change parameter type from format_data pointer to
1431         value_print_options reference.  Adjust.
1432         (print_command_1): Process options.  Adjust to pass down a
1433         value_print_options.
1434         (print_command_completer): New.
1435         (_initialize_printcmd): Install print_command_completer as
1436         handle_brkchars completer for the "print" command.  Update
1437         "print"'s help to include supported options.
1438         * valprint.c: Include "cli/cli-option.h".
1439         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1440         here from cp-valprint.c.
1441         (boolean_option_def, uinteger_option_def)
1442         (value_print_option_defs, make_value_print_options_def_group):
1443         New.  Use gdb::option::add_setshow_cmds_for_options to install
1444         "set print elements", "set print null-stop", "set print repeats",
1445         "set print pretty", "set print union", "set print array", "set
1446         print address", "set print symbol", "set print array-indexes".
1447         * valprint.h: Include <string> and "cli/cli-option.h".
1448         (make_value_print_options_def_group): Declare.
1449         (print_value): Change parameter type from format_data pointer to
1450         value_print_options reference.
1451         (print_command_completer): Declare.
1452
1453 2019-06-13  Pedro Alves  <palves@redhat.com>
1454
1455         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1456         (COMMON_SFILES): Add maint-test-settings.c.
1457         * cli/cli-decode.c (boolean_enums): New global, factored out from
1458         ...
1459         (add_setshow_boolean_cmd): ... here.
1460         * cli/cli-decode.h (boolean_enums): Declare.
1461         * cli/cli-option.c: New file.
1462         * cli/cli-option.h: New file.
1463         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1464         factored out from ...
1465         (parse_cli_boolean_value(const char *)): ... this.
1466         (is_unlimited_literal): Change parameter type to pointer to
1467         pointer.  Adjust and advance ARG pointer.
1468         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1469         (parse_cli_var_enum): New, factored out from ...
1470         (do_set_command): ... this.  Adjust.
1471         * cli/cli-setshow.h (parse_cli_boolean_value)
1472         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1473         (parse_cli_var_enum): Declare.
1474         * cli/cli-utils.c: Include "cli/cli-option.h".
1475         (get_ulongest): New.
1476         * cli/cli-utils.h (get_ulongest): Declare.
1477         (check_for_argument): New overloads.
1478         * maint-test-options.c: New file.
1479
1480 2019-06-13  Pedro Alves  <palves@redhat.com>
1481
1482         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1483         parse a range if "-" is at the end of the string.
1484
1485 2019-06-13  Pedro Alves  <palves@redhat.com>
1486
1487         * cli/cli-setshow.c (parse_auto_binary_operation)
1488         (parse_cli_boolean_value): Don't allow "o".
1489
1490 2019-06-13  Pedro Alves  <palves@redhat.com>
1491
1492         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1493         * NEWS: Mention maint test-settings KIND.
1494         * maint-test-settings.c: New file.
1495
1496 2019-06-13  Pedro Alves  <palves@redhat.com>
1497
1498         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1499         completer.
1500         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1501         "set" completers.
1502
1503 2019-06-13  Pedro Alves  <palves@redhat.com>
1504
1505         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1506         after item.
1507
1508 2019-06-13  Pedro Alves  <palves@redhat.com>
1509
1510         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1511
1512 2019-06-13  Pedro Alves <palves@redhat.com>
1513
1514         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1515         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1516         call.
1517         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1518         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1519         calls.
1520         (check_for_argument): Skip spaces after argument.
1521
1522 2019-06-13  Pedro Alves  <palves@redhat.com>
1523
1524         * thread.c (thread_apply_command): Adjust TID parsing.
1525         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1526         detected before end of string.
1527         (tid_is_in_list): Error out if LIST is invalid.
1528
1529 2019-06-13  Pedro Alves  <palves@redhat.com>
1530
1531         * completer.c (complete_line_internal_1): Rewind completion word
1532         point.
1533         (completion_tracker::advance_custom_word_point_by): Change
1534         parameter type to int.
1535         * completer.h (completion_tracker::advance_custom_word_point_by):
1536         Likewise.
1537
1538 2019-06-13  Pedro Alves  <palves@redhat.com>
1539
1540         * completer.c (advance_to_completion_word): Handle delimiters.
1541
1542 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1543
1544         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1545
1546 2019-06-11  Tom Tromey  <tom@tromey.com>
1547
1548         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1549         (xmalloc_failed): Move to alloc.c.
1550         * alloc.c: New file.
1551         * Makefile.in (COMMON_SFILES): Add alloc.c.
1552
1553 2019-06-11  Tom Tromey  <tom@tromey.com>
1554
1555         * nat/linux-waitpid.c: Don't include server.h.
1556         (linux_debug): Remove.
1557         (my_waitpid): Update.
1558
1559 2019-06-11  Tom Tromey  <tromey@adacore.com>
1560
1561         * infcall.c (_initialize_infcall): Remove trailing newline from
1562         help.
1563         * user-regs.c (_initialize_user_regs): Remove trailing newline
1564         from help.
1565         * typeprint.c (_initialize_typeprint): Remove trailing newline
1566         from help.
1567         * reverse.c (_initialize_reverse): Remove trailing newlines from
1568         help.
1569         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1570         from help.
1571         * language.c (add_set_language_command): Remove trailing newline
1572         from help.
1573         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1574         help.
1575         * disasm.c (_initialize_disasm): Remove trailing newline from
1576         help.
1577         * top.c (init_main): Remove trailing newline from help.
1578         * interps.c (_initialize_interpreter): Remove trailing newline
1579         from help.
1580         * btrace.c (_initialize_btrace): Remove trailing newlines from
1581         help.
1582         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1583         from help.
1584         * python/python.c (_initialize_python): Remove trailing newline
1585         from help.
1586         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1587         help.
1588         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1589         from help.  Reformat some text.
1590         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1591         from help.
1592         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1593         newline from help.
1594
1595 2019-06-11  Tom Tromey  <tromey@adacore.com>
1596
1597         * darwin-nat.c (darwin_decode_exception_message)
1598         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1599
1600 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * valops.c (value_slice): Check for not allocated or not
1603         associated values.
1604
1605 2019-06-10  Tom de Vries  <tdevries@suse.de>
1606
1607         PR gdb/24618
1608         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1609         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1610         invalid.
1611
1612 2019-06-10  Tom de Vries  <tdevries@suse.de>
1613
1614         PR gdb/24611
1615         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1616         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1617
1618 2019-06-10  Tom de Vries  <tdevries@suse.de>
1619
1620         PR symtab/24545
1621         * symtab.c (struct demangled_name_entry): Add language field.
1622         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1623         static minimal symbol".  Set and use language field.
1624
1625 2019-06-10  Tom Tromey  <tromey@adacore.com>
1626
1627         * ada-lang.c (_initialize_ada_language): Update help text.
1628
1629 2019-06-10  Tom Tromey  <tromey@adacore.com>
1630
1631         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1632         with a newline.
1633         * guile/guile.c (handle_boot_error): Don't end warning with a
1634         newline.
1635         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1636         warning with a newline.
1637         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1638         newline.
1639         (s12z_frame_cache): Likewise.
1640         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1641         a newline.
1642         * solib-svr4.c (disable_probes_interface): Don't end warning with
1643         a newline.
1644         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1645         newline.
1646         * python/python.c (do_finish_initialization): Don't end warning
1647         with a newline.
1648
1649 2019-06-10  Tom Tromey  <tom@tromey.com>
1650
1651         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1652         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1653         gdbpy_enter.
1654
1655 2019-06-10  Tom Tromey  <tromey@adacore.com>
1656
1657         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1658         data.
1659         (elf_new_init): Don't call stabsread_new_init.
1660         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1661         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1662         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1663
1664 2019-06-10  Tom de Vries  <tdevries@suse.de>
1665
1666         PR symtab/16264
1667         PR symtab/24517
1668         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1669
1670 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1671
1672         * source.c (find_and_open_source): Also rewrite relative file
1673         names.
1674
1675 2019-04-26  Amos Bird  <amosbird@gmail.com>
1676
1677         * annotate.c (annotate_thread_exited): Add "thread-exited"
1678         annotation.
1679
1680 2019-06-06  Tom Tromey  <tromey@adacore.com>
1681
1682         * maint.h (class scoped_command_stats): Use
1683         DISABLE_COPY_AND_ASSIGN.
1684         <print_time>: New method.
1685         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1686         print_time.
1687         (scoped_command_stats::print_time): New method.
1688
1689 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1692         instructions of lengths 6 or 8 bytes.
1693
1694 2019-06-04  Pedro Alves  <palves@redhat.com>
1695
1696         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1697
1698         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1699         * breakpoint.c (condition_completer): Likewise.
1700         * cli/cli-dump.c (scan_expression): Likewise.
1701         * common/filestuff.c (mkdir_recursive): Likewise.
1702         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1703         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1704         (gdb_abspath): Likewise.
1705         * compile/compile-cplus-types.c
1706         (compile_cplus_instance::decl_name): Likewise.
1707         * completer.c (complete_explicit_location):
1708         (signal_completer, reg_or_group_completer_1): Likewise.
1709         * cp-support.c (cp_remove_params_if_any): Likewise.
1710         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1711         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1712         * infcmd.c (strip_bg_char): Likewise.
1713         * linespec.c (copy_token_string): Likewise.
1714         * mi/mi-main.c (output_cores): Likewise.
1715         * psymtab.c (psymtab_search_name):
1716         * symfile.c (test_set_ext_lang_command): Likewise.
1717         * target.c (target_fileio_read_stralloc): Likewise.
1718         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1719         * value.c (complete_internalvar): Likewise.
1720
1721 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1722
1723         Add objfile property to gdb.Type.
1724         * NEWS: Mention Python API addition.
1725         * python/py-type.c (typy_get_objfile): New method.
1726
1727 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1728
1729         * NEWS: Mention the new set|show style [title|highlight].
1730         Mention changes to "show style", "help" and "apropos".
1731
1732 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1733
1734         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1735         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1736         instead of print_help_for_command.
1737         (print_doc_of_command): New function.
1738         (help_list): Add 'apropos -v word' suggestion.
1739         (print_help_for_command): Style the command name using title style.
1740         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1741         (_initialize_cli_cmds): Describe -v in apropos_command help.
1742
1743 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1744
1745         * cli/cli-style.h (cli_style_option): Add name in constructor,
1746         add m_name class member, add constructor with intensity,
1747         add name class function.
1748         (cli_style_option::add_setshow_commands): Remove name argument.
1749         (highlight_style, title_style): New styles.
1750         * cli/cli-style.c (do_show): New function that shows a style
1751         characteristic styling the style name with itself.
1752         (set_style_name): New function.
1753         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1754         Update all callers according to the changes in cli/cli-style.h.
1755         * utils.h (fputs_highlighted): New function.
1756         * utils.c (fputs_highlighted): Likewise.
1757
1758 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1759
1760         * NEWS: Mention new pipe command and new convenience variables.
1761
1762 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1763
1764         * cli/cli-cmds.c (pipe_command): New function.
1765         (_initialize_cli_cmds): Call add_com for pipe_command.
1766         Define | as an alias for pipe.
1767         (exit_status_set_internal_vars): New function.
1768         (shell_escape): Call exit_status_set_internal_vars.
1769         cli/cli-decode.c (find_command_name_length): Recognize | as
1770         a single character command.
1771
1772 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1773
1774         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1775         top.c (execute_command_to_ui_file): New function, mostly a copy
1776         of execute_command_to_string.
1777         (execute_command_to_string): Implement by calling
1778         execute_command_to_ui_file.
1779
1780 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1781
1782         * top.h (saved_command_line): Remove declaration.
1783         * top.c (previous_saved_command_line, previous_repeat_arguments):
1784         New variables.
1785         (saved_command_line): Make static, define together with other
1786         'repeat variables'.
1787         (dont_repeat): Clear repeat_arguments.
1788         (repeat_previous, get_saved_command_line, save_command_line):
1789         New functions.
1790         (gdb_init): Initialize saved_command_line
1791         and previous_saved_command_line.
1792         * main.c (captured_main_1): Remove saved_command_line initialization.
1793         * event-top.c (handle_line_of_input): Update to use
1794         the new 'repeat' related functions instead of direct access to
1795         saved_command_line.
1796         * command.h (repeat_previous, get_saved_command_line,
1797         save_command_line): New declarations.
1798         (dont_repeat): Add comment.
1799
1800 2019-05-30  Tom Tromey  <tromey@adacore.com>
1801
1802         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1803         Fix comment.
1804         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1805
1806 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1807
1808         PR cli/24587
1809         * completer.c (complete): Initialize variable word.
1810
1811 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1812
1813         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1814         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1815         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1816         'body' is NULL to the outter 'if', protecting the '!is_define'
1817         situation as well.
1818
1819 2019-05-29  Tom Tromey  <tromey@adacore.com>
1820
1821         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1822         (dwarf_unknown): New function.
1823         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1824         (dwarf_type_encoding_name): Use dwarf_unknown.
1825
1826 2019-05-29  Tom Tromey  <tromey@adacore.com>
1827
1828         PR c++/20020:
1829         * cp-valprint.c (cp_print_value_fields): Call
1830         cp_print_static_field inside "try".
1831
1832 2019-05-29  Tom Tromey  <tromey@adacore.com>
1833
1834         * inflow.c (struct terminal_info): Add default operator=.
1835         * configure: Rebuild.
1836         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1837         -Wdeprecated-copy-dtor, -Wredundant-move.
1838
1839 2019-05-29  Tom Tromey  <tromey@adacore.com>
1840
1841         * NEWS: Add entry.
1842         * infcmd.c (print_return_value_1): Handle finish_print
1843         option.
1844         (show_print_finish): New function.
1845         (_initialize_infcmd): Add "set/show print finish" commands.
1846         * valprint.c (user_print_options): Initialize new member.
1847         * valprint.h (struct value_print_options) <finish_print>: New
1848         member.
1849
1850 2019-05-28  Tom Tromey  <tromey@adacore.com>
1851
1852         * ada-lang.c (ada_remove_Xbn_suffix)
1853         (find_old_style_renaming_symbol)
1854         (parse_old_style_renaming): Remove.
1855         (ada_find_renaming_symbol): Don't call
1856         find_old_style_renaming_symbol.
1857         (ada_is_renaming_symbol): Rename from
1858         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1859         bool.  Now static.
1860         (ada_read_var_value): Update and simplify.
1861         * ada-exp.y (write_var_or_type): Remove old code.
1862
1863 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1864
1865         * event-top.c: Remove include comment.
1866         * inflow.c (class scoped_ignore_sigttou): Move from here...
1867         * inflow.h (class scoped_ignore_sigttou): ...to here.
1868         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1869         * top.c:  Remove include comment.
1870
1871 2019-05-27  Tom Tromey  <tom@tromey.com>
1872
1873         * NEWS: Fix typo.
1874
1875 2019-05-22  Tom Tromey  <tromey@adacore.com>
1876
1877         * target.c (target_follow_exec): Constify parameter.
1878         * target-delegates.c: Rebuild.
1879         * remote.c (remote_target::follow_exec): Constify parameter.
1880         * infrun.c (follow_exec): Constify parameter.
1881         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1882         (target_follow_exec): Likewise.
1883
1884 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1885
1886         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1887         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1888
1889 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1890
1891         * NEWS: Add debugredirect and testsuite sections.
1892
1893 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1894
1895         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1896         target descriptions using exclusively floating point register name
1897         aliases.
1898
1899 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1900
1901         PR gdb/18644:
1902         * f-lang.c (build_fortran_types): Handle the case where
1903         gdbarch_floatformat_for_type returns a nullptr.
1904
1905 2019-05-21  Tom de Vries  <tdevries@suse.de>
1906
1907         PR cli/24587
1908         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1909
1910 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         PR gdb/18644:
1913         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1914         16-byte floats.
1915         * i386-tdep.c (i386_floatformat_for_type): Use
1916         floatformats_ia64_quad for the 16-byte floating point component
1917         within a fortran 32-byte complex number.
1918
1919 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1922         delete default constructor.
1923         (find_partial_die): Update to return const struct.
1924         (partial_die_parent_scope): Move variable declaration into scope
1925         of its use and change its type to auto.
1926         (guess_partial_die_structure_name): Likewise.
1927         (partial_die_info::fixup): Likewise.
1928
1929 2019-05-17  Tom Tromey  <tromey@adacore.com>
1930
1931         * source.c (find_and_open_source): Remove cast.
1932
1933 2019-05-17  Tom Tromey  <tromey@adacore.com>
1934
1935         * annotate.c (annotate_source): Make "filename" const.
1936         * annotate.h (annotate_source): Use const.
1937
1938 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1939
1940         * disasm.c (set_disassembler_options): Send errors to stderr.
1941
1942 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1943
1944         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1945         (cli_interp_base::set_logging): Check debug_redirect.
1946         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1947         * cli/cli-logging.c (debug_redirect): Add static variable.
1948         (pop_output_files): Add default param.
1949         (handle_redirections): Print debug setting.
1950         (show_logging_command): Likewise.
1951         (_initialize_cli_logging): Add debugredirect command.
1952         * interps.c (current_interp_set_logging): Add debug_redirect
1953         parameter.
1954         * interps.h (set_logging): Add debug_redirect parameter.
1955         (current_interp_set_logging): Likewise.
1956         * mi/mi-common.h: Likewise.
1957         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1958
1959 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1960             Tom Tromey  <tromey@adacore.com>
1961
1962         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1963         directly.
1964         * cli/cli-interp.h (make_logging_output): Remove declaration.
1965         * cli/cli-logging.c (make_logging_output): Remove function.
1966         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1967         directly.
1968         * ui-file.c (tee_file::tee_file): Remove bools.
1969         (tee_file::~tee_file): Remove deletes.
1970         * ui-file.h (tee_file): Remove bools.
1971
1972 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1973
1974         * mi/mi-cmds.h (mi_cmd_complete): New function.
1975         * mi/mi-main.c (mi_cmd_complete): Likewise.
1976         * mi/mi-cmds.c: Define new MI command -complete.
1977         * NEWS: Mention new -complete command.
1978
1979 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1980
1981         * completer.h (complete): New function.
1982         * completer.c (complete): Likewise.
1983         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1984         function defined in completer.h.
1985
1986 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1987
1988         * MAINTAINERS (Write After Approval): Add myself.
1989
1990 2019-05-17  Tom de Vries  <tdevries@suse.de>
1991
1992         PR gdb/24094
1993         * dwarf2read.c (struct cu_partial_die_info): New struct.
1994         (find_partial_die): Return cu_partial_die_info.
1995         (partial_die_parent_scope, guess_partial_die_structure_name)
1996         (partial_die_info::fixup): Handle new return type of find_partial_die.
1997
1998 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1999
2000         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2001         "std::string", simplifying the algorithm.
2002
2003 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2004
2005         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2006         (stap_static_probe_ops::get_probes): Likewise.
2007
2008 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2009
2010         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2011         '-')" and "else if".
2012         (stap_parse_single_operand): Join checks for
2013         "gdbarch_stap_parse_special_token_p" and
2014         "gdbarch_stap_parse_special_token" in the same "if" statement.
2015         Invert check when verifying for operation on register
2016         displacement.
2017
2018 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2019
2020         * stap-probe.c (stap_get_opcode): Update comment.
2021         (stap_get_expected_argument_type): Likewise.
2022         (handle_stap_probe): Likewise.
2023
2024 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2025
2026         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2027         return type to 'bool'.  Adjust comment.  Use 'bool' when
2028         appropriate.
2029         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2030         * stap-probe.c (stap_parse_argument_1): Likewise.
2031         (stap_is_operator): Likewise.
2032         (stap_is_generic_prefix): Likewise.
2033         (stap_is_register_prefix): Likewise.
2034         (stap_is_register_indirection_prefix): Likewise.
2035         (stap_is_integer_prefix): Likewise.
2036         (stap_generic_check_suffix): Likewise.
2037         (stap_check_integer_suffix): Likewise.
2038         (stap_check_register_suffix): Likewise.
2039         (stap_check_register_indirection_suffix): Likewise.
2040         (stap_parse_register_operand): Likewise.
2041         (stap_parse_single_operand): Likewise.
2042         (stap_parse_argument_1): Likewise.
2043         (stap_probe::get_argument_count): Likewise.
2044         (stap_is_operator): Likewise.
2045
2046 2019-05-16  Tom Tromey  <tromey@adacore.com>
2047
2048         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2049         keyword to foreach.
2050
2051 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2052
2053         * linux-thread-db.c (try_thread_db_load_1): Change return type
2054         to bool.
2055         (try_thread_db_load): Likewise.
2056         (try_thread_db_load_from_pdir_1): Likewise.
2057         (try_thread_db_load_from_pdir): Likewise.
2058         (try_thread_db_load_from_sdir): Likewise.
2059         (try_thread_db_load_from_dir): Likewise.
2060         (thread_db_load_search): Likewise.
2061         (has_libpthread): Likewise.
2062         (thread_db_load): Likewise.
2063
2064 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2065
2066         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2067         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2068         NULL, and complain/return if that's the case.
2069
2070 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2071
2072         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2073         (advance, posn, abstract_read_memory): New functions.
2074         [struct mem_read_abstraction]: New struct.
2075         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2076
2077 2019-05-14  Tom Tromey  <tromey@adacore.com>
2078
2079         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2080         value is not lval_memory.
2081
2082 2019-05-14  Tom Tromey  <tromey@adacore.com>
2083
2084         * solib.c (info_sharedlibrary_command): Style the file name.
2085
2086 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2087
2088         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2089         (aarch64_vnv_type): Likewise.
2090         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2091         * common/tdesc.c: Likewise.
2092         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2093         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2094         * features/aarch64-fpu.xml: Add ieee half view.
2095         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2096         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2097         * gdbtypes.h (struct builtin_type): Likewise.
2098         (struct objfile_type): Likewise.
2099
2100 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2101
2102         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2103         typo.
2104         * location.h (string_to_event_location): Likewise.
2105
2106 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2107
2108         GDB 8.3 released.
2109
2110 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2111
2112         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2113         New variable declaration.
2114         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2115         New variable.
2116         (print_one_breakpoint): Use ui_out::test_flags and new global
2117         variable to compute use_fixed_output.
2118         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2119         Remove.
2120         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2121         (mi_multi_location_breakpoint_output_fixed): Remove.
2122         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2123         new variable.
2124         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2125         fix_multi_location_breakpoint_output flag if version >= 3.
2126         * ui-out.h (enum ui_out_flag)
2127         <fix_multi_location_breakpoint_output>: New enumerator.
2128
2129 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2130
2131         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2132
2133 2019-05-10  Tom Tromey  <tromey@adacore.com>
2134
2135         * ada-lang.c (catch_ada_completer): New function.
2136         (_initialize_ada_language): Use it.
2137
2138 2019-05-10  Tom Tromey  <tromey@adacore.com>
2139
2140         * thread.c (print_thread_info): Make "requested_threads" const.
2141         * gdbthread.h (print_thread_info): Make "requested_threads"
2142         const.
2143         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2144         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2145
2146 2019-05-08  Tom Tromey  <tom@tromey.com>
2147
2148         * gdbtypes.c (objfile_type_data): Change type.
2149         (objfile_type, _initialize_gdbtypes): Update.
2150
2151 2019-05-08  Tom Tromey  <tom@tromey.com>
2152
2153         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2154         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2155         (_initialize_dwarf2_frame): Update.
2156
2157 2019-05-08  Tom Tromey  <tom@tromey.com>
2158
2159         * objc-lang.c (objc_objfile_data): Change type.
2160         (find_methods): Update.
2161         (_initialize_objc_lang): Remove.
2162
2163 2019-05-08  Tom Tromey  <tom@tromey.com>
2164
2165         * stabsread.c (rs6000_builtin_type_data): Change type.
2166         (rs6000_builtin_type, _initialize_stabsread): Update.
2167
2168 2019-05-08  Tom Tromey  <tom@tromey.com>
2169
2170         * mips-tdep.c (mips_pdr_data): Remove.
2171         (_initialize_mips_tdep): Update.
2172
2173 2019-05-08  Tom Tromey  <tom@tromey.com>
2174
2175         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2176         (hppa_init_objfile_priv_data, read_unwind_info)
2177         (find_unwind_entry, _initialize_hppa_tdep): Update.
2178
2179 2019-05-08  Tom Tromey  <tom@tromey.com>
2180
2181         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2182         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2183         on obstack.
2184         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2185
2186 2019-05-08  Tom Tromey  <tom@tromey.com>
2187
2188         * mdebugread.c (basic_type_data): Change type.
2189         (basic_type, _initialize_mdebugread): Update.
2190
2191 2019-05-08  Tom Tromey  <tom@tromey.com>
2192
2193         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2194
2195 2019-05-08  Tom Tromey  <tom@tromey.com>
2196
2197         * nto-tdep.c (nto_inferior_data_reg): Change type.
2198         (nto_inferior_data): Update.
2199         (nto_inferior_data_cleanup, nto_new_inferior_data)
2200         (_initialize_nto_tdep): Remove.
2201         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2202
2203 2019-05-08  Tom Tromey  <tom@tromey.com>
2204
2205         * ada-lang.c (struct ada_inferior_data): Add initializers.
2206         (ada_inferior_data): Change type.
2207         (ada_inferior_data_cleanup): Remove.
2208         (get_ada_inferior_data, ada_inferior_exit)
2209         (struct ada_pspace_data): Add initializers, destructor.
2210         (ada_pspace_data_handle): Change type.
2211         (get_ada_pspace_data): Update.
2212         (ada_pspace_data_cleanup): Remove.
2213
2214 2019-05-08  Tom Tromey  <tom@tromey.com>
2215
2216         * coffread.c (struct coff_symfile_info): Add initializers.
2217         (coff_objfile_data_key): Move lower.  Change type.
2218         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2219         Update.
2220         (coff_free_info): Remove.
2221
2222 2019-05-08  Tom Tromey  <tom@tromey.com>
2223
2224         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2225         (fbsd_pspace_data_handle): Move lower.  Change type.
2226         (get_fbsd_pspace_data): Update.
2227         (fbsd_pspace_data_cleanup): Remove.
2228         (_initialize_fbsd_tdep): Update.
2229
2230 2019-05-08  Tom Tromey  <tom@tromey.com>
2231
2232         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2233         (get_ada_tasks_pspace_data): Update.
2234         (ada_tasks_pspace_data_cleanup): Remove.
2235         (_initialize_tasks): Update.
2236         (ada_tasks_inferior_data_handle): Change type.
2237         (get_ada_tasks_inferior_data): Update.
2238         (ada_tasks_inferior_data_cleanup): Remove.
2239         (struct ada_tasks_pspace_data): Add initializers.
2240
2241 2019-05-08  Tom Tromey  <tom@tromey.com>
2242
2243         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2244         * symfile-debug.c (debug_sym_get_probes): Change type.
2245         * stap-probe.c (handle_stap_probe):
2246         (stap_static_probe_ops::get_probes): Change type.
2247         * probe.h (class static_probe_ops) <get_probes>: Change type.
2248         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2249         (parse_probes_in_pspace): Update.
2250         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2251         Update.
2252         (any_static_probe_ops::get_probes): Change type.
2253         * elfread.c (elfread_data): New typedef.
2254         (probe_key): Change type.
2255         (elf_get_probes): Likewise.  Update.
2256         (probe_key_free): Remove.
2257         (_initialize_elfread): Update.
2258         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2259         Change type.
2260         (dtrace_process_dof_probe, dtrace_process_dof)
2261         (dtrace_static_probe_ops::get_probe): Change type.
2262
2263 2019-05-08  Tom Tromey  <tom@tromey.com>
2264
2265         * xcoffread.c (struct xcoff_symfile_info): Rename from
2266         coff_symfile_info.  Add initializers.
2267         (xcoff_objfile_data_key): Move lower.  Change type.
2268         (XCOFF_DATA): Rewrite.
2269         (xcoff_free_info): Remove.
2270         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2271         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2272         (xcoff_initial_scan): Update.
2273
2274 2019-05-08  Tom Tromey  <tom@tromey.com>
2275
2276         * solib-svr4.c (struct svr4_info): Add initializers and
2277         destructor.
2278         <probes_table>: Now an htab_up.
2279         (solib_svr4_pspace_data): Change type.
2280         (free_probes_table): Simplify.
2281         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2282         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2283         (probes_table_remove_objfile_probes, register_solib_event_probe)
2284         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2285         (_initialize_svr4_solib): Update.
2286
2287 2019-05-08  Tom Tromey  <tom@tromey.com>
2288
2289         * remote.c (remote_pspace_data): Change type.
2290         (remote_pspace_data_cleanup): Remove.
2291         (get_remote_exec_file, set_pspace_remote_exec_file)
2292         (_initialize_remote): Update.
2293
2294 2019-05-08  Tom Tromey  <tom@tromey.com>
2295
2296         * breakpoint.c (breakpoint_objfile_key): Change type.
2297         (get_breakpoint_objfile_data): Update.
2298         (free_breakpoint_objfile_data): Remove.
2299         (_initialize_breakpoint): Update.
2300
2301 2019-05-08  Tom Tromey  <tom@tromey.com>
2302
2303         * linux-tdep.c (struct linux_info): Add initializers.
2304         (linux_inferior_data): Move.  Change type.
2305         (invalidate_linux_cache_inf): Update.
2306         (linux_inferior_data_cleanup): Remove.
2307         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2308
2309 2019-05-08  Tom Tromey  <tom@tromey.com>
2310
2311         * auxv.c (auxv_inferior_data): Move.  Change type.
2312         (auxv_inferior_data_cleanup): Remove.
2313         (invalidate_auxv_cache_inf): Rewrite.
2314         (get_auxv_inferior_data, _initialize_auxv): Update.
2315
2316 2019-05-08  Tom Tromey  <tom@tromey.com>
2317
2318         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2319         (symfile_debug_objfile_data_key): Change type.
2320         (symfile_debug_installed, debug_qf_has_symbols)
2321         (debug_qf_find_last_source_symtab)
2322         (debug_qf_forget_cached_source_info)
2323         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2324         (debug_qf_print_stats, debug_qf_dump)
2325         (debug_qf_expand_symtabs_for_function)
2326         (debug_qf_expand_all_symtabs)
2327         (debug_qf_expand_symtabs_with_fullname)
2328         (debug_qf_map_matching_symbols)
2329         (debug_qf_expand_symtabs_matching)
2330         (debug_qf_find_pc_sect_compunit_symtab)
2331         (debug_qf_map_symbol_filenames)
2332         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2333         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2334         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2335         (debug_sym_read_linetable, debug_sym_relocate): Update.
2336         (symfile_debug_free_objfile): Remove.
2337         (install_symfile_debug_logging, _initialize_symfile_debug):
2338         Update.
2339
2340 2019-05-08  Tom Tromey  <tom@tromey.com>
2341
2342         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2343         allocate_on_obstack.
2344         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2345         (get_dwarf2_per_objfile): Update.
2346         (set_dwarf2_per_objfile): Remove.
2347         (dwarf2_has_info, dwarf2_get_section_info): Update.
2348         (dwarf2_free_objfile): Remove.
2349         (_initialize_dwarf2_read): Update.
2350
2351 2019-05-08  Tom Tromey  <tom@tromey.com>
2352
2353         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2354         initializers.
2355         <unsupported_script_warning_printed,
2356         script_not_found_warning_printed>: Now bool.
2357         (auto_load_pspace_data): Change type.
2358         (~auto_load_pspace_info): Rename from
2359         auto_load_pspace_data_cleanup.
2360         (get_auto_load_pspace_data, init_loaded_scripts_info)
2361         (clear_section_scripts, maybe_print_unsupported_script_warning)
2362         (maybe_print_script_not_found_warning, _initialize_auto_load):
2363         Update.
2364
2365 2019-05-08  Tom Tromey  <tom@tromey.com>
2366
2367         * objfiles.c (objfile_pspace_info): Add destructor and
2368         initializers.
2369         (objfiles_pspace_data): Change type.
2370         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2371         (get_objfile_pspace_data): Update.
2372         (objfiles_bfd_data): Change type.
2373         (get_objfile_bfd_data): Update.
2374         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2375
2376 2019-05-08  Tom Tromey  <tom@tromey.com>
2377
2378         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2379         Change type.
2380         (get_catch_syscall_inferior_data): Update.
2381         (catch_syscall_inferior_data_cleanup): Remove.
2382         (_initialize_break_catch_syscall): Update.
2383
2384 2019-05-08  Tom Tromey  <tom@tromey.com>
2385
2386         * inflow.c (struct terminal_info): Add destructor and
2387         initializers.
2388         (inflow_inferior_data): Change type.
2389         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2390         (get_inflow_inferior_data, inflow_inferior_exit)
2391         (swap_terminal_info, _initialize_inflow): Update.
2392
2393 2019-05-08  Tom Tromey  <tom@tromey.com>
2394
2395         * target-dcache.c (target_dcache_cleanup): Remove.
2396         (target_dcache_aspace_key): Change type.
2397         (target_dcache_init_p, target_dcache_invalidate)
2398         (target_dcache_get, target_dcache_get_or_init)
2399         (_initialize_target_dcache): Update.
2400         * dcache.h (struct dcache_deleter): New.
2401
2402 2019-05-08  Tom Tromey  <tom@tromey.com>
2403
2404         * symtab.c (struct symbol_cache): Add destructor and
2405         initializers.
2406         (symbol_cache_key): Move.  Change type.
2407         (make_symbol_cache, free_symbol_cache): Remove.
2408         (get_symbol_cache): Update.
2409         (symbol_cache_cleanup): Remove.
2410         (ALL_PSPACES, symbol_cache_flush)
2411         (maintenance_print_symbol_cache)
2412         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2413         Update.
2414
2415 2019-05-08  Tom Tromey  <tom@tromey.com>
2416
2417         * symtab.c (struct main_info): Add destructor and initializers.
2418         (main_progspace_key): Move.  Change type.
2419         (get_main_info): Update.
2420         (main_info_cleanup): Remove.
2421         (_initialize_symtab): Update.
2422
2423 2019-05-08  Tom Tromey  <tom@tromey.com>
2424
2425         * registry.h (DECLARE_REGISTRY): Define the _key class.
2426
2427 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * NEWS: Merge two 'New commands' sections.
2430
2431 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2432
2433         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2434         parameter and use Ada language definition instead.
2435         (ada_val_print_ptr): Remove unused language parameter.
2436         (ada_val_print_num): Remove language parameter and use Ada language
2437         definition instead.
2438         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2439         parameter.
2440         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2441         parameter and use Ada language definition instead.
2442         (ada_val_print_1): Update all ada_val_print_xxx calls.
2443         Remove language parameter.
2444         (ada_val_print): Update ada_val_print_1 call.
2445
2446 2019-05-08  Tom Tromey  <tromey@adacore.com>
2447
2448         * remote.c (remote_hw_watchpoint_limit)
2449         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2450         Now static.
2451
2452 2019-05-08  Tom Tromey  <tromey@adacore.com>
2453
2454         * maint.c (_initialize_maint_cmds): Move initialization code to
2455         remote.c.
2456         (watchdog, show_watchdog): Move to remote.c.
2457         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2458         "watchdog" static.
2459         (_initialize_remote): Move initialization code from maint.c.
2460         * defs.h (watchdog): Don't declare.
2461
2462 2019-05-08  Tom Tromey  <tromey@adacore.com>
2463
2464         * tui/tui-interp.c: Include main.h.
2465         * interps.c: Include main.h.
2466         * main.h (interpreter_p): Declare.
2467         * defs.h (interpreter_p): Don't declare.
2468
2469 2019-05-08  Tom Tromey  <tromey@adacore.com>
2470
2471         * dwarf2loc.c: Include dwarf2read.h.
2472         * defs.h (read_unsigned_leb128): Don't declare.
2473         * dwarf2read.h (read_unsigned_leb128): Declare.
2474
2475 2019-05-08  Tom Tromey  <tromey@adacore.com>
2476
2477         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2478         method.
2479
2480 2019-05-08  Tom Tromey  <tromey@adacore.com>
2481
2482         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2483         when no wrap column is set.
2484
2485 2019-05-08  Tom Tromey  <tromey@adacore.com>
2486
2487         * c-lang.c (c_get_string): Handle non-C-style arrays.
2488
2489 2019-05-08  Tom Tromey  <tromey@adacore.com>
2490
2491         * typeprint.c (print_offset_data::update): Print the bit offset,
2492         not the number of bits remaining.
2493
2494 2019-05-08  Tom Tromey  <tromey@adacore.com>
2495
2496         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2497         padding at end of comment.
2498
2499 2019-05-08  Tom Tromey  <tromey@adacore.com>
2500
2501         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2502         Compare main types.
2503
2504 2019-05-06  Tom Tromey  <tom@tromey.com>
2505
2506         * common/scoped_mmap.c: Include common-defs.h.
2507         * common/scoped_mmap.h: Don't include config.h.
2508
2509 2019-05-04  Tom Tromey  <tom@tromey.com>
2510
2511         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2512         (struct aarch64_call_info): Add initializers.
2513         <si>: Now a std::vector.
2514         (pass_on_stack, aarch64_push_dummy_call): Update.
2515
2516 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2517             Tom Tromey  <tom@tromey.com>
2518
2519         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2520         (ppc_threads): Now a std::vector.  Now static.
2521         (hwdebug_find_thread_points_by_tid)
2522         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2523         Update.
2524
2525 2019-05-04  Tom Tromey  <tom@tromey.com>
2526
2527         * arc-tdep.c (arc_tdesc_init): Return bool.
2528
2529 2019-05-04  Tom Tromey  <tom@tromey.com>
2530
2531         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2532         Use gdb_assert_not_reached.
2533
2534 2019-05-04  Tom Tromey  <tom@tromey.com>
2535
2536         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2537         "false".
2538
2539 2019-05-04  Tom Tromey  <tom@tromey.com>
2540
2541         * arc-tdep.c (arc_tdesc_init): Use bool.
2542
2543 2019-05-04  Tom Tromey  <tom@tromey.com>
2544
2545         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2546
2547 2019-05-04  Tom Tromey  <tom@tromey.com>
2548
2549         * cli/cli-cmds.c (valid_command_p): Return bool.
2550
2551 2019-05-04  Tom Tromey  <tom@tromey.com>
2552
2553         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2554         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2555
2556 2019-05-04  Raul Tambre  <raul@tambre.ee>
2557
2558         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2559         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2560         operator for comparison.
2561
2562 2019-05-04  Tom Tromey  <tom@tromey.com>
2563
2564         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2565         (lookup_partial_symbol, print_partial_symbols)
2566         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2567         (psymbol_compare): Update.
2568         (add_psymbol_to_bcache): Clear the entire psymbol.
2569         (maintenance_check_psymtabs): Update.
2570         * psympriv.h (struct partial_symbol): Don't derive from
2571         general_symbol_info.
2572         <obj_section, unrelocated_address, address,
2573         set_unrelocated_address>: Update.
2574         <ginfo>: New member.
2575         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2576         (debug_names::write_psymbols): Update.
2577
2578 2019-05-04  Tom de Vries  <tdevries@suse.de>
2579
2580         * contrib/cc-with-tweaks.sh: Support -n arg.
2581
2582 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2583
2584         * corelow.c (core_target::detach): Ensure frame cache and
2585         register caches are cleared.
2586         inferior.c (exit_inferior_1): Likewise.
2587
2588 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2589             Tom Tromey  <tom@tromey.com>
2590
2591         * dictionary.c (collate_pending_symbols_by_language): Remove
2592         "struct" from foreach.
2593         * symtab.c (lookup_global_symbol_from_objfile)
2594         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2595         foreach.
2596         * ser-tcp.c (net_open): Remove "struct" from foreach.
2597         * objfiles.c (objfile_relocate, objfile_rebase)
2598         (objfile_has_symbols): Remove "struct" from foreach.
2599         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2600         from foreach.
2601         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2602         foreach.
2603         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2604         "struct" from foreach.
2605         * ada-lang.c (create_excep_cond_exprs)
2606         (ada_exception_catchpoint_cond_string): Remove "struct" from
2607         foreach.
2608
2609 2019-05-03  Tom Tromey  <tromey@adacore.com>
2610
2611         * ada-exp.y (convert_char_literal): Check suffix of each
2612         enumerator.
2613
2614 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2615
2616         PR ada/21406:
2617         * ada-exp.y (yywrap): Don't define.
2618         * ada-lex.l (%option): Add noyywrap
2619         (yywrap): Remove.
2620
2621 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2622
2623         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2624         _WIN32_WINNT to the XP level, unless already defined to a higher
2625         level.
2626
2627         * unittests/parse-connection-spec-selftests.c:
2628         * ser-tcp.c:
2629         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2630         override.
2631
2632         * symfile.c (find_separate_debug_file): Remove colon from the
2633         drive spec of DOS/Windows file names of the target, so that the
2634         file name produced from DEBUGDIR and the target's directory will
2635         be valid on DOS/Windows systems.
2636
2637 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * rust-lang.c (val_print_struct): Handle printing structures
2640         containing strings.
2641
2642 2019-05-02  Tom Tromey  <tromey@adacore.com>
2643
2644         * valarith.c (_initialize_valarith): Remove.
2645
2646 2019-05-01  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2649         bitfields.
2650
2651 2019-05-01  Tom Tromey  <tromey@adacore.com>
2652
2653         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2654         for big-endian copies.
2655
2656 2019-04-30  Ali Tamur  <tamur@google.com>
2657         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2658         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2659         (read_3_bytes): New function.
2660
2661 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2662
2663         * windows-nat.c (main_thread_id): Delete.
2664         (handle_output_debug_string): Replace main_thread_id by
2665         current_event.dwThreadId.
2666         (fake_create_process): Likewise.
2667         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2668         Do not set main_thread_id.
2669         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2670         current_event.dwThreadId.
2671         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2672
2673 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2674
2675         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2676         Use current_event.dwThreadId instead of main_thread_id.
2677
2678 2019-04-30  Tom Tromey  <tromey@adacore.com>
2679
2680         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2681         (create_excep_cond_exprs): Iterate over program spaces.
2682         (ada_exception_catchpoint_cond_string): Examine all minimal
2683         symbols for exception types.
2684
2685 2019-04-30  Tom Tromey  <tromey@adacore.com>
2686
2687         PR c++/24470:
2688         * dwarf2read.c (process_structure_scope): Handle case where type
2689         has template parameters but no symbol was created.
2690
2691 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2692             Chris January  <chris.january@arm.com>
2693
2694         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2695         qualifier.
2696         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2697
2698 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * f-typeprint.c (f_print_type): Update rules for printing
2701         whitespace.
2702         (f_type_print_varspec_suffix): Likewise.
2703
2704 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2705             Chris January  <chris.january@arm.com>
2706
2707         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2708         function arguments.
2709
2710 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2711
2712         * f-lang.c (build_fortran_types): Change name of void type to
2713         lower case.
2714         * f-typeprint.c (f_type_print_base): Print the name of the void
2715         type, rather than a fixed string.
2716         * f-valprint.c (f_decorations): Use lower case void string.
2717
2718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2719             Chris January  <chris.january@arm.com>
2720
2721         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2722         types for Fortran.
2723
2724 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2725             Chris January  <chris.january@arm.com>
2726             David Lecomber  <david.lecomber@arm.com>
2727
2728         * f-exp.y (BINOP_INTRINSIC): New token.
2729         (exp): New parser rule handling BINOP_INTRINSIC.
2730         (f77_keywords): Add new builtin procedures.
2731         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2732         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2733         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2734         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2735         (print_unop_subexp_f): New function.
2736         (print_binop_subexp_f): New function.
2737         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2738         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2739         (dump_subexp_body_f): Likewise.
2740         (operator_check_f): Likewise.
2741         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2742         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2743
2744 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2747         UNOP_KIND.
2748         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2749         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2750         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2751         (operator_length_f): New fuction.
2752         (print_subexp_f): New function.
2753         (op_name_f): New function.
2754         (dump_subexp_body_f): New function.
2755         (operator_check_f): New function.
2756         (exp_descriptor_f): Replace standard expression handling functions
2757         with new functions.
2758         * gdb/fortran-operator.def: New file.
2759         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2760         * gdb/std-operator.def: Remove UNOP_KIND.
2761
2762 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * std-operator.def: Remove unbalanced, stray double quote
2765         character.
2766
2767 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2768             Chris January  <chris.january@arm.com>
2769             Daniel Everett  <daniel.everett@arm.com>
2770             Nick Forrington  <nick.forrington@arm.com>
2771             Richard Bunt  <richard.bunt@arm.com>
2772
2773         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2774         of depth when printing anonymous structs or unions.
2775         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2776         Don't print either the top-level value, or the children if the
2777         max-depth is exceeded.
2778         (ppscm_print_children): When printing the key of a map, allow one
2779         extra level of depth.
2780         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2781         print either the top-level value, or the children if the max-depth
2782         is exceeded.
2783         (print_children): When printing the key of a map, allow one extra
2784         level of depth.
2785         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2786         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2787         (user_print_options): Initialise max_depth field.
2788         (val_print_scalar_or_string_type_p): New function.
2789         (val_print): Check to see if the max depth has been reached.
2790         (val_print_check_max_depth): Define new function.
2791         (show_print_max_depth): New function.
2792         (_initialize_valprint): Add 'print max-depth' option.
2793         * valprint.h (struct value_print_options) <max_depth>: New field.
2794         (val_print_check_max_depth): Declare new function.
2795         * NEWS: Document new feature.
2796
2797 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * ada-lang.c (ada_language_defn): Initialise new field.
2800         * c-lang.c (c_is_string_type_p): New function.
2801         (c_language_defn): Initialise new field.
2802         (cplus_language_defn): Initialise new field.
2803         (asm_language_defn): Initialise new field.
2804         (minimal_language_defn): Initialise new field.
2805         * c-lang.h (c_is_string_type_p): Declare new function.
2806         * d-lang.c (d_language_defn): Initialise new field.
2807         * f-lang.c (f_is_string_type_p): New function.
2808         (f_language_defn): Initialise new field.
2809         * go-lang.c (go_is_string_type_p): New function.
2810         (go_language_defn): Initialise new field.
2811         * language.c (default_is_string_type_p): New function.
2812         (unknown_language_defn): Initialise new field.
2813         (auto_language_defn): Initialise new field.
2814         * language.h (struct language_defn) <la_is_string_type_p>: New
2815         member variable.
2816         (default_is_string_type_p): Declare new function.
2817         * m2-lang.c (m2_language_defn): Initialise new field.
2818         * objc-lang.c (objc_language_defn): Initialise new field.
2819         * opencl-lang.c (opencl_language_defn): Initialise new field.
2820         * p-lang.c (pascal_is_string_type_p): New function.
2821         (pascal_language_defn): Initialise new field.
2822         * rust-lang.c (rust_is_string_type_p): New function.
2823         (rust_language_defn): Initialise new field.
2824
2825 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2826
2827         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2828         New field.
2829         * ada-lang.c (ada_language_defn): Initialise new field.
2830         * c-lang.c (c_language_defn): Likewise.
2831         (cplus_language_defn): Likewise.
2832         (asm_language_defn): Likewise.
2833         (minimal_language_defn): Likewise.
2834         * d-lang.c (d_language_defn): Likewise.
2835         * f-lang.c (f_language_defn): Likewise.
2836         * go-lang.c (go_language_defn): Likewise.
2837         * language.c (unknown_language_defn): Likewise.
2838         (auto_language_defn): Likewise.
2839         * m2-lang.c (m2_language_defn): Likewise.
2840         * objc-lang.c (objc_language_defn): Likewise.
2841         * opencl-lang.c (opencl_language_defn): Likewise.
2842         * p-lang.c (pascal_language_defn): Likewise.
2843         * rust-lang.c (rust_language_defn): Likewise.
2844
2845 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * ada-lang.c (ada_is_character_type): Change return type to bool.
2848         (ada_is_string_type): Likewise.
2849         * ada-lang.h (ada_is_character_type): Update declaration
2850         (ada_is_string_type): Likewise.
2851
2852 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2853
2854         Support style in 'frame|thread apply'
2855
2856         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2857         * record.c (record_start, record_stop): Update callers of
2858         execute_command_to_string with false.
2859         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2860         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2861         methods.
2862         (class string_file): New constructor with term_out parameter.
2863         Override methods term_out and can_emit_style_escape.  New member
2864         term_out.
2865         (class stdio_file): Override can_emit_style_escape.
2866         (class tee_file): Override term_out and can_emit_style_escape.
2867         * utils.h (can_emit_style_escape): Remove.
2868         * utils.c (can_emit_style_escape): Likewise.
2869         Update all callers of can_emit_style_escape (SOMESTREAM) to
2870         SOMESTREAM->can_emit_style_escape.
2871         * source-cache.c (source_cache::get_source_lines): Likewise.
2872         * stack.c (frame_apply_command_count): Call execute_command_to_string
2873         passing the term_out characteristic of the current gdb_stdout.
2874         * thread.c (thr_try_catch_cmd): Likewise.
2875         * top.c (execute_command_to_string): pass term_out parameter
2876         to construct the string_file for the command output.
2877         * ui-file.c (term_cli_styling): New function (most code moved
2878         from utils.c can_emit_style_escape).
2879         (string_file::string_file, string_file::can_emit_style_escape,
2880         stdio_file::can_emit_style_escape, tee_file::term_out,
2881         tee_file::can_emit_style_escape): New functions.
2882
2883 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2884
2885         * NEWS: Mention the new set|show may-call-functions.
2886         * infcall.c (may_call_functions_p): New variable.
2887         (show_may_call_functions_p): New function.
2888         (call_function_by_hand_dummy): Throws an error if not
2889         may-call-functions.
2890         (_initialize_infcall): Call add_setshow_boolean_cmd for
2891         may-call-functions.
2892
2893 2019-04-25  Keith Seitz  <keiths@redhat.com>
2894
2895         PR c++/24367
2896         * cp-support.c (inspect_type): Don't attempt substitutions
2897         of symbol with the same name.
2898
2899 2019-04-25  Tom Tromey  <tromey@adacore.com>
2900
2901         PR gdb/24475:
2902         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2903         static.
2904
2905 2019-04-25  Tom Tromey  <tromey@adacore.com>
2906
2907         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2908         rvalue reference.
2909         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2910         (gdb_xml_parser::parse): Use std::move.
2911         * python/python-internal.h (gdbpy_convert_exception): Take a const
2912         reference.
2913         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2914         std::move.
2915         * python/py-utils.c (gdbpy_convert_exception): Take a const
2916         reference.
2917         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2918         Use std::move.
2919         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2920         Use std::move.
2921         * mi/mi-main.c (mi_print_exception): Take a const reference.
2922         * main.c (handle_command_errors): Take a const reference.
2923         * linespec.c (parse_linespec): Use std::move.
2924         * infcall.c (run_inferior_call): Use std::move.
2925         (call_function_by_hand_dummy): Use std::move.
2926         * exec.c (try_open_exec_file): Use std::move.
2927         * exceptions.h (exception_print, exception_fprintf)
2928         (exception_print_same): Update.
2929         * exceptions.c (print_exception, exception_print)
2930         (exception_fprintf, exception_print_same): Change parameters to
2931         const reference.
2932         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2933         * common/new-op.c: Use std::move.
2934         * common/common-exceptions.h (struct gdb_exception): Add move
2935         constructor.
2936         (struct gdb_exception_error, struct gdb_exception_quit, struct
2937         gdb_quit_bad_alloc): Change constructor to move constructor.
2938         (throw_exception): Change parameter to rvalue reference.
2939         * common/common-exceptions.c (throw_exception): Take rvalue
2940         reference.
2941         * cli/cli-interp.c (safe_execute_command): Use std::move.
2942         * breakpoint.c (insert_bp_location, location_to_sals): Use
2943         std::move.
2944
2945 2019-04-25  Tom Tromey  <tromey@adacore.com>
2946
2947         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2948         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2949         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2950         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2951         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2952         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2953         guile/scm-value.c: Use unpack.
2954         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2955         gdbscm_gdb_exception.
2956         (gdbscm_throw_gdb_exception): Likewise.
2957         (struct gdbscm_gdb_exception): New.
2958         (unpack): New function.
2959         (gdbscm_wrap): Use unpack.
2960
2961 2019-04-25  Tom Tromey  <tromey@adacore.com>
2962
2963         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2964         (gdb_rl_callback_handler): Use std::move.
2965         * common/common-exceptions.h (struct gdb_exception): Add move
2966         assignment operator.
2967         (throw_exception_sjlj): Change "exception" to const reference.
2968         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2969         (throw_exception_sjlj): Change "exception" to const reference.
2970
2971 2019-04-25  Tom Tromey  <tromey@adacore.com>
2972
2973         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2974         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2975         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2976         Update.
2977         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2978         Update.
2979         * mi/mi-interp.c (mi_interp::exec): Update.
2980         * linespec.c (parse_linespec): Update.
2981         * infcall.c (run_inferior_call): Update.
2982         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2983         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2984         (gdbscm_lookup_global_symbol): Update.
2985         * guile/scm-param.c (gdbscm_parameter_value): Update.
2986         * guile/scm-frame.c (gdbscm_frame_read_register)
2987         (gdbscm_frame_read_var): Update.
2988         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2989         * exec.c (try_open_exec_file): Update.
2990         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2991         (gdb_rl_callback_handler): Update.
2992         * common/common-exceptions.h (exception_none): Don't declare.
2993         * common/common-exceptions.c (exception_none): Don't define.
2994         (struct catcher) <exception>: Update.
2995         * cli/cli-interp.c (safe_execute_command): Update.
2996         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2997
2998 2019-04-25  Ali Tamur  <tamur@google.com>
2999
3000         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3001         (read_attribute_value): Likewise.
3002         (dwarf2_read_addr_index): Update comment.
3003         (read_str_index): Add DW_FORM_strx.
3004         (dwarf2_string_attr): Likewise.
3005         (dwarf2_const_value_attr): Likewise.
3006         (dump_die_shallow): Likewise.
3007         (dwarf2_fetch_constant_bytes): Likewise.
3008         (skip_form_bytes): Likewise.
3009         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3010
3011 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3012
3013         PR corefiles/11608
3014         PR corefiles/18187
3015         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3016         OFFSET.  Verify if current mapping contains an ELF header.
3017         (linux_find_memory_regions_full): Adjust call to
3018         dump_mapping_p.
3019
3020 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3021             Kang Li <kanglictf@gmail.com>
3022
3023         PR gdb/21600
3024
3025         * dwarf2-frame.c (read_initial_length): Be consistent about using
3026         unsigned representation of length.
3027         (decode_frame_entry_1): Likewise.  Check for wraparound of
3028         end pointer as well as buffer overflow.
3029
3030 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3031
3032         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3033         "vq".
3034
3035 2019-04-24  Tom Tromey  <tromey@adacore.com>
3036
3037         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3038
3039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * s12z-tdep.c (s12z_unwind_pc): Delete.
3042         (s12z_unwind_sp): Delete.
3043         (s12z_gdbarch_init): Don't register deleted functions with
3044         gdbarch.
3045
3046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * rl78-tdep.c (rl78_unwind_sp): Delete.
3049         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3050
3051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3054         (xstormy16_unwind_pc): Delete.
3055         (xstormy16_dummy_id): Delete.
3056         (xstormy16_gdbarch_init): Don't register deleted functions with
3057         gdbarch.
3058
3059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * vax-tdep.c (vax_unwind_pc): Delete.
3062         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3063
3064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * v850-tdep.c (v850_unwind_sp): Delete.
3067         (v850_unwind_pc): Delete.
3068         (v850_dummy_id): Delete.
3069         (v850_gdbarch_init): Don't register deleted functions with
3070         gdbarch.
3071
3072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3075         (tilegx_unwind_pc): Delete.
3076         (tilegx_unwind_dummy_id): Delete.
3077         (tilegx_gdbarch_init): Don't register deleted functions with
3078         gdbarch.
3079
3080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3083         (tic6x_dummy_id): Delete.
3084         (tic6x_gdbarch_init): Don't register deleted functions with
3085         gdbarch.
3086
3087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * sparc-tdep.c (sparc_unwind_pc): Delete.
3090         (sparc32_gdbarch_init): Don't register deleted function with
3091         gdbarch.
3092
3093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * sh-tdep.c (sh_unwind_sp): Delete.
3096         (sh_unwind_pc): Delete.
3097         (sh_dummy_id): Delete.
3098         (sh_gdbarch_init): Don't register deleted functions with
3099         gdbarch.
3100
3101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3102
3103         * score-tdep.c (score_unwind_sp): Delete.
3104         (score_unwind_pc): Delete.
3105         (score_dummy_id): Delete.
3106         (score_gdbarch_init): Don't register deleted functions with
3107         gdbarch.
3108
3109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * rx-tdep.c (rx_unwind_pc): Delete.
3112         (rx_unwind_sp): Delete.
3113         (rx_dummy_id): Delete.
3114         (rx_gdbarch_init): Don't register deleted functions with
3115         gdbarch.  Update comment.
3116
3117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3120         (rs6000_dummy_id): Delete.
3121         (rs6000_gdbarch_init): Don't register deleted functions with
3122         gdbarch.
3123
3124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * or1k-tdep.c (or1k_dummy_id): Delete.
3127         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3128
3129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * nios2-tdep.c (nios2_dummy_id): Delete.
3132         (nios2_unwind_sp): Delete.
3133         (nios2_gdbarch_init): Don't register deleted functions with
3134         gdbarch.
3135
3136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * nds32-tdep.c (nds32_dummy_id): Delete.
3139         (nds32_unwind_pc): Delete.
3140         (nds32_unwind_sp): Delete.
3141         (nds32_gdbarch_init): Don't register deleted functions with
3142         gdbarch.
3143
3144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * msp430-tdep.c (msp430_unwind_pc): Delete.
3147         (msp430_unwind_sp): Delete.
3148         (msp430_dummy_id): Delete.
3149         (msp430_gdbarch_init): Don't register deleted functions with
3150         gdbarch.
3151
3152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3153
3154         * moxie-tdep.c (moxie_unwind_sp): Delete.
3155         (moxie_unwind_pc): Delete.
3156         (moxie_dummy_id): Delete.
3157         (moxie_gdbarch_init): Don't register deleted functions with
3158         gdbarch.
3159
3160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3163         (mn10300_unwind_pc): Delete.
3164         (mn10300_unwind_sp): Delete.
3165         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3166         mn10300_unwind_sp.
3167         (mn10300_frame_unwind_init): Don't register deleted functions with
3168         gdbarch.
3169
3170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3171
3172         * mep-tdep.c (mep_unwind_pc): Delete.
3173         (mep_unwind_sp): Delete.
3174         (mep_dummy_id): Delete.
3175         (mep_gdbarch_init): Don't register deleted functions with
3176         gdbarch.
3177
3178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3181         (m68hc11_unwind_sp): Delete.
3182         (m68hc11_gdbarch_init): Don't register deleted functions with
3183         gdbarch.
3184
3185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * m32r-tdep.c (m32r_unwind_sp): Delete.
3188         (m32r_unwind_pc): Delete.
3189         (m32r_dummy_id): Delete.
3190         (m32r_gdbarch_init): Don't register deleted functions with
3191         gdbarch.
3192
3193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3194
3195         * m32c-tdep.c (m32c_unwind_pc): Delete.
3196         (m32c_unwind_sp): Delete.
3197         (m32c_dummy_id): Delete.
3198         (m32c_gdbarch_init): Don't register deleted functions with
3199         gdbarch.
3200
3201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3204         (lm32_unwind_pc): Delete.
3205         (lm32_dummy_id): Delete.
3206         (lm32_gdbarch_init): Don't register deleted functions with
3207         gdbarch.
3208
3209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3212         (iq2000_unwind_pc): Delete.
3213         (iq2000_dummy_id): Delete.
3214         (iq2000_gdbarch_init): Don't register deleted functions with
3215         gdbarch.
3216
3217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         * nds32-tdep.c (nds32_type_align): Delete.
3220         (nds32_push_dummy_call): Use type_align instead.
3221
3222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * arm-tdep.c (arm_type_align): Only handle vector override case.
3225         (arm_push_dummy_call): Use type_align.
3226         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3227
3228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3229
3230         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3231         case.
3232         (pass_on_stack): Use type_align.
3233         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3234         function.
3235
3236 2019-04-23  Tom Tromey  <tromey@adacore.com>
3237
3238         * dwarf2read.c (line_header::file_name_at): Remove unused
3239         overload.
3240
3241 2019-04-23  Tom de Vries  <tdevries@suse.de>
3242
3243         PR gdb/24438
3244         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3245         invocation.
3246
3247
3248 2019-03-27  Ali Tamur  <tamur@google.com>
3249
3250         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3251         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3252         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3253         (dwarf_expr_context::get_addr_index): Likewise
3254         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3255         (symbol_needs_eval_context::get_addr_index): Likewise
3256         (disassemble_dwarf_expression): Add DW_OP_addrx
3257         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3258         (read_cutu_die_from_dwo): Update comment
3259         (skip_one_die): Add DW_FORM_addrx
3260         (read_attribute_value): Likewise
3261         (var_decode_location): Add DW_OP_addrx
3262         (dwarf2_const_value_attr): Add DW_FORM_addrx
3263         (dump_die_shallow): Likewise
3264         (dwarf2_fetch_constant_bytes): Likewise
3265         (decode_locdesc): Add DW_OP_addrx
3266         (skip_form_bytes): Add DW_FORM_addrx
3267
3268 2019-04-22  Ali Tamur  <tamur@google.com>
3269
3270         * MAINTAINERS (Write After Approval): Add self.
3271
3272 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3273
3274         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3275         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3276         (open_symbol_file_object): Likewise.
3277         (svr4_default_sos): Add info parameter.
3278         (svr4_read_so_list): Likewise.
3279         (svr4_current_sos_direct): Adjust functions calls to pass down
3280         info.
3281         (svr4_current_sos_1): Add info parameter.
3282         (svr4_current_sos): Call get_svr4_info, pass info down to
3283         svr4_current_sos_1.
3284         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3285         get_svr4_info.
3286         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3287         get_svr4_info.
3288         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3289         to get_svr4_info.
3290         (probes_table_remove_objfile_probes): Likewise.
3291         (register_solib_event_probe): Add info parameter.
3292         (solist_update_incremental): Pass info parameter down to
3293         svr4_read_so_list.
3294         (disable_probes_interface): Add info parameter.
3295         (svr4_handle_solib_event): Pass current_program_space to
3296         get_svr4_info.  Adjust disable_probes_interface cleanup.
3297         (svr4_create_probe_breakpoints): Add info parameter, pass it
3298         down to register_solib_event_probe.
3299         (svr4_create_solib_event_breakpoints): Add info parameter,
3300         pass it down to svr4_create_probe_breakpoints.
3301         (enable_break): Pass info down to
3302         svr4_create_solib_event_breakpoints.
3303         (svr4_solib_create_inferior_hook): Pass current_program_space to
3304         get_svr4_info.
3305         (svr4_clear_solib): Likewise.
3306
3307 2019-04-22  Pedro Alves  <palves@redhat.com>
3308
3309         * solib-svr4.c (svr4_free_objfile_observer): New.
3310         (probe_and_action::objfile): New field.
3311         (probes_table_htab_remove_objfile_probes)
3312         (probes_table_remove_objfile_probes): New functions.
3313         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3314         in the new probe_and_action.  Don't store the probe in 'lookup'.
3315         (svr4_create_probe_breakpoints): Pass objfile to
3316         register_solib_event_probe.
3317         (_initialize_svr4_solib): Register a free_objfile observer.
3318
3319 2019-04-19  Tom Tromey  <tom@tromey.com>
3320
3321         * common/queue.h: Remove.
3322
3323 2019-04-19  Tom Tromey  <tom@tromey.com>
3324
3325         * event-loop.c: Don't include "common/queue.h".
3326
3327 2019-04-19  Tom Tromey  <tom@tromey.com>
3328
3329         * remote.c (remote_target): Use delete.
3330         * remote-notif.h: Include <list>, not "common/queue.h".
3331         (notif_client_p): Remove typedef.
3332         (remote_notif_state): Add constructor, destructor, initializer.
3333         <notif_queue>: Now a std::list.
3334         (remote_notif_state_xfree): Don't declare.
3335         * remote-notif.c (remote_notif_process, handle_notification)
3336         (remote_notif_state_allocate): Update.
3337         (~remote_notif_state): Rename from remote_notif_state_xfree.
3338
3339 2019-04-19  Tom Tromey  <tom@tromey.com>
3340
3341         * symfile.c (reread_symbols): Update.
3342         * objfiles.c (objfile_register_static_link)
3343         (objfile_lookup_static_link): Update
3344         (~objfile) Don't delete static_links.
3345         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3346
3347 2019-04-19  Tom Tromey  <tom@tromey.com>
3348
3349         * type-stack.h (struct type_stack) <insert>: Constify string.
3350         * type-stack.c (type_stack::insert): Constify string.
3351         * gdbtypes.h (lookup_template_type): Update.
3352         (address_space_name_to_int): Update.
3353         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3354         const.
3355         (lookup_template_type): Make name const.
3356         * c-exp.y: Update rules.
3357         (lex_one_token, classify_name, classify_inner_name)
3358         (c_print_token): Update.
3359         * p-exp.y: Update rules.
3360         (yylex): Update.
3361         * f-exp.y: Update rules.
3362         (yylex): Update.
3363         * d-exp.y: Update rules.
3364         (lex_one_token, classify_name, classify_inner_name): Update.
3365         * parse.c (write_dollar_variable, copy_name): Return std::string.
3366         * parser-defs.h (copy_name): Change return type.
3367         * m2-exp.y: Update rules.
3368         (yylex): Update.
3369         * go-exp.y (lex_one_token): Update.
3370         Update rules.
3371         (classify_unsafe_function, classify_packaged_name)
3372         (classify_name, yylex): Update.
3373
3374 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3375
3376         * configure.ac: add --enable-source-highlight switch.
3377         * configure: Regenerate.
3378         * top.c (print_gdb_version): plumb --enable-source-highlight
3379         status to "show configuration".
3380
3381 2019-04-19  Tom Tromey  <tromey@adacore.com>
3382
3383         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3384         Check ADA_TYPE_P.
3385         (empty_record, ada_template_to_fixed_record_type_1)
3386         (template_to_static_fixed_type)
3387         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3388         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3389         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3390         macros.
3391
3392 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3393
3394         PR symtab/24423:
3395         * source.c (print_source_lines_base): Advance "iter" when a
3396         control character is seen.
3397
3398 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * inferior.h (struct infcall_suspend_state_deleter):
3401         Catch exception in destructor to avoid crash.
3402
3403 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3404
3405         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3406         close to the add_com "shell".
3407
3408 2019-04-18  Tom Tromey  <tromey@adacore.com>
3409
3410         * process-stratum-target.h (class process_stratum_target)
3411         <stratum>: Add "final".
3412
3413 2019-04-17  Tom Tromey  <tromey@adacore.com>
3414
3415         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3416         against nullptr before use.
3417
3418 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3419
3420         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3421
3422 2019-04-17  Jim Wilson  <jimw@sifive.com>
3423             Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3426         code read might fail, assume 4-byte breakpoint in that case.
3427
3428 2019-04-15  Leszek Swirski  <leszeks@google.com>
3429
3430         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3431         rather than a hand-rolled POD check when checking for forced MEMORY
3432         classification.
3433
3434 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3435
3436         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3437         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3438         function.
3439         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3440         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3441         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3442         declaration.
3443
3444 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3445
3446         * aarch64-linux-nat.c
3447         (aarch64_linux_nat_target::thread_architecture): Add override.
3448         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3449         each VQ.
3450
3451 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3454
3455 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3458         target types of size 96-bits, add some additional comments, and
3459         check that the builtin type we found was the correct size.
3460
3461 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3462
3463         * utils.c (prompt_for_continue): Don't restore the styling at the
3464         end, as applied_style has the wrong value.  This fixes styling in
3465         long lists of file names that are interrupted by the "Continue?"
3466         prompt.
3467
3468 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3471         * c-lang.c (c_language_defn): Likewise.
3472         (cplus_language_defn): Likewise.
3473         (asm_language_defn): Likewise.
3474         (minimal_language_defn): Likewise.
3475         * d-lang.c (d_language_defn): Likewise.
3476         * f-lang.c (f_language_defn): Likewise.
3477         * go-lang.c (go_language_defn): Likewise.
3478         * language.c (unknown_language_defn): Likewise.
3479         (auto_language_defn): Likewise.
3480         * language.h (struct language_defn): Remove la_magic field.
3481         (LANG_MAGIC): Delete.
3482         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3483         * objc-lang.c (objc_language_defn): Likewise.
3484         * opencl-lang.c (opencl_language_defn): Likewise.
3485         * p-lang.c (pascal_language_defn): Likewise.
3486         * rust-lang.c (rust_language_defn): Likewise.
3487
3488 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * riscv-tdep.c (riscv_type_align): New function.
3491         (riscv_type_alignment): Delete.
3492         (riscv_arg_location): Use 'type_align'.
3493         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3494
3495 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * gdbtypes.c (type_align): A struct with no non-static fields also
3498         has alignment of 1.
3499
3500 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3503         component to 0.
3504         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3505         member.
3506         (riscv_struct_info::analyse): New implementation using new
3507         analyse_inner member function.
3508         (riscv_struct_info::field_offset): New member function.
3509         (riscv_struct_info::m_offsets): New member variable.
3510         (riscv_struct_info::analyse_inner): New private member function,
3511         takes the old implementation of riscv_struct_info::analyse but
3512         extended to track field offsets.
3513         (riscv_call_arg_struct): Update the struct folding special cases
3514         to handle cases where empty C++ structs, which are non-zero
3515         length, are found.
3516         (riscv_arg_location): Initialise the length of each location, a
3517         non-zero length now indicates the location is in use.
3518         (riscv_push_dummy_call): Allow for the first location having a
3519         non-zero offset when setting up arguments.
3520         (riscv_return_value): Likewise, but for return values.
3521
3522 2019-04-11  Tom Tromey  <tromey@adacore.com>
3523
3524         * utils.c (internal_vproblem): Make "msg" const.
3525
3526 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3527
3528         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3529         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3530         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3531         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3532
3533 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3534
3535         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3536         function.
3537         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3538         of amd64_collect_native_gregset.
3539         (amd64_linux_nat_target::store_registers): Likewise.
3540
3541 2019-04-10  Tom Tromey  <tom@tromey.com>
3542
3543         * symtab.c (lookup_global_symbol_from_objfile)
3544         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3545         * objfiles.h (class separate_debug_iterator): New.
3546         (class separate_debug_range): New.
3547         (struct objfile) <separate_debug_objfiles>: New method.
3548         (objfile_separate_debug_iterate): Don't declare.
3549         * objfiles.c (separate_debug_iterator::operator++): Rename from
3550         objfile_separate_debug_iterate.
3551         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3552         iterator.
3553         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3554         iterator.
3555
3556 2019-04-10  Tom Tromey  <tom@tromey.com>
3557
3558         * symfile.c (reread_symbols): Remove old comment.
3559         * objfiles.c (free_all_objfiles): Fix a typo.
3560
3561 2019-04-10  Tom Tromey  <tom@tromey.com>
3562
3563         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3564         * minsyms.c (lookup_minimal_symbol): Use foreach.
3565         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3566         (lookup_minimal_symbol_solib_trampoline): Likewise.
3567         * symfile.c (reread_symbols): Use foreach.
3568
3569 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3570             Tom Tromey  <tromey@adacore.com>
3571
3572         PR rust/24414:
3573         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3574         (rust_lex_int_test): Change "value" to be LONGEST.
3575         (rust_lex_tests): Add test for long integer literal.
3576
3577 2019-04-09  Tom Tromey  <tromey@adacore.com>
3578
3579         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3580         to bool.
3581         (extended_remote_target::attach): Update.
3582         (remote_target::remote_notice_new_inferior): Update.
3583         (remote_target::add_current_inferior_and_thread): Update.
3584         * inferior.c (exit_inferior_1): Use "false".
3585         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3586
3587 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3588
3589         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3590         the "start" command.
3591
3592 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3593
3594         * python/py-inferior.c (infpy_thread_from_thread_handle):
3595         Adjust comments to reflect renaming of thread_from_thread_handle
3596         to thread_from_handle.  Adjust keywords.  Fix type error message.
3597         (inferior_object_methods): Add thread_from_handle.  Retain
3598         thread_from_thread_handle, but mark it as deprecated.
3599
3600 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3601
3602         * gdbthread.h (find_thread_by_handle): Revise declaration.
3603         * thread.c (find_thread_by_handle): Likewise.  Adjust
3604         implementation too.
3605         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3606         support for buffer objects as handles.
3607
3608 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3609
3610         * python/py-infthread.c (thpy_thread_handle): New function.
3611         (thread_object_methods): Register thpy_thread_handle.
3612
3613 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3614
3615         * gdbthread.h (thread_to_thread_handle): Declare.
3616         * thread.c (gdbtypes.h): Include.
3617         (thread_to_thread_handle): New function.
3618
3619         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3620         (target_thread_info_to_thread_handle): Declare.
3621         * target.c (target_thread_info_to_thread_handle): New function.
3622         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3623         * target-delegates.c: Regenerate.
3624
3625         * linux-thread-db.c (class thread_db_target): Add method
3626         thread_info_to_thread_handle.
3627         (thread_db_target::thread_info_to_thread_handle): Define.
3628         * remote.c (class remote_target): Add new method
3629         thread_info_to_thread_handle.
3630         (remote_target::thread_info_to_thread_handle): Define.
3631
3632 2019-04-08  Pedro Alves  <palves@redhat.com>
3633
3634         * common/common-exceptions.c (throw_exception): Don't create
3635         named object to throw; throw directly.
3636         (throw_it): Likewise.  Don't initialize gdb_exception::message
3637         here, with new; pass FMT and AP to the ctor instead.
3638         * common/common-exceptions.h: Include <string>.
3639         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3640         const char *, va_list)): New ctor.  Use std::make_shared.
3641         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3642         errors)): Delete.
3643         (gdb_exception_error::gdb_exception_error(enum errors, const char
3644         *, va_list)): New.
3645         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3646         Add assertion.
3647         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3648         errors)): Delete.
3649         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3650         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3651         Add assertion.
3652
3653 2019-04-08  Tom Tromey  <tom@tromey.com>
3654
3655         * valops.c (value_rtti_indirect_type): Replace throw_exception
3656         with throw.
3657         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3658         with throw.
3659         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3660         throw.
3661         * target.c (target_translate_tls_address): Replace throw_exception
3662         with throw.
3663         * stack.c (frame_apply_command_count): Replace throw_exception
3664         with throw.
3665         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3666         throw.
3667         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3668         with throw.
3669         * rs6000-tdep.c (rs6000_frame_cache)
3670         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3671         * remote.c: Replace throw_exception with throw.
3672         * record-full.c (record_full_message, record_full_wait_1)
3673         (record_full_restore): Replace throw_exception with throw.
3674         * record-btrace.c:
3675         (get_thread_current_frame_id, record_btrace_start_replaying)
3676         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3677         (cmd_record_btrace_start): Replace throw_exception with throw.
3678         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3679         throw.
3680         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3681         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3682         * linespec.c:
3683         (find_linespec_symbols): Replace throw_exception with throw.
3684         * infrun.c (displaced_step_prepare, resume): Replace
3685         throw_exception with throw.
3686         * infcmd.c (post_create_inferior): Replace throw_exception with
3687         throw.
3688         * inf-loop.c (inferior_event_handler): Replace throw_exception
3689         with throw.
3690         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3691         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3692         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3693         (get_prev_frame_always, get_frame_pc_if_available)
3694         (get_frame_address_in_block_if_available, get_frame_language):
3695         Replace throw_exception with throw.
3696         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3697         throw_exception with throw.
3698         * eval.c (fetch_subexp_value, evaluate_var_value)
3699         (evaluate_funcall, evaluate_subexp_standard): Replace
3700         throw_exception with throw.
3701         * dwarf2loc.c (call_site_find_chain)
3702         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3703         Replace throw_exception with throw.
3704         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3705         with throw.
3706         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3707         throw.
3708         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3709         * completer.c (complete_line_internal): Replace throw_exception
3710         with throw.
3711         * compile/compile-object-run.c (compile_object_run): Replace
3712         throw_exception with throw.
3713         * cli/cli-script.c (process_next_line): Replace throw_exception
3714         with throw.
3715         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3716         (btrace_enable, btrace_maint_update_pt_packets): Replace
3717         throw_exception with throw.
3718         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3719         throw_exception with throw.
3720         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3721         throw_exception with throw.
3722         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3723         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3724         * aarch64-tdep.c (aarch64_make_prologue_cache)
3725         (aarch64_make_stub_cache): Replace throw_exception with throw.
3726
3727 2019-04-08  Tom Tromey  <tom@tromey.com>
3728
3729         * common/common-exceptions.c (throw_exception): Rename from
3730         throw_exception_cxx.  Remove old copy.  Make argument const.
3731         (throw_it): Create and throw exception objects directly.
3732         * common/common-exceptions.h (throw_exception): Make argument
3733         const.
3734         (struct gdb_exception_error): Add constructor.
3735         (struct gdb_exception_quit): Add constructor.
3736
3737 2019-04-08  Tom Tromey  <tom@tromey.com>
3738
3739         * common/common-exceptions.h (exception_rethrow): Don't declare.
3740         (TRY_SJLJ): Update comment.
3741         (TRY, CATCH, END_CATCH): Remove.
3742         * common/common-exceptions.c (exception_rethrow): Remove.
3743
3744 2019-04-08  Tom Tromey  <tom@tromey.com>
3745
3746         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3747         Remove.
3748         (gdb_exception_error): Rename from
3749         gdb_exception_RETURN_MASK_ERROR.
3750         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3751         (gdb_quit_bad_alloc): Update.
3752         * aarch64-tdep.c: Update.
3753         * ada-lang.c: Update.
3754         * ada-typeprint.c: Update.
3755         * ada-valprint.c: Update.
3756         * amd64-tdep.c: Update.
3757         * arch-utils.c: Update.
3758         * break-catch-throw.c: Update.
3759         * breakpoint.c: Update.
3760         * btrace.c: Update.
3761         * c-varobj.c: Update.
3762         * cli/cli-cmds.c: Update.
3763         * cli/cli-interp.c: Update.
3764         * cli/cli-script.c: Update.
3765         * common/common-exceptions.c: Update.
3766         * common/new-op.c: Update.
3767         * common/selftest.c: Update.
3768         * compile/compile-c-symbols.c: Update.
3769         * compile/compile-cplus-symbols.c: Update.
3770         * compile/compile-object-load.c: Update.
3771         * compile/compile-object-run.c: Update.
3772         * completer.c: Update.
3773         * corelow.c: Update.
3774         * cp-abi.c: Update.
3775         * cp-support.c: Update.
3776         * cp-valprint.c: Update.
3777         * darwin-nat.c: Update.
3778         * disasm-selftests.c: Update.
3779         * dtrace-probe.c: Update.
3780         * dwarf-index-cache.c: Update.
3781         * dwarf-index-write.c: Update.
3782         * dwarf2-frame-tailcall.c: Update.
3783         * dwarf2-frame.c: Update.
3784         * dwarf2loc.c: Update.
3785         * dwarf2read.c: Update.
3786         * eval.c: Update.
3787         * event-loop.c: Update.
3788         * event-top.c: Update.
3789         * exec.c: Update.
3790         * f-valprint.c: Update.
3791         * fbsd-tdep.c: Update.
3792         * frame-unwind.c: Update.
3793         * frame.c: Update.
3794         * gdbtypes.c: Update.
3795         * gnu-v3-abi.c: Update.
3796         * guile/guile-internal.h: Update.
3797         * guile/scm-block.c: Update.
3798         * guile/scm-breakpoint.c: Update.
3799         * guile/scm-cmd.c: Update.
3800         * guile/scm-disasm.c: Update.
3801         * guile/scm-frame.c: Update.
3802         * guile/scm-lazy-string.c: Update.
3803         * guile/scm-math.c: Update.
3804         * guile/scm-param.c: Update.
3805         * guile/scm-ports.c: Update.
3806         * guile/scm-pretty-print.c: Update.
3807         * guile/scm-symbol.c: Update.
3808         * guile/scm-symtab.c: Update.
3809         * guile/scm-type.c: Update.
3810         * guile/scm-value.c: Update.
3811         * i386-linux-tdep.c: Update.
3812         * i386-tdep.c: Update.
3813         * inf-loop.c: Update.
3814         * infcall.c: Update.
3815         * infcmd.c: Update.
3816         * infrun.c: Update.
3817         * jit.c: Update.
3818         * language.c: Update.
3819         * linespec.c: Update.
3820         * linux-fork.c: Update.
3821         * linux-nat.c: Update.
3822         * linux-tdep.c: Update.
3823         * linux-thread-db.c: Update.
3824         * main.c: Update.
3825         * mi/mi-cmd-break.c: Update.
3826         * mi/mi-cmd-stack.c: Update.
3827         * mi/mi-interp.c: Update.
3828         * mi/mi-main.c: Update.
3829         * objc-lang.c: Update.
3830         * p-valprint.c: Update.
3831         * parse.c: Update.
3832         * ppc-linux-tdep.c: Update.
3833         * printcmd.c: Update.
3834         * python/py-arch.c: Update.
3835         * python/py-breakpoint.c: Update.
3836         * python/py-cmd.c: Update.
3837         * python/py-finishbreakpoint.c: Update.
3838         * python/py-frame.c: Update.
3839         * python/py-framefilter.c: Update.
3840         * python/py-gdb-readline.c: Update.
3841         * python/py-inferior.c: Update.
3842         * python/py-infthread.c: Update.
3843         * python/py-lazy-string.c: Update.
3844         * python/py-linetable.c: Update.
3845         * python/py-objfile.c: Update.
3846         * python/py-param.c: Update.
3847         * python/py-prettyprint.c: Update.
3848         * python/py-progspace.c: Update.
3849         * python/py-record-btrace.c: Update.
3850         * python/py-record.c: Update.
3851         * python/py-symbol.c: Update.
3852         * python/py-type.c: Update.
3853         * python/py-unwind.c: Update.
3854         * python/py-utils.c: Update.
3855         * python/py-value.c: Update.
3856         * python/python.c: Update.
3857         * record-btrace.c: Update.
3858         * record-full.c: Update.
3859         * remote-fileio.c: Update.
3860         * remote.c: Update.
3861         * riscv-tdep.c: Update.
3862         * rs6000-aix-tdep.c: Update.
3863         * rs6000-tdep.c: Update.
3864         * rust-exp.y: Update.
3865         * rust-lang.c: Update.
3866         * s390-tdep.c: Update.
3867         * selftest-arch.c: Update.
3868         * solib-dsbt.c: Update.
3869         * solib-frv.c: Update.
3870         * solib-spu.c: Update.
3871         * solib-svr4.c: Update.
3872         * solib.c: Update.
3873         * sparc64-linux-tdep.c: Update.
3874         * stack.c: Update.
3875         * symfile-mem.c: Update.
3876         * symmisc.c: Update.
3877         * target.c: Update.
3878         * thread.c: Update.
3879         * top.c: Update.
3880         * tracefile-tfile.c: Update.
3881         * tui/tui.c: Update.
3882         * typeprint.c: Update.
3883         * unittests/cli-utils-selftests.c: Update.
3884         * unittests/parse-connection-spec-selftests.c: Update.
3885         * valops.c: Update.
3886         * valprint.c: Update.
3887         * value.c: Update.
3888         * varobj.c: Update.
3889         * windows-nat.c: Update.
3890         * x86-linux-nat.c: Update.
3891         * xml-support.c: Update.
3892
3893 2019-04-08  Tom Tromey  <tom@tromey.com>
3894
3895         * xml-support.c: Use C++ exception handling.
3896         * x86-linux-nat.c: Use C++ exception handling.
3897         * windows-nat.c: Use C++ exception handling.
3898         * varobj.c: Use C++ exception handling.
3899         * value.c: Use C++ exception handling.
3900         * valprint.c: Use C++ exception handling.
3901         * valops.c: Use C++ exception handling.
3902         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3903         handling.
3904         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3905         * typeprint.c: Use C++ exception handling.
3906         * tui/tui.c: Use C++ exception handling.
3907         * tracefile-tfile.c: Use C++ exception handling.
3908         * top.c: Use C++ exception handling.
3909         * thread.c: Use C++ exception handling.
3910         * target.c: Use C++ exception handling.
3911         * symmisc.c: Use C++ exception handling.
3912         * symfile-mem.c: Use C++ exception handling.
3913         * stack.c: Use C++ exception handling.
3914         * sparc64-linux-tdep.c: Use C++ exception handling.
3915         * solib.c: Use C++ exception handling.
3916         * solib-svr4.c: Use C++ exception handling.
3917         * solib-spu.c: Use C++ exception handling.
3918         * solib-frv.c: Use C++ exception handling.
3919         * solib-dsbt.c: Use C++ exception handling.
3920         * selftest-arch.c: Use C++ exception handling.
3921         * s390-tdep.c: Use C++ exception handling.
3922         * rust-lang.c: Use C++ exception handling.
3923         * rust-exp.y: Use C++ exception handling.
3924         * rs6000-tdep.c: Use C++ exception handling.
3925         * rs6000-aix-tdep.c: Use C++ exception handling.
3926         * riscv-tdep.c: Use C++ exception handling.
3927         * remote.c: Use C++ exception handling.
3928         * remote-fileio.c: Use C++ exception handling.
3929         * record-full.c: Use C++ exception handling.
3930         * record-btrace.c: Use C++ exception handling.
3931         * python/python.c: Use C++ exception handling.
3932         * python/py-value.c: Use C++ exception handling.
3933         * python/py-utils.c: Use C++ exception handling.
3934         * python/py-unwind.c: Use C++ exception handling.
3935         * python/py-type.c: Use C++ exception handling.
3936         * python/py-symbol.c: Use C++ exception handling.
3937         * python/py-record.c: Use C++ exception handling.
3938         * python/py-record-btrace.c: Use C++ exception handling.
3939         * python/py-progspace.c: Use C++ exception handling.
3940         * python/py-prettyprint.c: Use C++ exception handling.
3941         * python/py-param.c: Use C++ exception handling.
3942         * python/py-objfile.c: Use C++ exception handling.
3943         * python/py-linetable.c: Use C++ exception handling.
3944         * python/py-lazy-string.c: Use C++ exception handling.
3945         * python/py-infthread.c: Use C++ exception handling.
3946         * python/py-inferior.c: Use C++ exception handling.
3947         * python/py-gdb-readline.c: Use C++ exception handling.
3948         * python/py-framefilter.c: Use C++ exception handling.
3949         * python/py-frame.c: Use C++ exception handling.
3950         * python/py-finishbreakpoint.c: Use C++ exception handling.
3951         * python/py-cmd.c: Use C++ exception handling.
3952         * python/py-breakpoint.c: Use C++ exception handling.
3953         * python/py-arch.c: Use C++ exception handling.
3954         * printcmd.c: Use C++ exception handling.
3955         * ppc-linux-tdep.c: Use C++ exception handling.
3956         * parse.c: Use C++ exception handling.
3957         * p-valprint.c: Use C++ exception handling.
3958         * objc-lang.c: Use C++ exception handling.
3959         * mi/mi-main.c: Use C++ exception handling.
3960         * mi/mi-interp.c: Use C++ exception handling.
3961         * mi/mi-cmd-stack.c: Use C++ exception handling.
3962         * mi/mi-cmd-break.c: Use C++ exception handling.
3963         * main.c: Use C++ exception handling.
3964         * linux-thread-db.c: Use C++ exception handling.
3965         * linux-tdep.c: Use C++ exception handling.
3966         * linux-nat.c: Use C++ exception handling.
3967         * linux-fork.c: Use C++ exception handling.
3968         * linespec.c: Use C++ exception handling.
3969         * language.c: Use C++ exception handling.
3970         * jit.c: Use C++ exception handling.
3971         * infrun.c: Use C++ exception handling.
3972         * infcmd.c: Use C++ exception handling.
3973         * infcall.c: Use C++ exception handling.
3974         * inf-loop.c: Use C++ exception handling.
3975         * i386-tdep.c: Use C++ exception handling.
3976         * i386-linux-tdep.c: Use C++ exception handling.
3977         * guile/scm-value.c: Use C++ exception handling.
3978         * guile/scm-type.c: Use C++ exception handling.
3979         * guile/scm-symtab.c: Use C++ exception handling.
3980         * guile/scm-symbol.c: Use C++ exception handling.
3981         * guile/scm-pretty-print.c: Use C++ exception handling.
3982         * guile/scm-ports.c: Use C++ exception handling.
3983         * guile/scm-param.c: Use C++ exception handling.
3984         * guile/scm-math.c: Use C++ exception handling.
3985         * guile/scm-lazy-string.c: Use C++ exception handling.
3986         * guile/scm-frame.c: Use C++ exception handling.
3987         * guile/scm-disasm.c: Use C++ exception handling.
3988         * guile/scm-cmd.c: Use C++ exception handling.
3989         * guile/scm-breakpoint.c: Use C++ exception handling.
3990         * guile/scm-block.c: Use C++ exception handling.
3991         * guile/guile-internal.h: Use C++ exception handling.
3992         * gnu-v3-abi.c: Use C++ exception handling.
3993         * gdbtypes.c: Use C++ exception handling.
3994         * frame.c: Use C++ exception handling.
3995         * frame-unwind.c: Use C++ exception handling.
3996         * fbsd-tdep.c: Use C++ exception handling.
3997         * f-valprint.c: Use C++ exception handling.
3998         * exec.c: Use C++ exception handling.
3999         * event-top.c: Use C++ exception handling.
4000         * event-loop.c: Use C++ exception handling.
4001         * eval.c: Use C++ exception handling.
4002         * dwarf2read.c: Use C++ exception handling.
4003         * dwarf2loc.c: Use C++ exception handling.
4004         * dwarf2-frame.c: Use C++ exception handling.
4005         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4006         * dwarf-index-write.c: Use C++ exception handling.
4007         * dwarf-index-cache.c: Use C++ exception handling.
4008         * dtrace-probe.c: Use C++ exception handling.
4009         * disasm-selftests.c: Use C++ exception handling.
4010         * darwin-nat.c: Use C++ exception handling.
4011         * cp-valprint.c: Use C++ exception handling.
4012         * cp-support.c: Use C++ exception handling.
4013         * cp-abi.c: Use C++ exception handling.
4014         * corelow.c: Use C++ exception handling.
4015         * completer.c: Use C++ exception handling.
4016         * compile/compile-object-run.c: Use C++ exception handling.
4017         * compile/compile-object-load.c: Use C++ exception handling.
4018         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4019         * compile/compile-c-symbols.c: Use C++ exception handling.
4020         * common/selftest.c: Use C++ exception handling.
4021         * common/new-op.c: Use C++ exception handling.
4022         * cli/cli-script.c: Use C++ exception handling.
4023         * cli/cli-interp.c: Use C++ exception handling.
4024         * cli/cli-cmds.c: Use C++ exception handling.
4025         * c-varobj.c: Use C++ exception handling.
4026         * btrace.c: Use C++ exception handling.
4027         * breakpoint.c: Use C++ exception handling.
4028         * break-catch-throw.c: Use C++ exception handling.
4029         * arch-utils.c: Use C++ exception handling.
4030         * amd64-tdep.c: Use C++ exception handling.
4031         * ada-valprint.c: Use C++ exception handling.
4032         * ada-typeprint.c: Use C++ exception handling.
4033         * ada-lang.c: Use C++ exception handling.
4034         * aarch64-tdep.c: Use C++ exception handling.
4035
4036 2019-04-08  Tom Tromey  <tom@tromey.com>
4037
4038         * xml-support.c (gdb_xml_parser::parse): Update.
4039         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4040         * value.c (show_convenience): Update.
4041         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4042         (test_parse_flags_qcs): Update.
4043         * thread.c (thr_try_catch_cmd): Update.
4044         * target.c (target_translate_tls_address): Update.
4045         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4046         (info_frame_command_core, frame_apply_command_count): Update.
4047         * rust-exp.y (rust_lex_exception_test): Update.
4048         * riscv-tdep.c (riscv_print_one_register_info): Update.
4049         * remote.c (remote_target::enable_btrace): Update.
4050         * record-btrace.c (record_btrace_enable_warn): Update.
4051         * python/py-utils.c (gdbpy_convert_exception): Update.
4052         * printcmd.c (do_one_display, print_variable_and_value): Update.
4053         * mi/mi-main.c (mi_print_exception): Update.
4054         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4055         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4056         * linux-nat.c (linux_nat_target::attach): Update.
4057         * linux-fork.c (class scoped_switch_fork_info): Update.
4058         * infrun.c (displaced_step_prepare): Update.
4059         * infcall.c (call_function_by_hand_dummy): Update.
4060         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4061         * gnu-v3-abi.c (print_one_vtable): Update.
4062         * frame.c (get_prev_frame_always): Update.
4063         * f-valprint.c (info_common_command_for_block): Update.
4064         * exec.c (try_open_exec_file): Update.
4065         * exceptions.c (print_exception, exception_print)
4066         (exception_fprintf, exception_print_same): Update.
4067         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4068         * dwarf-index-cache.c (index_cache::store)
4069         (index_cache::lookup_gdb_index): Update.
4070         * darwin-nat.c (maybe_cache_shell): Update.
4071         * cp-valprint.c (cp_print_value_fields): Update.
4072         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4073         (gcc_cplus_symbol_address): Update.
4074         * compile/compile-c-symbols.c (gcc_convert_symbol)
4075         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4076         * common/selftest.c: Update.
4077         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4078         a std::string.
4079         (exception_try_scope_entry, exception_try_scope_exit): Don't
4080         declare.
4081         (struct exception_try_scope): Remove.
4082         (TRY): Don't use exception_try_scope.
4083         (struct gdb_exception): Add constructor, operator=.
4084         <what>: New method.
4085         (struct gdb_exception_RETURN_MASK_ALL)
4086         (struct gdb_exception_RETURN_MASK_ERROR)
4087         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4088         (struct gdb_quit_bad_alloc): Update.
4089         * common/common-exceptions.c (exception_none): Change
4090         initializer.
4091         (struct catcher) <state, exception>: Initialize inline.
4092         <prev>: Remove member.
4093         (current_catcher): Remove.
4094         (catchers): New global.
4095         (exceptions_state_mc_init): Simplify.
4096         (catcher_pop): Remove.
4097         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4098         (try_scope_depth, exception_try_scope_entry)
4099         (exception_try_scope_exit): Remove.
4100         (throw_exception_sjlj): Update.
4101         (exception_messages, exception_messages_size): Remove.
4102         (throw_it): Simplify.
4103         (gdb_exception_sliced_copy): Remove.
4104         (throw_exception_cxx): Update.
4105         * cli/cli-script.c (script_from_file): Update.
4106         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4107         Update.
4108         * ada-valprint.c (ada_val_print): Update.
4109         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4110         (create_excep_cond_exprs): Update.
4111
4112 2019-04-08  Tom Tromey  <tom@tromey.com>
4113
4114         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4115         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4116         (TRY, CATCH, END_CATCH): Remove some definitions.
4117         * common/common-exceptions.c: Don't use GDB_XCPT.
4118         (catcher_list_size): Remove.
4119         (throw_exception, throw_it): Simplify.
4120
4121 2019-04-05  Tom Tromey  <tom@tromey.com>
4122
4123         Revert the header-sorting patch.
4124         * ft32-tdep.c: Revert.
4125         * frv-tdep.c: Revert.
4126         * frv-linux-tdep.c: Revert.
4127         * frame.c: Revert.
4128         * frame-unwind.c: Revert.
4129         * frame-base.c: Revert.
4130         * fork-child.c: Revert.
4131         * findvar.c: Revert.
4132         * findcmd.c: Revert.
4133         * filesystem.c: Revert.
4134         * filename-seen-cache.h: Revert.
4135         * filename-seen-cache.c: Revert.
4136         * fbsd-tdep.c: Revert.
4137         * fbsd-nat.h: Revert.
4138         * fbsd-nat.c: Revert.
4139         * f-valprint.c: Revert.
4140         * f-typeprint.c: Revert.
4141         * f-lang.c: Revert.
4142         * extension.h: Revert.
4143         * extension.c: Revert.
4144         * extension-priv.h: Revert.
4145         * expprint.c: Revert.
4146         * exec.h: Revert.
4147         * exec.c: Revert.
4148         * exceptions.c: Revert.
4149         * event-top.c: Revert.
4150         * event-loop.c: Revert.
4151         * eval.c: Revert.
4152         * elfread.c: Revert.
4153         * dwarf2read.h: Revert.
4154         * dwarf2read.c: Revert.
4155         * dwarf2loc.c: Revert.
4156         * dwarf2expr.h: Revert.
4157         * dwarf2expr.c: Revert.
4158         * dwarf2-frame.c: Revert.
4159         * dwarf2-frame-tailcall.c: Revert.
4160         * dwarf-index-write.h: Revert.
4161         * dwarf-index-write.c: Revert.
4162         * dwarf-index-common.c: Revert.
4163         * dwarf-index-cache.h: Revert.
4164         * dwarf-index-cache.c: Revert.
4165         * dummy-frame.c: Revert.
4166         * dtrace-probe.c: Revert.
4167         * disasm.h: Revert.
4168         * disasm.c: Revert.
4169         * disasm-selftests.c: Revert.
4170         * dictionary.c: Revert.
4171         * dicos-tdep.c: Revert.
4172         * demangle.c: Revert.
4173         * dcache.h: Revert.
4174         * dcache.c: Revert.
4175         * darwin-nat.h: Revert.
4176         * darwin-nat.c: Revert.
4177         * darwin-nat-info.c: Revert.
4178         * d-valprint.c: Revert.
4179         * d-namespace.c: Revert.
4180         * d-lang.c: Revert.
4181         * ctf.c: Revert.
4182         * csky-tdep.c: Revert.
4183         * csky-linux-tdep.c: Revert.
4184         * cris-tdep.c: Revert.
4185         * cris-linux-tdep.c: Revert.
4186         * cp-valprint.c: Revert.
4187         * cp-support.c: Revert.
4188         * cp-namespace.c: Revert.
4189         * cp-abi.c: Revert.
4190         * corelow.c: Revert.
4191         * corefile.c: Revert.
4192         * continuations.c: Revert.
4193         * completer.h: Revert.
4194         * completer.c: Revert.
4195         * complaints.c: Revert.
4196         * coffread.c: Revert.
4197         * coff-pe-read.c: Revert.
4198         * cli-out.h: Revert.
4199         * cli-out.c: Revert.
4200         * charset.c: Revert.
4201         * c-varobj.c: Revert.
4202         * c-valprint.c: Revert.
4203         * c-typeprint.c: Revert.
4204         * c-lang.c: Revert.
4205         * buildsym.c: Revert.
4206         * buildsym-legacy.c: Revert.
4207         * build-id.h: Revert.
4208         * build-id.c: Revert.
4209         * btrace.c: Revert.
4210         * bsd-uthread.c: Revert.
4211         * breakpoint.h: Revert.
4212         * breakpoint.c: Revert.
4213         * break-catch-throw.c: Revert.
4214         * break-catch-syscall.c: Revert.
4215         * break-catch-sig.c: Revert.
4216         * blockframe.c: Revert.
4217         * block.c: Revert.
4218         * bfin-tdep.c: Revert.
4219         * bfin-linux-tdep.c: Revert.
4220         * bfd-target.c: Revert.
4221         * bcache.c: Revert.
4222         * ax-general.c: Revert.
4223         * ax-gdb.h: Revert.
4224         * ax-gdb.c: Revert.
4225         * avr-tdep.c: Revert.
4226         * auxv.c: Revert.
4227         * auto-load.c: Revert.
4228         * arm-wince-tdep.c: Revert.
4229         * arm-tdep.c: Revert.
4230         * arm-symbian-tdep.c: Revert.
4231         * arm-pikeos-tdep.c: Revert.
4232         * arm-obsd-tdep.c: Revert.
4233         * arm-nbsd-tdep.c: Revert.
4234         * arm-nbsd-nat.c: Revert.
4235         * arm-linux-tdep.c: Revert.
4236         * arm-linux-nat.c: Revert.
4237         * arm-fbsd-tdep.c: Revert.
4238         * arm-fbsd-nat.c: Revert.
4239         * arm-bsd-tdep.c: Revert.
4240         * arch-utils.c: Revert.
4241         * arc-tdep.c: Revert.
4242         * arc-newlib-tdep.c: Revert.
4243         * annotate.h: Revert.
4244         * annotate.c: Revert.
4245         * amd64-windows-tdep.c: Revert.
4246         * amd64-windows-nat.c: Revert.
4247         * amd64-tdep.c: Revert.
4248         * amd64-sol2-tdep.c: Revert.
4249         * amd64-obsd-tdep.c: Revert.
4250         * amd64-obsd-nat.c: Revert.
4251         * amd64-nbsd-tdep.c: Revert.
4252         * amd64-nbsd-nat.c: Revert.
4253         * amd64-nat.c: Revert.
4254         * amd64-linux-tdep.c: Revert.
4255         * amd64-linux-nat.c: Revert.
4256         * amd64-fbsd-tdep.c: Revert.
4257         * amd64-fbsd-nat.c: Revert.
4258         * amd64-dicos-tdep.c: Revert.
4259         * amd64-darwin-tdep.c: Revert.
4260         * amd64-bsd-nat.c: Revert.
4261         * alpha-tdep.c: Revert.
4262         * alpha-obsd-tdep.c: Revert.
4263         * alpha-nbsd-tdep.c: Revert.
4264         * alpha-mdebug-tdep.c: Revert.
4265         * alpha-linux-tdep.c: Revert.
4266         * alpha-linux-nat.c: Revert.
4267         * alpha-bsd-tdep.c: Revert.
4268         * alpha-bsd-nat.c: Revert.
4269         * aix-thread.c: Revert.
4270         * agent.c: Revert.
4271         * addrmap.c: Revert.
4272         * ada-varobj.c: Revert.
4273         * ada-valprint.c: Revert.
4274         * ada-typeprint.c: Revert.
4275         * ada-tasks.c: Revert.
4276         * ada-lang.c: Revert.
4277         * aarch64-tdep.c: Revert.
4278         * aarch64-ravenscar-thread.c: Revert.
4279         * aarch64-newlib-tdep.c: Revert.
4280         * aarch64-linux-tdep.c: Revert.
4281         * aarch64-linux-nat.c: Revert.
4282         * aarch64-fbsd-tdep.c: Revert.
4283         * aarch64-fbsd-nat.c: Revert.
4284         * aarch32-linux-nat.c: Revert.
4285
4286 2019-04-05  Tom Tromey  <tom@tromey.com>
4287
4288         * ft32-tdep.c: Sort headers.
4289         * frv-tdep.c: Sort headers.
4290         * frv-linux-tdep.c: Sort headers.
4291         * frame.c: Sort headers.
4292         * frame-unwind.c: Sort headers.
4293         * frame-base.c: Sort headers.
4294         * fork-child.c: Sort headers.
4295         * findvar.c: Sort headers.
4296         * findcmd.c: Sort headers.
4297         * filesystem.c: Sort headers.
4298         * filename-seen-cache.h: Sort headers.
4299         * filename-seen-cache.c: Sort headers.
4300         * fbsd-tdep.c: Sort headers.
4301         * fbsd-nat.h: Sort headers.
4302         * fbsd-nat.c: Sort headers.
4303         * f-valprint.c: Sort headers.
4304         * f-typeprint.c: Sort headers.
4305         * f-lang.c: Sort headers.
4306         * extension.h: Sort headers.
4307         * extension.c: Sort headers.
4308         * extension-priv.h: Sort headers.
4309         * expprint.c: Sort headers.
4310         * exec.h: Sort headers.
4311         * exec.c: Sort headers.
4312         * exceptions.c: Sort headers.
4313         * event-top.c: Sort headers.
4314         * event-loop.c: Sort headers.
4315         * eval.c: Sort headers.
4316         * elfread.c: Sort headers.
4317         * dwarf2read.h: Sort headers.
4318         * dwarf2read.c: Sort headers.
4319         * dwarf2loc.c: Sort headers.
4320         * dwarf2expr.h: Sort headers.
4321         * dwarf2expr.c: Sort headers.
4322         * dwarf2-frame.c: Sort headers.
4323         * dwarf2-frame-tailcall.c: Sort headers.
4324         * dwarf-index-write.h: Sort headers.
4325         * dwarf-index-write.c: Sort headers.
4326         * dwarf-index-common.c: Sort headers.
4327         * dwarf-index-cache.h: Sort headers.
4328         * dwarf-index-cache.c: Sort headers.
4329         * dummy-frame.c: Sort headers.
4330         * dtrace-probe.c: Sort headers.
4331         * disasm.h: Sort headers.
4332         * disasm.c: Sort headers.
4333         * disasm-selftests.c: Sort headers.
4334         * dictionary.c: Sort headers.
4335         * dicos-tdep.c: Sort headers.
4336         * demangle.c: Sort headers.
4337         * dcache.h: Sort headers.
4338         * dcache.c: Sort headers.
4339         * darwin-nat.h: Sort headers.
4340         * darwin-nat.c: Sort headers.
4341         * darwin-nat-info.c: Sort headers.
4342         * d-valprint.c: Sort headers.
4343         * d-namespace.c: Sort headers.
4344         * d-lang.c: Sort headers.
4345         * ctf.c: Sort headers.
4346         * csky-tdep.c: Sort headers.
4347         * csky-linux-tdep.c: Sort headers.
4348         * cris-tdep.c: Sort headers.
4349         * cris-linux-tdep.c: Sort headers.
4350         * cp-valprint.c: Sort headers.
4351         * cp-support.c: Sort headers.
4352         * cp-namespace.c: Sort headers.
4353         * cp-abi.c: Sort headers.
4354         * corelow.c: Sort headers.
4355         * corefile.c: Sort headers.
4356         * continuations.c: Sort headers.
4357         * completer.h: Sort headers.
4358         * completer.c: Sort headers.
4359         * complaints.c: Sort headers.
4360         * coffread.c: Sort headers.
4361         * coff-pe-read.c: Sort headers.
4362         * cli-out.h: Sort headers.
4363         * cli-out.c: Sort headers.
4364         * charset.c: Sort headers.
4365         * c-varobj.c: Sort headers.
4366         * c-valprint.c: Sort headers.
4367         * c-typeprint.c: Sort headers.
4368         * c-lang.c: Sort headers.
4369         * buildsym.c: Sort headers.
4370         * buildsym-legacy.c: Sort headers.
4371         * build-id.h: Sort headers.
4372         * build-id.c: Sort headers.
4373         * btrace.c: Sort headers.
4374         * bsd-uthread.c: Sort headers.
4375         * breakpoint.h: Sort headers.
4376         * breakpoint.c: Sort headers.
4377         * break-catch-throw.c: Sort headers.
4378         * break-catch-syscall.c: Sort headers.
4379         * break-catch-sig.c: Sort headers.
4380         * blockframe.c: Sort headers.
4381         * block.c: Sort headers.
4382         * bfin-tdep.c: Sort headers.
4383         * bfin-linux-tdep.c: Sort headers.
4384         * bfd-target.c: Sort headers.
4385         * bcache.c: Sort headers.
4386         * ax-general.c: Sort headers.
4387         * ax-gdb.h: Sort headers.
4388         * ax-gdb.c: Sort headers.
4389         * avr-tdep.c: Sort headers.
4390         * auxv.c: Sort headers.
4391         * auto-load.c: Sort headers.
4392         * arm-wince-tdep.c: Sort headers.
4393         * arm-tdep.c: Sort headers.
4394         * arm-symbian-tdep.c: Sort headers.
4395         * arm-pikeos-tdep.c: Sort headers.
4396         * arm-obsd-tdep.c: Sort headers.
4397         * arm-nbsd-tdep.c: Sort headers.
4398         * arm-nbsd-nat.c: Sort headers.
4399         * arm-linux-tdep.c: Sort headers.
4400         * arm-linux-nat.c: Sort headers.
4401         * arm-fbsd-tdep.c: Sort headers.
4402         * arm-fbsd-nat.c: Sort headers.
4403         * arm-bsd-tdep.c: Sort headers.
4404         * arch-utils.c: Sort headers.
4405         * arc-tdep.c: Sort headers.
4406         * arc-newlib-tdep.c: Sort headers.
4407         * annotate.h: Sort headers.
4408         * annotate.c: Sort headers.
4409         * amd64-windows-tdep.c: Sort headers.
4410         * amd64-windows-nat.c: Sort headers.
4411         * amd64-tdep.c: Sort headers.
4412         * amd64-sol2-tdep.c: Sort headers.
4413         * amd64-obsd-tdep.c: Sort headers.
4414         * amd64-obsd-nat.c: Sort headers.
4415         * amd64-nbsd-tdep.c: Sort headers.
4416         * amd64-nbsd-nat.c: Sort headers.
4417         * amd64-nat.c: Sort headers.
4418         * amd64-linux-tdep.c: Sort headers.
4419         * amd64-linux-nat.c: Sort headers.
4420         * amd64-fbsd-tdep.c: Sort headers.
4421         * amd64-fbsd-nat.c: Sort headers.
4422         * amd64-dicos-tdep.c: Sort headers.
4423         * amd64-darwin-tdep.c: Sort headers.
4424         * amd64-bsd-nat.c: Sort headers.
4425         * alpha-tdep.c: Sort headers.
4426         * alpha-obsd-tdep.c: Sort headers.
4427         * alpha-nbsd-tdep.c: Sort headers.
4428         * alpha-mdebug-tdep.c: Sort headers.
4429         * alpha-linux-tdep.c: Sort headers.
4430         * alpha-linux-nat.c: Sort headers.
4431         * alpha-bsd-tdep.c: Sort headers.
4432         * alpha-bsd-nat.c: Sort headers.
4433         * aix-thread.c: Sort headers.
4434         * agent.c: Sort headers.
4435         * addrmap.c: Sort headers.
4436         * ada-varobj.c: Sort headers.
4437         * ada-valprint.c: Sort headers.
4438         * ada-typeprint.c: Sort headers.
4439         * ada-tasks.c: Sort headers.
4440         * ada-lang.c: Sort headers.
4441         * aarch64-tdep.c: Sort headers.
4442         * aarch64-ravenscar-thread.c: Sort headers.
4443         * aarch64-newlib-tdep.c: Sort headers.
4444         * aarch64-linux-tdep.c: Sort headers.
4445         * aarch64-linux-nat.c: Sort headers.
4446         * aarch64-fbsd-tdep.c: Sort headers.
4447         * aarch64-fbsd-nat.c: Sort headers.
4448         * aarch32-linux-nat.c: Sort headers.
4449
4450 2019-04-04  Tom Tromey  <tom@tromey.com>
4451
4452         * varobj.c (varobj_create): Update.
4453         * rust-exp.y (struct rust_parser) <update_innermost_block,
4454         lookup_symbol>: New methods.
4455         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4456         Rename.
4457         (rust_parser::rust_lookup_type)
4458         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4459         * printcmd.c (display_command, do_one_display): Update.
4460         * parser-defs.h (struct parser_state) <parser_state>: Add
4461         "tracker" parameter.
4462         (block_tracker): New member.
4463         (class innermost_block_tracker) <innermost_block_tracker>: Add
4464         "types" parameter.
4465         <reset>: Remove method.
4466         (innermost_block): Don't declare.
4467         (null_post_parser): Update.
4468         * parse.c (innermost_block): Remove global.
4469         (write_dollar_variable): Update.
4470         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4471         Remove "tracker_types" parameter.
4472         (parse_expression): Add "tracker" parameter.
4473         (parse_expression_for_completion): Update.
4474         (null_post_parser): Add "tracker" parameter.
4475         * p-exp.y: Update rules.
4476         * m2-exp.y: Update rules.
4477         * language.h (struct language_defn) <la_post_parser>: Add
4478         "tracker" parameter.
4479         * go-exp.y: Update rules.
4480         * f-exp.y: Update rules.
4481         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4482         parameter.
4483         * d-exp.y: Update rules.
4484         * c-exp.y: Update rules.
4485         * breakpoint.c (set_breakpoint_condition): Create an
4486         innermost_block_tracker.
4487         (watch_command_1): Likewise.
4488         * ada-lang.c (resolve): Add "tracker" parameter.
4489         (resolve_subexp): Likewise.
4490         * ada-exp.y (write_var_from_sym): Update.
4491
4492 2019-04-04  Tom Tromey  <tom@tromey.com>
4493
4494         * type-stack.h: New file.
4495         * type-stack.c: New file.
4496         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4497         type-stack.h.
4498         (insert_into_type_stack, insert_type, push_type, push_type_int)
4499         (insert_type_address_space, pop_type, pop_type_int)
4500         (pop_typelist, pop_type_stack, append_type_stack)
4501         (push_type_stack, get_type_stack, push_typelist)
4502         (follow_type_instance_flags, follow_types): Don't declare.
4503         * parse.c (type_stack): Remove global.
4504         (parse_exp_in_context): Update.
4505         (insert_into_type_stack, insert_type, push_type, push_type_int)
4506         (insert_type_address_space, pop_type, pop_type_int)
4507         (pop_typelist, pop_type_stack, append_type_stack)
4508         (push_type_stack, get_type_stack, push_typelist)
4509         (follow_type_instance_flags, follow_types): Remove (moved to
4510         type-stack.c).
4511         * f-exp.y (type_stack): New global.
4512         Update rules.
4513         (push_kind_type, f_parse): Update.
4514         * d-exp.y (type_stack): New global.
4515         Update rules.
4516         (d_parse): Update.
4517         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4518         Update rules.
4519         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4520         (HFILES_NO_SRCDIR): Add type-stack.h.
4521
4522 2019-04-04  Tom Tromey  <tom@tromey.com>
4523
4524         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4525         (rust_parser::convert_ast_to_expression, rust_parse)
4526         (rust_lex_test_completion, rust_lex_tests): Update.
4527         * parser-defs.h (struct expr_completion_state): New.
4528         (struct parser_state) <parser_state>: Add completion parameter.
4529         <mark_struct_expression, mark_completion_tag>: New methods.
4530         <parse_completion, m_completion_state>: New members.
4531         (prefixify_expression, null_post_parser): Update.
4532         (mark_struct_expression, mark_completion_tag): Don't declare.
4533         * parse.c (parse_completion, expout_last_struct)
4534         (expout_tag_completion_type, expout_completion_name): Remove
4535         globals.
4536         (parser_state::mark_struct_expression)
4537         (parser_state::mark_completion_tag): Now methods.
4538         (prefixify_expression): Add last_struct parameter.
4539         (prefixify_subexp): Likewise.
4540         (parse_exp_1): Update.
4541         (parse_exp_in_context): Add cstate parameter.  Update.
4542         (parse_expression_for_completion): Create an
4543         expr_completion_state.
4544         (null_post_parser): Add "completion" parameter.
4545         * p-exp.y: Update rules.
4546         (yylex): Update.
4547         * language.h (struct language_defn) <la_post_parser>: Add
4548         "completing" parameter.
4549         * go-exp.y: Update rules.
4550         (lex_one_token): Update.
4551         * expression.h (parse_completion): Don't declare.
4552         * d-exp.y: Update rules.
4553         (lex_one_token): Update rules.
4554         * c-exp.y: Update rules.
4555         (lex_one_token): Update.
4556         * ada-lang.c (resolve): Add "parse_completion" parameter.
4557         (resolve_subexp): Likewise.
4558         (ada_resolve_function): Likewise.
4559
4560 2019-04-04  Tom Tromey  <tom@tromey.com>
4561
4562         * parser-defs.h (struct parser_state) <start_arglist,
4563         end_arglist>: New methods.
4564         <arglist_len, m_funcall_chain>: New members.
4565         (arglist_len, start_arglist, end_arglist): Don't declare.
4566         * parse.c (arglist_len, funcall_chain): Remove global.
4567         (start_arglist, end_arglist): Remove functions.
4568         (parse_exp_in_context): Update.
4569         * p-exp.y: Update rules.
4570         * m2-exp.y: Update rules.
4571         * go-exp.y: Update rules.
4572         * f-exp.y: Update rules.
4573         * d-exp.y: Update rules.
4574         * c-exp.y: Update rules.
4575
4576 2019-04-04  Tom Tromey  <tom@tromey.com>
4577
4578         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4579         lex_operator, push_back>: New methods.
4580         Update all rules.
4581         (rust_parser::lex_hex, lex_escape): Rename and update.
4582         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4583         (rust_parser::lex_operator): Rename and update.
4584         (rust_parser::lex_number, rustyylex, rustyyerror)
4585         (rust_lex_test_init, rust_lex_test_sequence)
4586         (rust_lex_test_push_back, rust_lex_tests): Update.
4587         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4588         parameter.
4589         <lexptr, prev_lexptr>: New members.
4590         (lexptr, prev_lexptr): Don't declare.
4591         * parse.c (lexptr, prev_lexptr): Remove globals.
4592         (parse_exp_in_context): Update.
4593         * p-exp.y (yylex, yyerror): Update.
4594         * m2-exp.y (parse_number, yylex, yyerror): Update.
4595         * go-exp.y (lex_one_token, yyerror): Update.
4596         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4597         * d-exp.y (lex_one_token, yyerror): Update.
4598         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4599         (lex_one_token, yyerror): Update.
4600         * ada-lex.l (YY_INPUT): Update.
4601         (rewind_to_char): Update.
4602         * ada-exp.y (yyerror): Update.
4603
4604 2019-04-04  Tom Tromey  <tom@tromey.com>
4605
4606         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4607         * parser-defs.h (struct parser_state) <parser_state>: Add new
4608         parameter.
4609         <comma_terminates>: New member.
4610         (comma_terminates): Don't declare global.
4611         * parse.c (comma_terminates): Remove global.
4612         (parse_exp_in_context): Update.
4613         * p-exp.y (yylex): Update.
4614         * m2-exp.y (yylex): Update.
4615         * go-exp.y (lex_one_token): Update.
4616         * f-exp.y (yylex): Update.
4617         * d-exp.y (lex_one_token): Update.
4618         * c-exp.y (lex_one_token): Update.
4619         * ada-lex.l: Update.
4620
4621 2019-04-04  Tom Tromey  <tom@tromey.com>
4622
4623         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4624         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4625         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4626         * parser-defs.h (paren_depth): Don't declare.
4627         * parse.c (paren_depth): Remove global.
4628         (parse_exp_in_context): Update.
4629         * p-exp.y (paren_depth): New global.
4630         (pascal_parse): Initialize it.
4631         * m2-exp.y (paren_depth): New global.
4632         (m2_parse): Initialize it.
4633         * go-exp.y (paren_depth): New global.
4634         (go_parse): Initialize it.
4635         * f-exp.y (paren_depth): New global.
4636         (f_parse): Initialize it.
4637         * d-exp.y (paren_depth): New global.
4638         (d_parse): Initialize it.
4639         * c-exp.y (paren_depth): New global.
4640         (c_parse): Initialize it.
4641         * ada-lex.l (paren_depth): New global.
4642         (lexer_init): Initialize it.
4643
4644 2019-04-04  Tom Tromey  <tom@tromey.com>
4645
4646         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4647         (rust_parser::convert_ast_to_type)
4648         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4649         * parser-defs.h (struct parser_state) <parser_state>: Add
4650         parameters.  Initialize new members.
4651         <expression_context_block, expression_context_pc>: New members.
4652         * parse.c (expression_context_block, expression_context_pc):
4653         Remove globals.
4654         (parse_exp_in_context): Update.
4655         * p-exp.y: Update all rules.
4656         (yylex): Update.
4657         * m2-exp.y: Update all rules.
4658         (yylex): Update.
4659         * go-exp.y (yylex): Update.
4660         * f-exp.y (yylex): Update.
4661         * d-exp.y: Update all rules.
4662         (yylex): Update.
4663         * c-exp.y: Update all rules.
4664         (lex_one_token, classify_name, yylex, c_parse): Update.
4665         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4666
4667 2019-04-04  Tom Tromey  <tom@tromey.com>
4668
4669         * gdbarch.h, gdbarch.c: Rebuild.
4670         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4671         * stap-probe.h:
4672         (struct stap_parse_info): Replace "parser_state" with
4673         "expr_builder".
4674         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4675         (parser_state): New class.
4676         * parse.c (expr_builder): Rename.
4677         (expr_builder::release): Rename.
4678         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4679         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4680         (write_exp_elt_longcst, write_exp_elt_floatcst)
4681         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4682         (write_exp_string_vector, write_exp_bitstring)
4683         (write_exp_msymbol, mark_struct_expression)
4684         (write_dollar_variable)
4685         (insert_type_address_space, increase_expout_size): Replace
4686         "parser_state" with "expr_builder".
4687         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4688         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4689         "parser_state" with "expr_builder".
4690
4691 2019-04-04  Tom Tromey  <tom@tromey.com>
4692
4693         * rust-exp.y: Replace "parse_language" with method call.
4694         * p-exp.y:
4695         (yylex): Replace "parse_language" with method call.
4696         * m2-exp.y:
4697         (yylex): Replace "parse_language" with method call.
4698         * go-exp.y (classify_name): Replace "parse_language" with method
4699         call.
4700         * f-exp.y (yylex): Replace "parse_language" with method call.
4701         * d-exp.y (lex_one_token): Replace "parse_language" with method
4702         call.
4703         * c-exp.y:
4704         (lex_one_token, classify_name, yylex): Replace "parse_language"
4705         with method call.
4706         * ada-exp.y (find_primitive_type, type_char)
4707         (type_system_address): Replace "parse_language" with method call.
4708
4709 2019-04-04  Tom Tromey  <tom@tromey.com>
4710
4711         * rust-exp.y: Replace "parse_gdbarch" with method call.
4712         * parse.c (write_dollar_variable, insert_type_address_space):
4713         Replace "parse_gdbarch" with method call.
4714         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4715         call.
4716         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4717         call.
4718         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4719         "parse_gdbarch" with method call.
4720         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4721         with method call.
4722         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4723         "parse_gdbarch" with method call.
4724         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4725         "parse_gdbarch" with method call.
4726         * c-exp.y (parse_type, parse_number, classify_name): Replace
4727         "parse_gdbarch" with method call.
4728         * ada-lex.l: Replace "parse_gdbarch" with method call.
4729         * ada-exp.y (parse_type, find_primitive_type, type_char)
4730         (type_system_address): Replace "parse_gdbarch" with method call.
4731
4732 2019-04-04  Tom Tromey  <tom@tromey.com>
4733
4734         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4735         * stap-probe.c (stap_parse_argument): Update.
4736         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4737         initial_size parameter.
4738         * rust-exp.y (rust_lex_tests): Update.
4739         * parse.c (parser_state): Update.
4740         (parse_exp_in_context): Update.
4741         * parser-defs.h (struct parser_state) <parser_state>: Remove
4742         "initial_size" parameter.
4743
4744 2019-04-04  Tom Tromey  <tom@tromey.com>
4745
4746         * parser-defs.h (increase_expout_size): Don't declare.
4747         * parse.c (increase_expout_size): Now static.
4748
4749 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4750
4751         * gnu-nat.c (gnu_nat_target::wait): Fix
4752         target_waitstatus_to_string call.
4753
4754 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * eval.c (evaluate_subexp_standard): Handle internal functions
4757         during Fortran function call handling.
4758
4759 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * NEWS: Mention new internal functions.
4762         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4763         (read_base_type): Use dwarf2_init_complex_target_type.
4764         * value.c (creal_internal_fn): New function.
4765         (cimag_internal_fn): New function.
4766         (_initialize_values): Register new internal functions.
4767
4768 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4769
4770         * infrun.c (stop_all_threads): If debug_infrun, always
4771         trace the wait status after wait_one, using
4772         target_waitstatus_to_string and target_pid_to_str.
4773         (handle_inferior_event): Replace various trace of
4774         wait status kind by a single trace.
4775         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4776         wait status kind image by target_waitstatus_to_string.
4777         * target/waitstatus.c (target_waitstatus_to_string): Fix
4778         obsolete comment.
4779
4780 2019-04-01  Tom Tromey  <tromey@adacore.com>
4781
4782         PR symtab/23331:
4783         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4784
4785 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4786             Pedro Alves  <palves@redhat.com>
4787
4788         * top.c (quit_force): Call 'finalize_values'.
4789         * value.c (finalize_values): New function.
4790         * value.h (finalize_values): Declare.
4791
4792 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4793
4794         * NEWS: Announce $_gdb_major and $_gdb_minor.
4795
4796         * top.c (init_gdb_version_vars): New function.
4797         (gdb_init): Call init_gdb_version_vars.
4798
4799 2019-03-29  Tom Tromey  <tromey@adacore.com>
4800
4801         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4802         help text.  Remove dead code.
4803
4804 2019-03-29  Keith Seitz  <keiths@redhat.com>
4805
4806         From Siddhesh Poyarekar:
4807         * f-lang.h (f77_get_upperbound): Return LONGEST.
4808         (f77_get_lowerbound): Likewise.
4809         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4810         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4811         print them.
4812         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4813         plongest to format print it.
4814         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4815         (f77_get_upperbound): Likewise.
4816         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4817         LOWER_BOUND to LONGEST.
4818         (f77_create_arrayprint_offset_tbl): Likewise.
4819
4820 2019-03-29  Keith Seitz  <keiths@redhat.com>
4821
4822         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4823         %s/pulongest for TYPE_LENGTH instead of %d in format
4824         strings.
4825         * ada-typerint.c (ada_print_type): Likewise.
4826         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4827         * compile/compile-c-support.c (generate_register_struct): Likewise.
4828         * gdbtypes.c (recursive_dump_type): Likewise.
4829         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4830         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4831         instead of %d in format strings.
4832         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4833         to std::min to ULONGEST.
4834         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4835         instead of %d in format strings.
4836         * tracepoint.c (info_scope_command): Likewise.
4837         * typeprint.c (print_offset_data::update)
4838         (print_offset_data::finish): Likewise.
4839         * xtensa-tdep.c (xtensa_store_return_value)
4840         (xtensa_push_dummy_call): Likewise.
4841
4842 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4843
4844         * windows-nat.c (display_selector): Fixed format specifications
4845         for 64-bit Cygwin.
4846
4847 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4848
4849         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4850
4851 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4852
4853         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4854         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4855         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4856         (nios2_linux_init_abi): Install it.
4857
4858 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4859
4860         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4861
4862 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4863
4864         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4865
4866 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4867             Tom Tromey  <tromey@adacore.com>
4868
4869         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4870
4871 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4872
4873         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4874         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4875         method to compute the bounds of range types. Also print "[evaluated]"
4876         if the bounds' values come from a dynamic evaluation.
4877
4878 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4881         whitespace when pretty printing is on.
4882
4883 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4884
4885         * ppc-linux-nat.c: Add include.
4886
4887 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4888
4889         * NEWS: Mention AArch64 Pointer Authentication.
4890
4891 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4892
4893         * arm-linux-nat.c: Add include.
4894
4895 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4896
4897         * source-cache.c (source_cache::get_source_lines): Re-read
4898         fullname after calling open_source_file.
4899
4900 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4901
4902         * NEWS: Mention TLS support for FreeBSD.
4903
4904 2019-03-25  Tom Tromey  <tromey@adacore.com>
4905
4906         * minsyms.c (BUNCH_SIZE): Update comment.
4907         (~minimal_symbol_reader): Remove old comment.
4908         (compact_minimal_symbols): Update comment.
4909         (minimal_symbol_reader::install): Remove old comment.  Update
4910         other comments.
4911
4912 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4913
4914         * s390-linux-nat.c: Add include.
4915
4916 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4917
4918         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4919         Call linux_get_hwcap.
4920         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4921         Likewise.
4922         (aarch64_linux_get_hwcap): Remove function.
4923         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4924         declaration.
4925         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4926         linux_get_hwcap.
4927         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4928         * linux-tdep.c (linux_get_hwcap): Add function.
4929         (linux_get_hwcap2): Likewise.
4930         * linux-tdep.h (linux_get_hwcap): Add declaration.
4931         (linux_get_hwcap2): Likewise.
4932         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4933         (ppc_linux_get_hwcap2): Likewise.
4934         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4935         linux_get_hwcap.
4936         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4937         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4938         (ppc_linux_nat_target::read_description): Likewise.
4939         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4940         * s390-linux-nat.c: Likewise.
4941         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4942
4943 2019-03-24  Tom Tromey  <tom@tromey.com>
4944
4945         * ada-lang.c (standard_lookup): Simplify initialization.
4946         (ada_lookup_symbol_nonlocal): Simplify return.
4947         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4948         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4949         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4950         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4951         initialization.
4952         * solib.c (solib_global_lookup): Simplify.
4953         * symtab.c (null_block_symbol): Remove.
4954         (symbol_cache_lookup): Simplify returns.
4955         (lookup_language_this): Simplify returns.
4956         (lookup_symbol_aux): Simplify return.
4957         (lookup_local_symbol): Simplify returns.
4958         (lookup_global_symbol_from_objfile): Simplify return.
4959         (lookup_symbol_in_objfile_symtabs)
4960         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4961         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4962         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4963         * cp-namespace.c (cp_lookup_bare_symbol)
4964         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4965         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4966         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4967         (cp_lookup_symbol_via_imports): Simplify initialization.
4968         (find_symbol_in_baseclass): Likewise.
4969         * symtab.h (null_block_symbol): Remove.
4970         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4971         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4972         (d_lookup_symbol_module): Likewise.
4973         (find_symbol_in_baseclass): Simplify initialization.
4974
4975 2019-03-24  Tom Tromey  <tom@tromey.com>
4976
4977         * expression.h: Don't include symtab.h.
4978         (struct block): Forward declare.
4979
4980 2019-03-24  Tom Tromey  <tom@tromey.com>
4981
4982         * c-exp.y (typebase): Remove casts.
4983         * gdbtypes.c (lookup_unsigned_typename, )
4984         (lookup_signed_typename): Remove cast.
4985         * eval.c (parse_to_comma_and_eval): Remove cast.
4986         * parse.c (write_dollar_variable): Remove cast.
4987         * block.h (struct block) <superblock>: Now const.
4988         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4989         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4990         (map_block): Make "block" const.
4991         * symfile.h (struct quick_symbol_functions)
4992         <map_matching_symbols>: Constify block argument to "callback".
4993         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4994         const.
4995         (find_pc_sect_compunit_symtab): Make "b" const.
4996         (find_symbol_at_address): Likewise.
4997         (search_symbols): Likewise.
4998         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4999         (dw2_debug_names_lookup_symbol): Likewise.
5000         (dw2_map_matching_symbols): Update.
5001         * p-valprint.c (pascal_val_print): Remove "block".
5002         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5003         (aux_add_nonlocal_symbols): Make "block" const.
5004         (resolve_subexp): Remove cast.
5005         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5006         const.
5007         (iterate_over_file_blocks): Likewise.
5008         * f-exp.y (%union) <bval>: Remove.
5009         * coffread.c (patch_opaque_types): Make "b" const.
5010         * spu-tdep.c (spu_catch_start): Make "block" const.
5011         * c-valprint.c (print_unpacked_pointer): Remove "block".
5012         * symmisc.c (dump_symtab_1): Make "b" const.
5013         (block_depth): Make "block" const.
5014         * d-exp.y (%union) <bval>: Remove.
5015         * cp-support.h (cp_lookup_rtti_type): Update.
5016         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5017         * psymtab.c (psym_lookup_symbol): Make "block" const.
5018         (maintenance_check_psymtabs): Make "b" const.
5019         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5020         (enumerate_locals, enumerate_args): Update.
5021         * python/py-symtab.c (stpy_global_block): Make "block" const.
5022         (stpy_static_block): Likewise.
5023         * inline-frame.c (block_starting_point_at): Make "new_block"
5024         const.
5025         * block.c (find_block_in_blockvector): Make return type const.
5026         (blockvector_for_pc_sect): Make "b" const.
5027         (find_block_in_blockvector): Make "b" const.
5028
5029 2019-03-23  Tom Tromey  <tom@tromey.com>
5030
5031         * varobj.c (varobj_create): Update.
5032         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5033         * printcmd.c (display_command, do_one_display): Don't reset
5034         innermost_block.
5035         * parser-defs.h (enum innermost_block_tracker_type): Move to
5036         expression.h.
5037         (innermost_block): Update comment.
5038         * parse.c (parse_exp_1): Add tracker_types parameter.
5039         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5040         tracker_types parameter.  Reset innermost_block.
5041         (parse_exp_in_context): Remove.
5042         (parse_expression_for_completion): Update.
5043         * objfiles.c (~objfile): Don't reset expression_context_block or
5044         innermost_block.
5045         * expression.h (enum innermost_block_tracker_type): Move from
5046         parser-defs.h.
5047         (parse_exp_1): Add tracker_types parameter.
5048         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5049         reset innermost_block.
5050
5051 2019-03-23  Tom Tromey  <tom@tromey.com>
5052
5053         * objfiles.h: Include bcache.h.
5054
5055 2019-03-23  Tom Tromey  <tom@tromey.com>
5056
5057         * linespec.c (get_current_search_block): Use
5058         scoped_restore_current_language.
5059         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5060
5061 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5062             Jiong Wang  <jiong.wang@arm.com>
5063
5064         * aarch64-linux-tdep.c
5065         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5066         section.
5067         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5068
5069 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5070             Jiong Wang  <jiong.wang@arm.com>
5071
5072         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5073         instructions.
5074         (aarch64_analyze_prologue_test): Add PACIASP test.
5075         (aarch64_prologue_prev_register): Unmask PC value.
5076
5077 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5078             Jiong Wang  <jiong.wang@arm.com>
5079
5080         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5081         (aarch64_dwarf2_prev_register): Unmask PC value.
5082         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5083         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5084         DW_CFA_AARCH64_negate_ra_state.
5085         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5086
5087 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5088             Jiong Wang  <jiong.wang@arm.com>
5089
5090         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5091         registers.
5092         (aarch64_pseudo_register_name): Likewise.
5093         (aarch64_pseudo_register_type): Likewise.
5094         (aarch64_pseudo_register_reggroup_p): Likewise.
5095         (aarch64_gdbarch_init): Add pauth registers.
5096         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5097         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5098         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5099         (struct gdbarch_tdep): Add regnum for ra_state.
5100
5101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5102             Jiong Wang  <jiong.wang@arm.com>
5103
5104         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5105
5106 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5107             Jiong Wang  <jiong.wang@arm.com>
5108
5109         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5110         function.
5111         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5112         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5113         (aarch64_gdbarch_init): Add puth registers.
5114         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5115         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5116         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5117
5118 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5119             Jiong Wang  <jiong.wang@arm.com>
5120
5121         * aarch64-linux-nat.c
5122         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5123         * aarch64-linux-tdep.c
5124         (aarch64_linux_core_read_description): Likewise.
5125         (aarch64_linux_get_hwcap): New function.
5126         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5127         (aarch64_linux_get_hwcap): New declaration.
5128
5129 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5130             Jiong Wang  <jiong.wang@arm.com>
5131
5132         * aarch64-linux-nat.c
5133         (aarch64_linux_nat_target::read_description): Add pauth param.
5134         * aarch64-linux-tdep.c
5135         (aarch64_linux_core_read_description): Likewise.
5136         * aarch64-tdep.c (struct target_desc): Add in pauth.
5137         (aarch64_read_description): Add pauth param.
5138         (aarch64_gdbarch_init): Likewise.
5139         * aarch64-tdep.h (aarch64_read_description): Likewise.
5140         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5141         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5142         * features/Makefile: Add new files.
5143         * features/aarch64-pauth.c: New file.
5144         * features/aarch64-pauth.xml: New file.
5145
5146 2019-03-20  Tom Tromey  <tromey@adacore.com>
5147
5148         * infrun.c (handle_inferior_event): Rename from
5149         handle_inferior_event_1.  Create a scoped_value_mark.
5150         (handle_inferior_event): Remove.
5151
5152 2019-03-19  Tom Tromey  <tromey@adacore.com>
5153
5154         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5155         * infrun.h (print_stop_event): Add "displays" parameter.
5156         * infrun.c (print_stop_event): Add "displays" parameter.
5157
5158 2019-03-19  Pedro Alves  <palves@redhat.com>
5159
5160         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5161         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5162         to -1.  Fix TABs vs spaces.
5163         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5164         * tui/tui-out.h (tui_ui_out) Add intro comments.
5165         <m_line, m_start_of_line>: In-class initialize, and add describing
5166         comment.
5167
5168 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5169
5170         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5171         variable names.
5172         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5173
5174 2019-03-18  Pedro Alves  <palves@redhat.com>
5175             Eli Zaretskii <eliz@gnu.org>
5176
5177         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5178         m_line and m_start_of_line.
5179
5180 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5181
5182         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5183         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5184         it returns a newline.  This fixes a regression in TU mode, whereby
5185         the next line is output on the same screen line as the user input.
5186
5187 2019-03-18  Tom Tromey  <tromey@adacore.com>
5188
5189         * minsyms.c (minimal_symbol_reader::install): Remove call to
5190         obstack_blank.
5191
5192 2019-03-18  Pedro Alves  <palves@redhat.com>
5193
5194         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5195         New globals.
5196         (apply_style): New, factored out from ...
5197         (apply_ansi_escape): ... this.  Handle reverse video mode.
5198         (tui_set_reverse_mode): New function.
5199         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5200         * tui/tui-winsource.c (tui_show_source_line): Use
5201         tui_set_reverse_mode instead of setting A_STANDOUT.
5202         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5203         New setter methods.
5204
5205 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5206
5207         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5208         Handle tabs.
5209
5210 2019-03-18  Tom Tromey  <tromey@adacore.com>
5211
5212         * ada-lang.c (empty_array): Add "high" parameter.
5213         (ada_evaluate_subexp): Update.
5214
5215 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5216
5217         * unittests/string_view-selftests.c: Define
5218         _initialize_string_view_selftests unconditionally.
5219
5220 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5221
5222         PR gdb/24350
5223         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5224
5225 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5226
5227         PR gdb/24351
5228         * windows-nat.c (display_selector): Fix format specifiers.
5229
5230 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5231
5232         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5233         tui_refill_source_window instead of tui_refresh_win, to update the
5234         current execution line.  This fixes redisplay of the current line
5235         when stepping through the code with "next" or "step".
5236
5237 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5238
5239         * source-cache.c (source_cache::get_source_lines): Call
5240         find_source_lines to initialize s->nlines.  This fixes vertical
5241         scrolling of TUI source window when the DOWN arrow is pressed.
5242
5243 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5244
5245         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5246         linux-thread-db.c (_initialize_thread_db): Likewise.
5247
5248 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5249
5250         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5251         wclrtoeol in tui_show_source_line".  This reverts changes made in
5252         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5253
5254 2019-03-15  Tom Tromey  <tom@tromey.com>
5255
5256         * symtab.h (struct minimal_symbol): Derive from
5257         general_symbol_info.
5258         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5259         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5260         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5261         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5262         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5263         (MSYMBOL_SEARCH_NAME): Update.
5264         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5265         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5266         * minsyms.c (minimal_symbol_reader::record_full): Update.
5267
5268 2019-03-15  Tom Tromey  <tom@tromey.com>
5269
5270         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5271
5272 2019-03-15  Tom Tromey  <tom@tromey.com>
5273
5274         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5275         unique_xmalloc_ptr.
5276         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5277         Update.
5278         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5279         (build_minimal_symbol_hash_tables)
5280         (minimal_symbol_reader::install): Update.
5281
5282 2019-03-15  Tom Tromey  <tom@tromey.com>
5283
5284         * symtab.c (create_demangled_names_hash): Update.
5285         (symbol_set_names): Update.
5286         * objfiles.h (struct objfile_per_bfd_storage)
5287         <demangled_names_hash>: Now an htab_up.
5288         * objfiles.c (objfile_per_bfd_storage): Simplify.
5289
5290 2019-03-15  Tom Tromey  <tom@tromey.com>
5291
5292         * objfiles.h (struct objfile_per_bfd_storage): Declare
5293         destructor.
5294         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5295         New.
5296         (get_objfile_bfd_data): Use new.  Don't initialize
5297         language_of_main.
5298         (free_objfile_per_bfd_storage): Remove.
5299         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5300
5301 2019-03-15  Tom Tromey  <tom@tromey.com>
5302
5303         * symfile.c (reread_symbols): Update.
5304         * objfiles.c (objfile::objfile): Update.
5305         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5306         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5307         comment.
5308         (minimal_symbol_reader::install): Update.
5309         (terminate_minimal_symbol_table): Remove.
5310         * jit.c (jit_object_close_impl): Update.
5311
5312 2019-03-15  Tom Tromey  <tom@tromey.com>
5313
5314         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5315         initializations.
5316
5317 2019-03-15  Tom Tromey  <tom@tromey.com>
5318
5319         * objfiles.h (struct objfile_per_bfd_storage)
5320         <demangled_hash_languages>: Now a bitset.
5321         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5322         (lookup_minimal_symbol): Update.
5323
5324 2019-03-15  Tom Tromey  <tom@tromey.com>
5325
5326         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5327         Don't return the symbol.
5328         * coffread.c (record_minimal_symbol): Use record_full.
5329
5330 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5331
5332         The MS-Windows port of ncurses fails to switch to a color pair if
5333         one or both of the colors are the implicit default colors.  This
5334         change records the default colors when TUI is initialized, and
5335         then specifies them explicitly when a color pair uses the default
5336         colors.  This allows color styling in TUI mode on MS-Windows.
5337
5338         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5339         ncurses_norm_attr.
5340         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5341         colors in ncurses_norm_attr.
5342         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5343         "none", replace it with the default color recorded in
5344         ncurses_norm_attr.
5345
5346 2019-03-14  Tom Tromey  <tromey@adacore.com>
5347
5348         * source-cache.h (class source_cache) <get_source_lines>: Return
5349         std::string.
5350         * source-cache.c (source_cache::extract_lines): Handle case where
5351         first_pos==npos.  Return std::string.
5352         (source_cache::get_source_lines): Update.
5353
5354 2019-03-14  Tom Tromey  <tromey@adacore.com>
5355
5356         * NEWS: Add item for "style sources" commands.
5357         * source-cache.c (source_cache::get_source_lines): Check
5358         source_styling.
5359         * cli/cli-style.c (source_styling): New global.
5360         (_initialize_cli_style): Add "style sources" commands.
5361         (show_style_sources): New function.
5362         * cli/cli-style.h (source_styling): Declare.
5363
5364 2019-03-14  Pedro Alves  <palves@redhat.com>
5365             Tom Tromey  <tromey@adacore.com>
5366
5367         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5368         * tui/tui-winsource.c (tui_refill_source_window): New function,
5369         from...
5370         (tui_horizontal_source_scroll): ... here.  Move some logic.
5371         * cli/cli-style.c (set_style_enabled): Notify new observable.
5372         * tui/tui-hooks.c (tui_redisplay_source): New function.
5373         (tui_attach_detach_observers): Attach or detach
5374         tui_redisplay_source.
5375         * observable.h (source_styling_changed): New observable.
5376         * observable.c: Define source_styling_changed observable.
5377
5378 2019-03-13  Tom Tromey  <tromey@adacore.com>
5379
5380         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5381         (i386_gnu_nat_target::store_registers): Update.
5382         * target-debug.h (target_debug_print_std_string): New macro.
5383         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5384         * windows-tdep.c (display_one_tib): Update.
5385         * tui/tui-stack.c (tui_make_status_line): Update.
5386         * top.c (print_inferior_quit_action): Update.
5387         * thread.c (thr_try_catch_cmd): Update.
5388         (add_thread_with_info): Update.
5389         (thread_target_id_str): Update.
5390         (thr_try_catch_cmd): Update.
5391         (thread_command): Update.
5392         (thread_find_command): Update.
5393         * record-btrace.c (record_btrace_target::info_record)
5394         (record_btrace_resume_thread, record_btrace_target::resume)
5395         (record_btrace_cancel_resume, record_btrace_step_thread)
5396         (record_btrace_target::wait, record_btrace_target::wait)
5397         (record_btrace_target::wait, record_btrace_target::stop): Update.
5398         * progspace.c (print_program_space): Update.
5399         * process-stratum-target.c
5400         (process_stratum_target::thread_address_space): Update.
5401         * linux-fork.c (linux_fork_mourn_inferior)
5402         (detach_checkpoint_command, info_checkpoints_command)
5403         (linux_fork_context): Update.
5404         (linux_fork_detach): Update.
5405         (class scoped_switch_fork_info): Update.
5406         (delete_checkpoint_command): Update.
5407         * infrun.c (follow_fork_inferior): Update.
5408         (follow_fork_inferior): Update.
5409         (proceed_after_vfork_done): Update.
5410         (handle_vfork_child_exec_or_exit): Update.
5411         (follow_exec): Update.
5412         (displaced_step_prepare_throw): Update.
5413         (displaced_step_restore): Update.
5414         (start_step_over): Update.
5415         (resume_1): Update.
5416         (clear_proceed_status_thread): Update.
5417         (proceed): Update.
5418         (print_target_wait_results): Update.
5419         (do_target_wait): Update.
5420         (context_switch): Update.
5421         (stop_all_threads): Update.
5422         (restart_threads): Update.
5423         (finish_step_over): Update.
5424         (handle_signal_stop): Update.
5425         (switch_back_to_stepped_thread): Update.
5426         (keep_going_pass_signal): Update.
5427         (print_exited_reason): Update.
5428         (normal_stop): Update.
5429         * inferior.c (inferior_pid_to_str): Change return type.
5430         (print_selected_inferior): Update.
5431         (add_inferior): Update.
5432         (detach_inferior): Update.
5433         * dummy-frame.c (fprint_dummy_frames): Update.
5434         * dcache.c (dcache_info_1): Update.
5435         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5436         (btrace_fetch, btrace_clear): Update.
5437         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5438         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5439         type.
5440         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5441         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5442         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5443         * gdbarch.c, gdbarch.h: Rebuild.
5444         * gdbarch.sh (core_pid_to_str): Change return type.
5445         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5446         return type.
5447         (windows_nat_target::pid_to_str): Change return type.
5448         (windows_delete_thread): Update.
5449         (windows_nat_target::attach): Update.
5450         (windows_nat_target::files_info): Update.
5451         * target-delegates.c: Rebuild.
5452         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5453         return type.
5454         (sol_thread_target::pid_to_str): Change return type.
5455         * remote.c (class remote_target) <pid_to_str>: Change return
5456         type.
5457         (remote_target::pid_to_str): Change return type.
5458         (extended_remote_target::attach, remote_target::remote_stop_ns)
5459         (remote_target::remote_notif_remove_queued_reply)
5460         (remote_target::push_stop_reply, remote_target::disable_btrace):
5461         Update.
5462         (extended_remote_target::attach): Update.
5463         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5464         type.
5465         (gdbsim_target::pid_to_str): Change return type.
5466         * ravenscar-thread.c (struct ravenscar_thread_target)
5467         <pid_to_str>: Change return type.
5468         (ravenscar_thread_target::pid_to_str): Change return type.
5469         * procfs.c (class procfs_target) <pid_to_str>: Change return
5470         type.
5471         (procfs_target::pid_to_str): Change return type.
5472         (procfs_target::attach): Update.
5473         (procfs_target::detach): Update.
5474         (procfs_target::fetch_registers): Update.
5475         (procfs_target::store_registers): Update.
5476         (procfs_target::wait): Update.
5477         (procfs_target::files_info): Update.
5478         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5479         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5480         return type.
5481         (nto_procfs_target::pid_to_str): Change return type.
5482         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5483         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5484         return type.
5485         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5486         (exit_lwp): Update.
5487         (attach_proc_task_lwp_callback, get_detach_signal)
5488         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5489         (linux_nat_target::resume, wait_lwp, stop_callback)
5490         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5491         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5492         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5493         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5494         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5495         type.
5496         (inf_ptrace_target::attach): Update.
5497         (inf_ptrace_target::files_info): Update.
5498         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5499         type.
5500         (go32_nat_target::pid_to_str): Change return type.
5501         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5502         (gnu_nat_target::wait): Update.
5503         (gnu_nat_target::wait): Update.
5504         (gnu_nat_target::resume): Update.
5505         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5506         (fbsd_nat_target::wait): Update.
5507         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5508         type.
5509         (darwin_nat_target::attach): Update.
5510         * corelow.c (class core_target) <pid_to_str>: Change return type.
5511         (core_target::pid_to_str): Change return type.
5512         * target.c (normal_pid_to_str): Change return type.
5513         (default_pid_to_str): Likewise.
5514         (target_pid_to_str): Change return type.
5515         (target_translate_tls_address): Update.
5516         (target_announce_detach): Update.
5517         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5518         return type.
5519         (bsd_uthread_target::pid_to_str): Change return type.
5520         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5521         type.
5522         (bsd_kvm_target::pid_to_str): Change return type.
5523         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5524         return type.
5525         (aix_thread_target::pid_to_str): Change return type.
5526         * target.h (struct target_ops) <pid_to_str>: Change return type.
5527         (target_pid_to_str, normal_pid_to_str): Likewise.
5528         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5529         type.
5530         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5531         type.
5532         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5533         return type.
5534         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5535         type.
5536         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5537         type.
5538         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5539         return type.
5540
5541 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5542
5543         * NEWS: Mention that the new default MI version is 3.  Mention
5544         changes to the output of commands and events that deal with
5545         multi-location breakpoints.
5546         * breakpoint.c: Include "mi/mi-out.h".
5547         (print_one_breakpoint): Change output syntax if using MI version
5548         >= 3.
5549         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5550         New.
5551         (mi_multi_location_breakpoint_output_fixed): New.
5552         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5553         (mi_cmd_fix_multi_location_breakpoint_output): New.
5554         (mi_multi_location_breakpoint_output_fixed): New.
5555         * mi/mi-cmds.c (mi_cmds): Register command
5556         -fix-multi-location-breakpoint-output.
5557         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5558         interpreter "mi".
5559
5560 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5561
5562         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5563         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5564         instantiate mi_ui_out based on interpreter name.
5565         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5566         * mi/mi-main.c (mi_load_progress): Likewise.
5567
5568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5569
5570         * NEWS: Combine separate "New targets" sections for 8.3.
5571
5572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5573
5574         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5575         (ppcfbsd_init_abi): Install gdbarch
5576         "fetch_tls_load_module_address" and "get_thread_local_address"
5577         methods.
5578
5579 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5580
5581         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5582         (riscv_fbsd_init_abi): Install gdbarch
5583         "fetch_tls_load_module_address" and "get_thread_local_address"
5584         methods.
5585
5586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5587
5588         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5589         (i386fbsd_init_abi): Install gdbarch
5590         "fetch_tls_load_module_address" and "get_thread_local_address"
5591         methods.
5592
5593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5594
5595         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5596         (amd64fbsd_init_abi): Install gdbarch
5597         "fetch_tls_load_module_address" and "get_thread_local_address"
5598         methods.
5599
5600 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5601
5602         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5603         (struct fbsd_pspace_data): New type.
5604         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5605         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5606         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5607         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5608         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5609
5610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5611
5612         * gdbtypes.c (lookup_struct_elt): New function.
5613         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5614         * gdbtypes.h (struct struct_elt): New type.
5615         (lookup_struct_elt): New prototype.
5616
5617 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5618
5619         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5620         remove disabled code block.
5621
5622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5623
5624         * gdbarch.sh (get_thread_local_address): New method.
5625         * gdbarch.h, gdbarch.c: Regenerate.
5626         * target.c (target_translate_tls_address): Use
5627         gdbarch_get_thread_local_address if present instead of
5628         target::get_thread_local_address.
5629
5630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5631
5632         * target.h (target::get_thread_local_address): Update comment.
5633
5634 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5635
5636         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5637         objfile->separate_debug_objfile_backlink if not NULL.
5638
5639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5640
5641         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5642         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5643         (amd64bsd_store_inferior_registers): Likewise.
5644         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5645         Enable segment base registers.
5646         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5647         PT_GETFSBASE and PT_GETGSBASE.
5648         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5649         PT_SETGSBASE.
5650         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5651         segment base registers.
5652         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5653
5654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5655
5656         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5657         Update calls to i386_target_description to add 'segments'
5658         parameter.
5659         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5660         add segment base registers.
5661         * arch/i386.c (i386_create_target_description): Add 'segments'
5662         parameter to enable segment base registers.
5663         * arch/i386.h (i386_create_target_description): Likewise.
5664         * features/i386/32bit-segments.xml: New file.
5665         * features/i386/32bit-segments.c: Generate.
5666         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5667         call to i386_target_description to add 'segments' parameter.
5668         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5669         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5670         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5671         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5672         if feature is present.
5673         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5674         Add 'segments' parameter to call to i386_target_description.
5675         (i386_target_description): Add 'segments' parameter to enable
5676         segment base registers.
5677         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5678         to call to i386_target_description.
5679         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5680         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5681         Define I386_NUM_REGS.
5682         (i386_target_description): Add 'segments' parameter to enable
5683         segment base registers.
5684
5685 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5686
5687         PR/24325
5688         * source-cache.c: #undef open and close, to avoid unresolved
5689         externals during linking.
5690
5691 2019-03-12  Tom Tromey  <tromey@adacore.com>
5692
5693         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5694         const.  Add initializers.
5695         (_initialize_remote): Don't initialize ptid globals.
5696
5697 2019-03-12  Pedro Alves  <palves@redhat.com>
5698
5699         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5700
5701 2019-03-12  Pedro Alves  <palves@redhat.com>
5702
5703         * cp-name-parser.y (main): Remove unused 'len' variable.
5704
5705 2019-03-12  Tom Tromey  <tromey@adacore.com>
5706
5707         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5708         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5709
5710 2019-03-12  Tom Tromey  <tromey@adacore.com>
5711
5712         * linux-nat.c (iterate_over_lwps): Update.
5713         (stop_callback): Remove parameter.
5714         (stop_wait_callback, detach_callback, resume_set_callback)
5715         (select_singlestep_lwp_callback, set_ignore_sigint)
5716         (status_callback, resumed_callback, resume_clear_callback)
5717         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5718         data parameter.
5719         (linux_nat_target::detach, linux_nat_target::resume)
5720         (linux_stop_and_wait_all_lwps, select_event_lwp)
5721         (linux_nat_filter_event, linux_nat_wait_1)
5722         (linux_nat_target::kill, linux_nat_target::stop)
5723         (linux_nat_target::stop): Update.
5724         (linux_nat_resume_callback): Change type.
5725         (resume_stopped_resumed_lwps, count_events_callback)
5726         (select_event_lwp_callback): Likewise.
5727         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5728         * arm-linux-nat.c (struct update_registers_data): Remove.
5729         (update_registers_callback): Change type.
5730         (arm_linux_insert_hw_breakpoint1): Update.
5731         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5732         parameter.
5733         (x86_linux_dr_set_addr): Update.
5734         (x86_linux_dr_set_control): Update.
5735         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5736         (iterate_over_lwps): Use gdb::function_view.
5737         * nat/aarch64-linux-hw-point.c (struct
5738         aarch64_dr_update_callback_param): Remove.
5739         (debug_reg_change_callback): Change type.
5740         (aarch64_notify_debug_reg_change): Update.
5741         * s390-linux-nat.c (s390_refresh_per_info): Update.
5742
5743 2019-03-11  Tom Tromey  <tromey@adacore.com>
5744
5745         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5746         redundant assignment to "this_cu".
5747
5748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5749
5750         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5751
5752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5753
5754         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5755         from...
5756         (rank_one_type): ... this.
5757
5758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5759
5760         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5761         from...
5762         (rank_one_type): ... this.
5763
5764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5765
5766         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5767         from...
5768         (rank_one_type): ... this.
5769
5770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5771
5772         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5773         from...
5774         (rank_one_type): ... this.
5775
5776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5777
5778         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5779         from...
5780         (rank_one_type): ... this.
5781
5782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5783
5784         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5785         from...
5786         (rank_one_type): ... this.
5787
5788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5789
5790         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5791         from...
5792         (rank_one_type): ... this.
5793
5794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5795
5796         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5797         from...
5798         (rank_one_type): ... this.
5799
5800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5801
5802         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5803         from...
5804         (rank_one_type): ... this.
5805
5806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5807
5808         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5809         from...
5810         (rank_one_type): ... this.
5811
5812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5813
5814         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5815         from...
5816         (rank_one_type): ... this.
5817
5818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5819
5820         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5821         from...
5822         (rank_one_type): ... this.
5823
5824 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5825
5826         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5827         inferior-events' shows the example events.
5828
5829 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5830
5831         Support styling on native MS-Windows console
5832
5833         PR/24315
5834         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5835         on MS-Windows if $TERM is not defined.
5836
5837         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5838
5839         * posix-hdep.c (gdb_console_fputs):
5840         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5841         functions.
5842         * ui-file.h (gdb_console_fputs): Add prototype.
5843
5844         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5845         back to fputs only if the former returns zero.
5846
5847 2019-03-07  Tom Tromey  <tom@tromey.com>
5848
5849         * symmisc.c (print_symbol_bcache_statistics): Update.
5850         (print_objfile_statistics): Update.
5851         * symfile.c (allocate_symtab): Update.
5852         * stabsread.c: Don't include bcache.h.
5853         * psymtab.h (struct psymbol_bcache): Don't declare.
5854         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5855         (psymbol_bcache_init, psymbol_bcache_free)
5856         (psymbol_bcache_get_bcache): Don't declare.
5857         * psymtab.c (struct psymbol_bcache): Remove.
5858         (psymtab_storage::psymtab_storage): Update.
5859         (psymtab_storage::~psymtab_storage): Update.
5860         (psymbol_bcache_init, psymbol_bcache_free)
5861         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5862         (add_psymbol_to_bcache): Update.
5863         (allocate_psymtab): Update.
5864         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5865         macro_cache>: No longer pointers.
5866         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5867         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5868         * macrotab.c (macro_bcache): Update.
5869         * macroexp.c: Don't include bcache.h.
5870         * gdbtypes.c (check_types_worklist): Update.
5871         (types_deeply_equal): Remove TRY/CATCH.  Update.
5872         * elfread.c (elf_symtab_read): Update.
5873         * dwarf2read.c: Don't include bcache.h.
5874         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5875         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5876         (print_bcache_statistics, bcache_memory_used): Don't declare.
5877         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5878         methods.  Rename all data members.
5879         * bcache.c (struct bcache): Move to bcache.h.
5880         (bcache::expand_hash_table): Rename from expand_hash_table.
5881         (bcache): Remove.
5882         (bcache::insert): Rename from bcache_full.
5883         (bcache::compare): Rename from bcache_compare.
5884         (bcache_xmalloc): Remove.
5885         (bcache::~bcache): Rename from bcache_xfree.
5886         (bcache::print_statistics): Rename from print_bcache_statistics.
5887         (bcache::memory_used): Rename from bcache_memory_used.
5888
5889 2019-03-07  Pedro Alves  <palves@redhat.com>
5890
5891         * infrun.c (normal_stop): Also check for
5892         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5893
5894 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * f-lang.c (value_from_host_double): Moved to...
5897         * value.c (value_from_host_double): ...here.
5898         * value.h (value_from_host_double): Declare.
5899         * guile/scm-math.c (vlscm_convert_typed_number): Use
5900         value_from_host_double.
5901         (vlscm_convert_number): Likewise.
5902         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5903         * python/py-value.c (convert_value_from_python): Likewise.
5904
5905 2019-03-06  Tom Tromey  <tom@tromey.com>
5906
5907         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5908
5909 2019-03-06  Tom Tromey  <tom@tromey.com>
5910
5911         * utils.h (free_current_contents): Don't declare.
5912         * utils.c (free_current_contents): Remove.
5913
5914 2019-03-06  Tom Tromey  <tom@tromey.com>
5915
5916         * top.c (quit_force): Update.
5917         * main.c (captured_command_loop): Update.
5918         * common/new-op.c (operator new): Update.
5919         * common/common-exceptions.c (struct catcher)
5920         <save_cleanup_chain>: Remove member.
5921         (exceptions_state_mc_init): Update.
5922         (exception_try_scope_entry): Return nullptr.
5923         (exception_try_scope_exit, exception_rethrow)
5924         (throw_exception_sjlj, throw_exception_cxx): Update.
5925         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5926         (all_cleanups, do_cleanups, discard_cleanups)
5927         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5928         (restore_cleanups, restore_final_cleanups): Don't declare.
5929         (do_final_cleanups): Remove parameter.
5930         * common/cleanups.c (cleanup_chain, make_cleanup)
5931         (make_cleanup_dtor, all_cleanups, do_cleanups)
5932         (discard_my_cleanups, discard_cleanups)
5933         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5934         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5935         (null_cleanup): Remove.
5936         (do_final_cleanups): Remove parameter.
5937
5938 2019-03-06  Tom Tromey  <tom@tromey.com>
5939
5940         * remote.c (remote_target::remote_parse_stop_reply): Use
5941         unique_xmalloc_ptr.
5942
5943 2019-03-06  Tom Tromey  <tom@tromey.com>
5944
5945         * stabsread.c (struct stabs_field_info): Rename from field_info.
5946         <list, fnlist>: Add initializers.
5947         <obstack>: New member.
5948         (read_member_functions, read_struct_fields, read_baseclasses):
5949         Allocate on obstack.  Don't use cleanups.
5950         (read_one_struct_field, read_member_functions, read_struct_fields)
5951         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5952         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5953         (read_struct_type): Update.
5954
5955 2019-03-06  Tom Tromey  <tom@tromey.com>
5956
5957         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5958         * common/filestuff.h (make_cleanup_close): Don't declare.
5959         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5960         Remove.
5961
5962 2019-03-06  Tom Tromey  <tom@tromey.com>
5963
5964         * solib-aix.c: Use make_scope_exit.
5965
5966 2019-03-06  Tom Tromey  <tom@tromey.com>
5967
5968         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5969         Use make_scope_exit.
5970
5971 2019-03-06  Tom Tromey  <tom@tromey.com>
5972
5973         * solib-svr4.c (disable_probes_interface): Remove parameter.
5974         (svr4_handle_solib_event): Use make_scope_exit.
5975
5976 2019-03-06  Tom Tromey  <tom@tromey.com>
5977
5978         * remote.c (struct stop_reply_deleter): Remove.
5979         (stop_reply_up): Update.
5980         (struct stop_reply): Derive from notif_event.  Don't typedef.
5981         <regcache>: Now a std::vector.
5982         (stop_reply_xfree): Remove.
5983         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5984         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5985         (remote_target::discard_pending_stop_replies): Use delete.
5986         (remote_target::remote_parse_stop_reply): Update.
5987         (remote_target::process_stop_reply): Update.
5988         * remote-notif.h (struct notif_event): Add virtual destructor.
5989         Remove "dtr" member.
5990         (struct notif_client) <alloc_event>: Return a unique_ptr.
5991         (notif_event_xfree): Don't declare.
5992         (notif_event_up): New typedef.
5993         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5994         (notif_event_xfree, do_notif_event_xfree): Remove.
5995         (remote_notif_state_xfree): Update.
5996
5997 2019-03-06  Tom Tromey  <tom@tromey.com>
5998
5999         * infrun.c (displaced_step_clear_cleanup): Now a
6000         forward_scope_exit type.
6001         (displaced_step_prepare_throw): Update.
6002         (displaced_step_fixup): Update.
6003
6004 2019-03-06  Tom Tromey  <tom@tromey.com>
6005
6006         * inferior.h (class inferior): Update comment.
6007         * gdbthread.h (class thread_info): Update comment.
6008
6009 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6010             Tom Tromey  <tom@tromey.com>
6011
6012         * stabsread.h (struct stab_section_list): Remove.
6013         (coffstab_build_psymtabs): Update.
6014         * dbxread.c (symbuf_sections): Now a std::vector.
6015         (sect_idx): New global.
6016         (fill_symbuf): Update.
6017         (coffstab_build_psymtabs): Change type of stabsects parameter.
6018         Update.
6019         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6020         std::vector.
6021         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6022         (coff_locate_sections): Update.
6023         (coff_symfile_read): Remove cleanups.  Update.
6024         (init_stringtab): Add storage parameter.
6025         (free_stringtab, free_stringtab_cleanup): Remove.
6026         (init_lineno): Add storage parameter.
6027         (free_linetab, free_linetab_cleanup): Remove.
6028
6029 2019-03-06  Pedro Alves  <palves@redhat.com>
6030
6031         * linux-fork.c (fork_info::clobber_regs): Delete.
6032         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6033         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6034         comment.  Adjust.
6035         (scoped_switch_fork_info::scoped_switch_fork_info)
6036         (checkpoint_command, linux_fork_context): Adjust
6037         fork_save_infrun_state calls.
6038
6039 2019-03-06  Pedro Alves  <palves@redhat.com>
6040
6041         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6042         (inf_has_multiple_threads): Return 'bool' and rewrite using
6043         inferior_info::threads().
6044
6045 2019-03-06  Pedro Alves  <palves@redhat.com>
6046
6047         * linux-fork.c: Include <list>.
6048         (fork_list): Now a std::list instance.
6049         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6050         (forks_exist_p, find_last_fork): Adjust.
6051         (new_fork): Delete.
6052         (one_fork_p): New.
6053         (add_fork): Adjust.
6054         (free_fork): Delete, folded into fork_info::~fork_info().
6055         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6056         Adjust.
6057         (init_fork_list): Delete.
6058         (linux_fork_killall, linux_fork_mourn_inferior)
6059         (linux_fork_detach, info_checkpoints_command): Adjust.
6060         (_initialize_linux_fork): No longer call init_fork_list.
6061
6062 2019-03-06  Pedro Alves  <palves@redhat.com>
6063
6064         * linux-fork.c (new_fork): New, split out of ...
6065         (add_fork): ... this.  Return void.  Move "first fork" special
6066         case from here, to ...
6067         (checkpoint_command): ... here.
6068         * linux-linux.h (add_fork): Return void.
6069
6070 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6073
6074 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6075             Chris January  <chris.january@arm.com>
6076             David Lecomber  <david.lecomber@arm.com>
6077
6078         * f-exp.y: New token, UNOP_INTRINSIC.
6079         (exp): New pattern using UNOP_INTRINSIC token.
6080         (f77_keywords): Add 'abs' keyword.
6081         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6082         (value_from_host_double): New function.
6083         (evaluate_subexp_f): Support UNOP_ABS.
6084
6085 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6088         types.
6089
6090 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6093         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6094         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6095
6096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6099
6100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6101             Chris January  <chris.january@arm.com>
6102
6103         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6104         * f-exp.y: Define 'KIND' token.
6105         (exp): New pattern for KIND expressions.
6106         (ptype): Handle types with a kind extension.
6107         (direct_abs_decl): Extend to spot kind extensions.
6108         (f77_keywords): Add 'kind' to the list.
6109         (push_kind_type): New function.
6110         (convert_to_kind_type): New function.
6111         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6112         * parse.c (operator_length_standard): Likewise.
6113         * parser-defs.h (enum type_pieces): Add tp_kind.
6114         * std-operator.def: Add UNOP_KIND.
6115
6116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * f-exp.y (f_parse): Set yydebug.
6119
6120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * f-lang.c (evaluate_subexp_f): New function.
6123         (exp_descriptor_f): New global.
6124         (f_language_defn): Use exp_descriptor_f instead of
6125         exp_descriptor_standard.
6126
6127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * f-exp.y (struct token): Add comments.
6130         (dot_ops): Remove uppercase versions and the end marker.
6131         (f77_keywords): Likewise.
6132         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6133         entries in the dot_ops array are case insensitive, and use
6134         strncasecmp to compare strings.  Also some whitespace cleanup in
6135         this area.  Similar for the f77_keywords array, except entries in
6136         this list might be case sensitive.
6137
6138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * f-exp.y (struct f77_boolean_val): Add comments.
6141         (boolean_values): Remove uppercase versions, and end marker.
6142         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6143         and use strncasecmp to achieve case insensitivity.  Additionally,
6144         perform whitespace cleanup around this code.
6145
6146 2019-03-06  Tom Tromey  <tromey@adacore.com>
6147
6148         * remote-sim.c (gdbsim_target_open): Use result of
6149         gdb_argv::release.
6150
6151 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6152         Dirk Schubert  <dirk.schubert@arm.com>
6153         Chris January  <chris.january@arm.com>
6154
6155         * eval.c (evaluate_subexp_standard): Call Fortran argument
6156         wrapping logic.
6157         * f-lang.c (struct value): A value which can be passed into a
6158         Fortran function call.
6159         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6160         where appropriate.
6161         (struct type): Value ready for a Fortran function call.
6162         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6163         is needed.
6164         * f-lang.h (fortran_argument_convert): Declaration.
6165         (fortran_preserve_arg_pointer): Declaration.
6166         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6167
6168 2019-03-05  Tom Tromey  <tromey@adacore.com>
6169
6170         * python/py-prettyprint.c (print_string_repr): Remove #if.
6171         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6172
6173 2019-03-05  Tom Tromey  <tromey@adacore.com>
6174
6175         * target.c (the_dummy_target): Move later.  Change type to
6176         "dummy_target".
6177         (initialize_targets): Don't initialize the_dummy_target.
6178
6179 2019-03-05  Tom Tromey  <tromey@adacore.com>
6180
6181         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6182         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6183
6184 2019-03-05  Tom Tromey  <tromey@adacore.com>
6185
6186         * windows-nat.c (windows_nat_target::attach)
6187         (windows_nat_target::detach): Don't call gdb_flush.
6188         * valprint.c (generic_val_print, val_print, val_print_string):
6189         Don't call gdb_flush.
6190         * utils.c (defaulted_query): Don't call gdb_flush.
6191         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6192         * target.c (target_announce_detach): Don't call gdb_flush.
6193         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6194         * remote.c (extended_remote_target::attach): Don't call
6195         gdb_flush.
6196         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6197         * printcmd.c (do_examine): Don't call gdb_flush.
6198         (info_display_command): Don't call gdb_flush.
6199         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6200         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6201         * memattr.c (info_mem_command): Don't call gdb_flush.
6202         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6203         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6204         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6205         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6206         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6207         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6208         (gnu_nat_target::detach): Don't call gdb_flush.
6209         * f-valprint.c (f_val_print): Don't call gdb_flush.
6210         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6211         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6212         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6213         gdb_flush.
6214         * c-valprint.c (c_val_print): Don't call gdb_flush.
6215         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6216
6217 2019-03-05  Tom Tromey  <tromey@adacore.com>
6218
6219         * varobj.c (update_dynamic_varobj_children): Update.
6220         (install_default_visualizer): Use reset, not release.
6221         * value.c (set_internalvar): Update.
6222         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6223         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6224         ATTRIBUTE_UNUSED_RESULT.
6225
6226 2019-03-05  Tom Tromey  <tromey@adacore.com>
6227
6228         * remote.c (class scoped_remote_fd) <release>: Add
6229         ATTRIBUTE_UNUSED_RESULT.
6230
6231 2019-03-05  Tom Tromey  <tromey@adacore.com>
6232
6233         * macroexp.c (struct macro_buffer) <release>: Add
6234         ATTRIBUTE_UNUSED_RESULT.
6235
6236 2019-03-05  Tom Tromey  <tromey@adacore.com>
6237
6238         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6239         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6240         ATTRIBUTE_UNUSED_RESULT.
6241
6242 2019-03-05  Tom Tromey  <tromey@adacore.com>
6243
6244         * common/scoped_fd.h (class scoped_fd) <release>: Add
6245         ATTRIBUTE_UNUSED_RESULT.
6246
6247 2019-03-05  Tom Tromey  <tromey@adacore.com>
6248
6249         * parser-defs.h (struct parser_state) <release>: Add
6250         ATTRIBUTE_UNUSED_RESULT.
6251
6252 2019-03-05  Tom Tromey  <tromey@adacore.com>
6253
6254         * utils.h (class gdb_argv) <release>: Add
6255         ATTRIBUTE_UNUSED_RESULT.
6256         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6257
6258 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6259
6260         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6261         for-loop range, to avoid compiler warnings.
6262
6263         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6264         avoid compiler warnings about unused variables.
6265
6266         * NEWS: Mention end of support for native debugging on MS-Windows
6267         before XP.
6268
6269         PR gdb/24292
6270         * common/netstuff.c:
6271         * gdbserver/gdbreplay.c
6272         * gdbserver/remote-utils.c:
6273         * ser-tcp.c:
6274         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6275         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6276         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6277         'getaddrinfo' and 'freeaddrinfo' were not available before
6278         Windows XP, and mingw.org's MinGW headers by default define
6279         _WIN32_WINNT to 0x500.
6280
6281 2019-03-01  Gary Benson <gbenson@redhat.com>
6282
6283         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6284
6285 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6286             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6287
6288         PR gdb/8527
6289         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6290         set_sigint_trap, clear_sigint_trap.
6291
6292 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6293
6294         * target.c (target_detach): Clear the regcache and the
6295         frame cache.
6296
6297 2019-02-27  Pedro Alves  <palves@redhat.com>
6298
6299         * utils.c (set_screen_size): When we cap the height/width sizes,
6300         tweak the corresponding command variable to show "unlimited":
6301
6302 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6303             Pedro Alves  <palves@redhat.com>
6304
6305         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6306         before calling rl_set_screen_size.
6307
6308 2019-02-27  Tom Tromey  <tromey@adacore.com>
6309
6310         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6311         define.
6312         * python/py-value.c: Remove Python 2.4 workaround.
6313         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6314         workaround.
6315         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6316         Python 2.4 workaround.
6317         * python/python-internal.h: Remove Python 2.4 comment.
6318         (Py_ssize_t): Don't define.
6319         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6320         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6321         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6322         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6323         * python/python.c (do_start_initialization): Remove Python 2.4
6324         workaround.
6325         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6326         (print_children): Remove Python 2.4 workaround.
6327         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6328         workaround.
6329         (CHARBUFFERPROC_NAME): Remove.
6330         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6331         Python 2.4 workaround.
6332
6333 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6334
6335         * NEWS: Note minimum Python version.
6336
6337 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6338
6339         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6340         code from these functions.  Remove corresponding ifdefs.  Use
6341         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6342         Remove gotos and target of gotos.
6343         (infpy_search_memory): Likewise.
6344
6345 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6348         (hppa_gdbarch_init): Don't register deleted functions with
6349         gdbarch.
6350
6351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6354         (h8300_unwind_sp): Delete.
6355         (h8300_dummy_id): Delete.
6356         (h8300_gdbarch_init): Don't register deleted functions with
6357         gdbarch.
6358
6359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6362         (ft32_unwind_pc): Delete.
6363         (ft32_unwind_sp): Delete.
6364         (ft32_gdbarch_init): Don't register deleted functions with
6365         gdbarch.
6366
6367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6368
6369         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6370         (frv_unwind_pc): Delete.
6371         (frv_unwind_sp): Delete.
6372         (frv_gdbarch_init): Don't register deleted functions with
6373         gdbarch.
6374
6375 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6378         (riscv_unwind_pc): Delete.
6379         (riscv_unwind_sp): Delete.
6380         (riscv_gdbarch_init): Don't register deleted functions with
6381         gdbarch.
6382
6383 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6386         (csky_unwind_pc): Delete.
6387         (csky_unwind_sp): Delete.
6388         (csky_gdbarch_init): Don't register deleted functions with
6389         gdbarch.
6390
6391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6394         (cris_unwind_pc): Delete.
6395         (cris_unwind_sp): Delete.
6396         (cris_gdbarch_init): Don't register deleted functions with
6397         gdbarch.
6398
6399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6400
6401         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6402         (bfin_unwind_pc): Delete.
6403         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6404
6405 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6406
6407         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6408         (arm_unwind_pc): Delete.
6409         (arm_unwind_sp): Delete.
6410         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6411
6412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6415         (arc_unwind_pc): Delete.
6416         (arc_unwind_sp): Delete.
6417         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6418
6419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6420
6421         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6422         (alpha_unwind_pc): Delete.
6423         (alpha_gdbarch_init): Don't register deleted functions with
6424         gdbarch.
6425
6426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6429         (aarch64_unwind_pc): Delete.
6430         (aarch64_unwind_sp): Delete.
6431         (aarch64_gdbarch_init): Don't register deleted functions with
6432         gdbarch.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdbtypes.c (type_align): Don't consider static members when
6437         computing structure alignment.
6438
6439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6442         return 0 for other types.
6443         * arch-utils.c (default_type_align): Always return 0.
6444         * gdbarch.h: Regenerate.
6445         * gdbarch.sh (type_align): Extend comment.
6446         * gdbtypes.c (type_align): Add additional comments, always call
6447         gdbarch_type_align before applying the default rules.
6448         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6449         generic code will then apply a suitable default.
6450         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6451         types, return 0 for other types.
6452
6453 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6454
6455         * NEWS: Create a new section for the next release branch.
6456         Rename the section of the current branch, now that it has
6457         been cut.
6458
6459 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6460
6461         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6462         * version.in: Bump version to 8.3.50.DATE-git.
6463
6464 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6465
6466         * aix-thread.c (ptid_cmp): Remove unused variable.
6467         (get_signaled_thread): Likewise.
6468         (store_regs_user_thread): Likewise.
6469         (store_regs_kernel_thread): Likewise.
6470         (fetch_regs_kernel_thread): Remove shadowed variable.
6471
6472 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * features/riscv/32bit-cpu.xml: Add register numbers.
6475         * features/riscv/32bit-fpu.c: Regenerate.
6476         * features/riscv/32bit-fpu.xml: Add register numbers.
6477         * features/riscv/64bit-cpu.xml: Add register numbers.
6478         * features/riscv/64bit-fpu.c: Regenerate.
6479         * features/riscv/64bit-fpu.xml: Add register numbers.
6480
6481 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6482
6483         * NEWS: Mention two argument form of gdb.Value constructor.
6484         * python/py-value.c (convert_buffer_and_type_to_value): New
6485         function.
6486         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6487         Add support for handling an optional second argument.  Call
6488         convert_buffer_and_type_to_value as appropriate.
6489         * python/python-internal.h (Py_buffer_deleter): New struct.
6490         (Py_buffer_up): New typedef.
6491
6492 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6493
6494         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6495         instead of releasing ownership.
6496
6497 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6498
6499         * dwarf2read.c (open_and_init_dwp_file): Call
6500         elf_numsections instead of bfd_count_sections to initialize
6501         dwp_file->num_sections.
6502
6503 2019-02-25  Tom Tromey  <tromey@adacore.com>
6504
6505         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6506
6507 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6508
6509         * gcore.in: Add '--readnever' option when invoking GDB.
6510
6511 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6512
6513         * MAINTAINERS: Update my email address.
6514
6515 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6516
6517         * build-id.c (build_id_to_debug_bfd_1): New function.
6518         (build_id_to_debug_bfd): Look for separate debug file in
6519         sysroot.
6520
6521 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * gdbarch.sh: Update the copyright year range that is placed into
6524         generated files.
6525
6526 2019-02-22  Keith Seitz  <keiths@redhat.com>
6527
6528         PR symtab/23853
6529         * linespec.c (create_sals_line_offset): Search for the default
6530         symtab's filename instead of its fullname.
6531
6532 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6533
6534         * NEWS: Update style defaults.
6535
6536 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6537
6538         * main.c (captured_main_1): Disable styling in batch mode.
6539
6540 2019-02-20  Tom Tromey  <tom@tromey.com>
6541
6542         * symtab.c (symtab_symbol_info): Fix typos.
6543
6544 2019-02-20  Tom Tromey  <tromey@adacore.com>
6545
6546         * findcmd.c (_initialize_mem_search): Use upper case for
6547         metasyntactic variables.
6548
6549 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6550
6551         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6552         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6553
6554 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6555
6556         * top.h (source_file_name): Change to std::string.
6557         * top.c (source_file_name): Likewise.
6558         (command_line_input): Adjust.
6559         * cli/cli-script.c (script_from_file): Adjust.
6560
6561 2019-02-19  Tom Tromey  <tromey@adacore.com>
6562
6563         * ravenscar-thread.c
6564         (ravenscar_thread_target::update_thread_list): Don't call
6565         ada_build_task_list.
6566         * ada-lang.h (ada_build_task_list): Don't declare.
6567         * ada-tasks.c (struct ada_tasks_inferior_data)
6568         <task_list_valid_p>: Now bool.
6569         (read_known_tasks, ada_task_list_changed)
6570         (ada_tasks_invalidate_inferior_data): Update.
6571         (read_known_tasks_array): Return bool.
6572         (read_known_tasks_list): Likewise.
6573         (read_known_tasks): Return void.
6574         (ada_build_task_list): Now static.
6575
6576 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6577
6578         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6579         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6580
6581 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6582
6583         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6584         variant for ada_tasks_pspace_data_handle and
6585         ada_tasks_inferior_data_handle.
6586         (ada_tasks_pspace_data_cleanup): New function.
6587         (ada_tasks_inferior_data_cleanup): New function.
6588
6589 2019-02-17  Tom Tromey  <tom@tromey.com>
6590
6591         * macrotab.h (macro_source_fullname): Return a std::string.
6592         * macrotab.c (macro_include, check_for_redefinition)
6593         (macro_undef, macro_lookup_definition, foreach_macro)
6594         (foreach_macro_in_scope): Update.
6595         (macro_source_fullname): Return a std::string.
6596         * macrocmd.c (show_pp_source_pos): Update.
6597
6598 2019-02-17  Tom Tromey  <tom@tromey.com>
6599
6600         * macrocmd.c (show_pp_source_pos): Style the file names.
6601
6602 2019-02-17  Tom Tromey  <tom@tromey.com>
6603
6604         PR tui/24197:
6605         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6606
6607 2019-02-17  Tom Tromey  <tom@tromey.com>
6608
6609         * ada-lang.c (user_select_syms): Use filtered printing.
6610         * utils.c (wrap_style): New global.
6611         (desired_style): Remove.
6612         (emit_style_escape): Add stream parameter.
6613         (set_output_style, reset_terminal_style, prompt_for_continue):
6614         Update.
6615         (flush_wrap_buffer): Only flush gdb_stdout.
6616         (wrap_here): Set wrap_style.
6617         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6618         treat escape sequences as a character.  Change when wrap buffer is
6619         flushed.
6620         (fputs_styled): Do not set the output style when the default is
6621         requested.
6622         * ui-style.h (struct ui_file_style) <is_default>: New method.
6623         * source.c (print_source_lines_base): Emit escape sequences in one
6624         piece.
6625
6626 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6627
6628         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6629         integers and enumeration types.
6630
6631 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6632
6633         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6634         instead of lookup_symbol_in_language
6635         (do_exact_match): New function.
6636         (ada_get_symbol_name_matcher): Return do_exact_match when
6637         doing a verbatim match.
6638
6639 2019-02-15  Tom Tromey  <tromey@adacore.com>
6640
6641         * ravenscar-thread.c (ravenscar_thread_target::resume)
6642         (ravenscar_thread_target::wait): Special case wildcard requests.
6643
6644 2019-02-15  Tom Tromey  <tromey@adacore.com>
6645
6646         * ravenscar-thread.c (base_ptid): Remove.
6647         (struct ravenscar_thread_target) <close>: New method.
6648         <m_base_ptid>: New member.
6649         <update_inferior_ptid, active_task, task_is_currently_active,
6650         runtime_initialized>: Declare methods.
6651         <ravenscar_thread_target>: Add constructor.
6652         (ravenscar_thread_target::task_is_currently_active)
6653         (ravenscar_thread_target::update_inferior_ptid)
6654         (ravenscar_runtime_initialized): Rename.  Now methods.
6655         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6656         (ravenscar_thread_target::update_thread_list): Update.
6657         (ravenscar_thread_target::active_task): Now method.
6658         (ravenscar_thread_target::store_registers)
6659         (ravenscar_thread_target::prepare_to_store)
6660         (ravenscar_thread_target::prepare_to_store)
6661         (ravenscar_thread_target::mourn_inferior): Update.
6662         (ravenscar_inferior_created): Use "new" to create target.
6663         (ravenscar_thread_target::get_ada_task_ptid): Update.
6664         (_initialize_ravenscar): Don't initialize base_ptid.
6665         (ravenscar_ops): Remove global.
6666
6667 2019-02-15  Tom Tromey  <tromey@adacore.com>
6668
6669         * target.h (push_target): Declare new overload.
6670         * target.c (push_target): New overload, taking an rvalue reference.
6671         * remote.c (remote_target::open_1): Use push_target overload.
6672         * corelow.c (core_target_open): Use push_target overload.
6673
6674 2019-02-15  Tom Tromey  <tromey@adacore.com>
6675
6676         * ravenscar-thread.c (is_ravenscar_task)
6677         (ravenscar_task_is_currently_active): Return bool.
6678         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6679         (_initialize_ravenscar): Remove "(void)".
6680         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6681         Return bool.
6682
6683 2019-02-15  Tom Tromey  <tromey@adacore.com>
6684
6685         * ravenscar-thread.c (ravenscar_runtime_initializer)
6686         (has_ravenscar_runtime, get_running_thread_id)
6687         (ravenscar_thread_target::resume): Fix indentation.
6688
6689 2019-02-15  Tom Tromey  <tromey@adacore.com>
6690
6691         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6692         from ravenscar_arch_ops.
6693         (sparc_ravenscar_ops::fetch_registers)
6694         (sparc_ravenscar_ops::store_registers): Now methods.
6695         (sparc_ravenscar_prepare_to_store): Remove.
6696         (sparc_ravenscar_ops): Redefine.
6697         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6698         methods and destructor.  Remove members.
6699         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6700         (ravenscar_thread_target::store_registers)
6701         (ravenscar_thread_target::prepare_to_store): Update.
6702         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6703         Remove.
6704         (struct ppc_ravenscar_powerpc_ops): Derive from
6705         ravenscar_arch_ops.
6706         (ppc_ravenscar_powerpc_ops::fetch_registers)
6707         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6708         (ppc_ravenscar_powerpc_ops): Redefine.
6709         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6710         (ppc_ravenscar_e500_ops::fetch_registers)
6711         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6712         (ppc_ravenscar_e500_ops): Redefine.
6713         * aarch64-ravenscar-thread.c
6714         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6715         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6716         (aarch64_ravenscar_fetch_registers)
6717         (aarch64_ravenscar_store_registers): Now methods.
6718         (aarch64_ravenscar_ops): Redefine.
6719
6720 2019-02-15  Tom Tromey  <tromey@adacore.com>
6721
6722         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6723         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6724         (ravenscar_thread_target::stopped_by_watchpoint)
6725         (ravenscar_thread_target::stopped_data_address)
6726         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6727
6728 2019-02-15  Tom Tromey  <tromey@adacore.com>
6729
6730         * ravenscar-thread.c: Fix some typos.
6731
6732 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6733             Tom Tromey  <tromey@adacore.com>
6734
6735         * ada-lang.c (ada_exception_sal): Change addr_string to a
6736         std::string.
6737         (create_ada_exception_catchpoint): Update.
6738
6739 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6740             Tom Tromey  <tromey@adacore.com>
6741
6742         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6743         (bp_location_ops): Remove.
6744         (base_breakpoint_allocate_location): Update.
6745         (free_bp_location): Update.
6746         * ada-lang.c (class ada_catchpoint_location)
6747         <ada_catchpoint_location>: Remove ops parameter.
6748         (ada_catchpoint_location_dtor): Remove.
6749         (ada_catchpoint_location_ops): Remove.
6750         (allocate_location_exception): Update.
6751         * breakpoint.h (struct bp_location_ops): Remove.
6752         (class bp_location) <bp_location>: Remove bp_location_ops
6753         parameter.
6754         <~bp_location>: Add destructor.
6755         <ops>: Remove.
6756
6757 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6758             Pedro Alves  <palves@redhat.com>
6759
6760         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6761         'PATH_MAX'.
6762
6763 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6764             Samuel Thibault  <samuel.thibault@gnu.org>
6765             Thomas Schwinge  <thomas@codesourcery.com>
6766
6767         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6768         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6769
6770 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6771
6772         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6773         (check_empty): Use "const char *".
6774
6775         * gnu-nat.c (gnu_nat_target::detach): Instead of
6776         'detach_inferior (pid)' call
6777         'detach_inferior (find_inferior_pid (pid))'.
6778
6779         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6780         'nat/fork-inferior.o'.
6781         * gnu-nat.c: #include "nat/fork-inferior.h".
6782
6783         * gnu-nat.c (gnu_nat_target::detach): Instead of
6784         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6785         * gnu-nat.h: #include "inf-child.h".
6786         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6787         'i386_gnu_nat_target::fetch_registers'.
6788         (gnu_store_registers): Rename/move to
6789         'i386_gnu_nat_target::store_registers'.
6790
6791         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6792         * gnu-nat.h (mach_thread_info): New function.
6793         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6794
6795         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6796
6797 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6798
6799         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6800
6801 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6802
6803         * windows-nat.c (windows_add_thread): Add new parameter
6804         "main_thread_p" with default value set to false.  Update
6805         function documentation as well as all callers.
6806         (windows_delete_thread): Likewise.
6807         (fake_create_process): Update call to windows_add_thread.
6808         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6809         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6810         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6811         call to windows_delete_thread.
6812
6813 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6814
6815         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6816
6817 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6818
6819         * symfile.c (find_separate_debug_file): Use canonical path of
6820         sysroot with child_path instead of gdb_sysroot if it is valid.
6821
6822 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6823
6824         * symfile.c (find_separate_debug_file): Use child_path to
6825         determine if an object file is under a sysroot.
6826
6827 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6828
6829         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6830         unittests/child-path-selftests.c.
6831         * common/pathstuff.c (child_path): New function.
6832         * common/pathstuff.h (child_path): New prototype.
6833         * unittests/child-path-selftests.c: New file.
6834
6835 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6836
6837         * symfile.c (find_separate_debug_file): Look for separate debug
6838         files in debug directories under the sysroot.
6839
6840 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6841
6842         * symtab.h (struct minimal_symbol data_p): New const method.
6843         (struct minimal_symbol text_p): Likewise.
6844         * symtab.c (output_source_filename): Use file name style
6845         to print file name.
6846         (print_symbol_info): Likewise.
6847         (print_msymbol_info): Use address style to print addresses.
6848         Use function name style to print executable text symbols.
6849         (expand_symtab_containing_pc): Use data_p.
6850         (find_pc_sect_compunit_symtab): Likewise.
6851
6852 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6853
6854         * breakpoint.c (describe_other_breakpoints): Use address style
6855         to print addresses.
6856         (say_where): Likewise.
6857
6858 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6859
6860         * ada-typeprint.c (print_func_type): Print function name
6861         style to print function name.
6862         * c-typeprint.c (c_print_type_1): Likewise.
6863
6864 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6865
6866         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6867         for execve.
6868
6869 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6870
6871         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6872         type_stack.
6873
6874 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6875
6876         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6877         TYPE_CODE_REF types.
6878
6879 2019-02-08  Jim Wilson  <jimw@sifive.com>
6880
6881         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6882         (riscv_linux_fregset): New.
6883         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6884
6885 2019-02-07  Tom Tromey  <tom@tromey.com>
6886
6887         * thread.c (thread_cancel_execution_command): Update.
6888         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6889         methods.
6890         (struct thread_fsm_ops): Remove.
6891         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6892         (thread_fsm_should_stop, thread_fsm_return_value)
6893         (thread_fsm_set_finished, thread_fsm_finished_p)
6894         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6895         Don't declare.
6896         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6897         * infrun.c (clear_proceed_status_thread)
6898         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6899         (print_stop_event): Update.
6900         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6901         Add constructor.
6902         (step_command_fsm_ops): Remove.
6903         (new_step_command_fsm): Remove.
6904         (step_1): Update.
6905         (step_command_fsm::should_stop): Rename from
6906         step_command_fsm_should_stop.
6907         (step_command_fsm::clean_up): Rename from
6908         step_command_fsm_clean_up.
6909         (step_command_fsm::do_async_reply_reason): Rename from
6910         step_command_fsm_async_reply_reason.
6911         (struct until_next_fsm): Inherit from thread_fsm.  Add
6912         constructor.
6913         (until_next_fsm_ops): Remove.
6914         (new_until_next_fsm): Remove.
6915         (until_next_fsm::should_stop): Rename from
6916         until_next_fsm_should_stop.
6917         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6918         (until_next_fsm::do_async_reply_reason): Rename from
6919         until_next_fsm_async_reply_reason.
6920         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6921         constructor.  Change type of breakpoint.
6922         (finish_command_fsm_ops): Remove.
6923         (new_finish_command_fsm): Remove.
6924         (finish_command_fsm::should_stop): Rename from
6925         finish_command_fsm_should_stop.
6926         (finish_command_fsm::clean_up): Rename from
6927         finish_command_fsm_clean_up.
6928         (finish_command_fsm::return_value): Rename from
6929         finish_command_fsm_return_value.
6930         (finish_command_fsm::do_async_reply_reason): Rename from
6931         finish_command_fsm_async_reply_reason.
6932         (finish_command): Update.
6933         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6934         Add constructor.
6935         (call_thread_fsm_ops): Remove.
6936         (call_thread_fsm::call_thread_fsm): Rename from
6937         new_call_thread_fsm.
6938         (call_thread_fsm::should_stop): Rename from
6939         call_thread_fsm_should_stop.
6940         (call_thread_fsm::should_notify_stop): Rename from
6941         call_thread_fsm_should_notify_stop.
6942         (run_inferior_call, call_function_by_hand_dummy): Update.
6943         * cli/cli-interp.c (should_print_stop_to_console): Update.
6944         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6945         Add constructor.  Change type of location_breakpoint,
6946         caller_breakpoint.
6947         (until_break_fsm_ops): Remove.
6948         (new_until_break_fsm): Remove.
6949         (until_break_fsm::should_stop): Rename from
6950         until_break_fsm_should_stop.
6951         (until_break_fsm::clean_up): Rename from
6952         until_break_fsm_clean_up.
6953         (until_break_fsm::do_async_reply_reason): Rename from
6954         until_break_fsm_async_reply_reason.
6955         (until_break_command): Update.
6956         * thread-fsm.c: Remove.
6957         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6958
6959 2019-02-07  Tom Tromey  <tom@tromey.com>
6960
6961         * yy-remap.h: Add include guard.
6962         * xtensa-tdep.h: Add include guard.
6963         * xcoffread.h: Rename include guard.
6964         * varobj-iter.h: Add include guard.
6965         * tui/tui.h: Rename include guard.
6966         * tui/tui-winsource.h: Rename include guard.
6967         * tui/tui-wingeneral.h: Rename include guard.
6968         * tui/tui-windata.h: Rename include guard.
6969         * tui/tui-win.h: Rename include guard.
6970         * tui/tui-stack.h: Rename include guard.
6971         * tui/tui-source.h: Rename include guard.
6972         * tui/tui-regs.h: Rename include guard.
6973         * tui/tui-out.h: Rename include guard.
6974         * tui/tui-layout.h: Rename include guard.
6975         * tui/tui-io.h: Rename include guard.
6976         * tui/tui-hooks.h: Rename include guard.
6977         * tui/tui-file.h: Rename include guard.
6978         * tui/tui-disasm.h: Rename include guard.
6979         * tui/tui-data.h: Rename include guard.
6980         * tui/tui-command.h: Rename include guard.
6981         * tic6x-tdep.h: Add include guard.
6982         * target/waitstatus.h: Rename include guard.
6983         * target/wait.h: Rename include guard.
6984         * target/target.h: Rename include guard.
6985         * target/resume.h: Rename include guard.
6986         * target-float.h: Rename include guard.
6987         * stabsread.h: Add include guard.
6988         * rs6000-tdep.h: Add include guard.
6989         * riscv-fbsd-tdep.h: Add include guard.
6990         * regformats/regdef.h: Rename include guard.
6991         * record.h: Rename include guard.
6992         * python/python.h: Rename include guard.
6993         * python/python-internal.h: Rename include guard.
6994         * python/py-stopevent.h: Rename include guard.
6995         * python/py-ref.h: Rename include guard.
6996         * python/py-record.h: Rename include guard.
6997         * python/py-record-full.h: Rename include guard.
6998         * python/py-record-btrace.h: Rename include guard.
6999         * python/py-instruction.h: Rename include guard.
7000         * python/py-events.h: Rename include guard.
7001         * python/py-event.h: Rename include guard.
7002         * procfs.h: Add include guard.
7003         * proc-utils.h: Add include guard.
7004         * p-lang.h: Add include guard.
7005         * or1k-tdep.h: Rename include guard.
7006         * observable.h: Rename include guard.
7007         * nto-tdep.h: Rename include guard.
7008         * nat/x86-linux.h: Rename include guard.
7009         * nat/x86-linux-dregs.h: Rename include guard.
7010         * nat/x86-gcc-cpuid.h: Add include guard.
7011         * nat/x86-dregs.h: Rename include guard.
7012         * nat/x86-cpuid.h: Rename include guard.
7013         * nat/ppc-linux.h: Rename include guard.
7014         * nat/mips-linux-watch.h: Rename include guard.
7015         * nat/linux-waitpid.h: Rename include guard.
7016         * nat/linux-ptrace.h: Rename include guard.
7017         * nat/linux-procfs.h: Rename include guard.
7018         * nat/linux-osdata.h: Rename include guard.
7019         * nat/linux-nat.h: Rename include guard.
7020         * nat/linux-namespaces.h: Rename include guard.
7021         * nat/linux-btrace.h: Rename include guard.
7022         * nat/glibc_thread_db.h: Rename include guard.
7023         * nat/gdb_thread_db.h: Rename include guard.
7024         * nat/gdb_ptrace.h: Rename include guard.
7025         * nat/fork-inferior.h: Rename include guard.
7026         * nat/amd64-linux-siginfo.h: Rename include guard.
7027         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7028         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7029         * nat/aarch64-linux.h: Rename include guard.
7030         * nat/aarch64-linux-hw-point.h: Rename include guard.
7031         * mn10300-tdep.h: Add include guard.
7032         * mips-linux-tdep.h: Add include guard.
7033         * mi/mi-parse.h: Rename include guard.
7034         * mi/mi-out.h: Rename include guard.
7035         * mi/mi-main.h: Rename include guard.
7036         * mi/mi-interp.h: Rename include guard.
7037         * mi/mi-getopt.h: Rename include guard.
7038         * mi/mi-console.h: Rename include guard.
7039         * mi/mi-common.h: Rename include guard.
7040         * mi/mi-cmds.h: Rename include guard.
7041         * mi/mi-cmd-break.h: Rename include guard.
7042         * m2-lang.h: Add include guard.
7043         * location.h: Rename include guard.
7044         * linux-record.h: Rename include guard.
7045         * linux-nat.h: Add include guard.
7046         * linux-fork.h: Add include guard.
7047         * i386-darwin-tdep.h: Rename include guard.
7048         * hppa-linux-offsets.h: Add include guard.
7049         * guile/guile.h: Rename include guard.
7050         * guile/guile-internal.h: Rename include guard.
7051         * gnu-nat.h: Rename include guard.
7052         * gdb-stabs.h: Rename include guard.
7053         * frv-tdep.h: Add include guard.
7054         * f-lang.h: Add include guard.
7055         * event-loop.h: Add include guard.
7056         * darwin-nat.h: Rename include guard.
7057         * cp-abi.h: Rename include guard.
7058         * config/sparc/nm-sol2.h: Rename include guard.
7059         * config/nm-nto.h: Rename include guard.
7060         * config/nm-linux.h: Add include guard.
7061         * config/i386/nm-i386gnu.h: Rename include guard.
7062         * config/djgpp/nl_types.h: Rename include guard.
7063         * config/djgpp/langinfo.h: Rename include guard.
7064         * compile/gcc-cp-plugin.h: Add include guard.
7065         * compile/gcc-c-plugin.h: Add include guard.
7066         * compile/compile.h: Rename include guard.
7067         * compile/compile-object-run.h: Rename include guard.
7068         * compile/compile-object-load.h: Rename include guard.
7069         * compile/compile-internal.h: Rename include guard.
7070         * compile/compile-cplus.h: Rename include guard.
7071         * compile/compile-c.h: Rename include guard.
7072         * common/xml-utils.h: Rename include guard.
7073         * common/x86-xstate.h: Rename include guard.
7074         * common/version.h: Rename include guard.
7075         * common/vec.h: Rename include guard.
7076         * common/tdesc.h: Rename include guard.
7077         * common/selftest.h: Rename include guard.
7078         * common/scoped_restore.h: Rename include guard.
7079         * common/scoped_mmap.h: Rename include guard.
7080         * common/scoped_fd.h: Rename include guard.
7081         * common/safe-iterator.h: Rename include guard.
7082         * common/run-time-clock.h: Rename include guard.
7083         * common/refcounted-object.h: Rename include guard.
7084         * common/queue.h: Rename include guard.
7085         * common/ptid.h: Rename include guard.
7086         * common/print-utils.h: Rename include guard.
7087         * common/preprocessor.h: Rename include guard.
7088         * common/pathstuff.h: Rename include guard.
7089         * common/observable.h: Rename include guard.
7090         * common/netstuff.h: Rename include guard.
7091         * common/job-control.h: Rename include guard.
7092         * common/host-defs.h: Rename include guard.
7093         * common/gdb_wait.h: Rename include guard.
7094         * common/gdb_vecs.h: Rename include guard.
7095         * common/gdb_unlinker.h: Rename include guard.
7096         * common/gdb_unique_ptr.h: Rename include guard.
7097         * common/gdb_tilde_expand.h: Rename include guard.
7098         * common/gdb_sys_time.h: Rename include guard.
7099         * common/gdb_string_view.h: Rename include guard.
7100         * common/gdb_splay_tree.h: Rename include guard.
7101         * common/gdb_setjmp.h: Rename include guard.
7102         * common/gdb_ref_ptr.h: Rename include guard.
7103         * common/gdb_optional.h: Rename include guard.
7104         * common/gdb_locale.h: Rename include guard.
7105         * common/gdb_assert.h: Rename include guard.
7106         * common/filtered-iterator.h: Rename include guard.
7107         * common/filestuff.h: Rename include guard.
7108         * common/fileio.h: Rename include guard.
7109         * common/environ.h: Rename include guard.
7110         * common/common-utils.h: Rename include guard.
7111         * common/common-types.h: Rename include guard.
7112         * common/common-regcache.h: Rename include guard.
7113         * common/common-inferior.h: Rename include guard.
7114         * common/common-gdbthread.h: Rename include guard.
7115         * common/common-exceptions.h: Rename include guard.
7116         * common/common-defs.h: Rename include guard.
7117         * common/common-debug.h: Rename include guard.
7118         * common/cleanups.h: Rename include guard.
7119         * common/buffer.h: Rename include guard.
7120         * common/btrace-common.h: Rename include guard.
7121         * common/break-common.h: Rename include guard.
7122         * cli/cli-utils.h: Rename include guard.
7123         * cli/cli-style.h: Rename include guard.
7124         * cli/cli-setshow.h: Rename include guard.
7125         * cli/cli-script.h: Rename include guard.
7126         * cli/cli-interp.h: Rename include guard.
7127         * cli/cli-decode.h: Rename include guard.
7128         * cli/cli-cmds.h: Rename include guard.
7129         * charset-list.h: Add include guard.
7130         * buildsym-legacy.h: Rename include guard.
7131         * bfin-tdep.h: Add include guard.
7132         * ax.h: Rename include guard.
7133         * arm-linux-tdep.h: Add include guard.
7134         * arm-fbsd-tdep.h: Add include guard.
7135         * arch/xtensa.h: Rename include guard.
7136         * arch/tic6x.h: Add include guard.
7137         * arch/i386.h: Add include guard.
7138         * arch/arm.h: Rename include guard.
7139         * arch/arm-linux.h: Rename include guard.
7140         * arch/arm-get-next-pcs.h: Rename include guard.
7141         * arch/amd64.h: Add include guard.
7142         * arch/aarch64-insn.h: Rename include guard.
7143         * arch-utils.h: Rename include guard.
7144         * annotate.h: Add include guard.
7145         * amd64-darwin-tdep.h: Rename include guard.
7146         * aarch64-linux-tdep.h: Add include guard.
7147         * aarch64-fbsd-tdep.h: Add include guard.
7148         * aarch32-linux-nat.h: Add include guard.
7149
7150 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7151
7152         * macrotab.c (macro_define_internal): New function that
7153         factorizes macro_define_object_internal and macro_define_function
7154         code.
7155         (macro_define_object_internal): Use macro_define_internal.
7156         (macro_define_function): Likewise.
7157
7158 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7159
7160         * macrocmd.c (extract_identifier): Return
7161         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7162         callers.
7163
7164 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7165
7166         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7167
7168 2019-02-05  Tom Tromey  <tom@tromey.com>
7169
7170         * target.c (target_stack::unpush): Move assertion earlier.
7171
7172 2019-01-30  Tom Tromey  <tom@tromey.com>
7173
7174         PR python/23615:
7175         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7176         (gdbpy_parse_and_eval): Likewise.
7177         * python/python-internal.h (gdbpy_allow_threads): New class.
7178
7179 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7180
7181         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7182         (aarch64_fbsd_fpregmap): Move earlier.
7183         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7184         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7185         instead of individual calls to trad_frame_set_reg_addr.
7186         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7187         earlier.
7188         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7189         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7190         instead of individual calls to trad_frame_set_reg_addr.
7191
7192 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7193
7194         * CONTRIBUTE: Replace contribution list with wiki link.
7195
7196 2019-01-25  Tom Tromey  <tom@tromey.com>
7197
7198         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7199
7200 2019-01-25  Tom Tromey  <tom@tromey.com>
7201
7202         * xtensa-linux-nat.c: Fix common/ includes.
7203         * xml-support.h: Fix common/ includes.
7204         * xml-support.c: Fix common/ includes.
7205         * x86-linux-nat.c: Fix common/ includes.
7206         * windows-nat.c: Fix common/ includes.
7207         * varobj.h: Fix common/ includes.
7208         * varobj.c: Fix common/ includes.
7209         * value.c: Fix common/ includes.
7210         * valops.c: Fix common/ includes.
7211         * utils.c: Fix common/ includes.
7212         * unittests/xml-utils-selftests.c: Fix common/ includes.
7213         * unittests/utils-selftests.c: Fix common/ includes.
7214         * unittests/unpack-selftests.c: Fix common/ includes.
7215         * unittests/tracepoint-selftests.c: Fix common/ includes.
7216         * unittests/style-selftests.c: Fix common/ includes.
7217         * unittests/string_view-selftests.c: Fix common/ includes.
7218         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7219         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7220         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7221         * unittests/rsp-low-selftests.c: Fix common/ includes.
7222         * unittests/parse-connection-spec-selftests.c: Fix common/
7223         includes.
7224         * unittests/optional-selftests.c: Fix common/ includes.
7225         * unittests/offset-type-selftests.c: Fix common/ includes.
7226         * unittests/observable-selftests.c: Fix common/ includes.
7227         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7228         * unittests/memrange-selftests.c: Fix common/ includes.
7229         * unittests/memory-map-selftests.c: Fix common/ includes.
7230         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7231         * unittests/function-view-selftests.c: Fix common/ includes.
7232         * unittests/environ-selftests.c: Fix common/ includes.
7233         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7234         * unittests/common-utils-selftests.c: Fix common/ includes.
7235         * unittests/cli-utils-selftests.c: Fix common/ includes.
7236         * unittests/array-view-selftests.c: Fix common/ includes.
7237         * ui-file.c: Fix common/ includes.
7238         * tui/tui-io.c: Fix common/ includes.
7239         * tracepoint.h: Fix common/ includes.
7240         * tracepoint.c: Fix common/ includes.
7241         * tracefile-tfile.c: Fix common/ includes.
7242         * top.h: Fix common/ includes.
7243         * top.c: Fix common/ includes.
7244         * thread.c: Fix common/ includes.
7245         * target/waitstatus.h: Fix common/ includes.
7246         * target/waitstatus.c: Fix common/ includes.
7247         * target.h: Fix common/ includes.
7248         * target.c: Fix common/ includes.
7249         * target-memory.c: Fix common/ includes.
7250         * target-descriptions.c: Fix common/ includes.
7251         * symtab.h: Fix common/ includes.
7252         * symfile.c: Fix common/ includes.
7253         * stap-probe.c: Fix common/ includes.
7254         * spu-linux-nat.c: Fix common/ includes.
7255         * sparc-nat.c: Fix common/ includes.
7256         * source.c: Fix common/ includes.
7257         * solib.c: Fix common/ includes.
7258         * solib-target.c: Fix common/ includes.
7259         * ser-unix.c: Fix common/ includes.
7260         * ser-tcp.c: Fix common/ includes.
7261         * ser-pipe.c: Fix common/ includes.
7262         * ser-base.c: Fix common/ includes.
7263         * selftest-arch.c: Fix common/ includes.
7264         * s12z-tdep.c: Fix common/ includes.
7265         * rust-exp.y: Fix common/ includes.
7266         * rs6000-aix-tdep.c: Fix common/ includes.
7267         * riscv-tdep.c: Fix common/ includes.
7268         * remote.c: Fix common/ includes.
7269         * remote-notif.h: Fix common/ includes.
7270         * remote-fileio.h: Fix common/ includes.
7271         * remote-fileio.c: Fix common/ includes.
7272         * regcache.h: Fix common/ includes.
7273         * regcache.c: Fix common/ includes.
7274         * record-btrace.c: Fix common/ includes.
7275         * python/python.c: Fix common/ includes.
7276         * python/py-type.c: Fix common/ includes.
7277         * python/py-inferior.c: Fix common/ includes.
7278         * progspace.h: Fix common/ includes.
7279         * producer.c: Fix common/ includes.
7280         * procfs.c: Fix common/ includes.
7281         * proc-api.c: Fix common/ includes.
7282         * printcmd.c: Fix common/ includes.
7283         * ppc-linux-nat.c: Fix common/ includes.
7284         * parser-defs.h: Fix common/ includes.
7285         * osdata.c: Fix common/ includes.
7286         * obsd-nat.c: Fix common/ includes.
7287         * nat/x86-linux.c: Fix common/ includes.
7288         * nat/x86-linux-dregs.c: Fix common/ includes.
7289         * nat/x86-dregs.h: Fix common/ includes.
7290         * nat/x86-dregs.c: Fix common/ includes.
7291         * nat/ppc-linux.c: Fix common/ includes.
7292         * nat/mips-linux-watch.h: Fix common/ includes.
7293         * nat/mips-linux-watch.c: Fix common/ includes.
7294         * nat/linux-waitpid.c: Fix common/ includes.
7295         * nat/linux-ptrace.h: Fix common/ includes.
7296         * nat/linux-ptrace.c: Fix common/ includes.
7297         * nat/linux-procfs.c: Fix common/ includes.
7298         * nat/linux-personality.c: Fix common/ includes.
7299         * nat/linux-osdata.c: Fix common/ includes.
7300         * nat/linux-namespaces.c: Fix common/ includes.
7301         * nat/linux-btrace.h: Fix common/ includes.
7302         * nat/linux-btrace.c: Fix common/ includes.
7303         * nat/fork-inferior.c: Fix common/ includes.
7304         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7305         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7306         * nat/aarch64-linux.c: Fix common/ includes.
7307         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7308         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7309         * namespace.h: Fix common/ includes.
7310         * mips-linux-tdep.c: Fix common/ includes.
7311         * minsyms.c: Fix common/ includes.
7312         * mi/mi-parse.h: Fix common/ includes.
7313         * mi/mi-main.c: Fix common/ includes.
7314         * mi/mi-cmd-env.c: Fix common/ includes.
7315         * memrange.h: Fix common/ includes.
7316         * memattr.c: Fix common/ includes.
7317         * maint.h: Fix common/ includes.
7318         * maint.c: Fix common/ includes.
7319         * main.c: Fix common/ includes.
7320         * machoread.c: Fix common/ includes.
7321         * location.c: Fix common/ includes.
7322         * linux-thread-db.c: Fix common/ includes.
7323         * linux-nat.c: Fix common/ includes.
7324         * linux-fork.c: Fix common/ includes.
7325         * inline-frame.c: Fix common/ includes.
7326         * infrun.c: Fix common/ includes.
7327         * inflow.c: Fix common/ includes.
7328         * inferior.h: Fix common/ includes.
7329         * inferior.c: Fix common/ includes.
7330         * infcmd.c: Fix common/ includes.
7331         * inf-ptrace.c: Fix common/ includes.
7332         * inf-child.c: Fix common/ includes.
7333         * ia64-linux-nat.c: Fix common/ includes.
7334         * i387-tdep.c: Fix common/ includes.
7335         * i386-tdep.c: Fix common/ includes.
7336         * i386-linux-tdep.c: Fix common/ includes.
7337         * i386-linux-nat.c: Fix common/ includes.
7338         * i386-go32-tdep.c: Fix common/ includes.
7339         * i386-fbsd-tdep.c: Fix common/ includes.
7340         * i386-fbsd-nat.c: Fix common/ includes.
7341         * guile/scm-type.c: Fix common/ includes.
7342         * guile/guile.c: Fix common/ includes.
7343         * go32-nat.c: Fix common/ includes.
7344         * gnu-nat.c: Fix common/ includes.
7345         * gdbthread.h: Fix common/ includes.
7346         * gdbarch-selftests.c: Fix common/ includes.
7347         * gdb_usleep.c: Fix common/ includes.
7348         * gdb_select.h: Fix common/ includes.
7349         * gdb_bfd.c: Fix common/ includes.
7350         * gcore.c: Fix common/ includes.
7351         * fork-child.c: Fix common/ includes.
7352         * findvar.c: Fix common/ includes.
7353         * fbsd-nat.c: Fix common/ includes.
7354         * event-top.c: Fix common/ includes.
7355         * event-loop.c: Fix common/ includes.
7356         * dwarf2read.c: Fix common/ includes.
7357         * dwarf2loc.c: Fix common/ includes.
7358         * dwarf2-frame.c: Fix common/ includes.
7359         * dwarf-index-cache.c: Fix common/ includes.
7360         * dtrace-probe.c: Fix common/ includes.
7361         * disasm-selftests.c: Fix common/ includes.
7362         * defs.h: Fix common/ includes.
7363         * csky-tdep.c: Fix common/ includes.
7364         * cp-valprint.c: Fix common/ includes.
7365         * cp-support.h: Fix common/ includes.
7366         * cp-support.c: Fix common/ includes.
7367         * corelow.c: Fix common/ includes.
7368         * completer.h: Fix common/ includes.
7369         * completer.c: Fix common/ includes.
7370         * compile/compile.c: Fix common/ includes.
7371         * compile/compile-loc2c.c: Fix common/ includes.
7372         * compile/compile-cplus-types.c: Fix common/ includes.
7373         * compile/compile-cplus-symbols.c: Fix common/ includes.
7374         * command.h: Fix common/ includes.
7375         * cli/cli-dump.c: Fix common/ includes.
7376         * cli/cli-cmds.c: Fix common/ includes.
7377         * charset.c: Fix common/ includes.
7378         * build-id.c: Fix common/ includes.
7379         * btrace.h: Fix common/ includes.
7380         * btrace.c: Fix common/ includes.
7381         * breakpoint.h: Fix common/ includes.
7382         * breakpoint.c: Fix common/ includes.
7383         * ax.h:
7384         (enum agent_op): Fix common/ includes.
7385         * ax-general.c (struct aop_map): Fix common/ includes.
7386         * ax-gdb.c: Fix common/ includes.
7387         * auxv.c: Fix common/ includes.
7388         * auto-load.c: Fix common/ includes.
7389         * arm-tdep.c: Fix common/ includes.
7390         * arch/riscv.c: Fix common/ includes.
7391         * arch/ppc-linux-common.c: Fix common/ includes.
7392         * arch/i386.c: Fix common/ includes.
7393         * arch/arm.c: Fix common/ includes.
7394         * arch/arm-linux.c: Fix common/ includes.
7395         * arch/arm-get-next-pcs.c: Fix common/ includes.
7396         * arch/amd64.c: Fix common/ includes.
7397         * arch/aarch64.c: Fix common/ includes.
7398         * arch/aarch64-insn.c: Fix common/ includes.
7399         * arch-utils.c: Fix common/ includes.
7400         * amd64-windows-tdep.c: Fix common/ includes.
7401         * amd64-tdep.c: Fix common/ includes.
7402         * amd64-sol2-tdep.c: Fix common/ includes.
7403         * amd64-obsd-tdep.c: Fix common/ includes.
7404         * amd64-nbsd-tdep.c: Fix common/ includes.
7405         * amd64-linux-tdep.c: Fix common/ includes.
7406         * amd64-linux-nat.c: Fix common/ includes.
7407         * amd64-fbsd-tdep.c: Fix common/ includes.
7408         * amd64-fbsd-nat.c: Fix common/ includes.
7409         * amd64-dicos-tdep.c: Fix common/ includes.
7410         * amd64-darwin-tdep.c: Fix common/ includes.
7411         * agent.c: Fix common/ includes.
7412         * ada-lang.h: Fix common/ includes.
7413         * ada-lang.c: Fix common/ includes.
7414         * aarch64-tdep.c: Fix common/ includes.
7415
7416 2019-01-25  Tom Tromey  <tom@tromey.com>
7417
7418         * common/create-version.sh: Use common/version.h.
7419
7420 2019-01-24  Pedro Alves  <palves@redhat.com>
7421
7422         * infrun.c (signal_stop, signal_print, signal_program)
7423         (signal_catch, signal_pass): Now arrays instead of pointers.
7424         (update_signals_program_target, do_target_resume)
7425         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7426         * linux-nat.c (linux_nat_target::pass_signals)
7427         (linux_nat_target::create_inferior, linux_nat_target::attach):
7428         Adjust.
7429         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7430         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7431         * procfs.c (procfs_target::pass_signals): Adjust.
7432         * record-full.c (record_full_target::resume): Adjust.
7433         * remote.c (remote_target::pass_signals)
7434         (remote_target::program_signals): Adjust.
7435         * target-debug.h (target_debug_print_signals): Now takes a
7436         gdb::array_view as parameter.  Adjust.
7437         * target.h (target_ops) <pass_signals, program_signals>: Replace
7438         pointer and length parameters with gdb::array_view.
7439         (target_pass_signals, target_program_signals): Likewise.
7440         * target-delegates.c: Regenerate.
7441
7442 2019-01-24  Pedro Alves  <palves@redhat.com>
7443
7444         * common/forward-scope-exit.h
7445         (forward_scope_exit::forward_scope_exit): Pass arguments to
7446         m_bind_function directly, instead of creating a std::bind and
7447         copying that.
7448
7449 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7450
7451         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7452         for static members.
7453         (pass_in_v_vfp_candidate): Likewise.
7454
7455 2019-01-23  Tom Tromey  <tom@tromey.com>
7456             Pedro Alves  <palves@redhat.com>
7457
7458         * regcache.c (class regcache_invalidator): Remove.
7459         (regcache::raw_write): Use make_scope_exit.
7460
7461 2019-01-23  Tom Tromey  <tom@tromey.com>
7462
7463         * ui-out.h (class ui_out_emit_type): Update comment.
7464
7465 2019-01-23  Tom Tromey  <tom@tromey.com>
7466
7467         * infrun.c (fetch_inferior_event): Update comment.
7468
7469 2019-01-23  Tom Tromey  <tom@tromey.com>
7470             Pedro Alves  <palves@redhat.com>
7471
7472         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7473         parameter.
7474         (fetch_inferior_event): Use SCOPE_EXIT.
7475
7476
7477 2019-01-23  Tom Tromey  <tom@tromey.com>
7478             Pedro Alves  <palves@redhat.com>
7479
7480         * infrun.c (disable_thread_events): Delete.
7481         (stop_all_threads): Use SCOPE_EXIT.
7482
7483 2019-01-23  Tom Tromey  <tom@tromey.com>
7484             Pedro Alves  <palves@redhat.com>
7485
7486         * symfile.c: Include forward-scope-exit.h.
7487         (clear_symtab_users_cleanup): Replace forward declaration with
7488         a FORWARD_SCOPE_EXIT.
7489         (syms_from_objfile_1): Use the forward_scope_exit and
7490         gdb::optional instead of cleanup_function.
7491         (reread_symbols): Use the forward_scope_exit instead of
7492         cleanup_function.
7493         (clear_symtab_users_cleanup): Remove function.
7494
7495 2019-01-23  Tom Tromey  <tom@tromey.com>
7496             Pedro Alves  <palves@redhat.com>
7497
7498         * linux-nat.c: Include scope-exit.h.
7499         (cleanup_target_stop): Remove.
7500         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7501         SCOPE_EXIT.
7502
7503 2019-01-23  Tom Tromey  <tom@tromey.com>
7504             Pedro Alves  <palves@redhat.com>
7505
7506         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7507         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7508
7509 2019-01-23  Tom Tromey  <tom@tromey.com>
7510             Andrew Burgess  <andrew.burgess@embecosm.com>
7511             Pedro Alves  <palves@redhat.com>
7512
7513         * infrun.c (fetch_inferior_event): Use scope_exit.
7514         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7515         * top.c (execute_command): Use scope_exit.
7516         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7517         * utils.c (do_bpstat_clear_actions_cleanup)
7518         (make_bpstat_clear_actions_cleanup): Remove.
7519
7520 2019-01-23  Tom Tromey  <tom@tromey.com>
7521             Pedro Alves  <palves@redhat.com>
7522
7523         * infrun.c: Include "common/scope-exit.h"
7524         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7525         (wait_for_inferior): Use SCOPE_EXIT.
7526         (fetch_inferior_event): Use scope_exit.
7527
7528 2019-01-23  Tom Tromey  <tom@tromey.com>
7529             Pedro Alves  <palves@redhat.com>
7530
7531         * breakpoint.c (create_breakpoint): Remove cleanup.
7532
7533 2019-01-23  Tom Tromey  <tom@tromey.com>
7534             Andrew Burgess  <andrew.burgess@embecosm.com>
7535             Pedro Alves  <palves@redhat.com>
7536
7537 2019-01-23  Pedro Alves  <palves@redhat.com>
7538
7539         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7540
7541 2019-01-23  Pedro Alves  <palves@redhat.com>
7542             Andrew Burgess  <andrew.burgess@embecosm.com>
7543
7544         * gdbthread.h: Include "common/forward-scope-exit.h".
7545         (scoped_finish_thread_state): Redefine custom class in terms of
7546         forward_scope_exit.
7547
7548 2019-01-23  Pedro Alves  <palves@redhat.com>
7549             Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * common/forward-scope-exit.h: New file.
7552
7553 2019-01-23  Pedro Alves  <palves@redhat.com>
7554             Andrew Burgess  <andrew.burgess@embecosm.com>
7555             Tom Tromey  <tom@tromey.com>
7556
7557         * common/scope-exit.h: New file.
7558
7559 2019-01-23  Pedro Alves  <palves@redhat.com>
7560
7561         * common/preprocessor.h (ESC): Rename to ...
7562         (ESC_PARENS): ... this.
7563         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7564         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7565
7566 2019-01-23  Tom Tromey  <tom@tromey.com>
7567
7568         * language.h (class scoped_switch_to_sym_language_if_auto):
7569         Initialize m_lang in both cases.
7570
7571 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7572
7573         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7574         with XCNEW.
7575
7576 2019-01-22  Tom Tromey  <tom@tromey.com>
7577
7578         * corelow.c: Do not include sys/file.h.
7579
7580 2019-01-22  Tom Tromey  <tom@tromey.com>
7581
7582         * tui/tui-wingeneral.h: Include gdb_curses.h.
7583
7584 2019-01-22  Tom Tromey  <tom@tromey.com>
7585
7586         * source-cache.h (class source_cache) <get_source_lines,
7587         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7588
7589 2019-01-22  Tom Tromey  <tom@tromey.com>
7590
7591         * remote-fileio.h (struct remote_target): Declare.
7592
7593 2019-01-22  Tom Tromey  <tom@tromey.com>
7594
7595         * python/py-arch.c: Do not include py-ref.h.
7596         * python/py-bpevent.c: Do not include py-ref.h.
7597         * python/py-cmd.c: Do not include py-ref.h.
7598         * python/py-continueevent.c: Do not include py-ref.h.
7599         * python/py-event.h: Do not include py-ref.h.
7600         * python/py-evtregistry.c: Do not include py-ref.h.
7601         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7602         * python/py-frame.c: Do not include py-ref.h.
7603         * python/py-framefilter.c: Do not include py-ref.h.
7604         * python/py-function.c: Do not include py-ref.h.
7605         * python/py-infevents.c: Do not include py-ref.h.
7606         * python/py-linetable.c: Do not include py-ref.h.
7607         * python/py-objfile.c: Do not include py-ref.h.
7608         * python/py-param.c: Do not include py-ref.h.
7609         * python/py-prettyprint.c: Do not include py-ref.h.
7610         * python/py-progspace.c: Do not include py-ref.h.
7611         * python/py-symbol.c: Do not include py-ref.h.
7612         * python/py-symtab.c: Do not include py-ref.h.
7613         * python/py-type.c: Do not include py-ref.h.
7614         * python/py-unwind.c: Do not include py-ref.h.
7615         * python/py-utils.c: Do not include py-ref.h.
7616         * python/py-value.c: Do not include py-ref.h.
7617         * python/py-varobj.c: Do not include py-ref.h.
7618         * python/py-xmethods.c: Do not include py-ref.h.
7619         * python/python.c: Do not include py-ref.h.
7620         * varobj.c: Do not include py-ref.h.
7621
7622 2019-01-22  Tom Tromey  <tom@tromey.com>
7623
7624         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7625         keyword for bcache.
7626
7627 2019-01-22  Tom Tromey  <tom@tromey.com>
7628
7629         * compile/compile-cplus-types.c: Remove a comment by #include.
7630
7631 2019-01-22  Tom Tromey  <tom@tromey.com>
7632
7633         * compile/gcc-c-plugin.h: Include compile-internal.h.
7634
7635 2019-01-22  Tom Tromey  <tom@tromey.com>
7636
7637         * stabsread.c (EXTERN): Do not define.
7638         (symnum, next_symbol_text_func, processing_gcc_compilation)
7639         (within_function, global_sym_chain, global_stabs)
7640         (previous_stab_code, this_object_header_files)
7641         (n_this_object_header_files)
7642         (n_allocated_this_object_header_files): Define.
7643         * stabsread.h (EXTERN): Never define.  Use "extern".
7644
7645 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7646
7647         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7648         history_value.
7649
7650 2019-01-21  Tom Tromey  <tom@tromey.com>
7651
7652         * ui-out.c: Fix includes.
7653         * tui/tui-source.c: Fix includes.
7654         * target.c: Fix includes.
7655         * remote.c: Fix includes.
7656         * regcache.c: Fix includes.
7657         * python/py-block.c: Fix includes.
7658         * printcmd.c: Fix includes.
7659         * or1k-tdep.c: Fix includes.
7660         * mi/mi-main.c: Fix includes.
7661         * m32r-tdep.c: Fix includes.
7662         * csky-tdep.c: Fix includes.
7663         * compile/compile-cplus-types.c: Fix includes.
7664         * cli/cli-interp.c: Fix includes.
7665
7666 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7669         for padding.
7670
7671 2019-01-16  Tom Tromey  <tom@tromey.com>
7672
7673         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7674         earlier.
7675         (struct objfile) <msymbols_range>: Move from top level.
7676         <msymbols>: New method.
7677         (class objfile_msymbols): Remove.
7678         * symtab.c (default_collect_symbol_completion_matches_break_on):
7679         Update.
7680         * symmisc.c (dump_msymbols): Update.
7681         * stabsread.c (scan_file_globals): Update.
7682         * objc-lang.c (info_selectors_command, info_classes_command)
7683         (find_methods): Update.
7684         * minsyms.c (find_solib_trampoline_target): Update.
7685         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7686         * coffread.c (coff_symfile_read): Update.
7687         * ada-lang.c (ada_lookup_simple_minsym)
7688         (ada_collect_symbol_completion_matches): Update.
7689
7690 2019-01-16  Tom Tromey  <tom@tromey.com>
7691
7692         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7693         type.  Remove no-argument constructor.
7694         <iterator::operator++>: Simplify.
7695         <begin>: Update.
7696         <end>: Use minimal_symbol_count.
7697
7698 2019-01-16  Tom Tromey  <tom@tromey.com>
7699
7700         * objfiles.h (struct objfile) <psymtabs>: New method.
7701         (class objfile_psymtabs): Remove.
7702         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7703         typedef.
7704         <range>: New method.
7705         (require_partial_symbols): Change return type.
7706         * psymtab.c (require_partial_symbols)
7707         (psym_expand_symtabs_matching): Update.
7708         * mdebugread.c (parse_partial_symbols): Update.
7709         * dbxread.c (dbx_end_psymtab): Update.
7710
7711 2019-01-15  Tom Tromey  <tom@tromey.com>
7712
7713         * symtab.c (lookup_objfile_from_block)
7714         (lookup_symbol_in_objfile_symtabs)
7715         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7716         (find_line_symtab, info_sources_command)
7717         (default_collect_symbol_completion_matches_break_on)
7718         (make_source_files_completion_list): Update.
7719         * symmisc.c (print_objfile_statistics, dump_objfile)
7720         (maintenance_print_symbols, maintenance_info_symtabs)
7721         (maintenance_check_symtabs, maintenance_info_line_tables):
7722         Update.
7723         * source.c (select_source_symtab)
7724         (forget_cached_source_info_for_objfile): Update.
7725         * objfiles.h (class objfile_compunits): Remove.
7726         (struct objfile) <compunits_range>: New typedef.
7727         (compunits): New method.
7728         * objfiles.c (objfile_relocate1): Update.
7729         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7730         * maint.c (count_symtabs_and_blocks): Update.
7731         * linespec.c (iterate_over_all_matching_symtabs): Update.
7732         * cp-support.c (add_symbol_overload_list_qualified): Update.
7733         * coffread.c (coff_symtab_read): Update.
7734         * ada-lang.c (add_nonlocal_symbols)
7735         (ada_collect_symbol_completion_matches)
7736         (ada_add_global_exceptions): Update.
7737
7738 2019-01-15  Tom Tromey  <tom@tromey.com>
7739
7740         * progspace.h (program_space) <objfiles_safe_range>: New
7741         typedef.
7742         <objfiles_safe>: New method.
7743         * objfiles.h (class all_objfiles_safe): Remove.
7744         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7745         * jit.c (jit_inferior_exit_hook): Update.
7746
7747 2019-01-17  Tom Tromey  <tom@tromey.com>
7748
7749         * progspace.h (program_space) <objfiles_range>: New typedef.
7750         <objfiles>: New method.
7751         <objfiles_head>: Rename from objfiles.
7752         (object_files): Update.
7753         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7754         * guile/scm-pretty-print.c
7755         (ppscm_find_pretty_printer_from_objfiles): Update.
7756         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7757         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7758         Update.
7759         * python/py-progspace.c (pspy_get_objfiles): Update.
7760         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7761         Update.
7762         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7763         (objfpy_lookup_objfile_by_build_id): Update.
7764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7765         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7766         Update.
7767         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7768         (expand_symtab_containing_pc, lookup_objfile_from_block)
7769         (lookup_static_symbol, basic_lookup_transparent_type)
7770         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7771         (find_line_symtab, info_sources_command)
7772         (default_collect_symbol_completion_matches_break_on)
7773         (make_source_files_completion_list, find_main_name): Update.
7774         * symmisc.c (print_symbol_bcache_statistics)
7775         (print_objfile_statistics, maintenance_print_symbols)
7776         (maintenance_print_msymbols, maintenance_print_objfiles)
7777         (maintenance_info_symtabs, maintenance_check_symtabs)
7778         (maintenance_expand_symtabs, maintenance_info_line_tables):
7779         Update.
7780         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7781         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7782         (map_overlay_command, unmap_overlay_command)
7783         (simple_overlay_update, expand_symtabs_matching)
7784         (map_symbol_filenames): Update.
7785         * symfile-debug.c (set_debug_symfile): Update.
7786         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7787         Update.
7788         * source.c (select_source_symtab, forget_cached_source_info):
7789         Update.
7790         * solib.c (solib_read_symbols): Update.
7791         * solib-spu.c (append_ocl_sos): Update.
7792         * psymtab.c (maintenance_print_psymbols)
7793         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7794         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7795         * printcmd.c (info_symbol_command): Update.
7796         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7797         Update.
7798         * objfiles.h (class all_objfiles): Remove.
7799         * objfiles.c (have_partial_symbols, have_full_symbols)
7800         (have_minimal_symbols, qsort_cmp, update_section_map)
7801         (shared_objfile_contains_address_p)
7802         (default_iterate_over_objfiles_in_search_order): Update.
7803         * objc-lang.c (info_selectors_command, info_classes_command)
7804         (find_methods): Update.
7805         * minsyms.c (find_solib_trampoline_target): Update.
7806         * maint.c (maintenance_info_sections)
7807         (maintenance_translate_address, count_symtabs_and_blocks):
7808         Update.
7809         * main.c (captured_main_1): Update.
7810         * linux-thread-db.c (try_thread_db_load_from_pdir)
7811         (has_libpthread): Update.
7812         * linespec.c (iterate_over_all_matching_symtabs)
7813         (search_minsyms_for_name): Update.
7814         * jit.c (jit_find_objf_with_entry_addr): Update.
7815         * hppa-tdep.c (find_unwind_entry)
7816         (hppa_lookup_stub_minimal_symbol): Update.
7817         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7818         Update.
7819         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7820         (elf_gnu_ifunc_resolve_by_got): Update.
7821         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7822         * dwarf-index-write.c (save_gdb_index_command): Update.
7823         * cp-support.c (add_symbol_overload_list_qualified): Update.
7824         * breakpoint.c (create_overlay_event_breakpoint)
7825         (create_longjmp_master_breakpoint)
7826         (create_std_terminate_master_breakpoint)
7827         (create_exception_master_breakpoint): Update.
7828         * blockframe.c (find_pc_partial_function): Update.
7829         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7830         (ada_collect_symbol_completion_matches)
7831         (ada_add_global_exceptions): Update.
7832
7833 2019-01-17  Tom Tromey  <tom@tromey.com>
7834
7835         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7836         declare VEC.
7837         (solib_target_parse_libraries): Change return type.
7838         (library_list_start_segment, library_list_start_section)
7839         (library_list_end_library, library_list_start_library); Update.
7840         (solib_target_free_library_list): Remove.
7841         (solib_target_parse_libraries): Remove cleanup.  Change return
7842         type.
7843         (solib_target_current_sos): Update.
7844
7845 2019-01-17  Tom Tromey  <tromey@bapiya>
7846
7847         * valprint.c: Replace "the the" with "the".
7848         * symtab.c: Replace "the the" with "the".
7849         * solib.c: Replace "the the" with "the".
7850         * solib-dsbt.c: Replace "the the" with "the".
7851         * linespec.c: Replace "the the" with "the".
7852         * dwarf2loc.h: Replace "the the" with "the".
7853         * amd64-windows-tdep.c: Replace "the the" with "the".
7854         * aarch64-tdep.c: Replace "the the" with "the".
7855
7856 2019-01-16  Keith Seitz  <keiths@redhat.com>
7857
7858         PR gdb/23773
7859         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7860         <builder>: Rename to ..
7861         <m_builder>: ... this and make private.
7862         (dwarf2_cu::get_builder): New method.  Change all users of
7863         `builder' to use this method.
7864         (dwarf2_start_symtab): Move to ...
7865         (dwarf2_cu::start_symtab): ... here.  Update all callers
7866         (setup_type_unit_groups): Move to ...
7867         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7868         callers.
7869         (dwarf2_cu::reset_builder): New method.
7870         (process_full_compunit, process_full_type_unit): Use
7871         dwarf2_cu::reset_builder.
7872         (follow_die_offset): Record the ancestor CU if it is different
7873         from the followed DIE's CU.
7874         (follow_die_sig_1): Likewise.
7875
7876 2019-01-15  Tom Tromey  <tom@tromey.com>
7877
7878         * remote.c (class remote_state) <buf>: Now a char_vector.
7879         <buf_size>: Remove.
7880         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7881         parameter.
7882         (remote_target::getpkt_or_notif_sane_1)
7883         (remote_target::getpkt_sane)
7884         (remote_target::getpkt_or_notif_sane): Likewise.
7885         (class remote_target) <putpkt>: New overload.
7886         (remote_target::read_frame): Change type of "buf_p".  Remove
7887         sizeof_p parameter.
7888         (packet_ok): New overload.
7889         (packet_check_result): New overload.
7890         Update all uses.
7891
7892 2019-01-14  Tom Tromey  <tom@tromey.com>
7893
7894         * remote-notif.c (handle_notification, remote_notif_ack)
7895         (remote_notif_parse): Make "buf" const.
7896         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7897         const.
7898         (remote_notif_parse, remote_notif_ack, handle_notification):
7899         Likewise.
7900         * remote.c (remote_notif_stop_parse): Make "buf" const.
7901         (remote_target::remote_parse_stop_reply): Make "buf" const.
7902         (remote_notif_stop_ack): Make "buf" const.
7903
7904 2019-01-14  Tom Tromey  <tom@tromey.com>
7905
7906         * remote.c (remote_console_output): Make parameter const.
7907
7908 2019-01-14  Tom Tromey  <tom@tromey.com>
7909
7910         * target-debug.h (target_debug_print_signals): Constify.
7911         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7912         * procfs.c (procfs_target::pass_signals): Update.
7913         * linux-nat.c (linux_nat_target::pass_signals): Update.
7914         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7915         * target-delegates.c: Rebuild.
7916         * remote.c (remote_target::program_signals): Update.
7917         (remote_target::pass_signals): Update.
7918         * target.c (target_pass_signals): Constify argument.
7919         (target_program_signals): Likewise.
7920         * target.h (struct target_ops) <pass_signals, program_signals>:
7921         Constify argument.
7922         (target_pass_signals, target_program_signals): Constify argument.
7923
7924 2019-01-14  Tom Tromey  <tom@tromey.com>
7925
7926         PR tui/28819:
7927         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7928
7929 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7930
7931         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7932         field.
7933         * rs6000-tdep.c: Include reggroups.h.
7934         (IS_V_ALIAS_PSEUDOREG): Define.
7935         (rs6000_register_name): Return names for the "vX" aliases.
7936         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7937         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7938         aliases.  Call default_register_reggroup_p for all other
7939         pseudo-registers.
7940         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7941         New functions.
7942         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7943         Handle "vX" aliases.
7944         (v_alias_pseudo_register_collect): New function.
7945         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7946         (rs6000_gdbarch_init): Initialize "vX" aliases as
7947         pseudo-registers.  Restore registration of
7948         rs6000_pseudo_register_reggroup_p with
7949         set_tdesc_pseudo_register_reggroup_p.
7950
7951 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7952
7953         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7954         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7955         set_gdbarch_num_pseudo_regs.
7956
7957 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7958
7959         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7960         Remove arg prefixname, add do_set and do_show.
7961         Add member functions set_list and show_list.
7962         * cli/cli-style.c (class cli_style_option): Update accordingly.
7963         (style_set_list): Move to file scope.
7964         (style_show_list): Likewise.
7965         (set_style): Call help_list.
7966         (show_style): Call cmd_show_list.
7967         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7968         Update to use the new macro.
7969
7970 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7971
7972         * ada-lang.c (_initialize_ada_language): Expand the help text
7973         for the "catch exception" command.
7974
7975 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7976
7977         * symtab.c (matching_obj_sections): Initialize obj,
7978         declare it closer to its usage.
7979
7980 2019-01-10  Tom Tromey  <tom@tromey.com>
7981
7982         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7983         (basic_inf_threads_range): Remove.
7984         (inf_threads_range, inf_non_exited_threads_range)
7985         (safe_inf_threads_range): Use next_adapter.
7986
7987 2019-01-10  Keith Seitz  <keiths@redhat.com>
7988
7989         PR gdb/23712
7990         PR symtab/23010
7991         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7992         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7993
7994 2019-01-10  Keith Seitz  <keiths@redhat.com>
7995
7996         PR gdb/23712
7997         PR symtab/23010
7998         * dictionary.c (pending_to_vector): Remove.
7999         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8000         Remove _1 suffix, replacing functions of the same name.  Update
8001         all callers.
8002         (dict_create_hashed, dict_create_hashed_expandable)
8003         (dict_create_linear, dict_create_linear_expandable, dict_free)
8004         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8005         Make functions static.
8006
8007 2019-01-10  Keith Seitz  <keiths@redhat.com>
8008
8009         PR gdb/23712
8010         PR symtab/23010
8011         * dictionary.h (struct dictionary): Replace declaration with
8012         multidictionary.
8013         (dict_create_hashed, dict_create_hashed_expandable)
8014         (dict_create_linear, dict_create_linear_expandable)
8015         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8016         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8017         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8018         taking multidictionary argument.
8019         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8020         * block.h (struct block) <dict>: Change to multidictionary
8021         and rename `multidict'.
8022         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8023         symmisc.c: Update all dictionary references to multidictionary.
8024
8025 2019-01-10  Keith Seitz  <keiths@redhat.com>
8026
8027         PR gdb/23712
8028         PR symtab/23010
8029         * dictionary.c: Include unordered_map.
8030         (pending_to_vector): New function.
8031         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8032         Rewrite the non-"_1" functions to take vector instead
8033         of linked list.
8034         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8035         "new" _1 versions of the same name.
8036         (multidictionary): Define.
8037         (std::hash<enum language): New definition.
8038         (collate_pending_symbols_by_language, mdict_create_hashed)
8039         (mdict_create_hashed_expandable, mdict_create_linear)
8040         (mdict_create_linear_expandable, mdict_free)
8041         (find_language_dictionary, create_new_language_dictionary)
8042         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8043         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8044         (mdict_size, mdict_empty): New functions.
8045         * dictionary.h (mdict_iterator): Define.
8046
8047 2019-01-10  Pedro Alves  <palves@redhat.com>
8048
8049         * breakpoint.c (read_uploaded_action)
8050         (create_tracepoint_from_upload): Adjust to use
8051         gdb::unique_xmalloc_ptr.
8052         * ctf.c (ctf_write_uploaded_tp):
8053         (SET_ARRAY_FIELD): Use emplace_back.
8054         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8055         * tracefile-tfile.c (tfile_write_uploaded_tp):
8056         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8057         gdb::unique_xmalloc_ptr.
8058         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8059         at_string, cond_string, cmd_strings>: Replace char pointers
8060         with gdb::unique_xmalloc_ptr.
8061
8062 2019-01-10  Pedro Alves  <palves@redhat.com>
8063
8064         * solib-target.c (library_list_start_library): Don't xstrdup name.
8065
8066 2019-01-10  Pedro Alves  <palves@redhat.com>
8067
8068         * mdebugread.c (parse_partial_symbols): Use
8069         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8070
8071 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8072
8073         * linux-fork.c (scoped_switch_fork_info)
8074         <~scoped_switch_fork_info>: Fix incorrect variable name.
8075
8076 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * linux-fork.c (scoped_switch_fork_info)
8079         <scoped_switch_fork_info>: Make explicit.
8080         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8081
8082 2019-01-10  Tom Tromey  <tom@tromey.com>
8083
8084         * objfiles.h (objfile::reset_psymtabs): Update.
8085         * objfiles.c (objfile::objfile): Update.
8086         * psymtab.h (psymtab_storage::obstack): Update.
8087         (psymtab_storage::m_obstack): Use gdb::optional.
8088         (class psymtab_storage): Update comment.  Remove objfile
8089         parameter.
8090         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8091
8092 2019-01-10  Tom Tromey  <tom@tromey.com>
8093
8094         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8095         <free_psymtabs>: Now private.
8096         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8097         (allocate_psymtab): Use new method.
8098
8099 2019-01-10  Tom Tromey  <tom@tromey.com>
8100
8101         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8102         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8103         * mdebugread.c (parse_partial_symbols): Use
8104         allocate_dependencies.
8105         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8106         allocate_dependencies.
8107         (process_psymtab_comp_unit_reader)
8108         (build_type_psymtab_dependencies): Likewise.
8109         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8110
8111 2019-01-10  Tom Tromey  <tom@tromey.com>
8112
8113         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8114         PSYMBOL_SET_LANGUAGE.
8115         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8116
8117 2019-01-10  Tom Tromey  <tom@tromey.com>
8118
8119         * psymtab.h (psymtab_storage::obstack): New method.
8120         <m_obstack>: Rename from obstack; now private.
8121         * psymtab.c (psymtab_storage): Update.
8122         * dwarf2read.c (create_addrmap_from_index)
8123         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8124         Update.
8125
8126 2019-01-10  Tom Tromey  <tom@tromey.com>
8127
8128         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8129         * objfiles.h (objfile::reset_psymtabs): New method.
8130
8131 2019-01-10  Tom Tromey  <tom@tromey.com>
8132
8133         * symmisc.c (print_symbol_bcache_statistics): Update.
8134         (print_objfile_statistics): Update.
8135         * symfile.c (reread_symbols): Update.
8136         * psymtab.h (class psymtab_storage): New.
8137         * psymtab.c (psymtab_storage): New constructor.
8138         (~psymtab_storage): New destructor.
8139         (require_partial_symbols): Update.
8140         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8141         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8142         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8143         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8144         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8145         (start_psymtab_common, end_psymtab_common)
8146         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8147         (allocate_psymtab): Update.
8148         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8149         Update.
8150         (dump_psymtab_addrmap, maintenance_print_psymbols)
8151         (maintenance_check_psymtabs): Update.
8152         (class objfile_psymtabs): Move to objfiles.h.
8153         * psympriv.h (discard_psymtab): Now inline.
8154         (psymtab_discarder::psymtab_discarder): Update.
8155         (psymtab_discarder::~psymtab_discarder): Update.
8156         (ALL_OBJFILE_PSYMTABS): Rewrite.
8157         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8158         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8159         Remove fields.
8160         <partial_symtabs>: New field.
8161         (class objfile_psymtabs): Move from psymtab.h.  Update.
8162         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8163         psymbol_cache.
8164         (objfile::~objfile): Don't destroy psymbol_cache.
8165         * mdebugread.c (parse_partial_symbols): Update.
8166         * dwarf2read.c (create_addrmap_from_index)
8167         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8168         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8169         (add_partial_subprogram, dwarf2_ranges_read): Update.
8170         * dwarf-index-write.c (write_address_map)
8171         (write_one_signatured_type, recursively_write_psymbols)
8172         (class debug_names, class debug_names, write_psymtabs_to_index):
8173         Update.
8174
8175 2019-01-10  Tom Tromey  <tom@tromey.com>
8176
8177         * symtab.h (SYMBOL_SET_NAMES): Update.
8178         (symbol_set_names): Update.
8179         (MSYMBOL_SET_NAMES): Update.
8180         * symtab.c (symbol_set_names): Change argument to be an
8181         objfile_per_bfd_storage.
8182         * psymtab.c (add_psymbol_to_bcache): Update.
8183         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8184
8185 2019-01-10  Tom Tromey  <tom@tromey.com>
8186
8187         * symtab.c (create_demangled_names_hash): Change argument to be an
8188         objfile_per_bfd_storage.
8189         (symbol_set_names): Update.
8190
8191 2019-01-10  Tom Tromey  <tom@tromey.com>
8192
8193         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8194         init_psymbol_list.
8195         * psymtab.c (init_psymbol_list): Do nothing if already called.
8196         * psympriv.h (init_psymbol_list): Add comment.
8197         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8198         init_psymbol_list.
8199         * dbxread.c (dbx_symfile_read): Unconditionally call
8200         init_psymbol_list.
8201
8202 2019-01-10  Tom Tromey  <tom@tromey.com>
8203
8204         * xcoffread.c (scan_xcoff_symtab): Update.
8205         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8206         "where".
8207         * mdebugread.c (parse_partial_symbols)
8208         (handle_psymbol_enumerators): Update.
8209         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8210         * dbxread.c (read_dbx_symtab): Update.
8211         * psympriv.h (psymbol_placement): New enum.
8212         (add_psymbol_to_list): Update.
8213
8214 2019-01-10  Tom Tromey  <tom@tromey.com>
8215
8216         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8217         static_psymbols parameters.
8218         (scan_xcoff_symtab): Update.
8219         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8220         static_psymbols parameters.
8221         * psympriv.h (start_psymtab_common): Update.
8222         * mdebugread.c (parse_partial_symbols): Update.
8223         * dwarf2read.c (create_partial_symtab): Update.
8224         * dbxread.c (read_dbx_symtab): Update.
8225         (start_psymtab): Remove global_psymbols and static_psymbols
8226         parameters.
8227
8228 2019-01-10  Tom Tromey  <tom@tromey.com>
8229
8230         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8231         * psymtab.c (allocate_psymtab): Add comment.
8232         * psympriv.h (allocate_psymtab): Add comment.
8233         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8234         initializations.
8235         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8236
8237 2019-01-10  Tom Tromey  <tom@tromey.com>
8238
8239         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8240         Don't declare.
8241         * mipsread.c: Include mdebugread.h.
8242         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8243         Declare.
8244         * elfread.c: Include mdebugread.h.
8245
8246 2019-01-09  Tom Tromey  <tom@tromey.com>
8247
8248         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8249         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8250         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8251         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8252         (psym_lookup_symbol, psym_find_last_source_symtab)
8253         (psym_forget_cached_source_info, psym_print_stats)
8254         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8255         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8256         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8257         (psym_find_compunit_symtab_by_address)
8258         (maintenance_print_psymbols, maintenance_info_psymtabs)
8259         (maintenance_check_psymtabs): Use ranged for.
8260         * psymtab.h (class objfile_psymtabs): New.
8261         (require_partial_symbols): Return objfile_psymtabs.
8262         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8263
8264 2019-01-09  Tom Tromey  <tom@tromey.com>
8265
8266         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8267         (find_pc_mapped_section, list_overlays_command)
8268         (map_overlay_command, unmap_overlay_command)
8269         (simple_overlay_update): Use all_objfiles.
8270         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8271         * printcmd.c (info_symbol_command): Use all_objfiles.
8272         * objfiles.h (ALL_OBJSECTIONS): Remove.
8273         * maint.c (maintenance_translate_address): Use all_objfiles.
8274         * gcore.c (gcore_create_callback): Use all_objfiles.
8275         (objfile_find_memory_regions): Likewise.
8276
8277 2019-01-09  Tom Tromey  <tom@tromey.com>
8278
8279         * symtab.c (find_line_symtab, info_sources_command)
8280         (make_source_files_completion_list): Use objfile_compunits.
8281         * source.c (select_source_symtab): Use objfile_compunits.
8282         * objfiles.h (struct objfile): Update comment.
8283         (ALL_OBJFILES): Remove.
8284         (ALL_FILETABS): Remove.
8285         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8286         objfile_compunits.
8287
8288 2019-01-09  Tom Tromey  <tom@tromey.com>
8289
8290         * symmisc.c (print_objfile_statistics, dump_objfile)
8291         (maintenance_print_symbols): Use compunit_filetabs.
8292         * source.c (forget_cached_source_info_for_objfile): Use
8293         compunit_filetabs.
8294         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8295         (ALL_FILETABS): Use compunit_filetabs.
8296         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8297         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8298
8299 2019-01-09  Tom Tromey  <tom@tromey.com>
8300
8301         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8302         (compunit_filetabs): New.
8303         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8304         compunit_filetabs.
8305         (info_sources_command, make_source_files_completion_list): Remove
8306         declaration.
8307         * symmisc.c (print_objfile_statistics, dump_objfile)
8308         (maintenance_print_symbols): Remove declaration.
8309         (maintenance_info_symtabs): Use compunit_filetabs.
8310         (maintenance_info_line_tables): Likewise.
8311         * source.c (select_source_symtab): Change local variable name.
8312         (forget_cached_source_info_for_objfile): Remove declaration.
8313         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8314         * objfiles.c (objfile_relocate1): Remove declaration.
8315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8316         declaration.
8317         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8318         * coffread.c (coff_symtab_read): Remove declaration.
8319         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8320         compunit_filetabs.
8321
8322 2019-01-09  Tom Tromey  <tom@tromey.com>
8323
8324         * symtab.c (lookup_objfile_from_block)
8325         (find_pc_sect_compunit_symtab, search_symbols)
8326         (default_collect_symbol_completion_matches_break_on): Use
8327         objfile_compunits.
8328         * objfiles.h (ALL_COMPUNITS): Remove.
8329         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8330         * cp-support.c (add_symbol_overload_list_qualified): Use
8331         objfile_compunits.
8332         * ada-lang.c (ada_collect_symbol_completion_matches)
8333         (ada_add_global_exceptions): Use objfile_compunits.
8334
8335 2019-01-09  Tom Tromey  <tom@tromey.com>
8336
8337         * source.c (select_source_symtab)
8338         (forget_cached_source_info_for_objfile): Remove declaration.
8339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8340         declaration.
8341         * maint.c (count_symtabs_and_blocks): Remove declaration.
8342         * cp-support.c (add_symbol_overload_list_qualified): Remove
8343         declaration.
8344         * coffread.c (coff_symtab_read): Remove declaration.
8345         * symtab.c (lookup_symbol_in_objfile_symtabs)
8346         (basic_lookup_transparent_type_1): Use objfile_compunits.
8347         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8348         (info_sources_command, search_symbols)
8349         (default_collect_symbol_completion_matches_break_on)
8350         (make_source_files_completion_list): Remove declaration.
8351         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8352         (ada_collect_symbol_completion_matches)
8353         (ada_add_global_exceptions): Remove declaration.
8354         * linespec.c (iterate_over_all_matching_symtabs): Use
8355         objfile_compunits.
8356         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8357         (class objfile_compunits): New.
8358         (ALL_COMPUNITS): Use objfile_compunits.
8359         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8360         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8361         objfile_compunits.
8362         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8363
8364 2019-01-09  Tom Tromey  <tom@tromey.com>
8365
8366         * symtab.c (search_symbols)
8367         (default_collect_symbol_completion_matches_break_on): Use
8368         objfile_msymbols.
8369         * ada-lang.c (ada_lookup_simple_minsym)
8370         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8371         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8372         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8373         objfile_msymbols.
8374         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8375         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8376         * objc-lang.c (find_methods): Use objfile_msymbols.
8377         (info_selectors_command, info_classes_command): Likewise.
8378         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8379         * objfiles.h (class objfile_msymbols): New.
8380         (ALL_OBJFILE_MSYMBOLS): Remove.
8381         (ALL_MSYMBOLS): Remove.
8382
8383 2019-01-09  Tom Tromey  <tom@tromey.com>
8384
8385         * common/next-iterator.h (next_adapter): Add Iterator template
8386         parameter.
8387         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8388         (class all_objfiles_safe): New.
8389         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8390         * objfiles.c (put_objfile_before): Update comment.
8391         (add_separate_debug_objfile): Likewise.
8392         (free_all_objfiles): Use all_objfiles_safe.
8393         (objfile_purge_solibs): Likewise.
8394
8395 2019-01-09  Tom Tromey  <tom@tromey.com>
8396
8397         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8398         (expand_symtab_containing_pc, lookup_static_symbol)
8399         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8400         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8401         all_objfiles.
8402         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8403         * breakpoint.c (create_overlay_event_breakpoint)
8404         (create_longjmp_master_breakpoint)
8405         (create_std_terminate_master_breakpoint)
8406         (create_exception_master_breakpoint): Use all_objfiles.
8407         * linux-thread-db.c (try_thread_db_load_from_pdir)
8408         (has_libpthread): Use all_objfiles.
8409         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8410         * linespec.c (iterate_over_all_matching_symtabs)
8411         (search_minsyms_for_name): Use all_objfiles.
8412         * maint.c (maintenance_info_sections): Use all_objfiles.
8413         * main.c (captured_main_1): Use all_objfiles.
8414         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8415         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8416         * guile/scm-pretty-print.c
8417         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8418         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8419         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8420         (maintenance_print_msymbols): Use all_objfiles.
8421         * source.c (select_source_symtab): Use all_objfiles.
8422         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8423         * symfile.c (remove_symbol_file_command)
8424         (expand_symtabs_matching, map_symbol_filenames): Use
8425         all_objfiles.
8426         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8427         all_objfiles.
8428         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8429         * objc-lang.c (find_methods): Use all_objfiles.
8430         * objfiles.c (have_partial_symbols, have_full_symbols)
8431         (have_minimal_symbols, qsort_cmp)
8432         (default_iterate_over_objfiles_in_search_order): Use
8433         all_objfiles.
8434         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8435         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8436         (maintenance_check_psymtabs): Use all_objfiles.
8437         (ALL_PSYMTABS): Remove.
8438         * compile/compile-object-run.c (do_module_cleanup): Use
8439         all_objfiles.
8440         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8441         * cp-support.c (add_symbol_overload_list_qualified): Use
8442         all_objfiles.
8443         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8444         Use all_objfiles.
8445         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8446         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8447         all_objfiles.
8448         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8449         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8450         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8451         Uses all_objfiles.
8452         * solib.c (solib_read_symbols): Use all_objfiles
8453
8454 2019-01-09  Tom Tromey  <tom@tromey.com>
8455
8456         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8457         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8458         all_objfiles.
8459         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8460         * symmisc.c (print_symbol_bcache_statistics)
8461         (print_objfile_statistics, maintenance_print_objfiles)
8462         (maintenance_info_symtabs, maintenance_check_symtabs)
8463         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8464         all_objfiles.
8465         * source.c (forget_cached_source_info): Use all_objfiles.
8466         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8467         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8468         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8469         * objfiles.c (update_section_map): Use all_objfiles.
8470         (shared_objfile_contains_address_p): Likewise.
8471         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8472         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8473
8474 2019-01-09  Tom Tromey  <tom@tromey.com>
8475
8476         * common/next-iterator.h: New file.
8477         * objfiles.h (class all_objfiles): New.
8478         (struct objfile_iterator): New.
8479
8480 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8481
8482         * NEWS: Move the description of the changed "frame", "select-frame",
8483          and "info frame" commands to the Changed commands section.
8484
8485 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8486
8487         * gdbtypes.c (check_stub_method_group): Remove handling of old
8488         mangling schemes.
8489         * linespec.c (find_methods): Likewise.
8490         * stabsread.c (read_member_functions): Likewise.
8491         * valops.c (search_struct_method): Likewise.
8492         (value_struct_elt_for_reference): Likewise.
8493         * NEWS: Mention this change.
8494
8495 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8496
8497         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8498         print_source_lines.
8499         * source.c (print_source_lines_base): Update line number check.
8500         (print_source_lines): New function.
8501         (source_lines_range::source_lines_range): New function.
8502         * source.h (class source_lines_range): New class.
8503         (print_source_lines): New declaration.
8504
8505 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8506
8507         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8508
8509 2019-01-08  Tom Tromey  <tom@tromey.com>
8510             Simon Marchi  <simon.marchi@ericsson.com>
8511
8512         PR gdb/24060
8513         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8514         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8515         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8516         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8517         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8518         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8519
8520 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8521
8522         * source.c (select_source_symtab): Move header comment to
8523         declaration in source.h.
8524         (forget_cached_source_info_for_objfile): Likewise.
8525         (forget_cached_source_info): Likewise.
8526         (identify_source_line): Likewise.
8527         * source.h (identify_source_line): Move declaration from symtab.h
8528         and add comment from source.c
8529         (print_source_lines): Likewise.
8530         (forget_cached_source_info_for_objfile): Likewise.
8531         (forget_cached_source_info): Likewise.
8532         (select_source_symtab): Likewise.
8533         (enum print_source_lines_flag): Move definition from symtab.h.
8534         * symtab.h (identify_source_line): Move declaration to source.h.
8535         (print_source_lines): Likewise.
8536         (forget_cached_source_info_for_objfile): Likewise.
8537         (forget_cached_source_info): Likewise.
8538         (select_source_symtab): Likewise.
8539         (enum print_source_lines_flag): Move definition to source.h.
8540         * tui/tui-hooks.c: Add 'source.h' include.
8541
8542 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8543
8544         * source.c (print_source_lines_base): Handle requests to print
8545         reverse line number sequences, and guard against empty lines
8546         string.
8547
8548 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * source.c (print_source_lines_base): Fix skip of '\r' if next
8551         character is '\n'.
8552
8553 2019-01-06  Tom Tromey  <tom@tromey.com>
8554
8555         * c-exp.y (struct c_parse_state) <macro_original_text,
8556         expansion_obstack>: New member.
8557         (macro_original_text, expansion_obstack): Remove globals.
8558         (scan_macro_expansion, scanning_macro_expansion)
8559         (finished_macro_expansion): Update.
8560         (scan_macro_cleanup): Remove.
8561         (yylex, c_parse): Update.
8562
8563 2019-01-06  Tom Tromey  <tom@tromey.com>
8564
8565         * c-exp.y (struct c_parse_state) <strings>: New member.
8566         (operator_stoken): Update.
8567
8568 2019-01-06  Tom Tromey  <tom@tromey.com>
8569
8570         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8571         (union type_stack_elt) <typelist_val>: Now a pointer to
8572         std::vector.
8573         (type_stack_cleanup): Don't declare.
8574         (push_typelist): Update.
8575         * parse.c (pop_typelist): Return a std::vector.
8576         (push_typelist): Take a std::vector.
8577         (follow_types): Update.  Do not free args.
8578         (type_stack_cleanup): Remove.
8579         * c-exp.y (struct c_parse_state): New.
8580         (cpstate): New global.
8581         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8582         (nonempty_typelist): Update.
8583         (func_mod): Create a new vector.
8584         (c_parse): Create a c_parse_state.
8585         (check_parameter_typelist): Do not delete params.
8586         (function_method): Update.  Do not delete type_list.
8587
8588 2019-01-06  Tom Tromey  <tom@tromey.com>
8589
8590         PR gdb/28155:
8591         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8592         check_typedef.
8593         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8594         (print_return_value): Likewise.
8595
8596 2019-01-05  Tom Tromey  <tom@tromey.com>
8597
8598         * contrib/cleanup_check.py: Remove.
8599         * contrib/gcc-with-excheck: Remove.
8600         * contrib/exsummary.py: Remove.
8601         * contrib/excheck.py: Remove.
8602
8603 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8604
8605         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8606         NULL. Initialize tpprev to NULL instead of assigning it
8607         to NULL on the next statement.
8608         * windows-nat.c (windows_delete_thread): Remove check for
8609         main_thread_id before printing thread exit notifications.
8610         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8611         Remove thread ID check against main_thread_id.
8612         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8613         windows_delete_thread.
8614         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8615
8616 2019-01-04  Tom Tromey  <tom@tromey.com>
8617
8618         * compile/compile.c (_initialize_compile): Use upper case for
8619         metasyntactic variables.
8620         * symmisc.c (_initialize_symmisc): Use upper case for
8621         metasyntactic variables.
8622         * psymtab.c (_initialize_psymtab): Use upper case for
8623         metasyntactic variables.
8624         * demangle.c (demangle_command): Use upper case for metasyntactic
8625         variables.
8626         (_initialize_demangler): Likewise.
8627         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8628         variables.
8629
8630 2019-01-03  Tom Tromey  <tom@tromey.com>
8631
8632         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8633
8634 2019-01-03  Tom Tromey  <tom@tromey.com>
8635
8636         * python/py-symtab.c (salpy_str): Update.
8637         (struct salpy_sal_object) <symtab>: Now a PyObject.
8638         (salpy_dealloc): Update.
8639         (del_objfile_sal): Use gdbpy_ref.
8640
8641 2019-01-03  Tom Tromey  <tom@tromey.com>
8642
8643         * python/py-type.c (convert_field): Use new_reference.  Return
8644         gdbpy_ref.
8645         (make_fielditem): Return gdbpy_ref.
8646         (typy_fields): Update.
8647         (typy_getitem): Update.
8648         (field_name): Return gdbpy_ref.  Use new_reference.
8649         (typy_iterator_iternext): Update.
8650
8651 2019-01-03  Tom Tromey  <tom@tromey.com>
8652
8653         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8654
8655 2019-01-03  Tom Tromey  <tom@tromey.com>
8656
8657         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8658         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8659         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8660         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8661         (pspy_set_type_printers): Likewise.
8662         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8663         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8664         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8665         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8666         (objfpy_set_type_printers): Likewise.
8667
8668 2019-01-03  Tom Tromey  <tom@tromey.com>
8669
8670         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8671         (gdbpy_print_stack): Use gdbpy_err_fetch.
8672         * python/python-internal.h (class gdbpy_err_fetch): New class.
8673         (class gdbpy_enter) <m_error_type, m_error_value,
8674         m_error_traceback>: Remove.
8675         <m_error>: New member.
8676         (gdbpy_exception_to_string): Don't declare.
8677         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8678         * python/py-value.c (convert_value_from_python): Use
8679         gdbpy_err_fetch.
8680         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8681         gdbpy_exception_to_string.
8682         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8683         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8684         gdbpy_err_fetch.
8685
8686 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8687
8688         * linux-nat.c (delete_lwp_cleanup): Delete.
8689         (struct lwp_deleter): New struct.
8690         (lwp_info_up): New typedef.
8691         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8692         lwp_info_up.
8693
8694 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8695
8696         * linux-fork.c (class scoped_switch_fork_info): New class.
8697         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8698
8699 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * valops.c (find_overload_match): Remove use of null_cleanup, and
8702         calls to do_cleanups.
8703
8704 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8705
8706         * compile/compile-cplus-types.c
8707         (compile_cplus_instance::decl_name): Handle changes to
8708         cp_func_name.
8709         * cp-support.c (cp_func_name): Update header comment, update
8710         return type.
8711         * cp-support.h (cp_func_name): Update return type in declaration.
8712         * valops.c (find_overload_match): Move temp_func local to top
8713         level of function and change its type.  Use temp_func to hold and
8714         delete temporary string obtained from cp_func_name.
8715
8716 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8717
8718         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8719         gdb::char_vector, remove cleanup, and update uses of `msg`.
8720
8721 2019-01-03  Jim Wilson  <jimw@sifive.com>
8722
8723         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8724
8725 2019-01-02  Tom Tromey  <tom@tromey.com>
8726
8727         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8728         (tdesc_parse_xml): Remove cleanups.
8729         * target-descriptions.h (make_cleanup_free_target_description):
8730         Don't declare.
8731         (target_desc_deleter): New struct.
8732         (target_desc_up): New typedef.
8733         * target-descriptions.c (target_desc_deleter::operator()): Rename
8734         from free_target_description.
8735         (make_cleanup_free_target_description): Remove.
8736
8737 2019-01-02  Tom Tromey  <tom@tromey.com>
8738
8739         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8740         constructor, destructor.
8741         (linespec_parser): Remove typedef.
8742         (~linespec_parser): Rename from linespec_parser_delete.
8743         (linespec_lex_to_end, linespec_complete_label)
8744         (linespec_complete): Update.
8745         (decode_line_full): Remove cleanups.
8746         (decode_line_1): Update.
8747
8748 2019-01-02  Tom Tromey  <tom@tromey.com>
8749
8750         * python/python-internal.h (inferior_to_inferior_object): Change
8751         return type.
8752         * python/py-exitedevent.c (create_exited_event_object): Update.
8753         * python/py-inferior.c (inferior_to_inferior_object): Return
8754         gdbpy_ref.
8755         (python_new_inferior, python_inferior_deleted)
8756         (thread_to_thread_object, delete_thread_object)
8757         (build_inferior_list, gdbpy_selected_inferior): Update.
8758         * python/py-infthread.c (create_thread_object): Update.  Also fail
8759         if inferior_to_inferior_object fails.
8760
8761 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8762
8763         * inferior.h (class inferior) <displaced_step_state>: New field.
8764         * infrun.h (struct displaced_step_state): Move here from
8765         infrun.c.  Initialize fields, add constructor.
8766         <inf>: Remove field.
8767         <reset>: New method.
8768         * infrun.c (struct displaced_step_inferior_state): Move to
8769         infrun.h.
8770         (displaced_step_inferior_states): Remove.
8771         (get_displaced_stepping_state): Adust.
8772         (displaced_step_in_progress_any_inferior): Adjust.
8773         (displaced_step_in_progress_thread): Adjust.
8774         (displaced_step_in_progress): Adjust.
8775         (add_displaced_stepping_state): Remove.
8776         (get_displaced_step_closure_by_addr): Adjust.
8777         (remove_displaced_stepping_state): Remove.
8778         (infrun_inferior_exit): Call displaced_step_state.reset.
8779         (use_displaced_stepping): Don't check for NULL.
8780         (displaced_step_prepare_throw): Call
8781         get_displaced_stepping_state.
8782         (displaced_step_fixup): Don't check for NULL.
8783         (prepare_for_detach): Don't check for NULL.
8784
8785 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8786
8787         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8788          in case of call that did not complete.
8789
8790 2019-01-02  Andrey Utkin  <autkin@undo.io>
8791
8792         * symfile.c (find_separate_debug_file): Fix search of debug files for
8793         remote debuggee.
8794
8795 2019-01-02  Tom Tromey  <tom@tromey.com>
8796
8797         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8798         indentation.
8799         * python/py-frame.c (frapy_older): Remove cast.
8800         (frapy_newer): Likewise.
8801         * python/py-breakpoint.c (local_setattro): Remove cast.
8802         * python/py-arch.c (archpy_name): Remove local variable.
8803         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8804
8805 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8806
8807         * unittests/basic_string_view/element_access/char/empty.cc:
8808         Fix year range in copyright header.
8809
8810 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8813         Delete.
8814         <operator==>: Update with for removed field.
8815         <hash>: Likewise.
8816         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8817         <isa_features>: ...this.
8818         <abi_features>: New field.
8819         (riscv_isa_flen): Update comment.
8820         (riscv_abi_xlen): New declaration.
8821         (riscv_abi_flen): New declaration.
8822         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8823         isa_features.
8824         (riscv_abi_xlen): New function.
8825         (riscv_isa_flen): Update to get answer from isa_features.
8826         (riscv_abi_flen): New function.
8827         (riscv_has_fp_abi): Update to get answer from abi_features.
8828         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8829         xlen and flen.
8830         (riscv_call_info) <xlen, flen>: Update comment.
8831         (riscv_call_arg_struct): Remove invalid assertions
8832         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8833         is removed.
8834         (riscv_gdbarch_init): Gather isa features and abi features
8835         separately, ensure both match on the gdbarch when reusing an old
8836         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8837         a target with 64-bit float hardware.
8838
8839 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8840
8841         * source.c (search_command_helper): Stop reverse search
8842         when line 1 has been searched.
8843
8844 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8845
8846         * record-full.c (record_full_base_target::close): Rewrite
8847         record_full_core_buf_list free logic.
8848
8849 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8850
8851         * break-catch-syscall.c (print_one_catch_syscall): xfree
8852         the last text.
8853
8854 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8855
8856         * top.c (print_gdb_version): Update Copyright year in version
8857         message.
8858
8859 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8860
8861         Update copyright year range in all GDB files.
8862
8863 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8864
8865         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8866
8867 For older changes see ChangeLog-2018.
8868 \f
8869 Local Variables:
8870 mode: change-log
8871 left-margin: 8
8872 fill-column: 74
8873 version-control: never
8874 coding: utf-8
8875 End:
8876