gdb/ChangeLog

   1 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * NEWS: Require GNU make 3.82.
   4
   5 2019-07-16  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
   8         declare.
   9
  10 2019-07-30  Tom Tromey  <tromey@adacore.com>
  11
  12         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  13
  14 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  15
  16         * printcmd.c (print_address_symbolic): Print negative offsets.
  17         (build_address_symbolic): Force signed arithmetic when computing
  18         offset.
  19
  20 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  21
  22         PR/24474: Add a function to lookup static variables.
  23         * NEWS: Mention this new function.
  24         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  25         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  26         * python/python.c (python_GdbMethods): Add new function.
  27
  28 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  31         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  32         (objfpy_lookup_static_symbol): New function.
  33         (objfile_object_methods): Add new functions.
  34
  35 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  36
  37         * NEWS: Mention 'set|show print frame-info'.  Mention new
  38         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  39         backtrace argument.  Mention that python frame filtering code
  40         is now consistent with what 'backtrace' command prints.
  41
  42 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  43
  44         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  45         comments.
  46         (print_frame_info_auto, print_frame_info_source_line,
  47         print_frame_info_location, print_frame_info_source_and_location,
  48         print_frame_info_location_and_address, print_frame_info_short_location):
  49         New declarations.
  50         (struct frame_print_options): New member print_frame_info.
  51         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  52         * stack.h (get_user_print_what_frame_info): New declaration.
  53         (frame_show_address): New declaration.
  54         * stack.c (print_frame_arguments_choices): New value 'presence'.
  55         (print_frame_info_auto, print_frame_info_source_line,
  56         print_frame_info_location, print_frame_info_source_and_location,
  57         print_frame_info_location_and_address, print_frame_info_short_location,
  58         print_frame_info_choices, print_frame_info_print_what): New definitions.
  59         (print_frame_args): Only print dots for args if print frame-arguments
  60         is 'presence'.
  61         (frame_print_option_defs): New element for "frame-info".
  62         (get_user_print_what_frame_info): New function.
  63         (frame_show_address): Make non static.  Move comment to stack.h.
  64         (print_frame_info_to_print_what): New function.
  65         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  66         to decide what to print.
  67         (backtrace_command_1): Handle the new print_frame_arguments_presence
  68         value.
  69         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  70         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  71         (py_print_frame): In non-mi mode, use LOCATION as default for
  72         print_what, similarly to frame information printed directly by
  73         backtrace command. Handle frame-info user option in non MI mode.
  74
  75 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  76
  77         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  78         Add case for debugging 32-bit target on 64-bit host.  Revise
  79         comment.
  80
  81 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  82
  83         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  84         instead of find_function_entry_range_from_pc.
  85
  86 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  87
  88         * stack.c (find_frame_funname): Remove code which preferred
  89         minsym over symtab sym in "certain pathological cases".
  90
  91         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  92         parameter.  Change type of "do_demangle" to bool.
  93         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  94         Pass suitable "prefer_sym_over_minsym" flag to
  95         build_address_symbolic().  Don't output "+" for negative offsets.
  96         * printcmd.c (print_address_symbolic): Update invocation of
  97         build_address_symbolic to include a "prefer_sym_over_minsym"
  98         flag.
  99         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 100         Restrict cases in which use of minimal symbol is preferred to that
 101         of a found symbol.  Update comments.
 102
 103         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 104         for entry pc when entry pc is out of range for that FDE.
 105
 106 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 107
 108         PR gdb/24839:
 109         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 110         type.
 111
 112 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 113
 114         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 115         this function's Python signature.
 116
 117
 118 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 119
 120         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 121         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 122         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 123         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 124         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 125
 126
 127 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 128
 129         * h8300-tdep.c (h8300_register_name_common): New.
 130         h8300_register_name): Use h8300_register_name_common.
 131         (h8300s_register_name): Likewise.
 132         (h8300sx_register_name): Likewise.
 133         (h8300h_register_nam): New.
 134         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 135
 136
 137 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 138
 139         * arm-tdep.c (arm_skip_cmse_entry): New function.
 140         (arm_is_sgstubs_section): New function.
 141         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 142
 143 2019-07-22  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 146         Don't self-assign.
 147
 148 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 151         type_print.
 152
 153 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 156         so that GDB doesn't match any msymbols when searching in the
 157         TYPES_DOMAIN.
 158         (print_symbol_info): Print using typedef_print or type_print based
 159         on the type of the symbol.  Add updated FIXME comment moved from...
 160         (_initialize_symtab): ... move and update FIXME comment to above.
 161
 162 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 163
 164         * NEWS: Mention adding -q option to "info types".
 165         * symtab.c (struct info_types_options): New struct.
 166         (info_types_options_defs): New variable.
 167         (make_info_types_options_def_group): New function.
 168         (info_types_command): Use gdb::option framework to parse options.
 169         (info_types_command_completer): New function.
 170         (_initialize_symtab): Extend the help text on "info types" and
 171         register command completer.
 172
 173 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 176         (lookup_symbol_in_objfile): Change int to block_enum and add a
 177         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 178
 179 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 180
 181         * MAINTAINERS (Write After Approval): Add self.
 182
 183 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 186         instruction to the dummy code region.
 187
 188 2019-07-19  Tom Tromey  <tromey@adacore.com>
 189
 190         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 191         (ARGSUSED, PARAMS, __func__): Remove rules.
 192
 193 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 194
 195         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 196         * features/arm/arm-with-iwmmxt.c: Remove.
 197         * features/arm/arm-with-iwmmxt.xml: Remove.
 198         * features/arm/arm-with-m-fpa-layout.c: Remove.
 199         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 200         * features/arm/arm-with-m-vfp-d16.c: Remove.
 201         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 202         * features/arm/arm-with-m.c: Remove.
 203         * features/arm/arm-with-m.xml: Remove.
 204         * features/arm/arm-with-neon.c: Remove.
 205         * features/arm/arm-with-neon.xml: Remove.
 206         * features/arm/arm-with-vfpv2.c: Remove.
 207         * features/arm/arm-with-vfpv2.xml: Remove.
 208         * features/arm/arm-with-vfpv3.c: Remove.
 209         * features/arm/arm-with-vfpv3.xml: Remove.
 210
 211 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 212
 213         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 214
 215 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 216
 217         * arch/aarch32.c (aarch32_create_target_description): Create
 218         target descriptions using features.
 219         * arch/arm.c (arm_create_target_description)
 220         (arm_create_mprofile_target_description): Likewise.
 221         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 222
 223 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 224
 225         * Makefile.in: Add new files.
 226         * aarch32-tdep.c: New file.
 227         * aarch32-tdep.h: New file.
 228         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 229         Call aarch32_read_description.
 230         * arch/aarch32.c: New file.
 231         * arch/aarch32.h: New file.
 232         * arch/arm.c (arm_create_target_description)
 233         (arm_create_mprofile_target_description): New function.
 234         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 235         (arm_create_target_description)
 236         (arm_create_mprofile_target_description): New declaration.
 237         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 238         read_description functions.
 239         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 240         Likewise.
 241         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 242         * arm-tdep.c (tdesc_arm_list): New variable.
 243         (arm_register_g_packet_guesses): Call create description functions.
 244         (arm_read_description) (arm_read_mprofile_description): New
 245         function.
 246         * arm-tdep.h (arm_read_description)
 247         (arm_read_mprofile_description): Add declaration.
 248         * configure.tgt: Add new files.
 249
 250 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 251
 252         * top.c (new_ui_command): Open specified terminal just once.
 253
 254 2019-07-18  Tom Tromey  <tromey@adacore.com>
 255
 256         * symtab.c (main_name): Constify return type.
 257         * symfile.c (set_initial_language): Update.
 258         * symtab.h (main_name): Constify return type.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-winsource.c (tui_update_source_window)
 263         (tui_update_source_window_as_is)
 264         (tui_update_source_windows_with_line): Remove return.
 265         * tui/tui-disasm.c (tui_show_disassem)
 266         (tui_show_disassem_and_update_source): Remove return.
 267         * tui/tui.c (tui_reset): Remove return.
 268         * tui/tui-wingeneral.c
 269         (tui_check_and_display_highlight_if_needed): Remove return.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 274
 275 2019-07-17  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-winsource.h (struct tui_exec_info_window)
 278         (struct tui_source_window_base): Move from tui-data.h.
 279         * tui/tui-winsource.c: Move many method definitions from
 280         elsewhere.  Remove "structuring" comments.
 281         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 282         (tui_source_window_base::refresh_window): Move to
 283         tui-winsource.c.
 284         * tui/tui-win.c (tui_source_window_base::refresh_all)
 285         (tui_source_window_base::update_tab_width)
 286         (tui_source_window_base::set_new_height)
 287         (tui_source_window_base::do_make_visible_with_new_height): Move to
 288         tui-winsource.c.
 289         * tui/tui-source.h: Update.
 290         * tui/tui-source.c (tui_source_window_base::reset): Move to
 291         tui-winsource.c.
 292         * tui/tui-disasm.h: Update.
 293         * tui/tui-data.h (struct tui_exec_info_window): Move to
 294         tui-winsource.h.
 295         (struct tui_source_window_base): Likewise.
 296         * tui/tui-data.c (tui_source_window_base::clear_detail)
 297         (tui_source_window_base, ~tui_source_window_base): Move to
 298         tui-winsource.c.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-win.c (tui_resize_all)
 303         (tui_source_window_base::update_tab_width)
 304         (tui_adjust_win_heights): Update.
 305         (tui_win_info::make_invisible_and_set_new_height): Rename from
 306         make_invisible_and_set_new_height.
 307         * tui/tui-data.h (struct tui_win_info)
 308         <make_invisible_and_set_new_height>: New method.
 309
 310 2019-07-17  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui.c: Update.
 313         * tui/tui-source.h (struct tui_source_window): Move from
 314         tui-data.h.
 315         * tui/tui-layout.c: Update.
 316         * tui/tui-disasm.c: Update.
 317         * tui/tui-data.h (struct tui_source_window): Move to
 318         tui-source.h.
 319
 320 2019-07-17  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 323         tui-data.h.
 324         * tui/tui-data.h (struct tui_disasm_window): Move to
 325         tui-disasm.h.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-regs.h (struct tui_data_item_window): Move from
 330         tui-data.h.
 331         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 332         * tui/tui-data.h (struct tui_data_item_window): Move to
 333         tui-regs.h.
 334         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui.c: Update.
 339         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 340         (tui_cmd_window::max_height): Move to tui-command.c.
 341         * tui/tui-layout.c: Update.
 342         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 343         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 344         tui-command.c.
 345         * tui/tui-command.h (struct tui_cmd_window): Move from
 346         tui-data.h.
 347         * tui/tui-command.c: Remove "structuring" comments.
 348         (tui_cmd_window::clear_detail)
 349         (tui_cmd_window::do_make_visible_with_new_height)
 350         (tui_cmd_window::max_height): Move from elsewhere.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 355         Now static.
 356         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 357         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui.c: Update.
 362         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 363         tui-regs.c.
 364         * tui/tui-windata.h: Remove file.
 365         * tui/tui-windata.c: Remove file.
 366         * tui/tui-win.c (tui_data_window::set_new_height)
 367         (tui_data_window::do_make_visible_with_new_height): Move to
 368         tui-regs.c.
 369         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 370         * tui/tui-regs.c: Remove "structuring" comments.
 371         (tui_data_window::first_data_item_displayed)
 372         (tui_data_window::delete_data_content_windows)
 373         (tui_data_window::erase_data_content)
 374         (tui_data_window::display_all_data)
 375         (tui_data_window::refresh_all)
 376         (tui_data_window::do_scroll_vertical)
 377         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 378         (tui_data_window::do_make_visible_with_new_height)
 379         (tui_data_window::refresh_window): Move from elsewhere.
 380         (_initialize_tui_regs): Move to end of file.
 381         * tui/tui-layout.c: Update.
 382         * tui/tui-hooks.c: Update.
 383         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 384         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 385         tui-regs.c.
 386         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 391         seen.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-win.c (tui_source_window_base::set_new_height)
 396         (tui_source_window_base::do_make_visible_with_new_height): Use
 397         m_has_locator field directly.
 398         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 399         method.
 400         (struct tui_source_window_base) <has_locator>: Likewise.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 405         Don't declare.
 406         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 407         Remove.
 408         * tui/tui-win.c (tui_source_window_base::set_new_height)
 409         (tui_source_window_base::set_new_height)
 410         (make_invisible_and_set_new_height)
 411         (tui_source_window_base::do_make_visible_with_new_height)
 412         (tui_source_window_base::do_make_visible_with_new_height):
 413         Update.
 414         * tui/tui-layout.c (show_source_disasm_command, show_data)
 415         (show_source_or_disasm_and_command): Update.
 416         * tui/tui-layout.c (show_layout): Update.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-layout.c (make_data_window): Remove.
 421         (show_data): Unify creation and re-initialization cases.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-layout.c (make_source_window, make_disasm_window):
 426         Remove.
 427         (show_data): Unify creation and re-initialization cases.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-layout.c (make_command_window): Remove.
 432         (show_source_disasm_command, show_source_or_disasm_and_command):
 433         Unify creation and re-initialization cases.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 438         creation and re-initialization cases.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-regs.c (tui_get_register): Return void.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 447         Simplify.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 452         resetting.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 457         * tui/tui-regs.c (tui_reg_layout): New function.
 458         (tui_show_registers, tui_reg_command): Use it.
 459         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 460         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 461         parameters.
 462         (tui_layout_command): Remove.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-layout.h (tui/tui-layout): Return void.
 467         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 468
 469 2019-07-17  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-layout.c (show_source_disasm_command, show_data):
 472         Update.
 473         (reset_locator): Remove.
 474         (show_source_or_disasm_and_command): Update.
 475
 476 2019-07-17  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-source.c (tui_source_window_base::reset): Remove
 479         win_type parameter.
 480         * tui/tui-layout.c (make_command_window, make_source_window)
 481         (make_disasm_window, make_data_window)
 482         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 483         (reset_locator, show_source_or_disasm_and_command): Update.
 484         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 485         win_type parameter.
 486         (struct tui_source_window_base) <reset>: Likewise.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-layout.c (show_source_disasm_command): Use
 491         reset_locator.
 492         (reset_locator): New function.
 493         (init_and_make_win): Remove.
 494         (show_source_or_disasm_and_command): Use reset_locator.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 499         condition.
 500         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 501         Remove condition.
 502         * tui/tui-source.c (tui_source_window_base::reset): New method.
 503         * tui/tui-layout.c (make_command_window): Don't call
 504         init_and_make_win.
 505         (make_source_window, make_disasm_window): Don't call
 506         make_source_or_disasm_window.
 507         (make_data_window): Don't call init_and_make_win.  Change calling
 508         convention.
 509         (show_source_disasm_command, show_data): Simplify.
 510         (make_source_or_disasm_window): Remove.
 511         (show_source_or_disasm_and_command): Simplify.
 512         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 513         (struct tui_source_window_base) <reset>: Likewise.
 514         <execution_info>: Remove initializer.
 515         * tui/tui-data.c (tui_source_window_base): Initialize
 516         execution_info.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 521         variable.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui.c (tui_rl_other_window): Update.
 526         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 527         superclass method first.  Always iterate over regs_content.
 528         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 529         method.
 530         * tui/tui-win.c (tui_set_focus_command): Update.
 531
 532 2019-07-17  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-win.c (tui_set_focus_command): Rename from
 535         tui_set_focus.  Call tui_enable.
 536         (tui_set_focus_command): Remove.
 537
 538 2019-07-17  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 541         refresh_window.
 542         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 543         touchwin.
 544         (tui_data_window::refresh_window): Call refresh_window on data
 545         items.  Always call superclass refresh_window.
 546         (tui_win_info::refresh): Remove.
 547         (tui_source_window_base::refresh_window): Update.
 548         (tui_refresh_all): Update.
 549         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 550         refresh_window.
 551         (show_source_or_disasm_and_command): Likewise.
 552         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 553         (struct tui_source_window_base) <refresh>: Likewise.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-winsource.c (tui_clear_source_content)
 558         (tui_show_source_content): Update.
 559         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 560         whether content is empty.
 561         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 562         Remove.
 563
 564 2019-07-17  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 567         window's contents.
 568         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 569         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 570
 571 2019-07-17  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 574         (struct tui_data_item_window): Update.
 575
 576 2019-07-17  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 579         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 580         defines.
 581
 582 2019-07-17  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-winsource.h (tui_erase_source_content)
 585         (tui_clear_source_content): Remove "display_prompt" parameter.
 586         * tui/tui-winsource.c (tui_update_source_window_as_is)
 587         (tui_update_source_windows_with_addr): Update.
 588         (tui_clear_source_content): Remove "display_prompt" parameter.
 589         (tui_erase_source_content): Likewise.  Simplify.
 590         (tui_show_source_content): Update.
 591         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 592         * tui/tui-stack.c (tui_show_frame_info): Update.
 593         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 594         Remove defines.
 595
 596 2019-07-17  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 599         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 600         parameter.
 601         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 602         parameter.
 603
 604 2019-07-17  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.c (tui_clear_source_content)
 607         (tui_show_source_content, tui_show_exec_info_content)
 608         (tui_clear_exec_info_content): Update.
 609         * tui/tui-stack.c (tui_show_locator_content): Update.
 610         (tui_show_frame_info): Update.
 611         * tui/tui-source.h (tui_source_window): Don't declare.
 612         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 613         from tui_source_is_displayed.
 614         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 615         Remove field.
 616         (struct tui_source_window_base) <content_in_use>: New field.  Now
 617         bool.
 618         (struct tui_source_window) <showing_source_p>: New method.
 619         (TUI_SRC_WIN): Change cast.
 620         * tui/tui-data.c (tui_initialize_static_data): Update.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 625         location_matches_p.
 626         * tui/tui-source.c (tui_source_window::location_matches_p): New
 627         method.
 628         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 629         method.
 630         * tui/tui-data.h (struct tui_source_window_base)
 631         <location_matches_p>: New method.
 632         (struct tui_source_window, struct tui_disasm_window)
 633         <location_matches_p>: Likewise.
 634
 635 2019-07-17  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-win.c (tui_set_win_height_command): Rename from
 638         tui_set_win_height.
 639         (tui_set_win_height_command): Remove.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-source.c (tui_source_window): New constructor.  Add
 644         observer.
 645         (~tui_source_window): New destructor.
 646         (tui_source_window::style_changed): New method.
 647         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 648         (tui_attach_detach_observers): Update.
 649         * tui/tui-data.h (struct tui_source_window): Make constructor not
 650         inline.  Add destructor.
 651         (struct tui_source_window) <style_changed>: New method.
 652         <m_observable>: New member.
 653
 654 2019-07-17  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 657         * tui/tui-win.c (tui_resize_all): Fix typo.
 658
 659 2019-07-17  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 662         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 663         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 664         * tui/tui-win.c (window_name_completer): Use foreach.
 665         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 666         (update_tab_width): Likewise.
 667         * tui/tui-layout.c (show_layout): Update.
 668         * tui/tui-data.h (class tui_window_iterator): New.
 669         (struct all_tui_windows): New.
 670         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 675         parameter.  Don't reference globals.
 676         (tui_reg_command): Update.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-regs.c (tui_show_registers): Simplify.
 681
 682 2019-07-17  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-regs.c (tui_show_registers): Update.
 685         (tui_show_register_group): Add win_info parameter.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 690         Rename from tui_display_reg_element_at_line.
 691         (tui_data_window::display_registers_from_line): Update.
 692         * tui/tui-data.h (struct tui_data_window)
 693         <display_reg_element_at_line>: New method.
 694
 695 2019-07-17  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-regs.h (tui_display_registers_from)
 698         (tui_display_registers_from_line): Don't declare.
 699         * tui/tui-windata.c (tui_data_window::display_all_data)
 700         (tui_data_window::refresh_all)
 701         (tui_data_window::do_scroll_vertical): Update.
 702         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 703         from tui_display_registers_from.
 704         (tui_display_reg_element_at_line): Update.
 705         (tui_data_window::display_registers_from_line): Rename from
 706         tui_display_registers_from_line.
 707         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 708         display_registers_from_line>: New methods.
 709
 710 2019-07-17  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 713         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 714         from tui_erase_data_content.
 715         (tui_data_window::display_all_data)
 716         (tui_data_window::refresh_all)
 717         (tui_data_window::do_scroll_vertical): Update.
 718         * tui/tui-regs.c (tui_show_registers): Update.
 719         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 720         New method.
 721
 722 2019-07-17  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 725         declare.
 726         * tui/tui-windata.c
 727         (tui_data_window::delete_data_content_windows): Rename from
 728         tui_delete_data_content_windows.
 729         (tui_data_window::display_all_data)
 730         (tui_data_window::do_scroll_vertical): Update.
 731         * tui/tui-data.h (struct tui_data_window)
 732         <delete_data_content_windows>: New method.
 733
 734 2019-07-17  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 737         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 738
 739 2019-07-17  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 742         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 743         from tui_display_all_data.
 744         * tui/tui-win.c
 745         (tui_data_window::do_make_visible_with_new_height): Update.
 746         * tui/tui-regs.c (tui_show_registers): Update.
 747         * tui/tui-layout.c (tui_set_layout): Update.
 748         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 749         method.
 750
 751 2019-07-17  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 754         * tui/tui-windata.c (tui_display_data_from): Remove.
 755         (tui_data_window::refresh_all): Update.
 756
 757 2019-07-17  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 760         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 761         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 762         tui_display_registers_from_line.
 763         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 764         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 765         "force_display" parameter.
 766
 767 2019-07-17  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 770         declare.
 771         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 772         Rename from tui_first_reg_element_no_inline.
 773         (tui_display_reg_element_at_line)
 774         (tui_display_registers_from_line): Update.
 775         * tui/tui-data.h (struct tui_data_window)
 776         <first_reg_element_no_inline>: New method.
 777
 778 2019-07-17  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-windata.c (tui_display_data_from)
 781         (tui_data_window::do_scroll_vertical): Update.
 782         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 783         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 784         Rename from tui_line_from_reg_element_no.
 785         (tui_display_registers_from_line): Update.
 786         * tui/tui-data.h (struct tui_data_window)
 787         <line_from_reg_element_no>: New method.
 788
 789 2019-07-17  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 792         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 793         tui_last_regs_line_no.
 794         (tui_display_reg_element_at_line)
 795         (tui_display_registers_from_line): Update.
 796         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 797         method.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         PR tui/24722:
 802         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 803         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 804         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 805         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 806         (tui_update_breakpoint_info): Likewise.
 807         * tui/tui-hooks.c (tui_event_create_breakpoint)
 808         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 809         Update.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-winsource.c (tui_update_source_window_as_is)
 818         (tui_update_source_windows_with_addr): Update.
 819         * tui/tui-source.h (tui_set_source_content)
 820         (tui_show_symtab_source): Add "win_info" parameter.
 821         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 822         parameter.
 823         (tui_show_symtab_source): Likewise.
 824
 825 2019-07-17  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-wingeneral.c
 828         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 829
 830 2019-07-17  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 833         (struct tui_cmd_window) <can_scroll>: New method.
 834         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 835         method.
 836
 837 2019-07-17  Tom Tromey  <tromey@adacore.com>
 838
 839         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 840         do_field_signed>: Rename.  Change type of "value".
 841         * ui-out.c (ui_out::field_signed): Rename from field_int.
 842         Change type of "value".
 843         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 844         type of "value".
 845         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 846         do_field_int.  Change type of "value".
 847         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 848         do_field_int.  Change type of "value".
 849         * tracepoint.c (trace_status_mi, tfind_1)
 850         (print_one_static_tracepoint_marker): Update.
 851         * thread.c (print_thread_info_1, print_selected_thread_frame):
 852         Update.
 853         * stack.c (print_frame, print_frame_info): Update.
 854         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 855         Update.
 856         * source.c (print_source_lines_base): Update.
 857         * skip.c (info_skip_command): Update.
 858         * record-btrace.c (btrace_ui_out_decode_error)
 859         (btrace_call_history_src_line): Update.
 860         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 861         Update.
 862         * progspace.c (print_program_space): Update.
 863         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 864         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 865         do_field_int.  Change type of "value".
 866         * mi/mi-out.c (mi_ui_out::do_table_begin)
 867         (mi_ui_out::do_table_header): Update.
 868         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 869         type of "value".
 870         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 871         (mi_cmd_data_list_changed_registers, output_register)
 872         (mi_cmd_data_read_memory, mi_load_progress)
 873         (mi_cmd_trace_frame_collected): Update.
 874         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 875         Update.
 876         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 877         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 878         (mi_cmd_var_list_children, varobj_update_one): Update.
 879         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 880         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 881         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 882         * inferior.c (print_inferior): Update.
 883         * gdb_bfd.c (print_one_bfd): Update.
 884         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 885         Update.
 886         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 887         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 888         do_field_int.  Change type of "value".
 889         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 890         do_field_int.  Change type of "value".
 891         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 892         (print_one_breakpoint_location, print_it_catch_fork)
 893         (print_one_catch_fork, print_it_catch_vfork)
 894         (print_one_catch_vfork, print_it_catch_solib)
 895         (print_it_catch_exec, print_it_ranged_breakpoint)
 896         (print_mention_watchpoint, print_mention_masked_watchpoint)
 897         (bkpt_print_it, update_static_tracepoint): Update.
 898         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 899         * break-catch-syscall.c (print_it_catch_syscall): Update.
 900         * ada-tasks.c (print_ada_task_info): Update.
 901         * ada-lang.c (print_it_exception, print_mention_exception):
 902         Update.
 903
 904 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         PR breakpoints/24541
 907         * gdbarch.c: Regenerate.
 908         * gdbarch.h: Regenerate.
 909         * gdbarch.sh: Adjust return type and parameter types for
 910         'stap_adjust_register'.
 911         (i386_stap_adjust_register): Adjust signature and return new
 912         register name.
 913         * stap-probe.c (stap_parse_register_operand): Adjust use of
 914         'gdbarch_stap_adjust_register'.
 915
 916 2019-07-17  Tom Tromey  <tromey@adacore.com>
 917
 918         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 919         declare VEC.
 920         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 921         std::vector.
 922         (struct s390_process_info): Add initializers.
 923         (s390_add_process): Use new.
 924         (s390_linux_nat_target::low_forget_process): Use delete.
 925         (s390_linux_nat_target::low_new_fork)
 926         (s390_linux_nat_target::stopped_by_watchpoint)
 927         (s390_linux_nat_target::low_prepare_to_resume)
 928         (s390_linux_nat_target::insert_watchpoint)
 929         (s390_linux_nat_target::insert_hw_breakpoint)
 930         (s390_linux_nat_target::remove_watchpoint)
 931         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 932
 933 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 934
 935         * aarch64-fbsd-nat.c: Include regcache.h.
 936         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 937         argument.
 938         (aarch64_fbsd_nat_target::fetch_registers)
 939         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 940         variable.
 941         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 942
 943 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 944
 945         * fbsd-nat.c: Include gdbarch.h.
 946
 947 2019-07-15  Tom Tromey  <tromey@adacore.com>
 948
 949         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 950
 951 2019-07-15  Tom Tromey  <tromey@adacore.com>
 952
 953         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 954         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 955         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 956         * cli-out.c (cli_ui_out::do_field_int): New method.
 957         * ui-out.c (ui_out::field_unsigned): New method.
 958         * symfile.c (generic_load): Use field_unsigned.
 959         (print_transfer_performance): Likewise.
 960         * record-btrace.c (ui_out_field_uint): Remove.
 961         (btrace_call_history_insn_range, btrace_call_history): Use
 962         field_unsigned.
 963         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 964         field_unsigned.
 965         * ui-out.h (class ui_out) <field_unsigned>: New method.
 966         <do_field_unsigned>: Likewise.
 967
 968 2019-07-15  Tom Tromey  <tromey@adacore.com>
 969
 970         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 971         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 972         * target.c (flash_erase_command): Use field_string.
 973         * infrun.c (print_signal_received_reason): Use field_string.
 974         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 975         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 976         field_string.
 977         * ada-tasks.c (print_ada_task_info): Use field_string.
 978
 979 2019-07-15  Tom Tromey  <tromey@adacore.com>
 980
 981         * target.c (flash_erase_command): Use field_core_addr.
 982         * symfile.c (generic_load): Use field_core_addr.
 983         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 984         Use field_core_addr.
 985         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 986         field_core_addr.
 987
 988 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 991         value if its desired type is smaller than a CORE_ADDR and signed.
 992
 993 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 996         of changes to field names, and use new is_reference field to
 997         decide if a property is a reference or not.
 998         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 999         field.
1000         (struct dwarf2_property_baton): Update header comment, rename
1001         'referenced_type' to 'property_type' and update comments.
1002         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1003         default property type, store in property baton, update to take
1004         accound of renamed field.
1005         (read_func_scope): Update call to attr_to_dynamic_prop.
1006         (read_array_type): Likewise.
1007         (dwarf2_per_cu_addr_sized_int_type): New function.
1008         (read_subrange_index_type): Move type finding code to
1009         dwarf2_per_cu_addr_sized_int_type.
1010         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1011         (dwarf2_per_cu_addr_type): New function.
1012         (set_die_type): Update calls to attr_to_dynamic_prop.
1013
1014 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * dwarf2read.c (read_subrange_index_type): New function.
1017         (read_subrange_type): Move code into new function and call it.
1018         * gdbtypes.c (create_range_type): Add some asserts.
1019
1020 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1023         update return statements.
1024         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1025         declaration, and update comment to match.
1026         * gdbtypes.c (resolve_dynamic_array): Update call to
1027         dwarf2_evaluate_property to match new return type.
1028
1029 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * valarith.c (value_subscripted_rvalue): Change lowerbound
1032         parameter type from int to LONGEST.
1033         * value.h (value_subscripted_rvalue): Likewise in declaration.
1034
1035 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * cli/cli-utils.c (info_print_command_completer): New function.
1038         * cli/cli-utils.h: Add 'completer.h' include, and forward
1039         declaration for 'struct cmd_list_element'.
1040         (info_print_command_completer): Declare.
1041         * stack.c (_initialize_stack): Add completer for 'info locals' and
1042         'info args'.
1043         * symtab.c (_initialize_symtab): Add completer for 'info
1044         variables' and 'info functions'.
1045         * NEWS: Mention completion for additional info commands.
1046
1047 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * cli/cli-utils.c (extract_info_print_args): Delete.
1050         (extract_arg_maybe_quoted): Delete.
1051         (info_print_options_defs): New variable.
1052         (make_info_print_options_def_group): New function.
1053         (extract_info_print_options): Define new function.
1054         * cli/cli-utils.h (extract_info_print_args): Delete.
1055         (struct info_print_options): New structure.
1056         (extract_info_print_options): Declare new function.
1057         * stack.c (info_locals_command): Update to use new
1058         extract_info_print_options, also add a header comment.
1059         (info_args_command): Likewise.
1060         * symtab.c (info_variables_command): Likewise.
1061         (info_functions_command): Likewise.
1062
1063 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1066         to extract string arguments.
1067         * common/common-utils.c (extract_string_maybe_quoted): New function.
1068         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1069
1070 2019-07-11  Tom Tromey  <tromey@adacore.com>
1071
1072         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1073         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1074         * top.h (gdbinit): Don't declare.
1075         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1076         into...
1077         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1078         * top.c (gdb_init): Don't call init_cli_cmds.
1079         (gdbinit): Remove.
1080         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1081
1082 2019-07-11  Tom Tromey  <tromey@adacore.com>
1083
1084         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1085         after it has been moved.
1086
1087 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1088
1089         * valops.c (value_must_coerce_to_target): Change return type to
1090         bool.
1091         * value.h (value_must_coerce_to_target): Likewise.
1092
1093 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1094
1095         * breakpoint.c (is_hardware_watchpoint): Remove
1096         forward-declaration.
1097         (is_masked_watchpoint): Change return type to bool.
1098         (is_tracepoint): Likewise.
1099         (is_breakpoint): Likewise.
1100         (is_hardware_watchpoint): Likewise.
1101         (is_watchpoint): Likewise.
1102         (is_no_memory_software_watchpoint): Likewise.
1103         (is_catchpoint): Likewise.
1104         (breakpoint_1): Make FILTER parameter's return type bool.
1105         is_masked_watchpoint): Change return type to bool.
1106         (save_breakpoints): Make FILTER parameter's return type bool.
1107         * breakpoint.h (is_breakpoint): Change return type to bool.
1108         (is_watchpoint): Likewise.
1109         (is_catchpoint): Likewise.
1110         (is_tracepoint): Likewise.
1111
1112 2019-07-10  Tom Tromey  <tom@tromey.com>
1113
1114         * defs.h: Don't include gdbarch.h.
1115         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1116         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1117         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1118         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1119         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1120         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1121         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1122         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1123         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1124         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1125         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1126         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1127         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1128         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1129         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1130         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1131         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1132         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1133         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1134         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1135         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1136         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1137         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1138         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1139         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1140         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1141         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1142
1143 2019-07-10  Tom Tromey  <tromey@adacore.com>
1144
1145         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1146         * breakpoint.c (init_ada_exception_breakpoint): Register as
1147         bp_catchpoint.
1148         (print_one_breakpoint_location, print_one_breakpoint): Use
1149         is_ada_exception_catchpoint.
1150         * ada-lang.c (class ada_catchpoint_location): Pass
1151         bp_loc_software_breakpoint to bp_location constructor.
1152         (is_ada_exception_catchpoint): New function.
1153
1154 2019-07-10  Tom Tromey  <tromey@adacore.com>
1155
1156         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1157         VEC.
1158         (struct arm_exidx_entry): New method operator<.
1159         (struct arm_exidx_data) <section_maps>: Change type.
1160         (arm_exidx_data_free): Remove.
1161         (arm_exidx_data_key): Change type.  Move lower.
1162         (arm_exidx_new_objfile): Update.
1163         (arm_compare_exidx_entries): Remove.
1164         (arm_find_exidx_entry, _initialize_arm_tdep)
1165
1166 2019-07-10  Tom Tromey  <tromey@adacore.com>
1167
1168         * solib-spu.c (ocl_program_data_key): Change type.
1169         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1170         Update.
1171
1172 2019-07-10  Tom Tromey  <tromey@adacore.com>
1173
1174         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1175         (struct solib_aix_inferior_data) <library_list>: Change type.
1176         (solib_aix_inferior_data_handle): Change type.
1177         (get_solib_aix_inferior_data): Update.
1178         (solib_aix_free_library_list): Remove.
1179         (library_list_start_library): Update.
1180         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1181         return type.
1182         (solib_aix_get_library_list)
1183         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1184         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1185
1186 2019-07-10  Tom Tromey  <tromey@adacore.com>
1187
1188         * solib-dsbt.c (struct dsbt_info): Add initializers.
1189         (solib_dsbt_pspace_data): Change type.
1190         (dsbt_pspace_data_cleanup): Remove.
1191         (get_dsbt_info, _initialize_dsbt_solib): Update.
1192
1193 2019-07-10  Tom Tromey  <tromey@adacore.com>
1194
1195         * spu-tdep.c (spu_overlay_data): Change type.
1196         (spu_get_overlay_table, spu_overlay_new_objfile)
1197         (_initialize_spu_tdep): Update.
1198
1199 2019-07-10  Tom Tromey  <tromey@adacore.com>
1200
1201         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1202         destructor.
1203         (dbx_objfile_data_key): Change type and declare later.
1204         (DBX_SYMFILE_INFO): Rewrite.
1205         * dbxread.c (dbx_objfile_data_key): Change type.
1206         (dbx_symfile_init): Update.
1207         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1208         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1209         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1210
1211 2019-07-10  Tom Tromey  <tromey@adacore.com>
1212
1213         * jit.c (jit_program_space_key): Change type.  Move lower.
1214         (get_jit_program_space_data): Update.
1215         (jit_program_space_data_cleanup): Remove.
1216         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1217         Update.
1218         (struct jit_program_space_data): Add initializers.
1219
1220 2019-07-10  Tom Tromey  <tromey@adacore.com>
1221
1222         * solib-darwin.c (struct darwin_info): Add initializers.
1223         (solib_darwin_pspace_data): Change type.
1224         (darwin_pspace_data_cleanup): Remove.
1225         (get_darwin_info, _initialize_darwin_solib): Update.
1226
1227 2019-07-10  Tom Tromey  <tromey@adacore.com>
1228
1229         * remote-sim.c (struct sim_inferior_data): Add initializers,
1230         constructor, and destructor.
1231         (sim_inferior_data_key): Change type.  Move lower.
1232         (check_for_duplicate_sim_descriptor): Update.
1233         (get_sim_inferior_data): Use new.  Update.
1234         (~sim_inferior_data_cleanup): Rename from
1235         sim_inferior_data_cleanup.  Simplify.
1236         (gdbsim_close_inferior, simulator_command)
1237         (sim_command_completer, _initialize_remote_sim): Update.
1238         (next_pid, INITIAL_PID): Move earlier.
1239
1240 2019-07-10  Tom Tromey  <tromey@adacore.com>
1241
1242         * python/python-internal.h (create_thread_object): Return
1243         gdbpy_ref.
1244         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1245         * python/py-inferior.c (struct threadlist_entry): Add
1246         constructor.
1247         <thread_obj>: Now a gdbpy_ref.
1248         (thread_to_thread_object): Update.
1249         (add_thread_object): Use new.
1250         (delete_thread_object): Use delete.
1251         (infpy_threads): Update.
1252         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1253         GIL.
1254
1255 2019-07-10  Tom Tromey  <tromey@adacore.com>
1256
1257         * valops.c (value_cast): Specialize error message for Ada.
1258
1259 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1260
1261         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1262
1263 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1264
1265         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1266         bpstat_should_step): Return bool, adjust comments.
1267         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1268         bpstat_should_step): Likewise.
1269
1270 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1271
1272         * features/Makefile: Use feature target descriptions for Arm.
1273         * features/arm/arm-core.c: Generate new file.
1274         * features/arm/arm-fpa.c: Likewise.
1275         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1276         * features/arm/arm-m-profile.c: Likewise.
1277         * features/arm/arm-vfpv2.c: Likewise.
1278         * features/arm/arm-vfpv3.c: Likewise.
1279         * features/arm/xscale-iwmmxt.c: Likewise.
1280         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1281
1282 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1285         ptrace earlier.
1286
1287 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1288
1289         * features/aarch64-pauth.c: Regenerate.
1290
1291 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1292
1293         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1294         bool.
1295         (bpstat_what): Use false instead of 0.
1296
1297 2019-07-09  Pedro Alves  <palves@redhat.com>
1298
1299         * break-catch-throw.c (is_exception_catchpoint): New.
1300         * breakpoint.c (print_one_breakpoint_location): New parameter
1301         'raw_loc'.  Handle it.  Use
1302         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1303         looking at the breakpoint's type.
1304         (print_one_breakpoint): If handling "maint info breakpoints", also
1305         print locations of exception catchpoints.
1306         * breakpoint.h (is_exception_catchpoint): Declare.
1307
1308 2019-07-09  Pedro Alves  <palves@redhat.com>
1309
1310         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1311         "addr" field.
1312         (allocate_location_exception_catchpoint): New.
1313         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1314         (initialize_throw_catchpoint_ops): Install
1315         allocate_location_exception_catchpoint as allocate_location
1316         method.
1317         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1318         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1319         bp_loc_other.
1320         (breakpoint_address_is_meaningful): Delete.
1321         (bl_address_is_meaningful): New.
1322         (breakpoint_locations_match): Adjust comment.
1323         (bp_location_from_bp_type): New, factored out of...
1324         (bp_location::bp_location(breakpoint *)): ... this.
1325         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1326         factored out of...
1327         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1328         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1329         breakpoint_address_is_meaningful.
1330         (bp_locations_compare): Adjust comment.
1331         (update_global_location_list): Use bl_address_is_meaningful
1332         instead of breakpoint_address_is_meaningful.
1333         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1334         explicit.
1335         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1336         * python/py-breakpoint.c (bppy_get_location): No longer check
1337         whether location is null.
1338
1339 2019-07-09  Pedro Alves  <palves@redhat.com>
1340
1341         PR c++/15468
1342         * breakpoint.c (print_one_breakpoint_location): Remove
1343         single-location assert.
1344
1345 2019-07-09  Tom Tromey  <tom@tromey.com>
1346
1347         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1348         * configure: Rebuild.
1349         * configure.ac: Change common to gdbsupport.
1350         * gdbsupport: Rename from common.
1351         * acinclude.m4: Change common to gdbsupport.
1352         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1353         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1354         gdbsupport.
1355         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1356         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1357         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1358         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1359         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1360         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1361         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1362         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1363         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1364         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1365         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1366         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1367         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1368         coff-pe-read.c, command.h, compile/compile-c-support.c,
1369         compile/compile-c.h, compile/compile-cplus-symbols.c,
1370         compile/compile-cplus-types.c, compile/compile-cplus.h,
1371         compile/compile-loc2c.c, compile/compile.c, completer.c,
1372         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1373         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1374         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1375         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1376         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1377         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1378         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1379         features/aarch64-core.c, features/aarch64-fpu.c,
1380         features/aarch64-pauth.c, features/aarch64-sve.c,
1381         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1382         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1383         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1384         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1385         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1386         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1387         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1388         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1389         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1390         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1391         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1392         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1393         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1394         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1395         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1396         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1397         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1398         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1399         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1400         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1401         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1402         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1403         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1404         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1405         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1406         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1407         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1408         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1409         minsyms.c, mips-linux-tdep.c, namespace.h,
1410         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1411         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1412         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1413         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1414         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1415         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1416         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1417         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1418         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1419         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1420         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1421         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1422         procfs.c, producer.c, progspace.h, psymtab.h,
1423         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1424         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1425         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1426         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1427         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1428         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1429         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1430         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1431         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1432         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1433         target-memory.c, target.c, target.h, target/waitstatus.c,
1434         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1435         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1436         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1437         unittests/array-view-selftests.c,
1438         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1439         unittests/common-utils-selftests.c,
1440         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1441         unittests/format_pieces-selftests.c,
1442         unittests/function-view-selftests.c,
1443         unittests/lookup_name_info-selftests.c,
1444         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1445         unittests/mkdir-recursive-selftests.c,
1446         unittests/observable-selftests.c,
1447         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1448         unittests/parse-connection-spec-selftests.c,
1449         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1450         unittests/scoped_fd-selftests.c,
1451         unittests/scoped_mmap-selftests.c,
1452         unittests/scoped_restore-selftests.c,
1453         unittests/string_view-selftests.c, unittests/style-selftests.c,
1454         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1455         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1456         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1457         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1458         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1459         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1460
1461 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1464         bool value.
1465         (decode_digits_ordinary): Set explicit_line field in sal.
1466         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1467         symtab_and_line that was set on an explicit line number in
1468         assembler code.  Do always update the recorded symtab and line if
1469         we do skip the prologue.
1470
1471 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * breakpoint.c (set_breakpoint_location_function): Remove
1474         explicit_loc parameter.
1475         (momentary_breakpoint_from_master): Update call to
1476         set_breakpoint_location_function.
1477         (add_location_to_breakpoint): Likewise.
1478
1479 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1480
1481         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1482         required features based on default bfd type when no specific bfd
1483         is present.
1484
1485 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1486
1487         * NEWS: Mention that GDB printf and eval commands can now print
1488         C-style and Ada-style convenience var strings without
1489         calling the inferior.
1490         * printcmd.c (printf_c_string): Locally print GDB internal var
1491         instead of transiting via the inferior.
1492         (printf_wide_c_string): Likewise.
1493
1494 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1495
1496         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1497
1498 2019-07-04  Tom Tromey  <tom@tromey.com>
1499
1500         PR tui/24724:
1501         * tui/tui-winsource.c (tui_clear_source_content): Update.
1502         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1503         (tui_update_breakpoint_info): Update.
1504         (tui_set_exec_info_content): Update.
1505         * tui/tui-source.c (tui_set_source_content_nil): Update.
1506         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1507         has_break.
1508         * tui/tui-data.h (enum tui_bp_flag): New.
1509         (tui_bp_flags): New enum flags type.
1510         (struct tui_source_element) <break_mode>: Change type.  Rename
1511         from has_break.
1512         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1513         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1514         constants.
1515         * tui/tui-winsource.h: Fix comment.
1516
1517 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1518
1519         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1520         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1521         (store_fpregs_to_thread)
1522         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1523         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1524         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1525         (IWMMXT_REGS_SIZE): Add define.
1526         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1527         (fetch_vfp_regs, store_vfp_regs)
1528         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1529         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1530
1531 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1532
1533         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1534         defines.
1535         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1536         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1537         (ARM_INT_REGISTER_SIZE): ...to this.
1538         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1539         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1540         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1541         (arm_linux_collect_gregset, supply_nwfpe_register)
1542         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1543         defines.
1544         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1545         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1546         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1547         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1548         (arm_return_in_memory, arm_store_return_value)
1549         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1550         (arm_record_ld_st_multiple): Likewise.
1551         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1552         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1553
1554 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1555
1556         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1557         AARCH64_DISPLACED_MODIFIED_INSNS.
1558         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1559         (aarch64_displaced_step_copy_insn): Likewise.
1560         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1561         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1562         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1563         ARM_DISPLACED_MODIFIED_INSNS.
1564         * arm-tdep.c (arm_gdbarch_init): Likewise.
1565         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1566         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1567         (struct arm_displaced_step_closure): Use
1568         ARM_DISPLACED_MODIFIED_INSNS.
1569
1570 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1571
1572         * features/Makefile: Remove unused xml files.
1573         * features/aarch64.xml: Remove.
1574         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1575         * features/i386/amd64-avx-avx512.xml: Remove.
1576         * features/i386/amd64-avx-linux.xml: Remove.
1577         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1578         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1579         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1580         * features/i386/amd64-avx-mpx.xml: Remove.
1581         * features/i386/amd64-avx.xml: Remove.
1582         * features/i386/amd64-linux.xml: Remove.
1583         * features/i386/amd64-mpx-linux.xml: Remove.
1584         * features/i386/amd64-mpx.xml: Remove.
1585         * features/i386/amd64.xml: Remove.
1586         * features/i386/i386-avx-avx512-linux.xml: Remove.
1587         * features/i386/i386-avx-avx512.xml: Remove.
1588         * features/i386/i386-avx-linux.xml: Remove.
1589         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1590         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1591         * features/i386/i386-avx-mpx-linux.xml: Remove.
1592         * features/i386/i386-avx-mpx.xml: Remove.
1593         * features/i386/i386-avx.xml: Remove.
1594         * features/i386/i386-linux.xml: Remove.
1595         * features/i386/i386-mmx-linux.xml: Remove.
1596         * features/i386/i386-mmx.xml: Remove.
1597         * features/i386/i386-mpx-linux.xml: Remove.
1598         * features/i386/i386-mpx.xml: Remove.
1599         * features/i386/i386.xml: Remove.
1600         * features/i386/x32-avx-avx512-linux.xml: Remove.
1601         * features/i386/x32-avx-linux.xml: Remove.
1602         * features/i386/x32-linux.xml: Remove.
1603
1604 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1605
1606         * regformats/aarch64.dat: Remove.
1607         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1608         * regformats/i386/amd64-avx-linux.dat: Remove.
1609         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1610         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1611         * regformats/i386/amd64-linux.dat: Remove.
1612         * regformats/i386/amd64-mpx-linux.dat: Remove.
1613         * regformats/i386/amd64.dat: Remove.
1614         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1615         * regformats/i386/i386-avx-linux.dat: Remove.
1616         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1617         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1618         * regformats/i386/i386-linux.dat: Remove.
1619         * regformats/i386/i386-mmx-linux.dat: Remove.
1620         * regformats/i386/i386-mpx-linux.dat: Remove.
1621         * regformats/i386/i386.dat: Remove.
1622         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1623         * regformats/i386/x32-avx-linux.dat: Remove.
1624         * regformats/i386/x32-linux.dat: Remove.
1625
1626 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1627
1628         * aarch64-tdep.c: Remove xml self tests.
1629         * amd64-linux-tdep.c: Likewise.
1630         * amd64-tdep.c: Likewise.
1631         * i386-linux-tdep.c: Likewise.
1632         * i386-tdep.c: Likewise.
1633
1634 2019-07-03  Pedro Alves  <palves@redhat.com>
1635
1636         PR cli/24732
1637         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1638         (pipe_cmd_option_defs): New.
1639         (make_pipe_cmd_options_def_group): New.
1640         (pipe_command): Use gdb::option::process_options.
1641         (pipe_command_completer): New function.
1642         (_initialize_cli_cmds): Install completer for "pipe" command.
1643
1644 2019-07-03  Pedro Alves  <palves@redhat.com>
1645
1646         * cli/cli-option.c (union option_value) <string>: New field.
1647         (struct option_def_and_value): Add ctor, move ctor, dtor and
1648         use DISABLE_COPY_AND_ASSIGN.
1649         (option_def_and_value::clear_value): New.
1650         (parse_option, save_option_value_in_ctx, get_val_type_str)
1651         (add_setshow_cmds_for_options): Handle var_string.
1652         * cli-option.h (union option_def::var_address) <string>: New
1653         field.
1654         (struct string_option_def): New.
1655         * maint-test-options.c (struct test_options_opts): Add default
1656         ctor and use DISABLE_COPY_AND_ASSIGN.
1657         <string_opt>: New field.
1658         (test_options_opts::~test_options_opts): New.
1659         (test_options_opts::dump): Also dump "-string".
1660         (test_options_option_defs): Install "string.
1661
1662 2019-07-03  Pedro Alves  <palves@redhat.com>
1663
1664         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1665         option_value with a null enumeration.
1666         (complete_options): Save the option values in the context.
1667         (save_option_value_in_ctx): New, factored out from ...
1668         (process_options): ... here.
1669         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1670         of the function.
1671         * maint-test-options.c (test_options_opts::dump): New, factored
1672         out from ...
1673         (maintenance_test_options_command_mode): ... here.
1674         (maintenance_test_options_command_completion_result): Delete.
1675         (maintenance_test_options_command_completion_text): Update
1676         comment.
1677         (maintenance_show_test_options_completion_result): Change
1678         prototype.  Just print
1679         maintenance_test_options_command_completion_text.
1680         (save_completion_result): New.
1681         (maintenance_test_options_completer_mode): Pass options context to
1682         complete_options, and then save a dump.
1683         (_initialize_maint_test_options): Use add_cmd to install "maint
1684         show test-options-completion-result".
1685
1686 2019-07-03  Pedro Alves  <palves@redhat.com>
1687
1688         * NEWS (New commands): Mention "with" and "maint with".
1689         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1690         (with_command, with_command_completer): New.
1691         (pipe_command): Adjust to new repeat_previous
1692         interface.
1693         (_initialize_cli_cmds): Install the "with" command and its "w"
1694         alias.
1695         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1696         declarations.
1697         * cli/cli-setshow.c (parse_cli_var_uinteger)
1698         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1699         argument strings for all var_types.
1700         (get_setshow_command_value_string): New, factored out from ...
1701         (do_show_command): ... this.
1702         * cli/cli-setshow.h: Include <string>.
1703         (get_setshow_command_value_string): Declare.
1704         * command.h (repeat_previous): Now returns const char *.  Adjust
1705         comment.
1706         * maint.c: Include "cli/cli-cmds.h".
1707         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1708         (_initialize_maint_cmds): Register the "maintenance with" command.
1709         * top.c (repeat_previous): Move bits from pipe_command here:
1710         Return the saved command line, if any; error out if there's no
1711         command to relaunch.
1712
1713 2019-07-03  Pedro Alves  <palves@redhat.com>
1714
1715         * NEWS (New commands): Mention "maint set/show test-settings"
1716         instead of "maint test-settings".
1717         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1718         (maintenance_test_settings_set_list): Rename to ...
1719         (maintenance_set_test_settings_list): ... this.
1720         (maintenance_test_settings_show_list): Rename to  ...
1721         (maintenance_show_test_settings_list): ... this.
1722         (maintenance_test_settings_cmd): Delete.
1723         (maintenance_test_settings_set_cmd): ...
1724         (maintenance_set_test_settings_cmd): ... this.
1725         (maintenance_test_settings_show_cmd): ...
1726         (maintenance_show_test_settings_cmd): ... this.
1727         (maintenance_test_settings_show_value_cmd):
1728         (maintenance_show_test_settings_value_cmd): ... this.
1729         (_initialize_maint_test_settings): No longer install the "maint
1730         test-settings" prefix command.  Rename "maint test-settings set"
1731         to "maint set test-settings", and "maint test-settings show" to
1732         "maint show test-settings".  Adjust all subcommands.
1733
1734 2019-07-03  Pedro Alves  <palves@redhat.com>
1735
1736         * maint-test-settings.c: Fix file's intro comment.  Replace all
1737         references to "test-options" with references to "test-settings",
1738         in comments.
1739
1740 2019-07-03  Pedro Alves  <palves@redhat.com>
1741
1742         * maint-test-settings.c (maintenance_test_settings_xxx)
1743         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1744         New.
1745         (maintenance_test_settings_enums): Use them.
1746         (maintenance_test_settings_enum): Default to
1747         maintenance_test_settings_xxx.
1748         (_initialize_maint_test_settings): Initialize
1749         MAINTENANCE_TEST_SETTINGS_FILENAME.
1750
1751 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1752
1753         * breakpoint.h (remove_breakpoints_inf): Change return type to
1754         void, move function documentation here.
1755         * breakpoint.c (remove_breakpoints_inf): Change return type to
1756         void, move function documentation to header.
1757
1758 2019-07-02  Pedro Alves  <palves@redhat.com>
1759
1760         * NEWS (Completion improvements): Mention "info threads".
1761         * thread.c (struct info_threads_opts, info_threads_option_defs)
1762         (make_info_threads_options_def_group): New.
1763         (info_threads_command): Use gdb::option::process_options.
1764         (info_threads_command_completer): New.
1765         (_initialize_thread): Use gdb::option::build_help to build the
1766         help text for "info threads".
1767
1768 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1769
1770         * defs.h (generic_load): Move from here...
1771         * symfile.h (generic_load): ... to here.  Rename name parameter
1772         to args.
1773         * symfile.c (generic_load): Add comment.
1774
1775 2019-07-01  Tom Tromey  <tromey@adacore.com>
1776
1777         * dwarf2read.c
1778         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1779         declaration of without_params.  Fix formatting.
1780
1781 2019-07-01  Tom Tromey  <tromey@adacore.com>
1782
1783         * ada-exp.y (find_primitive_type): Update.
1784         * ada-lang.h (ada_lookup_symbol): Update.
1785         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1786         parameter.
1787         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1788
1789 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1790
1791         PR breakpoints/24541
1792         * gdbarch.c: Regenerate.
1793         * gdbarch.h: Regenerate.
1794         * gdbarch.sh: Add 'stap_adjust_register'.
1795         * i386-tdep.c: Include '<unordered_set>'.
1796         (i386_stap_adjust_register): New function.
1797         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1798         * stap-probe.c (stap_parse_register_operand): Call
1799         'gdbarch_stap_adjust_register'.
1800
1801 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1802
1803         PR python/24742
1804         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1805         * python/python.c (do_start_initialization): Use 'xmalloc'
1806         instead of 'PyMem_Malloc'.
1807
1808 2019-06-28  Tom Tromey  <tromey@adacore.com>
1809
1810         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1811         for Ada.
1812
1813 2019-06-27  Tom Tromey  <tromey@adacore.com>
1814
1815         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1816         objfile_key.
1817         (arm_find_mapping_symbol, arm_record_special_symbol)
1818         (_initialize_arm_tdep): Update.
1819         (arm_objfile_data_free): Remove.
1820
1821 2019-06-27  Tom Tromey  <tromey@adacore.com>
1822
1823         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1824         to cp_print_static_field.
1825
1826 2019-06-26  Tom Tromey  <tromey@adacore.com>
1827
1828         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1829         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1830         declare.
1831
1832 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1833
1834         * features/aarch64-core.c (create_feature_aarch64_core):
1835         Regenerate.
1836         * features/aarch64-core.xml: Add cpsr flags.
1837
1838 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1839
1840         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1841         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1842
1843 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1844
1845         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1846         field.
1847         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1848         use.
1849         (arm_record_special_symbol): Don't insert new symbol in sorted
1850         position, push it at the end.
1851
1852 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1853
1854         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1855         (arm_mapping_symbol_s): Remove.
1856         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1857         (arm_mapping_symbol_vec): New typedef.
1858         (struct arm_per_objfile): Add constructor.
1859         <section_maps>: Change type to
1860         std::unique_ptr<arm_mapping_symbol_vec[]>.
1861         (arm_compare_mapping_symbols): Remove.
1862         (arm_find_mapping_symbol): Adjust to section_maps type change.
1863         (arm_objfile_data_free): Call delete on arm_per_objfile.
1864         (arm_record_special_symbol): Adjust to section_maps type change.
1865         Allocate arm_per_objfile with new.
1866
1867 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1868
1869         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1870         with the command prefix.
1871
1872 2019-06-25  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1875         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1880         type.
1881         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1882         protected.
1883
1884 2019-06-25  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.c
1887         (tui_source_window_base::set_is_exec_point_at): Add check against
1888         LOA_ADDRESS.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-source.c (tui_set_source_content): Don't check before
1893         xfree.
1894         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.h (tui_update_source_window_as_is)
1899         (tui_alloc_source_buffer, tui_line_is_displayed)
1900         (tui_addr_is_displayed): Change type of win_info.
1901         * tui/tui-winsource.c (tui_update_source_window_as_is)
1902         (tui_clear_source_content, tui_show_source_line)
1903         (tui_show_source_content, tui_source_window_base::refill)
1904         (tui_source_window_base::set_is_exec_point_at)
1905         (tui_source_window_base::set_is_exec_point_at)
1906         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1907         (tui_alloc_source_buffer, tui_line_is_displayed)
1908         (tui_addr_is_displayed): Change type of win_info.  Update.
1909         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1910         (tui_source_window_base::do_make_visible_with_new_height):
1911         Update.
1912         * tui/tui-source.c (tui_set_source_content)
1913         (tui_set_source_content_nil)
1914         (tui_source_window::do_scroll_vertical): Update.
1915         * tui/tui-layout.c (show_layout): Update.
1916         * tui/tui-disasm.c (tui_set_disassem_content)
1917         (tui_disasm_window::do_scroll_vertical): Update.
1918         * tui/tui-data.h (tui_win_content): Remove.
1919         (struct tui_gen_win_info) <content, content_size>: Remove.
1920         (struct tui_source_element): Add initializers and destructor.
1921         (union tui_which_element, struct tui_win_element): Remove.
1922         (struct tui_source_window_base) <content>: New field.
1923         (struct tui_data_window): Remove destructor.
1924         (tui_alloc_content, tui_free_win_content)
1925         (tui_free_all_source_wins_content): Don't declare.
1926         * tui/tui-data.c (tui_initialize_static_data): Update.
1927         (init_content_element, tui_alloc_content): Remove.
1928         (~tui_gen_win_info): Update.
1929         (~tui_data_window, tui_free_all_source_wins_content)
1930         (tui_free_win_content, free_content, free_content_elements):
1931         Remove.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-winsource.h (tui_clear_source_content)
1936         (tui_erase_source_content, tui_show_source_content): Change type
1937         of win_info.
1938         * tui/tui-winsource.c (tui_clear_source_content)
1939         (tui_erase_source_content, tui_show_source_content): Change type
1940         of win_info.
1941         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1942         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1943         win_info.
1944         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1945         win_info.
1946         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-winsource.c (tui_clear_source_content)
1951         (tui_source_window_base::set_is_exec_point_at): Update.
1952         * tui/tui-source.c (tui_set_source_content_nil): Update.
1953         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1954         a bool.
1955         * tui/tui-data.c (init_content_element): Update.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1960         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1961         * tui/tui-layout.c (init_and_make_win): Update.
1962         * tui/tui.h (enum tui_win_type): Update.
1963         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1964         tui_win_is_auxillary.
1965         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1966         tui_win_is_auxillary.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1971         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1972         (tui_delete_data_content_windows, tui_display_all_data)
1973         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1974         Update.
1975         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1976         * tui/tui-regs.c (tui_last_regs_line_no)
1977         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1978         (tui_show_registers): Update.
1979         (tui_show_register_group): Return void.  Update.
1980         (tui_display_registers_from, tui_display_reg_element_at_line)
1981         (tui_display_registers_from_line, tui_check_register_values):
1982         Update.
1983         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1984         member.
1985         (struct tui_data_window) <regs_content>: Now a std::vector.
1986         <regs_content_count>: Remove.
1987         (tui_add_content_elements, tui_free_data_content): Don't declare.
1988         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1989         (init_content_element): Remove DATA_WIN case.  Add assert.
1990         (tui_add_content_elements): Remove.
1991         (tui_data_window): Update.
1992         (tui_free_data_content): Remove.
1993         (free_content_elements): Remove DATA_WIN case.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-data.c (tui_data_item_window): Update.
1998         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1999         * tui/tui-windata.c (tui_display_all_data)
2000         (tui_display_data_from_line): Update.
2001         (tui_check_data_values): Remove.
2002         * tui/tui-regs.c (tui_show_register_group)
2003         (tui_display_reg_element_at_line): Update.
2004         * tui/tui-hooks.c (tui_register_changed)
2005         (tui_refresh_frame_and_register_information): Call
2006         tui_check_register_values.
2007         * tui/tui-data.h (struct tui_data_window) <data_content,
2008         data_content_count, data_type>: Remove.
2009         (enum tui_data_type): Remove.
2010
2011         * tui/tui-data.c (tui_data_window::clear_detail)
2012         (~tui_data_window): Update.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2017         declare.
2018         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2019         Rename from tui_first_data_item_displayed.  Update.
2020         (tui_data_window::refresh_all)
2021         (tui_data_window::do_scroll_vertical): Update.
2022         * tui/tui-data.h (struct tui_data_window)
2023         <first_data_item_displayed>: Declare new method.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2028         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2029         contents...
2030         (tui_initialize_static_data): ...here.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2035         (tui_display_registers_from, tui_check_register_values): Update.
2036         (tui_display_register): Remove win_info parameter; update.
2037         (tui_get_register): Change type of parameters.
2038         * tui/tui-data.h (struct tui_data_element): Remove.
2039         (union tui_which_element) <data>: Remove.
2040         <data_window>: Change type.
2041         (struct tui_data_item_window): New.
2042         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2043         case.  Add assert.
2044         (~tui_data_item_window): New destructor.
2045         (free_content_elements): Remove DATA_ITEM_WIN case.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2050         Remove.
2051
2052 2019-06-25  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-data.h (struct tui_command_element): Remove.
2055         (union tui_which_element) <command>: Remove.
2056         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2057         assert.
2058         (free_content_elements): Remove CMD_WIN case.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-layout.c (tui_set_layout): Update.
2063         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2064         * tui/tui-data.c (layout_def): Update.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2069         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2070         (tui_source_window_base::set_new_height): Update.
2071         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2072         Update.
2073         (tui_set_locator_fullname, tui_set_locator_info)
2074         (tui_show_frame_info): Update.
2075         * tui/tui-source.c (tui_set_source_content)
2076         (tui_source_is_displayed): Update.
2077         * tui/tui-layout.c (show_source_disasm_command, show_data)
2078         (show_source_or_disasm_and_command): Update.
2079         * tui/tui-disasm.c (tui_set_disassem_content)
2080         (tui_get_begin_asm_address): Update.
2081         * tui/tui-data.h (struct tui_locator_element): Remove.
2082         (union tui_which_element) <locator>: Remove.
2083         (struct tui_locator_window): New.
2084         (tui_locator_win_info_ptr): Change return type.
2085         * tui/tui-data.c (_locator): Change type.
2086         (tui_locator_win_info_ptr): Change return type.
2087         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2088         (tui_alloc_content): Add assert.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-winsource.c
2093         (tui_exec_info_window::maybe_allocate_content): New method.
2094         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2095         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2096         (make_source_or_disasm_window): Add cast.
2097         * tui/tui-data.h (union tui_which_element) <simple_string>:
2098         Remove.
2099         (struct tui_source_info): New.
2100         (struct tui_source_window_base) <execution_info>: Change type.
2101         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2102         case, and add assert.
2103         (tui_alloc_content): Add assert.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2108         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2109         * tui/tui-data.c (tui_alloc_win_info): Remove.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2114         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2115         can_highlight.
2116
2117 2019-06-25  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2120         make_visible_with_new_height method.
2121         (tui_win_info::make_visible_with_new_height): New method.
2122         (tui_source_window_base::do_make_visible_with_new_height)
2123         (tui_data_window::do_make_visible_with_new_height)
2124         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2125         (make_visible_with_new_height): Remove.
2126         (tui_resize_all, tui_adjust_win_heights): Use
2127         make_visible_with_new_height method.
2128         * tui/tui-data.h (struct tui_win_info)
2129         <do_make_visible_with_new_height, make_visible_with_new_height>:
2130         New methods.
2131         (struct tui_source_window_base, struct tui_data_window)
2132         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2133         methods.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2138         method.
2139         (update_tab_width): Call update_tab_width method.
2140         * tui/tui-data.h (struct tui_win_info)
2141         (struct tui_source_window_base) <update_tab_width>: New methods.
2142
2143 2019-06-25  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2146         parameter.
2147         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2148         parameter.
2149         (tui_gen_win_info::make_visible): Update.
2150         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2151         parameter.
2152         * tui/tui-data.h (enum tui_box): New enum.
2153         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2154
2155 2019-06-25  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2158         init_and_make_win for EXEC_INFO_WIN.
2159         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2160         longer inline.
2161         (struct tui_win_info) <~tui_win_info>: Inline.
2162         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2163         Don't declare.
2164         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2165         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2166         Remove.
2167         (tui_initialize_static_data): Update.
2168         (~tui_gen_win_info): Handle more cleanup here.
2169         (~tui_source_window_base): Delete "execution_info".
2170         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-layout.c (make_command_window): Don't set
2175         can_highlight.
2176         (show_source_disasm_command): Call the reset method.
2177         (show_data): Don't set can_highlight.  Call the reset method.
2178         (tui_gen_win_info::reset): Rename from init_gen_win_info
2179         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2180         (show_source_or_disasm_and_command): Call the reset method.
2181         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2182         (struct tui_cmd_window): Set can_highlight.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2187         from make_visible.
2188         (tui_make_visible, tui_make_invisible): Rewrite.
2189         (tui_win_info::make_visible): Remove.
2190         (tui_source_window_base::make_visible): Update.
2191         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2192         method.  Moved from...
2193         (struct tui_win_info) <make_visible>: ...here.
2194
2195 2019-06-25  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-winsource.c
2198         (tui_source_window_base::do_scroll_horizontal): Remove direction
2199         parameter.
2200         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2201         direction parameter.
2202         * tui/tui-win.c (tui_win_info::forward_scroll)
2203         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2204         (tui_win_info::right_scroll): Update.
2205         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2206         direction parameter.
2207         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2208         direction parameter.
2209         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2210         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2211         Remove direction parameter.
2212         (struct tui_source_window_base, struct tui_source_window)
2213         (struct tui_disasm_window, struct tui_data_window)
2214         (struct tui_cmd_window): Update.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-winsource.h (tui_set_exec_info_content)
2219         (tui_show_exec_info_content, tui_erase_exec_info_content)
2220         (tui_clear_exec_info_content, tui_update_exec_info): Change
2221         argument to tui_source_window_base.
2222         * tui/tui-winsource.c (tui_set_exec_info_content)
2223         (tui_show_exec_info_content, tui_erase_exec_info_content)
2224         (tui_clear_exec_info_content, tui_update_exec_info): Change
2225         argument to tui_source_window_base.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2230         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2235         check.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2240         type to void.
2241         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2242         type to void.
2243         * tui/tui-source.c (tui_set_source_content): Update.
2244         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-win.c (window_name_completer, tui_set_focus)
2249         (tui_all_windows_info): Use name method.
2250         * tui/tui-data.h (struct tui_gen_win_info)
2251         (struct tui_source_window, struct tui_disasm_window)
2252         (struct tui_data_window, struct tui_cmd_window) <name>: New
2253         method.
2254         (tui_win_name): Don't declare.
2255         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2256         (tui_win_name): Remove.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-winsource.h (tui_update_source_window)
2261         (tui_update_source_window_as_is): Change parameter type.
2262         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2263         to be a tui_source_window_base.
2264         (tui_update_source_window_as_is): Likewise.
2265         * tui/tui-win.c (make_visible_with_new_height): Update.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-winsource.c (tui_erase_source_content)
2270         (tui_show_source_content, tui_show_exec_info_content)
2271         (tui_erase_exec_info_content): Use refresh_window method.
2272         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2273         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2274         from tui_refresh_win.
2275         (tui_data_window::refresh_window): New method.
2276         (tui_win_info::refresh, tui_source_window_base::refresh)
2277         (tui_refresh_all): Use refresh_window method.
2278         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2279         method.
2280         * tui/tui-regs.c (tui_display_register): Call refresh_window
2281         method.
2282         * tui/tui-layout.c (show_source_disasm_command)
2283         (show_source_or_disasm_and_command): Call refresh_window method.
2284         * tui/tui-data.h (struct tui_gen_win_info)
2285         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2286         New method.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui.c (tui_rl_other_window, tui_enable)
2291         (tui_is_window_visible, tui_get_command_dimension): Update.
2292         * tui/tui-winsource.c (tui_update_source_window_as_is)
2293         (tui_clear_source_content, tui_erase_source_content)
2294         (tui_show_source_line, tui_source_window_base::refill)
2295         (tui_source_window_base::do_scroll_horizontal)
2296         (tui_source_window_base::set_is_exec_point_at)
2297         (tui_update_breakpoint_info, tui_set_exec_info_content)
2298         (tui_alloc_source_buffer, tui_line_is_displayed)
2299         (tui_addr_is_displayed): Update.
2300         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2301         (tui_check_and_display_highlight_if_needed)
2302         (tui_win_info::make_visible, tui_win_info::refresh)
2303         (tui_refresh_all): Update.
2304         * tui/tui-windata.c (tui_first_data_item_displayed)
2305         (tui_delete_data_content_windows, tui_erase_data_content)
2306         (tui_display_all_data, tui_data_window::refresh_all)
2307         (tui_check_data_values): Update.
2308         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2309         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2310         (tui_win_info::backward_scroll, tui_refresh_all_win)
2311         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2312         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2313         (tui_source_window_base::set_new_height)
2314         (tui_data_window::set_new_height)
2315         (make_invisible_and_set_new_height)
2316         (make_visible_with_new_height, new_height_ok)
2317         (parse_scrolling_args): Update.
2318         * tui/tui-stack.c (tui_show_frame_info): Update.
2319         * tui/tui-source.c (tui_set_source_content)
2320         (tui_set_source_content_nil, tui_source_is_displayed)
2321         (tui_source_window::do_scroll_vertical): Update.
2322         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2323         (tui_display_registers_from, tui_display_reg_element_at_line)
2324         (tui_check_register_values, tui_reg_command): Update.
2325         * tui/tui-layout.c (tui_default_win_height)
2326         (show_source_disasm_command, show_data, init_and_make_win)
2327         (show_source_or_disasm_and_command): Update.
2328         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2329         (tui_redisplay_readline, tui_mld_flush)
2330         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2331         (tui_getc): Update.
2332         * tui/tui-disasm.c (tui_set_disassem_content)
2333         (tui_disasm_window::do_scroll_vertical): Update.
2334         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2335         Now virtual.
2336         (struct tui_win_info): Derive from tui_gen_win_info.
2337         <~tui_win_info>: Mark as override.
2338         <generic>: Remove member.
2339         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2340         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2341         (~tui_data_window, ~tui_win_info)
2342         (tui_free_all_source_wins_content): Update.
2343         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2344
2345 2019-06-25  Tom Tromey  <tom@tromey.com>
2346
2347         * tui/tui-layout.c (init_and_make_win): Use new.
2348         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2349         destructor, initializers.
2350         (tui_alloc_generic_win_info): Don't declare.
2351         * tui/tui-data.c (_locator): Add argument to constructor.
2352         (source_win, disasm_win): New globals.
2353         (exec_info): Remove.
2354         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2355         Update.
2356         (tui_alloc_generic_win_info): Remove.
2357         (init_content_element): Use new.
2358         (tui_win_info::tui_win_info): Update.
2359         (free_content_elements) <case DATA_WIN>: Use delete.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2364         * tui/tui-windata.c (tui_first_data_item_displayed)
2365         (tui_delete_data_content_windows): Update.
2366         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2367         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2368         (tui_display_registers_from, tui_check_register_values): Update.
2369         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2370         pointer.
2371         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2372         window.
2373         (tui_free_data_content): Update.
2374         (free_content_elements) <case DATA_WIN>: Free the window.
2375
2376 2019-06-25  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2379         Update.
2380         * tui/tui-layout.c (make_command_window)
2381         (show_source_disasm_command, show_data, init_and_make_win)
2382         (show_source_or_disasm_and_command): Update.
2383         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2384         method.
2385         <can_highight, is_highlighted>: Now bool.
2386         (tui_set_win_highlight): Don't declare.
2387         * tui/tui-data.c (tui_set_win_highlight): Remove.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-wingeneral.c (make_visible): Remove check of window
2392         type.
2393
2394 2019-06-25  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-win.c (tui_win_info::max_height)
2397         (tui_cmd_window::max_height): New methods.
2398         (new_height_ok): Call max_height.
2399         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2400         <max_height>: New method.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-win.c (tui_source_window_base::set_new_height)
2405         (tui_data_window::set_new_height): New methods.
2406         (make_invisible_and_set_new_height): Call set_new_height method.
2407         * tui/tui-data.h (struct tui_win_info)
2408         (struct tui_source_window_base, struct tui_data_window)
2409         <set_new_height>: New method.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2414         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2415         tui_refresh_data_win.
2416         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2417         method.
2418         (tui_refresh_all_win): Call the refresh_all method.
2419         (tui_set_focus): Likewise.
2420         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2421         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2422         Likewise.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-winsource.h (tui_refill_source_window)
2427         (tui_set_is_exec_point_at): Don't declare.
2428         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2429         (tui_source_window_base::refill): Rename from
2430         tui_refill_source_window.
2431         (tui_source_window_base::do_scroll_horizontal): Update.
2432         (tui_source_window_base::set_is_exec_point_at): Rename from
2433         tui_set_is_exec_point_at.
2434         (tui_update_all_breakpoint_info): Update.
2435         * tui/tui-stack.c (tui_show_frame_info): Update.
2436         * tui/tui-layout.c (show_data): Add cast.
2437         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2438         * tui/tui-data.h (struct tui_source_window_base) <refill,
2439         set_is_exec_point_at>: New methods.
2440         (tui_source_windows, tui_add_to_source_windows): Update types.
2441         (tui_add_to_source_windows): Remove redundant declaration.
2442         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2443         (tui_source_windows): Change return type.
2444         (tui_clear_source_windows_detail): Update.
2445         (tui_add_to_source_windows): Change type of parameter.
2446         (tui_free_all_source_wins_content): Update.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-wingeneral.c (tui_win_info::refresh)
2451         (tui_source_window_base::refresh): New methods.
2452         (tui_refresh_all): Call the refresh method.
2453         * tui/tui-data.h (struct tui_win_info)
2454         (struct tui_source_window_base) <refresh>: New method.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui.h (tui_is_window_visible): Return bool.
2459         * tui/tui.c (tui_is_window_visible): Return bool.
2460         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2461         (tui_make_visible, tui_make_invisible)
2462         (tui_win_info::make_visible)
2463         (tui_source_window_base::make_visible, make_all_visible)
2464         (tui_make_all_visible, tui_make_all_invisible): Update.
2465         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2466         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2467         bool.
2468         (struct tui_win_info, struct tui_source_window_base)
2469         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2470         * tui/tui-data.c (tui_init_generic_part): Update.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2475         (tui_source_window_base::make_visible): New methods.
2476         (make_all_visible): Make method call.
2477         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2478         (struct tui_source_window_base, struct tui_cmd_window): Override
2479         make_visible.
2480         (tui_win_is_source_type): Don't declare.
2481         * tui/tui-data.c (tui_win_is_source_type): Remove.
2482
2483 2019-06-25  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2486         NULL check.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2491         Inline constructor.  Add initializers for members.
2492         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2493         constructors; now inline in class.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-regs.c (tui_show_registers): Update.
2498         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2499         bool.
2500         * tui/tui-data.c (tui_data_window::clear_detail)
2501         (tui_data_window): Update.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-windata.c (tui_display_all_data)
2506         (tui_display_data_from_line, tui_display_data_from)
2507         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2508         Update.
2509         * tui/tui-regs.c (tui_last_regs_line_no)
2510         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2511         (tui_show_registers, tui_show_register_group)
2512         (tui_display_registers_from, tui_display_reg_element_at_line)
2513         (tui_display_registers_from_line, tui_check_register_values)
2514         (tui_reg_next, tui_reg_prev): Update.
2515         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2516         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2517         tui_data_window.
2518         (struct tui_win_info) <detail>: Remove.  Add new fields from
2519         tui_data_info.
2520         (TUI_DATA_WIN): Add cast.
2521         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2522         (~tui_data_window): Simplify.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-layout.c (show_source_disasm_command)
2527         (show_source_or_disasm_and_command): Update.
2528         * tui/tui-io.c (update_cmdwin_start_line)
2529         (tui_redisplay_readline): Update.
2530         * tui/tui-data.h (struct tui_command_info): Remove.
2531         (struct tui_win_info) <detail>: Remove command_info member.
2532         (struct tui_data_window) <start_line>: New member, from
2533         tui_command_info.
2534         (TUI_CMD_WIN): Add casts.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-winsource.c (tui_update_source_window)
2539         (tui_refill_source_window)
2540         (tui_source_window_base::do_scroll_horizontal)
2541         (tui_update_breakpoint_info, tui_set_exec_info_content)
2542         (tui_show_exec_info_content, tui_erase_exec_info_content)
2543         (tui_clear_exec_info_content): Update.
2544         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2545         Update.
2546         * tui/tui-win.c (make_invisible_and_set_new_height)
2547         (make_visible_with_new_height): Update.
2548         * tui/tui-source.c (tui_set_source_content)
2549         (tui_show_symtab_source): Update.
2550         * tui/tui-layout.c (extract_display_start_addr)
2551         (show_source_disasm_command, show_data)
2552         (make_source_or_disasm_window)
2553         (show_source_or_disasm_and_command): Update.
2554         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2555         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2556         "gdbarch".
2557         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2558         to tui_source_window_base.
2559         (struct tui_win_info) <detail>: Remove source_info member.
2560         (struct tui_source_window_base) <has_locator>: Inline.
2561         Move contents from tui_source_info; rename has_locator member to
2562         m_has_locator.
2563         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2564         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2565         header file.
2566         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2567         Simplify.
2568         (tui_free_all_source_wins_content): Cast to
2569         tui_source_window_base.
2570
2571 2019-06-25  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui-win.c (make_invisible_and_set_new_height)
2574         (make_visible_with_new_height): Call has_locator method.
2575         * tui/tui-layout.c (show_source_disasm_command, show_data)
2576         (show_source_or_disasm_and_command): Update for bool change.
2577         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2578         (tui_win_info) <has_locator>: New method.
2579         (struct tui_source_window_base) <has_locator>: New method.
2580         (tui_win_has_locator): Don't declare.
2581         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2582         from tui_win_has_locator.
2583         (tui_source_window_base): Use false, not FALSE.
2584
2585 2019-06-25  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2588         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2589         clear_detail method directly.
2590         (tui_clear_win_detail): Remove.
2591
2592 2019-06-25  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2595         "this", not TUI_DISASM_WIN.
2596
2597 2019-06-25  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2600         declare.
2601         * tui/tui-winsource.c
2602         (tui_source_window_base::do_scroll_horizontal): Rename from
2603         tui_horizontal_source_scroll.
2604         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2605         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2606         from tui_vertical_data_scroll.
2607         * tui/tui-win.h (tui_scroll): Don't declare.
2608         * tui/tui-win.c (tui_win_info::forward_scroll)
2609         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2610         (tui_win_info::right_scroll): Rename and update.
2611         (tui_scroll_forward_command, tui_scroll_backward_command)
2612         (tui_scroll_left_command, tui_scroll_right_command): Update.
2613         (tui_scroll): Remove.
2614         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2615         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2616         from tui_vertical_source_scroll.
2617         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2618         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2619         from tui_vertical_disassem_scroll.
2620         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2621         do_scroll_horizontal>: New methods.
2622         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2623         Likewise.
2624         (struct tui_source_window_base): Add do_scroll_horizontal.
2625         (struct tui_source_window, struct tui_disasm_window): Add
2626         do_scroll_vertical.
2627         (struct tui_data_window, struct tui_cmd_window): Add
2628         do_scroll_horizontal and do_scroll_vertical.
2629         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2630
2631 2019-06-25  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-data.h (struct tui_source_window_base): New struct.
2634         (struct tui_source_window): Derive from tui_source_window_base.
2635         (struct tui_disasm_window): New struct.
2636         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2637         from tui_source_window::clear_detail.
2638         (tui_source_window_base): Rename from tui_source_window.
2639         (~tui_source_window_base): Rename from ~tui_source_window.
2640         (tui_alloc_win_info): Create a tui_disasm_window.
2641
2642 2019-06-25  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-data.h (struct tui_source_window)
2645         (struct tui_data_window): Declare destructors.
2646         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2647         destructors.
2648         (tui_win_info): Simplify.
2649
2650 2019-06-25  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-winsource.c (tui_display_main)
2653         (tui_update_source_windows_with_addr)
2654         (tui_update_all_breakpoint_info): Update.
2655         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2656         (new_height_ok, parse_scrolling_args): Update.
2657         * tui/tui-stack.c (tui_show_frame_info): Update.
2658         * tui/tui-data.h (struct tui_list): Remove.
2659         (tui_source_windows): Return a reference to a std::vector.
2660         * tui/tui-data.c (source_windows): Now a std::vector.
2661         (tui_source_windows): Change return type.
2662         (tui_clear_source_windows): Rewrite.
2663         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2664         (tui_free_all_source_wins_content): Rewrite.
2665
2666 2019-06-25  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2669         (struct tui_data_window, struct tui_cmd_window): Declare
2670         clear_detail method.
2671         * tui/tui-data.c (tui_source_window::clear_detail)
2672         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2673         methods.
2674         (tui_clear_win_detail): Simplify.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-layout.c (make_source_window, make_disasm_window)
2679         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2680         Return the new window.
2681         (show_source_disasm_command, show_data)
2682         (show_source_or_disasm_and_command): Update.
2683
2684 2019-06-25  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2687         parameter.  Return the new window.
2688         (show_source_disasm_command): Update and remove NULL check.
2689         (show_source_or_disasm_and_command): Update.
2690
2691 2019-06-25  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2694
2695 2019-06-25  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-data.h (struct tui_win_info): Make constructor
2698         protected.  Make destructor virtual.  Add initializers.
2699         (tui_source_window, tui_data_window, tui_cmd_window): New
2700         classes.
2701         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2702         constructor.  Add "type" parameter.
2703         (tui_source_window, tui_data_window, tui_cmd_window): New
2704         constructors.
2705         (tui_alloc_win_info): Instantiate the appropriate subclass.
2706
2707 2019-06-25  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-win.c (tui_resize_all): Use delete.
2710         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2711         destructor.
2712         (tui_free_window): Don't declare.
2713         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2714         Update.
2715
2716 2019-06-25  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-data.h (struct tui_win_info): Add constructor.
2719         * tui/tui-data.c (tui_alloc_win_info): Use new.
2720         (tui_free_window): Use delete.
2721
2722 2019-06-22  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2725         declare.
2726         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2727
2728 2019-06-22  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2731         declare.
2732         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2733
2734 2019-06-22  Tom de Vries  <tdevries@suse.de>
2735
2736         * dwarf2read.c (create_addrmap_from_aranges)
2737         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2738         instead of '%zu'.
2739
2740 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2741
2742         * dwarf2read.h (dwarf2_section_info_def): Remove.
2743         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2744         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2745         std::vector<dwarf2_section_info>.
2746         (struct dwo_file) <~dwo_file>: Remove.
2747         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2748         types field.
2749         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2750         (dwarf2_read_debug_names): Likewise.
2751         (create_debug_types_hash_table): Change parameter type to
2752         array_view, adjust code accordingly.
2753         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2754         (partial_die_info::fixup): Likewise.
2755         (determine_prefix): Likewise.
2756         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2757
2758 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2759
2760         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2761         gdb_bfd_ref_ptr.
2762         <~dwo_file>: Remove call to gdb_bfd_unref.
2763         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2764         gdb_bfd_ref_ptr::get.
2765
2766 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2767
2768         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2769         type to htab_up.
2770         * dwarf2read.c (struct dwo_file): Initialize fields.
2771         <~dwo_file>: New.
2772         (free_dwo_file): Remove, move content to ~dwo_file.
2773         (struct dwo_file_deleter): Remove.
2774         (dwo_file_up>: Remove custom deleter.
2775         (free_dwo_files): Remove.
2776         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2777         dwo_files.
2778         (process_skeletonless_type_units): Call unique_ptr::get.
2779         (allocate_dwo_file_hash_table): Add deleter to created hash
2780         table.  Change return type to htab_up.
2781         (lookup_dwo_file_slot): Don't memset dwo_file, call
2782         unique_ptr::get.
2783         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2784         (create_dwo_unit_in_dwp_v2): Likewise.
2785         (open_and_init_dwo_file): Likewise.
2786         (free_dwo_file_from_slot): Remove.
2787
2788 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2789
2790         * dwarf2read.h (struct dwarf2_section_info) <readin,
2791         is_virtual>: Change type to bool.
2792         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2793         true instead of 1.
2794
2795 2019-06-19  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-data.h (tui_init_content_element): Don't declare.
2798
2799 2019-06-19  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-data.h (tui_init_win_info): Don't declare.
2802
2803 2019-06-19  Tom de Vries  <tdevries@suse.de>
2804
2805         * dwarf2read.h (abstract_to_concrete): Change type to
2806         std::unordered_map<sect_offset, std::vector<sect_offset>,
2807         gdb::hash_enum<sect_offset>>.
2808
2809 2019-06-19  Tom Tromey  <tromey@adacore.com>
2810
2811         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2812         EVAL_AVOID_SIDE_EFFECTS specially.
2813
2814 2019-06-19  Tom Tromey  <tromey@adacore.com>
2815
2816         * source-cache.c (highlighter): New global.
2817         (source_cache::get_source_lines): Create a highlighter on demand.
2818
2819 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * defs.h (deprecated_interactive_hook): Delete declaration.
2822         * interps.c (clear_interpreter_hooks): Remove use of
2823         deprecated_interactive_hook.
2824         * top.c (deprecated_interactive_hook): Delete definition.
2825         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2826
2827 2019-06-18  Tom de Vries  <tdevries@suse.de>
2828
2829         PR gdb/24515
2830         * dwarf2read.h (abstract_to_concrete): Change type from
2831         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2832         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2833         * dwarf2read.c (read_variable): Update.
2834         (dwarf2_fetch_die_loc_sect_off): Update.
2835
2836 2019-06-17  Tom de Vries  <tdevries@suse.de>
2837
2838         PR gdb/24617
2839         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2840         accessing parent[parent_len - 1].
2841
2842 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2843
2844         PR gdb/24364
2845         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2846         call dtrace_process_dof with NULL dof.
2847
2848 2019-06-16  Tom de Vries  <tdevries@suse.de>
2849
2850         PR gdb/24445
2851         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2852
2853 2019-06-16  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2856         (make_all_visible): Use address of member.
2857
2858 2019-06-16  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2861         (tui_free_window, free_content, free_content_elements): Remove
2862         unnecessary cast.
2863         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2864         cast.
2865         * tui/tui-regs.c (tui_show_register_group)
2866         (tui_display_registers_from, tui_display_reg_element_at_line):
2867         Remove unnecessary cast.
2868
2869 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * linux-nat.c (normal_mask): Delete.
2872         (_initialize_linux_nat): Don't initialise normal_mask.
2873
2874 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2875
2876         PR gdb/24445
2877         * dwarf-index-write.h (write_psymtabs_to_index): Add
2878         dwz_basename parameter.
2879         * dwarf-index-write.c (write_gdbindex): Move file writing to
2880         write_gdbindex_1.  Change return type void.
2881         (assert_file_size): Move up, remove filename parameter.
2882         (write_gdbindex_1): New function.
2883         (write_debug_names): Change return type to void, call
2884         assert_file_size.
2885         (struct index_wip_file): New struct.
2886         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2887         file logic to index_wip_file.  Write index for dwz file if
2888         needed.
2889         (save_gdb_index_command): Pass basename of dwz file, if present.
2890         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2891         build-id of dwz file, if present.
2892         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2893         (dwarf2_get_dwz_file): Likewise.
2894         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2895         (dwarf2_get_dwz_file): Likewise.
2896
2897 2019-06-16  Tom Tromey  <tom@tromey.com>
2898
2899         * coffread.c (process_coff_symbol): Use xstrdup.
2900         * value.c (create_internalvar): Use xstrdup.
2901
2902 2019-06-16  Tom Tromey  <tom@tromey.com>
2903
2904         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2905         * breakpoint.c (stopin_command, stopat_command)
2906         (until_break_command, decode_location_default): Remove unnecessary
2907         cast.
2908         * utils.c (subset_compare): Remove unnecessary cast.
2909         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2910         cast.
2911         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2912         cast.
2913         * infcmd.c (path_command): Remove unnecessary cast.
2914         * coffread.c (decode_type): Remove unnecessary cast.
2915         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2916         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2917         * tui/tui-stack.c (tui_show_locator_content)
2918         (tui_show_frame_info): Remove unnecessary cast.
2919         * tui/tui-win.c (tui_scroll_forward_command)
2920         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2921         (parse_scrolling_args): Remove unnecessary cast.
2922         * tui/tui-data.c (init_win_info, tui_del_window)
2923         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2924         (free_content_elements): Remove unnecessary cast.
2925         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2926         unnecessary cast.
2927         * tui/tui-source.c (tui_set_source_content)
2928         (tui_vertical_source_scroll): Remove unnecessary cast.
2929         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2930         cast.
2931         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2932         * tui/tui-regs.c (tui_display_registers_from)
2933         (tui_display_register): Remove unnecessary cast.
2934         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2935         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2936         (make_visible): Remove unnecessary cast.
2937         * tui/tui-winsource.c (tui_erase_source_content)
2938         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2939         unnecessary cast.
2940         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2941         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2942         * stabsread.c (read_type, read_array_type, read_range_type):
2943         Remove unnecessary cast.
2944         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2945         (parse_symbol, parse_type, upgrade_type, parse_external)
2946         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2947         unnecessary cast.
2948         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2949
2950 2019-06-16  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-data.c (tui_alloc_generic_win_info)
2953         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2954         checks.
2955
2956 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2957             Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * f-typeprint.c (f_print_type): Don't return early for not
2960         associated or not allocated types.
2961         (f_type_print_varspec_suffix): Add print_rank parameter and print
2962         ranks of array types in case they dangling.
2963         (f_type_print_base): Add print_rank parameter.
2964
2965 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * NEWS: Mention new MI commands.
2968         * break-catch-throw.c (enum exception_event_kind): Move to
2969         breakpoint.h.
2970         (print_mention_exception_catchpoint): Output text as a single
2971         message.
2972         (catch_exception_command_1): Rename to...
2973         (catch_exception_event): ...this, make non-static, update header
2974         command, and change some parameter types.
2975         (catch_catch_command): Update for changes to
2976         catch_exception_command_1.
2977         (catch_throw_command): Likewise.
2978         (catch_rethrow_command): Likewise.
2979         * breakpoint.c (enum exception_event_kind): Delete.
2980         * breakpoint.h (enum exception_event_kind): Moved here from
2981         break-catch-throw.c.
2982         (catch_exception_event): Declare.
2983         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2984         (mi_cmd_catch_throw): New function.
2985         (mi_cmd_catch_rethrow): New function.
2986         (mi_cmd_catch_catch): New function.
2987         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2988         'catch-catch' entries.
2989         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2990         (mi_cmd_catch_rethrow): Declare.
2991         (mi_cmd_catch_catch): Declare.
2992
2993 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2994
2995         * annotate.c (annotate_source_line): Change return type to void,
2996         update implementation to match.
2997         * annotate.h (annotate_source_line): Change return type to void,
2998         update header comment.
2999         * stack.c (print_frame_info): Don't change what frame information
3000         is printed based on whether annotations are on or not.
3001
3002 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3005         (annotate_source): Make static.
3006         (annotate_source_line): Moved from source.c and renamed from
3007         identify_source_line.  Update the return type.
3008         * annotate.h (annotate_source): Delete declaration.
3009         (annotate_source_line): Declaration moved from source.h, and
3010         renamed from identify_source_line.  Return type updated.
3011         * source.c (identify_source_line): Moved to annotate.c and renamed
3012         to annotate_source_line.
3013         (info_line_command): Remove check of annotation_level.
3014         * source.h (identify_source_line): Move declaration to annotate.h
3015         and rename to annotate_source_line.
3016         * stack.c: Add 'annotate.h' include.
3017         (print_frame_info): Remove check of annotation_level before
3018         calling annotate_source_line.
3019
3020 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         * source-cache.c (source_cache::get_plain_source_lines): Use
3023         open_source_file_with_line_charpos instead of just
3024         open_source_file, remove call to find_source_lines.
3025         (source_cache::get_source_lines): Likewise.
3026         * source.c (find_source_lines): Make static.
3027         (get_filename_and_charpos): Renamed into...
3028         (open_source_file_with_line_charpos): ..this along with changes to
3029         return a scoped_fd, and some other minor clean ups.
3030         (identify_source_line): Use open_source_file_with_line_charpos.
3031         (search_command_helper): Use open_source_file_with_line_charpos
3032         instead of just open_source_file, remove call to
3033         find_source_lines.
3034         * source.h (open_source_file_with_line_charpos): Declare new
3035         function.
3036         (find_source_lines): Delete declaration.
3037
3038 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3039
3040         * source.c (get_filename_and_charpos): Remove fullname
3041         parameter.
3042         (identify_source_line): Update call to get_filename_and_charpos.
3043
3044 2019-06-14  Tom Tromey  <tromey@adacore.com>
3045
3046         PR gdb/24502:
3047         * ui-style.h (skip_ansi_escape): Update comment.
3048         * ui-file.h (class no_terminal_escape_file): New class.
3049         * ui-file.c (no_terminal_escape_file::write)
3050         (no_terminal_escape_file::puts): New methods.
3051         * cli/cli-logging.c (handle_redirections): Use
3052         no_terminal_escape_file.
3053
3054 2019-06-14  Tom Tromey  <tromey@adacore.com>
3055
3056         * NEWS: Move convenience variable news above Python news.
3057
3058 2019-06-14  Tom Tromey  <tom@tromey.com>
3059
3060         * gnulib: Move directory to top-level.
3061         * configure.ac: Don't configure gnulib.
3062         * configure: Rebuild.
3063         * common/common-defs.h: Use new path to gnulib.
3064         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3065         (GNULIB_H): Remove.
3066         (INCGNU): Look in new gnulib location.
3067         (HFILES_NO_SRCDIR): Remove gnulib files.
3068         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3069         (generated_files): Remove GNULIB_H.
3070         ($(LIBGNU), all-lib): Remove targets.
3071         (distclean): Don't mention GNULIB_BUILDDIR.
3072         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3073
3074 2019-06-14  Tom Tromey  <tromey@adacore.com>
3075
3076         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3077         Warn if symbol file does not provide any symbols.
3078
3079 2019-06-14  Tom Tromey  <tromey@adacore.com>
3080
3081         * source.c (find_and_open_source): Respect basenames_may_differ.
3082
3083 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * annotate.c (annotate_breakpoints_invalid): Make use of
3086         scoped_restore_terminal_state.
3087         (annotate_frames_invalid): Likewise.
3088
3089 2019-06-14  Tom Tromey  <tromey@adacore.com>
3090
3091         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3092         allow assignment to an internalvar.
3093
3094 2019-06-14  Tom Tromey  <tromey@adacore.com>
3095
3096         * ada-lex.l: Allow "_" in attribute names.
3097
3098 2019-06-14  Tom Tromey  <tromey@adacore.com>
3099
3100         PR gdb/24653:
3101         * regcache.c (registers_changed): Don't call alloca.
3102         * top.c (execute_command): Don't call alloca.
3103
3104 2019-06-13  Pedro Alves  <palves@redhat.com>
3105
3106         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3107         'expression'.  When parsing an expression, error out if there's
3108         junk after "unlimited".
3109         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3110         (do_set_command): Adjust calls to is_unlimited_literal.
3111
3112 2019-06-13  Pedro Alves  <palves@redhat.com>
3113
3114         * compile/compile.c (make_compile_options_def_group): Add braces
3115         around array_view initializer.
3116         * thread.c (make_thread_apply_all_options_def_group)
3117         (make_thread_apply_all_options_def_group): Likewise.
3118
3119 2019-06-13  Pedro Alves  <palves@redhat.com>
3120
3121         * NEWS (New commands): Mention "maint test-options
3122         require-delimiter", "maint test-options unknown-is-error", "maint
3123         test-options unknown-is-operand" and "maint show
3124         test-options-completion-result".
3125         (New command options, command completion): New section.
3126         (Completion improvements): New section.
3127         Mention that you can abbreviate "unlimited".
3128
3129 2019-06-13  Pedro Alves  <palves@redhat.com>
3130
3131         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3132         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3133         * unittests/cli-utils-selftests.c (test_parse_flags)
3134         (test_parse_flags_qcs): Delete.
3135         (test_cli_utils): Don't call deleted functions.
3136
3137 2019-06-13  Pedro Alves  <palves@redhat.com>
3138
3139         * thread.c: Include "cli/cli-option.h".
3140         (tp_array_compar_ascending): Global.
3141         (tp_array_compar): Delete function.
3142         (tp_array_compar_ascending, tp_array_compar_descending): New
3143         functions.
3144         (ascending_option_def, qcs_flag_option_def)
3145         (thr_qcs_flags_option_defs)
3146         (make_thread_apply_all_options_def_group)
3147         (make_thread_apply_options_def_group): New.
3148         (thread_apply_all_command): Use gdb::option::process_options.
3149         (thread_apply_command_completer)
3150         (thread_apply_all_command_completer): New.
3151         (thread_apply_command): Use gdb::option::process_options.
3152         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3153         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3154         to generate help text of "thread apply".  Adjust "taas"'s help.
3155         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3156         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3157
3158 2019-06-13  Pedro Alves  <palves@redhat.com>
3159
3160         * thread.c (thread_apply_command): Check for invalid TID with
3161         isdigit instead of !isalpha.
3162
3163 2019-06-13  Pedro Alves  <palves@redhat.com>
3164
3165         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3166         (validate_flags_qcs): New.
3167         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3168         (validate_flags_qcs): Declare.
3169         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3170         (make_frame_apply_options_def_group): New.
3171         (frame_apply_command_count): Process options with
3172         gdb::option::process_options.
3173         (frame_apply_completer): New.
3174         (frame_apply_level_completer, frame_apply_all_completer)
3175         (frame_apply_completer): New.
3176         (_initialize_stack): Update help of "frame apply", "frame apply
3177         level", "frame apply all" and "faas" to mention supported options
3178         and install command completers.
3179         * stack.h (frame_apply_all_completer): Declare.
3180         * thread.c: Include "stack.h".
3181         (tfaas_command): Add "--".
3182         (_initialize_thread): Update help "tfaas" to mention supported
3183         options and install command completer.
3184
3185 2019-06-13  Pedro Alves  <palves@redhat.com>
3186
3187         * completer.c (complete_nested_command_line): New.
3188         (gdb_completion_word_break_characters_throw): Add assertion.
3189         * completer.h (complete_nested_command_line): Declare.
3190
3191 2019-06-13  Pedro Alves  <palves@redhat.com>
3192
3193         * stack.c (parse_backtrace_qualifiers): New.
3194         (backtrace_command): Use it.
3195         (backtrace_command_completer): Complete on qualifiers.
3196
3197 2019-06-13  Pedro Alves  <palves@redhat.com>
3198
3199         * frame.c: Include "cli/cli-option.h.
3200         (user_set_backtrace_options): New.
3201         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3202         Delete.
3203         (get_prev_frame): Adjust.
3204         (boolean_option_def, uinteger_option_def)
3205         (set_backtrace_option_defs): New.
3206         (_initialize_frame): Adjust and use
3207         gdb::option::add_setshow_cmds_for_options to install "set
3208         backtrace past-main" and "set backtrace past-entry".
3209         * frame.h: Include "cli/cli-option.h".
3210         (struct frame_print_options): Forward declare.
3211         (print_frame_arguments_all, print_frame_arguments_scalars)
3212         (print_frame_arguments_none): Declare.
3213         (print_entry_values): Delete declaration.
3214         (struct frame_print_options, user_frame_print_options): New.
3215         (struct set_backtrace_options): New.
3216         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3217         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3218         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3219         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3220         (list_args_or_locals): Add frame_print_options parameter.
3221         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3222         * python/py-framefilter.c (enumerate_args): Pass down
3223         USER_FRAME_PRINT_OPTIONS.
3224         * stack.c: Include "cli/cli-option.h".
3225         (print_frame_arguments_all, print_frame_arguments_scalars)
3226         (print_frame_arguments_none): Declare.
3227         (print_raw_frame_arguments, print_entry_values): Delete.
3228         (user_frame_print_options): New.
3229         (boolean_option_def, enum_option_def, frame_print_option_defs):
3230         New.
3231         (struct backtrace_cmd_options): New.
3232         (bt_flag_option_def): New.
3233         (backtrace_command_option_defs): New.
3234         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3235         (print_frame_arg, read_frame_arg, print_frame_args)
3236         (print_frame_info, print_frame): Add frame_print_options parameter
3237         and use it.
3238         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3239         (backtrace_command_1): Add frame_print_options and
3240         backtrace_cmd_options parameters and use them.
3241         (make_backtrace_options_def_group): New.
3242         (backtrace_command): Process command options with
3243         gdb::option::process_options.
3244         (backtrace_command_completer): New.
3245         (_initialize_stack): Extend "backtrace"'s help to mention
3246         supported options.  Install completer for "backtrace".
3247         Install some settings commands with add_setshow_cmds_for_options.
3248
3249 2019-06-13  Pedro Alves  <palves@redhat.com>
3250
3251         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3252         and that "set/show print raw frame-arguments" are now deprecated.
3253
3254         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3255         command.
3256         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3257         * stack.c (_initialize_stack): Install "set/show print
3258         raw-frame-arguments", and deprecate "set/show print raw
3259         frame-arguments".
3260         * valprint.c (_initialize_valprint): Deprecate "set/show print
3261         raw".
3262
3263 2019-06-13  Pedro Alves  <palves@redhat.com>
3264
3265         * compile/compile.c (struct compile_options): New.
3266         (compile_flag_option_def, compile_command_option_defs)
3267         (make_compile_options_def_group): New.
3268         (compile_file_command): Handle options with
3269         gdb::option::process_options.
3270         (compile_file_command_completer): New function.
3271         (compile_code_command): Handle options with
3272         gdb::option::process_options.
3273         (compile_code_command_completer): New function.
3274         (_initialize_compiler): Install completers for "compile code" and
3275         "compile file".  Mention available options in "compile code" and
3276         "compile code"'s help.
3277         * completer.c (advance_to_completion_word): New, factored out from
3278         ...
3279         (advance_to_expression_complete_word_point): ... this.
3280         (advance_to_filename_complete_word_point): New.
3281         * completer.h (advance_to_filename_complete_word_point): New
3282         declaration.
3283
3284 2019-06-13  Pedro Alves  <palves@redhat.com>
3285
3286         * compile/compile.c: Include "cli/cli-option.h".
3287         (compile_print_value): Scope data pointer is now a
3288         value_print_options pointer; adjust.
3289         (compile_print_command): Process options.  Scope data pointer is
3290         now a value_print_options pointer; adjust.
3291         (_initialize_compile): Update "compile print"'s help to include
3292         supported options.  Install a completer for "compile print".
3293         * cp-valprint.c (show_vtblprint, show_objectprint)
3294         (show_static_field_print): Delete.
3295         (_initialize_cp_valprint): Don't install "set print
3296         static-members", "set print vtbl", "set print object" here.
3297         * printcmd.c: Include "cli/cli-option.h" and
3298         "common/gdb_optional.h".
3299         (print_command_parse_format): Rework to fill in a
3300         value_print_options instead of a format_data.
3301         (print_value): Change parameter type from format_data pointer to
3302         value_print_options reference.  Adjust.
3303         (print_command_1): Process options.  Adjust to pass down a
3304         value_print_options.
3305         (print_command_completer): New.
3306         (_initialize_printcmd): Install print_command_completer as
3307         handle_brkchars completer for the "print" command.  Update
3308         "print"'s help to include supported options.
3309         * valprint.c: Include "cli/cli-option.h".
3310         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3311         here from cp-valprint.c.
3312         (boolean_option_def, uinteger_option_def)
3313         (value_print_option_defs, make_value_print_options_def_group):
3314         New.  Use gdb::option::add_setshow_cmds_for_options to install
3315         "set print elements", "set print null-stop", "set print repeats",
3316         "set print pretty", "set print union", "set print array", "set
3317         print address", "set print symbol", "set print array-indexes".
3318         * valprint.h: Include <string> and "cli/cli-option.h".
3319         (make_value_print_options_def_group): Declare.
3320         (print_value): Change parameter type from format_data pointer to
3321         value_print_options reference.
3322         (print_command_completer): Declare.
3323
3324 2019-06-13  Pedro Alves  <palves@redhat.com>
3325
3326         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3327         (COMMON_SFILES): Add maint-test-settings.c.
3328         * cli/cli-decode.c (boolean_enums): New global, factored out from
3329         ...
3330         (add_setshow_boolean_cmd): ... here.
3331         * cli/cli-decode.h (boolean_enums): Declare.
3332         * cli/cli-option.c: New file.
3333         * cli/cli-option.h: New file.
3334         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3335         factored out from ...
3336         (parse_cli_boolean_value(const char *)): ... this.
3337         (is_unlimited_literal): Change parameter type to pointer to
3338         pointer.  Adjust and advance ARG pointer.
3339         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3340         (parse_cli_var_enum): New, factored out from ...
3341         (do_set_command): ... this.  Adjust.
3342         * cli/cli-setshow.h (parse_cli_boolean_value)
3343         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3344         (parse_cli_var_enum): Declare.
3345         * cli/cli-utils.c: Include "cli/cli-option.h".
3346         (get_ulongest): New.
3347         * cli/cli-utils.h (get_ulongest): Declare.
3348         (check_for_argument): New overloads.
3349         * maint-test-options.c: New file.
3350
3351 2019-06-13  Pedro Alves  <palves@redhat.com>
3352
3353         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3354         parse a range if "-" is at the end of the string.
3355
3356 2019-06-13  Pedro Alves  <palves@redhat.com>
3357
3358         * cli/cli-setshow.c (parse_auto_binary_operation)
3359         (parse_cli_boolean_value): Don't allow "o".
3360
3361 2019-06-13  Pedro Alves  <palves@redhat.com>
3362
3363         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3364         * NEWS: Mention maint test-settings KIND.
3365         * maint-test-settings.c: New file.
3366
3367 2019-06-13  Pedro Alves  <palves@redhat.com>
3368
3369         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3370         completer.
3371         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3372         "set" completers.
3373
3374 2019-06-13  Pedro Alves  <palves@redhat.com>
3375
3376         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3377         after item.
3378
3379 2019-06-13  Pedro Alves  <palves@redhat.com>
3380
3381         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3382
3383 2019-06-13  Pedro Alves <palves@redhat.com>
3384
3385         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3386         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3387         call.
3388         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3389         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3390         calls.
3391         (check_for_argument): Skip spaces after argument.
3392
3393 2019-06-13  Pedro Alves  <palves@redhat.com>
3394
3395         * thread.c (thread_apply_command): Adjust TID parsing.
3396         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3397         detected before end of string.
3398         (tid_is_in_list): Error out if LIST is invalid.
3399
3400 2019-06-13  Pedro Alves  <palves@redhat.com>
3401
3402         * completer.c (complete_line_internal_1): Rewind completion word
3403         point.
3404         (completion_tracker::advance_custom_word_point_by): Change
3405         parameter type to int.
3406         * completer.h (completion_tracker::advance_custom_word_point_by):
3407         Likewise.
3408
3409 2019-06-13  Pedro Alves  <palves@redhat.com>
3410
3411         * completer.c (advance_to_completion_word): Handle delimiters.
3412
3413 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3414
3415         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3416
3417 2019-06-11  Tom Tromey  <tom@tromey.com>
3418
3419         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3420         (xmalloc_failed): Move to alloc.c.
3421         * alloc.c: New file.
3422         * Makefile.in (COMMON_SFILES): Add alloc.c.
3423
3424 2019-06-11  Tom Tromey  <tom@tromey.com>
3425
3426         * nat/linux-waitpid.c: Don't include server.h.
3427         (linux_debug): Remove.
3428         (my_waitpid): Update.
3429
3430 2019-06-11  Tom Tromey  <tromey@adacore.com>
3431
3432         * infcall.c (_initialize_infcall): Remove trailing newline from
3433         help.
3434         * user-regs.c (_initialize_user_regs): Remove trailing newline
3435         from help.
3436         * typeprint.c (_initialize_typeprint): Remove trailing newline
3437         from help.
3438         * reverse.c (_initialize_reverse): Remove trailing newlines from
3439         help.
3440         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3441         from help.
3442         * language.c (add_set_language_command): Remove trailing newline
3443         from help.
3444         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3445         help.
3446         * disasm.c (_initialize_disasm): Remove trailing newline from
3447         help.
3448         * top.c (init_main): Remove trailing newline from help.
3449         * interps.c (_initialize_interpreter): Remove trailing newline
3450         from help.
3451         * btrace.c (_initialize_btrace): Remove trailing newlines from
3452         help.
3453         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3454         from help.
3455         * python/python.c (_initialize_python): Remove trailing newline
3456         from help.
3457         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3458         help.
3459         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3460         from help.  Reformat some text.
3461         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3462         from help.
3463         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3464         newline from help.
3465
3466 2019-06-11  Tom Tromey  <tromey@adacore.com>
3467
3468         * darwin-nat.c (darwin_decode_exception_message)
3469         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3470
3471 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         * valops.c (value_slice): Check for not allocated or not
3474         associated values.
3475
3476 2019-06-10  Tom de Vries  <tdevries@suse.de>
3477
3478         PR gdb/24618
3479         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3480         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3481         invalid.
3482
3483 2019-06-10  Tom de Vries  <tdevries@suse.de>
3484
3485         PR gdb/24611
3486         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3487         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3488
3489 2019-06-10  Tom de Vries  <tdevries@suse.de>
3490
3491         PR symtab/24545
3492         * symtab.c (struct demangled_name_entry): Add language field.
3493         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3494         static minimal symbol".  Set and use language field.
3495
3496 2019-06-10  Tom Tromey  <tromey@adacore.com>
3497
3498         * ada-lang.c (_initialize_ada_language): Update help text.
3499
3500 2019-06-10  Tom Tromey  <tromey@adacore.com>
3501
3502         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3503         with a newline.
3504         * guile/guile.c (handle_boot_error): Don't end warning with a
3505         newline.
3506         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3507         warning with a newline.
3508         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3509         newline.
3510         (s12z_frame_cache): Likewise.
3511         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3512         a newline.
3513         * solib-svr4.c (disable_probes_interface): Don't end warning with
3514         a newline.
3515         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3516         newline.
3517         * python/python.c (do_finish_initialization): Don't end warning
3518         with a newline.
3519
3520 2019-06-10  Tom Tromey  <tom@tromey.com>
3521
3522         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3523         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3524         gdbpy_enter.
3525
3526 2019-06-10  Tom Tromey  <tromey@adacore.com>
3527
3528         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3529         data.
3530         (elf_new_init): Don't call stabsread_new_init.
3531         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3532         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3533         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3534
3535 2019-06-10  Tom de Vries  <tdevries@suse.de>
3536
3537         PR symtab/16264
3538         PR symtab/24517
3539         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3540
3541 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3542
3543         * source.c (find_and_open_source): Also rewrite relative file
3544         names.
3545
3546 2019-04-26  Amos Bird  <amosbird@gmail.com>
3547
3548         * annotate.c (annotate_thread_exited): Add "thread-exited"
3549         annotation.
3550
3551 2019-06-06  Tom Tromey  <tromey@adacore.com>
3552
3553         * maint.h (class scoped_command_stats): Use
3554         DISABLE_COPY_AND_ASSIGN.
3555         <print_time>: New method.
3556         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3557         print_time.
3558         (scoped_command_stats::print_time): New method.
3559
3560 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3561
3562         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3563         instructions of lengths 6 or 8 bytes.
3564
3565 2019-06-04  Pedro Alves  <palves@redhat.com>
3566
3567         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3568
3569         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3570         * breakpoint.c (condition_completer): Likewise.
3571         * cli/cli-dump.c (scan_expression): Likewise.
3572         * common/filestuff.c (mkdir_recursive): Likewise.
3573         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3574         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3575         (gdb_abspath): Likewise.
3576         * compile/compile-cplus-types.c
3577         (compile_cplus_instance::decl_name): Likewise.
3578         * completer.c (complete_explicit_location):
3579         (signal_completer, reg_or_group_completer_1): Likewise.
3580         * cp-support.c (cp_remove_params_if_any): Likewise.
3581         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3582         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3583         * infcmd.c (strip_bg_char): Likewise.
3584         * linespec.c (copy_token_string): Likewise.
3585         * mi/mi-main.c (output_cores): Likewise.
3586         * psymtab.c (psymtab_search_name):
3587         * symfile.c (test_set_ext_lang_command): Likewise.
3588         * target.c (target_fileio_read_stralloc): Likewise.
3589         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3590         * value.c (complete_internalvar): Likewise.
3591
3592 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3593
3594         Add objfile property to gdb.Type.
3595         * NEWS: Mention Python API addition.
3596         * python/py-type.c (typy_get_objfile): New method.
3597
3598 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3599
3600         * NEWS: Mention the new set|show style [title|highlight].
3601         Mention changes to "show style", "help" and "apropos".
3602
3603 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3606         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3607         instead of print_help_for_command.
3608         (print_doc_of_command): New function.
3609         (help_list): Add 'apropos -v word' suggestion.
3610         (print_help_for_command): Style the command name using title style.
3611         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3612         (_initialize_cli_cmds): Describe -v in apropos_command help.
3613
3614 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3615
3616         * cli/cli-style.h (cli_style_option): Add name in constructor,
3617         add m_name class member, add constructor with intensity,
3618         add name class function.
3619         (cli_style_option::add_setshow_commands): Remove name argument.
3620         (highlight_style, title_style): New styles.
3621         * cli/cli-style.c (do_show): New function that shows a style
3622         characteristic styling the style name with itself.
3623         (set_style_name): New function.
3624         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3625         Update all callers according to the changes in cli/cli-style.h.
3626         * utils.h (fputs_highlighted): New function.
3627         * utils.c (fputs_highlighted): Likewise.
3628
3629 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3630
3631         * NEWS: Mention new pipe command and new convenience variables.
3632
3633 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3634
3635         * cli/cli-cmds.c (pipe_command): New function.
3636         (_initialize_cli_cmds): Call add_com for pipe_command.
3637         Define | as an alias for pipe.
3638         (exit_status_set_internal_vars): New function.
3639         (shell_escape): Call exit_status_set_internal_vars.
3640         cli/cli-decode.c (find_command_name_length): Recognize | as
3641         a single character command.
3642
3643 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3644
3645         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3646         top.c (execute_command_to_ui_file): New function, mostly a copy
3647         of execute_command_to_string.
3648         (execute_command_to_string): Implement by calling
3649         execute_command_to_ui_file.
3650
3651 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3652
3653         * top.h (saved_command_line): Remove declaration.
3654         * top.c (previous_saved_command_line, previous_repeat_arguments):
3655         New variables.
3656         (saved_command_line): Make static, define together with other
3657         'repeat variables'.
3658         (dont_repeat): Clear repeat_arguments.
3659         (repeat_previous, get_saved_command_line, save_command_line):
3660         New functions.
3661         (gdb_init): Initialize saved_command_line
3662         and previous_saved_command_line.
3663         * main.c (captured_main_1): Remove saved_command_line initialization.
3664         * event-top.c (handle_line_of_input): Update to use
3665         the new 'repeat' related functions instead of direct access to
3666         saved_command_line.
3667         * command.h (repeat_previous, get_saved_command_line,
3668         save_command_line): New declarations.
3669         (dont_repeat): Add comment.
3670
3671 2019-05-30  Tom Tromey  <tromey@adacore.com>
3672
3673         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3674         Fix comment.
3675         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3676
3677 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3678
3679         PR cli/24587
3680         * completer.c (complete): Initialize variable word.
3681
3682 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3683
3684         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3685         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3686         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3687         'body' is NULL to the outter 'if', protecting the '!is_define'
3688         situation as well.
3689
3690 2019-05-29  Tom Tromey  <tromey@adacore.com>
3691
3692         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3693         (dwarf_unknown): New function.
3694         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3695         (dwarf_type_encoding_name): Use dwarf_unknown.
3696
3697 2019-05-29  Tom Tromey  <tromey@adacore.com>
3698
3699         PR c++/20020:
3700         * cp-valprint.c (cp_print_value_fields): Call
3701         cp_print_static_field inside "try".
3702
3703 2019-05-29  Tom Tromey  <tromey@adacore.com>
3704
3705         * inflow.c (struct terminal_info): Add default operator=.
3706         * configure: Rebuild.
3707         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3708         -Wdeprecated-copy-dtor, -Wredundant-move.
3709
3710 2019-05-29  Tom Tromey  <tromey@adacore.com>
3711
3712         * NEWS: Add entry.
3713         * infcmd.c (print_return_value_1): Handle finish_print
3714         option.
3715         (show_print_finish): New function.
3716         (_initialize_infcmd): Add "set/show print finish" commands.
3717         * valprint.c (user_print_options): Initialize new member.
3718         * valprint.h (struct value_print_options) <finish_print>: New
3719         member.
3720
3721 2019-05-28  Tom Tromey  <tromey@adacore.com>
3722
3723         * ada-lang.c (ada_remove_Xbn_suffix)
3724         (find_old_style_renaming_symbol)
3725         (parse_old_style_renaming): Remove.
3726         (ada_find_renaming_symbol): Don't call
3727         find_old_style_renaming_symbol.
3728         (ada_is_renaming_symbol): Rename from
3729         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3730         bool.  Now static.
3731         (ada_read_var_value): Update and simplify.
3732         * ada-exp.y (write_var_or_type): Remove old code.
3733
3734 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3735
3736         * event-top.c: Remove include comment.
3737         * inflow.c (class scoped_ignore_sigttou): Move from here...
3738         * inflow.h (class scoped_ignore_sigttou): ...to here.
3739         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3740         * top.c:  Remove include comment.
3741
3742 2019-05-27  Tom Tromey  <tom@tromey.com>
3743
3744         * NEWS: Fix typo.
3745
3746 2019-05-22  Tom Tromey  <tromey@adacore.com>
3747
3748         * target.c (target_follow_exec): Constify parameter.
3749         * target-delegates.c: Rebuild.
3750         * remote.c (remote_target::follow_exec): Constify parameter.
3751         * infrun.c (follow_exec): Constify parameter.
3752         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3753         (target_follow_exec): Likewise.
3754
3755 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3756
3757         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3758         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3759
3760 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3761
3762         * NEWS: Add debugredirect and testsuite sections.
3763
3764 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3765
3766         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3767         target descriptions using exclusively floating point register name
3768         aliases.
3769
3770 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         PR gdb/18644:
3773         * f-lang.c (build_fortran_types): Handle the case where
3774         gdbarch_floatformat_for_type returns a nullptr.
3775
3776 2019-05-21  Tom de Vries  <tdevries@suse.de>
3777
3778         PR cli/24587
3779         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3780
3781 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         PR gdb/18644:
3784         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3785         16-byte floats.
3786         * i386-tdep.c (i386_floatformat_for_type): Use
3787         floatformats_ia64_quad for the 16-byte floating point component
3788         within a fortran 32-byte complex number.
3789
3790 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3793         delete default constructor.
3794         (find_partial_die): Update to return const struct.
3795         (partial_die_parent_scope): Move variable declaration into scope
3796         of its use and change its type to auto.
3797         (guess_partial_die_structure_name): Likewise.
3798         (partial_die_info::fixup): Likewise.
3799
3800 2019-05-17  Tom Tromey  <tromey@adacore.com>
3801
3802         * source.c (find_and_open_source): Remove cast.
3803
3804 2019-05-17  Tom Tromey  <tromey@adacore.com>
3805
3806         * annotate.c (annotate_source): Make "filename" const.
3807         * annotate.h (annotate_source): Use const.
3808
3809 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3810
3811         * disasm.c (set_disassembler_options): Send errors to stderr.
3812
3813 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3814
3815         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3816         (cli_interp_base::set_logging): Check debug_redirect.
3817         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3818         * cli/cli-logging.c (debug_redirect): Add static variable.
3819         (pop_output_files): Add default param.
3820         (handle_redirections): Print debug setting.
3821         (show_logging_command): Likewise.
3822         (_initialize_cli_logging): Add debugredirect command.
3823         * interps.c (current_interp_set_logging): Add debug_redirect
3824         parameter.
3825         * interps.h (set_logging): Add debug_redirect parameter.
3826         (current_interp_set_logging): Likewise.
3827         * mi/mi-common.h: Likewise.
3828         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3829
3830 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3831             Tom Tromey  <tromey@adacore.com>
3832
3833         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3834         directly.
3835         * cli/cli-interp.h (make_logging_output): Remove declaration.
3836         * cli/cli-logging.c (make_logging_output): Remove function.
3837         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3838         directly.
3839         * ui-file.c (tee_file::tee_file): Remove bools.
3840         (tee_file::~tee_file): Remove deletes.
3841         * ui-file.h (tee_file): Remove bools.
3842
3843 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3844
3845         * mi/mi-cmds.h (mi_cmd_complete): New function.
3846         * mi/mi-main.c (mi_cmd_complete): Likewise.
3847         * mi/mi-cmds.c: Define new MI command -complete.
3848         * NEWS: Mention new -complete command.
3849
3850 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3851
3852         * completer.h (complete): New function.
3853         * completer.c (complete): Likewise.
3854         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3855         function defined in completer.h.
3856
3857 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3858
3859         * MAINTAINERS (Write After Approval): Add myself.
3860
3861 2019-05-17  Tom de Vries  <tdevries@suse.de>
3862
3863         PR gdb/24094
3864         * dwarf2read.c (struct cu_partial_die_info): New struct.
3865         (find_partial_die): Return cu_partial_die_info.
3866         (partial_die_parent_scope, guess_partial_die_structure_name)
3867         (partial_die_info::fixup): Handle new return type of find_partial_die.
3868
3869 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3870
3871         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3872         "std::string", simplifying the algorithm.
3873
3874 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3875
3876         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3877         (stap_static_probe_ops::get_probes): Likewise.
3878
3879 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3880
3881         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3882         '-')" and "else if".
3883         (stap_parse_single_operand): Join checks for
3884         "gdbarch_stap_parse_special_token_p" and
3885         "gdbarch_stap_parse_special_token" in the same "if" statement.
3886         Invert check when verifying for operation on register
3887         displacement.
3888
3889 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3890
3891         * stap-probe.c (stap_get_opcode): Update comment.
3892         (stap_get_expected_argument_type): Likewise.
3893         (handle_stap_probe): Likewise.
3894
3895 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3896
3897         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3898         return type to 'bool'.  Adjust comment.  Use 'bool' when
3899         appropriate.
3900         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3901         * stap-probe.c (stap_parse_argument_1): Likewise.
3902         (stap_is_operator): Likewise.
3903         (stap_is_generic_prefix): Likewise.
3904         (stap_is_register_prefix): Likewise.
3905         (stap_is_register_indirection_prefix): Likewise.
3906         (stap_is_integer_prefix): Likewise.
3907         (stap_generic_check_suffix): Likewise.
3908         (stap_check_integer_suffix): Likewise.
3909         (stap_check_register_suffix): Likewise.
3910         (stap_check_register_indirection_suffix): Likewise.
3911         (stap_parse_register_operand): Likewise.
3912         (stap_parse_single_operand): Likewise.
3913         (stap_parse_argument_1): Likewise.
3914         (stap_probe::get_argument_count): Likewise.
3915         (stap_is_operator): Likewise.
3916
3917 2019-05-16  Tom Tromey  <tromey@adacore.com>
3918
3919         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3920         keyword to foreach.
3921
3922 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3923
3924         * linux-thread-db.c (try_thread_db_load_1): Change return type
3925         to bool.
3926         (try_thread_db_load): Likewise.
3927         (try_thread_db_load_from_pdir_1): Likewise.
3928         (try_thread_db_load_from_pdir): Likewise.
3929         (try_thread_db_load_from_sdir): Likewise.
3930         (try_thread_db_load_from_dir): Likewise.
3931         (thread_db_load_search): Likewise.
3932         (has_libpthread): Likewise.
3933         (thread_db_load): Likewise.
3934
3935 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3936
3937         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3938         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3939         NULL, and complain/return if that's the case.
3940
3941 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3942
3943         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3944         (advance, posn, abstract_read_memory): New functions.
3945         [struct mem_read_abstraction]: New struct.
3946         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3947
3948 2019-05-14  Tom Tromey  <tromey@adacore.com>
3949
3950         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3951         value is not lval_memory.
3952
3953 2019-05-14  Tom Tromey  <tromey@adacore.com>
3954
3955         * solib.c (info_sharedlibrary_command): Style the file name.
3956
3957 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3958
3959         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3960         (aarch64_vnv_type): Likewise.
3961         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3962         * common/tdesc.c: Likewise.
3963         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3964         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3965         * features/aarch64-fpu.xml: Add ieee half view.
3966         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3967         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3968         * gdbtypes.h (struct builtin_type): Likewise.
3969         (struct objfile_type): Likewise.
3970
3971 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3972
3973         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3974         typo.
3975         * location.h (string_to_event_location): Likewise.
3976
3977 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3978
3979         GDB 8.3 released.
3980
3981 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3982
3983         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3984         New variable declaration.
3985         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3986         New variable.
3987         (print_one_breakpoint): Use ui_out::test_flags and new global
3988         variable to compute use_fixed_output.
3989         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3990         Remove.
3991         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3992         (mi_multi_location_breakpoint_output_fixed): Remove.
3993         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3994         new variable.
3995         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3996         fix_multi_location_breakpoint_output flag if version >= 3.
3997         * ui-out.h (enum ui_out_flag)
3998         <fix_multi_location_breakpoint_output>: New enumerator.
3999
4000 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4001
4002         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4003
4004 2019-05-10  Tom Tromey  <tromey@adacore.com>
4005
4006         * ada-lang.c (catch_ada_completer): New function.
4007         (_initialize_ada_language): Use it.
4008
4009 2019-05-10  Tom Tromey  <tromey@adacore.com>
4010
4011         * thread.c (print_thread_info): Make "requested_threads" const.
4012         * gdbthread.h (print_thread_info): Make "requested_threads"
4013         const.
4014         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4015         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4016
4017 2019-05-08  Tom Tromey  <tom@tromey.com>
4018
4019         * gdbtypes.c (objfile_type_data): Change type.
4020         (objfile_type, _initialize_gdbtypes): Update.
4021
4022 2019-05-08  Tom Tromey  <tom@tromey.com>
4023
4024         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4025         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4026         (_initialize_dwarf2_frame): Update.
4027
4028 2019-05-08  Tom Tromey  <tom@tromey.com>
4029
4030         * objc-lang.c (objc_objfile_data): Change type.
4031         (find_methods): Update.
4032         (_initialize_objc_lang): Remove.
4033
4034 2019-05-08  Tom Tromey  <tom@tromey.com>
4035
4036         * stabsread.c (rs6000_builtin_type_data): Change type.
4037         (rs6000_builtin_type, _initialize_stabsread): Update.
4038
4039 2019-05-08  Tom Tromey  <tom@tromey.com>
4040
4041         * mips-tdep.c (mips_pdr_data): Remove.
4042         (_initialize_mips_tdep): Update.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4047         (hppa_init_objfile_priv_data, read_unwind_info)
4048         (find_unwind_entry, _initialize_hppa_tdep): Update.
4049
4050 2019-05-08  Tom Tromey  <tom@tromey.com>
4051
4052         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4053         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4054         on obstack.
4055         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4056
4057 2019-05-08  Tom Tromey  <tom@tromey.com>
4058
4059         * mdebugread.c (basic_type_data): Change type.
4060         (basic_type, _initialize_mdebugread): Update.
4061
4062 2019-05-08  Tom Tromey  <tom@tromey.com>
4063
4064         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4065
4066 2019-05-08  Tom Tromey  <tom@tromey.com>
4067
4068         * nto-tdep.c (nto_inferior_data_reg): Change type.
4069         (nto_inferior_data): Update.
4070         (nto_inferior_data_cleanup, nto_new_inferior_data)
4071         (_initialize_nto_tdep): Remove.
4072         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4073
4074 2019-05-08  Tom Tromey  <tom@tromey.com>
4075
4076         * ada-lang.c (struct ada_inferior_data): Add initializers.
4077         (ada_inferior_data): Change type.
4078         (ada_inferior_data_cleanup): Remove.
4079         (get_ada_inferior_data, ada_inferior_exit)
4080         (struct ada_pspace_data): Add initializers, destructor.
4081         (ada_pspace_data_handle): Change type.
4082         (get_ada_pspace_data): Update.
4083         (ada_pspace_data_cleanup): Remove.
4084
4085 2019-05-08  Tom Tromey  <tom@tromey.com>
4086
4087         * coffread.c (struct coff_symfile_info): Add initializers.
4088         (coff_objfile_data_key): Move lower.  Change type.
4089         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4090         Update.
4091         (coff_free_info): Remove.
4092
4093 2019-05-08  Tom Tromey  <tom@tromey.com>
4094
4095         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4096         (fbsd_pspace_data_handle): Move lower.  Change type.
4097         (get_fbsd_pspace_data): Update.
4098         (fbsd_pspace_data_cleanup): Remove.
4099         (_initialize_fbsd_tdep): Update.
4100
4101 2019-05-08  Tom Tromey  <tom@tromey.com>
4102
4103         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4104         (get_ada_tasks_pspace_data): Update.
4105         (ada_tasks_pspace_data_cleanup): Remove.
4106         (_initialize_tasks): Update.
4107         (ada_tasks_inferior_data_handle): Change type.
4108         (get_ada_tasks_inferior_data): Update.
4109         (ada_tasks_inferior_data_cleanup): Remove.
4110         (struct ada_tasks_pspace_data): Add initializers.
4111
4112 2019-05-08  Tom Tromey  <tom@tromey.com>
4113
4114         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4115         * symfile-debug.c (debug_sym_get_probes): Change type.
4116         * stap-probe.c (handle_stap_probe):
4117         (stap_static_probe_ops::get_probes): Change type.
4118         * probe.h (class static_probe_ops) <get_probes>: Change type.
4119         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4120         (parse_probes_in_pspace): Update.
4121         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4122         Update.
4123         (any_static_probe_ops::get_probes): Change type.
4124         * elfread.c (elfread_data): New typedef.
4125         (probe_key): Change type.
4126         (elf_get_probes): Likewise.  Update.
4127         (probe_key_free): Remove.
4128         (_initialize_elfread): Update.
4129         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4130         Change type.
4131         (dtrace_process_dof_probe, dtrace_process_dof)
4132         (dtrace_static_probe_ops::get_probe): Change type.
4133
4134 2019-05-08  Tom Tromey  <tom@tromey.com>
4135
4136         * xcoffread.c (struct xcoff_symfile_info): Rename from
4137         coff_symfile_info.  Add initializers.
4138         (xcoff_objfile_data_key): Move lower.  Change type.
4139         (XCOFF_DATA): Rewrite.
4140         (xcoff_free_info): Remove.
4141         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4142         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4143         (xcoff_initial_scan): Update.
4144
4145 2019-05-08  Tom Tromey  <tom@tromey.com>
4146
4147         * solib-svr4.c (struct svr4_info): Add initializers and
4148         destructor.
4149         <probes_table>: Now an htab_up.
4150         (solib_svr4_pspace_data): Change type.
4151         (free_probes_table): Simplify.
4152         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4153         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4154         (probes_table_remove_objfile_probes, register_solib_event_probe)
4155         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4156         (_initialize_svr4_solib): Update.
4157
4158 2019-05-08  Tom Tromey  <tom@tromey.com>
4159
4160         * remote.c (remote_pspace_data): Change type.
4161         (remote_pspace_data_cleanup): Remove.
4162         (get_remote_exec_file, set_pspace_remote_exec_file)
4163         (_initialize_remote): Update.
4164
4165 2019-05-08  Tom Tromey  <tom@tromey.com>
4166
4167         * breakpoint.c (breakpoint_objfile_key): Change type.
4168         (get_breakpoint_objfile_data): Update.
4169         (free_breakpoint_objfile_data): Remove.
4170         (_initialize_breakpoint): Update.
4171
4172 2019-05-08  Tom Tromey  <tom@tromey.com>
4173
4174         * linux-tdep.c (struct linux_info): Add initializers.
4175         (linux_inferior_data): Move.  Change type.
4176         (invalidate_linux_cache_inf): Update.
4177         (linux_inferior_data_cleanup): Remove.
4178         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4179
4180 2019-05-08  Tom Tromey  <tom@tromey.com>
4181
4182         * auxv.c (auxv_inferior_data): Move.  Change type.
4183         (auxv_inferior_data_cleanup): Remove.
4184         (invalidate_auxv_cache_inf): Rewrite.
4185         (get_auxv_inferior_data, _initialize_auxv): Update.
4186
4187 2019-05-08  Tom Tromey  <tom@tromey.com>
4188
4189         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4190         (symfile_debug_objfile_data_key): Change type.
4191         (symfile_debug_installed, debug_qf_has_symbols)
4192         (debug_qf_find_last_source_symtab)
4193         (debug_qf_forget_cached_source_info)
4194         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4195         (debug_qf_print_stats, debug_qf_dump)
4196         (debug_qf_expand_symtabs_for_function)
4197         (debug_qf_expand_all_symtabs)
4198         (debug_qf_expand_symtabs_with_fullname)
4199         (debug_qf_map_matching_symbols)
4200         (debug_qf_expand_symtabs_matching)
4201         (debug_qf_find_pc_sect_compunit_symtab)
4202         (debug_qf_map_symbol_filenames)
4203         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4204         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4205         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4206         (debug_sym_read_linetable, debug_sym_relocate): Update.
4207         (symfile_debug_free_objfile): Remove.
4208         (install_symfile_debug_logging, _initialize_symfile_debug):
4209         Update.
4210
4211 2019-05-08  Tom Tromey  <tom@tromey.com>
4212
4213         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4214         allocate_on_obstack.
4215         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4216         (get_dwarf2_per_objfile): Update.
4217         (set_dwarf2_per_objfile): Remove.
4218         (dwarf2_has_info, dwarf2_get_section_info): Update.
4219         (dwarf2_free_objfile): Remove.
4220         (_initialize_dwarf2_read): Update.
4221
4222 2019-05-08  Tom Tromey  <tom@tromey.com>
4223
4224         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4225         initializers.
4226         <unsupported_script_warning_printed,
4227         script_not_found_warning_printed>: Now bool.
4228         (auto_load_pspace_data): Change type.
4229         (~auto_load_pspace_info): Rename from
4230         auto_load_pspace_data_cleanup.
4231         (get_auto_load_pspace_data, init_loaded_scripts_info)
4232         (clear_section_scripts, maybe_print_unsupported_script_warning)
4233         (maybe_print_script_not_found_warning, _initialize_auto_load):
4234         Update.
4235
4236 2019-05-08  Tom Tromey  <tom@tromey.com>
4237
4238         * objfiles.c (objfile_pspace_info): Add destructor and
4239         initializers.
4240         (objfiles_pspace_data): Change type.
4241         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4242         (get_objfile_pspace_data): Update.
4243         (objfiles_bfd_data): Change type.
4244         (get_objfile_bfd_data): Update.
4245         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4246
4247 2019-05-08  Tom Tromey  <tom@tromey.com>
4248
4249         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4250         Change type.
4251         (get_catch_syscall_inferior_data): Update.
4252         (catch_syscall_inferior_data_cleanup): Remove.
4253         (_initialize_break_catch_syscall): Update.
4254
4255 2019-05-08  Tom Tromey  <tom@tromey.com>
4256
4257         * inflow.c (struct terminal_info): Add destructor and
4258         initializers.
4259         (inflow_inferior_data): Change type.
4260         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4261         (get_inflow_inferior_data, inflow_inferior_exit)
4262         (swap_terminal_info, _initialize_inflow): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * target-dcache.c (target_dcache_cleanup): Remove.
4267         (target_dcache_aspace_key): Change type.
4268         (target_dcache_init_p, target_dcache_invalidate)
4269         (target_dcache_get, target_dcache_get_or_init)
4270         (_initialize_target_dcache): Update.
4271         * dcache.h (struct dcache_deleter): New.
4272
4273 2019-05-08  Tom Tromey  <tom@tromey.com>
4274
4275         * symtab.c (struct symbol_cache): Add destructor and
4276         initializers.
4277         (symbol_cache_key): Move.  Change type.
4278         (make_symbol_cache, free_symbol_cache): Remove.
4279         (get_symbol_cache): Update.
4280         (symbol_cache_cleanup): Remove.
4281         (ALL_PSPACES, symbol_cache_flush)
4282         (maintenance_print_symbol_cache)
4283         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4284         Update.
4285
4286 2019-05-08  Tom Tromey  <tom@tromey.com>
4287
4288         * symtab.c (struct main_info): Add destructor and initializers.
4289         (main_progspace_key): Move.  Change type.
4290         (get_main_info): Update.
4291         (main_info_cleanup): Remove.
4292         (_initialize_symtab): Update.
4293
4294 2019-05-08  Tom Tromey  <tom@tromey.com>
4295
4296         * registry.h (DECLARE_REGISTRY): Define the _key class.
4297
4298 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * NEWS: Merge two 'New commands' sections.
4301
4302 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4303
4304         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4305         parameter and use Ada language definition instead.
4306         (ada_val_print_ptr): Remove unused language parameter.
4307         (ada_val_print_num): Remove language parameter and use Ada language
4308         definition instead.
4309         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4310         parameter.
4311         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4312         parameter and use Ada language definition instead.
4313         (ada_val_print_1): Update all ada_val_print_xxx calls.
4314         Remove language parameter.
4315         (ada_val_print): Update ada_val_print_1 call.
4316
4317 2019-05-08  Tom Tromey  <tromey@adacore.com>
4318
4319         * remote.c (remote_hw_watchpoint_limit)
4320         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4321         Now static.
4322
4323 2019-05-08  Tom Tromey  <tromey@adacore.com>
4324
4325         * maint.c (_initialize_maint_cmds): Move initialization code to
4326         remote.c.
4327         (watchdog, show_watchdog): Move to remote.c.
4328         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4329         "watchdog" static.
4330         (_initialize_remote): Move initialization code from maint.c.
4331         * defs.h (watchdog): Don't declare.
4332
4333 2019-05-08  Tom Tromey  <tromey@adacore.com>
4334
4335         * tui/tui-interp.c: Include main.h.
4336         * interps.c: Include main.h.
4337         * main.h (interpreter_p): Declare.
4338         * defs.h (interpreter_p): Don't declare.
4339
4340 2019-05-08  Tom Tromey  <tromey@adacore.com>
4341
4342         * dwarf2loc.c: Include dwarf2read.h.
4343         * defs.h (read_unsigned_leb128): Don't declare.
4344         * dwarf2read.h (read_unsigned_leb128): Declare.
4345
4346 2019-05-08  Tom Tromey  <tromey@adacore.com>
4347
4348         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4349         method.
4350
4351 2019-05-08  Tom Tromey  <tromey@adacore.com>
4352
4353         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4354         when no wrap column is set.
4355
4356 2019-05-08  Tom Tromey  <tromey@adacore.com>
4357
4358         * c-lang.c (c_get_string): Handle non-C-style arrays.
4359
4360 2019-05-08  Tom Tromey  <tromey@adacore.com>
4361
4362         * typeprint.c (print_offset_data::update): Print the bit offset,
4363         not the number of bits remaining.
4364
4365 2019-05-08  Tom Tromey  <tromey@adacore.com>
4366
4367         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4368         padding at end of comment.
4369
4370 2019-05-08  Tom Tromey  <tromey@adacore.com>
4371
4372         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4373         Compare main types.
4374
4375 2019-05-06  Tom Tromey  <tom@tromey.com>
4376
4377         * common/scoped_mmap.c: Include common-defs.h.
4378         * common/scoped_mmap.h: Don't include config.h.
4379
4380 2019-05-04  Tom Tromey  <tom@tromey.com>
4381
4382         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4383         (struct aarch64_call_info): Add initializers.
4384         <si>: Now a std::vector.
4385         (pass_on_stack, aarch64_push_dummy_call): Update.
4386
4387 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4388             Tom Tromey  <tom@tromey.com>
4389
4390         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4391         (ppc_threads): Now a std::vector.  Now static.
4392         (hwdebug_find_thread_points_by_tid)
4393         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4394         Update.
4395
4396 2019-05-04  Tom Tromey  <tom@tromey.com>
4397
4398         * arc-tdep.c (arc_tdesc_init): Return bool.
4399
4400 2019-05-04  Tom Tromey  <tom@tromey.com>
4401
4402         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4403         Use gdb_assert_not_reached.
4404
4405 2019-05-04  Tom Tromey  <tom@tromey.com>
4406
4407         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4408         "false".
4409
4410 2019-05-04  Tom Tromey  <tom@tromey.com>
4411
4412         * arc-tdep.c (arc_tdesc_init): Use bool.
4413
4414 2019-05-04  Tom Tromey  <tom@tromey.com>
4415
4416         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4417
4418 2019-05-04  Tom Tromey  <tom@tromey.com>
4419
4420         * cli/cli-cmds.c (valid_command_p): Return bool.
4421
4422 2019-05-04  Tom Tromey  <tom@tromey.com>
4423
4424         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4425         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4426
4427 2019-05-04  Raul Tambre  <raul@tambre.ee>
4428
4429         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4430         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4431         operator for comparison.
4432
4433 2019-05-04  Tom Tromey  <tom@tromey.com>
4434
4435         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4436         (lookup_partial_symbol, print_partial_symbols)
4437         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4438         (psymbol_compare): Update.
4439         (add_psymbol_to_bcache): Clear the entire psymbol.
4440         (maintenance_check_psymtabs): Update.
4441         * psympriv.h (struct partial_symbol): Don't derive from
4442         general_symbol_info.
4443         <obj_section, unrelocated_address, address,
4444         set_unrelocated_address>: Update.
4445         <ginfo>: New member.
4446         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4447         (debug_names::write_psymbols): Update.
4448
4449 2019-05-04  Tom de Vries  <tdevries@suse.de>
4450
4451         * contrib/cc-with-tweaks.sh: Support -n arg.
4452
4453 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4454
4455         * corelow.c (core_target::detach): Ensure frame cache and
4456         register caches are cleared.
4457         inferior.c (exit_inferior_1): Likewise.
4458
4459 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4460             Tom Tromey  <tom@tromey.com>
4461
4462         * dictionary.c (collate_pending_symbols_by_language): Remove
4463         "struct" from foreach.
4464         * symtab.c (lookup_global_symbol_from_objfile)
4465         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4466         foreach.
4467         * ser-tcp.c (net_open): Remove "struct" from foreach.
4468         * objfiles.c (objfile_relocate, objfile_rebase)
4469         (objfile_has_symbols): Remove "struct" from foreach.
4470         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4471         from foreach.
4472         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4473         foreach.
4474         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4475         "struct" from foreach.
4476         * ada-lang.c (create_excep_cond_exprs)
4477         (ada_exception_catchpoint_cond_string): Remove "struct" from
4478         foreach.
4479
4480 2019-05-03  Tom Tromey  <tromey@adacore.com>
4481
4482         * ada-exp.y (convert_char_literal): Check suffix of each
4483         enumerator.
4484
4485 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4486
4487         PR ada/21406:
4488         * ada-exp.y (yywrap): Don't define.
4489         * ada-lex.l (%option): Add noyywrap
4490         (yywrap): Remove.
4491
4492 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4493
4494         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4495         _WIN32_WINNT to the XP level, unless already defined to a higher
4496         level.
4497
4498         * unittests/parse-connection-spec-selftests.c:
4499         * ser-tcp.c:
4500         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4501         override.
4502
4503         * symfile.c (find_separate_debug_file): Remove colon from the
4504         drive spec of DOS/Windows file names of the target, so that the
4505         file name produced from DEBUGDIR and the target's directory will
4506         be valid on DOS/Windows systems.
4507
4508 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * rust-lang.c (val_print_struct): Handle printing structures
4511         containing strings.
4512
4513 2019-05-02  Tom Tromey  <tromey@adacore.com>
4514
4515         * valarith.c (_initialize_valarith): Remove.
4516
4517 2019-05-01  Tom Tromey  <tromey@adacore.com>
4518
4519         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4520         bitfields.
4521
4522 2019-05-01  Tom Tromey  <tromey@adacore.com>
4523
4524         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4525         for big-endian copies.
4526
4527 2019-04-30  Ali Tamur  <tamur@google.com>
4528         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4529         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4530         (read_3_bytes): New function.
4531
4532 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4533
4534         * windows-nat.c (main_thread_id): Delete.
4535         (handle_output_debug_string): Replace main_thread_id by
4536         current_event.dwThreadId.
4537         (fake_create_process): Likewise.
4538         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4539         Do not set main_thread_id.
4540         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4541         current_event.dwThreadId.
4542         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4543
4544 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4545
4546         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4547         Use current_event.dwThreadId instead of main_thread_id.
4548
4549 2019-04-30  Tom Tromey  <tromey@adacore.com>
4550
4551         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4552         (create_excep_cond_exprs): Iterate over program spaces.
4553         (ada_exception_catchpoint_cond_string): Examine all minimal
4554         symbols for exception types.
4555
4556 2019-04-30  Tom Tromey  <tromey@adacore.com>
4557
4558         PR c++/24470:
4559         * dwarf2read.c (process_structure_scope): Handle case where type
4560         has template parameters but no symbol was created.
4561
4562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4563             Chris January  <chris.january@arm.com>
4564
4565         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4566         qualifier.
4567         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4568
4569 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * f-typeprint.c (f_print_type): Update rules for printing
4572         whitespace.
4573         (f_type_print_varspec_suffix): Likewise.
4574
4575 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4576             Chris January  <chris.january@arm.com>
4577
4578         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4579         function arguments.
4580
4581 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * f-lang.c (build_fortran_types): Change name of void type to
4584         lower case.
4585         * f-typeprint.c (f_type_print_base): Print the name of the void
4586         type, rather than a fixed string.
4587         * f-valprint.c (f_decorations): Use lower case void string.
4588
4589 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4590             Chris January  <chris.january@arm.com>
4591
4592         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4593         types for Fortran.
4594
4595 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4596             Chris January  <chris.january@arm.com>
4597             David Lecomber  <david.lecomber@arm.com>
4598
4599         * f-exp.y (BINOP_INTRINSIC): New token.
4600         (exp): New parser rule handling BINOP_INTRINSIC.
4601         (f77_keywords): Add new builtin procedures.
4602         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4603         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4604         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4605         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4606         (print_unop_subexp_f): New function.
4607         (print_binop_subexp_f): New function.
4608         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4609         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4610         (dump_subexp_body_f): Likewise.
4611         (operator_check_f): Likewise.
4612         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4613         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4614
4615 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4618         UNOP_KIND.
4619         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4620         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4621         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4622         (operator_length_f): New fuction.
4623         (print_subexp_f): New function.
4624         (op_name_f): New function.
4625         (dump_subexp_body_f): New function.
4626         (operator_check_f): New function.
4627         (exp_descriptor_f): Replace standard expression handling functions
4628         with new functions.
4629         * gdb/fortran-operator.def: New file.
4630         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4631         * gdb/std-operator.def: Remove UNOP_KIND.
4632
4633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * std-operator.def: Remove unbalanced, stray double quote
4636         character.
4637
4638 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4639             Chris January  <chris.january@arm.com>
4640             Daniel Everett  <daniel.everett@arm.com>
4641             Nick Forrington  <nick.forrington@arm.com>
4642             Richard Bunt  <richard.bunt@arm.com>
4643
4644         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4645         of depth when printing anonymous structs or unions.
4646         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4647         Don't print either the top-level value, or the children if the
4648         max-depth is exceeded.
4649         (ppscm_print_children): When printing the key of a map, allow one
4650         extra level of depth.
4651         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4652         print either the top-level value, or the children if the max-depth
4653         is exceeded.
4654         (print_children): When printing the key of a map, allow one extra
4655         level of depth.
4656         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4657         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4658         (user_print_options): Initialise max_depth field.
4659         (val_print_scalar_or_string_type_p): New function.
4660         (val_print): Check to see if the max depth has been reached.
4661         (val_print_check_max_depth): Define new function.
4662         (show_print_max_depth): New function.
4663         (_initialize_valprint): Add 'print max-depth' option.
4664         * valprint.h (struct value_print_options) <max_depth>: New field.
4665         (val_print_check_max_depth): Declare new function.
4666         * NEWS: Document new feature.
4667
4668 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4669
4670         * ada-lang.c (ada_language_defn): Initialise new field.
4671         * c-lang.c (c_is_string_type_p): New function.
4672         (c_language_defn): Initialise new field.
4673         (cplus_language_defn): Initialise new field.
4674         (asm_language_defn): Initialise new field.
4675         (minimal_language_defn): Initialise new field.
4676         * c-lang.h (c_is_string_type_p): Declare new function.
4677         * d-lang.c (d_language_defn): Initialise new field.
4678         * f-lang.c (f_is_string_type_p): New function.
4679         (f_language_defn): Initialise new field.
4680         * go-lang.c (go_is_string_type_p): New function.
4681         (go_language_defn): Initialise new field.
4682         * language.c (default_is_string_type_p): New function.
4683         (unknown_language_defn): Initialise new field.
4684         (auto_language_defn): Initialise new field.
4685         * language.h (struct language_defn) <la_is_string_type_p>: New
4686         member variable.
4687         (default_is_string_type_p): Declare new function.
4688         * m2-lang.c (m2_language_defn): Initialise new field.
4689         * objc-lang.c (objc_language_defn): Initialise new field.
4690         * opencl-lang.c (opencl_language_defn): Initialise new field.
4691         * p-lang.c (pascal_is_string_type_p): New function.
4692         (pascal_language_defn): Initialise new field.
4693         * rust-lang.c (rust_is_string_type_p): New function.
4694         (rust_language_defn): Initialise new field.
4695
4696 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4699         New field.
4700         * ada-lang.c (ada_language_defn): Initialise new field.
4701         * c-lang.c (c_language_defn): Likewise.
4702         (cplus_language_defn): Likewise.
4703         (asm_language_defn): Likewise.
4704         (minimal_language_defn): Likewise.
4705         * d-lang.c (d_language_defn): Likewise.
4706         * f-lang.c (f_language_defn): Likewise.
4707         * go-lang.c (go_language_defn): Likewise.
4708         * language.c (unknown_language_defn): Likewise.
4709         (auto_language_defn): Likewise.
4710         * m2-lang.c (m2_language_defn): Likewise.
4711         * objc-lang.c (objc_language_defn): Likewise.
4712         * opencl-lang.c (opencl_language_defn): Likewise.
4713         * p-lang.c (pascal_language_defn): Likewise.
4714         * rust-lang.c (rust_language_defn): Likewise.
4715
4716 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * ada-lang.c (ada_is_character_type): Change return type to bool.
4719         (ada_is_string_type): Likewise.
4720         * ada-lang.h (ada_is_character_type): Update declaration
4721         (ada_is_string_type): Likewise.
4722
4723 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4724
4725         Support style in 'frame|thread apply'
4726
4727         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4728         * record.c (record_start, record_stop): Update callers of
4729         execute_command_to_string with false.
4730         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4731         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4732         methods.
4733         (class string_file): New constructor with term_out parameter.
4734         Override methods term_out and can_emit_style_escape.  New member
4735         term_out.
4736         (class stdio_file): Override can_emit_style_escape.
4737         (class tee_file): Override term_out and can_emit_style_escape.
4738         * utils.h (can_emit_style_escape): Remove.
4739         * utils.c (can_emit_style_escape): Likewise.
4740         Update all callers of can_emit_style_escape (SOMESTREAM) to
4741         SOMESTREAM->can_emit_style_escape.
4742         * source-cache.c (source_cache::get_source_lines): Likewise.
4743         * stack.c (frame_apply_command_count): Call execute_command_to_string
4744         passing the term_out characteristic of the current gdb_stdout.
4745         * thread.c (thr_try_catch_cmd): Likewise.
4746         * top.c (execute_command_to_string): pass term_out parameter
4747         to construct the string_file for the command output.
4748         * ui-file.c (term_cli_styling): New function (most code moved
4749         from utils.c can_emit_style_escape).
4750         (string_file::string_file, string_file::can_emit_style_escape,
4751         stdio_file::can_emit_style_escape, tee_file::term_out,
4752         tee_file::can_emit_style_escape): New functions.
4753
4754 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4755
4756         * NEWS: Mention the new set|show may-call-functions.
4757         * infcall.c (may_call_functions_p): New variable.
4758         (show_may_call_functions_p): New function.
4759         (call_function_by_hand_dummy): Throws an error if not
4760         may-call-functions.
4761         (_initialize_infcall): Call add_setshow_boolean_cmd for
4762         may-call-functions.
4763
4764 2019-04-25  Keith Seitz  <keiths@redhat.com>
4765
4766         PR c++/24367
4767         * cp-support.c (inspect_type): Don't attempt substitutions
4768         of symbol with the same name.
4769
4770 2019-04-25  Tom Tromey  <tromey@adacore.com>
4771
4772         PR gdb/24475:
4773         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4774         static.
4775
4776 2019-04-25  Tom Tromey  <tromey@adacore.com>
4777
4778         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4779         rvalue reference.
4780         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4781         (gdb_xml_parser::parse): Use std::move.
4782         * python/python-internal.h (gdbpy_convert_exception): Take a const
4783         reference.
4784         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4785         std::move.
4786         * python/py-utils.c (gdbpy_convert_exception): Take a const
4787         reference.
4788         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4789         Use std::move.
4790         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4791         Use std::move.
4792         * mi/mi-main.c (mi_print_exception): Take a const reference.
4793         * main.c (handle_command_errors): Take a const reference.
4794         * linespec.c (parse_linespec): Use std::move.
4795         * infcall.c (run_inferior_call): Use std::move.
4796         (call_function_by_hand_dummy): Use std::move.
4797         * exec.c (try_open_exec_file): Use std::move.
4798         * exceptions.h (exception_print, exception_fprintf)
4799         (exception_print_same): Update.
4800         * exceptions.c (print_exception, exception_print)
4801         (exception_fprintf, exception_print_same): Change parameters to
4802         const reference.
4803         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4804         * common/new-op.c: Use std::move.
4805         * common/common-exceptions.h (struct gdb_exception): Add move
4806         constructor.
4807         (struct gdb_exception_error, struct gdb_exception_quit, struct
4808         gdb_quit_bad_alloc): Change constructor to move constructor.
4809         (throw_exception): Change parameter to rvalue reference.
4810         * common/common-exceptions.c (throw_exception): Take rvalue
4811         reference.
4812         * cli/cli-interp.c (safe_execute_command): Use std::move.
4813         * breakpoint.c (insert_bp_location, location_to_sals): Use
4814         std::move.
4815
4816 2019-04-25  Tom Tromey  <tromey@adacore.com>
4817
4818         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4819         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4820         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4821         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4822         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4823         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4824         guile/scm-value.c: Use unpack.
4825         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4826         gdbscm_gdb_exception.
4827         (gdbscm_throw_gdb_exception): Likewise.
4828         (struct gdbscm_gdb_exception): New.
4829         (unpack): New function.
4830         (gdbscm_wrap): Use unpack.
4831
4832 2019-04-25  Tom Tromey  <tromey@adacore.com>
4833
4834         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4835         (gdb_rl_callback_handler): Use std::move.
4836         * common/common-exceptions.h (struct gdb_exception): Add move
4837         assignment operator.
4838         (throw_exception_sjlj): Change "exception" to const reference.
4839         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4840         (throw_exception_sjlj): Change "exception" to const reference.
4841
4842 2019-04-25  Tom Tromey  <tromey@adacore.com>
4843
4844         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4845         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4846         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4847         Update.
4848         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4849         Update.
4850         * mi/mi-interp.c (mi_interp::exec): Update.
4851         * linespec.c (parse_linespec): Update.
4852         * infcall.c (run_inferior_call): Update.
4853         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4854         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4855         (gdbscm_lookup_global_symbol): Update.
4856         * guile/scm-param.c (gdbscm_parameter_value): Update.
4857         * guile/scm-frame.c (gdbscm_frame_read_register)
4858         (gdbscm_frame_read_var): Update.
4859         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4860         * exec.c (try_open_exec_file): Update.
4861         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4862         (gdb_rl_callback_handler): Update.
4863         * common/common-exceptions.h (exception_none): Don't declare.
4864         * common/common-exceptions.c (exception_none): Don't define.
4865         (struct catcher) <exception>: Update.
4866         * cli/cli-interp.c (safe_execute_command): Update.
4867         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4868
4869 2019-04-25  Ali Tamur  <tamur@google.com>
4870
4871         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4872         (read_attribute_value): Likewise.
4873         (dwarf2_read_addr_index): Update comment.
4874         (read_str_index): Add DW_FORM_strx.
4875         (dwarf2_string_attr): Likewise.
4876         (dwarf2_const_value_attr): Likewise.
4877         (dump_die_shallow): Likewise.
4878         (dwarf2_fetch_constant_bytes): Likewise.
4879         (skip_form_bytes): Likewise.
4880         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4881
4882 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4883
4884         PR corefiles/11608
4885         PR corefiles/18187
4886         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4887         OFFSET.  Verify if current mapping contains an ELF header.
4888         (linux_find_memory_regions_full): Adjust call to
4889         dump_mapping_p.
4890
4891 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4892             Kang Li <kanglictf@gmail.com>
4893
4894         PR gdb/21600
4895
4896         * dwarf2-frame.c (read_initial_length): Be consistent about using
4897         unsigned representation of length.
4898         (decode_frame_entry_1): Likewise.  Check for wraparound of
4899         end pointer as well as buffer overflow.
4900
4901 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4902
4903         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4904         "vq".
4905
4906 2019-04-24  Tom Tromey  <tromey@adacore.com>
4907
4908         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4909
4910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * s12z-tdep.c (s12z_unwind_pc): Delete.
4913         (s12z_unwind_sp): Delete.
4914         (s12z_gdbarch_init): Don't register deleted functions with
4915         gdbarch.
4916
4917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * rl78-tdep.c (rl78_unwind_sp): Delete.
4920         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4921
4922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4925         (xstormy16_unwind_pc): Delete.
4926         (xstormy16_dummy_id): Delete.
4927         (xstormy16_gdbarch_init): Don't register deleted functions with
4928         gdbarch.
4929
4930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * vax-tdep.c (vax_unwind_pc): Delete.
4933         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4934
4935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * v850-tdep.c (v850_unwind_sp): Delete.
4938         (v850_unwind_pc): Delete.
4939         (v850_dummy_id): Delete.
4940         (v850_gdbarch_init): Don't register deleted functions with
4941         gdbarch.
4942
4943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4946         (tilegx_unwind_pc): Delete.
4947         (tilegx_unwind_dummy_id): Delete.
4948         (tilegx_gdbarch_init): Don't register deleted functions with
4949         gdbarch.
4950
4951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4954         (tic6x_dummy_id): Delete.
4955         (tic6x_gdbarch_init): Don't register deleted functions with
4956         gdbarch.
4957
4958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * sparc-tdep.c (sparc_unwind_pc): Delete.
4961         (sparc32_gdbarch_init): Don't register deleted function with
4962         gdbarch.
4963
4964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4965
4966         * sh-tdep.c (sh_unwind_sp): Delete.
4967         (sh_unwind_pc): Delete.
4968         (sh_dummy_id): Delete.
4969         (sh_gdbarch_init): Don't register deleted functions with
4970         gdbarch.
4971
4972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * score-tdep.c (score_unwind_sp): Delete.
4975         (score_unwind_pc): Delete.
4976         (score_dummy_id): Delete.
4977         (score_gdbarch_init): Don't register deleted functions with
4978         gdbarch.
4979
4980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * rx-tdep.c (rx_unwind_pc): Delete.
4983         (rx_unwind_sp): Delete.
4984         (rx_dummy_id): Delete.
4985         (rx_gdbarch_init): Don't register deleted functions with
4986         gdbarch.  Update comment.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4991         (rs6000_dummy_id): Delete.
4992         (rs6000_gdbarch_init): Don't register deleted functions with
4993         gdbarch.
4994
4995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4996
4997         * or1k-tdep.c (or1k_dummy_id): Delete.
4998         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4999
5000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * nios2-tdep.c (nios2_dummy_id): Delete.
5003         (nios2_unwind_sp): Delete.
5004         (nios2_gdbarch_init): Don't register deleted functions with
5005         gdbarch.
5006
5007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * nds32-tdep.c (nds32_dummy_id): Delete.
5010         (nds32_unwind_pc): Delete.
5011         (nds32_unwind_sp): Delete.
5012         (nds32_gdbarch_init): Don't register deleted functions with
5013         gdbarch.
5014
5015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5016
5017         * msp430-tdep.c (msp430_unwind_pc): Delete.
5018         (msp430_unwind_sp): Delete.
5019         (msp430_dummy_id): Delete.
5020         (msp430_gdbarch_init): Don't register deleted functions with
5021         gdbarch.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * moxie-tdep.c (moxie_unwind_sp): Delete.
5026         (moxie_unwind_pc): Delete.
5027         (moxie_dummy_id): Delete.
5028         (moxie_gdbarch_init): Don't register deleted functions with
5029         gdbarch.
5030
5031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5034         (mn10300_unwind_pc): Delete.
5035         (mn10300_unwind_sp): Delete.
5036         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5037         mn10300_unwind_sp.
5038         (mn10300_frame_unwind_init): Don't register deleted functions with
5039         gdbarch.
5040
5041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * mep-tdep.c (mep_unwind_pc): Delete.
5044         (mep_unwind_sp): Delete.
5045         (mep_dummy_id): Delete.
5046         (mep_gdbarch_init): Don't register deleted functions with
5047         gdbarch.
5048
5049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5052         (m68hc11_unwind_sp): Delete.
5053         (m68hc11_gdbarch_init): Don't register deleted functions with
5054         gdbarch.
5055
5056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * m32r-tdep.c (m32r_unwind_sp): Delete.
5059         (m32r_unwind_pc): Delete.
5060         (m32r_dummy_id): Delete.
5061         (m32r_gdbarch_init): Don't register deleted functions with
5062         gdbarch.
5063
5064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * m32c-tdep.c (m32c_unwind_pc): Delete.
5067         (m32c_unwind_sp): Delete.
5068         (m32c_dummy_id): Delete.
5069         (m32c_gdbarch_init): Don't register deleted functions with
5070         gdbarch.
5071
5072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5075         (lm32_unwind_pc): Delete.
5076         (lm32_dummy_id): Delete.
5077         (lm32_gdbarch_init): Don't register deleted functions with
5078         gdbarch.
5079
5080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5083         (iq2000_unwind_pc): Delete.
5084         (iq2000_dummy_id): Delete.
5085         (iq2000_gdbarch_init): Don't register deleted functions with
5086         gdbarch.
5087
5088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * nds32-tdep.c (nds32_type_align): Delete.
5091         (nds32_push_dummy_call): Use type_align instead.
5092
5093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * arm-tdep.c (arm_type_align): Only handle vector override case.
5096         (arm_push_dummy_call): Use type_align.
5097         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5098
5099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5102         case.
5103         (pass_on_stack): Use type_align.
5104         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5105         function.
5106
5107 2019-04-23  Tom Tromey  <tromey@adacore.com>
5108
5109         * dwarf2read.c (line_header::file_name_at): Remove unused
5110         overload.
5111
5112 2019-04-23  Tom de Vries  <tdevries@suse.de>
5113
5114         PR gdb/24438
5115         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5116         invocation.
5117
5118
5119 2019-03-27  Ali Tamur  <tamur@google.com>
5120
5121         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5122         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5123         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5124         (dwarf_expr_context::get_addr_index): Likewise
5125         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5126         (symbol_needs_eval_context::get_addr_index): Likewise
5127         (disassemble_dwarf_expression): Add DW_OP_addrx
5128         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5129         (read_cutu_die_from_dwo): Update comment
5130         (skip_one_die): Add DW_FORM_addrx
5131         (read_attribute_value): Likewise
5132         (var_decode_location): Add DW_OP_addrx
5133         (dwarf2_const_value_attr): Add DW_FORM_addrx
5134         (dump_die_shallow): Likewise
5135         (dwarf2_fetch_constant_bytes): Likewise
5136         (decode_locdesc): Add DW_OP_addrx
5137         (skip_form_bytes): Add DW_FORM_addrx
5138
5139 2019-04-22  Ali Tamur  <tamur@google.com>
5140
5141         * MAINTAINERS (Write After Approval): Add self.
5142
5143 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5144
5145         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5146         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5147         (open_symbol_file_object): Likewise.
5148         (svr4_default_sos): Add info parameter.
5149         (svr4_read_so_list): Likewise.
5150         (svr4_current_sos_direct): Adjust functions calls to pass down
5151         info.
5152         (svr4_current_sos_1): Add info parameter.
5153         (svr4_current_sos): Call get_svr4_info, pass info down to
5154         svr4_current_sos_1.
5155         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5156         get_svr4_info.
5157         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5158         get_svr4_info.
5159         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5160         to get_svr4_info.
5161         (probes_table_remove_objfile_probes): Likewise.
5162         (register_solib_event_probe): Add info parameter.
5163         (solist_update_incremental): Pass info parameter down to
5164         svr4_read_so_list.
5165         (disable_probes_interface): Add info parameter.
5166         (svr4_handle_solib_event): Pass current_program_space to
5167         get_svr4_info.  Adjust disable_probes_interface cleanup.
5168         (svr4_create_probe_breakpoints): Add info parameter, pass it
5169         down to register_solib_event_probe.
5170         (svr4_create_solib_event_breakpoints): Add info parameter,
5171         pass it down to svr4_create_probe_breakpoints.
5172         (enable_break): Pass info down to
5173         svr4_create_solib_event_breakpoints.
5174         (svr4_solib_create_inferior_hook): Pass current_program_space to
5175         get_svr4_info.
5176         (svr4_clear_solib): Likewise.
5177
5178 2019-04-22  Pedro Alves  <palves@redhat.com>
5179
5180         * solib-svr4.c (svr4_free_objfile_observer): New.
5181         (probe_and_action::objfile): New field.
5182         (probes_table_htab_remove_objfile_probes)
5183         (probes_table_remove_objfile_probes): New functions.
5184         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5185         in the new probe_and_action.  Don't store the probe in 'lookup'.
5186         (svr4_create_probe_breakpoints): Pass objfile to
5187         register_solib_event_probe.
5188         (_initialize_svr4_solib): Register a free_objfile observer.
5189
5190 2019-04-19  Tom Tromey  <tom@tromey.com>
5191
5192         * common/queue.h: Remove.
5193
5194 2019-04-19  Tom Tromey  <tom@tromey.com>
5195
5196         * event-loop.c: Don't include "common/queue.h".
5197
5198 2019-04-19  Tom Tromey  <tom@tromey.com>
5199
5200         * remote.c (remote_target): Use delete.
5201         * remote-notif.h: Include <list>, not "common/queue.h".
5202         (notif_client_p): Remove typedef.
5203         (remote_notif_state): Add constructor, destructor, initializer.
5204         <notif_queue>: Now a std::list.
5205         (remote_notif_state_xfree): Don't declare.
5206         * remote-notif.c (remote_notif_process, handle_notification)
5207         (remote_notif_state_allocate): Update.
5208         (~remote_notif_state): Rename from remote_notif_state_xfree.
5209
5210 2019-04-19  Tom Tromey  <tom@tromey.com>
5211
5212         * symfile.c (reread_symbols): Update.
5213         * objfiles.c (objfile_register_static_link)
5214         (objfile_lookup_static_link): Update
5215         (~objfile) Don't delete static_links.
5216         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5217
5218 2019-04-19  Tom Tromey  <tom@tromey.com>
5219
5220         * type-stack.h (struct type_stack) <insert>: Constify string.
5221         * type-stack.c (type_stack::insert): Constify string.
5222         * gdbtypes.h (lookup_template_type): Update.
5223         (address_space_name_to_int): Update.
5224         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5225         const.
5226         (lookup_template_type): Make name const.
5227         * c-exp.y: Update rules.
5228         (lex_one_token, classify_name, classify_inner_name)
5229         (c_print_token): Update.
5230         * p-exp.y: Update rules.
5231         (yylex): Update.
5232         * f-exp.y: Update rules.
5233         (yylex): Update.
5234         * d-exp.y: Update rules.
5235         (lex_one_token, classify_name, classify_inner_name): Update.
5236         * parse.c (write_dollar_variable, copy_name): Return std::string.
5237         * parser-defs.h (copy_name): Change return type.
5238         * m2-exp.y: Update rules.
5239         (yylex): Update.
5240         * go-exp.y (lex_one_token): Update.
5241         Update rules.
5242         (classify_unsafe_function, classify_packaged_name)
5243         (classify_name, yylex): Update.
5244
5245 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5246
5247         * configure.ac: add --enable-source-highlight switch.
5248         * configure: Regenerate.
5249         * top.c (print_gdb_version): plumb --enable-source-highlight
5250         status to "show configuration".
5251
5252 2019-04-19  Tom Tromey  <tromey@adacore.com>
5253
5254         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5255         Check ADA_TYPE_P.
5256         (empty_record, ada_template_to_fixed_record_type_1)
5257         (template_to_static_fixed_type)
5258         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5259         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5260         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5261         macros.
5262
5263 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5264
5265         PR symtab/24423:
5266         * source.c (print_source_lines_base): Advance "iter" when a
5267         control character is seen.
5268
5269 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5270
5271         * inferior.h (struct infcall_suspend_state_deleter):
5272         Catch exception in destructor to avoid crash.
5273
5274 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5275
5276         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5277         close to the add_com "shell".
5278
5279 2019-04-18  Tom Tromey  <tromey@adacore.com>
5280
5281         * process-stratum-target.h (class process_stratum_target)
5282         <stratum>: Add "final".
5283
5284 2019-04-17  Tom Tromey  <tromey@adacore.com>
5285
5286         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5287         against nullptr before use.
5288
5289 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5290
5291         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5292
5293 2019-04-17  Jim Wilson  <jimw@sifive.com>
5294             Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5297         code read might fail, assume 4-byte breakpoint in that case.
5298
5299 2019-04-15  Leszek Swirski  <leszeks@google.com>
5300
5301         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5302         rather than a hand-rolled POD check when checking for forced MEMORY
5303         classification.
5304
5305 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5306
5307         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5308         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5309         function.
5310         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5311         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5312         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5313         declaration.
5314
5315 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5316
5317         * aarch64-linux-nat.c
5318         (aarch64_linux_nat_target::thread_architecture): Add override.
5319         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5320         each VQ.
5321
5322 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5323
5324         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5325
5326 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5329         target types of size 96-bits, add some additional comments, and
5330         check that the builtin type we found was the correct size.
5331
5332 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5333
5334         * utils.c (prompt_for_continue): Don't restore the styling at the
5335         end, as applied_style has the wrong value.  This fixes styling in
5336         long lists of file names that are interrupted by the "Continue?"
5337         prompt.
5338
5339 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5342         * c-lang.c (c_language_defn): Likewise.
5343         (cplus_language_defn): Likewise.
5344         (asm_language_defn): Likewise.
5345         (minimal_language_defn): Likewise.
5346         * d-lang.c (d_language_defn): Likewise.
5347         * f-lang.c (f_language_defn): Likewise.
5348         * go-lang.c (go_language_defn): Likewise.
5349         * language.c (unknown_language_defn): Likewise.
5350         (auto_language_defn): Likewise.
5351         * language.h (struct language_defn): Remove la_magic field.
5352         (LANG_MAGIC): Delete.
5353         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5354         * objc-lang.c (objc_language_defn): Likewise.
5355         * opencl-lang.c (opencl_language_defn): Likewise.
5356         * p-lang.c (pascal_language_defn): Likewise.
5357         * rust-lang.c (rust_language_defn): Likewise.
5358
5359 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * riscv-tdep.c (riscv_type_align): New function.
5362         (riscv_type_alignment): Delete.
5363         (riscv_arg_location): Use 'type_align'.
5364         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5365
5366 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5367
5368         * gdbtypes.c (type_align): A struct with no non-static fields also
5369         has alignment of 1.
5370
5371 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5374         component to 0.
5375         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5376         member.
5377         (riscv_struct_info::analyse): New implementation using new
5378         analyse_inner member function.
5379         (riscv_struct_info::field_offset): New member function.
5380         (riscv_struct_info::m_offsets): New member variable.
5381         (riscv_struct_info::analyse_inner): New private member function,
5382         takes the old implementation of riscv_struct_info::analyse but
5383         extended to track field offsets.
5384         (riscv_call_arg_struct): Update the struct folding special cases
5385         to handle cases where empty C++ structs, which are non-zero
5386         length, are found.
5387         (riscv_arg_location): Initialise the length of each location, a
5388         non-zero length now indicates the location is in use.
5389         (riscv_push_dummy_call): Allow for the first location having a
5390         non-zero offset when setting up arguments.
5391         (riscv_return_value): Likewise, but for return values.
5392
5393 2019-04-11  Tom Tromey  <tromey@adacore.com>
5394
5395         * utils.c (internal_vproblem): Make "msg" const.
5396
5397 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5398
5399         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5400         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5401         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5402         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5403
5404 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5405
5406         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5407         function.
5408         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5409         of amd64_collect_native_gregset.
5410         (amd64_linux_nat_target::store_registers): Likewise.
5411
5412 2019-04-10  Tom Tromey  <tom@tromey.com>
5413
5414         * symtab.c (lookup_global_symbol_from_objfile)
5415         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5416         * objfiles.h (class separate_debug_iterator): New.
5417         (class separate_debug_range): New.
5418         (struct objfile) <separate_debug_objfiles>: New method.
5419         (objfile_separate_debug_iterate): Don't declare.
5420         * objfiles.c (separate_debug_iterator::operator++): Rename from
5421         objfile_separate_debug_iterate.
5422         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5423         iterator.
5424         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5425         iterator.
5426
5427 2019-04-10  Tom Tromey  <tom@tromey.com>
5428
5429         * symfile.c (reread_symbols): Remove old comment.
5430         * objfiles.c (free_all_objfiles): Fix a typo.
5431
5432 2019-04-10  Tom Tromey  <tom@tromey.com>
5433
5434         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5435         * minsyms.c (lookup_minimal_symbol): Use foreach.
5436         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5437         (lookup_minimal_symbol_solib_trampoline): Likewise.
5438         * symfile.c (reread_symbols): Use foreach.
5439
5440 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5441             Tom Tromey  <tromey@adacore.com>
5442
5443         PR rust/24414:
5444         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5445         (rust_lex_int_test): Change "value" to be LONGEST.
5446         (rust_lex_tests): Add test for long integer literal.
5447
5448 2019-04-09  Tom Tromey  <tromey@adacore.com>
5449
5450         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5451         to bool.
5452         (extended_remote_target::attach): Update.
5453         (remote_target::remote_notice_new_inferior): Update.
5454         (remote_target::add_current_inferior_and_thread): Update.
5455         * inferior.c (exit_inferior_1): Use "false".
5456         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5457
5458 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5459
5460         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5461         the "start" command.
5462
5463 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5464
5465         * python/py-inferior.c (infpy_thread_from_thread_handle):
5466         Adjust comments to reflect renaming of thread_from_thread_handle
5467         to thread_from_handle.  Adjust keywords.  Fix type error message.
5468         (inferior_object_methods): Add thread_from_handle.  Retain
5469         thread_from_thread_handle, but mark it as deprecated.
5470
5471 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5472
5473         * gdbthread.h (find_thread_by_handle): Revise declaration.
5474         * thread.c (find_thread_by_handle): Likewise.  Adjust
5475         implementation too.
5476         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5477         support for buffer objects as handles.
5478
5479 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5480
5481         * python/py-infthread.c (thpy_thread_handle): New function.
5482         (thread_object_methods): Register thpy_thread_handle.
5483
5484 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5485
5486         * gdbthread.h (thread_to_thread_handle): Declare.
5487         * thread.c (gdbtypes.h): Include.
5488         (thread_to_thread_handle): New function.
5489
5490         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5491         (target_thread_info_to_thread_handle): Declare.
5492         * target.c (target_thread_info_to_thread_handle): New function.
5493         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5494         * target-delegates.c: Regenerate.
5495
5496         * linux-thread-db.c (class thread_db_target): Add method
5497         thread_info_to_thread_handle.
5498         (thread_db_target::thread_info_to_thread_handle): Define.
5499         * remote.c (class remote_target): Add new method
5500         thread_info_to_thread_handle.
5501         (remote_target::thread_info_to_thread_handle): Define.
5502
5503 2019-04-08  Pedro Alves  <palves@redhat.com>
5504
5505         * common/common-exceptions.c (throw_exception): Don't create
5506         named object to throw; throw directly.
5507         (throw_it): Likewise.  Don't initialize gdb_exception::message
5508         here, with new; pass FMT and AP to the ctor instead.
5509         * common/common-exceptions.h: Include <string>.
5510         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5511         const char *, va_list)): New ctor.  Use std::make_shared.
5512         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5513         errors)): Delete.
5514         (gdb_exception_error::gdb_exception_error(enum errors, const char
5515         *, va_list)): New.
5516         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5517         Add assertion.
5518         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5519         errors)): Delete.
5520         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5521         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5522         Add assertion.
5523
5524 2019-04-08  Tom Tromey  <tom@tromey.com>
5525
5526         * valops.c (value_rtti_indirect_type): Replace throw_exception
5527         with throw.
5528         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5529         with throw.
5530         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5531         throw.
5532         * target.c (target_translate_tls_address): Replace throw_exception
5533         with throw.
5534         * stack.c (frame_apply_command_count): Replace throw_exception
5535         with throw.
5536         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5537         throw.
5538         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5539         with throw.
5540         * rs6000-tdep.c (rs6000_frame_cache)
5541         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5542         * remote.c: Replace throw_exception with throw.
5543         * record-full.c (record_full_message, record_full_wait_1)
5544         (record_full_restore): Replace throw_exception with throw.
5545         * record-btrace.c:
5546         (get_thread_current_frame_id, record_btrace_start_replaying)
5547         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5548         (cmd_record_btrace_start): Replace throw_exception with throw.
5549         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5550         throw.
5551         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5552         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5553         * linespec.c:
5554         (find_linespec_symbols): Replace throw_exception with throw.
5555         * infrun.c (displaced_step_prepare, resume): Replace
5556         throw_exception with throw.
5557         * infcmd.c (post_create_inferior): Replace throw_exception with
5558         throw.
5559         * inf-loop.c (inferior_event_handler): Replace throw_exception
5560         with throw.
5561         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5562         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5563         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5564         (get_prev_frame_always, get_frame_pc_if_available)
5565         (get_frame_address_in_block_if_available, get_frame_language):
5566         Replace throw_exception with throw.
5567         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5568         throw_exception with throw.
5569         * eval.c (fetch_subexp_value, evaluate_var_value)
5570         (evaluate_funcall, evaluate_subexp_standard): Replace
5571         throw_exception with throw.
5572         * dwarf2loc.c (call_site_find_chain)
5573         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5574         Replace throw_exception with throw.
5575         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5576         with throw.
5577         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5578         throw.
5579         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5580         * completer.c (complete_line_internal): Replace throw_exception
5581         with throw.
5582         * compile/compile-object-run.c (compile_object_run): Replace
5583         throw_exception with throw.
5584         * cli/cli-script.c (process_next_line): Replace throw_exception
5585         with throw.
5586         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5587         (btrace_enable, btrace_maint_update_pt_packets): Replace
5588         throw_exception with throw.
5589         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5590         throw_exception with throw.
5591         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5592         throw_exception with throw.
5593         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5594         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5595         * aarch64-tdep.c (aarch64_make_prologue_cache)
5596         (aarch64_make_stub_cache): Replace throw_exception with throw.
5597
5598 2019-04-08  Tom Tromey  <tom@tromey.com>
5599
5600         * common/common-exceptions.c (throw_exception): Rename from
5601         throw_exception_cxx.  Remove old copy.  Make argument const.
5602         (throw_it): Create and throw exception objects directly.
5603         * common/common-exceptions.h (throw_exception): Make argument
5604         const.
5605         (struct gdb_exception_error): Add constructor.
5606         (struct gdb_exception_quit): Add constructor.
5607
5608 2019-04-08  Tom Tromey  <tom@tromey.com>
5609
5610         * common/common-exceptions.h (exception_rethrow): Don't declare.
5611         (TRY_SJLJ): Update comment.
5612         (TRY, CATCH, END_CATCH): Remove.
5613         * common/common-exceptions.c (exception_rethrow): Remove.
5614
5615 2019-04-08  Tom Tromey  <tom@tromey.com>
5616
5617         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5618         Remove.
5619         (gdb_exception_error): Rename from
5620         gdb_exception_RETURN_MASK_ERROR.
5621         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5622         (gdb_quit_bad_alloc): Update.
5623         * aarch64-tdep.c: Update.
5624         * ada-lang.c: Update.
5625         * ada-typeprint.c: Update.
5626         * ada-valprint.c: Update.
5627         * amd64-tdep.c: Update.
5628         * arch-utils.c: Update.
5629         * break-catch-throw.c: Update.
5630         * breakpoint.c: Update.
5631         * btrace.c: Update.
5632         * c-varobj.c: Update.
5633         * cli/cli-cmds.c: Update.
5634         * cli/cli-interp.c: Update.
5635         * cli/cli-script.c: Update.
5636         * common/common-exceptions.c: Update.
5637         * common/new-op.c: Update.
5638         * common/selftest.c: Update.
5639         * compile/compile-c-symbols.c: Update.
5640         * compile/compile-cplus-symbols.c: Update.
5641         * compile/compile-object-load.c: Update.
5642         * compile/compile-object-run.c: Update.
5643         * completer.c: Update.
5644         * corelow.c: Update.
5645         * cp-abi.c: Update.
5646         * cp-support.c: Update.
5647         * cp-valprint.c: Update.
5648         * darwin-nat.c: Update.
5649         * disasm-selftests.c: Update.
5650         * dtrace-probe.c: Update.
5651         * dwarf-index-cache.c: Update.
5652         * dwarf-index-write.c: Update.
5653         * dwarf2-frame-tailcall.c: Update.
5654         * dwarf2-frame.c: Update.
5655         * dwarf2loc.c: Update.
5656         * dwarf2read.c: Update.
5657         * eval.c: Update.
5658         * event-loop.c: Update.
5659         * event-top.c: Update.
5660         * exec.c: Update.
5661         * f-valprint.c: Update.
5662         * fbsd-tdep.c: Update.
5663         * frame-unwind.c: Update.
5664         * frame.c: Update.
5665         * gdbtypes.c: Update.
5666         * gnu-v3-abi.c: Update.
5667         * guile/guile-internal.h: Update.
5668         * guile/scm-block.c: Update.
5669         * guile/scm-breakpoint.c: Update.
5670         * guile/scm-cmd.c: Update.
5671         * guile/scm-disasm.c: Update.
5672         * guile/scm-frame.c: Update.
5673         * guile/scm-lazy-string.c: Update.
5674         * guile/scm-math.c: Update.
5675         * guile/scm-param.c: Update.
5676         * guile/scm-ports.c: Update.
5677         * guile/scm-pretty-print.c: Update.
5678         * guile/scm-symbol.c: Update.
5679         * guile/scm-symtab.c: Update.
5680         * guile/scm-type.c: Update.
5681         * guile/scm-value.c: Update.
5682         * i386-linux-tdep.c: Update.
5683         * i386-tdep.c: Update.
5684         * inf-loop.c: Update.
5685         * infcall.c: Update.
5686         * infcmd.c: Update.
5687         * infrun.c: Update.
5688         * jit.c: Update.
5689         * language.c: Update.
5690         * linespec.c: Update.
5691         * linux-fork.c: Update.
5692         * linux-nat.c: Update.
5693         * linux-tdep.c: Update.
5694         * linux-thread-db.c: Update.
5695         * main.c: Update.
5696         * mi/mi-cmd-break.c: Update.
5697         * mi/mi-cmd-stack.c: Update.
5698         * mi/mi-interp.c: Update.
5699         * mi/mi-main.c: Update.
5700         * objc-lang.c: Update.
5701         * p-valprint.c: Update.
5702         * parse.c: Update.
5703         * ppc-linux-tdep.c: Update.
5704         * printcmd.c: Update.
5705         * python/py-arch.c: Update.
5706         * python/py-breakpoint.c: Update.
5707         * python/py-cmd.c: Update.
5708         * python/py-finishbreakpoint.c: Update.
5709         * python/py-frame.c: Update.
5710         * python/py-framefilter.c: Update.
5711         * python/py-gdb-readline.c: Update.
5712         * python/py-inferior.c: Update.
5713         * python/py-infthread.c: Update.
5714         * python/py-lazy-string.c: Update.
5715         * python/py-linetable.c: Update.
5716         * python/py-objfile.c: Update.
5717         * python/py-param.c: Update.
5718         * python/py-prettyprint.c: Update.
5719         * python/py-progspace.c: Update.
5720         * python/py-record-btrace.c: Update.
5721         * python/py-record.c: Update.
5722         * python/py-symbol.c: Update.
5723         * python/py-type.c: Update.
5724         * python/py-unwind.c: Update.
5725         * python/py-utils.c: Update.
5726         * python/py-value.c: Update.
5727         * python/python.c: Update.
5728         * record-btrace.c: Update.
5729         * record-full.c: Update.
5730         * remote-fileio.c: Update.
5731         * remote.c: Update.
5732         * riscv-tdep.c: Update.
5733         * rs6000-aix-tdep.c: Update.
5734         * rs6000-tdep.c: Update.
5735         * rust-exp.y: Update.
5736         * rust-lang.c: Update.
5737         * s390-tdep.c: Update.
5738         * selftest-arch.c: Update.
5739         * solib-dsbt.c: Update.
5740         * solib-frv.c: Update.
5741         * solib-spu.c: Update.
5742         * solib-svr4.c: Update.
5743         * solib.c: Update.
5744         * sparc64-linux-tdep.c: Update.
5745         * stack.c: Update.
5746         * symfile-mem.c: Update.
5747         * symmisc.c: Update.
5748         * target.c: Update.
5749         * thread.c: Update.
5750         * top.c: Update.
5751         * tracefile-tfile.c: Update.
5752         * tui/tui.c: Update.
5753         * typeprint.c: Update.
5754         * unittests/cli-utils-selftests.c: Update.
5755         * unittests/parse-connection-spec-selftests.c: Update.
5756         * valops.c: Update.
5757         * valprint.c: Update.
5758         * value.c: Update.
5759         * varobj.c: Update.
5760         * windows-nat.c: Update.
5761         * x86-linux-nat.c: Update.
5762         * xml-support.c: Update.
5763
5764 2019-04-08  Tom Tromey  <tom@tromey.com>
5765
5766         * xml-support.c: Use C++ exception handling.
5767         * x86-linux-nat.c: Use C++ exception handling.
5768         * windows-nat.c: Use C++ exception handling.
5769         * varobj.c: Use C++ exception handling.
5770         * value.c: Use C++ exception handling.
5771         * valprint.c: Use C++ exception handling.
5772         * valops.c: Use C++ exception handling.
5773         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5774         handling.
5775         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5776         * typeprint.c: Use C++ exception handling.
5777         * tui/tui.c: Use C++ exception handling.
5778         * tracefile-tfile.c: Use C++ exception handling.
5779         * top.c: Use C++ exception handling.
5780         * thread.c: Use C++ exception handling.
5781         * target.c: Use C++ exception handling.
5782         * symmisc.c: Use C++ exception handling.
5783         * symfile-mem.c: Use C++ exception handling.
5784         * stack.c: Use C++ exception handling.
5785         * sparc64-linux-tdep.c: Use C++ exception handling.
5786         * solib.c: Use C++ exception handling.
5787         * solib-svr4.c: Use C++ exception handling.
5788         * solib-spu.c: Use C++ exception handling.
5789         * solib-frv.c: Use C++ exception handling.
5790         * solib-dsbt.c: Use C++ exception handling.
5791         * selftest-arch.c: Use C++ exception handling.
5792         * s390-tdep.c: Use C++ exception handling.
5793         * rust-lang.c: Use C++ exception handling.
5794         * rust-exp.y: Use C++ exception handling.
5795         * rs6000-tdep.c: Use C++ exception handling.
5796         * rs6000-aix-tdep.c: Use C++ exception handling.
5797         * riscv-tdep.c: Use C++ exception handling.
5798         * remote.c: Use C++ exception handling.
5799         * remote-fileio.c: Use C++ exception handling.
5800         * record-full.c: Use C++ exception handling.
5801         * record-btrace.c: Use C++ exception handling.
5802         * python/python.c: Use C++ exception handling.
5803         * python/py-value.c: Use C++ exception handling.
5804         * python/py-utils.c: Use C++ exception handling.
5805         * python/py-unwind.c: Use C++ exception handling.
5806         * python/py-type.c: Use C++ exception handling.
5807         * python/py-symbol.c: Use C++ exception handling.
5808         * python/py-record.c: Use C++ exception handling.
5809         * python/py-record-btrace.c: Use C++ exception handling.
5810         * python/py-progspace.c: Use C++ exception handling.
5811         * python/py-prettyprint.c: Use C++ exception handling.
5812         * python/py-param.c: Use C++ exception handling.
5813         * python/py-objfile.c: Use C++ exception handling.
5814         * python/py-linetable.c: Use C++ exception handling.
5815         * python/py-lazy-string.c: Use C++ exception handling.
5816         * python/py-infthread.c: Use C++ exception handling.
5817         * python/py-inferior.c: Use C++ exception handling.
5818         * python/py-gdb-readline.c: Use C++ exception handling.
5819         * python/py-framefilter.c: Use C++ exception handling.
5820         * python/py-frame.c: Use C++ exception handling.
5821         * python/py-finishbreakpoint.c: Use C++ exception handling.
5822         * python/py-cmd.c: Use C++ exception handling.
5823         * python/py-breakpoint.c: Use C++ exception handling.
5824         * python/py-arch.c: Use C++ exception handling.
5825         * printcmd.c: Use C++ exception handling.
5826         * ppc-linux-tdep.c: Use C++ exception handling.
5827         * parse.c: Use C++ exception handling.
5828         * p-valprint.c: Use C++ exception handling.
5829         * objc-lang.c: Use C++ exception handling.
5830         * mi/mi-main.c: Use C++ exception handling.
5831         * mi/mi-interp.c: Use C++ exception handling.
5832         * mi/mi-cmd-stack.c: Use C++ exception handling.
5833         * mi/mi-cmd-break.c: Use C++ exception handling.
5834         * main.c: Use C++ exception handling.
5835         * linux-thread-db.c: Use C++ exception handling.
5836         * linux-tdep.c: Use C++ exception handling.
5837         * linux-nat.c: Use C++ exception handling.
5838         * linux-fork.c: Use C++ exception handling.
5839         * linespec.c: Use C++ exception handling.
5840         * language.c: Use C++ exception handling.
5841         * jit.c: Use C++ exception handling.
5842         * infrun.c: Use C++ exception handling.
5843         * infcmd.c: Use C++ exception handling.
5844         * infcall.c: Use C++ exception handling.
5845         * inf-loop.c: Use C++ exception handling.
5846         * i386-tdep.c: Use C++ exception handling.
5847         * i386-linux-tdep.c: Use C++ exception handling.
5848         * guile/scm-value.c: Use C++ exception handling.
5849         * guile/scm-type.c: Use C++ exception handling.
5850         * guile/scm-symtab.c: Use C++ exception handling.
5851         * guile/scm-symbol.c: Use C++ exception handling.
5852         * guile/scm-pretty-print.c: Use C++ exception handling.
5853         * guile/scm-ports.c: Use C++ exception handling.
5854         * guile/scm-param.c: Use C++ exception handling.
5855         * guile/scm-math.c: Use C++ exception handling.
5856         * guile/scm-lazy-string.c: Use C++ exception handling.
5857         * guile/scm-frame.c: Use C++ exception handling.
5858         * guile/scm-disasm.c: Use C++ exception handling.
5859         * guile/scm-cmd.c: Use C++ exception handling.
5860         * guile/scm-breakpoint.c: Use C++ exception handling.
5861         * guile/scm-block.c: Use C++ exception handling.
5862         * guile/guile-internal.h: Use C++ exception handling.
5863         * gnu-v3-abi.c: Use C++ exception handling.
5864         * gdbtypes.c: Use C++ exception handling.
5865         * frame.c: Use C++ exception handling.
5866         * frame-unwind.c: Use C++ exception handling.
5867         * fbsd-tdep.c: Use C++ exception handling.
5868         * f-valprint.c: Use C++ exception handling.
5869         * exec.c: Use C++ exception handling.
5870         * event-top.c: Use C++ exception handling.
5871         * event-loop.c: Use C++ exception handling.
5872         * eval.c: Use C++ exception handling.
5873         * dwarf2read.c: Use C++ exception handling.
5874         * dwarf2loc.c: Use C++ exception handling.
5875         * dwarf2-frame.c: Use C++ exception handling.
5876         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5877         * dwarf-index-write.c: Use C++ exception handling.
5878         * dwarf-index-cache.c: Use C++ exception handling.
5879         * dtrace-probe.c: Use C++ exception handling.
5880         * disasm-selftests.c: Use C++ exception handling.
5881         * darwin-nat.c: Use C++ exception handling.
5882         * cp-valprint.c: Use C++ exception handling.
5883         * cp-support.c: Use C++ exception handling.
5884         * cp-abi.c: Use C++ exception handling.
5885         * corelow.c: Use C++ exception handling.
5886         * completer.c: Use C++ exception handling.
5887         * compile/compile-object-run.c: Use C++ exception handling.
5888         * compile/compile-object-load.c: Use C++ exception handling.
5889         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5890         * compile/compile-c-symbols.c: Use C++ exception handling.
5891         * common/selftest.c: Use C++ exception handling.
5892         * common/new-op.c: Use C++ exception handling.
5893         * cli/cli-script.c: Use C++ exception handling.
5894         * cli/cli-interp.c: Use C++ exception handling.
5895         * cli/cli-cmds.c: Use C++ exception handling.
5896         * c-varobj.c: Use C++ exception handling.
5897         * btrace.c: Use C++ exception handling.
5898         * breakpoint.c: Use C++ exception handling.
5899         * break-catch-throw.c: Use C++ exception handling.
5900         * arch-utils.c: Use C++ exception handling.
5901         * amd64-tdep.c: Use C++ exception handling.
5902         * ada-valprint.c: Use C++ exception handling.
5903         * ada-typeprint.c: Use C++ exception handling.
5904         * ada-lang.c: Use C++ exception handling.
5905         * aarch64-tdep.c: Use C++ exception handling.
5906
5907 2019-04-08  Tom Tromey  <tom@tromey.com>
5908
5909         * xml-support.c (gdb_xml_parser::parse): Update.
5910         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5911         * value.c (show_convenience): Update.
5912         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5913         (test_parse_flags_qcs): Update.
5914         * thread.c (thr_try_catch_cmd): Update.
5915         * target.c (target_translate_tls_address): Update.
5916         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5917         (info_frame_command_core, frame_apply_command_count): Update.
5918         * rust-exp.y (rust_lex_exception_test): Update.
5919         * riscv-tdep.c (riscv_print_one_register_info): Update.
5920         * remote.c (remote_target::enable_btrace): Update.
5921         * record-btrace.c (record_btrace_enable_warn): Update.
5922         * python/py-utils.c (gdbpy_convert_exception): Update.
5923         * printcmd.c (do_one_display, print_variable_and_value): Update.
5924         * mi/mi-main.c (mi_print_exception): Update.
5925         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5926         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5927         * linux-nat.c (linux_nat_target::attach): Update.
5928         * linux-fork.c (class scoped_switch_fork_info): Update.
5929         * infrun.c (displaced_step_prepare): Update.
5930         * infcall.c (call_function_by_hand_dummy): Update.
5931         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5932         * gnu-v3-abi.c (print_one_vtable): Update.
5933         * frame.c (get_prev_frame_always): Update.
5934         * f-valprint.c (info_common_command_for_block): Update.
5935         * exec.c (try_open_exec_file): Update.
5936         * exceptions.c (print_exception, exception_print)
5937         (exception_fprintf, exception_print_same): Update.
5938         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5939         * dwarf-index-cache.c (index_cache::store)
5940         (index_cache::lookup_gdb_index): Update.
5941         * darwin-nat.c (maybe_cache_shell): Update.
5942         * cp-valprint.c (cp_print_value_fields): Update.
5943         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5944         (gcc_cplus_symbol_address): Update.
5945         * compile/compile-c-symbols.c (gcc_convert_symbol)
5946         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5947         * common/selftest.c: Update.
5948         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5949         a std::string.
5950         (exception_try_scope_entry, exception_try_scope_exit): Don't
5951         declare.
5952         (struct exception_try_scope): Remove.
5953         (TRY): Don't use exception_try_scope.
5954         (struct gdb_exception): Add constructor, operator=.
5955         <what>: New method.
5956         (struct gdb_exception_RETURN_MASK_ALL)
5957         (struct gdb_exception_RETURN_MASK_ERROR)
5958         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5959         (struct gdb_quit_bad_alloc): Update.
5960         * common/common-exceptions.c (exception_none): Change
5961         initializer.
5962         (struct catcher) <state, exception>: Initialize inline.
5963         <prev>: Remove member.
5964         (current_catcher): Remove.
5965         (catchers): New global.
5966         (exceptions_state_mc_init): Simplify.
5967         (catcher_pop): Remove.
5968         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5969         (try_scope_depth, exception_try_scope_entry)
5970         (exception_try_scope_exit): Remove.
5971         (throw_exception_sjlj): Update.
5972         (exception_messages, exception_messages_size): Remove.
5973         (throw_it): Simplify.
5974         (gdb_exception_sliced_copy): Remove.
5975         (throw_exception_cxx): Update.
5976         * cli/cli-script.c (script_from_file): Update.
5977         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5978         Update.
5979         * ada-valprint.c (ada_val_print): Update.
5980         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5981         (create_excep_cond_exprs): Update.
5982
5983 2019-04-08  Tom Tromey  <tom@tromey.com>
5984
5985         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5986         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5987         (TRY, CATCH, END_CATCH): Remove some definitions.
5988         * common/common-exceptions.c: Don't use GDB_XCPT.
5989         (catcher_list_size): Remove.
5990         (throw_exception, throw_it): Simplify.
5991
5992 2019-04-05  Tom Tromey  <tom@tromey.com>
5993
5994         Revert the header-sorting patch.
5995         * ft32-tdep.c: Revert.
5996         * frv-tdep.c: Revert.
5997         * frv-linux-tdep.c: Revert.
5998         * frame.c: Revert.
5999         * frame-unwind.c: Revert.
6000         * frame-base.c: Revert.
6001         * fork-child.c: Revert.
6002         * findvar.c: Revert.
6003         * findcmd.c: Revert.
6004         * filesystem.c: Revert.
6005         * filename-seen-cache.h: Revert.
6006         * filename-seen-cache.c: Revert.
6007         * fbsd-tdep.c: Revert.
6008         * fbsd-nat.h: Revert.
6009         * fbsd-nat.c: Revert.
6010         * f-valprint.c: Revert.
6011         * f-typeprint.c: Revert.
6012         * f-lang.c: Revert.
6013         * extension.h: Revert.
6014         * extension.c: Revert.
6015         * extension-priv.h: Revert.
6016         * expprint.c: Revert.
6017         * exec.h: Revert.
6018         * exec.c: Revert.
6019         * exceptions.c: Revert.
6020         * event-top.c: Revert.
6021         * event-loop.c: Revert.
6022         * eval.c: Revert.
6023         * elfread.c: Revert.
6024         * dwarf2read.h: Revert.
6025         * dwarf2read.c: Revert.
6026         * dwarf2loc.c: Revert.
6027         * dwarf2expr.h: Revert.
6028         * dwarf2expr.c: Revert.
6029         * dwarf2-frame.c: Revert.
6030         * dwarf2-frame-tailcall.c: Revert.
6031         * dwarf-index-write.h: Revert.
6032         * dwarf-index-write.c: Revert.
6033         * dwarf-index-common.c: Revert.
6034         * dwarf-index-cache.h: Revert.
6035         * dwarf-index-cache.c: Revert.
6036         * dummy-frame.c: Revert.
6037         * dtrace-probe.c: Revert.
6038         * disasm.h: Revert.
6039         * disasm.c: Revert.
6040         * disasm-selftests.c: Revert.
6041         * dictionary.c: Revert.
6042         * dicos-tdep.c: Revert.
6043         * demangle.c: Revert.
6044         * dcache.h: Revert.
6045         * dcache.c: Revert.
6046         * darwin-nat.h: Revert.
6047         * darwin-nat.c: Revert.
6048         * darwin-nat-info.c: Revert.
6049         * d-valprint.c: Revert.
6050         * d-namespace.c: Revert.
6051         * d-lang.c: Revert.
6052         * ctf.c: Revert.
6053         * csky-tdep.c: Revert.
6054         * csky-linux-tdep.c: Revert.
6055         * cris-tdep.c: Revert.
6056         * cris-linux-tdep.c: Revert.
6057         * cp-valprint.c: Revert.
6058         * cp-support.c: Revert.
6059         * cp-namespace.c: Revert.
6060         * cp-abi.c: Revert.
6061         * corelow.c: Revert.
6062         * corefile.c: Revert.
6063         * continuations.c: Revert.
6064         * completer.h: Revert.
6065         * completer.c: Revert.
6066         * complaints.c: Revert.
6067         * coffread.c: Revert.
6068         * coff-pe-read.c: Revert.
6069         * cli-out.h: Revert.
6070         * cli-out.c: Revert.
6071         * charset.c: Revert.
6072         * c-varobj.c: Revert.
6073         * c-valprint.c: Revert.
6074         * c-typeprint.c: Revert.
6075         * c-lang.c: Revert.
6076         * buildsym.c: Revert.
6077         * buildsym-legacy.c: Revert.
6078         * build-id.h: Revert.
6079         * build-id.c: Revert.
6080         * btrace.c: Revert.
6081         * bsd-uthread.c: Revert.
6082         * breakpoint.h: Revert.
6083         * breakpoint.c: Revert.
6084         * break-catch-throw.c: Revert.
6085         * break-catch-syscall.c: Revert.
6086         * break-catch-sig.c: Revert.
6087         * blockframe.c: Revert.
6088         * block.c: Revert.
6089         * bfin-tdep.c: Revert.
6090         * bfin-linux-tdep.c: Revert.
6091         * bfd-target.c: Revert.
6092         * bcache.c: Revert.
6093         * ax-general.c: Revert.
6094         * ax-gdb.h: Revert.
6095         * ax-gdb.c: Revert.
6096         * avr-tdep.c: Revert.
6097         * auxv.c: Revert.
6098         * auto-load.c: Revert.
6099         * arm-wince-tdep.c: Revert.
6100         * arm-tdep.c: Revert.
6101         * arm-symbian-tdep.c: Revert.
6102         * arm-pikeos-tdep.c: Revert.
6103         * arm-obsd-tdep.c: Revert.
6104         * arm-nbsd-tdep.c: Revert.
6105         * arm-nbsd-nat.c: Revert.
6106         * arm-linux-tdep.c: Revert.
6107         * arm-linux-nat.c: Revert.
6108         * arm-fbsd-tdep.c: Revert.
6109         * arm-fbsd-nat.c: Revert.
6110         * arm-bsd-tdep.c: Revert.
6111         * arch-utils.c: Revert.
6112         * arc-tdep.c: Revert.
6113         * arc-newlib-tdep.c: Revert.
6114         * annotate.h: Revert.
6115         * annotate.c: Revert.
6116         * amd64-windows-tdep.c: Revert.
6117         * amd64-windows-nat.c: Revert.
6118         * amd64-tdep.c: Revert.
6119         * amd64-sol2-tdep.c: Revert.
6120         * amd64-obsd-tdep.c: Revert.
6121         * amd64-obsd-nat.c: Revert.
6122         * amd64-nbsd-tdep.c: Revert.
6123         * amd64-nbsd-nat.c: Revert.
6124         * amd64-nat.c: Revert.
6125         * amd64-linux-tdep.c: Revert.
6126         * amd64-linux-nat.c: Revert.
6127         * amd64-fbsd-tdep.c: Revert.
6128         * amd64-fbsd-nat.c: Revert.
6129         * amd64-dicos-tdep.c: Revert.
6130         * amd64-darwin-tdep.c: Revert.
6131         * amd64-bsd-nat.c: Revert.
6132         * alpha-tdep.c: Revert.
6133         * alpha-obsd-tdep.c: Revert.
6134         * alpha-nbsd-tdep.c: Revert.
6135         * alpha-mdebug-tdep.c: Revert.
6136         * alpha-linux-tdep.c: Revert.
6137         * alpha-linux-nat.c: Revert.
6138         * alpha-bsd-tdep.c: Revert.
6139         * alpha-bsd-nat.c: Revert.
6140         * aix-thread.c: Revert.
6141         * agent.c: Revert.
6142         * addrmap.c: Revert.
6143         * ada-varobj.c: Revert.
6144         * ada-valprint.c: Revert.
6145         * ada-typeprint.c: Revert.
6146         * ada-tasks.c: Revert.
6147         * ada-lang.c: Revert.
6148         * aarch64-tdep.c: Revert.
6149         * aarch64-ravenscar-thread.c: Revert.
6150         * aarch64-newlib-tdep.c: Revert.
6151         * aarch64-linux-tdep.c: Revert.
6152         * aarch64-linux-nat.c: Revert.
6153         * aarch64-fbsd-tdep.c: Revert.
6154         * aarch64-fbsd-nat.c: Revert.
6155         * aarch32-linux-nat.c: Revert.
6156
6157 2019-04-05  Tom Tromey  <tom@tromey.com>
6158
6159         * ft32-tdep.c: Sort headers.
6160         * frv-tdep.c: Sort headers.
6161         * frv-linux-tdep.c: Sort headers.
6162         * frame.c: Sort headers.
6163         * frame-unwind.c: Sort headers.
6164         * frame-base.c: Sort headers.
6165         * fork-child.c: Sort headers.
6166         * findvar.c: Sort headers.
6167         * findcmd.c: Sort headers.
6168         * filesystem.c: Sort headers.
6169         * filename-seen-cache.h: Sort headers.
6170         * filename-seen-cache.c: Sort headers.
6171         * fbsd-tdep.c: Sort headers.
6172         * fbsd-nat.h: Sort headers.
6173         * fbsd-nat.c: Sort headers.
6174         * f-valprint.c: Sort headers.
6175         * f-typeprint.c: Sort headers.
6176         * f-lang.c: Sort headers.
6177         * extension.h: Sort headers.
6178         * extension.c: Sort headers.
6179         * extension-priv.h: Sort headers.
6180         * expprint.c: Sort headers.
6181         * exec.h: Sort headers.
6182         * exec.c: Sort headers.
6183         * exceptions.c: Sort headers.
6184         * event-top.c: Sort headers.
6185         * event-loop.c: Sort headers.
6186         * eval.c: Sort headers.
6187         * elfread.c: Sort headers.
6188         * dwarf2read.h: Sort headers.
6189         * dwarf2read.c: Sort headers.
6190         * dwarf2loc.c: Sort headers.
6191         * dwarf2expr.h: Sort headers.
6192         * dwarf2expr.c: Sort headers.
6193         * dwarf2-frame.c: Sort headers.
6194         * dwarf2-frame-tailcall.c: Sort headers.
6195         * dwarf-index-write.h: Sort headers.
6196         * dwarf-index-write.c: Sort headers.
6197         * dwarf-index-common.c: Sort headers.
6198         * dwarf-index-cache.h: Sort headers.
6199         * dwarf-index-cache.c: Sort headers.
6200         * dummy-frame.c: Sort headers.
6201         * dtrace-probe.c: Sort headers.
6202         * disasm.h: Sort headers.
6203         * disasm.c: Sort headers.
6204         * disasm-selftests.c: Sort headers.
6205         * dictionary.c: Sort headers.
6206         * dicos-tdep.c: Sort headers.
6207         * demangle.c: Sort headers.
6208         * dcache.h: Sort headers.
6209         * dcache.c: Sort headers.
6210         * darwin-nat.h: Sort headers.
6211         * darwin-nat.c: Sort headers.
6212         * darwin-nat-info.c: Sort headers.
6213         * d-valprint.c: Sort headers.
6214         * d-namespace.c: Sort headers.
6215         * d-lang.c: Sort headers.
6216         * ctf.c: Sort headers.
6217         * csky-tdep.c: Sort headers.
6218         * csky-linux-tdep.c: Sort headers.
6219         * cris-tdep.c: Sort headers.
6220         * cris-linux-tdep.c: Sort headers.
6221         * cp-valprint.c: Sort headers.
6222         * cp-support.c: Sort headers.
6223         * cp-namespace.c: Sort headers.
6224         * cp-abi.c: Sort headers.
6225         * corelow.c: Sort headers.
6226         * corefile.c: Sort headers.
6227         * continuations.c: Sort headers.
6228         * completer.h: Sort headers.
6229         * completer.c: Sort headers.
6230         * complaints.c: Sort headers.
6231         * coffread.c: Sort headers.
6232         * coff-pe-read.c: Sort headers.
6233         * cli-out.h: Sort headers.
6234         * cli-out.c: Sort headers.
6235         * charset.c: Sort headers.
6236         * c-varobj.c: Sort headers.
6237         * c-valprint.c: Sort headers.
6238         * c-typeprint.c: Sort headers.
6239         * c-lang.c: Sort headers.
6240         * buildsym.c: Sort headers.
6241         * buildsym-legacy.c: Sort headers.
6242         * build-id.h: Sort headers.
6243         * build-id.c: Sort headers.
6244         * btrace.c: Sort headers.
6245         * bsd-uthread.c: Sort headers.
6246         * breakpoint.h: Sort headers.
6247         * breakpoint.c: Sort headers.
6248         * break-catch-throw.c: Sort headers.
6249         * break-catch-syscall.c: Sort headers.
6250         * break-catch-sig.c: Sort headers.
6251         * blockframe.c: Sort headers.
6252         * block.c: Sort headers.
6253         * bfin-tdep.c: Sort headers.
6254         * bfin-linux-tdep.c: Sort headers.
6255         * bfd-target.c: Sort headers.
6256         * bcache.c: Sort headers.
6257         * ax-general.c: Sort headers.
6258         * ax-gdb.h: Sort headers.
6259         * ax-gdb.c: Sort headers.
6260         * avr-tdep.c: Sort headers.
6261         * auxv.c: Sort headers.
6262         * auto-load.c: Sort headers.
6263         * arm-wince-tdep.c: Sort headers.
6264         * arm-tdep.c: Sort headers.
6265         * arm-symbian-tdep.c: Sort headers.
6266         * arm-pikeos-tdep.c: Sort headers.
6267         * arm-obsd-tdep.c: Sort headers.
6268         * arm-nbsd-tdep.c: Sort headers.
6269         * arm-nbsd-nat.c: Sort headers.
6270         * arm-linux-tdep.c: Sort headers.
6271         * arm-linux-nat.c: Sort headers.
6272         * arm-fbsd-tdep.c: Sort headers.
6273         * arm-fbsd-nat.c: Sort headers.
6274         * arm-bsd-tdep.c: Sort headers.
6275         * arch-utils.c: Sort headers.
6276         * arc-tdep.c: Sort headers.
6277         * arc-newlib-tdep.c: Sort headers.
6278         * annotate.h: Sort headers.
6279         * annotate.c: Sort headers.
6280         * amd64-windows-tdep.c: Sort headers.
6281         * amd64-windows-nat.c: Sort headers.
6282         * amd64-tdep.c: Sort headers.
6283         * amd64-sol2-tdep.c: Sort headers.
6284         * amd64-obsd-tdep.c: Sort headers.
6285         * amd64-obsd-nat.c: Sort headers.
6286         * amd64-nbsd-tdep.c: Sort headers.
6287         * amd64-nbsd-nat.c: Sort headers.
6288         * amd64-nat.c: Sort headers.
6289         * amd64-linux-tdep.c: Sort headers.
6290         * amd64-linux-nat.c: Sort headers.
6291         * amd64-fbsd-tdep.c: Sort headers.
6292         * amd64-fbsd-nat.c: Sort headers.
6293         * amd64-dicos-tdep.c: Sort headers.
6294         * amd64-darwin-tdep.c: Sort headers.
6295         * amd64-bsd-nat.c: Sort headers.
6296         * alpha-tdep.c: Sort headers.
6297         * alpha-obsd-tdep.c: Sort headers.
6298         * alpha-nbsd-tdep.c: Sort headers.
6299         * alpha-mdebug-tdep.c: Sort headers.
6300         * alpha-linux-tdep.c: Sort headers.
6301         * alpha-linux-nat.c: Sort headers.
6302         * alpha-bsd-tdep.c: Sort headers.
6303         * alpha-bsd-nat.c: Sort headers.
6304         * aix-thread.c: Sort headers.
6305         * agent.c: Sort headers.
6306         * addrmap.c: Sort headers.
6307         * ada-varobj.c: Sort headers.
6308         * ada-valprint.c: Sort headers.
6309         * ada-typeprint.c: Sort headers.
6310         * ada-tasks.c: Sort headers.
6311         * ada-lang.c: Sort headers.
6312         * aarch64-tdep.c: Sort headers.
6313         * aarch64-ravenscar-thread.c: Sort headers.
6314         * aarch64-newlib-tdep.c: Sort headers.
6315         * aarch64-linux-tdep.c: Sort headers.
6316         * aarch64-linux-nat.c: Sort headers.
6317         * aarch64-fbsd-tdep.c: Sort headers.
6318         * aarch64-fbsd-nat.c: Sort headers.
6319         * aarch32-linux-nat.c: Sort headers.
6320
6321 2019-04-04  Tom Tromey  <tom@tromey.com>
6322
6323         * varobj.c (varobj_create): Update.
6324         * rust-exp.y (struct rust_parser) <update_innermost_block,
6325         lookup_symbol>: New methods.
6326         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6327         Rename.
6328         (rust_parser::rust_lookup_type)
6329         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6330         * printcmd.c (display_command, do_one_display): Update.
6331         * parser-defs.h (struct parser_state) <parser_state>: Add
6332         "tracker" parameter.
6333         (block_tracker): New member.
6334         (class innermost_block_tracker) <innermost_block_tracker>: Add
6335         "types" parameter.
6336         <reset>: Remove method.
6337         (innermost_block): Don't declare.
6338         (null_post_parser): Update.
6339         * parse.c (innermost_block): Remove global.
6340         (write_dollar_variable): Update.
6341         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6342         Remove "tracker_types" parameter.
6343         (parse_expression): Add "tracker" parameter.
6344         (parse_expression_for_completion): Update.
6345         (null_post_parser): Add "tracker" parameter.
6346         * p-exp.y: Update rules.
6347         * m2-exp.y: Update rules.
6348         * language.h (struct language_defn) <la_post_parser>: Add
6349         "tracker" parameter.
6350         * go-exp.y: Update rules.
6351         * f-exp.y: Update rules.
6352         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6353         parameter.
6354         * d-exp.y: Update rules.
6355         * c-exp.y: Update rules.
6356         * breakpoint.c (set_breakpoint_condition): Create an
6357         innermost_block_tracker.
6358         (watch_command_1): Likewise.
6359         * ada-lang.c (resolve): Add "tracker" parameter.
6360         (resolve_subexp): Likewise.
6361         * ada-exp.y (write_var_from_sym): Update.
6362
6363 2019-04-04  Tom Tromey  <tom@tromey.com>
6364
6365         * type-stack.h: New file.
6366         * type-stack.c: New file.
6367         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6368         type-stack.h.
6369         (insert_into_type_stack, insert_type, push_type, push_type_int)
6370         (insert_type_address_space, pop_type, pop_type_int)
6371         (pop_typelist, pop_type_stack, append_type_stack)
6372         (push_type_stack, get_type_stack, push_typelist)
6373         (follow_type_instance_flags, follow_types): Don't declare.
6374         * parse.c (type_stack): Remove global.
6375         (parse_exp_in_context): Update.
6376         (insert_into_type_stack, insert_type, push_type, push_type_int)
6377         (insert_type_address_space, pop_type, pop_type_int)
6378         (pop_typelist, pop_type_stack, append_type_stack)
6379         (push_type_stack, get_type_stack, push_typelist)
6380         (follow_type_instance_flags, follow_types): Remove (moved to
6381         type-stack.c).
6382         * f-exp.y (type_stack): New global.
6383         Update rules.
6384         (push_kind_type, f_parse): Update.
6385         * d-exp.y (type_stack): New global.
6386         Update rules.
6387         (d_parse): Update.
6388         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6389         Update rules.
6390         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6391         (HFILES_NO_SRCDIR): Add type-stack.h.
6392
6393 2019-04-04  Tom Tromey  <tom@tromey.com>
6394
6395         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6396         (rust_parser::convert_ast_to_expression, rust_parse)
6397         (rust_lex_test_completion, rust_lex_tests): Update.
6398         * parser-defs.h (struct expr_completion_state): New.
6399         (struct parser_state) <parser_state>: Add completion parameter.
6400         <mark_struct_expression, mark_completion_tag>: New methods.
6401         <parse_completion, m_completion_state>: New members.
6402         (prefixify_expression, null_post_parser): Update.
6403         (mark_struct_expression, mark_completion_tag): Don't declare.
6404         * parse.c (parse_completion, expout_last_struct)
6405         (expout_tag_completion_type, expout_completion_name): Remove
6406         globals.
6407         (parser_state::mark_struct_expression)
6408         (parser_state::mark_completion_tag): Now methods.
6409         (prefixify_expression): Add last_struct parameter.
6410         (prefixify_subexp): Likewise.
6411         (parse_exp_1): Update.
6412         (parse_exp_in_context): Add cstate parameter.  Update.
6413         (parse_expression_for_completion): Create an
6414         expr_completion_state.
6415         (null_post_parser): Add "completion" parameter.
6416         * p-exp.y: Update rules.
6417         (yylex): Update.
6418         * language.h (struct language_defn) <la_post_parser>: Add
6419         "completing" parameter.
6420         * go-exp.y: Update rules.
6421         (lex_one_token): Update.
6422         * expression.h (parse_completion): Don't declare.
6423         * d-exp.y: Update rules.
6424         (lex_one_token): Update rules.
6425         * c-exp.y: Update rules.
6426         (lex_one_token): Update.
6427         * ada-lang.c (resolve): Add "parse_completion" parameter.
6428         (resolve_subexp): Likewise.
6429         (ada_resolve_function): Likewise.
6430
6431 2019-04-04  Tom Tromey  <tom@tromey.com>
6432
6433         * parser-defs.h (struct parser_state) <start_arglist,
6434         end_arglist>: New methods.
6435         <arglist_len, m_funcall_chain>: New members.
6436         (arglist_len, start_arglist, end_arglist): Don't declare.
6437         * parse.c (arglist_len, funcall_chain): Remove global.
6438         (start_arglist, end_arglist): Remove functions.
6439         (parse_exp_in_context): Update.
6440         * p-exp.y: Update rules.
6441         * m2-exp.y: Update rules.
6442         * go-exp.y: Update rules.
6443         * f-exp.y: Update rules.
6444         * d-exp.y: Update rules.
6445         * c-exp.y: Update rules.
6446
6447 2019-04-04  Tom Tromey  <tom@tromey.com>
6448
6449         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6450         lex_operator, push_back>: New methods.
6451         Update all rules.
6452         (rust_parser::lex_hex, lex_escape): Rename and update.
6453         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6454         (rust_parser::lex_operator): Rename and update.
6455         (rust_parser::lex_number, rustyylex, rustyyerror)
6456         (rust_lex_test_init, rust_lex_test_sequence)
6457         (rust_lex_test_push_back, rust_lex_tests): Update.
6458         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6459         parameter.
6460         <lexptr, prev_lexptr>: New members.
6461         (lexptr, prev_lexptr): Don't declare.
6462         * parse.c (lexptr, prev_lexptr): Remove globals.
6463         (parse_exp_in_context): Update.
6464         * p-exp.y (yylex, yyerror): Update.
6465         * m2-exp.y (parse_number, yylex, yyerror): Update.
6466         * go-exp.y (lex_one_token, yyerror): Update.
6467         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6468         * d-exp.y (lex_one_token, yyerror): Update.
6469         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6470         (lex_one_token, yyerror): Update.
6471         * ada-lex.l (YY_INPUT): Update.
6472         (rewind_to_char): Update.
6473         * ada-exp.y (yyerror): Update.
6474
6475 2019-04-04  Tom Tromey  <tom@tromey.com>
6476
6477         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6478         * parser-defs.h (struct parser_state) <parser_state>: Add new
6479         parameter.
6480         <comma_terminates>: New member.
6481         (comma_terminates): Don't declare global.
6482         * parse.c (comma_terminates): Remove global.
6483         (parse_exp_in_context): Update.
6484         * p-exp.y (yylex): Update.
6485         * m2-exp.y (yylex): Update.
6486         * go-exp.y (lex_one_token): Update.
6487         * f-exp.y (yylex): Update.
6488         * d-exp.y (lex_one_token): Update.
6489         * c-exp.y (lex_one_token): Update.
6490         * ada-lex.l: Update.
6491
6492 2019-04-04  Tom Tromey  <tom@tromey.com>
6493
6494         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6495         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6496         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6497         * parser-defs.h (paren_depth): Don't declare.
6498         * parse.c (paren_depth): Remove global.
6499         (parse_exp_in_context): Update.
6500         * p-exp.y (paren_depth): New global.
6501         (pascal_parse): Initialize it.
6502         * m2-exp.y (paren_depth): New global.
6503         (m2_parse): Initialize it.
6504         * go-exp.y (paren_depth): New global.
6505         (go_parse): Initialize it.
6506         * f-exp.y (paren_depth): New global.
6507         (f_parse): Initialize it.
6508         * d-exp.y (paren_depth): New global.
6509         (d_parse): Initialize it.
6510         * c-exp.y (paren_depth): New global.
6511         (c_parse): Initialize it.
6512         * ada-lex.l (paren_depth): New global.
6513         (lexer_init): Initialize it.
6514
6515 2019-04-04  Tom Tromey  <tom@tromey.com>
6516
6517         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6518         (rust_parser::convert_ast_to_type)
6519         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6520         * parser-defs.h (struct parser_state) <parser_state>: Add
6521         parameters.  Initialize new members.
6522         <expression_context_block, expression_context_pc>: New members.
6523         * parse.c (expression_context_block, expression_context_pc):
6524         Remove globals.
6525         (parse_exp_in_context): Update.
6526         * p-exp.y: Update all rules.
6527         (yylex): Update.
6528         * m2-exp.y: Update all rules.
6529         (yylex): Update.
6530         * go-exp.y (yylex): Update.
6531         * f-exp.y (yylex): Update.
6532         * d-exp.y: Update all rules.
6533         (yylex): Update.
6534         * c-exp.y: Update all rules.
6535         (lex_one_token, classify_name, yylex, c_parse): Update.
6536         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6537
6538 2019-04-04  Tom Tromey  <tom@tromey.com>
6539
6540         * gdbarch.h, gdbarch.c: Rebuild.
6541         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6542         * stap-probe.h:
6543         (struct stap_parse_info): Replace "parser_state" with
6544         "expr_builder".
6545         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6546         (parser_state): New class.
6547         * parse.c (expr_builder): Rename.
6548         (expr_builder::release): Rename.
6549         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6550         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6551         (write_exp_elt_longcst, write_exp_elt_floatcst)
6552         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6553         (write_exp_string_vector, write_exp_bitstring)
6554         (write_exp_msymbol, mark_struct_expression)
6555         (write_dollar_variable)
6556         (insert_type_address_space, increase_expout_size): Replace
6557         "parser_state" with "expr_builder".
6558         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6559         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6560         "parser_state" with "expr_builder".
6561
6562 2019-04-04  Tom Tromey  <tom@tromey.com>
6563
6564         * rust-exp.y: Replace "parse_language" with method call.
6565         * p-exp.y:
6566         (yylex): Replace "parse_language" with method call.
6567         * m2-exp.y:
6568         (yylex): Replace "parse_language" with method call.
6569         * go-exp.y (classify_name): Replace "parse_language" with method
6570         call.
6571         * f-exp.y (yylex): Replace "parse_language" with method call.
6572         * d-exp.y (lex_one_token): Replace "parse_language" with method
6573         call.
6574         * c-exp.y:
6575         (lex_one_token, classify_name, yylex): Replace "parse_language"
6576         with method call.
6577         * ada-exp.y (find_primitive_type, type_char)
6578         (type_system_address): Replace "parse_language" with method call.
6579
6580 2019-04-04  Tom Tromey  <tom@tromey.com>
6581
6582         * rust-exp.y: Replace "parse_gdbarch" with method call.
6583         * parse.c (write_dollar_variable, insert_type_address_space):
6584         Replace "parse_gdbarch" with method call.
6585         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6586         call.
6587         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6588         call.
6589         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6590         "parse_gdbarch" with method call.
6591         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6592         with method call.
6593         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6594         "parse_gdbarch" with method call.
6595         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6596         "parse_gdbarch" with method call.
6597         * c-exp.y (parse_type, parse_number, classify_name): Replace
6598         "parse_gdbarch" with method call.
6599         * ada-lex.l: Replace "parse_gdbarch" with method call.
6600         * ada-exp.y (parse_type, find_primitive_type, type_char)
6601         (type_system_address): Replace "parse_gdbarch" with method call.
6602
6603 2019-04-04  Tom Tromey  <tom@tromey.com>
6604
6605         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6606         * stap-probe.c (stap_parse_argument): Update.
6607         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6608         initial_size parameter.
6609         * rust-exp.y (rust_lex_tests): Update.
6610         * parse.c (parser_state): Update.
6611         (parse_exp_in_context): Update.
6612         * parser-defs.h (struct parser_state) <parser_state>: Remove
6613         "initial_size" parameter.
6614
6615 2019-04-04  Tom Tromey  <tom@tromey.com>
6616
6617         * parser-defs.h (increase_expout_size): Don't declare.
6618         * parse.c (increase_expout_size): Now static.
6619
6620 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6621
6622         * gnu-nat.c (gnu_nat_target::wait): Fix
6623         target_waitstatus_to_string call.
6624
6625 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * eval.c (evaluate_subexp_standard): Handle internal functions
6628         during Fortran function call handling.
6629
6630 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6631
6632         * NEWS: Mention new internal functions.
6633         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6634         (read_base_type): Use dwarf2_init_complex_target_type.
6635         * value.c (creal_internal_fn): New function.
6636         (cimag_internal_fn): New function.
6637         (_initialize_values): Register new internal functions.
6638
6639 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6640
6641         * infrun.c (stop_all_threads): If debug_infrun, always
6642         trace the wait status after wait_one, using
6643         target_waitstatus_to_string and target_pid_to_str.
6644         (handle_inferior_event): Replace various trace of
6645         wait status kind by a single trace.
6646         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6647         wait status kind image by target_waitstatus_to_string.
6648         * target/waitstatus.c (target_waitstatus_to_string): Fix
6649         obsolete comment.
6650
6651 2019-04-01  Tom Tromey  <tromey@adacore.com>
6652
6653         PR symtab/23331:
6654         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6655
6656 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6657             Pedro Alves  <palves@redhat.com>
6658
6659         * top.c (quit_force): Call 'finalize_values'.
6660         * value.c (finalize_values): New function.
6661         * value.h (finalize_values): Declare.
6662
6663 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6664
6665         * NEWS: Announce $_gdb_major and $_gdb_minor.
6666
6667         * top.c (init_gdb_version_vars): New function.
6668         (gdb_init): Call init_gdb_version_vars.
6669
6670 2019-03-29  Tom Tromey  <tromey@adacore.com>
6671
6672         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6673         help text.  Remove dead code.
6674
6675 2019-03-29  Keith Seitz  <keiths@redhat.com>
6676
6677         From Siddhesh Poyarekar:
6678         * f-lang.h (f77_get_upperbound): Return LONGEST.
6679         (f77_get_lowerbound): Likewise.
6680         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6681         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6682         print them.
6683         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6684         plongest to format print it.
6685         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6686         (f77_get_upperbound): Likewise.
6687         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6688         LOWER_BOUND to LONGEST.
6689         (f77_create_arrayprint_offset_tbl): Likewise.
6690
6691 2019-03-29  Keith Seitz  <keiths@redhat.com>
6692
6693         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6694         %s/pulongest for TYPE_LENGTH instead of %d in format
6695         strings.
6696         * ada-typerint.c (ada_print_type): Likewise.
6697         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6698         * compile/compile-c-support.c (generate_register_struct): Likewise.
6699         * gdbtypes.c (recursive_dump_type): Likewise.
6700         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6701         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6702         instead of %d in format strings.
6703         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6704         to std::min to ULONGEST.
6705         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6706         instead of %d in format strings.
6707         * tracepoint.c (info_scope_command): Likewise.
6708         * typeprint.c (print_offset_data::update)
6709         (print_offset_data::finish): Likewise.
6710         * xtensa-tdep.c (xtensa_store_return_value)
6711         (xtensa_push_dummy_call): Likewise.
6712
6713 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6714
6715         * windows-nat.c (display_selector): Fixed format specifications
6716         for 64-bit Cygwin.
6717
6718 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6719
6720         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6721
6722 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6723
6724         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6725         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6726         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6727         (nios2_linux_init_abi): Install it.
6728
6729 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6730
6731         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6732
6733 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6734
6735         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6736
6737 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6738             Tom Tromey  <tromey@adacore.com>
6739
6740         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6741
6742 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6743
6744         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6745         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6746         method to compute the bounds of range types. Also print "[evaluated]"
6747         if the bounds' values come from a dynamic evaluation.
6748
6749 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6752         whitespace when pretty printing is on.
6753
6754 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6755
6756         * ppc-linux-nat.c: Add include.
6757
6758 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6759
6760         * NEWS: Mention AArch64 Pointer Authentication.
6761
6762 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6763
6764         * arm-linux-nat.c: Add include.
6765
6766 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6767
6768         * source-cache.c (source_cache::get_source_lines): Re-read
6769         fullname after calling open_source_file.
6770
6771 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6772
6773         * NEWS: Mention TLS support for FreeBSD.
6774
6775 2019-03-25  Tom Tromey  <tromey@adacore.com>
6776
6777         * minsyms.c (BUNCH_SIZE): Update comment.
6778         (~minimal_symbol_reader): Remove old comment.
6779         (compact_minimal_symbols): Update comment.
6780         (minimal_symbol_reader::install): Remove old comment.  Update
6781         other comments.
6782
6783 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6784
6785         * s390-linux-nat.c: Add include.
6786
6787 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6788
6789         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6790         Call linux_get_hwcap.
6791         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6792         Likewise.
6793         (aarch64_linux_get_hwcap): Remove function.
6794         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6795         declaration.
6796         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6797         linux_get_hwcap.
6798         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6799         * linux-tdep.c (linux_get_hwcap): Add function.
6800         (linux_get_hwcap2): Likewise.
6801         * linux-tdep.h (linux_get_hwcap): Add declaration.
6802         (linux_get_hwcap2): Likewise.
6803         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6804         (ppc_linux_get_hwcap2): Likewise.
6805         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6806         linux_get_hwcap.
6807         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6808         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6809         (ppc_linux_nat_target::read_description): Likewise.
6810         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6811         * s390-linux-nat.c: Likewise.
6812         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6813
6814 2019-03-24  Tom Tromey  <tom@tromey.com>
6815
6816         * ada-lang.c (standard_lookup): Simplify initialization.
6817         (ada_lookup_symbol_nonlocal): Simplify return.
6818         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6819         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6820         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6821         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6822         initialization.
6823         * solib.c (solib_global_lookup): Simplify.
6824         * symtab.c (null_block_symbol): Remove.
6825         (symbol_cache_lookup): Simplify returns.
6826         (lookup_language_this): Simplify returns.
6827         (lookup_symbol_aux): Simplify return.
6828         (lookup_local_symbol): Simplify returns.
6829         (lookup_global_symbol_from_objfile): Simplify return.
6830         (lookup_symbol_in_objfile_symtabs)
6831         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6832         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6833         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6834         * cp-namespace.c (cp_lookup_bare_symbol)
6835         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6836         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6837         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6838         (cp_lookup_symbol_via_imports): Simplify initialization.
6839         (find_symbol_in_baseclass): Likewise.
6840         * symtab.h (null_block_symbol): Remove.
6841         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6842         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6843         (d_lookup_symbol_module): Likewise.
6844         (find_symbol_in_baseclass): Simplify initialization.
6845
6846 2019-03-24  Tom Tromey  <tom@tromey.com>
6847
6848         * expression.h: Don't include symtab.h.
6849         (struct block): Forward declare.
6850
6851 2019-03-24  Tom Tromey  <tom@tromey.com>
6852
6853         * c-exp.y (typebase): Remove casts.
6854         * gdbtypes.c (lookup_unsigned_typename, )
6855         (lookup_signed_typename): Remove cast.
6856         * eval.c (parse_to_comma_and_eval): Remove cast.
6857         * parse.c (write_dollar_variable): Remove cast.
6858         * block.h (struct block) <superblock>: Now const.
6859         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6860         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6861         (map_block): Make "block" const.
6862         * symfile.h (struct quick_symbol_functions)
6863         <map_matching_symbols>: Constify block argument to "callback".
6864         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6865         const.
6866         (find_pc_sect_compunit_symtab): Make "b" const.
6867         (find_symbol_at_address): Likewise.
6868         (search_symbols): Likewise.
6869         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6870         (dw2_debug_names_lookup_symbol): Likewise.
6871         (dw2_map_matching_symbols): Update.
6872         * p-valprint.c (pascal_val_print): Remove "block".
6873         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6874         (aux_add_nonlocal_symbols): Make "block" const.
6875         (resolve_subexp): Remove cast.
6876         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6877         const.
6878         (iterate_over_file_blocks): Likewise.
6879         * f-exp.y (%union) <bval>: Remove.
6880         * coffread.c (patch_opaque_types): Make "b" const.
6881         * spu-tdep.c (spu_catch_start): Make "block" const.
6882         * c-valprint.c (print_unpacked_pointer): Remove "block".
6883         * symmisc.c (dump_symtab_1): Make "b" const.
6884         (block_depth): Make "block" const.
6885         * d-exp.y (%union) <bval>: Remove.
6886         * cp-support.h (cp_lookup_rtti_type): Update.
6887         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6888         * psymtab.c (psym_lookup_symbol): Make "block" const.
6889         (maintenance_check_psymtabs): Make "b" const.
6890         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6891         (enumerate_locals, enumerate_args): Update.
6892         * python/py-symtab.c (stpy_global_block): Make "block" const.
6893         (stpy_static_block): Likewise.
6894         * inline-frame.c (block_starting_point_at): Make "new_block"
6895         const.
6896         * block.c (find_block_in_blockvector): Make return type const.
6897         (blockvector_for_pc_sect): Make "b" const.
6898         (find_block_in_blockvector): Make "b" const.
6899
6900 2019-03-23  Tom Tromey  <tom@tromey.com>
6901
6902         * varobj.c (varobj_create): Update.
6903         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6904         * printcmd.c (display_command, do_one_display): Don't reset
6905         innermost_block.
6906         * parser-defs.h (enum innermost_block_tracker_type): Move to
6907         expression.h.
6908         (innermost_block): Update comment.
6909         * parse.c (parse_exp_1): Add tracker_types parameter.
6910         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6911         tracker_types parameter.  Reset innermost_block.
6912         (parse_exp_in_context): Remove.
6913         (parse_expression_for_completion): Update.
6914         * objfiles.c (~objfile): Don't reset expression_context_block or
6915         innermost_block.
6916         * expression.h (enum innermost_block_tracker_type): Move from
6917         parser-defs.h.
6918         (parse_exp_1): Add tracker_types parameter.
6919         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6920         reset innermost_block.
6921
6922 2019-03-23  Tom Tromey  <tom@tromey.com>
6923
6924         * objfiles.h: Include bcache.h.
6925
6926 2019-03-23  Tom Tromey  <tom@tromey.com>
6927
6928         * linespec.c (get_current_search_block): Use
6929         scoped_restore_current_language.
6930         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6931
6932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6933             Jiong Wang  <jiong.wang@arm.com>
6934
6935         * aarch64-linux-tdep.c
6936         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6937         section.
6938         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6939
6940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6941             Jiong Wang  <jiong.wang@arm.com>
6942
6943         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6944         instructions.
6945         (aarch64_analyze_prologue_test): Add PACIASP test.
6946         (aarch64_prologue_prev_register): Unmask PC value.
6947
6948 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6949             Jiong Wang  <jiong.wang@arm.com>
6950
6951         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6952         (aarch64_dwarf2_prev_register): Unmask PC value.
6953         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6954         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6955         DW_CFA_AARCH64_negate_ra_state.
6956         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6957
6958 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6959             Jiong Wang  <jiong.wang@arm.com>
6960
6961         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6962         registers.
6963         (aarch64_pseudo_register_name): Likewise.
6964         (aarch64_pseudo_register_type): Likewise.
6965         (aarch64_pseudo_register_reggroup_p): Likewise.
6966         (aarch64_gdbarch_init): Add pauth registers.
6967         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6968         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6969         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6970         (struct gdbarch_tdep): Add regnum for ra_state.
6971
6972 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6973             Jiong Wang  <jiong.wang@arm.com>
6974
6975         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6976
6977 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6978             Jiong Wang  <jiong.wang@arm.com>
6979
6980         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6981         function.
6982         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6983         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6984         (aarch64_gdbarch_init): Add puth registers.
6985         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6986         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6987         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6988
6989 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6990             Jiong Wang  <jiong.wang@arm.com>
6991
6992         * aarch64-linux-nat.c
6993         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6994         * aarch64-linux-tdep.c
6995         (aarch64_linux_core_read_description): Likewise.
6996         (aarch64_linux_get_hwcap): New function.
6997         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6998         (aarch64_linux_get_hwcap): New declaration.
6999
7000 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7001             Jiong Wang  <jiong.wang@arm.com>
7002
7003         * aarch64-linux-nat.c
7004         (aarch64_linux_nat_target::read_description): Add pauth param.
7005         * aarch64-linux-tdep.c
7006         (aarch64_linux_core_read_description): Likewise.
7007         * aarch64-tdep.c (struct target_desc): Add in pauth.
7008         (aarch64_read_description): Add pauth param.
7009         (aarch64_gdbarch_init): Likewise.
7010         * aarch64-tdep.h (aarch64_read_description): Likewise.
7011         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7012         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7013         * features/Makefile: Add new files.
7014         * features/aarch64-pauth.c: New file.
7015         * features/aarch64-pauth.xml: New file.
7016
7017 2019-03-20  Tom Tromey  <tromey@adacore.com>
7018
7019         * infrun.c (handle_inferior_event): Rename from
7020         handle_inferior_event_1.  Create a scoped_value_mark.
7021         (handle_inferior_event): Remove.
7022
7023 2019-03-19  Tom Tromey  <tromey@adacore.com>
7024
7025         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7026         * infrun.h (print_stop_event): Add "displays" parameter.
7027         * infrun.c (print_stop_event): Add "displays" parameter.
7028
7029 2019-03-19  Pedro Alves  <palves@redhat.com>
7030
7031         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7032         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7033         to -1.  Fix TABs vs spaces.
7034         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7035         * tui/tui-out.h (tui_ui_out) Add intro comments.
7036         <m_line, m_start_of_line>: In-class initialize, and add describing
7037         comment.
7038
7039 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7040
7041         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7042         variable names.
7043         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7044
7045 2019-03-18  Pedro Alves  <palves@redhat.com>
7046             Eli Zaretskii <eliz@gnu.org>
7047
7048         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7049         m_line and m_start_of_line.
7050
7051 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7052
7053         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7054         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7055         it returns a newline.  This fixes a regression in TU mode, whereby
7056         the next line is output on the same screen line as the user input.
7057
7058 2019-03-18  Tom Tromey  <tromey@adacore.com>
7059
7060         * minsyms.c (minimal_symbol_reader::install): Remove call to
7061         obstack_blank.
7062
7063 2019-03-18  Pedro Alves  <palves@redhat.com>
7064
7065         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7066         New globals.
7067         (apply_style): New, factored out from ...
7068         (apply_ansi_escape): ... this.  Handle reverse video mode.
7069         (tui_set_reverse_mode): New function.
7070         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7071         * tui/tui-winsource.c (tui_show_source_line): Use
7072         tui_set_reverse_mode instead of setting A_STANDOUT.
7073         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7074         New setter methods.
7075
7076 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7077
7078         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7079         Handle tabs.
7080
7081 2019-03-18  Tom Tromey  <tromey@adacore.com>
7082
7083         * ada-lang.c (empty_array): Add "high" parameter.
7084         (ada_evaluate_subexp): Update.
7085
7086 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7087
7088         * unittests/string_view-selftests.c: Define
7089         _initialize_string_view_selftests unconditionally.
7090
7091 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7092
7093         PR gdb/24350
7094         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7095
7096 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7097
7098         PR gdb/24351
7099         * windows-nat.c (display_selector): Fix format specifiers.
7100
7101 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7102
7103         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7104         tui_refill_source_window instead of tui_refresh_win, to update the
7105         current execution line.  This fixes redisplay of the current line
7106         when stepping through the code with "next" or "step".
7107
7108 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7109
7110         * source-cache.c (source_cache::get_source_lines): Call
7111         find_source_lines to initialize s->nlines.  This fixes vertical
7112         scrolling of TUI source window when the DOWN arrow is pressed.
7113
7114 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7115
7116         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7117         linux-thread-db.c (_initialize_thread_db): Likewise.
7118
7119 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7120
7121         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7122         wclrtoeol in tui_show_source_line".  This reverts changes made in
7123         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7124
7125 2019-03-15  Tom Tromey  <tom@tromey.com>
7126
7127         * symtab.h (struct minimal_symbol): Derive from
7128         general_symbol_info.
7129         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7130         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7131         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7132         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7133         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7134         (MSYMBOL_SEARCH_NAME): Update.
7135         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7136         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7137         * minsyms.c (minimal_symbol_reader::record_full): Update.
7138
7139 2019-03-15  Tom Tromey  <tom@tromey.com>
7140
7141         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7142
7143 2019-03-15  Tom Tromey  <tom@tromey.com>
7144
7145         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7146         unique_xmalloc_ptr.
7147         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7148         Update.
7149         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7150         (build_minimal_symbol_hash_tables)
7151         (minimal_symbol_reader::install): Update.
7152
7153 2019-03-15  Tom Tromey  <tom@tromey.com>
7154
7155         * symtab.c (create_demangled_names_hash): Update.
7156         (symbol_set_names): Update.
7157         * objfiles.h (struct objfile_per_bfd_storage)
7158         <demangled_names_hash>: Now an htab_up.
7159         * objfiles.c (objfile_per_bfd_storage): Simplify.
7160
7161 2019-03-15  Tom Tromey  <tom@tromey.com>
7162
7163         * objfiles.h (struct objfile_per_bfd_storage): Declare
7164         destructor.
7165         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7166         New.
7167         (get_objfile_bfd_data): Use new.  Don't initialize
7168         language_of_main.
7169         (free_objfile_per_bfd_storage): Remove.
7170         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7171
7172 2019-03-15  Tom Tromey  <tom@tromey.com>
7173
7174         * symfile.c (reread_symbols): Update.
7175         * objfiles.c (objfile::objfile): Update.
7176         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7177         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7178         comment.
7179         (minimal_symbol_reader::install): Update.
7180         (terminate_minimal_symbol_table): Remove.
7181         * jit.c (jit_object_close_impl): Update.
7182
7183 2019-03-15  Tom Tromey  <tom@tromey.com>
7184
7185         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7186         initializations.
7187
7188 2019-03-15  Tom Tromey  <tom@tromey.com>
7189
7190         * objfiles.h (struct objfile_per_bfd_storage)
7191         <demangled_hash_languages>: Now a bitset.
7192         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7193         (lookup_minimal_symbol): Update.
7194
7195 2019-03-15  Tom Tromey  <tom@tromey.com>
7196
7197         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7198         Don't return the symbol.
7199         * coffread.c (record_minimal_symbol): Use record_full.
7200
7201 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7202
7203         The MS-Windows port of ncurses fails to switch to a color pair if
7204         one or both of the colors are the implicit default colors.  This
7205         change records the default colors when TUI is initialized, and
7206         then specifies them explicitly when a color pair uses the default
7207         colors.  This allows color styling in TUI mode on MS-Windows.
7208
7209         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7210         ncurses_norm_attr.
7211         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7212         colors in ncurses_norm_attr.
7213         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7214         "none", replace it with the default color recorded in
7215         ncurses_norm_attr.
7216
7217 2019-03-14  Tom Tromey  <tromey@adacore.com>
7218
7219         * source-cache.h (class source_cache) <get_source_lines>: Return
7220         std::string.
7221         * source-cache.c (source_cache::extract_lines): Handle case where
7222         first_pos==npos.  Return std::string.
7223         (source_cache::get_source_lines): Update.
7224
7225 2019-03-14  Tom Tromey  <tromey@adacore.com>
7226
7227         * NEWS: Add item for "style sources" commands.
7228         * source-cache.c (source_cache::get_source_lines): Check
7229         source_styling.
7230         * cli/cli-style.c (source_styling): New global.
7231         (_initialize_cli_style): Add "style sources" commands.
7232         (show_style_sources): New function.
7233         * cli/cli-style.h (source_styling): Declare.
7234
7235 2019-03-14  Pedro Alves  <palves@redhat.com>
7236             Tom Tromey  <tromey@adacore.com>
7237
7238         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7239         * tui/tui-winsource.c (tui_refill_source_window): New function,
7240         from...
7241         (tui_horizontal_source_scroll): ... here.  Move some logic.
7242         * cli/cli-style.c (set_style_enabled): Notify new observable.
7243         * tui/tui-hooks.c (tui_redisplay_source): New function.
7244         (tui_attach_detach_observers): Attach or detach
7245         tui_redisplay_source.
7246         * observable.h (source_styling_changed): New observable.
7247         * observable.c: Define source_styling_changed observable.
7248
7249 2019-03-13  Tom Tromey  <tromey@adacore.com>
7250
7251         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7252         (i386_gnu_nat_target::store_registers): Update.
7253         * target-debug.h (target_debug_print_std_string): New macro.
7254         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7255         * windows-tdep.c (display_one_tib): Update.
7256         * tui/tui-stack.c (tui_make_status_line): Update.
7257         * top.c (print_inferior_quit_action): Update.
7258         * thread.c (thr_try_catch_cmd): Update.
7259         (add_thread_with_info): Update.
7260         (thread_target_id_str): Update.
7261         (thr_try_catch_cmd): Update.
7262         (thread_command): Update.
7263         (thread_find_command): Update.
7264         * record-btrace.c (record_btrace_target::info_record)
7265         (record_btrace_resume_thread, record_btrace_target::resume)
7266         (record_btrace_cancel_resume, record_btrace_step_thread)
7267         (record_btrace_target::wait, record_btrace_target::wait)
7268         (record_btrace_target::wait, record_btrace_target::stop): Update.
7269         * progspace.c (print_program_space): Update.
7270         * process-stratum-target.c
7271         (process_stratum_target::thread_address_space): Update.
7272         * linux-fork.c (linux_fork_mourn_inferior)
7273         (detach_checkpoint_command, info_checkpoints_command)
7274         (linux_fork_context): Update.
7275         (linux_fork_detach): Update.
7276         (class scoped_switch_fork_info): Update.
7277         (delete_checkpoint_command): Update.
7278         * infrun.c (follow_fork_inferior): Update.
7279         (follow_fork_inferior): Update.
7280         (proceed_after_vfork_done): Update.
7281         (handle_vfork_child_exec_or_exit): Update.
7282         (follow_exec): Update.
7283         (displaced_step_prepare_throw): Update.
7284         (displaced_step_restore): Update.
7285         (start_step_over): Update.
7286         (resume_1): Update.
7287         (clear_proceed_status_thread): Update.
7288         (proceed): Update.
7289         (print_target_wait_results): Update.
7290         (do_target_wait): Update.
7291         (context_switch): Update.
7292         (stop_all_threads): Update.
7293         (restart_threads): Update.
7294         (finish_step_over): Update.
7295         (handle_signal_stop): Update.
7296         (switch_back_to_stepped_thread): Update.
7297         (keep_going_pass_signal): Update.
7298         (print_exited_reason): Update.
7299         (normal_stop): Update.
7300         * inferior.c (inferior_pid_to_str): Change return type.
7301         (print_selected_inferior): Update.
7302         (add_inferior): Update.
7303         (detach_inferior): Update.
7304         * dummy-frame.c (fprint_dummy_frames): Update.
7305         * dcache.c (dcache_info_1): Update.
7306         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7307         (btrace_fetch, btrace_clear): Update.
7308         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7309         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7310         type.
7311         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7312         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7313         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7314         * gdbarch.c, gdbarch.h: Rebuild.
7315         * gdbarch.sh (core_pid_to_str): Change return type.
7316         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7317         return type.
7318         (windows_nat_target::pid_to_str): Change return type.
7319         (windows_delete_thread): Update.
7320         (windows_nat_target::attach): Update.
7321         (windows_nat_target::files_info): Update.
7322         * target-delegates.c: Rebuild.
7323         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7324         return type.
7325         (sol_thread_target::pid_to_str): Change return type.
7326         * remote.c (class remote_target) <pid_to_str>: Change return
7327         type.
7328         (remote_target::pid_to_str): Change return type.
7329         (extended_remote_target::attach, remote_target::remote_stop_ns)
7330         (remote_target::remote_notif_remove_queued_reply)
7331         (remote_target::push_stop_reply, remote_target::disable_btrace):
7332         Update.
7333         (extended_remote_target::attach): Update.
7334         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7335         type.
7336         (gdbsim_target::pid_to_str): Change return type.
7337         * ravenscar-thread.c (struct ravenscar_thread_target)
7338         <pid_to_str>: Change return type.
7339         (ravenscar_thread_target::pid_to_str): Change return type.
7340         * procfs.c (class procfs_target) <pid_to_str>: Change return
7341         type.
7342         (procfs_target::pid_to_str): Change return type.
7343         (procfs_target::attach): Update.
7344         (procfs_target::detach): Update.
7345         (procfs_target::fetch_registers): Update.
7346         (procfs_target::store_registers): Update.
7347         (procfs_target::wait): Update.
7348         (procfs_target::files_info): Update.
7349         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7350         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7351         return type.
7352         (nto_procfs_target::pid_to_str): Change return type.
7353         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7354         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7355         return type.
7356         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7357         (exit_lwp): Update.
7358         (attach_proc_task_lwp_callback, get_detach_signal)
7359         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7360         (linux_nat_target::resume, wait_lwp, stop_callback)
7361         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7362         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7363         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7364         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7365         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7366         type.
7367         (inf_ptrace_target::attach): Update.
7368         (inf_ptrace_target::files_info): Update.
7369         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7370         type.
7371         (go32_nat_target::pid_to_str): Change return type.
7372         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7373         (gnu_nat_target::wait): Update.
7374         (gnu_nat_target::wait): Update.
7375         (gnu_nat_target::resume): Update.
7376         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7377         (fbsd_nat_target::wait): Update.
7378         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7379         type.
7380         (darwin_nat_target::attach): Update.
7381         * corelow.c (class core_target) <pid_to_str>: Change return type.
7382         (core_target::pid_to_str): Change return type.
7383         * target.c (normal_pid_to_str): Change return type.
7384         (default_pid_to_str): Likewise.
7385         (target_pid_to_str): Change return type.
7386         (target_translate_tls_address): Update.
7387         (target_announce_detach): Update.
7388         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7389         return type.
7390         (bsd_uthread_target::pid_to_str): Change return type.
7391         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7392         type.
7393         (bsd_kvm_target::pid_to_str): Change return type.
7394         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7395         return type.
7396         (aix_thread_target::pid_to_str): Change return type.
7397         * target.h (struct target_ops) <pid_to_str>: Change return type.
7398         (target_pid_to_str, normal_pid_to_str): Likewise.
7399         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7400         type.
7401         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7402         type.
7403         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7404         return type.
7405         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7406         type.
7407         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7408         type.
7409         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7410         return type.
7411
7412 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7413
7414         * NEWS: Mention that the new default MI version is 3.  Mention
7415         changes to the output of commands and events that deal with
7416         multi-location breakpoints.
7417         * breakpoint.c: Include "mi/mi-out.h".
7418         (print_one_breakpoint): Change output syntax if using MI version
7419         >= 3.
7420         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7421         New.
7422         (mi_multi_location_breakpoint_output_fixed): New.
7423         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7424         (mi_cmd_fix_multi_location_breakpoint_output): New.
7425         (mi_multi_location_breakpoint_output_fixed): New.
7426         * mi/mi-cmds.c (mi_cmds): Register command
7427         -fix-multi-location-breakpoint-output.
7428         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7429         interpreter "mi".
7430
7431 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7432
7433         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7434         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7435         instantiate mi_ui_out based on interpreter name.
7436         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7437         * mi/mi-main.c (mi_load_progress): Likewise.
7438
7439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7440
7441         * NEWS: Combine separate "New targets" sections for 8.3.
7442
7443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7444
7445         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7446         (ppcfbsd_init_abi): Install gdbarch
7447         "fetch_tls_load_module_address" and "get_thread_local_address"
7448         methods.
7449
7450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7451
7452         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7453         (riscv_fbsd_init_abi): Install gdbarch
7454         "fetch_tls_load_module_address" and "get_thread_local_address"
7455         methods.
7456
7457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7458
7459         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7460         (i386fbsd_init_abi): Install gdbarch
7461         "fetch_tls_load_module_address" and "get_thread_local_address"
7462         methods.
7463
7464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7465
7466         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7467         (amd64fbsd_init_abi): Install gdbarch
7468         "fetch_tls_load_module_address" and "get_thread_local_address"
7469         methods.
7470
7471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7472
7473         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7474         (struct fbsd_pspace_data): New type.
7475         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7476         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7477         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7478         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7479         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7480
7481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7482
7483         * gdbtypes.c (lookup_struct_elt): New function.
7484         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7485         * gdbtypes.h (struct struct_elt): New type.
7486         (lookup_struct_elt): New prototype.
7487
7488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7489
7490         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7491         remove disabled code block.
7492
7493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7494
7495         * gdbarch.sh (get_thread_local_address): New method.
7496         * gdbarch.h, gdbarch.c: Regenerate.
7497         * target.c (target_translate_tls_address): Use
7498         gdbarch_get_thread_local_address if present instead of
7499         target::get_thread_local_address.
7500
7501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * target.h (target::get_thread_local_address): Update comment.
7504
7505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7506
7507         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7508         objfile->separate_debug_objfile_backlink if not NULL.
7509
7510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7511
7512         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7513         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7514         (amd64bsd_store_inferior_registers): Likewise.
7515         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7516         Enable segment base registers.
7517         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7518         PT_GETFSBASE and PT_GETGSBASE.
7519         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7520         PT_SETGSBASE.
7521         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7522         segment base registers.
7523         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7524
7525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7526
7527         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7528         Update calls to i386_target_description to add 'segments'
7529         parameter.
7530         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7531         add segment base registers.
7532         * arch/i386.c (i386_create_target_description): Add 'segments'
7533         parameter to enable segment base registers.
7534         * arch/i386.h (i386_create_target_description): Likewise.
7535         * features/i386/32bit-segments.xml: New file.
7536         * features/i386/32bit-segments.c: Generate.
7537         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7538         call to i386_target_description to add 'segments' parameter.
7539         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7540         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7541         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7542         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7543         if feature is present.
7544         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7545         Add 'segments' parameter to call to i386_target_description.
7546         (i386_target_description): Add 'segments' parameter to enable
7547         segment base registers.
7548         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7549         to call to i386_target_description.
7550         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7551         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7552         Define I386_NUM_REGS.
7553         (i386_target_description): Add 'segments' parameter to enable
7554         segment base registers.
7555
7556 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7557
7558         PR/24325
7559         * source-cache.c: #undef open and close, to avoid unresolved
7560         externals during linking.
7561
7562 2019-03-12  Tom Tromey  <tromey@adacore.com>
7563
7564         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7565         const.  Add initializers.
7566         (_initialize_remote): Don't initialize ptid globals.
7567
7568 2019-03-12  Pedro Alves  <palves@redhat.com>
7569
7570         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7571
7572 2019-03-12  Pedro Alves  <palves@redhat.com>
7573
7574         * cp-name-parser.y (main): Remove unused 'len' variable.
7575
7576 2019-03-12  Tom Tromey  <tromey@adacore.com>
7577
7578         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7579         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7580
7581 2019-03-12  Tom Tromey  <tromey@adacore.com>
7582
7583         * linux-nat.c (iterate_over_lwps): Update.
7584         (stop_callback): Remove parameter.
7585         (stop_wait_callback, detach_callback, resume_set_callback)
7586         (select_singlestep_lwp_callback, set_ignore_sigint)
7587         (status_callback, resumed_callback, resume_clear_callback)
7588         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7589         data parameter.
7590         (linux_nat_target::detach, linux_nat_target::resume)
7591         (linux_stop_and_wait_all_lwps, select_event_lwp)
7592         (linux_nat_filter_event, linux_nat_wait_1)
7593         (linux_nat_target::kill, linux_nat_target::stop)
7594         (linux_nat_target::stop): Update.
7595         (linux_nat_resume_callback): Change type.
7596         (resume_stopped_resumed_lwps, count_events_callback)
7597         (select_event_lwp_callback): Likewise.
7598         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7599         * arm-linux-nat.c (struct update_registers_data): Remove.
7600         (update_registers_callback): Change type.
7601         (arm_linux_insert_hw_breakpoint1): Update.
7602         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7603         parameter.
7604         (x86_linux_dr_set_addr): Update.
7605         (x86_linux_dr_set_control): Update.
7606         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7607         (iterate_over_lwps): Use gdb::function_view.
7608         * nat/aarch64-linux-hw-point.c (struct
7609         aarch64_dr_update_callback_param): Remove.
7610         (debug_reg_change_callback): Change type.
7611         (aarch64_notify_debug_reg_change): Update.
7612         * s390-linux-nat.c (s390_refresh_per_info): Update.
7613
7614 2019-03-11  Tom Tromey  <tromey@adacore.com>
7615
7616         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7617         redundant assignment to "this_cu".
7618
7619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7620
7621         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7622
7623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7624
7625         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7626         from...
7627         (rank_one_type): ... this.
7628
7629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7630
7631         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7632         from...
7633         (rank_one_type): ... this.
7634
7635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7636
7637         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7638         from...
7639         (rank_one_type): ... this.
7640
7641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7642
7643         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7644         from...
7645         (rank_one_type): ... this.
7646
7647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7648
7649         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7650         from...
7651         (rank_one_type): ... this.
7652
7653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7654
7655         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7656         from...
7657         (rank_one_type): ... this.
7658
7659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7660
7661         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7662         from...
7663         (rank_one_type): ... this.
7664
7665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7666
7667         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7668         from...
7669         (rank_one_type): ... this.
7670
7671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7672
7673         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7674         from...
7675         (rank_one_type): ... this.
7676
7677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7678
7679         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7680         from...
7681         (rank_one_type): ... this.
7682
7683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7684
7685         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7686         from...
7687         (rank_one_type): ... this.
7688
7689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7690
7691         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7692         from...
7693         (rank_one_type): ... this.
7694
7695 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7696
7697         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7698         inferior-events' shows the example events.
7699
7700 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7701
7702         Support styling on native MS-Windows console
7703
7704         PR/24315
7705         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7706         on MS-Windows if $TERM is not defined.
7707
7708         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7709
7710         * posix-hdep.c (gdb_console_fputs):
7711         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7712         functions.
7713         * ui-file.h (gdb_console_fputs): Add prototype.
7714
7715         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7716         back to fputs only if the former returns zero.
7717
7718 2019-03-07  Tom Tromey  <tom@tromey.com>
7719
7720         * symmisc.c (print_symbol_bcache_statistics): Update.
7721         (print_objfile_statistics): Update.
7722         * symfile.c (allocate_symtab): Update.
7723         * stabsread.c: Don't include bcache.h.
7724         * psymtab.h (struct psymbol_bcache): Don't declare.
7725         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7726         (psymbol_bcache_init, psymbol_bcache_free)
7727         (psymbol_bcache_get_bcache): Don't declare.
7728         * psymtab.c (struct psymbol_bcache): Remove.
7729         (psymtab_storage::psymtab_storage): Update.
7730         (psymtab_storage::~psymtab_storage): Update.
7731         (psymbol_bcache_init, psymbol_bcache_free)
7732         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7733         (add_psymbol_to_bcache): Update.
7734         (allocate_psymtab): Update.
7735         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7736         macro_cache>: No longer pointers.
7737         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7738         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7739         * macrotab.c (macro_bcache): Update.
7740         * macroexp.c: Don't include bcache.h.
7741         * gdbtypes.c (check_types_worklist): Update.
7742         (types_deeply_equal): Remove TRY/CATCH.  Update.
7743         * elfread.c (elf_symtab_read): Update.
7744         * dwarf2read.c: Don't include bcache.h.
7745         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7746         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7747         (print_bcache_statistics, bcache_memory_used): Don't declare.
7748         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7749         methods.  Rename all data members.
7750         * bcache.c (struct bcache): Move to bcache.h.
7751         (bcache::expand_hash_table): Rename from expand_hash_table.
7752         (bcache): Remove.
7753         (bcache::insert): Rename from bcache_full.
7754         (bcache::compare): Rename from bcache_compare.
7755         (bcache_xmalloc): Remove.
7756         (bcache::~bcache): Rename from bcache_xfree.
7757         (bcache::print_statistics): Rename from print_bcache_statistics.
7758         (bcache::memory_used): Rename from bcache_memory_used.
7759
7760 2019-03-07  Pedro Alves  <palves@redhat.com>
7761
7762         * infrun.c (normal_stop): Also check for
7763         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7764
7765 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7766
7767         * f-lang.c (value_from_host_double): Moved to...
7768         * value.c (value_from_host_double): ...here.
7769         * value.h (value_from_host_double): Declare.
7770         * guile/scm-math.c (vlscm_convert_typed_number): Use
7771         value_from_host_double.
7772         (vlscm_convert_number): Likewise.
7773         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7774         * python/py-value.c (convert_value_from_python): Likewise.
7775
7776 2019-03-06  Tom Tromey  <tom@tromey.com>
7777
7778         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7779
7780 2019-03-06  Tom Tromey  <tom@tromey.com>
7781
7782         * utils.h (free_current_contents): Don't declare.
7783         * utils.c (free_current_contents): Remove.
7784
7785 2019-03-06  Tom Tromey  <tom@tromey.com>
7786
7787         * top.c (quit_force): Update.
7788         * main.c (captured_command_loop): Update.
7789         * common/new-op.c (operator new): Update.
7790         * common/common-exceptions.c (struct catcher)
7791         <save_cleanup_chain>: Remove member.
7792         (exceptions_state_mc_init): Update.
7793         (exception_try_scope_entry): Return nullptr.
7794         (exception_try_scope_exit, exception_rethrow)
7795         (throw_exception_sjlj, throw_exception_cxx): Update.
7796         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7797         (all_cleanups, do_cleanups, discard_cleanups)
7798         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7799         (restore_cleanups, restore_final_cleanups): Don't declare.
7800         (do_final_cleanups): Remove parameter.
7801         * common/cleanups.c (cleanup_chain, make_cleanup)
7802         (make_cleanup_dtor, all_cleanups, do_cleanups)
7803         (discard_my_cleanups, discard_cleanups)
7804         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7805         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7806         (null_cleanup): Remove.
7807         (do_final_cleanups): Remove parameter.
7808
7809 2019-03-06  Tom Tromey  <tom@tromey.com>
7810
7811         * remote.c (remote_target::remote_parse_stop_reply): Use
7812         unique_xmalloc_ptr.
7813
7814 2019-03-06  Tom Tromey  <tom@tromey.com>
7815
7816         * stabsread.c (struct stabs_field_info): Rename from field_info.
7817         <list, fnlist>: Add initializers.
7818         <obstack>: New member.
7819         (read_member_functions, read_struct_fields, read_baseclasses):
7820         Allocate on obstack.  Don't use cleanups.
7821         (read_one_struct_field, read_member_functions, read_struct_fields)
7822         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7823         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7824         (read_struct_type): Update.
7825
7826 2019-03-06  Tom Tromey  <tom@tromey.com>
7827
7828         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7829         * common/filestuff.h (make_cleanup_close): Don't declare.
7830         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7831         Remove.
7832
7833 2019-03-06  Tom Tromey  <tom@tromey.com>
7834
7835         * solib-aix.c: Use make_scope_exit.
7836
7837 2019-03-06  Tom Tromey  <tom@tromey.com>
7838
7839         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7840         Use make_scope_exit.
7841
7842 2019-03-06  Tom Tromey  <tom@tromey.com>
7843
7844         * solib-svr4.c (disable_probes_interface): Remove parameter.
7845         (svr4_handle_solib_event): Use make_scope_exit.
7846
7847 2019-03-06  Tom Tromey  <tom@tromey.com>
7848
7849         * remote.c (struct stop_reply_deleter): Remove.
7850         (stop_reply_up): Update.
7851         (struct stop_reply): Derive from notif_event.  Don't typedef.
7852         <regcache>: Now a std::vector.
7853         (stop_reply_xfree): Remove.
7854         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7855         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7856         (remote_target::discard_pending_stop_replies): Use delete.
7857         (remote_target::remote_parse_stop_reply): Update.
7858         (remote_target::process_stop_reply): Update.
7859         * remote-notif.h (struct notif_event): Add virtual destructor.
7860         Remove "dtr" member.
7861         (struct notif_client) <alloc_event>: Return a unique_ptr.
7862         (notif_event_xfree): Don't declare.
7863         (notif_event_up): New typedef.
7864         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7865         (notif_event_xfree, do_notif_event_xfree): Remove.
7866         (remote_notif_state_xfree): Update.
7867
7868 2019-03-06  Tom Tromey  <tom@tromey.com>
7869
7870         * infrun.c (displaced_step_clear_cleanup): Now a
7871         forward_scope_exit type.
7872         (displaced_step_prepare_throw): Update.
7873         (displaced_step_fixup): Update.
7874
7875 2019-03-06  Tom Tromey  <tom@tromey.com>
7876
7877         * inferior.h (class inferior): Update comment.
7878         * gdbthread.h (class thread_info): Update comment.
7879
7880 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7881             Tom Tromey  <tom@tromey.com>
7882
7883         * stabsread.h (struct stab_section_list): Remove.
7884         (coffstab_build_psymtabs): Update.
7885         * dbxread.c (symbuf_sections): Now a std::vector.
7886         (sect_idx): New global.
7887         (fill_symbuf): Update.
7888         (coffstab_build_psymtabs): Change type of stabsects parameter.
7889         Update.
7890         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7891         std::vector.
7892         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7893         (coff_locate_sections): Update.
7894         (coff_symfile_read): Remove cleanups.  Update.
7895         (init_stringtab): Add storage parameter.
7896         (free_stringtab, free_stringtab_cleanup): Remove.
7897         (init_lineno): Add storage parameter.
7898         (free_linetab, free_linetab_cleanup): Remove.
7899
7900 2019-03-06  Pedro Alves  <palves@redhat.com>
7901
7902         * linux-fork.c (fork_info::clobber_regs): Delete.
7903         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7904         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7905         comment.  Adjust.
7906         (scoped_switch_fork_info::scoped_switch_fork_info)
7907         (checkpoint_command, linux_fork_context): Adjust
7908         fork_save_infrun_state calls.
7909
7910 2019-03-06  Pedro Alves  <palves@redhat.com>
7911
7912         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7913         (inf_has_multiple_threads): Return 'bool' and rewrite using
7914         inferior_info::threads().
7915
7916 2019-03-06  Pedro Alves  <palves@redhat.com>
7917
7918         * linux-fork.c: Include <list>.
7919         (fork_list): Now a std::list instance.
7920         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7921         (forks_exist_p, find_last_fork): Adjust.
7922         (new_fork): Delete.
7923         (one_fork_p): New.
7924         (add_fork): Adjust.
7925         (free_fork): Delete, folded into fork_info::~fork_info().
7926         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7927         Adjust.
7928         (init_fork_list): Delete.
7929         (linux_fork_killall, linux_fork_mourn_inferior)
7930         (linux_fork_detach, info_checkpoints_command): Adjust.
7931         (_initialize_linux_fork): No longer call init_fork_list.
7932
7933 2019-03-06  Pedro Alves  <palves@redhat.com>
7934
7935         * linux-fork.c (new_fork): New, split out of ...
7936         (add_fork): ... this.  Return void.  Move "first fork" special
7937         case from here, to ...
7938         (checkpoint_command): ... here.
7939         * linux-linux.h (add_fork): Return void.
7940
7941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7944
7945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7946             Chris January  <chris.january@arm.com>
7947             David Lecomber  <david.lecomber@arm.com>
7948
7949         * f-exp.y: New token, UNOP_INTRINSIC.
7950         (exp): New pattern using UNOP_INTRINSIC token.
7951         (f77_keywords): Add 'abs' keyword.
7952         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7953         (value_from_host_double): New function.
7954         (evaluate_subexp_f): Support UNOP_ABS.
7955
7956 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7957
7958         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7959         types.
7960
7961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7962
7963         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7964         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7965         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7966
7967 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7968
7969         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7970
7971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7972             Chris January  <chris.january@arm.com>
7973
7974         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7975         * f-exp.y: Define 'KIND' token.
7976         (exp): New pattern for KIND expressions.
7977         (ptype): Handle types with a kind extension.
7978         (direct_abs_decl): Extend to spot kind extensions.
7979         (f77_keywords): Add 'kind' to the list.
7980         (push_kind_type): New function.
7981         (convert_to_kind_type): New function.
7982         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7983         * parse.c (operator_length_standard): Likewise.
7984         * parser-defs.h (enum type_pieces): Add tp_kind.
7985         * std-operator.def: Add UNOP_KIND.
7986
7987 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7988
7989         * f-exp.y (f_parse): Set yydebug.
7990
7991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * f-lang.c (evaluate_subexp_f): New function.
7994         (exp_descriptor_f): New global.
7995         (f_language_defn): Use exp_descriptor_f instead of
7996         exp_descriptor_standard.
7997
7998 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7999
8000         * f-exp.y (struct token): Add comments.
8001         (dot_ops): Remove uppercase versions and the end marker.
8002         (f77_keywords): Likewise.
8003         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8004         entries in the dot_ops array are case insensitive, and use
8005         strncasecmp to compare strings.  Also some whitespace cleanup in
8006         this area.  Similar for the f77_keywords array, except entries in
8007         this list might be case sensitive.
8008
8009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         * f-exp.y (struct f77_boolean_val): Add comments.
8012         (boolean_values): Remove uppercase versions, and end marker.
8013         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8014         and use strncasecmp to achieve case insensitivity.  Additionally,
8015         perform whitespace cleanup around this code.
8016
8017 2019-03-06  Tom Tromey  <tromey@adacore.com>
8018
8019         * remote-sim.c (gdbsim_target_open): Use result of
8020         gdb_argv::release.
8021
8022 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8023         Dirk Schubert  <dirk.schubert@arm.com>
8024         Chris January  <chris.january@arm.com>
8025
8026         * eval.c (evaluate_subexp_standard): Call Fortran argument
8027         wrapping logic.
8028         * f-lang.c (struct value): A value which can be passed into a
8029         Fortran function call.
8030         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8031         where appropriate.
8032         (struct type): Value ready for a Fortran function call.
8033         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8034         is needed.
8035         * f-lang.h (fortran_argument_convert): Declaration.
8036         (fortran_preserve_arg_pointer): Declaration.
8037         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8038
8039 2019-03-05  Tom Tromey  <tromey@adacore.com>
8040
8041         * python/py-prettyprint.c (print_string_repr): Remove #if.
8042         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8043
8044 2019-03-05  Tom Tromey  <tromey@adacore.com>
8045
8046         * target.c (the_dummy_target): Move later.  Change type to
8047         "dummy_target".
8048         (initialize_targets): Don't initialize the_dummy_target.
8049
8050 2019-03-05  Tom Tromey  <tromey@adacore.com>
8051
8052         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8053         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8054
8055 2019-03-05  Tom Tromey  <tromey@adacore.com>
8056
8057         * windows-nat.c (windows_nat_target::attach)
8058         (windows_nat_target::detach): Don't call gdb_flush.
8059         * valprint.c (generic_val_print, val_print, val_print_string):
8060         Don't call gdb_flush.
8061         * utils.c (defaulted_query): Don't call gdb_flush.
8062         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8063         * target.c (target_announce_detach): Don't call gdb_flush.
8064         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8065         * remote.c (extended_remote_target::attach): Don't call
8066         gdb_flush.
8067         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8068         * printcmd.c (do_examine): Don't call gdb_flush.
8069         (info_display_command): Don't call gdb_flush.
8070         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8071         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8072         * memattr.c (info_mem_command): Don't call gdb_flush.
8073         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8074         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8075         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8076         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8077         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8078         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8079         (gnu_nat_target::detach): Don't call gdb_flush.
8080         * f-valprint.c (f_val_print): Don't call gdb_flush.
8081         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8082         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8083         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8084         gdb_flush.
8085         * c-valprint.c (c_val_print): Don't call gdb_flush.
8086         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8087
8088 2019-03-05  Tom Tromey  <tromey@adacore.com>
8089
8090         * varobj.c (update_dynamic_varobj_children): Update.
8091         (install_default_visualizer): Use reset, not release.
8092         * value.c (set_internalvar): Update.
8093         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8094         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8095         ATTRIBUTE_UNUSED_RESULT.
8096
8097 2019-03-05  Tom Tromey  <tromey@adacore.com>
8098
8099         * remote.c (class scoped_remote_fd) <release>: Add
8100         ATTRIBUTE_UNUSED_RESULT.
8101
8102 2019-03-05  Tom Tromey  <tromey@adacore.com>
8103
8104         * macroexp.c (struct macro_buffer) <release>: Add
8105         ATTRIBUTE_UNUSED_RESULT.
8106
8107 2019-03-05  Tom Tromey  <tromey@adacore.com>
8108
8109         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8110         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8111         ATTRIBUTE_UNUSED_RESULT.
8112
8113 2019-03-05  Tom Tromey  <tromey@adacore.com>
8114
8115         * common/scoped_fd.h (class scoped_fd) <release>: Add
8116         ATTRIBUTE_UNUSED_RESULT.
8117
8118 2019-03-05  Tom Tromey  <tromey@adacore.com>
8119
8120         * parser-defs.h (struct parser_state) <release>: Add
8121         ATTRIBUTE_UNUSED_RESULT.
8122
8123 2019-03-05  Tom Tromey  <tromey@adacore.com>
8124
8125         * utils.h (class gdb_argv) <release>: Add
8126         ATTRIBUTE_UNUSED_RESULT.
8127         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8128
8129 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8130
8131         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8132         for-loop range, to avoid compiler warnings.
8133
8134         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8135         avoid compiler warnings about unused variables.
8136
8137         * NEWS: Mention end of support for native debugging on MS-Windows
8138         before XP.
8139
8140         PR gdb/24292
8141         * common/netstuff.c:
8142         * gdbserver/gdbreplay.c
8143         * gdbserver/remote-utils.c:
8144         * ser-tcp.c:
8145         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8146         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8147         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8148         'getaddrinfo' and 'freeaddrinfo' were not available before
8149         Windows XP, and mingw.org's MinGW headers by default define
8150         _WIN32_WINNT to 0x500.
8151
8152 2019-03-01  Gary Benson <gbenson@redhat.com>
8153
8154         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8155
8156 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8157             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8158
8159         PR gdb/8527
8160         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8161         set_sigint_trap, clear_sigint_trap.
8162
8163 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8164
8165         * target.c (target_detach): Clear the regcache and the
8166         frame cache.
8167
8168 2019-02-27  Pedro Alves  <palves@redhat.com>
8169
8170         * utils.c (set_screen_size): When we cap the height/width sizes,
8171         tweak the corresponding command variable to show "unlimited":
8172
8173 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8174             Pedro Alves  <palves@redhat.com>
8175
8176         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8177         before calling rl_set_screen_size.
8178
8179 2019-02-27  Tom Tromey  <tromey@adacore.com>
8180
8181         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8182         define.
8183         * python/py-value.c: Remove Python 2.4 workaround.
8184         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8185         workaround.
8186         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8187         Python 2.4 workaround.
8188         * python/python-internal.h: Remove Python 2.4 comment.
8189         (Py_ssize_t): Don't define.
8190         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8191         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8192         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8193         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8194         * python/python.c (do_start_initialization): Remove Python 2.4
8195         workaround.
8196         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8197         (print_children): Remove Python 2.4 workaround.
8198         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8199         workaround.
8200         (CHARBUFFERPROC_NAME): Remove.
8201         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8202         Python 2.4 workaround.
8203
8204 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8205
8206         * NEWS: Note minimum Python version.
8207
8208 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8209
8210         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8211         code from these functions.  Remove corresponding ifdefs.  Use
8212         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8213         Remove gotos and target of gotos.
8214         (infpy_search_memory): Likewise.
8215
8216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8217
8218         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8219         (hppa_gdbarch_init): Don't register deleted functions with
8220         gdbarch.
8221
8222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8225         (h8300_unwind_sp): Delete.
8226         (h8300_dummy_id): Delete.
8227         (h8300_gdbarch_init): Don't register deleted functions with
8228         gdbarch.
8229
8230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8231
8232         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8233         (ft32_unwind_pc): Delete.
8234         (ft32_unwind_sp): Delete.
8235         (ft32_gdbarch_init): Don't register deleted functions with
8236         gdbarch.
8237
8238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8239
8240         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8241         (frv_unwind_pc): Delete.
8242         (frv_unwind_sp): Delete.
8243         (frv_gdbarch_init): Don't register deleted functions with
8244         gdbarch.
8245
8246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8247
8248         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8249         (riscv_unwind_pc): Delete.
8250         (riscv_unwind_sp): Delete.
8251         (riscv_gdbarch_init): Don't register deleted functions with
8252         gdbarch.
8253
8254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8255
8256         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8257         (csky_unwind_pc): Delete.
8258         (csky_unwind_sp): Delete.
8259         (csky_gdbarch_init): Don't register deleted functions with
8260         gdbarch.
8261
8262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8263
8264         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8265         (cris_unwind_pc): Delete.
8266         (cris_unwind_sp): Delete.
8267         (cris_gdbarch_init): Don't register deleted functions with
8268         gdbarch.
8269
8270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8271
8272         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8273         (bfin_unwind_pc): Delete.
8274         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8275
8276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8279         (arm_unwind_pc): Delete.
8280         (arm_unwind_sp): Delete.
8281         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8282
8283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8284
8285         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8286         (arc_unwind_pc): Delete.
8287         (arc_unwind_sp): Delete.
8288         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8289
8290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8291
8292         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8293         (alpha_unwind_pc): Delete.
8294         (alpha_gdbarch_init): Don't register deleted functions with
8295         gdbarch.
8296
8297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8300         (aarch64_unwind_pc): Delete.
8301         (aarch64_unwind_sp): Delete.
8302         (aarch64_gdbarch_init): Don't register deleted functions with
8303         gdbarch.
8304
8305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8306
8307         * gdbtypes.c (type_align): Don't consider static members when
8308         computing structure alignment.
8309
8310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8311
8312         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8313         return 0 for other types.
8314         * arch-utils.c (default_type_align): Always return 0.
8315         * gdbarch.h: Regenerate.
8316         * gdbarch.sh (type_align): Extend comment.
8317         * gdbtypes.c (type_align): Add additional comments, always call
8318         gdbarch_type_align before applying the default rules.
8319         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8320         generic code will then apply a suitable default.
8321         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8322         types, return 0 for other types.
8323
8324 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8325
8326         * NEWS: Create a new section for the next release branch.
8327         Rename the section of the current branch, now that it has
8328         been cut.
8329
8330 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8331
8332         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8333         * version.in: Bump version to 8.3.50.DATE-git.
8334
8335 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8336
8337         * aix-thread.c (ptid_cmp): Remove unused variable.
8338         (get_signaled_thread): Likewise.
8339         (store_regs_user_thread): Likewise.
8340         (store_regs_kernel_thread): Likewise.
8341         (fetch_regs_kernel_thread): Remove shadowed variable.
8342
8343 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8344
8345         * features/riscv/32bit-cpu.xml: Add register numbers.
8346         * features/riscv/32bit-fpu.c: Regenerate.
8347         * features/riscv/32bit-fpu.xml: Add register numbers.
8348         * features/riscv/64bit-cpu.xml: Add register numbers.
8349         * features/riscv/64bit-fpu.c: Regenerate.
8350         * features/riscv/64bit-fpu.xml: Add register numbers.
8351
8352 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8353
8354         * NEWS: Mention two argument form of gdb.Value constructor.
8355         * python/py-value.c (convert_buffer_and_type_to_value): New
8356         function.
8357         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8358         Add support for handling an optional second argument.  Call
8359         convert_buffer_and_type_to_value as appropriate.
8360         * python/python-internal.h (Py_buffer_deleter): New struct.
8361         (Py_buffer_up): New typedef.
8362
8363 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8364
8365         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8366         instead of releasing ownership.
8367
8368 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8369
8370         * dwarf2read.c (open_and_init_dwp_file): Call
8371         elf_numsections instead of bfd_count_sections to initialize
8372         dwp_file->num_sections.
8373
8374 2019-02-25  Tom Tromey  <tromey@adacore.com>
8375
8376         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8377
8378 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8379
8380         * gcore.in: Add '--readnever' option when invoking GDB.
8381
8382 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8383
8384         * MAINTAINERS: Update my email address.
8385
8386 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8387
8388         * build-id.c (build_id_to_debug_bfd_1): New function.
8389         (build_id_to_debug_bfd): Look for separate debug file in
8390         sysroot.
8391
8392 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * gdbarch.sh: Update the copyright year range that is placed into
8395         generated files.
8396
8397 2019-02-22  Keith Seitz  <keiths@redhat.com>
8398
8399         PR symtab/23853
8400         * linespec.c (create_sals_line_offset): Search for the default
8401         symtab's filename instead of its fullname.
8402
8403 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8404
8405         * NEWS: Update style defaults.
8406
8407 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * main.c (captured_main_1): Disable styling in batch mode.
8410
8411 2019-02-20  Tom Tromey  <tom@tromey.com>
8412
8413         * symtab.c (symtab_symbol_info): Fix typos.
8414
8415 2019-02-20  Tom Tromey  <tromey@adacore.com>
8416
8417         * findcmd.c (_initialize_mem_search): Use upper case for
8418         metasyntactic variables.
8419
8420 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8421
8422         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8423         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8424
8425 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8426
8427         * top.h (source_file_name): Change to std::string.
8428         * top.c (source_file_name): Likewise.
8429         (command_line_input): Adjust.
8430         * cli/cli-script.c (script_from_file): Adjust.
8431
8432 2019-02-19  Tom Tromey  <tromey@adacore.com>
8433
8434         * ravenscar-thread.c
8435         (ravenscar_thread_target::update_thread_list): Don't call
8436         ada_build_task_list.
8437         * ada-lang.h (ada_build_task_list): Don't declare.
8438         * ada-tasks.c (struct ada_tasks_inferior_data)
8439         <task_list_valid_p>: Now bool.
8440         (read_known_tasks, ada_task_list_changed)
8441         (ada_tasks_invalidate_inferior_data): Update.
8442         (read_known_tasks_array): Return bool.
8443         (read_known_tasks_list): Likewise.
8444         (read_known_tasks): Return void.
8445         (ada_build_task_list): Now static.
8446
8447 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8448
8449         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8450         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8451
8452 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8453
8454         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8455         variant for ada_tasks_pspace_data_handle and
8456         ada_tasks_inferior_data_handle.
8457         (ada_tasks_pspace_data_cleanup): New function.
8458         (ada_tasks_inferior_data_cleanup): New function.
8459
8460 2019-02-17  Tom Tromey  <tom@tromey.com>
8461
8462         * macrotab.h (macro_source_fullname): Return a std::string.
8463         * macrotab.c (macro_include, check_for_redefinition)
8464         (macro_undef, macro_lookup_definition, foreach_macro)
8465         (foreach_macro_in_scope): Update.
8466         (macro_source_fullname): Return a std::string.
8467         * macrocmd.c (show_pp_source_pos): Update.
8468
8469 2019-02-17  Tom Tromey  <tom@tromey.com>
8470
8471         * macrocmd.c (show_pp_source_pos): Style the file names.
8472
8473 2019-02-17  Tom Tromey  <tom@tromey.com>
8474
8475         PR tui/24197:
8476         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8477
8478 2019-02-17  Tom Tromey  <tom@tromey.com>
8479
8480         * ada-lang.c (user_select_syms): Use filtered printing.
8481         * utils.c (wrap_style): New global.
8482         (desired_style): Remove.
8483         (emit_style_escape): Add stream parameter.
8484         (set_output_style, reset_terminal_style, prompt_for_continue):
8485         Update.
8486         (flush_wrap_buffer): Only flush gdb_stdout.
8487         (wrap_here): Set wrap_style.
8488         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8489         treat escape sequences as a character.  Change when wrap buffer is
8490         flushed.
8491         (fputs_styled): Do not set the output style when the default is
8492         requested.
8493         * ui-style.h (struct ui_file_style) <is_default>: New method.
8494         * source.c (print_source_lines_base): Emit escape sequences in one
8495         piece.
8496
8497 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8498
8499         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8500         integers and enumeration types.
8501
8502 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8503
8504         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8505         instead of lookup_symbol_in_language
8506         (do_exact_match): New function.
8507         (ada_get_symbol_name_matcher): Return do_exact_match when
8508         doing a verbatim match.
8509
8510 2019-02-15  Tom Tromey  <tromey@adacore.com>
8511
8512         * ravenscar-thread.c (ravenscar_thread_target::resume)
8513         (ravenscar_thread_target::wait): Special case wildcard requests.
8514
8515 2019-02-15  Tom Tromey  <tromey@adacore.com>
8516
8517         * ravenscar-thread.c (base_ptid): Remove.
8518         (struct ravenscar_thread_target) <close>: New method.
8519         <m_base_ptid>: New member.
8520         <update_inferior_ptid, active_task, task_is_currently_active,
8521         runtime_initialized>: Declare methods.
8522         <ravenscar_thread_target>: Add constructor.
8523         (ravenscar_thread_target::task_is_currently_active)
8524         (ravenscar_thread_target::update_inferior_ptid)
8525         (ravenscar_runtime_initialized): Rename.  Now methods.
8526         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8527         (ravenscar_thread_target::update_thread_list): Update.
8528         (ravenscar_thread_target::active_task): Now method.
8529         (ravenscar_thread_target::store_registers)
8530         (ravenscar_thread_target::prepare_to_store)
8531         (ravenscar_thread_target::prepare_to_store)
8532         (ravenscar_thread_target::mourn_inferior): Update.
8533         (ravenscar_inferior_created): Use "new" to create target.
8534         (ravenscar_thread_target::get_ada_task_ptid): Update.
8535         (_initialize_ravenscar): Don't initialize base_ptid.
8536         (ravenscar_ops): Remove global.
8537
8538 2019-02-15  Tom Tromey  <tromey@adacore.com>
8539
8540         * target.h (push_target): Declare new overload.
8541         * target.c (push_target): New overload, taking an rvalue reference.
8542         * remote.c (remote_target::open_1): Use push_target overload.
8543         * corelow.c (core_target_open): Use push_target overload.
8544
8545 2019-02-15  Tom Tromey  <tromey@adacore.com>
8546
8547         * ravenscar-thread.c (is_ravenscar_task)
8548         (ravenscar_task_is_currently_active): Return bool.
8549         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8550         (_initialize_ravenscar): Remove "(void)".
8551         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8552         Return bool.
8553
8554 2019-02-15  Tom Tromey  <tromey@adacore.com>
8555
8556         * ravenscar-thread.c (ravenscar_runtime_initializer)
8557         (has_ravenscar_runtime, get_running_thread_id)
8558         (ravenscar_thread_target::resume): Fix indentation.
8559
8560 2019-02-15  Tom Tromey  <tromey@adacore.com>
8561
8562         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8563         from ravenscar_arch_ops.
8564         (sparc_ravenscar_ops::fetch_registers)
8565         (sparc_ravenscar_ops::store_registers): Now methods.
8566         (sparc_ravenscar_prepare_to_store): Remove.
8567         (sparc_ravenscar_ops): Redefine.
8568         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8569         methods and destructor.  Remove members.
8570         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8571         (ravenscar_thread_target::store_registers)
8572         (ravenscar_thread_target::prepare_to_store): Update.
8573         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8574         Remove.
8575         (struct ppc_ravenscar_powerpc_ops): Derive from
8576         ravenscar_arch_ops.
8577         (ppc_ravenscar_powerpc_ops::fetch_registers)
8578         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8579         (ppc_ravenscar_powerpc_ops): Redefine.
8580         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8581         (ppc_ravenscar_e500_ops::fetch_registers)
8582         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8583         (ppc_ravenscar_e500_ops): Redefine.
8584         * aarch64-ravenscar-thread.c
8585         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8586         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8587         (aarch64_ravenscar_fetch_registers)
8588         (aarch64_ravenscar_store_registers): Now methods.
8589         (aarch64_ravenscar_ops): Redefine.
8590
8591 2019-02-15  Tom Tromey  <tromey@adacore.com>
8592
8593         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8594         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8595         (ravenscar_thread_target::stopped_by_watchpoint)
8596         (ravenscar_thread_target::stopped_data_address)
8597         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8598
8599 2019-02-15  Tom Tromey  <tromey@adacore.com>
8600
8601         * ravenscar-thread.c: Fix some typos.
8602
8603 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8604             Tom Tromey  <tromey@adacore.com>
8605
8606         * ada-lang.c (ada_exception_sal): Change addr_string to a
8607         std::string.
8608         (create_ada_exception_catchpoint): Update.
8609
8610 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8611             Tom Tromey  <tromey@adacore.com>
8612
8613         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8614         (bp_location_ops): Remove.
8615         (base_breakpoint_allocate_location): Update.
8616         (free_bp_location): Update.
8617         * ada-lang.c (class ada_catchpoint_location)
8618         <ada_catchpoint_location>: Remove ops parameter.
8619         (ada_catchpoint_location_dtor): Remove.
8620         (ada_catchpoint_location_ops): Remove.
8621         (allocate_location_exception): Update.
8622         * breakpoint.h (struct bp_location_ops): Remove.
8623         (class bp_location) <bp_location>: Remove bp_location_ops
8624         parameter.
8625         <~bp_location>: Add destructor.
8626         <ops>: Remove.
8627
8628 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8629             Pedro Alves  <palves@redhat.com>
8630
8631         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8632         'PATH_MAX'.
8633
8634 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8635             Samuel Thibault  <samuel.thibault@gnu.org>
8636             Thomas Schwinge  <thomas@codesourcery.com>
8637
8638         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8639         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8640
8641 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8642
8643         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8644         (check_empty): Use "const char *".
8645
8646         * gnu-nat.c (gnu_nat_target::detach): Instead of
8647         'detach_inferior (pid)' call
8648         'detach_inferior (find_inferior_pid (pid))'.
8649
8650         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8651         'nat/fork-inferior.o'.
8652         * gnu-nat.c: #include "nat/fork-inferior.h".
8653
8654         * gnu-nat.c (gnu_nat_target::detach): Instead of
8655         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8656         * gnu-nat.h: #include "inf-child.h".
8657         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8658         'i386_gnu_nat_target::fetch_registers'.
8659         (gnu_store_registers): Rename/move to
8660         'i386_gnu_nat_target::store_registers'.
8661
8662         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8663         * gnu-nat.h (mach_thread_info): New function.
8664         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8665
8666         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8667
8668 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8669
8670         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8671
8672 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8673
8674         * windows-nat.c (windows_add_thread): Add new parameter
8675         "main_thread_p" with default value set to false.  Update
8676         function documentation as well as all callers.
8677         (windows_delete_thread): Likewise.
8678         (fake_create_process): Update call to windows_add_thread.
8679         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8680         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8681         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8682         call to windows_delete_thread.
8683
8684 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8685
8686         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8687
8688 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8689
8690         * symfile.c (find_separate_debug_file): Use canonical path of
8691         sysroot with child_path instead of gdb_sysroot if it is valid.
8692
8693 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8694
8695         * symfile.c (find_separate_debug_file): Use child_path to
8696         determine if an object file is under a sysroot.
8697
8698 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8699
8700         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8701         unittests/child-path-selftests.c.
8702         * common/pathstuff.c (child_path): New function.
8703         * common/pathstuff.h (child_path): New prototype.
8704         * unittests/child-path-selftests.c: New file.
8705
8706 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8707
8708         * symfile.c (find_separate_debug_file): Look for separate debug
8709         files in debug directories under the sysroot.
8710
8711 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8712
8713         * symtab.h (struct minimal_symbol data_p): New const method.
8714         (struct minimal_symbol text_p): Likewise.
8715         * symtab.c (output_source_filename): Use file name style
8716         to print file name.
8717         (print_symbol_info): Likewise.
8718         (print_msymbol_info): Use address style to print addresses.
8719         Use function name style to print executable text symbols.
8720         (expand_symtab_containing_pc): Use data_p.
8721         (find_pc_sect_compunit_symtab): Likewise.
8722
8723 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8724
8725         * breakpoint.c (describe_other_breakpoints): Use address style
8726         to print addresses.
8727         (say_where): Likewise.
8728
8729 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8730
8731         * ada-typeprint.c (print_func_type): Print function name
8732         style to print function name.
8733         * c-typeprint.c (c_print_type_1): Likewise.
8734
8735 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8736
8737         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8738         for execve.
8739
8740 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8741
8742         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8743         type_stack.
8744
8745 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8746
8747         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8748         TYPE_CODE_REF types.
8749
8750 2019-02-08  Jim Wilson  <jimw@sifive.com>
8751
8752         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8753         (riscv_linux_fregset): New.
8754         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8755
8756 2019-02-07  Tom Tromey  <tom@tromey.com>
8757
8758         * thread.c (thread_cancel_execution_command): Update.
8759         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8760         methods.
8761         (struct thread_fsm_ops): Remove.
8762         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8763         (thread_fsm_should_stop, thread_fsm_return_value)
8764         (thread_fsm_set_finished, thread_fsm_finished_p)
8765         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8766         Don't declare.
8767         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8768         * infrun.c (clear_proceed_status_thread)
8769         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8770         (print_stop_event): Update.
8771         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8772         Add constructor.
8773         (step_command_fsm_ops): Remove.
8774         (new_step_command_fsm): Remove.
8775         (step_1): Update.
8776         (step_command_fsm::should_stop): Rename from
8777         step_command_fsm_should_stop.
8778         (step_command_fsm::clean_up): Rename from
8779         step_command_fsm_clean_up.
8780         (step_command_fsm::do_async_reply_reason): Rename from
8781         step_command_fsm_async_reply_reason.
8782         (struct until_next_fsm): Inherit from thread_fsm.  Add
8783         constructor.
8784         (until_next_fsm_ops): Remove.
8785         (new_until_next_fsm): Remove.
8786         (until_next_fsm::should_stop): Rename from
8787         until_next_fsm_should_stop.
8788         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8789         (until_next_fsm::do_async_reply_reason): Rename from
8790         until_next_fsm_async_reply_reason.
8791         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8792         constructor.  Change type of breakpoint.
8793         (finish_command_fsm_ops): Remove.
8794         (new_finish_command_fsm): Remove.
8795         (finish_command_fsm::should_stop): Rename from
8796         finish_command_fsm_should_stop.
8797         (finish_command_fsm::clean_up): Rename from
8798         finish_command_fsm_clean_up.
8799         (finish_command_fsm::return_value): Rename from
8800         finish_command_fsm_return_value.
8801         (finish_command_fsm::do_async_reply_reason): Rename from
8802         finish_command_fsm_async_reply_reason.
8803         (finish_command): Update.
8804         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8805         Add constructor.
8806         (call_thread_fsm_ops): Remove.
8807         (call_thread_fsm::call_thread_fsm): Rename from
8808         new_call_thread_fsm.
8809         (call_thread_fsm::should_stop): Rename from
8810         call_thread_fsm_should_stop.
8811         (call_thread_fsm::should_notify_stop): Rename from
8812         call_thread_fsm_should_notify_stop.
8813         (run_inferior_call, call_function_by_hand_dummy): Update.
8814         * cli/cli-interp.c (should_print_stop_to_console): Update.
8815         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8816         Add constructor.  Change type of location_breakpoint,
8817         caller_breakpoint.
8818         (until_break_fsm_ops): Remove.
8819         (new_until_break_fsm): Remove.
8820         (until_break_fsm::should_stop): Rename from
8821         until_break_fsm_should_stop.
8822         (until_break_fsm::clean_up): Rename from
8823         until_break_fsm_clean_up.
8824         (until_break_fsm::do_async_reply_reason): Rename from
8825         until_break_fsm_async_reply_reason.
8826         (until_break_command): Update.
8827         * thread-fsm.c: Remove.
8828         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8829
8830 2019-02-07  Tom Tromey  <tom@tromey.com>
8831
8832         * yy-remap.h: Add include guard.
8833         * xtensa-tdep.h: Add include guard.
8834         * xcoffread.h: Rename include guard.
8835         * varobj-iter.h: Add include guard.
8836         * tui/tui.h: Rename include guard.
8837         * tui/tui-winsource.h: Rename include guard.
8838         * tui/tui-wingeneral.h: Rename include guard.
8839         * tui/tui-windata.h: Rename include guard.
8840         * tui/tui-win.h: Rename include guard.
8841         * tui/tui-stack.h: Rename include guard.
8842         * tui/tui-source.h: Rename include guard.
8843         * tui/tui-regs.h: Rename include guard.
8844         * tui/tui-out.h: Rename include guard.
8845         * tui/tui-layout.h: Rename include guard.
8846         * tui/tui-io.h: Rename include guard.
8847         * tui/tui-hooks.h: Rename include guard.
8848         * tui/tui-file.h: Rename include guard.
8849         * tui/tui-disasm.h: Rename include guard.
8850         * tui/tui-data.h: Rename include guard.
8851         * tui/tui-command.h: Rename include guard.
8852         * tic6x-tdep.h: Add include guard.
8853         * target/waitstatus.h: Rename include guard.
8854         * target/wait.h: Rename include guard.
8855         * target/target.h: Rename include guard.
8856         * target/resume.h: Rename include guard.
8857         * target-float.h: Rename include guard.
8858         * stabsread.h: Add include guard.
8859         * rs6000-tdep.h: Add include guard.
8860         * riscv-fbsd-tdep.h: Add include guard.
8861         * regformats/regdef.h: Rename include guard.
8862         * record.h: Rename include guard.
8863         * python/python.h: Rename include guard.
8864         * python/python-internal.h: Rename include guard.
8865         * python/py-stopevent.h: Rename include guard.
8866         * python/py-ref.h: Rename include guard.
8867         * python/py-record.h: Rename include guard.
8868         * python/py-record-full.h: Rename include guard.
8869         * python/py-record-btrace.h: Rename include guard.
8870         * python/py-instruction.h: Rename include guard.
8871         * python/py-events.h: Rename include guard.
8872         * python/py-event.h: Rename include guard.
8873         * procfs.h: Add include guard.
8874         * proc-utils.h: Add include guard.
8875         * p-lang.h: Add include guard.
8876         * or1k-tdep.h: Rename include guard.
8877         * observable.h: Rename include guard.
8878         * nto-tdep.h: Rename include guard.
8879         * nat/x86-linux.h: Rename include guard.
8880         * nat/x86-linux-dregs.h: Rename include guard.
8881         * nat/x86-gcc-cpuid.h: Add include guard.
8882         * nat/x86-dregs.h: Rename include guard.
8883         * nat/x86-cpuid.h: Rename include guard.
8884         * nat/ppc-linux.h: Rename include guard.
8885         * nat/mips-linux-watch.h: Rename include guard.
8886         * nat/linux-waitpid.h: Rename include guard.
8887         * nat/linux-ptrace.h: Rename include guard.
8888         * nat/linux-procfs.h: Rename include guard.
8889         * nat/linux-osdata.h: Rename include guard.
8890         * nat/linux-nat.h: Rename include guard.
8891         * nat/linux-namespaces.h: Rename include guard.
8892         * nat/linux-btrace.h: Rename include guard.
8893         * nat/glibc_thread_db.h: Rename include guard.
8894         * nat/gdb_thread_db.h: Rename include guard.
8895         * nat/gdb_ptrace.h: Rename include guard.
8896         * nat/fork-inferior.h: Rename include guard.
8897         * nat/amd64-linux-siginfo.h: Rename include guard.
8898         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8899         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8900         * nat/aarch64-linux.h: Rename include guard.
8901         * nat/aarch64-linux-hw-point.h: Rename include guard.
8902         * mn10300-tdep.h: Add include guard.
8903         * mips-linux-tdep.h: Add include guard.
8904         * mi/mi-parse.h: Rename include guard.
8905         * mi/mi-out.h: Rename include guard.
8906         * mi/mi-main.h: Rename include guard.
8907         * mi/mi-interp.h: Rename include guard.
8908         * mi/mi-getopt.h: Rename include guard.
8909         * mi/mi-console.h: Rename include guard.
8910         * mi/mi-common.h: Rename include guard.
8911         * mi/mi-cmds.h: Rename include guard.
8912         * mi/mi-cmd-break.h: Rename include guard.
8913         * m2-lang.h: Add include guard.
8914         * location.h: Rename include guard.
8915         * linux-record.h: Rename include guard.
8916         * linux-nat.h: Add include guard.
8917         * linux-fork.h: Add include guard.
8918         * i386-darwin-tdep.h: Rename include guard.
8919         * hppa-linux-offsets.h: Add include guard.
8920         * guile/guile.h: Rename include guard.
8921         * guile/guile-internal.h: Rename include guard.
8922         * gnu-nat.h: Rename include guard.
8923         * gdb-stabs.h: Rename include guard.
8924         * frv-tdep.h: Add include guard.
8925         * f-lang.h: Add include guard.
8926         * event-loop.h: Add include guard.
8927         * darwin-nat.h: Rename include guard.
8928         * cp-abi.h: Rename include guard.
8929         * config/sparc/nm-sol2.h: Rename include guard.
8930         * config/nm-nto.h: Rename include guard.
8931         * config/nm-linux.h: Add include guard.
8932         * config/i386/nm-i386gnu.h: Rename include guard.
8933         * config/djgpp/nl_types.h: Rename include guard.
8934         * config/djgpp/langinfo.h: Rename include guard.
8935         * compile/gcc-cp-plugin.h: Add include guard.
8936         * compile/gcc-c-plugin.h: Add include guard.
8937         * compile/compile.h: Rename include guard.
8938         * compile/compile-object-run.h: Rename include guard.
8939         * compile/compile-object-load.h: Rename include guard.
8940         * compile/compile-internal.h: Rename include guard.
8941         * compile/compile-cplus.h: Rename include guard.
8942         * compile/compile-c.h: Rename include guard.
8943         * common/xml-utils.h: Rename include guard.
8944         * common/x86-xstate.h: Rename include guard.
8945         * common/version.h: Rename include guard.
8946         * common/vec.h: Rename include guard.
8947         * common/tdesc.h: Rename include guard.
8948         * common/selftest.h: Rename include guard.
8949         * common/scoped_restore.h: Rename include guard.
8950         * common/scoped_mmap.h: Rename include guard.
8951         * common/scoped_fd.h: Rename include guard.
8952         * common/safe-iterator.h: Rename include guard.
8953         * common/run-time-clock.h: Rename include guard.
8954         * common/refcounted-object.h: Rename include guard.
8955         * common/queue.h: Rename include guard.
8956         * common/ptid.h: Rename include guard.
8957         * common/print-utils.h: Rename include guard.
8958         * common/preprocessor.h: Rename include guard.
8959         * common/pathstuff.h: Rename include guard.
8960         * common/observable.h: Rename include guard.
8961         * common/netstuff.h: Rename include guard.
8962         * common/job-control.h: Rename include guard.
8963         * common/host-defs.h: Rename include guard.
8964         * common/gdb_wait.h: Rename include guard.
8965         * common/gdb_vecs.h: Rename include guard.
8966         * common/gdb_unlinker.h: Rename include guard.
8967         * common/gdb_unique_ptr.h: Rename include guard.
8968         * common/gdb_tilde_expand.h: Rename include guard.
8969         * common/gdb_sys_time.h: Rename include guard.
8970         * common/gdb_string_view.h: Rename include guard.
8971         * common/gdb_splay_tree.h: Rename include guard.
8972         * common/gdb_setjmp.h: Rename include guard.
8973         * common/gdb_ref_ptr.h: Rename include guard.
8974         * common/gdb_optional.h: Rename include guard.
8975         * common/gdb_locale.h: Rename include guard.
8976         * common/gdb_assert.h: Rename include guard.
8977         * common/filtered-iterator.h: Rename include guard.
8978         * common/filestuff.h: Rename include guard.
8979         * common/fileio.h: Rename include guard.
8980         * common/environ.h: Rename include guard.
8981         * common/common-utils.h: Rename include guard.
8982         * common/common-types.h: Rename include guard.
8983         * common/common-regcache.h: Rename include guard.
8984         * common/common-inferior.h: Rename include guard.
8985         * common/common-gdbthread.h: Rename include guard.
8986         * common/common-exceptions.h: Rename include guard.
8987         * common/common-defs.h: Rename include guard.
8988         * common/common-debug.h: Rename include guard.
8989         * common/cleanups.h: Rename include guard.
8990         * common/buffer.h: Rename include guard.
8991         * common/btrace-common.h: Rename include guard.
8992         * common/break-common.h: Rename include guard.
8993         * cli/cli-utils.h: Rename include guard.
8994         * cli/cli-style.h: Rename include guard.
8995         * cli/cli-setshow.h: Rename include guard.
8996         * cli/cli-script.h: Rename include guard.
8997         * cli/cli-interp.h: Rename include guard.
8998         * cli/cli-decode.h: Rename include guard.
8999         * cli/cli-cmds.h: Rename include guard.
9000         * charset-list.h: Add include guard.
9001         * buildsym-legacy.h: Rename include guard.
9002         * bfin-tdep.h: Add include guard.
9003         * ax.h: Rename include guard.
9004         * arm-linux-tdep.h: Add include guard.
9005         * arm-fbsd-tdep.h: Add include guard.
9006         * arch/xtensa.h: Rename include guard.
9007         * arch/tic6x.h: Add include guard.
9008         * arch/i386.h: Add include guard.
9009         * arch/arm.h: Rename include guard.
9010         * arch/arm-linux.h: Rename include guard.
9011         * arch/arm-get-next-pcs.h: Rename include guard.
9012         * arch/amd64.h: Add include guard.
9013         * arch/aarch64-insn.h: Rename include guard.
9014         * arch-utils.h: Rename include guard.
9015         * annotate.h: Add include guard.
9016         * amd64-darwin-tdep.h: Rename include guard.
9017         * aarch64-linux-tdep.h: Add include guard.
9018         * aarch64-fbsd-tdep.h: Add include guard.
9019         * aarch32-linux-nat.h: Add include guard.
9020
9021 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9022
9023         * macrotab.c (macro_define_internal): New function that
9024         factorizes macro_define_object_internal and macro_define_function
9025         code.
9026         (macro_define_object_internal): Use macro_define_internal.
9027         (macro_define_function): Likewise.
9028
9029 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9030
9031         * macrocmd.c (extract_identifier): Return
9032         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9033         callers.
9034
9035 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9036
9037         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9038
9039 2019-02-05  Tom Tromey  <tom@tromey.com>
9040
9041         * target.c (target_stack::unpush): Move assertion earlier.
9042
9043 2019-01-30  Tom Tromey  <tom@tromey.com>
9044
9045         PR python/23615:
9046         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9047         (gdbpy_parse_and_eval): Likewise.
9048         * python/python-internal.h (gdbpy_allow_threads): New class.
9049
9050 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9051
9052         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9053         (aarch64_fbsd_fpregmap): Move earlier.
9054         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9055         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9056         instead of individual calls to trad_frame_set_reg_addr.
9057         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9058         earlier.
9059         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9060         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9061         instead of individual calls to trad_frame_set_reg_addr.
9062
9063 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9064
9065         * CONTRIBUTE: Replace contribution list with wiki link.
9066
9067 2019-01-25  Tom Tromey  <tom@tromey.com>
9068
9069         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9070
9071 2019-01-25  Tom Tromey  <tom@tromey.com>
9072
9073         * xtensa-linux-nat.c: Fix common/ includes.
9074         * xml-support.h: Fix common/ includes.
9075         * xml-support.c: Fix common/ includes.
9076         * x86-linux-nat.c: Fix common/ includes.
9077         * windows-nat.c: Fix common/ includes.
9078         * varobj.h: Fix common/ includes.
9079         * varobj.c: Fix common/ includes.
9080         * value.c: Fix common/ includes.
9081         * valops.c: Fix common/ includes.
9082         * utils.c: Fix common/ includes.
9083         * unittests/xml-utils-selftests.c: Fix common/ includes.
9084         * unittests/utils-selftests.c: Fix common/ includes.
9085         * unittests/unpack-selftests.c: Fix common/ includes.
9086         * unittests/tracepoint-selftests.c: Fix common/ includes.
9087         * unittests/style-selftests.c: Fix common/ includes.
9088         * unittests/string_view-selftests.c: Fix common/ includes.
9089         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9090         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9091         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9092         * unittests/rsp-low-selftests.c: Fix common/ includes.
9093         * unittests/parse-connection-spec-selftests.c: Fix common/
9094         includes.
9095         * unittests/optional-selftests.c: Fix common/ includes.
9096         * unittests/offset-type-selftests.c: Fix common/ includes.
9097         * unittests/observable-selftests.c: Fix common/ includes.
9098         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9099         * unittests/memrange-selftests.c: Fix common/ includes.
9100         * unittests/memory-map-selftests.c: Fix common/ includes.
9101         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9102         * unittests/function-view-selftests.c: Fix common/ includes.
9103         * unittests/environ-selftests.c: Fix common/ includes.
9104         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9105         * unittests/common-utils-selftests.c: Fix common/ includes.
9106         * unittests/cli-utils-selftests.c: Fix common/ includes.
9107         * unittests/array-view-selftests.c: Fix common/ includes.
9108         * ui-file.c: Fix common/ includes.
9109         * tui/tui-io.c: Fix common/ includes.
9110         * tracepoint.h: Fix common/ includes.
9111         * tracepoint.c: Fix common/ includes.
9112         * tracefile-tfile.c: Fix common/ includes.
9113         * top.h: Fix common/ includes.
9114         * top.c: Fix common/ includes.
9115         * thread.c: Fix common/ includes.
9116         * target/waitstatus.h: Fix common/ includes.
9117         * target/waitstatus.c: Fix common/ includes.
9118         * target.h: Fix common/ includes.
9119         * target.c: Fix common/ includes.
9120         * target-memory.c: Fix common/ includes.
9121         * target-descriptions.c: Fix common/ includes.
9122         * symtab.h: Fix common/ includes.
9123         * symfile.c: Fix common/ includes.
9124         * stap-probe.c: Fix common/ includes.
9125         * spu-linux-nat.c: Fix common/ includes.
9126         * sparc-nat.c: Fix common/ includes.
9127         * source.c: Fix common/ includes.
9128         * solib.c: Fix common/ includes.
9129         * solib-target.c: Fix common/ includes.
9130         * ser-unix.c: Fix common/ includes.
9131         * ser-tcp.c: Fix common/ includes.
9132         * ser-pipe.c: Fix common/ includes.
9133         * ser-base.c: Fix common/ includes.
9134         * selftest-arch.c: Fix common/ includes.
9135         * s12z-tdep.c: Fix common/ includes.
9136         * rust-exp.y: Fix common/ includes.
9137         * rs6000-aix-tdep.c: Fix common/ includes.
9138         * riscv-tdep.c: Fix common/ includes.
9139         * remote.c: Fix common/ includes.
9140         * remote-notif.h: Fix common/ includes.
9141         * remote-fileio.h: Fix common/ includes.
9142         * remote-fileio.c: Fix common/ includes.
9143         * regcache.h: Fix common/ includes.
9144         * regcache.c: Fix common/ includes.
9145         * record-btrace.c: Fix common/ includes.
9146         * python/python.c: Fix common/ includes.
9147         * python/py-type.c: Fix common/ includes.
9148         * python/py-inferior.c: Fix common/ includes.
9149         * progspace.h: Fix common/ includes.
9150         * producer.c: Fix common/ includes.
9151         * procfs.c: Fix common/ includes.
9152         * proc-api.c: Fix common/ includes.
9153         * printcmd.c: Fix common/ includes.
9154         * ppc-linux-nat.c: Fix common/ includes.
9155         * parser-defs.h: Fix common/ includes.
9156         * osdata.c: Fix common/ includes.
9157         * obsd-nat.c: Fix common/ includes.
9158         * nat/x86-linux.c: Fix common/ includes.
9159         * nat/x86-linux-dregs.c: Fix common/ includes.
9160         * nat/x86-dregs.h: Fix common/ includes.
9161         * nat/x86-dregs.c: Fix common/ includes.
9162         * nat/ppc-linux.c: Fix common/ includes.
9163         * nat/mips-linux-watch.h: Fix common/ includes.
9164         * nat/mips-linux-watch.c: Fix common/ includes.
9165         * nat/linux-waitpid.c: Fix common/ includes.
9166         * nat/linux-ptrace.h: Fix common/ includes.
9167         * nat/linux-ptrace.c: Fix common/ includes.
9168         * nat/linux-procfs.c: Fix common/ includes.
9169         * nat/linux-personality.c: Fix common/ includes.
9170         * nat/linux-osdata.c: Fix common/ includes.
9171         * nat/linux-namespaces.c: Fix common/ includes.
9172         * nat/linux-btrace.h: Fix common/ includes.
9173         * nat/linux-btrace.c: Fix common/ includes.
9174         * nat/fork-inferior.c: Fix common/ includes.
9175         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9176         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9177         * nat/aarch64-linux.c: Fix common/ includes.
9178         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9179         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9180         * namespace.h: Fix common/ includes.
9181         * mips-linux-tdep.c: Fix common/ includes.
9182         * minsyms.c: Fix common/ includes.
9183         * mi/mi-parse.h: Fix common/ includes.
9184         * mi/mi-main.c: Fix common/ includes.
9185         * mi/mi-cmd-env.c: Fix common/ includes.
9186         * memrange.h: Fix common/ includes.
9187         * memattr.c: Fix common/ includes.
9188         * maint.h: Fix common/ includes.
9189         * maint.c: Fix common/ includes.
9190         * main.c: Fix common/ includes.
9191         * machoread.c: Fix common/ includes.
9192         * location.c: Fix common/ includes.
9193         * linux-thread-db.c: Fix common/ includes.
9194         * linux-nat.c: Fix common/ includes.
9195         * linux-fork.c: Fix common/ includes.
9196         * inline-frame.c: Fix common/ includes.
9197         * infrun.c: Fix common/ includes.
9198         * inflow.c: Fix common/ includes.
9199         * inferior.h: Fix common/ includes.
9200         * inferior.c: Fix common/ includes.
9201         * infcmd.c: Fix common/ includes.
9202         * inf-ptrace.c: Fix common/ includes.
9203         * inf-child.c: Fix common/ includes.
9204         * ia64-linux-nat.c: Fix common/ includes.
9205         * i387-tdep.c: Fix common/ includes.
9206         * i386-tdep.c: Fix common/ includes.
9207         * i386-linux-tdep.c: Fix common/ includes.
9208         * i386-linux-nat.c: Fix common/ includes.
9209         * i386-go32-tdep.c: Fix common/ includes.
9210         * i386-fbsd-tdep.c: Fix common/ includes.
9211         * i386-fbsd-nat.c: Fix common/ includes.
9212         * guile/scm-type.c: Fix common/ includes.
9213         * guile/guile.c: Fix common/ includes.
9214         * go32-nat.c: Fix common/ includes.
9215         * gnu-nat.c: Fix common/ includes.
9216         * gdbthread.h: Fix common/ includes.
9217         * gdbarch-selftests.c: Fix common/ includes.
9218         * gdb_usleep.c: Fix common/ includes.
9219         * gdb_select.h: Fix common/ includes.
9220         * gdb_bfd.c: Fix common/ includes.
9221         * gcore.c: Fix common/ includes.
9222         * fork-child.c: Fix common/ includes.
9223         * findvar.c: Fix common/ includes.
9224         * fbsd-nat.c: Fix common/ includes.
9225         * event-top.c: Fix common/ includes.
9226         * event-loop.c: Fix common/ includes.
9227         * dwarf2read.c: Fix common/ includes.
9228         * dwarf2loc.c: Fix common/ includes.
9229         * dwarf2-frame.c: Fix common/ includes.
9230         * dwarf-index-cache.c: Fix common/ includes.
9231         * dtrace-probe.c: Fix common/ includes.
9232         * disasm-selftests.c: Fix common/ includes.
9233         * defs.h: Fix common/ includes.
9234         * csky-tdep.c: Fix common/ includes.
9235         * cp-valprint.c: Fix common/ includes.
9236         * cp-support.h: Fix common/ includes.
9237         * cp-support.c: Fix common/ includes.
9238         * corelow.c: Fix common/ includes.
9239         * completer.h: Fix common/ includes.
9240         * completer.c: Fix common/ includes.
9241         * compile/compile.c: Fix common/ includes.
9242         * compile/compile-loc2c.c: Fix common/ includes.
9243         * compile/compile-cplus-types.c: Fix common/ includes.
9244         * compile/compile-cplus-symbols.c: Fix common/ includes.
9245         * command.h: Fix common/ includes.
9246         * cli/cli-dump.c: Fix common/ includes.
9247         * cli/cli-cmds.c: Fix common/ includes.
9248         * charset.c: Fix common/ includes.
9249         * build-id.c: Fix common/ includes.
9250         * btrace.h: Fix common/ includes.
9251         * btrace.c: Fix common/ includes.
9252         * breakpoint.h: Fix common/ includes.
9253         * breakpoint.c: Fix common/ includes.
9254         * ax.h:
9255         (enum agent_op): Fix common/ includes.
9256         * ax-general.c (struct aop_map): Fix common/ includes.
9257         * ax-gdb.c: Fix common/ includes.
9258         * auxv.c: Fix common/ includes.
9259         * auto-load.c: Fix common/ includes.
9260         * arm-tdep.c: Fix common/ includes.
9261         * arch/riscv.c: Fix common/ includes.
9262         * arch/ppc-linux-common.c: Fix common/ includes.
9263         * arch/i386.c: Fix common/ includes.
9264         * arch/arm.c: Fix common/ includes.
9265         * arch/arm-linux.c: Fix common/ includes.
9266         * arch/arm-get-next-pcs.c: Fix common/ includes.
9267         * arch/amd64.c: Fix common/ includes.
9268         * arch/aarch64.c: Fix common/ includes.
9269         * arch/aarch64-insn.c: Fix common/ includes.
9270         * arch-utils.c: Fix common/ includes.
9271         * amd64-windows-tdep.c: Fix common/ includes.
9272         * amd64-tdep.c: Fix common/ includes.
9273         * amd64-sol2-tdep.c: Fix common/ includes.
9274         * amd64-obsd-tdep.c: Fix common/ includes.
9275         * amd64-nbsd-tdep.c: Fix common/ includes.
9276         * amd64-linux-tdep.c: Fix common/ includes.
9277         * amd64-linux-nat.c: Fix common/ includes.
9278         * amd64-fbsd-tdep.c: Fix common/ includes.
9279         * amd64-fbsd-nat.c: Fix common/ includes.
9280         * amd64-dicos-tdep.c: Fix common/ includes.
9281         * amd64-darwin-tdep.c: Fix common/ includes.
9282         * agent.c: Fix common/ includes.
9283         * ada-lang.h: Fix common/ includes.
9284         * ada-lang.c: Fix common/ includes.
9285         * aarch64-tdep.c: Fix common/ includes.
9286
9287 2019-01-25  Tom Tromey  <tom@tromey.com>
9288
9289         * common/create-version.sh: Use common/version.h.
9290
9291 2019-01-24  Pedro Alves  <palves@redhat.com>
9292
9293         * infrun.c (signal_stop, signal_print, signal_program)
9294         (signal_catch, signal_pass): Now arrays instead of pointers.
9295         (update_signals_program_target, do_target_resume)
9296         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9297         * linux-nat.c (linux_nat_target::pass_signals)
9298         (linux_nat_target::create_inferior, linux_nat_target::attach):
9299         Adjust.
9300         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9301         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9302         * procfs.c (procfs_target::pass_signals): Adjust.
9303         * record-full.c (record_full_target::resume): Adjust.
9304         * remote.c (remote_target::pass_signals)
9305         (remote_target::program_signals): Adjust.
9306         * target-debug.h (target_debug_print_signals): Now takes a
9307         gdb::array_view as parameter.  Adjust.
9308         * target.h (target_ops) <pass_signals, program_signals>: Replace
9309         pointer and length parameters with gdb::array_view.
9310         (target_pass_signals, target_program_signals): Likewise.
9311         * target-delegates.c: Regenerate.
9312
9313 2019-01-24  Pedro Alves  <palves@redhat.com>
9314
9315         * common/forward-scope-exit.h
9316         (forward_scope_exit::forward_scope_exit): Pass arguments to
9317         m_bind_function directly, instead of creating a std::bind and
9318         copying that.
9319
9320 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9321
9322         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9323         for static members.
9324         (pass_in_v_vfp_candidate): Likewise.
9325
9326 2019-01-23  Tom Tromey  <tom@tromey.com>
9327             Pedro Alves  <palves@redhat.com>
9328
9329         * regcache.c (class regcache_invalidator): Remove.
9330         (regcache::raw_write): Use make_scope_exit.
9331
9332 2019-01-23  Tom Tromey  <tom@tromey.com>
9333
9334         * ui-out.h (class ui_out_emit_type): Update comment.
9335
9336 2019-01-23  Tom Tromey  <tom@tromey.com>
9337
9338         * infrun.c (fetch_inferior_event): Update comment.
9339
9340 2019-01-23  Tom Tromey  <tom@tromey.com>
9341             Pedro Alves  <palves@redhat.com>
9342
9343         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9344         parameter.
9345         (fetch_inferior_event): Use SCOPE_EXIT.
9346
9347
9348 2019-01-23  Tom Tromey  <tom@tromey.com>
9349             Pedro Alves  <palves@redhat.com>
9350
9351         * infrun.c (disable_thread_events): Delete.
9352         (stop_all_threads): Use SCOPE_EXIT.
9353
9354 2019-01-23  Tom Tromey  <tom@tromey.com>
9355             Pedro Alves  <palves@redhat.com>
9356
9357         * symfile.c: Include forward-scope-exit.h.
9358         (clear_symtab_users_cleanup): Replace forward declaration with
9359         a FORWARD_SCOPE_EXIT.
9360         (syms_from_objfile_1): Use the forward_scope_exit and
9361         gdb::optional instead of cleanup_function.
9362         (reread_symbols): Use the forward_scope_exit instead of
9363         cleanup_function.
9364         (clear_symtab_users_cleanup): Remove function.
9365
9366 2019-01-23  Tom Tromey  <tom@tromey.com>
9367             Pedro Alves  <palves@redhat.com>
9368
9369         * linux-nat.c: Include scope-exit.h.
9370         (cleanup_target_stop): Remove.
9371         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9372         SCOPE_EXIT.
9373
9374 2019-01-23  Tom Tromey  <tom@tromey.com>
9375             Pedro Alves  <palves@redhat.com>
9376
9377         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9378         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9379
9380 2019-01-23  Tom Tromey  <tom@tromey.com>
9381             Andrew Burgess  <andrew.burgess@embecosm.com>
9382             Pedro Alves  <palves@redhat.com>
9383
9384         * infrun.c (fetch_inferior_event): Use scope_exit.
9385         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9386         * top.c (execute_command): Use scope_exit.
9387         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9388         * utils.c (do_bpstat_clear_actions_cleanup)
9389         (make_bpstat_clear_actions_cleanup): Remove.
9390
9391 2019-01-23  Tom Tromey  <tom@tromey.com>
9392             Pedro Alves  <palves@redhat.com>
9393
9394         * infrun.c: Include "common/scope-exit.h"
9395         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9396         (wait_for_inferior): Use SCOPE_EXIT.
9397         (fetch_inferior_event): Use scope_exit.
9398
9399 2019-01-23  Tom Tromey  <tom@tromey.com>
9400             Pedro Alves  <palves@redhat.com>
9401
9402         * breakpoint.c (create_breakpoint): Remove cleanup.
9403
9404 2019-01-23  Tom Tromey  <tom@tromey.com>
9405             Andrew Burgess  <andrew.burgess@embecosm.com>
9406             Pedro Alves  <palves@redhat.com>
9407
9408 2019-01-23  Pedro Alves  <palves@redhat.com>
9409
9410         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9411
9412 2019-01-23  Pedro Alves  <palves@redhat.com>
9413             Andrew Burgess  <andrew.burgess@embecosm.com>
9414
9415         * gdbthread.h: Include "common/forward-scope-exit.h".
9416         (scoped_finish_thread_state): Redefine custom class in terms of
9417         forward_scope_exit.
9418
9419 2019-01-23  Pedro Alves  <palves@redhat.com>
9420             Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * common/forward-scope-exit.h: New file.
9423
9424 2019-01-23  Pedro Alves  <palves@redhat.com>
9425             Andrew Burgess  <andrew.burgess@embecosm.com>
9426             Tom Tromey  <tom@tromey.com>
9427
9428         * common/scope-exit.h: New file.
9429
9430 2019-01-23  Pedro Alves  <palves@redhat.com>
9431
9432         * common/preprocessor.h (ESC): Rename to ...
9433         (ESC_PARENS): ... this.
9434         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9435         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9436
9437 2019-01-23  Tom Tromey  <tom@tromey.com>
9438
9439         * language.h (class scoped_switch_to_sym_language_if_auto):
9440         Initialize m_lang in both cases.
9441
9442 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9443
9444         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9445         with XCNEW.
9446
9447 2019-01-22  Tom Tromey  <tom@tromey.com>
9448
9449         * corelow.c: Do not include sys/file.h.
9450
9451 2019-01-22  Tom Tromey  <tom@tromey.com>
9452
9453         * tui/tui-wingeneral.h: Include gdb_curses.h.
9454
9455 2019-01-22  Tom Tromey  <tom@tromey.com>
9456
9457         * source-cache.h (class source_cache) <get_source_lines,
9458         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9459
9460 2019-01-22  Tom Tromey  <tom@tromey.com>
9461
9462         * remote-fileio.h (struct remote_target): Declare.
9463
9464 2019-01-22  Tom Tromey  <tom@tromey.com>
9465
9466         * python/py-arch.c: Do not include py-ref.h.
9467         * python/py-bpevent.c: Do not include py-ref.h.
9468         * python/py-cmd.c: Do not include py-ref.h.
9469         * python/py-continueevent.c: Do not include py-ref.h.
9470         * python/py-event.h: Do not include py-ref.h.
9471         * python/py-evtregistry.c: Do not include py-ref.h.
9472         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9473         * python/py-frame.c: Do not include py-ref.h.
9474         * python/py-framefilter.c: Do not include py-ref.h.
9475         * python/py-function.c: Do not include py-ref.h.
9476         * python/py-infevents.c: Do not include py-ref.h.
9477         * python/py-linetable.c: Do not include py-ref.h.
9478         * python/py-objfile.c: Do not include py-ref.h.
9479         * python/py-param.c: Do not include py-ref.h.
9480         * python/py-prettyprint.c: Do not include py-ref.h.
9481         * python/py-progspace.c: Do not include py-ref.h.
9482         * python/py-symbol.c: Do not include py-ref.h.
9483         * python/py-symtab.c: Do not include py-ref.h.
9484         * python/py-type.c: Do not include py-ref.h.
9485         * python/py-unwind.c: Do not include py-ref.h.
9486         * python/py-utils.c: Do not include py-ref.h.
9487         * python/py-value.c: Do not include py-ref.h.
9488         * python/py-varobj.c: Do not include py-ref.h.
9489         * python/py-xmethods.c: Do not include py-ref.h.
9490         * python/python.c: Do not include py-ref.h.
9491         * varobj.c: Do not include py-ref.h.
9492
9493 2019-01-22  Tom Tromey  <tom@tromey.com>
9494
9495         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9496         keyword for bcache.
9497
9498 2019-01-22  Tom Tromey  <tom@tromey.com>
9499
9500         * compile/compile-cplus-types.c: Remove a comment by #include.
9501
9502 2019-01-22  Tom Tromey  <tom@tromey.com>
9503
9504         * compile/gcc-c-plugin.h: Include compile-internal.h.
9505
9506 2019-01-22  Tom Tromey  <tom@tromey.com>
9507
9508         * stabsread.c (EXTERN): Do not define.
9509         (symnum, next_symbol_text_func, processing_gcc_compilation)
9510         (within_function, global_sym_chain, global_stabs)
9511         (previous_stab_code, this_object_header_files)
9512         (n_this_object_header_files)
9513         (n_allocated_this_object_header_files): Define.
9514         * stabsread.h (EXTERN): Never define.  Use "extern".
9515
9516 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9517
9518         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9519         history_value.
9520
9521 2019-01-21  Tom Tromey  <tom@tromey.com>
9522
9523         * ui-out.c: Fix includes.
9524         * tui/tui-source.c: Fix includes.
9525         * target.c: Fix includes.
9526         * remote.c: Fix includes.
9527         * regcache.c: Fix includes.
9528         * python/py-block.c: Fix includes.
9529         * printcmd.c: Fix includes.
9530         * or1k-tdep.c: Fix includes.
9531         * mi/mi-main.c: Fix includes.
9532         * m32r-tdep.c: Fix includes.
9533         * csky-tdep.c: Fix includes.
9534         * compile/compile-cplus-types.c: Fix includes.
9535         * cli/cli-interp.c: Fix includes.
9536
9537 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9538
9539         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9540         for padding.
9541
9542 2019-01-16  Tom Tromey  <tom@tromey.com>
9543
9544         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9545         earlier.
9546         (struct objfile) <msymbols_range>: Move from top level.
9547         <msymbols>: New method.
9548         (class objfile_msymbols): Remove.
9549         * symtab.c (default_collect_symbol_completion_matches_break_on):
9550         Update.
9551         * symmisc.c (dump_msymbols): Update.
9552         * stabsread.c (scan_file_globals): Update.
9553         * objc-lang.c (info_selectors_command, info_classes_command)
9554         (find_methods): Update.
9555         * minsyms.c (find_solib_trampoline_target): Update.
9556         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9557         * coffread.c (coff_symfile_read): Update.
9558         * ada-lang.c (ada_lookup_simple_minsym)
9559         (ada_collect_symbol_completion_matches): Update.
9560
9561 2019-01-16  Tom Tromey  <tom@tromey.com>
9562
9563         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9564         type.  Remove no-argument constructor.
9565         <iterator::operator++>: Simplify.
9566         <begin>: Update.
9567         <end>: Use minimal_symbol_count.
9568
9569 2019-01-16  Tom Tromey  <tom@tromey.com>
9570
9571         * objfiles.h (struct objfile) <psymtabs>: New method.
9572         (class objfile_psymtabs): Remove.
9573         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9574         typedef.
9575         <range>: New method.
9576         (require_partial_symbols): Change return type.
9577         * psymtab.c (require_partial_symbols)
9578         (psym_expand_symtabs_matching): Update.
9579         * mdebugread.c (parse_partial_symbols): Update.
9580         * dbxread.c (dbx_end_psymtab): Update.
9581
9582 2019-01-15  Tom Tromey  <tom@tromey.com>
9583
9584         * symtab.c (lookup_objfile_from_block)
9585         (lookup_symbol_in_objfile_symtabs)
9586         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9587         (find_line_symtab, info_sources_command)
9588         (default_collect_symbol_completion_matches_break_on)
9589         (make_source_files_completion_list): Update.
9590         * symmisc.c (print_objfile_statistics, dump_objfile)
9591         (maintenance_print_symbols, maintenance_info_symtabs)
9592         (maintenance_check_symtabs, maintenance_info_line_tables):
9593         Update.
9594         * source.c (select_source_symtab)
9595         (forget_cached_source_info_for_objfile): Update.
9596         * objfiles.h (class objfile_compunits): Remove.
9597         (struct objfile) <compunits_range>: New typedef.
9598         (compunits): New method.
9599         * objfiles.c (objfile_relocate1): Update.
9600         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9601         * maint.c (count_symtabs_and_blocks): Update.
9602         * linespec.c (iterate_over_all_matching_symtabs): Update.
9603         * cp-support.c (add_symbol_overload_list_qualified): Update.
9604         * coffread.c (coff_symtab_read): Update.
9605         * ada-lang.c (add_nonlocal_symbols)
9606         (ada_collect_symbol_completion_matches)
9607         (ada_add_global_exceptions): Update.
9608
9609 2019-01-15  Tom Tromey  <tom@tromey.com>
9610
9611         * progspace.h (program_space) <objfiles_safe_range>: New
9612         typedef.
9613         <objfiles_safe>: New method.
9614         * objfiles.h (class all_objfiles_safe): Remove.
9615         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9616         * jit.c (jit_inferior_exit_hook): Update.
9617
9618 2019-01-17  Tom Tromey  <tom@tromey.com>
9619
9620         * progspace.h (program_space) <objfiles_range>: New typedef.
9621         <objfiles>: New method.
9622         <objfiles_head>: Rename from objfiles.
9623         (object_files): Update.
9624         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9625         * guile/scm-pretty-print.c
9626         (ppscm_find_pretty_printer_from_objfiles): Update.
9627         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9628         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9629         Update.
9630         * python/py-progspace.c (pspy_get_objfiles): Update.
9631         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9632         Update.
9633         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9634         (objfpy_lookup_objfile_by_build_id): Update.
9635         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9636         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9637         Update.
9638         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9639         (expand_symtab_containing_pc, lookup_objfile_from_block)
9640         (lookup_static_symbol, basic_lookup_transparent_type)
9641         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9642         (find_line_symtab, info_sources_command)
9643         (default_collect_symbol_completion_matches_break_on)
9644         (make_source_files_completion_list, find_main_name): Update.
9645         * symmisc.c (print_symbol_bcache_statistics)
9646         (print_objfile_statistics, maintenance_print_symbols)
9647         (maintenance_print_msymbols, maintenance_print_objfiles)
9648         (maintenance_info_symtabs, maintenance_check_symtabs)
9649         (maintenance_expand_symtabs, maintenance_info_line_tables):
9650         Update.
9651         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9652         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9653         (map_overlay_command, unmap_overlay_command)
9654         (simple_overlay_update, expand_symtabs_matching)
9655         (map_symbol_filenames): Update.
9656         * symfile-debug.c (set_debug_symfile): Update.
9657         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9658         Update.
9659         * source.c (select_source_symtab, forget_cached_source_info):
9660         Update.
9661         * solib.c (solib_read_symbols): Update.
9662         * solib-spu.c (append_ocl_sos): Update.
9663         * psymtab.c (maintenance_print_psymbols)
9664         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9665         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9666         * printcmd.c (info_symbol_command): Update.
9667         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9668         Update.
9669         * objfiles.h (class all_objfiles): Remove.
9670         * objfiles.c (have_partial_symbols, have_full_symbols)
9671         (have_minimal_symbols, qsort_cmp, update_section_map)
9672         (shared_objfile_contains_address_p)
9673         (default_iterate_over_objfiles_in_search_order): Update.
9674         * objc-lang.c (info_selectors_command, info_classes_command)
9675         (find_methods): Update.
9676         * minsyms.c (find_solib_trampoline_target): Update.
9677         * maint.c (maintenance_info_sections)
9678         (maintenance_translate_address, count_symtabs_and_blocks):
9679         Update.
9680         * main.c (captured_main_1): Update.
9681         * linux-thread-db.c (try_thread_db_load_from_pdir)
9682         (has_libpthread): Update.
9683         * linespec.c (iterate_over_all_matching_symtabs)
9684         (search_minsyms_for_name): Update.
9685         * jit.c (jit_find_objf_with_entry_addr): Update.
9686         * hppa-tdep.c (find_unwind_entry)
9687         (hppa_lookup_stub_minimal_symbol): Update.
9688         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9689         Update.
9690         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9691         (elf_gnu_ifunc_resolve_by_got): Update.
9692         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9693         * dwarf-index-write.c (save_gdb_index_command): Update.
9694         * cp-support.c (add_symbol_overload_list_qualified): Update.
9695         * breakpoint.c (create_overlay_event_breakpoint)
9696         (create_longjmp_master_breakpoint)
9697         (create_std_terminate_master_breakpoint)
9698         (create_exception_master_breakpoint): Update.
9699         * blockframe.c (find_pc_partial_function): Update.
9700         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9701         (ada_collect_symbol_completion_matches)
9702         (ada_add_global_exceptions): Update.
9703
9704 2019-01-17  Tom Tromey  <tom@tromey.com>
9705
9706         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9707         declare VEC.
9708         (solib_target_parse_libraries): Change return type.
9709         (library_list_start_segment, library_list_start_section)
9710         (library_list_end_library, library_list_start_library); Update.
9711         (solib_target_free_library_list): Remove.
9712         (solib_target_parse_libraries): Remove cleanup.  Change return
9713         type.
9714         (solib_target_current_sos): Update.
9715
9716 2019-01-17  Tom Tromey  <tromey@bapiya>
9717
9718         * valprint.c: Replace "the the" with "the".
9719         * symtab.c: Replace "the the" with "the".
9720         * solib.c: Replace "the the" with "the".
9721         * solib-dsbt.c: Replace "the the" with "the".
9722         * linespec.c: Replace "the the" with "the".
9723         * dwarf2loc.h: Replace "the the" with "the".
9724         * amd64-windows-tdep.c: Replace "the the" with "the".
9725         * aarch64-tdep.c: Replace "the the" with "the".
9726
9727 2019-01-16  Keith Seitz  <keiths@redhat.com>
9728
9729         PR gdb/23773
9730         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9731         <builder>: Rename to ..
9732         <m_builder>: ... this and make private.
9733         (dwarf2_cu::get_builder): New method.  Change all users of
9734         `builder' to use this method.
9735         (dwarf2_start_symtab): Move to ...
9736         (dwarf2_cu::start_symtab): ... here.  Update all callers
9737         (setup_type_unit_groups): Move to ...
9738         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9739         callers.
9740         (dwarf2_cu::reset_builder): New method.
9741         (process_full_compunit, process_full_type_unit): Use
9742         dwarf2_cu::reset_builder.
9743         (follow_die_offset): Record the ancestor CU if it is different
9744         from the followed DIE's CU.
9745         (follow_die_sig_1): Likewise.
9746
9747 2019-01-15  Tom Tromey  <tom@tromey.com>
9748
9749         * remote.c (class remote_state) <buf>: Now a char_vector.
9750         <buf_size>: Remove.
9751         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9752         parameter.
9753         (remote_target::getpkt_or_notif_sane_1)
9754         (remote_target::getpkt_sane)
9755         (remote_target::getpkt_or_notif_sane): Likewise.
9756         (class remote_target) <putpkt>: New overload.
9757         (remote_target::read_frame): Change type of "buf_p".  Remove
9758         sizeof_p parameter.
9759         (packet_ok): New overload.
9760         (packet_check_result): New overload.
9761         Update all uses.
9762
9763 2019-01-14  Tom Tromey  <tom@tromey.com>
9764
9765         * remote-notif.c (handle_notification, remote_notif_ack)
9766         (remote_notif_parse): Make "buf" const.
9767         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9768         const.
9769         (remote_notif_parse, remote_notif_ack, handle_notification):
9770         Likewise.
9771         * remote.c (remote_notif_stop_parse): Make "buf" const.
9772         (remote_target::remote_parse_stop_reply): Make "buf" const.
9773         (remote_notif_stop_ack): Make "buf" const.
9774
9775 2019-01-14  Tom Tromey  <tom@tromey.com>
9776
9777         * remote.c (remote_console_output): Make parameter const.
9778
9779 2019-01-14  Tom Tromey  <tom@tromey.com>
9780
9781         * target-debug.h (target_debug_print_signals): Constify.
9782         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9783         * procfs.c (procfs_target::pass_signals): Update.
9784         * linux-nat.c (linux_nat_target::pass_signals): Update.
9785         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9786         * target-delegates.c: Rebuild.
9787         * remote.c (remote_target::program_signals): Update.
9788         (remote_target::pass_signals): Update.
9789         * target.c (target_pass_signals): Constify argument.
9790         (target_program_signals): Likewise.
9791         * target.h (struct target_ops) <pass_signals, program_signals>:
9792         Constify argument.
9793         (target_pass_signals, target_program_signals): Constify argument.
9794
9795 2019-01-14  Tom Tromey  <tom@tromey.com>
9796
9797         PR tui/28819:
9798         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9799
9800 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9801
9802         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9803         field.
9804         * rs6000-tdep.c: Include reggroups.h.
9805         (IS_V_ALIAS_PSEUDOREG): Define.
9806         (rs6000_register_name): Return names for the "vX" aliases.
9807         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9808         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9809         aliases.  Call default_register_reggroup_p for all other
9810         pseudo-registers.
9811         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9812         New functions.
9813         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9814         Handle "vX" aliases.
9815         (v_alias_pseudo_register_collect): New function.
9816         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9817         (rs6000_gdbarch_init): Initialize "vX" aliases as
9818         pseudo-registers.  Restore registration of
9819         rs6000_pseudo_register_reggroup_p with
9820         set_tdesc_pseudo_register_reggroup_p.
9821
9822 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9823
9824         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9825         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9826         set_gdbarch_num_pseudo_regs.
9827
9828 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9829
9830         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9831         Remove arg prefixname, add do_set and do_show.
9832         Add member functions set_list and show_list.
9833         * cli/cli-style.c (class cli_style_option): Update accordingly.
9834         (style_set_list): Move to file scope.
9835         (style_show_list): Likewise.
9836         (set_style): Call help_list.
9837         (show_style): Call cmd_show_list.
9838         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9839         Update to use the new macro.
9840
9841 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9842
9843         * ada-lang.c (_initialize_ada_language): Expand the help text
9844         for the "catch exception" command.
9845
9846 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847
9848         * symtab.c (matching_obj_sections): Initialize obj,
9849         declare it closer to its usage.
9850
9851 2019-01-10  Tom Tromey  <tom@tromey.com>
9852
9853         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9854         (basic_inf_threads_range): Remove.
9855         (inf_threads_range, inf_non_exited_threads_range)
9856         (safe_inf_threads_range): Use next_adapter.
9857
9858 2019-01-10  Keith Seitz  <keiths@redhat.com>
9859
9860         PR gdb/23712
9861         PR symtab/23010
9862         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9863         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9864
9865 2019-01-10  Keith Seitz  <keiths@redhat.com>
9866
9867         PR gdb/23712
9868         PR symtab/23010
9869         * dictionary.c (pending_to_vector): Remove.
9870         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9871         Remove _1 suffix, replacing functions of the same name.  Update
9872         all callers.
9873         (dict_create_hashed, dict_create_hashed_expandable)
9874         (dict_create_linear, dict_create_linear_expandable, dict_free)
9875         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9876         Make functions static.
9877
9878 2019-01-10  Keith Seitz  <keiths@redhat.com>
9879
9880         PR gdb/23712
9881         PR symtab/23010
9882         * dictionary.h (struct dictionary): Replace declaration with
9883         multidictionary.
9884         (dict_create_hashed, dict_create_hashed_expandable)
9885         (dict_create_linear, dict_create_linear_expandable)
9886         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9887         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9888         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9889         taking multidictionary argument.
9890         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9891         * block.h (struct block) <dict>: Change to multidictionary
9892         and rename `multidict'.
9893         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9894         symmisc.c: Update all dictionary references to multidictionary.
9895
9896 2019-01-10  Keith Seitz  <keiths@redhat.com>
9897
9898         PR gdb/23712
9899         PR symtab/23010
9900         * dictionary.c: Include unordered_map.
9901         (pending_to_vector): New function.
9902         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9903         Rewrite the non-"_1" functions to take vector instead
9904         of linked list.
9905         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9906         "new" _1 versions of the same name.
9907         (multidictionary): Define.
9908         (std::hash<enum language): New definition.
9909         (collate_pending_symbols_by_language, mdict_create_hashed)
9910         (mdict_create_hashed_expandable, mdict_create_linear)
9911         (mdict_create_linear_expandable, mdict_free)
9912         (find_language_dictionary, create_new_language_dictionary)
9913         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9914         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9915         (mdict_size, mdict_empty): New functions.
9916         * dictionary.h (mdict_iterator): Define.
9917
9918 2019-01-10  Pedro Alves  <palves@redhat.com>
9919
9920         * breakpoint.c (read_uploaded_action)
9921         (create_tracepoint_from_upload): Adjust to use
9922         gdb::unique_xmalloc_ptr.
9923         * ctf.c (ctf_write_uploaded_tp):
9924         (SET_ARRAY_FIELD): Use emplace_back.
9925         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9926         * tracefile-tfile.c (tfile_write_uploaded_tp):
9927         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9928         gdb::unique_xmalloc_ptr.
9929         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9930         at_string, cond_string, cmd_strings>: Replace char pointers
9931         with gdb::unique_xmalloc_ptr.
9932
9933 2019-01-10  Pedro Alves  <palves@redhat.com>
9934
9935         * solib-target.c (library_list_start_library): Don't xstrdup name.
9936
9937 2019-01-10  Pedro Alves  <palves@redhat.com>
9938
9939         * mdebugread.c (parse_partial_symbols): Use
9940         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9941
9942 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9943
9944         * linux-fork.c (scoped_switch_fork_info)
9945         <~scoped_switch_fork_info>: Fix incorrect variable name.
9946
9947 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9948
9949         * linux-fork.c (scoped_switch_fork_info)
9950         <scoped_switch_fork_info>: Make explicit.
9951         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9952
9953 2019-01-10  Tom Tromey  <tom@tromey.com>
9954
9955         * objfiles.h (objfile::reset_psymtabs): Update.
9956         * objfiles.c (objfile::objfile): Update.
9957         * psymtab.h (psymtab_storage::obstack): Update.
9958         (psymtab_storage::m_obstack): Use gdb::optional.
9959         (class psymtab_storage): Update comment.  Remove objfile
9960         parameter.
9961         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9962
9963 2019-01-10  Tom Tromey  <tom@tromey.com>
9964
9965         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9966         <free_psymtabs>: Now private.
9967         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9968         (allocate_psymtab): Use new method.
9969
9970 2019-01-10  Tom Tromey  <tom@tromey.com>
9971
9972         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9973         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9974         * mdebugread.c (parse_partial_symbols): Use
9975         allocate_dependencies.
9976         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9977         allocate_dependencies.
9978         (process_psymtab_comp_unit_reader)
9979         (build_type_psymtab_dependencies): Likewise.
9980         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9981
9982 2019-01-10  Tom Tromey  <tom@tromey.com>
9983
9984         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9985         PSYMBOL_SET_LANGUAGE.
9986         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9987
9988 2019-01-10  Tom Tromey  <tom@tromey.com>
9989
9990         * psymtab.h (psymtab_storage::obstack): New method.
9991         <m_obstack>: Rename from obstack; now private.
9992         * psymtab.c (psymtab_storage): Update.
9993         * dwarf2read.c (create_addrmap_from_index)
9994         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9995         Update.
9996
9997 2019-01-10  Tom Tromey  <tom@tromey.com>
9998
9999         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10000         * objfiles.h (objfile::reset_psymtabs): New method.
10001
10002 2019-01-10  Tom Tromey  <tom@tromey.com>
10003
10004         * symmisc.c (print_symbol_bcache_statistics): Update.
10005         (print_objfile_statistics): Update.
10006         * symfile.c (reread_symbols): Update.
10007         * psymtab.h (class psymtab_storage): New.
10008         * psymtab.c (psymtab_storage): New constructor.
10009         (~psymtab_storage): New destructor.
10010         (require_partial_symbols): Update.
10011         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10012         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10013         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10014         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10015         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10016         (start_psymtab_common, end_psymtab_common)
10017         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10018         (allocate_psymtab): Update.
10019         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10020         Update.
10021         (dump_psymtab_addrmap, maintenance_print_psymbols)
10022         (maintenance_check_psymtabs): Update.
10023         (class objfile_psymtabs): Move to objfiles.h.
10024         * psympriv.h (discard_psymtab): Now inline.
10025         (psymtab_discarder::psymtab_discarder): Update.
10026         (psymtab_discarder::~psymtab_discarder): Update.
10027         (ALL_OBJFILE_PSYMTABS): Rewrite.
10028         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10029         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10030         Remove fields.
10031         <partial_symtabs>: New field.
10032         (class objfile_psymtabs): Move from psymtab.h.  Update.
10033         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10034         psymbol_cache.
10035         (objfile::~objfile): Don't destroy psymbol_cache.
10036         * mdebugread.c (parse_partial_symbols): Update.
10037         * dwarf2read.c (create_addrmap_from_index)
10038         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10039         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10040         (add_partial_subprogram, dwarf2_ranges_read): Update.
10041         * dwarf-index-write.c (write_address_map)
10042         (write_one_signatured_type, recursively_write_psymbols)
10043         (class debug_names, class debug_names, write_psymtabs_to_index):
10044         Update.
10045
10046 2019-01-10  Tom Tromey  <tom@tromey.com>
10047
10048         * symtab.h (SYMBOL_SET_NAMES): Update.
10049         (symbol_set_names): Update.
10050         (MSYMBOL_SET_NAMES): Update.
10051         * symtab.c (symbol_set_names): Change argument to be an
10052         objfile_per_bfd_storage.
10053         * psymtab.c (add_psymbol_to_bcache): Update.
10054         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10055
10056 2019-01-10  Tom Tromey  <tom@tromey.com>
10057
10058         * symtab.c (create_demangled_names_hash): Change argument to be an
10059         objfile_per_bfd_storage.
10060         (symbol_set_names): Update.
10061
10062 2019-01-10  Tom Tromey  <tom@tromey.com>
10063
10064         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10065         init_psymbol_list.
10066         * psymtab.c (init_psymbol_list): Do nothing if already called.
10067         * psympriv.h (init_psymbol_list): Add comment.
10068         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10069         init_psymbol_list.
10070         * dbxread.c (dbx_symfile_read): Unconditionally call
10071         init_psymbol_list.
10072
10073 2019-01-10  Tom Tromey  <tom@tromey.com>
10074
10075         * xcoffread.c (scan_xcoff_symtab): Update.
10076         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10077         "where".
10078         * mdebugread.c (parse_partial_symbols)
10079         (handle_psymbol_enumerators): Update.
10080         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10081         * dbxread.c (read_dbx_symtab): Update.
10082         * psympriv.h (psymbol_placement): New enum.
10083         (add_psymbol_to_list): Update.
10084
10085 2019-01-10  Tom Tromey  <tom@tromey.com>
10086
10087         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10088         static_psymbols parameters.
10089         (scan_xcoff_symtab): Update.
10090         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10091         static_psymbols parameters.
10092         * psympriv.h (start_psymtab_common): Update.
10093         * mdebugread.c (parse_partial_symbols): Update.
10094         * dwarf2read.c (create_partial_symtab): Update.
10095         * dbxread.c (read_dbx_symtab): Update.
10096         (start_psymtab): Remove global_psymbols and static_psymbols
10097         parameters.
10098
10099 2019-01-10  Tom Tromey  <tom@tromey.com>
10100
10101         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10102         * psymtab.c (allocate_psymtab): Add comment.
10103         * psympriv.h (allocate_psymtab): Add comment.
10104         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10105         initializations.
10106         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10107
10108 2019-01-10  Tom Tromey  <tom@tromey.com>
10109
10110         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10111         Don't declare.
10112         * mipsread.c: Include mdebugread.h.
10113         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10114         Declare.
10115         * elfread.c: Include mdebugread.h.
10116
10117 2019-01-09  Tom Tromey  <tom@tromey.com>
10118
10119         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10120         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10121         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10122         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10123         (psym_lookup_symbol, psym_find_last_source_symtab)
10124         (psym_forget_cached_source_info, psym_print_stats)
10125         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10126         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10127         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10128         (psym_find_compunit_symtab_by_address)
10129         (maintenance_print_psymbols, maintenance_info_psymtabs)
10130         (maintenance_check_psymtabs): Use ranged for.
10131         * psymtab.h (class objfile_psymtabs): New.
10132         (require_partial_symbols): Return objfile_psymtabs.
10133         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10134
10135 2019-01-09  Tom Tromey  <tom@tromey.com>
10136
10137         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10138         (find_pc_mapped_section, list_overlays_command)
10139         (map_overlay_command, unmap_overlay_command)
10140         (simple_overlay_update): Use all_objfiles.
10141         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10142         * printcmd.c (info_symbol_command): Use all_objfiles.
10143         * objfiles.h (ALL_OBJSECTIONS): Remove.
10144         * maint.c (maintenance_translate_address): Use all_objfiles.
10145         * gcore.c (gcore_create_callback): Use all_objfiles.
10146         (objfile_find_memory_regions): Likewise.
10147
10148 2019-01-09  Tom Tromey  <tom@tromey.com>
10149
10150         * symtab.c (find_line_symtab, info_sources_command)
10151         (make_source_files_completion_list): Use objfile_compunits.
10152         * source.c (select_source_symtab): Use objfile_compunits.
10153         * objfiles.h (struct objfile): Update comment.
10154         (ALL_OBJFILES): Remove.
10155         (ALL_FILETABS): Remove.
10156         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10157         objfile_compunits.
10158
10159 2019-01-09  Tom Tromey  <tom@tromey.com>
10160
10161         * symmisc.c (print_objfile_statistics, dump_objfile)
10162         (maintenance_print_symbols): Use compunit_filetabs.
10163         * source.c (forget_cached_source_info_for_objfile): Use
10164         compunit_filetabs.
10165         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10166         (ALL_FILETABS): Use compunit_filetabs.
10167         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10168         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10169
10170 2019-01-09  Tom Tromey  <tom@tromey.com>
10171
10172         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10173         (compunit_filetabs): New.
10174         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10175         compunit_filetabs.
10176         (info_sources_command, make_source_files_completion_list): Remove
10177         declaration.
10178         * symmisc.c (print_objfile_statistics, dump_objfile)
10179         (maintenance_print_symbols): Remove declaration.
10180         (maintenance_info_symtabs): Use compunit_filetabs.
10181         (maintenance_info_line_tables): Likewise.
10182         * source.c (select_source_symtab): Change local variable name.
10183         (forget_cached_source_info_for_objfile): Remove declaration.
10184         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10185         * objfiles.c (objfile_relocate1): Remove declaration.
10186         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10187         declaration.
10188         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10189         * coffread.c (coff_symtab_read): Remove declaration.
10190         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10191         compunit_filetabs.
10192
10193 2019-01-09  Tom Tromey  <tom@tromey.com>
10194
10195         * symtab.c (lookup_objfile_from_block)
10196         (find_pc_sect_compunit_symtab, search_symbols)
10197         (default_collect_symbol_completion_matches_break_on): Use
10198         objfile_compunits.
10199         * objfiles.h (ALL_COMPUNITS): Remove.
10200         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10201         * cp-support.c (add_symbol_overload_list_qualified): Use
10202         objfile_compunits.
10203         * ada-lang.c (ada_collect_symbol_completion_matches)
10204         (ada_add_global_exceptions): Use objfile_compunits.
10205
10206 2019-01-09  Tom Tromey  <tom@tromey.com>
10207
10208         * source.c (select_source_symtab)
10209         (forget_cached_source_info_for_objfile): Remove declaration.
10210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10211         declaration.
10212         * maint.c (count_symtabs_and_blocks): Remove declaration.
10213         * cp-support.c (add_symbol_overload_list_qualified): Remove
10214         declaration.
10215         * coffread.c (coff_symtab_read): Remove declaration.
10216         * symtab.c (lookup_symbol_in_objfile_symtabs)
10217         (basic_lookup_transparent_type_1): Use objfile_compunits.
10218         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10219         (info_sources_command, search_symbols)
10220         (default_collect_symbol_completion_matches_break_on)
10221         (make_source_files_completion_list): Remove declaration.
10222         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10223         (ada_collect_symbol_completion_matches)
10224         (ada_add_global_exceptions): Remove declaration.
10225         * linespec.c (iterate_over_all_matching_symtabs): Use
10226         objfile_compunits.
10227         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10228         (class objfile_compunits): New.
10229         (ALL_COMPUNITS): Use objfile_compunits.
10230         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10231         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10232         objfile_compunits.
10233         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10234
10235 2019-01-09  Tom Tromey  <tom@tromey.com>
10236
10237         * symtab.c (search_symbols)
10238         (default_collect_symbol_completion_matches_break_on): Use
10239         objfile_msymbols.
10240         * ada-lang.c (ada_lookup_simple_minsym)
10241         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10242         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10243         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10244         objfile_msymbols.
10245         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10246         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10247         * objc-lang.c (find_methods): Use objfile_msymbols.
10248         (info_selectors_command, info_classes_command): Likewise.
10249         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10250         * objfiles.h (class objfile_msymbols): New.
10251         (ALL_OBJFILE_MSYMBOLS): Remove.
10252         (ALL_MSYMBOLS): Remove.
10253
10254 2019-01-09  Tom Tromey  <tom@tromey.com>
10255
10256         * common/next-iterator.h (next_adapter): Add Iterator template
10257         parameter.
10258         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10259         (class all_objfiles_safe): New.
10260         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10261         * objfiles.c (put_objfile_before): Update comment.
10262         (add_separate_debug_objfile): Likewise.
10263         (free_all_objfiles): Use all_objfiles_safe.
10264         (objfile_purge_solibs): Likewise.
10265
10266 2019-01-09  Tom Tromey  <tom@tromey.com>
10267
10268         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10269         (expand_symtab_containing_pc, lookup_static_symbol)
10270         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10271         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10272         all_objfiles.
10273         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10274         * breakpoint.c (create_overlay_event_breakpoint)
10275         (create_longjmp_master_breakpoint)
10276         (create_std_terminate_master_breakpoint)
10277         (create_exception_master_breakpoint): Use all_objfiles.
10278         * linux-thread-db.c (try_thread_db_load_from_pdir)
10279         (has_libpthread): Use all_objfiles.
10280         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10281         * linespec.c (iterate_over_all_matching_symtabs)
10282         (search_minsyms_for_name): Use all_objfiles.
10283         * maint.c (maintenance_info_sections): Use all_objfiles.
10284         * main.c (captured_main_1): Use all_objfiles.
10285         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10286         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10287         * guile/scm-pretty-print.c
10288         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10289         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10290         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10291         (maintenance_print_msymbols): Use all_objfiles.
10292         * source.c (select_source_symtab): Use all_objfiles.
10293         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10294         * symfile.c (remove_symbol_file_command)
10295         (expand_symtabs_matching, map_symbol_filenames): Use
10296         all_objfiles.
10297         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10298         all_objfiles.
10299         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10300         * objc-lang.c (find_methods): Use all_objfiles.
10301         * objfiles.c (have_partial_symbols, have_full_symbols)
10302         (have_minimal_symbols, qsort_cmp)
10303         (default_iterate_over_objfiles_in_search_order): Use
10304         all_objfiles.
10305         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10306         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10307         (maintenance_check_psymtabs): Use all_objfiles.
10308         (ALL_PSYMTABS): Remove.
10309         * compile/compile-object-run.c (do_module_cleanup): Use
10310         all_objfiles.
10311         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10312         * cp-support.c (add_symbol_overload_list_qualified): Use
10313         all_objfiles.
10314         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10315         Use all_objfiles.
10316         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10317         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10318         all_objfiles.
10319         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10320         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10321         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10322         Uses all_objfiles.
10323         * solib.c (solib_read_symbols): Use all_objfiles
10324
10325 2019-01-09  Tom Tromey  <tom@tromey.com>
10326
10327         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10328         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10329         all_objfiles.
10330         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10331         * symmisc.c (print_symbol_bcache_statistics)
10332         (print_objfile_statistics, maintenance_print_objfiles)
10333         (maintenance_info_symtabs, maintenance_check_symtabs)
10334         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10335         all_objfiles.
10336         * source.c (forget_cached_source_info): Use all_objfiles.
10337         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10338         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10339         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10340         * objfiles.c (update_section_map): Use all_objfiles.
10341         (shared_objfile_contains_address_p): Likewise.
10342         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10343         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10344
10345 2019-01-09  Tom Tromey  <tom@tromey.com>
10346
10347         * common/next-iterator.h: New file.
10348         * objfiles.h (class all_objfiles): New.
10349         (struct objfile_iterator): New.
10350
10351 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10352
10353         * NEWS: Move the description of the changed "frame", "select-frame",
10354          and "info frame" commands to the Changed commands section.
10355
10356 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10357
10358         * gdbtypes.c (check_stub_method_group): Remove handling of old
10359         mangling schemes.
10360         * linespec.c (find_methods): Likewise.
10361         * stabsread.c (read_member_functions): Likewise.
10362         * valops.c (search_struct_method): Likewise.
10363         (value_struct_elt_for_reference): Likewise.
10364         * NEWS: Mention this change.
10365
10366 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10367
10368         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10369         print_source_lines.
10370         * source.c (print_source_lines_base): Update line number check.
10371         (print_source_lines): New function.
10372         (source_lines_range::source_lines_range): New function.
10373         * source.h (class source_lines_range): New class.
10374         (print_source_lines): New declaration.
10375
10376 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10377
10378         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10379
10380 2019-01-08  Tom Tromey  <tom@tromey.com>
10381             Simon Marchi  <simon.marchi@ericsson.com>
10382
10383         PR gdb/24060
10384         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10385         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10386         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10387         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10388         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10389         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10390
10391 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10392
10393         * source.c (select_source_symtab): Move header comment to
10394         declaration in source.h.
10395         (forget_cached_source_info_for_objfile): Likewise.
10396         (forget_cached_source_info): Likewise.
10397         (identify_source_line): Likewise.
10398         * source.h (identify_source_line): Move declaration from symtab.h
10399         and add comment from source.c
10400         (print_source_lines): Likewise.
10401         (forget_cached_source_info_for_objfile): Likewise.
10402         (forget_cached_source_info): Likewise.
10403         (select_source_symtab): Likewise.
10404         (enum print_source_lines_flag): Move definition from symtab.h.
10405         * symtab.h (identify_source_line): Move declaration to source.h.
10406         (print_source_lines): Likewise.
10407         (forget_cached_source_info_for_objfile): Likewise.
10408         (forget_cached_source_info): Likewise.
10409         (select_source_symtab): Likewise.
10410         (enum print_source_lines_flag): Move definition to source.h.
10411         * tui/tui-hooks.c: Add 'source.h' include.
10412
10413 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10414
10415         * source.c (print_source_lines_base): Handle requests to print
10416         reverse line number sequences, and guard against empty lines
10417         string.
10418
10419 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10420
10421         * source.c (print_source_lines_base): Fix skip of '\r' if next
10422         character is '\n'.
10423
10424 2019-01-06  Tom Tromey  <tom@tromey.com>
10425
10426         * c-exp.y (struct c_parse_state) <macro_original_text,
10427         expansion_obstack>: New member.
10428         (macro_original_text, expansion_obstack): Remove globals.
10429         (scan_macro_expansion, scanning_macro_expansion)
10430         (finished_macro_expansion): Update.
10431         (scan_macro_cleanup): Remove.
10432         (yylex, c_parse): Update.
10433
10434 2019-01-06  Tom Tromey  <tom@tromey.com>
10435
10436         * c-exp.y (struct c_parse_state) <strings>: New member.
10437         (operator_stoken): Update.
10438
10439 2019-01-06  Tom Tromey  <tom@tromey.com>
10440
10441         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10442         (union type_stack_elt) <typelist_val>: Now a pointer to
10443         std::vector.
10444         (type_stack_cleanup): Don't declare.
10445         (push_typelist): Update.
10446         * parse.c (pop_typelist): Return a std::vector.
10447         (push_typelist): Take a std::vector.
10448         (follow_types): Update.  Do not free args.
10449         (type_stack_cleanup): Remove.
10450         * c-exp.y (struct c_parse_state): New.
10451         (cpstate): New global.
10452         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10453         (nonempty_typelist): Update.
10454         (func_mod): Create a new vector.
10455         (c_parse): Create a c_parse_state.
10456         (check_parameter_typelist): Do not delete params.
10457         (function_method): Update.  Do not delete type_list.
10458
10459 2019-01-06  Tom Tromey  <tom@tromey.com>
10460
10461         PR gdb/28155:
10462         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10463         check_typedef.
10464         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10465         (print_return_value): Likewise.
10466
10467 2019-01-05  Tom Tromey  <tom@tromey.com>
10468
10469         * contrib/cleanup_check.py: Remove.
10470         * contrib/gcc-with-excheck: Remove.
10471         * contrib/exsummary.py: Remove.
10472         * contrib/excheck.py: Remove.
10473
10474 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10475
10476         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10477         NULL. Initialize tpprev to NULL instead of assigning it
10478         to NULL on the next statement.
10479         * windows-nat.c (windows_delete_thread): Remove check for
10480         main_thread_id before printing thread exit notifications.
10481         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10482         Remove thread ID check against main_thread_id.
10483         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10484         windows_delete_thread.
10485         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10486
10487 2019-01-04  Tom Tromey  <tom@tromey.com>
10488
10489         * compile/compile.c (_initialize_compile): Use upper case for
10490         metasyntactic variables.
10491         * symmisc.c (_initialize_symmisc): Use upper case for
10492         metasyntactic variables.
10493         * psymtab.c (_initialize_psymtab): Use upper case for
10494         metasyntactic variables.
10495         * demangle.c (demangle_command): Use upper case for metasyntactic
10496         variables.
10497         (_initialize_demangler): Likewise.
10498         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10499         variables.
10500
10501 2019-01-03  Tom Tromey  <tom@tromey.com>
10502
10503         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10504
10505 2019-01-03  Tom Tromey  <tom@tromey.com>
10506
10507         * python/py-symtab.c (salpy_str): Update.
10508         (struct salpy_sal_object) <symtab>: Now a PyObject.
10509         (salpy_dealloc): Update.
10510         (del_objfile_sal): Use gdbpy_ref.
10511
10512 2019-01-03  Tom Tromey  <tom@tromey.com>
10513
10514         * python/py-type.c (convert_field): Use new_reference.  Return
10515         gdbpy_ref.
10516         (make_fielditem): Return gdbpy_ref.
10517         (typy_fields): Update.
10518         (typy_getitem): Update.
10519         (field_name): Return gdbpy_ref.  Use new_reference.
10520         (typy_iterator_iternext): Update.
10521
10522 2019-01-03  Tom Tromey  <tom@tromey.com>
10523
10524         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10525
10526 2019-01-03  Tom Tromey  <tom@tromey.com>
10527
10528         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10529         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10530         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10531         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10532         (pspy_set_type_printers): Likewise.
10533         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10534         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10535         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10536         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10537         (objfpy_set_type_printers): Likewise.
10538
10539 2019-01-03  Tom Tromey  <tom@tromey.com>
10540
10541         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10542         (gdbpy_print_stack): Use gdbpy_err_fetch.
10543         * python/python-internal.h (class gdbpy_err_fetch): New class.
10544         (class gdbpy_enter) <m_error_type, m_error_value,
10545         m_error_traceback>: Remove.
10546         <m_error>: New member.
10547         (gdbpy_exception_to_string): Don't declare.
10548         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10549         * python/py-value.c (convert_value_from_python): Use
10550         gdbpy_err_fetch.
10551         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10552         gdbpy_exception_to_string.
10553         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10554         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10555         gdbpy_err_fetch.
10556
10557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10558
10559         * linux-nat.c (delete_lwp_cleanup): Delete.
10560         (struct lwp_deleter): New struct.
10561         (lwp_info_up): New typedef.
10562         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10563         lwp_info_up.
10564
10565 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10566
10567         * linux-fork.c (class scoped_switch_fork_info): New class.
10568         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10569
10570 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10571
10572         * valops.c (find_overload_match): Remove use of null_cleanup, and
10573         calls to do_cleanups.
10574
10575 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10576
10577         * compile/compile-cplus-types.c
10578         (compile_cplus_instance::decl_name): Handle changes to
10579         cp_func_name.
10580         * cp-support.c (cp_func_name): Update header comment, update
10581         return type.
10582         * cp-support.h (cp_func_name): Update return type in declaration.
10583         * valops.c (find_overload_match): Move temp_func local to top
10584         level of function and change its type.  Use temp_func to hold and
10585         delete temporary string obtained from cp_func_name.
10586
10587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10590         gdb::char_vector, remove cleanup, and update uses of `msg`.
10591
10592 2019-01-03  Jim Wilson  <jimw@sifive.com>
10593
10594         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10595
10596 2019-01-02  Tom Tromey  <tom@tromey.com>
10597
10598         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10599         (tdesc_parse_xml): Remove cleanups.
10600         * target-descriptions.h (make_cleanup_free_target_description):
10601         Don't declare.
10602         (target_desc_deleter): New struct.
10603         (target_desc_up): New typedef.
10604         * target-descriptions.c (target_desc_deleter::operator()): Rename
10605         from free_target_description.
10606         (make_cleanup_free_target_description): Remove.
10607
10608 2019-01-02  Tom Tromey  <tom@tromey.com>
10609
10610         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10611         constructor, destructor.
10612         (linespec_parser): Remove typedef.
10613         (~linespec_parser): Rename from linespec_parser_delete.
10614         (linespec_lex_to_end, linespec_complete_label)
10615         (linespec_complete): Update.
10616         (decode_line_full): Remove cleanups.
10617         (decode_line_1): Update.
10618
10619 2019-01-02  Tom Tromey  <tom@tromey.com>
10620
10621         * python/python-internal.h (inferior_to_inferior_object): Change
10622         return type.
10623         * python/py-exitedevent.c (create_exited_event_object): Update.
10624         * python/py-inferior.c (inferior_to_inferior_object): Return
10625         gdbpy_ref.
10626         (python_new_inferior, python_inferior_deleted)
10627         (thread_to_thread_object, delete_thread_object)
10628         (build_inferior_list, gdbpy_selected_inferior): Update.
10629         * python/py-infthread.c (create_thread_object): Update.  Also fail
10630         if inferior_to_inferior_object fails.
10631
10632 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10633
10634         * inferior.h (class inferior) <displaced_step_state>: New field.
10635         * infrun.h (struct displaced_step_state): Move here from
10636         infrun.c.  Initialize fields, add constructor.
10637         <inf>: Remove field.
10638         <reset>: New method.
10639         * infrun.c (struct displaced_step_inferior_state): Move to
10640         infrun.h.
10641         (displaced_step_inferior_states): Remove.
10642         (get_displaced_stepping_state): Adust.
10643         (displaced_step_in_progress_any_inferior): Adjust.
10644         (displaced_step_in_progress_thread): Adjust.
10645         (displaced_step_in_progress): Adjust.
10646         (add_displaced_stepping_state): Remove.
10647         (get_displaced_step_closure_by_addr): Adjust.
10648         (remove_displaced_stepping_state): Remove.
10649         (infrun_inferior_exit): Call displaced_step_state.reset.
10650         (use_displaced_stepping): Don't check for NULL.
10651         (displaced_step_prepare_throw): Call
10652         get_displaced_stepping_state.
10653         (displaced_step_fixup): Don't check for NULL.
10654         (prepare_for_detach): Don't check for NULL.
10655
10656 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10657
10658         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10659          in case of call that did not complete.
10660
10661 2019-01-02  Andrey Utkin  <autkin@undo.io>
10662
10663         * symfile.c (find_separate_debug_file): Fix search of debug files for
10664         remote debuggee.
10665
10666 2019-01-02  Tom Tromey  <tom@tromey.com>
10667
10668         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10669         indentation.
10670         * python/py-frame.c (frapy_older): Remove cast.
10671         (frapy_newer): Likewise.
10672         * python/py-breakpoint.c (local_setattro): Remove cast.
10673         * python/py-arch.c (archpy_name): Remove local variable.
10674         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10675
10676 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10677
10678         * unittests/basic_string_view/element_access/char/empty.cc:
10679         Fix year range in copyright header.
10680
10681 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10682
10683         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10684         Delete.
10685         <operator==>: Update with for removed field.
10686         <hash>: Likewise.
10687         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10688         <isa_features>: ...this.
10689         <abi_features>: New field.
10690         (riscv_isa_flen): Update comment.
10691         (riscv_abi_xlen): New declaration.
10692         (riscv_abi_flen): New declaration.
10693         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10694         isa_features.
10695         (riscv_abi_xlen): New function.
10696         (riscv_isa_flen): Update to get answer from isa_features.
10697         (riscv_abi_flen): New function.
10698         (riscv_has_fp_abi): Update to get answer from abi_features.
10699         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10700         xlen and flen.
10701         (riscv_call_info) <xlen, flen>: Update comment.
10702         (riscv_call_arg_struct): Remove invalid assertions
10703         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10704         is removed.
10705         (riscv_gdbarch_init): Gather isa features and abi features
10706         separately, ensure both match on the gdbarch when reusing an old
10707         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10708         a target with 64-bit float hardware.
10709
10710 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10711
10712         * source.c (search_command_helper): Stop reverse search
10713         when line 1 has been searched.
10714
10715 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10716
10717         * record-full.c (record_full_base_target::close): Rewrite
10718         record_full_core_buf_list free logic.
10719
10720 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10721
10722         * break-catch-syscall.c (print_one_catch_syscall): xfree
10723         the last text.
10724
10725 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10726
10727         * top.c (print_gdb_version): Update Copyright year in version
10728         message.
10729
10730 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10731
10732         Update copyright year range in all GDB files.
10733
10734 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10735
10736         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10737
10738 For older changes see ChangeLog-2018.
10739 \f
10740 Local Variables:
10741 mode: change-log
10742 left-margin: 8
10743 fill-column: 74
10744 version-control: never
10745 coding: utf-8
10746 End:
10747