gdb/ChangeLog

   1 2019-08-02  Alexandre Oliva <oliva@adacore.com>
   2
   3         * ada-lang.c (exception_support_info_v0): Renamed from...
   4         (default_exception_support_info): ... this.  Create new
   5         definition for v1.
   6         (ada_has_this_exception_support): Look up catch_handlers_sym.
   7         (ada_exception_support_info_sniffer): Try v0 after default.
   8
   9 2019-08-01  Tom Tromey  <tromey@adacore.com>
  10
  11         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  12         gdbarch.h.
  13
  14 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  15
  16         * s12z-tdep.c: Fix include path for s12z-opc.h.
  17
  18 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * NEWS: Require GNU make 3.82.
  21
  22 2019-07-16  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  25         declare.
  26
  27 2019-07-30  Tom Tromey  <tromey@adacore.com>
  28
  29         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  30
  31 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  32
  33         * printcmd.c (print_address_symbolic): Print negative offsets.
  34         (build_address_symbolic): Force signed arithmetic when computing
  35         offset.
  36
  37 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  38
  39         PR/24474: Add a function to lookup static variables.
  40         * NEWS: Mention this new function.
  41         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  42         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  43         * python/python.c (python_GdbMethods): Add new function.
  44
  45 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  46
  47         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  48         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  49         (objfpy_lookup_static_symbol): New function.
  50         (objfile_object_methods): Add new functions.
  51
  52 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  53
  54         * NEWS: Mention 'set|show print frame-info'.  Mention new
  55         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  56         backtrace argument.  Mention that python frame filtering code
  57         is now consistent with what 'backtrace' command prints.
  58
  59 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  60
  61         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  62         comments.
  63         (print_frame_info_auto, print_frame_info_source_line,
  64         print_frame_info_location, print_frame_info_source_and_location,
  65         print_frame_info_location_and_address, print_frame_info_short_location):
  66         New declarations.
  67         (struct frame_print_options): New member print_frame_info.
  68         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  69         * stack.h (get_user_print_what_frame_info): New declaration.
  70         (frame_show_address): New declaration.
  71         * stack.c (print_frame_arguments_choices): New value 'presence'.
  72         (print_frame_info_auto, print_frame_info_source_line,
  73         print_frame_info_location, print_frame_info_source_and_location,
  74         print_frame_info_location_and_address, print_frame_info_short_location,
  75         print_frame_info_choices, print_frame_info_print_what): New definitions.
  76         (print_frame_args): Only print dots for args if print frame-arguments
  77         is 'presence'.
  78         (frame_print_option_defs): New element for "frame-info".
  79         (get_user_print_what_frame_info): New function.
  80         (frame_show_address): Make non static.  Move comment to stack.h.
  81         (print_frame_info_to_print_what): New function.
  82         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  83         to decide what to print.
  84         (backtrace_command_1): Handle the new print_frame_arguments_presence
  85         value.
  86         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  87         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  88         (py_print_frame): In non-mi mode, use LOCATION as default for
  89         print_what, similarly to frame information printed directly by
  90         backtrace command. Handle frame-info user option in non MI mode.
  91
  92 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  93
  94         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  95         Add case for debugging 32-bit target on 64-bit host.  Revise
  96         comment.
  97
  98 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  99
 100         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 101         instead of find_function_entry_range_from_pc.
 102
 103 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 104
 105         * stack.c (find_frame_funname): Remove code which preferred
 106         minsym over symtab sym in "certain pathological cases".
 107
 108         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 109         parameter.  Change type of "do_demangle" to bool.
 110         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 111         Pass suitable "prefer_sym_over_minsym" flag to
 112         build_address_symbolic().  Don't output "+" for negative offsets.
 113         * printcmd.c (print_address_symbolic): Update invocation of
 114         build_address_symbolic to include a "prefer_sym_over_minsym"
 115         flag.
 116         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 117         Restrict cases in which use of minimal symbol is preferred to that
 118         of a found symbol.  Update comments.
 119
 120         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 121         for entry pc when entry pc is out of range for that FDE.
 122
 123 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 124
 125         PR gdb/24839:
 126         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 127         type.
 128
 129 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 132         this function's Python signature.
 133
 134
 135 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 136
 137         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 138         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 139         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 140         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 141         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 142
 143
 144 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 145
 146         * h8300-tdep.c (h8300_register_name_common): New.
 147         h8300_register_name): Use h8300_register_name_common.
 148         (h8300s_register_name): Likewise.
 149         (h8300sx_register_name): Likewise.
 150         (h8300h_register_nam): New.
 151         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 152
 153
 154 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 155
 156         * arm-tdep.c (arm_skip_cmse_entry): New function.
 157         (arm_is_sgstubs_section): New function.
 158         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 159
 160 2019-07-22  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 163         Don't self-assign.
 164
 165 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 168         type_print.
 169
 170 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 173         so that GDB doesn't match any msymbols when searching in the
 174         TYPES_DOMAIN.
 175         (print_symbol_info): Print using typedef_print or type_print based
 176         on the type of the symbol.  Add updated FIXME comment moved from...
 177         (_initialize_symtab): ... move and update FIXME comment to above.
 178
 179 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 180
 181         * NEWS: Mention adding -q option to "info types".
 182         * symtab.c (struct info_types_options): New struct.
 183         (info_types_options_defs): New variable.
 184         (make_info_types_options_def_group): New function.
 185         (info_types_command): Use gdb::option framework to parse options.
 186         (info_types_command_completer): New function.
 187         (_initialize_symtab): Extend the help text on "info types" and
 188         register command completer.
 189
 190 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 191
 192         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 193         (lookup_symbol_in_objfile): Change int to block_enum and add a
 194         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 195
 196 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * MAINTAINERS (Write After Approval): Add self.
 199
 200 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 203         instruction to the dummy code region.
 204
 205 2019-07-19  Tom Tromey  <tromey@adacore.com>
 206
 207         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 208         (ARGSUSED, PARAMS, __func__): Remove rules.
 209
 210 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 211
 212         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 213         * features/arm/arm-with-iwmmxt.c: Remove.
 214         * features/arm/arm-with-iwmmxt.xml: Remove.
 215         * features/arm/arm-with-m-fpa-layout.c: Remove.
 216         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 217         * features/arm/arm-with-m-vfp-d16.c: Remove.
 218         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 219         * features/arm/arm-with-m.c: Remove.
 220         * features/arm/arm-with-m.xml: Remove.
 221         * features/arm/arm-with-neon.c: Remove.
 222         * features/arm/arm-with-neon.xml: Remove.
 223         * features/arm/arm-with-vfpv2.c: Remove.
 224         * features/arm/arm-with-vfpv2.xml: Remove.
 225         * features/arm/arm-with-vfpv3.c: Remove.
 226         * features/arm/arm-with-vfpv3.xml: Remove.
 227
 228 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 229
 230         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 231
 232 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 233
 234         * arch/aarch32.c (aarch32_create_target_description): Create
 235         target descriptions using features.
 236         * arch/arm.c (arm_create_target_description)
 237         (arm_create_mprofile_target_description): Likewise.
 238         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 239
 240 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 241
 242         * Makefile.in: Add new files.
 243         * aarch32-tdep.c: New file.
 244         * aarch32-tdep.h: New file.
 245         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 246         Call aarch32_read_description.
 247         * arch/aarch32.c: New file.
 248         * arch/aarch32.h: New file.
 249         * arch/arm.c (arm_create_target_description)
 250         (arm_create_mprofile_target_description): New function.
 251         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 252         (arm_create_target_description)
 253         (arm_create_mprofile_target_description): New declaration.
 254         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 255         read_description functions.
 256         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 257         Likewise.
 258         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 259         * arm-tdep.c (tdesc_arm_list): New variable.
 260         (arm_register_g_packet_guesses): Call create description functions.
 261         (arm_read_description) (arm_read_mprofile_description): New
 262         function.
 263         * arm-tdep.h (arm_read_description)
 264         (arm_read_mprofile_description): Add declaration.
 265         * configure.tgt: Add new files.
 266
 267 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 268
 269         * top.c (new_ui_command): Open specified terminal just once.
 270
 271 2019-07-18  Tom Tromey  <tromey@adacore.com>
 272
 273         * symtab.c (main_name): Constify return type.
 274         * symfile.c (set_initial_language): Update.
 275         * symtab.h (main_name): Constify return type.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-winsource.c (tui_update_source_window)
 280         (tui_update_source_window_as_is)
 281         (tui_update_source_windows_with_line): Remove return.
 282         * tui/tui-disasm.c (tui_show_disassem)
 283         (tui_show_disassem_and_update_source): Remove return.
 284         * tui/tui.c (tui_reset): Remove return.
 285         * tui/tui-wingeneral.c
 286         (tui_check_and_display_highlight_if_needed): Remove return.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 291
 292 2019-07-17  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-winsource.h (struct tui_exec_info_window)
 295         (struct tui_source_window_base): Move from tui-data.h.
 296         * tui/tui-winsource.c: Move many method definitions from
 297         elsewhere.  Remove "structuring" comments.
 298         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 299         (tui_source_window_base::refresh_window): Move to
 300         tui-winsource.c.
 301         * tui/tui-win.c (tui_source_window_base::refresh_all)
 302         (tui_source_window_base::update_tab_width)
 303         (tui_source_window_base::set_new_height)
 304         (tui_source_window_base::do_make_visible_with_new_height): Move to
 305         tui-winsource.c.
 306         * tui/tui-source.h: Update.
 307         * tui/tui-source.c (tui_source_window_base::reset): Move to
 308         tui-winsource.c.
 309         * tui/tui-disasm.h: Update.
 310         * tui/tui-data.h (struct tui_exec_info_window): Move to
 311         tui-winsource.h.
 312         (struct tui_source_window_base): Likewise.
 313         * tui/tui-data.c (tui_source_window_base::clear_detail)
 314         (tui_source_window_base, ~tui_source_window_base): Move to
 315         tui-winsource.c.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-win.c (tui_resize_all)
 320         (tui_source_window_base::update_tab_width)
 321         (tui_adjust_win_heights): Update.
 322         (tui_win_info::make_invisible_and_set_new_height): Rename from
 323         make_invisible_and_set_new_height.
 324         * tui/tui-data.h (struct tui_win_info)
 325         <make_invisible_and_set_new_height>: New method.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui.c: Update.
 330         * tui/tui-source.h (struct tui_source_window): Move from
 331         tui-data.h.
 332         * tui/tui-layout.c: Update.
 333         * tui/tui-disasm.c: Update.
 334         * tui/tui-data.h (struct tui_source_window): Move to
 335         tui-source.h.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 340         tui-data.h.
 341         * tui/tui-data.h (struct tui_disasm_window): Move to
 342         tui-disasm.h.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-regs.h (struct tui_data_item_window): Move from
 347         tui-data.h.
 348         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 349         * tui/tui-data.h (struct tui_data_item_window): Move to
 350         tui-regs.h.
 351         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 352
 353 2019-07-17  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui.c: Update.
 356         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 357         (tui_cmd_window::max_height): Move to tui-command.c.
 358         * tui/tui-layout.c: Update.
 359         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 360         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 361         tui-command.c.
 362         * tui/tui-command.h (struct tui_cmd_window): Move from
 363         tui-data.h.
 364         * tui/tui-command.c: Remove "structuring" comments.
 365         (tui_cmd_window::clear_detail)
 366         (tui_cmd_window::do_make_visible_with_new_height)
 367         (tui_cmd_window::max_height): Move from elsewhere.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 372         Now static.
 373         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 374         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui.c: Update.
 379         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 380         tui-regs.c.
 381         * tui/tui-windata.h: Remove file.
 382         * tui/tui-windata.c: Remove file.
 383         * tui/tui-win.c (tui_data_window::set_new_height)
 384         (tui_data_window::do_make_visible_with_new_height): Move to
 385         tui-regs.c.
 386         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 387         * tui/tui-regs.c: Remove "structuring" comments.
 388         (tui_data_window::first_data_item_displayed)
 389         (tui_data_window::delete_data_content_windows)
 390         (tui_data_window::erase_data_content)
 391         (tui_data_window::display_all_data)
 392         (tui_data_window::refresh_all)
 393         (tui_data_window::do_scroll_vertical)
 394         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 395         (tui_data_window::do_make_visible_with_new_height)
 396         (tui_data_window::refresh_window): Move from elsewhere.
 397         (_initialize_tui_regs): Move to end of file.
 398         * tui/tui-layout.c: Update.
 399         * tui/tui-hooks.c: Update.
 400         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 401         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 402         tui-regs.c.
 403         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 404
 405 2019-07-17  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 408         seen.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-win.c (tui_source_window_base::set_new_height)
 413         (tui_source_window_base::do_make_visible_with_new_height): Use
 414         m_has_locator field directly.
 415         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 416         method.
 417         (struct tui_source_window_base) <has_locator>: Likewise.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 422         Don't declare.
 423         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 424         Remove.
 425         * tui/tui-win.c (tui_source_window_base::set_new_height)
 426         (tui_source_window_base::set_new_height)
 427         (make_invisible_and_set_new_height)
 428         (tui_source_window_base::do_make_visible_with_new_height)
 429         (tui_source_window_base::do_make_visible_with_new_height):
 430         Update.
 431         * tui/tui-layout.c (show_source_disasm_command, show_data)
 432         (show_source_or_disasm_and_command): Update.
 433         * tui/tui-layout.c (show_layout): Update.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-layout.c (make_data_window): Remove.
 438         (show_data): Unify creation and re-initialization cases.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-layout.c (make_source_window, make_disasm_window):
 443         Remove.
 444         (show_data): Unify creation and re-initialization cases.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-layout.c (make_command_window): Remove.
 449         (show_source_disasm_command, show_source_or_disasm_and_command):
 450         Unify creation and re-initialization cases.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 455         creation and re-initialization cases.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-regs.c (tui_get_register): Return void.
 460
 461 2019-07-17  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 464         Simplify.
 465
 466 2019-07-17  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 469         resetting.
 470
 471 2019-07-17  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 474         * tui/tui-regs.c (tui_reg_layout): New function.
 475         (tui_show_registers, tui_reg_command): Use it.
 476         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 477         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 478         parameters.
 479         (tui_layout_command): Remove.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-layout.h (tui/tui-layout): Return void.
 484         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-layout.c (show_source_disasm_command, show_data):
 489         Update.
 490         (reset_locator): Remove.
 491         (show_source_or_disasm_and_command): Update.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-source.c (tui_source_window_base::reset): Remove
 496         win_type parameter.
 497         * tui/tui-layout.c (make_command_window, make_source_window)
 498         (make_disasm_window, make_data_window)
 499         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 500         (reset_locator, show_source_or_disasm_and_command): Update.
 501         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 502         win_type parameter.
 503         (struct tui_source_window_base) <reset>: Likewise.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-layout.c (show_source_disasm_command): Use
 508         reset_locator.
 509         (reset_locator): New function.
 510         (init_and_make_win): Remove.
 511         (show_source_or_disasm_and_command): Use reset_locator.
 512
 513 2019-07-17  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 516         condition.
 517         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 518         Remove condition.
 519         * tui/tui-source.c (tui_source_window_base::reset): New method.
 520         * tui/tui-layout.c (make_command_window): Don't call
 521         init_and_make_win.
 522         (make_source_window, make_disasm_window): Don't call
 523         make_source_or_disasm_window.
 524         (make_data_window): Don't call init_and_make_win.  Change calling
 525         convention.
 526         (show_source_disasm_command, show_data): Simplify.
 527         (make_source_or_disasm_window): Remove.
 528         (show_source_or_disasm_and_command): Simplify.
 529         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 530         (struct tui_source_window_base) <reset>: Likewise.
 531         <execution_info>: Remove initializer.
 532         * tui/tui-data.c (tui_source_window_base): Initialize
 533         execution_info.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 538         variable.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui.c (tui_rl_other_window): Update.
 543         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 544         superclass method first.  Always iterate over regs_content.
 545         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 546         method.
 547         * tui/tui-win.c (tui_set_focus_command): Update.
 548
 549 2019-07-17  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-win.c (tui_set_focus_command): Rename from
 552         tui_set_focus.  Call tui_enable.
 553         (tui_set_focus_command): Remove.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 558         refresh_window.
 559         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 560         touchwin.
 561         (tui_data_window::refresh_window): Call refresh_window on data
 562         items.  Always call superclass refresh_window.
 563         (tui_win_info::refresh): Remove.
 564         (tui_source_window_base::refresh_window): Update.
 565         (tui_refresh_all): Update.
 566         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 567         refresh_window.
 568         (show_source_or_disasm_and_command): Likewise.
 569         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 570         (struct tui_source_window_base) <refresh>: Likewise.
 571
 572 2019-07-17  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-winsource.c (tui_clear_source_content)
 575         (tui_show_source_content): Update.
 576         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 577         whether content is empty.
 578         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 579         Remove.
 580
 581 2019-07-17  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 584         window's contents.
 585         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 586         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 587
 588 2019-07-17  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 591         (struct tui_data_item_window): Update.
 592
 593 2019-07-17  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 596         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 597         defines.
 598
 599 2019-07-17  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.h (tui_erase_source_content)
 602         (tui_clear_source_content): Remove "display_prompt" parameter.
 603         * tui/tui-winsource.c (tui_update_source_window_as_is)
 604         (tui_update_source_windows_with_addr): Update.
 605         (tui_clear_source_content): Remove "display_prompt" parameter.
 606         (tui_erase_source_content): Likewise.  Simplify.
 607         (tui_show_source_content): Update.
 608         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 609         * tui/tui-stack.c (tui_show_frame_info): Update.
 610         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 611         Remove defines.
 612
 613 2019-07-17  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 616         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 617         parameter.
 618         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 619         parameter.
 620
 621 2019-07-17  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-winsource.c (tui_clear_source_content)
 624         (tui_show_source_content, tui_show_exec_info_content)
 625         (tui_clear_exec_info_content): Update.
 626         * tui/tui-stack.c (tui_show_locator_content): Update.
 627         (tui_show_frame_info): Update.
 628         * tui/tui-source.h (tui_source_window): Don't declare.
 629         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 630         from tui_source_is_displayed.
 631         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 632         Remove field.
 633         (struct tui_source_window_base) <content_in_use>: New field.  Now
 634         bool.
 635         (struct tui_source_window) <showing_source_p>: New method.
 636         (TUI_SRC_WIN): Change cast.
 637         * tui/tui-data.c (tui_initialize_static_data): Update.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 642         location_matches_p.
 643         * tui/tui-source.c (tui_source_window::location_matches_p): New
 644         method.
 645         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 646         method.
 647         * tui/tui-data.h (struct tui_source_window_base)
 648         <location_matches_p>: New method.
 649         (struct tui_source_window, struct tui_disasm_window)
 650         <location_matches_p>: Likewise.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-win.c (tui_set_win_height_command): Rename from
 655         tui_set_win_height.
 656         (tui_set_win_height_command): Remove.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-source.c (tui_source_window): New constructor.  Add
 661         observer.
 662         (~tui_source_window): New destructor.
 663         (tui_source_window::style_changed): New method.
 664         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 665         (tui_attach_detach_observers): Update.
 666         * tui/tui-data.h (struct tui_source_window): Make constructor not
 667         inline.  Add destructor.
 668         (struct tui_source_window) <style_changed>: New method.
 669         <m_observable>: New member.
 670
 671 2019-07-17  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 674         * tui/tui-win.c (tui_resize_all): Fix typo.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 679         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 680         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 681         * tui/tui-win.c (window_name_completer): Use foreach.
 682         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 683         (update_tab_width): Likewise.
 684         * tui/tui-layout.c (show_layout): Update.
 685         * tui/tui-data.h (class tui_window_iterator): New.
 686         (struct all_tui_windows): New.
 687         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 692         parameter.  Don't reference globals.
 693         (tui_reg_command): Update.
 694
 695 2019-07-17  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-regs.c (tui_show_registers): Simplify.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-regs.c (tui_show_registers): Update.
 702         (tui_show_register_group): Add win_info parameter.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 707         Rename from tui_display_reg_element_at_line.
 708         (tui_data_window::display_registers_from_line): Update.
 709         * tui/tui-data.h (struct tui_data_window)
 710         <display_reg_element_at_line>: New method.
 711
 712 2019-07-17  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-regs.h (tui_display_registers_from)
 715         (tui_display_registers_from_line): Don't declare.
 716         * tui/tui-windata.c (tui_data_window::display_all_data)
 717         (tui_data_window::refresh_all)
 718         (tui_data_window::do_scroll_vertical): Update.
 719         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 720         from tui_display_registers_from.
 721         (tui_display_reg_element_at_line): Update.
 722         (tui_data_window::display_registers_from_line): Rename from
 723         tui_display_registers_from_line.
 724         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 725         display_registers_from_line>: New methods.
 726
 727 2019-07-17  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 730         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 731         from tui_erase_data_content.
 732         (tui_data_window::display_all_data)
 733         (tui_data_window::refresh_all)
 734         (tui_data_window::do_scroll_vertical): Update.
 735         * tui/tui-regs.c (tui_show_registers): Update.
 736         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 737         New method.
 738
 739 2019-07-17  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 742         declare.
 743         * tui/tui-windata.c
 744         (tui_data_window::delete_data_content_windows): Rename from
 745         tui_delete_data_content_windows.
 746         (tui_data_window::display_all_data)
 747         (tui_data_window::do_scroll_vertical): Update.
 748         * tui/tui-data.h (struct tui_data_window)
 749         <delete_data_content_windows>: New method.
 750
 751 2019-07-17  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 754         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 755
 756 2019-07-17  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 759         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 760         from tui_display_all_data.
 761         * tui/tui-win.c
 762         (tui_data_window::do_make_visible_with_new_height): Update.
 763         * tui/tui-regs.c (tui_show_registers): Update.
 764         * tui/tui-layout.c (tui_set_layout): Update.
 765         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 766         method.
 767
 768 2019-07-17  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 771         * tui/tui-windata.c (tui_display_data_from): Remove.
 772         (tui_data_window::refresh_all): Update.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 777         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 778         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 779         tui_display_registers_from_line.
 780         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 781         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 782         "force_display" parameter.
 783
 784 2019-07-17  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 787         declare.
 788         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 789         Rename from tui_first_reg_element_no_inline.
 790         (tui_display_reg_element_at_line)
 791         (tui_display_registers_from_line): Update.
 792         * tui/tui-data.h (struct tui_data_window)
 793         <first_reg_element_no_inline>: New method.
 794
 795 2019-07-17  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-windata.c (tui_display_data_from)
 798         (tui_data_window::do_scroll_vertical): Update.
 799         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 800         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 801         Rename from tui_line_from_reg_element_no.
 802         (tui_display_registers_from_line): Update.
 803         * tui/tui-data.h (struct tui_data_window)
 804         <line_from_reg_element_no>: New method.
 805
 806 2019-07-17  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 809         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 810         tui_last_regs_line_no.
 811         (tui_display_reg_element_at_line)
 812         (tui_display_registers_from_line): Update.
 813         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 814         method.
 815
 816 2019-07-17  Tom Tromey  <tom@tromey.com>
 817
 818         PR tui/24722:
 819         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 820         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 821         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 822         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 823         (tui_update_breakpoint_info): Likewise.
 824         * tui/tui-hooks.c (tui_event_create_breakpoint)
 825         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 826         Update.
 827
 828 2019-07-17  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 831
 832 2019-07-17  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.c (tui_update_source_window_as_is)
 835         (tui_update_source_windows_with_addr): Update.
 836         * tui/tui-source.h (tui_set_source_content)
 837         (tui_show_symtab_source): Add "win_info" parameter.
 838         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 839         parameter.
 840         (tui_show_symtab_source): Likewise.
 841
 842 2019-07-17  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-wingeneral.c
 845         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 846
 847 2019-07-17  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 850         (struct tui_cmd_window) <can_scroll>: New method.
 851         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 852         method.
 853
 854 2019-07-17  Tom Tromey  <tromey@adacore.com>
 855
 856         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 857         do_field_signed>: Rename.  Change type of "value".
 858         * ui-out.c (ui_out::field_signed): Rename from field_int.
 859         Change type of "value".
 860         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 861         type of "value".
 862         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 863         do_field_int.  Change type of "value".
 864         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 865         do_field_int.  Change type of "value".
 866         * tracepoint.c (trace_status_mi, tfind_1)
 867         (print_one_static_tracepoint_marker): Update.
 868         * thread.c (print_thread_info_1, print_selected_thread_frame):
 869         Update.
 870         * stack.c (print_frame, print_frame_info): Update.
 871         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 872         Update.
 873         * source.c (print_source_lines_base): Update.
 874         * skip.c (info_skip_command): Update.
 875         * record-btrace.c (btrace_ui_out_decode_error)
 876         (btrace_call_history_src_line): Update.
 877         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 878         Update.
 879         * progspace.c (print_program_space): Update.
 880         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 881         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 882         do_field_int.  Change type of "value".
 883         * mi/mi-out.c (mi_ui_out::do_table_begin)
 884         (mi_ui_out::do_table_header): Update.
 885         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 886         type of "value".
 887         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 888         (mi_cmd_data_list_changed_registers, output_register)
 889         (mi_cmd_data_read_memory, mi_load_progress)
 890         (mi_cmd_trace_frame_collected): Update.
 891         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 892         Update.
 893         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 894         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 895         (mi_cmd_var_list_children, varobj_update_one): Update.
 896         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 897         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 899         * inferior.c (print_inferior): Update.
 900         * gdb_bfd.c (print_one_bfd): Update.
 901         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 902         Update.
 903         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 904         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 905         do_field_int.  Change type of "value".
 906         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 907         do_field_int.  Change type of "value".
 908         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 909         (print_one_breakpoint_location, print_it_catch_fork)
 910         (print_one_catch_fork, print_it_catch_vfork)
 911         (print_one_catch_vfork, print_it_catch_solib)
 912         (print_it_catch_exec, print_it_ranged_breakpoint)
 913         (print_mention_watchpoint, print_mention_masked_watchpoint)
 914         (bkpt_print_it, update_static_tracepoint): Update.
 915         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 916         * break-catch-syscall.c (print_it_catch_syscall): Update.
 917         * ada-tasks.c (print_ada_task_info): Update.
 918         * ada-lang.c (print_it_exception, print_mention_exception):
 919         Update.
 920
 921 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         PR breakpoints/24541
 924         * gdbarch.c: Regenerate.
 925         * gdbarch.h: Regenerate.
 926         * gdbarch.sh: Adjust return type and parameter types for
 927         'stap_adjust_register'.
 928         (i386_stap_adjust_register): Adjust signature and return new
 929         register name.
 930         * stap-probe.c (stap_parse_register_operand): Adjust use of
 931         'gdbarch_stap_adjust_register'.
 932
 933 2019-07-17  Tom Tromey  <tromey@adacore.com>
 934
 935         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 936         declare VEC.
 937         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 938         std::vector.
 939         (struct s390_process_info): Add initializers.
 940         (s390_add_process): Use new.
 941         (s390_linux_nat_target::low_forget_process): Use delete.
 942         (s390_linux_nat_target::low_new_fork)
 943         (s390_linux_nat_target::stopped_by_watchpoint)
 944         (s390_linux_nat_target::low_prepare_to_resume)
 945         (s390_linux_nat_target::insert_watchpoint)
 946         (s390_linux_nat_target::insert_hw_breakpoint)
 947         (s390_linux_nat_target::remove_watchpoint)
 948         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 949
 950 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 951
 952         * aarch64-fbsd-nat.c: Include regcache.h.
 953         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 954         argument.
 955         (aarch64_fbsd_nat_target::fetch_registers)
 956         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 957         variable.
 958         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 959
 960 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 961
 962         * fbsd-nat.c: Include gdbarch.h.
 963
 964 2019-07-15  Tom Tromey  <tromey@adacore.com>
 965
 966         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 967
 968 2019-07-15  Tom Tromey  <tromey@adacore.com>
 969
 970         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 971         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 972         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 973         * cli-out.c (cli_ui_out::do_field_int): New method.
 974         * ui-out.c (ui_out::field_unsigned): New method.
 975         * symfile.c (generic_load): Use field_unsigned.
 976         (print_transfer_performance): Likewise.
 977         * record-btrace.c (ui_out_field_uint): Remove.
 978         (btrace_call_history_insn_range, btrace_call_history): Use
 979         field_unsigned.
 980         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 981         field_unsigned.
 982         * ui-out.h (class ui_out) <field_unsigned>: New method.
 983         <do_field_unsigned>: Likewise.
 984
 985 2019-07-15  Tom Tromey  <tromey@adacore.com>
 986
 987         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 988         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 989         * target.c (flash_erase_command): Use field_string.
 990         * infrun.c (print_signal_received_reason): Use field_string.
 991         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 992         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 993         field_string.
 994         * ada-tasks.c (print_ada_task_info): Use field_string.
 995
 996 2019-07-15  Tom Tromey  <tromey@adacore.com>
 997
 998         * target.c (flash_erase_command): Use field_core_addr.
 999         * symfile.c (generic_load): Use field_core_addr.
1000         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1001         Use field_core_addr.
1002         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1003         field_core_addr.
1004
1005 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1008         value if its desired type is smaller than a CORE_ADDR and signed.
1009
1010 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1013         of changes to field names, and use new is_reference field to
1014         decide if a property is a reference or not.
1015         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1016         field.
1017         (struct dwarf2_property_baton): Update header comment, rename
1018         'referenced_type' to 'property_type' and update comments.
1019         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1020         default property type, store in property baton, update to take
1021         accound of renamed field.
1022         (read_func_scope): Update call to attr_to_dynamic_prop.
1023         (read_array_type): Likewise.
1024         (dwarf2_per_cu_addr_sized_int_type): New function.
1025         (read_subrange_index_type): Move type finding code to
1026         dwarf2_per_cu_addr_sized_int_type.
1027         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1028         (dwarf2_per_cu_addr_type): New function.
1029         (set_die_type): Update calls to attr_to_dynamic_prop.
1030
1031 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * dwarf2read.c (read_subrange_index_type): New function.
1034         (read_subrange_type): Move code into new function and call it.
1035         * gdbtypes.c (create_range_type): Add some asserts.
1036
1037 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1040         update return statements.
1041         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1042         declaration, and update comment to match.
1043         * gdbtypes.c (resolve_dynamic_array): Update call to
1044         dwarf2_evaluate_property to match new return type.
1045
1046 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * valarith.c (value_subscripted_rvalue): Change lowerbound
1049         parameter type from int to LONGEST.
1050         * value.h (value_subscripted_rvalue): Likewise in declaration.
1051
1052 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * cli/cli-utils.c (info_print_command_completer): New function.
1055         * cli/cli-utils.h: Add 'completer.h' include, and forward
1056         declaration for 'struct cmd_list_element'.
1057         (info_print_command_completer): Declare.
1058         * stack.c (_initialize_stack): Add completer for 'info locals' and
1059         'info args'.
1060         * symtab.c (_initialize_symtab): Add completer for 'info
1061         variables' and 'info functions'.
1062         * NEWS: Mention completion for additional info commands.
1063
1064 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * cli/cli-utils.c (extract_info_print_args): Delete.
1067         (extract_arg_maybe_quoted): Delete.
1068         (info_print_options_defs): New variable.
1069         (make_info_print_options_def_group): New function.
1070         (extract_info_print_options): Define new function.
1071         * cli/cli-utils.h (extract_info_print_args): Delete.
1072         (struct info_print_options): New structure.
1073         (extract_info_print_options): Declare new function.
1074         * stack.c (info_locals_command): Update to use new
1075         extract_info_print_options, also add a header comment.
1076         (info_args_command): Likewise.
1077         * symtab.c (info_variables_command): Likewise.
1078         (info_functions_command): Likewise.
1079
1080 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1083         to extract string arguments.
1084         * common/common-utils.c (extract_string_maybe_quoted): New function.
1085         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1086
1087 2019-07-11  Tom Tromey  <tromey@adacore.com>
1088
1089         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1090         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1091         * top.h (gdbinit): Don't declare.
1092         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1093         into...
1094         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1095         * top.c (gdb_init): Don't call init_cli_cmds.
1096         (gdbinit): Remove.
1097         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1098
1099 2019-07-11  Tom Tromey  <tromey@adacore.com>
1100
1101         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1102         after it has been moved.
1103
1104 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1105
1106         * valops.c (value_must_coerce_to_target): Change return type to
1107         bool.
1108         * value.h (value_must_coerce_to_target): Likewise.
1109
1110 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1111
1112         * breakpoint.c (is_hardware_watchpoint): Remove
1113         forward-declaration.
1114         (is_masked_watchpoint): Change return type to bool.
1115         (is_tracepoint): Likewise.
1116         (is_breakpoint): Likewise.
1117         (is_hardware_watchpoint): Likewise.
1118         (is_watchpoint): Likewise.
1119         (is_no_memory_software_watchpoint): Likewise.
1120         (is_catchpoint): Likewise.
1121         (breakpoint_1): Make FILTER parameter's return type bool.
1122         is_masked_watchpoint): Change return type to bool.
1123         (save_breakpoints): Make FILTER parameter's return type bool.
1124         * breakpoint.h (is_breakpoint): Change return type to bool.
1125         (is_watchpoint): Likewise.
1126         (is_catchpoint): Likewise.
1127         (is_tracepoint): Likewise.
1128
1129 2019-07-10  Tom Tromey  <tom@tromey.com>
1130
1131         * defs.h: Don't include gdbarch.h.
1132         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1133         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1134         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1135         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1136         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1137         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1138         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1139         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1140         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1141         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1142         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1143         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1144         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1145         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1146         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1147         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1148         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1149         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1150         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1151         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1152         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1153         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1154         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1155         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1156         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1157         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1158         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1159
1160 2019-07-10  Tom Tromey  <tromey@adacore.com>
1161
1162         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1163         * breakpoint.c (init_ada_exception_breakpoint): Register as
1164         bp_catchpoint.
1165         (print_one_breakpoint_location, print_one_breakpoint): Use
1166         is_ada_exception_catchpoint.
1167         * ada-lang.c (class ada_catchpoint_location): Pass
1168         bp_loc_software_breakpoint to bp_location constructor.
1169         (is_ada_exception_catchpoint): New function.
1170
1171 2019-07-10  Tom Tromey  <tromey@adacore.com>
1172
1173         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1174         VEC.
1175         (struct arm_exidx_entry): New method operator<.
1176         (struct arm_exidx_data) <section_maps>: Change type.
1177         (arm_exidx_data_free): Remove.
1178         (arm_exidx_data_key): Change type.  Move lower.
1179         (arm_exidx_new_objfile): Update.
1180         (arm_compare_exidx_entries): Remove.
1181         (arm_find_exidx_entry, _initialize_arm_tdep)
1182
1183 2019-07-10  Tom Tromey  <tromey@adacore.com>
1184
1185         * solib-spu.c (ocl_program_data_key): Change type.
1186         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1187         Update.
1188
1189 2019-07-10  Tom Tromey  <tromey@adacore.com>
1190
1191         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1192         (struct solib_aix_inferior_data) <library_list>: Change type.
1193         (solib_aix_inferior_data_handle): Change type.
1194         (get_solib_aix_inferior_data): Update.
1195         (solib_aix_free_library_list): Remove.
1196         (library_list_start_library): Update.
1197         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1198         return type.
1199         (solib_aix_get_library_list)
1200         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1201         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1202
1203 2019-07-10  Tom Tromey  <tromey@adacore.com>
1204
1205         * solib-dsbt.c (struct dsbt_info): Add initializers.
1206         (solib_dsbt_pspace_data): Change type.
1207         (dsbt_pspace_data_cleanup): Remove.
1208         (get_dsbt_info, _initialize_dsbt_solib): Update.
1209
1210 2019-07-10  Tom Tromey  <tromey@adacore.com>
1211
1212         * spu-tdep.c (spu_overlay_data): Change type.
1213         (spu_get_overlay_table, spu_overlay_new_objfile)
1214         (_initialize_spu_tdep): Update.
1215
1216 2019-07-10  Tom Tromey  <tromey@adacore.com>
1217
1218         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1219         destructor.
1220         (dbx_objfile_data_key): Change type and declare later.
1221         (DBX_SYMFILE_INFO): Rewrite.
1222         * dbxread.c (dbx_objfile_data_key): Change type.
1223         (dbx_symfile_init): Update.
1224         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1225         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1226         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1227
1228 2019-07-10  Tom Tromey  <tromey@adacore.com>
1229
1230         * jit.c (jit_program_space_key): Change type.  Move lower.
1231         (get_jit_program_space_data): Update.
1232         (jit_program_space_data_cleanup): Remove.
1233         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1234         Update.
1235         (struct jit_program_space_data): Add initializers.
1236
1237 2019-07-10  Tom Tromey  <tromey@adacore.com>
1238
1239         * solib-darwin.c (struct darwin_info): Add initializers.
1240         (solib_darwin_pspace_data): Change type.
1241         (darwin_pspace_data_cleanup): Remove.
1242         (get_darwin_info, _initialize_darwin_solib): Update.
1243
1244 2019-07-10  Tom Tromey  <tromey@adacore.com>
1245
1246         * remote-sim.c (struct sim_inferior_data): Add initializers,
1247         constructor, and destructor.
1248         (sim_inferior_data_key): Change type.  Move lower.
1249         (check_for_duplicate_sim_descriptor): Update.
1250         (get_sim_inferior_data): Use new.  Update.
1251         (~sim_inferior_data_cleanup): Rename from
1252         sim_inferior_data_cleanup.  Simplify.
1253         (gdbsim_close_inferior, simulator_command)
1254         (sim_command_completer, _initialize_remote_sim): Update.
1255         (next_pid, INITIAL_PID): Move earlier.
1256
1257 2019-07-10  Tom Tromey  <tromey@adacore.com>
1258
1259         * python/python-internal.h (create_thread_object): Return
1260         gdbpy_ref.
1261         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1262         * python/py-inferior.c (struct threadlist_entry): Add
1263         constructor.
1264         <thread_obj>: Now a gdbpy_ref.
1265         (thread_to_thread_object): Update.
1266         (add_thread_object): Use new.
1267         (delete_thread_object): Use delete.
1268         (infpy_threads): Update.
1269         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1270         GIL.
1271
1272 2019-07-10  Tom Tromey  <tromey@adacore.com>
1273
1274         * valops.c (value_cast): Specialize error message for Ada.
1275
1276 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1277
1278         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1279
1280 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1281
1282         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1283         bpstat_should_step): Return bool, adjust comments.
1284         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1285         bpstat_should_step): Likewise.
1286
1287 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1288
1289         * features/Makefile: Use feature target descriptions for Arm.
1290         * features/arm/arm-core.c: Generate new file.
1291         * features/arm/arm-fpa.c: Likewise.
1292         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1293         * features/arm/arm-m-profile.c: Likewise.
1294         * features/arm/arm-vfpv2.c: Likewise.
1295         * features/arm/arm-vfpv3.c: Likewise.
1296         * features/arm/xscale-iwmmxt.c: Likewise.
1297         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1298
1299 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1300
1301         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1302         ptrace earlier.
1303
1304 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1305
1306         * features/aarch64-pauth.c: Regenerate.
1307
1308 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1309
1310         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1311         bool.
1312         (bpstat_what): Use false instead of 0.
1313
1314 2019-07-09  Pedro Alves  <palves@redhat.com>
1315
1316         * break-catch-throw.c (is_exception_catchpoint): New.
1317         * breakpoint.c (print_one_breakpoint_location): New parameter
1318         'raw_loc'.  Handle it.  Use
1319         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1320         looking at the breakpoint's type.
1321         (print_one_breakpoint): If handling "maint info breakpoints", also
1322         print locations of exception catchpoints.
1323         * breakpoint.h (is_exception_catchpoint): Declare.
1324
1325 2019-07-09  Pedro Alves  <palves@redhat.com>
1326
1327         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1328         "addr" field.
1329         (allocate_location_exception_catchpoint): New.
1330         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1331         (initialize_throw_catchpoint_ops): Install
1332         allocate_location_exception_catchpoint as allocate_location
1333         method.
1334         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1335         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1336         bp_loc_other.
1337         (breakpoint_address_is_meaningful): Delete.
1338         (bl_address_is_meaningful): New.
1339         (breakpoint_locations_match): Adjust comment.
1340         (bp_location_from_bp_type): New, factored out of...
1341         (bp_location::bp_location(breakpoint *)): ... this.
1342         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1343         factored out of...
1344         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1345         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1346         breakpoint_address_is_meaningful.
1347         (bp_locations_compare): Adjust comment.
1348         (update_global_location_list): Use bl_address_is_meaningful
1349         instead of breakpoint_address_is_meaningful.
1350         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1351         explicit.
1352         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1353         * python/py-breakpoint.c (bppy_get_location): No longer check
1354         whether location is null.
1355
1356 2019-07-09  Pedro Alves  <palves@redhat.com>
1357
1358         PR c++/15468
1359         * breakpoint.c (print_one_breakpoint_location): Remove
1360         single-location assert.
1361
1362 2019-07-09  Tom Tromey  <tom@tromey.com>
1363
1364         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1365         * configure: Rebuild.
1366         * configure.ac: Change common to gdbsupport.
1367         * gdbsupport: Rename from common.
1368         * acinclude.m4: Change common to gdbsupport.
1369         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1370         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1371         gdbsupport.
1372         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1373         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1374         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1375         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1376         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1377         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1378         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1379         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1380         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1381         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1382         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1383         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1384         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1385         coff-pe-read.c, command.h, compile/compile-c-support.c,
1386         compile/compile-c.h, compile/compile-cplus-symbols.c,
1387         compile/compile-cplus-types.c, compile/compile-cplus.h,
1388         compile/compile-loc2c.c, compile/compile.c, completer.c,
1389         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1390         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1391         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1392         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1393         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1394         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1395         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1396         features/aarch64-core.c, features/aarch64-fpu.c,
1397         features/aarch64-pauth.c, features/aarch64-sve.c,
1398         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1399         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1400         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1401         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1402         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1403         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1404         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1405         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1406         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1407         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1408         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1409         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1410         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1411         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1412         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1413         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1414         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1415         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1416         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1417         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1418         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1419         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1420         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1421         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1422         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1423         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1424         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1425         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1426         minsyms.c, mips-linux-tdep.c, namespace.h,
1427         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1428         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1429         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1430         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1431         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1432         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1433         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1434         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1435         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1436         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1437         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1438         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1439         procfs.c, producer.c, progspace.h, psymtab.h,
1440         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1441         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1442         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1443         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1444         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1445         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1446         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1447         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1448         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1449         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1450         target-memory.c, target.c, target.h, target/waitstatus.c,
1451         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1452         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1453         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1454         unittests/array-view-selftests.c,
1455         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1456         unittests/common-utils-selftests.c,
1457         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1458         unittests/format_pieces-selftests.c,
1459         unittests/function-view-selftests.c,
1460         unittests/lookup_name_info-selftests.c,
1461         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1462         unittests/mkdir-recursive-selftests.c,
1463         unittests/observable-selftests.c,
1464         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1465         unittests/parse-connection-spec-selftests.c,
1466         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1467         unittests/scoped_fd-selftests.c,
1468         unittests/scoped_mmap-selftests.c,
1469         unittests/scoped_restore-selftests.c,
1470         unittests/string_view-selftests.c, unittests/style-selftests.c,
1471         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1472         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1473         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1474         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1475         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1476         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1477
1478 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1481         bool value.
1482         (decode_digits_ordinary): Set explicit_line field in sal.
1483         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1484         symtab_and_line that was set on an explicit line number in
1485         assembler code.  Do always update the recorded symtab and line if
1486         we do skip the prologue.
1487
1488 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * breakpoint.c (set_breakpoint_location_function): Remove
1491         explicit_loc parameter.
1492         (momentary_breakpoint_from_master): Update call to
1493         set_breakpoint_location_function.
1494         (add_location_to_breakpoint): Likewise.
1495
1496 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1499         required features based on default bfd type when no specific bfd
1500         is present.
1501
1502 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1503
1504         * NEWS: Mention that GDB printf and eval commands can now print
1505         C-style and Ada-style convenience var strings without
1506         calling the inferior.
1507         * printcmd.c (printf_c_string): Locally print GDB internal var
1508         instead of transiting via the inferior.
1509         (printf_wide_c_string): Likewise.
1510
1511 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1512
1513         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1514
1515 2019-07-04  Tom Tromey  <tom@tromey.com>
1516
1517         PR tui/24724:
1518         * tui/tui-winsource.c (tui_clear_source_content): Update.
1519         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1520         (tui_update_breakpoint_info): Update.
1521         (tui_set_exec_info_content): Update.
1522         * tui/tui-source.c (tui_set_source_content_nil): Update.
1523         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1524         has_break.
1525         * tui/tui-data.h (enum tui_bp_flag): New.
1526         (tui_bp_flags): New enum flags type.
1527         (struct tui_source_element) <break_mode>: Change type.  Rename
1528         from has_break.
1529         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1530         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1531         constants.
1532         * tui/tui-winsource.h: Fix comment.
1533
1534 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1537         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1538         (store_fpregs_to_thread)
1539         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1540         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1541         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1542         (IWMMXT_REGS_SIZE): Add define.
1543         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1544         (fetch_vfp_regs, store_vfp_regs)
1545         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1546         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1547
1548 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1551         defines.
1552         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1553         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1554         (ARM_INT_REGISTER_SIZE): ...to this.
1555         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1556         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1557         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1558         (arm_linux_collect_gregset, supply_nwfpe_register)
1559         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1560         defines.
1561         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1562         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1563         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1564         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1565         (arm_return_in_memory, arm_store_return_value)
1566         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1567         (arm_record_ld_st_multiple): Likewise.
1568         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1569         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1570
1571 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1572
1573         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1574         AARCH64_DISPLACED_MODIFIED_INSNS.
1575         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1576         (aarch64_displaced_step_copy_insn): Likewise.
1577         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1578         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1579         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1580         ARM_DISPLACED_MODIFIED_INSNS.
1581         * arm-tdep.c (arm_gdbarch_init): Likewise.
1582         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1583         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1584         (struct arm_displaced_step_closure): Use
1585         ARM_DISPLACED_MODIFIED_INSNS.
1586
1587 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * features/Makefile: Remove unused xml files.
1590         * features/aarch64.xml: Remove.
1591         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1592         * features/i386/amd64-avx-avx512.xml: Remove.
1593         * features/i386/amd64-avx-linux.xml: Remove.
1594         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1595         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1596         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1597         * features/i386/amd64-avx-mpx.xml: Remove.
1598         * features/i386/amd64-avx.xml: Remove.
1599         * features/i386/amd64-linux.xml: Remove.
1600         * features/i386/amd64-mpx-linux.xml: Remove.
1601         * features/i386/amd64-mpx.xml: Remove.
1602         * features/i386/amd64.xml: Remove.
1603         * features/i386/i386-avx-avx512-linux.xml: Remove.
1604         * features/i386/i386-avx-avx512.xml: Remove.
1605         * features/i386/i386-avx-linux.xml: Remove.
1606         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1607         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1608         * features/i386/i386-avx-mpx-linux.xml: Remove.
1609         * features/i386/i386-avx-mpx.xml: Remove.
1610         * features/i386/i386-avx.xml: Remove.
1611         * features/i386/i386-linux.xml: Remove.
1612         * features/i386/i386-mmx-linux.xml: Remove.
1613         * features/i386/i386-mmx.xml: Remove.
1614         * features/i386/i386-mpx-linux.xml: Remove.
1615         * features/i386/i386-mpx.xml: Remove.
1616         * features/i386/i386.xml: Remove.
1617         * features/i386/x32-avx-avx512-linux.xml: Remove.
1618         * features/i386/x32-avx-linux.xml: Remove.
1619         * features/i386/x32-linux.xml: Remove.
1620
1621 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1622
1623         * regformats/aarch64.dat: Remove.
1624         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1625         * regformats/i386/amd64-avx-linux.dat: Remove.
1626         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1627         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1628         * regformats/i386/amd64-linux.dat: Remove.
1629         * regformats/i386/amd64-mpx-linux.dat: Remove.
1630         * regformats/i386/amd64.dat: Remove.
1631         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1632         * regformats/i386/i386-avx-linux.dat: Remove.
1633         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1634         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1635         * regformats/i386/i386-linux.dat: Remove.
1636         * regformats/i386/i386-mmx-linux.dat: Remove.
1637         * regformats/i386/i386-mpx-linux.dat: Remove.
1638         * regformats/i386/i386.dat: Remove.
1639         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1640         * regformats/i386/x32-avx-linux.dat: Remove.
1641         * regformats/i386/x32-linux.dat: Remove.
1642
1643 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1644
1645         * aarch64-tdep.c: Remove xml self tests.
1646         * amd64-linux-tdep.c: Likewise.
1647         * amd64-tdep.c: Likewise.
1648         * i386-linux-tdep.c: Likewise.
1649         * i386-tdep.c: Likewise.
1650
1651 2019-07-03  Pedro Alves  <palves@redhat.com>
1652
1653         PR cli/24732
1654         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1655         (pipe_cmd_option_defs): New.
1656         (make_pipe_cmd_options_def_group): New.
1657         (pipe_command): Use gdb::option::process_options.
1658         (pipe_command_completer): New function.
1659         (_initialize_cli_cmds): Install completer for "pipe" command.
1660
1661 2019-07-03  Pedro Alves  <palves@redhat.com>
1662
1663         * cli/cli-option.c (union option_value) <string>: New field.
1664         (struct option_def_and_value): Add ctor, move ctor, dtor and
1665         use DISABLE_COPY_AND_ASSIGN.
1666         (option_def_and_value::clear_value): New.
1667         (parse_option, save_option_value_in_ctx, get_val_type_str)
1668         (add_setshow_cmds_for_options): Handle var_string.
1669         * cli-option.h (union option_def::var_address) <string>: New
1670         field.
1671         (struct string_option_def): New.
1672         * maint-test-options.c (struct test_options_opts): Add default
1673         ctor and use DISABLE_COPY_AND_ASSIGN.
1674         <string_opt>: New field.
1675         (test_options_opts::~test_options_opts): New.
1676         (test_options_opts::dump): Also dump "-string".
1677         (test_options_option_defs): Install "string.
1678
1679 2019-07-03  Pedro Alves  <palves@redhat.com>
1680
1681         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1682         option_value with a null enumeration.
1683         (complete_options): Save the option values in the context.
1684         (save_option_value_in_ctx): New, factored out from ...
1685         (process_options): ... here.
1686         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1687         of the function.
1688         * maint-test-options.c (test_options_opts::dump): New, factored
1689         out from ...
1690         (maintenance_test_options_command_mode): ... here.
1691         (maintenance_test_options_command_completion_result): Delete.
1692         (maintenance_test_options_command_completion_text): Update
1693         comment.
1694         (maintenance_show_test_options_completion_result): Change
1695         prototype.  Just print
1696         maintenance_test_options_command_completion_text.
1697         (save_completion_result): New.
1698         (maintenance_test_options_completer_mode): Pass options context to
1699         complete_options, and then save a dump.
1700         (_initialize_maint_test_options): Use add_cmd to install "maint
1701         show test-options-completion-result".
1702
1703 2019-07-03  Pedro Alves  <palves@redhat.com>
1704
1705         * NEWS (New commands): Mention "with" and "maint with".
1706         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1707         (with_command, with_command_completer): New.
1708         (pipe_command): Adjust to new repeat_previous
1709         interface.
1710         (_initialize_cli_cmds): Install the "with" command and its "w"
1711         alias.
1712         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1713         declarations.
1714         * cli/cli-setshow.c (parse_cli_var_uinteger)
1715         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1716         argument strings for all var_types.
1717         (get_setshow_command_value_string): New, factored out from ...
1718         (do_show_command): ... this.
1719         * cli/cli-setshow.h: Include <string>.
1720         (get_setshow_command_value_string): Declare.
1721         * command.h (repeat_previous): Now returns const char *.  Adjust
1722         comment.
1723         * maint.c: Include "cli/cli-cmds.h".
1724         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1725         (_initialize_maint_cmds): Register the "maintenance with" command.
1726         * top.c (repeat_previous): Move bits from pipe_command here:
1727         Return the saved command line, if any; error out if there's no
1728         command to relaunch.
1729
1730 2019-07-03  Pedro Alves  <palves@redhat.com>
1731
1732         * NEWS (New commands): Mention "maint set/show test-settings"
1733         instead of "maint test-settings".
1734         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1735         (maintenance_test_settings_set_list): Rename to ...
1736         (maintenance_set_test_settings_list): ... this.
1737         (maintenance_test_settings_show_list): Rename to  ...
1738         (maintenance_show_test_settings_list): ... this.
1739         (maintenance_test_settings_cmd): Delete.
1740         (maintenance_test_settings_set_cmd): ...
1741         (maintenance_set_test_settings_cmd): ... this.
1742         (maintenance_test_settings_show_cmd): ...
1743         (maintenance_show_test_settings_cmd): ... this.
1744         (maintenance_test_settings_show_value_cmd):
1745         (maintenance_show_test_settings_value_cmd): ... this.
1746         (_initialize_maint_test_settings): No longer install the "maint
1747         test-settings" prefix command.  Rename "maint test-settings set"
1748         to "maint set test-settings", and "maint test-settings show" to
1749         "maint show test-settings".  Adjust all subcommands.
1750
1751 2019-07-03  Pedro Alves  <palves@redhat.com>
1752
1753         * maint-test-settings.c: Fix file's intro comment.  Replace all
1754         references to "test-options" with references to "test-settings",
1755         in comments.
1756
1757 2019-07-03  Pedro Alves  <palves@redhat.com>
1758
1759         * maint-test-settings.c (maintenance_test_settings_xxx)
1760         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1761         New.
1762         (maintenance_test_settings_enums): Use them.
1763         (maintenance_test_settings_enum): Default to
1764         maintenance_test_settings_xxx.
1765         (_initialize_maint_test_settings): Initialize
1766         MAINTENANCE_TEST_SETTINGS_FILENAME.
1767
1768 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1769
1770         * breakpoint.h (remove_breakpoints_inf): Change return type to
1771         void, move function documentation here.
1772         * breakpoint.c (remove_breakpoints_inf): Change return type to
1773         void, move function documentation to header.
1774
1775 2019-07-02  Pedro Alves  <palves@redhat.com>
1776
1777         * NEWS (Completion improvements): Mention "info threads".
1778         * thread.c (struct info_threads_opts, info_threads_option_defs)
1779         (make_info_threads_options_def_group): New.
1780         (info_threads_command): Use gdb::option::process_options.
1781         (info_threads_command_completer): New.
1782         (_initialize_thread): Use gdb::option::build_help to build the
1783         help text for "info threads".
1784
1785 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1786
1787         * defs.h (generic_load): Move from here...
1788         * symfile.h (generic_load): ... to here.  Rename name parameter
1789         to args.
1790         * symfile.c (generic_load): Add comment.
1791
1792 2019-07-01  Tom Tromey  <tromey@adacore.com>
1793
1794         * dwarf2read.c
1795         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1796         declaration of without_params.  Fix formatting.
1797
1798 2019-07-01  Tom Tromey  <tromey@adacore.com>
1799
1800         * ada-exp.y (find_primitive_type): Update.
1801         * ada-lang.h (ada_lookup_symbol): Update.
1802         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1803         parameter.
1804         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1805
1806 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1807
1808         PR breakpoints/24541
1809         * gdbarch.c: Regenerate.
1810         * gdbarch.h: Regenerate.
1811         * gdbarch.sh: Add 'stap_adjust_register'.
1812         * i386-tdep.c: Include '<unordered_set>'.
1813         (i386_stap_adjust_register): New function.
1814         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1815         * stap-probe.c (stap_parse_register_operand): Call
1816         'gdbarch_stap_adjust_register'.
1817
1818 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1819
1820         PR python/24742
1821         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1822         * python/python.c (do_start_initialization): Use 'xmalloc'
1823         instead of 'PyMem_Malloc'.
1824
1825 2019-06-28  Tom Tromey  <tromey@adacore.com>
1826
1827         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1828         for Ada.
1829
1830 2019-06-27  Tom Tromey  <tromey@adacore.com>
1831
1832         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1833         objfile_key.
1834         (arm_find_mapping_symbol, arm_record_special_symbol)
1835         (_initialize_arm_tdep): Update.
1836         (arm_objfile_data_free): Remove.
1837
1838 2019-06-27  Tom Tromey  <tromey@adacore.com>
1839
1840         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1841         to cp_print_static_field.
1842
1843 2019-06-26  Tom Tromey  <tromey@adacore.com>
1844
1845         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1846         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1847         declare.
1848
1849 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1850
1851         * features/aarch64-core.c (create_feature_aarch64_core):
1852         Regenerate.
1853         * features/aarch64-core.xml: Add cpsr flags.
1854
1855 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1856
1857         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1858         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1859
1860 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1861
1862         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1863         field.
1864         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1865         use.
1866         (arm_record_special_symbol): Don't insert new symbol in sorted
1867         position, push it at the end.
1868
1869 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1870
1871         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1872         (arm_mapping_symbol_s): Remove.
1873         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1874         (arm_mapping_symbol_vec): New typedef.
1875         (struct arm_per_objfile): Add constructor.
1876         <section_maps>: Change type to
1877         std::unique_ptr<arm_mapping_symbol_vec[]>.
1878         (arm_compare_mapping_symbols): Remove.
1879         (arm_find_mapping_symbol): Adjust to section_maps type change.
1880         (arm_objfile_data_free): Call delete on arm_per_objfile.
1881         (arm_record_special_symbol): Adjust to section_maps type change.
1882         Allocate arm_per_objfile with new.
1883
1884 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1885
1886         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1887         with the command prefix.
1888
1889 2019-06-25  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1892         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1897         type.
1898         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1899         protected.
1900
1901 2019-06-25  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-winsource.c
1904         (tui_source_window_base::set_is_exec_point_at): Add check against
1905         LOA_ADDRESS.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-source.c (tui_set_source_content): Don't check before
1910         xfree.
1911         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-winsource.h (tui_update_source_window_as_is)
1916         (tui_alloc_source_buffer, tui_line_is_displayed)
1917         (tui_addr_is_displayed): Change type of win_info.
1918         * tui/tui-winsource.c (tui_update_source_window_as_is)
1919         (tui_clear_source_content, tui_show_source_line)
1920         (tui_show_source_content, tui_source_window_base::refill)
1921         (tui_source_window_base::set_is_exec_point_at)
1922         (tui_source_window_base::set_is_exec_point_at)
1923         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1924         (tui_alloc_source_buffer, tui_line_is_displayed)
1925         (tui_addr_is_displayed): Change type of win_info.  Update.
1926         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1927         (tui_source_window_base::do_make_visible_with_new_height):
1928         Update.
1929         * tui/tui-source.c (tui_set_source_content)
1930         (tui_set_source_content_nil)
1931         (tui_source_window::do_scroll_vertical): Update.
1932         * tui/tui-layout.c (show_layout): Update.
1933         * tui/tui-disasm.c (tui_set_disassem_content)
1934         (tui_disasm_window::do_scroll_vertical): Update.
1935         * tui/tui-data.h (tui_win_content): Remove.
1936         (struct tui_gen_win_info) <content, content_size>: Remove.
1937         (struct tui_source_element): Add initializers and destructor.
1938         (union tui_which_element, struct tui_win_element): Remove.
1939         (struct tui_source_window_base) <content>: New field.
1940         (struct tui_data_window): Remove destructor.
1941         (tui_alloc_content, tui_free_win_content)
1942         (tui_free_all_source_wins_content): Don't declare.
1943         * tui/tui-data.c (tui_initialize_static_data): Update.
1944         (init_content_element, tui_alloc_content): Remove.
1945         (~tui_gen_win_info): Update.
1946         (~tui_data_window, tui_free_all_source_wins_content)
1947         (tui_free_win_content, free_content, free_content_elements):
1948         Remove.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-winsource.h (tui_clear_source_content)
1953         (tui_erase_source_content, tui_show_source_content): Change type
1954         of win_info.
1955         * tui/tui-winsource.c (tui_clear_source_content)
1956         (tui_erase_source_content, tui_show_source_content): Change type
1957         of win_info.
1958         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1959         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1960         win_info.
1961         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1962         win_info.
1963         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-winsource.c (tui_clear_source_content)
1968         (tui_source_window_base::set_is_exec_point_at): Update.
1969         * tui/tui-source.c (tui_set_source_content_nil): Update.
1970         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1971         a bool.
1972         * tui/tui-data.c (init_content_element): Update.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1977         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1978         * tui/tui-layout.c (init_and_make_win): Update.
1979         * tui/tui.h (enum tui_win_type): Update.
1980         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1981         tui_win_is_auxillary.
1982         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1983         tui_win_is_auxillary.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1988         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1989         (tui_delete_data_content_windows, tui_display_all_data)
1990         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1991         Update.
1992         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1993         * tui/tui-regs.c (tui_last_regs_line_no)
1994         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1995         (tui_show_registers): Update.
1996         (tui_show_register_group): Return void.  Update.
1997         (tui_display_registers_from, tui_display_reg_element_at_line)
1998         (tui_display_registers_from_line, tui_check_register_values):
1999         Update.
2000         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2001         member.
2002         (struct tui_data_window) <regs_content>: Now a std::vector.
2003         <regs_content_count>: Remove.
2004         (tui_add_content_elements, tui_free_data_content): Don't declare.
2005         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2006         (init_content_element): Remove DATA_WIN case.  Add assert.
2007         (tui_add_content_elements): Remove.
2008         (tui_data_window): Update.
2009         (tui_free_data_content): Remove.
2010         (free_content_elements): Remove DATA_WIN case.
2011
2012 2019-06-25  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-data.c (tui_data_item_window): Update.
2015         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2016         * tui/tui-windata.c (tui_display_all_data)
2017         (tui_display_data_from_line): Update.
2018         (tui_check_data_values): Remove.
2019         * tui/tui-regs.c (tui_show_register_group)
2020         (tui_display_reg_element_at_line): Update.
2021         * tui/tui-hooks.c (tui_register_changed)
2022         (tui_refresh_frame_and_register_information): Call
2023         tui_check_register_values.
2024         * tui/tui-data.h (struct tui_data_window) <data_content,
2025         data_content_count, data_type>: Remove.
2026         (enum tui_data_type): Remove.
2027
2028         * tui/tui-data.c (tui_data_window::clear_detail)
2029         (~tui_data_window): Update.
2030
2031 2019-06-25  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2034         declare.
2035         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2036         Rename from tui_first_data_item_displayed.  Update.
2037         (tui_data_window::refresh_all)
2038         (tui_data_window::do_scroll_vertical): Update.
2039         * tui/tui-data.h (struct tui_data_window)
2040         <first_data_item_displayed>: Declare new method.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2045         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2046         contents...
2047         (tui_initialize_static_data): ...here.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2052         (tui_display_registers_from, tui_check_register_values): Update.
2053         (tui_display_register): Remove win_info parameter; update.
2054         (tui_get_register): Change type of parameters.
2055         * tui/tui-data.h (struct tui_data_element): Remove.
2056         (union tui_which_element) <data>: Remove.
2057         <data_window>: Change type.
2058         (struct tui_data_item_window): New.
2059         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2060         case.  Add assert.
2061         (~tui_data_item_window): New destructor.
2062         (free_content_elements): Remove DATA_ITEM_WIN case.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2067         Remove.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-data.h (struct tui_command_element): Remove.
2072         (union tui_which_element) <command>: Remove.
2073         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2074         assert.
2075         (free_content_elements): Remove CMD_WIN case.
2076
2077 2019-06-25  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-layout.c (tui_set_layout): Update.
2080         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2081         * tui/tui-data.c (layout_def): Update.
2082
2083 2019-06-25  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2086         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2087         (tui_source_window_base::set_new_height): Update.
2088         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2089         Update.
2090         (tui_set_locator_fullname, tui_set_locator_info)
2091         (tui_show_frame_info): Update.
2092         * tui/tui-source.c (tui_set_source_content)
2093         (tui_source_is_displayed): Update.
2094         * tui/tui-layout.c (show_source_disasm_command, show_data)
2095         (show_source_or_disasm_and_command): Update.
2096         * tui/tui-disasm.c (tui_set_disassem_content)
2097         (tui_get_begin_asm_address): Update.
2098         * tui/tui-data.h (struct tui_locator_element): Remove.
2099         (union tui_which_element) <locator>: Remove.
2100         (struct tui_locator_window): New.
2101         (tui_locator_win_info_ptr): Change return type.
2102         * tui/tui-data.c (_locator): Change type.
2103         (tui_locator_win_info_ptr): Change return type.
2104         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2105         (tui_alloc_content): Add assert.
2106
2107 2019-06-25  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-winsource.c
2110         (tui_exec_info_window::maybe_allocate_content): New method.
2111         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2112         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2113         (make_source_or_disasm_window): Add cast.
2114         * tui/tui-data.h (union tui_which_element) <simple_string>:
2115         Remove.
2116         (struct tui_source_info): New.
2117         (struct tui_source_window_base) <execution_info>: Change type.
2118         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2119         case, and add assert.
2120         (tui_alloc_content): Add assert.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2125         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2126         * tui/tui-data.c (tui_alloc_win_info): Remove.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2131         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2132         can_highlight.
2133
2134 2019-06-25  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2137         make_visible_with_new_height method.
2138         (tui_win_info::make_visible_with_new_height): New method.
2139         (tui_source_window_base::do_make_visible_with_new_height)
2140         (tui_data_window::do_make_visible_with_new_height)
2141         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2142         (make_visible_with_new_height): Remove.
2143         (tui_resize_all, tui_adjust_win_heights): Use
2144         make_visible_with_new_height method.
2145         * tui/tui-data.h (struct tui_win_info)
2146         <do_make_visible_with_new_height, make_visible_with_new_height>:
2147         New methods.
2148         (struct tui_source_window_base, struct tui_data_window)
2149         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2150         methods.
2151
2152 2019-06-25  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2155         method.
2156         (update_tab_width): Call update_tab_width method.
2157         * tui/tui-data.h (struct tui_win_info)
2158         (struct tui_source_window_base) <update_tab_width>: New methods.
2159
2160 2019-06-25  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2163         parameter.
2164         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2165         parameter.
2166         (tui_gen_win_info::make_visible): Update.
2167         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2168         parameter.
2169         * tui/tui-data.h (enum tui_box): New enum.
2170         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2175         init_and_make_win for EXEC_INFO_WIN.
2176         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2177         longer inline.
2178         (struct tui_win_info) <~tui_win_info>: Inline.
2179         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2180         Don't declare.
2181         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2182         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2183         Remove.
2184         (tui_initialize_static_data): Update.
2185         (~tui_gen_win_info): Handle more cleanup here.
2186         (~tui_source_window_base): Delete "execution_info".
2187         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-layout.c (make_command_window): Don't set
2192         can_highlight.
2193         (show_source_disasm_command): Call the reset method.
2194         (show_data): Don't set can_highlight.  Call the reset method.
2195         (tui_gen_win_info::reset): Rename from init_gen_win_info
2196         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2197         (show_source_or_disasm_and_command): Call the reset method.
2198         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2199         (struct tui_cmd_window): Set can_highlight.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2204         from make_visible.
2205         (tui_make_visible, tui_make_invisible): Rewrite.
2206         (tui_win_info::make_visible): Remove.
2207         (tui_source_window_base::make_visible): Update.
2208         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2209         method.  Moved from...
2210         (struct tui_win_info) <make_visible>: ...here.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-winsource.c
2215         (tui_source_window_base::do_scroll_horizontal): Remove direction
2216         parameter.
2217         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2218         direction parameter.
2219         * tui/tui-win.c (tui_win_info::forward_scroll)
2220         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2221         (tui_win_info::right_scroll): Update.
2222         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2223         direction parameter.
2224         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2225         direction parameter.
2226         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2227         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2228         Remove direction parameter.
2229         (struct tui_source_window_base, struct tui_source_window)
2230         (struct tui_disasm_window, struct tui_data_window)
2231         (struct tui_cmd_window): Update.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-winsource.h (tui_set_exec_info_content)
2236         (tui_show_exec_info_content, tui_erase_exec_info_content)
2237         (tui_clear_exec_info_content, tui_update_exec_info): Change
2238         argument to tui_source_window_base.
2239         * tui/tui-winsource.c (tui_set_exec_info_content)
2240         (tui_show_exec_info_content, tui_erase_exec_info_content)
2241         (tui_clear_exec_info_content, tui_update_exec_info): Change
2242         argument to tui_source_window_base.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2247         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2248
2249 2019-06-25  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2252         check.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2257         type to void.
2258         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2259         type to void.
2260         * tui/tui-source.c (tui_set_source_content): Update.
2261         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-win.c (window_name_completer, tui_set_focus)
2266         (tui_all_windows_info): Use name method.
2267         * tui/tui-data.h (struct tui_gen_win_info)
2268         (struct tui_source_window, struct tui_disasm_window)
2269         (struct tui_data_window, struct tui_cmd_window) <name>: New
2270         method.
2271         (tui_win_name): Don't declare.
2272         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2273         (tui_win_name): Remove.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-winsource.h (tui_update_source_window)
2278         (tui_update_source_window_as_is): Change parameter type.
2279         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2280         to be a tui_source_window_base.
2281         (tui_update_source_window_as_is): Likewise.
2282         * tui/tui-win.c (make_visible_with_new_height): Update.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-winsource.c (tui_erase_source_content)
2287         (tui_show_source_content, tui_show_exec_info_content)
2288         (tui_erase_exec_info_content): Use refresh_window method.
2289         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2290         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2291         from tui_refresh_win.
2292         (tui_data_window::refresh_window): New method.
2293         (tui_win_info::refresh, tui_source_window_base::refresh)
2294         (tui_refresh_all): Use refresh_window method.
2295         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2296         method.
2297         * tui/tui-regs.c (tui_display_register): Call refresh_window
2298         method.
2299         * tui/tui-layout.c (show_source_disasm_command)
2300         (show_source_or_disasm_and_command): Call refresh_window method.
2301         * tui/tui-data.h (struct tui_gen_win_info)
2302         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2303         New method.
2304
2305 2019-06-25  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui.c (tui_rl_other_window, tui_enable)
2308         (tui_is_window_visible, tui_get_command_dimension): Update.
2309         * tui/tui-winsource.c (tui_update_source_window_as_is)
2310         (tui_clear_source_content, tui_erase_source_content)
2311         (tui_show_source_line, tui_source_window_base::refill)
2312         (tui_source_window_base::do_scroll_horizontal)
2313         (tui_source_window_base::set_is_exec_point_at)
2314         (tui_update_breakpoint_info, tui_set_exec_info_content)
2315         (tui_alloc_source_buffer, tui_line_is_displayed)
2316         (tui_addr_is_displayed): Update.
2317         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2318         (tui_check_and_display_highlight_if_needed)
2319         (tui_win_info::make_visible, tui_win_info::refresh)
2320         (tui_refresh_all): Update.
2321         * tui/tui-windata.c (tui_first_data_item_displayed)
2322         (tui_delete_data_content_windows, tui_erase_data_content)
2323         (tui_display_all_data, tui_data_window::refresh_all)
2324         (tui_check_data_values): Update.
2325         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2326         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2327         (tui_win_info::backward_scroll, tui_refresh_all_win)
2328         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2329         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2330         (tui_source_window_base::set_new_height)
2331         (tui_data_window::set_new_height)
2332         (make_invisible_and_set_new_height)
2333         (make_visible_with_new_height, new_height_ok)
2334         (parse_scrolling_args): Update.
2335         * tui/tui-stack.c (tui_show_frame_info): Update.
2336         * tui/tui-source.c (tui_set_source_content)
2337         (tui_set_source_content_nil, tui_source_is_displayed)
2338         (tui_source_window::do_scroll_vertical): Update.
2339         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2340         (tui_display_registers_from, tui_display_reg_element_at_line)
2341         (tui_check_register_values, tui_reg_command): Update.
2342         * tui/tui-layout.c (tui_default_win_height)
2343         (show_source_disasm_command, show_data, init_and_make_win)
2344         (show_source_or_disasm_and_command): Update.
2345         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2346         (tui_redisplay_readline, tui_mld_flush)
2347         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2348         (tui_getc): Update.
2349         * tui/tui-disasm.c (tui_set_disassem_content)
2350         (tui_disasm_window::do_scroll_vertical): Update.
2351         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2352         Now virtual.
2353         (struct tui_win_info): Derive from tui_gen_win_info.
2354         <~tui_win_info>: Mark as override.
2355         <generic>: Remove member.
2356         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2357         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2358         (~tui_data_window, ~tui_win_info)
2359         (tui_free_all_source_wins_content): Update.
2360         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2361
2362 2019-06-25  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-layout.c (init_and_make_win): Use new.
2365         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2366         destructor, initializers.
2367         (tui_alloc_generic_win_info): Don't declare.
2368         * tui/tui-data.c (_locator): Add argument to constructor.
2369         (source_win, disasm_win): New globals.
2370         (exec_info): Remove.
2371         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2372         Update.
2373         (tui_alloc_generic_win_info): Remove.
2374         (init_content_element): Use new.
2375         (tui_win_info::tui_win_info): Update.
2376         (free_content_elements) <case DATA_WIN>: Use delete.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2381         * tui/tui-windata.c (tui_first_data_item_displayed)
2382         (tui_delete_data_content_windows): Update.
2383         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2384         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2385         (tui_display_registers_from, tui_check_register_values): Update.
2386         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2387         pointer.
2388         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2389         window.
2390         (tui_free_data_content): Update.
2391         (free_content_elements) <case DATA_WIN>: Free the window.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2396         Update.
2397         * tui/tui-layout.c (make_command_window)
2398         (show_source_disasm_command, show_data, init_and_make_win)
2399         (show_source_or_disasm_and_command): Update.
2400         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2401         method.
2402         <can_highight, is_highlighted>: Now bool.
2403         (tui_set_win_highlight): Don't declare.
2404         * tui/tui-data.c (tui_set_win_highlight): Remove.
2405
2406 2019-06-25  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-wingeneral.c (make_visible): Remove check of window
2409         type.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-win.c (tui_win_info::max_height)
2414         (tui_cmd_window::max_height): New methods.
2415         (new_height_ok): Call max_height.
2416         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2417         <max_height>: New method.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-win.c (tui_source_window_base::set_new_height)
2422         (tui_data_window::set_new_height): New methods.
2423         (make_invisible_and_set_new_height): Call set_new_height method.
2424         * tui/tui-data.h (struct tui_win_info)
2425         (struct tui_source_window_base, struct tui_data_window)
2426         <set_new_height>: New method.
2427
2428 2019-06-25  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2431         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2432         tui_refresh_data_win.
2433         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2434         method.
2435         (tui_refresh_all_win): Call the refresh_all method.
2436         (tui_set_focus): Likewise.
2437         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2438         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2439         Likewise.
2440
2441 2019-06-25  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-winsource.h (tui_refill_source_window)
2444         (tui_set_is_exec_point_at): Don't declare.
2445         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2446         (tui_source_window_base::refill): Rename from
2447         tui_refill_source_window.
2448         (tui_source_window_base::do_scroll_horizontal): Update.
2449         (tui_source_window_base::set_is_exec_point_at): Rename from
2450         tui_set_is_exec_point_at.
2451         (tui_update_all_breakpoint_info): Update.
2452         * tui/tui-stack.c (tui_show_frame_info): Update.
2453         * tui/tui-layout.c (show_data): Add cast.
2454         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2455         * tui/tui-data.h (struct tui_source_window_base) <refill,
2456         set_is_exec_point_at>: New methods.
2457         (tui_source_windows, tui_add_to_source_windows): Update types.
2458         (tui_add_to_source_windows): Remove redundant declaration.
2459         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2460         (tui_source_windows): Change return type.
2461         (tui_clear_source_windows_detail): Update.
2462         (tui_add_to_source_windows): Change type of parameter.
2463         (tui_free_all_source_wins_content): Update.
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-wingeneral.c (tui_win_info::refresh)
2468         (tui_source_window_base::refresh): New methods.
2469         (tui_refresh_all): Call the refresh method.
2470         * tui/tui-data.h (struct tui_win_info)
2471         (struct tui_source_window_base) <refresh>: New method.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui.h (tui_is_window_visible): Return bool.
2476         * tui/tui.c (tui_is_window_visible): Return bool.
2477         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2478         (tui_make_visible, tui_make_invisible)
2479         (tui_win_info::make_visible)
2480         (tui_source_window_base::make_visible, make_all_visible)
2481         (tui_make_all_visible, tui_make_all_invisible): Update.
2482         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2483         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2484         bool.
2485         (struct tui_win_info, struct tui_source_window_base)
2486         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2487         * tui/tui-data.c (tui_init_generic_part): Update.
2488
2489 2019-06-25  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2492         (tui_source_window_base::make_visible): New methods.
2493         (make_all_visible): Make method call.
2494         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2495         (struct tui_source_window_base, struct tui_cmd_window): Override
2496         make_visible.
2497         (tui_win_is_source_type): Don't declare.
2498         * tui/tui-data.c (tui_win_is_source_type): Remove.
2499
2500 2019-06-25  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2503         NULL check.
2504
2505 2019-06-25  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2508         Inline constructor.  Add initializers for members.
2509         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2510         constructors; now inline in class.
2511
2512 2019-06-25  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-regs.c (tui_show_registers): Update.
2515         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2516         bool.
2517         * tui/tui-data.c (tui_data_window::clear_detail)
2518         (tui_data_window): Update.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-windata.c (tui_display_all_data)
2523         (tui_display_data_from_line, tui_display_data_from)
2524         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2525         Update.
2526         * tui/tui-regs.c (tui_last_regs_line_no)
2527         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2528         (tui_show_registers, tui_show_register_group)
2529         (tui_display_registers_from, tui_display_reg_element_at_line)
2530         (tui_display_registers_from_line, tui_check_register_values)
2531         (tui_reg_next, tui_reg_prev): Update.
2532         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2533         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2534         tui_data_window.
2535         (struct tui_win_info) <detail>: Remove.  Add new fields from
2536         tui_data_info.
2537         (TUI_DATA_WIN): Add cast.
2538         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2539         (~tui_data_window): Simplify.
2540
2541 2019-06-25  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-layout.c (show_source_disasm_command)
2544         (show_source_or_disasm_and_command): Update.
2545         * tui/tui-io.c (update_cmdwin_start_line)
2546         (tui_redisplay_readline): Update.
2547         * tui/tui-data.h (struct tui_command_info): Remove.
2548         (struct tui_win_info) <detail>: Remove command_info member.
2549         (struct tui_data_window) <start_line>: New member, from
2550         tui_command_info.
2551         (TUI_CMD_WIN): Add casts.
2552
2553 2019-06-25  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-winsource.c (tui_update_source_window)
2556         (tui_refill_source_window)
2557         (tui_source_window_base::do_scroll_horizontal)
2558         (tui_update_breakpoint_info, tui_set_exec_info_content)
2559         (tui_show_exec_info_content, tui_erase_exec_info_content)
2560         (tui_clear_exec_info_content): Update.
2561         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2562         Update.
2563         * tui/tui-win.c (make_invisible_and_set_new_height)
2564         (make_visible_with_new_height): Update.
2565         * tui/tui-source.c (tui_set_source_content)
2566         (tui_show_symtab_source): Update.
2567         * tui/tui-layout.c (extract_display_start_addr)
2568         (show_source_disasm_command, show_data)
2569         (make_source_or_disasm_window)
2570         (show_source_or_disasm_and_command): Update.
2571         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2572         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2573         "gdbarch".
2574         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2575         to tui_source_window_base.
2576         (struct tui_win_info) <detail>: Remove source_info member.
2577         (struct tui_source_window_base) <has_locator>: Inline.
2578         Move contents from tui_source_info; rename has_locator member to
2579         m_has_locator.
2580         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2581         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2582         header file.
2583         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2584         Simplify.
2585         (tui_free_all_source_wins_content): Cast to
2586         tui_source_window_base.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-win.c (make_invisible_and_set_new_height)
2591         (make_visible_with_new_height): Call has_locator method.
2592         * tui/tui-layout.c (show_source_disasm_command, show_data)
2593         (show_source_or_disasm_and_command): Update for bool change.
2594         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2595         (tui_win_info) <has_locator>: New method.
2596         (struct tui_source_window_base) <has_locator>: New method.
2597         (tui_win_has_locator): Don't declare.
2598         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2599         from tui_win_has_locator.
2600         (tui_source_window_base): Use false, not FALSE.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2605         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2606         clear_detail method directly.
2607         (tui_clear_win_detail): Remove.
2608
2609 2019-06-25  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2612         "this", not TUI_DISASM_WIN.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2617         declare.
2618         * tui/tui-winsource.c
2619         (tui_source_window_base::do_scroll_horizontal): Rename from
2620         tui_horizontal_source_scroll.
2621         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2622         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2623         from tui_vertical_data_scroll.
2624         * tui/tui-win.h (tui_scroll): Don't declare.
2625         * tui/tui-win.c (tui_win_info::forward_scroll)
2626         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2627         (tui_win_info::right_scroll): Rename and update.
2628         (tui_scroll_forward_command, tui_scroll_backward_command)
2629         (tui_scroll_left_command, tui_scroll_right_command): Update.
2630         (tui_scroll): Remove.
2631         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2632         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2633         from tui_vertical_source_scroll.
2634         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2635         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2636         from tui_vertical_disassem_scroll.
2637         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2638         do_scroll_horizontal>: New methods.
2639         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2640         Likewise.
2641         (struct tui_source_window_base): Add do_scroll_horizontal.
2642         (struct tui_source_window, struct tui_disasm_window): Add
2643         do_scroll_vertical.
2644         (struct tui_data_window, struct tui_cmd_window): Add
2645         do_scroll_horizontal and do_scroll_vertical.
2646         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2647
2648 2019-06-25  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-data.h (struct tui_source_window_base): New struct.
2651         (struct tui_source_window): Derive from tui_source_window_base.
2652         (struct tui_disasm_window): New struct.
2653         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2654         from tui_source_window::clear_detail.
2655         (tui_source_window_base): Rename from tui_source_window.
2656         (~tui_source_window_base): Rename from ~tui_source_window.
2657         (tui_alloc_win_info): Create a tui_disasm_window.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-data.h (struct tui_source_window)
2662         (struct tui_data_window): Declare destructors.
2663         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2664         destructors.
2665         (tui_win_info): Simplify.
2666
2667 2019-06-25  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-winsource.c (tui_display_main)
2670         (tui_update_source_windows_with_addr)
2671         (tui_update_all_breakpoint_info): Update.
2672         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2673         (new_height_ok, parse_scrolling_args): Update.
2674         * tui/tui-stack.c (tui_show_frame_info): Update.
2675         * tui/tui-data.h (struct tui_list): Remove.
2676         (tui_source_windows): Return a reference to a std::vector.
2677         * tui/tui-data.c (source_windows): Now a std::vector.
2678         (tui_source_windows): Change return type.
2679         (tui_clear_source_windows): Rewrite.
2680         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2681         (tui_free_all_source_wins_content): Rewrite.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2686         (struct tui_data_window, struct tui_cmd_window): Declare
2687         clear_detail method.
2688         * tui/tui-data.c (tui_source_window::clear_detail)
2689         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2690         methods.
2691         (tui_clear_win_detail): Simplify.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-layout.c (make_source_window, make_disasm_window)
2696         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2697         Return the new window.
2698         (show_source_disasm_command, show_data)
2699         (show_source_or_disasm_and_command): Update.
2700
2701 2019-06-25  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2704         parameter.  Return the new window.
2705         (show_source_disasm_command): Update and remove NULL check.
2706         (show_source_or_disasm_and_command): Update.
2707
2708 2019-06-25  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2711
2712 2019-06-25  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-data.h (struct tui_win_info): Make constructor
2715         protected.  Make destructor virtual.  Add initializers.
2716         (tui_source_window, tui_data_window, tui_cmd_window): New
2717         classes.
2718         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2719         constructor.  Add "type" parameter.
2720         (tui_source_window, tui_data_window, tui_cmd_window): New
2721         constructors.
2722         (tui_alloc_win_info): Instantiate the appropriate subclass.
2723
2724 2019-06-25  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-win.c (tui_resize_all): Use delete.
2727         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2728         destructor.
2729         (tui_free_window): Don't declare.
2730         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2731         Update.
2732
2733 2019-06-25  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-data.h (struct tui_win_info): Add constructor.
2736         * tui/tui-data.c (tui_alloc_win_info): Use new.
2737         (tui_free_window): Use delete.
2738
2739 2019-06-22  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2742         declare.
2743         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2744
2745 2019-06-22  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2748         declare.
2749         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2750
2751 2019-06-22  Tom de Vries  <tdevries@suse.de>
2752
2753         * dwarf2read.c (create_addrmap_from_aranges)
2754         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2755         instead of '%zu'.
2756
2757 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2758
2759         * dwarf2read.h (dwarf2_section_info_def): Remove.
2760         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2761         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2762         std::vector<dwarf2_section_info>.
2763         (struct dwo_file) <~dwo_file>: Remove.
2764         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2765         types field.
2766         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2767         (dwarf2_read_debug_names): Likewise.
2768         (create_debug_types_hash_table): Change parameter type to
2769         array_view, adjust code accordingly.
2770         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2771         (partial_die_info::fixup): Likewise.
2772         (determine_prefix): Likewise.
2773         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2774
2775 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2776
2777         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2778         gdb_bfd_ref_ptr.
2779         <~dwo_file>: Remove call to gdb_bfd_unref.
2780         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2781         gdb_bfd_ref_ptr::get.
2782
2783 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2784
2785         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2786         type to htab_up.
2787         * dwarf2read.c (struct dwo_file): Initialize fields.
2788         <~dwo_file>: New.
2789         (free_dwo_file): Remove, move content to ~dwo_file.
2790         (struct dwo_file_deleter): Remove.
2791         (dwo_file_up>: Remove custom deleter.
2792         (free_dwo_files): Remove.
2793         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2794         dwo_files.
2795         (process_skeletonless_type_units): Call unique_ptr::get.
2796         (allocate_dwo_file_hash_table): Add deleter to created hash
2797         table.  Change return type to htab_up.
2798         (lookup_dwo_file_slot): Don't memset dwo_file, call
2799         unique_ptr::get.
2800         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2801         (create_dwo_unit_in_dwp_v2): Likewise.
2802         (open_and_init_dwo_file): Likewise.
2803         (free_dwo_file_from_slot): Remove.
2804
2805 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * dwarf2read.h (struct dwarf2_section_info) <readin,
2808         is_virtual>: Change type to bool.
2809         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2810         true instead of 1.
2811
2812 2019-06-19  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-data.h (tui_init_content_element): Don't declare.
2815
2816 2019-06-19  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-data.h (tui_init_win_info): Don't declare.
2819
2820 2019-06-19  Tom de Vries  <tdevries@suse.de>
2821
2822         * dwarf2read.h (abstract_to_concrete): Change type to
2823         std::unordered_map<sect_offset, std::vector<sect_offset>,
2824         gdb::hash_enum<sect_offset>>.
2825
2826 2019-06-19  Tom Tromey  <tromey@adacore.com>
2827
2828         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2829         EVAL_AVOID_SIDE_EFFECTS specially.
2830
2831 2019-06-19  Tom Tromey  <tromey@adacore.com>
2832
2833         * source-cache.c (highlighter): New global.
2834         (source_cache::get_source_lines): Create a highlighter on demand.
2835
2836 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * defs.h (deprecated_interactive_hook): Delete declaration.
2839         * interps.c (clear_interpreter_hooks): Remove use of
2840         deprecated_interactive_hook.
2841         * top.c (deprecated_interactive_hook): Delete definition.
2842         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2843
2844 2019-06-18  Tom de Vries  <tdevries@suse.de>
2845
2846         PR gdb/24515
2847         * dwarf2read.h (abstract_to_concrete): Change type from
2848         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2849         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2850         * dwarf2read.c (read_variable): Update.
2851         (dwarf2_fetch_die_loc_sect_off): Update.
2852
2853 2019-06-17  Tom de Vries  <tdevries@suse.de>
2854
2855         PR gdb/24617
2856         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2857         accessing parent[parent_len - 1].
2858
2859 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2860
2861         PR gdb/24364
2862         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2863         call dtrace_process_dof with NULL dof.
2864
2865 2019-06-16  Tom de Vries  <tdevries@suse.de>
2866
2867         PR gdb/24445
2868         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2869
2870 2019-06-16  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2873         (make_all_visible): Use address of member.
2874
2875 2019-06-16  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2878         (tui_free_window, free_content, free_content_elements): Remove
2879         unnecessary cast.
2880         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2881         cast.
2882         * tui/tui-regs.c (tui_show_register_group)
2883         (tui_display_registers_from, tui_display_reg_element_at_line):
2884         Remove unnecessary cast.
2885
2886 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * linux-nat.c (normal_mask): Delete.
2889         (_initialize_linux_nat): Don't initialise normal_mask.
2890
2891 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2892
2893         PR gdb/24445
2894         * dwarf-index-write.h (write_psymtabs_to_index): Add
2895         dwz_basename parameter.
2896         * dwarf-index-write.c (write_gdbindex): Move file writing to
2897         write_gdbindex_1.  Change return type void.
2898         (assert_file_size): Move up, remove filename parameter.
2899         (write_gdbindex_1): New function.
2900         (write_debug_names): Change return type to void, call
2901         assert_file_size.
2902         (struct index_wip_file): New struct.
2903         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2904         file logic to index_wip_file.  Write index for dwz file if
2905         needed.
2906         (save_gdb_index_command): Pass basename of dwz file, if present.
2907         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2908         build-id of dwz file, if present.
2909         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2910         (dwarf2_get_dwz_file): Likewise.
2911         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2912         (dwarf2_get_dwz_file): Likewise.
2913
2914 2019-06-16  Tom Tromey  <tom@tromey.com>
2915
2916         * coffread.c (process_coff_symbol): Use xstrdup.
2917         * value.c (create_internalvar): Use xstrdup.
2918
2919 2019-06-16  Tom Tromey  <tom@tromey.com>
2920
2921         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2922         * breakpoint.c (stopin_command, stopat_command)
2923         (until_break_command, decode_location_default): Remove unnecessary
2924         cast.
2925         * utils.c (subset_compare): Remove unnecessary cast.
2926         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2927         cast.
2928         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2929         cast.
2930         * infcmd.c (path_command): Remove unnecessary cast.
2931         * coffread.c (decode_type): Remove unnecessary cast.
2932         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2933         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2934         * tui/tui-stack.c (tui_show_locator_content)
2935         (tui_show_frame_info): Remove unnecessary cast.
2936         * tui/tui-win.c (tui_scroll_forward_command)
2937         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2938         (parse_scrolling_args): Remove unnecessary cast.
2939         * tui/tui-data.c (init_win_info, tui_del_window)
2940         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2941         (free_content_elements): Remove unnecessary cast.
2942         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2943         unnecessary cast.
2944         * tui/tui-source.c (tui_set_source_content)
2945         (tui_vertical_source_scroll): Remove unnecessary cast.
2946         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2947         cast.
2948         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2949         * tui/tui-regs.c (tui_display_registers_from)
2950         (tui_display_register): Remove unnecessary cast.
2951         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2952         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2953         (make_visible): Remove unnecessary cast.
2954         * tui/tui-winsource.c (tui_erase_source_content)
2955         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2956         unnecessary cast.
2957         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2958         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2959         * stabsread.c (read_type, read_array_type, read_range_type):
2960         Remove unnecessary cast.
2961         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2962         (parse_symbol, parse_type, upgrade_type, parse_external)
2963         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2964         unnecessary cast.
2965         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2966
2967 2019-06-16  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-data.c (tui_alloc_generic_win_info)
2970         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2971         checks.
2972
2973 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2974             Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * f-typeprint.c (f_print_type): Don't return early for not
2977         associated or not allocated types.
2978         (f_type_print_varspec_suffix): Add print_rank parameter and print
2979         ranks of array types in case they dangling.
2980         (f_type_print_base): Add print_rank parameter.
2981
2982 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * NEWS: Mention new MI commands.
2985         * break-catch-throw.c (enum exception_event_kind): Move to
2986         breakpoint.h.
2987         (print_mention_exception_catchpoint): Output text as a single
2988         message.
2989         (catch_exception_command_1): Rename to...
2990         (catch_exception_event): ...this, make non-static, update header
2991         command, and change some parameter types.
2992         (catch_catch_command): Update for changes to
2993         catch_exception_command_1.
2994         (catch_throw_command): Likewise.
2995         (catch_rethrow_command): Likewise.
2996         * breakpoint.c (enum exception_event_kind): Delete.
2997         * breakpoint.h (enum exception_event_kind): Moved here from
2998         break-catch-throw.c.
2999         (catch_exception_event): Declare.
3000         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3001         (mi_cmd_catch_throw): New function.
3002         (mi_cmd_catch_rethrow): New function.
3003         (mi_cmd_catch_catch): New function.
3004         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3005         'catch-catch' entries.
3006         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3007         (mi_cmd_catch_rethrow): Declare.
3008         (mi_cmd_catch_catch): Declare.
3009
3010 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * annotate.c (annotate_source_line): Change return type to void,
3013         update implementation to match.
3014         * annotate.h (annotate_source_line): Change return type to void,
3015         update header comment.
3016         * stack.c (print_frame_info): Don't change what frame information
3017         is printed based on whether annotations are on or not.
3018
3019 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3022         (annotate_source): Make static.
3023         (annotate_source_line): Moved from source.c and renamed from
3024         identify_source_line.  Update the return type.
3025         * annotate.h (annotate_source): Delete declaration.
3026         (annotate_source_line): Declaration moved from source.h, and
3027         renamed from identify_source_line.  Return type updated.
3028         * source.c (identify_source_line): Moved to annotate.c and renamed
3029         to annotate_source_line.
3030         (info_line_command): Remove check of annotation_level.
3031         * source.h (identify_source_line): Move declaration to annotate.h
3032         and rename to annotate_source_line.
3033         * stack.c: Add 'annotate.h' include.
3034         (print_frame_info): Remove check of annotation_level before
3035         calling annotate_source_line.
3036
3037 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * source-cache.c (source_cache::get_plain_source_lines): Use
3040         open_source_file_with_line_charpos instead of just
3041         open_source_file, remove call to find_source_lines.
3042         (source_cache::get_source_lines): Likewise.
3043         * source.c (find_source_lines): Make static.
3044         (get_filename_and_charpos): Renamed into...
3045         (open_source_file_with_line_charpos): ..this along with changes to
3046         return a scoped_fd, and some other minor clean ups.
3047         (identify_source_line): Use open_source_file_with_line_charpos.
3048         (search_command_helper): Use open_source_file_with_line_charpos
3049         instead of just open_source_file, remove call to
3050         find_source_lines.
3051         * source.h (open_source_file_with_line_charpos): Declare new
3052         function.
3053         (find_source_lines): Delete declaration.
3054
3055 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3056
3057         * source.c (get_filename_and_charpos): Remove fullname
3058         parameter.
3059         (identify_source_line): Update call to get_filename_and_charpos.
3060
3061 2019-06-14  Tom Tromey  <tromey@adacore.com>
3062
3063         PR gdb/24502:
3064         * ui-style.h (skip_ansi_escape): Update comment.
3065         * ui-file.h (class no_terminal_escape_file): New class.
3066         * ui-file.c (no_terminal_escape_file::write)
3067         (no_terminal_escape_file::puts): New methods.
3068         * cli/cli-logging.c (handle_redirections): Use
3069         no_terminal_escape_file.
3070
3071 2019-06-14  Tom Tromey  <tromey@adacore.com>
3072
3073         * NEWS: Move convenience variable news above Python news.
3074
3075 2019-06-14  Tom Tromey  <tom@tromey.com>
3076
3077         * gnulib: Move directory to top-level.
3078         * configure.ac: Don't configure gnulib.
3079         * configure: Rebuild.
3080         * common/common-defs.h: Use new path to gnulib.
3081         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3082         (GNULIB_H): Remove.
3083         (INCGNU): Look in new gnulib location.
3084         (HFILES_NO_SRCDIR): Remove gnulib files.
3085         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3086         (generated_files): Remove GNULIB_H.
3087         ($(LIBGNU), all-lib): Remove targets.
3088         (distclean): Don't mention GNULIB_BUILDDIR.
3089         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3090
3091 2019-06-14  Tom Tromey  <tromey@adacore.com>
3092
3093         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3094         Warn if symbol file does not provide any symbols.
3095
3096 2019-06-14  Tom Tromey  <tromey@adacore.com>
3097
3098         * source.c (find_and_open_source): Respect basenames_may_differ.
3099
3100 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * annotate.c (annotate_breakpoints_invalid): Make use of
3103         scoped_restore_terminal_state.
3104         (annotate_frames_invalid): Likewise.
3105
3106 2019-06-14  Tom Tromey  <tromey@adacore.com>
3107
3108         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3109         allow assignment to an internalvar.
3110
3111 2019-06-14  Tom Tromey  <tromey@adacore.com>
3112
3113         * ada-lex.l: Allow "_" in attribute names.
3114
3115 2019-06-14  Tom Tromey  <tromey@adacore.com>
3116
3117         PR gdb/24653:
3118         * regcache.c (registers_changed): Don't call alloca.
3119         * top.c (execute_command): Don't call alloca.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3124         'expression'.  When parsing an expression, error out if there's
3125         junk after "unlimited".
3126         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3127         (do_set_command): Adjust calls to is_unlimited_literal.
3128
3129 2019-06-13  Pedro Alves  <palves@redhat.com>
3130
3131         * compile/compile.c (make_compile_options_def_group): Add braces
3132         around array_view initializer.
3133         * thread.c (make_thread_apply_all_options_def_group)
3134         (make_thread_apply_all_options_def_group): Likewise.
3135
3136 2019-06-13  Pedro Alves  <palves@redhat.com>
3137
3138         * NEWS (New commands): Mention "maint test-options
3139         require-delimiter", "maint test-options unknown-is-error", "maint
3140         test-options unknown-is-operand" and "maint show
3141         test-options-completion-result".
3142         (New command options, command completion): New section.
3143         (Completion improvements): New section.
3144         Mention that you can abbreviate "unlimited".
3145
3146 2019-06-13  Pedro Alves  <palves@redhat.com>
3147
3148         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3149         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3150         * unittests/cli-utils-selftests.c (test_parse_flags)
3151         (test_parse_flags_qcs): Delete.
3152         (test_cli_utils): Don't call deleted functions.
3153
3154 2019-06-13  Pedro Alves  <palves@redhat.com>
3155
3156         * thread.c: Include "cli/cli-option.h".
3157         (tp_array_compar_ascending): Global.
3158         (tp_array_compar): Delete function.
3159         (tp_array_compar_ascending, tp_array_compar_descending): New
3160         functions.
3161         (ascending_option_def, qcs_flag_option_def)
3162         (thr_qcs_flags_option_defs)
3163         (make_thread_apply_all_options_def_group)
3164         (make_thread_apply_options_def_group): New.
3165         (thread_apply_all_command): Use gdb::option::process_options.
3166         (thread_apply_command_completer)
3167         (thread_apply_all_command_completer): New.
3168         (thread_apply_command): Use gdb::option::process_options.
3169         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3170         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3171         to generate help text of "thread apply".  Adjust "taas"'s help.
3172         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3173         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3174
3175 2019-06-13  Pedro Alves  <palves@redhat.com>
3176
3177         * thread.c (thread_apply_command): Check for invalid TID with
3178         isdigit instead of !isalpha.
3179
3180 2019-06-13  Pedro Alves  <palves@redhat.com>
3181
3182         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3183         (validate_flags_qcs): New.
3184         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3185         (validate_flags_qcs): Declare.
3186         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3187         (make_frame_apply_options_def_group): New.
3188         (frame_apply_command_count): Process options with
3189         gdb::option::process_options.
3190         (frame_apply_completer): New.
3191         (frame_apply_level_completer, frame_apply_all_completer)
3192         (frame_apply_completer): New.
3193         (_initialize_stack): Update help of "frame apply", "frame apply
3194         level", "frame apply all" and "faas" to mention supported options
3195         and install command completers.
3196         * stack.h (frame_apply_all_completer): Declare.
3197         * thread.c: Include "stack.h".
3198         (tfaas_command): Add "--".
3199         (_initialize_thread): Update help "tfaas" to mention supported
3200         options and install command completer.
3201
3202 2019-06-13  Pedro Alves  <palves@redhat.com>
3203
3204         * completer.c (complete_nested_command_line): New.
3205         (gdb_completion_word_break_characters_throw): Add assertion.
3206         * completer.h (complete_nested_command_line): Declare.
3207
3208 2019-06-13  Pedro Alves  <palves@redhat.com>
3209
3210         * stack.c (parse_backtrace_qualifiers): New.
3211         (backtrace_command): Use it.
3212         (backtrace_command_completer): Complete on qualifiers.
3213
3214 2019-06-13  Pedro Alves  <palves@redhat.com>
3215
3216         * frame.c: Include "cli/cli-option.h.
3217         (user_set_backtrace_options): New.
3218         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3219         Delete.
3220         (get_prev_frame): Adjust.
3221         (boolean_option_def, uinteger_option_def)
3222         (set_backtrace_option_defs): New.
3223         (_initialize_frame): Adjust and use
3224         gdb::option::add_setshow_cmds_for_options to install "set
3225         backtrace past-main" and "set backtrace past-entry".
3226         * frame.h: Include "cli/cli-option.h".
3227         (struct frame_print_options): Forward declare.
3228         (print_frame_arguments_all, print_frame_arguments_scalars)
3229         (print_frame_arguments_none): Declare.
3230         (print_entry_values): Delete declaration.
3231         (struct frame_print_options, user_frame_print_options): New.
3232         (struct set_backtrace_options): New.
3233         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3234         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3235         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3236         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3237         (list_args_or_locals): Add frame_print_options parameter.
3238         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3239         * python/py-framefilter.c (enumerate_args): Pass down
3240         USER_FRAME_PRINT_OPTIONS.
3241         * stack.c: Include "cli/cli-option.h".
3242         (print_frame_arguments_all, print_frame_arguments_scalars)
3243         (print_frame_arguments_none): Declare.
3244         (print_raw_frame_arguments, print_entry_values): Delete.
3245         (user_frame_print_options): New.
3246         (boolean_option_def, enum_option_def, frame_print_option_defs):
3247         New.
3248         (struct backtrace_cmd_options): New.
3249         (bt_flag_option_def): New.
3250         (backtrace_command_option_defs): New.
3251         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3252         (print_frame_arg, read_frame_arg, print_frame_args)
3253         (print_frame_info, print_frame): Add frame_print_options parameter
3254         and use it.
3255         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3256         (backtrace_command_1): Add frame_print_options and
3257         backtrace_cmd_options parameters and use them.
3258         (make_backtrace_options_def_group): New.
3259         (backtrace_command): Process command options with
3260         gdb::option::process_options.
3261         (backtrace_command_completer): New.
3262         (_initialize_stack): Extend "backtrace"'s help to mention
3263         supported options.  Install completer for "backtrace".
3264         Install some settings commands with add_setshow_cmds_for_options.
3265
3266 2019-06-13  Pedro Alves  <palves@redhat.com>
3267
3268         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3269         and that "set/show print raw frame-arguments" are now deprecated.
3270
3271         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3272         command.
3273         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3274         * stack.c (_initialize_stack): Install "set/show print
3275         raw-frame-arguments", and deprecate "set/show print raw
3276         frame-arguments".
3277         * valprint.c (_initialize_valprint): Deprecate "set/show print
3278         raw".
3279
3280 2019-06-13  Pedro Alves  <palves@redhat.com>
3281
3282         * compile/compile.c (struct compile_options): New.
3283         (compile_flag_option_def, compile_command_option_defs)
3284         (make_compile_options_def_group): New.
3285         (compile_file_command): Handle options with
3286         gdb::option::process_options.
3287         (compile_file_command_completer): New function.
3288         (compile_code_command): Handle options with
3289         gdb::option::process_options.
3290         (compile_code_command_completer): New function.
3291         (_initialize_compiler): Install completers for "compile code" and
3292         "compile file".  Mention available options in "compile code" and
3293         "compile code"'s help.
3294         * completer.c (advance_to_completion_word): New, factored out from
3295         ...
3296         (advance_to_expression_complete_word_point): ... this.
3297         (advance_to_filename_complete_word_point): New.
3298         * completer.h (advance_to_filename_complete_word_point): New
3299         declaration.
3300
3301 2019-06-13  Pedro Alves  <palves@redhat.com>
3302
3303         * compile/compile.c: Include "cli/cli-option.h".
3304         (compile_print_value): Scope data pointer is now a
3305         value_print_options pointer; adjust.
3306         (compile_print_command): Process options.  Scope data pointer is
3307         now a value_print_options pointer; adjust.
3308         (_initialize_compile): Update "compile print"'s help to include
3309         supported options.  Install a completer for "compile print".
3310         * cp-valprint.c (show_vtblprint, show_objectprint)
3311         (show_static_field_print): Delete.
3312         (_initialize_cp_valprint): Don't install "set print
3313         static-members", "set print vtbl", "set print object" here.
3314         * printcmd.c: Include "cli/cli-option.h" and
3315         "common/gdb_optional.h".
3316         (print_command_parse_format): Rework to fill in a
3317         value_print_options instead of a format_data.
3318         (print_value): Change parameter type from format_data pointer to
3319         value_print_options reference.  Adjust.
3320         (print_command_1): Process options.  Adjust to pass down a
3321         value_print_options.
3322         (print_command_completer): New.
3323         (_initialize_printcmd): Install print_command_completer as
3324         handle_brkchars completer for the "print" command.  Update
3325         "print"'s help to include supported options.
3326         * valprint.c: Include "cli/cli-option.h".
3327         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3328         here from cp-valprint.c.
3329         (boolean_option_def, uinteger_option_def)
3330         (value_print_option_defs, make_value_print_options_def_group):
3331         New.  Use gdb::option::add_setshow_cmds_for_options to install
3332         "set print elements", "set print null-stop", "set print repeats",
3333         "set print pretty", "set print union", "set print array", "set
3334         print address", "set print symbol", "set print array-indexes".
3335         * valprint.h: Include <string> and "cli/cli-option.h".
3336         (make_value_print_options_def_group): Declare.
3337         (print_value): Change parameter type from format_data pointer to
3338         value_print_options reference.
3339         (print_command_completer): Declare.
3340
3341 2019-06-13  Pedro Alves  <palves@redhat.com>
3342
3343         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3344         (COMMON_SFILES): Add maint-test-settings.c.
3345         * cli/cli-decode.c (boolean_enums): New global, factored out from
3346         ...
3347         (add_setshow_boolean_cmd): ... here.
3348         * cli/cli-decode.h (boolean_enums): Declare.
3349         * cli/cli-option.c: New file.
3350         * cli/cli-option.h: New file.
3351         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3352         factored out from ...
3353         (parse_cli_boolean_value(const char *)): ... this.
3354         (is_unlimited_literal): Change parameter type to pointer to
3355         pointer.  Adjust and advance ARG pointer.
3356         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3357         (parse_cli_var_enum): New, factored out from ...
3358         (do_set_command): ... this.  Adjust.
3359         * cli/cli-setshow.h (parse_cli_boolean_value)
3360         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3361         (parse_cli_var_enum): Declare.
3362         * cli/cli-utils.c: Include "cli/cli-option.h".
3363         (get_ulongest): New.
3364         * cli/cli-utils.h (get_ulongest): Declare.
3365         (check_for_argument): New overloads.
3366         * maint-test-options.c: New file.
3367
3368 2019-06-13  Pedro Alves  <palves@redhat.com>
3369
3370         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3371         parse a range if "-" is at the end of the string.
3372
3373 2019-06-13  Pedro Alves  <palves@redhat.com>
3374
3375         * cli/cli-setshow.c (parse_auto_binary_operation)
3376         (parse_cli_boolean_value): Don't allow "o".
3377
3378 2019-06-13  Pedro Alves  <palves@redhat.com>
3379
3380         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3381         * NEWS: Mention maint test-settings KIND.
3382         * maint-test-settings.c: New file.
3383
3384 2019-06-13  Pedro Alves  <palves@redhat.com>
3385
3386         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3387         completer.
3388         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3389         "set" completers.
3390
3391 2019-06-13  Pedro Alves  <palves@redhat.com>
3392
3393         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3394         after item.
3395
3396 2019-06-13  Pedro Alves  <palves@redhat.com>
3397
3398         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3399
3400 2019-06-13  Pedro Alves <palves@redhat.com>
3401
3402         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3403         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3404         call.
3405         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3406         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3407         calls.
3408         (check_for_argument): Skip spaces after argument.
3409
3410 2019-06-13  Pedro Alves  <palves@redhat.com>
3411
3412         * thread.c (thread_apply_command): Adjust TID parsing.
3413         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3414         detected before end of string.
3415         (tid_is_in_list): Error out if LIST is invalid.
3416
3417 2019-06-13  Pedro Alves  <palves@redhat.com>
3418
3419         * completer.c (complete_line_internal_1): Rewind completion word
3420         point.
3421         (completion_tracker::advance_custom_word_point_by): Change
3422         parameter type to int.
3423         * completer.h (completion_tracker::advance_custom_word_point_by):
3424         Likewise.
3425
3426 2019-06-13  Pedro Alves  <palves@redhat.com>
3427
3428         * completer.c (advance_to_completion_word): Handle delimiters.
3429
3430 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3431
3432         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3433
3434 2019-06-11  Tom Tromey  <tom@tromey.com>
3435
3436         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3437         (xmalloc_failed): Move to alloc.c.
3438         * alloc.c: New file.
3439         * Makefile.in (COMMON_SFILES): Add alloc.c.
3440
3441 2019-06-11  Tom Tromey  <tom@tromey.com>
3442
3443         * nat/linux-waitpid.c: Don't include server.h.
3444         (linux_debug): Remove.
3445         (my_waitpid): Update.
3446
3447 2019-06-11  Tom Tromey  <tromey@adacore.com>
3448
3449         * infcall.c (_initialize_infcall): Remove trailing newline from
3450         help.
3451         * user-regs.c (_initialize_user_regs): Remove trailing newline
3452         from help.
3453         * typeprint.c (_initialize_typeprint): Remove trailing newline
3454         from help.
3455         * reverse.c (_initialize_reverse): Remove trailing newlines from
3456         help.
3457         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3458         from help.
3459         * language.c (add_set_language_command): Remove trailing newline
3460         from help.
3461         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3462         help.
3463         * disasm.c (_initialize_disasm): Remove trailing newline from
3464         help.
3465         * top.c (init_main): Remove trailing newline from help.
3466         * interps.c (_initialize_interpreter): Remove trailing newline
3467         from help.
3468         * btrace.c (_initialize_btrace): Remove trailing newlines from
3469         help.
3470         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3471         from help.
3472         * python/python.c (_initialize_python): Remove trailing newline
3473         from help.
3474         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3475         help.
3476         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3477         from help.  Reformat some text.
3478         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3479         from help.
3480         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3481         newline from help.
3482
3483 2019-06-11  Tom Tromey  <tromey@adacore.com>
3484
3485         * darwin-nat.c (darwin_decode_exception_message)
3486         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3487
3488 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * valops.c (value_slice): Check for not allocated or not
3491         associated values.
3492
3493 2019-06-10  Tom de Vries  <tdevries@suse.de>
3494
3495         PR gdb/24618
3496         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3497         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3498         invalid.
3499
3500 2019-06-10  Tom de Vries  <tdevries@suse.de>
3501
3502         PR gdb/24611
3503         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3504         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3505
3506 2019-06-10  Tom de Vries  <tdevries@suse.de>
3507
3508         PR symtab/24545
3509         * symtab.c (struct demangled_name_entry): Add language field.
3510         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3511         static minimal symbol".  Set and use language field.
3512
3513 2019-06-10  Tom Tromey  <tromey@adacore.com>
3514
3515         * ada-lang.c (_initialize_ada_language): Update help text.
3516
3517 2019-06-10  Tom Tromey  <tromey@adacore.com>
3518
3519         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3520         with a newline.
3521         * guile/guile.c (handle_boot_error): Don't end warning with a
3522         newline.
3523         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3524         warning with a newline.
3525         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3526         newline.
3527         (s12z_frame_cache): Likewise.
3528         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3529         a newline.
3530         * solib-svr4.c (disable_probes_interface): Don't end warning with
3531         a newline.
3532         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3533         newline.
3534         * python/python.c (do_finish_initialization): Don't end warning
3535         with a newline.
3536
3537 2019-06-10  Tom Tromey  <tom@tromey.com>
3538
3539         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3540         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3541         gdbpy_enter.
3542
3543 2019-06-10  Tom Tromey  <tromey@adacore.com>
3544
3545         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3546         data.
3547         (elf_new_init): Don't call stabsread_new_init.
3548         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3549         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3550         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3551
3552 2019-06-10  Tom de Vries  <tdevries@suse.de>
3553
3554         PR symtab/16264
3555         PR symtab/24517
3556         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3557
3558 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3559
3560         * source.c (find_and_open_source): Also rewrite relative file
3561         names.
3562
3563 2019-04-26  Amos Bird  <amosbird@gmail.com>
3564
3565         * annotate.c (annotate_thread_exited): Add "thread-exited"
3566         annotation.
3567
3568 2019-06-06  Tom Tromey  <tromey@adacore.com>
3569
3570         * maint.h (class scoped_command_stats): Use
3571         DISABLE_COPY_AND_ASSIGN.
3572         <print_time>: New method.
3573         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3574         print_time.
3575         (scoped_command_stats::print_time): New method.
3576
3577 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3580         instructions of lengths 6 or 8 bytes.
3581
3582 2019-06-04  Pedro Alves  <palves@redhat.com>
3583
3584         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3585
3586         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3587         * breakpoint.c (condition_completer): Likewise.
3588         * cli/cli-dump.c (scan_expression): Likewise.
3589         * common/filestuff.c (mkdir_recursive): Likewise.
3590         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3591         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3592         (gdb_abspath): Likewise.
3593         * compile/compile-cplus-types.c
3594         (compile_cplus_instance::decl_name): Likewise.
3595         * completer.c (complete_explicit_location):
3596         (signal_completer, reg_or_group_completer_1): Likewise.
3597         * cp-support.c (cp_remove_params_if_any): Likewise.
3598         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3599         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3600         * infcmd.c (strip_bg_char): Likewise.
3601         * linespec.c (copy_token_string): Likewise.
3602         * mi/mi-main.c (output_cores): Likewise.
3603         * psymtab.c (psymtab_search_name):
3604         * symfile.c (test_set_ext_lang_command): Likewise.
3605         * target.c (target_fileio_read_stralloc): Likewise.
3606         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3607         * value.c (complete_internalvar): Likewise.
3608
3609 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3610
3611         Add objfile property to gdb.Type.
3612         * NEWS: Mention Python API addition.
3613         * python/py-type.c (typy_get_objfile): New method.
3614
3615 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3616
3617         * NEWS: Mention the new set|show style [title|highlight].
3618         Mention changes to "show style", "help" and "apropos".
3619
3620 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3621
3622         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3623         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3624         instead of print_help_for_command.
3625         (print_doc_of_command): New function.
3626         (help_list): Add 'apropos -v word' suggestion.
3627         (print_help_for_command): Style the command name using title style.
3628         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3629         (_initialize_cli_cmds): Describe -v in apropos_command help.
3630
3631 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3632
3633         * cli/cli-style.h (cli_style_option): Add name in constructor,
3634         add m_name class member, add constructor with intensity,
3635         add name class function.
3636         (cli_style_option::add_setshow_commands): Remove name argument.
3637         (highlight_style, title_style): New styles.
3638         * cli/cli-style.c (do_show): New function that shows a style
3639         characteristic styling the style name with itself.
3640         (set_style_name): New function.
3641         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3642         Update all callers according to the changes in cli/cli-style.h.
3643         * utils.h (fputs_highlighted): New function.
3644         * utils.c (fputs_highlighted): Likewise.
3645
3646 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3647
3648         * NEWS: Mention new pipe command and new convenience variables.
3649
3650 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3651
3652         * cli/cli-cmds.c (pipe_command): New function.
3653         (_initialize_cli_cmds): Call add_com for pipe_command.
3654         Define | as an alias for pipe.
3655         (exit_status_set_internal_vars): New function.
3656         (shell_escape): Call exit_status_set_internal_vars.
3657         cli/cli-decode.c (find_command_name_length): Recognize | as
3658         a single character command.
3659
3660 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3661
3662         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3663         top.c (execute_command_to_ui_file): New function, mostly a copy
3664         of execute_command_to_string.
3665         (execute_command_to_string): Implement by calling
3666         execute_command_to_ui_file.
3667
3668 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3669
3670         * top.h (saved_command_line): Remove declaration.
3671         * top.c (previous_saved_command_line, previous_repeat_arguments):
3672         New variables.
3673         (saved_command_line): Make static, define together with other
3674         'repeat variables'.
3675         (dont_repeat): Clear repeat_arguments.
3676         (repeat_previous, get_saved_command_line, save_command_line):
3677         New functions.
3678         (gdb_init): Initialize saved_command_line
3679         and previous_saved_command_line.
3680         * main.c (captured_main_1): Remove saved_command_line initialization.
3681         * event-top.c (handle_line_of_input): Update to use
3682         the new 'repeat' related functions instead of direct access to
3683         saved_command_line.
3684         * command.h (repeat_previous, get_saved_command_line,
3685         save_command_line): New declarations.
3686         (dont_repeat): Add comment.
3687
3688 2019-05-30  Tom Tromey  <tromey@adacore.com>
3689
3690         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3691         Fix comment.
3692         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3693
3694 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3695
3696         PR cli/24587
3697         * completer.c (complete): Initialize variable word.
3698
3699 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3700
3701         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3702         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3703         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3704         'body' is NULL to the outter 'if', protecting the '!is_define'
3705         situation as well.
3706
3707 2019-05-29  Tom Tromey  <tromey@adacore.com>
3708
3709         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3710         (dwarf_unknown): New function.
3711         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3712         (dwarf_type_encoding_name): Use dwarf_unknown.
3713
3714 2019-05-29  Tom Tromey  <tromey@adacore.com>
3715
3716         PR c++/20020:
3717         * cp-valprint.c (cp_print_value_fields): Call
3718         cp_print_static_field inside "try".
3719
3720 2019-05-29  Tom Tromey  <tromey@adacore.com>
3721
3722         * inflow.c (struct terminal_info): Add default operator=.
3723         * configure: Rebuild.
3724         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3725         -Wdeprecated-copy-dtor, -Wredundant-move.
3726
3727 2019-05-29  Tom Tromey  <tromey@adacore.com>
3728
3729         * NEWS: Add entry.
3730         * infcmd.c (print_return_value_1): Handle finish_print
3731         option.
3732         (show_print_finish): New function.
3733         (_initialize_infcmd): Add "set/show print finish" commands.
3734         * valprint.c (user_print_options): Initialize new member.
3735         * valprint.h (struct value_print_options) <finish_print>: New
3736         member.
3737
3738 2019-05-28  Tom Tromey  <tromey@adacore.com>
3739
3740         * ada-lang.c (ada_remove_Xbn_suffix)
3741         (find_old_style_renaming_symbol)
3742         (parse_old_style_renaming): Remove.
3743         (ada_find_renaming_symbol): Don't call
3744         find_old_style_renaming_symbol.
3745         (ada_is_renaming_symbol): Rename from
3746         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3747         bool.  Now static.
3748         (ada_read_var_value): Update and simplify.
3749         * ada-exp.y (write_var_or_type): Remove old code.
3750
3751 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3752
3753         * event-top.c: Remove include comment.
3754         * inflow.c (class scoped_ignore_sigttou): Move from here...
3755         * inflow.h (class scoped_ignore_sigttou): ...to here.
3756         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3757         * top.c:  Remove include comment.
3758
3759 2019-05-27  Tom Tromey  <tom@tromey.com>
3760
3761         * NEWS: Fix typo.
3762
3763 2019-05-22  Tom Tromey  <tromey@adacore.com>
3764
3765         * target.c (target_follow_exec): Constify parameter.
3766         * target-delegates.c: Rebuild.
3767         * remote.c (remote_target::follow_exec): Constify parameter.
3768         * infrun.c (follow_exec): Constify parameter.
3769         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3770         (target_follow_exec): Likewise.
3771
3772 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3773
3774         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3775         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3776
3777 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3778
3779         * NEWS: Add debugredirect and testsuite sections.
3780
3781 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3782
3783         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3784         target descriptions using exclusively floating point register name
3785         aliases.
3786
3787 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         PR gdb/18644:
3790         * f-lang.c (build_fortran_types): Handle the case where
3791         gdbarch_floatformat_for_type returns a nullptr.
3792
3793 2019-05-21  Tom de Vries  <tdevries@suse.de>
3794
3795         PR cli/24587
3796         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3797
3798 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         PR gdb/18644:
3801         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3802         16-byte floats.
3803         * i386-tdep.c (i386_floatformat_for_type): Use
3804         floatformats_ia64_quad for the 16-byte floating point component
3805         within a fortran 32-byte complex number.
3806
3807 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3810         delete default constructor.
3811         (find_partial_die): Update to return const struct.
3812         (partial_die_parent_scope): Move variable declaration into scope
3813         of its use and change its type to auto.
3814         (guess_partial_die_structure_name): Likewise.
3815         (partial_die_info::fixup): Likewise.
3816
3817 2019-05-17  Tom Tromey  <tromey@adacore.com>
3818
3819         * source.c (find_and_open_source): Remove cast.
3820
3821 2019-05-17  Tom Tromey  <tromey@adacore.com>
3822
3823         * annotate.c (annotate_source): Make "filename" const.
3824         * annotate.h (annotate_source): Use const.
3825
3826 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3827
3828         * disasm.c (set_disassembler_options): Send errors to stderr.
3829
3830 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3831
3832         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3833         (cli_interp_base::set_logging): Check debug_redirect.
3834         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3835         * cli/cli-logging.c (debug_redirect): Add static variable.
3836         (pop_output_files): Add default param.
3837         (handle_redirections): Print debug setting.
3838         (show_logging_command): Likewise.
3839         (_initialize_cli_logging): Add debugredirect command.
3840         * interps.c (current_interp_set_logging): Add debug_redirect
3841         parameter.
3842         * interps.h (set_logging): Add debug_redirect parameter.
3843         (current_interp_set_logging): Likewise.
3844         * mi/mi-common.h: Likewise.
3845         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3846
3847 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3848             Tom Tromey  <tromey@adacore.com>
3849
3850         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3851         directly.
3852         * cli/cli-interp.h (make_logging_output): Remove declaration.
3853         * cli/cli-logging.c (make_logging_output): Remove function.
3854         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3855         directly.
3856         * ui-file.c (tee_file::tee_file): Remove bools.
3857         (tee_file::~tee_file): Remove deletes.
3858         * ui-file.h (tee_file): Remove bools.
3859
3860 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3861
3862         * mi/mi-cmds.h (mi_cmd_complete): New function.
3863         * mi/mi-main.c (mi_cmd_complete): Likewise.
3864         * mi/mi-cmds.c: Define new MI command -complete.
3865         * NEWS: Mention new -complete command.
3866
3867 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3868
3869         * completer.h (complete): New function.
3870         * completer.c (complete): Likewise.
3871         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3872         function defined in completer.h.
3873
3874 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3875
3876         * MAINTAINERS (Write After Approval): Add myself.
3877
3878 2019-05-17  Tom de Vries  <tdevries@suse.de>
3879
3880         PR gdb/24094
3881         * dwarf2read.c (struct cu_partial_die_info): New struct.
3882         (find_partial_die): Return cu_partial_die_info.
3883         (partial_die_parent_scope, guess_partial_die_structure_name)
3884         (partial_die_info::fixup): Handle new return type of find_partial_die.
3885
3886 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3887
3888         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3889         "std::string", simplifying the algorithm.
3890
3891 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3892
3893         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3894         (stap_static_probe_ops::get_probes): Likewise.
3895
3896 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3897
3898         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3899         '-')" and "else if".
3900         (stap_parse_single_operand): Join checks for
3901         "gdbarch_stap_parse_special_token_p" and
3902         "gdbarch_stap_parse_special_token" in the same "if" statement.
3903         Invert check when verifying for operation on register
3904         displacement.
3905
3906 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3907
3908         * stap-probe.c (stap_get_opcode): Update comment.
3909         (stap_get_expected_argument_type): Likewise.
3910         (handle_stap_probe): Likewise.
3911
3912 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3913
3914         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3915         return type to 'bool'.  Adjust comment.  Use 'bool' when
3916         appropriate.
3917         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3918         * stap-probe.c (stap_parse_argument_1): Likewise.
3919         (stap_is_operator): Likewise.
3920         (stap_is_generic_prefix): Likewise.
3921         (stap_is_register_prefix): Likewise.
3922         (stap_is_register_indirection_prefix): Likewise.
3923         (stap_is_integer_prefix): Likewise.
3924         (stap_generic_check_suffix): Likewise.
3925         (stap_check_integer_suffix): Likewise.
3926         (stap_check_register_suffix): Likewise.
3927         (stap_check_register_indirection_suffix): Likewise.
3928         (stap_parse_register_operand): Likewise.
3929         (stap_parse_single_operand): Likewise.
3930         (stap_parse_argument_1): Likewise.
3931         (stap_probe::get_argument_count): Likewise.
3932         (stap_is_operator): Likewise.
3933
3934 2019-05-16  Tom Tromey  <tromey@adacore.com>
3935
3936         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3937         keyword to foreach.
3938
3939 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3940
3941         * linux-thread-db.c (try_thread_db_load_1): Change return type
3942         to bool.
3943         (try_thread_db_load): Likewise.
3944         (try_thread_db_load_from_pdir_1): Likewise.
3945         (try_thread_db_load_from_pdir): Likewise.
3946         (try_thread_db_load_from_sdir): Likewise.
3947         (try_thread_db_load_from_dir): Likewise.
3948         (thread_db_load_search): Likewise.
3949         (has_libpthread): Likewise.
3950         (thread_db_load): Likewise.
3951
3952 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3953
3954         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3955         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3956         NULL, and complain/return if that's the case.
3957
3958 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3959
3960         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3961         (advance, posn, abstract_read_memory): New functions.
3962         [struct mem_read_abstraction]: New struct.
3963         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3964
3965 2019-05-14  Tom Tromey  <tromey@adacore.com>
3966
3967         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3968         value is not lval_memory.
3969
3970 2019-05-14  Tom Tromey  <tromey@adacore.com>
3971
3972         * solib.c (info_sharedlibrary_command): Style the file name.
3973
3974 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3975
3976         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3977         (aarch64_vnv_type): Likewise.
3978         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3979         * common/tdesc.c: Likewise.
3980         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3981         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3982         * features/aarch64-fpu.xml: Add ieee half view.
3983         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3984         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3985         * gdbtypes.h (struct builtin_type): Likewise.
3986         (struct objfile_type): Likewise.
3987
3988 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3989
3990         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3991         typo.
3992         * location.h (string_to_event_location): Likewise.
3993
3994 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3995
3996         GDB 8.3 released.
3997
3998 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3999
4000         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4001         New variable declaration.
4002         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4003         New variable.
4004         (print_one_breakpoint): Use ui_out::test_flags and new global
4005         variable to compute use_fixed_output.
4006         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4007         Remove.
4008         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4009         (mi_multi_location_breakpoint_output_fixed): Remove.
4010         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4011         new variable.
4012         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4013         fix_multi_location_breakpoint_output flag if version >= 3.
4014         * ui-out.h (enum ui_out_flag)
4015         <fix_multi_location_breakpoint_output>: New enumerator.
4016
4017 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4018
4019         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4020
4021 2019-05-10  Tom Tromey  <tromey@adacore.com>
4022
4023         * ada-lang.c (catch_ada_completer): New function.
4024         (_initialize_ada_language): Use it.
4025
4026 2019-05-10  Tom Tromey  <tromey@adacore.com>
4027
4028         * thread.c (print_thread_info): Make "requested_threads" const.
4029         * gdbthread.h (print_thread_info): Make "requested_threads"
4030         const.
4031         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4032         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4033
4034 2019-05-08  Tom Tromey  <tom@tromey.com>
4035
4036         * gdbtypes.c (objfile_type_data): Change type.
4037         (objfile_type, _initialize_gdbtypes): Update.
4038
4039 2019-05-08  Tom Tromey  <tom@tromey.com>
4040
4041         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4042         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4043         (_initialize_dwarf2_frame): Update.
4044
4045 2019-05-08  Tom Tromey  <tom@tromey.com>
4046
4047         * objc-lang.c (objc_objfile_data): Change type.
4048         (find_methods): Update.
4049         (_initialize_objc_lang): Remove.
4050
4051 2019-05-08  Tom Tromey  <tom@tromey.com>
4052
4053         * stabsread.c (rs6000_builtin_type_data): Change type.
4054         (rs6000_builtin_type, _initialize_stabsread): Update.
4055
4056 2019-05-08  Tom Tromey  <tom@tromey.com>
4057
4058         * mips-tdep.c (mips_pdr_data): Remove.
4059         (_initialize_mips_tdep): Update.
4060
4061 2019-05-08  Tom Tromey  <tom@tromey.com>
4062
4063         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4064         (hppa_init_objfile_priv_data, read_unwind_info)
4065         (find_unwind_entry, _initialize_hppa_tdep): Update.
4066
4067 2019-05-08  Tom Tromey  <tom@tromey.com>
4068
4069         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4070         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4071         on obstack.
4072         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4073
4074 2019-05-08  Tom Tromey  <tom@tromey.com>
4075
4076         * mdebugread.c (basic_type_data): Change type.
4077         (basic_type, _initialize_mdebugread): Update.
4078
4079 2019-05-08  Tom Tromey  <tom@tromey.com>
4080
4081         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4082
4083 2019-05-08  Tom Tromey  <tom@tromey.com>
4084
4085         * nto-tdep.c (nto_inferior_data_reg): Change type.
4086         (nto_inferior_data): Update.
4087         (nto_inferior_data_cleanup, nto_new_inferior_data)
4088         (_initialize_nto_tdep): Remove.
4089         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4090
4091 2019-05-08  Tom Tromey  <tom@tromey.com>
4092
4093         * ada-lang.c (struct ada_inferior_data): Add initializers.
4094         (ada_inferior_data): Change type.
4095         (ada_inferior_data_cleanup): Remove.
4096         (get_ada_inferior_data, ada_inferior_exit)
4097         (struct ada_pspace_data): Add initializers, destructor.
4098         (ada_pspace_data_handle): Change type.
4099         (get_ada_pspace_data): Update.
4100         (ada_pspace_data_cleanup): Remove.
4101
4102 2019-05-08  Tom Tromey  <tom@tromey.com>
4103
4104         * coffread.c (struct coff_symfile_info): Add initializers.
4105         (coff_objfile_data_key): Move lower.  Change type.
4106         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4107         Update.
4108         (coff_free_info): Remove.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4113         (fbsd_pspace_data_handle): Move lower.  Change type.
4114         (get_fbsd_pspace_data): Update.
4115         (fbsd_pspace_data_cleanup): Remove.
4116         (_initialize_fbsd_tdep): Update.
4117
4118 2019-05-08  Tom Tromey  <tom@tromey.com>
4119
4120         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4121         (get_ada_tasks_pspace_data): Update.
4122         (ada_tasks_pspace_data_cleanup): Remove.
4123         (_initialize_tasks): Update.
4124         (ada_tasks_inferior_data_handle): Change type.
4125         (get_ada_tasks_inferior_data): Update.
4126         (ada_tasks_inferior_data_cleanup): Remove.
4127         (struct ada_tasks_pspace_data): Add initializers.
4128
4129 2019-05-08  Tom Tromey  <tom@tromey.com>
4130
4131         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4132         * symfile-debug.c (debug_sym_get_probes): Change type.
4133         * stap-probe.c (handle_stap_probe):
4134         (stap_static_probe_ops::get_probes): Change type.
4135         * probe.h (class static_probe_ops) <get_probes>: Change type.
4136         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4137         (parse_probes_in_pspace): Update.
4138         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4139         Update.
4140         (any_static_probe_ops::get_probes): Change type.
4141         * elfread.c (elfread_data): New typedef.
4142         (probe_key): Change type.
4143         (elf_get_probes): Likewise.  Update.
4144         (probe_key_free): Remove.
4145         (_initialize_elfread): Update.
4146         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4147         Change type.
4148         (dtrace_process_dof_probe, dtrace_process_dof)
4149         (dtrace_static_probe_ops::get_probe): Change type.
4150
4151 2019-05-08  Tom Tromey  <tom@tromey.com>
4152
4153         * xcoffread.c (struct xcoff_symfile_info): Rename from
4154         coff_symfile_info.  Add initializers.
4155         (xcoff_objfile_data_key): Move lower.  Change type.
4156         (XCOFF_DATA): Rewrite.
4157         (xcoff_free_info): Remove.
4158         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4159         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4160         (xcoff_initial_scan): Update.
4161
4162 2019-05-08  Tom Tromey  <tom@tromey.com>
4163
4164         * solib-svr4.c (struct svr4_info): Add initializers and
4165         destructor.
4166         <probes_table>: Now an htab_up.
4167         (solib_svr4_pspace_data): Change type.
4168         (free_probes_table): Simplify.
4169         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4170         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4171         (probes_table_remove_objfile_probes, register_solib_event_probe)
4172         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4173         (_initialize_svr4_solib): Update.
4174
4175 2019-05-08  Tom Tromey  <tom@tromey.com>
4176
4177         * remote.c (remote_pspace_data): Change type.
4178         (remote_pspace_data_cleanup): Remove.
4179         (get_remote_exec_file, set_pspace_remote_exec_file)
4180         (_initialize_remote): Update.
4181
4182 2019-05-08  Tom Tromey  <tom@tromey.com>
4183
4184         * breakpoint.c (breakpoint_objfile_key): Change type.
4185         (get_breakpoint_objfile_data): Update.
4186         (free_breakpoint_objfile_data): Remove.
4187         (_initialize_breakpoint): Update.
4188
4189 2019-05-08  Tom Tromey  <tom@tromey.com>
4190
4191         * linux-tdep.c (struct linux_info): Add initializers.
4192         (linux_inferior_data): Move.  Change type.
4193         (invalidate_linux_cache_inf): Update.
4194         (linux_inferior_data_cleanup): Remove.
4195         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4196
4197 2019-05-08  Tom Tromey  <tom@tromey.com>
4198
4199         * auxv.c (auxv_inferior_data): Move.  Change type.
4200         (auxv_inferior_data_cleanup): Remove.
4201         (invalidate_auxv_cache_inf): Rewrite.
4202         (get_auxv_inferior_data, _initialize_auxv): Update.
4203
4204 2019-05-08  Tom Tromey  <tom@tromey.com>
4205
4206         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4207         (symfile_debug_objfile_data_key): Change type.
4208         (symfile_debug_installed, debug_qf_has_symbols)
4209         (debug_qf_find_last_source_symtab)
4210         (debug_qf_forget_cached_source_info)
4211         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4212         (debug_qf_print_stats, debug_qf_dump)
4213         (debug_qf_expand_symtabs_for_function)
4214         (debug_qf_expand_all_symtabs)
4215         (debug_qf_expand_symtabs_with_fullname)
4216         (debug_qf_map_matching_symbols)
4217         (debug_qf_expand_symtabs_matching)
4218         (debug_qf_find_pc_sect_compunit_symtab)
4219         (debug_qf_map_symbol_filenames)
4220         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4221         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4222         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4223         (debug_sym_read_linetable, debug_sym_relocate): Update.
4224         (symfile_debug_free_objfile): Remove.
4225         (install_symfile_debug_logging, _initialize_symfile_debug):
4226         Update.
4227
4228 2019-05-08  Tom Tromey  <tom@tromey.com>
4229
4230         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4231         allocate_on_obstack.
4232         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4233         (get_dwarf2_per_objfile): Update.
4234         (set_dwarf2_per_objfile): Remove.
4235         (dwarf2_has_info, dwarf2_get_section_info): Update.
4236         (dwarf2_free_objfile): Remove.
4237         (_initialize_dwarf2_read): Update.
4238
4239 2019-05-08  Tom Tromey  <tom@tromey.com>
4240
4241         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4242         initializers.
4243         <unsupported_script_warning_printed,
4244         script_not_found_warning_printed>: Now bool.
4245         (auto_load_pspace_data): Change type.
4246         (~auto_load_pspace_info): Rename from
4247         auto_load_pspace_data_cleanup.
4248         (get_auto_load_pspace_data, init_loaded_scripts_info)
4249         (clear_section_scripts, maybe_print_unsupported_script_warning)
4250         (maybe_print_script_not_found_warning, _initialize_auto_load):
4251         Update.
4252
4253 2019-05-08  Tom Tromey  <tom@tromey.com>
4254
4255         * objfiles.c (objfile_pspace_info): Add destructor and
4256         initializers.
4257         (objfiles_pspace_data): Change type.
4258         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4259         (get_objfile_pspace_data): Update.
4260         (objfiles_bfd_data): Change type.
4261         (get_objfile_bfd_data): Update.
4262         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4267         Change type.
4268         (get_catch_syscall_inferior_data): Update.
4269         (catch_syscall_inferior_data_cleanup): Remove.
4270         (_initialize_break_catch_syscall): Update.
4271
4272 2019-05-08  Tom Tromey  <tom@tromey.com>
4273
4274         * inflow.c (struct terminal_info): Add destructor and
4275         initializers.
4276         (inflow_inferior_data): Change type.
4277         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4278         (get_inflow_inferior_data, inflow_inferior_exit)
4279         (swap_terminal_info, _initialize_inflow): Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * target-dcache.c (target_dcache_cleanup): Remove.
4284         (target_dcache_aspace_key): Change type.
4285         (target_dcache_init_p, target_dcache_invalidate)
4286         (target_dcache_get, target_dcache_get_or_init)
4287         (_initialize_target_dcache): Update.
4288         * dcache.h (struct dcache_deleter): New.
4289
4290 2019-05-08  Tom Tromey  <tom@tromey.com>
4291
4292         * symtab.c (struct symbol_cache): Add destructor and
4293         initializers.
4294         (symbol_cache_key): Move.  Change type.
4295         (make_symbol_cache, free_symbol_cache): Remove.
4296         (get_symbol_cache): Update.
4297         (symbol_cache_cleanup): Remove.
4298         (ALL_PSPACES, symbol_cache_flush)
4299         (maintenance_print_symbol_cache)
4300         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4301         Update.
4302
4303 2019-05-08  Tom Tromey  <tom@tromey.com>
4304
4305         * symtab.c (struct main_info): Add destructor and initializers.
4306         (main_progspace_key): Move.  Change type.
4307         (get_main_info): Update.
4308         (main_info_cleanup): Remove.
4309         (_initialize_symtab): Update.
4310
4311 2019-05-08  Tom Tromey  <tom@tromey.com>
4312
4313         * registry.h (DECLARE_REGISTRY): Define the _key class.
4314
4315 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4316
4317         * NEWS: Merge two 'New commands' sections.
4318
4319 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4320
4321         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4322         parameter and use Ada language definition instead.
4323         (ada_val_print_ptr): Remove unused language parameter.
4324         (ada_val_print_num): Remove language parameter and use Ada language
4325         definition instead.
4326         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4327         parameter.
4328         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4329         parameter and use Ada language definition instead.
4330         (ada_val_print_1): Update all ada_val_print_xxx calls.
4331         Remove language parameter.
4332         (ada_val_print): Update ada_val_print_1 call.
4333
4334 2019-05-08  Tom Tromey  <tromey@adacore.com>
4335
4336         * remote.c (remote_hw_watchpoint_limit)
4337         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4338         Now static.
4339
4340 2019-05-08  Tom Tromey  <tromey@adacore.com>
4341
4342         * maint.c (_initialize_maint_cmds): Move initialization code to
4343         remote.c.
4344         (watchdog, show_watchdog): Move to remote.c.
4345         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4346         "watchdog" static.
4347         (_initialize_remote): Move initialization code from maint.c.
4348         * defs.h (watchdog): Don't declare.
4349
4350 2019-05-08  Tom Tromey  <tromey@adacore.com>
4351
4352         * tui/tui-interp.c: Include main.h.
4353         * interps.c: Include main.h.
4354         * main.h (interpreter_p): Declare.
4355         * defs.h (interpreter_p): Don't declare.
4356
4357 2019-05-08  Tom Tromey  <tromey@adacore.com>
4358
4359         * dwarf2loc.c: Include dwarf2read.h.
4360         * defs.h (read_unsigned_leb128): Don't declare.
4361         * dwarf2read.h (read_unsigned_leb128): Declare.
4362
4363 2019-05-08  Tom Tromey  <tromey@adacore.com>
4364
4365         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4366         method.
4367
4368 2019-05-08  Tom Tromey  <tromey@adacore.com>
4369
4370         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4371         when no wrap column is set.
4372
4373 2019-05-08  Tom Tromey  <tromey@adacore.com>
4374
4375         * c-lang.c (c_get_string): Handle non-C-style arrays.
4376
4377 2019-05-08  Tom Tromey  <tromey@adacore.com>
4378
4379         * typeprint.c (print_offset_data::update): Print the bit offset,
4380         not the number of bits remaining.
4381
4382 2019-05-08  Tom Tromey  <tromey@adacore.com>
4383
4384         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4385         padding at end of comment.
4386
4387 2019-05-08  Tom Tromey  <tromey@adacore.com>
4388
4389         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4390         Compare main types.
4391
4392 2019-05-06  Tom Tromey  <tom@tromey.com>
4393
4394         * common/scoped_mmap.c: Include common-defs.h.
4395         * common/scoped_mmap.h: Don't include config.h.
4396
4397 2019-05-04  Tom Tromey  <tom@tromey.com>
4398
4399         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4400         (struct aarch64_call_info): Add initializers.
4401         <si>: Now a std::vector.
4402         (pass_on_stack, aarch64_push_dummy_call): Update.
4403
4404 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4405             Tom Tromey  <tom@tromey.com>
4406
4407         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4408         (ppc_threads): Now a std::vector.  Now static.
4409         (hwdebug_find_thread_points_by_tid)
4410         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4411         Update.
4412
4413 2019-05-04  Tom Tromey  <tom@tromey.com>
4414
4415         * arc-tdep.c (arc_tdesc_init): Return bool.
4416
4417 2019-05-04  Tom Tromey  <tom@tromey.com>
4418
4419         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4420         Use gdb_assert_not_reached.
4421
4422 2019-05-04  Tom Tromey  <tom@tromey.com>
4423
4424         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4425         "false".
4426
4427 2019-05-04  Tom Tromey  <tom@tromey.com>
4428
4429         * arc-tdep.c (arc_tdesc_init): Use bool.
4430
4431 2019-05-04  Tom Tromey  <tom@tromey.com>
4432
4433         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4434
4435 2019-05-04  Tom Tromey  <tom@tromey.com>
4436
4437         * cli/cli-cmds.c (valid_command_p): Return bool.
4438
4439 2019-05-04  Tom Tromey  <tom@tromey.com>
4440
4441         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4442         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4443
4444 2019-05-04  Raul Tambre  <raul@tambre.ee>
4445
4446         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4447         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4448         operator for comparison.
4449
4450 2019-05-04  Tom Tromey  <tom@tromey.com>
4451
4452         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4453         (lookup_partial_symbol, print_partial_symbols)
4454         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4455         (psymbol_compare): Update.
4456         (add_psymbol_to_bcache): Clear the entire psymbol.
4457         (maintenance_check_psymtabs): Update.
4458         * psympriv.h (struct partial_symbol): Don't derive from
4459         general_symbol_info.
4460         <obj_section, unrelocated_address, address,
4461         set_unrelocated_address>: Update.
4462         <ginfo>: New member.
4463         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4464         (debug_names::write_psymbols): Update.
4465
4466 2019-05-04  Tom de Vries  <tdevries@suse.de>
4467
4468         * contrib/cc-with-tweaks.sh: Support -n arg.
4469
4470 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4471
4472         * corelow.c (core_target::detach): Ensure frame cache and
4473         register caches are cleared.
4474         inferior.c (exit_inferior_1): Likewise.
4475
4476 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4477             Tom Tromey  <tom@tromey.com>
4478
4479         * dictionary.c (collate_pending_symbols_by_language): Remove
4480         "struct" from foreach.
4481         * symtab.c (lookup_global_symbol_from_objfile)
4482         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4483         foreach.
4484         * ser-tcp.c (net_open): Remove "struct" from foreach.
4485         * objfiles.c (objfile_relocate, objfile_rebase)
4486         (objfile_has_symbols): Remove "struct" from foreach.
4487         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4488         from foreach.
4489         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4490         foreach.
4491         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4492         "struct" from foreach.
4493         * ada-lang.c (create_excep_cond_exprs)
4494         (ada_exception_catchpoint_cond_string): Remove "struct" from
4495         foreach.
4496
4497 2019-05-03  Tom Tromey  <tromey@adacore.com>
4498
4499         * ada-exp.y (convert_char_literal): Check suffix of each
4500         enumerator.
4501
4502 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4503
4504         PR ada/21406:
4505         * ada-exp.y (yywrap): Don't define.
4506         * ada-lex.l (%option): Add noyywrap
4507         (yywrap): Remove.
4508
4509 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4510
4511         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4512         _WIN32_WINNT to the XP level, unless already defined to a higher
4513         level.
4514
4515         * unittests/parse-connection-spec-selftests.c:
4516         * ser-tcp.c:
4517         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4518         override.
4519
4520         * symfile.c (find_separate_debug_file): Remove colon from the
4521         drive spec of DOS/Windows file names of the target, so that the
4522         file name produced from DEBUGDIR and the target's directory will
4523         be valid on DOS/Windows systems.
4524
4525 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * rust-lang.c (val_print_struct): Handle printing structures
4528         containing strings.
4529
4530 2019-05-02  Tom Tromey  <tromey@adacore.com>
4531
4532         * valarith.c (_initialize_valarith): Remove.
4533
4534 2019-05-01  Tom Tromey  <tromey@adacore.com>
4535
4536         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4537         bitfields.
4538
4539 2019-05-01  Tom Tromey  <tromey@adacore.com>
4540
4541         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4542         for big-endian copies.
4543
4544 2019-04-30  Ali Tamur  <tamur@google.com>
4545         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4546         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4547         (read_3_bytes): New function.
4548
4549 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4550
4551         * windows-nat.c (main_thread_id): Delete.
4552         (handle_output_debug_string): Replace main_thread_id by
4553         current_event.dwThreadId.
4554         (fake_create_process): Likewise.
4555         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4556         Do not set main_thread_id.
4557         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4558         current_event.dwThreadId.
4559         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4560
4561 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4562
4563         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4564         Use current_event.dwThreadId instead of main_thread_id.
4565
4566 2019-04-30  Tom Tromey  <tromey@adacore.com>
4567
4568         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4569         (create_excep_cond_exprs): Iterate over program spaces.
4570         (ada_exception_catchpoint_cond_string): Examine all minimal
4571         symbols for exception types.
4572
4573 2019-04-30  Tom Tromey  <tromey@adacore.com>
4574
4575         PR c++/24470:
4576         * dwarf2read.c (process_structure_scope): Handle case where type
4577         has template parameters but no symbol was created.
4578
4579 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4580             Chris January  <chris.january@arm.com>
4581
4582         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4583         qualifier.
4584         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4585
4586 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4587
4588         * f-typeprint.c (f_print_type): Update rules for printing
4589         whitespace.
4590         (f_type_print_varspec_suffix): Likewise.
4591
4592 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4593             Chris January  <chris.january@arm.com>
4594
4595         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4596         function arguments.
4597
4598 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * f-lang.c (build_fortran_types): Change name of void type to
4601         lower case.
4602         * f-typeprint.c (f_type_print_base): Print the name of the void
4603         type, rather than a fixed string.
4604         * f-valprint.c (f_decorations): Use lower case void string.
4605
4606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4607             Chris January  <chris.january@arm.com>
4608
4609         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4610         types for Fortran.
4611
4612 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4613             Chris January  <chris.january@arm.com>
4614             David Lecomber  <david.lecomber@arm.com>
4615
4616         * f-exp.y (BINOP_INTRINSIC): New token.
4617         (exp): New parser rule handling BINOP_INTRINSIC.
4618         (f77_keywords): Add new builtin procedures.
4619         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4620         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4621         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4622         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4623         (print_unop_subexp_f): New function.
4624         (print_binop_subexp_f): New function.
4625         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4626         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4627         (dump_subexp_body_f): Likewise.
4628         (operator_check_f): Likewise.
4629         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4630         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4631
4632 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4635         UNOP_KIND.
4636         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4637         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4638         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4639         (operator_length_f): New fuction.
4640         (print_subexp_f): New function.
4641         (op_name_f): New function.
4642         (dump_subexp_body_f): New function.
4643         (operator_check_f): New function.
4644         (exp_descriptor_f): Replace standard expression handling functions
4645         with new functions.
4646         * gdb/fortran-operator.def: New file.
4647         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4648         * gdb/std-operator.def: Remove UNOP_KIND.
4649
4650 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * std-operator.def: Remove unbalanced, stray double quote
4653         character.
4654
4655 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4656             Chris January  <chris.january@arm.com>
4657             Daniel Everett  <daniel.everett@arm.com>
4658             Nick Forrington  <nick.forrington@arm.com>
4659             Richard Bunt  <richard.bunt@arm.com>
4660
4661         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4662         of depth when printing anonymous structs or unions.
4663         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4664         Don't print either the top-level value, or the children if the
4665         max-depth is exceeded.
4666         (ppscm_print_children): When printing the key of a map, allow one
4667         extra level of depth.
4668         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4669         print either the top-level value, or the children if the max-depth
4670         is exceeded.
4671         (print_children): When printing the key of a map, allow one extra
4672         level of depth.
4673         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4674         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4675         (user_print_options): Initialise max_depth field.
4676         (val_print_scalar_or_string_type_p): New function.
4677         (val_print): Check to see if the max depth has been reached.
4678         (val_print_check_max_depth): Define new function.
4679         (show_print_max_depth): New function.
4680         (_initialize_valprint): Add 'print max-depth' option.
4681         * valprint.h (struct value_print_options) <max_depth>: New field.
4682         (val_print_check_max_depth): Declare new function.
4683         * NEWS: Document new feature.
4684
4685 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4686
4687         * ada-lang.c (ada_language_defn): Initialise new field.
4688         * c-lang.c (c_is_string_type_p): New function.
4689         (c_language_defn): Initialise new field.
4690         (cplus_language_defn): Initialise new field.
4691         (asm_language_defn): Initialise new field.
4692         (minimal_language_defn): Initialise new field.
4693         * c-lang.h (c_is_string_type_p): Declare new function.
4694         * d-lang.c (d_language_defn): Initialise new field.
4695         * f-lang.c (f_is_string_type_p): New function.
4696         (f_language_defn): Initialise new field.
4697         * go-lang.c (go_is_string_type_p): New function.
4698         (go_language_defn): Initialise new field.
4699         * language.c (default_is_string_type_p): New function.
4700         (unknown_language_defn): Initialise new field.
4701         (auto_language_defn): Initialise new field.
4702         * language.h (struct language_defn) <la_is_string_type_p>: New
4703         member variable.
4704         (default_is_string_type_p): Declare new function.
4705         * m2-lang.c (m2_language_defn): Initialise new field.
4706         * objc-lang.c (objc_language_defn): Initialise new field.
4707         * opencl-lang.c (opencl_language_defn): Initialise new field.
4708         * p-lang.c (pascal_is_string_type_p): New function.
4709         (pascal_language_defn): Initialise new field.
4710         * rust-lang.c (rust_is_string_type_p): New function.
4711         (rust_language_defn): Initialise new field.
4712
4713 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4716         New field.
4717         * ada-lang.c (ada_language_defn): Initialise new field.
4718         * c-lang.c (c_language_defn): Likewise.
4719         (cplus_language_defn): Likewise.
4720         (asm_language_defn): Likewise.
4721         (minimal_language_defn): Likewise.
4722         * d-lang.c (d_language_defn): Likewise.
4723         * f-lang.c (f_language_defn): Likewise.
4724         * go-lang.c (go_language_defn): Likewise.
4725         * language.c (unknown_language_defn): Likewise.
4726         (auto_language_defn): Likewise.
4727         * m2-lang.c (m2_language_defn): Likewise.
4728         * objc-lang.c (objc_language_defn): Likewise.
4729         * opencl-lang.c (opencl_language_defn): Likewise.
4730         * p-lang.c (pascal_language_defn): Likewise.
4731         * rust-lang.c (rust_language_defn): Likewise.
4732
4733 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * ada-lang.c (ada_is_character_type): Change return type to bool.
4736         (ada_is_string_type): Likewise.
4737         * ada-lang.h (ada_is_character_type): Update declaration
4738         (ada_is_string_type): Likewise.
4739
4740 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4741
4742         Support style in 'frame|thread apply'
4743
4744         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4745         * record.c (record_start, record_stop): Update callers of
4746         execute_command_to_string with false.
4747         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4748         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4749         methods.
4750         (class string_file): New constructor with term_out parameter.
4751         Override methods term_out and can_emit_style_escape.  New member
4752         term_out.
4753         (class stdio_file): Override can_emit_style_escape.
4754         (class tee_file): Override term_out and can_emit_style_escape.
4755         * utils.h (can_emit_style_escape): Remove.
4756         * utils.c (can_emit_style_escape): Likewise.
4757         Update all callers of can_emit_style_escape (SOMESTREAM) to
4758         SOMESTREAM->can_emit_style_escape.
4759         * source-cache.c (source_cache::get_source_lines): Likewise.
4760         * stack.c (frame_apply_command_count): Call execute_command_to_string
4761         passing the term_out characteristic of the current gdb_stdout.
4762         * thread.c (thr_try_catch_cmd): Likewise.
4763         * top.c (execute_command_to_string): pass term_out parameter
4764         to construct the string_file for the command output.
4765         * ui-file.c (term_cli_styling): New function (most code moved
4766         from utils.c can_emit_style_escape).
4767         (string_file::string_file, string_file::can_emit_style_escape,
4768         stdio_file::can_emit_style_escape, tee_file::term_out,
4769         tee_file::can_emit_style_escape): New functions.
4770
4771 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * NEWS: Mention the new set|show may-call-functions.
4774         * infcall.c (may_call_functions_p): New variable.
4775         (show_may_call_functions_p): New function.
4776         (call_function_by_hand_dummy): Throws an error if not
4777         may-call-functions.
4778         (_initialize_infcall): Call add_setshow_boolean_cmd for
4779         may-call-functions.
4780
4781 2019-04-25  Keith Seitz  <keiths@redhat.com>
4782
4783         PR c++/24367
4784         * cp-support.c (inspect_type): Don't attempt substitutions
4785         of symbol with the same name.
4786
4787 2019-04-25  Tom Tromey  <tromey@adacore.com>
4788
4789         PR gdb/24475:
4790         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4791         static.
4792
4793 2019-04-25  Tom Tromey  <tromey@adacore.com>
4794
4795         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4796         rvalue reference.
4797         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4798         (gdb_xml_parser::parse): Use std::move.
4799         * python/python-internal.h (gdbpy_convert_exception): Take a const
4800         reference.
4801         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4802         std::move.
4803         * python/py-utils.c (gdbpy_convert_exception): Take a const
4804         reference.
4805         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4806         Use std::move.
4807         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4808         Use std::move.
4809         * mi/mi-main.c (mi_print_exception): Take a const reference.
4810         * main.c (handle_command_errors): Take a const reference.
4811         * linespec.c (parse_linespec): Use std::move.
4812         * infcall.c (run_inferior_call): Use std::move.
4813         (call_function_by_hand_dummy): Use std::move.
4814         * exec.c (try_open_exec_file): Use std::move.
4815         * exceptions.h (exception_print, exception_fprintf)
4816         (exception_print_same): Update.
4817         * exceptions.c (print_exception, exception_print)
4818         (exception_fprintf, exception_print_same): Change parameters to
4819         const reference.
4820         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4821         * common/new-op.c: Use std::move.
4822         * common/common-exceptions.h (struct gdb_exception): Add move
4823         constructor.
4824         (struct gdb_exception_error, struct gdb_exception_quit, struct
4825         gdb_quit_bad_alloc): Change constructor to move constructor.
4826         (throw_exception): Change parameter to rvalue reference.
4827         * common/common-exceptions.c (throw_exception): Take rvalue
4828         reference.
4829         * cli/cli-interp.c (safe_execute_command): Use std::move.
4830         * breakpoint.c (insert_bp_location, location_to_sals): Use
4831         std::move.
4832
4833 2019-04-25  Tom Tromey  <tromey@adacore.com>
4834
4835         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4836         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4837         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4838         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4839         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4840         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4841         guile/scm-value.c: Use unpack.
4842         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4843         gdbscm_gdb_exception.
4844         (gdbscm_throw_gdb_exception): Likewise.
4845         (struct gdbscm_gdb_exception): New.
4846         (unpack): New function.
4847         (gdbscm_wrap): Use unpack.
4848
4849 2019-04-25  Tom Tromey  <tromey@adacore.com>
4850
4851         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4852         (gdb_rl_callback_handler): Use std::move.
4853         * common/common-exceptions.h (struct gdb_exception): Add move
4854         assignment operator.
4855         (throw_exception_sjlj): Change "exception" to const reference.
4856         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4857         (throw_exception_sjlj): Change "exception" to const reference.
4858
4859 2019-04-25  Tom Tromey  <tromey@adacore.com>
4860
4861         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4862         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4863         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4864         Update.
4865         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4866         Update.
4867         * mi/mi-interp.c (mi_interp::exec): Update.
4868         * linespec.c (parse_linespec): Update.
4869         * infcall.c (run_inferior_call): Update.
4870         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4871         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4872         (gdbscm_lookup_global_symbol): Update.
4873         * guile/scm-param.c (gdbscm_parameter_value): Update.
4874         * guile/scm-frame.c (gdbscm_frame_read_register)
4875         (gdbscm_frame_read_var): Update.
4876         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4877         * exec.c (try_open_exec_file): Update.
4878         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4879         (gdb_rl_callback_handler): Update.
4880         * common/common-exceptions.h (exception_none): Don't declare.
4881         * common/common-exceptions.c (exception_none): Don't define.
4882         (struct catcher) <exception>: Update.
4883         * cli/cli-interp.c (safe_execute_command): Update.
4884         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4885
4886 2019-04-25  Ali Tamur  <tamur@google.com>
4887
4888         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4889         (read_attribute_value): Likewise.
4890         (dwarf2_read_addr_index): Update comment.
4891         (read_str_index): Add DW_FORM_strx.
4892         (dwarf2_string_attr): Likewise.
4893         (dwarf2_const_value_attr): Likewise.
4894         (dump_die_shallow): Likewise.
4895         (dwarf2_fetch_constant_bytes): Likewise.
4896         (skip_form_bytes): Likewise.
4897         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4898
4899 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4900
4901         PR corefiles/11608
4902         PR corefiles/18187
4903         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4904         OFFSET.  Verify if current mapping contains an ELF header.
4905         (linux_find_memory_regions_full): Adjust call to
4906         dump_mapping_p.
4907
4908 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4909             Kang Li <kanglictf@gmail.com>
4910
4911         PR gdb/21600
4912
4913         * dwarf2-frame.c (read_initial_length): Be consistent about using
4914         unsigned representation of length.
4915         (decode_frame_entry_1): Likewise.  Check for wraparound of
4916         end pointer as well as buffer overflow.
4917
4918 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4919
4920         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4921         "vq".
4922
4923 2019-04-24  Tom Tromey  <tromey@adacore.com>
4924
4925         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4926
4927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * s12z-tdep.c (s12z_unwind_pc): Delete.
4930         (s12z_unwind_sp): Delete.
4931         (s12z_gdbarch_init): Don't register deleted functions with
4932         gdbarch.
4933
4934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * rl78-tdep.c (rl78_unwind_sp): Delete.
4937         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4942         (xstormy16_unwind_pc): Delete.
4943         (xstormy16_dummy_id): Delete.
4944         (xstormy16_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * vax-tdep.c (vax_unwind_pc): Delete.
4950         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4951
4952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * v850-tdep.c (v850_unwind_sp): Delete.
4955         (v850_unwind_pc): Delete.
4956         (v850_dummy_id): Delete.
4957         (v850_gdbarch_init): Don't register deleted functions with
4958         gdbarch.
4959
4960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4963         (tilegx_unwind_pc): Delete.
4964         (tilegx_unwind_dummy_id): Delete.
4965         (tilegx_gdbarch_init): Don't register deleted functions with
4966         gdbarch.
4967
4968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4971         (tic6x_dummy_id): Delete.
4972         (tic6x_gdbarch_init): Don't register deleted functions with
4973         gdbarch.
4974
4975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * sparc-tdep.c (sparc_unwind_pc): Delete.
4978         (sparc32_gdbarch_init): Don't register deleted function with
4979         gdbarch.
4980
4981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * sh-tdep.c (sh_unwind_sp): Delete.
4984         (sh_unwind_pc): Delete.
4985         (sh_dummy_id): Delete.
4986         (sh_gdbarch_init): Don't register deleted functions with
4987         gdbarch.
4988
4989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * score-tdep.c (score_unwind_sp): Delete.
4992         (score_unwind_pc): Delete.
4993         (score_dummy_id): Delete.
4994         (score_gdbarch_init): Don't register deleted functions with
4995         gdbarch.
4996
4997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * rx-tdep.c (rx_unwind_pc): Delete.
5000         (rx_unwind_sp): Delete.
5001         (rx_dummy_id): Delete.
5002         (rx_gdbarch_init): Don't register deleted functions with
5003         gdbarch.  Update comment.
5004
5005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5006
5007         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5008         (rs6000_dummy_id): Delete.
5009         (rs6000_gdbarch_init): Don't register deleted functions with
5010         gdbarch.
5011
5012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * or1k-tdep.c (or1k_dummy_id): Delete.
5015         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5016
5017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * nios2-tdep.c (nios2_dummy_id): Delete.
5020         (nios2_unwind_sp): Delete.
5021         (nios2_gdbarch_init): Don't register deleted functions with
5022         gdbarch.
5023
5024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * nds32-tdep.c (nds32_dummy_id): Delete.
5027         (nds32_unwind_pc): Delete.
5028         (nds32_unwind_sp): Delete.
5029         (nds32_gdbarch_init): Don't register deleted functions with
5030         gdbarch.
5031
5032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * msp430-tdep.c (msp430_unwind_pc): Delete.
5035         (msp430_unwind_sp): Delete.
5036         (msp430_dummy_id): Delete.
5037         (msp430_gdbarch_init): Don't register deleted functions with
5038         gdbarch.
5039
5040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * moxie-tdep.c (moxie_unwind_sp): Delete.
5043         (moxie_unwind_pc): Delete.
5044         (moxie_dummy_id): Delete.
5045         (moxie_gdbarch_init): Don't register deleted functions with
5046         gdbarch.
5047
5048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5051         (mn10300_unwind_pc): Delete.
5052         (mn10300_unwind_sp): Delete.
5053         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5054         mn10300_unwind_sp.
5055         (mn10300_frame_unwind_init): Don't register deleted functions with
5056         gdbarch.
5057
5058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * mep-tdep.c (mep_unwind_pc): Delete.
5061         (mep_unwind_sp): Delete.
5062         (mep_dummy_id): Delete.
5063         (mep_gdbarch_init): Don't register deleted functions with
5064         gdbarch.
5065
5066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5069         (m68hc11_unwind_sp): Delete.
5070         (m68hc11_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * m32r-tdep.c (m32r_unwind_sp): Delete.
5076         (m32r_unwind_pc): Delete.
5077         (m32r_dummy_id): Delete.
5078         (m32r_gdbarch_init): Don't register deleted functions with
5079         gdbarch.
5080
5081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * m32c-tdep.c (m32c_unwind_pc): Delete.
5084         (m32c_unwind_sp): Delete.
5085         (m32c_dummy_id): Delete.
5086         (m32c_gdbarch_init): Don't register deleted functions with
5087         gdbarch.
5088
5089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5092         (lm32_unwind_pc): Delete.
5093         (lm32_dummy_id): Delete.
5094         (lm32_gdbarch_init): Don't register deleted functions with
5095         gdbarch.
5096
5097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5100         (iq2000_unwind_pc): Delete.
5101         (iq2000_dummy_id): Delete.
5102         (iq2000_gdbarch_init): Don't register deleted functions with
5103         gdbarch.
5104
5105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5106
5107         * nds32-tdep.c (nds32_type_align): Delete.
5108         (nds32_push_dummy_call): Use type_align instead.
5109
5110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * arm-tdep.c (arm_type_align): Only handle vector override case.
5113         (arm_push_dummy_call): Use type_align.
5114         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5115
5116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5119         case.
5120         (pass_on_stack): Use type_align.
5121         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5122         function.
5123
5124 2019-04-23  Tom Tromey  <tromey@adacore.com>
5125
5126         * dwarf2read.c (line_header::file_name_at): Remove unused
5127         overload.
5128
5129 2019-04-23  Tom de Vries  <tdevries@suse.de>
5130
5131         PR gdb/24438
5132         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5133         invocation.
5134
5135
5136 2019-03-27  Ali Tamur  <tamur@google.com>
5137
5138         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5139         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5140         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5141         (dwarf_expr_context::get_addr_index): Likewise
5142         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5143         (symbol_needs_eval_context::get_addr_index): Likewise
5144         (disassemble_dwarf_expression): Add DW_OP_addrx
5145         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5146         (read_cutu_die_from_dwo): Update comment
5147         (skip_one_die): Add DW_FORM_addrx
5148         (read_attribute_value): Likewise
5149         (var_decode_location): Add DW_OP_addrx
5150         (dwarf2_const_value_attr): Add DW_FORM_addrx
5151         (dump_die_shallow): Likewise
5152         (dwarf2_fetch_constant_bytes): Likewise
5153         (decode_locdesc): Add DW_OP_addrx
5154         (skip_form_bytes): Add DW_FORM_addrx
5155
5156 2019-04-22  Ali Tamur  <tamur@google.com>
5157
5158         * MAINTAINERS (Write After Approval): Add self.
5159
5160 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5161
5162         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5163         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5164         (open_symbol_file_object): Likewise.
5165         (svr4_default_sos): Add info parameter.
5166         (svr4_read_so_list): Likewise.
5167         (svr4_current_sos_direct): Adjust functions calls to pass down
5168         info.
5169         (svr4_current_sos_1): Add info parameter.
5170         (svr4_current_sos): Call get_svr4_info, pass info down to
5171         svr4_current_sos_1.
5172         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5173         get_svr4_info.
5174         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5175         get_svr4_info.
5176         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5177         to get_svr4_info.
5178         (probes_table_remove_objfile_probes): Likewise.
5179         (register_solib_event_probe): Add info parameter.
5180         (solist_update_incremental): Pass info parameter down to
5181         svr4_read_so_list.
5182         (disable_probes_interface): Add info parameter.
5183         (svr4_handle_solib_event): Pass current_program_space to
5184         get_svr4_info.  Adjust disable_probes_interface cleanup.
5185         (svr4_create_probe_breakpoints): Add info parameter, pass it
5186         down to register_solib_event_probe.
5187         (svr4_create_solib_event_breakpoints): Add info parameter,
5188         pass it down to svr4_create_probe_breakpoints.
5189         (enable_break): Pass info down to
5190         svr4_create_solib_event_breakpoints.
5191         (svr4_solib_create_inferior_hook): Pass current_program_space to
5192         get_svr4_info.
5193         (svr4_clear_solib): Likewise.
5194
5195 2019-04-22  Pedro Alves  <palves@redhat.com>
5196
5197         * solib-svr4.c (svr4_free_objfile_observer): New.
5198         (probe_and_action::objfile): New field.
5199         (probes_table_htab_remove_objfile_probes)
5200         (probes_table_remove_objfile_probes): New functions.
5201         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5202         in the new probe_and_action.  Don't store the probe in 'lookup'.
5203         (svr4_create_probe_breakpoints): Pass objfile to
5204         register_solib_event_probe.
5205         (_initialize_svr4_solib): Register a free_objfile observer.
5206
5207 2019-04-19  Tom Tromey  <tom@tromey.com>
5208
5209         * common/queue.h: Remove.
5210
5211 2019-04-19  Tom Tromey  <tom@tromey.com>
5212
5213         * event-loop.c: Don't include "common/queue.h".
5214
5215 2019-04-19  Tom Tromey  <tom@tromey.com>
5216
5217         * remote.c (remote_target): Use delete.
5218         * remote-notif.h: Include <list>, not "common/queue.h".
5219         (notif_client_p): Remove typedef.
5220         (remote_notif_state): Add constructor, destructor, initializer.
5221         <notif_queue>: Now a std::list.
5222         (remote_notif_state_xfree): Don't declare.
5223         * remote-notif.c (remote_notif_process, handle_notification)
5224         (remote_notif_state_allocate): Update.
5225         (~remote_notif_state): Rename from remote_notif_state_xfree.
5226
5227 2019-04-19  Tom Tromey  <tom@tromey.com>
5228
5229         * symfile.c (reread_symbols): Update.
5230         * objfiles.c (objfile_register_static_link)
5231         (objfile_lookup_static_link): Update
5232         (~objfile) Don't delete static_links.
5233         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5234
5235 2019-04-19  Tom Tromey  <tom@tromey.com>
5236
5237         * type-stack.h (struct type_stack) <insert>: Constify string.
5238         * type-stack.c (type_stack::insert): Constify string.
5239         * gdbtypes.h (lookup_template_type): Update.
5240         (address_space_name_to_int): Update.
5241         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5242         const.
5243         (lookup_template_type): Make name const.
5244         * c-exp.y: Update rules.
5245         (lex_one_token, classify_name, classify_inner_name)
5246         (c_print_token): Update.
5247         * p-exp.y: Update rules.
5248         (yylex): Update.
5249         * f-exp.y: Update rules.
5250         (yylex): Update.
5251         * d-exp.y: Update rules.
5252         (lex_one_token, classify_name, classify_inner_name): Update.
5253         * parse.c (write_dollar_variable, copy_name): Return std::string.
5254         * parser-defs.h (copy_name): Change return type.
5255         * m2-exp.y: Update rules.
5256         (yylex): Update.
5257         * go-exp.y (lex_one_token): Update.
5258         Update rules.
5259         (classify_unsafe_function, classify_packaged_name)
5260         (classify_name, yylex): Update.
5261
5262 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5263
5264         * configure.ac: add --enable-source-highlight switch.
5265         * configure: Regenerate.
5266         * top.c (print_gdb_version): plumb --enable-source-highlight
5267         status to "show configuration".
5268
5269 2019-04-19  Tom Tromey  <tromey@adacore.com>
5270
5271         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5272         Check ADA_TYPE_P.
5273         (empty_record, ada_template_to_fixed_record_type_1)
5274         (template_to_static_fixed_type)
5275         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5276         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5277         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5278         macros.
5279
5280 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5281
5282         PR symtab/24423:
5283         * source.c (print_source_lines_base): Advance "iter" when a
5284         control character is seen.
5285
5286 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5287
5288         * inferior.h (struct infcall_suspend_state_deleter):
5289         Catch exception in destructor to avoid crash.
5290
5291 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5292
5293         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5294         close to the add_com "shell".
5295
5296 2019-04-18  Tom Tromey  <tromey@adacore.com>
5297
5298         * process-stratum-target.h (class process_stratum_target)
5299         <stratum>: Add "final".
5300
5301 2019-04-17  Tom Tromey  <tromey@adacore.com>
5302
5303         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5304         against nullptr before use.
5305
5306 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5307
5308         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5309
5310 2019-04-17  Jim Wilson  <jimw@sifive.com>
5311             Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5314         code read might fail, assume 4-byte breakpoint in that case.
5315
5316 2019-04-15  Leszek Swirski  <leszeks@google.com>
5317
5318         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5319         rather than a hand-rolled POD check when checking for forced MEMORY
5320         classification.
5321
5322 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5323
5324         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5325         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5326         function.
5327         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5328         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5329         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5330         declaration.
5331
5332 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5333
5334         * aarch64-linux-nat.c
5335         (aarch64_linux_nat_target::thread_architecture): Add override.
5336         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5337         each VQ.
5338
5339 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5340
5341         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5342
5343 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5346         target types of size 96-bits, add some additional comments, and
5347         check that the builtin type we found was the correct size.
5348
5349 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5350
5351         * utils.c (prompt_for_continue): Don't restore the styling at the
5352         end, as applied_style has the wrong value.  This fixes styling in
5353         long lists of file names that are interrupted by the "Continue?"
5354         prompt.
5355
5356 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5359         * c-lang.c (c_language_defn): Likewise.
5360         (cplus_language_defn): Likewise.
5361         (asm_language_defn): Likewise.
5362         (minimal_language_defn): Likewise.
5363         * d-lang.c (d_language_defn): Likewise.
5364         * f-lang.c (f_language_defn): Likewise.
5365         * go-lang.c (go_language_defn): Likewise.
5366         * language.c (unknown_language_defn): Likewise.
5367         (auto_language_defn): Likewise.
5368         * language.h (struct language_defn): Remove la_magic field.
5369         (LANG_MAGIC): Delete.
5370         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5371         * objc-lang.c (objc_language_defn): Likewise.
5372         * opencl-lang.c (opencl_language_defn): Likewise.
5373         * p-lang.c (pascal_language_defn): Likewise.
5374         * rust-lang.c (rust_language_defn): Likewise.
5375
5376 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5377
5378         * riscv-tdep.c (riscv_type_align): New function.
5379         (riscv_type_alignment): Delete.
5380         (riscv_arg_location): Use 'type_align'.
5381         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5382
5383 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5384
5385         * gdbtypes.c (type_align): A struct with no non-static fields also
5386         has alignment of 1.
5387
5388 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5391         component to 0.
5392         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5393         member.
5394         (riscv_struct_info::analyse): New implementation using new
5395         analyse_inner member function.
5396         (riscv_struct_info::field_offset): New member function.
5397         (riscv_struct_info::m_offsets): New member variable.
5398         (riscv_struct_info::analyse_inner): New private member function,
5399         takes the old implementation of riscv_struct_info::analyse but
5400         extended to track field offsets.
5401         (riscv_call_arg_struct): Update the struct folding special cases
5402         to handle cases where empty C++ structs, which are non-zero
5403         length, are found.
5404         (riscv_arg_location): Initialise the length of each location, a
5405         non-zero length now indicates the location is in use.
5406         (riscv_push_dummy_call): Allow for the first location having a
5407         non-zero offset when setting up arguments.
5408         (riscv_return_value): Likewise, but for return values.
5409
5410 2019-04-11  Tom Tromey  <tromey@adacore.com>
5411
5412         * utils.c (internal_vproblem): Make "msg" const.
5413
5414 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5415
5416         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5417         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5418         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5419         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5420
5421 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5422
5423         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5424         function.
5425         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5426         of amd64_collect_native_gregset.
5427         (amd64_linux_nat_target::store_registers): Likewise.
5428
5429 2019-04-10  Tom Tromey  <tom@tromey.com>
5430
5431         * symtab.c (lookup_global_symbol_from_objfile)
5432         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5433         * objfiles.h (class separate_debug_iterator): New.
5434         (class separate_debug_range): New.
5435         (struct objfile) <separate_debug_objfiles>: New method.
5436         (objfile_separate_debug_iterate): Don't declare.
5437         * objfiles.c (separate_debug_iterator::operator++): Rename from
5438         objfile_separate_debug_iterate.
5439         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5440         iterator.
5441         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5442         iterator.
5443
5444 2019-04-10  Tom Tromey  <tom@tromey.com>
5445
5446         * symfile.c (reread_symbols): Remove old comment.
5447         * objfiles.c (free_all_objfiles): Fix a typo.
5448
5449 2019-04-10  Tom Tromey  <tom@tromey.com>
5450
5451         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5452         * minsyms.c (lookup_minimal_symbol): Use foreach.
5453         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5454         (lookup_minimal_symbol_solib_trampoline): Likewise.
5455         * symfile.c (reread_symbols): Use foreach.
5456
5457 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5458             Tom Tromey  <tromey@adacore.com>
5459
5460         PR rust/24414:
5461         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5462         (rust_lex_int_test): Change "value" to be LONGEST.
5463         (rust_lex_tests): Add test for long integer literal.
5464
5465 2019-04-09  Tom Tromey  <tromey@adacore.com>
5466
5467         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5468         to bool.
5469         (extended_remote_target::attach): Update.
5470         (remote_target::remote_notice_new_inferior): Update.
5471         (remote_target::add_current_inferior_and_thread): Update.
5472         * inferior.c (exit_inferior_1): Use "false".
5473         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5474
5475 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5476
5477         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5478         the "start" command.
5479
5480 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5481
5482         * python/py-inferior.c (infpy_thread_from_thread_handle):
5483         Adjust comments to reflect renaming of thread_from_thread_handle
5484         to thread_from_handle.  Adjust keywords.  Fix type error message.
5485         (inferior_object_methods): Add thread_from_handle.  Retain
5486         thread_from_thread_handle, but mark it as deprecated.
5487
5488 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5489
5490         * gdbthread.h (find_thread_by_handle): Revise declaration.
5491         * thread.c (find_thread_by_handle): Likewise.  Adjust
5492         implementation too.
5493         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5494         support for buffer objects as handles.
5495
5496 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5497
5498         * python/py-infthread.c (thpy_thread_handle): New function.
5499         (thread_object_methods): Register thpy_thread_handle.
5500
5501 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5502
5503         * gdbthread.h (thread_to_thread_handle): Declare.
5504         * thread.c (gdbtypes.h): Include.
5505         (thread_to_thread_handle): New function.
5506
5507         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5508         (target_thread_info_to_thread_handle): Declare.
5509         * target.c (target_thread_info_to_thread_handle): New function.
5510         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5511         * target-delegates.c: Regenerate.
5512
5513         * linux-thread-db.c (class thread_db_target): Add method
5514         thread_info_to_thread_handle.
5515         (thread_db_target::thread_info_to_thread_handle): Define.
5516         * remote.c (class remote_target): Add new method
5517         thread_info_to_thread_handle.
5518         (remote_target::thread_info_to_thread_handle): Define.
5519
5520 2019-04-08  Pedro Alves  <palves@redhat.com>
5521
5522         * common/common-exceptions.c (throw_exception): Don't create
5523         named object to throw; throw directly.
5524         (throw_it): Likewise.  Don't initialize gdb_exception::message
5525         here, with new; pass FMT and AP to the ctor instead.
5526         * common/common-exceptions.h: Include <string>.
5527         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5528         const char *, va_list)): New ctor.  Use std::make_shared.
5529         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5530         errors)): Delete.
5531         (gdb_exception_error::gdb_exception_error(enum errors, const char
5532         *, va_list)): New.
5533         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5534         Add assertion.
5535         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5536         errors)): Delete.
5537         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5538         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5539         Add assertion.
5540
5541 2019-04-08  Tom Tromey  <tom@tromey.com>
5542
5543         * valops.c (value_rtti_indirect_type): Replace throw_exception
5544         with throw.
5545         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5546         with throw.
5547         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5548         throw.
5549         * target.c (target_translate_tls_address): Replace throw_exception
5550         with throw.
5551         * stack.c (frame_apply_command_count): Replace throw_exception
5552         with throw.
5553         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5554         throw.
5555         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5556         with throw.
5557         * rs6000-tdep.c (rs6000_frame_cache)
5558         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5559         * remote.c: Replace throw_exception with throw.
5560         * record-full.c (record_full_message, record_full_wait_1)
5561         (record_full_restore): Replace throw_exception with throw.
5562         * record-btrace.c:
5563         (get_thread_current_frame_id, record_btrace_start_replaying)
5564         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5565         (cmd_record_btrace_start): Replace throw_exception with throw.
5566         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5567         throw.
5568         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5569         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5570         * linespec.c:
5571         (find_linespec_symbols): Replace throw_exception with throw.
5572         * infrun.c (displaced_step_prepare, resume): Replace
5573         throw_exception with throw.
5574         * infcmd.c (post_create_inferior): Replace throw_exception with
5575         throw.
5576         * inf-loop.c (inferior_event_handler): Replace throw_exception
5577         with throw.
5578         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5579         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5580         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5581         (get_prev_frame_always, get_frame_pc_if_available)
5582         (get_frame_address_in_block_if_available, get_frame_language):
5583         Replace throw_exception with throw.
5584         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5585         throw_exception with throw.
5586         * eval.c (fetch_subexp_value, evaluate_var_value)
5587         (evaluate_funcall, evaluate_subexp_standard): Replace
5588         throw_exception with throw.
5589         * dwarf2loc.c (call_site_find_chain)
5590         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5591         Replace throw_exception with throw.
5592         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5593         with throw.
5594         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5595         throw.
5596         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5597         * completer.c (complete_line_internal): Replace throw_exception
5598         with throw.
5599         * compile/compile-object-run.c (compile_object_run): Replace
5600         throw_exception with throw.
5601         * cli/cli-script.c (process_next_line): Replace throw_exception
5602         with throw.
5603         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5604         (btrace_enable, btrace_maint_update_pt_packets): Replace
5605         throw_exception with throw.
5606         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5607         throw_exception with throw.
5608         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5609         throw_exception with throw.
5610         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5611         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5612         * aarch64-tdep.c (aarch64_make_prologue_cache)
5613         (aarch64_make_stub_cache): Replace throw_exception with throw.
5614
5615 2019-04-08  Tom Tromey  <tom@tromey.com>
5616
5617         * common/common-exceptions.c (throw_exception): Rename from
5618         throw_exception_cxx.  Remove old copy.  Make argument const.
5619         (throw_it): Create and throw exception objects directly.
5620         * common/common-exceptions.h (throw_exception): Make argument
5621         const.
5622         (struct gdb_exception_error): Add constructor.
5623         (struct gdb_exception_quit): Add constructor.
5624
5625 2019-04-08  Tom Tromey  <tom@tromey.com>
5626
5627         * common/common-exceptions.h (exception_rethrow): Don't declare.
5628         (TRY_SJLJ): Update comment.
5629         (TRY, CATCH, END_CATCH): Remove.
5630         * common/common-exceptions.c (exception_rethrow): Remove.
5631
5632 2019-04-08  Tom Tromey  <tom@tromey.com>
5633
5634         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5635         Remove.
5636         (gdb_exception_error): Rename from
5637         gdb_exception_RETURN_MASK_ERROR.
5638         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5639         (gdb_quit_bad_alloc): Update.
5640         * aarch64-tdep.c: Update.
5641         * ada-lang.c: Update.
5642         * ada-typeprint.c: Update.
5643         * ada-valprint.c: Update.
5644         * amd64-tdep.c: Update.
5645         * arch-utils.c: Update.
5646         * break-catch-throw.c: Update.
5647         * breakpoint.c: Update.
5648         * btrace.c: Update.
5649         * c-varobj.c: Update.
5650         * cli/cli-cmds.c: Update.
5651         * cli/cli-interp.c: Update.
5652         * cli/cli-script.c: Update.
5653         * common/common-exceptions.c: Update.
5654         * common/new-op.c: Update.
5655         * common/selftest.c: Update.
5656         * compile/compile-c-symbols.c: Update.
5657         * compile/compile-cplus-symbols.c: Update.
5658         * compile/compile-object-load.c: Update.
5659         * compile/compile-object-run.c: Update.
5660         * completer.c: Update.
5661         * corelow.c: Update.
5662         * cp-abi.c: Update.
5663         * cp-support.c: Update.
5664         * cp-valprint.c: Update.
5665         * darwin-nat.c: Update.
5666         * disasm-selftests.c: Update.
5667         * dtrace-probe.c: Update.
5668         * dwarf-index-cache.c: Update.
5669         * dwarf-index-write.c: Update.
5670         * dwarf2-frame-tailcall.c: Update.
5671         * dwarf2-frame.c: Update.
5672         * dwarf2loc.c: Update.
5673         * dwarf2read.c: Update.
5674         * eval.c: Update.
5675         * event-loop.c: Update.
5676         * event-top.c: Update.
5677         * exec.c: Update.
5678         * f-valprint.c: Update.
5679         * fbsd-tdep.c: Update.
5680         * frame-unwind.c: Update.
5681         * frame.c: Update.
5682         * gdbtypes.c: Update.
5683         * gnu-v3-abi.c: Update.
5684         * guile/guile-internal.h: Update.
5685         * guile/scm-block.c: Update.
5686         * guile/scm-breakpoint.c: Update.
5687         * guile/scm-cmd.c: Update.
5688         * guile/scm-disasm.c: Update.
5689         * guile/scm-frame.c: Update.
5690         * guile/scm-lazy-string.c: Update.
5691         * guile/scm-math.c: Update.
5692         * guile/scm-param.c: Update.
5693         * guile/scm-ports.c: Update.
5694         * guile/scm-pretty-print.c: Update.
5695         * guile/scm-symbol.c: Update.
5696         * guile/scm-symtab.c: Update.
5697         * guile/scm-type.c: Update.
5698         * guile/scm-value.c: Update.
5699         * i386-linux-tdep.c: Update.
5700         * i386-tdep.c: Update.
5701         * inf-loop.c: Update.
5702         * infcall.c: Update.
5703         * infcmd.c: Update.
5704         * infrun.c: Update.
5705         * jit.c: Update.
5706         * language.c: Update.
5707         * linespec.c: Update.
5708         * linux-fork.c: Update.
5709         * linux-nat.c: Update.
5710         * linux-tdep.c: Update.
5711         * linux-thread-db.c: Update.
5712         * main.c: Update.
5713         * mi/mi-cmd-break.c: Update.
5714         * mi/mi-cmd-stack.c: Update.
5715         * mi/mi-interp.c: Update.
5716         * mi/mi-main.c: Update.
5717         * objc-lang.c: Update.
5718         * p-valprint.c: Update.
5719         * parse.c: Update.
5720         * ppc-linux-tdep.c: Update.
5721         * printcmd.c: Update.
5722         * python/py-arch.c: Update.
5723         * python/py-breakpoint.c: Update.
5724         * python/py-cmd.c: Update.
5725         * python/py-finishbreakpoint.c: Update.
5726         * python/py-frame.c: Update.
5727         * python/py-framefilter.c: Update.
5728         * python/py-gdb-readline.c: Update.
5729         * python/py-inferior.c: Update.
5730         * python/py-infthread.c: Update.
5731         * python/py-lazy-string.c: Update.
5732         * python/py-linetable.c: Update.
5733         * python/py-objfile.c: Update.
5734         * python/py-param.c: Update.
5735         * python/py-prettyprint.c: Update.
5736         * python/py-progspace.c: Update.
5737         * python/py-record-btrace.c: Update.
5738         * python/py-record.c: Update.
5739         * python/py-symbol.c: Update.
5740         * python/py-type.c: Update.
5741         * python/py-unwind.c: Update.
5742         * python/py-utils.c: Update.
5743         * python/py-value.c: Update.
5744         * python/python.c: Update.
5745         * record-btrace.c: Update.
5746         * record-full.c: Update.
5747         * remote-fileio.c: Update.
5748         * remote.c: Update.
5749         * riscv-tdep.c: Update.
5750         * rs6000-aix-tdep.c: Update.
5751         * rs6000-tdep.c: Update.
5752         * rust-exp.y: Update.
5753         * rust-lang.c: Update.
5754         * s390-tdep.c: Update.
5755         * selftest-arch.c: Update.
5756         * solib-dsbt.c: Update.
5757         * solib-frv.c: Update.
5758         * solib-spu.c: Update.
5759         * solib-svr4.c: Update.
5760         * solib.c: Update.
5761         * sparc64-linux-tdep.c: Update.
5762         * stack.c: Update.
5763         * symfile-mem.c: Update.
5764         * symmisc.c: Update.
5765         * target.c: Update.
5766         * thread.c: Update.
5767         * top.c: Update.
5768         * tracefile-tfile.c: Update.
5769         * tui/tui.c: Update.
5770         * typeprint.c: Update.
5771         * unittests/cli-utils-selftests.c: Update.
5772         * unittests/parse-connection-spec-selftests.c: Update.
5773         * valops.c: Update.
5774         * valprint.c: Update.
5775         * value.c: Update.
5776         * varobj.c: Update.
5777         * windows-nat.c: Update.
5778         * x86-linux-nat.c: Update.
5779         * xml-support.c: Update.
5780
5781 2019-04-08  Tom Tromey  <tom@tromey.com>
5782
5783         * xml-support.c: Use C++ exception handling.
5784         * x86-linux-nat.c: Use C++ exception handling.
5785         * windows-nat.c: Use C++ exception handling.
5786         * varobj.c: Use C++ exception handling.
5787         * value.c: Use C++ exception handling.
5788         * valprint.c: Use C++ exception handling.
5789         * valops.c: Use C++ exception handling.
5790         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5791         handling.
5792         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5793         * typeprint.c: Use C++ exception handling.
5794         * tui/tui.c: Use C++ exception handling.
5795         * tracefile-tfile.c: Use C++ exception handling.
5796         * top.c: Use C++ exception handling.
5797         * thread.c: Use C++ exception handling.
5798         * target.c: Use C++ exception handling.
5799         * symmisc.c: Use C++ exception handling.
5800         * symfile-mem.c: Use C++ exception handling.
5801         * stack.c: Use C++ exception handling.
5802         * sparc64-linux-tdep.c: Use C++ exception handling.
5803         * solib.c: Use C++ exception handling.
5804         * solib-svr4.c: Use C++ exception handling.
5805         * solib-spu.c: Use C++ exception handling.
5806         * solib-frv.c: Use C++ exception handling.
5807         * solib-dsbt.c: Use C++ exception handling.
5808         * selftest-arch.c: Use C++ exception handling.
5809         * s390-tdep.c: Use C++ exception handling.
5810         * rust-lang.c: Use C++ exception handling.
5811         * rust-exp.y: Use C++ exception handling.
5812         * rs6000-tdep.c: Use C++ exception handling.
5813         * rs6000-aix-tdep.c: Use C++ exception handling.
5814         * riscv-tdep.c: Use C++ exception handling.
5815         * remote.c: Use C++ exception handling.
5816         * remote-fileio.c: Use C++ exception handling.
5817         * record-full.c: Use C++ exception handling.
5818         * record-btrace.c: Use C++ exception handling.
5819         * python/python.c: Use C++ exception handling.
5820         * python/py-value.c: Use C++ exception handling.
5821         * python/py-utils.c: Use C++ exception handling.
5822         * python/py-unwind.c: Use C++ exception handling.
5823         * python/py-type.c: Use C++ exception handling.
5824         * python/py-symbol.c: Use C++ exception handling.
5825         * python/py-record.c: Use C++ exception handling.
5826         * python/py-record-btrace.c: Use C++ exception handling.
5827         * python/py-progspace.c: Use C++ exception handling.
5828         * python/py-prettyprint.c: Use C++ exception handling.
5829         * python/py-param.c: Use C++ exception handling.
5830         * python/py-objfile.c: Use C++ exception handling.
5831         * python/py-linetable.c: Use C++ exception handling.
5832         * python/py-lazy-string.c: Use C++ exception handling.
5833         * python/py-infthread.c: Use C++ exception handling.
5834         * python/py-inferior.c: Use C++ exception handling.
5835         * python/py-gdb-readline.c: Use C++ exception handling.
5836         * python/py-framefilter.c: Use C++ exception handling.
5837         * python/py-frame.c: Use C++ exception handling.
5838         * python/py-finishbreakpoint.c: Use C++ exception handling.
5839         * python/py-cmd.c: Use C++ exception handling.
5840         * python/py-breakpoint.c: Use C++ exception handling.
5841         * python/py-arch.c: Use C++ exception handling.
5842         * printcmd.c: Use C++ exception handling.
5843         * ppc-linux-tdep.c: Use C++ exception handling.
5844         * parse.c: Use C++ exception handling.
5845         * p-valprint.c: Use C++ exception handling.
5846         * objc-lang.c: Use C++ exception handling.
5847         * mi/mi-main.c: Use C++ exception handling.
5848         * mi/mi-interp.c: Use C++ exception handling.
5849         * mi/mi-cmd-stack.c: Use C++ exception handling.
5850         * mi/mi-cmd-break.c: Use C++ exception handling.
5851         * main.c: Use C++ exception handling.
5852         * linux-thread-db.c: Use C++ exception handling.
5853         * linux-tdep.c: Use C++ exception handling.
5854         * linux-nat.c: Use C++ exception handling.
5855         * linux-fork.c: Use C++ exception handling.
5856         * linespec.c: Use C++ exception handling.
5857         * language.c: Use C++ exception handling.
5858         * jit.c: Use C++ exception handling.
5859         * infrun.c: Use C++ exception handling.
5860         * infcmd.c: Use C++ exception handling.
5861         * infcall.c: Use C++ exception handling.
5862         * inf-loop.c: Use C++ exception handling.
5863         * i386-tdep.c: Use C++ exception handling.
5864         * i386-linux-tdep.c: Use C++ exception handling.
5865         * guile/scm-value.c: Use C++ exception handling.
5866         * guile/scm-type.c: Use C++ exception handling.
5867         * guile/scm-symtab.c: Use C++ exception handling.
5868         * guile/scm-symbol.c: Use C++ exception handling.
5869         * guile/scm-pretty-print.c: Use C++ exception handling.
5870         * guile/scm-ports.c: Use C++ exception handling.
5871         * guile/scm-param.c: Use C++ exception handling.
5872         * guile/scm-math.c: Use C++ exception handling.
5873         * guile/scm-lazy-string.c: Use C++ exception handling.
5874         * guile/scm-frame.c: Use C++ exception handling.
5875         * guile/scm-disasm.c: Use C++ exception handling.
5876         * guile/scm-cmd.c: Use C++ exception handling.
5877         * guile/scm-breakpoint.c: Use C++ exception handling.
5878         * guile/scm-block.c: Use C++ exception handling.
5879         * guile/guile-internal.h: Use C++ exception handling.
5880         * gnu-v3-abi.c: Use C++ exception handling.
5881         * gdbtypes.c: Use C++ exception handling.
5882         * frame.c: Use C++ exception handling.
5883         * frame-unwind.c: Use C++ exception handling.
5884         * fbsd-tdep.c: Use C++ exception handling.
5885         * f-valprint.c: Use C++ exception handling.
5886         * exec.c: Use C++ exception handling.
5887         * event-top.c: Use C++ exception handling.
5888         * event-loop.c: Use C++ exception handling.
5889         * eval.c: Use C++ exception handling.
5890         * dwarf2read.c: Use C++ exception handling.
5891         * dwarf2loc.c: Use C++ exception handling.
5892         * dwarf2-frame.c: Use C++ exception handling.
5893         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5894         * dwarf-index-write.c: Use C++ exception handling.
5895         * dwarf-index-cache.c: Use C++ exception handling.
5896         * dtrace-probe.c: Use C++ exception handling.
5897         * disasm-selftests.c: Use C++ exception handling.
5898         * darwin-nat.c: Use C++ exception handling.
5899         * cp-valprint.c: Use C++ exception handling.
5900         * cp-support.c: Use C++ exception handling.
5901         * cp-abi.c: Use C++ exception handling.
5902         * corelow.c: Use C++ exception handling.
5903         * completer.c: Use C++ exception handling.
5904         * compile/compile-object-run.c: Use C++ exception handling.
5905         * compile/compile-object-load.c: Use C++ exception handling.
5906         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5907         * compile/compile-c-symbols.c: Use C++ exception handling.
5908         * common/selftest.c: Use C++ exception handling.
5909         * common/new-op.c: Use C++ exception handling.
5910         * cli/cli-script.c: Use C++ exception handling.
5911         * cli/cli-interp.c: Use C++ exception handling.
5912         * cli/cli-cmds.c: Use C++ exception handling.
5913         * c-varobj.c: Use C++ exception handling.
5914         * btrace.c: Use C++ exception handling.
5915         * breakpoint.c: Use C++ exception handling.
5916         * break-catch-throw.c: Use C++ exception handling.
5917         * arch-utils.c: Use C++ exception handling.
5918         * amd64-tdep.c: Use C++ exception handling.
5919         * ada-valprint.c: Use C++ exception handling.
5920         * ada-typeprint.c: Use C++ exception handling.
5921         * ada-lang.c: Use C++ exception handling.
5922         * aarch64-tdep.c: Use C++ exception handling.
5923
5924 2019-04-08  Tom Tromey  <tom@tromey.com>
5925
5926         * xml-support.c (gdb_xml_parser::parse): Update.
5927         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5928         * value.c (show_convenience): Update.
5929         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5930         (test_parse_flags_qcs): Update.
5931         * thread.c (thr_try_catch_cmd): Update.
5932         * target.c (target_translate_tls_address): Update.
5933         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5934         (info_frame_command_core, frame_apply_command_count): Update.
5935         * rust-exp.y (rust_lex_exception_test): Update.
5936         * riscv-tdep.c (riscv_print_one_register_info): Update.
5937         * remote.c (remote_target::enable_btrace): Update.
5938         * record-btrace.c (record_btrace_enable_warn): Update.
5939         * python/py-utils.c (gdbpy_convert_exception): Update.
5940         * printcmd.c (do_one_display, print_variable_and_value): Update.
5941         * mi/mi-main.c (mi_print_exception): Update.
5942         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5943         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5944         * linux-nat.c (linux_nat_target::attach): Update.
5945         * linux-fork.c (class scoped_switch_fork_info): Update.
5946         * infrun.c (displaced_step_prepare): Update.
5947         * infcall.c (call_function_by_hand_dummy): Update.
5948         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5949         * gnu-v3-abi.c (print_one_vtable): Update.
5950         * frame.c (get_prev_frame_always): Update.
5951         * f-valprint.c (info_common_command_for_block): Update.
5952         * exec.c (try_open_exec_file): Update.
5953         * exceptions.c (print_exception, exception_print)
5954         (exception_fprintf, exception_print_same): Update.
5955         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5956         * dwarf-index-cache.c (index_cache::store)
5957         (index_cache::lookup_gdb_index): Update.
5958         * darwin-nat.c (maybe_cache_shell): Update.
5959         * cp-valprint.c (cp_print_value_fields): Update.
5960         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5961         (gcc_cplus_symbol_address): Update.
5962         * compile/compile-c-symbols.c (gcc_convert_symbol)
5963         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5964         * common/selftest.c: Update.
5965         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5966         a std::string.
5967         (exception_try_scope_entry, exception_try_scope_exit): Don't
5968         declare.
5969         (struct exception_try_scope): Remove.
5970         (TRY): Don't use exception_try_scope.
5971         (struct gdb_exception): Add constructor, operator=.
5972         <what>: New method.
5973         (struct gdb_exception_RETURN_MASK_ALL)
5974         (struct gdb_exception_RETURN_MASK_ERROR)
5975         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5976         (struct gdb_quit_bad_alloc): Update.
5977         * common/common-exceptions.c (exception_none): Change
5978         initializer.
5979         (struct catcher) <state, exception>: Initialize inline.
5980         <prev>: Remove member.
5981         (current_catcher): Remove.
5982         (catchers): New global.
5983         (exceptions_state_mc_init): Simplify.
5984         (catcher_pop): Remove.
5985         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5986         (try_scope_depth, exception_try_scope_entry)
5987         (exception_try_scope_exit): Remove.
5988         (throw_exception_sjlj): Update.
5989         (exception_messages, exception_messages_size): Remove.
5990         (throw_it): Simplify.
5991         (gdb_exception_sliced_copy): Remove.
5992         (throw_exception_cxx): Update.
5993         * cli/cli-script.c (script_from_file): Update.
5994         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5995         Update.
5996         * ada-valprint.c (ada_val_print): Update.
5997         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5998         (create_excep_cond_exprs): Update.
5999
6000 2019-04-08  Tom Tromey  <tom@tromey.com>
6001
6002         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6003         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6004         (TRY, CATCH, END_CATCH): Remove some definitions.
6005         * common/common-exceptions.c: Don't use GDB_XCPT.
6006         (catcher_list_size): Remove.
6007         (throw_exception, throw_it): Simplify.
6008
6009 2019-04-05  Tom Tromey  <tom@tromey.com>
6010
6011         Revert the header-sorting patch.
6012         * ft32-tdep.c: Revert.
6013         * frv-tdep.c: Revert.
6014         * frv-linux-tdep.c: Revert.
6015         * frame.c: Revert.
6016         * frame-unwind.c: Revert.
6017         * frame-base.c: Revert.
6018         * fork-child.c: Revert.
6019         * findvar.c: Revert.
6020         * findcmd.c: Revert.
6021         * filesystem.c: Revert.
6022         * filename-seen-cache.h: Revert.
6023         * filename-seen-cache.c: Revert.
6024         * fbsd-tdep.c: Revert.
6025         * fbsd-nat.h: Revert.
6026         * fbsd-nat.c: Revert.
6027         * f-valprint.c: Revert.
6028         * f-typeprint.c: Revert.
6029         * f-lang.c: Revert.
6030         * extension.h: Revert.
6031         * extension.c: Revert.
6032         * extension-priv.h: Revert.
6033         * expprint.c: Revert.
6034         * exec.h: Revert.
6035         * exec.c: Revert.
6036         * exceptions.c: Revert.
6037         * event-top.c: Revert.
6038         * event-loop.c: Revert.
6039         * eval.c: Revert.
6040         * elfread.c: Revert.
6041         * dwarf2read.h: Revert.
6042         * dwarf2read.c: Revert.
6043         * dwarf2loc.c: Revert.
6044         * dwarf2expr.h: Revert.
6045         * dwarf2expr.c: Revert.
6046         * dwarf2-frame.c: Revert.
6047         * dwarf2-frame-tailcall.c: Revert.
6048         * dwarf-index-write.h: Revert.
6049         * dwarf-index-write.c: Revert.
6050         * dwarf-index-common.c: Revert.
6051         * dwarf-index-cache.h: Revert.
6052         * dwarf-index-cache.c: Revert.
6053         * dummy-frame.c: Revert.
6054         * dtrace-probe.c: Revert.
6055         * disasm.h: Revert.
6056         * disasm.c: Revert.
6057         * disasm-selftests.c: Revert.
6058         * dictionary.c: Revert.
6059         * dicos-tdep.c: Revert.
6060         * demangle.c: Revert.
6061         * dcache.h: Revert.
6062         * dcache.c: Revert.
6063         * darwin-nat.h: Revert.
6064         * darwin-nat.c: Revert.
6065         * darwin-nat-info.c: Revert.
6066         * d-valprint.c: Revert.
6067         * d-namespace.c: Revert.
6068         * d-lang.c: Revert.
6069         * ctf.c: Revert.
6070         * csky-tdep.c: Revert.
6071         * csky-linux-tdep.c: Revert.
6072         * cris-tdep.c: Revert.
6073         * cris-linux-tdep.c: Revert.
6074         * cp-valprint.c: Revert.
6075         * cp-support.c: Revert.
6076         * cp-namespace.c: Revert.
6077         * cp-abi.c: Revert.
6078         * corelow.c: Revert.
6079         * corefile.c: Revert.
6080         * continuations.c: Revert.
6081         * completer.h: Revert.
6082         * completer.c: Revert.
6083         * complaints.c: Revert.
6084         * coffread.c: Revert.
6085         * coff-pe-read.c: Revert.
6086         * cli-out.h: Revert.
6087         * cli-out.c: Revert.
6088         * charset.c: Revert.
6089         * c-varobj.c: Revert.
6090         * c-valprint.c: Revert.
6091         * c-typeprint.c: Revert.
6092         * c-lang.c: Revert.
6093         * buildsym.c: Revert.
6094         * buildsym-legacy.c: Revert.
6095         * build-id.h: Revert.
6096         * build-id.c: Revert.
6097         * btrace.c: Revert.
6098         * bsd-uthread.c: Revert.
6099         * breakpoint.h: Revert.
6100         * breakpoint.c: Revert.
6101         * break-catch-throw.c: Revert.
6102         * break-catch-syscall.c: Revert.
6103         * break-catch-sig.c: Revert.
6104         * blockframe.c: Revert.
6105         * block.c: Revert.
6106         * bfin-tdep.c: Revert.
6107         * bfin-linux-tdep.c: Revert.
6108         * bfd-target.c: Revert.
6109         * bcache.c: Revert.
6110         * ax-general.c: Revert.
6111         * ax-gdb.h: Revert.
6112         * ax-gdb.c: Revert.
6113         * avr-tdep.c: Revert.
6114         * auxv.c: Revert.
6115         * auto-load.c: Revert.
6116         * arm-wince-tdep.c: Revert.
6117         * arm-tdep.c: Revert.
6118         * arm-symbian-tdep.c: Revert.
6119         * arm-pikeos-tdep.c: Revert.
6120         * arm-obsd-tdep.c: Revert.
6121         * arm-nbsd-tdep.c: Revert.
6122         * arm-nbsd-nat.c: Revert.
6123         * arm-linux-tdep.c: Revert.
6124         * arm-linux-nat.c: Revert.
6125         * arm-fbsd-tdep.c: Revert.
6126         * arm-fbsd-nat.c: Revert.
6127         * arm-bsd-tdep.c: Revert.
6128         * arch-utils.c: Revert.
6129         * arc-tdep.c: Revert.
6130         * arc-newlib-tdep.c: Revert.
6131         * annotate.h: Revert.
6132         * annotate.c: Revert.
6133         * amd64-windows-tdep.c: Revert.
6134         * amd64-windows-nat.c: Revert.
6135         * amd64-tdep.c: Revert.
6136         * amd64-sol2-tdep.c: Revert.
6137         * amd64-obsd-tdep.c: Revert.
6138         * amd64-obsd-nat.c: Revert.
6139         * amd64-nbsd-tdep.c: Revert.
6140         * amd64-nbsd-nat.c: Revert.
6141         * amd64-nat.c: Revert.
6142         * amd64-linux-tdep.c: Revert.
6143         * amd64-linux-nat.c: Revert.
6144         * amd64-fbsd-tdep.c: Revert.
6145         * amd64-fbsd-nat.c: Revert.
6146         * amd64-dicos-tdep.c: Revert.
6147         * amd64-darwin-tdep.c: Revert.
6148         * amd64-bsd-nat.c: Revert.
6149         * alpha-tdep.c: Revert.
6150         * alpha-obsd-tdep.c: Revert.
6151         * alpha-nbsd-tdep.c: Revert.
6152         * alpha-mdebug-tdep.c: Revert.
6153         * alpha-linux-tdep.c: Revert.
6154         * alpha-linux-nat.c: Revert.
6155         * alpha-bsd-tdep.c: Revert.
6156         * alpha-bsd-nat.c: Revert.
6157         * aix-thread.c: Revert.
6158         * agent.c: Revert.
6159         * addrmap.c: Revert.
6160         * ada-varobj.c: Revert.
6161         * ada-valprint.c: Revert.
6162         * ada-typeprint.c: Revert.
6163         * ada-tasks.c: Revert.
6164         * ada-lang.c: Revert.
6165         * aarch64-tdep.c: Revert.
6166         * aarch64-ravenscar-thread.c: Revert.
6167         * aarch64-newlib-tdep.c: Revert.
6168         * aarch64-linux-tdep.c: Revert.
6169         * aarch64-linux-nat.c: Revert.
6170         * aarch64-fbsd-tdep.c: Revert.
6171         * aarch64-fbsd-nat.c: Revert.
6172         * aarch32-linux-nat.c: Revert.
6173
6174 2019-04-05  Tom Tromey  <tom@tromey.com>
6175
6176         * ft32-tdep.c: Sort headers.
6177         * frv-tdep.c: Sort headers.
6178         * frv-linux-tdep.c: Sort headers.
6179         * frame.c: Sort headers.
6180         * frame-unwind.c: Sort headers.
6181         * frame-base.c: Sort headers.
6182         * fork-child.c: Sort headers.
6183         * findvar.c: Sort headers.
6184         * findcmd.c: Sort headers.
6185         * filesystem.c: Sort headers.
6186         * filename-seen-cache.h: Sort headers.
6187         * filename-seen-cache.c: Sort headers.
6188         * fbsd-tdep.c: Sort headers.
6189         * fbsd-nat.h: Sort headers.
6190         * fbsd-nat.c: Sort headers.
6191         * f-valprint.c: Sort headers.
6192         * f-typeprint.c: Sort headers.
6193         * f-lang.c: Sort headers.
6194         * extension.h: Sort headers.
6195         * extension.c: Sort headers.
6196         * extension-priv.h: Sort headers.
6197         * expprint.c: Sort headers.
6198         * exec.h: Sort headers.
6199         * exec.c: Sort headers.
6200         * exceptions.c: Sort headers.
6201         * event-top.c: Sort headers.
6202         * event-loop.c: Sort headers.
6203         * eval.c: Sort headers.
6204         * elfread.c: Sort headers.
6205         * dwarf2read.h: Sort headers.
6206         * dwarf2read.c: Sort headers.
6207         * dwarf2loc.c: Sort headers.
6208         * dwarf2expr.h: Sort headers.
6209         * dwarf2expr.c: Sort headers.
6210         * dwarf2-frame.c: Sort headers.
6211         * dwarf2-frame-tailcall.c: Sort headers.
6212         * dwarf-index-write.h: Sort headers.
6213         * dwarf-index-write.c: Sort headers.
6214         * dwarf-index-common.c: Sort headers.
6215         * dwarf-index-cache.h: Sort headers.
6216         * dwarf-index-cache.c: Sort headers.
6217         * dummy-frame.c: Sort headers.
6218         * dtrace-probe.c: Sort headers.
6219         * disasm.h: Sort headers.
6220         * disasm.c: Sort headers.
6221         * disasm-selftests.c: Sort headers.
6222         * dictionary.c: Sort headers.
6223         * dicos-tdep.c: Sort headers.
6224         * demangle.c: Sort headers.
6225         * dcache.h: Sort headers.
6226         * dcache.c: Sort headers.
6227         * darwin-nat.h: Sort headers.
6228         * darwin-nat.c: Sort headers.
6229         * darwin-nat-info.c: Sort headers.
6230         * d-valprint.c: Sort headers.
6231         * d-namespace.c: Sort headers.
6232         * d-lang.c: Sort headers.
6233         * ctf.c: Sort headers.
6234         * csky-tdep.c: Sort headers.
6235         * csky-linux-tdep.c: Sort headers.
6236         * cris-tdep.c: Sort headers.
6237         * cris-linux-tdep.c: Sort headers.
6238         * cp-valprint.c: Sort headers.
6239         * cp-support.c: Sort headers.
6240         * cp-namespace.c: Sort headers.
6241         * cp-abi.c: Sort headers.
6242         * corelow.c: Sort headers.
6243         * corefile.c: Sort headers.
6244         * continuations.c: Sort headers.
6245         * completer.h: Sort headers.
6246         * completer.c: Sort headers.
6247         * complaints.c: Sort headers.
6248         * coffread.c: Sort headers.
6249         * coff-pe-read.c: Sort headers.
6250         * cli-out.h: Sort headers.
6251         * cli-out.c: Sort headers.
6252         * charset.c: Sort headers.
6253         * c-varobj.c: Sort headers.
6254         * c-valprint.c: Sort headers.
6255         * c-typeprint.c: Sort headers.
6256         * c-lang.c: Sort headers.
6257         * buildsym.c: Sort headers.
6258         * buildsym-legacy.c: Sort headers.
6259         * build-id.h: Sort headers.
6260         * build-id.c: Sort headers.
6261         * btrace.c: Sort headers.
6262         * bsd-uthread.c: Sort headers.
6263         * breakpoint.h: Sort headers.
6264         * breakpoint.c: Sort headers.
6265         * break-catch-throw.c: Sort headers.
6266         * break-catch-syscall.c: Sort headers.
6267         * break-catch-sig.c: Sort headers.
6268         * blockframe.c: Sort headers.
6269         * block.c: Sort headers.
6270         * bfin-tdep.c: Sort headers.
6271         * bfin-linux-tdep.c: Sort headers.
6272         * bfd-target.c: Sort headers.
6273         * bcache.c: Sort headers.
6274         * ax-general.c: Sort headers.
6275         * ax-gdb.h: Sort headers.
6276         * ax-gdb.c: Sort headers.
6277         * avr-tdep.c: Sort headers.
6278         * auxv.c: Sort headers.
6279         * auto-load.c: Sort headers.
6280         * arm-wince-tdep.c: Sort headers.
6281         * arm-tdep.c: Sort headers.
6282         * arm-symbian-tdep.c: Sort headers.
6283         * arm-pikeos-tdep.c: Sort headers.
6284         * arm-obsd-tdep.c: Sort headers.
6285         * arm-nbsd-tdep.c: Sort headers.
6286         * arm-nbsd-nat.c: Sort headers.
6287         * arm-linux-tdep.c: Sort headers.
6288         * arm-linux-nat.c: Sort headers.
6289         * arm-fbsd-tdep.c: Sort headers.
6290         * arm-fbsd-nat.c: Sort headers.
6291         * arm-bsd-tdep.c: Sort headers.
6292         * arch-utils.c: Sort headers.
6293         * arc-tdep.c: Sort headers.
6294         * arc-newlib-tdep.c: Sort headers.
6295         * annotate.h: Sort headers.
6296         * annotate.c: Sort headers.
6297         * amd64-windows-tdep.c: Sort headers.
6298         * amd64-windows-nat.c: Sort headers.
6299         * amd64-tdep.c: Sort headers.
6300         * amd64-sol2-tdep.c: Sort headers.
6301         * amd64-obsd-tdep.c: Sort headers.
6302         * amd64-obsd-nat.c: Sort headers.
6303         * amd64-nbsd-tdep.c: Sort headers.
6304         * amd64-nbsd-nat.c: Sort headers.
6305         * amd64-nat.c: Sort headers.
6306         * amd64-linux-tdep.c: Sort headers.
6307         * amd64-linux-nat.c: Sort headers.
6308         * amd64-fbsd-tdep.c: Sort headers.
6309         * amd64-fbsd-nat.c: Sort headers.
6310         * amd64-dicos-tdep.c: Sort headers.
6311         * amd64-darwin-tdep.c: Sort headers.
6312         * amd64-bsd-nat.c: Sort headers.
6313         * alpha-tdep.c: Sort headers.
6314         * alpha-obsd-tdep.c: Sort headers.
6315         * alpha-nbsd-tdep.c: Sort headers.
6316         * alpha-mdebug-tdep.c: Sort headers.
6317         * alpha-linux-tdep.c: Sort headers.
6318         * alpha-linux-nat.c: Sort headers.
6319         * alpha-bsd-tdep.c: Sort headers.
6320         * alpha-bsd-nat.c: Sort headers.
6321         * aix-thread.c: Sort headers.
6322         * agent.c: Sort headers.
6323         * addrmap.c: Sort headers.
6324         * ada-varobj.c: Sort headers.
6325         * ada-valprint.c: Sort headers.
6326         * ada-typeprint.c: Sort headers.
6327         * ada-tasks.c: Sort headers.
6328         * ada-lang.c: Sort headers.
6329         * aarch64-tdep.c: Sort headers.
6330         * aarch64-ravenscar-thread.c: Sort headers.
6331         * aarch64-newlib-tdep.c: Sort headers.
6332         * aarch64-linux-tdep.c: Sort headers.
6333         * aarch64-linux-nat.c: Sort headers.
6334         * aarch64-fbsd-tdep.c: Sort headers.
6335         * aarch64-fbsd-nat.c: Sort headers.
6336         * aarch32-linux-nat.c: Sort headers.
6337
6338 2019-04-04  Tom Tromey  <tom@tromey.com>
6339
6340         * varobj.c (varobj_create): Update.
6341         * rust-exp.y (struct rust_parser) <update_innermost_block,
6342         lookup_symbol>: New methods.
6343         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6344         Rename.
6345         (rust_parser::rust_lookup_type)
6346         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6347         * printcmd.c (display_command, do_one_display): Update.
6348         * parser-defs.h (struct parser_state) <parser_state>: Add
6349         "tracker" parameter.
6350         (block_tracker): New member.
6351         (class innermost_block_tracker) <innermost_block_tracker>: Add
6352         "types" parameter.
6353         <reset>: Remove method.
6354         (innermost_block): Don't declare.
6355         (null_post_parser): Update.
6356         * parse.c (innermost_block): Remove global.
6357         (write_dollar_variable): Update.
6358         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6359         Remove "tracker_types" parameter.
6360         (parse_expression): Add "tracker" parameter.
6361         (parse_expression_for_completion): Update.
6362         (null_post_parser): Add "tracker" parameter.
6363         * p-exp.y: Update rules.
6364         * m2-exp.y: Update rules.
6365         * language.h (struct language_defn) <la_post_parser>: Add
6366         "tracker" parameter.
6367         * go-exp.y: Update rules.
6368         * f-exp.y: Update rules.
6369         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6370         parameter.
6371         * d-exp.y: Update rules.
6372         * c-exp.y: Update rules.
6373         * breakpoint.c (set_breakpoint_condition): Create an
6374         innermost_block_tracker.
6375         (watch_command_1): Likewise.
6376         * ada-lang.c (resolve): Add "tracker" parameter.
6377         (resolve_subexp): Likewise.
6378         * ada-exp.y (write_var_from_sym): Update.
6379
6380 2019-04-04  Tom Tromey  <tom@tromey.com>
6381
6382         * type-stack.h: New file.
6383         * type-stack.c: New file.
6384         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6385         type-stack.h.
6386         (insert_into_type_stack, insert_type, push_type, push_type_int)
6387         (insert_type_address_space, pop_type, pop_type_int)
6388         (pop_typelist, pop_type_stack, append_type_stack)
6389         (push_type_stack, get_type_stack, push_typelist)
6390         (follow_type_instance_flags, follow_types): Don't declare.
6391         * parse.c (type_stack): Remove global.
6392         (parse_exp_in_context): Update.
6393         (insert_into_type_stack, insert_type, push_type, push_type_int)
6394         (insert_type_address_space, pop_type, pop_type_int)
6395         (pop_typelist, pop_type_stack, append_type_stack)
6396         (push_type_stack, get_type_stack, push_typelist)
6397         (follow_type_instance_flags, follow_types): Remove (moved to
6398         type-stack.c).
6399         * f-exp.y (type_stack): New global.
6400         Update rules.
6401         (push_kind_type, f_parse): Update.
6402         * d-exp.y (type_stack): New global.
6403         Update rules.
6404         (d_parse): Update.
6405         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6406         Update rules.
6407         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6408         (HFILES_NO_SRCDIR): Add type-stack.h.
6409
6410 2019-04-04  Tom Tromey  <tom@tromey.com>
6411
6412         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6413         (rust_parser::convert_ast_to_expression, rust_parse)
6414         (rust_lex_test_completion, rust_lex_tests): Update.
6415         * parser-defs.h (struct expr_completion_state): New.
6416         (struct parser_state) <parser_state>: Add completion parameter.
6417         <mark_struct_expression, mark_completion_tag>: New methods.
6418         <parse_completion, m_completion_state>: New members.
6419         (prefixify_expression, null_post_parser): Update.
6420         (mark_struct_expression, mark_completion_tag): Don't declare.
6421         * parse.c (parse_completion, expout_last_struct)
6422         (expout_tag_completion_type, expout_completion_name): Remove
6423         globals.
6424         (parser_state::mark_struct_expression)
6425         (parser_state::mark_completion_tag): Now methods.
6426         (prefixify_expression): Add last_struct parameter.
6427         (prefixify_subexp): Likewise.
6428         (parse_exp_1): Update.
6429         (parse_exp_in_context): Add cstate parameter.  Update.
6430         (parse_expression_for_completion): Create an
6431         expr_completion_state.
6432         (null_post_parser): Add "completion" parameter.
6433         * p-exp.y: Update rules.
6434         (yylex): Update.
6435         * language.h (struct language_defn) <la_post_parser>: Add
6436         "completing" parameter.
6437         * go-exp.y: Update rules.
6438         (lex_one_token): Update.
6439         * expression.h (parse_completion): Don't declare.
6440         * d-exp.y: Update rules.
6441         (lex_one_token): Update rules.
6442         * c-exp.y: Update rules.
6443         (lex_one_token): Update.
6444         * ada-lang.c (resolve): Add "parse_completion" parameter.
6445         (resolve_subexp): Likewise.
6446         (ada_resolve_function): Likewise.
6447
6448 2019-04-04  Tom Tromey  <tom@tromey.com>
6449
6450         * parser-defs.h (struct parser_state) <start_arglist,
6451         end_arglist>: New methods.
6452         <arglist_len, m_funcall_chain>: New members.
6453         (arglist_len, start_arglist, end_arglist): Don't declare.
6454         * parse.c (arglist_len, funcall_chain): Remove global.
6455         (start_arglist, end_arglist): Remove functions.
6456         (parse_exp_in_context): Update.
6457         * p-exp.y: Update rules.
6458         * m2-exp.y: Update rules.
6459         * go-exp.y: Update rules.
6460         * f-exp.y: Update rules.
6461         * d-exp.y: Update rules.
6462         * c-exp.y: Update rules.
6463
6464 2019-04-04  Tom Tromey  <tom@tromey.com>
6465
6466         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6467         lex_operator, push_back>: New methods.
6468         Update all rules.
6469         (rust_parser::lex_hex, lex_escape): Rename and update.
6470         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6471         (rust_parser::lex_operator): Rename and update.
6472         (rust_parser::lex_number, rustyylex, rustyyerror)
6473         (rust_lex_test_init, rust_lex_test_sequence)
6474         (rust_lex_test_push_back, rust_lex_tests): Update.
6475         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6476         parameter.
6477         <lexptr, prev_lexptr>: New members.
6478         (lexptr, prev_lexptr): Don't declare.
6479         * parse.c (lexptr, prev_lexptr): Remove globals.
6480         (parse_exp_in_context): Update.
6481         * p-exp.y (yylex, yyerror): Update.
6482         * m2-exp.y (parse_number, yylex, yyerror): Update.
6483         * go-exp.y (lex_one_token, yyerror): Update.
6484         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6485         * d-exp.y (lex_one_token, yyerror): Update.
6486         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6487         (lex_one_token, yyerror): Update.
6488         * ada-lex.l (YY_INPUT): Update.
6489         (rewind_to_char): Update.
6490         * ada-exp.y (yyerror): Update.
6491
6492 2019-04-04  Tom Tromey  <tom@tromey.com>
6493
6494         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6495         * parser-defs.h (struct parser_state) <parser_state>: Add new
6496         parameter.
6497         <comma_terminates>: New member.
6498         (comma_terminates): Don't declare global.
6499         * parse.c (comma_terminates): Remove global.
6500         (parse_exp_in_context): Update.
6501         * p-exp.y (yylex): Update.
6502         * m2-exp.y (yylex): Update.
6503         * go-exp.y (lex_one_token): Update.
6504         * f-exp.y (yylex): Update.
6505         * d-exp.y (lex_one_token): Update.
6506         * c-exp.y (lex_one_token): Update.
6507         * ada-lex.l: Update.
6508
6509 2019-04-04  Tom Tromey  <tom@tromey.com>
6510
6511         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6512         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6513         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6514         * parser-defs.h (paren_depth): Don't declare.
6515         * parse.c (paren_depth): Remove global.
6516         (parse_exp_in_context): Update.
6517         * p-exp.y (paren_depth): New global.
6518         (pascal_parse): Initialize it.
6519         * m2-exp.y (paren_depth): New global.
6520         (m2_parse): Initialize it.
6521         * go-exp.y (paren_depth): New global.
6522         (go_parse): Initialize it.
6523         * f-exp.y (paren_depth): New global.
6524         (f_parse): Initialize it.
6525         * d-exp.y (paren_depth): New global.
6526         (d_parse): Initialize it.
6527         * c-exp.y (paren_depth): New global.
6528         (c_parse): Initialize it.
6529         * ada-lex.l (paren_depth): New global.
6530         (lexer_init): Initialize it.
6531
6532 2019-04-04  Tom Tromey  <tom@tromey.com>
6533
6534         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6535         (rust_parser::convert_ast_to_type)
6536         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6537         * parser-defs.h (struct parser_state) <parser_state>: Add
6538         parameters.  Initialize new members.
6539         <expression_context_block, expression_context_pc>: New members.
6540         * parse.c (expression_context_block, expression_context_pc):
6541         Remove globals.
6542         (parse_exp_in_context): Update.
6543         * p-exp.y: Update all rules.
6544         (yylex): Update.
6545         * m2-exp.y: Update all rules.
6546         (yylex): Update.
6547         * go-exp.y (yylex): Update.
6548         * f-exp.y (yylex): Update.
6549         * d-exp.y: Update all rules.
6550         (yylex): Update.
6551         * c-exp.y: Update all rules.
6552         (lex_one_token, classify_name, yylex, c_parse): Update.
6553         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6554
6555 2019-04-04  Tom Tromey  <tom@tromey.com>
6556
6557         * gdbarch.h, gdbarch.c: Rebuild.
6558         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6559         * stap-probe.h:
6560         (struct stap_parse_info): Replace "parser_state" with
6561         "expr_builder".
6562         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6563         (parser_state): New class.
6564         * parse.c (expr_builder): Rename.
6565         (expr_builder::release): Rename.
6566         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6567         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6568         (write_exp_elt_longcst, write_exp_elt_floatcst)
6569         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6570         (write_exp_string_vector, write_exp_bitstring)
6571         (write_exp_msymbol, mark_struct_expression)
6572         (write_dollar_variable)
6573         (insert_type_address_space, increase_expout_size): Replace
6574         "parser_state" with "expr_builder".
6575         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6576         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6577         "parser_state" with "expr_builder".
6578
6579 2019-04-04  Tom Tromey  <tom@tromey.com>
6580
6581         * rust-exp.y: Replace "parse_language" with method call.
6582         * p-exp.y:
6583         (yylex): Replace "parse_language" with method call.
6584         * m2-exp.y:
6585         (yylex): Replace "parse_language" with method call.
6586         * go-exp.y (classify_name): Replace "parse_language" with method
6587         call.
6588         * f-exp.y (yylex): Replace "parse_language" with method call.
6589         * d-exp.y (lex_one_token): Replace "parse_language" with method
6590         call.
6591         * c-exp.y:
6592         (lex_one_token, classify_name, yylex): Replace "parse_language"
6593         with method call.
6594         * ada-exp.y (find_primitive_type, type_char)
6595         (type_system_address): Replace "parse_language" with method call.
6596
6597 2019-04-04  Tom Tromey  <tom@tromey.com>
6598
6599         * rust-exp.y: Replace "parse_gdbarch" with method call.
6600         * parse.c (write_dollar_variable, insert_type_address_space):
6601         Replace "parse_gdbarch" with method call.
6602         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6603         call.
6604         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6605         call.
6606         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6607         "parse_gdbarch" with method call.
6608         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6609         with method call.
6610         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6611         "parse_gdbarch" with method call.
6612         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6613         "parse_gdbarch" with method call.
6614         * c-exp.y (parse_type, parse_number, classify_name): Replace
6615         "parse_gdbarch" with method call.
6616         * ada-lex.l: Replace "parse_gdbarch" with method call.
6617         * ada-exp.y (parse_type, find_primitive_type, type_char)
6618         (type_system_address): Replace "parse_gdbarch" with method call.
6619
6620 2019-04-04  Tom Tromey  <tom@tromey.com>
6621
6622         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6623         * stap-probe.c (stap_parse_argument): Update.
6624         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6625         initial_size parameter.
6626         * rust-exp.y (rust_lex_tests): Update.
6627         * parse.c (parser_state): Update.
6628         (parse_exp_in_context): Update.
6629         * parser-defs.h (struct parser_state) <parser_state>: Remove
6630         "initial_size" parameter.
6631
6632 2019-04-04  Tom Tromey  <tom@tromey.com>
6633
6634         * parser-defs.h (increase_expout_size): Don't declare.
6635         * parse.c (increase_expout_size): Now static.
6636
6637 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6638
6639         * gnu-nat.c (gnu_nat_target::wait): Fix
6640         target_waitstatus_to_string call.
6641
6642 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6643
6644         * eval.c (evaluate_subexp_standard): Handle internal functions
6645         during Fortran function call handling.
6646
6647 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * NEWS: Mention new internal functions.
6650         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6651         (read_base_type): Use dwarf2_init_complex_target_type.
6652         * value.c (creal_internal_fn): New function.
6653         (cimag_internal_fn): New function.
6654         (_initialize_values): Register new internal functions.
6655
6656 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6657
6658         * infrun.c (stop_all_threads): If debug_infrun, always
6659         trace the wait status after wait_one, using
6660         target_waitstatus_to_string and target_pid_to_str.
6661         (handle_inferior_event): Replace various trace of
6662         wait status kind by a single trace.
6663         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6664         wait status kind image by target_waitstatus_to_string.
6665         * target/waitstatus.c (target_waitstatus_to_string): Fix
6666         obsolete comment.
6667
6668 2019-04-01  Tom Tromey  <tromey@adacore.com>
6669
6670         PR symtab/23331:
6671         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6672
6673 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6674             Pedro Alves  <palves@redhat.com>
6675
6676         * top.c (quit_force): Call 'finalize_values'.
6677         * value.c (finalize_values): New function.
6678         * value.h (finalize_values): Declare.
6679
6680 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6681
6682         * NEWS: Announce $_gdb_major and $_gdb_minor.
6683
6684         * top.c (init_gdb_version_vars): New function.
6685         (gdb_init): Call init_gdb_version_vars.
6686
6687 2019-03-29  Tom Tromey  <tromey@adacore.com>
6688
6689         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6690         help text.  Remove dead code.
6691
6692 2019-03-29  Keith Seitz  <keiths@redhat.com>
6693
6694         From Siddhesh Poyarekar:
6695         * f-lang.h (f77_get_upperbound): Return LONGEST.
6696         (f77_get_lowerbound): Likewise.
6697         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6698         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6699         print them.
6700         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6701         plongest to format print it.
6702         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6703         (f77_get_upperbound): Likewise.
6704         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6705         LOWER_BOUND to LONGEST.
6706         (f77_create_arrayprint_offset_tbl): Likewise.
6707
6708 2019-03-29  Keith Seitz  <keiths@redhat.com>
6709
6710         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6711         %s/pulongest for TYPE_LENGTH instead of %d in format
6712         strings.
6713         * ada-typerint.c (ada_print_type): Likewise.
6714         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6715         * compile/compile-c-support.c (generate_register_struct): Likewise.
6716         * gdbtypes.c (recursive_dump_type): Likewise.
6717         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6718         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6719         instead of %d in format strings.
6720         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6721         to std::min to ULONGEST.
6722         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6723         instead of %d in format strings.
6724         * tracepoint.c (info_scope_command): Likewise.
6725         * typeprint.c (print_offset_data::update)
6726         (print_offset_data::finish): Likewise.
6727         * xtensa-tdep.c (xtensa_store_return_value)
6728         (xtensa_push_dummy_call): Likewise.
6729
6730 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6731
6732         * windows-nat.c (display_selector): Fixed format specifications
6733         for 64-bit Cygwin.
6734
6735 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6736
6737         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6738
6739 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6740
6741         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6742         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6743         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6744         (nios2_linux_init_abi): Install it.
6745
6746 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6747
6748         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6749
6750 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6753
6754 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6755             Tom Tromey  <tromey@adacore.com>
6756
6757         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6758
6759 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6760
6761         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6762         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6763         method to compute the bounds of range types. Also print "[evaluated]"
6764         if the bounds' values come from a dynamic evaluation.
6765
6766 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6767
6768         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6769         whitespace when pretty printing is on.
6770
6771 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6772
6773         * ppc-linux-nat.c: Add include.
6774
6775 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6776
6777         * NEWS: Mention AArch64 Pointer Authentication.
6778
6779 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6780
6781         * arm-linux-nat.c: Add include.
6782
6783 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6784
6785         * source-cache.c (source_cache::get_source_lines): Re-read
6786         fullname after calling open_source_file.
6787
6788 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6789
6790         * NEWS: Mention TLS support for FreeBSD.
6791
6792 2019-03-25  Tom Tromey  <tromey@adacore.com>
6793
6794         * minsyms.c (BUNCH_SIZE): Update comment.
6795         (~minimal_symbol_reader): Remove old comment.
6796         (compact_minimal_symbols): Update comment.
6797         (minimal_symbol_reader::install): Remove old comment.  Update
6798         other comments.
6799
6800 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6801
6802         * s390-linux-nat.c: Add include.
6803
6804 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6805
6806         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6807         Call linux_get_hwcap.
6808         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6809         Likewise.
6810         (aarch64_linux_get_hwcap): Remove function.
6811         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6812         declaration.
6813         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6814         linux_get_hwcap.
6815         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6816         * linux-tdep.c (linux_get_hwcap): Add function.
6817         (linux_get_hwcap2): Likewise.
6818         * linux-tdep.h (linux_get_hwcap): Add declaration.
6819         (linux_get_hwcap2): Likewise.
6820         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6821         (ppc_linux_get_hwcap2): Likewise.
6822         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6823         linux_get_hwcap.
6824         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6825         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6826         (ppc_linux_nat_target::read_description): Likewise.
6827         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6828         * s390-linux-nat.c: Likewise.
6829         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6830
6831 2019-03-24  Tom Tromey  <tom@tromey.com>
6832
6833         * ada-lang.c (standard_lookup): Simplify initialization.
6834         (ada_lookup_symbol_nonlocal): Simplify return.
6835         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6836         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6837         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6838         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6839         initialization.
6840         * solib.c (solib_global_lookup): Simplify.
6841         * symtab.c (null_block_symbol): Remove.
6842         (symbol_cache_lookup): Simplify returns.
6843         (lookup_language_this): Simplify returns.
6844         (lookup_symbol_aux): Simplify return.
6845         (lookup_local_symbol): Simplify returns.
6846         (lookup_global_symbol_from_objfile): Simplify return.
6847         (lookup_symbol_in_objfile_symtabs)
6848         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6849         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6850         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6851         * cp-namespace.c (cp_lookup_bare_symbol)
6852         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6853         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6854         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6855         (cp_lookup_symbol_via_imports): Simplify initialization.
6856         (find_symbol_in_baseclass): Likewise.
6857         * symtab.h (null_block_symbol): Remove.
6858         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6859         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6860         (d_lookup_symbol_module): Likewise.
6861         (find_symbol_in_baseclass): Simplify initialization.
6862
6863 2019-03-24  Tom Tromey  <tom@tromey.com>
6864
6865         * expression.h: Don't include symtab.h.
6866         (struct block): Forward declare.
6867
6868 2019-03-24  Tom Tromey  <tom@tromey.com>
6869
6870         * c-exp.y (typebase): Remove casts.
6871         * gdbtypes.c (lookup_unsigned_typename, )
6872         (lookup_signed_typename): Remove cast.
6873         * eval.c (parse_to_comma_and_eval): Remove cast.
6874         * parse.c (write_dollar_variable): Remove cast.
6875         * block.h (struct block) <superblock>: Now const.
6876         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6877         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6878         (map_block): Make "block" const.
6879         * symfile.h (struct quick_symbol_functions)
6880         <map_matching_symbols>: Constify block argument to "callback".
6881         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6882         const.
6883         (find_pc_sect_compunit_symtab): Make "b" const.
6884         (find_symbol_at_address): Likewise.
6885         (search_symbols): Likewise.
6886         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6887         (dw2_debug_names_lookup_symbol): Likewise.
6888         (dw2_map_matching_symbols): Update.
6889         * p-valprint.c (pascal_val_print): Remove "block".
6890         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6891         (aux_add_nonlocal_symbols): Make "block" const.
6892         (resolve_subexp): Remove cast.
6893         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6894         const.
6895         (iterate_over_file_blocks): Likewise.
6896         * f-exp.y (%union) <bval>: Remove.
6897         * coffread.c (patch_opaque_types): Make "b" const.
6898         * spu-tdep.c (spu_catch_start): Make "block" const.
6899         * c-valprint.c (print_unpacked_pointer): Remove "block".
6900         * symmisc.c (dump_symtab_1): Make "b" const.
6901         (block_depth): Make "block" const.
6902         * d-exp.y (%union) <bval>: Remove.
6903         * cp-support.h (cp_lookup_rtti_type): Update.
6904         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6905         * psymtab.c (psym_lookup_symbol): Make "block" const.
6906         (maintenance_check_psymtabs): Make "b" const.
6907         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6908         (enumerate_locals, enumerate_args): Update.
6909         * python/py-symtab.c (stpy_global_block): Make "block" const.
6910         (stpy_static_block): Likewise.
6911         * inline-frame.c (block_starting_point_at): Make "new_block"
6912         const.
6913         * block.c (find_block_in_blockvector): Make return type const.
6914         (blockvector_for_pc_sect): Make "b" const.
6915         (find_block_in_blockvector): Make "b" const.
6916
6917 2019-03-23  Tom Tromey  <tom@tromey.com>
6918
6919         * varobj.c (varobj_create): Update.
6920         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6921         * printcmd.c (display_command, do_one_display): Don't reset
6922         innermost_block.
6923         * parser-defs.h (enum innermost_block_tracker_type): Move to
6924         expression.h.
6925         (innermost_block): Update comment.
6926         * parse.c (parse_exp_1): Add tracker_types parameter.
6927         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6928         tracker_types parameter.  Reset innermost_block.
6929         (parse_exp_in_context): Remove.
6930         (parse_expression_for_completion): Update.
6931         * objfiles.c (~objfile): Don't reset expression_context_block or
6932         innermost_block.
6933         * expression.h (enum innermost_block_tracker_type): Move from
6934         parser-defs.h.
6935         (parse_exp_1): Add tracker_types parameter.
6936         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6937         reset innermost_block.
6938
6939 2019-03-23  Tom Tromey  <tom@tromey.com>
6940
6941         * objfiles.h: Include bcache.h.
6942
6943 2019-03-23  Tom Tromey  <tom@tromey.com>
6944
6945         * linespec.c (get_current_search_block): Use
6946         scoped_restore_current_language.
6947         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6948
6949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6950             Jiong Wang  <jiong.wang@arm.com>
6951
6952         * aarch64-linux-tdep.c
6953         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6954         section.
6955         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6956
6957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6958             Jiong Wang  <jiong.wang@arm.com>
6959
6960         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6961         instructions.
6962         (aarch64_analyze_prologue_test): Add PACIASP test.
6963         (aarch64_prologue_prev_register): Unmask PC value.
6964
6965 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6966             Jiong Wang  <jiong.wang@arm.com>
6967
6968         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6969         (aarch64_dwarf2_prev_register): Unmask PC value.
6970         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6971         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6972         DW_CFA_AARCH64_negate_ra_state.
6973         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6974
6975 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6976             Jiong Wang  <jiong.wang@arm.com>
6977
6978         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6979         registers.
6980         (aarch64_pseudo_register_name): Likewise.
6981         (aarch64_pseudo_register_type): Likewise.
6982         (aarch64_pseudo_register_reggroup_p): Likewise.
6983         (aarch64_gdbarch_init): Add pauth registers.
6984         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6985         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6986         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6987         (struct gdbarch_tdep): Add regnum for ra_state.
6988
6989 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6990             Jiong Wang  <jiong.wang@arm.com>
6991
6992         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6993
6994 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6995             Jiong Wang  <jiong.wang@arm.com>
6996
6997         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6998         function.
6999         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7000         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7001         (aarch64_gdbarch_init): Add puth registers.
7002         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7003         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7004         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7005
7006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7007             Jiong Wang  <jiong.wang@arm.com>
7008
7009         * aarch64-linux-nat.c
7010         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7011         * aarch64-linux-tdep.c
7012         (aarch64_linux_core_read_description): Likewise.
7013         (aarch64_linux_get_hwcap): New function.
7014         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7015         (aarch64_linux_get_hwcap): New declaration.
7016
7017 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7018             Jiong Wang  <jiong.wang@arm.com>
7019
7020         * aarch64-linux-nat.c
7021         (aarch64_linux_nat_target::read_description): Add pauth param.
7022         * aarch64-linux-tdep.c
7023         (aarch64_linux_core_read_description): Likewise.
7024         * aarch64-tdep.c (struct target_desc): Add in pauth.
7025         (aarch64_read_description): Add pauth param.
7026         (aarch64_gdbarch_init): Likewise.
7027         * aarch64-tdep.h (aarch64_read_description): Likewise.
7028         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7029         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7030         * features/Makefile: Add new files.
7031         * features/aarch64-pauth.c: New file.
7032         * features/aarch64-pauth.xml: New file.
7033
7034 2019-03-20  Tom Tromey  <tromey@adacore.com>
7035
7036         * infrun.c (handle_inferior_event): Rename from
7037         handle_inferior_event_1.  Create a scoped_value_mark.
7038         (handle_inferior_event): Remove.
7039
7040 2019-03-19  Tom Tromey  <tromey@adacore.com>
7041
7042         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7043         * infrun.h (print_stop_event): Add "displays" parameter.
7044         * infrun.c (print_stop_event): Add "displays" parameter.
7045
7046 2019-03-19  Pedro Alves  <palves@redhat.com>
7047
7048         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7049         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7050         to -1.  Fix TABs vs spaces.
7051         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7052         * tui/tui-out.h (tui_ui_out) Add intro comments.
7053         <m_line, m_start_of_line>: In-class initialize, and add describing
7054         comment.
7055
7056 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7057
7058         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7059         variable names.
7060         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7061
7062 2019-03-18  Pedro Alves  <palves@redhat.com>
7063             Eli Zaretskii <eliz@gnu.org>
7064
7065         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7066         m_line and m_start_of_line.
7067
7068 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7069
7070         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7071         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7072         it returns a newline.  This fixes a regression in TU mode, whereby
7073         the next line is output on the same screen line as the user input.
7074
7075 2019-03-18  Tom Tromey  <tromey@adacore.com>
7076
7077         * minsyms.c (minimal_symbol_reader::install): Remove call to
7078         obstack_blank.
7079
7080 2019-03-18  Pedro Alves  <palves@redhat.com>
7081
7082         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7083         New globals.
7084         (apply_style): New, factored out from ...
7085         (apply_ansi_escape): ... this.  Handle reverse video mode.
7086         (tui_set_reverse_mode): New function.
7087         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7088         * tui/tui-winsource.c (tui_show_source_line): Use
7089         tui_set_reverse_mode instead of setting A_STANDOUT.
7090         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7091         New setter methods.
7092
7093 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7094
7095         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7096         Handle tabs.
7097
7098 2019-03-18  Tom Tromey  <tromey@adacore.com>
7099
7100         * ada-lang.c (empty_array): Add "high" parameter.
7101         (ada_evaluate_subexp): Update.
7102
7103 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7104
7105         * unittests/string_view-selftests.c: Define
7106         _initialize_string_view_selftests unconditionally.
7107
7108 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7109
7110         PR gdb/24350
7111         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7112
7113 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7114
7115         PR gdb/24351
7116         * windows-nat.c (display_selector): Fix format specifiers.
7117
7118 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7119
7120         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7121         tui_refill_source_window instead of tui_refresh_win, to update the
7122         current execution line.  This fixes redisplay of the current line
7123         when stepping through the code with "next" or "step".
7124
7125 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7126
7127         * source-cache.c (source_cache::get_source_lines): Call
7128         find_source_lines to initialize s->nlines.  This fixes vertical
7129         scrolling of TUI source window when the DOWN arrow is pressed.
7130
7131 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7132
7133         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7134         linux-thread-db.c (_initialize_thread_db): Likewise.
7135
7136 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7137
7138         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7139         wclrtoeol in tui_show_source_line".  This reverts changes made in
7140         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7141
7142 2019-03-15  Tom Tromey  <tom@tromey.com>
7143
7144         * symtab.h (struct minimal_symbol): Derive from
7145         general_symbol_info.
7146         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7147         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7148         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7149         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7150         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7151         (MSYMBOL_SEARCH_NAME): Update.
7152         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7153         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7154         * minsyms.c (minimal_symbol_reader::record_full): Update.
7155
7156 2019-03-15  Tom Tromey  <tom@tromey.com>
7157
7158         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7159
7160 2019-03-15  Tom Tromey  <tom@tromey.com>
7161
7162         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7163         unique_xmalloc_ptr.
7164         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7165         Update.
7166         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7167         (build_minimal_symbol_hash_tables)
7168         (minimal_symbol_reader::install): Update.
7169
7170 2019-03-15  Tom Tromey  <tom@tromey.com>
7171
7172         * symtab.c (create_demangled_names_hash): Update.
7173         (symbol_set_names): Update.
7174         * objfiles.h (struct objfile_per_bfd_storage)
7175         <demangled_names_hash>: Now an htab_up.
7176         * objfiles.c (objfile_per_bfd_storage): Simplify.
7177
7178 2019-03-15  Tom Tromey  <tom@tromey.com>
7179
7180         * objfiles.h (struct objfile_per_bfd_storage): Declare
7181         destructor.
7182         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7183         New.
7184         (get_objfile_bfd_data): Use new.  Don't initialize
7185         language_of_main.
7186         (free_objfile_per_bfd_storage): Remove.
7187         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7188
7189 2019-03-15  Tom Tromey  <tom@tromey.com>
7190
7191         * symfile.c (reread_symbols): Update.
7192         * objfiles.c (objfile::objfile): Update.
7193         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7194         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7195         comment.
7196         (minimal_symbol_reader::install): Update.
7197         (terminate_minimal_symbol_table): Remove.
7198         * jit.c (jit_object_close_impl): Update.
7199
7200 2019-03-15  Tom Tromey  <tom@tromey.com>
7201
7202         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7203         initializations.
7204
7205 2019-03-15  Tom Tromey  <tom@tromey.com>
7206
7207         * objfiles.h (struct objfile_per_bfd_storage)
7208         <demangled_hash_languages>: Now a bitset.
7209         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7210         (lookup_minimal_symbol): Update.
7211
7212 2019-03-15  Tom Tromey  <tom@tromey.com>
7213
7214         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7215         Don't return the symbol.
7216         * coffread.c (record_minimal_symbol): Use record_full.
7217
7218 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7219
7220         The MS-Windows port of ncurses fails to switch to a color pair if
7221         one or both of the colors are the implicit default colors.  This
7222         change records the default colors when TUI is initialized, and
7223         then specifies them explicitly when a color pair uses the default
7224         colors.  This allows color styling in TUI mode on MS-Windows.
7225
7226         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7227         ncurses_norm_attr.
7228         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7229         colors in ncurses_norm_attr.
7230         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7231         "none", replace it with the default color recorded in
7232         ncurses_norm_attr.
7233
7234 2019-03-14  Tom Tromey  <tromey@adacore.com>
7235
7236         * source-cache.h (class source_cache) <get_source_lines>: Return
7237         std::string.
7238         * source-cache.c (source_cache::extract_lines): Handle case where
7239         first_pos==npos.  Return std::string.
7240         (source_cache::get_source_lines): Update.
7241
7242 2019-03-14  Tom Tromey  <tromey@adacore.com>
7243
7244         * NEWS: Add item for "style sources" commands.
7245         * source-cache.c (source_cache::get_source_lines): Check
7246         source_styling.
7247         * cli/cli-style.c (source_styling): New global.
7248         (_initialize_cli_style): Add "style sources" commands.
7249         (show_style_sources): New function.
7250         * cli/cli-style.h (source_styling): Declare.
7251
7252 2019-03-14  Pedro Alves  <palves@redhat.com>
7253             Tom Tromey  <tromey@adacore.com>
7254
7255         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7256         * tui/tui-winsource.c (tui_refill_source_window): New function,
7257         from...
7258         (tui_horizontal_source_scroll): ... here.  Move some logic.
7259         * cli/cli-style.c (set_style_enabled): Notify new observable.
7260         * tui/tui-hooks.c (tui_redisplay_source): New function.
7261         (tui_attach_detach_observers): Attach or detach
7262         tui_redisplay_source.
7263         * observable.h (source_styling_changed): New observable.
7264         * observable.c: Define source_styling_changed observable.
7265
7266 2019-03-13  Tom Tromey  <tromey@adacore.com>
7267
7268         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7269         (i386_gnu_nat_target::store_registers): Update.
7270         * target-debug.h (target_debug_print_std_string): New macro.
7271         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7272         * windows-tdep.c (display_one_tib): Update.
7273         * tui/tui-stack.c (tui_make_status_line): Update.
7274         * top.c (print_inferior_quit_action): Update.
7275         * thread.c (thr_try_catch_cmd): Update.
7276         (add_thread_with_info): Update.
7277         (thread_target_id_str): Update.
7278         (thr_try_catch_cmd): Update.
7279         (thread_command): Update.
7280         (thread_find_command): Update.
7281         * record-btrace.c (record_btrace_target::info_record)
7282         (record_btrace_resume_thread, record_btrace_target::resume)
7283         (record_btrace_cancel_resume, record_btrace_step_thread)
7284         (record_btrace_target::wait, record_btrace_target::wait)
7285         (record_btrace_target::wait, record_btrace_target::stop): Update.
7286         * progspace.c (print_program_space): Update.
7287         * process-stratum-target.c
7288         (process_stratum_target::thread_address_space): Update.
7289         * linux-fork.c (linux_fork_mourn_inferior)
7290         (detach_checkpoint_command, info_checkpoints_command)
7291         (linux_fork_context): Update.
7292         (linux_fork_detach): Update.
7293         (class scoped_switch_fork_info): Update.
7294         (delete_checkpoint_command): Update.
7295         * infrun.c (follow_fork_inferior): Update.
7296         (follow_fork_inferior): Update.
7297         (proceed_after_vfork_done): Update.
7298         (handle_vfork_child_exec_or_exit): Update.
7299         (follow_exec): Update.
7300         (displaced_step_prepare_throw): Update.
7301         (displaced_step_restore): Update.
7302         (start_step_over): Update.
7303         (resume_1): Update.
7304         (clear_proceed_status_thread): Update.
7305         (proceed): Update.
7306         (print_target_wait_results): Update.
7307         (do_target_wait): Update.
7308         (context_switch): Update.
7309         (stop_all_threads): Update.
7310         (restart_threads): Update.
7311         (finish_step_over): Update.
7312         (handle_signal_stop): Update.
7313         (switch_back_to_stepped_thread): Update.
7314         (keep_going_pass_signal): Update.
7315         (print_exited_reason): Update.
7316         (normal_stop): Update.
7317         * inferior.c (inferior_pid_to_str): Change return type.
7318         (print_selected_inferior): Update.
7319         (add_inferior): Update.
7320         (detach_inferior): Update.
7321         * dummy-frame.c (fprint_dummy_frames): Update.
7322         * dcache.c (dcache_info_1): Update.
7323         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7324         (btrace_fetch, btrace_clear): Update.
7325         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7326         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7327         type.
7328         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7329         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7330         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7331         * gdbarch.c, gdbarch.h: Rebuild.
7332         * gdbarch.sh (core_pid_to_str): Change return type.
7333         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7334         return type.
7335         (windows_nat_target::pid_to_str): Change return type.
7336         (windows_delete_thread): Update.
7337         (windows_nat_target::attach): Update.
7338         (windows_nat_target::files_info): Update.
7339         * target-delegates.c: Rebuild.
7340         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7341         return type.
7342         (sol_thread_target::pid_to_str): Change return type.
7343         * remote.c (class remote_target) <pid_to_str>: Change return
7344         type.
7345         (remote_target::pid_to_str): Change return type.
7346         (extended_remote_target::attach, remote_target::remote_stop_ns)
7347         (remote_target::remote_notif_remove_queued_reply)
7348         (remote_target::push_stop_reply, remote_target::disable_btrace):
7349         Update.
7350         (extended_remote_target::attach): Update.
7351         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7352         type.
7353         (gdbsim_target::pid_to_str): Change return type.
7354         * ravenscar-thread.c (struct ravenscar_thread_target)
7355         <pid_to_str>: Change return type.
7356         (ravenscar_thread_target::pid_to_str): Change return type.
7357         * procfs.c (class procfs_target) <pid_to_str>: Change return
7358         type.
7359         (procfs_target::pid_to_str): Change return type.
7360         (procfs_target::attach): Update.
7361         (procfs_target::detach): Update.
7362         (procfs_target::fetch_registers): Update.
7363         (procfs_target::store_registers): Update.
7364         (procfs_target::wait): Update.
7365         (procfs_target::files_info): Update.
7366         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7367         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7368         return type.
7369         (nto_procfs_target::pid_to_str): Change return type.
7370         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7371         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7372         return type.
7373         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7374         (exit_lwp): Update.
7375         (attach_proc_task_lwp_callback, get_detach_signal)
7376         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7377         (linux_nat_target::resume, wait_lwp, stop_callback)
7378         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7379         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7380         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7381         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7382         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7383         type.
7384         (inf_ptrace_target::attach): Update.
7385         (inf_ptrace_target::files_info): Update.
7386         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7387         type.
7388         (go32_nat_target::pid_to_str): Change return type.
7389         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7390         (gnu_nat_target::wait): Update.
7391         (gnu_nat_target::wait): Update.
7392         (gnu_nat_target::resume): Update.
7393         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7394         (fbsd_nat_target::wait): Update.
7395         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7396         type.
7397         (darwin_nat_target::attach): Update.
7398         * corelow.c (class core_target) <pid_to_str>: Change return type.
7399         (core_target::pid_to_str): Change return type.
7400         * target.c (normal_pid_to_str): Change return type.
7401         (default_pid_to_str): Likewise.
7402         (target_pid_to_str): Change return type.
7403         (target_translate_tls_address): Update.
7404         (target_announce_detach): Update.
7405         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7406         return type.
7407         (bsd_uthread_target::pid_to_str): Change return type.
7408         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7409         type.
7410         (bsd_kvm_target::pid_to_str): Change return type.
7411         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7412         return type.
7413         (aix_thread_target::pid_to_str): Change return type.
7414         * target.h (struct target_ops) <pid_to_str>: Change return type.
7415         (target_pid_to_str, normal_pid_to_str): Likewise.
7416         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7417         type.
7418         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7419         type.
7420         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7421         return type.
7422         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7423         type.
7424         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7425         type.
7426         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7427         return type.
7428
7429 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7430
7431         * NEWS: Mention that the new default MI version is 3.  Mention
7432         changes to the output of commands and events that deal with
7433         multi-location breakpoints.
7434         * breakpoint.c: Include "mi/mi-out.h".
7435         (print_one_breakpoint): Change output syntax if using MI version
7436         >= 3.
7437         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7438         New.
7439         (mi_multi_location_breakpoint_output_fixed): New.
7440         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7441         (mi_cmd_fix_multi_location_breakpoint_output): New.
7442         (mi_multi_location_breakpoint_output_fixed): New.
7443         * mi/mi-cmds.c (mi_cmds): Register command
7444         -fix-multi-location-breakpoint-output.
7445         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7446         interpreter "mi".
7447
7448 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7449
7450         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7451         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7452         instantiate mi_ui_out based on interpreter name.
7453         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7454         * mi/mi-main.c (mi_load_progress): Likewise.
7455
7456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7457
7458         * NEWS: Combine separate "New targets" sections for 8.3.
7459
7460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7461
7462         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7463         (ppcfbsd_init_abi): Install gdbarch
7464         "fetch_tls_load_module_address" and "get_thread_local_address"
7465         methods.
7466
7467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7468
7469         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7470         (riscv_fbsd_init_abi): Install gdbarch
7471         "fetch_tls_load_module_address" and "get_thread_local_address"
7472         methods.
7473
7474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7475
7476         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7477         (i386fbsd_init_abi): Install gdbarch
7478         "fetch_tls_load_module_address" and "get_thread_local_address"
7479         methods.
7480
7481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7482
7483         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7484         (amd64fbsd_init_abi): Install gdbarch
7485         "fetch_tls_load_module_address" and "get_thread_local_address"
7486         methods.
7487
7488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7489
7490         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7491         (struct fbsd_pspace_data): New type.
7492         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7493         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7494         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7495         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7496         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7497
7498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7499
7500         * gdbtypes.c (lookup_struct_elt): New function.
7501         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7502         * gdbtypes.h (struct struct_elt): New type.
7503         (lookup_struct_elt): New prototype.
7504
7505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7506
7507         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7508         remove disabled code block.
7509
7510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7511
7512         * gdbarch.sh (get_thread_local_address): New method.
7513         * gdbarch.h, gdbarch.c: Regenerate.
7514         * target.c (target_translate_tls_address): Use
7515         gdbarch_get_thread_local_address if present instead of
7516         target::get_thread_local_address.
7517
7518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7519
7520         * target.h (target::get_thread_local_address): Update comment.
7521
7522 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7523
7524         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7525         objfile->separate_debug_objfile_backlink if not NULL.
7526
7527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7530         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7531         (amd64bsd_store_inferior_registers): Likewise.
7532         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7533         Enable segment base registers.
7534         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7535         PT_GETFSBASE and PT_GETGSBASE.
7536         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7537         PT_SETGSBASE.
7538         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7539         segment base registers.
7540         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7541
7542 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7543
7544         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7545         Update calls to i386_target_description to add 'segments'
7546         parameter.
7547         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7548         add segment base registers.
7549         * arch/i386.c (i386_create_target_description): Add 'segments'
7550         parameter to enable segment base registers.
7551         * arch/i386.h (i386_create_target_description): Likewise.
7552         * features/i386/32bit-segments.xml: New file.
7553         * features/i386/32bit-segments.c: Generate.
7554         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7555         call to i386_target_description to add 'segments' parameter.
7556         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7557         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7558         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7559         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7560         if feature is present.
7561         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7562         Add 'segments' parameter to call to i386_target_description.
7563         (i386_target_description): Add 'segments' parameter to enable
7564         segment base registers.
7565         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7566         to call to i386_target_description.
7567         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7568         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7569         Define I386_NUM_REGS.
7570         (i386_target_description): Add 'segments' parameter to enable
7571         segment base registers.
7572
7573 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7574
7575         PR/24325
7576         * source-cache.c: #undef open and close, to avoid unresolved
7577         externals during linking.
7578
7579 2019-03-12  Tom Tromey  <tromey@adacore.com>
7580
7581         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7582         const.  Add initializers.
7583         (_initialize_remote): Don't initialize ptid globals.
7584
7585 2019-03-12  Pedro Alves  <palves@redhat.com>
7586
7587         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7588
7589 2019-03-12  Pedro Alves  <palves@redhat.com>
7590
7591         * cp-name-parser.y (main): Remove unused 'len' variable.
7592
7593 2019-03-12  Tom Tromey  <tromey@adacore.com>
7594
7595         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7596         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7597
7598 2019-03-12  Tom Tromey  <tromey@adacore.com>
7599
7600         * linux-nat.c (iterate_over_lwps): Update.
7601         (stop_callback): Remove parameter.
7602         (stop_wait_callback, detach_callback, resume_set_callback)
7603         (select_singlestep_lwp_callback, set_ignore_sigint)
7604         (status_callback, resumed_callback, resume_clear_callback)
7605         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7606         data parameter.
7607         (linux_nat_target::detach, linux_nat_target::resume)
7608         (linux_stop_and_wait_all_lwps, select_event_lwp)
7609         (linux_nat_filter_event, linux_nat_wait_1)
7610         (linux_nat_target::kill, linux_nat_target::stop)
7611         (linux_nat_target::stop): Update.
7612         (linux_nat_resume_callback): Change type.
7613         (resume_stopped_resumed_lwps, count_events_callback)
7614         (select_event_lwp_callback): Likewise.
7615         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7616         * arm-linux-nat.c (struct update_registers_data): Remove.
7617         (update_registers_callback): Change type.
7618         (arm_linux_insert_hw_breakpoint1): Update.
7619         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7620         parameter.
7621         (x86_linux_dr_set_addr): Update.
7622         (x86_linux_dr_set_control): Update.
7623         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7624         (iterate_over_lwps): Use gdb::function_view.
7625         * nat/aarch64-linux-hw-point.c (struct
7626         aarch64_dr_update_callback_param): Remove.
7627         (debug_reg_change_callback): Change type.
7628         (aarch64_notify_debug_reg_change): Update.
7629         * s390-linux-nat.c (s390_refresh_per_info): Update.
7630
7631 2019-03-11  Tom Tromey  <tromey@adacore.com>
7632
7633         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7634         redundant assignment to "this_cu".
7635
7636 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7637
7638         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7639
7640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7641
7642         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7643         from...
7644         (rank_one_type): ... this.
7645
7646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7647
7648         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7649         from...
7650         (rank_one_type): ... this.
7651
7652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7653
7654         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7655         from...
7656         (rank_one_type): ... this.
7657
7658 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7659
7660         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7661         from...
7662         (rank_one_type): ... this.
7663
7664 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7665
7666         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7667         from...
7668         (rank_one_type): ... this.
7669
7670 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7671
7672         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7673         from...
7674         (rank_one_type): ... this.
7675
7676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7677
7678         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7679         from...
7680         (rank_one_type): ... this.
7681
7682 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7683
7684         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7685         from...
7686         (rank_one_type): ... this.
7687
7688 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7689
7690         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7691         from...
7692         (rank_one_type): ... this.
7693
7694 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7695
7696         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7697         from...
7698         (rank_one_type): ... this.
7699
7700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7701
7702         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7703         from...
7704         (rank_one_type): ... this.
7705
7706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7707
7708         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7709         from...
7710         (rank_one_type): ... this.
7711
7712 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7713
7714         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7715         inferior-events' shows the example events.
7716
7717 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7718
7719         Support styling on native MS-Windows console
7720
7721         PR/24315
7722         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7723         on MS-Windows if $TERM is not defined.
7724
7725         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7726
7727         * posix-hdep.c (gdb_console_fputs):
7728         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7729         functions.
7730         * ui-file.h (gdb_console_fputs): Add prototype.
7731
7732         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7733         back to fputs only if the former returns zero.
7734
7735 2019-03-07  Tom Tromey  <tom@tromey.com>
7736
7737         * symmisc.c (print_symbol_bcache_statistics): Update.
7738         (print_objfile_statistics): Update.
7739         * symfile.c (allocate_symtab): Update.
7740         * stabsread.c: Don't include bcache.h.
7741         * psymtab.h (struct psymbol_bcache): Don't declare.
7742         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7743         (psymbol_bcache_init, psymbol_bcache_free)
7744         (psymbol_bcache_get_bcache): Don't declare.
7745         * psymtab.c (struct psymbol_bcache): Remove.
7746         (psymtab_storage::psymtab_storage): Update.
7747         (psymtab_storage::~psymtab_storage): Update.
7748         (psymbol_bcache_init, psymbol_bcache_free)
7749         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7750         (add_psymbol_to_bcache): Update.
7751         (allocate_psymtab): Update.
7752         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7753         macro_cache>: No longer pointers.
7754         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7755         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7756         * macrotab.c (macro_bcache): Update.
7757         * macroexp.c: Don't include bcache.h.
7758         * gdbtypes.c (check_types_worklist): Update.
7759         (types_deeply_equal): Remove TRY/CATCH.  Update.
7760         * elfread.c (elf_symtab_read): Update.
7761         * dwarf2read.c: Don't include bcache.h.
7762         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7763         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7764         (print_bcache_statistics, bcache_memory_used): Don't declare.
7765         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7766         methods.  Rename all data members.
7767         * bcache.c (struct bcache): Move to bcache.h.
7768         (bcache::expand_hash_table): Rename from expand_hash_table.
7769         (bcache): Remove.
7770         (bcache::insert): Rename from bcache_full.
7771         (bcache::compare): Rename from bcache_compare.
7772         (bcache_xmalloc): Remove.
7773         (bcache::~bcache): Rename from bcache_xfree.
7774         (bcache::print_statistics): Rename from print_bcache_statistics.
7775         (bcache::memory_used): Rename from bcache_memory_used.
7776
7777 2019-03-07  Pedro Alves  <palves@redhat.com>
7778
7779         * infrun.c (normal_stop): Also check for
7780         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7781
7782 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * f-lang.c (value_from_host_double): Moved to...
7785         * value.c (value_from_host_double): ...here.
7786         * value.h (value_from_host_double): Declare.
7787         * guile/scm-math.c (vlscm_convert_typed_number): Use
7788         value_from_host_double.
7789         (vlscm_convert_number): Likewise.
7790         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7791         * python/py-value.c (convert_value_from_python): Likewise.
7792
7793 2019-03-06  Tom Tromey  <tom@tromey.com>
7794
7795         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7796
7797 2019-03-06  Tom Tromey  <tom@tromey.com>
7798
7799         * utils.h (free_current_contents): Don't declare.
7800         * utils.c (free_current_contents): Remove.
7801
7802 2019-03-06  Tom Tromey  <tom@tromey.com>
7803
7804         * top.c (quit_force): Update.
7805         * main.c (captured_command_loop): Update.
7806         * common/new-op.c (operator new): Update.
7807         * common/common-exceptions.c (struct catcher)
7808         <save_cleanup_chain>: Remove member.
7809         (exceptions_state_mc_init): Update.
7810         (exception_try_scope_entry): Return nullptr.
7811         (exception_try_scope_exit, exception_rethrow)
7812         (throw_exception_sjlj, throw_exception_cxx): Update.
7813         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7814         (all_cleanups, do_cleanups, discard_cleanups)
7815         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7816         (restore_cleanups, restore_final_cleanups): Don't declare.
7817         (do_final_cleanups): Remove parameter.
7818         * common/cleanups.c (cleanup_chain, make_cleanup)
7819         (make_cleanup_dtor, all_cleanups, do_cleanups)
7820         (discard_my_cleanups, discard_cleanups)
7821         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7822         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7823         (null_cleanup): Remove.
7824         (do_final_cleanups): Remove parameter.
7825
7826 2019-03-06  Tom Tromey  <tom@tromey.com>
7827
7828         * remote.c (remote_target::remote_parse_stop_reply): Use
7829         unique_xmalloc_ptr.
7830
7831 2019-03-06  Tom Tromey  <tom@tromey.com>
7832
7833         * stabsread.c (struct stabs_field_info): Rename from field_info.
7834         <list, fnlist>: Add initializers.
7835         <obstack>: New member.
7836         (read_member_functions, read_struct_fields, read_baseclasses):
7837         Allocate on obstack.  Don't use cleanups.
7838         (read_one_struct_field, read_member_functions, read_struct_fields)
7839         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7840         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7841         (read_struct_type): Update.
7842
7843 2019-03-06  Tom Tromey  <tom@tromey.com>
7844
7845         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7846         * common/filestuff.h (make_cleanup_close): Don't declare.
7847         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7848         Remove.
7849
7850 2019-03-06  Tom Tromey  <tom@tromey.com>
7851
7852         * solib-aix.c: Use make_scope_exit.
7853
7854 2019-03-06  Tom Tromey  <tom@tromey.com>
7855
7856         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7857         Use make_scope_exit.
7858
7859 2019-03-06  Tom Tromey  <tom@tromey.com>
7860
7861         * solib-svr4.c (disable_probes_interface): Remove parameter.
7862         (svr4_handle_solib_event): Use make_scope_exit.
7863
7864 2019-03-06  Tom Tromey  <tom@tromey.com>
7865
7866         * remote.c (struct stop_reply_deleter): Remove.
7867         (stop_reply_up): Update.
7868         (struct stop_reply): Derive from notif_event.  Don't typedef.
7869         <regcache>: Now a std::vector.
7870         (stop_reply_xfree): Remove.
7871         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7872         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7873         (remote_target::discard_pending_stop_replies): Use delete.
7874         (remote_target::remote_parse_stop_reply): Update.
7875         (remote_target::process_stop_reply): Update.
7876         * remote-notif.h (struct notif_event): Add virtual destructor.
7877         Remove "dtr" member.
7878         (struct notif_client) <alloc_event>: Return a unique_ptr.
7879         (notif_event_xfree): Don't declare.
7880         (notif_event_up): New typedef.
7881         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7882         (notif_event_xfree, do_notif_event_xfree): Remove.
7883         (remote_notif_state_xfree): Update.
7884
7885 2019-03-06  Tom Tromey  <tom@tromey.com>
7886
7887         * infrun.c (displaced_step_clear_cleanup): Now a
7888         forward_scope_exit type.
7889         (displaced_step_prepare_throw): Update.
7890         (displaced_step_fixup): Update.
7891
7892 2019-03-06  Tom Tromey  <tom@tromey.com>
7893
7894         * inferior.h (class inferior): Update comment.
7895         * gdbthread.h (class thread_info): Update comment.
7896
7897 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7898             Tom Tromey  <tom@tromey.com>
7899
7900         * stabsread.h (struct stab_section_list): Remove.
7901         (coffstab_build_psymtabs): Update.
7902         * dbxread.c (symbuf_sections): Now a std::vector.
7903         (sect_idx): New global.
7904         (fill_symbuf): Update.
7905         (coffstab_build_psymtabs): Change type of stabsects parameter.
7906         Update.
7907         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7908         std::vector.
7909         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7910         (coff_locate_sections): Update.
7911         (coff_symfile_read): Remove cleanups.  Update.
7912         (init_stringtab): Add storage parameter.
7913         (free_stringtab, free_stringtab_cleanup): Remove.
7914         (init_lineno): Add storage parameter.
7915         (free_linetab, free_linetab_cleanup): Remove.
7916
7917 2019-03-06  Pedro Alves  <palves@redhat.com>
7918
7919         * linux-fork.c (fork_info::clobber_regs): Delete.
7920         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7921         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7922         comment.  Adjust.
7923         (scoped_switch_fork_info::scoped_switch_fork_info)
7924         (checkpoint_command, linux_fork_context): Adjust
7925         fork_save_infrun_state calls.
7926
7927 2019-03-06  Pedro Alves  <palves@redhat.com>
7928
7929         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7930         (inf_has_multiple_threads): Return 'bool' and rewrite using
7931         inferior_info::threads().
7932
7933 2019-03-06  Pedro Alves  <palves@redhat.com>
7934
7935         * linux-fork.c: Include <list>.
7936         (fork_list): Now a std::list instance.
7937         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7938         (forks_exist_p, find_last_fork): Adjust.
7939         (new_fork): Delete.
7940         (one_fork_p): New.
7941         (add_fork): Adjust.
7942         (free_fork): Delete, folded into fork_info::~fork_info().
7943         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7944         Adjust.
7945         (init_fork_list): Delete.
7946         (linux_fork_killall, linux_fork_mourn_inferior)
7947         (linux_fork_detach, info_checkpoints_command): Adjust.
7948         (_initialize_linux_fork): No longer call init_fork_list.
7949
7950 2019-03-06  Pedro Alves  <palves@redhat.com>
7951
7952         * linux-fork.c (new_fork): New, split out of ...
7953         (add_fork): ... this.  Return void.  Move "first fork" special
7954         case from here, to ...
7955         (checkpoint_command): ... here.
7956         * linux-linux.h (add_fork): Return void.
7957
7958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7959
7960         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7961
7962 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7963             Chris January  <chris.january@arm.com>
7964             David Lecomber  <david.lecomber@arm.com>
7965
7966         * f-exp.y: New token, UNOP_INTRINSIC.
7967         (exp): New pattern using UNOP_INTRINSIC token.
7968         (f77_keywords): Add 'abs' keyword.
7969         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7970         (value_from_host_double): New function.
7971         (evaluate_subexp_f): Support UNOP_ABS.
7972
7973 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7974
7975         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7976         types.
7977
7978 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7981         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7982         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7983
7984 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7987
7988 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7989             Chris January  <chris.january@arm.com>
7990
7991         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7992         * f-exp.y: Define 'KIND' token.
7993         (exp): New pattern for KIND expressions.
7994         (ptype): Handle types with a kind extension.
7995         (direct_abs_decl): Extend to spot kind extensions.
7996         (f77_keywords): Add 'kind' to the list.
7997         (push_kind_type): New function.
7998         (convert_to_kind_type): New function.
7999         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8000         * parse.c (operator_length_standard): Likewise.
8001         * parser-defs.h (enum type_pieces): Add tp_kind.
8002         * std-operator.def: Add UNOP_KIND.
8003
8004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8005
8006         * f-exp.y (f_parse): Set yydebug.
8007
8008 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * f-lang.c (evaluate_subexp_f): New function.
8011         (exp_descriptor_f): New global.
8012         (f_language_defn): Use exp_descriptor_f instead of
8013         exp_descriptor_standard.
8014
8015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8016
8017         * f-exp.y (struct token): Add comments.
8018         (dot_ops): Remove uppercase versions and the end marker.
8019         (f77_keywords): Likewise.
8020         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8021         entries in the dot_ops array are case insensitive, and use
8022         strncasecmp to compare strings.  Also some whitespace cleanup in
8023         this area.  Similar for the f77_keywords array, except entries in
8024         this list might be case sensitive.
8025
8026 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8027
8028         * f-exp.y (struct f77_boolean_val): Add comments.
8029         (boolean_values): Remove uppercase versions, and end marker.
8030         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8031         and use strncasecmp to achieve case insensitivity.  Additionally,
8032         perform whitespace cleanup around this code.
8033
8034 2019-03-06  Tom Tromey  <tromey@adacore.com>
8035
8036         * remote-sim.c (gdbsim_target_open): Use result of
8037         gdb_argv::release.
8038
8039 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8040         Dirk Schubert  <dirk.schubert@arm.com>
8041         Chris January  <chris.january@arm.com>
8042
8043         * eval.c (evaluate_subexp_standard): Call Fortran argument
8044         wrapping logic.
8045         * f-lang.c (struct value): A value which can be passed into a
8046         Fortran function call.
8047         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8048         where appropriate.
8049         (struct type): Value ready for a Fortran function call.
8050         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8051         is needed.
8052         * f-lang.h (fortran_argument_convert): Declaration.
8053         (fortran_preserve_arg_pointer): Declaration.
8054         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8055
8056 2019-03-05  Tom Tromey  <tromey@adacore.com>
8057
8058         * python/py-prettyprint.c (print_string_repr): Remove #if.
8059         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8060
8061 2019-03-05  Tom Tromey  <tromey@adacore.com>
8062
8063         * target.c (the_dummy_target): Move later.  Change type to
8064         "dummy_target".
8065         (initialize_targets): Don't initialize the_dummy_target.
8066
8067 2019-03-05  Tom Tromey  <tromey@adacore.com>
8068
8069         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8070         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8071
8072 2019-03-05  Tom Tromey  <tromey@adacore.com>
8073
8074         * windows-nat.c (windows_nat_target::attach)
8075         (windows_nat_target::detach): Don't call gdb_flush.
8076         * valprint.c (generic_val_print, val_print, val_print_string):
8077         Don't call gdb_flush.
8078         * utils.c (defaulted_query): Don't call gdb_flush.
8079         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8080         * target.c (target_announce_detach): Don't call gdb_flush.
8081         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8082         * remote.c (extended_remote_target::attach): Don't call
8083         gdb_flush.
8084         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8085         * printcmd.c (do_examine): Don't call gdb_flush.
8086         (info_display_command): Don't call gdb_flush.
8087         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8088         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8089         * memattr.c (info_mem_command): Don't call gdb_flush.
8090         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8091         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8092         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8093         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8094         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8095         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8096         (gnu_nat_target::detach): Don't call gdb_flush.
8097         * f-valprint.c (f_val_print): Don't call gdb_flush.
8098         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8099         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8100         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8101         gdb_flush.
8102         * c-valprint.c (c_val_print): Don't call gdb_flush.
8103         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8104
8105 2019-03-05  Tom Tromey  <tromey@adacore.com>
8106
8107         * varobj.c (update_dynamic_varobj_children): Update.
8108         (install_default_visualizer): Use reset, not release.
8109         * value.c (set_internalvar): Update.
8110         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8111         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8112         ATTRIBUTE_UNUSED_RESULT.
8113
8114 2019-03-05  Tom Tromey  <tromey@adacore.com>
8115
8116         * remote.c (class scoped_remote_fd) <release>: Add
8117         ATTRIBUTE_UNUSED_RESULT.
8118
8119 2019-03-05  Tom Tromey  <tromey@adacore.com>
8120
8121         * macroexp.c (struct macro_buffer) <release>: Add
8122         ATTRIBUTE_UNUSED_RESULT.
8123
8124 2019-03-05  Tom Tromey  <tromey@adacore.com>
8125
8126         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8127         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8128         ATTRIBUTE_UNUSED_RESULT.
8129
8130 2019-03-05  Tom Tromey  <tromey@adacore.com>
8131
8132         * common/scoped_fd.h (class scoped_fd) <release>: Add
8133         ATTRIBUTE_UNUSED_RESULT.
8134
8135 2019-03-05  Tom Tromey  <tromey@adacore.com>
8136
8137         * parser-defs.h (struct parser_state) <release>: Add
8138         ATTRIBUTE_UNUSED_RESULT.
8139
8140 2019-03-05  Tom Tromey  <tromey@adacore.com>
8141
8142         * utils.h (class gdb_argv) <release>: Add
8143         ATTRIBUTE_UNUSED_RESULT.
8144         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8145
8146 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8147
8148         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8149         for-loop range, to avoid compiler warnings.
8150
8151         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8152         avoid compiler warnings about unused variables.
8153
8154         * NEWS: Mention end of support for native debugging on MS-Windows
8155         before XP.
8156
8157         PR gdb/24292
8158         * common/netstuff.c:
8159         * gdbserver/gdbreplay.c
8160         * gdbserver/remote-utils.c:
8161         * ser-tcp.c:
8162         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8163         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8164         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8165         'getaddrinfo' and 'freeaddrinfo' were not available before
8166         Windows XP, and mingw.org's MinGW headers by default define
8167         _WIN32_WINNT to 0x500.
8168
8169 2019-03-01  Gary Benson <gbenson@redhat.com>
8170
8171         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8172
8173 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8174             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8175
8176         PR gdb/8527
8177         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8178         set_sigint_trap, clear_sigint_trap.
8179
8180 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8181
8182         * target.c (target_detach): Clear the regcache and the
8183         frame cache.
8184
8185 2019-02-27  Pedro Alves  <palves@redhat.com>
8186
8187         * utils.c (set_screen_size): When we cap the height/width sizes,
8188         tweak the corresponding command variable to show "unlimited":
8189
8190 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8191             Pedro Alves  <palves@redhat.com>
8192
8193         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8194         before calling rl_set_screen_size.
8195
8196 2019-02-27  Tom Tromey  <tromey@adacore.com>
8197
8198         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8199         define.
8200         * python/py-value.c: Remove Python 2.4 workaround.
8201         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8202         workaround.
8203         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8204         Python 2.4 workaround.
8205         * python/python-internal.h: Remove Python 2.4 comment.
8206         (Py_ssize_t): Don't define.
8207         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8208         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8209         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8210         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8211         * python/python.c (do_start_initialization): Remove Python 2.4
8212         workaround.
8213         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8214         (print_children): Remove Python 2.4 workaround.
8215         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8216         workaround.
8217         (CHARBUFFERPROC_NAME): Remove.
8218         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8219         Python 2.4 workaround.
8220
8221 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8222
8223         * NEWS: Note minimum Python version.
8224
8225 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8226
8227         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8228         code from these functions.  Remove corresponding ifdefs.  Use
8229         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8230         Remove gotos and target of gotos.
8231         (infpy_search_memory): Likewise.
8232
8233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8236         (hppa_gdbarch_init): Don't register deleted functions with
8237         gdbarch.
8238
8239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8242         (h8300_unwind_sp): Delete.
8243         (h8300_dummy_id): Delete.
8244         (h8300_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8250         (ft32_unwind_pc): Delete.
8251         (ft32_unwind_sp): Delete.
8252         (ft32_gdbarch_init): Don't register deleted functions with
8253         gdbarch.
8254
8255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8258         (frv_unwind_pc): Delete.
8259         (frv_unwind_sp): Delete.
8260         (frv_gdbarch_init): Don't register deleted functions with
8261         gdbarch.
8262
8263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8266         (riscv_unwind_pc): Delete.
8267         (riscv_unwind_sp): Delete.
8268         (riscv_gdbarch_init): Don't register deleted functions with
8269         gdbarch.
8270
8271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8274         (csky_unwind_pc): Delete.
8275         (csky_unwind_sp): Delete.
8276         (csky_gdbarch_init): Don't register deleted functions with
8277         gdbarch.
8278
8279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8282         (cris_unwind_pc): Delete.
8283         (cris_unwind_sp): Delete.
8284         (cris_gdbarch_init): Don't register deleted functions with
8285         gdbarch.
8286
8287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8290         (bfin_unwind_pc): Delete.
8291         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8292
8293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8294
8295         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8296         (arm_unwind_pc): Delete.
8297         (arm_unwind_sp): Delete.
8298         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8299
8300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8303         (arc_unwind_pc): Delete.
8304         (arc_unwind_sp): Delete.
8305         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8306
8307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8308
8309         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8310         (alpha_unwind_pc): Delete.
8311         (alpha_gdbarch_init): Don't register deleted functions with
8312         gdbarch.
8313
8314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8315
8316         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8317         (aarch64_unwind_pc): Delete.
8318         (aarch64_unwind_sp): Delete.
8319         (aarch64_gdbarch_init): Don't register deleted functions with
8320         gdbarch.
8321
8322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8323
8324         * gdbtypes.c (type_align): Don't consider static members when
8325         computing structure alignment.
8326
8327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8328
8329         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8330         return 0 for other types.
8331         * arch-utils.c (default_type_align): Always return 0.
8332         * gdbarch.h: Regenerate.
8333         * gdbarch.sh (type_align): Extend comment.
8334         * gdbtypes.c (type_align): Add additional comments, always call
8335         gdbarch_type_align before applying the default rules.
8336         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8337         generic code will then apply a suitable default.
8338         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8339         types, return 0 for other types.
8340
8341 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8342
8343         * NEWS: Create a new section for the next release branch.
8344         Rename the section of the current branch, now that it has
8345         been cut.
8346
8347 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8348
8349         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8350         * version.in: Bump version to 8.3.50.DATE-git.
8351
8352 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8353
8354         * aix-thread.c (ptid_cmp): Remove unused variable.
8355         (get_signaled_thread): Likewise.
8356         (store_regs_user_thread): Likewise.
8357         (store_regs_kernel_thread): Likewise.
8358         (fetch_regs_kernel_thread): Remove shadowed variable.
8359
8360 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * features/riscv/32bit-cpu.xml: Add register numbers.
8363         * features/riscv/32bit-fpu.c: Regenerate.
8364         * features/riscv/32bit-fpu.xml: Add register numbers.
8365         * features/riscv/64bit-cpu.xml: Add register numbers.
8366         * features/riscv/64bit-fpu.c: Regenerate.
8367         * features/riscv/64bit-fpu.xml: Add register numbers.
8368
8369 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8370
8371         * NEWS: Mention two argument form of gdb.Value constructor.
8372         * python/py-value.c (convert_buffer_and_type_to_value): New
8373         function.
8374         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8375         Add support for handling an optional second argument.  Call
8376         convert_buffer_and_type_to_value as appropriate.
8377         * python/python-internal.h (Py_buffer_deleter): New struct.
8378         (Py_buffer_up): New typedef.
8379
8380 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8381
8382         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8383         instead of releasing ownership.
8384
8385 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8386
8387         * dwarf2read.c (open_and_init_dwp_file): Call
8388         elf_numsections instead of bfd_count_sections to initialize
8389         dwp_file->num_sections.
8390
8391 2019-02-25  Tom Tromey  <tromey@adacore.com>
8392
8393         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8394
8395 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8396
8397         * gcore.in: Add '--readnever' option when invoking GDB.
8398
8399 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8400
8401         * MAINTAINERS: Update my email address.
8402
8403 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8404
8405         * build-id.c (build_id_to_debug_bfd_1): New function.
8406         (build_id_to_debug_bfd): Look for separate debug file in
8407         sysroot.
8408
8409 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8410
8411         * gdbarch.sh: Update the copyright year range that is placed into
8412         generated files.
8413
8414 2019-02-22  Keith Seitz  <keiths@redhat.com>
8415
8416         PR symtab/23853
8417         * linespec.c (create_sals_line_offset): Search for the default
8418         symtab's filename instead of its fullname.
8419
8420 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8421
8422         * NEWS: Update style defaults.
8423
8424 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8425
8426         * main.c (captured_main_1): Disable styling in batch mode.
8427
8428 2019-02-20  Tom Tromey  <tom@tromey.com>
8429
8430         * symtab.c (symtab_symbol_info): Fix typos.
8431
8432 2019-02-20  Tom Tromey  <tromey@adacore.com>
8433
8434         * findcmd.c (_initialize_mem_search): Use upper case for
8435         metasyntactic variables.
8436
8437 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8438
8439         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8440         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8441
8442 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8443
8444         * top.h (source_file_name): Change to std::string.
8445         * top.c (source_file_name): Likewise.
8446         (command_line_input): Adjust.
8447         * cli/cli-script.c (script_from_file): Adjust.
8448
8449 2019-02-19  Tom Tromey  <tromey@adacore.com>
8450
8451         * ravenscar-thread.c
8452         (ravenscar_thread_target::update_thread_list): Don't call
8453         ada_build_task_list.
8454         * ada-lang.h (ada_build_task_list): Don't declare.
8455         * ada-tasks.c (struct ada_tasks_inferior_data)
8456         <task_list_valid_p>: Now bool.
8457         (read_known_tasks, ada_task_list_changed)
8458         (ada_tasks_invalidate_inferior_data): Update.
8459         (read_known_tasks_array): Return bool.
8460         (read_known_tasks_list): Likewise.
8461         (read_known_tasks): Return void.
8462         (ada_build_task_list): Now static.
8463
8464 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8467         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8468
8469 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8470
8471         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8472         variant for ada_tasks_pspace_data_handle and
8473         ada_tasks_inferior_data_handle.
8474         (ada_tasks_pspace_data_cleanup): New function.
8475         (ada_tasks_inferior_data_cleanup): New function.
8476
8477 2019-02-17  Tom Tromey  <tom@tromey.com>
8478
8479         * macrotab.h (macro_source_fullname): Return a std::string.
8480         * macrotab.c (macro_include, check_for_redefinition)
8481         (macro_undef, macro_lookup_definition, foreach_macro)
8482         (foreach_macro_in_scope): Update.
8483         (macro_source_fullname): Return a std::string.
8484         * macrocmd.c (show_pp_source_pos): Update.
8485
8486 2019-02-17  Tom Tromey  <tom@tromey.com>
8487
8488         * macrocmd.c (show_pp_source_pos): Style the file names.
8489
8490 2019-02-17  Tom Tromey  <tom@tromey.com>
8491
8492         PR tui/24197:
8493         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8494
8495 2019-02-17  Tom Tromey  <tom@tromey.com>
8496
8497         * ada-lang.c (user_select_syms): Use filtered printing.
8498         * utils.c (wrap_style): New global.
8499         (desired_style): Remove.
8500         (emit_style_escape): Add stream parameter.
8501         (set_output_style, reset_terminal_style, prompt_for_continue):
8502         Update.
8503         (flush_wrap_buffer): Only flush gdb_stdout.
8504         (wrap_here): Set wrap_style.
8505         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8506         treat escape sequences as a character.  Change when wrap buffer is
8507         flushed.
8508         (fputs_styled): Do not set the output style when the default is
8509         requested.
8510         * ui-style.h (struct ui_file_style) <is_default>: New method.
8511         * source.c (print_source_lines_base): Emit escape sequences in one
8512         piece.
8513
8514 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8515
8516         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8517         integers and enumeration types.
8518
8519 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8520
8521         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8522         instead of lookup_symbol_in_language
8523         (do_exact_match): New function.
8524         (ada_get_symbol_name_matcher): Return do_exact_match when
8525         doing a verbatim match.
8526
8527 2019-02-15  Tom Tromey  <tromey@adacore.com>
8528
8529         * ravenscar-thread.c (ravenscar_thread_target::resume)
8530         (ravenscar_thread_target::wait): Special case wildcard requests.
8531
8532 2019-02-15  Tom Tromey  <tromey@adacore.com>
8533
8534         * ravenscar-thread.c (base_ptid): Remove.
8535         (struct ravenscar_thread_target) <close>: New method.
8536         <m_base_ptid>: New member.
8537         <update_inferior_ptid, active_task, task_is_currently_active,
8538         runtime_initialized>: Declare methods.
8539         <ravenscar_thread_target>: Add constructor.
8540         (ravenscar_thread_target::task_is_currently_active)
8541         (ravenscar_thread_target::update_inferior_ptid)
8542         (ravenscar_runtime_initialized): Rename.  Now methods.
8543         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8544         (ravenscar_thread_target::update_thread_list): Update.
8545         (ravenscar_thread_target::active_task): Now method.
8546         (ravenscar_thread_target::store_registers)
8547         (ravenscar_thread_target::prepare_to_store)
8548         (ravenscar_thread_target::prepare_to_store)
8549         (ravenscar_thread_target::mourn_inferior): Update.
8550         (ravenscar_inferior_created): Use "new" to create target.
8551         (ravenscar_thread_target::get_ada_task_ptid): Update.
8552         (_initialize_ravenscar): Don't initialize base_ptid.
8553         (ravenscar_ops): Remove global.
8554
8555 2019-02-15  Tom Tromey  <tromey@adacore.com>
8556
8557         * target.h (push_target): Declare new overload.
8558         * target.c (push_target): New overload, taking an rvalue reference.
8559         * remote.c (remote_target::open_1): Use push_target overload.
8560         * corelow.c (core_target_open): Use push_target overload.
8561
8562 2019-02-15  Tom Tromey  <tromey@adacore.com>
8563
8564         * ravenscar-thread.c (is_ravenscar_task)
8565         (ravenscar_task_is_currently_active): Return bool.
8566         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8567         (_initialize_ravenscar): Remove "(void)".
8568         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8569         Return bool.
8570
8571 2019-02-15  Tom Tromey  <tromey@adacore.com>
8572
8573         * ravenscar-thread.c (ravenscar_runtime_initializer)
8574         (has_ravenscar_runtime, get_running_thread_id)
8575         (ravenscar_thread_target::resume): Fix indentation.
8576
8577 2019-02-15  Tom Tromey  <tromey@adacore.com>
8578
8579         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8580         from ravenscar_arch_ops.
8581         (sparc_ravenscar_ops::fetch_registers)
8582         (sparc_ravenscar_ops::store_registers): Now methods.
8583         (sparc_ravenscar_prepare_to_store): Remove.
8584         (sparc_ravenscar_ops): Redefine.
8585         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8586         methods and destructor.  Remove members.
8587         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8588         (ravenscar_thread_target::store_registers)
8589         (ravenscar_thread_target::prepare_to_store): Update.
8590         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8591         Remove.
8592         (struct ppc_ravenscar_powerpc_ops): Derive from
8593         ravenscar_arch_ops.
8594         (ppc_ravenscar_powerpc_ops::fetch_registers)
8595         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8596         (ppc_ravenscar_powerpc_ops): Redefine.
8597         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8598         (ppc_ravenscar_e500_ops::fetch_registers)
8599         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8600         (ppc_ravenscar_e500_ops): Redefine.
8601         * aarch64-ravenscar-thread.c
8602         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8603         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8604         (aarch64_ravenscar_fetch_registers)
8605         (aarch64_ravenscar_store_registers): Now methods.
8606         (aarch64_ravenscar_ops): Redefine.
8607
8608 2019-02-15  Tom Tromey  <tromey@adacore.com>
8609
8610         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8611         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8612         (ravenscar_thread_target::stopped_by_watchpoint)
8613         (ravenscar_thread_target::stopped_data_address)
8614         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8615
8616 2019-02-15  Tom Tromey  <tromey@adacore.com>
8617
8618         * ravenscar-thread.c: Fix some typos.
8619
8620 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8621             Tom Tromey  <tromey@adacore.com>
8622
8623         * ada-lang.c (ada_exception_sal): Change addr_string to a
8624         std::string.
8625         (create_ada_exception_catchpoint): Update.
8626
8627 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8628             Tom Tromey  <tromey@adacore.com>
8629
8630         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8631         (bp_location_ops): Remove.
8632         (base_breakpoint_allocate_location): Update.
8633         (free_bp_location): Update.
8634         * ada-lang.c (class ada_catchpoint_location)
8635         <ada_catchpoint_location>: Remove ops parameter.
8636         (ada_catchpoint_location_dtor): Remove.
8637         (ada_catchpoint_location_ops): Remove.
8638         (allocate_location_exception): Update.
8639         * breakpoint.h (struct bp_location_ops): Remove.
8640         (class bp_location) <bp_location>: Remove bp_location_ops
8641         parameter.
8642         <~bp_location>: Add destructor.
8643         <ops>: Remove.
8644
8645 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8646             Pedro Alves  <palves@redhat.com>
8647
8648         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8649         'PATH_MAX'.
8650
8651 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8652             Samuel Thibault  <samuel.thibault@gnu.org>
8653             Thomas Schwinge  <thomas@codesourcery.com>
8654
8655         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8656         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8657
8658 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8659
8660         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8661         (check_empty): Use "const char *".
8662
8663         * gnu-nat.c (gnu_nat_target::detach): Instead of
8664         'detach_inferior (pid)' call
8665         'detach_inferior (find_inferior_pid (pid))'.
8666
8667         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8668         'nat/fork-inferior.o'.
8669         * gnu-nat.c: #include "nat/fork-inferior.h".
8670
8671         * gnu-nat.c (gnu_nat_target::detach): Instead of
8672         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8673         * gnu-nat.h: #include "inf-child.h".
8674         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8675         'i386_gnu_nat_target::fetch_registers'.
8676         (gnu_store_registers): Rename/move to
8677         'i386_gnu_nat_target::store_registers'.
8678
8679         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8680         * gnu-nat.h (mach_thread_info): New function.
8681         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8682
8683         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8684
8685 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8686
8687         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8688
8689 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8690
8691         * windows-nat.c (windows_add_thread): Add new parameter
8692         "main_thread_p" with default value set to false.  Update
8693         function documentation as well as all callers.
8694         (windows_delete_thread): Likewise.
8695         (fake_create_process): Update call to windows_add_thread.
8696         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8697         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8698         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8699         call to windows_delete_thread.
8700
8701 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8702
8703         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8704
8705 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8706
8707         * symfile.c (find_separate_debug_file): Use canonical path of
8708         sysroot with child_path instead of gdb_sysroot if it is valid.
8709
8710 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8711
8712         * symfile.c (find_separate_debug_file): Use child_path to
8713         determine if an object file is under a sysroot.
8714
8715 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8716
8717         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8718         unittests/child-path-selftests.c.
8719         * common/pathstuff.c (child_path): New function.
8720         * common/pathstuff.h (child_path): New prototype.
8721         * unittests/child-path-selftests.c: New file.
8722
8723 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8724
8725         * symfile.c (find_separate_debug_file): Look for separate debug
8726         files in debug directories under the sysroot.
8727
8728 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8729
8730         * symtab.h (struct minimal_symbol data_p): New const method.
8731         (struct minimal_symbol text_p): Likewise.
8732         * symtab.c (output_source_filename): Use file name style
8733         to print file name.
8734         (print_symbol_info): Likewise.
8735         (print_msymbol_info): Use address style to print addresses.
8736         Use function name style to print executable text symbols.
8737         (expand_symtab_containing_pc): Use data_p.
8738         (find_pc_sect_compunit_symtab): Likewise.
8739
8740 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8741
8742         * breakpoint.c (describe_other_breakpoints): Use address style
8743         to print addresses.
8744         (say_where): Likewise.
8745
8746 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8747
8748         * ada-typeprint.c (print_func_type): Print function name
8749         style to print function name.
8750         * c-typeprint.c (c_print_type_1): Likewise.
8751
8752 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8753
8754         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8755         for execve.
8756
8757 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8758
8759         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8760         type_stack.
8761
8762 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8763
8764         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8765         TYPE_CODE_REF types.
8766
8767 2019-02-08  Jim Wilson  <jimw@sifive.com>
8768
8769         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8770         (riscv_linux_fregset): New.
8771         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8772
8773 2019-02-07  Tom Tromey  <tom@tromey.com>
8774
8775         * thread.c (thread_cancel_execution_command): Update.
8776         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8777         methods.
8778         (struct thread_fsm_ops): Remove.
8779         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8780         (thread_fsm_should_stop, thread_fsm_return_value)
8781         (thread_fsm_set_finished, thread_fsm_finished_p)
8782         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8783         Don't declare.
8784         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8785         * infrun.c (clear_proceed_status_thread)
8786         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8787         (print_stop_event): Update.
8788         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8789         Add constructor.
8790         (step_command_fsm_ops): Remove.
8791         (new_step_command_fsm): Remove.
8792         (step_1): Update.
8793         (step_command_fsm::should_stop): Rename from
8794         step_command_fsm_should_stop.
8795         (step_command_fsm::clean_up): Rename from
8796         step_command_fsm_clean_up.
8797         (step_command_fsm::do_async_reply_reason): Rename from
8798         step_command_fsm_async_reply_reason.
8799         (struct until_next_fsm): Inherit from thread_fsm.  Add
8800         constructor.
8801         (until_next_fsm_ops): Remove.
8802         (new_until_next_fsm): Remove.
8803         (until_next_fsm::should_stop): Rename from
8804         until_next_fsm_should_stop.
8805         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8806         (until_next_fsm::do_async_reply_reason): Rename from
8807         until_next_fsm_async_reply_reason.
8808         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8809         constructor.  Change type of breakpoint.
8810         (finish_command_fsm_ops): Remove.
8811         (new_finish_command_fsm): Remove.
8812         (finish_command_fsm::should_stop): Rename from
8813         finish_command_fsm_should_stop.
8814         (finish_command_fsm::clean_up): Rename from
8815         finish_command_fsm_clean_up.
8816         (finish_command_fsm::return_value): Rename from
8817         finish_command_fsm_return_value.
8818         (finish_command_fsm::do_async_reply_reason): Rename from
8819         finish_command_fsm_async_reply_reason.
8820         (finish_command): Update.
8821         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8822         Add constructor.
8823         (call_thread_fsm_ops): Remove.
8824         (call_thread_fsm::call_thread_fsm): Rename from
8825         new_call_thread_fsm.
8826         (call_thread_fsm::should_stop): Rename from
8827         call_thread_fsm_should_stop.
8828         (call_thread_fsm::should_notify_stop): Rename from
8829         call_thread_fsm_should_notify_stop.
8830         (run_inferior_call, call_function_by_hand_dummy): Update.
8831         * cli/cli-interp.c (should_print_stop_to_console): Update.
8832         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8833         Add constructor.  Change type of location_breakpoint,
8834         caller_breakpoint.
8835         (until_break_fsm_ops): Remove.
8836         (new_until_break_fsm): Remove.
8837         (until_break_fsm::should_stop): Rename from
8838         until_break_fsm_should_stop.
8839         (until_break_fsm::clean_up): Rename from
8840         until_break_fsm_clean_up.
8841         (until_break_fsm::do_async_reply_reason): Rename from
8842         until_break_fsm_async_reply_reason.
8843         (until_break_command): Update.
8844         * thread-fsm.c: Remove.
8845         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8846
8847 2019-02-07  Tom Tromey  <tom@tromey.com>
8848
8849         * yy-remap.h: Add include guard.
8850         * xtensa-tdep.h: Add include guard.
8851         * xcoffread.h: Rename include guard.
8852         * varobj-iter.h: Add include guard.
8853         * tui/tui.h: Rename include guard.
8854         * tui/tui-winsource.h: Rename include guard.
8855         * tui/tui-wingeneral.h: Rename include guard.
8856         * tui/tui-windata.h: Rename include guard.
8857         * tui/tui-win.h: Rename include guard.
8858         * tui/tui-stack.h: Rename include guard.
8859         * tui/tui-source.h: Rename include guard.
8860         * tui/tui-regs.h: Rename include guard.
8861         * tui/tui-out.h: Rename include guard.
8862         * tui/tui-layout.h: Rename include guard.
8863         * tui/tui-io.h: Rename include guard.
8864         * tui/tui-hooks.h: Rename include guard.
8865         * tui/tui-file.h: Rename include guard.
8866         * tui/tui-disasm.h: Rename include guard.
8867         * tui/tui-data.h: Rename include guard.
8868         * tui/tui-command.h: Rename include guard.
8869         * tic6x-tdep.h: Add include guard.
8870         * target/waitstatus.h: Rename include guard.
8871         * target/wait.h: Rename include guard.
8872         * target/target.h: Rename include guard.
8873         * target/resume.h: Rename include guard.
8874         * target-float.h: Rename include guard.
8875         * stabsread.h: Add include guard.
8876         * rs6000-tdep.h: Add include guard.
8877         * riscv-fbsd-tdep.h: Add include guard.
8878         * regformats/regdef.h: Rename include guard.
8879         * record.h: Rename include guard.
8880         * python/python.h: Rename include guard.
8881         * python/python-internal.h: Rename include guard.
8882         * python/py-stopevent.h: Rename include guard.
8883         * python/py-ref.h: Rename include guard.
8884         * python/py-record.h: Rename include guard.
8885         * python/py-record-full.h: Rename include guard.
8886         * python/py-record-btrace.h: Rename include guard.
8887         * python/py-instruction.h: Rename include guard.
8888         * python/py-events.h: Rename include guard.
8889         * python/py-event.h: Rename include guard.
8890         * procfs.h: Add include guard.
8891         * proc-utils.h: Add include guard.
8892         * p-lang.h: Add include guard.
8893         * or1k-tdep.h: Rename include guard.
8894         * observable.h: Rename include guard.
8895         * nto-tdep.h: Rename include guard.
8896         * nat/x86-linux.h: Rename include guard.
8897         * nat/x86-linux-dregs.h: Rename include guard.
8898         * nat/x86-gcc-cpuid.h: Add include guard.
8899         * nat/x86-dregs.h: Rename include guard.
8900         * nat/x86-cpuid.h: Rename include guard.
8901         * nat/ppc-linux.h: Rename include guard.
8902         * nat/mips-linux-watch.h: Rename include guard.
8903         * nat/linux-waitpid.h: Rename include guard.
8904         * nat/linux-ptrace.h: Rename include guard.
8905         * nat/linux-procfs.h: Rename include guard.
8906         * nat/linux-osdata.h: Rename include guard.
8907         * nat/linux-nat.h: Rename include guard.
8908         * nat/linux-namespaces.h: Rename include guard.
8909         * nat/linux-btrace.h: Rename include guard.
8910         * nat/glibc_thread_db.h: Rename include guard.
8911         * nat/gdb_thread_db.h: Rename include guard.
8912         * nat/gdb_ptrace.h: Rename include guard.
8913         * nat/fork-inferior.h: Rename include guard.
8914         * nat/amd64-linux-siginfo.h: Rename include guard.
8915         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8916         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8917         * nat/aarch64-linux.h: Rename include guard.
8918         * nat/aarch64-linux-hw-point.h: Rename include guard.
8919         * mn10300-tdep.h: Add include guard.
8920         * mips-linux-tdep.h: Add include guard.
8921         * mi/mi-parse.h: Rename include guard.
8922         * mi/mi-out.h: Rename include guard.
8923         * mi/mi-main.h: Rename include guard.
8924         * mi/mi-interp.h: Rename include guard.
8925         * mi/mi-getopt.h: Rename include guard.
8926         * mi/mi-console.h: Rename include guard.
8927         * mi/mi-common.h: Rename include guard.
8928         * mi/mi-cmds.h: Rename include guard.
8929         * mi/mi-cmd-break.h: Rename include guard.
8930         * m2-lang.h: Add include guard.
8931         * location.h: Rename include guard.
8932         * linux-record.h: Rename include guard.
8933         * linux-nat.h: Add include guard.
8934         * linux-fork.h: Add include guard.
8935         * i386-darwin-tdep.h: Rename include guard.
8936         * hppa-linux-offsets.h: Add include guard.
8937         * guile/guile.h: Rename include guard.
8938         * guile/guile-internal.h: Rename include guard.
8939         * gnu-nat.h: Rename include guard.
8940         * gdb-stabs.h: Rename include guard.
8941         * frv-tdep.h: Add include guard.
8942         * f-lang.h: Add include guard.
8943         * event-loop.h: Add include guard.
8944         * darwin-nat.h: Rename include guard.
8945         * cp-abi.h: Rename include guard.
8946         * config/sparc/nm-sol2.h: Rename include guard.
8947         * config/nm-nto.h: Rename include guard.
8948         * config/nm-linux.h: Add include guard.
8949         * config/i386/nm-i386gnu.h: Rename include guard.
8950         * config/djgpp/nl_types.h: Rename include guard.
8951         * config/djgpp/langinfo.h: Rename include guard.
8952         * compile/gcc-cp-plugin.h: Add include guard.
8953         * compile/gcc-c-plugin.h: Add include guard.
8954         * compile/compile.h: Rename include guard.
8955         * compile/compile-object-run.h: Rename include guard.
8956         * compile/compile-object-load.h: Rename include guard.
8957         * compile/compile-internal.h: Rename include guard.
8958         * compile/compile-cplus.h: Rename include guard.
8959         * compile/compile-c.h: Rename include guard.
8960         * common/xml-utils.h: Rename include guard.
8961         * common/x86-xstate.h: Rename include guard.
8962         * common/version.h: Rename include guard.
8963         * common/vec.h: Rename include guard.
8964         * common/tdesc.h: Rename include guard.
8965         * common/selftest.h: Rename include guard.
8966         * common/scoped_restore.h: Rename include guard.
8967         * common/scoped_mmap.h: Rename include guard.
8968         * common/scoped_fd.h: Rename include guard.
8969         * common/safe-iterator.h: Rename include guard.
8970         * common/run-time-clock.h: Rename include guard.
8971         * common/refcounted-object.h: Rename include guard.
8972         * common/queue.h: Rename include guard.
8973         * common/ptid.h: Rename include guard.
8974         * common/print-utils.h: Rename include guard.
8975         * common/preprocessor.h: Rename include guard.
8976         * common/pathstuff.h: Rename include guard.
8977         * common/observable.h: Rename include guard.
8978         * common/netstuff.h: Rename include guard.
8979         * common/job-control.h: Rename include guard.
8980         * common/host-defs.h: Rename include guard.
8981         * common/gdb_wait.h: Rename include guard.
8982         * common/gdb_vecs.h: Rename include guard.
8983         * common/gdb_unlinker.h: Rename include guard.
8984         * common/gdb_unique_ptr.h: Rename include guard.
8985         * common/gdb_tilde_expand.h: Rename include guard.
8986         * common/gdb_sys_time.h: Rename include guard.
8987         * common/gdb_string_view.h: Rename include guard.
8988         * common/gdb_splay_tree.h: Rename include guard.
8989         * common/gdb_setjmp.h: Rename include guard.
8990         * common/gdb_ref_ptr.h: Rename include guard.
8991         * common/gdb_optional.h: Rename include guard.
8992         * common/gdb_locale.h: Rename include guard.
8993         * common/gdb_assert.h: Rename include guard.
8994         * common/filtered-iterator.h: Rename include guard.
8995         * common/filestuff.h: Rename include guard.
8996         * common/fileio.h: Rename include guard.
8997         * common/environ.h: Rename include guard.
8998         * common/common-utils.h: Rename include guard.
8999         * common/common-types.h: Rename include guard.
9000         * common/common-regcache.h: Rename include guard.
9001         * common/common-inferior.h: Rename include guard.
9002         * common/common-gdbthread.h: Rename include guard.
9003         * common/common-exceptions.h: Rename include guard.
9004         * common/common-defs.h: Rename include guard.
9005         * common/common-debug.h: Rename include guard.
9006         * common/cleanups.h: Rename include guard.
9007         * common/buffer.h: Rename include guard.
9008         * common/btrace-common.h: Rename include guard.
9009         * common/break-common.h: Rename include guard.
9010         * cli/cli-utils.h: Rename include guard.
9011         * cli/cli-style.h: Rename include guard.
9012         * cli/cli-setshow.h: Rename include guard.
9013         * cli/cli-script.h: Rename include guard.
9014         * cli/cli-interp.h: Rename include guard.
9015         * cli/cli-decode.h: Rename include guard.
9016         * cli/cli-cmds.h: Rename include guard.
9017         * charset-list.h: Add include guard.
9018         * buildsym-legacy.h: Rename include guard.
9019         * bfin-tdep.h: Add include guard.
9020         * ax.h: Rename include guard.
9021         * arm-linux-tdep.h: Add include guard.
9022         * arm-fbsd-tdep.h: Add include guard.
9023         * arch/xtensa.h: Rename include guard.
9024         * arch/tic6x.h: Add include guard.
9025         * arch/i386.h: Add include guard.
9026         * arch/arm.h: Rename include guard.
9027         * arch/arm-linux.h: Rename include guard.
9028         * arch/arm-get-next-pcs.h: Rename include guard.
9029         * arch/amd64.h: Add include guard.
9030         * arch/aarch64-insn.h: Rename include guard.
9031         * arch-utils.h: Rename include guard.
9032         * annotate.h: Add include guard.
9033         * amd64-darwin-tdep.h: Rename include guard.
9034         * aarch64-linux-tdep.h: Add include guard.
9035         * aarch64-fbsd-tdep.h: Add include guard.
9036         * aarch32-linux-nat.h: Add include guard.
9037
9038 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9039
9040         * macrotab.c (macro_define_internal): New function that
9041         factorizes macro_define_object_internal and macro_define_function
9042         code.
9043         (macro_define_object_internal): Use macro_define_internal.
9044         (macro_define_function): Likewise.
9045
9046 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9047
9048         * macrocmd.c (extract_identifier): Return
9049         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9050         callers.
9051
9052 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9053
9054         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9055
9056 2019-02-05  Tom Tromey  <tom@tromey.com>
9057
9058         * target.c (target_stack::unpush): Move assertion earlier.
9059
9060 2019-01-30  Tom Tromey  <tom@tromey.com>
9061
9062         PR python/23615:
9063         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9064         (gdbpy_parse_and_eval): Likewise.
9065         * python/python-internal.h (gdbpy_allow_threads): New class.
9066
9067 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9068
9069         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9070         (aarch64_fbsd_fpregmap): Move earlier.
9071         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9072         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9073         instead of individual calls to trad_frame_set_reg_addr.
9074         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9075         earlier.
9076         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9077         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9078         instead of individual calls to trad_frame_set_reg_addr.
9079
9080 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9081
9082         * CONTRIBUTE: Replace contribution list with wiki link.
9083
9084 2019-01-25  Tom Tromey  <tom@tromey.com>
9085
9086         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9087
9088 2019-01-25  Tom Tromey  <tom@tromey.com>
9089
9090         * xtensa-linux-nat.c: Fix common/ includes.
9091         * xml-support.h: Fix common/ includes.
9092         * xml-support.c: Fix common/ includes.
9093         * x86-linux-nat.c: Fix common/ includes.
9094         * windows-nat.c: Fix common/ includes.
9095         * varobj.h: Fix common/ includes.
9096         * varobj.c: Fix common/ includes.
9097         * value.c: Fix common/ includes.
9098         * valops.c: Fix common/ includes.
9099         * utils.c: Fix common/ includes.
9100         * unittests/xml-utils-selftests.c: Fix common/ includes.
9101         * unittests/utils-selftests.c: Fix common/ includes.
9102         * unittests/unpack-selftests.c: Fix common/ includes.
9103         * unittests/tracepoint-selftests.c: Fix common/ includes.
9104         * unittests/style-selftests.c: Fix common/ includes.
9105         * unittests/string_view-selftests.c: Fix common/ includes.
9106         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9107         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9108         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9109         * unittests/rsp-low-selftests.c: Fix common/ includes.
9110         * unittests/parse-connection-spec-selftests.c: Fix common/
9111         includes.
9112         * unittests/optional-selftests.c: Fix common/ includes.
9113         * unittests/offset-type-selftests.c: Fix common/ includes.
9114         * unittests/observable-selftests.c: Fix common/ includes.
9115         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9116         * unittests/memrange-selftests.c: Fix common/ includes.
9117         * unittests/memory-map-selftests.c: Fix common/ includes.
9118         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9119         * unittests/function-view-selftests.c: Fix common/ includes.
9120         * unittests/environ-selftests.c: Fix common/ includes.
9121         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9122         * unittests/common-utils-selftests.c: Fix common/ includes.
9123         * unittests/cli-utils-selftests.c: Fix common/ includes.
9124         * unittests/array-view-selftests.c: Fix common/ includes.
9125         * ui-file.c: Fix common/ includes.
9126         * tui/tui-io.c: Fix common/ includes.
9127         * tracepoint.h: Fix common/ includes.
9128         * tracepoint.c: Fix common/ includes.
9129         * tracefile-tfile.c: Fix common/ includes.
9130         * top.h: Fix common/ includes.
9131         * top.c: Fix common/ includes.
9132         * thread.c: Fix common/ includes.
9133         * target/waitstatus.h: Fix common/ includes.
9134         * target/waitstatus.c: Fix common/ includes.
9135         * target.h: Fix common/ includes.
9136         * target.c: Fix common/ includes.
9137         * target-memory.c: Fix common/ includes.
9138         * target-descriptions.c: Fix common/ includes.
9139         * symtab.h: Fix common/ includes.
9140         * symfile.c: Fix common/ includes.
9141         * stap-probe.c: Fix common/ includes.
9142         * spu-linux-nat.c: Fix common/ includes.
9143         * sparc-nat.c: Fix common/ includes.
9144         * source.c: Fix common/ includes.
9145         * solib.c: Fix common/ includes.
9146         * solib-target.c: Fix common/ includes.
9147         * ser-unix.c: Fix common/ includes.
9148         * ser-tcp.c: Fix common/ includes.
9149         * ser-pipe.c: Fix common/ includes.
9150         * ser-base.c: Fix common/ includes.
9151         * selftest-arch.c: Fix common/ includes.
9152         * s12z-tdep.c: Fix common/ includes.
9153         * rust-exp.y: Fix common/ includes.
9154         * rs6000-aix-tdep.c: Fix common/ includes.
9155         * riscv-tdep.c: Fix common/ includes.
9156         * remote.c: Fix common/ includes.
9157         * remote-notif.h: Fix common/ includes.
9158         * remote-fileio.h: Fix common/ includes.
9159         * remote-fileio.c: Fix common/ includes.
9160         * regcache.h: Fix common/ includes.
9161         * regcache.c: Fix common/ includes.
9162         * record-btrace.c: Fix common/ includes.
9163         * python/python.c: Fix common/ includes.
9164         * python/py-type.c: Fix common/ includes.
9165         * python/py-inferior.c: Fix common/ includes.
9166         * progspace.h: Fix common/ includes.
9167         * producer.c: Fix common/ includes.
9168         * procfs.c: Fix common/ includes.
9169         * proc-api.c: Fix common/ includes.
9170         * printcmd.c: Fix common/ includes.
9171         * ppc-linux-nat.c: Fix common/ includes.
9172         * parser-defs.h: Fix common/ includes.
9173         * osdata.c: Fix common/ includes.
9174         * obsd-nat.c: Fix common/ includes.
9175         * nat/x86-linux.c: Fix common/ includes.
9176         * nat/x86-linux-dregs.c: Fix common/ includes.
9177         * nat/x86-dregs.h: Fix common/ includes.
9178         * nat/x86-dregs.c: Fix common/ includes.
9179         * nat/ppc-linux.c: Fix common/ includes.
9180         * nat/mips-linux-watch.h: Fix common/ includes.
9181         * nat/mips-linux-watch.c: Fix common/ includes.
9182         * nat/linux-waitpid.c: Fix common/ includes.
9183         * nat/linux-ptrace.h: Fix common/ includes.
9184         * nat/linux-ptrace.c: Fix common/ includes.
9185         * nat/linux-procfs.c: Fix common/ includes.
9186         * nat/linux-personality.c: Fix common/ includes.
9187         * nat/linux-osdata.c: Fix common/ includes.
9188         * nat/linux-namespaces.c: Fix common/ includes.
9189         * nat/linux-btrace.h: Fix common/ includes.
9190         * nat/linux-btrace.c: Fix common/ includes.
9191         * nat/fork-inferior.c: Fix common/ includes.
9192         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9193         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9194         * nat/aarch64-linux.c: Fix common/ includes.
9195         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9196         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9197         * namespace.h: Fix common/ includes.
9198         * mips-linux-tdep.c: Fix common/ includes.
9199         * minsyms.c: Fix common/ includes.
9200         * mi/mi-parse.h: Fix common/ includes.
9201         * mi/mi-main.c: Fix common/ includes.
9202         * mi/mi-cmd-env.c: Fix common/ includes.
9203         * memrange.h: Fix common/ includes.
9204         * memattr.c: Fix common/ includes.
9205         * maint.h: Fix common/ includes.
9206         * maint.c: Fix common/ includes.
9207         * main.c: Fix common/ includes.
9208         * machoread.c: Fix common/ includes.
9209         * location.c: Fix common/ includes.
9210         * linux-thread-db.c: Fix common/ includes.
9211         * linux-nat.c: Fix common/ includes.
9212         * linux-fork.c: Fix common/ includes.
9213         * inline-frame.c: Fix common/ includes.
9214         * infrun.c: Fix common/ includes.
9215         * inflow.c: Fix common/ includes.
9216         * inferior.h: Fix common/ includes.
9217         * inferior.c: Fix common/ includes.
9218         * infcmd.c: Fix common/ includes.
9219         * inf-ptrace.c: Fix common/ includes.
9220         * inf-child.c: Fix common/ includes.
9221         * ia64-linux-nat.c: Fix common/ includes.
9222         * i387-tdep.c: Fix common/ includes.
9223         * i386-tdep.c: Fix common/ includes.
9224         * i386-linux-tdep.c: Fix common/ includes.
9225         * i386-linux-nat.c: Fix common/ includes.
9226         * i386-go32-tdep.c: Fix common/ includes.
9227         * i386-fbsd-tdep.c: Fix common/ includes.
9228         * i386-fbsd-nat.c: Fix common/ includes.
9229         * guile/scm-type.c: Fix common/ includes.
9230         * guile/guile.c: Fix common/ includes.
9231         * go32-nat.c: Fix common/ includes.
9232         * gnu-nat.c: Fix common/ includes.
9233         * gdbthread.h: Fix common/ includes.
9234         * gdbarch-selftests.c: Fix common/ includes.
9235         * gdb_usleep.c: Fix common/ includes.
9236         * gdb_select.h: Fix common/ includes.
9237         * gdb_bfd.c: Fix common/ includes.
9238         * gcore.c: Fix common/ includes.
9239         * fork-child.c: Fix common/ includes.
9240         * findvar.c: Fix common/ includes.
9241         * fbsd-nat.c: Fix common/ includes.
9242         * event-top.c: Fix common/ includes.
9243         * event-loop.c: Fix common/ includes.
9244         * dwarf2read.c: Fix common/ includes.
9245         * dwarf2loc.c: Fix common/ includes.
9246         * dwarf2-frame.c: Fix common/ includes.
9247         * dwarf-index-cache.c: Fix common/ includes.
9248         * dtrace-probe.c: Fix common/ includes.
9249         * disasm-selftests.c: Fix common/ includes.
9250         * defs.h: Fix common/ includes.
9251         * csky-tdep.c: Fix common/ includes.
9252         * cp-valprint.c: Fix common/ includes.
9253         * cp-support.h: Fix common/ includes.
9254         * cp-support.c: Fix common/ includes.
9255         * corelow.c: Fix common/ includes.
9256         * completer.h: Fix common/ includes.
9257         * completer.c: Fix common/ includes.
9258         * compile/compile.c: Fix common/ includes.
9259         * compile/compile-loc2c.c: Fix common/ includes.
9260         * compile/compile-cplus-types.c: Fix common/ includes.
9261         * compile/compile-cplus-symbols.c: Fix common/ includes.
9262         * command.h: Fix common/ includes.
9263         * cli/cli-dump.c: Fix common/ includes.
9264         * cli/cli-cmds.c: Fix common/ includes.
9265         * charset.c: Fix common/ includes.
9266         * build-id.c: Fix common/ includes.
9267         * btrace.h: Fix common/ includes.
9268         * btrace.c: Fix common/ includes.
9269         * breakpoint.h: Fix common/ includes.
9270         * breakpoint.c: Fix common/ includes.
9271         * ax.h:
9272         (enum agent_op): Fix common/ includes.
9273         * ax-general.c (struct aop_map): Fix common/ includes.
9274         * ax-gdb.c: Fix common/ includes.
9275         * auxv.c: Fix common/ includes.
9276         * auto-load.c: Fix common/ includes.
9277         * arm-tdep.c: Fix common/ includes.
9278         * arch/riscv.c: Fix common/ includes.
9279         * arch/ppc-linux-common.c: Fix common/ includes.
9280         * arch/i386.c: Fix common/ includes.
9281         * arch/arm.c: Fix common/ includes.
9282         * arch/arm-linux.c: Fix common/ includes.
9283         * arch/arm-get-next-pcs.c: Fix common/ includes.
9284         * arch/amd64.c: Fix common/ includes.
9285         * arch/aarch64.c: Fix common/ includes.
9286         * arch/aarch64-insn.c: Fix common/ includes.
9287         * arch-utils.c: Fix common/ includes.
9288         * amd64-windows-tdep.c: Fix common/ includes.
9289         * amd64-tdep.c: Fix common/ includes.
9290         * amd64-sol2-tdep.c: Fix common/ includes.
9291         * amd64-obsd-tdep.c: Fix common/ includes.
9292         * amd64-nbsd-tdep.c: Fix common/ includes.
9293         * amd64-linux-tdep.c: Fix common/ includes.
9294         * amd64-linux-nat.c: Fix common/ includes.
9295         * amd64-fbsd-tdep.c: Fix common/ includes.
9296         * amd64-fbsd-nat.c: Fix common/ includes.
9297         * amd64-dicos-tdep.c: Fix common/ includes.
9298         * amd64-darwin-tdep.c: Fix common/ includes.
9299         * agent.c: Fix common/ includes.
9300         * ada-lang.h: Fix common/ includes.
9301         * ada-lang.c: Fix common/ includes.
9302         * aarch64-tdep.c: Fix common/ includes.
9303
9304 2019-01-25  Tom Tromey  <tom@tromey.com>
9305
9306         * common/create-version.sh: Use common/version.h.
9307
9308 2019-01-24  Pedro Alves  <palves@redhat.com>
9309
9310         * infrun.c (signal_stop, signal_print, signal_program)
9311         (signal_catch, signal_pass): Now arrays instead of pointers.
9312         (update_signals_program_target, do_target_resume)
9313         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9314         * linux-nat.c (linux_nat_target::pass_signals)
9315         (linux_nat_target::create_inferior, linux_nat_target::attach):
9316         Adjust.
9317         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9318         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9319         * procfs.c (procfs_target::pass_signals): Adjust.
9320         * record-full.c (record_full_target::resume): Adjust.
9321         * remote.c (remote_target::pass_signals)
9322         (remote_target::program_signals): Adjust.
9323         * target-debug.h (target_debug_print_signals): Now takes a
9324         gdb::array_view as parameter.  Adjust.
9325         * target.h (target_ops) <pass_signals, program_signals>: Replace
9326         pointer and length parameters with gdb::array_view.
9327         (target_pass_signals, target_program_signals): Likewise.
9328         * target-delegates.c: Regenerate.
9329
9330 2019-01-24  Pedro Alves  <palves@redhat.com>
9331
9332         * common/forward-scope-exit.h
9333         (forward_scope_exit::forward_scope_exit): Pass arguments to
9334         m_bind_function directly, instead of creating a std::bind and
9335         copying that.
9336
9337 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9338
9339         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9340         for static members.
9341         (pass_in_v_vfp_candidate): Likewise.
9342
9343 2019-01-23  Tom Tromey  <tom@tromey.com>
9344             Pedro Alves  <palves@redhat.com>
9345
9346         * regcache.c (class regcache_invalidator): Remove.
9347         (regcache::raw_write): Use make_scope_exit.
9348
9349 2019-01-23  Tom Tromey  <tom@tromey.com>
9350
9351         * ui-out.h (class ui_out_emit_type): Update comment.
9352
9353 2019-01-23  Tom Tromey  <tom@tromey.com>
9354
9355         * infrun.c (fetch_inferior_event): Update comment.
9356
9357 2019-01-23  Tom Tromey  <tom@tromey.com>
9358             Pedro Alves  <palves@redhat.com>
9359
9360         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9361         parameter.
9362         (fetch_inferior_event): Use SCOPE_EXIT.
9363
9364
9365 2019-01-23  Tom Tromey  <tom@tromey.com>
9366             Pedro Alves  <palves@redhat.com>
9367
9368         * infrun.c (disable_thread_events): Delete.
9369         (stop_all_threads): Use SCOPE_EXIT.
9370
9371 2019-01-23  Tom Tromey  <tom@tromey.com>
9372             Pedro Alves  <palves@redhat.com>
9373
9374         * symfile.c: Include forward-scope-exit.h.
9375         (clear_symtab_users_cleanup): Replace forward declaration with
9376         a FORWARD_SCOPE_EXIT.
9377         (syms_from_objfile_1): Use the forward_scope_exit and
9378         gdb::optional instead of cleanup_function.
9379         (reread_symbols): Use the forward_scope_exit instead of
9380         cleanup_function.
9381         (clear_symtab_users_cleanup): Remove function.
9382
9383 2019-01-23  Tom Tromey  <tom@tromey.com>
9384             Pedro Alves  <palves@redhat.com>
9385
9386         * linux-nat.c: Include scope-exit.h.
9387         (cleanup_target_stop): Remove.
9388         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9389         SCOPE_EXIT.
9390
9391 2019-01-23  Tom Tromey  <tom@tromey.com>
9392             Pedro Alves  <palves@redhat.com>
9393
9394         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9395         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9396
9397 2019-01-23  Tom Tromey  <tom@tromey.com>
9398             Andrew Burgess  <andrew.burgess@embecosm.com>
9399             Pedro Alves  <palves@redhat.com>
9400
9401         * infrun.c (fetch_inferior_event): Use scope_exit.
9402         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9403         * top.c (execute_command): Use scope_exit.
9404         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9405         * utils.c (do_bpstat_clear_actions_cleanup)
9406         (make_bpstat_clear_actions_cleanup): Remove.
9407
9408 2019-01-23  Tom Tromey  <tom@tromey.com>
9409             Pedro Alves  <palves@redhat.com>
9410
9411         * infrun.c: Include "common/scope-exit.h"
9412         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9413         (wait_for_inferior): Use SCOPE_EXIT.
9414         (fetch_inferior_event): Use scope_exit.
9415
9416 2019-01-23  Tom Tromey  <tom@tromey.com>
9417             Pedro Alves  <palves@redhat.com>
9418
9419         * breakpoint.c (create_breakpoint): Remove cleanup.
9420
9421 2019-01-23  Tom Tromey  <tom@tromey.com>
9422             Andrew Burgess  <andrew.burgess@embecosm.com>
9423             Pedro Alves  <palves@redhat.com>
9424
9425 2019-01-23  Pedro Alves  <palves@redhat.com>
9426
9427         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9428
9429 2019-01-23  Pedro Alves  <palves@redhat.com>
9430             Andrew Burgess  <andrew.burgess@embecosm.com>
9431
9432         * gdbthread.h: Include "common/forward-scope-exit.h".
9433         (scoped_finish_thread_state): Redefine custom class in terms of
9434         forward_scope_exit.
9435
9436 2019-01-23  Pedro Alves  <palves@redhat.com>
9437             Andrew Burgess  <andrew.burgess@embecosm.com>
9438
9439         * common/forward-scope-exit.h: New file.
9440
9441 2019-01-23  Pedro Alves  <palves@redhat.com>
9442             Andrew Burgess  <andrew.burgess@embecosm.com>
9443             Tom Tromey  <tom@tromey.com>
9444
9445         * common/scope-exit.h: New file.
9446
9447 2019-01-23  Pedro Alves  <palves@redhat.com>
9448
9449         * common/preprocessor.h (ESC): Rename to ...
9450         (ESC_PARENS): ... this.
9451         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9452         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9453
9454 2019-01-23  Tom Tromey  <tom@tromey.com>
9455
9456         * language.h (class scoped_switch_to_sym_language_if_auto):
9457         Initialize m_lang in both cases.
9458
9459 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9460
9461         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9462         with XCNEW.
9463
9464 2019-01-22  Tom Tromey  <tom@tromey.com>
9465
9466         * corelow.c: Do not include sys/file.h.
9467
9468 2019-01-22  Tom Tromey  <tom@tromey.com>
9469
9470         * tui/tui-wingeneral.h: Include gdb_curses.h.
9471
9472 2019-01-22  Tom Tromey  <tom@tromey.com>
9473
9474         * source-cache.h (class source_cache) <get_source_lines,
9475         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9476
9477 2019-01-22  Tom Tromey  <tom@tromey.com>
9478
9479         * remote-fileio.h (struct remote_target): Declare.
9480
9481 2019-01-22  Tom Tromey  <tom@tromey.com>
9482
9483         * python/py-arch.c: Do not include py-ref.h.
9484         * python/py-bpevent.c: Do not include py-ref.h.
9485         * python/py-cmd.c: Do not include py-ref.h.
9486         * python/py-continueevent.c: Do not include py-ref.h.
9487         * python/py-event.h: Do not include py-ref.h.
9488         * python/py-evtregistry.c: Do not include py-ref.h.
9489         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9490         * python/py-frame.c: Do not include py-ref.h.
9491         * python/py-framefilter.c: Do not include py-ref.h.
9492         * python/py-function.c: Do not include py-ref.h.
9493         * python/py-infevents.c: Do not include py-ref.h.
9494         * python/py-linetable.c: Do not include py-ref.h.
9495         * python/py-objfile.c: Do not include py-ref.h.
9496         * python/py-param.c: Do not include py-ref.h.
9497         * python/py-prettyprint.c: Do not include py-ref.h.
9498         * python/py-progspace.c: Do not include py-ref.h.
9499         * python/py-symbol.c: Do not include py-ref.h.
9500         * python/py-symtab.c: Do not include py-ref.h.
9501         * python/py-type.c: Do not include py-ref.h.
9502         * python/py-unwind.c: Do not include py-ref.h.
9503         * python/py-utils.c: Do not include py-ref.h.
9504         * python/py-value.c: Do not include py-ref.h.
9505         * python/py-varobj.c: Do not include py-ref.h.
9506         * python/py-xmethods.c: Do not include py-ref.h.
9507         * python/python.c: Do not include py-ref.h.
9508         * varobj.c: Do not include py-ref.h.
9509
9510 2019-01-22  Tom Tromey  <tom@tromey.com>
9511
9512         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9513         keyword for bcache.
9514
9515 2019-01-22  Tom Tromey  <tom@tromey.com>
9516
9517         * compile/compile-cplus-types.c: Remove a comment by #include.
9518
9519 2019-01-22  Tom Tromey  <tom@tromey.com>
9520
9521         * compile/gcc-c-plugin.h: Include compile-internal.h.
9522
9523 2019-01-22  Tom Tromey  <tom@tromey.com>
9524
9525         * stabsread.c (EXTERN): Do not define.
9526         (symnum, next_symbol_text_func, processing_gcc_compilation)
9527         (within_function, global_sym_chain, global_stabs)
9528         (previous_stab_code, this_object_header_files)
9529         (n_this_object_header_files)
9530         (n_allocated_this_object_header_files): Define.
9531         * stabsread.h (EXTERN): Never define.  Use "extern".
9532
9533 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9534
9535         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9536         history_value.
9537
9538 2019-01-21  Tom Tromey  <tom@tromey.com>
9539
9540         * ui-out.c: Fix includes.
9541         * tui/tui-source.c: Fix includes.
9542         * target.c: Fix includes.
9543         * remote.c: Fix includes.
9544         * regcache.c: Fix includes.
9545         * python/py-block.c: Fix includes.
9546         * printcmd.c: Fix includes.
9547         * or1k-tdep.c: Fix includes.
9548         * mi/mi-main.c: Fix includes.
9549         * m32r-tdep.c: Fix includes.
9550         * csky-tdep.c: Fix includes.
9551         * compile/compile-cplus-types.c: Fix includes.
9552         * cli/cli-interp.c: Fix includes.
9553
9554 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9555
9556         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9557         for padding.
9558
9559 2019-01-16  Tom Tromey  <tom@tromey.com>
9560
9561         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9562         earlier.
9563         (struct objfile) <msymbols_range>: Move from top level.
9564         <msymbols>: New method.
9565         (class objfile_msymbols): Remove.
9566         * symtab.c (default_collect_symbol_completion_matches_break_on):
9567         Update.
9568         * symmisc.c (dump_msymbols): Update.
9569         * stabsread.c (scan_file_globals): Update.
9570         * objc-lang.c (info_selectors_command, info_classes_command)
9571         (find_methods): Update.
9572         * minsyms.c (find_solib_trampoline_target): Update.
9573         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9574         * coffread.c (coff_symfile_read): Update.
9575         * ada-lang.c (ada_lookup_simple_minsym)
9576         (ada_collect_symbol_completion_matches): Update.
9577
9578 2019-01-16  Tom Tromey  <tom@tromey.com>
9579
9580         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9581         type.  Remove no-argument constructor.
9582         <iterator::operator++>: Simplify.
9583         <begin>: Update.
9584         <end>: Use minimal_symbol_count.
9585
9586 2019-01-16  Tom Tromey  <tom@tromey.com>
9587
9588         * objfiles.h (struct objfile) <psymtabs>: New method.
9589         (class objfile_psymtabs): Remove.
9590         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9591         typedef.
9592         <range>: New method.
9593         (require_partial_symbols): Change return type.
9594         * psymtab.c (require_partial_symbols)
9595         (psym_expand_symtabs_matching): Update.
9596         * mdebugread.c (parse_partial_symbols): Update.
9597         * dbxread.c (dbx_end_psymtab): Update.
9598
9599 2019-01-15  Tom Tromey  <tom@tromey.com>
9600
9601         * symtab.c (lookup_objfile_from_block)
9602         (lookup_symbol_in_objfile_symtabs)
9603         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9604         (find_line_symtab, info_sources_command)
9605         (default_collect_symbol_completion_matches_break_on)
9606         (make_source_files_completion_list): Update.
9607         * symmisc.c (print_objfile_statistics, dump_objfile)
9608         (maintenance_print_symbols, maintenance_info_symtabs)
9609         (maintenance_check_symtabs, maintenance_info_line_tables):
9610         Update.
9611         * source.c (select_source_symtab)
9612         (forget_cached_source_info_for_objfile): Update.
9613         * objfiles.h (class objfile_compunits): Remove.
9614         (struct objfile) <compunits_range>: New typedef.
9615         (compunits): New method.
9616         * objfiles.c (objfile_relocate1): Update.
9617         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9618         * maint.c (count_symtabs_and_blocks): Update.
9619         * linespec.c (iterate_over_all_matching_symtabs): Update.
9620         * cp-support.c (add_symbol_overload_list_qualified): Update.
9621         * coffread.c (coff_symtab_read): Update.
9622         * ada-lang.c (add_nonlocal_symbols)
9623         (ada_collect_symbol_completion_matches)
9624         (ada_add_global_exceptions): Update.
9625
9626 2019-01-15  Tom Tromey  <tom@tromey.com>
9627
9628         * progspace.h (program_space) <objfiles_safe_range>: New
9629         typedef.
9630         <objfiles_safe>: New method.
9631         * objfiles.h (class all_objfiles_safe): Remove.
9632         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9633         * jit.c (jit_inferior_exit_hook): Update.
9634
9635 2019-01-17  Tom Tromey  <tom@tromey.com>
9636
9637         * progspace.h (program_space) <objfiles_range>: New typedef.
9638         <objfiles>: New method.
9639         <objfiles_head>: Rename from objfiles.
9640         (object_files): Update.
9641         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9642         * guile/scm-pretty-print.c
9643         (ppscm_find_pretty_printer_from_objfiles): Update.
9644         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9645         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9646         Update.
9647         * python/py-progspace.c (pspy_get_objfiles): Update.
9648         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9649         Update.
9650         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9651         (objfpy_lookup_objfile_by_build_id): Update.
9652         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9653         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9654         Update.
9655         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9656         (expand_symtab_containing_pc, lookup_objfile_from_block)
9657         (lookup_static_symbol, basic_lookup_transparent_type)
9658         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9659         (find_line_symtab, info_sources_command)
9660         (default_collect_symbol_completion_matches_break_on)
9661         (make_source_files_completion_list, find_main_name): Update.
9662         * symmisc.c (print_symbol_bcache_statistics)
9663         (print_objfile_statistics, maintenance_print_symbols)
9664         (maintenance_print_msymbols, maintenance_print_objfiles)
9665         (maintenance_info_symtabs, maintenance_check_symtabs)
9666         (maintenance_expand_symtabs, maintenance_info_line_tables):
9667         Update.
9668         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9669         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9670         (map_overlay_command, unmap_overlay_command)
9671         (simple_overlay_update, expand_symtabs_matching)
9672         (map_symbol_filenames): Update.
9673         * symfile-debug.c (set_debug_symfile): Update.
9674         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9675         Update.
9676         * source.c (select_source_symtab, forget_cached_source_info):
9677         Update.
9678         * solib.c (solib_read_symbols): Update.
9679         * solib-spu.c (append_ocl_sos): Update.
9680         * psymtab.c (maintenance_print_psymbols)
9681         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9682         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9683         * printcmd.c (info_symbol_command): Update.
9684         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9685         Update.
9686         * objfiles.h (class all_objfiles): Remove.
9687         * objfiles.c (have_partial_symbols, have_full_symbols)
9688         (have_minimal_symbols, qsort_cmp, update_section_map)
9689         (shared_objfile_contains_address_p)
9690         (default_iterate_over_objfiles_in_search_order): Update.
9691         * objc-lang.c (info_selectors_command, info_classes_command)
9692         (find_methods): Update.
9693         * minsyms.c (find_solib_trampoline_target): Update.
9694         * maint.c (maintenance_info_sections)
9695         (maintenance_translate_address, count_symtabs_and_blocks):
9696         Update.
9697         * main.c (captured_main_1): Update.
9698         * linux-thread-db.c (try_thread_db_load_from_pdir)
9699         (has_libpthread): Update.
9700         * linespec.c (iterate_over_all_matching_symtabs)
9701         (search_minsyms_for_name): Update.
9702         * jit.c (jit_find_objf_with_entry_addr): Update.
9703         * hppa-tdep.c (find_unwind_entry)
9704         (hppa_lookup_stub_minimal_symbol): Update.
9705         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9706         Update.
9707         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9708         (elf_gnu_ifunc_resolve_by_got): Update.
9709         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9710         * dwarf-index-write.c (save_gdb_index_command): Update.
9711         * cp-support.c (add_symbol_overload_list_qualified): Update.
9712         * breakpoint.c (create_overlay_event_breakpoint)
9713         (create_longjmp_master_breakpoint)
9714         (create_std_terminate_master_breakpoint)
9715         (create_exception_master_breakpoint): Update.
9716         * blockframe.c (find_pc_partial_function): Update.
9717         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9718         (ada_collect_symbol_completion_matches)
9719         (ada_add_global_exceptions): Update.
9720
9721 2019-01-17  Tom Tromey  <tom@tromey.com>
9722
9723         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9724         declare VEC.
9725         (solib_target_parse_libraries): Change return type.
9726         (library_list_start_segment, library_list_start_section)
9727         (library_list_end_library, library_list_start_library); Update.
9728         (solib_target_free_library_list): Remove.
9729         (solib_target_parse_libraries): Remove cleanup.  Change return
9730         type.
9731         (solib_target_current_sos): Update.
9732
9733 2019-01-17  Tom Tromey  <tromey@bapiya>
9734
9735         * valprint.c: Replace "the the" with "the".
9736         * symtab.c: Replace "the the" with "the".
9737         * solib.c: Replace "the the" with "the".
9738         * solib-dsbt.c: Replace "the the" with "the".
9739         * linespec.c: Replace "the the" with "the".
9740         * dwarf2loc.h: Replace "the the" with "the".
9741         * amd64-windows-tdep.c: Replace "the the" with "the".
9742         * aarch64-tdep.c: Replace "the the" with "the".
9743
9744 2019-01-16  Keith Seitz  <keiths@redhat.com>
9745
9746         PR gdb/23773
9747         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9748         <builder>: Rename to ..
9749         <m_builder>: ... this and make private.
9750         (dwarf2_cu::get_builder): New method.  Change all users of
9751         `builder' to use this method.
9752         (dwarf2_start_symtab): Move to ...
9753         (dwarf2_cu::start_symtab): ... here.  Update all callers
9754         (setup_type_unit_groups): Move to ...
9755         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9756         callers.
9757         (dwarf2_cu::reset_builder): New method.
9758         (process_full_compunit, process_full_type_unit): Use
9759         dwarf2_cu::reset_builder.
9760         (follow_die_offset): Record the ancestor CU if it is different
9761         from the followed DIE's CU.
9762         (follow_die_sig_1): Likewise.
9763
9764 2019-01-15  Tom Tromey  <tom@tromey.com>
9765
9766         * remote.c (class remote_state) <buf>: Now a char_vector.
9767         <buf_size>: Remove.
9768         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9769         parameter.
9770         (remote_target::getpkt_or_notif_sane_1)
9771         (remote_target::getpkt_sane)
9772         (remote_target::getpkt_or_notif_sane): Likewise.
9773         (class remote_target) <putpkt>: New overload.
9774         (remote_target::read_frame): Change type of "buf_p".  Remove
9775         sizeof_p parameter.
9776         (packet_ok): New overload.
9777         (packet_check_result): New overload.
9778         Update all uses.
9779
9780 2019-01-14  Tom Tromey  <tom@tromey.com>
9781
9782         * remote-notif.c (handle_notification, remote_notif_ack)
9783         (remote_notif_parse): Make "buf" const.
9784         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9785         const.
9786         (remote_notif_parse, remote_notif_ack, handle_notification):
9787         Likewise.
9788         * remote.c (remote_notif_stop_parse): Make "buf" const.
9789         (remote_target::remote_parse_stop_reply): Make "buf" const.
9790         (remote_notif_stop_ack): Make "buf" const.
9791
9792 2019-01-14  Tom Tromey  <tom@tromey.com>
9793
9794         * remote.c (remote_console_output): Make parameter const.
9795
9796 2019-01-14  Tom Tromey  <tom@tromey.com>
9797
9798         * target-debug.h (target_debug_print_signals): Constify.
9799         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9800         * procfs.c (procfs_target::pass_signals): Update.
9801         * linux-nat.c (linux_nat_target::pass_signals): Update.
9802         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9803         * target-delegates.c: Rebuild.
9804         * remote.c (remote_target::program_signals): Update.
9805         (remote_target::pass_signals): Update.
9806         * target.c (target_pass_signals): Constify argument.
9807         (target_program_signals): Likewise.
9808         * target.h (struct target_ops) <pass_signals, program_signals>:
9809         Constify argument.
9810         (target_pass_signals, target_program_signals): Constify argument.
9811
9812 2019-01-14  Tom Tromey  <tom@tromey.com>
9813
9814         PR tui/28819:
9815         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9816
9817 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9818
9819         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9820         field.
9821         * rs6000-tdep.c: Include reggroups.h.
9822         (IS_V_ALIAS_PSEUDOREG): Define.
9823         (rs6000_register_name): Return names for the "vX" aliases.
9824         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9825         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9826         aliases.  Call default_register_reggroup_p for all other
9827         pseudo-registers.
9828         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9829         New functions.
9830         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9831         Handle "vX" aliases.
9832         (v_alias_pseudo_register_collect): New function.
9833         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9834         (rs6000_gdbarch_init): Initialize "vX" aliases as
9835         pseudo-registers.  Restore registration of
9836         rs6000_pseudo_register_reggroup_p with
9837         set_tdesc_pseudo_register_reggroup_p.
9838
9839 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9840
9841         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9842         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9843         set_gdbarch_num_pseudo_regs.
9844
9845 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9846
9847         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9848         Remove arg prefixname, add do_set and do_show.
9849         Add member functions set_list and show_list.
9850         * cli/cli-style.c (class cli_style_option): Update accordingly.
9851         (style_set_list): Move to file scope.
9852         (style_show_list): Likewise.
9853         (set_style): Call help_list.
9854         (show_style): Call cmd_show_list.
9855         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9856         Update to use the new macro.
9857
9858 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9859
9860         * ada-lang.c (_initialize_ada_language): Expand the help text
9861         for the "catch exception" command.
9862
9863 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9864
9865         * symtab.c (matching_obj_sections): Initialize obj,
9866         declare it closer to its usage.
9867
9868 2019-01-10  Tom Tromey  <tom@tromey.com>
9869
9870         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9871         (basic_inf_threads_range): Remove.
9872         (inf_threads_range, inf_non_exited_threads_range)
9873         (safe_inf_threads_range): Use next_adapter.
9874
9875 2019-01-10  Keith Seitz  <keiths@redhat.com>
9876
9877         PR gdb/23712
9878         PR symtab/23010
9879         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9880         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9881
9882 2019-01-10  Keith Seitz  <keiths@redhat.com>
9883
9884         PR gdb/23712
9885         PR symtab/23010
9886         * dictionary.c (pending_to_vector): Remove.
9887         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9888         Remove _1 suffix, replacing functions of the same name.  Update
9889         all callers.
9890         (dict_create_hashed, dict_create_hashed_expandable)
9891         (dict_create_linear, dict_create_linear_expandable, dict_free)
9892         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9893         Make functions static.
9894
9895 2019-01-10  Keith Seitz  <keiths@redhat.com>
9896
9897         PR gdb/23712
9898         PR symtab/23010
9899         * dictionary.h (struct dictionary): Replace declaration with
9900         multidictionary.
9901         (dict_create_hashed, dict_create_hashed_expandable)
9902         (dict_create_linear, dict_create_linear_expandable)
9903         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9904         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9905         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9906         taking multidictionary argument.
9907         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9908         * block.h (struct block) <dict>: Change to multidictionary
9909         and rename `multidict'.
9910         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9911         symmisc.c: Update all dictionary references to multidictionary.
9912
9913 2019-01-10  Keith Seitz  <keiths@redhat.com>
9914
9915         PR gdb/23712
9916         PR symtab/23010
9917         * dictionary.c: Include unordered_map.
9918         (pending_to_vector): New function.
9919         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9920         Rewrite the non-"_1" functions to take vector instead
9921         of linked list.
9922         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9923         "new" _1 versions of the same name.
9924         (multidictionary): Define.
9925         (std::hash<enum language): New definition.
9926         (collate_pending_symbols_by_language, mdict_create_hashed)
9927         (mdict_create_hashed_expandable, mdict_create_linear)
9928         (mdict_create_linear_expandable, mdict_free)
9929         (find_language_dictionary, create_new_language_dictionary)
9930         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9931         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9932         (mdict_size, mdict_empty): New functions.
9933         * dictionary.h (mdict_iterator): Define.
9934
9935 2019-01-10  Pedro Alves  <palves@redhat.com>
9936
9937         * breakpoint.c (read_uploaded_action)
9938         (create_tracepoint_from_upload): Adjust to use
9939         gdb::unique_xmalloc_ptr.
9940         * ctf.c (ctf_write_uploaded_tp):
9941         (SET_ARRAY_FIELD): Use emplace_back.
9942         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9943         * tracefile-tfile.c (tfile_write_uploaded_tp):
9944         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9945         gdb::unique_xmalloc_ptr.
9946         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9947         at_string, cond_string, cmd_strings>: Replace char pointers
9948         with gdb::unique_xmalloc_ptr.
9949
9950 2019-01-10  Pedro Alves  <palves@redhat.com>
9951
9952         * solib-target.c (library_list_start_library): Don't xstrdup name.
9953
9954 2019-01-10  Pedro Alves  <palves@redhat.com>
9955
9956         * mdebugread.c (parse_partial_symbols): Use
9957         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9958
9959 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9960
9961         * linux-fork.c (scoped_switch_fork_info)
9962         <~scoped_switch_fork_info>: Fix incorrect variable name.
9963
9964 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9965
9966         * linux-fork.c (scoped_switch_fork_info)
9967         <scoped_switch_fork_info>: Make explicit.
9968         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9969
9970 2019-01-10  Tom Tromey  <tom@tromey.com>
9971
9972         * objfiles.h (objfile::reset_psymtabs): Update.
9973         * objfiles.c (objfile::objfile): Update.
9974         * psymtab.h (psymtab_storage::obstack): Update.
9975         (psymtab_storage::m_obstack): Use gdb::optional.
9976         (class psymtab_storage): Update comment.  Remove objfile
9977         parameter.
9978         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9979
9980 2019-01-10  Tom Tromey  <tom@tromey.com>
9981
9982         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9983         <free_psymtabs>: Now private.
9984         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9985         (allocate_psymtab): Use new method.
9986
9987 2019-01-10  Tom Tromey  <tom@tromey.com>
9988
9989         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9990         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9991         * mdebugread.c (parse_partial_symbols): Use
9992         allocate_dependencies.
9993         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9994         allocate_dependencies.
9995         (process_psymtab_comp_unit_reader)
9996         (build_type_psymtab_dependencies): Likewise.
9997         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9998
9999 2019-01-10  Tom Tromey  <tom@tromey.com>
10000
10001         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10002         PSYMBOL_SET_LANGUAGE.
10003         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10004
10005 2019-01-10  Tom Tromey  <tom@tromey.com>
10006
10007         * psymtab.h (psymtab_storage::obstack): New method.
10008         <m_obstack>: Rename from obstack; now private.
10009         * psymtab.c (psymtab_storage): Update.
10010         * dwarf2read.c (create_addrmap_from_index)
10011         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10012         Update.
10013
10014 2019-01-10  Tom Tromey  <tom@tromey.com>
10015
10016         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10017         * objfiles.h (objfile::reset_psymtabs): New method.
10018
10019 2019-01-10  Tom Tromey  <tom@tromey.com>
10020
10021         * symmisc.c (print_symbol_bcache_statistics): Update.
10022         (print_objfile_statistics): Update.
10023         * symfile.c (reread_symbols): Update.
10024         * psymtab.h (class psymtab_storage): New.
10025         * psymtab.c (psymtab_storage): New constructor.
10026         (~psymtab_storage): New destructor.
10027         (require_partial_symbols): Update.
10028         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10029         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10030         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10031         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10032         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10033         (start_psymtab_common, end_psymtab_common)
10034         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10035         (allocate_psymtab): Update.
10036         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10037         Update.
10038         (dump_psymtab_addrmap, maintenance_print_psymbols)
10039         (maintenance_check_psymtabs): Update.
10040         (class objfile_psymtabs): Move to objfiles.h.
10041         * psympriv.h (discard_psymtab): Now inline.
10042         (psymtab_discarder::psymtab_discarder): Update.
10043         (psymtab_discarder::~psymtab_discarder): Update.
10044         (ALL_OBJFILE_PSYMTABS): Rewrite.
10045         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10046         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10047         Remove fields.
10048         <partial_symtabs>: New field.
10049         (class objfile_psymtabs): Move from psymtab.h.  Update.
10050         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10051         psymbol_cache.
10052         (objfile::~objfile): Don't destroy psymbol_cache.
10053         * mdebugread.c (parse_partial_symbols): Update.
10054         * dwarf2read.c (create_addrmap_from_index)
10055         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10056         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10057         (add_partial_subprogram, dwarf2_ranges_read): Update.
10058         * dwarf-index-write.c (write_address_map)
10059         (write_one_signatured_type, recursively_write_psymbols)
10060         (class debug_names, class debug_names, write_psymtabs_to_index):
10061         Update.
10062
10063 2019-01-10  Tom Tromey  <tom@tromey.com>
10064
10065         * symtab.h (SYMBOL_SET_NAMES): Update.
10066         (symbol_set_names): Update.
10067         (MSYMBOL_SET_NAMES): Update.
10068         * symtab.c (symbol_set_names): Change argument to be an
10069         objfile_per_bfd_storage.
10070         * psymtab.c (add_psymbol_to_bcache): Update.
10071         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10072
10073 2019-01-10  Tom Tromey  <tom@tromey.com>
10074
10075         * symtab.c (create_demangled_names_hash): Change argument to be an
10076         objfile_per_bfd_storage.
10077         (symbol_set_names): Update.
10078
10079 2019-01-10  Tom Tromey  <tom@tromey.com>
10080
10081         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10082         init_psymbol_list.
10083         * psymtab.c (init_psymbol_list): Do nothing if already called.
10084         * psympriv.h (init_psymbol_list): Add comment.
10085         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10086         init_psymbol_list.
10087         * dbxread.c (dbx_symfile_read): Unconditionally call
10088         init_psymbol_list.
10089
10090 2019-01-10  Tom Tromey  <tom@tromey.com>
10091
10092         * xcoffread.c (scan_xcoff_symtab): Update.
10093         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10094         "where".
10095         * mdebugread.c (parse_partial_symbols)
10096         (handle_psymbol_enumerators): Update.
10097         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10098         * dbxread.c (read_dbx_symtab): Update.
10099         * psympriv.h (psymbol_placement): New enum.
10100         (add_psymbol_to_list): Update.
10101
10102 2019-01-10  Tom Tromey  <tom@tromey.com>
10103
10104         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10105         static_psymbols parameters.
10106         (scan_xcoff_symtab): Update.
10107         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10108         static_psymbols parameters.
10109         * psympriv.h (start_psymtab_common): Update.
10110         * mdebugread.c (parse_partial_symbols): Update.
10111         * dwarf2read.c (create_partial_symtab): Update.
10112         * dbxread.c (read_dbx_symtab): Update.
10113         (start_psymtab): Remove global_psymbols and static_psymbols
10114         parameters.
10115
10116 2019-01-10  Tom Tromey  <tom@tromey.com>
10117
10118         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10119         * psymtab.c (allocate_psymtab): Add comment.
10120         * psympriv.h (allocate_psymtab): Add comment.
10121         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10122         initializations.
10123         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10124
10125 2019-01-10  Tom Tromey  <tom@tromey.com>
10126
10127         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10128         Don't declare.
10129         * mipsread.c: Include mdebugread.h.
10130         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10131         Declare.
10132         * elfread.c: Include mdebugread.h.
10133
10134 2019-01-09  Tom Tromey  <tom@tromey.com>
10135
10136         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10137         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10138         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10139         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10140         (psym_lookup_symbol, psym_find_last_source_symtab)
10141         (psym_forget_cached_source_info, psym_print_stats)
10142         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10143         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10144         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10145         (psym_find_compunit_symtab_by_address)
10146         (maintenance_print_psymbols, maintenance_info_psymtabs)
10147         (maintenance_check_psymtabs): Use ranged for.
10148         * psymtab.h (class objfile_psymtabs): New.
10149         (require_partial_symbols): Return objfile_psymtabs.
10150         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10151
10152 2019-01-09  Tom Tromey  <tom@tromey.com>
10153
10154         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10155         (find_pc_mapped_section, list_overlays_command)
10156         (map_overlay_command, unmap_overlay_command)
10157         (simple_overlay_update): Use all_objfiles.
10158         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10159         * printcmd.c (info_symbol_command): Use all_objfiles.
10160         * objfiles.h (ALL_OBJSECTIONS): Remove.
10161         * maint.c (maintenance_translate_address): Use all_objfiles.
10162         * gcore.c (gcore_create_callback): Use all_objfiles.
10163         (objfile_find_memory_regions): Likewise.
10164
10165 2019-01-09  Tom Tromey  <tom@tromey.com>
10166
10167         * symtab.c (find_line_symtab, info_sources_command)
10168         (make_source_files_completion_list): Use objfile_compunits.
10169         * source.c (select_source_symtab): Use objfile_compunits.
10170         * objfiles.h (struct objfile): Update comment.
10171         (ALL_OBJFILES): Remove.
10172         (ALL_FILETABS): Remove.
10173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10174         objfile_compunits.
10175
10176 2019-01-09  Tom Tromey  <tom@tromey.com>
10177
10178         * symmisc.c (print_objfile_statistics, dump_objfile)
10179         (maintenance_print_symbols): Use compunit_filetabs.
10180         * source.c (forget_cached_source_info_for_objfile): Use
10181         compunit_filetabs.
10182         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10183         (ALL_FILETABS): Use compunit_filetabs.
10184         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10185         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10186
10187 2019-01-09  Tom Tromey  <tom@tromey.com>
10188
10189         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10190         (compunit_filetabs): New.
10191         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10192         compunit_filetabs.
10193         (info_sources_command, make_source_files_completion_list): Remove
10194         declaration.
10195         * symmisc.c (print_objfile_statistics, dump_objfile)
10196         (maintenance_print_symbols): Remove declaration.
10197         (maintenance_info_symtabs): Use compunit_filetabs.
10198         (maintenance_info_line_tables): Likewise.
10199         * source.c (select_source_symtab): Change local variable name.
10200         (forget_cached_source_info_for_objfile): Remove declaration.
10201         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10202         * objfiles.c (objfile_relocate1): Remove declaration.
10203         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10204         declaration.
10205         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10206         * coffread.c (coff_symtab_read): Remove declaration.
10207         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10208         compunit_filetabs.
10209
10210 2019-01-09  Tom Tromey  <tom@tromey.com>
10211
10212         * symtab.c (lookup_objfile_from_block)
10213         (find_pc_sect_compunit_symtab, search_symbols)
10214         (default_collect_symbol_completion_matches_break_on): Use
10215         objfile_compunits.
10216         * objfiles.h (ALL_COMPUNITS): Remove.
10217         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10218         * cp-support.c (add_symbol_overload_list_qualified): Use
10219         objfile_compunits.
10220         * ada-lang.c (ada_collect_symbol_completion_matches)
10221         (ada_add_global_exceptions): Use objfile_compunits.
10222
10223 2019-01-09  Tom Tromey  <tom@tromey.com>
10224
10225         * source.c (select_source_symtab)
10226         (forget_cached_source_info_for_objfile): Remove declaration.
10227         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10228         declaration.
10229         * maint.c (count_symtabs_and_blocks): Remove declaration.
10230         * cp-support.c (add_symbol_overload_list_qualified): Remove
10231         declaration.
10232         * coffread.c (coff_symtab_read): Remove declaration.
10233         * symtab.c (lookup_symbol_in_objfile_symtabs)
10234         (basic_lookup_transparent_type_1): Use objfile_compunits.
10235         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10236         (info_sources_command, search_symbols)
10237         (default_collect_symbol_completion_matches_break_on)
10238         (make_source_files_completion_list): Remove declaration.
10239         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10240         (ada_collect_symbol_completion_matches)
10241         (ada_add_global_exceptions): Remove declaration.
10242         * linespec.c (iterate_over_all_matching_symtabs): Use
10243         objfile_compunits.
10244         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10245         (class objfile_compunits): New.
10246         (ALL_COMPUNITS): Use objfile_compunits.
10247         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10248         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10249         objfile_compunits.
10250         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10251
10252 2019-01-09  Tom Tromey  <tom@tromey.com>
10253
10254         * symtab.c (search_symbols)
10255         (default_collect_symbol_completion_matches_break_on): Use
10256         objfile_msymbols.
10257         * ada-lang.c (ada_lookup_simple_minsym)
10258         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10259         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10260         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10261         objfile_msymbols.
10262         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10263         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10264         * objc-lang.c (find_methods): Use objfile_msymbols.
10265         (info_selectors_command, info_classes_command): Likewise.
10266         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10267         * objfiles.h (class objfile_msymbols): New.
10268         (ALL_OBJFILE_MSYMBOLS): Remove.
10269         (ALL_MSYMBOLS): Remove.
10270
10271 2019-01-09  Tom Tromey  <tom@tromey.com>
10272
10273         * common/next-iterator.h (next_adapter): Add Iterator template
10274         parameter.
10275         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10276         (class all_objfiles_safe): New.
10277         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10278         * objfiles.c (put_objfile_before): Update comment.
10279         (add_separate_debug_objfile): Likewise.
10280         (free_all_objfiles): Use all_objfiles_safe.
10281         (objfile_purge_solibs): Likewise.
10282
10283 2019-01-09  Tom Tromey  <tom@tromey.com>
10284
10285         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10286         (expand_symtab_containing_pc, lookup_static_symbol)
10287         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10288         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10289         all_objfiles.
10290         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10291         * breakpoint.c (create_overlay_event_breakpoint)
10292         (create_longjmp_master_breakpoint)
10293         (create_std_terminate_master_breakpoint)
10294         (create_exception_master_breakpoint): Use all_objfiles.
10295         * linux-thread-db.c (try_thread_db_load_from_pdir)
10296         (has_libpthread): Use all_objfiles.
10297         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10298         * linespec.c (iterate_over_all_matching_symtabs)
10299         (search_minsyms_for_name): Use all_objfiles.
10300         * maint.c (maintenance_info_sections): Use all_objfiles.
10301         * main.c (captured_main_1): Use all_objfiles.
10302         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10303         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10304         * guile/scm-pretty-print.c
10305         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10306         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10307         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10308         (maintenance_print_msymbols): Use all_objfiles.
10309         * source.c (select_source_symtab): Use all_objfiles.
10310         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10311         * symfile.c (remove_symbol_file_command)
10312         (expand_symtabs_matching, map_symbol_filenames): Use
10313         all_objfiles.
10314         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10315         all_objfiles.
10316         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10317         * objc-lang.c (find_methods): Use all_objfiles.
10318         * objfiles.c (have_partial_symbols, have_full_symbols)
10319         (have_minimal_symbols, qsort_cmp)
10320         (default_iterate_over_objfiles_in_search_order): Use
10321         all_objfiles.
10322         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10323         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10324         (maintenance_check_psymtabs): Use all_objfiles.
10325         (ALL_PSYMTABS): Remove.
10326         * compile/compile-object-run.c (do_module_cleanup): Use
10327         all_objfiles.
10328         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10329         * cp-support.c (add_symbol_overload_list_qualified): Use
10330         all_objfiles.
10331         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10332         Use all_objfiles.
10333         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10334         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10335         all_objfiles.
10336         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10337         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10338         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10339         Uses all_objfiles.
10340         * solib.c (solib_read_symbols): Use all_objfiles
10341
10342 2019-01-09  Tom Tromey  <tom@tromey.com>
10343
10344         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10345         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10346         all_objfiles.
10347         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10348         * symmisc.c (print_symbol_bcache_statistics)
10349         (print_objfile_statistics, maintenance_print_objfiles)
10350         (maintenance_info_symtabs, maintenance_check_symtabs)
10351         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10352         all_objfiles.
10353         * source.c (forget_cached_source_info): Use all_objfiles.
10354         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10355         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10356         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10357         * objfiles.c (update_section_map): Use all_objfiles.
10358         (shared_objfile_contains_address_p): Likewise.
10359         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10360         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10361
10362 2019-01-09  Tom Tromey  <tom@tromey.com>
10363
10364         * common/next-iterator.h: New file.
10365         * objfiles.h (class all_objfiles): New.
10366         (struct objfile_iterator): New.
10367
10368 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10369
10370         * NEWS: Move the description of the changed "frame", "select-frame",
10371          and "info frame" commands to the Changed commands section.
10372
10373 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10374
10375         * gdbtypes.c (check_stub_method_group): Remove handling of old
10376         mangling schemes.
10377         * linespec.c (find_methods): Likewise.
10378         * stabsread.c (read_member_functions): Likewise.
10379         * valops.c (search_struct_method): Likewise.
10380         (value_struct_elt_for_reference): Likewise.
10381         * NEWS: Mention this change.
10382
10383 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10386         print_source_lines.
10387         * source.c (print_source_lines_base): Update line number check.
10388         (print_source_lines): New function.
10389         (source_lines_range::source_lines_range): New function.
10390         * source.h (class source_lines_range): New class.
10391         (print_source_lines): New declaration.
10392
10393 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10394
10395         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10396
10397 2019-01-08  Tom Tromey  <tom@tromey.com>
10398             Simon Marchi  <simon.marchi@ericsson.com>
10399
10400         PR gdb/24060
10401         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10402         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10403         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10404         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10405         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10406         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10407
10408 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10409
10410         * source.c (select_source_symtab): Move header comment to
10411         declaration in source.h.
10412         (forget_cached_source_info_for_objfile): Likewise.
10413         (forget_cached_source_info): Likewise.
10414         (identify_source_line): Likewise.
10415         * source.h (identify_source_line): Move declaration from symtab.h
10416         and add comment from source.c
10417         (print_source_lines): Likewise.
10418         (forget_cached_source_info_for_objfile): Likewise.
10419         (forget_cached_source_info): Likewise.
10420         (select_source_symtab): Likewise.
10421         (enum print_source_lines_flag): Move definition from symtab.h.
10422         * symtab.h (identify_source_line): Move declaration to source.h.
10423         (print_source_lines): Likewise.
10424         (forget_cached_source_info_for_objfile): Likewise.
10425         (forget_cached_source_info): Likewise.
10426         (select_source_symtab): Likewise.
10427         (enum print_source_lines_flag): Move definition to source.h.
10428         * tui/tui-hooks.c: Add 'source.h' include.
10429
10430 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10431
10432         * source.c (print_source_lines_base): Handle requests to print
10433         reverse line number sequences, and guard against empty lines
10434         string.
10435
10436 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10437
10438         * source.c (print_source_lines_base): Fix skip of '\r' if next
10439         character is '\n'.
10440
10441 2019-01-06  Tom Tromey  <tom@tromey.com>
10442
10443         * c-exp.y (struct c_parse_state) <macro_original_text,
10444         expansion_obstack>: New member.
10445         (macro_original_text, expansion_obstack): Remove globals.
10446         (scan_macro_expansion, scanning_macro_expansion)
10447         (finished_macro_expansion): Update.
10448         (scan_macro_cleanup): Remove.
10449         (yylex, c_parse): Update.
10450
10451 2019-01-06  Tom Tromey  <tom@tromey.com>
10452
10453         * c-exp.y (struct c_parse_state) <strings>: New member.
10454         (operator_stoken): Update.
10455
10456 2019-01-06  Tom Tromey  <tom@tromey.com>
10457
10458         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10459         (union type_stack_elt) <typelist_val>: Now a pointer to
10460         std::vector.
10461         (type_stack_cleanup): Don't declare.
10462         (push_typelist): Update.
10463         * parse.c (pop_typelist): Return a std::vector.
10464         (push_typelist): Take a std::vector.
10465         (follow_types): Update.  Do not free args.
10466         (type_stack_cleanup): Remove.
10467         * c-exp.y (struct c_parse_state): New.
10468         (cpstate): New global.
10469         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10470         (nonempty_typelist): Update.
10471         (func_mod): Create a new vector.
10472         (c_parse): Create a c_parse_state.
10473         (check_parameter_typelist): Do not delete params.
10474         (function_method): Update.  Do not delete type_list.
10475
10476 2019-01-06  Tom Tromey  <tom@tromey.com>
10477
10478         PR gdb/28155:
10479         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10480         check_typedef.
10481         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10482         (print_return_value): Likewise.
10483
10484 2019-01-05  Tom Tromey  <tom@tromey.com>
10485
10486         * contrib/cleanup_check.py: Remove.
10487         * contrib/gcc-with-excheck: Remove.
10488         * contrib/exsummary.py: Remove.
10489         * contrib/excheck.py: Remove.
10490
10491 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10492
10493         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10494         NULL. Initialize tpprev to NULL instead of assigning it
10495         to NULL on the next statement.
10496         * windows-nat.c (windows_delete_thread): Remove check for
10497         main_thread_id before printing thread exit notifications.
10498         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10499         Remove thread ID check against main_thread_id.
10500         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10501         windows_delete_thread.
10502         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10503
10504 2019-01-04  Tom Tromey  <tom@tromey.com>
10505
10506         * compile/compile.c (_initialize_compile): Use upper case for
10507         metasyntactic variables.
10508         * symmisc.c (_initialize_symmisc): Use upper case for
10509         metasyntactic variables.
10510         * psymtab.c (_initialize_psymtab): Use upper case for
10511         metasyntactic variables.
10512         * demangle.c (demangle_command): Use upper case for metasyntactic
10513         variables.
10514         (_initialize_demangler): Likewise.
10515         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10516         variables.
10517
10518 2019-01-03  Tom Tromey  <tom@tromey.com>
10519
10520         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10521
10522 2019-01-03  Tom Tromey  <tom@tromey.com>
10523
10524         * python/py-symtab.c (salpy_str): Update.
10525         (struct salpy_sal_object) <symtab>: Now a PyObject.
10526         (salpy_dealloc): Update.
10527         (del_objfile_sal): Use gdbpy_ref.
10528
10529 2019-01-03  Tom Tromey  <tom@tromey.com>
10530
10531         * python/py-type.c (convert_field): Use new_reference.  Return
10532         gdbpy_ref.
10533         (make_fielditem): Return gdbpy_ref.
10534         (typy_fields): Update.
10535         (typy_getitem): Update.
10536         (field_name): Return gdbpy_ref.  Use new_reference.
10537         (typy_iterator_iternext): Update.
10538
10539 2019-01-03  Tom Tromey  <tom@tromey.com>
10540
10541         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10542
10543 2019-01-03  Tom Tromey  <tom@tromey.com>
10544
10545         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10546         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10547         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10548         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10549         (pspy_set_type_printers): Likewise.
10550         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10551         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10552         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10553         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10554         (objfpy_set_type_printers): Likewise.
10555
10556 2019-01-03  Tom Tromey  <tom@tromey.com>
10557
10558         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10559         (gdbpy_print_stack): Use gdbpy_err_fetch.
10560         * python/python-internal.h (class gdbpy_err_fetch): New class.
10561         (class gdbpy_enter) <m_error_type, m_error_value,
10562         m_error_traceback>: Remove.
10563         <m_error>: New member.
10564         (gdbpy_exception_to_string): Don't declare.
10565         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10566         * python/py-value.c (convert_value_from_python): Use
10567         gdbpy_err_fetch.
10568         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10569         gdbpy_exception_to_string.
10570         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10571         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10572         gdbpy_err_fetch.
10573
10574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10575
10576         * linux-nat.c (delete_lwp_cleanup): Delete.
10577         (struct lwp_deleter): New struct.
10578         (lwp_info_up): New typedef.
10579         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10580         lwp_info_up.
10581
10582 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10583
10584         * linux-fork.c (class scoped_switch_fork_info): New class.
10585         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10586
10587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * valops.c (find_overload_match): Remove use of null_cleanup, and
10590         calls to do_cleanups.
10591
10592 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10593
10594         * compile/compile-cplus-types.c
10595         (compile_cplus_instance::decl_name): Handle changes to
10596         cp_func_name.
10597         * cp-support.c (cp_func_name): Update header comment, update
10598         return type.
10599         * cp-support.h (cp_func_name): Update return type in declaration.
10600         * valops.c (find_overload_match): Move temp_func local to top
10601         level of function and change its type.  Use temp_func to hold and
10602         delete temporary string obtained from cp_func_name.
10603
10604 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10605
10606         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10607         gdb::char_vector, remove cleanup, and update uses of `msg`.
10608
10609 2019-01-03  Jim Wilson  <jimw@sifive.com>
10610
10611         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10612
10613 2019-01-02  Tom Tromey  <tom@tromey.com>
10614
10615         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10616         (tdesc_parse_xml): Remove cleanups.
10617         * target-descriptions.h (make_cleanup_free_target_description):
10618         Don't declare.
10619         (target_desc_deleter): New struct.
10620         (target_desc_up): New typedef.
10621         * target-descriptions.c (target_desc_deleter::operator()): Rename
10622         from free_target_description.
10623         (make_cleanup_free_target_description): Remove.
10624
10625 2019-01-02  Tom Tromey  <tom@tromey.com>
10626
10627         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10628         constructor, destructor.
10629         (linespec_parser): Remove typedef.
10630         (~linespec_parser): Rename from linespec_parser_delete.
10631         (linespec_lex_to_end, linespec_complete_label)
10632         (linespec_complete): Update.
10633         (decode_line_full): Remove cleanups.
10634         (decode_line_1): Update.
10635
10636 2019-01-02  Tom Tromey  <tom@tromey.com>
10637
10638         * python/python-internal.h (inferior_to_inferior_object): Change
10639         return type.
10640         * python/py-exitedevent.c (create_exited_event_object): Update.
10641         * python/py-inferior.c (inferior_to_inferior_object): Return
10642         gdbpy_ref.
10643         (python_new_inferior, python_inferior_deleted)
10644         (thread_to_thread_object, delete_thread_object)
10645         (build_inferior_list, gdbpy_selected_inferior): Update.
10646         * python/py-infthread.c (create_thread_object): Update.  Also fail
10647         if inferior_to_inferior_object fails.
10648
10649 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10650
10651         * inferior.h (class inferior) <displaced_step_state>: New field.
10652         * infrun.h (struct displaced_step_state): Move here from
10653         infrun.c.  Initialize fields, add constructor.
10654         <inf>: Remove field.
10655         <reset>: New method.
10656         * infrun.c (struct displaced_step_inferior_state): Move to
10657         infrun.h.
10658         (displaced_step_inferior_states): Remove.
10659         (get_displaced_stepping_state): Adust.
10660         (displaced_step_in_progress_any_inferior): Adjust.
10661         (displaced_step_in_progress_thread): Adjust.
10662         (displaced_step_in_progress): Adjust.
10663         (add_displaced_stepping_state): Remove.
10664         (get_displaced_step_closure_by_addr): Adjust.
10665         (remove_displaced_stepping_state): Remove.
10666         (infrun_inferior_exit): Call displaced_step_state.reset.
10667         (use_displaced_stepping): Don't check for NULL.
10668         (displaced_step_prepare_throw): Call
10669         get_displaced_stepping_state.
10670         (displaced_step_fixup): Don't check for NULL.
10671         (prepare_for_detach): Don't check for NULL.
10672
10673 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10674
10675         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10676          in case of call that did not complete.
10677
10678 2019-01-02  Andrey Utkin  <autkin@undo.io>
10679
10680         * symfile.c (find_separate_debug_file): Fix search of debug files for
10681         remote debuggee.
10682
10683 2019-01-02  Tom Tromey  <tom@tromey.com>
10684
10685         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10686         indentation.
10687         * python/py-frame.c (frapy_older): Remove cast.
10688         (frapy_newer): Likewise.
10689         * python/py-breakpoint.c (local_setattro): Remove cast.
10690         * python/py-arch.c (archpy_name): Remove local variable.
10691         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10692
10693 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10694
10695         * unittests/basic_string_view/element_access/char/empty.cc:
10696         Fix year range in copyright header.
10697
10698 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10699
10700         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10701         Delete.
10702         <operator==>: Update with for removed field.
10703         <hash>: Likewise.
10704         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10705         <isa_features>: ...this.
10706         <abi_features>: New field.
10707         (riscv_isa_flen): Update comment.
10708         (riscv_abi_xlen): New declaration.
10709         (riscv_abi_flen): New declaration.
10710         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10711         isa_features.
10712         (riscv_abi_xlen): New function.
10713         (riscv_isa_flen): Update to get answer from isa_features.
10714         (riscv_abi_flen): New function.
10715         (riscv_has_fp_abi): Update to get answer from abi_features.
10716         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10717         xlen and flen.
10718         (riscv_call_info) <xlen, flen>: Update comment.
10719         (riscv_call_arg_struct): Remove invalid assertions
10720         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10721         is removed.
10722         (riscv_gdbarch_init): Gather isa features and abi features
10723         separately, ensure both match on the gdbarch when reusing an old
10724         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10725         a target with 64-bit float hardware.
10726
10727 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10728
10729         * source.c (search_command_helper): Stop reverse search
10730         when line 1 has been searched.
10731
10732 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10733
10734         * record-full.c (record_full_base_target::close): Rewrite
10735         record_full_core_buf_list free logic.
10736
10737 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10738
10739         * break-catch-syscall.c (print_one_catch_syscall): xfree
10740         the last text.
10741
10742 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10743
10744         * top.c (print_gdb_version): Update Copyright year in version
10745         message.
10746
10747 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10748
10749         Update copyright year range in all GDB files.
10750
10751 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10752
10753         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10754
10755 For older changes see ChangeLog-2018.
10756 \f
10757 Local Variables:
10758 mode: change-log
10759 left-margin: 8
10760 fill-column: 74
10761 version-control: never
10762 coding: utf-8
10763 End:
10764