gdb/ChangeLog

   1 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   2
   3         * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
   4         New function.
   5         (read_subroutine_type): Validate the parsed
   6         DW_AT_calling_convention value before assigning it to a
   7         subroutine's calling_convention attribute.
   8         * gdbtypes.h (struct func_type) <calling_convention>: Use
   9         an enum bitfield as its type, instead of plain unsigned.
  10
  11 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  12
  13         PR gdb/25054
  14         * infcall.c (call_function_by_hand_dummy): Update the argument-
  15         passing section for call-by-value parameters.
  16         (struct destructor_info): New struct.
  17         (call_destructors): New auxiliary function.
  18
  19 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  20
  21         * gnu-v3-abi.c (enum definition_style): New enum type.
  22         (get_def_style): New function.
  23         (is_user_provided_def): New function.
  24         (is_implicit_def): New function.
  25         (is_copy_or_move_constructor_type): New function.
  26         (is_copy_constructor_type): New function.
  27         (is_move_constructor_type): New function.
  28         (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
  29         for a given type.
  30
  31 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  32
  33         * language.h (struct language_pass_by_ref_info): New struct.
  34         (struct language_defn)<la_pass_by_reference>: Change the signature
  35         to return a language_pass_by_ref_info instead of an int.
  36         (language_pass_by_reference): Ditto.
  37         (default_pass_by_reference): Ditto.
  38         Adjust the users listed below.
  39         * arch-utils.c (default_return_in_first_hidden_param_p):
  40         Update.
  41         * cp-abi.c (cp_pass_by_reference): Update.
  42         * cp-abi.h (cp_pass_by_reference): Update declaration.
  43         (struct cp_abi_ops)<pass_by_reference>: Update.
  44         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
  45         * infcall.c (call_function_by_hand_dummy): Update.
  46         * language.c (language_pass_by_reference): Update.
  47         (default_pass_by_reference): Update.
  48         * tic6x-tdep.c (tic6x_return_value): Update.
  49
  50 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  51
  52         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
  53         and DW_AT_deleted attributes of a function.
  54         (read_structure_type): Read the DW_AT_calling_convention attribute
  55         of a type.
  56         (is_valid_DW_AT_defaulted): New function.
  57         (is_valid_DW_AT_calling_convention_for_type): New function.
  58         * gdbtypes.h: Include dwarf2.h.
  59         (struct fn_field)<defaulted>: New field to store the
  60         DW_AT_defaulted attribute.
  61         (struct fn_field)<is_deleted>: New field to store the
  62         DW_AT_deleted attribute.
  63         (struct cplus_struct_type)<calling_convention>: New field to store
  64         the DW_AT_calling_convention attribute.
  65         (TYPE_FN_FIELD_DEFAULTED): New macro.
  66         (TYPE_FN_FIELD_DELETED): New macro.
  67         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
  68         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
  69         to the .h file.
  70         (print_cplus_stuff): Likewise.
  71
  72 2019-12-20  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui.c (tui_show_source): Remove.
  75         * tui/tui.h (tui_show_source): Don't declare.
  76         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
  77         tui_show_source.
  78
  79 2019-12-20  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-stack.h (tui_show_frame_info): Return bool.
  82         * tui/tui-stack.c (tui_show_frame_info): Return bool.
  83         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  84         Update.
  85
  86 2019-12-20  Tom Tromey  <tom@tromey.com>
  87
  88         PR tui/18932:
  89         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  90         Rename parameters.  Handle the not-from-stack-frame case.
  91         (from_stack, from_source_symtab): New globals.
  92         (tui_before_prompt, tui_normal_stop): Update.
  93         (tui_context_changed, tui_symtab_changed): New functions.
  94         (tui_attach_detach_observers): Attach new observers.
  95
  96 2019-12-20  Tom Tromey  <tom@tromey.com>
  97
  98         * source.c (struct current_source_location) <set, symtab, line>:
  99         New methods.
 100         <m_symtab, m_line>: Rename.  Now private.
 101         (get_current_source_symtab_and_line)
 102         (set_default_source_symtab_and_line)
 103         (set_current_source_symtab_and_line)
 104         (clear_current_source_symtab_and_line, select_source_symtab)
 105         (info_source_command, print_source_lines_base)
 106         (info_line_command, search_command_helper): Update.
 107         * observable.h (current_source_symtab_and_line_changed): Declare
 108         observable.
 109         * observable.c (current_source_symtab_and_line_changed): Define
 110         observable.
 111
 112 2019-12-20  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
 115         (tui_before_prompt, tui_normal_stop): Update.
 116
 117 2019-12-20  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-winsource.c
 120         (tui_source_window_base::update_source_window_as_is): Don't call
 121         set_current_source_symtab_and_line.
 122
 123 2019-12-20  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
 126         Take a symtab_and_line.
 127         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
 128         symtab_and_line.
 129         (tui_show_frame_info): Update.
 130
 131 2019-12-20  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-stack.c (tui_show_frame_info): Don't call
 134         update_exec_info.
 135
 136 2019-12-20  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui.c (tui_enable): Call tui_display_main.
 139
 140 2019-12-20  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
 143         get_current_source_symtab_and_line, and main_name.
 144
 145 2019-12-20  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui.c (tui_show_source): Update.
 148         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
 149         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
 150         a symtab_symbol_info, not a separate symtab and line.  Simplify.
 151
 152 2019-12-20  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
 155         Simplify.
 156
 157 2019-12-20  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-winsource.h (struct tui_source_window_base)
 160         <set_contents, update_source_window_as_is, update_source_window>:
 161         Take a sal, not a separate symtab and tui_line_or_address.
 162         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 163         (tui_source_window_base::update_source_window_as_is): Take a sal,
 164         not a separate symtab and tui_line_or_address.
 165         (tui_update_source_windows_with_addr)
 166         (tui_update_source_windows_with_line)
 167         (tui_source_window_base::rerender)
 168         (tui_source_window_base::refill): Update.
 169         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
 170         a sal, not a separate symtab and tui_line_or_address.
 171         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
 172         not a separate symtab and tui_line_or_address.
 173         (tui_source_window::maybe_update): Update.
 174         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
 175         a sal, not a separate symtab and tui_line_or_address.
 176         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
 177         not a separate symtab and tui_line_or_address.
 178         (tui_disasm_window::do_scroll_vertical)
 179         (tui_disasm_window::maybe_update): Update.
 180
 181 2019-12-20  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 184         start_line_or_addr.
 185         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 186         start_line_or_addr.
 187         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 188         start_line_or_addr.
 189
 190 2019-12-20  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-winsource.h (struct tui_source_window_base)
 193         <set_contents>: Return bool.
 194         * tui/tui-winsource.c
 195         (tui_source_window_base::update_source_window_as_is): Update.
 196         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 197         Return bool.
 198         * tui/tui-source.c (tui_source_window::set_contents): Return
 199         bool.  Simplify.
 200         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 201         Return bool.
 202         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 203         bool.
 204
 205 2019-12-20  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 208         (tui_update_source_windows_with_line): Call update_source_window.
 209         * tui/tui-source.h (struct tui_source_window)
 210         <show_symtab_source>: Don't declare.
 211         * tui/tui-source.c (tui_source_window::show_symtab_source):
 212         Remove.
 213
 214 2019-12-20  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 217         update_source_window directly.
 218         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 219         * tui/tui-disasm.c (tui_show_disassem): Remove.
 220
 221 2019-12-20  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-winsource.c
 224         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 225         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 226
 227 2019-12-20  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-winsource.h (struct tui_source_window_base)
 230         <maybe_update>: Remove line_no and addr parameters.
 231         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 232         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 233         Update.
 234         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 235         line_no and addr parameters.
 236         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 237         Update.
 238         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 239         line_no and addr parameters.
 240
 241 2019-12-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 244         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 245
 246 2019-12-20  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 249         tui_show_disassem.
 250         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 251         declare.
 252         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 253
 254 2019-12-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui.h (tui_show_source): Remove parameters.
 257         * tui/tui.c (tui_show_source): Remove parameters.
 258         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 259
 260 2019-12-20  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui.c (tui_show_source): Update.
 263         * tui/tui-winsource.c (tui_display_main): Update.
 264         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 265         to symtab.
 266         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 267         to symtab.
 268         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 269
 270 2019-12-20  Tom Tromey  <tom@tromey.com>
 271
 272         PR tui/23619:
 273         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 274         (tui_redisplay_readline): Use rl_display_prompt.
 275         (tui_prep_terminal): Update.
 276
 277 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * configure: Regenerate.
 280         * configure.ac: Quote variable arguments of test.
 281         * gdbsupport/common.m4: Likewise.
 282
 283 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 284
 285         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 286         2 to pow ().
 287
 288 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 289
 290         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 291         log10 to double to fix Solaris 11 with gcc 5.5.
 292
 293 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 294
 295         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 296         "sun" to "saddr_un".
 297
 298 2019-12-19  Tom Tromey  <tromey@adacore.com>
 299
 300         * ui-out.h (enum class field_kind): Fix comment.
 301
 302 2019-12-11  Tom Tromey  <tromey@adacore.com>
 303
 304         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 305
 306 2019-12-18  Tom Tromey  <tromey@adacore.com>
 307
 308         PR build/25268:
 309         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 310         type on macOS.  Add comment.
 311
 312 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 313
 314         * c-lang.c (c_get_string, asm_language_defn): Remove space
 315         before tab.
 316
 317 2019-12-18  Tom Tromey  <tromey@adacore.com>
 318
 319         PR build/25250:
 320         * ui-out.c (ui_out::vmessage): Update.
 321         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 322         Rename.
 323         (string_field): Update.
 324         (signed_field): Update.
 325
 326 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 327
 328         * top.c (print_gdb_configuration): Adjust indentation.
 329
 330 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 331
 332         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 333
 334 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 335
 336         * tui/tui-layout.h (class tui_layout_base): Add virtual
 337         destructor.
 338
 339 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 340
 341         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 342         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 343         (process_event_stop_test): Keep stepping over skipped inline functions.
 344
 345 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 346
 347         * jit.c (struct gdb_block) <next>: Remove field.
 348         (struct gdb_symtab) <~gdb_symtab>: Remove.
 349         <blocks>: Change type to std::forward_list<gdb_block>.
 350         (compare_block): Remove.
 351         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 352         block at the beginning, don't mind about sorting.
 353         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 354         before using it.
 355
 356 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * jit.c (struct gdb_block): Add constructor, initialize
 359         real_block and next fields.
 360         <name>: Change type to gdb::unique_xmalloc_ptr.
 361         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 362         (jit_block_open_impl): Allocate gdb_block with new.
 363         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 364
 365 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 366
 367         * jit.c: Include forward_list.
 368         (struct gdb_symtab) <next>: Remove field.
 369         (struct gdb_object) <symtabs>: Change type to
 370         std::forward_list<gdb_symtab>.
 371         (jit_object_open_impl): Allocate gdb_object with new.
 372         (jit_symtab_open_impl): Adjust to std::forward_list.
 373         (finalize_symtab): Don't delete symtab.
 374         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 375         gdb_object with delete.
 376
 377 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 378
 379         * jit.c (struct gdb_symtab): Add constructor, destructor,
 380         initialize fields.
 381         <linetable>: Change type to unique_xmalloc_ptr.
 382         <file_name>: Change type to std::string.
 383         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 384         (jit_symtab_line_mapping_add_impl): Adjust.
 385         (finalize_symtab): Adjust, call delete on stab.
 386
 387 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 388
 389         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 390
 391 2019-12-16  Tom Tromey  <tromey@adacore.com>
 392
 393         * windows-nat.c (windows_nat_target::attach): Update.
 394         * remote.c (extended_remote_target::attach): Update.
 395         * procfs.c (procfs_target::attach): Update.
 396         * nto-procfs.c (nto_procfs_target::attach): Update.
 397         (nto_procfs_target::create_inferior): Update.
 398         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 399         * gnu-nat.c (gnu_nat_target::attach): Update.
 400         (gnu_nat_target::detach): Update.
 401         * darwin-nat.c (darwin_nat_target::attach): Update.
 402         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 403         return.
 404         * bsd-kvm.c (bsd_kvm_target_open): Update.
 405         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 406
 407 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 408
 409         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 410         (we no longer need to include time.h before pathmax.h)
 411
 412 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 413
 414         * ada-exp.y (write_ambiguous_var): Update.
 415         * coffread.c (process_coff_symbol): Update.
 416         * ctfread.c (ctf_add_enum_member_cb): Update.
 417         (new_symbol): Update.
 418         * dwarf2read.c (fixup_go_packaging): Update.
 419         (new_symbol): Update.
 420         * language.c (language_alloc_type_symbol): Update.
 421         * mdebugread.c (new_symbol): Update.
 422         * minsyms.c (minimal_symbol_reader::record_full): Update.
 423         * psymtab.c (add_psymbol_to_bcache): Update.
 424         * stabsread.c (define_symbol): Update.
 425         (read_enum_type): Update.
 426         * symtab.c (symbol_set_language): Make this a member function...
 427         (general_symbol_info::set_language): ... here.
 428         * symtab.h (struct general_symbol_info) <set_language>: New function.
 429         (SYMBOL_SET_LANGUAGE): Remove.
 430         (symbol_set_language): Remove.
 431
 432 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 433
 434         * ada-lang.c (ada_add_block_symbols): Update.
 435         (ada_collect_symbol_completion_matches): Update.
 436         * ax-gdb.c (gen_expr): Update.
 437         * block.c (block_lookup_symbol): Update.
 438         (block_lookup_symbol_primary): Update.
 439         (block_find_symbol): Update.
 440         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 441         * dbxread.c (process_one_symbol): Update.
 442         * dictionary.c (insert_symbol_hashed): Update.
 443         (collate_pending_symbols_by_language): Update.
 444         (mdict_add_symbol): Update.
 445         * dwarf-index-write.c (write_psymbols): Update.
 446         * dwarf2read.c (fixup_go_packaging): Update.
 447         * findvar.c (read_var_value): Update.
 448         * ft32-tdep.c (ft32_skip_prologue): Update.
 449         * go-lang.c (go_symbol_package_name): Update.
 450         * language.h (scoped_switch_to_sym_language_if_auto::
 451         scoped_switch_to_sym_language_if_auto): Update.
 452         * linespec.c (find_method): Update.
 453         (find_label_symbols_in_block): Update.
 454         * mdebugread.c (parse_symbol): Update.
 455         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 456         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 457         (minimal_symbol_reader::install): Update.
 458         * moxie-tdep.c (moxie_skip_prologue): Update.
 459         * parse.c (parse_exp_in_context): Update.
 460         * psymtab.c (psymbol_name_matches): Update.
 461         (match_partial_symbol): Update.
 462         (lookup_partial_symbol): Update.
 463         (psymbol_hash): Update.
 464         (psymbol_compare): Update.
 465         * python/py-framefilter.c (extract_sym): Update.
 466         (py_print_single_arg): Update.
 467         * stabsread.c (define_symbol): Update.
 468         * stack.c (print_frame_arg): Update.
 469         (find_frame_funname): Update.
 470         (info_frame_command_core): Update.
 471         * symfile.c (set_initial_language): Update.
 472         * symtab.c (symbol_set_demangled_name): Update.
 473         (symbol_get_demangled_name): Update.
 474         (symbol_set_language): Update.
 475         (symbol_find_demangled_name): Update.
 476         (symbol_set_names): Update.
 477         (general_symbol_info::natural_name): Update.
 478         (general_symbol_info::demangled_name): Update.
 479         (general_symbol_info::search_name): Update.
 480         (symbol_matches_search_name): Update.
 481         (eq_symbol_entry): Update.
 482         (iterate_over_symbols): Update.
 483         (completion_list_add_symbol): Update.
 484         (completion_list_add_msymbol): Update.
 485         (completion_list_add_fields): Update.
 486         * symtab.h (struct general_symbol_info) <language>: New function.
 487         <language>: Rename to...
 488         <m_language>: ...this.
 489         (SYMBOL_LANGUAGE): Remove.
 490         (MSYMBOL_LANGUAGE): Remove.
 491         (struct symbol) <ctor>: Update.
 492         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 493
 494 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 495
 496         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 497         set the language of sym.
 498         * language.c (language_alloc_type_symbol): Likewise.
 499
 500 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 501
 502         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 503         PR gdb/23613
 504         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 505         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 506         (core_target_open): Use 'gdb_abspath'.
 507         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 508         'current_directory == NULL' case.
 509         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 510         explain what happens when 'current_directory' is NULL.
 511         * go32-nat.c (go32_nat_target::wait): Check if
 512         'current_directory' is NULL before call to 'chdir'.
 513         * source.c (add_path): Use 'gdb_abspath'.
 514         * top.c: Include 'gdbsupport/pathstuff.h'.
 515         (init_history): Use 'gdb_abspath'.
 516         (set_history_filename): Likewise.
 517         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 518         (tfile_target_open): Use 'gdb_abspath'.
 519
 520 2019-12-13  Tom Tromey  <tromey@adacore.com>
 521
 522         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 523         warning or error.
 524
 525 2019-12-13  Tom Tromey  <tromey@adacore.com>
 526
 527         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 528
 529 2019-12-13  Tom Tromey  <tromey@adacore.com>
 530
 531         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 532
 533 2019-12-13  Tom Tromey  <tromey@adacore.com>
 534
 535         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 536
 537 2019-12-13  Tom Tromey  <tromey@adacore.com>
 538
 539         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 540         (string_vappendf): Add ARI comment.
 541
 542 2019-12-13  Tom Tromey  <tromey@adacore.com>
 543
 544         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 545         floatformat_to_double.
 546         * target-float.c (host_float_ops<T>::from_target): Add ARI
 547         comment.
 548
 549 2019-12-13  Tom Tromey  <tromey@adacore.com>
 550
 551         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 552         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 553         ARI marker to abort.
 554         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 555
 556 2019-12-13  Tom Tromey  <tromey@adacore.com>
 557
 558         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 559
 560 2019-12-13  Tom Tromey  <tromey@adacore.com>
 561
 562         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 563
 564 2019-12-13  Tom Tromey  <tromey@adacore.com>
 565
 566         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 567         checks.
 568
 569 2019-12-13  Tom Tromey  <tromey@adacore.com>
 570
 571         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 572         end>: No longer "const".
 573
 574 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 575
 576         * jit.c: Fix indentation, replace spaces with tabs where
 577         applicable.
 578
 579 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 580
 581         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 582
 583 2019-12-12  Tom Tromey  <tom@tromey.com>
 584
 585         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 586         unique_ptr.
 587
 588 2019-12-12  Tom Tromey  <tom@tromey.com>
 589
 590         * progspace.h (objfile_list): New typedef.
 591         (class unwrapping_objfile_iterator)
 592         (struct unwrapping_objfile_range): Newl
 593         (struct program_space) <objfiles_range>: Change type.
 594         <objfiles>: Change return type.
 595         <add_objfile>: Change type of "objfile" parameter.
 596         <objfiles_list>: Now a list of shared_ptr.
 597         * progspace.c (program_space::add_objfile): Change type of
 598         "objfile".  Update.
 599         (program_space::remove_objfile): Update.
 600         * objfiles.h (struct objfile) <~objfile>: Make public.
 601         * objfiles.c (objfile::make): Update.
 602         (objfile::unlink): Don't call delete.
 603
 604 2019-12-12  Tom Tromey  <tom@tromey.com>
 605
 606         * symfile.c (symbol_file_clear): Update.
 607         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 608         method.
 609         * progspace.c (program_space::free_all_objfiles): New method.
 610         * objfiles.h (free_all_objfiles): Don't declare.
 611         * objfiles.c (free_all_objfiles): Move to program_space.
 612
 613 2019-12-12  Tom Tromey  <tom@tromey.com>
 614
 615         * progspace.c (program_space::add_objfile)
 616         (program_space::remove_objfile): Update.
 617         (program_space::multi_objfile_p): Remove.
 618         * objfiles.h (struct objfile) <next>: Remove.
 619         * objfiles.c (objfile::objfile): Update.
 620         (put_objfile_before): Update.
 621         (unlink_objfile): Update.
 622         * progspace.h (object_files): Remove.
 623         (struct program_space) <objfiles_head>: Remove.
 624         <objfiles_list>: New member.
 625         <objfiles_range, objfiles_safe_range>: Change type.
 626         (objfiles): Change return type.
 627         (objfiles_safe): Update.
 628         (multi_objfile_p): Rewrite and inline.
 629         (object_files): Remove macro.
 630
 631 2019-12-12  Tom Tromey  <tom@tromey.com>
 632
 633         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 634         second constructor.
 635         (basic_safe_range): New class.
 636
 637 2019-12-12  Tom Tromey  <tom@tromey.com>
 638
 639         * progspace.c (program_space::multi_objfile_p): New method.
 640         * printcmd.c (info_symbol_command): Update.
 641         * maint.c (maintenance_translate_address): Update.
 642         * objfiles.h (MULTI_OBJFILE_P): Remove.
 643         * progspace.h (struct program_space) <multi_objfile_p>: New
 644         method.
 645
 646 2019-12-12  Tom Tromey  <tom@tromey.com>
 647
 648         * progspace.h (struct program_space) <remove_objfile>: Declare.
 649         * progspace.c (program_space::remove_objfile): New method.
 650         * objfiles.c (unlink_objfile): Remove.
 651         (objfile::unlink): Call remove_objfile.
 652         (objfile): Don't call unlink_objfile.
 653
 654 2019-12-12  Tom Tromey  <tom@tromey.com>
 655
 656         * progspace.h (struct program_space) <add_objfile>: Declare
 657         method.
 658         * progspace.c (program_space::add_objfile): New method.
 659         * objfiles.c (~objfile): Don't unlink objfile.
 660         (put_objfile_before): Remove.
 661         (add_separate_debug_objfile): Don't call put_objfile_before.
 662         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 663         the per-program-space data.
 664
 665 2019-12-12  Tom Tromey  <tom@tromey.com>
 666
 667         * symfile.c (syms_from_objfile_1): Use objfile_up.
 668         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 669         method.
 670         (reread_symbols): Use objfile_up.
 671         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 672         unlink method.
 673         * objfiles.h (struct objfile) <~objfile>: Now private.
 674         <unlink>: New method.
 675         (struct objfile_deleter): New.
 676         (objfile_up): New typedef.
 677         * objfiles.c (objfile::unlink): New method.
 678         (free_objfile_separate_debug, free_all_objfiles)
 679         (objfile_purge_solibs): Use it.
 680         * jit.c (jit_unregister_code): Remove.
 681         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 682         objfile.
 683         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 684         objfile.
 685         * compile/compile-object-load.c (compile_object_load): Use
 686         objfile_up.
 687
 688 2019-12-12  Tom Tromey  <tom@tromey.com>
 689
 690         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 691         objfile::make.
 692         * objfiles.h (struct objjfile) <make>: No longer inline.
 693         (add_separate_debug_objfile): Don't declare.
 694         * objfiles.c (add_separate_debug_objfile): Now static.
 695         (objfile::make): Move from objfiles.h.  Call
 696         add_separate_debug_objfile.  Add "parent" parameter.
 697
 698 2019-12-12  Tom Tromey  <tom@tromey.com>
 699
 700         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 701         * objfiles.h (struct objfile): Make constructor private.
 702         <make>: New static method.
 703         * jit.c (jit_object_close_impl): Update.
 704
 705 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 706
 707         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 708         gdb::byte_vector.
 709
 710 2019-12-12  Tom Tromey  <tromey@adacore.com>
 711
 712         * xml-support.c (xml_fetch_content_from_file): Don't call
 713         malloc_failure.
 714         * utils.h (class gdb_argv): Remove malloc_failure comment.
 715         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 716
 717 2019-12-12  Tom Tromey  <tromey@adacore.com>
 718
 719         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 720         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 721         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 722         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 723         * riscv-ravenscar-thread.c: New file.
 724         * riscv-ravenscar-thread.h: New file.
 725         * riscv-tdep.c (riscv_gdbarch_init): Call
 726         register_riscv_ravenscar_ops.
 727
 728 2019-12-12  Tom Tromey  <tromey@adacore.com>
 729
 730         * gdbsupport/thread-pool.c (set_thread_name): Use
 731         ATTRIBUTE_UNUSED.
 732
 733 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 734
 735         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 736         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 737         macros.
 738
 739 2019-12-11  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-win.c (tui_set_win_height_command): Call
 742         tui_adjust_window_height.
 743         (tui_adjust_win_heights, new_height_ok): Remove.
 744         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 745         * tui/tui-layout.c (tui_adjust_window_height): New function.
 746
 747 2019-12-11  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-win.c (tui_resize_all): Remove code, call
 750         tui_apply_current_layout.
 751
 752 2019-12-11  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 755         * tui/tui-layout.c (standard_layouts, applied_layout): New
 756         globals.
 757         (tui_apply_current_layout): New function.
 758         (show_layout): Set applied_layout.  Call
 759         tui_apply_current_layout.
 760         (show_source_command, show_disasm_command)
 761         (show_source_disasm_command, show_data)
 762         (show_source_or_disasm_and_command): Remove.
 763         (initialize_layouts): New function.
 764         (_initialize_tui_layout): Call initialize_layouts.
 765
 766 2019-12-11  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-layout.h (class tui_layout_base)
 769         (class tui_layout_window, class tui_layout_split): New.
 770         * tui/tui-layout.c (tui_get_window_by_name)
 771         (tui_layout_window::clone, tui_layout_window::apply)
 772         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 773         (tui_layout_split::add_window, tui_layout_split::clone)
 774         (tui_layout_split::get_sizes)
 775         (tui_layout_split::set_weights_from_heights)
 776         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 777         functions.
 778         (tui_layout_split::add_split, tui_layout_split::add_split)
 779         (tui_layout_split::set_weights_from_heights)
 780         (tui_layout_split::set_weights_from_heights): New functions.
 781
 782 2019-12-11  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 785         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 786         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 787         * tui/tui-data.h (struct tui_point): Remove.
 788         (struct tui_gen_win_info) <origin>: Remove.
 789         <x, y>: New fields.
 790         * tui/tui-command.c (tui_cmd_window::resize): Update.
 791
 792 2019-12-11  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 795         Implement.
 796         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 797         Implement.
 798         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 799         method.
 800         (struct tui_win_info) <min_height>: Implement.
 801
 802 2019-12-11  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 805         (struct tui_win_info) <can_box>: Update.
 806
 807 2019-12-11  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 810         method.
 811         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 812         method.
 813         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 814         method.
 815         (struct tui_win_info) <max_height>: Now override.
 816
 817 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 818
 819         * NEWS: Create a new section for the next release branch.
 820         Rename the section of the current branch, now that it has
 821         been cut.
 822
 823 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 824
 825         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 826         * version.in: Bump version to 10.0.50.DATE-git.
 827
 828 2019-12-11  Tom Tromey  <tromey@adacore.com>
 829
 830         PR build/25268:
 831         * gdbsupport/thread-pool.c (set_thread_name): New function.
 832         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 833         (thread_pool::thread_function): Call set_thread_name.
 834
 835 2019-12-11  Tom Tromey  <tromey@adacore.com>
 836
 837         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 838         bfd_get_signed_8.
 839
 840 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 841
 842         * NEWS: Document -raw-values option and the related setting commands.
 843         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 844         only set it on when /r is given.
 845         * valprint.c (value_print_option_defs): New element raw-values.
 846         * Makefile.in: Add the new file.
 847
 848 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * gdbsupport/safe-strerror.c: Supress the unused function warning
 851         for select_strerror_r.
 852
 853 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 854
 855         * config.in: Regenerate.
 856         * configure: Regenerate.
 857         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 858         safe_strerror instead of strerror.
 859         * gdbsupport/common.m4: Don't check for strerror.
 860         * gdbsupport/safe-strerror.c: Support both the glibc version
 861         of strerror_r and the XSI version.
 862
 863 2019-12-10  Tom Tromey  <tromey@adacore.com>
 864
 865         * ada-typeprint.c (print_choices): Use a single "?".
 866         (print_variant_part): Print "?" if the discriminant name
 867         is not known.
 868
 869 2019-12-10  George Barrett  <bob@bob131.so>
 870
 871         Fix scripted probe breakpoints.
 872         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 873         declaration forward.
 874         (breakpoint_ops_for_event_location_type)
 875         (breakpoint_ops_for_event_location): Add function definitions.
 876         (break_command_1, trace_command): Use
 877         breakpoint_ops_for_event_location.
 878         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 879         declarations.
 880         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 881         breakpoint_ops_for_event_location.
 882         * python/py-breakpoint.c (bppy_init): Use
 883         breakpoint_ops_for_event_location.
 884
 885 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 886
 887         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 888         when ranking an lvalue argument for an rvalue parameter.
 889
 890 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 891
 892         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 893         template argument for scoped_restore_tmpl from bool to int.
 894
 895 2019-12-07  Keith Seitz  <keiths@redhat.com>
 896
 897         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 898         (build_id_to_debug_bfd): Make static, rewriting to use
 899         build_id_to_bfd_suffix.
 900         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 901         adding `suffix' parameter. Append SUFFIX to file names
 902         when searching for matching files.
 903         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 904         (build_id_to_exec_bfd): Likewise.
 905         * build-id.h (build_id_to_debug_bfd): Clarify that function
 906         searches for BFD of debug info file.
 907         (build_id_to_exec_bfd): Declare.
 908         * corelow.c: Include build-id.h.
 909         (locate_exec_from_corefile_build_id): New function.
 910         (core_target_open): If no executable BFD is found,
 911         search for a core file BFD using build-id.
 912
 913 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 914
 915         * bcache.c: Put in namespace gdb.
 916         * bcache.h: Likewise.
 917         * gdbtypes.c (check_types_worklist): Update.
 918         (types_deeply_equal): Update.
 919         * macrotab.c (struct macro_table) <bcache>: Update.
 920         (new_macro_table): Update.
 921         * macrotab.h (struct bcache): Put this forward declaration
 922         inside namespace gdb.
 923         (new_macro_table): Update.
 924         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 925         Update.
 926         <macro_cache>: Update.
 927         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 928
 929 2019-12-06  Tom de Vries  <tdevries@suse.de>
 930
 931         PR symtab/24971
 932         * block.c (best_symbol, better_symbol): New function.
 933         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 934         decl.
 935
 936 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 937
 938         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 939         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 940         for ranking see-through reference cases.
 941
 942 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 943         * stack.c (faas_command): Check a command is provided.
 944         * thread.c (taas_command, tfaas_command): Likewise.
 945
 946 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 947         * inferior.c (prune_inferiors):  Only call delete_inferior,
 948         Do not modify the inferior list.
 949
 950 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 951
 952         * c-exp.y: Update calls to lookup_typename,
 953         lookup_signed_typename and lookup_unsigned_typename.
 954         * c-lang.c (evaluate_subexp_c): Likewise.
 955         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 956         Likewise.
 957         * eval.c (binop_promote): Likewise.
 958         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 959         (lookup_unsigned_typename): Likewise.
 960         (lookup_signed_typename): Likewise.
 961         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 962         (lookup_signed_typename): Likewise.
 963         (lookup_typename): Likewise.
 964         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 965         lookup_typename, lookup_signed_typename,
 966         lookup_unsigned_typename.
 967         * m2-exp.y: Likewise.
 968         * printcmd.c (printf_wide_c_string): Likewise.
 969         (ui_printf): Likewise.
 970         * python/py-type.c (typy_lookup_typename): Likewise.
 971         * python/py-xmethods.c (python_xmethod_worker::invoke):
 972         Likewise.
 973         * rust-exp.y: Likewise.
 974
 975 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 976
 977         * configure.nat (obsd64): Add missing files x86-nat.o and
 978         nat/x86-dregs.o.
 979
 980 2019-12-04  Tom Tromey  <tom@tromey.com>
 981
 982         * valprint.c (val_print_string): Use metadata_style.
 983         * go-valprint.c (print_go_string): Use metadata style.
 984         * p-valprint.c (pascal_object_print_static_field): Use metadata
 985         style.
 986         * cp-valprint.c (cp_print_static_field): Use metadata style.
 987
 988 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 989             Chris January  <chris.january@arm.com>
 990
 991         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 992         tokens.
 993         (typebase): New patterns for complex, single/double precision, and
 994         single/double complex.
 995         (f77_keywords): Change token for complex keyword, and add single,
 996         double, and precision keywords.
 997
 998 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 999
1000         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1001         "info io_registers".
1002
1003 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1004
1005         * regcache.c (cooked_read_test): Initialize thread list of
1006         mock_inferior.
1007
1008 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1009
1010         * aarch64-linux-tdep.c: Remove includes.
1011
1012 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1013
1014         * aarch64-tdep.c: Remove includes.
1015
1016 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
1017
1018         * filtered-iterator.h (filtered_iterator) <operator==,
1019         operator!=>: Compare wrapped iterators, not wrapped pointers.
1020         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1021         unittests/filtered_iterator-selftests.c.
1022         * unittests/filtered_iterator-selftests.c: New file.
1023
1024 2019-12-04  Tom Tromey  <tromey@adacore.com>
1025
1026         * gdbtypes.c (create_range_type): Inherit endianity
1027         from base type.
1028
1029 2019-12-04  Tom Tromey  <tromey@adacore.com>
1030
1031         * ada-lang.c (decode_constrained_packed_array)
1032         (ada_value_assign, value_assign_to_component): Update.
1033         * dwarf2loc.c (rw_pieced_value, access_memory)
1034         (dwarf2_compile_expr_to_ax): Update.
1035         * dwarf2read.c (dwarf2_add_field): Update.
1036         * eval.c (evaluate_subexp_standard): Update.
1037         * gdbarch.c, gdbarch.h: Rebuild.
1038         * gdbarch.sh (bits_big_endian): Remove.
1039         * gdbtypes.h (union field_location): Update comment.
1040         * target-descriptions.c (make_gdb_type): Update.
1041         * valarith.c (value_bit_index): Update.
1042         * value.c (struct value) <bitpos>: Update comment.
1043         (unpack_bits_as_long, modify_field): Update.
1044         * value.h (value_bitpos): Update comment.
1045
1046 2019-12-04  Tom Tromey  <tromey@adacore.com>
1047
1048         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1049         endian-ness.
1050
1051 2019-12-04  Tom Tromey  <tromey@adacore.com>
1052
1053         * dwarf2read.c (dwarf2_init_float_type)
1054         (dwarf2_init_complex_target_type): Add byte_order parameter.
1055         (read_base_type): Compute byte order earlier.
1056         * gdbtypes.c (init_float_type): Add byte_order parameter.
1057         * gdbtypes.h (init_float_type): Add byte_order parameter.
1058
1059 2019-12-04  Tom Tromey  <tromey@adacore.com>
1060
1061         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1062
1063 2019-12-04  Tom Tromey  <tromey@adacore.com>
1064
1065         * dwarf2read.c (process_structure_scope): Initialize
1066         "discr_offset".
1067
1068 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1071         add it into the search spec.
1072         (parse_max_results_option): New function.
1073         (mi_info_functions_or_variables): Parse -max-results flag and pass
1074         it to mi_symbol_info.
1075         (mi_cmd_symbol_info_modules): Likewise.
1076         (mi_cmd_symbol_info_types): Likewise.
1077         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1078         return type to bool, change result container into a set, and don't
1079         add new results if we have enough already.
1080         (global_symbol_searcher::add_matching_msymbols): Change return
1081         type to bool, and don't add new results if we have enough already.
1082         (sort_search_symbols_remove_dups): Delete.
1083         (global_symbol_searcher::search): Early exit from search loop when
1084         we have enough results.  Use a std::set to collect the results
1085         from calling add_matching_symbols.
1086         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1087         member function.
1088         (global_symbol_searcher) <m_max_search_results>: New member
1089         variable.
1090         (global_symbol_searcher) <add_matching_symbols>: Update header
1091         comment and change return type to bool.
1092         (global_symbol_searcher) <add_matching_msymbols>: Update header
1093         comment and change return type to bool.
1094
1095 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * symtab.c (symbol_search::compare_search_syms): Update header
1098         comment.
1099         (global_symbol_searcher::is_suitable_msymbol): New function.
1100         (global_symbol_searcher::expand_symtabs): New function.
1101         (global_symbol_searcher::add_matching_symbols): New function.
1102         (global_symbol_searcher::add_matching_msymbols): New function.
1103         (global_symbol_searcher::search): Move most of the content
1104         into the new functions above, and call them as needed.
1105         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1106         function.
1107         (global_symbol_searcher) <add_matching_symbols>: New member
1108         function.
1109         (global_symbol_searcher) <add_matching_msymbols>: New member
1110         function.
1111         (global_symbol_searcher) <is_suitable_msymbol>: New member
1112         function.
1113
1114 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1117         -symbol-info-module-variables entries.
1118         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1119         (mi_cmd_symbol_info_module_variables): Declare.
1120         * mi/mi-symbol-cmds.c
1121         (module_symbol_search_iterator): New typedef.
1122         (output_module_symbols_in_single_module_and_file): New function.
1123         (output_module_symbols_in_single_module): New function.
1124         (mi_info_module_functions_or_variables): New function.
1125         (mi_cmd_symbol_info_module_functions): New function.
1126         (mi_cmd_symbol_info_module_variables): New function.
1127         * NEWS: Mention new MI command.
1128
1129 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1130
1131         * bcache.c (hash): Remove.
1132         (hash_continue): Remove.
1133         * bcache.h (hash): Remove.
1134         (hash_continue): Remove.
1135         (struct bcache) <ctor>: Update.
1136         * psymtab.c (psymbol_hash): Update.
1137         * stabsread.c (hashname): Update.
1138         * utils.h (fast_hash): Add an argument for a start value,
1139         defaulting to zero.
1140
1141 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1143         (destroy_block_symbol_cache): New function.
1144         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1145         (resize_symbol_cache): Likewise.
1146
1147 2019-12-02  Tom Tromey  <tom@tromey.com>
1148
1149         * unittests/tui-selftests.c (run_tests): Make conditional.
1150         (_initialize_tui_selftest): Make conditional.
1151
1152 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1153
1154         * aix-thread.c (debug_aix_thread): Change type to bool.
1155
1156 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1157
1158         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1159
1160 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * dwarf2read.c (read_tag_string_type): Read the fields required to
1163         make a dynamic string, and possibly create a dynamic range for the
1164         string.
1165         (attr_to_dynamic_prop): Setup is_reference based on the type of
1166         attribute being processed.
1167         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1168         (resolve_dynamic_array): Rename to...
1169         (resolve_dynamic_array_or_string): ...this, update header comment,
1170         and accept TYPE_CODE_STRING.
1171         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1172
1173 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1176         of its implementation from...
1177         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1178         the new function.
1179
1180 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1183         create a range with stride where appropriate.
1184         * f-valprint.c: Include 'gdbarch.h'.
1185         (f77_print_array_1): Take the stride into account when walking the
1186         array.  Also convert the stride into addressable units.
1187         * gdbtypes.c (create_range_type): Initialise the stride to
1188         constant zero.
1189         (create_range_type_with_stride): New function, initialise the
1190         range as normal, and then setup the stride.
1191         (has_static_range): Include the stride here.  Also change the
1192         return type to bool.
1193         (create_array_type_with_stride): Consider the range stride if the
1194         array isn't given its own stride.
1195         (resolve_dynamic_range): Resolve the stride if needed.
1196         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1197         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1198         (TYPE_BIT_STRIDE): Define.
1199         (TYPE_ARRAY_BIT_STRIDE): Define.
1200         (create_range_type_with_stride): Declare.
1201         * valarith.c (value_subscripted_rvalue): Take range stride into
1202         account when walking the array.
1203
1204 2019-12-01  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1207         specially.
1208
1209 2019-12-01  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1212         \0.
1213         * unittests/tui-selftests.c: New file.
1214         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1215
1216 2019-12-01  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1219
1220 2019-12-01  Tom Tromey  <tom@tromey.com>
1221
1222         * NEWS: Document new settings.
1223         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1224         * tui/tui-win.c (_initialize_tui_win): Add border style
1225         observers.
1226         * tui/tui-io.h (tui_apply_style): Declare.
1227         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1228         longer static.
1229         (apply_ansi_escape, tui_set_reverse_mode): Update.
1230         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1231         Add "skip_intensity" parameter.
1232         <changed>: New member.
1233         <do_set_value>: Declare.
1234         (tui_border_style, tui_active_border_style): Declare.
1235         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1236         globals.
1237         (cli_style_option): Initialize "changed".
1238         (cli_style_option::do_set_value): New function.
1239         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1240         parameter.  Update.
1241         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1242         (_initialize_cli_style): Update.  Create TUI border style
1243         commands.
1244
1245 2019-12-01  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1248         parameter.
1249         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1250         parameter.
1251         * tui/tui-win.h (compact_source): Declare.
1252         * tui/tui-win.c (compact_source): New global.
1253         (tui_set_compact_source, tui_show_compact_source): New functions.
1254         (_initialize_tui_win): Add "compact-source" setting.
1255         * tui/tui-source.c (tui_source_window::set_contents): Handle
1256         compact_source setting.
1257         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1258         * NEWS: Document new setting.
1259
1260 2019-11-30  Tom Tromey  <tom@tromey.com>
1261
1262         * dwarf2read.c (dwarf2_add_field): Include field offset when
1263         computing variant part length.
1264
1265 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266         * NEWS:  Mention define-prefix.  Tell that command names can now
1267         contain a . character.
1268
1269 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * command.h (valid_cmd_char_p): Declare.
1272         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1273         the check of valid command char.
1274         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1275         valid_cmd_char_p.
1276         * cli/cli-script.c (validate_comname): Likewise.
1277         * completer.c (gdb_completer_command_word_break_characters):
1278         Do not remove . from the word break char, update comments.
1279         (complete_line_internal_1): Use valid_cmd_char_p.
1280         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1281         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1282
1283 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1284
1285         * cli/cli-script.c (do_define_command): Ensure a redefined
1286         prefix command is kept as a prefix command.
1287         (define_prefix_command): New function.
1288         (show_user_1): Report user defined prefixes.
1289         (_initialize_cli_script):  Create the new 'define-prefix' command.
1290         Add completers for 'define' and 'document'.
1291         * top.c (execute_command):  If command is a user-defined prefix only
1292         command, report the list of commands for this prefix command.
1293
1294 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1295
1296         * valops.c (find_oload_champ): Improve debug output.
1297
1298 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1299
1300         * valops.c (find_oload_champ): Print part of debug messages
1301         before the badness vector is std::move'd.
1302
1303 2019-11-28  Tom Tromey  <tom@tromey.com>
1304
1305         * value.c (creal_internal_fn): Fix comment.
1306
1307 2019-11-28  Tom Tromey  <tom@tromey.com>
1308
1309         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1310         flag_bound_evaluated>: Now unsigned.
1311
1312 2019-11-28  Tom Tromey  <tom@tromey.com>
1313
1314         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1315         declare.
1316
1317 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1318
1319         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1320         debug output.
1321         * jit.c (jit_unregister_code): Add debug print to match
1322         `jit_register_code`.
1323
1324 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1325
1326         * NEWS: Mention the new multithreaded symbol loading.
1327
1328 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1329
1330         * maint.c (n_worker_threads): Default to 0.
1331         (worker_threads_disabled): New function.
1332         * maint.h (worker_threads_disabled): New function.
1333         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1334         here if worker_threads_disabled () is true.
1335         (minimal_symbol_reader::install): Skip all threading if
1336         worker_threads_disabled () is true.
1337
1338 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1339
1340         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1341         hash code if possible.
1342         (add_minsym_to_demangled_hash_table): Likewise.
1343         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1344         on the background thread.
1345         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1346         Add these fields.
1347
1348 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1349
1350         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1351         of the mangled name on the background thread.
1352         * symtab.c (symbol_set_names): Allow passing in the hash of the
1353         linkage_name.
1354         * symtab.h (symbol_set_names): Likewise.
1355
1356 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1357
1358         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1359         physnames are computed for inherited DIEs.
1360
1361 2019-11-27  Tom Tromey  <tromey@adacore.com>
1362
1363         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1364         backslashes.
1365         * cp-support.c: Remove unnecessary backslashes.
1366
1367 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1368
1369         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1370         with sym->set_linkage_name.
1371         * coffread.c (coff_read_enum_type): Likewise.
1372         * mdebugread.c (parse_symbol): Likewise.
1373         * stabsread.c (patch_block_stabs): Likewise.
1374         (define_symbol): Likewise.
1375         (read_enum_type): Likewise.
1376         (common_block_end): Likewise.
1377         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1378         function.
1379         (SYMBOL_SET_LINKAGE_NAME): Remove.
1380         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1381         with sym->set_linkage_name.
1382
1383 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1386         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1387         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1388         * NEWS: Mention new MI command.
1389
1390 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1393         '-symbol-info-types', and '-symbol-info-variables'.
1394         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1395         (mi_cmd_symbol_info_types): Declare.
1396         (mi_cmd_symbol_info_variables): Declare.
1397         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1398         (output_debug_symbol): New function.
1399         (output_nondebug_symbol): New function.
1400         (mi_symbol_info): New function.
1401         (mi_info_functions_or_variables): New function.
1402         (mi_cmd_symbol_info_functions): New function.
1403         (mi_cmd_symbol_info_types): New function.
1404         (mi_cmd_symbol_info_variables): New function.
1405         * NEWS: Mention new commands.
1406
1407 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * symtab.c (symbol_to_info_string): New function, most content
1410         moved from print_symbol_info, but updated to return a std::string.
1411         (print_symbol_info): Update to use symbol_to_info_string and print
1412         returned string.
1413         * symtab.h (symbol_to_info_string): Declare new function.
1414
1415 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * python/python.c (gdbpy_rbreak): Convert to using
1418         global_symbol_searcher.
1419         * symtab.c (file_matches): Convert return type to bool, change
1420         file list to std::vector, update header comment.
1421         (search_symbols): Rename to...
1422         (global_symbol_searcher::search): ...this and update now its
1423         a member function of global_symbol_searcher.  Take account of the
1424         changes to file_matches.
1425         (symtab_symbol_info): Convert to using global_symbol_searcher.
1426         (rbreak_command): Likewise.
1427         (search_module_symbols): Likewise.
1428         * symtab.h (enum symbol_search): Update comment.
1429         (search_symbols): Remove declaration.
1430         (class global_symbol_searcher): New class.
1431
1432 2019-11-26  Tom Tromey  <tromey@adacore.com>
1433
1434         * cp-support.c (_initialize_cp_support): Conditionally initialize
1435         gdb_demangle_attempt_core_dump.
1436
1437 2019-11-26  Tom Tromey  <tom@tromey.com>
1438
1439         * python/py-function.c (fnpy_init): Update.
1440         * value.h (add_internal_function): Adjust declaration.
1441         * value.c (function_destroyer): Remove.
1442         (do_add_internal_function): Don't set destroyer or copy name.
1443         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1444         Set name_allocated.
1445         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1446         (cmdpy_init): Set name_allocated.
1447         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1448         member.
1449         (~cmd_list_element): Free "name" if needed.
1450
1451 2019-11-26  Tom Tromey  <tom@tromey.com>
1452
1453         * value.h (add_internal_function): Add new overload.  Move
1454         documentation from value.h.
1455         * value.c (do_add_internal_function): New function.
1456         (add_internal_function): Use it.  Add new overload.
1457         (function_destroyer): Don't free doc.
1458         * python/py-function.c (fnpy_init): Update.
1459
1460 2019-11-26  Tom Tromey  <tom@tromey.com>
1461
1462         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1463         (cmdpy_init): Set "doc_allocated".
1464
1465 2019-11-26  Tom Tromey  <tom@tromey.com>
1466
1467         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1468         name of worker thread.
1469         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1470         pthread_setname_np.
1471         * configure, config.in: Rebuild.
1472
1473 2019-11-26  Tom Tromey  <tom@tromey.com>
1474
1475         * python/python.c (class gdbpy_gil): New.
1476         (struct gdbpy_event): Add constructor, destructor, operator().
1477         (gdbpy_post_event): Use run_on_main_thread.
1478         (gdbpy_initialize_events): Remove.
1479         (do_start_initialization): Update.
1480
1481 2019-11-26  Tom Tromey  <tom@tromey.com>
1482
1483         * NEWS: Add entry.
1484         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1485         commands.  Call update_thread_pool_size.
1486         (update_thread_pool_size, maintenance_set_worker_threads): New
1487         functions.
1488         (n_worker_threads): New global.
1489
1490 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1491             Tom Tromey  <tom@tromey.com>
1492
1493         * minsyms.c (minimal_symbol_reader::install): Use
1494         parallel_for_each.
1495         * gdbsupport/parallel-for.h: New file.
1496         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1497
1498 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1499             Tom Tromey  <tom@tromey.com>
1500
1501         * gdbsupport/thread-pool.h: New file.
1502         * gdbsupport/thread-pool.c: New file.
1503         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1504         (HFILES_NO_SRCDIR): Add thread-pool.h.
1505
1506 2019-11-26  Tom Tromey  <tom@tromey.com>
1507
1508         * event-top.h (thread_local_segv_handler): Declare.
1509         * event-top.c (thread_local_segv_handler): New global.
1510         (install_handle_sigsegv, handle_sigsegv): New functions.
1511         (async_init_signals): Install SIGSEGV handler.
1512         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1513         thread-local.
1514         (report_failed_demangle): New function.
1515         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1516         handler-setting code, instead use segv_handler.  Run warning code
1517         on main thread.
1518
1519 2019-11-26  Tom Tromey  <tom@tromey.com>
1520
1521         * run-on-main-thread.c: New file.
1522         * run-on-main-thread.h: New file.
1523         * unittests/main-thread-selftests.c: New file.
1524         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1525         main-thread-selftests.c.
1526         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1527         (COMMON_SFILES): Add run-on-main-thread.c.
1528
1529 2019-11-26  Tom Tromey  <tom@tromey.com>
1530
1531         * main.c (setup_alternate_signal_stack): Remove.
1532         (captured_main_1): Use gdb::alternate_signal_stack.
1533         * gdbsupport/alt-stack.h: New file.
1534
1535 2019-11-26  Tom Tromey  <tom@tromey.com>
1536
1537         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1538         Remove comment.
1539         (save_original_signals_state, restore_original_signals_state): Use
1540         gdb_sigmask.
1541         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1542         (_initialize_linux_nat): Use gdb_sigmask.
1543         * guile/guile.c (_initialize_guile): Use block_signals.
1544         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1545         * gdbsupport/gdb-sigmask.h: New file.
1546         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1547         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1548         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1549         pthread_sigmask.
1550         * configure, config.in: Rebuild.
1551         * gdbsupport/block-signals.h: New file.
1552
1553 2019-11-26  Tom Tromey  <tom@tromey.com>
1554
1555         * acinclude.m4: Include ax_pthread.m4.
1556         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1557         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1558         (CLIBS): Use PTHREAD_LIBS.
1559         (aclocal_m4_deps): Add ax_pthread.m4.
1560         * config.in, configure: Rebuild.
1561         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1562
1563 2019-11-26  Tom Tromey  <tom@tromey.com>
1564
1565         * symtab.h (struct minimal_symbol) <name_set>: New member.
1566         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1567         Don't call symbol_set_names.
1568         (minimal_symbol_reader::install): Call symbol_set_names.
1569
1570 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1571
1572         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1573         restore_active_ext_lang, as GIL is needed for (indirectly)
1574         called PyOS_InterruptOccurred.
1575
1576 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1577
1578         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1579         definition.
1580
1581 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1582
1583         * remote-sim.c (simulator_command): Make static, remove
1584         declaration.
1585
1586 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1587
1588         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1589         static.
1590         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1591         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1592         (main): Likewise.
1593         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1594         (main): Likewise.
1595         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1596         (main): Likewise.
1597         * unittests/basic_string_view/element_access/char/1.cc (test01):
1598         Likewise.
1599         (main): Likewise.
1600         * unittests/basic_string_view/element_access/char/empty.cc (main):
1601         Likewise.
1602         * unittests/basic_string_view/element_access/char/front_back.cc
1603         (test01): Likewise.
1604         (main): Likewise.
1605         * unittests/basic_string_view/inserters/char/2.cc (test05):
1606         Likewise.
1607         (main): Likewise.
1608         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1609         (test01): Likewise.
1610         (main): Likewise.
1611         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1612         (test01): Likewise.
1613         (main): Likewise.
1614         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1615         Likewise.
1616         * unittests/basic_string_view/operations/compare/char/1.cc
1617         (test01): Likewise.
1618         (main): Likewise.
1619         * unittests/basic_string_view/operations/compare/char/13650.cc
1620         (test01): Likewise.
1621         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1622         Likewise.
1623         (main): Likewise.
1624         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1625         Likewise.
1626         (main): Likewise.
1627         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1628         Likewise.
1629         (main): Likewise.
1630         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1631         Likewise.
1632         (main): Likewise.
1633         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1634         Likewise.
1635         (main): Likewise.
1636         * unittests/basic_string_view/operations/find/char/4.cc (main):
1637         Likewise.
1638         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1639         Likewise.
1640         (main): Likewise.
1641         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1642         Likewise.
1643         (main): Likewise.
1644         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1645         Likewise.
1646         (main): Likewise.
1647         * unittests/basic_string_view/operations/substr/char/1.cc
1648         (test01): Likewise.
1649         (main): Likewise.
1650         * unittests/basic_string_view/operators/char/2.cc (main):
1651         Likewise.
1652         * unittests/optional/assignment/1.cc (test): Likewise.
1653         * unittests/optional/assignment/2.cc (test): Likewise.
1654         * unittests/optional/assignment/3.cc (test): Likewise.
1655         * unittests/optional/assignment/4.cc (test): Likewise.
1656         * unittests/optional/assignment/5.cc (test): Likewise.
1657         * unittests/optional/assignment/6.cc (test): Likewise.
1658         * unittests/optional/assignment/7.cc (test): Likewise.
1659         * unittests/optional/cons/copy.cc (test): Likewise.
1660         * unittests/optional/cons/default.cc (test): Likewise.
1661         * unittests/optional/cons/move.cc (test): Likewise.
1662         * unittests/optional/cons/value.cc (test): Likewise.
1663         * unittests/optional/in_place.cc (test): Likewise.
1664         * unittests/optional/observers/1.cc (test): Likewise.
1665         * unittests/optional/observers/2.cc (test): Likewise.
1666
1667 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1668
1669         * tui-win.h (tui_set_var_cmd): Remove.
1670         * tui-win.c (tui_set_var_cmd): Make static.
1671
1672 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1673
1674         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1675         rbreak_command_wrapper): Remove.
1676         * symtab.c (rbreak_command_wrapper): Remove.
1677
1678 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1679
1680         * inferior.h (info_terminal_command): Remove declaration.
1681         * inflow.c (info_terminal_command): Make static.
1682
1683 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1684
1685         * inferior.c (exit_inferior_silent): Remove.
1686
1687 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1688
1689         * dictionary.c (dict_empty, mdict_empty): Remove.
1690         * dictionary.c (mdict_empty): Remove.
1691
1692 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1693
1694          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1695          (arc_insn_get_memory_offset): Likewise.
1696          (arc_insn_dump): Likewise.
1697          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1698          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1699          * dictionary.c (dict_iterator_next): Likewise.
1700          (dict_iter_match_first): Likewise.
1701          (dict_iter_match_next): Likewise.
1702          * f-lang.c (evaluate_subexp_f): Likewise.
1703          * hppa-tdep.c (hppa_read_pc): Likewise.
1704          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1705          * parse.c (write_exp_elt_msym): Likewise.
1706          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1707          * remote.c (remote_packet_size): Likewise.
1708          (remote_notif_stop_parse): Likewise.
1709          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1710          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1711          * source.c (prepare_path_for_appending): Likewise.
1712          * sparc64-linux-tdep.c
1713          (sparc64_linux_handle_segmentation_fault); Likewise.
1714          * stack.c (frame_selection_by_function_completer): Likewise.
1715
1716 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1717
1718         * completer.c (set_gdb_completion_word_break_characters):
1719         Remove.
1720
1721 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1722
1723         * dwarf-index-write.c: Include dwarf-index-write.h.
1724         * mi/mi-interp.c: Include mi/mi-interp.h.
1725
1726 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1727
1728         * aarch32-tdep.c: Include aarch32-tdep.h.
1729         * aarch32-tdep.h: Forward-declare struct target_desc.
1730
1731 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1732
1733         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1734         strerror.
1735         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1736         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1737
1738 2019-11-25  Tom de Vries  <tdevries@suse.de>
1739
1740         * contrib/words.sh: Add -c option.
1741
1742 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1743
1744         * solib.c (solib_find_1): Change int to bool.
1745         (exec_file_find): Change int to bool.
1746         (solib_find): Change int to bool.
1747         (solib_read_symbols): Change int to bool.
1748         (solib_used): Change int to bool.
1749         (solib_add): Change int to bool.
1750         (info_sharedlibrary_command): Change int to bool.
1751         (solib_contains_address_p): Change int to bool.
1752         (solib_keep_data_in_core): Change int to bool.
1753         (in_solib_dynsym_resolve_code): Change int to bool.
1754         (reload_shared_libraries_1): Change int to bool.
1755         (gdb_sysroot_changed): Change int to bool.
1756         * solib.h (solib_read_symbols): Change int to bool.
1757         (solib_contains_address_p): Change int to bool.
1758         (solib_keep_data_in_core): Change int to bool.
1759         (in_solib_dynsym_resolve_code): Change int to bool.
1760         (libpthread_name_p): Change int to bool.
1761
1762 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1763
1764         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1765         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1766         (remote_packet_max_chars): New static global.
1767         (show_remote_packet_max_chars): New function.
1768         (remote_target::putpkt_binary): Adjust to use new
1769         remote_packet_max_chars option.
1770         (remote_target::getpkt_or_notif_sane_1): Likewise.
1771         (_initialize_remote): Register new remote-packet-max-chars option.
1772
1773 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1774
1775         * m68k-linux-nat.c: Include gdbarch.h.
1776
1777 2019-11-24  Tom Tromey  <tom@tromey.com>
1778
1779         * symfile.c (read_symbols): Update.
1780         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1781         bool.
1782         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1783         (psym_lookup_symbol, psym_find_last_source_symtab)
1784         (psym_forget_cached_source_info, psym_print_stats)
1785         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1786         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1787         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1788         (psym_find_compunit_symtab_by_address)
1789         (maintenance_print_psymbols, maintenance_info_psymtabs)
1790         (maintenance_check_psymtabs): Update.
1791         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1792         bool.
1793
1794 2019-11-22  Tom Tromey  <tom@tromey.com>
1795
1796         * observable.h: Update comments.
1797
1798 2019-11-22  Tom Tromey  <tromey@adacore.com>
1799
1800         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1801         (print_ada_task_info): Don't try to fetch thread id if task is not
1802         alive.
1803
1804 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1805
1806         * ada-exp.y: Update.
1807         * ada-lang.c (sort_choices): Update.
1808         (ada_print_symbol_signature): Update.
1809         (resolve_subexp): Update.
1810         (ada_parse_renaming): Update.
1811         (ada_read_renaming_var_value): Update.
1812         (lesseq_defined_than): Update.
1813         (remove_extra_symbols): Update.
1814         (remove_irrelevant_renamings): Update.
1815         (ada_add_block_symbols): Update.
1816         (ada_collect_symbol_completion_matches): Update.
1817         (ada_is_renaming_symbol): Update.
1818         (aggregate_assign_from_choices): Update.
1819         (ada_evaluate_subexp): Update.
1820         (ada_has_this_exception_support): Update.
1821         (ada_is_non_standard_exception_sym): Update.
1822         (ada_add_exceptions_from_frame): Update.
1823         (ada_add_global_exceptions): Update.
1824         (ada_print_subexp): Update.
1825         * ax-gdb.c (gen_var_ref): Update.
1826         (gen_maybe_namespace_elt): Update.
1827         (gen_expr_for_cast): Update.
1828         (gen_expr): Update.
1829         * block.h: Update.
1830         * blockframe.c (find_pc_partial_function): Update.
1831         * breakpoint.c (print_breakpoint_location): Update.
1832         (update_static_tracepoint): Update.
1833         * btrace.c (ftrace_print_function_name): Update.
1834         (ftrace_function_switched): Update.
1835         * buildsym.c (find_symbol_in_list): Update.
1836         * c-exp.y: Update.
1837         * c-typeprint.c (c_print_typedef): Update.
1838         (c_type_print_template_args): Update.
1839         * cli/cli-cmds.c (edit_command): Update.
1840         (list_command): Update.
1841         (print_sal_location): Update.
1842         * coffread.c (patch_opaque_types): Update.
1843         (process_coff_symbol): Update.
1844         (coff_read_enum_type): Update.
1845         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1846         (convert_one_symbol): Update.
1847         (hash_symname): Update.
1848         (eq_symname): Update.
1849         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1850         * compile/compile-cplus-types.c (debug_print_scope): Update.
1851         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1852         * compile/compile-object-load.c (get_out_value_type): Update.
1853         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1854         (search_symbol_list): Update.
1855         (cp_lookup_symbol_imports_or_template): Update.
1856         * cp-support.c (overload_list_add_symbol): Update.
1857         * ctfread.c (psymtab_to_symtab): Update.
1858         * dbxread.c (cp_set_block_scope): Update.
1859         * dictionary.c (iter_match_first_hashed): Update.
1860         (iter_match_next_hashed): Update.
1861         (insert_symbol_hashed): Update.
1862         (iter_match_next_linear): Update.
1863         * dictionary.h: Update.
1864         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1865         (locexpr_describe_location_piece): Update.
1866         (locexpr_describe_location_1): Update.
1867         (locexpr_generate_c_location): Update.
1868         (loclist_describe_location): Update.
1869         (loclist_generate_c_location): Update.
1870         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1871         (read_func_scope): Update.
1872         (process_enumeration_scope): Update.
1873         (new_symbol): Update.
1874         (dwarf2_const_value): Update.
1875         (dwarf2_symbol_mark_computed): Update.
1876         * eval.c (evaluate_funcall): Update.
1877         (evaluate_subexp_standard): Update.
1878         * expprint.c (print_subexp_standard): Update.
1879         (dump_subexp_body_standard): Update.
1880         * f-valprint.c (info_common_command_for_block): Update.
1881         * findvar.c (get_hosting_frame): Update.
1882         (default_read_var_value): Update.
1883         * go-lang.c (go_symbol_package_name): Update.
1884         * guile/scm-block.c (bkscm_print_block_smob): Update.
1885         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1886         (gdbscm_symbol_name): Update.
1887         (gdbscm_symbol_linkage_name): Update.
1888         (gdbscm_symbol_print_name): Update.
1889         * infcall.c (get_function_name): Update.
1890         * infcmd.c (jump_command): Update.
1891         (finish_command): Update.
1892         * infrun.c (insert_exception_resume_breakpoint): Update.
1893         * linespec.c (canonicalize_linespec): Update.
1894         (create_sals_line_offset): Update.
1895         (convert_linespec_to_sals): Update.
1896         (complete_label): Update.
1897         (find_label_symbols_in_block): Update.
1898         * m2-typeprint.c (m2_print_typedef): Update.
1899         * mdebugread.c (mdebug_reg_to_regnum): Update.
1900         (parse_symbol): Update.
1901         (mylookup_symbol): Update.
1902         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1903         (list_args_or_locals): Update.
1904         * objc-lang.c (compare_selectors): Update.
1905         (info_selectors_command): Update.
1906         (compare_classes): Update.
1907         (info_classes_command): Update.
1908         (find_imps): Update.
1909         * p-typeprint.c (pascal_print_typedef): Update.
1910         * printcmd.c (build_address_symbolic): Update.
1911         (info_address_command): Update.
1912         (print_variable_and_value): Update.
1913         * python/py-framefilter.c (extract_sym): Update.
1914         (py_print_single_arg): Update.
1915         * python/py-symbol.c (sympy_str): Update.
1916         (sympy_get_name): Update.
1917         (sympy_get_linkage_name): Update.
1918         * python/python.c (gdbpy_rbreak): Update.
1919         * record-btrace.c (btrace_get_bfun_name): Update.
1920         (btrace_call_history): Update.
1921         * rust-lang.c (rust_print_typedef): Update.
1922         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1923         * stabsread.c (stab_reg_to_regnum): Update.
1924         (define_symbol): Update.
1925         (read_enum_type): Update.
1926         (common_block_end): Update.
1927         (cleanup_undefined_types_1): Update.
1928         (scan_file_globals): Update.
1929         * stack.c (print_frame_arg): Update.
1930         (print_frame_args): Update.
1931         (find_frame_funname): Update.
1932         (info_frame_command_core): Update.
1933         (iterate_over_block_locals): Update.
1934         (print_block_frame_labels): Update.
1935         (do_print_variable_and_value): Update.
1936         (iterate_over_block_arg_vars): Update.
1937         (return_command): Update.
1938         * symmisc.c (dump_symtab_1): Update.
1939         (print_symbol): Update.
1940         * symtab.c (eq_symbol_entry): Update.
1941         (symbol_cache_dump): Update.
1942         (lookup_language_this): Update.
1943         (find_pc_sect_line): Update.
1944         (skip_prologue_sal): Update.
1945         (symbol_search::compare_search_syms): Update.
1946         (treg_matches_sym_type_name): Update.
1947         (search_symbols): Update.
1948         (print_symbol_info): Update.
1949         (rbreak_command): Update.
1950         (completion_list_add_symbol): Update.
1951         (find_gnu_ifunc): Update.
1952         (get_symbol_address): Update.
1953         (search_module_symbols): Update.
1954         (info_module_subcommand): Update.
1955         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1956         (SYMBOL_LINKAGE_NAME): Remove.
1957         (SYMBOL_DEMANGLED_NAME): Remove.
1958         (SYMBOL_PRINT_NAME): Remove.
1959         (SYMBOL_SEARCH_NAME): Remove.
1960         * tracepoint.c (set_traceframe_context): Update.
1961         (validate_actionline): Update.
1962         (collection_list::collect_symbol): Update.
1963         (encode_actions_1): Update.
1964         (info_scope_command): Update.
1965         (print_one_static_tracepoint_marker): Update.
1966         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1967         * valops.c (address_of_variable): Update.
1968         (find_overload_match): Update.
1969         (find_oload_champ): Update.
1970
1971 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1972
1973         * ada-lang.c (ada_lookup_simple_minsym): Update.
1974         (ada_collect_symbol_completion_matches): Update.
1975         * ada-tasks.c (read_atcb): Update.
1976         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1977         (amd64_windows_skip_trampoline_code): Update.
1978         * arm-tdep.c (skip_prologue_function): Update.
1979         (arm_skip_stack_protector): Update.
1980         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1981         (arm_wince_skip_main_prologue): Update.
1982         * ax-gdb.c (gen_expr): Update.
1983         * block.c (call_site_for_pc): Update.
1984         * blockframe.c (find_pc_partial_function): Update.
1985         * breakpoint.c (set_breakpoint_location_function): Update.
1986         * btrace.c (ftrace_print_function_name): Update.
1987         (ftrace_function_switched): Update.
1988         * c-valprint.c (print_unpacked_pointer): Update.
1989         * coffread.c (coff_symfile_read): Update.
1990         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1991         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1992         * dwarf-index-write.c (write_psymbols): Update.
1993         * dwarf2loc.c (call_site_to_target_addr): Update.
1994         (func_verify_no_selftailcall): Update.
1995         (tailcall_dump): Update.
1996         (call_site_find_chain_1): Update.
1997         (dwarf_expr_reg_to_entry_parameter): Update.
1998         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1999         * eval.c (evaluate_funcall): Update.
2000         (evaluate_subexp_standard): Update.
2001         (evaluate_subexp_for_sizeof): Update.
2002         * expprint.c (print_subexp_standard): Update.
2003         (dump_subexp_body_standard): Update.
2004         * frame.c (get_prev_frame_always_1): Update.
2005         * frv-tdep.c (frv_skip_main_prologue): Update.
2006         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2007         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2008         (gnuv3_get_typename_from_type_info): Update.
2009         (gnuv3_skip_trampoline): Update.
2010         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2011         * i386-tdep.c (i386_skip_main_prologue): Update.
2012         (i386_pe_skip_trampoline_code): Update.
2013         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2014         * infcall.c (get_function_name): Update.
2015         * linespec.c (minsym_found): Update.
2016         * linux-fork.c (info_checkpoints_command): Update.
2017         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2018         (m32c_m16c_pointer_to_address): Update.
2019         * maint.c (maintenance_translate_address): Update.
2020         * minsyms.c (add_minsym_to_hash_table): Update.
2021         (add_minsym_to_demangled_hash_table): Update.
2022         (lookup_minimal_symbol_mangled): Update.
2023         (lookup_minimal_symbol_demangled): Update.
2024         (lookup_minimal_symbol_linkage): Update.
2025         (lookup_minimal_symbol_text): Update.
2026         (lookup_minimal_symbol_by_pc_name): Update.
2027         (minimal_symbol_is_less_than): Update.
2028         (compact_minimal_symbols): Update.
2029         (build_minimal_symbol_hash_tables): Update.
2030         (find_solib_trampoline_target): Update.
2031         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2032         (mips_skip_pic_trampoline_code): Update.
2033         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2034         * objc-lang.c (info_selectors_command): Update.
2035         (info_classes_command): Update.
2036         (find_methods): Update.
2037         (find_imps): Update.
2038         * p-valprint.c (pascal_val_print): Update.
2039         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2040         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2041         * printcmd.c (build_address_symbolic): Update.
2042         (info_symbol_command): Update.
2043         * psymtab.c (psymbol_name_matches): Update.
2044         (match_partial_symbol): Update.
2045         (lookup_partial_symbol): Update.
2046         (print_partial_symbols): Update.
2047         (sort_pst_symbols): Update.
2048         (maintenance_check_psymtabs): Update.
2049         * python/py-framefilter.c (py_print_frame): Update.
2050         * python/python.c (gdbpy_rbreak): Update.
2051         * record-btrace.c (btrace_get_bfun_name): Update.
2052         (btrace_call_history): Update.
2053         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2054         (rs6000_skip_trampoline_code): Update.
2055         * sol-thread.c (info_cb): Update.
2056         * stabsread.c (scan_file_globals): Update.
2057         * stack.c (find_frame_funname): Update.
2058         (info_frame_command_core): Update.
2059         * symmisc.c (dump_msymbols): Update.
2060         * symtab.c (symbol_natural_name): Rename to..,
2061         (general_symbol_info::natural_name): ...this.
2062         (symbol_demangled_name): Rename to...
2063         (general_symbol_info::demangled_name): ...this.
2064         (symbol_search_name): Rename to...
2065         (general_symbol_info::search_name): ...this.
2066         (symbol_matches_search_name): Update.
2067         (find_pc_sect_line): Update.
2068         (skip_prologue_sal): Update.
2069         (search_symbols): Update.
2070         (print_msymbol_info): Update.
2071         (rbreak_command): Update.
2072         (completion_list_add_msymbol): Update.
2073         (completion_list_objc_symbol): Update.
2074         (get_msymbol_address): Update.
2075         * symtab.h (struct general_symbol_info): Add member functions
2076         natural_name (), linkage_name (), print_name (), demangled_name (),
2077         and search_name ().
2078         (SYMBOL_NATURAL_NAME): Update.
2079         (symbol_natural_name): Move to a member function on general_symbol_info.
2080         (SYMBOL_DEMANGLED_NAME): Update.
2081         (symbol_demangled_name): Move to a member function on
2082         general_symbol_info.
2083         (SYMBOL_SEARCH_NAME): Update.
2084         (symbol_search_name): Move to a member function on general_symbol_info.
2085         (MSYMBOL_NATURAL_NAME): Remove.
2086         (MSYMBOL_LINKAGE_NAME): Remove.
2087         (MSYMBOL_PRINT_NAME): Remove.
2088         (MSYMBOL_DEMANGLED_NAME): Remove.
2089         (MSYMBOL_SEARCH_NAME): Remove.
2090         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2091
2092 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2093
2094         * symtab.c (create_demangled_names_hash): Use per_bfd->
2095         minimal_symbol_count for computing the initial size, if greater
2096         than our default size.
2097
2098 2019-11-22  Tom de Vries  <tdevries@suse.de>
2099
2100         * contrib/words.sh: Improve words extraction.
2101
2102 2019-11-22  Tom de Vries  <tdevries@suse.de>
2103
2104         * contrib/words.sh: Combine sed invocations.
2105
2106 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2107
2108         * Makefile.in: Update.
2109         * demangle.c: Rename to...
2110         * gdb-demangle.c: ..this.
2111         (is_cplus_marker): Change return type to bool.
2112         (_initialize_demangler): Rename to...
2113         (_initialize_gdb_demangle): ...this.
2114         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2115         * symtab.h (demangle): Remove declaration; instead include
2116         gdb-demangle.h.
2117
2118 2019-11-21  Tom Tromey  <tromey@adacore.com>
2119
2120         * gdbsupport/format.c (format_pieces): Parse %I64d.
2121         * unittests/format_pieces-selftests.c (test_windows_formats): New
2122         function.
2123         (run_tests): Call it.
2124
2125 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2126
2127         Byte reverse display of variables with DW_END_big, DW_END_little
2128         (DW_AT_endianity) dwarf attributes if different than the native
2129         byte order.
2130         * ada-lang.c (ada_value_binop):
2131         Use type_byte_order instead of gdbarch_byte_order.
2132         * ada-valprint.c (printstr):
2133         (ada_val_print_string):
2134         * ada-lang.c (value_pointer):
2135         (ada_value_binop):
2136         Use type_byte_order instead of gdbarch_byte_order.
2137         * c-lang.c (c_get_string):
2138         Use type_byte_order instead of gdbarch_byte_order.
2139         * c-valprint.c (c_val_print_array):
2140         Use type_byte_order instead of gdbarch_byte_order.
2141         * cp-valprint.c (cp_print_class_member):
2142         Use type_byte_order instead of gdbarch_byte_order.
2143         * dwarf2loc.c (rw_pieced_value):
2144         Use type_byte_order instead of gdbarch_byte_order.
2145         * dwarf2read.c (read_base_type): Handle DW_END_big,
2146         DW_END_little
2147         * f-lang.c (f_get_encoding):
2148         Use type_byte_order instead of gdbarch_byte_order.
2149         * findvar.c (default_read_var_value):
2150         Use type_byte_order instead of gdbarch_byte_order.
2151         * gdbtypes.c (check_types_equal):
2152         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2153         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2154         and TYPE_ENDIANITY_LITTLE if set.
2155         (type_byte_order): new function.
2156         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2157         (struct main_type) <flag_endianity_not_default>:
2158         New field.
2159         (type_byte_order): New function.
2160         * infcmd.c (default_print_one_register_info):
2161         Use type_byte_order instead of gdbarch_byte_order.
2162         * p-lang.c (pascal_printstr):
2163         Use type_byte_order instead of gdbarch_byte_order.
2164         * p-valprint.c (pascal_val_print):
2165         Use type_byte_order instead of gdbarch_byte_order.
2166         * printcmd.c (print_scalar_formatted):
2167         Use type_byte_order instead of gdbarch_byte_order.
2168         * solib-darwin.c (darwin_current_sos):
2169         Use type_byte_order instead of gdbarch_byte_order.
2170         * solib-svr4.c (solib_svr4_r_ldsomap):
2171         Use type_byte_order instead of gdbarch_byte_order.
2172         * stap-probe.c (stap_modify_semaphore):
2173         Use type_byte_order instead of gdbarch_byte_order.
2174         * target-float.c (target_float_same_format_p):
2175         Use type_byte_order instead of gdbarch_byte_order.
2176         * valarith.c (scalar_binop):
2177         (value_bit_index):
2178         Use type_byte_order instead of gdbarch_byte_order.
2179         * valops.c (value_cast):
2180         Use type_byte_order instead of gdbarch_byte_order.
2181         * valprint.c (generic_emit_char):
2182         (generic_printstr):
2183         (val_print_string):
2184         Use type_byte_order instead of gdbarch_byte_order.
2185         * value.c (unpack_long):
2186         (unpack_bits_as_long):
2187         (unpack_value_bitfield):
2188         (modify_field):
2189         (pack_long):
2190         (pack_unsigned_long):
2191         Use type_byte_order instead of gdbarch_byte_order.
2192         * findvar.c (unsigned_pointer_to_address):
2193         (signed_pointer_to_address):
2194         (unsigned_address_to_pointer):
2195         (address_to_signed_pointer):
2196         (default_read_var_value):
2197         (default_value_from_register):
2198         Use type_byte_order instead of gdbarch_byte_order.
2199         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2200         Use type_byte_order instead of gdbarch_byte_order.
2201         * riscv-tdep.c (riscv_print_one_register_info):
2202         Use type_byte_order instead of gdbarch_byte_order.
2203
2204 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2205
2206         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2207         (current_ui_gdb_stdin_ptr): Likewise.
2208         (current_ui_gdb_stderr_ptr): Likewise.
2209         (current_ui_gdb_stdlog_ptr): Likewise.
2210         (current_ui_current_uiout_ptr): Likewise.
2211         (gen_ret_current_ui_field_ptr): Remove.
2212
2213 2019-11-21  Tom de Vries  <tdevries@suse.de>
2214
2215         PR gdb/24956
2216         * cli/cli-script.c (execute_control_command): Only switch to
2217         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2218
2219 2019-11-19  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2222         Now static.  Change type of "name".
2223         (tui_set_win_height_command): Don't copy "arg".
2224         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2225         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2226
2227 2019-11-19  Ali Tamur <tamur@google.com>
2228
2229         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2230         "if (attr != nullptr)".
2231         (dwarf2_find_base_address): Likewise.
2232         (dwarf2_build_include_psymtabs): Likewise.
2233         (read_cutu_die_from_dwo): Likewise.
2234         (read_func_scope): Likewise.
2235         (read_call_site_scope): Likewise.
2236         (dwarf2_get_pc_bounds): Likewise.
2237         (dwarf2_record_block_ranges): Likewise.
2238         (dwarf2_add_field): Likewise.
2239         (dwarf2_add_member_fn): Likewise.
2240         (read_structure_type): Likewise.
2241         (read_enumeration_type): Likewise.
2242         (read_array_type): Likewise.
2243         (read_array_order): Likewise.
2244         (read_set_type): Likewise.
2245         (read_common_block): Likewise.
2246         (read_tag_reference_type): Likewise.
2247         (read_tag_string_type): Likewise.
2248         (read_subroutine_type): Likewise.
2249         (read_base_type): Likewise.
2250         (read_subrange_type): Likewise.
2251         (new_symbol): Likewise.
2252         (prepare_one_comp_unit): Likewise.
2253
2254 2019-11-19  Tom Tromey  <tromey@adacore.com>
2255
2256         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2257         result in error when DebugActiveProcess fails.
2258
2259 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2260             Pedro Alves  <palves@redhat.com>
2261
2262         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2263         * target.c (target_stack::push): Call 'unpush' if there's a
2264         target on top of the stack.
2265
2266 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2267
2268         * python/py-block.c (blpy_dealloc): Call tp_free.
2269         (blpy_block_syms_dealloc): Likewise.
2270         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2271         * python/py-inferior.c (infpy_dealloc): Likewise.
2272         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2273         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2274         * python/py-symbol.c (sympy_dealloc): Likewise.
2275         * python/py-symtab.c (stpy_dealloc): Likewise.
2276         * python/py-type.c (typy_iterator_dealloc): Likewise.
2277
2278 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2279
2280         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2281         constructor instead of using a class initializer.
2282
2283 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2286         * configure: Regenerate.
2287         * configure.ac: Don't source common.host.
2288         * gdbsupport/common.host: Remove.
2289         * gdbsupport/mingw-strerror.c: Remove.
2290         * gdbsupport/posix-strerror.c: Rename to...
2291         * gdbsupport/safe-strerror.c: ...this.
2292
2293 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2294
2295         * maint.c (scoped_command_stats::print_time): Use localtime_r
2296         instead of localtime (provided through gnulib if necessary).
2297         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2298         of ctime.
2299
2300 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2301
2302         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2303         avoid compile errors.
2304
2305 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2306
2307         * config.in: Regenerate.
2308         * configure: Regenerate.
2309         * gdbsupport/common.m4: No longer check for strerror_r.
2310         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2311         POSIX version of strerror_r, now that gnulib provides it if
2312         necessary.
2313
2314 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2315
2316         * README (`configure' options): Update.
2317
2318 2019-11-14  Tom Tromey  <tromey@adacore.com>
2319
2320         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2321         expected type for the RHS if the LHS is a convenience variable.
2322
2323 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2324
2325         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2326         Provide explicit default and copy constructor.
2327
2328 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2329
2330         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2331         only call Py_INCREF (newbp) in the bppy_pending_object case.
2332
2333 2019-11-13  Tom Tromey  <tromey@adacore.com>
2334
2335         PR build/25182:
2336         * psympriv.h (partial_symbol): Remove static assert.
2337         * symtab.h (general_symbol_info, symbol): Remove static assert.
2338
2339 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * gdbsupport/format.c (format_pieces::format_pieces): Support
2342         printf 'z' size modifier.
2343         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2344         * printcmd.c (ui_printf):  Handle size_t_arg.
2345         * ui-out.c (ui_out::vmessage): Likewise.
2346         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2347         function.
2348         (run_tests): Call test_format_int_sizes.
2349
2350 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2351
2352         * ada-exp.y (write_ambiguous_var): Update.
2353         * buildsym.c (add_symbol_to_list): Update.
2354         * dwarf2read.c (read_variable): Update.
2355         (new_symbol): Update.
2356         * jit.c (finalize_symtab): Update.
2357         * language.c (language_alloc_type_symbol): Update.
2358         * symtab.c (fixup_symbol_section): Update.
2359         (initialize_objfile_symbol_1): Move code to...
2360         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2361         (allocate_symbol): Update.
2362         (allocate_template_symbol): Update.
2363         (get_symbol_address): Update.
2364         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2365         of having as a field, and add a constructor.
2366         (SYMBOL_VALUE): Update.
2367         (SYMBOL_VALUE_ADDRESS): Update.
2368         (SET_SYMBOL_VALUE_ADDRESS): Update.
2369         (SYMBOL_VALUE_BYTES): Update.
2370         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2371         (SYMBOL_BLOCK_VALUE): Update.
2372         (SYMBOL_VALUE_CHAIN): Update.
2373         (SYMBOL_LANGUAGE): Update.
2374         (SYMBOL_SECTION): Update.
2375         (SYMBOL_OBJ_SECTION): Update.
2376         (SYMBOL_SET_LANGUAGE): Update.
2377         (SYMBOL_SET_LINKAGE_NAME): Update.
2378         (SYMBOL_SET_NAMES): Update.
2379         (SYMBOL_NATURAL_NAME): Update.
2380         (SYMBOL_LINKAGE_NAME): Update.
2381         (SYMBOL_DEMANGLED_NAME): Update.
2382         (SYMBOL_SEARCH_NAME): Update.
2383         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2384         (struct symbol): Update.
2385         (struct template_symbol): Update.
2386         (struct rust_vtable_symbol): Update.
2387         * xcoffread.c (SYMBOL_DUP): Update.
2388
2389 2019-11-12  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-layout.c (show_layout): Set current_layout.
2392         (show_source_disasm_command, show_data)
2393         (show_source_or_disasm_and_command): Don't set current_layout.
2394
2395 2019-11-12  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2398
2399 2019-11-12  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-win.c (resize_message): New global.
2402         (show_tui_resize_message): New function.
2403         (tui_async_resize_screen): Print message if requested.
2404         (_initialize_tui_win): Add tui-resize-message setting.
2405         * NEWS: Add entry for new commands.
2406
2407 2019-11-11  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2410         functions.
2411
2412 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2413
2414         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2415
2416 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2419         function.
2420         * python/python-internal.h (gdbpy_lookup_static_symbols):
2421         Declare new function.
2422         * python/python.c (python_GdbMethods): Add
2423         gdb.lookup_static_symbols method.
2424         * NEWS: Mention gdb.lookup_static_symbols.
2425
2426 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2429         static block of current object file first.  Also fix typo in
2430         header comment.
2431
2432 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * stack.c (set_last_displayed_sal): Delete.
2435         (last_displayed_sal_valid): Delete.
2436         (last_displayed_pspace): Delete.
2437         (last_displayed_addr): Delete.
2438         (last_displayed_symtab): Delete.
2439         (last_displayed_line): Delete.
2440         (class last_displayed_symtab_info_type): New.
2441         (last_displayed_symtab_info): New static global variable.
2442         (print_frame_info): Call methods on last_displayed_symtab_info.
2443         (clear_last_displayed_sal): Update header comment, and make use of
2444         last_displayed_symtab_info.
2445         (last_displayed_sal_is_valid): Likewise.
2446         (get_last_displayed_pspace): Likewise.
2447         (get_last_displayed_addr): Likewise.
2448         (get_last_displayed_symtab): Likewise.
2449         (get_last_displayed_line): Likewise.
2450         (get_last_displayed_sal): Likewise.
2451         * stack.h (clear_last_displayed_sal): Update header comment.
2452         (last_displayed_sal_is_valid): Likewise.
2453         (get_last_displayed_pspace): Likewise.
2454         (get_last_displayed_addr): Likewise.
2455         (get_last_displayed_symtab): Likewise.
2456         (get_last_displayed_line): Likewise.
2457         (get_last_displayed_sal): Likewise.
2458
2459 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * stack.c (frame_show_address): Convert return type to bool.
2462         * stack.h (frame_show_address): Likewise, and update header
2463         comment.
2464
2465 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2468         * unittests/vec-utils-selftests.c: New file.
2469         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2470
2471 2019-11-10  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2474         (tui_highlight_win): Likewise.
2475         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2476         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2477         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2478         Don't set can_highlight.
2479
2480 2019-11-10  Tom Tromey  <tom@tromey.com>
2481
2482         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2483         Remove unused declaration.
2484
2485 2019-11-08  Tom Tromey  <tromey@adacore.com>
2486
2487         * top.c (read_command_file): Update.
2488         (command_line_input): Make return type const.
2489         * python/py-gdb-readline.c: Update.
2490         * linespec.c (decode_line_2): Update.
2491         * defs.h (command_line_input): Make return type const.
2492         * cli/cli-script.c (read_next_line): Make return type const.
2493         * ada-lang.c (get_selections): Update.
2494
2495 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2496
2497         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2498         * mi/mi-main.c (output_cores): Likewise.
2499         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2500         (linux_xfer_osdata_modules): Likewise.
2501         * remote.c (register_remote_support_xml): Likewise.
2502         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2503         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2504
2505 2019-11-06  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-interp.c: Don't include readline.h.
2508         * tui/tui-hooks.c: Don't include readline.h.
2509         * symmisc.c: Include tilde.h, not readline.h.
2510         * symfile.c: Include tilde.h, not readline.h.
2511         * source.c: Include tilde.h, not readline.h.
2512         * solib.c: Include tilde.h, not readline.h.
2513         * psymtab.c: Include tilde.h, not readline.h.
2514         * exec.c: Include tilde.h, not readline.h.
2515         * corelow.c: Include tilde.h, not readline.h.
2516         * cli/cli-dump.c: Include tilde.h, not readline.h.
2517         * cli/cli-cmds.c: Don't include readline.h.
2518
2519 2019-11-05  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2522         (tui_disassemble): Set addr_size.
2523         (tui_disasm_window::set_contents): Use addr_size.
2524
2525 2019-11-05  Tom Tromey  <tom@tromey.com>
2526
2527         * rust-lang.c (rust_language_defn): Update.
2528         * python/py-value.c (valpy_string): Call c_get_string.
2529         * p-lang.c (pascal_language_defn): Update.
2530         * opencl-lang.c (opencl_language_defn): Update.
2531         * objc-lang.c (objc_language_defn): Update.
2532         * m2-lang.c (m2_language_defn): Update.
2533         * language.c (unknown_language_defn, auto_language_defn): Update.
2534         (default_get_string): Remove.
2535         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2536         * go-lang.c (go_language_defn): Update.
2537         * f-lang.c (f_language_defn): Update.
2538         * d-lang.c (d_language_defn): Update.
2539         * c-lang.c (c_language_defn, cplus_language_defn)
2540         (asm_language_defn, minimal_language_defn): Update.
2541         * ada-lang.c (ada_language_defn): Update.
2542         * language.h (struct language_defn) <la_get_string>: Remove.
2543         (LA_GET_STRING): Remove.
2544         (default_get_string): Don't declare.
2545
2546 2019-11-05  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-source.h (struct tui_source_window): Inline
2549         constructor.  Remove destructor.
2550         <style_changed, m_observable>: Move to superclass.
2551         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2552         (struct tui_source_window_base): Move private members to end.
2553         <style_changed, m_observable>: Move from tui_source_window.
2554         * tui/tui-winsource.c (tui_copy_source_line): Move from
2555         tui-source.c.  Rename from copy_source_line.  Add special handling
2556         for negative line number.
2557         (tui_source_window_base::style_changed): Move from
2558         tui_source_window.
2559         (tui_source_window_base): Register observer.
2560         (~tui_source_window_base): New.
2561         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2562         rename.
2563         (tui_source_window::set_contents): Use tui_copy_source_line.
2564         (tui_source_window::tui_source_window): Move to tui-source.h.
2565         (tui_source_window::~tui_source_window): Remove.
2566         (tui_source_window::style_changed): Move to superclass.
2567         * tui/tui-disasm.c (tui_disassemble): Create string file with
2568         styling, when possible.  Add "addr_size" parameter.
2569         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2570         Don't compute maximum size.
2571         (len_without_escapes): New function
2572
2573 2019-11-05  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2576         std::string.
2577         * tui/tui-winsource.c (tui_show_source_line): Update.
2578         * tui/tui-source.c (tui_source_window::set_contents): Update.
2579         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2580
2581 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2582
2583         * symtab.h (gdb_static_assert): Put && operator at the beginning
2584         of the line instead of the end.
2585
2586 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2587
2588         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2589         and sizeof (symbol).
2590         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2591
2592 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2593
2594         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2595         * configure.host: Mark *-*-solaris2.10* obsolete.
2596         * configure.tgt: Mark Solaris < 11 obsolete.
2597         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2598         Update target triplet.
2599
2600 2019-11-01  Tom Tromey  <tromey@adacore.com>
2601
2602         * utils.c (print_sys_errmsg): Simplify.
2603
2604 2019-11-01  Tom Tromey  <tromey@adacore.com>
2605
2606         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2607
2608 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2609
2610         * configure: Regenerate.
2611         * configure.ac: Remove check for strerror_r.
2612         * gdbsupport/common.m4: Check for strerror_r.
2613
2614 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2615
2616         PR gdb/25124
2617
2618         * arm-tdep.c (arm_per_objfile): Rename to ...
2619         (arm_per_bfd): ... this.
2620         (arm_objfile_data_key): Rename to ...
2621         (arm_bfd_data_key): ... this.
2622         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2623         data.
2624         (arm_record_special_symbol): Likewise.
2625
2626 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2629         end.
2630         * c-typeprint.c (c_print_typedef): Likewise.
2631         * f-typeprint.c (f_print_typedef): Likewise.
2632         * m2-typeprint.c (m2_print_typedef): Likewise.
2633         * p-typeprint.c (pascal_print_typedef): Likewise.
2634         * rust-lang.c (rust_print_typedef): Likewise.
2635         * symtab.c (print_symbol_info): Print a newline after calling
2636         typedef_print.
2637
2638 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * symtab.c (info_module_cmdlist): New variable.
2641         (info_module_command): New function.
2642         (search_module_symbols): New function.
2643         (info_module_subcommand): New function.
2644         (struct info_modules_var_func_options): New struct.
2645         (info_modules_var_func_options_defs): New variable.
2646         (make_info_modules_var_func_options_def_group): New function.
2647         (info_module_functions_command): New function.
2648         (info_module_variables_command): New function.
2649         (info_module_var_func_command_completer): New function.
2650         (_initialize_symtab): Register new 'info module functions' and
2651         'info module variables' commands.
2652         * symtab.h (typedef symbol_search_in_module): New typedef.
2653         (search_module_symbols): Declare new function.
2654         * NEWS: Mention new commands.
2655
2656 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2659         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2660         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2661         MODULES_DOMAIN.
2662         (scan_partial_symbols): Only create partial module symbols for non
2663         declarations.
2664         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2665         and MODULES_DOMAIN.
2666         * symtab.c (search_domain_name): Likewise.
2667         (search_symbols): Likewise.
2668         (print_symbol_info): Likewise.
2669         (symtab_symbol_info): Likewise.
2670         (info_modules_command): New function.
2671         (_initialize_symtab): Register 'info modules' command.
2672         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2673         * NEWS: Mention new 'info modules' command.
2674
2675 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2676
2677         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2678         and $_gdb_maint_setting_str.
2679
2680 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2681
2682         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2683         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2684         (str_value_from_setting, gdb_setting_str_internal_fn)
2685         (gdb_maint_setting_str_internal_fn): New functions.
2686         (_initialize_cli_cmds): Define the new convenience functions.
2687         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2688         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2689
2690 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2691
2692         * agent.c (set_can_use_agent): When the setting is turned on,
2693         look up agent symbols if we don't have them yet.
2694         (agent_new_objfile): Don't look up agent symbols when the agent
2695         setting is off.
2696
2697 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2698
2699         * config.in: Regenerate.
2700
2701 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2702
2703         * configure: Regenerate.
2704         * configure.ac: Check for strerror_r.
2705         * gdbsupport/common-utils.h (safe_strerror): Change return value
2706         to const char * and document that this function is now threadsafe.
2707         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2708         thread_local and call strerror_r, if available.
2709         * utils.c (perror_string): Update.
2710         (print_sys_errmsg): Update.
2711
2712 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2713
2714         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2715         objfile_key.
2716         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2717         objfile to fetch per-bfd data.
2718         (arm_find_exidx_entry): Likewise.
2719
2720 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2721
2722         * gdbsupport/agent.c (debug_agent): Change type to bool.
2723         (use_agent): Likewise.
2724         (all_agent_symbols_look_up): Likewise.
2725         (agent_loaded_p): Change return value to bool.
2726         (agent_look_up_symbols): Update.
2727         (agent_capability_check): Change return value to bool.
2728         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2729         (debug_agent): Change type to bool.
2730         (use_agent): Likewise.
2731         (agent_capability_check): Change return value to bool.
2732
2733 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2734
2735         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2736         (build_minimal_symbol_hash_tables): Code to clear the table moved
2737         to clear_minimal_symbol_hash_tables.
2738         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2739         when needed.
2740
2741 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2742
2743         * infcmd.c: Remove includes.
2744         * infrun.c: Remove includes.
2745
2746 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2747
2748         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2749         (grow_vect): Remove declaration.
2750         (ada_type_of_array): Remove declaration.
2751         (ada_update_initial_language): Remove declaration.
2752         (ada_fold_name): Remove declaration.
2753         (ada_fill_in_ada_prototype): Remove declaration.
2754         (user_select_syms): Remove declaration.
2755         (get_selections): Remove declaration.
2756         (ada_tag_type): Remove declaration.
2757         (ada_value_tag): Remove declaration.
2758         (ada_is_others_clause): Remove declaration.
2759         (ada_in_variant): Remove declaration.
2760         (ada_value_struct_elt): Remove declaration.
2761         (ada_attribute_name): Remove declaration.
2762         (ada_system_address_type): Remove declaration.
2763         * ada-lang.c (ada_watch_location_expression): Make static.
2764         (GROW_VECT): Move here from ada-lang.h.
2765         (grow_vect): Make static.
2766         (ada_update_initial_language): Make static.
2767         (ada_fold_name): Make static.
2768         (ada_type_of_array): Make static.
2769         (encoded_ordered_before): Move up.
2770         (sort_choices): Move up.
2771         (print_signatures): Move up.
2772         (ada_print_symbol_signature): Move up.
2773         (get_selections): Move up and make static.
2774         (user_select_syms): Move up and make static.
2775         (ada_value_struct_elt): Move up and make static.
2776         (ada_tag_type): Make static.
2777         (ada_value_tag): Make static.
2778         (ada_is_others_clause): Make static.
2779         (ada_in_variant): Make static.
2780         (ada_attribute_name): Make static.
2781
2782 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2783
2784         * ada-lang.c: Remove includes.
2785         * ada-typeprint.c: Remove includes.
2786         * ada-valprint.c: Remove includes.
2787
2788 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2789
2790         * addrmap.c: Add static assertions of type size, moved from
2791         _initialize_addrmap.
2792         (_initialize_addrmap): Remove.
2793
2794 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2795
2796         * coffread.c (record_minimal_symbol): Update.
2797         (process_coff_symbol): Update.
2798         * dbxread.c (read_dbx_symtab): Update.
2799         * dwarf2read.c (add_partial_symbol): Update.
2800         (fixup_go_packaging): Update.
2801         (load_partial_dies): Update.
2802         (new_symbol): Update.
2803         * elfread.c (record_minimal_symbol): Change signature to use
2804         gdb::string_view instead of name+len.
2805         (elf_symtab_read): Update.
2806         (elf_rel_plt_read): Update.
2807         * mdebugread.c (parse_partial_symbols): Update.
2808         (handle_psymbol_enumerators): Update.
2809         (new_symbol): Update.
2810         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2811         to use gdb::string_view instead of name+len.
2812         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2813         * psympriv.h (add_psymbol_to_list): Likewise.
2814         * psymtab.c (add_psymbol_to_bcache): Likewise.
2815         (add_psymbol_to_list): Likewise.
2816         * stabsread.c (define_symbol): Update.
2817         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2818         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2819         (symbol_set_names): Likewise.
2820         * xcoffread.c (scan_xcoff_symtab): Update.
2821
2822 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2823
2824         * symtab.h (symbol_set_names): Document that copy_name must be
2825         set to true for non-nullterminated strings.
2826         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2827         linkage_name if the entry was not found and we need to demangle.
2828
2829 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2830
2831         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2832         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2833         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2834         * gdbsupport/gdb_binary_search.h: New file.
2835
2836 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2837
2838         * NEWS: Mention new --with-system-gdbinit-dir option.
2839         * config.in: Regenerate.
2840         * configure: Regenerate.
2841         * configure.ac: Add new option --with-system-gdbinit-dir.
2842         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2843         for a ".gdb" suffix.
2844         * main.c (get_init_files): Change system_gdbinit argument to
2845         a vector and return the files in SYSTEM_GDBINIT_DIR in
2846         addition to SYSTEM_GDBINIT.
2847         (captured_main_1): Update.
2848         (print_gdb_help): Update.
2849         * top.c (print_gdb_configuration): Also print the value of
2850         SYSTEM_GDBINIT_DIR.
2851
2852 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2853
2854         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2855         that takes gdb::string_view arguments.
2856
2857 2019-10-26  Tom de Vries  <tdevries@suse.de>
2858
2859         * aarch64-linux-tdep.c: Fix typos in comments.
2860         * aarch64-tdep.c: Same.
2861         * ada-lang.c: Same.
2862         * amd64-nat.c: Same.
2863         * arc-tdep.c: Same.
2864         * arch/aarch64-insn.c: Same.
2865         * block.c: Same.
2866         * breakpoint.h: Same.
2867         * btrace.h: Same.
2868         * c-varobj.c: Same.
2869         * cli/cli-decode.c: Same.
2870         * cli/cli-script.c: Same.
2871         * cli/cli-utils.h: Same.
2872         * coff-pe-read.c: Same.
2873         * coffread.c: Same.
2874         * compile/compile-cplus-symbols.c: Same.
2875         * compile/compile-object-run.c: Same.
2876         * completer.c: Same.
2877         * corelow.c: Same.
2878         * cp-support.c: Same.
2879         * demangle.c: Same.
2880         * dwarf-index-write.c: Same.
2881         * dwarf2-frame.c: Same.
2882         * dwarf2-frame.h: Same.
2883         * eval.c: Same.
2884         * frame-base.h: Same.
2885         * frame.h: Same.
2886         * gdbcmd.h: Same.
2887         * gdbtypes.h: Same.
2888         * gnu-nat.c: Same.
2889         * guile/scm-objfile.c: Same.
2890         * i386-tdep.c: Same.
2891         * i386-tdep.h: Same.
2892         * infcall.c: Same.
2893         * infcall.h: Same.
2894         * linux-nat.c: Same.
2895         * m68k-tdep.c: Same.
2896         * macroexp.c: Same.
2897         * memattr.c: Same.
2898         * mi/mi-cmd-disas.c: Same.
2899         * mi/mi-getopt.h: Same.
2900         * mi/mi-main.c: Same.
2901         * minsyms.c: Same.
2902         * nat/aarch64-sve-linux-sigcontext.h: Same.
2903         * objfiles.h: Same.
2904         * ppc-linux-nat.c: Same.
2905         * ppc-linux-tdep.c: Same.
2906         * ppc-tdep.h: Same.
2907         * progspace.h: Same.
2908         * prologue-value.h: Same.
2909         * python/py-evtregistry.c: Same.
2910         * python/py-instruction.h: Same.
2911         * record-btrace.c: Same.
2912         * record-full.c: Same.
2913         * remote.c: Same.
2914         * rs6000-tdep.c: Same.
2915         * ser-tcp.c: Same.
2916         * sol-thread.c: Same.
2917         * sparc-sol2-tdep.c: Same.
2918         * sparc64-tdep.c: Same.
2919         * stabsread.c: Same.
2920         * symfile.c: Same.
2921         * symtab.h: Same.
2922         * target.c: Same.
2923         * tracepoint.c: Same.
2924         * tui/tui-data.h: Same.
2925         * tui/tui-io.c: Same.
2926         * tui/tui-win.c: Same.
2927         * tui/tui.c: Same.
2928         * unittests/rsp-low-selftests.c: Same.
2929         * user-regs.h: Same.
2930         * utils.c: Same.
2931         * utils.h: Same.
2932         * valarith.c: Same.
2933         * valops.c: Same.
2934         * valprint.c: Same.
2935         * valprint.h: Same.
2936         * value.c: Same.
2937         * value.h: Same.
2938         * varobj.c: Same.
2939         * x86-nat.h: Same.
2940         * xtensa-tdep.c: Same.
2941
2942 2019-10-25  Ali Tamur <tamur@google.com>
2943
2944         * charset.c (find_charset_names): Reflect API change.
2945
2946 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2947
2948         * symtab.c (struct demangled_name_entry): Change demangled name
2949         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2950         part of the struct anymore.
2951         (symbol_set_names): No longer obstack allocate + copy the demangled
2952         name, just store the allocated name from bfd.
2953
2954 2019-10-25  Tom Tromey  <tromey@adacore.com>
2955
2956         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2957         (bsearch_cie_cmp, add_cie): Remove.
2958         (find_cie): Reimplement.
2959         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2960         (dwarf2_build_frame_info): Update.
2961
2962 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2963
2964         PR gdb/25126
2965         * symfile.c (reread_symbols): Call forget_cached_source_info to
2966         clear the stale source cache.
2967
2968 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2969
2970         * configure: Regenerate.
2971         * configure.ac: Remove code that sets python_has_threads.
2972
2973 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2974
2975         * config.in: Regenerate.
2976         * configure: Regenerate.
2977         * configure.ac: Remove the code that uses sed to get the python
2978         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2979
2980 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2983         error paths.
2984
2985 2019-10-23  Tom Tromey  <tom@tromey.com>
2986
2987         * arc-tdep.c: Remove ".." from include.
2988         * frv-tdep.c: Remove ".." from include.
2989         * lm32-tdep.c: Remove ".." from include.
2990         * microblaze-tdep.c: Remove ".." from include.
2991         * or1k-tdep.h: Remove ".." from include.
2992         * s12z-tdep.c: Remove ".." from include.
2993         * Makefile.in (OPCODES_CFLAGS): Add comment.
2994         (TOP_CFLAGS): New variable.
2995         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2996
2997 2019-10-23  Tom Tromey  <tom@tromey.com>
2998
2999         * Makefile.in (READLINE_DIR): Update.
3000
3001 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3002
3003         * infcall.c (call_function_by_hand_dummy): Fix the function
3004         comment.  And extract out a code section into...
3005         (reserve_stack_space): ...this new function.
3006
3007 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3008
3009         * infcall.c (value_arg_coerce): Remove an unused parameter.
3010         (call_function_by_hand_dummy): Update the call to
3011         'value_arg_coerce'.
3012
3013 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3014
3015         * infcall.c (call_function_by_hand_dummy): Refactor.
3016
3017 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3018
3019         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3020
3021 2019-10-23  Tom Tromey  <tom@tromey.com>
3022
3023         * configure: Rebuild.
3024         * configure.ac: Don't check for sigprocmask.
3025         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3026
3027 2019-10-23  Tom Tromey  <tom@tromey.com>
3028
3029         * configure: Rebuild.
3030         * acinclude.m4: Use m4_include, not sinclude.
3031
3032 2019-10-23  Tom de Vries  <tdevries@suse.de>
3033
3034         PR breakpoints/24687
3035         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3036
3037 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3038
3039         * symtab.c (struct demangled_name_entry) <language>: Change from
3040         bitfield to regular variable.
3041
3042 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3043
3044         * symtab.c (struct demangled_name_entry): Add a constructor.
3045         (free_demangled_name_entry): New function to call the destructor
3046         for demangled_name_entry.
3047         (create_demangled_names_hash): Pass free_demangled_name_entry to
3048         htab_create_alloc.
3049         (symbol_set_names): Call placement new for demangled_name_entry.
3050         * utils.c: No longer include xxhash.h here, now that fast_hash
3051         is inlined in the header.
3052         * utils.h: Instead, include it here.
3053
3054 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3055
3056         * Makefile.in: Link with libxxhash.
3057         * config.in: Regenerate.
3058         * configure: Regenerate.
3059         * configure.ac: Search for libxxhash.
3060         * utils.c (fast_hash): Use xxhash if present.
3061
3062 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3063
3064         * utils.h (fast_hash): New function.
3065         * symtab.c (hash_demangled_name_entry): Call new function
3066         fast_hash.
3067
3068 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3069
3070         * symtab.c (struct demangled_name_entry): Change type of mangled
3071         to gdb::string_view. Also adds a constructor that takes the
3072         mangled name.
3073         (hash_demangled_name_entry): Update.
3074         (eq_demangled_name_entry): Update.
3075         (free_demangled_name_entry): New function to call the destructor
3076         now that this is not a POD anymore.
3077         (create_demangled_names_hash): Pass free_demangled_name_entry to
3078         htab_create_alloc.
3079         (symbol_set_names): Update.
3080
3081 2019-10-21  Ali Tamur  <tamu@google.com>
3082
3083         * dwarf2read.c (dir_index): Change type.
3084         (file_name_index): Likewise.
3085         (line_header::include_dir_at): Change comment and implementation on
3086         whether it is DWARF 5.
3087         (line_header::is_valid_file_index): New function.
3088         (line_header::file_name_at): Change comment and implementation on
3089         whether it is DWARF 5.
3090         (line_header::file_names): Change to private field renamed as
3091         m_file_names and introduce a new accessor method.
3092         (line_header::file_names_size): New method.
3093         (line_header::include_dirs): Change to private field and rename as
3094         m_include_dirs.
3095         (dw2_get_file_names_reader): Define local var at a smaller scope and
3096         reflect API change.
3097         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3098         (process_structure_scope): Likewise.
3099         (line_header::add_include_dir): Change message and reflect renaming.
3100         (line_header::add_file_name): Likewise.
3101         (read_formatted_entries): Handle DW_FORM_data16.
3102         (dwarf_decode_line_header): Fix line header length calculation.
3103         (psymtab_include_file_name): Change comment and API.
3104         (lnp_state_machine::m_file): Update comment and reflect type change.
3105         (lnp_state_machine::record_line): Reflect type change.
3106         (dwarf_decode_lines): Reflect API change.
3107         (file_file_name): Likewise.
3108         (file_full_name): Likewise.
3109
3110 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3113
3114 2019-10-21  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3117
3118 2019-10-21  Tom Tromey  <tom@tromey.com>
3119
3120         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3121         NM_H.   Use AC_CONFIG_LINKS.
3122         * configure: Rebuild.
3123         * Makefile.in (NM_H): New variable.
3124         (generated_files): Add NM_H.  Remove gcore.
3125         (nm.h, stamp-nmh): New targets.
3126
3127 2019-10-20  Tom Tromey  <tom@tromey.com>
3128
3129         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3130         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3131         obsolete comment.
3132         (put_objfile_before): Now static.
3133
3134 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3135
3136         * gdbsupport/common-utils.h (startswith): Change return type to
3137         bool.
3138
3139 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3140
3141         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3142         * breakpoint.c (bp_locations_compare): Rename to...
3143         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3144         (update_global_location_list): Use std::sort instead of qsort.
3145         * buildsym.c (compare_line_numbers): Rename to...
3146         (lte_is_less_than): ...this, and change to std::sort semantics.
3147         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3148         instead of qsort.
3149         * disasm.c (compare_lines): Rename to...
3150         (line_is_less_than): ...this, and change to std::sort semantics.
3151         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3152         of qsort.
3153         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3154         (fde_is_less_than): ...this, and change to std::sort semantics.
3155         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3156         * mdebugread.c (compare_blocks):
3157         (block_is_less_than): ...this, and change to std::sort semantics.
3158         (sort_blocks): Call std::sort instead of qsort.
3159         * objfiles.c (qsort_cmp): Rename to...
3160         (sort_cmp): ...this, and change to std::sort semantics.
3161         (update_section_map): Call std::sort instead of qsort.
3162         * remote.c (compare_pnums): Remove.
3163         (map_regcache_remote_table): Call std::sort instead of qsort.
3164         * utils.c (compare_positive_ints): Remove.
3165         * utils.h (compare_positive_ints): Remove.
3166         * xcoffread.c (compare_lte): Remove.
3167         (arrange_linetable): Call std::sort instead of qsort.
3168
3169 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3170
3171         * symfile.c (init_entry_point_info): Fix typo.
3172         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3173
3174 2019-10-18  Tom de Vries  <tdevries@suse.de>
3175
3176         * aarch64-tdep.c: Fix typos in comments.
3177         * ada-lang.c: Same.
3178         * ada-tasks.c: Same.
3179         * alpha-tdep.c: Same.
3180         * alpha-tdep.h: Same.
3181         * amd64-nat.c: Same.
3182         * amd64-windows-tdep.c: Same.
3183         * arc-tdep.c: Same.
3184         * arc-tdep.h: Same.
3185         * arch-utils.c: Same.
3186         * arm-nbsd-tdep.c: Same.
3187         * arm-tdep.c: Same.
3188         * ax-gdb.c: Same.
3189         * blockframe.c: Same.
3190         * btrace.c: Same.
3191         * c-varobj.c: Same.
3192         * coff-pe-read.c: Same.
3193         * coffread.c: Same.
3194         * cris-tdep.c: Same.
3195         * darwin-nat.c: Same.
3196         * dbxread.c: Same.
3197         * dcache.c: Same.
3198         * disasm.c: Same.
3199         * dtrace-probe.c: Same.
3200         * dwarf-index-write.c: Same.
3201         * dwarf2-frame-tailcall.c: Same.
3202         * dwarf2-frame.c: Same.
3203         * dwarf2read.c: Same.
3204         * eval.c: Same.
3205         * exceptions.c: Same.
3206         * fbsd-tdep.c: Same.
3207         * findvar.c: Same.
3208         * frame.c: Same.
3209         * frv-tdep.c: Same.
3210         * gnu-v3-abi.c: Same.
3211         * go32-nat.c: Same.
3212         * h8300-tdep.c: Same.
3213         * hppa-tdep.c: Same.
3214         * i386-linux-tdep.c: Same.
3215         * i386-tdep.c: Same.
3216         * ia64-libunwind-tdep.c: Same.
3217         * ia64-tdep.c: Same.
3218         * infcmd.c: Same.
3219         * infrun.c: Same.
3220         * linespec.c: Same.
3221         * linux-nat.c: Same.
3222         * linux-thread-db.c: Same.
3223         * machoread.c: Same.
3224         * mdebugread.c: Same.
3225         * mep-tdep.c: Same.
3226         * mn10300-tdep.c: Same.
3227         * namespace.c: Same.
3228         * objfiles.c: Same.
3229         * opencl-lang.c: Same.
3230         * or1k-tdep.c: Same.
3231         * osabi.c: Same.
3232         * ppc-linux-nat.c: Same.
3233         * ppc-linux-tdep.c: Same.
3234         * ppc-sysv-tdep.c: Same.
3235         * printcmd.c: Same.
3236         * procfs.c: Same.
3237         * record-btrace.c: Same.
3238         * record-full.c: Same.
3239         * remote-fileio.c: Same.
3240         * remote.c: Same.
3241         * rs6000-tdep.c: Same.
3242         * s12z-tdep.c: Same.
3243         * score-tdep.c: Same.
3244         * ser-base.c: Same.
3245         * ser-go32.c: Same.
3246         * skip.c: Same.
3247         * sol-thread.c: Same.
3248         * solib-svr4.c: Same.
3249         * solib.c: Same.
3250         * source.c: Same.
3251         * sparc-nat.c: Same.
3252         * sparc-sol2-tdep.c: Same.
3253         * sparc-tdep.c: Same.
3254         * sparc64-tdep.c: Same.
3255         * stabsread.c: Same.
3256         * stack.c: Same.
3257         * symfile.c: Same.
3258         * symtab.c: Same.
3259         * target-descriptions.c: Same.
3260         * target-float.c: Same.
3261         * thread.c: Same.
3262         * utils.c: Same.
3263         * valops.c: Same.
3264         * valprint.c: Same.
3265         * value.c: Same.
3266         * varobj.c: Same.
3267         * windows-nat.c: Same.
3268         * xcoffread.c: Same.
3269         * xstormy16-tdep.c: Same.
3270         * xtensa-tdep.c: Same.
3271
3272 2019-10-17  Tom Tromey  <tromey@adacore.com>
3273
3274         * configure: Rebuild.
3275         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3276         in AC_CONFIG_FILES invocation.
3277         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3278         new-style config.status invocation.
3279
3280 2019-10-17  Tom de Vries  <tdevries@suse.de>
3281
3282         * arm-nbsd-nat.c: Fix typos in comments.
3283         * arm-tdep.c: Same.
3284         * darwin-nat-info.c: Same.
3285         * dwarf2read.c: Same.
3286         * elfread.c: Same.
3287         * event-top.c: Same.
3288         * findvar.c: Same.
3289         * gdbtypes.c: Same.
3290         * hppa-tdep.c: Same.
3291         * i386-tdep.c: Same.
3292         * jit.c: Same.
3293         * main.c: Same.
3294         * mdebugread.c: Same.
3295         * moxie-tdep.c: Same.
3296         * nto-procfs.c: Same.
3297         * osabi.c: Same.
3298         * ppc-linux-tdep.c: Same.
3299         * remote.c: Same.
3300         * riscv-tdep.c: Same.
3301         * s390-tdep.c: Same.
3302         * sh-tdep.c: Same.
3303         * sparc-linux-tdep.c: Same.
3304         * sparc-nat.c: Same.
3305         * stack.c: Same.
3306         * target-descriptions.c: Same.
3307         * top.c: Same.
3308         * varobj.c: Same.
3309
3310 2019-10-16  Tom Tromey  <tom@tromey.com>
3311
3312         * objfiles.h (struct objfile) <original_name>: Now const.
3313
3314 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3315
3316         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3317         pass on to sigsetjmp's second argument.
3318         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3319
3320 2019-10-16  Keith Seitz  <keiths@redhat.com>
3321
3322         PR gdb/23567
3323         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3324         sections whose size is greater than the file size.
3325
3326 2019-10-16  Jim Wilson  <jimw@sifive.com>
3327
3328         * riscv-tdep.c (riscv_gcc_target_options): New.
3329         (riscv_gnu_triplet_regexp): New.
3330         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3331         set_gdbarch_gnu_triplet_regexp.
3332
3333 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3334
3335         * Makefile.in: Add xml-builtin.h.
3336         * features/feature_to_c.sh: Add an include for xml-builtin.h
3337         to ensure that the compiler checks that the types match.
3338         * xml-builtin.h: New file.
3339         * xml-support.c (fetch_xml_builtin): Add missing const.
3340         * xml-support.h: Remove declaration of xml_builtins.
3341
3342 2019-10-16  Tom de Vries  <tdevries@suse.de>
3343
3344         PR tdep/25096
3345         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3346         (amd64_classify_aggregate): ... here.
3347         (amd64_classify_aggregate_field): Handled fiels of nested structs
3348         recursively.
3349
3350 2019-10-16  Tom de Vries  <tdevries@suse.de>
3351
3352         PR tdep/24104
3353         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3354         that handles 'theclass'.
3355
3356 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * linespec.c (decode_digits_ordinary): Update comment.
3359         * make-target-delegates: No longer need to handle VEC case.
3360         * memrange.c (normalize_mem_ranges): Update comment.
3361         * namespace.c (add_using_directive): Update comment.
3362         * objc-lang.c (uniquify_strings): Update comment.
3363         * ppc-linux-nat.c (struct thread_points): Update comment.
3364         * probe.h (find_probes_in_objfile): Update comment.
3365         * target.h (enum flash_preserve_mode): Update comment.
3366         * varobj.c (varobj_restrict_range): Update comment.
3367         * varobj.h (varobj_list_children): Update comment.
3368
3369 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * Makefile.in: Remove references to vec.h and vec.c.
3372         * aarch64-tdep.c: No longer include vec.h.
3373         * ada-lang.c: Likewise.
3374         * ada-lang.h: Likewise.
3375         * arm-tdep.c: Likewise.
3376         * ax.h: Likewise.
3377         * breakpoint.h: Likewise.
3378         * charset.c: Likewise.
3379         * cp-support.h: Likewise.
3380         * dtrace-probe.c: Likewise.
3381         * dwarf2read.c: Likewise.
3382         * extension.h: Likewise.
3383         * gdb_bfd.c: Likewise.
3384         * gdbsupport/gdb_vecs.h: Likewise.
3385         * gdbsupport/vec.c: Remove.
3386         * gdbsupport/vec.h: Remove.
3387         * gdbthread.h: Likewise.
3388         * guile/scm-type.c: Likewise.
3389         * inline-frame.c: Likewise.
3390         * machoread.c: Likewise.
3391         * memattr.c: Likewise.
3392         * memrange.h: Likewise.
3393         * namespace.h: Likewise.
3394         * nat/linux-btrace.h: Likewise.
3395         * osdata.c: Likewise.
3396         * parser-defs.h: Likewise.
3397         * progspace.h: Likewise.
3398         * python/py-type.c: Likewise.
3399         * record-btrace.c: Likewise.
3400         * rust-exp.y: Likewise.
3401         * solib-target.c: Likewise.
3402         * stap-probe.c: Likewise.
3403         * target-descriptions.c: Likewise.
3404         * target-memory.c: Likewise.
3405         * target.h: Likewise.
3406         * varobj.c: Likewise.
3407         * varobj.h: Likewise.
3408         * xml-support.h: Likewise.
3409
3410 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3413         Update for new std::vector based implementation.
3414         (process_psymtab_comp_unit_reader): Likewise.
3415         (scan_partial_symbols): Likewise.
3416         (recursively_compute_inclusions): Likewise.
3417         (compute_compunit_symtab_includes): Likewise.
3418         (process_imported_unit_die): Likewise.
3419         (queue_and_load_dwo_tu): Likewise.
3420         (follow_die_sig_1): Likewise.
3421         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3422         (typedef dwarf2_per_cu_ptr): Remove.
3423         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3424         function.
3425         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3426         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3427         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3428         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3429         std::vector.
3430
3431 2019-10-15  Tom Tromey  <tromey@adacore.com>
3432
3433         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3434         TID.
3435
3436 2019-10-15  Tom Tromey  <tromey@adacore.com>
3437
3438         * windows-nat.c (windows_nat_target::fetch_registers)
3439         (windows_nat_target::store_registers): Rename "pid" to "tid".
3440
3441 2019-10-15  Tom Tromey  <tromey@adacore.com>
3442
3443         * gdbarch.h, gdbarch.c: Rebuild.
3444         * gdbarch.sh (gcc_target_options): Change return type to
3445         std::string.
3446         * compile/compile.c (get_args): Update.
3447         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3448         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3449         std::string.
3450         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3451         std::string.
3452         * arch-utils.c (default_gcc_target_options): Return std::string.
3453         * arch-utils.h (default_gcc_target_options): Return std::string.
3454         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3455
3456 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3457
3458         * breakpoint.c (breakpoint_chain): Make static.
3459         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3460         of accessing breakpoint_chain.
3461
3462 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3463
3464         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3465         to a gdb::function_view and return value to bool.
3466         * breakpoint.h (iterate_over_breakpoints): Likewise.
3467         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3468         (pop_dummy_frame): Update.
3469         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3470         (gdbscm_breakpoints): Update.
3471         * python/py-breakpoint.c (build_bp_list): Update.
3472         (gdbpy_breakpoints): Update.
3473         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3474         Update.
3475         (bpfinishpy_handle_stop): Update.
3476         (bpfinishpy_handle_exit): Update.
3477         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3478         (svr4_update_solib_event_breakpoints): Update.
3479
3480 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3481
3482         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3483         when unwrapping single-field structs.
3484
3485 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3486
3487         * dwarf2read.c: Remove includes.
3488
3489 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3490
3491         * ui-out.c (ui_out::call_do_message): Silence
3492         -Wformat-nonliteral warning.
3493
3494 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3495
3496         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3497         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3498         include: readline/tilde.h.
3499
3500 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3501
3502         * remote.c (remote_target::get_trace_status): Remove declaration of
3503         trace_regblock_size.
3504
3505 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3506
3507         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3508         (show_user): Remove declaration of cmdlist.
3509         * cli/cli-cmds.h (max_user_call_depth): Declare.
3510         * cli/cli-script.c (execute_user_command): Remove declaration
3511         of max_user_call_depth.
3512
3513 2019-10-11  Jim Wilson  <jimw@sifive.com>
3514
3515         * gdbsupport/print-utils.h (pulongest): Fix comment.
3516         (plongest): Likewise.
3517         (phex): Add missing comment, mention leading zeros.
3518         (phex_nz): Add mention of no leading zeros to comment.
3519
3520         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3521         plongest instead of unsigned long long cast.
3522
3523 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3524
3525         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3526         for external_editor_command and gdbtk_test.
3527
3528 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3529
3530         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3531         * varobj.c (varobjdebug): Move comment to...
3532         * varobj.h (varobjdebug): ...here, and declare.
3533
3534 2019-10-09  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3537         erase_data_content.
3538
3539 2019-10-09  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3542         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3543         * tui/tui-command.c (tui_cmd_window::resize)
3544         (tui_refresh_cmd_win): Update.
3545         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3546         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3547         * tui/tui-data.c (~tui_gen_win_info): Remove.
3548         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3549         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3550         (tui_redisplay_readline, tui_mld_flush)
3551         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3552         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3553         (tui_data_window::erase_data_content)
3554         (tui_data_item_window::rerender)
3555         (tui_data_item_window::refresh_window): Update.
3556         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3557         (box_win, tui_gen_win_info::make_window)
3558         (tui_gen_win_info::make_visible): Update.
3559         (tui_delete_win): Remove.
3560         * tui/tui-winsource.c
3561         (tui_source_window_base::do_erase_source_content): Update.
3562         (tui_show_source_line, tui_source_window_base::update_tab_width)
3563         (tui_source_window_base::update_exec_info): Update.
3564         * tui/tui-data.h (struct curses_deleter): New.
3565         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3566         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3567
3568 2019-10-09  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3571
3572 2019-10-09  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3575         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3576
3577 2019-10-09  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3580         window height directly.
3581         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3582         declare.
3583         * tui/tui-layout.c (tui_default_win_height): Remove.
3584         (tui_default_win_viewport_height): Remove.
3585
3586 2019-10-09  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui.h: Remove comments.
3589
3590 2019-10-09  Tom de Vries  <tdevries@suse.de>
3591
3592         * python/lib/gdb/printer/bound_registers.py: Use
3593         '^builtin_type_bound128' as regexp argument for
3594         add_builtin_pretty_printer.
3595
3596 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3597
3598         * guile/guile.c (guile_extension_script_ops): Remove forward
3599         declaration and mark as static.
3600         (guile_script_ops): Likewise.
3601         (extension_language_guile): Move further down in the file so
3602         it can reference the definitions for guile_{extension_,}script_ops.
3603
3604 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3605
3606         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3607         except SORTL, DFLTCC, and KDSA.
3608
3609 2019-10-08  Tom Tromey  <tromey@adacore.com>
3610
3611         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3612         (struct safe_symbol_file_add_args): Remove.
3613
3614 2019-10-08  Tom Tromey  <tromey@adacore.com>
3615
3616         * windows-nat.c: Don't include buildsym-legacy.h.
3617
3618 2019-10-08  Tom Tromey  <tromey@adacore.com>
3619
3620         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3621
3622 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3623
3624         * gdbtypes.c (overload_debug): Move comment to header.
3625         * gdbtypes.h (overload_debug): Declare.
3626         * valops.c: Remove declaration of overload_debug, instead
3627         include gdbtypes.h.
3628
3629 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3630
3631         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3632         through _().
3633         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3634         move comment...
3635         * language.h (lang_frame_mismatch_warn): ... here. Also add
3636         declaration.
3637         * top.c (lang_frame_mismatch_warn): Remove declaration.
3638         (check_frame_language_change): Pass lang_frame_mismatch_warn
3639         through _().
3640
3641 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3642
3643         * c-lang.h (vtbl_ptr_name): Declare.
3644         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3645         it from the header.
3646         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3647
3648 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3649
3650         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3651         gdb_static_assert.
3652
3653 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3654
3655         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3656         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3657         * ctfread.c: New file.
3658         * ctfread.h: New file.
3659         * elfread.c: Include ctfread.h.
3660         (struct elfinfo text_p): New member ctfsect.
3661         (elf_locate_sections): Mark CTF section.
3662         (elf_symfile_read): Call elfctf_build_psymtabs.
3663         * Makefile.in (LIBCTF): Add.
3664         (CLIBS): Use it.
3665         (CDEPS): Likewise.
3666         (DIST): Add ctfread.c.
3667
3668 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * ctfread.c (struct nextfield): Renamed to ...
3671         (struct ctf_nextfield): ... this.
3672         (struct field_info): Renamed to ...
3673         (strut ctf_field_info): ... this.
3674         (attach_fields_to_type): Update for renamed structures.
3675         (ctf_add_member_cb): Likewise.
3676         (ctf_add_enum_member_cb): Likewise.
3677         (process_struct_members): Likewise.
3678         (process_enum_type): Likewise.
3679
3680 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3681
3682         * tracectf.h: Rename, was ctf.h.
3683         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3684         * tracefile.c: Likewise.
3685         * tracepoint.c: Remove unused include ctf.h.
3686         * mi/mi-main.c: Likewise.
3687         * Makefile.in Replace ctf.c with tracectf.c.
3688
3689 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3690
3691         * version.in: Change version number to "9.0.50.DATE-git".
3692
3693 2019-10-03  Tom Tromey  <tom@tromey.com>
3694
3695         PR rust/24976:
3696         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3697
3698 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3701         cp_search_name_hash.
3702         * NEWS: Add entry about nested function support.
3703
3704 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3705             Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3708         for nested static variables when searchin VAR_DOMAIN.
3709         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3710         global scope, update comment.
3711         (add_partial_subprogram): Call add_partial_subprogram recursively
3712         for nested subroutines when processinng Fortran.
3713         (load_partial_dies): Process the child entities of a subprogram
3714         when processing Fortran.
3715         (partial_die_parent_scope): Handle building scope
3716         for Fortran nested functions.
3717         (process_die): Record that nested functions have a scope.
3718         (new_symbol): Always record Fortran subprograms on the global
3719         symbol list.
3720         (determine_prefix): How to build the prefix for Fortran
3721         subprograms.
3722
3723 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3726         have just sent the thread a SIGSTOP and are waiting for it to
3727         arrive.
3728
3729 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * btrace.c (btrace_add_pc): Remove whitespace before the template
3732         parameter in 'std::vector <...>'.
3733         (parse_xml_btrace_block): Likewise.
3734         (btrace_maint_decode_pt): Likewise.
3735         (btrace_maint_update_packets): Likewise.
3736         (btrace_maint_print_packets): Likewise.
3737         * btrace.h (struct btrace_maint_info): Likewise.
3738         * dwarf2read.c (struct type_unit_group): Likewise.
3739         (build_type_psymtabs_reader): Likewise.
3740         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3741         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3742         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3743
3744 2019-10-03  Tom de Vries  <tdevries@suse.de>
3745
3746         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3747         the first line of the help text for set/show style metadata.
3748
3749 2019-10-02  Tom Tromey  <tromey@adacore.com>
3750
3751         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3752         * gdbsupport/common-inferior.c: New file.
3753         * infcmd.c (startup_with_shell): Don't define.
3754         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3755         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3756         * inferior.h (startup_with_shell): Don't declare.
3757
3758 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3759
3760         * gdbsupport/gdb_assert.h: Include errors.h.
3761         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3762
3763 2019-10-02  Tom Tromey  <tromey@adacore.com>
3764
3765         * NEWS: Add $_ada_exception entry.
3766         * ada-lang.c (struct ada_catchpoint): Add constructor.
3767         <m_kind>: New member.
3768         (allocate_location_exception, re_set_exception): Remove
3769         "ex" parameter.
3770         (should_stop_exception): Compute $_ada_exception.
3771         (check_status_exception, print_it_exception)
3772         (print_one_exception, print_mention_exception): Remove
3773         "ex" parameter.
3774         (allocate_location_catch_exception, re_set_catch_exception)
3775         (check_status_exception, print_it_catch_exception)
3776         (print_one_catch_exception, print_mention_catch_exception)
3777         (print_recreate_catch_exception)
3778         (allocate_location_catch_exception_unhandled)
3779         (re_set_catch_exception_unhandled)
3780         (check_status_exception, print_it_catch_exception_unhandled)
3781         (print_one_catch_exception_unhandled)
3782         (print_mention_catch_exception_unhandled)
3783         (print_recreate_catch_exception_unhandled)
3784         (allocate_location_catch_assert, re_set_catch_assert)
3785         (check_status_assert, print_it_catch_assert)
3786         (print_one_catch_assert, print_mention_catch_assert)
3787         (print_recreate_catch_assert)
3788         (allocate_location_catch_handlers, re_set_catch_handlers)
3789         (check_status_handlers, print_it_catch_handlers)
3790         (print_one_catch_handlers, print_mention_catch_handlers)
3791         (print_recreate_catch_handlers): Remove.
3792         (create_ada_exception_catchpoint): Update.
3793         (initialize_ada_catchpoint_ops): Update.
3794
3795 2019-10-02  Tom Tromey  <tromey@adacore.com>
3796
3797         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3798         (create_excep_cond_exprs): Simplify exception string computation.
3799         (ada_exception_catchpoint_cond_string): Likewise.
3800
3801 2019-10-02  Tom Tromey  <tromey@adacore.com>
3802
3803         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3804         * ada-lang.c (lesseq_defined_than): Handle
3805         LOC_STATIC.
3806         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3807         parameter.
3808         (dwarf2_has_info): Likewise.
3809         (new_symbol): Set maybe_copied on symbol when
3810         appropriate.
3811         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3812         parameter.
3813         <can_copy>: New member.
3814         * elfread.c (record_minimal_symbol): Set maybe_copied
3815         on symbol when appropriate.
3816         (elf_symfile_read): Update call to dwarf2_has_info.
3817         * minsyms.c (lookup_minimal_symbol_linkage): New
3818         function.
3819         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3820         * symtab.c (get_symbol_address, get_msymbol_address):
3821         New functions.
3822         * symtab.h (get_symbol_address, get_msymbol_address):
3823         Declare.
3824         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3825         maybe_copied.
3826         (struct symbol, struct minimal_symbol) <maybe_copied>:
3827         New member.
3828
3829 2019-10-02  Tom Tromey  <tromey@adacore.com>
3830
3831         * source.c (struct current_source_location): New.
3832         (current_source_key): New global.
3833         (current_source_symtab, current_source_line)
3834         (current_source_pspace): Remove.
3835         (get_source_location): New function.
3836         (get_current_source_symtab_and_line)
3837         (set_default_source_symtab_and_line)
3838         (set_current_source_symtab_and_line)
3839         (clear_current_source_symtab_and_line, select_source_symtab)
3840         (info_source_command, print_source_lines_base)
3841         (info_line_command, search_command_helper, _initialize_source):
3842         Update.
3843
3844 2019-10-02  Tom Tromey  <tromey@adacore.com>
3845
3846         * source.c (select_source_symtab): Don't call
3847         decode_line_with_current_source.
3848
3849 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * symtab.c (lookup_global_symbol): Search global block.
3852
3853 2019-10-02  Tom Tromey  <tromey@adacore.com>
3854
3855         * coffread.c (process_coff_symbol): Update.
3856         * dwarf2read.c (var_decode_location, new_symbol): Update.
3857         * mdebugread.c (parse_symbol): Update.
3858         * objfiles.c (relocate_one_symbol): Update.
3859         * stabsread.c (define_symbol, fix_common_block)
3860         (scan_file_globals): Update.
3861         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3862         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3863         * xcoffread.c (process_xcoff_symbol): Update.
3864
3865 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3866
3867         * MAINTAINERS: Update my email address.
3868
3869 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3872         std::vector.
3873         (build_type_psymtabs_reader): Update for std::vector.
3874         (build_type_psymtab_dependencies): Likewise.
3875         * dwarf2read.h: Remove use of DEF_VEC_P.
3876         (typedef sig_type_ptr): Delete.
3877
3878 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3881         to std::vector.
3882         (btrace_maint_decode_pt): Likewise, and move allocation of the
3883         vector outside of the loop.
3884         (btrace_maint_update_packets): Update to handle change from VEC to
3885         std::vector.
3886         (btrace_maint_print_packets): Likewise.
3887         (maint_info_btrace_cmd): Likewise.
3888         * btrace.h: Remove use of DEF_VEC_O.
3889         (typedef btrace_pt_packet_s): Delete.
3890         (struct btrace_maint_info) <packets>: Change fromm VEC to
3891         std::vector.
3892         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3893
3894 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3895
3896         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3897         make accesses into the vector constant references.
3898         (btrace_add_pc): Update for std::vector.
3899         (btrace_stitch_bts): Likewise.
3900         (parse_xml_btrace_block): Likewise.
3901         (btrace_maint_update_packets): Likewise.
3902         (btrace_maint_print_packets): Likewise.
3903         (maint_info_btrace_cmd): Likewise.
3904         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3905         std::vector.
3906         (btrace_data::empty): Likewise.
3907         (btrace_data_append): Likewise.
3908         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3909         (typedef btrace_block_s): Delete.
3910         (struct btrace_block): Add constructor.
3911         (struct btrace_data_bts) <blocks>: Change to std::vector.
3912         * nat/linux-btrace.c (perf_event_read_bts): Update for
3913         std::vector.
3914         (linux_read_bts): Likewise.
3915
3916 2019-10-01  Tom Tromey  <tom@tromey.com>
3917
3918         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3919
3920 2019-10-01  Tom Tromey  <tom@tromey.com>
3921
3922         * stack.c (print_frame, info_frame_command_core): Use
3923         styled_string.
3924         * linux-thread-db.c (try_thread_db_load_1)
3925         (try_thread_db_load_from_pdir_1): Use styled_string.
3926         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3927         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3928         (maybe_print_unsupported_script_warning)
3929         (maybe_print_script_not_found_warning): Use styled_string.
3930         * ada-lang.c (user_select_syms): Use styled_string.
3931
3932 2019-10-01  Tom Tromey  <tom@tromey.com>
3933
3934         * p-lang.c (pascal_printstr): Use metadata style.
3935         * value.c (show_convenience): Use metadata style.
3936         * valprint.c (valprint_check_validity, val_print_optimized_out)
3937         (val_print_not_saved, val_print_unavailable)
3938         (val_print_invalid_address, generic_val_print, val_print)
3939         (value_check_printable, val_print_array_elements): Use metadata
3940         style.
3941         * ui-out.h (class ui_out) <field_fmt>: New overload.
3942         <do_field_fmt>: Add style parameter.
3943         * ui-out.c (ui_out::field_fmt): New overload.
3944         * typeprint.c (type_print_unknown_return_type)
3945         (val_print_not_allocated, val_print_not_associated): Use metadata
3946         style.
3947         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3948         parameter.
3949         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3950         * tracepoint.c (tvariables_info_1): Use metadata style.
3951         * stack.c (print_frame_arg, print_frame_info, print_frame)
3952         (info_frame_command_core): Use metadata style.
3953         * skip.c (info_skip_command): Use metadata style.
3954         * rust-lang.c (rust_print_enum): Use metadata style.
3955         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3956         metadata style.
3957         * python/py-framefilter.c (py_print_single_arg): Use metadata
3958         style.
3959         * printcmd.c (do_one_display, print_variable_and_value): Use
3960         metadata style.
3961         * p-valprint.c (pascal_val_print)
3962         (pascal_object_print_value_fields): Use metadata style.
3963         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3964         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3965         parameter.
3966         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3967         * m2-valprint.c (m2_print_long_set): Use metadata style.
3968         * m2-typeprint.c (m2_print_type): Use metadata style.
3969         * infcmd.c (print_return_value_1): Use metadata style.
3970         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3971         * f-valprint.c (info_common_command_for_block): Use metadata
3972         style.
3973         * f-typeprint.c (f_type_print_base): Use metadata style.
3974         * expprint.c (print_subexp_standard): Use metadata style.
3975         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3976         * cli/cli-style.h (class cli_style_option): Add constructor.
3977         (metadata_style): Declare.
3978         * cli/cli-style.c (metadata_style): New global.
3979         (_initialize_cli_style): Register metadata style.
3980         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3981         parameter.
3982         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3983         * c-typeprint.c (c_type_print_base_struct_union)
3984         (c_type_print_base_1): Use metadata style.
3985         * breakpoint.c (watchpoint_value_print)
3986         (print_one_breakpoint_location): Use metadata style.
3987         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3988         style.
3989         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3990         style.
3991         * ada-valprint.c (val_print_packed_array_elements, printstr)
3992         (print_field_values, ada_val_print_ref, ada_val_print): Use
3993         metadata style.
3994         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3995         style.
3996         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3997         style.
3998         * ada-lang.c (user_select_syms): Use metadata style.
3999
4000 2019-10-01  Tom Tromey  <tom@tromey.com>
4001
4002         * cli/cli-cmds.c (pwd_command): Style output.
4003
4004 2019-10-01  Pedro Alves  <palves@redhat.com>
4005             Tom Tromey  <tom@tromey.com>
4006
4007         * symtab.c (print_symbol_info): Use %ps.
4008         (print_msymbol_info): Use %ps.
4009         * symfile.c (symbol_file_add_with_addrs): Use %ps.
4010         * printcmd.c (print_variable_and_value): Use %ps.
4011         * macrocmd.c (show_pp_source_pos): Use %ps.
4012         * infrun.c (print_exited_reason): Use ui_out::message.
4013         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4014         (describe_other_breakpoints): Use ui_out::message and new
4015         formats.
4016         (say_where): Use new formats.
4017         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4018         and new formats.
4019
4020 2019-10-01  Pedro Alves  <palves@redhat.com>
4021             Tom Tromey  <tom@tromey.com>
4022
4023         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4024         (test_gdb_formats): New function.
4025         (run_tests): Call it.
4026         (test_format_specifier): Update.
4027         * utils.h (fputs_filtered): Update comment.
4028         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4029         (fputs_styled_unfiltered): Declare.
4030         * utils.c (fputs_styled_unfiltered): New function.
4031         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4032         (vfprintf_filtered): Update.
4033         (vfprintf_unfiltered, vprintf_filtered): Update.
4034         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4035         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4036         disallow_ui_out_field>: New constants.
4037         (enum class field_kind): New.
4038         (struct base_field_s, struct signed_field_s): New.
4039         (signed_field): New function.
4040         (struct string_field_s): New.
4041         (string_field): New function.
4042         (struct styled_string_s): New.
4043         (styled_string): New function.
4044         (class ui_out) <message>: Add comment.
4045         <vmessage, call_do_message>: New methods.
4046         <do_message>: Add style parameter.
4047         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4048         methods.
4049         (ui_out::message): Rewrite.
4050         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4051         parameter.
4052         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4053         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4054         gdb_extensions parameter.
4055         (class format_piece): Add parameter to constructor.
4056         (n_int_args): New field.
4057         * gdbsupport/format.c (format_pieces::format_pieces): Add
4058         gdb_extensions parameter.  Handle '*'.
4059         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4060         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4061         vfprintf_styled_no_gdbfmt.
4062         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4063         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4064         unfiltered output.
4065         * ui-style.h (struct ui_file_style) <ptr>: New method.
4066
4067 2019-10-01  Tom Tromey  <tom@tromey.com>
4068
4069         * unittests/format_pieces-selftests.c: Update.  Add final format.
4070         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4071         empty literal pieces.
4072
4073 2019-10-01  Tom Tromey  <tom@tromey.com>
4074
4075         * ui-out.h (enum class ui_out_style_kind): Remove.
4076         (class ui_out) <field_string, field_stsream, do_field_string>:
4077         Change type of "style".
4078         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4079         (ui_out::field_string): Update.
4080         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4081         of "style".
4082         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4083         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4084         * stack.c (print_frame_arg, print_frame_info, print_frame):
4085         Update.
4086         * source.c (print_source_lines_base): Update.
4087         * solib.c (info_sharedlibrary_command): Update.
4088         * skip.c (info_skip_command): Update.
4089         * record-btrace.c (btrace_call_history_src_line)
4090         (btrace_call_history): Update.
4091         * python/py-framefilter.c (py_print_frame): Update.
4092         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4093         "style".
4094         * mi/mi-out.c (mi_ui_out::do_table_header)
4095         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4096         (mi_ui_out::do_field_string): Update.
4097         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4098         Update.
4099         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4100         "style".
4101         * cli-out.c (cli_ui_out::do_table_header)
4102         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4103         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4104         (cli_ui_out::do_field_fmt): Update.
4105         * breakpoint.c (print_breakpoint_location): Update.
4106         (update_static_tracepoint): Update.
4107
4108 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4109
4110         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4111         conversion of gdb_datadir.
4112         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4113         remove not needed c_str ().
4114
4115 2019-09-30  Ali Tamur <tamur@google.com>
4116
4117         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4118         (dwarf2_string_attr): Likewise.
4119
4120 2019-09-30  Ali Tamur <tamur@google.com>
4121
4122         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4123         (process_full_type_unit): Likewise.
4124         (dump_die_shallow): Likewise.
4125         (cu_debug_loc_section): Likewise.
4126
4127 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4128
4129         * minsyms.c (compare_minimal_symbols): Rename to...
4130         (minimal_symbol_is_less_than): ...this, and adjust to STL
4131         conventions (return bool, take arguments as references)
4132         (minimal_symbol_reader::install): Call std::sort instead
4133         of qsort.
4134
4135 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4136
4137         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4138         hash and why.
4139         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4140         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4141
4142 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4143
4144         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4145         * psympriv.h (add_psymbol_to_list): Move comment here and update
4146         it.
4147
4148 2019-09-29  Tom de Vries  <tdevries@suse.de>
4149
4150         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4151         Use $tmpdir/$(basename "$output_file").dwz instead of
4152         "${output_file}.dwz".
4153
4154 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4155
4156         PR gdb/25045
4157         * hppa-linux-nat.c: Include gdbarch.h.
4158
4159 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4160
4161         * blockframe.c (find_pc_partial_function): Change return type to bool.
4162         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4163         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4164         (stub_gnu_ifunc_resolve_name): Likewise.
4165         * symtab.c (compare_filenames_for_search): Likewise.
4166         (compare_glob_filenames_for_search): Likewise.
4167         (matching_obj_sections): Likewise.
4168         (symbol_matches_domain): Likewise.
4169         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4170         (find_line_pc): Change return type to bool.
4171         (find_line_pc_range): Likewise.
4172         (producer_is_realview): Likewise.
4173         * symtab.h (symbol_matches_domain): Likewise.
4174         (find_pc_partial_function): Likewise.
4175         (find_pc_line_pc_range): Likewise.
4176         (in_gnu_ifunc_stub): Likewise.
4177         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4178         (find_line_pc): Likewise.
4179         (find_line_pc_range): Likewise.
4180         (matching_obj_sections): Likewise.
4181         (find_line_symtab): Change out parameter to bool.
4182         (producer_is_realview): Change return type to bool.
4183         (compare_filenames_for_search): Likewise.
4184         (compare_glob_filenames_for_search): Likewise.
4185
4186 2019-09-26  Tom Tromey  <tom@tromey.com>
4187
4188         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4189         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4190         * gdb_usleep.h: Remove.
4191         * gdb_usleep.c: Remove.
4192         * utils.c: Don't include gdb_usleep.h.
4193
4194 2019-09-26  Tom Tromey  <tromey@adacore.com>
4195
4196         * python/py-type.c (type_to_type_object): Call check_typedef
4197         for stub types.
4198
4199 2019-09-26  Tom Tromey  <tom@tromey.com>
4200
4201         * utils.h (initialize_utils): Don't declare.
4202         * top.c (gdb_init): Don't call initialize_utils.
4203         * utils.c (initialize_utils): Remove.  Move contents...
4204         (_initialize_utils): ... here.
4205
4206 2019-09-25  Tom Tromey  <tom@tromey.com>
4207
4208         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4209         * utils.h (make_hex_string): Don't declare.
4210         * utils.c (make_hex_string): Remove.
4211
4212 2019-09-24  Tom de Vries  <tdevries@suse.de>
4213
4214         PR gdb/23815
4215         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4216         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4217
4218 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4219
4220         * NEWS: Mention new simulator port for PRU.
4221
4222 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4223
4224         * ada-exp.y (write_object_remaining): Update.
4225         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4226         and eliminate the static buffer.
4227         (ada_decode_symbol): Update.
4228         (ada_la_decode): Update.
4229         (ada_sniff_from_mangled_name): Update.
4230         (is_valid_name_for_wild_match): Update.
4231         (ada_lookup_name_info::matches): Update and simplify.
4232         (name_matches_regex): Update.
4233         (ada_add_global_exceptions): Update.
4234         * ada-lang.h (ada_decode): Update signature.
4235         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4236         * dwarf-index-write.c (debug_names::insert): Update.
4237
4238 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4239
4240         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4241         formatting.
4242
4243 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4244
4245         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4246         Change "nonzero" to "true" in documentation.
4247
4248 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4249
4250         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4251         (_initialize_darwin_solib): Don't set
4252         darwin_so_ops.lookup_lib_global_symbol.
4253         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4254         set_gdbarch_iterate_over_objfiles_in_search_order.
4255         (elf_lookup_lib_symbol): Rename to...
4256         (svr4_iterate_over_objfiles_in_search_order): this, and update
4257         to iterate semantics.
4258         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4259         * solib.c (solib_global_lookup): Remove.
4260         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4261         (solib_global_lookup): Remove.
4262         * symtab.c (lookup_global_or_static_symbol): Remove call to
4263         solib_global_lookup.
4264
4265 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4266
4267         * NEWS: Move entries about default MI version now being
4268         version 3, and about the GDB/MI fix for multi-location
4269         breakpoints to the "since GDB 8.3" section.
4270
4271 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4272
4273         GDB 8.3.1 released.
4274
4275 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4276
4277         * NEWS: Mention that Cell/B.E. debugging support was removed.
4278         * MAINTAINERS: Remove spu target.
4279
4280         * config/djgpp/fnchange.lst: Remove entries for removed files.
4281
4282         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4283         spu-multiarch.o, and spu-tdep.o.
4284         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4285         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4286         spu-multiarch.c, and spu-tdep.c.
4287         * spu-linux-nat.c: Remove file.
4288         * spu-multiarch.c: Remove file.
4289         * spu-tdep.c: Remove file.
4290         * spu-tdep.h: Remove file.
4291         * solib-spu.c: Remove file.
4292         * solib-spu.h: Remove file.
4293
4294         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4295         * configure.nat (spu-linux): Remove.
4296         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4297         solib-multiarch.o from gdb_target_obs.
4298         (spu*-*-*): Remove.
4299
4300         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4301         feature flag.
4302         (ppc_linux_no_features): Update.
4303         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4304         Cell/B.E. support.
4305         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4306         (tdesc_powerpc_cell64l): Likewise.
4307         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4308         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4309         Cell/B.E. support.
4310         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4311         Do not include "features/rs6000/powerpc-cell32l.c" or
4312         "features/rs6000/powerpc-cell64l.c".
4313         (ppc_linux_spu_section): Remove.
4314         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4315         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4316         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4317         (ppc_linux_spe_context_lookup): Remove.
4318         (ppc_linux_spe_context_inferior_created): Remove.
4319         (ppc_linux_spe_context_solib_loaded): Remove.
4320         (ppc_linux_spe_context_solib_unloaded): Remove.
4321         (ppc_linux_spe_context): Remove.
4322         (struct ppu2spu_cache): Remove.
4323         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4324         (struct ppu2spu_data): Remove.
4325         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4326         ppu2spu_unwind): Remove.
4327         (ppc_linux_init_abi): Remove Cell/B.E. support.
4328         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4329
4330         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4331         (rs6000/powerpc-cell64l-expedite): Likewise
4332         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4333         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4334         rs6000/powerpc-cell64l.xml.
4335         * features/rs6000/powerpc-cell32l.xml: Remove.
4336         * features/rs6000/powerpc-cell64l.xml: Likewise.
4337         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4338         * features/rs6000/powerpc-cell64l.c: Likewise.
4339         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4340         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4341         * regformats/reg-spu.dat: Remove.
4342
4343         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4344         * corelow.c (struct spuid_list): Remove.
4345         (add_to_spuid_list): Remove.
4346         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4347         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4348         (remote_protocol_features): Remove associated entries.
4349         (_initialize_remote): No longer initialize them.
4350         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4351         * linux-nat.c (SPUFS_MAGIC): Remove.
4352         (linux_proc_xfer_spu): Remove.
4353         (spu_enumerate_spu_ids): Remove.
4354         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4355         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4356         (linux_make_corefile_notes): No longer call it.
4357
4358         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4359         (cooked_write_test): Likewise.
4360
4361 2019-09-20  Tom Tromey  <tom@tromey.com>
4362
4363         * NEWS: Mention case-sensitivity of TUI commands.
4364         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4365         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4366         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4367
4368 2019-09-20  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-source.c (tui_source_window::set_contents): Use
4371         make_unique_xstrdup.
4372         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4373         make_unique_xstrdup.
4374
4375 2019-09-20  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui-data.c: Remove separator comments.
4378         * tui/tui-layout.c: Remove separator comments.
4379         * tui/tui-win.c: Remove separator comments.
4380         * tui/tui-wingeneral.c: Remove separator comments.
4381
4382 2019-09-20  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui.h (strcat_to_buf): Don't declare.
4385         * tui/tui.c (strcat_to_buf): Remove.
4386
4387 2019-09-20  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4390         from "fullname".
4391         * tui/tui-source.c (tui_source_window::set_contents)
4392         (tui_source_window::location_matches_p)
4393         (tui_source_window::maybe_update): Update.
4394
4395 2019-09-20  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4398         Update.
4399         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4400         prefix.
4401         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4402         (tui_data_window::line_from_reg_element_no)
4403         (tui_data_window::first_reg_element_no_inline)
4404         (tui_data_window::show_registers)
4405         (tui_data_window::show_register_group)
4406         (tui_data_window::display_registers_from)
4407         (tui_data_window::display_registers_from_line)
4408         (tui_data_window::first_data_item_displayed)
4409         (tui_data_window::delete_data_content_windows)
4410         (tui_data_window::erase_data_content)
4411         (tui_data_window::do_scroll_vertical)
4412         (tui_data_window::refresh_window)
4413         (tui_data_window::check_register_values): Update.
4414
4415 2019-09-20  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4418         (struct tui_locator_window) <full_name, proc_name>: Now
4419         std::string.
4420         * tui/tui-stack.c (tui_locator_window::make_status_line)
4421         (tui_locator_window::set_locator_fullname)
4422         (tui_locator_window::set_locator_info): Update.
4423         * tui/tui-source.c (tui_source_window::set_contents)
4424         (tui_source_window::showing_source_p): Update.
4425
4426 2019-09-20  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4429         Don't call tui_locator_win_info_ptr.
4430
4431 2019-09-20  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4434
4435 2019-09-20  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4438         height for locator.
4439         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4440         * tui/tui-layout.c (show_source_disasm_command, show_data)
4441         (show_source_or_disasm_and_command): Use 1 as height for locator.
4442
4443 2019-09-20  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui.c (tui_enable): Update.
4446         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4447         Update.
4448         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4449         Update.
4450         * tui/tui-data.c (win_resized): Now bool.
4451         (tui_win_resized): Return bool.
4452         (tui_set_win_resized_to): Accept a bool.
4453
4454 2019-09-20  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4457         Change type of "refresh_values_only".
4458         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4459         type of "refresh_values_only".
4460
4461 2019-09-20  Tom Tromey  <tom@tromey.com>
4462
4463         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4464         std::string.
4465         (tui_disassemble): Add "pos" parameter.
4466         (tui_disasm_window::set_contents): Simplify.
4467
4468 2019-09-20  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-winsource.h (struct tui_source_window_base)
4471         <show_source_content>: Now private.
4472         * tui/tui-winsource.c
4473         (tui_source_window_base::show_source_content): Don't handle empty
4474         content case.
4475
4476 2019-09-20  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-layout.c (show_source_disasm_command)
4479         (show_source_or_disasm_and_command): Don't call
4480         show_source_content.
4481
4482 2019-09-20  Tom Tromey  <tom@tromey.com>
4483
4484         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4485         Declare.
4486         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4487         from tui_make_status_line.
4488         (tui_locator_window::rerender): Update.
4489
4490 2019-09-20  Tom Tromey  <tom@tromey.com>
4491
4492         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4493         (tui_locator_window::rerender): Update.
4494
4495 2019-09-20  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-winsource.h (struct tui_source_window_base)
4498         <~tui_source_window_base>: Don't declare.
4499         <fullname>: Remove.
4500         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4501         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4502         member.
4503         * tui/tui-source.c (tui_source_window::set_contents): Update.
4504         (tui_source_window::location_matches_p)
4505         (tui_source_window::maybe_update): Update.
4506
4507 2019-09-20  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-winsource.h (~tui_source_element): Remove.
4510         (tui_source_element): Update.
4511         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4512         * tui/tui-winsource.c (tui_show_source_line): Update.
4513         * tui/tui-source.c (tui_source_window::set_contents): Update.
4514         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4515
4516 2019-09-20  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4519         declare.
4520         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4521         tui_clear_source_windows_detail.
4522         * tui/tui-winsource.h (struct tui_source_window_base)
4523         <clear_detail>: Don't declare.
4524         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4525         Remove.
4526         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4527
4528 2019-09-20  Tom Tromey  <tromey@adacore.com>
4529
4530         PR ada/24919:
4531         * block.c (contained_in): Fix final return value.
4532
4533 2019-09-20  Alan Modra  <amodra@gmail.com>
4534
4535         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4536         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4537         (read_indirect_string_from_dwz): Use bfd accessor.
4538         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4539         * machoread.c (macho_symfile_read_all_oso): Likewise.
4540         * solib.c (solib_bfd_open): Likewise.
4541
4542 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4543
4544         * eval.c: Move declaration of overload_resolution to...
4545         * value.h: ...here.
4546
4547 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4548
4549         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4550         * arm-linux-tdep.c: Likewise.
4551         * arm-nbsd-nat.c: Likewise.
4552         * arm-tdep.h: Declare arm_apcs_32.
4553         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4554
4555 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4556
4557         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4558         * dwarf2read.h: Declare dwarf_always_disassemble.
4559
4560 2019-09-19  Tom de Vries  <tdevries@suse.de>
4561
4562         PR gdb/25009
4563         * source-cache.c (source_cache::ensure): Catch exception thrown during
4564         construction of the highlighter.
4565
4566 2019-09-18  Alan Modra  <amodra@gmail.com>
4567
4568         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4569         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4570         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4571         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4572         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4573         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4574         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4575         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4576         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4577         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4578         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4579         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4580         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4581         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4582         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4583         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4584         * mi/mi-interp.c: Update throughout for bfd section macro and
4585         function changes.
4586         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4587         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4588
4589 2019-09-18  Tom Tromey  <tom@tromey.com>
4590
4591         * NEWS: Add entry.
4592         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4593         call rl_initialize.
4594         (tui_enable): Do not call rl_initialize.
4595
4596 2019-09-18  Christian Groessler  <chris@groessler.org>
4597
4598         * alpha-linux-nat.c: Include gdbarch.h.
4599
4600 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4601
4602         * ui-file.c: Include cli/cli-style.h.
4603         (term_cli_styling): Remove cli_styling declaration.
4604
4605 2019-09-18  Alan Modra  <amodra@gmail.com>
4606
4607         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4608         to bfd_asymbol_section.
4609
4610 2019-09-18  Alan Modra  <amodra@gmail.com>
4611
4612         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4613         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4614         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4615
4616 2019-09-18  Alan Modra  <amodra@gmail.com>
4617
4618         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4619         * spu-linux-nat.c (spu_bfd_open): Likewise.
4620
4621 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4622
4623         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4624         to bool to match definition in dwarf2read.c.
4625
4626 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4627
4628         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4629         (print_signatures): Likewise.
4630         (trust_pad_over_xvs): Likewise.
4631         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4632         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4633         * arm-linux-nat.c (arm_apcs_32): Likewise.
4634         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4635         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4636         * arm-tdep.c (arm_debug): Likewise.
4637         (arm_apcs_32): Likewise.
4638         * auto-load.c (debug_auto_load): Likewise.
4639         (auto_load_gdb_scripts): Likewise.
4640         (global_auto_load): Likewise.
4641         (auto_load_local_gdbinit): Likewise.
4642         (auto_load_local_gdbinit_loaded): Likewise.
4643         * auto-load.h (global_auto_load): Likewise.
4644         (auto_load_local_gdbinit): Likewise.
4645         (auto_load_local_gdbinit_loaded): Likewise.
4646         * breakpoint.c (disconnected_dprintf): Likewise.
4647         (breakpoint_proceeded): Likewise.
4648         (automatic_hardware_breakpoints): Likewise.
4649         (always_inserted_mode): Likewise.
4650         (target_exact_watchpoints): Likewise.
4651         (_initialize_breakpoint): Update.
4652         * breakpoint.h (target_exact_watchpoints): Change to bool.
4653         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4654         * cli/cli-cmds.c (trace_commands): Likewise.
4655         * cli/cli-cmds.h (trace_commands): Likewise.
4656         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4657         to bool*.
4658         * cli/cli-logging.c (logging_overwrite): Change to bool.
4659         (logging_redirect): Likewise.
4660         (debug_redirect): Likewise.
4661         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4662         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4663         to bool.
4664         <boolean_option_def>: Update.
4665         (struct flag_option_def): Change default type of Context to bool
4666         from int.
4667         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4668         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4669         (get_setshow_command_value_string): Likewise.
4670         * cli/cli-style.c (cli_styling): Change to bool.
4671         (source_styling): Likewise.
4672         * cli/cli-style.h (source_styling): Likewise.
4673         (cli_styling): Likewise.
4674         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4675         to bool.
4676         * command.h (var_types): Update comment.
4677         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4678         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4679         bool.
4680         (debug_compile_cplus_scopes): Likewise.
4681         * compile/compile-internal.h (compile_debug): Likewise.
4682         * compile/compile.c (compile_debug): Likewise.
4683         (struct compile_options) <raw>: Likewise.
4684         * cp-support.c (catch_demangler_crashes): Likewise.
4685         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4686         (usr_cmd_cris_dwarf2_cfi): Likewise.
4687         * csky-tdep.c (csky_debug): Likewise.
4688         * darwin-nat.c (enable_mach_exceptions): Likewise.
4689         * dcache.c (dcache_enabled_p): Likewise.
4690         * defs.h (info_verbose): Likewise.
4691         * demangle.c (demangle): Likewise.
4692         (asm_demangle): Likewise.
4693         * dwarf-index-cache.c (debug_index_cache): Likewise.
4694         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4695         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4696         * dwarf2read.c (check_physname): Likewise.
4697         (use_deprecated_index_sections): Likewise.
4698         (dwarf_always_disassemble): Likewise.
4699         * eval.c (overload_resolution): Likewise.
4700         * event-top.c (set_editing_cmd_var): Likewise.
4701         (exec_done_display_p): Likewise.
4702         * event-top.h (set_editing_cmd_var): Likewise.
4703         (exec_done_display_p): Likewise.
4704         * exec.c (write_files): Likewise.
4705         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4706         (debug_fbsd_nat): Likewise.
4707         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4708         Likewise.
4709         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4710         <backtrace_past_entry> Likewise.
4711         * gdb-demangle.h (demangle): Likewise.
4712         (asm_demangle): Likewise.
4713         * gdb_bfd.c (bfd_sharing): Likewise.
4714         * gdbcore.h (write_files): Likewise.
4715         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4716         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4717         * gdbthread.h (print_thread_events): Likewise.
4718         * gdbtypes.c (opaque_type_resolution): Likewise.
4719         (strict_type_checking): Likewise.
4720         * gnu-nat.c (gnu_debug_flag): Likewise.
4721         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4722         * guile/scm-param.c (pascm_variable): Add boolval.
4723         (add_setshow_generic): Update.
4724         (pascm_param_value): Update.
4725         (pascm_set_param_value_x): Update.
4726         * hppa-tdep.c (hppa_debug): Change to bool..
4727         * infcall.c (may_call_functions_p): Likewise.
4728         (coerce_float_to_double_p): Likewise.
4729         (unwind_on_signal_p): Likewise.
4730         (unwind_on_terminating_exception_p): Likewise.
4731         * infcmd.c (startup_with_shell): Likewise.
4732         * inferior.c (print_inferior_events): Likewise.
4733         * inferior.h (startup_with_shell): Likewise.
4734         (print_inferior_events): Likewise.
4735         * infrun.c (step_stop_if_no_debug): Likewise.
4736         (detach_fork): Likewise.
4737         (debug_displaced): Likewise.
4738         (disable_randomization): Likewise.
4739         (non_stop): Likewise.
4740         (non_stop_1): Likewise.
4741         (observer_mode): Likewise.
4742         (observer_mode_1): Likewise.
4743         (set_observer_mode): Update.
4744         (sched_multi): Change to bool.
4745         * infrun.h (debug_displaced): Likewise.
4746         (sched_multi): Likewise.
4747         (step_stop_if_no_debug): Likewise.
4748         (non_stop): Likewise.
4749         (disable_randomization): Likewise.
4750         * linux-tdep.c (use_coredump_filter): Likewise.
4751         (dump_excluded_mappings): Likewise.
4752         * linux-thread-db.c (auto_load_thread_db): Likewise.
4753         (check_thread_db_on_load): Likewise.
4754         * main.c (captured_main_1): Update.
4755         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4756         xx2_opt, boolean_opt>: Change to bool.
4757         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4758         * maint.c (maintenance_profile_p): Likewise.
4759         (per_command_time): Likewise.
4760         (per_command_space): Likewise.
4761         (per_command_symtab): Likewise.
4762         * memattr.c (inaccessible_by_default): Likewise.
4763         * mi/mi-main.c (mi_async): Likewise.
4764         (mi_async_1): Likewise.
4765         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4766         * nat/fork-inferior.h (startup_with_shell): Likewise.
4767         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4768         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4769         * nios2-tdep.c (nios2_debug): Likewise.
4770         * or1k-tdep.c (or1k_debug): Likewise.
4771         * parse.c (parser_debug): Likewise.
4772         * parser-defs.h (parser_debug): Likewise.
4773         * printcmd.c (print_symbol_filename): Likewise.
4774         * proc-api.c (procfs_trace): Likewise.
4775         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4776         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4777         (set_parameter_value): Update.
4778         (add_setshow_generic): Update.
4779         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4780         to bool*.
4781         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4782         int*.
4783         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4784         * record-btrace.c (record_btrace_target::store_registers): Update.
4785         * record-full.c (record_full_memory_query): Change to bool.
4786         (record_full_stop_at_limit): Likewise.
4787         * record-full.h (record_full_memory_query): Likewise.
4788         * remote-notif.c (notif_debug): Likewise.
4789         * remote-notif.h (notif_debug): Likewise.
4790         * remote.c (use_range_stepping): Likewise.
4791         (interrupt_on_connect): Likewise.
4792         (remote_break): Likewise.
4793         * ser-tcp.c (tcp_auto_retry): Likewise.
4794         * ser-unix.c (serial_hwflow): Likewise.
4795         * skip.c (debug_skip): Likewise.
4796         * solib-aix.c (solib_aix_debug): Likewise.
4797         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4798         (spu_auto_flush_cache_p): Likewise.
4799         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4800         Likewise.
4801         (struct info_print_options) <quiet>: Likewise.
4802         * symfile-debug.c (debug_symfile): Likewise.
4803         * symfile.c (auto_solib_add): Likewise.
4804         (separate_debug_file_debug): Likewise.
4805         * symfile.h (auto_solib_add): Likewise.
4806         (separate_debug_file_debug): Likewise.
4807         * symtab.c (basenames_may_differ): Likewise.
4808         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4809         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4810         (struct info_types_options) <quiet>: Likewise.
4811         * symtab.h (demangle): Likewise.
4812         (basenames_may_differ): Likewise.
4813         * target-dcache.c (stack_cache_enabled_1): Likewise.
4814         (code_cache_enabled_1): Likewise.
4815         * target.c (trust_readonly): Likewise.
4816         (may_write_registers): Likewise.
4817         (may_write_memory): Likewise.
4818         (may_insert_breakpoints): Likewise.
4819         (may_insert_tracepoints): Likewise.
4820         (may_insert_fast_tracepoints): Likewise.
4821         (may_stop): Likewise.
4822         (auto_connect_native_target): Likewise.
4823         (target_stop_and_wait): Update.
4824         (target_async_permitted): Change to bool.
4825         (target_async_permitted_1): Likewise.
4826         (may_write_registers_1): Likewise.
4827         (may_write_memory_1): Likewise.
4828         (may_insert_breakpoints_1): Likewise.
4829         (may_insert_tracepoints_1): Likewise.
4830         (may_insert_fast_tracepoints_1): Likewise.
4831         (may_stop_1): Likewise.
4832         * target.h (target_async_permitted): Likewise.
4833         (may_write_registers): Likewise.
4834         (may_write_memory): Likewise.
4835         (may_insert_breakpoints): Likewise.
4836         (may_insert_tracepoints): Likewise.
4837         (may_insert_fast_tracepoints): Likewise.
4838         (may_stop): Likewise.
4839         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4840         (make_thread_apply_all_options_def_group): Change argument from int*
4841         to bool*.
4842         (thread_apply_all_command): Update.
4843         (print_thread_events): Change to bool.
4844         * top.c (confirm): Likewise.
4845         (command_editing_p): Likewise.
4846         (history_expansion_p): Likewise.
4847         (write_history_p): Likewise.
4848         (info_verbose): Likewise.
4849         * top.h (confirm): Likewise.
4850         (history_expansion_p): Likewise.
4851         * tracepoint.c (disconnected_tracing): Likewise.
4852         (circular_trace_buffer): Likewise.
4853         * typeprint.c (print_methods): Likewise.
4854         (print_typedefs): Likewise.
4855         * utils.c (debug_timestamp): Likewise.
4856         (sevenbit_strings): Likewise.
4857         (pagination_enabled): Likewise.
4858         * utils.h (sevenbit_strings): Likewise.
4859         (pagination_enabled): Likewise.
4860         * valops.c (overload_resolution): Likewise.
4861         * valprint.h (struct value_print_options) <prettyformat_arrays,
4862         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4863         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4864         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4865         Likewise.
4866         * windows-nat.c (new_console): Likewise.
4867         (cygwin_exceptions): Likewise.
4868         (new_group): Likewise.
4869         (debug_exec): Likewise.
4870         (debug_events): Likewise.
4871         (debug_memory): Likewise.
4872         (debug_exceptions): Likewise.
4873         (useshell): Likewise.
4874         * windows-tdep.c (maint_display_all_tib): Likewise.
4875         * xml-support.c (debug_xml): Likewise.
4876
4877 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4878
4879         * source.c (prepare_path_for_appending): New function.
4880         (openp): Make use of new function.
4881         (find_and_open_source): Search for the compilation directory and
4882         source file as a relative path beneath the directory search path.
4883
4884 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * source-cache.c (source_cache::get_line_charpos): Catch
4887         exceptions and return false, this matches the behaviour documented
4888         in the header file.
4889
4890 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4891
4892         * ada-tasks.c (info_task): Remove quoting of the task's name.
4893
4894 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4895
4896         * symfile.c (auto_solib_add): Replace comment with a reference
4897         to the header file.
4898
4899 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4900
4901         * NEWS: Mention that gdb can now be compiled with Python 3
4902         on Windows.
4903
4904 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * maint.c (maint_print_section_data::maint_print_section_data):
4907         Force use of 'float log10 (float)' by casting the argument to
4908         float.
4909
4910 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * maint.c: Add 'cmath' include.
4913         (struct maint_print_section_data): New structure.
4914         (print_section_index): New function.
4915         (print_bfd_section_info): Add header comment, small whitespace
4916         cleanup, and update to call new print_section_index function.
4917         (print_objfile_section_info): Likewise.
4918         (maint_obj_section_from_bfd_section): New function.
4919         (print_bfd_section_info_maybe_relocated): New function.
4920         (maintenance_info_sections): Add header comment, always use
4921         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4922
4923 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4924
4925         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4926         inner scope, add check that the objfile has psymtabs before
4927         checking psymtabs_addrmap.
4928         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4929
4930 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4931
4932         * NEWS: Announce that Ada task names are now shown at more places,
4933         and between quotes (except in info task output).
4934         * gdb/ada-tasks.c (task_to_str): New function.
4935         (display_current_task_id): Call task_to_str.
4936         (task_command_1): Likewise.
4937         (print_ada_task_info): In non-mi mode, Properly align headers and data
4938         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4939
4940 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4941
4942         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4943         prstatus.pr_lwp.pr_info instead of making it up.
4944
4945 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4946
4947         * auto-load.c (auto_load_expand_dir_vars): Update.
4948         * defs.h (gdb_datadir): Change to std::string.
4949         (python_libdir): Likewise.
4950         (relocate_gdb_directory): Change return type to std::string.
4951         * guile/guile.c (gdbscm_data_directory): Update.
4952         (initialize_scheme_side): Update.
4953         * jit.c (jit_reader_dir): Change to std::string.
4954         (jit_reader_load_command): Update.
4955         * main.c (gdb_datadir): Change to std::string.
4956         (python_libdir): Likewise.
4957         (set_gdb_data_directory): Update.
4958         (relocate_path): Change to return std::string.
4959         (relocate_gdb_directory): Change to return std::string.
4960         (relocate_gdbinit_path_maybe_in_datadir): Update.
4961         (captured_main_1): Update.
4962         * python/python.c (do_start_initialization): Update.
4963         * top.c (show_gdb_datadir): Update.
4964         * xml-syscall.c (xml_init_syscalls_info): Update.
4965         (init_syscalls_info): Update.
4966
4967 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4968
4969         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4970         out of get_init_files.
4971         (get_init_files): Update.
4972
4973 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4974
4975         * main.c (get_init_files): Change to use std::string.
4976         (captured_main_1): Update.
4977         (print_gdb_help): Update.
4978
4979 2019-09-11  Ali Tamur  <tamur@google.com>
4980
4981         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4982         implementation.
4983
4984 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4985
4986         * dbxread.c (read_dbx_symtab): Update.
4987         * dwarf2read.c (load_partial_dies): Update.
4988         * mdebugread.c (parse_partial_symbols): Update.
4989         (handle_psymbol_enumerators): Update.
4990         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4991         * psymtab.c (add_psymbol_to_bcache): Likewise.
4992         (add_psymbol_to_list): Likewise.
4993         * symtab.c (symbol_set_names): Likewise.
4994         * symtab.h (symbol_set_names): Likewise.
4995         * xcoffread.c (scan_xcoff_symtab): Update.
4996
4997 2019-09-11  Tom Tromey  <tom@tromey.com>
4998
4999         * symfile-mem.c (symbol_file_add_from_memory): Use
5000         bfd_set_filename.
5001         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5002         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5003
5004 2019-09-10  Tom Tromey  <tromey@adacore.com>
5005
5006         * dwarf-index-write.c (write_psymbols): Extend error message.
5007         (debug_names::insert): Add Ada code.
5008         (debug_names::write_psymbols): Remove Ada check.
5009         (debug_names) <m_string_obstack>: New member.
5010         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5011         (gdb_index_symbol_name_matcher::matches): Remove.
5012         (mapped_index_base::find_name_components_bounds): Add "lang"
5013         parameter.
5014         (mapped_index_base::build_name_components): Also split names
5015         according to Ada syntax.
5016         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
5017         type of "match_callback".
5018         (check_match, check_find_bounds_finds)
5019         (dw2_expand_symtabs_matching): Update.
5020         (dw2_debug_names_iterator): Add new constructor.
5021         (dw2_debug_names_map_matching_symbols): New function.
5022         (dw2_debug_names_expand_symtabs_matching): Update.
5023         (dwarf2_debug_names_functions): Use
5024         dw2_debug_names_map_matching_symbols.
5025
5026 2019-09-10  Tom Tromey  <tromey@adacore.com>
5027
5028         * dwarf2read.c (dw2_get_file_names_reader): Add the
5029         CU's file name to the results.
5030
5031 2019-09-10  Tom Tromey  <tromey@adacore.com>
5032
5033         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5034         map_matching_symbols.  Update.
5035         * dwarf2read.c (dw2_map_matching_symbols): Update.
5036         * psymtab.c (match_partial_symbol): Change type; update.
5037         (psym_map_matching_symbols): Likewise.
5038         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5039         type; update.
5040         * symfile.h (struct quick_symbol_functions)
5041         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5042         Remove "match".
5043
5044 2019-09-10  Tom Tromey  <tromey@adacore.com>
5045
5046         * psymtab.c (map_block): Remove.
5047         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5048         * symtab.c (iterate_over_symbols_terminated): New function.
5049         * symtab.c (iterate_over_symbols_terminated): Declare.
5050
5051 2019-09-10  Tom Tromey  <tromey@adacore.com>
5052
5053         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5054         * language.h (struct language_defn) <la_iterate_over_symbols>:
5055         Return bool.
5056         * symtab.c (iterate_over_symbols): Return bool.
5057         * symtab.h (iterate_over_symbols): Return bool.
5058
5059 2019-09-10  Tom Tromey  <tromey@adacore.com>
5060
5061         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5062         (add_nonlocal_symbols): Update.
5063         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5064         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5065         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5066         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5067         Change type of "callback".  Remove "data".
5068
5069
5070 2019-09-09  Ali Tamur  <tamur@google.com>
5071
5072         * dwarf2read.c (comp_unit_head): Update comment.
5073         (dwarf2_dwo_name): New function declaration.
5074         (dwarf_unit_type_name): New function declaration.
5075         (read_comp_unit_head): Add support for new compilation units,
5076         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5077         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5078         (currently named as "signature") in their header. Also clarify error
5079         messages.
5080         (lookup_dwo_id): New function. Returns the dwo id of the given
5081         compile unit.
5082         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5083         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5084         functions.
5085         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5086         (dwarf2_dwo_name): Get the dwo name if present.
5087         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5088         purposes.
5089
5090 2019-09-09  Tom Tromey  <tom@tromey.com>
5091
5092         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5093
5094 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5095
5096         * python/python.c (do_start_initialization): Make progname_copy static,
5097         to avoid a leak report.
5098
5099 2019-09-08  Tom Tromey  <tom@tromey.com>
5100
5101         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5102
5103 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5104
5105         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5106         Change type to gdb::optional<block_enum>.
5107         (dw2_symtab_iter_init): Change block_index parameter type
5108         to gdb::optional<block_enum>.
5109         (dw2_lookup_symbol): Change block_index parameter
5110         type to block_enum.c
5111         (dw2_debug_names_lookup_symbol): Likewise.
5112         * psymtab.c (psym_lookup_symbol): Likewise.
5113         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5114         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5115         Likewise.
5116
5117 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5118
5119         * defs.h (relocate_gdb_directory): Change int to bool in
5120         signature and rename flag to relocatable.
5121         * main.c (relocate_path): Likewise.
5122         (relocate_gdb_directory): Likewise.
5123
5124 2019-09-06  Alan Modra  <amodra@gmail.com>
5125
5126         * coffread.c (coff_symfile_read): Constify filename variable.
5127         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5128         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5129         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5130         * solib.c (reload_shared_libraries_1): Likewise.
5131         * symfile.c (reread_symbols): Likewise.
5132         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5133         * solib-darwin.c (darwin_bfd_open): Likewise.
5134         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5135
5136 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5139         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5140
5141 2019-09-03  Tom Tromey  <tromey@adacore.com>
5142
5143         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5144         types.
5145         (has_negatives): Unbias a range type bound.
5146         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5147         * gdbtypes.c (operator==): Handle new field.
5148         (create_range_type): Add "bias" parameter.
5149         (create_static_range_type, resolve_dynamic_range): Update.
5150         * gdbtypes.h (struct range_bounds) <bias>: New member.
5151         (create_range_type): Add bias parameter.
5152         * printcmd.c (print_scalar_formatted): Unbias range types.
5153         * value.c (unpack_long): Unbias range types.
5154         (pack_long): Bias range types.
5155
5156 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5157
5158         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5159         probe arguments.
5160
5161 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5162
5163         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5164         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5165         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5166         (compile_probe_arg): Likewise.
5167         * probe.h (get_argument_count): Likewise.
5168         * solib-svr4.c (solib_event_probe_action): Likewise.
5169         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5170
5171 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5172
5173         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5174         code to here...
5175         (svr4_create_solib_event_breakpoints): ...from here.
5176
5177 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5178
5179         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5180         suffix from warning message.
5181
5182 2019-08-30  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-winsource.h (struct tui_source_window_base)
5185         <refresh_all>: Don't declare.
5186         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5187         Remove.
5188         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5189         tui_show_locator_content.
5190         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5191         declare.
5192         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5193         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5194         declare.
5195
5196 2019-08-30  Tom Tromey  <tom@tromey.com>
5197
5198         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5199
5200 2019-08-30  Tom Tromey  <tom@tromey.com>
5201
5202         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5203         Remove unnecessary forward declarations.
5204
5205 2019-08-30  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5208         rerender.
5209         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5210         tui_show_locator_content.
5211
5212 2019-08-30  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5215         (tui_locator_window::rerender): Rewrite using body of previous
5216         tui_show_locator_content.
5217
5218 2019-08-30  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5221         set_locator_fullname>: New methods.
5222         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5223         Rename from tui_set_locator_fullname.
5224         (tui_locator_window::set_locator_info): Rename from
5225         tui_set_locator_info.  Return bool.
5226         (tui_update_locator_fullname, tui_show_frame_info): Update.
5227
5228 2019-08-30  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5231
5232 2019-08-30  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5235         call touchwin.
5236
5237 2019-08-30  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-wingeneral.c (box_win): Assume win_info and
5240         win_info->handle cannot be NULL.
5241
5242 2019-08-30  Tom Tromey  <tom@tromey.com>
5243
5244         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5245         refresh_window>: Declare.
5246         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5247         resize.
5248         (tui_data_item_window::rerender): Rename from
5249         tui_display_register.
5250         (tui_data_item_window::refresh_window): New method.
5251         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5252         no-op.
5253
5254 2019-08-30  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5257         regs_column_count, current_group>: Move later.  Now private.
5258         <get_current_group>: New method.
5259         * tui/tui-regs.c (tui_reg_command): Update.
5260         * tui/tui-layout.c (tui_set_layout): Update.
5261
5262 2019-08-30  Tom Tromey  <tom@tromey.com>
5263
5264         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5265         (tui_data_window::rerender): Don't call
5266         check_and_display_highlight_if_needed.
5267         (tui_data_window::refresh_all): Remove call to
5268         erase_data_content.
5269
5270 2019-08-30  Tom Tromey  <tom@tromey.com>
5271
5272         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5273         (tui_data_window::display_registers_from)
5274         (tui_data_window::display_reg_element_at_line)
5275         (tui_data_window::display_registers_from_line): Remove checks of
5276         "empty".
5277
5278 2019-08-30  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5281         Don't declare.
5282         * tui/tui-regs.c (tui_data_window::show_registers): Call
5283         rerender.
5284         (tui_data_window::rerender): Rename from display_all_data.
5285         (tui_data_window::rerender): Remove old implementation.
5286
5287 2019-08-30  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5290         text.
5291         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5292
5293 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5294             Sergio Durigan Junior  <sergiodj@redhat.com>
5295
5296         PR win32/24284
5297         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5298
5299 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5302         when searching for types.
5303
5304 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * f-lang.c (f_language_defn): Use f_print_typedef.
5307         * f-lang.h (f_print_typedef): Declare.
5308         * f-typeprint.c (f_print_typedef): Define.
5309
5310 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5311
5312         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5313
5314 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * cli/cli-utils.c (info_print_options_defs): Delete.
5317         (make_info_print_options_def_group): Delete.
5318         (extract_info_print_options): Delete.
5319         (info_print_command_completer): Delete.
5320         (info_print_args_help): Add extra parameter, and optionally
5321         include text about -n flag.
5322         * cli/cli-utils.h (struct info_print_options): Delete.
5323         (extract_info_print_options): Delete declaration.
5324         (info_print_command_completer): Delete declaration.
5325         (info_print_args_help): Add extra parameter, extend header
5326         comment.
5327         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5328         search_symbols.
5329         * stack.c (struct info_print_options): New type.
5330         (info_print_options_defs): New file scoped variable.
5331         (make_info_print_options_def_group): New static function.
5332         (info_print_command_completer): New static function.
5333         (info_locals_command): Update to use new local functions.
5334         (info_args_command): Likewise.
5335         (_initialize_stack): Add extra parameter to calls to
5336         info_print_args_help.
5337         * symtab.c (search_symbols): Add extra parameter, use this to
5338         possibly excluse non-debug symbols.
5339         (symtab_symbol_info): Add extra parameter, which is passed on to
5340         search_symbols.
5341         (struct info_print_options): New type.
5342         (info_print_options_defs): New file scoped variable.
5343         (make_info_print_options_def_group): New static function.
5344         (info_print_command_completer): New static function.
5345         (info_variables_command): Update to use local functions, and pass
5346         extra parameter through to symtab_symbol_info.
5347         (info_functions_command): Likewise.
5348         (info_types_command): Pass additional argument through to
5349         symtab_symbol_info.
5350         (rbreak_command): Pass extra argument to search_symbols.
5351         (_initialize_symtab): Add extra arguments for calls to
5352         info_print_args_help, and update help text for 'info variables',
5353         'whereis', and 'info functions' commands.
5354         * symtab.h (search_symbols): Add extra argument to declaration.
5355         * NEWS: Mention new flags.
5356
5357 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5358
5359         * symtab.c (lookup_static_symbol): Call the new function (and move
5360         it down to be next to lookup_global_symbol).
5361         (struct global_sym_lookup_data): Add block_enum member and rename to...
5362         (struct global_or_static_sym_lookup_data): ...this.
5363         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5364         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5365         (lookup_symbol_global_or_static_iterator_cb): ...this.
5366         (lookup_global_or_static_symbol): New function.
5367         (lookup_global_symbol): Call new function.
5368
5369 2019-08-26  Tom de Vries  <tdevries@suse.de>
5370
5371         PR c++/24852
5372         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5373         when pc_probe.prob == NULL.
5374
5375 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5376
5377         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5378         variable symbol_linkage to symbol_linkage_.
5379
5380 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5381
5382         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5383         represent whether the symbol is static, dynamic, or we don't
5384         know.
5385
5386 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5387
5388         * gdb/rx-tdep.c (rx_register_names): New.
5389         (rx_register_name): Delete.
5390         (rx_psw_type): Delete.
5391         (rx_fpsw_type): Delete.
5392         (rx_register_type): Delete.
5393         (rx_gdbarch_init): Convert target-descriptions.
5394         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5395         * gdb/features/Makefile: Add rx.xml.
5396         * gdb/features/rx.xml: New.
5397         * gdb/features/rx.c: Generated.
5398         * gdb/NEWS: Mention target description support.
5399
5400 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5401
5402         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5403         *slot_ptr.
5404
5405 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5406
5407         * configure.ac: Don't check for 'dlfcn.h' (moved to
5408         gdbsupport/common.m4).
5409         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5410         'gdbsupport/'.
5411         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5412         * compile/compile-c-support.c: Include
5413         'gdbsupport/gdb-dlfcn.h'.
5414         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5415         * gdb-dlfcn.c: Move to...
5416         * gdbsupport/gdb-dlfcn.c: ... here.
5417         * gdb-dlfcn.h: Move to...
5418         * gdbsupport/gdb-dlfcn.h: ... here.
5419
5420 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5421
5422         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5423         the offset field signed.
5424
5425 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5426
5427         * python/lib/gdb/__init__.py (_execute_file): New function.
5428         * python/python.c (python_run_simple_file): Call gdb._execute_file
5429         on Windows.
5430
5431 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5432
5433         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5434         all uses as this was never set to anything but a zero value.
5435
5436 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5437
5438         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5439
5440 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5441
5442         * tui/tui-data.h (tui_gen_win_info): Add an =default
5443         move constructor, required by some GCC versions.
5444
5445 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5446
5447         * go32-nat.c (go32_sysinfo): Add hygon_p.
5448
5449 2019-08-20  Tom Tromey  <tom@tromey.com>
5450
5451         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5452         line_from_reg_element_no, first_reg_element_no_inline,
5453         display_all_data, delete_data_content_windows,
5454         erase_data_content>: Now private.
5455
5456 2019-08-20  Tom Tromey  <tom@tromey.com>
5457
5458         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5459         (tui_unhighlight_win, tui_highlight_win)
5460         (tui_win_info::make_window): Update.
5461         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5462
5463 2019-08-20  Tom Tromey  <tom@tromey.com>
5464
5465         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5466         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5467         (MAX_PID_WIDTH): Move to tui-stack.c.
5468         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5469         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5470         (MAX_PID_WIDTH): Move from tui-data.h.
5471
5472 2019-08-20  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5475         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5476         (box_win): Update.
5477         (tui_gen_win_info::make_window): Rename from tui_make_window.
5478         (tui_win_info::make_window): New method.
5479         (tui_gen_win_info::make_visible): Update.
5480         * tui/tui-source.c (tui_source_window::set_contents): Update.
5481         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5482         (tui_data_window::display_registers_from): Update.
5483         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5484         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5485         Declare.
5486         <can_box>: Remove.
5487         <title>: Remove.
5488         (struct tui_win_info) <make_window>: Declare.
5489         <can_box>: Now virtual.
5490         <title>: New member.
5491         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5492         * tui/tui-command.c (tui_cmd_window::resize): Update.
5493
5494 2019-08-20  Tom Tromey  <tom@tromey.com>
5495
5496         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5497         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5498         (tui_data_window::check_register_values): Update.
5499
5500 2019-08-20  Tom Tromey  <tom@tromey.com>
5501
5502         * tui/tui-regs.h (struct tui_data_window): Use
5503         DISABLE_COPY_AND_ASSIGN.
5504         <regs_content>: Change type, removing unique_ptr.
5505         <tui_data_window>: Add move constructor.
5506         * tui/tui-regs.c (tui_data_window::show_registers)
5507         (tui_data_window::show_register_group)
5508         (tui_data_window::display_registers_from)
5509         (tui_data_window::display_registers_from)
5510         (tui_data_window::first_data_item_displayed)
5511         (tui_data_window::delete_data_content_windows)
5512         (tui_data_window::rerender, tui_data_window::refresh_window)
5513         (tui_data_window::check_register_values): Update.
5514
5515 2019-08-20  Tom Tromey  <tom@tromey.com>
5516
5517         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5518         show_register_group>: Declare.
5519         (tui_show_register_group): Don't declare.
5520         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5521         tui_show_registers.
5522         (tui_data_window::show_register_group): Rename from
5523         tui_show_register_group.
5524         (tui_data_window::check_register_values, tui_reg_command):
5525         Update.
5526         * tui/tui-layout.c (tui_set_layout): Update.
5527
5528 2019-08-20  Tom Tromey  <tom@tromey.com>
5529
5530         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5531         Declare.
5532         (tui_check_register_values): Don't declare.
5533         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5534         from tui_check_register_values.
5535         * tui/tui-hooks.c (tui_register_changed): Update.
5536
5537 2019-08-20  Tom Tromey  <tom@tromey.com>
5538
5539         * tui/tui-regs.c (tui_reg_layout): Move later.
5540         (tui_show_registers): Don't enable TUI mode or change layout.
5541
5542 2019-08-20  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-regs.h (struct tui_data_item_window)
5545         <~tui_data_item_window>: Remove.
5546         <content>: Now a unique_xmalloc_ptr.
5547         * tui/tui-regs.c (tui_register_format): Return a
5548         unique_xmalloc_ptr.
5549         (tui_get_register): Update.
5550         (~tui_data_item_window): Remove.
5551         (tui_data_window::display_registers_from, tui_display_register):
5552         Update.
5553         * tui/tui-io.h (tui_expand_tabs): Update.
5554         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5555         Remove "col" parameter.
5556
5557 2019-08-20  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5560         field.
5561         * tui/tui-regs.c (~tui_data_item_window): Update.
5562
5563 2019-08-20  Tom Tromey  <tom@tromey.com>
5564
5565         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5566         earlier.
5567
5568 2019-08-20  Tom Tromey  <tom@tromey.com>
5569
5570         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5571
5572 2019-08-20  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-source.h (struct tui_source_window): Update.
5575         * tui/tui-regs.c (tui_show_registers): Update.
5576         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5577         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5578         (NO_REGS_STRING): Remove defines.
5579
5580 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5581
5582         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5583         unnecessary thread walk if remote doesn't support the packet.
5584
5585 2019-08-19  Tom Tromey  <tromey@adacore.com>
5586
5587         * python/py-value.c (value_has_field): Fix indentation.
5588
5589 2019-08-19  Tom Tromey  <tromey@adacore.com>
5590
5591         * printcmd.c (do_one_display, info_display_command): Update.
5592         * block.h (contained_in): Return bool.  Add allow_nested
5593         parameter.
5594         * block.c (contained_in): Return bool.  Add allow_nested
5595         parameter.
5596
5597 2019-08-19  Tom Tromey  <tom@tromey.com>
5598
5599         * configure: Rebuild.
5600         * configure.ac: Disallow the combination of -static-libstdc++ and
5601         source highlight.
5602         * source-cache.c (get_language_name): Handle rust.
5603         (source_cache::get_source_lines): Ignore highlighting exceptions.
5604
5605 2019-08-16  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5608         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5609         (struct tui_source_window_base) <make_visible, refresh_window,
5610         resize>: Remove methods.
5611         <execution_info>: Remove field.
5612         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5613         (tui_show_source_line, tui_source_window_base)
5614         (~tui_source_window_base): Update.
5615         (tui_source_window_base::resize)
5616         (tui_source_window_base::make_visible)
5617         (tui_source_window_base::refresh_window): Remove.
5618         (tui_source_window_base::update_exec_info): Update.
5619         * tui/tui-source.c (tui_source_window::set_contents): Update.
5620         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5621
5622 2019-08-16  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5625         deprecated_query_hook.
5626
5627 2019-08-16  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5630         (tui_update_source_windows_with_line): Update.
5631         * tui/tui-source.h (struct tui_source_window)
5632         <show_symtab_source>: Declare.
5633         (tui_show_symtab_source): Don't declare.
5634         * tui/tui-source.c (tui_show_symtab_source): Rename from
5635         tui_show_symtab_source.
5636
5637 2019-08-16  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-winsource.h (struct tui_source_window_base)
5640         <set_contents>: Declare.
5641         * tui/tui-winsource.c
5642         (tui_source_window_base::update_source_window_as_is): Update.
5643         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5644         Declare.
5645         (tui_set_source_content): Don't declare.
5646         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5647         tui_set_source_content.
5648         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5649         Declare.
5650         (tui_set_disassem_content): Don't declare.
5651         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5652         tui_set_disassem_content.
5653
5654 2019-08-16  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-winsource.h (struct tui_source_window_base)
5657         <update_breakpoint_info>: Declare.
5658         (tui_update_breakpoint_info): Don't declare.
5659         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5660         (tui_update_all_breakpoint_info): Update.
5661         (tui_source_window_base::update_breakpoint_info): Rename from
5662         tui_update_breakpoint_info.
5663         (tui_source_window_base::update_exec_info): Update.
5664
5665 2019-08-16  Tom Tromey  <tom@tromey.com>
5666
5667         * tui/tui-winsource.h (struct tui_source_window_base)
5668         <update_source_window>: Declare.
5669         (tui_update_source_window): Don't declare.
5670         * tui/tui-winsource.c
5671         (tui_source_window_base::update_source_window): Rename from
5672         tui_update_source_window.
5673         (tui_source_window_base::rerender): Update.
5674         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5675         * tui/tui-disasm.c (tui_show_disassem)
5676         (tui_show_disassem_and_update_source)
5677         (tui_disasm_window::maybe_update): Update.
5678
5679 2019-08-16  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-winsource.h (struct tui_source_window_base)
5682         <update_source_window_as_is>: Declare.
5683         (tui_update_source_window_as_is): Don't declare.
5684         * tui/tui-winsource.c (tui_update_source_window): Update
5685         (tui_source_window_base::update_source_window_as_is): Rename from
5686         tui_update_source_window_as_is.
5687         (tui_source_window_base::refill): Update.
5688         * tui/tui-source.c (tui_show_symtab_source): Update.
5689         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5690         Update.
5691
5692 2019-08-16  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-winsource.h (tui_update_source_window)
5695         (tui_update_source_window_as_is): Remove "noerror" parameter.
5696         * tui/tui-winsource.c (tui_update_source_window)
5697         (tui_update_source_window_as_is): Remove "noerror" parameter.
5698         (tui_update_source_windows_with_addr)
5699         (tui_update_source_windows_with_line)
5700         (tui_source_window_base::rerender)
5701         (tui_source_window_base::refill): Update.
5702         * tui/tui-source.h (tui_set_source_content)
5703         (tui_show_symtab_source): Remove "noerror" parameter.
5704         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5705         parameter.
5706         (tui_show_symtab_source): Likewise.
5707         (tui_source_window::maybe_update): Update.
5708         * tui/tui-disasm.c (tui_show_disassem)
5709         (tui_show_disassem_and_update_source)
5710         (tui_disasm_window::do_scroll_vertical)
5711         (tui_disasm_window::maybe_update): Update.
5712
5713 2019-08-16  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui.c (tui_is_window_visible): Update.
5716         * tui/tui-wingeneral.c (tui_make_window)
5717         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5718         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5719         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5720         (tui_set_win_height_command, parse_scrolling_args): Update.
5721         * tui/tui-source.c (tui_source_window::style_changed): Update.
5722         * tui/tui-regs.c (tui_show_registers)
5723         (tui_data_window::first_data_item_displayed)
5724         (tui_data_window::delete_data_content_windows)
5725         (tui_check_register_values, tui_reg_command): Update.
5726         * tui/tui-disasm.c (tui_show_disassem): Update.
5727         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5728         method.
5729         <is_visible>: Remove field.
5730         * tui/tui-data.c (tui_next_win, tui_prev_win)
5731         (tui_delete_invisible_windows): Update.
5732
5733 2019-08-16  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-winsource.h (struct tui_source_window_base)
5736         <m_has_locator>: Remove.
5737         * tui/tui-layout.c (show_source_disasm_command, show_data)
5738         (show_source_or_disasm_and_command): Update.
5739
5740 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5741
5742         * NEWS (Other MI changes): New subsection.
5743         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5744         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5745         * arch-utils.c (default_get_pc_address_flags): New function.
5746         * arch-utils.h (default_get_pc_address_flags): New declaration.
5747         * gdbarch.sh: Add get_pc_address_flags.
5748         * gdbarch.c: Regenerate.
5749         * gdbarch.h: Likewise.
5750         * stack.c (print_pc): New function.
5751         (print_frame_info) (print_frame): Call print_pc.
5752
5753 2019-08-16  Tom de Vries  <tdevries@suse.de>
5754
5755         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5756         print_objfile_section_info.
5757
5758 2019-08-15  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5761         calling update_cmdwin_start_line.
5762         * tui/tui-winsource.h (struct tui_source_window_base)
5763         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5764         <rerender>: Declare.
5765         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5766         Call rerender.
5767         (tui_source_window_base::set_new_height): Remove.
5768         (tui_source_window_base::rerender): Rename from
5769         do_make_visible_with_new_height.
5770         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5771         resize method.
5772         (tui_win_info::make_invisible_and_set_new_height)
5773         (tui_win_info::make_visible_with_new_height): Remove.
5774         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5775         Declare.
5776         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5777         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5778         do_make_visible_with_new_height>: Don't declare.
5779         <rerender>: Declare.
5780         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5781         set_new_height.
5782         (tui_data_window::do_make_visible_with_new_height): Remove.
5783         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5784         call tui_show_locator_content.
5785         (tui_gen_win_info::resize): Call rerender.
5786         (show_source_or_disasm_and_command): Don't call
5787         tui_show_locator_content.
5788         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5789         method.
5790         (struct tui_win_info) <rerender>: Declare.
5791         <set_new_height, make_invisible_and_set_new_height,
5792         make_visible_with_new_height>: Don't declare.
5793         * tui/tui-data.c (tui_win_list::rerender): New method.
5794         * tui/tui-command.h (struct tui_cmd_window)
5795         <do_make_visible_with_new_height>: Don't declare.
5796         * tui/tui-command.c
5797         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5798
5799 2019-08-15  Tom Tromey  <tromey@adacore.com>
5800
5801         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5802         * ada-lang.c (ada_enum_name): Likewise.
5803
5804 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5805
5806         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5807         leading underscore.
5808         (GdbOutputErrorFile): Likewise.
5809         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5810         accordingly.
5811         (execute_unwinders): Rename to have a leading underscore.
5812         (auto_load_packages): Likewise.
5813         (global scope): Adjust call to auto_load_packages accordingly.
5814         (GdbSetPythonDirectory): Likewise.
5815         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5816         instead of execute_unwinders.
5817
5818 2019-08-15  Tom Tromey  <tom@tromey.com>
5819
5820         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5821         (show_data): Don't change window visibility.
5822         (tui_gen_win_info::resize): Remove special case for command
5823         window.  Use wresize, when available.
5824         (show_source_or_disasm_and_command): Don't change window
5825         visibility.
5826         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5827         <make_visible>: New method.
5828         * tui/tui-command.c (tui_cmd_window::resize): New method.
5829
5830 2019-08-15  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5833         (struct tui_source_windows): New.
5834         * tui/tui-winsource.c (tui_display_main): Update.
5835         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5836         (new_height_ok, parse_scrolling_args): Update.
5837         * tui/tui-layout.c (show_layout, show_data): Update.
5838         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5839         (tui_add_to_source_windows): Don't declare.
5840         * tui/tui-data.c (source_windows, tui_source_windows)
5841         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5842
5843 2019-08-15  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5846         Rename from reset.
5847         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5848         * tui/tui-layout.c (show_source_disasm_command, show_data):
5849         Update.
5850         (tui_gen_win_info::resize): Rename.
5851         (show_source_or_disasm_and_command): Update.
5852         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5853         reset.
5854
5855 2019-08-15  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5858         * tui/tui-interp.c (tui_interp::init): Don't call
5859         tui_initialize_static_data.
5860         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5861
5862 2019-08-15  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5865         examine tui_win_list.
5866
5867 2019-08-15  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5870         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5871         tui_clear_source_content.
5872         (tui_clear_source_content): Remove.
5873         (tui_source_window_base::do_erase_source_content): Hoist call to
5874         content.clear().
5875         * tui/tui-stack.c (tui_show_frame_info): Don't call
5876         tui_clear_source_content.
5877
5878 2019-08-15  Tom Tromey  <tom@tromey.com>
5879
5880         * tui/tui-winsource.h (struct tui_source_window_base)
5881         <do_erase_source_content>: New method.
5882         <erase_source_content>: New method.
5883         (tui_erase_source_content): Don't declare.
5884         * tui/tui-winsource.c (tui_clear_source_content): Update.
5885         (tui_source_window_base::do_erase_source_content): Rename from
5886         tui_erase_source_content.
5887         (tui_source_window_base::show_source_content): Update.
5888         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5889         * tui/tui-source.h (struct tui_source_window)
5890         <erase_source_content>: New method.
5891         * tui/tui-disasm.h (struct tui_disasm_window)
5892         <erase_source_content>: New method.
5893
5894 2019-08-15  Tom Tromey  <tom@tromey.com>
5895
5896         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5897         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5898         constructor.
5899         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5900         * tui/tui-source.c (tui_set_source_content): Update.
5901         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5902
5903 2019-08-15  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5906         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5907         tui-source.c.
5908         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5909         Declare.
5910         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5911         method.
5912         (tui_source_window::maybe_update): Update.
5913
5914 2019-08-15  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5917         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5918         tui-disasm.c.
5919         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5920         Declare.
5921         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5922         method.
5923         (tui_disasm_window::maybe_update): Update.
5924
5925 2019-08-15  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui-winsource.h (struct tui_source_window_base)
5928         <maybe_update>: Declare.
5929         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5930         method.
5931         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5932         Declare.
5933         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5934         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5935         Declare.
5936         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5937
5938 2019-08-15  Tom Tromey  <tom@tromey.com>
5939
5940         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5941
5942 2019-08-15  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-wingeneral.c: Include tui-stack.h.
5945         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5946         (struct tui_locator_window): Move from tui-data.h.
5947         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5948         (tui_initialize_static_data): Move from tui-data.c.
5949         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5950         (struct tui_locator_window): Move to tui-stack.c.
5951         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5952         (tui_initialize_static_data): Move to tui-stack.c.
5953
5954 2019-08-15  Tom Tromey  <tom@tromey.com>
5955
5956         * tui/tui-layout.c (show_source_disasm_command)
5957         (show_source_or_disasm_and_command): Use make_visible method, not
5958         tui_make_window.
5959         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5960         Remove.
5961
5962 2019-08-15  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-wingeneral.h (tui_make_window): Update.
5965         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5966         parameter.
5967         (tui_gen_win_info::make_visible): Update.
5968         * tui/tui-regs.c (tui_data_window::display_registers_from):
5969         Update.
5970         * tui/tui-layout.c (show_source_disasm_command)
5971         (show_source_or_disasm_and_command): Update.
5972         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5973         (enum tui_box): Remove.
5974         (struct tui_win_info) <can_box>: New method.
5975         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5976         method.
5977
5978 2019-08-15  Tom de Vries  <tdevries@suse.de>
5979
5980         * linux-nat-trad.c: Include gdbarch.h.
5981
5982 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5983
5984         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5985         register sizes.
5986
5987 2019-08-14  Tom Tromey  <tromey@adacore.com>
5988
5989         * darwin-nat.c: Include gdbarch.h.
5990         * darwin-nat-info.c: Include gdbarch.h.
5991
5992 2019-08-13  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5995         Remove.
5996         * tui/tui-data.c (tui_initialize_static_data): Update.
5997
5998 2019-08-13  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-winsource.h (struct tui_exec_info_window)
6001         <~tui_exec_info_window, maybe_allocate_content, get_content,
6002         m_content>: Remove.
6003         (struct tui_source_window_base) <set_exec_info_content,
6004         show_exec_info_content>: Don't declare.
6005         * tui/tui-winsource.c
6006         (tui_exec_info_window::maybe_allocate_content): Remove.
6007         (tui_source_window_base::update_exec_info): Rename from
6008         set_exec_info_content.
6009         (tui_source_window_base::show_exec_info_content)
6010         (tui_source_window_base::update_exec_info): Remove.
6011
6012 2019-08-13  Tom Tromey  <tom@tromey.com>
6013
6014         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6015         declare.
6016         * tui/tui-winsource.c (tui_update_source_window_as_is)
6017         (tui_update_source_windows_with_addr, tui_erase_source_content):
6018         Update.
6019         (tui_clear_exec_info_content): Remove.
6020
6021 2019-08-13  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6024         declare.
6025         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6026         call tui_erase_exec_info_content.
6027         (tui_clear_exec_info_content): Rename from
6028         tui_erase_exec_info_content.
6029         (tui_clear_exec_info_content): Delete.
6030
6031 2019-08-13  Tom Tromey  <tom@tromey.com>
6032
6033         * tui/tui-winsource.h (struct tui_source_window_base)
6034         <show_exec_info_content>: Declare.
6035         (tui_show_exec_info_content): Don't declare.
6036         * tui/tui-winsource.c
6037         (tui_source_window_base::show_exec_info_content): Rename from
6038         tui_show_exec_info_content.
6039         (tui_source_window_base::update_exec_info): Update.
6040
6041 2019-08-13  Tom Tromey  <tom@tromey.com>
6042
6043         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6044         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6045         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6046         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6047         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6048         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6049         ... here.
6050
6051 2019-08-13  Tom Tromey  <tom@tromey.com>
6052
6053         * tui/tui-winsource.h (struct tui_source_window_base)
6054         <update_exec_info>: Declare.
6055         (tui_update_exec_info): Don't declare.
6056         * tui/tui-winsource.c (tui_update_source_window_as_is)
6057         (tui_source_window_base::refresh_all)
6058         (tui_update_all_breakpoint_info): Update.
6059         (tui_source_window_base::update_exec_info): Rename from
6060         tui_update_exec_info.
6061         * tui/tui-stack.c (tui_show_frame_info): Update.
6062
6063 2019-08-13  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-winsource.h (struct tui_source_window_base)
6066         <set_exec_info_content>: Declare.
6067         (tui_set_exec_info_content): Don't declare.
6068         * tui/tui-winsource.c
6069         (tui_source_window_base::set_exec_info_content): Rename from
6070         tui_set_exec_info_content.
6071         (tui_update_exec_info): Update.
6072
6073 2019-08-13  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui-winsource.h (struct tui_source_window_base)
6076         <show_source_content>: Declare.
6077         (tui_show_source_content): Don't declare.
6078         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6079         (tui_source_window_base::show_source_content): Rename from
6080         tui_show_source_content.
6081         (tui_source_window_base::refresh_all): Update.
6082         * tui/tui-layout.c (show_source_disasm_command)
6083         (show_source_or_disasm_and_command): Update.
6084
6085 2019-08-13  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui-winsource.c (tui_erase_source_content)
6088         (tui_show_source_content, tui_source_window_base::refresh_all):
6089         Update.
6090         * tui/tui-wingeneral.h
6091         (tui_check_and_display_highlight_if_needed): Don't declare.
6092         * tui/tui-wingeneral.c
6093         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6094         check_and_display_highlight_if_needed.
6095         * tui/tui-win.c (tui_rehighlight_all)
6096         (tui_win_info::make_visible_with_new_height): Update.
6097         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6098         (tui_data_window::erase_data_content)
6099         (tui_data_window::display_all_data): Update.
6100         * tui/tui-data.h (struct tui_win_info)
6101         <check_and_display_highlight_if_needed>: Declare.
6102
6103 2019-08-13  Tom Tromey  <tom@tromey.com>
6104
6105         * tui/tui-win.c (tui_resize_all): Call
6106         tui_delete_invisible_windows.
6107         * tui/tui-layout.c (show_layout): Call
6108         tui_delete_invisible_windows.
6109         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6110         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6111
6112 2019-08-13  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6115         tui_add_win_to_layout.
6116
6117 2019-08-13  Tom Tromey  <tom@tromey.com>
6118
6119         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6120         * tui/tui-layout.c (tui_default_win_height): Now static.
6121
6122 2019-08-13  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6125         single switch.
6126         (show_source_disasm_command, show_source_or_disasm_and_command):
6127         Don't check current layout.
6128
6129 2019-08-13  Tom Tromey  <tom@tromey.com>
6130
6131         * tui/tui-wingeneral.c (make_all_visible): Remove.
6132         (tui_make_all_invisible): Simplify.
6133         * tui/tui-layout.c (tui_make_all_invisible): Move from
6134         tui-wingeneral.c; simplify.
6135         (show_layout): Hoist call to tui_make_all_invisible.
6136         (show_data): Don't call tui_make_all_invisible.
6137
6138 2019-08-13  Tom Tromey  <tom@tromey.com>
6139
6140         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6141         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6142
6143 2019-08-13  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6146         tui-data.c.
6147         (show_source_disasm_command, show_data)
6148         (show_source_or_disasm_and_command): Don't use
6149         tui_set_current_layout_to.
6150         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6151         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6152         tui-layout.c.
6153         (tui_set_current_layout_to): Remove.
6154
6155 2019-08-13  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-layout.c (tui_set_layout): Update.
6158         * tui/tui-data.h (struct tui_layout_def): Remove.
6159         (tui_layout_def): Don't declare.
6160         * tui/tui-data.c (layout_def): Remove.
6161         (tui_layout_def): Remove.
6162
6163 2019-08-13  Tom Tromey  <tom@tromey.com>
6164
6165         * tui/tui-winsource.h (struct tui_source_window_base)
6166         <clear_detail>: No longer "override".
6167         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6168         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6169         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6170         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6171         Remove.
6172         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6173
6174 2019-08-13  Tom Tromey  <tromey@adacore.com>
6175
6176         * tracepoint.c: Don't include readline.h or history.h.
6177
6178 2019-08-12  Tom Tromey  <tom@tromey.com>
6179
6180         * configure: Rebuild.
6181         * configure.ac: Check for readline 7.
6182         * NEWS: Mention readline 7 requirement.
6183         * README: Update.
6184
6185 2019-08-12  Tom Tromey  <tom@tromey.com>
6186
6187         * mingw-hdep.c (gdb_select): Remove readline hack.
6188
6189 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6190
6191         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6192         when the function fails.
6193
6194 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6195
6196         * s390-tdep.c (s390_type_align): New function.
6197         (s390_gdbarch_init): Set it as type_align gdbarch method.
6198
6199 2019-08-09  Tom de Vries  <tdevries@suse.de>
6200
6201         PR gdb/24591
6202         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6203         pc_low with relocation offset.
6204
6205 2019-08-07  Tom Tromey  <tromey@adacore.com>
6206
6207         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6208         (print_frame_args): Update.
6209         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6210         Update.
6211         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6212         * frame.h (struct frame_arg): Add initializers.
6213         <error>: Now a unique_xmalloc_ptr.
6214
6215 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6216
6217         * NEWS: Expand the Pointer Authentication entry.
6218         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6219         (aarch64_frame_unmask_lr): ... to this.
6220         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6221         Call aarch64_frame_unmask_lr.
6222         * frame.c (struct frame_info): Add "masked" variable.
6223         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6224         (fprint_frame): Check for masked pc.
6225         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6226         declarations.
6227         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6228         * stack.c (print_frame): Check for masked pc.
6229
6230 2019-08-06  Tom Tromey  <tom@tromey.com>
6231
6232         * stabsread.c (patch_block_stabs, read_one_struct_field)
6233         (read_enum_type): Use obstack_strndup.
6234         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6235         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6236         * dwarf2read.c (guess_full_die_structure_name)
6237         (anonymous_struct_prefix): Use obstack_strndup.
6238         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6239         * c-exp.y (yylex): Use obstack_strndup.
6240         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6241         (write_var_or_type): Use obstack_strndup.
6242
6243 2019-08-06  Tom Tromey  <tom@tromey.com>
6244
6245         * symfile.c (reread_symbols): Use obstack_strdup.
6246         * stabsread.c (read_type): Use obstack_strdup.
6247         * gdb_obstack.h (obstack_strdup): New overload.
6248         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6249         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6250         (dwarf2_canonicalize_name): Use obstack_strdup.
6251         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6252         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6253         Use obstack_strdup.
6254
6255 2019-08-06  Tom Tromey  <tom@tromey.com>
6256
6257         * gdb_obstack.h (obstack_strdup): Define.
6258         * gdb_obstack.c (obstack_strdup): Don't define.
6259
6260 2019-08-06  Tom Tromey  <tom@tromey.com>
6261
6262         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6263         obstack_strdup.
6264         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6265         obstack_strdup.
6266         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6267         * stabsread.c (common_block_start): Use obstack_strdup.
6268         * objfiles.c (set_objfile_main_name, objfile): Use
6269         obstack_strdup.
6270         * namespace.c (add_using_directive): Use obstack_strdup.
6271         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6272         * jit.c (finalize_symtab): Use obstack_strdup.
6273         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6274         (guess_partial_die_structure_name, partial_die_info::fixup)
6275         (dwarf2_name): Use obstack_strdup.
6276         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6277         obstack_strdup.
6278         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6279         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6280         obstack_strdup.
6281         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6282
6283 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6284
6285         * unittests/help-doc-selftests.c: New file.
6286         * Makefile.in: Add the new file.
6287
6288 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6291         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6292         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6293         the trailing '.' is not output, and the first character is uppercased.
6294         (print_help_for_command): Update call to print_doc_line.
6295         (print_doc_of_command): Likewise.
6296         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6297         * cli/cli-option.c (append_indented_doc): Do not append newline.
6298         (build_help_option): Append newline after first appended_indented_doc
6299         only if a second call is done.
6300         (build_help): Append 2 new lines before each option, except the first
6301         one.
6302         * compile/compile.c (_initialize_compile): Add new lines after
6303         %OPTIONS%, when not at the end of the help.
6304         Change help doc or code
6305         producing the help doc to respect the invariants.
6306         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6307         Also removed the new line after 'Options:', as all other commands
6308         do not put an empty line between 'Options:' and the first option.
6309         * printcmd.c (_initialize_printcmd): Likewise.
6310         * stack.c (_initialize_stack): Likewise.
6311         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6312         incorrectly telling COMMAND is optional.
6313         * ada-lang.c (_initialize_ada_language): Change help doc or code
6314         producing the help doc to respect the invariants.
6315         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6316         * breakpoint.c (_initialize_breakpoint): Likewise.
6317         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6318         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6319         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6320         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6321         _initialize_cli_style): Likewise.
6322         * corelow.c (core_target_info): Likewise.
6323         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6324         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6325         * filesystem.c (_initialize_filesystem): Likewise.
6326         * frame.c (_initialize_frame): Likewise.
6327         * gnu-nat.c (add_task_commands): Likewise.
6328         * infcall.c (_initialize_infcall): Likewise.
6329         * infcmd.c (_initialize_infcmd): Likewise.
6330         * interps.c (_initialize_interpreter): Likewise.
6331         * language.c (_initialize_language): Likewise.
6332         * linux-fork.c (_initialize_linux_fork): Likewise.
6333         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6334         * maint.c (_initialize_maint_cmds): Likewise.
6335         * memattr.c (_initialize_mem): Likewise.
6336         * printcmd.c (_initialize_printcmd): Likewise.
6337         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6338         _RegEx): Likewise.
6339         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6340         * record-btrace.c (_initialize_record_btrace): Likewise.
6341         * record-full.c (_initialize_record_full): Likewise.
6342         * record.c (_initialize_record): Likewise.
6343         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6344         * regcache.c (_initialize_regcache): Likewise.
6345         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6346         _initialize_remote): Likewise.
6347         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6348         * serial.c (_initialize_serial): Likewise.
6349         * skip.c (_initialize_step_skip): Likewise.
6350         * source.c (_initialize_source): Likewise.
6351         * stack.c (_initialize_stack): Likewise.
6352         * symfile.c (_initialize_symfile): Likewise.
6353         * symtab.c (_initialize_symtab): Likewise.
6354         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6355         * top.c (init_main): Likewise.
6356         * tracefile-tfile.c (tfile_target_info): Likewise.
6357         * tracepoint.c (_initialize_tracepoint): Likewise.
6358         * tui/tui-win.c (_initialize_tui_win): Likewise.
6359         * utils.c (add_internal_problem_command): Likewise.
6360         * valprint.c (value_print_option_defs): Likewise.
6361
6362 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6363
6364         PR build/24886
6365         * configure.ac: Drop enable-libmcheck support.
6366         * configure, config.in: Rebuild.
6367         * libmcheck.m4: Remove.
6368         * acinclude.m4: Don't include it.
6369         * Makefile.in: Don't distribute it.
6370         * top.c (print_gdb_configuration): Don't mention it.
6371
6372 2019-08-06  Tom Tromey  <tom@tromey.com>
6373
6374         * utils.c (set_output_style): Sometimes pass stream to
6375         emit_style_escape.
6376         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6377         * record-btrace.c (btrace_insn_history): Update.
6378         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6379         method.
6380         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6381         Update initializers.
6382         <m_uiout>: New field.
6383         <m_di>: Move lower.
6384         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6385         Remove "uiout" parameter.
6386         (dump_insns): Update.
6387         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6388         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6389
6390 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6391
6392         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6393         (error_in_psymtab_expansion): Likewise.
6394         (lookup_symbol_via_quick_fns): Likewise.
6395         (basic_lookup_transparent_type_quick): Likewise.
6396         (basic_lookup_transparent_type_1): Likewise.
6397
6398 2019-08-06  Tom Tromey  <tromey@adacore.com>
6399
6400         * source.c (last_source_error): Now bool.
6401         (print_source_lines_base): Make "noprint" bool.  Only open
6402         source file when last_source_visited changes.
6403
6404 2019-08-06  Tom Tromey  <tromey@adacore.com>
6405
6406         * annotate.c (annotate_source_line): Use g_source_cache.
6407         * source-cache.c (source_cache::get_plain_source_lines): Change
6408         parameters.  Populate m_offset_cache.
6409         (source_cache::ensure): New method.
6410         (source_cache::get_line_charpos): New method.
6411         (extract_lines): Move lower.  Change parameters.
6412         (source_cache::get_source_lines): Move lower.
6413         * source-cache.h (class source_cache): Update comment.
6414         <get_line_charpos>: New method.
6415         <get_source_lines>: Update comment.
6416         <clear>: Clear m_offset_cache.
6417         <get_plain_source_lines>: Change parameters.
6418         <ensure>: New method
6419         <m_offset_cache>: New member.
6420         * source.c (forget_cached_source_info_for_objfile): Update.
6421         (info_source_command): Use g_source_cache.
6422         (find_source_lines, open_source_file_with_line_charpos): Remove.
6423         (print_source_lines_base, search_command_helper): Use g_source_cache.
6424         * source.h (open_source_file_with_line_charpos): Don't declare.
6425         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6426         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6427         Use g_source_cache.
6428
6429 2019-08-06  Tom Tromey  <tromey@adacore.com>
6430
6431         * source-cache.c (source_cache::get_plain_source_lines):
6432         Remove "first_line" and "last_line" parameters.
6433         (source_cache::get_source_lines): Cache plain text.
6434         * source-cache.h (class source_cache)
6435         <get_plain_source_lines>: Update.
6436
6437 2019-08-06  Tom Tromey  <tromey@adacore.com>
6438
6439         * source-cache.c (extract_lines): No longer a method.
6440         Changed type of parameter.  Include final newline.
6441         (selftests::extract_lines_test): New function.
6442         (_initialize_source_cache): Likewise.
6443         * source-cache.h (class source_cache)
6444         <extract_lines>: Don't declare.
6445
6446 2019-08-06  Tom Tromey  <tromey@adacore.com>
6447
6448         * breakpoint.c (init_breakpoint_sal): Update.
6449         (breakpoint): Update.
6450         * breakpoint.h (struct breakpoint) <filter>: Now a
6451         unique_xmalloc_ptr.
6452
6453 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6454
6455         * NEWS: Mention dictionary access on blocks.
6456         * python/py-block.c (blpy_getitem): New function.
6457         (block_object_as_mapping): New struct.
6458         (block_object_type): Use new struct for tp_as_mapping field.
6459
6460 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6461
6462         * objfiles.h (objfile): Add a comment describing partial symbols.
6463
6464 2019-08-05  Tom Tromey  <tromey@adacore.com>
6465
6466         * compile/compile.c (_initialize_compile): Use _(), not N_().
6467         * thread.c (_initialize_thread): Use _(), not N_().
6468         * stack.c (_initialize_stack): Use _(), not N_().
6469         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6470
6471 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6472
6473         * dwarf2read.c (struct dw2_symtab_iterator):
6474         <want_specific_block>: Remove.
6475         <block_index>: Change type to gdb::optional.
6476         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6477         change type of BLOCK_INDEX parameter to gdb::optional.
6478         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6479         (dw2_lookup_symbol): Don't pass argument for
6480         WANT_SPECIFIC_BLOCK.
6481         (dw2_expand_symtabs_for_function): Don't pass argument for
6482         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6483         (class dw2_debug_names_iterator)
6484         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6485         parameter, change BLOCK_INDEX type to gdb::optional.
6486         <m_want_specific_block>: Remove.
6487         <m_block_index>: Change type to gdb::optional.
6488         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6489         gdb::optional.  Re-write in function of gdb::optional.
6490         (dw2_debug_names_lookup_symbol): Don't pass argument for
6491         WANT_SPECIFIC_BLOCK.
6492         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6493         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6494         BLOCK_INDEX.
6495
6496 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6497
6498         * NEWS: Mention changes to "info sources" command.
6499
6500 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6501
6502         * symtab.c (filename_partial_match_opts): New struct type.
6503         (struct output_source_filename_data): New members
6504         regexp, c_regexp, partial_match.
6505         (output_source_filename): Use new members to decide to print file.
6506         (info_sources_option_defs): New variable.
6507         (make_info_sources_options_def_group, print_info_sources_header,
6508         info_sources_command_completer):
6509         New functions.
6510         (info_sources_command): Read new optional arguments.
6511         (_initialize_symtab): Update info sources help.
6512
6513 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6514
6515         * ada-lang.c (exception_support_info_v0): Renamed from...
6516         (default_exception_support_info): ... this.  Create new
6517         definition for v1.
6518         (ada_has_this_exception_support): Look up catch_handlers_sym.
6519         (ada_exception_support_info_sniffer): Try v0 after default.
6520
6521 2019-08-01  Tom Tromey  <tromey@adacore.com>
6522
6523         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6524         gdbarch.h.
6525
6526 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6527
6528         * s12z-tdep.c: Fix include path for s12z-opc.h.
6529
6530 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6531
6532         * NEWS: Require GNU make 3.82.
6533
6534 2019-07-16  Tom Tromey  <tom@tromey.com>
6535
6536         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6537         declare.
6538
6539 2019-07-30  Tom Tromey  <tromey@adacore.com>
6540
6541         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6542
6543 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6544
6545         * printcmd.c (print_address_symbolic): Print negative offsets.
6546         (build_address_symbolic): Force signed arithmetic when computing
6547         offset.
6548
6549 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6550
6551         PR/24474: Add a function to lookup static variables.
6552         * NEWS: Mention this new function.
6553         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6554         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6555         * python/python.c (python_GdbMethods): Add new function.
6556
6557 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6558
6559         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6560         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6561         (objfpy_lookup_static_symbol): New function.
6562         (objfile_object_methods): Add new functions.
6563
6564 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6565
6566         * NEWS: Mention 'set|show print frame-info'.  Mention new
6567         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6568         backtrace argument.  Mention that python frame filtering code
6569         is now consistent with what 'backtrace' command prints.
6570
6571 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6572
6573         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6574         comments.
6575         (print_frame_info_auto, print_frame_info_source_line,
6576         print_frame_info_location, print_frame_info_source_and_location,
6577         print_frame_info_location_and_address, print_frame_info_short_location):
6578         New declarations.
6579         (struct frame_print_options): New member print_frame_info.
6580         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6581         * stack.h (get_user_print_what_frame_info): New declaration.
6582         (frame_show_address): New declaration.
6583         * stack.c (print_frame_arguments_choices): New value 'presence'.
6584         (print_frame_info_auto, print_frame_info_source_line,
6585         print_frame_info_location, print_frame_info_source_and_location,
6586         print_frame_info_location_and_address, print_frame_info_short_location,
6587         print_frame_info_choices, print_frame_info_print_what): New definitions.
6588         (print_frame_args): Only print dots for args if print frame-arguments
6589         is 'presence'.
6590         (frame_print_option_defs): New element for "frame-info".
6591         (get_user_print_what_frame_info): New function.
6592         (frame_show_address): Make non static.  Move comment to stack.h.
6593         (print_frame_info_to_print_what): New function.
6594         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6595         to decide what to print.
6596         (backtrace_command_1): Handle the new print_frame_arguments_presence
6597         value.
6598         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6599         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6600         (py_print_frame): In non-mi mode, use LOCATION as default for
6601         print_what, similarly to frame information printed directly by
6602         backtrace command. Handle frame-info user option in non MI mode.
6603
6604 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6605
6606         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6607         Add case for debugging 32-bit target on 64-bit host.  Revise
6608         comment.
6609
6610 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6611
6612         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6613         instead of find_function_entry_range_from_pc.
6614
6615 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6616
6617         * stack.c (find_frame_funname): Remove code which preferred
6618         minsym over symtab sym in "certain pathological cases".
6619
6620         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6621         parameter.  Change type of "do_demangle" to bool.
6622         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6623         Pass suitable "prefer_sym_over_minsym" flag to
6624         build_address_symbolic().  Don't output "+" for negative offsets.
6625         * printcmd.c (print_address_symbolic): Update invocation of
6626         build_address_symbolic to include a "prefer_sym_over_minsym"
6627         flag.
6628         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6629         Restrict cases in which use of minimal symbol is preferred to that
6630         of a found symbol.  Update comments.
6631
6632         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6633         for entry pc when entry pc is out of range for that FDE.
6634
6635 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6636
6637         PR gdb/24839:
6638         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6639         type.
6640
6641 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6642
6643         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6644         this function's Python signature.
6645
6646
6647 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6648
6649         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6650         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6651         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6652         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6653         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6654
6655
6656 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6657
6658         * h8300-tdep.c (h8300_register_name_common): New.
6659         h8300_register_name): Use h8300_register_name_common.
6660         (h8300s_register_name): Likewise.
6661         (h8300sx_register_name): Likewise.
6662         (h8300h_register_nam): New.
6663         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6664
6665
6666 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6667
6668         * arm-tdep.c (arm_skip_cmse_entry): New function.
6669         (arm_is_sgstubs_section): New function.
6670         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6671
6672 2019-07-22  Tom Tromey  <tom@tromey.com>
6673
6674         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6675         Don't self-assign.
6676
6677 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6680         type_print.
6681
6682 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6685         so that GDB doesn't match any msymbols when searching in the
6686         TYPES_DOMAIN.
6687         (print_symbol_info): Print using typedef_print or type_print based
6688         on the type of the symbol.  Add updated FIXME comment moved from...
6689         (_initialize_symtab): ... move and update FIXME comment to above.
6690
6691 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6692
6693         * NEWS: Mention adding -q option to "info types".
6694         * symtab.c (struct info_types_options): New struct.
6695         (info_types_options_defs): New variable.
6696         (make_info_types_options_def_group): New function.
6697         (info_types_command): Use gdb::option framework to parse options.
6698         (info_types_command_completer): New function.
6699         (_initialize_symtab): Extend the help text on "info types" and
6700         register command completer.
6701
6702 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6703
6704         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6705         (lookup_symbol_in_objfile): Change int to block_enum and add a
6706         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6707
6708 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6709
6710         * MAINTAINERS (Write After Approval): Add self.
6711
6712 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6715         instruction to the dummy code region.
6716
6717 2019-07-19  Tom Tromey  <tromey@adacore.com>
6718
6719         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6720         (ARGSUSED, PARAMS, __func__): Remove rules.
6721
6722 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6723
6724         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6725         * features/arm/arm-with-iwmmxt.c: Remove.
6726         * features/arm/arm-with-iwmmxt.xml: Remove.
6727         * features/arm/arm-with-m-fpa-layout.c: Remove.
6728         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6729         * features/arm/arm-with-m-vfp-d16.c: Remove.
6730         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6731         * features/arm/arm-with-m.c: Remove.
6732         * features/arm/arm-with-m.xml: Remove.
6733         * features/arm/arm-with-neon.c: Remove.
6734         * features/arm/arm-with-neon.xml: Remove.
6735         * features/arm/arm-with-vfpv2.c: Remove.
6736         * features/arm/arm-with-vfpv2.xml: Remove.
6737         * features/arm/arm-with-vfpv3.c: Remove.
6738         * features/arm/arm-with-vfpv3.xml: Remove.
6739
6740 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6741
6742         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6743
6744 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6745
6746         * arch/aarch32.c (aarch32_create_target_description): Create
6747         target descriptions using features.
6748         * arch/arm.c (arm_create_target_description)
6749         (arm_create_mprofile_target_description): Likewise.
6750         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6751
6752 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6753
6754         * Makefile.in: Add new files.
6755         * aarch32-tdep.c: New file.
6756         * aarch32-tdep.h: New file.
6757         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6758         Call aarch32_read_description.
6759         * arch/aarch32.c: New file.
6760         * arch/aarch32.h: New file.
6761         * arch/arm.c (arm_create_target_description)
6762         (arm_create_mprofile_target_description): New function.
6763         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6764         (arm_create_target_description)
6765         (arm_create_mprofile_target_description): New declaration.
6766         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6767         read_description functions.
6768         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6769         Likewise.
6770         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6771         * arm-tdep.c (tdesc_arm_list): New variable.
6772         (arm_register_g_packet_guesses): Call create description functions.
6773         (arm_read_description) (arm_read_mprofile_description): New
6774         function.
6775         * arm-tdep.h (arm_read_description)
6776         (arm_read_mprofile_description): Add declaration.
6777         * configure.tgt: Add new files.
6778
6779 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6780
6781         * top.c (new_ui_command): Open specified terminal just once.
6782
6783 2019-07-18  Tom Tromey  <tromey@adacore.com>
6784
6785         * symtab.c (main_name): Constify return type.
6786         * symfile.c (set_initial_language): Update.
6787         * symtab.h (main_name): Constify return type.
6788
6789 2019-07-17  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-winsource.c (tui_update_source_window)
6792         (tui_update_source_window_as_is)
6793         (tui_update_source_windows_with_line): Remove return.
6794         * tui/tui-disasm.c (tui_show_disassem)
6795         (tui_show_disassem_and_update_source): Remove return.
6796         * tui/tui.c (tui_reset): Remove return.
6797         * tui/tui-wingeneral.c
6798         (tui_check_and_display_highlight_if_needed): Remove return.
6799
6800 2019-07-17  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6803
6804 2019-07-17  Tom Tromey  <tom@tromey.com>
6805
6806         * tui/tui-winsource.h (struct tui_exec_info_window)
6807         (struct tui_source_window_base): Move from tui-data.h.
6808         * tui/tui-winsource.c: Move many method definitions from
6809         elsewhere.  Remove "structuring" comments.
6810         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6811         (tui_source_window_base::refresh_window): Move to
6812         tui-winsource.c.
6813         * tui/tui-win.c (tui_source_window_base::refresh_all)
6814         (tui_source_window_base::update_tab_width)
6815         (tui_source_window_base::set_new_height)
6816         (tui_source_window_base::do_make_visible_with_new_height): Move to
6817         tui-winsource.c.
6818         * tui/tui-source.h: Update.
6819         * tui/tui-source.c (tui_source_window_base::reset): Move to
6820         tui-winsource.c.
6821         * tui/tui-disasm.h: Update.
6822         * tui/tui-data.h (struct tui_exec_info_window): Move to
6823         tui-winsource.h.
6824         (struct tui_source_window_base): Likewise.
6825         * tui/tui-data.c (tui_source_window_base::clear_detail)
6826         (tui_source_window_base, ~tui_source_window_base): Move to
6827         tui-winsource.c.
6828
6829 2019-07-17  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui-win.c (tui_resize_all)
6832         (tui_source_window_base::update_tab_width)
6833         (tui_adjust_win_heights): Update.
6834         (tui_win_info::make_invisible_and_set_new_height): Rename from
6835         make_invisible_and_set_new_height.
6836         * tui/tui-data.h (struct tui_win_info)
6837         <make_invisible_and_set_new_height>: New method.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui.c: Update.
6842         * tui/tui-source.h (struct tui_source_window): Move from
6843         tui-data.h.
6844         * tui/tui-layout.c: Update.
6845         * tui/tui-disasm.c: Update.
6846         * tui/tui-data.h (struct tui_source_window): Move to
6847         tui-source.h.
6848
6849 2019-07-17  Tom Tromey  <tom@tromey.com>
6850
6851         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6852         tui-data.h.
6853         * tui/tui-data.h (struct tui_disasm_window): Move to
6854         tui-disasm.h.
6855
6856 2019-07-17  Tom Tromey  <tom@tromey.com>
6857
6858         * tui/tui-regs.h (struct tui_data_item_window): Move from
6859         tui-data.h.
6860         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6861         * tui/tui-data.h (struct tui_data_item_window): Move to
6862         tui-regs.h.
6863         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6864
6865 2019-07-17  Tom Tromey  <tom@tromey.com>
6866
6867         * tui/tui.c: Update.
6868         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6869         (tui_cmd_window::max_height): Move to tui-command.c.
6870         * tui/tui-layout.c: Update.
6871         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6872         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6873         tui-command.c.
6874         * tui/tui-command.h (struct tui_cmd_window): Move from
6875         tui-data.h.
6876         * tui/tui-command.c: Remove "structuring" comments.
6877         (tui_cmd_window::clear_detail)
6878         (tui_cmd_window::do_make_visible_with_new_height)
6879         (tui_cmd_window::max_height): Move from elsewhere.
6880
6881 2019-07-17  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6884         Now static.
6885         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6886         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6887
6888 2019-07-17  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui.c: Update.
6891         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6892         tui-regs.c.
6893         * tui/tui-windata.h: Remove file.
6894         * tui/tui-windata.c: Remove file.
6895         * tui/tui-win.c (tui_data_window::set_new_height)
6896         (tui_data_window::do_make_visible_with_new_height): Move to
6897         tui-regs.c.
6898         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6899         * tui/tui-regs.c: Remove "structuring" comments.
6900         (tui_data_window::first_data_item_displayed)
6901         (tui_data_window::delete_data_content_windows)
6902         (tui_data_window::erase_data_content)
6903         (tui_data_window::display_all_data)
6904         (tui_data_window::refresh_all)
6905         (tui_data_window::do_scroll_vertical)
6906         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6907         (tui_data_window::do_make_visible_with_new_height)
6908         (tui_data_window::refresh_window): Move from elsewhere.
6909         (_initialize_tui_regs): Move to end of file.
6910         * tui/tui-layout.c: Update.
6911         * tui/tui-hooks.c: Update.
6912         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6913         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6914         tui-regs.c.
6915         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6916
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6920         seen.
6921
6922 2019-07-17  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-win.c (tui_source_window_base::set_new_height)
6925         (tui_source_window_base::do_make_visible_with_new_height): Use
6926         m_has_locator field directly.
6927         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6928         method.
6929         (struct tui_source_window_base) <has_locator>: Likewise.
6930
6931 2019-07-17  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6934         Don't declare.
6935         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6936         Remove.
6937         * tui/tui-win.c (tui_source_window_base::set_new_height)
6938         (tui_source_window_base::set_new_height)
6939         (make_invisible_and_set_new_height)
6940         (tui_source_window_base::do_make_visible_with_new_height)
6941         (tui_source_window_base::do_make_visible_with_new_height):
6942         Update.
6943         * tui/tui-layout.c (show_source_disasm_command, show_data)
6944         (show_source_or_disasm_and_command): Update.
6945         * tui/tui-layout.c (show_layout): Update.
6946
6947 2019-07-17  Tom Tromey  <tom@tromey.com>
6948
6949         * tui/tui-layout.c (make_data_window): Remove.
6950         (show_data): Unify creation and re-initialization cases.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-layout.c (make_source_window, make_disasm_window):
6955         Remove.
6956         (show_data): Unify creation and re-initialization cases.
6957
6958 2019-07-17  Tom Tromey  <tom@tromey.com>
6959
6960         * tui/tui-layout.c (make_command_window): Remove.
6961         (show_source_disasm_command, show_source_or_disasm_and_command):
6962         Unify creation and re-initialization cases.
6963
6964 2019-07-17  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6967         creation and re-initialization cases.
6968
6969 2019-07-17  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-regs.c (tui_get_register): Return void.
6972
6973 2019-07-17  Tom Tromey  <tom@tromey.com>
6974
6975         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6976         Simplify.
6977
6978 2019-07-17  Tom Tromey  <tom@tromey.com>
6979
6980         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6981         resetting.
6982
6983 2019-07-17  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6986         * tui/tui-regs.c (tui_reg_layout): New function.
6987         (tui_show_registers, tui_reg_command): Use it.
6988         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6989         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6990         parameters.
6991         (tui_layout_command): Remove.
6992
6993 2019-07-17  Tom Tromey  <tom@tromey.com>
6994
6995         * tui/tui-layout.h (tui/tui-layout): Return void.
6996         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6997
6998 2019-07-17  Tom Tromey  <tom@tromey.com>
6999
7000         * tui/tui-layout.c (show_source_disasm_command, show_data):
7001         Update.
7002         (reset_locator): Remove.
7003         (show_source_or_disasm_and_command): Update.
7004
7005 2019-07-17  Tom Tromey  <tom@tromey.com>
7006
7007         * tui/tui-source.c (tui_source_window_base::reset): Remove
7008         win_type parameter.
7009         * tui/tui-layout.c (make_command_window, make_source_window)
7010         (make_disasm_window, make_data_window)
7011         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7012         (reset_locator, show_source_or_disasm_and_command): Update.
7013         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7014         win_type parameter.
7015         (struct tui_source_window_base) <reset>: Likewise.
7016
7017 2019-07-17  Tom Tromey  <tom@tromey.com>
7018
7019         * tui/tui-layout.c (show_source_disasm_command): Use
7020         reset_locator.
7021         (reset_locator): New function.
7022         (init_and_make_win): Remove.
7023         (show_source_or_disasm_and_command): Use reset_locator.
7024
7025 2019-07-17  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7028         condition.
7029         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7030         Remove condition.
7031         * tui/tui-source.c (tui_source_window_base::reset): New method.
7032         * tui/tui-layout.c (make_command_window): Don't call
7033         init_and_make_win.
7034         (make_source_window, make_disasm_window): Don't call
7035         make_source_or_disasm_window.
7036         (make_data_window): Don't call init_and_make_win.  Change calling
7037         convention.
7038         (show_source_disasm_command, show_data): Simplify.
7039         (make_source_or_disasm_window): Remove.
7040         (show_source_or_disasm_and_command): Simplify.
7041         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7042         (struct tui_source_window_base) <reset>: Likewise.
7043         <execution_info>: Remove initializer.
7044         * tui/tui-data.c (tui_source_window_base): Initialize
7045         execution_info.
7046
7047 2019-07-17  Tom Tromey  <tom@tromey.com>
7048
7049         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7050         variable.
7051
7052 2019-07-17  Tom Tromey  <tom@tromey.com>
7053
7054         * tui/tui.c (tui_rl_other_window): Update.
7055         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7056         superclass method first.  Always iterate over regs_content.
7057         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7058         method.
7059         * tui/tui-win.c (tui_set_focus_command): Update.
7060
7061 2019-07-17  Tom Tromey  <tom@tromey.com>
7062
7063         * tui/tui-win.c (tui_set_focus_command): Rename from
7064         tui_set_focus.  Call tui_enable.
7065         (tui_set_focus_command): Remove.
7066
7067 2019-07-17  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7070         refresh_window.
7071         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7072         touchwin.
7073         (tui_data_window::refresh_window): Call refresh_window on data
7074         items.  Always call superclass refresh_window.
7075         (tui_win_info::refresh): Remove.
7076         (tui_source_window_base::refresh_window): Update.
7077         (tui_refresh_all): Update.
7078         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7079         refresh_window.
7080         (show_source_or_disasm_and_command): Likewise.
7081         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7082         (struct tui_source_window_base) <refresh>: Likewise.
7083
7084 2019-07-17  Tom Tromey  <tom@tromey.com>
7085
7086         * tui/tui-winsource.c (tui_clear_source_content)
7087         (tui_show_source_content): Update.
7088         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7089         whether content is empty.
7090         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7091         Remove.
7092
7093 2019-07-17  Tom Tromey  <tom@tromey.com>
7094
7095         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7096         window's contents.
7097         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7098         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7099
7100 2019-07-17  Tom Tromey  <tom@tromey.com>
7101
7102         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7103         (struct tui_data_item_window): Update.
7104
7105 2019-07-17  Tom Tromey  <tom@tromey.com>
7106
7107         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7108         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7109         defines.
7110
7111 2019-07-17  Tom Tromey  <tom@tromey.com>
7112
7113         * tui/tui-winsource.h (tui_erase_source_content)
7114         (tui_clear_source_content): Remove "display_prompt" parameter.
7115         * tui/tui-winsource.c (tui_update_source_window_as_is)
7116         (tui_update_source_windows_with_addr): Update.
7117         (tui_clear_source_content): Remove "display_prompt" parameter.
7118         (tui_erase_source_content): Likewise.  Simplify.
7119         (tui_show_source_content): Update.
7120         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7121         * tui/tui-stack.c (tui_show_frame_info): Update.
7122         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7123         Remove defines.
7124
7125 2019-07-17  Tom Tromey  <tom@tromey.com>
7126
7127         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7128         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7129         parameter.
7130         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7131         parameter.
7132
7133 2019-07-17  Tom Tromey  <tom@tromey.com>
7134
7135         * tui/tui-winsource.c (tui_clear_source_content)
7136         (tui_show_source_content, tui_show_exec_info_content)
7137         (tui_clear_exec_info_content): Update.
7138         * tui/tui-stack.c (tui_show_locator_content): Update.
7139         (tui_show_frame_info): Update.
7140         * tui/tui-source.h (tui_source_window): Don't declare.
7141         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7142         from tui_source_is_displayed.
7143         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7144         Remove field.
7145         (struct tui_source_window_base) <content_in_use>: New field.  Now
7146         bool.
7147         (struct tui_source_window) <showing_source_p>: New method.
7148         (TUI_SRC_WIN): Change cast.
7149         * tui/tui-data.c (tui_initialize_static_data): Update.
7150
7151 2019-07-17  Tom Tromey  <tom@tromey.com>
7152
7153         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7154         location_matches_p.
7155         * tui/tui-source.c (tui_source_window::location_matches_p): New
7156         method.
7157         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7158         method.
7159         * tui/tui-data.h (struct tui_source_window_base)
7160         <location_matches_p>: New method.
7161         (struct tui_source_window, struct tui_disasm_window)
7162         <location_matches_p>: Likewise.
7163
7164 2019-07-17  Tom Tromey  <tom@tromey.com>
7165
7166         * tui/tui-win.c (tui_set_win_height_command): Rename from
7167         tui_set_win_height.
7168         (tui_set_win_height_command): Remove.
7169
7170 2019-07-17  Tom Tromey  <tom@tromey.com>
7171
7172         * tui/tui-source.c (tui_source_window): New constructor.  Add
7173         observer.
7174         (~tui_source_window): New destructor.
7175         (tui_source_window::style_changed): New method.
7176         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7177         (tui_attach_detach_observers): Update.
7178         * tui/tui-data.h (struct tui_source_window): Make constructor not
7179         inline.  Add destructor.
7180         (struct tui_source_window) <style_changed>: New method.
7181         <m_observable>: New member.
7182
7183 2019-07-17  Tom Tromey  <tom@tromey.com>
7184
7185         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7186         * tui/tui-win.c (tui_resize_all): Fix typo.
7187
7188 2019-07-17  Tom Tromey  <tom@tromey.com>
7189
7190         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7191         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7192         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7193         * tui/tui-win.c (window_name_completer): Use foreach.
7194         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7195         (update_tab_width): Likewise.
7196         * tui/tui-layout.c (show_layout): Update.
7197         * tui/tui-data.h (class tui_window_iterator): New.
7198         (struct all_tui_windows): New.
7199         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7200
7201 2019-07-17  Tom Tromey  <tom@tromey.com>
7202
7203         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7204         parameter.  Don't reference globals.
7205         (tui_reg_command): Update.
7206
7207 2019-07-17  Tom Tromey  <tom@tromey.com>
7208
7209         * tui/tui-regs.c (tui_show_registers): Simplify.
7210
7211 2019-07-17  Tom Tromey  <tom@tromey.com>
7212
7213         * tui/tui-regs.c (tui_show_registers): Update.
7214         (tui_show_register_group): Add win_info parameter.
7215
7216 2019-07-17  Tom Tromey  <tom@tromey.com>
7217
7218         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7219         Rename from tui_display_reg_element_at_line.
7220         (tui_data_window::display_registers_from_line): Update.
7221         * tui/tui-data.h (struct tui_data_window)
7222         <display_reg_element_at_line>: New method.
7223
7224 2019-07-17  Tom Tromey  <tom@tromey.com>
7225
7226         * tui/tui-regs.h (tui_display_registers_from)
7227         (tui_display_registers_from_line): Don't declare.
7228         * tui/tui-windata.c (tui_data_window::display_all_data)
7229         (tui_data_window::refresh_all)
7230         (tui_data_window::do_scroll_vertical): Update.
7231         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7232         from tui_display_registers_from.
7233         (tui_display_reg_element_at_line): Update.
7234         (tui_data_window::display_registers_from_line): Rename from
7235         tui_display_registers_from_line.
7236         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7237         display_registers_from_line>: New methods.
7238
7239 2019-07-17  Tom Tromey  <tom@tromey.com>
7240
7241         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7242         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7243         from tui_erase_data_content.
7244         (tui_data_window::display_all_data)
7245         (tui_data_window::refresh_all)
7246         (tui_data_window::do_scroll_vertical): Update.
7247         * tui/tui-regs.c (tui_show_registers): Update.
7248         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7249         New method.
7250
7251 2019-07-17  Tom Tromey  <tom@tromey.com>
7252
7253         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7254         declare.
7255         * tui/tui-windata.c
7256         (tui_data_window::delete_data_content_windows): Rename from
7257         tui_delete_data_content_windows.
7258         (tui_data_window::display_all_data)
7259         (tui_data_window::do_scroll_vertical): Update.
7260         * tui/tui-data.h (struct tui_data_window)
7261         <delete_data_content_windows>: New method.
7262
7263 2019-07-17  Tom Tromey  <tom@tromey.com>
7264
7265         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7266         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7267
7268 2019-07-17  Tom Tromey  <tom@tromey.com>
7269
7270         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7271         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7272         from tui_display_all_data.
7273         * tui/tui-win.c
7274         (tui_data_window::do_make_visible_with_new_height): Update.
7275         * tui/tui-regs.c (tui_show_registers): Update.
7276         * tui/tui-layout.c (tui_set_layout): Update.
7277         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7278         method.
7279
7280 2019-07-17  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7283         * tui/tui-windata.c (tui_display_data_from): Remove.
7284         (tui_data_window::refresh_all): Update.
7285
7286 2019-07-17  Tom Tromey  <tom@tromey.com>
7287
7288         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7289         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7290         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7291         tui_display_registers_from_line.
7292         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7293         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7294         "force_display" parameter.
7295
7296 2019-07-17  Tom Tromey  <tom@tromey.com>
7297
7298         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7299         declare.
7300         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7301         Rename from tui_first_reg_element_no_inline.
7302         (tui_display_reg_element_at_line)
7303         (tui_display_registers_from_line): Update.
7304         * tui/tui-data.h (struct tui_data_window)
7305         <first_reg_element_no_inline>: New method.
7306
7307 2019-07-17  Tom Tromey  <tom@tromey.com>
7308
7309         * tui/tui-windata.c (tui_display_data_from)
7310         (tui_data_window::do_scroll_vertical): Update.
7311         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7312         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7313         Rename from tui_line_from_reg_element_no.
7314         (tui_display_registers_from_line): Update.
7315         * tui/tui-data.h (struct tui_data_window)
7316         <line_from_reg_element_no>: New method.
7317
7318 2019-07-17  Tom Tromey  <tom@tromey.com>
7319
7320         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7321         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7322         tui_last_regs_line_no.
7323         (tui_display_reg_element_at_line)
7324         (tui_display_registers_from_line): Update.
7325         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7326         method.
7327
7328 2019-07-17  Tom Tromey  <tom@tromey.com>
7329
7330         PR tui/24722:
7331         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7332         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7333         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7334         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7335         (tui_update_breakpoint_info): Likewise.
7336         * tui/tui-hooks.c (tui_event_create_breakpoint)
7337         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7338         Update.
7339
7340 2019-07-17  Tom Tromey  <tom@tromey.com>
7341
7342         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7343
7344 2019-07-17  Tom Tromey  <tom@tromey.com>
7345
7346         * tui/tui-winsource.c (tui_update_source_window_as_is)
7347         (tui_update_source_windows_with_addr): Update.
7348         * tui/tui-source.h (tui_set_source_content)
7349         (tui_show_symtab_source): Add "win_info" parameter.
7350         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7351         parameter.
7352         (tui_show_symtab_source): Likewise.
7353
7354 2019-07-17  Tom Tromey  <tom@tromey.com>
7355
7356         * tui/tui-wingeneral.c
7357         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7358
7359 2019-07-17  Tom Tromey  <tom@tromey.com>
7360
7361         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7362         (struct tui_cmd_window) <can_scroll>: New method.
7363         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7364         method.
7365
7366 2019-07-17  Tom Tromey  <tromey@adacore.com>
7367
7368         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7369         do_field_signed>: Rename.  Change type of "value".
7370         * ui-out.c (ui_out::field_signed): Rename from field_int.
7371         Change type of "value".
7372         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7373         type of "value".
7374         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7375         do_field_int.  Change type of "value".
7376         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7377         do_field_int.  Change type of "value".
7378         * tracepoint.c (trace_status_mi, tfind_1)
7379         (print_one_static_tracepoint_marker): Update.
7380         * thread.c (print_thread_info_1, print_selected_thread_frame):
7381         Update.
7382         * stack.c (print_frame, print_frame_info): Update.
7383         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7384         Update.
7385         * source.c (print_source_lines_base): Update.
7386         * skip.c (info_skip_command): Update.
7387         * record-btrace.c (btrace_ui_out_decode_error)
7388         (btrace_call_history_src_line): Update.
7389         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7390         Update.
7391         * progspace.c (print_program_space): Update.
7392         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7393         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7394         do_field_int.  Change type of "value".
7395         * mi/mi-out.c (mi_ui_out::do_table_begin)
7396         (mi_ui_out::do_table_header): Update.
7397         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7398         type of "value".
7399         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7400         (mi_cmd_data_list_changed_registers, output_register)
7401         (mi_cmd_data_read_memory, mi_load_progress)
7402         (mi_cmd_trace_frame_collected): Update.
7403         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7404         Update.
7405         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7406         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7407         (mi_cmd_var_list_children, varobj_update_one): Update.
7408         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7409         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7410         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7411         * inferior.c (print_inferior): Update.
7412         * gdb_bfd.c (print_one_bfd): Update.
7413         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7414         Update.
7415         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7416         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7417         do_field_int.  Change type of "value".
7418         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7419         do_field_int.  Change type of "value".
7420         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7421         (print_one_breakpoint_location, print_it_catch_fork)
7422         (print_one_catch_fork, print_it_catch_vfork)
7423         (print_one_catch_vfork, print_it_catch_solib)
7424         (print_it_catch_exec, print_it_ranged_breakpoint)
7425         (print_mention_watchpoint, print_mention_masked_watchpoint)
7426         (bkpt_print_it, update_static_tracepoint): Update.
7427         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7428         * break-catch-syscall.c (print_it_catch_syscall): Update.
7429         * ada-tasks.c (print_ada_task_info): Update.
7430         * ada-lang.c (print_it_exception, print_mention_exception):
7431         Update.
7432
7433 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7434
7435         PR breakpoints/24541
7436         * gdbarch.c: Regenerate.
7437         * gdbarch.h: Regenerate.
7438         * gdbarch.sh: Adjust return type and parameter types for
7439         'stap_adjust_register'.
7440         (i386_stap_adjust_register): Adjust signature and return new
7441         register name.
7442         * stap-probe.c (stap_parse_register_operand): Adjust use of
7443         'gdbarch_stap_adjust_register'.
7444
7445 2019-07-17  Tom Tromey  <tromey@adacore.com>
7446
7447         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7448         declare VEC.
7449         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7450         std::vector.
7451         (struct s390_process_info): Add initializers.
7452         (s390_add_process): Use new.
7453         (s390_linux_nat_target::low_forget_process): Use delete.
7454         (s390_linux_nat_target::low_new_fork)
7455         (s390_linux_nat_target::stopped_by_watchpoint)
7456         (s390_linux_nat_target::low_prepare_to_resume)
7457         (s390_linux_nat_target::insert_watchpoint)
7458         (s390_linux_nat_target::insert_hw_breakpoint)
7459         (s390_linux_nat_target::remove_watchpoint)
7460         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7461
7462 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7463
7464         * aarch64-fbsd-nat.c: Include regcache.h.
7465         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7466         argument.
7467         (aarch64_fbsd_nat_target::fetch_registers)
7468         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7469         variable.
7470         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7471
7472 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7473
7474         * fbsd-nat.c: Include gdbarch.h.
7475
7476 2019-07-15  Tom Tromey  <tromey@adacore.com>
7477
7478         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7479
7480 2019-07-15  Tom Tromey  <tromey@adacore.com>
7481
7482         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7483         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7484         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7485         * cli-out.c (cli_ui_out::do_field_int): New method.
7486         * ui-out.c (ui_out::field_unsigned): New method.
7487         * symfile.c (generic_load): Use field_unsigned.
7488         (print_transfer_performance): Likewise.
7489         * record-btrace.c (ui_out_field_uint): Remove.
7490         (btrace_call_history_insn_range, btrace_call_history): Use
7491         field_unsigned.
7492         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7493         field_unsigned.
7494         * ui-out.h (class ui_out) <field_unsigned>: New method.
7495         <do_field_unsigned>: Likewise.
7496
7497 2019-07-15  Tom Tromey  <tromey@adacore.com>
7498
7499         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7500         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7501         * target.c (flash_erase_command): Use field_string.
7502         * infrun.c (print_signal_received_reason): Use field_string.
7503         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7504         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7505         field_string.
7506         * ada-tasks.c (print_ada_task_info): Use field_string.
7507
7508 2019-07-15  Tom Tromey  <tromey@adacore.com>
7509
7510         * target.c (flash_erase_command): Use field_core_addr.
7511         * symfile.c (generic_load): Use field_core_addr.
7512         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7513         Use field_core_addr.
7514         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7515         field_core_addr.
7516
7517 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7520         value if its desired type is smaller than a CORE_ADDR and signed.
7521
7522 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7525         of changes to field names, and use new is_reference field to
7526         decide if a property is a reference or not.
7527         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7528         field.
7529         (struct dwarf2_property_baton): Update header comment, rename
7530         'referenced_type' to 'property_type' and update comments.
7531         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7532         default property type, store in property baton, update to take
7533         accound of renamed field.
7534         (read_func_scope): Update call to attr_to_dynamic_prop.
7535         (read_array_type): Likewise.
7536         (dwarf2_per_cu_addr_sized_int_type): New function.
7537         (read_subrange_index_type): Move type finding code to
7538         dwarf2_per_cu_addr_sized_int_type.
7539         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7540         (dwarf2_per_cu_addr_type): New function.
7541         (set_die_type): Update calls to attr_to_dynamic_prop.
7542
7543 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7544
7545         * dwarf2read.c (read_subrange_index_type): New function.
7546         (read_subrange_type): Move code into new function and call it.
7547         * gdbtypes.c (create_range_type): Add some asserts.
7548
7549 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7552         update return statements.
7553         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7554         declaration, and update comment to match.
7555         * gdbtypes.c (resolve_dynamic_array): Update call to
7556         dwarf2_evaluate_property to match new return type.
7557
7558 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * valarith.c (value_subscripted_rvalue): Change lowerbound
7561         parameter type from int to LONGEST.
7562         * value.h (value_subscripted_rvalue): Likewise in declaration.
7563
7564 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * cli/cli-utils.c (info_print_command_completer): New function.
7567         * cli/cli-utils.h: Add 'completer.h' include, and forward
7568         declaration for 'struct cmd_list_element'.
7569         (info_print_command_completer): Declare.
7570         * stack.c (_initialize_stack): Add completer for 'info locals' and
7571         'info args'.
7572         * symtab.c (_initialize_symtab): Add completer for 'info
7573         variables' and 'info functions'.
7574         * NEWS: Mention completion for additional info commands.
7575
7576 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * cli/cli-utils.c (extract_info_print_args): Delete.
7579         (extract_arg_maybe_quoted): Delete.
7580         (info_print_options_defs): New variable.
7581         (make_info_print_options_def_group): New function.
7582         (extract_info_print_options): Define new function.
7583         * cli/cli-utils.h (extract_info_print_args): Delete.
7584         (struct info_print_options): New structure.
7585         (extract_info_print_options): Declare new function.
7586         * stack.c (info_locals_command): Update to use new
7587         extract_info_print_options, also add a header comment.
7588         (info_args_command): Likewise.
7589         * symtab.c (info_variables_command): Likewise.
7590         (info_functions_command): Likewise.
7591
7592 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7593
7594         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7595         to extract string arguments.
7596         * common/common-utils.c (extract_string_maybe_quoted): New function.
7597         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7598
7599 2019-07-11  Tom Tromey  <tromey@adacore.com>
7600
7601         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7602         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7603         * top.h (gdbinit): Don't declare.
7604         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7605         into...
7606         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7607         * top.c (gdb_init): Don't call init_cli_cmds.
7608         (gdbinit): Remove.
7609         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7610
7611 2019-07-11  Tom Tromey  <tromey@adacore.com>
7612
7613         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7614         after it has been moved.
7615
7616 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7617
7618         * valops.c (value_must_coerce_to_target): Change return type to
7619         bool.
7620         * value.h (value_must_coerce_to_target): Likewise.
7621
7622 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7623
7624         * breakpoint.c (is_hardware_watchpoint): Remove
7625         forward-declaration.
7626         (is_masked_watchpoint): Change return type to bool.
7627         (is_tracepoint): Likewise.
7628         (is_breakpoint): Likewise.
7629         (is_hardware_watchpoint): Likewise.
7630         (is_watchpoint): Likewise.
7631         (is_no_memory_software_watchpoint): Likewise.
7632         (is_catchpoint): Likewise.
7633         (breakpoint_1): Make FILTER parameter's return type bool.
7634         is_masked_watchpoint): Change return type to bool.
7635         (save_breakpoints): Make FILTER parameter's return type bool.
7636         * breakpoint.h (is_breakpoint): Change return type to bool.
7637         (is_watchpoint): Likewise.
7638         (is_catchpoint): Likewise.
7639         (is_tracepoint): Likewise.
7640
7641 2019-07-10  Tom Tromey  <tom@tromey.com>
7642
7643         * defs.h: Don't include gdbarch.h.
7644         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7645         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7646         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7647         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7648         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7649         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7650         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7651         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7652         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7653         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7654         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7655         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7656         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7657         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7658         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7659         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7660         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7661         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7662         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7663         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7664         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7665         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7666         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7667         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7668         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7669         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7670         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7671
7672 2019-07-10  Tom Tromey  <tromey@adacore.com>
7673
7674         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7675         * breakpoint.c (init_ada_exception_breakpoint): Register as
7676         bp_catchpoint.
7677         (print_one_breakpoint_location, print_one_breakpoint): Use
7678         is_ada_exception_catchpoint.
7679         * ada-lang.c (class ada_catchpoint_location): Pass
7680         bp_loc_software_breakpoint to bp_location constructor.
7681         (is_ada_exception_catchpoint): New function.
7682
7683 2019-07-10  Tom Tromey  <tromey@adacore.com>
7684
7685         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7686         VEC.
7687         (struct arm_exidx_entry): New method operator<.
7688         (struct arm_exidx_data) <section_maps>: Change type.
7689         (arm_exidx_data_free): Remove.
7690         (arm_exidx_data_key): Change type.  Move lower.
7691         (arm_exidx_new_objfile): Update.
7692         (arm_compare_exidx_entries): Remove.
7693         (arm_find_exidx_entry, _initialize_arm_tdep)
7694
7695 2019-07-10  Tom Tromey  <tromey@adacore.com>
7696
7697         * solib-spu.c (ocl_program_data_key): Change type.
7698         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7699         Update.
7700
7701 2019-07-10  Tom Tromey  <tromey@adacore.com>
7702
7703         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7704         (struct solib_aix_inferior_data) <library_list>: Change type.
7705         (solib_aix_inferior_data_handle): Change type.
7706         (get_solib_aix_inferior_data): Update.
7707         (solib_aix_free_library_list): Remove.
7708         (library_list_start_library): Update.
7709         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7710         return type.
7711         (solib_aix_get_library_list)
7712         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7713         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7714
7715 2019-07-10  Tom Tromey  <tromey@adacore.com>
7716
7717         * solib-dsbt.c (struct dsbt_info): Add initializers.
7718         (solib_dsbt_pspace_data): Change type.
7719         (dsbt_pspace_data_cleanup): Remove.
7720         (get_dsbt_info, _initialize_dsbt_solib): Update.
7721
7722 2019-07-10  Tom Tromey  <tromey@adacore.com>
7723
7724         * spu-tdep.c (spu_overlay_data): Change type.
7725         (spu_get_overlay_table, spu_overlay_new_objfile)
7726         (_initialize_spu_tdep): Update.
7727
7728 2019-07-10  Tom Tromey  <tromey@adacore.com>
7729
7730         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7731         destructor.
7732         (dbx_objfile_data_key): Change type and declare later.
7733         (DBX_SYMFILE_INFO): Rewrite.
7734         * dbxread.c (dbx_objfile_data_key): Change type.
7735         (dbx_symfile_init): Update.
7736         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7737         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7738         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7739
7740 2019-07-10  Tom Tromey  <tromey@adacore.com>
7741
7742         * jit.c (jit_program_space_key): Change type.  Move lower.
7743         (get_jit_program_space_data): Update.
7744         (jit_program_space_data_cleanup): Remove.
7745         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7746         Update.
7747         (struct jit_program_space_data): Add initializers.
7748
7749 2019-07-10  Tom Tromey  <tromey@adacore.com>
7750
7751         * solib-darwin.c (struct darwin_info): Add initializers.
7752         (solib_darwin_pspace_data): Change type.
7753         (darwin_pspace_data_cleanup): Remove.
7754         (get_darwin_info, _initialize_darwin_solib): Update.
7755
7756 2019-07-10  Tom Tromey  <tromey@adacore.com>
7757
7758         * remote-sim.c (struct sim_inferior_data): Add initializers,
7759         constructor, and destructor.
7760         (sim_inferior_data_key): Change type.  Move lower.
7761         (check_for_duplicate_sim_descriptor): Update.
7762         (get_sim_inferior_data): Use new.  Update.
7763         (~sim_inferior_data_cleanup): Rename from
7764         sim_inferior_data_cleanup.  Simplify.
7765         (gdbsim_close_inferior, simulator_command)
7766         (sim_command_completer, _initialize_remote_sim): Update.
7767         (next_pid, INITIAL_PID): Move earlier.
7768
7769 2019-07-10  Tom Tromey  <tromey@adacore.com>
7770
7771         * python/python-internal.h (create_thread_object): Return
7772         gdbpy_ref.
7773         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7774         * python/py-inferior.c (struct threadlist_entry): Add
7775         constructor.
7776         <thread_obj>: Now a gdbpy_ref.
7777         (thread_to_thread_object): Update.
7778         (add_thread_object): Use new.
7779         (delete_thread_object): Use delete.
7780         (infpy_threads): Update.
7781         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7782         GIL.
7783
7784 2019-07-10  Tom Tromey  <tromey@adacore.com>
7785
7786         * valops.c (value_cast): Specialize error message for Ada.
7787
7788 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7789
7790         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7791
7792 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7793
7794         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7795         bpstat_should_step): Return bool, adjust comments.
7796         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7797         bpstat_should_step): Likewise.
7798
7799 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7800
7801         * features/Makefile: Use feature target descriptions for Arm.
7802         * features/arm/arm-core.c: Generate new file.
7803         * features/arm/arm-fpa.c: Likewise.
7804         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7805         * features/arm/arm-m-profile.c: Likewise.
7806         * features/arm/arm-vfpv2.c: Likewise.
7807         * features/arm/arm-vfpv3.c: Likewise.
7808         * features/arm/xscale-iwmmxt.c: Likewise.
7809         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7810
7811 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7812
7813         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7814         ptrace earlier.
7815
7816 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7817
7818         * features/aarch64-pauth.c: Regenerate.
7819
7820 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7821
7822         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7823         bool.
7824         (bpstat_what): Use false instead of 0.
7825
7826 2019-07-09  Pedro Alves  <palves@redhat.com>
7827
7828         * break-catch-throw.c (is_exception_catchpoint): New.
7829         * breakpoint.c (print_one_breakpoint_location): New parameter
7830         'raw_loc'.  Handle it.  Use
7831         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7832         looking at the breakpoint's type.
7833         (print_one_breakpoint): If handling "maint info breakpoints", also
7834         print locations of exception catchpoints.
7835         * breakpoint.h (is_exception_catchpoint): Declare.
7836
7837 2019-07-09  Pedro Alves  <palves@redhat.com>
7838
7839         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7840         "addr" field.
7841         (allocate_location_exception_catchpoint): New.
7842         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7843         (initialize_throw_catchpoint_ops): Install
7844         allocate_location_exception_catchpoint as allocate_location
7845         method.
7846         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7847         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7848         bp_loc_other.
7849         (breakpoint_address_is_meaningful): Delete.
7850         (bl_address_is_meaningful): New.
7851         (breakpoint_locations_match): Adjust comment.
7852         (bp_location_from_bp_type): New, factored out of...
7853         (bp_location::bp_location(breakpoint *)): ... this.
7854         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7855         factored out of...
7856         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7857         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7858         breakpoint_address_is_meaningful.
7859         (bp_locations_compare): Adjust comment.
7860         (update_global_location_list): Use bl_address_is_meaningful
7861         instead of breakpoint_address_is_meaningful.
7862         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7863         explicit.
7864         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7865         * python/py-breakpoint.c (bppy_get_location): No longer check
7866         whether location is null.
7867
7868 2019-07-09  Pedro Alves  <palves@redhat.com>
7869
7870         PR c++/15468
7871         * breakpoint.c (print_one_breakpoint_location): Remove
7872         single-location assert.
7873
7874 2019-07-09  Tom Tromey  <tom@tromey.com>
7875
7876         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7877         * configure: Rebuild.
7878         * configure.ac: Change common to gdbsupport.
7879         * gdbsupport: Rename from common.
7880         * acinclude.m4: Change common to gdbsupport.
7881         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7882         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7883         gdbsupport.
7884         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7885         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7886         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7887         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7888         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7889         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7890         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7891         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7892         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7893         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7894         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7895         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7896         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7897         coff-pe-read.c, command.h, compile/compile-c-support.c,
7898         compile/compile-c.h, compile/compile-cplus-symbols.c,
7899         compile/compile-cplus-types.c, compile/compile-cplus.h,
7900         compile/compile-loc2c.c, compile/compile.c, completer.c,
7901         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7902         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7903         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7904         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7905         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7906         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7907         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7908         features/aarch64-core.c, features/aarch64-fpu.c,
7909         features/aarch64-pauth.c, features/aarch64-sve.c,
7910         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7911         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7912         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7913         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7914         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7915         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7916         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7917         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7918         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7919         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7920         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7921         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7922         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7923         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7924         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7925         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7926         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7927         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7928         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7929         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7930         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7931         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7932         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7933         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7934         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7935         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7936         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7937         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7938         minsyms.c, mips-linux-tdep.c, namespace.h,
7939         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7940         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7941         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7942         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7943         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7944         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7945         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7946         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7947         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7948         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7949         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7950         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7951         procfs.c, producer.c, progspace.h, psymtab.h,
7952         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7953         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7954         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7955         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7956         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7957         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7958         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7959         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7960         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7961         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7962         target-memory.c, target.c, target.h, target/waitstatus.c,
7963         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7964         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7965         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7966         unittests/array-view-selftests.c,
7967         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7968         unittests/common-utils-selftests.c,
7969         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7970         unittests/format_pieces-selftests.c,
7971         unittests/function-view-selftests.c,
7972         unittests/lookup_name_info-selftests.c,
7973         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7974         unittests/mkdir-recursive-selftests.c,
7975         unittests/observable-selftests.c,
7976         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7977         unittests/parse-connection-spec-selftests.c,
7978         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7979         unittests/scoped_fd-selftests.c,
7980         unittests/scoped_mmap-selftests.c,
7981         unittests/scoped_restore-selftests.c,
7982         unittests/string_view-selftests.c, unittests/style-selftests.c,
7983         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7984         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7985         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7986         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7987         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7988         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7989
7990 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7993         bool value.
7994         (decode_digits_ordinary): Set explicit_line field in sal.
7995         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7996         symtab_and_line that was set on an explicit line number in
7997         assembler code.  Do always update the recorded symtab and line if
7998         we do skip the prologue.
7999
8000 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * breakpoint.c (set_breakpoint_location_function): Remove
8003         explicit_loc parameter.
8004         (momentary_breakpoint_from_master): Update call to
8005         set_breakpoint_location_function.
8006         (add_location_to_breakpoint): Likewise.
8007
8008 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8011         required features based on default bfd type when no specific bfd
8012         is present.
8013
8014 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8015
8016         * NEWS: Mention that GDB printf and eval commands can now print
8017         C-style and Ada-style convenience var strings without
8018         calling the inferior.
8019         * printcmd.c (printf_c_string): Locally print GDB internal var
8020         instead of transiting via the inferior.
8021         (printf_wide_c_string): Likewise.
8022
8023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8024
8025         PR breakpoints/25011
8026         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8027
8028 2019-07-04  Tom Tromey  <tom@tromey.com>
8029
8030         PR tui/24724:
8031         * tui/tui-winsource.c (tui_clear_source_content): Update.
8032         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8033         (tui_update_breakpoint_info): Update.
8034         (tui_set_exec_info_content): Update.
8035         * tui/tui-source.c (tui_set_source_content_nil): Update.
8036         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8037         has_break.
8038         * tui/tui-data.h (enum tui_bp_flag): New.
8039         (tui_bp_flags): New enum flags type.
8040         (struct tui_source_element) <break_mode>: Change type.  Rename
8041         from has_break.
8042         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8043         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8044         constants.
8045         * tui/tui-winsource.h: Fix comment.
8046
8047 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8048
8049         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8050         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8051         (store_fpregs_to_thread)
8052         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8053         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8054         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8055         (IWMMXT_REGS_SIZE): Add define.
8056         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8057         (fetch_vfp_regs, store_vfp_regs)
8058         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8059         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8060
8061 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8062
8063         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8064         defines.
8065         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8066         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8067         (ARM_INT_REGISTER_SIZE): ...to this.
8068         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8069         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8070         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8071         (arm_linux_collect_gregset, supply_nwfpe_register)
8072         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8073         defines.
8074         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8075         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8076         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8077         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8078         (arm_return_in_memory, arm_store_return_value)
8079         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8080         (arm_record_ld_st_multiple): Likewise.
8081         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8082         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8083
8084 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8085
8086         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8087         AARCH64_DISPLACED_MODIFIED_INSNS.
8088         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8089         (aarch64_displaced_step_copy_insn): Likewise.
8090         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8091         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8092         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8093         ARM_DISPLACED_MODIFIED_INSNS.
8094         * arm-tdep.c (arm_gdbarch_init): Likewise.
8095         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8096         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8097         (struct arm_displaced_step_closure): Use
8098         ARM_DISPLACED_MODIFIED_INSNS.
8099
8100 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8101
8102         * features/Makefile: Remove unused xml files.
8103         * features/aarch64.xml: Remove.
8104         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8105         * features/i386/amd64-avx-avx512.xml: Remove.
8106         * features/i386/amd64-avx-linux.xml: Remove.
8107         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8108         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8109         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8110         * features/i386/amd64-avx-mpx.xml: Remove.
8111         * features/i386/amd64-avx.xml: Remove.
8112         * features/i386/amd64-linux.xml: Remove.
8113         * features/i386/amd64-mpx-linux.xml: Remove.
8114         * features/i386/amd64-mpx.xml: Remove.
8115         * features/i386/amd64.xml: Remove.
8116         * features/i386/i386-avx-avx512-linux.xml: Remove.
8117         * features/i386/i386-avx-avx512.xml: Remove.
8118         * features/i386/i386-avx-linux.xml: Remove.
8119         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8120         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8121         * features/i386/i386-avx-mpx-linux.xml: Remove.
8122         * features/i386/i386-avx-mpx.xml: Remove.
8123         * features/i386/i386-avx.xml: Remove.
8124         * features/i386/i386-linux.xml: Remove.
8125         * features/i386/i386-mmx-linux.xml: Remove.
8126         * features/i386/i386-mmx.xml: Remove.
8127         * features/i386/i386-mpx-linux.xml: Remove.
8128         * features/i386/i386-mpx.xml: Remove.
8129         * features/i386/i386.xml: Remove.
8130         * features/i386/x32-avx-avx512-linux.xml: Remove.
8131         * features/i386/x32-avx-linux.xml: Remove.
8132         * features/i386/x32-linux.xml: Remove.
8133
8134 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8135
8136         * regformats/aarch64.dat: Remove.
8137         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8138         * regformats/i386/amd64-avx-linux.dat: Remove.
8139         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8140         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8141         * regformats/i386/amd64-linux.dat: Remove.
8142         * regformats/i386/amd64-mpx-linux.dat: Remove.
8143         * regformats/i386/amd64.dat: Remove.
8144         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8145         * regformats/i386/i386-avx-linux.dat: Remove.
8146         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8147         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8148         * regformats/i386/i386-linux.dat: Remove.
8149         * regformats/i386/i386-mmx-linux.dat: Remove.
8150         * regformats/i386/i386-mpx-linux.dat: Remove.
8151         * regformats/i386/i386.dat: Remove.
8152         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8153         * regformats/i386/x32-avx-linux.dat: Remove.
8154         * regformats/i386/x32-linux.dat: Remove.
8155
8156 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8157
8158         * aarch64-tdep.c: Remove xml self tests.
8159         * amd64-linux-tdep.c: Likewise.
8160         * amd64-tdep.c: Likewise.
8161         * i386-linux-tdep.c: Likewise.
8162         * i386-tdep.c: Likewise.
8163
8164 2019-07-03  Pedro Alves  <palves@redhat.com>
8165
8166         PR cli/24732
8167         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8168         (pipe_cmd_option_defs): New.
8169         (make_pipe_cmd_options_def_group): New.
8170         (pipe_command): Use gdb::option::process_options.
8171         (pipe_command_completer): New function.
8172         (_initialize_cli_cmds): Install completer for "pipe" command.
8173
8174 2019-07-03  Pedro Alves  <palves@redhat.com>
8175
8176         * cli/cli-option.c (union option_value) <string>: New field.
8177         (struct option_def_and_value): Add ctor, move ctor, dtor and
8178         use DISABLE_COPY_AND_ASSIGN.
8179         (option_def_and_value::clear_value): New.
8180         (parse_option, save_option_value_in_ctx, get_val_type_str)
8181         (add_setshow_cmds_for_options): Handle var_string.
8182         * cli-option.h (union option_def::var_address) <string>: New
8183         field.
8184         (struct string_option_def): New.
8185         * maint-test-options.c (struct test_options_opts): Add default
8186         ctor and use DISABLE_COPY_AND_ASSIGN.
8187         <string_opt>: New field.
8188         (test_options_opts::~test_options_opts): New.
8189         (test_options_opts::dump): Also dump "-string".
8190         (test_options_option_defs): Install "string.
8191
8192 2019-07-03  Pedro Alves  <palves@redhat.com>
8193
8194         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8195         option_value with a null enumeration.
8196         (complete_options): Save the option values in the context.
8197         (save_option_value_in_ctx): New, factored out from ...
8198         (process_options): ... here.
8199         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8200         of the function.
8201         * maint-test-options.c (test_options_opts::dump): New, factored
8202         out from ...
8203         (maintenance_test_options_command_mode): ... here.
8204         (maintenance_test_options_command_completion_result): Delete.
8205         (maintenance_test_options_command_completion_text): Update
8206         comment.
8207         (maintenance_show_test_options_completion_result): Change
8208         prototype.  Just print
8209         maintenance_test_options_command_completion_text.
8210         (save_completion_result): New.
8211         (maintenance_test_options_completer_mode): Pass options context to
8212         complete_options, and then save a dump.
8213         (_initialize_maint_test_options): Use add_cmd to install "maint
8214         show test-options-completion-result".
8215
8216 2019-07-03  Pedro Alves  <palves@redhat.com>
8217
8218         * NEWS (New commands): Mention "with" and "maint with".
8219         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8220         (with_command, with_command_completer): New.
8221         (pipe_command): Adjust to new repeat_previous
8222         interface.
8223         (_initialize_cli_cmds): Install the "with" command and its "w"
8224         alias.
8225         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8226         declarations.
8227         * cli/cli-setshow.c (parse_cli_var_uinteger)
8228         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8229         argument strings for all var_types.
8230         (get_setshow_command_value_string): New, factored out from ...
8231         (do_show_command): ... this.
8232         * cli/cli-setshow.h: Include <string>.
8233         (get_setshow_command_value_string): Declare.
8234         * command.h (repeat_previous): Now returns const char *.  Adjust
8235         comment.
8236         * maint.c: Include "cli/cli-cmds.h".
8237         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8238         (_initialize_maint_cmds): Register the "maintenance with" command.
8239         * top.c (repeat_previous): Move bits from pipe_command here:
8240         Return the saved command line, if any; error out if there's no
8241         command to relaunch.
8242
8243 2019-07-03  Pedro Alves  <palves@redhat.com>
8244
8245         * NEWS (New commands): Mention "maint set/show test-settings"
8246         instead of "maint test-settings".
8247         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8248         (maintenance_test_settings_set_list): Rename to ...
8249         (maintenance_set_test_settings_list): ... this.
8250         (maintenance_test_settings_show_list): Rename to  ...
8251         (maintenance_show_test_settings_list): ... this.
8252         (maintenance_test_settings_cmd): Delete.
8253         (maintenance_test_settings_set_cmd): ...
8254         (maintenance_set_test_settings_cmd): ... this.
8255         (maintenance_test_settings_show_cmd): ...
8256         (maintenance_show_test_settings_cmd): ... this.
8257         (maintenance_test_settings_show_value_cmd):
8258         (maintenance_show_test_settings_value_cmd): ... this.
8259         (_initialize_maint_test_settings): No longer install the "maint
8260         test-settings" prefix command.  Rename "maint test-settings set"
8261         to "maint set test-settings", and "maint test-settings show" to
8262         "maint show test-settings".  Adjust all subcommands.
8263
8264 2019-07-03  Pedro Alves  <palves@redhat.com>
8265
8266         * maint-test-settings.c: Fix file's intro comment.  Replace all
8267         references to "test-options" with references to "test-settings",
8268         in comments.
8269
8270 2019-07-03  Pedro Alves  <palves@redhat.com>
8271
8272         * maint-test-settings.c (maintenance_test_settings_xxx)
8273         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8274         New.
8275         (maintenance_test_settings_enums): Use them.
8276         (maintenance_test_settings_enum): Default to
8277         maintenance_test_settings_xxx.
8278         (_initialize_maint_test_settings): Initialize
8279         MAINTENANCE_TEST_SETTINGS_FILENAME.
8280
8281 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8282
8283         * breakpoint.h (remove_breakpoints_inf): Change return type to
8284         void, move function documentation here.
8285         * breakpoint.c (remove_breakpoints_inf): Change return type to
8286         void, move function documentation to header.
8287
8288 2019-07-02  Pedro Alves  <palves@redhat.com>
8289
8290         * NEWS (Completion improvements): Mention "info threads".
8291         * thread.c (struct info_threads_opts, info_threads_option_defs)
8292         (make_info_threads_options_def_group): New.
8293         (info_threads_command): Use gdb::option::process_options.
8294         (info_threads_command_completer): New.
8295         (_initialize_thread): Use gdb::option::build_help to build the
8296         help text for "info threads".
8297
8298 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8299
8300         * defs.h (generic_load): Move from here...
8301         * symfile.h (generic_load): ... to here.  Rename name parameter
8302         to args.
8303         * symfile.c (generic_load): Add comment.
8304
8305 2019-07-01  Tom Tromey  <tromey@adacore.com>
8306
8307         * dwarf2read.c
8308         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8309         declaration of without_params.  Fix formatting.
8310
8311 2019-07-01  Tom Tromey  <tromey@adacore.com>
8312
8313         * ada-exp.y (find_primitive_type): Update.
8314         * ada-lang.h (ada_lookup_symbol): Update.
8315         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8316         parameter.
8317         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8318
8319 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8320
8321         PR breakpoints/24541
8322         * gdbarch.c: Regenerate.
8323         * gdbarch.h: Regenerate.
8324         * gdbarch.sh: Add 'stap_adjust_register'.
8325         * i386-tdep.c: Include '<unordered_set>'.
8326         (i386_stap_adjust_register): New function.
8327         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8328         * stap-probe.c (stap_parse_register_operand): Call
8329         'gdbarch_stap_adjust_register'.
8330
8331 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8332
8333         PR python/24742
8334         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8335         * python/python.c (do_start_initialization): Use 'xmalloc'
8336         instead of 'PyMem_Malloc'.
8337
8338 2019-06-28  Tom Tromey  <tromey@adacore.com>
8339
8340         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8341         for Ada.
8342
8343 2019-06-27  Tom Tromey  <tromey@adacore.com>
8344
8345         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8346         objfile_key.
8347         (arm_find_mapping_symbol, arm_record_special_symbol)
8348         (_initialize_arm_tdep): Update.
8349         (arm_objfile_data_free): Remove.
8350
8351 2019-06-27  Tom Tromey  <tromey@adacore.com>
8352
8353         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8354         to cp_print_static_field.
8355
8356 2019-06-26  Tom Tromey  <tromey@adacore.com>
8357
8358         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8359         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8360         declare.
8361
8362 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8363
8364         * features/aarch64-core.c (create_feature_aarch64_core):
8365         Regenerate.
8366         * features/aarch64-core.xml: Add cpsr flags.
8367
8368 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8369
8370         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8371         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8372
8373 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8374
8375         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8376         field.
8377         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8378         use.
8379         (arm_record_special_symbol): Don't insert new symbol in sorted
8380         position, push it at the end.
8381
8382 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8383
8384         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8385         (arm_mapping_symbol_s): Remove.
8386         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8387         (arm_mapping_symbol_vec): New typedef.
8388         (struct arm_per_objfile): Add constructor.
8389         <section_maps>: Change type to
8390         std::unique_ptr<arm_mapping_symbol_vec[]>.
8391         (arm_compare_mapping_symbols): Remove.
8392         (arm_find_mapping_symbol): Adjust to section_maps type change.
8393         (arm_objfile_data_free): Call delete on arm_per_objfile.
8394         (arm_record_special_symbol): Adjust to section_maps type change.
8395         Allocate arm_per_objfile with new.
8396
8397 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8398
8399         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8400         with the command prefix.
8401
8402 2019-06-25  Tom Tromey  <tom@tromey.com>
8403
8404         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8405         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8406
8407 2019-06-25  Tom Tromey  <tom@tromey.com>
8408
8409         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8410         type.
8411         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8412         protected.
8413
8414 2019-06-25  Tom Tromey  <tom@tromey.com>
8415
8416         * tui/tui-winsource.c
8417         (tui_source_window_base::set_is_exec_point_at): Add check against
8418         LOA_ADDRESS.
8419
8420 2019-06-25  Tom Tromey  <tom@tromey.com>
8421
8422         * tui/tui-source.c (tui_set_source_content): Don't check before
8423         xfree.
8424         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8425
8426 2019-06-25  Tom Tromey  <tom@tromey.com>
8427
8428         * tui/tui-winsource.h (tui_update_source_window_as_is)
8429         (tui_alloc_source_buffer, tui_line_is_displayed)
8430         (tui_addr_is_displayed): Change type of win_info.
8431         * tui/tui-winsource.c (tui_update_source_window_as_is)
8432         (tui_clear_source_content, tui_show_source_line)
8433         (tui_show_source_content, tui_source_window_base::refill)
8434         (tui_source_window_base::set_is_exec_point_at)
8435         (tui_source_window_base::set_is_exec_point_at)
8436         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8437         (tui_alloc_source_buffer, tui_line_is_displayed)
8438         (tui_addr_is_displayed): Change type of win_info.  Update.
8439         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8440         (tui_source_window_base::do_make_visible_with_new_height):
8441         Update.
8442         * tui/tui-source.c (tui_set_source_content)
8443         (tui_set_source_content_nil)
8444         (tui_source_window::do_scroll_vertical): Update.
8445         * tui/tui-layout.c (show_layout): Update.
8446         * tui/tui-disasm.c (tui_set_disassem_content)
8447         (tui_disasm_window::do_scroll_vertical): Update.
8448         * tui/tui-data.h (tui_win_content): Remove.
8449         (struct tui_gen_win_info) <content, content_size>: Remove.
8450         (struct tui_source_element): Add initializers and destructor.
8451         (union tui_which_element, struct tui_win_element): Remove.
8452         (struct tui_source_window_base) <content>: New field.
8453         (struct tui_data_window): Remove destructor.
8454         (tui_alloc_content, tui_free_win_content)
8455         (tui_free_all_source_wins_content): Don't declare.
8456         * tui/tui-data.c (tui_initialize_static_data): Update.
8457         (init_content_element, tui_alloc_content): Remove.
8458         (~tui_gen_win_info): Update.
8459         (~tui_data_window, tui_free_all_source_wins_content)
8460         (tui_free_win_content, free_content, free_content_elements):
8461         Remove.
8462
8463 2019-06-25  Tom Tromey  <tom@tromey.com>
8464
8465         * tui/tui-winsource.h (tui_clear_source_content)
8466         (tui_erase_source_content, tui_show_source_content): Change type
8467         of win_info.
8468         * tui/tui-winsource.c (tui_clear_source_content)
8469         (tui_erase_source_content, tui_show_source_content): Change type
8470         of win_info.
8471         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8472         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8473         win_info.
8474         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8475         win_info.
8476         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8477
8478 2019-06-25  Tom Tromey  <tom@tromey.com>
8479
8480         * tui/tui-winsource.c (tui_clear_source_content)
8481         (tui_source_window_base::set_is_exec_point_at): Update.
8482         * tui/tui-source.c (tui_set_source_content_nil): Update.
8483         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8484         a bool.
8485         * tui/tui-data.c (init_content_element): Update.
8486
8487 2019-06-25  Tom Tromey  <tom@tromey.com>
8488
8489         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8490         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8491         * tui/tui-layout.c (init_and_make_win): Update.
8492         * tui/tui.h (enum tui_win_type): Update.
8493         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8494         tui_win_is_auxillary.
8495         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8496         tui_win_is_auxillary.
8497
8498 2019-06-25  Tom Tromey  <tom@tromey.com>
8499
8500         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8501         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8502         (tui_delete_data_content_windows, tui_display_all_data)
8503         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8504         Update.
8505         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8506         * tui/tui-regs.c (tui_last_regs_line_no)
8507         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8508         (tui_show_registers): Update.
8509         (tui_show_register_group): Return void.  Update.
8510         (tui_display_registers_from, tui_display_reg_element_at_line)
8511         (tui_display_registers_from_line, tui_check_register_values):
8512         Update.
8513         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8514         member.
8515         (struct tui_data_window) <regs_content>: Now a std::vector.
8516         <regs_content_count>: Remove.
8517         (tui_add_content_elements, tui_free_data_content): Don't declare.
8518         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8519         (init_content_element): Remove DATA_WIN case.  Add assert.
8520         (tui_add_content_elements): Remove.
8521         (tui_data_window): Update.
8522         (tui_free_data_content): Remove.
8523         (free_content_elements): Remove DATA_WIN case.
8524
8525 2019-06-25  Tom Tromey  <tom@tromey.com>
8526
8527         * tui/tui-data.c (tui_data_item_window): Update.
8528         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8529         * tui/tui-windata.c (tui_display_all_data)
8530         (tui_display_data_from_line): Update.
8531         (tui_check_data_values): Remove.
8532         * tui/tui-regs.c (tui_show_register_group)
8533         (tui_display_reg_element_at_line): Update.
8534         * tui/tui-hooks.c (tui_register_changed)
8535         (tui_refresh_frame_and_register_information): Call
8536         tui_check_register_values.
8537         * tui/tui-data.h (struct tui_data_window) <data_content,
8538         data_content_count, data_type>: Remove.
8539         (enum tui_data_type): Remove.
8540
8541         * tui/tui-data.c (tui_data_window::clear_detail)
8542         (~tui_data_window): Update.
8543
8544 2019-06-25  Tom Tromey  <tom@tromey.com>
8545
8546         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8547         declare.
8548         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8549         Rename from tui_first_data_item_displayed.  Update.
8550         (tui_data_window::refresh_all)
8551         (tui_data_window::do_scroll_vertical): Update.
8552         * tui/tui-data.h (struct tui_data_window)
8553         <first_data_item_displayed>: Declare new method.
8554
8555 2019-06-25  Tom Tromey  <tom@tromey.com>
8556
8557         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8558         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8559         contents...
8560         (tui_initialize_static_data): ...here.
8561
8562 2019-06-25  Tom Tromey  <tom@tromey.com>
8563
8564         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8565         (tui_display_registers_from, tui_check_register_values): Update.
8566         (tui_display_register): Remove win_info parameter; update.
8567         (tui_get_register): Change type of parameters.
8568         * tui/tui-data.h (struct tui_data_element): Remove.
8569         (union tui_which_element) <data>: Remove.
8570         <data_window>: Change type.
8571         (struct tui_data_item_window): New.
8572         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8573         case.  Add assert.
8574         (~tui_data_item_window): New destructor.
8575         (free_content_elements): Remove DATA_ITEM_WIN case.
8576
8577 2019-06-25  Tom Tromey  <tom@tromey.com>
8578
8579         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8580         Remove.
8581
8582 2019-06-25  Tom Tromey  <tom@tromey.com>
8583
8584         * tui/tui-data.h (struct tui_command_element): Remove.
8585         (union tui_which_element) <command>: Remove.
8586         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8587         assert.
8588         (free_content_elements): Remove CMD_WIN case.
8589
8590 2019-06-25  Tom Tromey  <tom@tromey.com>
8591
8592         * tui/tui-layout.c (tui_set_layout): Update.
8593         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8594         * tui/tui-data.c (layout_def): Update.
8595
8596 2019-06-25  Tom Tromey  <tom@tromey.com>
8597
8598         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8599         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8600         (tui_source_window_base::set_new_height): Update.
8601         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8602         Update.
8603         (tui_set_locator_fullname, tui_set_locator_info)
8604         (tui_show_frame_info): Update.
8605         * tui/tui-source.c (tui_set_source_content)
8606         (tui_source_is_displayed): Update.
8607         * tui/tui-layout.c (show_source_disasm_command, show_data)
8608         (show_source_or_disasm_and_command): Update.
8609         * tui/tui-disasm.c (tui_set_disassem_content)
8610         (tui_get_begin_asm_address): Update.
8611         * tui/tui-data.h (struct tui_locator_element): Remove.
8612         (union tui_which_element) <locator>: Remove.
8613         (struct tui_locator_window): New.
8614         (tui_locator_win_info_ptr): Change return type.
8615         * tui/tui-data.c (_locator): Change type.
8616         (tui_locator_win_info_ptr): Change return type.
8617         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8618         (tui_alloc_content): Add assert.
8619
8620 2019-06-25  Tom Tromey  <tom@tromey.com>
8621
8622         * tui/tui-winsource.c
8623         (tui_exec_info_window::maybe_allocate_content): New method.
8624         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8625         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8626         (make_source_or_disasm_window): Add cast.
8627         * tui/tui-data.h (union tui_which_element) <simple_string>:
8628         Remove.
8629         (struct tui_source_info): New.
8630         (struct tui_source_window_base) <execution_info>: Change type.
8631         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8632         case, and add assert.
8633         (tui_alloc_content): Add assert.
8634
8635 2019-06-25  Tom Tromey  <tom@tromey.com>
8636
8637         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8638         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8639         * tui/tui-data.c (tui_alloc_win_info): Remove.
8640
8641 2019-06-25  Tom Tromey  <tom@tromey.com>
8642
8643         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8644         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8645         can_highlight.
8646
8647 2019-06-25  Tom Tromey  <tom@tromey.com>
8648
8649         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8650         make_visible_with_new_height method.
8651         (tui_win_info::make_visible_with_new_height): New method.
8652         (tui_source_window_base::do_make_visible_with_new_height)
8653         (tui_data_window::do_make_visible_with_new_height)
8654         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8655         (make_visible_with_new_height): Remove.
8656         (tui_resize_all, tui_adjust_win_heights): Use
8657         make_visible_with_new_height method.
8658         * tui/tui-data.h (struct tui_win_info)
8659         <do_make_visible_with_new_height, make_visible_with_new_height>:
8660         New methods.
8661         (struct tui_source_window_base, struct tui_data_window)
8662         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8663         methods.
8664
8665 2019-06-25  Tom Tromey  <tom@tromey.com>
8666
8667         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8668         method.
8669         (update_tab_width): Call update_tab_width method.
8670         * tui/tui-data.h (struct tui_win_info)
8671         (struct tui_source_window_base) <update_tab_width>: New methods.
8672
8673 2019-06-25  Tom Tromey  <tom@tromey.com>
8674
8675         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8676         parameter.
8677         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8678         parameter.
8679         (tui_gen_win_info::make_visible): Update.
8680         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8681         parameter.
8682         * tui/tui-data.h (enum tui_box): New enum.
8683         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8684
8685 2019-06-25  Tom Tromey  <tom@tromey.com>
8686
8687         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8688         init_and_make_win for EXEC_INFO_WIN.
8689         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8690         longer inline.
8691         (struct tui_win_info) <~tui_win_info>: Inline.
8692         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8693         Don't declare.
8694         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8695         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8696         Remove.
8697         (tui_initialize_static_data): Update.
8698         (~tui_gen_win_info): Handle more cleanup here.
8699         (~tui_source_window_base): Delete "execution_info".
8700         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8701
8702 2019-06-25  Tom Tromey  <tom@tromey.com>
8703
8704         * tui/tui-layout.c (make_command_window): Don't set
8705         can_highlight.
8706         (show_source_disasm_command): Call the reset method.
8707         (show_data): Don't set can_highlight.  Call the reset method.
8708         (tui_gen_win_info::reset): Rename from init_gen_win_info
8709         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8710         (show_source_or_disasm_and_command): Call the reset method.
8711         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8712         (struct tui_cmd_window): Set can_highlight.
8713
8714 2019-06-25  Tom Tromey  <tom@tromey.com>
8715
8716         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8717         from make_visible.
8718         (tui_make_visible, tui_make_invisible): Rewrite.
8719         (tui_win_info::make_visible): Remove.
8720         (tui_source_window_base::make_visible): Update.
8721         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8722         method.  Moved from...
8723         (struct tui_win_info) <make_visible>: ...here.
8724
8725 2019-06-25  Tom Tromey  <tom@tromey.com>
8726
8727         * tui/tui-winsource.c
8728         (tui_source_window_base::do_scroll_horizontal): Remove direction
8729         parameter.
8730         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8731         direction parameter.
8732         * tui/tui-win.c (tui_win_info::forward_scroll)
8733         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8734         (tui_win_info::right_scroll): Update.
8735         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8736         direction parameter.
8737         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8738         direction parameter.
8739         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8740         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8741         Remove direction parameter.
8742         (struct tui_source_window_base, struct tui_source_window)
8743         (struct tui_disasm_window, struct tui_data_window)
8744         (struct tui_cmd_window): Update.
8745
8746 2019-06-25  Tom Tromey  <tom@tromey.com>
8747
8748         * tui/tui-winsource.h (tui_set_exec_info_content)
8749         (tui_show_exec_info_content, tui_erase_exec_info_content)
8750         (tui_clear_exec_info_content, tui_update_exec_info): Change
8751         argument to tui_source_window_base.
8752         * tui/tui-winsource.c (tui_set_exec_info_content)
8753         (tui_show_exec_info_content, tui_erase_exec_info_content)
8754         (tui_clear_exec_info_content, tui_update_exec_info): Change
8755         argument to tui_source_window_base.
8756
8757 2019-06-25  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8760         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8761
8762 2019-06-25  Tom Tromey  <tom@tromey.com>
8763
8764         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8765         check.
8766
8767 2019-06-25  Tom Tromey  <tom@tromey.com>
8768
8769         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8770         type to void.
8771         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8772         type to void.
8773         * tui/tui-source.c (tui_set_source_content): Update.
8774         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8775
8776 2019-06-25  Tom Tromey  <tom@tromey.com>
8777
8778         * tui/tui-win.c (window_name_completer, tui_set_focus)
8779         (tui_all_windows_info): Use name method.
8780         * tui/tui-data.h (struct tui_gen_win_info)
8781         (struct tui_source_window, struct tui_disasm_window)
8782         (struct tui_data_window, struct tui_cmd_window) <name>: New
8783         method.
8784         (tui_win_name): Don't declare.
8785         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8786         (tui_win_name): Remove.
8787
8788 2019-06-25  Tom Tromey  <tom@tromey.com>
8789
8790         * tui/tui-winsource.h (tui_update_source_window)
8791         (tui_update_source_window_as_is): Change parameter type.
8792         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8793         to be a tui_source_window_base.
8794         (tui_update_source_window_as_is): Likewise.
8795         * tui/tui-win.c (make_visible_with_new_height): Update.
8796
8797 2019-06-25  Tom Tromey  <tom@tromey.com>
8798
8799         * tui/tui-winsource.c (tui_erase_source_content)
8800         (tui_show_source_content, tui_show_exec_info_content)
8801         (tui_erase_exec_info_content): Use refresh_window method.
8802         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8803         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8804         from tui_refresh_win.
8805         (tui_data_window::refresh_window): New method.
8806         (tui_win_info::refresh, tui_source_window_base::refresh)
8807         (tui_refresh_all): Use refresh_window method.
8808         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8809         method.
8810         * tui/tui-regs.c (tui_display_register): Call refresh_window
8811         method.
8812         * tui/tui-layout.c (show_source_disasm_command)
8813         (show_source_or_disasm_and_command): Call refresh_window method.
8814         * tui/tui-data.h (struct tui_gen_win_info)
8815         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8816         New method.
8817
8818 2019-06-25  Tom Tromey  <tom@tromey.com>
8819
8820         * tui/tui.c (tui_rl_other_window, tui_enable)
8821         (tui_is_window_visible, tui_get_command_dimension): Update.
8822         * tui/tui-winsource.c (tui_update_source_window_as_is)
8823         (tui_clear_source_content, tui_erase_source_content)
8824         (tui_show_source_line, tui_source_window_base::refill)
8825         (tui_source_window_base::do_scroll_horizontal)
8826         (tui_source_window_base::set_is_exec_point_at)
8827         (tui_update_breakpoint_info, tui_set_exec_info_content)
8828         (tui_alloc_source_buffer, tui_line_is_displayed)
8829         (tui_addr_is_displayed): Update.
8830         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8831         (tui_check_and_display_highlight_if_needed)
8832         (tui_win_info::make_visible, tui_win_info::refresh)
8833         (tui_refresh_all): Update.
8834         * tui/tui-windata.c (tui_first_data_item_displayed)
8835         (tui_delete_data_content_windows, tui_erase_data_content)
8836         (tui_display_all_data, tui_data_window::refresh_all)
8837         (tui_check_data_values): Update.
8838         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8839         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8840         (tui_win_info::backward_scroll, tui_refresh_all_win)
8841         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8842         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8843         (tui_source_window_base::set_new_height)
8844         (tui_data_window::set_new_height)
8845         (make_invisible_and_set_new_height)
8846         (make_visible_with_new_height, new_height_ok)
8847         (parse_scrolling_args): Update.
8848         * tui/tui-stack.c (tui_show_frame_info): Update.
8849         * tui/tui-source.c (tui_set_source_content)
8850         (tui_set_source_content_nil, tui_source_is_displayed)
8851         (tui_source_window::do_scroll_vertical): Update.
8852         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8853         (tui_display_registers_from, tui_display_reg_element_at_line)
8854         (tui_check_register_values, tui_reg_command): Update.
8855         * tui/tui-layout.c (tui_default_win_height)
8856         (show_source_disasm_command, show_data, init_and_make_win)
8857         (show_source_or_disasm_and_command): Update.
8858         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8859         (tui_redisplay_readline, tui_mld_flush)
8860         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8861         (tui_getc): Update.
8862         * tui/tui-disasm.c (tui_set_disassem_content)
8863         (tui_disasm_window::do_scroll_vertical): Update.
8864         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8865         Now virtual.
8866         (struct tui_win_info): Derive from tui_gen_win_info.
8867         <~tui_win_info>: Mark as override.
8868         <generic>: Remove member.
8869         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8870         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8871         (~tui_data_window, ~tui_win_info)
8872         (tui_free_all_source_wins_content): Update.
8873         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8874
8875 2019-06-25  Tom Tromey  <tom@tromey.com>
8876
8877         * tui/tui-layout.c (init_and_make_win): Use new.
8878         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8879         destructor, initializers.
8880         (tui_alloc_generic_win_info): Don't declare.
8881         * tui/tui-data.c (_locator): Add argument to constructor.
8882         (source_win, disasm_win): New globals.
8883         (exec_info): Remove.
8884         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8885         Update.
8886         (tui_alloc_generic_win_info): Remove.
8887         (init_content_element): Use new.
8888         (tui_win_info::tui_win_info): Update.
8889         (free_content_elements) <case DATA_WIN>: Use delete.
8890
8891 2019-06-25  Tom Tromey  <tom@tromey.com>
8892
8893         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8894         * tui/tui-windata.c (tui_first_data_item_displayed)
8895         (tui_delete_data_content_windows): Update.
8896         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8897         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8898         (tui_display_registers_from, tui_check_register_values): Update.
8899         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8900         pointer.
8901         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8902         window.
8903         (tui_free_data_content): Update.
8904         (free_content_elements) <case DATA_WIN>: Free the window.
8905
8906 2019-06-25  Tom Tromey  <tom@tromey.com>
8907
8908         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8909         Update.
8910         * tui/tui-layout.c (make_command_window)
8911         (show_source_disasm_command, show_data, init_and_make_win)
8912         (show_source_or_disasm_and_command): Update.
8913         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8914         method.
8915         <can_highight, is_highlighted>: Now bool.
8916         (tui_set_win_highlight): Don't declare.
8917         * tui/tui-data.c (tui_set_win_highlight): Remove.
8918
8919 2019-06-25  Tom Tromey  <tom@tromey.com>
8920
8921         * tui/tui-wingeneral.c (make_visible): Remove check of window
8922         type.
8923
8924 2019-06-25  Tom Tromey  <tom@tromey.com>
8925
8926         * tui/tui-win.c (tui_win_info::max_height)
8927         (tui_cmd_window::max_height): New methods.
8928         (new_height_ok): Call max_height.
8929         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8930         <max_height>: New method.
8931
8932 2019-06-25  Tom Tromey  <tom@tromey.com>
8933
8934         * tui/tui-win.c (tui_source_window_base::set_new_height)
8935         (tui_data_window::set_new_height): New methods.
8936         (make_invisible_and_set_new_height): Call set_new_height method.
8937         * tui/tui-data.h (struct tui_win_info)
8938         (struct tui_source_window_base, struct tui_data_window)
8939         <set_new_height>: New method.
8940
8941 2019-06-25  Tom Tromey  <tom@tromey.com>
8942
8943         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8944         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8945         tui_refresh_data_win.
8946         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8947         method.
8948         (tui_refresh_all_win): Call the refresh_all method.
8949         (tui_set_focus): Likewise.
8950         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8951         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8952         Likewise.
8953
8954 2019-06-25  Tom Tromey  <tom@tromey.com>
8955
8956         * tui/tui-winsource.h (tui_refill_source_window)
8957         (tui_set_is_exec_point_at): Don't declare.
8958         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8959         (tui_source_window_base::refill): Rename from
8960         tui_refill_source_window.
8961         (tui_source_window_base::do_scroll_horizontal): Update.
8962         (tui_source_window_base::set_is_exec_point_at): Rename from
8963         tui_set_is_exec_point_at.
8964         (tui_update_all_breakpoint_info): Update.
8965         * tui/tui-stack.c (tui_show_frame_info): Update.
8966         * tui/tui-layout.c (show_data): Add cast.
8967         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8968         * tui/tui-data.h (struct tui_source_window_base) <refill,
8969         set_is_exec_point_at>: New methods.
8970         (tui_source_windows, tui_add_to_source_windows): Update types.
8971         (tui_add_to_source_windows): Remove redundant declaration.
8972         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8973         (tui_source_windows): Change return type.
8974         (tui_clear_source_windows_detail): Update.
8975         (tui_add_to_source_windows): Change type of parameter.
8976         (tui_free_all_source_wins_content): Update.
8977
8978 2019-06-25  Tom Tromey  <tom@tromey.com>
8979
8980         * tui/tui-wingeneral.c (tui_win_info::refresh)
8981         (tui_source_window_base::refresh): New methods.
8982         (tui_refresh_all): Call the refresh method.
8983         * tui/tui-data.h (struct tui_win_info)
8984         (struct tui_source_window_base) <refresh>: New method.
8985
8986 2019-06-25  Tom Tromey  <tom@tromey.com>
8987
8988         * tui/tui.h (tui_is_window_visible): Return bool.
8989         * tui/tui.c (tui_is_window_visible): Return bool.
8990         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8991         (tui_make_visible, tui_make_invisible)
8992         (tui_win_info::make_visible)
8993         (tui_source_window_base::make_visible, make_all_visible)
8994         (tui_make_all_visible, tui_make_all_invisible): Update.
8995         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8996         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8997         bool.
8998         (struct tui_win_info, struct tui_source_window_base)
8999         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9000         * tui/tui-data.c (tui_init_generic_part): Update.
9001
9002 2019-06-25  Tom Tromey  <tom@tromey.com>
9003
9004         * tui/tui-wingeneral.c (tui_win_info::make_visible)
9005         (tui_source_window_base::make_visible): New methods.
9006         (make_all_visible): Make method call.
9007         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9008         (struct tui_source_window_base, struct tui_cmd_window): Override
9009         make_visible.
9010         (tui_win_is_source_type): Don't declare.
9011         * tui/tui-data.c (tui_win_is_source_type): Remove.
9012
9013 2019-06-25  Tom Tromey  <tom@tromey.com>
9014
9015         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9016         NULL check.
9017
9018 2019-06-25  Tom Tromey  <tom@tromey.com>
9019
9020         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9021         Inline constructor.  Add initializers for members.
9022         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9023         constructors; now inline in class.
9024
9025 2019-06-25  Tom Tromey  <tom@tromey.com>
9026
9027         * tui/tui-regs.c (tui_show_registers): Update.
9028         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9029         bool.
9030         * tui/tui-data.c (tui_data_window::clear_detail)
9031         (tui_data_window): Update.
9032
9033 2019-06-25  Tom Tromey  <tom@tromey.com>
9034
9035         * tui/tui-windata.c (tui_display_all_data)
9036         (tui_display_data_from_line, tui_display_data_from)
9037         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9038         Update.
9039         * tui/tui-regs.c (tui_last_regs_line_no)
9040         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9041         (tui_show_registers, tui_show_register_group)
9042         (tui_display_registers_from, tui_display_reg_element_at_line)
9043         (tui_display_registers_from_line, tui_check_register_values)
9044         (tui_reg_next, tui_reg_prev): Update.
9045         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9046         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9047         tui_data_window.
9048         (struct tui_win_info) <detail>: Remove.  Add new fields from
9049         tui_data_info.
9050         (TUI_DATA_WIN): Add cast.
9051         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9052         (~tui_data_window): Simplify.
9053
9054 2019-06-25  Tom Tromey  <tom@tromey.com>
9055
9056         * tui/tui-layout.c (show_source_disasm_command)
9057         (show_source_or_disasm_and_command): Update.
9058         * tui/tui-io.c (update_cmdwin_start_line)
9059         (tui_redisplay_readline): Update.
9060         * tui/tui-data.h (struct tui_command_info): Remove.
9061         (struct tui_win_info) <detail>: Remove command_info member.
9062         (struct tui_data_window) <start_line>: New member, from
9063         tui_command_info.
9064         (TUI_CMD_WIN): Add casts.
9065
9066 2019-06-25  Tom Tromey  <tom@tromey.com>
9067
9068         * tui/tui-winsource.c (tui_update_source_window)
9069         (tui_refill_source_window)
9070         (tui_source_window_base::do_scroll_horizontal)
9071         (tui_update_breakpoint_info, tui_set_exec_info_content)
9072         (tui_show_exec_info_content, tui_erase_exec_info_content)
9073         (tui_clear_exec_info_content): Update.
9074         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9075         Update.
9076         * tui/tui-win.c (make_invisible_and_set_new_height)
9077         (make_visible_with_new_height): Update.
9078         * tui/tui-source.c (tui_set_source_content)
9079         (tui_show_symtab_source): Update.
9080         * tui/tui-layout.c (extract_display_start_addr)
9081         (show_source_disasm_command, show_data)
9082         (make_source_or_disasm_window)
9083         (show_source_or_disasm_and_command): Update.
9084         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9085         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9086         "gdbarch".
9087         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9088         to tui_source_window_base.
9089         (struct tui_win_info) <detail>: Remove source_info member.
9090         (struct tui_source_window_base) <has_locator>: Inline.
9091         Move contents from tui_source_info; rename has_locator member to
9092         m_has_locator.
9093         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9094         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9095         header file.
9096         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9097         Simplify.
9098         (tui_free_all_source_wins_content): Cast to
9099         tui_source_window_base.
9100
9101 2019-06-25  Tom Tromey  <tom@tromey.com>
9102
9103         * tui/tui-win.c (make_invisible_and_set_new_height)
9104         (make_visible_with_new_height): Call has_locator method.
9105         * tui/tui-layout.c (show_source_disasm_command, show_data)
9106         (show_source_or_disasm_and_command): Update for bool change.
9107         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9108         (tui_win_info) <has_locator>: New method.
9109         (struct tui_source_window_base) <has_locator>: New method.
9110         (tui_win_has_locator): Don't declare.
9111         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9112         from tui_win_has_locator.
9113         (tui_source_window_base): Use false, not FALSE.
9114
9115 2019-06-25  Tom Tromey  <tom@tromey.com>
9116
9117         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9118         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9119         clear_detail method directly.
9120         (tui_clear_win_detail): Remove.
9121
9122 2019-06-25  Tom Tromey  <tom@tromey.com>
9123
9124         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9125         "this", not TUI_DISASM_WIN.
9126
9127 2019-06-25  Tom Tromey  <tom@tromey.com>
9128
9129         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9130         declare.
9131         * tui/tui-winsource.c
9132         (tui_source_window_base::do_scroll_horizontal): Rename from
9133         tui_horizontal_source_scroll.
9134         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9135         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9136         from tui_vertical_data_scroll.
9137         * tui/tui-win.h (tui_scroll): Don't declare.
9138         * tui/tui-win.c (tui_win_info::forward_scroll)
9139         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9140         (tui_win_info::right_scroll): Rename and update.
9141         (tui_scroll_forward_command, tui_scroll_backward_command)
9142         (tui_scroll_left_command, tui_scroll_right_command): Update.
9143         (tui_scroll): Remove.
9144         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9145         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9146         from tui_vertical_source_scroll.
9147         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9149         from tui_vertical_disassem_scroll.
9150         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9151         do_scroll_horizontal>: New methods.
9152         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9153         Likewise.
9154         (struct tui_source_window_base): Add do_scroll_horizontal.
9155         (struct tui_source_window, struct tui_disasm_window): Add
9156         do_scroll_vertical.
9157         (struct tui_data_window, struct tui_cmd_window): Add
9158         do_scroll_horizontal and do_scroll_vertical.
9159         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9160
9161 2019-06-25  Tom Tromey  <tom@tromey.com>
9162
9163         * tui/tui-data.h (struct tui_source_window_base): New struct.
9164         (struct tui_source_window): Derive from tui_source_window_base.
9165         (struct tui_disasm_window): New struct.
9166         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9167         from tui_source_window::clear_detail.
9168         (tui_source_window_base): Rename from tui_source_window.
9169         (~tui_source_window_base): Rename from ~tui_source_window.
9170         (tui_alloc_win_info): Create a tui_disasm_window.
9171
9172 2019-06-25  Tom Tromey  <tom@tromey.com>
9173
9174         * tui/tui-data.h (struct tui_source_window)
9175         (struct tui_data_window): Declare destructors.
9176         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9177         destructors.
9178         (tui_win_info): Simplify.
9179
9180 2019-06-25  Tom Tromey  <tom@tromey.com>
9181
9182         * tui/tui-winsource.c (tui_display_main)
9183         (tui_update_source_windows_with_addr)
9184         (tui_update_all_breakpoint_info): Update.
9185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9186         (new_height_ok, parse_scrolling_args): Update.
9187         * tui/tui-stack.c (tui_show_frame_info): Update.
9188         * tui/tui-data.h (struct tui_list): Remove.
9189         (tui_source_windows): Return a reference to a std::vector.
9190         * tui/tui-data.c (source_windows): Now a std::vector.
9191         (tui_source_windows): Change return type.
9192         (tui_clear_source_windows): Rewrite.
9193         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9194         (tui_free_all_source_wins_content): Rewrite.
9195
9196 2019-06-25  Tom Tromey  <tom@tromey.com>
9197
9198         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9199         (struct tui_data_window, struct tui_cmd_window): Declare
9200         clear_detail method.
9201         * tui/tui-data.c (tui_source_window::clear_detail)
9202         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9203         methods.
9204         (tui_clear_win_detail): Simplify.
9205
9206 2019-06-25  Tom Tromey  <tom@tromey.com>
9207
9208         * tui/tui-layout.c (make_source_window, make_disasm_window)
9209         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9210         Return the new window.
9211         (show_source_disasm_command, show_data)
9212         (show_source_or_disasm_and_command): Update.
9213
9214 2019-06-25  Tom Tromey  <tom@tromey.com>
9215
9216         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9217         parameter.  Return the new window.
9218         (show_source_disasm_command): Update and remove NULL check.
9219         (show_source_or_disasm_and_command): Update.
9220
9221 2019-06-25  Tom Tromey  <tom@tromey.com>
9222
9223         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9224
9225 2019-06-25  Tom Tromey  <tom@tromey.com>
9226
9227         * tui/tui-data.h (struct tui_win_info): Make constructor
9228         protected.  Make destructor virtual.  Add initializers.
9229         (tui_source_window, tui_data_window, tui_cmd_window): New
9230         classes.
9231         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9232         constructor.  Add "type" parameter.
9233         (tui_source_window, tui_data_window, tui_cmd_window): New
9234         constructors.
9235         (tui_alloc_win_info): Instantiate the appropriate subclass.
9236
9237 2019-06-25  Tom Tromey  <tom@tromey.com>
9238
9239         * tui/tui-win.c (tui_resize_all): Use delete.
9240         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9241         destructor.
9242         (tui_free_window): Don't declare.
9243         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9244         Update.
9245
9246 2019-06-25  Tom Tromey  <tom@tromey.com>
9247
9248         * tui/tui-data.h (struct tui_win_info): Add constructor.
9249         * tui/tui-data.c (tui_alloc_win_info): Use new.
9250         (tui_free_window): Use delete.
9251
9252 2019-06-22  Tom Tromey  <tom@tromey.com>
9253
9254         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9255         declare.
9256         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9257
9258 2019-06-22  Tom Tromey  <tom@tromey.com>
9259
9260         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9261         declare.
9262         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9263
9264 2019-06-22  Tom de Vries  <tdevries@suse.de>
9265
9266         * dwarf2read.c (create_addrmap_from_aranges)
9267         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9268         instead of '%zu'.
9269
9270 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9271
9272         * dwarf2read.h (dwarf2_section_info_def): Remove.
9273         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9274         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9275         std::vector<dwarf2_section_info>.
9276         (struct dwo_file) <~dwo_file>: Remove.
9277         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9278         types field.
9279         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9280         (dwarf2_read_debug_names): Likewise.
9281         (create_debug_types_hash_table): Change parameter type to
9282         array_view, adjust code accordingly.
9283         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9284         (partial_die_info::fixup): Likewise.
9285         (determine_prefix): Likewise.
9286         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9287
9288 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9289
9290         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9291         gdb_bfd_ref_ptr.
9292         <~dwo_file>: Remove call to gdb_bfd_unref.
9293         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9294         gdb_bfd_ref_ptr::get.
9295
9296 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9297
9298         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9299         type to htab_up.
9300         * dwarf2read.c (struct dwo_file): Initialize fields.
9301         <~dwo_file>: New.
9302         (free_dwo_file): Remove, move content to ~dwo_file.
9303         (struct dwo_file_deleter): Remove.
9304         (dwo_file_up>: Remove custom deleter.
9305         (free_dwo_files): Remove.
9306         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9307         dwo_files.
9308         (process_skeletonless_type_units): Call unique_ptr::get.
9309         (allocate_dwo_file_hash_table): Add deleter to created hash
9310         table.  Change return type to htab_up.
9311         (lookup_dwo_file_slot): Don't memset dwo_file, call
9312         unique_ptr::get.
9313         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9314         (create_dwo_unit_in_dwp_v2): Likewise.
9315         (open_and_init_dwo_file): Likewise.
9316         (free_dwo_file_from_slot): Remove.
9317
9318 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9319
9320         * dwarf2read.h (struct dwarf2_section_info) <readin,
9321         is_virtual>: Change type to bool.
9322         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9323         true instead of 1.
9324
9325 2019-06-19  Tom Tromey  <tom@tromey.com>
9326
9327         * tui/tui-data.h (tui_init_content_element): Don't declare.
9328
9329 2019-06-19  Tom Tromey  <tom@tromey.com>
9330
9331         * tui/tui-data.h (tui_init_win_info): Don't declare.
9332
9333 2019-06-19  Tom de Vries  <tdevries@suse.de>
9334
9335         * dwarf2read.h (abstract_to_concrete): Change type to
9336         std::unordered_map<sect_offset, std::vector<sect_offset>,
9337         gdb::hash_enum<sect_offset>>.
9338
9339 2019-06-19  Tom Tromey  <tromey@adacore.com>
9340
9341         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9342         EVAL_AVOID_SIDE_EFFECTS specially.
9343
9344 2019-06-19  Tom Tromey  <tromey@adacore.com>
9345
9346         * source-cache.c (highlighter): New global.
9347         (source_cache::get_source_lines): Create a highlighter on demand.
9348
9349 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9350
9351         * defs.h (deprecated_interactive_hook): Delete declaration.
9352         * interps.c (clear_interpreter_hooks): Remove use of
9353         deprecated_interactive_hook.
9354         * top.c (deprecated_interactive_hook): Delete definition.
9355         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9356
9357 2019-06-18  Tom de Vries  <tdevries@suse.de>
9358
9359         PR gdb/24515
9360         * dwarf2read.h (abstract_to_concrete): Change type from
9361         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9362         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9363         * dwarf2read.c (read_variable): Update.
9364         (dwarf2_fetch_die_loc_sect_off): Update.
9365
9366 2019-06-17  Tom de Vries  <tdevries@suse.de>
9367
9368         PR gdb/24617
9369         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9370         accessing parent[parent_len - 1].
9371
9372 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9373
9374         PR gdb/24364
9375         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9376         call dtrace_process_dof with NULL dof.
9377
9378 2019-06-16  Tom de Vries  <tdevries@suse.de>
9379
9380         PR gdb/24445
9381         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9382
9383 2019-06-16  Tom Tromey  <tom@tromey.com>
9384
9385         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9386         (make_all_visible): Use address of member.
9387
9388 2019-06-16  Tom Tromey  <tom@tromey.com>
9389
9390         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9391         (tui_free_window, free_content, free_content_elements): Remove
9392         unnecessary cast.
9393         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9394         cast.
9395         * tui/tui-regs.c (tui_show_register_group)
9396         (tui_display_registers_from, tui_display_reg_element_at_line):
9397         Remove unnecessary cast.
9398
9399 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * linux-nat.c (normal_mask): Delete.
9402         (_initialize_linux_nat): Don't initialise normal_mask.
9403
9404 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9405
9406         PR gdb/24445
9407         * dwarf-index-write.h (write_psymtabs_to_index): Add
9408         dwz_basename parameter.
9409         * dwarf-index-write.c (write_gdbindex): Move file writing to
9410         write_gdbindex_1.  Change return type void.
9411         (assert_file_size): Move up, remove filename parameter.
9412         (write_gdbindex_1): New function.
9413         (write_debug_names): Change return type to void, call
9414         assert_file_size.
9415         (struct index_wip_file): New struct.
9416         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9417         file logic to index_wip_file.  Write index for dwz file if
9418         needed.
9419         (save_gdb_index_command): Pass basename of dwz file, if present.
9420         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9421         build-id of dwz file, if present.
9422         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9423         (dwarf2_get_dwz_file): Likewise.
9424         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9425         (dwarf2_get_dwz_file): Likewise.
9426
9427 2019-06-16  Tom Tromey  <tom@tromey.com>
9428
9429         * coffread.c (process_coff_symbol): Use xstrdup.
9430         * value.c (create_internalvar): Use xstrdup.
9431
9432 2019-06-16  Tom Tromey  <tom@tromey.com>
9433
9434         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9435         * breakpoint.c (stopin_command, stopat_command)
9436         (until_break_command, decode_location_default): Remove unnecessary
9437         cast.
9438         * utils.c (subset_compare): Remove unnecessary cast.
9439         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9440         cast.
9441         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9442         cast.
9443         * infcmd.c (path_command): Remove unnecessary cast.
9444         * coffread.c (decode_type): Remove unnecessary cast.
9445         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9446         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9447         * tui/tui-stack.c (tui_show_locator_content)
9448         (tui_show_frame_info): Remove unnecessary cast.
9449         * tui/tui-win.c (tui_scroll_forward_command)
9450         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9451         (parse_scrolling_args): Remove unnecessary cast.
9452         * tui/tui-data.c (init_win_info, tui_del_window)
9453         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9454         (free_content_elements): Remove unnecessary cast.
9455         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9456         unnecessary cast.
9457         * tui/tui-source.c (tui_set_source_content)
9458         (tui_vertical_source_scroll): Remove unnecessary cast.
9459         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9460         cast.
9461         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9462         * tui/tui-regs.c (tui_display_registers_from)
9463         (tui_display_register): Remove unnecessary cast.
9464         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9465         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9466         (make_visible): Remove unnecessary cast.
9467         * tui/tui-winsource.c (tui_erase_source_content)
9468         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9469         unnecessary cast.
9470         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9471         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9472         * stabsread.c (read_type, read_array_type, read_range_type):
9473         Remove unnecessary cast.
9474         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9475         (parse_symbol, parse_type, upgrade_type, parse_external)
9476         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9477         unnecessary cast.
9478         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9479
9480 2019-06-16  Tom Tromey  <tom@tromey.com>
9481
9482         * tui/tui-data.c (tui_alloc_generic_win_info)
9483         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9484         checks.
9485
9486 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9487             Andrew Burgess  <andrew.burgess@embecosm.com>
9488
9489         * f-typeprint.c (f_print_type): Don't return early for not
9490         associated or not allocated types.
9491         (f_type_print_varspec_suffix): Add print_rank parameter and print
9492         ranks of array types in case they dangling.
9493         (f_type_print_base): Add print_rank parameter.
9494
9495 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9496
9497         * NEWS: Mention new MI commands.
9498         * break-catch-throw.c (enum exception_event_kind): Move to
9499         breakpoint.h.
9500         (print_mention_exception_catchpoint): Output text as a single
9501         message.
9502         (catch_exception_command_1): Rename to...
9503         (catch_exception_event): ...this, make non-static, update header
9504         command, and change some parameter types.
9505         (catch_catch_command): Update for changes to
9506         catch_exception_command_1.
9507         (catch_throw_command): Likewise.
9508         (catch_rethrow_command): Likewise.
9509         * breakpoint.c (enum exception_event_kind): Delete.
9510         * breakpoint.h (enum exception_event_kind): Moved here from
9511         break-catch-throw.c.
9512         (catch_exception_event): Declare.
9513         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9514         (mi_cmd_catch_throw): New function.
9515         (mi_cmd_catch_rethrow): New function.
9516         (mi_cmd_catch_catch): New function.
9517         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9518         'catch-catch' entries.
9519         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9520         (mi_cmd_catch_rethrow): Declare.
9521         (mi_cmd_catch_catch): Declare.
9522
9523 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9524
9525         * annotate.c (annotate_source_line): Change return type to void,
9526         update implementation to match.
9527         * annotate.h (annotate_source_line): Change return type to void,
9528         update header comment.
9529         * stack.c (print_frame_info): Don't change what frame information
9530         is printed based on whether annotations are on or not.
9531
9532 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9533
9534         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9535         (annotate_source): Make static.
9536         (annotate_source_line): Moved from source.c and renamed from
9537         identify_source_line.  Update the return type.
9538         * annotate.h (annotate_source): Delete declaration.
9539         (annotate_source_line): Declaration moved from source.h, and
9540         renamed from identify_source_line.  Return type updated.
9541         * source.c (identify_source_line): Moved to annotate.c and renamed
9542         to annotate_source_line.
9543         (info_line_command): Remove check of annotation_level.
9544         * source.h (identify_source_line): Move declaration to annotate.h
9545         and rename to annotate_source_line.
9546         * stack.c: Add 'annotate.h' include.
9547         (print_frame_info): Remove check of annotation_level before
9548         calling annotate_source_line.
9549
9550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * source-cache.c (source_cache::get_plain_source_lines): Use
9553         open_source_file_with_line_charpos instead of just
9554         open_source_file, remove call to find_source_lines.
9555         (source_cache::get_source_lines): Likewise.
9556         * source.c (find_source_lines): Make static.
9557         (get_filename_and_charpos): Renamed into...
9558         (open_source_file_with_line_charpos): ..this along with changes to
9559         return a scoped_fd, and some other minor clean ups.
9560         (identify_source_line): Use open_source_file_with_line_charpos.
9561         (search_command_helper): Use open_source_file_with_line_charpos
9562         instead of just open_source_file, remove call to
9563         find_source_lines.
9564         * source.h (open_source_file_with_line_charpos): Declare new
9565         function.
9566         (find_source_lines): Delete declaration.
9567
9568 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * source.c (get_filename_and_charpos): Remove fullname
9571         parameter.
9572         (identify_source_line): Update call to get_filename_and_charpos.
9573
9574 2019-06-14  Tom Tromey  <tromey@adacore.com>
9575
9576         PR gdb/24502:
9577         * ui-style.h (skip_ansi_escape): Update comment.
9578         * ui-file.h (class no_terminal_escape_file): New class.
9579         * ui-file.c (no_terminal_escape_file::write)
9580         (no_terminal_escape_file::puts): New methods.
9581         * cli/cli-logging.c (handle_redirections): Use
9582         no_terminal_escape_file.
9583
9584 2019-06-14  Tom Tromey  <tromey@adacore.com>
9585
9586         * NEWS: Move convenience variable news above Python news.
9587
9588 2019-06-14  Tom Tromey  <tom@tromey.com>
9589
9590         * gnulib: Move directory to top-level.
9591         * configure.ac: Don't configure gnulib.
9592         * configure: Rebuild.
9593         * common/common-defs.h: Use new path to gnulib.
9594         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9595         (GNULIB_H): Remove.
9596         (INCGNU): Look in new gnulib location.
9597         (HFILES_NO_SRCDIR): Remove gnulib files.
9598         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9599         (generated_files): Remove GNULIB_H.
9600         ($(LIBGNU), all-lib): Remove targets.
9601         (distclean): Don't mention GNULIB_BUILDDIR.
9602         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9603
9604 2019-06-14  Tom Tromey  <tromey@adacore.com>
9605
9606         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9607         Warn if symbol file does not provide any symbols.
9608
9609 2019-06-14  Tom Tromey  <tromey@adacore.com>
9610
9611         * source.c (find_and_open_source): Respect basenames_may_differ.
9612
9613 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9614
9615         * annotate.c (annotate_breakpoints_invalid): Make use of
9616         scoped_restore_terminal_state.
9617         (annotate_frames_invalid): Likewise.
9618
9619 2019-06-14  Tom Tromey  <tromey@adacore.com>
9620
9621         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9622         allow assignment to an internalvar.
9623
9624 2019-06-14  Tom Tromey  <tromey@adacore.com>
9625
9626         * ada-lex.l: Allow "_" in attribute names.
9627
9628 2019-06-14  Tom Tromey  <tromey@adacore.com>
9629
9630         PR gdb/24653:
9631         * regcache.c (registers_changed): Don't call alloca.
9632         * top.c (execute_command): Don't call alloca.
9633
9634 2019-06-13  Pedro Alves  <palves@redhat.com>
9635
9636         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9637         'expression'.  When parsing an expression, error out if there's
9638         junk after "unlimited".
9639         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9640         (do_set_command): Adjust calls to is_unlimited_literal.
9641
9642 2019-06-13  Pedro Alves  <palves@redhat.com>
9643
9644         * compile/compile.c (make_compile_options_def_group): Add braces
9645         around array_view initializer.
9646         * thread.c (make_thread_apply_all_options_def_group)
9647         (make_thread_apply_all_options_def_group): Likewise.
9648
9649 2019-06-13  Pedro Alves  <palves@redhat.com>
9650
9651         * NEWS (New commands): Mention "maint test-options
9652         require-delimiter", "maint test-options unknown-is-error", "maint
9653         test-options unknown-is-operand" and "maint show
9654         test-options-completion-result".
9655         (New command options, command completion): New section.
9656         (Completion improvements): New section.
9657         Mention that you can abbreviate "unlimited".
9658
9659 2019-06-13  Pedro Alves  <palves@redhat.com>
9660
9661         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9662         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9663         * unittests/cli-utils-selftests.c (test_parse_flags)
9664         (test_parse_flags_qcs): Delete.
9665         (test_cli_utils): Don't call deleted functions.
9666
9667 2019-06-13  Pedro Alves  <palves@redhat.com>
9668
9669         * thread.c: Include "cli/cli-option.h".
9670         (tp_array_compar_ascending): Global.
9671         (tp_array_compar): Delete function.
9672         (tp_array_compar_ascending, tp_array_compar_descending): New
9673         functions.
9674         (ascending_option_def, qcs_flag_option_def)
9675         (thr_qcs_flags_option_defs)
9676         (make_thread_apply_all_options_def_group)
9677         (make_thread_apply_options_def_group): New.
9678         (thread_apply_all_command): Use gdb::option::process_options.
9679         (thread_apply_command_completer)
9680         (thread_apply_all_command_completer): New.
9681         (thread_apply_command): Use gdb::option::process_options.
9682         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9683         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9684         to generate help text of "thread apply".  Adjust "taas"'s help.
9685         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9686         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9687
9688 2019-06-13  Pedro Alves  <palves@redhat.com>
9689
9690         * thread.c (thread_apply_command): Check for invalid TID with
9691         isdigit instead of !isalpha.
9692
9693 2019-06-13  Pedro Alves  <palves@redhat.com>
9694
9695         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9696         (validate_flags_qcs): New.
9697         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9698         (validate_flags_qcs): Declare.
9699         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9700         (make_frame_apply_options_def_group): New.
9701         (frame_apply_command_count): Process options with
9702         gdb::option::process_options.
9703         (frame_apply_completer): New.
9704         (frame_apply_level_completer, frame_apply_all_completer)
9705         (frame_apply_completer): New.
9706         (_initialize_stack): Update help of "frame apply", "frame apply
9707         level", "frame apply all" and "faas" to mention supported options
9708         and install command completers.
9709         * stack.h (frame_apply_all_completer): Declare.
9710         * thread.c: Include "stack.h".
9711         (tfaas_command): Add "--".
9712         (_initialize_thread): Update help "tfaas" to mention supported
9713         options and install command completer.
9714
9715 2019-06-13  Pedro Alves  <palves@redhat.com>
9716
9717         * completer.c (complete_nested_command_line): New.
9718         (gdb_completion_word_break_characters_throw): Add assertion.
9719         * completer.h (complete_nested_command_line): Declare.
9720
9721 2019-06-13  Pedro Alves  <palves@redhat.com>
9722
9723         * stack.c (parse_backtrace_qualifiers): New.
9724         (backtrace_command): Use it.
9725         (backtrace_command_completer): Complete on qualifiers.
9726
9727 2019-06-13  Pedro Alves  <palves@redhat.com>
9728
9729         * frame.c: Include "cli/cli-option.h.
9730         (user_set_backtrace_options): New.
9731         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9732         Delete.
9733         (get_prev_frame): Adjust.
9734         (boolean_option_def, uinteger_option_def)
9735         (set_backtrace_option_defs): New.
9736         (_initialize_frame): Adjust and use
9737         gdb::option::add_setshow_cmds_for_options to install "set
9738         backtrace past-main" and "set backtrace past-entry".
9739         * frame.h: Include "cli/cli-option.h".
9740         (struct frame_print_options): Forward declare.
9741         (print_frame_arguments_all, print_frame_arguments_scalars)
9742         (print_frame_arguments_none): Declare.
9743         (print_entry_values): Delete declaration.
9744         (struct frame_print_options, user_frame_print_options): New.
9745         (struct set_backtrace_options): New.
9746         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9747         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9748         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9749         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9750         (list_args_or_locals): Add frame_print_options parameter.
9751         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9752         * python/py-framefilter.c (enumerate_args): Pass down
9753         USER_FRAME_PRINT_OPTIONS.
9754         * stack.c: Include "cli/cli-option.h".
9755         (print_frame_arguments_all, print_frame_arguments_scalars)
9756         (print_frame_arguments_none): Declare.
9757         (print_raw_frame_arguments, print_entry_values): Delete.
9758         (user_frame_print_options): New.
9759         (boolean_option_def, enum_option_def, frame_print_option_defs):
9760         New.
9761         (struct backtrace_cmd_options): New.
9762         (bt_flag_option_def): New.
9763         (backtrace_command_option_defs): New.
9764         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9765         (print_frame_arg, read_frame_arg, print_frame_args)
9766         (print_frame_info, print_frame): Add frame_print_options parameter
9767         and use it.
9768         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9769         (backtrace_command_1): Add frame_print_options and
9770         backtrace_cmd_options parameters and use them.
9771         (make_backtrace_options_def_group): New.
9772         (backtrace_command): Process command options with
9773         gdb::option::process_options.
9774         (backtrace_command_completer): New.
9775         (_initialize_stack): Extend "backtrace"'s help to mention
9776         supported options.  Install completer for "backtrace".
9777         Install some settings commands with add_setshow_cmds_for_options.
9778
9779 2019-06-13  Pedro Alves  <palves@redhat.com>
9780
9781         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9782         and that "set/show print raw frame-arguments" are now deprecated.
9783
9784         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9785         command.
9786         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9787         * stack.c (_initialize_stack): Install "set/show print
9788         raw-frame-arguments", and deprecate "set/show print raw
9789         frame-arguments".
9790         * valprint.c (_initialize_valprint): Deprecate "set/show print
9791         raw".
9792
9793 2019-06-13  Pedro Alves  <palves@redhat.com>
9794
9795         * compile/compile.c (struct compile_options): New.
9796         (compile_flag_option_def, compile_command_option_defs)
9797         (make_compile_options_def_group): New.
9798         (compile_file_command): Handle options with
9799         gdb::option::process_options.
9800         (compile_file_command_completer): New function.
9801         (compile_code_command): Handle options with
9802         gdb::option::process_options.
9803         (compile_code_command_completer): New function.
9804         (_initialize_compiler): Install completers for "compile code" and
9805         "compile file".  Mention available options in "compile code" and
9806         "compile code"'s help.
9807         * completer.c (advance_to_completion_word): New, factored out from
9808         ...
9809         (advance_to_expression_complete_word_point): ... this.
9810         (advance_to_filename_complete_word_point): New.
9811         * completer.h (advance_to_filename_complete_word_point): New
9812         declaration.
9813
9814 2019-06-13  Pedro Alves  <palves@redhat.com>
9815
9816         * compile/compile.c: Include "cli/cli-option.h".
9817         (compile_print_value): Scope data pointer is now a
9818         value_print_options pointer; adjust.
9819         (compile_print_command): Process options.  Scope data pointer is
9820         now a value_print_options pointer; adjust.
9821         (_initialize_compile): Update "compile print"'s help to include
9822         supported options.  Install a completer for "compile print".
9823         * cp-valprint.c (show_vtblprint, show_objectprint)
9824         (show_static_field_print): Delete.
9825         (_initialize_cp_valprint): Don't install "set print
9826         static-members", "set print vtbl", "set print object" here.
9827         * printcmd.c: Include "cli/cli-option.h" and
9828         "common/gdb_optional.h".
9829         (print_command_parse_format): Rework to fill in a
9830         value_print_options instead of a format_data.
9831         (print_value): Change parameter type from format_data pointer to
9832         value_print_options reference.  Adjust.
9833         (print_command_1): Process options.  Adjust to pass down a
9834         value_print_options.
9835         (print_command_completer): New.
9836         (_initialize_printcmd): Install print_command_completer as
9837         handle_brkchars completer for the "print" command.  Update
9838         "print"'s help to include supported options.
9839         * valprint.c: Include "cli/cli-option.h".
9840         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9841         here from cp-valprint.c.
9842         (boolean_option_def, uinteger_option_def)
9843         (value_print_option_defs, make_value_print_options_def_group):
9844         New.  Use gdb::option::add_setshow_cmds_for_options to install
9845         "set print elements", "set print null-stop", "set print repeats",
9846         "set print pretty", "set print union", "set print array", "set
9847         print address", "set print symbol", "set print array-indexes".
9848         * valprint.h: Include <string> and "cli/cli-option.h".
9849         (make_value_print_options_def_group): Declare.
9850         (print_value): Change parameter type from format_data pointer to
9851         value_print_options reference.
9852         (print_command_completer): Declare.
9853
9854 2019-06-13  Pedro Alves  <palves@redhat.com>
9855
9856         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9857         (COMMON_SFILES): Add maint-test-settings.c.
9858         * cli/cli-decode.c (boolean_enums): New global, factored out from
9859         ...
9860         (add_setshow_boolean_cmd): ... here.
9861         * cli/cli-decode.h (boolean_enums): Declare.
9862         * cli/cli-option.c: New file.
9863         * cli/cli-option.h: New file.
9864         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9865         factored out from ...
9866         (parse_cli_boolean_value(const char *)): ... this.
9867         (is_unlimited_literal): Change parameter type to pointer to
9868         pointer.  Adjust and advance ARG pointer.
9869         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9870         (parse_cli_var_enum): New, factored out from ...
9871         (do_set_command): ... this.  Adjust.
9872         * cli/cli-setshow.h (parse_cli_boolean_value)
9873         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9874         (parse_cli_var_enum): Declare.
9875         * cli/cli-utils.c: Include "cli/cli-option.h".
9876         (get_ulongest): New.
9877         * cli/cli-utils.h (get_ulongest): Declare.
9878         (check_for_argument): New overloads.
9879         * maint-test-options.c: New file.
9880
9881 2019-06-13  Pedro Alves  <palves@redhat.com>
9882
9883         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9884         parse a range if "-" is at the end of the string.
9885
9886 2019-06-13  Pedro Alves  <palves@redhat.com>
9887
9888         * cli/cli-setshow.c (parse_auto_binary_operation)
9889         (parse_cli_boolean_value): Don't allow "o".
9890
9891 2019-06-13  Pedro Alves  <palves@redhat.com>
9892
9893         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9894         * NEWS: Mention maint test-settings KIND.
9895         * maint-test-settings.c: New file.
9896
9897 2019-06-13  Pedro Alves  <palves@redhat.com>
9898
9899         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9900         completer.
9901         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9902         "set" completers.
9903
9904 2019-06-13  Pedro Alves  <palves@redhat.com>
9905
9906         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9907         after item.
9908
9909 2019-06-13  Pedro Alves  <palves@redhat.com>
9910
9911         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9912
9913 2019-06-13  Pedro Alves <palves@redhat.com>
9914
9915         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9916         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9917         call.
9918         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9919         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9920         calls.
9921         (check_for_argument): Skip spaces after argument.
9922
9923 2019-06-13  Pedro Alves  <palves@redhat.com>
9924
9925         * thread.c (thread_apply_command): Adjust TID parsing.
9926         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9927         detected before end of string.
9928         (tid_is_in_list): Error out if LIST is invalid.
9929
9930 2019-06-13  Pedro Alves  <palves@redhat.com>
9931
9932         * completer.c (complete_line_internal_1): Rewind completion word
9933         point.
9934         (completion_tracker::advance_custom_word_point_by): Change
9935         parameter type to int.
9936         * completer.h (completion_tracker::advance_custom_word_point_by):
9937         Likewise.
9938
9939 2019-06-13  Pedro Alves  <palves@redhat.com>
9940
9941         * completer.c (advance_to_completion_word): Handle delimiters.
9942
9943 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9944
9945         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9946
9947 2019-06-11  Tom Tromey  <tom@tromey.com>
9948
9949         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9950         (xmalloc_failed): Move to alloc.c.
9951         * alloc.c: New file.
9952         * Makefile.in (COMMON_SFILES): Add alloc.c.
9953
9954 2019-06-11  Tom Tromey  <tom@tromey.com>
9955
9956         * nat/linux-waitpid.c: Don't include server.h.
9957         (linux_debug): Remove.
9958         (my_waitpid): Update.
9959
9960 2019-06-11  Tom Tromey  <tromey@adacore.com>
9961
9962         * infcall.c (_initialize_infcall): Remove trailing newline from
9963         help.
9964         * user-regs.c (_initialize_user_regs): Remove trailing newline
9965         from help.
9966         * typeprint.c (_initialize_typeprint): Remove trailing newline
9967         from help.
9968         * reverse.c (_initialize_reverse): Remove trailing newlines from
9969         help.
9970         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9971         from help.
9972         * language.c (add_set_language_command): Remove trailing newline
9973         from help.
9974         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9975         help.
9976         * disasm.c (_initialize_disasm): Remove trailing newline from
9977         help.
9978         * top.c (init_main): Remove trailing newline from help.
9979         * interps.c (_initialize_interpreter): Remove trailing newline
9980         from help.
9981         * btrace.c (_initialize_btrace): Remove trailing newlines from
9982         help.
9983         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9984         from help.
9985         * python/python.c (_initialize_python): Remove trailing newline
9986         from help.
9987         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9988         help.
9989         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9990         from help.  Reformat some text.
9991         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9992         from help.
9993         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9994         newline from help.
9995
9996 2019-06-11  Tom Tromey  <tromey@adacore.com>
9997
9998         * darwin-nat.c (darwin_decode_exception_message)
9999         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10000
10001 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10002
10003         * valops.c (value_slice): Check for not allocated or not
10004         associated values.
10005
10006 2019-06-10  Tom de Vries  <tdevries@suse.de>
10007
10008         PR gdb/24618
10009         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10010         sure an empty slot (defined by a 32-bit zero pair) is recognized as
10011         invalid.
10012
10013 2019-06-10  Tom de Vries  <tdevries@suse.de>
10014
10015         PR gdb/24611
10016         * linespec.c (linespec_lexer_lex_string): Remove incorrect
10017         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
10018
10019 2019-06-10  Tom de Vries  <tdevries@suse.de>
10020
10021         PR symtab/24545
10022         * symtab.c (struct demangled_name_entry): Add language field.
10023         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
10024         static minimal symbol".  Set and use language field.
10025
10026 2019-06-10  Tom Tromey  <tromey@adacore.com>
10027
10028         * ada-lang.c (_initialize_ada_language): Update help text.
10029
10030 2019-06-10  Tom Tromey  <tromey@adacore.com>
10031
10032         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10033         with a newline.
10034         * guile/guile.c (handle_boot_error): Don't end warning with a
10035         newline.
10036         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10037         warning with a newline.
10038         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10039         newline.
10040         (s12z_frame_cache): Likewise.
10041         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10042         a newline.
10043         * solib-svr4.c (disable_probes_interface): Don't end warning with
10044         a newline.
10045         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10046         newline.
10047         * python/python.c (do_finish_initialization): Don't end warning
10048         with a newline.
10049
10050 2019-06-10  Tom Tromey  <tom@tromey.com>
10051
10052         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10053         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10054         gdbpy_enter.
10055
10056 2019-06-10  Tom Tromey  <tromey@adacore.com>
10057
10058         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10059         data.
10060         (elf_new_init): Don't call stabsread_new_init.
10061         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10062         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10063         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10064
10065 2019-06-10  Tom de Vries  <tdevries@suse.de>
10066
10067         PR symtab/16264
10068         PR symtab/24517
10069         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10070
10071 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10072
10073         * source.c (find_and_open_source): Also rewrite relative file
10074         names.
10075
10076 2019-04-26  Amos Bird  <amosbird@gmail.com>
10077
10078         * annotate.c (annotate_thread_exited): Add "thread-exited"
10079         annotation.
10080
10081 2019-06-06  Tom Tromey  <tromey@adacore.com>
10082
10083         * maint.h (class scoped_command_stats): Use
10084         DISABLE_COPY_AND_ASSIGN.
10085         <print_time>: New method.
10086         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10087         print_time.
10088         (scoped_command_stats::print_time): New method.
10089
10090 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10091
10092         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10093         instructions of lengths 6 or 8 bytes.
10094
10095 2019-06-04  Pedro Alves  <palves@redhat.com>
10096
10097         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10098
10099         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10100         * breakpoint.c (condition_completer): Likewise.
10101         * cli/cli-dump.c (scan_expression): Likewise.
10102         * common/filestuff.c (mkdir_recursive): Likewise.
10103         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10104         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10105         (gdb_abspath): Likewise.
10106         * compile/compile-cplus-types.c
10107         (compile_cplus_instance::decl_name): Likewise.
10108         * completer.c (complete_explicit_location):
10109         (signal_completer, reg_or_group_completer_1): Likewise.
10110         * cp-support.c (cp_remove_params_if_any): Likewise.
10111         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10112         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10113         * infcmd.c (strip_bg_char): Likewise.
10114         * linespec.c (copy_token_string): Likewise.
10115         * mi/mi-main.c (output_cores): Likewise.
10116         * psymtab.c (psymtab_search_name):
10117         * symfile.c (test_set_ext_lang_command): Likewise.
10118         * target.c (target_fileio_read_stralloc): Likewise.
10119         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10120         * value.c (complete_internalvar): Likewise.
10121
10122 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10123
10124         Add objfile property to gdb.Type.
10125         * NEWS: Mention Python API addition.
10126         * python/py-type.c (typy_get_objfile): New method.
10127
10128 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10129
10130         * NEWS: Mention the new set|show style [title|highlight].
10131         Mention changes to "show style", "help" and "apropos".
10132
10133 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10134
10135         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10136         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10137         instead of print_help_for_command.
10138         (print_doc_of_command): New function.
10139         (help_list): Add 'apropos -v word' suggestion.
10140         (print_help_for_command): Style the command name using title style.
10141         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10142         (_initialize_cli_cmds): Describe -v in apropos_command help.
10143
10144 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10145
10146         * cli/cli-style.h (cli_style_option): Add name in constructor,
10147         add m_name class member, add constructor with intensity,
10148         add name class function.
10149         (cli_style_option::add_setshow_commands): Remove name argument.
10150         (highlight_style, title_style): New styles.
10151         * cli/cli-style.c (do_show): New function that shows a style
10152         characteristic styling the style name with itself.
10153         (set_style_name): New function.
10154         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10155         Update all callers according to the changes in cli/cli-style.h.
10156         * utils.h (fputs_highlighted): New function.
10157         * utils.c (fputs_highlighted): Likewise.
10158
10159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10160
10161         * NEWS: Mention new pipe command and new convenience variables.
10162
10163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10164
10165         * cli/cli-cmds.c (pipe_command): New function.
10166         (_initialize_cli_cmds): Call add_com for pipe_command.
10167         Define | as an alias for pipe.
10168         (exit_status_set_internal_vars): New function.
10169         (shell_escape): Call exit_status_set_internal_vars.
10170         cli/cli-decode.c (find_command_name_length): Recognize | as
10171         a single character command.
10172
10173 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10174
10175         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10176         top.c (execute_command_to_ui_file): New function, mostly a copy
10177         of execute_command_to_string.
10178         (execute_command_to_string): Implement by calling
10179         execute_command_to_ui_file.
10180
10181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10182
10183         * top.h (saved_command_line): Remove declaration.
10184         * top.c (previous_saved_command_line, previous_repeat_arguments):
10185         New variables.
10186         (saved_command_line): Make static, define together with other
10187         'repeat variables'.
10188         (dont_repeat): Clear repeat_arguments.
10189         (repeat_previous, get_saved_command_line, save_command_line):
10190         New functions.
10191         (gdb_init): Initialize saved_command_line
10192         and previous_saved_command_line.
10193         * main.c (captured_main_1): Remove saved_command_line initialization.
10194         * event-top.c (handle_line_of_input): Update to use
10195         the new 'repeat' related functions instead of direct access to
10196         saved_command_line.
10197         * command.h (repeat_previous, get_saved_command_line,
10198         save_command_line): New declarations.
10199         (dont_repeat): Add comment.
10200
10201 2019-05-30  Tom Tromey  <tromey@adacore.com>
10202
10203         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10204         Fix comment.
10205         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10206
10207 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10208
10209         PR cli/24587
10210         * completer.c (complete): Initialize variable word.
10211
10212 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10213
10214         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10215         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10216         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10217         'body' is NULL to the outter 'if', protecting the '!is_define'
10218         situation as well.
10219
10220 2019-05-29  Tom Tromey  <tromey@adacore.com>
10221
10222         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10223         (dwarf_unknown): New function.
10224         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10225         (dwarf_type_encoding_name): Use dwarf_unknown.
10226
10227 2019-05-29  Tom Tromey  <tromey@adacore.com>
10228
10229         PR c++/20020:
10230         * cp-valprint.c (cp_print_value_fields): Call
10231         cp_print_static_field inside "try".
10232
10233 2019-05-29  Tom Tromey  <tromey@adacore.com>
10234
10235         * inflow.c (struct terminal_info): Add default operator=.
10236         * configure: Rebuild.
10237         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10238         -Wdeprecated-copy-dtor, -Wredundant-move.
10239
10240 2019-05-29  Tom Tromey  <tromey@adacore.com>
10241
10242         * NEWS: Add entry.
10243         * infcmd.c (print_return_value_1): Handle finish_print
10244         option.
10245         (show_print_finish): New function.
10246         (_initialize_infcmd): Add "set/show print finish" commands.
10247         * valprint.c (user_print_options): Initialize new member.
10248         * valprint.h (struct value_print_options) <finish_print>: New
10249         member.
10250
10251 2019-05-28  Tom Tromey  <tromey@adacore.com>
10252
10253         * ada-lang.c (ada_remove_Xbn_suffix)
10254         (find_old_style_renaming_symbol)
10255         (parse_old_style_renaming): Remove.
10256         (ada_find_renaming_symbol): Don't call
10257         find_old_style_renaming_symbol.
10258         (ada_is_renaming_symbol): Rename from
10259         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10260         bool.  Now static.
10261         (ada_read_var_value): Update and simplify.
10262         * ada-exp.y (write_var_or_type): Remove old code.
10263
10264 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10265
10266         PR gdb/25010
10267         * event-top.c: Remove include comment.
10268         * inflow.c (class scoped_ignore_sigttou): Move from here...
10269         * inflow.h (class scoped_ignore_sigttou): ...to here.
10270         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10271         * top.c:  Remove include comment.
10272
10273 2019-05-27  Tom Tromey  <tom@tromey.com>
10274
10275         * NEWS: Fix typo.
10276
10277 2019-05-22  Tom Tromey  <tromey@adacore.com>
10278
10279         * target.c (target_follow_exec): Constify parameter.
10280         * target-delegates.c: Rebuild.
10281         * remote.c (remote_target::follow_exec): Constify parameter.
10282         * infrun.c (follow_exec): Constify parameter.
10283         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10284         (target_follow_exec): Likewise.
10285
10286 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10287
10288         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10289         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10290
10291 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10292
10293         * NEWS: Add debugredirect and testsuite sections.
10294
10295 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10296
10297         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10298         target descriptions using exclusively floating point register name
10299         aliases.
10300
10301 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10302
10303         PR gdb/18644:
10304         * f-lang.c (build_fortran_types): Handle the case where
10305         gdbarch_floatformat_for_type returns a nullptr.
10306
10307 2019-05-21  Tom de Vries  <tdevries@suse.de>
10308
10309         PR cli/24587
10310         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10311
10312 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10313
10314         PR gdb/18644:
10315         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10316         16-byte floats.
10317         * i386-tdep.c (i386_floatformat_for_type): Use
10318         floatformats_ia64_quad for the 16-byte floating point component
10319         within a fortran 32-byte complex number.
10320
10321 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10324         delete default constructor.
10325         (find_partial_die): Update to return const struct.
10326         (partial_die_parent_scope): Move variable declaration into scope
10327         of its use and change its type to auto.
10328         (guess_partial_die_structure_name): Likewise.
10329         (partial_die_info::fixup): Likewise.
10330
10331 2019-05-17  Tom Tromey  <tromey@adacore.com>
10332
10333         * source.c (find_and_open_source): Remove cast.
10334
10335 2019-05-17  Tom Tromey  <tromey@adacore.com>
10336
10337         * annotate.c (annotate_source): Make "filename" const.
10338         * annotate.h (annotate_source): Use const.
10339
10340 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10341
10342         * disasm.c (set_disassembler_options): Send errors to stderr.
10343
10344 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10345
10346         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10347         (cli_interp_base::set_logging): Check debug_redirect.
10348         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10349         * cli/cli-logging.c (debug_redirect): Add static variable.
10350         (pop_output_files): Add default param.
10351         (handle_redirections): Print debug setting.
10352         (show_logging_command): Likewise.
10353         (_initialize_cli_logging): Add debugredirect command.
10354         * interps.c (current_interp_set_logging): Add debug_redirect
10355         parameter.
10356         * interps.h (set_logging): Add debug_redirect parameter.
10357         (current_interp_set_logging): Likewise.
10358         * mi/mi-common.h: Likewise.
10359         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10360
10361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10362             Tom Tromey  <tromey@adacore.com>
10363
10364         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10365         directly.
10366         * cli/cli-interp.h (make_logging_output): Remove declaration.
10367         * cli/cli-logging.c (make_logging_output): Remove function.
10368         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10369         directly.
10370         * ui-file.c (tee_file::tee_file): Remove bools.
10371         (tee_file::~tee_file): Remove deletes.
10372         * ui-file.h (tee_file): Remove bools.
10373
10374 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10375
10376         * mi/mi-cmds.h (mi_cmd_complete): New function.
10377         * mi/mi-main.c (mi_cmd_complete): Likewise.
10378         * mi/mi-cmds.c: Define new MI command -complete.
10379         * NEWS: Mention new -complete command.
10380
10381 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10382
10383         * completer.h (complete): New function.
10384         * completer.c (complete): Likewise.
10385         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10386         function defined in completer.h.
10387
10388 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10389
10390         * MAINTAINERS (Write After Approval): Add myself.
10391
10392 2019-05-17  Tom de Vries  <tdevries@suse.de>
10393
10394         PR gdb/24094
10395         * dwarf2read.c (struct cu_partial_die_info): New struct.
10396         (find_partial_die): Return cu_partial_die_info.
10397         (partial_die_parent_scope, guess_partial_die_structure_name)
10398         (partial_die_info::fixup): Handle new return type of find_partial_die.
10399
10400 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10401
10402         PR breakpoints/24541
10403         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10404         "std::string", simplifying the algorithm.
10405
10406 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10407
10408         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10409         (stap_static_probe_ops::get_probes): Likewise.
10410
10411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10412
10413         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10414         '-')" and "else if".
10415         (stap_parse_single_operand): Join checks for
10416         "gdbarch_stap_parse_special_token_p" and
10417         "gdbarch_stap_parse_special_token" in the same "if" statement.
10418         Invert check when verifying for operation on register
10419         displacement.
10420
10421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10422
10423         * stap-probe.c (stap_get_opcode): Update comment.
10424         (stap_get_expected_argument_type): Likewise.
10425         (handle_stap_probe): Likewise.
10426
10427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10428
10429         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10430         return type to 'bool'.  Adjust comment.  Use 'bool' when
10431         appropriate.
10432         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10433         * stap-probe.c (stap_parse_argument_1): Likewise.
10434         (stap_is_operator): Likewise.
10435         (stap_is_generic_prefix): Likewise.
10436         (stap_is_register_prefix): Likewise.
10437         (stap_is_register_indirection_prefix): Likewise.
10438         (stap_is_integer_prefix): Likewise.
10439         (stap_generic_check_suffix): Likewise.
10440         (stap_check_integer_suffix): Likewise.
10441         (stap_check_register_suffix): Likewise.
10442         (stap_check_register_indirection_suffix): Likewise.
10443         (stap_parse_register_operand): Likewise.
10444         (stap_parse_single_operand): Likewise.
10445         (stap_parse_argument_1): Likewise.
10446         (stap_probe::get_argument_count): Likewise.
10447         (stap_is_operator): Likewise.
10448
10449 2019-05-16  Tom Tromey  <tromey@adacore.com>
10450
10451         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10452         keyword to foreach.
10453
10454 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10455
10456         * linux-thread-db.c (try_thread_db_load_1): Change return type
10457         to bool.
10458         (try_thread_db_load): Likewise.
10459         (try_thread_db_load_from_pdir_1): Likewise.
10460         (try_thread_db_load_from_pdir): Likewise.
10461         (try_thread_db_load_from_sdir): Likewise.
10462         (try_thread_db_load_from_dir): Likewise.
10463         (thread_db_load_search): Likewise.
10464         (has_libpthread): Likewise.
10465         (thread_db_load): Likewise.
10466
10467 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10468
10469         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10470         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10471         NULL, and complain/return if that's the case.
10472
10473 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10474
10475         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10476         (advance, posn, abstract_read_memory): New functions.
10477         [struct mem_read_abstraction]: New struct.
10478         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10479
10480 2019-05-14  Tom Tromey  <tromey@adacore.com>
10481
10482         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10483         value is not lval_memory.
10484
10485 2019-05-14  Tom Tromey  <tromey@adacore.com>
10486
10487         * solib.c (info_sharedlibrary_command): Style the file name.
10488
10489 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10490
10491         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10492         (aarch64_vnv_type): Likewise.
10493         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10494         * common/tdesc.c: Likewise.
10495         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10496         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10497         * features/aarch64-fpu.xml: Add ieee half view.
10498         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10499         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10500         * gdbtypes.h (struct builtin_type): Likewise.
10501         (struct objfile_type): Likewise.
10502
10503 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10504
10505         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10506         typo.
10507         * location.h (string_to_event_location): Likewise.
10508
10509 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10510
10511         GDB 8.3 released.
10512
10513 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10514
10515         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10516         New variable declaration.
10517         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10518         New variable.
10519         (print_one_breakpoint): Use ui_out::test_flags and new global
10520         variable to compute use_fixed_output.
10521         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10522         Remove.
10523         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10524         (mi_multi_location_breakpoint_output_fixed): Remove.
10525         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10526         new variable.
10527         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10528         fix_multi_location_breakpoint_output flag if version >= 3.
10529         * ui-out.h (enum ui_out_flag)
10530         <fix_multi_location_breakpoint_output>: New enumerator.
10531
10532 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10533
10534         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10535
10536 2019-05-10  Tom Tromey  <tromey@adacore.com>
10537
10538         * ada-lang.c (catch_ada_completer): New function.
10539         (_initialize_ada_language): Use it.
10540
10541 2019-05-10  Tom Tromey  <tromey@adacore.com>
10542
10543         * thread.c (print_thread_info): Make "requested_threads" const.
10544         * gdbthread.h (print_thread_info): Make "requested_threads"
10545         const.
10546         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10547         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10548
10549 2019-05-08  Tom Tromey  <tom@tromey.com>
10550
10551         * gdbtypes.c (objfile_type_data): Change type.
10552         (objfile_type, _initialize_gdbtypes): Update.
10553
10554 2019-05-08  Tom Tromey  <tom@tromey.com>
10555
10556         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10557         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10558         (_initialize_dwarf2_frame): Update.
10559
10560 2019-05-08  Tom Tromey  <tom@tromey.com>
10561
10562         * objc-lang.c (objc_objfile_data): Change type.
10563         (find_methods): Update.
10564         (_initialize_objc_lang): Remove.
10565
10566 2019-05-08  Tom Tromey  <tom@tromey.com>
10567
10568         * stabsread.c (rs6000_builtin_type_data): Change type.
10569         (rs6000_builtin_type, _initialize_stabsread): Update.
10570
10571 2019-05-08  Tom Tromey  <tom@tromey.com>
10572
10573         * mips-tdep.c (mips_pdr_data): Remove.
10574         (_initialize_mips_tdep): Update.
10575
10576 2019-05-08  Tom Tromey  <tom@tromey.com>
10577
10578         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10579         (hppa_init_objfile_priv_data, read_unwind_info)
10580         (find_unwind_entry, _initialize_hppa_tdep): Update.
10581
10582 2019-05-08  Tom Tromey  <tom@tromey.com>
10583
10584         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10585         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10586         on obstack.
10587         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10588
10589 2019-05-08  Tom Tromey  <tom@tromey.com>
10590
10591         * mdebugread.c (basic_type_data): Change type.
10592         (basic_type, _initialize_mdebugread): Update.
10593
10594 2019-05-08  Tom Tromey  <tom@tromey.com>
10595
10596         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10597
10598 2019-05-08  Tom Tromey  <tom@tromey.com>
10599
10600         * nto-tdep.c (nto_inferior_data_reg): Change type.
10601         (nto_inferior_data): Update.
10602         (nto_inferior_data_cleanup, nto_new_inferior_data)
10603         (_initialize_nto_tdep): Remove.
10604         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10605
10606 2019-05-08  Tom Tromey  <tom@tromey.com>
10607
10608         * ada-lang.c (struct ada_inferior_data): Add initializers.
10609         (ada_inferior_data): Change type.
10610         (ada_inferior_data_cleanup): Remove.
10611         (get_ada_inferior_data, ada_inferior_exit)
10612         (struct ada_pspace_data): Add initializers, destructor.
10613         (ada_pspace_data_handle): Change type.
10614         (get_ada_pspace_data): Update.
10615         (ada_pspace_data_cleanup): Remove.
10616
10617 2019-05-08  Tom Tromey  <tom@tromey.com>
10618
10619         * coffread.c (struct coff_symfile_info): Add initializers.
10620         (coff_objfile_data_key): Move lower.  Change type.
10621         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10622         Update.
10623         (coff_free_info): Remove.
10624
10625 2019-05-08  Tom Tromey  <tom@tromey.com>
10626
10627         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10628         (fbsd_pspace_data_handle): Move lower.  Change type.
10629         (get_fbsd_pspace_data): Update.
10630         (fbsd_pspace_data_cleanup): Remove.
10631         (_initialize_fbsd_tdep): Update.
10632
10633 2019-05-08  Tom Tromey  <tom@tromey.com>
10634
10635         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10636         (get_ada_tasks_pspace_data): Update.
10637         (ada_tasks_pspace_data_cleanup): Remove.
10638         (_initialize_tasks): Update.
10639         (ada_tasks_inferior_data_handle): Change type.
10640         (get_ada_tasks_inferior_data): Update.
10641         (ada_tasks_inferior_data_cleanup): Remove.
10642         (struct ada_tasks_pspace_data): Add initializers.
10643
10644 2019-05-08  Tom Tromey  <tom@tromey.com>
10645
10646         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10647         * symfile-debug.c (debug_sym_get_probes): Change type.
10648         * stap-probe.c (handle_stap_probe):
10649         (stap_static_probe_ops::get_probes): Change type.
10650         * probe.h (class static_probe_ops) <get_probes>: Change type.
10651         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10652         (parse_probes_in_pspace): Update.
10653         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10654         Update.
10655         (any_static_probe_ops::get_probes): Change type.
10656         * elfread.c (elfread_data): New typedef.
10657         (probe_key): Change type.
10658         (elf_get_probes): Likewise.  Update.
10659         (probe_key_free): Remove.
10660         (_initialize_elfread): Update.
10661         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10662         Change type.
10663         (dtrace_process_dof_probe, dtrace_process_dof)
10664         (dtrace_static_probe_ops::get_probe): Change type.
10665
10666 2019-05-08  Tom Tromey  <tom@tromey.com>
10667
10668         * xcoffread.c (struct xcoff_symfile_info): Rename from
10669         coff_symfile_info.  Add initializers.
10670         (xcoff_objfile_data_key): Move lower.  Change type.
10671         (XCOFF_DATA): Rewrite.
10672         (xcoff_free_info): Remove.
10673         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10674         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10675         (xcoff_initial_scan): Update.
10676
10677 2019-05-08  Tom Tromey  <tom@tromey.com>
10678
10679         * solib-svr4.c (struct svr4_info): Add initializers and
10680         destructor.
10681         <probes_table>: Now an htab_up.
10682         (solib_svr4_pspace_data): Change type.
10683         (free_probes_table): Simplify.
10684         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10685         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10686         (probes_table_remove_objfile_probes, register_solib_event_probe)
10687         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10688         (_initialize_svr4_solib): Update.
10689
10690 2019-05-08  Tom Tromey  <tom@tromey.com>
10691
10692         * remote.c (remote_pspace_data): Change type.
10693         (remote_pspace_data_cleanup): Remove.
10694         (get_remote_exec_file, set_pspace_remote_exec_file)
10695         (_initialize_remote): Update.
10696
10697 2019-05-08  Tom Tromey  <tom@tromey.com>
10698
10699         * breakpoint.c (breakpoint_objfile_key): Change type.
10700         (get_breakpoint_objfile_data): Update.
10701         (free_breakpoint_objfile_data): Remove.
10702         (_initialize_breakpoint): Update.
10703
10704 2019-05-08  Tom Tromey  <tom@tromey.com>
10705
10706         * linux-tdep.c (struct linux_info): Add initializers.
10707         (linux_inferior_data): Move.  Change type.
10708         (invalidate_linux_cache_inf): Update.
10709         (linux_inferior_data_cleanup): Remove.
10710         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10711
10712 2019-05-08  Tom Tromey  <tom@tromey.com>
10713
10714         * auxv.c (auxv_inferior_data): Move.  Change type.
10715         (auxv_inferior_data_cleanup): Remove.
10716         (invalidate_auxv_cache_inf): Rewrite.
10717         (get_auxv_inferior_data, _initialize_auxv): Update.
10718
10719 2019-05-08  Tom Tromey  <tom@tromey.com>
10720
10721         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10722         (symfile_debug_objfile_data_key): Change type.
10723         (symfile_debug_installed, debug_qf_has_symbols)
10724         (debug_qf_find_last_source_symtab)
10725         (debug_qf_forget_cached_source_info)
10726         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10727         (debug_qf_print_stats, debug_qf_dump)
10728         (debug_qf_expand_symtabs_for_function)
10729         (debug_qf_expand_all_symtabs)
10730         (debug_qf_expand_symtabs_with_fullname)
10731         (debug_qf_map_matching_symbols)
10732         (debug_qf_expand_symtabs_matching)
10733         (debug_qf_find_pc_sect_compunit_symtab)
10734         (debug_qf_map_symbol_filenames)
10735         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10736         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10737         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10738         (debug_sym_read_linetable, debug_sym_relocate): Update.
10739         (symfile_debug_free_objfile): Remove.
10740         (install_symfile_debug_logging, _initialize_symfile_debug):
10741         Update.
10742
10743 2019-05-08  Tom Tromey  <tom@tromey.com>
10744
10745         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10746         allocate_on_obstack.
10747         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10748         (get_dwarf2_per_objfile): Update.
10749         (set_dwarf2_per_objfile): Remove.
10750         (dwarf2_has_info, dwarf2_get_section_info): Update.
10751         (dwarf2_free_objfile): Remove.
10752         (_initialize_dwarf2_read): Update.
10753
10754 2019-05-08  Tom Tromey  <tom@tromey.com>
10755
10756         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10757         initializers.
10758         <unsupported_script_warning_printed,
10759         script_not_found_warning_printed>: Now bool.
10760         (auto_load_pspace_data): Change type.
10761         (~auto_load_pspace_info): Rename from
10762         auto_load_pspace_data_cleanup.
10763         (get_auto_load_pspace_data, init_loaded_scripts_info)
10764         (clear_section_scripts, maybe_print_unsupported_script_warning)
10765         (maybe_print_script_not_found_warning, _initialize_auto_load):
10766         Update.
10767
10768 2019-05-08  Tom Tromey  <tom@tromey.com>
10769
10770         * objfiles.c (objfile_pspace_info): Add destructor and
10771         initializers.
10772         (objfiles_pspace_data): Change type.
10773         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10774         (get_objfile_pspace_data): Update.
10775         (objfiles_bfd_data): Change type.
10776         (get_objfile_bfd_data): Update.
10777         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10778
10779 2019-05-08  Tom Tromey  <tom@tromey.com>
10780
10781         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10782         Change type.
10783         (get_catch_syscall_inferior_data): Update.
10784         (catch_syscall_inferior_data_cleanup): Remove.
10785         (_initialize_break_catch_syscall): Update.
10786
10787 2019-05-08  Tom Tromey  <tom@tromey.com>
10788
10789         * inflow.c (struct terminal_info): Add destructor and
10790         initializers.
10791         (inflow_inferior_data): Change type.
10792         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10793         (get_inflow_inferior_data, inflow_inferior_exit)
10794         (swap_terminal_info, _initialize_inflow): Update.
10795
10796 2019-05-08  Tom Tromey  <tom@tromey.com>
10797
10798         * target-dcache.c (target_dcache_cleanup): Remove.
10799         (target_dcache_aspace_key): Change type.
10800         (target_dcache_init_p, target_dcache_invalidate)
10801         (target_dcache_get, target_dcache_get_or_init)
10802         (_initialize_target_dcache): Update.
10803         * dcache.h (struct dcache_deleter): New.
10804
10805 2019-05-08  Tom Tromey  <tom@tromey.com>
10806
10807         * symtab.c (struct symbol_cache): Add destructor and
10808         initializers.
10809         (symbol_cache_key): Move.  Change type.
10810         (make_symbol_cache, free_symbol_cache): Remove.
10811         (get_symbol_cache): Update.
10812         (symbol_cache_cleanup): Remove.
10813         (ALL_PSPACES, symbol_cache_flush)
10814         (maintenance_print_symbol_cache)
10815         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10816         Update.
10817
10818 2019-05-08  Tom Tromey  <tom@tromey.com>
10819
10820         * symtab.c (struct main_info): Add destructor and initializers.
10821         (main_progspace_key): Move.  Change type.
10822         (get_main_info): Update.
10823         (main_info_cleanup): Remove.
10824         (_initialize_symtab): Update.
10825
10826 2019-05-08  Tom Tromey  <tom@tromey.com>
10827
10828         * registry.h (DECLARE_REGISTRY): Define the _key class.
10829
10830 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10831
10832         * NEWS: Merge two 'New commands' sections.
10833
10834 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10835
10836         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10837         parameter and use Ada language definition instead.
10838         (ada_val_print_ptr): Remove unused language parameter.
10839         (ada_val_print_num): Remove language parameter and use Ada language
10840         definition instead.
10841         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10842         parameter.
10843         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10844         parameter and use Ada language definition instead.
10845         (ada_val_print_1): Update all ada_val_print_xxx calls.
10846         Remove language parameter.
10847         (ada_val_print): Update ada_val_print_1 call.
10848
10849 2019-05-08  Tom Tromey  <tromey@adacore.com>
10850
10851         * remote.c (remote_hw_watchpoint_limit)
10852         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10853         Now static.
10854
10855 2019-05-08  Tom Tromey  <tromey@adacore.com>
10856
10857         * maint.c (_initialize_maint_cmds): Move initialization code to
10858         remote.c.
10859         (watchdog, show_watchdog): Move to remote.c.
10860         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10861         "watchdog" static.
10862         (_initialize_remote): Move initialization code from maint.c.
10863         * defs.h (watchdog): Don't declare.
10864
10865 2019-05-08  Tom Tromey  <tromey@adacore.com>
10866
10867         * tui/tui-interp.c: Include main.h.
10868         * interps.c: Include main.h.
10869         * main.h (interpreter_p): Declare.
10870         * defs.h (interpreter_p): Don't declare.
10871
10872 2019-05-08  Tom Tromey  <tromey@adacore.com>
10873
10874         * dwarf2loc.c: Include dwarf2read.h.
10875         * defs.h (read_unsigned_leb128): Don't declare.
10876         * dwarf2read.h (read_unsigned_leb128): Declare.
10877
10878 2019-05-08  Tom Tromey  <tromey@adacore.com>
10879
10880         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10881         method.
10882
10883 2019-05-08  Tom Tromey  <tromey@adacore.com>
10884
10885         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10886         when no wrap column is set.
10887
10888 2019-05-08  Tom Tromey  <tromey@adacore.com>
10889
10890         * c-lang.c (c_get_string): Handle non-C-style arrays.
10891
10892 2019-05-08  Tom Tromey  <tromey@adacore.com>
10893
10894         * typeprint.c (print_offset_data::update): Print the bit offset,
10895         not the number of bits remaining.
10896
10897 2019-05-08  Tom Tromey  <tromey@adacore.com>
10898
10899         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10900         padding at end of comment.
10901
10902 2019-05-08  Tom Tromey  <tromey@adacore.com>
10903
10904         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10905         Compare main types.
10906
10907 2019-05-06  Tom Tromey  <tom@tromey.com>
10908
10909         * common/scoped_mmap.c: Include common-defs.h.
10910         * common/scoped_mmap.h: Don't include config.h.
10911
10912 2019-05-04  Tom Tromey  <tom@tromey.com>
10913
10914         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10915         (struct aarch64_call_info): Add initializers.
10916         <si>: Now a std::vector.
10917         (pass_on_stack, aarch64_push_dummy_call): Update.
10918
10919 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10920             Tom Tromey  <tom@tromey.com>
10921
10922         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10923         (ppc_threads): Now a std::vector.  Now static.
10924         (hwdebug_find_thread_points_by_tid)
10925         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10926         Update.
10927
10928 2019-05-04  Tom Tromey  <tom@tromey.com>
10929
10930         * arc-tdep.c (arc_tdesc_init): Return bool.
10931
10932 2019-05-04  Tom Tromey  <tom@tromey.com>
10933
10934         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10935         Use gdb_assert_not_reached.
10936
10937 2019-05-04  Tom Tromey  <tom@tromey.com>
10938
10939         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10940         "false".
10941
10942 2019-05-04  Tom Tromey  <tom@tromey.com>
10943
10944         * arc-tdep.c (arc_tdesc_init): Use bool.
10945
10946 2019-05-04  Tom Tromey  <tom@tromey.com>
10947
10948         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10949
10950 2019-05-04  Tom Tromey  <tom@tromey.com>
10951
10952         * cli/cli-cmds.c (valid_command_p): Return bool.
10953
10954 2019-05-04  Tom Tromey  <tom@tromey.com>
10955
10956         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10957         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10958
10959 2019-05-04  Raul Tambre  <raul@tambre.ee>
10960
10961         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10962         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10963         operator for comparison.
10964
10965 2019-05-04  Tom Tromey  <tom@tromey.com>
10966
10967         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10968         (lookup_partial_symbol, print_partial_symbols)
10969         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10970         (psymbol_compare): Update.
10971         (add_psymbol_to_bcache): Clear the entire psymbol.
10972         (maintenance_check_psymtabs): Update.
10973         * psympriv.h (struct partial_symbol): Don't derive from
10974         general_symbol_info.
10975         <obj_section, unrelocated_address, address,
10976         set_unrelocated_address>: Update.
10977         <ginfo>: New member.
10978         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10979         (debug_names::write_psymbols): Update.
10980
10981 2019-05-04  Tom de Vries  <tdevries@suse.de>
10982
10983         * contrib/cc-with-tweaks.sh: Support -n arg.
10984
10985 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10986
10987         * corelow.c (core_target::detach): Ensure frame cache and
10988         register caches are cleared.
10989         inferior.c (exit_inferior_1): Likewise.
10990
10991 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10992             Tom Tromey  <tom@tromey.com>
10993
10994         * dictionary.c (collate_pending_symbols_by_language): Remove
10995         "struct" from foreach.
10996         * symtab.c (lookup_global_symbol_from_objfile)
10997         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10998         foreach.
10999         * ser-tcp.c (net_open): Remove "struct" from foreach.
11000         * objfiles.c (objfile_relocate, objfile_rebase)
11001         (objfile_has_symbols): Remove "struct" from foreach.
11002         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11003         from foreach.
11004         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11005         foreach.
11006         * darwin-nat.c (thread_info_from_private_thread_info): Remove
11007         "struct" from foreach.
11008         * ada-lang.c (create_excep_cond_exprs)
11009         (ada_exception_catchpoint_cond_string): Remove "struct" from
11010         foreach.
11011
11012 2019-05-03  Tom Tromey  <tromey@adacore.com>
11013
11014         * ada-exp.y (convert_char_literal): Check suffix of each
11015         enumerator.
11016
11017 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
11018
11019         PR ada/21406:
11020         * ada-exp.y (yywrap): Don't define.
11021         * ada-lex.l (%option): Add noyywrap
11022         (yywrap): Remove.
11023
11024 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
11025
11026         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11027         _WIN32_WINNT to the XP level, unless already defined to a higher
11028         level.
11029
11030         * unittests/parse-connection-spec-selftests.c:
11031         * ser-tcp.c:
11032         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11033         override.
11034
11035         * symfile.c (find_separate_debug_file): Remove colon from the
11036         drive spec of DOS/Windows file names of the target, so that the
11037         file name produced from DEBUGDIR and the target's directory will
11038         be valid on DOS/Windows systems.
11039
11040 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11041
11042         * rust-lang.c (val_print_struct): Handle printing structures
11043         containing strings.
11044
11045 2019-05-02  Tom Tromey  <tromey@adacore.com>
11046
11047         * valarith.c (_initialize_valarith): Remove.
11048
11049 2019-05-01  Tom Tromey  <tromey@adacore.com>
11050
11051         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11052         bitfields.
11053
11054 2019-05-01  Tom Tromey  <tromey@adacore.com>
11055
11056         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11057         for big-endian copies.
11058
11059 2019-04-30  Ali Tamur  <tamur@google.com>
11060         * gdb/dwarf2read.c (read_3_bytes): New declaration.
11061         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11062         (read_3_bytes): New function.
11063
11064 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11065
11066         * windows-nat.c (main_thread_id): Delete.
11067         (handle_output_debug_string): Replace main_thread_id by
11068         current_event.dwThreadId.
11069         (fake_create_process): Likewise.
11070         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11071         Do not set main_thread_id.
11072         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11073         current_event.dwThreadId.
11074         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11075
11076 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11077
11078         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11079         Use current_event.dwThreadId instead of main_thread_id.
11080
11081 2019-04-30  Tom Tromey  <tromey@adacore.com>
11082
11083         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11084         (create_excep_cond_exprs): Iterate over program spaces.
11085         (ada_exception_catchpoint_cond_string): Examine all minimal
11086         symbols for exception types.
11087
11088 2019-04-30  Tom Tromey  <tromey@adacore.com>
11089
11090         PR c++/24470:
11091         * dwarf2read.c (process_structure_scope): Handle case where type
11092         has template parameters but no symbol was created.
11093
11094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11095             Chris January  <chris.january@arm.com>
11096
11097         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11098         qualifier.
11099         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11100
11101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11102
11103         * f-typeprint.c (f_print_type): Update rules for printing
11104         whitespace.
11105         (f_type_print_varspec_suffix): Likewise.
11106
11107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11108             Chris January  <chris.january@arm.com>
11109
11110         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11111         function arguments.
11112
11113 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11114
11115         * f-lang.c (build_fortran_types): Change name of void type to
11116         lower case.
11117         * f-typeprint.c (f_type_print_base): Print the name of the void
11118         type, rather than a fixed string.
11119         * f-valprint.c (f_decorations): Use lower case void string.
11120
11121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11122             Chris January  <chris.january@arm.com>
11123
11124         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11125         types for Fortran.
11126
11127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11128             Chris January  <chris.january@arm.com>
11129             David Lecomber  <david.lecomber@arm.com>
11130
11131         * f-exp.y (BINOP_INTRINSIC): New token.
11132         (exp): New parser rule handling BINOP_INTRINSIC.
11133         (f77_keywords): Add new builtin procedures.
11134         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11135         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11136         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11137         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11138         (print_unop_subexp_f): New function.
11139         (print_binop_subexp_f): New function.
11140         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11141         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11142         (dump_subexp_body_f): Likewise.
11143         (operator_check_f): Likewise.
11144         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11145         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11146
11147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11148
11149         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11150         UNOP_KIND.
11151         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11152         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11153         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11154         (operator_length_f): New fuction.
11155         (print_subexp_f): New function.
11156         (op_name_f): New function.
11157         (dump_subexp_body_f): New function.
11158         (operator_check_f): New function.
11159         (exp_descriptor_f): Replace standard expression handling functions
11160         with new functions.
11161         * gdb/fortran-operator.def: New file.
11162         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11163         * gdb/std-operator.def: Remove UNOP_KIND.
11164
11165 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11166
11167         * std-operator.def: Remove unbalanced, stray double quote
11168         character.
11169
11170 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11171             Chris January  <chris.january@arm.com>
11172             Daniel Everett  <daniel.everett@arm.com>
11173             Nick Forrington  <nick.forrington@arm.com>
11174             Richard Bunt  <richard.bunt@arm.com>
11175
11176         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11177         of depth when printing anonymous structs or unions.
11178         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11179         Don't print either the top-level value, or the children if the
11180         max-depth is exceeded.
11181         (ppscm_print_children): When printing the key of a map, allow one
11182         extra level of depth.
11183         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11184         print either the top-level value, or the children if the max-depth
11185         is exceeded.
11186         (print_children): When printing the key of a map, allow one extra
11187         level of depth.
11188         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11189         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11190         (user_print_options): Initialise max_depth field.
11191         (val_print_scalar_or_string_type_p): New function.
11192         (val_print): Check to see if the max depth has been reached.
11193         (val_print_check_max_depth): Define new function.
11194         (show_print_max_depth): New function.
11195         (_initialize_valprint): Add 'print max-depth' option.
11196         * valprint.h (struct value_print_options) <max_depth>: New field.
11197         (val_print_check_max_depth): Declare new function.
11198         * NEWS: Document new feature.
11199
11200 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11201
11202         * ada-lang.c (ada_language_defn): Initialise new field.
11203         * c-lang.c (c_is_string_type_p): New function.
11204         (c_language_defn): Initialise new field.
11205         (cplus_language_defn): Initialise new field.
11206         (asm_language_defn): Initialise new field.
11207         (minimal_language_defn): Initialise new field.
11208         * c-lang.h (c_is_string_type_p): Declare new function.
11209         * d-lang.c (d_language_defn): Initialise new field.
11210         * f-lang.c (f_is_string_type_p): New function.
11211         (f_language_defn): Initialise new field.
11212         * go-lang.c (go_is_string_type_p): New function.
11213         (go_language_defn): Initialise new field.
11214         * language.c (default_is_string_type_p): New function.
11215         (unknown_language_defn): Initialise new field.
11216         (auto_language_defn): Initialise new field.
11217         * language.h (struct language_defn) <la_is_string_type_p>: New
11218         member variable.
11219         (default_is_string_type_p): Declare new function.
11220         * m2-lang.c (m2_language_defn): Initialise new field.
11221         * objc-lang.c (objc_language_defn): Initialise new field.
11222         * opencl-lang.c (opencl_language_defn): Initialise new field.
11223         * p-lang.c (pascal_is_string_type_p): New function.
11224         (pascal_language_defn): Initialise new field.
11225         * rust-lang.c (rust_is_string_type_p): New function.
11226         (rust_language_defn): Initialise new field.
11227
11228 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11231         New field.
11232         * ada-lang.c (ada_language_defn): Initialise new field.
11233         * c-lang.c (c_language_defn): Likewise.
11234         (cplus_language_defn): Likewise.
11235         (asm_language_defn): Likewise.
11236         (minimal_language_defn): Likewise.
11237         * d-lang.c (d_language_defn): Likewise.
11238         * f-lang.c (f_language_defn): Likewise.
11239         * go-lang.c (go_language_defn): Likewise.
11240         * language.c (unknown_language_defn): Likewise.
11241         (auto_language_defn): Likewise.
11242         * m2-lang.c (m2_language_defn): Likewise.
11243         * objc-lang.c (objc_language_defn): Likewise.
11244         * opencl-lang.c (opencl_language_defn): Likewise.
11245         * p-lang.c (pascal_language_defn): Likewise.
11246         * rust-lang.c (rust_language_defn): Likewise.
11247
11248 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11249
11250         * ada-lang.c (ada_is_character_type): Change return type to bool.
11251         (ada_is_string_type): Likewise.
11252         * ada-lang.h (ada_is_character_type): Update declaration
11253         (ada_is_string_type): Likewise.
11254
11255 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11256
11257         Support style in 'frame|thread apply'
11258
11259         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11260         * record.c (record_start, record_stop): Update callers of
11261         execute_command_to_string with false.
11262         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11263         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11264         methods.
11265         (class string_file): New constructor with term_out parameter.
11266         Override methods term_out and can_emit_style_escape.  New member
11267         term_out.
11268         (class stdio_file): Override can_emit_style_escape.
11269         (class tee_file): Override term_out and can_emit_style_escape.
11270         * utils.h (can_emit_style_escape): Remove.
11271         * utils.c (can_emit_style_escape): Likewise.
11272         Update all callers of can_emit_style_escape (SOMESTREAM) to
11273         SOMESTREAM->can_emit_style_escape.
11274         * source-cache.c (source_cache::get_source_lines): Likewise.
11275         * stack.c (frame_apply_command_count): Call execute_command_to_string
11276         passing the term_out characteristic of the current gdb_stdout.
11277         * thread.c (thr_try_catch_cmd): Likewise.
11278         * top.c (execute_command_to_string): pass term_out parameter
11279         to construct the string_file for the command output.
11280         * ui-file.c (term_cli_styling): New function (most code moved
11281         from utils.c can_emit_style_escape).
11282         (string_file::string_file, string_file::can_emit_style_escape,
11283         stdio_file::can_emit_style_escape, tee_file::term_out,
11284         tee_file::can_emit_style_escape): New functions.
11285
11286 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11287
11288         * NEWS: Mention the new set|show may-call-functions.
11289         * infcall.c (may_call_functions_p): New variable.
11290         (show_may_call_functions_p): New function.
11291         (call_function_by_hand_dummy): Throws an error if not
11292         may-call-functions.
11293         (_initialize_infcall): Call add_setshow_boolean_cmd for
11294         may-call-functions.
11295
11296 2019-04-25  Keith Seitz  <keiths@redhat.com>
11297
11298         PR c++/24367
11299         * cp-support.c (inspect_type): Don't attempt substitutions
11300         of symbol with the same name.
11301
11302 2019-04-25  Tom Tromey  <tromey@adacore.com>
11303
11304         PR gdb/24475:
11305         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11306         static.
11307
11308 2019-04-25  Tom Tromey  <tromey@adacore.com>
11309
11310         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11311         rvalue reference.
11312         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11313         (gdb_xml_parser::parse): Use std::move.
11314         * python/python-internal.h (gdbpy_convert_exception): Take a const
11315         reference.
11316         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11317         std::move.
11318         * python/py-utils.c (gdbpy_convert_exception): Take a const
11319         reference.
11320         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11321         Use std::move.
11322         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11323         Use std::move.
11324         * mi/mi-main.c (mi_print_exception): Take a const reference.
11325         * main.c (handle_command_errors): Take a const reference.
11326         * linespec.c (parse_linespec): Use std::move.
11327         * infcall.c (run_inferior_call): Use std::move.
11328         (call_function_by_hand_dummy): Use std::move.
11329         * exec.c (try_open_exec_file): Use std::move.
11330         * exceptions.h (exception_print, exception_fprintf)
11331         (exception_print_same): Update.
11332         * exceptions.c (print_exception, exception_print)
11333         (exception_fprintf, exception_print_same): Change parameters to
11334         const reference.
11335         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11336         * common/new-op.c: Use std::move.
11337         * common/common-exceptions.h (struct gdb_exception): Add move
11338         constructor.
11339         (struct gdb_exception_error, struct gdb_exception_quit, struct
11340         gdb_quit_bad_alloc): Change constructor to move constructor.
11341         (throw_exception): Change parameter to rvalue reference.
11342         * common/common-exceptions.c (throw_exception): Take rvalue
11343         reference.
11344         * cli/cli-interp.c (safe_execute_command): Use std::move.
11345         * breakpoint.c (insert_bp_location, location_to_sals): Use
11346         std::move.
11347
11348 2019-04-25  Tom Tromey  <tromey@adacore.com>
11349
11350         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11351         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11352         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11353         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11354         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11355         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11356         guile/scm-value.c: Use unpack.
11357         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11358         gdbscm_gdb_exception.
11359         (gdbscm_throw_gdb_exception): Likewise.
11360         (struct gdbscm_gdb_exception): New.
11361         (unpack): New function.
11362         (gdbscm_wrap): Use unpack.
11363
11364 2019-04-25  Tom Tromey  <tromey@adacore.com>
11365
11366         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11367         (gdb_rl_callback_handler): Use std::move.
11368         * common/common-exceptions.h (struct gdb_exception): Add move
11369         assignment operator.
11370         (throw_exception_sjlj): Change "exception" to const reference.
11371         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11372         (throw_exception_sjlj): Change "exception" to const reference.
11373
11374 2019-04-25  Tom Tromey  <tromey@adacore.com>
11375
11376         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11377         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11378         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11379         Update.
11380         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11381         Update.
11382         * mi/mi-interp.c (mi_interp::exec): Update.
11383         * linespec.c (parse_linespec): Update.
11384         * infcall.c (run_inferior_call): Update.
11385         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11386         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11387         (gdbscm_lookup_global_symbol): Update.
11388         * guile/scm-param.c (gdbscm_parameter_value): Update.
11389         * guile/scm-frame.c (gdbscm_frame_read_register)
11390         (gdbscm_frame_read_var): Update.
11391         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11392         * exec.c (try_open_exec_file): Update.
11393         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11394         (gdb_rl_callback_handler): Update.
11395         * common/common-exceptions.h (exception_none): Don't declare.
11396         * common/common-exceptions.c (exception_none): Don't define.
11397         (struct catcher) <exception>: Update.
11398         * cli/cli-interp.c (safe_execute_command): Update.
11399         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11400
11401 2019-04-25  Ali Tamur  <tamur@google.com>
11402
11403         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11404         (read_attribute_value): Likewise.
11405         (dwarf2_read_addr_index): Update comment.
11406         (read_str_index): Add DW_FORM_strx.
11407         (dwarf2_string_attr): Likewise.
11408         (dwarf2_const_value_attr): Likewise.
11409         (dump_die_shallow): Likewise.
11410         (dwarf2_fetch_constant_bytes): Likewise.
11411         (skip_form_bytes): Likewise.
11412         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11413
11414 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11415
11416         PR corefiles/11608
11417         PR corefiles/18187
11418         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11419         OFFSET.  Verify if current mapping contains an ELF header.
11420         (linux_find_memory_regions_full): Adjust call to
11421         dump_mapping_p.
11422
11423 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11424             Kang Li <kanglictf@gmail.com>
11425
11426         PR gdb/21600
11427
11428         * dwarf2-frame.c (read_initial_length): Be consistent about using
11429         unsigned representation of length.
11430         (decode_frame_entry_1): Likewise.  Check for wraparound of
11431         end pointer as well as buffer overflow.
11432
11433 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11434
11435         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11436         "vq".
11437
11438 2019-04-24  Tom Tromey  <tromey@adacore.com>
11439
11440         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11441
11442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11443
11444         * s12z-tdep.c (s12z_unwind_pc): Delete.
11445         (s12z_unwind_sp): Delete.
11446         (s12z_gdbarch_init): Don't register deleted functions with
11447         gdbarch.
11448
11449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11450
11451         * rl78-tdep.c (rl78_unwind_sp): Delete.
11452         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11453
11454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11455
11456         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11457         (xstormy16_unwind_pc): Delete.
11458         (xstormy16_dummy_id): Delete.
11459         (xstormy16_gdbarch_init): Don't register deleted functions with
11460         gdbarch.
11461
11462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11463
11464         * vax-tdep.c (vax_unwind_pc): Delete.
11465         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11466
11467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11468
11469         * v850-tdep.c (v850_unwind_sp): Delete.
11470         (v850_unwind_pc): Delete.
11471         (v850_dummy_id): Delete.
11472         (v850_gdbarch_init): Don't register deleted functions with
11473         gdbarch.
11474
11475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11476
11477         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11478         (tilegx_unwind_pc): Delete.
11479         (tilegx_unwind_dummy_id): Delete.
11480         (tilegx_gdbarch_init): Don't register deleted functions with
11481         gdbarch.
11482
11483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11486         (tic6x_dummy_id): Delete.
11487         (tic6x_gdbarch_init): Don't register deleted functions with
11488         gdbarch.
11489
11490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * sparc-tdep.c (sparc_unwind_pc): Delete.
11493         (sparc32_gdbarch_init): Don't register deleted function with
11494         gdbarch.
11495
11496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11497
11498         * sh-tdep.c (sh_unwind_sp): Delete.
11499         (sh_unwind_pc): Delete.
11500         (sh_dummy_id): Delete.
11501         (sh_gdbarch_init): Don't register deleted functions with
11502         gdbarch.
11503
11504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11505
11506         * score-tdep.c (score_unwind_sp): Delete.
11507         (score_unwind_pc): Delete.
11508         (score_dummy_id): Delete.
11509         (score_gdbarch_init): Don't register deleted functions with
11510         gdbarch.
11511
11512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11513
11514         * rx-tdep.c (rx_unwind_pc): Delete.
11515         (rx_unwind_sp): Delete.
11516         (rx_dummy_id): Delete.
11517         (rx_gdbarch_init): Don't register deleted functions with
11518         gdbarch.  Update comment.
11519
11520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11523         (rs6000_dummy_id): Delete.
11524         (rs6000_gdbarch_init): Don't register deleted functions with
11525         gdbarch.
11526
11527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * or1k-tdep.c (or1k_dummy_id): Delete.
11530         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11531
11532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11533
11534         * nios2-tdep.c (nios2_dummy_id): Delete.
11535         (nios2_unwind_sp): Delete.
11536         (nios2_gdbarch_init): Don't register deleted functions with
11537         gdbarch.
11538
11539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11540
11541         * nds32-tdep.c (nds32_dummy_id): Delete.
11542         (nds32_unwind_pc): Delete.
11543         (nds32_unwind_sp): Delete.
11544         (nds32_gdbarch_init): Don't register deleted functions with
11545         gdbarch.
11546
11547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * msp430-tdep.c (msp430_unwind_pc): Delete.
11550         (msp430_unwind_sp): Delete.
11551         (msp430_dummy_id): Delete.
11552         (msp430_gdbarch_init): Don't register deleted functions with
11553         gdbarch.
11554
11555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11556
11557         * moxie-tdep.c (moxie_unwind_sp): Delete.
11558         (moxie_unwind_pc): Delete.
11559         (moxie_dummy_id): Delete.
11560         (moxie_gdbarch_init): Don't register deleted functions with
11561         gdbarch.
11562
11563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11564
11565         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11566         (mn10300_unwind_pc): Delete.
11567         (mn10300_unwind_sp): Delete.
11568         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11569         mn10300_unwind_sp.
11570         (mn10300_frame_unwind_init): Don't register deleted functions with
11571         gdbarch.
11572
11573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11574
11575         * mep-tdep.c (mep_unwind_pc): Delete.
11576         (mep_unwind_sp): Delete.
11577         (mep_dummy_id): Delete.
11578         (mep_gdbarch_init): Don't register deleted functions with
11579         gdbarch.
11580
11581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11582
11583         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11584         (m68hc11_unwind_sp): Delete.
11585         (m68hc11_gdbarch_init): Don't register deleted functions with
11586         gdbarch.
11587
11588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11589
11590         * m32r-tdep.c (m32r_unwind_sp): Delete.
11591         (m32r_unwind_pc): Delete.
11592         (m32r_dummy_id): Delete.
11593         (m32r_gdbarch_init): Don't register deleted functions with
11594         gdbarch.
11595
11596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11597
11598         * m32c-tdep.c (m32c_unwind_pc): Delete.
11599         (m32c_unwind_sp): Delete.
11600         (m32c_dummy_id): Delete.
11601         (m32c_gdbarch_init): Don't register deleted functions with
11602         gdbarch.
11603
11604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11605
11606         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11607         (lm32_unwind_pc): Delete.
11608         (lm32_dummy_id): Delete.
11609         (lm32_gdbarch_init): Don't register deleted functions with
11610         gdbarch.
11611
11612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11613
11614         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11615         (iq2000_unwind_pc): Delete.
11616         (iq2000_dummy_id): Delete.
11617         (iq2000_gdbarch_init): Don't register deleted functions with
11618         gdbarch.
11619
11620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11621
11622         * nds32-tdep.c (nds32_type_align): Delete.
11623         (nds32_push_dummy_call): Use type_align instead.
11624
11625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11626
11627         * arm-tdep.c (arm_type_align): Only handle vector override case.
11628         (arm_push_dummy_call): Use type_align.
11629         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11630
11631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11634         case.
11635         (pass_on_stack): Use type_align.
11636         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11637         function.
11638
11639 2019-04-23  Tom Tromey  <tromey@adacore.com>
11640
11641         * dwarf2read.c (line_header::file_name_at): Remove unused
11642         overload.
11643
11644 2019-04-23  Tom de Vries  <tdevries@suse.de>
11645
11646         PR gdb/24438
11647         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11648         invocation.
11649
11650
11651 2019-03-27  Ali Tamur  <tamur@google.com>
11652
11653         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11654         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11655         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11656         (dwarf_expr_context::get_addr_index): Likewise
11657         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11658         (symbol_needs_eval_context::get_addr_index): Likewise
11659         (disassemble_dwarf_expression): Add DW_OP_addrx
11660         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11661         (read_cutu_die_from_dwo): Update comment
11662         (skip_one_die): Add DW_FORM_addrx
11663         (read_attribute_value): Likewise
11664         (var_decode_location): Add DW_OP_addrx
11665         (dwarf2_const_value_attr): Add DW_FORM_addrx
11666         (dump_die_shallow): Likewise
11667         (dwarf2_fetch_constant_bytes): Likewise
11668         (decode_locdesc): Add DW_OP_addrx
11669         (skip_form_bytes): Add DW_FORM_addrx
11670
11671 2019-04-22  Ali Tamur  <tamur@google.com>
11672
11673         * MAINTAINERS (Write After Approval): Add self.
11674
11675 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11676
11677         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11678         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11679         (open_symbol_file_object): Likewise.
11680         (svr4_default_sos): Add info parameter.
11681         (svr4_read_so_list): Likewise.
11682         (svr4_current_sos_direct): Adjust functions calls to pass down
11683         info.
11684         (svr4_current_sos_1): Add info parameter.
11685         (svr4_current_sos): Call get_svr4_info, pass info down to
11686         svr4_current_sos_1.
11687         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11688         get_svr4_info.
11689         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11690         get_svr4_info.
11691         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11692         to get_svr4_info.
11693         (probes_table_remove_objfile_probes): Likewise.
11694         (register_solib_event_probe): Add info parameter.
11695         (solist_update_incremental): Pass info parameter down to
11696         svr4_read_so_list.
11697         (disable_probes_interface): Add info parameter.
11698         (svr4_handle_solib_event): Pass current_program_space to
11699         get_svr4_info.  Adjust disable_probes_interface cleanup.
11700         (svr4_create_probe_breakpoints): Add info parameter, pass it
11701         down to register_solib_event_probe.
11702         (svr4_create_solib_event_breakpoints): Add info parameter,
11703         pass it down to svr4_create_probe_breakpoints.
11704         (enable_break): Pass info down to
11705         svr4_create_solib_event_breakpoints.
11706         (svr4_solib_create_inferior_hook): Pass current_program_space to
11707         get_svr4_info.
11708         (svr4_clear_solib): Likewise.
11709
11710 2019-04-22  Pedro Alves  <palves@redhat.com>
11711
11712         * solib-svr4.c (svr4_free_objfile_observer): New.
11713         (probe_and_action::objfile): New field.
11714         (probes_table_htab_remove_objfile_probes)
11715         (probes_table_remove_objfile_probes): New functions.
11716         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11717         in the new probe_and_action.  Don't store the probe in 'lookup'.
11718         (svr4_create_probe_breakpoints): Pass objfile to
11719         register_solib_event_probe.
11720         (_initialize_svr4_solib): Register a free_objfile observer.
11721
11722 2019-04-19  Tom Tromey  <tom@tromey.com>
11723
11724         * common/queue.h: Remove.
11725
11726 2019-04-19  Tom Tromey  <tom@tromey.com>
11727
11728         * event-loop.c: Don't include "common/queue.h".
11729
11730 2019-04-19  Tom Tromey  <tom@tromey.com>
11731
11732         * remote.c (remote_target): Use delete.
11733         * remote-notif.h: Include <list>, not "common/queue.h".
11734         (notif_client_p): Remove typedef.
11735         (remote_notif_state): Add constructor, destructor, initializer.
11736         <notif_queue>: Now a std::list.
11737         (remote_notif_state_xfree): Don't declare.
11738         * remote-notif.c (remote_notif_process, handle_notification)
11739         (remote_notif_state_allocate): Update.
11740         (~remote_notif_state): Rename from remote_notif_state_xfree.
11741
11742 2019-04-19  Tom Tromey  <tom@tromey.com>
11743
11744         * symfile.c (reread_symbols): Update.
11745         * objfiles.c (objfile_register_static_link)
11746         (objfile_lookup_static_link): Update
11747         (~objfile) Don't delete static_links.
11748         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11749
11750 2019-04-19  Tom Tromey  <tom@tromey.com>
11751
11752         * type-stack.h (struct type_stack) <insert>: Constify string.
11753         * type-stack.c (type_stack::insert): Constify string.
11754         * gdbtypes.h (lookup_template_type): Update.
11755         (address_space_name_to_int): Update.
11756         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11757         const.
11758         (lookup_template_type): Make name const.
11759         * c-exp.y: Update rules.
11760         (lex_one_token, classify_name, classify_inner_name)
11761         (c_print_token): Update.
11762         * p-exp.y: Update rules.
11763         (yylex): Update.
11764         * f-exp.y: Update rules.
11765         (yylex): Update.
11766         * d-exp.y: Update rules.
11767         (lex_one_token, classify_name, classify_inner_name): Update.
11768         * parse.c (write_dollar_variable, copy_name): Return std::string.
11769         * parser-defs.h (copy_name): Change return type.
11770         * m2-exp.y: Update rules.
11771         (yylex): Update.
11772         * go-exp.y (lex_one_token): Update.
11773         Update rules.
11774         (classify_unsafe_function, classify_packaged_name)
11775         (classify_name, yylex): Update.
11776
11777 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11778
11779         * configure.ac: add --enable-source-highlight switch.
11780         * configure: Regenerate.
11781         * top.c (print_gdb_version): plumb --enable-source-highlight
11782         status to "show configuration".
11783
11784 2019-04-19  Tom Tromey  <tromey@adacore.com>
11785
11786         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11787         Check ADA_TYPE_P.
11788         (empty_record, ada_template_to_fixed_record_type_1)
11789         (template_to_static_fixed_type)
11790         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11791         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11792         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11793         macros.
11794
11795 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11796
11797         PR symtab/24423:
11798         * source.c (print_source_lines_base): Advance "iter" when a
11799         control character is seen.
11800
11801 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11802
11803         * inferior.h (struct infcall_suspend_state_deleter):
11804         Catch exception in destructor to avoid crash.
11805
11806 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11807
11808         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11809         close to the add_com "shell".
11810
11811 2019-04-18  Tom Tromey  <tromey@adacore.com>
11812
11813         * process-stratum-target.h (class process_stratum_target)
11814         <stratum>: Add "final".
11815
11816 2019-04-17  Tom Tromey  <tromey@adacore.com>
11817
11818         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11819         against nullptr before use.
11820
11821 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11822
11823         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11824
11825 2019-04-17  Jim Wilson  <jimw@sifive.com>
11826             Andrew Burgess  <andrew.burgess@embecosm.com>
11827
11828         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11829         code read might fail, assume 4-byte breakpoint in that case.
11830
11831 2019-04-15  Leszek Swirski  <leszeks@google.com>
11832
11833         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11834         rather than a hand-rolled POD check when checking for forced MEMORY
11835         classification.
11836
11837 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11838
11839         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11840         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11841         function.
11842         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11843         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11844         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11845         declaration.
11846
11847 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11848
11849         * aarch64-linux-nat.c
11850         (aarch64_linux_nat_target::thread_architecture): Add override.
11851         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11852         each VQ.
11853
11854 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11855
11856         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11857
11858 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11859
11860         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11861         target types of size 96-bits, add some additional comments, and
11862         check that the builtin type we found was the correct size.
11863
11864 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11865
11866         * utils.c (prompt_for_continue): Don't restore the styling at the
11867         end, as applied_style has the wrong value.  This fixes styling in
11868         long lists of file names that are interrupted by the "Continue?"
11869         prompt.
11870
11871 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11872
11873         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11874         * c-lang.c (c_language_defn): Likewise.
11875         (cplus_language_defn): Likewise.
11876         (asm_language_defn): Likewise.
11877         (minimal_language_defn): Likewise.
11878         * d-lang.c (d_language_defn): Likewise.
11879         * f-lang.c (f_language_defn): Likewise.
11880         * go-lang.c (go_language_defn): Likewise.
11881         * language.c (unknown_language_defn): Likewise.
11882         (auto_language_defn): Likewise.
11883         * language.h (struct language_defn): Remove la_magic field.
11884         (LANG_MAGIC): Delete.
11885         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11886         * objc-lang.c (objc_language_defn): Likewise.
11887         * opencl-lang.c (opencl_language_defn): Likewise.
11888         * p-lang.c (pascal_language_defn): Likewise.
11889         * rust-lang.c (rust_language_defn): Likewise.
11890
11891 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11892
11893         * riscv-tdep.c (riscv_type_align): New function.
11894         (riscv_type_alignment): Delete.
11895         (riscv_arg_location): Use 'type_align'.
11896         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11897
11898 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * gdbtypes.c (type_align): A struct with no non-static fields also
11901         has alignment of 1.
11902
11903 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11904
11905         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11906         component to 0.
11907         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11908         member.
11909         (riscv_struct_info::analyse): New implementation using new
11910         analyse_inner member function.
11911         (riscv_struct_info::field_offset): New member function.
11912         (riscv_struct_info::m_offsets): New member variable.
11913         (riscv_struct_info::analyse_inner): New private member function,
11914         takes the old implementation of riscv_struct_info::analyse but
11915         extended to track field offsets.
11916         (riscv_call_arg_struct): Update the struct folding special cases
11917         to handle cases where empty C++ structs, which are non-zero
11918         length, are found.
11919         (riscv_arg_location): Initialise the length of each location, a
11920         non-zero length now indicates the location is in use.
11921         (riscv_push_dummy_call): Allow for the first location having a
11922         non-zero offset when setting up arguments.
11923         (riscv_return_value): Likewise, but for return values.
11924
11925 2019-04-11  Tom Tromey  <tromey@adacore.com>
11926
11927         * utils.c (internal_vproblem): Make "msg" const.
11928
11929 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11930
11931         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11932         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11933         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11934         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11935
11936 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11937
11938         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11939         function.
11940         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11941         of amd64_collect_native_gregset.
11942         (amd64_linux_nat_target::store_registers): Likewise.
11943
11944 2019-04-10  Tom Tromey  <tom@tromey.com>
11945
11946         * symtab.c (lookup_global_symbol_from_objfile)
11947         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11948         * objfiles.h (class separate_debug_iterator): New.
11949         (class separate_debug_range): New.
11950         (struct objfile) <separate_debug_objfiles>: New method.
11951         (objfile_separate_debug_iterate): Don't declare.
11952         * objfiles.c (separate_debug_iterator::operator++): Rename from
11953         objfile_separate_debug_iterate.
11954         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11955         iterator.
11956         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11957         iterator.
11958
11959 2019-04-10  Tom Tromey  <tom@tromey.com>
11960
11961         * symfile.c (reread_symbols): Remove old comment.
11962         * objfiles.c (free_all_objfiles): Fix a typo.
11963
11964 2019-04-10  Tom Tromey  <tom@tromey.com>
11965
11966         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11967         * minsyms.c (lookup_minimal_symbol): Use foreach.
11968         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11969         (lookup_minimal_symbol_solib_trampoline): Likewise.
11970         * symfile.c (reread_symbols): Use foreach.
11971
11972 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11973             Tom Tromey  <tromey@adacore.com>
11974
11975         PR rust/24414:
11976         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11977         (rust_lex_int_test): Change "value" to be LONGEST.
11978         (rust_lex_tests): Add test for long integer literal.
11979
11980 2019-04-09  Tom Tromey  <tromey@adacore.com>
11981
11982         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11983         to bool.
11984         (extended_remote_target::attach): Update.
11985         (remote_target::remote_notice_new_inferior): Update.
11986         (remote_target::add_current_inferior_and_thread): Update.
11987         * inferior.c (exit_inferior_1): Use "false".
11988         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11989
11990 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11991
11992         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11993         the "start" command.
11994
11995 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11996
11997         * python/py-inferior.c (infpy_thread_from_thread_handle):
11998         Adjust comments to reflect renaming of thread_from_thread_handle
11999         to thread_from_handle.  Adjust keywords.  Fix type error message.
12000         (inferior_object_methods): Add thread_from_handle.  Retain
12001         thread_from_thread_handle, but mark it as deprecated.
12002
12003 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12004
12005         * gdbthread.h (find_thread_by_handle): Revise declaration.
12006         * thread.c (find_thread_by_handle): Likewise.  Adjust
12007         implementation too.
12008         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12009         support for buffer objects as handles.
12010
12011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12012
12013         * python/py-infthread.c (thpy_thread_handle): New function.
12014         (thread_object_methods): Register thpy_thread_handle.
12015
12016 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12017
12018         * gdbthread.h (thread_to_thread_handle): Declare.
12019         * thread.c (gdbtypes.h): Include.
12020         (thread_to_thread_handle): New function.
12021
12022         * target.h (struct target_ops): Add thread_info_to_thread_handle.
12023         (target_thread_info_to_thread_handle): Declare.
12024         * target.c (target_thread_info_to_thread_handle): New function.
12025         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12026         * target-delegates.c: Regenerate.
12027
12028         * linux-thread-db.c (class thread_db_target): Add method
12029         thread_info_to_thread_handle.
12030         (thread_db_target::thread_info_to_thread_handle): Define.
12031         * remote.c (class remote_target): Add new method
12032         thread_info_to_thread_handle.
12033         (remote_target::thread_info_to_thread_handle): Define.
12034
12035 2019-04-08  Pedro Alves  <palves@redhat.com>
12036
12037         * common/common-exceptions.c (throw_exception): Don't create
12038         named object to throw; throw directly.
12039         (throw_it): Likewise.  Don't initialize gdb_exception::message
12040         here, with new; pass FMT and AP to the ctor instead.
12041         * common/common-exceptions.h: Include <string>.
12042         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12043         const char *, va_list)): New ctor.  Use std::make_shared.
12044         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12045         errors)): Delete.
12046         (gdb_exception_error::gdb_exception_error(enum errors, const char
12047         *, va_list)): New.
12048         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12049         Add assertion.
12050         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12051         errors)): Delete.
12052         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12053         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12054         Add assertion.
12055
12056 2019-04-08  Tom Tromey  <tom@tromey.com>
12057
12058         * valops.c (value_rtti_indirect_type): Replace throw_exception
12059         with throw.
12060         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12061         with throw.
12062         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12063         throw.
12064         * target.c (target_translate_tls_address): Replace throw_exception
12065         with throw.
12066         * stack.c (frame_apply_command_count): Replace throw_exception
12067         with throw.
12068         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12069         throw.
12070         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12071         with throw.
12072         * rs6000-tdep.c (rs6000_frame_cache)
12073         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12074         * remote.c: Replace throw_exception with throw.
12075         * record-full.c (record_full_message, record_full_wait_1)
12076         (record_full_restore): Replace throw_exception with throw.
12077         * record-btrace.c:
12078         (get_thread_current_frame_id, record_btrace_start_replaying)
12079         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12080         (cmd_record_btrace_start): Replace throw_exception with throw.
12081         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12082         throw.
12083         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12084         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12085         * linespec.c:
12086         (find_linespec_symbols): Replace throw_exception with throw.
12087         * infrun.c (displaced_step_prepare, resume): Replace
12088         throw_exception with throw.
12089         * infcmd.c (post_create_inferior): Replace throw_exception with
12090         throw.
12091         * inf-loop.c (inferior_event_handler): Replace throw_exception
12092         with throw.
12093         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12094         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12095         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12096         (get_prev_frame_always, get_frame_pc_if_available)
12097         (get_frame_address_in_block_if_available, get_frame_language):
12098         Replace throw_exception with throw.
12099         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12100         throw_exception with throw.
12101         * eval.c (fetch_subexp_value, evaluate_var_value)
12102         (evaluate_funcall, evaluate_subexp_standard): Replace
12103         throw_exception with throw.
12104         * dwarf2loc.c (call_site_find_chain)
12105         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12106         Replace throw_exception with throw.
12107         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12108         with throw.
12109         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12110         throw.
12111         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12112         * completer.c (complete_line_internal): Replace throw_exception
12113         with throw.
12114         * compile/compile-object-run.c (compile_object_run): Replace
12115         throw_exception with throw.
12116         * cli/cli-script.c (process_next_line): Replace throw_exception
12117         with throw.
12118         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12119         (btrace_enable, btrace_maint_update_pt_packets): Replace
12120         throw_exception with throw.
12121         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12122         throw_exception with throw.
12123         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12124         throw_exception with throw.
12125         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12126         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12127         * aarch64-tdep.c (aarch64_make_prologue_cache)
12128         (aarch64_make_stub_cache): Replace throw_exception with throw.
12129
12130 2019-04-08  Tom Tromey  <tom@tromey.com>
12131
12132         * common/common-exceptions.c (throw_exception): Rename from
12133         throw_exception_cxx.  Remove old copy.  Make argument const.
12134         (throw_it): Create and throw exception objects directly.
12135         * common/common-exceptions.h (throw_exception): Make argument
12136         const.
12137         (struct gdb_exception_error): Add constructor.
12138         (struct gdb_exception_quit): Add constructor.
12139
12140 2019-04-08  Tom Tromey  <tom@tromey.com>
12141
12142         * common/common-exceptions.h (exception_rethrow): Don't declare.
12143         (TRY_SJLJ): Update comment.
12144         (TRY, CATCH, END_CATCH): Remove.
12145         * common/common-exceptions.c (exception_rethrow): Remove.
12146
12147 2019-04-08  Tom Tromey  <tom@tromey.com>
12148
12149         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12150         Remove.
12151         (gdb_exception_error): Rename from
12152         gdb_exception_RETURN_MASK_ERROR.
12153         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12154         (gdb_quit_bad_alloc): Update.
12155         * aarch64-tdep.c: Update.
12156         * ada-lang.c: Update.
12157         * ada-typeprint.c: Update.
12158         * ada-valprint.c: Update.
12159         * amd64-tdep.c: Update.
12160         * arch-utils.c: Update.
12161         * break-catch-throw.c: Update.
12162         * breakpoint.c: Update.
12163         * btrace.c: Update.
12164         * c-varobj.c: Update.
12165         * cli/cli-cmds.c: Update.
12166         * cli/cli-interp.c: Update.
12167         * cli/cli-script.c: Update.
12168         * common/common-exceptions.c: Update.
12169         * common/new-op.c: Update.
12170         * common/selftest.c: Update.
12171         * compile/compile-c-symbols.c: Update.
12172         * compile/compile-cplus-symbols.c: Update.
12173         * compile/compile-object-load.c: Update.
12174         * compile/compile-object-run.c: Update.
12175         * completer.c: Update.
12176         * corelow.c: Update.
12177         * cp-abi.c: Update.
12178         * cp-support.c: Update.
12179         * cp-valprint.c: Update.
12180         * darwin-nat.c: Update.
12181         * disasm-selftests.c: Update.
12182         * dtrace-probe.c: Update.
12183         * dwarf-index-cache.c: Update.
12184         * dwarf-index-write.c: Update.
12185         * dwarf2-frame-tailcall.c: Update.
12186         * dwarf2-frame.c: Update.
12187         * dwarf2loc.c: Update.
12188         * dwarf2read.c: Update.
12189         * eval.c: Update.
12190         * event-loop.c: Update.
12191         * event-top.c: Update.
12192         * exec.c: Update.
12193         * f-valprint.c: Update.
12194         * fbsd-tdep.c: Update.
12195         * frame-unwind.c: Update.
12196         * frame.c: Update.
12197         * gdbtypes.c: Update.
12198         * gnu-v3-abi.c: Update.
12199         * guile/guile-internal.h: Update.
12200         * guile/scm-block.c: Update.
12201         * guile/scm-breakpoint.c: Update.
12202         * guile/scm-cmd.c: Update.
12203         * guile/scm-disasm.c: Update.
12204         * guile/scm-frame.c: Update.
12205         * guile/scm-lazy-string.c: Update.
12206         * guile/scm-math.c: Update.
12207         * guile/scm-param.c: Update.
12208         * guile/scm-ports.c: Update.
12209         * guile/scm-pretty-print.c: Update.
12210         * guile/scm-symbol.c: Update.
12211         * guile/scm-symtab.c: Update.
12212         * guile/scm-type.c: Update.
12213         * guile/scm-value.c: Update.
12214         * i386-linux-tdep.c: Update.
12215         * i386-tdep.c: Update.
12216         * inf-loop.c: Update.
12217         * infcall.c: Update.
12218         * infcmd.c: Update.
12219         * infrun.c: Update.
12220         * jit.c: Update.
12221         * language.c: Update.
12222         * linespec.c: Update.
12223         * linux-fork.c: Update.
12224         * linux-nat.c: Update.
12225         * linux-tdep.c: Update.
12226         * linux-thread-db.c: Update.
12227         * main.c: Update.
12228         * mi/mi-cmd-break.c: Update.
12229         * mi/mi-cmd-stack.c: Update.
12230         * mi/mi-interp.c: Update.
12231         * mi/mi-main.c: Update.
12232         * objc-lang.c: Update.
12233         * p-valprint.c: Update.
12234         * parse.c: Update.
12235         * ppc-linux-tdep.c: Update.
12236         * printcmd.c: Update.
12237         * python/py-arch.c: Update.
12238         * python/py-breakpoint.c: Update.
12239         * python/py-cmd.c: Update.
12240         * python/py-finishbreakpoint.c: Update.
12241         * python/py-frame.c: Update.
12242         * python/py-framefilter.c: Update.
12243         * python/py-gdb-readline.c: Update.
12244         * python/py-inferior.c: Update.
12245         * python/py-infthread.c: Update.
12246         * python/py-lazy-string.c: Update.
12247         * python/py-linetable.c: Update.
12248         * python/py-objfile.c: Update.
12249         * python/py-param.c: Update.
12250         * python/py-prettyprint.c: Update.
12251         * python/py-progspace.c: Update.
12252         * python/py-record-btrace.c: Update.
12253         * python/py-record.c: Update.
12254         * python/py-symbol.c: Update.
12255         * python/py-type.c: Update.
12256         * python/py-unwind.c: Update.
12257         * python/py-utils.c: Update.
12258         * python/py-value.c: Update.
12259         * python/python.c: Update.
12260         * record-btrace.c: Update.
12261         * record-full.c: Update.
12262         * remote-fileio.c: Update.
12263         * remote.c: Update.
12264         * riscv-tdep.c: Update.
12265         * rs6000-aix-tdep.c: Update.
12266         * rs6000-tdep.c: Update.
12267         * rust-exp.y: Update.
12268         * rust-lang.c: Update.
12269         * s390-tdep.c: Update.
12270         * selftest-arch.c: Update.
12271         * solib-dsbt.c: Update.
12272         * solib-frv.c: Update.
12273         * solib-spu.c: Update.
12274         * solib-svr4.c: Update.
12275         * solib.c: Update.
12276         * sparc64-linux-tdep.c: Update.
12277         * stack.c: Update.
12278         * symfile-mem.c: Update.
12279         * symmisc.c: Update.
12280         * target.c: Update.
12281         * thread.c: Update.
12282         * top.c: Update.
12283         * tracefile-tfile.c: Update.
12284         * tui/tui.c: Update.
12285         * typeprint.c: Update.
12286         * unittests/cli-utils-selftests.c: Update.
12287         * unittests/parse-connection-spec-selftests.c: Update.
12288         * valops.c: Update.
12289         * valprint.c: Update.
12290         * value.c: Update.
12291         * varobj.c: Update.
12292         * windows-nat.c: Update.
12293         * x86-linux-nat.c: Update.
12294         * xml-support.c: Update.
12295
12296 2019-04-08  Tom Tromey  <tom@tromey.com>
12297
12298         * xml-support.c: Use C++ exception handling.
12299         * x86-linux-nat.c: Use C++ exception handling.
12300         * windows-nat.c: Use C++ exception handling.
12301         * varobj.c: Use C++ exception handling.
12302         * value.c: Use C++ exception handling.
12303         * valprint.c: Use C++ exception handling.
12304         * valops.c: Use C++ exception handling.
12305         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12306         handling.
12307         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12308         * typeprint.c: Use C++ exception handling.
12309         * tui/tui.c: Use C++ exception handling.
12310         * tracefile-tfile.c: Use C++ exception handling.
12311         * top.c: Use C++ exception handling.
12312         * thread.c: Use C++ exception handling.
12313         * target.c: Use C++ exception handling.
12314         * symmisc.c: Use C++ exception handling.
12315         * symfile-mem.c: Use C++ exception handling.
12316         * stack.c: Use C++ exception handling.
12317         * sparc64-linux-tdep.c: Use C++ exception handling.
12318         * solib.c: Use C++ exception handling.
12319         * solib-svr4.c: Use C++ exception handling.
12320         * solib-spu.c: Use C++ exception handling.
12321         * solib-frv.c: Use C++ exception handling.
12322         * solib-dsbt.c: Use C++ exception handling.
12323         * selftest-arch.c: Use C++ exception handling.
12324         * s390-tdep.c: Use C++ exception handling.
12325         * rust-lang.c: Use C++ exception handling.
12326         * rust-exp.y: Use C++ exception handling.
12327         * rs6000-tdep.c: Use C++ exception handling.
12328         * rs6000-aix-tdep.c: Use C++ exception handling.
12329         * riscv-tdep.c: Use C++ exception handling.
12330         * remote.c: Use C++ exception handling.
12331         * remote-fileio.c: Use C++ exception handling.
12332         * record-full.c: Use C++ exception handling.
12333         * record-btrace.c: Use C++ exception handling.
12334         * python/python.c: Use C++ exception handling.
12335         * python/py-value.c: Use C++ exception handling.
12336         * python/py-utils.c: Use C++ exception handling.
12337         * python/py-unwind.c: Use C++ exception handling.
12338         * python/py-type.c: Use C++ exception handling.
12339         * python/py-symbol.c: Use C++ exception handling.
12340         * python/py-record.c: Use C++ exception handling.
12341         * python/py-record-btrace.c: Use C++ exception handling.
12342         * python/py-progspace.c: Use C++ exception handling.
12343         * python/py-prettyprint.c: Use C++ exception handling.
12344         * python/py-param.c: Use C++ exception handling.
12345         * python/py-objfile.c: Use C++ exception handling.
12346         * python/py-linetable.c: Use C++ exception handling.
12347         * python/py-lazy-string.c: Use C++ exception handling.
12348         * python/py-infthread.c: Use C++ exception handling.
12349         * python/py-inferior.c: Use C++ exception handling.
12350         * python/py-gdb-readline.c: Use C++ exception handling.
12351         * python/py-framefilter.c: Use C++ exception handling.
12352         * python/py-frame.c: Use C++ exception handling.
12353         * python/py-finishbreakpoint.c: Use C++ exception handling.
12354         * python/py-cmd.c: Use C++ exception handling.
12355         * python/py-breakpoint.c: Use C++ exception handling.
12356         * python/py-arch.c: Use C++ exception handling.
12357         * printcmd.c: Use C++ exception handling.
12358         * ppc-linux-tdep.c: Use C++ exception handling.
12359         * parse.c: Use C++ exception handling.
12360         * p-valprint.c: Use C++ exception handling.
12361         * objc-lang.c: Use C++ exception handling.
12362         * mi/mi-main.c: Use C++ exception handling.
12363         * mi/mi-interp.c: Use C++ exception handling.
12364         * mi/mi-cmd-stack.c: Use C++ exception handling.
12365         * mi/mi-cmd-break.c: Use C++ exception handling.
12366         * main.c: Use C++ exception handling.
12367         * linux-thread-db.c: Use C++ exception handling.
12368         * linux-tdep.c: Use C++ exception handling.
12369         * linux-nat.c: Use C++ exception handling.
12370         * linux-fork.c: Use C++ exception handling.
12371         * linespec.c: Use C++ exception handling.
12372         * language.c: Use C++ exception handling.
12373         * jit.c: Use C++ exception handling.
12374         * infrun.c: Use C++ exception handling.
12375         * infcmd.c: Use C++ exception handling.
12376         * infcall.c: Use C++ exception handling.
12377         * inf-loop.c: Use C++ exception handling.
12378         * i386-tdep.c: Use C++ exception handling.
12379         * i386-linux-tdep.c: Use C++ exception handling.
12380         * guile/scm-value.c: Use C++ exception handling.
12381         * guile/scm-type.c: Use C++ exception handling.
12382         * guile/scm-symtab.c: Use C++ exception handling.
12383         * guile/scm-symbol.c: Use C++ exception handling.
12384         * guile/scm-pretty-print.c: Use C++ exception handling.
12385         * guile/scm-ports.c: Use C++ exception handling.
12386         * guile/scm-param.c: Use C++ exception handling.
12387         * guile/scm-math.c: Use C++ exception handling.
12388         * guile/scm-lazy-string.c: Use C++ exception handling.
12389         * guile/scm-frame.c: Use C++ exception handling.
12390         * guile/scm-disasm.c: Use C++ exception handling.
12391         * guile/scm-cmd.c: Use C++ exception handling.
12392         * guile/scm-breakpoint.c: Use C++ exception handling.
12393         * guile/scm-block.c: Use C++ exception handling.
12394         * guile/guile-internal.h: Use C++ exception handling.
12395         * gnu-v3-abi.c: Use C++ exception handling.
12396         * gdbtypes.c: Use C++ exception handling.
12397         * frame.c: Use C++ exception handling.
12398         * frame-unwind.c: Use C++ exception handling.
12399         * fbsd-tdep.c: Use C++ exception handling.
12400         * f-valprint.c: Use C++ exception handling.
12401         * exec.c: Use C++ exception handling.
12402         * event-top.c: Use C++ exception handling.
12403         * event-loop.c: Use C++ exception handling.
12404         * eval.c: Use C++ exception handling.
12405         * dwarf2read.c: Use C++ exception handling.
12406         * dwarf2loc.c: Use C++ exception handling.
12407         * dwarf2-frame.c: Use C++ exception handling.
12408         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12409         * dwarf-index-write.c: Use C++ exception handling.
12410         * dwarf-index-cache.c: Use C++ exception handling.
12411         * dtrace-probe.c: Use C++ exception handling.
12412         * disasm-selftests.c: Use C++ exception handling.
12413         * darwin-nat.c: Use C++ exception handling.
12414         * cp-valprint.c: Use C++ exception handling.
12415         * cp-support.c: Use C++ exception handling.
12416         * cp-abi.c: Use C++ exception handling.
12417         * corelow.c: Use C++ exception handling.
12418         * completer.c: Use C++ exception handling.
12419         * compile/compile-object-run.c: Use C++ exception handling.
12420         * compile/compile-object-load.c: Use C++ exception handling.
12421         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12422         * compile/compile-c-symbols.c: Use C++ exception handling.
12423         * common/selftest.c: Use C++ exception handling.
12424         * common/new-op.c: Use C++ exception handling.
12425         * cli/cli-script.c: Use C++ exception handling.
12426         * cli/cli-interp.c: Use C++ exception handling.
12427         * cli/cli-cmds.c: Use C++ exception handling.
12428         * c-varobj.c: Use C++ exception handling.
12429         * btrace.c: Use C++ exception handling.
12430         * breakpoint.c: Use C++ exception handling.
12431         * break-catch-throw.c: Use C++ exception handling.
12432         * arch-utils.c: Use C++ exception handling.
12433         * amd64-tdep.c: Use C++ exception handling.
12434         * ada-valprint.c: Use C++ exception handling.
12435         * ada-typeprint.c: Use C++ exception handling.
12436         * ada-lang.c: Use C++ exception handling.
12437         * aarch64-tdep.c: Use C++ exception handling.
12438
12439 2019-04-08  Tom Tromey  <tom@tromey.com>
12440
12441         * xml-support.c (gdb_xml_parser::parse): Update.
12442         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12443         * value.c (show_convenience): Update.
12444         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12445         (test_parse_flags_qcs): Update.
12446         * thread.c (thr_try_catch_cmd): Update.
12447         * target.c (target_translate_tls_address): Update.
12448         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12449         (info_frame_command_core, frame_apply_command_count): Update.
12450         * rust-exp.y (rust_lex_exception_test): Update.
12451         * riscv-tdep.c (riscv_print_one_register_info): Update.
12452         * remote.c (remote_target::enable_btrace): Update.
12453         * record-btrace.c (record_btrace_enable_warn): Update.
12454         * python/py-utils.c (gdbpy_convert_exception): Update.
12455         * printcmd.c (do_one_display, print_variable_and_value): Update.
12456         * mi/mi-main.c (mi_print_exception): Update.
12457         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12458         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12459         * linux-nat.c (linux_nat_target::attach): Update.
12460         * linux-fork.c (class scoped_switch_fork_info): Update.
12461         * infrun.c (displaced_step_prepare): Update.
12462         * infcall.c (call_function_by_hand_dummy): Update.
12463         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12464         * gnu-v3-abi.c (print_one_vtable): Update.
12465         * frame.c (get_prev_frame_always): Update.
12466         * f-valprint.c (info_common_command_for_block): Update.
12467         * exec.c (try_open_exec_file): Update.
12468         * exceptions.c (print_exception, exception_print)
12469         (exception_fprintf, exception_print_same): Update.
12470         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12471         * dwarf-index-cache.c (index_cache::store)
12472         (index_cache::lookup_gdb_index): Update.
12473         * darwin-nat.c (maybe_cache_shell): Update.
12474         * cp-valprint.c (cp_print_value_fields): Update.
12475         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12476         (gcc_cplus_symbol_address): Update.
12477         * compile/compile-c-symbols.c (gcc_convert_symbol)
12478         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12479         * common/selftest.c: Update.
12480         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12481         a std::string.
12482         (exception_try_scope_entry, exception_try_scope_exit): Don't
12483         declare.
12484         (struct exception_try_scope): Remove.
12485         (TRY): Don't use exception_try_scope.
12486         (struct gdb_exception): Add constructor, operator=.
12487         <what>: New method.
12488         (struct gdb_exception_RETURN_MASK_ALL)
12489         (struct gdb_exception_RETURN_MASK_ERROR)
12490         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12491         (struct gdb_quit_bad_alloc): Update.
12492         * common/common-exceptions.c (exception_none): Change
12493         initializer.
12494         (struct catcher) <state, exception>: Initialize inline.
12495         <prev>: Remove member.
12496         (current_catcher): Remove.
12497         (catchers): New global.
12498         (exceptions_state_mc_init): Simplify.
12499         (catcher_pop): Remove.
12500         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12501         (try_scope_depth, exception_try_scope_entry)
12502         (exception_try_scope_exit): Remove.
12503         (throw_exception_sjlj): Update.
12504         (exception_messages, exception_messages_size): Remove.
12505         (throw_it): Simplify.
12506         (gdb_exception_sliced_copy): Remove.
12507         (throw_exception_cxx): Update.
12508         * cli/cli-script.c (script_from_file): Update.
12509         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12510         Update.
12511         * ada-valprint.c (ada_val_print): Update.
12512         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12513         (create_excep_cond_exprs): Update.
12514
12515 2019-04-08  Tom Tromey  <tom@tromey.com>
12516
12517         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12518         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12519         (TRY, CATCH, END_CATCH): Remove some definitions.
12520         * common/common-exceptions.c: Don't use GDB_XCPT.
12521         (catcher_list_size): Remove.
12522         (throw_exception, throw_it): Simplify.
12523
12524 2019-04-05  Tom Tromey  <tom@tromey.com>
12525
12526         Revert the header-sorting patch.
12527         * ft32-tdep.c: Revert.
12528         * frv-tdep.c: Revert.
12529         * frv-linux-tdep.c: Revert.
12530         * frame.c: Revert.
12531         * frame-unwind.c: Revert.
12532         * frame-base.c: Revert.
12533         * fork-child.c: Revert.
12534         * findvar.c: Revert.
12535         * findcmd.c: Revert.
12536         * filesystem.c: Revert.
12537         * filename-seen-cache.h: Revert.
12538         * filename-seen-cache.c: Revert.
12539         * fbsd-tdep.c: Revert.
12540         * fbsd-nat.h: Revert.
12541         * fbsd-nat.c: Revert.
12542         * f-valprint.c: Revert.
12543         * f-typeprint.c: Revert.
12544         * f-lang.c: Revert.
12545         * extension.h: Revert.
12546         * extension.c: Revert.
12547         * extension-priv.h: Revert.
12548         * expprint.c: Revert.
12549         * exec.h: Revert.
12550         * exec.c: Revert.
12551         * exceptions.c: Revert.
12552         * event-top.c: Revert.
12553         * event-loop.c: Revert.
12554         * eval.c: Revert.
12555         * elfread.c: Revert.
12556         * dwarf2read.h: Revert.
12557         * dwarf2read.c: Revert.
12558         * dwarf2loc.c: Revert.
12559         * dwarf2expr.h: Revert.
12560         * dwarf2expr.c: Revert.
12561         * dwarf2-frame.c: Revert.
12562         * dwarf2-frame-tailcall.c: Revert.
12563         * dwarf-index-write.h: Revert.
12564         * dwarf-index-write.c: Revert.
12565         * dwarf-index-common.c: Revert.
12566         * dwarf-index-cache.h: Revert.
12567         * dwarf-index-cache.c: Revert.
12568         * dummy-frame.c: Revert.
12569         * dtrace-probe.c: Revert.
12570         * disasm.h: Revert.
12571         * disasm.c: Revert.
12572         * disasm-selftests.c: Revert.
12573         * dictionary.c: Revert.
12574         * dicos-tdep.c: Revert.
12575         * demangle.c: Revert.
12576         * dcache.h: Revert.
12577         * dcache.c: Revert.
12578         * darwin-nat.h: Revert.
12579         * darwin-nat.c: Revert.
12580         * darwin-nat-info.c: Revert.
12581         * d-valprint.c: Revert.
12582         * d-namespace.c: Revert.
12583         * d-lang.c: Revert.
12584         * ctf.c: Revert.
12585         * csky-tdep.c: Revert.
12586         * csky-linux-tdep.c: Revert.
12587         * cris-tdep.c: Revert.
12588         * cris-linux-tdep.c: Revert.
12589         * cp-valprint.c: Revert.
12590         * cp-support.c: Revert.
12591         * cp-namespace.c: Revert.
12592         * cp-abi.c: Revert.
12593         * corelow.c: Revert.
12594         * corefile.c: Revert.
12595         * continuations.c: Revert.
12596         * completer.h: Revert.
12597         * completer.c: Revert.
12598         * complaints.c: Revert.
12599         * coffread.c: Revert.
12600         * coff-pe-read.c: Revert.
12601         * cli-out.h: Revert.
12602         * cli-out.c: Revert.
12603         * charset.c: Revert.
12604         * c-varobj.c: Revert.
12605         * c-valprint.c: Revert.
12606         * c-typeprint.c: Revert.
12607         * c-lang.c: Revert.
12608         * buildsym.c: Revert.
12609         * buildsym-legacy.c: Revert.
12610         * build-id.h: Revert.
12611         * build-id.c: Revert.
12612         * btrace.c: Revert.
12613         * bsd-uthread.c: Revert.
12614         * breakpoint.h: Revert.
12615         * breakpoint.c: Revert.
12616         * break-catch-throw.c: Revert.
12617         * break-catch-syscall.c: Revert.
12618         * break-catch-sig.c: Revert.
12619         * blockframe.c: Revert.
12620         * block.c: Revert.
12621         * bfin-tdep.c: Revert.
12622         * bfin-linux-tdep.c: Revert.
12623         * bfd-target.c: Revert.
12624         * bcache.c: Revert.
12625         * ax-general.c: Revert.
12626         * ax-gdb.h: Revert.
12627         * ax-gdb.c: Revert.
12628         * avr-tdep.c: Revert.
12629         * auxv.c: Revert.
12630         * auto-load.c: Revert.
12631         * arm-wince-tdep.c: Revert.
12632         * arm-tdep.c: Revert.
12633         * arm-symbian-tdep.c: Revert.
12634         * arm-pikeos-tdep.c: Revert.
12635         * arm-obsd-tdep.c: Revert.
12636         * arm-nbsd-tdep.c: Revert.
12637         * arm-nbsd-nat.c: Revert.
12638         * arm-linux-tdep.c: Revert.
12639         * arm-linux-nat.c: Revert.
12640         * arm-fbsd-tdep.c: Revert.
12641         * arm-fbsd-nat.c: Revert.
12642         * arm-bsd-tdep.c: Revert.
12643         * arch-utils.c: Revert.
12644         * arc-tdep.c: Revert.
12645         * arc-newlib-tdep.c: Revert.
12646         * annotate.h: Revert.
12647         * annotate.c: Revert.
12648         * amd64-windows-tdep.c: Revert.
12649         * amd64-windows-nat.c: Revert.
12650         * amd64-tdep.c: Revert.
12651         * amd64-sol2-tdep.c: Revert.
12652         * amd64-obsd-tdep.c: Revert.
12653         * amd64-obsd-nat.c: Revert.
12654         * amd64-nbsd-tdep.c: Revert.
12655         * amd64-nbsd-nat.c: Revert.
12656         * amd64-nat.c: Revert.
12657         * amd64-linux-tdep.c: Revert.
12658         * amd64-linux-nat.c: Revert.
12659         * amd64-fbsd-tdep.c: Revert.
12660         * amd64-fbsd-nat.c: Revert.
12661         * amd64-dicos-tdep.c: Revert.
12662         * amd64-darwin-tdep.c: Revert.
12663         * amd64-bsd-nat.c: Revert.
12664         * alpha-tdep.c: Revert.
12665         * alpha-obsd-tdep.c: Revert.
12666         * alpha-nbsd-tdep.c: Revert.
12667         * alpha-mdebug-tdep.c: Revert.
12668         * alpha-linux-tdep.c: Revert.
12669         * alpha-linux-nat.c: Revert.
12670         * alpha-bsd-tdep.c: Revert.
12671         * alpha-bsd-nat.c: Revert.
12672         * aix-thread.c: Revert.
12673         * agent.c: Revert.
12674         * addrmap.c: Revert.
12675         * ada-varobj.c: Revert.
12676         * ada-valprint.c: Revert.
12677         * ada-typeprint.c: Revert.
12678         * ada-tasks.c: Revert.
12679         * ada-lang.c: Revert.
12680         * aarch64-tdep.c: Revert.
12681         * aarch64-ravenscar-thread.c: Revert.
12682         * aarch64-newlib-tdep.c: Revert.
12683         * aarch64-linux-tdep.c: Revert.
12684         * aarch64-linux-nat.c: Revert.
12685         * aarch64-fbsd-tdep.c: Revert.
12686         * aarch64-fbsd-nat.c: Revert.
12687         * aarch32-linux-nat.c: Revert.
12688
12689 2019-04-05  Tom Tromey  <tom@tromey.com>
12690
12691         * ft32-tdep.c: Sort headers.
12692         * frv-tdep.c: Sort headers.
12693         * frv-linux-tdep.c: Sort headers.
12694         * frame.c: Sort headers.
12695         * frame-unwind.c: Sort headers.
12696         * frame-base.c: Sort headers.
12697         * fork-child.c: Sort headers.
12698         * findvar.c: Sort headers.
12699         * findcmd.c: Sort headers.
12700         * filesystem.c: Sort headers.
12701         * filename-seen-cache.h: Sort headers.
12702         * filename-seen-cache.c: Sort headers.
12703         * fbsd-tdep.c: Sort headers.
12704         * fbsd-nat.h: Sort headers.
12705         * fbsd-nat.c: Sort headers.
12706         * f-valprint.c: Sort headers.
12707         * f-typeprint.c: Sort headers.
12708         * f-lang.c: Sort headers.
12709         * extension.h: Sort headers.
12710         * extension.c: Sort headers.
12711         * extension-priv.h: Sort headers.
12712         * expprint.c: Sort headers.
12713         * exec.h: Sort headers.
12714         * exec.c: Sort headers.
12715         * exceptions.c: Sort headers.
12716         * event-top.c: Sort headers.
12717         * event-loop.c: Sort headers.
12718         * eval.c: Sort headers.
12719         * elfread.c: Sort headers.
12720         * dwarf2read.h: Sort headers.
12721         * dwarf2read.c: Sort headers.
12722         * dwarf2loc.c: Sort headers.
12723         * dwarf2expr.h: Sort headers.
12724         * dwarf2expr.c: Sort headers.
12725         * dwarf2-frame.c: Sort headers.
12726         * dwarf2-frame-tailcall.c: Sort headers.
12727         * dwarf-index-write.h: Sort headers.
12728         * dwarf-index-write.c: Sort headers.
12729         * dwarf-index-common.c: Sort headers.
12730         * dwarf-index-cache.h: Sort headers.
12731         * dwarf-index-cache.c: Sort headers.
12732         * dummy-frame.c: Sort headers.
12733         * dtrace-probe.c: Sort headers.
12734         * disasm.h: Sort headers.
12735         * disasm.c: Sort headers.
12736         * disasm-selftests.c: Sort headers.
12737         * dictionary.c: Sort headers.
12738         * dicos-tdep.c: Sort headers.
12739         * demangle.c: Sort headers.
12740         * dcache.h: Sort headers.
12741         * dcache.c: Sort headers.
12742         * darwin-nat.h: Sort headers.
12743         * darwin-nat.c: Sort headers.
12744         * darwin-nat-info.c: Sort headers.
12745         * d-valprint.c: Sort headers.
12746         * d-namespace.c: Sort headers.
12747         * d-lang.c: Sort headers.
12748         * ctf.c: Sort headers.
12749         * csky-tdep.c: Sort headers.
12750         * csky-linux-tdep.c: Sort headers.
12751         * cris-tdep.c: Sort headers.
12752         * cris-linux-tdep.c: Sort headers.
12753         * cp-valprint.c: Sort headers.
12754         * cp-support.c: Sort headers.
12755         * cp-namespace.c: Sort headers.
12756         * cp-abi.c: Sort headers.
12757         * corelow.c: Sort headers.
12758         * corefile.c: Sort headers.
12759         * continuations.c: Sort headers.
12760         * completer.h: Sort headers.
12761         * completer.c: Sort headers.
12762         * complaints.c: Sort headers.
12763         * coffread.c: Sort headers.
12764         * coff-pe-read.c: Sort headers.
12765         * cli-out.h: Sort headers.
12766         * cli-out.c: Sort headers.
12767         * charset.c: Sort headers.
12768         * c-varobj.c: Sort headers.
12769         * c-valprint.c: Sort headers.
12770         * c-typeprint.c: Sort headers.
12771         * c-lang.c: Sort headers.
12772         * buildsym.c: Sort headers.
12773         * buildsym-legacy.c: Sort headers.
12774         * build-id.h: Sort headers.
12775         * build-id.c: Sort headers.
12776         * btrace.c: Sort headers.
12777         * bsd-uthread.c: Sort headers.
12778         * breakpoint.h: Sort headers.
12779         * breakpoint.c: Sort headers.
12780         * break-catch-throw.c: Sort headers.
12781         * break-catch-syscall.c: Sort headers.
12782         * break-catch-sig.c: Sort headers.
12783         * blockframe.c: Sort headers.
12784         * block.c: Sort headers.
12785         * bfin-tdep.c: Sort headers.
12786         * bfin-linux-tdep.c: Sort headers.
12787         * bfd-target.c: Sort headers.
12788         * bcache.c: Sort headers.
12789         * ax-general.c: Sort headers.
12790         * ax-gdb.h: Sort headers.
12791         * ax-gdb.c: Sort headers.
12792         * avr-tdep.c: Sort headers.
12793         * auxv.c: Sort headers.
12794         * auto-load.c: Sort headers.
12795         * arm-wince-tdep.c: Sort headers.
12796         * arm-tdep.c: Sort headers.
12797         * arm-symbian-tdep.c: Sort headers.
12798         * arm-pikeos-tdep.c: Sort headers.
12799         * arm-obsd-tdep.c: Sort headers.
12800         * arm-nbsd-tdep.c: Sort headers.
12801         * arm-nbsd-nat.c: Sort headers.
12802         * arm-linux-tdep.c: Sort headers.
12803         * arm-linux-nat.c: Sort headers.
12804         * arm-fbsd-tdep.c: Sort headers.
12805         * arm-fbsd-nat.c: Sort headers.
12806         * arm-bsd-tdep.c: Sort headers.
12807         * arch-utils.c: Sort headers.
12808         * arc-tdep.c: Sort headers.
12809         * arc-newlib-tdep.c: Sort headers.
12810         * annotate.h: Sort headers.
12811         * annotate.c: Sort headers.
12812         * amd64-windows-tdep.c: Sort headers.
12813         * amd64-windows-nat.c: Sort headers.
12814         * amd64-tdep.c: Sort headers.
12815         * amd64-sol2-tdep.c: Sort headers.
12816         * amd64-obsd-tdep.c: Sort headers.
12817         * amd64-obsd-nat.c: Sort headers.
12818         * amd64-nbsd-tdep.c: Sort headers.
12819         * amd64-nbsd-nat.c: Sort headers.
12820         * amd64-nat.c: Sort headers.
12821         * amd64-linux-tdep.c: Sort headers.
12822         * amd64-linux-nat.c: Sort headers.
12823         * amd64-fbsd-tdep.c: Sort headers.
12824         * amd64-fbsd-nat.c: Sort headers.
12825         * amd64-dicos-tdep.c: Sort headers.
12826         * amd64-darwin-tdep.c: Sort headers.
12827         * amd64-bsd-nat.c: Sort headers.
12828         * alpha-tdep.c: Sort headers.
12829         * alpha-obsd-tdep.c: Sort headers.
12830         * alpha-nbsd-tdep.c: Sort headers.
12831         * alpha-mdebug-tdep.c: Sort headers.
12832         * alpha-linux-tdep.c: Sort headers.
12833         * alpha-linux-nat.c: Sort headers.
12834         * alpha-bsd-tdep.c: Sort headers.
12835         * alpha-bsd-nat.c: Sort headers.
12836         * aix-thread.c: Sort headers.
12837         * agent.c: Sort headers.
12838         * addrmap.c: Sort headers.
12839         * ada-varobj.c: Sort headers.
12840         * ada-valprint.c: Sort headers.
12841         * ada-typeprint.c: Sort headers.
12842         * ada-tasks.c: Sort headers.
12843         * ada-lang.c: Sort headers.
12844         * aarch64-tdep.c: Sort headers.
12845         * aarch64-ravenscar-thread.c: Sort headers.
12846         * aarch64-newlib-tdep.c: Sort headers.
12847         * aarch64-linux-tdep.c: Sort headers.
12848         * aarch64-linux-nat.c: Sort headers.
12849         * aarch64-fbsd-tdep.c: Sort headers.
12850         * aarch64-fbsd-nat.c: Sort headers.
12851         * aarch32-linux-nat.c: Sort headers.
12852
12853 2019-04-04  Tom Tromey  <tom@tromey.com>
12854
12855         * varobj.c (varobj_create): Update.
12856         * rust-exp.y (struct rust_parser) <update_innermost_block,
12857         lookup_symbol>: New methods.
12858         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12859         Rename.
12860         (rust_parser::rust_lookup_type)
12861         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12862         * printcmd.c (display_command, do_one_display): Update.
12863         * parser-defs.h (struct parser_state) <parser_state>: Add
12864         "tracker" parameter.
12865         (block_tracker): New member.
12866         (class innermost_block_tracker) <innermost_block_tracker>: Add
12867         "types" parameter.
12868         <reset>: Remove method.
12869         (innermost_block): Don't declare.
12870         (null_post_parser): Update.
12871         * parse.c (innermost_block): Remove global.
12872         (write_dollar_variable): Update.
12873         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12874         Remove "tracker_types" parameter.
12875         (parse_expression): Add "tracker" parameter.
12876         (parse_expression_for_completion): Update.
12877         (null_post_parser): Add "tracker" parameter.
12878         * p-exp.y: Update rules.
12879         * m2-exp.y: Update rules.
12880         * language.h (struct language_defn) <la_post_parser>: Add
12881         "tracker" parameter.
12882         * go-exp.y: Update rules.
12883         * f-exp.y: Update rules.
12884         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12885         parameter.
12886         * d-exp.y: Update rules.
12887         * c-exp.y: Update rules.
12888         * breakpoint.c (set_breakpoint_condition): Create an
12889         innermost_block_tracker.
12890         (watch_command_1): Likewise.
12891         * ada-lang.c (resolve): Add "tracker" parameter.
12892         (resolve_subexp): Likewise.
12893         * ada-exp.y (write_var_from_sym): Update.
12894
12895 2019-04-04  Tom Tromey  <tom@tromey.com>
12896
12897         * type-stack.h: New file.
12898         * type-stack.c: New file.
12899         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12900         type-stack.h.
12901         (insert_into_type_stack, insert_type, push_type, push_type_int)
12902         (insert_type_address_space, pop_type, pop_type_int)
12903         (pop_typelist, pop_type_stack, append_type_stack)
12904         (push_type_stack, get_type_stack, push_typelist)
12905         (follow_type_instance_flags, follow_types): Don't declare.
12906         * parse.c (type_stack): Remove global.
12907         (parse_exp_in_context): Update.
12908         (insert_into_type_stack, insert_type, push_type, push_type_int)
12909         (insert_type_address_space, pop_type, pop_type_int)
12910         (pop_typelist, pop_type_stack, append_type_stack)
12911         (push_type_stack, get_type_stack, push_typelist)
12912         (follow_type_instance_flags, follow_types): Remove (moved to
12913         type-stack.c).
12914         * f-exp.y (type_stack): New global.
12915         Update rules.
12916         (push_kind_type, f_parse): Update.
12917         * d-exp.y (type_stack): New global.
12918         Update rules.
12919         (d_parse): Update.
12920         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12921         Update rules.
12922         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12923         (HFILES_NO_SRCDIR): Add type-stack.h.
12924
12925 2019-04-04  Tom Tromey  <tom@tromey.com>
12926
12927         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12928         (rust_parser::convert_ast_to_expression, rust_parse)
12929         (rust_lex_test_completion, rust_lex_tests): Update.
12930         * parser-defs.h (struct expr_completion_state): New.
12931         (struct parser_state) <parser_state>: Add completion parameter.
12932         <mark_struct_expression, mark_completion_tag>: New methods.
12933         <parse_completion, m_completion_state>: New members.
12934         (prefixify_expression, null_post_parser): Update.
12935         (mark_struct_expression, mark_completion_tag): Don't declare.
12936         * parse.c (parse_completion, expout_last_struct)
12937         (expout_tag_completion_type, expout_completion_name): Remove
12938         globals.
12939         (parser_state::mark_struct_expression)
12940         (parser_state::mark_completion_tag): Now methods.
12941         (prefixify_expression): Add last_struct parameter.
12942         (prefixify_subexp): Likewise.
12943         (parse_exp_1): Update.
12944         (parse_exp_in_context): Add cstate parameter.  Update.
12945         (parse_expression_for_completion): Create an
12946         expr_completion_state.
12947         (null_post_parser): Add "completion" parameter.
12948         * p-exp.y: Update rules.
12949         (yylex): Update.
12950         * language.h (struct language_defn) <la_post_parser>: Add
12951         "completing" parameter.
12952         * go-exp.y: Update rules.
12953         (lex_one_token): Update.
12954         * expression.h (parse_completion): Don't declare.
12955         * d-exp.y: Update rules.
12956         (lex_one_token): Update rules.
12957         * c-exp.y: Update rules.
12958         (lex_one_token): Update.
12959         * ada-lang.c (resolve): Add "parse_completion" parameter.
12960         (resolve_subexp): Likewise.
12961         (ada_resolve_function): Likewise.
12962
12963 2019-04-04  Tom Tromey  <tom@tromey.com>
12964
12965         * parser-defs.h (struct parser_state) <start_arglist,
12966         end_arglist>: New methods.
12967         <arglist_len, m_funcall_chain>: New members.
12968         (arglist_len, start_arglist, end_arglist): Don't declare.
12969         * parse.c (arglist_len, funcall_chain): Remove global.
12970         (start_arglist, end_arglist): Remove functions.
12971         (parse_exp_in_context): Update.
12972         * p-exp.y: Update rules.
12973         * m2-exp.y: Update rules.
12974         * go-exp.y: Update rules.
12975         * f-exp.y: Update rules.
12976         * d-exp.y: Update rules.
12977         * c-exp.y: Update rules.
12978
12979 2019-04-04  Tom Tromey  <tom@tromey.com>
12980
12981         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12982         lex_operator, push_back>: New methods.
12983         Update all rules.
12984         (rust_parser::lex_hex, lex_escape): Rename and update.
12985         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12986         (rust_parser::lex_operator): Rename and update.
12987         (rust_parser::lex_number, rustyylex, rustyyerror)
12988         (rust_lex_test_init, rust_lex_test_sequence)
12989         (rust_lex_test_push_back, rust_lex_tests): Update.
12990         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12991         parameter.
12992         <lexptr, prev_lexptr>: New members.
12993         (lexptr, prev_lexptr): Don't declare.
12994         * parse.c (lexptr, prev_lexptr): Remove globals.
12995         (parse_exp_in_context): Update.
12996         * p-exp.y (yylex, yyerror): Update.
12997         * m2-exp.y (parse_number, yylex, yyerror): Update.
12998         * go-exp.y (lex_one_token, yyerror): Update.
12999         * f-exp.y (match_string_literal, yylex, yyerror): Update.
13000         * d-exp.y (lex_one_token, yyerror): Update.
13001         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13002         (lex_one_token, yyerror): Update.
13003         * ada-lex.l (YY_INPUT): Update.
13004         (rewind_to_char): Update.
13005         * ada-exp.y (yyerror): Update.
13006
13007 2019-04-04  Tom Tromey  <tom@tromey.com>
13008
13009         * rust-exp.y (rustyylex, rust_lex_tests): Update.
13010         * parser-defs.h (struct parser_state) <parser_state>: Add new
13011         parameter.
13012         <comma_terminates>: New member.
13013         (comma_terminates): Don't declare global.
13014         * parse.c (comma_terminates): Remove global.
13015         (parse_exp_in_context): Update.
13016         * p-exp.y (yylex): Update.
13017         * m2-exp.y (yylex): Update.
13018         * go-exp.y (lex_one_token): Update.
13019         * f-exp.y (yylex): Update.
13020         * d-exp.y (lex_one_token): Update.
13021         * c-exp.y (lex_one_token): Update.
13022         * ada-lex.l: Update.
13023
13024 2019-04-04  Tom Tromey  <tom@tromey.com>
13025
13026         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13027         (rustyylex, rust_lex_test_init, rust_lex_test_one)
13028         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13029         * parser-defs.h (paren_depth): Don't declare.
13030         * parse.c (paren_depth): Remove global.
13031         (parse_exp_in_context): Update.
13032         * p-exp.y (paren_depth): New global.
13033         (pascal_parse): Initialize it.
13034         * m2-exp.y (paren_depth): New global.
13035         (m2_parse): Initialize it.
13036         * go-exp.y (paren_depth): New global.
13037         (go_parse): Initialize it.
13038         * f-exp.y (paren_depth): New global.
13039         (f_parse): Initialize it.
13040         * d-exp.y (paren_depth): New global.
13041         (d_parse): Initialize it.
13042         * c-exp.y (paren_depth): New global.
13043         (c_parse): Initialize it.
13044         * ada-lex.l (paren_depth): New global.
13045         (lexer_init): Initialize it.
13046
13047 2019-04-04  Tom Tromey  <tom@tromey.com>
13048
13049         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13050         (rust_parser::convert_ast_to_type)
13051         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13052         * parser-defs.h (struct parser_state) <parser_state>: Add
13053         parameters.  Initialize new members.
13054         <expression_context_block, expression_context_pc>: New members.
13055         * parse.c (expression_context_block, expression_context_pc):
13056         Remove globals.
13057         (parse_exp_in_context): Update.
13058         * p-exp.y: Update all rules.
13059         (yylex): Update.
13060         * m2-exp.y: Update all rules.
13061         (yylex): Update.
13062         * go-exp.y (yylex): Update.
13063         * f-exp.y (yylex): Update.
13064         * d-exp.y: Update all rules.
13065         (yylex): Update.
13066         * c-exp.y: Update all rules.
13067         (lex_one_token, classify_name, yylex, c_parse): Update.
13068         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13069
13070 2019-04-04  Tom Tromey  <tom@tromey.com>
13071
13072         * gdbarch.h, gdbarch.c: Rebuild.
13073         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13074         * stap-probe.h:
13075         (struct stap_parse_info): Replace "parser_state" with
13076         "expr_builder".
13077         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13078         (parser_state): New class.
13079         * parse.c (expr_builder): Rename.
13080         (expr_builder::release): Rename.
13081         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13082         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13083         (write_exp_elt_longcst, write_exp_elt_floatcst)
13084         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13085         (write_exp_string_vector, write_exp_bitstring)
13086         (write_exp_msymbol, mark_struct_expression)
13087         (write_dollar_variable)
13088         (insert_type_address_space, increase_expout_size): Replace
13089         "parser_state" with "expr_builder".
13090         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13091         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13092         "parser_state" with "expr_builder".
13093
13094 2019-04-04  Tom Tromey  <tom@tromey.com>
13095
13096         * rust-exp.y: Replace "parse_language" with method call.
13097         * p-exp.y:
13098         (yylex): Replace "parse_language" with method call.
13099         * m2-exp.y:
13100         (yylex): Replace "parse_language" with method call.
13101         * go-exp.y (classify_name): Replace "parse_language" with method
13102         call.
13103         * f-exp.y (yylex): Replace "parse_language" with method call.
13104         * d-exp.y (lex_one_token): Replace "parse_language" with method
13105         call.
13106         * c-exp.y:
13107         (lex_one_token, classify_name, yylex): Replace "parse_language"
13108         with method call.
13109         * ada-exp.y (find_primitive_type, type_char)
13110         (type_system_address): Replace "parse_language" with method call.
13111
13112 2019-04-04  Tom Tromey  <tom@tromey.com>
13113
13114         * rust-exp.y: Replace "parse_gdbarch" with method call.
13115         * parse.c (write_dollar_variable, insert_type_address_space):
13116         Replace "parse_gdbarch" with method call.
13117         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13118         call.
13119         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13120         call.
13121         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13122         "parse_gdbarch" with method call.
13123         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13124         with method call.
13125         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13126         "parse_gdbarch" with method call.
13127         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13128         "parse_gdbarch" with method call.
13129         * c-exp.y (parse_type, parse_number, classify_name): Replace
13130         "parse_gdbarch" with method call.
13131         * ada-lex.l: Replace "parse_gdbarch" with method call.
13132         * ada-exp.y (parse_type, find_primitive_type, type_char)
13133         (type_system_address): Replace "parse_gdbarch" with method call.
13134
13135 2019-04-04  Tom Tromey  <tom@tromey.com>
13136
13137         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13138         * stap-probe.c (stap_parse_argument): Update.
13139         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13140         initial_size parameter.
13141         * rust-exp.y (rust_lex_tests): Update.
13142         * parse.c (parser_state): Update.
13143         (parse_exp_in_context): Update.
13144         * parser-defs.h (struct parser_state) <parser_state>: Remove
13145         "initial_size" parameter.
13146
13147 2019-04-04  Tom Tromey  <tom@tromey.com>
13148
13149         * parser-defs.h (increase_expout_size): Don't declare.
13150         * parse.c (increase_expout_size): Now static.
13151
13152 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13153
13154         * gnu-nat.c (gnu_nat_target::wait): Fix
13155         target_waitstatus_to_string call.
13156
13157 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13158
13159         * eval.c (evaluate_subexp_standard): Handle internal functions
13160         during Fortran function call handling.
13161
13162 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13163
13164         * NEWS: Mention new internal functions.
13165         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13166         (read_base_type): Use dwarf2_init_complex_target_type.
13167         * value.c (creal_internal_fn): New function.
13168         (cimag_internal_fn): New function.
13169         (_initialize_values): Register new internal functions.
13170
13171 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13172
13173         * infrun.c (stop_all_threads): If debug_infrun, always
13174         trace the wait status after wait_one, using
13175         target_waitstatus_to_string and target_pid_to_str.
13176         (handle_inferior_event): Replace various trace of
13177         wait status kind by a single trace.
13178         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13179         wait status kind image by target_waitstatus_to_string.
13180         * target/waitstatus.c (target_waitstatus_to_string): Fix
13181         obsolete comment.
13182
13183 2019-04-01  Tom Tromey  <tromey@adacore.com>
13184
13185         PR symtab/23331:
13186         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13187
13188 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13189             Pedro Alves  <palves@redhat.com>
13190
13191         * top.c (quit_force): Call 'finalize_values'.
13192         * value.c (finalize_values): New function.
13193         * value.h (finalize_values): Declare.
13194
13195 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13196
13197         * NEWS: Announce $_gdb_major and $_gdb_minor.
13198
13199         * top.c (init_gdb_version_vars): New function.
13200         (gdb_init): Call init_gdb_version_vars.
13201
13202 2019-03-29  Tom Tromey  <tromey@adacore.com>
13203
13204         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13205         help text.  Remove dead code.
13206
13207 2019-03-29  Keith Seitz  <keiths@redhat.com>
13208
13209         From Siddhesh Poyarekar:
13210         * f-lang.h (f77_get_upperbound): Return LONGEST.
13211         (f77_get_lowerbound): Likewise.
13212         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13213         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13214         print them.
13215         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13216         plongest to format print it.
13217         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13218         (f77_get_upperbound): Likewise.
13219         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13220         LOWER_BOUND to LONGEST.
13221         (f77_create_arrayprint_offset_tbl): Likewise.
13222
13223 2019-03-29  Keith Seitz  <keiths@redhat.com>
13224
13225         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13226         %s/pulongest for TYPE_LENGTH instead of %d in format
13227         strings.
13228         * ada-typerint.c (ada_print_type): Likewise.
13229         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13230         * compile/compile-c-support.c (generate_register_struct): Likewise.
13231         * gdbtypes.c (recursive_dump_type): Likewise.
13232         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13233         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13234         instead of %d in format strings.
13235         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13236         to std::min to ULONGEST.
13237         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13238         instead of %d in format strings.
13239         * tracepoint.c (info_scope_command): Likewise.
13240         * typeprint.c (print_offset_data::update)
13241         (print_offset_data::finish): Likewise.
13242         * xtensa-tdep.c (xtensa_store_return_value)
13243         (xtensa_push_dummy_call): Likewise.
13244
13245 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13246
13247         * windows-nat.c (display_selector): Fixed format specifications
13248         for 64-bit Cygwin.
13249
13250 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13251
13252         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13253
13254 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13255
13256         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13257         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13258         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13259         (nios2_linux_init_abi): Install it.
13260
13261 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13262
13263         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13264
13265 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13266
13267         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13268
13269 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13270             Tom Tromey  <tromey@adacore.com>
13271
13272         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13273
13274 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13275
13276         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13277         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13278         method to compute the bounds of range types. Also print "[evaluated]"
13279         if the bounds' values come from a dynamic evaluation.
13280
13281 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13282
13283         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13284         whitespace when pretty printing is on.
13285
13286 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13287
13288         * ppc-linux-nat.c: Add include.
13289
13290 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13291
13292         * NEWS: Mention AArch64 Pointer Authentication.
13293
13294 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13295
13296         * arm-linux-nat.c: Add include.
13297
13298 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13299
13300         * source-cache.c (source_cache::get_source_lines): Re-read
13301         fullname after calling open_source_file.
13302
13303 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13304
13305         * NEWS: Mention TLS support for FreeBSD.
13306
13307 2019-03-25  Tom Tromey  <tromey@adacore.com>
13308
13309         * minsyms.c (BUNCH_SIZE): Update comment.
13310         (~minimal_symbol_reader): Remove old comment.
13311         (compact_minimal_symbols): Update comment.
13312         (minimal_symbol_reader::install): Remove old comment.  Update
13313         other comments.
13314
13315 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13316
13317         * s390-linux-nat.c: Add include.
13318
13319 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13320
13321         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13322         Call linux_get_hwcap.
13323         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13324         Likewise.
13325         (aarch64_linux_get_hwcap): Remove function.
13326         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13327         declaration.
13328         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13329         linux_get_hwcap.
13330         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13331         * linux-tdep.c (linux_get_hwcap): Add function.
13332         (linux_get_hwcap2): Likewise.
13333         * linux-tdep.h (linux_get_hwcap): Add declaration.
13334         (linux_get_hwcap2): Likewise.
13335         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13336         (ppc_linux_get_hwcap2): Likewise.
13337         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13338         linux_get_hwcap.
13339         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13340         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13341         (ppc_linux_nat_target::read_description): Likewise.
13342         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13343         * s390-linux-nat.c: Likewise.
13344         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13345
13346 2019-03-24  Tom Tromey  <tom@tromey.com>
13347
13348         * ada-lang.c (standard_lookup): Simplify initialization.
13349         (ada_lookup_symbol_nonlocal): Simplify return.
13350         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13351         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13352         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13353         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13354         initialization.
13355         * solib.c (solib_global_lookup): Simplify.
13356         * symtab.c (null_block_symbol): Remove.
13357         (symbol_cache_lookup): Simplify returns.
13358         (lookup_language_this): Simplify returns.
13359         (lookup_symbol_aux): Simplify return.
13360         (lookup_local_symbol): Simplify returns.
13361         (lookup_global_symbol_from_objfile): Simplify return.
13362         (lookup_symbol_in_objfile_symtabs)
13363         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13364         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13365         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13366         * cp-namespace.c (cp_lookup_bare_symbol)
13367         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13368         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13369         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13370         (cp_lookup_symbol_via_imports): Simplify initialization.
13371         (find_symbol_in_baseclass): Likewise.
13372         * symtab.h (null_block_symbol): Remove.
13373         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13374         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13375         (d_lookup_symbol_module): Likewise.
13376         (find_symbol_in_baseclass): Simplify initialization.
13377
13378 2019-03-24  Tom Tromey  <tom@tromey.com>
13379
13380         * expression.h: Don't include symtab.h.
13381         (struct block): Forward declare.
13382
13383 2019-03-24  Tom Tromey  <tom@tromey.com>
13384
13385         * c-exp.y (typebase): Remove casts.
13386         * gdbtypes.c (lookup_unsigned_typename, )
13387         (lookup_signed_typename): Remove cast.
13388         * eval.c (parse_to_comma_and_eval): Remove cast.
13389         * parse.c (write_dollar_variable): Remove cast.
13390         * block.h (struct block) <superblock>: Now const.
13391         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13392         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13393         (map_block): Make "block" const.
13394         * symfile.h (struct quick_symbol_functions)
13395         <map_matching_symbols>: Constify block argument to "callback".
13396         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13397         const.
13398         (find_pc_sect_compunit_symtab): Make "b" const.
13399         (find_symbol_at_address): Likewise.
13400         (search_symbols): Likewise.
13401         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13402         (dw2_debug_names_lookup_symbol): Likewise.
13403         (dw2_map_matching_symbols): Update.
13404         * p-valprint.c (pascal_val_print): Remove "block".
13405         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13406         (aux_add_nonlocal_symbols): Make "block" const.
13407         (resolve_subexp): Remove cast.
13408         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13409         const.
13410         (iterate_over_file_blocks): Likewise.
13411         * f-exp.y (%union) <bval>: Remove.
13412         * coffread.c (patch_opaque_types): Make "b" const.
13413         * spu-tdep.c (spu_catch_start): Make "block" const.
13414         * c-valprint.c (print_unpacked_pointer): Remove "block".
13415         * symmisc.c (dump_symtab_1): Make "b" const.
13416         (block_depth): Make "block" const.
13417         * d-exp.y (%union) <bval>: Remove.
13418         * cp-support.h (cp_lookup_rtti_type): Update.
13419         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13420         * psymtab.c (psym_lookup_symbol): Make "block" const.
13421         (maintenance_check_psymtabs): Make "b" const.
13422         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13423         (enumerate_locals, enumerate_args): Update.
13424         * python/py-symtab.c (stpy_global_block): Make "block" const.
13425         (stpy_static_block): Likewise.
13426         * inline-frame.c (block_starting_point_at): Make "new_block"
13427         const.
13428         * block.c (find_block_in_blockvector): Make return type const.
13429         (blockvector_for_pc_sect): Make "b" const.
13430         (find_block_in_blockvector): Make "b" const.
13431
13432 2019-03-23  Tom Tromey  <tom@tromey.com>
13433
13434         * varobj.c (varobj_create): Update.
13435         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13436         * printcmd.c (display_command, do_one_display): Don't reset
13437         innermost_block.
13438         * parser-defs.h (enum innermost_block_tracker_type): Move to
13439         expression.h.
13440         (innermost_block): Update comment.
13441         * parse.c (parse_exp_1): Add tracker_types parameter.
13442         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13443         tracker_types parameter.  Reset innermost_block.
13444         (parse_exp_in_context): Remove.
13445         (parse_expression_for_completion): Update.
13446         * objfiles.c (~objfile): Don't reset expression_context_block or
13447         innermost_block.
13448         * expression.h (enum innermost_block_tracker_type): Move from
13449         parser-defs.h.
13450         (parse_exp_1): Add tracker_types parameter.
13451         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13452         reset innermost_block.
13453
13454 2019-03-23  Tom Tromey  <tom@tromey.com>
13455
13456         * objfiles.h: Include bcache.h.
13457
13458 2019-03-23  Tom Tromey  <tom@tromey.com>
13459
13460         * linespec.c (get_current_search_block): Use
13461         scoped_restore_current_language.
13462         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13463
13464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13465             Jiong Wang  <jiong.wang@arm.com>
13466
13467         * aarch64-linux-tdep.c
13468         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13469         section.
13470         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13471
13472 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13473             Jiong Wang  <jiong.wang@arm.com>
13474
13475         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13476         instructions.
13477         (aarch64_analyze_prologue_test): Add PACIASP test.
13478         (aarch64_prologue_prev_register): Unmask PC value.
13479
13480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13481             Jiong Wang  <jiong.wang@arm.com>
13482
13483         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13484         (aarch64_dwarf2_prev_register): Unmask PC value.
13485         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13486         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13487         DW_CFA_AARCH64_negate_ra_state.
13488         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13489
13490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13491             Jiong Wang  <jiong.wang@arm.com>
13492
13493         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13494         registers.
13495         (aarch64_pseudo_register_name): Likewise.
13496         (aarch64_pseudo_register_type): Likewise.
13497         (aarch64_pseudo_register_reggroup_p): Likewise.
13498         (aarch64_gdbarch_init): Add pauth registers.
13499         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13500         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13501         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13502         (struct gdbarch_tdep): Add regnum for ra_state.
13503
13504 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13505             Jiong Wang  <jiong.wang@arm.com>
13506
13507         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13508
13509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13510             Jiong Wang  <jiong.wang@arm.com>
13511
13512         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13513         function.
13514         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13515         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13516         (aarch64_gdbarch_init): Add puth registers.
13517         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13518         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13519         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13520
13521 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13522             Jiong Wang  <jiong.wang@arm.com>
13523
13524         * aarch64-linux-nat.c
13525         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13526         * aarch64-linux-tdep.c
13527         (aarch64_linux_core_read_description): Likewise.
13528         (aarch64_linux_get_hwcap): New function.
13529         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13530         (aarch64_linux_get_hwcap): New declaration.
13531
13532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13533             Jiong Wang  <jiong.wang@arm.com>
13534
13535         * aarch64-linux-nat.c
13536         (aarch64_linux_nat_target::read_description): Add pauth param.
13537         * aarch64-linux-tdep.c
13538         (aarch64_linux_core_read_description): Likewise.
13539         * aarch64-tdep.c (struct target_desc): Add in pauth.
13540         (aarch64_read_description): Add pauth param.
13541         (aarch64_gdbarch_init): Likewise.
13542         * aarch64-tdep.h (aarch64_read_description): Likewise.
13543         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13544         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13545         * features/Makefile: Add new files.
13546         * features/aarch64-pauth.c: New file.
13547         * features/aarch64-pauth.xml: New file.
13548
13549 2019-03-20  Tom Tromey  <tromey@adacore.com>
13550
13551         * infrun.c (handle_inferior_event): Rename from
13552         handle_inferior_event_1.  Create a scoped_value_mark.
13553         (handle_inferior_event): Remove.
13554
13555 2019-03-19  Tom Tromey  <tromey@adacore.com>
13556
13557         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13558         * infrun.h (print_stop_event): Add "displays" parameter.
13559         * infrun.c (print_stop_event): Add "displays" parameter.
13560
13561 2019-03-19  Pedro Alves  <palves@redhat.com>
13562
13563         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13564         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13565         to -1.  Fix TABs vs spaces.
13566         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13567         * tui/tui-out.h (tui_ui_out) Add intro comments.
13568         <m_line, m_start_of_line>: In-class initialize, and add describing
13569         comment.
13570
13571 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13572
13573         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13574         variable names.
13575         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13576
13577 2019-03-18  Pedro Alves  <palves@redhat.com>
13578             Eli Zaretskii <eliz@gnu.org>
13579
13580         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13581         m_line and m_start_of_line.
13582
13583 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13584
13585         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13586         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13587         it returns a newline.  This fixes a regression in TU mode, whereby
13588         the next line is output on the same screen line as the user input.
13589
13590 2019-03-18  Tom Tromey  <tromey@adacore.com>
13591
13592         * minsyms.c (minimal_symbol_reader::install): Remove call to
13593         obstack_blank.
13594
13595 2019-03-18  Pedro Alves  <palves@redhat.com>
13596
13597         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13598         New globals.
13599         (apply_style): New, factored out from ...
13600         (apply_ansi_escape): ... this.  Handle reverse video mode.
13601         (tui_set_reverse_mode): New function.
13602         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13603         * tui/tui-winsource.c (tui_show_source_line): Use
13604         tui_set_reverse_mode instead of setting A_STANDOUT.
13605         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13606         New setter methods.
13607
13608 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13609
13610         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13611         Handle tabs.
13612
13613 2019-03-18  Tom Tromey  <tromey@adacore.com>
13614
13615         * ada-lang.c (empty_array): Add "high" parameter.
13616         (ada_evaluate_subexp): Update.
13617
13618 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13619
13620         * unittests/string_view-selftests.c: Define
13621         _initialize_string_view_selftests unconditionally.
13622
13623 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13624
13625         PR gdb/24350
13626         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13627
13628 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13629
13630         PR gdb/24351
13631         * windows-nat.c (display_selector): Fix format specifiers.
13632
13633 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13634
13635         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13636         tui_refill_source_window instead of tui_refresh_win, to update the
13637         current execution line.  This fixes redisplay of the current line
13638         when stepping through the code with "next" or "step".
13639
13640 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13641
13642         * source-cache.c (source_cache::get_source_lines): Call
13643         find_source_lines to initialize s->nlines.  This fixes vertical
13644         scrolling of TUI source window when the DOWN arrow is pressed.
13645
13646 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13647
13648         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13649         linux-thread-db.c (_initialize_thread_db): Likewise.
13650
13651 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13652
13653         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13654         wclrtoeol in tui_show_source_line".  This reverts changes made in
13655         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13656
13657 2019-03-15  Tom Tromey  <tom@tromey.com>
13658
13659         * symtab.h (struct minimal_symbol): Derive from
13660         general_symbol_info.
13661         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13662         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13663         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13664         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13665         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13666         (MSYMBOL_SEARCH_NAME): Update.
13667         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13668         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13669         * minsyms.c (minimal_symbol_reader::record_full): Update.
13670
13671 2019-03-15  Tom Tromey  <tom@tromey.com>
13672
13673         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13674
13675 2019-03-15  Tom Tromey  <tom@tromey.com>
13676
13677         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13678         unique_xmalloc_ptr.
13679         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13680         Update.
13681         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13682         (build_minimal_symbol_hash_tables)
13683         (minimal_symbol_reader::install): Update.
13684
13685 2019-03-15  Tom Tromey  <tom@tromey.com>
13686
13687         * symtab.c (create_demangled_names_hash): Update.
13688         (symbol_set_names): Update.
13689         * objfiles.h (struct objfile_per_bfd_storage)
13690         <demangled_names_hash>: Now an htab_up.
13691         * objfiles.c (objfile_per_bfd_storage): Simplify.
13692
13693 2019-03-15  Tom Tromey  <tom@tromey.com>
13694
13695         * objfiles.h (struct objfile_per_bfd_storage): Declare
13696         destructor.
13697         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13698         New.
13699         (get_objfile_bfd_data): Use new.  Don't initialize
13700         language_of_main.
13701         (free_objfile_per_bfd_storage): Remove.
13702         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13703
13704 2019-03-15  Tom Tromey  <tom@tromey.com>
13705
13706         * symfile.c (reread_symbols): Update.
13707         * objfiles.c (objfile::objfile): Update.
13708         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13709         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13710         comment.
13711         (minimal_symbol_reader::install): Update.
13712         (terminate_minimal_symbol_table): Remove.
13713         * jit.c (jit_object_close_impl): Update.
13714
13715 2019-03-15  Tom Tromey  <tom@tromey.com>
13716
13717         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13718         initializations.
13719
13720 2019-03-15  Tom Tromey  <tom@tromey.com>
13721
13722         * objfiles.h (struct objfile_per_bfd_storage)
13723         <demangled_hash_languages>: Now a bitset.
13724         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13725         (lookup_minimal_symbol): Update.
13726
13727 2019-03-15  Tom Tromey  <tom@tromey.com>
13728
13729         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13730         Don't return the symbol.
13731         * coffread.c (record_minimal_symbol): Use record_full.
13732
13733 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13734
13735         The MS-Windows port of ncurses fails to switch to a color pair if
13736         one or both of the colors are the implicit default colors.  This
13737         change records the default colors when TUI is initialized, and
13738         then specifies them explicitly when a color pair uses the default
13739         colors.  This allows color styling in TUI mode on MS-Windows.
13740
13741         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13742         ncurses_norm_attr.
13743         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13744         colors in ncurses_norm_attr.
13745         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13746         "none", replace it with the default color recorded in
13747         ncurses_norm_attr.
13748
13749 2019-03-14  Tom Tromey  <tromey@adacore.com>
13750
13751         * source-cache.h (class source_cache) <get_source_lines>: Return
13752         std::string.
13753         * source-cache.c (source_cache::extract_lines): Handle case where
13754         first_pos==npos.  Return std::string.
13755         (source_cache::get_source_lines): Update.
13756
13757 2019-03-14  Tom Tromey  <tromey@adacore.com>
13758
13759         * NEWS: Add item for "style sources" commands.
13760         * source-cache.c (source_cache::get_source_lines): Check
13761         source_styling.
13762         * cli/cli-style.c (source_styling): New global.
13763         (_initialize_cli_style): Add "style sources" commands.
13764         (show_style_sources): New function.
13765         * cli/cli-style.h (source_styling): Declare.
13766
13767 2019-03-14  Pedro Alves  <palves@redhat.com>
13768             Tom Tromey  <tromey@adacore.com>
13769
13770         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13771         * tui/tui-winsource.c (tui_refill_source_window): New function,
13772         from...
13773         (tui_horizontal_source_scroll): ... here.  Move some logic.
13774         * cli/cli-style.c (set_style_enabled): Notify new observable.
13775         * tui/tui-hooks.c (tui_redisplay_source): New function.
13776         (tui_attach_detach_observers): Attach or detach
13777         tui_redisplay_source.
13778         * observable.h (source_styling_changed): New observable.
13779         * observable.c: Define source_styling_changed observable.
13780
13781 2019-03-13  Tom Tromey  <tromey@adacore.com>
13782
13783         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13784         (i386_gnu_nat_target::store_registers): Update.
13785         * target-debug.h (target_debug_print_std_string): New macro.
13786         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13787         * windows-tdep.c (display_one_tib): Update.
13788         * tui/tui-stack.c (tui_make_status_line): Update.
13789         * top.c (print_inferior_quit_action): Update.
13790         * thread.c (thr_try_catch_cmd): Update.
13791         (add_thread_with_info): Update.
13792         (thread_target_id_str): Update.
13793         (thr_try_catch_cmd): Update.
13794         (thread_command): Update.
13795         (thread_find_command): Update.
13796         * record-btrace.c (record_btrace_target::info_record)
13797         (record_btrace_resume_thread, record_btrace_target::resume)
13798         (record_btrace_cancel_resume, record_btrace_step_thread)
13799         (record_btrace_target::wait, record_btrace_target::wait)
13800         (record_btrace_target::wait, record_btrace_target::stop): Update.
13801         * progspace.c (print_program_space): Update.
13802         * process-stratum-target.c
13803         (process_stratum_target::thread_address_space): Update.
13804         * linux-fork.c (linux_fork_mourn_inferior)
13805         (detach_checkpoint_command, info_checkpoints_command)
13806         (linux_fork_context): Update.
13807         (linux_fork_detach): Update.
13808         (class scoped_switch_fork_info): Update.
13809         (delete_checkpoint_command): Update.
13810         * infrun.c (follow_fork_inferior): Update.
13811         (follow_fork_inferior): Update.
13812         (proceed_after_vfork_done): Update.
13813         (handle_vfork_child_exec_or_exit): Update.
13814         (follow_exec): Update.
13815         (displaced_step_prepare_throw): Update.
13816         (displaced_step_restore): Update.
13817         (start_step_over): Update.
13818         (resume_1): Update.
13819         (clear_proceed_status_thread): Update.
13820         (proceed): Update.
13821         (print_target_wait_results): Update.
13822         (do_target_wait): Update.
13823         (context_switch): Update.
13824         (stop_all_threads): Update.
13825         (restart_threads): Update.
13826         (finish_step_over): Update.
13827         (handle_signal_stop): Update.
13828         (switch_back_to_stepped_thread): Update.
13829         (keep_going_pass_signal): Update.
13830         (print_exited_reason): Update.
13831         (normal_stop): Update.
13832         * inferior.c (inferior_pid_to_str): Change return type.
13833         (print_selected_inferior): Update.
13834         (add_inferior): Update.
13835         (detach_inferior): Update.
13836         * dummy-frame.c (fprint_dummy_frames): Update.
13837         * dcache.c (dcache_info_1): Update.
13838         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13839         (btrace_fetch, btrace_clear): Update.
13840         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13841         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13842         type.
13843         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13844         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13845         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13846         * gdbarch.c, gdbarch.h: Rebuild.
13847         * gdbarch.sh (core_pid_to_str): Change return type.
13848         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13849         return type.
13850         (windows_nat_target::pid_to_str): Change return type.
13851         (windows_delete_thread): Update.
13852         (windows_nat_target::attach): Update.
13853         (windows_nat_target::files_info): Update.
13854         * target-delegates.c: Rebuild.
13855         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13856         return type.
13857         (sol_thread_target::pid_to_str): Change return type.
13858         * remote.c (class remote_target) <pid_to_str>: Change return
13859         type.
13860         (remote_target::pid_to_str): Change return type.
13861         (extended_remote_target::attach, remote_target::remote_stop_ns)
13862         (remote_target::remote_notif_remove_queued_reply)
13863         (remote_target::push_stop_reply, remote_target::disable_btrace):
13864         Update.
13865         (extended_remote_target::attach): Update.
13866         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13867         type.
13868         (gdbsim_target::pid_to_str): Change return type.
13869         * ravenscar-thread.c (struct ravenscar_thread_target)
13870         <pid_to_str>: Change return type.
13871         (ravenscar_thread_target::pid_to_str): Change return type.
13872         * procfs.c (class procfs_target) <pid_to_str>: Change return
13873         type.
13874         (procfs_target::pid_to_str): Change return type.
13875         (procfs_target::attach): Update.
13876         (procfs_target::detach): Update.
13877         (procfs_target::fetch_registers): Update.
13878         (procfs_target::store_registers): Update.
13879         (procfs_target::wait): Update.
13880         (procfs_target::files_info): Update.
13881         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13882         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13883         return type.
13884         (nto_procfs_target::pid_to_str): Change return type.
13885         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13886         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13887         return type.
13888         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13889         (exit_lwp): Update.
13890         (attach_proc_task_lwp_callback, get_detach_signal)
13891         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13892         (linux_nat_target::resume, wait_lwp, stop_callback)
13893         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13894         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13895         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13896         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13897         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13898         type.
13899         (inf_ptrace_target::attach): Update.
13900         (inf_ptrace_target::files_info): Update.
13901         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13902         type.
13903         (go32_nat_target::pid_to_str): Change return type.
13904         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13905         (gnu_nat_target::wait): Update.
13906         (gnu_nat_target::wait): Update.
13907         (gnu_nat_target::resume): Update.
13908         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13909         (fbsd_nat_target::wait): Update.
13910         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13911         type.
13912         (darwin_nat_target::attach): Update.
13913         * corelow.c (class core_target) <pid_to_str>: Change return type.
13914         (core_target::pid_to_str): Change return type.
13915         * target.c (normal_pid_to_str): Change return type.
13916         (default_pid_to_str): Likewise.
13917         (target_pid_to_str): Change return type.
13918         (target_translate_tls_address): Update.
13919         (target_announce_detach): Update.
13920         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13921         return type.
13922         (bsd_uthread_target::pid_to_str): Change return type.
13923         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13924         type.
13925         (bsd_kvm_target::pid_to_str): Change return type.
13926         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13927         return type.
13928         (aix_thread_target::pid_to_str): Change return type.
13929         * target.h (struct target_ops) <pid_to_str>: Change return type.
13930         (target_pid_to_str, normal_pid_to_str): Likewise.
13931         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13932         type.
13933         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13934         type.
13935         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13936         return type.
13937         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13938         type.
13939         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13940         type.
13941         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13942         return type.
13943
13944 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13945
13946         * NEWS: Mention that the new default MI version is 3.  Mention
13947         changes to the output of commands and events that deal with
13948         multi-location breakpoints.
13949         * breakpoint.c: Include "mi/mi-out.h".
13950         (print_one_breakpoint): Change output syntax if using MI version
13951         >= 3.
13952         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13953         New.
13954         (mi_multi_location_breakpoint_output_fixed): New.
13955         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13956         (mi_cmd_fix_multi_location_breakpoint_output): New.
13957         (mi_multi_location_breakpoint_output_fixed): New.
13958         * mi/mi-cmds.c (mi_cmds): Register command
13959         -fix-multi-location-breakpoint-output.
13960         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13961         interpreter "mi".
13962
13963 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13964
13965         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13966         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13967         instantiate mi_ui_out based on interpreter name.
13968         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13969         * mi/mi-main.c (mi_load_progress): Likewise.
13970
13971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13972
13973         * NEWS: Combine separate "New targets" sections for 8.3.
13974
13975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13976
13977         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13978         (ppcfbsd_init_abi): Install gdbarch
13979         "fetch_tls_load_module_address" and "get_thread_local_address"
13980         methods.
13981
13982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13983
13984         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13985         (riscv_fbsd_init_abi): Install gdbarch
13986         "fetch_tls_load_module_address" and "get_thread_local_address"
13987         methods.
13988
13989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13990
13991         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13992         (i386fbsd_init_abi): Install gdbarch
13993         "fetch_tls_load_module_address" and "get_thread_local_address"
13994         methods.
13995
13996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13997
13998         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13999         (amd64fbsd_init_abi): Install gdbarch
14000         "fetch_tls_load_module_address" and "get_thread_local_address"
14001         methods.
14002
14003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14004
14005         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14006         (struct fbsd_pspace_data): New type.
14007         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14008         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14009         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14010         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14011         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14012
14013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14014
14015         * gdbtypes.c (lookup_struct_elt): New function.
14016         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14017         * gdbtypes.h (struct struct_elt): New type.
14018         (lookup_struct_elt): New prototype.
14019
14020 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14021
14022         * gdbtypes.c (lookup_struct_elt_type): Update comment and
14023         remove disabled code block.
14024
14025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14026
14027         * gdbarch.sh (get_thread_local_address): New method.
14028         * gdbarch.h, gdbarch.c: Regenerate.
14029         * target.c (target_translate_tls_address): Use
14030         gdbarch_get_thread_local_address if present instead of
14031         target::get_thread_local_address.
14032
14033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14034
14035         * target.h (target::get_thread_local_address): Update comment.
14036
14037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14038
14039         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14040         objfile->separate_debug_objfile_backlink if not NULL.
14041
14042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14043
14044         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14045         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14046         (amd64bsd_store_inferior_registers): Likewise.
14047         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14048         Enable segment base registers.
14049         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14050         PT_GETFSBASE and PT_GETGSBASE.
14051         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14052         PT_SETGSBASE.
14053         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14054         segment base registers.
14055         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14056
14057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14058
14059         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14060         Update calls to i386_target_description to add 'segments'
14061         parameter.
14062         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14063         add segment base registers.
14064         * arch/i386.c (i386_create_target_description): Add 'segments'
14065         parameter to enable segment base registers.
14066         * arch/i386.h (i386_create_target_description): Likewise.
14067         * features/i386/32bit-segments.xml: New file.
14068         * features/i386/32bit-segments.c: Generate.
14069         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14070         call to i386_target_description to add 'segments' parameter.
14071         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14072         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14073         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14074         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14075         if feature is present.
14076         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14077         Add 'segments' parameter to call to i386_target_description.
14078         (i386_target_description): Add 'segments' parameter to enable
14079         segment base registers.
14080         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14081         to call to i386_target_description.
14082         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14083         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14084         Define I386_NUM_REGS.
14085         (i386_target_description): Add 'segments' parameter to enable
14086         segment base registers.
14087
14088 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14089
14090         PR/24325
14091         * source-cache.c: #undef open and close, to avoid unresolved
14092         externals during linking.
14093
14094 2019-03-12  Tom Tromey  <tromey@adacore.com>
14095
14096         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14097         const.  Add initializers.
14098         (_initialize_remote): Don't initialize ptid globals.
14099
14100 2019-03-12  Pedro Alves  <palves@redhat.com>
14101
14102         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14103
14104 2019-03-12  Pedro Alves  <palves@redhat.com>
14105
14106         * cp-name-parser.y (main): Remove unused 'len' variable.
14107
14108 2019-03-12  Tom Tromey  <tromey@adacore.com>
14109
14110         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14111         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14112
14113 2019-03-12  Tom Tromey  <tromey@adacore.com>
14114
14115         * linux-nat.c (iterate_over_lwps): Update.
14116         (stop_callback): Remove parameter.
14117         (stop_wait_callback, detach_callback, resume_set_callback)
14118         (select_singlestep_lwp_callback, set_ignore_sigint)
14119         (status_callback, resumed_callback, resume_clear_callback)
14120         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14121         data parameter.
14122         (linux_nat_target::detach, linux_nat_target::resume)
14123         (linux_stop_and_wait_all_lwps, select_event_lwp)
14124         (linux_nat_filter_event, linux_nat_wait_1)
14125         (linux_nat_target::kill, linux_nat_target::stop)
14126         (linux_nat_target::stop): Update.
14127         (linux_nat_resume_callback): Change type.
14128         (resume_stopped_resumed_lwps, count_events_callback)
14129         (select_event_lwp_callback): Likewise.
14130         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14131         * arm-linux-nat.c (struct update_registers_data): Remove.
14132         (update_registers_callback): Change type.
14133         (arm_linux_insert_hw_breakpoint1): Update.
14134         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14135         parameter.
14136         (x86_linux_dr_set_addr): Update.
14137         (x86_linux_dr_set_control): Update.
14138         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14139         (iterate_over_lwps): Use gdb::function_view.
14140         * nat/aarch64-linux-hw-point.c (struct
14141         aarch64_dr_update_callback_param): Remove.
14142         (debug_reg_change_callback): Change type.
14143         (aarch64_notify_debug_reg_change): Update.
14144         * s390-linux-nat.c (s390_refresh_per_info): Update.
14145
14146 2019-03-11  Tom Tromey  <tromey@adacore.com>
14147
14148         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14149         redundant assignment to "this_cu".
14150
14151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14152
14153         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14154
14155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14156
14157         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14158         from...
14159         (rank_one_type): ... this.
14160
14161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14162
14163         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14164         from...
14165         (rank_one_type): ... this.
14166
14167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14168
14169         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14170         from...
14171         (rank_one_type): ... this.
14172
14173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14174
14175         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14176         from...
14177         (rank_one_type): ... this.
14178
14179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14180
14181         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14182         from...
14183         (rank_one_type): ... this.
14184
14185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14186
14187         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14188         from...
14189         (rank_one_type): ... this.
14190
14191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14192
14193         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14194         from...
14195         (rank_one_type): ... this.
14196
14197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14198
14199         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14200         from...
14201         (rank_one_type): ... this.
14202
14203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14204
14205         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14206         from...
14207         (rank_one_type): ... this.
14208
14209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14210
14211         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14212         from...
14213         (rank_one_type): ... this.
14214
14215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14216
14217         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14218         from...
14219         (rank_one_type): ... this.
14220
14221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14222
14223         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14224         from...
14225         (rank_one_type): ... this.
14226
14227 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14228
14229         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14230         inferior-events' shows the example events.
14231
14232 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14233
14234         Support styling on native MS-Windows console
14235
14236         PR/24315
14237         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14238         on MS-Windows if $TERM is not defined.
14239
14240         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14241
14242         * posix-hdep.c (gdb_console_fputs):
14243         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14244         functions.
14245         * ui-file.h (gdb_console_fputs): Add prototype.
14246
14247         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14248         back to fputs only if the former returns zero.
14249
14250 2019-03-07  Tom Tromey  <tom@tromey.com>
14251
14252         * symmisc.c (print_symbol_bcache_statistics): Update.
14253         (print_objfile_statistics): Update.
14254         * symfile.c (allocate_symtab): Update.
14255         * stabsread.c: Don't include bcache.h.
14256         * psymtab.h (struct psymbol_bcache): Don't declare.
14257         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14258         (psymbol_bcache_init, psymbol_bcache_free)
14259         (psymbol_bcache_get_bcache): Don't declare.
14260         * psymtab.c (struct psymbol_bcache): Remove.
14261         (psymtab_storage::psymtab_storage): Update.
14262         (psymtab_storage::~psymtab_storage): Update.
14263         (psymbol_bcache_init, psymbol_bcache_free)
14264         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14265         (add_psymbol_to_bcache): Update.
14266         (allocate_psymtab): Update.
14267         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14268         macro_cache>: No longer pointers.
14269         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14270         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14271         * macrotab.c (macro_bcache): Update.
14272         * macroexp.c: Don't include bcache.h.
14273         * gdbtypes.c (check_types_worklist): Update.
14274         (types_deeply_equal): Remove TRY/CATCH.  Update.
14275         * elfread.c (elf_symtab_read): Update.
14276         * dwarf2read.c: Don't include bcache.h.
14277         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14278         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14279         (print_bcache_statistics, bcache_memory_used): Don't declare.
14280         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14281         methods.  Rename all data members.
14282         * bcache.c (struct bcache): Move to bcache.h.
14283         (bcache::expand_hash_table): Rename from expand_hash_table.
14284         (bcache): Remove.
14285         (bcache::insert): Rename from bcache_full.
14286         (bcache::compare): Rename from bcache_compare.
14287         (bcache_xmalloc): Remove.
14288         (bcache::~bcache): Rename from bcache_xfree.
14289         (bcache::print_statistics): Rename from print_bcache_statistics.
14290         (bcache::memory_used): Rename from bcache_memory_used.
14291
14292 2019-03-07  Pedro Alves  <palves@redhat.com>
14293
14294         * infrun.c (normal_stop): Also check for
14295         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14296
14297 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14298
14299         * f-lang.c (value_from_host_double): Moved to...
14300         * value.c (value_from_host_double): ...here.
14301         * value.h (value_from_host_double): Declare.
14302         * guile/scm-math.c (vlscm_convert_typed_number): Use
14303         value_from_host_double.
14304         (vlscm_convert_number): Likewise.
14305         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14306         * python/py-value.c (convert_value_from_python): Likewise.
14307
14308 2019-03-06  Tom Tromey  <tom@tromey.com>
14309
14310         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14311
14312 2019-03-06  Tom Tromey  <tom@tromey.com>
14313
14314         * utils.h (free_current_contents): Don't declare.
14315         * utils.c (free_current_contents): Remove.
14316
14317 2019-03-06  Tom Tromey  <tom@tromey.com>
14318
14319         * top.c (quit_force): Update.
14320         * main.c (captured_command_loop): Update.
14321         * common/new-op.c (operator new): Update.
14322         * common/common-exceptions.c (struct catcher)
14323         <save_cleanup_chain>: Remove member.
14324         (exceptions_state_mc_init): Update.
14325         (exception_try_scope_entry): Return nullptr.
14326         (exception_try_scope_exit, exception_rethrow)
14327         (throw_exception_sjlj, throw_exception_cxx): Update.
14328         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14329         (all_cleanups, do_cleanups, discard_cleanups)
14330         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14331         (restore_cleanups, restore_final_cleanups): Don't declare.
14332         (do_final_cleanups): Remove parameter.
14333         * common/cleanups.c (cleanup_chain, make_cleanup)
14334         (make_cleanup_dtor, all_cleanups, do_cleanups)
14335         (discard_my_cleanups, discard_cleanups)
14336         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14337         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14338         (null_cleanup): Remove.
14339         (do_final_cleanups): Remove parameter.
14340
14341 2019-03-06  Tom Tromey  <tom@tromey.com>
14342
14343         * remote.c (remote_target::remote_parse_stop_reply): Use
14344         unique_xmalloc_ptr.
14345
14346 2019-03-06  Tom Tromey  <tom@tromey.com>
14347
14348         * stabsread.c (struct stabs_field_info): Rename from field_info.
14349         <list, fnlist>: Add initializers.
14350         <obstack>: New member.
14351         (read_member_functions, read_struct_fields, read_baseclasses):
14352         Allocate on obstack.  Don't use cleanups.
14353         (read_one_struct_field, read_member_functions, read_struct_fields)
14354         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14355         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14356         (read_struct_type): Update.
14357
14358 2019-03-06  Tom Tromey  <tom@tromey.com>
14359
14360         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14361         * common/filestuff.h (make_cleanup_close): Don't declare.
14362         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14363         Remove.
14364
14365 2019-03-06  Tom Tromey  <tom@tromey.com>
14366
14367         * solib-aix.c: Use make_scope_exit.
14368
14369 2019-03-06  Tom Tromey  <tom@tromey.com>
14370
14371         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14372         Use make_scope_exit.
14373
14374 2019-03-06  Tom Tromey  <tom@tromey.com>
14375
14376         * solib-svr4.c (disable_probes_interface): Remove parameter.
14377         (svr4_handle_solib_event): Use make_scope_exit.
14378
14379 2019-03-06  Tom Tromey  <tom@tromey.com>
14380
14381         * remote.c (struct stop_reply_deleter): Remove.
14382         (stop_reply_up): Update.
14383         (struct stop_reply): Derive from notif_event.  Don't typedef.
14384         <regcache>: Now a std::vector.
14385         (stop_reply_xfree): Remove.
14386         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14387         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14388         (remote_target::discard_pending_stop_replies): Use delete.
14389         (remote_target::remote_parse_stop_reply): Update.
14390         (remote_target::process_stop_reply): Update.
14391         * remote-notif.h (struct notif_event): Add virtual destructor.
14392         Remove "dtr" member.
14393         (struct notif_client) <alloc_event>: Return a unique_ptr.
14394         (notif_event_xfree): Don't declare.
14395         (notif_event_up): New typedef.
14396         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14397         (notif_event_xfree, do_notif_event_xfree): Remove.
14398         (remote_notif_state_xfree): Update.
14399
14400 2019-03-06  Tom Tromey  <tom@tromey.com>
14401
14402         * infrun.c (displaced_step_clear_cleanup): Now a
14403         forward_scope_exit type.
14404         (displaced_step_prepare_throw): Update.
14405         (displaced_step_fixup): Update.
14406
14407 2019-03-06  Tom Tromey  <tom@tromey.com>
14408
14409         * inferior.h (class inferior): Update comment.
14410         * gdbthread.h (class thread_info): Update comment.
14411
14412 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14413             Tom Tromey  <tom@tromey.com>
14414
14415         * stabsread.h (struct stab_section_list): Remove.
14416         (coffstab_build_psymtabs): Update.
14417         * dbxread.c (symbuf_sections): Now a std::vector.
14418         (sect_idx): New global.
14419         (fill_symbuf): Update.
14420         (coffstab_build_psymtabs): Change type of stabsects parameter.
14421         Update.
14422         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14423         std::vector.
14424         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14425         (coff_locate_sections): Update.
14426         (coff_symfile_read): Remove cleanups.  Update.
14427         (init_stringtab): Add storage parameter.
14428         (free_stringtab, free_stringtab_cleanup): Remove.
14429         (init_lineno): Add storage parameter.
14430         (free_linetab, free_linetab_cleanup): Remove.
14431
14432 2019-03-06  Pedro Alves  <palves@redhat.com>
14433
14434         * linux-fork.c (fork_info::clobber_regs): Delete.
14435         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14436         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14437         comment.  Adjust.
14438         (scoped_switch_fork_info::scoped_switch_fork_info)
14439         (checkpoint_command, linux_fork_context): Adjust
14440         fork_save_infrun_state calls.
14441
14442 2019-03-06  Pedro Alves  <palves@redhat.com>
14443
14444         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14445         (inf_has_multiple_threads): Return 'bool' and rewrite using
14446         inferior_info::threads().
14447
14448 2019-03-06  Pedro Alves  <palves@redhat.com>
14449
14450         * linux-fork.c: Include <list>.
14451         (fork_list): Now a std::list instance.
14452         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14453         (forks_exist_p, find_last_fork): Adjust.
14454         (new_fork): Delete.
14455         (one_fork_p): New.
14456         (add_fork): Adjust.
14457         (free_fork): Delete, folded into fork_info::~fork_info().
14458         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14459         Adjust.
14460         (init_fork_list): Delete.
14461         (linux_fork_killall, linux_fork_mourn_inferior)
14462         (linux_fork_detach, info_checkpoints_command): Adjust.
14463         (_initialize_linux_fork): No longer call init_fork_list.
14464
14465 2019-03-06  Pedro Alves  <palves@redhat.com>
14466
14467         * linux-fork.c (new_fork): New, split out of ...
14468         (add_fork): ... this.  Return void.  Move "first fork" special
14469         case from here, to ...
14470         (checkpoint_command): ... here.
14471         * linux-linux.h (add_fork): Return void.
14472
14473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14474
14475         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14476
14477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14478             Chris January  <chris.january@arm.com>
14479             David Lecomber  <david.lecomber@arm.com>
14480
14481         * f-exp.y: New token, UNOP_INTRINSIC.
14482         (exp): New pattern using UNOP_INTRINSIC token.
14483         (f77_keywords): Add 'abs' keyword.
14484         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14485         (value_from_host_double): New function.
14486         (evaluate_subexp_f): Support UNOP_ABS.
14487
14488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14489
14490         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14491         types.
14492
14493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14494
14495         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14496         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14497         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14498
14499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14500
14501         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14502
14503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14504             Chris January  <chris.january@arm.com>
14505
14506         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14507         * f-exp.y: Define 'KIND' token.
14508         (exp): New pattern for KIND expressions.
14509         (ptype): Handle types with a kind extension.
14510         (direct_abs_decl): Extend to spot kind extensions.
14511         (f77_keywords): Add 'kind' to the list.
14512         (push_kind_type): New function.
14513         (convert_to_kind_type): New function.
14514         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14515         * parse.c (operator_length_standard): Likewise.
14516         * parser-defs.h (enum type_pieces): Add tp_kind.
14517         * std-operator.def: Add UNOP_KIND.
14518
14519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14520
14521         * f-exp.y (f_parse): Set yydebug.
14522
14523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14524
14525         * f-lang.c (evaluate_subexp_f): New function.
14526         (exp_descriptor_f): New global.
14527         (f_language_defn): Use exp_descriptor_f instead of
14528         exp_descriptor_standard.
14529
14530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14531
14532         * f-exp.y (struct token): Add comments.
14533         (dot_ops): Remove uppercase versions and the end marker.
14534         (f77_keywords): Likewise.
14535         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14536         entries in the dot_ops array are case insensitive, and use
14537         strncasecmp to compare strings.  Also some whitespace cleanup in
14538         this area.  Similar for the f77_keywords array, except entries in
14539         this list might be case sensitive.
14540
14541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14542
14543         * f-exp.y (struct f77_boolean_val): Add comments.
14544         (boolean_values): Remove uppercase versions, and end marker.
14545         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14546         and use strncasecmp to achieve case insensitivity.  Additionally,
14547         perform whitespace cleanup around this code.
14548
14549 2019-03-06  Tom Tromey  <tromey@adacore.com>
14550
14551         * remote-sim.c (gdbsim_target_open): Use result of
14552         gdb_argv::release.
14553
14554 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14555         Dirk Schubert  <dirk.schubert@arm.com>
14556         Chris January  <chris.january@arm.com>
14557
14558         * eval.c (evaluate_subexp_standard): Call Fortran argument
14559         wrapping logic.
14560         * f-lang.c (struct value): A value which can be passed into a
14561         Fortran function call.
14562         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14563         where appropriate.
14564         (struct type): Value ready for a Fortran function call.
14565         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14566         is needed.
14567         * f-lang.h (fortran_argument_convert): Declaration.
14568         (fortran_preserve_arg_pointer): Declaration.
14569         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14570
14571 2019-03-05  Tom Tromey  <tromey@adacore.com>
14572
14573         * python/py-prettyprint.c (print_string_repr): Remove #if.
14574         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14575
14576 2019-03-05  Tom Tromey  <tromey@adacore.com>
14577
14578         * target.c (the_dummy_target): Move later.  Change type to
14579         "dummy_target".
14580         (initialize_targets): Don't initialize the_dummy_target.
14581
14582 2019-03-05  Tom Tromey  <tromey@adacore.com>
14583
14584         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14585         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14586
14587 2019-03-05  Tom Tromey  <tromey@adacore.com>
14588
14589         * windows-nat.c (windows_nat_target::attach)
14590         (windows_nat_target::detach): Don't call gdb_flush.
14591         * valprint.c (generic_val_print, val_print, val_print_string):
14592         Don't call gdb_flush.
14593         * utils.c (defaulted_query): Don't call gdb_flush.
14594         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14595         * target.c (target_announce_detach): Don't call gdb_flush.
14596         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14597         * remote.c (extended_remote_target::attach): Don't call
14598         gdb_flush.
14599         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14600         * printcmd.c (do_examine): Don't call gdb_flush.
14601         (info_display_command): Don't call gdb_flush.
14602         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14603         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14604         * memattr.c (info_mem_command): Don't call gdb_flush.
14605         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14606         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14607         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14608         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14609         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14610         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14611         (gnu_nat_target::detach): Don't call gdb_flush.
14612         * f-valprint.c (f_val_print): Don't call gdb_flush.
14613         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14614         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14615         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14616         gdb_flush.
14617         * c-valprint.c (c_val_print): Don't call gdb_flush.
14618         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14619
14620 2019-03-05  Tom Tromey  <tromey@adacore.com>
14621
14622         * varobj.c (update_dynamic_varobj_children): Update.
14623         (install_default_visualizer): Use reset, not release.
14624         * value.c (set_internalvar): Update.
14625         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14626         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14627         ATTRIBUTE_UNUSED_RESULT.
14628
14629 2019-03-05  Tom Tromey  <tromey@adacore.com>
14630
14631         * remote.c (class scoped_remote_fd) <release>: Add
14632         ATTRIBUTE_UNUSED_RESULT.
14633
14634 2019-03-05  Tom Tromey  <tromey@adacore.com>
14635
14636         * macroexp.c (struct macro_buffer) <release>: Add
14637         ATTRIBUTE_UNUSED_RESULT.
14638
14639 2019-03-05  Tom Tromey  <tromey@adacore.com>
14640
14641         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14642         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14643         ATTRIBUTE_UNUSED_RESULT.
14644
14645 2019-03-05  Tom Tromey  <tromey@adacore.com>
14646
14647         * common/scoped_fd.h (class scoped_fd) <release>: Add
14648         ATTRIBUTE_UNUSED_RESULT.
14649
14650 2019-03-05  Tom Tromey  <tromey@adacore.com>
14651
14652         * parser-defs.h (struct parser_state) <release>: Add
14653         ATTRIBUTE_UNUSED_RESULT.
14654
14655 2019-03-05  Tom Tromey  <tromey@adacore.com>
14656
14657         * utils.h (class gdb_argv) <release>: Add
14658         ATTRIBUTE_UNUSED_RESULT.
14659         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14660
14661 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14662
14663         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14664         for-loop range, to avoid compiler warnings.
14665
14666         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14667         avoid compiler warnings about unused variables.
14668
14669         * NEWS: Mention end of support for native debugging on MS-Windows
14670         before XP.
14671
14672         PR gdb/24292
14673         * common/netstuff.c:
14674         * gdbserver/gdbreplay.c
14675         * gdbserver/remote-utils.c:
14676         * ser-tcp.c:
14677         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14678         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14679         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14680         'getaddrinfo' and 'freeaddrinfo' were not available before
14681         Windows XP, and mingw.org's MinGW headers by default define
14682         _WIN32_WINNT to 0x500.
14683
14684 2019-03-01  Gary Benson <gbenson@redhat.com>
14685
14686         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14687
14688 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14689             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14690
14691         PR gdb/8527
14692         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14693         set_sigint_trap, clear_sigint_trap.
14694
14695 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14696
14697         * target.c (target_detach): Clear the regcache and the
14698         frame cache.
14699
14700 2019-02-27  Pedro Alves  <palves@redhat.com>
14701
14702         * utils.c (set_screen_size): When we cap the height/width sizes,
14703         tweak the corresponding command variable to show "unlimited":
14704
14705 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14706             Pedro Alves  <palves@redhat.com>
14707
14708         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14709         before calling rl_set_screen_size.
14710
14711 2019-02-27  Tom Tromey  <tromey@adacore.com>
14712
14713         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14714         define.
14715         * python/py-value.c: Remove Python 2.4 workaround.
14716         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14717         workaround.
14718         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14719         Python 2.4 workaround.
14720         * python/python-internal.h: Remove Python 2.4 comment.
14721         (Py_ssize_t): Don't define.
14722         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14723         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14724         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14725         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14726         * python/python.c (do_start_initialization): Remove Python 2.4
14727         workaround.
14728         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14729         (print_children): Remove Python 2.4 workaround.
14730         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14731         workaround.
14732         (CHARBUFFERPROC_NAME): Remove.
14733         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14734         Python 2.4 workaround.
14735
14736 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14737
14738         * NEWS: Note minimum Python version.
14739
14740 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14741
14742         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14743         code from these functions.  Remove corresponding ifdefs.  Use
14744         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14745         Remove gotos and target of gotos.
14746         (infpy_search_memory): Likewise.
14747
14748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14749
14750         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14751         (hppa_gdbarch_init): Don't register deleted functions with
14752         gdbarch.
14753
14754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14755
14756         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14757         (h8300_unwind_sp): Delete.
14758         (h8300_dummy_id): Delete.
14759         (h8300_gdbarch_init): Don't register deleted functions with
14760         gdbarch.
14761
14762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14763
14764         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14765         (ft32_unwind_pc): Delete.
14766         (ft32_unwind_sp): Delete.
14767         (ft32_gdbarch_init): Don't register deleted functions with
14768         gdbarch.
14769
14770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14771
14772         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14773         (frv_unwind_pc): Delete.
14774         (frv_unwind_sp): Delete.
14775         (frv_gdbarch_init): Don't register deleted functions with
14776         gdbarch.
14777
14778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14779
14780         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14781         (riscv_unwind_pc): Delete.
14782         (riscv_unwind_sp): Delete.
14783         (riscv_gdbarch_init): Don't register deleted functions with
14784         gdbarch.
14785
14786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14787
14788         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14789         (csky_unwind_pc): Delete.
14790         (csky_unwind_sp): Delete.
14791         (csky_gdbarch_init): Don't register deleted functions with
14792         gdbarch.
14793
14794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14795
14796         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14797         (cris_unwind_pc): Delete.
14798         (cris_unwind_sp): Delete.
14799         (cris_gdbarch_init): Don't register deleted functions with
14800         gdbarch.
14801
14802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14803
14804         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14805         (bfin_unwind_pc): Delete.
14806         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14807
14808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14809
14810         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14811         (arm_unwind_pc): Delete.
14812         (arm_unwind_sp): Delete.
14813         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14814
14815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14816
14817         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14818         (arc_unwind_pc): Delete.
14819         (arc_unwind_sp): Delete.
14820         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14821
14822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14823
14824         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14825         (alpha_unwind_pc): Delete.
14826         (alpha_gdbarch_init): Don't register deleted functions with
14827         gdbarch.
14828
14829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14830
14831         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14832         (aarch64_unwind_pc): Delete.
14833         (aarch64_unwind_sp): Delete.
14834         (aarch64_gdbarch_init): Don't register deleted functions with
14835         gdbarch.
14836
14837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14838
14839         * gdbtypes.c (type_align): Don't consider static members when
14840         computing structure alignment.
14841
14842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14843
14844         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14845         return 0 for other types.
14846         * arch-utils.c (default_type_align): Always return 0.
14847         * gdbarch.h: Regenerate.
14848         * gdbarch.sh (type_align): Extend comment.
14849         * gdbtypes.c (type_align): Add additional comments, always call
14850         gdbarch_type_align before applying the default rules.
14851         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14852         generic code will then apply a suitable default.
14853         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14854         types, return 0 for other types.
14855
14856 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14857
14858         * NEWS: Create a new section for the next release branch.
14859         Rename the section of the current branch, now that it has
14860         been cut.
14861
14862 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14863
14864         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14865         * version.in: Bump version to 8.3.50.DATE-git.
14866
14867 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14868
14869         * aix-thread.c (ptid_cmp): Remove unused variable.
14870         (get_signaled_thread): Likewise.
14871         (store_regs_user_thread): Likewise.
14872         (store_regs_kernel_thread): Likewise.
14873         (fetch_regs_kernel_thread): Remove shadowed variable.
14874
14875 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14876
14877         * features/riscv/32bit-cpu.xml: Add register numbers.
14878         * features/riscv/32bit-fpu.c: Regenerate.
14879         * features/riscv/32bit-fpu.xml: Add register numbers.
14880         * features/riscv/64bit-cpu.xml: Add register numbers.
14881         * features/riscv/64bit-fpu.c: Regenerate.
14882         * features/riscv/64bit-fpu.xml: Add register numbers.
14883
14884 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14885
14886         * NEWS: Mention two argument form of gdb.Value constructor.
14887         * python/py-value.c (convert_buffer_and_type_to_value): New
14888         function.
14889         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14890         Add support for handling an optional second argument.  Call
14891         convert_buffer_and_type_to_value as appropriate.
14892         * python/python-internal.h (Py_buffer_deleter): New struct.
14893         (Py_buffer_up): New typedef.
14894
14895 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14896
14897         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14898         instead of releasing ownership.
14899
14900 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14901
14902         * dwarf2read.c (open_and_init_dwp_file): Call
14903         elf_numsections instead of bfd_count_sections to initialize
14904         dwp_file->num_sections.
14905
14906 2019-02-25  Tom Tromey  <tromey@adacore.com>
14907
14908         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14909
14910 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14911
14912         * gcore.in: Add '--readnever' option when invoking GDB.
14913
14914 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14915
14916         * MAINTAINERS: Update my email address.
14917
14918 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14919
14920         * build-id.c (build_id_to_debug_bfd_1): New function.
14921         (build_id_to_debug_bfd): Look for separate debug file in
14922         sysroot.
14923
14924 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14925
14926         * gdbarch.sh: Update the copyright year range that is placed into
14927         generated files.
14928
14929 2019-02-22  Keith Seitz  <keiths@redhat.com>
14930
14931         PR symtab/23853
14932         * linespec.c (create_sals_line_offset): Search for the default
14933         symtab's filename instead of its fullname.
14934
14935 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14936
14937         * NEWS: Update style defaults.
14938
14939 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14940
14941         * main.c (captured_main_1): Disable styling in batch mode.
14942
14943 2019-02-20  Tom Tromey  <tom@tromey.com>
14944
14945         * symtab.c (symtab_symbol_info): Fix typos.
14946
14947 2019-02-20  Tom Tromey  <tromey@adacore.com>
14948
14949         * findcmd.c (_initialize_mem_search): Use upper case for
14950         metasyntactic variables.
14951
14952 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14953
14954         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14955         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14956
14957 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14958
14959         * top.h (source_file_name): Change to std::string.
14960         * top.c (source_file_name): Likewise.
14961         (command_line_input): Adjust.
14962         * cli/cli-script.c (script_from_file): Adjust.
14963
14964 2019-02-19  Tom Tromey  <tromey@adacore.com>
14965
14966         * ravenscar-thread.c
14967         (ravenscar_thread_target::update_thread_list): Don't call
14968         ada_build_task_list.
14969         * ada-lang.h (ada_build_task_list): Don't declare.
14970         * ada-tasks.c (struct ada_tasks_inferior_data)
14971         <task_list_valid_p>: Now bool.
14972         (read_known_tasks, ada_task_list_changed)
14973         (ada_tasks_invalidate_inferior_data): Update.
14974         (read_known_tasks_array): Return bool.
14975         (read_known_tasks_list): Likewise.
14976         (read_known_tasks): Return void.
14977         (ada_build_task_list): Now static.
14978
14979 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14980
14981         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14982         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14983
14984 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14985
14986         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14987         variant for ada_tasks_pspace_data_handle and
14988         ada_tasks_inferior_data_handle.
14989         (ada_tasks_pspace_data_cleanup): New function.
14990         (ada_tasks_inferior_data_cleanup): New function.
14991
14992 2019-02-17  Tom Tromey  <tom@tromey.com>
14993
14994         * macrotab.h (macro_source_fullname): Return a std::string.
14995         * macrotab.c (macro_include, check_for_redefinition)
14996         (macro_undef, macro_lookup_definition, foreach_macro)
14997         (foreach_macro_in_scope): Update.
14998         (macro_source_fullname): Return a std::string.
14999         * macrocmd.c (show_pp_source_pos): Update.
15000
15001 2019-02-17  Tom Tromey  <tom@tromey.com>
15002
15003         * macrocmd.c (show_pp_source_pos): Style the file names.
15004
15005 2019-02-17  Tom Tromey  <tom@tromey.com>
15006
15007         PR tui/24197:
15008         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15009
15010 2019-02-17  Tom Tromey  <tom@tromey.com>
15011
15012         * ada-lang.c (user_select_syms): Use filtered printing.
15013         * utils.c (wrap_style): New global.
15014         (desired_style): Remove.
15015         (emit_style_escape): Add stream parameter.
15016         (set_output_style, reset_terminal_style, prompt_for_continue):
15017         Update.
15018         (flush_wrap_buffer): Only flush gdb_stdout.
15019         (wrap_here): Set wrap_style.
15020         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
15021         treat escape sequences as a character.  Change when wrap buffer is
15022         flushed.
15023         (fputs_styled): Do not set the output style when the default is
15024         requested.
15025         * ui-style.h (struct ui_file_style) <is_default>: New method.
15026         * source.c (print_source_lines_base): Emit escape sequences in one
15027         piece.
15028
15029 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15030
15031         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15032         integers and enumeration types.
15033
15034 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15035
15036         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15037         instead of lookup_symbol_in_language
15038         (do_exact_match): New function.
15039         (ada_get_symbol_name_matcher): Return do_exact_match when
15040         doing a verbatim match.
15041
15042 2019-02-15  Tom Tromey  <tromey@adacore.com>
15043
15044         * ravenscar-thread.c (ravenscar_thread_target::resume)
15045         (ravenscar_thread_target::wait): Special case wildcard requests.
15046
15047 2019-02-15  Tom Tromey  <tromey@adacore.com>
15048
15049         * ravenscar-thread.c (base_ptid): Remove.
15050         (struct ravenscar_thread_target) <close>: New method.
15051         <m_base_ptid>: New member.
15052         <update_inferior_ptid, active_task, task_is_currently_active,
15053         runtime_initialized>: Declare methods.
15054         <ravenscar_thread_target>: Add constructor.
15055         (ravenscar_thread_target::task_is_currently_active)
15056         (ravenscar_thread_target::update_inferior_ptid)
15057         (ravenscar_runtime_initialized): Rename.  Now methods.
15058         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15059         (ravenscar_thread_target::update_thread_list): Update.
15060         (ravenscar_thread_target::active_task): Now method.
15061         (ravenscar_thread_target::store_registers)
15062         (ravenscar_thread_target::prepare_to_store)
15063         (ravenscar_thread_target::prepare_to_store)
15064         (ravenscar_thread_target::mourn_inferior): Update.
15065         (ravenscar_inferior_created): Use "new" to create target.
15066         (ravenscar_thread_target::get_ada_task_ptid): Update.
15067         (_initialize_ravenscar): Don't initialize base_ptid.
15068         (ravenscar_ops): Remove global.
15069
15070 2019-02-15  Tom Tromey  <tromey@adacore.com>
15071
15072         * target.h (push_target): Declare new overload.
15073         * target.c (push_target): New overload, taking an rvalue reference.
15074         * remote.c (remote_target::open_1): Use push_target overload.
15075         * corelow.c (core_target_open): Use push_target overload.
15076
15077 2019-02-15  Tom Tromey  <tromey@adacore.com>
15078
15079         * ravenscar-thread.c (is_ravenscar_task)
15080         (ravenscar_task_is_currently_active): Return bool.
15081         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15082         (_initialize_ravenscar): Remove "(void)".
15083         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15084         Return bool.
15085
15086 2019-02-15  Tom Tromey  <tromey@adacore.com>
15087
15088         * ravenscar-thread.c (ravenscar_runtime_initializer)
15089         (has_ravenscar_runtime, get_running_thread_id)
15090         (ravenscar_thread_target::resume): Fix indentation.
15091
15092 2019-02-15  Tom Tromey  <tromey@adacore.com>
15093
15094         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15095         from ravenscar_arch_ops.
15096         (sparc_ravenscar_ops::fetch_registers)
15097         (sparc_ravenscar_ops::store_registers): Now methods.
15098         (sparc_ravenscar_prepare_to_store): Remove.
15099         (sparc_ravenscar_ops): Redefine.
15100         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15101         methods and destructor.  Remove members.
15102         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15103         (ravenscar_thread_target::store_registers)
15104         (ravenscar_thread_target::prepare_to_store): Update.
15105         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15106         Remove.
15107         (struct ppc_ravenscar_powerpc_ops): Derive from
15108         ravenscar_arch_ops.
15109         (ppc_ravenscar_powerpc_ops::fetch_registers)
15110         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15111         (ppc_ravenscar_powerpc_ops): Redefine.
15112         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15113         (ppc_ravenscar_e500_ops::fetch_registers)
15114         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15115         (ppc_ravenscar_e500_ops): Redefine.
15116         * aarch64-ravenscar-thread.c
15117         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15118         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15119         (aarch64_ravenscar_fetch_registers)
15120         (aarch64_ravenscar_store_registers): Now methods.
15121         (aarch64_ravenscar_ops): Redefine.
15122
15123 2019-02-15  Tom Tromey  <tromey@adacore.com>
15124
15125         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15126         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15127         (ravenscar_thread_target::stopped_by_watchpoint)
15128         (ravenscar_thread_target::stopped_data_address)
15129         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15130
15131 2019-02-15  Tom Tromey  <tromey@adacore.com>
15132
15133         * ravenscar-thread.c: Fix some typos.
15134
15135 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15136             Tom Tromey  <tromey@adacore.com>
15137
15138         * ada-lang.c (ada_exception_sal): Change addr_string to a
15139         std::string.
15140         (create_ada_exception_catchpoint): Update.
15141
15142 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15143             Tom Tromey  <tromey@adacore.com>
15144
15145         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15146         (bp_location_ops): Remove.
15147         (base_breakpoint_allocate_location): Update.
15148         (free_bp_location): Update.
15149         * ada-lang.c (class ada_catchpoint_location)
15150         <ada_catchpoint_location>: Remove ops parameter.
15151         (ada_catchpoint_location_dtor): Remove.
15152         (ada_catchpoint_location_ops): Remove.
15153         (allocate_location_exception): Update.
15154         * breakpoint.h (struct bp_location_ops): Remove.
15155         (class bp_location) <bp_location>: Remove bp_location_ops
15156         parameter.
15157         <~bp_location>: Add destructor.
15158         <ops>: Remove.
15159
15160 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15161             Pedro Alves  <palves@redhat.com>
15162
15163         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15164         'PATH_MAX'.
15165
15166 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15167             Samuel Thibault  <samuel.thibault@gnu.org>
15168             Thomas Schwinge  <thomas@codesourcery.com>
15169
15170         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15171         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15172
15173 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15174
15175         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15176         (check_empty): Use "const char *".
15177
15178         * gnu-nat.c (gnu_nat_target::detach): Instead of
15179         'detach_inferior (pid)' call
15180         'detach_inferior (find_inferior_pid (pid))'.
15181
15182         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15183         'nat/fork-inferior.o'.
15184         * gnu-nat.c: #include "nat/fork-inferior.h".
15185
15186         * gnu-nat.c (gnu_nat_target::detach): Instead of
15187         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15188         * gnu-nat.h: #include "inf-child.h".
15189         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15190         'i386_gnu_nat_target::fetch_registers'.
15191         (gnu_store_registers): Rename/move to
15192         'i386_gnu_nat_target::store_registers'.
15193
15194         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15195         * gnu-nat.h (mach_thread_info): New function.
15196         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15197
15198         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15199
15200 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15201
15202         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15203
15204 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15205
15206         * windows-nat.c (windows_add_thread): Add new parameter
15207         "main_thread_p" with default value set to false.  Update
15208         function documentation as well as all callers.
15209         (windows_delete_thread): Likewise.
15210         (fake_create_process): Update call to windows_add_thread.
15211         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15212         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15213         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15214         call to windows_delete_thread.
15215
15216 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15217
15218         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15219
15220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15221
15222         * symfile.c (find_separate_debug_file): Use canonical path of
15223         sysroot with child_path instead of gdb_sysroot if it is valid.
15224
15225 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15226
15227         * symfile.c (find_separate_debug_file): Use child_path to
15228         determine if an object file is under a sysroot.
15229
15230 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15231
15232         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15233         unittests/child-path-selftests.c.
15234         * common/pathstuff.c (child_path): New function.
15235         * common/pathstuff.h (child_path): New prototype.
15236         * unittests/child-path-selftests.c: New file.
15237
15238 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15239
15240         * symfile.c (find_separate_debug_file): Look for separate debug
15241         files in debug directories under the sysroot.
15242
15243 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15244
15245         * symtab.h (struct minimal_symbol data_p): New const method.
15246         (struct minimal_symbol text_p): Likewise.
15247         * symtab.c (output_source_filename): Use file name style
15248         to print file name.
15249         (print_symbol_info): Likewise.
15250         (print_msymbol_info): Use address style to print addresses.
15251         Use function name style to print executable text symbols.
15252         (expand_symtab_containing_pc): Use data_p.
15253         (find_pc_sect_compunit_symtab): Likewise.
15254
15255 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15256
15257         * breakpoint.c (describe_other_breakpoints): Use address style
15258         to print addresses.
15259         (say_where): Likewise.
15260
15261 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15262
15263         * ada-typeprint.c (print_func_type): Print function name
15264         style to print function name.
15265         * c-typeprint.c (c_print_type_1): Likewise.
15266
15267 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15268
15269         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15270         for execve.
15271
15272 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15273
15274         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15275         type_stack.
15276
15277 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15278
15279         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15280         TYPE_CODE_REF types.
15281
15282 2019-02-08  Jim Wilson  <jimw@sifive.com>
15283
15284         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15285         (riscv_linux_fregset): New.
15286         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15287
15288 2019-02-07  Tom Tromey  <tom@tromey.com>
15289
15290         * thread.c (thread_cancel_execution_command): Update.
15291         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15292         methods.
15293         (struct thread_fsm_ops): Remove.
15294         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15295         (thread_fsm_should_stop, thread_fsm_return_value)
15296         (thread_fsm_set_finished, thread_fsm_finished_p)
15297         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15298         Don't declare.
15299         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15300         * infrun.c (clear_proceed_status_thread)
15301         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15302         (print_stop_event): Update.
15303         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15304         Add constructor.
15305         (step_command_fsm_ops): Remove.
15306         (new_step_command_fsm): Remove.
15307         (step_1): Update.
15308         (step_command_fsm::should_stop): Rename from
15309         step_command_fsm_should_stop.
15310         (step_command_fsm::clean_up): Rename from
15311         step_command_fsm_clean_up.
15312         (step_command_fsm::do_async_reply_reason): Rename from
15313         step_command_fsm_async_reply_reason.
15314         (struct until_next_fsm): Inherit from thread_fsm.  Add
15315         constructor.
15316         (until_next_fsm_ops): Remove.
15317         (new_until_next_fsm): Remove.
15318         (until_next_fsm::should_stop): Rename from
15319         until_next_fsm_should_stop.
15320         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15321         (until_next_fsm::do_async_reply_reason): Rename from
15322         until_next_fsm_async_reply_reason.
15323         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15324         constructor.  Change type of breakpoint.
15325         (finish_command_fsm_ops): Remove.
15326         (new_finish_command_fsm): Remove.
15327         (finish_command_fsm::should_stop): Rename from
15328         finish_command_fsm_should_stop.
15329         (finish_command_fsm::clean_up): Rename from
15330         finish_command_fsm_clean_up.
15331         (finish_command_fsm::return_value): Rename from
15332         finish_command_fsm_return_value.
15333         (finish_command_fsm::do_async_reply_reason): Rename from
15334         finish_command_fsm_async_reply_reason.
15335         (finish_command): Update.
15336         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15337         Add constructor.
15338         (call_thread_fsm_ops): Remove.
15339         (call_thread_fsm::call_thread_fsm): Rename from
15340         new_call_thread_fsm.
15341         (call_thread_fsm::should_stop): Rename from
15342         call_thread_fsm_should_stop.
15343         (call_thread_fsm::should_notify_stop): Rename from
15344         call_thread_fsm_should_notify_stop.
15345         (run_inferior_call, call_function_by_hand_dummy): Update.
15346         * cli/cli-interp.c (should_print_stop_to_console): Update.
15347         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15348         Add constructor.  Change type of location_breakpoint,
15349         caller_breakpoint.
15350         (until_break_fsm_ops): Remove.
15351         (new_until_break_fsm): Remove.
15352         (until_break_fsm::should_stop): Rename from
15353         until_break_fsm_should_stop.
15354         (until_break_fsm::clean_up): Rename from
15355         until_break_fsm_clean_up.
15356         (until_break_fsm::do_async_reply_reason): Rename from
15357         until_break_fsm_async_reply_reason.
15358         (until_break_command): Update.
15359         * thread-fsm.c: Remove.
15360         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15361
15362 2019-02-07  Tom Tromey  <tom@tromey.com>
15363
15364         * yy-remap.h: Add include guard.
15365         * xtensa-tdep.h: Add include guard.
15366         * xcoffread.h: Rename include guard.
15367         * varobj-iter.h: Add include guard.
15368         * tui/tui.h: Rename include guard.
15369         * tui/tui-winsource.h: Rename include guard.
15370         * tui/tui-wingeneral.h: Rename include guard.
15371         * tui/tui-windata.h: Rename include guard.
15372         * tui/tui-win.h: Rename include guard.
15373         * tui/tui-stack.h: Rename include guard.
15374         * tui/tui-source.h: Rename include guard.
15375         * tui/tui-regs.h: Rename include guard.
15376         * tui/tui-out.h: Rename include guard.
15377         * tui/tui-layout.h: Rename include guard.
15378         * tui/tui-io.h: Rename include guard.
15379         * tui/tui-hooks.h: Rename include guard.
15380         * tui/tui-file.h: Rename include guard.
15381         * tui/tui-disasm.h: Rename include guard.
15382         * tui/tui-data.h: Rename include guard.
15383         * tui/tui-command.h: Rename include guard.
15384         * tic6x-tdep.h: Add include guard.
15385         * target/waitstatus.h: Rename include guard.
15386         * target/wait.h: Rename include guard.
15387         * target/target.h: Rename include guard.
15388         * target/resume.h: Rename include guard.
15389         * target-float.h: Rename include guard.
15390         * stabsread.h: Add include guard.
15391         * rs6000-tdep.h: Add include guard.
15392         * riscv-fbsd-tdep.h: Add include guard.
15393         * regformats/regdef.h: Rename include guard.
15394         * record.h: Rename include guard.
15395         * python/python.h: Rename include guard.
15396         * python/python-internal.h: Rename include guard.
15397         * python/py-stopevent.h: Rename include guard.
15398         * python/py-ref.h: Rename include guard.
15399         * python/py-record.h: Rename include guard.
15400         * python/py-record-full.h: Rename include guard.
15401         * python/py-record-btrace.h: Rename include guard.
15402         * python/py-instruction.h: Rename include guard.
15403         * python/py-events.h: Rename include guard.
15404         * python/py-event.h: Rename include guard.
15405         * procfs.h: Add include guard.
15406         * proc-utils.h: Add include guard.
15407         * p-lang.h: Add include guard.
15408         * or1k-tdep.h: Rename include guard.
15409         * observable.h: Rename include guard.
15410         * nto-tdep.h: Rename include guard.
15411         * nat/x86-linux.h: Rename include guard.
15412         * nat/x86-linux-dregs.h: Rename include guard.
15413         * nat/x86-gcc-cpuid.h: Add include guard.
15414         * nat/x86-dregs.h: Rename include guard.
15415         * nat/x86-cpuid.h: Rename include guard.
15416         * nat/ppc-linux.h: Rename include guard.
15417         * nat/mips-linux-watch.h: Rename include guard.
15418         * nat/linux-waitpid.h: Rename include guard.
15419         * nat/linux-ptrace.h: Rename include guard.
15420         * nat/linux-procfs.h: Rename include guard.
15421         * nat/linux-osdata.h: Rename include guard.
15422         * nat/linux-nat.h: Rename include guard.
15423         * nat/linux-namespaces.h: Rename include guard.
15424         * nat/linux-btrace.h: Rename include guard.
15425         * nat/glibc_thread_db.h: Rename include guard.
15426         * nat/gdb_thread_db.h: Rename include guard.
15427         * nat/gdb_ptrace.h: Rename include guard.
15428         * nat/fork-inferior.h: Rename include guard.
15429         * nat/amd64-linux-siginfo.h: Rename include guard.
15430         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15431         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15432         * nat/aarch64-linux.h: Rename include guard.
15433         * nat/aarch64-linux-hw-point.h: Rename include guard.
15434         * mn10300-tdep.h: Add include guard.
15435         * mips-linux-tdep.h: Add include guard.
15436         * mi/mi-parse.h: Rename include guard.
15437         * mi/mi-out.h: Rename include guard.
15438         * mi/mi-main.h: Rename include guard.
15439         * mi/mi-interp.h: Rename include guard.
15440         * mi/mi-getopt.h: Rename include guard.
15441         * mi/mi-console.h: Rename include guard.
15442         * mi/mi-common.h: Rename include guard.
15443         * mi/mi-cmds.h: Rename include guard.
15444         * mi/mi-cmd-break.h: Rename include guard.
15445         * m2-lang.h: Add include guard.
15446         * location.h: Rename include guard.
15447         * linux-record.h: Rename include guard.
15448         * linux-nat.h: Add include guard.
15449         * linux-fork.h: Add include guard.
15450         * i386-darwin-tdep.h: Rename include guard.
15451         * hppa-linux-offsets.h: Add include guard.
15452         * guile/guile.h: Rename include guard.
15453         * guile/guile-internal.h: Rename include guard.
15454         * gnu-nat.h: Rename include guard.
15455         * gdb-stabs.h: Rename include guard.
15456         * frv-tdep.h: Add include guard.
15457         * f-lang.h: Add include guard.
15458         * event-loop.h: Add include guard.
15459         * darwin-nat.h: Rename include guard.
15460         * cp-abi.h: Rename include guard.
15461         * config/sparc/nm-sol2.h: Rename include guard.
15462         * config/nm-nto.h: Rename include guard.
15463         * config/nm-linux.h: Add include guard.
15464         * config/i386/nm-i386gnu.h: Rename include guard.
15465         * config/djgpp/nl_types.h: Rename include guard.
15466         * config/djgpp/langinfo.h: Rename include guard.
15467         * compile/gcc-cp-plugin.h: Add include guard.
15468         * compile/gcc-c-plugin.h: Add include guard.
15469         * compile/compile.h: Rename include guard.
15470         * compile/compile-object-run.h: Rename include guard.
15471         * compile/compile-object-load.h: Rename include guard.
15472         * compile/compile-internal.h: Rename include guard.
15473         * compile/compile-cplus.h: Rename include guard.
15474         * compile/compile-c.h: Rename include guard.
15475         * common/xml-utils.h: Rename include guard.
15476         * common/x86-xstate.h: Rename include guard.
15477         * common/version.h: Rename include guard.
15478         * common/vec.h: Rename include guard.
15479         * common/tdesc.h: Rename include guard.
15480         * common/selftest.h: Rename include guard.
15481         * common/scoped_restore.h: Rename include guard.
15482         * common/scoped_mmap.h: Rename include guard.
15483         * common/scoped_fd.h: Rename include guard.
15484         * common/safe-iterator.h: Rename include guard.
15485         * common/run-time-clock.h: Rename include guard.
15486         * common/refcounted-object.h: Rename include guard.
15487         * common/queue.h: Rename include guard.
15488         * common/ptid.h: Rename include guard.
15489         * common/print-utils.h: Rename include guard.
15490         * common/preprocessor.h: Rename include guard.
15491         * common/pathstuff.h: Rename include guard.
15492         * common/observable.h: Rename include guard.
15493         * common/netstuff.h: Rename include guard.
15494         * common/job-control.h: Rename include guard.
15495         * common/host-defs.h: Rename include guard.
15496         * common/gdb_wait.h: Rename include guard.
15497         * common/gdb_vecs.h: Rename include guard.
15498         * common/gdb_unlinker.h: Rename include guard.
15499         * common/gdb_unique_ptr.h: Rename include guard.
15500         * common/gdb_tilde_expand.h: Rename include guard.
15501         * common/gdb_sys_time.h: Rename include guard.
15502         * common/gdb_string_view.h: Rename include guard.
15503         * common/gdb_splay_tree.h: Rename include guard.
15504         * common/gdb_setjmp.h: Rename include guard.
15505         * common/gdb_ref_ptr.h: Rename include guard.
15506         * common/gdb_optional.h: Rename include guard.
15507         * common/gdb_locale.h: Rename include guard.
15508         * common/gdb_assert.h: Rename include guard.
15509         * common/filtered-iterator.h: Rename include guard.
15510         * common/filestuff.h: Rename include guard.
15511         * common/fileio.h: Rename include guard.
15512         * common/environ.h: Rename include guard.
15513         * common/common-utils.h: Rename include guard.
15514         * common/common-types.h: Rename include guard.
15515         * common/common-regcache.h: Rename include guard.
15516         * common/common-inferior.h: Rename include guard.
15517         * common/common-gdbthread.h: Rename include guard.
15518         * common/common-exceptions.h: Rename include guard.
15519         * common/common-defs.h: Rename include guard.
15520         * common/common-debug.h: Rename include guard.
15521         * common/cleanups.h: Rename include guard.
15522         * common/buffer.h: Rename include guard.
15523         * common/btrace-common.h: Rename include guard.
15524         * common/break-common.h: Rename include guard.
15525         * cli/cli-utils.h: Rename include guard.
15526         * cli/cli-style.h: Rename include guard.
15527         * cli/cli-setshow.h: Rename include guard.
15528         * cli/cli-script.h: Rename include guard.
15529         * cli/cli-interp.h: Rename include guard.
15530         * cli/cli-decode.h: Rename include guard.
15531         * cli/cli-cmds.h: Rename include guard.
15532         * charset-list.h: Add include guard.
15533         * buildsym-legacy.h: Rename include guard.
15534         * bfin-tdep.h: Add include guard.
15535         * ax.h: Rename include guard.
15536         * arm-linux-tdep.h: Add include guard.
15537         * arm-fbsd-tdep.h: Add include guard.
15538         * arch/xtensa.h: Rename include guard.
15539         * arch/tic6x.h: Add include guard.
15540         * arch/i386.h: Add include guard.
15541         * arch/arm.h: Rename include guard.
15542         * arch/arm-linux.h: Rename include guard.
15543         * arch/arm-get-next-pcs.h: Rename include guard.
15544         * arch/amd64.h: Add include guard.
15545         * arch/aarch64-insn.h: Rename include guard.
15546         * arch-utils.h: Rename include guard.
15547         * annotate.h: Add include guard.
15548         * amd64-darwin-tdep.h: Rename include guard.
15549         * aarch64-linux-tdep.h: Add include guard.
15550         * aarch64-fbsd-tdep.h: Add include guard.
15551         * aarch32-linux-nat.h: Add include guard.
15552
15553 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15554
15555         * macrotab.c (macro_define_internal): New function that
15556         factorizes macro_define_object_internal and macro_define_function
15557         code.
15558         (macro_define_object_internal): Use macro_define_internal.
15559         (macro_define_function): Likewise.
15560
15561 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15562
15563         * macrocmd.c (extract_identifier): Return
15564         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15565         callers.
15566
15567 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15568
15569         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15570
15571 2019-02-05  Tom Tromey  <tom@tromey.com>
15572
15573         * target.c (target_stack::unpush): Move assertion earlier.
15574
15575 2019-01-30  Tom Tromey  <tom@tromey.com>
15576
15577         PR python/23615:
15578         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15579         (gdbpy_parse_and_eval): Likewise.
15580         * python/python-internal.h (gdbpy_allow_threads): New class.
15581
15582 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15583
15584         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15585         (aarch64_fbsd_fpregmap): Move earlier.
15586         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15587         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15588         instead of individual calls to trad_frame_set_reg_addr.
15589         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15590         earlier.
15591         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15592         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15593         instead of individual calls to trad_frame_set_reg_addr.
15594
15595 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15596
15597         * CONTRIBUTE: Replace contribution list with wiki link.
15598
15599 2019-01-25  Tom Tromey  <tom@tromey.com>
15600
15601         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15602
15603 2019-01-25  Tom Tromey  <tom@tromey.com>
15604
15605         * xtensa-linux-nat.c: Fix common/ includes.
15606         * xml-support.h: Fix common/ includes.
15607         * xml-support.c: Fix common/ includes.
15608         * x86-linux-nat.c: Fix common/ includes.
15609         * windows-nat.c: Fix common/ includes.
15610         * varobj.h: Fix common/ includes.
15611         * varobj.c: Fix common/ includes.
15612         * value.c: Fix common/ includes.
15613         * valops.c: Fix common/ includes.
15614         * utils.c: Fix common/ includes.
15615         * unittests/xml-utils-selftests.c: Fix common/ includes.
15616         * unittests/utils-selftests.c: Fix common/ includes.
15617         * unittests/unpack-selftests.c: Fix common/ includes.
15618         * unittests/tracepoint-selftests.c: Fix common/ includes.
15619         * unittests/style-selftests.c: Fix common/ includes.
15620         * unittests/string_view-selftests.c: Fix common/ includes.
15621         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15622         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15623         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15624         * unittests/rsp-low-selftests.c: Fix common/ includes.
15625         * unittests/parse-connection-spec-selftests.c: Fix common/
15626         includes.
15627         * unittests/optional-selftests.c: Fix common/ includes.
15628         * unittests/offset-type-selftests.c: Fix common/ includes.
15629         * unittests/observable-selftests.c: Fix common/ includes.
15630         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15631         * unittests/memrange-selftests.c: Fix common/ includes.
15632         * unittests/memory-map-selftests.c: Fix common/ includes.
15633         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15634         * unittests/function-view-selftests.c: Fix common/ includes.
15635         * unittests/environ-selftests.c: Fix common/ includes.
15636         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15637         * unittests/common-utils-selftests.c: Fix common/ includes.
15638         * unittests/cli-utils-selftests.c: Fix common/ includes.
15639         * unittests/array-view-selftests.c: Fix common/ includes.
15640         * ui-file.c: Fix common/ includes.
15641         * tui/tui-io.c: Fix common/ includes.
15642         * tracepoint.h: Fix common/ includes.
15643         * tracepoint.c: Fix common/ includes.
15644         * tracefile-tfile.c: Fix common/ includes.
15645         * top.h: Fix common/ includes.
15646         * top.c: Fix common/ includes.
15647         * thread.c: Fix common/ includes.
15648         * target/waitstatus.h: Fix common/ includes.
15649         * target/waitstatus.c: Fix common/ includes.
15650         * target.h: Fix common/ includes.
15651         * target.c: Fix common/ includes.
15652         * target-memory.c: Fix common/ includes.
15653         * target-descriptions.c: Fix common/ includes.
15654         * symtab.h: Fix common/ includes.
15655         * symfile.c: Fix common/ includes.
15656         * stap-probe.c: Fix common/ includes.
15657         * spu-linux-nat.c: Fix common/ includes.
15658         * sparc-nat.c: Fix common/ includes.
15659         * source.c: Fix common/ includes.
15660         * solib.c: Fix common/ includes.
15661         * solib-target.c: Fix common/ includes.
15662         * ser-unix.c: Fix common/ includes.
15663         * ser-tcp.c: Fix common/ includes.
15664         * ser-pipe.c: Fix common/ includes.
15665         * ser-base.c: Fix common/ includes.
15666         * selftest-arch.c: Fix common/ includes.
15667         * s12z-tdep.c: Fix common/ includes.
15668         * rust-exp.y: Fix common/ includes.
15669         * rs6000-aix-tdep.c: Fix common/ includes.
15670         * riscv-tdep.c: Fix common/ includes.
15671         * remote.c: Fix common/ includes.
15672         * remote-notif.h: Fix common/ includes.
15673         * remote-fileio.h: Fix common/ includes.
15674         * remote-fileio.c: Fix common/ includes.
15675         * regcache.h: Fix common/ includes.
15676         * regcache.c: Fix common/ includes.
15677         * record-btrace.c: Fix common/ includes.
15678         * python/python.c: Fix common/ includes.
15679         * python/py-type.c: Fix common/ includes.
15680         * python/py-inferior.c: Fix common/ includes.
15681         * progspace.h: Fix common/ includes.
15682         * producer.c: Fix common/ includes.
15683         * procfs.c: Fix common/ includes.
15684         * proc-api.c: Fix common/ includes.
15685         * printcmd.c: Fix common/ includes.
15686         * ppc-linux-nat.c: Fix common/ includes.
15687         * parser-defs.h: Fix common/ includes.
15688         * osdata.c: Fix common/ includes.
15689         * obsd-nat.c: Fix common/ includes.
15690         * nat/x86-linux.c: Fix common/ includes.
15691         * nat/x86-linux-dregs.c: Fix common/ includes.
15692         * nat/x86-dregs.h: Fix common/ includes.
15693         * nat/x86-dregs.c: Fix common/ includes.
15694         * nat/ppc-linux.c: Fix common/ includes.
15695         * nat/mips-linux-watch.h: Fix common/ includes.
15696         * nat/mips-linux-watch.c: Fix common/ includes.
15697         * nat/linux-waitpid.c: Fix common/ includes.
15698         * nat/linux-ptrace.h: Fix common/ includes.
15699         * nat/linux-ptrace.c: Fix common/ includes.
15700         * nat/linux-procfs.c: Fix common/ includes.
15701         * nat/linux-personality.c: Fix common/ includes.
15702         * nat/linux-osdata.c: Fix common/ includes.
15703         * nat/linux-namespaces.c: Fix common/ includes.
15704         * nat/linux-btrace.h: Fix common/ includes.
15705         * nat/linux-btrace.c: Fix common/ includes.
15706         * nat/fork-inferior.c: Fix common/ includes.
15707         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15708         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15709         * nat/aarch64-linux.c: Fix common/ includes.
15710         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15711         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15712         * namespace.h: Fix common/ includes.
15713         * mips-linux-tdep.c: Fix common/ includes.
15714         * minsyms.c: Fix common/ includes.
15715         * mi/mi-parse.h: Fix common/ includes.
15716         * mi/mi-main.c: Fix common/ includes.
15717         * mi/mi-cmd-env.c: Fix common/ includes.
15718         * memrange.h: Fix common/ includes.
15719         * memattr.c: Fix common/ includes.
15720         * maint.h: Fix common/ includes.
15721         * maint.c: Fix common/ includes.
15722         * main.c: Fix common/ includes.
15723         * machoread.c: Fix common/ includes.
15724         * location.c: Fix common/ includes.
15725         * linux-thread-db.c: Fix common/ includes.
15726         * linux-nat.c: Fix common/ includes.
15727         * linux-fork.c: Fix common/ includes.
15728         * inline-frame.c: Fix common/ includes.
15729         * infrun.c: Fix common/ includes.
15730         * inflow.c: Fix common/ includes.
15731         * inferior.h: Fix common/ includes.
15732         * inferior.c: Fix common/ includes.
15733         * infcmd.c: Fix common/ includes.
15734         * inf-ptrace.c: Fix common/ includes.
15735         * inf-child.c: Fix common/ includes.
15736         * ia64-linux-nat.c: Fix common/ includes.
15737         * i387-tdep.c: Fix common/ includes.
15738         * i386-tdep.c: Fix common/ includes.
15739         * i386-linux-tdep.c: Fix common/ includes.
15740         * i386-linux-nat.c: Fix common/ includes.
15741         * i386-go32-tdep.c: Fix common/ includes.
15742         * i386-fbsd-tdep.c: Fix common/ includes.
15743         * i386-fbsd-nat.c: Fix common/ includes.
15744         * guile/scm-type.c: Fix common/ includes.
15745         * guile/guile.c: Fix common/ includes.
15746         * go32-nat.c: Fix common/ includes.
15747         * gnu-nat.c: Fix common/ includes.
15748         * gdbthread.h: Fix common/ includes.
15749         * gdbarch-selftests.c: Fix common/ includes.
15750         * gdb_usleep.c: Fix common/ includes.
15751         * gdb_select.h: Fix common/ includes.
15752         * gdb_bfd.c: Fix common/ includes.
15753         * gcore.c: Fix common/ includes.
15754         * fork-child.c: Fix common/ includes.
15755         * findvar.c: Fix common/ includes.
15756         * fbsd-nat.c: Fix common/ includes.
15757         * event-top.c: Fix common/ includes.
15758         * event-loop.c: Fix common/ includes.
15759         * dwarf2read.c: Fix common/ includes.
15760         * dwarf2loc.c: Fix common/ includes.
15761         * dwarf2-frame.c: Fix common/ includes.
15762         * dwarf-index-cache.c: Fix common/ includes.
15763         * dtrace-probe.c: Fix common/ includes.
15764         * disasm-selftests.c: Fix common/ includes.
15765         * defs.h: Fix common/ includes.
15766         * csky-tdep.c: Fix common/ includes.
15767         * cp-valprint.c: Fix common/ includes.
15768         * cp-support.h: Fix common/ includes.
15769         * cp-support.c: Fix common/ includes.
15770         * corelow.c: Fix common/ includes.
15771         * completer.h: Fix common/ includes.
15772         * completer.c: Fix common/ includes.
15773         * compile/compile.c: Fix common/ includes.
15774         * compile/compile-loc2c.c: Fix common/ includes.
15775         * compile/compile-cplus-types.c: Fix common/ includes.
15776         * compile/compile-cplus-symbols.c: Fix common/ includes.
15777         * command.h: Fix common/ includes.
15778         * cli/cli-dump.c: Fix common/ includes.
15779         * cli/cli-cmds.c: Fix common/ includes.
15780         * charset.c: Fix common/ includes.
15781         * build-id.c: Fix common/ includes.
15782         * btrace.h: Fix common/ includes.
15783         * btrace.c: Fix common/ includes.
15784         * breakpoint.h: Fix common/ includes.
15785         * breakpoint.c: Fix common/ includes.
15786         * ax.h:
15787         (enum agent_op): Fix common/ includes.
15788         * ax-general.c (struct aop_map): Fix common/ includes.
15789         * ax-gdb.c: Fix common/ includes.
15790         * auxv.c: Fix common/ includes.
15791         * auto-load.c: Fix common/ includes.
15792         * arm-tdep.c: Fix common/ includes.
15793         * arch/riscv.c: Fix common/ includes.
15794         * arch/ppc-linux-common.c: Fix common/ includes.
15795         * arch/i386.c: Fix common/ includes.
15796         * arch/arm.c: Fix common/ includes.
15797         * arch/arm-linux.c: Fix common/ includes.
15798         * arch/arm-get-next-pcs.c: Fix common/ includes.
15799         * arch/amd64.c: Fix common/ includes.
15800         * arch/aarch64.c: Fix common/ includes.
15801         * arch/aarch64-insn.c: Fix common/ includes.
15802         * arch-utils.c: Fix common/ includes.
15803         * amd64-windows-tdep.c: Fix common/ includes.
15804         * amd64-tdep.c: Fix common/ includes.
15805         * amd64-sol2-tdep.c: Fix common/ includes.
15806         * amd64-obsd-tdep.c: Fix common/ includes.
15807         * amd64-nbsd-tdep.c: Fix common/ includes.
15808         * amd64-linux-tdep.c: Fix common/ includes.
15809         * amd64-linux-nat.c: Fix common/ includes.
15810         * amd64-fbsd-tdep.c: Fix common/ includes.
15811         * amd64-fbsd-nat.c: Fix common/ includes.
15812         * amd64-dicos-tdep.c: Fix common/ includes.
15813         * amd64-darwin-tdep.c: Fix common/ includes.
15814         * agent.c: Fix common/ includes.
15815         * ada-lang.h: Fix common/ includes.
15816         * ada-lang.c: Fix common/ includes.
15817         * aarch64-tdep.c: Fix common/ includes.
15818
15819 2019-01-25  Tom Tromey  <tom@tromey.com>
15820
15821         * common/create-version.sh: Use common/version.h.
15822
15823 2019-01-24  Pedro Alves  <palves@redhat.com>
15824
15825         * infrun.c (signal_stop, signal_print, signal_program)
15826         (signal_catch, signal_pass): Now arrays instead of pointers.
15827         (update_signals_program_target, do_target_resume)
15828         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15829         * linux-nat.c (linux_nat_target::pass_signals)
15830         (linux_nat_target::create_inferior, linux_nat_target::attach):
15831         Adjust.
15832         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15833         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15834         * procfs.c (procfs_target::pass_signals): Adjust.
15835         * record-full.c (record_full_target::resume): Adjust.
15836         * remote.c (remote_target::pass_signals)
15837         (remote_target::program_signals): Adjust.
15838         * target-debug.h (target_debug_print_signals): Now takes a
15839         gdb::array_view as parameter.  Adjust.
15840         * target.h (target_ops) <pass_signals, program_signals>: Replace
15841         pointer and length parameters with gdb::array_view.
15842         (target_pass_signals, target_program_signals): Likewise.
15843         * target-delegates.c: Regenerate.
15844
15845 2019-01-24  Pedro Alves  <palves@redhat.com>
15846
15847         * common/forward-scope-exit.h
15848         (forward_scope_exit::forward_scope_exit): Pass arguments to
15849         m_bind_function directly, instead of creating a std::bind and
15850         copying that.
15851
15852 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15853
15854         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15855         for static members.
15856         (pass_in_v_vfp_candidate): Likewise.
15857
15858 2019-01-23  Tom Tromey  <tom@tromey.com>
15859             Pedro Alves  <palves@redhat.com>
15860
15861         * regcache.c (class regcache_invalidator): Remove.
15862         (regcache::raw_write): Use make_scope_exit.
15863
15864 2019-01-23  Tom Tromey  <tom@tromey.com>
15865
15866         * ui-out.h (class ui_out_emit_type): Update comment.
15867
15868 2019-01-23  Tom Tromey  <tom@tromey.com>
15869
15870         * infrun.c (fetch_inferior_event): Update comment.
15871
15872 2019-01-23  Tom Tromey  <tom@tromey.com>
15873             Pedro Alves  <palves@redhat.com>
15874
15875         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15876         parameter.
15877         (fetch_inferior_event): Use SCOPE_EXIT.
15878
15879
15880 2019-01-23  Tom Tromey  <tom@tromey.com>
15881             Pedro Alves  <palves@redhat.com>
15882
15883         * infrun.c (disable_thread_events): Delete.
15884         (stop_all_threads): Use SCOPE_EXIT.
15885
15886 2019-01-23  Tom Tromey  <tom@tromey.com>
15887             Pedro Alves  <palves@redhat.com>
15888
15889         * symfile.c: Include forward-scope-exit.h.
15890         (clear_symtab_users_cleanup): Replace forward declaration with
15891         a FORWARD_SCOPE_EXIT.
15892         (syms_from_objfile_1): Use the forward_scope_exit and
15893         gdb::optional instead of cleanup_function.
15894         (reread_symbols): Use the forward_scope_exit instead of
15895         cleanup_function.
15896         (clear_symtab_users_cleanup): Remove function.
15897
15898 2019-01-23  Tom Tromey  <tom@tromey.com>
15899             Pedro Alves  <palves@redhat.com>
15900
15901         * linux-nat.c: Include scope-exit.h.
15902         (cleanup_target_stop): Remove.
15903         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15904         SCOPE_EXIT.
15905
15906 2019-01-23  Tom Tromey  <tom@tromey.com>
15907             Pedro Alves  <palves@redhat.com>
15908
15909         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15910         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15911
15912 2019-01-23  Tom Tromey  <tom@tromey.com>
15913             Andrew Burgess  <andrew.burgess@embecosm.com>
15914             Pedro Alves  <palves@redhat.com>
15915
15916         * infrun.c (fetch_inferior_event): Use scope_exit.
15917         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15918         * top.c (execute_command): Use scope_exit.
15919         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15920         * utils.c (do_bpstat_clear_actions_cleanup)
15921         (make_bpstat_clear_actions_cleanup): Remove.
15922
15923 2019-01-23  Tom Tromey  <tom@tromey.com>
15924             Pedro Alves  <palves@redhat.com>
15925
15926         * infrun.c: Include "common/scope-exit.h"
15927         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15928         (wait_for_inferior): Use SCOPE_EXIT.
15929         (fetch_inferior_event): Use scope_exit.
15930
15931 2019-01-23  Tom Tromey  <tom@tromey.com>
15932             Pedro Alves  <palves@redhat.com>
15933
15934         * breakpoint.c (create_breakpoint): Remove cleanup.
15935
15936 2019-01-23  Tom Tromey  <tom@tromey.com>
15937             Andrew Burgess  <andrew.burgess@embecosm.com>
15938             Pedro Alves  <palves@redhat.com>
15939
15940 2019-01-23  Pedro Alves  <palves@redhat.com>
15941
15942         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15943
15944 2019-01-23  Pedro Alves  <palves@redhat.com>
15945             Andrew Burgess  <andrew.burgess@embecosm.com>
15946
15947         * gdbthread.h: Include "common/forward-scope-exit.h".
15948         (scoped_finish_thread_state): Redefine custom class in terms of
15949         forward_scope_exit.
15950
15951 2019-01-23  Pedro Alves  <palves@redhat.com>
15952             Andrew Burgess  <andrew.burgess@embecosm.com>
15953
15954         * common/forward-scope-exit.h: New file.
15955
15956 2019-01-23  Pedro Alves  <palves@redhat.com>
15957             Andrew Burgess  <andrew.burgess@embecosm.com>
15958             Tom Tromey  <tom@tromey.com>
15959
15960         * common/scope-exit.h: New file.
15961
15962 2019-01-23  Pedro Alves  <palves@redhat.com>
15963
15964         * common/preprocessor.h (ESC): Rename to ...
15965         (ESC_PARENS): ... this.
15966         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15967         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15968
15969 2019-01-23  Tom Tromey  <tom@tromey.com>
15970
15971         * language.h (class scoped_switch_to_sym_language_if_auto):
15972         Initialize m_lang in both cases.
15973
15974 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15975
15976         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15977         with XCNEW.
15978
15979 2019-01-22  Tom Tromey  <tom@tromey.com>
15980
15981         * corelow.c: Do not include sys/file.h.
15982
15983 2019-01-22  Tom Tromey  <tom@tromey.com>
15984
15985         * tui/tui-wingeneral.h: Include gdb_curses.h.
15986
15987 2019-01-22  Tom Tromey  <tom@tromey.com>
15988
15989         * source-cache.h (class source_cache) <get_source_lines,
15990         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15991
15992 2019-01-22  Tom Tromey  <tom@tromey.com>
15993
15994         * remote-fileio.h (struct remote_target): Declare.
15995
15996 2019-01-22  Tom Tromey  <tom@tromey.com>
15997
15998         * python/py-arch.c: Do not include py-ref.h.
15999         * python/py-bpevent.c: Do not include py-ref.h.
16000         * python/py-cmd.c: Do not include py-ref.h.
16001         * python/py-continueevent.c: Do not include py-ref.h.
16002         * python/py-event.h: Do not include py-ref.h.
16003         * python/py-evtregistry.c: Do not include py-ref.h.
16004         * python/py-finishbreakpoint.c: Do not include py-ref.h.
16005         * python/py-frame.c: Do not include py-ref.h.
16006         * python/py-framefilter.c: Do not include py-ref.h.
16007         * python/py-function.c: Do not include py-ref.h.
16008         * python/py-infevents.c: Do not include py-ref.h.
16009         * python/py-linetable.c: Do not include py-ref.h.
16010         * python/py-objfile.c: Do not include py-ref.h.
16011         * python/py-param.c: Do not include py-ref.h.
16012         * python/py-prettyprint.c: Do not include py-ref.h.
16013         * python/py-progspace.c: Do not include py-ref.h.
16014         * python/py-symbol.c: Do not include py-ref.h.
16015         * python/py-symtab.c: Do not include py-ref.h.
16016         * python/py-type.c: Do not include py-ref.h.
16017         * python/py-unwind.c: Do not include py-ref.h.
16018         * python/py-utils.c: Do not include py-ref.h.
16019         * python/py-value.c: Do not include py-ref.h.
16020         * python/py-varobj.c: Do not include py-ref.h.
16021         * python/py-xmethods.c: Do not include py-ref.h.
16022         * python/python.c: Do not include py-ref.h.
16023         * varobj.c: Do not include py-ref.h.
16024
16025 2019-01-22  Tom Tromey  <tom@tromey.com>
16026
16027         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16028         keyword for bcache.
16029
16030 2019-01-22  Tom Tromey  <tom@tromey.com>
16031
16032         * compile/compile-cplus-types.c: Remove a comment by #include.
16033
16034 2019-01-22  Tom Tromey  <tom@tromey.com>
16035
16036         * compile/gcc-c-plugin.h: Include compile-internal.h.
16037
16038 2019-01-22  Tom Tromey  <tom@tromey.com>
16039
16040         * stabsread.c (EXTERN): Do not define.
16041         (symnum, next_symbol_text_func, processing_gcc_compilation)
16042         (within_function, global_sym_chain, global_stabs)
16043         (previous_stab_code, this_object_header_files)
16044         (n_this_object_header_files)
16045         (n_allocated_this_object_header_files): Define.
16046         * stabsread.h (EXTERN): Never define.  Use "extern".
16047
16048 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16049
16050         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16051         history_value.
16052
16053 2019-01-21  Tom Tromey  <tom@tromey.com>
16054
16055         * ui-out.c: Fix includes.
16056         * tui/tui-source.c: Fix includes.
16057         * target.c: Fix includes.
16058         * remote.c: Fix includes.
16059         * regcache.c: Fix includes.
16060         * python/py-block.c: Fix includes.
16061         * printcmd.c: Fix includes.
16062         * or1k-tdep.c: Fix includes.
16063         * mi/mi-main.c: Fix includes.
16064         * m32r-tdep.c: Fix includes.
16065         * csky-tdep.c: Fix includes.
16066         * compile/compile-cplus-types.c: Fix includes.
16067         * cli/cli-interp.c: Fix includes.
16068
16069 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16070
16071         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16072         for padding.
16073
16074 2019-01-16  Tom Tromey  <tom@tromey.com>
16075
16076         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16077         earlier.
16078         (struct objfile) <msymbols_range>: Move from top level.
16079         <msymbols>: New method.
16080         (class objfile_msymbols): Remove.
16081         * symtab.c (default_collect_symbol_completion_matches_break_on):
16082         Update.
16083         * symmisc.c (dump_msymbols): Update.
16084         * stabsread.c (scan_file_globals): Update.
16085         * objc-lang.c (info_selectors_command, info_classes_command)
16086         (find_methods): Update.
16087         * minsyms.c (find_solib_trampoline_target): Update.
16088         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16089         * coffread.c (coff_symfile_read): Update.
16090         * ada-lang.c (ada_lookup_simple_minsym)
16091         (ada_collect_symbol_completion_matches): Update.
16092
16093 2019-01-16  Tom Tromey  <tom@tromey.com>
16094
16095         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16096         type.  Remove no-argument constructor.
16097         <iterator::operator++>: Simplify.
16098         <begin>: Update.
16099         <end>: Use minimal_symbol_count.
16100
16101 2019-01-16  Tom Tromey  <tom@tromey.com>
16102
16103         * objfiles.h (struct objfile) <psymtabs>: New method.
16104         (class objfile_psymtabs): Remove.
16105         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16106         typedef.
16107         <range>: New method.
16108         (require_partial_symbols): Change return type.
16109         * psymtab.c (require_partial_symbols)
16110         (psym_expand_symtabs_matching): Update.
16111         * mdebugread.c (parse_partial_symbols): Update.
16112         * dbxread.c (dbx_end_psymtab): Update.
16113
16114 2019-01-15  Tom Tromey  <tom@tromey.com>
16115
16116         * symtab.c (lookup_objfile_from_block)
16117         (lookup_symbol_in_objfile_symtabs)
16118         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16119         (find_line_symtab, info_sources_command)
16120         (default_collect_symbol_completion_matches_break_on)
16121         (make_source_files_completion_list): Update.
16122         * symmisc.c (print_objfile_statistics, dump_objfile)
16123         (maintenance_print_symbols, maintenance_info_symtabs)
16124         (maintenance_check_symtabs, maintenance_info_line_tables):
16125         Update.
16126         * source.c (select_source_symtab)
16127         (forget_cached_source_info_for_objfile): Update.
16128         * objfiles.h (class objfile_compunits): Remove.
16129         (struct objfile) <compunits_range>: New typedef.
16130         (compunits): New method.
16131         * objfiles.c (objfile_relocate1): Update.
16132         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16133         * maint.c (count_symtabs_and_blocks): Update.
16134         * linespec.c (iterate_over_all_matching_symtabs): Update.
16135         * cp-support.c (add_symbol_overload_list_qualified): Update.
16136         * coffread.c (coff_symtab_read): Update.
16137         * ada-lang.c (add_nonlocal_symbols)
16138         (ada_collect_symbol_completion_matches)
16139         (ada_add_global_exceptions): Update.
16140
16141 2019-01-15  Tom Tromey  <tom@tromey.com>
16142
16143         * progspace.h (program_space) <objfiles_safe_range>: New
16144         typedef.
16145         <objfiles_safe>: New method.
16146         * objfiles.h (class all_objfiles_safe): Remove.
16147         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16148         * jit.c (jit_inferior_exit_hook): Update.
16149
16150 2019-01-17  Tom Tromey  <tom@tromey.com>
16151
16152         * progspace.h (program_space) <objfiles_range>: New typedef.
16153         <objfiles>: New method.
16154         <objfiles_head>: Rename from objfiles.
16155         (object_files): Update.
16156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16157         * guile/scm-pretty-print.c
16158         (ppscm_find_pretty_printer_from_objfiles): Update.
16159         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16161         Update.
16162         * python/py-progspace.c (pspy_get_objfiles): Update.
16163         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16164         Update.
16165         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16166         (objfpy_lookup_objfile_by_build_id): Update.
16167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16168         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16169         Update.
16170         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16171         (expand_symtab_containing_pc, lookup_objfile_from_block)
16172         (lookup_static_symbol, basic_lookup_transparent_type)
16173         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16174         (find_line_symtab, info_sources_command)
16175         (default_collect_symbol_completion_matches_break_on)
16176         (make_source_files_completion_list, find_main_name): Update.
16177         * symmisc.c (print_symbol_bcache_statistics)
16178         (print_objfile_statistics, maintenance_print_symbols)
16179         (maintenance_print_msymbols, maintenance_print_objfiles)
16180         (maintenance_info_symtabs, maintenance_check_symtabs)
16181         (maintenance_expand_symtabs, maintenance_info_line_tables):
16182         Update.
16183         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16184         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16185         (map_overlay_command, unmap_overlay_command)
16186         (simple_overlay_update, expand_symtabs_matching)
16187         (map_symbol_filenames): Update.
16188         * symfile-debug.c (set_debug_symfile): Update.
16189         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16190         Update.
16191         * source.c (select_source_symtab, forget_cached_source_info):
16192         Update.
16193         * solib.c (solib_read_symbols): Update.
16194         * solib-spu.c (append_ocl_sos): Update.
16195         * psymtab.c (maintenance_print_psymbols)
16196         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16197         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16198         * printcmd.c (info_symbol_command): Update.
16199         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16200         Update.
16201         * objfiles.h (class all_objfiles): Remove.
16202         * objfiles.c (have_partial_symbols, have_full_symbols)
16203         (have_minimal_symbols, qsort_cmp, update_section_map)
16204         (shared_objfile_contains_address_p)
16205         (default_iterate_over_objfiles_in_search_order): Update.
16206         * objc-lang.c (info_selectors_command, info_classes_command)
16207         (find_methods): Update.
16208         * minsyms.c (find_solib_trampoline_target): Update.
16209         * maint.c (maintenance_info_sections)
16210         (maintenance_translate_address, count_symtabs_and_blocks):
16211         Update.
16212         * main.c (captured_main_1): Update.
16213         * linux-thread-db.c (try_thread_db_load_from_pdir)
16214         (has_libpthread): Update.
16215         * linespec.c (iterate_over_all_matching_symtabs)
16216         (search_minsyms_for_name): Update.
16217         * jit.c (jit_find_objf_with_entry_addr): Update.
16218         * hppa-tdep.c (find_unwind_entry)
16219         (hppa_lookup_stub_minimal_symbol): Update.
16220         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16221         Update.
16222         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16223         (elf_gnu_ifunc_resolve_by_got): Update.
16224         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16225         * dwarf-index-write.c (save_gdb_index_command): Update.
16226         * cp-support.c (add_symbol_overload_list_qualified): Update.
16227         * breakpoint.c (create_overlay_event_breakpoint)
16228         (create_longjmp_master_breakpoint)
16229         (create_std_terminate_master_breakpoint)
16230         (create_exception_master_breakpoint): Update.
16231         * blockframe.c (find_pc_partial_function): Update.
16232         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16233         (ada_collect_symbol_completion_matches)
16234         (ada_add_global_exceptions): Update.
16235
16236 2019-01-17  Tom Tromey  <tom@tromey.com>
16237
16238         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16239         declare VEC.
16240         (solib_target_parse_libraries): Change return type.
16241         (library_list_start_segment, library_list_start_section)
16242         (library_list_end_library, library_list_start_library); Update.
16243         (solib_target_free_library_list): Remove.
16244         (solib_target_parse_libraries): Remove cleanup.  Change return
16245         type.
16246         (solib_target_current_sos): Update.
16247
16248 2019-01-17  Tom Tromey  <tromey@bapiya>
16249
16250         * valprint.c: Replace "the the" with "the".
16251         * symtab.c: Replace "the the" with "the".
16252         * solib.c: Replace "the the" with "the".
16253         * solib-dsbt.c: Replace "the the" with "the".
16254         * linespec.c: Replace "the the" with "the".
16255         * dwarf2loc.h: Replace "the the" with "the".
16256         * amd64-windows-tdep.c: Replace "the the" with "the".
16257         * aarch64-tdep.c: Replace "the the" with "the".
16258
16259 2019-01-16  Keith Seitz  <keiths@redhat.com>
16260
16261         PR gdb/23773
16262         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16263         <builder>: Rename to ..
16264         <m_builder>: ... this and make private.
16265         (dwarf2_cu::get_builder): New method.  Change all users of
16266         `builder' to use this method.
16267         (dwarf2_start_symtab): Move to ...
16268         (dwarf2_cu::start_symtab): ... here.  Update all callers
16269         (setup_type_unit_groups): Move to ...
16270         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16271         callers.
16272         (dwarf2_cu::reset_builder): New method.
16273         (process_full_compunit, process_full_type_unit): Use
16274         dwarf2_cu::reset_builder.
16275         (follow_die_offset): Record the ancestor CU if it is different
16276         from the followed DIE's CU.
16277         (follow_die_sig_1): Likewise.
16278
16279 2019-01-15  Tom Tromey  <tom@tromey.com>
16280
16281         * remote.c (class remote_state) <buf>: Now a char_vector.
16282         <buf_size>: Remove.
16283         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16284         parameter.
16285         (remote_target::getpkt_or_notif_sane_1)
16286         (remote_target::getpkt_sane)
16287         (remote_target::getpkt_or_notif_sane): Likewise.
16288         (class remote_target) <putpkt>: New overload.
16289         (remote_target::read_frame): Change type of "buf_p".  Remove
16290         sizeof_p parameter.
16291         (packet_ok): New overload.
16292         (packet_check_result): New overload.
16293         Update all uses.
16294
16295 2019-01-14  Tom Tromey  <tom@tromey.com>
16296
16297         * remote-notif.c (handle_notification, remote_notif_ack)
16298         (remote_notif_parse): Make "buf" const.
16299         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16300         const.
16301         (remote_notif_parse, remote_notif_ack, handle_notification):
16302         Likewise.
16303         * remote.c (remote_notif_stop_parse): Make "buf" const.
16304         (remote_target::remote_parse_stop_reply): Make "buf" const.
16305         (remote_notif_stop_ack): Make "buf" const.
16306
16307 2019-01-14  Tom Tromey  <tom@tromey.com>
16308
16309         * remote.c (remote_console_output): Make parameter const.
16310
16311 2019-01-14  Tom Tromey  <tom@tromey.com>
16312
16313         * target-debug.h (target_debug_print_signals): Constify.
16314         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16315         * procfs.c (procfs_target::pass_signals): Update.
16316         * linux-nat.c (linux_nat_target::pass_signals): Update.
16317         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16318         * target-delegates.c: Rebuild.
16319         * remote.c (remote_target::program_signals): Update.
16320         (remote_target::pass_signals): Update.
16321         * target.c (target_pass_signals): Constify argument.
16322         (target_program_signals): Likewise.
16323         * target.h (struct target_ops) <pass_signals, program_signals>:
16324         Constify argument.
16325         (target_pass_signals, target_program_signals): Constify argument.
16326
16327 2019-01-14  Tom Tromey  <tom@tromey.com>
16328
16329         PR tui/28819:
16330         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16331
16332 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16333
16334         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16335         field.
16336         * rs6000-tdep.c: Include reggroups.h.
16337         (IS_V_ALIAS_PSEUDOREG): Define.
16338         (rs6000_register_name): Return names for the "vX" aliases.
16339         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16340         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16341         aliases.  Call default_register_reggroup_p for all other
16342         pseudo-registers.
16343         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16344         New functions.
16345         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16346         Handle "vX" aliases.
16347         (v_alias_pseudo_register_collect): New function.
16348         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16349         (rs6000_gdbarch_init): Initialize "vX" aliases as
16350         pseudo-registers.  Restore registration of
16351         rs6000_pseudo_register_reggroup_p with
16352         set_tdesc_pseudo_register_reggroup_p.
16353
16354 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16355
16356         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16357         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16358         set_gdbarch_num_pseudo_regs.
16359
16360 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16361
16362         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16363         Remove arg prefixname, add do_set and do_show.
16364         Add member functions set_list and show_list.
16365         * cli/cli-style.c (class cli_style_option): Update accordingly.
16366         (style_set_list): Move to file scope.
16367         (style_show_list): Likewise.
16368         (set_style): Call help_list.
16369         (show_style): Call cmd_show_list.
16370         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16371         Update to use the new macro.
16372
16373 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16374
16375         * ada-lang.c (_initialize_ada_language): Expand the help text
16376         for the "catch exception" command.
16377
16378 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16379
16380         * symtab.c (matching_obj_sections): Initialize obj,
16381         declare it closer to its usage.
16382
16383 2019-01-10  Tom Tromey  <tom@tromey.com>
16384
16385         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16386         (basic_inf_threads_range): Remove.
16387         (inf_threads_range, inf_non_exited_threads_range)
16388         (safe_inf_threads_range): Use next_adapter.
16389
16390 2019-01-10  Keith Seitz  <keiths@redhat.com>
16391
16392         PR gdb/23712
16393         PR symtab/23010
16394         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16395         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16396
16397 2019-01-10  Keith Seitz  <keiths@redhat.com>
16398
16399         PR gdb/23712
16400         PR symtab/23010
16401         * dictionary.c (pending_to_vector): Remove.
16402         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16403         Remove _1 suffix, replacing functions of the same name.  Update
16404         all callers.
16405         (dict_create_hashed, dict_create_hashed_expandable)
16406         (dict_create_linear, dict_create_linear_expandable, dict_free)
16407         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16408         Make functions static.
16409
16410 2019-01-10  Keith Seitz  <keiths@redhat.com>
16411
16412         PR gdb/23712
16413         PR symtab/23010
16414         * dictionary.h (struct dictionary): Replace declaration with
16415         multidictionary.
16416         (dict_create_hashed, dict_create_hashed_expandable)
16417         (dict_create_linear, dict_create_linear_expandable)
16418         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16419         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16420         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16421         taking multidictionary argument.
16422         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16423         * block.h (struct block) <dict>: Change to multidictionary
16424         and rename `multidict'.
16425         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16426         symmisc.c: Update all dictionary references to multidictionary.
16427
16428 2019-01-10  Keith Seitz  <keiths@redhat.com>
16429
16430         PR gdb/23712
16431         PR symtab/23010
16432         * dictionary.c: Include unordered_map.
16433         (pending_to_vector): New function.
16434         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16435         Rewrite the non-"_1" functions to take vector instead
16436         of linked list.
16437         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16438         "new" _1 versions of the same name.
16439         (multidictionary): Define.
16440         (std::hash<enum language): New definition.
16441         (collate_pending_symbols_by_language, mdict_create_hashed)
16442         (mdict_create_hashed_expandable, mdict_create_linear)
16443         (mdict_create_linear_expandable, mdict_free)
16444         (find_language_dictionary, create_new_language_dictionary)
16445         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16446         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16447         (mdict_size, mdict_empty): New functions.
16448         * dictionary.h (mdict_iterator): Define.
16449
16450 2019-01-10  Pedro Alves  <palves@redhat.com>
16451
16452         * breakpoint.c (read_uploaded_action)
16453         (create_tracepoint_from_upload): Adjust to use
16454         gdb::unique_xmalloc_ptr.
16455         * ctf.c (ctf_write_uploaded_tp):
16456         (SET_ARRAY_FIELD): Use emplace_back.
16457         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16458         * tracefile-tfile.c (tfile_write_uploaded_tp):
16459         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16460         gdb::unique_xmalloc_ptr.
16461         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16462         at_string, cond_string, cmd_strings>: Replace char pointers
16463         with gdb::unique_xmalloc_ptr.
16464
16465 2019-01-10  Pedro Alves  <palves@redhat.com>
16466
16467         * solib-target.c (library_list_start_library): Don't xstrdup name.
16468
16469 2019-01-10  Pedro Alves  <palves@redhat.com>
16470
16471         * mdebugread.c (parse_partial_symbols): Use
16472         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16473
16474 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16475
16476         * linux-fork.c (scoped_switch_fork_info)
16477         <~scoped_switch_fork_info>: Fix incorrect variable name.
16478
16479 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16480
16481         * linux-fork.c (scoped_switch_fork_info)
16482         <scoped_switch_fork_info>: Make explicit.
16483         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16484
16485 2019-01-10  Tom Tromey  <tom@tromey.com>
16486
16487         * objfiles.h (objfile::reset_psymtabs): Update.
16488         * objfiles.c (objfile::objfile): Update.
16489         * psymtab.h (psymtab_storage::obstack): Update.
16490         (psymtab_storage::m_obstack): Use gdb::optional.
16491         (class psymtab_storage): Update comment.  Remove objfile
16492         parameter.
16493         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16494
16495 2019-01-10  Tom Tromey  <tom@tromey.com>
16496
16497         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16498         <free_psymtabs>: Now private.
16499         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16500         (allocate_psymtab): Use new method.
16501
16502 2019-01-10  Tom Tromey  <tom@tromey.com>
16503
16504         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16505         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16506         * mdebugread.c (parse_partial_symbols): Use
16507         allocate_dependencies.
16508         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16509         allocate_dependencies.
16510         (process_psymtab_comp_unit_reader)
16511         (build_type_psymtab_dependencies): Likewise.
16512         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16513
16514 2019-01-10  Tom Tromey  <tom@tromey.com>
16515
16516         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16517         PSYMBOL_SET_LANGUAGE.
16518         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16519
16520 2019-01-10  Tom Tromey  <tom@tromey.com>
16521
16522         * psymtab.h (psymtab_storage::obstack): New method.
16523         <m_obstack>: Rename from obstack; now private.
16524         * psymtab.c (psymtab_storage): Update.
16525         * dwarf2read.c (create_addrmap_from_index)
16526         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16527         Update.
16528
16529 2019-01-10  Tom Tromey  <tom@tromey.com>
16530
16531         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16532         * objfiles.h (objfile::reset_psymtabs): New method.
16533
16534 2019-01-10  Tom Tromey  <tom@tromey.com>
16535
16536         * symmisc.c (print_symbol_bcache_statistics): Update.
16537         (print_objfile_statistics): Update.
16538         * symfile.c (reread_symbols): Update.
16539         * psymtab.h (class psymtab_storage): New.
16540         * psymtab.c (psymtab_storage): New constructor.
16541         (~psymtab_storage): New destructor.
16542         (require_partial_symbols): Update.
16543         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16544         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16545         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16546         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16547         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16548         (start_psymtab_common, end_psymtab_common)
16549         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16550         (allocate_psymtab): Update.
16551         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16552         Update.
16553         (dump_psymtab_addrmap, maintenance_print_psymbols)
16554         (maintenance_check_psymtabs): Update.
16555         (class objfile_psymtabs): Move to objfiles.h.
16556         * psympriv.h (discard_psymtab): Now inline.
16557         (psymtab_discarder::psymtab_discarder): Update.
16558         (psymtab_discarder::~psymtab_discarder): Update.
16559         (ALL_OBJFILE_PSYMTABS): Rewrite.
16560         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16561         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16562         Remove fields.
16563         <partial_symtabs>: New field.
16564         (class objfile_psymtabs): Move from psymtab.h.  Update.
16565         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16566         psymbol_cache.
16567         (objfile::~objfile): Don't destroy psymbol_cache.
16568         * mdebugread.c (parse_partial_symbols): Update.
16569         * dwarf2read.c (create_addrmap_from_index)
16570         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16571         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16572         (add_partial_subprogram, dwarf2_ranges_read): Update.
16573         * dwarf-index-write.c (write_address_map)
16574         (write_one_signatured_type, recursively_write_psymbols)
16575         (class debug_names, class debug_names, write_psymtabs_to_index):
16576         Update.
16577
16578 2019-01-10  Tom Tromey  <tom@tromey.com>
16579
16580         * symtab.h (SYMBOL_SET_NAMES): Update.
16581         (symbol_set_names): Update.
16582         (MSYMBOL_SET_NAMES): Update.
16583         * symtab.c (symbol_set_names): Change argument to be an
16584         objfile_per_bfd_storage.
16585         * psymtab.c (add_psymbol_to_bcache): Update.
16586         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16587
16588 2019-01-10  Tom Tromey  <tom@tromey.com>
16589
16590         * symtab.c (create_demangled_names_hash): Change argument to be an
16591         objfile_per_bfd_storage.
16592         (symbol_set_names): Update.
16593
16594 2019-01-10  Tom Tromey  <tom@tromey.com>
16595
16596         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16597         init_psymbol_list.
16598         * psymtab.c (init_psymbol_list): Do nothing if already called.
16599         * psympriv.h (init_psymbol_list): Add comment.
16600         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16601         init_psymbol_list.
16602         * dbxread.c (dbx_symfile_read): Unconditionally call
16603         init_psymbol_list.
16604
16605 2019-01-10  Tom Tromey  <tom@tromey.com>
16606
16607         * xcoffread.c (scan_xcoff_symtab): Update.
16608         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16609         "where".
16610         * mdebugread.c (parse_partial_symbols)
16611         (handle_psymbol_enumerators): Update.
16612         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16613         * dbxread.c (read_dbx_symtab): Update.
16614         * psympriv.h (psymbol_placement): New enum.
16615         (add_psymbol_to_list): Update.
16616
16617 2019-01-10  Tom Tromey  <tom@tromey.com>
16618
16619         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16620         static_psymbols parameters.
16621         (scan_xcoff_symtab): Update.
16622         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16623         static_psymbols parameters.
16624         * psympriv.h (start_psymtab_common): Update.
16625         * mdebugread.c (parse_partial_symbols): Update.
16626         * dwarf2read.c (create_partial_symtab): Update.
16627         * dbxread.c (read_dbx_symtab): Update.
16628         (start_psymtab): Remove global_psymbols and static_psymbols
16629         parameters.
16630
16631 2019-01-10  Tom Tromey  <tom@tromey.com>
16632
16633         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16634         * psymtab.c (allocate_psymtab): Add comment.
16635         * psympriv.h (allocate_psymtab): Add comment.
16636         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16637         initializations.
16638         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16639
16640 2019-01-10  Tom Tromey  <tom@tromey.com>
16641
16642         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16643         Don't declare.
16644         * mipsread.c: Include mdebugread.h.
16645         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16646         Declare.
16647         * elfread.c: Include mdebugread.h.
16648
16649 2019-01-09  Tom Tromey  <tom@tromey.com>
16650
16651         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16652         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16653         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16654         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16655         (psym_lookup_symbol, psym_find_last_source_symtab)
16656         (psym_forget_cached_source_info, psym_print_stats)
16657         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16658         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16659         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16660         (psym_find_compunit_symtab_by_address)
16661         (maintenance_print_psymbols, maintenance_info_psymtabs)
16662         (maintenance_check_psymtabs): Use ranged for.
16663         * psymtab.h (class objfile_psymtabs): New.
16664         (require_partial_symbols): Return objfile_psymtabs.
16665         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16666
16667 2019-01-09  Tom Tromey  <tom@tromey.com>
16668
16669         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16670         (find_pc_mapped_section, list_overlays_command)
16671         (map_overlay_command, unmap_overlay_command)
16672         (simple_overlay_update): Use all_objfiles.
16673         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16674         * printcmd.c (info_symbol_command): Use all_objfiles.
16675         * objfiles.h (ALL_OBJSECTIONS): Remove.
16676         * maint.c (maintenance_translate_address): Use all_objfiles.
16677         * gcore.c (gcore_create_callback): Use all_objfiles.
16678         (objfile_find_memory_regions): Likewise.
16679
16680 2019-01-09  Tom Tromey  <tom@tromey.com>
16681
16682         * symtab.c (find_line_symtab, info_sources_command)
16683         (make_source_files_completion_list): Use objfile_compunits.
16684         * source.c (select_source_symtab): Use objfile_compunits.
16685         * objfiles.h (struct objfile): Update comment.
16686         (ALL_OBJFILES): Remove.
16687         (ALL_FILETABS): Remove.
16688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16689         objfile_compunits.
16690
16691 2019-01-09  Tom Tromey  <tom@tromey.com>
16692
16693         * symmisc.c (print_objfile_statistics, dump_objfile)
16694         (maintenance_print_symbols): Use compunit_filetabs.
16695         * source.c (forget_cached_source_info_for_objfile): Use
16696         compunit_filetabs.
16697         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16698         (ALL_FILETABS): Use compunit_filetabs.
16699         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16700         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16701
16702 2019-01-09  Tom Tromey  <tom@tromey.com>
16703
16704         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16705         (compunit_filetabs): New.
16706         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16707         compunit_filetabs.
16708         (info_sources_command, make_source_files_completion_list): Remove
16709         declaration.
16710         * symmisc.c (print_objfile_statistics, dump_objfile)
16711         (maintenance_print_symbols): Remove declaration.
16712         (maintenance_info_symtabs): Use compunit_filetabs.
16713         (maintenance_info_line_tables): Likewise.
16714         * source.c (select_source_symtab): Change local variable name.
16715         (forget_cached_source_info_for_objfile): Remove declaration.
16716         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16717         * objfiles.c (objfile_relocate1): Remove declaration.
16718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16719         declaration.
16720         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16721         * coffread.c (coff_symtab_read): Remove declaration.
16722         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16723         compunit_filetabs.
16724
16725 2019-01-09  Tom Tromey  <tom@tromey.com>
16726
16727         * symtab.c (lookup_objfile_from_block)
16728         (find_pc_sect_compunit_symtab, search_symbols)
16729         (default_collect_symbol_completion_matches_break_on): Use
16730         objfile_compunits.
16731         * objfiles.h (ALL_COMPUNITS): Remove.
16732         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16733         * cp-support.c (add_symbol_overload_list_qualified): Use
16734         objfile_compunits.
16735         * ada-lang.c (ada_collect_symbol_completion_matches)
16736         (ada_add_global_exceptions): Use objfile_compunits.
16737
16738 2019-01-09  Tom Tromey  <tom@tromey.com>
16739
16740         * source.c (select_source_symtab)
16741         (forget_cached_source_info_for_objfile): Remove declaration.
16742         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16743         declaration.
16744         * maint.c (count_symtabs_and_blocks): Remove declaration.
16745         * cp-support.c (add_symbol_overload_list_qualified): Remove
16746         declaration.
16747         * coffread.c (coff_symtab_read): Remove declaration.
16748         * symtab.c (lookup_symbol_in_objfile_symtabs)
16749         (basic_lookup_transparent_type_1): Use objfile_compunits.
16750         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16751         (info_sources_command, search_symbols)
16752         (default_collect_symbol_completion_matches_break_on)
16753         (make_source_files_completion_list): Remove declaration.
16754         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16755         (ada_collect_symbol_completion_matches)
16756         (ada_add_global_exceptions): Remove declaration.
16757         * linespec.c (iterate_over_all_matching_symtabs): Use
16758         objfile_compunits.
16759         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16760         (class objfile_compunits): New.
16761         (ALL_COMPUNITS): Use objfile_compunits.
16762         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16763         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16764         objfile_compunits.
16765         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16766
16767 2019-01-09  Tom Tromey  <tom@tromey.com>
16768
16769         * symtab.c (search_symbols)
16770         (default_collect_symbol_completion_matches_break_on): Use
16771         objfile_msymbols.
16772         * ada-lang.c (ada_lookup_simple_minsym)
16773         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16774         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16775         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16776         objfile_msymbols.
16777         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16778         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16779         * objc-lang.c (find_methods): Use objfile_msymbols.
16780         (info_selectors_command, info_classes_command): Likewise.
16781         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16782         * objfiles.h (class objfile_msymbols): New.
16783         (ALL_OBJFILE_MSYMBOLS): Remove.
16784         (ALL_MSYMBOLS): Remove.
16785
16786 2019-01-09  Tom Tromey  <tom@tromey.com>
16787
16788         * common/next-iterator.h (next_adapter): Add Iterator template
16789         parameter.
16790         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16791         (class all_objfiles_safe): New.
16792         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16793         * objfiles.c (put_objfile_before): Update comment.
16794         (add_separate_debug_objfile): Likewise.
16795         (free_all_objfiles): Use all_objfiles_safe.
16796         (objfile_purge_solibs): Likewise.
16797
16798 2019-01-09  Tom Tromey  <tom@tromey.com>
16799
16800         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16801         (expand_symtab_containing_pc, lookup_static_symbol)
16802         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16803         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16804         all_objfiles.
16805         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16806         * breakpoint.c (create_overlay_event_breakpoint)
16807         (create_longjmp_master_breakpoint)
16808         (create_std_terminate_master_breakpoint)
16809         (create_exception_master_breakpoint): Use all_objfiles.
16810         * linux-thread-db.c (try_thread_db_load_from_pdir)
16811         (has_libpthread): Use all_objfiles.
16812         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16813         * linespec.c (iterate_over_all_matching_symtabs)
16814         (search_minsyms_for_name): Use all_objfiles.
16815         * maint.c (maintenance_info_sections): Use all_objfiles.
16816         * main.c (captured_main_1): Use all_objfiles.
16817         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16818         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16819         * guile/scm-pretty-print.c
16820         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16821         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16822         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16823         (maintenance_print_msymbols): Use all_objfiles.
16824         * source.c (select_source_symtab): Use all_objfiles.
16825         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16826         * symfile.c (remove_symbol_file_command)
16827         (expand_symtabs_matching, map_symbol_filenames): Use
16828         all_objfiles.
16829         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16830         all_objfiles.
16831         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16832         * objc-lang.c (find_methods): Use all_objfiles.
16833         * objfiles.c (have_partial_symbols, have_full_symbols)
16834         (have_minimal_symbols, qsort_cmp)
16835         (default_iterate_over_objfiles_in_search_order): Use
16836         all_objfiles.
16837         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16838         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16839         (maintenance_check_psymtabs): Use all_objfiles.
16840         (ALL_PSYMTABS): Remove.
16841         * compile/compile-object-run.c (do_module_cleanup): Use
16842         all_objfiles.
16843         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16844         * cp-support.c (add_symbol_overload_list_qualified): Use
16845         all_objfiles.
16846         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16847         Use all_objfiles.
16848         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16849         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16850         all_objfiles.
16851         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16852         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16853         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16854         Uses all_objfiles.
16855         * solib.c (solib_read_symbols): Use all_objfiles
16856
16857 2019-01-09  Tom Tromey  <tom@tromey.com>
16858
16859         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16860         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16861         all_objfiles.
16862         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16863         * symmisc.c (print_symbol_bcache_statistics)
16864         (print_objfile_statistics, maintenance_print_objfiles)
16865         (maintenance_info_symtabs, maintenance_check_symtabs)
16866         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16867         all_objfiles.
16868         * source.c (forget_cached_source_info): Use all_objfiles.
16869         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16870         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16871         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16872         * objfiles.c (update_section_map): Use all_objfiles.
16873         (shared_objfile_contains_address_p): Likewise.
16874         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16875         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16876
16877 2019-01-09  Tom Tromey  <tom@tromey.com>
16878
16879         * common/next-iterator.h: New file.
16880         * objfiles.h (class all_objfiles): New.
16881         (struct objfile_iterator): New.
16882
16883 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16884
16885         * NEWS: Move the description of the changed "frame", "select-frame",
16886          and "info frame" commands to the Changed commands section.
16887
16888 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16889
16890         * gdbtypes.c (check_stub_method_group): Remove handling of old
16891         mangling schemes.
16892         * linespec.c (find_methods): Likewise.
16893         * stabsread.c (read_member_functions): Likewise.
16894         * valops.c (search_struct_method): Likewise.
16895         (value_struct_elt_for_reference): Likewise.
16896         * NEWS: Mention this change.
16897
16898 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16899
16900         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16901         print_source_lines.
16902         * source.c (print_source_lines_base): Update line number check.
16903         (print_source_lines): New function.
16904         (source_lines_range::source_lines_range): New function.
16905         * source.h (class source_lines_range): New class.
16906         (print_source_lines): New declaration.
16907
16908 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16909
16910         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16911
16912 2019-01-08  Tom Tromey  <tom@tromey.com>
16913             Simon Marchi  <simon.marchi@ericsson.com>
16914
16915         PR gdb/24060
16916         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16917         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16918         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16919         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16920         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16921         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16922
16923 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16924
16925         * source.c (select_source_symtab): Move header comment to
16926         declaration in source.h.
16927         (forget_cached_source_info_for_objfile): Likewise.
16928         (forget_cached_source_info): Likewise.
16929         (identify_source_line): Likewise.
16930         * source.h (identify_source_line): Move declaration from symtab.h
16931         and add comment from source.c
16932         (print_source_lines): Likewise.
16933         (forget_cached_source_info_for_objfile): Likewise.
16934         (forget_cached_source_info): Likewise.
16935         (select_source_symtab): Likewise.
16936         (enum print_source_lines_flag): Move definition from symtab.h.
16937         * symtab.h (identify_source_line): Move declaration to source.h.
16938         (print_source_lines): Likewise.
16939         (forget_cached_source_info_for_objfile): Likewise.
16940         (forget_cached_source_info): Likewise.
16941         (select_source_symtab): Likewise.
16942         (enum print_source_lines_flag): Move definition to source.h.
16943         * tui/tui-hooks.c: Add 'source.h' include.
16944
16945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16946
16947         * source.c (print_source_lines_base): Handle requests to print
16948         reverse line number sequences, and guard against empty lines
16949         string.
16950
16951 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16952
16953         * source.c (print_source_lines_base): Fix skip of '\r' if next
16954         character is '\n'.
16955
16956 2019-01-06  Tom Tromey  <tom@tromey.com>
16957
16958         * c-exp.y (struct c_parse_state) <macro_original_text,
16959         expansion_obstack>: New member.
16960         (macro_original_text, expansion_obstack): Remove globals.
16961         (scan_macro_expansion, scanning_macro_expansion)
16962         (finished_macro_expansion): Update.
16963         (scan_macro_cleanup): Remove.
16964         (yylex, c_parse): Update.
16965
16966 2019-01-06  Tom Tromey  <tom@tromey.com>
16967
16968         * c-exp.y (struct c_parse_state) <strings>: New member.
16969         (operator_stoken): Update.
16970
16971 2019-01-06  Tom Tromey  <tom@tromey.com>
16972
16973         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16974         (union type_stack_elt) <typelist_val>: Now a pointer to
16975         std::vector.
16976         (type_stack_cleanup): Don't declare.
16977         (push_typelist): Update.
16978         * parse.c (pop_typelist): Return a std::vector.
16979         (push_typelist): Take a std::vector.
16980         (follow_types): Update.  Do not free args.
16981         (type_stack_cleanup): Remove.
16982         * c-exp.y (struct c_parse_state): New.
16983         (cpstate): New global.
16984         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16985         (nonempty_typelist): Update.
16986         (func_mod): Create a new vector.
16987         (c_parse): Create a c_parse_state.
16988         (check_parameter_typelist): Do not delete params.
16989         (function_method): Update.  Do not delete type_list.
16990
16991 2019-01-06  Tom Tromey  <tom@tromey.com>
16992
16993         PR gdb/28155:
16994         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16995         check_typedef.
16996         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16997         (print_return_value): Likewise.
16998
16999 2019-01-05  Tom Tromey  <tom@tromey.com>
17000
17001         * contrib/cleanup_check.py: Remove.
17002         * contrib/gcc-with-excheck: Remove.
17003         * contrib/exsummary.py: Remove.
17004         * contrib/excheck.py: Remove.
17005
17006 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
17007
17008         * thread.c (delete_thread_1): Add gdb_assert that THR is not
17009         NULL. Initialize tpprev to NULL instead of assigning it
17010         to NULL on the next statement.
17011         * windows-nat.c (windows_delete_thread): Remove check for
17012         main_thread_id before printing thread exit notifications.
17013         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17014         Remove thread ID check against main_thread_id.
17015         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17016         windows_delete_thread.
17017         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17018
17019 2019-01-04  Tom Tromey  <tom@tromey.com>
17020
17021         * compile/compile.c (_initialize_compile): Use upper case for
17022         metasyntactic variables.
17023         * symmisc.c (_initialize_symmisc): Use upper case for
17024         metasyntactic variables.
17025         * psymtab.c (_initialize_psymtab): Use upper case for
17026         metasyntactic variables.
17027         * demangle.c (demangle_command): Use upper case for metasyntactic
17028         variables.
17029         (_initialize_demangler): Likewise.
17030         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17031         variables.
17032
17033 2019-01-03  Tom Tromey  <tom@tromey.com>
17034
17035         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17036
17037 2019-01-03  Tom Tromey  <tom@tromey.com>
17038
17039         * python/py-symtab.c (salpy_str): Update.
17040         (struct salpy_sal_object) <symtab>: Now a PyObject.
17041         (salpy_dealloc): Update.
17042         (del_objfile_sal): Use gdbpy_ref.
17043
17044 2019-01-03  Tom Tromey  <tom@tromey.com>
17045
17046         * python/py-type.c (convert_field): Use new_reference.  Return
17047         gdbpy_ref.
17048         (make_fielditem): Return gdbpy_ref.
17049         (typy_fields): Update.
17050         (typy_getitem): Update.
17051         (field_name): Return gdbpy_ref.  Use new_reference.
17052         (typy_iterator_iternext): Update.
17053
17054 2019-01-03  Tom Tromey  <tom@tromey.com>
17055
17056         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17057
17058 2019-01-03  Tom Tromey  <tom@tromey.com>
17059
17060         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17061         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17062         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17063         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17064         (pspy_set_type_printers): Likewise.
17065         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17066         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17067         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17068         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17069         (objfpy_set_type_printers): Likewise.
17070
17071 2019-01-03  Tom Tromey  <tom@tromey.com>
17072
17073         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17074         (gdbpy_print_stack): Use gdbpy_err_fetch.
17075         * python/python-internal.h (class gdbpy_err_fetch): New class.
17076         (class gdbpy_enter) <m_error_type, m_error_value,
17077         m_error_traceback>: Remove.
17078         <m_error>: New member.
17079         (gdbpy_exception_to_string): Don't declare.
17080         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17081         * python/py-value.c (convert_value_from_python): Use
17082         gdbpy_err_fetch.
17083         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17084         gdbpy_exception_to_string.
17085         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17086         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17087         gdbpy_err_fetch.
17088
17089 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17090
17091         * linux-nat.c (delete_lwp_cleanup): Delete.
17092         (struct lwp_deleter): New struct.
17093         (lwp_info_up): New typedef.
17094         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17095         lwp_info_up.
17096
17097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17098
17099         * linux-fork.c (class scoped_switch_fork_info): New class.
17100         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17101
17102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17103
17104         * valops.c (find_overload_match): Remove use of null_cleanup, and
17105         calls to do_cleanups.
17106
17107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17108
17109         * compile/compile-cplus-types.c
17110         (compile_cplus_instance::decl_name): Handle changes to
17111         cp_func_name.
17112         * cp-support.c (cp_func_name): Update header comment, update
17113         return type.
17114         * cp-support.h (cp_func_name): Update return type in declaration.
17115         * valops.c (find_overload_match): Move temp_func local to top
17116         level of function and change its type.  Use temp_func to hold and
17117         delete temporary string obtained from cp_func_name.
17118
17119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17120
17121         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17122         gdb::char_vector, remove cleanup, and update uses of `msg`.
17123
17124 2019-01-03  Jim Wilson  <jimw@sifive.com>
17125
17126         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17127
17128 2019-01-02  Tom Tromey  <tom@tromey.com>
17129
17130         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17131         (tdesc_parse_xml): Remove cleanups.
17132         * target-descriptions.h (make_cleanup_free_target_description):
17133         Don't declare.
17134         (target_desc_deleter): New struct.
17135         (target_desc_up): New typedef.
17136         * target-descriptions.c (target_desc_deleter::operator()): Rename
17137         from free_target_description.
17138         (make_cleanup_free_target_description): Remove.
17139
17140 2019-01-02  Tom Tromey  <tom@tromey.com>
17141
17142         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17143         constructor, destructor.
17144         (linespec_parser): Remove typedef.
17145         (~linespec_parser): Rename from linespec_parser_delete.
17146         (linespec_lex_to_end, linespec_complete_label)
17147         (linespec_complete): Update.
17148         (decode_line_full): Remove cleanups.
17149         (decode_line_1): Update.
17150
17151 2019-01-02  Tom Tromey  <tom@tromey.com>
17152
17153         * python/python-internal.h (inferior_to_inferior_object): Change
17154         return type.
17155         * python/py-exitedevent.c (create_exited_event_object): Update.
17156         * python/py-inferior.c (inferior_to_inferior_object): Return
17157         gdbpy_ref.
17158         (python_new_inferior, python_inferior_deleted)
17159         (thread_to_thread_object, delete_thread_object)
17160         (build_inferior_list, gdbpy_selected_inferior): Update.
17161         * python/py-infthread.c (create_thread_object): Update.  Also fail
17162         if inferior_to_inferior_object fails.
17163
17164 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17165
17166         * inferior.h (class inferior) <displaced_step_state>: New field.
17167         * infrun.h (struct displaced_step_state): Move here from
17168         infrun.c.  Initialize fields, add constructor.
17169         <inf>: Remove field.
17170         <reset>: New method.
17171         * infrun.c (struct displaced_step_inferior_state): Move to
17172         infrun.h.
17173         (displaced_step_inferior_states): Remove.
17174         (get_displaced_stepping_state): Adust.
17175         (displaced_step_in_progress_any_inferior): Adjust.
17176         (displaced_step_in_progress_thread): Adjust.
17177         (displaced_step_in_progress): Adjust.
17178         (add_displaced_stepping_state): Remove.
17179         (get_displaced_step_closure_by_addr): Adjust.
17180         (remove_displaced_stepping_state): Remove.
17181         (infrun_inferior_exit): Call displaced_step_state.reset.
17182         (use_displaced_stepping): Don't check for NULL.
17183         (displaced_step_prepare_throw): Call
17184         get_displaced_stepping_state.
17185         (displaced_step_fixup): Don't check for NULL.
17186         (prepare_for_detach): Don't check for NULL.
17187
17188 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17189
17190         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17191          in case of call that did not complete.
17192
17193 2019-01-02  Andrey Utkin  <autkin@undo.io>
17194
17195         * symfile.c (find_separate_debug_file): Fix search of debug files for
17196         remote debuggee.
17197
17198 2019-01-02  Tom Tromey  <tom@tromey.com>
17199
17200         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17201         indentation.
17202         * python/py-frame.c (frapy_older): Remove cast.
17203         (frapy_newer): Likewise.
17204         * python/py-breakpoint.c (local_setattro): Remove cast.
17205         * python/py-arch.c (archpy_name): Remove local variable.
17206         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17207
17208 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17209
17210         * unittests/basic_string_view/element_access/char/empty.cc:
17211         Fix year range in copyright header.
17212
17213 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17214
17215         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17216         Delete.
17217         <operator==>: Update with for removed field.
17218         <hash>: Likewise.
17219         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17220         <isa_features>: ...this.
17221         <abi_features>: New field.
17222         (riscv_isa_flen): Update comment.
17223         (riscv_abi_xlen): New declaration.
17224         (riscv_abi_flen): New declaration.
17225         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17226         isa_features.
17227         (riscv_abi_xlen): New function.
17228         (riscv_isa_flen): Update to get answer from isa_features.
17229         (riscv_abi_flen): New function.
17230         (riscv_has_fp_abi): Update to get answer from abi_features.
17231         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17232         xlen and flen.
17233         (riscv_call_info) <xlen, flen>: Update comment.
17234         (riscv_call_arg_struct): Remove invalid assertions
17235         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17236         is removed.
17237         (riscv_gdbarch_init): Gather isa features and abi features
17238         separately, ensure both match on the gdbarch when reusing an old
17239         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17240         a target with 64-bit float hardware.
17241
17242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17243
17244         * source.c (search_command_helper): Stop reverse search
17245         when line 1 has been searched.
17246
17247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17248
17249         * record-full.c (record_full_base_target::close): Rewrite
17250         record_full_core_buf_list free logic.
17251
17252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17253
17254         * break-catch-syscall.c (print_one_catch_syscall): xfree
17255         the last text.
17256
17257 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17258
17259         * top.c (print_gdb_version): Update Copyright year in version
17260         message.
17261
17262 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17263
17264         Update copyright year range in all GDB files.
17265
17266 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17267
17268         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17269
17270 For older changes see ChangeLog-2018.
17271 \f
17272 Local Variables:
17273 mode: change-log
17274 left-margin: 8
17275 fill-column: 74
17276 version-control: never
17277 coding: utf-8
17278 End:
17279