gdb/ChangeLog

   1 2019-11-13  Tom Tromey  <tromey@adacore.com>
   2
   3         PR build/25182:
   4         * psympriv.h (partial_symbol): Remove static assert.
   5         * symtab.h (general_symbol_info, symbol): Remove static assert.
   6
   7 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         * gdbsupport/format.c (format_pieces::format_pieces): Support
  10         printf 'z' size modifier.
  11         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  12         * printcmd.c (ui_printf):  Handle size_t_arg.
  13         * ui-out.c (ui_out::vmessage): Likewise.
  14         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  15         function.
  16         (run_tests): Call test_format_int_sizes.
  17
  18 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * ada-exp.y (write_ambiguous_var): Update.
  21         * buildsym.c (add_symbol_to_list): Update.
  22         * dwarf2read.c (read_variable): Update.
  23         (new_symbol): Update.
  24         * jit.c (finalize_symtab): Update.
  25         * language.c (language_alloc_type_symbol): Update.
  26         * symtab.c (fixup_symbol_section): Update.
  27         (initialize_objfile_symbol_1): Move code to...
  28         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  29         (allocate_symbol): Update.
  30         (allocate_template_symbol): Update.
  31         (get_symbol_address): Update.
  32         * symtab.h (struct symbol): Inherit from general_symbol_info instead
  33         of having as a field, and add a constructor.
  34         (SYMBOL_VALUE): Update.
  35         (SYMBOL_VALUE_ADDRESS): Update.
  36         (SET_SYMBOL_VALUE_ADDRESS): Update.
  37         (SYMBOL_VALUE_BYTES): Update.
  38         (SYMBOL_VALUE_COMMON_BLOCK): Update.
  39         (SYMBOL_BLOCK_VALUE): Update.
  40         (SYMBOL_VALUE_CHAIN): Update.
  41         (SYMBOL_LANGUAGE): Update.
  42         (SYMBOL_SECTION): Update.
  43         (SYMBOL_OBJ_SECTION): Update.
  44         (SYMBOL_SET_LANGUAGE): Update.
  45         (SYMBOL_SET_LINKAGE_NAME): Update.
  46         (SYMBOL_SET_NAMES): Update.
  47         (SYMBOL_NATURAL_NAME): Update.
  48         (SYMBOL_LINKAGE_NAME): Update.
  49         (SYMBOL_DEMANGLED_NAME): Update.
  50         (SYMBOL_SEARCH_NAME): Update.
  51         (SYMBOL_MATCHES_SEARCH_NAME): Update.
  52         (struct symbol): Update.
  53         (struct template_symbol): Update.
  54         (struct rust_vtable_symbol): Update.
  55         * xcoffread.c (SYMBOL_DUP): Update.
  56
  57 2019-11-12  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-layout.c (show_layout): Set current_layout.
  60         (show_source_disasm_command, show_data)
  61         (show_source_or_disasm_and_command): Don't set current_layout.
  62
  63 2019-11-12  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
  66
  67 2019-11-12  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-win.c (resize_message): New global.
  70         (show_tui_resize_message): New function.
  71         (tui_async_resize_screen): Print message if requested.
  72         (_initialize_tui_win): Add tui-resize-message setting.
  73         * NEWS: Add entry for new commands.
  74
  75 2019-11-11  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui.c (tui_initialize_readline): Add new bindable readline
  78         functions.
  79
  80 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
  81
  82         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
  83
  84 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
  87         function.
  88         * python/python-internal.h (gdbpy_lookup_static_symbols):
  89         Declare new function.
  90         * python/python.c (python_GdbMethods): Add
  91         gdb.lookup_static_symbols method.
  92         * NEWS: Mention gdb.lookup_static_symbols.
  93
  94 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
  97         static block of current object file first.  Also fix typo in
  98         header comment.
  99
 100 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * stack.c (set_last_displayed_sal): Delete.
 103         (last_displayed_sal_valid): Delete.
 104         (last_displayed_pspace): Delete.
 105         (last_displayed_addr): Delete.
 106         (last_displayed_symtab): Delete.
 107         (last_displayed_line): Delete.
 108         (class last_displayed_symtab_info_type): New.
 109         (last_displayed_symtab_info): New static global variable.
 110         (print_frame_info): Call methods on last_displayed_symtab_info.
 111         (clear_last_displayed_sal): Update header comment, and make use of
 112         last_displayed_symtab_info.
 113         (last_displayed_sal_is_valid): Likewise.
 114         (get_last_displayed_pspace): Likewise.
 115         (get_last_displayed_addr): Likewise.
 116         (get_last_displayed_symtab): Likewise.
 117         (get_last_displayed_line): Likewise.
 118         (get_last_displayed_sal): Likewise.
 119         * stack.h (clear_last_displayed_sal): Update header comment.
 120         (last_displayed_sal_is_valid): Likewise.
 121         (get_last_displayed_pspace): Likewise.
 122         (get_last_displayed_addr): Likewise.
 123         (get_last_displayed_symtab): Likewise.
 124         (get_last_displayed_line): Likewise.
 125         (get_last_displayed_sal): Likewise.
 126
 127 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 128
 129         * stack.c (frame_show_address): Convert return type to bool.
 130         * stack.h (frame_show_address): Likewise, and update header
 131         comment.
 132
 133 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 136         * unittests/vec-utils-selftests.c: New file.
 137         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 138
 139 2019-11-10  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 142         (tui_highlight_win): Likewise.
 143         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 144         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 145         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 146         Don't set can_highlight.
 147
 148 2019-11-10  Tom Tromey  <tom@tromey.com>
 149
 150         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 151         Remove unused declaration.
 152
 153 2019-11-08  Tom Tromey  <tromey@adacore.com>
 154
 155         * top.c (read_command_file): Update.
 156         (command_line_input): Make return type const.
 157         * python/py-gdb-readline.c: Update.
 158         * linespec.c (decode_line_2): Update.
 159         * defs.h (command_line_input): Make return type const.
 160         * cli/cli-script.c (read_next_line): Make return type const.
 161         * ada-lang.c (get_selections): Update.
 162
 163 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 166         * mi/mi-main.c (output_cores): Likewise.
 167         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 168         (linux_xfer_osdata_modules): Likewise.
 169         * remote.c (register_remote_support_xml): Likewise.
 170         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 171         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 172
 173 2019-11-06  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-interp.c: Don't include readline.h.
 176         * tui/tui-hooks.c: Don't include readline.h.
 177         * symmisc.c: Include tilde.h, not readline.h.
 178         * symfile.c: Include tilde.h, not readline.h.
 179         * source.c: Include tilde.h, not readline.h.
 180         * solib.c: Include tilde.h, not readline.h.
 181         * psymtab.c: Include tilde.h, not readline.h.
 182         * exec.c: Include tilde.h, not readline.h.
 183         * corelow.c: Include tilde.h, not readline.h.
 184         * cli/cli-dump.c: Include tilde.h, not readline.h.
 185         * cli/cli-cmds.c: Don't include readline.h.
 186
 187 2019-11-05  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 190         (tui_disassemble): Set addr_size.
 191         (tui_disasm_window::set_contents): Use addr_size.
 192
 193 2019-11-05  Tom Tromey  <tom@tromey.com>
 194
 195         * rust-lang.c (rust_language_defn): Update.
 196         * python/py-value.c (valpy_string): Call c_get_string.
 197         * p-lang.c (pascal_language_defn): Update.
 198         * opencl-lang.c (opencl_language_defn): Update.
 199         * objc-lang.c (objc_language_defn): Update.
 200         * m2-lang.c (m2_language_defn): Update.
 201         * language.c (unknown_language_defn, auto_language_defn): Update.
 202         (default_get_string): Remove.
 203         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 204         * go-lang.c (go_language_defn): Update.
 205         * f-lang.c (f_language_defn): Update.
 206         * d-lang.c (d_language_defn): Update.
 207         * c-lang.c (c_language_defn, cplus_language_defn)
 208         (asm_language_defn, minimal_language_defn): Update.
 209         * ada-lang.c (ada_language_defn): Update.
 210         * language.h (struct language_defn) <la_get_string>: Remove.
 211         (LA_GET_STRING): Remove.
 212         (default_get_string): Don't declare.
 213
 214 2019-11-05  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-source.h (struct tui_source_window): Inline
 217         constructor.  Remove destructor.
 218         <style_changed, m_observable>: Move to superclass.
 219         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 220         (struct tui_source_window_base): Move private members to end.
 221         <style_changed, m_observable>: Move from tui_source_window.
 222         * tui/tui-winsource.c (tui_copy_source_line): Move from
 223         tui-source.c.  Rename from copy_source_line.  Add special handling
 224         for negative line number.
 225         (tui_source_window_base::style_changed): Move from
 226         tui_source_window.
 227         (tui_source_window_base): Register observer.
 228         (~tui_source_window_base): New.
 229         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 230         rename.
 231         (tui_source_window::set_contents): Use tui_copy_source_line.
 232         (tui_source_window::tui_source_window): Move to tui-source.h.
 233         (tui_source_window::~tui_source_window): Remove.
 234         (tui_source_window::style_changed): Move to superclass.
 235         * tui/tui-disasm.c (tui_disassemble): Create string file with
 236         styling, when possible.  Add "addr_size" parameter.
 237         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 238         Don't compute maximum size.
 239         (len_without_escapes): New function
 240
 241 2019-11-05  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 244         std::string.
 245         * tui/tui-winsource.c (tui_show_source_line): Update.
 246         * tui/tui-source.c (tui_source_window::set_contents): Update.
 247         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 248
 249 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * symtab.h (gdb_static_assert): Put && operator at the beginning
 252         of the line instead of the end.
 253
 254 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 255
 256         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 257         and sizeof (symbol).
 258         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 259
 260 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 261
 262         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 263         * configure.host: Mark *-*-solaris2.10* obsolete.
 264         * configure.tgt: Mark Solaris < 11 obsolete.
 265         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 266         Update target triplet.
 267
 268 2019-11-01  Tom Tromey  <tromey@adacore.com>
 269
 270         * utils.c (print_sys_errmsg): Simplify.
 271
 272 2019-11-01  Tom Tromey  <tromey@adacore.com>
 273
 274         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 275
 276 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 277
 278         * configure: Regenerate.
 279         * configure.ac: Remove check for strerror_r.
 280         * gdbsupport/common.m4: Check for strerror_r.
 281
 282 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 283
 284         PR gdb/25124
 285
 286         * arm-tdep.c (arm_per_objfile): Rename to ...
 287         (arm_per_bfd): ... this.
 288         (arm_objfile_data_key): Rename to ...
 289         (arm_bfd_data_key): ... this.
 290         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 291         data.
 292         (arm_record_special_symbol): Likewise.
 293
 294 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 297         end.
 298         * c-typeprint.c (c_print_typedef): Likewise.
 299         * f-typeprint.c (f_print_typedef): Likewise.
 300         * m2-typeprint.c (m2_print_typedef): Likewise.
 301         * p-typeprint.c (pascal_print_typedef): Likewise.
 302         * rust-lang.c (rust_print_typedef): Likewise.
 303         * symtab.c (print_symbol_info): Print a newline after calling
 304         typedef_print.
 305
 306 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * symtab.c (info_module_cmdlist): New variable.
 309         (info_module_command): New function.
 310         (search_module_symbols): New function.
 311         (info_module_subcommand): New function.
 312         (struct info_modules_var_func_options): New struct.
 313         (info_modules_var_func_options_defs): New variable.
 314         (make_info_modules_var_func_options_def_group): New function.
 315         (info_module_functions_command): New function.
 316         (info_module_variables_command): New function.
 317         (info_module_var_func_command_completer): New function.
 318         (_initialize_symtab): Register new 'info module functions' and
 319         'info module variables' commands.
 320         * symtab.h (typedef symbol_search_in_module): New typedef.
 321         (search_module_symbols): Declare new function.
 322         * NEWS: Mention new commands.
 323
 324 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 325
 326         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 327         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 328         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 329         MODULES_DOMAIN.
 330         (scan_partial_symbols): Only create partial module symbols for non
 331         declarations.
 332         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 333         and MODULES_DOMAIN.
 334         * symtab.c (search_domain_name): Likewise.
 335         (search_symbols): Likewise.
 336         (print_symbol_info): Likewise.
 337         (symtab_symbol_info): Likewise.
 338         (info_modules_command): New function.
 339         (_initialize_symtab): Register 'info modules' command.
 340         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 341         * NEWS: Mention new 'info modules' command.
 342
 343 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 344
 345         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 346         and $_gdb_maint_setting_str.
 347
 348 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 349
 350         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 351         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 352         (str_value_from_setting, gdb_setting_str_internal_fn)
 353         (gdb_maint_setting_str_internal_fn): New functions.
 354         (_initialize_cli_cmds): Define the new convenience functions.
 355         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 356         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 357
 358 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 359
 360         * agent.c (set_can_use_agent): When the setting is turned on,
 361         look up agent symbols if we don't have them yet.
 362         (agent_new_objfile): Don't look up agent symbols when the agent
 363         setting is off.
 364
 365 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * config.in: Regenerate.
 368
 369 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 370
 371         * configure: Regenerate.
 372         * configure.ac: Check for strerror_r.
 373         * gdbsupport/common-utils.h (safe_strerror): Change return value
 374         to const char * and document that this function is now threadsafe.
 375         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 376         thread_local and call strerror_r, if available.
 377         * utils.c (perror_string): Update.
 378         (print_sys_errmsg): Update.
 379
 380 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 381
 382         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 383         objfile_key.
 384         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 385         objfile to fetch per-bfd data.
 386         (arm_find_exidx_entry): Likewise.
 387
 388 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * gdbsupport/agent.c (debug_agent): Change type to bool.
 391         (use_agent): Likewise.
 392         (all_agent_symbols_look_up): Likewise.
 393         (agent_loaded_p): Change return value to bool.
 394         (agent_look_up_symbols): Update.
 395         (agent_capability_check): Change return value to bool.
 396         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 397         (debug_agent): Change type to bool.
 398         (use_agent): Likewise.
 399         (agent_capability_check): Change return value to bool.
 400
 401 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 404         (build_minimal_symbol_hash_tables): Code to clear the table moved
 405         to clear_minimal_symbol_hash_tables.
 406         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 407         when needed.
 408
 409 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 410
 411         * infcmd.c: Remove includes.
 412         * infrun.c: Remove includes.
 413
 414 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 415
 416         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 417         (grow_vect): Remove declaration.
 418         (ada_type_of_array): Remove declaration.
 419         (ada_update_initial_language): Remove declaration.
 420         (ada_fold_name): Remove declaration.
 421         (ada_fill_in_ada_prototype): Remove declaration.
 422         (user_select_syms): Remove declaration.
 423         (get_selections): Remove declaration.
 424         (ada_tag_type): Remove declaration.
 425         (ada_value_tag): Remove declaration.
 426         (ada_is_others_clause): Remove declaration.
 427         (ada_in_variant): Remove declaration.
 428         (ada_value_struct_elt): Remove declaration.
 429         (ada_attribute_name): Remove declaration.
 430         (ada_system_address_type): Remove declaration.
 431         * ada-lang.c (ada_watch_location_expression): Make static.
 432         (GROW_VECT): Move here from ada-lang.h.
 433         (grow_vect): Make static.
 434         (ada_update_initial_language): Make static.
 435         (ada_fold_name): Make static.
 436         (ada_type_of_array): Make static.
 437         (encoded_ordered_before): Move up.
 438         (sort_choices): Move up.
 439         (print_signatures): Move up.
 440         (ada_print_symbol_signature): Move up.
 441         (get_selections): Move up and make static.
 442         (user_select_syms): Move up and make static.
 443         (ada_value_struct_elt): Move up and make static.
 444         (ada_tag_type): Make static.
 445         (ada_value_tag): Make static.
 446         (ada_is_others_clause): Make static.
 447         (ada_in_variant): Make static.
 448         (ada_attribute_name): Make static.
 449
 450 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 451
 452         * ada-lang.c: Remove includes.
 453         * ada-typeprint.c: Remove includes.
 454         * ada-valprint.c: Remove includes.
 455
 456 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 457
 458         * addrmap.c: Add static assertions of type size, moved from
 459         _initialize_addrmap.
 460         (_initialize_addrmap): Remove.
 461
 462 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 463
 464         * coffread.c (record_minimal_symbol): Update.
 465         (process_coff_symbol): Update.
 466         * dbxread.c (read_dbx_symtab): Update.
 467         * dwarf2read.c (add_partial_symbol): Update.
 468         (fixup_go_packaging): Update.
 469         (load_partial_dies): Update.
 470         (new_symbol): Update.
 471         * elfread.c (record_minimal_symbol): Change signature to use
 472         gdb::string_view instead of name+len.
 473         (elf_symtab_read): Update.
 474         (elf_rel_plt_read): Update.
 475         * mdebugread.c (parse_partial_symbols): Update.
 476         (handle_psymbol_enumerators): Update.
 477         (new_symbol): Update.
 478         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 479         to use gdb::string_view instead of name+len.
 480         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 481         * psympriv.h (add_psymbol_to_list): Likewise.
 482         * psymtab.c (add_psymbol_to_bcache): Likewise.
 483         (add_psymbol_to_list): Likewise.
 484         * stabsread.c (define_symbol): Update.
 485         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 486         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 487         (symbol_set_names): Likewise.
 488         * xcoffread.c (scan_xcoff_symtab): Update.
 489
 490 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 491
 492         * symtab.h (symbol_set_names): Document that copy_name must be
 493         set to true for non-nullterminated strings.
 494         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 495         linkage_name if the entry was not found and we need to demangle.
 496
 497 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 498
 499         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 500         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 501         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 502         * gdbsupport/gdb_binary_search.h: New file.
 503
 504 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 505
 506         * NEWS: Mention new --with-system-gdbinit-dir option.
 507         * config.in: Regenerate.
 508         * configure: Regenerate.
 509         * configure.ac: Add new option --with-system-gdbinit-dir.
 510         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 511         for a ".gdb" suffix.
 512         * main.c (get_init_files): Change system_gdbinit argument to
 513         a vector and return the files in SYSTEM_GDBINIT_DIR in
 514         addition to SYSTEM_GDBINIT.
 515         (captured_main_1): Update.
 516         (print_gdb_help): Update.
 517         * top.c (print_gdb_configuration): Also print the value of
 518         SYSTEM_GDBINIT_DIR.
 519
 520 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 523         that takes gdb::string_view arguments.
 524
 525 2019-10-26  Tom de Vries  <tdevries@suse.de>
 526
 527         * aarch64-linux-tdep.c: Fix typos in comments.
 528         * aarch64-tdep.c: Same.
 529         * ada-lang.c: Same.
 530         * amd64-nat.c: Same.
 531         * arc-tdep.c: Same.
 532         * arch/aarch64-insn.c: Same.
 533         * block.c: Same.
 534         * breakpoint.h: Same.
 535         * btrace.h: Same.
 536         * c-varobj.c: Same.
 537         * cli/cli-decode.c: Same.
 538         * cli/cli-script.c: Same.
 539         * cli/cli-utils.h: Same.
 540         * coff-pe-read.c: Same.
 541         * coffread.c: Same.
 542         * compile/compile-cplus-symbols.c: Same.
 543         * compile/compile-object-run.c: Same.
 544         * completer.c: Same.
 545         * corelow.c: Same.
 546         * cp-support.c: Same.
 547         * demangle.c: Same.
 548         * dwarf-index-write.c: Same.
 549         * dwarf2-frame.c: Same.
 550         * dwarf2-frame.h: Same.
 551         * eval.c: Same.
 552         * frame-base.h: Same.
 553         * frame.h: Same.
 554         * gdbcmd.h: Same.
 555         * gdbtypes.h: Same.
 556         * gnu-nat.c: Same.
 557         * guile/scm-objfile.c: Same.
 558         * i386-tdep.c: Same.
 559         * i386-tdep.h: Same.
 560         * infcall.c: Same.
 561         * infcall.h: Same.
 562         * linux-nat.c: Same.
 563         * m68k-tdep.c: Same.
 564         * macroexp.c: Same.
 565         * memattr.c: Same.
 566         * mi/mi-cmd-disas.c: Same.
 567         * mi/mi-getopt.h: Same.
 568         * mi/mi-main.c: Same.
 569         * minsyms.c: Same.
 570         * nat/aarch64-sve-linux-sigcontext.h: Same.
 571         * objfiles.h: Same.
 572         * ppc-linux-nat.c: Same.
 573         * ppc-linux-tdep.c: Same.
 574         * ppc-tdep.h: Same.
 575         * progspace.h: Same.
 576         * prologue-value.h: Same.
 577         * python/py-evtregistry.c: Same.
 578         * python/py-instruction.h: Same.
 579         * record-btrace.c: Same.
 580         * record-full.c: Same.
 581         * remote.c: Same.
 582         * rs6000-tdep.c: Same.
 583         * ser-tcp.c: Same.
 584         * sol-thread.c: Same.
 585         * sparc-sol2-tdep.c: Same.
 586         * sparc64-tdep.c: Same.
 587         * stabsread.c: Same.
 588         * symfile.c: Same.
 589         * symtab.h: Same.
 590         * target.c: Same.
 591         * tracepoint.c: Same.
 592         * tui/tui-data.h: Same.
 593         * tui/tui-io.c: Same.
 594         * tui/tui-win.c: Same.
 595         * tui/tui.c: Same.
 596         * unittests/rsp-low-selftests.c: Same.
 597         * user-regs.h: Same.
 598         * utils.c: Same.
 599         * utils.h: Same.
 600         * valarith.c: Same.
 601         * valops.c: Same.
 602         * valprint.c: Same.
 603         * valprint.h: Same.
 604         * value.c: Same.
 605         * value.h: Same.
 606         * varobj.c: Same.
 607         * x86-nat.h: Same.
 608         * xtensa-tdep.c: Same.
 609
 610 2019-10-25  Ali Tamur <tamur@google.com>
 611
 612         * charset.c (find_charset_names): Reflect API change.
 613
 614 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 615
 616         * symtab.c (struct demangled_name_entry): Change demangled name
 617         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 618         part of the struct anymore.
 619         (symbol_set_names): No longer obstack allocate + copy the demangled
 620         name, just store the allocated name from bfd.
 621
 622 2019-10-25  Tom Tromey  <tromey@adacore.com>
 623
 624         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 625         (bsearch_cie_cmp, add_cie): Remove.
 626         (find_cie): Reimplement.
 627         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 628         (dwarf2_build_frame_info): Update.
 629
 630 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 631
 632         PR gdb/25126
 633         * symfile.c (reread_symbols): Call forget_cached_source_info to
 634         clear the stale source cache.
 635
 636 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 637
 638         * configure: Regenerate.
 639         * configure.ac: Remove code that sets python_has_threads.
 640
 641 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 642
 643         * config.in: Regenerate.
 644         * configure: Regenerate.
 645         * configure.ac: Remove the code that uses sed to get the python
 646         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 647
 648 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 649
 650         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 651         error paths.
 652
 653 2019-10-23  Tom Tromey  <tom@tromey.com>
 654
 655         * arc-tdep.c: Remove ".." from include.
 656         * frv-tdep.c: Remove ".." from include.
 657         * lm32-tdep.c: Remove ".." from include.
 658         * microblaze-tdep.c: Remove ".." from include.
 659         * or1k-tdep.h: Remove ".." from include.
 660         * s12z-tdep.c: Remove ".." from include.
 661         * Makefile.in (OPCODES_CFLAGS): Add comment.
 662         (TOP_CFLAGS): New variable.
 663         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 664
 665 2019-10-23  Tom Tromey  <tom@tromey.com>
 666
 667         * Makefile.in (READLINE_DIR): Update.
 668
 669 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 670
 671         * infcall.c (call_function_by_hand_dummy): Fix the function
 672         comment.  And extract out a code section into...
 673         (reserve_stack_space): ...this new function.
 674
 675 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 676
 677         * infcall.c (value_arg_coerce): Remove an unused parameter.
 678         (call_function_by_hand_dummy): Update the call to
 679         'value_arg_coerce'.
 680
 681 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 682
 683         * infcall.c (call_function_by_hand_dummy): Refactor.
 684
 685 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 686
 687         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 688
 689 2019-10-23  Tom Tromey  <tom@tromey.com>
 690
 691         * configure: Rebuild.
 692         * configure.ac: Don't check for sigprocmask.
 693         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 694
 695 2019-10-23  Tom Tromey  <tom@tromey.com>
 696
 697         * configure: Rebuild.
 698         * acinclude.m4: Use m4_include, not sinclude.
 699
 700 2019-10-23  Tom de Vries  <tdevries@suse.de>
 701
 702         PR breakpoints/24687
 703         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 704
 705 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 706
 707         * symtab.c (struct demangled_name_entry) <language>: Change from
 708         bitfield to regular variable.
 709
 710 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 711
 712         * symtab.c (struct demangled_name_entry): Add a constructor.
 713         (free_demangled_name_entry): New function to call the destructor
 714         for demangled_name_entry.
 715         (create_demangled_names_hash): Pass free_demangled_name_entry to
 716         htab_create_alloc.
 717         (symbol_set_names): Call placement new for demangled_name_entry.
 718         * utils.c: No longer include xxhash.h here, now that fast_hash
 719         is inlined in the header.
 720         * utils.h: Instead, include it here.
 721
 722 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 723
 724         * Makefile.in: Link with libxxhash.
 725         * config.in: Regenerate.
 726         * configure: Regenerate.
 727         * configure.ac: Search for libxxhash.
 728         * utils.c (fast_hash): Use xxhash if present.
 729
 730 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 731
 732         * utils.h (fast_hash): New function.
 733         * symtab.c (hash_demangled_name_entry): Call new function
 734         fast_hash.
 735
 736 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 737
 738         * symtab.c (struct demangled_name_entry): Change type of mangled
 739         to gdb::string_view. Also adds a constructor that takes the
 740         mangled name.
 741         (hash_demangled_name_entry): Update.
 742         (eq_demangled_name_entry): Update.
 743         (free_demangled_name_entry): New function to call the destructor
 744         now that this is not a POD anymore.
 745         (create_demangled_names_hash): Pass free_demangled_name_entry to
 746         htab_create_alloc.
 747         (symbol_set_names): Update.
 748
 749 2019-10-21  Ali Tamur  <tamu@google.com>
 750
 751         * dwarf2read.c (dir_index): Change type.
 752         (file_name_index): Likewise.
 753         (line_header::include_dir_at): Change comment and implementation on
 754         whether it is DWARF 5.
 755         (line_header::is_valid_file_index): New function.
 756         (line_header::file_name_at): Change comment and implementation on
 757         whether it is DWARF 5.
 758         (line_header::file_names): Change to private field renamed as
 759         m_file_names and introduce a new accessor method.
 760         (line_header::file_names_size): New method.
 761         (line_header::include_dirs): Change to private field and rename as
 762         m_include_dirs.
 763         (dw2_get_file_names_reader): Define local var at a smaller scope and
 764         reflect API change.
 765         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 766         (process_structure_scope): Likewise.
 767         (line_header::add_include_dir): Change message and reflect renaming.
 768         (line_header::add_file_name): Likewise.
 769         (read_formatted_entries): Handle DW_FORM_data16.
 770         (dwarf_decode_line_header): Fix line header length calculation.
 771         (psymtab_include_file_name): Change comment and API.
 772         (lnp_state_machine::m_file): Update comment and reflect type change.
 773         (lnp_state_machine::record_line): Reflect type change.
 774         (dwarf_decode_lines): Reflect API change.
 775         (file_file_name): Likewise.
 776         (file_full_name): Likewise.
 777
 778 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 781
 782 2019-10-21  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 785
 786 2019-10-21  Tom Tromey  <tom@tromey.com>
 787
 788         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 789         NM_H.   Use AC_CONFIG_LINKS.
 790         * configure: Rebuild.
 791         * Makefile.in (NM_H): New variable.
 792         (generated_files): Add NM_H.  Remove gcore.
 793         (nm.h, stamp-nmh): New targets.
 794
 795 2019-10-20  Tom Tromey  <tom@tromey.com>
 796
 797         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 798         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 799         obsolete comment.
 800         (put_objfile_before): Now static.
 801
 802 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 803
 804         * gdbsupport/common-utils.h (startswith): Change return type to
 805         bool.
 806
 807 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 808
 809         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 810         * breakpoint.c (bp_locations_compare): Rename to...
 811         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 812         (update_global_location_list): Use std::sort instead of qsort.
 813         * buildsym.c (compare_line_numbers): Rename to...
 814         (lte_is_less_than): ...this, and change to std::sort semantics.
 815         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 816         instead of qsort.
 817         * disasm.c (compare_lines): Rename to...
 818         (line_is_less_than): ...this, and change to std::sort semantics.
 819         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 820         of qsort.
 821         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 822         (fde_is_less_than): ...this, and change to std::sort semantics.
 823         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 824         * mdebugread.c (compare_blocks):
 825         (block_is_less_than): ...this, and change to std::sort semantics.
 826         (sort_blocks): Call std::sort instead of qsort.
 827         * objfiles.c (qsort_cmp): Rename to...
 828         (sort_cmp): ...this, and change to std::sort semantics.
 829         (update_section_map): Call std::sort instead of qsort.
 830         * remote.c (compare_pnums): Remove.
 831         (map_regcache_remote_table): Call std::sort instead of qsort.
 832         * utils.c (compare_positive_ints): Remove.
 833         * utils.h (compare_positive_ints): Remove.
 834         * xcoffread.c (compare_lte): Remove.
 835         (arrange_linetable): Call std::sort instead of qsort.
 836
 837 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 838
 839         * symfile.c (init_entry_point_info): Fix typo.
 840         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 841
 842 2019-10-18  Tom de Vries  <tdevries@suse.de>
 843
 844         * aarch64-tdep.c: Fix typos in comments.
 845         * ada-lang.c: Same.
 846         * ada-tasks.c: Same.
 847         * alpha-tdep.c: Same.
 848         * alpha-tdep.h: Same.
 849         * amd64-nat.c: Same.
 850         * amd64-windows-tdep.c: Same.
 851         * arc-tdep.c: Same.
 852         * arc-tdep.h: Same.
 853         * arch-utils.c: Same.
 854         * arm-nbsd-tdep.c: Same.
 855         * arm-tdep.c: Same.
 856         * ax-gdb.c: Same.
 857         * blockframe.c: Same.
 858         * btrace.c: Same.
 859         * c-varobj.c: Same.
 860         * coff-pe-read.c: Same.
 861         * coffread.c: Same.
 862         * cris-tdep.c: Same.
 863         * darwin-nat.c: Same.
 864         * dbxread.c: Same.
 865         * dcache.c: Same.
 866         * disasm.c: Same.
 867         * dtrace-probe.c: Same.
 868         * dwarf-index-write.c: Same.
 869         * dwarf2-frame-tailcall.c: Same.
 870         * dwarf2-frame.c: Same.
 871         * dwarf2read.c: Same.
 872         * eval.c: Same.
 873         * exceptions.c: Same.
 874         * fbsd-tdep.c: Same.
 875         * findvar.c: Same.
 876         * frame.c: Same.
 877         * frv-tdep.c: Same.
 878         * gnu-v3-abi.c: Same.
 879         * go32-nat.c: Same.
 880         * h8300-tdep.c: Same.
 881         * hppa-tdep.c: Same.
 882         * i386-linux-tdep.c: Same.
 883         * i386-tdep.c: Same.
 884         * ia64-libunwind-tdep.c: Same.
 885         * ia64-tdep.c: Same.
 886         * infcmd.c: Same.
 887         * infrun.c: Same.
 888         * linespec.c: Same.
 889         * linux-nat.c: Same.
 890         * linux-thread-db.c: Same.
 891         * machoread.c: Same.
 892         * mdebugread.c: Same.
 893         * mep-tdep.c: Same.
 894         * mn10300-tdep.c: Same.
 895         * namespace.c: Same.
 896         * objfiles.c: Same.
 897         * opencl-lang.c: Same.
 898         * or1k-tdep.c: Same.
 899         * osabi.c: Same.
 900         * ppc-linux-nat.c: Same.
 901         * ppc-linux-tdep.c: Same.
 902         * ppc-sysv-tdep.c: Same.
 903         * printcmd.c: Same.
 904         * procfs.c: Same.
 905         * record-btrace.c: Same.
 906         * record-full.c: Same.
 907         * remote-fileio.c: Same.
 908         * remote.c: Same.
 909         * rs6000-tdep.c: Same.
 910         * s12z-tdep.c: Same.
 911         * score-tdep.c: Same.
 912         * ser-base.c: Same.
 913         * ser-go32.c: Same.
 914         * skip.c: Same.
 915         * sol-thread.c: Same.
 916         * solib-svr4.c: Same.
 917         * solib.c: Same.
 918         * source.c: Same.
 919         * sparc-nat.c: Same.
 920         * sparc-sol2-tdep.c: Same.
 921         * sparc-tdep.c: Same.
 922         * sparc64-tdep.c: Same.
 923         * stabsread.c: Same.
 924         * stack.c: Same.
 925         * symfile.c: Same.
 926         * symtab.c: Same.
 927         * target-descriptions.c: Same.
 928         * target-float.c: Same.
 929         * thread.c: Same.
 930         * utils.c: Same.
 931         * valops.c: Same.
 932         * valprint.c: Same.
 933         * value.c: Same.
 934         * varobj.c: Same.
 935         * windows-nat.c: Same.
 936         * xcoffread.c: Same.
 937         * xstormy16-tdep.c: Same.
 938         * xtensa-tdep.c: Same.
 939
 940 2019-10-17  Tom Tromey  <tromey@adacore.com>
 941
 942         * configure: Rebuild.
 943         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 944         in AC_CONFIG_FILES invocation.
 945         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 946         new-style config.status invocation.
 947
 948 2019-10-17  Tom de Vries  <tdevries@suse.de>
 949
 950         * arm-nbsd-nat.c: Fix typos in comments.
 951         * arm-tdep.c: Same.
 952         * darwin-nat-info.c: Same.
 953         * dwarf2read.c: Same.
 954         * elfread.c: Same.
 955         * event-top.c: Same.
 956         * findvar.c: Same.
 957         * gdbtypes.c: Same.
 958         * hppa-tdep.c: Same.
 959         * i386-tdep.c: Same.
 960         * jit.c: Same.
 961         * main.c: Same.
 962         * mdebugread.c: Same.
 963         * moxie-tdep.c: Same.
 964         * nto-procfs.c: Same.
 965         * osabi.c: Same.
 966         * ppc-linux-tdep.c: Same.
 967         * remote.c: Same.
 968         * riscv-tdep.c: Same.
 969         * s390-tdep.c: Same.
 970         * sh-tdep.c: Same.
 971         * sparc-linux-tdep.c: Same.
 972         * sparc-nat.c: Same.
 973         * stack.c: Same.
 974         * target-descriptions.c: Same.
 975         * top.c: Same.
 976         * varobj.c: Same.
 977
 978 2019-10-16  Tom Tromey  <tom@tromey.com>
 979
 980         * objfiles.h (struct objfile) <original_name>: Now const.
 981
 982 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 983
 984         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 985         pass on to sigsetjmp's second argument.
 986         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 987
 988 2019-10-16  Keith Seitz  <keiths@redhat.com>
 989
 990         PR gdb/23567
 991         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 992         sections whose size is greater than the file size.
 993
 994 2019-10-16  Jim Wilson  <jimw@sifive.com>
 995
 996         * riscv-tdep.c (riscv_gcc_target_options): New.
 997         (riscv_gnu_triplet_regexp): New.
 998         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 999         set_gdbarch_gnu_triplet_regexp.
1000
1001 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1002
1003         * Makefile.in: Add xml-builtin.h.
1004         * features/feature_to_c.sh: Add an include for xml-builtin.h
1005         to ensure that the compiler checks that the types match.
1006         * xml-builtin.h: New file.
1007         * xml-support.c (fetch_xml_builtin): Add missing const.
1008         * xml-support.h: Remove declaration of xml_builtins.
1009
1010 2019-10-16  Tom de Vries  <tdevries@suse.de>
1011
1012         PR tdep/25096
1013         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1014         (amd64_classify_aggregate): ... here.
1015         (amd64_classify_aggregate_field): Handled fiels of nested structs
1016         recursively.
1017
1018 2019-10-16  Tom de Vries  <tdevries@suse.de>
1019
1020         PR tdep/24104
1021         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1022         that handles 'theclass'.
1023
1024 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * linespec.c (decode_digits_ordinary): Update comment.
1027         * make-target-delegates: No longer need to handle VEC case.
1028         * memrange.c (normalize_mem_ranges): Update comment.
1029         * namespace.c (add_using_directive): Update comment.
1030         * objc-lang.c (uniquify_strings): Update comment.
1031         * ppc-linux-nat.c (struct thread_points): Update comment.
1032         * probe.h (find_probes_in_objfile): Update comment.
1033         * target.h (enum flash_preserve_mode): Update comment.
1034         * varobj.c (varobj_restrict_range): Update comment.
1035         * varobj.h (varobj_list_children): Update comment.
1036
1037 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * Makefile.in: Remove references to vec.h and vec.c.
1040         * aarch64-tdep.c: No longer include vec.h.
1041         * ada-lang.c: Likewise.
1042         * ada-lang.h: Likewise.
1043         * arm-tdep.c: Likewise.
1044         * ax.h: Likewise.
1045         * breakpoint.h: Likewise.
1046         * charset.c: Likewise.
1047         * cp-support.h: Likewise.
1048         * dtrace-probe.c: Likewise.
1049         * dwarf2read.c: Likewise.
1050         * extension.h: Likewise.
1051         * gdb_bfd.c: Likewise.
1052         * gdbsupport/gdb_vecs.h: Likewise.
1053         * gdbsupport/vec.c: Remove.
1054         * gdbsupport/vec.h: Remove.
1055         * gdbthread.h: Likewise.
1056         * guile/scm-type.c: Likewise.
1057         * inline-frame.c: Likewise.
1058         * machoread.c: Likewise.
1059         * memattr.c: Likewise.
1060         * memrange.h: Likewise.
1061         * namespace.h: Likewise.
1062         * nat/linux-btrace.h: Likewise.
1063         * osdata.c: Likewise.
1064         * parser-defs.h: Likewise.
1065         * progspace.h: Likewise.
1066         * python/py-type.c: Likewise.
1067         * record-btrace.c: Likewise.
1068         * rust-exp.y: Likewise.
1069         * solib-target.c: Likewise.
1070         * stap-probe.c: Likewise.
1071         * target-descriptions.c: Likewise.
1072         * target-memory.c: Likewise.
1073         * target.h: Likewise.
1074         * varobj.c: Likewise.
1075         * varobj.h: Likewise.
1076         * xml-support.h: Likewise.
1077
1078 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1081         Update for new std::vector based implementation.
1082         (process_psymtab_comp_unit_reader): Likewise.
1083         (scan_partial_symbols): Likewise.
1084         (recursively_compute_inclusions): Likewise.
1085         (compute_compunit_symtab_includes): Likewise.
1086         (process_imported_unit_die): Likewise.
1087         (queue_and_load_dwo_tu): Likewise.
1088         (follow_die_sig_1): Likewise.
1089         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1090         (typedef dwarf2_per_cu_ptr): Remove.
1091         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1092         function.
1093         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1094         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1095         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1096         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1097         std::vector.
1098
1099 2019-10-15  Tom Tromey  <tromey@adacore.com>
1100
1101         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1102         TID.
1103
1104 2019-10-15  Tom Tromey  <tromey@adacore.com>
1105
1106         * windows-nat.c (windows_nat_target::fetch_registers)
1107         (windows_nat_target::store_registers): Rename "pid" to "tid".
1108
1109 2019-10-15  Tom Tromey  <tromey@adacore.com>
1110
1111         * gdbarch.h, gdbarch.c: Rebuild.
1112         * gdbarch.sh (gcc_target_options): Change return type to
1113         std::string.
1114         * compile/compile.c (get_args): Update.
1115         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1116         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1117         std::string.
1118         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1119         std::string.
1120         * arch-utils.c (default_gcc_target_options): Return std::string.
1121         * arch-utils.h (default_gcc_target_options): Return std::string.
1122         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1123
1124 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1125
1126         * breakpoint.c (breakpoint_chain): Make static.
1127         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1128         of accessing breakpoint_chain.
1129
1130 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1131
1132         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1133         to a gdb::function_view and return value to bool.
1134         * breakpoint.h (iterate_over_breakpoints): Likewise.
1135         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1136         (pop_dummy_frame): Update.
1137         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1138         (gdbscm_breakpoints): Update.
1139         * python/py-breakpoint.c (build_bp_list): Update.
1140         (gdbpy_breakpoints): Update.
1141         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1142         Update.
1143         (bpfinishpy_handle_stop): Update.
1144         (bpfinishpy_handle_exit): Update.
1145         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1146         (svr4_update_solib_event_breakpoints): Update.
1147
1148 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1149
1150         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1151         when unwrapping single-field structs.
1152
1153 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1154
1155         * dwarf2read.c: Remove includes.
1156
1157 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1158
1159         * ui-out.c (ui_out::call_do_message): Silence
1160         -Wformat-nonliteral warning.
1161
1162 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1163
1164         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1165         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1166         include: readline/tilde.h.
1167
1168 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * remote.c (remote_target::get_trace_status): Remove declaration of
1171         trace_regblock_size.
1172
1173 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1174
1175         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1176         (show_user): Remove declaration of cmdlist.
1177         * cli/cli-cmds.h (max_user_call_depth): Declare.
1178         * cli/cli-script.c (execute_user_command): Remove declaration
1179         of max_user_call_depth.
1180
1181 2019-10-11  Jim Wilson  <jimw@sifive.com>
1182
1183         * gdbsupport/print-utils.h (pulongest): Fix comment.
1184         (plongest): Likewise.
1185         (phex): Add missing comment, mention leading zeros.
1186         (phex_nz): Add mention of no leading zeros to comment.
1187
1188         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1189         plongest instead of unsigned long long cast.
1190
1191 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1194         for external_editor_command and gdbtk_test.
1195
1196 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1197
1198         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1199         * varobj.c (varobjdebug): Move comment to...
1200         * varobj.h (varobjdebug): ...here, and declare.
1201
1202 2019-10-09  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1205         erase_data_content.
1206
1207 2019-10-09  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1210         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1211         * tui/tui-command.c (tui_cmd_window::resize)
1212         (tui_refresh_cmd_win): Update.
1213         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1214         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1215         * tui/tui-data.c (~tui_gen_win_info): Remove.
1216         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1217         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1218         (tui_redisplay_readline, tui_mld_flush)
1219         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1220         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1221         (tui_data_window::erase_data_content)
1222         (tui_data_item_window::rerender)
1223         (tui_data_item_window::refresh_window): Update.
1224         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1225         (box_win, tui_gen_win_info::make_window)
1226         (tui_gen_win_info::make_visible): Update.
1227         (tui_delete_win): Remove.
1228         * tui/tui-winsource.c
1229         (tui_source_window_base::do_erase_source_content): Update.
1230         (tui_show_source_line, tui_source_window_base::update_tab_width)
1231         (tui_source_window_base::update_exec_info): Update.
1232         * tui/tui-data.h (struct curses_deleter): New.
1233         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1234         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1235
1236 2019-10-09  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1239
1240 2019-10-09  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1243         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1244
1245 2019-10-09  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1248         window height directly.
1249         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1250         declare.
1251         * tui/tui-layout.c (tui_default_win_height): Remove.
1252         (tui_default_win_viewport_height): Remove.
1253
1254 2019-10-09  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui.h: Remove comments.
1257
1258 2019-10-09  Tom de Vries  <tdevries@suse.de>
1259
1260         * python/lib/gdb/printer/bound_registers.py: Use
1261         '^builtin_type_bound128' as regexp argument for
1262         add_builtin_pretty_printer.
1263
1264 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1265
1266         * guile/guile.c (guile_extension_script_ops): Remove forward
1267         declaration and mark as static.
1268         (guile_script_ops): Likewise.
1269         (extension_language_guile): Move further down in the file so
1270         it can reference the definitions for guile_{extension_,}script_ops.
1271
1272 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1273
1274         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1275         except SORTL, DFLTCC, and KDSA.
1276
1277 2019-10-08  Tom Tromey  <tromey@adacore.com>
1278
1279         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1280         (struct safe_symbol_file_add_args): Remove.
1281
1282 2019-10-08  Tom Tromey  <tromey@adacore.com>
1283
1284         * windows-nat.c: Don't include buildsym-legacy.h.
1285
1286 2019-10-08  Tom Tromey  <tromey@adacore.com>
1287
1288         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1289
1290 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1291
1292         * gdbtypes.c (overload_debug): Move comment to header.
1293         * gdbtypes.h (overload_debug): Declare.
1294         * valops.c: Remove declaration of overload_debug, instead
1295         include gdbtypes.h.
1296
1297 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1298
1299         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1300         through _().
1301         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1302         move comment...
1303         * language.h (lang_frame_mismatch_warn): ... here. Also add
1304         declaration.
1305         * top.c (lang_frame_mismatch_warn): Remove declaration.
1306         (check_frame_language_change): Pass lang_frame_mismatch_warn
1307         through _().
1308
1309 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1310
1311         * c-lang.h (vtbl_ptr_name): Declare.
1312         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1313         it from the header.
1314         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1315
1316 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1317
1318         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1319         gdb_static_assert.
1320
1321 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1322
1323         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1324         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1325         * ctfread.c: New file.
1326         * ctfread.h: New file.
1327         * elfread.c: Include ctfread.h.
1328         (struct elfinfo text_p): New member ctfsect.
1329         (elf_locate_sections): Mark CTF section.
1330         (elf_symfile_read): Call elfctf_build_psymtabs.
1331         * Makefile.in (LIBCTF): Add.
1332         (CLIBS): Use it.
1333         (CDEPS): Likewise.
1334         (DIST): Add ctfread.c.
1335
1336 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * ctfread.c (struct nextfield): Renamed to ...
1339         (struct ctf_nextfield): ... this.
1340         (struct field_info): Renamed to ...
1341         (strut ctf_field_info): ... this.
1342         (attach_fields_to_type): Update for renamed structures.
1343         (ctf_add_member_cb): Likewise.
1344         (ctf_add_enum_member_cb): Likewise.
1345         (process_struct_members): Likewise.
1346         (process_enum_type): Likewise.
1347
1348 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1349
1350         * tracectf.h: Rename, was ctf.h.
1351         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1352         * tracefile.c: Likewise.
1353         * tracepoint.c: Remove unused include ctf.h.
1354         * mi/mi-main.c: Likewise.
1355         * Makefile.in Replace ctf.c with tracectf.c.
1356
1357 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1358
1359         * version.in: Change version number to "9.0.50.DATE-git".
1360
1361 2019-10-03  Tom Tromey  <tom@tromey.com>
1362
1363         PR rust/24976:
1364         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1365
1366 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1369         cp_search_name_hash.
1370         * NEWS: Add entry about nested function support.
1371
1372 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1373             Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1376         for nested static variables when searchin VAR_DOMAIN.
1377         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1378         global scope, update comment.
1379         (add_partial_subprogram): Call add_partial_subprogram recursively
1380         for nested subroutines when processinng Fortran.
1381         (load_partial_dies): Process the child entities of a subprogram
1382         when processing Fortran.
1383         (partial_die_parent_scope): Handle building scope
1384         for Fortran nested functions.
1385         (process_die): Record that nested functions have a scope.
1386         (new_symbol): Always record Fortran subprograms on the global
1387         symbol list.
1388         (determine_prefix): How to build the prefix for Fortran
1389         subprograms.
1390
1391 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1394         have just sent the thread a SIGSTOP and are waiting for it to
1395         arrive.
1396
1397 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * btrace.c (btrace_add_pc): Remove whitespace before the template
1400         parameter in 'std::vector <...>'.
1401         (parse_xml_btrace_block): Likewise.
1402         (btrace_maint_decode_pt): Likewise.
1403         (btrace_maint_update_packets): Likewise.
1404         (btrace_maint_print_packets): Likewise.
1405         * btrace.h (struct btrace_maint_info): Likewise.
1406         * dwarf2read.c (struct type_unit_group): Likewise.
1407         (build_type_psymtabs_reader): Likewise.
1408         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1409         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1410         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1411
1412 2019-10-03  Tom de Vries  <tdevries@suse.de>
1413
1414         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1415         the first line of the help text for set/show style metadata.
1416
1417 2019-10-02  Tom Tromey  <tromey@adacore.com>
1418
1419         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1420         * gdbsupport/common-inferior.c: New file.
1421         * infcmd.c (startup_with_shell): Don't define.
1422         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1423         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1424         * inferior.h (startup_with_shell): Don't declare.
1425
1426 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1427
1428         * gdbsupport/gdb_assert.h: Include errors.h.
1429         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1430
1431 2019-10-02  Tom Tromey  <tromey@adacore.com>
1432
1433         * NEWS: Add $_ada_exception entry.
1434         * ada-lang.c (struct ada_catchpoint): Add constructor.
1435         <m_kind>: New member.
1436         (allocate_location_exception, re_set_exception): Remove
1437         "ex" parameter.
1438         (should_stop_exception): Compute $_ada_exception.
1439         (check_status_exception, print_it_exception)
1440         (print_one_exception, print_mention_exception): Remove
1441         "ex" parameter.
1442         (allocate_location_catch_exception, re_set_catch_exception)
1443         (check_status_exception, print_it_catch_exception)
1444         (print_one_catch_exception, print_mention_catch_exception)
1445         (print_recreate_catch_exception)
1446         (allocate_location_catch_exception_unhandled)
1447         (re_set_catch_exception_unhandled)
1448         (check_status_exception, print_it_catch_exception_unhandled)
1449         (print_one_catch_exception_unhandled)
1450         (print_mention_catch_exception_unhandled)
1451         (print_recreate_catch_exception_unhandled)
1452         (allocate_location_catch_assert, re_set_catch_assert)
1453         (check_status_assert, print_it_catch_assert)
1454         (print_one_catch_assert, print_mention_catch_assert)
1455         (print_recreate_catch_assert)
1456         (allocate_location_catch_handlers, re_set_catch_handlers)
1457         (check_status_handlers, print_it_catch_handlers)
1458         (print_one_catch_handlers, print_mention_catch_handlers)
1459         (print_recreate_catch_handlers): Remove.
1460         (create_ada_exception_catchpoint): Update.
1461         (initialize_ada_catchpoint_ops): Update.
1462
1463 2019-10-02  Tom Tromey  <tromey@adacore.com>
1464
1465         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1466         (create_excep_cond_exprs): Simplify exception string computation.
1467         (ada_exception_catchpoint_cond_string): Likewise.
1468
1469 2019-10-02  Tom Tromey  <tromey@adacore.com>
1470
1471         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1472         * ada-lang.c (lesseq_defined_than): Handle
1473         LOC_STATIC.
1474         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1475         parameter.
1476         (dwarf2_has_info): Likewise.
1477         (new_symbol): Set maybe_copied on symbol when
1478         appropriate.
1479         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1480         parameter.
1481         <can_copy>: New member.
1482         * elfread.c (record_minimal_symbol): Set maybe_copied
1483         on symbol when appropriate.
1484         (elf_symfile_read): Update call to dwarf2_has_info.
1485         * minsyms.c (lookup_minimal_symbol_linkage): New
1486         function.
1487         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1488         * symtab.c (get_symbol_address, get_msymbol_address):
1489         New functions.
1490         * symtab.h (get_symbol_address, get_msymbol_address):
1491         Declare.
1492         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1493         maybe_copied.
1494         (struct symbol, struct minimal_symbol) <maybe_copied>:
1495         New member.
1496
1497 2019-10-02  Tom Tromey  <tromey@adacore.com>
1498
1499         * source.c (struct current_source_location): New.
1500         (current_source_key): New global.
1501         (current_source_symtab, current_source_line)
1502         (current_source_pspace): Remove.
1503         (get_source_location): New function.
1504         (get_current_source_symtab_and_line)
1505         (set_default_source_symtab_and_line)
1506         (set_current_source_symtab_and_line)
1507         (clear_current_source_symtab_and_line, select_source_symtab)
1508         (info_source_command, print_source_lines_base)
1509         (info_line_command, search_command_helper, _initialize_source):
1510         Update.
1511
1512 2019-10-02  Tom Tromey  <tromey@adacore.com>
1513
1514         * source.c (select_source_symtab): Don't call
1515         decode_line_with_current_source.
1516
1517 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * symtab.c (lookup_global_symbol): Search global block.
1520
1521 2019-10-02  Tom Tromey  <tromey@adacore.com>
1522
1523         * coffread.c (process_coff_symbol): Update.
1524         * dwarf2read.c (var_decode_location, new_symbol): Update.
1525         * mdebugread.c (parse_symbol): Update.
1526         * objfiles.c (relocate_one_symbol): Update.
1527         * stabsread.c (define_symbol, fix_common_block)
1528         (scan_file_globals): Update.
1529         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1530         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1531         * xcoffread.c (process_xcoff_symbol): Update.
1532
1533 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1534
1535         * MAINTAINERS: Update my email address.
1536
1537 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1540         std::vector.
1541         (build_type_psymtabs_reader): Update for std::vector.
1542         (build_type_psymtab_dependencies): Likewise.
1543         * dwarf2read.h: Remove use of DEF_VEC_P.
1544         (typedef sig_type_ptr): Delete.
1545
1546 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1547
1548         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1549         to std::vector.
1550         (btrace_maint_decode_pt): Likewise, and move allocation of the
1551         vector outside of the loop.
1552         (btrace_maint_update_packets): Update to handle change from VEC to
1553         std::vector.
1554         (btrace_maint_print_packets): Likewise.
1555         (maint_info_btrace_cmd): Likewise.
1556         * btrace.h: Remove use of DEF_VEC_O.
1557         (typedef btrace_pt_packet_s): Delete.
1558         (struct btrace_maint_info) <packets>: Change fromm VEC to
1559         std::vector.
1560         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1561
1562 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1565         make accesses into the vector constant references.
1566         (btrace_add_pc): Update for std::vector.
1567         (btrace_stitch_bts): Likewise.
1568         (parse_xml_btrace_block): Likewise.
1569         (btrace_maint_update_packets): Likewise.
1570         (btrace_maint_print_packets): Likewise.
1571         (maint_info_btrace_cmd): Likewise.
1572         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1573         std::vector.
1574         (btrace_data::empty): Likewise.
1575         (btrace_data_append): Likewise.
1576         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1577         (typedef btrace_block_s): Delete.
1578         (struct btrace_block): Add constructor.
1579         (struct btrace_data_bts) <blocks>: Change to std::vector.
1580         * nat/linux-btrace.c (perf_event_read_bts): Update for
1581         std::vector.
1582         (linux_read_bts): Likewise.
1583
1584 2019-10-01  Tom Tromey  <tom@tromey.com>
1585
1586         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1587
1588 2019-10-01  Tom Tromey  <tom@tromey.com>
1589
1590         * stack.c (print_frame, info_frame_command_core): Use
1591         styled_string.
1592         * linux-thread-db.c (try_thread_db_load_1)
1593         (try_thread_db_load_from_pdir_1): Use styled_string.
1594         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1595         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1596         (maybe_print_unsupported_script_warning)
1597         (maybe_print_script_not_found_warning): Use styled_string.
1598         * ada-lang.c (user_select_syms): Use styled_string.
1599
1600 2019-10-01  Tom Tromey  <tom@tromey.com>
1601
1602         * p-lang.c (pascal_printstr): Use metadata style.
1603         * value.c (show_convenience): Use metadata style.
1604         * valprint.c (valprint_check_validity, val_print_optimized_out)
1605         (val_print_not_saved, val_print_unavailable)
1606         (val_print_invalid_address, generic_val_print, val_print)
1607         (value_check_printable, val_print_array_elements): Use metadata
1608         style.
1609         * ui-out.h (class ui_out) <field_fmt>: New overload.
1610         <do_field_fmt>: Add style parameter.
1611         * ui-out.c (ui_out::field_fmt): New overload.
1612         * typeprint.c (type_print_unknown_return_type)
1613         (val_print_not_allocated, val_print_not_associated): Use metadata
1614         style.
1615         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1616         parameter.
1617         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1618         * tracepoint.c (tvariables_info_1): Use metadata style.
1619         * stack.c (print_frame_arg, print_frame_info, print_frame)
1620         (info_frame_command_core): Use metadata style.
1621         * skip.c (info_skip_command): Use metadata style.
1622         * rust-lang.c (rust_print_enum): Use metadata style.
1623         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1624         metadata style.
1625         * python/py-framefilter.c (py_print_single_arg): Use metadata
1626         style.
1627         * printcmd.c (do_one_display, print_variable_and_value): Use
1628         metadata style.
1629         * p-valprint.c (pascal_val_print)
1630         (pascal_object_print_value_fields): Use metadata style.
1631         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1632         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1633         parameter.
1634         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1635         * m2-valprint.c (m2_print_long_set): Use metadata style.
1636         * m2-typeprint.c (m2_print_type): Use metadata style.
1637         * infcmd.c (print_return_value_1): Use metadata style.
1638         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1639         * f-valprint.c (info_common_command_for_block): Use metadata
1640         style.
1641         * f-typeprint.c (f_type_print_base): Use metadata style.
1642         * expprint.c (print_subexp_standard): Use metadata style.
1643         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1644         * cli/cli-style.h (class cli_style_option): Add constructor.
1645         (metadata_style): Declare.
1646         * cli/cli-style.c (metadata_style): New global.
1647         (_initialize_cli_style): Register metadata style.
1648         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1649         parameter.
1650         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1651         * c-typeprint.c (c_type_print_base_struct_union)
1652         (c_type_print_base_1): Use metadata style.
1653         * breakpoint.c (watchpoint_value_print)
1654         (print_one_breakpoint_location): Use metadata style.
1655         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1656         style.
1657         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1658         style.
1659         * ada-valprint.c (val_print_packed_array_elements, printstr)
1660         (print_field_values, ada_val_print_ref, ada_val_print): Use
1661         metadata style.
1662         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1663         style.
1664         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1665         style.
1666         * ada-lang.c (user_select_syms): Use metadata style.
1667
1668 2019-10-01  Tom Tromey  <tom@tromey.com>
1669
1670         * cli/cli-cmds.c (pwd_command): Style output.
1671
1672 2019-10-01  Pedro Alves  <palves@redhat.com>
1673             Tom Tromey  <tom@tromey.com>
1674
1675         * symtab.c (print_symbol_info): Use %ps.
1676         (print_msymbol_info): Use %ps.
1677         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1678         * printcmd.c (print_variable_and_value): Use %ps.
1679         * macrocmd.c (show_pp_source_pos): Use %ps.
1680         * infrun.c (print_exited_reason): Use ui_out::message.
1681         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1682         (describe_other_breakpoints): Use ui_out::message and new
1683         formats.
1684         (say_where): Use new formats.
1685         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1686         and new formats.
1687
1688 2019-10-01  Pedro Alves  <palves@redhat.com>
1689             Tom Tromey  <tom@tromey.com>
1690
1691         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1692         (test_gdb_formats): New function.
1693         (run_tests): Call it.
1694         (test_format_specifier): Update.
1695         * utils.h (fputs_filtered): Update comment.
1696         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1697         (fputs_styled_unfiltered): Declare.
1698         * utils.c (fputs_styled_unfiltered): New function.
1699         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1700         (vfprintf_filtered): Update.
1701         (vfprintf_unfiltered, vprintf_filtered): Update.
1702         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1703         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1704         disallow_ui_out_field>: New constants.
1705         (enum class field_kind): New.
1706         (struct base_field_s, struct signed_field_s): New.
1707         (signed_field): New function.
1708         (struct string_field_s): New.
1709         (string_field): New function.
1710         (struct styled_string_s): New.
1711         (styled_string): New function.
1712         (class ui_out) <message>: Add comment.
1713         <vmessage, call_do_message>: New methods.
1714         <do_message>: Add style parameter.
1715         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1716         methods.
1717         (ui_out::message): Rewrite.
1718         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1719         parameter.
1720         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1721         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1722         gdb_extensions parameter.
1723         (class format_piece): Add parameter to constructor.
1724         (n_int_args): New field.
1725         * gdbsupport/format.c (format_pieces::format_pieces): Add
1726         gdb_extensions parameter.  Handle '*'.
1727         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1728         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1729         vfprintf_styled_no_gdbfmt.
1730         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1731         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1732         unfiltered output.
1733         * ui-style.h (struct ui_file_style) <ptr>: New method.
1734
1735 2019-10-01  Tom Tromey  <tom@tromey.com>
1736
1737         * unittests/format_pieces-selftests.c: Update.  Add final format.
1738         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1739         empty literal pieces.
1740
1741 2019-10-01  Tom Tromey  <tom@tromey.com>
1742
1743         * ui-out.h (enum class ui_out_style_kind): Remove.
1744         (class ui_out) <field_string, field_stsream, do_field_string>:
1745         Change type of "style".
1746         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1747         (ui_out::field_string): Update.
1748         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1749         of "style".
1750         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1751         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1752         * stack.c (print_frame_arg, print_frame_info, print_frame):
1753         Update.
1754         * source.c (print_source_lines_base): Update.
1755         * solib.c (info_sharedlibrary_command): Update.
1756         * skip.c (info_skip_command): Update.
1757         * record-btrace.c (btrace_call_history_src_line)
1758         (btrace_call_history): Update.
1759         * python/py-framefilter.c (py_print_frame): Update.
1760         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1761         "style".
1762         * mi/mi-out.c (mi_ui_out::do_table_header)
1763         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1764         (mi_ui_out::do_field_string): Update.
1765         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1766         Update.
1767         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1768         "style".
1769         * cli-out.c (cli_ui_out::do_table_header)
1770         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1771         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1772         (cli_ui_out::do_field_fmt): Update.
1773         * breakpoint.c (print_breakpoint_location): Update.
1774         (update_static_tracepoint): Update.
1775
1776 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1777
1778         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1779         conversion of gdb_datadir.
1780         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1781         remove not needed c_str ().
1782
1783 2019-09-30  Ali Tamur <tamur@google.com>
1784
1785         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1786         (dwarf2_string_attr): Likewise.
1787
1788 2019-09-30  Ali Tamur <tamur@google.com>
1789
1790         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1791         (process_full_type_unit): Likewise.
1792         (dump_die_shallow): Likewise.
1793         (cu_debug_loc_section): Likewise.
1794
1795 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1796
1797         * minsyms.c (compare_minimal_symbols): Rename to...
1798         (minimal_symbol_is_less_than): ...this, and adjust to STL
1799         conventions (return bool, take arguments as references)
1800         (minimal_symbol_reader::install): Call std::sort instead
1801         of qsort.
1802
1803 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1804
1805         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1806         hash and why.
1807         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1808         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1809
1810 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1811
1812         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1813         * psympriv.h (add_psymbol_to_list): Move comment here and update
1814         it.
1815
1816 2019-09-29  Tom de Vries  <tdevries@suse.de>
1817
1818         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1819         Use $tmpdir/$(basename "$output_file").dwz instead of
1820         "${output_file}.dwz".
1821
1822 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1823
1824         PR gdb/25045
1825         * hppa-linux-nat.c: Include gdbarch.h.
1826
1827 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1828
1829         * blockframe.c (find_pc_partial_function): Change return type to bool.
1830         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1831         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1832         (stub_gnu_ifunc_resolve_name): Likewise.
1833         * symtab.c (compare_filenames_for_search): Likewise.
1834         (compare_glob_filenames_for_search): Likewise.
1835         (matching_obj_sections): Likewise.
1836         (symbol_matches_domain): Likewise.
1837         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1838         (find_line_pc): Change return type to bool.
1839         (find_line_pc_range): Likewise.
1840         (producer_is_realview): Likewise.
1841         * symtab.h (symbol_matches_domain): Likewise.
1842         (find_pc_partial_function): Likewise.
1843         (find_pc_line_pc_range): Likewise.
1844         (in_gnu_ifunc_stub): Likewise.
1845         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1846         (find_line_pc): Likewise.
1847         (find_line_pc_range): Likewise.
1848         (matching_obj_sections): Likewise.
1849         (find_line_symtab): Change out parameter to bool.
1850         (producer_is_realview): Change return type to bool.
1851         (compare_filenames_for_search): Likewise.
1852         (compare_glob_filenames_for_search): Likewise.
1853
1854 2019-09-26  Tom Tromey  <tom@tromey.com>
1855
1856         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1857         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1858         * gdb_usleep.h: Remove.
1859         * gdb_usleep.c: Remove.
1860         * utils.c: Don't include gdb_usleep.h.
1861
1862 2019-09-26  Tom Tromey  <tromey@adacore.com>
1863
1864         * python/py-type.c (type_to_type_object): Call check_typedef
1865         for stub types.
1866
1867 2019-09-26  Tom Tromey  <tom@tromey.com>
1868
1869         * utils.h (initialize_utils): Don't declare.
1870         * top.c (gdb_init): Don't call initialize_utils.
1871         * utils.c (initialize_utils): Remove.  Move contents...
1872         (_initialize_utils): ... here.
1873
1874 2019-09-25  Tom Tromey  <tom@tromey.com>
1875
1876         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1877         * utils.h (make_hex_string): Don't declare.
1878         * utils.c (make_hex_string): Remove.
1879
1880 2019-09-24  Tom de Vries  <tdevries@suse.de>
1881
1882         PR gdb/23815
1883         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1884         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1885
1886 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1887
1888         * NEWS: Mention new simulator port for PRU.
1889
1890 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1891
1892         * ada-exp.y (write_object_remaining): Update.
1893         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1894         and eliminate the static buffer.
1895         (ada_decode_symbol): Update.
1896         (ada_la_decode): Update.
1897         (ada_sniff_from_mangled_name): Update.
1898         (is_valid_name_for_wild_match): Update.
1899         (ada_lookup_name_info::matches): Update and simplify.
1900         (name_matches_regex): Update.
1901         (ada_add_global_exceptions): Update.
1902         * ada-lang.h (ada_decode): Update signature.
1903         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1904         * dwarf-index-write.c (debug_names::insert): Update.
1905
1906 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1907
1908         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1909         formatting.
1910
1911 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1912
1913         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1914         Change "nonzero" to "true" in documentation.
1915
1916 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1917
1918         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1919         (_initialize_darwin_solib): Don't set
1920         darwin_so_ops.lookup_lib_global_symbol.
1921         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1922         set_gdbarch_iterate_over_objfiles_in_search_order.
1923         (elf_lookup_lib_symbol): Rename to...
1924         (svr4_iterate_over_objfiles_in_search_order): this, and update
1925         to iterate semantics.
1926         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1927         * solib.c (solib_global_lookup): Remove.
1928         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1929         (solib_global_lookup): Remove.
1930         * symtab.c (lookup_global_or_static_symbol): Remove call to
1931         solib_global_lookup.
1932
1933 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1934
1935         * NEWS: Move entries about default MI version now being
1936         version 3, and about the GDB/MI fix for multi-location
1937         breakpoints to the "since GDB 8.3" section.
1938
1939 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1940
1941         GDB 8.3.1 released.
1942
1943 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1944
1945         * NEWS: Mention that Cell/B.E. debugging support was removed.
1946         * MAINTAINERS: Remove spu target.
1947
1948         * config/djgpp/fnchange.lst: Remove entries for removed files.
1949
1950         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1951         spu-multiarch.o, and spu-tdep.o.
1952         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1953         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1954         spu-multiarch.c, and spu-tdep.c.
1955         * spu-linux-nat.c: Remove file.
1956         * spu-multiarch.c: Remove file.
1957         * spu-tdep.c: Remove file.
1958         * spu-tdep.h: Remove file.
1959         * solib-spu.c: Remove file.
1960         * solib-spu.h: Remove file.
1961
1962         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1963         * configure.nat (spu-linux): Remove.
1964         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1965         solib-multiarch.o from gdb_target_obs.
1966         (spu*-*-*): Remove.
1967
1968         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1969         feature flag.
1970         (ppc_linux_no_features): Update.
1971         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1972         Cell/B.E. support.
1973         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1974         (tdesc_powerpc_cell64l): Likewise.
1975         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1976         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1977         Cell/B.E. support.
1978         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1979         Do not include "features/rs6000/powerpc-cell32l.c" or
1980         "features/rs6000/powerpc-cell64l.c".
1981         (ppc_linux_spu_section): Remove.
1982         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1983         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1984         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1985         (ppc_linux_spe_context_lookup): Remove.
1986         (ppc_linux_spe_context_inferior_created): Remove.
1987         (ppc_linux_spe_context_solib_loaded): Remove.
1988         (ppc_linux_spe_context_solib_unloaded): Remove.
1989         (ppc_linux_spe_context): Remove.
1990         (struct ppu2spu_cache): Remove.
1991         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1992         (struct ppu2spu_data): Remove.
1993         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1994         ppu2spu_unwind): Remove.
1995         (ppc_linux_init_abi): Remove Cell/B.E. support.
1996         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1997
1998         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1999         (rs6000/powerpc-cell64l-expedite): Likewise
2000         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2001         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2002         rs6000/powerpc-cell64l.xml.
2003         * features/rs6000/powerpc-cell32l.xml: Remove.
2004         * features/rs6000/powerpc-cell64l.xml: Likewise.
2005         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2006         * features/rs6000/powerpc-cell64l.c: Likewise.
2007         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2008         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2009         * regformats/reg-spu.dat: Remove.
2010
2011         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2012         * corelow.c (struct spuid_list): Remove.
2013         (add_to_spuid_list): Remove.
2014         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2015         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2016         (remote_protocol_features): Remove associated entries.
2017         (_initialize_remote): No longer initialize them.
2018         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2019         * linux-nat.c (SPUFS_MAGIC): Remove.
2020         (linux_proc_xfer_spu): Remove.
2021         (spu_enumerate_spu_ids): Remove.
2022         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2023         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2024         (linux_make_corefile_notes): No longer call it.
2025
2026         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2027         (cooked_write_test): Likewise.
2028
2029 2019-09-20  Tom Tromey  <tom@tromey.com>
2030
2031         * NEWS: Mention case-sensitivity of TUI commands.
2032         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2033         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2034         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2035
2036 2019-09-20  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-source.c (tui_source_window::set_contents): Use
2039         make_unique_xstrdup.
2040         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2041         make_unique_xstrdup.
2042
2043 2019-09-20  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-data.c: Remove separator comments.
2046         * tui/tui-layout.c: Remove separator comments.
2047         * tui/tui-win.c: Remove separator comments.
2048         * tui/tui-wingeneral.c: Remove separator comments.
2049
2050 2019-09-20  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui.h (strcat_to_buf): Don't declare.
2053         * tui/tui.c (strcat_to_buf): Remove.
2054
2055 2019-09-20  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2058         from "fullname".
2059         * tui/tui-source.c (tui_source_window::set_contents)
2060         (tui_source_window::location_matches_p)
2061         (tui_source_window::maybe_update): Update.
2062
2063 2019-09-20  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2066         Update.
2067         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2068         prefix.
2069         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2070         (tui_data_window::line_from_reg_element_no)
2071         (tui_data_window::first_reg_element_no_inline)
2072         (tui_data_window::show_registers)
2073         (tui_data_window::show_register_group)
2074         (tui_data_window::display_registers_from)
2075         (tui_data_window::display_registers_from_line)
2076         (tui_data_window::first_data_item_displayed)
2077         (tui_data_window::delete_data_content_windows)
2078         (tui_data_window::erase_data_content)
2079         (tui_data_window::do_scroll_vertical)
2080         (tui_data_window::refresh_window)
2081         (tui_data_window::check_register_values): Update.
2082
2083 2019-09-20  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2086         (struct tui_locator_window) <full_name, proc_name>: Now
2087         std::string.
2088         * tui/tui-stack.c (tui_locator_window::make_status_line)
2089         (tui_locator_window::set_locator_fullname)
2090         (tui_locator_window::set_locator_info): Update.
2091         * tui/tui-source.c (tui_source_window::set_contents)
2092         (tui_source_window::showing_source_p): Update.
2093
2094 2019-09-20  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2097         Don't call tui_locator_win_info_ptr.
2098
2099 2019-09-20  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2102
2103 2019-09-20  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2106         height for locator.
2107         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2108         * tui/tui-layout.c (show_source_disasm_command, show_data)
2109         (show_source_or_disasm_and_command): Use 1 as height for locator.
2110
2111 2019-09-20  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui.c (tui_enable): Update.
2114         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2115         Update.
2116         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2117         Update.
2118         * tui/tui-data.c (win_resized): Now bool.
2119         (tui_win_resized): Return bool.
2120         (tui_set_win_resized_to): Accept a bool.
2121
2122 2019-09-20  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2125         Change type of "refresh_values_only".
2126         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2127         type of "refresh_values_only".
2128
2129 2019-09-20  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2132         std::string.
2133         (tui_disassemble): Add "pos" parameter.
2134         (tui_disasm_window::set_contents): Simplify.
2135
2136 2019-09-20  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-winsource.h (struct tui_source_window_base)
2139         <show_source_content>: Now private.
2140         * tui/tui-winsource.c
2141         (tui_source_window_base::show_source_content): Don't handle empty
2142         content case.
2143
2144 2019-09-20  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-layout.c (show_source_disasm_command)
2147         (show_source_or_disasm_and_command): Don't call
2148         show_source_content.
2149
2150 2019-09-20  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2153         Declare.
2154         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2155         from tui_make_status_line.
2156         (tui_locator_window::rerender): Update.
2157
2158 2019-09-20  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2161         (tui_locator_window::rerender): Update.
2162
2163 2019-09-20  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-winsource.h (struct tui_source_window_base)
2166         <~tui_source_window_base>: Don't declare.
2167         <fullname>: Remove.
2168         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2169         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2170         member.
2171         * tui/tui-source.c (tui_source_window::set_contents): Update.
2172         (tui_source_window::location_matches_p)
2173         (tui_source_window::maybe_update): Update.
2174
2175 2019-09-20  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (~tui_source_element): Remove.
2178         (tui_source_element): Update.
2179         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2180         * tui/tui-winsource.c (tui_show_source_line): Update.
2181         * tui/tui-source.c (tui_source_window::set_contents): Update.
2182         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2183
2184 2019-09-20  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2187         declare.
2188         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2189         tui_clear_source_windows_detail.
2190         * tui/tui-winsource.h (struct tui_source_window_base)
2191         <clear_detail>: Don't declare.
2192         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2193         Remove.
2194         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2195
2196 2019-09-20  Tom Tromey  <tromey@adacore.com>
2197
2198         PR ada/24919:
2199         * block.c (contained_in): Fix final return value.
2200
2201 2019-09-20  Alan Modra  <amodra@gmail.com>
2202
2203         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2204         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2205         (read_indirect_string_from_dwz): Use bfd accessor.
2206         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2207         * machoread.c (macho_symfile_read_all_oso): Likewise.
2208         * solib.c (solib_bfd_open): Likewise.
2209
2210 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * eval.c: Move declaration of overload_resolution to...
2213         * value.h: ...here.
2214
2215 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2216
2217         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2218         * arm-linux-tdep.c: Likewise.
2219         * arm-nbsd-nat.c: Likewise.
2220         * arm-tdep.h: Declare arm_apcs_32.
2221         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2222
2223 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2224
2225         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2226         * dwarf2read.h: Declare dwarf_always_disassemble.
2227
2228 2019-09-19  Tom de Vries  <tdevries@suse.de>
2229
2230         PR gdb/25009
2231         * source-cache.c (source_cache::ensure): Catch exception thrown during
2232         construction of the highlighter.
2233
2234 2019-09-18  Alan Modra  <amodra@gmail.com>
2235
2236         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2237         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2238         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2239         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2240         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2241         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2242         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2243         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2244         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2245         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2246         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2247         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2248         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2249         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2250         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2251         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2252         * mi/mi-interp.c: Update throughout for bfd section macro and
2253         function changes.
2254         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2255         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2256
2257 2019-09-18  Tom Tromey  <tom@tromey.com>
2258
2259         * NEWS: Add entry.
2260         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2261         call rl_initialize.
2262         (tui_enable): Do not call rl_initialize.
2263
2264 2019-09-18  Christian Groessler  <chris@groessler.org>
2265
2266         * alpha-linux-nat.c: Include gdbarch.h.
2267
2268 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2269
2270         * ui-file.c: Include cli/cli-style.h.
2271         (term_cli_styling): Remove cli_styling declaration.
2272
2273 2019-09-18  Alan Modra  <amodra@gmail.com>
2274
2275         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2276         to bfd_asymbol_section.
2277
2278 2019-09-18  Alan Modra  <amodra@gmail.com>
2279
2280         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2281         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2282         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2283
2284 2019-09-18  Alan Modra  <amodra@gmail.com>
2285
2286         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2287         * spu-linux-nat.c (spu_bfd_open): Likewise.
2288
2289 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2290
2291         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2292         to bool to match definition in dwarf2read.c.
2293
2294 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2297         (print_signatures): Likewise.
2298         (trust_pad_over_xvs): Likewise.
2299         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2300         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2301         * arm-linux-nat.c (arm_apcs_32): Likewise.
2302         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2303         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2304         * arm-tdep.c (arm_debug): Likewise.
2305         (arm_apcs_32): Likewise.
2306         * auto-load.c (debug_auto_load): Likewise.
2307         (auto_load_gdb_scripts): Likewise.
2308         (global_auto_load): Likewise.
2309         (auto_load_local_gdbinit): Likewise.
2310         (auto_load_local_gdbinit_loaded): Likewise.
2311         * auto-load.h (global_auto_load): Likewise.
2312         (auto_load_local_gdbinit): Likewise.
2313         (auto_load_local_gdbinit_loaded): Likewise.
2314         * breakpoint.c (disconnected_dprintf): Likewise.
2315         (breakpoint_proceeded): Likewise.
2316         (automatic_hardware_breakpoints): Likewise.
2317         (always_inserted_mode): Likewise.
2318         (target_exact_watchpoints): Likewise.
2319         (_initialize_breakpoint): Update.
2320         * breakpoint.h (target_exact_watchpoints): Change to bool.
2321         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2322         * cli/cli-cmds.c (trace_commands): Likewise.
2323         * cli/cli-cmds.h (trace_commands): Likewise.
2324         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2325         to bool*.
2326         * cli/cli-logging.c (logging_overwrite): Change to bool.
2327         (logging_redirect): Likewise.
2328         (debug_redirect): Likewise.
2329         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2330         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2331         to bool.
2332         <boolean_option_def>: Update.
2333         (struct flag_option_def): Change default type of Context to bool
2334         from int.
2335         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2336         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2337         (get_setshow_command_value_string): Likewise.
2338         * cli/cli-style.c (cli_styling): Change to bool.
2339         (source_styling): Likewise.
2340         * cli/cli-style.h (source_styling): Likewise.
2341         (cli_styling): Likewise.
2342         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2343         to bool.
2344         * command.h (var_types): Update comment.
2345         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2346         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2347         bool.
2348         (debug_compile_cplus_scopes): Likewise.
2349         * compile/compile-internal.h (compile_debug): Likewise.
2350         * compile/compile.c (compile_debug): Likewise.
2351         (struct compile_options) <raw>: Likewise.
2352         * cp-support.c (catch_demangler_crashes): Likewise.
2353         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2354         (usr_cmd_cris_dwarf2_cfi): Likewise.
2355         * csky-tdep.c (csky_debug): Likewise.
2356         * darwin-nat.c (enable_mach_exceptions): Likewise.
2357         * dcache.c (dcache_enabled_p): Likewise.
2358         * defs.h (info_verbose): Likewise.
2359         * demangle.c (demangle): Likewise.
2360         (asm_demangle): Likewise.
2361         * dwarf-index-cache.c (debug_index_cache): Likewise.
2362         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2363         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2364         * dwarf2read.c (check_physname): Likewise.
2365         (use_deprecated_index_sections): Likewise.
2366         (dwarf_always_disassemble): Likewise.
2367         * eval.c (overload_resolution): Likewise.
2368         * event-top.c (set_editing_cmd_var): Likewise.
2369         (exec_done_display_p): Likewise.
2370         * event-top.h (set_editing_cmd_var): Likewise.
2371         (exec_done_display_p): Likewise.
2372         * exec.c (write_files): Likewise.
2373         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2374         (debug_fbsd_nat): Likewise.
2375         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2376         Likewise.
2377         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2378         <backtrace_past_entry> Likewise.
2379         * gdb-demangle.h (demangle): Likewise.
2380         (asm_demangle): Likewise.
2381         * gdb_bfd.c (bfd_sharing): Likewise.
2382         * gdbcore.h (write_files): Likewise.
2383         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2384         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2385         * gdbthread.h (print_thread_events): Likewise.
2386         * gdbtypes.c (opaque_type_resolution): Likewise.
2387         (strict_type_checking): Likewise.
2388         * gnu-nat.c (gnu_debug_flag): Likewise.
2389         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2390         * guile/scm-param.c (pascm_variable): Add boolval.
2391         (add_setshow_generic): Update.
2392         (pascm_param_value): Update.
2393         (pascm_set_param_value_x): Update.
2394         * hppa-tdep.c (hppa_debug): Change to bool..
2395         * infcall.c (may_call_functions_p): Likewise.
2396         (coerce_float_to_double_p): Likewise.
2397         (unwind_on_signal_p): Likewise.
2398         (unwind_on_terminating_exception_p): Likewise.
2399         * infcmd.c (startup_with_shell): Likewise.
2400         * inferior.c (print_inferior_events): Likewise.
2401         * inferior.h (startup_with_shell): Likewise.
2402         (print_inferior_events): Likewise.
2403         * infrun.c (step_stop_if_no_debug): Likewise.
2404         (detach_fork): Likewise.
2405         (debug_displaced): Likewise.
2406         (disable_randomization): Likewise.
2407         (non_stop): Likewise.
2408         (non_stop_1): Likewise.
2409         (observer_mode): Likewise.
2410         (observer_mode_1): Likewise.
2411         (set_observer_mode): Update.
2412         (sched_multi): Change to bool.
2413         * infrun.h (debug_displaced): Likewise.
2414         (sched_multi): Likewise.
2415         (step_stop_if_no_debug): Likewise.
2416         (non_stop): Likewise.
2417         (disable_randomization): Likewise.
2418         * linux-tdep.c (use_coredump_filter): Likewise.
2419         (dump_excluded_mappings): Likewise.
2420         * linux-thread-db.c (auto_load_thread_db): Likewise.
2421         (check_thread_db_on_load): Likewise.
2422         * main.c (captured_main_1): Update.
2423         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2424         xx2_opt, boolean_opt>: Change to bool.
2425         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2426         * maint.c (maintenance_profile_p): Likewise.
2427         (per_command_time): Likewise.
2428         (per_command_space): Likewise.
2429         (per_command_symtab): Likewise.
2430         * memattr.c (inaccessible_by_default): Likewise.
2431         * mi/mi-main.c (mi_async): Likewise.
2432         (mi_async_1): Likewise.
2433         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2434         * nat/fork-inferior.h (startup_with_shell): Likewise.
2435         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2436         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2437         * nios2-tdep.c (nios2_debug): Likewise.
2438         * or1k-tdep.c (or1k_debug): Likewise.
2439         * parse.c (parser_debug): Likewise.
2440         * parser-defs.h (parser_debug): Likewise.
2441         * printcmd.c (print_symbol_filename): Likewise.
2442         * proc-api.c (procfs_trace): Likewise.
2443         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2444         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2445         (set_parameter_value): Update.
2446         (add_setshow_generic): Update.
2447         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2448         to bool*.
2449         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2450         int*.
2451         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2452         * record-btrace.c (record_btrace_target::store_registers): Update.
2453         * record-full.c (record_full_memory_query): Change to bool.
2454         (record_full_stop_at_limit): Likewise.
2455         * record-full.h (record_full_memory_query): Likewise.
2456         * remote-notif.c (notif_debug): Likewise.
2457         * remote-notif.h (notif_debug): Likewise.
2458         * remote.c (use_range_stepping): Likewise.
2459         (interrupt_on_connect): Likewise.
2460         (remote_break): Likewise.
2461         * ser-tcp.c (tcp_auto_retry): Likewise.
2462         * ser-unix.c (serial_hwflow): Likewise.
2463         * skip.c (debug_skip): Likewise.
2464         * solib-aix.c (solib_aix_debug): Likewise.
2465         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2466         (spu_auto_flush_cache_p): Likewise.
2467         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2468         Likewise.
2469         (struct info_print_options) <quiet>: Likewise.
2470         * symfile-debug.c (debug_symfile): Likewise.
2471         * symfile.c (auto_solib_add): Likewise.
2472         (separate_debug_file_debug): Likewise.
2473         * symfile.h (auto_solib_add): Likewise.
2474         (separate_debug_file_debug): Likewise.
2475         * symtab.c (basenames_may_differ): Likewise.
2476         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2477         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2478         (struct info_types_options) <quiet>: Likewise.
2479         * symtab.h (demangle): Likewise.
2480         (basenames_may_differ): Likewise.
2481         * target-dcache.c (stack_cache_enabled_1): Likewise.
2482         (code_cache_enabled_1): Likewise.
2483         * target.c (trust_readonly): Likewise.
2484         (may_write_registers): Likewise.
2485         (may_write_memory): Likewise.
2486         (may_insert_breakpoints): Likewise.
2487         (may_insert_tracepoints): Likewise.
2488         (may_insert_fast_tracepoints): Likewise.
2489         (may_stop): Likewise.
2490         (auto_connect_native_target): Likewise.
2491         (target_stop_and_wait): Update.
2492         (target_async_permitted): Change to bool.
2493         (target_async_permitted_1): Likewise.
2494         (may_write_registers_1): Likewise.
2495         (may_write_memory_1): Likewise.
2496         (may_insert_breakpoints_1): Likewise.
2497         (may_insert_tracepoints_1): Likewise.
2498         (may_insert_fast_tracepoints_1): Likewise.
2499         (may_stop_1): Likewise.
2500         * target.h (target_async_permitted): Likewise.
2501         (may_write_registers): Likewise.
2502         (may_write_memory): Likewise.
2503         (may_insert_breakpoints): Likewise.
2504         (may_insert_tracepoints): Likewise.
2505         (may_insert_fast_tracepoints): Likewise.
2506         (may_stop): Likewise.
2507         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2508         (make_thread_apply_all_options_def_group): Change argument from int*
2509         to bool*.
2510         (thread_apply_all_command): Update.
2511         (print_thread_events): Change to bool.
2512         * top.c (confirm): Likewise.
2513         (command_editing_p): Likewise.
2514         (history_expansion_p): Likewise.
2515         (write_history_p): Likewise.
2516         (info_verbose): Likewise.
2517         * top.h (confirm): Likewise.
2518         (history_expansion_p): Likewise.
2519         * tracepoint.c (disconnected_tracing): Likewise.
2520         (circular_trace_buffer): Likewise.
2521         * typeprint.c (print_methods): Likewise.
2522         (print_typedefs): Likewise.
2523         * utils.c (debug_timestamp): Likewise.
2524         (sevenbit_strings): Likewise.
2525         (pagination_enabled): Likewise.
2526         * utils.h (sevenbit_strings): Likewise.
2527         (pagination_enabled): Likewise.
2528         * valops.c (overload_resolution): Likewise.
2529         * valprint.h (struct value_print_options) <prettyformat_arrays,
2530         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2531         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2532         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2533         Likewise.
2534         * windows-nat.c (new_console): Likewise.
2535         (cygwin_exceptions): Likewise.
2536         (new_group): Likewise.
2537         (debug_exec): Likewise.
2538         (debug_events): Likewise.
2539         (debug_memory): Likewise.
2540         (debug_exceptions): Likewise.
2541         (useshell): Likewise.
2542         * windows-tdep.c (maint_display_all_tib): Likewise.
2543         * xml-support.c (debug_xml): Likewise.
2544
2545 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2546
2547         * source.c (prepare_path_for_appending): New function.
2548         (openp): Make use of new function.
2549         (find_and_open_source): Search for the compilation directory and
2550         source file as a relative path beneath the directory search path.
2551
2552 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * source-cache.c (source_cache::get_line_charpos): Catch
2555         exceptions and return false, this matches the behaviour documented
2556         in the header file.
2557
2558 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2559
2560         * ada-tasks.c (info_task): Remove quoting of the task's name.
2561
2562 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2563
2564         * symfile.c (auto_solib_add): Replace comment with a reference
2565         to the header file.
2566
2567 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2568
2569         * NEWS: Mention that gdb can now be compiled with Python 3
2570         on Windows.
2571
2572 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * maint.c (maint_print_section_data::maint_print_section_data):
2575         Force use of 'float log10 (float)' by casting the argument to
2576         float.
2577
2578 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * maint.c: Add 'cmath' include.
2581         (struct maint_print_section_data): New structure.
2582         (print_section_index): New function.
2583         (print_bfd_section_info): Add header comment, small whitespace
2584         cleanup, and update to call new print_section_index function.
2585         (print_objfile_section_info): Likewise.
2586         (maint_obj_section_from_bfd_section): New function.
2587         (print_bfd_section_info_maybe_relocated): New function.
2588         (maintenance_info_sections): Add header comment, always use
2589         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2590
2591 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2592
2593         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2594         inner scope, add check that the objfile has psymtabs before
2595         checking psymtabs_addrmap.
2596         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2597
2598 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2599
2600         * NEWS: Announce that Ada task names are now shown at more places,
2601         and between quotes (except in info task output).
2602         * gdb/ada-tasks.c (task_to_str): New function.
2603         (display_current_task_id): Call task_to_str.
2604         (task_command_1): Likewise.
2605         (print_ada_task_info): In non-mi mode, Properly align headers and data
2606         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2607
2608 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2609
2610         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2611         prstatus.pr_lwp.pr_info instead of making it up.
2612
2613 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2614
2615         * auto-load.c (auto_load_expand_dir_vars): Update.
2616         * defs.h (gdb_datadir): Change to std::string.
2617         (python_libdir): Likewise.
2618         (relocate_gdb_directory): Change return type to std::string.
2619         * guile/guile.c (gdbscm_data_directory): Update.
2620         (initialize_scheme_side): Update.
2621         * jit.c (jit_reader_dir): Change to std::string.
2622         (jit_reader_load_command): Update.
2623         * main.c (gdb_datadir): Change to std::string.
2624         (python_libdir): Likewise.
2625         (set_gdb_data_directory): Update.
2626         (relocate_path): Change to return std::string.
2627         (relocate_gdb_directory): Change to return std::string.
2628         (relocate_gdbinit_path_maybe_in_datadir): Update.
2629         (captured_main_1): Update.
2630         * python/python.c (do_start_initialization): Update.
2631         * top.c (show_gdb_datadir): Update.
2632         * xml-syscall.c (xml_init_syscalls_info): Update.
2633         (init_syscalls_info): Update.
2634
2635 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2636
2637         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2638         out of get_init_files.
2639         (get_init_files): Update.
2640
2641 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2642
2643         * main.c (get_init_files): Change to use std::string.
2644         (captured_main_1): Update.
2645         (print_gdb_help): Update.
2646
2647 2019-09-11  Ali Tamur  <tamur@google.com>
2648
2649         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2650         implementation.
2651
2652 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2653
2654         * dbxread.c (read_dbx_symtab): Update.
2655         * dwarf2read.c (load_partial_dies): Update.
2656         * mdebugread.c (parse_partial_symbols): Update.
2657         (handle_psymbol_enumerators): Update.
2658         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2659         * psymtab.c (add_psymbol_to_bcache): Likewise.
2660         (add_psymbol_to_list): Likewise.
2661         * symtab.c (symbol_set_names): Likewise.
2662         * symtab.h (symbol_set_names): Likewise.
2663         * xcoffread.c (scan_xcoff_symtab): Update.
2664
2665 2019-09-11  Tom Tromey  <tom@tromey.com>
2666
2667         * symfile-mem.c (symbol_file_add_from_memory): Use
2668         bfd_set_filename.
2669         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2670         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2671
2672 2019-09-10  Tom Tromey  <tromey@adacore.com>
2673
2674         * dwarf-index-write.c (write_psymbols): Extend error message.
2675         (debug_names::insert): Add Ada code.
2676         (debug_names::write_psymbols): Remove Ada check.
2677         (debug_names) <m_string_obstack>: New member.
2678         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2679         (gdb_index_symbol_name_matcher::matches): Remove.
2680         (mapped_index_base::find_name_components_bounds): Add "lang"
2681         parameter.
2682         (mapped_index_base::build_name_components): Also split names
2683         according to Ada syntax.
2684         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2685         type of "match_callback".
2686         (check_match, check_find_bounds_finds)
2687         (dw2_expand_symtabs_matching): Update.
2688         (dw2_debug_names_iterator): Add new constructor.
2689         (dw2_debug_names_map_matching_symbols): New function.
2690         (dw2_debug_names_expand_symtabs_matching): Update.
2691         (dwarf2_debug_names_functions): Use
2692         dw2_debug_names_map_matching_symbols.
2693
2694 2019-09-10  Tom Tromey  <tromey@adacore.com>
2695
2696         * dwarf2read.c (dw2_get_file_names_reader): Add the
2697         CU's file name to the results.
2698
2699 2019-09-10  Tom Tromey  <tromey@adacore.com>
2700
2701         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2702         map_matching_symbols.  Update.
2703         * dwarf2read.c (dw2_map_matching_symbols): Update.
2704         * psymtab.c (match_partial_symbol): Change type; update.
2705         (psym_map_matching_symbols): Likewise.
2706         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2707         type; update.
2708         * symfile.h (struct quick_symbol_functions)
2709         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2710         Remove "match".
2711
2712 2019-09-10  Tom Tromey  <tromey@adacore.com>
2713
2714         * psymtab.c (map_block): Remove.
2715         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2716         * symtab.c (iterate_over_symbols_terminated): New function.
2717         * symtab.c (iterate_over_symbols_terminated): Declare.
2718
2719 2019-09-10  Tom Tromey  <tromey@adacore.com>
2720
2721         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2722         * language.h (struct language_defn) <la_iterate_over_symbols>:
2723         Return bool.
2724         * symtab.c (iterate_over_symbols): Return bool.
2725         * symtab.h (iterate_over_symbols): Return bool.
2726
2727 2019-09-10  Tom Tromey  <tromey@adacore.com>
2728
2729         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2730         (add_nonlocal_symbols): Update.
2731         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2732         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2733         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2734         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2735         Change type of "callback".  Remove "data".
2736
2737
2738 2019-09-09  Ali Tamur  <tamur@google.com>
2739
2740         * dwarf2read.c (comp_unit_head): Update comment.
2741         (dwarf2_dwo_name): New function declaration.
2742         (dwarf_unit_type_name): New function declaration.
2743         (read_comp_unit_head): Add support for new compilation units,
2744         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2745         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2746         (currently named as "signature") in their header. Also clarify error
2747         messages.
2748         (lookup_dwo_id): New function. Returns the dwo id of the given
2749         compile unit.
2750         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2751         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2752         functions.
2753         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2754         (dwarf2_dwo_name): Get the dwo name if present.
2755         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2756         purposes.
2757
2758 2019-09-09  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2761
2762 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2763
2764         * python/python.c (do_start_initialization): Make progname_copy static,
2765         to avoid a leak report.
2766
2767 2019-09-08  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2770
2771 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2772
2773         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2774         Change type to gdb::optional<block_enum>.
2775         (dw2_symtab_iter_init): Change block_index parameter type
2776         to gdb::optional<block_enum>.
2777         (dw2_lookup_symbol): Change block_index parameter
2778         type to block_enum.c
2779         (dw2_debug_names_lookup_symbol): Likewise.
2780         * psymtab.c (psym_lookup_symbol): Likewise.
2781         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2782         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2783         Likewise.
2784
2785 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2786
2787         * defs.h (relocate_gdb_directory): Change int to bool in
2788         signature and rename flag to relocatable.
2789         * main.c (relocate_path): Likewise.
2790         (relocate_gdb_directory): Likewise.
2791
2792 2019-09-06  Alan Modra  <amodra@gmail.com>
2793
2794         * coffread.c (coff_symfile_read): Constify filename variable.
2795         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2796         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2797         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2798         * solib.c (reload_shared_libraries_1): Likewise.
2799         * symfile.c (reread_symbols): Likewise.
2800         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2801         * solib-darwin.c (darwin_bfd_open): Likewise.
2802         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2803
2804 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2807         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2808
2809 2019-09-03  Tom Tromey  <tromey@adacore.com>
2810
2811         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2812         types.
2813         (has_negatives): Unbias a range type bound.
2814         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2815         * gdbtypes.c (operator==): Handle new field.
2816         (create_range_type): Add "bias" parameter.
2817         (create_static_range_type, resolve_dynamic_range): Update.
2818         * gdbtypes.h (struct range_bounds) <bias>: New member.
2819         (create_range_type): Add bias parameter.
2820         * printcmd.c (print_scalar_formatted): Unbias range types.
2821         * value.c (unpack_long): Unbias range types.
2822         (pack_long): Bias range types.
2823
2824 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2825
2826         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2827         probe arguments.
2828
2829 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2832         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2833         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2834         (compile_probe_arg): Likewise.
2835         * probe.h (get_argument_count): Likewise.
2836         * solib-svr4.c (solib_event_probe_action): Likewise.
2837         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2838
2839 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2840
2841         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2842         code to here...
2843         (svr4_create_solib_event_breakpoints): ...from here.
2844
2845 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2846
2847         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2848         suffix from warning message.
2849
2850 2019-08-30  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-winsource.h (struct tui_source_window_base)
2853         <refresh_all>: Don't declare.
2854         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2855         Remove.
2856         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2857         tui_show_locator_content.
2858         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2859         declare.
2860         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2861         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2862         declare.
2863
2864 2019-08-30  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2867
2868 2019-08-30  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2871         Remove unnecessary forward declarations.
2872
2873 2019-08-30  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2876         rerender.
2877         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2878         tui_show_locator_content.
2879
2880 2019-08-30  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2883         (tui_locator_window::rerender): Rewrite using body of previous
2884         tui_show_locator_content.
2885
2886 2019-08-30  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2889         set_locator_fullname>: New methods.
2890         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2891         Rename from tui_set_locator_fullname.
2892         (tui_locator_window::set_locator_info): Rename from
2893         tui_set_locator_info.  Return bool.
2894         (tui_update_locator_fullname, tui_show_frame_info): Update.
2895
2896 2019-08-30  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2899
2900 2019-08-30  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2903         call touchwin.
2904
2905 2019-08-30  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui-wingeneral.c (box_win): Assume win_info and
2908         win_info->handle cannot be NULL.
2909
2910 2019-08-30  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2913         refresh_window>: Declare.
2914         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2915         resize.
2916         (tui_data_item_window::rerender): Rename from
2917         tui_display_register.
2918         (tui_data_item_window::refresh_window): New method.
2919         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2920         no-op.
2921
2922 2019-08-30  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2925         regs_column_count, current_group>: Move later.  Now private.
2926         <get_current_group>: New method.
2927         * tui/tui-regs.c (tui_reg_command): Update.
2928         * tui/tui-layout.c (tui_set_layout): Update.
2929
2930 2019-08-30  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2933         (tui_data_window::rerender): Don't call
2934         check_and_display_highlight_if_needed.
2935         (tui_data_window::refresh_all): Remove call to
2936         erase_data_content.
2937
2938 2019-08-30  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2941         (tui_data_window::display_registers_from)
2942         (tui_data_window::display_reg_element_at_line)
2943         (tui_data_window::display_registers_from_line): Remove checks of
2944         "empty".
2945
2946 2019-08-30  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2949         Don't declare.
2950         * tui/tui-regs.c (tui_data_window::show_registers): Call
2951         rerender.
2952         (tui_data_window::rerender): Rename from display_all_data.
2953         (tui_data_window::rerender): Remove old implementation.
2954
2955 2019-08-30  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2958         text.
2959         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2960
2961 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2962             Sergio Durigan Junior  <sergiodj@redhat.com>
2963
2964         PR win32/24284
2965         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2966
2967 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2970         when searching for types.
2971
2972 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * f-lang.c (f_language_defn): Use f_print_typedef.
2975         * f-lang.h (f_print_typedef): Declare.
2976         * f-typeprint.c (f_print_typedef): Define.
2977
2978 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2979
2980         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2981
2982 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * cli/cli-utils.c (info_print_options_defs): Delete.
2985         (make_info_print_options_def_group): Delete.
2986         (extract_info_print_options): Delete.
2987         (info_print_command_completer): Delete.
2988         (info_print_args_help): Add extra parameter, and optionally
2989         include text about -n flag.
2990         * cli/cli-utils.h (struct info_print_options): Delete.
2991         (extract_info_print_options): Delete declaration.
2992         (info_print_command_completer): Delete declaration.
2993         (info_print_args_help): Add extra parameter, extend header
2994         comment.
2995         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2996         search_symbols.
2997         * stack.c (struct info_print_options): New type.
2998         (info_print_options_defs): New file scoped variable.
2999         (make_info_print_options_def_group): New static function.
3000         (info_print_command_completer): New static function.
3001         (info_locals_command): Update to use new local functions.
3002         (info_args_command): Likewise.
3003         (_initialize_stack): Add extra parameter to calls to
3004         info_print_args_help.
3005         * symtab.c (search_symbols): Add extra parameter, use this to
3006         possibly excluse non-debug symbols.
3007         (symtab_symbol_info): Add extra parameter, which is passed on to
3008         search_symbols.
3009         (struct info_print_options): New type.
3010         (info_print_options_defs): New file scoped variable.
3011         (make_info_print_options_def_group): New static function.
3012         (info_print_command_completer): New static function.
3013         (info_variables_command): Update to use local functions, and pass
3014         extra parameter through to symtab_symbol_info.
3015         (info_functions_command): Likewise.
3016         (info_types_command): Pass additional argument through to
3017         symtab_symbol_info.
3018         (rbreak_command): Pass extra argument to search_symbols.
3019         (_initialize_symtab): Add extra arguments for calls to
3020         info_print_args_help, and update help text for 'info variables',
3021         'whereis', and 'info functions' commands.
3022         * symtab.h (search_symbols): Add extra argument to declaration.
3023         * NEWS: Mention new flags.
3024
3025 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3026
3027         * symtab.c (lookup_static_symbol): Call the new function (and move
3028         it down to be next to lookup_global_symbol).
3029         (struct global_sym_lookup_data): Add block_enum member and rename to...
3030         (struct global_or_static_sym_lookup_data): ...this.
3031         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3032         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3033         (lookup_symbol_global_or_static_iterator_cb): ...this.
3034         (lookup_global_or_static_symbol): New function.
3035         (lookup_global_symbol): Call new function.
3036
3037 2019-08-26  Tom de Vries  <tdevries@suse.de>
3038
3039         PR c++/24852
3040         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3041         when pc_probe.prob == NULL.
3042
3043 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3044
3045         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3046         variable symbol_linkage to symbol_linkage_.
3047
3048 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3049
3050         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3051         represent whether the symbol is static, dynamic, or we don't
3052         know.
3053
3054 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3055
3056         * gdb/rx-tdep.c (rx_register_names): New.
3057         (rx_register_name): Delete.
3058         (rx_psw_type): Delete.
3059         (rx_fpsw_type): Delete.
3060         (rx_register_type): Delete.
3061         (rx_gdbarch_init): Convert target-descriptions.
3062         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3063         * gdb/features/Makefile: Add rx.xml.
3064         * gdb/features/rx.xml: New.
3065         * gdb/features/rx.c: Generated.
3066         * gdb/NEWS: Mention target description support.
3067
3068 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3069
3070         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3071         *slot_ptr.
3072
3073 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3074
3075         * configure.ac: Don't check for 'dlfcn.h' (moved to
3076         gdbsupport/common.m4).
3077         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3078         'gdbsupport/'.
3079         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3080         * compile/compile-c-support.c: Include
3081         'gdbsupport/gdb-dlfcn.h'.
3082         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3083         * gdb-dlfcn.c: Move to...
3084         * gdbsupport/gdb-dlfcn.c: ... here.
3085         * gdb-dlfcn.h: Move to...
3086         * gdbsupport/gdb-dlfcn.h: ... here.
3087
3088 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3089
3090         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3091         the offset field signed.
3092
3093 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3094
3095         * python/lib/gdb/__init__.py (_execute_file): New function.
3096         * python/python.c (python_run_simple_file): Call gdb._execute_file
3097         on Windows.
3098
3099 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3102         all uses as this was never set to anything but a zero value.
3103
3104 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3105
3106         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3107
3108 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3109
3110         * tui/tui-data.h (tui_gen_win_info): Add an =default
3111         move constructor, required by some GCC versions.
3112
3113 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3114
3115         * go32-nat.c (go32_sysinfo): Add hygon_p.
3116
3117 2019-08-20  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3120         line_from_reg_element_no, first_reg_element_no_inline,
3121         display_all_data, delete_data_content_windows,
3122         erase_data_content>: Now private.
3123
3124 2019-08-20  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3127         (tui_unhighlight_win, tui_highlight_win)
3128         (tui_win_info::make_window): Update.
3129         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3130
3131 2019-08-20  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3134         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3135         (MAX_PID_WIDTH): Move to tui-stack.c.
3136         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3137         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3138         (MAX_PID_WIDTH): Move from tui-data.h.
3139
3140 2019-08-20  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3143         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3144         (box_win): Update.
3145         (tui_gen_win_info::make_window): Rename from tui_make_window.
3146         (tui_win_info::make_window): New method.
3147         (tui_gen_win_info::make_visible): Update.
3148         * tui/tui-source.c (tui_source_window::set_contents): Update.
3149         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3150         (tui_data_window::display_registers_from): Update.
3151         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3152         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3153         Declare.
3154         <can_box>: Remove.
3155         <title>: Remove.
3156         (struct tui_win_info) <make_window>: Declare.
3157         <can_box>: Now virtual.
3158         <title>: New member.
3159         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3160         * tui/tui-command.c (tui_cmd_window::resize): Update.
3161
3162 2019-08-20  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3165         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3166         (tui_data_window::check_register_values): Update.
3167
3168 2019-08-20  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-regs.h (struct tui_data_window): Use
3171         DISABLE_COPY_AND_ASSIGN.
3172         <regs_content>: Change type, removing unique_ptr.
3173         <tui_data_window>: Add move constructor.
3174         * tui/tui-regs.c (tui_data_window::show_registers)
3175         (tui_data_window::show_register_group)
3176         (tui_data_window::display_registers_from)
3177         (tui_data_window::display_registers_from)
3178         (tui_data_window::first_data_item_displayed)
3179         (tui_data_window::delete_data_content_windows)
3180         (tui_data_window::rerender, tui_data_window::refresh_window)
3181         (tui_data_window::check_register_values): Update.
3182
3183 2019-08-20  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3186         show_register_group>: Declare.
3187         (tui_show_register_group): Don't declare.
3188         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3189         tui_show_registers.
3190         (tui_data_window::show_register_group): Rename from
3191         tui_show_register_group.
3192         (tui_data_window::check_register_values, tui_reg_command):
3193         Update.
3194         * tui/tui-layout.c (tui_set_layout): Update.
3195
3196 2019-08-20  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3199         Declare.
3200         (tui_check_register_values): Don't declare.
3201         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3202         from tui_check_register_values.
3203         * tui/tui-hooks.c (tui_register_changed): Update.
3204
3205 2019-08-20  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-regs.c (tui_reg_layout): Move later.
3208         (tui_show_registers): Don't enable TUI mode or change layout.
3209
3210 2019-08-20  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-regs.h (struct tui_data_item_window)
3213         <~tui_data_item_window>: Remove.
3214         <content>: Now a unique_xmalloc_ptr.
3215         * tui/tui-regs.c (tui_register_format): Return a
3216         unique_xmalloc_ptr.
3217         (tui_get_register): Update.
3218         (~tui_data_item_window): Remove.
3219         (tui_data_window::display_registers_from, tui_display_register):
3220         Update.
3221         * tui/tui-io.h (tui_expand_tabs): Update.
3222         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3223         Remove "col" parameter.
3224
3225 2019-08-20  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3228         field.
3229         * tui/tui-regs.c (~tui_data_item_window): Update.
3230
3231 2019-08-20  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3234         earlier.
3235
3236 2019-08-20  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3239
3240 2019-08-20  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-source.h (struct tui_source_window): Update.
3243         * tui/tui-regs.c (tui_show_registers): Update.
3244         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3245         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3246         (NO_REGS_STRING): Remove defines.
3247
3248 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3249
3250         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3251         unnecessary thread walk if remote doesn't support the packet.
3252
3253 2019-08-19  Tom Tromey  <tromey@adacore.com>
3254
3255         * python/py-value.c (value_has_field): Fix indentation.
3256
3257 2019-08-19  Tom Tromey  <tromey@adacore.com>
3258
3259         * printcmd.c (do_one_display, info_display_command): Update.
3260         * block.h (contained_in): Return bool.  Add allow_nested
3261         parameter.
3262         * block.c (contained_in): Return bool.  Add allow_nested
3263         parameter.
3264
3265 2019-08-19  Tom Tromey  <tom@tromey.com>
3266
3267         * configure: Rebuild.
3268         * configure.ac: Disallow the combination of -static-libstdc++ and
3269         source highlight.
3270         * source-cache.c (get_language_name): Handle rust.
3271         (source_cache::get_source_lines): Ignore highlighting exceptions.
3272
3273 2019-08-16  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3276         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3277         (struct tui_source_window_base) <make_visible, refresh_window,
3278         resize>: Remove methods.
3279         <execution_info>: Remove field.
3280         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3281         (tui_show_source_line, tui_source_window_base)
3282         (~tui_source_window_base): Update.
3283         (tui_source_window_base::resize)
3284         (tui_source_window_base::make_visible)
3285         (tui_source_window_base::refresh_window): Remove.
3286         (tui_source_window_base::update_exec_info): Update.
3287         * tui/tui-source.c (tui_source_window::set_contents): Update.
3288         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3289
3290 2019-08-16  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3293         deprecated_query_hook.
3294
3295 2019-08-16  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3298         (tui_update_source_windows_with_line): Update.
3299         * tui/tui-source.h (struct tui_source_window)
3300         <show_symtab_source>: Declare.
3301         (tui_show_symtab_source): Don't declare.
3302         * tui/tui-source.c (tui_show_symtab_source): Rename from
3303         tui_show_symtab_source.
3304
3305 2019-08-16  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-winsource.h (struct tui_source_window_base)
3308         <set_contents>: Declare.
3309         * tui/tui-winsource.c
3310         (tui_source_window_base::update_source_window_as_is): Update.
3311         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3312         Declare.
3313         (tui_set_source_content): Don't declare.
3314         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3315         tui_set_source_content.
3316         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3317         Declare.
3318         (tui_set_disassem_content): Don't declare.
3319         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3320         tui_set_disassem_content.
3321
3322 2019-08-16  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.h (struct tui_source_window_base)
3325         <update_breakpoint_info>: Declare.
3326         (tui_update_breakpoint_info): Don't declare.
3327         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3328         (tui_update_all_breakpoint_info): Update.
3329         (tui_source_window_base::update_breakpoint_info): Rename from
3330         tui_update_breakpoint_info.
3331         (tui_source_window_base::update_exec_info): Update.
3332
3333 2019-08-16  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.h (struct tui_source_window_base)
3336         <update_source_window>: Declare.
3337         (tui_update_source_window): Don't declare.
3338         * tui/tui-winsource.c
3339         (tui_source_window_base::update_source_window): Rename from
3340         tui_update_source_window.
3341         (tui_source_window_base::rerender): Update.
3342         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3343         * tui/tui-disasm.c (tui_show_disassem)
3344         (tui_show_disassem_and_update_source)
3345         (tui_disasm_window::maybe_update): Update.
3346
3347 2019-08-16  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-winsource.h (struct tui_source_window_base)
3350         <update_source_window_as_is>: Declare.
3351         (tui_update_source_window_as_is): Don't declare.
3352         * tui/tui-winsource.c (tui_update_source_window): Update
3353         (tui_source_window_base::update_source_window_as_is): Rename from
3354         tui_update_source_window_as_is.
3355         (tui_source_window_base::refill): Update.
3356         * tui/tui-source.c (tui_show_symtab_source): Update.
3357         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3358         Update.
3359
3360 2019-08-16  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-winsource.h (tui_update_source_window)
3363         (tui_update_source_window_as_is): Remove "noerror" parameter.
3364         * tui/tui-winsource.c (tui_update_source_window)
3365         (tui_update_source_window_as_is): Remove "noerror" parameter.
3366         (tui_update_source_windows_with_addr)
3367         (tui_update_source_windows_with_line)
3368         (tui_source_window_base::rerender)
3369         (tui_source_window_base::refill): Update.
3370         * tui/tui-source.h (tui_set_source_content)
3371         (tui_show_symtab_source): Remove "noerror" parameter.
3372         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3373         parameter.
3374         (tui_show_symtab_source): Likewise.
3375         (tui_source_window::maybe_update): Update.
3376         * tui/tui-disasm.c (tui_show_disassem)
3377         (tui_show_disassem_and_update_source)
3378         (tui_disasm_window::do_scroll_vertical)
3379         (tui_disasm_window::maybe_update): Update.
3380
3381 2019-08-16  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui.c (tui_is_window_visible): Update.
3384         * tui/tui-wingeneral.c (tui_make_window)
3385         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3386         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3387         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3388         (tui_set_win_height_command, parse_scrolling_args): Update.
3389         * tui/tui-source.c (tui_source_window::style_changed): Update.
3390         * tui/tui-regs.c (tui_show_registers)
3391         (tui_data_window::first_data_item_displayed)
3392         (tui_data_window::delete_data_content_windows)
3393         (tui_check_register_values, tui_reg_command): Update.
3394         * tui/tui-disasm.c (tui_show_disassem): Update.
3395         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3396         method.
3397         <is_visible>: Remove field.
3398         * tui/tui-data.c (tui_next_win, tui_prev_win)
3399         (tui_delete_invisible_windows): Update.
3400
3401 2019-08-16  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-winsource.h (struct tui_source_window_base)
3404         <m_has_locator>: Remove.
3405         * tui/tui-layout.c (show_source_disasm_command, show_data)
3406         (show_source_or_disasm_and_command): Update.
3407
3408 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3409
3410         * NEWS (Other MI changes): New subsection.
3411         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3412         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3413         * arch-utils.c (default_get_pc_address_flags): New function.
3414         * arch-utils.h (default_get_pc_address_flags): New declaration.
3415         * gdbarch.sh: Add get_pc_address_flags.
3416         * gdbarch.c: Regenerate.
3417         * gdbarch.h: Likewise.
3418         * stack.c (print_pc): New function.
3419         (print_frame_info) (print_frame): Call print_pc.
3420
3421 2019-08-16  Tom de Vries  <tdevries@suse.de>
3422
3423         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3424         print_objfile_section_info.
3425
3426 2019-08-15  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3429         calling update_cmdwin_start_line.
3430         * tui/tui-winsource.h (struct tui_source_window_base)
3431         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3432         <rerender>: Declare.
3433         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3434         Call rerender.
3435         (tui_source_window_base::set_new_height): Remove.
3436         (tui_source_window_base::rerender): Rename from
3437         do_make_visible_with_new_height.
3438         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3439         resize method.
3440         (tui_win_info::make_invisible_and_set_new_height)
3441         (tui_win_info::make_visible_with_new_height): Remove.
3442         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3443         Declare.
3444         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3445         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3446         do_make_visible_with_new_height>: Don't declare.
3447         <rerender>: Declare.
3448         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3449         set_new_height.
3450         (tui_data_window::do_make_visible_with_new_height): Remove.
3451         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3452         call tui_show_locator_content.
3453         (tui_gen_win_info::resize): Call rerender.
3454         (show_source_or_disasm_and_command): Don't call
3455         tui_show_locator_content.
3456         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3457         method.
3458         (struct tui_win_info) <rerender>: Declare.
3459         <set_new_height, make_invisible_and_set_new_height,
3460         make_visible_with_new_height>: Don't declare.
3461         * tui/tui-data.c (tui_win_list::rerender): New method.
3462         * tui/tui-command.h (struct tui_cmd_window)
3463         <do_make_visible_with_new_height>: Don't declare.
3464         * tui/tui-command.c
3465         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3466
3467 2019-08-15  Tom Tromey  <tromey@adacore.com>
3468
3469         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3470         * ada-lang.c (ada_enum_name): Likewise.
3471
3472 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3473
3474         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3475         leading underscore.
3476         (GdbOutputErrorFile): Likewise.
3477         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3478         accordingly.
3479         (execute_unwinders): Rename to have a leading underscore.
3480         (auto_load_packages): Likewise.
3481         (global scope): Adjust call to auto_load_packages accordingly.
3482         (GdbSetPythonDirectory): Likewise.
3483         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3484         instead of execute_unwinders.
3485
3486 2019-08-15  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3489         (show_data): Don't change window visibility.
3490         (tui_gen_win_info::resize): Remove special case for command
3491         window.  Use wresize, when available.
3492         (show_source_or_disasm_and_command): Don't change window
3493         visibility.
3494         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3495         <make_visible>: New method.
3496         * tui/tui-command.c (tui_cmd_window::resize): New method.
3497
3498 2019-08-15  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3501         (struct tui_source_windows): New.
3502         * tui/tui-winsource.c (tui_display_main): Update.
3503         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3504         (new_height_ok, parse_scrolling_args): Update.
3505         * tui/tui-layout.c (show_layout, show_data): Update.
3506         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3507         (tui_add_to_source_windows): Don't declare.
3508         * tui/tui-data.c (source_windows, tui_source_windows)
3509         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3510
3511 2019-08-15  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3514         Rename from reset.
3515         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3516         * tui/tui-layout.c (show_source_disasm_command, show_data):
3517         Update.
3518         (tui_gen_win_info::resize): Rename.
3519         (show_source_or_disasm_and_command): Update.
3520         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3521         reset.
3522
3523 2019-08-15  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3526         * tui/tui-interp.c (tui_interp::init): Don't call
3527         tui_initialize_static_data.
3528         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3529
3530 2019-08-15  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3533         examine tui_win_list.
3534
3535 2019-08-15  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3538         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3539         tui_clear_source_content.
3540         (tui_clear_source_content): Remove.
3541         (tui_source_window_base::do_erase_source_content): Hoist call to
3542         content.clear().
3543         * tui/tui-stack.c (tui_show_frame_info): Don't call
3544         tui_clear_source_content.
3545
3546 2019-08-15  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-winsource.h (struct tui_source_window_base)
3549         <do_erase_source_content>: New method.
3550         <erase_source_content>: New method.
3551         (tui_erase_source_content): Don't declare.
3552         * tui/tui-winsource.c (tui_clear_source_content): Update.
3553         (tui_source_window_base::do_erase_source_content): Rename from
3554         tui_erase_source_content.
3555         (tui_source_window_base::show_source_content): Update.
3556         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3557         * tui/tui-source.h (struct tui_source_window)
3558         <erase_source_content>: New method.
3559         * tui/tui-disasm.h (struct tui_disasm_window)
3560         <erase_source_content>: New method.
3561
3562 2019-08-15  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3565         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3566         constructor.
3567         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3568         * tui/tui-source.c (tui_set_source_content): Update.
3569         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3570
3571 2019-08-15  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3574         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3575         tui-source.c.
3576         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3577         Declare.
3578         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3579         method.
3580         (tui_source_window::maybe_update): Update.
3581
3582 2019-08-15  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3585         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3586         tui-disasm.c.
3587         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3588         Declare.
3589         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3590         method.
3591         (tui_disasm_window::maybe_update): Update.
3592
3593 2019-08-15  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-winsource.h (struct tui_source_window_base)
3596         <maybe_update>: Declare.
3597         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3598         method.
3599         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3600         Declare.
3601         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3602         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3603         Declare.
3604         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3605
3606 2019-08-15  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3609
3610 2019-08-15  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-wingeneral.c: Include tui-stack.h.
3613         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3614         (struct tui_locator_window): Move from tui-data.h.
3615         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3616         (tui_initialize_static_data): Move from tui-data.c.
3617         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3618         (struct tui_locator_window): Move to tui-stack.c.
3619         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3620         (tui_initialize_static_data): Move to tui-stack.c.
3621
3622 2019-08-15  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-layout.c (show_source_disasm_command)
3625         (show_source_or_disasm_and_command): Use make_visible method, not
3626         tui_make_window.
3627         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3628         Remove.
3629
3630 2019-08-15  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-wingeneral.h (tui_make_window): Update.
3633         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3634         parameter.
3635         (tui_gen_win_info::make_visible): Update.
3636         * tui/tui-regs.c (tui_data_window::display_registers_from):
3637         Update.
3638         * tui/tui-layout.c (show_source_disasm_command)
3639         (show_source_or_disasm_and_command): Update.
3640         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3641         (enum tui_box): Remove.
3642         (struct tui_win_info) <can_box>: New method.
3643         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3644         method.
3645
3646 2019-08-15  Tom de Vries  <tdevries@suse.de>
3647
3648         * linux-nat-trad.c: Include gdbarch.h.
3649
3650 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3651
3652         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3653         register sizes.
3654
3655 2019-08-14  Tom Tromey  <tromey@adacore.com>
3656
3657         * darwin-nat.c: Include gdbarch.h.
3658         * darwin-nat-info.c: Include gdbarch.h.
3659
3660 2019-08-13  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3663         Remove.
3664         * tui/tui-data.c (tui_initialize_static_data): Update.
3665
3666 2019-08-13  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-winsource.h (struct tui_exec_info_window)
3669         <~tui_exec_info_window, maybe_allocate_content, get_content,
3670         m_content>: Remove.
3671         (struct tui_source_window_base) <set_exec_info_content,
3672         show_exec_info_content>: Don't declare.
3673         * tui/tui-winsource.c
3674         (tui_exec_info_window::maybe_allocate_content): Remove.
3675         (tui_source_window_base::update_exec_info): Rename from
3676         set_exec_info_content.
3677         (tui_source_window_base::show_exec_info_content)
3678         (tui_source_window_base::update_exec_info): Remove.
3679
3680 2019-08-13  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3683         declare.
3684         * tui/tui-winsource.c (tui_update_source_window_as_is)
3685         (tui_update_source_windows_with_addr, tui_erase_source_content):
3686         Update.
3687         (tui_clear_exec_info_content): Remove.
3688
3689 2019-08-13  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3692         declare.
3693         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3694         call tui_erase_exec_info_content.
3695         (tui_clear_exec_info_content): Rename from
3696         tui_erase_exec_info_content.
3697         (tui_clear_exec_info_content): Delete.
3698
3699 2019-08-13  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.h (struct tui_source_window_base)
3702         <show_exec_info_content>: Declare.
3703         (tui_show_exec_info_content): Don't declare.
3704         * tui/tui-winsource.c
3705         (tui_source_window_base::show_exec_info_content): Rename from
3706         tui_show_exec_info_content.
3707         (tui_source_window_base::update_exec_info): Update.
3708
3709 2019-08-13  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3712         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3713         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3714         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3715         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3716         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3717         ... here.
3718
3719 2019-08-13  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-winsource.h (struct tui_source_window_base)
3722         <update_exec_info>: Declare.
3723         (tui_update_exec_info): Don't declare.
3724         * tui/tui-winsource.c (tui_update_source_window_as_is)
3725         (tui_source_window_base::refresh_all)
3726         (tui_update_all_breakpoint_info): Update.
3727         (tui_source_window_base::update_exec_info): Rename from
3728         tui_update_exec_info.
3729         * tui/tui-stack.c (tui_show_frame_info): Update.
3730
3731 2019-08-13  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-winsource.h (struct tui_source_window_base)
3734         <set_exec_info_content>: Declare.
3735         (tui_set_exec_info_content): Don't declare.
3736         * tui/tui-winsource.c
3737         (tui_source_window_base::set_exec_info_content): Rename from
3738         tui_set_exec_info_content.
3739         (tui_update_exec_info): Update.
3740
3741 2019-08-13  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-winsource.h (struct tui_source_window_base)
3744         <show_source_content>: Declare.
3745         (tui_show_source_content): Don't declare.
3746         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3747         (tui_source_window_base::show_source_content): Rename from
3748         tui_show_source_content.
3749         (tui_source_window_base::refresh_all): Update.
3750         * tui/tui-layout.c (show_source_disasm_command)
3751         (show_source_or_disasm_and_command): Update.
3752
3753 2019-08-13  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-winsource.c (tui_erase_source_content)
3756         (tui_show_source_content, tui_source_window_base::refresh_all):
3757         Update.
3758         * tui/tui-wingeneral.h
3759         (tui_check_and_display_highlight_if_needed): Don't declare.
3760         * tui/tui-wingeneral.c
3761         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3762         check_and_display_highlight_if_needed.
3763         * tui/tui-win.c (tui_rehighlight_all)
3764         (tui_win_info::make_visible_with_new_height): Update.
3765         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3766         (tui_data_window::erase_data_content)
3767         (tui_data_window::display_all_data): Update.
3768         * tui/tui-data.h (struct tui_win_info)
3769         <check_and_display_highlight_if_needed>: Declare.
3770
3771 2019-08-13  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-win.c (tui_resize_all): Call
3774         tui_delete_invisible_windows.
3775         * tui/tui-layout.c (show_layout): Call
3776         tui_delete_invisible_windows.
3777         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3778         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3779
3780 2019-08-13  Tom Tromey  <tom@tromey.com>
3781
3782         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3783         tui_add_win_to_layout.
3784
3785 2019-08-13  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3788         * tui/tui-layout.c (tui_default_win_height): Now static.
3789
3790 2019-08-13  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3793         single switch.
3794         (show_source_disasm_command, show_source_or_disasm_and_command):
3795         Don't check current layout.
3796
3797 2019-08-13  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-wingeneral.c (make_all_visible): Remove.
3800         (tui_make_all_invisible): Simplify.
3801         * tui/tui-layout.c (tui_make_all_invisible): Move from
3802         tui-wingeneral.c; simplify.
3803         (show_layout): Hoist call to tui_make_all_invisible.
3804         (show_data): Don't call tui_make_all_invisible.
3805
3806 2019-08-13  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3809         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3810
3811 2019-08-13  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3814         tui-data.c.
3815         (show_source_disasm_command, show_data)
3816         (show_source_or_disasm_and_command): Don't use
3817         tui_set_current_layout_to.
3818         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3819         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3820         tui-layout.c.
3821         (tui_set_current_layout_to): Remove.
3822
3823 2019-08-13  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-layout.c (tui_set_layout): Update.
3826         * tui/tui-data.h (struct tui_layout_def): Remove.
3827         (tui_layout_def): Don't declare.
3828         * tui/tui-data.c (layout_def): Remove.
3829         (tui_layout_def): Remove.
3830
3831 2019-08-13  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-winsource.h (struct tui_source_window_base)
3834         <clear_detail>: No longer "override".
3835         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3836         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3837         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3838         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3839         Remove.
3840         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3841
3842 2019-08-13  Tom Tromey  <tromey@adacore.com>
3843
3844         * tracepoint.c: Don't include readline.h or history.h.
3845
3846 2019-08-12  Tom Tromey  <tom@tromey.com>
3847
3848         * configure: Rebuild.
3849         * configure.ac: Check for readline 7.
3850         * NEWS: Mention readline 7 requirement.
3851         * README: Update.
3852
3853 2019-08-12  Tom Tromey  <tom@tromey.com>
3854
3855         * mingw-hdep.c (gdb_select): Remove readline hack.
3856
3857 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3858
3859         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3860         when the function fails.
3861
3862 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3863
3864         * s390-tdep.c (s390_type_align): New function.
3865         (s390_gdbarch_init): Set it as type_align gdbarch method.
3866
3867 2019-08-09  Tom de Vries  <tdevries@suse.de>
3868
3869         PR gdb/24591
3870         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3871         pc_low with relocation offset.
3872
3873 2019-08-07  Tom Tromey  <tromey@adacore.com>
3874
3875         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3876         (print_frame_args): Update.
3877         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3878         Update.
3879         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3880         * frame.h (struct frame_arg): Add initializers.
3881         <error>: Now a unique_xmalloc_ptr.
3882
3883 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3884
3885         * NEWS: Expand the Pointer Authentication entry.
3886         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3887         (aarch64_frame_unmask_lr): ... to this.
3888         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3889         Call aarch64_frame_unmask_lr.
3890         * frame.c (struct frame_info): Add "masked" variable.
3891         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3892         (fprint_frame): Check for masked pc.
3893         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3894         declarations.
3895         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3896         * stack.c (print_frame): Check for masked pc.
3897
3898 2019-08-06  Tom Tromey  <tom@tromey.com>
3899
3900         * stabsread.c (patch_block_stabs, read_one_struct_field)
3901         (read_enum_type): Use obstack_strndup.
3902         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3903         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3904         * dwarf2read.c (guess_full_die_structure_name)
3905         (anonymous_struct_prefix): Use obstack_strndup.
3906         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3907         * c-exp.y (yylex): Use obstack_strndup.
3908         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3909         (write_var_or_type): Use obstack_strndup.
3910
3911 2019-08-06  Tom Tromey  <tom@tromey.com>
3912
3913         * symfile.c (reread_symbols): Use obstack_strdup.
3914         * stabsread.c (read_type): Use obstack_strdup.
3915         * gdb_obstack.h (obstack_strdup): New overload.
3916         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3917         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3918         (dwarf2_canonicalize_name): Use obstack_strdup.
3919         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3920         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3921         Use obstack_strdup.
3922
3923 2019-08-06  Tom Tromey  <tom@tromey.com>
3924
3925         * gdb_obstack.h (obstack_strdup): Define.
3926         * gdb_obstack.c (obstack_strdup): Don't define.
3927
3928 2019-08-06  Tom Tromey  <tom@tromey.com>
3929
3930         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3931         obstack_strdup.
3932         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3933         obstack_strdup.
3934         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3935         * stabsread.c (common_block_start): Use obstack_strdup.
3936         * objfiles.c (set_objfile_main_name, objfile): Use
3937         obstack_strdup.
3938         * namespace.c (add_using_directive): Use obstack_strdup.
3939         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3940         * jit.c (finalize_symtab): Use obstack_strdup.
3941         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3942         (guess_partial_die_structure_name, partial_die_info::fixup)
3943         (dwarf2_name): Use obstack_strdup.
3944         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3945         obstack_strdup.
3946         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3947         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3948         obstack_strdup.
3949         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3950
3951 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3952
3953         * unittests/help-doc-selftests.c: New file.
3954         * Makefile.in: Add the new file.
3955
3956 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3957
3958         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3959         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3960         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3961         the trailing '.' is not output, and the first character is uppercased.
3962         (print_help_for_command): Update call to print_doc_line.
3963         (print_doc_of_command): Likewise.
3964         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3965         * cli/cli-option.c (append_indented_doc): Do not append newline.
3966         (build_help_option): Append newline after first appended_indented_doc
3967         only if a second call is done.
3968         (build_help): Append 2 new lines before each option, except the first
3969         one.
3970         * compile/compile.c (_initialize_compile): Add new lines after
3971         %OPTIONS%, when not at the end of the help.
3972         Change help doc or code
3973         producing the help doc to respect the invariants.
3974         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3975         Also removed the new line after 'Options:', as all other commands
3976         do not put an empty line between 'Options:' and the first option.
3977         * printcmd.c (_initialize_printcmd): Likewise.
3978         * stack.c (_initialize_stack): Likewise.
3979         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3980         incorrectly telling COMMAND is optional.
3981         * ada-lang.c (_initialize_ada_language): Change help doc or code
3982         producing the help doc to respect the invariants.
3983         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3984         * breakpoint.c (_initialize_breakpoint): Likewise.
3985         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3986         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3987         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3988         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3989         _initialize_cli_style): Likewise.
3990         * corelow.c (core_target_info): Likewise.
3991         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3992         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3993         * filesystem.c (_initialize_filesystem): Likewise.
3994         * frame.c (_initialize_frame): Likewise.
3995         * gnu-nat.c (add_task_commands): Likewise.
3996         * infcall.c (_initialize_infcall): Likewise.
3997         * infcmd.c (_initialize_infcmd): Likewise.
3998         * interps.c (_initialize_interpreter): Likewise.
3999         * language.c (_initialize_language): Likewise.
4000         * linux-fork.c (_initialize_linux_fork): Likewise.
4001         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4002         * maint.c (_initialize_maint_cmds): Likewise.
4003         * memattr.c (_initialize_mem): Likewise.
4004         * printcmd.c (_initialize_printcmd): Likewise.
4005         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4006         _RegEx): Likewise.
4007         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4008         * record-btrace.c (_initialize_record_btrace): Likewise.
4009         * record-full.c (_initialize_record_full): Likewise.
4010         * record.c (_initialize_record): Likewise.
4011         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4012         * regcache.c (_initialize_regcache): Likewise.
4013         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4014         _initialize_remote): Likewise.
4015         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4016         * serial.c (_initialize_serial): Likewise.
4017         * skip.c (_initialize_step_skip): Likewise.
4018         * source.c (_initialize_source): Likewise.
4019         * stack.c (_initialize_stack): Likewise.
4020         * symfile.c (_initialize_symfile): Likewise.
4021         * symtab.c (_initialize_symtab): Likewise.
4022         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4023         * top.c (init_main): Likewise.
4024         * tracefile-tfile.c (tfile_target_info): Likewise.
4025         * tracepoint.c (_initialize_tracepoint): Likewise.
4026         * tui/tui-win.c (_initialize_tui_win): Likewise.
4027         * utils.c (add_internal_problem_command): Likewise.
4028         * valprint.c (value_print_option_defs): Likewise.
4029
4030 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4031
4032         PR build/24886
4033         * configure.ac: Drop enable-libmcheck support.
4034         * configure, config.in: Rebuild.
4035         * libmcheck.m4: Remove.
4036         * acinclude.m4: Don't include it.
4037         * Makefile.in: Don't distribute it.
4038         * top.c (print_gdb_configuration): Don't mention it.
4039
4040 2019-08-06  Tom Tromey  <tom@tromey.com>
4041
4042         * utils.c (set_output_style): Sometimes pass stream to
4043         emit_style_escape.
4044         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4045         * record-btrace.c (btrace_insn_history): Update.
4046         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4047         method.
4048         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4049         Update initializers.
4050         <m_uiout>: New field.
4051         <m_di>: Move lower.
4052         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4053         Remove "uiout" parameter.
4054         (dump_insns): Update.
4055         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4056         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4057
4058 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4059
4060         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4061         (error_in_psymtab_expansion): Likewise.
4062         (lookup_symbol_via_quick_fns): Likewise.
4063         (basic_lookup_transparent_type_quick): Likewise.
4064         (basic_lookup_transparent_type_1): Likewise.
4065
4066 2019-08-06  Tom Tromey  <tromey@adacore.com>
4067
4068         * source.c (last_source_error): Now bool.
4069         (print_source_lines_base): Make "noprint" bool.  Only open
4070         source file when last_source_visited changes.
4071
4072 2019-08-06  Tom Tromey  <tromey@adacore.com>
4073
4074         * annotate.c (annotate_source_line): Use g_source_cache.
4075         * source-cache.c (source_cache::get_plain_source_lines): Change
4076         parameters.  Populate m_offset_cache.
4077         (source_cache::ensure): New method.
4078         (source_cache::get_line_charpos): New method.
4079         (extract_lines): Move lower.  Change parameters.
4080         (source_cache::get_source_lines): Move lower.
4081         * source-cache.h (class source_cache): Update comment.
4082         <get_line_charpos>: New method.
4083         <get_source_lines>: Update comment.
4084         <clear>: Clear m_offset_cache.
4085         <get_plain_source_lines>: Change parameters.
4086         <ensure>: New method
4087         <m_offset_cache>: New member.
4088         * source.c (forget_cached_source_info_for_objfile): Update.
4089         (info_source_command): Use g_source_cache.
4090         (find_source_lines, open_source_file_with_line_charpos): Remove.
4091         (print_source_lines_base, search_command_helper): Use g_source_cache.
4092         * source.h (open_source_file_with_line_charpos): Don't declare.
4093         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4094         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4095         Use g_source_cache.
4096
4097 2019-08-06  Tom Tromey  <tromey@adacore.com>
4098
4099         * source-cache.c (source_cache::get_plain_source_lines):
4100         Remove "first_line" and "last_line" parameters.
4101         (source_cache::get_source_lines): Cache plain text.
4102         * source-cache.h (class source_cache)
4103         <get_plain_source_lines>: Update.
4104
4105 2019-08-06  Tom Tromey  <tromey@adacore.com>
4106
4107         * source-cache.c (extract_lines): No longer a method.
4108         Changed type of parameter.  Include final newline.
4109         (selftests::extract_lines_test): New function.
4110         (_initialize_source_cache): Likewise.
4111         * source-cache.h (class source_cache)
4112         <extract_lines>: Don't declare.
4113
4114 2019-08-06  Tom Tromey  <tromey@adacore.com>
4115
4116         * breakpoint.c (init_breakpoint_sal): Update.
4117         (breakpoint): Update.
4118         * breakpoint.h (struct breakpoint) <filter>: Now a
4119         unique_xmalloc_ptr.
4120
4121 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4122
4123         * NEWS: Mention dictionary access on blocks.
4124         * python/py-block.c (blpy_getitem): New function.
4125         (block_object_as_mapping): New struct.
4126         (block_object_type): Use new struct for tp_as_mapping field.
4127
4128 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4129
4130         * objfiles.h (objfile): Add a comment describing partial symbols.
4131
4132 2019-08-05  Tom Tromey  <tromey@adacore.com>
4133
4134         * compile/compile.c (_initialize_compile): Use _(), not N_().
4135         * thread.c (_initialize_thread): Use _(), not N_().
4136         * stack.c (_initialize_stack): Use _(), not N_().
4137         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4138
4139 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4140
4141         * dwarf2read.c (struct dw2_symtab_iterator):
4142         <want_specific_block>: Remove.
4143         <block_index>: Change type to gdb::optional.
4144         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4145         change type of BLOCK_INDEX parameter to gdb::optional.
4146         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4147         (dw2_lookup_symbol): Don't pass argument for
4148         WANT_SPECIFIC_BLOCK.
4149         (dw2_expand_symtabs_for_function): Don't pass argument for
4150         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4151         (class dw2_debug_names_iterator)
4152         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4153         parameter, change BLOCK_INDEX type to gdb::optional.
4154         <m_want_specific_block>: Remove.
4155         <m_block_index>: Change type to gdb::optional.
4156         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4157         gdb::optional.  Re-write in function of gdb::optional.
4158         (dw2_debug_names_lookup_symbol): Don't pass argument for
4159         WANT_SPECIFIC_BLOCK.
4160         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4161         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4162         BLOCK_INDEX.
4163
4164 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4165
4166         * NEWS: Mention changes to "info sources" command.
4167
4168 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4169
4170         * symtab.c (filename_partial_match_opts): New struct type.
4171         (struct output_source_filename_data): New members
4172         regexp, c_regexp, partial_match.
4173         (output_source_filename): Use new members to decide to print file.
4174         (info_sources_option_defs): New variable.
4175         (make_info_sources_options_def_group, print_info_sources_header,
4176         info_sources_command_completer):
4177         New functions.
4178         (info_sources_command): Read new optional arguments.
4179         (_initialize_symtab): Update info sources help.
4180
4181 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4182
4183         * ada-lang.c (exception_support_info_v0): Renamed from...
4184         (default_exception_support_info): ... this.  Create new
4185         definition for v1.
4186         (ada_has_this_exception_support): Look up catch_handlers_sym.
4187         (ada_exception_support_info_sniffer): Try v0 after default.
4188
4189 2019-08-01  Tom Tromey  <tromey@adacore.com>
4190
4191         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4192         gdbarch.h.
4193
4194 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4195
4196         * s12z-tdep.c: Fix include path for s12z-opc.h.
4197
4198 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4199
4200         * NEWS: Require GNU make 3.82.
4201
4202 2019-07-16  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4205         declare.
4206
4207 2019-07-30  Tom Tromey  <tromey@adacore.com>
4208
4209         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4210
4211 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4212
4213         * printcmd.c (print_address_symbolic): Print negative offsets.
4214         (build_address_symbolic): Force signed arithmetic when computing
4215         offset.
4216
4217 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4218
4219         PR/24474: Add a function to lookup static variables.
4220         * NEWS: Mention this new function.
4221         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4222         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4223         * python/python.c (python_GdbMethods): Add new function.
4224
4225 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4226
4227         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4228         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4229         (objfpy_lookup_static_symbol): New function.
4230         (objfile_object_methods): Add new functions.
4231
4232 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4233
4234         * NEWS: Mention 'set|show print frame-info'.  Mention new
4235         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4236         backtrace argument.  Mention that python frame filtering code
4237         is now consistent with what 'backtrace' command prints.
4238
4239 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4242         comments.
4243         (print_frame_info_auto, print_frame_info_source_line,
4244         print_frame_info_location, print_frame_info_source_and_location,
4245         print_frame_info_location_and_address, print_frame_info_short_location):
4246         New declarations.
4247         (struct frame_print_options): New member print_frame_info.
4248         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4249         * stack.h (get_user_print_what_frame_info): New declaration.
4250         (frame_show_address): New declaration.
4251         * stack.c (print_frame_arguments_choices): New value 'presence'.
4252         (print_frame_info_auto, print_frame_info_source_line,
4253         print_frame_info_location, print_frame_info_source_and_location,
4254         print_frame_info_location_and_address, print_frame_info_short_location,
4255         print_frame_info_choices, print_frame_info_print_what): New definitions.
4256         (print_frame_args): Only print dots for args if print frame-arguments
4257         is 'presence'.
4258         (frame_print_option_defs): New element for "frame-info".
4259         (get_user_print_what_frame_info): New function.
4260         (frame_show_address): Make non static.  Move comment to stack.h.
4261         (print_frame_info_to_print_what): New function.
4262         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4263         to decide what to print.
4264         (backtrace_command_1): Handle the new print_frame_arguments_presence
4265         value.
4266         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4267         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4268         (py_print_frame): In non-mi mode, use LOCATION as default for
4269         print_what, similarly to frame information printed directly by
4270         backtrace command. Handle frame-info user option in non MI mode.
4271
4272 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4273
4274         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4275         Add case for debugging 32-bit target on 64-bit host.  Revise
4276         comment.
4277
4278 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4279
4280         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4281         instead of find_function_entry_range_from_pc.
4282
4283 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4284
4285         * stack.c (find_frame_funname): Remove code which preferred
4286         minsym over symtab sym in "certain pathological cases".
4287
4288         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4289         parameter.  Change type of "do_demangle" to bool.
4290         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4291         Pass suitable "prefer_sym_over_minsym" flag to
4292         build_address_symbolic().  Don't output "+" for negative offsets.
4293         * printcmd.c (print_address_symbolic): Update invocation of
4294         build_address_symbolic to include a "prefer_sym_over_minsym"
4295         flag.
4296         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4297         Restrict cases in which use of minimal symbol is preferred to that
4298         of a found symbol.  Update comments.
4299
4300         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4301         for entry pc when entry pc is out of range for that FDE.
4302
4303 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4304
4305         PR gdb/24839:
4306         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4307         type.
4308
4309 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4310
4311         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4312         this function's Python signature.
4313
4314
4315 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4316
4317         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4318         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4319         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4320         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4321         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4322
4323
4324 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4325
4326         * h8300-tdep.c (h8300_register_name_common): New.
4327         h8300_register_name): Use h8300_register_name_common.
4328         (h8300s_register_name): Likewise.
4329         (h8300sx_register_name): Likewise.
4330         (h8300h_register_nam): New.
4331         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4332
4333
4334 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4335
4336         * arm-tdep.c (arm_skip_cmse_entry): New function.
4337         (arm_is_sgstubs_section): New function.
4338         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4339
4340 2019-07-22  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4343         Don't self-assign.
4344
4345 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4348         type_print.
4349
4350 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4353         so that GDB doesn't match any msymbols when searching in the
4354         TYPES_DOMAIN.
4355         (print_symbol_info): Print using typedef_print or type_print based
4356         on the type of the symbol.  Add updated FIXME comment moved from...
4357         (_initialize_symtab): ... move and update FIXME comment to above.
4358
4359 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * NEWS: Mention adding -q option to "info types".
4362         * symtab.c (struct info_types_options): New struct.
4363         (info_types_options_defs): New variable.
4364         (make_info_types_options_def_group): New function.
4365         (info_types_command): Use gdb::option framework to parse options.
4366         (info_types_command_completer): New function.
4367         (_initialize_symtab): Extend the help text on "info types" and
4368         register command completer.
4369
4370 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4371
4372         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4373         (lookup_symbol_in_objfile): Change int to block_enum and add a
4374         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4375
4376 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4377
4378         * MAINTAINERS (Write After Approval): Add self.
4379
4380 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4381
4382         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4383         instruction to the dummy code region.
4384
4385 2019-07-19  Tom Tromey  <tromey@adacore.com>
4386
4387         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4388         (ARGSUSED, PARAMS, __func__): Remove rules.
4389
4390 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4393         * features/arm/arm-with-iwmmxt.c: Remove.
4394         * features/arm/arm-with-iwmmxt.xml: Remove.
4395         * features/arm/arm-with-m-fpa-layout.c: Remove.
4396         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4397         * features/arm/arm-with-m-vfp-d16.c: Remove.
4398         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4399         * features/arm/arm-with-m.c: Remove.
4400         * features/arm/arm-with-m.xml: Remove.
4401         * features/arm/arm-with-neon.c: Remove.
4402         * features/arm/arm-with-neon.xml: Remove.
4403         * features/arm/arm-with-vfpv2.c: Remove.
4404         * features/arm/arm-with-vfpv2.xml: Remove.
4405         * features/arm/arm-with-vfpv3.c: Remove.
4406         * features/arm/arm-with-vfpv3.xml: Remove.
4407
4408 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4409
4410         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4411
4412 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * arch/aarch32.c (aarch32_create_target_description): Create
4415         target descriptions using features.
4416         * arch/arm.c (arm_create_target_description)
4417         (arm_create_mprofile_target_description): Likewise.
4418         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4419
4420 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4421
4422         * Makefile.in: Add new files.
4423         * aarch32-tdep.c: New file.
4424         * aarch32-tdep.h: New file.
4425         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4426         Call aarch32_read_description.
4427         * arch/aarch32.c: New file.
4428         * arch/aarch32.h: New file.
4429         * arch/arm.c (arm_create_target_description)
4430         (arm_create_mprofile_target_description): New function.
4431         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4432         (arm_create_target_description)
4433         (arm_create_mprofile_target_description): New declaration.
4434         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4435         read_description functions.
4436         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4437         Likewise.
4438         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4439         * arm-tdep.c (tdesc_arm_list): New variable.
4440         (arm_register_g_packet_guesses): Call create description functions.
4441         (arm_read_description) (arm_read_mprofile_description): New
4442         function.
4443         * arm-tdep.h (arm_read_description)
4444         (arm_read_mprofile_description): Add declaration.
4445         * configure.tgt: Add new files.
4446
4447 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4448
4449         * top.c (new_ui_command): Open specified terminal just once.
4450
4451 2019-07-18  Tom Tromey  <tromey@adacore.com>
4452
4453         * symtab.c (main_name): Constify return type.
4454         * symfile.c (set_initial_language): Update.
4455         * symtab.h (main_name): Constify return type.
4456
4457 2019-07-17  Tom Tromey  <tom@tromey.com>
4458
4459         * tui/tui-winsource.c (tui_update_source_window)
4460         (tui_update_source_window_as_is)
4461         (tui_update_source_windows_with_line): Remove return.
4462         * tui/tui-disasm.c (tui_show_disassem)
4463         (tui_show_disassem_and_update_source): Remove return.
4464         * tui/tui.c (tui_reset): Remove return.
4465         * tui/tui-wingeneral.c
4466         (tui_check_and_display_highlight_if_needed): Remove return.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4471
4472 2019-07-17  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-winsource.h (struct tui_exec_info_window)
4475         (struct tui_source_window_base): Move from tui-data.h.
4476         * tui/tui-winsource.c: Move many method definitions from
4477         elsewhere.  Remove "structuring" comments.
4478         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4479         (tui_source_window_base::refresh_window): Move to
4480         tui-winsource.c.
4481         * tui/tui-win.c (tui_source_window_base::refresh_all)
4482         (tui_source_window_base::update_tab_width)
4483         (tui_source_window_base::set_new_height)
4484         (tui_source_window_base::do_make_visible_with_new_height): Move to
4485         tui-winsource.c.
4486         * tui/tui-source.h: Update.
4487         * tui/tui-source.c (tui_source_window_base::reset): Move to
4488         tui-winsource.c.
4489         * tui/tui-disasm.h: Update.
4490         * tui/tui-data.h (struct tui_exec_info_window): Move to
4491         tui-winsource.h.
4492         (struct tui_source_window_base): Likewise.
4493         * tui/tui-data.c (tui_source_window_base::clear_detail)
4494         (tui_source_window_base, ~tui_source_window_base): Move to
4495         tui-winsource.c.
4496
4497 2019-07-17  Tom Tromey  <tom@tromey.com>
4498
4499         * tui/tui-win.c (tui_resize_all)
4500         (tui_source_window_base::update_tab_width)
4501         (tui_adjust_win_heights): Update.
4502         (tui_win_info::make_invisible_and_set_new_height): Rename from
4503         make_invisible_and_set_new_height.
4504         * tui/tui-data.h (struct tui_win_info)
4505         <make_invisible_and_set_new_height>: New method.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui.c: Update.
4510         * tui/tui-source.h (struct tui_source_window): Move from
4511         tui-data.h.
4512         * tui/tui-layout.c: Update.
4513         * tui/tui-disasm.c: Update.
4514         * tui/tui-data.h (struct tui_source_window): Move to
4515         tui-source.h.
4516
4517 2019-07-17  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4520         tui-data.h.
4521         * tui/tui-data.h (struct tui_disasm_window): Move to
4522         tui-disasm.h.
4523
4524 2019-07-17  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-regs.h (struct tui_data_item_window): Move from
4527         tui-data.h.
4528         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4529         * tui/tui-data.h (struct tui_data_item_window): Move to
4530         tui-regs.h.
4531         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4532
4533 2019-07-17  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui.c: Update.
4536         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4537         (tui_cmd_window::max_height): Move to tui-command.c.
4538         * tui/tui-layout.c: Update.
4539         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4540         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4541         tui-command.c.
4542         * tui/tui-command.h (struct tui_cmd_window): Move from
4543         tui-data.h.
4544         * tui/tui-command.c: Remove "structuring" comments.
4545         (tui_cmd_window::clear_detail)
4546         (tui_cmd_window::do_make_visible_with_new_height)
4547         (tui_cmd_window::max_height): Move from elsewhere.
4548
4549 2019-07-17  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4552         Now static.
4553         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4554         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4555
4556 2019-07-17  Tom Tromey  <tom@tromey.com>
4557
4558         * tui/tui.c: Update.
4559         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4560         tui-regs.c.
4561         * tui/tui-windata.h: Remove file.
4562         * tui/tui-windata.c: Remove file.
4563         * tui/tui-win.c (tui_data_window::set_new_height)
4564         (tui_data_window::do_make_visible_with_new_height): Move to
4565         tui-regs.c.
4566         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4567         * tui/tui-regs.c: Remove "structuring" comments.
4568         (tui_data_window::first_data_item_displayed)
4569         (tui_data_window::delete_data_content_windows)
4570         (tui_data_window::erase_data_content)
4571         (tui_data_window::display_all_data)
4572         (tui_data_window::refresh_all)
4573         (tui_data_window::do_scroll_vertical)
4574         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4575         (tui_data_window::do_make_visible_with_new_height)
4576         (tui_data_window::refresh_window): Move from elsewhere.
4577         (_initialize_tui_regs): Move to end of file.
4578         * tui/tui-layout.c: Update.
4579         * tui/tui-hooks.c: Update.
4580         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4581         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4582         tui-regs.c.
4583         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4584
4585 2019-07-17  Tom Tromey  <tom@tromey.com>
4586
4587         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4588         seen.
4589
4590 2019-07-17  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-win.c (tui_source_window_base::set_new_height)
4593         (tui_source_window_base::do_make_visible_with_new_height): Use
4594         m_has_locator field directly.
4595         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4596         method.
4597         (struct tui_source_window_base) <has_locator>: Likewise.
4598
4599 2019-07-17  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4602         Don't declare.
4603         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4604         Remove.
4605         * tui/tui-win.c (tui_source_window_base::set_new_height)
4606         (tui_source_window_base::set_new_height)
4607         (make_invisible_and_set_new_height)
4608         (tui_source_window_base::do_make_visible_with_new_height)
4609         (tui_source_window_base::do_make_visible_with_new_height):
4610         Update.
4611         * tui/tui-layout.c (show_source_disasm_command, show_data)
4612         (show_source_or_disasm_and_command): Update.
4613         * tui/tui-layout.c (show_layout): Update.
4614
4615 2019-07-17  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-layout.c (make_data_window): Remove.
4618         (show_data): Unify creation and re-initialization cases.
4619
4620 2019-07-17  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-layout.c (make_source_window, make_disasm_window):
4623         Remove.
4624         (show_data): Unify creation and re-initialization cases.
4625
4626 2019-07-17  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-layout.c (make_command_window): Remove.
4629         (show_source_disasm_command, show_source_or_disasm_and_command):
4630         Unify creation and re-initialization cases.
4631
4632 2019-07-17  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4635         creation and re-initialization cases.
4636
4637 2019-07-17  Tom Tromey  <tom@tromey.com>
4638
4639         * tui/tui-regs.c (tui_get_register): Return void.
4640
4641 2019-07-17  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4644         Simplify.
4645
4646 2019-07-17  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4649         resetting.
4650
4651 2019-07-17  Tom Tromey  <tom@tromey.com>
4652
4653         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4654         * tui/tui-regs.c (tui_reg_layout): New function.
4655         (tui_show_registers, tui_reg_command): Use it.
4656         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4657         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4658         parameters.
4659         (tui_layout_command): Remove.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-layout.h (tui/tui-layout): Return void.
4664         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4665
4666 2019-07-17  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-layout.c (show_source_disasm_command, show_data):
4669         Update.
4670         (reset_locator): Remove.
4671         (show_source_or_disasm_and_command): Update.
4672
4673 2019-07-17  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-source.c (tui_source_window_base::reset): Remove
4676         win_type parameter.
4677         * tui/tui-layout.c (make_command_window, make_source_window)
4678         (make_disasm_window, make_data_window)
4679         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4680         (reset_locator, show_source_or_disasm_and_command): Update.
4681         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4682         win_type parameter.
4683         (struct tui_source_window_base) <reset>: Likewise.
4684
4685 2019-07-17  Tom Tromey  <tom@tromey.com>
4686
4687         * tui/tui-layout.c (show_source_disasm_command): Use
4688         reset_locator.
4689         (reset_locator): New function.
4690         (init_and_make_win): Remove.
4691         (show_source_or_disasm_and_command): Use reset_locator.
4692
4693 2019-07-17  Tom Tromey  <tom@tromey.com>
4694
4695         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4696         condition.
4697         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4698         Remove condition.
4699         * tui/tui-source.c (tui_source_window_base::reset): New method.
4700         * tui/tui-layout.c (make_command_window): Don't call
4701         init_and_make_win.
4702         (make_source_window, make_disasm_window): Don't call
4703         make_source_or_disasm_window.
4704         (make_data_window): Don't call init_and_make_win.  Change calling
4705         convention.
4706         (show_source_disasm_command, show_data): Simplify.
4707         (make_source_or_disasm_window): Remove.
4708         (show_source_or_disasm_and_command): Simplify.
4709         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4710         (struct tui_source_window_base) <reset>: Likewise.
4711         <execution_info>: Remove initializer.
4712         * tui/tui-data.c (tui_source_window_base): Initialize
4713         execution_info.
4714
4715 2019-07-17  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4718         variable.
4719
4720 2019-07-17  Tom Tromey  <tom@tromey.com>
4721
4722         * tui/tui.c (tui_rl_other_window): Update.
4723         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4724         superclass method first.  Always iterate over regs_content.
4725         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4726         method.
4727         * tui/tui-win.c (tui_set_focus_command): Update.
4728
4729 2019-07-17  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-win.c (tui_set_focus_command): Rename from
4732         tui_set_focus.  Call tui_enable.
4733         (tui_set_focus_command): Remove.
4734
4735 2019-07-17  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4738         refresh_window.
4739         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4740         touchwin.
4741         (tui_data_window::refresh_window): Call refresh_window on data
4742         items.  Always call superclass refresh_window.
4743         (tui_win_info::refresh): Remove.
4744         (tui_source_window_base::refresh_window): Update.
4745         (tui_refresh_all): Update.
4746         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4747         refresh_window.
4748         (show_source_or_disasm_and_command): Likewise.
4749         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4750         (struct tui_source_window_base) <refresh>: Likewise.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-winsource.c (tui_clear_source_content)
4755         (tui_show_source_content): Update.
4756         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4757         whether content is empty.
4758         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4759         Remove.
4760
4761 2019-07-17  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4764         window's contents.
4765         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4766         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4767
4768 2019-07-17  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4771         (struct tui_data_item_window): Update.
4772
4773 2019-07-17  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4776         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4777         defines.
4778
4779 2019-07-17  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-winsource.h (tui_erase_source_content)
4782         (tui_clear_source_content): Remove "display_prompt" parameter.
4783         * tui/tui-winsource.c (tui_update_source_window_as_is)
4784         (tui_update_source_windows_with_addr): Update.
4785         (tui_clear_source_content): Remove "display_prompt" parameter.
4786         (tui_erase_source_content): Likewise.  Simplify.
4787         (tui_show_source_content): Update.
4788         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4789         * tui/tui-stack.c (tui_show_frame_info): Update.
4790         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4791         Remove defines.
4792
4793 2019-07-17  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4796         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4797         parameter.
4798         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4799         parameter.
4800
4801 2019-07-17  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-winsource.c (tui_clear_source_content)
4804         (tui_show_source_content, tui_show_exec_info_content)
4805         (tui_clear_exec_info_content): Update.
4806         * tui/tui-stack.c (tui_show_locator_content): Update.
4807         (tui_show_frame_info): Update.
4808         * tui/tui-source.h (tui_source_window): Don't declare.
4809         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4810         from tui_source_is_displayed.
4811         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4812         Remove field.
4813         (struct tui_source_window_base) <content_in_use>: New field.  Now
4814         bool.
4815         (struct tui_source_window) <showing_source_p>: New method.
4816         (TUI_SRC_WIN): Change cast.
4817         * tui/tui-data.c (tui_initialize_static_data): Update.
4818
4819 2019-07-17  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4822         location_matches_p.
4823         * tui/tui-source.c (tui_source_window::location_matches_p): New
4824         method.
4825         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4826         method.
4827         * tui/tui-data.h (struct tui_source_window_base)
4828         <location_matches_p>: New method.
4829         (struct tui_source_window, struct tui_disasm_window)
4830         <location_matches_p>: Likewise.
4831
4832 2019-07-17  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-win.c (tui_set_win_height_command): Rename from
4835         tui_set_win_height.
4836         (tui_set_win_height_command): Remove.
4837
4838 2019-07-17  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-source.c (tui_source_window): New constructor.  Add
4841         observer.
4842         (~tui_source_window): New destructor.
4843         (tui_source_window::style_changed): New method.
4844         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4845         (tui_attach_detach_observers): Update.
4846         * tui/tui-data.h (struct tui_source_window): Make constructor not
4847         inline.  Add destructor.
4848         (struct tui_source_window) <style_changed>: New method.
4849         <m_observable>: New member.
4850
4851 2019-07-17  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4854         * tui/tui-win.c (tui_resize_all): Fix typo.
4855
4856 2019-07-17  Tom Tromey  <tom@tromey.com>
4857
4858         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4859         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4860         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4861         * tui/tui-win.c (window_name_completer): Use foreach.
4862         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4863         (update_tab_width): Likewise.
4864         * tui/tui-layout.c (show_layout): Update.
4865         * tui/tui-data.h (class tui_window_iterator): New.
4866         (struct all_tui_windows): New.
4867         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4868
4869 2019-07-17  Tom Tromey  <tom@tromey.com>
4870
4871         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4872         parameter.  Don't reference globals.
4873         (tui_reg_command): Update.
4874
4875 2019-07-17  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-regs.c (tui_show_registers): Simplify.
4878
4879 2019-07-17  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-regs.c (tui_show_registers): Update.
4882         (tui_show_register_group): Add win_info parameter.
4883
4884 2019-07-17  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4887         Rename from tui_display_reg_element_at_line.
4888         (tui_data_window::display_registers_from_line): Update.
4889         * tui/tui-data.h (struct tui_data_window)
4890         <display_reg_element_at_line>: New method.
4891
4892 2019-07-17  Tom Tromey  <tom@tromey.com>
4893
4894         * tui/tui-regs.h (tui_display_registers_from)
4895         (tui_display_registers_from_line): Don't declare.
4896         * tui/tui-windata.c (tui_data_window::display_all_data)
4897         (tui_data_window::refresh_all)
4898         (tui_data_window::do_scroll_vertical): Update.
4899         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4900         from tui_display_registers_from.
4901         (tui_display_reg_element_at_line): Update.
4902         (tui_data_window::display_registers_from_line): Rename from
4903         tui_display_registers_from_line.
4904         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4905         display_registers_from_line>: New methods.
4906
4907 2019-07-17  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4910         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4911         from tui_erase_data_content.
4912         (tui_data_window::display_all_data)
4913         (tui_data_window::refresh_all)
4914         (tui_data_window::do_scroll_vertical): Update.
4915         * tui/tui-regs.c (tui_show_registers): Update.
4916         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4917         New method.
4918
4919 2019-07-17  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4922         declare.
4923         * tui/tui-windata.c
4924         (tui_data_window::delete_data_content_windows): Rename from
4925         tui_delete_data_content_windows.
4926         (tui_data_window::display_all_data)
4927         (tui_data_window::do_scroll_vertical): Update.
4928         * tui/tui-data.h (struct tui_data_window)
4929         <delete_data_content_windows>: New method.
4930
4931 2019-07-17  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4934         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4935
4936 2019-07-17  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4939         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4940         from tui_display_all_data.
4941         * tui/tui-win.c
4942         (tui_data_window::do_make_visible_with_new_height): Update.
4943         * tui/tui-regs.c (tui_show_registers): Update.
4944         * tui/tui-layout.c (tui_set_layout): Update.
4945         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4946         method.
4947
4948 2019-07-17  Tom Tromey  <tom@tromey.com>
4949
4950         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4951         * tui/tui-windata.c (tui_display_data_from): Remove.
4952         (tui_data_window::refresh_all): Update.
4953
4954 2019-07-17  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4957         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4958         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4959         tui_display_registers_from_line.
4960         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4961         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4962         "force_display" parameter.
4963
4964 2019-07-17  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4967         declare.
4968         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4969         Rename from tui_first_reg_element_no_inline.
4970         (tui_display_reg_element_at_line)
4971         (tui_display_registers_from_line): Update.
4972         * tui/tui-data.h (struct tui_data_window)
4973         <first_reg_element_no_inline>: New method.
4974
4975 2019-07-17  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-windata.c (tui_display_data_from)
4978         (tui_data_window::do_scroll_vertical): Update.
4979         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4980         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4981         Rename from tui_line_from_reg_element_no.
4982         (tui_display_registers_from_line): Update.
4983         * tui/tui-data.h (struct tui_data_window)
4984         <line_from_reg_element_no>: New method.
4985
4986 2019-07-17  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4989         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4990         tui_last_regs_line_no.
4991         (tui_display_reg_element_at_line)
4992         (tui_display_registers_from_line): Update.
4993         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4994         method.
4995
4996 2019-07-17  Tom Tromey  <tom@tromey.com>
4997
4998         PR tui/24722:
4999         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5000         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5001         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5002         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5003         (tui_update_breakpoint_info): Likewise.
5004         * tui/tui-hooks.c (tui_event_create_breakpoint)
5005         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5006         Update.
5007
5008 2019-07-17  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5011
5012 2019-07-17  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui-winsource.c (tui_update_source_window_as_is)
5015         (tui_update_source_windows_with_addr): Update.
5016         * tui/tui-source.h (tui_set_source_content)
5017         (tui_show_symtab_source): Add "win_info" parameter.
5018         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5019         parameter.
5020         (tui_show_symtab_source): Likewise.
5021
5022 2019-07-17  Tom Tromey  <tom@tromey.com>
5023
5024         * tui/tui-wingeneral.c
5025         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5026
5027 2019-07-17  Tom Tromey  <tom@tromey.com>
5028
5029         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5030         (struct tui_cmd_window) <can_scroll>: New method.
5031         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5032         method.
5033
5034 2019-07-17  Tom Tromey  <tromey@adacore.com>
5035
5036         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5037         do_field_signed>: Rename.  Change type of "value".
5038         * ui-out.c (ui_out::field_signed): Rename from field_int.
5039         Change type of "value".
5040         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5041         type of "value".
5042         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5043         do_field_int.  Change type of "value".
5044         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5045         do_field_int.  Change type of "value".
5046         * tracepoint.c (trace_status_mi, tfind_1)
5047         (print_one_static_tracepoint_marker): Update.
5048         * thread.c (print_thread_info_1, print_selected_thread_frame):
5049         Update.
5050         * stack.c (print_frame, print_frame_info): Update.
5051         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5052         Update.
5053         * source.c (print_source_lines_base): Update.
5054         * skip.c (info_skip_command): Update.
5055         * record-btrace.c (btrace_ui_out_decode_error)
5056         (btrace_call_history_src_line): Update.
5057         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5058         Update.
5059         * progspace.c (print_program_space): Update.
5060         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5061         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5062         do_field_int.  Change type of "value".
5063         * mi/mi-out.c (mi_ui_out::do_table_begin)
5064         (mi_ui_out::do_table_header): Update.
5065         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5066         type of "value".
5067         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5068         (mi_cmd_data_list_changed_registers, output_register)
5069         (mi_cmd_data_read_memory, mi_load_progress)
5070         (mi_cmd_trace_frame_collected): Update.
5071         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5072         Update.
5073         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5074         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5075         (mi_cmd_var_list_children, varobj_update_one): Update.
5076         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5077         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5078         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5079         * inferior.c (print_inferior): Update.
5080         * gdb_bfd.c (print_one_bfd): Update.
5081         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5082         Update.
5083         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5084         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5085         do_field_int.  Change type of "value".
5086         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5087         do_field_int.  Change type of "value".
5088         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5089         (print_one_breakpoint_location, print_it_catch_fork)
5090         (print_one_catch_fork, print_it_catch_vfork)
5091         (print_one_catch_vfork, print_it_catch_solib)
5092         (print_it_catch_exec, print_it_ranged_breakpoint)
5093         (print_mention_watchpoint, print_mention_masked_watchpoint)
5094         (bkpt_print_it, update_static_tracepoint): Update.
5095         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5096         * break-catch-syscall.c (print_it_catch_syscall): Update.
5097         * ada-tasks.c (print_ada_task_info): Update.
5098         * ada-lang.c (print_it_exception, print_mention_exception):
5099         Update.
5100
5101 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         PR breakpoints/24541
5104         * gdbarch.c: Regenerate.
5105         * gdbarch.h: Regenerate.
5106         * gdbarch.sh: Adjust return type and parameter types for
5107         'stap_adjust_register'.
5108         (i386_stap_adjust_register): Adjust signature and return new
5109         register name.
5110         * stap-probe.c (stap_parse_register_operand): Adjust use of
5111         'gdbarch_stap_adjust_register'.
5112
5113 2019-07-17  Tom Tromey  <tromey@adacore.com>
5114
5115         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5116         declare VEC.
5117         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5118         std::vector.
5119         (struct s390_process_info): Add initializers.
5120         (s390_add_process): Use new.
5121         (s390_linux_nat_target::low_forget_process): Use delete.
5122         (s390_linux_nat_target::low_new_fork)
5123         (s390_linux_nat_target::stopped_by_watchpoint)
5124         (s390_linux_nat_target::low_prepare_to_resume)
5125         (s390_linux_nat_target::insert_watchpoint)
5126         (s390_linux_nat_target::insert_hw_breakpoint)
5127         (s390_linux_nat_target::remove_watchpoint)
5128         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5129
5130 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5131
5132         * aarch64-fbsd-nat.c: Include regcache.h.
5133         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5134         argument.
5135         (aarch64_fbsd_nat_target::fetch_registers)
5136         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5137         variable.
5138         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5139
5140 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5141
5142         * fbsd-nat.c: Include gdbarch.h.
5143
5144 2019-07-15  Tom Tromey  <tromey@adacore.com>
5145
5146         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5147
5148 2019-07-15  Tom Tromey  <tromey@adacore.com>
5149
5150         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5151         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5152         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5153         * cli-out.c (cli_ui_out::do_field_int): New method.
5154         * ui-out.c (ui_out::field_unsigned): New method.
5155         * symfile.c (generic_load): Use field_unsigned.
5156         (print_transfer_performance): Likewise.
5157         * record-btrace.c (ui_out_field_uint): Remove.
5158         (btrace_call_history_insn_range, btrace_call_history): Use
5159         field_unsigned.
5160         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5161         field_unsigned.
5162         * ui-out.h (class ui_out) <field_unsigned>: New method.
5163         <do_field_unsigned>: Likewise.
5164
5165 2019-07-15  Tom Tromey  <tromey@adacore.com>
5166
5167         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5168         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5169         * target.c (flash_erase_command): Use field_string.
5170         * infrun.c (print_signal_received_reason): Use field_string.
5171         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5172         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5173         field_string.
5174         * ada-tasks.c (print_ada_task_info): Use field_string.
5175
5176 2019-07-15  Tom Tromey  <tromey@adacore.com>
5177
5178         * target.c (flash_erase_command): Use field_core_addr.
5179         * symfile.c (generic_load): Use field_core_addr.
5180         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5181         Use field_core_addr.
5182         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5183         field_core_addr.
5184
5185 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5188         value if its desired type is smaller than a CORE_ADDR and signed.
5189
5190 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5191
5192         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5193         of changes to field names, and use new is_reference field to
5194         decide if a property is a reference or not.
5195         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5196         field.
5197         (struct dwarf2_property_baton): Update header comment, rename
5198         'referenced_type' to 'property_type' and update comments.
5199         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5200         default property type, store in property baton, update to take
5201         accound of renamed field.
5202         (read_func_scope): Update call to attr_to_dynamic_prop.
5203         (read_array_type): Likewise.
5204         (dwarf2_per_cu_addr_sized_int_type): New function.
5205         (read_subrange_index_type): Move type finding code to
5206         dwarf2_per_cu_addr_sized_int_type.
5207         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5208         (dwarf2_per_cu_addr_type): New function.
5209         (set_die_type): Update calls to attr_to_dynamic_prop.
5210
5211 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * dwarf2read.c (read_subrange_index_type): New function.
5214         (read_subrange_type): Move code into new function and call it.
5215         * gdbtypes.c (create_range_type): Add some asserts.
5216
5217 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5220         update return statements.
5221         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5222         declaration, and update comment to match.
5223         * gdbtypes.c (resolve_dynamic_array): Update call to
5224         dwarf2_evaluate_property to match new return type.
5225
5226 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * valarith.c (value_subscripted_rvalue): Change lowerbound
5229         parameter type from int to LONGEST.
5230         * value.h (value_subscripted_rvalue): Likewise in declaration.
5231
5232 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * cli/cli-utils.c (info_print_command_completer): New function.
5235         * cli/cli-utils.h: Add 'completer.h' include, and forward
5236         declaration for 'struct cmd_list_element'.
5237         (info_print_command_completer): Declare.
5238         * stack.c (_initialize_stack): Add completer for 'info locals' and
5239         'info args'.
5240         * symtab.c (_initialize_symtab): Add completer for 'info
5241         variables' and 'info functions'.
5242         * NEWS: Mention completion for additional info commands.
5243
5244 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * cli/cli-utils.c (extract_info_print_args): Delete.
5247         (extract_arg_maybe_quoted): Delete.
5248         (info_print_options_defs): New variable.
5249         (make_info_print_options_def_group): New function.
5250         (extract_info_print_options): Define new function.
5251         * cli/cli-utils.h (extract_info_print_args): Delete.
5252         (struct info_print_options): New structure.
5253         (extract_info_print_options): Declare new function.
5254         * stack.c (info_locals_command): Update to use new
5255         extract_info_print_options, also add a header comment.
5256         (info_args_command): Likewise.
5257         * symtab.c (info_variables_command): Likewise.
5258         (info_functions_command): Likewise.
5259
5260 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5263         to extract string arguments.
5264         * common/common-utils.c (extract_string_maybe_quoted): New function.
5265         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5266
5267 2019-07-11  Tom Tromey  <tromey@adacore.com>
5268
5269         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5270         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5271         * top.h (gdbinit): Don't declare.
5272         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5273         into...
5274         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5275         * top.c (gdb_init): Don't call init_cli_cmds.
5276         (gdbinit): Remove.
5277         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5278
5279 2019-07-11  Tom Tromey  <tromey@adacore.com>
5280
5281         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5282         after it has been moved.
5283
5284 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5285
5286         * valops.c (value_must_coerce_to_target): Change return type to
5287         bool.
5288         * value.h (value_must_coerce_to_target): Likewise.
5289
5290 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5291
5292         * breakpoint.c (is_hardware_watchpoint): Remove
5293         forward-declaration.
5294         (is_masked_watchpoint): Change return type to bool.
5295         (is_tracepoint): Likewise.
5296         (is_breakpoint): Likewise.
5297         (is_hardware_watchpoint): Likewise.
5298         (is_watchpoint): Likewise.
5299         (is_no_memory_software_watchpoint): Likewise.
5300         (is_catchpoint): Likewise.
5301         (breakpoint_1): Make FILTER parameter's return type bool.
5302         is_masked_watchpoint): Change return type to bool.
5303         (save_breakpoints): Make FILTER parameter's return type bool.
5304         * breakpoint.h (is_breakpoint): Change return type to bool.
5305         (is_watchpoint): Likewise.
5306         (is_catchpoint): Likewise.
5307         (is_tracepoint): Likewise.
5308
5309 2019-07-10  Tom Tromey  <tom@tromey.com>
5310
5311         * defs.h: Don't include gdbarch.h.
5312         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5313         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5314         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5315         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5316         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5317         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5318         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5319         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5320         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5321         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5322         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5323         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5324         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5325         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5326         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5327         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5328         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5329         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5330         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5331         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5332         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5333         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5334         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5335         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5336         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5337         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5338         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5339
5340 2019-07-10  Tom Tromey  <tromey@adacore.com>
5341
5342         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5343         * breakpoint.c (init_ada_exception_breakpoint): Register as
5344         bp_catchpoint.
5345         (print_one_breakpoint_location, print_one_breakpoint): Use
5346         is_ada_exception_catchpoint.
5347         * ada-lang.c (class ada_catchpoint_location): Pass
5348         bp_loc_software_breakpoint to bp_location constructor.
5349         (is_ada_exception_catchpoint): New function.
5350
5351 2019-07-10  Tom Tromey  <tromey@adacore.com>
5352
5353         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5354         VEC.
5355         (struct arm_exidx_entry): New method operator<.
5356         (struct arm_exidx_data) <section_maps>: Change type.
5357         (arm_exidx_data_free): Remove.
5358         (arm_exidx_data_key): Change type.  Move lower.
5359         (arm_exidx_new_objfile): Update.
5360         (arm_compare_exidx_entries): Remove.
5361         (arm_find_exidx_entry, _initialize_arm_tdep)
5362
5363 2019-07-10  Tom Tromey  <tromey@adacore.com>
5364
5365         * solib-spu.c (ocl_program_data_key): Change type.
5366         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5367         Update.
5368
5369 2019-07-10  Tom Tromey  <tromey@adacore.com>
5370
5371         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5372         (struct solib_aix_inferior_data) <library_list>: Change type.
5373         (solib_aix_inferior_data_handle): Change type.
5374         (get_solib_aix_inferior_data): Update.
5375         (solib_aix_free_library_list): Remove.
5376         (library_list_start_library): Update.
5377         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5378         return type.
5379         (solib_aix_get_library_list)
5380         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5381         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5382
5383 2019-07-10  Tom Tromey  <tromey@adacore.com>
5384
5385         * solib-dsbt.c (struct dsbt_info): Add initializers.
5386         (solib_dsbt_pspace_data): Change type.
5387         (dsbt_pspace_data_cleanup): Remove.
5388         (get_dsbt_info, _initialize_dsbt_solib): Update.
5389
5390 2019-07-10  Tom Tromey  <tromey@adacore.com>
5391
5392         * spu-tdep.c (spu_overlay_data): Change type.
5393         (spu_get_overlay_table, spu_overlay_new_objfile)
5394         (_initialize_spu_tdep): Update.
5395
5396 2019-07-10  Tom Tromey  <tromey@adacore.com>
5397
5398         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5399         destructor.
5400         (dbx_objfile_data_key): Change type and declare later.
5401         (DBX_SYMFILE_INFO): Rewrite.
5402         * dbxread.c (dbx_objfile_data_key): Change type.
5403         (dbx_symfile_init): Update.
5404         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5405         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5406         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5407
5408 2019-07-10  Tom Tromey  <tromey@adacore.com>
5409
5410         * jit.c (jit_program_space_key): Change type.  Move lower.
5411         (get_jit_program_space_data): Update.
5412         (jit_program_space_data_cleanup): Remove.
5413         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5414         Update.
5415         (struct jit_program_space_data): Add initializers.
5416
5417 2019-07-10  Tom Tromey  <tromey@adacore.com>
5418
5419         * solib-darwin.c (struct darwin_info): Add initializers.
5420         (solib_darwin_pspace_data): Change type.
5421         (darwin_pspace_data_cleanup): Remove.
5422         (get_darwin_info, _initialize_darwin_solib): Update.
5423
5424 2019-07-10  Tom Tromey  <tromey@adacore.com>
5425
5426         * remote-sim.c (struct sim_inferior_data): Add initializers,
5427         constructor, and destructor.
5428         (sim_inferior_data_key): Change type.  Move lower.
5429         (check_for_duplicate_sim_descriptor): Update.
5430         (get_sim_inferior_data): Use new.  Update.
5431         (~sim_inferior_data_cleanup): Rename from
5432         sim_inferior_data_cleanup.  Simplify.
5433         (gdbsim_close_inferior, simulator_command)
5434         (sim_command_completer, _initialize_remote_sim): Update.
5435         (next_pid, INITIAL_PID): Move earlier.
5436
5437 2019-07-10  Tom Tromey  <tromey@adacore.com>
5438
5439         * python/python-internal.h (create_thread_object): Return
5440         gdbpy_ref.
5441         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5442         * python/py-inferior.c (struct threadlist_entry): Add
5443         constructor.
5444         <thread_obj>: Now a gdbpy_ref.
5445         (thread_to_thread_object): Update.
5446         (add_thread_object): Use new.
5447         (delete_thread_object): Use delete.
5448         (infpy_threads): Update.
5449         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5450         GIL.
5451
5452 2019-07-10  Tom Tromey  <tromey@adacore.com>
5453
5454         * valops.c (value_cast): Specialize error message for Ada.
5455
5456 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5457
5458         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5459
5460 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5461
5462         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5463         bpstat_should_step): Return bool, adjust comments.
5464         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5465         bpstat_should_step): Likewise.
5466
5467 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5468
5469         * features/Makefile: Use feature target descriptions for Arm.
5470         * features/arm/arm-core.c: Generate new file.
5471         * features/arm/arm-fpa.c: Likewise.
5472         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5473         * features/arm/arm-m-profile.c: Likewise.
5474         * features/arm/arm-vfpv2.c: Likewise.
5475         * features/arm/arm-vfpv3.c: Likewise.
5476         * features/arm/xscale-iwmmxt.c: Likewise.
5477         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5478
5479 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5480
5481         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5482         ptrace earlier.
5483
5484 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5485
5486         * features/aarch64-pauth.c: Regenerate.
5487
5488 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5489
5490         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5491         bool.
5492         (bpstat_what): Use false instead of 0.
5493
5494 2019-07-09  Pedro Alves  <palves@redhat.com>
5495
5496         * break-catch-throw.c (is_exception_catchpoint): New.
5497         * breakpoint.c (print_one_breakpoint_location): New parameter
5498         'raw_loc'.  Handle it.  Use
5499         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5500         looking at the breakpoint's type.
5501         (print_one_breakpoint): If handling "maint info breakpoints", also
5502         print locations of exception catchpoints.
5503         * breakpoint.h (is_exception_catchpoint): Declare.
5504
5505 2019-07-09  Pedro Alves  <palves@redhat.com>
5506
5507         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5508         "addr" field.
5509         (allocate_location_exception_catchpoint): New.
5510         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5511         (initialize_throw_catchpoint_ops): Install
5512         allocate_location_exception_catchpoint as allocate_location
5513         method.
5514         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5515         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5516         bp_loc_other.
5517         (breakpoint_address_is_meaningful): Delete.
5518         (bl_address_is_meaningful): New.
5519         (breakpoint_locations_match): Adjust comment.
5520         (bp_location_from_bp_type): New, factored out of...
5521         (bp_location::bp_location(breakpoint *)): ... this.
5522         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5523         factored out of...
5524         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5525         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5526         breakpoint_address_is_meaningful.
5527         (bp_locations_compare): Adjust comment.
5528         (update_global_location_list): Use bl_address_is_meaningful
5529         instead of breakpoint_address_is_meaningful.
5530         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5531         explicit.
5532         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5533         * python/py-breakpoint.c (bppy_get_location): No longer check
5534         whether location is null.
5535
5536 2019-07-09  Pedro Alves  <palves@redhat.com>
5537
5538         PR c++/15468
5539         * breakpoint.c (print_one_breakpoint_location): Remove
5540         single-location assert.
5541
5542 2019-07-09  Tom Tromey  <tom@tromey.com>
5543
5544         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5545         * configure: Rebuild.
5546         * configure.ac: Change common to gdbsupport.
5547         * gdbsupport: Rename from common.
5548         * acinclude.m4: Change common to gdbsupport.
5549         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5550         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5551         gdbsupport.
5552         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5553         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5554         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5555         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5556         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5557         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5558         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5559         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5560         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5561         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5562         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5563         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5564         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5565         coff-pe-read.c, command.h, compile/compile-c-support.c,
5566         compile/compile-c.h, compile/compile-cplus-symbols.c,
5567         compile/compile-cplus-types.c, compile/compile-cplus.h,
5568         compile/compile-loc2c.c, compile/compile.c, completer.c,
5569         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5570         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5571         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5572         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5573         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5574         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5575         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5576         features/aarch64-core.c, features/aarch64-fpu.c,
5577         features/aarch64-pauth.c, features/aarch64-sve.c,
5578         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5579         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5580         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5581         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5582         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5583         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5584         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5585         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5586         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5587         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5588         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5589         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5590         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5591         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5592         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5593         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5594         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5595         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5596         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5597         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5598         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5599         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5600         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5601         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5602         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5603         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5604         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5605         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5606         minsyms.c, mips-linux-tdep.c, namespace.h,
5607         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5608         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5609         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5610         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5611         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5612         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5613         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5614         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5615         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5616         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5617         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5618         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5619         procfs.c, producer.c, progspace.h, psymtab.h,
5620         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5621         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5622         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5623         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5624         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5625         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5626         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5627         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5628         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5629         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5630         target-memory.c, target.c, target.h, target/waitstatus.c,
5631         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5632         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5633         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5634         unittests/array-view-selftests.c,
5635         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5636         unittests/common-utils-selftests.c,
5637         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5638         unittests/format_pieces-selftests.c,
5639         unittests/function-view-selftests.c,
5640         unittests/lookup_name_info-selftests.c,
5641         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5642         unittests/mkdir-recursive-selftests.c,
5643         unittests/observable-selftests.c,
5644         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5645         unittests/parse-connection-spec-selftests.c,
5646         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5647         unittests/scoped_fd-selftests.c,
5648         unittests/scoped_mmap-selftests.c,
5649         unittests/scoped_restore-selftests.c,
5650         unittests/string_view-selftests.c, unittests/style-selftests.c,
5651         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5652         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5653         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5654         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5655         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5656         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5657
5658 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5659
5660         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5661         bool value.
5662         (decode_digits_ordinary): Set explicit_line field in sal.
5663         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5664         symtab_and_line that was set on an explicit line number in
5665         assembler code.  Do always update the recorded symtab and line if
5666         we do skip the prologue.
5667
5668 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * breakpoint.c (set_breakpoint_location_function): Remove
5671         explicit_loc parameter.
5672         (momentary_breakpoint_from_master): Update call to
5673         set_breakpoint_location_function.
5674         (add_location_to_breakpoint): Likewise.
5675
5676 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5679         required features based on default bfd type when no specific bfd
5680         is present.
5681
5682 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5683
5684         * NEWS: Mention that GDB printf and eval commands can now print
5685         C-style and Ada-style convenience var strings without
5686         calling the inferior.
5687         * printcmd.c (printf_c_string): Locally print GDB internal var
5688         instead of transiting via the inferior.
5689         (printf_wide_c_string): Likewise.
5690
5691 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5692
5693         PR breakpoints/25011
5694         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5695
5696 2019-07-04  Tom Tromey  <tom@tromey.com>
5697
5698         PR tui/24724:
5699         * tui/tui-winsource.c (tui_clear_source_content): Update.
5700         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5701         (tui_update_breakpoint_info): Update.
5702         (tui_set_exec_info_content): Update.
5703         * tui/tui-source.c (tui_set_source_content_nil): Update.
5704         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5705         has_break.
5706         * tui/tui-data.h (enum tui_bp_flag): New.
5707         (tui_bp_flags): New enum flags type.
5708         (struct tui_source_element) <break_mode>: Change type.  Rename
5709         from has_break.
5710         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5711         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5712         constants.
5713         * tui/tui-winsource.h: Fix comment.
5714
5715 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5716
5717         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5718         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5719         (store_fpregs_to_thread)
5720         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5721         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5722         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5723         (IWMMXT_REGS_SIZE): Add define.
5724         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5725         (fetch_vfp_regs, store_vfp_regs)
5726         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5727         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5728
5729 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5730
5731         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5732         defines.
5733         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5734         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5735         (ARM_INT_REGISTER_SIZE): ...to this.
5736         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5737         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5738         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5739         (arm_linux_collect_gregset, supply_nwfpe_register)
5740         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5741         defines.
5742         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5743         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5744         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5745         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5746         (arm_return_in_memory, arm_store_return_value)
5747         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5748         (arm_record_ld_st_multiple): Likewise.
5749         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5750         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5751
5752 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5753
5754         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5755         AARCH64_DISPLACED_MODIFIED_INSNS.
5756         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5757         (aarch64_displaced_step_copy_insn): Likewise.
5758         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5759         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5760         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5761         ARM_DISPLACED_MODIFIED_INSNS.
5762         * arm-tdep.c (arm_gdbarch_init): Likewise.
5763         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5764         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5765         (struct arm_displaced_step_closure): Use
5766         ARM_DISPLACED_MODIFIED_INSNS.
5767
5768 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5769
5770         * features/Makefile: Remove unused xml files.
5771         * features/aarch64.xml: Remove.
5772         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5773         * features/i386/amd64-avx-avx512.xml: Remove.
5774         * features/i386/amd64-avx-linux.xml: Remove.
5775         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5776         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5777         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5778         * features/i386/amd64-avx-mpx.xml: Remove.
5779         * features/i386/amd64-avx.xml: Remove.
5780         * features/i386/amd64-linux.xml: Remove.
5781         * features/i386/amd64-mpx-linux.xml: Remove.
5782         * features/i386/amd64-mpx.xml: Remove.
5783         * features/i386/amd64.xml: Remove.
5784         * features/i386/i386-avx-avx512-linux.xml: Remove.
5785         * features/i386/i386-avx-avx512.xml: Remove.
5786         * features/i386/i386-avx-linux.xml: Remove.
5787         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5788         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5789         * features/i386/i386-avx-mpx-linux.xml: Remove.
5790         * features/i386/i386-avx-mpx.xml: Remove.
5791         * features/i386/i386-avx.xml: Remove.
5792         * features/i386/i386-linux.xml: Remove.
5793         * features/i386/i386-mmx-linux.xml: Remove.
5794         * features/i386/i386-mmx.xml: Remove.
5795         * features/i386/i386-mpx-linux.xml: Remove.
5796         * features/i386/i386-mpx.xml: Remove.
5797         * features/i386/i386.xml: Remove.
5798         * features/i386/x32-avx-avx512-linux.xml: Remove.
5799         * features/i386/x32-avx-linux.xml: Remove.
5800         * features/i386/x32-linux.xml: Remove.
5801
5802 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5803
5804         * regformats/aarch64.dat: Remove.
5805         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5806         * regformats/i386/amd64-avx-linux.dat: Remove.
5807         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5808         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5809         * regformats/i386/amd64-linux.dat: Remove.
5810         * regformats/i386/amd64-mpx-linux.dat: Remove.
5811         * regformats/i386/amd64.dat: Remove.
5812         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5813         * regformats/i386/i386-avx-linux.dat: Remove.
5814         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5815         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5816         * regformats/i386/i386-linux.dat: Remove.
5817         * regformats/i386/i386-mmx-linux.dat: Remove.
5818         * regformats/i386/i386-mpx-linux.dat: Remove.
5819         * regformats/i386/i386.dat: Remove.
5820         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5821         * regformats/i386/x32-avx-linux.dat: Remove.
5822         * regformats/i386/x32-linux.dat: Remove.
5823
5824 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5825
5826         * aarch64-tdep.c: Remove xml self tests.
5827         * amd64-linux-tdep.c: Likewise.
5828         * amd64-tdep.c: Likewise.
5829         * i386-linux-tdep.c: Likewise.
5830         * i386-tdep.c: Likewise.
5831
5832 2019-07-03  Pedro Alves  <palves@redhat.com>
5833
5834         PR cli/24732
5835         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5836         (pipe_cmd_option_defs): New.
5837         (make_pipe_cmd_options_def_group): New.
5838         (pipe_command): Use gdb::option::process_options.
5839         (pipe_command_completer): New function.
5840         (_initialize_cli_cmds): Install completer for "pipe" command.
5841
5842 2019-07-03  Pedro Alves  <palves@redhat.com>
5843
5844         * cli/cli-option.c (union option_value) <string>: New field.
5845         (struct option_def_and_value): Add ctor, move ctor, dtor and
5846         use DISABLE_COPY_AND_ASSIGN.
5847         (option_def_and_value::clear_value): New.
5848         (parse_option, save_option_value_in_ctx, get_val_type_str)
5849         (add_setshow_cmds_for_options): Handle var_string.
5850         * cli-option.h (union option_def::var_address) <string>: New
5851         field.
5852         (struct string_option_def): New.
5853         * maint-test-options.c (struct test_options_opts): Add default
5854         ctor and use DISABLE_COPY_AND_ASSIGN.
5855         <string_opt>: New field.
5856         (test_options_opts::~test_options_opts): New.
5857         (test_options_opts::dump): Also dump "-string".
5858         (test_options_option_defs): Install "string.
5859
5860 2019-07-03  Pedro Alves  <palves@redhat.com>
5861
5862         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5863         option_value with a null enumeration.
5864         (complete_options): Save the option values in the context.
5865         (save_option_value_in_ctx): New, factored out from ...
5866         (process_options): ... here.
5867         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5868         of the function.
5869         * maint-test-options.c (test_options_opts::dump): New, factored
5870         out from ...
5871         (maintenance_test_options_command_mode): ... here.
5872         (maintenance_test_options_command_completion_result): Delete.
5873         (maintenance_test_options_command_completion_text): Update
5874         comment.
5875         (maintenance_show_test_options_completion_result): Change
5876         prototype.  Just print
5877         maintenance_test_options_command_completion_text.
5878         (save_completion_result): New.
5879         (maintenance_test_options_completer_mode): Pass options context to
5880         complete_options, and then save a dump.
5881         (_initialize_maint_test_options): Use add_cmd to install "maint
5882         show test-options-completion-result".
5883
5884 2019-07-03  Pedro Alves  <palves@redhat.com>
5885
5886         * NEWS (New commands): Mention "with" and "maint with".
5887         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5888         (with_command, with_command_completer): New.
5889         (pipe_command): Adjust to new repeat_previous
5890         interface.
5891         (_initialize_cli_cmds): Install the "with" command and its "w"
5892         alias.
5893         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5894         declarations.
5895         * cli/cli-setshow.c (parse_cli_var_uinteger)
5896         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5897         argument strings for all var_types.
5898         (get_setshow_command_value_string): New, factored out from ...
5899         (do_show_command): ... this.
5900         * cli/cli-setshow.h: Include <string>.
5901         (get_setshow_command_value_string): Declare.
5902         * command.h (repeat_previous): Now returns const char *.  Adjust
5903         comment.
5904         * maint.c: Include "cli/cli-cmds.h".
5905         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5906         (_initialize_maint_cmds): Register the "maintenance with" command.
5907         * top.c (repeat_previous): Move bits from pipe_command here:
5908         Return the saved command line, if any; error out if there's no
5909         command to relaunch.
5910
5911 2019-07-03  Pedro Alves  <palves@redhat.com>
5912
5913         * NEWS (New commands): Mention "maint set/show test-settings"
5914         instead of "maint test-settings".
5915         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5916         (maintenance_test_settings_set_list): Rename to ...
5917         (maintenance_set_test_settings_list): ... this.
5918         (maintenance_test_settings_show_list): Rename to  ...
5919         (maintenance_show_test_settings_list): ... this.
5920         (maintenance_test_settings_cmd): Delete.
5921         (maintenance_test_settings_set_cmd): ...
5922         (maintenance_set_test_settings_cmd): ... this.
5923         (maintenance_test_settings_show_cmd): ...
5924         (maintenance_show_test_settings_cmd): ... this.
5925         (maintenance_test_settings_show_value_cmd):
5926         (maintenance_show_test_settings_value_cmd): ... this.
5927         (_initialize_maint_test_settings): No longer install the "maint
5928         test-settings" prefix command.  Rename "maint test-settings set"
5929         to "maint set test-settings", and "maint test-settings show" to
5930         "maint show test-settings".  Adjust all subcommands.
5931
5932 2019-07-03  Pedro Alves  <palves@redhat.com>
5933
5934         * maint-test-settings.c: Fix file's intro comment.  Replace all
5935         references to "test-options" with references to "test-settings",
5936         in comments.
5937
5938 2019-07-03  Pedro Alves  <palves@redhat.com>
5939
5940         * maint-test-settings.c (maintenance_test_settings_xxx)
5941         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5942         New.
5943         (maintenance_test_settings_enums): Use them.
5944         (maintenance_test_settings_enum): Default to
5945         maintenance_test_settings_xxx.
5946         (_initialize_maint_test_settings): Initialize
5947         MAINTENANCE_TEST_SETTINGS_FILENAME.
5948
5949 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5950
5951         * breakpoint.h (remove_breakpoints_inf): Change return type to
5952         void, move function documentation here.
5953         * breakpoint.c (remove_breakpoints_inf): Change return type to
5954         void, move function documentation to header.
5955
5956 2019-07-02  Pedro Alves  <palves@redhat.com>
5957
5958         * NEWS (Completion improvements): Mention "info threads".
5959         * thread.c (struct info_threads_opts, info_threads_option_defs)
5960         (make_info_threads_options_def_group): New.
5961         (info_threads_command): Use gdb::option::process_options.
5962         (info_threads_command_completer): New.
5963         (_initialize_thread): Use gdb::option::build_help to build the
5964         help text for "info threads".
5965
5966 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5967
5968         * defs.h (generic_load): Move from here...
5969         * symfile.h (generic_load): ... to here.  Rename name parameter
5970         to args.
5971         * symfile.c (generic_load): Add comment.
5972
5973 2019-07-01  Tom Tromey  <tromey@adacore.com>
5974
5975         * dwarf2read.c
5976         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5977         declaration of without_params.  Fix formatting.
5978
5979 2019-07-01  Tom Tromey  <tromey@adacore.com>
5980
5981         * ada-exp.y (find_primitive_type): Update.
5982         * ada-lang.h (ada_lookup_symbol): Update.
5983         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5984         parameter.
5985         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5986
5987 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5988
5989         PR breakpoints/24541
5990         * gdbarch.c: Regenerate.
5991         * gdbarch.h: Regenerate.
5992         * gdbarch.sh: Add 'stap_adjust_register'.
5993         * i386-tdep.c: Include '<unordered_set>'.
5994         (i386_stap_adjust_register): New function.
5995         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5996         * stap-probe.c (stap_parse_register_operand): Call
5997         'gdbarch_stap_adjust_register'.
5998
5999 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6000
6001         PR python/24742
6002         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6003         * python/python.c (do_start_initialization): Use 'xmalloc'
6004         instead of 'PyMem_Malloc'.
6005
6006 2019-06-28  Tom Tromey  <tromey@adacore.com>
6007
6008         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6009         for Ada.
6010
6011 2019-06-27  Tom Tromey  <tromey@adacore.com>
6012
6013         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6014         objfile_key.
6015         (arm_find_mapping_symbol, arm_record_special_symbol)
6016         (_initialize_arm_tdep): Update.
6017         (arm_objfile_data_free): Remove.
6018
6019 2019-06-27  Tom Tromey  <tromey@adacore.com>
6020
6021         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6022         to cp_print_static_field.
6023
6024 2019-06-26  Tom Tromey  <tromey@adacore.com>
6025
6026         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6027         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6028         declare.
6029
6030 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6031
6032         * features/aarch64-core.c (create_feature_aarch64_core):
6033         Regenerate.
6034         * features/aarch64-core.xml: Add cpsr flags.
6035
6036 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6037
6038         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6039         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6040
6041 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6042
6043         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6044         field.
6045         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6046         use.
6047         (arm_record_special_symbol): Don't insert new symbol in sorted
6048         position, push it at the end.
6049
6050 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6051
6052         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6053         (arm_mapping_symbol_s): Remove.
6054         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6055         (arm_mapping_symbol_vec): New typedef.
6056         (struct arm_per_objfile): Add constructor.
6057         <section_maps>: Change type to
6058         std::unique_ptr<arm_mapping_symbol_vec[]>.
6059         (arm_compare_mapping_symbols): Remove.
6060         (arm_find_mapping_symbol): Adjust to section_maps type change.
6061         (arm_objfile_data_free): Call delete on arm_per_objfile.
6062         (arm_record_special_symbol): Adjust to section_maps type change.
6063         Allocate arm_per_objfile with new.
6064
6065 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6066
6067         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6068         with the command prefix.
6069
6070 2019-06-25  Tom Tromey  <tom@tromey.com>
6071
6072         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6073         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6074
6075 2019-06-25  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6078         type.
6079         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6080         protected.
6081
6082 2019-06-25  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-winsource.c
6085         (tui_source_window_base::set_is_exec_point_at): Add check against
6086         LOA_ADDRESS.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-source.c (tui_set_source_content): Don't check before
6091         xfree.
6092         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6093
6094 2019-06-25  Tom Tromey  <tom@tromey.com>
6095
6096         * tui/tui-winsource.h (tui_update_source_window_as_is)
6097         (tui_alloc_source_buffer, tui_line_is_displayed)
6098         (tui_addr_is_displayed): Change type of win_info.
6099         * tui/tui-winsource.c (tui_update_source_window_as_is)
6100         (tui_clear_source_content, tui_show_source_line)
6101         (tui_show_source_content, tui_source_window_base::refill)
6102         (tui_source_window_base::set_is_exec_point_at)
6103         (tui_source_window_base::set_is_exec_point_at)
6104         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6105         (tui_alloc_source_buffer, tui_line_is_displayed)
6106         (tui_addr_is_displayed): Change type of win_info.  Update.
6107         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6108         (tui_source_window_base::do_make_visible_with_new_height):
6109         Update.
6110         * tui/tui-source.c (tui_set_source_content)
6111         (tui_set_source_content_nil)
6112         (tui_source_window::do_scroll_vertical): Update.
6113         * tui/tui-layout.c (show_layout): Update.
6114         * tui/tui-disasm.c (tui_set_disassem_content)
6115         (tui_disasm_window::do_scroll_vertical): Update.
6116         * tui/tui-data.h (tui_win_content): Remove.
6117         (struct tui_gen_win_info) <content, content_size>: Remove.
6118         (struct tui_source_element): Add initializers and destructor.
6119         (union tui_which_element, struct tui_win_element): Remove.
6120         (struct tui_source_window_base) <content>: New field.
6121         (struct tui_data_window): Remove destructor.
6122         (tui_alloc_content, tui_free_win_content)
6123         (tui_free_all_source_wins_content): Don't declare.
6124         * tui/tui-data.c (tui_initialize_static_data): Update.
6125         (init_content_element, tui_alloc_content): Remove.
6126         (~tui_gen_win_info): Update.
6127         (~tui_data_window, tui_free_all_source_wins_content)
6128         (tui_free_win_content, free_content, free_content_elements):
6129         Remove.
6130
6131 2019-06-25  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-winsource.h (tui_clear_source_content)
6134         (tui_erase_source_content, tui_show_source_content): Change type
6135         of win_info.
6136         * tui/tui-winsource.c (tui_clear_source_content)
6137         (tui_erase_source_content, tui_show_source_content): Change type
6138         of win_info.
6139         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6140         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6141         win_info.
6142         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6143         win_info.
6144         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6145
6146 2019-06-25  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-winsource.c (tui_clear_source_content)
6149         (tui_source_window_base::set_is_exec_point_at): Update.
6150         * tui/tui-source.c (tui_set_source_content_nil): Update.
6151         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6152         a bool.
6153         * tui/tui-data.c (init_content_element): Update.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6158         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6159         * tui/tui-layout.c (init_and_make_win): Update.
6160         * tui/tui.h (enum tui_win_type): Update.
6161         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6162         tui_win_is_auxillary.
6163         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6164         tui_win_is_auxillary.
6165
6166 2019-06-25  Tom Tromey  <tom@tromey.com>
6167
6168         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6169         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6170         (tui_delete_data_content_windows, tui_display_all_data)
6171         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6172         Update.
6173         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6174         * tui/tui-regs.c (tui_last_regs_line_no)
6175         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6176         (tui_show_registers): Update.
6177         (tui_show_register_group): Return void.  Update.
6178         (tui_display_registers_from, tui_display_reg_element_at_line)
6179         (tui_display_registers_from_line, tui_check_register_values):
6180         Update.
6181         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6182         member.
6183         (struct tui_data_window) <regs_content>: Now a std::vector.
6184         <regs_content_count>: Remove.
6185         (tui_add_content_elements, tui_free_data_content): Don't declare.
6186         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6187         (init_content_element): Remove DATA_WIN case.  Add assert.
6188         (tui_add_content_elements): Remove.
6189         (tui_data_window): Update.
6190         (tui_free_data_content): Remove.
6191         (free_content_elements): Remove DATA_WIN case.
6192
6193 2019-06-25  Tom Tromey  <tom@tromey.com>
6194
6195         * tui/tui-data.c (tui_data_item_window): Update.
6196         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6197         * tui/tui-windata.c (tui_display_all_data)
6198         (tui_display_data_from_line): Update.
6199         (tui_check_data_values): Remove.
6200         * tui/tui-regs.c (tui_show_register_group)
6201         (tui_display_reg_element_at_line): Update.
6202         * tui/tui-hooks.c (tui_register_changed)
6203         (tui_refresh_frame_and_register_information): Call
6204         tui_check_register_values.
6205         * tui/tui-data.h (struct tui_data_window) <data_content,
6206         data_content_count, data_type>: Remove.
6207         (enum tui_data_type): Remove.
6208
6209         * tui/tui-data.c (tui_data_window::clear_detail)
6210         (~tui_data_window): Update.
6211
6212 2019-06-25  Tom Tromey  <tom@tromey.com>
6213
6214         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6215         declare.
6216         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6217         Rename from tui_first_data_item_displayed.  Update.
6218         (tui_data_window::refresh_all)
6219         (tui_data_window::do_scroll_vertical): Update.
6220         * tui/tui-data.h (struct tui_data_window)
6221         <first_data_item_displayed>: Declare new method.
6222
6223 2019-06-25  Tom Tromey  <tom@tromey.com>
6224
6225         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6226         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6227         contents...
6228         (tui_initialize_static_data): ...here.
6229
6230 2019-06-25  Tom Tromey  <tom@tromey.com>
6231
6232         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6233         (tui_display_registers_from, tui_check_register_values): Update.
6234         (tui_display_register): Remove win_info parameter; update.
6235         (tui_get_register): Change type of parameters.
6236         * tui/tui-data.h (struct tui_data_element): Remove.
6237         (union tui_which_element) <data>: Remove.
6238         <data_window>: Change type.
6239         (struct tui_data_item_window): New.
6240         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6241         case.  Add assert.
6242         (~tui_data_item_window): New destructor.
6243         (free_content_elements): Remove DATA_ITEM_WIN case.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6248         Remove.
6249
6250 2019-06-25  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-data.h (struct tui_command_element): Remove.
6253         (union tui_which_element) <command>: Remove.
6254         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6255         assert.
6256         (free_content_elements): Remove CMD_WIN case.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-layout.c (tui_set_layout): Update.
6261         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6262         * tui/tui-data.c (layout_def): Update.
6263
6264 2019-06-25  Tom Tromey  <tom@tromey.com>
6265
6266         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6267         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6268         (tui_source_window_base::set_new_height): Update.
6269         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6270         Update.
6271         (tui_set_locator_fullname, tui_set_locator_info)
6272         (tui_show_frame_info): Update.
6273         * tui/tui-source.c (tui_set_source_content)
6274         (tui_source_is_displayed): Update.
6275         * tui/tui-layout.c (show_source_disasm_command, show_data)
6276         (show_source_or_disasm_and_command): Update.
6277         * tui/tui-disasm.c (tui_set_disassem_content)
6278         (tui_get_begin_asm_address): Update.
6279         * tui/tui-data.h (struct tui_locator_element): Remove.
6280         (union tui_which_element) <locator>: Remove.
6281         (struct tui_locator_window): New.
6282         (tui_locator_win_info_ptr): Change return type.
6283         * tui/tui-data.c (_locator): Change type.
6284         (tui_locator_win_info_ptr): Change return type.
6285         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6286         (tui_alloc_content): Add assert.
6287
6288 2019-06-25  Tom Tromey  <tom@tromey.com>
6289
6290         * tui/tui-winsource.c
6291         (tui_exec_info_window::maybe_allocate_content): New method.
6292         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6293         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6294         (make_source_or_disasm_window): Add cast.
6295         * tui/tui-data.h (union tui_which_element) <simple_string>:
6296         Remove.
6297         (struct tui_source_info): New.
6298         (struct tui_source_window_base) <execution_info>: Change type.
6299         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6300         case, and add assert.
6301         (tui_alloc_content): Add assert.
6302
6303 2019-06-25  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6306         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6307         * tui/tui-data.c (tui_alloc_win_info): Remove.
6308
6309 2019-06-25  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6312         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6313         can_highlight.
6314
6315 2019-06-25  Tom Tromey  <tom@tromey.com>
6316
6317         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6318         make_visible_with_new_height method.
6319         (tui_win_info::make_visible_with_new_height): New method.
6320         (tui_source_window_base::do_make_visible_with_new_height)
6321         (tui_data_window::do_make_visible_with_new_height)
6322         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6323         (make_visible_with_new_height): Remove.
6324         (tui_resize_all, tui_adjust_win_heights): Use
6325         make_visible_with_new_height method.
6326         * tui/tui-data.h (struct tui_win_info)
6327         <do_make_visible_with_new_height, make_visible_with_new_height>:
6328         New methods.
6329         (struct tui_source_window_base, struct tui_data_window)
6330         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6331         methods.
6332
6333 2019-06-25  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6336         method.
6337         (update_tab_width): Call update_tab_width method.
6338         * tui/tui-data.h (struct tui_win_info)
6339         (struct tui_source_window_base) <update_tab_width>: New methods.
6340
6341 2019-06-25  Tom Tromey  <tom@tromey.com>
6342
6343         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6344         parameter.
6345         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6346         parameter.
6347         (tui_gen_win_info::make_visible): Update.
6348         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6349         parameter.
6350         * tui/tui-data.h (enum tui_box): New enum.
6351         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6352
6353 2019-06-25  Tom Tromey  <tom@tromey.com>
6354
6355         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6356         init_and_make_win for EXEC_INFO_WIN.
6357         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6358         longer inline.
6359         (struct tui_win_info) <~tui_win_info>: Inline.
6360         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6361         Don't declare.
6362         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6363         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6364         Remove.
6365         (tui_initialize_static_data): Update.
6366         (~tui_gen_win_info): Handle more cleanup here.
6367         (~tui_source_window_base): Delete "execution_info".
6368         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6369
6370 2019-06-25  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-layout.c (make_command_window): Don't set
6373         can_highlight.
6374         (show_source_disasm_command): Call the reset method.
6375         (show_data): Don't set can_highlight.  Call the reset method.
6376         (tui_gen_win_info::reset): Rename from init_gen_win_info
6377         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6378         (show_source_or_disasm_and_command): Call the reset method.
6379         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6380         (struct tui_cmd_window): Set can_highlight.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6385         from make_visible.
6386         (tui_make_visible, tui_make_invisible): Rewrite.
6387         (tui_win_info::make_visible): Remove.
6388         (tui_source_window_base::make_visible): Update.
6389         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6390         method.  Moved from...
6391         (struct tui_win_info) <make_visible>: ...here.
6392
6393 2019-06-25  Tom Tromey  <tom@tromey.com>
6394
6395         * tui/tui-winsource.c
6396         (tui_source_window_base::do_scroll_horizontal): Remove direction
6397         parameter.
6398         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6399         direction parameter.
6400         * tui/tui-win.c (tui_win_info::forward_scroll)
6401         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6402         (tui_win_info::right_scroll): Update.
6403         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6404         direction parameter.
6405         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6406         direction parameter.
6407         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6408         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6409         Remove direction parameter.
6410         (struct tui_source_window_base, struct tui_source_window)
6411         (struct tui_disasm_window, struct tui_data_window)
6412         (struct tui_cmd_window): Update.
6413
6414 2019-06-25  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-winsource.h (tui_set_exec_info_content)
6417         (tui_show_exec_info_content, tui_erase_exec_info_content)
6418         (tui_clear_exec_info_content, tui_update_exec_info): Change
6419         argument to tui_source_window_base.
6420         * tui/tui-winsource.c (tui_set_exec_info_content)
6421         (tui_show_exec_info_content, tui_erase_exec_info_content)
6422         (tui_clear_exec_info_content, tui_update_exec_info): Change
6423         argument to tui_source_window_base.
6424
6425 2019-06-25  Tom Tromey  <tom@tromey.com>
6426
6427         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6428         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6429
6430 2019-06-25  Tom Tromey  <tom@tromey.com>
6431
6432         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6433         check.
6434
6435 2019-06-25  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6438         type to void.
6439         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6440         type to void.
6441         * tui/tui-source.c (tui_set_source_content): Update.
6442         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6443
6444 2019-06-25  Tom Tromey  <tom@tromey.com>
6445
6446         * tui/tui-win.c (window_name_completer, tui_set_focus)
6447         (tui_all_windows_info): Use name method.
6448         * tui/tui-data.h (struct tui_gen_win_info)
6449         (struct tui_source_window, struct tui_disasm_window)
6450         (struct tui_data_window, struct tui_cmd_window) <name>: New
6451         method.
6452         (tui_win_name): Don't declare.
6453         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6454         (tui_win_name): Remove.
6455
6456 2019-06-25  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-winsource.h (tui_update_source_window)
6459         (tui_update_source_window_as_is): Change parameter type.
6460         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6461         to be a tui_source_window_base.
6462         (tui_update_source_window_as_is): Likewise.
6463         * tui/tui-win.c (make_visible_with_new_height): Update.
6464
6465 2019-06-25  Tom Tromey  <tom@tromey.com>
6466
6467         * tui/tui-winsource.c (tui_erase_source_content)
6468         (tui_show_source_content, tui_show_exec_info_content)
6469         (tui_erase_exec_info_content): Use refresh_window method.
6470         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6471         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6472         from tui_refresh_win.
6473         (tui_data_window::refresh_window): New method.
6474         (tui_win_info::refresh, tui_source_window_base::refresh)
6475         (tui_refresh_all): Use refresh_window method.
6476         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6477         method.
6478         * tui/tui-regs.c (tui_display_register): Call refresh_window
6479         method.
6480         * tui/tui-layout.c (show_source_disasm_command)
6481         (show_source_or_disasm_and_command): Call refresh_window method.
6482         * tui/tui-data.h (struct tui_gen_win_info)
6483         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6484         New method.
6485
6486 2019-06-25  Tom Tromey  <tom@tromey.com>
6487
6488         * tui/tui.c (tui_rl_other_window, tui_enable)
6489         (tui_is_window_visible, tui_get_command_dimension): Update.
6490         * tui/tui-winsource.c (tui_update_source_window_as_is)
6491         (tui_clear_source_content, tui_erase_source_content)
6492         (tui_show_source_line, tui_source_window_base::refill)
6493         (tui_source_window_base::do_scroll_horizontal)
6494         (tui_source_window_base::set_is_exec_point_at)
6495         (tui_update_breakpoint_info, tui_set_exec_info_content)
6496         (tui_alloc_source_buffer, tui_line_is_displayed)
6497         (tui_addr_is_displayed): Update.
6498         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6499         (tui_check_and_display_highlight_if_needed)
6500         (tui_win_info::make_visible, tui_win_info::refresh)
6501         (tui_refresh_all): Update.
6502         * tui/tui-windata.c (tui_first_data_item_displayed)
6503         (tui_delete_data_content_windows, tui_erase_data_content)
6504         (tui_display_all_data, tui_data_window::refresh_all)
6505         (tui_check_data_values): Update.
6506         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6507         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6508         (tui_win_info::backward_scroll, tui_refresh_all_win)
6509         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6510         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6511         (tui_source_window_base::set_new_height)
6512         (tui_data_window::set_new_height)
6513         (make_invisible_and_set_new_height)
6514         (make_visible_with_new_height, new_height_ok)
6515         (parse_scrolling_args): Update.
6516         * tui/tui-stack.c (tui_show_frame_info): Update.
6517         * tui/tui-source.c (tui_set_source_content)
6518         (tui_set_source_content_nil, tui_source_is_displayed)
6519         (tui_source_window::do_scroll_vertical): Update.
6520         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6521         (tui_display_registers_from, tui_display_reg_element_at_line)
6522         (tui_check_register_values, tui_reg_command): Update.
6523         * tui/tui-layout.c (tui_default_win_height)
6524         (show_source_disasm_command, show_data, init_and_make_win)
6525         (show_source_or_disasm_and_command): Update.
6526         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6527         (tui_redisplay_readline, tui_mld_flush)
6528         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6529         (tui_getc): Update.
6530         * tui/tui-disasm.c (tui_set_disassem_content)
6531         (tui_disasm_window::do_scroll_vertical): Update.
6532         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6533         Now virtual.
6534         (struct tui_win_info): Derive from tui_gen_win_info.
6535         <~tui_win_info>: Mark as override.
6536         <generic>: Remove member.
6537         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6538         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6539         (~tui_data_window, ~tui_win_info)
6540         (tui_free_all_source_wins_content): Update.
6541         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6542
6543 2019-06-25  Tom Tromey  <tom@tromey.com>
6544
6545         * tui/tui-layout.c (init_and_make_win): Use new.
6546         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6547         destructor, initializers.
6548         (tui_alloc_generic_win_info): Don't declare.
6549         * tui/tui-data.c (_locator): Add argument to constructor.
6550         (source_win, disasm_win): New globals.
6551         (exec_info): Remove.
6552         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6553         Update.
6554         (tui_alloc_generic_win_info): Remove.
6555         (init_content_element): Use new.
6556         (tui_win_info::tui_win_info): Update.
6557         (free_content_elements) <case DATA_WIN>: Use delete.
6558
6559 2019-06-25  Tom Tromey  <tom@tromey.com>
6560
6561         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6562         * tui/tui-windata.c (tui_first_data_item_displayed)
6563         (tui_delete_data_content_windows): Update.
6564         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6565         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6566         (tui_display_registers_from, tui_check_register_values): Update.
6567         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6568         pointer.
6569         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6570         window.
6571         (tui_free_data_content): Update.
6572         (free_content_elements) <case DATA_WIN>: Free the window.
6573
6574 2019-06-25  Tom Tromey  <tom@tromey.com>
6575
6576         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6577         Update.
6578         * tui/tui-layout.c (make_command_window)
6579         (show_source_disasm_command, show_data, init_and_make_win)
6580         (show_source_or_disasm_and_command): Update.
6581         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6582         method.
6583         <can_highight, is_highlighted>: Now bool.
6584         (tui_set_win_highlight): Don't declare.
6585         * tui/tui-data.c (tui_set_win_highlight): Remove.
6586
6587 2019-06-25  Tom Tromey  <tom@tromey.com>
6588
6589         * tui/tui-wingeneral.c (make_visible): Remove check of window
6590         type.
6591
6592 2019-06-25  Tom Tromey  <tom@tromey.com>
6593
6594         * tui/tui-win.c (tui_win_info::max_height)
6595         (tui_cmd_window::max_height): New methods.
6596         (new_height_ok): Call max_height.
6597         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6598         <max_height>: New method.
6599
6600 2019-06-25  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-win.c (tui_source_window_base::set_new_height)
6603         (tui_data_window::set_new_height): New methods.
6604         (make_invisible_and_set_new_height): Call set_new_height method.
6605         * tui/tui-data.h (struct tui_win_info)
6606         (struct tui_source_window_base, struct tui_data_window)
6607         <set_new_height>: New method.
6608
6609 2019-06-25  Tom Tromey  <tom@tromey.com>
6610
6611         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6612         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6613         tui_refresh_data_win.
6614         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6615         method.
6616         (tui_refresh_all_win): Call the refresh_all method.
6617         (tui_set_focus): Likewise.
6618         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6619         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6620         Likewise.
6621
6622 2019-06-25  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-winsource.h (tui_refill_source_window)
6625         (tui_set_is_exec_point_at): Don't declare.
6626         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6627         (tui_source_window_base::refill): Rename from
6628         tui_refill_source_window.
6629         (tui_source_window_base::do_scroll_horizontal): Update.
6630         (tui_source_window_base::set_is_exec_point_at): Rename from
6631         tui_set_is_exec_point_at.
6632         (tui_update_all_breakpoint_info): Update.
6633         * tui/tui-stack.c (tui_show_frame_info): Update.
6634         * tui/tui-layout.c (show_data): Add cast.
6635         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6636         * tui/tui-data.h (struct tui_source_window_base) <refill,
6637         set_is_exec_point_at>: New methods.
6638         (tui_source_windows, tui_add_to_source_windows): Update types.
6639         (tui_add_to_source_windows): Remove redundant declaration.
6640         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6641         (tui_source_windows): Change return type.
6642         (tui_clear_source_windows_detail): Update.
6643         (tui_add_to_source_windows): Change type of parameter.
6644         (tui_free_all_source_wins_content): Update.
6645
6646 2019-06-25  Tom Tromey  <tom@tromey.com>
6647
6648         * tui/tui-wingeneral.c (tui_win_info::refresh)
6649         (tui_source_window_base::refresh): New methods.
6650         (tui_refresh_all): Call the refresh method.
6651         * tui/tui-data.h (struct tui_win_info)
6652         (struct tui_source_window_base) <refresh>: New method.
6653
6654 2019-06-25  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui.h (tui_is_window_visible): Return bool.
6657         * tui/tui.c (tui_is_window_visible): Return bool.
6658         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6659         (tui_make_visible, tui_make_invisible)
6660         (tui_win_info::make_visible)
6661         (tui_source_window_base::make_visible, make_all_visible)
6662         (tui_make_all_visible, tui_make_all_invisible): Update.
6663         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6664         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6665         bool.
6666         (struct tui_win_info, struct tui_source_window_base)
6667         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6668         * tui/tui-data.c (tui_init_generic_part): Update.
6669
6670 2019-06-25  Tom Tromey  <tom@tromey.com>
6671
6672         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6673         (tui_source_window_base::make_visible): New methods.
6674         (make_all_visible): Make method call.
6675         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6676         (struct tui_source_window_base, struct tui_cmd_window): Override
6677         make_visible.
6678         (tui_win_is_source_type): Don't declare.
6679         * tui/tui-data.c (tui_win_is_source_type): Remove.
6680
6681 2019-06-25  Tom Tromey  <tom@tromey.com>
6682
6683         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6684         NULL check.
6685
6686 2019-06-25  Tom Tromey  <tom@tromey.com>
6687
6688         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6689         Inline constructor.  Add initializers for members.
6690         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6691         constructors; now inline in class.
6692
6693 2019-06-25  Tom Tromey  <tom@tromey.com>
6694
6695         * tui/tui-regs.c (tui_show_registers): Update.
6696         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6697         bool.
6698         * tui/tui-data.c (tui_data_window::clear_detail)
6699         (tui_data_window): Update.
6700
6701 2019-06-25  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui-windata.c (tui_display_all_data)
6704         (tui_display_data_from_line, tui_display_data_from)
6705         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6706         Update.
6707         * tui/tui-regs.c (tui_last_regs_line_no)
6708         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6709         (tui_show_registers, tui_show_register_group)
6710         (tui_display_registers_from, tui_display_reg_element_at_line)
6711         (tui_display_registers_from_line, tui_check_register_values)
6712         (tui_reg_next, tui_reg_prev): Update.
6713         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6714         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6715         tui_data_window.
6716         (struct tui_win_info) <detail>: Remove.  Add new fields from
6717         tui_data_info.
6718         (TUI_DATA_WIN): Add cast.
6719         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6720         (~tui_data_window): Simplify.
6721
6722 2019-06-25  Tom Tromey  <tom@tromey.com>
6723
6724         * tui/tui-layout.c (show_source_disasm_command)
6725         (show_source_or_disasm_and_command): Update.
6726         * tui/tui-io.c (update_cmdwin_start_line)
6727         (tui_redisplay_readline): Update.
6728         * tui/tui-data.h (struct tui_command_info): Remove.
6729         (struct tui_win_info) <detail>: Remove command_info member.
6730         (struct tui_data_window) <start_line>: New member, from
6731         tui_command_info.
6732         (TUI_CMD_WIN): Add casts.
6733
6734 2019-06-25  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-winsource.c (tui_update_source_window)
6737         (tui_refill_source_window)
6738         (tui_source_window_base::do_scroll_horizontal)
6739         (tui_update_breakpoint_info, tui_set_exec_info_content)
6740         (tui_show_exec_info_content, tui_erase_exec_info_content)
6741         (tui_clear_exec_info_content): Update.
6742         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6743         Update.
6744         * tui/tui-win.c (make_invisible_and_set_new_height)
6745         (make_visible_with_new_height): Update.
6746         * tui/tui-source.c (tui_set_source_content)
6747         (tui_show_symtab_source): Update.
6748         * tui/tui-layout.c (extract_display_start_addr)
6749         (show_source_disasm_command, show_data)
6750         (make_source_or_disasm_window)
6751         (show_source_or_disasm_and_command): Update.
6752         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6753         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6754         "gdbarch".
6755         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6756         to tui_source_window_base.
6757         (struct tui_win_info) <detail>: Remove source_info member.
6758         (struct tui_source_window_base) <has_locator>: Inline.
6759         Move contents from tui_source_info; rename has_locator member to
6760         m_has_locator.
6761         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6762         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6763         header file.
6764         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6765         Simplify.
6766         (tui_free_all_source_wins_content): Cast to
6767         tui_source_window_base.
6768
6769 2019-06-25  Tom Tromey  <tom@tromey.com>
6770
6771         * tui/tui-win.c (make_invisible_and_set_new_height)
6772         (make_visible_with_new_height): Call has_locator method.
6773         * tui/tui-layout.c (show_source_disasm_command, show_data)
6774         (show_source_or_disasm_and_command): Update for bool change.
6775         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6776         (tui_win_info) <has_locator>: New method.
6777         (struct tui_source_window_base) <has_locator>: New method.
6778         (tui_win_has_locator): Don't declare.
6779         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6780         from tui_win_has_locator.
6781         (tui_source_window_base): Use false, not FALSE.
6782
6783 2019-06-25  Tom Tromey  <tom@tromey.com>
6784
6785         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6786         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6787         clear_detail method directly.
6788         (tui_clear_win_detail): Remove.
6789
6790 2019-06-25  Tom Tromey  <tom@tromey.com>
6791
6792         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6793         "this", not TUI_DISASM_WIN.
6794
6795 2019-06-25  Tom Tromey  <tom@tromey.com>
6796
6797         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6798         declare.
6799         * tui/tui-winsource.c
6800         (tui_source_window_base::do_scroll_horizontal): Rename from
6801         tui_horizontal_source_scroll.
6802         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6803         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6804         from tui_vertical_data_scroll.
6805         * tui/tui-win.h (tui_scroll): Don't declare.
6806         * tui/tui-win.c (tui_win_info::forward_scroll)
6807         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6808         (tui_win_info::right_scroll): Rename and update.
6809         (tui_scroll_forward_command, tui_scroll_backward_command)
6810         (tui_scroll_left_command, tui_scroll_right_command): Update.
6811         (tui_scroll): Remove.
6812         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6813         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6814         from tui_vertical_source_scroll.
6815         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6816         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6817         from tui_vertical_disassem_scroll.
6818         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6819         do_scroll_horizontal>: New methods.
6820         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6821         Likewise.
6822         (struct tui_source_window_base): Add do_scroll_horizontal.
6823         (struct tui_source_window, struct tui_disasm_window): Add
6824         do_scroll_vertical.
6825         (struct tui_data_window, struct tui_cmd_window): Add
6826         do_scroll_horizontal and do_scroll_vertical.
6827         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6828
6829 2019-06-25  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui-data.h (struct tui_source_window_base): New struct.
6832         (struct tui_source_window): Derive from tui_source_window_base.
6833         (struct tui_disasm_window): New struct.
6834         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6835         from tui_source_window::clear_detail.
6836         (tui_source_window_base): Rename from tui_source_window.
6837         (~tui_source_window_base): Rename from ~tui_source_window.
6838         (tui_alloc_win_info): Create a tui_disasm_window.
6839
6840 2019-06-25  Tom Tromey  <tom@tromey.com>
6841
6842         * tui/tui-data.h (struct tui_source_window)
6843         (struct tui_data_window): Declare destructors.
6844         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6845         destructors.
6846         (tui_win_info): Simplify.
6847
6848 2019-06-25  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-winsource.c (tui_display_main)
6851         (tui_update_source_windows_with_addr)
6852         (tui_update_all_breakpoint_info): Update.
6853         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6854         (new_height_ok, parse_scrolling_args): Update.
6855         * tui/tui-stack.c (tui_show_frame_info): Update.
6856         * tui/tui-data.h (struct tui_list): Remove.
6857         (tui_source_windows): Return a reference to a std::vector.
6858         * tui/tui-data.c (source_windows): Now a std::vector.
6859         (tui_source_windows): Change return type.
6860         (tui_clear_source_windows): Rewrite.
6861         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6862         (tui_free_all_source_wins_content): Rewrite.
6863
6864 2019-06-25  Tom Tromey  <tom@tromey.com>
6865
6866         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6867         (struct tui_data_window, struct tui_cmd_window): Declare
6868         clear_detail method.
6869         * tui/tui-data.c (tui_source_window::clear_detail)
6870         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6871         methods.
6872         (tui_clear_win_detail): Simplify.
6873
6874 2019-06-25  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-layout.c (make_source_window, make_disasm_window)
6877         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6878         Return the new window.
6879         (show_source_disasm_command, show_data)
6880         (show_source_or_disasm_and_command): Update.
6881
6882 2019-06-25  Tom Tromey  <tom@tromey.com>
6883
6884         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6885         parameter.  Return the new window.
6886         (show_source_disasm_command): Update and remove NULL check.
6887         (show_source_or_disasm_and_command): Update.
6888
6889 2019-06-25  Tom Tromey  <tom@tromey.com>
6890
6891         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6892
6893 2019-06-25  Tom Tromey  <tom@tromey.com>
6894
6895         * tui/tui-data.h (struct tui_win_info): Make constructor
6896         protected.  Make destructor virtual.  Add initializers.
6897         (tui_source_window, tui_data_window, tui_cmd_window): New
6898         classes.
6899         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6900         constructor.  Add "type" parameter.
6901         (tui_source_window, tui_data_window, tui_cmd_window): New
6902         constructors.
6903         (tui_alloc_win_info): Instantiate the appropriate subclass.
6904
6905 2019-06-25  Tom Tromey  <tom@tromey.com>
6906
6907         * tui/tui-win.c (tui_resize_all): Use delete.
6908         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6909         destructor.
6910         (tui_free_window): Don't declare.
6911         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6912         Update.
6913
6914 2019-06-25  Tom Tromey  <tom@tromey.com>
6915
6916         * tui/tui-data.h (struct tui_win_info): Add constructor.
6917         * tui/tui-data.c (tui_alloc_win_info): Use new.
6918         (tui_free_window): Use delete.
6919
6920 2019-06-22  Tom Tromey  <tom@tromey.com>
6921
6922         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6923         declare.
6924         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6925
6926 2019-06-22  Tom Tromey  <tom@tromey.com>
6927
6928         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6929         declare.
6930         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6931
6932 2019-06-22  Tom de Vries  <tdevries@suse.de>
6933
6934         * dwarf2read.c (create_addrmap_from_aranges)
6935         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6936         instead of '%zu'.
6937
6938 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6939
6940         * dwarf2read.h (dwarf2_section_info_def): Remove.
6941         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6942         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6943         std::vector<dwarf2_section_info>.
6944         (struct dwo_file) <~dwo_file>: Remove.
6945         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6946         types field.
6947         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6948         (dwarf2_read_debug_names): Likewise.
6949         (create_debug_types_hash_table): Change parameter type to
6950         array_view, adjust code accordingly.
6951         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6952         (partial_die_info::fixup): Likewise.
6953         (determine_prefix): Likewise.
6954         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6955
6956 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6957
6958         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6959         gdb_bfd_ref_ptr.
6960         <~dwo_file>: Remove call to gdb_bfd_unref.
6961         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6962         gdb_bfd_ref_ptr::get.
6963
6964 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6965
6966         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6967         type to htab_up.
6968         * dwarf2read.c (struct dwo_file): Initialize fields.
6969         <~dwo_file>: New.
6970         (free_dwo_file): Remove, move content to ~dwo_file.
6971         (struct dwo_file_deleter): Remove.
6972         (dwo_file_up>: Remove custom deleter.
6973         (free_dwo_files): Remove.
6974         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6975         dwo_files.
6976         (process_skeletonless_type_units): Call unique_ptr::get.
6977         (allocate_dwo_file_hash_table): Add deleter to created hash
6978         table.  Change return type to htab_up.
6979         (lookup_dwo_file_slot): Don't memset dwo_file, call
6980         unique_ptr::get.
6981         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6982         (create_dwo_unit_in_dwp_v2): Likewise.
6983         (open_and_init_dwo_file): Likewise.
6984         (free_dwo_file_from_slot): Remove.
6985
6986 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6987
6988         * dwarf2read.h (struct dwarf2_section_info) <readin,
6989         is_virtual>: Change type to bool.
6990         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6991         true instead of 1.
6992
6993 2019-06-19  Tom Tromey  <tom@tromey.com>
6994
6995         * tui/tui-data.h (tui_init_content_element): Don't declare.
6996
6997 2019-06-19  Tom Tromey  <tom@tromey.com>
6998
6999         * tui/tui-data.h (tui_init_win_info): Don't declare.
7000
7001 2019-06-19  Tom de Vries  <tdevries@suse.de>
7002
7003         * dwarf2read.h (abstract_to_concrete): Change type to
7004         std::unordered_map<sect_offset, std::vector<sect_offset>,
7005         gdb::hash_enum<sect_offset>>.
7006
7007 2019-06-19  Tom Tromey  <tromey@adacore.com>
7008
7009         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7010         EVAL_AVOID_SIDE_EFFECTS specially.
7011
7012 2019-06-19  Tom Tromey  <tromey@adacore.com>
7013
7014         * source-cache.c (highlighter): New global.
7015         (source_cache::get_source_lines): Create a highlighter on demand.
7016
7017 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7018
7019         * defs.h (deprecated_interactive_hook): Delete declaration.
7020         * interps.c (clear_interpreter_hooks): Remove use of
7021         deprecated_interactive_hook.
7022         * top.c (deprecated_interactive_hook): Delete definition.
7023         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7024
7025 2019-06-18  Tom de Vries  <tdevries@suse.de>
7026
7027         PR gdb/24515
7028         * dwarf2read.h (abstract_to_concrete): Change type from
7029         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7030         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7031         * dwarf2read.c (read_variable): Update.
7032         (dwarf2_fetch_die_loc_sect_off): Update.
7033
7034 2019-06-17  Tom de Vries  <tdevries@suse.de>
7035
7036         PR gdb/24617
7037         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7038         accessing parent[parent_len - 1].
7039
7040 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7041
7042         PR gdb/24364
7043         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7044         call dtrace_process_dof with NULL dof.
7045
7046 2019-06-16  Tom de Vries  <tdevries@suse.de>
7047
7048         PR gdb/24445
7049         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7050
7051 2019-06-16  Tom Tromey  <tom@tromey.com>
7052
7053         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7054         (make_all_visible): Use address of member.
7055
7056 2019-06-16  Tom Tromey  <tom@tromey.com>
7057
7058         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7059         (tui_free_window, free_content, free_content_elements): Remove
7060         unnecessary cast.
7061         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7062         cast.
7063         * tui/tui-regs.c (tui_show_register_group)
7064         (tui_display_registers_from, tui_display_reg_element_at_line):
7065         Remove unnecessary cast.
7066
7067 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7068
7069         * linux-nat.c (normal_mask): Delete.
7070         (_initialize_linux_nat): Don't initialise normal_mask.
7071
7072 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7073
7074         PR gdb/24445
7075         * dwarf-index-write.h (write_psymtabs_to_index): Add
7076         dwz_basename parameter.
7077         * dwarf-index-write.c (write_gdbindex): Move file writing to
7078         write_gdbindex_1.  Change return type void.
7079         (assert_file_size): Move up, remove filename parameter.
7080         (write_gdbindex_1): New function.
7081         (write_debug_names): Change return type to void, call
7082         assert_file_size.
7083         (struct index_wip_file): New struct.
7084         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7085         file logic to index_wip_file.  Write index for dwz file if
7086         needed.
7087         (save_gdb_index_command): Pass basename of dwz file, if present.
7088         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7089         build-id of dwz file, if present.
7090         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7091         (dwarf2_get_dwz_file): Likewise.
7092         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7093         (dwarf2_get_dwz_file): Likewise.
7094
7095 2019-06-16  Tom Tromey  <tom@tromey.com>
7096
7097         * coffread.c (process_coff_symbol): Use xstrdup.
7098         * value.c (create_internalvar): Use xstrdup.
7099
7100 2019-06-16  Tom Tromey  <tom@tromey.com>
7101
7102         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7103         * breakpoint.c (stopin_command, stopat_command)
7104         (until_break_command, decode_location_default): Remove unnecessary
7105         cast.
7106         * utils.c (subset_compare): Remove unnecessary cast.
7107         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7108         cast.
7109         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7110         cast.
7111         * infcmd.c (path_command): Remove unnecessary cast.
7112         * coffread.c (decode_type): Remove unnecessary cast.
7113         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7114         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7115         * tui/tui-stack.c (tui_show_locator_content)
7116         (tui_show_frame_info): Remove unnecessary cast.
7117         * tui/tui-win.c (tui_scroll_forward_command)
7118         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7119         (parse_scrolling_args): Remove unnecessary cast.
7120         * tui/tui-data.c (init_win_info, tui_del_window)
7121         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7122         (free_content_elements): Remove unnecessary cast.
7123         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7124         unnecessary cast.
7125         * tui/tui-source.c (tui_set_source_content)
7126         (tui_vertical_source_scroll): Remove unnecessary cast.
7127         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7128         cast.
7129         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7130         * tui/tui-regs.c (tui_display_registers_from)
7131         (tui_display_register): Remove unnecessary cast.
7132         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7133         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7134         (make_visible): Remove unnecessary cast.
7135         * tui/tui-winsource.c (tui_erase_source_content)
7136         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7137         unnecessary cast.
7138         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7139         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7140         * stabsread.c (read_type, read_array_type, read_range_type):
7141         Remove unnecessary cast.
7142         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7143         (parse_symbol, parse_type, upgrade_type, parse_external)
7144         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7145         unnecessary cast.
7146         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7147
7148 2019-06-16  Tom Tromey  <tom@tromey.com>
7149
7150         * tui/tui-data.c (tui_alloc_generic_win_info)
7151         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7152         checks.
7153
7154 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7155             Andrew Burgess  <andrew.burgess@embecosm.com>
7156
7157         * f-typeprint.c (f_print_type): Don't return early for not
7158         associated or not allocated types.
7159         (f_type_print_varspec_suffix): Add print_rank parameter and print
7160         ranks of array types in case they dangling.
7161         (f_type_print_base): Add print_rank parameter.
7162
7163 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * NEWS: Mention new MI commands.
7166         * break-catch-throw.c (enum exception_event_kind): Move to
7167         breakpoint.h.
7168         (print_mention_exception_catchpoint): Output text as a single
7169         message.
7170         (catch_exception_command_1): Rename to...
7171         (catch_exception_event): ...this, make non-static, update header
7172         command, and change some parameter types.
7173         (catch_catch_command): Update for changes to
7174         catch_exception_command_1.
7175         (catch_throw_command): Likewise.
7176         (catch_rethrow_command): Likewise.
7177         * breakpoint.c (enum exception_event_kind): Delete.
7178         * breakpoint.h (enum exception_event_kind): Moved here from
7179         break-catch-throw.c.
7180         (catch_exception_event): Declare.
7181         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7182         (mi_cmd_catch_throw): New function.
7183         (mi_cmd_catch_rethrow): New function.
7184         (mi_cmd_catch_catch): New function.
7185         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7186         'catch-catch' entries.
7187         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7188         (mi_cmd_catch_rethrow): Declare.
7189         (mi_cmd_catch_catch): Declare.
7190
7191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7192
7193         * annotate.c (annotate_source_line): Change return type to void,
7194         update implementation to match.
7195         * annotate.h (annotate_source_line): Change return type to void,
7196         update header comment.
7197         * stack.c (print_frame_info): Don't change what frame information
7198         is printed based on whether annotations are on or not.
7199
7200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7203         (annotate_source): Make static.
7204         (annotate_source_line): Moved from source.c and renamed from
7205         identify_source_line.  Update the return type.
7206         * annotate.h (annotate_source): Delete declaration.
7207         (annotate_source_line): Declaration moved from source.h, and
7208         renamed from identify_source_line.  Return type updated.
7209         * source.c (identify_source_line): Moved to annotate.c and renamed
7210         to annotate_source_line.
7211         (info_line_command): Remove check of annotation_level.
7212         * source.h (identify_source_line): Move declaration to annotate.h
7213         and rename to annotate_source_line.
7214         * stack.c: Add 'annotate.h' include.
7215         (print_frame_info): Remove check of annotation_level before
7216         calling annotate_source_line.
7217
7218 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7219
7220         * source-cache.c (source_cache::get_plain_source_lines): Use
7221         open_source_file_with_line_charpos instead of just
7222         open_source_file, remove call to find_source_lines.
7223         (source_cache::get_source_lines): Likewise.
7224         * source.c (find_source_lines): Make static.
7225         (get_filename_and_charpos): Renamed into...
7226         (open_source_file_with_line_charpos): ..this along with changes to
7227         return a scoped_fd, and some other minor clean ups.
7228         (identify_source_line): Use open_source_file_with_line_charpos.
7229         (search_command_helper): Use open_source_file_with_line_charpos
7230         instead of just open_source_file, remove call to
7231         find_source_lines.
7232         * source.h (open_source_file_with_line_charpos): Declare new
7233         function.
7234         (find_source_lines): Delete declaration.
7235
7236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7237
7238         * source.c (get_filename_and_charpos): Remove fullname
7239         parameter.
7240         (identify_source_line): Update call to get_filename_and_charpos.
7241
7242 2019-06-14  Tom Tromey  <tromey@adacore.com>
7243
7244         PR gdb/24502:
7245         * ui-style.h (skip_ansi_escape): Update comment.
7246         * ui-file.h (class no_terminal_escape_file): New class.
7247         * ui-file.c (no_terminal_escape_file::write)
7248         (no_terminal_escape_file::puts): New methods.
7249         * cli/cli-logging.c (handle_redirections): Use
7250         no_terminal_escape_file.
7251
7252 2019-06-14  Tom Tromey  <tromey@adacore.com>
7253
7254         * NEWS: Move convenience variable news above Python news.
7255
7256 2019-06-14  Tom Tromey  <tom@tromey.com>
7257
7258         * gnulib: Move directory to top-level.
7259         * configure.ac: Don't configure gnulib.
7260         * configure: Rebuild.
7261         * common/common-defs.h: Use new path to gnulib.
7262         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7263         (GNULIB_H): Remove.
7264         (INCGNU): Look in new gnulib location.
7265         (HFILES_NO_SRCDIR): Remove gnulib files.
7266         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7267         (generated_files): Remove GNULIB_H.
7268         ($(LIBGNU), all-lib): Remove targets.
7269         (distclean): Don't mention GNULIB_BUILDDIR.
7270         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7271
7272 2019-06-14  Tom Tromey  <tromey@adacore.com>
7273
7274         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7275         Warn if symbol file does not provide any symbols.
7276
7277 2019-06-14  Tom Tromey  <tromey@adacore.com>
7278
7279         * source.c (find_and_open_source): Respect basenames_may_differ.
7280
7281 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * annotate.c (annotate_breakpoints_invalid): Make use of
7284         scoped_restore_terminal_state.
7285         (annotate_frames_invalid): Likewise.
7286
7287 2019-06-14  Tom Tromey  <tromey@adacore.com>
7288
7289         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7290         allow assignment to an internalvar.
7291
7292 2019-06-14  Tom Tromey  <tromey@adacore.com>
7293
7294         * ada-lex.l: Allow "_" in attribute names.
7295
7296 2019-06-14  Tom Tromey  <tromey@adacore.com>
7297
7298         PR gdb/24653:
7299         * regcache.c (registers_changed): Don't call alloca.
7300         * top.c (execute_command): Don't call alloca.
7301
7302 2019-06-13  Pedro Alves  <palves@redhat.com>
7303
7304         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7305         'expression'.  When parsing an expression, error out if there's
7306         junk after "unlimited".
7307         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7308         (do_set_command): Adjust calls to is_unlimited_literal.
7309
7310 2019-06-13  Pedro Alves  <palves@redhat.com>
7311
7312         * compile/compile.c (make_compile_options_def_group): Add braces
7313         around array_view initializer.
7314         * thread.c (make_thread_apply_all_options_def_group)
7315         (make_thread_apply_all_options_def_group): Likewise.
7316
7317 2019-06-13  Pedro Alves  <palves@redhat.com>
7318
7319         * NEWS (New commands): Mention "maint test-options
7320         require-delimiter", "maint test-options unknown-is-error", "maint
7321         test-options unknown-is-operand" and "maint show
7322         test-options-completion-result".
7323         (New command options, command completion): New section.
7324         (Completion improvements): New section.
7325         Mention that you can abbreviate "unlimited".
7326
7327 2019-06-13  Pedro Alves  <palves@redhat.com>
7328
7329         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7330         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7331         * unittests/cli-utils-selftests.c (test_parse_flags)
7332         (test_parse_flags_qcs): Delete.
7333         (test_cli_utils): Don't call deleted functions.
7334
7335 2019-06-13  Pedro Alves  <palves@redhat.com>
7336
7337         * thread.c: Include "cli/cli-option.h".
7338         (tp_array_compar_ascending): Global.
7339         (tp_array_compar): Delete function.
7340         (tp_array_compar_ascending, tp_array_compar_descending): New
7341         functions.
7342         (ascending_option_def, qcs_flag_option_def)
7343         (thr_qcs_flags_option_defs)
7344         (make_thread_apply_all_options_def_group)
7345         (make_thread_apply_options_def_group): New.
7346         (thread_apply_all_command): Use gdb::option::process_options.
7347         (thread_apply_command_completer)
7348         (thread_apply_all_command_completer): New.
7349         (thread_apply_command): Use gdb::option::process_options.
7350         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7351         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7352         to generate help text of "thread apply".  Adjust "taas"'s help.
7353         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7354         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7355
7356 2019-06-13  Pedro Alves  <palves@redhat.com>
7357
7358         * thread.c (thread_apply_command): Check for invalid TID with
7359         isdigit instead of !isalpha.
7360
7361 2019-06-13  Pedro Alves  <palves@redhat.com>
7362
7363         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7364         (validate_flags_qcs): New.
7365         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7366         (validate_flags_qcs): Declare.
7367         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7368         (make_frame_apply_options_def_group): New.
7369         (frame_apply_command_count): Process options with
7370         gdb::option::process_options.
7371         (frame_apply_completer): New.
7372         (frame_apply_level_completer, frame_apply_all_completer)
7373         (frame_apply_completer): New.
7374         (_initialize_stack): Update help of "frame apply", "frame apply
7375         level", "frame apply all" and "faas" to mention supported options
7376         and install command completers.
7377         * stack.h (frame_apply_all_completer): Declare.
7378         * thread.c: Include "stack.h".
7379         (tfaas_command): Add "--".
7380         (_initialize_thread): Update help "tfaas" to mention supported
7381         options and install command completer.
7382
7383 2019-06-13  Pedro Alves  <palves@redhat.com>
7384
7385         * completer.c (complete_nested_command_line): New.
7386         (gdb_completion_word_break_characters_throw): Add assertion.
7387         * completer.h (complete_nested_command_line): Declare.
7388
7389 2019-06-13  Pedro Alves  <palves@redhat.com>
7390
7391         * stack.c (parse_backtrace_qualifiers): New.
7392         (backtrace_command): Use it.
7393         (backtrace_command_completer): Complete on qualifiers.
7394
7395 2019-06-13  Pedro Alves  <palves@redhat.com>
7396
7397         * frame.c: Include "cli/cli-option.h.
7398         (user_set_backtrace_options): New.
7399         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7400         Delete.
7401         (get_prev_frame): Adjust.
7402         (boolean_option_def, uinteger_option_def)
7403         (set_backtrace_option_defs): New.
7404         (_initialize_frame): Adjust and use
7405         gdb::option::add_setshow_cmds_for_options to install "set
7406         backtrace past-main" and "set backtrace past-entry".
7407         * frame.h: Include "cli/cli-option.h".
7408         (struct frame_print_options): Forward declare.
7409         (print_frame_arguments_all, print_frame_arguments_scalars)
7410         (print_frame_arguments_none): Declare.
7411         (print_entry_values): Delete declaration.
7412         (struct frame_print_options, user_frame_print_options): New.
7413         (struct set_backtrace_options): New.
7414         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7415         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7416         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7417         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7418         (list_args_or_locals): Add frame_print_options parameter.
7419         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7420         * python/py-framefilter.c (enumerate_args): Pass down
7421         USER_FRAME_PRINT_OPTIONS.
7422         * stack.c: Include "cli/cli-option.h".
7423         (print_frame_arguments_all, print_frame_arguments_scalars)
7424         (print_frame_arguments_none): Declare.
7425         (print_raw_frame_arguments, print_entry_values): Delete.
7426         (user_frame_print_options): New.
7427         (boolean_option_def, enum_option_def, frame_print_option_defs):
7428         New.
7429         (struct backtrace_cmd_options): New.
7430         (bt_flag_option_def): New.
7431         (backtrace_command_option_defs): New.
7432         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7433         (print_frame_arg, read_frame_arg, print_frame_args)
7434         (print_frame_info, print_frame): Add frame_print_options parameter
7435         and use it.
7436         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7437         (backtrace_command_1): Add frame_print_options and
7438         backtrace_cmd_options parameters and use them.
7439         (make_backtrace_options_def_group): New.
7440         (backtrace_command): Process command options with
7441         gdb::option::process_options.
7442         (backtrace_command_completer): New.
7443         (_initialize_stack): Extend "backtrace"'s help to mention
7444         supported options.  Install completer for "backtrace".
7445         Install some settings commands with add_setshow_cmds_for_options.
7446
7447 2019-06-13  Pedro Alves  <palves@redhat.com>
7448
7449         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7450         and that "set/show print raw frame-arguments" are now deprecated.
7451
7452         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7453         command.
7454         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7455         * stack.c (_initialize_stack): Install "set/show print
7456         raw-frame-arguments", and deprecate "set/show print raw
7457         frame-arguments".
7458         * valprint.c (_initialize_valprint): Deprecate "set/show print
7459         raw".
7460
7461 2019-06-13  Pedro Alves  <palves@redhat.com>
7462
7463         * compile/compile.c (struct compile_options): New.
7464         (compile_flag_option_def, compile_command_option_defs)
7465         (make_compile_options_def_group): New.
7466         (compile_file_command): Handle options with
7467         gdb::option::process_options.
7468         (compile_file_command_completer): New function.
7469         (compile_code_command): Handle options with
7470         gdb::option::process_options.
7471         (compile_code_command_completer): New function.
7472         (_initialize_compiler): Install completers for "compile code" and
7473         "compile file".  Mention available options in "compile code" and
7474         "compile code"'s help.
7475         * completer.c (advance_to_completion_word): New, factored out from
7476         ...
7477         (advance_to_expression_complete_word_point): ... this.
7478         (advance_to_filename_complete_word_point): New.
7479         * completer.h (advance_to_filename_complete_word_point): New
7480         declaration.
7481
7482 2019-06-13  Pedro Alves  <palves@redhat.com>
7483
7484         * compile/compile.c: Include "cli/cli-option.h".
7485         (compile_print_value): Scope data pointer is now a
7486         value_print_options pointer; adjust.
7487         (compile_print_command): Process options.  Scope data pointer is
7488         now a value_print_options pointer; adjust.
7489         (_initialize_compile): Update "compile print"'s help to include
7490         supported options.  Install a completer for "compile print".
7491         * cp-valprint.c (show_vtblprint, show_objectprint)
7492         (show_static_field_print): Delete.
7493         (_initialize_cp_valprint): Don't install "set print
7494         static-members", "set print vtbl", "set print object" here.
7495         * printcmd.c: Include "cli/cli-option.h" and
7496         "common/gdb_optional.h".
7497         (print_command_parse_format): Rework to fill in a
7498         value_print_options instead of a format_data.
7499         (print_value): Change parameter type from format_data pointer to
7500         value_print_options reference.  Adjust.
7501         (print_command_1): Process options.  Adjust to pass down a
7502         value_print_options.
7503         (print_command_completer): New.
7504         (_initialize_printcmd): Install print_command_completer as
7505         handle_brkchars completer for the "print" command.  Update
7506         "print"'s help to include supported options.
7507         * valprint.c: Include "cli/cli-option.h".
7508         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7509         here from cp-valprint.c.
7510         (boolean_option_def, uinteger_option_def)
7511         (value_print_option_defs, make_value_print_options_def_group):
7512         New.  Use gdb::option::add_setshow_cmds_for_options to install
7513         "set print elements", "set print null-stop", "set print repeats",
7514         "set print pretty", "set print union", "set print array", "set
7515         print address", "set print symbol", "set print array-indexes".
7516         * valprint.h: Include <string> and "cli/cli-option.h".
7517         (make_value_print_options_def_group): Declare.
7518         (print_value): Change parameter type from format_data pointer to
7519         value_print_options reference.
7520         (print_command_completer): Declare.
7521
7522 2019-06-13  Pedro Alves  <palves@redhat.com>
7523
7524         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7525         (COMMON_SFILES): Add maint-test-settings.c.
7526         * cli/cli-decode.c (boolean_enums): New global, factored out from
7527         ...
7528         (add_setshow_boolean_cmd): ... here.
7529         * cli/cli-decode.h (boolean_enums): Declare.
7530         * cli/cli-option.c: New file.
7531         * cli/cli-option.h: New file.
7532         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7533         factored out from ...
7534         (parse_cli_boolean_value(const char *)): ... this.
7535         (is_unlimited_literal): Change parameter type to pointer to
7536         pointer.  Adjust and advance ARG pointer.
7537         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7538         (parse_cli_var_enum): New, factored out from ...
7539         (do_set_command): ... this.  Adjust.
7540         * cli/cli-setshow.h (parse_cli_boolean_value)
7541         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7542         (parse_cli_var_enum): Declare.
7543         * cli/cli-utils.c: Include "cli/cli-option.h".
7544         (get_ulongest): New.
7545         * cli/cli-utils.h (get_ulongest): Declare.
7546         (check_for_argument): New overloads.
7547         * maint-test-options.c: New file.
7548
7549 2019-06-13  Pedro Alves  <palves@redhat.com>
7550
7551         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7552         parse a range if "-" is at the end of the string.
7553
7554 2019-06-13  Pedro Alves  <palves@redhat.com>
7555
7556         * cli/cli-setshow.c (parse_auto_binary_operation)
7557         (parse_cli_boolean_value): Don't allow "o".
7558
7559 2019-06-13  Pedro Alves  <palves@redhat.com>
7560
7561         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7562         * NEWS: Mention maint test-settings KIND.
7563         * maint-test-settings.c: New file.
7564
7565 2019-06-13  Pedro Alves  <palves@redhat.com>
7566
7567         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7568         completer.
7569         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7570         "set" completers.
7571
7572 2019-06-13  Pedro Alves  <palves@redhat.com>
7573
7574         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7575         after item.
7576
7577 2019-06-13  Pedro Alves  <palves@redhat.com>
7578
7579         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7580
7581 2019-06-13  Pedro Alves <palves@redhat.com>
7582
7583         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7584         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7585         call.
7586         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7587         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7588         calls.
7589         (check_for_argument): Skip spaces after argument.
7590
7591 2019-06-13  Pedro Alves  <palves@redhat.com>
7592
7593         * thread.c (thread_apply_command): Adjust TID parsing.
7594         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7595         detected before end of string.
7596         (tid_is_in_list): Error out if LIST is invalid.
7597
7598 2019-06-13  Pedro Alves  <palves@redhat.com>
7599
7600         * completer.c (complete_line_internal_1): Rewind completion word
7601         point.
7602         (completion_tracker::advance_custom_word_point_by): Change
7603         parameter type to int.
7604         * completer.h (completion_tracker::advance_custom_word_point_by):
7605         Likewise.
7606
7607 2019-06-13  Pedro Alves  <palves@redhat.com>
7608
7609         * completer.c (advance_to_completion_word): Handle delimiters.
7610
7611 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7612
7613         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7614
7615 2019-06-11  Tom Tromey  <tom@tromey.com>
7616
7617         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7618         (xmalloc_failed): Move to alloc.c.
7619         * alloc.c: New file.
7620         * Makefile.in (COMMON_SFILES): Add alloc.c.
7621
7622 2019-06-11  Tom Tromey  <tom@tromey.com>
7623
7624         * nat/linux-waitpid.c: Don't include server.h.
7625         (linux_debug): Remove.
7626         (my_waitpid): Update.
7627
7628 2019-06-11  Tom Tromey  <tromey@adacore.com>
7629
7630         * infcall.c (_initialize_infcall): Remove trailing newline from
7631         help.
7632         * user-regs.c (_initialize_user_regs): Remove trailing newline
7633         from help.
7634         * typeprint.c (_initialize_typeprint): Remove trailing newline
7635         from help.
7636         * reverse.c (_initialize_reverse): Remove trailing newlines from
7637         help.
7638         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7639         from help.
7640         * language.c (add_set_language_command): Remove trailing newline
7641         from help.
7642         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7643         help.
7644         * disasm.c (_initialize_disasm): Remove trailing newline from
7645         help.
7646         * top.c (init_main): Remove trailing newline from help.
7647         * interps.c (_initialize_interpreter): Remove trailing newline
7648         from help.
7649         * btrace.c (_initialize_btrace): Remove trailing newlines from
7650         help.
7651         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7652         from help.
7653         * python/python.c (_initialize_python): Remove trailing newline
7654         from help.
7655         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7656         help.
7657         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7658         from help.  Reformat some text.
7659         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7660         from help.
7661         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7662         newline from help.
7663
7664 2019-06-11  Tom Tromey  <tromey@adacore.com>
7665
7666         * darwin-nat.c (darwin_decode_exception_message)
7667         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7668
7669 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7670
7671         * valops.c (value_slice): Check for not allocated or not
7672         associated values.
7673
7674 2019-06-10  Tom de Vries  <tdevries@suse.de>
7675
7676         PR gdb/24618
7677         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7678         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7679         invalid.
7680
7681 2019-06-10  Tom de Vries  <tdevries@suse.de>
7682
7683         PR gdb/24611
7684         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7685         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7686
7687 2019-06-10  Tom de Vries  <tdevries@suse.de>
7688
7689         PR symtab/24545
7690         * symtab.c (struct demangled_name_entry): Add language field.
7691         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7692         static minimal symbol".  Set and use language field.
7693
7694 2019-06-10  Tom Tromey  <tromey@adacore.com>
7695
7696         * ada-lang.c (_initialize_ada_language): Update help text.
7697
7698 2019-06-10  Tom Tromey  <tromey@adacore.com>
7699
7700         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7701         with a newline.
7702         * guile/guile.c (handle_boot_error): Don't end warning with a
7703         newline.
7704         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7705         warning with a newline.
7706         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7707         newline.
7708         (s12z_frame_cache): Likewise.
7709         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7710         a newline.
7711         * solib-svr4.c (disable_probes_interface): Don't end warning with
7712         a newline.
7713         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7714         newline.
7715         * python/python.c (do_finish_initialization): Don't end warning
7716         with a newline.
7717
7718 2019-06-10  Tom Tromey  <tom@tromey.com>
7719
7720         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7721         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7722         gdbpy_enter.
7723
7724 2019-06-10  Tom Tromey  <tromey@adacore.com>
7725
7726         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7727         data.
7728         (elf_new_init): Don't call stabsread_new_init.
7729         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7730         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7731         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7732
7733 2019-06-10  Tom de Vries  <tdevries@suse.de>
7734
7735         PR symtab/16264
7736         PR symtab/24517
7737         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7738
7739 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7740
7741         * source.c (find_and_open_source): Also rewrite relative file
7742         names.
7743
7744 2019-04-26  Amos Bird  <amosbird@gmail.com>
7745
7746         * annotate.c (annotate_thread_exited): Add "thread-exited"
7747         annotation.
7748
7749 2019-06-06  Tom Tromey  <tromey@adacore.com>
7750
7751         * maint.h (class scoped_command_stats): Use
7752         DISABLE_COPY_AND_ASSIGN.
7753         <print_time>: New method.
7754         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7755         print_time.
7756         (scoped_command_stats::print_time): New method.
7757
7758 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7759
7760         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7761         instructions of lengths 6 or 8 bytes.
7762
7763 2019-06-04  Pedro Alves  <palves@redhat.com>
7764
7765         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7766
7767         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7768         * breakpoint.c (condition_completer): Likewise.
7769         * cli/cli-dump.c (scan_expression): Likewise.
7770         * common/filestuff.c (mkdir_recursive): Likewise.
7771         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7772         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7773         (gdb_abspath): Likewise.
7774         * compile/compile-cplus-types.c
7775         (compile_cplus_instance::decl_name): Likewise.
7776         * completer.c (complete_explicit_location):
7777         (signal_completer, reg_or_group_completer_1): Likewise.
7778         * cp-support.c (cp_remove_params_if_any): Likewise.
7779         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7780         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7781         * infcmd.c (strip_bg_char): Likewise.
7782         * linespec.c (copy_token_string): Likewise.
7783         * mi/mi-main.c (output_cores): Likewise.
7784         * psymtab.c (psymtab_search_name):
7785         * symfile.c (test_set_ext_lang_command): Likewise.
7786         * target.c (target_fileio_read_stralloc): Likewise.
7787         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7788         * value.c (complete_internalvar): Likewise.
7789
7790 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7791
7792         Add objfile property to gdb.Type.
7793         * NEWS: Mention Python API addition.
7794         * python/py-type.c (typy_get_objfile): New method.
7795
7796 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7797
7798         * NEWS: Mention the new set|show style [title|highlight].
7799         Mention changes to "show style", "help" and "apropos".
7800
7801 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7802
7803         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7804         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7805         instead of print_help_for_command.
7806         (print_doc_of_command): New function.
7807         (help_list): Add 'apropos -v word' suggestion.
7808         (print_help_for_command): Style the command name using title style.
7809         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7810         (_initialize_cli_cmds): Describe -v in apropos_command help.
7811
7812 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7813
7814         * cli/cli-style.h (cli_style_option): Add name in constructor,
7815         add m_name class member, add constructor with intensity,
7816         add name class function.
7817         (cli_style_option::add_setshow_commands): Remove name argument.
7818         (highlight_style, title_style): New styles.
7819         * cli/cli-style.c (do_show): New function that shows a style
7820         characteristic styling the style name with itself.
7821         (set_style_name): New function.
7822         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7823         Update all callers according to the changes in cli/cli-style.h.
7824         * utils.h (fputs_highlighted): New function.
7825         * utils.c (fputs_highlighted): Likewise.
7826
7827 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7828
7829         * NEWS: Mention new pipe command and new convenience variables.
7830
7831 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7832
7833         * cli/cli-cmds.c (pipe_command): New function.
7834         (_initialize_cli_cmds): Call add_com for pipe_command.
7835         Define | as an alias for pipe.
7836         (exit_status_set_internal_vars): New function.
7837         (shell_escape): Call exit_status_set_internal_vars.
7838         cli/cli-decode.c (find_command_name_length): Recognize | as
7839         a single character command.
7840
7841 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7842
7843         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7844         top.c (execute_command_to_ui_file): New function, mostly a copy
7845         of execute_command_to_string.
7846         (execute_command_to_string): Implement by calling
7847         execute_command_to_ui_file.
7848
7849 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7850
7851         * top.h (saved_command_line): Remove declaration.
7852         * top.c (previous_saved_command_line, previous_repeat_arguments):
7853         New variables.
7854         (saved_command_line): Make static, define together with other
7855         'repeat variables'.
7856         (dont_repeat): Clear repeat_arguments.
7857         (repeat_previous, get_saved_command_line, save_command_line):
7858         New functions.
7859         (gdb_init): Initialize saved_command_line
7860         and previous_saved_command_line.
7861         * main.c (captured_main_1): Remove saved_command_line initialization.
7862         * event-top.c (handle_line_of_input): Update to use
7863         the new 'repeat' related functions instead of direct access to
7864         saved_command_line.
7865         * command.h (repeat_previous, get_saved_command_line,
7866         save_command_line): New declarations.
7867         (dont_repeat): Add comment.
7868
7869 2019-05-30  Tom Tromey  <tromey@adacore.com>
7870
7871         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7872         Fix comment.
7873         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7874
7875 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7876
7877         PR cli/24587
7878         * completer.c (complete): Initialize variable word.
7879
7880 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7881
7882         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7883         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7884         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7885         'body' is NULL to the outter 'if', protecting the '!is_define'
7886         situation as well.
7887
7888 2019-05-29  Tom Tromey  <tromey@adacore.com>
7889
7890         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7891         (dwarf_unknown): New function.
7892         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7893         (dwarf_type_encoding_name): Use dwarf_unknown.
7894
7895 2019-05-29  Tom Tromey  <tromey@adacore.com>
7896
7897         PR c++/20020:
7898         * cp-valprint.c (cp_print_value_fields): Call
7899         cp_print_static_field inside "try".
7900
7901 2019-05-29  Tom Tromey  <tromey@adacore.com>
7902
7903         * inflow.c (struct terminal_info): Add default operator=.
7904         * configure: Rebuild.
7905         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7906         -Wdeprecated-copy-dtor, -Wredundant-move.
7907
7908 2019-05-29  Tom Tromey  <tromey@adacore.com>
7909
7910         * NEWS: Add entry.
7911         * infcmd.c (print_return_value_1): Handle finish_print
7912         option.
7913         (show_print_finish): New function.
7914         (_initialize_infcmd): Add "set/show print finish" commands.
7915         * valprint.c (user_print_options): Initialize new member.
7916         * valprint.h (struct value_print_options) <finish_print>: New
7917         member.
7918
7919 2019-05-28  Tom Tromey  <tromey@adacore.com>
7920
7921         * ada-lang.c (ada_remove_Xbn_suffix)
7922         (find_old_style_renaming_symbol)
7923         (parse_old_style_renaming): Remove.
7924         (ada_find_renaming_symbol): Don't call
7925         find_old_style_renaming_symbol.
7926         (ada_is_renaming_symbol): Rename from
7927         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7928         bool.  Now static.
7929         (ada_read_var_value): Update and simplify.
7930         * ada-exp.y (write_var_or_type): Remove old code.
7931
7932 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7933
7934         PR gdb/25010
7935         * event-top.c: Remove include comment.
7936         * inflow.c (class scoped_ignore_sigttou): Move from here...
7937         * inflow.h (class scoped_ignore_sigttou): ...to here.
7938         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7939         * top.c:  Remove include comment.
7940
7941 2019-05-27  Tom Tromey  <tom@tromey.com>
7942
7943         * NEWS: Fix typo.
7944
7945 2019-05-22  Tom Tromey  <tromey@adacore.com>
7946
7947         * target.c (target_follow_exec): Constify parameter.
7948         * target-delegates.c: Rebuild.
7949         * remote.c (remote_target::follow_exec): Constify parameter.
7950         * infrun.c (follow_exec): Constify parameter.
7951         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7952         (target_follow_exec): Likewise.
7953
7954 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7955
7956         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7957         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7958
7959 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7960
7961         * NEWS: Add debugredirect and testsuite sections.
7962
7963 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7964
7965         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7966         target descriptions using exclusively floating point register name
7967         aliases.
7968
7969 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7970
7971         PR gdb/18644:
7972         * f-lang.c (build_fortran_types): Handle the case where
7973         gdbarch_floatformat_for_type returns a nullptr.
7974
7975 2019-05-21  Tom de Vries  <tdevries@suse.de>
7976
7977         PR cli/24587
7978         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7979
7980 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7981
7982         PR gdb/18644:
7983         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7984         16-byte floats.
7985         * i386-tdep.c (i386_floatformat_for_type): Use
7986         floatformats_ia64_quad for the 16-byte floating point component
7987         within a fortran 32-byte complex number.
7988
7989 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7990
7991         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7992         delete default constructor.
7993         (find_partial_die): Update to return const struct.
7994         (partial_die_parent_scope): Move variable declaration into scope
7995         of its use and change its type to auto.
7996         (guess_partial_die_structure_name): Likewise.
7997         (partial_die_info::fixup): Likewise.
7998
7999 2019-05-17  Tom Tromey  <tromey@adacore.com>
8000
8001         * source.c (find_and_open_source): Remove cast.
8002
8003 2019-05-17  Tom Tromey  <tromey@adacore.com>
8004
8005         * annotate.c (annotate_source): Make "filename" const.
8006         * annotate.h (annotate_source): Use const.
8007
8008 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8009
8010         * disasm.c (set_disassembler_options): Send errors to stderr.
8011
8012 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8013
8014         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8015         (cli_interp_base::set_logging): Check debug_redirect.
8016         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8017         * cli/cli-logging.c (debug_redirect): Add static variable.
8018         (pop_output_files): Add default param.
8019         (handle_redirections): Print debug setting.
8020         (show_logging_command): Likewise.
8021         (_initialize_cli_logging): Add debugredirect command.
8022         * interps.c (current_interp_set_logging): Add debug_redirect
8023         parameter.
8024         * interps.h (set_logging): Add debug_redirect parameter.
8025         (current_interp_set_logging): Likewise.
8026         * mi/mi-common.h: Likewise.
8027         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8028
8029 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8030             Tom Tromey  <tromey@adacore.com>
8031
8032         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8033         directly.
8034         * cli/cli-interp.h (make_logging_output): Remove declaration.
8035         * cli/cli-logging.c (make_logging_output): Remove function.
8036         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8037         directly.
8038         * ui-file.c (tee_file::tee_file): Remove bools.
8039         (tee_file::~tee_file): Remove deletes.
8040         * ui-file.h (tee_file): Remove bools.
8041
8042 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8043
8044         * mi/mi-cmds.h (mi_cmd_complete): New function.
8045         * mi/mi-main.c (mi_cmd_complete): Likewise.
8046         * mi/mi-cmds.c: Define new MI command -complete.
8047         * NEWS: Mention new -complete command.
8048
8049 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8050
8051         * completer.h (complete): New function.
8052         * completer.c (complete): Likewise.
8053         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8054         function defined in completer.h.
8055
8056 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8057
8058         * MAINTAINERS (Write After Approval): Add myself.
8059
8060 2019-05-17  Tom de Vries  <tdevries@suse.de>
8061
8062         PR gdb/24094
8063         * dwarf2read.c (struct cu_partial_die_info): New struct.
8064         (find_partial_die): Return cu_partial_die_info.
8065         (partial_die_parent_scope, guess_partial_die_structure_name)
8066         (partial_die_info::fixup): Handle new return type of find_partial_die.
8067
8068 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8069
8070         PR breakpoints/24541
8071         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8072         "std::string", simplifying the algorithm.
8073
8074 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8075
8076         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8077         (stap_static_probe_ops::get_probes): Likewise.
8078
8079 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8080
8081         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8082         '-')" and "else if".
8083         (stap_parse_single_operand): Join checks for
8084         "gdbarch_stap_parse_special_token_p" and
8085         "gdbarch_stap_parse_special_token" in the same "if" statement.
8086         Invert check when verifying for operation on register
8087         displacement.
8088
8089 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8090
8091         * stap-probe.c (stap_get_opcode): Update comment.
8092         (stap_get_expected_argument_type): Likewise.
8093         (handle_stap_probe): Likewise.
8094
8095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8096
8097         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8098         return type to 'bool'.  Adjust comment.  Use 'bool' when
8099         appropriate.
8100         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8101         * stap-probe.c (stap_parse_argument_1): Likewise.
8102         (stap_is_operator): Likewise.
8103         (stap_is_generic_prefix): Likewise.
8104         (stap_is_register_prefix): Likewise.
8105         (stap_is_register_indirection_prefix): Likewise.
8106         (stap_is_integer_prefix): Likewise.
8107         (stap_generic_check_suffix): Likewise.
8108         (stap_check_integer_suffix): Likewise.
8109         (stap_check_register_suffix): Likewise.
8110         (stap_check_register_indirection_suffix): Likewise.
8111         (stap_parse_register_operand): Likewise.
8112         (stap_parse_single_operand): Likewise.
8113         (stap_parse_argument_1): Likewise.
8114         (stap_probe::get_argument_count): Likewise.
8115         (stap_is_operator): Likewise.
8116
8117 2019-05-16  Tom Tromey  <tromey@adacore.com>
8118
8119         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8120         keyword to foreach.
8121
8122 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8123
8124         * linux-thread-db.c (try_thread_db_load_1): Change return type
8125         to bool.
8126         (try_thread_db_load): Likewise.
8127         (try_thread_db_load_from_pdir_1): Likewise.
8128         (try_thread_db_load_from_pdir): Likewise.
8129         (try_thread_db_load_from_sdir): Likewise.
8130         (try_thread_db_load_from_dir): Likewise.
8131         (thread_db_load_search): Likewise.
8132         (has_libpthread): Likewise.
8133         (thread_db_load): Likewise.
8134
8135 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8136
8137         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8138         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8139         NULL, and complain/return if that's the case.
8140
8141 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8142
8143         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8144         (advance, posn, abstract_read_memory): New functions.
8145         [struct mem_read_abstraction]: New struct.
8146         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8147
8148 2019-05-14  Tom Tromey  <tromey@adacore.com>
8149
8150         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8151         value is not lval_memory.
8152
8153 2019-05-14  Tom Tromey  <tromey@adacore.com>
8154
8155         * solib.c (info_sharedlibrary_command): Style the file name.
8156
8157 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8158
8159         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8160         (aarch64_vnv_type): Likewise.
8161         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8162         * common/tdesc.c: Likewise.
8163         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8164         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8165         * features/aarch64-fpu.xml: Add ieee half view.
8166         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8167         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8168         * gdbtypes.h (struct builtin_type): Likewise.
8169         (struct objfile_type): Likewise.
8170
8171 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8172
8173         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8174         typo.
8175         * location.h (string_to_event_location): Likewise.
8176
8177 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8178
8179         GDB 8.3 released.
8180
8181 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8182
8183         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8184         New variable declaration.
8185         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8186         New variable.
8187         (print_one_breakpoint): Use ui_out::test_flags and new global
8188         variable to compute use_fixed_output.
8189         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8190         Remove.
8191         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8192         (mi_multi_location_breakpoint_output_fixed): Remove.
8193         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8194         new variable.
8195         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8196         fix_multi_location_breakpoint_output flag if version >= 3.
8197         * ui-out.h (enum ui_out_flag)
8198         <fix_multi_location_breakpoint_output>: New enumerator.
8199
8200 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8201
8202         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8203
8204 2019-05-10  Tom Tromey  <tromey@adacore.com>
8205
8206         * ada-lang.c (catch_ada_completer): New function.
8207         (_initialize_ada_language): Use it.
8208
8209 2019-05-10  Tom Tromey  <tromey@adacore.com>
8210
8211         * thread.c (print_thread_info): Make "requested_threads" const.
8212         * gdbthread.h (print_thread_info): Make "requested_threads"
8213         const.
8214         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8215         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8216
8217 2019-05-08  Tom Tromey  <tom@tromey.com>
8218
8219         * gdbtypes.c (objfile_type_data): Change type.
8220         (objfile_type, _initialize_gdbtypes): Update.
8221
8222 2019-05-08  Tom Tromey  <tom@tromey.com>
8223
8224         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8225         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8226         (_initialize_dwarf2_frame): Update.
8227
8228 2019-05-08  Tom Tromey  <tom@tromey.com>
8229
8230         * objc-lang.c (objc_objfile_data): Change type.
8231         (find_methods): Update.
8232         (_initialize_objc_lang): Remove.
8233
8234 2019-05-08  Tom Tromey  <tom@tromey.com>
8235
8236         * stabsread.c (rs6000_builtin_type_data): Change type.
8237         (rs6000_builtin_type, _initialize_stabsread): Update.
8238
8239 2019-05-08  Tom Tromey  <tom@tromey.com>
8240
8241         * mips-tdep.c (mips_pdr_data): Remove.
8242         (_initialize_mips_tdep): Update.
8243
8244 2019-05-08  Tom Tromey  <tom@tromey.com>
8245
8246         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8247         (hppa_init_objfile_priv_data, read_unwind_info)
8248         (find_unwind_entry, _initialize_hppa_tdep): Update.
8249
8250 2019-05-08  Tom Tromey  <tom@tromey.com>
8251
8252         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8253         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8254         on obstack.
8255         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8256
8257 2019-05-08  Tom Tromey  <tom@tromey.com>
8258
8259         * mdebugread.c (basic_type_data): Change type.
8260         (basic_type, _initialize_mdebugread): Update.
8261
8262 2019-05-08  Tom Tromey  <tom@tromey.com>
8263
8264         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8265
8266 2019-05-08  Tom Tromey  <tom@tromey.com>
8267
8268         * nto-tdep.c (nto_inferior_data_reg): Change type.
8269         (nto_inferior_data): Update.
8270         (nto_inferior_data_cleanup, nto_new_inferior_data)
8271         (_initialize_nto_tdep): Remove.
8272         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8273
8274 2019-05-08  Tom Tromey  <tom@tromey.com>
8275
8276         * ada-lang.c (struct ada_inferior_data): Add initializers.
8277         (ada_inferior_data): Change type.
8278         (ada_inferior_data_cleanup): Remove.
8279         (get_ada_inferior_data, ada_inferior_exit)
8280         (struct ada_pspace_data): Add initializers, destructor.
8281         (ada_pspace_data_handle): Change type.
8282         (get_ada_pspace_data): Update.
8283         (ada_pspace_data_cleanup): Remove.
8284
8285 2019-05-08  Tom Tromey  <tom@tromey.com>
8286
8287         * coffread.c (struct coff_symfile_info): Add initializers.
8288         (coff_objfile_data_key): Move lower.  Change type.
8289         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8290         Update.
8291         (coff_free_info): Remove.
8292
8293 2019-05-08  Tom Tromey  <tom@tromey.com>
8294
8295         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8296         (fbsd_pspace_data_handle): Move lower.  Change type.
8297         (get_fbsd_pspace_data): Update.
8298         (fbsd_pspace_data_cleanup): Remove.
8299         (_initialize_fbsd_tdep): Update.
8300
8301 2019-05-08  Tom Tromey  <tom@tromey.com>
8302
8303         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8304         (get_ada_tasks_pspace_data): Update.
8305         (ada_tasks_pspace_data_cleanup): Remove.
8306         (_initialize_tasks): Update.
8307         (ada_tasks_inferior_data_handle): Change type.
8308         (get_ada_tasks_inferior_data): Update.
8309         (ada_tasks_inferior_data_cleanup): Remove.
8310         (struct ada_tasks_pspace_data): Add initializers.
8311
8312 2019-05-08  Tom Tromey  <tom@tromey.com>
8313
8314         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8315         * symfile-debug.c (debug_sym_get_probes): Change type.
8316         * stap-probe.c (handle_stap_probe):
8317         (stap_static_probe_ops::get_probes): Change type.
8318         * probe.h (class static_probe_ops) <get_probes>: Change type.
8319         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8320         (parse_probes_in_pspace): Update.
8321         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8322         Update.
8323         (any_static_probe_ops::get_probes): Change type.
8324         * elfread.c (elfread_data): New typedef.
8325         (probe_key): Change type.
8326         (elf_get_probes): Likewise.  Update.
8327         (probe_key_free): Remove.
8328         (_initialize_elfread): Update.
8329         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8330         Change type.
8331         (dtrace_process_dof_probe, dtrace_process_dof)
8332         (dtrace_static_probe_ops::get_probe): Change type.
8333
8334 2019-05-08  Tom Tromey  <tom@tromey.com>
8335
8336         * xcoffread.c (struct xcoff_symfile_info): Rename from
8337         coff_symfile_info.  Add initializers.
8338         (xcoff_objfile_data_key): Move lower.  Change type.
8339         (XCOFF_DATA): Rewrite.
8340         (xcoff_free_info): Remove.
8341         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8342         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8343         (xcoff_initial_scan): Update.
8344
8345 2019-05-08  Tom Tromey  <tom@tromey.com>
8346
8347         * solib-svr4.c (struct svr4_info): Add initializers and
8348         destructor.
8349         <probes_table>: Now an htab_up.
8350         (solib_svr4_pspace_data): Change type.
8351         (free_probes_table): Simplify.
8352         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8353         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8354         (probes_table_remove_objfile_probes, register_solib_event_probe)
8355         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8356         (_initialize_svr4_solib): Update.
8357
8358 2019-05-08  Tom Tromey  <tom@tromey.com>
8359
8360         * remote.c (remote_pspace_data): Change type.
8361         (remote_pspace_data_cleanup): Remove.
8362         (get_remote_exec_file, set_pspace_remote_exec_file)
8363         (_initialize_remote): Update.
8364
8365 2019-05-08  Tom Tromey  <tom@tromey.com>
8366
8367         * breakpoint.c (breakpoint_objfile_key): Change type.
8368         (get_breakpoint_objfile_data): Update.
8369         (free_breakpoint_objfile_data): Remove.
8370         (_initialize_breakpoint): Update.
8371
8372 2019-05-08  Tom Tromey  <tom@tromey.com>
8373
8374         * linux-tdep.c (struct linux_info): Add initializers.
8375         (linux_inferior_data): Move.  Change type.
8376         (invalidate_linux_cache_inf): Update.
8377         (linux_inferior_data_cleanup): Remove.
8378         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8379
8380 2019-05-08  Tom Tromey  <tom@tromey.com>
8381
8382         * auxv.c (auxv_inferior_data): Move.  Change type.
8383         (auxv_inferior_data_cleanup): Remove.
8384         (invalidate_auxv_cache_inf): Rewrite.
8385         (get_auxv_inferior_data, _initialize_auxv): Update.
8386
8387 2019-05-08  Tom Tromey  <tom@tromey.com>
8388
8389         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8390         (symfile_debug_objfile_data_key): Change type.
8391         (symfile_debug_installed, debug_qf_has_symbols)
8392         (debug_qf_find_last_source_symtab)
8393         (debug_qf_forget_cached_source_info)
8394         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8395         (debug_qf_print_stats, debug_qf_dump)
8396         (debug_qf_expand_symtabs_for_function)
8397         (debug_qf_expand_all_symtabs)
8398         (debug_qf_expand_symtabs_with_fullname)
8399         (debug_qf_map_matching_symbols)
8400         (debug_qf_expand_symtabs_matching)
8401         (debug_qf_find_pc_sect_compunit_symtab)
8402         (debug_qf_map_symbol_filenames)
8403         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8404         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8405         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8406         (debug_sym_read_linetable, debug_sym_relocate): Update.
8407         (symfile_debug_free_objfile): Remove.
8408         (install_symfile_debug_logging, _initialize_symfile_debug):
8409         Update.
8410
8411 2019-05-08  Tom Tromey  <tom@tromey.com>
8412
8413         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8414         allocate_on_obstack.
8415         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8416         (get_dwarf2_per_objfile): Update.
8417         (set_dwarf2_per_objfile): Remove.
8418         (dwarf2_has_info, dwarf2_get_section_info): Update.
8419         (dwarf2_free_objfile): Remove.
8420         (_initialize_dwarf2_read): Update.
8421
8422 2019-05-08  Tom Tromey  <tom@tromey.com>
8423
8424         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8425         initializers.
8426         <unsupported_script_warning_printed,
8427         script_not_found_warning_printed>: Now bool.
8428         (auto_load_pspace_data): Change type.
8429         (~auto_load_pspace_info): Rename from
8430         auto_load_pspace_data_cleanup.
8431         (get_auto_load_pspace_data, init_loaded_scripts_info)
8432         (clear_section_scripts, maybe_print_unsupported_script_warning)
8433         (maybe_print_script_not_found_warning, _initialize_auto_load):
8434         Update.
8435
8436 2019-05-08  Tom Tromey  <tom@tromey.com>
8437
8438         * objfiles.c (objfile_pspace_info): Add destructor and
8439         initializers.
8440         (objfiles_pspace_data): Change type.
8441         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8442         (get_objfile_pspace_data): Update.
8443         (objfiles_bfd_data): Change type.
8444         (get_objfile_bfd_data): Update.
8445         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8446
8447 2019-05-08  Tom Tromey  <tom@tromey.com>
8448
8449         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8450         Change type.
8451         (get_catch_syscall_inferior_data): Update.
8452         (catch_syscall_inferior_data_cleanup): Remove.
8453         (_initialize_break_catch_syscall): Update.
8454
8455 2019-05-08  Tom Tromey  <tom@tromey.com>
8456
8457         * inflow.c (struct terminal_info): Add destructor and
8458         initializers.
8459         (inflow_inferior_data): Change type.
8460         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8461         (get_inflow_inferior_data, inflow_inferior_exit)
8462         (swap_terminal_info, _initialize_inflow): Update.
8463
8464 2019-05-08  Tom Tromey  <tom@tromey.com>
8465
8466         * target-dcache.c (target_dcache_cleanup): Remove.
8467         (target_dcache_aspace_key): Change type.
8468         (target_dcache_init_p, target_dcache_invalidate)
8469         (target_dcache_get, target_dcache_get_or_init)
8470         (_initialize_target_dcache): Update.
8471         * dcache.h (struct dcache_deleter): New.
8472
8473 2019-05-08  Tom Tromey  <tom@tromey.com>
8474
8475         * symtab.c (struct symbol_cache): Add destructor and
8476         initializers.
8477         (symbol_cache_key): Move.  Change type.
8478         (make_symbol_cache, free_symbol_cache): Remove.
8479         (get_symbol_cache): Update.
8480         (symbol_cache_cleanup): Remove.
8481         (ALL_PSPACES, symbol_cache_flush)
8482         (maintenance_print_symbol_cache)
8483         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8484         Update.
8485
8486 2019-05-08  Tom Tromey  <tom@tromey.com>
8487
8488         * symtab.c (struct main_info): Add destructor and initializers.
8489         (main_progspace_key): Move.  Change type.
8490         (get_main_info): Update.
8491         (main_info_cleanup): Remove.
8492         (_initialize_symtab): Update.
8493
8494 2019-05-08  Tom Tromey  <tom@tromey.com>
8495
8496         * registry.h (DECLARE_REGISTRY): Define the _key class.
8497
8498 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * NEWS: Merge two 'New commands' sections.
8501
8502 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8503
8504         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8505         parameter and use Ada language definition instead.
8506         (ada_val_print_ptr): Remove unused language parameter.
8507         (ada_val_print_num): Remove language parameter and use Ada language
8508         definition instead.
8509         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8510         parameter.
8511         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8512         parameter and use Ada language definition instead.
8513         (ada_val_print_1): Update all ada_val_print_xxx calls.
8514         Remove language parameter.
8515         (ada_val_print): Update ada_val_print_1 call.
8516
8517 2019-05-08  Tom Tromey  <tromey@adacore.com>
8518
8519         * remote.c (remote_hw_watchpoint_limit)
8520         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8521         Now static.
8522
8523 2019-05-08  Tom Tromey  <tromey@adacore.com>
8524
8525         * maint.c (_initialize_maint_cmds): Move initialization code to
8526         remote.c.
8527         (watchdog, show_watchdog): Move to remote.c.
8528         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8529         "watchdog" static.
8530         (_initialize_remote): Move initialization code from maint.c.
8531         * defs.h (watchdog): Don't declare.
8532
8533 2019-05-08  Tom Tromey  <tromey@adacore.com>
8534
8535         * tui/tui-interp.c: Include main.h.
8536         * interps.c: Include main.h.
8537         * main.h (interpreter_p): Declare.
8538         * defs.h (interpreter_p): Don't declare.
8539
8540 2019-05-08  Tom Tromey  <tromey@adacore.com>
8541
8542         * dwarf2loc.c: Include dwarf2read.h.
8543         * defs.h (read_unsigned_leb128): Don't declare.
8544         * dwarf2read.h (read_unsigned_leb128): Declare.
8545
8546 2019-05-08  Tom Tromey  <tromey@adacore.com>
8547
8548         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8549         method.
8550
8551 2019-05-08  Tom Tromey  <tromey@adacore.com>
8552
8553         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8554         when no wrap column is set.
8555
8556 2019-05-08  Tom Tromey  <tromey@adacore.com>
8557
8558         * c-lang.c (c_get_string): Handle non-C-style arrays.
8559
8560 2019-05-08  Tom Tromey  <tromey@adacore.com>
8561
8562         * typeprint.c (print_offset_data::update): Print the bit offset,
8563         not the number of bits remaining.
8564
8565 2019-05-08  Tom Tromey  <tromey@adacore.com>
8566
8567         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8568         padding at end of comment.
8569
8570 2019-05-08  Tom Tromey  <tromey@adacore.com>
8571
8572         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8573         Compare main types.
8574
8575 2019-05-06  Tom Tromey  <tom@tromey.com>
8576
8577         * common/scoped_mmap.c: Include common-defs.h.
8578         * common/scoped_mmap.h: Don't include config.h.
8579
8580 2019-05-04  Tom Tromey  <tom@tromey.com>
8581
8582         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8583         (struct aarch64_call_info): Add initializers.
8584         <si>: Now a std::vector.
8585         (pass_on_stack, aarch64_push_dummy_call): Update.
8586
8587 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8588             Tom Tromey  <tom@tromey.com>
8589
8590         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8591         (ppc_threads): Now a std::vector.  Now static.
8592         (hwdebug_find_thread_points_by_tid)
8593         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8594         Update.
8595
8596 2019-05-04  Tom Tromey  <tom@tromey.com>
8597
8598         * arc-tdep.c (arc_tdesc_init): Return bool.
8599
8600 2019-05-04  Tom Tromey  <tom@tromey.com>
8601
8602         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8603         Use gdb_assert_not_reached.
8604
8605 2019-05-04  Tom Tromey  <tom@tromey.com>
8606
8607         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8608         "false".
8609
8610 2019-05-04  Tom Tromey  <tom@tromey.com>
8611
8612         * arc-tdep.c (arc_tdesc_init): Use bool.
8613
8614 2019-05-04  Tom Tromey  <tom@tromey.com>
8615
8616         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8617
8618 2019-05-04  Tom Tromey  <tom@tromey.com>
8619
8620         * cli/cli-cmds.c (valid_command_p): Return bool.
8621
8622 2019-05-04  Tom Tromey  <tom@tromey.com>
8623
8624         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8625         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8626
8627 2019-05-04  Raul Tambre  <raul@tambre.ee>
8628
8629         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8630         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8631         operator for comparison.
8632
8633 2019-05-04  Tom Tromey  <tom@tromey.com>
8634
8635         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8636         (lookup_partial_symbol, print_partial_symbols)
8637         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8638         (psymbol_compare): Update.
8639         (add_psymbol_to_bcache): Clear the entire psymbol.
8640         (maintenance_check_psymtabs): Update.
8641         * psympriv.h (struct partial_symbol): Don't derive from
8642         general_symbol_info.
8643         <obj_section, unrelocated_address, address,
8644         set_unrelocated_address>: Update.
8645         <ginfo>: New member.
8646         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8647         (debug_names::write_psymbols): Update.
8648
8649 2019-05-04  Tom de Vries  <tdevries@suse.de>
8650
8651         * contrib/cc-with-tweaks.sh: Support -n arg.
8652
8653 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8654
8655         * corelow.c (core_target::detach): Ensure frame cache and
8656         register caches are cleared.
8657         inferior.c (exit_inferior_1): Likewise.
8658
8659 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8660             Tom Tromey  <tom@tromey.com>
8661
8662         * dictionary.c (collate_pending_symbols_by_language): Remove
8663         "struct" from foreach.
8664         * symtab.c (lookup_global_symbol_from_objfile)
8665         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8666         foreach.
8667         * ser-tcp.c (net_open): Remove "struct" from foreach.
8668         * objfiles.c (objfile_relocate, objfile_rebase)
8669         (objfile_has_symbols): Remove "struct" from foreach.
8670         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8671         from foreach.
8672         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8673         foreach.
8674         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8675         "struct" from foreach.
8676         * ada-lang.c (create_excep_cond_exprs)
8677         (ada_exception_catchpoint_cond_string): Remove "struct" from
8678         foreach.
8679
8680 2019-05-03  Tom Tromey  <tromey@adacore.com>
8681
8682         * ada-exp.y (convert_char_literal): Check suffix of each
8683         enumerator.
8684
8685 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8686
8687         PR ada/21406:
8688         * ada-exp.y (yywrap): Don't define.
8689         * ada-lex.l (%option): Add noyywrap
8690         (yywrap): Remove.
8691
8692 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8693
8694         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8695         _WIN32_WINNT to the XP level, unless already defined to a higher
8696         level.
8697
8698         * unittests/parse-connection-spec-selftests.c:
8699         * ser-tcp.c:
8700         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8701         override.
8702
8703         * symfile.c (find_separate_debug_file): Remove colon from the
8704         drive spec of DOS/Windows file names of the target, so that the
8705         file name produced from DEBUGDIR and the target's directory will
8706         be valid on DOS/Windows systems.
8707
8708 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8709
8710         * rust-lang.c (val_print_struct): Handle printing structures
8711         containing strings.
8712
8713 2019-05-02  Tom Tromey  <tromey@adacore.com>
8714
8715         * valarith.c (_initialize_valarith): Remove.
8716
8717 2019-05-01  Tom Tromey  <tromey@adacore.com>
8718
8719         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8720         bitfields.
8721
8722 2019-05-01  Tom Tromey  <tromey@adacore.com>
8723
8724         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8725         for big-endian copies.
8726
8727 2019-04-30  Ali Tamur  <tamur@google.com>
8728         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8729         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8730         (read_3_bytes): New function.
8731
8732 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8733
8734         * windows-nat.c (main_thread_id): Delete.
8735         (handle_output_debug_string): Replace main_thread_id by
8736         current_event.dwThreadId.
8737         (fake_create_process): Likewise.
8738         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8739         Do not set main_thread_id.
8740         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8741         current_event.dwThreadId.
8742         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8743
8744 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8745
8746         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8747         Use current_event.dwThreadId instead of main_thread_id.
8748
8749 2019-04-30  Tom Tromey  <tromey@adacore.com>
8750
8751         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8752         (create_excep_cond_exprs): Iterate over program spaces.
8753         (ada_exception_catchpoint_cond_string): Examine all minimal
8754         symbols for exception types.
8755
8756 2019-04-30  Tom Tromey  <tromey@adacore.com>
8757
8758         PR c++/24470:
8759         * dwarf2read.c (process_structure_scope): Handle case where type
8760         has template parameters but no symbol was created.
8761
8762 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8763             Chris January  <chris.january@arm.com>
8764
8765         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8766         qualifier.
8767         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8768
8769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * f-typeprint.c (f_print_type): Update rules for printing
8772         whitespace.
8773         (f_type_print_varspec_suffix): Likewise.
8774
8775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8776             Chris January  <chris.january@arm.com>
8777
8778         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8779         function arguments.
8780
8781 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8782
8783         * f-lang.c (build_fortran_types): Change name of void type to
8784         lower case.
8785         * f-typeprint.c (f_type_print_base): Print the name of the void
8786         type, rather than a fixed string.
8787         * f-valprint.c (f_decorations): Use lower case void string.
8788
8789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8790             Chris January  <chris.january@arm.com>
8791
8792         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8793         types for Fortran.
8794
8795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8796             Chris January  <chris.january@arm.com>
8797             David Lecomber  <david.lecomber@arm.com>
8798
8799         * f-exp.y (BINOP_INTRINSIC): New token.
8800         (exp): New parser rule handling BINOP_INTRINSIC.
8801         (f77_keywords): Add new builtin procedures.
8802         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8803         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8804         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8805         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8806         (print_unop_subexp_f): New function.
8807         (print_binop_subexp_f): New function.
8808         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8809         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8810         (dump_subexp_body_f): Likewise.
8811         (operator_check_f): Likewise.
8812         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8813         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8814
8815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8818         UNOP_KIND.
8819         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8820         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8821         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8822         (operator_length_f): New fuction.
8823         (print_subexp_f): New function.
8824         (op_name_f): New function.
8825         (dump_subexp_body_f): New function.
8826         (operator_check_f): New function.
8827         (exp_descriptor_f): Replace standard expression handling functions
8828         with new functions.
8829         * gdb/fortran-operator.def: New file.
8830         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8831         * gdb/std-operator.def: Remove UNOP_KIND.
8832
8833 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8834
8835         * std-operator.def: Remove unbalanced, stray double quote
8836         character.
8837
8838 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8839             Chris January  <chris.january@arm.com>
8840             Daniel Everett  <daniel.everett@arm.com>
8841             Nick Forrington  <nick.forrington@arm.com>
8842             Richard Bunt  <richard.bunt@arm.com>
8843
8844         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8845         of depth when printing anonymous structs or unions.
8846         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8847         Don't print either the top-level value, or the children if the
8848         max-depth is exceeded.
8849         (ppscm_print_children): When printing the key of a map, allow one
8850         extra level of depth.
8851         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8852         print either the top-level value, or the children if the max-depth
8853         is exceeded.
8854         (print_children): When printing the key of a map, allow one extra
8855         level of depth.
8856         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8857         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8858         (user_print_options): Initialise max_depth field.
8859         (val_print_scalar_or_string_type_p): New function.
8860         (val_print): Check to see if the max depth has been reached.
8861         (val_print_check_max_depth): Define new function.
8862         (show_print_max_depth): New function.
8863         (_initialize_valprint): Add 'print max-depth' option.
8864         * valprint.h (struct value_print_options) <max_depth>: New field.
8865         (val_print_check_max_depth): Declare new function.
8866         * NEWS: Document new feature.
8867
8868 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * ada-lang.c (ada_language_defn): Initialise new field.
8871         * c-lang.c (c_is_string_type_p): New function.
8872         (c_language_defn): Initialise new field.
8873         (cplus_language_defn): Initialise new field.
8874         (asm_language_defn): Initialise new field.
8875         (minimal_language_defn): Initialise new field.
8876         * c-lang.h (c_is_string_type_p): Declare new function.
8877         * d-lang.c (d_language_defn): Initialise new field.
8878         * f-lang.c (f_is_string_type_p): New function.
8879         (f_language_defn): Initialise new field.
8880         * go-lang.c (go_is_string_type_p): New function.
8881         (go_language_defn): Initialise new field.
8882         * language.c (default_is_string_type_p): New function.
8883         (unknown_language_defn): Initialise new field.
8884         (auto_language_defn): Initialise new field.
8885         * language.h (struct language_defn) <la_is_string_type_p>: New
8886         member variable.
8887         (default_is_string_type_p): Declare new function.
8888         * m2-lang.c (m2_language_defn): Initialise new field.
8889         * objc-lang.c (objc_language_defn): Initialise new field.
8890         * opencl-lang.c (opencl_language_defn): Initialise new field.
8891         * p-lang.c (pascal_is_string_type_p): New function.
8892         (pascal_language_defn): Initialise new field.
8893         * rust-lang.c (rust_is_string_type_p): New function.
8894         (rust_language_defn): Initialise new field.
8895
8896 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8899         New field.
8900         * ada-lang.c (ada_language_defn): Initialise new field.
8901         * c-lang.c (c_language_defn): Likewise.
8902         (cplus_language_defn): Likewise.
8903         (asm_language_defn): Likewise.
8904         (minimal_language_defn): Likewise.
8905         * d-lang.c (d_language_defn): Likewise.
8906         * f-lang.c (f_language_defn): Likewise.
8907         * go-lang.c (go_language_defn): Likewise.
8908         * language.c (unknown_language_defn): Likewise.
8909         (auto_language_defn): Likewise.
8910         * m2-lang.c (m2_language_defn): Likewise.
8911         * objc-lang.c (objc_language_defn): Likewise.
8912         * opencl-lang.c (opencl_language_defn): Likewise.
8913         * p-lang.c (pascal_language_defn): Likewise.
8914         * rust-lang.c (rust_language_defn): Likewise.
8915
8916 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8917
8918         * ada-lang.c (ada_is_character_type): Change return type to bool.
8919         (ada_is_string_type): Likewise.
8920         * ada-lang.h (ada_is_character_type): Update declaration
8921         (ada_is_string_type): Likewise.
8922
8923 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8924
8925         Support style in 'frame|thread apply'
8926
8927         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8928         * record.c (record_start, record_stop): Update callers of
8929         execute_command_to_string with false.
8930         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8931         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8932         methods.
8933         (class string_file): New constructor with term_out parameter.
8934         Override methods term_out and can_emit_style_escape.  New member
8935         term_out.
8936         (class stdio_file): Override can_emit_style_escape.
8937         (class tee_file): Override term_out and can_emit_style_escape.
8938         * utils.h (can_emit_style_escape): Remove.
8939         * utils.c (can_emit_style_escape): Likewise.
8940         Update all callers of can_emit_style_escape (SOMESTREAM) to
8941         SOMESTREAM->can_emit_style_escape.
8942         * source-cache.c (source_cache::get_source_lines): Likewise.
8943         * stack.c (frame_apply_command_count): Call execute_command_to_string
8944         passing the term_out characteristic of the current gdb_stdout.
8945         * thread.c (thr_try_catch_cmd): Likewise.
8946         * top.c (execute_command_to_string): pass term_out parameter
8947         to construct the string_file for the command output.
8948         * ui-file.c (term_cli_styling): New function (most code moved
8949         from utils.c can_emit_style_escape).
8950         (string_file::string_file, string_file::can_emit_style_escape,
8951         stdio_file::can_emit_style_escape, tee_file::term_out,
8952         tee_file::can_emit_style_escape): New functions.
8953
8954 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8955
8956         * NEWS: Mention the new set|show may-call-functions.
8957         * infcall.c (may_call_functions_p): New variable.
8958         (show_may_call_functions_p): New function.
8959         (call_function_by_hand_dummy): Throws an error if not
8960         may-call-functions.
8961         (_initialize_infcall): Call add_setshow_boolean_cmd for
8962         may-call-functions.
8963
8964 2019-04-25  Keith Seitz  <keiths@redhat.com>
8965
8966         PR c++/24367
8967         * cp-support.c (inspect_type): Don't attempt substitutions
8968         of symbol with the same name.
8969
8970 2019-04-25  Tom Tromey  <tromey@adacore.com>
8971
8972         PR gdb/24475:
8973         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8974         static.
8975
8976 2019-04-25  Tom Tromey  <tromey@adacore.com>
8977
8978         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8979         rvalue reference.
8980         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8981         (gdb_xml_parser::parse): Use std::move.
8982         * python/python-internal.h (gdbpy_convert_exception): Take a const
8983         reference.
8984         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8985         std::move.
8986         * python/py-utils.c (gdbpy_convert_exception): Take a const
8987         reference.
8988         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8989         Use std::move.
8990         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8991         Use std::move.
8992         * mi/mi-main.c (mi_print_exception): Take a const reference.
8993         * main.c (handle_command_errors): Take a const reference.
8994         * linespec.c (parse_linespec): Use std::move.
8995         * infcall.c (run_inferior_call): Use std::move.
8996         (call_function_by_hand_dummy): Use std::move.
8997         * exec.c (try_open_exec_file): Use std::move.
8998         * exceptions.h (exception_print, exception_fprintf)
8999         (exception_print_same): Update.
9000         * exceptions.c (print_exception, exception_print)
9001         (exception_fprintf, exception_print_same): Change parameters to
9002         const reference.
9003         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9004         * common/new-op.c: Use std::move.
9005         * common/common-exceptions.h (struct gdb_exception): Add move
9006         constructor.
9007         (struct gdb_exception_error, struct gdb_exception_quit, struct
9008         gdb_quit_bad_alloc): Change constructor to move constructor.
9009         (throw_exception): Change parameter to rvalue reference.
9010         * common/common-exceptions.c (throw_exception): Take rvalue
9011         reference.
9012         * cli/cli-interp.c (safe_execute_command): Use std::move.
9013         * breakpoint.c (insert_bp_location, location_to_sals): Use
9014         std::move.
9015
9016 2019-04-25  Tom Tromey  <tromey@adacore.com>
9017
9018         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9019         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9020         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9021         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9022         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9023         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9024         guile/scm-value.c: Use unpack.
9025         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9026         gdbscm_gdb_exception.
9027         (gdbscm_throw_gdb_exception): Likewise.
9028         (struct gdbscm_gdb_exception): New.
9029         (unpack): New function.
9030         (gdbscm_wrap): Use unpack.
9031
9032 2019-04-25  Tom Tromey  <tromey@adacore.com>
9033
9034         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9035         (gdb_rl_callback_handler): Use std::move.
9036         * common/common-exceptions.h (struct gdb_exception): Add move
9037         assignment operator.
9038         (throw_exception_sjlj): Change "exception" to const reference.
9039         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9040         (throw_exception_sjlj): Change "exception" to const reference.
9041
9042 2019-04-25  Tom Tromey  <tromey@adacore.com>
9043
9044         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9045         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9046         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9047         Update.
9048         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9049         Update.
9050         * mi/mi-interp.c (mi_interp::exec): Update.
9051         * linespec.c (parse_linespec): Update.
9052         * infcall.c (run_inferior_call): Update.
9053         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9054         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9055         (gdbscm_lookup_global_symbol): Update.
9056         * guile/scm-param.c (gdbscm_parameter_value): Update.
9057         * guile/scm-frame.c (gdbscm_frame_read_register)
9058         (gdbscm_frame_read_var): Update.
9059         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9060         * exec.c (try_open_exec_file): Update.
9061         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9062         (gdb_rl_callback_handler): Update.
9063         * common/common-exceptions.h (exception_none): Don't declare.
9064         * common/common-exceptions.c (exception_none): Don't define.
9065         (struct catcher) <exception>: Update.
9066         * cli/cli-interp.c (safe_execute_command): Update.
9067         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9068
9069 2019-04-25  Ali Tamur  <tamur@google.com>
9070
9071         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9072         (read_attribute_value): Likewise.
9073         (dwarf2_read_addr_index): Update comment.
9074         (read_str_index): Add DW_FORM_strx.
9075         (dwarf2_string_attr): Likewise.
9076         (dwarf2_const_value_attr): Likewise.
9077         (dump_die_shallow): Likewise.
9078         (dwarf2_fetch_constant_bytes): Likewise.
9079         (skip_form_bytes): Likewise.
9080         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9081
9082 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9083
9084         PR corefiles/11608
9085         PR corefiles/18187
9086         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9087         OFFSET.  Verify if current mapping contains an ELF header.
9088         (linux_find_memory_regions_full): Adjust call to
9089         dump_mapping_p.
9090
9091 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9092             Kang Li <kanglictf@gmail.com>
9093
9094         PR gdb/21600
9095
9096         * dwarf2-frame.c (read_initial_length): Be consistent about using
9097         unsigned representation of length.
9098         (decode_frame_entry_1): Likewise.  Check for wraparound of
9099         end pointer as well as buffer overflow.
9100
9101 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9102
9103         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9104         "vq".
9105
9106 2019-04-24  Tom Tromey  <tromey@adacore.com>
9107
9108         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9109
9110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9111
9112         * s12z-tdep.c (s12z_unwind_pc): Delete.
9113         (s12z_unwind_sp): Delete.
9114         (s12z_gdbarch_init): Don't register deleted functions with
9115         gdbarch.
9116
9117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * rl78-tdep.c (rl78_unwind_sp): Delete.
9120         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9121
9122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9123
9124         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9125         (xstormy16_unwind_pc): Delete.
9126         (xstormy16_dummy_id): Delete.
9127         (xstormy16_gdbarch_init): Don't register deleted functions with
9128         gdbarch.
9129
9130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9131
9132         * vax-tdep.c (vax_unwind_pc): Delete.
9133         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9134
9135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9136
9137         * v850-tdep.c (v850_unwind_sp): Delete.
9138         (v850_unwind_pc): Delete.
9139         (v850_dummy_id): Delete.
9140         (v850_gdbarch_init): Don't register deleted functions with
9141         gdbarch.
9142
9143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9144
9145         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9146         (tilegx_unwind_pc): Delete.
9147         (tilegx_unwind_dummy_id): Delete.
9148         (tilegx_gdbarch_init): Don't register deleted functions with
9149         gdbarch.
9150
9151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9152
9153         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9154         (tic6x_dummy_id): Delete.
9155         (tic6x_gdbarch_init): Don't register deleted functions with
9156         gdbarch.
9157
9158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * sparc-tdep.c (sparc_unwind_pc): Delete.
9161         (sparc32_gdbarch_init): Don't register deleted function with
9162         gdbarch.
9163
9164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9165
9166         * sh-tdep.c (sh_unwind_sp): Delete.
9167         (sh_unwind_pc): Delete.
9168         (sh_dummy_id): Delete.
9169         (sh_gdbarch_init): Don't register deleted functions with
9170         gdbarch.
9171
9172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9173
9174         * score-tdep.c (score_unwind_sp): Delete.
9175         (score_unwind_pc): Delete.
9176         (score_dummy_id): Delete.
9177         (score_gdbarch_init): Don't register deleted functions with
9178         gdbarch.
9179
9180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9181
9182         * rx-tdep.c (rx_unwind_pc): Delete.
9183         (rx_unwind_sp): Delete.
9184         (rx_dummy_id): Delete.
9185         (rx_gdbarch_init): Don't register deleted functions with
9186         gdbarch.  Update comment.
9187
9188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9189
9190         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9191         (rs6000_dummy_id): Delete.
9192         (rs6000_gdbarch_init): Don't register deleted functions with
9193         gdbarch.
9194
9195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * or1k-tdep.c (or1k_dummy_id): Delete.
9198         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9199
9200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * nios2-tdep.c (nios2_dummy_id): Delete.
9203         (nios2_unwind_sp): Delete.
9204         (nios2_gdbarch_init): Don't register deleted functions with
9205         gdbarch.
9206
9207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9208
9209         * nds32-tdep.c (nds32_dummy_id): Delete.
9210         (nds32_unwind_pc): Delete.
9211         (nds32_unwind_sp): Delete.
9212         (nds32_gdbarch_init): Don't register deleted functions with
9213         gdbarch.
9214
9215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9216
9217         * msp430-tdep.c (msp430_unwind_pc): Delete.
9218         (msp430_unwind_sp): Delete.
9219         (msp430_dummy_id): Delete.
9220         (msp430_gdbarch_init): Don't register deleted functions with
9221         gdbarch.
9222
9223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9224
9225         * moxie-tdep.c (moxie_unwind_sp): Delete.
9226         (moxie_unwind_pc): Delete.
9227         (moxie_dummy_id): Delete.
9228         (moxie_gdbarch_init): Don't register deleted functions with
9229         gdbarch.
9230
9231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9234         (mn10300_unwind_pc): Delete.
9235         (mn10300_unwind_sp): Delete.
9236         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9237         mn10300_unwind_sp.
9238         (mn10300_frame_unwind_init): Don't register deleted functions with
9239         gdbarch.
9240
9241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * mep-tdep.c (mep_unwind_pc): Delete.
9244         (mep_unwind_sp): Delete.
9245         (mep_dummy_id): Delete.
9246         (mep_gdbarch_init): Don't register deleted functions with
9247         gdbarch.
9248
9249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9252         (m68hc11_unwind_sp): Delete.
9253         (m68hc11_gdbarch_init): Don't register deleted functions with
9254         gdbarch.
9255
9256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * m32r-tdep.c (m32r_unwind_sp): Delete.
9259         (m32r_unwind_pc): Delete.
9260         (m32r_dummy_id): Delete.
9261         (m32r_gdbarch_init): Don't register deleted functions with
9262         gdbarch.
9263
9264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * m32c-tdep.c (m32c_unwind_pc): Delete.
9267         (m32c_unwind_sp): Delete.
9268         (m32c_dummy_id): Delete.
9269         (m32c_gdbarch_init): Don't register deleted functions with
9270         gdbarch.
9271
9272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9273
9274         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9275         (lm32_unwind_pc): Delete.
9276         (lm32_dummy_id): Delete.
9277         (lm32_gdbarch_init): Don't register deleted functions with
9278         gdbarch.
9279
9280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9283         (iq2000_unwind_pc): Delete.
9284         (iq2000_dummy_id): Delete.
9285         (iq2000_gdbarch_init): Don't register deleted functions with
9286         gdbarch.
9287
9288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9289
9290         * nds32-tdep.c (nds32_type_align): Delete.
9291         (nds32_push_dummy_call): Use type_align instead.
9292
9293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9294
9295         * arm-tdep.c (arm_type_align): Only handle vector override case.
9296         (arm_push_dummy_call): Use type_align.
9297         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9298
9299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9302         case.
9303         (pass_on_stack): Use type_align.
9304         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9305         function.
9306
9307 2019-04-23  Tom Tromey  <tromey@adacore.com>
9308
9309         * dwarf2read.c (line_header::file_name_at): Remove unused
9310         overload.
9311
9312 2019-04-23  Tom de Vries  <tdevries@suse.de>
9313
9314         PR gdb/24438
9315         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9316         invocation.
9317
9318
9319 2019-03-27  Ali Tamur  <tamur@google.com>
9320
9321         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9322         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9323         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9324         (dwarf_expr_context::get_addr_index): Likewise
9325         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9326         (symbol_needs_eval_context::get_addr_index): Likewise
9327         (disassemble_dwarf_expression): Add DW_OP_addrx
9328         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9329         (read_cutu_die_from_dwo): Update comment
9330         (skip_one_die): Add DW_FORM_addrx
9331         (read_attribute_value): Likewise
9332         (var_decode_location): Add DW_OP_addrx
9333         (dwarf2_const_value_attr): Add DW_FORM_addrx
9334         (dump_die_shallow): Likewise
9335         (dwarf2_fetch_constant_bytes): Likewise
9336         (decode_locdesc): Add DW_OP_addrx
9337         (skip_form_bytes): Add DW_FORM_addrx
9338
9339 2019-04-22  Ali Tamur  <tamur@google.com>
9340
9341         * MAINTAINERS (Write After Approval): Add self.
9342
9343 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9344
9345         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9346         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9347         (open_symbol_file_object): Likewise.
9348         (svr4_default_sos): Add info parameter.
9349         (svr4_read_so_list): Likewise.
9350         (svr4_current_sos_direct): Adjust functions calls to pass down
9351         info.
9352         (svr4_current_sos_1): Add info parameter.
9353         (svr4_current_sos): Call get_svr4_info, pass info down to
9354         svr4_current_sos_1.
9355         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9356         get_svr4_info.
9357         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9358         get_svr4_info.
9359         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9360         to get_svr4_info.
9361         (probes_table_remove_objfile_probes): Likewise.
9362         (register_solib_event_probe): Add info parameter.
9363         (solist_update_incremental): Pass info parameter down to
9364         svr4_read_so_list.
9365         (disable_probes_interface): Add info parameter.
9366         (svr4_handle_solib_event): Pass current_program_space to
9367         get_svr4_info.  Adjust disable_probes_interface cleanup.
9368         (svr4_create_probe_breakpoints): Add info parameter, pass it
9369         down to register_solib_event_probe.
9370         (svr4_create_solib_event_breakpoints): Add info parameter,
9371         pass it down to svr4_create_probe_breakpoints.
9372         (enable_break): Pass info down to
9373         svr4_create_solib_event_breakpoints.
9374         (svr4_solib_create_inferior_hook): Pass current_program_space to
9375         get_svr4_info.
9376         (svr4_clear_solib): Likewise.
9377
9378 2019-04-22  Pedro Alves  <palves@redhat.com>
9379
9380         * solib-svr4.c (svr4_free_objfile_observer): New.
9381         (probe_and_action::objfile): New field.
9382         (probes_table_htab_remove_objfile_probes)
9383         (probes_table_remove_objfile_probes): New functions.
9384         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9385         in the new probe_and_action.  Don't store the probe in 'lookup'.
9386         (svr4_create_probe_breakpoints): Pass objfile to
9387         register_solib_event_probe.
9388         (_initialize_svr4_solib): Register a free_objfile observer.
9389
9390 2019-04-19  Tom Tromey  <tom@tromey.com>
9391
9392         * common/queue.h: Remove.
9393
9394 2019-04-19  Tom Tromey  <tom@tromey.com>
9395
9396         * event-loop.c: Don't include "common/queue.h".
9397
9398 2019-04-19  Tom Tromey  <tom@tromey.com>
9399
9400         * remote.c (remote_target): Use delete.
9401         * remote-notif.h: Include <list>, not "common/queue.h".
9402         (notif_client_p): Remove typedef.
9403         (remote_notif_state): Add constructor, destructor, initializer.
9404         <notif_queue>: Now a std::list.
9405         (remote_notif_state_xfree): Don't declare.
9406         * remote-notif.c (remote_notif_process, handle_notification)
9407         (remote_notif_state_allocate): Update.
9408         (~remote_notif_state): Rename from remote_notif_state_xfree.
9409
9410 2019-04-19  Tom Tromey  <tom@tromey.com>
9411
9412         * symfile.c (reread_symbols): Update.
9413         * objfiles.c (objfile_register_static_link)
9414         (objfile_lookup_static_link): Update
9415         (~objfile) Don't delete static_links.
9416         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9417
9418 2019-04-19  Tom Tromey  <tom@tromey.com>
9419
9420         * type-stack.h (struct type_stack) <insert>: Constify string.
9421         * type-stack.c (type_stack::insert): Constify string.
9422         * gdbtypes.h (lookup_template_type): Update.
9423         (address_space_name_to_int): Update.
9424         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9425         const.
9426         (lookup_template_type): Make name const.
9427         * c-exp.y: Update rules.
9428         (lex_one_token, classify_name, classify_inner_name)
9429         (c_print_token): Update.
9430         * p-exp.y: Update rules.
9431         (yylex): Update.
9432         * f-exp.y: Update rules.
9433         (yylex): Update.
9434         * d-exp.y: Update rules.
9435         (lex_one_token, classify_name, classify_inner_name): Update.
9436         * parse.c (write_dollar_variable, copy_name): Return std::string.
9437         * parser-defs.h (copy_name): Change return type.
9438         * m2-exp.y: Update rules.
9439         (yylex): Update.
9440         * go-exp.y (lex_one_token): Update.
9441         Update rules.
9442         (classify_unsafe_function, classify_packaged_name)
9443         (classify_name, yylex): Update.
9444
9445 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9446
9447         * configure.ac: add --enable-source-highlight switch.
9448         * configure: Regenerate.
9449         * top.c (print_gdb_version): plumb --enable-source-highlight
9450         status to "show configuration".
9451
9452 2019-04-19  Tom Tromey  <tromey@adacore.com>
9453
9454         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9455         Check ADA_TYPE_P.
9456         (empty_record, ada_template_to_fixed_record_type_1)
9457         (template_to_static_fixed_type)
9458         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9459         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9460         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9461         macros.
9462
9463 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9464
9465         PR symtab/24423:
9466         * source.c (print_source_lines_base): Advance "iter" when a
9467         control character is seen.
9468
9469 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9470
9471         * inferior.h (struct infcall_suspend_state_deleter):
9472         Catch exception in destructor to avoid crash.
9473
9474 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9475
9476         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9477         close to the add_com "shell".
9478
9479 2019-04-18  Tom Tromey  <tromey@adacore.com>
9480
9481         * process-stratum-target.h (class process_stratum_target)
9482         <stratum>: Add "final".
9483
9484 2019-04-17  Tom Tromey  <tromey@adacore.com>
9485
9486         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9487         against nullptr before use.
9488
9489 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9490
9491         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9492
9493 2019-04-17  Jim Wilson  <jimw@sifive.com>
9494             Andrew Burgess  <andrew.burgess@embecosm.com>
9495
9496         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9497         code read might fail, assume 4-byte breakpoint in that case.
9498
9499 2019-04-15  Leszek Swirski  <leszeks@google.com>
9500
9501         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9502         rather than a hand-rolled POD check when checking for forced MEMORY
9503         classification.
9504
9505 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9506
9507         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9508         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9509         function.
9510         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9511         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9512         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9513         declaration.
9514
9515 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9516
9517         * aarch64-linux-nat.c
9518         (aarch64_linux_nat_target::thread_architecture): Add override.
9519         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9520         each VQ.
9521
9522 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9523
9524         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9525
9526 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9527
9528         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9529         target types of size 96-bits, add some additional comments, and
9530         check that the builtin type we found was the correct size.
9531
9532 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9533
9534         * utils.c (prompt_for_continue): Don't restore the styling at the
9535         end, as applied_style has the wrong value.  This fixes styling in
9536         long lists of file names that are interrupted by the "Continue?"
9537         prompt.
9538
9539 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9540
9541         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9542         * c-lang.c (c_language_defn): Likewise.
9543         (cplus_language_defn): Likewise.
9544         (asm_language_defn): Likewise.
9545         (minimal_language_defn): Likewise.
9546         * d-lang.c (d_language_defn): Likewise.
9547         * f-lang.c (f_language_defn): Likewise.
9548         * go-lang.c (go_language_defn): Likewise.
9549         * language.c (unknown_language_defn): Likewise.
9550         (auto_language_defn): Likewise.
9551         * language.h (struct language_defn): Remove la_magic field.
9552         (LANG_MAGIC): Delete.
9553         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9554         * objc-lang.c (objc_language_defn): Likewise.
9555         * opencl-lang.c (opencl_language_defn): Likewise.
9556         * p-lang.c (pascal_language_defn): Likewise.
9557         * rust-lang.c (rust_language_defn): Likewise.
9558
9559 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9560
9561         * riscv-tdep.c (riscv_type_align): New function.
9562         (riscv_type_alignment): Delete.
9563         (riscv_arg_location): Use 'type_align'.
9564         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9565
9566 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * gdbtypes.c (type_align): A struct with no non-static fields also
9569         has alignment of 1.
9570
9571 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9572
9573         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9574         component to 0.
9575         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9576         member.
9577         (riscv_struct_info::analyse): New implementation using new
9578         analyse_inner member function.
9579         (riscv_struct_info::field_offset): New member function.
9580         (riscv_struct_info::m_offsets): New member variable.
9581         (riscv_struct_info::analyse_inner): New private member function,
9582         takes the old implementation of riscv_struct_info::analyse but
9583         extended to track field offsets.
9584         (riscv_call_arg_struct): Update the struct folding special cases
9585         to handle cases where empty C++ structs, which are non-zero
9586         length, are found.
9587         (riscv_arg_location): Initialise the length of each location, a
9588         non-zero length now indicates the location is in use.
9589         (riscv_push_dummy_call): Allow for the first location having a
9590         non-zero offset when setting up arguments.
9591         (riscv_return_value): Likewise, but for return values.
9592
9593 2019-04-11  Tom Tromey  <tromey@adacore.com>
9594
9595         * utils.c (internal_vproblem): Make "msg" const.
9596
9597 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9598
9599         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9600         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9601         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9602         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9603
9604 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9605
9606         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9607         function.
9608         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9609         of amd64_collect_native_gregset.
9610         (amd64_linux_nat_target::store_registers): Likewise.
9611
9612 2019-04-10  Tom Tromey  <tom@tromey.com>
9613
9614         * symtab.c (lookup_global_symbol_from_objfile)
9615         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9616         * objfiles.h (class separate_debug_iterator): New.
9617         (class separate_debug_range): New.
9618         (struct objfile) <separate_debug_objfiles>: New method.
9619         (objfile_separate_debug_iterate): Don't declare.
9620         * objfiles.c (separate_debug_iterator::operator++): Rename from
9621         objfile_separate_debug_iterate.
9622         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9623         iterator.
9624         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9625         iterator.
9626
9627 2019-04-10  Tom Tromey  <tom@tromey.com>
9628
9629         * symfile.c (reread_symbols): Remove old comment.
9630         * objfiles.c (free_all_objfiles): Fix a typo.
9631
9632 2019-04-10  Tom Tromey  <tom@tromey.com>
9633
9634         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9635         * minsyms.c (lookup_minimal_symbol): Use foreach.
9636         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9637         (lookup_minimal_symbol_solib_trampoline): Likewise.
9638         * symfile.c (reread_symbols): Use foreach.
9639
9640 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9641             Tom Tromey  <tromey@adacore.com>
9642
9643         PR rust/24414:
9644         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9645         (rust_lex_int_test): Change "value" to be LONGEST.
9646         (rust_lex_tests): Add test for long integer literal.
9647
9648 2019-04-09  Tom Tromey  <tromey@adacore.com>
9649
9650         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9651         to bool.
9652         (extended_remote_target::attach): Update.
9653         (remote_target::remote_notice_new_inferior): Update.
9654         (remote_target::add_current_inferior_and_thread): Update.
9655         * inferior.c (exit_inferior_1): Use "false".
9656         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9657
9658 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9659
9660         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9661         the "start" command.
9662
9663 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9664
9665         * python/py-inferior.c (infpy_thread_from_thread_handle):
9666         Adjust comments to reflect renaming of thread_from_thread_handle
9667         to thread_from_handle.  Adjust keywords.  Fix type error message.
9668         (inferior_object_methods): Add thread_from_handle.  Retain
9669         thread_from_thread_handle, but mark it as deprecated.
9670
9671 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9672
9673         * gdbthread.h (find_thread_by_handle): Revise declaration.
9674         * thread.c (find_thread_by_handle): Likewise.  Adjust
9675         implementation too.
9676         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9677         support for buffer objects as handles.
9678
9679 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9680
9681         * python/py-infthread.c (thpy_thread_handle): New function.
9682         (thread_object_methods): Register thpy_thread_handle.
9683
9684 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9685
9686         * gdbthread.h (thread_to_thread_handle): Declare.
9687         * thread.c (gdbtypes.h): Include.
9688         (thread_to_thread_handle): New function.
9689
9690         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9691         (target_thread_info_to_thread_handle): Declare.
9692         * target.c (target_thread_info_to_thread_handle): New function.
9693         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9694         * target-delegates.c: Regenerate.
9695
9696         * linux-thread-db.c (class thread_db_target): Add method
9697         thread_info_to_thread_handle.
9698         (thread_db_target::thread_info_to_thread_handle): Define.
9699         * remote.c (class remote_target): Add new method
9700         thread_info_to_thread_handle.
9701         (remote_target::thread_info_to_thread_handle): Define.
9702
9703 2019-04-08  Pedro Alves  <palves@redhat.com>
9704
9705         * common/common-exceptions.c (throw_exception): Don't create
9706         named object to throw; throw directly.
9707         (throw_it): Likewise.  Don't initialize gdb_exception::message
9708         here, with new; pass FMT and AP to the ctor instead.
9709         * common/common-exceptions.h: Include <string>.
9710         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9711         const char *, va_list)): New ctor.  Use std::make_shared.
9712         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9713         errors)): Delete.
9714         (gdb_exception_error::gdb_exception_error(enum errors, const char
9715         *, va_list)): New.
9716         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9717         Add assertion.
9718         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9719         errors)): Delete.
9720         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9721         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9722         Add assertion.
9723
9724 2019-04-08  Tom Tromey  <tom@tromey.com>
9725
9726         * valops.c (value_rtti_indirect_type): Replace throw_exception
9727         with throw.
9728         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9729         with throw.
9730         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9731         throw.
9732         * target.c (target_translate_tls_address): Replace throw_exception
9733         with throw.
9734         * stack.c (frame_apply_command_count): Replace throw_exception
9735         with throw.
9736         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9737         throw.
9738         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9739         with throw.
9740         * rs6000-tdep.c (rs6000_frame_cache)
9741         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9742         * remote.c: Replace throw_exception with throw.
9743         * record-full.c (record_full_message, record_full_wait_1)
9744         (record_full_restore): Replace throw_exception with throw.
9745         * record-btrace.c:
9746         (get_thread_current_frame_id, record_btrace_start_replaying)
9747         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9748         (cmd_record_btrace_start): Replace throw_exception with throw.
9749         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9750         throw.
9751         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9752         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9753         * linespec.c:
9754         (find_linespec_symbols): Replace throw_exception with throw.
9755         * infrun.c (displaced_step_prepare, resume): Replace
9756         throw_exception with throw.
9757         * infcmd.c (post_create_inferior): Replace throw_exception with
9758         throw.
9759         * inf-loop.c (inferior_event_handler): Replace throw_exception
9760         with throw.
9761         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9762         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9763         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9764         (get_prev_frame_always, get_frame_pc_if_available)
9765         (get_frame_address_in_block_if_available, get_frame_language):
9766         Replace throw_exception with throw.
9767         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9768         throw_exception with throw.
9769         * eval.c (fetch_subexp_value, evaluate_var_value)
9770         (evaluate_funcall, evaluate_subexp_standard): Replace
9771         throw_exception with throw.
9772         * dwarf2loc.c (call_site_find_chain)
9773         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9774         Replace throw_exception with throw.
9775         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9776         with throw.
9777         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9778         throw.
9779         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9780         * completer.c (complete_line_internal): Replace throw_exception
9781         with throw.
9782         * compile/compile-object-run.c (compile_object_run): Replace
9783         throw_exception with throw.
9784         * cli/cli-script.c (process_next_line): Replace throw_exception
9785         with throw.
9786         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9787         (btrace_enable, btrace_maint_update_pt_packets): Replace
9788         throw_exception with throw.
9789         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9790         throw_exception with throw.
9791         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9792         throw_exception with throw.
9793         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9794         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9795         * aarch64-tdep.c (aarch64_make_prologue_cache)
9796         (aarch64_make_stub_cache): Replace throw_exception with throw.
9797
9798 2019-04-08  Tom Tromey  <tom@tromey.com>
9799
9800         * common/common-exceptions.c (throw_exception): Rename from
9801         throw_exception_cxx.  Remove old copy.  Make argument const.
9802         (throw_it): Create and throw exception objects directly.
9803         * common/common-exceptions.h (throw_exception): Make argument
9804         const.
9805         (struct gdb_exception_error): Add constructor.
9806         (struct gdb_exception_quit): Add constructor.
9807
9808 2019-04-08  Tom Tromey  <tom@tromey.com>
9809
9810         * common/common-exceptions.h (exception_rethrow): Don't declare.
9811         (TRY_SJLJ): Update comment.
9812         (TRY, CATCH, END_CATCH): Remove.
9813         * common/common-exceptions.c (exception_rethrow): Remove.
9814
9815 2019-04-08  Tom Tromey  <tom@tromey.com>
9816
9817         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9818         Remove.
9819         (gdb_exception_error): Rename from
9820         gdb_exception_RETURN_MASK_ERROR.
9821         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9822         (gdb_quit_bad_alloc): Update.
9823         * aarch64-tdep.c: Update.
9824         * ada-lang.c: Update.
9825         * ada-typeprint.c: Update.
9826         * ada-valprint.c: Update.
9827         * amd64-tdep.c: Update.
9828         * arch-utils.c: Update.
9829         * break-catch-throw.c: Update.
9830         * breakpoint.c: Update.
9831         * btrace.c: Update.
9832         * c-varobj.c: Update.
9833         * cli/cli-cmds.c: Update.
9834         * cli/cli-interp.c: Update.
9835         * cli/cli-script.c: Update.
9836         * common/common-exceptions.c: Update.
9837         * common/new-op.c: Update.
9838         * common/selftest.c: Update.
9839         * compile/compile-c-symbols.c: Update.
9840         * compile/compile-cplus-symbols.c: Update.
9841         * compile/compile-object-load.c: Update.
9842         * compile/compile-object-run.c: Update.
9843         * completer.c: Update.
9844         * corelow.c: Update.
9845         * cp-abi.c: Update.
9846         * cp-support.c: Update.
9847         * cp-valprint.c: Update.
9848         * darwin-nat.c: Update.
9849         * disasm-selftests.c: Update.
9850         * dtrace-probe.c: Update.
9851         * dwarf-index-cache.c: Update.
9852         * dwarf-index-write.c: Update.
9853         * dwarf2-frame-tailcall.c: Update.
9854         * dwarf2-frame.c: Update.
9855         * dwarf2loc.c: Update.
9856         * dwarf2read.c: Update.
9857         * eval.c: Update.
9858         * event-loop.c: Update.
9859         * event-top.c: Update.
9860         * exec.c: Update.
9861         * f-valprint.c: Update.
9862         * fbsd-tdep.c: Update.
9863         * frame-unwind.c: Update.
9864         * frame.c: Update.
9865         * gdbtypes.c: Update.
9866         * gnu-v3-abi.c: Update.
9867         * guile/guile-internal.h: Update.
9868         * guile/scm-block.c: Update.
9869         * guile/scm-breakpoint.c: Update.
9870         * guile/scm-cmd.c: Update.
9871         * guile/scm-disasm.c: Update.
9872         * guile/scm-frame.c: Update.
9873         * guile/scm-lazy-string.c: Update.
9874         * guile/scm-math.c: Update.
9875         * guile/scm-param.c: Update.
9876         * guile/scm-ports.c: Update.
9877         * guile/scm-pretty-print.c: Update.
9878         * guile/scm-symbol.c: Update.
9879         * guile/scm-symtab.c: Update.
9880         * guile/scm-type.c: Update.
9881         * guile/scm-value.c: Update.
9882         * i386-linux-tdep.c: Update.
9883         * i386-tdep.c: Update.
9884         * inf-loop.c: Update.
9885         * infcall.c: Update.
9886         * infcmd.c: Update.
9887         * infrun.c: Update.
9888         * jit.c: Update.
9889         * language.c: Update.
9890         * linespec.c: Update.
9891         * linux-fork.c: Update.
9892         * linux-nat.c: Update.
9893         * linux-tdep.c: Update.
9894         * linux-thread-db.c: Update.
9895         * main.c: Update.
9896         * mi/mi-cmd-break.c: Update.
9897         * mi/mi-cmd-stack.c: Update.
9898         * mi/mi-interp.c: Update.
9899         * mi/mi-main.c: Update.
9900         * objc-lang.c: Update.
9901         * p-valprint.c: Update.
9902         * parse.c: Update.
9903         * ppc-linux-tdep.c: Update.
9904         * printcmd.c: Update.
9905         * python/py-arch.c: Update.
9906         * python/py-breakpoint.c: Update.
9907         * python/py-cmd.c: Update.
9908         * python/py-finishbreakpoint.c: Update.
9909         * python/py-frame.c: Update.
9910         * python/py-framefilter.c: Update.
9911         * python/py-gdb-readline.c: Update.
9912         * python/py-inferior.c: Update.
9913         * python/py-infthread.c: Update.
9914         * python/py-lazy-string.c: Update.
9915         * python/py-linetable.c: Update.
9916         * python/py-objfile.c: Update.
9917         * python/py-param.c: Update.
9918         * python/py-prettyprint.c: Update.
9919         * python/py-progspace.c: Update.
9920         * python/py-record-btrace.c: Update.
9921         * python/py-record.c: Update.
9922         * python/py-symbol.c: Update.
9923         * python/py-type.c: Update.
9924         * python/py-unwind.c: Update.
9925         * python/py-utils.c: Update.
9926         * python/py-value.c: Update.
9927         * python/python.c: Update.
9928         * record-btrace.c: Update.
9929         * record-full.c: Update.
9930         * remote-fileio.c: Update.
9931         * remote.c: Update.
9932         * riscv-tdep.c: Update.
9933         * rs6000-aix-tdep.c: Update.
9934         * rs6000-tdep.c: Update.
9935         * rust-exp.y: Update.
9936         * rust-lang.c: Update.
9937         * s390-tdep.c: Update.
9938         * selftest-arch.c: Update.
9939         * solib-dsbt.c: Update.
9940         * solib-frv.c: Update.
9941         * solib-spu.c: Update.
9942         * solib-svr4.c: Update.
9943         * solib.c: Update.
9944         * sparc64-linux-tdep.c: Update.
9945         * stack.c: Update.
9946         * symfile-mem.c: Update.
9947         * symmisc.c: Update.
9948         * target.c: Update.
9949         * thread.c: Update.
9950         * top.c: Update.
9951         * tracefile-tfile.c: Update.
9952         * tui/tui.c: Update.
9953         * typeprint.c: Update.
9954         * unittests/cli-utils-selftests.c: Update.
9955         * unittests/parse-connection-spec-selftests.c: Update.
9956         * valops.c: Update.
9957         * valprint.c: Update.
9958         * value.c: Update.
9959         * varobj.c: Update.
9960         * windows-nat.c: Update.
9961         * x86-linux-nat.c: Update.
9962         * xml-support.c: Update.
9963
9964 2019-04-08  Tom Tromey  <tom@tromey.com>
9965
9966         * xml-support.c: Use C++ exception handling.
9967         * x86-linux-nat.c: Use C++ exception handling.
9968         * windows-nat.c: Use C++ exception handling.
9969         * varobj.c: Use C++ exception handling.
9970         * value.c: Use C++ exception handling.
9971         * valprint.c: Use C++ exception handling.
9972         * valops.c: Use C++ exception handling.
9973         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9974         handling.
9975         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9976         * typeprint.c: Use C++ exception handling.
9977         * tui/tui.c: Use C++ exception handling.
9978         * tracefile-tfile.c: Use C++ exception handling.
9979         * top.c: Use C++ exception handling.
9980         * thread.c: Use C++ exception handling.
9981         * target.c: Use C++ exception handling.
9982         * symmisc.c: Use C++ exception handling.
9983         * symfile-mem.c: Use C++ exception handling.
9984         * stack.c: Use C++ exception handling.
9985         * sparc64-linux-tdep.c: Use C++ exception handling.
9986         * solib.c: Use C++ exception handling.
9987         * solib-svr4.c: Use C++ exception handling.
9988         * solib-spu.c: Use C++ exception handling.
9989         * solib-frv.c: Use C++ exception handling.
9990         * solib-dsbt.c: Use C++ exception handling.
9991         * selftest-arch.c: Use C++ exception handling.
9992         * s390-tdep.c: Use C++ exception handling.
9993         * rust-lang.c: Use C++ exception handling.
9994         * rust-exp.y: Use C++ exception handling.
9995         * rs6000-tdep.c: Use C++ exception handling.
9996         * rs6000-aix-tdep.c: Use C++ exception handling.
9997         * riscv-tdep.c: Use C++ exception handling.
9998         * remote.c: Use C++ exception handling.
9999         * remote-fileio.c: Use C++ exception handling.
10000         * record-full.c: Use C++ exception handling.
10001         * record-btrace.c: Use C++ exception handling.
10002         * python/python.c: Use C++ exception handling.
10003         * python/py-value.c: Use C++ exception handling.
10004         * python/py-utils.c: Use C++ exception handling.
10005         * python/py-unwind.c: Use C++ exception handling.
10006         * python/py-type.c: Use C++ exception handling.
10007         * python/py-symbol.c: Use C++ exception handling.
10008         * python/py-record.c: Use C++ exception handling.
10009         * python/py-record-btrace.c: Use C++ exception handling.
10010         * python/py-progspace.c: Use C++ exception handling.
10011         * python/py-prettyprint.c: Use C++ exception handling.
10012         * python/py-param.c: Use C++ exception handling.
10013         * python/py-objfile.c: Use C++ exception handling.
10014         * python/py-linetable.c: Use C++ exception handling.
10015         * python/py-lazy-string.c: Use C++ exception handling.
10016         * python/py-infthread.c: Use C++ exception handling.
10017         * python/py-inferior.c: Use C++ exception handling.
10018         * python/py-gdb-readline.c: Use C++ exception handling.
10019         * python/py-framefilter.c: Use C++ exception handling.
10020         * python/py-frame.c: Use C++ exception handling.
10021         * python/py-finishbreakpoint.c: Use C++ exception handling.
10022         * python/py-cmd.c: Use C++ exception handling.
10023         * python/py-breakpoint.c: Use C++ exception handling.
10024         * python/py-arch.c: Use C++ exception handling.
10025         * printcmd.c: Use C++ exception handling.
10026         * ppc-linux-tdep.c: Use C++ exception handling.
10027         * parse.c: Use C++ exception handling.
10028         * p-valprint.c: Use C++ exception handling.
10029         * objc-lang.c: Use C++ exception handling.
10030         * mi/mi-main.c: Use C++ exception handling.
10031         * mi/mi-interp.c: Use C++ exception handling.
10032         * mi/mi-cmd-stack.c: Use C++ exception handling.
10033         * mi/mi-cmd-break.c: Use C++ exception handling.
10034         * main.c: Use C++ exception handling.
10035         * linux-thread-db.c: Use C++ exception handling.
10036         * linux-tdep.c: Use C++ exception handling.
10037         * linux-nat.c: Use C++ exception handling.
10038         * linux-fork.c: Use C++ exception handling.
10039         * linespec.c: Use C++ exception handling.
10040         * language.c: Use C++ exception handling.
10041         * jit.c: Use C++ exception handling.
10042         * infrun.c: Use C++ exception handling.
10043         * infcmd.c: Use C++ exception handling.
10044         * infcall.c: Use C++ exception handling.
10045         * inf-loop.c: Use C++ exception handling.
10046         * i386-tdep.c: Use C++ exception handling.
10047         * i386-linux-tdep.c: Use C++ exception handling.
10048         * guile/scm-value.c: Use C++ exception handling.
10049         * guile/scm-type.c: Use C++ exception handling.
10050         * guile/scm-symtab.c: Use C++ exception handling.
10051         * guile/scm-symbol.c: Use C++ exception handling.
10052         * guile/scm-pretty-print.c: Use C++ exception handling.
10053         * guile/scm-ports.c: Use C++ exception handling.
10054         * guile/scm-param.c: Use C++ exception handling.
10055         * guile/scm-math.c: Use C++ exception handling.
10056         * guile/scm-lazy-string.c: Use C++ exception handling.
10057         * guile/scm-frame.c: Use C++ exception handling.
10058         * guile/scm-disasm.c: Use C++ exception handling.
10059         * guile/scm-cmd.c: Use C++ exception handling.
10060         * guile/scm-breakpoint.c: Use C++ exception handling.
10061         * guile/scm-block.c: Use C++ exception handling.
10062         * guile/guile-internal.h: Use C++ exception handling.
10063         * gnu-v3-abi.c: Use C++ exception handling.
10064         * gdbtypes.c: Use C++ exception handling.
10065         * frame.c: Use C++ exception handling.
10066         * frame-unwind.c: Use C++ exception handling.
10067         * fbsd-tdep.c: Use C++ exception handling.
10068         * f-valprint.c: Use C++ exception handling.
10069         * exec.c: Use C++ exception handling.
10070         * event-top.c: Use C++ exception handling.
10071         * event-loop.c: Use C++ exception handling.
10072         * eval.c: Use C++ exception handling.
10073         * dwarf2read.c: Use C++ exception handling.
10074         * dwarf2loc.c: Use C++ exception handling.
10075         * dwarf2-frame.c: Use C++ exception handling.
10076         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10077         * dwarf-index-write.c: Use C++ exception handling.
10078         * dwarf-index-cache.c: Use C++ exception handling.
10079         * dtrace-probe.c: Use C++ exception handling.
10080         * disasm-selftests.c: Use C++ exception handling.
10081         * darwin-nat.c: Use C++ exception handling.
10082         * cp-valprint.c: Use C++ exception handling.
10083         * cp-support.c: Use C++ exception handling.
10084         * cp-abi.c: Use C++ exception handling.
10085         * corelow.c: Use C++ exception handling.
10086         * completer.c: Use C++ exception handling.
10087         * compile/compile-object-run.c: Use C++ exception handling.
10088         * compile/compile-object-load.c: Use C++ exception handling.
10089         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10090         * compile/compile-c-symbols.c: Use C++ exception handling.
10091         * common/selftest.c: Use C++ exception handling.
10092         * common/new-op.c: Use C++ exception handling.
10093         * cli/cli-script.c: Use C++ exception handling.
10094         * cli/cli-interp.c: Use C++ exception handling.
10095         * cli/cli-cmds.c: Use C++ exception handling.
10096         * c-varobj.c: Use C++ exception handling.
10097         * btrace.c: Use C++ exception handling.
10098         * breakpoint.c: Use C++ exception handling.
10099         * break-catch-throw.c: Use C++ exception handling.
10100         * arch-utils.c: Use C++ exception handling.
10101         * amd64-tdep.c: Use C++ exception handling.
10102         * ada-valprint.c: Use C++ exception handling.
10103         * ada-typeprint.c: Use C++ exception handling.
10104         * ada-lang.c: Use C++ exception handling.
10105         * aarch64-tdep.c: Use C++ exception handling.
10106
10107 2019-04-08  Tom Tromey  <tom@tromey.com>
10108
10109         * xml-support.c (gdb_xml_parser::parse): Update.
10110         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10111         * value.c (show_convenience): Update.
10112         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10113         (test_parse_flags_qcs): Update.
10114         * thread.c (thr_try_catch_cmd): Update.
10115         * target.c (target_translate_tls_address): Update.
10116         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10117         (info_frame_command_core, frame_apply_command_count): Update.
10118         * rust-exp.y (rust_lex_exception_test): Update.
10119         * riscv-tdep.c (riscv_print_one_register_info): Update.
10120         * remote.c (remote_target::enable_btrace): Update.
10121         * record-btrace.c (record_btrace_enable_warn): Update.
10122         * python/py-utils.c (gdbpy_convert_exception): Update.
10123         * printcmd.c (do_one_display, print_variable_and_value): Update.
10124         * mi/mi-main.c (mi_print_exception): Update.
10125         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10126         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10127         * linux-nat.c (linux_nat_target::attach): Update.
10128         * linux-fork.c (class scoped_switch_fork_info): Update.
10129         * infrun.c (displaced_step_prepare): Update.
10130         * infcall.c (call_function_by_hand_dummy): Update.
10131         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10132         * gnu-v3-abi.c (print_one_vtable): Update.
10133         * frame.c (get_prev_frame_always): Update.
10134         * f-valprint.c (info_common_command_for_block): Update.
10135         * exec.c (try_open_exec_file): Update.
10136         * exceptions.c (print_exception, exception_print)
10137         (exception_fprintf, exception_print_same): Update.
10138         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10139         * dwarf-index-cache.c (index_cache::store)
10140         (index_cache::lookup_gdb_index): Update.
10141         * darwin-nat.c (maybe_cache_shell): Update.
10142         * cp-valprint.c (cp_print_value_fields): Update.
10143         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10144         (gcc_cplus_symbol_address): Update.
10145         * compile/compile-c-symbols.c (gcc_convert_symbol)
10146         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10147         * common/selftest.c: Update.
10148         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10149         a std::string.
10150         (exception_try_scope_entry, exception_try_scope_exit): Don't
10151         declare.
10152         (struct exception_try_scope): Remove.
10153         (TRY): Don't use exception_try_scope.
10154         (struct gdb_exception): Add constructor, operator=.
10155         <what>: New method.
10156         (struct gdb_exception_RETURN_MASK_ALL)
10157         (struct gdb_exception_RETURN_MASK_ERROR)
10158         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10159         (struct gdb_quit_bad_alloc): Update.
10160         * common/common-exceptions.c (exception_none): Change
10161         initializer.
10162         (struct catcher) <state, exception>: Initialize inline.
10163         <prev>: Remove member.
10164         (current_catcher): Remove.
10165         (catchers): New global.
10166         (exceptions_state_mc_init): Simplify.
10167         (catcher_pop): Remove.
10168         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10169         (try_scope_depth, exception_try_scope_entry)
10170         (exception_try_scope_exit): Remove.
10171         (throw_exception_sjlj): Update.
10172         (exception_messages, exception_messages_size): Remove.
10173         (throw_it): Simplify.
10174         (gdb_exception_sliced_copy): Remove.
10175         (throw_exception_cxx): Update.
10176         * cli/cli-script.c (script_from_file): Update.
10177         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10178         Update.
10179         * ada-valprint.c (ada_val_print): Update.
10180         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10181         (create_excep_cond_exprs): Update.
10182
10183 2019-04-08  Tom Tromey  <tom@tromey.com>
10184
10185         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10186         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10187         (TRY, CATCH, END_CATCH): Remove some definitions.
10188         * common/common-exceptions.c: Don't use GDB_XCPT.
10189         (catcher_list_size): Remove.
10190         (throw_exception, throw_it): Simplify.
10191
10192 2019-04-05  Tom Tromey  <tom@tromey.com>
10193
10194         Revert the header-sorting patch.
10195         * ft32-tdep.c: Revert.
10196         * frv-tdep.c: Revert.
10197         * frv-linux-tdep.c: Revert.
10198         * frame.c: Revert.
10199         * frame-unwind.c: Revert.
10200         * frame-base.c: Revert.
10201         * fork-child.c: Revert.
10202         * findvar.c: Revert.
10203         * findcmd.c: Revert.
10204         * filesystem.c: Revert.
10205         * filename-seen-cache.h: Revert.
10206         * filename-seen-cache.c: Revert.
10207         * fbsd-tdep.c: Revert.
10208         * fbsd-nat.h: Revert.
10209         * fbsd-nat.c: Revert.
10210         * f-valprint.c: Revert.
10211         * f-typeprint.c: Revert.
10212         * f-lang.c: Revert.
10213         * extension.h: Revert.
10214         * extension.c: Revert.
10215         * extension-priv.h: Revert.
10216         * expprint.c: Revert.
10217         * exec.h: Revert.
10218         * exec.c: Revert.
10219         * exceptions.c: Revert.
10220         * event-top.c: Revert.
10221         * event-loop.c: Revert.
10222         * eval.c: Revert.
10223         * elfread.c: Revert.
10224         * dwarf2read.h: Revert.
10225         * dwarf2read.c: Revert.
10226         * dwarf2loc.c: Revert.
10227         * dwarf2expr.h: Revert.
10228         * dwarf2expr.c: Revert.
10229         * dwarf2-frame.c: Revert.
10230         * dwarf2-frame-tailcall.c: Revert.
10231         * dwarf-index-write.h: Revert.
10232         * dwarf-index-write.c: Revert.
10233         * dwarf-index-common.c: Revert.
10234         * dwarf-index-cache.h: Revert.
10235         * dwarf-index-cache.c: Revert.
10236         * dummy-frame.c: Revert.
10237         * dtrace-probe.c: Revert.
10238         * disasm.h: Revert.
10239         * disasm.c: Revert.
10240         * disasm-selftests.c: Revert.
10241         * dictionary.c: Revert.
10242         * dicos-tdep.c: Revert.
10243         * demangle.c: Revert.
10244         * dcache.h: Revert.
10245         * dcache.c: Revert.
10246         * darwin-nat.h: Revert.
10247         * darwin-nat.c: Revert.
10248         * darwin-nat-info.c: Revert.
10249         * d-valprint.c: Revert.
10250         * d-namespace.c: Revert.
10251         * d-lang.c: Revert.
10252         * ctf.c: Revert.
10253         * csky-tdep.c: Revert.
10254         * csky-linux-tdep.c: Revert.
10255         * cris-tdep.c: Revert.
10256         * cris-linux-tdep.c: Revert.
10257         * cp-valprint.c: Revert.
10258         * cp-support.c: Revert.
10259         * cp-namespace.c: Revert.
10260         * cp-abi.c: Revert.
10261         * corelow.c: Revert.
10262         * corefile.c: Revert.
10263         * continuations.c: Revert.
10264         * completer.h: Revert.
10265         * completer.c: Revert.
10266         * complaints.c: Revert.
10267         * coffread.c: Revert.
10268         * coff-pe-read.c: Revert.
10269         * cli-out.h: Revert.
10270         * cli-out.c: Revert.
10271         * charset.c: Revert.
10272         * c-varobj.c: Revert.
10273         * c-valprint.c: Revert.
10274         * c-typeprint.c: Revert.
10275         * c-lang.c: Revert.
10276         * buildsym.c: Revert.
10277         * buildsym-legacy.c: Revert.
10278         * build-id.h: Revert.
10279         * build-id.c: Revert.
10280         * btrace.c: Revert.
10281         * bsd-uthread.c: Revert.
10282         * breakpoint.h: Revert.
10283         * breakpoint.c: Revert.
10284         * break-catch-throw.c: Revert.
10285         * break-catch-syscall.c: Revert.
10286         * break-catch-sig.c: Revert.
10287         * blockframe.c: Revert.
10288         * block.c: Revert.
10289         * bfin-tdep.c: Revert.
10290         * bfin-linux-tdep.c: Revert.
10291         * bfd-target.c: Revert.
10292         * bcache.c: Revert.
10293         * ax-general.c: Revert.
10294         * ax-gdb.h: Revert.
10295         * ax-gdb.c: Revert.
10296         * avr-tdep.c: Revert.
10297         * auxv.c: Revert.
10298         * auto-load.c: Revert.
10299         * arm-wince-tdep.c: Revert.
10300         * arm-tdep.c: Revert.
10301         * arm-symbian-tdep.c: Revert.
10302         * arm-pikeos-tdep.c: Revert.
10303         * arm-obsd-tdep.c: Revert.
10304         * arm-nbsd-tdep.c: Revert.
10305         * arm-nbsd-nat.c: Revert.
10306         * arm-linux-tdep.c: Revert.
10307         * arm-linux-nat.c: Revert.
10308         * arm-fbsd-tdep.c: Revert.
10309         * arm-fbsd-nat.c: Revert.
10310         * arm-bsd-tdep.c: Revert.
10311         * arch-utils.c: Revert.
10312         * arc-tdep.c: Revert.
10313         * arc-newlib-tdep.c: Revert.
10314         * annotate.h: Revert.
10315         * annotate.c: Revert.
10316         * amd64-windows-tdep.c: Revert.
10317         * amd64-windows-nat.c: Revert.
10318         * amd64-tdep.c: Revert.
10319         * amd64-sol2-tdep.c: Revert.
10320         * amd64-obsd-tdep.c: Revert.
10321         * amd64-obsd-nat.c: Revert.
10322         * amd64-nbsd-tdep.c: Revert.
10323         * amd64-nbsd-nat.c: Revert.
10324         * amd64-nat.c: Revert.
10325         * amd64-linux-tdep.c: Revert.
10326         * amd64-linux-nat.c: Revert.
10327         * amd64-fbsd-tdep.c: Revert.
10328         * amd64-fbsd-nat.c: Revert.
10329         * amd64-dicos-tdep.c: Revert.
10330         * amd64-darwin-tdep.c: Revert.
10331         * amd64-bsd-nat.c: Revert.
10332         * alpha-tdep.c: Revert.
10333         * alpha-obsd-tdep.c: Revert.
10334         * alpha-nbsd-tdep.c: Revert.
10335         * alpha-mdebug-tdep.c: Revert.
10336         * alpha-linux-tdep.c: Revert.
10337         * alpha-linux-nat.c: Revert.
10338         * alpha-bsd-tdep.c: Revert.
10339         * alpha-bsd-nat.c: Revert.
10340         * aix-thread.c: Revert.
10341         * agent.c: Revert.
10342         * addrmap.c: Revert.
10343         * ada-varobj.c: Revert.
10344         * ada-valprint.c: Revert.
10345         * ada-typeprint.c: Revert.
10346         * ada-tasks.c: Revert.
10347         * ada-lang.c: Revert.
10348         * aarch64-tdep.c: Revert.
10349         * aarch64-ravenscar-thread.c: Revert.
10350         * aarch64-newlib-tdep.c: Revert.
10351         * aarch64-linux-tdep.c: Revert.
10352         * aarch64-linux-nat.c: Revert.
10353         * aarch64-fbsd-tdep.c: Revert.
10354         * aarch64-fbsd-nat.c: Revert.
10355         * aarch32-linux-nat.c: Revert.
10356
10357 2019-04-05  Tom Tromey  <tom@tromey.com>
10358
10359         * ft32-tdep.c: Sort headers.
10360         * frv-tdep.c: Sort headers.
10361         * frv-linux-tdep.c: Sort headers.
10362         * frame.c: Sort headers.
10363         * frame-unwind.c: Sort headers.
10364         * frame-base.c: Sort headers.
10365         * fork-child.c: Sort headers.
10366         * findvar.c: Sort headers.
10367         * findcmd.c: Sort headers.
10368         * filesystem.c: Sort headers.
10369         * filename-seen-cache.h: Sort headers.
10370         * filename-seen-cache.c: Sort headers.
10371         * fbsd-tdep.c: Sort headers.
10372         * fbsd-nat.h: Sort headers.
10373         * fbsd-nat.c: Sort headers.
10374         * f-valprint.c: Sort headers.
10375         * f-typeprint.c: Sort headers.
10376         * f-lang.c: Sort headers.
10377         * extension.h: Sort headers.
10378         * extension.c: Sort headers.
10379         * extension-priv.h: Sort headers.
10380         * expprint.c: Sort headers.
10381         * exec.h: Sort headers.
10382         * exec.c: Sort headers.
10383         * exceptions.c: Sort headers.
10384         * event-top.c: Sort headers.
10385         * event-loop.c: Sort headers.
10386         * eval.c: Sort headers.
10387         * elfread.c: Sort headers.
10388         * dwarf2read.h: Sort headers.
10389         * dwarf2read.c: Sort headers.
10390         * dwarf2loc.c: Sort headers.
10391         * dwarf2expr.h: Sort headers.
10392         * dwarf2expr.c: Sort headers.
10393         * dwarf2-frame.c: Sort headers.
10394         * dwarf2-frame-tailcall.c: Sort headers.
10395         * dwarf-index-write.h: Sort headers.
10396         * dwarf-index-write.c: Sort headers.
10397         * dwarf-index-common.c: Sort headers.
10398         * dwarf-index-cache.h: Sort headers.
10399         * dwarf-index-cache.c: Sort headers.
10400         * dummy-frame.c: Sort headers.
10401         * dtrace-probe.c: Sort headers.
10402         * disasm.h: Sort headers.
10403         * disasm.c: Sort headers.
10404         * disasm-selftests.c: Sort headers.
10405         * dictionary.c: Sort headers.
10406         * dicos-tdep.c: Sort headers.
10407         * demangle.c: Sort headers.
10408         * dcache.h: Sort headers.
10409         * dcache.c: Sort headers.
10410         * darwin-nat.h: Sort headers.
10411         * darwin-nat.c: Sort headers.
10412         * darwin-nat-info.c: Sort headers.
10413         * d-valprint.c: Sort headers.
10414         * d-namespace.c: Sort headers.
10415         * d-lang.c: Sort headers.
10416         * ctf.c: Sort headers.
10417         * csky-tdep.c: Sort headers.
10418         * csky-linux-tdep.c: Sort headers.
10419         * cris-tdep.c: Sort headers.
10420         * cris-linux-tdep.c: Sort headers.
10421         * cp-valprint.c: Sort headers.
10422         * cp-support.c: Sort headers.
10423         * cp-namespace.c: Sort headers.
10424         * cp-abi.c: Sort headers.
10425         * corelow.c: Sort headers.
10426         * corefile.c: Sort headers.
10427         * continuations.c: Sort headers.
10428         * completer.h: Sort headers.
10429         * completer.c: Sort headers.
10430         * complaints.c: Sort headers.
10431         * coffread.c: Sort headers.
10432         * coff-pe-read.c: Sort headers.
10433         * cli-out.h: Sort headers.
10434         * cli-out.c: Sort headers.
10435         * charset.c: Sort headers.
10436         * c-varobj.c: Sort headers.
10437         * c-valprint.c: Sort headers.
10438         * c-typeprint.c: Sort headers.
10439         * c-lang.c: Sort headers.
10440         * buildsym.c: Sort headers.
10441         * buildsym-legacy.c: Sort headers.
10442         * build-id.h: Sort headers.
10443         * build-id.c: Sort headers.
10444         * btrace.c: Sort headers.
10445         * bsd-uthread.c: Sort headers.
10446         * breakpoint.h: Sort headers.
10447         * breakpoint.c: Sort headers.
10448         * break-catch-throw.c: Sort headers.
10449         * break-catch-syscall.c: Sort headers.
10450         * break-catch-sig.c: Sort headers.
10451         * blockframe.c: Sort headers.
10452         * block.c: Sort headers.
10453         * bfin-tdep.c: Sort headers.
10454         * bfin-linux-tdep.c: Sort headers.
10455         * bfd-target.c: Sort headers.
10456         * bcache.c: Sort headers.
10457         * ax-general.c: Sort headers.
10458         * ax-gdb.h: Sort headers.
10459         * ax-gdb.c: Sort headers.
10460         * avr-tdep.c: Sort headers.
10461         * auxv.c: Sort headers.
10462         * auto-load.c: Sort headers.
10463         * arm-wince-tdep.c: Sort headers.
10464         * arm-tdep.c: Sort headers.
10465         * arm-symbian-tdep.c: Sort headers.
10466         * arm-pikeos-tdep.c: Sort headers.
10467         * arm-obsd-tdep.c: Sort headers.
10468         * arm-nbsd-tdep.c: Sort headers.
10469         * arm-nbsd-nat.c: Sort headers.
10470         * arm-linux-tdep.c: Sort headers.
10471         * arm-linux-nat.c: Sort headers.
10472         * arm-fbsd-tdep.c: Sort headers.
10473         * arm-fbsd-nat.c: Sort headers.
10474         * arm-bsd-tdep.c: Sort headers.
10475         * arch-utils.c: Sort headers.
10476         * arc-tdep.c: Sort headers.
10477         * arc-newlib-tdep.c: Sort headers.
10478         * annotate.h: Sort headers.
10479         * annotate.c: Sort headers.
10480         * amd64-windows-tdep.c: Sort headers.
10481         * amd64-windows-nat.c: Sort headers.
10482         * amd64-tdep.c: Sort headers.
10483         * amd64-sol2-tdep.c: Sort headers.
10484         * amd64-obsd-tdep.c: Sort headers.
10485         * amd64-obsd-nat.c: Sort headers.
10486         * amd64-nbsd-tdep.c: Sort headers.
10487         * amd64-nbsd-nat.c: Sort headers.
10488         * amd64-nat.c: Sort headers.
10489         * amd64-linux-tdep.c: Sort headers.
10490         * amd64-linux-nat.c: Sort headers.
10491         * amd64-fbsd-tdep.c: Sort headers.
10492         * amd64-fbsd-nat.c: Sort headers.
10493         * amd64-dicos-tdep.c: Sort headers.
10494         * amd64-darwin-tdep.c: Sort headers.
10495         * amd64-bsd-nat.c: Sort headers.
10496         * alpha-tdep.c: Sort headers.
10497         * alpha-obsd-tdep.c: Sort headers.
10498         * alpha-nbsd-tdep.c: Sort headers.
10499         * alpha-mdebug-tdep.c: Sort headers.
10500         * alpha-linux-tdep.c: Sort headers.
10501         * alpha-linux-nat.c: Sort headers.
10502         * alpha-bsd-tdep.c: Sort headers.
10503         * alpha-bsd-nat.c: Sort headers.
10504         * aix-thread.c: Sort headers.
10505         * agent.c: Sort headers.
10506         * addrmap.c: Sort headers.
10507         * ada-varobj.c: Sort headers.
10508         * ada-valprint.c: Sort headers.
10509         * ada-typeprint.c: Sort headers.
10510         * ada-tasks.c: Sort headers.
10511         * ada-lang.c: Sort headers.
10512         * aarch64-tdep.c: Sort headers.
10513         * aarch64-ravenscar-thread.c: Sort headers.
10514         * aarch64-newlib-tdep.c: Sort headers.
10515         * aarch64-linux-tdep.c: Sort headers.
10516         * aarch64-linux-nat.c: Sort headers.
10517         * aarch64-fbsd-tdep.c: Sort headers.
10518         * aarch64-fbsd-nat.c: Sort headers.
10519         * aarch32-linux-nat.c: Sort headers.
10520
10521 2019-04-04  Tom Tromey  <tom@tromey.com>
10522
10523         * varobj.c (varobj_create): Update.
10524         * rust-exp.y (struct rust_parser) <update_innermost_block,
10525         lookup_symbol>: New methods.
10526         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10527         Rename.
10528         (rust_parser::rust_lookup_type)
10529         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10530         * printcmd.c (display_command, do_one_display): Update.
10531         * parser-defs.h (struct parser_state) <parser_state>: Add
10532         "tracker" parameter.
10533         (block_tracker): New member.
10534         (class innermost_block_tracker) <innermost_block_tracker>: Add
10535         "types" parameter.
10536         <reset>: Remove method.
10537         (innermost_block): Don't declare.
10538         (null_post_parser): Update.
10539         * parse.c (innermost_block): Remove global.
10540         (write_dollar_variable): Update.
10541         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10542         Remove "tracker_types" parameter.
10543         (parse_expression): Add "tracker" parameter.
10544         (parse_expression_for_completion): Update.
10545         (null_post_parser): Add "tracker" parameter.
10546         * p-exp.y: Update rules.
10547         * m2-exp.y: Update rules.
10548         * language.h (struct language_defn) <la_post_parser>: Add
10549         "tracker" parameter.
10550         * go-exp.y: Update rules.
10551         * f-exp.y: Update rules.
10552         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10553         parameter.
10554         * d-exp.y: Update rules.
10555         * c-exp.y: Update rules.
10556         * breakpoint.c (set_breakpoint_condition): Create an
10557         innermost_block_tracker.
10558         (watch_command_1): Likewise.
10559         * ada-lang.c (resolve): Add "tracker" parameter.
10560         (resolve_subexp): Likewise.
10561         * ada-exp.y (write_var_from_sym): Update.
10562
10563 2019-04-04  Tom Tromey  <tom@tromey.com>
10564
10565         * type-stack.h: New file.
10566         * type-stack.c: New file.
10567         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10568         type-stack.h.
10569         (insert_into_type_stack, insert_type, push_type, push_type_int)
10570         (insert_type_address_space, pop_type, pop_type_int)
10571         (pop_typelist, pop_type_stack, append_type_stack)
10572         (push_type_stack, get_type_stack, push_typelist)
10573         (follow_type_instance_flags, follow_types): Don't declare.
10574         * parse.c (type_stack): Remove global.
10575         (parse_exp_in_context): Update.
10576         (insert_into_type_stack, insert_type, push_type, push_type_int)
10577         (insert_type_address_space, pop_type, pop_type_int)
10578         (pop_typelist, pop_type_stack, append_type_stack)
10579         (push_type_stack, get_type_stack, push_typelist)
10580         (follow_type_instance_flags, follow_types): Remove (moved to
10581         type-stack.c).
10582         * f-exp.y (type_stack): New global.
10583         Update rules.
10584         (push_kind_type, f_parse): Update.
10585         * d-exp.y (type_stack): New global.
10586         Update rules.
10587         (d_parse): Update.
10588         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10589         Update rules.
10590         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10591         (HFILES_NO_SRCDIR): Add type-stack.h.
10592
10593 2019-04-04  Tom Tromey  <tom@tromey.com>
10594
10595         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10596         (rust_parser::convert_ast_to_expression, rust_parse)
10597         (rust_lex_test_completion, rust_lex_tests): Update.
10598         * parser-defs.h (struct expr_completion_state): New.
10599         (struct parser_state) <parser_state>: Add completion parameter.
10600         <mark_struct_expression, mark_completion_tag>: New methods.
10601         <parse_completion, m_completion_state>: New members.
10602         (prefixify_expression, null_post_parser): Update.
10603         (mark_struct_expression, mark_completion_tag): Don't declare.
10604         * parse.c (parse_completion, expout_last_struct)
10605         (expout_tag_completion_type, expout_completion_name): Remove
10606         globals.
10607         (parser_state::mark_struct_expression)
10608         (parser_state::mark_completion_tag): Now methods.
10609         (prefixify_expression): Add last_struct parameter.
10610         (prefixify_subexp): Likewise.
10611         (parse_exp_1): Update.
10612         (parse_exp_in_context): Add cstate parameter.  Update.
10613         (parse_expression_for_completion): Create an
10614         expr_completion_state.
10615         (null_post_parser): Add "completion" parameter.
10616         * p-exp.y: Update rules.
10617         (yylex): Update.
10618         * language.h (struct language_defn) <la_post_parser>: Add
10619         "completing" parameter.
10620         * go-exp.y: Update rules.
10621         (lex_one_token): Update.
10622         * expression.h (parse_completion): Don't declare.
10623         * d-exp.y: Update rules.
10624         (lex_one_token): Update rules.
10625         * c-exp.y: Update rules.
10626         (lex_one_token): Update.
10627         * ada-lang.c (resolve): Add "parse_completion" parameter.
10628         (resolve_subexp): Likewise.
10629         (ada_resolve_function): Likewise.
10630
10631 2019-04-04  Tom Tromey  <tom@tromey.com>
10632
10633         * parser-defs.h (struct parser_state) <start_arglist,
10634         end_arglist>: New methods.
10635         <arglist_len, m_funcall_chain>: New members.
10636         (arglist_len, start_arglist, end_arglist): Don't declare.
10637         * parse.c (arglist_len, funcall_chain): Remove global.
10638         (start_arglist, end_arglist): Remove functions.
10639         (parse_exp_in_context): Update.
10640         * p-exp.y: Update rules.
10641         * m2-exp.y: Update rules.
10642         * go-exp.y: Update rules.
10643         * f-exp.y: Update rules.
10644         * d-exp.y: Update rules.
10645         * c-exp.y: Update rules.
10646
10647 2019-04-04  Tom Tromey  <tom@tromey.com>
10648
10649         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10650         lex_operator, push_back>: New methods.
10651         Update all rules.
10652         (rust_parser::lex_hex, lex_escape): Rename and update.
10653         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10654         (rust_parser::lex_operator): Rename and update.
10655         (rust_parser::lex_number, rustyylex, rustyyerror)
10656         (rust_lex_test_init, rust_lex_test_sequence)
10657         (rust_lex_test_push_back, rust_lex_tests): Update.
10658         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10659         parameter.
10660         <lexptr, prev_lexptr>: New members.
10661         (lexptr, prev_lexptr): Don't declare.
10662         * parse.c (lexptr, prev_lexptr): Remove globals.
10663         (parse_exp_in_context): Update.
10664         * p-exp.y (yylex, yyerror): Update.
10665         * m2-exp.y (parse_number, yylex, yyerror): Update.
10666         * go-exp.y (lex_one_token, yyerror): Update.
10667         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10668         * d-exp.y (lex_one_token, yyerror): Update.
10669         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10670         (lex_one_token, yyerror): Update.
10671         * ada-lex.l (YY_INPUT): Update.
10672         (rewind_to_char): Update.
10673         * ada-exp.y (yyerror): Update.
10674
10675 2019-04-04  Tom Tromey  <tom@tromey.com>
10676
10677         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10678         * parser-defs.h (struct parser_state) <parser_state>: Add new
10679         parameter.
10680         <comma_terminates>: New member.
10681         (comma_terminates): Don't declare global.
10682         * parse.c (comma_terminates): Remove global.
10683         (parse_exp_in_context): Update.
10684         * p-exp.y (yylex): Update.
10685         * m2-exp.y (yylex): Update.
10686         * go-exp.y (lex_one_token): Update.
10687         * f-exp.y (yylex): Update.
10688         * d-exp.y (lex_one_token): Update.
10689         * c-exp.y (lex_one_token): Update.
10690         * ada-lex.l: Update.
10691
10692 2019-04-04  Tom Tromey  <tom@tromey.com>
10693
10694         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10695         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10696         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10697         * parser-defs.h (paren_depth): Don't declare.
10698         * parse.c (paren_depth): Remove global.
10699         (parse_exp_in_context): Update.
10700         * p-exp.y (paren_depth): New global.
10701         (pascal_parse): Initialize it.
10702         * m2-exp.y (paren_depth): New global.
10703         (m2_parse): Initialize it.
10704         * go-exp.y (paren_depth): New global.
10705         (go_parse): Initialize it.
10706         * f-exp.y (paren_depth): New global.
10707         (f_parse): Initialize it.
10708         * d-exp.y (paren_depth): New global.
10709         (d_parse): Initialize it.
10710         * c-exp.y (paren_depth): New global.
10711         (c_parse): Initialize it.
10712         * ada-lex.l (paren_depth): New global.
10713         (lexer_init): Initialize it.
10714
10715 2019-04-04  Tom Tromey  <tom@tromey.com>
10716
10717         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10718         (rust_parser::convert_ast_to_type)
10719         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10720         * parser-defs.h (struct parser_state) <parser_state>: Add
10721         parameters.  Initialize new members.
10722         <expression_context_block, expression_context_pc>: New members.
10723         * parse.c (expression_context_block, expression_context_pc):
10724         Remove globals.
10725         (parse_exp_in_context): Update.
10726         * p-exp.y: Update all rules.
10727         (yylex): Update.
10728         * m2-exp.y: Update all rules.
10729         (yylex): Update.
10730         * go-exp.y (yylex): Update.
10731         * f-exp.y (yylex): Update.
10732         * d-exp.y: Update all rules.
10733         (yylex): Update.
10734         * c-exp.y: Update all rules.
10735         (lex_one_token, classify_name, yylex, c_parse): Update.
10736         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10737
10738 2019-04-04  Tom Tromey  <tom@tromey.com>
10739
10740         * gdbarch.h, gdbarch.c: Rebuild.
10741         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10742         * stap-probe.h:
10743         (struct stap_parse_info): Replace "parser_state" with
10744         "expr_builder".
10745         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10746         (parser_state): New class.
10747         * parse.c (expr_builder): Rename.
10748         (expr_builder::release): Rename.
10749         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10750         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10751         (write_exp_elt_longcst, write_exp_elt_floatcst)
10752         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10753         (write_exp_string_vector, write_exp_bitstring)
10754         (write_exp_msymbol, mark_struct_expression)
10755         (write_dollar_variable)
10756         (insert_type_address_space, increase_expout_size): Replace
10757         "parser_state" with "expr_builder".
10758         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10759         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10760         "parser_state" with "expr_builder".
10761
10762 2019-04-04  Tom Tromey  <tom@tromey.com>
10763
10764         * rust-exp.y: Replace "parse_language" with method call.
10765         * p-exp.y:
10766         (yylex): Replace "parse_language" with method call.
10767         * m2-exp.y:
10768         (yylex): Replace "parse_language" with method call.
10769         * go-exp.y (classify_name): Replace "parse_language" with method
10770         call.
10771         * f-exp.y (yylex): Replace "parse_language" with method call.
10772         * d-exp.y (lex_one_token): Replace "parse_language" with method
10773         call.
10774         * c-exp.y:
10775         (lex_one_token, classify_name, yylex): Replace "parse_language"
10776         with method call.
10777         * ada-exp.y (find_primitive_type, type_char)
10778         (type_system_address): Replace "parse_language" with method call.
10779
10780 2019-04-04  Tom Tromey  <tom@tromey.com>
10781
10782         * rust-exp.y: Replace "parse_gdbarch" with method call.
10783         * parse.c (write_dollar_variable, insert_type_address_space):
10784         Replace "parse_gdbarch" with method call.
10785         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10786         call.
10787         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10788         call.
10789         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10790         "parse_gdbarch" with method call.
10791         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10792         with method call.
10793         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10794         "parse_gdbarch" with method call.
10795         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10796         "parse_gdbarch" with method call.
10797         * c-exp.y (parse_type, parse_number, classify_name): Replace
10798         "parse_gdbarch" with method call.
10799         * ada-lex.l: Replace "parse_gdbarch" with method call.
10800         * ada-exp.y (parse_type, find_primitive_type, type_char)
10801         (type_system_address): Replace "parse_gdbarch" with method call.
10802
10803 2019-04-04  Tom Tromey  <tom@tromey.com>
10804
10805         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10806         * stap-probe.c (stap_parse_argument): Update.
10807         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10808         initial_size parameter.
10809         * rust-exp.y (rust_lex_tests): Update.
10810         * parse.c (parser_state): Update.
10811         (parse_exp_in_context): Update.
10812         * parser-defs.h (struct parser_state) <parser_state>: Remove
10813         "initial_size" parameter.
10814
10815 2019-04-04  Tom Tromey  <tom@tromey.com>
10816
10817         * parser-defs.h (increase_expout_size): Don't declare.
10818         * parse.c (increase_expout_size): Now static.
10819
10820 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10821
10822         * gnu-nat.c (gnu_nat_target::wait): Fix
10823         target_waitstatus_to_string call.
10824
10825 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10826
10827         * eval.c (evaluate_subexp_standard): Handle internal functions
10828         during Fortran function call handling.
10829
10830 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10831
10832         * NEWS: Mention new internal functions.
10833         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10834         (read_base_type): Use dwarf2_init_complex_target_type.
10835         * value.c (creal_internal_fn): New function.
10836         (cimag_internal_fn): New function.
10837         (_initialize_values): Register new internal functions.
10838
10839 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10840
10841         * infrun.c (stop_all_threads): If debug_infrun, always
10842         trace the wait status after wait_one, using
10843         target_waitstatus_to_string and target_pid_to_str.
10844         (handle_inferior_event): Replace various trace of
10845         wait status kind by a single trace.
10846         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10847         wait status kind image by target_waitstatus_to_string.
10848         * target/waitstatus.c (target_waitstatus_to_string): Fix
10849         obsolete comment.
10850
10851 2019-04-01  Tom Tromey  <tromey@adacore.com>
10852
10853         PR symtab/23331:
10854         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10855
10856 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10857             Pedro Alves  <palves@redhat.com>
10858
10859         * top.c (quit_force): Call 'finalize_values'.
10860         * value.c (finalize_values): New function.
10861         * value.h (finalize_values): Declare.
10862
10863 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10864
10865         * NEWS: Announce $_gdb_major and $_gdb_minor.
10866
10867         * top.c (init_gdb_version_vars): New function.
10868         (gdb_init): Call init_gdb_version_vars.
10869
10870 2019-03-29  Tom Tromey  <tromey@adacore.com>
10871
10872         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10873         help text.  Remove dead code.
10874
10875 2019-03-29  Keith Seitz  <keiths@redhat.com>
10876
10877         From Siddhesh Poyarekar:
10878         * f-lang.h (f77_get_upperbound): Return LONGEST.
10879         (f77_get_lowerbound): Likewise.
10880         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10881         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10882         print them.
10883         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10884         plongest to format print it.
10885         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10886         (f77_get_upperbound): Likewise.
10887         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10888         LOWER_BOUND to LONGEST.
10889         (f77_create_arrayprint_offset_tbl): Likewise.
10890
10891 2019-03-29  Keith Seitz  <keiths@redhat.com>
10892
10893         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10894         %s/pulongest for TYPE_LENGTH instead of %d in format
10895         strings.
10896         * ada-typerint.c (ada_print_type): Likewise.
10897         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10898         * compile/compile-c-support.c (generate_register_struct): Likewise.
10899         * gdbtypes.c (recursive_dump_type): Likewise.
10900         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10901         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10902         instead of %d in format strings.
10903         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10904         to std::min to ULONGEST.
10905         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10906         instead of %d in format strings.
10907         * tracepoint.c (info_scope_command): Likewise.
10908         * typeprint.c (print_offset_data::update)
10909         (print_offset_data::finish): Likewise.
10910         * xtensa-tdep.c (xtensa_store_return_value)
10911         (xtensa_push_dummy_call): Likewise.
10912
10913 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10914
10915         * windows-nat.c (display_selector): Fixed format specifications
10916         for 64-bit Cygwin.
10917
10918 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10919
10920         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10921
10922 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10923
10924         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10925         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10926         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10927         (nios2_linux_init_abi): Install it.
10928
10929 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10930
10931         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10932
10933 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10934
10935         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10936
10937 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10938             Tom Tromey  <tromey@adacore.com>
10939
10940         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10941
10942 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10943
10944         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10945         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10946         method to compute the bounds of range types. Also print "[evaluated]"
10947         if the bounds' values come from a dynamic evaluation.
10948
10949 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10950
10951         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10952         whitespace when pretty printing is on.
10953
10954 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10955
10956         * ppc-linux-nat.c: Add include.
10957
10958 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10959
10960         * NEWS: Mention AArch64 Pointer Authentication.
10961
10962 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10963
10964         * arm-linux-nat.c: Add include.
10965
10966 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10967
10968         * source-cache.c (source_cache::get_source_lines): Re-read
10969         fullname after calling open_source_file.
10970
10971 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10972
10973         * NEWS: Mention TLS support for FreeBSD.
10974
10975 2019-03-25  Tom Tromey  <tromey@adacore.com>
10976
10977         * minsyms.c (BUNCH_SIZE): Update comment.
10978         (~minimal_symbol_reader): Remove old comment.
10979         (compact_minimal_symbols): Update comment.
10980         (minimal_symbol_reader::install): Remove old comment.  Update
10981         other comments.
10982
10983 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10984
10985         * s390-linux-nat.c: Add include.
10986
10987 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10988
10989         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10990         Call linux_get_hwcap.
10991         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10992         Likewise.
10993         (aarch64_linux_get_hwcap): Remove function.
10994         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10995         declaration.
10996         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10997         linux_get_hwcap.
10998         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10999         * linux-tdep.c (linux_get_hwcap): Add function.
11000         (linux_get_hwcap2): Likewise.
11001         * linux-tdep.h (linux_get_hwcap): Add declaration.
11002         (linux_get_hwcap2): Likewise.
11003         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11004         (ppc_linux_get_hwcap2): Likewise.
11005         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11006         linux_get_hwcap.
11007         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11008         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11009         (ppc_linux_nat_target::read_description): Likewise.
11010         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11011         * s390-linux-nat.c: Likewise.
11012         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11013
11014 2019-03-24  Tom Tromey  <tom@tromey.com>
11015
11016         * ada-lang.c (standard_lookup): Simplify initialization.
11017         (ada_lookup_symbol_nonlocal): Simplify return.
11018         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11019         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11020         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11021         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11022         initialization.
11023         * solib.c (solib_global_lookup): Simplify.
11024         * symtab.c (null_block_symbol): Remove.
11025         (symbol_cache_lookup): Simplify returns.
11026         (lookup_language_this): Simplify returns.
11027         (lookup_symbol_aux): Simplify return.
11028         (lookup_local_symbol): Simplify returns.
11029         (lookup_global_symbol_from_objfile): Simplify return.
11030         (lookup_symbol_in_objfile_symtabs)
11031         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11032         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11033         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11034         * cp-namespace.c (cp_lookup_bare_symbol)
11035         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11036         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11037         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11038         (cp_lookup_symbol_via_imports): Simplify initialization.
11039         (find_symbol_in_baseclass): Likewise.
11040         * symtab.h (null_block_symbol): Remove.
11041         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11042         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11043         (d_lookup_symbol_module): Likewise.
11044         (find_symbol_in_baseclass): Simplify initialization.
11045
11046 2019-03-24  Tom Tromey  <tom@tromey.com>
11047
11048         * expression.h: Don't include symtab.h.
11049         (struct block): Forward declare.
11050
11051 2019-03-24  Tom Tromey  <tom@tromey.com>
11052
11053         * c-exp.y (typebase): Remove casts.
11054         * gdbtypes.c (lookup_unsigned_typename, )
11055         (lookup_signed_typename): Remove cast.
11056         * eval.c (parse_to_comma_and_eval): Remove cast.
11057         * parse.c (write_dollar_variable): Remove cast.
11058         * block.h (struct block) <superblock>: Now const.
11059         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11060         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11061         (map_block): Make "block" const.
11062         * symfile.h (struct quick_symbol_functions)
11063         <map_matching_symbols>: Constify block argument to "callback".
11064         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11065         const.
11066         (find_pc_sect_compunit_symtab): Make "b" const.
11067         (find_symbol_at_address): Likewise.
11068         (search_symbols): Likewise.
11069         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11070         (dw2_debug_names_lookup_symbol): Likewise.
11071         (dw2_map_matching_symbols): Update.
11072         * p-valprint.c (pascal_val_print): Remove "block".
11073         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11074         (aux_add_nonlocal_symbols): Make "block" const.
11075         (resolve_subexp): Remove cast.
11076         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11077         const.
11078         (iterate_over_file_blocks): Likewise.
11079         * f-exp.y (%union) <bval>: Remove.
11080         * coffread.c (patch_opaque_types): Make "b" const.
11081         * spu-tdep.c (spu_catch_start): Make "block" const.
11082         * c-valprint.c (print_unpacked_pointer): Remove "block".
11083         * symmisc.c (dump_symtab_1): Make "b" const.
11084         (block_depth): Make "block" const.
11085         * d-exp.y (%union) <bval>: Remove.
11086         * cp-support.h (cp_lookup_rtti_type): Update.
11087         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11088         * psymtab.c (psym_lookup_symbol): Make "block" const.
11089         (maintenance_check_psymtabs): Make "b" const.
11090         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11091         (enumerate_locals, enumerate_args): Update.
11092         * python/py-symtab.c (stpy_global_block): Make "block" const.
11093         (stpy_static_block): Likewise.
11094         * inline-frame.c (block_starting_point_at): Make "new_block"
11095         const.
11096         * block.c (find_block_in_blockvector): Make return type const.
11097         (blockvector_for_pc_sect): Make "b" const.
11098         (find_block_in_blockvector): Make "b" const.
11099
11100 2019-03-23  Tom Tromey  <tom@tromey.com>
11101
11102         * varobj.c (varobj_create): Update.
11103         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11104         * printcmd.c (display_command, do_one_display): Don't reset
11105         innermost_block.
11106         * parser-defs.h (enum innermost_block_tracker_type): Move to
11107         expression.h.
11108         (innermost_block): Update comment.
11109         * parse.c (parse_exp_1): Add tracker_types parameter.
11110         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11111         tracker_types parameter.  Reset innermost_block.
11112         (parse_exp_in_context): Remove.
11113         (parse_expression_for_completion): Update.
11114         * objfiles.c (~objfile): Don't reset expression_context_block or
11115         innermost_block.
11116         * expression.h (enum innermost_block_tracker_type): Move from
11117         parser-defs.h.
11118         (parse_exp_1): Add tracker_types parameter.
11119         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11120         reset innermost_block.
11121
11122 2019-03-23  Tom Tromey  <tom@tromey.com>
11123
11124         * objfiles.h: Include bcache.h.
11125
11126 2019-03-23  Tom Tromey  <tom@tromey.com>
11127
11128         * linespec.c (get_current_search_block): Use
11129         scoped_restore_current_language.
11130         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11131
11132 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11133             Jiong Wang  <jiong.wang@arm.com>
11134
11135         * aarch64-linux-tdep.c
11136         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11137         section.
11138         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11139
11140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11141             Jiong Wang  <jiong.wang@arm.com>
11142
11143         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11144         instructions.
11145         (aarch64_analyze_prologue_test): Add PACIASP test.
11146         (aarch64_prologue_prev_register): Unmask PC value.
11147
11148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11149             Jiong Wang  <jiong.wang@arm.com>
11150
11151         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11152         (aarch64_dwarf2_prev_register): Unmask PC value.
11153         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11154         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11155         DW_CFA_AARCH64_negate_ra_state.
11156         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11157
11158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11159             Jiong Wang  <jiong.wang@arm.com>
11160
11161         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11162         registers.
11163         (aarch64_pseudo_register_name): Likewise.
11164         (aarch64_pseudo_register_type): Likewise.
11165         (aarch64_pseudo_register_reggroup_p): Likewise.
11166         (aarch64_gdbarch_init): Add pauth registers.
11167         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11168         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11169         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11170         (struct gdbarch_tdep): Add regnum for ra_state.
11171
11172 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11173             Jiong Wang  <jiong.wang@arm.com>
11174
11175         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11176
11177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11178             Jiong Wang  <jiong.wang@arm.com>
11179
11180         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11181         function.
11182         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11183         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11184         (aarch64_gdbarch_init): Add puth registers.
11185         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11186         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11187         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11188
11189 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11190             Jiong Wang  <jiong.wang@arm.com>
11191
11192         * aarch64-linux-nat.c
11193         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11194         * aarch64-linux-tdep.c
11195         (aarch64_linux_core_read_description): Likewise.
11196         (aarch64_linux_get_hwcap): New function.
11197         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11198         (aarch64_linux_get_hwcap): New declaration.
11199
11200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11201             Jiong Wang  <jiong.wang@arm.com>
11202
11203         * aarch64-linux-nat.c
11204         (aarch64_linux_nat_target::read_description): Add pauth param.
11205         * aarch64-linux-tdep.c
11206         (aarch64_linux_core_read_description): Likewise.
11207         * aarch64-tdep.c (struct target_desc): Add in pauth.
11208         (aarch64_read_description): Add pauth param.
11209         (aarch64_gdbarch_init): Likewise.
11210         * aarch64-tdep.h (aarch64_read_description): Likewise.
11211         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11212         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11213         * features/Makefile: Add new files.
11214         * features/aarch64-pauth.c: New file.
11215         * features/aarch64-pauth.xml: New file.
11216
11217 2019-03-20  Tom Tromey  <tromey@adacore.com>
11218
11219         * infrun.c (handle_inferior_event): Rename from
11220         handle_inferior_event_1.  Create a scoped_value_mark.
11221         (handle_inferior_event): Remove.
11222
11223 2019-03-19  Tom Tromey  <tromey@adacore.com>
11224
11225         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11226         * infrun.h (print_stop_event): Add "displays" parameter.
11227         * infrun.c (print_stop_event): Add "displays" parameter.
11228
11229 2019-03-19  Pedro Alves  <palves@redhat.com>
11230
11231         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11232         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11233         to -1.  Fix TABs vs spaces.
11234         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11235         * tui/tui-out.h (tui_ui_out) Add intro comments.
11236         <m_line, m_start_of_line>: In-class initialize, and add describing
11237         comment.
11238
11239 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11240
11241         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11242         variable names.
11243         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11244
11245 2019-03-18  Pedro Alves  <palves@redhat.com>
11246             Eli Zaretskii <eliz@gnu.org>
11247
11248         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11249         m_line and m_start_of_line.
11250
11251 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11252
11253         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11254         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11255         it returns a newline.  This fixes a regression in TU mode, whereby
11256         the next line is output on the same screen line as the user input.
11257
11258 2019-03-18  Tom Tromey  <tromey@adacore.com>
11259
11260         * minsyms.c (minimal_symbol_reader::install): Remove call to
11261         obstack_blank.
11262
11263 2019-03-18  Pedro Alves  <palves@redhat.com>
11264
11265         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11266         New globals.
11267         (apply_style): New, factored out from ...
11268         (apply_ansi_escape): ... this.  Handle reverse video mode.
11269         (tui_set_reverse_mode): New function.
11270         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11271         * tui/tui-winsource.c (tui_show_source_line): Use
11272         tui_set_reverse_mode instead of setting A_STANDOUT.
11273         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11274         New setter methods.
11275
11276 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11277
11278         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11279         Handle tabs.
11280
11281 2019-03-18  Tom Tromey  <tromey@adacore.com>
11282
11283         * ada-lang.c (empty_array): Add "high" parameter.
11284         (ada_evaluate_subexp): Update.
11285
11286 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11287
11288         * unittests/string_view-selftests.c: Define
11289         _initialize_string_view_selftests unconditionally.
11290
11291 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11292
11293         PR gdb/24350
11294         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11295
11296 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11297
11298         PR gdb/24351
11299         * windows-nat.c (display_selector): Fix format specifiers.
11300
11301 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11302
11303         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11304         tui_refill_source_window instead of tui_refresh_win, to update the
11305         current execution line.  This fixes redisplay of the current line
11306         when stepping through the code with "next" or "step".
11307
11308 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11309
11310         * source-cache.c (source_cache::get_source_lines): Call
11311         find_source_lines to initialize s->nlines.  This fixes vertical
11312         scrolling of TUI source window when the DOWN arrow is pressed.
11313
11314 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11315
11316         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11317         linux-thread-db.c (_initialize_thread_db): Likewise.
11318
11319 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11320
11321         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11322         wclrtoeol in tui_show_source_line".  This reverts changes made in
11323         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11324
11325 2019-03-15  Tom Tromey  <tom@tromey.com>
11326
11327         * symtab.h (struct minimal_symbol): Derive from
11328         general_symbol_info.
11329         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11330         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11331         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11332         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11333         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11334         (MSYMBOL_SEARCH_NAME): Update.
11335         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11336         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11337         * minsyms.c (minimal_symbol_reader::record_full): Update.
11338
11339 2019-03-15  Tom Tromey  <tom@tromey.com>
11340
11341         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11342
11343 2019-03-15  Tom Tromey  <tom@tromey.com>
11344
11345         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11346         unique_xmalloc_ptr.
11347         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11348         Update.
11349         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11350         (build_minimal_symbol_hash_tables)
11351         (minimal_symbol_reader::install): Update.
11352
11353 2019-03-15  Tom Tromey  <tom@tromey.com>
11354
11355         * symtab.c (create_demangled_names_hash): Update.
11356         (symbol_set_names): Update.
11357         * objfiles.h (struct objfile_per_bfd_storage)
11358         <demangled_names_hash>: Now an htab_up.
11359         * objfiles.c (objfile_per_bfd_storage): Simplify.
11360
11361 2019-03-15  Tom Tromey  <tom@tromey.com>
11362
11363         * objfiles.h (struct objfile_per_bfd_storage): Declare
11364         destructor.
11365         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11366         New.
11367         (get_objfile_bfd_data): Use new.  Don't initialize
11368         language_of_main.
11369         (free_objfile_per_bfd_storage): Remove.
11370         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11371
11372 2019-03-15  Tom Tromey  <tom@tromey.com>
11373
11374         * symfile.c (reread_symbols): Update.
11375         * objfiles.c (objfile::objfile): Update.
11376         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11377         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11378         comment.
11379         (minimal_symbol_reader::install): Update.
11380         (terminate_minimal_symbol_table): Remove.
11381         * jit.c (jit_object_close_impl): Update.
11382
11383 2019-03-15  Tom Tromey  <tom@tromey.com>
11384
11385         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11386         initializations.
11387
11388 2019-03-15  Tom Tromey  <tom@tromey.com>
11389
11390         * objfiles.h (struct objfile_per_bfd_storage)
11391         <demangled_hash_languages>: Now a bitset.
11392         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11393         (lookup_minimal_symbol): Update.
11394
11395 2019-03-15  Tom Tromey  <tom@tromey.com>
11396
11397         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11398         Don't return the symbol.
11399         * coffread.c (record_minimal_symbol): Use record_full.
11400
11401 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11402
11403         The MS-Windows port of ncurses fails to switch to a color pair if
11404         one or both of the colors are the implicit default colors.  This
11405         change records the default colors when TUI is initialized, and
11406         then specifies them explicitly when a color pair uses the default
11407         colors.  This allows color styling in TUI mode on MS-Windows.
11408
11409         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11410         ncurses_norm_attr.
11411         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11412         colors in ncurses_norm_attr.
11413         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11414         "none", replace it with the default color recorded in
11415         ncurses_norm_attr.
11416
11417 2019-03-14  Tom Tromey  <tromey@adacore.com>
11418
11419         * source-cache.h (class source_cache) <get_source_lines>: Return
11420         std::string.
11421         * source-cache.c (source_cache::extract_lines): Handle case where
11422         first_pos==npos.  Return std::string.
11423         (source_cache::get_source_lines): Update.
11424
11425 2019-03-14  Tom Tromey  <tromey@adacore.com>
11426
11427         * NEWS: Add item for "style sources" commands.
11428         * source-cache.c (source_cache::get_source_lines): Check
11429         source_styling.
11430         * cli/cli-style.c (source_styling): New global.
11431         (_initialize_cli_style): Add "style sources" commands.
11432         (show_style_sources): New function.
11433         * cli/cli-style.h (source_styling): Declare.
11434
11435 2019-03-14  Pedro Alves  <palves@redhat.com>
11436             Tom Tromey  <tromey@adacore.com>
11437
11438         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11439         * tui/tui-winsource.c (tui_refill_source_window): New function,
11440         from...
11441         (tui_horizontal_source_scroll): ... here.  Move some logic.
11442         * cli/cli-style.c (set_style_enabled): Notify new observable.
11443         * tui/tui-hooks.c (tui_redisplay_source): New function.
11444         (tui_attach_detach_observers): Attach or detach
11445         tui_redisplay_source.
11446         * observable.h (source_styling_changed): New observable.
11447         * observable.c: Define source_styling_changed observable.
11448
11449 2019-03-13  Tom Tromey  <tromey@adacore.com>
11450
11451         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11452         (i386_gnu_nat_target::store_registers): Update.
11453         * target-debug.h (target_debug_print_std_string): New macro.
11454         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11455         * windows-tdep.c (display_one_tib): Update.
11456         * tui/tui-stack.c (tui_make_status_line): Update.
11457         * top.c (print_inferior_quit_action): Update.
11458         * thread.c (thr_try_catch_cmd): Update.
11459         (add_thread_with_info): Update.
11460         (thread_target_id_str): Update.
11461         (thr_try_catch_cmd): Update.
11462         (thread_command): Update.
11463         (thread_find_command): Update.
11464         * record-btrace.c (record_btrace_target::info_record)
11465         (record_btrace_resume_thread, record_btrace_target::resume)
11466         (record_btrace_cancel_resume, record_btrace_step_thread)
11467         (record_btrace_target::wait, record_btrace_target::wait)
11468         (record_btrace_target::wait, record_btrace_target::stop): Update.
11469         * progspace.c (print_program_space): Update.
11470         * process-stratum-target.c
11471         (process_stratum_target::thread_address_space): Update.
11472         * linux-fork.c (linux_fork_mourn_inferior)
11473         (detach_checkpoint_command, info_checkpoints_command)
11474         (linux_fork_context): Update.
11475         (linux_fork_detach): Update.
11476         (class scoped_switch_fork_info): Update.
11477         (delete_checkpoint_command): Update.
11478         * infrun.c (follow_fork_inferior): Update.
11479         (follow_fork_inferior): Update.
11480         (proceed_after_vfork_done): Update.
11481         (handle_vfork_child_exec_or_exit): Update.
11482         (follow_exec): Update.
11483         (displaced_step_prepare_throw): Update.
11484         (displaced_step_restore): Update.
11485         (start_step_over): Update.
11486         (resume_1): Update.
11487         (clear_proceed_status_thread): Update.
11488         (proceed): Update.
11489         (print_target_wait_results): Update.
11490         (do_target_wait): Update.
11491         (context_switch): Update.
11492         (stop_all_threads): Update.
11493         (restart_threads): Update.
11494         (finish_step_over): Update.
11495         (handle_signal_stop): Update.
11496         (switch_back_to_stepped_thread): Update.
11497         (keep_going_pass_signal): Update.
11498         (print_exited_reason): Update.
11499         (normal_stop): Update.
11500         * inferior.c (inferior_pid_to_str): Change return type.
11501         (print_selected_inferior): Update.
11502         (add_inferior): Update.
11503         (detach_inferior): Update.
11504         * dummy-frame.c (fprint_dummy_frames): Update.
11505         * dcache.c (dcache_info_1): Update.
11506         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11507         (btrace_fetch, btrace_clear): Update.
11508         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11509         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11510         type.
11511         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11512         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11513         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11514         * gdbarch.c, gdbarch.h: Rebuild.
11515         * gdbarch.sh (core_pid_to_str): Change return type.
11516         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11517         return type.
11518         (windows_nat_target::pid_to_str): Change return type.
11519         (windows_delete_thread): Update.
11520         (windows_nat_target::attach): Update.
11521         (windows_nat_target::files_info): Update.
11522         * target-delegates.c: Rebuild.
11523         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11524         return type.
11525         (sol_thread_target::pid_to_str): Change return type.
11526         * remote.c (class remote_target) <pid_to_str>: Change return
11527         type.
11528         (remote_target::pid_to_str): Change return type.
11529         (extended_remote_target::attach, remote_target::remote_stop_ns)
11530         (remote_target::remote_notif_remove_queued_reply)
11531         (remote_target::push_stop_reply, remote_target::disable_btrace):
11532         Update.
11533         (extended_remote_target::attach): Update.
11534         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11535         type.
11536         (gdbsim_target::pid_to_str): Change return type.
11537         * ravenscar-thread.c (struct ravenscar_thread_target)
11538         <pid_to_str>: Change return type.
11539         (ravenscar_thread_target::pid_to_str): Change return type.
11540         * procfs.c (class procfs_target) <pid_to_str>: Change return
11541         type.
11542         (procfs_target::pid_to_str): Change return type.
11543         (procfs_target::attach): Update.
11544         (procfs_target::detach): Update.
11545         (procfs_target::fetch_registers): Update.
11546         (procfs_target::store_registers): Update.
11547         (procfs_target::wait): Update.
11548         (procfs_target::files_info): Update.
11549         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11550         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11551         return type.
11552         (nto_procfs_target::pid_to_str): Change return type.
11553         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11554         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11555         return type.
11556         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11557         (exit_lwp): Update.
11558         (attach_proc_task_lwp_callback, get_detach_signal)
11559         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11560         (linux_nat_target::resume, wait_lwp, stop_callback)
11561         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11562         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11563         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11564         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11565         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11566         type.
11567         (inf_ptrace_target::attach): Update.
11568         (inf_ptrace_target::files_info): Update.
11569         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11570         type.
11571         (go32_nat_target::pid_to_str): Change return type.
11572         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11573         (gnu_nat_target::wait): Update.
11574         (gnu_nat_target::wait): Update.
11575         (gnu_nat_target::resume): Update.
11576         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11577         (fbsd_nat_target::wait): Update.
11578         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11579         type.
11580         (darwin_nat_target::attach): Update.
11581         * corelow.c (class core_target) <pid_to_str>: Change return type.
11582         (core_target::pid_to_str): Change return type.
11583         * target.c (normal_pid_to_str): Change return type.
11584         (default_pid_to_str): Likewise.
11585         (target_pid_to_str): Change return type.
11586         (target_translate_tls_address): Update.
11587         (target_announce_detach): Update.
11588         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11589         return type.
11590         (bsd_uthread_target::pid_to_str): Change return type.
11591         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11592         type.
11593         (bsd_kvm_target::pid_to_str): Change return type.
11594         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11595         return type.
11596         (aix_thread_target::pid_to_str): Change return type.
11597         * target.h (struct target_ops) <pid_to_str>: Change return type.
11598         (target_pid_to_str, normal_pid_to_str): Likewise.
11599         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11600         type.
11601         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11602         type.
11603         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11604         return type.
11605         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11606         type.
11607         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11608         type.
11609         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11610         return type.
11611
11612 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11613
11614         * NEWS: Mention that the new default MI version is 3.  Mention
11615         changes to the output of commands and events that deal with
11616         multi-location breakpoints.
11617         * breakpoint.c: Include "mi/mi-out.h".
11618         (print_one_breakpoint): Change output syntax if using MI version
11619         >= 3.
11620         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11621         New.
11622         (mi_multi_location_breakpoint_output_fixed): New.
11623         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11624         (mi_cmd_fix_multi_location_breakpoint_output): New.
11625         (mi_multi_location_breakpoint_output_fixed): New.
11626         * mi/mi-cmds.c (mi_cmds): Register command
11627         -fix-multi-location-breakpoint-output.
11628         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11629         interpreter "mi".
11630
11631 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11632
11633         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11634         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11635         instantiate mi_ui_out based on interpreter name.
11636         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11637         * mi/mi-main.c (mi_load_progress): Likewise.
11638
11639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11640
11641         * NEWS: Combine separate "New targets" sections for 8.3.
11642
11643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11644
11645         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11646         (ppcfbsd_init_abi): Install gdbarch
11647         "fetch_tls_load_module_address" and "get_thread_local_address"
11648         methods.
11649
11650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11651
11652         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11653         (riscv_fbsd_init_abi): Install gdbarch
11654         "fetch_tls_load_module_address" and "get_thread_local_address"
11655         methods.
11656
11657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11658
11659         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11660         (i386fbsd_init_abi): Install gdbarch
11661         "fetch_tls_load_module_address" and "get_thread_local_address"
11662         methods.
11663
11664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11665
11666         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11667         (amd64fbsd_init_abi): Install gdbarch
11668         "fetch_tls_load_module_address" and "get_thread_local_address"
11669         methods.
11670
11671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11672
11673         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11674         (struct fbsd_pspace_data): New type.
11675         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11676         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11677         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11678         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11679         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11680
11681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11682
11683         * gdbtypes.c (lookup_struct_elt): New function.
11684         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11685         * gdbtypes.h (struct struct_elt): New type.
11686         (lookup_struct_elt): New prototype.
11687
11688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11689
11690         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11691         remove disabled code block.
11692
11693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11694
11695         * gdbarch.sh (get_thread_local_address): New method.
11696         * gdbarch.h, gdbarch.c: Regenerate.
11697         * target.c (target_translate_tls_address): Use
11698         gdbarch_get_thread_local_address if present instead of
11699         target::get_thread_local_address.
11700
11701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11702
11703         * target.h (target::get_thread_local_address): Update comment.
11704
11705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11706
11707         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11708         objfile->separate_debug_objfile_backlink if not NULL.
11709
11710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11711
11712         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11713         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11714         (amd64bsd_store_inferior_registers): Likewise.
11715         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11716         Enable segment base registers.
11717         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11718         PT_GETFSBASE and PT_GETGSBASE.
11719         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11720         PT_SETGSBASE.
11721         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11722         segment base registers.
11723         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11724
11725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11726
11727         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11728         Update calls to i386_target_description to add 'segments'
11729         parameter.
11730         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11731         add segment base registers.
11732         * arch/i386.c (i386_create_target_description): Add 'segments'
11733         parameter to enable segment base registers.
11734         * arch/i386.h (i386_create_target_description): Likewise.
11735         * features/i386/32bit-segments.xml: New file.
11736         * features/i386/32bit-segments.c: Generate.
11737         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11738         call to i386_target_description to add 'segments' parameter.
11739         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11740         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11741         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11742         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11743         if feature is present.
11744         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11745         Add 'segments' parameter to call to i386_target_description.
11746         (i386_target_description): Add 'segments' parameter to enable
11747         segment base registers.
11748         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11749         to call to i386_target_description.
11750         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11751         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11752         Define I386_NUM_REGS.
11753         (i386_target_description): Add 'segments' parameter to enable
11754         segment base registers.
11755
11756 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11757
11758         PR/24325
11759         * source-cache.c: #undef open and close, to avoid unresolved
11760         externals during linking.
11761
11762 2019-03-12  Tom Tromey  <tromey@adacore.com>
11763
11764         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11765         const.  Add initializers.
11766         (_initialize_remote): Don't initialize ptid globals.
11767
11768 2019-03-12  Pedro Alves  <palves@redhat.com>
11769
11770         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11771
11772 2019-03-12  Pedro Alves  <palves@redhat.com>
11773
11774         * cp-name-parser.y (main): Remove unused 'len' variable.
11775
11776 2019-03-12  Tom Tromey  <tromey@adacore.com>
11777
11778         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11779         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11780
11781 2019-03-12  Tom Tromey  <tromey@adacore.com>
11782
11783         * linux-nat.c (iterate_over_lwps): Update.
11784         (stop_callback): Remove parameter.
11785         (stop_wait_callback, detach_callback, resume_set_callback)
11786         (select_singlestep_lwp_callback, set_ignore_sigint)
11787         (status_callback, resumed_callback, resume_clear_callback)
11788         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11789         data parameter.
11790         (linux_nat_target::detach, linux_nat_target::resume)
11791         (linux_stop_and_wait_all_lwps, select_event_lwp)
11792         (linux_nat_filter_event, linux_nat_wait_1)
11793         (linux_nat_target::kill, linux_nat_target::stop)
11794         (linux_nat_target::stop): Update.
11795         (linux_nat_resume_callback): Change type.
11796         (resume_stopped_resumed_lwps, count_events_callback)
11797         (select_event_lwp_callback): Likewise.
11798         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11799         * arm-linux-nat.c (struct update_registers_data): Remove.
11800         (update_registers_callback): Change type.
11801         (arm_linux_insert_hw_breakpoint1): Update.
11802         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11803         parameter.
11804         (x86_linux_dr_set_addr): Update.
11805         (x86_linux_dr_set_control): Update.
11806         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11807         (iterate_over_lwps): Use gdb::function_view.
11808         * nat/aarch64-linux-hw-point.c (struct
11809         aarch64_dr_update_callback_param): Remove.
11810         (debug_reg_change_callback): Change type.
11811         (aarch64_notify_debug_reg_change): Update.
11812         * s390-linux-nat.c (s390_refresh_per_info): Update.
11813
11814 2019-03-11  Tom Tromey  <tromey@adacore.com>
11815
11816         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11817         redundant assignment to "this_cu".
11818
11819 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11820
11821         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11822
11823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11824
11825         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11826         from...
11827         (rank_one_type): ... this.
11828
11829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11830
11831         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11832         from...
11833         (rank_one_type): ... this.
11834
11835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11836
11837         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11838         from...
11839         (rank_one_type): ... this.
11840
11841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11842
11843         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11844         from...
11845         (rank_one_type): ... this.
11846
11847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11848
11849         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11850         from...
11851         (rank_one_type): ... this.
11852
11853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11854
11855         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11856         from...
11857         (rank_one_type): ... this.
11858
11859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11860
11861         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11862         from...
11863         (rank_one_type): ... this.
11864
11865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11866
11867         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11868         from...
11869         (rank_one_type): ... this.
11870
11871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11872
11873         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11874         from...
11875         (rank_one_type): ... this.
11876
11877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11878
11879         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11880         from...
11881         (rank_one_type): ... this.
11882
11883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11884
11885         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11886         from...
11887         (rank_one_type): ... this.
11888
11889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11890
11891         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11892         from...
11893         (rank_one_type): ... this.
11894
11895 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11896
11897         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11898         inferior-events' shows the example events.
11899
11900 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11901
11902         Support styling on native MS-Windows console
11903
11904         PR/24315
11905         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11906         on MS-Windows if $TERM is not defined.
11907
11908         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11909
11910         * posix-hdep.c (gdb_console_fputs):
11911         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11912         functions.
11913         * ui-file.h (gdb_console_fputs): Add prototype.
11914
11915         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11916         back to fputs only if the former returns zero.
11917
11918 2019-03-07  Tom Tromey  <tom@tromey.com>
11919
11920         * symmisc.c (print_symbol_bcache_statistics): Update.
11921         (print_objfile_statistics): Update.
11922         * symfile.c (allocate_symtab): Update.
11923         * stabsread.c: Don't include bcache.h.
11924         * psymtab.h (struct psymbol_bcache): Don't declare.
11925         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11926         (psymbol_bcache_init, psymbol_bcache_free)
11927         (psymbol_bcache_get_bcache): Don't declare.
11928         * psymtab.c (struct psymbol_bcache): Remove.
11929         (psymtab_storage::psymtab_storage): Update.
11930         (psymtab_storage::~psymtab_storage): Update.
11931         (psymbol_bcache_init, psymbol_bcache_free)
11932         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11933         (add_psymbol_to_bcache): Update.
11934         (allocate_psymtab): Update.
11935         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11936         macro_cache>: No longer pointers.
11937         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11938         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11939         * macrotab.c (macro_bcache): Update.
11940         * macroexp.c: Don't include bcache.h.
11941         * gdbtypes.c (check_types_worklist): Update.
11942         (types_deeply_equal): Remove TRY/CATCH.  Update.
11943         * elfread.c (elf_symtab_read): Update.
11944         * dwarf2read.c: Don't include bcache.h.
11945         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11946         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11947         (print_bcache_statistics, bcache_memory_used): Don't declare.
11948         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11949         methods.  Rename all data members.
11950         * bcache.c (struct bcache): Move to bcache.h.
11951         (bcache::expand_hash_table): Rename from expand_hash_table.
11952         (bcache): Remove.
11953         (bcache::insert): Rename from bcache_full.
11954         (bcache::compare): Rename from bcache_compare.
11955         (bcache_xmalloc): Remove.
11956         (bcache::~bcache): Rename from bcache_xfree.
11957         (bcache::print_statistics): Rename from print_bcache_statistics.
11958         (bcache::memory_used): Rename from bcache_memory_used.
11959
11960 2019-03-07  Pedro Alves  <palves@redhat.com>
11961
11962         * infrun.c (normal_stop): Also check for
11963         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11964
11965 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11966
11967         * f-lang.c (value_from_host_double): Moved to...
11968         * value.c (value_from_host_double): ...here.
11969         * value.h (value_from_host_double): Declare.
11970         * guile/scm-math.c (vlscm_convert_typed_number): Use
11971         value_from_host_double.
11972         (vlscm_convert_number): Likewise.
11973         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11974         * python/py-value.c (convert_value_from_python): Likewise.
11975
11976 2019-03-06  Tom Tromey  <tom@tromey.com>
11977
11978         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11979
11980 2019-03-06  Tom Tromey  <tom@tromey.com>
11981
11982         * utils.h (free_current_contents): Don't declare.
11983         * utils.c (free_current_contents): Remove.
11984
11985 2019-03-06  Tom Tromey  <tom@tromey.com>
11986
11987         * top.c (quit_force): Update.
11988         * main.c (captured_command_loop): Update.
11989         * common/new-op.c (operator new): Update.
11990         * common/common-exceptions.c (struct catcher)
11991         <save_cleanup_chain>: Remove member.
11992         (exceptions_state_mc_init): Update.
11993         (exception_try_scope_entry): Return nullptr.
11994         (exception_try_scope_exit, exception_rethrow)
11995         (throw_exception_sjlj, throw_exception_cxx): Update.
11996         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11997         (all_cleanups, do_cleanups, discard_cleanups)
11998         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11999         (restore_cleanups, restore_final_cleanups): Don't declare.
12000         (do_final_cleanups): Remove parameter.
12001         * common/cleanups.c (cleanup_chain, make_cleanup)
12002         (make_cleanup_dtor, all_cleanups, do_cleanups)
12003         (discard_my_cleanups, discard_cleanups)
12004         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12005         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12006         (null_cleanup): Remove.
12007         (do_final_cleanups): Remove parameter.
12008
12009 2019-03-06  Tom Tromey  <tom@tromey.com>
12010
12011         * remote.c (remote_target::remote_parse_stop_reply): Use
12012         unique_xmalloc_ptr.
12013
12014 2019-03-06  Tom Tromey  <tom@tromey.com>
12015
12016         * stabsread.c (struct stabs_field_info): Rename from field_info.
12017         <list, fnlist>: Add initializers.
12018         <obstack>: New member.
12019         (read_member_functions, read_struct_fields, read_baseclasses):
12020         Allocate on obstack.  Don't use cleanups.
12021         (read_one_struct_field, read_member_functions, read_struct_fields)
12022         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12023         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12024         (read_struct_type): Update.
12025
12026 2019-03-06  Tom Tromey  <tom@tromey.com>
12027
12028         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12029         * common/filestuff.h (make_cleanup_close): Don't declare.
12030         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12031         Remove.
12032
12033 2019-03-06  Tom Tromey  <tom@tromey.com>
12034
12035         * solib-aix.c: Use make_scope_exit.
12036
12037 2019-03-06  Tom Tromey  <tom@tromey.com>
12038
12039         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12040         Use make_scope_exit.
12041
12042 2019-03-06  Tom Tromey  <tom@tromey.com>
12043
12044         * solib-svr4.c (disable_probes_interface): Remove parameter.
12045         (svr4_handle_solib_event): Use make_scope_exit.
12046
12047 2019-03-06  Tom Tromey  <tom@tromey.com>
12048
12049         * remote.c (struct stop_reply_deleter): Remove.
12050         (stop_reply_up): Update.
12051         (struct stop_reply): Derive from notif_event.  Don't typedef.
12052         <regcache>: Now a std::vector.
12053         (stop_reply_xfree): Remove.
12054         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12055         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12056         (remote_target::discard_pending_stop_replies): Use delete.
12057         (remote_target::remote_parse_stop_reply): Update.
12058         (remote_target::process_stop_reply): Update.
12059         * remote-notif.h (struct notif_event): Add virtual destructor.
12060         Remove "dtr" member.
12061         (struct notif_client) <alloc_event>: Return a unique_ptr.
12062         (notif_event_xfree): Don't declare.
12063         (notif_event_up): New typedef.
12064         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12065         (notif_event_xfree, do_notif_event_xfree): Remove.
12066         (remote_notif_state_xfree): Update.
12067
12068 2019-03-06  Tom Tromey  <tom@tromey.com>
12069
12070         * infrun.c (displaced_step_clear_cleanup): Now a
12071         forward_scope_exit type.
12072         (displaced_step_prepare_throw): Update.
12073         (displaced_step_fixup): Update.
12074
12075 2019-03-06  Tom Tromey  <tom@tromey.com>
12076
12077         * inferior.h (class inferior): Update comment.
12078         * gdbthread.h (class thread_info): Update comment.
12079
12080 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12081             Tom Tromey  <tom@tromey.com>
12082
12083         * stabsread.h (struct stab_section_list): Remove.
12084         (coffstab_build_psymtabs): Update.
12085         * dbxread.c (symbuf_sections): Now a std::vector.
12086         (sect_idx): New global.
12087         (fill_symbuf): Update.
12088         (coffstab_build_psymtabs): Change type of stabsects parameter.
12089         Update.
12090         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12091         std::vector.
12092         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12093         (coff_locate_sections): Update.
12094         (coff_symfile_read): Remove cleanups.  Update.
12095         (init_stringtab): Add storage parameter.
12096         (free_stringtab, free_stringtab_cleanup): Remove.
12097         (init_lineno): Add storage parameter.
12098         (free_linetab, free_linetab_cleanup): Remove.
12099
12100 2019-03-06  Pedro Alves  <palves@redhat.com>
12101
12102         * linux-fork.c (fork_info::clobber_regs): Delete.
12103         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12104         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12105         comment.  Adjust.
12106         (scoped_switch_fork_info::scoped_switch_fork_info)
12107         (checkpoint_command, linux_fork_context): Adjust
12108         fork_save_infrun_state calls.
12109
12110 2019-03-06  Pedro Alves  <palves@redhat.com>
12111
12112         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12113         (inf_has_multiple_threads): Return 'bool' and rewrite using
12114         inferior_info::threads().
12115
12116 2019-03-06  Pedro Alves  <palves@redhat.com>
12117
12118         * linux-fork.c: Include <list>.
12119         (fork_list): Now a std::list instance.
12120         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12121         (forks_exist_p, find_last_fork): Adjust.
12122         (new_fork): Delete.
12123         (one_fork_p): New.
12124         (add_fork): Adjust.
12125         (free_fork): Delete, folded into fork_info::~fork_info().
12126         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12127         Adjust.
12128         (init_fork_list): Delete.
12129         (linux_fork_killall, linux_fork_mourn_inferior)
12130         (linux_fork_detach, info_checkpoints_command): Adjust.
12131         (_initialize_linux_fork): No longer call init_fork_list.
12132
12133 2019-03-06  Pedro Alves  <palves@redhat.com>
12134
12135         * linux-fork.c (new_fork): New, split out of ...
12136         (add_fork): ... this.  Return void.  Move "first fork" special
12137         case from here, to ...
12138         (checkpoint_command): ... here.
12139         * linux-linux.h (add_fork): Return void.
12140
12141 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12142
12143         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12144
12145 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12146             Chris January  <chris.january@arm.com>
12147             David Lecomber  <david.lecomber@arm.com>
12148
12149         * f-exp.y: New token, UNOP_INTRINSIC.
12150         (exp): New pattern using UNOP_INTRINSIC token.
12151         (f77_keywords): Add 'abs' keyword.
12152         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12153         (value_from_host_double): New function.
12154         (evaluate_subexp_f): Support UNOP_ABS.
12155
12156 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12157
12158         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12159         types.
12160
12161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12162
12163         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12164         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12165         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12166
12167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12168
12169         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12170
12171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12172             Chris January  <chris.january@arm.com>
12173
12174         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12175         * f-exp.y: Define 'KIND' token.
12176         (exp): New pattern for KIND expressions.
12177         (ptype): Handle types with a kind extension.
12178         (direct_abs_decl): Extend to spot kind extensions.
12179         (f77_keywords): Add 'kind' to the list.
12180         (push_kind_type): New function.
12181         (convert_to_kind_type): New function.
12182         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12183         * parse.c (operator_length_standard): Likewise.
12184         * parser-defs.h (enum type_pieces): Add tp_kind.
12185         * std-operator.def: Add UNOP_KIND.
12186
12187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12188
12189         * f-exp.y (f_parse): Set yydebug.
12190
12191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12192
12193         * f-lang.c (evaluate_subexp_f): New function.
12194         (exp_descriptor_f): New global.
12195         (f_language_defn): Use exp_descriptor_f instead of
12196         exp_descriptor_standard.
12197
12198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12199
12200         * f-exp.y (struct token): Add comments.
12201         (dot_ops): Remove uppercase versions and the end marker.
12202         (f77_keywords): Likewise.
12203         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12204         entries in the dot_ops array are case insensitive, and use
12205         strncasecmp to compare strings.  Also some whitespace cleanup in
12206         this area.  Similar for the f77_keywords array, except entries in
12207         this list might be case sensitive.
12208
12209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12210
12211         * f-exp.y (struct f77_boolean_val): Add comments.
12212         (boolean_values): Remove uppercase versions, and end marker.
12213         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12214         and use strncasecmp to achieve case insensitivity.  Additionally,
12215         perform whitespace cleanup around this code.
12216
12217 2019-03-06  Tom Tromey  <tromey@adacore.com>
12218
12219         * remote-sim.c (gdbsim_target_open): Use result of
12220         gdb_argv::release.
12221
12222 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12223         Dirk Schubert  <dirk.schubert@arm.com>
12224         Chris January  <chris.january@arm.com>
12225
12226         * eval.c (evaluate_subexp_standard): Call Fortran argument
12227         wrapping logic.
12228         * f-lang.c (struct value): A value which can be passed into a
12229         Fortran function call.
12230         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12231         where appropriate.
12232         (struct type): Value ready for a Fortran function call.
12233         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12234         is needed.
12235         * f-lang.h (fortran_argument_convert): Declaration.
12236         (fortran_preserve_arg_pointer): Declaration.
12237         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12238
12239 2019-03-05  Tom Tromey  <tromey@adacore.com>
12240
12241         * python/py-prettyprint.c (print_string_repr): Remove #if.
12242         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12243
12244 2019-03-05  Tom Tromey  <tromey@adacore.com>
12245
12246         * target.c (the_dummy_target): Move later.  Change type to
12247         "dummy_target".
12248         (initialize_targets): Don't initialize the_dummy_target.
12249
12250 2019-03-05  Tom Tromey  <tromey@adacore.com>
12251
12252         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12253         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12254
12255 2019-03-05  Tom Tromey  <tromey@adacore.com>
12256
12257         * windows-nat.c (windows_nat_target::attach)
12258         (windows_nat_target::detach): Don't call gdb_flush.
12259         * valprint.c (generic_val_print, val_print, val_print_string):
12260         Don't call gdb_flush.
12261         * utils.c (defaulted_query): Don't call gdb_flush.
12262         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12263         * target.c (target_announce_detach): Don't call gdb_flush.
12264         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12265         * remote.c (extended_remote_target::attach): Don't call
12266         gdb_flush.
12267         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12268         * printcmd.c (do_examine): Don't call gdb_flush.
12269         (info_display_command): Don't call gdb_flush.
12270         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12271         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12272         * memattr.c (info_mem_command): Don't call gdb_flush.
12273         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12274         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12275         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12276         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12277         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12278         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12279         (gnu_nat_target::detach): Don't call gdb_flush.
12280         * f-valprint.c (f_val_print): Don't call gdb_flush.
12281         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12282         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12283         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12284         gdb_flush.
12285         * c-valprint.c (c_val_print): Don't call gdb_flush.
12286         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12287
12288 2019-03-05  Tom Tromey  <tromey@adacore.com>
12289
12290         * varobj.c (update_dynamic_varobj_children): Update.
12291         (install_default_visualizer): Use reset, not release.
12292         * value.c (set_internalvar): Update.
12293         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12294         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12295         ATTRIBUTE_UNUSED_RESULT.
12296
12297 2019-03-05  Tom Tromey  <tromey@adacore.com>
12298
12299         * remote.c (class scoped_remote_fd) <release>: Add
12300         ATTRIBUTE_UNUSED_RESULT.
12301
12302 2019-03-05  Tom Tromey  <tromey@adacore.com>
12303
12304         * macroexp.c (struct macro_buffer) <release>: Add
12305         ATTRIBUTE_UNUSED_RESULT.
12306
12307 2019-03-05  Tom Tromey  <tromey@adacore.com>
12308
12309         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12310         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12311         ATTRIBUTE_UNUSED_RESULT.
12312
12313 2019-03-05  Tom Tromey  <tromey@adacore.com>
12314
12315         * common/scoped_fd.h (class scoped_fd) <release>: Add
12316         ATTRIBUTE_UNUSED_RESULT.
12317
12318 2019-03-05  Tom Tromey  <tromey@adacore.com>
12319
12320         * parser-defs.h (struct parser_state) <release>: Add
12321         ATTRIBUTE_UNUSED_RESULT.
12322
12323 2019-03-05  Tom Tromey  <tromey@adacore.com>
12324
12325         * utils.h (class gdb_argv) <release>: Add
12326         ATTRIBUTE_UNUSED_RESULT.
12327         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12328
12329 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12330
12331         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12332         for-loop range, to avoid compiler warnings.
12333
12334         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12335         avoid compiler warnings about unused variables.
12336
12337         * NEWS: Mention end of support for native debugging on MS-Windows
12338         before XP.
12339
12340         PR gdb/24292
12341         * common/netstuff.c:
12342         * gdbserver/gdbreplay.c
12343         * gdbserver/remote-utils.c:
12344         * ser-tcp.c:
12345         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12346         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12347         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12348         'getaddrinfo' and 'freeaddrinfo' were not available before
12349         Windows XP, and mingw.org's MinGW headers by default define
12350         _WIN32_WINNT to 0x500.
12351
12352 2019-03-01  Gary Benson <gbenson@redhat.com>
12353
12354         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12355
12356 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12357             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12358
12359         PR gdb/8527
12360         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12361         set_sigint_trap, clear_sigint_trap.
12362
12363 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12364
12365         * target.c (target_detach): Clear the regcache and the
12366         frame cache.
12367
12368 2019-02-27  Pedro Alves  <palves@redhat.com>
12369
12370         * utils.c (set_screen_size): When we cap the height/width sizes,
12371         tweak the corresponding command variable to show "unlimited":
12372
12373 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12374             Pedro Alves  <palves@redhat.com>
12375
12376         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12377         before calling rl_set_screen_size.
12378
12379 2019-02-27  Tom Tromey  <tromey@adacore.com>
12380
12381         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12382         define.
12383         * python/py-value.c: Remove Python 2.4 workaround.
12384         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12385         workaround.
12386         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12387         Python 2.4 workaround.
12388         * python/python-internal.h: Remove Python 2.4 comment.
12389         (Py_ssize_t): Don't define.
12390         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12391         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12392         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12393         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12394         * python/python.c (do_start_initialization): Remove Python 2.4
12395         workaround.
12396         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12397         (print_children): Remove Python 2.4 workaround.
12398         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12399         workaround.
12400         (CHARBUFFERPROC_NAME): Remove.
12401         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12402         Python 2.4 workaround.
12403
12404 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12405
12406         * NEWS: Note minimum Python version.
12407
12408 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12409
12410         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12411         code from these functions.  Remove corresponding ifdefs.  Use
12412         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12413         Remove gotos and target of gotos.
12414         (infpy_search_memory): Likewise.
12415
12416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12417
12418         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12419         (hppa_gdbarch_init): Don't register deleted functions with
12420         gdbarch.
12421
12422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12423
12424         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12425         (h8300_unwind_sp): Delete.
12426         (h8300_dummy_id): Delete.
12427         (h8300_gdbarch_init): Don't register deleted functions with
12428         gdbarch.
12429
12430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12431
12432         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12433         (ft32_unwind_pc): Delete.
12434         (ft32_unwind_sp): Delete.
12435         (ft32_gdbarch_init): Don't register deleted functions with
12436         gdbarch.
12437
12438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12439
12440         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12441         (frv_unwind_pc): Delete.
12442         (frv_unwind_sp): Delete.
12443         (frv_gdbarch_init): Don't register deleted functions with
12444         gdbarch.
12445
12446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12447
12448         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12449         (riscv_unwind_pc): Delete.
12450         (riscv_unwind_sp): Delete.
12451         (riscv_gdbarch_init): Don't register deleted functions with
12452         gdbarch.
12453
12454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12455
12456         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12457         (csky_unwind_pc): Delete.
12458         (csky_unwind_sp): Delete.
12459         (csky_gdbarch_init): Don't register deleted functions with
12460         gdbarch.
12461
12462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12463
12464         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12465         (cris_unwind_pc): Delete.
12466         (cris_unwind_sp): Delete.
12467         (cris_gdbarch_init): Don't register deleted functions with
12468         gdbarch.
12469
12470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12471
12472         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12473         (bfin_unwind_pc): Delete.
12474         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12475
12476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12477
12478         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12479         (arm_unwind_pc): Delete.
12480         (arm_unwind_sp): Delete.
12481         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12482
12483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12484
12485         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12486         (arc_unwind_pc): Delete.
12487         (arc_unwind_sp): Delete.
12488         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12489
12490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12493         (alpha_unwind_pc): Delete.
12494         (alpha_gdbarch_init): Don't register deleted functions with
12495         gdbarch.
12496
12497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12498
12499         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12500         (aarch64_unwind_pc): Delete.
12501         (aarch64_unwind_sp): Delete.
12502         (aarch64_gdbarch_init): Don't register deleted functions with
12503         gdbarch.
12504
12505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12506
12507         * gdbtypes.c (type_align): Don't consider static members when
12508         computing structure alignment.
12509
12510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12511
12512         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12513         return 0 for other types.
12514         * arch-utils.c (default_type_align): Always return 0.
12515         * gdbarch.h: Regenerate.
12516         * gdbarch.sh (type_align): Extend comment.
12517         * gdbtypes.c (type_align): Add additional comments, always call
12518         gdbarch_type_align before applying the default rules.
12519         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12520         generic code will then apply a suitable default.
12521         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12522         types, return 0 for other types.
12523
12524 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12525
12526         * NEWS: Create a new section for the next release branch.
12527         Rename the section of the current branch, now that it has
12528         been cut.
12529
12530 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12531
12532         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12533         * version.in: Bump version to 8.3.50.DATE-git.
12534
12535 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12536
12537         * aix-thread.c (ptid_cmp): Remove unused variable.
12538         (get_signaled_thread): Likewise.
12539         (store_regs_user_thread): Likewise.
12540         (store_regs_kernel_thread): Likewise.
12541         (fetch_regs_kernel_thread): Remove shadowed variable.
12542
12543 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12544
12545         * features/riscv/32bit-cpu.xml: Add register numbers.
12546         * features/riscv/32bit-fpu.c: Regenerate.
12547         * features/riscv/32bit-fpu.xml: Add register numbers.
12548         * features/riscv/64bit-cpu.xml: Add register numbers.
12549         * features/riscv/64bit-fpu.c: Regenerate.
12550         * features/riscv/64bit-fpu.xml: Add register numbers.
12551
12552 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12553
12554         * NEWS: Mention two argument form of gdb.Value constructor.
12555         * python/py-value.c (convert_buffer_and_type_to_value): New
12556         function.
12557         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12558         Add support for handling an optional second argument.  Call
12559         convert_buffer_and_type_to_value as appropriate.
12560         * python/python-internal.h (Py_buffer_deleter): New struct.
12561         (Py_buffer_up): New typedef.
12562
12563 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12564
12565         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12566         instead of releasing ownership.
12567
12568 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12569
12570         * dwarf2read.c (open_and_init_dwp_file): Call
12571         elf_numsections instead of bfd_count_sections to initialize
12572         dwp_file->num_sections.
12573
12574 2019-02-25  Tom Tromey  <tromey@adacore.com>
12575
12576         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12577
12578 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12579
12580         * gcore.in: Add '--readnever' option when invoking GDB.
12581
12582 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12583
12584         * MAINTAINERS: Update my email address.
12585
12586 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12587
12588         * build-id.c (build_id_to_debug_bfd_1): New function.
12589         (build_id_to_debug_bfd): Look for separate debug file in
12590         sysroot.
12591
12592 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12593
12594         * gdbarch.sh: Update the copyright year range that is placed into
12595         generated files.
12596
12597 2019-02-22  Keith Seitz  <keiths@redhat.com>
12598
12599         PR symtab/23853
12600         * linespec.c (create_sals_line_offset): Search for the default
12601         symtab's filename instead of its fullname.
12602
12603 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12604
12605         * NEWS: Update style defaults.
12606
12607 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12608
12609         * main.c (captured_main_1): Disable styling in batch mode.
12610
12611 2019-02-20  Tom Tromey  <tom@tromey.com>
12612
12613         * symtab.c (symtab_symbol_info): Fix typos.
12614
12615 2019-02-20  Tom Tromey  <tromey@adacore.com>
12616
12617         * findcmd.c (_initialize_mem_search): Use upper case for
12618         metasyntactic variables.
12619
12620 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12621
12622         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12623         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12624
12625 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12626
12627         * top.h (source_file_name): Change to std::string.
12628         * top.c (source_file_name): Likewise.
12629         (command_line_input): Adjust.
12630         * cli/cli-script.c (script_from_file): Adjust.
12631
12632 2019-02-19  Tom Tromey  <tromey@adacore.com>
12633
12634         * ravenscar-thread.c
12635         (ravenscar_thread_target::update_thread_list): Don't call
12636         ada_build_task_list.
12637         * ada-lang.h (ada_build_task_list): Don't declare.
12638         * ada-tasks.c (struct ada_tasks_inferior_data)
12639         <task_list_valid_p>: Now bool.
12640         (read_known_tasks, ada_task_list_changed)
12641         (ada_tasks_invalidate_inferior_data): Update.
12642         (read_known_tasks_array): Return bool.
12643         (read_known_tasks_list): Likewise.
12644         (read_known_tasks): Return void.
12645         (ada_build_task_list): Now static.
12646
12647 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12648
12649         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12650         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12651
12652 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12653
12654         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12655         variant for ada_tasks_pspace_data_handle and
12656         ada_tasks_inferior_data_handle.
12657         (ada_tasks_pspace_data_cleanup): New function.
12658         (ada_tasks_inferior_data_cleanup): New function.
12659
12660 2019-02-17  Tom Tromey  <tom@tromey.com>
12661
12662         * macrotab.h (macro_source_fullname): Return a std::string.
12663         * macrotab.c (macro_include, check_for_redefinition)
12664         (macro_undef, macro_lookup_definition, foreach_macro)
12665         (foreach_macro_in_scope): Update.
12666         (macro_source_fullname): Return a std::string.
12667         * macrocmd.c (show_pp_source_pos): Update.
12668
12669 2019-02-17  Tom Tromey  <tom@tromey.com>
12670
12671         * macrocmd.c (show_pp_source_pos): Style the file names.
12672
12673 2019-02-17  Tom Tromey  <tom@tromey.com>
12674
12675         PR tui/24197:
12676         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12677
12678 2019-02-17  Tom Tromey  <tom@tromey.com>
12679
12680         * ada-lang.c (user_select_syms): Use filtered printing.
12681         * utils.c (wrap_style): New global.
12682         (desired_style): Remove.
12683         (emit_style_escape): Add stream parameter.
12684         (set_output_style, reset_terminal_style, prompt_for_continue):
12685         Update.
12686         (flush_wrap_buffer): Only flush gdb_stdout.
12687         (wrap_here): Set wrap_style.
12688         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12689         treat escape sequences as a character.  Change when wrap buffer is
12690         flushed.
12691         (fputs_styled): Do not set the output style when the default is
12692         requested.
12693         * ui-style.h (struct ui_file_style) <is_default>: New method.
12694         * source.c (print_source_lines_base): Emit escape sequences in one
12695         piece.
12696
12697 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12698
12699         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12700         integers and enumeration types.
12701
12702 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12703
12704         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12705         instead of lookup_symbol_in_language
12706         (do_exact_match): New function.
12707         (ada_get_symbol_name_matcher): Return do_exact_match when
12708         doing a verbatim match.
12709
12710 2019-02-15  Tom Tromey  <tromey@adacore.com>
12711
12712         * ravenscar-thread.c (ravenscar_thread_target::resume)
12713         (ravenscar_thread_target::wait): Special case wildcard requests.
12714
12715 2019-02-15  Tom Tromey  <tromey@adacore.com>
12716
12717         * ravenscar-thread.c (base_ptid): Remove.
12718         (struct ravenscar_thread_target) <close>: New method.
12719         <m_base_ptid>: New member.
12720         <update_inferior_ptid, active_task, task_is_currently_active,
12721         runtime_initialized>: Declare methods.
12722         <ravenscar_thread_target>: Add constructor.
12723         (ravenscar_thread_target::task_is_currently_active)
12724         (ravenscar_thread_target::update_inferior_ptid)
12725         (ravenscar_runtime_initialized): Rename.  Now methods.
12726         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12727         (ravenscar_thread_target::update_thread_list): Update.
12728         (ravenscar_thread_target::active_task): Now method.
12729         (ravenscar_thread_target::store_registers)
12730         (ravenscar_thread_target::prepare_to_store)
12731         (ravenscar_thread_target::prepare_to_store)
12732         (ravenscar_thread_target::mourn_inferior): Update.
12733         (ravenscar_inferior_created): Use "new" to create target.
12734         (ravenscar_thread_target::get_ada_task_ptid): Update.
12735         (_initialize_ravenscar): Don't initialize base_ptid.
12736         (ravenscar_ops): Remove global.
12737
12738 2019-02-15  Tom Tromey  <tromey@adacore.com>
12739
12740         * target.h (push_target): Declare new overload.
12741         * target.c (push_target): New overload, taking an rvalue reference.
12742         * remote.c (remote_target::open_1): Use push_target overload.
12743         * corelow.c (core_target_open): Use push_target overload.
12744
12745 2019-02-15  Tom Tromey  <tromey@adacore.com>
12746
12747         * ravenscar-thread.c (is_ravenscar_task)
12748         (ravenscar_task_is_currently_active): Return bool.
12749         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12750         (_initialize_ravenscar): Remove "(void)".
12751         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12752         Return bool.
12753
12754 2019-02-15  Tom Tromey  <tromey@adacore.com>
12755
12756         * ravenscar-thread.c (ravenscar_runtime_initializer)
12757         (has_ravenscar_runtime, get_running_thread_id)
12758         (ravenscar_thread_target::resume): Fix indentation.
12759
12760 2019-02-15  Tom Tromey  <tromey@adacore.com>
12761
12762         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12763         from ravenscar_arch_ops.
12764         (sparc_ravenscar_ops::fetch_registers)
12765         (sparc_ravenscar_ops::store_registers): Now methods.
12766         (sparc_ravenscar_prepare_to_store): Remove.
12767         (sparc_ravenscar_ops): Redefine.
12768         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12769         methods and destructor.  Remove members.
12770         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12771         (ravenscar_thread_target::store_registers)
12772         (ravenscar_thread_target::prepare_to_store): Update.
12773         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12774         Remove.
12775         (struct ppc_ravenscar_powerpc_ops): Derive from
12776         ravenscar_arch_ops.
12777         (ppc_ravenscar_powerpc_ops::fetch_registers)
12778         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12779         (ppc_ravenscar_powerpc_ops): Redefine.
12780         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12781         (ppc_ravenscar_e500_ops::fetch_registers)
12782         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12783         (ppc_ravenscar_e500_ops): Redefine.
12784         * aarch64-ravenscar-thread.c
12785         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12786         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12787         (aarch64_ravenscar_fetch_registers)
12788         (aarch64_ravenscar_store_registers): Now methods.
12789         (aarch64_ravenscar_ops): Redefine.
12790
12791 2019-02-15  Tom Tromey  <tromey@adacore.com>
12792
12793         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12794         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12795         (ravenscar_thread_target::stopped_by_watchpoint)
12796         (ravenscar_thread_target::stopped_data_address)
12797         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12798
12799 2019-02-15  Tom Tromey  <tromey@adacore.com>
12800
12801         * ravenscar-thread.c: Fix some typos.
12802
12803 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12804             Tom Tromey  <tromey@adacore.com>
12805
12806         * ada-lang.c (ada_exception_sal): Change addr_string to a
12807         std::string.
12808         (create_ada_exception_catchpoint): Update.
12809
12810 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12811             Tom Tromey  <tromey@adacore.com>
12812
12813         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12814         (bp_location_ops): Remove.
12815         (base_breakpoint_allocate_location): Update.
12816         (free_bp_location): Update.
12817         * ada-lang.c (class ada_catchpoint_location)
12818         <ada_catchpoint_location>: Remove ops parameter.
12819         (ada_catchpoint_location_dtor): Remove.
12820         (ada_catchpoint_location_ops): Remove.
12821         (allocate_location_exception): Update.
12822         * breakpoint.h (struct bp_location_ops): Remove.
12823         (class bp_location) <bp_location>: Remove bp_location_ops
12824         parameter.
12825         <~bp_location>: Add destructor.
12826         <ops>: Remove.
12827
12828 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12829             Pedro Alves  <palves@redhat.com>
12830
12831         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12832         'PATH_MAX'.
12833
12834 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12835             Samuel Thibault  <samuel.thibault@gnu.org>
12836             Thomas Schwinge  <thomas@codesourcery.com>
12837
12838         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12839         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12840
12841 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12842
12843         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12844         (check_empty): Use "const char *".
12845
12846         * gnu-nat.c (gnu_nat_target::detach): Instead of
12847         'detach_inferior (pid)' call
12848         'detach_inferior (find_inferior_pid (pid))'.
12849
12850         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12851         'nat/fork-inferior.o'.
12852         * gnu-nat.c: #include "nat/fork-inferior.h".
12853
12854         * gnu-nat.c (gnu_nat_target::detach): Instead of
12855         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12856         * gnu-nat.h: #include "inf-child.h".
12857         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12858         'i386_gnu_nat_target::fetch_registers'.
12859         (gnu_store_registers): Rename/move to
12860         'i386_gnu_nat_target::store_registers'.
12861
12862         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12863         * gnu-nat.h (mach_thread_info): New function.
12864         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12865
12866         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12867
12868 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12869
12870         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12871
12872 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12873
12874         * windows-nat.c (windows_add_thread): Add new parameter
12875         "main_thread_p" with default value set to false.  Update
12876         function documentation as well as all callers.
12877         (windows_delete_thread): Likewise.
12878         (fake_create_process): Update call to windows_add_thread.
12879         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12880         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12881         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12882         call to windows_delete_thread.
12883
12884 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12885
12886         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12887
12888 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12889
12890         * symfile.c (find_separate_debug_file): Use canonical path of
12891         sysroot with child_path instead of gdb_sysroot if it is valid.
12892
12893 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12894
12895         * symfile.c (find_separate_debug_file): Use child_path to
12896         determine if an object file is under a sysroot.
12897
12898 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12899
12900         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12901         unittests/child-path-selftests.c.
12902         * common/pathstuff.c (child_path): New function.
12903         * common/pathstuff.h (child_path): New prototype.
12904         * unittests/child-path-selftests.c: New file.
12905
12906 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12907
12908         * symfile.c (find_separate_debug_file): Look for separate debug
12909         files in debug directories under the sysroot.
12910
12911 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12912
12913         * symtab.h (struct minimal_symbol data_p): New const method.
12914         (struct minimal_symbol text_p): Likewise.
12915         * symtab.c (output_source_filename): Use file name style
12916         to print file name.
12917         (print_symbol_info): Likewise.
12918         (print_msymbol_info): Use address style to print addresses.
12919         Use function name style to print executable text symbols.
12920         (expand_symtab_containing_pc): Use data_p.
12921         (find_pc_sect_compunit_symtab): Likewise.
12922
12923 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12924
12925         * breakpoint.c (describe_other_breakpoints): Use address style
12926         to print addresses.
12927         (say_where): Likewise.
12928
12929 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12930
12931         * ada-typeprint.c (print_func_type): Print function name
12932         style to print function name.
12933         * c-typeprint.c (c_print_type_1): Likewise.
12934
12935 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12936
12937         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12938         for execve.
12939
12940 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12941
12942         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12943         type_stack.
12944
12945 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12946
12947         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12948         TYPE_CODE_REF types.
12949
12950 2019-02-08  Jim Wilson  <jimw@sifive.com>
12951
12952         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12953         (riscv_linux_fregset): New.
12954         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12955
12956 2019-02-07  Tom Tromey  <tom@tromey.com>
12957
12958         * thread.c (thread_cancel_execution_command): Update.
12959         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12960         methods.
12961         (struct thread_fsm_ops): Remove.
12962         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12963         (thread_fsm_should_stop, thread_fsm_return_value)
12964         (thread_fsm_set_finished, thread_fsm_finished_p)
12965         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12966         Don't declare.
12967         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12968         * infrun.c (clear_proceed_status_thread)
12969         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12970         (print_stop_event): Update.
12971         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12972         Add constructor.
12973         (step_command_fsm_ops): Remove.
12974         (new_step_command_fsm): Remove.
12975         (step_1): Update.
12976         (step_command_fsm::should_stop): Rename from
12977         step_command_fsm_should_stop.
12978         (step_command_fsm::clean_up): Rename from
12979         step_command_fsm_clean_up.
12980         (step_command_fsm::do_async_reply_reason): Rename from
12981         step_command_fsm_async_reply_reason.
12982         (struct until_next_fsm): Inherit from thread_fsm.  Add
12983         constructor.
12984         (until_next_fsm_ops): Remove.
12985         (new_until_next_fsm): Remove.
12986         (until_next_fsm::should_stop): Rename from
12987         until_next_fsm_should_stop.
12988         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12989         (until_next_fsm::do_async_reply_reason): Rename from
12990         until_next_fsm_async_reply_reason.
12991         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12992         constructor.  Change type of breakpoint.
12993         (finish_command_fsm_ops): Remove.
12994         (new_finish_command_fsm): Remove.
12995         (finish_command_fsm::should_stop): Rename from
12996         finish_command_fsm_should_stop.
12997         (finish_command_fsm::clean_up): Rename from
12998         finish_command_fsm_clean_up.
12999         (finish_command_fsm::return_value): Rename from
13000         finish_command_fsm_return_value.
13001         (finish_command_fsm::do_async_reply_reason): Rename from
13002         finish_command_fsm_async_reply_reason.
13003         (finish_command): Update.
13004         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13005         Add constructor.
13006         (call_thread_fsm_ops): Remove.
13007         (call_thread_fsm::call_thread_fsm): Rename from
13008         new_call_thread_fsm.
13009         (call_thread_fsm::should_stop): Rename from
13010         call_thread_fsm_should_stop.
13011         (call_thread_fsm::should_notify_stop): Rename from
13012         call_thread_fsm_should_notify_stop.
13013         (run_inferior_call, call_function_by_hand_dummy): Update.
13014         * cli/cli-interp.c (should_print_stop_to_console): Update.
13015         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13016         Add constructor.  Change type of location_breakpoint,
13017         caller_breakpoint.
13018         (until_break_fsm_ops): Remove.
13019         (new_until_break_fsm): Remove.
13020         (until_break_fsm::should_stop): Rename from
13021         until_break_fsm_should_stop.
13022         (until_break_fsm::clean_up): Rename from
13023         until_break_fsm_clean_up.
13024         (until_break_fsm::do_async_reply_reason): Rename from
13025         until_break_fsm_async_reply_reason.
13026         (until_break_command): Update.
13027         * thread-fsm.c: Remove.
13028         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13029
13030 2019-02-07  Tom Tromey  <tom@tromey.com>
13031
13032         * yy-remap.h: Add include guard.
13033         * xtensa-tdep.h: Add include guard.
13034         * xcoffread.h: Rename include guard.
13035         * varobj-iter.h: Add include guard.
13036         * tui/tui.h: Rename include guard.
13037         * tui/tui-winsource.h: Rename include guard.
13038         * tui/tui-wingeneral.h: Rename include guard.
13039         * tui/tui-windata.h: Rename include guard.
13040         * tui/tui-win.h: Rename include guard.
13041         * tui/tui-stack.h: Rename include guard.
13042         * tui/tui-source.h: Rename include guard.
13043         * tui/tui-regs.h: Rename include guard.
13044         * tui/tui-out.h: Rename include guard.
13045         * tui/tui-layout.h: Rename include guard.
13046         * tui/tui-io.h: Rename include guard.
13047         * tui/tui-hooks.h: Rename include guard.
13048         * tui/tui-file.h: Rename include guard.
13049         * tui/tui-disasm.h: Rename include guard.
13050         * tui/tui-data.h: Rename include guard.
13051         * tui/tui-command.h: Rename include guard.
13052         * tic6x-tdep.h: Add include guard.
13053         * target/waitstatus.h: Rename include guard.
13054         * target/wait.h: Rename include guard.
13055         * target/target.h: Rename include guard.
13056         * target/resume.h: Rename include guard.
13057         * target-float.h: Rename include guard.
13058         * stabsread.h: Add include guard.
13059         * rs6000-tdep.h: Add include guard.
13060         * riscv-fbsd-tdep.h: Add include guard.
13061         * regformats/regdef.h: Rename include guard.
13062         * record.h: Rename include guard.
13063         * python/python.h: Rename include guard.
13064         * python/python-internal.h: Rename include guard.
13065         * python/py-stopevent.h: Rename include guard.
13066         * python/py-ref.h: Rename include guard.
13067         * python/py-record.h: Rename include guard.
13068         * python/py-record-full.h: Rename include guard.
13069         * python/py-record-btrace.h: Rename include guard.
13070         * python/py-instruction.h: Rename include guard.
13071         * python/py-events.h: Rename include guard.
13072         * python/py-event.h: Rename include guard.
13073         * procfs.h: Add include guard.
13074         * proc-utils.h: Add include guard.
13075         * p-lang.h: Add include guard.
13076         * or1k-tdep.h: Rename include guard.
13077         * observable.h: Rename include guard.
13078         * nto-tdep.h: Rename include guard.
13079         * nat/x86-linux.h: Rename include guard.
13080         * nat/x86-linux-dregs.h: Rename include guard.
13081         * nat/x86-gcc-cpuid.h: Add include guard.
13082         * nat/x86-dregs.h: Rename include guard.
13083         * nat/x86-cpuid.h: Rename include guard.
13084         * nat/ppc-linux.h: Rename include guard.
13085         * nat/mips-linux-watch.h: Rename include guard.
13086         * nat/linux-waitpid.h: Rename include guard.
13087         * nat/linux-ptrace.h: Rename include guard.
13088         * nat/linux-procfs.h: Rename include guard.
13089         * nat/linux-osdata.h: Rename include guard.
13090         * nat/linux-nat.h: Rename include guard.
13091         * nat/linux-namespaces.h: Rename include guard.
13092         * nat/linux-btrace.h: Rename include guard.
13093         * nat/glibc_thread_db.h: Rename include guard.
13094         * nat/gdb_thread_db.h: Rename include guard.
13095         * nat/gdb_ptrace.h: Rename include guard.
13096         * nat/fork-inferior.h: Rename include guard.
13097         * nat/amd64-linux-siginfo.h: Rename include guard.
13098         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13099         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13100         * nat/aarch64-linux.h: Rename include guard.
13101         * nat/aarch64-linux-hw-point.h: Rename include guard.
13102         * mn10300-tdep.h: Add include guard.
13103         * mips-linux-tdep.h: Add include guard.
13104         * mi/mi-parse.h: Rename include guard.
13105         * mi/mi-out.h: Rename include guard.
13106         * mi/mi-main.h: Rename include guard.
13107         * mi/mi-interp.h: Rename include guard.
13108         * mi/mi-getopt.h: Rename include guard.
13109         * mi/mi-console.h: Rename include guard.
13110         * mi/mi-common.h: Rename include guard.
13111         * mi/mi-cmds.h: Rename include guard.
13112         * mi/mi-cmd-break.h: Rename include guard.
13113         * m2-lang.h: Add include guard.
13114         * location.h: Rename include guard.
13115         * linux-record.h: Rename include guard.
13116         * linux-nat.h: Add include guard.
13117         * linux-fork.h: Add include guard.
13118         * i386-darwin-tdep.h: Rename include guard.
13119         * hppa-linux-offsets.h: Add include guard.
13120         * guile/guile.h: Rename include guard.
13121         * guile/guile-internal.h: Rename include guard.
13122         * gnu-nat.h: Rename include guard.
13123         * gdb-stabs.h: Rename include guard.
13124         * frv-tdep.h: Add include guard.
13125         * f-lang.h: Add include guard.
13126         * event-loop.h: Add include guard.
13127         * darwin-nat.h: Rename include guard.
13128         * cp-abi.h: Rename include guard.
13129         * config/sparc/nm-sol2.h: Rename include guard.
13130         * config/nm-nto.h: Rename include guard.
13131         * config/nm-linux.h: Add include guard.
13132         * config/i386/nm-i386gnu.h: Rename include guard.
13133         * config/djgpp/nl_types.h: Rename include guard.
13134         * config/djgpp/langinfo.h: Rename include guard.
13135         * compile/gcc-cp-plugin.h: Add include guard.
13136         * compile/gcc-c-plugin.h: Add include guard.
13137         * compile/compile.h: Rename include guard.
13138         * compile/compile-object-run.h: Rename include guard.
13139         * compile/compile-object-load.h: Rename include guard.
13140         * compile/compile-internal.h: Rename include guard.
13141         * compile/compile-cplus.h: Rename include guard.
13142         * compile/compile-c.h: Rename include guard.
13143         * common/xml-utils.h: Rename include guard.
13144         * common/x86-xstate.h: Rename include guard.
13145         * common/version.h: Rename include guard.
13146         * common/vec.h: Rename include guard.
13147         * common/tdesc.h: Rename include guard.
13148         * common/selftest.h: Rename include guard.
13149         * common/scoped_restore.h: Rename include guard.
13150         * common/scoped_mmap.h: Rename include guard.
13151         * common/scoped_fd.h: Rename include guard.
13152         * common/safe-iterator.h: Rename include guard.
13153         * common/run-time-clock.h: Rename include guard.
13154         * common/refcounted-object.h: Rename include guard.
13155         * common/queue.h: Rename include guard.
13156         * common/ptid.h: Rename include guard.
13157         * common/print-utils.h: Rename include guard.
13158         * common/preprocessor.h: Rename include guard.
13159         * common/pathstuff.h: Rename include guard.
13160         * common/observable.h: Rename include guard.
13161         * common/netstuff.h: Rename include guard.
13162         * common/job-control.h: Rename include guard.
13163         * common/host-defs.h: Rename include guard.
13164         * common/gdb_wait.h: Rename include guard.
13165         * common/gdb_vecs.h: Rename include guard.
13166         * common/gdb_unlinker.h: Rename include guard.
13167         * common/gdb_unique_ptr.h: Rename include guard.
13168         * common/gdb_tilde_expand.h: Rename include guard.
13169         * common/gdb_sys_time.h: Rename include guard.
13170         * common/gdb_string_view.h: Rename include guard.
13171         * common/gdb_splay_tree.h: Rename include guard.
13172         * common/gdb_setjmp.h: Rename include guard.
13173         * common/gdb_ref_ptr.h: Rename include guard.
13174         * common/gdb_optional.h: Rename include guard.
13175         * common/gdb_locale.h: Rename include guard.
13176         * common/gdb_assert.h: Rename include guard.
13177         * common/filtered-iterator.h: Rename include guard.
13178         * common/filestuff.h: Rename include guard.
13179         * common/fileio.h: Rename include guard.
13180         * common/environ.h: Rename include guard.
13181         * common/common-utils.h: Rename include guard.
13182         * common/common-types.h: Rename include guard.
13183         * common/common-regcache.h: Rename include guard.
13184         * common/common-inferior.h: Rename include guard.
13185         * common/common-gdbthread.h: Rename include guard.
13186         * common/common-exceptions.h: Rename include guard.
13187         * common/common-defs.h: Rename include guard.
13188         * common/common-debug.h: Rename include guard.
13189         * common/cleanups.h: Rename include guard.
13190         * common/buffer.h: Rename include guard.
13191         * common/btrace-common.h: Rename include guard.
13192         * common/break-common.h: Rename include guard.
13193         * cli/cli-utils.h: Rename include guard.
13194         * cli/cli-style.h: Rename include guard.
13195         * cli/cli-setshow.h: Rename include guard.
13196         * cli/cli-script.h: Rename include guard.
13197         * cli/cli-interp.h: Rename include guard.
13198         * cli/cli-decode.h: Rename include guard.
13199         * cli/cli-cmds.h: Rename include guard.
13200         * charset-list.h: Add include guard.
13201         * buildsym-legacy.h: Rename include guard.
13202         * bfin-tdep.h: Add include guard.
13203         * ax.h: Rename include guard.
13204         * arm-linux-tdep.h: Add include guard.
13205         * arm-fbsd-tdep.h: Add include guard.
13206         * arch/xtensa.h: Rename include guard.
13207         * arch/tic6x.h: Add include guard.
13208         * arch/i386.h: Add include guard.
13209         * arch/arm.h: Rename include guard.
13210         * arch/arm-linux.h: Rename include guard.
13211         * arch/arm-get-next-pcs.h: Rename include guard.
13212         * arch/amd64.h: Add include guard.
13213         * arch/aarch64-insn.h: Rename include guard.
13214         * arch-utils.h: Rename include guard.
13215         * annotate.h: Add include guard.
13216         * amd64-darwin-tdep.h: Rename include guard.
13217         * aarch64-linux-tdep.h: Add include guard.
13218         * aarch64-fbsd-tdep.h: Add include guard.
13219         * aarch32-linux-nat.h: Add include guard.
13220
13221 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13222
13223         * macrotab.c (macro_define_internal): New function that
13224         factorizes macro_define_object_internal and macro_define_function
13225         code.
13226         (macro_define_object_internal): Use macro_define_internal.
13227         (macro_define_function): Likewise.
13228
13229 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13230
13231         * macrocmd.c (extract_identifier): Return
13232         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13233         callers.
13234
13235 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13236
13237         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13238
13239 2019-02-05  Tom Tromey  <tom@tromey.com>
13240
13241         * target.c (target_stack::unpush): Move assertion earlier.
13242
13243 2019-01-30  Tom Tromey  <tom@tromey.com>
13244
13245         PR python/23615:
13246         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13247         (gdbpy_parse_and_eval): Likewise.
13248         * python/python-internal.h (gdbpy_allow_threads): New class.
13249
13250 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13251
13252         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13253         (aarch64_fbsd_fpregmap): Move earlier.
13254         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13255         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13256         instead of individual calls to trad_frame_set_reg_addr.
13257         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13258         earlier.
13259         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13260         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13261         instead of individual calls to trad_frame_set_reg_addr.
13262
13263 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13264
13265         * CONTRIBUTE: Replace contribution list with wiki link.
13266
13267 2019-01-25  Tom Tromey  <tom@tromey.com>
13268
13269         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13270
13271 2019-01-25  Tom Tromey  <tom@tromey.com>
13272
13273         * xtensa-linux-nat.c: Fix common/ includes.
13274         * xml-support.h: Fix common/ includes.
13275         * xml-support.c: Fix common/ includes.
13276         * x86-linux-nat.c: Fix common/ includes.
13277         * windows-nat.c: Fix common/ includes.
13278         * varobj.h: Fix common/ includes.
13279         * varobj.c: Fix common/ includes.
13280         * value.c: Fix common/ includes.
13281         * valops.c: Fix common/ includes.
13282         * utils.c: Fix common/ includes.
13283         * unittests/xml-utils-selftests.c: Fix common/ includes.
13284         * unittests/utils-selftests.c: Fix common/ includes.
13285         * unittests/unpack-selftests.c: Fix common/ includes.
13286         * unittests/tracepoint-selftests.c: Fix common/ includes.
13287         * unittests/style-selftests.c: Fix common/ includes.
13288         * unittests/string_view-selftests.c: Fix common/ includes.
13289         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13290         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13291         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13292         * unittests/rsp-low-selftests.c: Fix common/ includes.
13293         * unittests/parse-connection-spec-selftests.c: Fix common/
13294         includes.
13295         * unittests/optional-selftests.c: Fix common/ includes.
13296         * unittests/offset-type-selftests.c: Fix common/ includes.
13297         * unittests/observable-selftests.c: Fix common/ includes.
13298         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13299         * unittests/memrange-selftests.c: Fix common/ includes.
13300         * unittests/memory-map-selftests.c: Fix common/ includes.
13301         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13302         * unittests/function-view-selftests.c: Fix common/ includes.
13303         * unittests/environ-selftests.c: Fix common/ includes.
13304         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13305         * unittests/common-utils-selftests.c: Fix common/ includes.
13306         * unittests/cli-utils-selftests.c: Fix common/ includes.
13307         * unittests/array-view-selftests.c: Fix common/ includes.
13308         * ui-file.c: Fix common/ includes.
13309         * tui/tui-io.c: Fix common/ includes.
13310         * tracepoint.h: Fix common/ includes.
13311         * tracepoint.c: Fix common/ includes.
13312         * tracefile-tfile.c: Fix common/ includes.
13313         * top.h: Fix common/ includes.
13314         * top.c: Fix common/ includes.
13315         * thread.c: Fix common/ includes.
13316         * target/waitstatus.h: Fix common/ includes.
13317         * target/waitstatus.c: Fix common/ includes.
13318         * target.h: Fix common/ includes.
13319         * target.c: Fix common/ includes.
13320         * target-memory.c: Fix common/ includes.
13321         * target-descriptions.c: Fix common/ includes.
13322         * symtab.h: Fix common/ includes.
13323         * symfile.c: Fix common/ includes.
13324         * stap-probe.c: Fix common/ includes.
13325         * spu-linux-nat.c: Fix common/ includes.
13326         * sparc-nat.c: Fix common/ includes.
13327         * source.c: Fix common/ includes.
13328         * solib.c: Fix common/ includes.
13329         * solib-target.c: Fix common/ includes.
13330         * ser-unix.c: Fix common/ includes.
13331         * ser-tcp.c: Fix common/ includes.
13332         * ser-pipe.c: Fix common/ includes.
13333         * ser-base.c: Fix common/ includes.
13334         * selftest-arch.c: Fix common/ includes.
13335         * s12z-tdep.c: Fix common/ includes.
13336         * rust-exp.y: Fix common/ includes.
13337         * rs6000-aix-tdep.c: Fix common/ includes.
13338         * riscv-tdep.c: Fix common/ includes.
13339         * remote.c: Fix common/ includes.
13340         * remote-notif.h: Fix common/ includes.
13341         * remote-fileio.h: Fix common/ includes.
13342         * remote-fileio.c: Fix common/ includes.
13343         * regcache.h: Fix common/ includes.
13344         * regcache.c: Fix common/ includes.
13345         * record-btrace.c: Fix common/ includes.
13346         * python/python.c: Fix common/ includes.
13347         * python/py-type.c: Fix common/ includes.
13348         * python/py-inferior.c: Fix common/ includes.
13349         * progspace.h: Fix common/ includes.
13350         * producer.c: Fix common/ includes.
13351         * procfs.c: Fix common/ includes.
13352         * proc-api.c: Fix common/ includes.
13353         * printcmd.c: Fix common/ includes.
13354         * ppc-linux-nat.c: Fix common/ includes.
13355         * parser-defs.h: Fix common/ includes.
13356         * osdata.c: Fix common/ includes.
13357         * obsd-nat.c: Fix common/ includes.
13358         * nat/x86-linux.c: Fix common/ includes.
13359         * nat/x86-linux-dregs.c: Fix common/ includes.
13360         * nat/x86-dregs.h: Fix common/ includes.
13361         * nat/x86-dregs.c: Fix common/ includes.
13362         * nat/ppc-linux.c: Fix common/ includes.
13363         * nat/mips-linux-watch.h: Fix common/ includes.
13364         * nat/mips-linux-watch.c: Fix common/ includes.
13365         * nat/linux-waitpid.c: Fix common/ includes.
13366         * nat/linux-ptrace.h: Fix common/ includes.
13367         * nat/linux-ptrace.c: Fix common/ includes.
13368         * nat/linux-procfs.c: Fix common/ includes.
13369         * nat/linux-personality.c: Fix common/ includes.
13370         * nat/linux-osdata.c: Fix common/ includes.
13371         * nat/linux-namespaces.c: Fix common/ includes.
13372         * nat/linux-btrace.h: Fix common/ includes.
13373         * nat/linux-btrace.c: Fix common/ includes.
13374         * nat/fork-inferior.c: Fix common/ includes.
13375         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13376         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13377         * nat/aarch64-linux.c: Fix common/ includes.
13378         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13379         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13380         * namespace.h: Fix common/ includes.
13381         * mips-linux-tdep.c: Fix common/ includes.
13382         * minsyms.c: Fix common/ includes.
13383         * mi/mi-parse.h: Fix common/ includes.
13384         * mi/mi-main.c: Fix common/ includes.
13385         * mi/mi-cmd-env.c: Fix common/ includes.
13386         * memrange.h: Fix common/ includes.
13387         * memattr.c: Fix common/ includes.
13388         * maint.h: Fix common/ includes.
13389         * maint.c: Fix common/ includes.
13390         * main.c: Fix common/ includes.
13391         * machoread.c: Fix common/ includes.
13392         * location.c: Fix common/ includes.
13393         * linux-thread-db.c: Fix common/ includes.
13394         * linux-nat.c: Fix common/ includes.
13395         * linux-fork.c: Fix common/ includes.
13396         * inline-frame.c: Fix common/ includes.
13397         * infrun.c: Fix common/ includes.
13398         * inflow.c: Fix common/ includes.
13399         * inferior.h: Fix common/ includes.
13400         * inferior.c: Fix common/ includes.
13401         * infcmd.c: Fix common/ includes.
13402         * inf-ptrace.c: Fix common/ includes.
13403         * inf-child.c: Fix common/ includes.
13404         * ia64-linux-nat.c: Fix common/ includes.
13405         * i387-tdep.c: Fix common/ includes.
13406         * i386-tdep.c: Fix common/ includes.
13407         * i386-linux-tdep.c: Fix common/ includes.
13408         * i386-linux-nat.c: Fix common/ includes.
13409         * i386-go32-tdep.c: Fix common/ includes.
13410         * i386-fbsd-tdep.c: Fix common/ includes.
13411         * i386-fbsd-nat.c: Fix common/ includes.
13412         * guile/scm-type.c: Fix common/ includes.
13413         * guile/guile.c: Fix common/ includes.
13414         * go32-nat.c: Fix common/ includes.
13415         * gnu-nat.c: Fix common/ includes.
13416         * gdbthread.h: Fix common/ includes.
13417         * gdbarch-selftests.c: Fix common/ includes.
13418         * gdb_usleep.c: Fix common/ includes.
13419         * gdb_select.h: Fix common/ includes.
13420         * gdb_bfd.c: Fix common/ includes.
13421         * gcore.c: Fix common/ includes.
13422         * fork-child.c: Fix common/ includes.
13423         * findvar.c: Fix common/ includes.
13424         * fbsd-nat.c: Fix common/ includes.
13425         * event-top.c: Fix common/ includes.
13426         * event-loop.c: Fix common/ includes.
13427         * dwarf2read.c: Fix common/ includes.
13428         * dwarf2loc.c: Fix common/ includes.
13429         * dwarf2-frame.c: Fix common/ includes.
13430         * dwarf-index-cache.c: Fix common/ includes.
13431         * dtrace-probe.c: Fix common/ includes.
13432         * disasm-selftests.c: Fix common/ includes.
13433         * defs.h: Fix common/ includes.
13434         * csky-tdep.c: Fix common/ includes.
13435         * cp-valprint.c: Fix common/ includes.
13436         * cp-support.h: Fix common/ includes.
13437         * cp-support.c: Fix common/ includes.
13438         * corelow.c: Fix common/ includes.
13439         * completer.h: Fix common/ includes.
13440         * completer.c: Fix common/ includes.
13441         * compile/compile.c: Fix common/ includes.
13442         * compile/compile-loc2c.c: Fix common/ includes.
13443         * compile/compile-cplus-types.c: Fix common/ includes.
13444         * compile/compile-cplus-symbols.c: Fix common/ includes.
13445         * command.h: Fix common/ includes.
13446         * cli/cli-dump.c: Fix common/ includes.
13447         * cli/cli-cmds.c: Fix common/ includes.
13448         * charset.c: Fix common/ includes.
13449         * build-id.c: Fix common/ includes.
13450         * btrace.h: Fix common/ includes.
13451         * btrace.c: Fix common/ includes.
13452         * breakpoint.h: Fix common/ includes.
13453         * breakpoint.c: Fix common/ includes.
13454         * ax.h:
13455         (enum agent_op): Fix common/ includes.
13456         * ax-general.c (struct aop_map): Fix common/ includes.
13457         * ax-gdb.c: Fix common/ includes.
13458         * auxv.c: Fix common/ includes.
13459         * auto-load.c: Fix common/ includes.
13460         * arm-tdep.c: Fix common/ includes.
13461         * arch/riscv.c: Fix common/ includes.
13462         * arch/ppc-linux-common.c: Fix common/ includes.
13463         * arch/i386.c: Fix common/ includes.
13464         * arch/arm.c: Fix common/ includes.
13465         * arch/arm-linux.c: Fix common/ includes.
13466         * arch/arm-get-next-pcs.c: Fix common/ includes.
13467         * arch/amd64.c: Fix common/ includes.
13468         * arch/aarch64.c: Fix common/ includes.
13469         * arch/aarch64-insn.c: Fix common/ includes.
13470         * arch-utils.c: Fix common/ includes.
13471         * amd64-windows-tdep.c: Fix common/ includes.
13472         * amd64-tdep.c: Fix common/ includes.
13473         * amd64-sol2-tdep.c: Fix common/ includes.
13474         * amd64-obsd-tdep.c: Fix common/ includes.
13475         * amd64-nbsd-tdep.c: Fix common/ includes.
13476         * amd64-linux-tdep.c: Fix common/ includes.
13477         * amd64-linux-nat.c: Fix common/ includes.
13478         * amd64-fbsd-tdep.c: Fix common/ includes.
13479         * amd64-fbsd-nat.c: Fix common/ includes.
13480         * amd64-dicos-tdep.c: Fix common/ includes.
13481         * amd64-darwin-tdep.c: Fix common/ includes.
13482         * agent.c: Fix common/ includes.
13483         * ada-lang.h: Fix common/ includes.
13484         * ada-lang.c: Fix common/ includes.
13485         * aarch64-tdep.c: Fix common/ includes.
13486
13487 2019-01-25  Tom Tromey  <tom@tromey.com>
13488
13489         * common/create-version.sh: Use common/version.h.
13490
13491 2019-01-24  Pedro Alves  <palves@redhat.com>
13492
13493         * infrun.c (signal_stop, signal_print, signal_program)
13494         (signal_catch, signal_pass): Now arrays instead of pointers.
13495         (update_signals_program_target, do_target_resume)
13496         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13497         * linux-nat.c (linux_nat_target::pass_signals)
13498         (linux_nat_target::create_inferior, linux_nat_target::attach):
13499         Adjust.
13500         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13501         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13502         * procfs.c (procfs_target::pass_signals): Adjust.
13503         * record-full.c (record_full_target::resume): Adjust.
13504         * remote.c (remote_target::pass_signals)
13505         (remote_target::program_signals): Adjust.
13506         * target-debug.h (target_debug_print_signals): Now takes a
13507         gdb::array_view as parameter.  Adjust.
13508         * target.h (target_ops) <pass_signals, program_signals>: Replace
13509         pointer and length parameters with gdb::array_view.
13510         (target_pass_signals, target_program_signals): Likewise.
13511         * target-delegates.c: Regenerate.
13512
13513 2019-01-24  Pedro Alves  <palves@redhat.com>
13514
13515         * common/forward-scope-exit.h
13516         (forward_scope_exit::forward_scope_exit): Pass arguments to
13517         m_bind_function directly, instead of creating a std::bind and
13518         copying that.
13519
13520 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13521
13522         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13523         for static members.
13524         (pass_in_v_vfp_candidate): Likewise.
13525
13526 2019-01-23  Tom Tromey  <tom@tromey.com>
13527             Pedro Alves  <palves@redhat.com>
13528
13529         * regcache.c (class regcache_invalidator): Remove.
13530         (regcache::raw_write): Use make_scope_exit.
13531
13532 2019-01-23  Tom Tromey  <tom@tromey.com>
13533
13534         * ui-out.h (class ui_out_emit_type): Update comment.
13535
13536 2019-01-23  Tom Tromey  <tom@tromey.com>
13537
13538         * infrun.c (fetch_inferior_event): Update comment.
13539
13540 2019-01-23  Tom Tromey  <tom@tromey.com>
13541             Pedro Alves  <palves@redhat.com>
13542
13543         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13544         parameter.
13545         (fetch_inferior_event): Use SCOPE_EXIT.
13546
13547
13548 2019-01-23  Tom Tromey  <tom@tromey.com>
13549             Pedro Alves  <palves@redhat.com>
13550
13551         * infrun.c (disable_thread_events): Delete.
13552         (stop_all_threads): Use SCOPE_EXIT.
13553
13554 2019-01-23  Tom Tromey  <tom@tromey.com>
13555             Pedro Alves  <palves@redhat.com>
13556
13557         * symfile.c: Include forward-scope-exit.h.
13558         (clear_symtab_users_cleanup): Replace forward declaration with
13559         a FORWARD_SCOPE_EXIT.
13560         (syms_from_objfile_1): Use the forward_scope_exit and
13561         gdb::optional instead of cleanup_function.
13562         (reread_symbols): Use the forward_scope_exit instead of
13563         cleanup_function.
13564         (clear_symtab_users_cleanup): Remove function.
13565
13566 2019-01-23  Tom Tromey  <tom@tromey.com>
13567             Pedro Alves  <palves@redhat.com>
13568
13569         * linux-nat.c: Include scope-exit.h.
13570         (cleanup_target_stop): Remove.
13571         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13572         SCOPE_EXIT.
13573
13574 2019-01-23  Tom Tromey  <tom@tromey.com>
13575             Pedro Alves  <palves@redhat.com>
13576
13577         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13578         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13579
13580 2019-01-23  Tom Tromey  <tom@tromey.com>
13581             Andrew Burgess  <andrew.burgess@embecosm.com>
13582             Pedro Alves  <palves@redhat.com>
13583
13584         * infrun.c (fetch_inferior_event): Use scope_exit.
13585         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13586         * top.c (execute_command): Use scope_exit.
13587         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13588         * utils.c (do_bpstat_clear_actions_cleanup)
13589         (make_bpstat_clear_actions_cleanup): Remove.
13590
13591 2019-01-23  Tom Tromey  <tom@tromey.com>
13592             Pedro Alves  <palves@redhat.com>
13593
13594         * infrun.c: Include "common/scope-exit.h"
13595         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13596         (wait_for_inferior): Use SCOPE_EXIT.
13597         (fetch_inferior_event): Use scope_exit.
13598
13599 2019-01-23  Tom Tromey  <tom@tromey.com>
13600             Pedro Alves  <palves@redhat.com>
13601
13602         * breakpoint.c (create_breakpoint): Remove cleanup.
13603
13604 2019-01-23  Tom Tromey  <tom@tromey.com>
13605             Andrew Burgess  <andrew.burgess@embecosm.com>
13606             Pedro Alves  <palves@redhat.com>
13607
13608 2019-01-23  Pedro Alves  <palves@redhat.com>
13609
13610         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13611
13612 2019-01-23  Pedro Alves  <palves@redhat.com>
13613             Andrew Burgess  <andrew.burgess@embecosm.com>
13614
13615         * gdbthread.h: Include "common/forward-scope-exit.h".
13616         (scoped_finish_thread_state): Redefine custom class in terms of
13617         forward_scope_exit.
13618
13619 2019-01-23  Pedro Alves  <palves@redhat.com>
13620             Andrew Burgess  <andrew.burgess@embecosm.com>
13621
13622         * common/forward-scope-exit.h: New file.
13623
13624 2019-01-23  Pedro Alves  <palves@redhat.com>
13625             Andrew Burgess  <andrew.burgess@embecosm.com>
13626             Tom Tromey  <tom@tromey.com>
13627
13628         * common/scope-exit.h: New file.
13629
13630 2019-01-23  Pedro Alves  <palves@redhat.com>
13631
13632         * common/preprocessor.h (ESC): Rename to ...
13633         (ESC_PARENS): ... this.
13634         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13635         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13636
13637 2019-01-23  Tom Tromey  <tom@tromey.com>
13638
13639         * language.h (class scoped_switch_to_sym_language_if_auto):
13640         Initialize m_lang in both cases.
13641
13642 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13643
13644         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13645         with XCNEW.
13646
13647 2019-01-22  Tom Tromey  <tom@tromey.com>
13648
13649         * corelow.c: Do not include sys/file.h.
13650
13651 2019-01-22  Tom Tromey  <tom@tromey.com>
13652
13653         * tui/tui-wingeneral.h: Include gdb_curses.h.
13654
13655 2019-01-22  Tom Tromey  <tom@tromey.com>
13656
13657         * source-cache.h (class source_cache) <get_source_lines,
13658         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13659
13660 2019-01-22  Tom Tromey  <tom@tromey.com>
13661
13662         * remote-fileio.h (struct remote_target): Declare.
13663
13664 2019-01-22  Tom Tromey  <tom@tromey.com>
13665
13666         * python/py-arch.c: Do not include py-ref.h.
13667         * python/py-bpevent.c: Do not include py-ref.h.
13668         * python/py-cmd.c: Do not include py-ref.h.
13669         * python/py-continueevent.c: Do not include py-ref.h.
13670         * python/py-event.h: Do not include py-ref.h.
13671         * python/py-evtregistry.c: Do not include py-ref.h.
13672         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13673         * python/py-frame.c: Do not include py-ref.h.
13674         * python/py-framefilter.c: Do not include py-ref.h.
13675         * python/py-function.c: Do not include py-ref.h.
13676         * python/py-infevents.c: Do not include py-ref.h.
13677         * python/py-linetable.c: Do not include py-ref.h.
13678         * python/py-objfile.c: Do not include py-ref.h.
13679         * python/py-param.c: Do not include py-ref.h.
13680         * python/py-prettyprint.c: Do not include py-ref.h.
13681         * python/py-progspace.c: Do not include py-ref.h.
13682         * python/py-symbol.c: Do not include py-ref.h.
13683         * python/py-symtab.c: Do not include py-ref.h.
13684         * python/py-type.c: Do not include py-ref.h.
13685         * python/py-unwind.c: Do not include py-ref.h.
13686         * python/py-utils.c: Do not include py-ref.h.
13687         * python/py-value.c: Do not include py-ref.h.
13688         * python/py-varobj.c: Do not include py-ref.h.
13689         * python/py-xmethods.c: Do not include py-ref.h.
13690         * python/python.c: Do not include py-ref.h.
13691         * varobj.c: Do not include py-ref.h.
13692
13693 2019-01-22  Tom Tromey  <tom@tromey.com>
13694
13695         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13696         keyword for bcache.
13697
13698 2019-01-22  Tom Tromey  <tom@tromey.com>
13699
13700         * compile/compile-cplus-types.c: Remove a comment by #include.
13701
13702 2019-01-22  Tom Tromey  <tom@tromey.com>
13703
13704         * compile/gcc-c-plugin.h: Include compile-internal.h.
13705
13706 2019-01-22  Tom Tromey  <tom@tromey.com>
13707
13708         * stabsread.c (EXTERN): Do not define.
13709         (symnum, next_symbol_text_func, processing_gcc_compilation)
13710         (within_function, global_sym_chain, global_stabs)
13711         (previous_stab_code, this_object_header_files)
13712         (n_this_object_header_files)
13713         (n_allocated_this_object_header_files): Define.
13714         * stabsread.h (EXTERN): Never define.  Use "extern".
13715
13716 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13717
13718         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13719         history_value.
13720
13721 2019-01-21  Tom Tromey  <tom@tromey.com>
13722
13723         * ui-out.c: Fix includes.
13724         * tui/tui-source.c: Fix includes.
13725         * target.c: Fix includes.
13726         * remote.c: Fix includes.
13727         * regcache.c: Fix includes.
13728         * python/py-block.c: Fix includes.
13729         * printcmd.c: Fix includes.
13730         * or1k-tdep.c: Fix includes.
13731         * mi/mi-main.c: Fix includes.
13732         * m32r-tdep.c: Fix includes.
13733         * csky-tdep.c: Fix includes.
13734         * compile/compile-cplus-types.c: Fix includes.
13735         * cli/cli-interp.c: Fix includes.
13736
13737 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13738
13739         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13740         for padding.
13741
13742 2019-01-16  Tom Tromey  <tom@tromey.com>
13743
13744         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13745         earlier.
13746         (struct objfile) <msymbols_range>: Move from top level.
13747         <msymbols>: New method.
13748         (class objfile_msymbols): Remove.
13749         * symtab.c (default_collect_symbol_completion_matches_break_on):
13750         Update.
13751         * symmisc.c (dump_msymbols): Update.
13752         * stabsread.c (scan_file_globals): Update.
13753         * objc-lang.c (info_selectors_command, info_classes_command)
13754         (find_methods): Update.
13755         * minsyms.c (find_solib_trampoline_target): Update.
13756         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13757         * coffread.c (coff_symfile_read): Update.
13758         * ada-lang.c (ada_lookup_simple_minsym)
13759         (ada_collect_symbol_completion_matches): Update.
13760
13761 2019-01-16  Tom Tromey  <tom@tromey.com>
13762
13763         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13764         type.  Remove no-argument constructor.
13765         <iterator::operator++>: Simplify.
13766         <begin>: Update.
13767         <end>: Use minimal_symbol_count.
13768
13769 2019-01-16  Tom Tromey  <tom@tromey.com>
13770
13771         * objfiles.h (struct objfile) <psymtabs>: New method.
13772         (class objfile_psymtabs): Remove.
13773         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13774         typedef.
13775         <range>: New method.
13776         (require_partial_symbols): Change return type.
13777         * psymtab.c (require_partial_symbols)
13778         (psym_expand_symtabs_matching): Update.
13779         * mdebugread.c (parse_partial_symbols): Update.
13780         * dbxread.c (dbx_end_psymtab): Update.
13781
13782 2019-01-15  Tom Tromey  <tom@tromey.com>
13783
13784         * symtab.c (lookup_objfile_from_block)
13785         (lookup_symbol_in_objfile_symtabs)
13786         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13787         (find_line_symtab, info_sources_command)
13788         (default_collect_symbol_completion_matches_break_on)
13789         (make_source_files_completion_list): Update.
13790         * symmisc.c (print_objfile_statistics, dump_objfile)
13791         (maintenance_print_symbols, maintenance_info_symtabs)
13792         (maintenance_check_symtabs, maintenance_info_line_tables):
13793         Update.
13794         * source.c (select_source_symtab)
13795         (forget_cached_source_info_for_objfile): Update.
13796         * objfiles.h (class objfile_compunits): Remove.
13797         (struct objfile) <compunits_range>: New typedef.
13798         (compunits): New method.
13799         * objfiles.c (objfile_relocate1): Update.
13800         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13801         * maint.c (count_symtabs_and_blocks): Update.
13802         * linespec.c (iterate_over_all_matching_symtabs): Update.
13803         * cp-support.c (add_symbol_overload_list_qualified): Update.
13804         * coffread.c (coff_symtab_read): Update.
13805         * ada-lang.c (add_nonlocal_symbols)
13806         (ada_collect_symbol_completion_matches)
13807         (ada_add_global_exceptions): Update.
13808
13809 2019-01-15  Tom Tromey  <tom@tromey.com>
13810
13811         * progspace.h (program_space) <objfiles_safe_range>: New
13812         typedef.
13813         <objfiles_safe>: New method.
13814         * objfiles.h (class all_objfiles_safe): Remove.
13815         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13816         * jit.c (jit_inferior_exit_hook): Update.
13817
13818 2019-01-17  Tom Tromey  <tom@tromey.com>
13819
13820         * progspace.h (program_space) <objfiles_range>: New typedef.
13821         <objfiles>: New method.
13822         <objfiles_head>: Rename from objfiles.
13823         (object_files): Update.
13824         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13825         * guile/scm-pretty-print.c
13826         (ppscm_find_pretty_printer_from_objfiles): Update.
13827         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13828         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13829         Update.
13830         * python/py-progspace.c (pspy_get_objfiles): Update.
13831         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13832         Update.
13833         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13834         (objfpy_lookup_objfile_by_build_id): Update.
13835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13836         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13837         Update.
13838         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13839         (expand_symtab_containing_pc, lookup_objfile_from_block)
13840         (lookup_static_symbol, basic_lookup_transparent_type)
13841         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13842         (find_line_symtab, info_sources_command)
13843         (default_collect_symbol_completion_matches_break_on)
13844         (make_source_files_completion_list, find_main_name): Update.
13845         * symmisc.c (print_symbol_bcache_statistics)
13846         (print_objfile_statistics, maintenance_print_symbols)
13847         (maintenance_print_msymbols, maintenance_print_objfiles)
13848         (maintenance_info_symtabs, maintenance_check_symtabs)
13849         (maintenance_expand_symtabs, maintenance_info_line_tables):
13850         Update.
13851         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13852         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13853         (map_overlay_command, unmap_overlay_command)
13854         (simple_overlay_update, expand_symtabs_matching)
13855         (map_symbol_filenames): Update.
13856         * symfile-debug.c (set_debug_symfile): Update.
13857         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13858         Update.
13859         * source.c (select_source_symtab, forget_cached_source_info):
13860         Update.
13861         * solib.c (solib_read_symbols): Update.
13862         * solib-spu.c (append_ocl_sos): Update.
13863         * psymtab.c (maintenance_print_psymbols)
13864         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13865         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13866         * printcmd.c (info_symbol_command): Update.
13867         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13868         Update.
13869         * objfiles.h (class all_objfiles): Remove.
13870         * objfiles.c (have_partial_symbols, have_full_symbols)
13871         (have_minimal_symbols, qsort_cmp, update_section_map)
13872         (shared_objfile_contains_address_p)
13873         (default_iterate_over_objfiles_in_search_order): Update.
13874         * objc-lang.c (info_selectors_command, info_classes_command)
13875         (find_methods): Update.
13876         * minsyms.c (find_solib_trampoline_target): Update.
13877         * maint.c (maintenance_info_sections)
13878         (maintenance_translate_address, count_symtabs_and_blocks):
13879         Update.
13880         * main.c (captured_main_1): Update.
13881         * linux-thread-db.c (try_thread_db_load_from_pdir)
13882         (has_libpthread): Update.
13883         * linespec.c (iterate_over_all_matching_symtabs)
13884         (search_minsyms_for_name): Update.
13885         * jit.c (jit_find_objf_with_entry_addr): Update.
13886         * hppa-tdep.c (find_unwind_entry)
13887         (hppa_lookup_stub_minimal_symbol): Update.
13888         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13889         Update.
13890         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13891         (elf_gnu_ifunc_resolve_by_got): Update.
13892         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13893         * dwarf-index-write.c (save_gdb_index_command): Update.
13894         * cp-support.c (add_symbol_overload_list_qualified): Update.
13895         * breakpoint.c (create_overlay_event_breakpoint)
13896         (create_longjmp_master_breakpoint)
13897         (create_std_terminate_master_breakpoint)
13898         (create_exception_master_breakpoint): Update.
13899         * blockframe.c (find_pc_partial_function): Update.
13900         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13901         (ada_collect_symbol_completion_matches)
13902         (ada_add_global_exceptions): Update.
13903
13904 2019-01-17  Tom Tromey  <tom@tromey.com>
13905
13906         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13907         declare VEC.
13908         (solib_target_parse_libraries): Change return type.
13909         (library_list_start_segment, library_list_start_section)
13910         (library_list_end_library, library_list_start_library); Update.
13911         (solib_target_free_library_list): Remove.
13912         (solib_target_parse_libraries): Remove cleanup.  Change return
13913         type.
13914         (solib_target_current_sos): Update.
13915
13916 2019-01-17  Tom Tromey  <tromey@bapiya>
13917
13918         * valprint.c: Replace "the the" with "the".
13919         * symtab.c: Replace "the the" with "the".
13920         * solib.c: Replace "the the" with "the".
13921         * solib-dsbt.c: Replace "the the" with "the".
13922         * linespec.c: Replace "the the" with "the".
13923         * dwarf2loc.h: Replace "the the" with "the".
13924         * amd64-windows-tdep.c: Replace "the the" with "the".
13925         * aarch64-tdep.c: Replace "the the" with "the".
13926
13927 2019-01-16  Keith Seitz  <keiths@redhat.com>
13928
13929         PR gdb/23773
13930         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13931         <builder>: Rename to ..
13932         <m_builder>: ... this and make private.
13933         (dwarf2_cu::get_builder): New method.  Change all users of
13934         `builder' to use this method.
13935         (dwarf2_start_symtab): Move to ...
13936         (dwarf2_cu::start_symtab): ... here.  Update all callers
13937         (setup_type_unit_groups): Move to ...
13938         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13939         callers.
13940         (dwarf2_cu::reset_builder): New method.
13941         (process_full_compunit, process_full_type_unit): Use
13942         dwarf2_cu::reset_builder.
13943         (follow_die_offset): Record the ancestor CU if it is different
13944         from the followed DIE's CU.
13945         (follow_die_sig_1): Likewise.
13946
13947 2019-01-15  Tom Tromey  <tom@tromey.com>
13948
13949         * remote.c (class remote_state) <buf>: Now a char_vector.
13950         <buf_size>: Remove.
13951         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13952         parameter.
13953         (remote_target::getpkt_or_notif_sane_1)
13954         (remote_target::getpkt_sane)
13955         (remote_target::getpkt_or_notif_sane): Likewise.
13956         (class remote_target) <putpkt>: New overload.
13957         (remote_target::read_frame): Change type of "buf_p".  Remove
13958         sizeof_p parameter.
13959         (packet_ok): New overload.
13960         (packet_check_result): New overload.
13961         Update all uses.
13962
13963 2019-01-14  Tom Tromey  <tom@tromey.com>
13964
13965         * remote-notif.c (handle_notification, remote_notif_ack)
13966         (remote_notif_parse): Make "buf" const.
13967         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13968         const.
13969         (remote_notif_parse, remote_notif_ack, handle_notification):
13970         Likewise.
13971         * remote.c (remote_notif_stop_parse): Make "buf" const.
13972         (remote_target::remote_parse_stop_reply): Make "buf" const.
13973         (remote_notif_stop_ack): Make "buf" const.
13974
13975 2019-01-14  Tom Tromey  <tom@tromey.com>
13976
13977         * remote.c (remote_console_output): Make parameter const.
13978
13979 2019-01-14  Tom Tromey  <tom@tromey.com>
13980
13981         * target-debug.h (target_debug_print_signals): Constify.
13982         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13983         * procfs.c (procfs_target::pass_signals): Update.
13984         * linux-nat.c (linux_nat_target::pass_signals): Update.
13985         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13986         * target-delegates.c: Rebuild.
13987         * remote.c (remote_target::program_signals): Update.
13988         (remote_target::pass_signals): Update.
13989         * target.c (target_pass_signals): Constify argument.
13990         (target_program_signals): Likewise.
13991         * target.h (struct target_ops) <pass_signals, program_signals>:
13992         Constify argument.
13993         (target_pass_signals, target_program_signals): Constify argument.
13994
13995 2019-01-14  Tom Tromey  <tom@tromey.com>
13996
13997         PR tui/28819:
13998         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13999
14000 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14001
14002         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14003         field.
14004         * rs6000-tdep.c: Include reggroups.h.
14005         (IS_V_ALIAS_PSEUDOREG): Define.
14006         (rs6000_register_name): Return names for the "vX" aliases.
14007         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14008         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14009         aliases.  Call default_register_reggroup_p for all other
14010         pseudo-registers.
14011         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14012         New functions.
14013         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14014         Handle "vX" aliases.
14015         (v_alias_pseudo_register_collect): New function.
14016         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14017         (rs6000_gdbarch_init): Initialize "vX" aliases as
14018         pseudo-registers.  Restore registration of
14019         rs6000_pseudo_register_reggroup_p with
14020         set_tdesc_pseudo_register_reggroup_p.
14021
14022 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14023
14024         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14025         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14026         set_gdbarch_num_pseudo_regs.
14027
14028 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14029
14030         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14031         Remove arg prefixname, add do_set and do_show.
14032         Add member functions set_list and show_list.
14033         * cli/cli-style.c (class cli_style_option): Update accordingly.
14034         (style_set_list): Move to file scope.
14035         (style_show_list): Likewise.
14036         (set_style): Call help_list.
14037         (show_style): Call cmd_show_list.
14038         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14039         Update to use the new macro.
14040
14041 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14042
14043         * ada-lang.c (_initialize_ada_language): Expand the help text
14044         for the "catch exception" command.
14045
14046 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14047
14048         * symtab.c (matching_obj_sections): Initialize obj,
14049         declare it closer to its usage.
14050
14051 2019-01-10  Tom Tromey  <tom@tromey.com>
14052
14053         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14054         (basic_inf_threads_range): Remove.
14055         (inf_threads_range, inf_non_exited_threads_range)
14056         (safe_inf_threads_range): Use next_adapter.
14057
14058 2019-01-10  Keith Seitz  <keiths@redhat.com>
14059
14060         PR gdb/23712
14061         PR symtab/23010
14062         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14063         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14064
14065 2019-01-10  Keith Seitz  <keiths@redhat.com>
14066
14067         PR gdb/23712
14068         PR symtab/23010
14069         * dictionary.c (pending_to_vector): Remove.
14070         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14071         Remove _1 suffix, replacing functions of the same name.  Update
14072         all callers.
14073         (dict_create_hashed, dict_create_hashed_expandable)
14074         (dict_create_linear, dict_create_linear_expandable, dict_free)
14075         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14076         Make functions static.
14077
14078 2019-01-10  Keith Seitz  <keiths@redhat.com>
14079
14080         PR gdb/23712
14081         PR symtab/23010
14082         * dictionary.h (struct dictionary): Replace declaration with
14083         multidictionary.
14084         (dict_create_hashed, dict_create_hashed_expandable)
14085         (dict_create_linear, dict_create_linear_expandable)
14086         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14087         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14088         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14089         taking multidictionary argument.
14090         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14091         * block.h (struct block) <dict>: Change to multidictionary
14092         and rename `multidict'.
14093         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14094         symmisc.c: Update all dictionary references to multidictionary.
14095
14096 2019-01-10  Keith Seitz  <keiths@redhat.com>
14097
14098         PR gdb/23712
14099         PR symtab/23010
14100         * dictionary.c: Include unordered_map.
14101         (pending_to_vector): New function.
14102         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14103         Rewrite the non-"_1" functions to take vector instead
14104         of linked list.
14105         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14106         "new" _1 versions of the same name.
14107         (multidictionary): Define.
14108         (std::hash<enum language): New definition.
14109         (collate_pending_symbols_by_language, mdict_create_hashed)
14110         (mdict_create_hashed_expandable, mdict_create_linear)
14111         (mdict_create_linear_expandable, mdict_free)
14112         (find_language_dictionary, create_new_language_dictionary)
14113         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14114         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14115         (mdict_size, mdict_empty): New functions.
14116         * dictionary.h (mdict_iterator): Define.
14117
14118 2019-01-10  Pedro Alves  <palves@redhat.com>
14119
14120         * breakpoint.c (read_uploaded_action)
14121         (create_tracepoint_from_upload): Adjust to use
14122         gdb::unique_xmalloc_ptr.
14123         * ctf.c (ctf_write_uploaded_tp):
14124         (SET_ARRAY_FIELD): Use emplace_back.
14125         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14126         * tracefile-tfile.c (tfile_write_uploaded_tp):
14127         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14128         gdb::unique_xmalloc_ptr.
14129         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14130         at_string, cond_string, cmd_strings>: Replace char pointers
14131         with gdb::unique_xmalloc_ptr.
14132
14133 2019-01-10  Pedro Alves  <palves@redhat.com>
14134
14135         * solib-target.c (library_list_start_library): Don't xstrdup name.
14136
14137 2019-01-10  Pedro Alves  <palves@redhat.com>
14138
14139         * mdebugread.c (parse_partial_symbols): Use
14140         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14141
14142 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14143
14144         * linux-fork.c (scoped_switch_fork_info)
14145         <~scoped_switch_fork_info>: Fix incorrect variable name.
14146
14147 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14148
14149         * linux-fork.c (scoped_switch_fork_info)
14150         <scoped_switch_fork_info>: Make explicit.
14151         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14152
14153 2019-01-10  Tom Tromey  <tom@tromey.com>
14154
14155         * objfiles.h (objfile::reset_psymtabs): Update.
14156         * objfiles.c (objfile::objfile): Update.
14157         * psymtab.h (psymtab_storage::obstack): Update.
14158         (psymtab_storage::m_obstack): Use gdb::optional.
14159         (class psymtab_storage): Update comment.  Remove objfile
14160         parameter.
14161         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14162
14163 2019-01-10  Tom Tromey  <tom@tromey.com>
14164
14165         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14166         <free_psymtabs>: Now private.
14167         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14168         (allocate_psymtab): Use new method.
14169
14170 2019-01-10  Tom Tromey  <tom@tromey.com>
14171
14172         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14173         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14174         * mdebugread.c (parse_partial_symbols): Use
14175         allocate_dependencies.
14176         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14177         allocate_dependencies.
14178         (process_psymtab_comp_unit_reader)
14179         (build_type_psymtab_dependencies): Likewise.
14180         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14181
14182 2019-01-10  Tom Tromey  <tom@tromey.com>
14183
14184         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14185         PSYMBOL_SET_LANGUAGE.
14186         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14187
14188 2019-01-10  Tom Tromey  <tom@tromey.com>
14189
14190         * psymtab.h (psymtab_storage::obstack): New method.
14191         <m_obstack>: Rename from obstack; now private.
14192         * psymtab.c (psymtab_storage): Update.
14193         * dwarf2read.c (create_addrmap_from_index)
14194         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14195         Update.
14196
14197 2019-01-10  Tom Tromey  <tom@tromey.com>
14198
14199         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14200         * objfiles.h (objfile::reset_psymtabs): New method.
14201
14202 2019-01-10  Tom Tromey  <tom@tromey.com>
14203
14204         * symmisc.c (print_symbol_bcache_statistics): Update.
14205         (print_objfile_statistics): Update.
14206         * symfile.c (reread_symbols): Update.
14207         * psymtab.h (class psymtab_storage): New.
14208         * psymtab.c (psymtab_storage): New constructor.
14209         (~psymtab_storage): New destructor.
14210         (require_partial_symbols): Update.
14211         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14212         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14213         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14214         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14215         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14216         (start_psymtab_common, end_psymtab_common)
14217         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14218         (allocate_psymtab): Update.
14219         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14220         Update.
14221         (dump_psymtab_addrmap, maintenance_print_psymbols)
14222         (maintenance_check_psymtabs): Update.
14223         (class objfile_psymtabs): Move to objfiles.h.
14224         * psympriv.h (discard_psymtab): Now inline.
14225         (psymtab_discarder::psymtab_discarder): Update.
14226         (psymtab_discarder::~psymtab_discarder): Update.
14227         (ALL_OBJFILE_PSYMTABS): Rewrite.
14228         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14229         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14230         Remove fields.
14231         <partial_symtabs>: New field.
14232         (class objfile_psymtabs): Move from psymtab.h.  Update.
14233         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14234         psymbol_cache.
14235         (objfile::~objfile): Don't destroy psymbol_cache.
14236         * mdebugread.c (parse_partial_symbols): Update.
14237         * dwarf2read.c (create_addrmap_from_index)
14238         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14239         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14240         (add_partial_subprogram, dwarf2_ranges_read): Update.
14241         * dwarf-index-write.c (write_address_map)
14242         (write_one_signatured_type, recursively_write_psymbols)
14243         (class debug_names, class debug_names, write_psymtabs_to_index):
14244         Update.
14245
14246 2019-01-10  Tom Tromey  <tom@tromey.com>
14247
14248         * symtab.h (SYMBOL_SET_NAMES): Update.
14249         (symbol_set_names): Update.
14250         (MSYMBOL_SET_NAMES): Update.
14251         * symtab.c (symbol_set_names): Change argument to be an
14252         objfile_per_bfd_storage.
14253         * psymtab.c (add_psymbol_to_bcache): Update.
14254         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14255
14256 2019-01-10  Tom Tromey  <tom@tromey.com>
14257
14258         * symtab.c (create_demangled_names_hash): Change argument to be an
14259         objfile_per_bfd_storage.
14260         (symbol_set_names): Update.
14261
14262 2019-01-10  Tom Tromey  <tom@tromey.com>
14263
14264         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14265         init_psymbol_list.
14266         * psymtab.c (init_psymbol_list): Do nothing if already called.
14267         * psympriv.h (init_psymbol_list): Add comment.
14268         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14269         init_psymbol_list.
14270         * dbxread.c (dbx_symfile_read): Unconditionally call
14271         init_psymbol_list.
14272
14273 2019-01-10  Tom Tromey  <tom@tromey.com>
14274
14275         * xcoffread.c (scan_xcoff_symtab): Update.
14276         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14277         "where".
14278         * mdebugread.c (parse_partial_symbols)
14279         (handle_psymbol_enumerators): Update.
14280         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14281         * dbxread.c (read_dbx_symtab): Update.
14282         * psympriv.h (psymbol_placement): New enum.
14283         (add_psymbol_to_list): Update.
14284
14285 2019-01-10  Tom Tromey  <tom@tromey.com>
14286
14287         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14288         static_psymbols parameters.
14289         (scan_xcoff_symtab): Update.
14290         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14291         static_psymbols parameters.
14292         * psympriv.h (start_psymtab_common): Update.
14293         * mdebugread.c (parse_partial_symbols): Update.
14294         * dwarf2read.c (create_partial_symtab): Update.
14295         * dbxread.c (read_dbx_symtab): Update.
14296         (start_psymtab): Remove global_psymbols and static_psymbols
14297         parameters.
14298
14299 2019-01-10  Tom Tromey  <tom@tromey.com>
14300
14301         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14302         * psymtab.c (allocate_psymtab): Add comment.
14303         * psympriv.h (allocate_psymtab): Add comment.
14304         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14305         initializations.
14306         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14307
14308 2019-01-10  Tom Tromey  <tom@tromey.com>
14309
14310         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14311         Don't declare.
14312         * mipsread.c: Include mdebugread.h.
14313         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14314         Declare.
14315         * elfread.c: Include mdebugread.h.
14316
14317 2019-01-09  Tom Tromey  <tom@tromey.com>
14318
14319         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14320         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14321         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14322         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14323         (psym_lookup_symbol, psym_find_last_source_symtab)
14324         (psym_forget_cached_source_info, psym_print_stats)
14325         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14326         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14327         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14328         (psym_find_compunit_symtab_by_address)
14329         (maintenance_print_psymbols, maintenance_info_psymtabs)
14330         (maintenance_check_psymtabs): Use ranged for.
14331         * psymtab.h (class objfile_psymtabs): New.
14332         (require_partial_symbols): Return objfile_psymtabs.
14333         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14334
14335 2019-01-09  Tom Tromey  <tom@tromey.com>
14336
14337         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14338         (find_pc_mapped_section, list_overlays_command)
14339         (map_overlay_command, unmap_overlay_command)
14340         (simple_overlay_update): Use all_objfiles.
14341         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14342         * printcmd.c (info_symbol_command): Use all_objfiles.
14343         * objfiles.h (ALL_OBJSECTIONS): Remove.
14344         * maint.c (maintenance_translate_address): Use all_objfiles.
14345         * gcore.c (gcore_create_callback): Use all_objfiles.
14346         (objfile_find_memory_regions): Likewise.
14347
14348 2019-01-09  Tom Tromey  <tom@tromey.com>
14349
14350         * symtab.c (find_line_symtab, info_sources_command)
14351         (make_source_files_completion_list): Use objfile_compunits.
14352         * source.c (select_source_symtab): Use objfile_compunits.
14353         * objfiles.h (struct objfile): Update comment.
14354         (ALL_OBJFILES): Remove.
14355         (ALL_FILETABS): Remove.
14356         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14357         objfile_compunits.
14358
14359 2019-01-09  Tom Tromey  <tom@tromey.com>
14360
14361         * symmisc.c (print_objfile_statistics, dump_objfile)
14362         (maintenance_print_symbols): Use compunit_filetabs.
14363         * source.c (forget_cached_source_info_for_objfile): Use
14364         compunit_filetabs.
14365         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14366         (ALL_FILETABS): Use compunit_filetabs.
14367         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14368         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14369
14370 2019-01-09  Tom Tromey  <tom@tromey.com>
14371
14372         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14373         (compunit_filetabs): New.
14374         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14375         compunit_filetabs.
14376         (info_sources_command, make_source_files_completion_list): Remove
14377         declaration.
14378         * symmisc.c (print_objfile_statistics, dump_objfile)
14379         (maintenance_print_symbols): Remove declaration.
14380         (maintenance_info_symtabs): Use compunit_filetabs.
14381         (maintenance_info_line_tables): Likewise.
14382         * source.c (select_source_symtab): Change local variable name.
14383         (forget_cached_source_info_for_objfile): Remove declaration.
14384         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14385         * objfiles.c (objfile_relocate1): Remove declaration.
14386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14387         declaration.
14388         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14389         * coffread.c (coff_symtab_read): Remove declaration.
14390         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14391         compunit_filetabs.
14392
14393 2019-01-09  Tom Tromey  <tom@tromey.com>
14394
14395         * symtab.c (lookup_objfile_from_block)
14396         (find_pc_sect_compunit_symtab, search_symbols)
14397         (default_collect_symbol_completion_matches_break_on): Use
14398         objfile_compunits.
14399         * objfiles.h (ALL_COMPUNITS): Remove.
14400         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14401         * cp-support.c (add_symbol_overload_list_qualified): Use
14402         objfile_compunits.
14403         * ada-lang.c (ada_collect_symbol_completion_matches)
14404         (ada_add_global_exceptions): Use objfile_compunits.
14405
14406 2019-01-09  Tom Tromey  <tom@tromey.com>
14407
14408         * source.c (select_source_symtab)
14409         (forget_cached_source_info_for_objfile): Remove declaration.
14410         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14411         declaration.
14412         * maint.c (count_symtabs_and_blocks): Remove declaration.
14413         * cp-support.c (add_symbol_overload_list_qualified): Remove
14414         declaration.
14415         * coffread.c (coff_symtab_read): Remove declaration.
14416         * symtab.c (lookup_symbol_in_objfile_symtabs)
14417         (basic_lookup_transparent_type_1): Use objfile_compunits.
14418         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14419         (info_sources_command, search_symbols)
14420         (default_collect_symbol_completion_matches_break_on)
14421         (make_source_files_completion_list): Remove declaration.
14422         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14423         (ada_collect_symbol_completion_matches)
14424         (ada_add_global_exceptions): Remove declaration.
14425         * linespec.c (iterate_over_all_matching_symtabs): Use
14426         objfile_compunits.
14427         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14428         (class objfile_compunits): New.
14429         (ALL_COMPUNITS): Use objfile_compunits.
14430         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14431         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14432         objfile_compunits.
14433         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14434
14435 2019-01-09  Tom Tromey  <tom@tromey.com>
14436
14437         * symtab.c (search_symbols)
14438         (default_collect_symbol_completion_matches_break_on): Use
14439         objfile_msymbols.
14440         * ada-lang.c (ada_lookup_simple_minsym)
14441         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14442         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14443         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14444         objfile_msymbols.
14445         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14446         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14447         * objc-lang.c (find_methods): Use objfile_msymbols.
14448         (info_selectors_command, info_classes_command): Likewise.
14449         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14450         * objfiles.h (class objfile_msymbols): New.
14451         (ALL_OBJFILE_MSYMBOLS): Remove.
14452         (ALL_MSYMBOLS): Remove.
14453
14454 2019-01-09  Tom Tromey  <tom@tromey.com>
14455
14456         * common/next-iterator.h (next_adapter): Add Iterator template
14457         parameter.
14458         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14459         (class all_objfiles_safe): New.
14460         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14461         * objfiles.c (put_objfile_before): Update comment.
14462         (add_separate_debug_objfile): Likewise.
14463         (free_all_objfiles): Use all_objfiles_safe.
14464         (objfile_purge_solibs): Likewise.
14465
14466 2019-01-09  Tom Tromey  <tom@tromey.com>
14467
14468         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14469         (expand_symtab_containing_pc, lookup_static_symbol)
14470         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14471         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14472         all_objfiles.
14473         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14474         * breakpoint.c (create_overlay_event_breakpoint)
14475         (create_longjmp_master_breakpoint)
14476         (create_std_terminate_master_breakpoint)
14477         (create_exception_master_breakpoint): Use all_objfiles.
14478         * linux-thread-db.c (try_thread_db_load_from_pdir)
14479         (has_libpthread): Use all_objfiles.
14480         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14481         * linespec.c (iterate_over_all_matching_symtabs)
14482         (search_minsyms_for_name): Use all_objfiles.
14483         * maint.c (maintenance_info_sections): Use all_objfiles.
14484         * main.c (captured_main_1): Use all_objfiles.
14485         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14486         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14487         * guile/scm-pretty-print.c
14488         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14489         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14490         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14491         (maintenance_print_msymbols): Use all_objfiles.
14492         * source.c (select_source_symtab): Use all_objfiles.
14493         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14494         * symfile.c (remove_symbol_file_command)
14495         (expand_symtabs_matching, map_symbol_filenames): Use
14496         all_objfiles.
14497         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14498         all_objfiles.
14499         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14500         * objc-lang.c (find_methods): Use all_objfiles.
14501         * objfiles.c (have_partial_symbols, have_full_symbols)
14502         (have_minimal_symbols, qsort_cmp)
14503         (default_iterate_over_objfiles_in_search_order): Use
14504         all_objfiles.
14505         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14506         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14507         (maintenance_check_psymtabs): Use all_objfiles.
14508         (ALL_PSYMTABS): Remove.
14509         * compile/compile-object-run.c (do_module_cleanup): Use
14510         all_objfiles.
14511         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14512         * cp-support.c (add_symbol_overload_list_qualified): Use
14513         all_objfiles.
14514         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14515         Use all_objfiles.
14516         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14517         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14518         all_objfiles.
14519         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14520         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14521         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14522         Uses all_objfiles.
14523         * solib.c (solib_read_symbols): Use all_objfiles
14524
14525 2019-01-09  Tom Tromey  <tom@tromey.com>
14526
14527         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14528         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14529         all_objfiles.
14530         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14531         * symmisc.c (print_symbol_bcache_statistics)
14532         (print_objfile_statistics, maintenance_print_objfiles)
14533         (maintenance_info_symtabs, maintenance_check_symtabs)
14534         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14535         all_objfiles.
14536         * source.c (forget_cached_source_info): Use all_objfiles.
14537         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14538         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14539         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14540         * objfiles.c (update_section_map): Use all_objfiles.
14541         (shared_objfile_contains_address_p): Likewise.
14542         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14543         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14544
14545 2019-01-09  Tom Tromey  <tom@tromey.com>
14546
14547         * common/next-iterator.h: New file.
14548         * objfiles.h (class all_objfiles): New.
14549         (struct objfile_iterator): New.
14550
14551 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14552
14553         * NEWS: Move the description of the changed "frame", "select-frame",
14554          and "info frame" commands to the Changed commands section.
14555
14556 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14557
14558         * gdbtypes.c (check_stub_method_group): Remove handling of old
14559         mangling schemes.
14560         * linespec.c (find_methods): Likewise.
14561         * stabsread.c (read_member_functions): Likewise.
14562         * valops.c (search_struct_method): Likewise.
14563         (value_struct_elt_for_reference): Likewise.
14564         * NEWS: Mention this change.
14565
14566 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14567
14568         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14569         print_source_lines.
14570         * source.c (print_source_lines_base): Update line number check.
14571         (print_source_lines): New function.
14572         (source_lines_range::source_lines_range): New function.
14573         * source.h (class source_lines_range): New class.
14574         (print_source_lines): New declaration.
14575
14576 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14577
14578         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14579
14580 2019-01-08  Tom Tromey  <tom@tromey.com>
14581             Simon Marchi  <simon.marchi@ericsson.com>
14582
14583         PR gdb/24060
14584         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14585         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14586         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14587         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14588         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14589         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14590
14591 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14592
14593         * source.c (select_source_symtab): Move header comment to
14594         declaration in source.h.
14595         (forget_cached_source_info_for_objfile): Likewise.
14596         (forget_cached_source_info): Likewise.
14597         (identify_source_line): Likewise.
14598         * source.h (identify_source_line): Move declaration from symtab.h
14599         and add comment from source.c
14600         (print_source_lines): Likewise.
14601         (forget_cached_source_info_for_objfile): Likewise.
14602         (forget_cached_source_info): Likewise.
14603         (select_source_symtab): Likewise.
14604         (enum print_source_lines_flag): Move definition from symtab.h.
14605         * symtab.h (identify_source_line): Move declaration to source.h.
14606         (print_source_lines): Likewise.
14607         (forget_cached_source_info_for_objfile): Likewise.
14608         (forget_cached_source_info): Likewise.
14609         (select_source_symtab): Likewise.
14610         (enum print_source_lines_flag): Move definition to source.h.
14611         * tui/tui-hooks.c: Add 'source.h' include.
14612
14613 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14614
14615         * source.c (print_source_lines_base): Handle requests to print
14616         reverse line number sequences, and guard against empty lines
14617         string.
14618
14619 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14620
14621         * source.c (print_source_lines_base): Fix skip of '\r' if next
14622         character is '\n'.
14623
14624 2019-01-06  Tom Tromey  <tom@tromey.com>
14625
14626         * c-exp.y (struct c_parse_state) <macro_original_text,
14627         expansion_obstack>: New member.
14628         (macro_original_text, expansion_obstack): Remove globals.
14629         (scan_macro_expansion, scanning_macro_expansion)
14630         (finished_macro_expansion): Update.
14631         (scan_macro_cleanup): Remove.
14632         (yylex, c_parse): Update.
14633
14634 2019-01-06  Tom Tromey  <tom@tromey.com>
14635
14636         * c-exp.y (struct c_parse_state) <strings>: New member.
14637         (operator_stoken): Update.
14638
14639 2019-01-06  Tom Tromey  <tom@tromey.com>
14640
14641         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14642         (union type_stack_elt) <typelist_val>: Now a pointer to
14643         std::vector.
14644         (type_stack_cleanup): Don't declare.
14645         (push_typelist): Update.
14646         * parse.c (pop_typelist): Return a std::vector.
14647         (push_typelist): Take a std::vector.
14648         (follow_types): Update.  Do not free args.
14649         (type_stack_cleanup): Remove.
14650         * c-exp.y (struct c_parse_state): New.
14651         (cpstate): New global.
14652         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14653         (nonempty_typelist): Update.
14654         (func_mod): Create a new vector.
14655         (c_parse): Create a c_parse_state.
14656         (check_parameter_typelist): Do not delete params.
14657         (function_method): Update.  Do not delete type_list.
14658
14659 2019-01-06  Tom Tromey  <tom@tromey.com>
14660
14661         PR gdb/28155:
14662         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14663         check_typedef.
14664         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14665         (print_return_value): Likewise.
14666
14667 2019-01-05  Tom Tromey  <tom@tromey.com>
14668
14669         * contrib/cleanup_check.py: Remove.
14670         * contrib/gcc-with-excheck: Remove.
14671         * contrib/exsummary.py: Remove.
14672         * contrib/excheck.py: Remove.
14673
14674 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14675
14676         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14677         NULL. Initialize tpprev to NULL instead of assigning it
14678         to NULL on the next statement.
14679         * windows-nat.c (windows_delete_thread): Remove check for
14680         main_thread_id before printing thread exit notifications.
14681         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14682         Remove thread ID check against main_thread_id.
14683         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14684         windows_delete_thread.
14685         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14686
14687 2019-01-04  Tom Tromey  <tom@tromey.com>
14688
14689         * compile/compile.c (_initialize_compile): Use upper case for
14690         metasyntactic variables.
14691         * symmisc.c (_initialize_symmisc): Use upper case for
14692         metasyntactic variables.
14693         * psymtab.c (_initialize_psymtab): Use upper case for
14694         metasyntactic variables.
14695         * demangle.c (demangle_command): Use upper case for metasyntactic
14696         variables.
14697         (_initialize_demangler): Likewise.
14698         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14699         variables.
14700
14701 2019-01-03  Tom Tromey  <tom@tromey.com>
14702
14703         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14704
14705 2019-01-03  Tom Tromey  <tom@tromey.com>
14706
14707         * python/py-symtab.c (salpy_str): Update.
14708         (struct salpy_sal_object) <symtab>: Now a PyObject.
14709         (salpy_dealloc): Update.
14710         (del_objfile_sal): Use gdbpy_ref.
14711
14712 2019-01-03  Tom Tromey  <tom@tromey.com>
14713
14714         * python/py-type.c (convert_field): Use new_reference.  Return
14715         gdbpy_ref.
14716         (make_fielditem): Return gdbpy_ref.
14717         (typy_fields): Update.
14718         (typy_getitem): Update.
14719         (field_name): Return gdbpy_ref.  Use new_reference.
14720         (typy_iterator_iternext): Update.
14721
14722 2019-01-03  Tom Tromey  <tom@tromey.com>
14723
14724         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14725
14726 2019-01-03  Tom Tromey  <tom@tromey.com>
14727
14728         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14729         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14730         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14731         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14732         (pspy_set_type_printers): Likewise.
14733         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14734         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14735         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14736         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14737         (objfpy_set_type_printers): Likewise.
14738
14739 2019-01-03  Tom Tromey  <tom@tromey.com>
14740
14741         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14742         (gdbpy_print_stack): Use gdbpy_err_fetch.
14743         * python/python-internal.h (class gdbpy_err_fetch): New class.
14744         (class gdbpy_enter) <m_error_type, m_error_value,
14745         m_error_traceback>: Remove.
14746         <m_error>: New member.
14747         (gdbpy_exception_to_string): Don't declare.
14748         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14749         * python/py-value.c (convert_value_from_python): Use
14750         gdbpy_err_fetch.
14751         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14752         gdbpy_exception_to_string.
14753         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14754         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14755         gdbpy_err_fetch.
14756
14757 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14758
14759         * linux-nat.c (delete_lwp_cleanup): Delete.
14760         (struct lwp_deleter): New struct.
14761         (lwp_info_up): New typedef.
14762         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14763         lwp_info_up.
14764
14765 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14766
14767         * linux-fork.c (class scoped_switch_fork_info): New class.
14768         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14769
14770 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14771
14772         * valops.c (find_overload_match): Remove use of null_cleanup, and
14773         calls to do_cleanups.
14774
14775 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14776
14777         * compile/compile-cplus-types.c
14778         (compile_cplus_instance::decl_name): Handle changes to
14779         cp_func_name.
14780         * cp-support.c (cp_func_name): Update header comment, update
14781         return type.
14782         * cp-support.h (cp_func_name): Update return type in declaration.
14783         * valops.c (find_overload_match): Move temp_func local to top
14784         level of function and change its type.  Use temp_func to hold and
14785         delete temporary string obtained from cp_func_name.
14786
14787 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14788
14789         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14790         gdb::char_vector, remove cleanup, and update uses of `msg`.
14791
14792 2019-01-03  Jim Wilson  <jimw@sifive.com>
14793
14794         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14795
14796 2019-01-02  Tom Tromey  <tom@tromey.com>
14797
14798         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14799         (tdesc_parse_xml): Remove cleanups.
14800         * target-descriptions.h (make_cleanup_free_target_description):
14801         Don't declare.
14802         (target_desc_deleter): New struct.
14803         (target_desc_up): New typedef.
14804         * target-descriptions.c (target_desc_deleter::operator()): Rename
14805         from free_target_description.
14806         (make_cleanup_free_target_description): Remove.
14807
14808 2019-01-02  Tom Tromey  <tom@tromey.com>
14809
14810         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14811         constructor, destructor.
14812         (linespec_parser): Remove typedef.
14813         (~linespec_parser): Rename from linespec_parser_delete.
14814         (linespec_lex_to_end, linespec_complete_label)
14815         (linespec_complete): Update.
14816         (decode_line_full): Remove cleanups.
14817         (decode_line_1): Update.
14818
14819 2019-01-02  Tom Tromey  <tom@tromey.com>
14820
14821         * python/python-internal.h (inferior_to_inferior_object): Change
14822         return type.
14823         * python/py-exitedevent.c (create_exited_event_object): Update.
14824         * python/py-inferior.c (inferior_to_inferior_object): Return
14825         gdbpy_ref.
14826         (python_new_inferior, python_inferior_deleted)
14827         (thread_to_thread_object, delete_thread_object)
14828         (build_inferior_list, gdbpy_selected_inferior): Update.
14829         * python/py-infthread.c (create_thread_object): Update.  Also fail
14830         if inferior_to_inferior_object fails.
14831
14832 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14833
14834         * inferior.h (class inferior) <displaced_step_state>: New field.
14835         * infrun.h (struct displaced_step_state): Move here from
14836         infrun.c.  Initialize fields, add constructor.
14837         <inf>: Remove field.
14838         <reset>: New method.
14839         * infrun.c (struct displaced_step_inferior_state): Move to
14840         infrun.h.
14841         (displaced_step_inferior_states): Remove.
14842         (get_displaced_stepping_state): Adust.
14843         (displaced_step_in_progress_any_inferior): Adjust.
14844         (displaced_step_in_progress_thread): Adjust.
14845         (displaced_step_in_progress): Adjust.
14846         (add_displaced_stepping_state): Remove.
14847         (get_displaced_step_closure_by_addr): Adjust.
14848         (remove_displaced_stepping_state): Remove.
14849         (infrun_inferior_exit): Call displaced_step_state.reset.
14850         (use_displaced_stepping): Don't check for NULL.
14851         (displaced_step_prepare_throw): Call
14852         get_displaced_stepping_state.
14853         (displaced_step_fixup): Don't check for NULL.
14854         (prepare_for_detach): Don't check for NULL.
14855
14856 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14857
14858         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14859          in case of call that did not complete.
14860
14861 2019-01-02  Andrey Utkin  <autkin@undo.io>
14862
14863         * symfile.c (find_separate_debug_file): Fix search of debug files for
14864         remote debuggee.
14865
14866 2019-01-02  Tom Tromey  <tom@tromey.com>
14867
14868         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14869         indentation.
14870         * python/py-frame.c (frapy_older): Remove cast.
14871         (frapy_newer): Likewise.
14872         * python/py-breakpoint.c (local_setattro): Remove cast.
14873         * python/py-arch.c (archpy_name): Remove local variable.
14874         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14875
14876 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14877
14878         * unittests/basic_string_view/element_access/char/empty.cc:
14879         Fix year range in copyright header.
14880
14881 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14882
14883         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14884         Delete.
14885         <operator==>: Update with for removed field.
14886         <hash>: Likewise.
14887         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14888         <isa_features>: ...this.
14889         <abi_features>: New field.
14890         (riscv_isa_flen): Update comment.
14891         (riscv_abi_xlen): New declaration.
14892         (riscv_abi_flen): New declaration.
14893         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14894         isa_features.
14895         (riscv_abi_xlen): New function.
14896         (riscv_isa_flen): Update to get answer from isa_features.
14897         (riscv_abi_flen): New function.
14898         (riscv_has_fp_abi): Update to get answer from abi_features.
14899         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14900         xlen and flen.
14901         (riscv_call_info) <xlen, flen>: Update comment.
14902         (riscv_call_arg_struct): Remove invalid assertions
14903         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14904         is removed.
14905         (riscv_gdbarch_init): Gather isa features and abi features
14906         separately, ensure both match on the gdbarch when reusing an old
14907         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14908         a target with 64-bit float hardware.
14909
14910 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14911
14912         * source.c (search_command_helper): Stop reverse search
14913         when line 1 has been searched.
14914
14915 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14916
14917         * record-full.c (record_full_base_target::close): Rewrite
14918         record_full_core_buf_list free logic.
14919
14920 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14921
14922         * break-catch-syscall.c (print_one_catch_syscall): xfree
14923         the last text.
14924
14925 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14926
14927         * top.c (print_gdb_version): Update Copyright year in version
14928         message.
14929
14930 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14931
14932         Update copyright year range in all GDB files.
14933
14934 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14935
14936         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14937
14938 For older changes see ChangeLog-2018.
14939 \f
14940 Local Variables:
14941 mode: change-log
14942 left-margin: 8
14943 fill-column: 74
14944 version-control: never
14945 coding: utf-8
14946 End:
14947