gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
   4         (struct tui_data_item_window): Update.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
   9         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  10         defines.
  11
  12 2019-07-17  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-winsource.h (tui_erase_source_content)
  15         (tui_clear_source_content): Remove "display_prompt" parameter.
  16         * tui/tui-winsource.c (tui_update_source_window_as_is)
  17         (tui_update_source_windows_with_addr): Update.
  18         (tui_clear_source_content): Remove "display_prompt" parameter.
  19         (tui_erase_source_content): Likewise.  Simplify.
  20         (tui_show_source_content): Update.
  21         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  22         * tui/tui-stack.c (tui_show_frame_info): Update.
  23         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  24         Remove defines.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  29         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  30         parameter.
  31         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  32         parameter.
  33
  34 2019-07-17  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-winsource.c (tui_clear_source_content)
  37         (tui_show_source_content, tui_show_exec_info_content)
  38         (tui_clear_exec_info_content): Update.
  39         * tui/tui-stack.c (tui_show_locator_content): Update.
  40         (tui_show_frame_info): Update.
  41         * tui/tui-source.h (tui_source_window): Don't declare.
  42         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  43         from tui_source_is_displayed.
  44         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  45         Remove field.
  46         (struct tui_source_window_base) <content_in_use>: New field.  Now
  47         bool.
  48         (struct tui_source_window) <showing_source_p>: New method.
  49         (TUI_SRC_WIN): Change cast.
  50         * tui/tui-data.c (tui_initialize_static_data): Update.
  51
  52 2019-07-17  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  55         location_matches_p.
  56         * tui/tui-source.c (tui_source_window::location_matches_p): New
  57         method.
  58         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  59         method.
  60         * tui/tui-data.h (struct tui_source_window_base)
  61         <location_matches_p>: New method.
  62         (struct tui_source_window, struct tui_disasm_window)
  63         <location_matches_p>: Likewise.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-win.c (tui_set_win_height_command): Rename from
  68         tui_set_win_height.
  69         (tui_set_win_height_command): Remove.
  70
  71 2019-07-17  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-source.c (tui_source_window): New constructor.  Add
  74         observer.
  75         (~tui_source_window): New destructor.
  76         (tui_source_window::style_changed): New method.
  77         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  78         (tui_attach_detach_observers): Update.
  79         * tui/tui-data.h (struct tui_source_window): Make constructor not
  80         inline.  Add destructor.
  81         (struct tui_source_window) <style_changed>: New method.
  82         <m_observable>: New member.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
  87         * tui/tui-win.c (tui_resize_all): Fix typo.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-wingeneral.h (tui_refresh_all): Update.
  92         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
  93         (tui_refresh_all): Remove "list" parameter.  Use foreach.
  94         * tui/tui-win.c (window_name_completer): Use foreach.
  95         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
  96         (update_tab_width): Likewise.
  97         * tui/tui-layout.c (show_layout): Update.
  98         * tui/tui-data.h (class tui_window_iterator): New.
  99         (struct all_tui_windows): New.
 100         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 101
 102 2019-07-17  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 105         parameter.  Don't reference globals.
 106         (tui_reg_command): Update.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-regs.c (tui_show_registers): Simplify.
 111
 112 2019-07-17  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-regs.c (tui_show_registers): Update.
 115         (tui_show_register_group): Add win_info parameter.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 120         Rename from tui_display_reg_element_at_line.
 121         (tui_data_window::display_registers_from_line): Update.
 122         * tui/tui-data.h (struct tui_data_window)
 123         <display_reg_element_at_line>: New method.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-regs.h (tui_display_registers_from)
 128         (tui_display_registers_from_line): Don't declare.
 129         * tui/tui-windata.c (tui_data_window::display_all_data)
 130         (tui_data_window::refresh_all)
 131         (tui_data_window::do_scroll_vertical): Update.
 132         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 133         from tui_display_registers_from.
 134         (tui_display_reg_element_at_line): Update.
 135         (tui_data_window::display_registers_from_line): Rename from
 136         tui_display_registers_from_line.
 137         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 138         display_registers_from_line>: New methods.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 143         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 144         from tui_erase_data_content.
 145         (tui_data_window::display_all_data)
 146         (tui_data_window::refresh_all)
 147         (tui_data_window::do_scroll_vertical): Update.
 148         * tui/tui-regs.c (tui_show_registers): Update.
 149         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 150         New method.
 151
 152 2019-07-17  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 155         declare.
 156         * tui/tui-windata.c
 157         (tui_data_window::delete_data_content_windows): Rename from
 158         tui_delete_data_content_windows.
 159         (tui_data_window::display_all_data)
 160         (tui_data_window::do_scroll_vertical): Update.
 161         * tui/tui-data.h (struct tui_data_window)
 162         <delete_data_content_windows>: New method.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 167         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 168
 169 2019-07-17  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 172         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 173         from tui_display_all_data.
 174         * tui/tui-win.c
 175         (tui_data_window::do_make_visible_with_new_height): Update.
 176         * tui/tui-regs.c (tui_show_registers): Update.
 177         * tui/tui-layout.c (tui_set_layout): Update.
 178         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 179         method.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 184         * tui/tui-windata.c (tui_display_data_from): Remove.
 185         (tui_data_window::refresh_all): Update.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 190         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 191         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 192         tui_display_registers_from_line.
 193         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 194         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 195         "force_display" parameter.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 200         declare.
 201         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 202         Rename from tui_first_reg_element_no_inline.
 203         (tui_display_reg_element_at_line)
 204         (tui_display_registers_from_line): Update.
 205         * tui/tui-data.h (struct tui_data_window)
 206         <first_reg_element_no_inline>: New method.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-windata.c (tui_display_data_from)
 211         (tui_data_window::do_scroll_vertical): Update.
 212         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 213         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 214         Rename from tui_line_from_reg_element_no.
 215         (tui_display_registers_from_line): Update.
 216         * tui/tui-data.h (struct tui_data_window)
 217         <line_from_reg_element_no>: New method.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 222         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 223         tui_last_regs_line_no.
 224         (tui_display_reg_element_at_line)
 225         (tui_display_registers_from_line): Update.
 226         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 227         method.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         PR tui/24722:
 232         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 233         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 234         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 235         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 236         (tui_update_breakpoint_info): Likewise.
 237         * tui/tui-hooks.c (tui_event_create_breakpoint)
 238         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 239         Update.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.c (tui_update_source_window_as_is)
 248         (tui_update_source_windows_with_addr): Update.
 249         * tui/tui-source.h (tui_set_source_content)
 250         (tui_show_symtab_source): Add "win_info" parameter.
 251         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 252         parameter.
 253         (tui_show_symtab_source): Likewise.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-wingeneral.c
 258         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 263         (struct tui_cmd_window) <can_scroll>: New method.
 264         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 265         method.
 266
 267 2019-07-17  Tom Tromey  <tromey@adacore.com>
 268
 269         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 270         do_field_signed>: Rename.  Change type of "value".
 271         * ui-out.c (ui_out::field_signed): Rename from field_int.
 272         Change type of "value".
 273         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 274         type of "value".
 275         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 276         do_field_int.  Change type of "value".
 277         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 278         do_field_int.  Change type of "value".
 279         * tracepoint.c (trace_status_mi, tfind_1)
 280         (print_one_static_tracepoint_marker): Update.
 281         * thread.c (print_thread_info_1, print_selected_thread_frame):
 282         Update.
 283         * stack.c (print_frame, print_frame_info): Update.
 284         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 285         Update.
 286         * source.c (print_source_lines_base): Update.
 287         * skip.c (info_skip_command): Update.
 288         * record-btrace.c (btrace_ui_out_decode_error)
 289         (btrace_call_history_src_line): Update.
 290         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 291         Update.
 292         * progspace.c (print_program_space): Update.
 293         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 294         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 295         do_field_int.  Change type of "value".
 296         * mi/mi-out.c (mi_ui_out::do_table_begin)
 297         (mi_ui_out::do_table_header): Update.
 298         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 299         type of "value".
 300         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 301         (mi_cmd_data_list_changed_registers, output_register)
 302         (mi_cmd_data_read_memory, mi_load_progress)
 303         (mi_cmd_trace_frame_collected): Update.
 304         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 305         Update.
 306         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 307         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 308         (mi_cmd_var_list_children, varobj_update_one): Update.
 309         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 310         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 312         * inferior.c (print_inferior): Update.
 313         * gdb_bfd.c (print_one_bfd): Update.
 314         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 315         Update.
 316         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 317         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 318         do_field_int.  Change type of "value".
 319         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 320         do_field_int.  Change type of "value".
 321         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 322         (print_one_breakpoint_location, print_it_catch_fork)
 323         (print_one_catch_fork, print_it_catch_vfork)
 324         (print_one_catch_vfork, print_it_catch_solib)
 325         (print_it_catch_exec, print_it_ranged_breakpoint)
 326         (print_mention_watchpoint, print_mention_masked_watchpoint)
 327         (bkpt_print_it, update_static_tracepoint): Update.
 328         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 329         * break-catch-syscall.c (print_it_catch_syscall): Update.
 330         * ada-tasks.c (print_ada_task_info): Update.
 331         * ada-lang.c (print_it_exception, print_mention_exception):
 332         Update.
 333
 334 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         PR breakpoints/24541
 337         * gdbarch.c: Regenerate.
 338         * gdbarch.h: Regenerate.
 339         * gdbarch.sh: Adjust return type and parameter types for
 340         'stap_adjust_register'.
 341         (i386_stap_adjust_register): Adjust signature and return new
 342         register name.
 343         * stap-probe.c (stap_parse_register_operand): Adjust use of
 344         'gdbarch_stap_adjust_register'.
 345
 346 2019-07-17  Tom Tromey  <tromey@adacore.com>
 347
 348         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 349         declare VEC.
 350         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 351         std::vector.
 352         (struct s390_process_info): Add initializers.
 353         (s390_add_process): Use new.
 354         (s390_linux_nat_target::low_forget_process): Use delete.
 355         (s390_linux_nat_target::low_new_fork)
 356         (s390_linux_nat_target::stopped_by_watchpoint)
 357         (s390_linux_nat_target::low_prepare_to_resume)
 358         (s390_linux_nat_target::insert_watchpoint)
 359         (s390_linux_nat_target::insert_hw_breakpoint)
 360         (s390_linux_nat_target::remove_watchpoint)
 361         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 362
 363 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 364
 365         * aarch64-fbsd-nat.c: Include regcache.h.
 366         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 367         argument.
 368         (aarch64_fbsd_nat_target::fetch_registers)
 369         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 370         variable.
 371         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 372
 373 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 374
 375         * fbsd-nat.c: Include gdbarch.h.
 376
 377 2019-07-15  Tom Tromey  <tromey@adacore.com>
 378
 379         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 380
 381 2019-07-15  Tom Tromey  <tromey@adacore.com>
 382
 383         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 384         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 385         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 386         * cli-out.c (cli_ui_out::do_field_int): New method.
 387         * ui-out.c (ui_out::field_unsigned): New method.
 388         * symfile.c (generic_load): Use field_unsigned.
 389         (print_transfer_performance): Likewise.
 390         * record-btrace.c (ui_out_field_uint): Remove.
 391         (btrace_call_history_insn_range, btrace_call_history): Use
 392         field_unsigned.
 393         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 394         field_unsigned.
 395         * ui-out.h (class ui_out) <field_unsigned>: New method.
 396         <do_field_unsigned>: Likewise.
 397
 398 2019-07-15  Tom Tromey  <tromey@adacore.com>
 399
 400         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 401         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 402         * target.c (flash_erase_command): Use field_string.
 403         * infrun.c (print_signal_received_reason): Use field_string.
 404         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 405         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 406         field_string.
 407         * ada-tasks.c (print_ada_task_info): Use field_string.
 408
 409 2019-07-15  Tom Tromey  <tromey@adacore.com>
 410
 411         * target.c (flash_erase_command): Use field_core_addr.
 412         * symfile.c (generic_load): Use field_core_addr.
 413         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 414         Use field_core_addr.
 415         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 416         field_core_addr.
 417
 418 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 419
 420         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 421         value if its desired type is smaller than a CORE_ADDR and signed.
 422
 423 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 424
 425         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 426         of changes to field names, and use new is_reference field to
 427         decide if a property is a reference or not.
 428         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 429         field.
 430         (struct dwarf2_property_baton): Update header comment, rename
 431         'referenced_type' to 'property_type' and update comments.
 432         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 433         default property type, store in property baton, update to take
 434         accound of renamed field.
 435         (read_func_scope): Update call to attr_to_dynamic_prop.
 436         (read_array_type): Likewise.
 437         (dwarf2_per_cu_addr_sized_int_type): New function.
 438         (read_subrange_index_type): Move type finding code to
 439         dwarf2_per_cu_addr_sized_int_type.
 440         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 441         (dwarf2_per_cu_addr_type): New function.
 442         (set_die_type): Update calls to attr_to_dynamic_prop.
 443
 444 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * dwarf2read.c (read_subrange_index_type): New function.
 447         (read_subrange_type): Move code into new function and call it.
 448         * gdbtypes.c (create_range_type): Add some asserts.
 449
 450 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 453         update return statements.
 454         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 455         declaration, and update comment to match.
 456         * gdbtypes.c (resolve_dynamic_array): Update call to
 457         dwarf2_evaluate_property to match new return type.
 458
 459 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * valarith.c (value_subscripted_rvalue): Change lowerbound
 462         parameter type from int to LONGEST.
 463         * value.h (value_subscripted_rvalue): Likewise in declaration.
 464
 465 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         * cli/cli-utils.c (info_print_command_completer): New function.
 468         * cli/cli-utils.h: Add 'completer.h' include, and forward
 469         declaration for 'struct cmd_list_element'.
 470         (info_print_command_completer): Declare.
 471         * stack.c (_initialize_stack): Add completer for 'info locals' and
 472         'info args'.
 473         * symtab.c (_initialize_symtab): Add completer for 'info
 474         variables' and 'info functions'.
 475         * NEWS: Mention completion for additional info commands.
 476
 477 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 478
 479         * cli/cli-utils.c (extract_info_print_args): Delete.
 480         (extract_arg_maybe_quoted): Delete.
 481         (info_print_options_defs): New variable.
 482         (make_info_print_options_def_group): New function.
 483         (extract_info_print_options): Define new function.
 484         * cli/cli-utils.h (extract_info_print_args): Delete.
 485         (struct info_print_options): New structure.
 486         (extract_info_print_options): Declare new function.
 487         * stack.c (info_locals_command): Update to use new
 488         extract_info_print_options, also add a header comment.
 489         (info_args_command): Likewise.
 490         * symtab.c (info_variables_command): Likewise.
 491         (info_functions_command): Likewise.
 492
 493 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 496         to extract string arguments.
 497         * common/common-utils.c (extract_string_maybe_quoted): New function.
 498         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 499
 500 2019-07-11  Tom Tromey  <tromey@adacore.com>
 501
 502         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 503         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 504         * top.h (gdbinit): Don't declare.
 505         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 506         into...
 507         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 508         * top.c (gdb_init): Don't call init_cli_cmds.
 509         (gdbinit): Remove.
 510         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 511
 512 2019-07-11  Tom Tromey  <tromey@adacore.com>
 513
 514         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 515         after it has been moved.
 516
 517 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 518
 519         * valops.c (value_must_coerce_to_target): Change return type to
 520         bool.
 521         * value.h (value_must_coerce_to_target): Likewise.
 522
 523 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 524
 525         * breakpoint.c (is_hardware_watchpoint): Remove
 526         forward-declaration.
 527         (is_masked_watchpoint): Change return type to bool.
 528         (is_tracepoint): Likewise.
 529         (is_breakpoint): Likewise.
 530         (is_hardware_watchpoint): Likewise.
 531         (is_watchpoint): Likewise.
 532         (is_no_memory_software_watchpoint): Likewise.
 533         (is_catchpoint): Likewise.
 534         (breakpoint_1): Make FILTER parameter's return type bool.
 535         is_masked_watchpoint): Change return type to bool.
 536         (save_breakpoints): Make FILTER parameter's return type bool.
 537         * breakpoint.h (is_breakpoint): Change return type to bool.
 538         (is_watchpoint): Likewise.
 539         (is_catchpoint): Likewise.
 540         (is_tracepoint): Likewise.
 541
 542 2019-07-10  Tom Tromey  <tom@tromey.com>
 543
 544         * defs.h: Don't include gdbarch.h.
 545         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 546         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 547         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 548         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 549         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 550         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 551         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 552         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 553         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 554         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 555         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 556         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 557         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 558         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 559         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 560         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 561         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 562         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 563         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 564         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 565         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 566         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 567         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 568         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 569         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 570         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 571         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 572
 573 2019-07-10  Tom Tromey  <tromey@adacore.com>
 574
 575         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 576         * breakpoint.c (init_ada_exception_breakpoint): Register as
 577         bp_catchpoint.
 578         (print_one_breakpoint_location, print_one_breakpoint): Use
 579         is_ada_exception_catchpoint.
 580         * ada-lang.c (class ada_catchpoint_location): Pass
 581         bp_loc_software_breakpoint to bp_location constructor.
 582         (is_ada_exception_catchpoint): New function.
 583
 584 2019-07-10  Tom Tromey  <tromey@adacore.com>
 585
 586         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 587         VEC.
 588         (struct arm_exidx_entry): New method operator<.
 589         (struct arm_exidx_data) <section_maps>: Change type.
 590         (arm_exidx_data_free): Remove.
 591         (arm_exidx_data_key): Change type.  Move lower.
 592         (arm_exidx_new_objfile): Update.
 593         (arm_compare_exidx_entries): Remove.
 594         (arm_find_exidx_entry, _initialize_arm_tdep)
 595
 596 2019-07-10  Tom Tromey  <tromey@adacore.com>
 597
 598         * solib-spu.c (ocl_program_data_key): Change type.
 599         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 600         Update.
 601
 602 2019-07-10  Tom Tromey  <tromey@adacore.com>
 603
 604         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 605         (struct solib_aix_inferior_data) <library_list>: Change type.
 606         (solib_aix_inferior_data_handle): Change type.
 607         (get_solib_aix_inferior_data): Update.
 608         (solib_aix_free_library_list): Remove.
 609         (library_list_start_library): Update.
 610         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 611         return type.
 612         (solib_aix_get_library_list)
 613         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 614         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 615
 616 2019-07-10  Tom Tromey  <tromey@adacore.com>
 617
 618         * solib-dsbt.c (struct dsbt_info): Add initializers.
 619         (solib_dsbt_pspace_data): Change type.
 620         (dsbt_pspace_data_cleanup): Remove.
 621         (get_dsbt_info, _initialize_dsbt_solib): Update.
 622
 623 2019-07-10  Tom Tromey  <tromey@adacore.com>
 624
 625         * spu-tdep.c (spu_overlay_data): Change type.
 626         (spu_get_overlay_table, spu_overlay_new_objfile)
 627         (_initialize_spu_tdep): Update.
 628
 629 2019-07-10  Tom Tromey  <tromey@adacore.com>
 630
 631         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 632         destructor.
 633         (dbx_objfile_data_key): Change type and declare later.
 634         (DBX_SYMFILE_INFO): Rewrite.
 635         * dbxread.c (dbx_objfile_data_key): Change type.
 636         (dbx_symfile_init): Update.
 637         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 638         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 639         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 640
 641 2019-07-10  Tom Tromey  <tromey@adacore.com>
 642
 643         * jit.c (jit_program_space_key): Change type.  Move lower.
 644         (get_jit_program_space_data): Update.
 645         (jit_program_space_data_cleanup): Remove.
 646         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 647         Update.
 648         (struct jit_program_space_data): Add initializers.
 649
 650 2019-07-10  Tom Tromey  <tromey@adacore.com>
 651
 652         * solib-darwin.c (struct darwin_info): Add initializers.
 653         (solib_darwin_pspace_data): Change type.
 654         (darwin_pspace_data_cleanup): Remove.
 655         (get_darwin_info, _initialize_darwin_solib): Update.
 656
 657 2019-07-10  Tom Tromey  <tromey@adacore.com>
 658
 659         * remote-sim.c (struct sim_inferior_data): Add initializers,
 660         constructor, and destructor.
 661         (sim_inferior_data_key): Change type.  Move lower.
 662         (check_for_duplicate_sim_descriptor): Update.
 663         (get_sim_inferior_data): Use new.  Update.
 664         (~sim_inferior_data_cleanup): Rename from
 665         sim_inferior_data_cleanup.  Simplify.
 666         (gdbsim_close_inferior, simulator_command)
 667         (sim_command_completer, _initialize_remote_sim): Update.
 668         (next_pid, INITIAL_PID): Move earlier.
 669
 670 2019-07-10  Tom Tromey  <tromey@adacore.com>
 671
 672         * python/python-internal.h (create_thread_object): Return
 673         gdbpy_ref.
 674         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 675         * python/py-inferior.c (struct threadlist_entry): Add
 676         constructor.
 677         <thread_obj>: Now a gdbpy_ref.
 678         (thread_to_thread_object): Update.
 679         (add_thread_object): Use new.
 680         (delete_thread_object): Use delete.
 681         (infpy_threads): Update.
 682         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 683         GIL.
 684
 685 2019-07-10  Tom Tromey  <tromey@adacore.com>
 686
 687         * valops.c (value_cast): Specialize error message for Ada.
 688
 689 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 690
 691         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 692
 693 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 694
 695         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 696         bpstat_should_step): Return bool, adjust comments.
 697         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 698         bpstat_should_step): Likewise.
 699
 700 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 701
 702         * features/Makefile: Use feature target descriptions for Arm.
 703         * features/arm/arm-core.c: Generate new file.
 704         * features/arm/arm-fpa.c: Likewise.
 705         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 706         * features/arm/arm-m-profile.c: Likewise.
 707         * features/arm/arm-vfpv2.c: Likewise.
 708         * features/arm/arm-vfpv3.c: Likewise.
 709         * features/arm/xscale-iwmmxt.c: Likewise.
 710         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 711
 712 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 713
 714         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 715         ptrace earlier.
 716
 717 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 718
 719         * features/aarch64-pauth.c: Regenerate.
 720
 721 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 722
 723         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 724         bool.
 725         (bpstat_what): Use false instead of 0.
 726
 727 2019-07-09  Pedro Alves  <palves@redhat.com>
 728
 729         * break-catch-throw.c (is_exception_catchpoint): New.
 730         * breakpoint.c (print_one_breakpoint_location): New parameter
 731         'raw_loc'.  Handle it.  Use
 732         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 733         looking at the breakpoint's type.
 734         (print_one_breakpoint): If handling "maint info breakpoints", also
 735         print locations of exception catchpoints.
 736         * breakpoint.h (is_exception_catchpoint): Declare.
 737
 738 2019-07-09  Pedro Alves  <palves@redhat.com>
 739
 740         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 741         "addr" field.
 742         (allocate_location_exception_catchpoint): New.
 743         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 744         (initialize_throw_catchpoint_ops): Install
 745         allocate_location_exception_catchpoint as allocate_location
 746         method.
 747         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 748         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 749         bp_loc_other.
 750         (breakpoint_address_is_meaningful): Delete.
 751         (bl_address_is_meaningful): New.
 752         (breakpoint_locations_match): Adjust comment.
 753         (bp_location_from_bp_type): New, factored out of...
 754         (bp_location::bp_location(breakpoint *)): ... this.
 755         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 756         factored out of...
 757         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 758         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 759         breakpoint_address_is_meaningful.
 760         (bp_locations_compare): Adjust comment.
 761         (update_global_location_list): Use bl_address_is_meaningful
 762         instead of breakpoint_address_is_meaningful.
 763         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 764         explicit.
 765         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 766         * python/py-breakpoint.c (bppy_get_location): No longer check
 767         whether location is null.
 768
 769 2019-07-09  Pedro Alves  <palves@redhat.com>
 770
 771         PR c++/15468
 772         * breakpoint.c (print_one_breakpoint_location): Remove
 773         single-location assert.
 774
 775 2019-07-09  Tom Tromey  <tom@tromey.com>
 776
 777         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 778         * configure: Rebuild.
 779         * configure.ac: Change common to gdbsupport.
 780         * gdbsupport: Rename from common.
 781         * acinclude.m4: Change common to gdbsupport.
 782         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 783         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 784         gdbsupport.
 785         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 786         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 787         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 788         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 789         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 790         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 791         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 792         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 793         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 794         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 795         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 796         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 797         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 798         coff-pe-read.c, command.h, compile/compile-c-support.c,
 799         compile/compile-c.h, compile/compile-cplus-symbols.c,
 800         compile/compile-cplus-types.c, compile/compile-cplus.h,
 801         compile/compile-loc2c.c, compile/compile.c, completer.c,
 802         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 803         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 804         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 805         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 806         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 807         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 808         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 809         features/aarch64-core.c, features/aarch64-fpu.c,
 810         features/aarch64-pauth.c, features/aarch64-sve.c,
 811         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 812         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 813         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 814         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 815         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 816         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 817         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 818         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 819         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 820         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 821         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 822         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 823         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 824         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 825         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 826         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 827         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 828         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 829         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 830         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 831         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 832         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 833         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 834         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 835         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 836         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 837         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 838         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 839         minsyms.c, mips-linux-tdep.c, namespace.h,
 840         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 841         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 842         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 843         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 844         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 845         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 846         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 847         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 848         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 849         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 850         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 851         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 852         procfs.c, producer.c, progspace.h, psymtab.h,
 853         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 854         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 855         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 856         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 857         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 858         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 859         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 860         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 861         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 862         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 863         target-memory.c, target.c, target.h, target/waitstatus.c,
 864         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 865         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 866         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 867         unittests/array-view-selftests.c,
 868         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 869         unittests/common-utils-selftests.c,
 870         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 871         unittests/format_pieces-selftests.c,
 872         unittests/function-view-selftests.c,
 873         unittests/lookup_name_info-selftests.c,
 874         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 875         unittests/mkdir-recursive-selftests.c,
 876         unittests/observable-selftests.c,
 877         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 878         unittests/parse-connection-spec-selftests.c,
 879         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 880         unittests/scoped_fd-selftests.c,
 881         unittests/scoped_mmap-selftests.c,
 882         unittests/scoped_restore-selftests.c,
 883         unittests/string_view-selftests.c, unittests/style-selftests.c,
 884         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 885         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 886         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 887         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 888         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 889         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 890
 891 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 894         bool value.
 895         (decode_digits_ordinary): Set explicit_line field in sal.
 896         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 897         symtab_and_line that was set on an explicit line number in
 898         assembler code.  Do always update the recorded symtab and line if
 899         we do skip the prologue.
 900
 901 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * breakpoint.c (set_breakpoint_location_function): Remove
 904         explicit_loc parameter.
 905         (momentary_breakpoint_from_master): Update call to
 906         set_breakpoint_location_function.
 907         (add_location_to_breakpoint): Likewise.
 908
 909 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 912         required features based on default bfd type when no specific bfd
 913         is present.
 914
 915 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 916
 917         * NEWS: Mention that GDB printf and eval commands can now print
 918         C-style and Ada-style convenience var strings without
 919         calling the inferior.
 920         * printcmd.c (printf_c_string): Locally print GDB internal var
 921         instead of transiting via the inferior.
 922         (printf_wide_c_string): Likewise.
 923
 924 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 925
 926         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 927
 928 2019-07-04  Tom Tromey  <tom@tromey.com>
 929
 930         PR tui/24724:
 931         * tui/tui-winsource.c (tui_clear_source_content): Update.
 932         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 933         (tui_update_breakpoint_info): Update.
 934         (tui_set_exec_info_content): Update.
 935         * tui/tui-source.c (tui_set_source_content_nil): Update.
 936         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 937         has_break.
 938         * tui/tui-data.h (enum tui_bp_flag): New.
 939         (tui_bp_flags): New enum flags type.
 940         (struct tui_source_element) <break_mode>: Change type.  Rename
 941         from has_break.
 942         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 943         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 944         constants.
 945         * tui/tui-winsource.h: Fix comment.
 946
 947 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 948
 949         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 950         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 951         (store_fpregs_to_thread)
 952         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 953         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 954         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 955         (IWMMXT_REGS_SIZE): Add define.
 956         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 957         (fetch_vfp_regs, store_vfp_regs)
 958         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 959         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 960
 961 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 962
 963         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 964         defines.
 965         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 966         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 967         (ARM_INT_REGISTER_SIZE): ...to this.
 968         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 969         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 970         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 971         (arm_linux_collect_gregset, supply_nwfpe_register)
 972         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 973         defines.
 974         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 975         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 976         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 977         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 978         (arm_return_in_memory, arm_store_return_value)
 979         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 980         (arm_record_ld_st_multiple): Likewise.
 981         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 982         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 983
 984 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 985
 986         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 987         AARCH64_DISPLACED_MODIFIED_INSNS.
 988         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 989         (aarch64_displaced_step_copy_insn): Likewise.
 990         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 991         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 992         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 993         ARM_DISPLACED_MODIFIED_INSNS.
 994         * arm-tdep.c (arm_gdbarch_init): Likewise.
 995         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 996         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 997         (struct arm_displaced_step_closure): Use
 998         ARM_DISPLACED_MODIFIED_INSNS.
 999
1000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * features/Makefile: Remove unused xml files.
1003         * features/aarch64.xml: Remove.
1004         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1005         * features/i386/amd64-avx-avx512.xml: Remove.
1006         * features/i386/amd64-avx-linux.xml: Remove.
1007         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1008         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1009         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1010         * features/i386/amd64-avx-mpx.xml: Remove.
1011         * features/i386/amd64-avx.xml: Remove.
1012         * features/i386/amd64-linux.xml: Remove.
1013         * features/i386/amd64-mpx-linux.xml: Remove.
1014         * features/i386/amd64-mpx.xml: Remove.
1015         * features/i386/amd64.xml: Remove.
1016         * features/i386/i386-avx-avx512-linux.xml: Remove.
1017         * features/i386/i386-avx-avx512.xml: Remove.
1018         * features/i386/i386-avx-linux.xml: Remove.
1019         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1020         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1021         * features/i386/i386-avx-mpx-linux.xml: Remove.
1022         * features/i386/i386-avx-mpx.xml: Remove.
1023         * features/i386/i386-avx.xml: Remove.
1024         * features/i386/i386-linux.xml: Remove.
1025         * features/i386/i386-mmx-linux.xml: Remove.
1026         * features/i386/i386-mmx.xml: Remove.
1027         * features/i386/i386-mpx-linux.xml: Remove.
1028         * features/i386/i386-mpx.xml: Remove.
1029         * features/i386/i386.xml: Remove.
1030         * features/i386/x32-avx-avx512-linux.xml: Remove.
1031         * features/i386/x32-avx-linux.xml: Remove.
1032         * features/i386/x32-linux.xml: Remove.
1033
1034 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1035
1036         * regformats/aarch64.dat: Remove.
1037         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1038         * regformats/i386/amd64-avx-linux.dat: Remove.
1039         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1040         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1041         * regformats/i386/amd64-linux.dat: Remove.
1042         * regformats/i386/amd64-mpx-linux.dat: Remove.
1043         * regformats/i386/amd64.dat: Remove.
1044         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1045         * regformats/i386/i386-avx-linux.dat: Remove.
1046         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1047         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1048         * regformats/i386/i386-linux.dat: Remove.
1049         * regformats/i386/i386-mmx-linux.dat: Remove.
1050         * regformats/i386/i386-mpx-linux.dat: Remove.
1051         * regformats/i386/i386.dat: Remove.
1052         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1053         * regformats/i386/x32-avx-linux.dat: Remove.
1054         * regformats/i386/x32-linux.dat: Remove.
1055
1056 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1057
1058         * aarch64-tdep.c: Remove xml self tests.
1059         * amd64-linux-tdep.c: Likewise.
1060         * amd64-tdep.c: Likewise.
1061         * i386-linux-tdep.c: Likewise.
1062         * i386-tdep.c: Likewise.
1063
1064 2019-07-03  Pedro Alves  <palves@redhat.com>
1065
1066         PR cli/24732
1067         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1068         (pipe_cmd_option_defs): New.
1069         (make_pipe_cmd_options_def_group): New.
1070         (pipe_command): Use gdb::option::process_options.
1071         (pipe_command_completer): New function.
1072         (_initialize_cli_cmds): Install completer for "pipe" command.
1073
1074 2019-07-03  Pedro Alves  <palves@redhat.com>
1075
1076         * cli/cli-option.c (union option_value) <string>: New field.
1077         (struct option_def_and_value): Add ctor, move ctor, dtor and
1078         use DISABLE_COPY_AND_ASSIGN.
1079         (option_def_and_value::clear_value): New.
1080         (parse_option, save_option_value_in_ctx, get_val_type_str)
1081         (add_setshow_cmds_for_options): Handle var_string.
1082         * cli-option.h (union option_def::var_address) <string>: New
1083         field.
1084         (struct string_option_def): New.
1085         * maint-test-options.c (struct test_options_opts): Add default
1086         ctor and use DISABLE_COPY_AND_ASSIGN.
1087         <string_opt>: New field.
1088         (test_options_opts::~test_options_opts): New.
1089         (test_options_opts::dump): Also dump "-string".
1090         (test_options_option_defs): Install "string.
1091
1092 2019-07-03  Pedro Alves  <palves@redhat.com>
1093
1094         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1095         option_value with a null enumeration.
1096         (complete_options): Save the option values in the context.
1097         (save_option_value_in_ctx): New, factored out from ...
1098         (process_options): ... here.
1099         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1100         of the function.
1101         * maint-test-options.c (test_options_opts::dump): New, factored
1102         out from ...
1103         (maintenance_test_options_command_mode): ... here.
1104         (maintenance_test_options_command_completion_result): Delete.
1105         (maintenance_test_options_command_completion_text): Update
1106         comment.
1107         (maintenance_show_test_options_completion_result): Change
1108         prototype.  Just print
1109         maintenance_test_options_command_completion_text.
1110         (save_completion_result): New.
1111         (maintenance_test_options_completer_mode): Pass options context to
1112         complete_options, and then save a dump.
1113         (_initialize_maint_test_options): Use add_cmd to install "maint
1114         show test-options-completion-result".
1115
1116 2019-07-03  Pedro Alves  <palves@redhat.com>
1117
1118         * NEWS (New commands): Mention "with" and "maint with".
1119         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1120         (with_command, with_command_completer): New.
1121         (pipe_command): Adjust to new repeat_previous
1122         interface.
1123         (_initialize_cli_cmds): Install the "with" command and its "w"
1124         alias.
1125         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1126         declarations.
1127         * cli/cli-setshow.c (parse_cli_var_uinteger)
1128         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1129         argument strings for all var_types.
1130         (get_setshow_command_value_string): New, factored out from ...
1131         (do_show_command): ... this.
1132         * cli/cli-setshow.h: Include <string>.
1133         (get_setshow_command_value_string): Declare.
1134         * command.h (repeat_previous): Now returns const char *.  Adjust
1135         comment.
1136         * maint.c: Include "cli/cli-cmds.h".
1137         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1138         (_initialize_maint_cmds): Register the "maintenance with" command.
1139         * top.c (repeat_previous): Move bits from pipe_command here:
1140         Return the saved command line, if any; error out if there's no
1141         command to relaunch.
1142
1143 2019-07-03  Pedro Alves  <palves@redhat.com>
1144
1145         * NEWS (New commands): Mention "maint set/show test-settings"
1146         instead of "maint test-settings".
1147         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1148         (maintenance_test_settings_set_list): Rename to ...
1149         (maintenance_set_test_settings_list): ... this.
1150         (maintenance_test_settings_show_list): Rename to  ...
1151         (maintenance_show_test_settings_list): ... this.
1152         (maintenance_test_settings_cmd): Delete.
1153         (maintenance_test_settings_set_cmd): ...
1154         (maintenance_set_test_settings_cmd): ... this.
1155         (maintenance_test_settings_show_cmd): ...
1156         (maintenance_show_test_settings_cmd): ... this.
1157         (maintenance_test_settings_show_value_cmd):
1158         (maintenance_show_test_settings_value_cmd): ... this.
1159         (_initialize_maint_test_settings): No longer install the "maint
1160         test-settings" prefix command.  Rename "maint test-settings set"
1161         to "maint set test-settings", and "maint test-settings show" to
1162         "maint show test-settings".  Adjust all subcommands.
1163
1164 2019-07-03  Pedro Alves  <palves@redhat.com>
1165
1166         * maint-test-settings.c: Fix file's intro comment.  Replace all
1167         references to "test-options" with references to "test-settings",
1168         in comments.
1169
1170 2019-07-03  Pedro Alves  <palves@redhat.com>
1171
1172         * maint-test-settings.c (maintenance_test_settings_xxx)
1173         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1174         New.
1175         (maintenance_test_settings_enums): Use them.
1176         (maintenance_test_settings_enum): Default to
1177         maintenance_test_settings_xxx.
1178         (_initialize_maint_test_settings): Initialize
1179         MAINTENANCE_TEST_SETTINGS_FILENAME.
1180
1181 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1182
1183         * breakpoint.h (remove_breakpoints_inf): Change return type to
1184         void, move function documentation here.
1185         * breakpoint.c (remove_breakpoints_inf): Change return type to
1186         void, move function documentation to header.
1187
1188 2019-07-02  Pedro Alves  <palves@redhat.com>
1189
1190         * NEWS (Completion improvements): Mention "info threads".
1191         * thread.c (struct info_threads_opts, info_threads_option_defs)
1192         (make_info_threads_options_def_group): New.
1193         (info_threads_command): Use gdb::option::process_options.
1194         (info_threads_command_completer): New.
1195         (_initialize_thread): Use gdb::option::build_help to build the
1196         help text for "info threads".
1197
1198 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1199
1200         * defs.h (generic_load): Move from here...
1201         * symfile.h (generic_load): ... to here.  Rename name parameter
1202         to args.
1203         * symfile.c (generic_load): Add comment.
1204
1205 2019-07-01  Tom Tromey  <tromey@adacore.com>
1206
1207         * dwarf2read.c
1208         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1209         declaration of without_params.  Fix formatting.
1210
1211 2019-07-01  Tom Tromey  <tromey@adacore.com>
1212
1213         * ada-exp.y (find_primitive_type): Update.
1214         * ada-lang.h (ada_lookup_symbol): Update.
1215         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1216         parameter.
1217         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1218
1219 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1220
1221         PR breakpoints/24541
1222         * gdbarch.c: Regenerate.
1223         * gdbarch.h: Regenerate.
1224         * gdbarch.sh: Add 'stap_adjust_register'.
1225         * i386-tdep.c: Include '<unordered_set>'.
1226         (i386_stap_adjust_register): New function.
1227         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1228         * stap-probe.c (stap_parse_register_operand): Call
1229         'gdbarch_stap_adjust_register'.
1230
1231 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1232
1233         PR python/24742
1234         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1235         * python/python.c (do_start_initialization): Use 'xmalloc'
1236         instead of 'PyMem_Malloc'.
1237
1238 2019-06-28  Tom Tromey  <tromey@adacore.com>
1239
1240         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1241         for Ada.
1242
1243 2019-06-27  Tom Tromey  <tromey@adacore.com>
1244
1245         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1246         objfile_key.
1247         (arm_find_mapping_symbol, arm_record_special_symbol)
1248         (_initialize_arm_tdep): Update.
1249         (arm_objfile_data_free): Remove.
1250
1251 2019-06-27  Tom Tromey  <tromey@adacore.com>
1252
1253         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1254         to cp_print_static_field.
1255
1256 2019-06-26  Tom Tromey  <tromey@adacore.com>
1257
1258         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1259         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1260         declare.
1261
1262 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1263
1264         * features/aarch64-core.c (create_feature_aarch64_core):
1265         Regenerate.
1266         * features/aarch64-core.xml: Add cpsr flags.
1267
1268 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1271         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1272
1273 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1274
1275         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1276         field.
1277         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1278         use.
1279         (arm_record_special_symbol): Don't insert new symbol in sorted
1280         position, push it at the end.
1281
1282 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1283
1284         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1285         (arm_mapping_symbol_s): Remove.
1286         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1287         (arm_mapping_symbol_vec): New typedef.
1288         (struct arm_per_objfile): Add constructor.
1289         <section_maps>: Change type to
1290         std::unique_ptr<arm_mapping_symbol_vec[]>.
1291         (arm_compare_mapping_symbols): Remove.
1292         (arm_find_mapping_symbol): Adjust to section_maps type change.
1293         (arm_objfile_data_free): Call delete on arm_per_objfile.
1294         (arm_record_special_symbol): Adjust to section_maps type change.
1295         Allocate arm_per_objfile with new.
1296
1297 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1298
1299         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1300         with the command prefix.
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1305         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1310         type.
1311         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1312         protected.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-winsource.c
1317         (tui_source_window_base::set_is_exec_point_at): Add check against
1318         LOA_ADDRESS.
1319
1320 2019-06-25  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-source.c (tui_set_source_content): Don't check before
1323         xfree.
1324         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-winsource.h (tui_update_source_window_as_is)
1329         (tui_alloc_source_buffer, tui_line_is_displayed)
1330         (tui_addr_is_displayed): Change type of win_info.
1331         * tui/tui-winsource.c (tui_update_source_window_as_is)
1332         (tui_clear_source_content, tui_show_source_line)
1333         (tui_show_source_content, tui_source_window_base::refill)
1334         (tui_source_window_base::set_is_exec_point_at)
1335         (tui_source_window_base::set_is_exec_point_at)
1336         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1337         (tui_alloc_source_buffer, tui_line_is_displayed)
1338         (tui_addr_is_displayed): Change type of win_info.  Update.
1339         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1340         (tui_source_window_base::do_make_visible_with_new_height):
1341         Update.
1342         * tui/tui-source.c (tui_set_source_content)
1343         (tui_set_source_content_nil)
1344         (tui_source_window::do_scroll_vertical): Update.
1345         * tui/tui-layout.c (show_layout): Update.
1346         * tui/tui-disasm.c (tui_set_disassem_content)
1347         (tui_disasm_window::do_scroll_vertical): Update.
1348         * tui/tui-data.h (tui_win_content): Remove.
1349         (struct tui_gen_win_info) <content, content_size>: Remove.
1350         (struct tui_source_element): Add initializers and destructor.
1351         (union tui_which_element, struct tui_win_element): Remove.
1352         (struct tui_source_window_base) <content>: New field.
1353         (struct tui_data_window): Remove destructor.
1354         (tui_alloc_content, tui_free_win_content)
1355         (tui_free_all_source_wins_content): Don't declare.
1356         * tui/tui-data.c (tui_initialize_static_data): Update.
1357         (init_content_element, tui_alloc_content): Remove.
1358         (~tui_gen_win_info): Update.
1359         (~tui_data_window, tui_free_all_source_wins_content)
1360         (tui_free_win_content, free_content, free_content_elements):
1361         Remove.
1362
1363 2019-06-25  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-winsource.h (tui_clear_source_content)
1366         (tui_erase_source_content, tui_show_source_content): Change type
1367         of win_info.
1368         * tui/tui-winsource.c (tui_clear_source_content)
1369         (tui_erase_source_content, tui_show_source_content): Change type
1370         of win_info.
1371         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1372         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1373         win_info.
1374         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1375         win_info.
1376         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1377
1378 2019-06-25  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-winsource.c (tui_clear_source_content)
1381         (tui_source_window_base::set_is_exec_point_at): Update.
1382         * tui/tui-source.c (tui_set_source_content_nil): Update.
1383         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1384         a bool.
1385         * tui/tui-data.c (init_content_element): Update.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1390         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1391         * tui/tui-layout.c (init_and_make_win): Update.
1392         * tui/tui.h (enum tui_win_type): Update.
1393         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1394         tui_win_is_auxillary.
1395         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1396         tui_win_is_auxillary.
1397
1398 2019-06-25  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1401         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1402         (tui_delete_data_content_windows, tui_display_all_data)
1403         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1404         Update.
1405         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1406         * tui/tui-regs.c (tui_last_regs_line_no)
1407         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1408         (tui_show_registers): Update.
1409         (tui_show_register_group): Return void.  Update.
1410         (tui_display_registers_from, tui_display_reg_element_at_line)
1411         (tui_display_registers_from_line, tui_check_register_values):
1412         Update.
1413         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1414         member.
1415         (struct tui_data_window) <regs_content>: Now a std::vector.
1416         <regs_content_count>: Remove.
1417         (tui_add_content_elements, tui_free_data_content): Don't declare.
1418         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1419         (init_content_element): Remove DATA_WIN case.  Add assert.
1420         (tui_add_content_elements): Remove.
1421         (tui_data_window): Update.
1422         (tui_free_data_content): Remove.
1423         (free_content_elements): Remove DATA_WIN case.
1424
1425 2019-06-25  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-data.c (tui_data_item_window): Update.
1428         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1429         * tui/tui-windata.c (tui_display_all_data)
1430         (tui_display_data_from_line): Update.
1431         (tui_check_data_values): Remove.
1432         * tui/tui-regs.c (tui_show_register_group)
1433         (tui_display_reg_element_at_line): Update.
1434         * tui/tui-hooks.c (tui_register_changed)
1435         (tui_refresh_frame_and_register_information): Call
1436         tui_check_register_values.
1437         * tui/tui-data.h (struct tui_data_window) <data_content,
1438         data_content_count, data_type>: Remove.
1439         (enum tui_data_type): Remove.
1440
1441         * tui/tui-data.c (tui_data_window::clear_detail)
1442         (~tui_data_window): Update.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1447         declare.
1448         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1449         Rename from tui_first_data_item_displayed.  Update.
1450         (tui_data_window::refresh_all)
1451         (tui_data_window::do_scroll_vertical): Update.
1452         * tui/tui-data.h (struct tui_data_window)
1453         <first_data_item_displayed>: Declare new method.
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1458         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1459         contents...
1460         (tui_initialize_static_data): ...here.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1465         (tui_display_registers_from, tui_check_register_values): Update.
1466         (tui_display_register): Remove win_info parameter; update.
1467         (tui_get_register): Change type of parameters.
1468         * tui/tui-data.h (struct tui_data_element): Remove.
1469         (union tui_which_element) <data>: Remove.
1470         <data_window>: Change type.
1471         (struct tui_data_item_window): New.
1472         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1473         case.  Add assert.
1474         (~tui_data_item_window): New destructor.
1475         (free_content_elements): Remove DATA_ITEM_WIN case.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1480         Remove.
1481
1482 2019-06-25  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-data.h (struct tui_command_element): Remove.
1485         (union tui_which_element) <command>: Remove.
1486         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1487         assert.
1488         (free_content_elements): Remove CMD_WIN case.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-layout.c (tui_set_layout): Update.
1493         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1494         * tui/tui-data.c (layout_def): Update.
1495
1496 2019-06-25  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1499         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1500         (tui_source_window_base::set_new_height): Update.
1501         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1502         Update.
1503         (tui_set_locator_fullname, tui_set_locator_info)
1504         (tui_show_frame_info): Update.
1505         * tui/tui-source.c (tui_set_source_content)
1506         (tui_source_is_displayed): Update.
1507         * tui/tui-layout.c (show_source_disasm_command, show_data)
1508         (show_source_or_disasm_and_command): Update.
1509         * tui/tui-disasm.c (tui_set_disassem_content)
1510         (tui_get_begin_asm_address): Update.
1511         * tui/tui-data.h (struct tui_locator_element): Remove.
1512         (union tui_which_element) <locator>: Remove.
1513         (struct tui_locator_window): New.
1514         (tui_locator_win_info_ptr): Change return type.
1515         * tui/tui-data.c (_locator): Change type.
1516         (tui_locator_win_info_ptr): Change return type.
1517         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1518         (tui_alloc_content): Add assert.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-winsource.c
1523         (tui_exec_info_window::maybe_allocate_content): New method.
1524         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1525         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1526         (make_source_or_disasm_window): Add cast.
1527         * tui/tui-data.h (union tui_which_element) <simple_string>:
1528         Remove.
1529         (struct tui_source_info): New.
1530         (struct tui_source_window_base) <execution_info>: Change type.
1531         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1532         case, and add assert.
1533         (tui_alloc_content): Add assert.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1538         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1539         * tui/tui-data.c (tui_alloc_win_info): Remove.
1540
1541 2019-06-25  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1544         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1545         can_highlight.
1546
1547 2019-06-25  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1550         make_visible_with_new_height method.
1551         (tui_win_info::make_visible_with_new_height): New method.
1552         (tui_source_window_base::do_make_visible_with_new_height)
1553         (tui_data_window::do_make_visible_with_new_height)
1554         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1555         (make_visible_with_new_height): Remove.
1556         (tui_resize_all, tui_adjust_win_heights): Use
1557         make_visible_with_new_height method.
1558         * tui/tui-data.h (struct tui_win_info)
1559         <do_make_visible_with_new_height, make_visible_with_new_height>:
1560         New methods.
1561         (struct tui_source_window_base, struct tui_data_window)
1562         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1563         methods.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1568         method.
1569         (update_tab_width): Call update_tab_width method.
1570         * tui/tui-data.h (struct tui_win_info)
1571         (struct tui_source_window_base) <update_tab_width>: New methods.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1576         parameter.
1577         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1578         parameter.
1579         (tui_gen_win_info::make_visible): Update.
1580         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1581         parameter.
1582         * tui/tui-data.h (enum tui_box): New enum.
1583         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1588         init_and_make_win for EXEC_INFO_WIN.
1589         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1590         longer inline.
1591         (struct tui_win_info) <~tui_win_info>: Inline.
1592         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1593         Don't declare.
1594         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1595         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1596         Remove.
1597         (tui_initialize_static_data): Update.
1598         (~tui_gen_win_info): Handle more cleanup here.
1599         (~tui_source_window_base): Delete "execution_info".
1600         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1601
1602 2019-06-25  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-layout.c (make_command_window): Don't set
1605         can_highlight.
1606         (show_source_disasm_command): Call the reset method.
1607         (show_data): Don't set can_highlight.  Call the reset method.
1608         (tui_gen_win_info::reset): Rename from init_gen_win_info
1609         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1610         (show_source_or_disasm_and_command): Call the reset method.
1611         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1612         (struct tui_cmd_window): Set can_highlight.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1617         from make_visible.
1618         (tui_make_visible, tui_make_invisible): Rewrite.
1619         (tui_win_info::make_visible): Remove.
1620         (tui_source_window_base::make_visible): Update.
1621         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1622         method.  Moved from...
1623         (struct tui_win_info) <make_visible>: ...here.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-winsource.c
1628         (tui_source_window_base::do_scroll_horizontal): Remove direction
1629         parameter.
1630         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1631         direction parameter.
1632         * tui/tui-win.c (tui_win_info::forward_scroll)
1633         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1634         (tui_win_info::right_scroll): Update.
1635         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1636         direction parameter.
1637         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1638         direction parameter.
1639         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1640         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1641         Remove direction parameter.
1642         (struct tui_source_window_base, struct tui_source_window)
1643         (struct tui_disasm_window, struct tui_data_window)
1644         (struct tui_cmd_window): Update.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-winsource.h (tui_set_exec_info_content)
1649         (tui_show_exec_info_content, tui_erase_exec_info_content)
1650         (tui_clear_exec_info_content, tui_update_exec_info): Change
1651         argument to tui_source_window_base.
1652         * tui/tui-winsource.c (tui_set_exec_info_content)
1653         (tui_show_exec_info_content, tui_erase_exec_info_content)
1654         (tui_clear_exec_info_content, tui_update_exec_info): Change
1655         argument to tui_source_window_base.
1656
1657 2019-06-25  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1660         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1665         check.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1670         type to void.
1671         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1672         type to void.
1673         * tui/tui-source.c (tui_set_source_content): Update.
1674         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1675
1676 2019-06-25  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-win.c (window_name_completer, tui_set_focus)
1679         (tui_all_windows_info): Use name method.
1680         * tui/tui-data.h (struct tui_gen_win_info)
1681         (struct tui_source_window, struct tui_disasm_window)
1682         (struct tui_data_window, struct tui_cmd_window) <name>: New
1683         method.
1684         (tui_win_name): Don't declare.
1685         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1686         (tui_win_name): Remove.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-winsource.h (tui_update_source_window)
1691         (tui_update_source_window_as_is): Change parameter type.
1692         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1693         to be a tui_source_window_base.
1694         (tui_update_source_window_as_is): Likewise.
1695         * tui/tui-win.c (make_visible_with_new_height): Update.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-winsource.c (tui_erase_source_content)
1700         (tui_show_source_content, tui_show_exec_info_content)
1701         (tui_erase_exec_info_content): Use refresh_window method.
1702         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1703         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1704         from tui_refresh_win.
1705         (tui_data_window::refresh_window): New method.
1706         (tui_win_info::refresh, tui_source_window_base::refresh)
1707         (tui_refresh_all): Use refresh_window method.
1708         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1709         method.
1710         * tui/tui-regs.c (tui_display_register): Call refresh_window
1711         method.
1712         * tui/tui-layout.c (show_source_disasm_command)
1713         (show_source_or_disasm_and_command): Call refresh_window method.
1714         * tui/tui-data.h (struct tui_gen_win_info)
1715         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1716         New method.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui.c (tui_rl_other_window, tui_enable)
1721         (tui_is_window_visible, tui_get_command_dimension): Update.
1722         * tui/tui-winsource.c (tui_update_source_window_as_is)
1723         (tui_clear_source_content, tui_erase_source_content)
1724         (tui_show_source_line, tui_source_window_base::refill)
1725         (tui_source_window_base::do_scroll_horizontal)
1726         (tui_source_window_base::set_is_exec_point_at)
1727         (tui_update_breakpoint_info, tui_set_exec_info_content)
1728         (tui_alloc_source_buffer, tui_line_is_displayed)
1729         (tui_addr_is_displayed): Update.
1730         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1731         (tui_check_and_display_highlight_if_needed)
1732         (tui_win_info::make_visible, tui_win_info::refresh)
1733         (tui_refresh_all): Update.
1734         * tui/tui-windata.c (tui_first_data_item_displayed)
1735         (tui_delete_data_content_windows, tui_erase_data_content)
1736         (tui_display_all_data, tui_data_window::refresh_all)
1737         (tui_check_data_values): Update.
1738         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1739         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1740         (tui_win_info::backward_scroll, tui_refresh_all_win)
1741         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1742         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1743         (tui_source_window_base::set_new_height)
1744         (tui_data_window::set_new_height)
1745         (make_invisible_and_set_new_height)
1746         (make_visible_with_new_height, new_height_ok)
1747         (parse_scrolling_args): Update.
1748         * tui/tui-stack.c (tui_show_frame_info): Update.
1749         * tui/tui-source.c (tui_set_source_content)
1750         (tui_set_source_content_nil, tui_source_is_displayed)
1751         (tui_source_window::do_scroll_vertical): Update.
1752         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1753         (tui_display_registers_from, tui_display_reg_element_at_line)
1754         (tui_check_register_values, tui_reg_command): Update.
1755         * tui/tui-layout.c (tui_default_win_height)
1756         (show_source_disasm_command, show_data, init_and_make_win)
1757         (show_source_or_disasm_and_command): Update.
1758         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1759         (tui_redisplay_readline, tui_mld_flush)
1760         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1761         (tui_getc): Update.
1762         * tui/tui-disasm.c (tui_set_disassem_content)
1763         (tui_disasm_window::do_scroll_vertical): Update.
1764         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1765         Now virtual.
1766         (struct tui_win_info): Derive from tui_gen_win_info.
1767         <~tui_win_info>: Mark as override.
1768         <generic>: Remove member.
1769         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1770         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1771         (~tui_data_window, ~tui_win_info)
1772         (tui_free_all_source_wins_content): Update.
1773         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1774
1775 2019-06-25  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-layout.c (init_and_make_win): Use new.
1778         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1779         destructor, initializers.
1780         (tui_alloc_generic_win_info): Don't declare.
1781         * tui/tui-data.c (_locator): Add argument to constructor.
1782         (source_win, disasm_win): New globals.
1783         (exec_info): Remove.
1784         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1785         Update.
1786         (tui_alloc_generic_win_info): Remove.
1787         (init_content_element): Use new.
1788         (tui_win_info::tui_win_info): Update.
1789         (free_content_elements) <case DATA_WIN>: Use delete.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1794         * tui/tui-windata.c (tui_first_data_item_displayed)
1795         (tui_delete_data_content_windows): Update.
1796         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1797         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1798         (tui_display_registers_from, tui_check_register_values): Update.
1799         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1800         pointer.
1801         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1802         window.
1803         (tui_free_data_content): Update.
1804         (free_content_elements) <case DATA_WIN>: Free the window.
1805
1806 2019-06-25  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1809         Update.
1810         * tui/tui-layout.c (make_command_window)
1811         (show_source_disasm_command, show_data, init_and_make_win)
1812         (show_source_or_disasm_and_command): Update.
1813         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1814         method.
1815         <can_highight, is_highlighted>: Now bool.
1816         (tui_set_win_highlight): Don't declare.
1817         * tui/tui-data.c (tui_set_win_highlight): Remove.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-wingeneral.c (make_visible): Remove check of window
1822         type.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-win.c (tui_win_info::max_height)
1827         (tui_cmd_window::max_height): New methods.
1828         (new_height_ok): Call max_height.
1829         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1830         <max_height>: New method.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-win.c (tui_source_window_base::set_new_height)
1835         (tui_data_window::set_new_height): New methods.
1836         (make_invisible_and_set_new_height): Call set_new_height method.
1837         * tui/tui-data.h (struct tui_win_info)
1838         (struct tui_source_window_base, struct tui_data_window)
1839         <set_new_height>: New method.
1840
1841 2019-06-25  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1844         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1845         tui_refresh_data_win.
1846         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1847         method.
1848         (tui_refresh_all_win): Call the refresh_all method.
1849         (tui_set_focus): Likewise.
1850         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1851         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1852         Likewise.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-winsource.h (tui_refill_source_window)
1857         (tui_set_is_exec_point_at): Don't declare.
1858         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1859         (tui_source_window_base::refill): Rename from
1860         tui_refill_source_window.
1861         (tui_source_window_base::do_scroll_horizontal): Update.
1862         (tui_source_window_base::set_is_exec_point_at): Rename from
1863         tui_set_is_exec_point_at.
1864         (tui_update_all_breakpoint_info): Update.
1865         * tui/tui-stack.c (tui_show_frame_info): Update.
1866         * tui/tui-layout.c (show_data): Add cast.
1867         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1868         * tui/tui-data.h (struct tui_source_window_base) <refill,
1869         set_is_exec_point_at>: New methods.
1870         (tui_source_windows, tui_add_to_source_windows): Update types.
1871         (tui_add_to_source_windows): Remove redundant declaration.
1872         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1873         (tui_source_windows): Change return type.
1874         (tui_clear_source_windows_detail): Update.
1875         (tui_add_to_source_windows): Change type of parameter.
1876         (tui_free_all_source_wins_content): Update.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-wingeneral.c (tui_win_info::refresh)
1881         (tui_source_window_base::refresh): New methods.
1882         (tui_refresh_all): Call the refresh method.
1883         * tui/tui-data.h (struct tui_win_info)
1884         (struct tui_source_window_base) <refresh>: New method.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui.h (tui_is_window_visible): Return bool.
1889         * tui/tui.c (tui_is_window_visible): Return bool.
1890         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1891         (tui_make_visible, tui_make_invisible)
1892         (tui_win_info::make_visible)
1893         (tui_source_window_base::make_visible, make_all_visible)
1894         (tui_make_all_visible, tui_make_all_invisible): Update.
1895         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1896         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1897         bool.
1898         (struct tui_win_info, struct tui_source_window_base)
1899         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1900         * tui/tui-data.c (tui_init_generic_part): Update.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1905         (tui_source_window_base::make_visible): New methods.
1906         (make_all_visible): Make method call.
1907         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1908         (struct tui_source_window_base, struct tui_cmd_window): Override
1909         make_visible.
1910         (tui_win_is_source_type): Don't declare.
1911         * tui/tui-data.c (tui_win_is_source_type): Remove.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1916         NULL check.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1921         Inline constructor.  Add initializers for members.
1922         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1923         constructors; now inline in class.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-regs.c (tui_show_registers): Update.
1928         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1929         bool.
1930         * tui/tui-data.c (tui_data_window::clear_detail)
1931         (tui_data_window): Update.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-windata.c (tui_display_all_data)
1936         (tui_display_data_from_line, tui_display_data_from)
1937         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1938         Update.
1939         * tui/tui-regs.c (tui_last_regs_line_no)
1940         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1941         (tui_show_registers, tui_show_register_group)
1942         (tui_display_registers_from, tui_display_reg_element_at_line)
1943         (tui_display_registers_from_line, tui_check_register_values)
1944         (tui_reg_next, tui_reg_prev): Update.
1945         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1946         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1947         tui_data_window.
1948         (struct tui_win_info) <detail>: Remove.  Add new fields from
1949         tui_data_info.
1950         (TUI_DATA_WIN): Add cast.
1951         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1952         (~tui_data_window): Simplify.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-layout.c (show_source_disasm_command)
1957         (show_source_or_disasm_and_command): Update.
1958         * tui/tui-io.c (update_cmdwin_start_line)
1959         (tui_redisplay_readline): Update.
1960         * tui/tui-data.h (struct tui_command_info): Remove.
1961         (struct tui_win_info) <detail>: Remove command_info member.
1962         (struct tui_data_window) <start_line>: New member, from
1963         tui_command_info.
1964         (TUI_CMD_WIN): Add casts.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.c (tui_update_source_window)
1969         (tui_refill_source_window)
1970         (tui_source_window_base::do_scroll_horizontal)
1971         (tui_update_breakpoint_info, tui_set_exec_info_content)
1972         (tui_show_exec_info_content, tui_erase_exec_info_content)
1973         (tui_clear_exec_info_content): Update.
1974         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1975         Update.
1976         * tui/tui-win.c (make_invisible_and_set_new_height)
1977         (make_visible_with_new_height): Update.
1978         * tui/tui-source.c (tui_set_source_content)
1979         (tui_show_symtab_source): Update.
1980         * tui/tui-layout.c (extract_display_start_addr)
1981         (show_source_disasm_command, show_data)
1982         (make_source_or_disasm_window)
1983         (show_source_or_disasm_and_command): Update.
1984         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1985         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1986         "gdbarch".
1987         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1988         to tui_source_window_base.
1989         (struct tui_win_info) <detail>: Remove source_info member.
1990         (struct tui_source_window_base) <has_locator>: Inline.
1991         Move contents from tui_source_info; rename has_locator member to
1992         m_has_locator.
1993         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1994         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1995         header file.
1996         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1997         Simplify.
1998         (tui_free_all_source_wins_content): Cast to
1999         tui_source_window_base.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-win.c (make_invisible_and_set_new_height)
2004         (make_visible_with_new_height): Call has_locator method.
2005         * tui/tui-layout.c (show_source_disasm_command, show_data)
2006         (show_source_or_disasm_and_command): Update for bool change.
2007         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2008         (tui_win_info) <has_locator>: New method.
2009         (struct tui_source_window_base) <has_locator>: New method.
2010         (tui_win_has_locator): Don't declare.
2011         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2012         from tui_win_has_locator.
2013         (tui_source_window_base): Use false, not FALSE.
2014
2015 2019-06-25  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2018         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2019         clear_detail method directly.
2020         (tui_clear_win_detail): Remove.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2025         "this", not TUI_DISASM_WIN.
2026
2027 2019-06-25  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2030         declare.
2031         * tui/tui-winsource.c
2032         (tui_source_window_base::do_scroll_horizontal): Rename from
2033         tui_horizontal_source_scroll.
2034         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2035         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2036         from tui_vertical_data_scroll.
2037         * tui/tui-win.h (tui_scroll): Don't declare.
2038         * tui/tui-win.c (tui_win_info::forward_scroll)
2039         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2040         (tui_win_info::right_scroll): Rename and update.
2041         (tui_scroll_forward_command, tui_scroll_backward_command)
2042         (tui_scroll_left_command, tui_scroll_right_command): Update.
2043         (tui_scroll): Remove.
2044         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2045         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2046         from tui_vertical_source_scroll.
2047         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2048         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2049         from tui_vertical_disassem_scroll.
2050         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2051         do_scroll_horizontal>: New methods.
2052         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2053         Likewise.
2054         (struct tui_source_window_base): Add do_scroll_horizontal.
2055         (struct tui_source_window, struct tui_disasm_window): Add
2056         do_scroll_vertical.
2057         (struct tui_data_window, struct tui_cmd_window): Add
2058         do_scroll_horizontal and do_scroll_vertical.
2059         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.h (struct tui_source_window_base): New struct.
2064         (struct tui_source_window): Derive from tui_source_window_base.
2065         (struct tui_disasm_window): New struct.
2066         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2067         from tui_source_window::clear_detail.
2068         (tui_source_window_base): Rename from tui_source_window.
2069         (~tui_source_window_base): Rename from ~tui_source_window.
2070         (tui_alloc_win_info): Create a tui_disasm_window.
2071
2072 2019-06-25  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-data.h (struct tui_source_window)
2075         (struct tui_data_window): Declare destructors.
2076         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2077         destructors.
2078         (tui_win_info): Simplify.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.c (tui_display_main)
2083         (tui_update_source_windows_with_addr)
2084         (tui_update_all_breakpoint_info): Update.
2085         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2086         (new_height_ok, parse_scrolling_args): Update.
2087         * tui/tui-stack.c (tui_show_frame_info): Update.
2088         * tui/tui-data.h (struct tui_list): Remove.
2089         (tui_source_windows): Return a reference to a std::vector.
2090         * tui/tui-data.c (source_windows): Now a std::vector.
2091         (tui_source_windows): Change return type.
2092         (tui_clear_source_windows): Rewrite.
2093         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2094         (tui_free_all_source_wins_content): Rewrite.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2099         (struct tui_data_window, struct tui_cmd_window): Declare
2100         clear_detail method.
2101         * tui/tui-data.c (tui_source_window::clear_detail)
2102         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2103         methods.
2104         (tui_clear_win_detail): Simplify.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-layout.c (make_source_window, make_disasm_window)
2109         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2110         Return the new window.
2111         (show_source_disasm_command, show_data)
2112         (show_source_or_disasm_and_command): Update.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2117         parameter.  Return the new window.
2118         (show_source_disasm_command): Update and remove NULL check.
2119         (show_source_or_disasm_and_command): Update.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-data.h (struct tui_win_info): Make constructor
2128         protected.  Make destructor virtual.  Add initializers.
2129         (tui_source_window, tui_data_window, tui_cmd_window): New
2130         classes.
2131         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2132         constructor.  Add "type" parameter.
2133         (tui_source_window, tui_data_window, tui_cmd_window): New
2134         constructors.
2135         (tui_alloc_win_info): Instantiate the appropriate subclass.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-win.c (tui_resize_all): Use delete.
2140         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2141         destructor.
2142         (tui_free_window): Don't declare.
2143         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2144         Update.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-data.h (struct tui_win_info): Add constructor.
2149         * tui/tui-data.c (tui_alloc_win_info): Use new.
2150         (tui_free_window): Use delete.
2151
2152 2019-06-22  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2155         declare.
2156         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2157
2158 2019-06-22  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2161         declare.
2162         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2163
2164 2019-06-22  Tom de Vries  <tdevries@suse.de>
2165
2166         * dwarf2read.c (create_addrmap_from_aranges)
2167         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2168         instead of '%zu'.
2169
2170 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2171
2172         * dwarf2read.h (dwarf2_section_info_def): Remove.
2173         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2174         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2175         std::vector<dwarf2_section_info>.
2176         (struct dwo_file) <~dwo_file>: Remove.
2177         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2178         types field.
2179         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2180         (dwarf2_read_debug_names): Likewise.
2181         (create_debug_types_hash_table): Change parameter type to
2182         array_view, adjust code accordingly.
2183         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2184         (partial_die_info::fixup): Likewise.
2185         (determine_prefix): Likewise.
2186         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2187
2188 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2191         gdb_bfd_ref_ptr.
2192         <~dwo_file>: Remove call to gdb_bfd_unref.
2193         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2194         gdb_bfd_ref_ptr::get.
2195
2196 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2197
2198         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2199         type to htab_up.
2200         * dwarf2read.c (struct dwo_file): Initialize fields.
2201         <~dwo_file>: New.
2202         (free_dwo_file): Remove, move content to ~dwo_file.
2203         (struct dwo_file_deleter): Remove.
2204         (dwo_file_up>: Remove custom deleter.
2205         (free_dwo_files): Remove.
2206         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2207         dwo_files.
2208         (process_skeletonless_type_units): Call unique_ptr::get.
2209         (allocate_dwo_file_hash_table): Add deleter to created hash
2210         table.  Change return type to htab_up.
2211         (lookup_dwo_file_slot): Don't memset dwo_file, call
2212         unique_ptr::get.
2213         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2214         (create_dwo_unit_in_dwp_v2): Likewise.
2215         (open_and_init_dwo_file): Likewise.
2216         (free_dwo_file_from_slot): Remove.
2217
2218 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2219
2220         * dwarf2read.h (struct dwarf2_section_info) <readin,
2221         is_virtual>: Change type to bool.
2222         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2223         true instead of 1.
2224
2225 2019-06-19  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-data.h (tui_init_content_element): Don't declare.
2228
2229 2019-06-19  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-data.h (tui_init_win_info): Don't declare.
2232
2233 2019-06-19  Tom de Vries  <tdevries@suse.de>
2234
2235         * dwarf2read.h (abstract_to_concrete): Change type to
2236         std::unordered_map<sect_offset, std::vector<sect_offset>,
2237         gdb::hash_enum<sect_offset>>.
2238
2239 2019-06-19  Tom Tromey  <tromey@adacore.com>
2240
2241         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2242         EVAL_AVOID_SIDE_EFFECTS specially.
2243
2244 2019-06-19  Tom Tromey  <tromey@adacore.com>
2245
2246         * source-cache.c (highlighter): New global.
2247         (source_cache::get_source_lines): Create a highlighter on demand.
2248
2249 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * defs.h (deprecated_interactive_hook): Delete declaration.
2252         * interps.c (clear_interpreter_hooks): Remove use of
2253         deprecated_interactive_hook.
2254         * top.c (deprecated_interactive_hook): Delete definition.
2255         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2256
2257 2019-06-18  Tom de Vries  <tdevries@suse.de>
2258
2259         PR gdb/24515
2260         * dwarf2read.h (abstract_to_concrete): Change type from
2261         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2262         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2263         * dwarf2read.c (read_variable): Update.
2264         (dwarf2_fetch_die_loc_sect_off): Update.
2265
2266 2019-06-17  Tom de Vries  <tdevries@suse.de>
2267
2268         PR gdb/24617
2269         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2270         accessing parent[parent_len - 1].
2271
2272 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2273
2274         PR gdb/24364
2275         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2276         call dtrace_process_dof with NULL dof.
2277
2278 2019-06-16  Tom de Vries  <tdevries@suse.de>
2279
2280         PR gdb/24445
2281         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2282
2283 2019-06-16  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2286         (make_all_visible): Use address of member.
2287
2288 2019-06-16  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2291         (tui_free_window, free_content, free_content_elements): Remove
2292         unnecessary cast.
2293         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2294         cast.
2295         * tui/tui-regs.c (tui_show_register_group)
2296         (tui_display_registers_from, tui_display_reg_element_at_line):
2297         Remove unnecessary cast.
2298
2299 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * linux-nat.c (normal_mask): Delete.
2302         (_initialize_linux_nat): Don't initialise normal_mask.
2303
2304 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2305
2306         PR gdb/24445
2307         * dwarf-index-write.h (write_psymtabs_to_index): Add
2308         dwz_basename parameter.
2309         * dwarf-index-write.c (write_gdbindex): Move file writing to
2310         write_gdbindex_1.  Change return type void.
2311         (assert_file_size): Move up, remove filename parameter.
2312         (write_gdbindex_1): New function.
2313         (write_debug_names): Change return type to void, call
2314         assert_file_size.
2315         (struct index_wip_file): New struct.
2316         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2317         file logic to index_wip_file.  Write index for dwz file if
2318         needed.
2319         (save_gdb_index_command): Pass basename of dwz file, if present.
2320         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2321         build-id of dwz file, if present.
2322         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2323         (dwarf2_get_dwz_file): Likewise.
2324         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2325         (dwarf2_get_dwz_file): Likewise.
2326
2327 2019-06-16  Tom Tromey  <tom@tromey.com>
2328
2329         * coffread.c (process_coff_symbol): Use xstrdup.
2330         * value.c (create_internalvar): Use xstrdup.
2331
2332 2019-06-16  Tom Tromey  <tom@tromey.com>
2333
2334         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2335         * breakpoint.c (stopin_command, stopat_command)
2336         (until_break_command, decode_location_default): Remove unnecessary
2337         cast.
2338         * utils.c (subset_compare): Remove unnecessary cast.
2339         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2340         cast.
2341         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2342         cast.
2343         * infcmd.c (path_command): Remove unnecessary cast.
2344         * coffread.c (decode_type): Remove unnecessary cast.
2345         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2346         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2347         * tui/tui-stack.c (tui_show_locator_content)
2348         (tui_show_frame_info): Remove unnecessary cast.
2349         * tui/tui-win.c (tui_scroll_forward_command)
2350         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2351         (parse_scrolling_args): Remove unnecessary cast.
2352         * tui/tui-data.c (init_win_info, tui_del_window)
2353         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2354         (free_content_elements): Remove unnecessary cast.
2355         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2356         unnecessary cast.
2357         * tui/tui-source.c (tui_set_source_content)
2358         (tui_vertical_source_scroll): Remove unnecessary cast.
2359         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2360         cast.
2361         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2362         * tui/tui-regs.c (tui_display_registers_from)
2363         (tui_display_register): Remove unnecessary cast.
2364         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2365         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2366         (make_visible): Remove unnecessary cast.
2367         * tui/tui-winsource.c (tui_erase_source_content)
2368         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2369         unnecessary cast.
2370         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2371         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2372         * stabsread.c (read_type, read_array_type, read_range_type):
2373         Remove unnecessary cast.
2374         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2375         (parse_symbol, parse_type, upgrade_type, parse_external)
2376         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2377         unnecessary cast.
2378         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2379
2380 2019-06-16  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-data.c (tui_alloc_generic_win_info)
2383         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2384         checks.
2385
2386 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2387             Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * f-typeprint.c (f_print_type): Don't return early for not
2390         associated or not allocated types.
2391         (f_type_print_varspec_suffix): Add print_rank parameter and print
2392         ranks of array types in case they dangling.
2393         (f_type_print_base): Add print_rank parameter.
2394
2395 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * NEWS: Mention new MI commands.
2398         * break-catch-throw.c (enum exception_event_kind): Move to
2399         breakpoint.h.
2400         (print_mention_exception_catchpoint): Output text as a single
2401         message.
2402         (catch_exception_command_1): Rename to...
2403         (catch_exception_event): ...this, make non-static, update header
2404         command, and change some parameter types.
2405         (catch_catch_command): Update for changes to
2406         catch_exception_command_1.
2407         (catch_throw_command): Likewise.
2408         (catch_rethrow_command): Likewise.
2409         * breakpoint.c (enum exception_event_kind): Delete.
2410         * breakpoint.h (enum exception_event_kind): Moved here from
2411         break-catch-throw.c.
2412         (catch_exception_event): Declare.
2413         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2414         (mi_cmd_catch_throw): New function.
2415         (mi_cmd_catch_rethrow): New function.
2416         (mi_cmd_catch_catch): New function.
2417         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2418         'catch-catch' entries.
2419         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2420         (mi_cmd_catch_rethrow): Declare.
2421         (mi_cmd_catch_catch): Declare.
2422
2423 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * annotate.c (annotate_source_line): Change return type to void,
2426         update implementation to match.
2427         * annotate.h (annotate_source_line): Change return type to void,
2428         update header comment.
2429         * stack.c (print_frame_info): Don't change what frame information
2430         is printed based on whether annotations are on or not.
2431
2432 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2435         (annotate_source): Make static.
2436         (annotate_source_line): Moved from source.c and renamed from
2437         identify_source_line.  Update the return type.
2438         * annotate.h (annotate_source): Delete declaration.
2439         (annotate_source_line): Declaration moved from source.h, and
2440         renamed from identify_source_line.  Return type updated.
2441         * source.c (identify_source_line): Moved to annotate.c and renamed
2442         to annotate_source_line.
2443         (info_line_command): Remove check of annotation_level.
2444         * source.h (identify_source_line): Move declaration to annotate.h
2445         and rename to annotate_source_line.
2446         * stack.c: Add 'annotate.h' include.
2447         (print_frame_info): Remove check of annotation_level before
2448         calling annotate_source_line.
2449
2450 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * source-cache.c (source_cache::get_plain_source_lines): Use
2453         open_source_file_with_line_charpos instead of just
2454         open_source_file, remove call to find_source_lines.
2455         (source_cache::get_source_lines): Likewise.
2456         * source.c (find_source_lines): Make static.
2457         (get_filename_and_charpos): Renamed into...
2458         (open_source_file_with_line_charpos): ..this along with changes to
2459         return a scoped_fd, and some other minor clean ups.
2460         (identify_source_line): Use open_source_file_with_line_charpos.
2461         (search_command_helper): Use open_source_file_with_line_charpos
2462         instead of just open_source_file, remove call to
2463         find_source_lines.
2464         * source.h (open_source_file_with_line_charpos): Declare new
2465         function.
2466         (find_source_lines): Delete declaration.
2467
2468 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * source.c (get_filename_and_charpos): Remove fullname
2471         parameter.
2472         (identify_source_line): Update call to get_filename_and_charpos.
2473
2474 2019-06-14  Tom Tromey  <tromey@adacore.com>
2475
2476         PR gdb/24502:
2477         * ui-style.h (skip_ansi_escape): Update comment.
2478         * ui-file.h (class no_terminal_escape_file): New class.
2479         * ui-file.c (no_terminal_escape_file::write)
2480         (no_terminal_escape_file::puts): New methods.
2481         * cli/cli-logging.c (handle_redirections): Use
2482         no_terminal_escape_file.
2483
2484 2019-06-14  Tom Tromey  <tromey@adacore.com>
2485
2486         * NEWS: Move convenience variable news above Python news.
2487
2488 2019-06-14  Tom Tromey  <tom@tromey.com>
2489
2490         * gnulib: Move directory to top-level.
2491         * configure.ac: Don't configure gnulib.
2492         * configure: Rebuild.
2493         * common/common-defs.h: Use new path to gnulib.
2494         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2495         (GNULIB_H): Remove.
2496         (INCGNU): Look in new gnulib location.
2497         (HFILES_NO_SRCDIR): Remove gnulib files.
2498         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2499         (generated_files): Remove GNULIB_H.
2500         ($(LIBGNU), all-lib): Remove targets.
2501         (distclean): Don't mention GNULIB_BUILDDIR.
2502         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2503
2504 2019-06-14  Tom Tromey  <tromey@adacore.com>
2505
2506         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2507         Warn if symbol file does not provide any symbols.
2508
2509 2019-06-14  Tom Tromey  <tromey@adacore.com>
2510
2511         * source.c (find_and_open_source): Respect basenames_may_differ.
2512
2513 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * annotate.c (annotate_breakpoints_invalid): Make use of
2516         scoped_restore_terminal_state.
2517         (annotate_frames_invalid): Likewise.
2518
2519 2019-06-14  Tom Tromey  <tromey@adacore.com>
2520
2521         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2522         allow assignment to an internalvar.
2523
2524 2019-06-14  Tom Tromey  <tromey@adacore.com>
2525
2526         * ada-lex.l: Allow "_" in attribute names.
2527
2528 2019-06-14  Tom Tromey  <tromey@adacore.com>
2529
2530         PR gdb/24653:
2531         * regcache.c (registers_changed): Don't call alloca.
2532         * top.c (execute_command): Don't call alloca.
2533
2534 2019-06-13  Pedro Alves  <palves@redhat.com>
2535
2536         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2537         'expression'.  When parsing an expression, error out if there's
2538         junk after "unlimited".
2539         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2540         (do_set_command): Adjust calls to is_unlimited_literal.
2541
2542 2019-06-13  Pedro Alves  <palves@redhat.com>
2543
2544         * compile/compile.c (make_compile_options_def_group): Add braces
2545         around array_view initializer.
2546         * thread.c (make_thread_apply_all_options_def_group)
2547         (make_thread_apply_all_options_def_group): Likewise.
2548
2549 2019-06-13  Pedro Alves  <palves@redhat.com>
2550
2551         * NEWS (New commands): Mention "maint test-options
2552         require-delimiter", "maint test-options unknown-is-error", "maint
2553         test-options unknown-is-operand" and "maint show
2554         test-options-completion-result".
2555         (New command options, command completion): New section.
2556         (Completion improvements): New section.
2557         Mention that you can abbreviate "unlimited".
2558
2559 2019-06-13  Pedro Alves  <palves@redhat.com>
2560
2561         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2562         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2563         * unittests/cli-utils-selftests.c (test_parse_flags)
2564         (test_parse_flags_qcs): Delete.
2565         (test_cli_utils): Don't call deleted functions.
2566
2567 2019-06-13  Pedro Alves  <palves@redhat.com>
2568
2569         * thread.c: Include "cli/cli-option.h".
2570         (tp_array_compar_ascending): Global.
2571         (tp_array_compar): Delete function.
2572         (tp_array_compar_ascending, tp_array_compar_descending): New
2573         functions.
2574         (ascending_option_def, qcs_flag_option_def)
2575         (thr_qcs_flags_option_defs)
2576         (make_thread_apply_all_options_def_group)
2577         (make_thread_apply_options_def_group): New.
2578         (thread_apply_all_command): Use gdb::option::process_options.
2579         (thread_apply_command_completer)
2580         (thread_apply_all_command_completer): New.
2581         (thread_apply_command): Use gdb::option::process_options.
2582         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2583         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2584         to generate help text of "thread apply".  Adjust "taas"'s help.
2585         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2586         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2587
2588 2019-06-13  Pedro Alves  <palves@redhat.com>
2589
2590         * thread.c (thread_apply_command): Check for invalid TID with
2591         isdigit instead of !isalpha.
2592
2593 2019-06-13  Pedro Alves  <palves@redhat.com>
2594
2595         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2596         (validate_flags_qcs): New.
2597         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2598         (validate_flags_qcs): Declare.
2599         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2600         (make_frame_apply_options_def_group): New.
2601         (frame_apply_command_count): Process options with
2602         gdb::option::process_options.
2603         (frame_apply_completer): New.
2604         (frame_apply_level_completer, frame_apply_all_completer)
2605         (frame_apply_completer): New.
2606         (_initialize_stack): Update help of "frame apply", "frame apply
2607         level", "frame apply all" and "faas" to mention supported options
2608         and install command completers.
2609         * stack.h (frame_apply_all_completer): Declare.
2610         * thread.c: Include "stack.h".
2611         (tfaas_command): Add "--".
2612         (_initialize_thread): Update help "tfaas" to mention supported
2613         options and install command completer.
2614
2615 2019-06-13  Pedro Alves  <palves@redhat.com>
2616
2617         * completer.c (complete_nested_command_line): New.
2618         (gdb_completion_word_break_characters_throw): Add assertion.
2619         * completer.h (complete_nested_command_line): Declare.
2620
2621 2019-06-13  Pedro Alves  <palves@redhat.com>
2622
2623         * stack.c (parse_backtrace_qualifiers): New.
2624         (backtrace_command): Use it.
2625         (backtrace_command_completer): Complete on qualifiers.
2626
2627 2019-06-13  Pedro Alves  <palves@redhat.com>
2628
2629         * frame.c: Include "cli/cli-option.h.
2630         (user_set_backtrace_options): New.
2631         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2632         Delete.
2633         (get_prev_frame): Adjust.
2634         (boolean_option_def, uinteger_option_def)
2635         (set_backtrace_option_defs): New.
2636         (_initialize_frame): Adjust and use
2637         gdb::option::add_setshow_cmds_for_options to install "set
2638         backtrace past-main" and "set backtrace past-entry".
2639         * frame.h: Include "cli/cli-option.h".
2640         (struct frame_print_options): Forward declare.
2641         (print_frame_arguments_all, print_frame_arguments_scalars)
2642         (print_frame_arguments_none): Declare.
2643         (print_entry_values): Delete declaration.
2644         (struct frame_print_options, user_frame_print_options): New.
2645         (struct set_backtrace_options): New.
2646         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2647         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2648         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2649         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2650         (list_args_or_locals): Add frame_print_options parameter.
2651         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2652         * python/py-framefilter.c (enumerate_args): Pass down
2653         USER_FRAME_PRINT_OPTIONS.
2654         * stack.c: Include "cli/cli-option.h".
2655         (print_frame_arguments_all, print_frame_arguments_scalars)
2656         (print_frame_arguments_none): Declare.
2657         (print_raw_frame_arguments, print_entry_values): Delete.
2658         (user_frame_print_options): New.
2659         (boolean_option_def, enum_option_def, frame_print_option_defs):
2660         New.
2661         (struct backtrace_cmd_options): New.
2662         (bt_flag_option_def): New.
2663         (backtrace_command_option_defs): New.
2664         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2665         (print_frame_arg, read_frame_arg, print_frame_args)
2666         (print_frame_info, print_frame): Add frame_print_options parameter
2667         and use it.
2668         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2669         (backtrace_command_1): Add frame_print_options and
2670         backtrace_cmd_options parameters and use them.
2671         (make_backtrace_options_def_group): New.
2672         (backtrace_command): Process command options with
2673         gdb::option::process_options.
2674         (backtrace_command_completer): New.
2675         (_initialize_stack): Extend "backtrace"'s help to mention
2676         supported options.  Install completer for "backtrace".
2677         Install some settings commands with add_setshow_cmds_for_options.
2678
2679 2019-06-13  Pedro Alves  <palves@redhat.com>
2680
2681         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2682         and that "set/show print raw frame-arguments" are now deprecated.
2683
2684         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2685         command.
2686         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2687         * stack.c (_initialize_stack): Install "set/show print
2688         raw-frame-arguments", and deprecate "set/show print raw
2689         frame-arguments".
2690         * valprint.c (_initialize_valprint): Deprecate "set/show print
2691         raw".
2692
2693 2019-06-13  Pedro Alves  <palves@redhat.com>
2694
2695         * compile/compile.c (struct compile_options): New.
2696         (compile_flag_option_def, compile_command_option_defs)
2697         (make_compile_options_def_group): New.
2698         (compile_file_command): Handle options with
2699         gdb::option::process_options.
2700         (compile_file_command_completer): New function.
2701         (compile_code_command): Handle options with
2702         gdb::option::process_options.
2703         (compile_code_command_completer): New function.
2704         (_initialize_compiler): Install completers for "compile code" and
2705         "compile file".  Mention available options in "compile code" and
2706         "compile code"'s help.
2707         * completer.c (advance_to_completion_word): New, factored out from
2708         ...
2709         (advance_to_expression_complete_word_point): ... this.
2710         (advance_to_filename_complete_word_point): New.
2711         * completer.h (advance_to_filename_complete_word_point): New
2712         declaration.
2713
2714 2019-06-13  Pedro Alves  <palves@redhat.com>
2715
2716         * compile/compile.c: Include "cli/cli-option.h".
2717         (compile_print_value): Scope data pointer is now a
2718         value_print_options pointer; adjust.
2719         (compile_print_command): Process options.  Scope data pointer is
2720         now a value_print_options pointer; adjust.
2721         (_initialize_compile): Update "compile print"'s help to include
2722         supported options.  Install a completer for "compile print".
2723         * cp-valprint.c (show_vtblprint, show_objectprint)
2724         (show_static_field_print): Delete.
2725         (_initialize_cp_valprint): Don't install "set print
2726         static-members", "set print vtbl", "set print object" here.
2727         * printcmd.c: Include "cli/cli-option.h" and
2728         "common/gdb_optional.h".
2729         (print_command_parse_format): Rework to fill in a
2730         value_print_options instead of a format_data.
2731         (print_value): Change parameter type from format_data pointer to
2732         value_print_options reference.  Adjust.
2733         (print_command_1): Process options.  Adjust to pass down a
2734         value_print_options.
2735         (print_command_completer): New.
2736         (_initialize_printcmd): Install print_command_completer as
2737         handle_brkchars completer for the "print" command.  Update
2738         "print"'s help to include supported options.
2739         * valprint.c: Include "cli/cli-option.h".
2740         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2741         here from cp-valprint.c.
2742         (boolean_option_def, uinteger_option_def)
2743         (value_print_option_defs, make_value_print_options_def_group):
2744         New.  Use gdb::option::add_setshow_cmds_for_options to install
2745         "set print elements", "set print null-stop", "set print repeats",
2746         "set print pretty", "set print union", "set print array", "set
2747         print address", "set print symbol", "set print array-indexes".
2748         * valprint.h: Include <string> and "cli/cli-option.h".
2749         (make_value_print_options_def_group): Declare.
2750         (print_value): Change parameter type from format_data pointer to
2751         value_print_options reference.
2752         (print_command_completer): Declare.
2753
2754 2019-06-13  Pedro Alves  <palves@redhat.com>
2755
2756         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2757         (COMMON_SFILES): Add maint-test-settings.c.
2758         * cli/cli-decode.c (boolean_enums): New global, factored out from
2759         ...
2760         (add_setshow_boolean_cmd): ... here.
2761         * cli/cli-decode.h (boolean_enums): Declare.
2762         * cli/cli-option.c: New file.
2763         * cli/cli-option.h: New file.
2764         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2765         factored out from ...
2766         (parse_cli_boolean_value(const char *)): ... this.
2767         (is_unlimited_literal): Change parameter type to pointer to
2768         pointer.  Adjust and advance ARG pointer.
2769         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2770         (parse_cli_var_enum): New, factored out from ...
2771         (do_set_command): ... this.  Adjust.
2772         * cli/cli-setshow.h (parse_cli_boolean_value)
2773         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2774         (parse_cli_var_enum): Declare.
2775         * cli/cli-utils.c: Include "cli/cli-option.h".
2776         (get_ulongest): New.
2777         * cli/cli-utils.h (get_ulongest): Declare.
2778         (check_for_argument): New overloads.
2779         * maint-test-options.c: New file.
2780
2781 2019-06-13  Pedro Alves  <palves@redhat.com>
2782
2783         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2784         parse a range if "-" is at the end of the string.
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * cli/cli-setshow.c (parse_auto_binary_operation)
2789         (parse_cli_boolean_value): Don't allow "o".
2790
2791 2019-06-13  Pedro Alves  <palves@redhat.com>
2792
2793         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2794         * NEWS: Mention maint test-settings KIND.
2795         * maint-test-settings.c: New file.
2796
2797 2019-06-13  Pedro Alves  <palves@redhat.com>
2798
2799         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2800         completer.
2801         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2802         "set" completers.
2803
2804 2019-06-13  Pedro Alves  <palves@redhat.com>
2805
2806         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2807         after item.
2808
2809 2019-06-13  Pedro Alves  <palves@redhat.com>
2810
2811         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2812
2813 2019-06-13  Pedro Alves <palves@redhat.com>
2814
2815         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2816         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2817         call.
2818         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2819         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2820         calls.
2821         (check_for_argument): Skip spaces after argument.
2822
2823 2019-06-13  Pedro Alves  <palves@redhat.com>
2824
2825         * thread.c (thread_apply_command): Adjust TID parsing.
2826         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2827         detected before end of string.
2828         (tid_is_in_list): Error out if LIST is invalid.
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * completer.c (complete_line_internal_1): Rewind completion word
2833         point.
2834         (completion_tracker::advance_custom_word_point_by): Change
2835         parameter type to int.
2836         * completer.h (completion_tracker::advance_custom_word_point_by):
2837         Likewise.
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * completer.c (advance_to_completion_word): Handle delimiters.
2842
2843 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2844
2845         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2846
2847 2019-06-11  Tom Tromey  <tom@tromey.com>
2848
2849         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2850         (xmalloc_failed): Move to alloc.c.
2851         * alloc.c: New file.
2852         * Makefile.in (COMMON_SFILES): Add alloc.c.
2853
2854 2019-06-11  Tom Tromey  <tom@tromey.com>
2855
2856         * nat/linux-waitpid.c: Don't include server.h.
2857         (linux_debug): Remove.
2858         (my_waitpid): Update.
2859
2860 2019-06-11  Tom Tromey  <tromey@adacore.com>
2861
2862         * infcall.c (_initialize_infcall): Remove trailing newline from
2863         help.
2864         * user-regs.c (_initialize_user_regs): Remove trailing newline
2865         from help.
2866         * typeprint.c (_initialize_typeprint): Remove trailing newline
2867         from help.
2868         * reverse.c (_initialize_reverse): Remove trailing newlines from
2869         help.
2870         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2871         from help.
2872         * language.c (add_set_language_command): Remove trailing newline
2873         from help.
2874         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2875         help.
2876         * disasm.c (_initialize_disasm): Remove trailing newline from
2877         help.
2878         * top.c (init_main): Remove trailing newline from help.
2879         * interps.c (_initialize_interpreter): Remove trailing newline
2880         from help.
2881         * btrace.c (_initialize_btrace): Remove trailing newlines from
2882         help.
2883         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2884         from help.
2885         * python/python.c (_initialize_python): Remove trailing newline
2886         from help.
2887         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2888         help.
2889         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2890         from help.  Reformat some text.
2891         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2892         from help.
2893         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2894         newline from help.
2895
2896 2019-06-11  Tom Tromey  <tromey@adacore.com>
2897
2898         * darwin-nat.c (darwin_decode_exception_message)
2899         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2900
2901 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * valops.c (value_slice): Check for not allocated or not
2904         associated values.
2905
2906 2019-06-10  Tom de Vries  <tdevries@suse.de>
2907
2908         PR gdb/24618
2909         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2910         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2911         invalid.
2912
2913 2019-06-10  Tom de Vries  <tdevries@suse.de>
2914
2915         PR gdb/24611
2916         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2917         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2918
2919 2019-06-10  Tom de Vries  <tdevries@suse.de>
2920
2921         PR symtab/24545
2922         * symtab.c (struct demangled_name_entry): Add language field.
2923         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2924         static minimal symbol".  Set and use language field.
2925
2926 2019-06-10  Tom Tromey  <tromey@adacore.com>
2927
2928         * ada-lang.c (_initialize_ada_language): Update help text.
2929
2930 2019-06-10  Tom Tromey  <tromey@adacore.com>
2931
2932         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2933         with a newline.
2934         * guile/guile.c (handle_boot_error): Don't end warning with a
2935         newline.
2936         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2937         warning with a newline.
2938         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2939         newline.
2940         (s12z_frame_cache): Likewise.
2941         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2942         a newline.
2943         * solib-svr4.c (disable_probes_interface): Don't end warning with
2944         a newline.
2945         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2946         newline.
2947         * python/python.c (do_finish_initialization): Don't end warning
2948         with a newline.
2949
2950 2019-06-10  Tom Tromey  <tom@tromey.com>
2951
2952         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2953         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2954         gdbpy_enter.
2955
2956 2019-06-10  Tom Tromey  <tromey@adacore.com>
2957
2958         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2959         data.
2960         (elf_new_init): Don't call stabsread_new_init.
2961         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2962         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2963         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2964
2965 2019-06-10  Tom de Vries  <tdevries@suse.de>
2966
2967         PR symtab/16264
2968         PR symtab/24517
2969         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2970
2971 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2972
2973         * source.c (find_and_open_source): Also rewrite relative file
2974         names.
2975
2976 2019-04-26  Amos Bird  <amosbird@gmail.com>
2977
2978         * annotate.c (annotate_thread_exited): Add "thread-exited"
2979         annotation.
2980
2981 2019-06-06  Tom Tromey  <tromey@adacore.com>
2982
2983         * maint.h (class scoped_command_stats): Use
2984         DISABLE_COPY_AND_ASSIGN.
2985         <print_time>: New method.
2986         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2987         print_time.
2988         (scoped_command_stats::print_time): New method.
2989
2990 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2993         instructions of lengths 6 or 8 bytes.
2994
2995 2019-06-04  Pedro Alves  <palves@redhat.com>
2996
2997         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2998
2999         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3000         * breakpoint.c (condition_completer): Likewise.
3001         * cli/cli-dump.c (scan_expression): Likewise.
3002         * common/filestuff.c (mkdir_recursive): Likewise.
3003         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3004         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3005         (gdb_abspath): Likewise.
3006         * compile/compile-cplus-types.c
3007         (compile_cplus_instance::decl_name): Likewise.
3008         * completer.c (complete_explicit_location):
3009         (signal_completer, reg_or_group_completer_1): Likewise.
3010         * cp-support.c (cp_remove_params_if_any): Likewise.
3011         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3012         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3013         * infcmd.c (strip_bg_char): Likewise.
3014         * linespec.c (copy_token_string): Likewise.
3015         * mi/mi-main.c (output_cores): Likewise.
3016         * psymtab.c (psymtab_search_name):
3017         * symfile.c (test_set_ext_lang_command): Likewise.
3018         * target.c (target_fileio_read_stralloc): Likewise.
3019         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3020         * value.c (complete_internalvar): Likewise.
3021
3022 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3023
3024         Add objfile property to gdb.Type.
3025         * NEWS: Mention Python API addition.
3026         * python/py-type.c (typy_get_objfile): New method.
3027
3028 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3029
3030         * NEWS: Mention the new set|show style [title|highlight].
3031         Mention changes to "show style", "help" and "apropos".
3032
3033 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3034
3035         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3036         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3037         instead of print_help_for_command.
3038         (print_doc_of_command): New function.
3039         (help_list): Add 'apropos -v word' suggestion.
3040         (print_help_for_command): Style the command name using title style.
3041         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3042         (_initialize_cli_cmds): Describe -v in apropos_command help.
3043
3044 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3045
3046         * cli/cli-style.h (cli_style_option): Add name in constructor,
3047         add m_name class member, add constructor with intensity,
3048         add name class function.
3049         (cli_style_option::add_setshow_commands): Remove name argument.
3050         (highlight_style, title_style): New styles.
3051         * cli/cli-style.c (do_show): New function that shows a style
3052         characteristic styling the style name with itself.
3053         (set_style_name): New function.
3054         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3055         Update all callers according to the changes in cli/cli-style.h.
3056         * utils.h (fputs_highlighted): New function.
3057         * utils.c (fputs_highlighted): Likewise.
3058
3059 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3060
3061         * NEWS: Mention new pipe command and new convenience variables.
3062
3063 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3064
3065         * cli/cli-cmds.c (pipe_command): New function.
3066         (_initialize_cli_cmds): Call add_com for pipe_command.
3067         Define | as an alias for pipe.
3068         (exit_status_set_internal_vars): New function.
3069         (shell_escape): Call exit_status_set_internal_vars.
3070         cli/cli-decode.c (find_command_name_length): Recognize | as
3071         a single character command.
3072
3073 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3074
3075         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3076         top.c (execute_command_to_ui_file): New function, mostly a copy
3077         of execute_command_to_string.
3078         (execute_command_to_string): Implement by calling
3079         execute_command_to_ui_file.
3080
3081 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3082
3083         * top.h (saved_command_line): Remove declaration.
3084         * top.c (previous_saved_command_line, previous_repeat_arguments):
3085         New variables.
3086         (saved_command_line): Make static, define together with other
3087         'repeat variables'.
3088         (dont_repeat): Clear repeat_arguments.
3089         (repeat_previous, get_saved_command_line, save_command_line):
3090         New functions.
3091         (gdb_init): Initialize saved_command_line
3092         and previous_saved_command_line.
3093         * main.c (captured_main_1): Remove saved_command_line initialization.
3094         * event-top.c (handle_line_of_input): Update to use
3095         the new 'repeat' related functions instead of direct access to
3096         saved_command_line.
3097         * command.h (repeat_previous, get_saved_command_line,
3098         save_command_line): New declarations.
3099         (dont_repeat): Add comment.
3100
3101 2019-05-30  Tom Tromey  <tromey@adacore.com>
3102
3103         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3104         Fix comment.
3105         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3106
3107 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3108
3109         PR cli/24587
3110         * completer.c (complete): Initialize variable word.
3111
3112 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3113
3114         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3115         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3116         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3117         'body' is NULL to the outter 'if', protecting the '!is_define'
3118         situation as well.
3119
3120 2019-05-29  Tom Tromey  <tromey@adacore.com>
3121
3122         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3123         (dwarf_unknown): New function.
3124         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3125         (dwarf_type_encoding_name): Use dwarf_unknown.
3126
3127 2019-05-29  Tom Tromey  <tromey@adacore.com>
3128
3129         PR c++/20020:
3130         * cp-valprint.c (cp_print_value_fields): Call
3131         cp_print_static_field inside "try".
3132
3133 2019-05-29  Tom Tromey  <tromey@adacore.com>
3134
3135         * inflow.c (struct terminal_info): Add default operator=.
3136         * configure: Rebuild.
3137         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3138         -Wdeprecated-copy-dtor, -Wredundant-move.
3139
3140 2019-05-29  Tom Tromey  <tromey@adacore.com>
3141
3142         * NEWS: Add entry.
3143         * infcmd.c (print_return_value_1): Handle finish_print
3144         option.
3145         (show_print_finish): New function.
3146         (_initialize_infcmd): Add "set/show print finish" commands.
3147         * valprint.c (user_print_options): Initialize new member.
3148         * valprint.h (struct value_print_options) <finish_print>: New
3149         member.
3150
3151 2019-05-28  Tom Tromey  <tromey@adacore.com>
3152
3153         * ada-lang.c (ada_remove_Xbn_suffix)
3154         (find_old_style_renaming_symbol)
3155         (parse_old_style_renaming): Remove.
3156         (ada_find_renaming_symbol): Don't call
3157         find_old_style_renaming_symbol.
3158         (ada_is_renaming_symbol): Rename from
3159         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3160         bool.  Now static.
3161         (ada_read_var_value): Update and simplify.
3162         * ada-exp.y (write_var_or_type): Remove old code.
3163
3164 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3165
3166         * event-top.c: Remove include comment.
3167         * inflow.c (class scoped_ignore_sigttou): Move from here...
3168         * inflow.h (class scoped_ignore_sigttou): ...to here.
3169         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3170         * top.c:  Remove include comment.
3171
3172 2019-05-27  Tom Tromey  <tom@tromey.com>
3173
3174         * NEWS: Fix typo.
3175
3176 2019-05-22  Tom Tromey  <tromey@adacore.com>
3177
3178         * target.c (target_follow_exec): Constify parameter.
3179         * target-delegates.c: Rebuild.
3180         * remote.c (remote_target::follow_exec): Constify parameter.
3181         * infrun.c (follow_exec): Constify parameter.
3182         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3183         (target_follow_exec): Likewise.
3184
3185 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3188         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3189
3190 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3191
3192         * NEWS: Add debugredirect and testsuite sections.
3193
3194 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3195
3196         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3197         target descriptions using exclusively floating point register name
3198         aliases.
3199
3200 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         PR gdb/18644:
3203         * f-lang.c (build_fortran_types): Handle the case where
3204         gdbarch_floatformat_for_type returns a nullptr.
3205
3206 2019-05-21  Tom de Vries  <tdevries@suse.de>
3207
3208         PR cli/24587
3209         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3210
3211 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         PR gdb/18644:
3214         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3215         16-byte floats.
3216         * i386-tdep.c (i386_floatformat_for_type): Use
3217         floatformats_ia64_quad for the 16-byte floating point component
3218         within a fortran 32-byte complex number.
3219
3220 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3221
3222         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3223         delete default constructor.
3224         (find_partial_die): Update to return const struct.
3225         (partial_die_parent_scope): Move variable declaration into scope
3226         of its use and change its type to auto.
3227         (guess_partial_die_structure_name): Likewise.
3228         (partial_die_info::fixup): Likewise.
3229
3230 2019-05-17  Tom Tromey  <tromey@adacore.com>
3231
3232         * source.c (find_and_open_source): Remove cast.
3233
3234 2019-05-17  Tom Tromey  <tromey@adacore.com>
3235
3236         * annotate.c (annotate_source): Make "filename" const.
3237         * annotate.h (annotate_source): Use const.
3238
3239 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3240
3241         * disasm.c (set_disassembler_options): Send errors to stderr.
3242
3243 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3246         (cli_interp_base::set_logging): Check debug_redirect.
3247         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3248         * cli/cli-logging.c (debug_redirect): Add static variable.
3249         (pop_output_files): Add default param.
3250         (handle_redirections): Print debug setting.
3251         (show_logging_command): Likewise.
3252         (_initialize_cli_logging): Add debugredirect command.
3253         * interps.c (current_interp_set_logging): Add debug_redirect
3254         parameter.
3255         * interps.h (set_logging): Add debug_redirect parameter.
3256         (current_interp_set_logging): Likewise.
3257         * mi/mi-common.h: Likewise.
3258         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3259
3260 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3261             Tom Tromey  <tromey@adacore.com>
3262
3263         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3264         directly.
3265         * cli/cli-interp.h (make_logging_output): Remove declaration.
3266         * cli/cli-logging.c (make_logging_output): Remove function.
3267         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3268         directly.
3269         * ui-file.c (tee_file::tee_file): Remove bools.
3270         (tee_file::~tee_file): Remove deletes.
3271         * ui-file.h (tee_file): Remove bools.
3272
3273 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3274
3275         * mi/mi-cmds.h (mi_cmd_complete): New function.
3276         * mi/mi-main.c (mi_cmd_complete): Likewise.
3277         * mi/mi-cmds.c: Define new MI command -complete.
3278         * NEWS: Mention new -complete command.
3279
3280 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3281
3282         * completer.h (complete): New function.
3283         * completer.c (complete): Likewise.
3284         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3285         function defined in completer.h.
3286
3287 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3288
3289         * MAINTAINERS (Write After Approval): Add myself.
3290
3291 2019-05-17  Tom de Vries  <tdevries@suse.de>
3292
3293         PR gdb/24094
3294         * dwarf2read.c (struct cu_partial_die_info): New struct.
3295         (find_partial_die): Return cu_partial_die_info.
3296         (partial_die_parent_scope, guess_partial_die_structure_name)
3297         (partial_die_info::fixup): Handle new return type of find_partial_die.
3298
3299 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3300
3301         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3302         "std::string", simplifying the algorithm.
3303
3304 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3305
3306         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3307         (stap_static_probe_ops::get_probes): Likewise.
3308
3309 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3310
3311         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3312         '-')" and "else if".
3313         (stap_parse_single_operand): Join checks for
3314         "gdbarch_stap_parse_special_token_p" and
3315         "gdbarch_stap_parse_special_token" in the same "if" statement.
3316         Invert check when verifying for operation on register
3317         displacement.
3318
3319 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3320
3321         * stap-probe.c (stap_get_opcode): Update comment.
3322         (stap_get_expected_argument_type): Likewise.
3323         (handle_stap_probe): Likewise.
3324
3325 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3326
3327         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3328         return type to 'bool'.  Adjust comment.  Use 'bool' when
3329         appropriate.
3330         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3331         * stap-probe.c (stap_parse_argument_1): Likewise.
3332         (stap_is_operator): Likewise.
3333         (stap_is_generic_prefix): Likewise.
3334         (stap_is_register_prefix): Likewise.
3335         (stap_is_register_indirection_prefix): Likewise.
3336         (stap_is_integer_prefix): Likewise.
3337         (stap_generic_check_suffix): Likewise.
3338         (stap_check_integer_suffix): Likewise.
3339         (stap_check_register_suffix): Likewise.
3340         (stap_check_register_indirection_suffix): Likewise.
3341         (stap_parse_register_operand): Likewise.
3342         (stap_parse_single_operand): Likewise.
3343         (stap_parse_argument_1): Likewise.
3344         (stap_probe::get_argument_count): Likewise.
3345         (stap_is_operator): Likewise.
3346
3347 2019-05-16  Tom Tromey  <tromey@adacore.com>
3348
3349         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3350         keyword to foreach.
3351
3352 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3353
3354         * linux-thread-db.c (try_thread_db_load_1): Change return type
3355         to bool.
3356         (try_thread_db_load): Likewise.
3357         (try_thread_db_load_from_pdir_1): Likewise.
3358         (try_thread_db_load_from_pdir): Likewise.
3359         (try_thread_db_load_from_sdir): Likewise.
3360         (try_thread_db_load_from_dir): Likewise.
3361         (thread_db_load_search): Likewise.
3362         (has_libpthread): Likewise.
3363         (thread_db_load): Likewise.
3364
3365 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3366
3367         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3368         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3369         NULL, and complain/return if that's the case.
3370
3371 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3372
3373         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3374         (advance, posn, abstract_read_memory): New functions.
3375         [struct mem_read_abstraction]: New struct.
3376         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3377
3378 2019-05-14  Tom Tromey  <tromey@adacore.com>
3379
3380         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3381         value is not lval_memory.
3382
3383 2019-05-14  Tom Tromey  <tromey@adacore.com>
3384
3385         * solib.c (info_sharedlibrary_command): Style the file name.
3386
3387 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3388
3389         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3390         (aarch64_vnv_type): Likewise.
3391         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3392         * common/tdesc.c: Likewise.
3393         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3394         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3395         * features/aarch64-fpu.xml: Add ieee half view.
3396         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3397         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3398         * gdbtypes.h (struct builtin_type): Likewise.
3399         (struct objfile_type): Likewise.
3400
3401 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3402
3403         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3404         typo.
3405         * location.h (string_to_event_location): Likewise.
3406
3407 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3408
3409         GDB 8.3 released.
3410
3411 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3412
3413         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3414         New variable declaration.
3415         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3416         New variable.
3417         (print_one_breakpoint): Use ui_out::test_flags and new global
3418         variable to compute use_fixed_output.
3419         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3420         Remove.
3421         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3422         (mi_multi_location_breakpoint_output_fixed): Remove.
3423         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3424         new variable.
3425         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3426         fix_multi_location_breakpoint_output flag if version >= 3.
3427         * ui-out.h (enum ui_out_flag)
3428         <fix_multi_location_breakpoint_output>: New enumerator.
3429
3430 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3431
3432         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3433
3434 2019-05-10  Tom Tromey  <tromey@adacore.com>
3435
3436         * ada-lang.c (catch_ada_completer): New function.
3437         (_initialize_ada_language): Use it.
3438
3439 2019-05-10  Tom Tromey  <tromey@adacore.com>
3440
3441         * thread.c (print_thread_info): Make "requested_threads" const.
3442         * gdbthread.h (print_thread_info): Make "requested_threads"
3443         const.
3444         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3445         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3446
3447 2019-05-08  Tom Tromey  <tom@tromey.com>
3448
3449         * gdbtypes.c (objfile_type_data): Change type.
3450         (objfile_type, _initialize_gdbtypes): Update.
3451
3452 2019-05-08  Tom Tromey  <tom@tromey.com>
3453
3454         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3455         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3456         (_initialize_dwarf2_frame): Update.
3457
3458 2019-05-08  Tom Tromey  <tom@tromey.com>
3459
3460         * objc-lang.c (objc_objfile_data): Change type.
3461         (find_methods): Update.
3462         (_initialize_objc_lang): Remove.
3463
3464 2019-05-08  Tom Tromey  <tom@tromey.com>
3465
3466         * stabsread.c (rs6000_builtin_type_data): Change type.
3467         (rs6000_builtin_type, _initialize_stabsread): Update.
3468
3469 2019-05-08  Tom Tromey  <tom@tromey.com>
3470
3471         * mips-tdep.c (mips_pdr_data): Remove.
3472         (_initialize_mips_tdep): Update.
3473
3474 2019-05-08  Tom Tromey  <tom@tromey.com>
3475
3476         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3477         (hppa_init_objfile_priv_data, read_unwind_info)
3478         (find_unwind_entry, _initialize_hppa_tdep): Update.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3483         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3484         on obstack.
3485         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3486
3487 2019-05-08  Tom Tromey  <tom@tromey.com>
3488
3489         * mdebugread.c (basic_type_data): Change type.
3490         (basic_type, _initialize_mdebugread): Update.
3491
3492 2019-05-08  Tom Tromey  <tom@tromey.com>
3493
3494         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3495
3496 2019-05-08  Tom Tromey  <tom@tromey.com>
3497
3498         * nto-tdep.c (nto_inferior_data_reg): Change type.
3499         (nto_inferior_data): Update.
3500         (nto_inferior_data_cleanup, nto_new_inferior_data)
3501         (_initialize_nto_tdep): Remove.
3502         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3503
3504 2019-05-08  Tom Tromey  <tom@tromey.com>
3505
3506         * ada-lang.c (struct ada_inferior_data): Add initializers.
3507         (ada_inferior_data): Change type.
3508         (ada_inferior_data_cleanup): Remove.
3509         (get_ada_inferior_data, ada_inferior_exit)
3510         (struct ada_pspace_data): Add initializers, destructor.
3511         (ada_pspace_data_handle): Change type.
3512         (get_ada_pspace_data): Update.
3513         (ada_pspace_data_cleanup): Remove.
3514
3515 2019-05-08  Tom Tromey  <tom@tromey.com>
3516
3517         * coffread.c (struct coff_symfile_info): Add initializers.
3518         (coff_objfile_data_key): Move lower.  Change type.
3519         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3520         Update.
3521         (coff_free_info): Remove.
3522
3523 2019-05-08  Tom Tromey  <tom@tromey.com>
3524
3525         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3526         (fbsd_pspace_data_handle): Move lower.  Change type.
3527         (get_fbsd_pspace_data): Update.
3528         (fbsd_pspace_data_cleanup): Remove.
3529         (_initialize_fbsd_tdep): Update.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3534         (get_ada_tasks_pspace_data): Update.
3535         (ada_tasks_pspace_data_cleanup): Remove.
3536         (_initialize_tasks): Update.
3537         (ada_tasks_inferior_data_handle): Change type.
3538         (get_ada_tasks_inferior_data): Update.
3539         (ada_tasks_inferior_data_cleanup): Remove.
3540         (struct ada_tasks_pspace_data): Add initializers.
3541
3542 2019-05-08  Tom Tromey  <tom@tromey.com>
3543
3544         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3545         * symfile-debug.c (debug_sym_get_probes): Change type.
3546         * stap-probe.c (handle_stap_probe):
3547         (stap_static_probe_ops::get_probes): Change type.
3548         * probe.h (class static_probe_ops) <get_probes>: Change type.
3549         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3550         (parse_probes_in_pspace): Update.
3551         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3552         Update.
3553         (any_static_probe_ops::get_probes): Change type.
3554         * elfread.c (elfread_data): New typedef.
3555         (probe_key): Change type.
3556         (elf_get_probes): Likewise.  Update.
3557         (probe_key_free): Remove.
3558         (_initialize_elfread): Update.
3559         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3560         Change type.
3561         (dtrace_process_dof_probe, dtrace_process_dof)
3562         (dtrace_static_probe_ops::get_probe): Change type.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * xcoffread.c (struct xcoff_symfile_info): Rename from
3567         coff_symfile_info.  Add initializers.
3568         (xcoff_objfile_data_key): Move lower.  Change type.
3569         (XCOFF_DATA): Rewrite.
3570         (xcoff_free_info): Remove.
3571         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3572         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3573         (xcoff_initial_scan): Update.
3574
3575 2019-05-08  Tom Tromey  <tom@tromey.com>
3576
3577         * solib-svr4.c (struct svr4_info): Add initializers and
3578         destructor.
3579         <probes_table>: Now an htab_up.
3580         (solib_svr4_pspace_data): Change type.
3581         (free_probes_table): Simplify.
3582         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3583         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3584         (probes_table_remove_objfile_probes, register_solib_event_probe)
3585         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3586         (_initialize_svr4_solib): Update.
3587
3588 2019-05-08  Tom Tromey  <tom@tromey.com>
3589
3590         * remote.c (remote_pspace_data): Change type.
3591         (remote_pspace_data_cleanup): Remove.
3592         (get_remote_exec_file, set_pspace_remote_exec_file)
3593         (_initialize_remote): Update.
3594
3595 2019-05-08  Tom Tromey  <tom@tromey.com>
3596
3597         * breakpoint.c (breakpoint_objfile_key): Change type.
3598         (get_breakpoint_objfile_data): Update.
3599         (free_breakpoint_objfile_data): Remove.
3600         (_initialize_breakpoint): Update.
3601
3602 2019-05-08  Tom Tromey  <tom@tromey.com>
3603
3604         * linux-tdep.c (struct linux_info): Add initializers.
3605         (linux_inferior_data): Move.  Change type.
3606         (invalidate_linux_cache_inf): Update.
3607         (linux_inferior_data_cleanup): Remove.
3608         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3609
3610 2019-05-08  Tom Tromey  <tom@tromey.com>
3611
3612         * auxv.c (auxv_inferior_data): Move.  Change type.
3613         (auxv_inferior_data_cleanup): Remove.
3614         (invalidate_auxv_cache_inf): Rewrite.
3615         (get_auxv_inferior_data, _initialize_auxv): Update.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3620         (symfile_debug_objfile_data_key): Change type.
3621         (symfile_debug_installed, debug_qf_has_symbols)
3622         (debug_qf_find_last_source_symtab)
3623         (debug_qf_forget_cached_source_info)
3624         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3625         (debug_qf_print_stats, debug_qf_dump)
3626         (debug_qf_expand_symtabs_for_function)
3627         (debug_qf_expand_all_symtabs)
3628         (debug_qf_expand_symtabs_with_fullname)
3629         (debug_qf_map_matching_symbols)
3630         (debug_qf_expand_symtabs_matching)
3631         (debug_qf_find_pc_sect_compunit_symtab)
3632         (debug_qf_map_symbol_filenames)
3633         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3634         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3635         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3636         (debug_sym_read_linetable, debug_sym_relocate): Update.
3637         (symfile_debug_free_objfile): Remove.
3638         (install_symfile_debug_logging, _initialize_symfile_debug):
3639         Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3644         allocate_on_obstack.
3645         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3646         (get_dwarf2_per_objfile): Update.
3647         (set_dwarf2_per_objfile): Remove.
3648         (dwarf2_has_info, dwarf2_get_section_info): Update.
3649         (dwarf2_free_objfile): Remove.
3650         (_initialize_dwarf2_read): Update.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3655         initializers.
3656         <unsupported_script_warning_printed,
3657         script_not_found_warning_printed>: Now bool.
3658         (auto_load_pspace_data): Change type.
3659         (~auto_load_pspace_info): Rename from
3660         auto_load_pspace_data_cleanup.
3661         (get_auto_load_pspace_data, init_loaded_scripts_info)
3662         (clear_section_scripts, maybe_print_unsupported_script_warning)
3663         (maybe_print_script_not_found_warning, _initialize_auto_load):
3664         Update.
3665
3666 2019-05-08  Tom Tromey  <tom@tromey.com>
3667
3668         * objfiles.c (objfile_pspace_info): Add destructor and
3669         initializers.
3670         (objfiles_pspace_data): Change type.
3671         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3672         (get_objfile_pspace_data): Update.
3673         (objfiles_bfd_data): Change type.
3674         (get_objfile_bfd_data): Update.
3675         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3676
3677 2019-05-08  Tom Tromey  <tom@tromey.com>
3678
3679         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3680         Change type.
3681         (get_catch_syscall_inferior_data): Update.
3682         (catch_syscall_inferior_data_cleanup): Remove.
3683         (_initialize_break_catch_syscall): Update.
3684
3685 2019-05-08  Tom Tromey  <tom@tromey.com>
3686
3687         * inflow.c (struct terminal_info): Add destructor and
3688         initializers.
3689         (inflow_inferior_data): Change type.
3690         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3691         (get_inflow_inferior_data, inflow_inferior_exit)
3692         (swap_terminal_info, _initialize_inflow): Update.
3693
3694 2019-05-08  Tom Tromey  <tom@tromey.com>
3695
3696         * target-dcache.c (target_dcache_cleanup): Remove.
3697         (target_dcache_aspace_key): Change type.
3698         (target_dcache_init_p, target_dcache_invalidate)
3699         (target_dcache_get, target_dcache_get_or_init)
3700         (_initialize_target_dcache): Update.
3701         * dcache.h (struct dcache_deleter): New.
3702
3703 2019-05-08  Tom Tromey  <tom@tromey.com>
3704
3705         * symtab.c (struct symbol_cache): Add destructor and
3706         initializers.
3707         (symbol_cache_key): Move.  Change type.
3708         (make_symbol_cache, free_symbol_cache): Remove.
3709         (get_symbol_cache): Update.
3710         (symbol_cache_cleanup): Remove.
3711         (ALL_PSPACES, symbol_cache_flush)
3712         (maintenance_print_symbol_cache)
3713         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3714         Update.
3715
3716 2019-05-08  Tom Tromey  <tom@tromey.com>
3717
3718         * symtab.c (struct main_info): Add destructor and initializers.
3719         (main_progspace_key): Move.  Change type.
3720         (get_main_info): Update.
3721         (main_info_cleanup): Remove.
3722         (_initialize_symtab): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * registry.h (DECLARE_REGISTRY): Define the _key class.
3727
3728 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * NEWS: Merge two 'New commands' sections.
3731
3732 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3733
3734         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3735         parameter and use Ada language definition instead.
3736         (ada_val_print_ptr): Remove unused language parameter.
3737         (ada_val_print_num): Remove language parameter and use Ada language
3738         definition instead.
3739         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3740         parameter.
3741         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3742         parameter and use Ada language definition instead.
3743         (ada_val_print_1): Update all ada_val_print_xxx calls.
3744         Remove language parameter.
3745         (ada_val_print): Update ada_val_print_1 call.
3746
3747 2019-05-08  Tom Tromey  <tromey@adacore.com>
3748
3749         * remote.c (remote_hw_watchpoint_limit)
3750         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3751         Now static.
3752
3753 2019-05-08  Tom Tromey  <tromey@adacore.com>
3754
3755         * maint.c (_initialize_maint_cmds): Move initialization code to
3756         remote.c.
3757         (watchdog, show_watchdog): Move to remote.c.
3758         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3759         "watchdog" static.
3760         (_initialize_remote): Move initialization code from maint.c.
3761         * defs.h (watchdog): Don't declare.
3762
3763 2019-05-08  Tom Tromey  <tromey@adacore.com>
3764
3765         * tui/tui-interp.c: Include main.h.
3766         * interps.c: Include main.h.
3767         * main.h (interpreter_p): Declare.
3768         * defs.h (interpreter_p): Don't declare.
3769
3770 2019-05-08  Tom Tromey  <tromey@adacore.com>
3771
3772         * dwarf2loc.c: Include dwarf2read.h.
3773         * defs.h (read_unsigned_leb128): Don't declare.
3774         * dwarf2read.h (read_unsigned_leb128): Declare.
3775
3776 2019-05-08  Tom Tromey  <tromey@adacore.com>
3777
3778         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3779         method.
3780
3781 2019-05-08  Tom Tromey  <tromey@adacore.com>
3782
3783         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3784         when no wrap column is set.
3785
3786 2019-05-08  Tom Tromey  <tromey@adacore.com>
3787
3788         * c-lang.c (c_get_string): Handle non-C-style arrays.
3789
3790 2019-05-08  Tom Tromey  <tromey@adacore.com>
3791
3792         * typeprint.c (print_offset_data::update): Print the bit offset,
3793         not the number of bits remaining.
3794
3795 2019-05-08  Tom Tromey  <tromey@adacore.com>
3796
3797         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3798         padding at end of comment.
3799
3800 2019-05-08  Tom Tromey  <tromey@adacore.com>
3801
3802         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3803         Compare main types.
3804
3805 2019-05-06  Tom Tromey  <tom@tromey.com>
3806
3807         * common/scoped_mmap.c: Include common-defs.h.
3808         * common/scoped_mmap.h: Don't include config.h.
3809
3810 2019-05-04  Tom Tromey  <tom@tromey.com>
3811
3812         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3813         (struct aarch64_call_info): Add initializers.
3814         <si>: Now a std::vector.
3815         (pass_on_stack, aarch64_push_dummy_call): Update.
3816
3817 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3818             Tom Tromey  <tom@tromey.com>
3819
3820         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3821         (ppc_threads): Now a std::vector.  Now static.
3822         (hwdebug_find_thread_points_by_tid)
3823         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3824         Update.
3825
3826 2019-05-04  Tom Tromey  <tom@tromey.com>
3827
3828         * arc-tdep.c (arc_tdesc_init): Return bool.
3829
3830 2019-05-04  Tom Tromey  <tom@tromey.com>
3831
3832         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3833         Use gdb_assert_not_reached.
3834
3835 2019-05-04  Tom Tromey  <tom@tromey.com>
3836
3837         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3838         "false".
3839
3840 2019-05-04  Tom Tromey  <tom@tromey.com>
3841
3842         * arc-tdep.c (arc_tdesc_init): Use bool.
3843
3844 2019-05-04  Tom Tromey  <tom@tromey.com>
3845
3846         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3847
3848 2019-05-04  Tom Tromey  <tom@tromey.com>
3849
3850         * cli/cli-cmds.c (valid_command_p): Return bool.
3851
3852 2019-05-04  Tom Tromey  <tom@tromey.com>
3853
3854         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3855         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3856
3857 2019-05-04  Raul Tambre  <raul@tambre.ee>
3858
3859         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3860         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3861         operator for comparison.
3862
3863 2019-05-04  Tom Tromey  <tom@tromey.com>
3864
3865         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3866         (lookup_partial_symbol, print_partial_symbols)
3867         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3868         (psymbol_compare): Update.
3869         (add_psymbol_to_bcache): Clear the entire psymbol.
3870         (maintenance_check_psymtabs): Update.
3871         * psympriv.h (struct partial_symbol): Don't derive from
3872         general_symbol_info.
3873         <obj_section, unrelocated_address, address,
3874         set_unrelocated_address>: Update.
3875         <ginfo>: New member.
3876         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3877         (debug_names::write_psymbols): Update.
3878
3879 2019-05-04  Tom de Vries  <tdevries@suse.de>
3880
3881         * contrib/cc-with-tweaks.sh: Support -n arg.
3882
3883 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3884
3885         * corelow.c (core_target::detach): Ensure frame cache and
3886         register caches are cleared.
3887         inferior.c (exit_inferior_1): Likewise.
3888
3889 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3890             Tom Tromey  <tom@tromey.com>
3891
3892         * dictionary.c (collate_pending_symbols_by_language): Remove
3893         "struct" from foreach.
3894         * symtab.c (lookup_global_symbol_from_objfile)
3895         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3896         foreach.
3897         * ser-tcp.c (net_open): Remove "struct" from foreach.
3898         * objfiles.c (objfile_relocate, objfile_rebase)
3899         (objfile_has_symbols): Remove "struct" from foreach.
3900         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3901         from foreach.
3902         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3903         foreach.
3904         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3905         "struct" from foreach.
3906         * ada-lang.c (create_excep_cond_exprs)
3907         (ada_exception_catchpoint_cond_string): Remove "struct" from
3908         foreach.
3909
3910 2019-05-03  Tom Tromey  <tromey@adacore.com>
3911
3912         * ada-exp.y (convert_char_literal): Check suffix of each
3913         enumerator.
3914
3915 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3916
3917         PR ada/21406:
3918         * ada-exp.y (yywrap): Don't define.
3919         * ada-lex.l (%option): Add noyywrap
3920         (yywrap): Remove.
3921
3922 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3923
3924         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3925         _WIN32_WINNT to the XP level, unless already defined to a higher
3926         level.
3927
3928         * unittests/parse-connection-spec-selftests.c:
3929         * ser-tcp.c:
3930         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3931         override.
3932
3933         * symfile.c (find_separate_debug_file): Remove colon from the
3934         drive spec of DOS/Windows file names of the target, so that the
3935         file name produced from DEBUGDIR and the target's directory will
3936         be valid on DOS/Windows systems.
3937
3938 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * rust-lang.c (val_print_struct): Handle printing structures
3941         containing strings.
3942
3943 2019-05-02  Tom Tromey  <tromey@adacore.com>
3944
3945         * valarith.c (_initialize_valarith): Remove.
3946
3947 2019-05-01  Tom Tromey  <tromey@adacore.com>
3948
3949         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3950         bitfields.
3951
3952 2019-05-01  Tom Tromey  <tromey@adacore.com>
3953
3954         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3955         for big-endian copies.
3956
3957 2019-04-30  Ali Tamur  <tamur@google.com>
3958         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3959         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3960         (read_3_bytes): New function.
3961
3962 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3963
3964         * windows-nat.c (main_thread_id): Delete.
3965         (handle_output_debug_string): Replace main_thread_id by
3966         current_event.dwThreadId.
3967         (fake_create_process): Likewise.
3968         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3969         Do not set main_thread_id.
3970         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3971         current_event.dwThreadId.
3972         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3973
3974 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3975
3976         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3977         Use current_event.dwThreadId instead of main_thread_id.
3978
3979 2019-04-30  Tom Tromey  <tromey@adacore.com>
3980
3981         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3982         (create_excep_cond_exprs): Iterate over program spaces.
3983         (ada_exception_catchpoint_cond_string): Examine all minimal
3984         symbols for exception types.
3985
3986 2019-04-30  Tom Tromey  <tromey@adacore.com>
3987
3988         PR c++/24470:
3989         * dwarf2read.c (process_structure_scope): Handle case where type
3990         has template parameters but no symbol was created.
3991
3992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3993             Chris January  <chris.january@arm.com>
3994
3995         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3996         qualifier.
3997         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3998
3999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * f-typeprint.c (f_print_type): Update rules for printing
4002         whitespace.
4003         (f_type_print_varspec_suffix): Likewise.
4004
4005 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4006             Chris January  <chris.january@arm.com>
4007
4008         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4009         function arguments.
4010
4011 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * f-lang.c (build_fortran_types): Change name of void type to
4014         lower case.
4015         * f-typeprint.c (f_type_print_base): Print the name of the void
4016         type, rather than a fixed string.
4017         * f-valprint.c (f_decorations): Use lower case void string.
4018
4019 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4020             Chris January  <chris.january@arm.com>
4021
4022         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4023         types for Fortran.
4024
4025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4026             Chris January  <chris.january@arm.com>
4027             David Lecomber  <david.lecomber@arm.com>
4028
4029         * f-exp.y (BINOP_INTRINSIC): New token.
4030         (exp): New parser rule handling BINOP_INTRINSIC.
4031         (f77_keywords): Add new builtin procedures.
4032         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4033         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4034         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4035         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4036         (print_unop_subexp_f): New function.
4037         (print_binop_subexp_f): New function.
4038         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4039         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4040         (dump_subexp_body_f): Likewise.
4041         (operator_check_f): Likewise.
4042         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4043         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4044
4045 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4048         UNOP_KIND.
4049         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4050         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4051         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4052         (operator_length_f): New fuction.
4053         (print_subexp_f): New function.
4054         (op_name_f): New function.
4055         (dump_subexp_body_f): New function.
4056         (operator_check_f): New function.
4057         (exp_descriptor_f): Replace standard expression handling functions
4058         with new functions.
4059         * gdb/fortran-operator.def: New file.
4060         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4061         * gdb/std-operator.def: Remove UNOP_KIND.
4062
4063 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * std-operator.def: Remove unbalanced, stray double quote
4066         character.
4067
4068 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4069             Chris January  <chris.january@arm.com>
4070             Daniel Everett  <daniel.everett@arm.com>
4071             Nick Forrington  <nick.forrington@arm.com>
4072             Richard Bunt  <richard.bunt@arm.com>
4073
4074         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4075         of depth when printing anonymous structs or unions.
4076         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4077         Don't print either the top-level value, or the children if the
4078         max-depth is exceeded.
4079         (ppscm_print_children): When printing the key of a map, allow one
4080         extra level of depth.
4081         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4082         print either the top-level value, or the children if the max-depth
4083         is exceeded.
4084         (print_children): When printing the key of a map, allow one extra
4085         level of depth.
4086         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4087         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4088         (user_print_options): Initialise max_depth field.
4089         (val_print_scalar_or_string_type_p): New function.
4090         (val_print): Check to see if the max depth has been reached.
4091         (val_print_check_max_depth): Define new function.
4092         (show_print_max_depth): New function.
4093         (_initialize_valprint): Add 'print max-depth' option.
4094         * valprint.h (struct value_print_options) <max_depth>: New field.
4095         (val_print_check_max_depth): Declare new function.
4096         * NEWS: Document new feature.
4097
4098 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * ada-lang.c (ada_language_defn): Initialise new field.
4101         * c-lang.c (c_is_string_type_p): New function.
4102         (c_language_defn): Initialise new field.
4103         (cplus_language_defn): Initialise new field.
4104         (asm_language_defn): Initialise new field.
4105         (minimal_language_defn): Initialise new field.
4106         * c-lang.h (c_is_string_type_p): Declare new function.
4107         * d-lang.c (d_language_defn): Initialise new field.
4108         * f-lang.c (f_is_string_type_p): New function.
4109         (f_language_defn): Initialise new field.
4110         * go-lang.c (go_is_string_type_p): New function.
4111         (go_language_defn): Initialise new field.
4112         * language.c (default_is_string_type_p): New function.
4113         (unknown_language_defn): Initialise new field.
4114         (auto_language_defn): Initialise new field.
4115         * language.h (struct language_defn) <la_is_string_type_p>: New
4116         member variable.
4117         (default_is_string_type_p): Declare new function.
4118         * m2-lang.c (m2_language_defn): Initialise new field.
4119         * objc-lang.c (objc_language_defn): Initialise new field.
4120         * opencl-lang.c (opencl_language_defn): Initialise new field.
4121         * p-lang.c (pascal_is_string_type_p): New function.
4122         (pascal_language_defn): Initialise new field.
4123         * rust-lang.c (rust_is_string_type_p): New function.
4124         (rust_language_defn): Initialise new field.
4125
4126 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4129         New field.
4130         * ada-lang.c (ada_language_defn): Initialise new field.
4131         * c-lang.c (c_language_defn): Likewise.
4132         (cplus_language_defn): Likewise.
4133         (asm_language_defn): Likewise.
4134         (minimal_language_defn): Likewise.
4135         * d-lang.c (d_language_defn): Likewise.
4136         * f-lang.c (f_language_defn): Likewise.
4137         * go-lang.c (go_language_defn): Likewise.
4138         * language.c (unknown_language_defn): Likewise.
4139         (auto_language_defn): Likewise.
4140         * m2-lang.c (m2_language_defn): Likewise.
4141         * objc-lang.c (objc_language_defn): Likewise.
4142         * opencl-lang.c (opencl_language_defn): Likewise.
4143         * p-lang.c (pascal_language_defn): Likewise.
4144         * rust-lang.c (rust_language_defn): Likewise.
4145
4146 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * ada-lang.c (ada_is_character_type): Change return type to bool.
4149         (ada_is_string_type): Likewise.
4150         * ada-lang.h (ada_is_character_type): Update declaration
4151         (ada_is_string_type): Likewise.
4152
4153 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4154
4155         Support style in 'frame|thread apply'
4156
4157         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4158         * record.c (record_start, record_stop): Update callers of
4159         execute_command_to_string with false.
4160         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4161         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4162         methods.
4163         (class string_file): New constructor with term_out parameter.
4164         Override methods term_out and can_emit_style_escape.  New member
4165         term_out.
4166         (class stdio_file): Override can_emit_style_escape.
4167         (class tee_file): Override term_out and can_emit_style_escape.
4168         * utils.h (can_emit_style_escape): Remove.
4169         * utils.c (can_emit_style_escape): Likewise.
4170         Update all callers of can_emit_style_escape (SOMESTREAM) to
4171         SOMESTREAM->can_emit_style_escape.
4172         * source-cache.c (source_cache::get_source_lines): Likewise.
4173         * stack.c (frame_apply_command_count): Call execute_command_to_string
4174         passing the term_out characteristic of the current gdb_stdout.
4175         * thread.c (thr_try_catch_cmd): Likewise.
4176         * top.c (execute_command_to_string): pass term_out parameter
4177         to construct the string_file for the command output.
4178         * ui-file.c (term_cli_styling): New function (most code moved
4179         from utils.c can_emit_style_escape).
4180         (string_file::string_file, string_file::can_emit_style_escape,
4181         stdio_file::can_emit_style_escape, tee_file::term_out,
4182         tee_file::can_emit_style_escape): New functions.
4183
4184 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4185
4186         * NEWS: Mention the new set|show may-call-functions.
4187         * infcall.c (may_call_functions_p): New variable.
4188         (show_may_call_functions_p): New function.
4189         (call_function_by_hand_dummy): Throws an error if not
4190         may-call-functions.
4191         (_initialize_infcall): Call add_setshow_boolean_cmd for
4192         may-call-functions.
4193
4194 2019-04-25  Keith Seitz  <keiths@redhat.com>
4195
4196         PR c++/24367
4197         * cp-support.c (inspect_type): Don't attempt substitutions
4198         of symbol with the same name.
4199
4200 2019-04-25  Tom Tromey  <tromey@adacore.com>
4201
4202         PR gdb/24475:
4203         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4204         static.
4205
4206 2019-04-25  Tom Tromey  <tromey@adacore.com>
4207
4208         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4209         rvalue reference.
4210         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4211         (gdb_xml_parser::parse): Use std::move.
4212         * python/python-internal.h (gdbpy_convert_exception): Take a const
4213         reference.
4214         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4215         std::move.
4216         * python/py-utils.c (gdbpy_convert_exception): Take a const
4217         reference.
4218         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4219         Use std::move.
4220         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4221         Use std::move.
4222         * mi/mi-main.c (mi_print_exception): Take a const reference.
4223         * main.c (handle_command_errors): Take a const reference.
4224         * linespec.c (parse_linespec): Use std::move.
4225         * infcall.c (run_inferior_call): Use std::move.
4226         (call_function_by_hand_dummy): Use std::move.
4227         * exec.c (try_open_exec_file): Use std::move.
4228         * exceptions.h (exception_print, exception_fprintf)
4229         (exception_print_same): Update.
4230         * exceptions.c (print_exception, exception_print)
4231         (exception_fprintf, exception_print_same): Change parameters to
4232         const reference.
4233         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4234         * common/new-op.c: Use std::move.
4235         * common/common-exceptions.h (struct gdb_exception): Add move
4236         constructor.
4237         (struct gdb_exception_error, struct gdb_exception_quit, struct
4238         gdb_quit_bad_alloc): Change constructor to move constructor.
4239         (throw_exception): Change parameter to rvalue reference.
4240         * common/common-exceptions.c (throw_exception): Take rvalue
4241         reference.
4242         * cli/cli-interp.c (safe_execute_command): Use std::move.
4243         * breakpoint.c (insert_bp_location, location_to_sals): Use
4244         std::move.
4245
4246 2019-04-25  Tom Tromey  <tromey@adacore.com>
4247
4248         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4249         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4250         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4251         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4252         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4253         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4254         guile/scm-value.c: Use unpack.
4255         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4256         gdbscm_gdb_exception.
4257         (gdbscm_throw_gdb_exception): Likewise.
4258         (struct gdbscm_gdb_exception): New.
4259         (unpack): New function.
4260         (gdbscm_wrap): Use unpack.
4261
4262 2019-04-25  Tom Tromey  <tromey@adacore.com>
4263
4264         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4265         (gdb_rl_callback_handler): Use std::move.
4266         * common/common-exceptions.h (struct gdb_exception): Add move
4267         assignment operator.
4268         (throw_exception_sjlj): Change "exception" to const reference.
4269         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4270         (throw_exception_sjlj): Change "exception" to const reference.
4271
4272 2019-04-25  Tom Tromey  <tromey@adacore.com>
4273
4274         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4275         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4276         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4277         Update.
4278         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4279         Update.
4280         * mi/mi-interp.c (mi_interp::exec): Update.
4281         * linespec.c (parse_linespec): Update.
4282         * infcall.c (run_inferior_call): Update.
4283         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4284         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4285         (gdbscm_lookup_global_symbol): Update.
4286         * guile/scm-param.c (gdbscm_parameter_value): Update.
4287         * guile/scm-frame.c (gdbscm_frame_read_register)
4288         (gdbscm_frame_read_var): Update.
4289         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4290         * exec.c (try_open_exec_file): Update.
4291         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4292         (gdb_rl_callback_handler): Update.
4293         * common/common-exceptions.h (exception_none): Don't declare.
4294         * common/common-exceptions.c (exception_none): Don't define.
4295         (struct catcher) <exception>: Update.
4296         * cli/cli-interp.c (safe_execute_command): Update.
4297         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4298
4299 2019-04-25  Ali Tamur  <tamur@google.com>
4300
4301         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4302         (read_attribute_value): Likewise.
4303         (dwarf2_read_addr_index): Update comment.
4304         (read_str_index): Add DW_FORM_strx.
4305         (dwarf2_string_attr): Likewise.
4306         (dwarf2_const_value_attr): Likewise.
4307         (dump_die_shallow): Likewise.
4308         (dwarf2_fetch_constant_bytes): Likewise.
4309         (skip_form_bytes): Likewise.
4310         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4311
4312 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4313
4314         PR corefiles/11608
4315         PR corefiles/18187
4316         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4317         OFFSET.  Verify if current mapping contains an ELF header.
4318         (linux_find_memory_regions_full): Adjust call to
4319         dump_mapping_p.
4320
4321 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4322             Kang Li <kanglictf@gmail.com>
4323
4324         PR gdb/21600
4325
4326         * dwarf2-frame.c (read_initial_length): Be consistent about using
4327         unsigned representation of length.
4328         (decode_frame_entry_1): Likewise.  Check for wraparound of
4329         end pointer as well as buffer overflow.
4330
4331 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4332
4333         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4334         "vq".
4335
4336 2019-04-24  Tom Tromey  <tromey@adacore.com>
4337
4338         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4339
4340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4341
4342         * s12z-tdep.c (s12z_unwind_pc): Delete.
4343         (s12z_unwind_sp): Delete.
4344         (s12z_gdbarch_init): Don't register deleted functions with
4345         gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * rl78-tdep.c (rl78_unwind_sp): Delete.
4350         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4351
4352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4353
4354         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4355         (xstormy16_unwind_pc): Delete.
4356         (xstormy16_dummy_id): Delete.
4357         (xstormy16_gdbarch_init): Don't register deleted functions with
4358         gdbarch.
4359
4360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * vax-tdep.c (vax_unwind_pc): Delete.
4363         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4364
4365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * v850-tdep.c (v850_unwind_sp): Delete.
4368         (v850_unwind_pc): Delete.
4369         (v850_dummy_id): Delete.
4370         (v850_gdbarch_init): Don't register deleted functions with
4371         gdbarch.
4372
4373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4376         (tilegx_unwind_pc): Delete.
4377         (tilegx_unwind_dummy_id): Delete.
4378         (tilegx_gdbarch_init): Don't register deleted functions with
4379         gdbarch.
4380
4381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4384         (tic6x_dummy_id): Delete.
4385         (tic6x_gdbarch_init): Don't register deleted functions with
4386         gdbarch.
4387
4388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4389
4390         * sparc-tdep.c (sparc_unwind_pc): Delete.
4391         (sparc32_gdbarch_init): Don't register deleted function with
4392         gdbarch.
4393
4394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * sh-tdep.c (sh_unwind_sp): Delete.
4397         (sh_unwind_pc): Delete.
4398         (sh_dummy_id): Delete.
4399         (sh_gdbarch_init): Don't register deleted functions with
4400         gdbarch.
4401
4402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4403
4404         * score-tdep.c (score_unwind_sp): Delete.
4405         (score_unwind_pc): Delete.
4406         (score_dummy_id): Delete.
4407         (score_gdbarch_init): Don't register deleted functions with
4408         gdbarch.
4409
4410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4411
4412         * rx-tdep.c (rx_unwind_pc): Delete.
4413         (rx_unwind_sp): Delete.
4414         (rx_dummy_id): Delete.
4415         (rx_gdbarch_init): Don't register deleted functions with
4416         gdbarch.  Update comment.
4417
4418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4419
4420         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4421         (rs6000_dummy_id): Delete.
4422         (rs6000_gdbarch_init): Don't register deleted functions with
4423         gdbarch.
4424
4425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * or1k-tdep.c (or1k_dummy_id): Delete.
4428         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4429
4430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4431
4432         * nios2-tdep.c (nios2_dummy_id): Delete.
4433         (nios2_unwind_sp): Delete.
4434         (nios2_gdbarch_init): Don't register deleted functions with
4435         gdbarch.
4436
4437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * nds32-tdep.c (nds32_dummy_id): Delete.
4440         (nds32_unwind_pc): Delete.
4441         (nds32_unwind_sp): Delete.
4442         (nds32_gdbarch_init): Don't register deleted functions with
4443         gdbarch.
4444
4445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4446
4447         * msp430-tdep.c (msp430_unwind_pc): Delete.
4448         (msp430_unwind_sp): Delete.
4449         (msp430_dummy_id): Delete.
4450         (msp430_gdbarch_init): Don't register deleted functions with
4451         gdbarch.
4452
4453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * moxie-tdep.c (moxie_unwind_sp): Delete.
4456         (moxie_unwind_pc): Delete.
4457         (moxie_dummy_id): Delete.
4458         (moxie_gdbarch_init): Don't register deleted functions with
4459         gdbarch.
4460
4461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4464         (mn10300_unwind_pc): Delete.
4465         (mn10300_unwind_sp): Delete.
4466         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4467         mn10300_unwind_sp.
4468         (mn10300_frame_unwind_init): Don't register deleted functions with
4469         gdbarch.
4470
4471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * mep-tdep.c (mep_unwind_pc): Delete.
4474         (mep_unwind_sp): Delete.
4475         (mep_dummy_id): Delete.
4476         (mep_gdbarch_init): Don't register deleted functions with
4477         gdbarch.
4478
4479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4482         (m68hc11_unwind_sp): Delete.
4483         (m68hc11_gdbarch_init): Don't register deleted functions with
4484         gdbarch.
4485
4486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * m32r-tdep.c (m32r_unwind_sp): Delete.
4489         (m32r_unwind_pc): Delete.
4490         (m32r_dummy_id): Delete.
4491         (m32r_gdbarch_init): Don't register deleted functions with
4492         gdbarch.
4493
4494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * m32c-tdep.c (m32c_unwind_pc): Delete.
4497         (m32c_unwind_sp): Delete.
4498         (m32c_dummy_id): Delete.
4499         (m32c_gdbarch_init): Don't register deleted functions with
4500         gdbarch.
4501
4502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4505         (lm32_unwind_pc): Delete.
4506         (lm32_dummy_id): Delete.
4507         (lm32_gdbarch_init): Don't register deleted functions with
4508         gdbarch.
4509
4510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4513         (iq2000_unwind_pc): Delete.
4514         (iq2000_dummy_id): Delete.
4515         (iq2000_gdbarch_init): Don't register deleted functions with
4516         gdbarch.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * nds32-tdep.c (nds32_type_align): Delete.
4521         (nds32_push_dummy_call): Use type_align instead.
4522
4523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * arm-tdep.c (arm_type_align): Only handle vector override case.
4526         (arm_push_dummy_call): Use type_align.
4527         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4528
4529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4532         case.
4533         (pass_on_stack): Use type_align.
4534         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4535         function.
4536
4537 2019-04-23  Tom Tromey  <tromey@adacore.com>
4538
4539         * dwarf2read.c (line_header::file_name_at): Remove unused
4540         overload.
4541
4542 2019-04-23  Tom de Vries  <tdevries@suse.de>
4543
4544         PR gdb/24438
4545         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4546         invocation.
4547
4548
4549 2019-03-27  Ali Tamur  <tamur@google.com>
4550
4551         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4552         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4553         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4554         (dwarf_expr_context::get_addr_index): Likewise
4555         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4556         (symbol_needs_eval_context::get_addr_index): Likewise
4557         (disassemble_dwarf_expression): Add DW_OP_addrx
4558         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4559         (read_cutu_die_from_dwo): Update comment
4560         (skip_one_die): Add DW_FORM_addrx
4561         (read_attribute_value): Likewise
4562         (var_decode_location): Add DW_OP_addrx
4563         (dwarf2_const_value_attr): Add DW_FORM_addrx
4564         (dump_die_shallow): Likewise
4565         (dwarf2_fetch_constant_bytes): Likewise
4566         (decode_locdesc): Add DW_OP_addrx
4567         (skip_form_bytes): Add DW_FORM_addrx
4568
4569 2019-04-22  Ali Tamur  <tamur@google.com>
4570
4571         * MAINTAINERS (Write After Approval): Add self.
4572
4573 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4574
4575         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4576         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4577         (open_symbol_file_object): Likewise.
4578         (svr4_default_sos): Add info parameter.
4579         (svr4_read_so_list): Likewise.
4580         (svr4_current_sos_direct): Adjust functions calls to pass down
4581         info.
4582         (svr4_current_sos_1): Add info parameter.
4583         (svr4_current_sos): Call get_svr4_info, pass info down to
4584         svr4_current_sos_1.
4585         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4586         get_svr4_info.
4587         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4588         get_svr4_info.
4589         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4590         to get_svr4_info.
4591         (probes_table_remove_objfile_probes): Likewise.
4592         (register_solib_event_probe): Add info parameter.
4593         (solist_update_incremental): Pass info parameter down to
4594         svr4_read_so_list.
4595         (disable_probes_interface): Add info parameter.
4596         (svr4_handle_solib_event): Pass current_program_space to
4597         get_svr4_info.  Adjust disable_probes_interface cleanup.
4598         (svr4_create_probe_breakpoints): Add info parameter, pass it
4599         down to register_solib_event_probe.
4600         (svr4_create_solib_event_breakpoints): Add info parameter,
4601         pass it down to svr4_create_probe_breakpoints.
4602         (enable_break): Pass info down to
4603         svr4_create_solib_event_breakpoints.
4604         (svr4_solib_create_inferior_hook): Pass current_program_space to
4605         get_svr4_info.
4606         (svr4_clear_solib): Likewise.
4607
4608 2019-04-22  Pedro Alves  <palves@redhat.com>
4609
4610         * solib-svr4.c (svr4_free_objfile_observer): New.
4611         (probe_and_action::objfile): New field.
4612         (probes_table_htab_remove_objfile_probes)
4613         (probes_table_remove_objfile_probes): New functions.
4614         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4615         in the new probe_and_action.  Don't store the probe in 'lookup'.
4616         (svr4_create_probe_breakpoints): Pass objfile to
4617         register_solib_event_probe.
4618         (_initialize_svr4_solib): Register a free_objfile observer.
4619
4620 2019-04-19  Tom Tromey  <tom@tromey.com>
4621
4622         * common/queue.h: Remove.
4623
4624 2019-04-19  Tom Tromey  <tom@tromey.com>
4625
4626         * event-loop.c: Don't include "common/queue.h".
4627
4628 2019-04-19  Tom Tromey  <tom@tromey.com>
4629
4630         * remote.c (remote_target): Use delete.
4631         * remote-notif.h: Include <list>, not "common/queue.h".
4632         (notif_client_p): Remove typedef.
4633         (remote_notif_state): Add constructor, destructor, initializer.
4634         <notif_queue>: Now a std::list.
4635         (remote_notif_state_xfree): Don't declare.
4636         * remote-notif.c (remote_notif_process, handle_notification)
4637         (remote_notif_state_allocate): Update.
4638         (~remote_notif_state): Rename from remote_notif_state_xfree.
4639
4640 2019-04-19  Tom Tromey  <tom@tromey.com>
4641
4642         * symfile.c (reread_symbols): Update.
4643         * objfiles.c (objfile_register_static_link)
4644         (objfile_lookup_static_link): Update
4645         (~objfile) Don't delete static_links.
4646         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4647
4648 2019-04-19  Tom Tromey  <tom@tromey.com>
4649
4650         * type-stack.h (struct type_stack) <insert>: Constify string.
4651         * type-stack.c (type_stack::insert): Constify string.
4652         * gdbtypes.h (lookup_template_type): Update.
4653         (address_space_name_to_int): Update.
4654         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4655         const.
4656         (lookup_template_type): Make name const.
4657         * c-exp.y: Update rules.
4658         (lex_one_token, classify_name, classify_inner_name)
4659         (c_print_token): Update.
4660         * p-exp.y: Update rules.
4661         (yylex): Update.
4662         * f-exp.y: Update rules.
4663         (yylex): Update.
4664         * d-exp.y: Update rules.
4665         (lex_one_token, classify_name, classify_inner_name): Update.
4666         * parse.c (write_dollar_variable, copy_name): Return std::string.
4667         * parser-defs.h (copy_name): Change return type.
4668         * m2-exp.y: Update rules.
4669         (yylex): Update.
4670         * go-exp.y (lex_one_token): Update.
4671         Update rules.
4672         (classify_unsafe_function, classify_packaged_name)
4673         (classify_name, yylex): Update.
4674
4675 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4676
4677         * configure.ac: add --enable-source-highlight switch.
4678         * configure: Regenerate.
4679         * top.c (print_gdb_version): plumb --enable-source-highlight
4680         status to "show configuration".
4681
4682 2019-04-19  Tom Tromey  <tromey@adacore.com>
4683
4684         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4685         Check ADA_TYPE_P.
4686         (empty_record, ada_template_to_fixed_record_type_1)
4687         (template_to_static_fixed_type)
4688         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4689         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4690         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4691         macros.
4692
4693 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4694
4695         PR symtab/24423:
4696         * source.c (print_source_lines_base): Advance "iter" when a
4697         control character is seen.
4698
4699 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4700
4701         * inferior.h (struct infcall_suspend_state_deleter):
4702         Catch exception in destructor to avoid crash.
4703
4704 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4705
4706         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4707         close to the add_com "shell".
4708
4709 2019-04-18  Tom Tromey  <tromey@adacore.com>
4710
4711         * process-stratum-target.h (class process_stratum_target)
4712         <stratum>: Add "final".
4713
4714 2019-04-17  Tom Tromey  <tromey@adacore.com>
4715
4716         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4717         against nullptr before use.
4718
4719 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4720
4721         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4722
4723 2019-04-17  Jim Wilson  <jimw@sifive.com>
4724             Andrew Burgess  <andrew.burgess@embecosm.com>
4725
4726         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4727         code read might fail, assume 4-byte breakpoint in that case.
4728
4729 2019-04-15  Leszek Swirski  <leszeks@google.com>
4730
4731         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4732         rather than a hand-rolled POD check when checking for forced MEMORY
4733         classification.
4734
4735 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4736
4737         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4738         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4739         function.
4740         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4741         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4742         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4743         declaration.
4744
4745 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4746
4747         * aarch64-linux-nat.c
4748         (aarch64_linux_nat_target::thread_architecture): Add override.
4749         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4750         each VQ.
4751
4752 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4755
4756 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4759         target types of size 96-bits, add some additional comments, and
4760         check that the builtin type we found was the correct size.
4761
4762 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4763
4764         * utils.c (prompt_for_continue): Don't restore the styling at the
4765         end, as applied_style has the wrong value.  This fixes styling in
4766         long lists of file names that are interrupted by the "Continue?"
4767         prompt.
4768
4769 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4772         * c-lang.c (c_language_defn): Likewise.
4773         (cplus_language_defn): Likewise.
4774         (asm_language_defn): Likewise.
4775         (minimal_language_defn): Likewise.
4776         * d-lang.c (d_language_defn): Likewise.
4777         * f-lang.c (f_language_defn): Likewise.
4778         * go-lang.c (go_language_defn): Likewise.
4779         * language.c (unknown_language_defn): Likewise.
4780         (auto_language_defn): Likewise.
4781         * language.h (struct language_defn): Remove la_magic field.
4782         (LANG_MAGIC): Delete.
4783         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4784         * objc-lang.c (objc_language_defn): Likewise.
4785         * opencl-lang.c (opencl_language_defn): Likewise.
4786         * p-lang.c (pascal_language_defn): Likewise.
4787         * rust-lang.c (rust_language_defn): Likewise.
4788
4789 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * riscv-tdep.c (riscv_type_align): New function.
4792         (riscv_type_alignment): Delete.
4793         (riscv_arg_location): Use 'type_align'.
4794         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4795
4796 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * gdbtypes.c (type_align): A struct with no non-static fields also
4799         has alignment of 1.
4800
4801 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4804         component to 0.
4805         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4806         member.
4807         (riscv_struct_info::analyse): New implementation using new
4808         analyse_inner member function.
4809         (riscv_struct_info::field_offset): New member function.
4810         (riscv_struct_info::m_offsets): New member variable.
4811         (riscv_struct_info::analyse_inner): New private member function,
4812         takes the old implementation of riscv_struct_info::analyse but
4813         extended to track field offsets.
4814         (riscv_call_arg_struct): Update the struct folding special cases
4815         to handle cases where empty C++ structs, which are non-zero
4816         length, are found.
4817         (riscv_arg_location): Initialise the length of each location, a
4818         non-zero length now indicates the location is in use.
4819         (riscv_push_dummy_call): Allow for the first location having a
4820         non-zero offset when setting up arguments.
4821         (riscv_return_value): Likewise, but for return values.
4822
4823 2019-04-11  Tom Tromey  <tromey@adacore.com>
4824
4825         * utils.c (internal_vproblem): Make "msg" const.
4826
4827 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4830         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4831         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4832         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4833
4834 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4835
4836         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4837         function.
4838         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4839         of amd64_collect_native_gregset.
4840         (amd64_linux_nat_target::store_registers): Likewise.
4841
4842 2019-04-10  Tom Tromey  <tom@tromey.com>
4843
4844         * symtab.c (lookup_global_symbol_from_objfile)
4845         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4846         * objfiles.h (class separate_debug_iterator): New.
4847         (class separate_debug_range): New.
4848         (struct objfile) <separate_debug_objfiles>: New method.
4849         (objfile_separate_debug_iterate): Don't declare.
4850         * objfiles.c (separate_debug_iterator::operator++): Rename from
4851         objfile_separate_debug_iterate.
4852         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4853         iterator.
4854         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4855         iterator.
4856
4857 2019-04-10  Tom Tromey  <tom@tromey.com>
4858
4859         * symfile.c (reread_symbols): Remove old comment.
4860         * objfiles.c (free_all_objfiles): Fix a typo.
4861
4862 2019-04-10  Tom Tromey  <tom@tromey.com>
4863
4864         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4865         * minsyms.c (lookup_minimal_symbol): Use foreach.
4866         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4867         (lookup_minimal_symbol_solib_trampoline): Likewise.
4868         * symfile.c (reread_symbols): Use foreach.
4869
4870 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4871             Tom Tromey  <tromey@adacore.com>
4872
4873         PR rust/24414:
4874         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4875         (rust_lex_int_test): Change "value" to be LONGEST.
4876         (rust_lex_tests): Add test for long integer literal.
4877
4878 2019-04-09  Tom Tromey  <tromey@adacore.com>
4879
4880         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4881         to bool.
4882         (extended_remote_target::attach): Update.
4883         (remote_target::remote_notice_new_inferior): Update.
4884         (remote_target::add_current_inferior_and_thread): Update.
4885         * inferior.c (exit_inferior_1): Use "false".
4886         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4887
4888 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4889
4890         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4891         the "start" command.
4892
4893 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4894
4895         * python/py-inferior.c (infpy_thread_from_thread_handle):
4896         Adjust comments to reflect renaming of thread_from_thread_handle
4897         to thread_from_handle.  Adjust keywords.  Fix type error message.
4898         (inferior_object_methods): Add thread_from_handle.  Retain
4899         thread_from_thread_handle, but mark it as deprecated.
4900
4901 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4902
4903         * gdbthread.h (find_thread_by_handle): Revise declaration.
4904         * thread.c (find_thread_by_handle): Likewise.  Adjust
4905         implementation too.
4906         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4907         support for buffer objects as handles.
4908
4909 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4910
4911         * python/py-infthread.c (thpy_thread_handle): New function.
4912         (thread_object_methods): Register thpy_thread_handle.
4913
4914 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4915
4916         * gdbthread.h (thread_to_thread_handle): Declare.
4917         * thread.c (gdbtypes.h): Include.
4918         (thread_to_thread_handle): New function.
4919
4920         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4921         (target_thread_info_to_thread_handle): Declare.
4922         * target.c (target_thread_info_to_thread_handle): New function.
4923         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4924         * target-delegates.c: Regenerate.
4925
4926         * linux-thread-db.c (class thread_db_target): Add method
4927         thread_info_to_thread_handle.
4928         (thread_db_target::thread_info_to_thread_handle): Define.
4929         * remote.c (class remote_target): Add new method
4930         thread_info_to_thread_handle.
4931         (remote_target::thread_info_to_thread_handle): Define.
4932
4933 2019-04-08  Pedro Alves  <palves@redhat.com>
4934
4935         * common/common-exceptions.c (throw_exception): Don't create
4936         named object to throw; throw directly.
4937         (throw_it): Likewise.  Don't initialize gdb_exception::message
4938         here, with new; pass FMT and AP to the ctor instead.
4939         * common/common-exceptions.h: Include <string>.
4940         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4941         const char *, va_list)): New ctor.  Use std::make_shared.
4942         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4943         errors)): Delete.
4944         (gdb_exception_error::gdb_exception_error(enum errors, const char
4945         *, va_list)): New.
4946         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4947         Add assertion.
4948         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4949         errors)): Delete.
4950         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4951         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4952         Add assertion.
4953
4954 2019-04-08  Tom Tromey  <tom@tromey.com>
4955
4956         * valops.c (value_rtti_indirect_type): Replace throw_exception
4957         with throw.
4958         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4959         with throw.
4960         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4961         throw.
4962         * target.c (target_translate_tls_address): Replace throw_exception
4963         with throw.
4964         * stack.c (frame_apply_command_count): Replace throw_exception
4965         with throw.
4966         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4967         throw.
4968         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4969         with throw.
4970         * rs6000-tdep.c (rs6000_frame_cache)
4971         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4972         * remote.c: Replace throw_exception with throw.
4973         * record-full.c (record_full_message, record_full_wait_1)
4974         (record_full_restore): Replace throw_exception with throw.
4975         * record-btrace.c:
4976         (get_thread_current_frame_id, record_btrace_start_replaying)
4977         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4978         (cmd_record_btrace_start): Replace throw_exception with throw.
4979         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4980         throw.
4981         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4982         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4983         * linespec.c:
4984         (find_linespec_symbols): Replace throw_exception with throw.
4985         * infrun.c (displaced_step_prepare, resume): Replace
4986         throw_exception with throw.
4987         * infcmd.c (post_create_inferior): Replace throw_exception with
4988         throw.
4989         * inf-loop.c (inferior_event_handler): Replace throw_exception
4990         with throw.
4991         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4992         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4993         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4994         (get_prev_frame_always, get_frame_pc_if_available)
4995         (get_frame_address_in_block_if_available, get_frame_language):
4996         Replace throw_exception with throw.
4997         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4998         throw_exception with throw.
4999         * eval.c (fetch_subexp_value, evaluate_var_value)
5000         (evaluate_funcall, evaluate_subexp_standard): Replace
5001         throw_exception with throw.
5002         * dwarf2loc.c (call_site_find_chain)
5003         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5004         Replace throw_exception with throw.
5005         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5006         with throw.
5007         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5008         throw.
5009         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5010         * completer.c (complete_line_internal): Replace throw_exception
5011         with throw.
5012         * compile/compile-object-run.c (compile_object_run): Replace
5013         throw_exception with throw.
5014         * cli/cli-script.c (process_next_line): Replace throw_exception
5015         with throw.
5016         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5017         (btrace_enable, btrace_maint_update_pt_packets): Replace
5018         throw_exception with throw.
5019         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5020         throw_exception with throw.
5021         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5022         throw_exception with throw.
5023         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5024         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5025         * aarch64-tdep.c (aarch64_make_prologue_cache)
5026         (aarch64_make_stub_cache): Replace throw_exception with throw.
5027
5028 2019-04-08  Tom Tromey  <tom@tromey.com>
5029
5030         * common/common-exceptions.c (throw_exception): Rename from
5031         throw_exception_cxx.  Remove old copy.  Make argument const.
5032         (throw_it): Create and throw exception objects directly.
5033         * common/common-exceptions.h (throw_exception): Make argument
5034         const.
5035         (struct gdb_exception_error): Add constructor.
5036         (struct gdb_exception_quit): Add constructor.
5037
5038 2019-04-08  Tom Tromey  <tom@tromey.com>
5039
5040         * common/common-exceptions.h (exception_rethrow): Don't declare.
5041         (TRY_SJLJ): Update comment.
5042         (TRY, CATCH, END_CATCH): Remove.
5043         * common/common-exceptions.c (exception_rethrow): Remove.
5044
5045 2019-04-08  Tom Tromey  <tom@tromey.com>
5046
5047         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5048         Remove.
5049         (gdb_exception_error): Rename from
5050         gdb_exception_RETURN_MASK_ERROR.
5051         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5052         (gdb_quit_bad_alloc): Update.
5053         * aarch64-tdep.c: Update.
5054         * ada-lang.c: Update.
5055         * ada-typeprint.c: Update.
5056         * ada-valprint.c: Update.
5057         * amd64-tdep.c: Update.
5058         * arch-utils.c: Update.
5059         * break-catch-throw.c: Update.
5060         * breakpoint.c: Update.
5061         * btrace.c: Update.
5062         * c-varobj.c: Update.
5063         * cli/cli-cmds.c: Update.
5064         * cli/cli-interp.c: Update.
5065         * cli/cli-script.c: Update.
5066         * common/common-exceptions.c: Update.
5067         * common/new-op.c: Update.
5068         * common/selftest.c: Update.
5069         * compile/compile-c-symbols.c: Update.
5070         * compile/compile-cplus-symbols.c: Update.
5071         * compile/compile-object-load.c: Update.
5072         * compile/compile-object-run.c: Update.
5073         * completer.c: Update.
5074         * corelow.c: Update.
5075         * cp-abi.c: Update.
5076         * cp-support.c: Update.
5077         * cp-valprint.c: Update.
5078         * darwin-nat.c: Update.
5079         * disasm-selftests.c: Update.
5080         * dtrace-probe.c: Update.
5081         * dwarf-index-cache.c: Update.
5082         * dwarf-index-write.c: Update.
5083         * dwarf2-frame-tailcall.c: Update.
5084         * dwarf2-frame.c: Update.
5085         * dwarf2loc.c: Update.
5086         * dwarf2read.c: Update.
5087         * eval.c: Update.
5088         * event-loop.c: Update.
5089         * event-top.c: Update.
5090         * exec.c: Update.
5091         * f-valprint.c: Update.
5092         * fbsd-tdep.c: Update.
5093         * frame-unwind.c: Update.
5094         * frame.c: Update.
5095         * gdbtypes.c: Update.
5096         * gnu-v3-abi.c: Update.
5097         * guile/guile-internal.h: Update.
5098         * guile/scm-block.c: Update.
5099         * guile/scm-breakpoint.c: Update.
5100         * guile/scm-cmd.c: Update.
5101         * guile/scm-disasm.c: Update.
5102         * guile/scm-frame.c: Update.
5103         * guile/scm-lazy-string.c: Update.
5104         * guile/scm-math.c: Update.
5105         * guile/scm-param.c: Update.
5106         * guile/scm-ports.c: Update.
5107         * guile/scm-pretty-print.c: Update.
5108         * guile/scm-symbol.c: Update.
5109         * guile/scm-symtab.c: Update.
5110         * guile/scm-type.c: Update.
5111         * guile/scm-value.c: Update.
5112         * i386-linux-tdep.c: Update.
5113         * i386-tdep.c: Update.
5114         * inf-loop.c: Update.
5115         * infcall.c: Update.
5116         * infcmd.c: Update.
5117         * infrun.c: Update.
5118         * jit.c: Update.
5119         * language.c: Update.
5120         * linespec.c: Update.
5121         * linux-fork.c: Update.
5122         * linux-nat.c: Update.
5123         * linux-tdep.c: Update.
5124         * linux-thread-db.c: Update.
5125         * main.c: Update.
5126         * mi/mi-cmd-break.c: Update.
5127         * mi/mi-cmd-stack.c: Update.
5128         * mi/mi-interp.c: Update.
5129         * mi/mi-main.c: Update.
5130         * objc-lang.c: Update.
5131         * p-valprint.c: Update.
5132         * parse.c: Update.
5133         * ppc-linux-tdep.c: Update.
5134         * printcmd.c: Update.
5135         * python/py-arch.c: Update.
5136         * python/py-breakpoint.c: Update.
5137         * python/py-cmd.c: Update.
5138         * python/py-finishbreakpoint.c: Update.
5139         * python/py-frame.c: Update.
5140         * python/py-framefilter.c: Update.
5141         * python/py-gdb-readline.c: Update.
5142         * python/py-inferior.c: Update.
5143         * python/py-infthread.c: Update.
5144         * python/py-lazy-string.c: Update.
5145         * python/py-linetable.c: Update.
5146         * python/py-objfile.c: Update.
5147         * python/py-param.c: Update.
5148         * python/py-prettyprint.c: Update.
5149         * python/py-progspace.c: Update.
5150         * python/py-record-btrace.c: Update.
5151         * python/py-record.c: Update.
5152         * python/py-symbol.c: Update.
5153         * python/py-type.c: Update.
5154         * python/py-unwind.c: Update.
5155         * python/py-utils.c: Update.
5156         * python/py-value.c: Update.
5157         * python/python.c: Update.
5158         * record-btrace.c: Update.
5159         * record-full.c: Update.
5160         * remote-fileio.c: Update.
5161         * remote.c: Update.
5162         * riscv-tdep.c: Update.
5163         * rs6000-aix-tdep.c: Update.
5164         * rs6000-tdep.c: Update.
5165         * rust-exp.y: Update.
5166         * rust-lang.c: Update.
5167         * s390-tdep.c: Update.
5168         * selftest-arch.c: Update.
5169         * solib-dsbt.c: Update.
5170         * solib-frv.c: Update.
5171         * solib-spu.c: Update.
5172         * solib-svr4.c: Update.
5173         * solib.c: Update.
5174         * sparc64-linux-tdep.c: Update.
5175         * stack.c: Update.
5176         * symfile-mem.c: Update.
5177         * symmisc.c: Update.
5178         * target.c: Update.
5179         * thread.c: Update.
5180         * top.c: Update.
5181         * tracefile-tfile.c: Update.
5182         * tui/tui.c: Update.
5183         * typeprint.c: Update.
5184         * unittests/cli-utils-selftests.c: Update.
5185         * unittests/parse-connection-spec-selftests.c: Update.
5186         * valops.c: Update.
5187         * valprint.c: Update.
5188         * value.c: Update.
5189         * varobj.c: Update.
5190         * windows-nat.c: Update.
5191         * x86-linux-nat.c: Update.
5192         * xml-support.c: Update.
5193
5194 2019-04-08  Tom Tromey  <tom@tromey.com>
5195
5196         * xml-support.c: Use C++ exception handling.
5197         * x86-linux-nat.c: Use C++ exception handling.
5198         * windows-nat.c: Use C++ exception handling.
5199         * varobj.c: Use C++ exception handling.
5200         * value.c: Use C++ exception handling.
5201         * valprint.c: Use C++ exception handling.
5202         * valops.c: Use C++ exception handling.
5203         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5204         handling.
5205         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5206         * typeprint.c: Use C++ exception handling.
5207         * tui/tui.c: Use C++ exception handling.
5208         * tracefile-tfile.c: Use C++ exception handling.
5209         * top.c: Use C++ exception handling.
5210         * thread.c: Use C++ exception handling.
5211         * target.c: Use C++ exception handling.
5212         * symmisc.c: Use C++ exception handling.
5213         * symfile-mem.c: Use C++ exception handling.
5214         * stack.c: Use C++ exception handling.
5215         * sparc64-linux-tdep.c: Use C++ exception handling.
5216         * solib.c: Use C++ exception handling.
5217         * solib-svr4.c: Use C++ exception handling.
5218         * solib-spu.c: Use C++ exception handling.
5219         * solib-frv.c: Use C++ exception handling.
5220         * solib-dsbt.c: Use C++ exception handling.
5221         * selftest-arch.c: Use C++ exception handling.
5222         * s390-tdep.c: Use C++ exception handling.
5223         * rust-lang.c: Use C++ exception handling.
5224         * rust-exp.y: Use C++ exception handling.
5225         * rs6000-tdep.c: Use C++ exception handling.
5226         * rs6000-aix-tdep.c: Use C++ exception handling.
5227         * riscv-tdep.c: Use C++ exception handling.
5228         * remote.c: Use C++ exception handling.
5229         * remote-fileio.c: Use C++ exception handling.
5230         * record-full.c: Use C++ exception handling.
5231         * record-btrace.c: Use C++ exception handling.
5232         * python/python.c: Use C++ exception handling.
5233         * python/py-value.c: Use C++ exception handling.
5234         * python/py-utils.c: Use C++ exception handling.
5235         * python/py-unwind.c: Use C++ exception handling.
5236         * python/py-type.c: Use C++ exception handling.
5237         * python/py-symbol.c: Use C++ exception handling.
5238         * python/py-record.c: Use C++ exception handling.
5239         * python/py-record-btrace.c: Use C++ exception handling.
5240         * python/py-progspace.c: Use C++ exception handling.
5241         * python/py-prettyprint.c: Use C++ exception handling.
5242         * python/py-param.c: Use C++ exception handling.
5243         * python/py-objfile.c: Use C++ exception handling.
5244         * python/py-linetable.c: Use C++ exception handling.
5245         * python/py-lazy-string.c: Use C++ exception handling.
5246         * python/py-infthread.c: Use C++ exception handling.
5247         * python/py-inferior.c: Use C++ exception handling.
5248         * python/py-gdb-readline.c: Use C++ exception handling.
5249         * python/py-framefilter.c: Use C++ exception handling.
5250         * python/py-frame.c: Use C++ exception handling.
5251         * python/py-finishbreakpoint.c: Use C++ exception handling.
5252         * python/py-cmd.c: Use C++ exception handling.
5253         * python/py-breakpoint.c: Use C++ exception handling.
5254         * python/py-arch.c: Use C++ exception handling.
5255         * printcmd.c: Use C++ exception handling.
5256         * ppc-linux-tdep.c: Use C++ exception handling.
5257         * parse.c: Use C++ exception handling.
5258         * p-valprint.c: Use C++ exception handling.
5259         * objc-lang.c: Use C++ exception handling.
5260         * mi/mi-main.c: Use C++ exception handling.
5261         * mi/mi-interp.c: Use C++ exception handling.
5262         * mi/mi-cmd-stack.c: Use C++ exception handling.
5263         * mi/mi-cmd-break.c: Use C++ exception handling.
5264         * main.c: Use C++ exception handling.
5265         * linux-thread-db.c: Use C++ exception handling.
5266         * linux-tdep.c: Use C++ exception handling.
5267         * linux-nat.c: Use C++ exception handling.
5268         * linux-fork.c: Use C++ exception handling.
5269         * linespec.c: Use C++ exception handling.
5270         * language.c: Use C++ exception handling.
5271         * jit.c: Use C++ exception handling.
5272         * infrun.c: Use C++ exception handling.
5273         * infcmd.c: Use C++ exception handling.
5274         * infcall.c: Use C++ exception handling.
5275         * inf-loop.c: Use C++ exception handling.
5276         * i386-tdep.c: Use C++ exception handling.
5277         * i386-linux-tdep.c: Use C++ exception handling.
5278         * guile/scm-value.c: Use C++ exception handling.
5279         * guile/scm-type.c: Use C++ exception handling.
5280         * guile/scm-symtab.c: Use C++ exception handling.
5281         * guile/scm-symbol.c: Use C++ exception handling.
5282         * guile/scm-pretty-print.c: Use C++ exception handling.
5283         * guile/scm-ports.c: Use C++ exception handling.
5284         * guile/scm-param.c: Use C++ exception handling.
5285         * guile/scm-math.c: Use C++ exception handling.
5286         * guile/scm-lazy-string.c: Use C++ exception handling.
5287         * guile/scm-frame.c: Use C++ exception handling.
5288         * guile/scm-disasm.c: Use C++ exception handling.
5289         * guile/scm-cmd.c: Use C++ exception handling.
5290         * guile/scm-breakpoint.c: Use C++ exception handling.
5291         * guile/scm-block.c: Use C++ exception handling.
5292         * guile/guile-internal.h: Use C++ exception handling.
5293         * gnu-v3-abi.c: Use C++ exception handling.
5294         * gdbtypes.c: Use C++ exception handling.
5295         * frame.c: Use C++ exception handling.
5296         * frame-unwind.c: Use C++ exception handling.
5297         * fbsd-tdep.c: Use C++ exception handling.
5298         * f-valprint.c: Use C++ exception handling.
5299         * exec.c: Use C++ exception handling.
5300         * event-top.c: Use C++ exception handling.
5301         * event-loop.c: Use C++ exception handling.
5302         * eval.c: Use C++ exception handling.
5303         * dwarf2read.c: Use C++ exception handling.
5304         * dwarf2loc.c: Use C++ exception handling.
5305         * dwarf2-frame.c: Use C++ exception handling.
5306         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5307         * dwarf-index-write.c: Use C++ exception handling.
5308         * dwarf-index-cache.c: Use C++ exception handling.
5309         * dtrace-probe.c: Use C++ exception handling.
5310         * disasm-selftests.c: Use C++ exception handling.
5311         * darwin-nat.c: Use C++ exception handling.
5312         * cp-valprint.c: Use C++ exception handling.
5313         * cp-support.c: Use C++ exception handling.
5314         * cp-abi.c: Use C++ exception handling.
5315         * corelow.c: Use C++ exception handling.
5316         * completer.c: Use C++ exception handling.
5317         * compile/compile-object-run.c: Use C++ exception handling.
5318         * compile/compile-object-load.c: Use C++ exception handling.
5319         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5320         * compile/compile-c-symbols.c: Use C++ exception handling.
5321         * common/selftest.c: Use C++ exception handling.
5322         * common/new-op.c: Use C++ exception handling.
5323         * cli/cli-script.c: Use C++ exception handling.
5324         * cli/cli-interp.c: Use C++ exception handling.
5325         * cli/cli-cmds.c: Use C++ exception handling.
5326         * c-varobj.c: Use C++ exception handling.
5327         * btrace.c: Use C++ exception handling.
5328         * breakpoint.c: Use C++ exception handling.
5329         * break-catch-throw.c: Use C++ exception handling.
5330         * arch-utils.c: Use C++ exception handling.
5331         * amd64-tdep.c: Use C++ exception handling.
5332         * ada-valprint.c: Use C++ exception handling.
5333         * ada-typeprint.c: Use C++ exception handling.
5334         * ada-lang.c: Use C++ exception handling.
5335         * aarch64-tdep.c: Use C++ exception handling.
5336
5337 2019-04-08  Tom Tromey  <tom@tromey.com>
5338
5339         * xml-support.c (gdb_xml_parser::parse): Update.
5340         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5341         * value.c (show_convenience): Update.
5342         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5343         (test_parse_flags_qcs): Update.
5344         * thread.c (thr_try_catch_cmd): Update.
5345         * target.c (target_translate_tls_address): Update.
5346         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5347         (info_frame_command_core, frame_apply_command_count): Update.
5348         * rust-exp.y (rust_lex_exception_test): Update.
5349         * riscv-tdep.c (riscv_print_one_register_info): Update.
5350         * remote.c (remote_target::enable_btrace): Update.
5351         * record-btrace.c (record_btrace_enable_warn): Update.
5352         * python/py-utils.c (gdbpy_convert_exception): Update.
5353         * printcmd.c (do_one_display, print_variable_and_value): Update.
5354         * mi/mi-main.c (mi_print_exception): Update.
5355         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5356         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5357         * linux-nat.c (linux_nat_target::attach): Update.
5358         * linux-fork.c (class scoped_switch_fork_info): Update.
5359         * infrun.c (displaced_step_prepare): Update.
5360         * infcall.c (call_function_by_hand_dummy): Update.
5361         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5362         * gnu-v3-abi.c (print_one_vtable): Update.
5363         * frame.c (get_prev_frame_always): Update.
5364         * f-valprint.c (info_common_command_for_block): Update.
5365         * exec.c (try_open_exec_file): Update.
5366         * exceptions.c (print_exception, exception_print)
5367         (exception_fprintf, exception_print_same): Update.
5368         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5369         * dwarf-index-cache.c (index_cache::store)
5370         (index_cache::lookup_gdb_index): Update.
5371         * darwin-nat.c (maybe_cache_shell): Update.
5372         * cp-valprint.c (cp_print_value_fields): Update.
5373         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5374         (gcc_cplus_symbol_address): Update.
5375         * compile/compile-c-symbols.c (gcc_convert_symbol)
5376         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5377         * common/selftest.c: Update.
5378         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5379         a std::string.
5380         (exception_try_scope_entry, exception_try_scope_exit): Don't
5381         declare.
5382         (struct exception_try_scope): Remove.
5383         (TRY): Don't use exception_try_scope.
5384         (struct gdb_exception): Add constructor, operator=.
5385         <what>: New method.
5386         (struct gdb_exception_RETURN_MASK_ALL)
5387         (struct gdb_exception_RETURN_MASK_ERROR)
5388         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5389         (struct gdb_quit_bad_alloc): Update.
5390         * common/common-exceptions.c (exception_none): Change
5391         initializer.
5392         (struct catcher) <state, exception>: Initialize inline.
5393         <prev>: Remove member.
5394         (current_catcher): Remove.
5395         (catchers): New global.
5396         (exceptions_state_mc_init): Simplify.
5397         (catcher_pop): Remove.
5398         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5399         (try_scope_depth, exception_try_scope_entry)
5400         (exception_try_scope_exit): Remove.
5401         (throw_exception_sjlj): Update.
5402         (exception_messages, exception_messages_size): Remove.
5403         (throw_it): Simplify.
5404         (gdb_exception_sliced_copy): Remove.
5405         (throw_exception_cxx): Update.
5406         * cli/cli-script.c (script_from_file): Update.
5407         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5408         Update.
5409         * ada-valprint.c (ada_val_print): Update.
5410         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5411         (create_excep_cond_exprs): Update.
5412
5413 2019-04-08  Tom Tromey  <tom@tromey.com>
5414
5415         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5416         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5417         (TRY, CATCH, END_CATCH): Remove some definitions.
5418         * common/common-exceptions.c: Don't use GDB_XCPT.
5419         (catcher_list_size): Remove.
5420         (throw_exception, throw_it): Simplify.
5421
5422 2019-04-05  Tom Tromey  <tom@tromey.com>
5423
5424         Revert the header-sorting patch.
5425         * ft32-tdep.c: Revert.
5426         * frv-tdep.c: Revert.
5427         * frv-linux-tdep.c: Revert.
5428         * frame.c: Revert.
5429         * frame-unwind.c: Revert.
5430         * frame-base.c: Revert.
5431         * fork-child.c: Revert.
5432         * findvar.c: Revert.
5433         * findcmd.c: Revert.
5434         * filesystem.c: Revert.
5435         * filename-seen-cache.h: Revert.
5436         * filename-seen-cache.c: Revert.
5437         * fbsd-tdep.c: Revert.
5438         * fbsd-nat.h: Revert.
5439         * fbsd-nat.c: Revert.
5440         * f-valprint.c: Revert.
5441         * f-typeprint.c: Revert.
5442         * f-lang.c: Revert.
5443         * extension.h: Revert.
5444         * extension.c: Revert.
5445         * extension-priv.h: Revert.
5446         * expprint.c: Revert.
5447         * exec.h: Revert.
5448         * exec.c: Revert.
5449         * exceptions.c: Revert.
5450         * event-top.c: Revert.
5451         * event-loop.c: Revert.
5452         * eval.c: Revert.
5453         * elfread.c: Revert.
5454         * dwarf2read.h: Revert.
5455         * dwarf2read.c: Revert.
5456         * dwarf2loc.c: Revert.
5457         * dwarf2expr.h: Revert.
5458         * dwarf2expr.c: Revert.
5459         * dwarf2-frame.c: Revert.
5460         * dwarf2-frame-tailcall.c: Revert.
5461         * dwarf-index-write.h: Revert.
5462         * dwarf-index-write.c: Revert.
5463         * dwarf-index-common.c: Revert.
5464         * dwarf-index-cache.h: Revert.
5465         * dwarf-index-cache.c: Revert.
5466         * dummy-frame.c: Revert.
5467         * dtrace-probe.c: Revert.
5468         * disasm.h: Revert.
5469         * disasm.c: Revert.
5470         * disasm-selftests.c: Revert.
5471         * dictionary.c: Revert.
5472         * dicos-tdep.c: Revert.
5473         * demangle.c: Revert.
5474         * dcache.h: Revert.
5475         * dcache.c: Revert.
5476         * darwin-nat.h: Revert.
5477         * darwin-nat.c: Revert.
5478         * darwin-nat-info.c: Revert.
5479         * d-valprint.c: Revert.
5480         * d-namespace.c: Revert.
5481         * d-lang.c: Revert.
5482         * ctf.c: Revert.
5483         * csky-tdep.c: Revert.
5484         * csky-linux-tdep.c: Revert.
5485         * cris-tdep.c: Revert.
5486         * cris-linux-tdep.c: Revert.
5487         * cp-valprint.c: Revert.
5488         * cp-support.c: Revert.
5489         * cp-namespace.c: Revert.
5490         * cp-abi.c: Revert.
5491         * corelow.c: Revert.
5492         * corefile.c: Revert.
5493         * continuations.c: Revert.
5494         * completer.h: Revert.
5495         * completer.c: Revert.
5496         * complaints.c: Revert.
5497         * coffread.c: Revert.
5498         * coff-pe-read.c: Revert.
5499         * cli-out.h: Revert.
5500         * cli-out.c: Revert.
5501         * charset.c: Revert.
5502         * c-varobj.c: Revert.
5503         * c-valprint.c: Revert.
5504         * c-typeprint.c: Revert.
5505         * c-lang.c: Revert.
5506         * buildsym.c: Revert.
5507         * buildsym-legacy.c: Revert.
5508         * build-id.h: Revert.
5509         * build-id.c: Revert.
5510         * btrace.c: Revert.
5511         * bsd-uthread.c: Revert.
5512         * breakpoint.h: Revert.
5513         * breakpoint.c: Revert.
5514         * break-catch-throw.c: Revert.
5515         * break-catch-syscall.c: Revert.
5516         * break-catch-sig.c: Revert.
5517         * blockframe.c: Revert.
5518         * block.c: Revert.
5519         * bfin-tdep.c: Revert.
5520         * bfin-linux-tdep.c: Revert.
5521         * bfd-target.c: Revert.
5522         * bcache.c: Revert.
5523         * ax-general.c: Revert.
5524         * ax-gdb.h: Revert.
5525         * ax-gdb.c: Revert.
5526         * avr-tdep.c: Revert.
5527         * auxv.c: Revert.
5528         * auto-load.c: Revert.
5529         * arm-wince-tdep.c: Revert.
5530         * arm-tdep.c: Revert.
5531         * arm-symbian-tdep.c: Revert.
5532         * arm-pikeos-tdep.c: Revert.
5533         * arm-obsd-tdep.c: Revert.
5534         * arm-nbsd-tdep.c: Revert.
5535         * arm-nbsd-nat.c: Revert.
5536         * arm-linux-tdep.c: Revert.
5537         * arm-linux-nat.c: Revert.
5538         * arm-fbsd-tdep.c: Revert.
5539         * arm-fbsd-nat.c: Revert.
5540         * arm-bsd-tdep.c: Revert.
5541         * arch-utils.c: Revert.
5542         * arc-tdep.c: Revert.
5543         * arc-newlib-tdep.c: Revert.
5544         * annotate.h: Revert.
5545         * annotate.c: Revert.
5546         * amd64-windows-tdep.c: Revert.
5547         * amd64-windows-nat.c: Revert.
5548         * amd64-tdep.c: Revert.
5549         * amd64-sol2-tdep.c: Revert.
5550         * amd64-obsd-tdep.c: Revert.
5551         * amd64-obsd-nat.c: Revert.
5552         * amd64-nbsd-tdep.c: Revert.
5553         * amd64-nbsd-nat.c: Revert.
5554         * amd64-nat.c: Revert.
5555         * amd64-linux-tdep.c: Revert.
5556         * amd64-linux-nat.c: Revert.
5557         * amd64-fbsd-tdep.c: Revert.
5558         * amd64-fbsd-nat.c: Revert.
5559         * amd64-dicos-tdep.c: Revert.
5560         * amd64-darwin-tdep.c: Revert.
5561         * amd64-bsd-nat.c: Revert.
5562         * alpha-tdep.c: Revert.
5563         * alpha-obsd-tdep.c: Revert.
5564         * alpha-nbsd-tdep.c: Revert.
5565         * alpha-mdebug-tdep.c: Revert.
5566         * alpha-linux-tdep.c: Revert.
5567         * alpha-linux-nat.c: Revert.
5568         * alpha-bsd-tdep.c: Revert.
5569         * alpha-bsd-nat.c: Revert.
5570         * aix-thread.c: Revert.
5571         * agent.c: Revert.
5572         * addrmap.c: Revert.
5573         * ada-varobj.c: Revert.
5574         * ada-valprint.c: Revert.
5575         * ada-typeprint.c: Revert.
5576         * ada-tasks.c: Revert.
5577         * ada-lang.c: Revert.
5578         * aarch64-tdep.c: Revert.
5579         * aarch64-ravenscar-thread.c: Revert.
5580         * aarch64-newlib-tdep.c: Revert.
5581         * aarch64-linux-tdep.c: Revert.
5582         * aarch64-linux-nat.c: Revert.
5583         * aarch64-fbsd-tdep.c: Revert.
5584         * aarch64-fbsd-nat.c: Revert.
5585         * aarch32-linux-nat.c: Revert.
5586
5587 2019-04-05  Tom Tromey  <tom@tromey.com>
5588
5589         * ft32-tdep.c: Sort headers.
5590         * frv-tdep.c: Sort headers.
5591         * frv-linux-tdep.c: Sort headers.
5592         * frame.c: Sort headers.
5593         * frame-unwind.c: Sort headers.
5594         * frame-base.c: Sort headers.
5595         * fork-child.c: Sort headers.
5596         * findvar.c: Sort headers.
5597         * findcmd.c: Sort headers.
5598         * filesystem.c: Sort headers.
5599         * filename-seen-cache.h: Sort headers.
5600         * filename-seen-cache.c: Sort headers.
5601         * fbsd-tdep.c: Sort headers.
5602         * fbsd-nat.h: Sort headers.
5603         * fbsd-nat.c: Sort headers.
5604         * f-valprint.c: Sort headers.
5605         * f-typeprint.c: Sort headers.
5606         * f-lang.c: Sort headers.
5607         * extension.h: Sort headers.
5608         * extension.c: Sort headers.
5609         * extension-priv.h: Sort headers.
5610         * expprint.c: Sort headers.
5611         * exec.h: Sort headers.
5612         * exec.c: Sort headers.
5613         * exceptions.c: Sort headers.
5614         * event-top.c: Sort headers.
5615         * event-loop.c: Sort headers.
5616         * eval.c: Sort headers.
5617         * elfread.c: Sort headers.
5618         * dwarf2read.h: Sort headers.
5619         * dwarf2read.c: Sort headers.
5620         * dwarf2loc.c: Sort headers.
5621         * dwarf2expr.h: Sort headers.
5622         * dwarf2expr.c: Sort headers.
5623         * dwarf2-frame.c: Sort headers.
5624         * dwarf2-frame-tailcall.c: Sort headers.
5625         * dwarf-index-write.h: Sort headers.
5626         * dwarf-index-write.c: Sort headers.
5627         * dwarf-index-common.c: Sort headers.
5628         * dwarf-index-cache.h: Sort headers.
5629         * dwarf-index-cache.c: Sort headers.
5630         * dummy-frame.c: Sort headers.
5631         * dtrace-probe.c: Sort headers.
5632         * disasm.h: Sort headers.
5633         * disasm.c: Sort headers.
5634         * disasm-selftests.c: Sort headers.
5635         * dictionary.c: Sort headers.
5636         * dicos-tdep.c: Sort headers.
5637         * demangle.c: Sort headers.
5638         * dcache.h: Sort headers.
5639         * dcache.c: Sort headers.
5640         * darwin-nat.h: Sort headers.
5641         * darwin-nat.c: Sort headers.
5642         * darwin-nat-info.c: Sort headers.
5643         * d-valprint.c: Sort headers.
5644         * d-namespace.c: Sort headers.
5645         * d-lang.c: Sort headers.
5646         * ctf.c: Sort headers.
5647         * csky-tdep.c: Sort headers.
5648         * csky-linux-tdep.c: Sort headers.
5649         * cris-tdep.c: Sort headers.
5650         * cris-linux-tdep.c: Sort headers.
5651         * cp-valprint.c: Sort headers.
5652         * cp-support.c: Sort headers.
5653         * cp-namespace.c: Sort headers.
5654         * cp-abi.c: Sort headers.
5655         * corelow.c: Sort headers.
5656         * corefile.c: Sort headers.
5657         * continuations.c: Sort headers.
5658         * completer.h: Sort headers.
5659         * completer.c: Sort headers.
5660         * complaints.c: Sort headers.
5661         * coffread.c: Sort headers.
5662         * coff-pe-read.c: Sort headers.
5663         * cli-out.h: Sort headers.
5664         * cli-out.c: Sort headers.
5665         * charset.c: Sort headers.
5666         * c-varobj.c: Sort headers.
5667         * c-valprint.c: Sort headers.
5668         * c-typeprint.c: Sort headers.
5669         * c-lang.c: Sort headers.
5670         * buildsym.c: Sort headers.
5671         * buildsym-legacy.c: Sort headers.
5672         * build-id.h: Sort headers.
5673         * build-id.c: Sort headers.
5674         * btrace.c: Sort headers.
5675         * bsd-uthread.c: Sort headers.
5676         * breakpoint.h: Sort headers.
5677         * breakpoint.c: Sort headers.
5678         * break-catch-throw.c: Sort headers.
5679         * break-catch-syscall.c: Sort headers.
5680         * break-catch-sig.c: Sort headers.
5681         * blockframe.c: Sort headers.
5682         * block.c: Sort headers.
5683         * bfin-tdep.c: Sort headers.
5684         * bfin-linux-tdep.c: Sort headers.
5685         * bfd-target.c: Sort headers.
5686         * bcache.c: Sort headers.
5687         * ax-general.c: Sort headers.
5688         * ax-gdb.h: Sort headers.
5689         * ax-gdb.c: Sort headers.
5690         * avr-tdep.c: Sort headers.
5691         * auxv.c: Sort headers.
5692         * auto-load.c: Sort headers.
5693         * arm-wince-tdep.c: Sort headers.
5694         * arm-tdep.c: Sort headers.
5695         * arm-symbian-tdep.c: Sort headers.
5696         * arm-pikeos-tdep.c: Sort headers.
5697         * arm-obsd-tdep.c: Sort headers.
5698         * arm-nbsd-tdep.c: Sort headers.
5699         * arm-nbsd-nat.c: Sort headers.
5700         * arm-linux-tdep.c: Sort headers.
5701         * arm-linux-nat.c: Sort headers.
5702         * arm-fbsd-tdep.c: Sort headers.
5703         * arm-fbsd-nat.c: Sort headers.
5704         * arm-bsd-tdep.c: Sort headers.
5705         * arch-utils.c: Sort headers.
5706         * arc-tdep.c: Sort headers.
5707         * arc-newlib-tdep.c: Sort headers.
5708         * annotate.h: Sort headers.
5709         * annotate.c: Sort headers.
5710         * amd64-windows-tdep.c: Sort headers.
5711         * amd64-windows-nat.c: Sort headers.
5712         * amd64-tdep.c: Sort headers.
5713         * amd64-sol2-tdep.c: Sort headers.
5714         * amd64-obsd-tdep.c: Sort headers.
5715         * amd64-obsd-nat.c: Sort headers.
5716         * amd64-nbsd-tdep.c: Sort headers.
5717         * amd64-nbsd-nat.c: Sort headers.
5718         * amd64-nat.c: Sort headers.
5719         * amd64-linux-tdep.c: Sort headers.
5720         * amd64-linux-nat.c: Sort headers.
5721         * amd64-fbsd-tdep.c: Sort headers.
5722         * amd64-fbsd-nat.c: Sort headers.
5723         * amd64-dicos-tdep.c: Sort headers.
5724         * amd64-darwin-tdep.c: Sort headers.
5725         * amd64-bsd-nat.c: Sort headers.
5726         * alpha-tdep.c: Sort headers.
5727         * alpha-obsd-tdep.c: Sort headers.
5728         * alpha-nbsd-tdep.c: Sort headers.
5729         * alpha-mdebug-tdep.c: Sort headers.
5730         * alpha-linux-tdep.c: Sort headers.
5731         * alpha-linux-nat.c: Sort headers.
5732         * alpha-bsd-tdep.c: Sort headers.
5733         * alpha-bsd-nat.c: Sort headers.
5734         * aix-thread.c: Sort headers.
5735         * agent.c: Sort headers.
5736         * addrmap.c: Sort headers.
5737         * ada-varobj.c: Sort headers.
5738         * ada-valprint.c: Sort headers.
5739         * ada-typeprint.c: Sort headers.
5740         * ada-tasks.c: Sort headers.
5741         * ada-lang.c: Sort headers.
5742         * aarch64-tdep.c: Sort headers.
5743         * aarch64-ravenscar-thread.c: Sort headers.
5744         * aarch64-newlib-tdep.c: Sort headers.
5745         * aarch64-linux-tdep.c: Sort headers.
5746         * aarch64-linux-nat.c: Sort headers.
5747         * aarch64-fbsd-tdep.c: Sort headers.
5748         * aarch64-fbsd-nat.c: Sort headers.
5749         * aarch32-linux-nat.c: Sort headers.
5750
5751 2019-04-04  Tom Tromey  <tom@tromey.com>
5752
5753         * varobj.c (varobj_create): Update.
5754         * rust-exp.y (struct rust_parser) <update_innermost_block,
5755         lookup_symbol>: New methods.
5756         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5757         Rename.
5758         (rust_parser::rust_lookup_type)
5759         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5760         * printcmd.c (display_command, do_one_display): Update.
5761         * parser-defs.h (struct parser_state) <parser_state>: Add
5762         "tracker" parameter.
5763         (block_tracker): New member.
5764         (class innermost_block_tracker) <innermost_block_tracker>: Add
5765         "types" parameter.
5766         <reset>: Remove method.
5767         (innermost_block): Don't declare.
5768         (null_post_parser): Update.
5769         * parse.c (innermost_block): Remove global.
5770         (write_dollar_variable): Update.
5771         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5772         Remove "tracker_types" parameter.
5773         (parse_expression): Add "tracker" parameter.
5774         (parse_expression_for_completion): Update.
5775         (null_post_parser): Add "tracker" parameter.
5776         * p-exp.y: Update rules.
5777         * m2-exp.y: Update rules.
5778         * language.h (struct language_defn) <la_post_parser>: Add
5779         "tracker" parameter.
5780         * go-exp.y: Update rules.
5781         * f-exp.y: Update rules.
5782         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5783         parameter.
5784         * d-exp.y: Update rules.
5785         * c-exp.y: Update rules.
5786         * breakpoint.c (set_breakpoint_condition): Create an
5787         innermost_block_tracker.
5788         (watch_command_1): Likewise.
5789         * ada-lang.c (resolve): Add "tracker" parameter.
5790         (resolve_subexp): Likewise.
5791         * ada-exp.y (write_var_from_sym): Update.
5792
5793 2019-04-04  Tom Tromey  <tom@tromey.com>
5794
5795         * type-stack.h: New file.
5796         * type-stack.c: New file.
5797         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5798         type-stack.h.
5799         (insert_into_type_stack, insert_type, push_type, push_type_int)
5800         (insert_type_address_space, pop_type, pop_type_int)
5801         (pop_typelist, pop_type_stack, append_type_stack)
5802         (push_type_stack, get_type_stack, push_typelist)
5803         (follow_type_instance_flags, follow_types): Don't declare.
5804         * parse.c (type_stack): Remove global.
5805         (parse_exp_in_context): Update.
5806         (insert_into_type_stack, insert_type, push_type, push_type_int)
5807         (insert_type_address_space, pop_type, pop_type_int)
5808         (pop_typelist, pop_type_stack, append_type_stack)
5809         (push_type_stack, get_type_stack, push_typelist)
5810         (follow_type_instance_flags, follow_types): Remove (moved to
5811         type-stack.c).
5812         * f-exp.y (type_stack): New global.
5813         Update rules.
5814         (push_kind_type, f_parse): Update.
5815         * d-exp.y (type_stack): New global.
5816         Update rules.
5817         (d_parse): Update.
5818         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5819         Update rules.
5820         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5821         (HFILES_NO_SRCDIR): Add type-stack.h.
5822
5823 2019-04-04  Tom Tromey  <tom@tromey.com>
5824
5825         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5826         (rust_parser::convert_ast_to_expression, rust_parse)
5827         (rust_lex_test_completion, rust_lex_tests): Update.
5828         * parser-defs.h (struct expr_completion_state): New.
5829         (struct parser_state) <parser_state>: Add completion parameter.
5830         <mark_struct_expression, mark_completion_tag>: New methods.
5831         <parse_completion, m_completion_state>: New members.
5832         (prefixify_expression, null_post_parser): Update.
5833         (mark_struct_expression, mark_completion_tag): Don't declare.
5834         * parse.c (parse_completion, expout_last_struct)
5835         (expout_tag_completion_type, expout_completion_name): Remove
5836         globals.
5837         (parser_state::mark_struct_expression)
5838         (parser_state::mark_completion_tag): Now methods.
5839         (prefixify_expression): Add last_struct parameter.
5840         (prefixify_subexp): Likewise.
5841         (parse_exp_1): Update.
5842         (parse_exp_in_context): Add cstate parameter.  Update.
5843         (parse_expression_for_completion): Create an
5844         expr_completion_state.
5845         (null_post_parser): Add "completion" parameter.
5846         * p-exp.y: Update rules.
5847         (yylex): Update.
5848         * language.h (struct language_defn) <la_post_parser>: Add
5849         "completing" parameter.
5850         * go-exp.y: Update rules.
5851         (lex_one_token): Update.
5852         * expression.h (parse_completion): Don't declare.
5853         * d-exp.y: Update rules.
5854         (lex_one_token): Update rules.
5855         * c-exp.y: Update rules.
5856         (lex_one_token): Update.
5857         * ada-lang.c (resolve): Add "parse_completion" parameter.
5858         (resolve_subexp): Likewise.
5859         (ada_resolve_function): Likewise.
5860
5861 2019-04-04  Tom Tromey  <tom@tromey.com>
5862
5863         * parser-defs.h (struct parser_state) <start_arglist,
5864         end_arglist>: New methods.
5865         <arglist_len, m_funcall_chain>: New members.
5866         (arglist_len, start_arglist, end_arglist): Don't declare.
5867         * parse.c (arglist_len, funcall_chain): Remove global.
5868         (start_arglist, end_arglist): Remove functions.
5869         (parse_exp_in_context): Update.
5870         * p-exp.y: Update rules.
5871         * m2-exp.y: Update rules.
5872         * go-exp.y: Update rules.
5873         * f-exp.y: Update rules.
5874         * d-exp.y: Update rules.
5875         * c-exp.y: Update rules.
5876
5877 2019-04-04  Tom Tromey  <tom@tromey.com>
5878
5879         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5880         lex_operator, push_back>: New methods.
5881         Update all rules.
5882         (rust_parser::lex_hex, lex_escape): Rename and update.
5883         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5884         (rust_parser::lex_operator): Rename and update.
5885         (rust_parser::lex_number, rustyylex, rustyyerror)
5886         (rust_lex_test_init, rust_lex_test_sequence)
5887         (rust_lex_test_push_back, rust_lex_tests): Update.
5888         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5889         parameter.
5890         <lexptr, prev_lexptr>: New members.
5891         (lexptr, prev_lexptr): Don't declare.
5892         * parse.c (lexptr, prev_lexptr): Remove globals.
5893         (parse_exp_in_context): Update.
5894         * p-exp.y (yylex, yyerror): Update.
5895         * m2-exp.y (parse_number, yylex, yyerror): Update.
5896         * go-exp.y (lex_one_token, yyerror): Update.
5897         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5898         * d-exp.y (lex_one_token, yyerror): Update.
5899         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5900         (lex_one_token, yyerror): Update.
5901         * ada-lex.l (YY_INPUT): Update.
5902         (rewind_to_char): Update.
5903         * ada-exp.y (yyerror): Update.
5904
5905 2019-04-04  Tom Tromey  <tom@tromey.com>
5906
5907         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5908         * parser-defs.h (struct parser_state) <parser_state>: Add new
5909         parameter.
5910         <comma_terminates>: New member.
5911         (comma_terminates): Don't declare global.
5912         * parse.c (comma_terminates): Remove global.
5913         (parse_exp_in_context): Update.
5914         * p-exp.y (yylex): Update.
5915         * m2-exp.y (yylex): Update.
5916         * go-exp.y (lex_one_token): Update.
5917         * f-exp.y (yylex): Update.
5918         * d-exp.y (lex_one_token): Update.
5919         * c-exp.y (lex_one_token): Update.
5920         * ada-lex.l: Update.
5921
5922 2019-04-04  Tom Tromey  <tom@tromey.com>
5923
5924         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5925         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5926         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5927         * parser-defs.h (paren_depth): Don't declare.
5928         * parse.c (paren_depth): Remove global.
5929         (parse_exp_in_context): Update.
5930         * p-exp.y (paren_depth): New global.
5931         (pascal_parse): Initialize it.
5932         * m2-exp.y (paren_depth): New global.
5933         (m2_parse): Initialize it.
5934         * go-exp.y (paren_depth): New global.
5935         (go_parse): Initialize it.
5936         * f-exp.y (paren_depth): New global.
5937         (f_parse): Initialize it.
5938         * d-exp.y (paren_depth): New global.
5939         (d_parse): Initialize it.
5940         * c-exp.y (paren_depth): New global.
5941         (c_parse): Initialize it.
5942         * ada-lex.l (paren_depth): New global.
5943         (lexer_init): Initialize it.
5944
5945 2019-04-04  Tom Tromey  <tom@tromey.com>
5946
5947         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5948         (rust_parser::convert_ast_to_type)
5949         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5950         * parser-defs.h (struct parser_state) <parser_state>: Add
5951         parameters.  Initialize new members.
5952         <expression_context_block, expression_context_pc>: New members.
5953         * parse.c (expression_context_block, expression_context_pc):
5954         Remove globals.
5955         (parse_exp_in_context): Update.
5956         * p-exp.y: Update all rules.
5957         (yylex): Update.
5958         * m2-exp.y: Update all rules.
5959         (yylex): Update.
5960         * go-exp.y (yylex): Update.
5961         * f-exp.y (yylex): Update.
5962         * d-exp.y: Update all rules.
5963         (yylex): Update.
5964         * c-exp.y: Update all rules.
5965         (lex_one_token, classify_name, yylex, c_parse): Update.
5966         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5967
5968 2019-04-04  Tom Tromey  <tom@tromey.com>
5969
5970         * gdbarch.h, gdbarch.c: Rebuild.
5971         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5972         * stap-probe.h:
5973         (struct stap_parse_info): Replace "parser_state" with
5974         "expr_builder".
5975         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5976         (parser_state): New class.
5977         * parse.c (expr_builder): Rename.
5978         (expr_builder::release): Rename.
5979         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5980         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5981         (write_exp_elt_longcst, write_exp_elt_floatcst)
5982         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5983         (write_exp_string_vector, write_exp_bitstring)
5984         (write_exp_msymbol, mark_struct_expression)
5985         (write_dollar_variable)
5986         (insert_type_address_space, increase_expout_size): Replace
5987         "parser_state" with "expr_builder".
5988         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5989         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5990         "parser_state" with "expr_builder".
5991
5992 2019-04-04  Tom Tromey  <tom@tromey.com>
5993
5994         * rust-exp.y: Replace "parse_language" with method call.
5995         * p-exp.y:
5996         (yylex): Replace "parse_language" with method call.
5997         * m2-exp.y:
5998         (yylex): Replace "parse_language" with method call.
5999         * go-exp.y (classify_name): Replace "parse_language" with method
6000         call.
6001         * f-exp.y (yylex): Replace "parse_language" with method call.
6002         * d-exp.y (lex_one_token): Replace "parse_language" with method
6003         call.
6004         * c-exp.y:
6005         (lex_one_token, classify_name, yylex): Replace "parse_language"
6006         with method call.
6007         * ada-exp.y (find_primitive_type, type_char)
6008         (type_system_address): Replace "parse_language" with method call.
6009
6010 2019-04-04  Tom Tromey  <tom@tromey.com>
6011
6012         * rust-exp.y: Replace "parse_gdbarch" with method call.
6013         * parse.c (write_dollar_variable, insert_type_address_space):
6014         Replace "parse_gdbarch" with method call.
6015         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6016         call.
6017         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6018         call.
6019         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6020         "parse_gdbarch" with method call.
6021         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6022         with method call.
6023         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6024         "parse_gdbarch" with method call.
6025         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6026         "parse_gdbarch" with method call.
6027         * c-exp.y (parse_type, parse_number, classify_name): Replace
6028         "parse_gdbarch" with method call.
6029         * ada-lex.l: Replace "parse_gdbarch" with method call.
6030         * ada-exp.y (parse_type, find_primitive_type, type_char)
6031         (type_system_address): Replace "parse_gdbarch" with method call.
6032
6033 2019-04-04  Tom Tromey  <tom@tromey.com>
6034
6035         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6036         * stap-probe.c (stap_parse_argument): Update.
6037         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6038         initial_size parameter.
6039         * rust-exp.y (rust_lex_tests): Update.
6040         * parse.c (parser_state): Update.
6041         (parse_exp_in_context): Update.
6042         * parser-defs.h (struct parser_state) <parser_state>: Remove
6043         "initial_size" parameter.
6044
6045 2019-04-04  Tom Tromey  <tom@tromey.com>
6046
6047         * parser-defs.h (increase_expout_size): Don't declare.
6048         * parse.c (increase_expout_size): Now static.
6049
6050 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6051
6052         * gnu-nat.c (gnu_nat_target::wait): Fix
6053         target_waitstatus_to_string call.
6054
6055 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * eval.c (evaluate_subexp_standard): Handle internal functions
6058         during Fortran function call handling.
6059
6060 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * NEWS: Mention new internal functions.
6063         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6064         (read_base_type): Use dwarf2_init_complex_target_type.
6065         * value.c (creal_internal_fn): New function.
6066         (cimag_internal_fn): New function.
6067         (_initialize_values): Register new internal functions.
6068
6069 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6070
6071         * infrun.c (stop_all_threads): If debug_infrun, always
6072         trace the wait status after wait_one, using
6073         target_waitstatus_to_string and target_pid_to_str.
6074         (handle_inferior_event): Replace various trace of
6075         wait status kind by a single trace.
6076         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6077         wait status kind image by target_waitstatus_to_string.
6078         * target/waitstatus.c (target_waitstatus_to_string): Fix
6079         obsolete comment.
6080
6081 2019-04-01  Tom Tromey  <tromey@adacore.com>
6082
6083         PR symtab/23331:
6084         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6085
6086 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6087             Pedro Alves  <palves@redhat.com>
6088
6089         * top.c (quit_force): Call 'finalize_values'.
6090         * value.c (finalize_values): New function.
6091         * value.h (finalize_values): Declare.
6092
6093 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6094
6095         * NEWS: Announce $_gdb_major and $_gdb_minor.
6096
6097         * top.c (init_gdb_version_vars): New function.
6098         (gdb_init): Call init_gdb_version_vars.
6099
6100 2019-03-29  Tom Tromey  <tromey@adacore.com>
6101
6102         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6103         help text.  Remove dead code.
6104
6105 2019-03-29  Keith Seitz  <keiths@redhat.com>
6106
6107         From Siddhesh Poyarekar:
6108         * f-lang.h (f77_get_upperbound): Return LONGEST.
6109         (f77_get_lowerbound): Likewise.
6110         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6111         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6112         print them.
6113         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6114         plongest to format print it.
6115         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6116         (f77_get_upperbound): Likewise.
6117         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6118         LOWER_BOUND to LONGEST.
6119         (f77_create_arrayprint_offset_tbl): Likewise.
6120
6121 2019-03-29  Keith Seitz  <keiths@redhat.com>
6122
6123         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6124         %s/pulongest for TYPE_LENGTH instead of %d in format
6125         strings.
6126         * ada-typerint.c (ada_print_type): Likewise.
6127         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6128         * compile/compile-c-support.c (generate_register_struct): Likewise.
6129         * gdbtypes.c (recursive_dump_type): Likewise.
6130         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6131         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6132         instead of %d in format strings.
6133         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6134         to std::min to ULONGEST.
6135         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6136         instead of %d in format strings.
6137         * tracepoint.c (info_scope_command): Likewise.
6138         * typeprint.c (print_offset_data::update)
6139         (print_offset_data::finish): Likewise.
6140         * xtensa-tdep.c (xtensa_store_return_value)
6141         (xtensa_push_dummy_call): Likewise.
6142
6143 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6144
6145         * windows-nat.c (display_selector): Fixed format specifications
6146         for 64-bit Cygwin.
6147
6148 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6149
6150         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6151
6152 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6153
6154         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6155         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6156         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6157         (nios2_linux_init_abi): Install it.
6158
6159 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6160
6161         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6162
6163 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6164
6165         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6166
6167 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168             Tom Tromey  <tromey@adacore.com>
6169
6170         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6171
6172 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6173
6174         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6175         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6176         method to compute the bounds of range types. Also print "[evaluated]"
6177         if the bounds' values come from a dynamic evaluation.
6178
6179 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6182         whitespace when pretty printing is on.
6183
6184 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6185
6186         * ppc-linux-nat.c: Add include.
6187
6188 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6189
6190         * NEWS: Mention AArch64 Pointer Authentication.
6191
6192 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6193
6194         * arm-linux-nat.c: Add include.
6195
6196 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6197
6198         * source-cache.c (source_cache::get_source_lines): Re-read
6199         fullname after calling open_source_file.
6200
6201 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6202
6203         * NEWS: Mention TLS support for FreeBSD.
6204
6205 2019-03-25  Tom Tromey  <tromey@adacore.com>
6206
6207         * minsyms.c (BUNCH_SIZE): Update comment.
6208         (~minimal_symbol_reader): Remove old comment.
6209         (compact_minimal_symbols): Update comment.
6210         (minimal_symbol_reader::install): Remove old comment.  Update
6211         other comments.
6212
6213 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6214
6215         * s390-linux-nat.c: Add include.
6216
6217 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6218
6219         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6220         Call linux_get_hwcap.
6221         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6222         Likewise.
6223         (aarch64_linux_get_hwcap): Remove function.
6224         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6225         declaration.
6226         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6227         linux_get_hwcap.
6228         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6229         * linux-tdep.c (linux_get_hwcap): Add function.
6230         (linux_get_hwcap2): Likewise.
6231         * linux-tdep.h (linux_get_hwcap): Add declaration.
6232         (linux_get_hwcap2): Likewise.
6233         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6234         (ppc_linux_get_hwcap2): Likewise.
6235         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6236         linux_get_hwcap.
6237         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6238         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6239         (ppc_linux_nat_target::read_description): Likewise.
6240         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6241         * s390-linux-nat.c: Likewise.
6242         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6243
6244 2019-03-24  Tom Tromey  <tom@tromey.com>
6245
6246         * ada-lang.c (standard_lookup): Simplify initialization.
6247         (ada_lookup_symbol_nonlocal): Simplify return.
6248         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6249         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6250         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6251         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6252         initialization.
6253         * solib.c (solib_global_lookup): Simplify.
6254         * symtab.c (null_block_symbol): Remove.
6255         (symbol_cache_lookup): Simplify returns.
6256         (lookup_language_this): Simplify returns.
6257         (lookup_symbol_aux): Simplify return.
6258         (lookup_local_symbol): Simplify returns.
6259         (lookup_global_symbol_from_objfile): Simplify return.
6260         (lookup_symbol_in_objfile_symtabs)
6261         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6262         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6263         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6264         * cp-namespace.c (cp_lookup_bare_symbol)
6265         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6266         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6267         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6268         (cp_lookup_symbol_via_imports): Simplify initialization.
6269         (find_symbol_in_baseclass): Likewise.
6270         * symtab.h (null_block_symbol): Remove.
6271         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6272         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6273         (d_lookup_symbol_module): Likewise.
6274         (find_symbol_in_baseclass): Simplify initialization.
6275
6276 2019-03-24  Tom Tromey  <tom@tromey.com>
6277
6278         * expression.h: Don't include symtab.h.
6279         (struct block): Forward declare.
6280
6281 2019-03-24  Tom Tromey  <tom@tromey.com>
6282
6283         * c-exp.y (typebase): Remove casts.
6284         * gdbtypes.c (lookup_unsigned_typename, )
6285         (lookup_signed_typename): Remove cast.
6286         * eval.c (parse_to_comma_and_eval): Remove cast.
6287         * parse.c (write_dollar_variable): Remove cast.
6288         * block.h (struct block) <superblock>: Now const.
6289         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6290         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6291         (map_block): Make "block" const.
6292         * symfile.h (struct quick_symbol_functions)
6293         <map_matching_symbols>: Constify block argument to "callback".
6294         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6295         const.
6296         (find_pc_sect_compunit_symtab): Make "b" const.
6297         (find_symbol_at_address): Likewise.
6298         (search_symbols): Likewise.
6299         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6300         (dw2_debug_names_lookup_symbol): Likewise.
6301         (dw2_map_matching_symbols): Update.
6302         * p-valprint.c (pascal_val_print): Remove "block".
6303         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6304         (aux_add_nonlocal_symbols): Make "block" const.
6305         (resolve_subexp): Remove cast.
6306         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6307         const.
6308         (iterate_over_file_blocks): Likewise.
6309         * f-exp.y (%union) <bval>: Remove.
6310         * coffread.c (patch_opaque_types): Make "b" const.
6311         * spu-tdep.c (spu_catch_start): Make "block" const.
6312         * c-valprint.c (print_unpacked_pointer): Remove "block".
6313         * symmisc.c (dump_symtab_1): Make "b" const.
6314         (block_depth): Make "block" const.
6315         * d-exp.y (%union) <bval>: Remove.
6316         * cp-support.h (cp_lookup_rtti_type): Update.
6317         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6318         * psymtab.c (psym_lookup_symbol): Make "block" const.
6319         (maintenance_check_psymtabs): Make "b" const.
6320         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6321         (enumerate_locals, enumerate_args): Update.
6322         * python/py-symtab.c (stpy_global_block): Make "block" const.
6323         (stpy_static_block): Likewise.
6324         * inline-frame.c (block_starting_point_at): Make "new_block"
6325         const.
6326         * block.c (find_block_in_blockvector): Make return type const.
6327         (blockvector_for_pc_sect): Make "b" const.
6328         (find_block_in_blockvector): Make "b" const.
6329
6330 2019-03-23  Tom Tromey  <tom@tromey.com>
6331
6332         * varobj.c (varobj_create): Update.
6333         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6334         * printcmd.c (display_command, do_one_display): Don't reset
6335         innermost_block.
6336         * parser-defs.h (enum innermost_block_tracker_type): Move to
6337         expression.h.
6338         (innermost_block): Update comment.
6339         * parse.c (parse_exp_1): Add tracker_types parameter.
6340         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6341         tracker_types parameter.  Reset innermost_block.
6342         (parse_exp_in_context): Remove.
6343         (parse_expression_for_completion): Update.
6344         * objfiles.c (~objfile): Don't reset expression_context_block or
6345         innermost_block.
6346         * expression.h (enum innermost_block_tracker_type): Move from
6347         parser-defs.h.
6348         (parse_exp_1): Add tracker_types parameter.
6349         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6350         reset innermost_block.
6351
6352 2019-03-23  Tom Tromey  <tom@tromey.com>
6353
6354         * objfiles.h: Include bcache.h.
6355
6356 2019-03-23  Tom Tromey  <tom@tromey.com>
6357
6358         * linespec.c (get_current_search_block): Use
6359         scoped_restore_current_language.
6360         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6361
6362 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6363             Jiong Wang  <jiong.wang@arm.com>
6364
6365         * aarch64-linux-tdep.c
6366         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6367         section.
6368         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6369
6370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6371             Jiong Wang  <jiong.wang@arm.com>
6372
6373         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6374         instructions.
6375         (aarch64_analyze_prologue_test): Add PACIASP test.
6376         (aarch64_prologue_prev_register): Unmask PC value.
6377
6378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6379             Jiong Wang  <jiong.wang@arm.com>
6380
6381         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6382         (aarch64_dwarf2_prev_register): Unmask PC value.
6383         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6384         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6385         DW_CFA_AARCH64_negate_ra_state.
6386         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6387
6388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6389             Jiong Wang  <jiong.wang@arm.com>
6390
6391         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6392         registers.
6393         (aarch64_pseudo_register_name): Likewise.
6394         (aarch64_pseudo_register_type): Likewise.
6395         (aarch64_pseudo_register_reggroup_p): Likewise.
6396         (aarch64_gdbarch_init): Add pauth registers.
6397         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6398         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6399         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6400         (struct gdbarch_tdep): Add regnum for ra_state.
6401
6402 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6403             Jiong Wang  <jiong.wang@arm.com>
6404
6405         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6406
6407 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6408             Jiong Wang  <jiong.wang@arm.com>
6409
6410         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6411         function.
6412         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6413         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6414         (aarch64_gdbarch_init): Add puth registers.
6415         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6416         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6417         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6418
6419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6420             Jiong Wang  <jiong.wang@arm.com>
6421
6422         * aarch64-linux-nat.c
6423         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6424         * aarch64-linux-tdep.c
6425         (aarch64_linux_core_read_description): Likewise.
6426         (aarch64_linux_get_hwcap): New function.
6427         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6428         (aarch64_linux_get_hwcap): New declaration.
6429
6430 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6431             Jiong Wang  <jiong.wang@arm.com>
6432
6433         * aarch64-linux-nat.c
6434         (aarch64_linux_nat_target::read_description): Add pauth param.
6435         * aarch64-linux-tdep.c
6436         (aarch64_linux_core_read_description): Likewise.
6437         * aarch64-tdep.c (struct target_desc): Add in pauth.
6438         (aarch64_read_description): Add pauth param.
6439         (aarch64_gdbarch_init): Likewise.
6440         * aarch64-tdep.h (aarch64_read_description): Likewise.
6441         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6442         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6443         * features/Makefile: Add new files.
6444         * features/aarch64-pauth.c: New file.
6445         * features/aarch64-pauth.xml: New file.
6446
6447 2019-03-20  Tom Tromey  <tromey@adacore.com>
6448
6449         * infrun.c (handle_inferior_event): Rename from
6450         handle_inferior_event_1.  Create a scoped_value_mark.
6451         (handle_inferior_event): Remove.
6452
6453 2019-03-19  Tom Tromey  <tromey@adacore.com>
6454
6455         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6456         * infrun.h (print_stop_event): Add "displays" parameter.
6457         * infrun.c (print_stop_event): Add "displays" parameter.
6458
6459 2019-03-19  Pedro Alves  <palves@redhat.com>
6460
6461         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6462         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6463         to -1.  Fix TABs vs spaces.
6464         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6465         * tui/tui-out.h (tui_ui_out) Add intro comments.
6466         <m_line, m_start_of_line>: In-class initialize, and add describing
6467         comment.
6468
6469 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6470
6471         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6472         variable names.
6473         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6474
6475 2019-03-18  Pedro Alves  <palves@redhat.com>
6476             Eli Zaretskii <eliz@gnu.org>
6477
6478         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6479         m_line and m_start_of_line.
6480
6481 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6482
6483         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6484         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6485         it returns a newline.  This fixes a regression in TU mode, whereby
6486         the next line is output on the same screen line as the user input.
6487
6488 2019-03-18  Tom Tromey  <tromey@adacore.com>
6489
6490         * minsyms.c (minimal_symbol_reader::install): Remove call to
6491         obstack_blank.
6492
6493 2019-03-18  Pedro Alves  <palves@redhat.com>
6494
6495         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6496         New globals.
6497         (apply_style): New, factored out from ...
6498         (apply_ansi_escape): ... this.  Handle reverse video mode.
6499         (tui_set_reverse_mode): New function.
6500         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6501         * tui/tui-winsource.c (tui_show_source_line): Use
6502         tui_set_reverse_mode instead of setting A_STANDOUT.
6503         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6504         New setter methods.
6505
6506 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6507
6508         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6509         Handle tabs.
6510
6511 2019-03-18  Tom Tromey  <tromey@adacore.com>
6512
6513         * ada-lang.c (empty_array): Add "high" parameter.
6514         (ada_evaluate_subexp): Update.
6515
6516 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6517
6518         * unittests/string_view-selftests.c: Define
6519         _initialize_string_view_selftests unconditionally.
6520
6521 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6522
6523         PR gdb/24350
6524         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6525
6526 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6527
6528         PR gdb/24351
6529         * windows-nat.c (display_selector): Fix format specifiers.
6530
6531 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6532
6533         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6534         tui_refill_source_window instead of tui_refresh_win, to update the
6535         current execution line.  This fixes redisplay of the current line
6536         when stepping through the code with "next" or "step".
6537
6538 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6539
6540         * source-cache.c (source_cache::get_source_lines): Call
6541         find_source_lines to initialize s->nlines.  This fixes vertical
6542         scrolling of TUI source window when the DOWN arrow is pressed.
6543
6544 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6545
6546         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6547         linux-thread-db.c (_initialize_thread_db): Likewise.
6548
6549 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6550
6551         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6552         wclrtoeol in tui_show_source_line".  This reverts changes made in
6553         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6554
6555 2019-03-15  Tom Tromey  <tom@tromey.com>
6556
6557         * symtab.h (struct minimal_symbol): Derive from
6558         general_symbol_info.
6559         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6560         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6561         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6562         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6563         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6564         (MSYMBOL_SEARCH_NAME): Update.
6565         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6566         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6567         * minsyms.c (minimal_symbol_reader::record_full): Update.
6568
6569 2019-03-15  Tom Tromey  <tom@tromey.com>
6570
6571         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6572
6573 2019-03-15  Tom Tromey  <tom@tromey.com>
6574
6575         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6576         unique_xmalloc_ptr.
6577         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6578         Update.
6579         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6580         (build_minimal_symbol_hash_tables)
6581         (minimal_symbol_reader::install): Update.
6582
6583 2019-03-15  Tom Tromey  <tom@tromey.com>
6584
6585         * symtab.c (create_demangled_names_hash): Update.
6586         (symbol_set_names): Update.
6587         * objfiles.h (struct objfile_per_bfd_storage)
6588         <demangled_names_hash>: Now an htab_up.
6589         * objfiles.c (objfile_per_bfd_storage): Simplify.
6590
6591 2019-03-15  Tom Tromey  <tom@tromey.com>
6592
6593         * objfiles.h (struct objfile_per_bfd_storage): Declare
6594         destructor.
6595         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6596         New.
6597         (get_objfile_bfd_data): Use new.  Don't initialize
6598         language_of_main.
6599         (free_objfile_per_bfd_storage): Remove.
6600         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6601
6602 2019-03-15  Tom Tromey  <tom@tromey.com>
6603
6604         * symfile.c (reread_symbols): Update.
6605         * objfiles.c (objfile::objfile): Update.
6606         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6607         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6608         comment.
6609         (minimal_symbol_reader::install): Update.
6610         (terminate_minimal_symbol_table): Remove.
6611         * jit.c (jit_object_close_impl): Update.
6612
6613 2019-03-15  Tom Tromey  <tom@tromey.com>
6614
6615         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6616         initializations.
6617
6618 2019-03-15  Tom Tromey  <tom@tromey.com>
6619
6620         * objfiles.h (struct objfile_per_bfd_storage)
6621         <demangled_hash_languages>: Now a bitset.
6622         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6623         (lookup_minimal_symbol): Update.
6624
6625 2019-03-15  Tom Tromey  <tom@tromey.com>
6626
6627         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6628         Don't return the symbol.
6629         * coffread.c (record_minimal_symbol): Use record_full.
6630
6631 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6632
6633         The MS-Windows port of ncurses fails to switch to a color pair if
6634         one or both of the colors are the implicit default colors.  This
6635         change records the default colors when TUI is initialized, and
6636         then specifies them explicitly when a color pair uses the default
6637         colors.  This allows color styling in TUI mode on MS-Windows.
6638
6639         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6640         ncurses_norm_attr.
6641         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6642         colors in ncurses_norm_attr.
6643         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6644         "none", replace it with the default color recorded in
6645         ncurses_norm_attr.
6646
6647 2019-03-14  Tom Tromey  <tromey@adacore.com>
6648
6649         * source-cache.h (class source_cache) <get_source_lines>: Return
6650         std::string.
6651         * source-cache.c (source_cache::extract_lines): Handle case where
6652         first_pos==npos.  Return std::string.
6653         (source_cache::get_source_lines): Update.
6654
6655 2019-03-14  Tom Tromey  <tromey@adacore.com>
6656
6657         * NEWS: Add item for "style sources" commands.
6658         * source-cache.c (source_cache::get_source_lines): Check
6659         source_styling.
6660         * cli/cli-style.c (source_styling): New global.
6661         (_initialize_cli_style): Add "style sources" commands.
6662         (show_style_sources): New function.
6663         * cli/cli-style.h (source_styling): Declare.
6664
6665 2019-03-14  Pedro Alves  <palves@redhat.com>
6666             Tom Tromey  <tromey@adacore.com>
6667
6668         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6669         * tui/tui-winsource.c (tui_refill_source_window): New function,
6670         from...
6671         (tui_horizontal_source_scroll): ... here.  Move some logic.
6672         * cli/cli-style.c (set_style_enabled): Notify new observable.
6673         * tui/tui-hooks.c (tui_redisplay_source): New function.
6674         (tui_attach_detach_observers): Attach or detach
6675         tui_redisplay_source.
6676         * observable.h (source_styling_changed): New observable.
6677         * observable.c: Define source_styling_changed observable.
6678
6679 2019-03-13  Tom Tromey  <tromey@adacore.com>
6680
6681         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6682         (i386_gnu_nat_target::store_registers): Update.
6683         * target-debug.h (target_debug_print_std_string): New macro.
6684         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6685         * windows-tdep.c (display_one_tib): Update.
6686         * tui/tui-stack.c (tui_make_status_line): Update.
6687         * top.c (print_inferior_quit_action): Update.
6688         * thread.c (thr_try_catch_cmd): Update.
6689         (add_thread_with_info): Update.
6690         (thread_target_id_str): Update.
6691         (thr_try_catch_cmd): Update.
6692         (thread_command): Update.
6693         (thread_find_command): Update.
6694         * record-btrace.c (record_btrace_target::info_record)
6695         (record_btrace_resume_thread, record_btrace_target::resume)
6696         (record_btrace_cancel_resume, record_btrace_step_thread)
6697         (record_btrace_target::wait, record_btrace_target::wait)
6698         (record_btrace_target::wait, record_btrace_target::stop): Update.
6699         * progspace.c (print_program_space): Update.
6700         * process-stratum-target.c
6701         (process_stratum_target::thread_address_space): Update.
6702         * linux-fork.c (linux_fork_mourn_inferior)
6703         (detach_checkpoint_command, info_checkpoints_command)
6704         (linux_fork_context): Update.
6705         (linux_fork_detach): Update.
6706         (class scoped_switch_fork_info): Update.
6707         (delete_checkpoint_command): Update.
6708         * infrun.c (follow_fork_inferior): Update.
6709         (follow_fork_inferior): Update.
6710         (proceed_after_vfork_done): Update.
6711         (handle_vfork_child_exec_or_exit): Update.
6712         (follow_exec): Update.
6713         (displaced_step_prepare_throw): Update.
6714         (displaced_step_restore): Update.
6715         (start_step_over): Update.
6716         (resume_1): Update.
6717         (clear_proceed_status_thread): Update.
6718         (proceed): Update.
6719         (print_target_wait_results): Update.
6720         (do_target_wait): Update.
6721         (context_switch): Update.
6722         (stop_all_threads): Update.
6723         (restart_threads): Update.
6724         (finish_step_over): Update.
6725         (handle_signal_stop): Update.
6726         (switch_back_to_stepped_thread): Update.
6727         (keep_going_pass_signal): Update.
6728         (print_exited_reason): Update.
6729         (normal_stop): Update.
6730         * inferior.c (inferior_pid_to_str): Change return type.
6731         (print_selected_inferior): Update.
6732         (add_inferior): Update.
6733         (detach_inferior): Update.
6734         * dummy-frame.c (fprint_dummy_frames): Update.
6735         * dcache.c (dcache_info_1): Update.
6736         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6737         (btrace_fetch, btrace_clear): Update.
6738         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6739         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6740         type.
6741         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6742         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6743         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6744         * gdbarch.c, gdbarch.h: Rebuild.
6745         * gdbarch.sh (core_pid_to_str): Change return type.
6746         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6747         return type.
6748         (windows_nat_target::pid_to_str): Change return type.
6749         (windows_delete_thread): Update.
6750         (windows_nat_target::attach): Update.
6751         (windows_nat_target::files_info): Update.
6752         * target-delegates.c: Rebuild.
6753         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6754         return type.
6755         (sol_thread_target::pid_to_str): Change return type.
6756         * remote.c (class remote_target) <pid_to_str>: Change return
6757         type.
6758         (remote_target::pid_to_str): Change return type.
6759         (extended_remote_target::attach, remote_target::remote_stop_ns)
6760         (remote_target::remote_notif_remove_queued_reply)
6761         (remote_target::push_stop_reply, remote_target::disable_btrace):
6762         Update.
6763         (extended_remote_target::attach): Update.
6764         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6765         type.
6766         (gdbsim_target::pid_to_str): Change return type.
6767         * ravenscar-thread.c (struct ravenscar_thread_target)
6768         <pid_to_str>: Change return type.
6769         (ravenscar_thread_target::pid_to_str): Change return type.
6770         * procfs.c (class procfs_target) <pid_to_str>: Change return
6771         type.
6772         (procfs_target::pid_to_str): Change return type.
6773         (procfs_target::attach): Update.
6774         (procfs_target::detach): Update.
6775         (procfs_target::fetch_registers): Update.
6776         (procfs_target::store_registers): Update.
6777         (procfs_target::wait): Update.
6778         (procfs_target::files_info): Update.
6779         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6780         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6781         return type.
6782         (nto_procfs_target::pid_to_str): Change return type.
6783         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6784         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6785         return type.
6786         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6787         (exit_lwp): Update.
6788         (attach_proc_task_lwp_callback, get_detach_signal)
6789         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6790         (linux_nat_target::resume, wait_lwp, stop_callback)
6791         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6792         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6793         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6794         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6795         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6796         type.
6797         (inf_ptrace_target::attach): Update.
6798         (inf_ptrace_target::files_info): Update.
6799         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6800         type.
6801         (go32_nat_target::pid_to_str): Change return type.
6802         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6803         (gnu_nat_target::wait): Update.
6804         (gnu_nat_target::wait): Update.
6805         (gnu_nat_target::resume): Update.
6806         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6807         (fbsd_nat_target::wait): Update.
6808         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6809         type.
6810         (darwin_nat_target::attach): Update.
6811         * corelow.c (class core_target) <pid_to_str>: Change return type.
6812         (core_target::pid_to_str): Change return type.
6813         * target.c (normal_pid_to_str): Change return type.
6814         (default_pid_to_str): Likewise.
6815         (target_pid_to_str): Change return type.
6816         (target_translate_tls_address): Update.
6817         (target_announce_detach): Update.
6818         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6819         return type.
6820         (bsd_uthread_target::pid_to_str): Change return type.
6821         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6822         type.
6823         (bsd_kvm_target::pid_to_str): Change return type.
6824         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6825         return type.
6826         (aix_thread_target::pid_to_str): Change return type.
6827         * target.h (struct target_ops) <pid_to_str>: Change return type.
6828         (target_pid_to_str, normal_pid_to_str): Likewise.
6829         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6830         type.
6831         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6832         type.
6833         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6834         return type.
6835         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6836         type.
6837         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6838         type.
6839         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6840         return type.
6841
6842 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6843
6844         * NEWS: Mention that the new default MI version is 3.  Mention
6845         changes to the output of commands and events that deal with
6846         multi-location breakpoints.
6847         * breakpoint.c: Include "mi/mi-out.h".
6848         (print_one_breakpoint): Change output syntax if using MI version
6849         >= 3.
6850         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6851         New.
6852         (mi_multi_location_breakpoint_output_fixed): New.
6853         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6854         (mi_cmd_fix_multi_location_breakpoint_output): New.
6855         (mi_multi_location_breakpoint_output_fixed): New.
6856         * mi/mi-cmds.c (mi_cmds): Register command
6857         -fix-multi-location-breakpoint-output.
6858         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6859         interpreter "mi".
6860
6861 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6862
6863         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6864         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6865         instantiate mi_ui_out based on interpreter name.
6866         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6867         * mi/mi-main.c (mi_load_progress): Likewise.
6868
6869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6870
6871         * NEWS: Combine separate "New targets" sections for 8.3.
6872
6873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6874
6875         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6876         (ppcfbsd_init_abi): Install gdbarch
6877         "fetch_tls_load_module_address" and "get_thread_local_address"
6878         methods.
6879
6880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6881
6882         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6883         (riscv_fbsd_init_abi): Install gdbarch
6884         "fetch_tls_load_module_address" and "get_thread_local_address"
6885         methods.
6886
6887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6888
6889         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6890         (i386fbsd_init_abi): Install gdbarch
6891         "fetch_tls_load_module_address" and "get_thread_local_address"
6892         methods.
6893
6894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6895
6896         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6897         (amd64fbsd_init_abi): Install gdbarch
6898         "fetch_tls_load_module_address" and "get_thread_local_address"
6899         methods.
6900
6901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6902
6903         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6904         (struct fbsd_pspace_data): New type.
6905         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6906         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6907         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6908         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6909         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6910
6911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6912
6913         * gdbtypes.c (lookup_struct_elt): New function.
6914         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6915         * gdbtypes.h (struct struct_elt): New type.
6916         (lookup_struct_elt): New prototype.
6917
6918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6919
6920         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6921         remove disabled code block.
6922
6923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6924
6925         * gdbarch.sh (get_thread_local_address): New method.
6926         * gdbarch.h, gdbarch.c: Regenerate.
6927         * target.c (target_translate_tls_address): Use
6928         gdbarch_get_thread_local_address if present instead of
6929         target::get_thread_local_address.
6930
6931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6932
6933         * target.h (target::get_thread_local_address): Update comment.
6934
6935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6936
6937         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6938         objfile->separate_debug_objfile_backlink if not NULL.
6939
6940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6941
6942         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6943         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6944         (amd64bsd_store_inferior_registers): Likewise.
6945         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6946         Enable segment base registers.
6947         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6948         PT_GETFSBASE and PT_GETGSBASE.
6949         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6950         PT_SETGSBASE.
6951         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6952         segment base registers.
6953         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6954
6955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6956
6957         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6958         Update calls to i386_target_description to add 'segments'
6959         parameter.
6960         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6961         add segment base registers.
6962         * arch/i386.c (i386_create_target_description): Add 'segments'
6963         parameter to enable segment base registers.
6964         * arch/i386.h (i386_create_target_description): Likewise.
6965         * features/i386/32bit-segments.xml: New file.
6966         * features/i386/32bit-segments.c: Generate.
6967         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6968         call to i386_target_description to add 'segments' parameter.
6969         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6970         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6971         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6972         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6973         if feature is present.
6974         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6975         Add 'segments' parameter to call to i386_target_description.
6976         (i386_target_description): Add 'segments' parameter to enable
6977         segment base registers.
6978         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6979         to call to i386_target_description.
6980         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6981         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6982         Define I386_NUM_REGS.
6983         (i386_target_description): Add 'segments' parameter to enable
6984         segment base registers.
6985
6986 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6987
6988         PR/24325
6989         * source-cache.c: #undef open and close, to avoid unresolved
6990         externals during linking.
6991
6992 2019-03-12  Tom Tromey  <tromey@adacore.com>
6993
6994         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6995         const.  Add initializers.
6996         (_initialize_remote): Don't initialize ptid globals.
6997
6998 2019-03-12  Pedro Alves  <palves@redhat.com>
6999
7000         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7001
7002 2019-03-12  Pedro Alves  <palves@redhat.com>
7003
7004         * cp-name-parser.y (main): Remove unused 'len' variable.
7005
7006 2019-03-12  Tom Tromey  <tromey@adacore.com>
7007
7008         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7009         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7010
7011 2019-03-12  Tom Tromey  <tromey@adacore.com>
7012
7013         * linux-nat.c (iterate_over_lwps): Update.
7014         (stop_callback): Remove parameter.
7015         (stop_wait_callback, detach_callback, resume_set_callback)
7016         (select_singlestep_lwp_callback, set_ignore_sigint)
7017         (status_callback, resumed_callback, resume_clear_callback)
7018         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7019         data parameter.
7020         (linux_nat_target::detach, linux_nat_target::resume)
7021         (linux_stop_and_wait_all_lwps, select_event_lwp)
7022         (linux_nat_filter_event, linux_nat_wait_1)
7023         (linux_nat_target::kill, linux_nat_target::stop)
7024         (linux_nat_target::stop): Update.
7025         (linux_nat_resume_callback): Change type.
7026         (resume_stopped_resumed_lwps, count_events_callback)
7027         (select_event_lwp_callback): Likewise.
7028         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7029         * arm-linux-nat.c (struct update_registers_data): Remove.
7030         (update_registers_callback): Change type.
7031         (arm_linux_insert_hw_breakpoint1): Update.
7032         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7033         parameter.
7034         (x86_linux_dr_set_addr): Update.
7035         (x86_linux_dr_set_control): Update.
7036         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7037         (iterate_over_lwps): Use gdb::function_view.
7038         * nat/aarch64-linux-hw-point.c (struct
7039         aarch64_dr_update_callback_param): Remove.
7040         (debug_reg_change_callback): Change type.
7041         (aarch64_notify_debug_reg_change): Update.
7042         * s390-linux-nat.c (s390_refresh_per_info): Update.
7043
7044 2019-03-11  Tom Tromey  <tromey@adacore.com>
7045
7046         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7047         redundant assignment to "this_cu".
7048
7049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7050
7051         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7052
7053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7054
7055         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7056         from...
7057         (rank_one_type): ... this.
7058
7059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7060
7061         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7062         from...
7063         (rank_one_type): ... this.
7064
7065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7066
7067         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7068         from...
7069         (rank_one_type): ... this.
7070
7071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7072
7073         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7074         from...
7075         (rank_one_type): ... this.
7076
7077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7078
7079         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7080         from...
7081         (rank_one_type): ... this.
7082
7083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7084
7085         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7086         from...
7087         (rank_one_type): ... this.
7088
7089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7090
7091         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7092         from...
7093         (rank_one_type): ... this.
7094
7095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7096
7097         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7098         from...
7099         (rank_one_type): ... this.
7100
7101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7102
7103         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7104         from...
7105         (rank_one_type): ... this.
7106
7107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7108
7109         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7110         from...
7111         (rank_one_type): ... this.
7112
7113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7114
7115         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7116         from...
7117         (rank_one_type): ... this.
7118
7119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7120
7121         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7122         from...
7123         (rank_one_type): ... this.
7124
7125 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7126
7127         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7128         inferior-events' shows the example events.
7129
7130 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7131
7132         Support styling on native MS-Windows console
7133
7134         PR/24315
7135         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7136         on MS-Windows if $TERM is not defined.
7137
7138         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7139
7140         * posix-hdep.c (gdb_console_fputs):
7141         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7142         functions.
7143         * ui-file.h (gdb_console_fputs): Add prototype.
7144
7145         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7146         back to fputs only if the former returns zero.
7147
7148 2019-03-07  Tom Tromey  <tom@tromey.com>
7149
7150         * symmisc.c (print_symbol_bcache_statistics): Update.
7151         (print_objfile_statistics): Update.
7152         * symfile.c (allocate_symtab): Update.
7153         * stabsread.c: Don't include bcache.h.
7154         * psymtab.h (struct psymbol_bcache): Don't declare.
7155         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7156         (psymbol_bcache_init, psymbol_bcache_free)
7157         (psymbol_bcache_get_bcache): Don't declare.
7158         * psymtab.c (struct psymbol_bcache): Remove.
7159         (psymtab_storage::psymtab_storage): Update.
7160         (psymtab_storage::~psymtab_storage): Update.
7161         (psymbol_bcache_init, psymbol_bcache_free)
7162         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7163         (add_psymbol_to_bcache): Update.
7164         (allocate_psymtab): Update.
7165         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7166         macro_cache>: No longer pointers.
7167         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7168         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7169         * macrotab.c (macro_bcache): Update.
7170         * macroexp.c: Don't include bcache.h.
7171         * gdbtypes.c (check_types_worklist): Update.
7172         (types_deeply_equal): Remove TRY/CATCH.  Update.
7173         * elfread.c (elf_symtab_read): Update.
7174         * dwarf2read.c: Don't include bcache.h.
7175         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7176         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7177         (print_bcache_statistics, bcache_memory_used): Don't declare.
7178         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7179         methods.  Rename all data members.
7180         * bcache.c (struct bcache): Move to bcache.h.
7181         (bcache::expand_hash_table): Rename from expand_hash_table.
7182         (bcache): Remove.
7183         (bcache::insert): Rename from bcache_full.
7184         (bcache::compare): Rename from bcache_compare.
7185         (bcache_xmalloc): Remove.
7186         (bcache::~bcache): Rename from bcache_xfree.
7187         (bcache::print_statistics): Rename from print_bcache_statistics.
7188         (bcache::memory_used): Rename from bcache_memory_used.
7189
7190 2019-03-07  Pedro Alves  <palves@redhat.com>
7191
7192         * infrun.c (normal_stop): Also check for
7193         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7194
7195 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * f-lang.c (value_from_host_double): Moved to...
7198         * value.c (value_from_host_double): ...here.
7199         * value.h (value_from_host_double): Declare.
7200         * guile/scm-math.c (vlscm_convert_typed_number): Use
7201         value_from_host_double.
7202         (vlscm_convert_number): Likewise.
7203         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7204         * python/py-value.c (convert_value_from_python): Likewise.
7205
7206 2019-03-06  Tom Tromey  <tom@tromey.com>
7207
7208         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7209
7210 2019-03-06  Tom Tromey  <tom@tromey.com>
7211
7212         * utils.h (free_current_contents): Don't declare.
7213         * utils.c (free_current_contents): Remove.
7214
7215 2019-03-06  Tom Tromey  <tom@tromey.com>
7216
7217         * top.c (quit_force): Update.
7218         * main.c (captured_command_loop): Update.
7219         * common/new-op.c (operator new): Update.
7220         * common/common-exceptions.c (struct catcher)
7221         <save_cleanup_chain>: Remove member.
7222         (exceptions_state_mc_init): Update.
7223         (exception_try_scope_entry): Return nullptr.
7224         (exception_try_scope_exit, exception_rethrow)
7225         (throw_exception_sjlj, throw_exception_cxx): Update.
7226         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7227         (all_cleanups, do_cleanups, discard_cleanups)
7228         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7229         (restore_cleanups, restore_final_cleanups): Don't declare.
7230         (do_final_cleanups): Remove parameter.
7231         * common/cleanups.c (cleanup_chain, make_cleanup)
7232         (make_cleanup_dtor, all_cleanups, do_cleanups)
7233         (discard_my_cleanups, discard_cleanups)
7234         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7235         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7236         (null_cleanup): Remove.
7237         (do_final_cleanups): Remove parameter.
7238
7239 2019-03-06  Tom Tromey  <tom@tromey.com>
7240
7241         * remote.c (remote_target::remote_parse_stop_reply): Use
7242         unique_xmalloc_ptr.
7243
7244 2019-03-06  Tom Tromey  <tom@tromey.com>
7245
7246         * stabsread.c (struct stabs_field_info): Rename from field_info.
7247         <list, fnlist>: Add initializers.
7248         <obstack>: New member.
7249         (read_member_functions, read_struct_fields, read_baseclasses):
7250         Allocate on obstack.  Don't use cleanups.
7251         (read_one_struct_field, read_member_functions, read_struct_fields)
7252         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7253         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7254         (read_struct_type): Update.
7255
7256 2019-03-06  Tom Tromey  <tom@tromey.com>
7257
7258         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7259         * common/filestuff.h (make_cleanup_close): Don't declare.
7260         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7261         Remove.
7262
7263 2019-03-06  Tom Tromey  <tom@tromey.com>
7264
7265         * solib-aix.c: Use make_scope_exit.
7266
7267 2019-03-06  Tom Tromey  <tom@tromey.com>
7268
7269         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7270         Use make_scope_exit.
7271
7272 2019-03-06  Tom Tromey  <tom@tromey.com>
7273
7274         * solib-svr4.c (disable_probes_interface): Remove parameter.
7275         (svr4_handle_solib_event): Use make_scope_exit.
7276
7277 2019-03-06  Tom Tromey  <tom@tromey.com>
7278
7279         * remote.c (struct stop_reply_deleter): Remove.
7280         (stop_reply_up): Update.
7281         (struct stop_reply): Derive from notif_event.  Don't typedef.
7282         <regcache>: Now a std::vector.
7283         (stop_reply_xfree): Remove.
7284         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7285         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7286         (remote_target::discard_pending_stop_replies): Use delete.
7287         (remote_target::remote_parse_stop_reply): Update.
7288         (remote_target::process_stop_reply): Update.
7289         * remote-notif.h (struct notif_event): Add virtual destructor.
7290         Remove "dtr" member.
7291         (struct notif_client) <alloc_event>: Return a unique_ptr.
7292         (notif_event_xfree): Don't declare.
7293         (notif_event_up): New typedef.
7294         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7295         (notif_event_xfree, do_notif_event_xfree): Remove.
7296         (remote_notif_state_xfree): Update.
7297
7298 2019-03-06  Tom Tromey  <tom@tromey.com>
7299
7300         * infrun.c (displaced_step_clear_cleanup): Now a
7301         forward_scope_exit type.
7302         (displaced_step_prepare_throw): Update.
7303         (displaced_step_fixup): Update.
7304
7305 2019-03-06  Tom Tromey  <tom@tromey.com>
7306
7307         * inferior.h (class inferior): Update comment.
7308         * gdbthread.h (class thread_info): Update comment.
7309
7310 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7311             Tom Tromey  <tom@tromey.com>
7312
7313         * stabsread.h (struct stab_section_list): Remove.
7314         (coffstab_build_psymtabs): Update.
7315         * dbxread.c (symbuf_sections): Now a std::vector.
7316         (sect_idx): New global.
7317         (fill_symbuf): Update.
7318         (coffstab_build_psymtabs): Change type of stabsects parameter.
7319         Update.
7320         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7321         std::vector.
7322         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7323         (coff_locate_sections): Update.
7324         (coff_symfile_read): Remove cleanups.  Update.
7325         (init_stringtab): Add storage parameter.
7326         (free_stringtab, free_stringtab_cleanup): Remove.
7327         (init_lineno): Add storage parameter.
7328         (free_linetab, free_linetab_cleanup): Remove.
7329
7330 2019-03-06  Pedro Alves  <palves@redhat.com>
7331
7332         * linux-fork.c (fork_info::clobber_regs): Delete.
7333         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7334         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7335         comment.  Adjust.
7336         (scoped_switch_fork_info::scoped_switch_fork_info)
7337         (checkpoint_command, linux_fork_context): Adjust
7338         fork_save_infrun_state calls.
7339
7340 2019-03-06  Pedro Alves  <palves@redhat.com>
7341
7342         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7343         (inf_has_multiple_threads): Return 'bool' and rewrite using
7344         inferior_info::threads().
7345
7346 2019-03-06  Pedro Alves  <palves@redhat.com>
7347
7348         * linux-fork.c: Include <list>.
7349         (fork_list): Now a std::list instance.
7350         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7351         (forks_exist_p, find_last_fork): Adjust.
7352         (new_fork): Delete.
7353         (one_fork_p): New.
7354         (add_fork): Adjust.
7355         (free_fork): Delete, folded into fork_info::~fork_info().
7356         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7357         Adjust.
7358         (init_fork_list): Delete.
7359         (linux_fork_killall, linux_fork_mourn_inferior)
7360         (linux_fork_detach, info_checkpoints_command): Adjust.
7361         (_initialize_linux_fork): No longer call init_fork_list.
7362
7363 2019-03-06  Pedro Alves  <palves@redhat.com>
7364
7365         * linux-fork.c (new_fork): New, split out of ...
7366         (add_fork): ... this.  Return void.  Move "first fork" special
7367         case from here, to ...
7368         (checkpoint_command): ... here.
7369         * linux-linux.h (add_fork): Return void.
7370
7371 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7372
7373         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7374
7375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7376             Chris January  <chris.january@arm.com>
7377             David Lecomber  <david.lecomber@arm.com>
7378
7379         * f-exp.y: New token, UNOP_INTRINSIC.
7380         (exp): New pattern using UNOP_INTRINSIC token.
7381         (f77_keywords): Add 'abs' keyword.
7382         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7383         (value_from_host_double): New function.
7384         (evaluate_subexp_f): Support UNOP_ABS.
7385
7386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7389         types.
7390
7391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7392
7393         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7394         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7395         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7396
7397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7398
7399         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7400
7401 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7402             Chris January  <chris.january@arm.com>
7403
7404         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7405         * f-exp.y: Define 'KIND' token.
7406         (exp): New pattern for KIND expressions.
7407         (ptype): Handle types with a kind extension.
7408         (direct_abs_decl): Extend to spot kind extensions.
7409         (f77_keywords): Add 'kind' to the list.
7410         (push_kind_type): New function.
7411         (convert_to_kind_type): New function.
7412         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7413         * parse.c (operator_length_standard): Likewise.
7414         * parser-defs.h (enum type_pieces): Add tp_kind.
7415         * std-operator.def: Add UNOP_KIND.
7416
7417 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7418
7419         * f-exp.y (f_parse): Set yydebug.
7420
7421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7422
7423         * f-lang.c (evaluate_subexp_f): New function.
7424         (exp_descriptor_f): New global.
7425         (f_language_defn): Use exp_descriptor_f instead of
7426         exp_descriptor_standard.
7427
7428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7429
7430         * f-exp.y (struct token): Add comments.
7431         (dot_ops): Remove uppercase versions and the end marker.
7432         (f77_keywords): Likewise.
7433         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7434         entries in the dot_ops array are case insensitive, and use
7435         strncasecmp to compare strings.  Also some whitespace cleanup in
7436         this area.  Similar for the f77_keywords array, except entries in
7437         this list might be case sensitive.
7438
7439 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * f-exp.y (struct f77_boolean_val): Add comments.
7442         (boolean_values): Remove uppercase versions, and end marker.
7443         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7444         and use strncasecmp to achieve case insensitivity.  Additionally,
7445         perform whitespace cleanup around this code.
7446
7447 2019-03-06  Tom Tromey  <tromey@adacore.com>
7448
7449         * remote-sim.c (gdbsim_target_open): Use result of
7450         gdb_argv::release.
7451
7452 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7453         Dirk Schubert  <dirk.schubert@arm.com>
7454         Chris January  <chris.january@arm.com>
7455
7456         * eval.c (evaluate_subexp_standard): Call Fortran argument
7457         wrapping logic.
7458         * f-lang.c (struct value): A value which can be passed into a
7459         Fortran function call.
7460         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7461         where appropriate.
7462         (struct type): Value ready for a Fortran function call.
7463         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7464         is needed.
7465         * f-lang.h (fortran_argument_convert): Declaration.
7466         (fortran_preserve_arg_pointer): Declaration.
7467         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7468
7469 2019-03-05  Tom Tromey  <tromey@adacore.com>
7470
7471         * python/py-prettyprint.c (print_string_repr): Remove #if.
7472         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7473
7474 2019-03-05  Tom Tromey  <tromey@adacore.com>
7475
7476         * target.c (the_dummy_target): Move later.  Change type to
7477         "dummy_target".
7478         (initialize_targets): Don't initialize the_dummy_target.
7479
7480 2019-03-05  Tom Tromey  <tromey@adacore.com>
7481
7482         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7483         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7484
7485 2019-03-05  Tom Tromey  <tromey@adacore.com>
7486
7487         * windows-nat.c (windows_nat_target::attach)
7488         (windows_nat_target::detach): Don't call gdb_flush.
7489         * valprint.c (generic_val_print, val_print, val_print_string):
7490         Don't call gdb_flush.
7491         * utils.c (defaulted_query): Don't call gdb_flush.
7492         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7493         * target.c (target_announce_detach): Don't call gdb_flush.
7494         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7495         * remote.c (extended_remote_target::attach): Don't call
7496         gdb_flush.
7497         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7498         * printcmd.c (do_examine): Don't call gdb_flush.
7499         (info_display_command): Don't call gdb_flush.
7500         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7501         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7502         * memattr.c (info_mem_command): Don't call gdb_flush.
7503         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7504         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7505         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7506         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7507         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7508         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7509         (gnu_nat_target::detach): Don't call gdb_flush.
7510         * f-valprint.c (f_val_print): Don't call gdb_flush.
7511         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7512         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7513         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7514         gdb_flush.
7515         * c-valprint.c (c_val_print): Don't call gdb_flush.
7516         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7517
7518 2019-03-05  Tom Tromey  <tromey@adacore.com>
7519
7520         * varobj.c (update_dynamic_varobj_children): Update.
7521         (install_default_visualizer): Use reset, not release.
7522         * value.c (set_internalvar): Update.
7523         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7524         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7525         ATTRIBUTE_UNUSED_RESULT.
7526
7527 2019-03-05  Tom Tromey  <tromey@adacore.com>
7528
7529         * remote.c (class scoped_remote_fd) <release>: Add
7530         ATTRIBUTE_UNUSED_RESULT.
7531
7532 2019-03-05  Tom Tromey  <tromey@adacore.com>
7533
7534         * macroexp.c (struct macro_buffer) <release>: Add
7535         ATTRIBUTE_UNUSED_RESULT.
7536
7537 2019-03-05  Tom Tromey  <tromey@adacore.com>
7538
7539         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7540         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7541         ATTRIBUTE_UNUSED_RESULT.
7542
7543 2019-03-05  Tom Tromey  <tromey@adacore.com>
7544
7545         * common/scoped_fd.h (class scoped_fd) <release>: Add
7546         ATTRIBUTE_UNUSED_RESULT.
7547
7548 2019-03-05  Tom Tromey  <tromey@adacore.com>
7549
7550         * parser-defs.h (struct parser_state) <release>: Add
7551         ATTRIBUTE_UNUSED_RESULT.
7552
7553 2019-03-05  Tom Tromey  <tromey@adacore.com>
7554
7555         * utils.h (class gdb_argv) <release>: Add
7556         ATTRIBUTE_UNUSED_RESULT.
7557         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7558
7559 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7560
7561         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7562         for-loop range, to avoid compiler warnings.
7563
7564         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7565         avoid compiler warnings about unused variables.
7566
7567         * NEWS: Mention end of support for native debugging on MS-Windows
7568         before XP.
7569
7570         PR gdb/24292
7571         * common/netstuff.c:
7572         * gdbserver/gdbreplay.c
7573         * gdbserver/remote-utils.c:
7574         * ser-tcp.c:
7575         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7576         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7577         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7578         'getaddrinfo' and 'freeaddrinfo' were not available before
7579         Windows XP, and mingw.org's MinGW headers by default define
7580         _WIN32_WINNT to 0x500.
7581
7582 2019-03-01  Gary Benson <gbenson@redhat.com>
7583
7584         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7585
7586 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7587             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7588
7589         PR gdb/8527
7590         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7591         set_sigint_trap, clear_sigint_trap.
7592
7593 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7594
7595         * target.c (target_detach): Clear the regcache and the
7596         frame cache.
7597
7598 2019-02-27  Pedro Alves  <palves@redhat.com>
7599
7600         * utils.c (set_screen_size): When we cap the height/width sizes,
7601         tweak the corresponding command variable to show "unlimited":
7602
7603 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7604             Pedro Alves  <palves@redhat.com>
7605
7606         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7607         before calling rl_set_screen_size.
7608
7609 2019-02-27  Tom Tromey  <tromey@adacore.com>
7610
7611         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7612         define.
7613         * python/py-value.c: Remove Python 2.4 workaround.
7614         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7615         workaround.
7616         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7617         Python 2.4 workaround.
7618         * python/python-internal.h: Remove Python 2.4 comment.
7619         (Py_ssize_t): Don't define.
7620         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7621         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7622         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7623         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7624         * python/python.c (do_start_initialization): Remove Python 2.4
7625         workaround.
7626         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7627         (print_children): Remove Python 2.4 workaround.
7628         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7629         workaround.
7630         (CHARBUFFERPROC_NAME): Remove.
7631         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7632         Python 2.4 workaround.
7633
7634 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7635
7636         * NEWS: Note minimum Python version.
7637
7638 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7639
7640         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7641         code from these functions.  Remove corresponding ifdefs.  Use
7642         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7643         Remove gotos and target of gotos.
7644         (infpy_search_memory): Likewise.
7645
7646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7647
7648         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7649         (hppa_gdbarch_init): Don't register deleted functions with
7650         gdbarch.
7651
7652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7655         (h8300_unwind_sp): Delete.
7656         (h8300_dummy_id): Delete.
7657         (h8300_gdbarch_init): Don't register deleted functions with
7658         gdbarch.
7659
7660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7663         (ft32_unwind_pc): Delete.
7664         (ft32_unwind_sp): Delete.
7665         (ft32_gdbarch_init): Don't register deleted functions with
7666         gdbarch.
7667
7668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7671         (frv_unwind_pc): Delete.
7672         (frv_unwind_sp): Delete.
7673         (frv_gdbarch_init): Don't register deleted functions with
7674         gdbarch.
7675
7676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7679         (riscv_unwind_pc): Delete.
7680         (riscv_unwind_sp): Delete.
7681         (riscv_gdbarch_init): Don't register deleted functions with
7682         gdbarch.
7683
7684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7687         (csky_unwind_pc): Delete.
7688         (csky_unwind_sp): Delete.
7689         (csky_gdbarch_init): Don't register deleted functions with
7690         gdbarch.
7691
7692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7695         (cris_unwind_pc): Delete.
7696         (cris_unwind_sp): Delete.
7697         (cris_gdbarch_init): Don't register deleted functions with
7698         gdbarch.
7699
7700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7701
7702         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7703         (bfin_unwind_pc): Delete.
7704         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7705
7706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7707
7708         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7709         (arm_unwind_pc): Delete.
7710         (arm_unwind_sp): Delete.
7711         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7712
7713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7716         (arc_unwind_pc): Delete.
7717         (arc_unwind_sp): Delete.
7718         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7719
7720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7721
7722         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7723         (alpha_unwind_pc): Delete.
7724         (alpha_gdbarch_init): Don't register deleted functions with
7725         gdbarch.
7726
7727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7730         (aarch64_unwind_pc): Delete.
7731         (aarch64_unwind_sp): Delete.
7732         (aarch64_gdbarch_init): Don't register deleted functions with
7733         gdbarch.
7734
7735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * gdbtypes.c (type_align): Don't consider static members when
7738         computing structure alignment.
7739
7740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7743         return 0 for other types.
7744         * arch-utils.c (default_type_align): Always return 0.
7745         * gdbarch.h: Regenerate.
7746         * gdbarch.sh (type_align): Extend comment.
7747         * gdbtypes.c (type_align): Add additional comments, always call
7748         gdbarch_type_align before applying the default rules.
7749         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7750         generic code will then apply a suitable default.
7751         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7752         types, return 0 for other types.
7753
7754 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7755
7756         * NEWS: Create a new section for the next release branch.
7757         Rename the section of the current branch, now that it has
7758         been cut.
7759
7760 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7761
7762         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7763         * version.in: Bump version to 8.3.50.DATE-git.
7764
7765 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7766
7767         * aix-thread.c (ptid_cmp): Remove unused variable.
7768         (get_signaled_thread): Likewise.
7769         (store_regs_user_thread): Likewise.
7770         (store_regs_kernel_thread): Likewise.
7771         (fetch_regs_kernel_thread): Remove shadowed variable.
7772
7773 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * features/riscv/32bit-cpu.xml: Add register numbers.
7776         * features/riscv/32bit-fpu.c: Regenerate.
7777         * features/riscv/32bit-fpu.xml: Add register numbers.
7778         * features/riscv/64bit-cpu.xml: Add register numbers.
7779         * features/riscv/64bit-fpu.c: Regenerate.
7780         * features/riscv/64bit-fpu.xml: Add register numbers.
7781
7782 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7783
7784         * NEWS: Mention two argument form of gdb.Value constructor.
7785         * python/py-value.c (convert_buffer_and_type_to_value): New
7786         function.
7787         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7788         Add support for handling an optional second argument.  Call
7789         convert_buffer_and_type_to_value as appropriate.
7790         * python/python-internal.h (Py_buffer_deleter): New struct.
7791         (Py_buffer_up): New typedef.
7792
7793 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7794
7795         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7796         instead of releasing ownership.
7797
7798 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7799
7800         * dwarf2read.c (open_and_init_dwp_file): Call
7801         elf_numsections instead of bfd_count_sections to initialize
7802         dwp_file->num_sections.
7803
7804 2019-02-25  Tom Tromey  <tromey@adacore.com>
7805
7806         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7807
7808 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7809
7810         * gcore.in: Add '--readnever' option when invoking GDB.
7811
7812 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7813
7814         * MAINTAINERS: Update my email address.
7815
7816 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7817
7818         * build-id.c (build_id_to_debug_bfd_1): New function.
7819         (build_id_to_debug_bfd): Look for separate debug file in
7820         sysroot.
7821
7822 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * gdbarch.sh: Update the copyright year range that is placed into
7825         generated files.
7826
7827 2019-02-22  Keith Seitz  <keiths@redhat.com>
7828
7829         PR symtab/23853
7830         * linespec.c (create_sals_line_offset): Search for the default
7831         symtab's filename instead of its fullname.
7832
7833 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7834
7835         * NEWS: Update style defaults.
7836
7837 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7838
7839         * main.c (captured_main_1): Disable styling in batch mode.
7840
7841 2019-02-20  Tom Tromey  <tom@tromey.com>
7842
7843         * symtab.c (symtab_symbol_info): Fix typos.
7844
7845 2019-02-20  Tom Tromey  <tromey@adacore.com>
7846
7847         * findcmd.c (_initialize_mem_search): Use upper case for
7848         metasyntactic variables.
7849
7850 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7851
7852         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7853         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7854
7855 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7856
7857         * top.h (source_file_name): Change to std::string.
7858         * top.c (source_file_name): Likewise.
7859         (command_line_input): Adjust.
7860         * cli/cli-script.c (script_from_file): Adjust.
7861
7862 2019-02-19  Tom Tromey  <tromey@adacore.com>
7863
7864         * ravenscar-thread.c
7865         (ravenscar_thread_target::update_thread_list): Don't call
7866         ada_build_task_list.
7867         * ada-lang.h (ada_build_task_list): Don't declare.
7868         * ada-tasks.c (struct ada_tasks_inferior_data)
7869         <task_list_valid_p>: Now bool.
7870         (read_known_tasks, ada_task_list_changed)
7871         (ada_tasks_invalidate_inferior_data): Update.
7872         (read_known_tasks_array): Return bool.
7873         (read_known_tasks_list): Likewise.
7874         (read_known_tasks): Return void.
7875         (ada_build_task_list): Now static.
7876
7877 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7878
7879         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7880         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7881
7882 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883
7884         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7885         variant for ada_tasks_pspace_data_handle and
7886         ada_tasks_inferior_data_handle.
7887         (ada_tasks_pspace_data_cleanup): New function.
7888         (ada_tasks_inferior_data_cleanup): New function.
7889
7890 2019-02-17  Tom Tromey  <tom@tromey.com>
7891
7892         * macrotab.h (macro_source_fullname): Return a std::string.
7893         * macrotab.c (macro_include, check_for_redefinition)
7894         (macro_undef, macro_lookup_definition, foreach_macro)
7895         (foreach_macro_in_scope): Update.
7896         (macro_source_fullname): Return a std::string.
7897         * macrocmd.c (show_pp_source_pos): Update.
7898
7899 2019-02-17  Tom Tromey  <tom@tromey.com>
7900
7901         * macrocmd.c (show_pp_source_pos): Style the file names.
7902
7903 2019-02-17  Tom Tromey  <tom@tromey.com>
7904
7905         PR tui/24197:
7906         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7907
7908 2019-02-17  Tom Tromey  <tom@tromey.com>
7909
7910         * ada-lang.c (user_select_syms): Use filtered printing.
7911         * utils.c (wrap_style): New global.
7912         (desired_style): Remove.
7913         (emit_style_escape): Add stream parameter.
7914         (set_output_style, reset_terminal_style, prompt_for_continue):
7915         Update.
7916         (flush_wrap_buffer): Only flush gdb_stdout.
7917         (wrap_here): Set wrap_style.
7918         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7919         treat escape sequences as a character.  Change when wrap buffer is
7920         flushed.
7921         (fputs_styled): Do not set the output style when the default is
7922         requested.
7923         * ui-style.h (struct ui_file_style) <is_default>: New method.
7924         * source.c (print_source_lines_base): Emit escape sequences in one
7925         piece.
7926
7927 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7928
7929         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7930         integers and enumeration types.
7931
7932 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7933
7934         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7935         instead of lookup_symbol_in_language
7936         (do_exact_match): New function.
7937         (ada_get_symbol_name_matcher): Return do_exact_match when
7938         doing a verbatim match.
7939
7940 2019-02-15  Tom Tromey  <tromey@adacore.com>
7941
7942         * ravenscar-thread.c (ravenscar_thread_target::resume)
7943         (ravenscar_thread_target::wait): Special case wildcard requests.
7944
7945 2019-02-15  Tom Tromey  <tromey@adacore.com>
7946
7947         * ravenscar-thread.c (base_ptid): Remove.
7948         (struct ravenscar_thread_target) <close>: New method.
7949         <m_base_ptid>: New member.
7950         <update_inferior_ptid, active_task, task_is_currently_active,
7951         runtime_initialized>: Declare methods.
7952         <ravenscar_thread_target>: Add constructor.
7953         (ravenscar_thread_target::task_is_currently_active)
7954         (ravenscar_thread_target::update_inferior_ptid)
7955         (ravenscar_runtime_initialized): Rename.  Now methods.
7956         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7957         (ravenscar_thread_target::update_thread_list): Update.
7958         (ravenscar_thread_target::active_task): Now method.
7959         (ravenscar_thread_target::store_registers)
7960         (ravenscar_thread_target::prepare_to_store)
7961         (ravenscar_thread_target::prepare_to_store)
7962         (ravenscar_thread_target::mourn_inferior): Update.
7963         (ravenscar_inferior_created): Use "new" to create target.
7964         (ravenscar_thread_target::get_ada_task_ptid): Update.
7965         (_initialize_ravenscar): Don't initialize base_ptid.
7966         (ravenscar_ops): Remove global.
7967
7968 2019-02-15  Tom Tromey  <tromey@adacore.com>
7969
7970         * target.h (push_target): Declare new overload.
7971         * target.c (push_target): New overload, taking an rvalue reference.
7972         * remote.c (remote_target::open_1): Use push_target overload.
7973         * corelow.c (core_target_open): Use push_target overload.
7974
7975 2019-02-15  Tom Tromey  <tromey@adacore.com>
7976
7977         * ravenscar-thread.c (is_ravenscar_task)
7978         (ravenscar_task_is_currently_active): Return bool.
7979         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7980         (_initialize_ravenscar): Remove "(void)".
7981         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7982         Return bool.
7983
7984 2019-02-15  Tom Tromey  <tromey@adacore.com>
7985
7986         * ravenscar-thread.c (ravenscar_runtime_initializer)
7987         (has_ravenscar_runtime, get_running_thread_id)
7988         (ravenscar_thread_target::resume): Fix indentation.
7989
7990 2019-02-15  Tom Tromey  <tromey@adacore.com>
7991
7992         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7993         from ravenscar_arch_ops.
7994         (sparc_ravenscar_ops::fetch_registers)
7995         (sparc_ravenscar_ops::store_registers): Now methods.
7996         (sparc_ravenscar_prepare_to_store): Remove.
7997         (sparc_ravenscar_ops): Redefine.
7998         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7999         methods and destructor.  Remove members.
8000         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8001         (ravenscar_thread_target::store_registers)
8002         (ravenscar_thread_target::prepare_to_store): Update.
8003         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8004         Remove.
8005         (struct ppc_ravenscar_powerpc_ops): Derive from
8006         ravenscar_arch_ops.
8007         (ppc_ravenscar_powerpc_ops::fetch_registers)
8008         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8009         (ppc_ravenscar_powerpc_ops): Redefine.
8010         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8011         (ppc_ravenscar_e500_ops::fetch_registers)
8012         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8013         (ppc_ravenscar_e500_ops): Redefine.
8014         * aarch64-ravenscar-thread.c
8015         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8016         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8017         (aarch64_ravenscar_fetch_registers)
8018         (aarch64_ravenscar_store_registers): Now methods.
8019         (aarch64_ravenscar_ops): Redefine.
8020
8021 2019-02-15  Tom Tromey  <tromey@adacore.com>
8022
8023         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8024         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8025         (ravenscar_thread_target::stopped_by_watchpoint)
8026         (ravenscar_thread_target::stopped_data_address)
8027         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8028
8029 2019-02-15  Tom Tromey  <tromey@adacore.com>
8030
8031         * ravenscar-thread.c: Fix some typos.
8032
8033 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8034             Tom Tromey  <tromey@adacore.com>
8035
8036         * ada-lang.c (ada_exception_sal): Change addr_string to a
8037         std::string.
8038         (create_ada_exception_catchpoint): Update.
8039
8040 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041             Tom Tromey  <tromey@adacore.com>
8042
8043         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8044         (bp_location_ops): Remove.
8045         (base_breakpoint_allocate_location): Update.
8046         (free_bp_location): Update.
8047         * ada-lang.c (class ada_catchpoint_location)
8048         <ada_catchpoint_location>: Remove ops parameter.
8049         (ada_catchpoint_location_dtor): Remove.
8050         (ada_catchpoint_location_ops): Remove.
8051         (allocate_location_exception): Update.
8052         * breakpoint.h (struct bp_location_ops): Remove.
8053         (class bp_location) <bp_location>: Remove bp_location_ops
8054         parameter.
8055         <~bp_location>: Add destructor.
8056         <ops>: Remove.
8057
8058 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8059             Pedro Alves  <palves@redhat.com>
8060
8061         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8062         'PATH_MAX'.
8063
8064 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8065             Samuel Thibault  <samuel.thibault@gnu.org>
8066             Thomas Schwinge  <thomas@codesourcery.com>
8067
8068         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8069         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8070
8071 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8072
8073         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8074         (check_empty): Use "const char *".
8075
8076         * gnu-nat.c (gnu_nat_target::detach): Instead of
8077         'detach_inferior (pid)' call
8078         'detach_inferior (find_inferior_pid (pid))'.
8079
8080         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8081         'nat/fork-inferior.o'.
8082         * gnu-nat.c: #include "nat/fork-inferior.h".
8083
8084         * gnu-nat.c (gnu_nat_target::detach): Instead of
8085         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8086         * gnu-nat.h: #include "inf-child.h".
8087         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8088         'i386_gnu_nat_target::fetch_registers'.
8089         (gnu_store_registers): Rename/move to
8090         'i386_gnu_nat_target::store_registers'.
8091
8092         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8093         * gnu-nat.h (mach_thread_info): New function.
8094         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8095
8096         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8097
8098 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8099
8100         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8101
8102 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8103
8104         * windows-nat.c (windows_add_thread): Add new parameter
8105         "main_thread_p" with default value set to false.  Update
8106         function documentation as well as all callers.
8107         (windows_delete_thread): Likewise.
8108         (fake_create_process): Update call to windows_add_thread.
8109         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8110         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8111         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8112         call to windows_delete_thread.
8113
8114 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8115
8116         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8117
8118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8119
8120         * symfile.c (find_separate_debug_file): Use canonical path of
8121         sysroot with child_path instead of gdb_sysroot if it is valid.
8122
8123 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8124
8125         * symfile.c (find_separate_debug_file): Use child_path to
8126         determine if an object file is under a sysroot.
8127
8128 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8129
8130         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8131         unittests/child-path-selftests.c.
8132         * common/pathstuff.c (child_path): New function.
8133         * common/pathstuff.h (child_path): New prototype.
8134         * unittests/child-path-selftests.c: New file.
8135
8136 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8137
8138         * symfile.c (find_separate_debug_file): Look for separate debug
8139         files in debug directories under the sysroot.
8140
8141 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8142
8143         * symtab.h (struct minimal_symbol data_p): New const method.
8144         (struct minimal_symbol text_p): Likewise.
8145         * symtab.c (output_source_filename): Use file name style
8146         to print file name.
8147         (print_symbol_info): Likewise.
8148         (print_msymbol_info): Use address style to print addresses.
8149         Use function name style to print executable text symbols.
8150         (expand_symtab_containing_pc): Use data_p.
8151         (find_pc_sect_compunit_symtab): Likewise.
8152
8153 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8154
8155         * breakpoint.c (describe_other_breakpoints): Use address style
8156         to print addresses.
8157         (say_where): Likewise.
8158
8159 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8160
8161         * ada-typeprint.c (print_func_type): Print function name
8162         style to print function name.
8163         * c-typeprint.c (c_print_type_1): Likewise.
8164
8165 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8166
8167         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8168         for execve.
8169
8170 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8171
8172         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8173         type_stack.
8174
8175 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8176
8177         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8178         TYPE_CODE_REF types.
8179
8180 2019-02-08  Jim Wilson  <jimw@sifive.com>
8181
8182         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8183         (riscv_linux_fregset): New.
8184         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8185
8186 2019-02-07  Tom Tromey  <tom@tromey.com>
8187
8188         * thread.c (thread_cancel_execution_command): Update.
8189         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8190         methods.
8191         (struct thread_fsm_ops): Remove.
8192         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8193         (thread_fsm_should_stop, thread_fsm_return_value)
8194         (thread_fsm_set_finished, thread_fsm_finished_p)
8195         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8196         Don't declare.
8197         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8198         * infrun.c (clear_proceed_status_thread)
8199         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8200         (print_stop_event): Update.
8201         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8202         Add constructor.
8203         (step_command_fsm_ops): Remove.
8204         (new_step_command_fsm): Remove.
8205         (step_1): Update.
8206         (step_command_fsm::should_stop): Rename from
8207         step_command_fsm_should_stop.
8208         (step_command_fsm::clean_up): Rename from
8209         step_command_fsm_clean_up.
8210         (step_command_fsm::do_async_reply_reason): Rename from
8211         step_command_fsm_async_reply_reason.
8212         (struct until_next_fsm): Inherit from thread_fsm.  Add
8213         constructor.
8214         (until_next_fsm_ops): Remove.
8215         (new_until_next_fsm): Remove.
8216         (until_next_fsm::should_stop): Rename from
8217         until_next_fsm_should_stop.
8218         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8219         (until_next_fsm::do_async_reply_reason): Rename from
8220         until_next_fsm_async_reply_reason.
8221         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8222         constructor.  Change type of breakpoint.
8223         (finish_command_fsm_ops): Remove.
8224         (new_finish_command_fsm): Remove.
8225         (finish_command_fsm::should_stop): Rename from
8226         finish_command_fsm_should_stop.
8227         (finish_command_fsm::clean_up): Rename from
8228         finish_command_fsm_clean_up.
8229         (finish_command_fsm::return_value): Rename from
8230         finish_command_fsm_return_value.
8231         (finish_command_fsm::do_async_reply_reason): Rename from
8232         finish_command_fsm_async_reply_reason.
8233         (finish_command): Update.
8234         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8235         Add constructor.
8236         (call_thread_fsm_ops): Remove.
8237         (call_thread_fsm::call_thread_fsm): Rename from
8238         new_call_thread_fsm.
8239         (call_thread_fsm::should_stop): Rename from
8240         call_thread_fsm_should_stop.
8241         (call_thread_fsm::should_notify_stop): Rename from
8242         call_thread_fsm_should_notify_stop.
8243         (run_inferior_call, call_function_by_hand_dummy): Update.
8244         * cli/cli-interp.c (should_print_stop_to_console): Update.
8245         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8246         Add constructor.  Change type of location_breakpoint,
8247         caller_breakpoint.
8248         (until_break_fsm_ops): Remove.
8249         (new_until_break_fsm): Remove.
8250         (until_break_fsm::should_stop): Rename from
8251         until_break_fsm_should_stop.
8252         (until_break_fsm::clean_up): Rename from
8253         until_break_fsm_clean_up.
8254         (until_break_fsm::do_async_reply_reason): Rename from
8255         until_break_fsm_async_reply_reason.
8256         (until_break_command): Update.
8257         * thread-fsm.c: Remove.
8258         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8259
8260 2019-02-07  Tom Tromey  <tom@tromey.com>
8261
8262         * yy-remap.h: Add include guard.
8263         * xtensa-tdep.h: Add include guard.
8264         * xcoffread.h: Rename include guard.
8265         * varobj-iter.h: Add include guard.
8266         * tui/tui.h: Rename include guard.
8267         * tui/tui-winsource.h: Rename include guard.
8268         * tui/tui-wingeneral.h: Rename include guard.
8269         * tui/tui-windata.h: Rename include guard.
8270         * tui/tui-win.h: Rename include guard.
8271         * tui/tui-stack.h: Rename include guard.
8272         * tui/tui-source.h: Rename include guard.
8273         * tui/tui-regs.h: Rename include guard.
8274         * tui/tui-out.h: Rename include guard.
8275         * tui/tui-layout.h: Rename include guard.
8276         * tui/tui-io.h: Rename include guard.
8277         * tui/tui-hooks.h: Rename include guard.
8278         * tui/tui-file.h: Rename include guard.
8279         * tui/tui-disasm.h: Rename include guard.
8280         * tui/tui-data.h: Rename include guard.
8281         * tui/tui-command.h: Rename include guard.
8282         * tic6x-tdep.h: Add include guard.
8283         * target/waitstatus.h: Rename include guard.
8284         * target/wait.h: Rename include guard.
8285         * target/target.h: Rename include guard.
8286         * target/resume.h: Rename include guard.
8287         * target-float.h: Rename include guard.
8288         * stabsread.h: Add include guard.
8289         * rs6000-tdep.h: Add include guard.
8290         * riscv-fbsd-tdep.h: Add include guard.
8291         * regformats/regdef.h: Rename include guard.
8292         * record.h: Rename include guard.
8293         * python/python.h: Rename include guard.
8294         * python/python-internal.h: Rename include guard.
8295         * python/py-stopevent.h: Rename include guard.
8296         * python/py-ref.h: Rename include guard.
8297         * python/py-record.h: Rename include guard.
8298         * python/py-record-full.h: Rename include guard.
8299         * python/py-record-btrace.h: Rename include guard.
8300         * python/py-instruction.h: Rename include guard.
8301         * python/py-events.h: Rename include guard.
8302         * python/py-event.h: Rename include guard.
8303         * procfs.h: Add include guard.
8304         * proc-utils.h: Add include guard.
8305         * p-lang.h: Add include guard.
8306         * or1k-tdep.h: Rename include guard.
8307         * observable.h: Rename include guard.
8308         * nto-tdep.h: Rename include guard.
8309         * nat/x86-linux.h: Rename include guard.
8310         * nat/x86-linux-dregs.h: Rename include guard.
8311         * nat/x86-gcc-cpuid.h: Add include guard.
8312         * nat/x86-dregs.h: Rename include guard.
8313         * nat/x86-cpuid.h: Rename include guard.
8314         * nat/ppc-linux.h: Rename include guard.
8315         * nat/mips-linux-watch.h: Rename include guard.
8316         * nat/linux-waitpid.h: Rename include guard.
8317         * nat/linux-ptrace.h: Rename include guard.
8318         * nat/linux-procfs.h: Rename include guard.
8319         * nat/linux-osdata.h: Rename include guard.
8320         * nat/linux-nat.h: Rename include guard.
8321         * nat/linux-namespaces.h: Rename include guard.
8322         * nat/linux-btrace.h: Rename include guard.
8323         * nat/glibc_thread_db.h: Rename include guard.
8324         * nat/gdb_thread_db.h: Rename include guard.
8325         * nat/gdb_ptrace.h: Rename include guard.
8326         * nat/fork-inferior.h: Rename include guard.
8327         * nat/amd64-linux-siginfo.h: Rename include guard.
8328         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8329         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8330         * nat/aarch64-linux.h: Rename include guard.
8331         * nat/aarch64-linux-hw-point.h: Rename include guard.
8332         * mn10300-tdep.h: Add include guard.
8333         * mips-linux-tdep.h: Add include guard.
8334         * mi/mi-parse.h: Rename include guard.
8335         * mi/mi-out.h: Rename include guard.
8336         * mi/mi-main.h: Rename include guard.
8337         * mi/mi-interp.h: Rename include guard.
8338         * mi/mi-getopt.h: Rename include guard.
8339         * mi/mi-console.h: Rename include guard.
8340         * mi/mi-common.h: Rename include guard.
8341         * mi/mi-cmds.h: Rename include guard.
8342         * mi/mi-cmd-break.h: Rename include guard.
8343         * m2-lang.h: Add include guard.
8344         * location.h: Rename include guard.
8345         * linux-record.h: Rename include guard.
8346         * linux-nat.h: Add include guard.
8347         * linux-fork.h: Add include guard.
8348         * i386-darwin-tdep.h: Rename include guard.
8349         * hppa-linux-offsets.h: Add include guard.
8350         * guile/guile.h: Rename include guard.
8351         * guile/guile-internal.h: Rename include guard.
8352         * gnu-nat.h: Rename include guard.
8353         * gdb-stabs.h: Rename include guard.
8354         * frv-tdep.h: Add include guard.
8355         * f-lang.h: Add include guard.
8356         * event-loop.h: Add include guard.
8357         * darwin-nat.h: Rename include guard.
8358         * cp-abi.h: Rename include guard.
8359         * config/sparc/nm-sol2.h: Rename include guard.
8360         * config/nm-nto.h: Rename include guard.
8361         * config/nm-linux.h: Add include guard.
8362         * config/i386/nm-i386gnu.h: Rename include guard.
8363         * config/djgpp/nl_types.h: Rename include guard.
8364         * config/djgpp/langinfo.h: Rename include guard.
8365         * compile/gcc-cp-plugin.h: Add include guard.
8366         * compile/gcc-c-plugin.h: Add include guard.
8367         * compile/compile.h: Rename include guard.
8368         * compile/compile-object-run.h: Rename include guard.
8369         * compile/compile-object-load.h: Rename include guard.
8370         * compile/compile-internal.h: Rename include guard.
8371         * compile/compile-cplus.h: Rename include guard.
8372         * compile/compile-c.h: Rename include guard.
8373         * common/xml-utils.h: Rename include guard.
8374         * common/x86-xstate.h: Rename include guard.
8375         * common/version.h: Rename include guard.
8376         * common/vec.h: Rename include guard.
8377         * common/tdesc.h: Rename include guard.
8378         * common/selftest.h: Rename include guard.
8379         * common/scoped_restore.h: Rename include guard.
8380         * common/scoped_mmap.h: Rename include guard.
8381         * common/scoped_fd.h: Rename include guard.
8382         * common/safe-iterator.h: Rename include guard.
8383         * common/run-time-clock.h: Rename include guard.
8384         * common/refcounted-object.h: Rename include guard.
8385         * common/queue.h: Rename include guard.
8386         * common/ptid.h: Rename include guard.
8387         * common/print-utils.h: Rename include guard.
8388         * common/preprocessor.h: Rename include guard.
8389         * common/pathstuff.h: Rename include guard.
8390         * common/observable.h: Rename include guard.
8391         * common/netstuff.h: Rename include guard.
8392         * common/job-control.h: Rename include guard.
8393         * common/host-defs.h: Rename include guard.
8394         * common/gdb_wait.h: Rename include guard.
8395         * common/gdb_vecs.h: Rename include guard.
8396         * common/gdb_unlinker.h: Rename include guard.
8397         * common/gdb_unique_ptr.h: Rename include guard.
8398         * common/gdb_tilde_expand.h: Rename include guard.
8399         * common/gdb_sys_time.h: Rename include guard.
8400         * common/gdb_string_view.h: Rename include guard.
8401         * common/gdb_splay_tree.h: Rename include guard.
8402         * common/gdb_setjmp.h: Rename include guard.
8403         * common/gdb_ref_ptr.h: Rename include guard.
8404         * common/gdb_optional.h: Rename include guard.
8405         * common/gdb_locale.h: Rename include guard.
8406         * common/gdb_assert.h: Rename include guard.
8407         * common/filtered-iterator.h: Rename include guard.
8408         * common/filestuff.h: Rename include guard.
8409         * common/fileio.h: Rename include guard.
8410         * common/environ.h: Rename include guard.
8411         * common/common-utils.h: Rename include guard.
8412         * common/common-types.h: Rename include guard.
8413         * common/common-regcache.h: Rename include guard.
8414         * common/common-inferior.h: Rename include guard.
8415         * common/common-gdbthread.h: Rename include guard.
8416         * common/common-exceptions.h: Rename include guard.
8417         * common/common-defs.h: Rename include guard.
8418         * common/common-debug.h: Rename include guard.
8419         * common/cleanups.h: Rename include guard.
8420         * common/buffer.h: Rename include guard.
8421         * common/btrace-common.h: Rename include guard.
8422         * common/break-common.h: Rename include guard.
8423         * cli/cli-utils.h: Rename include guard.
8424         * cli/cli-style.h: Rename include guard.
8425         * cli/cli-setshow.h: Rename include guard.
8426         * cli/cli-script.h: Rename include guard.
8427         * cli/cli-interp.h: Rename include guard.
8428         * cli/cli-decode.h: Rename include guard.
8429         * cli/cli-cmds.h: Rename include guard.
8430         * charset-list.h: Add include guard.
8431         * buildsym-legacy.h: Rename include guard.
8432         * bfin-tdep.h: Add include guard.
8433         * ax.h: Rename include guard.
8434         * arm-linux-tdep.h: Add include guard.
8435         * arm-fbsd-tdep.h: Add include guard.
8436         * arch/xtensa.h: Rename include guard.
8437         * arch/tic6x.h: Add include guard.
8438         * arch/i386.h: Add include guard.
8439         * arch/arm.h: Rename include guard.
8440         * arch/arm-linux.h: Rename include guard.
8441         * arch/arm-get-next-pcs.h: Rename include guard.
8442         * arch/amd64.h: Add include guard.
8443         * arch/aarch64-insn.h: Rename include guard.
8444         * arch-utils.h: Rename include guard.
8445         * annotate.h: Add include guard.
8446         * amd64-darwin-tdep.h: Rename include guard.
8447         * aarch64-linux-tdep.h: Add include guard.
8448         * aarch64-fbsd-tdep.h: Add include guard.
8449         * aarch32-linux-nat.h: Add include guard.
8450
8451 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8452
8453         * macrotab.c (macro_define_internal): New function that
8454         factorizes macro_define_object_internal and macro_define_function
8455         code.
8456         (macro_define_object_internal): Use macro_define_internal.
8457         (macro_define_function): Likewise.
8458
8459 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8460
8461         * macrocmd.c (extract_identifier): Return
8462         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8463         callers.
8464
8465 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8466
8467         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8468
8469 2019-02-05  Tom Tromey  <tom@tromey.com>
8470
8471         * target.c (target_stack::unpush): Move assertion earlier.
8472
8473 2019-01-30  Tom Tromey  <tom@tromey.com>
8474
8475         PR python/23615:
8476         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8477         (gdbpy_parse_and_eval): Likewise.
8478         * python/python-internal.h (gdbpy_allow_threads): New class.
8479
8480 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8481
8482         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8483         (aarch64_fbsd_fpregmap): Move earlier.
8484         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8485         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8486         instead of individual calls to trad_frame_set_reg_addr.
8487         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8488         earlier.
8489         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8490         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8491         instead of individual calls to trad_frame_set_reg_addr.
8492
8493 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8494
8495         * CONTRIBUTE: Replace contribution list with wiki link.
8496
8497 2019-01-25  Tom Tromey  <tom@tromey.com>
8498
8499         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8500
8501 2019-01-25  Tom Tromey  <tom@tromey.com>
8502
8503         * xtensa-linux-nat.c: Fix common/ includes.
8504         * xml-support.h: Fix common/ includes.
8505         * xml-support.c: Fix common/ includes.
8506         * x86-linux-nat.c: Fix common/ includes.
8507         * windows-nat.c: Fix common/ includes.
8508         * varobj.h: Fix common/ includes.
8509         * varobj.c: Fix common/ includes.
8510         * value.c: Fix common/ includes.
8511         * valops.c: Fix common/ includes.
8512         * utils.c: Fix common/ includes.
8513         * unittests/xml-utils-selftests.c: Fix common/ includes.
8514         * unittests/utils-selftests.c: Fix common/ includes.
8515         * unittests/unpack-selftests.c: Fix common/ includes.
8516         * unittests/tracepoint-selftests.c: Fix common/ includes.
8517         * unittests/style-selftests.c: Fix common/ includes.
8518         * unittests/string_view-selftests.c: Fix common/ includes.
8519         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8520         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8521         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8522         * unittests/rsp-low-selftests.c: Fix common/ includes.
8523         * unittests/parse-connection-spec-selftests.c: Fix common/
8524         includes.
8525         * unittests/optional-selftests.c: Fix common/ includes.
8526         * unittests/offset-type-selftests.c: Fix common/ includes.
8527         * unittests/observable-selftests.c: Fix common/ includes.
8528         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8529         * unittests/memrange-selftests.c: Fix common/ includes.
8530         * unittests/memory-map-selftests.c: Fix common/ includes.
8531         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8532         * unittests/function-view-selftests.c: Fix common/ includes.
8533         * unittests/environ-selftests.c: Fix common/ includes.
8534         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8535         * unittests/common-utils-selftests.c: Fix common/ includes.
8536         * unittests/cli-utils-selftests.c: Fix common/ includes.
8537         * unittests/array-view-selftests.c: Fix common/ includes.
8538         * ui-file.c: Fix common/ includes.
8539         * tui/tui-io.c: Fix common/ includes.
8540         * tracepoint.h: Fix common/ includes.
8541         * tracepoint.c: Fix common/ includes.
8542         * tracefile-tfile.c: Fix common/ includes.
8543         * top.h: Fix common/ includes.
8544         * top.c: Fix common/ includes.
8545         * thread.c: Fix common/ includes.
8546         * target/waitstatus.h: Fix common/ includes.
8547         * target/waitstatus.c: Fix common/ includes.
8548         * target.h: Fix common/ includes.
8549         * target.c: Fix common/ includes.
8550         * target-memory.c: Fix common/ includes.
8551         * target-descriptions.c: Fix common/ includes.
8552         * symtab.h: Fix common/ includes.
8553         * symfile.c: Fix common/ includes.
8554         * stap-probe.c: Fix common/ includes.
8555         * spu-linux-nat.c: Fix common/ includes.
8556         * sparc-nat.c: Fix common/ includes.
8557         * source.c: Fix common/ includes.
8558         * solib.c: Fix common/ includes.
8559         * solib-target.c: Fix common/ includes.
8560         * ser-unix.c: Fix common/ includes.
8561         * ser-tcp.c: Fix common/ includes.
8562         * ser-pipe.c: Fix common/ includes.
8563         * ser-base.c: Fix common/ includes.
8564         * selftest-arch.c: Fix common/ includes.
8565         * s12z-tdep.c: Fix common/ includes.
8566         * rust-exp.y: Fix common/ includes.
8567         * rs6000-aix-tdep.c: Fix common/ includes.
8568         * riscv-tdep.c: Fix common/ includes.
8569         * remote.c: Fix common/ includes.
8570         * remote-notif.h: Fix common/ includes.
8571         * remote-fileio.h: Fix common/ includes.
8572         * remote-fileio.c: Fix common/ includes.
8573         * regcache.h: Fix common/ includes.
8574         * regcache.c: Fix common/ includes.
8575         * record-btrace.c: Fix common/ includes.
8576         * python/python.c: Fix common/ includes.
8577         * python/py-type.c: Fix common/ includes.
8578         * python/py-inferior.c: Fix common/ includes.
8579         * progspace.h: Fix common/ includes.
8580         * producer.c: Fix common/ includes.
8581         * procfs.c: Fix common/ includes.
8582         * proc-api.c: Fix common/ includes.
8583         * printcmd.c: Fix common/ includes.
8584         * ppc-linux-nat.c: Fix common/ includes.
8585         * parser-defs.h: Fix common/ includes.
8586         * osdata.c: Fix common/ includes.
8587         * obsd-nat.c: Fix common/ includes.
8588         * nat/x86-linux.c: Fix common/ includes.
8589         * nat/x86-linux-dregs.c: Fix common/ includes.
8590         * nat/x86-dregs.h: Fix common/ includes.
8591         * nat/x86-dregs.c: Fix common/ includes.
8592         * nat/ppc-linux.c: Fix common/ includes.
8593         * nat/mips-linux-watch.h: Fix common/ includes.
8594         * nat/mips-linux-watch.c: Fix common/ includes.
8595         * nat/linux-waitpid.c: Fix common/ includes.
8596         * nat/linux-ptrace.h: Fix common/ includes.
8597         * nat/linux-ptrace.c: Fix common/ includes.
8598         * nat/linux-procfs.c: Fix common/ includes.
8599         * nat/linux-personality.c: Fix common/ includes.
8600         * nat/linux-osdata.c: Fix common/ includes.
8601         * nat/linux-namespaces.c: Fix common/ includes.
8602         * nat/linux-btrace.h: Fix common/ includes.
8603         * nat/linux-btrace.c: Fix common/ includes.
8604         * nat/fork-inferior.c: Fix common/ includes.
8605         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8606         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8607         * nat/aarch64-linux.c: Fix common/ includes.
8608         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8609         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8610         * namespace.h: Fix common/ includes.
8611         * mips-linux-tdep.c: Fix common/ includes.
8612         * minsyms.c: Fix common/ includes.
8613         * mi/mi-parse.h: Fix common/ includes.
8614         * mi/mi-main.c: Fix common/ includes.
8615         * mi/mi-cmd-env.c: Fix common/ includes.
8616         * memrange.h: Fix common/ includes.
8617         * memattr.c: Fix common/ includes.
8618         * maint.h: Fix common/ includes.
8619         * maint.c: Fix common/ includes.
8620         * main.c: Fix common/ includes.
8621         * machoread.c: Fix common/ includes.
8622         * location.c: Fix common/ includes.
8623         * linux-thread-db.c: Fix common/ includes.
8624         * linux-nat.c: Fix common/ includes.
8625         * linux-fork.c: Fix common/ includes.
8626         * inline-frame.c: Fix common/ includes.
8627         * infrun.c: Fix common/ includes.
8628         * inflow.c: Fix common/ includes.
8629         * inferior.h: Fix common/ includes.
8630         * inferior.c: Fix common/ includes.
8631         * infcmd.c: Fix common/ includes.
8632         * inf-ptrace.c: Fix common/ includes.
8633         * inf-child.c: Fix common/ includes.
8634         * ia64-linux-nat.c: Fix common/ includes.
8635         * i387-tdep.c: Fix common/ includes.
8636         * i386-tdep.c: Fix common/ includes.
8637         * i386-linux-tdep.c: Fix common/ includes.
8638         * i386-linux-nat.c: Fix common/ includes.
8639         * i386-go32-tdep.c: Fix common/ includes.
8640         * i386-fbsd-tdep.c: Fix common/ includes.
8641         * i386-fbsd-nat.c: Fix common/ includes.
8642         * guile/scm-type.c: Fix common/ includes.
8643         * guile/guile.c: Fix common/ includes.
8644         * go32-nat.c: Fix common/ includes.
8645         * gnu-nat.c: Fix common/ includes.
8646         * gdbthread.h: Fix common/ includes.
8647         * gdbarch-selftests.c: Fix common/ includes.
8648         * gdb_usleep.c: Fix common/ includes.
8649         * gdb_select.h: Fix common/ includes.
8650         * gdb_bfd.c: Fix common/ includes.
8651         * gcore.c: Fix common/ includes.
8652         * fork-child.c: Fix common/ includes.
8653         * findvar.c: Fix common/ includes.
8654         * fbsd-nat.c: Fix common/ includes.
8655         * event-top.c: Fix common/ includes.
8656         * event-loop.c: Fix common/ includes.
8657         * dwarf2read.c: Fix common/ includes.
8658         * dwarf2loc.c: Fix common/ includes.
8659         * dwarf2-frame.c: Fix common/ includes.
8660         * dwarf-index-cache.c: Fix common/ includes.
8661         * dtrace-probe.c: Fix common/ includes.
8662         * disasm-selftests.c: Fix common/ includes.
8663         * defs.h: Fix common/ includes.
8664         * csky-tdep.c: Fix common/ includes.
8665         * cp-valprint.c: Fix common/ includes.
8666         * cp-support.h: Fix common/ includes.
8667         * cp-support.c: Fix common/ includes.
8668         * corelow.c: Fix common/ includes.
8669         * completer.h: Fix common/ includes.
8670         * completer.c: Fix common/ includes.
8671         * compile/compile.c: Fix common/ includes.
8672         * compile/compile-loc2c.c: Fix common/ includes.
8673         * compile/compile-cplus-types.c: Fix common/ includes.
8674         * compile/compile-cplus-symbols.c: Fix common/ includes.
8675         * command.h: Fix common/ includes.
8676         * cli/cli-dump.c: Fix common/ includes.
8677         * cli/cli-cmds.c: Fix common/ includes.
8678         * charset.c: Fix common/ includes.
8679         * build-id.c: Fix common/ includes.
8680         * btrace.h: Fix common/ includes.
8681         * btrace.c: Fix common/ includes.
8682         * breakpoint.h: Fix common/ includes.
8683         * breakpoint.c: Fix common/ includes.
8684         * ax.h:
8685         (enum agent_op): Fix common/ includes.
8686         * ax-general.c (struct aop_map): Fix common/ includes.
8687         * ax-gdb.c: Fix common/ includes.
8688         * auxv.c: Fix common/ includes.
8689         * auto-load.c: Fix common/ includes.
8690         * arm-tdep.c: Fix common/ includes.
8691         * arch/riscv.c: Fix common/ includes.
8692         * arch/ppc-linux-common.c: Fix common/ includes.
8693         * arch/i386.c: Fix common/ includes.
8694         * arch/arm.c: Fix common/ includes.
8695         * arch/arm-linux.c: Fix common/ includes.
8696         * arch/arm-get-next-pcs.c: Fix common/ includes.
8697         * arch/amd64.c: Fix common/ includes.
8698         * arch/aarch64.c: Fix common/ includes.
8699         * arch/aarch64-insn.c: Fix common/ includes.
8700         * arch-utils.c: Fix common/ includes.
8701         * amd64-windows-tdep.c: Fix common/ includes.
8702         * amd64-tdep.c: Fix common/ includes.
8703         * amd64-sol2-tdep.c: Fix common/ includes.
8704         * amd64-obsd-tdep.c: Fix common/ includes.
8705         * amd64-nbsd-tdep.c: Fix common/ includes.
8706         * amd64-linux-tdep.c: Fix common/ includes.
8707         * amd64-linux-nat.c: Fix common/ includes.
8708         * amd64-fbsd-tdep.c: Fix common/ includes.
8709         * amd64-fbsd-nat.c: Fix common/ includes.
8710         * amd64-dicos-tdep.c: Fix common/ includes.
8711         * amd64-darwin-tdep.c: Fix common/ includes.
8712         * agent.c: Fix common/ includes.
8713         * ada-lang.h: Fix common/ includes.
8714         * ada-lang.c: Fix common/ includes.
8715         * aarch64-tdep.c: Fix common/ includes.
8716
8717 2019-01-25  Tom Tromey  <tom@tromey.com>
8718
8719         * common/create-version.sh: Use common/version.h.
8720
8721 2019-01-24  Pedro Alves  <palves@redhat.com>
8722
8723         * infrun.c (signal_stop, signal_print, signal_program)
8724         (signal_catch, signal_pass): Now arrays instead of pointers.
8725         (update_signals_program_target, do_target_resume)
8726         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8727         * linux-nat.c (linux_nat_target::pass_signals)
8728         (linux_nat_target::create_inferior, linux_nat_target::attach):
8729         Adjust.
8730         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8731         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8732         * procfs.c (procfs_target::pass_signals): Adjust.
8733         * record-full.c (record_full_target::resume): Adjust.
8734         * remote.c (remote_target::pass_signals)
8735         (remote_target::program_signals): Adjust.
8736         * target-debug.h (target_debug_print_signals): Now takes a
8737         gdb::array_view as parameter.  Adjust.
8738         * target.h (target_ops) <pass_signals, program_signals>: Replace
8739         pointer and length parameters with gdb::array_view.
8740         (target_pass_signals, target_program_signals): Likewise.
8741         * target-delegates.c: Regenerate.
8742
8743 2019-01-24  Pedro Alves  <palves@redhat.com>
8744
8745         * common/forward-scope-exit.h
8746         (forward_scope_exit::forward_scope_exit): Pass arguments to
8747         m_bind_function directly, instead of creating a std::bind and
8748         copying that.
8749
8750 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8751
8752         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8753         for static members.
8754         (pass_in_v_vfp_candidate): Likewise.
8755
8756 2019-01-23  Tom Tromey  <tom@tromey.com>
8757             Pedro Alves  <palves@redhat.com>
8758
8759         * regcache.c (class regcache_invalidator): Remove.
8760         (regcache::raw_write): Use make_scope_exit.
8761
8762 2019-01-23  Tom Tromey  <tom@tromey.com>
8763
8764         * ui-out.h (class ui_out_emit_type): Update comment.
8765
8766 2019-01-23  Tom Tromey  <tom@tromey.com>
8767
8768         * infrun.c (fetch_inferior_event): Update comment.
8769
8770 2019-01-23  Tom Tromey  <tom@tromey.com>
8771             Pedro Alves  <palves@redhat.com>
8772
8773         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8774         parameter.
8775         (fetch_inferior_event): Use SCOPE_EXIT.
8776
8777
8778 2019-01-23  Tom Tromey  <tom@tromey.com>
8779             Pedro Alves  <palves@redhat.com>
8780
8781         * infrun.c (disable_thread_events): Delete.
8782         (stop_all_threads): Use SCOPE_EXIT.
8783
8784 2019-01-23  Tom Tromey  <tom@tromey.com>
8785             Pedro Alves  <palves@redhat.com>
8786
8787         * symfile.c: Include forward-scope-exit.h.
8788         (clear_symtab_users_cleanup): Replace forward declaration with
8789         a FORWARD_SCOPE_EXIT.
8790         (syms_from_objfile_1): Use the forward_scope_exit and
8791         gdb::optional instead of cleanup_function.
8792         (reread_symbols): Use the forward_scope_exit instead of
8793         cleanup_function.
8794         (clear_symtab_users_cleanup): Remove function.
8795
8796 2019-01-23  Tom Tromey  <tom@tromey.com>
8797             Pedro Alves  <palves@redhat.com>
8798
8799         * linux-nat.c: Include scope-exit.h.
8800         (cleanup_target_stop): Remove.
8801         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8802         SCOPE_EXIT.
8803
8804 2019-01-23  Tom Tromey  <tom@tromey.com>
8805             Pedro Alves  <palves@redhat.com>
8806
8807         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8808         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8809
8810 2019-01-23  Tom Tromey  <tom@tromey.com>
8811             Andrew Burgess  <andrew.burgess@embecosm.com>
8812             Pedro Alves  <palves@redhat.com>
8813
8814         * infrun.c (fetch_inferior_event): Use scope_exit.
8815         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8816         * top.c (execute_command): Use scope_exit.
8817         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8818         * utils.c (do_bpstat_clear_actions_cleanup)
8819         (make_bpstat_clear_actions_cleanup): Remove.
8820
8821 2019-01-23  Tom Tromey  <tom@tromey.com>
8822             Pedro Alves  <palves@redhat.com>
8823
8824         * infrun.c: Include "common/scope-exit.h"
8825         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8826         (wait_for_inferior): Use SCOPE_EXIT.
8827         (fetch_inferior_event): Use scope_exit.
8828
8829 2019-01-23  Tom Tromey  <tom@tromey.com>
8830             Pedro Alves  <palves@redhat.com>
8831
8832         * breakpoint.c (create_breakpoint): Remove cleanup.
8833
8834 2019-01-23  Tom Tromey  <tom@tromey.com>
8835             Andrew Burgess  <andrew.burgess@embecosm.com>
8836             Pedro Alves  <palves@redhat.com>
8837
8838 2019-01-23  Pedro Alves  <palves@redhat.com>
8839
8840         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8841
8842 2019-01-23  Pedro Alves  <palves@redhat.com>
8843             Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * gdbthread.h: Include "common/forward-scope-exit.h".
8846         (scoped_finish_thread_state): Redefine custom class in terms of
8847         forward_scope_exit.
8848
8849 2019-01-23  Pedro Alves  <palves@redhat.com>
8850             Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * common/forward-scope-exit.h: New file.
8853
8854 2019-01-23  Pedro Alves  <palves@redhat.com>
8855             Andrew Burgess  <andrew.burgess@embecosm.com>
8856             Tom Tromey  <tom@tromey.com>
8857
8858         * common/scope-exit.h: New file.
8859
8860 2019-01-23  Pedro Alves  <palves@redhat.com>
8861
8862         * common/preprocessor.h (ESC): Rename to ...
8863         (ESC_PARENS): ... this.
8864         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8865         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8866
8867 2019-01-23  Tom Tromey  <tom@tromey.com>
8868
8869         * language.h (class scoped_switch_to_sym_language_if_auto):
8870         Initialize m_lang in both cases.
8871
8872 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8873
8874         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8875         with XCNEW.
8876
8877 2019-01-22  Tom Tromey  <tom@tromey.com>
8878
8879         * corelow.c: Do not include sys/file.h.
8880
8881 2019-01-22  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-wingeneral.h: Include gdb_curses.h.
8884
8885 2019-01-22  Tom Tromey  <tom@tromey.com>
8886
8887         * source-cache.h (class source_cache) <get_source_lines,
8888         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8889
8890 2019-01-22  Tom Tromey  <tom@tromey.com>
8891
8892         * remote-fileio.h (struct remote_target): Declare.
8893
8894 2019-01-22  Tom Tromey  <tom@tromey.com>
8895
8896         * python/py-arch.c: Do not include py-ref.h.
8897         * python/py-bpevent.c: Do not include py-ref.h.
8898         * python/py-cmd.c: Do not include py-ref.h.
8899         * python/py-continueevent.c: Do not include py-ref.h.
8900         * python/py-event.h: Do not include py-ref.h.
8901         * python/py-evtregistry.c: Do not include py-ref.h.
8902         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8903         * python/py-frame.c: Do not include py-ref.h.
8904         * python/py-framefilter.c: Do not include py-ref.h.
8905         * python/py-function.c: Do not include py-ref.h.
8906         * python/py-infevents.c: Do not include py-ref.h.
8907         * python/py-linetable.c: Do not include py-ref.h.
8908         * python/py-objfile.c: Do not include py-ref.h.
8909         * python/py-param.c: Do not include py-ref.h.
8910         * python/py-prettyprint.c: Do not include py-ref.h.
8911         * python/py-progspace.c: Do not include py-ref.h.
8912         * python/py-symbol.c: Do not include py-ref.h.
8913         * python/py-symtab.c: Do not include py-ref.h.
8914         * python/py-type.c: Do not include py-ref.h.
8915         * python/py-unwind.c: Do not include py-ref.h.
8916         * python/py-utils.c: Do not include py-ref.h.
8917         * python/py-value.c: Do not include py-ref.h.
8918         * python/py-varobj.c: Do not include py-ref.h.
8919         * python/py-xmethods.c: Do not include py-ref.h.
8920         * python/python.c: Do not include py-ref.h.
8921         * varobj.c: Do not include py-ref.h.
8922
8923 2019-01-22  Tom Tromey  <tom@tromey.com>
8924
8925         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8926         keyword for bcache.
8927
8928 2019-01-22  Tom Tromey  <tom@tromey.com>
8929
8930         * compile/compile-cplus-types.c: Remove a comment by #include.
8931
8932 2019-01-22  Tom Tromey  <tom@tromey.com>
8933
8934         * compile/gcc-c-plugin.h: Include compile-internal.h.
8935
8936 2019-01-22  Tom Tromey  <tom@tromey.com>
8937
8938         * stabsread.c (EXTERN): Do not define.
8939         (symnum, next_symbol_text_func, processing_gcc_compilation)
8940         (within_function, global_sym_chain, global_stabs)
8941         (previous_stab_code, this_object_header_files)
8942         (n_this_object_header_files)
8943         (n_allocated_this_object_header_files): Define.
8944         * stabsread.h (EXTERN): Never define.  Use "extern".
8945
8946 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8947
8948         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8949         history_value.
8950
8951 2019-01-21  Tom Tromey  <tom@tromey.com>
8952
8953         * ui-out.c: Fix includes.
8954         * tui/tui-source.c: Fix includes.
8955         * target.c: Fix includes.
8956         * remote.c: Fix includes.
8957         * regcache.c: Fix includes.
8958         * python/py-block.c: Fix includes.
8959         * printcmd.c: Fix includes.
8960         * or1k-tdep.c: Fix includes.
8961         * mi/mi-main.c: Fix includes.
8962         * m32r-tdep.c: Fix includes.
8963         * csky-tdep.c: Fix includes.
8964         * compile/compile-cplus-types.c: Fix includes.
8965         * cli/cli-interp.c: Fix includes.
8966
8967 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8968
8969         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8970         for padding.
8971
8972 2019-01-16  Tom Tromey  <tom@tromey.com>
8973
8974         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8975         earlier.
8976         (struct objfile) <msymbols_range>: Move from top level.
8977         <msymbols>: New method.
8978         (class objfile_msymbols): Remove.
8979         * symtab.c (default_collect_symbol_completion_matches_break_on):
8980         Update.
8981         * symmisc.c (dump_msymbols): Update.
8982         * stabsread.c (scan_file_globals): Update.
8983         * objc-lang.c (info_selectors_command, info_classes_command)
8984         (find_methods): Update.
8985         * minsyms.c (find_solib_trampoline_target): Update.
8986         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8987         * coffread.c (coff_symfile_read): Update.
8988         * ada-lang.c (ada_lookup_simple_minsym)
8989         (ada_collect_symbol_completion_matches): Update.
8990
8991 2019-01-16  Tom Tromey  <tom@tromey.com>
8992
8993         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8994         type.  Remove no-argument constructor.
8995         <iterator::operator++>: Simplify.
8996         <begin>: Update.
8997         <end>: Use minimal_symbol_count.
8998
8999 2019-01-16  Tom Tromey  <tom@tromey.com>
9000
9001         * objfiles.h (struct objfile) <psymtabs>: New method.
9002         (class objfile_psymtabs): Remove.
9003         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9004         typedef.
9005         <range>: New method.
9006         (require_partial_symbols): Change return type.
9007         * psymtab.c (require_partial_symbols)
9008         (psym_expand_symtabs_matching): Update.
9009         * mdebugread.c (parse_partial_symbols): Update.
9010         * dbxread.c (dbx_end_psymtab): Update.
9011
9012 2019-01-15  Tom Tromey  <tom@tromey.com>
9013
9014         * symtab.c (lookup_objfile_from_block)
9015         (lookup_symbol_in_objfile_symtabs)
9016         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9017         (find_line_symtab, info_sources_command)
9018         (default_collect_symbol_completion_matches_break_on)
9019         (make_source_files_completion_list): Update.
9020         * symmisc.c (print_objfile_statistics, dump_objfile)
9021         (maintenance_print_symbols, maintenance_info_symtabs)
9022         (maintenance_check_symtabs, maintenance_info_line_tables):
9023         Update.
9024         * source.c (select_source_symtab)
9025         (forget_cached_source_info_for_objfile): Update.
9026         * objfiles.h (class objfile_compunits): Remove.
9027         (struct objfile) <compunits_range>: New typedef.
9028         (compunits): New method.
9029         * objfiles.c (objfile_relocate1): Update.
9030         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9031         * maint.c (count_symtabs_and_blocks): Update.
9032         * linespec.c (iterate_over_all_matching_symtabs): Update.
9033         * cp-support.c (add_symbol_overload_list_qualified): Update.
9034         * coffread.c (coff_symtab_read): Update.
9035         * ada-lang.c (add_nonlocal_symbols)
9036         (ada_collect_symbol_completion_matches)
9037         (ada_add_global_exceptions): Update.
9038
9039 2019-01-15  Tom Tromey  <tom@tromey.com>
9040
9041         * progspace.h (program_space) <objfiles_safe_range>: New
9042         typedef.
9043         <objfiles_safe>: New method.
9044         * objfiles.h (class all_objfiles_safe): Remove.
9045         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9046         * jit.c (jit_inferior_exit_hook): Update.
9047
9048 2019-01-17  Tom Tromey  <tom@tromey.com>
9049
9050         * progspace.h (program_space) <objfiles_range>: New typedef.
9051         <objfiles>: New method.
9052         <objfiles_head>: Rename from objfiles.
9053         (object_files): Update.
9054         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9055         * guile/scm-pretty-print.c
9056         (ppscm_find_pretty_printer_from_objfiles): Update.
9057         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9058         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9059         Update.
9060         * python/py-progspace.c (pspy_get_objfiles): Update.
9061         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9062         Update.
9063         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9064         (objfpy_lookup_objfile_by_build_id): Update.
9065         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9066         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9067         Update.
9068         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9069         (expand_symtab_containing_pc, lookup_objfile_from_block)
9070         (lookup_static_symbol, basic_lookup_transparent_type)
9071         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9072         (find_line_symtab, info_sources_command)
9073         (default_collect_symbol_completion_matches_break_on)
9074         (make_source_files_completion_list, find_main_name): Update.
9075         * symmisc.c (print_symbol_bcache_statistics)
9076         (print_objfile_statistics, maintenance_print_symbols)
9077         (maintenance_print_msymbols, maintenance_print_objfiles)
9078         (maintenance_info_symtabs, maintenance_check_symtabs)
9079         (maintenance_expand_symtabs, maintenance_info_line_tables):
9080         Update.
9081         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9082         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9083         (map_overlay_command, unmap_overlay_command)
9084         (simple_overlay_update, expand_symtabs_matching)
9085         (map_symbol_filenames): Update.
9086         * symfile-debug.c (set_debug_symfile): Update.
9087         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9088         Update.
9089         * source.c (select_source_symtab, forget_cached_source_info):
9090         Update.
9091         * solib.c (solib_read_symbols): Update.
9092         * solib-spu.c (append_ocl_sos): Update.
9093         * psymtab.c (maintenance_print_psymbols)
9094         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9095         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9096         * printcmd.c (info_symbol_command): Update.
9097         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9098         Update.
9099         * objfiles.h (class all_objfiles): Remove.
9100         * objfiles.c (have_partial_symbols, have_full_symbols)
9101         (have_minimal_symbols, qsort_cmp, update_section_map)
9102         (shared_objfile_contains_address_p)
9103         (default_iterate_over_objfiles_in_search_order): Update.
9104         * objc-lang.c (info_selectors_command, info_classes_command)
9105         (find_methods): Update.
9106         * minsyms.c (find_solib_trampoline_target): Update.
9107         * maint.c (maintenance_info_sections)
9108         (maintenance_translate_address, count_symtabs_and_blocks):
9109         Update.
9110         * main.c (captured_main_1): Update.
9111         * linux-thread-db.c (try_thread_db_load_from_pdir)
9112         (has_libpthread): Update.
9113         * linespec.c (iterate_over_all_matching_symtabs)
9114         (search_minsyms_for_name): Update.
9115         * jit.c (jit_find_objf_with_entry_addr): Update.
9116         * hppa-tdep.c (find_unwind_entry)
9117         (hppa_lookup_stub_minimal_symbol): Update.
9118         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9119         Update.
9120         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9121         (elf_gnu_ifunc_resolve_by_got): Update.
9122         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9123         * dwarf-index-write.c (save_gdb_index_command): Update.
9124         * cp-support.c (add_symbol_overload_list_qualified): Update.
9125         * breakpoint.c (create_overlay_event_breakpoint)
9126         (create_longjmp_master_breakpoint)
9127         (create_std_terminate_master_breakpoint)
9128         (create_exception_master_breakpoint): Update.
9129         * blockframe.c (find_pc_partial_function): Update.
9130         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9131         (ada_collect_symbol_completion_matches)
9132         (ada_add_global_exceptions): Update.
9133
9134 2019-01-17  Tom Tromey  <tom@tromey.com>
9135
9136         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9137         declare VEC.
9138         (solib_target_parse_libraries): Change return type.
9139         (library_list_start_segment, library_list_start_section)
9140         (library_list_end_library, library_list_start_library); Update.
9141         (solib_target_free_library_list): Remove.
9142         (solib_target_parse_libraries): Remove cleanup.  Change return
9143         type.
9144         (solib_target_current_sos): Update.
9145
9146 2019-01-17  Tom Tromey  <tromey@bapiya>
9147
9148         * valprint.c: Replace "the the" with "the".
9149         * symtab.c: Replace "the the" with "the".
9150         * solib.c: Replace "the the" with "the".
9151         * solib-dsbt.c: Replace "the the" with "the".
9152         * linespec.c: Replace "the the" with "the".
9153         * dwarf2loc.h: Replace "the the" with "the".
9154         * amd64-windows-tdep.c: Replace "the the" with "the".
9155         * aarch64-tdep.c: Replace "the the" with "the".
9156
9157 2019-01-16  Keith Seitz  <keiths@redhat.com>
9158
9159         PR gdb/23773
9160         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9161         <builder>: Rename to ..
9162         <m_builder>: ... this and make private.
9163         (dwarf2_cu::get_builder): New method.  Change all users of
9164         `builder' to use this method.
9165         (dwarf2_start_symtab): Move to ...
9166         (dwarf2_cu::start_symtab): ... here.  Update all callers
9167         (setup_type_unit_groups): Move to ...
9168         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9169         callers.
9170         (dwarf2_cu::reset_builder): New method.
9171         (process_full_compunit, process_full_type_unit): Use
9172         dwarf2_cu::reset_builder.
9173         (follow_die_offset): Record the ancestor CU if it is different
9174         from the followed DIE's CU.
9175         (follow_die_sig_1): Likewise.
9176
9177 2019-01-15  Tom Tromey  <tom@tromey.com>
9178
9179         * remote.c (class remote_state) <buf>: Now a char_vector.
9180         <buf_size>: Remove.
9181         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9182         parameter.
9183         (remote_target::getpkt_or_notif_sane_1)
9184         (remote_target::getpkt_sane)
9185         (remote_target::getpkt_or_notif_sane): Likewise.
9186         (class remote_target) <putpkt>: New overload.
9187         (remote_target::read_frame): Change type of "buf_p".  Remove
9188         sizeof_p parameter.
9189         (packet_ok): New overload.
9190         (packet_check_result): New overload.
9191         Update all uses.
9192
9193 2019-01-14  Tom Tromey  <tom@tromey.com>
9194
9195         * remote-notif.c (handle_notification, remote_notif_ack)
9196         (remote_notif_parse): Make "buf" const.
9197         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9198         const.
9199         (remote_notif_parse, remote_notif_ack, handle_notification):
9200         Likewise.
9201         * remote.c (remote_notif_stop_parse): Make "buf" const.
9202         (remote_target::remote_parse_stop_reply): Make "buf" const.
9203         (remote_notif_stop_ack): Make "buf" const.
9204
9205 2019-01-14  Tom Tromey  <tom@tromey.com>
9206
9207         * remote.c (remote_console_output): Make parameter const.
9208
9209 2019-01-14  Tom Tromey  <tom@tromey.com>
9210
9211         * target-debug.h (target_debug_print_signals): Constify.
9212         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9213         * procfs.c (procfs_target::pass_signals): Update.
9214         * linux-nat.c (linux_nat_target::pass_signals): Update.
9215         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9216         * target-delegates.c: Rebuild.
9217         * remote.c (remote_target::program_signals): Update.
9218         (remote_target::pass_signals): Update.
9219         * target.c (target_pass_signals): Constify argument.
9220         (target_program_signals): Likewise.
9221         * target.h (struct target_ops) <pass_signals, program_signals>:
9222         Constify argument.
9223         (target_pass_signals, target_program_signals): Constify argument.
9224
9225 2019-01-14  Tom Tromey  <tom@tromey.com>
9226
9227         PR tui/28819:
9228         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9229
9230 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9231
9232         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9233         field.
9234         * rs6000-tdep.c: Include reggroups.h.
9235         (IS_V_ALIAS_PSEUDOREG): Define.
9236         (rs6000_register_name): Return names for the "vX" aliases.
9237         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9238         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9239         aliases.  Call default_register_reggroup_p for all other
9240         pseudo-registers.
9241         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9242         New functions.
9243         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9244         Handle "vX" aliases.
9245         (v_alias_pseudo_register_collect): New function.
9246         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9247         (rs6000_gdbarch_init): Initialize "vX" aliases as
9248         pseudo-registers.  Restore registration of
9249         rs6000_pseudo_register_reggroup_p with
9250         set_tdesc_pseudo_register_reggroup_p.
9251
9252 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9253
9254         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9255         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9256         set_gdbarch_num_pseudo_regs.
9257
9258 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9259
9260         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9261         Remove arg prefixname, add do_set and do_show.
9262         Add member functions set_list and show_list.
9263         * cli/cli-style.c (class cli_style_option): Update accordingly.
9264         (style_set_list): Move to file scope.
9265         (style_show_list): Likewise.
9266         (set_style): Call help_list.
9267         (show_style): Call cmd_show_list.
9268         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9269         Update to use the new macro.
9270
9271 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9272
9273         * ada-lang.c (_initialize_ada_language): Expand the help text
9274         for the "catch exception" command.
9275
9276 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9277
9278         * symtab.c (matching_obj_sections): Initialize obj,
9279         declare it closer to its usage.
9280
9281 2019-01-10  Tom Tromey  <tom@tromey.com>
9282
9283         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9284         (basic_inf_threads_range): Remove.
9285         (inf_threads_range, inf_non_exited_threads_range)
9286         (safe_inf_threads_range): Use next_adapter.
9287
9288 2019-01-10  Keith Seitz  <keiths@redhat.com>
9289
9290         PR gdb/23712
9291         PR symtab/23010
9292         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9293         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9294
9295 2019-01-10  Keith Seitz  <keiths@redhat.com>
9296
9297         PR gdb/23712
9298         PR symtab/23010
9299         * dictionary.c (pending_to_vector): Remove.
9300         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9301         Remove _1 suffix, replacing functions of the same name.  Update
9302         all callers.
9303         (dict_create_hashed, dict_create_hashed_expandable)
9304         (dict_create_linear, dict_create_linear_expandable, dict_free)
9305         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9306         Make functions static.
9307
9308 2019-01-10  Keith Seitz  <keiths@redhat.com>
9309
9310         PR gdb/23712
9311         PR symtab/23010
9312         * dictionary.h (struct dictionary): Replace declaration with
9313         multidictionary.
9314         (dict_create_hashed, dict_create_hashed_expandable)
9315         (dict_create_linear, dict_create_linear_expandable)
9316         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9317         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9318         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9319         taking multidictionary argument.
9320         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9321         * block.h (struct block) <dict>: Change to multidictionary
9322         and rename `multidict'.
9323         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9324         symmisc.c: Update all dictionary references to multidictionary.
9325
9326 2019-01-10  Keith Seitz  <keiths@redhat.com>
9327
9328         PR gdb/23712
9329         PR symtab/23010
9330         * dictionary.c: Include unordered_map.
9331         (pending_to_vector): New function.
9332         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9333         Rewrite the non-"_1" functions to take vector instead
9334         of linked list.
9335         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9336         "new" _1 versions of the same name.
9337         (multidictionary): Define.
9338         (std::hash<enum language): New definition.
9339         (collate_pending_symbols_by_language, mdict_create_hashed)
9340         (mdict_create_hashed_expandable, mdict_create_linear)
9341         (mdict_create_linear_expandable, mdict_free)
9342         (find_language_dictionary, create_new_language_dictionary)
9343         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9344         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9345         (mdict_size, mdict_empty): New functions.
9346         * dictionary.h (mdict_iterator): Define.
9347
9348 2019-01-10  Pedro Alves  <palves@redhat.com>
9349
9350         * breakpoint.c (read_uploaded_action)
9351         (create_tracepoint_from_upload): Adjust to use
9352         gdb::unique_xmalloc_ptr.
9353         * ctf.c (ctf_write_uploaded_tp):
9354         (SET_ARRAY_FIELD): Use emplace_back.
9355         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9356         * tracefile-tfile.c (tfile_write_uploaded_tp):
9357         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9358         gdb::unique_xmalloc_ptr.
9359         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9360         at_string, cond_string, cmd_strings>: Replace char pointers
9361         with gdb::unique_xmalloc_ptr.
9362
9363 2019-01-10  Pedro Alves  <palves@redhat.com>
9364
9365         * solib-target.c (library_list_start_library): Don't xstrdup name.
9366
9367 2019-01-10  Pedro Alves  <palves@redhat.com>
9368
9369         * mdebugread.c (parse_partial_symbols): Use
9370         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9371
9372 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * linux-fork.c (scoped_switch_fork_info)
9375         <~scoped_switch_fork_info>: Fix incorrect variable name.
9376
9377 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * linux-fork.c (scoped_switch_fork_info)
9380         <scoped_switch_fork_info>: Make explicit.
9381         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9382
9383 2019-01-10  Tom Tromey  <tom@tromey.com>
9384
9385         * objfiles.h (objfile::reset_psymtabs): Update.
9386         * objfiles.c (objfile::objfile): Update.
9387         * psymtab.h (psymtab_storage::obstack): Update.
9388         (psymtab_storage::m_obstack): Use gdb::optional.
9389         (class psymtab_storage): Update comment.  Remove objfile
9390         parameter.
9391         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9392
9393 2019-01-10  Tom Tromey  <tom@tromey.com>
9394
9395         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9396         <free_psymtabs>: Now private.
9397         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9398         (allocate_psymtab): Use new method.
9399
9400 2019-01-10  Tom Tromey  <tom@tromey.com>
9401
9402         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9403         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9404         * mdebugread.c (parse_partial_symbols): Use
9405         allocate_dependencies.
9406         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9407         allocate_dependencies.
9408         (process_psymtab_comp_unit_reader)
9409         (build_type_psymtab_dependencies): Likewise.
9410         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9411
9412 2019-01-10  Tom Tromey  <tom@tromey.com>
9413
9414         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9415         PSYMBOL_SET_LANGUAGE.
9416         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9417
9418 2019-01-10  Tom Tromey  <tom@tromey.com>
9419
9420         * psymtab.h (psymtab_storage::obstack): New method.
9421         <m_obstack>: Rename from obstack; now private.
9422         * psymtab.c (psymtab_storage): Update.
9423         * dwarf2read.c (create_addrmap_from_index)
9424         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9425         Update.
9426
9427 2019-01-10  Tom Tromey  <tom@tromey.com>
9428
9429         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9430         * objfiles.h (objfile::reset_psymtabs): New method.
9431
9432 2019-01-10  Tom Tromey  <tom@tromey.com>
9433
9434         * symmisc.c (print_symbol_bcache_statistics): Update.
9435         (print_objfile_statistics): Update.
9436         * symfile.c (reread_symbols): Update.
9437         * psymtab.h (class psymtab_storage): New.
9438         * psymtab.c (psymtab_storage): New constructor.
9439         (~psymtab_storage): New destructor.
9440         (require_partial_symbols): Update.
9441         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9442         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9443         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9444         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9445         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9446         (start_psymtab_common, end_psymtab_common)
9447         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9448         (allocate_psymtab): Update.
9449         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9450         Update.
9451         (dump_psymtab_addrmap, maintenance_print_psymbols)
9452         (maintenance_check_psymtabs): Update.
9453         (class objfile_psymtabs): Move to objfiles.h.
9454         * psympriv.h (discard_psymtab): Now inline.
9455         (psymtab_discarder::psymtab_discarder): Update.
9456         (psymtab_discarder::~psymtab_discarder): Update.
9457         (ALL_OBJFILE_PSYMTABS): Rewrite.
9458         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9459         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9460         Remove fields.
9461         <partial_symtabs>: New field.
9462         (class objfile_psymtabs): Move from psymtab.h.  Update.
9463         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9464         psymbol_cache.
9465         (objfile::~objfile): Don't destroy psymbol_cache.
9466         * mdebugread.c (parse_partial_symbols): Update.
9467         * dwarf2read.c (create_addrmap_from_index)
9468         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9469         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9470         (add_partial_subprogram, dwarf2_ranges_read): Update.
9471         * dwarf-index-write.c (write_address_map)
9472         (write_one_signatured_type, recursively_write_psymbols)
9473         (class debug_names, class debug_names, write_psymtabs_to_index):
9474         Update.
9475
9476 2019-01-10  Tom Tromey  <tom@tromey.com>
9477
9478         * symtab.h (SYMBOL_SET_NAMES): Update.
9479         (symbol_set_names): Update.
9480         (MSYMBOL_SET_NAMES): Update.
9481         * symtab.c (symbol_set_names): Change argument to be an
9482         objfile_per_bfd_storage.
9483         * psymtab.c (add_psymbol_to_bcache): Update.
9484         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9485
9486 2019-01-10  Tom Tromey  <tom@tromey.com>
9487
9488         * symtab.c (create_demangled_names_hash): Change argument to be an
9489         objfile_per_bfd_storage.
9490         (symbol_set_names): Update.
9491
9492 2019-01-10  Tom Tromey  <tom@tromey.com>
9493
9494         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9495         init_psymbol_list.
9496         * psymtab.c (init_psymbol_list): Do nothing if already called.
9497         * psympriv.h (init_psymbol_list): Add comment.
9498         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9499         init_psymbol_list.
9500         * dbxread.c (dbx_symfile_read): Unconditionally call
9501         init_psymbol_list.
9502
9503 2019-01-10  Tom Tromey  <tom@tromey.com>
9504
9505         * xcoffread.c (scan_xcoff_symtab): Update.
9506         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9507         "where".
9508         * mdebugread.c (parse_partial_symbols)
9509         (handle_psymbol_enumerators): Update.
9510         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9511         * dbxread.c (read_dbx_symtab): Update.
9512         * psympriv.h (psymbol_placement): New enum.
9513         (add_psymbol_to_list): Update.
9514
9515 2019-01-10  Tom Tromey  <tom@tromey.com>
9516
9517         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9518         static_psymbols parameters.
9519         (scan_xcoff_symtab): Update.
9520         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9521         static_psymbols parameters.
9522         * psympriv.h (start_psymtab_common): Update.
9523         * mdebugread.c (parse_partial_symbols): Update.
9524         * dwarf2read.c (create_partial_symtab): Update.
9525         * dbxread.c (read_dbx_symtab): Update.
9526         (start_psymtab): Remove global_psymbols and static_psymbols
9527         parameters.
9528
9529 2019-01-10  Tom Tromey  <tom@tromey.com>
9530
9531         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9532         * psymtab.c (allocate_psymtab): Add comment.
9533         * psympriv.h (allocate_psymtab): Add comment.
9534         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9535         initializations.
9536         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9537
9538 2019-01-10  Tom Tromey  <tom@tromey.com>
9539
9540         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9541         Don't declare.
9542         * mipsread.c: Include mdebugread.h.
9543         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9544         Declare.
9545         * elfread.c: Include mdebugread.h.
9546
9547 2019-01-09  Tom Tromey  <tom@tromey.com>
9548
9549         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9550         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9551         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9552         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9553         (psym_lookup_symbol, psym_find_last_source_symtab)
9554         (psym_forget_cached_source_info, psym_print_stats)
9555         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9556         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9557         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9558         (psym_find_compunit_symtab_by_address)
9559         (maintenance_print_psymbols, maintenance_info_psymtabs)
9560         (maintenance_check_psymtabs): Use ranged for.
9561         * psymtab.h (class objfile_psymtabs): New.
9562         (require_partial_symbols): Return objfile_psymtabs.
9563         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9564
9565 2019-01-09  Tom Tromey  <tom@tromey.com>
9566
9567         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9568         (find_pc_mapped_section, list_overlays_command)
9569         (map_overlay_command, unmap_overlay_command)
9570         (simple_overlay_update): Use all_objfiles.
9571         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9572         * printcmd.c (info_symbol_command): Use all_objfiles.
9573         * objfiles.h (ALL_OBJSECTIONS): Remove.
9574         * maint.c (maintenance_translate_address): Use all_objfiles.
9575         * gcore.c (gcore_create_callback): Use all_objfiles.
9576         (objfile_find_memory_regions): Likewise.
9577
9578 2019-01-09  Tom Tromey  <tom@tromey.com>
9579
9580         * symtab.c (find_line_symtab, info_sources_command)
9581         (make_source_files_completion_list): Use objfile_compunits.
9582         * source.c (select_source_symtab): Use objfile_compunits.
9583         * objfiles.h (struct objfile): Update comment.
9584         (ALL_OBJFILES): Remove.
9585         (ALL_FILETABS): Remove.
9586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9587         objfile_compunits.
9588
9589 2019-01-09  Tom Tromey  <tom@tromey.com>
9590
9591         * symmisc.c (print_objfile_statistics, dump_objfile)
9592         (maintenance_print_symbols): Use compunit_filetabs.
9593         * source.c (forget_cached_source_info_for_objfile): Use
9594         compunit_filetabs.
9595         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9596         (ALL_FILETABS): Use compunit_filetabs.
9597         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9598         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9599
9600 2019-01-09  Tom Tromey  <tom@tromey.com>
9601
9602         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9603         (compunit_filetabs): New.
9604         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9605         compunit_filetabs.
9606         (info_sources_command, make_source_files_completion_list): Remove
9607         declaration.
9608         * symmisc.c (print_objfile_statistics, dump_objfile)
9609         (maintenance_print_symbols): Remove declaration.
9610         (maintenance_info_symtabs): Use compunit_filetabs.
9611         (maintenance_info_line_tables): Likewise.
9612         * source.c (select_source_symtab): Change local variable name.
9613         (forget_cached_source_info_for_objfile): Remove declaration.
9614         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9615         * objfiles.c (objfile_relocate1): Remove declaration.
9616         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9617         declaration.
9618         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9619         * coffread.c (coff_symtab_read): Remove declaration.
9620         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9621         compunit_filetabs.
9622
9623 2019-01-09  Tom Tromey  <tom@tromey.com>
9624
9625         * symtab.c (lookup_objfile_from_block)
9626         (find_pc_sect_compunit_symtab, search_symbols)
9627         (default_collect_symbol_completion_matches_break_on): Use
9628         objfile_compunits.
9629         * objfiles.h (ALL_COMPUNITS): Remove.
9630         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9631         * cp-support.c (add_symbol_overload_list_qualified): Use
9632         objfile_compunits.
9633         * ada-lang.c (ada_collect_symbol_completion_matches)
9634         (ada_add_global_exceptions): Use objfile_compunits.
9635
9636 2019-01-09  Tom Tromey  <tom@tromey.com>
9637
9638         * source.c (select_source_symtab)
9639         (forget_cached_source_info_for_objfile): Remove declaration.
9640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9641         declaration.
9642         * maint.c (count_symtabs_and_blocks): Remove declaration.
9643         * cp-support.c (add_symbol_overload_list_qualified): Remove
9644         declaration.
9645         * coffread.c (coff_symtab_read): Remove declaration.
9646         * symtab.c (lookup_symbol_in_objfile_symtabs)
9647         (basic_lookup_transparent_type_1): Use objfile_compunits.
9648         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9649         (info_sources_command, search_symbols)
9650         (default_collect_symbol_completion_matches_break_on)
9651         (make_source_files_completion_list): Remove declaration.
9652         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9653         (ada_collect_symbol_completion_matches)
9654         (ada_add_global_exceptions): Remove declaration.
9655         * linespec.c (iterate_over_all_matching_symtabs): Use
9656         objfile_compunits.
9657         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9658         (class objfile_compunits): New.
9659         (ALL_COMPUNITS): Use objfile_compunits.
9660         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9661         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9662         objfile_compunits.
9663         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9664
9665 2019-01-09  Tom Tromey  <tom@tromey.com>
9666
9667         * symtab.c (search_symbols)
9668         (default_collect_symbol_completion_matches_break_on): Use
9669         objfile_msymbols.
9670         * ada-lang.c (ada_lookup_simple_minsym)
9671         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9672         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9673         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9674         objfile_msymbols.
9675         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9676         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9677         * objc-lang.c (find_methods): Use objfile_msymbols.
9678         (info_selectors_command, info_classes_command): Likewise.
9679         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9680         * objfiles.h (class objfile_msymbols): New.
9681         (ALL_OBJFILE_MSYMBOLS): Remove.
9682         (ALL_MSYMBOLS): Remove.
9683
9684 2019-01-09  Tom Tromey  <tom@tromey.com>
9685
9686         * common/next-iterator.h (next_adapter): Add Iterator template
9687         parameter.
9688         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9689         (class all_objfiles_safe): New.
9690         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9691         * objfiles.c (put_objfile_before): Update comment.
9692         (add_separate_debug_objfile): Likewise.
9693         (free_all_objfiles): Use all_objfiles_safe.
9694         (objfile_purge_solibs): Likewise.
9695
9696 2019-01-09  Tom Tromey  <tom@tromey.com>
9697
9698         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9699         (expand_symtab_containing_pc, lookup_static_symbol)
9700         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9701         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9702         all_objfiles.
9703         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9704         * breakpoint.c (create_overlay_event_breakpoint)
9705         (create_longjmp_master_breakpoint)
9706         (create_std_terminate_master_breakpoint)
9707         (create_exception_master_breakpoint): Use all_objfiles.
9708         * linux-thread-db.c (try_thread_db_load_from_pdir)
9709         (has_libpthread): Use all_objfiles.
9710         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9711         * linespec.c (iterate_over_all_matching_symtabs)
9712         (search_minsyms_for_name): Use all_objfiles.
9713         * maint.c (maintenance_info_sections): Use all_objfiles.
9714         * main.c (captured_main_1): Use all_objfiles.
9715         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9716         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9717         * guile/scm-pretty-print.c
9718         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9719         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9720         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9721         (maintenance_print_msymbols): Use all_objfiles.
9722         * source.c (select_source_symtab): Use all_objfiles.
9723         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9724         * symfile.c (remove_symbol_file_command)
9725         (expand_symtabs_matching, map_symbol_filenames): Use
9726         all_objfiles.
9727         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9728         all_objfiles.
9729         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9730         * objc-lang.c (find_methods): Use all_objfiles.
9731         * objfiles.c (have_partial_symbols, have_full_symbols)
9732         (have_minimal_symbols, qsort_cmp)
9733         (default_iterate_over_objfiles_in_search_order): Use
9734         all_objfiles.
9735         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9736         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9737         (maintenance_check_psymtabs): Use all_objfiles.
9738         (ALL_PSYMTABS): Remove.
9739         * compile/compile-object-run.c (do_module_cleanup): Use
9740         all_objfiles.
9741         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9742         * cp-support.c (add_symbol_overload_list_qualified): Use
9743         all_objfiles.
9744         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9745         Use all_objfiles.
9746         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9747         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9748         all_objfiles.
9749         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9750         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9751         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9752         Uses all_objfiles.
9753         * solib.c (solib_read_symbols): Use all_objfiles
9754
9755 2019-01-09  Tom Tromey  <tom@tromey.com>
9756
9757         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9758         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9759         all_objfiles.
9760         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9761         * symmisc.c (print_symbol_bcache_statistics)
9762         (print_objfile_statistics, maintenance_print_objfiles)
9763         (maintenance_info_symtabs, maintenance_check_symtabs)
9764         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9765         all_objfiles.
9766         * source.c (forget_cached_source_info): Use all_objfiles.
9767         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9768         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9769         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9770         * objfiles.c (update_section_map): Use all_objfiles.
9771         (shared_objfile_contains_address_p): Likewise.
9772         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9773         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9774
9775 2019-01-09  Tom Tromey  <tom@tromey.com>
9776
9777         * common/next-iterator.h: New file.
9778         * objfiles.h (class all_objfiles): New.
9779         (struct objfile_iterator): New.
9780
9781 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9782
9783         * NEWS: Move the description of the changed "frame", "select-frame",
9784          and "info frame" commands to the Changed commands section.
9785
9786 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9787
9788         * gdbtypes.c (check_stub_method_group): Remove handling of old
9789         mangling schemes.
9790         * linespec.c (find_methods): Likewise.
9791         * stabsread.c (read_member_functions): Likewise.
9792         * valops.c (search_struct_method): Likewise.
9793         (value_struct_elt_for_reference): Likewise.
9794         * NEWS: Mention this change.
9795
9796 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9797
9798         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9799         print_source_lines.
9800         * source.c (print_source_lines_base): Update line number check.
9801         (print_source_lines): New function.
9802         (source_lines_range::source_lines_range): New function.
9803         * source.h (class source_lines_range): New class.
9804         (print_source_lines): New declaration.
9805
9806 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9807
9808         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9809
9810 2019-01-08  Tom Tromey  <tom@tromey.com>
9811             Simon Marchi  <simon.marchi@ericsson.com>
9812
9813         PR gdb/24060
9814         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9815         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9816         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9817         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9818         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9819         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9820
9821 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * source.c (select_source_symtab): Move header comment to
9824         declaration in source.h.
9825         (forget_cached_source_info_for_objfile): Likewise.
9826         (forget_cached_source_info): Likewise.
9827         (identify_source_line): Likewise.
9828         * source.h (identify_source_line): Move declaration from symtab.h
9829         and add comment from source.c
9830         (print_source_lines): Likewise.
9831         (forget_cached_source_info_for_objfile): Likewise.
9832         (forget_cached_source_info): Likewise.
9833         (select_source_symtab): Likewise.
9834         (enum print_source_lines_flag): Move definition from symtab.h.
9835         * symtab.h (identify_source_line): Move declaration to source.h.
9836         (print_source_lines): Likewise.
9837         (forget_cached_source_info_for_objfile): Likewise.
9838         (forget_cached_source_info): Likewise.
9839         (select_source_symtab): Likewise.
9840         (enum print_source_lines_flag): Move definition to source.h.
9841         * tui/tui-hooks.c: Add 'source.h' include.
9842
9843 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9844
9845         * source.c (print_source_lines_base): Handle requests to print
9846         reverse line number sequences, and guard against empty lines
9847         string.
9848
9849 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9850
9851         * source.c (print_source_lines_base): Fix skip of '\r' if next
9852         character is '\n'.
9853
9854 2019-01-06  Tom Tromey  <tom@tromey.com>
9855
9856         * c-exp.y (struct c_parse_state) <macro_original_text,
9857         expansion_obstack>: New member.
9858         (macro_original_text, expansion_obstack): Remove globals.
9859         (scan_macro_expansion, scanning_macro_expansion)
9860         (finished_macro_expansion): Update.
9861         (scan_macro_cleanup): Remove.
9862         (yylex, c_parse): Update.
9863
9864 2019-01-06  Tom Tromey  <tom@tromey.com>
9865
9866         * c-exp.y (struct c_parse_state) <strings>: New member.
9867         (operator_stoken): Update.
9868
9869 2019-01-06  Tom Tromey  <tom@tromey.com>
9870
9871         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9872         (union type_stack_elt) <typelist_val>: Now a pointer to
9873         std::vector.
9874         (type_stack_cleanup): Don't declare.
9875         (push_typelist): Update.
9876         * parse.c (pop_typelist): Return a std::vector.
9877         (push_typelist): Take a std::vector.
9878         (follow_types): Update.  Do not free args.
9879         (type_stack_cleanup): Remove.
9880         * c-exp.y (struct c_parse_state): New.
9881         (cpstate): New global.
9882         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9883         (nonempty_typelist): Update.
9884         (func_mod): Create a new vector.
9885         (c_parse): Create a c_parse_state.
9886         (check_parameter_typelist): Do not delete params.
9887         (function_method): Update.  Do not delete type_list.
9888
9889 2019-01-06  Tom Tromey  <tom@tromey.com>
9890
9891         PR gdb/28155:
9892         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9893         check_typedef.
9894         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9895         (print_return_value): Likewise.
9896
9897 2019-01-05  Tom Tromey  <tom@tromey.com>
9898
9899         * contrib/cleanup_check.py: Remove.
9900         * contrib/gcc-with-excheck: Remove.
9901         * contrib/exsummary.py: Remove.
9902         * contrib/excheck.py: Remove.
9903
9904 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9905
9906         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9907         NULL. Initialize tpprev to NULL instead of assigning it
9908         to NULL on the next statement.
9909         * windows-nat.c (windows_delete_thread): Remove check for
9910         main_thread_id before printing thread exit notifications.
9911         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9912         Remove thread ID check against main_thread_id.
9913         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9914         windows_delete_thread.
9915         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9916
9917 2019-01-04  Tom Tromey  <tom@tromey.com>
9918
9919         * compile/compile.c (_initialize_compile): Use upper case for
9920         metasyntactic variables.
9921         * symmisc.c (_initialize_symmisc): Use upper case for
9922         metasyntactic variables.
9923         * psymtab.c (_initialize_psymtab): Use upper case for
9924         metasyntactic variables.
9925         * demangle.c (demangle_command): Use upper case for metasyntactic
9926         variables.
9927         (_initialize_demangler): Likewise.
9928         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9929         variables.
9930
9931 2019-01-03  Tom Tromey  <tom@tromey.com>
9932
9933         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9934
9935 2019-01-03  Tom Tromey  <tom@tromey.com>
9936
9937         * python/py-symtab.c (salpy_str): Update.
9938         (struct salpy_sal_object) <symtab>: Now a PyObject.
9939         (salpy_dealloc): Update.
9940         (del_objfile_sal): Use gdbpy_ref.
9941
9942 2019-01-03  Tom Tromey  <tom@tromey.com>
9943
9944         * python/py-type.c (convert_field): Use new_reference.  Return
9945         gdbpy_ref.
9946         (make_fielditem): Return gdbpy_ref.
9947         (typy_fields): Update.
9948         (typy_getitem): Update.
9949         (field_name): Return gdbpy_ref.  Use new_reference.
9950         (typy_iterator_iternext): Update.
9951
9952 2019-01-03  Tom Tromey  <tom@tromey.com>
9953
9954         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9955
9956 2019-01-03  Tom Tromey  <tom@tromey.com>
9957
9958         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9959         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9960         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9961         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9962         (pspy_set_type_printers): Likewise.
9963         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9964         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9965         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9966         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9967         (objfpy_set_type_printers): Likewise.
9968
9969 2019-01-03  Tom Tromey  <tom@tromey.com>
9970
9971         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9972         (gdbpy_print_stack): Use gdbpy_err_fetch.
9973         * python/python-internal.h (class gdbpy_err_fetch): New class.
9974         (class gdbpy_enter) <m_error_type, m_error_value,
9975         m_error_traceback>: Remove.
9976         <m_error>: New member.
9977         (gdbpy_exception_to_string): Don't declare.
9978         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9979         * python/py-value.c (convert_value_from_python): Use
9980         gdbpy_err_fetch.
9981         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9982         gdbpy_exception_to_string.
9983         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9984         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9985         gdbpy_err_fetch.
9986
9987 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9988
9989         * linux-nat.c (delete_lwp_cleanup): Delete.
9990         (struct lwp_deleter): New struct.
9991         (lwp_info_up): New typedef.
9992         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9993         lwp_info_up.
9994
9995 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9996
9997         * linux-fork.c (class scoped_switch_fork_info): New class.
9998         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9999
10000 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10001
10002         * valops.c (find_overload_match): Remove use of null_cleanup, and
10003         calls to do_cleanups.
10004
10005 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10006
10007         * compile/compile-cplus-types.c
10008         (compile_cplus_instance::decl_name): Handle changes to
10009         cp_func_name.
10010         * cp-support.c (cp_func_name): Update header comment, update
10011         return type.
10012         * cp-support.h (cp_func_name): Update return type in declaration.
10013         * valops.c (find_overload_match): Move temp_func local to top
10014         level of function and change its type.  Use temp_func to hold and
10015         delete temporary string obtained from cp_func_name.
10016
10017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10018
10019         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10020         gdb::char_vector, remove cleanup, and update uses of `msg`.
10021
10022 2019-01-03  Jim Wilson  <jimw@sifive.com>
10023
10024         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10025
10026 2019-01-02  Tom Tromey  <tom@tromey.com>
10027
10028         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10029         (tdesc_parse_xml): Remove cleanups.
10030         * target-descriptions.h (make_cleanup_free_target_description):
10031         Don't declare.
10032         (target_desc_deleter): New struct.
10033         (target_desc_up): New typedef.
10034         * target-descriptions.c (target_desc_deleter::operator()): Rename
10035         from free_target_description.
10036         (make_cleanup_free_target_description): Remove.
10037
10038 2019-01-02  Tom Tromey  <tom@tromey.com>
10039
10040         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10041         constructor, destructor.
10042         (linespec_parser): Remove typedef.
10043         (~linespec_parser): Rename from linespec_parser_delete.
10044         (linespec_lex_to_end, linespec_complete_label)
10045         (linespec_complete): Update.
10046         (decode_line_full): Remove cleanups.
10047         (decode_line_1): Update.
10048
10049 2019-01-02  Tom Tromey  <tom@tromey.com>
10050
10051         * python/python-internal.h (inferior_to_inferior_object): Change
10052         return type.
10053         * python/py-exitedevent.c (create_exited_event_object): Update.
10054         * python/py-inferior.c (inferior_to_inferior_object): Return
10055         gdbpy_ref.
10056         (python_new_inferior, python_inferior_deleted)
10057         (thread_to_thread_object, delete_thread_object)
10058         (build_inferior_list, gdbpy_selected_inferior): Update.
10059         * python/py-infthread.c (create_thread_object): Update.  Also fail
10060         if inferior_to_inferior_object fails.
10061
10062 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10063
10064         * inferior.h (class inferior) <displaced_step_state>: New field.
10065         * infrun.h (struct displaced_step_state): Move here from
10066         infrun.c.  Initialize fields, add constructor.
10067         <inf>: Remove field.
10068         <reset>: New method.
10069         * infrun.c (struct displaced_step_inferior_state): Move to
10070         infrun.h.
10071         (displaced_step_inferior_states): Remove.
10072         (get_displaced_stepping_state): Adust.
10073         (displaced_step_in_progress_any_inferior): Adjust.
10074         (displaced_step_in_progress_thread): Adjust.
10075         (displaced_step_in_progress): Adjust.
10076         (add_displaced_stepping_state): Remove.
10077         (get_displaced_step_closure_by_addr): Adjust.
10078         (remove_displaced_stepping_state): Remove.
10079         (infrun_inferior_exit): Call displaced_step_state.reset.
10080         (use_displaced_stepping): Don't check for NULL.
10081         (displaced_step_prepare_throw): Call
10082         get_displaced_stepping_state.
10083         (displaced_step_fixup): Don't check for NULL.
10084         (prepare_for_detach): Don't check for NULL.
10085
10086 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10087
10088         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10089          in case of call that did not complete.
10090
10091 2019-01-02  Andrey Utkin  <autkin@undo.io>
10092
10093         * symfile.c (find_separate_debug_file): Fix search of debug files for
10094         remote debuggee.
10095
10096 2019-01-02  Tom Tromey  <tom@tromey.com>
10097
10098         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10099         indentation.
10100         * python/py-frame.c (frapy_older): Remove cast.
10101         (frapy_newer): Likewise.
10102         * python/py-breakpoint.c (local_setattro): Remove cast.
10103         * python/py-arch.c (archpy_name): Remove local variable.
10104         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10105
10106 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10107
10108         * unittests/basic_string_view/element_access/char/empty.cc:
10109         Fix year range in copyright header.
10110
10111 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10112
10113         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10114         Delete.
10115         <operator==>: Update with for removed field.
10116         <hash>: Likewise.
10117         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10118         <isa_features>: ...this.
10119         <abi_features>: New field.
10120         (riscv_isa_flen): Update comment.
10121         (riscv_abi_xlen): New declaration.
10122         (riscv_abi_flen): New declaration.
10123         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10124         isa_features.
10125         (riscv_abi_xlen): New function.
10126         (riscv_isa_flen): Update to get answer from isa_features.
10127         (riscv_abi_flen): New function.
10128         (riscv_has_fp_abi): Update to get answer from abi_features.
10129         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10130         xlen and flen.
10131         (riscv_call_info) <xlen, flen>: Update comment.
10132         (riscv_call_arg_struct): Remove invalid assertions
10133         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10134         is removed.
10135         (riscv_gdbarch_init): Gather isa features and abi features
10136         separately, ensure both match on the gdbarch when reusing an old
10137         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10138         a target with 64-bit float hardware.
10139
10140 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10141
10142         * source.c (search_command_helper): Stop reverse search
10143         when line 1 has been searched.
10144
10145 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10146
10147         * record-full.c (record_full_base_target::close): Rewrite
10148         record_full_core_buf_list free logic.
10149
10150 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10151
10152         * break-catch-syscall.c (print_one_catch_syscall): xfree
10153         the last text.
10154
10155 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10156
10157         * top.c (print_gdb_version): Update Copyright year in version
10158         message.
10159
10160 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10161
10162         Update copyright year range in all GDB files.
10163
10164 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10165
10166         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10167
10168 For older changes see ChangeLog-2018.
10169 \f
10170 Local Variables:
10171 mode: change-log
10172 left-margin: 8
10173 fill-column: 74
10174 version-control: never
10175 coding: utf-8
10176 End:
10177