gdb/ChangeLog

   1 2019-12-01  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
   4         parameter.
   5         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
   6         parameter.
   7         * tui/tui-win.h (compact_source): Declare.
   8         * tui/tui-win.c (compact_source): New global.
   9         (tui_set_compact_source, tui_show_compact_source): New functions.
  10         (_initialize_tui_win): Add "compact-source" setting.
  11         * tui/tui-source.c (tui_source_window::set_contents): Handle
  12         compact_source setting.
  13         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  14         * NEWS: Document new setting.
  15
  16 2019-11-30  Tom Tromey  <tom@tromey.com>
  17
  18         * dwarf2read.c (dwarf2_add_field): Include field offset when
  19         computing variant part length.
  20
  21 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  22         * NEWS:  Mention define-prefix.  Tell that command names can now
  23         contain a . character.
  24
  25 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  26
  27         * command.h (valid_cmd_char_p): Declare.
  28         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
  29         the check of valid command char.
  30         (find_command_name_length, valid_user_defined_cmd_name_p): Use
  31         valid_cmd_char_p.
  32         * cli/cli-script.c (validate_comname): Likewise.
  33         * completer.c (gdb_completer_command_word_break_characters):
  34         Do not remove . from the word break char, update comments.
  35         (complete_line_internal_1): Use valid_cmd_char_p.
  36         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  37         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  38
  39 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  40
  41         * cli/cli-script.c (do_define_command): Ensure a redefined
  42         prefix command is kept as a prefix command.
  43         (define_prefix_command): New function.
  44         (show_user_1): Report user defined prefixes.
  45         (_initialize_cli_script):  Create the new 'define-prefix' command.
  46         Add completers for 'define' and 'document'.
  47         * top.c (execute_command):  If command is a user-defined prefix only
  48         command, report the list of commands for this prefix command.
  49
  50 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  51
  52         * valops.c (find_oload_champ): Improve debug output.
  53
  54 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  55
  56         * valops.c (find_oload_champ): Print part of debug messages
  57         before the badness vector is std::move'd.
  58
  59 2019-11-28  Tom Tromey  <tom@tromey.com>
  60
  61         * value.c (creal_internal_fn): Fix comment.
  62
  63 2019-11-28  Tom Tromey  <tom@tromey.com>
  64
  65         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
  66         flag_bound_evaluated>: Now unsigned.
  67
  68 2019-11-28  Tom Tromey  <tom@tromey.com>
  69
  70         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
  71         declare.
  72
  73 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
  74
  75         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
  76         debug output.
  77         * jit.c (jit_unregister_code): Add debug print to match
  78         `jit_register_code`.
  79
  80 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  81
  82         * NEWS: Mention the new multithreaded symbol loading.
  83
  84 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  85
  86         * maint.c (n_worker_threads): Default to 0.
  87         (worker_threads_disabled): New function.
  88         * maint.h (worker_threads_disabled): New function.
  89         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
  90         here if worker_threads_disabled () is true.
  91         (minimal_symbol_reader::install): Skip all threading if
  92         worker_threads_disabled () is true.
  93
  94 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  95
  96         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
  97         hash code if possible.
  98         (add_minsym_to_demangled_hash_table): Likewise.
  99         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 100         on the background thread.
 101         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 102         Add these fields.
 103
 104 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 105
 106         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 107         of the mangled name on the background thread.
 108         * symtab.c (symbol_set_names): Allow passing in the hash of the
 109         linkage_name.
 110         * symtab.h (symbol_set_names): Likewise.
 111
 112 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 113
 114         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 115         physnames are computed for inherited DIEs.
 116
 117 2019-11-27  Tom Tromey  <tromey@adacore.com>
 118
 119         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 120         backslashes.
 121         * cp-support.c: Remove unnecessary backslashes.
 122
 123 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 124
 125         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 126         with sym->set_linkage_name.
 127         * coffread.c (coff_read_enum_type): Likewise.
 128         * mdebugread.c (parse_symbol): Likewise.
 129         * stabsread.c (patch_block_stabs): Likewise.
 130         (define_symbol): Likewise.
 131         (read_enum_type): Likewise.
 132         (common_block_end): Likewise.
 133         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 134         function.
 135         (SYMBOL_SET_LINKAGE_NAME): Remove.
 136         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 137         with sym->set_linkage_name.
 138
 139 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 142         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 143         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 144         * NEWS: Mention new MI command.
 145
 146 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 147
 148         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 149         '-symbol-info-types', and '-symbol-info-variables'.
 150         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 151         (mi_cmd_symbol_info_types): Declare.
 152         (mi_cmd_symbol_info_variables): Declare.
 153         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 154         (output_debug_symbol): New function.
 155         (output_nondebug_symbol): New function.
 156         (mi_symbol_info): New function.
 157         (mi_info_functions_or_variables): New function.
 158         (mi_cmd_symbol_info_functions): New function.
 159         (mi_cmd_symbol_info_types): New function.
 160         (mi_cmd_symbol_info_variables): New function.
 161         * NEWS: Mention new commands.
 162
 163 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * symtab.c (symbol_to_info_string): New function, most content
 166         moved from print_symbol_info, but updated to return a std::string.
 167         (print_symbol_info): Update to use symbol_to_info_string and print
 168         returned string.
 169         * symtab.h (symbol_to_info_string): Declare new function.
 170
 171 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * python/python.c (gdbpy_rbreak): Convert to using
 174         global_symbol_searcher.
 175         * symtab.c (file_matches): Convert return type to bool, change
 176         file list to std::vector, update header comment.
 177         (search_symbols): Rename to...
 178         (global_symbol_searcher::search): ...this and update now its
 179         a member function of global_symbol_searcher.  Take account of the
 180         changes to file_matches.
 181         (symtab_symbol_info): Convert to using global_symbol_searcher.
 182         (rbreak_command): Likewise.
 183         (search_module_symbols): Likewise.
 184         * symtab.h (enum symbol_search): Update comment.
 185         (search_symbols): Remove declaration.
 186         (class global_symbol_searcher): New class.
 187
 188 2019-11-26  Tom Tromey  <tromey@adacore.com>
 189
 190         * cp-support.c (_initialize_cp_support): Conditionally initialize
 191         gdb_demangle_attempt_core_dump.
 192
 193 2019-11-26  Tom Tromey  <tom@tromey.com>
 194
 195         * python/py-function.c (fnpy_init): Update.
 196         * value.h (add_internal_function): Adjust declaration.
 197         * value.c (function_destroyer): Remove.
 198         (do_add_internal_function): Don't set destroyer or copy name.
 199         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 200         Set name_allocated.
 201         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 202         (cmdpy_init): Set name_allocated.
 203         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 204         member.
 205         (~cmd_list_element): Free "name" if needed.
 206
 207 2019-11-26  Tom Tromey  <tom@tromey.com>
 208
 209         * value.h (add_internal_function): Add new overload.  Move
 210         documentation from value.h.
 211         * value.c (do_add_internal_function): New function.
 212         (add_internal_function): Use it.  Add new overload.
 213         (function_destroyer): Don't free doc.
 214         * python/py-function.c (fnpy_init): Update.
 215
 216 2019-11-26  Tom Tromey  <tom@tromey.com>
 217
 218         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 219         (cmdpy_init): Set "doc_allocated".
 220
 221 2019-11-26  Tom Tromey  <tom@tromey.com>
 222
 223         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 224         name of worker thread.
 225         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 226         pthread_setname_np.
 227         * configure, config.in: Rebuild.
 228
 229 2019-11-26  Tom Tromey  <tom@tromey.com>
 230
 231         * python/python.c (class gdbpy_gil): New.
 232         (struct gdbpy_event): Add constructor, destructor, operator().
 233         (gdbpy_post_event): Use run_on_main_thread.
 234         (gdbpy_initialize_events): Remove.
 235         (do_start_initialization): Update.
 236
 237 2019-11-26  Tom Tromey  <tom@tromey.com>
 238
 239         * NEWS: Add entry.
 240         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 241         commands.  Call update_thread_pool_size.
 242         (update_thread_pool_size, maintenance_set_worker_threads): New
 243         functions.
 244         (n_worker_threads): New global.
 245
 246 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 247             Tom Tromey  <tom@tromey.com>
 248
 249         * minsyms.c (minimal_symbol_reader::install): Use
 250         parallel_for_each.
 251         * gdbsupport/parallel-for.h: New file.
 252         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 253
 254 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 255             Tom Tromey  <tom@tromey.com>
 256
 257         * gdbsupport/thread-pool.h: New file.
 258         * gdbsupport/thread-pool.c: New file.
 259         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 260         (HFILES_NO_SRCDIR): Add thread-pool.h.
 261
 262 2019-11-26  Tom Tromey  <tom@tromey.com>
 263
 264         * event-top.h (thread_local_segv_handler): Declare.
 265         * event-top.c (thread_local_segv_handler): New global.
 266         (install_handle_sigsegv, handle_sigsegv): New functions.
 267         (async_init_signals): Install SIGSEGV handler.
 268         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 269         thread-local.
 270         (report_failed_demangle): New function.
 271         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 272         handler-setting code, instead use segv_handler.  Run warning code
 273         on main thread.
 274
 275 2019-11-26  Tom Tromey  <tom@tromey.com>
 276
 277         * run-on-main-thread.c: New file.
 278         * run-on-main-thread.h: New file.
 279         * unittests/main-thread-selftests.c: New file.
 280         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 281         main-thread-selftests.c.
 282         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 283         (COMMON_SFILES): Add run-on-main-thread.c.
 284
 285 2019-11-26  Tom Tromey  <tom@tromey.com>
 286
 287         * main.c (setup_alternate_signal_stack): Remove.
 288         (captured_main_1): Use gdb::alternate_signal_stack.
 289         * gdbsupport/alt-stack.h: New file.
 290
 291 2019-11-26  Tom Tromey  <tom@tromey.com>
 292
 293         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 294         Remove comment.
 295         (save_original_signals_state, restore_original_signals_state): Use
 296         gdb_sigmask.
 297         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 298         (_initialize_linux_nat): Use gdb_sigmask.
 299         * guile/guile.c (_initialize_guile): Use block_signals.
 300         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 301         * gdbsupport/gdb-sigmask.h: New file.
 302         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 303         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 304         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 305         pthread_sigmask.
 306         * configure, config.in: Rebuild.
 307         * gdbsupport/block-signals.h: New file.
 308
 309 2019-11-26  Tom Tromey  <tom@tromey.com>
 310
 311         * acinclude.m4: Include ax_pthread.m4.
 312         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 313         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 314         (CLIBS): Use PTHREAD_LIBS.
 315         (aclocal_m4_deps): Add ax_pthread.m4.
 316         * config.in, configure: Rebuild.
 317         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 318
 319 2019-11-26  Tom Tromey  <tom@tromey.com>
 320
 321         * symtab.h (struct minimal_symbol) <name_set>: New member.
 322         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 323         Don't call symbol_set_names.
 324         (minimal_symbol_reader::install): Call symbol_set_names.
 325
 326 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 329         restore_active_ext_lang, as GIL is needed for (indirectly)
 330         called PyOS_InterruptOccurred.
 331
 332 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 333
 334         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 335         definition.
 336
 337 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 338
 339         * remote-sim.c (simulator_command): Make static, remove
 340         declaration.
 341
 342 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 343
 344         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 345         static.
 346         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 347         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 348         (main): Likewise.
 349         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 350         (main): Likewise.
 351         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 352         (main): Likewise.
 353         * unittests/basic_string_view/element_access/char/1.cc (test01):
 354         Likewise.
 355         (main): Likewise.
 356         * unittests/basic_string_view/element_access/char/empty.cc (main):
 357         Likewise.
 358         * unittests/basic_string_view/element_access/char/front_back.cc
 359         (test01): Likewise.
 360         (main): Likewise.
 361         * unittests/basic_string_view/inserters/char/2.cc (test05):
 362         Likewise.
 363         (main): Likewise.
 364         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 365         (test01): Likewise.
 366         (main): Likewise.
 367         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 368         (test01): Likewise.
 369         (main): Likewise.
 370         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 371         Likewise.
 372         * unittests/basic_string_view/operations/compare/char/1.cc
 373         (test01): Likewise.
 374         (main): Likewise.
 375         * unittests/basic_string_view/operations/compare/char/13650.cc
 376         (test01): Likewise.
 377         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 378         Likewise.
 379         (main): Likewise.
 380         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 381         Likewise.
 382         (main): Likewise.
 383         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 384         Likewise.
 385         (main): Likewise.
 386         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 387         Likewise.
 388         (main): Likewise.
 389         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 390         Likewise.
 391         (main): Likewise.
 392         * unittests/basic_string_view/operations/find/char/4.cc (main):
 393         Likewise.
 394         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 395         Likewise.
 396         (main): Likewise.
 397         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 398         Likewise.
 399         (main): Likewise.
 400         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 401         Likewise.
 402         (main): Likewise.
 403         * unittests/basic_string_view/operations/substr/char/1.cc
 404         (test01): Likewise.
 405         (main): Likewise.
 406         * unittests/basic_string_view/operators/char/2.cc (main):
 407         Likewise.
 408         * unittests/optional/assignment/1.cc (test): Likewise.
 409         * unittests/optional/assignment/2.cc (test): Likewise.
 410         * unittests/optional/assignment/3.cc (test): Likewise.
 411         * unittests/optional/assignment/4.cc (test): Likewise.
 412         * unittests/optional/assignment/5.cc (test): Likewise.
 413         * unittests/optional/assignment/6.cc (test): Likewise.
 414         * unittests/optional/assignment/7.cc (test): Likewise.
 415         * unittests/optional/cons/copy.cc (test): Likewise.
 416         * unittests/optional/cons/default.cc (test): Likewise.
 417         * unittests/optional/cons/move.cc (test): Likewise.
 418         * unittests/optional/cons/value.cc (test): Likewise.
 419         * unittests/optional/in_place.cc (test): Likewise.
 420         * unittests/optional/observers/1.cc (test): Likewise.
 421         * unittests/optional/observers/2.cc (test): Likewise.
 422
 423 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 424
 425         * tui-win.h (tui_set_var_cmd): Remove.
 426         * tui-win.c (tui_set_var_cmd): Make static.
 427
 428 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 429
 430         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 431         rbreak_command_wrapper): Remove.
 432         * symtab.c (rbreak_command_wrapper): Remove.
 433
 434 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 435
 436         * inferior.h (info_terminal_command): Remove declaration.
 437         * inflow.c (info_terminal_command): Make static.
 438
 439 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 440
 441         * inferior.c (exit_inferior_silent): Remove.
 442
 443 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 444
 445         * dictionary.c (dict_empty, mdict_empty): Remove.
 446         * dictionary.c (mdict_empty): Remove.
 447
 448 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 449
 450          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 451          (arc_insn_get_memory_offset): Likewise.
 452          (arc_insn_dump): Likewise.
 453          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 454          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 455          * dictionary.c (dict_iterator_next): Likewise.
 456          (dict_iter_match_first): Likewise.
 457          (dict_iter_match_next): Likewise.
 458          * f-lang.c (evaluate_subexp_f): Likewise.
 459          * hppa-tdep.c (hppa_read_pc): Likewise.
 460          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 461          * parse.c (write_exp_elt_msym): Likewise.
 462          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 463          * remote.c (remote_packet_size): Likewise.
 464          (remote_notif_stop_parse): Likewise.
 465          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 466          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 467          * source.c (prepare_path_for_appending): Likewise.
 468          * sparc64-linux-tdep.c
 469          (sparc64_linux_handle_segmentation_fault); Likewise.
 470          * stack.c (frame_selection_by_function_completer): Likewise.
 471
 472 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 473
 474         * completer.c (set_gdb_completion_word_break_characters):
 475         Remove.
 476
 477 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * dwarf-index-write.c: Include dwarf-index-write.h.
 480         * mi/mi-interp.c: Include mi/mi-interp.h.
 481
 482 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 483
 484         * aarch32-tdep.c: Include aarch32-tdep.h.
 485         * aarch32-tdep.h: Forward-declare struct target_desc.
 486
 487 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 488
 489         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 490         strerror.
 491         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 492         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 493
 494 2019-11-25  Tom de Vries  <tdevries@suse.de>
 495
 496         * contrib/words.sh: Add -c option.
 497
 498 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 499
 500         * solib.c (solib_find_1): Change int to bool.
 501         (exec_file_find): Change int to bool.
 502         (solib_find): Change int to bool.
 503         (solib_read_symbols): Change int to bool.
 504         (solib_used): Change int to bool.
 505         (solib_add): Change int to bool.
 506         (info_sharedlibrary_command): Change int to bool.
 507         (solib_contains_address_p): Change int to bool.
 508         (solib_keep_data_in_core): Change int to bool.
 509         (in_solib_dynsym_resolve_code): Change int to bool.
 510         (reload_shared_libraries_1): Change int to bool.
 511         (gdb_sysroot_changed): Change int to bool.
 512         * solib.h (solib_read_symbols): Change int to bool.
 513         (solib_contains_address_p): Change int to bool.
 514         (solib_keep_data_in_core): Change int to bool.
 515         (in_solib_dynsym_resolve_code): Change int to bool.
 516         (libpthread_name_p): Change int to bool.
 517
 518 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 519
 520         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 521         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 522         (remote_packet_max_chars): New static global.
 523         (show_remote_packet_max_chars): New function.
 524         (remote_target::putpkt_binary): Adjust to use new
 525         remote_packet_max_chars option.
 526         (remote_target::getpkt_or_notif_sane_1): Likewise.
 527         (_initialize_remote): Register new remote-packet-max-chars option.
 528
 529 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 530
 531         * m68k-linux-nat.c: Include gdbarch.h.
 532
 533 2019-11-24  Tom Tromey  <tom@tromey.com>
 534
 535         * symfile.c (read_symbols): Update.
 536         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 537         bool.
 538         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 539         (psym_lookup_symbol, psym_find_last_source_symtab)
 540         (psym_forget_cached_source_info, psym_print_stats)
 541         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 542         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 543         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 544         (psym_find_compunit_symtab_by_address)
 545         (maintenance_print_psymbols, maintenance_info_psymtabs)
 546         (maintenance_check_psymtabs): Update.
 547         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 548         bool.
 549
 550 2019-11-22  Tom Tromey  <tom@tromey.com>
 551
 552         * observable.h: Update comments.
 553
 554 2019-11-22  Tom Tromey  <tromey@adacore.com>
 555
 556         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 557         (print_ada_task_info): Don't try to fetch thread id if task is not
 558         alive.
 559
 560 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * ada-exp.y: Update.
 563         * ada-lang.c (sort_choices): Update.
 564         (ada_print_symbol_signature): Update.
 565         (resolve_subexp): Update.
 566         (ada_parse_renaming): Update.
 567         (ada_read_renaming_var_value): Update.
 568         (lesseq_defined_than): Update.
 569         (remove_extra_symbols): Update.
 570         (remove_irrelevant_renamings): Update.
 571         (ada_add_block_symbols): Update.
 572         (ada_collect_symbol_completion_matches): Update.
 573         (ada_is_renaming_symbol): Update.
 574         (aggregate_assign_from_choices): Update.
 575         (ada_evaluate_subexp): Update.
 576         (ada_has_this_exception_support): Update.
 577         (ada_is_non_standard_exception_sym): Update.
 578         (ada_add_exceptions_from_frame): Update.
 579         (ada_add_global_exceptions): Update.
 580         (ada_print_subexp): Update.
 581         * ax-gdb.c (gen_var_ref): Update.
 582         (gen_maybe_namespace_elt): Update.
 583         (gen_expr_for_cast): Update.
 584         (gen_expr): Update.
 585         * block.h: Update.
 586         * blockframe.c (find_pc_partial_function): Update.
 587         * breakpoint.c (print_breakpoint_location): Update.
 588         (update_static_tracepoint): Update.
 589         * btrace.c (ftrace_print_function_name): Update.
 590         (ftrace_function_switched): Update.
 591         * buildsym.c (find_symbol_in_list): Update.
 592         * c-exp.y: Update.
 593         * c-typeprint.c (c_print_typedef): Update.
 594         (c_type_print_template_args): Update.
 595         * cli/cli-cmds.c (edit_command): Update.
 596         (list_command): Update.
 597         (print_sal_location): Update.
 598         * coffread.c (patch_opaque_types): Update.
 599         (process_coff_symbol): Update.
 600         (coff_read_enum_type): Update.
 601         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 602         (convert_one_symbol): Update.
 603         (hash_symname): Update.
 604         (eq_symname): Update.
 605         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 606         * compile/compile-cplus-types.c (debug_print_scope): Update.
 607         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 608         * compile/compile-object-load.c (get_out_value_type): Update.
 609         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 610         (search_symbol_list): Update.
 611         (cp_lookup_symbol_imports_or_template): Update.
 612         * cp-support.c (overload_list_add_symbol): Update.
 613         * ctfread.c (psymtab_to_symtab): Update.
 614         * dbxread.c (cp_set_block_scope): Update.
 615         * dictionary.c (iter_match_first_hashed): Update.
 616         (iter_match_next_hashed): Update.
 617         (insert_symbol_hashed): Update.
 618         (iter_match_next_linear): Update.
 619         * dictionary.h: Update.
 620         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 621         (locexpr_describe_location_piece): Update.
 622         (locexpr_describe_location_1): Update.
 623         (locexpr_generate_c_location): Update.
 624         (loclist_describe_location): Update.
 625         (loclist_generate_c_location): Update.
 626         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 627         (read_func_scope): Update.
 628         (process_enumeration_scope): Update.
 629         (new_symbol): Update.
 630         (dwarf2_const_value): Update.
 631         (dwarf2_symbol_mark_computed): Update.
 632         * eval.c (evaluate_funcall): Update.
 633         (evaluate_subexp_standard): Update.
 634         * expprint.c (print_subexp_standard): Update.
 635         (dump_subexp_body_standard): Update.
 636         * f-valprint.c (info_common_command_for_block): Update.
 637         * findvar.c (get_hosting_frame): Update.
 638         (default_read_var_value): Update.
 639         * go-lang.c (go_symbol_package_name): Update.
 640         * guile/scm-block.c (bkscm_print_block_smob): Update.
 641         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 642         (gdbscm_symbol_name): Update.
 643         (gdbscm_symbol_linkage_name): Update.
 644         (gdbscm_symbol_print_name): Update.
 645         * infcall.c (get_function_name): Update.
 646         * infcmd.c (jump_command): Update.
 647         (finish_command): Update.
 648         * infrun.c (insert_exception_resume_breakpoint): Update.
 649         * linespec.c (canonicalize_linespec): Update.
 650         (create_sals_line_offset): Update.
 651         (convert_linespec_to_sals): Update.
 652         (complete_label): Update.
 653         (find_label_symbols_in_block): Update.
 654         * m2-typeprint.c (m2_print_typedef): Update.
 655         * mdebugread.c (mdebug_reg_to_regnum): Update.
 656         (parse_symbol): Update.
 657         (mylookup_symbol): Update.
 658         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 659         (list_args_or_locals): Update.
 660         * objc-lang.c (compare_selectors): Update.
 661         (info_selectors_command): Update.
 662         (compare_classes): Update.
 663         (info_classes_command): Update.
 664         (find_imps): Update.
 665         * p-typeprint.c (pascal_print_typedef): Update.
 666         * printcmd.c (build_address_symbolic): Update.
 667         (info_address_command): Update.
 668         (print_variable_and_value): Update.
 669         * python/py-framefilter.c (extract_sym): Update.
 670         (py_print_single_arg): Update.
 671         * python/py-symbol.c (sympy_str): Update.
 672         (sympy_get_name): Update.
 673         (sympy_get_linkage_name): Update.
 674         * python/python.c (gdbpy_rbreak): Update.
 675         * record-btrace.c (btrace_get_bfun_name): Update.
 676         (btrace_call_history): Update.
 677         * rust-lang.c (rust_print_typedef): Update.
 678         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 679         * stabsread.c (stab_reg_to_regnum): Update.
 680         (define_symbol): Update.
 681         (read_enum_type): Update.
 682         (common_block_end): Update.
 683         (cleanup_undefined_types_1): Update.
 684         (scan_file_globals): Update.
 685         * stack.c (print_frame_arg): Update.
 686         (print_frame_args): Update.
 687         (find_frame_funname): Update.
 688         (info_frame_command_core): Update.
 689         (iterate_over_block_locals): Update.
 690         (print_block_frame_labels): Update.
 691         (do_print_variable_and_value): Update.
 692         (iterate_over_block_arg_vars): Update.
 693         (return_command): Update.
 694         * symmisc.c (dump_symtab_1): Update.
 695         (print_symbol): Update.
 696         * symtab.c (eq_symbol_entry): Update.
 697         (symbol_cache_dump): Update.
 698         (lookup_language_this): Update.
 699         (find_pc_sect_line): Update.
 700         (skip_prologue_sal): Update.
 701         (symbol_search::compare_search_syms): Update.
 702         (treg_matches_sym_type_name): Update.
 703         (search_symbols): Update.
 704         (print_symbol_info): Update.
 705         (rbreak_command): Update.
 706         (completion_list_add_symbol): Update.
 707         (find_gnu_ifunc): Update.
 708         (get_symbol_address): Update.
 709         (search_module_symbols): Update.
 710         (info_module_subcommand): Update.
 711         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 712         (SYMBOL_LINKAGE_NAME): Remove.
 713         (SYMBOL_DEMANGLED_NAME): Remove.
 714         (SYMBOL_PRINT_NAME): Remove.
 715         (SYMBOL_SEARCH_NAME): Remove.
 716         * tracepoint.c (set_traceframe_context): Update.
 717         (validate_actionline): Update.
 718         (collection_list::collect_symbol): Update.
 719         (encode_actions_1): Update.
 720         (info_scope_command): Update.
 721         (print_one_static_tracepoint_marker): Update.
 722         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 723         * valops.c (address_of_variable): Update.
 724         (find_overload_match): Update.
 725         (find_oload_champ): Update.
 726
 727 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 728
 729         * ada-lang.c (ada_lookup_simple_minsym): Update.
 730         (ada_collect_symbol_completion_matches): Update.
 731         * ada-tasks.c (read_atcb): Update.
 732         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 733         (amd64_windows_skip_trampoline_code): Update.
 734         * arm-tdep.c (skip_prologue_function): Update.
 735         (arm_skip_stack_protector): Update.
 736         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 737         (arm_wince_skip_main_prologue): Update.
 738         * ax-gdb.c (gen_expr): Update.
 739         * block.c (call_site_for_pc): Update.
 740         * blockframe.c (find_pc_partial_function): Update.
 741         * breakpoint.c (set_breakpoint_location_function): Update.
 742         * btrace.c (ftrace_print_function_name): Update.
 743         (ftrace_function_switched): Update.
 744         * c-valprint.c (print_unpacked_pointer): Update.
 745         * coffread.c (coff_symfile_read): Update.
 746         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 747         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 748         * dwarf-index-write.c (write_psymbols): Update.
 749         * dwarf2loc.c (call_site_to_target_addr): Update.
 750         (func_verify_no_selftailcall): Update.
 751         (tailcall_dump): Update.
 752         (call_site_find_chain_1): Update.
 753         (dwarf_expr_reg_to_entry_parameter): Update.
 754         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 755         * eval.c (evaluate_funcall): Update.
 756         (evaluate_subexp_standard): Update.
 757         (evaluate_subexp_for_sizeof): Update.
 758         * expprint.c (print_subexp_standard): Update.
 759         (dump_subexp_body_standard): Update.
 760         * frame.c (get_prev_frame_always_1): Update.
 761         * frv-tdep.c (frv_skip_main_prologue): Update.
 762         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 763         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 764         (gnuv3_get_typename_from_type_info): Update.
 765         (gnuv3_skip_trampoline): Update.
 766         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 767         * i386-tdep.c (i386_skip_main_prologue): Update.
 768         (i386_pe_skip_trampoline_code): Update.
 769         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 770         * infcall.c (get_function_name): Update.
 771         * linespec.c (minsym_found): Update.
 772         * linux-fork.c (info_checkpoints_command): Update.
 773         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 774         (m32c_m16c_pointer_to_address): Update.
 775         * maint.c (maintenance_translate_address): Update.
 776         * minsyms.c (add_minsym_to_hash_table): Update.
 777         (add_minsym_to_demangled_hash_table): Update.
 778         (lookup_minimal_symbol_mangled): Update.
 779         (lookup_minimal_symbol_demangled): Update.
 780         (lookup_minimal_symbol_linkage): Update.
 781         (lookup_minimal_symbol_text): Update.
 782         (lookup_minimal_symbol_by_pc_name): Update.
 783         (minimal_symbol_is_less_than): Update.
 784         (compact_minimal_symbols): Update.
 785         (build_minimal_symbol_hash_tables): Update.
 786         (find_solib_trampoline_target): Update.
 787         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 788         (mips_skip_pic_trampoline_code): Update.
 789         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 790         * objc-lang.c (info_selectors_command): Update.
 791         (info_classes_command): Update.
 792         (find_methods): Update.
 793         (find_imps): Update.
 794         * p-valprint.c (pascal_val_print): Update.
 795         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 796         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 797         * printcmd.c (build_address_symbolic): Update.
 798         (info_symbol_command): Update.
 799         * psymtab.c (psymbol_name_matches): Update.
 800         (match_partial_symbol): Update.
 801         (lookup_partial_symbol): Update.
 802         (print_partial_symbols): Update.
 803         (sort_pst_symbols): Update.
 804         (maintenance_check_psymtabs): Update.
 805         * python/py-framefilter.c (py_print_frame): Update.
 806         * python/python.c (gdbpy_rbreak): Update.
 807         * record-btrace.c (btrace_get_bfun_name): Update.
 808         (btrace_call_history): Update.
 809         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 810         (rs6000_skip_trampoline_code): Update.
 811         * sol-thread.c (info_cb): Update.
 812         * stabsread.c (scan_file_globals): Update.
 813         * stack.c (find_frame_funname): Update.
 814         (info_frame_command_core): Update.
 815         * symmisc.c (dump_msymbols): Update.
 816         * symtab.c (symbol_natural_name): Rename to..,
 817         (general_symbol_info::natural_name): ...this.
 818         (symbol_demangled_name): Rename to...
 819         (general_symbol_info::demangled_name): ...this.
 820         (symbol_search_name): Rename to...
 821         (general_symbol_info::search_name): ...this.
 822         (symbol_matches_search_name): Update.
 823         (find_pc_sect_line): Update.
 824         (skip_prologue_sal): Update.
 825         (search_symbols): Update.
 826         (print_msymbol_info): Update.
 827         (rbreak_command): Update.
 828         (completion_list_add_msymbol): Update.
 829         (completion_list_objc_symbol): Update.
 830         (get_msymbol_address): Update.
 831         * symtab.h (struct general_symbol_info): Add member functions
 832         natural_name (), linkage_name (), print_name (), demangled_name (),
 833         and search_name ().
 834         (SYMBOL_NATURAL_NAME): Update.
 835         (symbol_natural_name): Move to a member function on general_symbol_info.
 836         (SYMBOL_DEMANGLED_NAME): Update.
 837         (symbol_demangled_name): Move to a member function on
 838         general_symbol_info.
 839         (SYMBOL_SEARCH_NAME): Update.
 840         (symbol_search_name): Move to a member function on general_symbol_info.
 841         (MSYMBOL_NATURAL_NAME): Remove.
 842         (MSYMBOL_LINKAGE_NAME): Remove.
 843         (MSYMBOL_PRINT_NAME): Remove.
 844         (MSYMBOL_DEMANGLED_NAME): Remove.
 845         (MSYMBOL_SEARCH_NAME): Remove.
 846         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 847
 848 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * symtab.c (create_demangled_names_hash): Use per_bfd->
 851         minimal_symbol_count for computing the initial size, if greater
 852         than our default size.
 853
 854 2019-11-22  Tom de Vries  <tdevries@suse.de>
 855
 856         * contrib/words.sh: Improve words extraction.
 857
 858 2019-11-22  Tom de Vries  <tdevries@suse.de>
 859
 860         * contrib/words.sh: Combine sed invocations.
 861
 862 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 863
 864         * Makefile.in: Update.
 865         * demangle.c: Rename to...
 866         * gdb-demangle.c: ..this.
 867         (is_cplus_marker): Change return type to bool.
 868         (_initialize_demangler): Rename to...
 869         (_initialize_gdb_demangle): ...this.
 870         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 871         * symtab.h (demangle): Remove declaration; instead include
 872         gdb-demangle.h.
 873
 874 2019-11-21  Tom Tromey  <tromey@adacore.com>
 875
 876         * gdbsupport/format.c (format_pieces): Parse %I64d.
 877         * unittests/format_pieces-selftests.c (test_windows_formats): New
 878         function.
 879         (run_tests): Call it.
 880
 881 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 882
 883         Byte reverse display of variables with DW_END_big, DW_END_little
 884         (DW_AT_endianity) dwarf attributes if different than the native
 885         byte order.
 886         * ada-lang.c (ada_value_binop):
 887         Use type_byte_order instead of gdbarch_byte_order.
 888         * ada-valprint.c (printstr):
 889         (ada_val_print_string):
 890         * ada-lang.c (value_pointer):
 891         (ada_value_binop):
 892         Use type_byte_order instead of gdbarch_byte_order.
 893         * c-lang.c (c_get_string):
 894         Use type_byte_order instead of gdbarch_byte_order.
 895         * c-valprint.c (c_val_print_array):
 896         Use type_byte_order instead of gdbarch_byte_order.
 897         * cp-valprint.c (cp_print_class_member):
 898         Use type_byte_order instead of gdbarch_byte_order.
 899         * dwarf2loc.c (rw_pieced_value):
 900         Use type_byte_order instead of gdbarch_byte_order.
 901         * dwarf2read.c (read_base_type): Handle DW_END_big,
 902         DW_END_little
 903         * f-lang.c (f_get_encoding):
 904         Use type_byte_order instead of gdbarch_byte_order.
 905         * findvar.c (default_read_var_value):
 906         Use type_byte_order instead of gdbarch_byte_order.
 907         * gdbtypes.c (check_types_equal):
 908         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 909         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 910         and TYPE_ENDIANITY_LITTLE if set.
 911         (type_byte_order): new function.
 912         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 913         (struct main_type) <flag_endianity_not_default>:
 914         New field.
 915         (type_byte_order): New function.
 916         * infcmd.c (default_print_one_register_info):
 917         Use type_byte_order instead of gdbarch_byte_order.
 918         * p-lang.c (pascal_printstr):
 919         Use type_byte_order instead of gdbarch_byte_order.
 920         * p-valprint.c (pascal_val_print):
 921         Use type_byte_order instead of gdbarch_byte_order.
 922         * printcmd.c (print_scalar_formatted):
 923         Use type_byte_order instead of gdbarch_byte_order.
 924         * solib-darwin.c (darwin_current_sos):
 925         Use type_byte_order instead of gdbarch_byte_order.
 926         * solib-svr4.c (solib_svr4_r_ldsomap):
 927         Use type_byte_order instead of gdbarch_byte_order.
 928         * stap-probe.c (stap_modify_semaphore):
 929         Use type_byte_order instead of gdbarch_byte_order.
 930         * target-float.c (target_float_same_format_p):
 931         Use type_byte_order instead of gdbarch_byte_order.
 932         * valarith.c (scalar_binop):
 933         (value_bit_index):
 934         Use type_byte_order instead of gdbarch_byte_order.
 935         * valops.c (value_cast):
 936         Use type_byte_order instead of gdbarch_byte_order.
 937         * valprint.c (generic_emit_char):
 938         (generic_printstr):
 939         (val_print_string):
 940         Use type_byte_order instead of gdbarch_byte_order.
 941         * value.c (unpack_long):
 942         (unpack_bits_as_long):
 943         (unpack_value_bitfield):
 944         (modify_field):
 945         (pack_long):
 946         (pack_unsigned_long):
 947         Use type_byte_order instead of gdbarch_byte_order.
 948         * findvar.c (unsigned_pointer_to_address):
 949         (signed_pointer_to_address):
 950         (unsigned_address_to_pointer):
 951         (address_to_signed_pointer):
 952         (default_read_var_value):
 953         (default_value_from_register):
 954         Use type_byte_order instead of gdbarch_byte_order.
 955         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 956         Use type_byte_order instead of gdbarch_byte_order.
 957         * riscv-tdep.c (riscv_print_one_register_info):
 958         Use type_byte_order instead of gdbarch_byte_order.
 959
 960 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 961
 962         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 963         (current_ui_gdb_stdin_ptr): Likewise.
 964         (current_ui_gdb_stderr_ptr): Likewise.
 965         (current_ui_gdb_stdlog_ptr): Likewise.
 966         (current_ui_current_uiout_ptr): Likewise.
 967         (gen_ret_current_ui_field_ptr): Remove.
 968
 969 2019-11-21  Tom de Vries  <tdevries@suse.de>
 970
 971         PR gdb/24956
 972         * cli/cli-script.c (execute_control_command): Only switch to
 973         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 974
 975 2019-11-19  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 978         Now static.  Change type of "name".
 979         (tui_set_win_height_command): Don't copy "arg".
 980         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 981         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 982
 983 2019-11-19  Ali Tamur <tamur@google.com>
 984
 985         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 986         "if (attr != nullptr)".
 987         (dwarf2_find_base_address): Likewise.
 988         (dwarf2_build_include_psymtabs): Likewise.
 989         (read_cutu_die_from_dwo): Likewise.
 990         (read_func_scope): Likewise.
 991         (read_call_site_scope): Likewise.
 992         (dwarf2_get_pc_bounds): Likewise.
 993         (dwarf2_record_block_ranges): Likewise.
 994         (dwarf2_add_field): Likewise.
 995         (dwarf2_add_member_fn): Likewise.
 996         (read_structure_type): Likewise.
 997         (read_enumeration_type): Likewise.
 998         (read_array_type): Likewise.
 999         (read_array_order): Likewise.
1000         (read_set_type): Likewise.
1001         (read_common_block): Likewise.
1002         (read_tag_reference_type): Likewise.
1003         (read_tag_string_type): Likewise.
1004         (read_subroutine_type): Likewise.
1005         (read_base_type): Likewise.
1006         (read_subrange_type): Likewise.
1007         (new_symbol): Likewise.
1008         (prepare_one_comp_unit): Likewise.
1009
1010 2019-11-19  Tom Tromey  <tromey@adacore.com>
1011
1012         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1013         result in error when DebugActiveProcess fails.
1014
1015 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1016             Pedro Alves  <palves@redhat.com>
1017
1018         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1019         * target.c (target_stack::push): Call 'unpush' if there's a
1020         target on top of the stack.
1021
1022 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1023
1024         * python/py-block.c (blpy_dealloc): Call tp_free.
1025         (blpy_block_syms_dealloc): Likewise.
1026         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1027         * python/py-inferior.c (infpy_dealloc): Likewise.
1028         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1029         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1030         * python/py-symbol.c (sympy_dealloc): Likewise.
1031         * python/py-symtab.c (stpy_dealloc): Likewise.
1032         * python/py-type.c (typy_iterator_dealloc): Likewise.
1033
1034 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1037         constructor instead of using a class initializer.
1038
1039 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1040
1041         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1042         * configure: Regenerate.
1043         * configure.ac: Don't source common.host.
1044         * gdbsupport/common.host: Remove.
1045         * gdbsupport/mingw-strerror.c: Remove.
1046         * gdbsupport/posix-strerror.c: Rename to...
1047         * gdbsupport/safe-strerror.c: ...this.
1048
1049 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1050
1051         * maint.c (scoped_command_stats::print_time): Use localtime_r
1052         instead of localtime (provided through gnulib if necessary).
1053         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1054         of ctime.
1055
1056 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1059         avoid compile errors.
1060
1061 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1062
1063         * config.in: Regenerate.
1064         * configure: Regenerate.
1065         * gdbsupport/common.m4: No longer check for strerror_r.
1066         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1067         POSIX version of strerror_r, now that gnulib provides it if
1068         necessary.
1069
1070 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1071
1072         * README (`configure' options): Update.
1073
1074 2019-11-14  Tom Tromey  <tromey@adacore.com>
1075
1076         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1077         expected type for the RHS if the LHS is a convenience variable.
1078
1079 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1080
1081         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1082         Provide explicit default and copy constructor.
1083
1084 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1085
1086         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1087         only call Py_INCREF (newbp) in the bppy_pending_object case.
1088
1089 2019-11-13  Tom Tromey  <tromey@adacore.com>
1090
1091         PR build/25182:
1092         * psympriv.h (partial_symbol): Remove static assert.
1093         * symtab.h (general_symbol_info, symbol): Remove static assert.
1094
1095 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * gdbsupport/format.c (format_pieces::format_pieces): Support
1098         printf 'z' size modifier.
1099         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1100         * printcmd.c (ui_printf):  Handle size_t_arg.
1101         * ui-out.c (ui_out::vmessage): Likewise.
1102         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1103         function.
1104         (run_tests): Call test_format_int_sizes.
1105
1106 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1107
1108         * ada-exp.y (write_ambiguous_var): Update.
1109         * buildsym.c (add_symbol_to_list): Update.
1110         * dwarf2read.c (read_variable): Update.
1111         (new_symbol): Update.
1112         * jit.c (finalize_symtab): Update.
1113         * language.c (language_alloc_type_symbol): Update.
1114         * symtab.c (fixup_symbol_section): Update.
1115         (initialize_objfile_symbol_1): Move code to...
1116         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1117         (allocate_symbol): Update.
1118         (allocate_template_symbol): Update.
1119         (get_symbol_address): Update.
1120         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1121         of having as a field, and add a constructor.
1122         (SYMBOL_VALUE): Update.
1123         (SYMBOL_VALUE_ADDRESS): Update.
1124         (SET_SYMBOL_VALUE_ADDRESS): Update.
1125         (SYMBOL_VALUE_BYTES): Update.
1126         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1127         (SYMBOL_BLOCK_VALUE): Update.
1128         (SYMBOL_VALUE_CHAIN): Update.
1129         (SYMBOL_LANGUAGE): Update.
1130         (SYMBOL_SECTION): Update.
1131         (SYMBOL_OBJ_SECTION): Update.
1132         (SYMBOL_SET_LANGUAGE): Update.
1133         (SYMBOL_SET_LINKAGE_NAME): Update.
1134         (SYMBOL_SET_NAMES): Update.
1135         (SYMBOL_NATURAL_NAME): Update.
1136         (SYMBOL_LINKAGE_NAME): Update.
1137         (SYMBOL_DEMANGLED_NAME): Update.
1138         (SYMBOL_SEARCH_NAME): Update.
1139         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1140         (struct symbol): Update.
1141         (struct template_symbol): Update.
1142         (struct rust_vtable_symbol): Update.
1143         * xcoffread.c (SYMBOL_DUP): Update.
1144
1145 2019-11-12  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-layout.c (show_layout): Set current_layout.
1148         (show_source_disasm_command, show_data)
1149         (show_source_or_disasm_and_command): Don't set current_layout.
1150
1151 2019-11-12  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1154
1155 2019-11-12  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-win.c (resize_message): New global.
1158         (show_tui_resize_message): New function.
1159         (tui_async_resize_screen): Print message if requested.
1160         (_initialize_tui_win): Add tui-resize-message setting.
1161         * NEWS: Add entry for new commands.
1162
1163 2019-11-11  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1166         functions.
1167
1168 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1171
1172 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1175         function.
1176         * python/python-internal.h (gdbpy_lookup_static_symbols):
1177         Declare new function.
1178         * python/python.c (python_GdbMethods): Add
1179         gdb.lookup_static_symbols method.
1180         * NEWS: Mention gdb.lookup_static_symbols.
1181
1182 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1185         static block of current object file first.  Also fix typo in
1186         header comment.
1187
1188 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * stack.c (set_last_displayed_sal): Delete.
1191         (last_displayed_sal_valid): Delete.
1192         (last_displayed_pspace): Delete.
1193         (last_displayed_addr): Delete.
1194         (last_displayed_symtab): Delete.
1195         (last_displayed_line): Delete.
1196         (class last_displayed_symtab_info_type): New.
1197         (last_displayed_symtab_info): New static global variable.
1198         (print_frame_info): Call methods on last_displayed_symtab_info.
1199         (clear_last_displayed_sal): Update header comment, and make use of
1200         last_displayed_symtab_info.
1201         (last_displayed_sal_is_valid): Likewise.
1202         (get_last_displayed_pspace): Likewise.
1203         (get_last_displayed_addr): Likewise.
1204         (get_last_displayed_symtab): Likewise.
1205         (get_last_displayed_line): Likewise.
1206         (get_last_displayed_sal): Likewise.
1207         * stack.h (clear_last_displayed_sal): Update header comment.
1208         (last_displayed_sal_is_valid): Likewise.
1209         (get_last_displayed_pspace): Likewise.
1210         (get_last_displayed_addr): Likewise.
1211         (get_last_displayed_symtab): Likewise.
1212         (get_last_displayed_line): Likewise.
1213         (get_last_displayed_sal): Likewise.
1214
1215 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * stack.c (frame_show_address): Convert return type to bool.
1218         * stack.h (frame_show_address): Likewise, and update header
1219         comment.
1220
1221 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1224         * unittests/vec-utils-selftests.c: New file.
1225         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1226
1227 2019-11-10  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1230         (tui_highlight_win): Likewise.
1231         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1232         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1233         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1234         Don't set can_highlight.
1235
1236 2019-11-10  Tom Tromey  <tom@tromey.com>
1237
1238         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1239         Remove unused declaration.
1240
1241 2019-11-08  Tom Tromey  <tromey@adacore.com>
1242
1243         * top.c (read_command_file): Update.
1244         (command_line_input): Make return type const.
1245         * python/py-gdb-readline.c: Update.
1246         * linespec.c (decode_line_2): Update.
1247         * defs.h (command_line_input): Make return type const.
1248         * cli/cli-script.c (read_next_line): Make return type const.
1249         * ada-lang.c (get_selections): Update.
1250
1251 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1252
1253         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1254         * mi/mi-main.c (output_cores): Likewise.
1255         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1256         (linux_xfer_osdata_modules): Likewise.
1257         * remote.c (register_remote_support_xml): Likewise.
1258         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1259         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1260
1261 2019-11-06  Tom Tromey  <tom@tromey.com>
1262
1263         * tui/tui-interp.c: Don't include readline.h.
1264         * tui/tui-hooks.c: Don't include readline.h.
1265         * symmisc.c: Include tilde.h, not readline.h.
1266         * symfile.c: Include tilde.h, not readline.h.
1267         * source.c: Include tilde.h, not readline.h.
1268         * solib.c: Include tilde.h, not readline.h.
1269         * psymtab.c: Include tilde.h, not readline.h.
1270         * exec.c: Include tilde.h, not readline.h.
1271         * corelow.c: Include tilde.h, not readline.h.
1272         * cli/cli-dump.c: Include tilde.h, not readline.h.
1273         * cli/cli-cmds.c: Don't include readline.h.
1274
1275 2019-11-05  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1278         (tui_disassemble): Set addr_size.
1279         (tui_disasm_window::set_contents): Use addr_size.
1280
1281 2019-11-05  Tom Tromey  <tom@tromey.com>
1282
1283         * rust-lang.c (rust_language_defn): Update.
1284         * python/py-value.c (valpy_string): Call c_get_string.
1285         * p-lang.c (pascal_language_defn): Update.
1286         * opencl-lang.c (opencl_language_defn): Update.
1287         * objc-lang.c (objc_language_defn): Update.
1288         * m2-lang.c (m2_language_defn): Update.
1289         * language.c (unknown_language_defn, auto_language_defn): Update.
1290         (default_get_string): Remove.
1291         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1292         * go-lang.c (go_language_defn): Update.
1293         * f-lang.c (f_language_defn): Update.
1294         * d-lang.c (d_language_defn): Update.
1295         * c-lang.c (c_language_defn, cplus_language_defn)
1296         (asm_language_defn, minimal_language_defn): Update.
1297         * ada-lang.c (ada_language_defn): Update.
1298         * language.h (struct language_defn) <la_get_string>: Remove.
1299         (LA_GET_STRING): Remove.
1300         (default_get_string): Don't declare.
1301
1302 2019-11-05  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-source.h (struct tui_source_window): Inline
1305         constructor.  Remove destructor.
1306         <style_changed, m_observable>: Move to superclass.
1307         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1308         (struct tui_source_window_base): Move private members to end.
1309         <style_changed, m_observable>: Move from tui_source_window.
1310         * tui/tui-winsource.c (tui_copy_source_line): Move from
1311         tui-source.c.  Rename from copy_source_line.  Add special handling
1312         for negative line number.
1313         (tui_source_window_base::style_changed): Move from
1314         tui_source_window.
1315         (tui_source_window_base): Register observer.
1316         (~tui_source_window_base): New.
1317         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1318         rename.
1319         (tui_source_window::set_contents): Use tui_copy_source_line.
1320         (tui_source_window::tui_source_window): Move to tui-source.h.
1321         (tui_source_window::~tui_source_window): Remove.
1322         (tui_source_window::style_changed): Move to superclass.
1323         * tui/tui-disasm.c (tui_disassemble): Create string file with
1324         styling, when possible.  Add "addr_size" parameter.
1325         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1326         Don't compute maximum size.
1327         (len_without_escapes): New function
1328
1329 2019-11-05  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1332         std::string.
1333         * tui/tui-winsource.c (tui_show_source_line): Update.
1334         * tui/tui-source.c (tui_source_window::set_contents): Update.
1335         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1336
1337 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1338
1339         * symtab.h (gdb_static_assert): Put && operator at the beginning
1340         of the line instead of the end.
1341
1342 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1343
1344         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1345         and sizeof (symbol).
1346         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1347
1348 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1349
1350         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1351         * configure.host: Mark *-*-solaris2.10* obsolete.
1352         * configure.tgt: Mark Solaris < 11 obsolete.
1353         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1354         Update target triplet.
1355
1356 2019-11-01  Tom Tromey  <tromey@adacore.com>
1357
1358         * utils.c (print_sys_errmsg): Simplify.
1359
1360 2019-11-01  Tom Tromey  <tromey@adacore.com>
1361
1362         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1363
1364 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1365
1366         * configure: Regenerate.
1367         * configure.ac: Remove check for strerror_r.
1368         * gdbsupport/common.m4: Check for strerror_r.
1369
1370 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1371
1372         PR gdb/25124
1373
1374         * arm-tdep.c (arm_per_objfile): Rename to ...
1375         (arm_per_bfd): ... this.
1376         (arm_objfile_data_key): Rename to ...
1377         (arm_bfd_data_key): ... this.
1378         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1379         data.
1380         (arm_record_special_symbol): Likewise.
1381
1382 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1385         end.
1386         * c-typeprint.c (c_print_typedef): Likewise.
1387         * f-typeprint.c (f_print_typedef): Likewise.
1388         * m2-typeprint.c (m2_print_typedef): Likewise.
1389         * p-typeprint.c (pascal_print_typedef): Likewise.
1390         * rust-lang.c (rust_print_typedef): Likewise.
1391         * symtab.c (print_symbol_info): Print a newline after calling
1392         typedef_print.
1393
1394 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * symtab.c (info_module_cmdlist): New variable.
1397         (info_module_command): New function.
1398         (search_module_symbols): New function.
1399         (info_module_subcommand): New function.
1400         (struct info_modules_var_func_options): New struct.
1401         (info_modules_var_func_options_defs): New variable.
1402         (make_info_modules_var_func_options_def_group): New function.
1403         (info_module_functions_command): New function.
1404         (info_module_variables_command): New function.
1405         (info_module_var_func_command_completer): New function.
1406         (_initialize_symtab): Register new 'info module functions' and
1407         'info module variables' commands.
1408         * symtab.h (typedef symbol_search_in_module): New typedef.
1409         (search_module_symbols): Declare new function.
1410         * NEWS: Mention new commands.
1411
1412 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1415         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1416         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1417         MODULES_DOMAIN.
1418         (scan_partial_symbols): Only create partial module symbols for non
1419         declarations.
1420         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1421         and MODULES_DOMAIN.
1422         * symtab.c (search_domain_name): Likewise.
1423         (search_symbols): Likewise.
1424         (print_symbol_info): Likewise.
1425         (symtab_symbol_info): Likewise.
1426         (info_modules_command): New function.
1427         (_initialize_symtab): Register 'info modules' command.
1428         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1429         * NEWS: Mention new 'info modules' command.
1430
1431 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1432
1433         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1434         and $_gdb_maint_setting_str.
1435
1436 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1437
1438         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1439         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1440         (str_value_from_setting, gdb_setting_str_internal_fn)
1441         (gdb_maint_setting_str_internal_fn): New functions.
1442         (_initialize_cli_cmds): Define the new convenience functions.
1443         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1444         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1445
1446 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1447
1448         * agent.c (set_can_use_agent): When the setting is turned on,
1449         look up agent symbols if we don't have them yet.
1450         (agent_new_objfile): Don't look up agent symbols when the agent
1451         setting is off.
1452
1453 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1454
1455         * config.in: Regenerate.
1456
1457 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1458
1459         * configure: Regenerate.
1460         * configure.ac: Check for strerror_r.
1461         * gdbsupport/common-utils.h (safe_strerror): Change return value
1462         to const char * and document that this function is now threadsafe.
1463         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1464         thread_local and call strerror_r, if available.
1465         * utils.c (perror_string): Update.
1466         (print_sys_errmsg): Update.
1467
1468 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1469
1470         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1471         objfile_key.
1472         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1473         objfile to fetch per-bfd data.
1474         (arm_find_exidx_entry): Likewise.
1475
1476 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1477
1478         * gdbsupport/agent.c (debug_agent): Change type to bool.
1479         (use_agent): Likewise.
1480         (all_agent_symbols_look_up): Likewise.
1481         (agent_loaded_p): Change return value to bool.
1482         (agent_look_up_symbols): Update.
1483         (agent_capability_check): Change return value to bool.
1484         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1485         (debug_agent): Change type to bool.
1486         (use_agent): Likewise.
1487         (agent_capability_check): Change return value to bool.
1488
1489 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1490
1491         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1492         (build_minimal_symbol_hash_tables): Code to clear the table moved
1493         to clear_minimal_symbol_hash_tables.
1494         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1495         when needed.
1496
1497 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1498
1499         * infcmd.c: Remove includes.
1500         * infrun.c: Remove includes.
1501
1502 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1503
1504         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1505         (grow_vect): Remove declaration.
1506         (ada_type_of_array): Remove declaration.
1507         (ada_update_initial_language): Remove declaration.
1508         (ada_fold_name): Remove declaration.
1509         (ada_fill_in_ada_prototype): Remove declaration.
1510         (user_select_syms): Remove declaration.
1511         (get_selections): Remove declaration.
1512         (ada_tag_type): Remove declaration.
1513         (ada_value_tag): Remove declaration.
1514         (ada_is_others_clause): Remove declaration.
1515         (ada_in_variant): Remove declaration.
1516         (ada_value_struct_elt): Remove declaration.
1517         (ada_attribute_name): Remove declaration.
1518         (ada_system_address_type): Remove declaration.
1519         * ada-lang.c (ada_watch_location_expression): Make static.
1520         (GROW_VECT): Move here from ada-lang.h.
1521         (grow_vect): Make static.
1522         (ada_update_initial_language): Make static.
1523         (ada_fold_name): Make static.
1524         (ada_type_of_array): Make static.
1525         (encoded_ordered_before): Move up.
1526         (sort_choices): Move up.
1527         (print_signatures): Move up.
1528         (ada_print_symbol_signature): Move up.
1529         (get_selections): Move up and make static.
1530         (user_select_syms): Move up and make static.
1531         (ada_value_struct_elt): Move up and make static.
1532         (ada_tag_type): Make static.
1533         (ada_value_tag): Make static.
1534         (ada_is_others_clause): Make static.
1535         (ada_in_variant): Make static.
1536         (ada_attribute_name): Make static.
1537
1538 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1539
1540         * ada-lang.c: Remove includes.
1541         * ada-typeprint.c: Remove includes.
1542         * ada-valprint.c: Remove includes.
1543
1544 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1545
1546         * addrmap.c: Add static assertions of type size, moved from
1547         _initialize_addrmap.
1548         (_initialize_addrmap): Remove.
1549
1550 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1551
1552         * coffread.c (record_minimal_symbol): Update.
1553         (process_coff_symbol): Update.
1554         * dbxread.c (read_dbx_symtab): Update.
1555         * dwarf2read.c (add_partial_symbol): Update.
1556         (fixup_go_packaging): Update.
1557         (load_partial_dies): Update.
1558         (new_symbol): Update.
1559         * elfread.c (record_minimal_symbol): Change signature to use
1560         gdb::string_view instead of name+len.
1561         (elf_symtab_read): Update.
1562         (elf_rel_plt_read): Update.
1563         * mdebugread.c (parse_partial_symbols): Update.
1564         (handle_psymbol_enumerators): Update.
1565         (new_symbol): Update.
1566         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1567         to use gdb::string_view instead of name+len.
1568         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1569         * psympriv.h (add_psymbol_to_list): Likewise.
1570         * psymtab.c (add_psymbol_to_bcache): Likewise.
1571         (add_psymbol_to_list): Likewise.
1572         * stabsread.c (define_symbol): Update.
1573         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1574         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1575         (symbol_set_names): Likewise.
1576         * xcoffread.c (scan_xcoff_symtab): Update.
1577
1578 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1579
1580         * symtab.h (symbol_set_names): Document that copy_name must be
1581         set to true for non-nullterminated strings.
1582         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1583         linkage_name if the entry was not found and we need to demangle.
1584
1585 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1586
1587         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1588         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1589         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1590         * gdbsupport/gdb_binary_search.h: New file.
1591
1592 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1593
1594         * NEWS: Mention new --with-system-gdbinit-dir option.
1595         * config.in: Regenerate.
1596         * configure: Regenerate.
1597         * configure.ac: Add new option --with-system-gdbinit-dir.
1598         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1599         for a ".gdb" suffix.
1600         * main.c (get_init_files): Change system_gdbinit argument to
1601         a vector and return the files in SYSTEM_GDBINIT_DIR in
1602         addition to SYSTEM_GDBINIT.
1603         (captured_main_1): Update.
1604         (print_gdb_help): Update.
1605         * top.c (print_gdb_configuration): Also print the value of
1606         SYSTEM_GDBINIT_DIR.
1607
1608 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1609
1610         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1611         that takes gdb::string_view arguments.
1612
1613 2019-10-26  Tom de Vries  <tdevries@suse.de>
1614
1615         * aarch64-linux-tdep.c: Fix typos in comments.
1616         * aarch64-tdep.c: Same.
1617         * ada-lang.c: Same.
1618         * amd64-nat.c: Same.
1619         * arc-tdep.c: Same.
1620         * arch/aarch64-insn.c: Same.
1621         * block.c: Same.
1622         * breakpoint.h: Same.
1623         * btrace.h: Same.
1624         * c-varobj.c: Same.
1625         * cli/cli-decode.c: Same.
1626         * cli/cli-script.c: Same.
1627         * cli/cli-utils.h: Same.
1628         * coff-pe-read.c: Same.
1629         * coffread.c: Same.
1630         * compile/compile-cplus-symbols.c: Same.
1631         * compile/compile-object-run.c: Same.
1632         * completer.c: Same.
1633         * corelow.c: Same.
1634         * cp-support.c: Same.
1635         * demangle.c: Same.
1636         * dwarf-index-write.c: Same.
1637         * dwarf2-frame.c: Same.
1638         * dwarf2-frame.h: Same.
1639         * eval.c: Same.
1640         * frame-base.h: Same.
1641         * frame.h: Same.
1642         * gdbcmd.h: Same.
1643         * gdbtypes.h: Same.
1644         * gnu-nat.c: Same.
1645         * guile/scm-objfile.c: Same.
1646         * i386-tdep.c: Same.
1647         * i386-tdep.h: Same.
1648         * infcall.c: Same.
1649         * infcall.h: Same.
1650         * linux-nat.c: Same.
1651         * m68k-tdep.c: Same.
1652         * macroexp.c: Same.
1653         * memattr.c: Same.
1654         * mi/mi-cmd-disas.c: Same.
1655         * mi/mi-getopt.h: Same.
1656         * mi/mi-main.c: Same.
1657         * minsyms.c: Same.
1658         * nat/aarch64-sve-linux-sigcontext.h: Same.
1659         * objfiles.h: Same.
1660         * ppc-linux-nat.c: Same.
1661         * ppc-linux-tdep.c: Same.
1662         * ppc-tdep.h: Same.
1663         * progspace.h: Same.
1664         * prologue-value.h: Same.
1665         * python/py-evtregistry.c: Same.
1666         * python/py-instruction.h: Same.
1667         * record-btrace.c: Same.
1668         * record-full.c: Same.
1669         * remote.c: Same.
1670         * rs6000-tdep.c: Same.
1671         * ser-tcp.c: Same.
1672         * sol-thread.c: Same.
1673         * sparc-sol2-tdep.c: Same.
1674         * sparc64-tdep.c: Same.
1675         * stabsread.c: Same.
1676         * symfile.c: Same.
1677         * symtab.h: Same.
1678         * target.c: Same.
1679         * tracepoint.c: Same.
1680         * tui/tui-data.h: Same.
1681         * tui/tui-io.c: Same.
1682         * tui/tui-win.c: Same.
1683         * tui/tui.c: Same.
1684         * unittests/rsp-low-selftests.c: Same.
1685         * user-regs.h: Same.
1686         * utils.c: Same.
1687         * utils.h: Same.
1688         * valarith.c: Same.
1689         * valops.c: Same.
1690         * valprint.c: Same.
1691         * valprint.h: Same.
1692         * value.c: Same.
1693         * value.h: Same.
1694         * varobj.c: Same.
1695         * x86-nat.h: Same.
1696         * xtensa-tdep.c: Same.
1697
1698 2019-10-25  Ali Tamur <tamur@google.com>
1699
1700         * charset.c (find_charset_names): Reflect API change.
1701
1702 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1703
1704         * symtab.c (struct demangled_name_entry): Change demangled name
1705         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1706         part of the struct anymore.
1707         (symbol_set_names): No longer obstack allocate + copy the demangled
1708         name, just store the allocated name from bfd.
1709
1710 2019-10-25  Tom Tromey  <tromey@adacore.com>
1711
1712         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1713         (bsearch_cie_cmp, add_cie): Remove.
1714         (find_cie): Reimplement.
1715         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1716         (dwarf2_build_frame_info): Update.
1717
1718 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1719
1720         PR gdb/25126
1721         * symfile.c (reread_symbols): Call forget_cached_source_info to
1722         clear the stale source cache.
1723
1724 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1725
1726         * configure: Regenerate.
1727         * configure.ac: Remove code that sets python_has_threads.
1728
1729 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1730
1731         * config.in: Regenerate.
1732         * configure: Regenerate.
1733         * configure.ac: Remove the code that uses sed to get the python
1734         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1735
1736 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1737
1738         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1739         error paths.
1740
1741 2019-10-23  Tom Tromey  <tom@tromey.com>
1742
1743         * arc-tdep.c: Remove ".." from include.
1744         * frv-tdep.c: Remove ".." from include.
1745         * lm32-tdep.c: Remove ".." from include.
1746         * microblaze-tdep.c: Remove ".." from include.
1747         * or1k-tdep.h: Remove ".." from include.
1748         * s12z-tdep.c: Remove ".." from include.
1749         * Makefile.in (OPCODES_CFLAGS): Add comment.
1750         (TOP_CFLAGS): New variable.
1751         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1752
1753 2019-10-23  Tom Tromey  <tom@tromey.com>
1754
1755         * Makefile.in (READLINE_DIR): Update.
1756
1757 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1758
1759         * infcall.c (call_function_by_hand_dummy): Fix the function
1760         comment.  And extract out a code section into...
1761         (reserve_stack_space): ...this new function.
1762
1763 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1764
1765         * infcall.c (value_arg_coerce): Remove an unused parameter.
1766         (call_function_by_hand_dummy): Update the call to
1767         'value_arg_coerce'.
1768
1769 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1770
1771         * infcall.c (call_function_by_hand_dummy): Refactor.
1772
1773 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1774
1775         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1776
1777 2019-10-23  Tom Tromey  <tom@tromey.com>
1778
1779         * configure: Rebuild.
1780         * configure.ac: Don't check for sigprocmask.
1781         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1782
1783 2019-10-23  Tom Tromey  <tom@tromey.com>
1784
1785         * configure: Rebuild.
1786         * acinclude.m4: Use m4_include, not sinclude.
1787
1788 2019-10-23  Tom de Vries  <tdevries@suse.de>
1789
1790         PR breakpoints/24687
1791         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1792
1793 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1794
1795         * symtab.c (struct demangled_name_entry) <language>: Change from
1796         bitfield to regular variable.
1797
1798 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1799
1800         * symtab.c (struct demangled_name_entry): Add a constructor.
1801         (free_demangled_name_entry): New function to call the destructor
1802         for demangled_name_entry.
1803         (create_demangled_names_hash): Pass free_demangled_name_entry to
1804         htab_create_alloc.
1805         (symbol_set_names): Call placement new for demangled_name_entry.
1806         * utils.c: No longer include xxhash.h here, now that fast_hash
1807         is inlined in the header.
1808         * utils.h: Instead, include it here.
1809
1810 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1811
1812         * Makefile.in: Link with libxxhash.
1813         * config.in: Regenerate.
1814         * configure: Regenerate.
1815         * configure.ac: Search for libxxhash.
1816         * utils.c (fast_hash): Use xxhash if present.
1817
1818 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1819
1820         * utils.h (fast_hash): New function.
1821         * symtab.c (hash_demangled_name_entry): Call new function
1822         fast_hash.
1823
1824 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1825
1826         * symtab.c (struct demangled_name_entry): Change type of mangled
1827         to gdb::string_view. Also adds a constructor that takes the
1828         mangled name.
1829         (hash_demangled_name_entry): Update.
1830         (eq_demangled_name_entry): Update.
1831         (free_demangled_name_entry): New function to call the destructor
1832         now that this is not a POD anymore.
1833         (create_demangled_names_hash): Pass free_demangled_name_entry to
1834         htab_create_alloc.
1835         (symbol_set_names): Update.
1836
1837 2019-10-21  Ali Tamur  <tamu@google.com>
1838
1839         * dwarf2read.c (dir_index): Change type.
1840         (file_name_index): Likewise.
1841         (line_header::include_dir_at): Change comment and implementation on
1842         whether it is DWARF 5.
1843         (line_header::is_valid_file_index): New function.
1844         (line_header::file_name_at): Change comment and implementation on
1845         whether it is DWARF 5.
1846         (line_header::file_names): Change to private field renamed as
1847         m_file_names and introduce a new accessor method.
1848         (line_header::file_names_size): New method.
1849         (line_header::include_dirs): Change to private field and rename as
1850         m_include_dirs.
1851         (dw2_get_file_names_reader): Define local var at a smaller scope and
1852         reflect API change.
1853         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1854         (process_structure_scope): Likewise.
1855         (line_header::add_include_dir): Change message and reflect renaming.
1856         (line_header::add_file_name): Likewise.
1857         (read_formatted_entries): Handle DW_FORM_data16.
1858         (dwarf_decode_line_header): Fix line header length calculation.
1859         (psymtab_include_file_name): Change comment and API.
1860         (lnp_state_machine::m_file): Update comment and reflect type change.
1861         (lnp_state_machine::record_line): Reflect type change.
1862         (dwarf_decode_lines): Reflect API change.
1863         (file_file_name): Likewise.
1864         (file_full_name): Likewise.
1865
1866 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1869
1870 2019-10-21  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1873
1874 2019-10-21  Tom Tromey  <tom@tromey.com>
1875
1876         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1877         NM_H.   Use AC_CONFIG_LINKS.
1878         * configure: Rebuild.
1879         * Makefile.in (NM_H): New variable.
1880         (generated_files): Add NM_H.  Remove gcore.
1881         (nm.h, stamp-nmh): New targets.
1882
1883 2019-10-20  Tom Tromey  <tom@tromey.com>
1884
1885         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1886         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1887         obsolete comment.
1888         (put_objfile_before): Now static.
1889
1890 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1891
1892         * gdbsupport/common-utils.h (startswith): Change return type to
1893         bool.
1894
1895 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1896
1897         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1898         * breakpoint.c (bp_locations_compare): Rename to...
1899         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1900         (update_global_location_list): Use std::sort instead of qsort.
1901         * buildsym.c (compare_line_numbers): Rename to...
1902         (lte_is_less_than): ...this, and change to std::sort semantics.
1903         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1904         instead of qsort.
1905         * disasm.c (compare_lines): Rename to...
1906         (line_is_less_than): ...this, and change to std::sort semantics.
1907         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1908         of qsort.
1909         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1910         (fde_is_less_than): ...this, and change to std::sort semantics.
1911         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1912         * mdebugread.c (compare_blocks):
1913         (block_is_less_than): ...this, and change to std::sort semantics.
1914         (sort_blocks): Call std::sort instead of qsort.
1915         * objfiles.c (qsort_cmp): Rename to...
1916         (sort_cmp): ...this, and change to std::sort semantics.
1917         (update_section_map): Call std::sort instead of qsort.
1918         * remote.c (compare_pnums): Remove.
1919         (map_regcache_remote_table): Call std::sort instead of qsort.
1920         * utils.c (compare_positive_ints): Remove.
1921         * utils.h (compare_positive_ints): Remove.
1922         * xcoffread.c (compare_lte): Remove.
1923         (arrange_linetable): Call std::sort instead of qsort.
1924
1925 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1926
1927         * symfile.c (init_entry_point_info): Fix typo.
1928         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1929
1930 2019-10-18  Tom de Vries  <tdevries@suse.de>
1931
1932         * aarch64-tdep.c: Fix typos in comments.
1933         * ada-lang.c: Same.
1934         * ada-tasks.c: Same.
1935         * alpha-tdep.c: Same.
1936         * alpha-tdep.h: Same.
1937         * amd64-nat.c: Same.
1938         * amd64-windows-tdep.c: Same.
1939         * arc-tdep.c: Same.
1940         * arc-tdep.h: Same.
1941         * arch-utils.c: Same.
1942         * arm-nbsd-tdep.c: Same.
1943         * arm-tdep.c: Same.
1944         * ax-gdb.c: Same.
1945         * blockframe.c: Same.
1946         * btrace.c: Same.
1947         * c-varobj.c: Same.
1948         * coff-pe-read.c: Same.
1949         * coffread.c: Same.
1950         * cris-tdep.c: Same.
1951         * darwin-nat.c: Same.
1952         * dbxread.c: Same.
1953         * dcache.c: Same.
1954         * disasm.c: Same.
1955         * dtrace-probe.c: Same.
1956         * dwarf-index-write.c: Same.
1957         * dwarf2-frame-tailcall.c: Same.
1958         * dwarf2-frame.c: Same.
1959         * dwarf2read.c: Same.
1960         * eval.c: Same.
1961         * exceptions.c: Same.
1962         * fbsd-tdep.c: Same.
1963         * findvar.c: Same.
1964         * frame.c: Same.
1965         * frv-tdep.c: Same.
1966         * gnu-v3-abi.c: Same.
1967         * go32-nat.c: Same.
1968         * h8300-tdep.c: Same.
1969         * hppa-tdep.c: Same.
1970         * i386-linux-tdep.c: Same.
1971         * i386-tdep.c: Same.
1972         * ia64-libunwind-tdep.c: Same.
1973         * ia64-tdep.c: Same.
1974         * infcmd.c: Same.
1975         * infrun.c: Same.
1976         * linespec.c: Same.
1977         * linux-nat.c: Same.
1978         * linux-thread-db.c: Same.
1979         * machoread.c: Same.
1980         * mdebugread.c: Same.
1981         * mep-tdep.c: Same.
1982         * mn10300-tdep.c: Same.
1983         * namespace.c: Same.
1984         * objfiles.c: Same.
1985         * opencl-lang.c: Same.
1986         * or1k-tdep.c: Same.
1987         * osabi.c: Same.
1988         * ppc-linux-nat.c: Same.
1989         * ppc-linux-tdep.c: Same.
1990         * ppc-sysv-tdep.c: Same.
1991         * printcmd.c: Same.
1992         * procfs.c: Same.
1993         * record-btrace.c: Same.
1994         * record-full.c: Same.
1995         * remote-fileio.c: Same.
1996         * remote.c: Same.
1997         * rs6000-tdep.c: Same.
1998         * s12z-tdep.c: Same.
1999         * score-tdep.c: Same.
2000         * ser-base.c: Same.
2001         * ser-go32.c: Same.
2002         * skip.c: Same.
2003         * sol-thread.c: Same.
2004         * solib-svr4.c: Same.
2005         * solib.c: Same.
2006         * source.c: Same.
2007         * sparc-nat.c: Same.
2008         * sparc-sol2-tdep.c: Same.
2009         * sparc-tdep.c: Same.
2010         * sparc64-tdep.c: Same.
2011         * stabsread.c: Same.
2012         * stack.c: Same.
2013         * symfile.c: Same.
2014         * symtab.c: Same.
2015         * target-descriptions.c: Same.
2016         * target-float.c: Same.
2017         * thread.c: Same.
2018         * utils.c: Same.
2019         * valops.c: Same.
2020         * valprint.c: Same.
2021         * value.c: Same.
2022         * varobj.c: Same.
2023         * windows-nat.c: Same.
2024         * xcoffread.c: Same.
2025         * xstormy16-tdep.c: Same.
2026         * xtensa-tdep.c: Same.
2027
2028 2019-10-17  Tom Tromey  <tromey@adacore.com>
2029
2030         * configure: Rebuild.
2031         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2032         in AC_CONFIG_FILES invocation.
2033         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2034         new-style config.status invocation.
2035
2036 2019-10-17  Tom de Vries  <tdevries@suse.de>
2037
2038         * arm-nbsd-nat.c: Fix typos in comments.
2039         * arm-tdep.c: Same.
2040         * darwin-nat-info.c: Same.
2041         * dwarf2read.c: Same.
2042         * elfread.c: Same.
2043         * event-top.c: Same.
2044         * findvar.c: Same.
2045         * gdbtypes.c: Same.
2046         * hppa-tdep.c: Same.
2047         * i386-tdep.c: Same.
2048         * jit.c: Same.
2049         * main.c: Same.
2050         * mdebugread.c: Same.
2051         * moxie-tdep.c: Same.
2052         * nto-procfs.c: Same.
2053         * osabi.c: Same.
2054         * ppc-linux-tdep.c: Same.
2055         * remote.c: Same.
2056         * riscv-tdep.c: Same.
2057         * s390-tdep.c: Same.
2058         * sh-tdep.c: Same.
2059         * sparc-linux-tdep.c: Same.
2060         * sparc-nat.c: Same.
2061         * stack.c: Same.
2062         * target-descriptions.c: Same.
2063         * top.c: Same.
2064         * varobj.c: Same.
2065
2066 2019-10-16  Tom Tromey  <tom@tromey.com>
2067
2068         * objfiles.h (struct objfile) <original_name>: Now const.
2069
2070 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2071
2072         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2073         pass on to sigsetjmp's second argument.
2074         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2075
2076 2019-10-16  Keith Seitz  <keiths@redhat.com>
2077
2078         PR gdb/23567
2079         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2080         sections whose size is greater than the file size.
2081
2082 2019-10-16  Jim Wilson  <jimw@sifive.com>
2083
2084         * riscv-tdep.c (riscv_gcc_target_options): New.
2085         (riscv_gnu_triplet_regexp): New.
2086         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2087         set_gdbarch_gnu_triplet_regexp.
2088
2089 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2090
2091         * Makefile.in: Add xml-builtin.h.
2092         * features/feature_to_c.sh: Add an include for xml-builtin.h
2093         to ensure that the compiler checks that the types match.
2094         * xml-builtin.h: New file.
2095         * xml-support.c (fetch_xml_builtin): Add missing const.
2096         * xml-support.h: Remove declaration of xml_builtins.
2097
2098 2019-10-16  Tom de Vries  <tdevries@suse.de>
2099
2100         PR tdep/25096
2101         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2102         (amd64_classify_aggregate): ... here.
2103         (amd64_classify_aggregate_field): Handled fiels of nested structs
2104         recursively.
2105
2106 2019-10-16  Tom de Vries  <tdevries@suse.de>
2107
2108         PR tdep/24104
2109         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2110         that handles 'theclass'.
2111
2112 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2113
2114         * linespec.c (decode_digits_ordinary): Update comment.
2115         * make-target-delegates: No longer need to handle VEC case.
2116         * memrange.c (normalize_mem_ranges): Update comment.
2117         * namespace.c (add_using_directive): Update comment.
2118         * objc-lang.c (uniquify_strings): Update comment.
2119         * ppc-linux-nat.c (struct thread_points): Update comment.
2120         * probe.h (find_probes_in_objfile): Update comment.
2121         * target.h (enum flash_preserve_mode): Update comment.
2122         * varobj.c (varobj_restrict_range): Update comment.
2123         * varobj.h (varobj_list_children): Update comment.
2124
2125 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * Makefile.in: Remove references to vec.h and vec.c.
2128         * aarch64-tdep.c: No longer include vec.h.
2129         * ada-lang.c: Likewise.
2130         * ada-lang.h: Likewise.
2131         * arm-tdep.c: Likewise.
2132         * ax.h: Likewise.
2133         * breakpoint.h: Likewise.
2134         * charset.c: Likewise.
2135         * cp-support.h: Likewise.
2136         * dtrace-probe.c: Likewise.
2137         * dwarf2read.c: Likewise.
2138         * extension.h: Likewise.
2139         * gdb_bfd.c: Likewise.
2140         * gdbsupport/gdb_vecs.h: Likewise.
2141         * gdbsupport/vec.c: Remove.
2142         * gdbsupport/vec.h: Remove.
2143         * gdbthread.h: Likewise.
2144         * guile/scm-type.c: Likewise.
2145         * inline-frame.c: Likewise.
2146         * machoread.c: Likewise.
2147         * memattr.c: Likewise.
2148         * memrange.h: Likewise.
2149         * namespace.h: Likewise.
2150         * nat/linux-btrace.h: Likewise.
2151         * osdata.c: Likewise.
2152         * parser-defs.h: Likewise.
2153         * progspace.h: Likewise.
2154         * python/py-type.c: Likewise.
2155         * record-btrace.c: Likewise.
2156         * rust-exp.y: Likewise.
2157         * solib-target.c: Likewise.
2158         * stap-probe.c: Likewise.
2159         * target-descriptions.c: Likewise.
2160         * target-memory.c: Likewise.
2161         * target.h: Likewise.
2162         * varobj.c: Likewise.
2163         * varobj.h: Likewise.
2164         * xml-support.h: Likewise.
2165
2166 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2169         Update for new std::vector based implementation.
2170         (process_psymtab_comp_unit_reader): Likewise.
2171         (scan_partial_symbols): Likewise.
2172         (recursively_compute_inclusions): Likewise.
2173         (compute_compunit_symtab_includes): Likewise.
2174         (process_imported_unit_die): Likewise.
2175         (queue_and_load_dwo_tu): Likewise.
2176         (follow_die_sig_1): Likewise.
2177         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2178         (typedef dwarf2_per_cu_ptr): Remove.
2179         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2180         function.
2181         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2182         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2183         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2184         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2185         std::vector.
2186
2187 2019-10-15  Tom Tromey  <tromey@adacore.com>
2188
2189         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2190         TID.
2191
2192 2019-10-15  Tom Tromey  <tromey@adacore.com>
2193
2194         * windows-nat.c (windows_nat_target::fetch_registers)
2195         (windows_nat_target::store_registers): Rename "pid" to "tid".
2196
2197 2019-10-15  Tom Tromey  <tromey@adacore.com>
2198
2199         * gdbarch.h, gdbarch.c: Rebuild.
2200         * gdbarch.sh (gcc_target_options): Change return type to
2201         std::string.
2202         * compile/compile.c (get_args): Update.
2203         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2204         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2205         std::string.
2206         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2207         std::string.
2208         * arch-utils.c (default_gcc_target_options): Return std::string.
2209         * arch-utils.h (default_gcc_target_options): Return std::string.
2210         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2211
2212 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2213
2214         * breakpoint.c (breakpoint_chain): Make static.
2215         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2216         of accessing breakpoint_chain.
2217
2218 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2219
2220         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2221         to a gdb::function_view and return value to bool.
2222         * breakpoint.h (iterate_over_breakpoints): Likewise.
2223         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2224         (pop_dummy_frame): Update.
2225         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2226         (gdbscm_breakpoints): Update.
2227         * python/py-breakpoint.c (build_bp_list): Update.
2228         (gdbpy_breakpoints): Update.
2229         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2230         Update.
2231         (bpfinishpy_handle_stop): Update.
2232         (bpfinishpy_handle_exit): Update.
2233         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2234         (svr4_update_solib_event_breakpoints): Update.
2235
2236 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2237
2238         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2239         when unwrapping single-field structs.
2240
2241 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2242
2243         * dwarf2read.c: Remove includes.
2244
2245 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2246
2247         * ui-out.c (ui_out::call_do_message): Silence
2248         -Wformat-nonliteral warning.
2249
2250 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2251
2252         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2253         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2254         include: readline/tilde.h.
2255
2256 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2257
2258         * remote.c (remote_target::get_trace_status): Remove declaration of
2259         trace_regblock_size.
2260
2261 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2262
2263         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2264         (show_user): Remove declaration of cmdlist.
2265         * cli/cli-cmds.h (max_user_call_depth): Declare.
2266         * cli/cli-script.c (execute_user_command): Remove declaration
2267         of max_user_call_depth.
2268
2269 2019-10-11  Jim Wilson  <jimw@sifive.com>
2270
2271         * gdbsupport/print-utils.h (pulongest): Fix comment.
2272         (plongest): Likewise.
2273         (phex): Add missing comment, mention leading zeros.
2274         (phex_nz): Add mention of no leading zeros to comment.
2275
2276         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2277         plongest instead of unsigned long long cast.
2278
2279 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2280
2281         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2282         for external_editor_command and gdbtk_test.
2283
2284 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2287         * varobj.c (varobjdebug): Move comment to...
2288         * varobj.h (varobjdebug): ...here, and declare.
2289
2290 2019-10-09  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2293         erase_data_content.
2294
2295 2019-10-09  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2298         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2299         * tui/tui-command.c (tui_cmd_window::resize)
2300         (tui_refresh_cmd_win): Update.
2301         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2302         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2303         * tui/tui-data.c (~tui_gen_win_info): Remove.
2304         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2305         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2306         (tui_redisplay_readline, tui_mld_flush)
2307         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2308         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2309         (tui_data_window::erase_data_content)
2310         (tui_data_item_window::rerender)
2311         (tui_data_item_window::refresh_window): Update.
2312         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2313         (box_win, tui_gen_win_info::make_window)
2314         (tui_gen_win_info::make_visible): Update.
2315         (tui_delete_win): Remove.
2316         * tui/tui-winsource.c
2317         (tui_source_window_base::do_erase_source_content): Update.
2318         (tui_show_source_line, tui_source_window_base::update_tab_width)
2319         (tui_source_window_base::update_exec_info): Update.
2320         * tui/tui-data.h (struct curses_deleter): New.
2321         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2322         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2323
2324 2019-10-09  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2327
2328 2019-10-09  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2331         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2332
2333 2019-10-09  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2336         window height directly.
2337         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2338         declare.
2339         * tui/tui-layout.c (tui_default_win_height): Remove.
2340         (tui_default_win_viewport_height): Remove.
2341
2342 2019-10-09  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui.h: Remove comments.
2345
2346 2019-10-09  Tom de Vries  <tdevries@suse.de>
2347
2348         * python/lib/gdb/printer/bound_registers.py: Use
2349         '^builtin_type_bound128' as regexp argument for
2350         add_builtin_pretty_printer.
2351
2352 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2353
2354         * guile/guile.c (guile_extension_script_ops): Remove forward
2355         declaration and mark as static.
2356         (guile_script_ops): Likewise.
2357         (extension_language_guile): Move further down in the file so
2358         it can reference the definitions for guile_{extension_,}script_ops.
2359
2360 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2361
2362         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2363         except SORTL, DFLTCC, and KDSA.
2364
2365 2019-10-08  Tom Tromey  <tromey@adacore.com>
2366
2367         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2368         (struct safe_symbol_file_add_args): Remove.
2369
2370 2019-10-08  Tom Tromey  <tromey@adacore.com>
2371
2372         * windows-nat.c: Don't include buildsym-legacy.h.
2373
2374 2019-10-08  Tom Tromey  <tromey@adacore.com>
2375
2376         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2377
2378 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2379
2380         * gdbtypes.c (overload_debug): Move comment to header.
2381         * gdbtypes.h (overload_debug): Declare.
2382         * valops.c: Remove declaration of overload_debug, instead
2383         include gdbtypes.h.
2384
2385 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2388         through _().
2389         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2390         move comment...
2391         * language.h (lang_frame_mismatch_warn): ... here. Also add
2392         declaration.
2393         * top.c (lang_frame_mismatch_warn): Remove declaration.
2394         (check_frame_language_change): Pass lang_frame_mismatch_warn
2395         through _().
2396
2397 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2398
2399         * c-lang.h (vtbl_ptr_name): Declare.
2400         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2401         it from the header.
2402         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2403
2404 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2407         gdb_static_assert.
2408
2409 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2410
2411         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2412         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2413         * ctfread.c: New file.
2414         * ctfread.h: New file.
2415         * elfread.c: Include ctfread.h.
2416         (struct elfinfo text_p): New member ctfsect.
2417         (elf_locate_sections): Mark CTF section.
2418         (elf_symfile_read): Call elfctf_build_psymtabs.
2419         * Makefile.in (LIBCTF): Add.
2420         (CLIBS): Use it.
2421         (CDEPS): Likewise.
2422         (DIST): Add ctfread.c.
2423
2424 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * ctfread.c (struct nextfield): Renamed to ...
2427         (struct ctf_nextfield): ... this.
2428         (struct field_info): Renamed to ...
2429         (strut ctf_field_info): ... this.
2430         (attach_fields_to_type): Update for renamed structures.
2431         (ctf_add_member_cb): Likewise.
2432         (ctf_add_enum_member_cb): Likewise.
2433         (process_struct_members): Likewise.
2434         (process_enum_type): Likewise.
2435
2436 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2437
2438         * tracectf.h: Rename, was ctf.h.
2439         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2440         * tracefile.c: Likewise.
2441         * tracepoint.c: Remove unused include ctf.h.
2442         * mi/mi-main.c: Likewise.
2443         * Makefile.in Replace ctf.c with tracectf.c.
2444
2445 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2446
2447         * version.in: Change version number to "9.0.50.DATE-git".
2448
2449 2019-10-03  Tom Tromey  <tom@tromey.com>
2450
2451         PR rust/24976:
2452         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2453
2454 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2455
2456         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2457         cp_search_name_hash.
2458         * NEWS: Add entry about nested function support.
2459
2460 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2461             Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2464         for nested static variables when searchin VAR_DOMAIN.
2465         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2466         global scope, update comment.
2467         (add_partial_subprogram): Call add_partial_subprogram recursively
2468         for nested subroutines when processinng Fortran.
2469         (load_partial_dies): Process the child entities of a subprogram
2470         when processing Fortran.
2471         (partial_die_parent_scope): Handle building scope
2472         for Fortran nested functions.
2473         (process_die): Record that nested functions have a scope.
2474         (new_symbol): Always record Fortran subprograms on the global
2475         symbol list.
2476         (determine_prefix): How to build the prefix for Fortran
2477         subprograms.
2478
2479 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2482         have just sent the thread a SIGSTOP and are waiting for it to
2483         arrive.
2484
2485 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * btrace.c (btrace_add_pc): Remove whitespace before the template
2488         parameter in 'std::vector <...>'.
2489         (parse_xml_btrace_block): Likewise.
2490         (btrace_maint_decode_pt): Likewise.
2491         (btrace_maint_update_packets): Likewise.
2492         (btrace_maint_print_packets): Likewise.
2493         * btrace.h (struct btrace_maint_info): Likewise.
2494         * dwarf2read.c (struct type_unit_group): Likewise.
2495         (build_type_psymtabs_reader): Likewise.
2496         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2497         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2498         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2499
2500 2019-10-03  Tom de Vries  <tdevries@suse.de>
2501
2502         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2503         the first line of the help text for set/show style metadata.
2504
2505 2019-10-02  Tom Tromey  <tromey@adacore.com>
2506
2507         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2508         * gdbsupport/common-inferior.c: New file.
2509         * infcmd.c (startup_with_shell): Don't define.
2510         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2511         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2512         * inferior.h (startup_with_shell): Don't declare.
2513
2514 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2515
2516         * gdbsupport/gdb_assert.h: Include errors.h.
2517         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2518
2519 2019-10-02  Tom Tromey  <tromey@adacore.com>
2520
2521         * NEWS: Add $_ada_exception entry.
2522         * ada-lang.c (struct ada_catchpoint): Add constructor.
2523         <m_kind>: New member.
2524         (allocate_location_exception, re_set_exception): Remove
2525         "ex" parameter.
2526         (should_stop_exception): Compute $_ada_exception.
2527         (check_status_exception, print_it_exception)
2528         (print_one_exception, print_mention_exception): Remove
2529         "ex" parameter.
2530         (allocate_location_catch_exception, re_set_catch_exception)
2531         (check_status_exception, print_it_catch_exception)
2532         (print_one_catch_exception, print_mention_catch_exception)
2533         (print_recreate_catch_exception)
2534         (allocate_location_catch_exception_unhandled)
2535         (re_set_catch_exception_unhandled)
2536         (check_status_exception, print_it_catch_exception_unhandled)
2537         (print_one_catch_exception_unhandled)
2538         (print_mention_catch_exception_unhandled)
2539         (print_recreate_catch_exception_unhandled)
2540         (allocate_location_catch_assert, re_set_catch_assert)
2541         (check_status_assert, print_it_catch_assert)
2542         (print_one_catch_assert, print_mention_catch_assert)
2543         (print_recreate_catch_assert)
2544         (allocate_location_catch_handlers, re_set_catch_handlers)
2545         (check_status_handlers, print_it_catch_handlers)
2546         (print_one_catch_handlers, print_mention_catch_handlers)
2547         (print_recreate_catch_handlers): Remove.
2548         (create_ada_exception_catchpoint): Update.
2549         (initialize_ada_catchpoint_ops): Update.
2550
2551 2019-10-02  Tom Tromey  <tromey@adacore.com>
2552
2553         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2554         (create_excep_cond_exprs): Simplify exception string computation.
2555         (ada_exception_catchpoint_cond_string): Likewise.
2556
2557 2019-10-02  Tom Tromey  <tromey@adacore.com>
2558
2559         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2560         * ada-lang.c (lesseq_defined_than): Handle
2561         LOC_STATIC.
2562         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2563         parameter.
2564         (dwarf2_has_info): Likewise.
2565         (new_symbol): Set maybe_copied on symbol when
2566         appropriate.
2567         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2568         parameter.
2569         <can_copy>: New member.
2570         * elfread.c (record_minimal_symbol): Set maybe_copied
2571         on symbol when appropriate.
2572         (elf_symfile_read): Update call to dwarf2_has_info.
2573         * minsyms.c (lookup_minimal_symbol_linkage): New
2574         function.
2575         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2576         * symtab.c (get_symbol_address, get_msymbol_address):
2577         New functions.
2578         * symtab.h (get_symbol_address, get_msymbol_address):
2579         Declare.
2580         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2581         maybe_copied.
2582         (struct symbol, struct minimal_symbol) <maybe_copied>:
2583         New member.
2584
2585 2019-10-02  Tom Tromey  <tromey@adacore.com>
2586
2587         * source.c (struct current_source_location): New.
2588         (current_source_key): New global.
2589         (current_source_symtab, current_source_line)
2590         (current_source_pspace): Remove.
2591         (get_source_location): New function.
2592         (get_current_source_symtab_and_line)
2593         (set_default_source_symtab_and_line)
2594         (set_current_source_symtab_and_line)
2595         (clear_current_source_symtab_and_line, select_source_symtab)
2596         (info_source_command, print_source_lines_base)
2597         (info_line_command, search_command_helper, _initialize_source):
2598         Update.
2599
2600 2019-10-02  Tom Tromey  <tromey@adacore.com>
2601
2602         * source.c (select_source_symtab): Don't call
2603         decode_line_with_current_source.
2604
2605 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * symtab.c (lookup_global_symbol): Search global block.
2608
2609 2019-10-02  Tom Tromey  <tromey@adacore.com>
2610
2611         * coffread.c (process_coff_symbol): Update.
2612         * dwarf2read.c (var_decode_location, new_symbol): Update.
2613         * mdebugread.c (parse_symbol): Update.
2614         * objfiles.c (relocate_one_symbol): Update.
2615         * stabsread.c (define_symbol, fix_common_block)
2616         (scan_file_globals): Update.
2617         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2618         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2619         * xcoffread.c (process_xcoff_symbol): Update.
2620
2621 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2622
2623         * MAINTAINERS: Update my email address.
2624
2625 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2628         std::vector.
2629         (build_type_psymtabs_reader): Update for std::vector.
2630         (build_type_psymtab_dependencies): Likewise.
2631         * dwarf2read.h: Remove use of DEF_VEC_P.
2632         (typedef sig_type_ptr): Delete.
2633
2634 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2637         to std::vector.
2638         (btrace_maint_decode_pt): Likewise, and move allocation of the
2639         vector outside of the loop.
2640         (btrace_maint_update_packets): Update to handle change from VEC to
2641         std::vector.
2642         (btrace_maint_print_packets): Likewise.
2643         (maint_info_btrace_cmd): Likewise.
2644         * btrace.h: Remove use of DEF_VEC_O.
2645         (typedef btrace_pt_packet_s): Delete.
2646         (struct btrace_maint_info) <packets>: Change fromm VEC to
2647         std::vector.
2648         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2649
2650 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2651
2652         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2653         make accesses into the vector constant references.
2654         (btrace_add_pc): Update for std::vector.
2655         (btrace_stitch_bts): Likewise.
2656         (parse_xml_btrace_block): Likewise.
2657         (btrace_maint_update_packets): Likewise.
2658         (btrace_maint_print_packets): Likewise.
2659         (maint_info_btrace_cmd): Likewise.
2660         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2661         std::vector.
2662         (btrace_data::empty): Likewise.
2663         (btrace_data_append): Likewise.
2664         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2665         (typedef btrace_block_s): Delete.
2666         (struct btrace_block): Add constructor.
2667         (struct btrace_data_bts) <blocks>: Change to std::vector.
2668         * nat/linux-btrace.c (perf_event_read_bts): Update for
2669         std::vector.
2670         (linux_read_bts): Likewise.
2671
2672 2019-10-01  Tom Tromey  <tom@tromey.com>
2673
2674         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2675
2676 2019-10-01  Tom Tromey  <tom@tromey.com>
2677
2678         * stack.c (print_frame, info_frame_command_core): Use
2679         styled_string.
2680         * linux-thread-db.c (try_thread_db_load_1)
2681         (try_thread_db_load_from_pdir_1): Use styled_string.
2682         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2683         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2684         (maybe_print_unsupported_script_warning)
2685         (maybe_print_script_not_found_warning): Use styled_string.
2686         * ada-lang.c (user_select_syms): Use styled_string.
2687
2688 2019-10-01  Tom Tromey  <tom@tromey.com>
2689
2690         * p-lang.c (pascal_printstr): Use metadata style.
2691         * value.c (show_convenience): Use metadata style.
2692         * valprint.c (valprint_check_validity, val_print_optimized_out)
2693         (val_print_not_saved, val_print_unavailable)
2694         (val_print_invalid_address, generic_val_print, val_print)
2695         (value_check_printable, val_print_array_elements): Use metadata
2696         style.
2697         * ui-out.h (class ui_out) <field_fmt>: New overload.
2698         <do_field_fmt>: Add style parameter.
2699         * ui-out.c (ui_out::field_fmt): New overload.
2700         * typeprint.c (type_print_unknown_return_type)
2701         (val_print_not_allocated, val_print_not_associated): Use metadata
2702         style.
2703         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2704         parameter.
2705         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2706         * tracepoint.c (tvariables_info_1): Use metadata style.
2707         * stack.c (print_frame_arg, print_frame_info, print_frame)
2708         (info_frame_command_core): Use metadata style.
2709         * skip.c (info_skip_command): Use metadata style.
2710         * rust-lang.c (rust_print_enum): Use metadata style.
2711         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2712         metadata style.
2713         * python/py-framefilter.c (py_print_single_arg): Use metadata
2714         style.
2715         * printcmd.c (do_one_display, print_variable_and_value): Use
2716         metadata style.
2717         * p-valprint.c (pascal_val_print)
2718         (pascal_object_print_value_fields): Use metadata style.
2719         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2720         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2721         parameter.
2722         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2723         * m2-valprint.c (m2_print_long_set): Use metadata style.
2724         * m2-typeprint.c (m2_print_type): Use metadata style.
2725         * infcmd.c (print_return_value_1): Use metadata style.
2726         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2727         * f-valprint.c (info_common_command_for_block): Use metadata
2728         style.
2729         * f-typeprint.c (f_type_print_base): Use metadata style.
2730         * expprint.c (print_subexp_standard): Use metadata style.
2731         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2732         * cli/cli-style.h (class cli_style_option): Add constructor.
2733         (metadata_style): Declare.
2734         * cli/cli-style.c (metadata_style): New global.
2735         (_initialize_cli_style): Register metadata style.
2736         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2737         parameter.
2738         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2739         * c-typeprint.c (c_type_print_base_struct_union)
2740         (c_type_print_base_1): Use metadata style.
2741         * breakpoint.c (watchpoint_value_print)
2742         (print_one_breakpoint_location): Use metadata style.
2743         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2744         style.
2745         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2746         style.
2747         * ada-valprint.c (val_print_packed_array_elements, printstr)
2748         (print_field_values, ada_val_print_ref, ada_val_print): Use
2749         metadata style.
2750         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2751         style.
2752         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2753         style.
2754         * ada-lang.c (user_select_syms): Use metadata style.
2755
2756 2019-10-01  Tom Tromey  <tom@tromey.com>
2757
2758         * cli/cli-cmds.c (pwd_command): Style output.
2759
2760 2019-10-01  Pedro Alves  <palves@redhat.com>
2761             Tom Tromey  <tom@tromey.com>
2762
2763         * symtab.c (print_symbol_info): Use %ps.
2764         (print_msymbol_info): Use %ps.
2765         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2766         * printcmd.c (print_variable_and_value): Use %ps.
2767         * macrocmd.c (show_pp_source_pos): Use %ps.
2768         * infrun.c (print_exited_reason): Use ui_out::message.
2769         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2770         (describe_other_breakpoints): Use ui_out::message and new
2771         formats.
2772         (say_where): Use new formats.
2773         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2774         and new formats.
2775
2776 2019-10-01  Pedro Alves  <palves@redhat.com>
2777             Tom Tromey  <tom@tromey.com>
2778
2779         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2780         (test_gdb_formats): New function.
2781         (run_tests): Call it.
2782         (test_format_specifier): Update.
2783         * utils.h (fputs_filtered): Update comment.
2784         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2785         (fputs_styled_unfiltered): Declare.
2786         * utils.c (fputs_styled_unfiltered): New function.
2787         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2788         (vfprintf_filtered): Update.
2789         (vfprintf_unfiltered, vprintf_filtered): Update.
2790         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2791         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2792         disallow_ui_out_field>: New constants.
2793         (enum class field_kind): New.
2794         (struct base_field_s, struct signed_field_s): New.
2795         (signed_field): New function.
2796         (struct string_field_s): New.
2797         (string_field): New function.
2798         (struct styled_string_s): New.
2799         (styled_string): New function.
2800         (class ui_out) <message>: Add comment.
2801         <vmessage, call_do_message>: New methods.
2802         <do_message>: Add style parameter.
2803         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2804         methods.
2805         (ui_out::message): Rewrite.
2806         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2807         parameter.
2808         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2809         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2810         gdb_extensions parameter.
2811         (class format_piece): Add parameter to constructor.
2812         (n_int_args): New field.
2813         * gdbsupport/format.c (format_pieces::format_pieces): Add
2814         gdb_extensions parameter.  Handle '*'.
2815         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2816         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2817         vfprintf_styled_no_gdbfmt.
2818         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2819         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2820         unfiltered output.
2821         * ui-style.h (struct ui_file_style) <ptr>: New method.
2822
2823 2019-10-01  Tom Tromey  <tom@tromey.com>
2824
2825         * unittests/format_pieces-selftests.c: Update.  Add final format.
2826         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2827         empty literal pieces.
2828
2829 2019-10-01  Tom Tromey  <tom@tromey.com>
2830
2831         * ui-out.h (enum class ui_out_style_kind): Remove.
2832         (class ui_out) <field_string, field_stsream, do_field_string>:
2833         Change type of "style".
2834         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2835         (ui_out::field_string): Update.
2836         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2837         of "style".
2838         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2839         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2840         * stack.c (print_frame_arg, print_frame_info, print_frame):
2841         Update.
2842         * source.c (print_source_lines_base): Update.
2843         * solib.c (info_sharedlibrary_command): Update.
2844         * skip.c (info_skip_command): Update.
2845         * record-btrace.c (btrace_call_history_src_line)
2846         (btrace_call_history): Update.
2847         * python/py-framefilter.c (py_print_frame): Update.
2848         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2849         "style".
2850         * mi/mi-out.c (mi_ui_out::do_table_header)
2851         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2852         (mi_ui_out::do_field_string): Update.
2853         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2854         Update.
2855         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2856         "style".
2857         * cli-out.c (cli_ui_out::do_table_header)
2858         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2859         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2860         (cli_ui_out::do_field_fmt): Update.
2861         * breakpoint.c (print_breakpoint_location): Update.
2862         (update_static_tracepoint): Update.
2863
2864 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2867         conversion of gdb_datadir.
2868         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2869         remove not needed c_str ().
2870
2871 2019-09-30  Ali Tamur <tamur@google.com>
2872
2873         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2874         (dwarf2_string_attr): Likewise.
2875
2876 2019-09-30  Ali Tamur <tamur@google.com>
2877
2878         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2879         (process_full_type_unit): Likewise.
2880         (dump_die_shallow): Likewise.
2881         (cu_debug_loc_section): Likewise.
2882
2883 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2884
2885         * minsyms.c (compare_minimal_symbols): Rename to...
2886         (minimal_symbol_is_less_than): ...this, and adjust to STL
2887         conventions (return bool, take arguments as references)
2888         (minimal_symbol_reader::install): Call std::sort instead
2889         of qsort.
2890
2891 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2892
2893         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2894         hash and why.
2895         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2896         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2897
2898 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2899
2900         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2901         * psympriv.h (add_psymbol_to_list): Move comment here and update
2902         it.
2903
2904 2019-09-29  Tom de Vries  <tdevries@suse.de>
2905
2906         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2907         Use $tmpdir/$(basename "$output_file").dwz instead of
2908         "${output_file}.dwz".
2909
2910 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2911
2912         PR gdb/25045
2913         * hppa-linux-nat.c: Include gdbarch.h.
2914
2915 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2916
2917         * blockframe.c (find_pc_partial_function): Change return type to bool.
2918         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2919         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2920         (stub_gnu_ifunc_resolve_name): Likewise.
2921         * symtab.c (compare_filenames_for_search): Likewise.
2922         (compare_glob_filenames_for_search): Likewise.
2923         (matching_obj_sections): Likewise.
2924         (symbol_matches_domain): Likewise.
2925         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2926         (find_line_pc): Change return type to bool.
2927         (find_line_pc_range): Likewise.
2928         (producer_is_realview): Likewise.
2929         * symtab.h (symbol_matches_domain): Likewise.
2930         (find_pc_partial_function): Likewise.
2931         (find_pc_line_pc_range): Likewise.
2932         (in_gnu_ifunc_stub): Likewise.
2933         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2934         (find_line_pc): Likewise.
2935         (find_line_pc_range): Likewise.
2936         (matching_obj_sections): Likewise.
2937         (find_line_symtab): Change out parameter to bool.
2938         (producer_is_realview): Change return type to bool.
2939         (compare_filenames_for_search): Likewise.
2940         (compare_glob_filenames_for_search): Likewise.
2941
2942 2019-09-26  Tom Tromey  <tom@tromey.com>
2943
2944         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2945         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2946         * gdb_usleep.h: Remove.
2947         * gdb_usleep.c: Remove.
2948         * utils.c: Don't include gdb_usleep.h.
2949
2950 2019-09-26  Tom Tromey  <tromey@adacore.com>
2951
2952         * python/py-type.c (type_to_type_object): Call check_typedef
2953         for stub types.
2954
2955 2019-09-26  Tom Tromey  <tom@tromey.com>
2956
2957         * utils.h (initialize_utils): Don't declare.
2958         * top.c (gdb_init): Don't call initialize_utils.
2959         * utils.c (initialize_utils): Remove.  Move contents...
2960         (_initialize_utils): ... here.
2961
2962 2019-09-25  Tom Tromey  <tom@tromey.com>
2963
2964         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2965         * utils.h (make_hex_string): Don't declare.
2966         * utils.c (make_hex_string): Remove.
2967
2968 2019-09-24  Tom de Vries  <tdevries@suse.de>
2969
2970         PR gdb/23815
2971         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2972         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2973
2974 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2975
2976         * NEWS: Mention new simulator port for PRU.
2977
2978 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2979
2980         * ada-exp.y (write_object_remaining): Update.
2981         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2982         and eliminate the static buffer.
2983         (ada_decode_symbol): Update.
2984         (ada_la_decode): Update.
2985         (ada_sniff_from_mangled_name): Update.
2986         (is_valid_name_for_wild_match): Update.
2987         (ada_lookup_name_info::matches): Update and simplify.
2988         (name_matches_regex): Update.
2989         (ada_add_global_exceptions): Update.
2990         * ada-lang.h (ada_decode): Update signature.
2991         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2992         * dwarf-index-write.c (debug_names::insert): Update.
2993
2994 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2995
2996         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2997         formatting.
2998
2999 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3000
3001         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3002         Change "nonzero" to "true" in documentation.
3003
3004 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3005
3006         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3007         (_initialize_darwin_solib): Don't set
3008         darwin_so_ops.lookup_lib_global_symbol.
3009         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3010         set_gdbarch_iterate_over_objfiles_in_search_order.
3011         (elf_lookup_lib_symbol): Rename to...
3012         (svr4_iterate_over_objfiles_in_search_order): this, and update
3013         to iterate semantics.
3014         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3015         * solib.c (solib_global_lookup): Remove.
3016         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3017         (solib_global_lookup): Remove.
3018         * symtab.c (lookup_global_or_static_symbol): Remove call to
3019         solib_global_lookup.
3020
3021 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3022
3023         * NEWS: Move entries about default MI version now being
3024         version 3, and about the GDB/MI fix for multi-location
3025         breakpoints to the "since GDB 8.3" section.
3026
3027 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3028
3029         GDB 8.3.1 released.
3030
3031 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3032
3033         * NEWS: Mention that Cell/B.E. debugging support was removed.
3034         * MAINTAINERS: Remove spu target.
3035
3036         * config/djgpp/fnchange.lst: Remove entries for removed files.
3037
3038         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3039         spu-multiarch.o, and spu-tdep.o.
3040         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3041         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3042         spu-multiarch.c, and spu-tdep.c.
3043         * spu-linux-nat.c: Remove file.
3044         * spu-multiarch.c: Remove file.
3045         * spu-tdep.c: Remove file.
3046         * spu-tdep.h: Remove file.
3047         * solib-spu.c: Remove file.
3048         * solib-spu.h: Remove file.
3049
3050         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3051         * configure.nat (spu-linux): Remove.
3052         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3053         solib-multiarch.o from gdb_target_obs.
3054         (spu*-*-*): Remove.
3055
3056         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3057         feature flag.
3058         (ppc_linux_no_features): Update.
3059         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3060         Cell/B.E. support.
3061         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3062         (tdesc_powerpc_cell64l): Likewise.
3063         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3064         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3065         Cell/B.E. support.
3066         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3067         Do not include "features/rs6000/powerpc-cell32l.c" or
3068         "features/rs6000/powerpc-cell64l.c".
3069         (ppc_linux_spu_section): Remove.
3070         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3071         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3072         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3073         (ppc_linux_spe_context_lookup): Remove.
3074         (ppc_linux_spe_context_inferior_created): Remove.
3075         (ppc_linux_spe_context_solib_loaded): Remove.
3076         (ppc_linux_spe_context_solib_unloaded): Remove.
3077         (ppc_linux_spe_context): Remove.
3078         (struct ppu2spu_cache): Remove.
3079         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3080         (struct ppu2spu_data): Remove.
3081         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3082         ppu2spu_unwind): Remove.
3083         (ppc_linux_init_abi): Remove Cell/B.E. support.
3084         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3085
3086         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3087         (rs6000/powerpc-cell64l-expedite): Likewise
3088         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3089         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3090         rs6000/powerpc-cell64l.xml.
3091         * features/rs6000/powerpc-cell32l.xml: Remove.
3092         * features/rs6000/powerpc-cell64l.xml: Likewise.
3093         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3094         * features/rs6000/powerpc-cell64l.c: Likewise.
3095         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3096         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3097         * regformats/reg-spu.dat: Remove.
3098
3099         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3100         * corelow.c (struct spuid_list): Remove.
3101         (add_to_spuid_list): Remove.
3102         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3103         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3104         (remote_protocol_features): Remove associated entries.
3105         (_initialize_remote): No longer initialize them.
3106         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3107         * linux-nat.c (SPUFS_MAGIC): Remove.
3108         (linux_proc_xfer_spu): Remove.
3109         (spu_enumerate_spu_ids): Remove.
3110         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3111         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3112         (linux_make_corefile_notes): No longer call it.
3113
3114         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3115         (cooked_write_test): Likewise.
3116
3117 2019-09-20  Tom Tromey  <tom@tromey.com>
3118
3119         * NEWS: Mention case-sensitivity of TUI commands.
3120         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3121         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3122         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3123
3124 2019-09-20  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-source.c (tui_source_window::set_contents): Use
3127         make_unique_xstrdup.
3128         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3129         make_unique_xstrdup.
3130
3131 2019-09-20  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-data.c: Remove separator comments.
3134         * tui/tui-layout.c: Remove separator comments.
3135         * tui/tui-win.c: Remove separator comments.
3136         * tui/tui-wingeneral.c: Remove separator comments.
3137
3138 2019-09-20  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui.h (strcat_to_buf): Don't declare.
3141         * tui/tui.c (strcat_to_buf): Remove.
3142
3143 2019-09-20  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3146         from "fullname".
3147         * tui/tui-source.c (tui_source_window::set_contents)
3148         (tui_source_window::location_matches_p)
3149         (tui_source_window::maybe_update): Update.
3150
3151 2019-09-20  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3154         Update.
3155         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3156         prefix.
3157         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3158         (tui_data_window::line_from_reg_element_no)
3159         (tui_data_window::first_reg_element_no_inline)
3160         (tui_data_window::show_registers)
3161         (tui_data_window::show_register_group)
3162         (tui_data_window::display_registers_from)
3163         (tui_data_window::display_registers_from_line)
3164         (tui_data_window::first_data_item_displayed)
3165         (tui_data_window::delete_data_content_windows)
3166         (tui_data_window::erase_data_content)
3167         (tui_data_window::do_scroll_vertical)
3168         (tui_data_window::refresh_window)
3169         (tui_data_window::check_register_values): Update.
3170
3171 2019-09-20  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3174         (struct tui_locator_window) <full_name, proc_name>: Now
3175         std::string.
3176         * tui/tui-stack.c (tui_locator_window::make_status_line)
3177         (tui_locator_window::set_locator_fullname)
3178         (tui_locator_window::set_locator_info): Update.
3179         * tui/tui-source.c (tui_source_window::set_contents)
3180         (tui_source_window::showing_source_p): Update.
3181
3182 2019-09-20  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3185         Don't call tui_locator_win_info_ptr.
3186
3187 2019-09-20  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3190
3191 2019-09-20  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3194         height for locator.
3195         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3196         * tui/tui-layout.c (show_source_disasm_command, show_data)
3197         (show_source_or_disasm_and_command): Use 1 as height for locator.
3198
3199 2019-09-20  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui.c (tui_enable): Update.
3202         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3203         Update.
3204         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3205         Update.
3206         * tui/tui-data.c (win_resized): Now bool.
3207         (tui_win_resized): Return bool.
3208         (tui_set_win_resized_to): Accept a bool.
3209
3210 2019-09-20  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3213         Change type of "refresh_values_only".
3214         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3215         type of "refresh_values_only".
3216
3217 2019-09-20  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3220         std::string.
3221         (tui_disassemble): Add "pos" parameter.
3222         (tui_disasm_window::set_contents): Simplify.
3223
3224 2019-09-20  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-winsource.h (struct tui_source_window_base)
3227         <show_source_content>: Now private.
3228         * tui/tui-winsource.c
3229         (tui_source_window_base::show_source_content): Don't handle empty
3230         content case.
3231
3232 2019-09-20  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-layout.c (show_source_disasm_command)
3235         (show_source_or_disasm_and_command): Don't call
3236         show_source_content.
3237
3238 2019-09-20  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3241         Declare.
3242         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3243         from tui_make_status_line.
3244         (tui_locator_window::rerender): Update.
3245
3246 2019-09-20  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3249         (tui_locator_window::rerender): Update.
3250
3251 2019-09-20  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-winsource.h (struct tui_source_window_base)
3254         <~tui_source_window_base>: Don't declare.
3255         <fullname>: Remove.
3256         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3257         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3258         member.
3259         * tui/tui-source.c (tui_source_window::set_contents): Update.
3260         (tui_source_window::location_matches_p)
3261         (tui_source_window::maybe_update): Update.
3262
3263 2019-09-20  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.h (~tui_source_element): Remove.
3266         (tui_source_element): Update.
3267         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3268         * tui/tui-winsource.c (tui_show_source_line): Update.
3269         * tui/tui-source.c (tui_source_window::set_contents): Update.
3270         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3271
3272 2019-09-20  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3275         declare.
3276         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3277         tui_clear_source_windows_detail.
3278         * tui/tui-winsource.h (struct tui_source_window_base)
3279         <clear_detail>: Don't declare.
3280         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3281         Remove.
3282         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3283
3284 2019-09-20  Tom Tromey  <tromey@adacore.com>
3285
3286         PR ada/24919:
3287         * block.c (contained_in): Fix final return value.
3288
3289 2019-09-20  Alan Modra  <amodra@gmail.com>
3290
3291         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3292         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3293         (read_indirect_string_from_dwz): Use bfd accessor.
3294         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3295         * machoread.c (macho_symfile_read_all_oso): Likewise.
3296         * solib.c (solib_bfd_open): Likewise.
3297
3298 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3299
3300         * eval.c: Move declaration of overload_resolution to...
3301         * value.h: ...here.
3302
3303 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3304
3305         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3306         * arm-linux-tdep.c: Likewise.
3307         * arm-nbsd-nat.c: Likewise.
3308         * arm-tdep.h: Declare arm_apcs_32.
3309         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3310
3311 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3312
3313         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3314         * dwarf2read.h: Declare dwarf_always_disassemble.
3315
3316 2019-09-19  Tom de Vries  <tdevries@suse.de>
3317
3318         PR gdb/25009
3319         * source-cache.c (source_cache::ensure): Catch exception thrown during
3320         construction of the highlighter.
3321
3322 2019-09-18  Alan Modra  <amodra@gmail.com>
3323
3324         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3325         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3326         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3327         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3328         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3329         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3330         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3331         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3332         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3333         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3334         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3335         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3336         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3337         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3338         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3339         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3340         * mi/mi-interp.c: Update throughout for bfd section macro and
3341         function changes.
3342         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3343         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3344
3345 2019-09-18  Tom Tromey  <tom@tromey.com>
3346
3347         * NEWS: Add entry.
3348         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3349         call rl_initialize.
3350         (tui_enable): Do not call rl_initialize.
3351
3352 2019-09-18  Christian Groessler  <chris@groessler.org>
3353
3354         * alpha-linux-nat.c: Include gdbarch.h.
3355
3356 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3357
3358         * ui-file.c: Include cli/cli-style.h.
3359         (term_cli_styling): Remove cli_styling declaration.
3360
3361 2019-09-18  Alan Modra  <amodra@gmail.com>
3362
3363         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3364         to bfd_asymbol_section.
3365
3366 2019-09-18  Alan Modra  <amodra@gmail.com>
3367
3368         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3369         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3370         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3371
3372 2019-09-18  Alan Modra  <amodra@gmail.com>
3373
3374         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3375         * spu-linux-nat.c (spu_bfd_open): Likewise.
3376
3377 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3378
3379         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3380         to bool to match definition in dwarf2read.c.
3381
3382 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3383
3384         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3385         (print_signatures): Likewise.
3386         (trust_pad_over_xvs): Likewise.
3387         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3388         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3389         * arm-linux-nat.c (arm_apcs_32): Likewise.
3390         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3391         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3392         * arm-tdep.c (arm_debug): Likewise.
3393         (arm_apcs_32): Likewise.
3394         * auto-load.c (debug_auto_load): Likewise.
3395         (auto_load_gdb_scripts): Likewise.
3396         (global_auto_load): Likewise.
3397         (auto_load_local_gdbinit): Likewise.
3398         (auto_load_local_gdbinit_loaded): Likewise.
3399         * auto-load.h (global_auto_load): Likewise.
3400         (auto_load_local_gdbinit): Likewise.
3401         (auto_load_local_gdbinit_loaded): Likewise.
3402         * breakpoint.c (disconnected_dprintf): Likewise.
3403         (breakpoint_proceeded): Likewise.
3404         (automatic_hardware_breakpoints): Likewise.
3405         (always_inserted_mode): Likewise.
3406         (target_exact_watchpoints): Likewise.
3407         (_initialize_breakpoint): Update.
3408         * breakpoint.h (target_exact_watchpoints): Change to bool.
3409         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3410         * cli/cli-cmds.c (trace_commands): Likewise.
3411         * cli/cli-cmds.h (trace_commands): Likewise.
3412         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3413         to bool*.
3414         * cli/cli-logging.c (logging_overwrite): Change to bool.
3415         (logging_redirect): Likewise.
3416         (debug_redirect): Likewise.
3417         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3418         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3419         to bool.
3420         <boolean_option_def>: Update.
3421         (struct flag_option_def): Change default type of Context to bool
3422         from int.
3423         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3424         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3425         (get_setshow_command_value_string): Likewise.
3426         * cli/cli-style.c (cli_styling): Change to bool.
3427         (source_styling): Likewise.
3428         * cli/cli-style.h (source_styling): Likewise.
3429         (cli_styling): Likewise.
3430         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3431         to bool.
3432         * command.h (var_types): Update comment.
3433         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3434         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3435         bool.
3436         (debug_compile_cplus_scopes): Likewise.
3437         * compile/compile-internal.h (compile_debug): Likewise.
3438         * compile/compile.c (compile_debug): Likewise.
3439         (struct compile_options) <raw>: Likewise.
3440         * cp-support.c (catch_demangler_crashes): Likewise.
3441         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3442         (usr_cmd_cris_dwarf2_cfi): Likewise.
3443         * csky-tdep.c (csky_debug): Likewise.
3444         * darwin-nat.c (enable_mach_exceptions): Likewise.
3445         * dcache.c (dcache_enabled_p): Likewise.
3446         * defs.h (info_verbose): Likewise.
3447         * demangle.c (demangle): Likewise.
3448         (asm_demangle): Likewise.
3449         * dwarf-index-cache.c (debug_index_cache): Likewise.
3450         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3451         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3452         * dwarf2read.c (check_physname): Likewise.
3453         (use_deprecated_index_sections): Likewise.
3454         (dwarf_always_disassemble): Likewise.
3455         * eval.c (overload_resolution): Likewise.
3456         * event-top.c (set_editing_cmd_var): Likewise.
3457         (exec_done_display_p): Likewise.
3458         * event-top.h (set_editing_cmd_var): Likewise.
3459         (exec_done_display_p): Likewise.
3460         * exec.c (write_files): Likewise.
3461         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3462         (debug_fbsd_nat): Likewise.
3463         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3464         Likewise.
3465         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3466         <backtrace_past_entry> Likewise.
3467         * gdb-demangle.h (demangle): Likewise.
3468         (asm_demangle): Likewise.
3469         * gdb_bfd.c (bfd_sharing): Likewise.
3470         * gdbcore.h (write_files): Likewise.
3471         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3472         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3473         * gdbthread.h (print_thread_events): Likewise.
3474         * gdbtypes.c (opaque_type_resolution): Likewise.
3475         (strict_type_checking): Likewise.
3476         * gnu-nat.c (gnu_debug_flag): Likewise.
3477         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3478         * guile/scm-param.c (pascm_variable): Add boolval.
3479         (add_setshow_generic): Update.
3480         (pascm_param_value): Update.
3481         (pascm_set_param_value_x): Update.
3482         * hppa-tdep.c (hppa_debug): Change to bool..
3483         * infcall.c (may_call_functions_p): Likewise.
3484         (coerce_float_to_double_p): Likewise.
3485         (unwind_on_signal_p): Likewise.
3486         (unwind_on_terminating_exception_p): Likewise.
3487         * infcmd.c (startup_with_shell): Likewise.
3488         * inferior.c (print_inferior_events): Likewise.
3489         * inferior.h (startup_with_shell): Likewise.
3490         (print_inferior_events): Likewise.
3491         * infrun.c (step_stop_if_no_debug): Likewise.
3492         (detach_fork): Likewise.
3493         (debug_displaced): Likewise.
3494         (disable_randomization): Likewise.
3495         (non_stop): Likewise.
3496         (non_stop_1): Likewise.
3497         (observer_mode): Likewise.
3498         (observer_mode_1): Likewise.
3499         (set_observer_mode): Update.
3500         (sched_multi): Change to bool.
3501         * infrun.h (debug_displaced): Likewise.
3502         (sched_multi): Likewise.
3503         (step_stop_if_no_debug): Likewise.
3504         (non_stop): Likewise.
3505         (disable_randomization): Likewise.
3506         * linux-tdep.c (use_coredump_filter): Likewise.
3507         (dump_excluded_mappings): Likewise.
3508         * linux-thread-db.c (auto_load_thread_db): Likewise.
3509         (check_thread_db_on_load): Likewise.
3510         * main.c (captured_main_1): Update.
3511         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3512         xx2_opt, boolean_opt>: Change to bool.
3513         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3514         * maint.c (maintenance_profile_p): Likewise.
3515         (per_command_time): Likewise.
3516         (per_command_space): Likewise.
3517         (per_command_symtab): Likewise.
3518         * memattr.c (inaccessible_by_default): Likewise.
3519         * mi/mi-main.c (mi_async): Likewise.
3520         (mi_async_1): Likewise.
3521         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3522         * nat/fork-inferior.h (startup_with_shell): Likewise.
3523         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3524         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3525         * nios2-tdep.c (nios2_debug): Likewise.
3526         * or1k-tdep.c (or1k_debug): Likewise.
3527         * parse.c (parser_debug): Likewise.
3528         * parser-defs.h (parser_debug): Likewise.
3529         * printcmd.c (print_symbol_filename): Likewise.
3530         * proc-api.c (procfs_trace): Likewise.
3531         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3532         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3533         (set_parameter_value): Update.
3534         (add_setshow_generic): Update.
3535         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3536         to bool*.
3537         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3538         int*.
3539         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3540         * record-btrace.c (record_btrace_target::store_registers): Update.
3541         * record-full.c (record_full_memory_query): Change to bool.
3542         (record_full_stop_at_limit): Likewise.
3543         * record-full.h (record_full_memory_query): Likewise.
3544         * remote-notif.c (notif_debug): Likewise.
3545         * remote-notif.h (notif_debug): Likewise.
3546         * remote.c (use_range_stepping): Likewise.
3547         (interrupt_on_connect): Likewise.
3548         (remote_break): Likewise.
3549         * ser-tcp.c (tcp_auto_retry): Likewise.
3550         * ser-unix.c (serial_hwflow): Likewise.
3551         * skip.c (debug_skip): Likewise.
3552         * solib-aix.c (solib_aix_debug): Likewise.
3553         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3554         (spu_auto_flush_cache_p): Likewise.
3555         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3556         Likewise.
3557         (struct info_print_options) <quiet>: Likewise.
3558         * symfile-debug.c (debug_symfile): Likewise.
3559         * symfile.c (auto_solib_add): Likewise.
3560         (separate_debug_file_debug): Likewise.
3561         * symfile.h (auto_solib_add): Likewise.
3562         (separate_debug_file_debug): Likewise.
3563         * symtab.c (basenames_may_differ): Likewise.
3564         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3565         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3566         (struct info_types_options) <quiet>: Likewise.
3567         * symtab.h (demangle): Likewise.
3568         (basenames_may_differ): Likewise.
3569         * target-dcache.c (stack_cache_enabled_1): Likewise.
3570         (code_cache_enabled_1): Likewise.
3571         * target.c (trust_readonly): Likewise.
3572         (may_write_registers): Likewise.
3573         (may_write_memory): Likewise.
3574         (may_insert_breakpoints): Likewise.
3575         (may_insert_tracepoints): Likewise.
3576         (may_insert_fast_tracepoints): Likewise.
3577         (may_stop): Likewise.
3578         (auto_connect_native_target): Likewise.
3579         (target_stop_and_wait): Update.
3580         (target_async_permitted): Change to bool.
3581         (target_async_permitted_1): Likewise.
3582         (may_write_registers_1): Likewise.
3583         (may_write_memory_1): Likewise.
3584         (may_insert_breakpoints_1): Likewise.
3585         (may_insert_tracepoints_1): Likewise.
3586         (may_insert_fast_tracepoints_1): Likewise.
3587         (may_stop_1): Likewise.
3588         * target.h (target_async_permitted): Likewise.
3589         (may_write_registers): Likewise.
3590         (may_write_memory): Likewise.
3591         (may_insert_breakpoints): Likewise.
3592         (may_insert_tracepoints): Likewise.
3593         (may_insert_fast_tracepoints): Likewise.
3594         (may_stop): Likewise.
3595         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3596         (make_thread_apply_all_options_def_group): Change argument from int*
3597         to bool*.
3598         (thread_apply_all_command): Update.
3599         (print_thread_events): Change to bool.
3600         * top.c (confirm): Likewise.
3601         (command_editing_p): Likewise.
3602         (history_expansion_p): Likewise.
3603         (write_history_p): Likewise.
3604         (info_verbose): Likewise.
3605         * top.h (confirm): Likewise.
3606         (history_expansion_p): Likewise.
3607         * tracepoint.c (disconnected_tracing): Likewise.
3608         (circular_trace_buffer): Likewise.
3609         * typeprint.c (print_methods): Likewise.
3610         (print_typedefs): Likewise.
3611         * utils.c (debug_timestamp): Likewise.
3612         (sevenbit_strings): Likewise.
3613         (pagination_enabled): Likewise.
3614         * utils.h (sevenbit_strings): Likewise.
3615         (pagination_enabled): Likewise.
3616         * valops.c (overload_resolution): Likewise.
3617         * valprint.h (struct value_print_options) <prettyformat_arrays,
3618         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3619         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3620         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3621         Likewise.
3622         * windows-nat.c (new_console): Likewise.
3623         (cygwin_exceptions): Likewise.
3624         (new_group): Likewise.
3625         (debug_exec): Likewise.
3626         (debug_events): Likewise.
3627         (debug_memory): Likewise.
3628         (debug_exceptions): Likewise.
3629         (useshell): Likewise.
3630         * windows-tdep.c (maint_display_all_tib): Likewise.
3631         * xml-support.c (debug_xml): Likewise.
3632
3633 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3634
3635         * source.c (prepare_path_for_appending): New function.
3636         (openp): Make use of new function.
3637         (find_and_open_source): Search for the compilation directory and
3638         source file as a relative path beneath the directory search path.
3639
3640 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * source-cache.c (source_cache::get_line_charpos): Catch
3643         exceptions and return false, this matches the behaviour documented
3644         in the header file.
3645
3646 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3647
3648         * ada-tasks.c (info_task): Remove quoting of the task's name.
3649
3650 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3651
3652         * symfile.c (auto_solib_add): Replace comment with a reference
3653         to the header file.
3654
3655 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3656
3657         * NEWS: Mention that gdb can now be compiled with Python 3
3658         on Windows.
3659
3660 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * maint.c (maint_print_section_data::maint_print_section_data):
3663         Force use of 'float log10 (float)' by casting the argument to
3664         float.
3665
3666 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * maint.c: Add 'cmath' include.
3669         (struct maint_print_section_data): New structure.
3670         (print_section_index): New function.
3671         (print_bfd_section_info): Add header comment, small whitespace
3672         cleanup, and update to call new print_section_index function.
3673         (print_objfile_section_info): Likewise.
3674         (maint_obj_section_from_bfd_section): New function.
3675         (print_bfd_section_info_maybe_relocated): New function.
3676         (maintenance_info_sections): Add header comment, always use
3677         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3678
3679 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3682         inner scope, add check that the objfile has psymtabs before
3683         checking psymtabs_addrmap.
3684         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3685
3686 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3687
3688         * NEWS: Announce that Ada task names are now shown at more places,
3689         and between quotes (except in info task output).
3690         * gdb/ada-tasks.c (task_to_str): New function.
3691         (display_current_task_id): Call task_to_str.
3692         (task_command_1): Likewise.
3693         (print_ada_task_info): In non-mi mode, Properly align headers and data
3694         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3695
3696 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3697
3698         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3699         prstatus.pr_lwp.pr_info instead of making it up.
3700
3701 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3702
3703         * auto-load.c (auto_load_expand_dir_vars): Update.
3704         * defs.h (gdb_datadir): Change to std::string.
3705         (python_libdir): Likewise.
3706         (relocate_gdb_directory): Change return type to std::string.
3707         * guile/guile.c (gdbscm_data_directory): Update.
3708         (initialize_scheme_side): Update.
3709         * jit.c (jit_reader_dir): Change to std::string.
3710         (jit_reader_load_command): Update.
3711         * main.c (gdb_datadir): Change to std::string.
3712         (python_libdir): Likewise.
3713         (set_gdb_data_directory): Update.
3714         (relocate_path): Change to return std::string.
3715         (relocate_gdb_directory): Change to return std::string.
3716         (relocate_gdbinit_path_maybe_in_datadir): Update.
3717         (captured_main_1): Update.
3718         * python/python.c (do_start_initialization): Update.
3719         * top.c (show_gdb_datadir): Update.
3720         * xml-syscall.c (xml_init_syscalls_info): Update.
3721         (init_syscalls_info): Update.
3722
3723 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3724
3725         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3726         out of get_init_files.
3727         (get_init_files): Update.
3728
3729 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3730
3731         * main.c (get_init_files): Change to use std::string.
3732         (captured_main_1): Update.
3733         (print_gdb_help): Update.
3734
3735 2019-09-11  Ali Tamur  <tamur@google.com>
3736
3737         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3738         implementation.
3739
3740 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3741
3742         * dbxread.c (read_dbx_symtab): Update.
3743         * dwarf2read.c (load_partial_dies): Update.
3744         * mdebugread.c (parse_partial_symbols): Update.
3745         (handle_psymbol_enumerators): Update.
3746         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3747         * psymtab.c (add_psymbol_to_bcache): Likewise.
3748         (add_psymbol_to_list): Likewise.
3749         * symtab.c (symbol_set_names): Likewise.
3750         * symtab.h (symbol_set_names): Likewise.
3751         * xcoffread.c (scan_xcoff_symtab): Update.
3752
3753 2019-09-11  Tom Tromey  <tom@tromey.com>
3754
3755         * symfile-mem.c (symbol_file_add_from_memory): Use
3756         bfd_set_filename.
3757         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3758         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3759
3760 2019-09-10  Tom Tromey  <tromey@adacore.com>
3761
3762         * dwarf-index-write.c (write_psymbols): Extend error message.
3763         (debug_names::insert): Add Ada code.
3764         (debug_names::write_psymbols): Remove Ada check.
3765         (debug_names) <m_string_obstack>: New member.
3766         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3767         (gdb_index_symbol_name_matcher::matches): Remove.
3768         (mapped_index_base::find_name_components_bounds): Add "lang"
3769         parameter.
3770         (mapped_index_base::build_name_components): Also split names
3771         according to Ada syntax.
3772         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3773         type of "match_callback".
3774         (check_match, check_find_bounds_finds)
3775         (dw2_expand_symtabs_matching): Update.
3776         (dw2_debug_names_iterator): Add new constructor.
3777         (dw2_debug_names_map_matching_symbols): New function.
3778         (dw2_debug_names_expand_symtabs_matching): Update.
3779         (dwarf2_debug_names_functions): Use
3780         dw2_debug_names_map_matching_symbols.
3781
3782 2019-09-10  Tom Tromey  <tromey@adacore.com>
3783
3784         * dwarf2read.c (dw2_get_file_names_reader): Add the
3785         CU's file name to the results.
3786
3787 2019-09-10  Tom Tromey  <tromey@adacore.com>
3788
3789         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3790         map_matching_symbols.  Update.
3791         * dwarf2read.c (dw2_map_matching_symbols): Update.
3792         * psymtab.c (match_partial_symbol): Change type; update.
3793         (psym_map_matching_symbols): Likewise.
3794         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3795         type; update.
3796         * symfile.h (struct quick_symbol_functions)
3797         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3798         Remove "match".
3799
3800 2019-09-10  Tom Tromey  <tromey@adacore.com>
3801
3802         * psymtab.c (map_block): Remove.
3803         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3804         * symtab.c (iterate_over_symbols_terminated): New function.
3805         * symtab.c (iterate_over_symbols_terminated): Declare.
3806
3807 2019-09-10  Tom Tromey  <tromey@adacore.com>
3808
3809         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3810         * language.h (struct language_defn) <la_iterate_over_symbols>:
3811         Return bool.
3812         * symtab.c (iterate_over_symbols): Return bool.
3813         * symtab.h (iterate_over_symbols): Return bool.
3814
3815 2019-09-10  Tom Tromey  <tromey@adacore.com>
3816
3817         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3818         (add_nonlocal_symbols): Update.
3819         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3820         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3821         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3822         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3823         Change type of "callback".  Remove "data".
3824
3825
3826 2019-09-09  Ali Tamur  <tamur@google.com>
3827
3828         * dwarf2read.c (comp_unit_head): Update comment.
3829         (dwarf2_dwo_name): New function declaration.
3830         (dwarf_unit_type_name): New function declaration.
3831         (read_comp_unit_head): Add support for new compilation units,
3832         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3833         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3834         (currently named as "signature") in their header. Also clarify error
3835         messages.
3836         (lookup_dwo_id): New function. Returns the dwo id of the given
3837         compile unit.
3838         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3839         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3840         functions.
3841         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3842         (dwarf2_dwo_name): Get the dwo name if present.
3843         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3844         purposes.
3845
3846 2019-09-09  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3849
3850 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3851
3852         * python/python.c (do_start_initialization): Make progname_copy static,
3853         to avoid a leak report.
3854
3855 2019-09-08  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3858
3859 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3860
3861         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3862         Change type to gdb::optional<block_enum>.
3863         (dw2_symtab_iter_init): Change block_index parameter type
3864         to gdb::optional<block_enum>.
3865         (dw2_lookup_symbol): Change block_index parameter
3866         type to block_enum.c
3867         (dw2_debug_names_lookup_symbol): Likewise.
3868         * psymtab.c (psym_lookup_symbol): Likewise.
3869         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3870         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3871         Likewise.
3872
3873 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3874
3875         * defs.h (relocate_gdb_directory): Change int to bool in
3876         signature and rename flag to relocatable.
3877         * main.c (relocate_path): Likewise.
3878         (relocate_gdb_directory): Likewise.
3879
3880 2019-09-06  Alan Modra  <amodra@gmail.com>
3881
3882         * coffread.c (coff_symfile_read): Constify filename variable.
3883         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3884         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3885         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3886         * solib.c (reload_shared_libraries_1): Likewise.
3887         * symfile.c (reread_symbols): Likewise.
3888         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3889         * solib-darwin.c (darwin_bfd_open): Likewise.
3890         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3891
3892 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3895         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3896
3897 2019-09-03  Tom Tromey  <tromey@adacore.com>
3898
3899         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3900         types.
3901         (has_negatives): Unbias a range type bound.
3902         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3903         * gdbtypes.c (operator==): Handle new field.
3904         (create_range_type): Add "bias" parameter.
3905         (create_static_range_type, resolve_dynamic_range): Update.
3906         * gdbtypes.h (struct range_bounds) <bias>: New member.
3907         (create_range_type): Add bias parameter.
3908         * printcmd.c (print_scalar_formatted): Unbias range types.
3909         * value.c (unpack_long): Unbias range types.
3910         (pack_long): Bias range types.
3911
3912 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3913
3914         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3915         probe arguments.
3916
3917 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3918
3919         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3920         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3921         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3922         (compile_probe_arg): Likewise.
3923         * probe.h (get_argument_count): Likewise.
3924         * solib-svr4.c (solib_event_probe_action): Likewise.
3925         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3926
3927 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3928
3929         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3930         code to here...
3931         (svr4_create_solib_event_breakpoints): ...from here.
3932
3933 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3934
3935         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3936         suffix from warning message.
3937
3938 2019-08-30  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-winsource.h (struct tui_source_window_base)
3941         <refresh_all>: Don't declare.
3942         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3943         Remove.
3944         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3945         tui_show_locator_content.
3946         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3947         declare.
3948         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3949         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3950         declare.
3951
3952 2019-08-30  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3955
3956 2019-08-30  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3959         Remove unnecessary forward declarations.
3960
3961 2019-08-30  Tom Tromey  <tom@tromey.com>
3962
3963         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3964         rerender.
3965         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3966         tui_show_locator_content.
3967
3968 2019-08-30  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3971         (tui_locator_window::rerender): Rewrite using body of previous
3972         tui_show_locator_content.
3973
3974 2019-08-30  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3977         set_locator_fullname>: New methods.
3978         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3979         Rename from tui_set_locator_fullname.
3980         (tui_locator_window::set_locator_info): Rename from
3981         tui_set_locator_info.  Return bool.
3982         (tui_update_locator_fullname, tui_show_frame_info): Update.
3983
3984 2019-08-30  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3987
3988 2019-08-30  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3991         call touchwin.
3992
3993 2019-08-30  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-wingeneral.c (box_win): Assume win_info and
3996         win_info->handle cannot be NULL.
3997
3998 2019-08-30  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4001         refresh_window>: Declare.
4002         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4003         resize.
4004         (tui_data_item_window::rerender): Rename from
4005         tui_display_register.
4006         (tui_data_item_window::refresh_window): New method.
4007         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4008         no-op.
4009
4010 2019-08-30  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4013         regs_column_count, current_group>: Move later.  Now private.
4014         <get_current_group>: New method.
4015         * tui/tui-regs.c (tui_reg_command): Update.
4016         * tui/tui-layout.c (tui_set_layout): Update.
4017
4018 2019-08-30  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4021         (tui_data_window::rerender): Don't call
4022         check_and_display_highlight_if_needed.
4023         (tui_data_window::refresh_all): Remove call to
4024         erase_data_content.
4025
4026 2019-08-30  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4029         (tui_data_window::display_registers_from)
4030         (tui_data_window::display_reg_element_at_line)
4031         (tui_data_window::display_registers_from_line): Remove checks of
4032         "empty".
4033
4034 2019-08-30  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4037         Don't declare.
4038         * tui/tui-regs.c (tui_data_window::show_registers): Call
4039         rerender.
4040         (tui_data_window::rerender): Rename from display_all_data.
4041         (tui_data_window::rerender): Remove old implementation.
4042
4043 2019-08-30  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4046         text.
4047         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4048
4049 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4050             Sergio Durigan Junior  <sergiodj@redhat.com>
4051
4052         PR win32/24284
4053         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4054
4055 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4058         when searching for types.
4059
4060 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * f-lang.c (f_language_defn): Use f_print_typedef.
4063         * f-lang.h (f_print_typedef): Declare.
4064         * f-typeprint.c (f_print_typedef): Define.
4065
4066 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4067
4068         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4069
4070 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * cli/cli-utils.c (info_print_options_defs): Delete.
4073         (make_info_print_options_def_group): Delete.
4074         (extract_info_print_options): Delete.
4075         (info_print_command_completer): Delete.
4076         (info_print_args_help): Add extra parameter, and optionally
4077         include text about -n flag.
4078         * cli/cli-utils.h (struct info_print_options): Delete.
4079         (extract_info_print_options): Delete declaration.
4080         (info_print_command_completer): Delete declaration.
4081         (info_print_args_help): Add extra parameter, extend header
4082         comment.
4083         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4084         search_symbols.
4085         * stack.c (struct info_print_options): New type.
4086         (info_print_options_defs): New file scoped variable.
4087         (make_info_print_options_def_group): New static function.
4088         (info_print_command_completer): New static function.
4089         (info_locals_command): Update to use new local functions.
4090         (info_args_command): Likewise.
4091         (_initialize_stack): Add extra parameter to calls to
4092         info_print_args_help.
4093         * symtab.c (search_symbols): Add extra parameter, use this to
4094         possibly excluse non-debug symbols.
4095         (symtab_symbol_info): Add extra parameter, which is passed on to
4096         search_symbols.
4097         (struct info_print_options): New type.
4098         (info_print_options_defs): New file scoped variable.
4099         (make_info_print_options_def_group): New static function.
4100         (info_print_command_completer): New static function.
4101         (info_variables_command): Update to use local functions, and pass
4102         extra parameter through to symtab_symbol_info.
4103         (info_functions_command): Likewise.
4104         (info_types_command): Pass additional argument through to
4105         symtab_symbol_info.
4106         (rbreak_command): Pass extra argument to search_symbols.
4107         (_initialize_symtab): Add extra arguments for calls to
4108         info_print_args_help, and update help text for 'info variables',
4109         'whereis', and 'info functions' commands.
4110         * symtab.h (search_symbols): Add extra argument to declaration.
4111         * NEWS: Mention new flags.
4112
4113 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4114
4115         * symtab.c (lookup_static_symbol): Call the new function (and move
4116         it down to be next to lookup_global_symbol).
4117         (struct global_sym_lookup_data): Add block_enum member and rename to...
4118         (struct global_or_static_sym_lookup_data): ...this.
4119         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4120         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4121         (lookup_symbol_global_or_static_iterator_cb): ...this.
4122         (lookup_global_or_static_symbol): New function.
4123         (lookup_global_symbol): Call new function.
4124
4125 2019-08-26  Tom de Vries  <tdevries@suse.de>
4126
4127         PR c++/24852
4128         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4129         when pc_probe.prob == NULL.
4130
4131 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4132
4133         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4134         variable symbol_linkage to symbol_linkage_.
4135
4136 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4137
4138         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4139         represent whether the symbol is static, dynamic, or we don't
4140         know.
4141
4142 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4143
4144         * gdb/rx-tdep.c (rx_register_names): New.
4145         (rx_register_name): Delete.
4146         (rx_psw_type): Delete.
4147         (rx_fpsw_type): Delete.
4148         (rx_register_type): Delete.
4149         (rx_gdbarch_init): Convert target-descriptions.
4150         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4151         * gdb/features/Makefile: Add rx.xml.
4152         * gdb/features/rx.xml: New.
4153         * gdb/features/rx.c: Generated.
4154         * gdb/NEWS: Mention target description support.
4155
4156 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4157
4158         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4159         *slot_ptr.
4160
4161 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4162
4163         * configure.ac: Don't check for 'dlfcn.h' (moved to
4164         gdbsupport/common.m4).
4165         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4166         'gdbsupport/'.
4167         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4168         * compile/compile-c-support.c: Include
4169         'gdbsupport/gdb-dlfcn.h'.
4170         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4171         * gdb-dlfcn.c: Move to...
4172         * gdbsupport/gdb-dlfcn.c: ... here.
4173         * gdb-dlfcn.h: Move to...
4174         * gdbsupport/gdb-dlfcn.h: ... here.
4175
4176 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4177
4178         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4179         the offset field signed.
4180
4181 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4182
4183         * python/lib/gdb/__init__.py (_execute_file): New function.
4184         * python/python.c (python_run_simple_file): Call gdb._execute_file
4185         on Windows.
4186
4187 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4190         all uses as this was never set to anything but a zero value.
4191
4192 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4193
4194         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4195
4196 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4197
4198         * tui/tui-data.h (tui_gen_win_info): Add an =default
4199         move constructor, required by some GCC versions.
4200
4201 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4202
4203         * go32-nat.c (go32_sysinfo): Add hygon_p.
4204
4205 2019-08-20  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4208         line_from_reg_element_no, first_reg_element_no_inline,
4209         display_all_data, delete_data_content_windows,
4210         erase_data_content>: Now private.
4211
4212 2019-08-20  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4215         (tui_unhighlight_win, tui_highlight_win)
4216         (tui_win_info::make_window): Update.
4217         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4218
4219 2019-08-20  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4222         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4223         (MAX_PID_WIDTH): Move to tui-stack.c.
4224         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4225         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4226         (MAX_PID_WIDTH): Move from tui-data.h.
4227
4228 2019-08-20  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4231         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4232         (box_win): Update.
4233         (tui_gen_win_info::make_window): Rename from tui_make_window.
4234         (tui_win_info::make_window): New method.
4235         (tui_gen_win_info::make_visible): Update.
4236         * tui/tui-source.c (tui_source_window::set_contents): Update.
4237         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4238         (tui_data_window::display_registers_from): Update.
4239         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4240         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4241         Declare.
4242         <can_box>: Remove.
4243         <title>: Remove.
4244         (struct tui_win_info) <make_window>: Declare.
4245         <can_box>: Now virtual.
4246         <title>: New member.
4247         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4248         * tui/tui-command.c (tui_cmd_window::resize): Update.
4249
4250 2019-08-20  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4253         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4254         (tui_data_window::check_register_values): Update.
4255
4256 2019-08-20  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-regs.h (struct tui_data_window): Use
4259         DISABLE_COPY_AND_ASSIGN.
4260         <regs_content>: Change type, removing unique_ptr.
4261         <tui_data_window>: Add move constructor.
4262         * tui/tui-regs.c (tui_data_window::show_registers)
4263         (tui_data_window::show_register_group)
4264         (tui_data_window::display_registers_from)
4265         (tui_data_window::display_registers_from)
4266         (tui_data_window::first_data_item_displayed)
4267         (tui_data_window::delete_data_content_windows)
4268         (tui_data_window::rerender, tui_data_window::refresh_window)
4269         (tui_data_window::check_register_values): Update.
4270
4271 2019-08-20  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4274         show_register_group>: Declare.
4275         (tui_show_register_group): Don't declare.
4276         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4277         tui_show_registers.
4278         (tui_data_window::show_register_group): Rename from
4279         tui_show_register_group.
4280         (tui_data_window::check_register_values, tui_reg_command):
4281         Update.
4282         * tui/tui-layout.c (tui_set_layout): Update.
4283
4284 2019-08-20  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4287         Declare.
4288         (tui_check_register_values): Don't declare.
4289         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4290         from tui_check_register_values.
4291         * tui/tui-hooks.c (tui_register_changed): Update.
4292
4293 2019-08-20  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-regs.c (tui_reg_layout): Move later.
4296         (tui_show_registers): Don't enable TUI mode or change layout.
4297
4298 2019-08-20  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-regs.h (struct tui_data_item_window)
4301         <~tui_data_item_window>: Remove.
4302         <content>: Now a unique_xmalloc_ptr.
4303         * tui/tui-regs.c (tui_register_format): Return a
4304         unique_xmalloc_ptr.
4305         (tui_get_register): Update.
4306         (~tui_data_item_window): Remove.
4307         (tui_data_window::display_registers_from, tui_display_register):
4308         Update.
4309         * tui/tui-io.h (tui_expand_tabs): Update.
4310         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4311         Remove "col" parameter.
4312
4313 2019-08-20  Tom Tromey  <tom@tromey.com>
4314
4315         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4316         field.
4317         * tui/tui-regs.c (~tui_data_item_window): Update.
4318
4319 2019-08-20  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4322         earlier.
4323
4324 2019-08-20  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4327
4328 2019-08-20  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-source.h (struct tui_source_window): Update.
4331         * tui/tui-regs.c (tui_show_registers): Update.
4332         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4333         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4334         (NO_REGS_STRING): Remove defines.
4335
4336 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4337
4338         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4339         unnecessary thread walk if remote doesn't support the packet.
4340
4341 2019-08-19  Tom Tromey  <tromey@adacore.com>
4342
4343         * python/py-value.c (value_has_field): Fix indentation.
4344
4345 2019-08-19  Tom Tromey  <tromey@adacore.com>
4346
4347         * printcmd.c (do_one_display, info_display_command): Update.
4348         * block.h (contained_in): Return bool.  Add allow_nested
4349         parameter.
4350         * block.c (contained_in): Return bool.  Add allow_nested
4351         parameter.
4352
4353 2019-08-19  Tom Tromey  <tom@tromey.com>
4354
4355         * configure: Rebuild.
4356         * configure.ac: Disallow the combination of -static-libstdc++ and
4357         source highlight.
4358         * source-cache.c (get_language_name): Handle rust.
4359         (source_cache::get_source_lines): Ignore highlighting exceptions.
4360
4361 2019-08-16  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4364         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4365         (struct tui_source_window_base) <make_visible, refresh_window,
4366         resize>: Remove methods.
4367         <execution_info>: Remove field.
4368         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4369         (tui_show_source_line, tui_source_window_base)
4370         (~tui_source_window_base): Update.
4371         (tui_source_window_base::resize)
4372         (tui_source_window_base::make_visible)
4373         (tui_source_window_base::refresh_window): Remove.
4374         (tui_source_window_base::update_exec_info): Update.
4375         * tui/tui-source.c (tui_source_window::set_contents): Update.
4376         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4377
4378 2019-08-16  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4381         deprecated_query_hook.
4382
4383 2019-08-16  Tom Tromey  <tom@tromey.com>
4384
4385         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4386         (tui_update_source_windows_with_line): Update.
4387         * tui/tui-source.h (struct tui_source_window)
4388         <show_symtab_source>: Declare.
4389         (tui_show_symtab_source): Don't declare.
4390         * tui/tui-source.c (tui_show_symtab_source): Rename from
4391         tui_show_symtab_source.
4392
4393 2019-08-16  Tom Tromey  <tom@tromey.com>
4394
4395         * tui/tui-winsource.h (struct tui_source_window_base)
4396         <set_contents>: Declare.
4397         * tui/tui-winsource.c
4398         (tui_source_window_base::update_source_window_as_is): Update.
4399         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4400         Declare.
4401         (tui_set_source_content): Don't declare.
4402         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4403         tui_set_source_content.
4404         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4405         Declare.
4406         (tui_set_disassem_content): Don't declare.
4407         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4408         tui_set_disassem_content.
4409
4410 2019-08-16  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-winsource.h (struct tui_source_window_base)
4413         <update_breakpoint_info>: Declare.
4414         (tui_update_breakpoint_info): Don't declare.
4415         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4416         (tui_update_all_breakpoint_info): Update.
4417         (tui_source_window_base::update_breakpoint_info): Rename from
4418         tui_update_breakpoint_info.
4419         (tui_source_window_base::update_exec_info): Update.
4420
4421 2019-08-16  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-winsource.h (struct tui_source_window_base)
4424         <update_source_window>: Declare.
4425         (tui_update_source_window): Don't declare.
4426         * tui/tui-winsource.c
4427         (tui_source_window_base::update_source_window): Rename from
4428         tui_update_source_window.
4429         (tui_source_window_base::rerender): Update.
4430         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4431         * tui/tui-disasm.c (tui_show_disassem)
4432         (tui_show_disassem_and_update_source)
4433         (tui_disasm_window::maybe_update): Update.
4434
4435 2019-08-16  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-winsource.h (struct tui_source_window_base)
4438         <update_source_window_as_is>: Declare.
4439         (tui_update_source_window_as_is): Don't declare.
4440         * tui/tui-winsource.c (tui_update_source_window): Update
4441         (tui_source_window_base::update_source_window_as_is): Rename from
4442         tui_update_source_window_as_is.
4443         (tui_source_window_base::refill): Update.
4444         * tui/tui-source.c (tui_show_symtab_source): Update.
4445         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4446         Update.
4447
4448 2019-08-16  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-winsource.h (tui_update_source_window)
4451         (tui_update_source_window_as_is): Remove "noerror" parameter.
4452         * tui/tui-winsource.c (tui_update_source_window)
4453         (tui_update_source_window_as_is): Remove "noerror" parameter.
4454         (tui_update_source_windows_with_addr)
4455         (tui_update_source_windows_with_line)
4456         (tui_source_window_base::rerender)
4457         (tui_source_window_base::refill): Update.
4458         * tui/tui-source.h (tui_set_source_content)
4459         (tui_show_symtab_source): Remove "noerror" parameter.
4460         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4461         parameter.
4462         (tui_show_symtab_source): Likewise.
4463         (tui_source_window::maybe_update): Update.
4464         * tui/tui-disasm.c (tui_show_disassem)
4465         (tui_show_disassem_and_update_source)
4466         (tui_disasm_window::do_scroll_vertical)
4467         (tui_disasm_window::maybe_update): Update.
4468
4469 2019-08-16  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui.c (tui_is_window_visible): Update.
4472         * tui/tui-wingeneral.c (tui_make_window)
4473         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4474         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4475         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4476         (tui_set_win_height_command, parse_scrolling_args): Update.
4477         * tui/tui-source.c (tui_source_window::style_changed): Update.
4478         * tui/tui-regs.c (tui_show_registers)
4479         (tui_data_window::first_data_item_displayed)
4480         (tui_data_window::delete_data_content_windows)
4481         (tui_check_register_values, tui_reg_command): Update.
4482         * tui/tui-disasm.c (tui_show_disassem): Update.
4483         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4484         method.
4485         <is_visible>: Remove field.
4486         * tui/tui-data.c (tui_next_win, tui_prev_win)
4487         (tui_delete_invisible_windows): Update.
4488
4489 2019-08-16  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-winsource.h (struct tui_source_window_base)
4492         <m_has_locator>: Remove.
4493         * tui/tui-layout.c (show_source_disasm_command, show_data)
4494         (show_source_or_disasm_and_command): Update.
4495
4496 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4497
4498         * NEWS (Other MI changes): New subsection.
4499         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4500         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4501         * arch-utils.c (default_get_pc_address_flags): New function.
4502         * arch-utils.h (default_get_pc_address_flags): New declaration.
4503         * gdbarch.sh: Add get_pc_address_flags.
4504         * gdbarch.c: Regenerate.
4505         * gdbarch.h: Likewise.
4506         * stack.c (print_pc): New function.
4507         (print_frame_info) (print_frame): Call print_pc.
4508
4509 2019-08-16  Tom de Vries  <tdevries@suse.de>
4510
4511         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4512         print_objfile_section_info.
4513
4514 2019-08-15  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4517         calling update_cmdwin_start_line.
4518         * tui/tui-winsource.h (struct tui_source_window_base)
4519         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4520         <rerender>: Declare.
4521         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4522         Call rerender.
4523         (tui_source_window_base::set_new_height): Remove.
4524         (tui_source_window_base::rerender): Rename from
4525         do_make_visible_with_new_height.
4526         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4527         resize method.
4528         (tui_win_info::make_invisible_and_set_new_height)
4529         (tui_win_info::make_visible_with_new_height): Remove.
4530         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4531         Declare.
4532         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4533         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4534         do_make_visible_with_new_height>: Don't declare.
4535         <rerender>: Declare.
4536         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4537         set_new_height.
4538         (tui_data_window::do_make_visible_with_new_height): Remove.
4539         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4540         call tui_show_locator_content.
4541         (tui_gen_win_info::resize): Call rerender.
4542         (show_source_or_disasm_and_command): Don't call
4543         tui_show_locator_content.
4544         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4545         method.
4546         (struct tui_win_info) <rerender>: Declare.
4547         <set_new_height, make_invisible_and_set_new_height,
4548         make_visible_with_new_height>: Don't declare.
4549         * tui/tui-data.c (tui_win_list::rerender): New method.
4550         * tui/tui-command.h (struct tui_cmd_window)
4551         <do_make_visible_with_new_height>: Don't declare.
4552         * tui/tui-command.c
4553         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4554
4555 2019-08-15  Tom Tromey  <tromey@adacore.com>
4556
4557         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4558         * ada-lang.c (ada_enum_name): Likewise.
4559
4560 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4561
4562         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4563         leading underscore.
4564         (GdbOutputErrorFile): Likewise.
4565         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4566         accordingly.
4567         (execute_unwinders): Rename to have a leading underscore.
4568         (auto_load_packages): Likewise.
4569         (global scope): Adjust call to auto_load_packages accordingly.
4570         (GdbSetPythonDirectory): Likewise.
4571         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4572         instead of execute_unwinders.
4573
4574 2019-08-15  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4577         (show_data): Don't change window visibility.
4578         (tui_gen_win_info::resize): Remove special case for command
4579         window.  Use wresize, when available.
4580         (show_source_or_disasm_and_command): Don't change window
4581         visibility.
4582         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4583         <make_visible>: New method.
4584         * tui/tui-command.c (tui_cmd_window::resize): New method.
4585
4586 2019-08-15  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4589         (struct tui_source_windows): New.
4590         * tui/tui-winsource.c (tui_display_main): Update.
4591         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4592         (new_height_ok, parse_scrolling_args): Update.
4593         * tui/tui-layout.c (show_layout, show_data): Update.
4594         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4595         (tui_add_to_source_windows): Don't declare.
4596         * tui/tui-data.c (source_windows, tui_source_windows)
4597         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4598
4599 2019-08-15  Tom Tromey  <tom@tromey.com>
4600
4601         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4602         Rename from reset.
4603         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4604         * tui/tui-layout.c (show_source_disasm_command, show_data):
4605         Update.
4606         (tui_gen_win_info::resize): Rename.
4607         (show_source_or_disasm_and_command): Update.
4608         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4609         reset.
4610
4611 2019-08-15  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4614         * tui/tui-interp.c (tui_interp::init): Don't call
4615         tui_initialize_static_data.
4616         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4617
4618 2019-08-15  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4621         examine tui_win_list.
4622
4623 2019-08-15  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4626         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4627         tui_clear_source_content.
4628         (tui_clear_source_content): Remove.
4629         (tui_source_window_base::do_erase_source_content): Hoist call to
4630         content.clear().
4631         * tui/tui-stack.c (tui_show_frame_info): Don't call
4632         tui_clear_source_content.
4633
4634 2019-08-15  Tom Tromey  <tom@tromey.com>
4635
4636         * tui/tui-winsource.h (struct tui_source_window_base)
4637         <do_erase_source_content>: New method.
4638         <erase_source_content>: New method.
4639         (tui_erase_source_content): Don't declare.
4640         * tui/tui-winsource.c (tui_clear_source_content): Update.
4641         (tui_source_window_base::do_erase_source_content): Rename from
4642         tui_erase_source_content.
4643         (tui_source_window_base::show_source_content): Update.
4644         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4645         * tui/tui-source.h (struct tui_source_window)
4646         <erase_source_content>: New method.
4647         * tui/tui-disasm.h (struct tui_disasm_window)
4648         <erase_source_content>: New method.
4649
4650 2019-08-15  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4653         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4654         constructor.
4655         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4656         * tui/tui-source.c (tui_set_source_content): Update.
4657         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4658
4659 2019-08-15  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4662         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4663         tui-source.c.
4664         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4665         Declare.
4666         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4667         method.
4668         (tui_source_window::maybe_update): Update.
4669
4670 2019-08-15  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4673         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4674         tui-disasm.c.
4675         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4676         Declare.
4677         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4678         method.
4679         (tui_disasm_window::maybe_update): Update.
4680
4681 2019-08-15  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-winsource.h (struct tui_source_window_base)
4684         <maybe_update>: Declare.
4685         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4686         method.
4687         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4688         Declare.
4689         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4690         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4691         Declare.
4692         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4693
4694 2019-08-15  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4697
4698 2019-08-15  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-wingeneral.c: Include tui-stack.h.
4701         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4702         (struct tui_locator_window): Move from tui-data.h.
4703         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4704         (tui_initialize_static_data): Move from tui-data.c.
4705         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4706         (struct tui_locator_window): Move to tui-stack.c.
4707         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4708         (tui_initialize_static_data): Move to tui-stack.c.
4709
4710 2019-08-15  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui-layout.c (show_source_disasm_command)
4713         (show_source_or_disasm_and_command): Use make_visible method, not
4714         tui_make_window.
4715         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4716         Remove.
4717
4718 2019-08-15  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-wingeneral.h (tui_make_window): Update.
4721         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4722         parameter.
4723         (tui_gen_win_info::make_visible): Update.
4724         * tui/tui-regs.c (tui_data_window::display_registers_from):
4725         Update.
4726         * tui/tui-layout.c (show_source_disasm_command)
4727         (show_source_or_disasm_and_command): Update.
4728         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4729         (enum tui_box): Remove.
4730         (struct tui_win_info) <can_box>: New method.
4731         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4732         method.
4733
4734 2019-08-15  Tom de Vries  <tdevries@suse.de>
4735
4736         * linux-nat-trad.c: Include gdbarch.h.
4737
4738 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4739
4740         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4741         register sizes.
4742
4743 2019-08-14  Tom Tromey  <tromey@adacore.com>
4744
4745         * darwin-nat.c: Include gdbarch.h.
4746         * darwin-nat-info.c: Include gdbarch.h.
4747
4748 2019-08-13  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4751         Remove.
4752         * tui/tui-data.c (tui_initialize_static_data): Update.
4753
4754 2019-08-13  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-winsource.h (struct tui_exec_info_window)
4757         <~tui_exec_info_window, maybe_allocate_content, get_content,
4758         m_content>: Remove.
4759         (struct tui_source_window_base) <set_exec_info_content,
4760         show_exec_info_content>: Don't declare.
4761         * tui/tui-winsource.c
4762         (tui_exec_info_window::maybe_allocate_content): Remove.
4763         (tui_source_window_base::update_exec_info): Rename from
4764         set_exec_info_content.
4765         (tui_source_window_base::show_exec_info_content)
4766         (tui_source_window_base::update_exec_info): Remove.
4767
4768 2019-08-13  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4771         declare.
4772         * tui/tui-winsource.c (tui_update_source_window_as_is)
4773         (tui_update_source_windows_with_addr, tui_erase_source_content):
4774         Update.
4775         (tui_clear_exec_info_content): Remove.
4776
4777 2019-08-13  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4780         declare.
4781         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4782         call tui_erase_exec_info_content.
4783         (tui_clear_exec_info_content): Rename from
4784         tui_erase_exec_info_content.
4785         (tui_clear_exec_info_content): Delete.
4786
4787 2019-08-13  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-winsource.h (struct tui_source_window_base)
4790         <show_exec_info_content>: Declare.
4791         (tui_show_exec_info_content): Don't declare.
4792         * tui/tui-winsource.c
4793         (tui_source_window_base::show_exec_info_content): Rename from
4794         tui_show_exec_info_content.
4795         (tui_source_window_base::update_exec_info): Update.
4796
4797 2019-08-13  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4800         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4801         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4802         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4803         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4804         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4805         ... here.
4806
4807 2019-08-13  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-winsource.h (struct tui_source_window_base)
4810         <update_exec_info>: Declare.
4811         (tui_update_exec_info): Don't declare.
4812         * tui/tui-winsource.c (tui_update_source_window_as_is)
4813         (tui_source_window_base::refresh_all)
4814         (tui_update_all_breakpoint_info): Update.
4815         (tui_source_window_base::update_exec_info): Rename from
4816         tui_update_exec_info.
4817         * tui/tui-stack.c (tui_show_frame_info): Update.
4818
4819 2019-08-13  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.h (struct tui_source_window_base)
4822         <set_exec_info_content>: Declare.
4823         (tui_set_exec_info_content): Don't declare.
4824         * tui/tui-winsource.c
4825         (tui_source_window_base::set_exec_info_content): Rename from
4826         tui_set_exec_info_content.
4827         (tui_update_exec_info): Update.
4828
4829 2019-08-13  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-winsource.h (struct tui_source_window_base)
4832         <show_source_content>: Declare.
4833         (tui_show_source_content): Don't declare.
4834         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4835         (tui_source_window_base::show_source_content): Rename from
4836         tui_show_source_content.
4837         (tui_source_window_base::refresh_all): Update.
4838         * tui/tui-layout.c (show_source_disasm_command)
4839         (show_source_or_disasm_and_command): Update.
4840
4841 2019-08-13  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-winsource.c (tui_erase_source_content)
4844         (tui_show_source_content, tui_source_window_base::refresh_all):
4845         Update.
4846         * tui/tui-wingeneral.h
4847         (tui_check_and_display_highlight_if_needed): Don't declare.
4848         * tui/tui-wingeneral.c
4849         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4850         check_and_display_highlight_if_needed.
4851         * tui/tui-win.c (tui_rehighlight_all)
4852         (tui_win_info::make_visible_with_new_height): Update.
4853         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4854         (tui_data_window::erase_data_content)
4855         (tui_data_window::display_all_data): Update.
4856         * tui/tui-data.h (struct tui_win_info)
4857         <check_and_display_highlight_if_needed>: Declare.
4858
4859 2019-08-13  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui-win.c (tui_resize_all): Call
4862         tui_delete_invisible_windows.
4863         * tui/tui-layout.c (show_layout): Call
4864         tui_delete_invisible_windows.
4865         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4866         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4867
4868 2019-08-13  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4871         tui_add_win_to_layout.
4872
4873 2019-08-13  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4876         * tui/tui-layout.c (tui_default_win_height): Now static.
4877
4878 2019-08-13  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4881         single switch.
4882         (show_source_disasm_command, show_source_or_disasm_and_command):
4883         Don't check current layout.
4884
4885 2019-08-13  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-wingeneral.c (make_all_visible): Remove.
4888         (tui_make_all_invisible): Simplify.
4889         * tui/tui-layout.c (tui_make_all_invisible): Move from
4890         tui-wingeneral.c; simplify.
4891         (show_layout): Hoist call to tui_make_all_invisible.
4892         (show_data): Don't call tui_make_all_invisible.
4893
4894 2019-08-13  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4897         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4898
4899 2019-08-13  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4902         tui-data.c.
4903         (show_source_disasm_command, show_data)
4904         (show_source_or_disasm_and_command): Don't use
4905         tui_set_current_layout_to.
4906         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4907         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4908         tui-layout.c.
4909         (tui_set_current_layout_to): Remove.
4910
4911 2019-08-13  Tom Tromey  <tom@tromey.com>
4912
4913         * tui/tui-layout.c (tui_set_layout): Update.
4914         * tui/tui-data.h (struct tui_layout_def): Remove.
4915         (tui_layout_def): Don't declare.
4916         * tui/tui-data.c (layout_def): Remove.
4917         (tui_layout_def): Remove.
4918
4919 2019-08-13  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-winsource.h (struct tui_source_window_base)
4922         <clear_detail>: No longer "override".
4923         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4924         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4925         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4926         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4927         Remove.
4928         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4929
4930 2019-08-13  Tom Tromey  <tromey@adacore.com>
4931
4932         * tracepoint.c: Don't include readline.h or history.h.
4933
4934 2019-08-12  Tom Tromey  <tom@tromey.com>
4935
4936         * configure: Rebuild.
4937         * configure.ac: Check for readline 7.
4938         * NEWS: Mention readline 7 requirement.
4939         * README: Update.
4940
4941 2019-08-12  Tom Tromey  <tom@tromey.com>
4942
4943         * mingw-hdep.c (gdb_select): Remove readline hack.
4944
4945 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4946
4947         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4948         when the function fails.
4949
4950 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4951
4952         * s390-tdep.c (s390_type_align): New function.
4953         (s390_gdbarch_init): Set it as type_align gdbarch method.
4954
4955 2019-08-09  Tom de Vries  <tdevries@suse.de>
4956
4957         PR gdb/24591
4958         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4959         pc_low with relocation offset.
4960
4961 2019-08-07  Tom Tromey  <tromey@adacore.com>
4962
4963         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4964         (print_frame_args): Update.
4965         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4966         Update.
4967         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4968         * frame.h (struct frame_arg): Add initializers.
4969         <error>: Now a unique_xmalloc_ptr.
4970
4971 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4972
4973         * NEWS: Expand the Pointer Authentication entry.
4974         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4975         (aarch64_frame_unmask_lr): ... to this.
4976         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4977         Call aarch64_frame_unmask_lr.
4978         * frame.c (struct frame_info): Add "masked" variable.
4979         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4980         (fprint_frame): Check for masked pc.
4981         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4982         declarations.
4983         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4984         * stack.c (print_frame): Check for masked pc.
4985
4986 2019-08-06  Tom Tromey  <tom@tromey.com>
4987
4988         * stabsread.c (patch_block_stabs, read_one_struct_field)
4989         (read_enum_type): Use obstack_strndup.
4990         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4991         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4992         * dwarf2read.c (guess_full_die_structure_name)
4993         (anonymous_struct_prefix): Use obstack_strndup.
4994         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4995         * c-exp.y (yylex): Use obstack_strndup.
4996         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4997         (write_var_or_type): Use obstack_strndup.
4998
4999 2019-08-06  Tom Tromey  <tom@tromey.com>
5000
5001         * symfile.c (reread_symbols): Use obstack_strdup.
5002         * stabsread.c (read_type): Use obstack_strdup.
5003         * gdb_obstack.h (obstack_strdup): New overload.
5004         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5005         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5006         (dwarf2_canonicalize_name): Use obstack_strdup.
5007         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5008         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5009         Use obstack_strdup.
5010
5011 2019-08-06  Tom Tromey  <tom@tromey.com>
5012
5013         * gdb_obstack.h (obstack_strdup): Define.
5014         * gdb_obstack.c (obstack_strdup): Don't define.
5015
5016 2019-08-06  Tom Tromey  <tom@tromey.com>
5017
5018         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5019         obstack_strdup.
5020         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5021         obstack_strdup.
5022         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5023         * stabsread.c (common_block_start): Use obstack_strdup.
5024         * objfiles.c (set_objfile_main_name, objfile): Use
5025         obstack_strdup.
5026         * namespace.c (add_using_directive): Use obstack_strdup.
5027         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5028         * jit.c (finalize_symtab): Use obstack_strdup.
5029         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5030         (guess_partial_die_structure_name, partial_die_info::fixup)
5031         (dwarf2_name): Use obstack_strdup.
5032         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5033         obstack_strdup.
5034         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5035         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5036         obstack_strdup.
5037         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5038
5039 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5040
5041         * unittests/help-doc-selftests.c: New file.
5042         * Makefile.in: Add the new file.
5043
5044 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5045
5046         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5047         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5048         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5049         the trailing '.' is not output, and the first character is uppercased.
5050         (print_help_for_command): Update call to print_doc_line.
5051         (print_doc_of_command): Likewise.
5052         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5053         * cli/cli-option.c (append_indented_doc): Do not append newline.
5054         (build_help_option): Append newline after first appended_indented_doc
5055         only if a second call is done.
5056         (build_help): Append 2 new lines before each option, except the first
5057         one.
5058         * compile/compile.c (_initialize_compile): Add new lines after
5059         %OPTIONS%, when not at the end of the help.
5060         Change help doc or code
5061         producing the help doc to respect the invariants.
5062         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5063         Also removed the new line after 'Options:', as all other commands
5064         do not put an empty line between 'Options:' and the first option.
5065         * printcmd.c (_initialize_printcmd): Likewise.
5066         * stack.c (_initialize_stack): Likewise.
5067         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5068         incorrectly telling COMMAND is optional.
5069         * ada-lang.c (_initialize_ada_language): Change help doc or code
5070         producing the help doc to respect the invariants.
5071         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5072         * breakpoint.c (_initialize_breakpoint): Likewise.
5073         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5074         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5075         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5076         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5077         _initialize_cli_style): Likewise.
5078         * corelow.c (core_target_info): Likewise.
5079         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5080         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5081         * filesystem.c (_initialize_filesystem): Likewise.
5082         * frame.c (_initialize_frame): Likewise.
5083         * gnu-nat.c (add_task_commands): Likewise.
5084         * infcall.c (_initialize_infcall): Likewise.
5085         * infcmd.c (_initialize_infcmd): Likewise.
5086         * interps.c (_initialize_interpreter): Likewise.
5087         * language.c (_initialize_language): Likewise.
5088         * linux-fork.c (_initialize_linux_fork): Likewise.
5089         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5090         * maint.c (_initialize_maint_cmds): Likewise.
5091         * memattr.c (_initialize_mem): Likewise.
5092         * printcmd.c (_initialize_printcmd): Likewise.
5093         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5094         _RegEx): Likewise.
5095         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5096         * record-btrace.c (_initialize_record_btrace): Likewise.
5097         * record-full.c (_initialize_record_full): Likewise.
5098         * record.c (_initialize_record): Likewise.
5099         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5100         * regcache.c (_initialize_regcache): Likewise.
5101         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5102         _initialize_remote): Likewise.
5103         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5104         * serial.c (_initialize_serial): Likewise.
5105         * skip.c (_initialize_step_skip): Likewise.
5106         * source.c (_initialize_source): Likewise.
5107         * stack.c (_initialize_stack): Likewise.
5108         * symfile.c (_initialize_symfile): Likewise.
5109         * symtab.c (_initialize_symtab): Likewise.
5110         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5111         * top.c (init_main): Likewise.
5112         * tracefile-tfile.c (tfile_target_info): Likewise.
5113         * tracepoint.c (_initialize_tracepoint): Likewise.
5114         * tui/tui-win.c (_initialize_tui_win): Likewise.
5115         * utils.c (add_internal_problem_command): Likewise.
5116         * valprint.c (value_print_option_defs): Likewise.
5117
5118 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5119
5120         PR build/24886
5121         * configure.ac: Drop enable-libmcheck support.
5122         * configure, config.in: Rebuild.
5123         * libmcheck.m4: Remove.
5124         * acinclude.m4: Don't include it.
5125         * Makefile.in: Don't distribute it.
5126         * top.c (print_gdb_configuration): Don't mention it.
5127
5128 2019-08-06  Tom Tromey  <tom@tromey.com>
5129
5130         * utils.c (set_output_style): Sometimes pass stream to
5131         emit_style_escape.
5132         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5133         * record-btrace.c (btrace_insn_history): Update.
5134         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5135         method.
5136         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5137         Update initializers.
5138         <m_uiout>: New field.
5139         <m_di>: Move lower.
5140         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5141         Remove "uiout" parameter.
5142         (dump_insns): Update.
5143         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5144         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5145
5146 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5147
5148         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5149         (error_in_psymtab_expansion): Likewise.
5150         (lookup_symbol_via_quick_fns): Likewise.
5151         (basic_lookup_transparent_type_quick): Likewise.
5152         (basic_lookup_transparent_type_1): Likewise.
5153
5154 2019-08-06  Tom Tromey  <tromey@adacore.com>
5155
5156         * source.c (last_source_error): Now bool.
5157         (print_source_lines_base): Make "noprint" bool.  Only open
5158         source file when last_source_visited changes.
5159
5160 2019-08-06  Tom Tromey  <tromey@adacore.com>
5161
5162         * annotate.c (annotate_source_line): Use g_source_cache.
5163         * source-cache.c (source_cache::get_plain_source_lines): Change
5164         parameters.  Populate m_offset_cache.
5165         (source_cache::ensure): New method.
5166         (source_cache::get_line_charpos): New method.
5167         (extract_lines): Move lower.  Change parameters.
5168         (source_cache::get_source_lines): Move lower.
5169         * source-cache.h (class source_cache): Update comment.
5170         <get_line_charpos>: New method.
5171         <get_source_lines>: Update comment.
5172         <clear>: Clear m_offset_cache.
5173         <get_plain_source_lines>: Change parameters.
5174         <ensure>: New method
5175         <m_offset_cache>: New member.
5176         * source.c (forget_cached_source_info_for_objfile): Update.
5177         (info_source_command): Use g_source_cache.
5178         (find_source_lines, open_source_file_with_line_charpos): Remove.
5179         (print_source_lines_base, search_command_helper): Use g_source_cache.
5180         * source.h (open_source_file_with_line_charpos): Don't declare.
5181         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5182         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5183         Use g_source_cache.
5184
5185 2019-08-06  Tom Tromey  <tromey@adacore.com>
5186
5187         * source-cache.c (source_cache::get_plain_source_lines):
5188         Remove "first_line" and "last_line" parameters.
5189         (source_cache::get_source_lines): Cache plain text.
5190         * source-cache.h (class source_cache)
5191         <get_plain_source_lines>: Update.
5192
5193 2019-08-06  Tom Tromey  <tromey@adacore.com>
5194
5195         * source-cache.c (extract_lines): No longer a method.
5196         Changed type of parameter.  Include final newline.
5197         (selftests::extract_lines_test): New function.
5198         (_initialize_source_cache): Likewise.
5199         * source-cache.h (class source_cache)
5200         <extract_lines>: Don't declare.
5201
5202 2019-08-06  Tom Tromey  <tromey@adacore.com>
5203
5204         * breakpoint.c (init_breakpoint_sal): Update.
5205         (breakpoint): Update.
5206         * breakpoint.h (struct breakpoint) <filter>: Now a
5207         unique_xmalloc_ptr.
5208
5209 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5210
5211         * NEWS: Mention dictionary access on blocks.
5212         * python/py-block.c (blpy_getitem): New function.
5213         (block_object_as_mapping): New struct.
5214         (block_object_type): Use new struct for tp_as_mapping field.
5215
5216 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5217
5218         * objfiles.h (objfile): Add a comment describing partial symbols.
5219
5220 2019-08-05  Tom Tromey  <tromey@adacore.com>
5221
5222         * compile/compile.c (_initialize_compile): Use _(), not N_().
5223         * thread.c (_initialize_thread): Use _(), not N_().
5224         * stack.c (_initialize_stack): Use _(), not N_().
5225         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5226
5227 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5228
5229         * dwarf2read.c (struct dw2_symtab_iterator):
5230         <want_specific_block>: Remove.
5231         <block_index>: Change type to gdb::optional.
5232         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5233         change type of BLOCK_INDEX parameter to gdb::optional.
5234         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5235         (dw2_lookup_symbol): Don't pass argument for
5236         WANT_SPECIFIC_BLOCK.
5237         (dw2_expand_symtabs_for_function): Don't pass argument for
5238         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5239         (class dw2_debug_names_iterator)
5240         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5241         parameter, change BLOCK_INDEX type to gdb::optional.
5242         <m_want_specific_block>: Remove.
5243         <m_block_index>: Change type to gdb::optional.
5244         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5245         gdb::optional.  Re-write in function of gdb::optional.
5246         (dw2_debug_names_lookup_symbol): Don't pass argument for
5247         WANT_SPECIFIC_BLOCK.
5248         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5249         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5250         BLOCK_INDEX.
5251
5252 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5253
5254         * NEWS: Mention changes to "info sources" command.
5255
5256 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5257
5258         * symtab.c (filename_partial_match_opts): New struct type.
5259         (struct output_source_filename_data): New members
5260         regexp, c_regexp, partial_match.
5261         (output_source_filename): Use new members to decide to print file.
5262         (info_sources_option_defs): New variable.
5263         (make_info_sources_options_def_group, print_info_sources_header,
5264         info_sources_command_completer):
5265         New functions.
5266         (info_sources_command): Read new optional arguments.
5267         (_initialize_symtab): Update info sources help.
5268
5269 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5270
5271         * ada-lang.c (exception_support_info_v0): Renamed from...
5272         (default_exception_support_info): ... this.  Create new
5273         definition for v1.
5274         (ada_has_this_exception_support): Look up catch_handlers_sym.
5275         (ada_exception_support_info_sniffer): Try v0 after default.
5276
5277 2019-08-01  Tom Tromey  <tromey@adacore.com>
5278
5279         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5280         gdbarch.h.
5281
5282 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5283
5284         * s12z-tdep.c: Fix include path for s12z-opc.h.
5285
5286 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5287
5288         * NEWS: Require GNU make 3.82.
5289
5290 2019-07-16  Tom Tromey  <tom@tromey.com>
5291
5292         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5293         declare.
5294
5295 2019-07-30  Tom Tromey  <tromey@adacore.com>
5296
5297         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5298
5299 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5300
5301         * printcmd.c (print_address_symbolic): Print negative offsets.
5302         (build_address_symbolic): Force signed arithmetic when computing
5303         offset.
5304
5305 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5306
5307         PR/24474: Add a function to lookup static variables.
5308         * NEWS: Mention this new function.
5309         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5310         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5311         * python/python.c (python_GdbMethods): Add new function.
5312
5313 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5314
5315         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5316         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5317         (objfpy_lookup_static_symbol): New function.
5318         (objfile_object_methods): Add new functions.
5319
5320 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321
5322         * NEWS: Mention 'set|show print frame-info'.  Mention new
5323         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5324         backtrace argument.  Mention that python frame filtering code
5325         is now consistent with what 'backtrace' command prints.
5326
5327 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5328
5329         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5330         comments.
5331         (print_frame_info_auto, print_frame_info_source_line,
5332         print_frame_info_location, print_frame_info_source_and_location,
5333         print_frame_info_location_and_address, print_frame_info_short_location):
5334         New declarations.
5335         (struct frame_print_options): New member print_frame_info.
5336         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5337         * stack.h (get_user_print_what_frame_info): New declaration.
5338         (frame_show_address): New declaration.
5339         * stack.c (print_frame_arguments_choices): New value 'presence'.
5340         (print_frame_info_auto, print_frame_info_source_line,
5341         print_frame_info_location, print_frame_info_source_and_location,
5342         print_frame_info_location_and_address, print_frame_info_short_location,
5343         print_frame_info_choices, print_frame_info_print_what): New definitions.
5344         (print_frame_args): Only print dots for args if print frame-arguments
5345         is 'presence'.
5346         (frame_print_option_defs): New element for "frame-info".
5347         (get_user_print_what_frame_info): New function.
5348         (frame_show_address): Make non static.  Move comment to stack.h.
5349         (print_frame_info_to_print_what): New function.
5350         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5351         to decide what to print.
5352         (backtrace_command_1): Handle the new print_frame_arguments_presence
5353         value.
5354         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5355         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5356         (py_print_frame): In non-mi mode, use LOCATION as default for
5357         print_what, similarly to frame information printed directly by
5358         backtrace command. Handle frame-info user option in non MI mode.
5359
5360 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5361
5362         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5363         Add case for debugging 32-bit target on 64-bit host.  Revise
5364         comment.
5365
5366 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5367
5368         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5369         instead of find_function_entry_range_from_pc.
5370
5371 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5372
5373         * stack.c (find_frame_funname): Remove code which preferred
5374         minsym over symtab sym in "certain pathological cases".
5375
5376         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5377         parameter.  Change type of "do_demangle" to bool.
5378         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5379         Pass suitable "prefer_sym_over_minsym" flag to
5380         build_address_symbolic().  Don't output "+" for negative offsets.
5381         * printcmd.c (print_address_symbolic): Update invocation of
5382         build_address_symbolic to include a "prefer_sym_over_minsym"
5383         flag.
5384         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5385         Restrict cases in which use of minimal symbol is preferred to that
5386         of a found symbol.  Update comments.
5387
5388         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5389         for entry pc when entry pc is out of range for that FDE.
5390
5391 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5392
5393         PR gdb/24839:
5394         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5395         type.
5396
5397 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5398
5399         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5400         this function's Python signature.
5401
5402
5403 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5404
5405         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5406         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5407         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5408         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5409         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5410
5411
5412 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5413
5414         * h8300-tdep.c (h8300_register_name_common): New.
5415         h8300_register_name): Use h8300_register_name_common.
5416         (h8300s_register_name): Likewise.
5417         (h8300sx_register_name): Likewise.
5418         (h8300h_register_nam): New.
5419         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5420
5421
5422 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5423
5424         * arm-tdep.c (arm_skip_cmse_entry): New function.
5425         (arm_is_sgstubs_section): New function.
5426         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5427
5428 2019-07-22  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5431         Don't self-assign.
5432
5433 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5436         type_print.
5437
5438 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5439
5440         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5441         so that GDB doesn't match any msymbols when searching in the
5442         TYPES_DOMAIN.
5443         (print_symbol_info): Print using typedef_print or type_print based
5444         on the type of the symbol.  Add updated FIXME comment moved from...
5445         (_initialize_symtab): ... move and update FIXME comment to above.
5446
5447 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * NEWS: Mention adding -q option to "info types".
5450         * symtab.c (struct info_types_options): New struct.
5451         (info_types_options_defs): New variable.
5452         (make_info_types_options_def_group): New function.
5453         (info_types_command): Use gdb::option framework to parse options.
5454         (info_types_command_completer): New function.
5455         (_initialize_symtab): Extend the help text on "info types" and
5456         register command completer.
5457
5458 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5459
5460         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5461         (lookup_symbol_in_objfile): Change int to block_enum and add a
5462         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5463
5464 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5465
5466         * MAINTAINERS (Write After Approval): Add self.
5467
5468 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5471         instruction to the dummy code region.
5472
5473 2019-07-19  Tom Tromey  <tromey@adacore.com>
5474
5475         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5476         (ARGSUSED, PARAMS, __func__): Remove rules.
5477
5478 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5479
5480         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5481         * features/arm/arm-with-iwmmxt.c: Remove.
5482         * features/arm/arm-with-iwmmxt.xml: Remove.
5483         * features/arm/arm-with-m-fpa-layout.c: Remove.
5484         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5485         * features/arm/arm-with-m-vfp-d16.c: Remove.
5486         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5487         * features/arm/arm-with-m.c: Remove.
5488         * features/arm/arm-with-m.xml: Remove.
5489         * features/arm/arm-with-neon.c: Remove.
5490         * features/arm/arm-with-neon.xml: Remove.
5491         * features/arm/arm-with-vfpv2.c: Remove.
5492         * features/arm/arm-with-vfpv2.xml: Remove.
5493         * features/arm/arm-with-vfpv3.c: Remove.
5494         * features/arm/arm-with-vfpv3.xml: Remove.
5495
5496 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5497
5498         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5499
5500 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5501
5502         * arch/aarch32.c (aarch32_create_target_description): Create
5503         target descriptions using features.
5504         * arch/arm.c (arm_create_target_description)
5505         (arm_create_mprofile_target_description): Likewise.
5506         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5507
5508 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5509
5510         * Makefile.in: Add new files.
5511         * aarch32-tdep.c: New file.
5512         * aarch32-tdep.h: New file.
5513         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5514         Call aarch32_read_description.
5515         * arch/aarch32.c: New file.
5516         * arch/aarch32.h: New file.
5517         * arch/arm.c (arm_create_target_description)
5518         (arm_create_mprofile_target_description): New function.
5519         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5520         (arm_create_target_description)
5521         (arm_create_mprofile_target_description): New declaration.
5522         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5523         read_description functions.
5524         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5525         Likewise.
5526         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5527         * arm-tdep.c (tdesc_arm_list): New variable.
5528         (arm_register_g_packet_guesses): Call create description functions.
5529         (arm_read_description) (arm_read_mprofile_description): New
5530         function.
5531         * arm-tdep.h (arm_read_description)
5532         (arm_read_mprofile_description): Add declaration.
5533         * configure.tgt: Add new files.
5534
5535 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5536
5537         * top.c (new_ui_command): Open specified terminal just once.
5538
5539 2019-07-18  Tom Tromey  <tromey@adacore.com>
5540
5541         * symtab.c (main_name): Constify return type.
5542         * symfile.c (set_initial_language): Update.
5543         * symtab.h (main_name): Constify return type.
5544
5545 2019-07-17  Tom Tromey  <tom@tromey.com>
5546
5547         * tui/tui-winsource.c (tui_update_source_window)
5548         (tui_update_source_window_as_is)
5549         (tui_update_source_windows_with_line): Remove return.
5550         * tui/tui-disasm.c (tui_show_disassem)
5551         (tui_show_disassem_and_update_source): Remove return.
5552         * tui/tui.c (tui_reset): Remove return.
5553         * tui/tui-wingeneral.c
5554         (tui_check_and_display_highlight_if_needed): Remove return.
5555
5556 2019-07-17  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5559
5560 2019-07-17  Tom Tromey  <tom@tromey.com>
5561
5562         * tui/tui-winsource.h (struct tui_exec_info_window)
5563         (struct tui_source_window_base): Move from tui-data.h.
5564         * tui/tui-winsource.c: Move many method definitions from
5565         elsewhere.  Remove "structuring" comments.
5566         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5567         (tui_source_window_base::refresh_window): Move to
5568         tui-winsource.c.
5569         * tui/tui-win.c (tui_source_window_base::refresh_all)
5570         (tui_source_window_base::update_tab_width)
5571         (tui_source_window_base::set_new_height)
5572         (tui_source_window_base::do_make_visible_with_new_height): Move to
5573         tui-winsource.c.
5574         * tui/tui-source.h: Update.
5575         * tui/tui-source.c (tui_source_window_base::reset): Move to
5576         tui-winsource.c.
5577         * tui/tui-disasm.h: Update.
5578         * tui/tui-data.h (struct tui_exec_info_window): Move to
5579         tui-winsource.h.
5580         (struct tui_source_window_base): Likewise.
5581         * tui/tui-data.c (tui_source_window_base::clear_detail)
5582         (tui_source_window_base, ~tui_source_window_base): Move to
5583         tui-winsource.c.
5584
5585 2019-07-17  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-win.c (tui_resize_all)
5588         (tui_source_window_base::update_tab_width)
5589         (tui_adjust_win_heights): Update.
5590         (tui_win_info::make_invisible_and_set_new_height): Rename from
5591         make_invisible_and_set_new_height.
5592         * tui/tui-data.h (struct tui_win_info)
5593         <make_invisible_and_set_new_height>: New method.
5594
5595 2019-07-17  Tom Tromey  <tom@tromey.com>
5596
5597         * tui/tui.c: Update.
5598         * tui/tui-source.h (struct tui_source_window): Move from
5599         tui-data.h.
5600         * tui/tui-layout.c: Update.
5601         * tui/tui-disasm.c: Update.
5602         * tui/tui-data.h (struct tui_source_window): Move to
5603         tui-source.h.
5604
5605 2019-07-17  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5608         tui-data.h.
5609         * tui/tui-data.h (struct tui_disasm_window): Move to
5610         tui-disasm.h.
5611
5612 2019-07-17  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-regs.h (struct tui_data_item_window): Move from
5615         tui-data.h.
5616         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5617         * tui/tui-data.h (struct tui_data_item_window): Move to
5618         tui-regs.h.
5619         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5620
5621 2019-07-17  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui.c: Update.
5624         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5625         (tui_cmd_window::max_height): Move to tui-command.c.
5626         * tui/tui-layout.c: Update.
5627         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5628         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5629         tui-command.c.
5630         * tui/tui-command.h (struct tui_cmd_window): Move from
5631         tui-data.h.
5632         * tui/tui-command.c: Remove "structuring" comments.
5633         (tui_cmd_window::clear_detail)
5634         (tui_cmd_window::do_make_visible_with_new_height)
5635         (tui_cmd_window::max_height): Move from elsewhere.
5636
5637 2019-07-17  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5640         Now static.
5641         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5642         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5643
5644 2019-07-17  Tom Tromey  <tom@tromey.com>
5645
5646         * tui/tui.c: Update.
5647         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5648         tui-regs.c.
5649         * tui/tui-windata.h: Remove file.
5650         * tui/tui-windata.c: Remove file.
5651         * tui/tui-win.c (tui_data_window::set_new_height)
5652         (tui_data_window::do_make_visible_with_new_height): Move to
5653         tui-regs.c.
5654         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5655         * tui/tui-regs.c: Remove "structuring" comments.
5656         (tui_data_window::first_data_item_displayed)
5657         (tui_data_window::delete_data_content_windows)
5658         (tui_data_window::erase_data_content)
5659         (tui_data_window::display_all_data)
5660         (tui_data_window::refresh_all)
5661         (tui_data_window::do_scroll_vertical)
5662         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5663         (tui_data_window::do_make_visible_with_new_height)
5664         (tui_data_window::refresh_window): Move from elsewhere.
5665         (_initialize_tui_regs): Move to end of file.
5666         * tui/tui-layout.c: Update.
5667         * tui/tui-hooks.c: Update.
5668         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5669         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5670         tui-regs.c.
5671         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5672
5673 2019-07-17  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5676         seen.
5677
5678 2019-07-17  Tom Tromey  <tom@tromey.com>
5679
5680         * tui/tui-win.c (tui_source_window_base::set_new_height)
5681         (tui_source_window_base::do_make_visible_with_new_height): Use
5682         m_has_locator field directly.
5683         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5684         method.
5685         (struct tui_source_window_base) <has_locator>: Likewise.
5686
5687 2019-07-17  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5690         Don't declare.
5691         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5692         Remove.
5693         * tui/tui-win.c (tui_source_window_base::set_new_height)
5694         (tui_source_window_base::set_new_height)
5695         (make_invisible_and_set_new_height)
5696         (tui_source_window_base::do_make_visible_with_new_height)
5697         (tui_source_window_base::do_make_visible_with_new_height):
5698         Update.
5699         * tui/tui-layout.c (show_source_disasm_command, show_data)
5700         (show_source_or_disasm_and_command): Update.
5701         * tui/tui-layout.c (show_layout): Update.
5702
5703 2019-07-17  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-layout.c (make_data_window): Remove.
5706         (show_data): Unify creation and re-initialization cases.
5707
5708 2019-07-17  Tom Tromey  <tom@tromey.com>
5709
5710         * tui/tui-layout.c (make_source_window, make_disasm_window):
5711         Remove.
5712         (show_data): Unify creation and re-initialization cases.
5713
5714 2019-07-17  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-layout.c (make_command_window): Remove.
5717         (show_source_disasm_command, show_source_or_disasm_and_command):
5718         Unify creation and re-initialization cases.
5719
5720 2019-07-17  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5723         creation and re-initialization cases.
5724
5725 2019-07-17  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-regs.c (tui_get_register): Return void.
5728
5729 2019-07-17  Tom Tromey  <tom@tromey.com>
5730
5731         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5732         Simplify.
5733
5734 2019-07-17  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5737         resetting.
5738
5739 2019-07-17  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5742         * tui/tui-regs.c (tui_reg_layout): New function.
5743         (tui_show_registers, tui_reg_command): Use it.
5744         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5745         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5746         parameters.
5747         (tui_layout_command): Remove.
5748
5749 2019-07-17  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-layout.h (tui/tui-layout): Return void.
5752         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5753
5754 2019-07-17  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-layout.c (show_source_disasm_command, show_data):
5757         Update.
5758         (reset_locator): Remove.
5759         (show_source_or_disasm_and_command): Update.
5760
5761 2019-07-17  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-source.c (tui_source_window_base::reset): Remove
5764         win_type parameter.
5765         * tui/tui-layout.c (make_command_window, make_source_window)
5766         (make_disasm_window, make_data_window)
5767         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5768         (reset_locator, show_source_or_disasm_and_command): Update.
5769         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5770         win_type parameter.
5771         (struct tui_source_window_base) <reset>: Likewise.
5772
5773 2019-07-17  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-layout.c (show_source_disasm_command): Use
5776         reset_locator.
5777         (reset_locator): New function.
5778         (init_and_make_win): Remove.
5779         (show_source_or_disasm_and_command): Use reset_locator.
5780
5781 2019-07-17  Tom Tromey  <tom@tromey.com>
5782
5783         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5784         condition.
5785         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5786         Remove condition.
5787         * tui/tui-source.c (tui_source_window_base::reset): New method.
5788         * tui/tui-layout.c (make_command_window): Don't call
5789         init_and_make_win.
5790         (make_source_window, make_disasm_window): Don't call
5791         make_source_or_disasm_window.
5792         (make_data_window): Don't call init_and_make_win.  Change calling
5793         convention.
5794         (show_source_disasm_command, show_data): Simplify.
5795         (make_source_or_disasm_window): Remove.
5796         (show_source_or_disasm_and_command): Simplify.
5797         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5798         (struct tui_source_window_base) <reset>: Likewise.
5799         <execution_info>: Remove initializer.
5800         * tui/tui-data.c (tui_source_window_base): Initialize
5801         execution_info.
5802
5803 2019-07-17  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5806         variable.
5807
5808 2019-07-17  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui.c (tui_rl_other_window): Update.
5811         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5812         superclass method first.  Always iterate over regs_content.
5813         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5814         method.
5815         * tui/tui-win.c (tui_set_focus_command): Update.
5816
5817 2019-07-17  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-win.c (tui_set_focus_command): Rename from
5820         tui_set_focus.  Call tui_enable.
5821         (tui_set_focus_command): Remove.
5822
5823 2019-07-17  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5826         refresh_window.
5827         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5828         touchwin.
5829         (tui_data_window::refresh_window): Call refresh_window on data
5830         items.  Always call superclass refresh_window.
5831         (tui_win_info::refresh): Remove.
5832         (tui_source_window_base::refresh_window): Update.
5833         (tui_refresh_all): Update.
5834         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5835         refresh_window.
5836         (show_source_or_disasm_and_command): Likewise.
5837         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5838         (struct tui_source_window_base) <refresh>: Likewise.
5839
5840 2019-07-17  Tom Tromey  <tom@tromey.com>
5841
5842         * tui/tui-winsource.c (tui_clear_source_content)
5843         (tui_show_source_content): Update.
5844         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5845         whether content is empty.
5846         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5847         Remove.
5848
5849 2019-07-17  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5852         window's contents.
5853         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5854         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5855
5856 2019-07-17  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5859         (struct tui_data_item_window): Update.
5860
5861 2019-07-17  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5864         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5865         defines.
5866
5867 2019-07-17  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-winsource.h (tui_erase_source_content)
5870         (tui_clear_source_content): Remove "display_prompt" parameter.
5871         * tui/tui-winsource.c (tui_update_source_window_as_is)
5872         (tui_update_source_windows_with_addr): Update.
5873         (tui_clear_source_content): Remove "display_prompt" parameter.
5874         (tui_erase_source_content): Likewise.  Simplify.
5875         (tui_show_source_content): Update.
5876         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5877         * tui/tui-stack.c (tui_show_frame_info): Update.
5878         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5879         Remove defines.
5880
5881 2019-07-17  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5884         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5885         parameter.
5886         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5887         parameter.
5888
5889 2019-07-17  Tom Tromey  <tom@tromey.com>
5890
5891         * tui/tui-winsource.c (tui_clear_source_content)
5892         (tui_show_source_content, tui_show_exec_info_content)
5893         (tui_clear_exec_info_content): Update.
5894         * tui/tui-stack.c (tui_show_locator_content): Update.
5895         (tui_show_frame_info): Update.
5896         * tui/tui-source.h (tui_source_window): Don't declare.
5897         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5898         from tui_source_is_displayed.
5899         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5900         Remove field.
5901         (struct tui_source_window_base) <content_in_use>: New field.  Now
5902         bool.
5903         (struct tui_source_window) <showing_source_p>: New method.
5904         (TUI_SRC_WIN): Change cast.
5905         * tui/tui-data.c (tui_initialize_static_data): Update.
5906
5907 2019-07-17  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5910         location_matches_p.
5911         * tui/tui-source.c (tui_source_window::location_matches_p): New
5912         method.
5913         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5914         method.
5915         * tui/tui-data.h (struct tui_source_window_base)
5916         <location_matches_p>: New method.
5917         (struct tui_source_window, struct tui_disasm_window)
5918         <location_matches_p>: Likewise.
5919
5920 2019-07-17  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-win.c (tui_set_win_height_command): Rename from
5923         tui_set_win_height.
5924         (tui_set_win_height_command): Remove.
5925
5926 2019-07-17  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-source.c (tui_source_window): New constructor.  Add
5929         observer.
5930         (~tui_source_window): New destructor.
5931         (tui_source_window::style_changed): New method.
5932         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5933         (tui_attach_detach_observers): Update.
5934         * tui/tui-data.h (struct tui_source_window): Make constructor not
5935         inline.  Add destructor.
5936         (struct tui_source_window) <style_changed>: New method.
5937         <m_observable>: New member.
5938
5939 2019-07-17  Tom Tromey  <tom@tromey.com>
5940
5941         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5942         * tui/tui-win.c (tui_resize_all): Fix typo.
5943
5944 2019-07-17  Tom Tromey  <tom@tromey.com>
5945
5946         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5947         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5948         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5949         * tui/tui-win.c (window_name_completer): Use foreach.
5950         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5951         (update_tab_width): Likewise.
5952         * tui/tui-layout.c (show_layout): Update.
5953         * tui/tui-data.h (class tui_window_iterator): New.
5954         (struct all_tui_windows): New.
5955         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5956
5957 2019-07-17  Tom Tromey  <tom@tromey.com>
5958
5959         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5960         parameter.  Don't reference globals.
5961         (tui_reg_command): Update.
5962
5963 2019-07-17  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-regs.c (tui_show_registers): Simplify.
5966
5967 2019-07-17  Tom Tromey  <tom@tromey.com>
5968
5969         * tui/tui-regs.c (tui_show_registers): Update.
5970         (tui_show_register_group): Add win_info parameter.
5971
5972 2019-07-17  Tom Tromey  <tom@tromey.com>
5973
5974         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5975         Rename from tui_display_reg_element_at_line.
5976         (tui_data_window::display_registers_from_line): Update.
5977         * tui/tui-data.h (struct tui_data_window)
5978         <display_reg_element_at_line>: New method.
5979
5980 2019-07-17  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-regs.h (tui_display_registers_from)
5983         (tui_display_registers_from_line): Don't declare.
5984         * tui/tui-windata.c (tui_data_window::display_all_data)
5985         (tui_data_window::refresh_all)
5986         (tui_data_window::do_scroll_vertical): Update.
5987         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5988         from tui_display_registers_from.
5989         (tui_display_reg_element_at_line): Update.
5990         (tui_data_window::display_registers_from_line): Rename from
5991         tui_display_registers_from_line.
5992         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5993         display_registers_from_line>: New methods.
5994
5995 2019-07-17  Tom Tromey  <tom@tromey.com>
5996
5997         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5998         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5999         from tui_erase_data_content.
6000         (tui_data_window::display_all_data)
6001         (tui_data_window::refresh_all)
6002         (tui_data_window::do_scroll_vertical): Update.
6003         * tui/tui-regs.c (tui_show_registers): Update.
6004         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6005         New method.
6006
6007 2019-07-17  Tom Tromey  <tom@tromey.com>
6008
6009         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6010         declare.
6011         * tui/tui-windata.c
6012         (tui_data_window::delete_data_content_windows): Rename from
6013         tui_delete_data_content_windows.
6014         (tui_data_window::display_all_data)
6015         (tui_data_window::do_scroll_vertical): Update.
6016         * tui/tui-data.h (struct tui_data_window)
6017         <delete_data_content_windows>: New method.
6018
6019 2019-07-17  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6022         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6023
6024 2019-07-17  Tom Tromey  <tom@tromey.com>
6025
6026         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6027         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6028         from tui_display_all_data.
6029         * tui/tui-win.c
6030         (tui_data_window::do_make_visible_with_new_height): Update.
6031         * tui/tui-regs.c (tui_show_registers): Update.
6032         * tui/tui-layout.c (tui_set_layout): Update.
6033         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6034         method.
6035
6036 2019-07-17  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6039         * tui/tui-windata.c (tui_display_data_from): Remove.
6040         (tui_data_window::refresh_all): Update.
6041
6042 2019-07-17  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6045         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6046         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6047         tui_display_registers_from_line.
6048         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6049         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6050         "force_display" parameter.
6051
6052 2019-07-17  Tom Tromey  <tom@tromey.com>
6053
6054         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6055         declare.
6056         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6057         Rename from tui_first_reg_element_no_inline.
6058         (tui_display_reg_element_at_line)
6059         (tui_display_registers_from_line): Update.
6060         * tui/tui-data.h (struct tui_data_window)
6061         <first_reg_element_no_inline>: New method.
6062
6063 2019-07-17  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-windata.c (tui_display_data_from)
6066         (tui_data_window::do_scroll_vertical): Update.
6067         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6068         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6069         Rename from tui_line_from_reg_element_no.
6070         (tui_display_registers_from_line): Update.
6071         * tui/tui-data.h (struct tui_data_window)
6072         <line_from_reg_element_no>: New method.
6073
6074 2019-07-17  Tom Tromey  <tom@tromey.com>
6075
6076         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6077         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6078         tui_last_regs_line_no.
6079         (tui_display_reg_element_at_line)
6080         (tui_display_registers_from_line): Update.
6081         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6082         method.
6083
6084 2019-07-17  Tom Tromey  <tom@tromey.com>
6085
6086         PR tui/24722:
6087         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6088         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6089         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6090         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6091         (tui_update_breakpoint_info): Likewise.
6092         * tui/tui-hooks.c (tui_event_create_breakpoint)
6093         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6094         Update.
6095
6096 2019-07-17  Tom Tromey  <tom@tromey.com>
6097
6098         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6099
6100 2019-07-17  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-winsource.c (tui_update_source_window_as_is)
6103         (tui_update_source_windows_with_addr): Update.
6104         * tui/tui-source.h (tui_set_source_content)
6105         (tui_show_symtab_source): Add "win_info" parameter.
6106         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6107         parameter.
6108         (tui_show_symtab_source): Likewise.
6109
6110 2019-07-17  Tom Tromey  <tom@tromey.com>
6111
6112         * tui/tui-wingeneral.c
6113         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6114
6115 2019-07-17  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6118         (struct tui_cmd_window) <can_scroll>: New method.
6119         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6120         method.
6121
6122 2019-07-17  Tom Tromey  <tromey@adacore.com>
6123
6124         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6125         do_field_signed>: Rename.  Change type of "value".
6126         * ui-out.c (ui_out::field_signed): Rename from field_int.
6127         Change type of "value".
6128         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6129         type of "value".
6130         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6131         do_field_int.  Change type of "value".
6132         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6133         do_field_int.  Change type of "value".
6134         * tracepoint.c (trace_status_mi, tfind_1)
6135         (print_one_static_tracepoint_marker): Update.
6136         * thread.c (print_thread_info_1, print_selected_thread_frame):
6137         Update.
6138         * stack.c (print_frame, print_frame_info): Update.
6139         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6140         Update.
6141         * source.c (print_source_lines_base): Update.
6142         * skip.c (info_skip_command): Update.
6143         * record-btrace.c (btrace_ui_out_decode_error)
6144         (btrace_call_history_src_line): Update.
6145         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6146         Update.
6147         * progspace.c (print_program_space): Update.
6148         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6149         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6150         do_field_int.  Change type of "value".
6151         * mi/mi-out.c (mi_ui_out::do_table_begin)
6152         (mi_ui_out::do_table_header): Update.
6153         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6154         type of "value".
6155         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6156         (mi_cmd_data_list_changed_registers, output_register)
6157         (mi_cmd_data_read_memory, mi_load_progress)
6158         (mi_cmd_trace_frame_collected): Update.
6159         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6160         Update.
6161         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6162         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6163         (mi_cmd_var_list_children, varobj_update_one): Update.
6164         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6165         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6167         * inferior.c (print_inferior): Update.
6168         * gdb_bfd.c (print_one_bfd): Update.
6169         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6170         Update.
6171         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6172         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6173         do_field_int.  Change type of "value".
6174         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6175         do_field_int.  Change type of "value".
6176         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6177         (print_one_breakpoint_location, print_it_catch_fork)
6178         (print_one_catch_fork, print_it_catch_vfork)
6179         (print_one_catch_vfork, print_it_catch_solib)
6180         (print_it_catch_exec, print_it_ranged_breakpoint)
6181         (print_mention_watchpoint, print_mention_masked_watchpoint)
6182         (bkpt_print_it, update_static_tracepoint): Update.
6183         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6184         * break-catch-syscall.c (print_it_catch_syscall): Update.
6185         * ada-tasks.c (print_ada_task_info): Update.
6186         * ada-lang.c (print_it_exception, print_mention_exception):
6187         Update.
6188
6189 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         PR breakpoints/24541
6192         * gdbarch.c: Regenerate.
6193         * gdbarch.h: Regenerate.
6194         * gdbarch.sh: Adjust return type and parameter types for
6195         'stap_adjust_register'.
6196         (i386_stap_adjust_register): Adjust signature and return new
6197         register name.
6198         * stap-probe.c (stap_parse_register_operand): Adjust use of
6199         'gdbarch_stap_adjust_register'.
6200
6201 2019-07-17  Tom Tromey  <tromey@adacore.com>
6202
6203         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6204         declare VEC.
6205         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6206         std::vector.
6207         (struct s390_process_info): Add initializers.
6208         (s390_add_process): Use new.
6209         (s390_linux_nat_target::low_forget_process): Use delete.
6210         (s390_linux_nat_target::low_new_fork)
6211         (s390_linux_nat_target::stopped_by_watchpoint)
6212         (s390_linux_nat_target::low_prepare_to_resume)
6213         (s390_linux_nat_target::insert_watchpoint)
6214         (s390_linux_nat_target::insert_hw_breakpoint)
6215         (s390_linux_nat_target::remove_watchpoint)
6216         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6217
6218 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6219
6220         * aarch64-fbsd-nat.c: Include regcache.h.
6221         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6222         argument.
6223         (aarch64_fbsd_nat_target::fetch_registers)
6224         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6225         variable.
6226         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6227
6228 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6229
6230         * fbsd-nat.c: Include gdbarch.h.
6231
6232 2019-07-15  Tom Tromey  <tromey@adacore.com>
6233
6234         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6235
6236 2019-07-15  Tom Tromey  <tromey@adacore.com>
6237
6238         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6239         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6240         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6241         * cli-out.c (cli_ui_out::do_field_int): New method.
6242         * ui-out.c (ui_out::field_unsigned): New method.
6243         * symfile.c (generic_load): Use field_unsigned.
6244         (print_transfer_performance): Likewise.
6245         * record-btrace.c (ui_out_field_uint): Remove.
6246         (btrace_call_history_insn_range, btrace_call_history): Use
6247         field_unsigned.
6248         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6249         field_unsigned.
6250         * ui-out.h (class ui_out) <field_unsigned>: New method.
6251         <do_field_unsigned>: Likewise.
6252
6253 2019-07-15  Tom Tromey  <tromey@adacore.com>
6254
6255         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6256         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6257         * target.c (flash_erase_command): Use field_string.
6258         * infrun.c (print_signal_received_reason): Use field_string.
6259         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6260         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6261         field_string.
6262         * ada-tasks.c (print_ada_task_info): Use field_string.
6263
6264 2019-07-15  Tom Tromey  <tromey@adacore.com>
6265
6266         * target.c (flash_erase_command): Use field_core_addr.
6267         * symfile.c (generic_load): Use field_core_addr.
6268         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6269         Use field_core_addr.
6270         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6271         field_core_addr.
6272
6273 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6274
6275         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6276         value if its desired type is smaller than a CORE_ADDR and signed.
6277
6278 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6279
6280         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6281         of changes to field names, and use new is_reference field to
6282         decide if a property is a reference or not.
6283         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6284         field.
6285         (struct dwarf2_property_baton): Update header comment, rename
6286         'referenced_type' to 'property_type' and update comments.
6287         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6288         default property type, store in property baton, update to take
6289         accound of renamed field.
6290         (read_func_scope): Update call to attr_to_dynamic_prop.
6291         (read_array_type): Likewise.
6292         (dwarf2_per_cu_addr_sized_int_type): New function.
6293         (read_subrange_index_type): Move type finding code to
6294         dwarf2_per_cu_addr_sized_int_type.
6295         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6296         (dwarf2_per_cu_addr_type): New function.
6297         (set_die_type): Update calls to attr_to_dynamic_prop.
6298
6299 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * dwarf2read.c (read_subrange_index_type): New function.
6302         (read_subrange_type): Move code into new function and call it.
6303         * gdbtypes.c (create_range_type): Add some asserts.
6304
6305 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6306
6307         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6308         update return statements.
6309         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6310         declaration, and update comment to match.
6311         * gdbtypes.c (resolve_dynamic_array): Update call to
6312         dwarf2_evaluate_property to match new return type.
6313
6314 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * valarith.c (value_subscripted_rvalue): Change lowerbound
6317         parameter type from int to LONGEST.
6318         * value.h (value_subscripted_rvalue): Likewise in declaration.
6319
6320 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * cli/cli-utils.c (info_print_command_completer): New function.
6323         * cli/cli-utils.h: Add 'completer.h' include, and forward
6324         declaration for 'struct cmd_list_element'.
6325         (info_print_command_completer): Declare.
6326         * stack.c (_initialize_stack): Add completer for 'info locals' and
6327         'info args'.
6328         * symtab.c (_initialize_symtab): Add completer for 'info
6329         variables' and 'info functions'.
6330         * NEWS: Mention completion for additional info commands.
6331
6332 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * cli/cli-utils.c (extract_info_print_args): Delete.
6335         (extract_arg_maybe_quoted): Delete.
6336         (info_print_options_defs): New variable.
6337         (make_info_print_options_def_group): New function.
6338         (extract_info_print_options): Define new function.
6339         * cli/cli-utils.h (extract_info_print_args): Delete.
6340         (struct info_print_options): New structure.
6341         (extract_info_print_options): Declare new function.
6342         * stack.c (info_locals_command): Update to use new
6343         extract_info_print_options, also add a header comment.
6344         (info_args_command): Likewise.
6345         * symtab.c (info_variables_command): Likewise.
6346         (info_functions_command): Likewise.
6347
6348 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6351         to extract string arguments.
6352         * common/common-utils.c (extract_string_maybe_quoted): New function.
6353         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6354
6355 2019-07-11  Tom Tromey  <tromey@adacore.com>
6356
6357         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6358         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6359         * top.h (gdbinit): Don't declare.
6360         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6361         into...
6362         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6363         * top.c (gdb_init): Don't call init_cli_cmds.
6364         (gdbinit): Remove.
6365         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6366
6367 2019-07-11  Tom Tromey  <tromey@adacore.com>
6368
6369         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6370         after it has been moved.
6371
6372 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6373
6374         * valops.c (value_must_coerce_to_target): Change return type to
6375         bool.
6376         * value.h (value_must_coerce_to_target): Likewise.
6377
6378 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6379
6380         * breakpoint.c (is_hardware_watchpoint): Remove
6381         forward-declaration.
6382         (is_masked_watchpoint): Change return type to bool.
6383         (is_tracepoint): Likewise.
6384         (is_breakpoint): Likewise.
6385         (is_hardware_watchpoint): Likewise.
6386         (is_watchpoint): Likewise.
6387         (is_no_memory_software_watchpoint): Likewise.
6388         (is_catchpoint): Likewise.
6389         (breakpoint_1): Make FILTER parameter's return type bool.
6390         is_masked_watchpoint): Change return type to bool.
6391         (save_breakpoints): Make FILTER parameter's return type bool.
6392         * breakpoint.h (is_breakpoint): Change return type to bool.
6393         (is_watchpoint): Likewise.
6394         (is_catchpoint): Likewise.
6395         (is_tracepoint): Likewise.
6396
6397 2019-07-10  Tom Tromey  <tom@tromey.com>
6398
6399         * defs.h: Don't include gdbarch.h.
6400         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6401         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6402         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6403         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6404         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6405         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6406         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6407         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6408         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6409         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6410         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6411         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6412         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6413         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6414         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6415         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6416         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6417         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6418         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6419         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6420         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6421         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6422         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6423         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6424         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6425         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6426         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6427
6428 2019-07-10  Tom Tromey  <tromey@adacore.com>
6429
6430         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6431         * breakpoint.c (init_ada_exception_breakpoint): Register as
6432         bp_catchpoint.
6433         (print_one_breakpoint_location, print_one_breakpoint): Use
6434         is_ada_exception_catchpoint.
6435         * ada-lang.c (class ada_catchpoint_location): Pass
6436         bp_loc_software_breakpoint to bp_location constructor.
6437         (is_ada_exception_catchpoint): New function.
6438
6439 2019-07-10  Tom Tromey  <tromey@adacore.com>
6440
6441         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6442         VEC.
6443         (struct arm_exidx_entry): New method operator<.
6444         (struct arm_exidx_data) <section_maps>: Change type.
6445         (arm_exidx_data_free): Remove.
6446         (arm_exidx_data_key): Change type.  Move lower.
6447         (arm_exidx_new_objfile): Update.
6448         (arm_compare_exidx_entries): Remove.
6449         (arm_find_exidx_entry, _initialize_arm_tdep)
6450
6451 2019-07-10  Tom Tromey  <tromey@adacore.com>
6452
6453         * solib-spu.c (ocl_program_data_key): Change type.
6454         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6455         Update.
6456
6457 2019-07-10  Tom Tromey  <tromey@adacore.com>
6458
6459         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6460         (struct solib_aix_inferior_data) <library_list>: Change type.
6461         (solib_aix_inferior_data_handle): Change type.
6462         (get_solib_aix_inferior_data): Update.
6463         (solib_aix_free_library_list): Remove.
6464         (library_list_start_library): Update.
6465         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6466         return type.
6467         (solib_aix_get_library_list)
6468         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6469         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6470
6471 2019-07-10  Tom Tromey  <tromey@adacore.com>
6472
6473         * solib-dsbt.c (struct dsbt_info): Add initializers.
6474         (solib_dsbt_pspace_data): Change type.
6475         (dsbt_pspace_data_cleanup): Remove.
6476         (get_dsbt_info, _initialize_dsbt_solib): Update.
6477
6478 2019-07-10  Tom Tromey  <tromey@adacore.com>
6479
6480         * spu-tdep.c (spu_overlay_data): Change type.
6481         (spu_get_overlay_table, spu_overlay_new_objfile)
6482         (_initialize_spu_tdep): Update.
6483
6484 2019-07-10  Tom Tromey  <tromey@adacore.com>
6485
6486         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6487         destructor.
6488         (dbx_objfile_data_key): Change type and declare later.
6489         (DBX_SYMFILE_INFO): Rewrite.
6490         * dbxread.c (dbx_objfile_data_key): Change type.
6491         (dbx_symfile_init): Update.
6492         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6493         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6494         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6495
6496 2019-07-10  Tom Tromey  <tromey@adacore.com>
6497
6498         * jit.c (jit_program_space_key): Change type.  Move lower.
6499         (get_jit_program_space_data): Update.
6500         (jit_program_space_data_cleanup): Remove.
6501         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6502         Update.
6503         (struct jit_program_space_data): Add initializers.
6504
6505 2019-07-10  Tom Tromey  <tromey@adacore.com>
6506
6507         * solib-darwin.c (struct darwin_info): Add initializers.
6508         (solib_darwin_pspace_data): Change type.
6509         (darwin_pspace_data_cleanup): Remove.
6510         (get_darwin_info, _initialize_darwin_solib): Update.
6511
6512 2019-07-10  Tom Tromey  <tromey@adacore.com>
6513
6514         * remote-sim.c (struct sim_inferior_data): Add initializers,
6515         constructor, and destructor.
6516         (sim_inferior_data_key): Change type.  Move lower.
6517         (check_for_duplicate_sim_descriptor): Update.
6518         (get_sim_inferior_data): Use new.  Update.
6519         (~sim_inferior_data_cleanup): Rename from
6520         sim_inferior_data_cleanup.  Simplify.
6521         (gdbsim_close_inferior, simulator_command)
6522         (sim_command_completer, _initialize_remote_sim): Update.
6523         (next_pid, INITIAL_PID): Move earlier.
6524
6525 2019-07-10  Tom Tromey  <tromey@adacore.com>
6526
6527         * python/python-internal.h (create_thread_object): Return
6528         gdbpy_ref.
6529         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6530         * python/py-inferior.c (struct threadlist_entry): Add
6531         constructor.
6532         <thread_obj>: Now a gdbpy_ref.
6533         (thread_to_thread_object): Update.
6534         (add_thread_object): Use new.
6535         (delete_thread_object): Use delete.
6536         (infpy_threads): Update.
6537         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6538         GIL.
6539
6540 2019-07-10  Tom Tromey  <tromey@adacore.com>
6541
6542         * valops.c (value_cast): Specialize error message for Ada.
6543
6544 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6545
6546         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6547
6548 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6549
6550         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6551         bpstat_should_step): Return bool, adjust comments.
6552         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6553         bpstat_should_step): Likewise.
6554
6555 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6556
6557         * features/Makefile: Use feature target descriptions for Arm.
6558         * features/arm/arm-core.c: Generate new file.
6559         * features/arm/arm-fpa.c: Likewise.
6560         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6561         * features/arm/arm-m-profile.c: Likewise.
6562         * features/arm/arm-vfpv2.c: Likewise.
6563         * features/arm/arm-vfpv3.c: Likewise.
6564         * features/arm/xscale-iwmmxt.c: Likewise.
6565         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6566
6567 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6568
6569         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6570         ptrace earlier.
6571
6572 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * features/aarch64-pauth.c: Regenerate.
6575
6576 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6577
6578         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6579         bool.
6580         (bpstat_what): Use false instead of 0.
6581
6582 2019-07-09  Pedro Alves  <palves@redhat.com>
6583
6584         * break-catch-throw.c (is_exception_catchpoint): New.
6585         * breakpoint.c (print_one_breakpoint_location): New parameter
6586         'raw_loc'.  Handle it.  Use
6587         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6588         looking at the breakpoint's type.
6589         (print_one_breakpoint): If handling "maint info breakpoints", also
6590         print locations of exception catchpoints.
6591         * breakpoint.h (is_exception_catchpoint): Declare.
6592
6593 2019-07-09  Pedro Alves  <palves@redhat.com>
6594
6595         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6596         "addr" field.
6597         (allocate_location_exception_catchpoint): New.
6598         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6599         (initialize_throw_catchpoint_ops): Install
6600         allocate_location_exception_catchpoint as allocate_location
6601         method.
6602         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6603         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6604         bp_loc_other.
6605         (breakpoint_address_is_meaningful): Delete.
6606         (bl_address_is_meaningful): New.
6607         (breakpoint_locations_match): Adjust comment.
6608         (bp_location_from_bp_type): New, factored out of...
6609         (bp_location::bp_location(breakpoint *)): ... this.
6610         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6611         factored out of...
6612         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6613         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6614         breakpoint_address_is_meaningful.
6615         (bp_locations_compare): Adjust comment.
6616         (update_global_location_list): Use bl_address_is_meaningful
6617         instead of breakpoint_address_is_meaningful.
6618         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6619         explicit.
6620         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6621         * python/py-breakpoint.c (bppy_get_location): No longer check
6622         whether location is null.
6623
6624 2019-07-09  Pedro Alves  <palves@redhat.com>
6625
6626         PR c++/15468
6627         * breakpoint.c (print_one_breakpoint_location): Remove
6628         single-location assert.
6629
6630 2019-07-09  Tom Tromey  <tom@tromey.com>
6631
6632         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6633         * configure: Rebuild.
6634         * configure.ac: Change common to gdbsupport.
6635         * gdbsupport: Rename from common.
6636         * acinclude.m4: Change common to gdbsupport.
6637         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6638         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6639         gdbsupport.
6640         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6641         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6642         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6643         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6644         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6645         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6646         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6647         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6648         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6649         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6650         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6651         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6652         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6653         coff-pe-read.c, command.h, compile/compile-c-support.c,
6654         compile/compile-c.h, compile/compile-cplus-symbols.c,
6655         compile/compile-cplus-types.c, compile/compile-cplus.h,
6656         compile/compile-loc2c.c, compile/compile.c, completer.c,
6657         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6658         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6659         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6660         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6661         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6662         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6663         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6664         features/aarch64-core.c, features/aarch64-fpu.c,
6665         features/aarch64-pauth.c, features/aarch64-sve.c,
6666         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6667         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6668         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6669         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6670         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6671         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6672         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6673         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6674         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6675         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6676         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6677         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6678         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6679         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6680         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6681         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6682         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6683         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6684         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6685         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6686         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6687         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6688         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6689         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6690         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6691         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6692         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6693         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6694         minsyms.c, mips-linux-tdep.c, namespace.h,
6695         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6696         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6697         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6698         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6699         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6700         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6701         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6702         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6703         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6704         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6705         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6706         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6707         procfs.c, producer.c, progspace.h, psymtab.h,
6708         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6709         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6710         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6711         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6712         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6713         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6714         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6715         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6716         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6717         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6718         target-memory.c, target.c, target.h, target/waitstatus.c,
6719         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6720         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6721         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6722         unittests/array-view-selftests.c,
6723         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6724         unittests/common-utils-selftests.c,
6725         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6726         unittests/format_pieces-selftests.c,
6727         unittests/function-view-selftests.c,
6728         unittests/lookup_name_info-selftests.c,
6729         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6730         unittests/mkdir-recursive-selftests.c,
6731         unittests/observable-selftests.c,
6732         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6733         unittests/parse-connection-spec-selftests.c,
6734         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6735         unittests/scoped_fd-selftests.c,
6736         unittests/scoped_mmap-selftests.c,
6737         unittests/scoped_restore-selftests.c,
6738         unittests/string_view-selftests.c, unittests/style-selftests.c,
6739         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6740         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6741         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6742         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6743         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6744         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6745
6746 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6749         bool value.
6750         (decode_digits_ordinary): Set explicit_line field in sal.
6751         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6752         symtab_and_line that was set on an explicit line number in
6753         assembler code.  Do always update the recorded symtab and line if
6754         we do skip the prologue.
6755
6756 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6757
6758         * breakpoint.c (set_breakpoint_location_function): Remove
6759         explicit_loc parameter.
6760         (momentary_breakpoint_from_master): Update call to
6761         set_breakpoint_location_function.
6762         (add_location_to_breakpoint): Likewise.
6763
6764 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6765
6766         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6767         required features based on default bfd type when no specific bfd
6768         is present.
6769
6770 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6771
6772         * NEWS: Mention that GDB printf and eval commands can now print
6773         C-style and Ada-style convenience var strings without
6774         calling the inferior.
6775         * printcmd.c (printf_c_string): Locally print GDB internal var
6776         instead of transiting via the inferior.
6777         (printf_wide_c_string): Likewise.
6778
6779 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6780
6781         PR breakpoints/25011
6782         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6783
6784 2019-07-04  Tom Tromey  <tom@tromey.com>
6785
6786         PR tui/24724:
6787         * tui/tui-winsource.c (tui_clear_source_content): Update.
6788         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6789         (tui_update_breakpoint_info): Update.
6790         (tui_set_exec_info_content): Update.
6791         * tui/tui-source.c (tui_set_source_content_nil): Update.
6792         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6793         has_break.
6794         * tui/tui-data.h (enum tui_bp_flag): New.
6795         (tui_bp_flags): New enum flags type.
6796         (struct tui_source_element) <break_mode>: Change type.  Rename
6797         from has_break.
6798         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6799         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6800         constants.
6801         * tui/tui-winsource.h: Fix comment.
6802
6803 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6804
6805         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6806         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6807         (store_fpregs_to_thread)
6808         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6809         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6810         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6811         (IWMMXT_REGS_SIZE): Add define.
6812         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6813         (fetch_vfp_regs, store_vfp_regs)
6814         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6815         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6816
6817 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6820         defines.
6821         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6822         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6823         (ARM_INT_REGISTER_SIZE): ...to this.
6824         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6825         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6826         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6827         (arm_linux_collect_gregset, supply_nwfpe_register)
6828         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6829         defines.
6830         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6831         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6832         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6833         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6834         (arm_return_in_memory, arm_store_return_value)
6835         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6836         (arm_record_ld_st_multiple): Likewise.
6837         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6838         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6839
6840 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6841
6842         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6843         AARCH64_DISPLACED_MODIFIED_INSNS.
6844         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6845         (aarch64_displaced_step_copy_insn): Likewise.
6846         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6847         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6848         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6849         ARM_DISPLACED_MODIFIED_INSNS.
6850         * arm-tdep.c (arm_gdbarch_init): Likewise.
6851         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6852         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6853         (struct arm_displaced_step_closure): Use
6854         ARM_DISPLACED_MODIFIED_INSNS.
6855
6856 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6857
6858         * features/Makefile: Remove unused xml files.
6859         * features/aarch64.xml: Remove.
6860         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6861         * features/i386/amd64-avx-avx512.xml: Remove.
6862         * features/i386/amd64-avx-linux.xml: Remove.
6863         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6864         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6865         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6866         * features/i386/amd64-avx-mpx.xml: Remove.
6867         * features/i386/amd64-avx.xml: Remove.
6868         * features/i386/amd64-linux.xml: Remove.
6869         * features/i386/amd64-mpx-linux.xml: Remove.
6870         * features/i386/amd64-mpx.xml: Remove.
6871         * features/i386/amd64.xml: Remove.
6872         * features/i386/i386-avx-avx512-linux.xml: Remove.
6873         * features/i386/i386-avx-avx512.xml: Remove.
6874         * features/i386/i386-avx-linux.xml: Remove.
6875         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6876         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6877         * features/i386/i386-avx-mpx-linux.xml: Remove.
6878         * features/i386/i386-avx-mpx.xml: Remove.
6879         * features/i386/i386-avx.xml: Remove.
6880         * features/i386/i386-linux.xml: Remove.
6881         * features/i386/i386-mmx-linux.xml: Remove.
6882         * features/i386/i386-mmx.xml: Remove.
6883         * features/i386/i386-mpx-linux.xml: Remove.
6884         * features/i386/i386-mpx.xml: Remove.
6885         * features/i386/i386.xml: Remove.
6886         * features/i386/x32-avx-avx512-linux.xml: Remove.
6887         * features/i386/x32-avx-linux.xml: Remove.
6888         * features/i386/x32-linux.xml: Remove.
6889
6890 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6891
6892         * regformats/aarch64.dat: Remove.
6893         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6894         * regformats/i386/amd64-avx-linux.dat: Remove.
6895         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6896         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6897         * regformats/i386/amd64-linux.dat: Remove.
6898         * regformats/i386/amd64-mpx-linux.dat: Remove.
6899         * regformats/i386/amd64.dat: Remove.
6900         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6901         * regformats/i386/i386-avx-linux.dat: Remove.
6902         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6903         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6904         * regformats/i386/i386-linux.dat: Remove.
6905         * regformats/i386/i386-mmx-linux.dat: Remove.
6906         * regformats/i386/i386-mpx-linux.dat: Remove.
6907         * regformats/i386/i386.dat: Remove.
6908         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6909         * regformats/i386/x32-avx-linux.dat: Remove.
6910         * regformats/i386/x32-linux.dat: Remove.
6911
6912 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6913
6914         * aarch64-tdep.c: Remove xml self tests.
6915         * amd64-linux-tdep.c: Likewise.
6916         * amd64-tdep.c: Likewise.
6917         * i386-linux-tdep.c: Likewise.
6918         * i386-tdep.c: Likewise.
6919
6920 2019-07-03  Pedro Alves  <palves@redhat.com>
6921
6922         PR cli/24732
6923         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6924         (pipe_cmd_option_defs): New.
6925         (make_pipe_cmd_options_def_group): New.
6926         (pipe_command): Use gdb::option::process_options.
6927         (pipe_command_completer): New function.
6928         (_initialize_cli_cmds): Install completer for "pipe" command.
6929
6930 2019-07-03  Pedro Alves  <palves@redhat.com>
6931
6932         * cli/cli-option.c (union option_value) <string>: New field.
6933         (struct option_def_and_value): Add ctor, move ctor, dtor and
6934         use DISABLE_COPY_AND_ASSIGN.
6935         (option_def_and_value::clear_value): New.
6936         (parse_option, save_option_value_in_ctx, get_val_type_str)
6937         (add_setshow_cmds_for_options): Handle var_string.
6938         * cli-option.h (union option_def::var_address) <string>: New
6939         field.
6940         (struct string_option_def): New.
6941         * maint-test-options.c (struct test_options_opts): Add default
6942         ctor and use DISABLE_COPY_AND_ASSIGN.
6943         <string_opt>: New field.
6944         (test_options_opts::~test_options_opts): New.
6945         (test_options_opts::dump): Also dump "-string".
6946         (test_options_option_defs): Install "string.
6947
6948 2019-07-03  Pedro Alves  <palves@redhat.com>
6949
6950         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6951         option_value with a null enumeration.
6952         (complete_options): Save the option values in the context.
6953         (save_option_value_in_ctx): New, factored out from ...
6954         (process_options): ... here.
6955         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6956         of the function.
6957         * maint-test-options.c (test_options_opts::dump): New, factored
6958         out from ...
6959         (maintenance_test_options_command_mode): ... here.
6960         (maintenance_test_options_command_completion_result): Delete.
6961         (maintenance_test_options_command_completion_text): Update
6962         comment.
6963         (maintenance_show_test_options_completion_result): Change
6964         prototype.  Just print
6965         maintenance_test_options_command_completion_text.
6966         (save_completion_result): New.
6967         (maintenance_test_options_completer_mode): Pass options context to
6968         complete_options, and then save a dump.
6969         (_initialize_maint_test_options): Use add_cmd to install "maint
6970         show test-options-completion-result".
6971
6972 2019-07-03  Pedro Alves  <palves@redhat.com>
6973
6974         * NEWS (New commands): Mention "with" and "maint with".
6975         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6976         (with_command, with_command_completer): New.
6977         (pipe_command): Adjust to new repeat_previous
6978         interface.
6979         (_initialize_cli_cmds): Install the "with" command and its "w"
6980         alias.
6981         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6982         declarations.
6983         * cli/cli-setshow.c (parse_cli_var_uinteger)
6984         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6985         argument strings for all var_types.
6986         (get_setshow_command_value_string): New, factored out from ...
6987         (do_show_command): ... this.
6988         * cli/cli-setshow.h: Include <string>.
6989         (get_setshow_command_value_string): Declare.
6990         * command.h (repeat_previous): Now returns const char *.  Adjust
6991         comment.
6992         * maint.c: Include "cli/cli-cmds.h".
6993         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6994         (_initialize_maint_cmds): Register the "maintenance with" command.
6995         * top.c (repeat_previous): Move bits from pipe_command here:
6996         Return the saved command line, if any; error out if there's no
6997         command to relaunch.
6998
6999 2019-07-03  Pedro Alves  <palves@redhat.com>
7000
7001         * NEWS (New commands): Mention "maint set/show test-settings"
7002         instead of "maint test-settings".
7003         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7004         (maintenance_test_settings_set_list): Rename to ...
7005         (maintenance_set_test_settings_list): ... this.
7006         (maintenance_test_settings_show_list): Rename to  ...
7007         (maintenance_show_test_settings_list): ... this.
7008         (maintenance_test_settings_cmd): Delete.
7009         (maintenance_test_settings_set_cmd): ...
7010         (maintenance_set_test_settings_cmd): ... this.
7011         (maintenance_test_settings_show_cmd): ...
7012         (maintenance_show_test_settings_cmd): ... this.
7013         (maintenance_test_settings_show_value_cmd):
7014         (maintenance_show_test_settings_value_cmd): ... this.
7015         (_initialize_maint_test_settings): No longer install the "maint
7016         test-settings" prefix command.  Rename "maint test-settings set"
7017         to "maint set test-settings", and "maint test-settings show" to
7018         "maint show test-settings".  Adjust all subcommands.
7019
7020 2019-07-03  Pedro Alves  <palves@redhat.com>
7021
7022         * maint-test-settings.c: Fix file's intro comment.  Replace all
7023         references to "test-options" with references to "test-settings",
7024         in comments.
7025
7026 2019-07-03  Pedro Alves  <palves@redhat.com>
7027
7028         * maint-test-settings.c (maintenance_test_settings_xxx)
7029         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7030         New.
7031         (maintenance_test_settings_enums): Use them.
7032         (maintenance_test_settings_enum): Default to
7033         maintenance_test_settings_xxx.
7034         (_initialize_maint_test_settings): Initialize
7035         MAINTENANCE_TEST_SETTINGS_FILENAME.
7036
7037 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7038
7039         * breakpoint.h (remove_breakpoints_inf): Change return type to
7040         void, move function documentation here.
7041         * breakpoint.c (remove_breakpoints_inf): Change return type to
7042         void, move function documentation to header.
7043
7044 2019-07-02  Pedro Alves  <palves@redhat.com>
7045
7046         * NEWS (Completion improvements): Mention "info threads".
7047         * thread.c (struct info_threads_opts, info_threads_option_defs)
7048         (make_info_threads_options_def_group): New.
7049         (info_threads_command): Use gdb::option::process_options.
7050         (info_threads_command_completer): New.
7051         (_initialize_thread): Use gdb::option::build_help to build the
7052         help text for "info threads".
7053
7054 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7055
7056         * defs.h (generic_load): Move from here...
7057         * symfile.h (generic_load): ... to here.  Rename name parameter
7058         to args.
7059         * symfile.c (generic_load): Add comment.
7060
7061 2019-07-01  Tom Tromey  <tromey@adacore.com>
7062
7063         * dwarf2read.c
7064         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7065         declaration of without_params.  Fix formatting.
7066
7067 2019-07-01  Tom Tromey  <tromey@adacore.com>
7068
7069         * ada-exp.y (find_primitive_type): Update.
7070         * ada-lang.h (ada_lookup_symbol): Update.
7071         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7072         parameter.
7073         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7074
7075 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7076
7077         PR breakpoints/24541
7078         * gdbarch.c: Regenerate.
7079         * gdbarch.h: Regenerate.
7080         * gdbarch.sh: Add 'stap_adjust_register'.
7081         * i386-tdep.c: Include '<unordered_set>'.
7082         (i386_stap_adjust_register): New function.
7083         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7084         * stap-probe.c (stap_parse_register_operand): Call
7085         'gdbarch_stap_adjust_register'.
7086
7087 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7088
7089         PR python/24742
7090         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7091         * python/python.c (do_start_initialization): Use 'xmalloc'
7092         instead of 'PyMem_Malloc'.
7093
7094 2019-06-28  Tom Tromey  <tromey@adacore.com>
7095
7096         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7097         for Ada.
7098
7099 2019-06-27  Tom Tromey  <tromey@adacore.com>
7100
7101         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7102         objfile_key.
7103         (arm_find_mapping_symbol, arm_record_special_symbol)
7104         (_initialize_arm_tdep): Update.
7105         (arm_objfile_data_free): Remove.
7106
7107 2019-06-27  Tom Tromey  <tromey@adacore.com>
7108
7109         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7110         to cp_print_static_field.
7111
7112 2019-06-26  Tom Tromey  <tromey@adacore.com>
7113
7114         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7115         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7116         declare.
7117
7118 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7119
7120         * features/aarch64-core.c (create_feature_aarch64_core):
7121         Regenerate.
7122         * features/aarch64-core.xml: Add cpsr flags.
7123
7124 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7125
7126         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7127         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7128
7129 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7130
7131         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7132         field.
7133         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7134         use.
7135         (arm_record_special_symbol): Don't insert new symbol in sorted
7136         position, push it at the end.
7137
7138 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7139
7140         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7141         (arm_mapping_symbol_s): Remove.
7142         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7143         (arm_mapping_symbol_vec): New typedef.
7144         (struct arm_per_objfile): Add constructor.
7145         <section_maps>: Change type to
7146         std::unique_ptr<arm_mapping_symbol_vec[]>.
7147         (arm_compare_mapping_symbols): Remove.
7148         (arm_find_mapping_symbol): Adjust to section_maps type change.
7149         (arm_objfile_data_free): Call delete on arm_per_objfile.
7150         (arm_record_special_symbol): Adjust to section_maps type change.
7151         Allocate arm_per_objfile with new.
7152
7153 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7154
7155         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7156         with the command prefix.
7157
7158 2019-06-25  Tom Tromey  <tom@tromey.com>
7159
7160         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7161         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7162
7163 2019-06-25  Tom Tromey  <tom@tromey.com>
7164
7165         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7166         type.
7167         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7168         protected.
7169
7170 2019-06-25  Tom Tromey  <tom@tromey.com>
7171
7172         * tui/tui-winsource.c
7173         (tui_source_window_base::set_is_exec_point_at): Add check against
7174         LOA_ADDRESS.
7175
7176 2019-06-25  Tom Tromey  <tom@tromey.com>
7177
7178         * tui/tui-source.c (tui_set_source_content): Don't check before
7179         xfree.
7180         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7181
7182 2019-06-25  Tom Tromey  <tom@tromey.com>
7183
7184         * tui/tui-winsource.h (tui_update_source_window_as_is)
7185         (tui_alloc_source_buffer, tui_line_is_displayed)
7186         (tui_addr_is_displayed): Change type of win_info.
7187         * tui/tui-winsource.c (tui_update_source_window_as_is)
7188         (tui_clear_source_content, tui_show_source_line)
7189         (tui_show_source_content, tui_source_window_base::refill)
7190         (tui_source_window_base::set_is_exec_point_at)
7191         (tui_source_window_base::set_is_exec_point_at)
7192         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7193         (tui_alloc_source_buffer, tui_line_is_displayed)
7194         (tui_addr_is_displayed): Change type of win_info.  Update.
7195         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7196         (tui_source_window_base::do_make_visible_with_new_height):
7197         Update.
7198         * tui/tui-source.c (tui_set_source_content)
7199         (tui_set_source_content_nil)
7200         (tui_source_window::do_scroll_vertical): Update.
7201         * tui/tui-layout.c (show_layout): Update.
7202         * tui/tui-disasm.c (tui_set_disassem_content)
7203         (tui_disasm_window::do_scroll_vertical): Update.
7204         * tui/tui-data.h (tui_win_content): Remove.
7205         (struct tui_gen_win_info) <content, content_size>: Remove.
7206         (struct tui_source_element): Add initializers and destructor.
7207         (union tui_which_element, struct tui_win_element): Remove.
7208         (struct tui_source_window_base) <content>: New field.
7209         (struct tui_data_window): Remove destructor.
7210         (tui_alloc_content, tui_free_win_content)
7211         (tui_free_all_source_wins_content): Don't declare.
7212         * tui/tui-data.c (tui_initialize_static_data): Update.
7213         (init_content_element, tui_alloc_content): Remove.
7214         (~tui_gen_win_info): Update.
7215         (~tui_data_window, tui_free_all_source_wins_content)
7216         (tui_free_win_content, free_content, free_content_elements):
7217         Remove.
7218
7219 2019-06-25  Tom Tromey  <tom@tromey.com>
7220
7221         * tui/tui-winsource.h (tui_clear_source_content)
7222         (tui_erase_source_content, tui_show_source_content): Change type
7223         of win_info.
7224         * tui/tui-winsource.c (tui_clear_source_content)
7225         (tui_erase_source_content, tui_show_source_content): Change type
7226         of win_info.
7227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7228         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7229         win_info.
7230         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7231         win_info.
7232         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7233
7234 2019-06-25  Tom Tromey  <tom@tromey.com>
7235
7236         * tui/tui-winsource.c (tui_clear_source_content)
7237         (tui_source_window_base::set_is_exec_point_at): Update.
7238         * tui/tui-source.c (tui_set_source_content_nil): Update.
7239         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7240         a bool.
7241         * tui/tui-data.c (init_content_element): Update.
7242
7243 2019-06-25  Tom Tromey  <tom@tromey.com>
7244
7245         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7246         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7247         * tui/tui-layout.c (init_and_make_win): Update.
7248         * tui/tui.h (enum tui_win_type): Update.
7249         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7250         tui_win_is_auxillary.
7251         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7252         tui_win_is_auxillary.
7253
7254 2019-06-25  Tom Tromey  <tom@tromey.com>
7255
7256         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7257         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7258         (tui_delete_data_content_windows, tui_display_all_data)
7259         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7260         Update.
7261         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7262         * tui/tui-regs.c (tui_last_regs_line_no)
7263         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7264         (tui_show_registers): Update.
7265         (tui_show_register_group): Return void.  Update.
7266         (tui_display_registers_from, tui_display_reg_element_at_line)
7267         (tui_display_registers_from_line, tui_check_register_values):
7268         Update.
7269         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7270         member.
7271         (struct tui_data_window) <regs_content>: Now a std::vector.
7272         <regs_content_count>: Remove.
7273         (tui_add_content_elements, tui_free_data_content): Don't declare.
7274         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7275         (init_content_element): Remove DATA_WIN case.  Add assert.
7276         (tui_add_content_elements): Remove.
7277         (tui_data_window): Update.
7278         (tui_free_data_content): Remove.
7279         (free_content_elements): Remove DATA_WIN case.
7280
7281 2019-06-25  Tom Tromey  <tom@tromey.com>
7282
7283         * tui/tui-data.c (tui_data_item_window): Update.
7284         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7285         * tui/tui-windata.c (tui_display_all_data)
7286         (tui_display_data_from_line): Update.
7287         (tui_check_data_values): Remove.
7288         * tui/tui-regs.c (tui_show_register_group)
7289         (tui_display_reg_element_at_line): Update.
7290         * tui/tui-hooks.c (tui_register_changed)
7291         (tui_refresh_frame_and_register_information): Call
7292         tui_check_register_values.
7293         * tui/tui-data.h (struct tui_data_window) <data_content,
7294         data_content_count, data_type>: Remove.
7295         (enum tui_data_type): Remove.
7296
7297         * tui/tui-data.c (tui_data_window::clear_detail)
7298         (~tui_data_window): Update.
7299
7300 2019-06-25  Tom Tromey  <tom@tromey.com>
7301
7302         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7303         declare.
7304         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7305         Rename from tui_first_data_item_displayed.  Update.
7306         (tui_data_window::refresh_all)
7307         (tui_data_window::do_scroll_vertical): Update.
7308         * tui/tui-data.h (struct tui_data_window)
7309         <first_data_item_displayed>: Declare new method.
7310
7311 2019-06-25  Tom Tromey  <tom@tromey.com>
7312
7313         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7314         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7315         contents...
7316         (tui_initialize_static_data): ...here.
7317
7318 2019-06-25  Tom Tromey  <tom@tromey.com>
7319
7320         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7321         (tui_display_registers_from, tui_check_register_values): Update.
7322         (tui_display_register): Remove win_info parameter; update.
7323         (tui_get_register): Change type of parameters.
7324         * tui/tui-data.h (struct tui_data_element): Remove.
7325         (union tui_which_element) <data>: Remove.
7326         <data_window>: Change type.
7327         (struct tui_data_item_window): New.
7328         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7329         case.  Add assert.
7330         (~tui_data_item_window): New destructor.
7331         (free_content_elements): Remove DATA_ITEM_WIN case.
7332
7333 2019-06-25  Tom Tromey  <tom@tromey.com>
7334
7335         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7336         Remove.
7337
7338 2019-06-25  Tom Tromey  <tom@tromey.com>
7339
7340         * tui/tui-data.h (struct tui_command_element): Remove.
7341         (union tui_which_element) <command>: Remove.
7342         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7343         assert.
7344         (free_content_elements): Remove CMD_WIN case.
7345
7346 2019-06-25  Tom Tromey  <tom@tromey.com>
7347
7348         * tui/tui-layout.c (tui_set_layout): Update.
7349         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7350         * tui/tui-data.c (layout_def): Update.
7351
7352 2019-06-25  Tom Tromey  <tom@tromey.com>
7353
7354         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7355         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7356         (tui_source_window_base::set_new_height): Update.
7357         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7358         Update.
7359         (tui_set_locator_fullname, tui_set_locator_info)
7360         (tui_show_frame_info): Update.
7361         * tui/tui-source.c (tui_set_source_content)
7362         (tui_source_is_displayed): Update.
7363         * tui/tui-layout.c (show_source_disasm_command, show_data)
7364         (show_source_or_disasm_and_command): Update.
7365         * tui/tui-disasm.c (tui_set_disassem_content)
7366         (tui_get_begin_asm_address): Update.
7367         * tui/tui-data.h (struct tui_locator_element): Remove.
7368         (union tui_which_element) <locator>: Remove.
7369         (struct tui_locator_window): New.
7370         (tui_locator_win_info_ptr): Change return type.
7371         * tui/tui-data.c (_locator): Change type.
7372         (tui_locator_win_info_ptr): Change return type.
7373         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7374         (tui_alloc_content): Add assert.
7375
7376 2019-06-25  Tom Tromey  <tom@tromey.com>
7377
7378         * tui/tui-winsource.c
7379         (tui_exec_info_window::maybe_allocate_content): New method.
7380         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7381         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7382         (make_source_or_disasm_window): Add cast.
7383         * tui/tui-data.h (union tui_which_element) <simple_string>:
7384         Remove.
7385         (struct tui_source_info): New.
7386         (struct tui_source_window_base) <execution_info>: Change type.
7387         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7388         case, and add assert.
7389         (tui_alloc_content): Add assert.
7390
7391 2019-06-25  Tom Tromey  <tom@tromey.com>
7392
7393         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7394         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7395         * tui/tui-data.c (tui_alloc_win_info): Remove.
7396
7397 2019-06-25  Tom Tromey  <tom@tromey.com>
7398
7399         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7400         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7401         can_highlight.
7402
7403 2019-06-25  Tom Tromey  <tom@tromey.com>
7404
7405         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7406         make_visible_with_new_height method.
7407         (tui_win_info::make_visible_with_new_height): New method.
7408         (tui_source_window_base::do_make_visible_with_new_height)
7409         (tui_data_window::do_make_visible_with_new_height)
7410         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7411         (make_visible_with_new_height): Remove.
7412         (tui_resize_all, tui_adjust_win_heights): Use
7413         make_visible_with_new_height method.
7414         * tui/tui-data.h (struct tui_win_info)
7415         <do_make_visible_with_new_height, make_visible_with_new_height>:
7416         New methods.
7417         (struct tui_source_window_base, struct tui_data_window)
7418         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7419         methods.
7420
7421 2019-06-25  Tom Tromey  <tom@tromey.com>
7422
7423         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7424         method.
7425         (update_tab_width): Call update_tab_width method.
7426         * tui/tui-data.h (struct tui_win_info)
7427         (struct tui_source_window_base) <update_tab_width>: New methods.
7428
7429 2019-06-25  Tom Tromey  <tom@tromey.com>
7430
7431         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7432         parameter.
7433         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7434         parameter.
7435         (tui_gen_win_info::make_visible): Update.
7436         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7437         parameter.
7438         * tui/tui-data.h (enum tui_box): New enum.
7439         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7440
7441 2019-06-25  Tom Tromey  <tom@tromey.com>
7442
7443         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7444         init_and_make_win for EXEC_INFO_WIN.
7445         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7446         longer inline.
7447         (struct tui_win_info) <~tui_win_info>: Inline.
7448         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7449         Don't declare.
7450         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7451         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7452         Remove.
7453         (tui_initialize_static_data): Update.
7454         (~tui_gen_win_info): Handle more cleanup here.
7455         (~tui_source_window_base): Delete "execution_info".
7456         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7457
7458 2019-06-25  Tom Tromey  <tom@tromey.com>
7459
7460         * tui/tui-layout.c (make_command_window): Don't set
7461         can_highlight.
7462         (show_source_disasm_command): Call the reset method.
7463         (show_data): Don't set can_highlight.  Call the reset method.
7464         (tui_gen_win_info::reset): Rename from init_gen_win_info
7465         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7466         (show_source_or_disasm_and_command): Call the reset method.
7467         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7468         (struct tui_cmd_window): Set can_highlight.
7469
7470 2019-06-25  Tom Tromey  <tom@tromey.com>
7471
7472         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7473         from make_visible.
7474         (tui_make_visible, tui_make_invisible): Rewrite.
7475         (tui_win_info::make_visible): Remove.
7476         (tui_source_window_base::make_visible): Update.
7477         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7478         method.  Moved from...
7479         (struct tui_win_info) <make_visible>: ...here.
7480
7481 2019-06-25  Tom Tromey  <tom@tromey.com>
7482
7483         * tui/tui-winsource.c
7484         (tui_source_window_base::do_scroll_horizontal): Remove direction
7485         parameter.
7486         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7487         direction parameter.
7488         * tui/tui-win.c (tui_win_info::forward_scroll)
7489         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7490         (tui_win_info::right_scroll): Update.
7491         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7492         direction parameter.
7493         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7494         direction parameter.
7495         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7496         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7497         Remove direction parameter.
7498         (struct tui_source_window_base, struct tui_source_window)
7499         (struct tui_disasm_window, struct tui_data_window)
7500         (struct tui_cmd_window): Update.
7501
7502 2019-06-25  Tom Tromey  <tom@tromey.com>
7503
7504         * tui/tui-winsource.h (tui_set_exec_info_content)
7505         (tui_show_exec_info_content, tui_erase_exec_info_content)
7506         (tui_clear_exec_info_content, tui_update_exec_info): Change
7507         argument to tui_source_window_base.
7508         * tui/tui-winsource.c (tui_set_exec_info_content)
7509         (tui_show_exec_info_content, tui_erase_exec_info_content)
7510         (tui_clear_exec_info_content, tui_update_exec_info): Change
7511         argument to tui_source_window_base.
7512
7513 2019-06-25  Tom Tromey  <tom@tromey.com>
7514
7515         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7516         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7517
7518 2019-06-25  Tom Tromey  <tom@tromey.com>
7519
7520         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7521         check.
7522
7523 2019-06-25  Tom Tromey  <tom@tromey.com>
7524
7525         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7526         type to void.
7527         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7528         type to void.
7529         * tui/tui-source.c (tui_set_source_content): Update.
7530         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7531
7532 2019-06-25  Tom Tromey  <tom@tromey.com>
7533
7534         * tui/tui-win.c (window_name_completer, tui_set_focus)
7535         (tui_all_windows_info): Use name method.
7536         * tui/tui-data.h (struct tui_gen_win_info)
7537         (struct tui_source_window, struct tui_disasm_window)
7538         (struct tui_data_window, struct tui_cmd_window) <name>: New
7539         method.
7540         (tui_win_name): Don't declare.
7541         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7542         (tui_win_name): Remove.
7543
7544 2019-06-25  Tom Tromey  <tom@tromey.com>
7545
7546         * tui/tui-winsource.h (tui_update_source_window)
7547         (tui_update_source_window_as_is): Change parameter type.
7548         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7549         to be a tui_source_window_base.
7550         (tui_update_source_window_as_is): Likewise.
7551         * tui/tui-win.c (make_visible_with_new_height): Update.
7552
7553 2019-06-25  Tom Tromey  <tom@tromey.com>
7554
7555         * tui/tui-winsource.c (tui_erase_source_content)
7556         (tui_show_source_content, tui_show_exec_info_content)
7557         (tui_erase_exec_info_content): Use refresh_window method.
7558         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7559         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7560         from tui_refresh_win.
7561         (tui_data_window::refresh_window): New method.
7562         (tui_win_info::refresh, tui_source_window_base::refresh)
7563         (tui_refresh_all): Use refresh_window method.
7564         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7565         method.
7566         * tui/tui-regs.c (tui_display_register): Call refresh_window
7567         method.
7568         * tui/tui-layout.c (show_source_disasm_command)
7569         (show_source_or_disasm_and_command): Call refresh_window method.
7570         * tui/tui-data.h (struct tui_gen_win_info)
7571         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7572         New method.
7573
7574 2019-06-25  Tom Tromey  <tom@tromey.com>
7575
7576         * tui/tui.c (tui_rl_other_window, tui_enable)
7577         (tui_is_window_visible, tui_get_command_dimension): Update.
7578         * tui/tui-winsource.c (tui_update_source_window_as_is)
7579         (tui_clear_source_content, tui_erase_source_content)
7580         (tui_show_source_line, tui_source_window_base::refill)
7581         (tui_source_window_base::do_scroll_horizontal)
7582         (tui_source_window_base::set_is_exec_point_at)
7583         (tui_update_breakpoint_info, tui_set_exec_info_content)
7584         (tui_alloc_source_buffer, tui_line_is_displayed)
7585         (tui_addr_is_displayed): Update.
7586         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7587         (tui_check_and_display_highlight_if_needed)
7588         (tui_win_info::make_visible, tui_win_info::refresh)
7589         (tui_refresh_all): Update.
7590         * tui/tui-windata.c (tui_first_data_item_displayed)
7591         (tui_delete_data_content_windows, tui_erase_data_content)
7592         (tui_display_all_data, tui_data_window::refresh_all)
7593         (tui_check_data_values): Update.
7594         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7595         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7596         (tui_win_info::backward_scroll, tui_refresh_all_win)
7597         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7598         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7599         (tui_source_window_base::set_new_height)
7600         (tui_data_window::set_new_height)
7601         (make_invisible_and_set_new_height)
7602         (make_visible_with_new_height, new_height_ok)
7603         (parse_scrolling_args): Update.
7604         * tui/tui-stack.c (tui_show_frame_info): Update.
7605         * tui/tui-source.c (tui_set_source_content)
7606         (tui_set_source_content_nil, tui_source_is_displayed)
7607         (tui_source_window::do_scroll_vertical): Update.
7608         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7609         (tui_display_registers_from, tui_display_reg_element_at_line)
7610         (tui_check_register_values, tui_reg_command): Update.
7611         * tui/tui-layout.c (tui_default_win_height)
7612         (show_source_disasm_command, show_data, init_and_make_win)
7613         (show_source_or_disasm_and_command): Update.
7614         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7615         (tui_redisplay_readline, tui_mld_flush)
7616         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7617         (tui_getc): Update.
7618         * tui/tui-disasm.c (tui_set_disassem_content)
7619         (tui_disasm_window::do_scroll_vertical): Update.
7620         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7621         Now virtual.
7622         (struct tui_win_info): Derive from tui_gen_win_info.
7623         <~tui_win_info>: Mark as override.
7624         <generic>: Remove member.
7625         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7626         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7627         (~tui_data_window, ~tui_win_info)
7628         (tui_free_all_source_wins_content): Update.
7629         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7630
7631 2019-06-25  Tom Tromey  <tom@tromey.com>
7632
7633         * tui/tui-layout.c (init_and_make_win): Use new.
7634         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7635         destructor, initializers.
7636         (tui_alloc_generic_win_info): Don't declare.
7637         * tui/tui-data.c (_locator): Add argument to constructor.
7638         (source_win, disasm_win): New globals.
7639         (exec_info): Remove.
7640         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7641         Update.
7642         (tui_alloc_generic_win_info): Remove.
7643         (init_content_element): Use new.
7644         (tui_win_info::tui_win_info): Update.
7645         (free_content_elements) <case DATA_WIN>: Use delete.
7646
7647 2019-06-25  Tom Tromey  <tom@tromey.com>
7648
7649         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7650         * tui/tui-windata.c (tui_first_data_item_displayed)
7651         (tui_delete_data_content_windows): Update.
7652         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7653         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7654         (tui_display_registers_from, tui_check_register_values): Update.
7655         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7656         pointer.
7657         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7658         window.
7659         (tui_free_data_content): Update.
7660         (free_content_elements) <case DATA_WIN>: Free the window.
7661
7662 2019-06-25  Tom Tromey  <tom@tromey.com>
7663
7664         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7665         Update.
7666         * tui/tui-layout.c (make_command_window)
7667         (show_source_disasm_command, show_data, init_and_make_win)
7668         (show_source_or_disasm_and_command): Update.
7669         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7670         method.
7671         <can_highight, is_highlighted>: Now bool.
7672         (tui_set_win_highlight): Don't declare.
7673         * tui/tui-data.c (tui_set_win_highlight): Remove.
7674
7675 2019-06-25  Tom Tromey  <tom@tromey.com>
7676
7677         * tui/tui-wingeneral.c (make_visible): Remove check of window
7678         type.
7679
7680 2019-06-25  Tom Tromey  <tom@tromey.com>
7681
7682         * tui/tui-win.c (tui_win_info::max_height)
7683         (tui_cmd_window::max_height): New methods.
7684         (new_height_ok): Call max_height.
7685         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7686         <max_height>: New method.
7687
7688 2019-06-25  Tom Tromey  <tom@tromey.com>
7689
7690         * tui/tui-win.c (tui_source_window_base::set_new_height)
7691         (tui_data_window::set_new_height): New methods.
7692         (make_invisible_and_set_new_height): Call set_new_height method.
7693         * tui/tui-data.h (struct tui_win_info)
7694         (struct tui_source_window_base, struct tui_data_window)
7695         <set_new_height>: New method.
7696
7697 2019-06-25  Tom Tromey  <tom@tromey.com>
7698
7699         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7700         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7701         tui_refresh_data_win.
7702         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7703         method.
7704         (tui_refresh_all_win): Call the refresh_all method.
7705         (tui_set_focus): Likewise.
7706         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7707         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7708         Likewise.
7709
7710 2019-06-25  Tom Tromey  <tom@tromey.com>
7711
7712         * tui/tui-winsource.h (tui_refill_source_window)
7713         (tui_set_is_exec_point_at): Don't declare.
7714         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7715         (tui_source_window_base::refill): Rename from
7716         tui_refill_source_window.
7717         (tui_source_window_base::do_scroll_horizontal): Update.
7718         (tui_source_window_base::set_is_exec_point_at): Rename from
7719         tui_set_is_exec_point_at.
7720         (tui_update_all_breakpoint_info): Update.
7721         * tui/tui-stack.c (tui_show_frame_info): Update.
7722         * tui/tui-layout.c (show_data): Add cast.
7723         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7724         * tui/tui-data.h (struct tui_source_window_base) <refill,
7725         set_is_exec_point_at>: New methods.
7726         (tui_source_windows, tui_add_to_source_windows): Update types.
7727         (tui_add_to_source_windows): Remove redundant declaration.
7728         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7729         (tui_source_windows): Change return type.
7730         (tui_clear_source_windows_detail): Update.
7731         (tui_add_to_source_windows): Change type of parameter.
7732         (tui_free_all_source_wins_content): Update.
7733
7734 2019-06-25  Tom Tromey  <tom@tromey.com>
7735
7736         * tui/tui-wingeneral.c (tui_win_info::refresh)
7737         (tui_source_window_base::refresh): New methods.
7738         (tui_refresh_all): Call the refresh method.
7739         * tui/tui-data.h (struct tui_win_info)
7740         (struct tui_source_window_base) <refresh>: New method.
7741
7742 2019-06-25  Tom Tromey  <tom@tromey.com>
7743
7744         * tui/tui.h (tui_is_window_visible): Return bool.
7745         * tui/tui.c (tui_is_window_visible): Return bool.
7746         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7747         (tui_make_visible, tui_make_invisible)
7748         (tui_win_info::make_visible)
7749         (tui_source_window_base::make_visible, make_all_visible)
7750         (tui_make_all_visible, tui_make_all_invisible): Update.
7751         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7752         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7753         bool.
7754         (struct tui_win_info, struct tui_source_window_base)
7755         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7756         * tui/tui-data.c (tui_init_generic_part): Update.
7757
7758 2019-06-25  Tom Tromey  <tom@tromey.com>
7759
7760         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7761         (tui_source_window_base::make_visible): New methods.
7762         (make_all_visible): Make method call.
7763         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7764         (struct tui_source_window_base, struct tui_cmd_window): Override
7765         make_visible.
7766         (tui_win_is_source_type): Don't declare.
7767         * tui/tui-data.c (tui_win_is_source_type): Remove.
7768
7769 2019-06-25  Tom Tromey  <tom@tromey.com>
7770
7771         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7772         NULL check.
7773
7774 2019-06-25  Tom Tromey  <tom@tromey.com>
7775
7776         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7777         Inline constructor.  Add initializers for members.
7778         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7779         constructors; now inline in class.
7780
7781 2019-06-25  Tom Tromey  <tom@tromey.com>
7782
7783         * tui/tui-regs.c (tui_show_registers): Update.
7784         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7785         bool.
7786         * tui/tui-data.c (tui_data_window::clear_detail)
7787         (tui_data_window): Update.
7788
7789 2019-06-25  Tom Tromey  <tom@tromey.com>
7790
7791         * tui/tui-windata.c (tui_display_all_data)
7792         (tui_display_data_from_line, tui_display_data_from)
7793         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7794         Update.
7795         * tui/tui-regs.c (tui_last_regs_line_no)
7796         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7797         (tui_show_registers, tui_show_register_group)
7798         (tui_display_registers_from, tui_display_reg_element_at_line)
7799         (tui_display_registers_from_line, tui_check_register_values)
7800         (tui_reg_next, tui_reg_prev): Update.
7801         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7802         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7803         tui_data_window.
7804         (struct tui_win_info) <detail>: Remove.  Add new fields from
7805         tui_data_info.
7806         (TUI_DATA_WIN): Add cast.
7807         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7808         (~tui_data_window): Simplify.
7809
7810 2019-06-25  Tom Tromey  <tom@tromey.com>
7811
7812         * tui/tui-layout.c (show_source_disasm_command)
7813         (show_source_or_disasm_and_command): Update.
7814         * tui/tui-io.c (update_cmdwin_start_line)
7815         (tui_redisplay_readline): Update.
7816         * tui/tui-data.h (struct tui_command_info): Remove.
7817         (struct tui_win_info) <detail>: Remove command_info member.
7818         (struct tui_data_window) <start_line>: New member, from
7819         tui_command_info.
7820         (TUI_CMD_WIN): Add casts.
7821
7822 2019-06-25  Tom Tromey  <tom@tromey.com>
7823
7824         * tui/tui-winsource.c (tui_update_source_window)
7825         (tui_refill_source_window)
7826         (tui_source_window_base::do_scroll_horizontal)
7827         (tui_update_breakpoint_info, tui_set_exec_info_content)
7828         (tui_show_exec_info_content, tui_erase_exec_info_content)
7829         (tui_clear_exec_info_content): Update.
7830         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7831         Update.
7832         * tui/tui-win.c (make_invisible_and_set_new_height)
7833         (make_visible_with_new_height): Update.
7834         * tui/tui-source.c (tui_set_source_content)
7835         (tui_show_symtab_source): Update.
7836         * tui/tui-layout.c (extract_display_start_addr)
7837         (show_source_disasm_command, show_data)
7838         (make_source_or_disasm_window)
7839         (show_source_or_disasm_and_command): Update.
7840         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7841         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7842         "gdbarch".
7843         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7844         to tui_source_window_base.
7845         (struct tui_win_info) <detail>: Remove source_info member.
7846         (struct tui_source_window_base) <has_locator>: Inline.
7847         Move contents from tui_source_info; rename has_locator member to
7848         m_has_locator.
7849         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7850         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7851         header file.
7852         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7853         Simplify.
7854         (tui_free_all_source_wins_content): Cast to
7855         tui_source_window_base.
7856
7857 2019-06-25  Tom Tromey  <tom@tromey.com>
7858
7859         * tui/tui-win.c (make_invisible_and_set_new_height)
7860         (make_visible_with_new_height): Call has_locator method.
7861         * tui/tui-layout.c (show_source_disasm_command, show_data)
7862         (show_source_or_disasm_and_command): Update for bool change.
7863         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7864         (tui_win_info) <has_locator>: New method.
7865         (struct tui_source_window_base) <has_locator>: New method.
7866         (tui_win_has_locator): Don't declare.
7867         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7868         from tui_win_has_locator.
7869         (tui_source_window_base): Use false, not FALSE.
7870
7871 2019-06-25  Tom Tromey  <tom@tromey.com>
7872
7873         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7874         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7875         clear_detail method directly.
7876         (tui_clear_win_detail): Remove.
7877
7878 2019-06-25  Tom Tromey  <tom@tromey.com>
7879
7880         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7881         "this", not TUI_DISASM_WIN.
7882
7883 2019-06-25  Tom Tromey  <tom@tromey.com>
7884
7885         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7886         declare.
7887         * tui/tui-winsource.c
7888         (tui_source_window_base::do_scroll_horizontal): Rename from
7889         tui_horizontal_source_scroll.
7890         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7891         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7892         from tui_vertical_data_scroll.
7893         * tui/tui-win.h (tui_scroll): Don't declare.
7894         * tui/tui-win.c (tui_win_info::forward_scroll)
7895         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7896         (tui_win_info::right_scroll): Rename and update.
7897         (tui_scroll_forward_command, tui_scroll_backward_command)
7898         (tui_scroll_left_command, tui_scroll_right_command): Update.
7899         (tui_scroll): Remove.
7900         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7901         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7902         from tui_vertical_source_scroll.
7903         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7904         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7905         from tui_vertical_disassem_scroll.
7906         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7907         do_scroll_horizontal>: New methods.
7908         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7909         Likewise.
7910         (struct tui_source_window_base): Add do_scroll_horizontal.
7911         (struct tui_source_window, struct tui_disasm_window): Add
7912         do_scroll_vertical.
7913         (struct tui_data_window, struct tui_cmd_window): Add
7914         do_scroll_horizontal and do_scroll_vertical.
7915         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7916
7917 2019-06-25  Tom Tromey  <tom@tromey.com>
7918
7919         * tui/tui-data.h (struct tui_source_window_base): New struct.
7920         (struct tui_source_window): Derive from tui_source_window_base.
7921         (struct tui_disasm_window): New struct.
7922         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7923         from tui_source_window::clear_detail.
7924         (tui_source_window_base): Rename from tui_source_window.
7925         (~tui_source_window_base): Rename from ~tui_source_window.
7926         (tui_alloc_win_info): Create a tui_disasm_window.
7927
7928 2019-06-25  Tom Tromey  <tom@tromey.com>
7929
7930         * tui/tui-data.h (struct tui_source_window)
7931         (struct tui_data_window): Declare destructors.
7932         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7933         destructors.
7934         (tui_win_info): Simplify.
7935
7936 2019-06-25  Tom Tromey  <tom@tromey.com>
7937
7938         * tui/tui-winsource.c (tui_display_main)
7939         (tui_update_source_windows_with_addr)
7940         (tui_update_all_breakpoint_info): Update.
7941         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7942         (new_height_ok, parse_scrolling_args): Update.
7943         * tui/tui-stack.c (tui_show_frame_info): Update.
7944         * tui/tui-data.h (struct tui_list): Remove.
7945         (tui_source_windows): Return a reference to a std::vector.
7946         * tui/tui-data.c (source_windows): Now a std::vector.
7947         (tui_source_windows): Change return type.
7948         (tui_clear_source_windows): Rewrite.
7949         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7950         (tui_free_all_source_wins_content): Rewrite.
7951
7952 2019-06-25  Tom Tromey  <tom@tromey.com>
7953
7954         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7955         (struct tui_data_window, struct tui_cmd_window): Declare
7956         clear_detail method.
7957         * tui/tui-data.c (tui_source_window::clear_detail)
7958         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7959         methods.
7960         (tui_clear_win_detail): Simplify.
7961
7962 2019-06-25  Tom Tromey  <tom@tromey.com>
7963
7964         * tui/tui-layout.c (make_source_window, make_disasm_window)
7965         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7966         Return the new window.
7967         (show_source_disasm_command, show_data)
7968         (show_source_or_disasm_and_command): Update.
7969
7970 2019-06-25  Tom Tromey  <tom@tromey.com>
7971
7972         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7973         parameter.  Return the new window.
7974         (show_source_disasm_command): Update and remove NULL check.
7975         (show_source_or_disasm_and_command): Update.
7976
7977 2019-06-25  Tom Tromey  <tom@tromey.com>
7978
7979         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7980
7981 2019-06-25  Tom Tromey  <tom@tromey.com>
7982
7983         * tui/tui-data.h (struct tui_win_info): Make constructor
7984         protected.  Make destructor virtual.  Add initializers.
7985         (tui_source_window, tui_data_window, tui_cmd_window): New
7986         classes.
7987         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7988         constructor.  Add "type" parameter.
7989         (tui_source_window, tui_data_window, tui_cmd_window): New
7990         constructors.
7991         (tui_alloc_win_info): Instantiate the appropriate subclass.
7992
7993 2019-06-25  Tom Tromey  <tom@tromey.com>
7994
7995         * tui/tui-win.c (tui_resize_all): Use delete.
7996         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7997         destructor.
7998         (tui_free_window): Don't declare.
7999         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8000         Update.
8001
8002 2019-06-25  Tom Tromey  <tom@tromey.com>
8003
8004         * tui/tui-data.h (struct tui_win_info): Add constructor.
8005         * tui/tui-data.c (tui_alloc_win_info): Use new.
8006         (tui_free_window): Use delete.
8007
8008 2019-06-22  Tom Tromey  <tom@tromey.com>
8009
8010         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8011         declare.
8012         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8013
8014 2019-06-22  Tom Tromey  <tom@tromey.com>
8015
8016         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8017         declare.
8018         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8019
8020 2019-06-22  Tom de Vries  <tdevries@suse.de>
8021
8022         * dwarf2read.c (create_addrmap_from_aranges)
8023         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8024         instead of '%zu'.
8025
8026 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8027
8028         * dwarf2read.h (dwarf2_section_info_def): Remove.
8029         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8030         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8031         std::vector<dwarf2_section_info>.
8032         (struct dwo_file) <~dwo_file>: Remove.
8033         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8034         types field.
8035         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8036         (dwarf2_read_debug_names): Likewise.
8037         (create_debug_types_hash_table): Change parameter type to
8038         array_view, adjust code accordingly.
8039         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8040         (partial_die_info::fixup): Likewise.
8041         (determine_prefix): Likewise.
8042         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8043
8044 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8045
8046         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8047         gdb_bfd_ref_ptr.
8048         <~dwo_file>: Remove call to gdb_bfd_unref.
8049         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8050         gdb_bfd_ref_ptr::get.
8051
8052 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8053
8054         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8055         type to htab_up.
8056         * dwarf2read.c (struct dwo_file): Initialize fields.
8057         <~dwo_file>: New.
8058         (free_dwo_file): Remove, move content to ~dwo_file.
8059         (struct dwo_file_deleter): Remove.
8060         (dwo_file_up>: Remove custom deleter.
8061         (free_dwo_files): Remove.
8062         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8063         dwo_files.
8064         (process_skeletonless_type_units): Call unique_ptr::get.
8065         (allocate_dwo_file_hash_table): Add deleter to created hash
8066         table.  Change return type to htab_up.
8067         (lookup_dwo_file_slot): Don't memset dwo_file, call
8068         unique_ptr::get.
8069         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8070         (create_dwo_unit_in_dwp_v2): Likewise.
8071         (open_and_init_dwo_file): Likewise.
8072         (free_dwo_file_from_slot): Remove.
8073
8074 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8075
8076         * dwarf2read.h (struct dwarf2_section_info) <readin,
8077         is_virtual>: Change type to bool.
8078         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8079         true instead of 1.
8080
8081 2019-06-19  Tom Tromey  <tom@tromey.com>
8082
8083         * tui/tui-data.h (tui_init_content_element): Don't declare.
8084
8085 2019-06-19  Tom Tromey  <tom@tromey.com>
8086
8087         * tui/tui-data.h (tui_init_win_info): Don't declare.
8088
8089 2019-06-19  Tom de Vries  <tdevries@suse.de>
8090
8091         * dwarf2read.h (abstract_to_concrete): Change type to
8092         std::unordered_map<sect_offset, std::vector<sect_offset>,
8093         gdb::hash_enum<sect_offset>>.
8094
8095 2019-06-19  Tom Tromey  <tromey@adacore.com>
8096
8097         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8098         EVAL_AVOID_SIDE_EFFECTS specially.
8099
8100 2019-06-19  Tom Tromey  <tromey@adacore.com>
8101
8102         * source-cache.c (highlighter): New global.
8103         (source_cache::get_source_lines): Create a highlighter on demand.
8104
8105 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * defs.h (deprecated_interactive_hook): Delete declaration.
8108         * interps.c (clear_interpreter_hooks): Remove use of
8109         deprecated_interactive_hook.
8110         * top.c (deprecated_interactive_hook): Delete definition.
8111         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8112
8113 2019-06-18  Tom de Vries  <tdevries@suse.de>
8114
8115         PR gdb/24515
8116         * dwarf2read.h (abstract_to_concrete): Change type from
8117         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8118         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8119         * dwarf2read.c (read_variable): Update.
8120         (dwarf2_fetch_die_loc_sect_off): Update.
8121
8122 2019-06-17  Tom de Vries  <tdevries@suse.de>
8123
8124         PR gdb/24617
8125         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8126         accessing parent[parent_len - 1].
8127
8128 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8129
8130         PR gdb/24364
8131         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8132         call dtrace_process_dof with NULL dof.
8133
8134 2019-06-16  Tom de Vries  <tdevries@suse.de>
8135
8136         PR gdb/24445
8137         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8138
8139 2019-06-16  Tom Tromey  <tom@tromey.com>
8140
8141         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8142         (make_all_visible): Use address of member.
8143
8144 2019-06-16  Tom Tromey  <tom@tromey.com>
8145
8146         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8147         (tui_free_window, free_content, free_content_elements): Remove
8148         unnecessary cast.
8149         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8150         cast.
8151         * tui/tui-regs.c (tui_show_register_group)
8152         (tui_display_registers_from, tui_display_reg_element_at_line):
8153         Remove unnecessary cast.
8154
8155 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * linux-nat.c (normal_mask): Delete.
8158         (_initialize_linux_nat): Don't initialise normal_mask.
8159
8160 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8161
8162         PR gdb/24445
8163         * dwarf-index-write.h (write_psymtabs_to_index): Add
8164         dwz_basename parameter.
8165         * dwarf-index-write.c (write_gdbindex): Move file writing to
8166         write_gdbindex_1.  Change return type void.
8167         (assert_file_size): Move up, remove filename parameter.
8168         (write_gdbindex_1): New function.
8169         (write_debug_names): Change return type to void, call
8170         assert_file_size.
8171         (struct index_wip_file): New struct.
8172         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8173         file logic to index_wip_file.  Write index for dwz file if
8174         needed.
8175         (save_gdb_index_command): Pass basename of dwz file, if present.
8176         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8177         build-id of dwz file, if present.
8178         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8179         (dwarf2_get_dwz_file): Likewise.
8180         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8181         (dwarf2_get_dwz_file): Likewise.
8182
8183 2019-06-16  Tom Tromey  <tom@tromey.com>
8184
8185         * coffread.c (process_coff_symbol): Use xstrdup.
8186         * value.c (create_internalvar): Use xstrdup.
8187
8188 2019-06-16  Tom Tromey  <tom@tromey.com>
8189
8190         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8191         * breakpoint.c (stopin_command, stopat_command)
8192         (until_break_command, decode_location_default): Remove unnecessary
8193         cast.
8194         * utils.c (subset_compare): Remove unnecessary cast.
8195         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8196         cast.
8197         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8198         cast.
8199         * infcmd.c (path_command): Remove unnecessary cast.
8200         * coffread.c (decode_type): Remove unnecessary cast.
8201         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8202         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8203         * tui/tui-stack.c (tui_show_locator_content)
8204         (tui_show_frame_info): Remove unnecessary cast.
8205         * tui/tui-win.c (tui_scroll_forward_command)
8206         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8207         (parse_scrolling_args): Remove unnecessary cast.
8208         * tui/tui-data.c (init_win_info, tui_del_window)
8209         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8210         (free_content_elements): Remove unnecessary cast.
8211         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8212         unnecessary cast.
8213         * tui/tui-source.c (tui_set_source_content)
8214         (tui_vertical_source_scroll): Remove unnecessary cast.
8215         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8216         cast.
8217         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8218         * tui/tui-regs.c (tui_display_registers_from)
8219         (tui_display_register): Remove unnecessary cast.
8220         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8221         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8222         (make_visible): Remove unnecessary cast.
8223         * tui/tui-winsource.c (tui_erase_source_content)
8224         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8225         unnecessary cast.
8226         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8227         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8228         * stabsread.c (read_type, read_array_type, read_range_type):
8229         Remove unnecessary cast.
8230         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8231         (parse_symbol, parse_type, upgrade_type, parse_external)
8232         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8233         unnecessary cast.
8234         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8235
8236 2019-06-16  Tom Tromey  <tom@tromey.com>
8237
8238         * tui/tui-data.c (tui_alloc_generic_win_info)
8239         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8240         checks.
8241
8242 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8243             Andrew Burgess  <andrew.burgess@embecosm.com>
8244
8245         * f-typeprint.c (f_print_type): Don't return early for not
8246         associated or not allocated types.
8247         (f_type_print_varspec_suffix): Add print_rank parameter and print
8248         ranks of array types in case they dangling.
8249         (f_type_print_base): Add print_rank parameter.
8250
8251 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8252
8253         * NEWS: Mention new MI commands.
8254         * break-catch-throw.c (enum exception_event_kind): Move to
8255         breakpoint.h.
8256         (print_mention_exception_catchpoint): Output text as a single
8257         message.
8258         (catch_exception_command_1): Rename to...
8259         (catch_exception_event): ...this, make non-static, update header
8260         command, and change some parameter types.
8261         (catch_catch_command): Update for changes to
8262         catch_exception_command_1.
8263         (catch_throw_command): Likewise.
8264         (catch_rethrow_command): Likewise.
8265         * breakpoint.c (enum exception_event_kind): Delete.
8266         * breakpoint.h (enum exception_event_kind): Moved here from
8267         break-catch-throw.c.
8268         (catch_exception_event): Declare.
8269         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8270         (mi_cmd_catch_throw): New function.
8271         (mi_cmd_catch_rethrow): New function.
8272         (mi_cmd_catch_catch): New function.
8273         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8274         'catch-catch' entries.
8275         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8276         (mi_cmd_catch_rethrow): Declare.
8277         (mi_cmd_catch_catch): Declare.
8278
8279 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * annotate.c (annotate_source_line): Change return type to void,
8282         update implementation to match.
8283         * annotate.h (annotate_source_line): Change return type to void,
8284         update header comment.
8285         * stack.c (print_frame_info): Don't change what frame information
8286         is printed based on whether annotations are on or not.
8287
8288 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8289
8290         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8291         (annotate_source): Make static.
8292         (annotate_source_line): Moved from source.c and renamed from
8293         identify_source_line.  Update the return type.
8294         * annotate.h (annotate_source): Delete declaration.
8295         (annotate_source_line): Declaration moved from source.h, and
8296         renamed from identify_source_line.  Return type updated.
8297         * source.c (identify_source_line): Moved to annotate.c and renamed
8298         to annotate_source_line.
8299         (info_line_command): Remove check of annotation_level.
8300         * source.h (identify_source_line): Move declaration to annotate.h
8301         and rename to annotate_source_line.
8302         * stack.c: Add 'annotate.h' include.
8303         (print_frame_info): Remove check of annotation_level before
8304         calling annotate_source_line.
8305
8306 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * source-cache.c (source_cache::get_plain_source_lines): Use
8309         open_source_file_with_line_charpos instead of just
8310         open_source_file, remove call to find_source_lines.
8311         (source_cache::get_source_lines): Likewise.
8312         * source.c (find_source_lines): Make static.
8313         (get_filename_and_charpos): Renamed into...
8314         (open_source_file_with_line_charpos): ..this along with changes to
8315         return a scoped_fd, and some other minor clean ups.
8316         (identify_source_line): Use open_source_file_with_line_charpos.
8317         (search_command_helper): Use open_source_file_with_line_charpos
8318         instead of just open_source_file, remove call to
8319         find_source_lines.
8320         * source.h (open_source_file_with_line_charpos): Declare new
8321         function.
8322         (find_source_lines): Delete declaration.
8323
8324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * source.c (get_filename_and_charpos): Remove fullname
8327         parameter.
8328         (identify_source_line): Update call to get_filename_and_charpos.
8329
8330 2019-06-14  Tom Tromey  <tromey@adacore.com>
8331
8332         PR gdb/24502:
8333         * ui-style.h (skip_ansi_escape): Update comment.
8334         * ui-file.h (class no_terminal_escape_file): New class.
8335         * ui-file.c (no_terminal_escape_file::write)
8336         (no_terminal_escape_file::puts): New methods.
8337         * cli/cli-logging.c (handle_redirections): Use
8338         no_terminal_escape_file.
8339
8340 2019-06-14  Tom Tromey  <tromey@adacore.com>
8341
8342         * NEWS: Move convenience variable news above Python news.
8343
8344 2019-06-14  Tom Tromey  <tom@tromey.com>
8345
8346         * gnulib: Move directory to top-level.
8347         * configure.ac: Don't configure gnulib.
8348         * configure: Rebuild.
8349         * common/common-defs.h: Use new path to gnulib.
8350         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8351         (GNULIB_H): Remove.
8352         (INCGNU): Look in new gnulib location.
8353         (HFILES_NO_SRCDIR): Remove gnulib files.
8354         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8355         (generated_files): Remove GNULIB_H.
8356         ($(LIBGNU), all-lib): Remove targets.
8357         (distclean): Don't mention GNULIB_BUILDDIR.
8358         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8359
8360 2019-06-14  Tom Tromey  <tromey@adacore.com>
8361
8362         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8363         Warn if symbol file does not provide any symbols.
8364
8365 2019-06-14  Tom Tromey  <tromey@adacore.com>
8366
8367         * source.c (find_and_open_source): Respect basenames_may_differ.
8368
8369 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * annotate.c (annotate_breakpoints_invalid): Make use of
8372         scoped_restore_terminal_state.
8373         (annotate_frames_invalid): Likewise.
8374
8375 2019-06-14  Tom Tromey  <tromey@adacore.com>
8376
8377         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8378         allow assignment to an internalvar.
8379
8380 2019-06-14  Tom Tromey  <tromey@adacore.com>
8381
8382         * ada-lex.l: Allow "_" in attribute names.
8383
8384 2019-06-14  Tom Tromey  <tromey@adacore.com>
8385
8386         PR gdb/24653:
8387         * regcache.c (registers_changed): Don't call alloca.
8388         * top.c (execute_command): Don't call alloca.
8389
8390 2019-06-13  Pedro Alves  <palves@redhat.com>
8391
8392         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8393         'expression'.  When parsing an expression, error out if there's
8394         junk after "unlimited".
8395         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8396         (do_set_command): Adjust calls to is_unlimited_literal.
8397
8398 2019-06-13  Pedro Alves  <palves@redhat.com>
8399
8400         * compile/compile.c (make_compile_options_def_group): Add braces
8401         around array_view initializer.
8402         * thread.c (make_thread_apply_all_options_def_group)
8403         (make_thread_apply_all_options_def_group): Likewise.
8404
8405 2019-06-13  Pedro Alves  <palves@redhat.com>
8406
8407         * NEWS (New commands): Mention "maint test-options
8408         require-delimiter", "maint test-options unknown-is-error", "maint
8409         test-options unknown-is-operand" and "maint show
8410         test-options-completion-result".
8411         (New command options, command completion): New section.
8412         (Completion improvements): New section.
8413         Mention that you can abbreviate "unlimited".
8414
8415 2019-06-13  Pedro Alves  <palves@redhat.com>
8416
8417         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8418         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8419         * unittests/cli-utils-selftests.c (test_parse_flags)
8420         (test_parse_flags_qcs): Delete.
8421         (test_cli_utils): Don't call deleted functions.
8422
8423 2019-06-13  Pedro Alves  <palves@redhat.com>
8424
8425         * thread.c: Include "cli/cli-option.h".
8426         (tp_array_compar_ascending): Global.
8427         (tp_array_compar): Delete function.
8428         (tp_array_compar_ascending, tp_array_compar_descending): New
8429         functions.
8430         (ascending_option_def, qcs_flag_option_def)
8431         (thr_qcs_flags_option_defs)
8432         (make_thread_apply_all_options_def_group)
8433         (make_thread_apply_options_def_group): New.
8434         (thread_apply_all_command): Use gdb::option::process_options.
8435         (thread_apply_command_completer)
8436         (thread_apply_all_command_completer): New.
8437         (thread_apply_command): Use gdb::option::process_options.
8438         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8439         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8440         to generate help text of "thread apply".  Adjust "taas"'s help.
8441         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8442         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8443
8444 2019-06-13  Pedro Alves  <palves@redhat.com>
8445
8446         * thread.c (thread_apply_command): Check for invalid TID with
8447         isdigit instead of !isalpha.
8448
8449 2019-06-13  Pedro Alves  <palves@redhat.com>
8450
8451         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8452         (validate_flags_qcs): New.
8453         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8454         (validate_flags_qcs): Declare.
8455         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8456         (make_frame_apply_options_def_group): New.
8457         (frame_apply_command_count): Process options with
8458         gdb::option::process_options.
8459         (frame_apply_completer): New.
8460         (frame_apply_level_completer, frame_apply_all_completer)
8461         (frame_apply_completer): New.
8462         (_initialize_stack): Update help of "frame apply", "frame apply
8463         level", "frame apply all" and "faas" to mention supported options
8464         and install command completers.
8465         * stack.h (frame_apply_all_completer): Declare.
8466         * thread.c: Include "stack.h".
8467         (tfaas_command): Add "--".
8468         (_initialize_thread): Update help "tfaas" to mention supported
8469         options and install command completer.
8470
8471 2019-06-13  Pedro Alves  <palves@redhat.com>
8472
8473         * completer.c (complete_nested_command_line): New.
8474         (gdb_completion_word_break_characters_throw): Add assertion.
8475         * completer.h (complete_nested_command_line): Declare.
8476
8477 2019-06-13  Pedro Alves  <palves@redhat.com>
8478
8479         * stack.c (parse_backtrace_qualifiers): New.
8480         (backtrace_command): Use it.
8481         (backtrace_command_completer): Complete on qualifiers.
8482
8483 2019-06-13  Pedro Alves  <palves@redhat.com>
8484
8485         * frame.c: Include "cli/cli-option.h.
8486         (user_set_backtrace_options): New.
8487         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8488         Delete.
8489         (get_prev_frame): Adjust.
8490         (boolean_option_def, uinteger_option_def)
8491         (set_backtrace_option_defs): New.
8492         (_initialize_frame): Adjust and use
8493         gdb::option::add_setshow_cmds_for_options to install "set
8494         backtrace past-main" and "set backtrace past-entry".
8495         * frame.h: Include "cli/cli-option.h".
8496         (struct frame_print_options): Forward declare.
8497         (print_frame_arguments_all, print_frame_arguments_scalars)
8498         (print_frame_arguments_none): Declare.
8499         (print_entry_values): Delete declaration.
8500         (struct frame_print_options, user_frame_print_options): New.
8501         (struct set_backtrace_options): New.
8502         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8503         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8504         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8505         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8506         (list_args_or_locals): Add frame_print_options parameter.
8507         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8508         * python/py-framefilter.c (enumerate_args): Pass down
8509         USER_FRAME_PRINT_OPTIONS.
8510         * stack.c: Include "cli/cli-option.h".
8511         (print_frame_arguments_all, print_frame_arguments_scalars)
8512         (print_frame_arguments_none): Declare.
8513         (print_raw_frame_arguments, print_entry_values): Delete.
8514         (user_frame_print_options): New.
8515         (boolean_option_def, enum_option_def, frame_print_option_defs):
8516         New.
8517         (struct backtrace_cmd_options): New.
8518         (bt_flag_option_def): New.
8519         (backtrace_command_option_defs): New.
8520         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8521         (print_frame_arg, read_frame_arg, print_frame_args)
8522         (print_frame_info, print_frame): Add frame_print_options parameter
8523         and use it.
8524         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8525         (backtrace_command_1): Add frame_print_options and
8526         backtrace_cmd_options parameters and use them.
8527         (make_backtrace_options_def_group): New.
8528         (backtrace_command): Process command options with
8529         gdb::option::process_options.
8530         (backtrace_command_completer): New.
8531         (_initialize_stack): Extend "backtrace"'s help to mention
8532         supported options.  Install completer for "backtrace".
8533         Install some settings commands with add_setshow_cmds_for_options.
8534
8535 2019-06-13  Pedro Alves  <palves@redhat.com>
8536
8537         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8538         and that "set/show print raw frame-arguments" are now deprecated.
8539
8540         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8541         command.
8542         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8543         * stack.c (_initialize_stack): Install "set/show print
8544         raw-frame-arguments", and deprecate "set/show print raw
8545         frame-arguments".
8546         * valprint.c (_initialize_valprint): Deprecate "set/show print
8547         raw".
8548
8549 2019-06-13  Pedro Alves  <palves@redhat.com>
8550
8551         * compile/compile.c (struct compile_options): New.
8552         (compile_flag_option_def, compile_command_option_defs)
8553         (make_compile_options_def_group): New.
8554         (compile_file_command): Handle options with
8555         gdb::option::process_options.
8556         (compile_file_command_completer): New function.
8557         (compile_code_command): Handle options with
8558         gdb::option::process_options.
8559         (compile_code_command_completer): New function.
8560         (_initialize_compiler): Install completers for "compile code" and
8561         "compile file".  Mention available options in "compile code" and
8562         "compile code"'s help.
8563         * completer.c (advance_to_completion_word): New, factored out from
8564         ...
8565         (advance_to_expression_complete_word_point): ... this.
8566         (advance_to_filename_complete_word_point): New.
8567         * completer.h (advance_to_filename_complete_word_point): New
8568         declaration.
8569
8570 2019-06-13  Pedro Alves  <palves@redhat.com>
8571
8572         * compile/compile.c: Include "cli/cli-option.h".
8573         (compile_print_value): Scope data pointer is now a
8574         value_print_options pointer; adjust.
8575         (compile_print_command): Process options.  Scope data pointer is
8576         now a value_print_options pointer; adjust.
8577         (_initialize_compile): Update "compile print"'s help to include
8578         supported options.  Install a completer for "compile print".
8579         * cp-valprint.c (show_vtblprint, show_objectprint)
8580         (show_static_field_print): Delete.
8581         (_initialize_cp_valprint): Don't install "set print
8582         static-members", "set print vtbl", "set print object" here.
8583         * printcmd.c: Include "cli/cli-option.h" and
8584         "common/gdb_optional.h".
8585         (print_command_parse_format): Rework to fill in a
8586         value_print_options instead of a format_data.
8587         (print_value): Change parameter type from format_data pointer to
8588         value_print_options reference.  Adjust.
8589         (print_command_1): Process options.  Adjust to pass down a
8590         value_print_options.
8591         (print_command_completer): New.
8592         (_initialize_printcmd): Install print_command_completer as
8593         handle_brkchars completer for the "print" command.  Update
8594         "print"'s help to include supported options.
8595         * valprint.c: Include "cli/cli-option.h".
8596         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8597         here from cp-valprint.c.
8598         (boolean_option_def, uinteger_option_def)
8599         (value_print_option_defs, make_value_print_options_def_group):
8600         New.  Use gdb::option::add_setshow_cmds_for_options to install
8601         "set print elements", "set print null-stop", "set print repeats",
8602         "set print pretty", "set print union", "set print array", "set
8603         print address", "set print symbol", "set print array-indexes".
8604         * valprint.h: Include <string> and "cli/cli-option.h".
8605         (make_value_print_options_def_group): Declare.
8606         (print_value): Change parameter type from format_data pointer to
8607         value_print_options reference.
8608         (print_command_completer): Declare.
8609
8610 2019-06-13  Pedro Alves  <palves@redhat.com>
8611
8612         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8613         (COMMON_SFILES): Add maint-test-settings.c.
8614         * cli/cli-decode.c (boolean_enums): New global, factored out from
8615         ...
8616         (add_setshow_boolean_cmd): ... here.
8617         * cli/cli-decode.h (boolean_enums): Declare.
8618         * cli/cli-option.c: New file.
8619         * cli/cli-option.h: New file.
8620         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8621         factored out from ...
8622         (parse_cli_boolean_value(const char *)): ... this.
8623         (is_unlimited_literal): Change parameter type to pointer to
8624         pointer.  Adjust and advance ARG pointer.
8625         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8626         (parse_cli_var_enum): New, factored out from ...
8627         (do_set_command): ... this.  Adjust.
8628         * cli/cli-setshow.h (parse_cli_boolean_value)
8629         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8630         (parse_cli_var_enum): Declare.
8631         * cli/cli-utils.c: Include "cli/cli-option.h".
8632         (get_ulongest): New.
8633         * cli/cli-utils.h (get_ulongest): Declare.
8634         (check_for_argument): New overloads.
8635         * maint-test-options.c: New file.
8636
8637 2019-06-13  Pedro Alves  <palves@redhat.com>
8638
8639         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8640         parse a range if "-" is at the end of the string.
8641
8642 2019-06-13  Pedro Alves  <palves@redhat.com>
8643
8644         * cli/cli-setshow.c (parse_auto_binary_operation)
8645         (parse_cli_boolean_value): Don't allow "o".
8646
8647 2019-06-13  Pedro Alves  <palves@redhat.com>
8648
8649         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8650         * NEWS: Mention maint test-settings KIND.
8651         * maint-test-settings.c: New file.
8652
8653 2019-06-13  Pedro Alves  <palves@redhat.com>
8654
8655         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8656         completer.
8657         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8658         "set" completers.
8659
8660 2019-06-13  Pedro Alves  <palves@redhat.com>
8661
8662         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8663         after item.
8664
8665 2019-06-13  Pedro Alves  <palves@redhat.com>
8666
8667         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8668
8669 2019-06-13  Pedro Alves <palves@redhat.com>
8670
8671         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8672         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8673         call.
8674         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8675         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8676         calls.
8677         (check_for_argument): Skip spaces after argument.
8678
8679 2019-06-13  Pedro Alves  <palves@redhat.com>
8680
8681         * thread.c (thread_apply_command): Adjust TID parsing.
8682         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8683         detected before end of string.
8684         (tid_is_in_list): Error out if LIST is invalid.
8685
8686 2019-06-13  Pedro Alves  <palves@redhat.com>
8687
8688         * completer.c (complete_line_internal_1): Rewind completion word
8689         point.
8690         (completion_tracker::advance_custom_word_point_by): Change
8691         parameter type to int.
8692         * completer.h (completion_tracker::advance_custom_word_point_by):
8693         Likewise.
8694
8695 2019-06-13  Pedro Alves  <palves@redhat.com>
8696
8697         * completer.c (advance_to_completion_word): Handle delimiters.
8698
8699 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8700
8701         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8702
8703 2019-06-11  Tom Tromey  <tom@tromey.com>
8704
8705         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8706         (xmalloc_failed): Move to alloc.c.
8707         * alloc.c: New file.
8708         * Makefile.in (COMMON_SFILES): Add alloc.c.
8709
8710 2019-06-11  Tom Tromey  <tom@tromey.com>
8711
8712         * nat/linux-waitpid.c: Don't include server.h.
8713         (linux_debug): Remove.
8714         (my_waitpid): Update.
8715
8716 2019-06-11  Tom Tromey  <tromey@adacore.com>
8717
8718         * infcall.c (_initialize_infcall): Remove trailing newline from
8719         help.
8720         * user-regs.c (_initialize_user_regs): Remove trailing newline
8721         from help.
8722         * typeprint.c (_initialize_typeprint): Remove trailing newline
8723         from help.
8724         * reverse.c (_initialize_reverse): Remove trailing newlines from
8725         help.
8726         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8727         from help.
8728         * language.c (add_set_language_command): Remove trailing newline
8729         from help.
8730         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8731         help.
8732         * disasm.c (_initialize_disasm): Remove trailing newline from
8733         help.
8734         * top.c (init_main): Remove trailing newline from help.
8735         * interps.c (_initialize_interpreter): Remove trailing newline
8736         from help.
8737         * btrace.c (_initialize_btrace): Remove trailing newlines from
8738         help.
8739         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8740         from help.
8741         * python/python.c (_initialize_python): Remove trailing newline
8742         from help.
8743         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8744         help.
8745         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8746         from help.  Reformat some text.
8747         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8748         from help.
8749         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8750         newline from help.
8751
8752 2019-06-11  Tom Tromey  <tromey@adacore.com>
8753
8754         * darwin-nat.c (darwin_decode_exception_message)
8755         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8756
8757 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8758
8759         * valops.c (value_slice): Check for not allocated or not
8760         associated values.
8761
8762 2019-06-10  Tom de Vries  <tdevries@suse.de>
8763
8764         PR gdb/24618
8765         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8766         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8767         invalid.
8768
8769 2019-06-10  Tom de Vries  <tdevries@suse.de>
8770
8771         PR gdb/24611
8772         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8773         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8774
8775 2019-06-10  Tom de Vries  <tdevries@suse.de>
8776
8777         PR symtab/24545
8778         * symtab.c (struct demangled_name_entry): Add language field.
8779         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8780         static minimal symbol".  Set and use language field.
8781
8782 2019-06-10  Tom Tromey  <tromey@adacore.com>
8783
8784         * ada-lang.c (_initialize_ada_language): Update help text.
8785
8786 2019-06-10  Tom Tromey  <tromey@adacore.com>
8787
8788         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8789         with a newline.
8790         * guile/guile.c (handle_boot_error): Don't end warning with a
8791         newline.
8792         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8793         warning with a newline.
8794         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8795         newline.
8796         (s12z_frame_cache): Likewise.
8797         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8798         a newline.
8799         * solib-svr4.c (disable_probes_interface): Don't end warning with
8800         a newline.
8801         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8802         newline.
8803         * python/python.c (do_finish_initialization): Don't end warning
8804         with a newline.
8805
8806 2019-06-10  Tom Tromey  <tom@tromey.com>
8807
8808         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8809         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8810         gdbpy_enter.
8811
8812 2019-06-10  Tom Tromey  <tromey@adacore.com>
8813
8814         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8815         data.
8816         (elf_new_init): Don't call stabsread_new_init.
8817         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8818         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8819         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8820
8821 2019-06-10  Tom de Vries  <tdevries@suse.de>
8822
8823         PR symtab/16264
8824         PR symtab/24517
8825         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8826
8827 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8828
8829         * source.c (find_and_open_source): Also rewrite relative file
8830         names.
8831
8832 2019-04-26  Amos Bird  <amosbird@gmail.com>
8833
8834         * annotate.c (annotate_thread_exited): Add "thread-exited"
8835         annotation.
8836
8837 2019-06-06  Tom Tromey  <tromey@adacore.com>
8838
8839         * maint.h (class scoped_command_stats): Use
8840         DISABLE_COPY_AND_ASSIGN.
8841         <print_time>: New method.
8842         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8843         print_time.
8844         (scoped_command_stats::print_time): New method.
8845
8846 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8849         instructions of lengths 6 or 8 bytes.
8850
8851 2019-06-04  Pedro Alves  <palves@redhat.com>
8852
8853         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8854
8855         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8856         * breakpoint.c (condition_completer): Likewise.
8857         * cli/cli-dump.c (scan_expression): Likewise.
8858         * common/filestuff.c (mkdir_recursive): Likewise.
8859         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8860         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8861         (gdb_abspath): Likewise.
8862         * compile/compile-cplus-types.c
8863         (compile_cplus_instance::decl_name): Likewise.
8864         * completer.c (complete_explicit_location):
8865         (signal_completer, reg_or_group_completer_1): Likewise.
8866         * cp-support.c (cp_remove_params_if_any): Likewise.
8867         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8868         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8869         * infcmd.c (strip_bg_char): Likewise.
8870         * linespec.c (copy_token_string): Likewise.
8871         * mi/mi-main.c (output_cores): Likewise.
8872         * psymtab.c (psymtab_search_name):
8873         * symfile.c (test_set_ext_lang_command): Likewise.
8874         * target.c (target_fileio_read_stralloc): Likewise.
8875         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8876         * value.c (complete_internalvar): Likewise.
8877
8878 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8879
8880         Add objfile property to gdb.Type.
8881         * NEWS: Mention Python API addition.
8882         * python/py-type.c (typy_get_objfile): New method.
8883
8884 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8885
8886         * NEWS: Mention the new set|show style [title|highlight].
8887         Mention changes to "show style", "help" and "apropos".
8888
8889 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8890
8891         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8892         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8893         instead of print_help_for_command.
8894         (print_doc_of_command): New function.
8895         (help_list): Add 'apropos -v word' suggestion.
8896         (print_help_for_command): Style the command name using title style.
8897         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8898         (_initialize_cli_cmds): Describe -v in apropos_command help.
8899
8900 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8901
8902         * cli/cli-style.h (cli_style_option): Add name in constructor,
8903         add m_name class member, add constructor with intensity,
8904         add name class function.
8905         (cli_style_option::add_setshow_commands): Remove name argument.
8906         (highlight_style, title_style): New styles.
8907         * cli/cli-style.c (do_show): New function that shows a style
8908         characteristic styling the style name with itself.
8909         (set_style_name): New function.
8910         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8911         Update all callers according to the changes in cli/cli-style.h.
8912         * utils.h (fputs_highlighted): New function.
8913         * utils.c (fputs_highlighted): Likewise.
8914
8915 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8916
8917         * NEWS: Mention new pipe command and new convenience variables.
8918
8919 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8920
8921         * cli/cli-cmds.c (pipe_command): New function.
8922         (_initialize_cli_cmds): Call add_com for pipe_command.
8923         Define | as an alias for pipe.
8924         (exit_status_set_internal_vars): New function.
8925         (shell_escape): Call exit_status_set_internal_vars.
8926         cli/cli-decode.c (find_command_name_length): Recognize | as
8927         a single character command.
8928
8929 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8930
8931         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8932         top.c (execute_command_to_ui_file): New function, mostly a copy
8933         of execute_command_to_string.
8934         (execute_command_to_string): Implement by calling
8935         execute_command_to_ui_file.
8936
8937 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8938
8939         * top.h (saved_command_line): Remove declaration.
8940         * top.c (previous_saved_command_line, previous_repeat_arguments):
8941         New variables.
8942         (saved_command_line): Make static, define together with other
8943         'repeat variables'.
8944         (dont_repeat): Clear repeat_arguments.
8945         (repeat_previous, get_saved_command_line, save_command_line):
8946         New functions.
8947         (gdb_init): Initialize saved_command_line
8948         and previous_saved_command_line.
8949         * main.c (captured_main_1): Remove saved_command_line initialization.
8950         * event-top.c (handle_line_of_input): Update to use
8951         the new 'repeat' related functions instead of direct access to
8952         saved_command_line.
8953         * command.h (repeat_previous, get_saved_command_line,
8954         save_command_line): New declarations.
8955         (dont_repeat): Add comment.
8956
8957 2019-05-30  Tom Tromey  <tromey@adacore.com>
8958
8959         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8960         Fix comment.
8961         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8962
8963 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8964
8965         PR cli/24587
8966         * completer.c (complete): Initialize variable word.
8967
8968 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8969
8970         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8971         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8972         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8973         'body' is NULL to the outter 'if', protecting the '!is_define'
8974         situation as well.
8975
8976 2019-05-29  Tom Tromey  <tromey@adacore.com>
8977
8978         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8979         (dwarf_unknown): New function.
8980         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8981         (dwarf_type_encoding_name): Use dwarf_unknown.
8982
8983 2019-05-29  Tom Tromey  <tromey@adacore.com>
8984
8985         PR c++/20020:
8986         * cp-valprint.c (cp_print_value_fields): Call
8987         cp_print_static_field inside "try".
8988
8989 2019-05-29  Tom Tromey  <tromey@adacore.com>
8990
8991         * inflow.c (struct terminal_info): Add default operator=.
8992         * configure: Rebuild.
8993         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8994         -Wdeprecated-copy-dtor, -Wredundant-move.
8995
8996 2019-05-29  Tom Tromey  <tromey@adacore.com>
8997
8998         * NEWS: Add entry.
8999         * infcmd.c (print_return_value_1): Handle finish_print
9000         option.
9001         (show_print_finish): New function.
9002         (_initialize_infcmd): Add "set/show print finish" commands.
9003         * valprint.c (user_print_options): Initialize new member.
9004         * valprint.h (struct value_print_options) <finish_print>: New
9005         member.
9006
9007 2019-05-28  Tom Tromey  <tromey@adacore.com>
9008
9009         * ada-lang.c (ada_remove_Xbn_suffix)
9010         (find_old_style_renaming_symbol)
9011         (parse_old_style_renaming): Remove.
9012         (ada_find_renaming_symbol): Don't call
9013         find_old_style_renaming_symbol.
9014         (ada_is_renaming_symbol): Rename from
9015         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9016         bool.  Now static.
9017         (ada_read_var_value): Update and simplify.
9018         * ada-exp.y (write_var_or_type): Remove old code.
9019
9020 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9021
9022         PR gdb/25010
9023         * event-top.c: Remove include comment.
9024         * inflow.c (class scoped_ignore_sigttou): Move from here...
9025         * inflow.h (class scoped_ignore_sigttou): ...to here.
9026         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9027         * top.c:  Remove include comment.
9028
9029 2019-05-27  Tom Tromey  <tom@tromey.com>
9030
9031         * NEWS: Fix typo.
9032
9033 2019-05-22  Tom Tromey  <tromey@adacore.com>
9034
9035         * target.c (target_follow_exec): Constify parameter.
9036         * target-delegates.c: Rebuild.
9037         * remote.c (remote_target::follow_exec): Constify parameter.
9038         * infrun.c (follow_exec): Constify parameter.
9039         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9040         (target_follow_exec): Likewise.
9041
9042 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9043
9044         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9045         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9046
9047 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9048
9049         * NEWS: Add debugredirect and testsuite sections.
9050
9051 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9052
9053         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9054         target descriptions using exclusively floating point register name
9055         aliases.
9056
9057 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9058
9059         PR gdb/18644:
9060         * f-lang.c (build_fortran_types): Handle the case where
9061         gdbarch_floatformat_for_type returns a nullptr.
9062
9063 2019-05-21  Tom de Vries  <tdevries@suse.de>
9064
9065         PR cli/24587
9066         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9067
9068 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9069
9070         PR gdb/18644:
9071         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9072         16-byte floats.
9073         * i386-tdep.c (i386_floatformat_for_type): Use
9074         floatformats_ia64_quad for the 16-byte floating point component
9075         within a fortran 32-byte complex number.
9076
9077 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9078
9079         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9080         delete default constructor.
9081         (find_partial_die): Update to return const struct.
9082         (partial_die_parent_scope): Move variable declaration into scope
9083         of its use and change its type to auto.
9084         (guess_partial_die_structure_name): Likewise.
9085         (partial_die_info::fixup): Likewise.
9086
9087 2019-05-17  Tom Tromey  <tromey@adacore.com>
9088
9089         * source.c (find_and_open_source): Remove cast.
9090
9091 2019-05-17  Tom Tromey  <tromey@adacore.com>
9092
9093         * annotate.c (annotate_source): Make "filename" const.
9094         * annotate.h (annotate_source): Use const.
9095
9096 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9097
9098         * disasm.c (set_disassembler_options): Send errors to stderr.
9099
9100 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9101
9102         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9103         (cli_interp_base::set_logging): Check debug_redirect.
9104         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9105         * cli/cli-logging.c (debug_redirect): Add static variable.
9106         (pop_output_files): Add default param.
9107         (handle_redirections): Print debug setting.
9108         (show_logging_command): Likewise.
9109         (_initialize_cli_logging): Add debugredirect command.
9110         * interps.c (current_interp_set_logging): Add debug_redirect
9111         parameter.
9112         * interps.h (set_logging): Add debug_redirect parameter.
9113         (current_interp_set_logging): Likewise.
9114         * mi/mi-common.h: Likewise.
9115         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9116
9117 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9118             Tom Tromey  <tromey@adacore.com>
9119
9120         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9121         directly.
9122         * cli/cli-interp.h (make_logging_output): Remove declaration.
9123         * cli/cli-logging.c (make_logging_output): Remove function.
9124         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9125         directly.
9126         * ui-file.c (tee_file::tee_file): Remove bools.
9127         (tee_file::~tee_file): Remove deletes.
9128         * ui-file.h (tee_file): Remove bools.
9129
9130 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9131
9132         * mi/mi-cmds.h (mi_cmd_complete): New function.
9133         * mi/mi-main.c (mi_cmd_complete): Likewise.
9134         * mi/mi-cmds.c: Define new MI command -complete.
9135         * NEWS: Mention new -complete command.
9136
9137 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9138
9139         * completer.h (complete): New function.
9140         * completer.c (complete): Likewise.
9141         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9142         function defined in completer.h.
9143
9144 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9145
9146         * MAINTAINERS (Write After Approval): Add myself.
9147
9148 2019-05-17  Tom de Vries  <tdevries@suse.de>
9149
9150         PR gdb/24094
9151         * dwarf2read.c (struct cu_partial_die_info): New struct.
9152         (find_partial_die): Return cu_partial_die_info.
9153         (partial_die_parent_scope, guess_partial_die_structure_name)
9154         (partial_die_info::fixup): Handle new return type of find_partial_die.
9155
9156 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9157
9158         PR breakpoints/24541
9159         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9160         "std::string", simplifying the algorithm.
9161
9162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9163
9164         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9165         (stap_static_probe_ops::get_probes): Likewise.
9166
9167 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9168
9169         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9170         '-')" and "else if".
9171         (stap_parse_single_operand): Join checks for
9172         "gdbarch_stap_parse_special_token_p" and
9173         "gdbarch_stap_parse_special_token" in the same "if" statement.
9174         Invert check when verifying for operation on register
9175         displacement.
9176
9177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9178
9179         * stap-probe.c (stap_get_opcode): Update comment.
9180         (stap_get_expected_argument_type): Likewise.
9181         (handle_stap_probe): Likewise.
9182
9183 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9184
9185         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9186         return type to 'bool'.  Adjust comment.  Use 'bool' when
9187         appropriate.
9188         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9189         * stap-probe.c (stap_parse_argument_1): Likewise.
9190         (stap_is_operator): Likewise.
9191         (stap_is_generic_prefix): Likewise.
9192         (stap_is_register_prefix): Likewise.
9193         (stap_is_register_indirection_prefix): Likewise.
9194         (stap_is_integer_prefix): Likewise.
9195         (stap_generic_check_suffix): Likewise.
9196         (stap_check_integer_suffix): Likewise.
9197         (stap_check_register_suffix): Likewise.
9198         (stap_check_register_indirection_suffix): Likewise.
9199         (stap_parse_register_operand): Likewise.
9200         (stap_parse_single_operand): Likewise.
9201         (stap_parse_argument_1): Likewise.
9202         (stap_probe::get_argument_count): Likewise.
9203         (stap_is_operator): Likewise.
9204
9205 2019-05-16  Tom Tromey  <tromey@adacore.com>
9206
9207         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9208         keyword to foreach.
9209
9210 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9211
9212         * linux-thread-db.c (try_thread_db_load_1): Change return type
9213         to bool.
9214         (try_thread_db_load): Likewise.
9215         (try_thread_db_load_from_pdir_1): Likewise.
9216         (try_thread_db_load_from_pdir): Likewise.
9217         (try_thread_db_load_from_sdir): Likewise.
9218         (try_thread_db_load_from_dir): Likewise.
9219         (thread_db_load_search): Likewise.
9220         (has_libpthread): Likewise.
9221         (thread_db_load): Likewise.
9222
9223 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9224
9225         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9226         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9227         NULL, and complain/return if that's the case.
9228
9229 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9230
9231         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9232         (advance, posn, abstract_read_memory): New functions.
9233         [struct mem_read_abstraction]: New struct.
9234         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9235
9236 2019-05-14  Tom Tromey  <tromey@adacore.com>
9237
9238         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9239         value is not lval_memory.
9240
9241 2019-05-14  Tom Tromey  <tromey@adacore.com>
9242
9243         * solib.c (info_sharedlibrary_command): Style the file name.
9244
9245 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9246
9247         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9248         (aarch64_vnv_type): Likewise.
9249         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9250         * common/tdesc.c: Likewise.
9251         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9252         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9253         * features/aarch64-fpu.xml: Add ieee half view.
9254         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9255         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9256         * gdbtypes.h (struct builtin_type): Likewise.
9257         (struct objfile_type): Likewise.
9258
9259 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9260
9261         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9262         typo.
9263         * location.h (string_to_event_location): Likewise.
9264
9265 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9266
9267         GDB 8.3 released.
9268
9269 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9270
9271         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9272         New variable declaration.
9273         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9274         New variable.
9275         (print_one_breakpoint): Use ui_out::test_flags and new global
9276         variable to compute use_fixed_output.
9277         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9278         Remove.
9279         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9280         (mi_multi_location_breakpoint_output_fixed): Remove.
9281         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9282         new variable.
9283         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9284         fix_multi_location_breakpoint_output flag if version >= 3.
9285         * ui-out.h (enum ui_out_flag)
9286         <fix_multi_location_breakpoint_output>: New enumerator.
9287
9288 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9289
9290         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9291
9292 2019-05-10  Tom Tromey  <tromey@adacore.com>
9293
9294         * ada-lang.c (catch_ada_completer): New function.
9295         (_initialize_ada_language): Use it.
9296
9297 2019-05-10  Tom Tromey  <tromey@adacore.com>
9298
9299         * thread.c (print_thread_info): Make "requested_threads" const.
9300         * gdbthread.h (print_thread_info): Make "requested_threads"
9301         const.
9302         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9303         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9304
9305 2019-05-08  Tom Tromey  <tom@tromey.com>
9306
9307         * gdbtypes.c (objfile_type_data): Change type.
9308         (objfile_type, _initialize_gdbtypes): Update.
9309
9310 2019-05-08  Tom Tromey  <tom@tromey.com>
9311
9312         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9313         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9314         (_initialize_dwarf2_frame): Update.
9315
9316 2019-05-08  Tom Tromey  <tom@tromey.com>
9317
9318         * objc-lang.c (objc_objfile_data): Change type.
9319         (find_methods): Update.
9320         (_initialize_objc_lang): Remove.
9321
9322 2019-05-08  Tom Tromey  <tom@tromey.com>
9323
9324         * stabsread.c (rs6000_builtin_type_data): Change type.
9325         (rs6000_builtin_type, _initialize_stabsread): Update.
9326
9327 2019-05-08  Tom Tromey  <tom@tromey.com>
9328
9329         * mips-tdep.c (mips_pdr_data): Remove.
9330         (_initialize_mips_tdep): Update.
9331
9332 2019-05-08  Tom Tromey  <tom@tromey.com>
9333
9334         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9335         (hppa_init_objfile_priv_data, read_unwind_info)
9336         (find_unwind_entry, _initialize_hppa_tdep): Update.
9337
9338 2019-05-08  Tom Tromey  <tom@tromey.com>
9339
9340         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9341         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9342         on obstack.
9343         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9344
9345 2019-05-08  Tom Tromey  <tom@tromey.com>
9346
9347         * mdebugread.c (basic_type_data): Change type.
9348         (basic_type, _initialize_mdebugread): Update.
9349
9350 2019-05-08  Tom Tromey  <tom@tromey.com>
9351
9352         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9353
9354 2019-05-08  Tom Tromey  <tom@tromey.com>
9355
9356         * nto-tdep.c (nto_inferior_data_reg): Change type.
9357         (nto_inferior_data): Update.
9358         (nto_inferior_data_cleanup, nto_new_inferior_data)
9359         (_initialize_nto_tdep): Remove.
9360         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9361
9362 2019-05-08  Tom Tromey  <tom@tromey.com>
9363
9364         * ada-lang.c (struct ada_inferior_data): Add initializers.
9365         (ada_inferior_data): Change type.
9366         (ada_inferior_data_cleanup): Remove.
9367         (get_ada_inferior_data, ada_inferior_exit)
9368         (struct ada_pspace_data): Add initializers, destructor.
9369         (ada_pspace_data_handle): Change type.
9370         (get_ada_pspace_data): Update.
9371         (ada_pspace_data_cleanup): Remove.
9372
9373 2019-05-08  Tom Tromey  <tom@tromey.com>
9374
9375         * coffread.c (struct coff_symfile_info): Add initializers.
9376         (coff_objfile_data_key): Move lower.  Change type.
9377         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9378         Update.
9379         (coff_free_info): Remove.
9380
9381 2019-05-08  Tom Tromey  <tom@tromey.com>
9382
9383         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9384         (fbsd_pspace_data_handle): Move lower.  Change type.
9385         (get_fbsd_pspace_data): Update.
9386         (fbsd_pspace_data_cleanup): Remove.
9387         (_initialize_fbsd_tdep): Update.
9388
9389 2019-05-08  Tom Tromey  <tom@tromey.com>
9390
9391         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9392         (get_ada_tasks_pspace_data): Update.
9393         (ada_tasks_pspace_data_cleanup): Remove.
9394         (_initialize_tasks): Update.
9395         (ada_tasks_inferior_data_handle): Change type.
9396         (get_ada_tasks_inferior_data): Update.
9397         (ada_tasks_inferior_data_cleanup): Remove.
9398         (struct ada_tasks_pspace_data): Add initializers.
9399
9400 2019-05-08  Tom Tromey  <tom@tromey.com>
9401
9402         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9403         * symfile-debug.c (debug_sym_get_probes): Change type.
9404         * stap-probe.c (handle_stap_probe):
9405         (stap_static_probe_ops::get_probes): Change type.
9406         * probe.h (class static_probe_ops) <get_probes>: Change type.
9407         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9408         (parse_probes_in_pspace): Update.
9409         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9410         Update.
9411         (any_static_probe_ops::get_probes): Change type.
9412         * elfread.c (elfread_data): New typedef.
9413         (probe_key): Change type.
9414         (elf_get_probes): Likewise.  Update.
9415         (probe_key_free): Remove.
9416         (_initialize_elfread): Update.
9417         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9418         Change type.
9419         (dtrace_process_dof_probe, dtrace_process_dof)
9420         (dtrace_static_probe_ops::get_probe): Change type.
9421
9422 2019-05-08  Tom Tromey  <tom@tromey.com>
9423
9424         * xcoffread.c (struct xcoff_symfile_info): Rename from
9425         coff_symfile_info.  Add initializers.
9426         (xcoff_objfile_data_key): Move lower.  Change type.
9427         (XCOFF_DATA): Rewrite.
9428         (xcoff_free_info): Remove.
9429         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9430         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9431         (xcoff_initial_scan): Update.
9432
9433 2019-05-08  Tom Tromey  <tom@tromey.com>
9434
9435         * solib-svr4.c (struct svr4_info): Add initializers and
9436         destructor.
9437         <probes_table>: Now an htab_up.
9438         (solib_svr4_pspace_data): Change type.
9439         (free_probes_table): Simplify.
9440         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9441         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9442         (probes_table_remove_objfile_probes, register_solib_event_probe)
9443         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9444         (_initialize_svr4_solib): Update.
9445
9446 2019-05-08  Tom Tromey  <tom@tromey.com>
9447
9448         * remote.c (remote_pspace_data): Change type.
9449         (remote_pspace_data_cleanup): Remove.
9450         (get_remote_exec_file, set_pspace_remote_exec_file)
9451         (_initialize_remote): Update.
9452
9453 2019-05-08  Tom Tromey  <tom@tromey.com>
9454
9455         * breakpoint.c (breakpoint_objfile_key): Change type.
9456         (get_breakpoint_objfile_data): Update.
9457         (free_breakpoint_objfile_data): Remove.
9458         (_initialize_breakpoint): Update.
9459
9460 2019-05-08  Tom Tromey  <tom@tromey.com>
9461
9462         * linux-tdep.c (struct linux_info): Add initializers.
9463         (linux_inferior_data): Move.  Change type.
9464         (invalidate_linux_cache_inf): Update.
9465         (linux_inferior_data_cleanup): Remove.
9466         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9467
9468 2019-05-08  Tom Tromey  <tom@tromey.com>
9469
9470         * auxv.c (auxv_inferior_data): Move.  Change type.
9471         (auxv_inferior_data_cleanup): Remove.
9472         (invalidate_auxv_cache_inf): Rewrite.
9473         (get_auxv_inferior_data, _initialize_auxv): Update.
9474
9475 2019-05-08  Tom Tromey  <tom@tromey.com>
9476
9477         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9478         (symfile_debug_objfile_data_key): Change type.
9479         (symfile_debug_installed, debug_qf_has_symbols)
9480         (debug_qf_find_last_source_symtab)
9481         (debug_qf_forget_cached_source_info)
9482         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9483         (debug_qf_print_stats, debug_qf_dump)
9484         (debug_qf_expand_symtabs_for_function)
9485         (debug_qf_expand_all_symtabs)
9486         (debug_qf_expand_symtabs_with_fullname)
9487         (debug_qf_map_matching_symbols)
9488         (debug_qf_expand_symtabs_matching)
9489         (debug_qf_find_pc_sect_compunit_symtab)
9490         (debug_qf_map_symbol_filenames)
9491         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9492         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9493         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9494         (debug_sym_read_linetable, debug_sym_relocate): Update.
9495         (symfile_debug_free_objfile): Remove.
9496         (install_symfile_debug_logging, _initialize_symfile_debug):
9497         Update.
9498
9499 2019-05-08  Tom Tromey  <tom@tromey.com>
9500
9501         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9502         allocate_on_obstack.
9503         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9504         (get_dwarf2_per_objfile): Update.
9505         (set_dwarf2_per_objfile): Remove.
9506         (dwarf2_has_info, dwarf2_get_section_info): Update.
9507         (dwarf2_free_objfile): Remove.
9508         (_initialize_dwarf2_read): Update.
9509
9510 2019-05-08  Tom Tromey  <tom@tromey.com>
9511
9512         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9513         initializers.
9514         <unsupported_script_warning_printed,
9515         script_not_found_warning_printed>: Now bool.
9516         (auto_load_pspace_data): Change type.
9517         (~auto_load_pspace_info): Rename from
9518         auto_load_pspace_data_cleanup.
9519         (get_auto_load_pspace_data, init_loaded_scripts_info)
9520         (clear_section_scripts, maybe_print_unsupported_script_warning)
9521         (maybe_print_script_not_found_warning, _initialize_auto_load):
9522         Update.
9523
9524 2019-05-08  Tom Tromey  <tom@tromey.com>
9525
9526         * objfiles.c (objfile_pspace_info): Add destructor and
9527         initializers.
9528         (objfiles_pspace_data): Change type.
9529         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9530         (get_objfile_pspace_data): Update.
9531         (objfiles_bfd_data): Change type.
9532         (get_objfile_bfd_data): Update.
9533         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9534
9535 2019-05-08  Tom Tromey  <tom@tromey.com>
9536
9537         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9538         Change type.
9539         (get_catch_syscall_inferior_data): Update.
9540         (catch_syscall_inferior_data_cleanup): Remove.
9541         (_initialize_break_catch_syscall): Update.
9542
9543 2019-05-08  Tom Tromey  <tom@tromey.com>
9544
9545         * inflow.c (struct terminal_info): Add destructor and
9546         initializers.
9547         (inflow_inferior_data): Change type.
9548         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9549         (get_inflow_inferior_data, inflow_inferior_exit)
9550         (swap_terminal_info, _initialize_inflow): Update.
9551
9552 2019-05-08  Tom Tromey  <tom@tromey.com>
9553
9554         * target-dcache.c (target_dcache_cleanup): Remove.
9555         (target_dcache_aspace_key): Change type.
9556         (target_dcache_init_p, target_dcache_invalidate)
9557         (target_dcache_get, target_dcache_get_or_init)
9558         (_initialize_target_dcache): Update.
9559         * dcache.h (struct dcache_deleter): New.
9560
9561 2019-05-08  Tom Tromey  <tom@tromey.com>
9562
9563         * symtab.c (struct symbol_cache): Add destructor and
9564         initializers.
9565         (symbol_cache_key): Move.  Change type.
9566         (make_symbol_cache, free_symbol_cache): Remove.
9567         (get_symbol_cache): Update.
9568         (symbol_cache_cleanup): Remove.
9569         (ALL_PSPACES, symbol_cache_flush)
9570         (maintenance_print_symbol_cache)
9571         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9572         Update.
9573
9574 2019-05-08  Tom Tromey  <tom@tromey.com>
9575
9576         * symtab.c (struct main_info): Add destructor and initializers.
9577         (main_progspace_key): Move.  Change type.
9578         (get_main_info): Update.
9579         (main_info_cleanup): Remove.
9580         (_initialize_symtab): Update.
9581
9582 2019-05-08  Tom Tromey  <tom@tromey.com>
9583
9584         * registry.h (DECLARE_REGISTRY): Define the _key class.
9585
9586 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9587
9588         * NEWS: Merge two 'New commands' sections.
9589
9590 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9591
9592         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9593         parameter and use Ada language definition instead.
9594         (ada_val_print_ptr): Remove unused language parameter.
9595         (ada_val_print_num): Remove language parameter and use Ada language
9596         definition instead.
9597         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9598         parameter.
9599         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9600         parameter and use Ada language definition instead.
9601         (ada_val_print_1): Update all ada_val_print_xxx calls.
9602         Remove language parameter.
9603         (ada_val_print): Update ada_val_print_1 call.
9604
9605 2019-05-08  Tom Tromey  <tromey@adacore.com>
9606
9607         * remote.c (remote_hw_watchpoint_limit)
9608         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9609         Now static.
9610
9611 2019-05-08  Tom Tromey  <tromey@adacore.com>
9612
9613         * maint.c (_initialize_maint_cmds): Move initialization code to
9614         remote.c.
9615         (watchdog, show_watchdog): Move to remote.c.
9616         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9617         "watchdog" static.
9618         (_initialize_remote): Move initialization code from maint.c.
9619         * defs.h (watchdog): Don't declare.
9620
9621 2019-05-08  Tom Tromey  <tromey@adacore.com>
9622
9623         * tui/tui-interp.c: Include main.h.
9624         * interps.c: Include main.h.
9625         * main.h (interpreter_p): Declare.
9626         * defs.h (interpreter_p): Don't declare.
9627
9628 2019-05-08  Tom Tromey  <tromey@adacore.com>
9629
9630         * dwarf2loc.c: Include dwarf2read.h.
9631         * defs.h (read_unsigned_leb128): Don't declare.
9632         * dwarf2read.h (read_unsigned_leb128): Declare.
9633
9634 2019-05-08  Tom Tromey  <tromey@adacore.com>
9635
9636         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9637         method.
9638
9639 2019-05-08  Tom Tromey  <tromey@adacore.com>
9640
9641         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9642         when no wrap column is set.
9643
9644 2019-05-08  Tom Tromey  <tromey@adacore.com>
9645
9646         * c-lang.c (c_get_string): Handle non-C-style arrays.
9647
9648 2019-05-08  Tom Tromey  <tromey@adacore.com>
9649
9650         * typeprint.c (print_offset_data::update): Print the bit offset,
9651         not the number of bits remaining.
9652
9653 2019-05-08  Tom Tromey  <tromey@adacore.com>
9654
9655         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9656         padding at end of comment.
9657
9658 2019-05-08  Tom Tromey  <tromey@adacore.com>
9659
9660         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9661         Compare main types.
9662
9663 2019-05-06  Tom Tromey  <tom@tromey.com>
9664
9665         * common/scoped_mmap.c: Include common-defs.h.
9666         * common/scoped_mmap.h: Don't include config.h.
9667
9668 2019-05-04  Tom Tromey  <tom@tromey.com>
9669
9670         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9671         (struct aarch64_call_info): Add initializers.
9672         <si>: Now a std::vector.
9673         (pass_on_stack, aarch64_push_dummy_call): Update.
9674
9675 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9676             Tom Tromey  <tom@tromey.com>
9677
9678         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9679         (ppc_threads): Now a std::vector.  Now static.
9680         (hwdebug_find_thread_points_by_tid)
9681         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9682         Update.
9683
9684 2019-05-04  Tom Tromey  <tom@tromey.com>
9685
9686         * arc-tdep.c (arc_tdesc_init): Return bool.
9687
9688 2019-05-04  Tom Tromey  <tom@tromey.com>
9689
9690         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9691         Use gdb_assert_not_reached.
9692
9693 2019-05-04  Tom Tromey  <tom@tromey.com>
9694
9695         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9696         "false".
9697
9698 2019-05-04  Tom Tromey  <tom@tromey.com>
9699
9700         * arc-tdep.c (arc_tdesc_init): Use bool.
9701
9702 2019-05-04  Tom Tromey  <tom@tromey.com>
9703
9704         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9705
9706 2019-05-04  Tom Tromey  <tom@tromey.com>
9707
9708         * cli/cli-cmds.c (valid_command_p): Return bool.
9709
9710 2019-05-04  Tom Tromey  <tom@tromey.com>
9711
9712         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9713         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9714
9715 2019-05-04  Raul Tambre  <raul@tambre.ee>
9716
9717         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9718         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9719         operator for comparison.
9720
9721 2019-05-04  Tom Tromey  <tom@tromey.com>
9722
9723         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9724         (lookup_partial_symbol, print_partial_symbols)
9725         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9726         (psymbol_compare): Update.
9727         (add_psymbol_to_bcache): Clear the entire psymbol.
9728         (maintenance_check_psymtabs): Update.
9729         * psympriv.h (struct partial_symbol): Don't derive from
9730         general_symbol_info.
9731         <obj_section, unrelocated_address, address,
9732         set_unrelocated_address>: Update.
9733         <ginfo>: New member.
9734         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9735         (debug_names::write_psymbols): Update.
9736
9737 2019-05-04  Tom de Vries  <tdevries@suse.de>
9738
9739         * contrib/cc-with-tweaks.sh: Support -n arg.
9740
9741 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9742
9743         * corelow.c (core_target::detach): Ensure frame cache and
9744         register caches are cleared.
9745         inferior.c (exit_inferior_1): Likewise.
9746
9747 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9748             Tom Tromey  <tom@tromey.com>
9749
9750         * dictionary.c (collate_pending_symbols_by_language): Remove
9751         "struct" from foreach.
9752         * symtab.c (lookup_global_symbol_from_objfile)
9753         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9754         foreach.
9755         * ser-tcp.c (net_open): Remove "struct" from foreach.
9756         * objfiles.c (objfile_relocate, objfile_rebase)
9757         (objfile_has_symbols): Remove "struct" from foreach.
9758         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9759         from foreach.
9760         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9761         foreach.
9762         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9763         "struct" from foreach.
9764         * ada-lang.c (create_excep_cond_exprs)
9765         (ada_exception_catchpoint_cond_string): Remove "struct" from
9766         foreach.
9767
9768 2019-05-03  Tom Tromey  <tromey@adacore.com>
9769
9770         * ada-exp.y (convert_char_literal): Check suffix of each
9771         enumerator.
9772
9773 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9774
9775         PR ada/21406:
9776         * ada-exp.y (yywrap): Don't define.
9777         * ada-lex.l (%option): Add noyywrap
9778         (yywrap): Remove.
9779
9780 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9781
9782         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9783         _WIN32_WINNT to the XP level, unless already defined to a higher
9784         level.
9785
9786         * unittests/parse-connection-spec-selftests.c:
9787         * ser-tcp.c:
9788         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9789         override.
9790
9791         * symfile.c (find_separate_debug_file): Remove colon from the
9792         drive spec of DOS/Windows file names of the target, so that the
9793         file name produced from DEBUGDIR and the target's directory will
9794         be valid on DOS/Windows systems.
9795
9796 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9797
9798         * rust-lang.c (val_print_struct): Handle printing structures
9799         containing strings.
9800
9801 2019-05-02  Tom Tromey  <tromey@adacore.com>
9802
9803         * valarith.c (_initialize_valarith): Remove.
9804
9805 2019-05-01  Tom Tromey  <tromey@adacore.com>
9806
9807         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9808         bitfields.
9809
9810 2019-05-01  Tom Tromey  <tromey@adacore.com>
9811
9812         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9813         for big-endian copies.
9814
9815 2019-04-30  Ali Tamur  <tamur@google.com>
9816         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9817         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9818         (read_3_bytes): New function.
9819
9820 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9821
9822         * windows-nat.c (main_thread_id): Delete.
9823         (handle_output_debug_string): Replace main_thread_id by
9824         current_event.dwThreadId.
9825         (fake_create_process): Likewise.
9826         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9827         Do not set main_thread_id.
9828         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9829         current_event.dwThreadId.
9830         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9831
9832 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9833
9834         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9835         Use current_event.dwThreadId instead of main_thread_id.
9836
9837 2019-04-30  Tom Tromey  <tromey@adacore.com>
9838
9839         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9840         (create_excep_cond_exprs): Iterate over program spaces.
9841         (ada_exception_catchpoint_cond_string): Examine all minimal
9842         symbols for exception types.
9843
9844 2019-04-30  Tom Tromey  <tromey@adacore.com>
9845
9846         PR c++/24470:
9847         * dwarf2read.c (process_structure_scope): Handle case where type
9848         has template parameters but no symbol was created.
9849
9850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9851             Chris January  <chris.january@arm.com>
9852
9853         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9854         qualifier.
9855         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9856
9857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9858
9859         * f-typeprint.c (f_print_type): Update rules for printing
9860         whitespace.
9861         (f_type_print_varspec_suffix): Likewise.
9862
9863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9864             Chris January  <chris.january@arm.com>
9865
9866         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9867         function arguments.
9868
9869 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * f-lang.c (build_fortran_types): Change name of void type to
9872         lower case.
9873         * f-typeprint.c (f_type_print_base): Print the name of the void
9874         type, rather than a fixed string.
9875         * f-valprint.c (f_decorations): Use lower case void string.
9876
9877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9878             Chris January  <chris.january@arm.com>
9879
9880         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9881         types for Fortran.
9882
9883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9884             Chris January  <chris.january@arm.com>
9885             David Lecomber  <david.lecomber@arm.com>
9886
9887         * f-exp.y (BINOP_INTRINSIC): New token.
9888         (exp): New parser rule handling BINOP_INTRINSIC.
9889         (f77_keywords): Add new builtin procedures.
9890         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9891         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9892         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9893         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9894         (print_unop_subexp_f): New function.
9895         (print_binop_subexp_f): New function.
9896         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9897         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9898         (dump_subexp_body_f): Likewise.
9899         (operator_check_f): Likewise.
9900         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9901         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9902
9903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9904
9905         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9906         UNOP_KIND.
9907         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9908         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9909         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9910         (operator_length_f): New fuction.
9911         (print_subexp_f): New function.
9912         (op_name_f): New function.
9913         (dump_subexp_body_f): New function.
9914         (operator_check_f): New function.
9915         (exp_descriptor_f): Replace standard expression handling functions
9916         with new functions.
9917         * gdb/fortran-operator.def: New file.
9918         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9919         * gdb/std-operator.def: Remove UNOP_KIND.
9920
9921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9922
9923         * std-operator.def: Remove unbalanced, stray double quote
9924         character.
9925
9926 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9927             Chris January  <chris.january@arm.com>
9928             Daniel Everett  <daniel.everett@arm.com>
9929             Nick Forrington  <nick.forrington@arm.com>
9930             Richard Bunt  <richard.bunt@arm.com>
9931
9932         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9933         of depth when printing anonymous structs or unions.
9934         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9935         Don't print either the top-level value, or the children if the
9936         max-depth is exceeded.
9937         (ppscm_print_children): When printing the key of a map, allow one
9938         extra level of depth.
9939         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9940         print either the top-level value, or the children if the max-depth
9941         is exceeded.
9942         (print_children): When printing the key of a map, allow one extra
9943         level of depth.
9944         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9945         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9946         (user_print_options): Initialise max_depth field.
9947         (val_print_scalar_or_string_type_p): New function.
9948         (val_print): Check to see if the max depth has been reached.
9949         (val_print_check_max_depth): Define new function.
9950         (show_print_max_depth): New function.
9951         (_initialize_valprint): Add 'print max-depth' option.
9952         * valprint.h (struct value_print_options) <max_depth>: New field.
9953         (val_print_check_max_depth): Declare new function.
9954         * NEWS: Document new feature.
9955
9956 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9957
9958         * ada-lang.c (ada_language_defn): Initialise new field.
9959         * c-lang.c (c_is_string_type_p): New function.
9960         (c_language_defn): Initialise new field.
9961         (cplus_language_defn): Initialise new field.
9962         (asm_language_defn): Initialise new field.
9963         (minimal_language_defn): Initialise new field.
9964         * c-lang.h (c_is_string_type_p): Declare new function.
9965         * d-lang.c (d_language_defn): Initialise new field.
9966         * f-lang.c (f_is_string_type_p): New function.
9967         (f_language_defn): Initialise new field.
9968         * go-lang.c (go_is_string_type_p): New function.
9969         (go_language_defn): Initialise new field.
9970         * language.c (default_is_string_type_p): New function.
9971         (unknown_language_defn): Initialise new field.
9972         (auto_language_defn): Initialise new field.
9973         * language.h (struct language_defn) <la_is_string_type_p>: New
9974         member variable.
9975         (default_is_string_type_p): Declare new function.
9976         * m2-lang.c (m2_language_defn): Initialise new field.
9977         * objc-lang.c (objc_language_defn): Initialise new field.
9978         * opencl-lang.c (opencl_language_defn): Initialise new field.
9979         * p-lang.c (pascal_is_string_type_p): New function.
9980         (pascal_language_defn): Initialise new field.
9981         * rust-lang.c (rust_is_string_type_p): New function.
9982         (rust_language_defn): Initialise new field.
9983
9984 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9985
9986         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9987         New field.
9988         * ada-lang.c (ada_language_defn): Initialise new field.
9989         * c-lang.c (c_language_defn): Likewise.
9990         (cplus_language_defn): Likewise.
9991         (asm_language_defn): Likewise.
9992         (minimal_language_defn): Likewise.
9993         * d-lang.c (d_language_defn): Likewise.
9994         * f-lang.c (f_language_defn): Likewise.
9995         * go-lang.c (go_language_defn): Likewise.
9996         * language.c (unknown_language_defn): Likewise.
9997         (auto_language_defn): Likewise.
9998         * m2-lang.c (m2_language_defn): Likewise.
9999         * objc-lang.c (objc_language_defn): Likewise.
10000         * opencl-lang.c (opencl_language_defn): Likewise.
10001         * p-lang.c (pascal_language_defn): Likewise.
10002         * rust-lang.c (rust_language_defn): Likewise.
10003
10004 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10005
10006         * ada-lang.c (ada_is_character_type): Change return type to bool.
10007         (ada_is_string_type): Likewise.
10008         * ada-lang.h (ada_is_character_type): Update declaration
10009         (ada_is_string_type): Likewise.
10010
10011 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10012
10013         Support style in 'frame|thread apply'
10014
10015         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10016         * record.c (record_start, record_stop): Update callers of
10017         execute_command_to_string with false.
10018         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10019         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10020         methods.
10021         (class string_file): New constructor with term_out parameter.
10022         Override methods term_out and can_emit_style_escape.  New member
10023         term_out.
10024         (class stdio_file): Override can_emit_style_escape.
10025         (class tee_file): Override term_out and can_emit_style_escape.
10026         * utils.h (can_emit_style_escape): Remove.
10027         * utils.c (can_emit_style_escape): Likewise.
10028         Update all callers of can_emit_style_escape (SOMESTREAM) to
10029         SOMESTREAM->can_emit_style_escape.
10030         * source-cache.c (source_cache::get_source_lines): Likewise.
10031         * stack.c (frame_apply_command_count): Call execute_command_to_string
10032         passing the term_out characteristic of the current gdb_stdout.
10033         * thread.c (thr_try_catch_cmd): Likewise.
10034         * top.c (execute_command_to_string): pass term_out parameter
10035         to construct the string_file for the command output.
10036         * ui-file.c (term_cli_styling): New function (most code moved
10037         from utils.c can_emit_style_escape).
10038         (string_file::string_file, string_file::can_emit_style_escape,
10039         stdio_file::can_emit_style_escape, tee_file::term_out,
10040         tee_file::can_emit_style_escape): New functions.
10041
10042 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10043
10044         * NEWS: Mention the new set|show may-call-functions.
10045         * infcall.c (may_call_functions_p): New variable.
10046         (show_may_call_functions_p): New function.
10047         (call_function_by_hand_dummy): Throws an error if not
10048         may-call-functions.
10049         (_initialize_infcall): Call add_setshow_boolean_cmd for
10050         may-call-functions.
10051
10052 2019-04-25  Keith Seitz  <keiths@redhat.com>
10053
10054         PR c++/24367
10055         * cp-support.c (inspect_type): Don't attempt substitutions
10056         of symbol with the same name.
10057
10058 2019-04-25  Tom Tromey  <tromey@adacore.com>
10059
10060         PR gdb/24475:
10061         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10062         static.
10063
10064 2019-04-25  Tom Tromey  <tromey@adacore.com>
10065
10066         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10067         rvalue reference.
10068         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10069         (gdb_xml_parser::parse): Use std::move.
10070         * python/python-internal.h (gdbpy_convert_exception): Take a const
10071         reference.
10072         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10073         std::move.
10074         * python/py-utils.c (gdbpy_convert_exception): Take a const
10075         reference.
10076         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10077         Use std::move.
10078         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10079         Use std::move.
10080         * mi/mi-main.c (mi_print_exception): Take a const reference.
10081         * main.c (handle_command_errors): Take a const reference.
10082         * linespec.c (parse_linespec): Use std::move.
10083         * infcall.c (run_inferior_call): Use std::move.
10084         (call_function_by_hand_dummy): Use std::move.
10085         * exec.c (try_open_exec_file): Use std::move.
10086         * exceptions.h (exception_print, exception_fprintf)
10087         (exception_print_same): Update.
10088         * exceptions.c (print_exception, exception_print)
10089         (exception_fprintf, exception_print_same): Change parameters to
10090         const reference.
10091         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10092         * common/new-op.c: Use std::move.
10093         * common/common-exceptions.h (struct gdb_exception): Add move
10094         constructor.
10095         (struct gdb_exception_error, struct gdb_exception_quit, struct
10096         gdb_quit_bad_alloc): Change constructor to move constructor.
10097         (throw_exception): Change parameter to rvalue reference.
10098         * common/common-exceptions.c (throw_exception): Take rvalue
10099         reference.
10100         * cli/cli-interp.c (safe_execute_command): Use std::move.
10101         * breakpoint.c (insert_bp_location, location_to_sals): Use
10102         std::move.
10103
10104 2019-04-25  Tom Tromey  <tromey@adacore.com>
10105
10106         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10107         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10108         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10109         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10110         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10111         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10112         guile/scm-value.c: Use unpack.
10113         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10114         gdbscm_gdb_exception.
10115         (gdbscm_throw_gdb_exception): Likewise.
10116         (struct gdbscm_gdb_exception): New.
10117         (unpack): New function.
10118         (gdbscm_wrap): Use unpack.
10119
10120 2019-04-25  Tom Tromey  <tromey@adacore.com>
10121
10122         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10123         (gdb_rl_callback_handler): Use std::move.
10124         * common/common-exceptions.h (struct gdb_exception): Add move
10125         assignment operator.
10126         (throw_exception_sjlj): Change "exception" to const reference.
10127         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10128         (throw_exception_sjlj): Change "exception" to const reference.
10129
10130 2019-04-25  Tom Tromey  <tromey@adacore.com>
10131
10132         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10133         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10134         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10135         Update.
10136         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10137         Update.
10138         * mi/mi-interp.c (mi_interp::exec): Update.
10139         * linespec.c (parse_linespec): Update.
10140         * infcall.c (run_inferior_call): Update.
10141         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10142         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10143         (gdbscm_lookup_global_symbol): Update.
10144         * guile/scm-param.c (gdbscm_parameter_value): Update.
10145         * guile/scm-frame.c (gdbscm_frame_read_register)
10146         (gdbscm_frame_read_var): Update.
10147         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10148         * exec.c (try_open_exec_file): Update.
10149         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10150         (gdb_rl_callback_handler): Update.
10151         * common/common-exceptions.h (exception_none): Don't declare.
10152         * common/common-exceptions.c (exception_none): Don't define.
10153         (struct catcher) <exception>: Update.
10154         * cli/cli-interp.c (safe_execute_command): Update.
10155         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10156
10157 2019-04-25  Ali Tamur  <tamur@google.com>
10158
10159         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10160         (read_attribute_value): Likewise.
10161         (dwarf2_read_addr_index): Update comment.
10162         (read_str_index): Add DW_FORM_strx.
10163         (dwarf2_string_attr): Likewise.
10164         (dwarf2_const_value_attr): Likewise.
10165         (dump_die_shallow): Likewise.
10166         (dwarf2_fetch_constant_bytes): Likewise.
10167         (skip_form_bytes): Likewise.
10168         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10169
10170 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10171
10172         PR corefiles/11608
10173         PR corefiles/18187
10174         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10175         OFFSET.  Verify if current mapping contains an ELF header.
10176         (linux_find_memory_regions_full): Adjust call to
10177         dump_mapping_p.
10178
10179 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10180             Kang Li <kanglictf@gmail.com>
10181
10182         PR gdb/21600
10183
10184         * dwarf2-frame.c (read_initial_length): Be consistent about using
10185         unsigned representation of length.
10186         (decode_frame_entry_1): Likewise.  Check for wraparound of
10187         end pointer as well as buffer overflow.
10188
10189 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10190
10191         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10192         "vq".
10193
10194 2019-04-24  Tom Tromey  <tromey@adacore.com>
10195
10196         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10197
10198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10199
10200         * s12z-tdep.c (s12z_unwind_pc): Delete.
10201         (s12z_unwind_sp): Delete.
10202         (s12z_gdbarch_init): Don't register deleted functions with
10203         gdbarch.
10204
10205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10206
10207         * rl78-tdep.c (rl78_unwind_sp): Delete.
10208         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10209
10210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10211
10212         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10213         (xstormy16_unwind_pc): Delete.
10214         (xstormy16_dummy_id): Delete.
10215         (xstormy16_gdbarch_init): Don't register deleted functions with
10216         gdbarch.
10217
10218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10219
10220         * vax-tdep.c (vax_unwind_pc): Delete.
10221         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10222
10223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         * v850-tdep.c (v850_unwind_sp): Delete.
10226         (v850_unwind_pc): Delete.
10227         (v850_dummy_id): Delete.
10228         (v850_gdbarch_init): Don't register deleted functions with
10229         gdbarch.
10230
10231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10232
10233         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10234         (tilegx_unwind_pc): Delete.
10235         (tilegx_unwind_dummy_id): Delete.
10236         (tilegx_gdbarch_init): Don't register deleted functions with
10237         gdbarch.
10238
10239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10242         (tic6x_dummy_id): Delete.
10243         (tic6x_gdbarch_init): Don't register deleted functions with
10244         gdbarch.
10245
10246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * sparc-tdep.c (sparc_unwind_pc): Delete.
10249         (sparc32_gdbarch_init): Don't register deleted function with
10250         gdbarch.
10251
10252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10253
10254         * sh-tdep.c (sh_unwind_sp): Delete.
10255         (sh_unwind_pc): Delete.
10256         (sh_dummy_id): Delete.
10257         (sh_gdbarch_init): Don't register deleted functions with
10258         gdbarch.
10259
10260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10261
10262         * score-tdep.c (score_unwind_sp): Delete.
10263         (score_unwind_pc): Delete.
10264         (score_dummy_id): Delete.
10265         (score_gdbarch_init): Don't register deleted functions with
10266         gdbarch.
10267
10268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10269
10270         * rx-tdep.c (rx_unwind_pc): Delete.
10271         (rx_unwind_sp): Delete.
10272         (rx_dummy_id): Delete.
10273         (rx_gdbarch_init): Don't register deleted functions with
10274         gdbarch.  Update comment.
10275
10276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10277
10278         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10279         (rs6000_dummy_id): Delete.
10280         (rs6000_gdbarch_init): Don't register deleted functions with
10281         gdbarch.
10282
10283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * or1k-tdep.c (or1k_dummy_id): Delete.
10286         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10287
10288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10289
10290         * nios2-tdep.c (nios2_dummy_id): Delete.
10291         (nios2_unwind_sp): Delete.
10292         (nios2_gdbarch_init): Don't register deleted functions with
10293         gdbarch.
10294
10295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10296
10297         * nds32-tdep.c (nds32_dummy_id): Delete.
10298         (nds32_unwind_pc): Delete.
10299         (nds32_unwind_sp): Delete.
10300         (nds32_gdbarch_init): Don't register deleted functions with
10301         gdbarch.
10302
10303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10304
10305         * msp430-tdep.c (msp430_unwind_pc): Delete.
10306         (msp430_unwind_sp): Delete.
10307         (msp430_dummy_id): Delete.
10308         (msp430_gdbarch_init): Don't register deleted functions with
10309         gdbarch.
10310
10311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10312
10313         * moxie-tdep.c (moxie_unwind_sp): Delete.
10314         (moxie_unwind_pc): Delete.
10315         (moxie_dummy_id): Delete.
10316         (moxie_gdbarch_init): Don't register deleted functions with
10317         gdbarch.
10318
10319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10320
10321         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10322         (mn10300_unwind_pc): Delete.
10323         (mn10300_unwind_sp): Delete.
10324         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10325         mn10300_unwind_sp.
10326         (mn10300_frame_unwind_init): Don't register deleted functions with
10327         gdbarch.
10328
10329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10330
10331         * mep-tdep.c (mep_unwind_pc): Delete.
10332         (mep_unwind_sp): Delete.
10333         (mep_dummy_id): Delete.
10334         (mep_gdbarch_init): Don't register deleted functions with
10335         gdbarch.
10336
10337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10338
10339         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10340         (m68hc11_unwind_sp): Delete.
10341         (m68hc11_gdbarch_init): Don't register deleted functions with
10342         gdbarch.
10343
10344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10345
10346         * m32r-tdep.c (m32r_unwind_sp): Delete.
10347         (m32r_unwind_pc): Delete.
10348         (m32r_dummy_id): Delete.
10349         (m32r_gdbarch_init): Don't register deleted functions with
10350         gdbarch.
10351
10352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * m32c-tdep.c (m32c_unwind_pc): Delete.
10355         (m32c_unwind_sp): Delete.
10356         (m32c_dummy_id): Delete.
10357         (m32c_gdbarch_init): Don't register deleted functions with
10358         gdbarch.
10359
10360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10363         (lm32_unwind_pc): Delete.
10364         (lm32_dummy_id): Delete.
10365         (lm32_gdbarch_init): Don't register deleted functions with
10366         gdbarch.
10367
10368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10369
10370         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10371         (iq2000_unwind_pc): Delete.
10372         (iq2000_dummy_id): Delete.
10373         (iq2000_gdbarch_init): Don't register deleted functions with
10374         gdbarch.
10375
10376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * nds32-tdep.c (nds32_type_align): Delete.
10379         (nds32_push_dummy_call): Use type_align instead.
10380
10381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10382
10383         * arm-tdep.c (arm_type_align): Only handle vector override case.
10384         (arm_push_dummy_call): Use type_align.
10385         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10386
10387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10388
10389         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10390         case.
10391         (pass_on_stack): Use type_align.
10392         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10393         function.
10394
10395 2019-04-23  Tom Tromey  <tromey@adacore.com>
10396
10397         * dwarf2read.c (line_header::file_name_at): Remove unused
10398         overload.
10399
10400 2019-04-23  Tom de Vries  <tdevries@suse.de>
10401
10402         PR gdb/24438
10403         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10404         invocation.
10405
10406
10407 2019-03-27  Ali Tamur  <tamur@google.com>
10408
10409         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10410         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10411         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10412         (dwarf_expr_context::get_addr_index): Likewise
10413         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10414         (symbol_needs_eval_context::get_addr_index): Likewise
10415         (disassemble_dwarf_expression): Add DW_OP_addrx
10416         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10417         (read_cutu_die_from_dwo): Update comment
10418         (skip_one_die): Add DW_FORM_addrx
10419         (read_attribute_value): Likewise
10420         (var_decode_location): Add DW_OP_addrx
10421         (dwarf2_const_value_attr): Add DW_FORM_addrx
10422         (dump_die_shallow): Likewise
10423         (dwarf2_fetch_constant_bytes): Likewise
10424         (decode_locdesc): Add DW_OP_addrx
10425         (skip_form_bytes): Add DW_FORM_addrx
10426
10427 2019-04-22  Ali Tamur  <tamur@google.com>
10428
10429         * MAINTAINERS (Write After Approval): Add self.
10430
10431 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10432
10433         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10434         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10435         (open_symbol_file_object): Likewise.
10436         (svr4_default_sos): Add info parameter.
10437         (svr4_read_so_list): Likewise.
10438         (svr4_current_sos_direct): Adjust functions calls to pass down
10439         info.
10440         (svr4_current_sos_1): Add info parameter.
10441         (svr4_current_sos): Call get_svr4_info, pass info down to
10442         svr4_current_sos_1.
10443         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10444         get_svr4_info.
10445         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10446         get_svr4_info.
10447         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10448         to get_svr4_info.
10449         (probes_table_remove_objfile_probes): Likewise.
10450         (register_solib_event_probe): Add info parameter.
10451         (solist_update_incremental): Pass info parameter down to
10452         svr4_read_so_list.
10453         (disable_probes_interface): Add info parameter.
10454         (svr4_handle_solib_event): Pass current_program_space to
10455         get_svr4_info.  Adjust disable_probes_interface cleanup.
10456         (svr4_create_probe_breakpoints): Add info parameter, pass it
10457         down to register_solib_event_probe.
10458         (svr4_create_solib_event_breakpoints): Add info parameter,
10459         pass it down to svr4_create_probe_breakpoints.
10460         (enable_break): Pass info down to
10461         svr4_create_solib_event_breakpoints.
10462         (svr4_solib_create_inferior_hook): Pass current_program_space to
10463         get_svr4_info.
10464         (svr4_clear_solib): Likewise.
10465
10466 2019-04-22  Pedro Alves  <palves@redhat.com>
10467
10468         * solib-svr4.c (svr4_free_objfile_observer): New.
10469         (probe_and_action::objfile): New field.
10470         (probes_table_htab_remove_objfile_probes)
10471         (probes_table_remove_objfile_probes): New functions.
10472         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10473         in the new probe_and_action.  Don't store the probe in 'lookup'.
10474         (svr4_create_probe_breakpoints): Pass objfile to
10475         register_solib_event_probe.
10476         (_initialize_svr4_solib): Register a free_objfile observer.
10477
10478 2019-04-19  Tom Tromey  <tom@tromey.com>
10479
10480         * common/queue.h: Remove.
10481
10482 2019-04-19  Tom Tromey  <tom@tromey.com>
10483
10484         * event-loop.c: Don't include "common/queue.h".
10485
10486 2019-04-19  Tom Tromey  <tom@tromey.com>
10487
10488         * remote.c (remote_target): Use delete.
10489         * remote-notif.h: Include <list>, not "common/queue.h".
10490         (notif_client_p): Remove typedef.
10491         (remote_notif_state): Add constructor, destructor, initializer.
10492         <notif_queue>: Now a std::list.
10493         (remote_notif_state_xfree): Don't declare.
10494         * remote-notif.c (remote_notif_process, handle_notification)
10495         (remote_notif_state_allocate): Update.
10496         (~remote_notif_state): Rename from remote_notif_state_xfree.
10497
10498 2019-04-19  Tom Tromey  <tom@tromey.com>
10499
10500         * symfile.c (reread_symbols): Update.
10501         * objfiles.c (objfile_register_static_link)
10502         (objfile_lookup_static_link): Update
10503         (~objfile) Don't delete static_links.
10504         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10505
10506 2019-04-19  Tom Tromey  <tom@tromey.com>
10507
10508         * type-stack.h (struct type_stack) <insert>: Constify string.
10509         * type-stack.c (type_stack::insert): Constify string.
10510         * gdbtypes.h (lookup_template_type): Update.
10511         (address_space_name_to_int): Update.
10512         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10513         const.
10514         (lookup_template_type): Make name const.
10515         * c-exp.y: Update rules.
10516         (lex_one_token, classify_name, classify_inner_name)
10517         (c_print_token): Update.
10518         * p-exp.y: Update rules.
10519         (yylex): Update.
10520         * f-exp.y: Update rules.
10521         (yylex): Update.
10522         * d-exp.y: Update rules.
10523         (lex_one_token, classify_name, classify_inner_name): Update.
10524         * parse.c (write_dollar_variable, copy_name): Return std::string.
10525         * parser-defs.h (copy_name): Change return type.
10526         * m2-exp.y: Update rules.
10527         (yylex): Update.
10528         * go-exp.y (lex_one_token): Update.
10529         Update rules.
10530         (classify_unsafe_function, classify_packaged_name)
10531         (classify_name, yylex): Update.
10532
10533 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10534
10535         * configure.ac: add --enable-source-highlight switch.
10536         * configure: Regenerate.
10537         * top.c (print_gdb_version): plumb --enable-source-highlight
10538         status to "show configuration".
10539
10540 2019-04-19  Tom Tromey  <tromey@adacore.com>
10541
10542         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10543         Check ADA_TYPE_P.
10544         (empty_record, ada_template_to_fixed_record_type_1)
10545         (template_to_static_fixed_type)
10546         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10547         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10548         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10549         macros.
10550
10551 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10552
10553         PR symtab/24423:
10554         * source.c (print_source_lines_base): Advance "iter" when a
10555         control character is seen.
10556
10557 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10558
10559         * inferior.h (struct infcall_suspend_state_deleter):
10560         Catch exception in destructor to avoid crash.
10561
10562 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10563
10564         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10565         close to the add_com "shell".
10566
10567 2019-04-18  Tom Tromey  <tromey@adacore.com>
10568
10569         * process-stratum-target.h (class process_stratum_target)
10570         <stratum>: Add "final".
10571
10572 2019-04-17  Tom Tromey  <tromey@adacore.com>
10573
10574         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10575         against nullptr before use.
10576
10577 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10578
10579         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10580
10581 2019-04-17  Jim Wilson  <jimw@sifive.com>
10582             Andrew Burgess  <andrew.burgess@embecosm.com>
10583
10584         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10585         code read might fail, assume 4-byte breakpoint in that case.
10586
10587 2019-04-15  Leszek Swirski  <leszeks@google.com>
10588
10589         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10590         rather than a hand-rolled POD check when checking for forced MEMORY
10591         classification.
10592
10593 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10594
10595         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10596         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10597         function.
10598         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10599         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10600         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10601         declaration.
10602
10603 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10604
10605         * aarch64-linux-nat.c
10606         (aarch64_linux_nat_target::thread_architecture): Add override.
10607         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10608         each VQ.
10609
10610 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10611
10612         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10613
10614 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10615
10616         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10617         target types of size 96-bits, add some additional comments, and
10618         check that the builtin type we found was the correct size.
10619
10620 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10621
10622         * utils.c (prompt_for_continue): Don't restore the styling at the
10623         end, as applied_style has the wrong value.  This fixes styling in
10624         long lists of file names that are interrupted by the "Continue?"
10625         prompt.
10626
10627 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10628
10629         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10630         * c-lang.c (c_language_defn): Likewise.
10631         (cplus_language_defn): Likewise.
10632         (asm_language_defn): Likewise.
10633         (minimal_language_defn): Likewise.
10634         * d-lang.c (d_language_defn): Likewise.
10635         * f-lang.c (f_language_defn): Likewise.
10636         * go-lang.c (go_language_defn): Likewise.
10637         * language.c (unknown_language_defn): Likewise.
10638         (auto_language_defn): Likewise.
10639         * language.h (struct language_defn): Remove la_magic field.
10640         (LANG_MAGIC): Delete.
10641         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10642         * objc-lang.c (objc_language_defn): Likewise.
10643         * opencl-lang.c (opencl_language_defn): Likewise.
10644         * p-lang.c (pascal_language_defn): Likewise.
10645         * rust-lang.c (rust_language_defn): Likewise.
10646
10647 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10648
10649         * riscv-tdep.c (riscv_type_align): New function.
10650         (riscv_type_alignment): Delete.
10651         (riscv_arg_location): Use 'type_align'.
10652         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10653
10654 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10655
10656         * gdbtypes.c (type_align): A struct with no non-static fields also
10657         has alignment of 1.
10658
10659 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10660
10661         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10662         component to 0.
10663         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10664         member.
10665         (riscv_struct_info::analyse): New implementation using new
10666         analyse_inner member function.
10667         (riscv_struct_info::field_offset): New member function.
10668         (riscv_struct_info::m_offsets): New member variable.
10669         (riscv_struct_info::analyse_inner): New private member function,
10670         takes the old implementation of riscv_struct_info::analyse but
10671         extended to track field offsets.
10672         (riscv_call_arg_struct): Update the struct folding special cases
10673         to handle cases where empty C++ structs, which are non-zero
10674         length, are found.
10675         (riscv_arg_location): Initialise the length of each location, a
10676         non-zero length now indicates the location is in use.
10677         (riscv_push_dummy_call): Allow for the first location having a
10678         non-zero offset when setting up arguments.
10679         (riscv_return_value): Likewise, but for return values.
10680
10681 2019-04-11  Tom Tromey  <tromey@adacore.com>
10682
10683         * utils.c (internal_vproblem): Make "msg" const.
10684
10685 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10686
10687         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10688         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10689         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10690         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10691
10692 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10693
10694         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10695         function.
10696         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10697         of amd64_collect_native_gregset.
10698         (amd64_linux_nat_target::store_registers): Likewise.
10699
10700 2019-04-10  Tom Tromey  <tom@tromey.com>
10701
10702         * symtab.c (lookup_global_symbol_from_objfile)
10703         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10704         * objfiles.h (class separate_debug_iterator): New.
10705         (class separate_debug_range): New.
10706         (struct objfile) <separate_debug_objfiles>: New method.
10707         (objfile_separate_debug_iterate): Don't declare.
10708         * objfiles.c (separate_debug_iterator::operator++): Rename from
10709         objfile_separate_debug_iterate.
10710         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10711         iterator.
10712         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10713         iterator.
10714
10715 2019-04-10  Tom Tromey  <tom@tromey.com>
10716
10717         * symfile.c (reread_symbols): Remove old comment.
10718         * objfiles.c (free_all_objfiles): Fix a typo.
10719
10720 2019-04-10  Tom Tromey  <tom@tromey.com>
10721
10722         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10723         * minsyms.c (lookup_minimal_symbol): Use foreach.
10724         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10725         (lookup_minimal_symbol_solib_trampoline): Likewise.
10726         * symfile.c (reread_symbols): Use foreach.
10727
10728 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10729             Tom Tromey  <tromey@adacore.com>
10730
10731         PR rust/24414:
10732         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10733         (rust_lex_int_test): Change "value" to be LONGEST.
10734         (rust_lex_tests): Add test for long integer literal.
10735
10736 2019-04-09  Tom Tromey  <tromey@adacore.com>
10737
10738         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10739         to bool.
10740         (extended_remote_target::attach): Update.
10741         (remote_target::remote_notice_new_inferior): Update.
10742         (remote_target::add_current_inferior_and_thread): Update.
10743         * inferior.c (exit_inferior_1): Use "false".
10744         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10745
10746 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10747
10748         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10749         the "start" command.
10750
10751 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10752
10753         * python/py-inferior.c (infpy_thread_from_thread_handle):
10754         Adjust comments to reflect renaming of thread_from_thread_handle
10755         to thread_from_handle.  Adjust keywords.  Fix type error message.
10756         (inferior_object_methods): Add thread_from_handle.  Retain
10757         thread_from_thread_handle, but mark it as deprecated.
10758
10759 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10760
10761         * gdbthread.h (find_thread_by_handle): Revise declaration.
10762         * thread.c (find_thread_by_handle): Likewise.  Adjust
10763         implementation too.
10764         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10765         support for buffer objects as handles.
10766
10767 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10768
10769         * python/py-infthread.c (thpy_thread_handle): New function.
10770         (thread_object_methods): Register thpy_thread_handle.
10771
10772 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10773
10774         * gdbthread.h (thread_to_thread_handle): Declare.
10775         * thread.c (gdbtypes.h): Include.
10776         (thread_to_thread_handle): New function.
10777
10778         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10779         (target_thread_info_to_thread_handle): Declare.
10780         * target.c (target_thread_info_to_thread_handle): New function.
10781         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10782         * target-delegates.c: Regenerate.
10783
10784         * linux-thread-db.c (class thread_db_target): Add method
10785         thread_info_to_thread_handle.
10786         (thread_db_target::thread_info_to_thread_handle): Define.
10787         * remote.c (class remote_target): Add new method
10788         thread_info_to_thread_handle.
10789         (remote_target::thread_info_to_thread_handle): Define.
10790
10791 2019-04-08  Pedro Alves  <palves@redhat.com>
10792
10793         * common/common-exceptions.c (throw_exception): Don't create
10794         named object to throw; throw directly.
10795         (throw_it): Likewise.  Don't initialize gdb_exception::message
10796         here, with new; pass FMT and AP to the ctor instead.
10797         * common/common-exceptions.h: Include <string>.
10798         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10799         const char *, va_list)): New ctor.  Use std::make_shared.
10800         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10801         errors)): Delete.
10802         (gdb_exception_error::gdb_exception_error(enum errors, const char
10803         *, va_list)): New.
10804         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10805         Add assertion.
10806         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10807         errors)): Delete.
10808         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10809         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10810         Add assertion.
10811
10812 2019-04-08  Tom Tromey  <tom@tromey.com>
10813
10814         * valops.c (value_rtti_indirect_type): Replace throw_exception
10815         with throw.
10816         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10817         with throw.
10818         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10819         throw.
10820         * target.c (target_translate_tls_address): Replace throw_exception
10821         with throw.
10822         * stack.c (frame_apply_command_count): Replace throw_exception
10823         with throw.
10824         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10825         throw.
10826         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10827         with throw.
10828         * rs6000-tdep.c (rs6000_frame_cache)
10829         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10830         * remote.c: Replace throw_exception with throw.
10831         * record-full.c (record_full_message, record_full_wait_1)
10832         (record_full_restore): Replace throw_exception with throw.
10833         * record-btrace.c:
10834         (get_thread_current_frame_id, record_btrace_start_replaying)
10835         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10836         (cmd_record_btrace_start): Replace throw_exception with throw.
10837         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10838         throw.
10839         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10840         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10841         * linespec.c:
10842         (find_linespec_symbols): Replace throw_exception with throw.
10843         * infrun.c (displaced_step_prepare, resume): Replace
10844         throw_exception with throw.
10845         * infcmd.c (post_create_inferior): Replace throw_exception with
10846         throw.
10847         * inf-loop.c (inferior_event_handler): Replace throw_exception
10848         with throw.
10849         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10850         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10851         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10852         (get_prev_frame_always, get_frame_pc_if_available)
10853         (get_frame_address_in_block_if_available, get_frame_language):
10854         Replace throw_exception with throw.
10855         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10856         throw_exception with throw.
10857         * eval.c (fetch_subexp_value, evaluate_var_value)
10858         (evaluate_funcall, evaluate_subexp_standard): Replace
10859         throw_exception with throw.
10860         * dwarf2loc.c (call_site_find_chain)
10861         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10862         Replace throw_exception with throw.
10863         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10864         with throw.
10865         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10866         throw.
10867         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10868         * completer.c (complete_line_internal): Replace throw_exception
10869         with throw.
10870         * compile/compile-object-run.c (compile_object_run): Replace
10871         throw_exception with throw.
10872         * cli/cli-script.c (process_next_line): Replace throw_exception
10873         with throw.
10874         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10875         (btrace_enable, btrace_maint_update_pt_packets): Replace
10876         throw_exception with throw.
10877         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10878         throw_exception with throw.
10879         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10880         throw_exception with throw.
10881         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10882         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10883         * aarch64-tdep.c (aarch64_make_prologue_cache)
10884         (aarch64_make_stub_cache): Replace throw_exception with throw.
10885
10886 2019-04-08  Tom Tromey  <tom@tromey.com>
10887
10888         * common/common-exceptions.c (throw_exception): Rename from
10889         throw_exception_cxx.  Remove old copy.  Make argument const.
10890         (throw_it): Create and throw exception objects directly.
10891         * common/common-exceptions.h (throw_exception): Make argument
10892         const.
10893         (struct gdb_exception_error): Add constructor.
10894         (struct gdb_exception_quit): Add constructor.
10895
10896 2019-04-08  Tom Tromey  <tom@tromey.com>
10897
10898         * common/common-exceptions.h (exception_rethrow): Don't declare.
10899         (TRY_SJLJ): Update comment.
10900         (TRY, CATCH, END_CATCH): Remove.
10901         * common/common-exceptions.c (exception_rethrow): Remove.
10902
10903 2019-04-08  Tom Tromey  <tom@tromey.com>
10904
10905         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10906         Remove.
10907         (gdb_exception_error): Rename from
10908         gdb_exception_RETURN_MASK_ERROR.
10909         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10910         (gdb_quit_bad_alloc): Update.
10911         * aarch64-tdep.c: Update.
10912         * ada-lang.c: Update.
10913         * ada-typeprint.c: Update.
10914         * ada-valprint.c: Update.
10915         * amd64-tdep.c: Update.
10916         * arch-utils.c: Update.
10917         * break-catch-throw.c: Update.
10918         * breakpoint.c: Update.
10919         * btrace.c: Update.
10920         * c-varobj.c: Update.
10921         * cli/cli-cmds.c: Update.
10922         * cli/cli-interp.c: Update.
10923         * cli/cli-script.c: Update.
10924         * common/common-exceptions.c: Update.
10925         * common/new-op.c: Update.
10926         * common/selftest.c: Update.
10927         * compile/compile-c-symbols.c: Update.
10928         * compile/compile-cplus-symbols.c: Update.
10929         * compile/compile-object-load.c: Update.
10930         * compile/compile-object-run.c: Update.
10931         * completer.c: Update.
10932         * corelow.c: Update.
10933         * cp-abi.c: Update.
10934         * cp-support.c: Update.
10935         * cp-valprint.c: Update.
10936         * darwin-nat.c: Update.
10937         * disasm-selftests.c: Update.
10938         * dtrace-probe.c: Update.
10939         * dwarf-index-cache.c: Update.
10940         * dwarf-index-write.c: Update.
10941         * dwarf2-frame-tailcall.c: Update.
10942         * dwarf2-frame.c: Update.
10943         * dwarf2loc.c: Update.
10944         * dwarf2read.c: Update.
10945         * eval.c: Update.
10946         * event-loop.c: Update.
10947         * event-top.c: Update.
10948         * exec.c: Update.
10949         * f-valprint.c: Update.
10950         * fbsd-tdep.c: Update.
10951         * frame-unwind.c: Update.
10952         * frame.c: Update.
10953         * gdbtypes.c: Update.
10954         * gnu-v3-abi.c: Update.
10955         * guile/guile-internal.h: Update.
10956         * guile/scm-block.c: Update.
10957         * guile/scm-breakpoint.c: Update.
10958         * guile/scm-cmd.c: Update.
10959         * guile/scm-disasm.c: Update.
10960         * guile/scm-frame.c: Update.
10961         * guile/scm-lazy-string.c: Update.
10962         * guile/scm-math.c: Update.
10963         * guile/scm-param.c: Update.
10964         * guile/scm-ports.c: Update.
10965         * guile/scm-pretty-print.c: Update.
10966         * guile/scm-symbol.c: Update.
10967         * guile/scm-symtab.c: Update.
10968         * guile/scm-type.c: Update.
10969         * guile/scm-value.c: Update.
10970         * i386-linux-tdep.c: Update.
10971         * i386-tdep.c: Update.
10972         * inf-loop.c: Update.
10973         * infcall.c: Update.
10974         * infcmd.c: Update.
10975         * infrun.c: Update.
10976         * jit.c: Update.
10977         * language.c: Update.
10978         * linespec.c: Update.
10979         * linux-fork.c: Update.
10980         * linux-nat.c: Update.
10981         * linux-tdep.c: Update.
10982         * linux-thread-db.c: Update.
10983         * main.c: Update.
10984         * mi/mi-cmd-break.c: Update.
10985         * mi/mi-cmd-stack.c: Update.
10986         * mi/mi-interp.c: Update.
10987         * mi/mi-main.c: Update.
10988         * objc-lang.c: Update.
10989         * p-valprint.c: Update.
10990         * parse.c: Update.
10991         * ppc-linux-tdep.c: Update.
10992         * printcmd.c: Update.
10993         * python/py-arch.c: Update.
10994         * python/py-breakpoint.c: Update.
10995         * python/py-cmd.c: Update.
10996         * python/py-finishbreakpoint.c: Update.
10997         * python/py-frame.c: Update.
10998         * python/py-framefilter.c: Update.
10999         * python/py-gdb-readline.c: Update.
11000         * python/py-inferior.c: Update.
11001         * python/py-infthread.c: Update.
11002         * python/py-lazy-string.c: Update.
11003         * python/py-linetable.c: Update.
11004         * python/py-objfile.c: Update.
11005         * python/py-param.c: Update.
11006         * python/py-prettyprint.c: Update.
11007         * python/py-progspace.c: Update.
11008         * python/py-record-btrace.c: Update.
11009         * python/py-record.c: Update.
11010         * python/py-symbol.c: Update.
11011         * python/py-type.c: Update.
11012         * python/py-unwind.c: Update.
11013         * python/py-utils.c: Update.
11014         * python/py-value.c: Update.
11015         * python/python.c: Update.
11016         * record-btrace.c: Update.
11017         * record-full.c: Update.
11018         * remote-fileio.c: Update.
11019         * remote.c: Update.
11020         * riscv-tdep.c: Update.
11021         * rs6000-aix-tdep.c: Update.
11022         * rs6000-tdep.c: Update.
11023         * rust-exp.y: Update.
11024         * rust-lang.c: Update.
11025         * s390-tdep.c: Update.
11026         * selftest-arch.c: Update.
11027         * solib-dsbt.c: Update.
11028         * solib-frv.c: Update.
11029         * solib-spu.c: Update.
11030         * solib-svr4.c: Update.
11031         * solib.c: Update.
11032         * sparc64-linux-tdep.c: Update.
11033         * stack.c: Update.
11034         * symfile-mem.c: Update.
11035         * symmisc.c: Update.
11036         * target.c: Update.
11037         * thread.c: Update.
11038         * top.c: Update.
11039         * tracefile-tfile.c: Update.
11040         * tui/tui.c: Update.
11041         * typeprint.c: Update.
11042         * unittests/cli-utils-selftests.c: Update.
11043         * unittests/parse-connection-spec-selftests.c: Update.
11044         * valops.c: Update.
11045         * valprint.c: Update.
11046         * value.c: Update.
11047         * varobj.c: Update.
11048         * windows-nat.c: Update.
11049         * x86-linux-nat.c: Update.
11050         * xml-support.c: Update.
11051
11052 2019-04-08  Tom Tromey  <tom@tromey.com>
11053
11054         * xml-support.c: Use C++ exception handling.
11055         * x86-linux-nat.c: Use C++ exception handling.
11056         * windows-nat.c: Use C++ exception handling.
11057         * varobj.c: Use C++ exception handling.
11058         * value.c: Use C++ exception handling.
11059         * valprint.c: Use C++ exception handling.
11060         * valops.c: Use C++ exception handling.
11061         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11062         handling.
11063         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11064         * typeprint.c: Use C++ exception handling.
11065         * tui/tui.c: Use C++ exception handling.
11066         * tracefile-tfile.c: Use C++ exception handling.
11067         * top.c: Use C++ exception handling.
11068         * thread.c: Use C++ exception handling.
11069         * target.c: Use C++ exception handling.
11070         * symmisc.c: Use C++ exception handling.
11071         * symfile-mem.c: Use C++ exception handling.
11072         * stack.c: Use C++ exception handling.
11073         * sparc64-linux-tdep.c: Use C++ exception handling.
11074         * solib.c: Use C++ exception handling.
11075         * solib-svr4.c: Use C++ exception handling.
11076         * solib-spu.c: Use C++ exception handling.
11077         * solib-frv.c: Use C++ exception handling.
11078         * solib-dsbt.c: Use C++ exception handling.
11079         * selftest-arch.c: Use C++ exception handling.
11080         * s390-tdep.c: Use C++ exception handling.
11081         * rust-lang.c: Use C++ exception handling.
11082         * rust-exp.y: Use C++ exception handling.
11083         * rs6000-tdep.c: Use C++ exception handling.
11084         * rs6000-aix-tdep.c: Use C++ exception handling.
11085         * riscv-tdep.c: Use C++ exception handling.
11086         * remote.c: Use C++ exception handling.
11087         * remote-fileio.c: Use C++ exception handling.
11088         * record-full.c: Use C++ exception handling.
11089         * record-btrace.c: Use C++ exception handling.
11090         * python/python.c: Use C++ exception handling.
11091         * python/py-value.c: Use C++ exception handling.
11092         * python/py-utils.c: Use C++ exception handling.
11093         * python/py-unwind.c: Use C++ exception handling.
11094         * python/py-type.c: Use C++ exception handling.
11095         * python/py-symbol.c: Use C++ exception handling.
11096         * python/py-record.c: Use C++ exception handling.
11097         * python/py-record-btrace.c: Use C++ exception handling.
11098         * python/py-progspace.c: Use C++ exception handling.
11099         * python/py-prettyprint.c: Use C++ exception handling.
11100         * python/py-param.c: Use C++ exception handling.
11101         * python/py-objfile.c: Use C++ exception handling.
11102         * python/py-linetable.c: Use C++ exception handling.
11103         * python/py-lazy-string.c: Use C++ exception handling.
11104         * python/py-infthread.c: Use C++ exception handling.
11105         * python/py-inferior.c: Use C++ exception handling.
11106         * python/py-gdb-readline.c: Use C++ exception handling.
11107         * python/py-framefilter.c: Use C++ exception handling.
11108         * python/py-frame.c: Use C++ exception handling.
11109         * python/py-finishbreakpoint.c: Use C++ exception handling.
11110         * python/py-cmd.c: Use C++ exception handling.
11111         * python/py-breakpoint.c: Use C++ exception handling.
11112         * python/py-arch.c: Use C++ exception handling.
11113         * printcmd.c: Use C++ exception handling.
11114         * ppc-linux-tdep.c: Use C++ exception handling.
11115         * parse.c: Use C++ exception handling.
11116         * p-valprint.c: Use C++ exception handling.
11117         * objc-lang.c: Use C++ exception handling.
11118         * mi/mi-main.c: Use C++ exception handling.
11119         * mi/mi-interp.c: Use C++ exception handling.
11120         * mi/mi-cmd-stack.c: Use C++ exception handling.
11121         * mi/mi-cmd-break.c: Use C++ exception handling.
11122         * main.c: Use C++ exception handling.
11123         * linux-thread-db.c: Use C++ exception handling.
11124         * linux-tdep.c: Use C++ exception handling.
11125         * linux-nat.c: Use C++ exception handling.
11126         * linux-fork.c: Use C++ exception handling.
11127         * linespec.c: Use C++ exception handling.
11128         * language.c: Use C++ exception handling.
11129         * jit.c: Use C++ exception handling.
11130         * infrun.c: Use C++ exception handling.
11131         * infcmd.c: Use C++ exception handling.
11132         * infcall.c: Use C++ exception handling.
11133         * inf-loop.c: Use C++ exception handling.
11134         * i386-tdep.c: Use C++ exception handling.
11135         * i386-linux-tdep.c: Use C++ exception handling.
11136         * guile/scm-value.c: Use C++ exception handling.
11137         * guile/scm-type.c: Use C++ exception handling.
11138         * guile/scm-symtab.c: Use C++ exception handling.
11139         * guile/scm-symbol.c: Use C++ exception handling.
11140         * guile/scm-pretty-print.c: Use C++ exception handling.
11141         * guile/scm-ports.c: Use C++ exception handling.
11142         * guile/scm-param.c: Use C++ exception handling.
11143         * guile/scm-math.c: Use C++ exception handling.
11144         * guile/scm-lazy-string.c: Use C++ exception handling.
11145         * guile/scm-frame.c: Use C++ exception handling.
11146         * guile/scm-disasm.c: Use C++ exception handling.
11147         * guile/scm-cmd.c: Use C++ exception handling.
11148         * guile/scm-breakpoint.c: Use C++ exception handling.
11149         * guile/scm-block.c: Use C++ exception handling.
11150         * guile/guile-internal.h: Use C++ exception handling.
11151         * gnu-v3-abi.c: Use C++ exception handling.
11152         * gdbtypes.c: Use C++ exception handling.
11153         * frame.c: Use C++ exception handling.
11154         * frame-unwind.c: Use C++ exception handling.
11155         * fbsd-tdep.c: Use C++ exception handling.
11156         * f-valprint.c: Use C++ exception handling.
11157         * exec.c: Use C++ exception handling.
11158         * event-top.c: Use C++ exception handling.
11159         * event-loop.c: Use C++ exception handling.
11160         * eval.c: Use C++ exception handling.
11161         * dwarf2read.c: Use C++ exception handling.
11162         * dwarf2loc.c: Use C++ exception handling.
11163         * dwarf2-frame.c: Use C++ exception handling.
11164         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11165         * dwarf-index-write.c: Use C++ exception handling.
11166         * dwarf-index-cache.c: Use C++ exception handling.
11167         * dtrace-probe.c: Use C++ exception handling.
11168         * disasm-selftests.c: Use C++ exception handling.
11169         * darwin-nat.c: Use C++ exception handling.
11170         * cp-valprint.c: Use C++ exception handling.
11171         * cp-support.c: Use C++ exception handling.
11172         * cp-abi.c: Use C++ exception handling.
11173         * corelow.c: Use C++ exception handling.
11174         * completer.c: Use C++ exception handling.
11175         * compile/compile-object-run.c: Use C++ exception handling.
11176         * compile/compile-object-load.c: Use C++ exception handling.
11177         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11178         * compile/compile-c-symbols.c: Use C++ exception handling.
11179         * common/selftest.c: Use C++ exception handling.
11180         * common/new-op.c: Use C++ exception handling.
11181         * cli/cli-script.c: Use C++ exception handling.
11182         * cli/cli-interp.c: Use C++ exception handling.
11183         * cli/cli-cmds.c: Use C++ exception handling.
11184         * c-varobj.c: Use C++ exception handling.
11185         * btrace.c: Use C++ exception handling.
11186         * breakpoint.c: Use C++ exception handling.
11187         * break-catch-throw.c: Use C++ exception handling.
11188         * arch-utils.c: Use C++ exception handling.
11189         * amd64-tdep.c: Use C++ exception handling.
11190         * ada-valprint.c: Use C++ exception handling.
11191         * ada-typeprint.c: Use C++ exception handling.
11192         * ada-lang.c: Use C++ exception handling.
11193         * aarch64-tdep.c: Use C++ exception handling.
11194
11195 2019-04-08  Tom Tromey  <tom@tromey.com>
11196
11197         * xml-support.c (gdb_xml_parser::parse): Update.
11198         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11199         * value.c (show_convenience): Update.
11200         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11201         (test_parse_flags_qcs): Update.
11202         * thread.c (thr_try_catch_cmd): Update.
11203         * target.c (target_translate_tls_address): Update.
11204         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11205         (info_frame_command_core, frame_apply_command_count): Update.
11206         * rust-exp.y (rust_lex_exception_test): Update.
11207         * riscv-tdep.c (riscv_print_one_register_info): Update.
11208         * remote.c (remote_target::enable_btrace): Update.
11209         * record-btrace.c (record_btrace_enable_warn): Update.
11210         * python/py-utils.c (gdbpy_convert_exception): Update.
11211         * printcmd.c (do_one_display, print_variable_and_value): Update.
11212         * mi/mi-main.c (mi_print_exception): Update.
11213         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11214         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11215         * linux-nat.c (linux_nat_target::attach): Update.
11216         * linux-fork.c (class scoped_switch_fork_info): Update.
11217         * infrun.c (displaced_step_prepare): Update.
11218         * infcall.c (call_function_by_hand_dummy): Update.
11219         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11220         * gnu-v3-abi.c (print_one_vtable): Update.
11221         * frame.c (get_prev_frame_always): Update.
11222         * f-valprint.c (info_common_command_for_block): Update.
11223         * exec.c (try_open_exec_file): Update.
11224         * exceptions.c (print_exception, exception_print)
11225         (exception_fprintf, exception_print_same): Update.
11226         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11227         * dwarf-index-cache.c (index_cache::store)
11228         (index_cache::lookup_gdb_index): Update.
11229         * darwin-nat.c (maybe_cache_shell): Update.
11230         * cp-valprint.c (cp_print_value_fields): Update.
11231         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11232         (gcc_cplus_symbol_address): Update.
11233         * compile/compile-c-symbols.c (gcc_convert_symbol)
11234         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11235         * common/selftest.c: Update.
11236         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11237         a std::string.
11238         (exception_try_scope_entry, exception_try_scope_exit): Don't
11239         declare.
11240         (struct exception_try_scope): Remove.
11241         (TRY): Don't use exception_try_scope.
11242         (struct gdb_exception): Add constructor, operator=.
11243         <what>: New method.
11244         (struct gdb_exception_RETURN_MASK_ALL)
11245         (struct gdb_exception_RETURN_MASK_ERROR)
11246         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11247         (struct gdb_quit_bad_alloc): Update.
11248         * common/common-exceptions.c (exception_none): Change
11249         initializer.
11250         (struct catcher) <state, exception>: Initialize inline.
11251         <prev>: Remove member.
11252         (current_catcher): Remove.
11253         (catchers): New global.
11254         (exceptions_state_mc_init): Simplify.
11255         (catcher_pop): Remove.
11256         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11257         (try_scope_depth, exception_try_scope_entry)
11258         (exception_try_scope_exit): Remove.
11259         (throw_exception_sjlj): Update.
11260         (exception_messages, exception_messages_size): Remove.
11261         (throw_it): Simplify.
11262         (gdb_exception_sliced_copy): Remove.
11263         (throw_exception_cxx): Update.
11264         * cli/cli-script.c (script_from_file): Update.
11265         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11266         Update.
11267         * ada-valprint.c (ada_val_print): Update.
11268         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11269         (create_excep_cond_exprs): Update.
11270
11271 2019-04-08  Tom Tromey  <tom@tromey.com>
11272
11273         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11274         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11275         (TRY, CATCH, END_CATCH): Remove some definitions.
11276         * common/common-exceptions.c: Don't use GDB_XCPT.
11277         (catcher_list_size): Remove.
11278         (throw_exception, throw_it): Simplify.
11279
11280 2019-04-05  Tom Tromey  <tom@tromey.com>
11281
11282         Revert the header-sorting patch.
11283         * ft32-tdep.c: Revert.
11284         * frv-tdep.c: Revert.
11285         * frv-linux-tdep.c: Revert.
11286         * frame.c: Revert.
11287         * frame-unwind.c: Revert.
11288         * frame-base.c: Revert.
11289         * fork-child.c: Revert.
11290         * findvar.c: Revert.
11291         * findcmd.c: Revert.
11292         * filesystem.c: Revert.
11293         * filename-seen-cache.h: Revert.
11294         * filename-seen-cache.c: Revert.
11295         * fbsd-tdep.c: Revert.
11296         * fbsd-nat.h: Revert.
11297         * fbsd-nat.c: Revert.
11298         * f-valprint.c: Revert.
11299         * f-typeprint.c: Revert.
11300         * f-lang.c: Revert.
11301         * extension.h: Revert.
11302         * extension.c: Revert.
11303         * extension-priv.h: Revert.
11304         * expprint.c: Revert.
11305         * exec.h: Revert.
11306         * exec.c: Revert.
11307         * exceptions.c: Revert.
11308         * event-top.c: Revert.
11309         * event-loop.c: Revert.
11310         * eval.c: Revert.
11311         * elfread.c: Revert.
11312         * dwarf2read.h: Revert.
11313         * dwarf2read.c: Revert.
11314         * dwarf2loc.c: Revert.
11315         * dwarf2expr.h: Revert.
11316         * dwarf2expr.c: Revert.
11317         * dwarf2-frame.c: Revert.
11318         * dwarf2-frame-tailcall.c: Revert.
11319         * dwarf-index-write.h: Revert.
11320         * dwarf-index-write.c: Revert.
11321         * dwarf-index-common.c: Revert.
11322         * dwarf-index-cache.h: Revert.
11323         * dwarf-index-cache.c: Revert.
11324         * dummy-frame.c: Revert.
11325         * dtrace-probe.c: Revert.
11326         * disasm.h: Revert.
11327         * disasm.c: Revert.
11328         * disasm-selftests.c: Revert.
11329         * dictionary.c: Revert.
11330         * dicos-tdep.c: Revert.
11331         * demangle.c: Revert.
11332         * dcache.h: Revert.
11333         * dcache.c: Revert.
11334         * darwin-nat.h: Revert.
11335         * darwin-nat.c: Revert.
11336         * darwin-nat-info.c: Revert.
11337         * d-valprint.c: Revert.
11338         * d-namespace.c: Revert.
11339         * d-lang.c: Revert.
11340         * ctf.c: Revert.
11341         * csky-tdep.c: Revert.
11342         * csky-linux-tdep.c: Revert.
11343         * cris-tdep.c: Revert.
11344         * cris-linux-tdep.c: Revert.
11345         * cp-valprint.c: Revert.
11346         * cp-support.c: Revert.
11347         * cp-namespace.c: Revert.
11348         * cp-abi.c: Revert.
11349         * corelow.c: Revert.
11350         * corefile.c: Revert.
11351         * continuations.c: Revert.
11352         * completer.h: Revert.
11353         * completer.c: Revert.
11354         * complaints.c: Revert.
11355         * coffread.c: Revert.
11356         * coff-pe-read.c: Revert.
11357         * cli-out.h: Revert.
11358         * cli-out.c: Revert.
11359         * charset.c: Revert.
11360         * c-varobj.c: Revert.
11361         * c-valprint.c: Revert.
11362         * c-typeprint.c: Revert.
11363         * c-lang.c: Revert.
11364         * buildsym.c: Revert.
11365         * buildsym-legacy.c: Revert.
11366         * build-id.h: Revert.
11367         * build-id.c: Revert.
11368         * btrace.c: Revert.
11369         * bsd-uthread.c: Revert.
11370         * breakpoint.h: Revert.
11371         * breakpoint.c: Revert.
11372         * break-catch-throw.c: Revert.
11373         * break-catch-syscall.c: Revert.
11374         * break-catch-sig.c: Revert.
11375         * blockframe.c: Revert.
11376         * block.c: Revert.
11377         * bfin-tdep.c: Revert.
11378         * bfin-linux-tdep.c: Revert.
11379         * bfd-target.c: Revert.
11380         * bcache.c: Revert.
11381         * ax-general.c: Revert.
11382         * ax-gdb.h: Revert.
11383         * ax-gdb.c: Revert.
11384         * avr-tdep.c: Revert.
11385         * auxv.c: Revert.
11386         * auto-load.c: Revert.
11387         * arm-wince-tdep.c: Revert.
11388         * arm-tdep.c: Revert.
11389         * arm-symbian-tdep.c: Revert.
11390         * arm-pikeos-tdep.c: Revert.
11391         * arm-obsd-tdep.c: Revert.
11392         * arm-nbsd-tdep.c: Revert.
11393         * arm-nbsd-nat.c: Revert.
11394         * arm-linux-tdep.c: Revert.
11395         * arm-linux-nat.c: Revert.
11396         * arm-fbsd-tdep.c: Revert.
11397         * arm-fbsd-nat.c: Revert.
11398         * arm-bsd-tdep.c: Revert.
11399         * arch-utils.c: Revert.
11400         * arc-tdep.c: Revert.
11401         * arc-newlib-tdep.c: Revert.
11402         * annotate.h: Revert.
11403         * annotate.c: Revert.
11404         * amd64-windows-tdep.c: Revert.
11405         * amd64-windows-nat.c: Revert.
11406         * amd64-tdep.c: Revert.
11407         * amd64-sol2-tdep.c: Revert.
11408         * amd64-obsd-tdep.c: Revert.
11409         * amd64-obsd-nat.c: Revert.
11410         * amd64-nbsd-tdep.c: Revert.
11411         * amd64-nbsd-nat.c: Revert.
11412         * amd64-nat.c: Revert.
11413         * amd64-linux-tdep.c: Revert.
11414         * amd64-linux-nat.c: Revert.
11415         * amd64-fbsd-tdep.c: Revert.
11416         * amd64-fbsd-nat.c: Revert.
11417         * amd64-dicos-tdep.c: Revert.
11418         * amd64-darwin-tdep.c: Revert.
11419         * amd64-bsd-nat.c: Revert.
11420         * alpha-tdep.c: Revert.
11421         * alpha-obsd-tdep.c: Revert.
11422         * alpha-nbsd-tdep.c: Revert.
11423         * alpha-mdebug-tdep.c: Revert.
11424         * alpha-linux-tdep.c: Revert.
11425         * alpha-linux-nat.c: Revert.
11426         * alpha-bsd-tdep.c: Revert.
11427         * alpha-bsd-nat.c: Revert.
11428         * aix-thread.c: Revert.
11429         * agent.c: Revert.
11430         * addrmap.c: Revert.
11431         * ada-varobj.c: Revert.
11432         * ada-valprint.c: Revert.
11433         * ada-typeprint.c: Revert.
11434         * ada-tasks.c: Revert.
11435         * ada-lang.c: Revert.
11436         * aarch64-tdep.c: Revert.
11437         * aarch64-ravenscar-thread.c: Revert.
11438         * aarch64-newlib-tdep.c: Revert.
11439         * aarch64-linux-tdep.c: Revert.
11440         * aarch64-linux-nat.c: Revert.
11441         * aarch64-fbsd-tdep.c: Revert.
11442         * aarch64-fbsd-nat.c: Revert.
11443         * aarch32-linux-nat.c: Revert.
11444
11445 2019-04-05  Tom Tromey  <tom@tromey.com>
11446
11447         * ft32-tdep.c: Sort headers.
11448         * frv-tdep.c: Sort headers.
11449         * frv-linux-tdep.c: Sort headers.
11450         * frame.c: Sort headers.
11451         * frame-unwind.c: Sort headers.
11452         * frame-base.c: Sort headers.
11453         * fork-child.c: Sort headers.
11454         * findvar.c: Sort headers.
11455         * findcmd.c: Sort headers.
11456         * filesystem.c: Sort headers.
11457         * filename-seen-cache.h: Sort headers.
11458         * filename-seen-cache.c: Sort headers.
11459         * fbsd-tdep.c: Sort headers.
11460         * fbsd-nat.h: Sort headers.
11461         * fbsd-nat.c: Sort headers.
11462         * f-valprint.c: Sort headers.
11463         * f-typeprint.c: Sort headers.
11464         * f-lang.c: Sort headers.
11465         * extension.h: Sort headers.
11466         * extension.c: Sort headers.
11467         * extension-priv.h: Sort headers.
11468         * expprint.c: Sort headers.
11469         * exec.h: Sort headers.
11470         * exec.c: Sort headers.
11471         * exceptions.c: Sort headers.
11472         * event-top.c: Sort headers.
11473         * event-loop.c: Sort headers.
11474         * eval.c: Sort headers.
11475         * elfread.c: Sort headers.
11476         * dwarf2read.h: Sort headers.
11477         * dwarf2read.c: Sort headers.
11478         * dwarf2loc.c: Sort headers.
11479         * dwarf2expr.h: Sort headers.
11480         * dwarf2expr.c: Sort headers.
11481         * dwarf2-frame.c: Sort headers.
11482         * dwarf2-frame-tailcall.c: Sort headers.
11483         * dwarf-index-write.h: Sort headers.
11484         * dwarf-index-write.c: Sort headers.
11485         * dwarf-index-common.c: Sort headers.
11486         * dwarf-index-cache.h: Sort headers.
11487         * dwarf-index-cache.c: Sort headers.
11488         * dummy-frame.c: Sort headers.
11489         * dtrace-probe.c: Sort headers.
11490         * disasm.h: Sort headers.
11491         * disasm.c: Sort headers.
11492         * disasm-selftests.c: Sort headers.
11493         * dictionary.c: Sort headers.
11494         * dicos-tdep.c: Sort headers.
11495         * demangle.c: Sort headers.
11496         * dcache.h: Sort headers.
11497         * dcache.c: Sort headers.
11498         * darwin-nat.h: Sort headers.
11499         * darwin-nat.c: Sort headers.
11500         * darwin-nat-info.c: Sort headers.
11501         * d-valprint.c: Sort headers.
11502         * d-namespace.c: Sort headers.
11503         * d-lang.c: Sort headers.
11504         * ctf.c: Sort headers.
11505         * csky-tdep.c: Sort headers.
11506         * csky-linux-tdep.c: Sort headers.
11507         * cris-tdep.c: Sort headers.
11508         * cris-linux-tdep.c: Sort headers.
11509         * cp-valprint.c: Sort headers.
11510         * cp-support.c: Sort headers.
11511         * cp-namespace.c: Sort headers.
11512         * cp-abi.c: Sort headers.
11513         * corelow.c: Sort headers.
11514         * corefile.c: Sort headers.
11515         * continuations.c: Sort headers.
11516         * completer.h: Sort headers.
11517         * completer.c: Sort headers.
11518         * complaints.c: Sort headers.
11519         * coffread.c: Sort headers.
11520         * coff-pe-read.c: Sort headers.
11521         * cli-out.h: Sort headers.
11522         * cli-out.c: Sort headers.
11523         * charset.c: Sort headers.
11524         * c-varobj.c: Sort headers.
11525         * c-valprint.c: Sort headers.
11526         * c-typeprint.c: Sort headers.
11527         * c-lang.c: Sort headers.
11528         * buildsym.c: Sort headers.
11529         * buildsym-legacy.c: Sort headers.
11530         * build-id.h: Sort headers.
11531         * build-id.c: Sort headers.
11532         * btrace.c: Sort headers.
11533         * bsd-uthread.c: Sort headers.
11534         * breakpoint.h: Sort headers.
11535         * breakpoint.c: Sort headers.
11536         * break-catch-throw.c: Sort headers.
11537         * break-catch-syscall.c: Sort headers.
11538         * break-catch-sig.c: Sort headers.
11539         * blockframe.c: Sort headers.
11540         * block.c: Sort headers.
11541         * bfin-tdep.c: Sort headers.
11542         * bfin-linux-tdep.c: Sort headers.
11543         * bfd-target.c: Sort headers.
11544         * bcache.c: Sort headers.
11545         * ax-general.c: Sort headers.
11546         * ax-gdb.h: Sort headers.
11547         * ax-gdb.c: Sort headers.
11548         * avr-tdep.c: Sort headers.
11549         * auxv.c: Sort headers.
11550         * auto-load.c: Sort headers.
11551         * arm-wince-tdep.c: Sort headers.
11552         * arm-tdep.c: Sort headers.
11553         * arm-symbian-tdep.c: Sort headers.
11554         * arm-pikeos-tdep.c: Sort headers.
11555         * arm-obsd-tdep.c: Sort headers.
11556         * arm-nbsd-tdep.c: Sort headers.
11557         * arm-nbsd-nat.c: Sort headers.
11558         * arm-linux-tdep.c: Sort headers.
11559         * arm-linux-nat.c: Sort headers.
11560         * arm-fbsd-tdep.c: Sort headers.
11561         * arm-fbsd-nat.c: Sort headers.
11562         * arm-bsd-tdep.c: Sort headers.
11563         * arch-utils.c: Sort headers.
11564         * arc-tdep.c: Sort headers.
11565         * arc-newlib-tdep.c: Sort headers.
11566         * annotate.h: Sort headers.
11567         * annotate.c: Sort headers.
11568         * amd64-windows-tdep.c: Sort headers.
11569         * amd64-windows-nat.c: Sort headers.
11570         * amd64-tdep.c: Sort headers.
11571         * amd64-sol2-tdep.c: Sort headers.
11572         * amd64-obsd-tdep.c: Sort headers.
11573         * amd64-obsd-nat.c: Sort headers.
11574         * amd64-nbsd-tdep.c: Sort headers.
11575         * amd64-nbsd-nat.c: Sort headers.
11576         * amd64-nat.c: Sort headers.
11577         * amd64-linux-tdep.c: Sort headers.
11578         * amd64-linux-nat.c: Sort headers.
11579         * amd64-fbsd-tdep.c: Sort headers.
11580         * amd64-fbsd-nat.c: Sort headers.
11581         * amd64-dicos-tdep.c: Sort headers.
11582         * amd64-darwin-tdep.c: Sort headers.
11583         * amd64-bsd-nat.c: Sort headers.
11584         * alpha-tdep.c: Sort headers.
11585         * alpha-obsd-tdep.c: Sort headers.
11586         * alpha-nbsd-tdep.c: Sort headers.
11587         * alpha-mdebug-tdep.c: Sort headers.
11588         * alpha-linux-tdep.c: Sort headers.
11589         * alpha-linux-nat.c: Sort headers.
11590         * alpha-bsd-tdep.c: Sort headers.
11591         * alpha-bsd-nat.c: Sort headers.
11592         * aix-thread.c: Sort headers.
11593         * agent.c: Sort headers.
11594         * addrmap.c: Sort headers.
11595         * ada-varobj.c: Sort headers.
11596         * ada-valprint.c: Sort headers.
11597         * ada-typeprint.c: Sort headers.
11598         * ada-tasks.c: Sort headers.
11599         * ada-lang.c: Sort headers.
11600         * aarch64-tdep.c: Sort headers.
11601         * aarch64-ravenscar-thread.c: Sort headers.
11602         * aarch64-newlib-tdep.c: Sort headers.
11603         * aarch64-linux-tdep.c: Sort headers.
11604         * aarch64-linux-nat.c: Sort headers.
11605         * aarch64-fbsd-tdep.c: Sort headers.
11606         * aarch64-fbsd-nat.c: Sort headers.
11607         * aarch32-linux-nat.c: Sort headers.
11608
11609 2019-04-04  Tom Tromey  <tom@tromey.com>
11610
11611         * varobj.c (varobj_create): Update.
11612         * rust-exp.y (struct rust_parser) <update_innermost_block,
11613         lookup_symbol>: New methods.
11614         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11615         Rename.
11616         (rust_parser::rust_lookup_type)
11617         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11618         * printcmd.c (display_command, do_one_display): Update.
11619         * parser-defs.h (struct parser_state) <parser_state>: Add
11620         "tracker" parameter.
11621         (block_tracker): New member.
11622         (class innermost_block_tracker) <innermost_block_tracker>: Add
11623         "types" parameter.
11624         <reset>: Remove method.
11625         (innermost_block): Don't declare.
11626         (null_post_parser): Update.
11627         * parse.c (innermost_block): Remove global.
11628         (write_dollar_variable): Update.
11629         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11630         Remove "tracker_types" parameter.
11631         (parse_expression): Add "tracker" parameter.
11632         (parse_expression_for_completion): Update.
11633         (null_post_parser): Add "tracker" parameter.
11634         * p-exp.y: Update rules.
11635         * m2-exp.y: Update rules.
11636         * language.h (struct language_defn) <la_post_parser>: Add
11637         "tracker" parameter.
11638         * go-exp.y: Update rules.
11639         * f-exp.y: Update rules.
11640         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11641         parameter.
11642         * d-exp.y: Update rules.
11643         * c-exp.y: Update rules.
11644         * breakpoint.c (set_breakpoint_condition): Create an
11645         innermost_block_tracker.
11646         (watch_command_1): Likewise.
11647         * ada-lang.c (resolve): Add "tracker" parameter.
11648         (resolve_subexp): Likewise.
11649         * ada-exp.y (write_var_from_sym): Update.
11650
11651 2019-04-04  Tom Tromey  <tom@tromey.com>
11652
11653         * type-stack.h: New file.
11654         * type-stack.c: New file.
11655         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11656         type-stack.h.
11657         (insert_into_type_stack, insert_type, push_type, push_type_int)
11658         (insert_type_address_space, pop_type, pop_type_int)
11659         (pop_typelist, pop_type_stack, append_type_stack)
11660         (push_type_stack, get_type_stack, push_typelist)
11661         (follow_type_instance_flags, follow_types): Don't declare.
11662         * parse.c (type_stack): Remove global.
11663         (parse_exp_in_context): Update.
11664         (insert_into_type_stack, insert_type, push_type, push_type_int)
11665         (insert_type_address_space, pop_type, pop_type_int)
11666         (pop_typelist, pop_type_stack, append_type_stack)
11667         (push_type_stack, get_type_stack, push_typelist)
11668         (follow_type_instance_flags, follow_types): Remove (moved to
11669         type-stack.c).
11670         * f-exp.y (type_stack): New global.
11671         Update rules.
11672         (push_kind_type, f_parse): Update.
11673         * d-exp.y (type_stack): New global.
11674         Update rules.
11675         (d_parse): Update.
11676         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11677         Update rules.
11678         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11679         (HFILES_NO_SRCDIR): Add type-stack.h.
11680
11681 2019-04-04  Tom Tromey  <tom@tromey.com>
11682
11683         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11684         (rust_parser::convert_ast_to_expression, rust_parse)
11685         (rust_lex_test_completion, rust_lex_tests): Update.
11686         * parser-defs.h (struct expr_completion_state): New.
11687         (struct parser_state) <parser_state>: Add completion parameter.
11688         <mark_struct_expression, mark_completion_tag>: New methods.
11689         <parse_completion, m_completion_state>: New members.
11690         (prefixify_expression, null_post_parser): Update.
11691         (mark_struct_expression, mark_completion_tag): Don't declare.
11692         * parse.c (parse_completion, expout_last_struct)
11693         (expout_tag_completion_type, expout_completion_name): Remove
11694         globals.
11695         (parser_state::mark_struct_expression)
11696         (parser_state::mark_completion_tag): Now methods.
11697         (prefixify_expression): Add last_struct parameter.
11698         (prefixify_subexp): Likewise.
11699         (parse_exp_1): Update.
11700         (parse_exp_in_context): Add cstate parameter.  Update.
11701         (parse_expression_for_completion): Create an
11702         expr_completion_state.
11703         (null_post_parser): Add "completion" parameter.
11704         * p-exp.y: Update rules.
11705         (yylex): Update.
11706         * language.h (struct language_defn) <la_post_parser>: Add
11707         "completing" parameter.
11708         * go-exp.y: Update rules.
11709         (lex_one_token): Update.
11710         * expression.h (parse_completion): Don't declare.
11711         * d-exp.y: Update rules.
11712         (lex_one_token): Update rules.
11713         * c-exp.y: Update rules.
11714         (lex_one_token): Update.
11715         * ada-lang.c (resolve): Add "parse_completion" parameter.
11716         (resolve_subexp): Likewise.
11717         (ada_resolve_function): Likewise.
11718
11719 2019-04-04  Tom Tromey  <tom@tromey.com>
11720
11721         * parser-defs.h (struct parser_state) <start_arglist,
11722         end_arglist>: New methods.
11723         <arglist_len, m_funcall_chain>: New members.
11724         (arglist_len, start_arglist, end_arglist): Don't declare.
11725         * parse.c (arglist_len, funcall_chain): Remove global.
11726         (start_arglist, end_arglist): Remove functions.
11727         (parse_exp_in_context): Update.
11728         * p-exp.y: Update rules.
11729         * m2-exp.y: Update rules.
11730         * go-exp.y: Update rules.
11731         * f-exp.y: Update rules.
11732         * d-exp.y: Update rules.
11733         * c-exp.y: Update rules.
11734
11735 2019-04-04  Tom Tromey  <tom@tromey.com>
11736
11737         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11738         lex_operator, push_back>: New methods.
11739         Update all rules.
11740         (rust_parser::lex_hex, lex_escape): Rename and update.
11741         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11742         (rust_parser::lex_operator): Rename and update.
11743         (rust_parser::lex_number, rustyylex, rustyyerror)
11744         (rust_lex_test_init, rust_lex_test_sequence)
11745         (rust_lex_test_push_back, rust_lex_tests): Update.
11746         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11747         parameter.
11748         <lexptr, prev_lexptr>: New members.
11749         (lexptr, prev_lexptr): Don't declare.
11750         * parse.c (lexptr, prev_lexptr): Remove globals.
11751         (parse_exp_in_context): Update.
11752         * p-exp.y (yylex, yyerror): Update.
11753         * m2-exp.y (parse_number, yylex, yyerror): Update.
11754         * go-exp.y (lex_one_token, yyerror): Update.
11755         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11756         * d-exp.y (lex_one_token, yyerror): Update.
11757         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11758         (lex_one_token, yyerror): Update.
11759         * ada-lex.l (YY_INPUT): Update.
11760         (rewind_to_char): Update.
11761         * ada-exp.y (yyerror): Update.
11762
11763 2019-04-04  Tom Tromey  <tom@tromey.com>
11764
11765         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11766         * parser-defs.h (struct parser_state) <parser_state>: Add new
11767         parameter.
11768         <comma_terminates>: New member.
11769         (comma_terminates): Don't declare global.
11770         * parse.c (comma_terminates): Remove global.
11771         (parse_exp_in_context): Update.
11772         * p-exp.y (yylex): Update.
11773         * m2-exp.y (yylex): Update.
11774         * go-exp.y (lex_one_token): Update.
11775         * f-exp.y (yylex): Update.
11776         * d-exp.y (lex_one_token): Update.
11777         * c-exp.y (lex_one_token): Update.
11778         * ada-lex.l: Update.
11779
11780 2019-04-04  Tom Tromey  <tom@tromey.com>
11781
11782         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11783         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11784         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11785         * parser-defs.h (paren_depth): Don't declare.
11786         * parse.c (paren_depth): Remove global.
11787         (parse_exp_in_context): Update.
11788         * p-exp.y (paren_depth): New global.
11789         (pascal_parse): Initialize it.
11790         * m2-exp.y (paren_depth): New global.
11791         (m2_parse): Initialize it.
11792         * go-exp.y (paren_depth): New global.
11793         (go_parse): Initialize it.
11794         * f-exp.y (paren_depth): New global.
11795         (f_parse): Initialize it.
11796         * d-exp.y (paren_depth): New global.
11797         (d_parse): Initialize it.
11798         * c-exp.y (paren_depth): New global.
11799         (c_parse): Initialize it.
11800         * ada-lex.l (paren_depth): New global.
11801         (lexer_init): Initialize it.
11802
11803 2019-04-04  Tom Tromey  <tom@tromey.com>
11804
11805         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11806         (rust_parser::convert_ast_to_type)
11807         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11808         * parser-defs.h (struct parser_state) <parser_state>: Add
11809         parameters.  Initialize new members.
11810         <expression_context_block, expression_context_pc>: New members.
11811         * parse.c (expression_context_block, expression_context_pc):
11812         Remove globals.
11813         (parse_exp_in_context): Update.
11814         * p-exp.y: Update all rules.
11815         (yylex): Update.
11816         * m2-exp.y: Update all rules.
11817         (yylex): Update.
11818         * go-exp.y (yylex): Update.
11819         * f-exp.y (yylex): Update.
11820         * d-exp.y: Update all rules.
11821         (yylex): Update.
11822         * c-exp.y: Update all rules.
11823         (lex_one_token, classify_name, yylex, c_parse): Update.
11824         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11825
11826 2019-04-04  Tom Tromey  <tom@tromey.com>
11827
11828         * gdbarch.h, gdbarch.c: Rebuild.
11829         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11830         * stap-probe.h:
11831         (struct stap_parse_info): Replace "parser_state" with
11832         "expr_builder".
11833         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11834         (parser_state): New class.
11835         * parse.c (expr_builder): Rename.
11836         (expr_builder::release): Rename.
11837         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11838         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11839         (write_exp_elt_longcst, write_exp_elt_floatcst)
11840         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11841         (write_exp_string_vector, write_exp_bitstring)
11842         (write_exp_msymbol, mark_struct_expression)
11843         (write_dollar_variable)
11844         (insert_type_address_space, increase_expout_size): Replace
11845         "parser_state" with "expr_builder".
11846         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11847         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11848         "parser_state" with "expr_builder".
11849
11850 2019-04-04  Tom Tromey  <tom@tromey.com>
11851
11852         * rust-exp.y: Replace "parse_language" with method call.
11853         * p-exp.y:
11854         (yylex): Replace "parse_language" with method call.
11855         * m2-exp.y:
11856         (yylex): Replace "parse_language" with method call.
11857         * go-exp.y (classify_name): Replace "parse_language" with method
11858         call.
11859         * f-exp.y (yylex): Replace "parse_language" with method call.
11860         * d-exp.y (lex_one_token): Replace "parse_language" with method
11861         call.
11862         * c-exp.y:
11863         (lex_one_token, classify_name, yylex): Replace "parse_language"
11864         with method call.
11865         * ada-exp.y (find_primitive_type, type_char)
11866         (type_system_address): Replace "parse_language" with method call.
11867
11868 2019-04-04  Tom Tromey  <tom@tromey.com>
11869
11870         * rust-exp.y: Replace "parse_gdbarch" with method call.
11871         * parse.c (write_dollar_variable, insert_type_address_space):
11872         Replace "parse_gdbarch" with method call.
11873         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11874         call.
11875         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11876         call.
11877         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11878         "parse_gdbarch" with method call.
11879         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11880         with method call.
11881         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11882         "parse_gdbarch" with method call.
11883         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11884         "parse_gdbarch" with method call.
11885         * c-exp.y (parse_type, parse_number, classify_name): Replace
11886         "parse_gdbarch" with method call.
11887         * ada-lex.l: Replace "parse_gdbarch" with method call.
11888         * ada-exp.y (parse_type, find_primitive_type, type_char)
11889         (type_system_address): Replace "parse_gdbarch" with method call.
11890
11891 2019-04-04  Tom Tromey  <tom@tromey.com>
11892
11893         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11894         * stap-probe.c (stap_parse_argument): Update.
11895         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11896         initial_size parameter.
11897         * rust-exp.y (rust_lex_tests): Update.
11898         * parse.c (parser_state): Update.
11899         (parse_exp_in_context): Update.
11900         * parser-defs.h (struct parser_state) <parser_state>: Remove
11901         "initial_size" parameter.
11902
11903 2019-04-04  Tom Tromey  <tom@tromey.com>
11904
11905         * parser-defs.h (increase_expout_size): Don't declare.
11906         * parse.c (increase_expout_size): Now static.
11907
11908 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11909
11910         * gnu-nat.c (gnu_nat_target::wait): Fix
11911         target_waitstatus_to_string call.
11912
11913 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11914
11915         * eval.c (evaluate_subexp_standard): Handle internal functions
11916         during Fortran function call handling.
11917
11918 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * NEWS: Mention new internal functions.
11921         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11922         (read_base_type): Use dwarf2_init_complex_target_type.
11923         * value.c (creal_internal_fn): New function.
11924         (cimag_internal_fn): New function.
11925         (_initialize_values): Register new internal functions.
11926
11927 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11928
11929         * infrun.c (stop_all_threads): If debug_infrun, always
11930         trace the wait status after wait_one, using
11931         target_waitstatus_to_string and target_pid_to_str.
11932         (handle_inferior_event): Replace various trace of
11933         wait status kind by a single trace.
11934         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11935         wait status kind image by target_waitstatus_to_string.
11936         * target/waitstatus.c (target_waitstatus_to_string): Fix
11937         obsolete comment.
11938
11939 2019-04-01  Tom Tromey  <tromey@adacore.com>
11940
11941         PR symtab/23331:
11942         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11943
11944 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11945             Pedro Alves  <palves@redhat.com>
11946
11947         * top.c (quit_force): Call 'finalize_values'.
11948         * value.c (finalize_values): New function.
11949         * value.h (finalize_values): Declare.
11950
11951 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11952
11953         * NEWS: Announce $_gdb_major and $_gdb_minor.
11954
11955         * top.c (init_gdb_version_vars): New function.
11956         (gdb_init): Call init_gdb_version_vars.
11957
11958 2019-03-29  Tom Tromey  <tromey@adacore.com>
11959
11960         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11961         help text.  Remove dead code.
11962
11963 2019-03-29  Keith Seitz  <keiths@redhat.com>
11964
11965         From Siddhesh Poyarekar:
11966         * f-lang.h (f77_get_upperbound): Return LONGEST.
11967         (f77_get_lowerbound): Likewise.
11968         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11969         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11970         print them.
11971         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11972         plongest to format print it.
11973         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11974         (f77_get_upperbound): Likewise.
11975         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11976         LOWER_BOUND to LONGEST.
11977         (f77_create_arrayprint_offset_tbl): Likewise.
11978
11979 2019-03-29  Keith Seitz  <keiths@redhat.com>
11980
11981         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11982         %s/pulongest for TYPE_LENGTH instead of %d in format
11983         strings.
11984         * ada-typerint.c (ada_print_type): Likewise.
11985         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11986         * compile/compile-c-support.c (generate_register_struct): Likewise.
11987         * gdbtypes.c (recursive_dump_type): Likewise.
11988         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11989         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11990         instead of %d in format strings.
11991         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11992         to std::min to ULONGEST.
11993         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11994         instead of %d in format strings.
11995         * tracepoint.c (info_scope_command): Likewise.
11996         * typeprint.c (print_offset_data::update)
11997         (print_offset_data::finish): Likewise.
11998         * xtensa-tdep.c (xtensa_store_return_value)
11999         (xtensa_push_dummy_call): Likewise.
12000
12001 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12002
12003         * windows-nat.c (display_selector): Fixed format specifications
12004         for 64-bit Cygwin.
12005
12006 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12007
12008         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12009
12010 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12011
12012         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12013         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12014         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12015         (nios2_linux_init_abi): Install it.
12016
12017 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12018
12019         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12020
12021 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12022
12023         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12024
12025 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12026             Tom Tromey  <tromey@adacore.com>
12027
12028         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12029
12030 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12031
12032         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12033         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12034         method to compute the bounds of range types. Also print "[evaluated]"
12035         if the bounds' values come from a dynamic evaluation.
12036
12037 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12038
12039         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12040         whitespace when pretty printing is on.
12041
12042 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12043
12044         * ppc-linux-nat.c: Add include.
12045
12046 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12047
12048         * NEWS: Mention AArch64 Pointer Authentication.
12049
12050 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12051
12052         * arm-linux-nat.c: Add include.
12053
12054 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12055
12056         * source-cache.c (source_cache::get_source_lines): Re-read
12057         fullname after calling open_source_file.
12058
12059 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12060
12061         * NEWS: Mention TLS support for FreeBSD.
12062
12063 2019-03-25  Tom Tromey  <tromey@adacore.com>
12064
12065         * minsyms.c (BUNCH_SIZE): Update comment.
12066         (~minimal_symbol_reader): Remove old comment.
12067         (compact_minimal_symbols): Update comment.
12068         (minimal_symbol_reader::install): Remove old comment.  Update
12069         other comments.
12070
12071 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12072
12073         * s390-linux-nat.c: Add include.
12074
12075 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12076
12077         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12078         Call linux_get_hwcap.
12079         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12080         Likewise.
12081         (aarch64_linux_get_hwcap): Remove function.
12082         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12083         declaration.
12084         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12085         linux_get_hwcap.
12086         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12087         * linux-tdep.c (linux_get_hwcap): Add function.
12088         (linux_get_hwcap2): Likewise.
12089         * linux-tdep.h (linux_get_hwcap): Add declaration.
12090         (linux_get_hwcap2): Likewise.
12091         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12092         (ppc_linux_get_hwcap2): Likewise.
12093         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12094         linux_get_hwcap.
12095         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12096         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12097         (ppc_linux_nat_target::read_description): Likewise.
12098         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12099         * s390-linux-nat.c: Likewise.
12100         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12101
12102 2019-03-24  Tom Tromey  <tom@tromey.com>
12103
12104         * ada-lang.c (standard_lookup): Simplify initialization.
12105         (ada_lookup_symbol_nonlocal): Simplify return.
12106         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12107         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12108         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12109         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12110         initialization.
12111         * solib.c (solib_global_lookup): Simplify.
12112         * symtab.c (null_block_symbol): Remove.
12113         (symbol_cache_lookup): Simplify returns.
12114         (lookup_language_this): Simplify returns.
12115         (lookup_symbol_aux): Simplify return.
12116         (lookup_local_symbol): Simplify returns.
12117         (lookup_global_symbol_from_objfile): Simplify return.
12118         (lookup_symbol_in_objfile_symtabs)
12119         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12120         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12121         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12122         * cp-namespace.c (cp_lookup_bare_symbol)
12123         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12124         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12125         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12126         (cp_lookup_symbol_via_imports): Simplify initialization.
12127         (find_symbol_in_baseclass): Likewise.
12128         * symtab.h (null_block_symbol): Remove.
12129         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12130         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12131         (d_lookup_symbol_module): Likewise.
12132         (find_symbol_in_baseclass): Simplify initialization.
12133
12134 2019-03-24  Tom Tromey  <tom@tromey.com>
12135
12136         * expression.h: Don't include symtab.h.
12137         (struct block): Forward declare.
12138
12139 2019-03-24  Tom Tromey  <tom@tromey.com>
12140
12141         * c-exp.y (typebase): Remove casts.
12142         * gdbtypes.c (lookup_unsigned_typename, )
12143         (lookup_signed_typename): Remove cast.
12144         * eval.c (parse_to_comma_and_eval): Remove cast.
12145         * parse.c (write_dollar_variable): Remove cast.
12146         * block.h (struct block) <superblock>: Now const.
12147         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12148         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12149         (map_block): Make "block" const.
12150         * symfile.h (struct quick_symbol_functions)
12151         <map_matching_symbols>: Constify block argument to "callback".
12152         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12153         const.
12154         (find_pc_sect_compunit_symtab): Make "b" const.
12155         (find_symbol_at_address): Likewise.
12156         (search_symbols): Likewise.
12157         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12158         (dw2_debug_names_lookup_symbol): Likewise.
12159         (dw2_map_matching_symbols): Update.
12160         * p-valprint.c (pascal_val_print): Remove "block".
12161         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12162         (aux_add_nonlocal_symbols): Make "block" const.
12163         (resolve_subexp): Remove cast.
12164         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12165         const.
12166         (iterate_over_file_blocks): Likewise.
12167         * f-exp.y (%union) <bval>: Remove.
12168         * coffread.c (patch_opaque_types): Make "b" const.
12169         * spu-tdep.c (spu_catch_start): Make "block" const.
12170         * c-valprint.c (print_unpacked_pointer): Remove "block".
12171         * symmisc.c (dump_symtab_1): Make "b" const.
12172         (block_depth): Make "block" const.
12173         * d-exp.y (%union) <bval>: Remove.
12174         * cp-support.h (cp_lookup_rtti_type): Update.
12175         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12176         * psymtab.c (psym_lookup_symbol): Make "block" const.
12177         (maintenance_check_psymtabs): Make "b" const.
12178         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12179         (enumerate_locals, enumerate_args): Update.
12180         * python/py-symtab.c (stpy_global_block): Make "block" const.
12181         (stpy_static_block): Likewise.
12182         * inline-frame.c (block_starting_point_at): Make "new_block"
12183         const.
12184         * block.c (find_block_in_blockvector): Make return type const.
12185         (blockvector_for_pc_sect): Make "b" const.
12186         (find_block_in_blockvector): Make "b" const.
12187
12188 2019-03-23  Tom Tromey  <tom@tromey.com>
12189
12190         * varobj.c (varobj_create): Update.
12191         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12192         * printcmd.c (display_command, do_one_display): Don't reset
12193         innermost_block.
12194         * parser-defs.h (enum innermost_block_tracker_type): Move to
12195         expression.h.
12196         (innermost_block): Update comment.
12197         * parse.c (parse_exp_1): Add tracker_types parameter.
12198         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12199         tracker_types parameter.  Reset innermost_block.
12200         (parse_exp_in_context): Remove.
12201         (parse_expression_for_completion): Update.
12202         * objfiles.c (~objfile): Don't reset expression_context_block or
12203         innermost_block.
12204         * expression.h (enum innermost_block_tracker_type): Move from
12205         parser-defs.h.
12206         (parse_exp_1): Add tracker_types parameter.
12207         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12208         reset innermost_block.
12209
12210 2019-03-23  Tom Tromey  <tom@tromey.com>
12211
12212         * objfiles.h: Include bcache.h.
12213
12214 2019-03-23  Tom Tromey  <tom@tromey.com>
12215
12216         * linespec.c (get_current_search_block): Use
12217         scoped_restore_current_language.
12218         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12219
12220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12221             Jiong Wang  <jiong.wang@arm.com>
12222
12223         * aarch64-linux-tdep.c
12224         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12225         section.
12226         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12227
12228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12229             Jiong Wang  <jiong.wang@arm.com>
12230
12231         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12232         instructions.
12233         (aarch64_analyze_prologue_test): Add PACIASP test.
12234         (aarch64_prologue_prev_register): Unmask PC value.
12235
12236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12237             Jiong Wang  <jiong.wang@arm.com>
12238
12239         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12240         (aarch64_dwarf2_prev_register): Unmask PC value.
12241         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12242         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12243         DW_CFA_AARCH64_negate_ra_state.
12244         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12245
12246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12247             Jiong Wang  <jiong.wang@arm.com>
12248
12249         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12250         registers.
12251         (aarch64_pseudo_register_name): Likewise.
12252         (aarch64_pseudo_register_type): Likewise.
12253         (aarch64_pseudo_register_reggroup_p): Likewise.
12254         (aarch64_gdbarch_init): Add pauth registers.
12255         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12256         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12257         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12258         (struct gdbarch_tdep): Add regnum for ra_state.
12259
12260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12261             Jiong Wang  <jiong.wang@arm.com>
12262
12263         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12264
12265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12266             Jiong Wang  <jiong.wang@arm.com>
12267
12268         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12269         function.
12270         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12271         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12272         (aarch64_gdbarch_init): Add puth registers.
12273         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12274         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12275         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12276
12277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12278             Jiong Wang  <jiong.wang@arm.com>
12279
12280         * aarch64-linux-nat.c
12281         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12282         * aarch64-linux-tdep.c
12283         (aarch64_linux_core_read_description): Likewise.
12284         (aarch64_linux_get_hwcap): New function.
12285         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12286         (aarch64_linux_get_hwcap): New declaration.
12287
12288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12289             Jiong Wang  <jiong.wang@arm.com>
12290
12291         * aarch64-linux-nat.c
12292         (aarch64_linux_nat_target::read_description): Add pauth param.
12293         * aarch64-linux-tdep.c
12294         (aarch64_linux_core_read_description): Likewise.
12295         * aarch64-tdep.c (struct target_desc): Add in pauth.
12296         (aarch64_read_description): Add pauth param.
12297         (aarch64_gdbarch_init): Likewise.
12298         * aarch64-tdep.h (aarch64_read_description): Likewise.
12299         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12300         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12301         * features/Makefile: Add new files.
12302         * features/aarch64-pauth.c: New file.
12303         * features/aarch64-pauth.xml: New file.
12304
12305 2019-03-20  Tom Tromey  <tromey@adacore.com>
12306
12307         * infrun.c (handle_inferior_event): Rename from
12308         handle_inferior_event_1.  Create a scoped_value_mark.
12309         (handle_inferior_event): Remove.
12310
12311 2019-03-19  Tom Tromey  <tromey@adacore.com>
12312
12313         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12314         * infrun.h (print_stop_event): Add "displays" parameter.
12315         * infrun.c (print_stop_event): Add "displays" parameter.
12316
12317 2019-03-19  Pedro Alves  <palves@redhat.com>
12318
12319         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12320         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12321         to -1.  Fix TABs vs spaces.
12322         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12323         * tui/tui-out.h (tui_ui_out) Add intro comments.
12324         <m_line, m_start_of_line>: In-class initialize, and add describing
12325         comment.
12326
12327 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12328
12329         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12330         variable names.
12331         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12332
12333 2019-03-18  Pedro Alves  <palves@redhat.com>
12334             Eli Zaretskii <eliz@gnu.org>
12335
12336         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12337         m_line and m_start_of_line.
12338
12339 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12340
12341         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12342         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12343         it returns a newline.  This fixes a regression in TU mode, whereby
12344         the next line is output on the same screen line as the user input.
12345
12346 2019-03-18  Tom Tromey  <tromey@adacore.com>
12347
12348         * minsyms.c (minimal_symbol_reader::install): Remove call to
12349         obstack_blank.
12350
12351 2019-03-18  Pedro Alves  <palves@redhat.com>
12352
12353         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12354         New globals.
12355         (apply_style): New, factored out from ...
12356         (apply_ansi_escape): ... this.  Handle reverse video mode.
12357         (tui_set_reverse_mode): New function.
12358         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12359         * tui/tui-winsource.c (tui_show_source_line): Use
12360         tui_set_reverse_mode instead of setting A_STANDOUT.
12361         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12362         New setter methods.
12363
12364 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12365
12366         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12367         Handle tabs.
12368
12369 2019-03-18  Tom Tromey  <tromey@adacore.com>
12370
12371         * ada-lang.c (empty_array): Add "high" parameter.
12372         (ada_evaluate_subexp): Update.
12373
12374 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12375
12376         * unittests/string_view-selftests.c: Define
12377         _initialize_string_view_selftests unconditionally.
12378
12379 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12380
12381         PR gdb/24350
12382         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12383
12384 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12385
12386         PR gdb/24351
12387         * windows-nat.c (display_selector): Fix format specifiers.
12388
12389 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12390
12391         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12392         tui_refill_source_window instead of tui_refresh_win, to update the
12393         current execution line.  This fixes redisplay of the current line
12394         when stepping through the code with "next" or "step".
12395
12396 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12397
12398         * source-cache.c (source_cache::get_source_lines): Call
12399         find_source_lines to initialize s->nlines.  This fixes vertical
12400         scrolling of TUI source window when the DOWN arrow is pressed.
12401
12402 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12403
12404         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12405         linux-thread-db.c (_initialize_thread_db): Likewise.
12406
12407 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12408
12409         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12410         wclrtoeol in tui_show_source_line".  This reverts changes made in
12411         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12412
12413 2019-03-15  Tom Tromey  <tom@tromey.com>
12414
12415         * symtab.h (struct minimal_symbol): Derive from
12416         general_symbol_info.
12417         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12418         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12419         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12420         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12421         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12422         (MSYMBOL_SEARCH_NAME): Update.
12423         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12424         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12425         * minsyms.c (minimal_symbol_reader::record_full): Update.
12426
12427 2019-03-15  Tom Tromey  <tom@tromey.com>
12428
12429         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12430
12431 2019-03-15  Tom Tromey  <tom@tromey.com>
12432
12433         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12434         unique_xmalloc_ptr.
12435         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12436         Update.
12437         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12438         (build_minimal_symbol_hash_tables)
12439         (minimal_symbol_reader::install): Update.
12440
12441 2019-03-15  Tom Tromey  <tom@tromey.com>
12442
12443         * symtab.c (create_demangled_names_hash): Update.
12444         (symbol_set_names): Update.
12445         * objfiles.h (struct objfile_per_bfd_storage)
12446         <demangled_names_hash>: Now an htab_up.
12447         * objfiles.c (objfile_per_bfd_storage): Simplify.
12448
12449 2019-03-15  Tom Tromey  <tom@tromey.com>
12450
12451         * objfiles.h (struct objfile_per_bfd_storage): Declare
12452         destructor.
12453         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12454         New.
12455         (get_objfile_bfd_data): Use new.  Don't initialize
12456         language_of_main.
12457         (free_objfile_per_bfd_storage): Remove.
12458         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12459
12460 2019-03-15  Tom Tromey  <tom@tromey.com>
12461
12462         * symfile.c (reread_symbols): Update.
12463         * objfiles.c (objfile::objfile): Update.
12464         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12465         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12466         comment.
12467         (minimal_symbol_reader::install): Update.
12468         (terminate_minimal_symbol_table): Remove.
12469         * jit.c (jit_object_close_impl): Update.
12470
12471 2019-03-15  Tom Tromey  <tom@tromey.com>
12472
12473         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12474         initializations.
12475
12476 2019-03-15  Tom Tromey  <tom@tromey.com>
12477
12478         * objfiles.h (struct objfile_per_bfd_storage)
12479         <demangled_hash_languages>: Now a bitset.
12480         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12481         (lookup_minimal_symbol): Update.
12482
12483 2019-03-15  Tom Tromey  <tom@tromey.com>
12484
12485         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12486         Don't return the symbol.
12487         * coffread.c (record_minimal_symbol): Use record_full.
12488
12489 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12490
12491         The MS-Windows port of ncurses fails to switch to a color pair if
12492         one or both of the colors are the implicit default colors.  This
12493         change records the default colors when TUI is initialized, and
12494         then specifies them explicitly when a color pair uses the default
12495         colors.  This allows color styling in TUI mode on MS-Windows.
12496
12497         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12498         ncurses_norm_attr.
12499         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12500         colors in ncurses_norm_attr.
12501         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12502         "none", replace it with the default color recorded in
12503         ncurses_norm_attr.
12504
12505 2019-03-14  Tom Tromey  <tromey@adacore.com>
12506
12507         * source-cache.h (class source_cache) <get_source_lines>: Return
12508         std::string.
12509         * source-cache.c (source_cache::extract_lines): Handle case where
12510         first_pos==npos.  Return std::string.
12511         (source_cache::get_source_lines): Update.
12512
12513 2019-03-14  Tom Tromey  <tromey@adacore.com>
12514
12515         * NEWS: Add item for "style sources" commands.
12516         * source-cache.c (source_cache::get_source_lines): Check
12517         source_styling.
12518         * cli/cli-style.c (source_styling): New global.
12519         (_initialize_cli_style): Add "style sources" commands.
12520         (show_style_sources): New function.
12521         * cli/cli-style.h (source_styling): Declare.
12522
12523 2019-03-14  Pedro Alves  <palves@redhat.com>
12524             Tom Tromey  <tromey@adacore.com>
12525
12526         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12527         * tui/tui-winsource.c (tui_refill_source_window): New function,
12528         from...
12529         (tui_horizontal_source_scroll): ... here.  Move some logic.
12530         * cli/cli-style.c (set_style_enabled): Notify new observable.
12531         * tui/tui-hooks.c (tui_redisplay_source): New function.
12532         (tui_attach_detach_observers): Attach or detach
12533         tui_redisplay_source.
12534         * observable.h (source_styling_changed): New observable.
12535         * observable.c: Define source_styling_changed observable.
12536
12537 2019-03-13  Tom Tromey  <tromey@adacore.com>
12538
12539         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12540         (i386_gnu_nat_target::store_registers): Update.
12541         * target-debug.h (target_debug_print_std_string): New macro.
12542         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12543         * windows-tdep.c (display_one_tib): Update.
12544         * tui/tui-stack.c (tui_make_status_line): Update.
12545         * top.c (print_inferior_quit_action): Update.
12546         * thread.c (thr_try_catch_cmd): Update.
12547         (add_thread_with_info): Update.
12548         (thread_target_id_str): Update.
12549         (thr_try_catch_cmd): Update.
12550         (thread_command): Update.
12551         (thread_find_command): Update.
12552         * record-btrace.c (record_btrace_target::info_record)
12553         (record_btrace_resume_thread, record_btrace_target::resume)
12554         (record_btrace_cancel_resume, record_btrace_step_thread)
12555         (record_btrace_target::wait, record_btrace_target::wait)
12556         (record_btrace_target::wait, record_btrace_target::stop): Update.
12557         * progspace.c (print_program_space): Update.
12558         * process-stratum-target.c
12559         (process_stratum_target::thread_address_space): Update.
12560         * linux-fork.c (linux_fork_mourn_inferior)
12561         (detach_checkpoint_command, info_checkpoints_command)
12562         (linux_fork_context): Update.
12563         (linux_fork_detach): Update.
12564         (class scoped_switch_fork_info): Update.
12565         (delete_checkpoint_command): Update.
12566         * infrun.c (follow_fork_inferior): Update.
12567         (follow_fork_inferior): Update.
12568         (proceed_after_vfork_done): Update.
12569         (handle_vfork_child_exec_or_exit): Update.
12570         (follow_exec): Update.
12571         (displaced_step_prepare_throw): Update.
12572         (displaced_step_restore): Update.
12573         (start_step_over): Update.
12574         (resume_1): Update.
12575         (clear_proceed_status_thread): Update.
12576         (proceed): Update.
12577         (print_target_wait_results): Update.
12578         (do_target_wait): Update.
12579         (context_switch): Update.
12580         (stop_all_threads): Update.
12581         (restart_threads): Update.
12582         (finish_step_over): Update.
12583         (handle_signal_stop): Update.
12584         (switch_back_to_stepped_thread): Update.
12585         (keep_going_pass_signal): Update.
12586         (print_exited_reason): Update.
12587         (normal_stop): Update.
12588         * inferior.c (inferior_pid_to_str): Change return type.
12589         (print_selected_inferior): Update.
12590         (add_inferior): Update.
12591         (detach_inferior): Update.
12592         * dummy-frame.c (fprint_dummy_frames): Update.
12593         * dcache.c (dcache_info_1): Update.
12594         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12595         (btrace_fetch, btrace_clear): Update.
12596         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12597         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12598         type.
12599         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12600         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12601         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12602         * gdbarch.c, gdbarch.h: Rebuild.
12603         * gdbarch.sh (core_pid_to_str): Change return type.
12604         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12605         return type.
12606         (windows_nat_target::pid_to_str): Change return type.
12607         (windows_delete_thread): Update.
12608         (windows_nat_target::attach): Update.
12609         (windows_nat_target::files_info): Update.
12610         * target-delegates.c: Rebuild.
12611         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12612         return type.
12613         (sol_thread_target::pid_to_str): Change return type.
12614         * remote.c (class remote_target) <pid_to_str>: Change return
12615         type.
12616         (remote_target::pid_to_str): Change return type.
12617         (extended_remote_target::attach, remote_target::remote_stop_ns)
12618         (remote_target::remote_notif_remove_queued_reply)
12619         (remote_target::push_stop_reply, remote_target::disable_btrace):
12620         Update.
12621         (extended_remote_target::attach): Update.
12622         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12623         type.
12624         (gdbsim_target::pid_to_str): Change return type.
12625         * ravenscar-thread.c (struct ravenscar_thread_target)
12626         <pid_to_str>: Change return type.
12627         (ravenscar_thread_target::pid_to_str): Change return type.
12628         * procfs.c (class procfs_target) <pid_to_str>: Change return
12629         type.
12630         (procfs_target::pid_to_str): Change return type.
12631         (procfs_target::attach): Update.
12632         (procfs_target::detach): Update.
12633         (procfs_target::fetch_registers): Update.
12634         (procfs_target::store_registers): Update.
12635         (procfs_target::wait): Update.
12636         (procfs_target::files_info): Update.
12637         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12638         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12639         return type.
12640         (nto_procfs_target::pid_to_str): Change return type.
12641         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12642         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12643         return type.
12644         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12645         (exit_lwp): Update.
12646         (attach_proc_task_lwp_callback, get_detach_signal)
12647         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12648         (linux_nat_target::resume, wait_lwp, stop_callback)
12649         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12650         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12651         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12652         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12653         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12654         type.
12655         (inf_ptrace_target::attach): Update.
12656         (inf_ptrace_target::files_info): Update.
12657         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12658         type.
12659         (go32_nat_target::pid_to_str): Change return type.
12660         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12661         (gnu_nat_target::wait): Update.
12662         (gnu_nat_target::wait): Update.
12663         (gnu_nat_target::resume): Update.
12664         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12665         (fbsd_nat_target::wait): Update.
12666         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12667         type.
12668         (darwin_nat_target::attach): Update.
12669         * corelow.c (class core_target) <pid_to_str>: Change return type.
12670         (core_target::pid_to_str): Change return type.
12671         * target.c (normal_pid_to_str): Change return type.
12672         (default_pid_to_str): Likewise.
12673         (target_pid_to_str): Change return type.
12674         (target_translate_tls_address): Update.
12675         (target_announce_detach): Update.
12676         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12677         return type.
12678         (bsd_uthread_target::pid_to_str): Change return type.
12679         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12680         type.
12681         (bsd_kvm_target::pid_to_str): Change return type.
12682         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12683         return type.
12684         (aix_thread_target::pid_to_str): Change return type.
12685         * target.h (struct target_ops) <pid_to_str>: Change return type.
12686         (target_pid_to_str, normal_pid_to_str): Likewise.
12687         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12688         type.
12689         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12690         type.
12691         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12692         return type.
12693         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12694         type.
12695         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12696         type.
12697         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12698         return type.
12699
12700 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12701
12702         * NEWS: Mention that the new default MI version is 3.  Mention
12703         changes to the output of commands and events that deal with
12704         multi-location breakpoints.
12705         * breakpoint.c: Include "mi/mi-out.h".
12706         (print_one_breakpoint): Change output syntax if using MI version
12707         >= 3.
12708         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12709         New.
12710         (mi_multi_location_breakpoint_output_fixed): New.
12711         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12712         (mi_cmd_fix_multi_location_breakpoint_output): New.
12713         (mi_multi_location_breakpoint_output_fixed): New.
12714         * mi/mi-cmds.c (mi_cmds): Register command
12715         -fix-multi-location-breakpoint-output.
12716         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12717         interpreter "mi".
12718
12719 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12720
12721         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12722         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12723         instantiate mi_ui_out based on interpreter name.
12724         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12725         * mi/mi-main.c (mi_load_progress): Likewise.
12726
12727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12728
12729         * NEWS: Combine separate "New targets" sections for 8.3.
12730
12731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12732
12733         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12734         (ppcfbsd_init_abi): Install gdbarch
12735         "fetch_tls_load_module_address" and "get_thread_local_address"
12736         methods.
12737
12738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12739
12740         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12741         (riscv_fbsd_init_abi): Install gdbarch
12742         "fetch_tls_load_module_address" and "get_thread_local_address"
12743         methods.
12744
12745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12746
12747         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12748         (i386fbsd_init_abi): Install gdbarch
12749         "fetch_tls_load_module_address" and "get_thread_local_address"
12750         methods.
12751
12752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12753
12754         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12755         (amd64fbsd_init_abi): Install gdbarch
12756         "fetch_tls_load_module_address" and "get_thread_local_address"
12757         methods.
12758
12759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12760
12761         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12762         (struct fbsd_pspace_data): New type.
12763         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12764         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12765         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12766         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12767         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12768
12769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12770
12771         * gdbtypes.c (lookup_struct_elt): New function.
12772         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12773         * gdbtypes.h (struct struct_elt): New type.
12774         (lookup_struct_elt): New prototype.
12775
12776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12777
12778         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12779         remove disabled code block.
12780
12781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12782
12783         * gdbarch.sh (get_thread_local_address): New method.
12784         * gdbarch.h, gdbarch.c: Regenerate.
12785         * target.c (target_translate_tls_address): Use
12786         gdbarch_get_thread_local_address if present instead of
12787         target::get_thread_local_address.
12788
12789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12790
12791         * target.h (target::get_thread_local_address): Update comment.
12792
12793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12794
12795         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12796         objfile->separate_debug_objfile_backlink if not NULL.
12797
12798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12799
12800         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12801         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12802         (amd64bsd_store_inferior_registers): Likewise.
12803         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12804         Enable segment base registers.
12805         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12806         PT_GETFSBASE and PT_GETGSBASE.
12807         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12808         PT_SETGSBASE.
12809         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12810         segment base registers.
12811         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12812
12813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12814
12815         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12816         Update calls to i386_target_description to add 'segments'
12817         parameter.
12818         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12819         add segment base registers.
12820         * arch/i386.c (i386_create_target_description): Add 'segments'
12821         parameter to enable segment base registers.
12822         * arch/i386.h (i386_create_target_description): Likewise.
12823         * features/i386/32bit-segments.xml: New file.
12824         * features/i386/32bit-segments.c: Generate.
12825         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12826         call to i386_target_description to add 'segments' parameter.
12827         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12828         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12829         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12830         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12831         if feature is present.
12832         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12833         Add 'segments' parameter to call to i386_target_description.
12834         (i386_target_description): Add 'segments' parameter to enable
12835         segment base registers.
12836         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12837         to call to i386_target_description.
12838         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12839         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12840         Define I386_NUM_REGS.
12841         (i386_target_description): Add 'segments' parameter to enable
12842         segment base registers.
12843
12844 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12845
12846         PR/24325
12847         * source-cache.c: #undef open and close, to avoid unresolved
12848         externals during linking.
12849
12850 2019-03-12  Tom Tromey  <tromey@adacore.com>
12851
12852         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12853         const.  Add initializers.
12854         (_initialize_remote): Don't initialize ptid globals.
12855
12856 2019-03-12  Pedro Alves  <palves@redhat.com>
12857
12858         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12859
12860 2019-03-12  Pedro Alves  <palves@redhat.com>
12861
12862         * cp-name-parser.y (main): Remove unused 'len' variable.
12863
12864 2019-03-12  Tom Tromey  <tromey@adacore.com>
12865
12866         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12867         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12868
12869 2019-03-12  Tom Tromey  <tromey@adacore.com>
12870
12871         * linux-nat.c (iterate_over_lwps): Update.
12872         (stop_callback): Remove parameter.
12873         (stop_wait_callback, detach_callback, resume_set_callback)
12874         (select_singlestep_lwp_callback, set_ignore_sigint)
12875         (status_callback, resumed_callback, resume_clear_callback)
12876         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12877         data parameter.
12878         (linux_nat_target::detach, linux_nat_target::resume)
12879         (linux_stop_and_wait_all_lwps, select_event_lwp)
12880         (linux_nat_filter_event, linux_nat_wait_1)
12881         (linux_nat_target::kill, linux_nat_target::stop)
12882         (linux_nat_target::stop): Update.
12883         (linux_nat_resume_callback): Change type.
12884         (resume_stopped_resumed_lwps, count_events_callback)
12885         (select_event_lwp_callback): Likewise.
12886         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12887         * arm-linux-nat.c (struct update_registers_data): Remove.
12888         (update_registers_callback): Change type.
12889         (arm_linux_insert_hw_breakpoint1): Update.
12890         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12891         parameter.
12892         (x86_linux_dr_set_addr): Update.
12893         (x86_linux_dr_set_control): Update.
12894         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12895         (iterate_over_lwps): Use gdb::function_view.
12896         * nat/aarch64-linux-hw-point.c (struct
12897         aarch64_dr_update_callback_param): Remove.
12898         (debug_reg_change_callback): Change type.
12899         (aarch64_notify_debug_reg_change): Update.
12900         * s390-linux-nat.c (s390_refresh_per_info): Update.
12901
12902 2019-03-11  Tom Tromey  <tromey@adacore.com>
12903
12904         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12905         redundant assignment to "this_cu".
12906
12907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12908
12909         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12910
12911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12912
12913         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12914         from...
12915         (rank_one_type): ... this.
12916
12917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12918
12919         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12920         from...
12921         (rank_one_type): ... this.
12922
12923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12924
12925         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12926         from...
12927         (rank_one_type): ... this.
12928
12929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12930
12931         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12932         from...
12933         (rank_one_type): ... this.
12934
12935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12936
12937         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12938         from...
12939         (rank_one_type): ... this.
12940
12941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12942
12943         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12944         from...
12945         (rank_one_type): ... this.
12946
12947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12948
12949         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12950         from...
12951         (rank_one_type): ... this.
12952
12953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12954
12955         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12956         from...
12957         (rank_one_type): ... this.
12958
12959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12960
12961         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12962         from...
12963         (rank_one_type): ... this.
12964
12965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12966
12967         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12968         from...
12969         (rank_one_type): ... this.
12970
12971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12972
12973         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12974         from...
12975         (rank_one_type): ... this.
12976
12977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12978
12979         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12980         from...
12981         (rank_one_type): ... this.
12982
12983 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12984
12985         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12986         inferior-events' shows the example events.
12987
12988 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12989
12990         Support styling on native MS-Windows console
12991
12992         PR/24315
12993         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12994         on MS-Windows if $TERM is not defined.
12995
12996         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12997
12998         * posix-hdep.c (gdb_console_fputs):
12999         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13000         functions.
13001         * ui-file.h (gdb_console_fputs): Add prototype.
13002
13003         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13004         back to fputs only if the former returns zero.
13005
13006 2019-03-07  Tom Tromey  <tom@tromey.com>
13007
13008         * symmisc.c (print_symbol_bcache_statistics): Update.
13009         (print_objfile_statistics): Update.
13010         * symfile.c (allocate_symtab): Update.
13011         * stabsread.c: Don't include bcache.h.
13012         * psymtab.h (struct psymbol_bcache): Don't declare.
13013         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13014         (psymbol_bcache_init, psymbol_bcache_free)
13015         (psymbol_bcache_get_bcache): Don't declare.
13016         * psymtab.c (struct psymbol_bcache): Remove.
13017         (psymtab_storage::psymtab_storage): Update.
13018         (psymtab_storage::~psymtab_storage): Update.
13019         (psymbol_bcache_init, psymbol_bcache_free)
13020         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13021         (add_psymbol_to_bcache): Update.
13022         (allocate_psymtab): Update.
13023         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13024         macro_cache>: No longer pointers.
13025         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13026         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13027         * macrotab.c (macro_bcache): Update.
13028         * macroexp.c: Don't include bcache.h.
13029         * gdbtypes.c (check_types_worklist): Update.
13030         (types_deeply_equal): Remove TRY/CATCH.  Update.
13031         * elfread.c (elf_symtab_read): Update.
13032         * dwarf2read.c: Don't include bcache.h.
13033         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13034         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13035         (print_bcache_statistics, bcache_memory_used): Don't declare.
13036         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13037         methods.  Rename all data members.
13038         * bcache.c (struct bcache): Move to bcache.h.
13039         (bcache::expand_hash_table): Rename from expand_hash_table.
13040         (bcache): Remove.
13041         (bcache::insert): Rename from bcache_full.
13042         (bcache::compare): Rename from bcache_compare.
13043         (bcache_xmalloc): Remove.
13044         (bcache::~bcache): Rename from bcache_xfree.
13045         (bcache::print_statistics): Rename from print_bcache_statistics.
13046         (bcache::memory_used): Rename from bcache_memory_used.
13047
13048 2019-03-07  Pedro Alves  <palves@redhat.com>
13049
13050         * infrun.c (normal_stop): Also check for
13051         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13052
13053 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13054
13055         * f-lang.c (value_from_host_double): Moved to...
13056         * value.c (value_from_host_double): ...here.
13057         * value.h (value_from_host_double): Declare.
13058         * guile/scm-math.c (vlscm_convert_typed_number): Use
13059         value_from_host_double.
13060         (vlscm_convert_number): Likewise.
13061         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13062         * python/py-value.c (convert_value_from_python): Likewise.
13063
13064 2019-03-06  Tom Tromey  <tom@tromey.com>
13065
13066         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13067
13068 2019-03-06  Tom Tromey  <tom@tromey.com>
13069
13070         * utils.h (free_current_contents): Don't declare.
13071         * utils.c (free_current_contents): Remove.
13072
13073 2019-03-06  Tom Tromey  <tom@tromey.com>
13074
13075         * top.c (quit_force): Update.
13076         * main.c (captured_command_loop): Update.
13077         * common/new-op.c (operator new): Update.
13078         * common/common-exceptions.c (struct catcher)
13079         <save_cleanup_chain>: Remove member.
13080         (exceptions_state_mc_init): Update.
13081         (exception_try_scope_entry): Return nullptr.
13082         (exception_try_scope_exit, exception_rethrow)
13083         (throw_exception_sjlj, throw_exception_cxx): Update.
13084         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13085         (all_cleanups, do_cleanups, discard_cleanups)
13086         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13087         (restore_cleanups, restore_final_cleanups): Don't declare.
13088         (do_final_cleanups): Remove parameter.
13089         * common/cleanups.c (cleanup_chain, make_cleanup)
13090         (make_cleanup_dtor, all_cleanups, do_cleanups)
13091         (discard_my_cleanups, discard_cleanups)
13092         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13093         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13094         (null_cleanup): Remove.
13095         (do_final_cleanups): Remove parameter.
13096
13097 2019-03-06  Tom Tromey  <tom@tromey.com>
13098
13099         * remote.c (remote_target::remote_parse_stop_reply): Use
13100         unique_xmalloc_ptr.
13101
13102 2019-03-06  Tom Tromey  <tom@tromey.com>
13103
13104         * stabsread.c (struct stabs_field_info): Rename from field_info.
13105         <list, fnlist>: Add initializers.
13106         <obstack>: New member.
13107         (read_member_functions, read_struct_fields, read_baseclasses):
13108         Allocate on obstack.  Don't use cleanups.
13109         (read_one_struct_field, read_member_functions, read_struct_fields)
13110         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13111         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13112         (read_struct_type): Update.
13113
13114 2019-03-06  Tom Tromey  <tom@tromey.com>
13115
13116         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13117         * common/filestuff.h (make_cleanup_close): Don't declare.
13118         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13119         Remove.
13120
13121 2019-03-06  Tom Tromey  <tom@tromey.com>
13122
13123         * solib-aix.c: Use make_scope_exit.
13124
13125 2019-03-06  Tom Tromey  <tom@tromey.com>
13126
13127         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13128         Use make_scope_exit.
13129
13130 2019-03-06  Tom Tromey  <tom@tromey.com>
13131
13132         * solib-svr4.c (disable_probes_interface): Remove parameter.
13133         (svr4_handle_solib_event): Use make_scope_exit.
13134
13135 2019-03-06  Tom Tromey  <tom@tromey.com>
13136
13137         * remote.c (struct stop_reply_deleter): Remove.
13138         (stop_reply_up): Update.
13139         (struct stop_reply): Derive from notif_event.  Don't typedef.
13140         <regcache>: Now a std::vector.
13141         (stop_reply_xfree): Remove.
13142         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13143         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13144         (remote_target::discard_pending_stop_replies): Use delete.
13145         (remote_target::remote_parse_stop_reply): Update.
13146         (remote_target::process_stop_reply): Update.
13147         * remote-notif.h (struct notif_event): Add virtual destructor.
13148         Remove "dtr" member.
13149         (struct notif_client) <alloc_event>: Return a unique_ptr.
13150         (notif_event_xfree): Don't declare.
13151         (notif_event_up): New typedef.
13152         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13153         (notif_event_xfree, do_notif_event_xfree): Remove.
13154         (remote_notif_state_xfree): Update.
13155
13156 2019-03-06  Tom Tromey  <tom@tromey.com>
13157
13158         * infrun.c (displaced_step_clear_cleanup): Now a
13159         forward_scope_exit type.
13160         (displaced_step_prepare_throw): Update.
13161         (displaced_step_fixup): Update.
13162
13163 2019-03-06  Tom Tromey  <tom@tromey.com>
13164
13165         * inferior.h (class inferior): Update comment.
13166         * gdbthread.h (class thread_info): Update comment.
13167
13168 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13169             Tom Tromey  <tom@tromey.com>
13170
13171         * stabsread.h (struct stab_section_list): Remove.
13172         (coffstab_build_psymtabs): Update.
13173         * dbxread.c (symbuf_sections): Now a std::vector.
13174         (sect_idx): New global.
13175         (fill_symbuf): Update.
13176         (coffstab_build_psymtabs): Change type of stabsects parameter.
13177         Update.
13178         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13179         std::vector.
13180         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13181         (coff_locate_sections): Update.
13182         (coff_symfile_read): Remove cleanups.  Update.
13183         (init_stringtab): Add storage parameter.
13184         (free_stringtab, free_stringtab_cleanup): Remove.
13185         (init_lineno): Add storage parameter.
13186         (free_linetab, free_linetab_cleanup): Remove.
13187
13188 2019-03-06  Pedro Alves  <palves@redhat.com>
13189
13190         * linux-fork.c (fork_info::clobber_regs): Delete.
13191         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13192         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13193         comment.  Adjust.
13194         (scoped_switch_fork_info::scoped_switch_fork_info)
13195         (checkpoint_command, linux_fork_context): Adjust
13196         fork_save_infrun_state calls.
13197
13198 2019-03-06  Pedro Alves  <palves@redhat.com>
13199
13200         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13201         (inf_has_multiple_threads): Return 'bool' and rewrite using
13202         inferior_info::threads().
13203
13204 2019-03-06  Pedro Alves  <palves@redhat.com>
13205
13206         * linux-fork.c: Include <list>.
13207         (fork_list): Now a std::list instance.
13208         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13209         (forks_exist_p, find_last_fork): Adjust.
13210         (new_fork): Delete.
13211         (one_fork_p): New.
13212         (add_fork): Adjust.
13213         (free_fork): Delete, folded into fork_info::~fork_info().
13214         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13215         Adjust.
13216         (init_fork_list): Delete.
13217         (linux_fork_killall, linux_fork_mourn_inferior)
13218         (linux_fork_detach, info_checkpoints_command): Adjust.
13219         (_initialize_linux_fork): No longer call init_fork_list.
13220
13221 2019-03-06  Pedro Alves  <palves@redhat.com>
13222
13223         * linux-fork.c (new_fork): New, split out of ...
13224         (add_fork): ... this.  Return void.  Move "first fork" special
13225         case from here, to ...
13226         (checkpoint_command): ... here.
13227         * linux-linux.h (add_fork): Return void.
13228
13229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13230
13231         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13232
13233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13234             Chris January  <chris.january@arm.com>
13235             David Lecomber  <david.lecomber@arm.com>
13236
13237         * f-exp.y: New token, UNOP_INTRINSIC.
13238         (exp): New pattern using UNOP_INTRINSIC token.
13239         (f77_keywords): Add 'abs' keyword.
13240         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13241         (value_from_host_double): New function.
13242         (evaluate_subexp_f): Support UNOP_ABS.
13243
13244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13245
13246         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13247         types.
13248
13249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13250
13251         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13252         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13253         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13254
13255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13256
13257         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13258
13259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13260             Chris January  <chris.january@arm.com>
13261
13262         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13263         * f-exp.y: Define 'KIND' token.
13264         (exp): New pattern for KIND expressions.
13265         (ptype): Handle types with a kind extension.
13266         (direct_abs_decl): Extend to spot kind extensions.
13267         (f77_keywords): Add 'kind' to the list.
13268         (push_kind_type): New function.
13269         (convert_to_kind_type): New function.
13270         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13271         * parse.c (operator_length_standard): Likewise.
13272         * parser-defs.h (enum type_pieces): Add tp_kind.
13273         * std-operator.def: Add UNOP_KIND.
13274
13275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13276
13277         * f-exp.y (f_parse): Set yydebug.
13278
13279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13280
13281         * f-lang.c (evaluate_subexp_f): New function.
13282         (exp_descriptor_f): New global.
13283         (f_language_defn): Use exp_descriptor_f instead of
13284         exp_descriptor_standard.
13285
13286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13287
13288         * f-exp.y (struct token): Add comments.
13289         (dot_ops): Remove uppercase versions and the end marker.
13290         (f77_keywords): Likewise.
13291         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13292         entries in the dot_ops array are case insensitive, and use
13293         strncasecmp to compare strings.  Also some whitespace cleanup in
13294         this area.  Similar for the f77_keywords array, except entries in
13295         this list might be case sensitive.
13296
13297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13298
13299         * f-exp.y (struct f77_boolean_val): Add comments.
13300         (boolean_values): Remove uppercase versions, and end marker.
13301         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13302         and use strncasecmp to achieve case insensitivity.  Additionally,
13303         perform whitespace cleanup around this code.
13304
13305 2019-03-06  Tom Tromey  <tromey@adacore.com>
13306
13307         * remote-sim.c (gdbsim_target_open): Use result of
13308         gdb_argv::release.
13309
13310 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13311         Dirk Schubert  <dirk.schubert@arm.com>
13312         Chris January  <chris.january@arm.com>
13313
13314         * eval.c (evaluate_subexp_standard): Call Fortran argument
13315         wrapping logic.
13316         * f-lang.c (struct value): A value which can be passed into a
13317         Fortran function call.
13318         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13319         where appropriate.
13320         (struct type): Value ready for a Fortran function call.
13321         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13322         is needed.
13323         * f-lang.h (fortran_argument_convert): Declaration.
13324         (fortran_preserve_arg_pointer): Declaration.
13325         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13326
13327 2019-03-05  Tom Tromey  <tromey@adacore.com>
13328
13329         * python/py-prettyprint.c (print_string_repr): Remove #if.
13330         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13331
13332 2019-03-05  Tom Tromey  <tromey@adacore.com>
13333
13334         * target.c (the_dummy_target): Move later.  Change type to
13335         "dummy_target".
13336         (initialize_targets): Don't initialize the_dummy_target.
13337
13338 2019-03-05  Tom Tromey  <tromey@adacore.com>
13339
13340         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13341         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13342
13343 2019-03-05  Tom Tromey  <tromey@adacore.com>
13344
13345         * windows-nat.c (windows_nat_target::attach)
13346         (windows_nat_target::detach): Don't call gdb_flush.
13347         * valprint.c (generic_val_print, val_print, val_print_string):
13348         Don't call gdb_flush.
13349         * utils.c (defaulted_query): Don't call gdb_flush.
13350         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13351         * target.c (target_announce_detach): Don't call gdb_flush.
13352         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13353         * remote.c (extended_remote_target::attach): Don't call
13354         gdb_flush.
13355         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13356         * printcmd.c (do_examine): Don't call gdb_flush.
13357         (info_display_command): Don't call gdb_flush.
13358         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13359         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13360         * memattr.c (info_mem_command): Don't call gdb_flush.
13361         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13362         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13363         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13364         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13365         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13366         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13367         (gnu_nat_target::detach): Don't call gdb_flush.
13368         * f-valprint.c (f_val_print): Don't call gdb_flush.
13369         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13370         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13371         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13372         gdb_flush.
13373         * c-valprint.c (c_val_print): Don't call gdb_flush.
13374         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13375
13376 2019-03-05  Tom Tromey  <tromey@adacore.com>
13377
13378         * varobj.c (update_dynamic_varobj_children): Update.
13379         (install_default_visualizer): Use reset, not release.
13380         * value.c (set_internalvar): Update.
13381         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13382         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13383         ATTRIBUTE_UNUSED_RESULT.
13384
13385 2019-03-05  Tom Tromey  <tromey@adacore.com>
13386
13387         * remote.c (class scoped_remote_fd) <release>: Add
13388         ATTRIBUTE_UNUSED_RESULT.
13389
13390 2019-03-05  Tom Tromey  <tromey@adacore.com>
13391
13392         * macroexp.c (struct macro_buffer) <release>: Add
13393         ATTRIBUTE_UNUSED_RESULT.
13394
13395 2019-03-05  Tom Tromey  <tromey@adacore.com>
13396
13397         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13398         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13399         ATTRIBUTE_UNUSED_RESULT.
13400
13401 2019-03-05  Tom Tromey  <tromey@adacore.com>
13402
13403         * common/scoped_fd.h (class scoped_fd) <release>: Add
13404         ATTRIBUTE_UNUSED_RESULT.
13405
13406 2019-03-05  Tom Tromey  <tromey@adacore.com>
13407
13408         * parser-defs.h (struct parser_state) <release>: Add
13409         ATTRIBUTE_UNUSED_RESULT.
13410
13411 2019-03-05  Tom Tromey  <tromey@adacore.com>
13412
13413         * utils.h (class gdb_argv) <release>: Add
13414         ATTRIBUTE_UNUSED_RESULT.
13415         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13416
13417 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13418
13419         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13420         for-loop range, to avoid compiler warnings.
13421
13422         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13423         avoid compiler warnings about unused variables.
13424
13425         * NEWS: Mention end of support for native debugging on MS-Windows
13426         before XP.
13427
13428         PR gdb/24292
13429         * common/netstuff.c:
13430         * gdbserver/gdbreplay.c
13431         * gdbserver/remote-utils.c:
13432         * ser-tcp.c:
13433         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13434         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13435         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13436         'getaddrinfo' and 'freeaddrinfo' were not available before
13437         Windows XP, and mingw.org's MinGW headers by default define
13438         _WIN32_WINNT to 0x500.
13439
13440 2019-03-01  Gary Benson <gbenson@redhat.com>
13441
13442         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13443
13444 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13445             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13446
13447         PR gdb/8527
13448         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13449         set_sigint_trap, clear_sigint_trap.
13450
13451 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13452
13453         * target.c (target_detach): Clear the regcache and the
13454         frame cache.
13455
13456 2019-02-27  Pedro Alves  <palves@redhat.com>
13457
13458         * utils.c (set_screen_size): When we cap the height/width sizes,
13459         tweak the corresponding command variable to show "unlimited":
13460
13461 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13462             Pedro Alves  <palves@redhat.com>
13463
13464         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13465         before calling rl_set_screen_size.
13466
13467 2019-02-27  Tom Tromey  <tromey@adacore.com>
13468
13469         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13470         define.
13471         * python/py-value.c: Remove Python 2.4 workaround.
13472         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13473         workaround.
13474         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13475         Python 2.4 workaround.
13476         * python/python-internal.h: Remove Python 2.4 comment.
13477         (Py_ssize_t): Don't define.
13478         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13479         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13480         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13481         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13482         * python/python.c (do_start_initialization): Remove Python 2.4
13483         workaround.
13484         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13485         (print_children): Remove Python 2.4 workaround.
13486         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13487         workaround.
13488         (CHARBUFFERPROC_NAME): Remove.
13489         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13490         Python 2.4 workaround.
13491
13492 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13493
13494         * NEWS: Note minimum Python version.
13495
13496 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13497
13498         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13499         code from these functions.  Remove corresponding ifdefs.  Use
13500         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13501         Remove gotos and target of gotos.
13502         (infpy_search_memory): Likewise.
13503
13504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13505
13506         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13507         (hppa_gdbarch_init): Don't register deleted functions with
13508         gdbarch.
13509
13510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13511
13512         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13513         (h8300_unwind_sp): Delete.
13514         (h8300_dummy_id): Delete.
13515         (h8300_gdbarch_init): Don't register deleted functions with
13516         gdbarch.
13517
13518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13519
13520         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13521         (ft32_unwind_pc): Delete.
13522         (ft32_unwind_sp): Delete.
13523         (ft32_gdbarch_init): Don't register deleted functions with
13524         gdbarch.
13525
13526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13527
13528         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13529         (frv_unwind_pc): Delete.
13530         (frv_unwind_sp): Delete.
13531         (frv_gdbarch_init): Don't register deleted functions with
13532         gdbarch.
13533
13534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13535
13536         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13537         (riscv_unwind_pc): Delete.
13538         (riscv_unwind_sp): Delete.
13539         (riscv_gdbarch_init): Don't register deleted functions with
13540         gdbarch.
13541
13542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13543
13544         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13545         (csky_unwind_pc): Delete.
13546         (csky_unwind_sp): Delete.
13547         (csky_gdbarch_init): Don't register deleted functions with
13548         gdbarch.
13549
13550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13551
13552         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13553         (cris_unwind_pc): Delete.
13554         (cris_unwind_sp): Delete.
13555         (cris_gdbarch_init): Don't register deleted functions with
13556         gdbarch.
13557
13558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13559
13560         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13561         (bfin_unwind_pc): Delete.
13562         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13563
13564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13565
13566         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13567         (arm_unwind_pc): Delete.
13568         (arm_unwind_sp): Delete.
13569         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13570
13571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13572
13573         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13574         (arc_unwind_pc): Delete.
13575         (arc_unwind_sp): Delete.
13576         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13577
13578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13579
13580         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13581         (alpha_unwind_pc): Delete.
13582         (alpha_gdbarch_init): Don't register deleted functions with
13583         gdbarch.
13584
13585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13586
13587         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13588         (aarch64_unwind_pc): Delete.
13589         (aarch64_unwind_sp): Delete.
13590         (aarch64_gdbarch_init): Don't register deleted functions with
13591         gdbarch.
13592
13593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13594
13595         * gdbtypes.c (type_align): Don't consider static members when
13596         computing structure alignment.
13597
13598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13599
13600         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13601         return 0 for other types.
13602         * arch-utils.c (default_type_align): Always return 0.
13603         * gdbarch.h: Regenerate.
13604         * gdbarch.sh (type_align): Extend comment.
13605         * gdbtypes.c (type_align): Add additional comments, always call
13606         gdbarch_type_align before applying the default rules.
13607         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13608         generic code will then apply a suitable default.
13609         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13610         types, return 0 for other types.
13611
13612 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13613
13614         * NEWS: Create a new section for the next release branch.
13615         Rename the section of the current branch, now that it has
13616         been cut.
13617
13618 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13619
13620         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13621         * version.in: Bump version to 8.3.50.DATE-git.
13622
13623 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13624
13625         * aix-thread.c (ptid_cmp): Remove unused variable.
13626         (get_signaled_thread): Likewise.
13627         (store_regs_user_thread): Likewise.
13628         (store_regs_kernel_thread): Likewise.
13629         (fetch_regs_kernel_thread): Remove shadowed variable.
13630
13631 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13632
13633         * features/riscv/32bit-cpu.xml: Add register numbers.
13634         * features/riscv/32bit-fpu.c: Regenerate.
13635         * features/riscv/32bit-fpu.xml: Add register numbers.
13636         * features/riscv/64bit-cpu.xml: Add register numbers.
13637         * features/riscv/64bit-fpu.c: Regenerate.
13638         * features/riscv/64bit-fpu.xml: Add register numbers.
13639
13640 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13641
13642         * NEWS: Mention two argument form of gdb.Value constructor.
13643         * python/py-value.c (convert_buffer_and_type_to_value): New
13644         function.
13645         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13646         Add support for handling an optional second argument.  Call
13647         convert_buffer_and_type_to_value as appropriate.
13648         * python/python-internal.h (Py_buffer_deleter): New struct.
13649         (Py_buffer_up): New typedef.
13650
13651 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13652
13653         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13654         instead of releasing ownership.
13655
13656 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13657
13658         * dwarf2read.c (open_and_init_dwp_file): Call
13659         elf_numsections instead of bfd_count_sections to initialize
13660         dwp_file->num_sections.
13661
13662 2019-02-25  Tom Tromey  <tromey@adacore.com>
13663
13664         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13665
13666 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13667
13668         * gcore.in: Add '--readnever' option when invoking GDB.
13669
13670 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13671
13672         * MAINTAINERS: Update my email address.
13673
13674 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13675
13676         * build-id.c (build_id_to_debug_bfd_1): New function.
13677         (build_id_to_debug_bfd): Look for separate debug file in
13678         sysroot.
13679
13680 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13681
13682         * gdbarch.sh: Update the copyright year range that is placed into
13683         generated files.
13684
13685 2019-02-22  Keith Seitz  <keiths@redhat.com>
13686
13687         PR symtab/23853
13688         * linespec.c (create_sals_line_offset): Search for the default
13689         symtab's filename instead of its fullname.
13690
13691 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13692
13693         * NEWS: Update style defaults.
13694
13695 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13696
13697         * main.c (captured_main_1): Disable styling in batch mode.
13698
13699 2019-02-20  Tom Tromey  <tom@tromey.com>
13700
13701         * symtab.c (symtab_symbol_info): Fix typos.
13702
13703 2019-02-20  Tom Tromey  <tromey@adacore.com>
13704
13705         * findcmd.c (_initialize_mem_search): Use upper case for
13706         metasyntactic variables.
13707
13708 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13709
13710         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13711         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13712
13713 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13714
13715         * top.h (source_file_name): Change to std::string.
13716         * top.c (source_file_name): Likewise.
13717         (command_line_input): Adjust.
13718         * cli/cli-script.c (script_from_file): Adjust.
13719
13720 2019-02-19  Tom Tromey  <tromey@adacore.com>
13721
13722         * ravenscar-thread.c
13723         (ravenscar_thread_target::update_thread_list): Don't call
13724         ada_build_task_list.
13725         * ada-lang.h (ada_build_task_list): Don't declare.
13726         * ada-tasks.c (struct ada_tasks_inferior_data)
13727         <task_list_valid_p>: Now bool.
13728         (read_known_tasks, ada_task_list_changed)
13729         (ada_tasks_invalidate_inferior_data): Update.
13730         (read_known_tasks_array): Return bool.
13731         (read_known_tasks_list): Likewise.
13732         (read_known_tasks): Return void.
13733         (ada_build_task_list): Now static.
13734
13735 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13736
13737         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13738         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13739
13740 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13741
13742         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13743         variant for ada_tasks_pspace_data_handle and
13744         ada_tasks_inferior_data_handle.
13745         (ada_tasks_pspace_data_cleanup): New function.
13746         (ada_tasks_inferior_data_cleanup): New function.
13747
13748 2019-02-17  Tom Tromey  <tom@tromey.com>
13749
13750         * macrotab.h (macro_source_fullname): Return a std::string.
13751         * macrotab.c (macro_include, check_for_redefinition)
13752         (macro_undef, macro_lookup_definition, foreach_macro)
13753         (foreach_macro_in_scope): Update.
13754         (macro_source_fullname): Return a std::string.
13755         * macrocmd.c (show_pp_source_pos): Update.
13756
13757 2019-02-17  Tom Tromey  <tom@tromey.com>
13758
13759         * macrocmd.c (show_pp_source_pos): Style the file names.
13760
13761 2019-02-17  Tom Tromey  <tom@tromey.com>
13762
13763         PR tui/24197:
13764         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13765
13766 2019-02-17  Tom Tromey  <tom@tromey.com>
13767
13768         * ada-lang.c (user_select_syms): Use filtered printing.
13769         * utils.c (wrap_style): New global.
13770         (desired_style): Remove.
13771         (emit_style_escape): Add stream parameter.
13772         (set_output_style, reset_terminal_style, prompt_for_continue):
13773         Update.
13774         (flush_wrap_buffer): Only flush gdb_stdout.
13775         (wrap_here): Set wrap_style.
13776         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13777         treat escape sequences as a character.  Change when wrap buffer is
13778         flushed.
13779         (fputs_styled): Do not set the output style when the default is
13780         requested.
13781         * ui-style.h (struct ui_file_style) <is_default>: New method.
13782         * source.c (print_source_lines_base): Emit escape sequences in one
13783         piece.
13784
13785 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13786
13787         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13788         integers and enumeration types.
13789
13790 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13791
13792         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13793         instead of lookup_symbol_in_language
13794         (do_exact_match): New function.
13795         (ada_get_symbol_name_matcher): Return do_exact_match when
13796         doing a verbatim match.
13797
13798 2019-02-15  Tom Tromey  <tromey@adacore.com>
13799
13800         * ravenscar-thread.c (ravenscar_thread_target::resume)
13801         (ravenscar_thread_target::wait): Special case wildcard requests.
13802
13803 2019-02-15  Tom Tromey  <tromey@adacore.com>
13804
13805         * ravenscar-thread.c (base_ptid): Remove.
13806         (struct ravenscar_thread_target) <close>: New method.
13807         <m_base_ptid>: New member.
13808         <update_inferior_ptid, active_task, task_is_currently_active,
13809         runtime_initialized>: Declare methods.
13810         <ravenscar_thread_target>: Add constructor.
13811         (ravenscar_thread_target::task_is_currently_active)
13812         (ravenscar_thread_target::update_inferior_ptid)
13813         (ravenscar_runtime_initialized): Rename.  Now methods.
13814         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13815         (ravenscar_thread_target::update_thread_list): Update.
13816         (ravenscar_thread_target::active_task): Now method.
13817         (ravenscar_thread_target::store_registers)
13818         (ravenscar_thread_target::prepare_to_store)
13819         (ravenscar_thread_target::prepare_to_store)
13820         (ravenscar_thread_target::mourn_inferior): Update.
13821         (ravenscar_inferior_created): Use "new" to create target.
13822         (ravenscar_thread_target::get_ada_task_ptid): Update.
13823         (_initialize_ravenscar): Don't initialize base_ptid.
13824         (ravenscar_ops): Remove global.
13825
13826 2019-02-15  Tom Tromey  <tromey@adacore.com>
13827
13828         * target.h (push_target): Declare new overload.
13829         * target.c (push_target): New overload, taking an rvalue reference.
13830         * remote.c (remote_target::open_1): Use push_target overload.
13831         * corelow.c (core_target_open): Use push_target overload.
13832
13833 2019-02-15  Tom Tromey  <tromey@adacore.com>
13834
13835         * ravenscar-thread.c (is_ravenscar_task)
13836         (ravenscar_task_is_currently_active): Return bool.
13837         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13838         (_initialize_ravenscar): Remove "(void)".
13839         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13840         Return bool.
13841
13842 2019-02-15  Tom Tromey  <tromey@adacore.com>
13843
13844         * ravenscar-thread.c (ravenscar_runtime_initializer)
13845         (has_ravenscar_runtime, get_running_thread_id)
13846         (ravenscar_thread_target::resume): Fix indentation.
13847
13848 2019-02-15  Tom Tromey  <tromey@adacore.com>
13849
13850         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13851         from ravenscar_arch_ops.
13852         (sparc_ravenscar_ops::fetch_registers)
13853         (sparc_ravenscar_ops::store_registers): Now methods.
13854         (sparc_ravenscar_prepare_to_store): Remove.
13855         (sparc_ravenscar_ops): Redefine.
13856         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13857         methods and destructor.  Remove members.
13858         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13859         (ravenscar_thread_target::store_registers)
13860         (ravenscar_thread_target::prepare_to_store): Update.
13861         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13862         Remove.
13863         (struct ppc_ravenscar_powerpc_ops): Derive from
13864         ravenscar_arch_ops.
13865         (ppc_ravenscar_powerpc_ops::fetch_registers)
13866         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13867         (ppc_ravenscar_powerpc_ops): Redefine.
13868         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13869         (ppc_ravenscar_e500_ops::fetch_registers)
13870         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13871         (ppc_ravenscar_e500_ops): Redefine.
13872         * aarch64-ravenscar-thread.c
13873         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13874         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13875         (aarch64_ravenscar_fetch_registers)
13876         (aarch64_ravenscar_store_registers): Now methods.
13877         (aarch64_ravenscar_ops): Redefine.
13878
13879 2019-02-15  Tom Tromey  <tromey@adacore.com>
13880
13881         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13882         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13883         (ravenscar_thread_target::stopped_by_watchpoint)
13884         (ravenscar_thread_target::stopped_data_address)
13885         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13886
13887 2019-02-15  Tom Tromey  <tromey@adacore.com>
13888
13889         * ravenscar-thread.c: Fix some typos.
13890
13891 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13892             Tom Tromey  <tromey@adacore.com>
13893
13894         * ada-lang.c (ada_exception_sal): Change addr_string to a
13895         std::string.
13896         (create_ada_exception_catchpoint): Update.
13897
13898 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13899             Tom Tromey  <tromey@adacore.com>
13900
13901         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13902         (bp_location_ops): Remove.
13903         (base_breakpoint_allocate_location): Update.
13904         (free_bp_location): Update.
13905         * ada-lang.c (class ada_catchpoint_location)
13906         <ada_catchpoint_location>: Remove ops parameter.
13907         (ada_catchpoint_location_dtor): Remove.
13908         (ada_catchpoint_location_ops): Remove.
13909         (allocate_location_exception): Update.
13910         * breakpoint.h (struct bp_location_ops): Remove.
13911         (class bp_location) <bp_location>: Remove bp_location_ops
13912         parameter.
13913         <~bp_location>: Add destructor.
13914         <ops>: Remove.
13915
13916 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13917             Pedro Alves  <palves@redhat.com>
13918
13919         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13920         'PATH_MAX'.
13921
13922 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13923             Samuel Thibault  <samuel.thibault@gnu.org>
13924             Thomas Schwinge  <thomas@codesourcery.com>
13925
13926         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13927         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13928
13929 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13930
13931         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13932         (check_empty): Use "const char *".
13933
13934         * gnu-nat.c (gnu_nat_target::detach): Instead of
13935         'detach_inferior (pid)' call
13936         'detach_inferior (find_inferior_pid (pid))'.
13937
13938         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13939         'nat/fork-inferior.o'.
13940         * gnu-nat.c: #include "nat/fork-inferior.h".
13941
13942         * gnu-nat.c (gnu_nat_target::detach): Instead of
13943         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13944         * gnu-nat.h: #include "inf-child.h".
13945         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13946         'i386_gnu_nat_target::fetch_registers'.
13947         (gnu_store_registers): Rename/move to
13948         'i386_gnu_nat_target::store_registers'.
13949
13950         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13951         * gnu-nat.h (mach_thread_info): New function.
13952         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13953
13954         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13955
13956 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13957
13958         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13959
13960 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13961
13962         * windows-nat.c (windows_add_thread): Add new parameter
13963         "main_thread_p" with default value set to false.  Update
13964         function documentation as well as all callers.
13965         (windows_delete_thread): Likewise.
13966         (fake_create_process): Update call to windows_add_thread.
13967         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13968         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13969         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13970         call to windows_delete_thread.
13971
13972 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13973
13974         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13975
13976 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13977
13978         * symfile.c (find_separate_debug_file): Use canonical path of
13979         sysroot with child_path instead of gdb_sysroot if it is valid.
13980
13981 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13982
13983         * symfile.c (find_separate_debug_file): Use child_path to
13984         determine if an object file is under a sysroot.
13985
13986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13987
13988         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13989         unittests/child-path-selftests.c.
13990         * common/pathstuff.c (child_path): New function.
13991         * common/pathstuff.h (child_path): New prototype.
13992         * unittests/child-path-selftests.c: New file.
13993
13994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13995
13996         * symfile.c (find_separate_debug_file): Look for separate debug
13997         files in debug directories under the sysroot.
13998
13999 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14000
14001         * symtab.h (struct minimal_symbol data_p): New const method.
14002         (struct minimal_symbol text_p): Likewise.
14003         * symtab.c (output_source_filename): Use file name style
14004         to print file name.
14005         (print_symbol_info): Likewise.
14006         (print_msymbol_info): Use address style to print addresses.
14007         Use function name style to print executable text symbols.
14008         (expand_symtab_containing_pc): Use data_p.
14009         (find_pc_sect_compunit_symtab): Likewise.
14010
14011 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14012
14013         * breakpoint.c (describe_other_breakpoints): Use address style
14014         to print addresses.
14015         (say_where): Likewise.
14016
14017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14018
14019         * ada-typeprint.c (print_func_type): Print function name
14020         style to print function name.
14021         * c-typeprint.c (c_print_type_1): Likewise.
14022
14023 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14024
14025         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14026         for execve.
14027
14028 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14029
14030         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14031         type_stack.
14032
14033 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14034
14035         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14036         TYPE_CODE_REF types.
14037
14038 2019-02-08  Jim Wilson  <jimw@sifive.com>
14039
14040         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14041         (riscv_linux_fregset): New.
14042         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14043
14044 2019-02-07  Tom Tromey  <tom@tromey.com>
14045
14046         * thread.c (thread_cancel_execution_command): Update.
14047         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14048         methods.
14049         (struct thread_fsm_ops): Remove.
14050         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14051         (thread_fsm_should_stop, thread_fsm_return_value)
14052         (thread_fsm_set_finished, thread_fsm_finished_p)
14053         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14054         Don't declare.
14055         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14056         * infrun.c (clear_proceed_status_thread)
14057         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14058         (print_stop_event): Update.
14059         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14060         Add constructor.
14061         (step_command_fsm_ops): Remove.
14062         (new_step_command_fsm): Remove.
14063         (step_1): Update.
14064         (step_command_fsm::should_stop): Rename from
14065         step_command_fsm_should_stop.
14066         (step_command_fsm::clean_up): Rename from
14067         step_command_fsm_clean_up.
14068         (step_command_fsm::do_async_reply_reason): Rename from
14069         step_command_fsm_async_reply_reason.
14070         (struct until_next_fsm): Inherit from thread_fsm.  Add
14071         constructor.
14072         (until_next_fsm_ops): Remove.
14073         (new_until_next_fsm): Remove.
14074         (until_next_fsm::should_stop): Rename from
14075         until_next_fsm_should_stop.
14076         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14077         (until_next_fsm::do_async_reply_reason): Rename from
14078         until_next_fsm_async_reply_reason.
14079         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14080         constructor.  Change type of breakpoint.
14081         (finish_command_fsm_ops): Remove.
14082         (new_finish_command_fsm): Remove.
14083         (finish_command_fsm::should_stop): Rename from
14084         finish_command_fsm_should_stop.
14085         (finish_command_fsm::clean_up): Rename from
14086         finish_command_fsm_clean_up.
14087         (finish_command_fsm::return_value): Rename from
14088         finish_command_fsm_return_value.
14089         (finish_command_fsm::do_async_reply_reason): Rename from
14090         finish_command_fsm_async_reply_reason.
14091         (finish_command): Update.
14092         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14093         Add constructor.
14094         (call_thread_fsm_ops): Remove.
14095         (call_thread_fsm::call_thread_fsm): Rename from
14096         new_call_thread_fsm.
14097         (call_thread_fsm::should_stop): Rename from
14098         call_thread_fsm_should_stop.
14099         (call_thread_fsm::should_notify_stop): Rename from
14100         call_thread_fsm_should_notify_stop.
14101         (run_inferior_call, call_function_by_hand_dummy): Update.
14102         * cli/cli-interp.c (should_print_stop_to_console): Update.
14103         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14104         Add constructor.  Change type of location_breakpoint,
14105         caller_breakpoint.
14106         (until_break_fsm_ops): Remove.
14107         (new_until_break_fsm): Remove.
14108         (until_break_fsm::should_stop): Rename from
14109         until_break_fsm_should_stop.
14110         (until_break_fsm::clean_up): Rename from
14111         until_break_fsm_clean_up.
14112         (until_break_fsm::do_async_reply_reason): Rename from
14113         until_break_fsm_async_reply_reason.
14114         (until_break_command): Update.
14115         * thread-fsm.c: Remove.
14116         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14117
14118 2019-02-07  Tom Tromey  <tom@tromey.com>
14119
14120         * yy-remap.h: Add include guard.
14121         * xtensa-tdep.h: Add include guard.
14122         * xcoffread.h: Rename include guard.
14123         * varobj-iter.h: Add include guard.
14124         * tui/tui.h: Rename include guard.
14125         * tui/tui-winsource.h: Rename include guard.
14126         * tui/tui-wingeneral.h: Rename include guard.
14127         * tui/tui-windata.h: Rename include guard.
14128         * tui/tui-win.h: Rename include guard.
14129         * tui/tui-stack.h: Rename include guard.
14130         * tui/tui-source.h: Rename include guard.
14131         * tui/tui-regs.h: Rename include guard.
14132         * tui/tui-out.h: Rename include guard.
14133         * tui/tui-layout.h: Rename include guard.
14134         * tui/tui-io.h: Rename include guard.
14135         * tui/tui-hooks.h: Rename include guard.
14136         * tui/tui-file.h: Rename include guard.
14137         * tui/tui-disasm.h: Rename include guard.
14138         * tui/tui-data.h: Rename include guard.
14139         * tui/tui-command.h: Rename include guard.
14140         * tic6x-tdep.h: Add include guard.
14141         * target/waitstatus.h: Rename include guard.
14142         * target/wait.h: Rename include guard.
14143         * target/target.h: Rename include guard.
14144         * target/resume.h: Rename include guard.
14145         * target-float.h: Rename include guard.
14146         * stabsread.h: Add include guard.
14147         * rs6000-tdep.h: Add include guard.
14148         * riscv-fbsd-tdep.h: Add include guard.
14149         * regformats/regdef.h: Rename include guard.
14150         * record.h: Rename include guard.
14151         * python/python.h: Rename include guard.
14152         * python/python-internal.h: Rename include guard.
14153         * python/py-stopevent.h: Rename include guard.
14154         * python/py-ref.h: Rename include guard.
14155         * python/py-record.h: Rename include guard.
14156         * python/py-record-full.h: Rename include guard.
14157         * python/py-record-btrace.h: Rename include guard.
14158         * python/py-instruction.h: Rename include guard.
14159         * python/py-events.h: Rename include guard.
14160         * python/py-event.h: Rename include guard.
14161         * procfs.h: Add include guard.
14162         * proc-utils.h: Add include guard.
14163         * p-lang.h: Add include guard.
14164         * or1k-tdep.h: Rename include guard.
14165         * observable.h: Rename include guard.
14166         * nto-tdep.h: Rename include guard.
14167         * nat/x86-linux.h: Rename include guard.
14168         * nat/x86-linux-dregs.h: Rename include guard.
14169         * nat/x86-gcc-cpuid.h: Add include guard.
14170         * nat/x86-dregs.h: Rename include guard.
14171         * nat/x86-cpuid.h: Rename include guard.
14172         * nat/ppc-linux.h: Rename include guard.
14173         * nat/mips-linux-watch.h: Rename include guard.
14174         * nat/linux-waitpid.h: Rename include guard.
14175         * nat/linux-ptrace.h: Rename include guard.
14176         * nat/linux-procfs.h: Rename include guard.
14177         * nat/linux-osdata.h: Rename include guard.
14178         * nat/linux-nat.h: Rename include guard.
14179         * nat/linux-namespaces.h: Rename include guard.
14180         * nat/linux-btrace.h: Rename include guard.
14181         * nat/glibc_thread_db.h: Rename include guard.
14182         * nat/gdb_thread_db.h: Rename include guard.
14183         * nat/gdb_ptrace.h: Rename include guard.
14184         * nat/fork-inferior.h: Rename include guard.
14185         * nat/amd64-linux-siginfo.h: Rename include guard.
14186         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14187         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14188         * nat/aarch64-linux.h: Rename include guard.
14189         * nat/aarch64-linux-hw-point.h: Rename include guard.
14190         * mn10300-tdep.h: Add include guard.
14191         * mips-linux-tdep.h: Add include guard.
14192         * mi/mi-parse.h: Rename include guard.
14193         * mi/mi-out.h: Rename include guard.
14194         * mi/mi-main.h: Rename include guard.
14195         * mi/mi-interp.h: Rename include guard.
14196         * mi/mi-getopt.h: Rename include guard.
14197         * mi/mi-console.h: Rename include guard.
14198         * mi/mi-common.h: Rename include guard.
14199         * mi/mi-cmds.h: Rename include guard.
14200         * mi/mi-cmd-break.h: Rename include guard.
14201         * m2-lang.h: Add include guard.
14202         * location.h: Rename include guard.
14203         * linux-record.h: Rename include guard.
14204         * linux-nat.h: Add include guard.
14205         * linux-fork.h: Add include guard.
14206         * i386-darwin-tdep.h: Rename include guard.
14207         * hppa-linux-offsets.h: Add include guard.
14208         * guile/guile.h: Rename include guard.
14209         * guile/guile-internal.h: Rename include guard.
14210         * gnu-nat.h: Rename include guard.
14211         * gdb-stabs.h: Rename include guard.
14212         * frv-tdep.h: Add include guard.
14213         * f-lang.h: Add include guard.
14214         * event-loop.h: Add include guard.
14215         * darwin-nat.h: Rename include guard.
14216         * cp-abi.h: Rename include guard.
14217         * config/sparc/nm-sol2.h: Rename include guard.
14218         * config/nm-nto.h: Rename include guard.
14219         * config/nm-linux.h: Add include guard.
14220         * config/i386/nm-i386gnu.h: Rename include guard.
14221         * config/djgpp/nl_types.h: Rename include guard.
14222         * config/djgpp/langinfo.h: Rename include guard.
14223         * compile/gcc-cp-plugin.h: Add include guard.
14224         * compile/gcc-c-plugin.h: Add include guard.
14225         * compile/compile.h: Rename include guard.
14226         * compile/compile-object-run.h: Rename include guard.
14227         * compile/compile-object-load.h: Rename include guard.
14228         * compile/compile-internal.h: Rename include guard.
14229         * compile/compile-cplus.h: Rename include guard.
14230         * compile/compile-c.h: Rename include guard.
14231         * common/xml-utils.h: Rename include guard.
14232         * common/x86-xstate.h: Rename include guard.
14233         * common/version.h: Rename include guard.
14234         * common/vec.h: Rename include guard.
14235         * common/tdesc.h: Rename include guard.
14236         * common/selftest.h: Rename include guard.
14237         * common/scoped_restore.h: Rename include guard.
14238         * common/scoped_mmap.h: Rename include guard.
14239         * common/scoped_fd.h: Rename include guard.
14240         * common/safe-iterator.h: Rename include guard.
14241         * common/run-time-clock.h: Rename include guard.
14242         * common/refcounted-object.h: Rename include guard.
14243         * common/queue.h: Rename include guard.
14244         * common/ptid.h: Rename include guard.
14245         * common/print-utils.h: Rename include guard.
14246         * common/preprocessor.h: Rename include guard.
14247         * common/pathstuff.h: Rename include guard.
14248         * common/observable.h: Rename include guard.
14249         * common/netstuff.h: Rename include guard.
14250         * common/job-control.h: Rename include guard.
14251         * common/host-defs.h: Rename include guard.
14252         * common/gdb_wait.h: Rename include guard.
14253         * common/gdb_vecs.h: Rename include guard.
14254         * common/gdb_unlinker.h: Rename include guard.
14255         * common/gdb_unique_ptr.h: Rename include guard.
14256         * common/gdb_tilde_expand.h: Rename include guard.
14257         * common/gdb_sys_time.h: Rename include guard.
14258         * common/gdb_string_view.h: Rename include guard.
14259         * common/gdb_splay_tree.h: Rename include guard.
14260         * common/gdb_setjmp.h: Rename include guard.
14261         * common/gdb_ref_ptr.h: Rename include guard.
14262         * common/gdb_optional.h: Rename include guard.
14263         * common/gdb_locale.h: Rename include guard.
14264         * common/gdb_assert.h: Rename include guard.
14265         * common/filtered-iterator.h: Rename include guard.
14266         * common/filestuff.h: Rename include guard.
14267         * common/fileio.h: Rename include guard.
14268         * common/environ.h: Rename include guard.
14269         * common/common-utils.h: Rename include guard.
14270         * common/common-types.h: Rename include guard.
14271         * common/common-regcache.h: Rename include guard.
14272         * common/common-inferior.h: Rename include guard.
14273         * common/common-gdbthread.h: Rename include guard.
14274         * common/common-exceptions.h: Rename include guard.
14275         * common/common-defs.h: Rename include guard.
14276         * common/common-debug.h: Rename include guard.
14277         * common/cleanups.h: Rename include guard.
14278         * common/buffer.h: Rename include guard.
14279         * common/btrace-common.h: Rename include guard.
14280         * common/break-common.h: Rename include guard.
14281         * cli/cli-utils.h: Rename include guard.
14282         * cli/cli-style.h: Rename include guard.
14283         * cli/cli-setshow.h: Rename include guard.
14284         * cli/cli-script.h: Rename include guard.
14285         * cli/cli-interp.h: Rename include guard.
14286         * cli/cli-decode.h: Rename include guard.
14287         * cli/cli-cmds.h: Rename include guard.
14288         * charset-list.h: Add include guard.
14289         * buildsym-legacy.h: Rename include guard.
14290         * bfin-tdep.h: Add include guard.
14291         * ax.h: Rename include guard.
14292         * arm-linux-tdep.h: Add include guard.
14293         * arm-fbsd-tdep.h: Add include guard.
14294         * arch/xtensa.h: Rename include guard.
14295         * arch/tic6x.h: Add include guard.
14296         * arch/i386.h: Add include guard.
14297         * arch/arm.h: Rename include guard.
14298         * arch/arm-linux.h: Rename include guard.
14299         * arch/arm-get-next-pcs.h: Rename include guard.
14300         * arch/amd64.h: Add include guard.
14301         * arch/aarch64-insn.h: Rename include guard.
14302         * arch-utils.h: Rename include guard.
14303         * annotate.h: Add include guard.
14304         * amd64-darwin-tdep.h: Rename include guard.
14305         * aarch64-linux-tdep.h: Add include guard.
14306         * aarch64-fbsd-tdep.h: Add include guard.
14307         * aarch32-linux-nat.h: Add include guard.
14308
14309 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14310
14311         * macrotab.c (macro_define_internal): New function that
14312         factorizes macro_define_object_internal and macro_define_function
14313         code.
14314         (macro_define_object_internal): Use macro_define_internal.
14315         (macro_define_function): Likewise.
14316
14317 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14318
14319         * macrocmd.c (extract_identifier): Return
14320         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14321         callers.
14322
14323 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14324
14325         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14326
14327 2019-02-05  Tom Tromey  <tom@tromey.com>
14328
14329         * target.c (target_stack::unpush): Move assertion earlier.
14330
14331 2019-01-30  Tom Tromey  <tom@tromey.com>
14332
14333         PR python/23615:
14334         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14335         (gdbpy_parse_and_eval): Likewise.
14336         * python/python-internal.h (gdbpy_allow_threads): New class.
14337
14338 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14339
14340         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14341         (aarch64_fbsd_fpregmap): Move earlier.
14342         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14343         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14344         instead of individual calls to trad_frame_set_reg_addr.
14345         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14346         earlier.
14347         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14348         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14349         instead of individual calls to trad_frame_set_reg_addr.
14350
14351 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14352
14353         * CONTRIBUTE: Replace contribution list with wiki link.
14354
14355 2019-01-25  Tom Tromey  <tom@tromey.com>
14356
14357         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14358
14359 2019-01-25  Tom Tromey  <tom@tromey.com>
14360
14361         * xtensa-linux-nat.c: Fix common/ includes.
14362         * xml-support.h: Fix common/ includes.
14363         * xml-support.c: Fix common/ includes.
14364         * x86-linux-nat.c: Fix common/ includes.
14365         * windows-nat.c: Fix common/ includes.
14366         * varobj.h: Fix common/ includes.
14367         * varobj.c: Fix common/ includes.
14368         * value.c: Fix common/ includes.
14369         * valops.c: Fix common/ includes.
14370         * utils.c: Fix common/ includes.
14371         * unittests/xml-utils-selftests.c: Fix common/ includes.
14372         * unittests/utils-selftests.c: Fix common/ includes.
14373         * unittests/unpack-selftests.c: Fix common/ includes.
14374         * unittests/tracepoint-selftests.c: Fix common/ includes.
14375         * unittests/style-selftests.c: Fix common/ includes.
14376         * unittests/string_view-selftests.c: Fix common/ includes.
14377         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14378         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14379         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14380         * unittests/rsp-low-selftests.c: Fix common/ includes.
14381         * unittests/parse-connection-spec-selftests.c: Fix common/
14382         includes.
14383         * unittests/optional-selftests.c: Fix common/ includes.
14384         * unittests/offset-type-selftests.c: Fix common/ includes.
14385         * unittests/observable-selftests.c: Fix common/ includes.
14386         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14387         * unittests/memrange-selftests.c: Fix common/ includes.
14388         * unittests/memory-map-selftests.c: Fix common/ includes.
14389         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14390         * unittests/function-view-selftests.c: Fix common/ includes.
14391         * unittests/environ-selftests.c: Fix common/ includes.
14392         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14393         * unittests/common-utils-selftests.c: Fix common/ includes.
14394         * unittests/cli-utils-selftests.c: Fix common/ includes.
14395         * unittests/array-view-selftests.c: Fix common/ includes.
14396         * ui-file.c: Fix common/ includes.
14397         * tui/tui-io.c: Fix common/ includes.
14398         * tracepoint.h: Fix common/ includes.
14399         * tracepoint.c: Fix common/ includes.
14400         * tracefile-tfile.c: Fix common/ includes.
14401         * top.h: Fix common/ includes.
14402         * top.c: Fix common/ includes.
14403         * thread.c: Fix common/ includes.
14404         * target/waitstatus.h: Fix common/ includes.
14405         * target/waitstatus.c: Fix common/ includes.
14406         * target.h: Fix common/ includes.
14407         * target.c: Fix common/ includes.
14408         * target-memory.c: Fix common/ includes.
14409         * target-descriptions.c: Fix common/ includes.
14410         * symtab.h: Fix common/ includes.
14411         * symfile.c: Fix common/ includes.
14412         * stap-probe.c: Fix common/ includes.
14413         * spu-linux-nat.c: Fix common/ includes.
14414         * sparc-nat.c: Fix common/ includes.
14415         * source.c: Fix common/ includes.
14416         * solib.c: Fix common/ includes.
14417         * solib-target.c: Fix common/ includes.
14418         * ser-unix.c: Fix common/ includes.
14419         * ser-tcp.c: Fix common/ includes.
14420         * ser-pipe.c: Fix common/ includes.
14421         * ser-base.c: Fix common/ includes.
14422         * selftest-arch.c: Fix common/ includes.
14423         * s12z-tdep.c: Fix common/ includes.
14424         * rust-exp.y: Fix common/ includes.
14425         * rs6000-aix-tdep.c: Fix common/ includes.
14426         * riscv-tdep.c: Fix common/ includes.
14427         * remote.c: Fix common/ includes.
14428         * remote-notif.h: Fix common/ includes.
14429         * remote-fileio.h: Fix common/ includes.
14430         * remote-fileio.c: Fix common/ includes.
14431         * regcache.h: Fix common/ includes.
14432         * regcache.c: Fix common/ includes.
14433         * record-btrace.c: Fix common/ includes.
14434         * python/python.c: Fix common/ includes.
14435         * python/py-type.c: Fix common/ includes.
14436         * python/py-inferior.c: Fix common/ includes.
14437         * progspace.h: Fix common/ includes.
14438         * producer.c: Fix common/ includes.
14439         * procfs.c: Fix common/ includes.
14440         * proc-api.c: Fix common/ includes.
14441         * printcmd.c: Fix common/ includes.
14442         * ppc-linux-nat.c: Fix common/ includes.
14443         * parser-defs.h: Fix common/ includes.
14444         * osdata.c: Fix common/ includes.
14445         * obsd-nat.c: Fix common/ includes.
14446         * nat/x86-linux.c: Fix common/ includes.
14447         * nat/x86-linux-dregs.c: Fix common/ includes.
14448         * nat/x86-dregs.h: Fix common/ includes.
14449         * nat/x86-dregs.c: Fix common/ includes.
14450         * nat/ppc-linux.c: Fix common/ includes.
14451         * nat/mips-linux-watch.h: Fix common/ includes.
14452         * nat/mips-linux-watch.c: Fix common/ includes.
14453         * nat/linux-waitpid.c: Fix common/ includes.
14454         * nat/linux-ptrace.h: Fix common/ includes.
14455         * nat/linux-ptrace.c: Fix common/ includes.
14456         * nat/linux-procfs.c: Fix common/ includes.
14457         * nat/linux-personality.c: Fix common/ includes.
14458         * nat/linux-osdata.c: Fix common/ includes.
14459         * nat/linux-namespaces.c: Fix common/ includes.
14460         * nat/linux-btrace.h: Fix common/ includes.
14461         * nat/linux-btrace.c: Fix common/ includes.
14462         * nat/fork-inferior.c: Fix common/ includes.
14463         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14464         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14465         * nat/aarch64-linux.c: Fix common/ includes.
14466         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14467         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14468         * namespace.h: Fix common/ includes.
14469         * mips-linux-tdep.c: Fix common/ includes.
14470         * minsyms.c: Fix common/ includes.
14471         * mi/mi-parse.h: Fix common/ includes.
14472         * mi/mi-main.c: Fix common/ includes.
14473         * mi/mi-cmd-env.c: Fix common/ includes.
14474         * memrange.h: Fix common/ includes.
14475         * memattr.c: Fix common/ includes.
14476         * maint.h: Fix common/ includes.
14477         * maint.c: Fix common/ includes.
14478         * main.c: Fix common/ includes.
14479         * machoread.c: Fix common/ includes.
14480         * location.c: Fix common/ includes.
14481         * linux-thread-db.c: Fix common/ includes.
14482         * linux-nat.c: Fix common/ includes.
14483         * linux-fork.c: Fix common/ includes.
14484         * inline-frame.c: Fix common/ includes.
14485         * infrun.c: Fix common/ includes.
14486         * inflow.c: Fix common/ includes.
14487         * inferior.h: Fix common/ includes.
14488         * inferior.c: Fix common/ includes.
14489         * infcmd.c: Fix common/ includes.
14490         * inf-ptrace.c: Fix common/ includes.
14491         * inf-child.c: Fix common/ includes.
14492         * ia64-linux-nat.c: Fix common/ includes.
14493         * i387-tdep.c: Fix common/ includes.
14494         * i386-tdep.c: Fix common/ includes.
14495         * i386-linux-tdep.c: Fix common/ includes.
14496         * i386-linux-nat.c: Fix common/ includes.
14497         * i386-go32-tdep.c: Fix common/ includes.
14498         * i386-fbsd-tdep.c: Fix common/ includes.
14499         * i386-fbsd-nat.c: Fix common/ includes.
14500         * guile/scm-type.c: Fix common/ includes.
14501         * guile/guile.c: Fix common/ includes.
14502         * go32-nat.c: Fix common/ includes.
14503         * gnu-nat.c: Fix common/ includes.
14504         * gdbthread.h: Fix common/ includes.
14505         * gdbarch-selftests.c: Fix common/ includes.
14506         * gdb_usleep.c: Fix common/ includes.
14507         * gdb_select.h: Fix common/ includes.
14508         * gdb_bfd.c: Fix common/ includes.
14509         * gcore.c: Fix common/ includes.
14510         * fork-child.c: Fix common/ includes.
14511         * findvar.c: Fix common/ includes.
14512         * fbsd-nat.c: Fix common/ includes.
14513         * event-top.c: Fix common/ includes.
14514         * event-loop.c: Fix common/ includes.
14515         * dwarf2read.c: Fix common/ includes.
14516         * dwarf2loc.c: Fix common/ includes.
14517         * dwarf2-frame.c: Fix common/ includes.
14518         * dwarf-index-cache.c: Fix common/ includes.
14519         * dtrace-probe.c: Fix common/ includes.
14520         * disasm-selftests.c: Fix common/ includes.
14521         * defs.h: Fix common/ includes.
14522         * csky-tdep.c: Fix common/ includes.
14523         * cp-valprint.c: Fix common/ includes.
14524         * cp-support.h: Fix common/ includes.
14525         * cp-support.c: Fix common/ includes.
14526         * corelow.c: Fix common/ includes.
14527         * completer.h: Fix common/ includes.
14528         * completer.c: Fix common/ includes.
14529         * compile/compile.c: Fix common/ includes.
14530         * compile/compile-loc2c.c: Fix common/ includes.
14531         * compile/compile-cplus-types.c: Fix common/ includes.
14532         * compile/compile-cplus-symbols.c: Fix common/ includes.
14533         * command.h: Fix common/ includes.
14534         * cli/cli-dump.c: Fix common/ includes.
14535         * cli/cli-cmds.c: Fix common/ includes.
14536         * charset.c: Fix common/ includes.
14537         * build-id.c: Fix common/ includes.
14538         * btrace.h: Fix common/ includes.
14539         * btrace.c: Fix common/ includes.
14540         * breakpoint.h: Fix common/ includes.
14541         * breakpoint.c: Fix common/ includes.
14542         * ax.h:
14543         (enum agent_op): Fix common/ includes.
14544         * ax-general.c (struct aop_map): Fix common/ includes.
14545         * ax-gdb.c: Fix common/ includes.
14546         * auxv.c: Fix common/ includes.
14547         * auto-load.c: Fix common/ includes.
14548         * arm-tdep.c: Fix common/ includes.
14549         * arch/riscv.c: Fix common/ includes.
14550         * arch/ppc-linux-common.c: Fix common/ includes.
14551         * arch/i386.c: Fix common/ includes.
14552         * arch/arm.c: Fix common/ includes.
14553         * arch/arm-linux.c: Fix common/ includes.
14554         * arch/arm-get-next-pcs.c: Fix common/ includes.
14555         * arch/amd64.c: Fix common/ includes.
14556         * arch/aarch64.c: Fix common/ includes.
14557         * arch/aarch64-insn.c: Fix common/ includes.
14558         * arch-utils.c: Fix common/ includes.
14559         * amd64-windows-tdep.c: Fix common/ includes.
14560         * amd64-tdep.c: Fix common/ includes.
14561         * amd64-sol2-tdep.c: Fix common/ includes.
14562         * amd64-obsd-tdep.c: Fix common/ includes.
14563         * amd64-nbsd-tdep.c: Fix common/ includes.
14564         * amd64-linux-tdep.c: Fix common/ includes.
14565         * amd64-linux-nat.c: Fix common/ includes.
14566         * amd64-fbsd-tdep.c: Fix common/ includes.
14567         * amd64-fbsd-nat.c: Fix common/ includes.
14568         * amd64-dicos-tdep.c: Fix common/ includes.
14569         * amd64-darwin-tdep.c: Fix common/ includes.
14570         * agent.c: Fix common/ includes.
14571         * ada-lang.h: Fix common/ includes.
14572         * ada-lang.c: Fix common/ includes.
14573         * aarch64-tdep.c: Fix common/ includes.
14574
14575 2019-01-25  Tom Tromey  <tom@tromey.com>
14576
14577         * common/create-version.sh: Use common/version.h.
14578
14579 2019-01-24  Pedro Alves  <palves@redhat.com>
14580
14581         * infrun.c (signal_stop, signal_print, signal_program)
14582         (signal_catch, signal_pass): Now arrays instead of pointers.
14583         (update_signals_program_target, do_target_resume)
14584         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14585         * linux-nat.c (linux_nat_target::pass_signals)
14586         (linux_nat_target::create_inferior, linux_nat_target::attach):
14587         Adjust.
14588         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14589         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14590         * procfs.c (procfs_target::pass_signals): Adjust.
14591         * record-full.c (record_full_target::resume): Adjust.
14592         * remote.c (remote_target::pass_signals)
14593         (remote_target::program_signals): Adjust.
14594         * target-debug.h (target_debug_print_signals): Now takes a
14595         gdb::array_view as parameter.  Adjust.
14596         * target.h (target_ops) <pass_signals, program_signals>: Replace
14597         pointer and length parameters with gdb::array_view.
14598         (target_pass_signals, target_program_signals): Likewise.
14599         * target-delegates.c: Regenerate.
14600
14601 2019-01-24  Pedro Alves  <palves@redhat.com>
14602
14603         * common/forward-scope-exit.h
14604         (forward_scope_exit::forward_scope_exit): Pass arguments to
14605         m_bind_function directly, instead of creating a std::bind and
14606         copying that.
14607
14608 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14609
14610         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14611         for static members.
14612         (pass_in_v_vfp_candidate): Likewise.
14613
14614 2019-01-23  Tom Tromey  <tom@tromey.com>
14615             Pedro Alves  <palves@redhat.com>
14616
14617         * regcache.c (class regcache_invalidator): Remove.
14618         (regcache::raw_write): Use make_scope_exit.
14619
14620 2019-01-23  Tom Tromey  <tom@tromey.com>
14621
14622         * ui-out.h (class ui_out_emit_type): Update comment.
14623
14624 2019-01-23  Tom Tromey  <tom@tromey.com>
14625
14626         * infrun.c (fetch_inferior_event): Update comment.
14627
14628 2019-01-23  Tom Tromey  <tom@tromey.com>
14629             Pedro Alves  <palves@redhat.com>
14630
14631         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14632         parameter.
14633         (fetch_inferior_event): Use SCOPE_EXIT.
14634
14635
14636 2019-01-23  Tom Tromey  <tom@tromey.com>
14637             Pedro Alves  <palves@redhat.com>
14638
14639         * infrun.c (disable_thread_events): Delete.
14640         (stop_all_threads): Use SCOPE_EXIT.
14641
14642 2019-01-23  Tom Tromey  <tom@tromey.com>
14643             Pedro Alves  <palves@redhat.com>
14644
14645         * symfile.c: Include forward-scope-exit.h.
14646         (clear_symtab_users_cleanup): Replace forward declaration with
14647         a FORWARD_SCOPE_EXIT.
14648         (syms_from_objfile_1): Use the forward_scope_exit and
14649         gdb::optional instead of cleanup_function.
14650         (reread_symbols): Use the forward_scope_exit instead of
14651         cleanup_function.
14652         (clear_symtab_users_cleanup): Remove function.
14653
14654 2019-01-23  Tom Tromey  <tom@tromey.com>
14655             Pedro Alves  <palves@redhat.com>
14656
14657         * linux-nat.c: Include scope-exit.h.
14658         (cleanup_target_stop): Remove.
14659         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14660         SCOPE_EXIT.
14661
14662 2019-01-23  Tom Tromey  <tom@tromey.com>
14663             Pedro Alves  <palves@redhat.com>
14664
14665         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14666         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14667
14668 2019-01-23  Tom Tromey  <tom@tromey.com>
14669             Andrew Burgess  <andrew.burgess@embecosm.com>
14670             Pedro Alves  <palves@redhat.com>
14671
14672         * infrun.c (fetch_inferior_event): Use scope_exit.
14673         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14674         * top.c (execute_command): Use scope_exit.
14675         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14676         * utils.c (do_bpstat_clear_actions_cleanup)
14677         (make_bpstat_clear_actions_cleanup): Remove.
14678
14679 2019-01-23  Tom Tromey  <tom@tromey.com>
14680             Pedro Alves  <palves@redhat.com>
14681
14682         * infrun.c: Include "common/scope-exit.h"
14683         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14684         (wait_for_inferior): Use SCOPE_EXIT.
14685         (fetch_inferior_event): Use scope_exit.
14686
14687 2019-01-23  Tom Tromey  <tom@tromey.com>
14688             Pedro Alves  <palves@redhat.com>
14689
14690         * breakpoint.c (create_breakpoint): Remove cleanup.
14691
14692 2019-01-23  Tom Tromey  <tom@tromey.com>
14693             Andrew Burgess  <andrew.burgess@embecosm.com>
14694             Pedro Alves  <palves@redhat.com>
14695
14696 2019-01-23  Pedro Alves  <palves@redhat.com>
14697
14698         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14699
14700 2019-01-23  Pedro Alves  <palves@redhat.com>
14701             Andrew Burgess  <andrew.burgess@embecosm.com>
14702
14703         * gdbthread.h: Include "common/forward-scope-exit.h".
14704         (scoped_finish_thread_state): Redefine custom class in terms of
14705         forward_scope_exit.
14706
14707 2019-01-23  Pedro Alves  <palves@redhat.com>
14708             Andrew Burgess  <andrew.burgess@embecosm.com>
14709
14710         * common/forward-scope-exit.h: New file.
14711
14712 2019-01-23  Pedro Alves  <palves@redhat.com>
14713             Andrew Burgess  <andrew.burgess@embecosm.com>
14714             Tom Tromey  <tom@tromey.com>
14715
14716         * common/scope-exit.h: New file.
14717
14718 2019-01-23  Pedro Alves  <palves@redhat.com>
14719
14720         * common/preprocessor.h (ESC): Rename to ...
14721         (ESC_PARENS): ... this.
14722         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14723         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14724
14725 2019-01-23  Tom Tromey  <tom@tromey.com>
14726
14727         * language.h (class scoped_switch_to_sym_language_if_auto):
14728         Initialize m_lang in both cases.
14729
14730 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14731
14732         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14733         with XCNEW.
14734
14735 2019-01-22  Tom Tromey  <tom@tromey.com>
14736
14737         * corelow.c: Do not include sys/file.h.
14738
14739 2019-01-22  Tom Tromey  <tom@tromey.com>
14740
14741         * tui/tui-wingeneral.h: Include gdb_curses.h.
14742
14743 2019-01-22  Tom Tromey  <tom@tromey.com>
14744
14745         * source-cache.h (class source_cache) <get_source_lines,
14746         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14747
14748 2019-01-22  Tom Tromey  <tom@tromey.com>
14749
14750         * remote-fileio.h (struct remote_target): Declare.
14751
14752 2019-01-22  Tom Tromey  <tom@tromey.com>
14753
14754         * python/py-arch.c: Do not include py-ref.h.
14755         * python/py-bpevent.c: Do not include py-ref.h.
14756         * python/py-cmd.c: Do not include py-ref.h.
14757         * python/py-continueevent.c: Do not include py-ref.h.
14758         * python/py-event.h: Do not include py-ref.h.
14759         * python/py-evtregistry.c: Do not include py-ref.h.
14760         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14761         * python/py-frame.c: Do not include py-ref.h.
14762         * python/py-framefilter.c: Do not include py-ref.h.
14763         * python/py-function.c: Do not include py-ref.h.
14764         * python/py-infevents.c: Do not include py-ref.h.
14765         * python/py-linetable.c: Do not include py-ref.h.
14766         * python/py-objfile.c: Do not include py-ref.h.
14767         * python/py-param.c: Do not include py-ref.h.
14768         * python/py-prettyprint.c: Do not include py-ref.h.
14769         * python/py-progspace.c: Do not include py-ref.h.
14770         * python/py-symbol.c: Do not include py-ref.h.
14771         * python/py-symtab.c: Do not include py-ref.h.
14772         * python/py-type.c: Do not include py-ref.h.
14773         * python/py-unwind.c: Do not include py-ref.h.
14774         * python/py-utils.c: Do not include py-ref.h.
14775         * python/py-value.c: Do not include py-ref.h.
14776         * python/py-varobj.c: Do not include py-ref.h.
14777         * python/py-xmethods.c: Do not include py-ref.h.
14778         * python/python.c: Do not include py-ref.h.
14779         * varobj.c: Do not include py-ref.h.
14780
14781 2019-01-22  Tom Tromey  <tom@tromey.com>
14782
14783         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14784         keyword for bcache.
14785
14786 2019-01-22  Tom Tromey  <tom@tromey.com>
14787
14788         * compile/compile-cplus-types.c: Remove a comment by #include.
14789
14790 2019-01-22  Tom Tromey  <tom@tromey.com>
14791
14792         * compile/gcc-c-plugin.h: Include compile-internal.h.
14793
14794 2019-01-22  Tom Tromey  <tom@tromey.com>
14795
14796         * stabsread.c (EXTERN): Do not define.
14797         (symnum, next_symbol_text_func, processing_gcc_compilation)
14798         (within_function, global_sym_chain, global_stabs)
14799         (previous_stab_code, this_object_header_files)
14800         (n_this_object_header_files)
14801         (n_allocated_this_object_header_files): Define.
14802         * stabsread.h (EXTERN): Never define.  Use "extern".
14803
14804 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14805
14806         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14807         history_value.
14808
14809 2019-01-21  Tom Tromey  <tom@tromey.com>
14810
14811         * ui-out.c: Fix includes.
14812         * tui/tui-source.c: Fix includes.
14813         * target.c: Fix includes.
14814         * remote.c: Fix includes.
14815         * regcache.c: Fix includes.
14816         * python/py-block.c: Fix includes.
14817         * printcmd.c: Fix includes.
14818         * or1k-tdep.c: Fix includes.
14819         * mi/mi-main.c: Fix includes.
14820         * m32r-tdep.c: Fix includes.
14821         * csky-tdep.c: Fix includes.
14822         * compile/compile-cplus-types.c: Fix includes.
14823         * cli/cli-interp.c: Fix includes.
14824
14825 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14826
14827         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14828         for padding.
14829
14830 2019-01-16  Tom Tromey  <tom@tromey.com>
14831
14832         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14833         earlier.
14834         (struct objfile) <msymbols_range>: Move from top level.
14835         <msymbols>: New method.
14836         (class objfile_msymbols): Remove.
14837         * symtab.c (default_collect_symbol_completion_matches_break_on):
14838         Update.
14839         * symmisc.c (dump_msymbols): Update.
14840         * stabsread.c (scan_file_globals): Update.
14841         * objc-lang.c (info_selectors_command, info_classes_command)
14842         (find_methods): Update.
14843         * minsyms.c (find_solib_trampoline_target): Update.
14844         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14845         * coffread.c (coff_symfile_read): Update.
14846         * ada-lang.c (ada_lookup_simple_minsym)
14847         (ada_collect_symbol_completion_matches): Update.
14848
14849 2019-01-16  Tom Tromey  <tom@tromey.com>
14850
14851         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14852         type.  Remove no-argument constructor.
14853         <iterator::operator++>: Simplify.
14854         <begin>: Update.
14855         <end>: Use minimal_symbol_count.
14856
14857 2019-01-16  Tom Tromey  <tom@tromey.com>
14858
14859         * objfiles.h (struct objfile) <psymtabs>: New method.
14860         (class objfile_psymtabs): Remove.
14861         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14862         typedef.
14863         <range>: New method.
14864         (require_partial_symbols): Change return type.
14865         * psymtab.c (require_partial_symbols)
14866         (psym_expand_symtabs_matching): Update.
14867         * mdebugread.c (parse_partial_symbols): Update.
14868         * dbxread.c (dbx_end_psymtab): Update.
14869
14870 2019-01-15  Tom Tromey  <tom@tromey.com>
14871
14872         * symtab.c (lookup_objfile_from_block)
14873         (lookup_symbol_in_objfile_symtabs)
14874         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14875         (find_line_symtab, info_sources_command)
14876         (default_collect_symbol_completion_matches_break_on)
14877         (make_source_files_completion_list): Update.
14878         * symmisc.c (print_objfile_statistics, dump_objfile)
14879         (maintenance_print_symbols, maintenance_info_symtabs)
14880         (maintenance_check_symtabs, maintenance_info_line_tables):
14881         Update.
14882         * source.c (select_source_symtab)
14883         (forget_cached_source_info_for_objfile): Update.
14884         * objfiles.h (class objfile_compunits): Remove.
14885         (struct objfile) <compunits_range>: New typedef.
14886         (compunits): New method.
14887         * objfiles.c (objfile_relocate1): Update.
14888         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14889         * maint.c (count_symtabs_and_blocks): Update.
14890         * linespec.c (iterate_over_all_matching_symtabs): Update.
14891         * cp-support.c (add_symbol_overload_list_qualified): Update.
14892         * coffread.c (coff_symtab_read): Update.
14893         * ada-lang.c (add_nonlocal_symbols)
14894         (ada_collect_symbol_completion_matches)
14895         (ada_add_global_exceptions): Update.
14896
14897 2019-01-15  Tom Tromey  <tom@tromey.com>
14898
14899         * progspace.h (program_space) <objfiles_safe_range>: New
14900         typedef.
14901         <objfiles_safe>: New method.
14902         * objfiles.h (class all_objfiles_safe): Remove.
14903         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14904         * jit.c (jit_inferior_exit_hook): Update.
14905
14906 2019-01-17  Tom Tromey  <tom@tromey.com>
14907
14908         * progspace.h (program_space) <objfiles_range>: New typedef.
14909         <objfiles>: New method.
14910         <objfiles_head>: Rename from objfiles.
14911         (object_files): Update.
14912         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14913         * guile/scm-pretty-print.c
14914         (ppscm_find_pretty_printer_from_objfiles): Update.
14915         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14917         Update.
14918         * python/py-progspace.c (pspy_get_objfiles): Update.
14919         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14920         Update.
14921         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14922         (objfpy_lookup_objfile_by_build_id): Update.
14923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14924         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14925         Update.
14926         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14927         (expand_symtab_containing_pc, lookup_objfile_from_block)
14928         (lookup_static_symbol, basic_lookup_transparent_type)
14929         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14930         (find_line_symtab, info_sources_command)
14931         (default_collect_symbol_completion_matches_break_on)
14932         (make_source_files_completion_list, find_main_name): Update.
14933         * symmisc.c (print_symbol_bcache_statistics)
14934         (print_objfile_statistics, maintenance_print_symbols)
14935         (maintenance_print_msymbols, maintenance_print_objfiles)
14936         (maintenance_info_symtabs, maintenance_check_symtabs)
14937         (maintenance_expand_symtabs, maintenance_info_line_tables):
14938         Update.
14939         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14940         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14941         (map_overlay_command, unmap_overlay_command)
14942         (simple_overlay_update, expand_symtabs_matching)
14943         (map_symbol_filenames): Update.
14944         * symfile-debug.c (set_debug_symfile): Update.
14945         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14946         Update.
14947         * source.c (select_source_symtab, forget_cached_source_info):
14948         Update.
14949         * solib.c (solib_read_symbols): Update.
14950         * solib-spu.c (append_ocl_sos): Update.
14951         * psymtab.c (maintenance_print_psymbols)
14952         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14953         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14954         * printcmd.c (info_symbol_command): Update.
14955         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14956         Update.
14957         * objfiles.h (class all_objfiles): Remove.
14958         * objfiles.c (have_partial_symbols, have_full_symbols)
14959         (have_minimal_symbols, qsort_cmp, update_section_map)
14960         (shared_objfile_contains_address_p)
14961         (default_iterate_over_objfiles_in_search_order): Update.
14962         * objc-lang.c (info_selectors_command, info_classes_command)
14963         (find_methods): Update.
14964         * minsyms.c (find_solib_trampoline_target): Update.
14965         * maint.c (maintenance_info_sections)
14966         (maintenance_translate_address, count_symtabs_and_blocks):
14967         Update.
14968         * main.c (captured_main_1): Update.
14969         * linux-thread-db.c (try_thread_db_load_from_pdir)
14970         (has_libpthread): Update.
14971         * linespec.c (iterate_over_all_matching_symtabs)
14972         (search_minsyms_for_name): Update.
14973         * jit.c (jit_find_objf_with_entry_addr): Update.
14974         * hppa-tdep.c (find_unwind_entry)
14975         (hppa_lookup_stub_minimal_symbol): Update.
14976         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14977         Update.
14978         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14979         (elf_gnu_ifunc_resolve_by_got): Update.
14980         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14981         * dwarf-index-write.c (save_gdb_index_command): Update.
14982         * cp-support.c (add_symbol_overload_list_qualified): Update.
14983         * breakpoint.c (create_overlay_event_breakpoint)
14984         (create_longjmp_master_breakpoint)
14985         (create_std_terminate_master_breakpoint)
14986         (create_exception_master_breakpoint): Update.
14987         * blockframe.c (find_pc_partial_function): Update.
14988         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14989         (ada_collect_symbol_completion_matches)
14990         (ada_add_global_exceptions): Update.
14991
14992 2019-01-17  Tom Tromey  <tom@tromey.com>
14993
14994         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14995         declare VEC.
14996         (solib_target_parse_libraries): Change return type.
14997         (library_list_start_segment, library_list_start_section)
14998         (library_list_end_library, library_list_start_library); Update.
14999         (solib_target_free_library_list): Remove.
15000         (solib_target_parse_libraries): Remove cleanup.  Change return
15001         type.
15002         (solib_target_current_sos): Update.
15003
15004 2019-01-17  Tom Tromey  <tromey@bapiya>
15005
15006         * valprint.c: Replace "the the" with "the".
15007         * symtab.c: Replace "the the" with "the".
15008         * solib.c: Replace "the the" with "the".
15009         * solib-dsbt.c: Replace "the the" with "the".
15010         * linespec.c: Replace "the the" with "the".
15011         * dwarf2loc.h: Replace "the the" with "the".
15012         * amd64-windows-tdep.c: Replace "the the" with "the".
15013         * aarch64-tdep.c: Replace "the the" with "the".
15014
15015 2019-01-16  Keith Seitz  <keiths@redhat.com>
15016
15017         PR gdb/23773
15018         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15019         <builder>: Rename to ..
15020         <m_builder>: ... this and make private.
15021         (dwarf2_cu::get_builder): New method.  Change all users of
15022         `builder' to use this method.
15023         (dwarf2_start_symtab): Move to ...
15024         (dwarf2_cu::start_symtab): ... here.  Update all callers
15025         (setup_type_unit_groups): Move to ...
15026         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15027         callers.
15028         (dwarf2_cu::reset_builder): New method.
15029         (process_full_compunit, process_full_type_unit): Use
15030         dwarf2_cu::reset_builder.
15031         (follow_die_offset): Record the ancestor CU if it is different
15032         from the followed DIE's CU.
15033         (follow_die_sig_1): Likewise.
15034
15035 2019-01-15  Tom Tromey  <tom@tromey.com>
15036
15037         * remote.c (class remote_state) <buf>: Now a char_vector.
15038         <buf_size>: Remove.
15039         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15040         parameter.
15041         (remote_target::getpkt_or_notif_sane_1)
15042         (remote_target::getpkt_sane)
15043         (remote_target::getpkt_or_notif_sane): Likewise.
15044         (class remote_target) <putpkt>: New overload.
15045         (remote_target::read_frame): Change type of "buf_p".  Remove
15046         sizeof_p parameter.
15047         (packet_ok): New overload.
15048         (packet_check_result): New overload.
15049         Update all uses.
15050
15051 2019-01-14  Tom Tromey  <tom@tromey.com>
15052
15053         * remote-notif.c (handle_notification, remote_notif_ack)
15054         (remote_notif_parse): Make "buf" const.
15055         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15056         const.
15057         (remote_notif_parse, remote_notif_ack, handle_notification):
15058         Likewise.
15059         * remote.c (remote_notif_stop_parse): Make "buf" const.
15060         (remote_target::remote_parse_stop_reply): Make "buf" const.
15061         (remote_notif_stop_ack): Make "buf" const.
15062
15063 2019-01-14  Tom Tromey  <tom@tromey.com>
15064
15065         * remote.c (remote_console_output): Make parameter const.
15066
15067 2019-01-14  Tom Tromey  <tom@tromey.com>
15068
15069         * target-debug.h (target_debug_print_signals): Constify.
15070         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15071         * procfs.c (procfs_target::pass_signals): Update.
15072         * linux-nat.c (linux_nat_target::pass_signals): Update.
15073         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15074         * target-delegates.c: Rebuild.
15075         * remote.c (remote_target::program_signals): Update.
15076         (remote_target::pass_signals): Update.
15077         * target.c (target_pass_signals): Constify argument.
15078         (target_program_signals): Likewise.
15079         * target.h (struct target_ops) <pass_signals, program_signals>:
15080         Constify argument.
15081         (target_pass_signals, target_program_signals): Constify argument.
15082
15083 2019-01-14  Tom Tromey  <tom@tromey.com>
15084
15085         PR tui/28819:
15086         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15087
15088 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15089
15090         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15091         field.
15092         * rs6000-tdep.c: Include reggroups.h.
15093         (IS_V_ALIAS_PSEUDOREG): Define.
15094         (rs6000_register_name): Return names for the "vX" aliases.
15095         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15096         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15097         aliases.  Call default_register_reggroup_p for all other
15098         pseudo-registers.
15099         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15100         New functions.
15101         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15102         Handle "vX" aliases.
15103         (v_alias_pseudo_register_collect): New function.
15104         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15105         (rs6000_gdbarch_init): Initialize "vX" aliases as
15106         pseudo-registers.  Restore registration of
15107         rs6000_pseudo_register_reggroup_p with
15108         set_tdesc_pseudo_register_reggroup_p.
15109
15110 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15111
15112         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15113         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15114         set_gdbarch_num_pseudo_regs.
15115
15116 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15117
15118         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15119         Remove arg prefixname, add do_set and do_show.
15120         Add member functions set_list and show_list.
15121         * cli/cli-style.c (class cli_style_option): Update accordingly.
15122         (style_set_list): Move to file scope.
15123         (style_show_list): Likewise.
15124         (set_style): Call help_list.
15125         (show_style): Call cmd_show_list.
15126         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15127         Update to use the new macro.
15128
15129 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15130
15131         * ada-lang.c (_initialize_ada_language): Expand the help text
15132         for the "catch exception" command.
15133
15134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15135
15136         * symtab.c (matching_obj_sections): Initialize obj,
15137         declare it closer to its usage.
15138
15139 2019-01-10  Tom Tromey  <tom@tromey.com>
15140
15141         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15142         (basic_inf_threads_range): Remove.
15143         (inf_threads_range, inf_non_exited_threads_range)
15144         (safe_inf_threads_range): Use next_adapter.
15145
15146 2019-01-10  Keith Seitz  <keiths@redhat.com>
15147
15148         PR gdb/23712
15149         PR symtab/23010
15150         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15151         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15152
15153 2019-01-10  Keith Seitz  <keiths@redhat.com>
15154
15155         PR gdb/23712
15156         PR symtab/23010
15157         * dictionary.c (pending_to_vector): Remove.
15158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15159         Remove _1 suffix, replacing functions of the same name.  Update
15160         all callers.
15161         (dict_create_hashed, dict_create_hashed_expandable)
15162         (dict_create_linear, dict_create_linear_expandable, dict_free)
15163         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15164         Make functions static.
15165
15166 2019-01-10  Keith Seitz  <keiths@redhat.com>
15167
15168         PR gdb/23712
15169         PR symtab/23010
15170         * dictionary.h (struct dictionary): Replace declaration with
15171         multidictionary.
15172         (dict_create_hashed, dict_create_hashed_expandable)
15173         (dict_create_linear, dict_create_linear_expandable)
15174         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15175         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15176         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15177         taking multidictionary argument.
15178         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15179         * block.h (struct block) <dict>: Change to multidictionary
15180         and rename `multidict'.
15181         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15182         symmisc.c: Update all dictionary references to multidictionary.
15183
15184 2019-01-10  Keith Seitz  <keiths@redhat.com>
15185
15186         PR gdb/23712
15187         PR symtab/23010
15188         * dictionary.c: Include unordered_map.
15189         (pending_to_vector): New function.
15190         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15191         Rewrite the non-"_1" functions to take vector instead
15192         of linked list.
15193         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15194         "new" _1 versions of the same name.
15195         (multidictionary): Define.
15196         (std::hash<enum language): New definition.
15197         (collate_pending_symbols_by_language, mdict_create_hashed)
15198         (mdict_create_hashed_expandable, mdict_create_linear)
15199         (mdict_create_linear_expandable, mdict_free)
15200         (find_language_dictionary, create_new_language_dictionary)
15201         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15202         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15203         (mdict_size, mdict_empty): New functions.
15204         * dictionary.h (mdict_iterator): Define.
15205
15206 2019-01-10  Pedro Alves  <palves@redhat.com>
15207
15208         * breakpoint.c (read_uploaded_action)
15209         (create_tracepoint_from_upload): Adjust to use
15210         gdb::unique_xmalloc_ptr.
15211         * ctf.c (ctf_write_uploaded_tp):
15212         (SET_ARRAY_FIELD): Use emplace_back.
15213         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15214         * tracefile-tfile.c (tfile_write_uploaded_tp):
15215         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15216         gdb::unique_xmalloc_ptr.
15217         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15218         at_string, cond_string, cmd_strings>: Replace char pointers
15219         with gdb::unique_xmalloc_ptr.
15220
15221 2019-01-10  Pedro Alves  <palves@redhat.com>
15222
15223         * solib-target.c (library_list_start_library): Don't xstrdup name.
15224
15225 2019-01-10  Pedro Alves  <palves@redhat.com>
15226
15227         * mdebugread.c (parse_partial_symbols): Use
15228         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15229
15230 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15231
15232         * linux-fork.c (scoped_switch_fork_info)
15233         <~scoped_switch_fork_info>: Fix incorrect variable name.
15234
15235 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15236
15237         * linux-fork.c (scoped_switch_fork_info)
15238         <scoped_switch_fork_info>: Make explicit.
15239         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15240
15241 2019-01-10  Tom Tromey  <tom@tromey.com>
15242
15243         * objfiles.h (objfile::reset_psymtabs): Update.
15244         * objfiles.c (objfile::objfile): Update.
15245         * psymtab.h (psymtab_storage::obstack): Update.
15246         (psymtab_storage::m_obstack): Use gdb::optional.
15247         (class psymtab_storage): Update comment.  Remove objfile
15248         parameter.
15249         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15250
15251 2019-01-10  Tom Tromey  <tom@tromey.com>
15252
15253         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15254         <free_psymtabs>: Now private.
15255         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15256         (allocate_psymtab): Use new method.
15257
15258 2019-01-10  Tom Tromey  <tom@tromey.com>
15259
15260         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15261         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15262         * mdebugread.c (parse_partial_symbols): Use
15263         allocate_dependencies.
15264         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15265         allocate_dependencies.
15266         (process_psymtab_comp_unit_reader)
15267         (build_type_psymtab_dependencies): Likewise.
15268         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15269
15270 2019-01-10  Tom Tromey  <tom@tromey.com>
15271
15272         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15273         PSYMBOL_SET_LANGUAGE.
15274         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15275
15276 2019-01-10  Tom Tromey  <tom@tromey.com>
15277
15278         * psymtab.h (psymtab_storage::obstack): New method.
15279         <m_obstack>: Rename from obstack; now private.
15280         * psymtab.c (psymtab_storage): Update.
15281         * dwarf2read.c (create_addrmap_from_index)
15282         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15283         Update.
15284
15285 2019-01-10  Tom Tromey  <tom@tromey.com>
15286
15287         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15288         * objfiles.h (objfile::reset_psymtabs): New method.
15289
15290 2019-01-10  Tom Tromey  <tom@tromey.com>
15291
15292         * symmisc.c (print_symbol_bcache_statistics): Update.
15293         (print_objfile_statistics): Update.
15294         * symfile.c (reread_symbols): Update.
15295         * psymtab.h (class psymtab_storage): New.
15296         * psymtab.c (psymtab_storage): New constructor.
15297         (~psymtab_storage): New destructor.
15298         (require_partial_symbols): Update.
15299         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15300         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15301         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15302         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15303         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15304         (start_psymtab_common, end_psymtab_common)
15305         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15306         (allocate_psymtab): Update.
15307         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15308         Update.
15309         (dump_psymtab_addrmap, maintenance_print_psymbols)
15310         (maintenance_check_psymtabs): Update.
15311         (class objfile_psymtabs): Move to objfiles.h.
15312         * psympriv.h (discard_psymtab): Now inline.
15313         (psymtab_discarder::psymtab_discarder): Update.
15314         (psymtab_discarder::~psymtab_discarder): Update.
15315         (ALL_OBJFILE_PSYMTABS): Rewrite.
15316         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15317         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15318         Remove fields.
15319         <partial_symtabs>: New field.
15320         (class objfile_psymtabs): Move from psymtab.h.  Update.
15321         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15322         psymbol_cache.
15323         (objfile::~objfile): Don't destroy psymbol_cache.
15324         * mdebugread.c (parse_partial_symbols): Update.
15325         * dwarf2read.c (create_addrmap_from_index)
15326         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15327         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15328         (add_partial_subprogram, dwarf2_ranges_read): Update.
15329         * dwarf-index-write.c (write_address_map)
15330         (write_one_signatured_type, recursively_write_psymbols)
15331         (class debug_names, class debug_names, write_psymtabs_to_index):
15332         Update.
15333
15334 2019-01-10  Tom Tromey  <tom@tromey.com>
15335
15336         * symtab.h (SYMBOL_SET_NAMES): Update.
15337         (symbol_set_names): Update.
15338         (MSYMBOL_SET_NAMES): Update.
15339         * symtab.c (symbol_set_names): Change argument to be an
15340         objfile_per_bfd_storage.
15341         * psymtab.c (add_psymbol_to_bcache): Update.
15342         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15343
15344 2019-01-10  Tom Tromey  <tom@tromey.com>
15345
15346         * symtab.c (create_demangled_names_hash): Change argument to be an
15347         objfile_per_bfd_storage.
15348         (symbol_set_names): Update.
15349
15350 2019-01-10  Tom Tromey  <tom@tromey.com>
15351
15352         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15353         init_psymbol_list.
15354         * psymtab.c (init_psymbol_list): Do nothing if already called.
15355         * psympriv.h (init_psymbol_list): Add comment.
15356         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15357         init_psymbol_list.
15358         * dbxread.c (dbx_symfile_read): Unconditionally call
15359         init_psymbol_list.
15360
15361 2019-01-10  Tom Tromey  <tom@tromey.com>
15362
15363         * xcoffread.c (scan_xcoff_symtab): Update.
15364         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15365         "where".
15366         * mdebugread.c (parse_partial_symbols)
15367         (handle_psymbol_enumerators): Update.
15368         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15369         * dbxread.c (read_dbx_symtab): Update.
15370         * psympriv.h (psymbol_placement): New enum.
15371         (add_psymbol_to_list): Update.
15372
15373 2019-01-10  Tom Tromey  <tom@tromey.com>
15374
15375         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15376         static_psymbols parameters.
15377         (scan_xcoff_symtab): Update.
15378         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15379         static_psymbols parameters.
15380         * psympriv.h (start_psymtab_common): Update.
15381         * mdebugread.c (parse_partial_symbols): Update.
15382         * dwarf2read.c (create_partial_symtab): Update.
15383         * dbxread.c (read_dbx_symtab): Update.
15384         (start_psymtab): Remove global_psymbols and static_psymbols
15385         parameters.
15386
15387 2019-01-10  Tom Tromey  <tom@tromey.com>
15388
15389         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15390         * psymtab.c (allocate_psymtab): Add comment.
15391         * psympriv.h (allocate_psymtab): Add comment.
15392         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15393         initializations.
15394         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15395
15396 2019-01-10  Tom Tromey  <tom@tromey.com>
15397
15398         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15399         Don't declare.
15400         * mipsread.c: Include mdebugread.h.
15401         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15402         Declare.
15403         * elfread.c: Include mdebugread.h.
15404
15405 2019-01-09  Tom Tromey  <tom@tromey.com>
15406
15407         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15408         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15409         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15410         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15411         (psym_lookup_symbol, psym_find_last_source_symtab)
15412         (psym_forget_cached_source_info, psym_print_stats)
15413         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15414         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15415         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15416         (psym_find_compunit_symtab_by_address)
15417         (maintenance_print_psymbols, maintenance_info_psymtabs)
15418         (maintenance_check_psymtabs): Use ranged for.
15419         * psymtab.h (class objfile_psymtabs): New.
15420         (require_partial_symbols): Return objfile_psymtabs.
15421         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15422
15423 2019-01-09  Tom Tromey  <tom@tromey.com>
15424
15425         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15426         (find_pc_mapped_section, list_overlays_command)
15427         (map_overlay_command, unmap_overlay_command)
15428         (simple_overlay_update): Use all_objfiles.
15429         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15430         * printcmd.c (info_symbol_command): Use all_objfiles.
15431         * objfiles.h (ALL_OBJSECTIONS): Remove.
15432         * maint.c (maintenance_translate_address): Use all_objfiles.
15433         * gcore.c (gcore_create_callback): Use all_objfiles.
15434         (objfile_find_memory_regions): Likewise.
15435
15436 2019-01-09  Tom Tromey  <tom@tromey.com>
15437
15438         * symtab.c (find_line_symtab, info_sources_command)
15439         (make_source_files_completion_list): Use objfile_compunits.
15440         * source.c (select_source_symtab): Use objfile_compunits.
15441         * objfiles.h (struct objfile): Update comment.
15442         (ALL_OBJFILES): Remove.
15443         (ALL_FILETABS): Remove.
15444         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15445         objfile_compunits.
15446
15447 2019-01-09  Tom Tromey  <tom@tromey.com>
15448
15449         * symmisc.c (print_objfile_statistics, dump_objfile)
15450         (maintenance_print_symbols): Use compunit_filetabs.
15451         * source.c (forget_cached_source_info_for_objfile): Use
15452         compunit_filetabs.
15453         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15454         (ALL_FILETABS): Use compunit_filetabs.
15455         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15456         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15457
15458 2019-01-09  Tom Tromey  <tom@tromey.com>
15459
15460         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15461         (compunit_filetabs): New.
15462         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15463         compunit_filetabs.
15464         (info_sources_command, make_source_files_completion_list): Remove
15465         declaration.
15466         * symmisc.c (print_objfile_statistics, dump_objfile)
15467         (maintenance_print_symbols): Remove declaration.
15468         (maintenance_info_symtabs): Use compunit_filetabs.
15469         (maintenance_info_line_tables): Likewise.
15470         * source.c (select_source_symtab): Change local variable name.
15471         (forget_cached_source_info_for_objfile): Remove declaration.
15472         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15473         * objfiles.c (objfile_relocate1): Remove declaration.
15474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15475         declaration.
15476         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15477         * coffread.c (coff_symtab_read): Remove declaration.
15478         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15479         compunit_filetabs.
15480
15481 2019-01-09  Tom Tromey  <tom@tromey.com>
15482
15483         * symtab.c (lookup_objfile_from_block)
15484         (find_pc_sect_compunit_symtab, search_symbols)
15485         (default_collect_symbol_completion_matches_break_on): Use
15486         objfile_compunits.
15487         * objfiles.h (ALL_COMPUNITS): Remove.
15488         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15489         * cp-support.c (add_symbol_overload_list_qualified): Use
15490         objfile_compunits.
15491         * ada-lang.c (ada_collect_symbol_completion_matches)
15492         (ada_add_global_exceptions): Use objfile_compunits.
15493
15494 2019-01-09  Tom Tromey  <tom@tromey.com>
15495
15496         * source.c (select_source_symtab)
15497         (forget_cached_source_info_for_objfile): Remove declaration.
15498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15499         declaration.
15500         * maint.c (count_symtabs_and_blocks): Remove declaration.
15501         * cp-support.c (add_symbol_overload_list_qualified): Remove
15502         declaration.
15503         * coffread.c (coff_symtab_read): Remove declaration.
15504         * symtab.c (lookup_symbol_in_objfile_symtabs)
15505         (basic_lookup_transparent_type_1): Use objfile_compunits.
15506         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15507         (info_sources_command, search_symbols)
15508         (default_collect_symbol_completion_matches_break_on)
15509         (make_source_files_completion_list): Remove declaration.
15510         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15511         (ada_collect_symbol_completion_matches)
15512         (ada_add_global_exceptions): Remove declaration.
15513         * linespec.c (iterate_over_all_matching_symtabs): Use
15514         objfile_compunits.
15515         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15516         (class objfile_compunits): New.
15517         (ALL_COMPUNITS): Use objfile_compunits.
15518         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15519         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15520         objfile_compunits.
15521         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15522
15523 2019-01-09  Tom Tromey  <tom@tromey.com>
15524
15525         * symtab.c (search_symbols)
15526         (default_collect_symbol_completion_matches_break_on): Use
15527         objfile_msymbols.
15528         * ada-lang.c (ada_lookup_simple_minsym)
15529         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15530         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15531         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15532         objfile_msymbols.
15533         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15534         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15535         * objc-lang.c (find_methods): Use objfile_msymbols.
15536         (info_selectors_command, info_classes_command): Likewise.
15537         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15538         * objfiles.h (class objfile_msymbols): New.
15539         (ALL_OBJFILE_MSYMBOLS): Remove.
15540         (ALL_MSYMBOLS): Remove.
15541
15542 2019-01-09  Tom Tromey  <tom@tromey.com>
15543
15544         * common/next-iterator.h (next_adapter): Add Iterator template
15545         parameter.
15546         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15547         (class all_objfiles_safe): New.
15548         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15549         * objfiles.c (put_objfile_before): Update comment.
15550         (add_separate_debug_objfile): Likewise.
15551         (free_all_objfiles): Use all_objfiles_safe.
15552         (objfile_purge_solibs): Likewise.
15553
15554 2019-01-09  Tom Tromey  <tom@tromey.com>
15555
15556         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15557         (expand_symtab_containing_pc, lookup_static_symbol)
15558         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15559         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15560         all_objfiles.
15561         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15562         * breakpoint.c (create_overlay_event_breakpoint)
15563         (create_longjmp_master_breakpoint)
15564         (create_std_terminate_master_breakpoint)
15565         (create_exception_master_breakpoint): Use all_objfiles.
15566         * linux-thread-db.c (try_thread_db_load_from_pdir)
15567         (has_libpthread): Use all_objfiles.
15568         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15569         * linespec.c (iterate_over_all_matching_symtabs)
15570         (search_minsyms_for_name): Use all_objfiles.
15571         * maint.c (maintenance_info_sections): Use all_objfiles.
15572         * main.c (captured_main_1): Use all_objfiles.
15573         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15574         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15575         * guile/scm-pretty-print.c
15576         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15577         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15578         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15579         (maintenance_print_msymbols): Use all_objfiles.
15580         * source.c (select_source_symtab): Use all_objfiles.
15581         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15582         * symfile.c (remove_symbol_file_command)
15583         (expand_symtabs_matching, map_symbol_filenames): Use
15584         all_objfiles.
15585         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15586         all_objfiles.
15587         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15588         * objc-lang.c (find_methods): Use all_objfiles.
15589         * objfiles.c (have_partial_symbols, have_full_symbols)
15590         (have_minimal_symbols, qsort_cmp)
15591         (default_iterate_over_objfiles_in_search_order): Use
15592         all_objfiles.
15593         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15594         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15595         (maintenance_check_psymtabs): Use all_objfiles.
15596         (ALL_PSYMTABS): Remove.
15597         * compile/compile-object-run.c (do_module_cleanup): Use
15598         all_objfiles.
15599         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15600         * cp-support.c (add_symbol_overload_list_qualified): Use
15601         all_objfiles.
15602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15603         Use all_objfiles.
15604         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15605         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15606         all_objfiles.
15607         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15608         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15609         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15610         Uses all_objfiles.
15611         * solib.c (solib_read_symbols): Use all_objfiles
15612
15613 2019-01-09  Tom Tromey  <tom@tromey.com>
15614
15615         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15616         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15617         all_objfiles.
15618         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15619         * symmisc.c (print_symbol_bcache_statistics)
15620         (print_objfile_statistics, maintenance_print_objfiles)
15621         (maintenance_info_symtabs, maintenance_check_symtabs)
15622         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15623         all_objfiles.
15624         * source.c (forget_cached_source_info): Use all_objfiles.
15625         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15626         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15627         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15628         * objfiles.c (update_section_map): Use all_objfiles.
15629         (shared_objfile_contains_address_p): Likewise.
15630         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15631         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15632
15633 2019-01-09  Tom Tromey  <tom@tromey.com>
15634
15635         * common/next-iterator.h: New file.
15636         * objfiles.h (class all_objfiles): New.
15637         (struct objfile_iterator): New.
15638
15639 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15640
15641         * NEWS: Move the description of the changed "frame", "select-frame",
15642          and "info frame" commands to the Changed commands section.
15643
15644 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15645
15646         * gdbtypes.c (check_stub_method_group): Remove handling of old
15647         mangling schemes.
15648         * linespec.c (find_methods): Likewise.
15649         * stabsread.c (read_member_functions): Likewise.
15650         * valops.c (search_struct_method): Likewise.
15651         (value_struct_elt_for_reference): Likewise.
15652         * NEWS: Mention this change.
15653
15654 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15655
15656         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15657         print_source_lines.
15658         * source.c (print_source_lines_base): Update line number check.
15659         (print_source_lines): New function.
15660         (source_lines_range::source_lines_range): New function.
15661         * source.h (class source_lines_range): New class.
15662         (print_source_lines): New declaration.
15663
15664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15665
15666         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15667
15668 2019-01-08  Tom Tromey  <tom@tromey.com>
15669             Simon Marchi  <simon.marchi@ericsson.com>
15670
15671         PR gdb/24060
15672         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15673         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15674         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15675         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15676         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15677         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15678
15679 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15680
15681         * source.c (select_source_symtab): Move header comment to
15682         declaration in source.h.
15683         (forget_cached_source_info_for_objfile): Likewise.
15684         (forget_cached_source_info): Likewise.
15685         (identify_source_line): Likewise.
15686         * source.h (identify_source_line): Move declaration from symtab.h
15687         and add comment from source.c
15688         (print_source_lines): Likewise.
15689         (forget_cached_source_info_for_objfile): Likewise.
15690         (forget_cached_source_info): Likewise.
15691         (select_source_symtab): Likewise.
15692         (enum print_source_lines_flag): Move definition from symtab.h.
15693         * symtab.h (identify_source_line): Move declaration to source.h.
15694         (print_source_lines): Likewise.
15695         (forget_cached_source_info_for_objfile): Likewise.
15696         (forget_cached_source_info): Likewise.
15697         (select_source_symtab): Likewise.
15698         (enum print_source_lines_flag): Move definition to source.h.
15699         * tui/tui-hooks.c: Add 'source.h' include.
15700
15701 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15702
15703         * source.c (print_source_lines_base): Handle requests to print
15704         reverse line number sequences, and guard against empty lines
15705         string.
15706
15707 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15708
15709         * source.c (print_source_lines_base): Fix skip of '\r' if next
15710         character is '\n'.
15711
15712 2019-01-06  Tom Tromey  <tom@tromey.com>
15713
15714         * c-exp.y (struct c_parse_state) <macro_original_text,
15715         expansion_obstack>: New member.
15716         (macro_original_text, expansion_obstack): Remove globals.
15717         (scan_macro_expansion, scanning_macro_expansion)
15718         (finished_macro_expansion): Update.
15719         (scan_macro_cleanup): Remove.
15720         (yylex, c_parse): Update.
15721
15722 2019-01-06  Tom Tromey  <tom@tromey.com>
15723
15724         * c-exp.y (struct c_parse_state) <strings>: New member.
15725         (operator_stoken): Update.
15726
15727 2019-01-06  Tom Tromey  <tom@tromey.com>
15728
15729         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15730         (union type_stack_elt) <typelist_val>: Now a pointer to
15731         std::vector.
15732         (type_stack_cleanup): Don't declare.
15733         (push_typelist): Update.
15734         * parse.c (pop_typelist): Return a std::vector.
15735         (push_typelist): Take a std::vector.
15736         (follow_types): Update.  Do not free args.
15737         (type_stack_cleanup): Remove.
15738         * c-exp.y (struct c_parse_state): New.
15739         (cpstate): New global.
15740         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15741         (nonempty_typelist): Update.
15742         (func_mod): Create a new vector.
15743         (c_parse): Create a c_parse_state.
15744         (check_parameter_typelist): Do not delete params.
15745         (function_method): Update.  Do not delete type_list.
15746
15747 2019-01-06  Tom Tromey  <tom@tromey.com>
15748
15749         PR gdb/28155:
15750         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15751         check_typedef.
15752         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15753         (print_return_value): Likewise.
15754
15755 2019-01-05  Tom Tromey  <tom@tromey.com>
15756
15757         * contrib/cleanup_check.py: Remove.
15758         * contrib/gcc-with-excheck: Remove.
15759         * contrib/exsummary.py: Remove.
15760         * contrib/excheck.py: Remove.
15761
15762 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15763
15764         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15765         NULL. Initialize tpprev to NULL instead of assigning it
15766         to NULL on the next statement.
15767         * windows-nat.c (windows_delete_thread): Remove check for
15768         main_thread_id before printing thread exit notifications.
15769         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15770         Remove thread ID check against main_thread_id.
15771         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15772         windows_delete_thread.
15773         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15774
15775 2019-01-04  Tom Tromey  <tom@tromey.com>
15776
15777         * compile/compile.c (_initialize_compile): Use upper case for
15778         metasyntactic variables.
15779         * symmisc.c (_initialize_symmisc): Use upper case for
15780         metasyntactic variables.
15781         * psymtab.c (_initialize_psymtab): Use upper case for
15782         metasyntactic variables.
15783         * demangle.c (demangle_command): Use upper case for metasyntactic
15784         variables.
15785         (_initialize_demangler): Likewise.
15786         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15787         variables.
15788
15789 2019-01-03  Tom Tromey  <tom@tromey.com>
15790
15791         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15792
15793 2019-01-03  Tom Tromey  <tom@tromey.com>
15794
15795         * python/py-symtab.c (salpy_str): Update.
15796         (struct salpy_sal_object) <symtab>: Now a PyObject.
15797         (salpy_dealloc): Update.
15798         (del_objfile_sal): Use gdbpy_ref.
15799
15800 2019-01-03  Tom Tromey  <tom@tromey.com>
15801
15802         * python/py-type.c (convert_field): Use new_reference.  Return
15803         gdbpy_ref.
15804         (make_fielditem): Return gdbpy_ref.
15805         (typy_fields): Update.
15806         (typy_getitem): Update.
15807         (field_name): Return gdbpy_ref.  Use new_reference.
15808         (typy_iterator_iternext): Update.
15809
15810 2019-01-03  Tom Tromey  <tom@tromey.com>
15811
15812         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15813
15814 2019-01-03  Tom Tromey  <tom@tromey.com>
15815
15816         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15817         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15818         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15819         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15820         (pspy_set_type_printers): Likewise.
15821         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15822         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15823         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15824         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15825         (objfpy_set_type_printers): Likewise.
15826
15827 2019-01-03  Tom Tromey  <tom@tromey.com>
15828
15829         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15830         (gdbpy_print_stack): Use gdbpy_err_fetch.
15831         * python/python-internal.h (class gdbpy_err_fetch): New class.
15832         (class gdbpy_enter) <m_error_type, m_error_value,
15833         m_error_traceback>: Remove.
15834         <m_error>: New member.
15835         (gdbpy_exception_to_string): Don't declare.
15836         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15837         * python/py-value.c (convert_value_from_python): Use
15838         gdbpy_err_fetch.
15839         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15840         gdbpy_exception_to_string.
15841         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15842         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15843         gdbpy_err_fetch.
15844
15845 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15846
15847         * linux-nat.c (delete_lwp_cleanup): Delete.
15848         (struct lwp_deleter): New struct.
15849         (lwp_info_up): New typedef.
15850         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15851         lwp_info_up.
15852
15853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15854
15855         * linux-fork.c (class scoped_switch_fork_info): New class.
15856         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15857
15858 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15859
15860         * valops.c (find_overload_match): Remove use of null_cleanup, and
15861         calls to do_cleanups.
15862
15863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15864
15865         * compile/compile-cplus-types.c
15866         (compile_cplus_instance::decl_name): Handle changes to
15867         cp_func_name.
15868         * cp-support.c (cp_func_name): Update header comment, update
15869         return type.
15870         * cp-support.h (cp_func_name): Update return type in declaration.
15871         * valops.c (find_overload_match): Move temp_func local to top
15872         level of function and change its type.  Use temp_func to hold and
15873         delete temporary string obtained from cp_func_name.
15874
15875 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15876
15877         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15878         gdb::char_vector, remove cleanup, and update uses of `msg`.
15879
15880 2019-01-03  Jim Wilson  <jimw@sifive.com>
15881
15882         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15883
15884 2019-01-02  Tom Tromey  <tom@tromey.com>
15885
15886         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15887         (tdesc_parse_xml): Remove cleanups.
15888         * target-descriptions.h (make_cleanup_free_target_description):
15889         Don't declare.
15890         (target_desc_deleter): New struct.
15891         (target_desc_up): New typedef.
15892         * target-descriptions.c (target_desc_deleter::operator()): Rename
15893         from free_target_description.
15894         (make_cleanup_free_target_description): Remove.
15895
15896 2019-01-02  Tom Tromey  <tom@tromey.com>
15897
15898         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15899         constructor, destructor.
15900         (linespec_parser): Remove typedef.
15901         (~linespec_parser): Rename from linespec_parser_delete.
15902         (linespec_lex_to_end, linespec_complete_label)
15903         (linespec_complete): Update.
15904         (decode_line_full): Remove cleanups.
15905         (decode_line_1): Update.
15906
15907 2019-01-02  Tom Tromey  <tom@tromey.com>
15908
15909         * python/python-internal.h (inferior_to_inferior_object): Change
15910         return type.
15911         * python/py-exitedevent.c (create_exited_event_object): Update.
15912         * python/py-inferior.c (inferior_to_inferior_object): Return
15913         gdbpy_ref.
15914         (python_new_inferior, python_inferior_deleted)
15915         (thread_to_thread_object, delete_thread_object)
15916         (build_inferior_list, gdbpy_selected_inferior): Update.
15917         * python/py-infthread.c (create_thread_object): Update.  Also fail
15918         if inferior_to_inferior_object fails.
15919
15920 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15921
15922         * inferior.h (class inferior) <displaced_step_state>: New field.
15923         * infrun.h (struct displaced_step_state): Move here from
15924         infrun.c.  Initialize fields, add constructor.
15925         <inf>: Remove field.
15926         <reset>: New method.
15927         * infrun.c (struct displaced_step_inferior_state): Move to
15928         infrun.h.
15929         (displaced_step_inferior_states): Remove.
15930         (get_displaced_stepping_state): Adust.
15931         (displaced_step_in_progress_any_inferior): Adjust.
15932         (displaced_step_in_progress_thread): Adjust.
15933         (displaced_step_in_progress): Adjust.
15934         (add_displaced_stepping_state): Remove.
15935         (get_displaced_step_closure_by_addr): Adjust.
15936         (remove_displaced_stepping_state): Remove.
15937         (infrun_inferior_exit): Call displaced_step_state.reset.
15938         (use_displaced_stepping): Don't check for NULL.
15939         (displaced_step_prepare_throw): Call
15940         get_displaced_stepping_state.
15941         (displaced_step_fixup): Don't check for NULL.
15942         (prepare_for_detach): Don't check for NULL.
15943
15944 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15945
15946         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15947          in case of call that did not complete.
15948
15949 2019-01-02  Andrey Utkin  <autkin@undo.io>
15950
15951         * symfile.c (find_separate_debug_file): Fix search of debug files for
15952         remote debuggee.
15953
15954 2019-01-02  Tom Tromey  <tom@tromey.com>
15955
15956         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15957         indentation.
15958         * python/py-frame.c (frapy_older): Remove cast.
15959         (frapy_newer): Likewise.
15960         * python/py-breakpoint.c (local_setattro): Remove cast.
15961         * python/py-arch.c (archpy_name): Remove local variable.
15962         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15963
15964 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15965
15966         * unittests/basic_string_view/element_access/char/empty.cc:
15967         Fix year range in copyright header.
15968
15969 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15970
15971         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15972         Delete.
15973         <operator==>: Update with for removed field.
15974         <hash>: Likewise.
15975         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15976         <isa_features>: ...this.
15977         <abi_features>: New field.
15978         (riscv_isa_flen): Update comment.
15979         (riscv_abi_xlen): New declaration.
15980         (riscv_abi_flen): New declaration.
15981         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15982         isa_features.
15983         (riscv_abi_xlen): New function.
15984         (riscv_isa_flen): Update to get answer from isa_features.
15985         (riscv_abi_flen): New function.
15986         (riscv_has_fp_abi): Update to get answer from abi_features.
15987         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15988         xlen and flen.
15989         (riscv_call_info) <xlen, flen>: Update comment.
15990         (riscv_call_arg_struct): Remove invalid assertions
15991         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15992         is removed.
15993         (riscv_gdbarch_init): Gather isa features and abi features
15994         separately, ensure both match on the gdbarch when reusing an old
15995         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15996         a target with 64-bit float hardware.
15997
15998 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15999
16000         * source.c (search_command_helper): Stop reverse search
16001         when line 1 has been searched.
16002
16003 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16004
16005         * record-full.c (record_full_base_target::close): Rewrite
16006         record_full_core_buf_list free logic.
16007
16008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16009
16010         * break-catch-syscall.c (print_one_catch_syscall): xfree
16011         the last text.
16012
16013 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16014
16015         * top.c (print_gdb_version): Update Copyright year in version
16016         message.
16017
16018 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16019
16020         Update copyright year range in all GDB files.
16021
16022 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16023
16024         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16025
16026 For older changes see ChangeLog-2018.
16027 \f
16028 Local Variables:
16029 mode: change-log
16030 left-margin: 8
16031 fill-column: 74
16032 version-control: never
16033 coding: utf-8
16034 End:
16035