gdb/ChangeLog

   1 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
   4         2 to pow ().
   5
   6 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
   9         log10 to double to fix Solaris 11 with gcc 5.5.
  10
  11 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  12
  13         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
  14         "sun" to "saddr_un".
  15
  16 2019-12-19  Tom Tromey  <tromey@adacore.com>
  17
  18         * ui-out.h (enum class field_kind): Fix comment.
  19
  20 2019-12-11  Tom Tromey  <tromey@adacore.com>
  21
  22         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  23
  24 2019-12-18  Tom Tromey  <tromey@adacore.com>
  25
  26         PR build/25268:
  27         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  28         type on macOS.  Add comment.
  29
  30 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  31
  32         * c-lang.c (c_get_string, asm_language_defn): Remove space
  33         before tab.
  34
  35 2019-12-18  Tom Tromey  <tromey@adacore.com>
  36
  37         PR build/25250:
  38         * ui-out.c (ui_out::vmessage): Update.
  39         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  40         Rename.
  41         (string_field): Update.
  42         (signed_field): Update.
  43
  44 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  45
  46         * top.c (print_gdb_configuration): Adjust indentation.
  47
  48 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  49
  50         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  51
  52 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  53
  54         * tui/tui-layout.h (class tui_layout_base): Add virtual
  55         destructor.
  56
  57 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  58
  59         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  60         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  61         (process_event_stop_test): Keep stepping over skipped inline functions.
  62
  63 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  64
  65         * jit.c (struct gdb_block) <next>: Remove field.
  66         (struct gdb_symtab) <~gdb_symtab>: Remove.
  67         <blocks>: Change type to std::forward_list<gdb_block>.
  68         (compare_block): Remove.
  69         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  70         block at the beginning, don't mind about sorting.
  71         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  72         before using it.
  73
  74 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  75
  76         * jit.c (struct gdb_block): Add constructor, initialize
  77         real_block and next fields.
  78         <name>: Change type to gdb::unique_xmalloc_ptr.
  79         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  80         (jit_block_open_impl): Allocate gdb_block with new.
  81         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  82
  83 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  84
  85         * jit.c: Include forward_list.
  86         (struct gdb_symtab) <next>: Remove field.
  87         (struct gdb_object) <symtabs>: Change type to
  88         std::forward_list<gdb_symtab>.
  89         (jit_object_open_impl): Allocate gdb_object with new.
  90         (jit_symtab_open_impl): Adjust to std::forward_list.
  91         (finalize_symtab): Don't delete symtab.
  92         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  93         gdb_object with delete.
  94
  95 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  96
  97         * jit.c (struct gdb_symtab): Add constructor, destructor,
  98         initialize fields.
  99         <linetable>: Change type to unique_xmalloc_ptr.
 100         <file_name>: Change type to std::string.
 101         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 102         (jit_symtab_line_mapping_add_impl): Adjust.
 103         (finalize_symtab): Adjust, call delete on stab.
 104
 105 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 106
 107         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 108
 109 2019-12-16  Tom Tromey  <tromey@adacore.com>
 110
 111         * windows-nat.c (windows_nat_target::attach): Update.
 112         * remote.c (extended_remote_target::attach): Update.
 113         * procfs.c (procfs_target::attach): Update.
 114         * nto-procfs.c (nto_procfs_target::attach): Update.
 115         (nto_procfs_target::create_inferior): Update.
 116         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 117         * gnu-nat.c (gnu_nat_target::attach): Update.
 118         (gnu_nat_target::detach): Update.
 119         * darwin-nat.c (darwin_nat_target::attach): Update.
 120         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 121         return.
 122         * bsd-kvm.c (bsd_kvm_target_open): Update.
 123         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 124
 125 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 126
 127         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 128         (we no longer need to include time.h before pathmax.h)
 129
 130 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 131
 132         * ada-exp.y (write_ambiguous_var): Update.
 133         * coffread.c (process_coff_symbol): Update.
 134         * ctfread.c (ctf_add_enum_member_cb): Update.
 135         (new_symbol): Update.
 136         * dwarf2read.c (fixup_go_packaging): Update.
 137         (new_symbol): Update.
 138         * language.c (language_alloc_type_symbol): Update.
 139         * mdebugread.c (new_symbol): Update.
 140         * minsyms.c (minimal_symbol_reader::record_full): Update.
 141         * psymtab.c (add_psymbol_to_bcache): Update.
 142         * stabsread.c (define_symbol): Update.
 143         (read_enum_type): Update.
 144         * symtab.c (symbol_set_language): Make this a member function...
 145         (general_symbol_info::set_language): ... here.
 146         * symtab.h (struct general_symbol_info) <set_language>: New function.
 147         (SYMBOL_SET_LANGUAGE): Remove.
 148         (symbol_set_language): Remove.
 149
 150 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * ada-lang.c (ada_add_block_symbols): Update.
 153         (ada_collect_symbol_completion_matches): Update.
 154         * ax-gdb.c (gen_expr): Update.
 155         * block.c (block_lookup_symbol): Update.
 156         (block_lookup_symbol_primary): Update.
 157         (block_find_symbol): Update.
 158         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 159         * dbxread.c (process_one_symbol): Update.
 160         * dictionary.c (insert_symbol_hashed): Update.
 161         (collate_pending_symbols_by_language): Update.
 162         (mdict_add_symbol): Update.
 163         * dwarf-index-write.c (write_psymbols): Update.
 164         * dwarf2read.c (fixup_go_packaging): Update.
 165         * findvar.c (read_var_value): Update.
 166         * ft32-tdep.c (ft32_skip_prologue): Update.
 167         * go-lang.c (go_symbol_package_name): Update.
 168         * language.h (scoped_switch_to_sym_language_if_auto::
 169         scoped_switch_to_sym_language_if_auto): Update.
 170         * linespec.c (find_method): Update.
 171         (find_label_symbols_in_block): Update.
 172         * mdebugread.c (parse_symbol): Update.
 173         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 174         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 175         (minimal_symbol_reader::install): Update.
 176         * moxie-tdep.c (moxie_skip_prologue): Update.
 177         * parse.c (parse_exp_in_context): Update.
 178         * psymtab.c (psymbol_name_matches): Update.
 179         (match_partial_symbol): Update.
 180         (lookup_partial_symbol): Update.
 181         (psymbol_hash): Update.
 182         (psymbol_compare): Update.
 183         * python/py-framefilter.c (extract_sym): Update.
 184         (py_print_single_arg): Update.
 185         * stabsread.c (define_symbol): Update.
 186         * stack.c (print_frame_arg): Update.
 187         (find_frame_funname): Update.
 188         (info_frame_command_core): Update.
 189         * symfile.c (set_initial_language): Update.
 190         * symtab.c (symbol_set_demangled_name): Update.
 191         (symbol_get_demangled_name): Update.
 192         (symbol_set_language): Update.
 193         (symbol_find_demangled_name): Update.
 194         (symbol_set_names): Update.
 195         (general_symbol_info::natural_name): Update.
 196         (general_symbol_info::demangled_name): Update.
 197         (general_symbol_info::search_name): Update.
 198         (symbol_matches_search_name): Update.
 199         (eq_symbol_entry): Update.
 200         (iterate_over_symbols): Update.
 201         (completion_list_add_symbol): Update.
 202         (completion_list_add_msymbol): Update.
 203         (completion_list_add_fields): Update.
 204         * symtab.h (struct general_symbol_info) <language>: New function.
 205         <language>: Rename to...
 206         <m_language>: ...this.
 207         (SYMBOL_LANGUAGE): Remove.
 208         (MSYMBOL_LANGUAGE): Remove.
 209         (struct symbol) <ctor>: Update.
 210         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 211
 212 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 215         set the language of sym.
 216         * language.c (language_alloc_type_symbol): Likewise.
 217
 218 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 219
 220         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 221         PR gdb/23613
 222         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 223         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 224         (core_target_open): Use 'gdb_abspath'.
 225         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 226         'current_directory == NULL' case.
 227         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 228         explain what happens when 'current_directory' is NULL.
 229         * go32-nat.c (go32_nat_target::wait): Check if
 230         'current_directory' is NULL before call to 'chdir'.
 231         * source.c (add_path): Use 'gdb_abspath'.
 232         * top.c: Include 'gdbsupport/pathstuff.h'.
 233         (init_history): Use 'gdb_abspath'.
 234         (set_history_filename): Likewise.
 235         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 236         (tfile_target_open): Use 'gdb_abspath'.
 237
 238 2019-12-13  Tom Tromey  <tromey@adacore.com>
 239
 240         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 241         warning or error.
 242
 243 2019-12-13  Tom Tromey  <tromey@adacore.com>
 244
 245         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 246
 247 2019-12-13  Tom Tromey  <tromey@adacore.com>
 248
 249         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 250
 251 2019-12-13  Tom Tromey  <tromey@adacore.com>
 252
 253         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 254
 255 2019-12-13  Tom Tromey  <tromey@adacore.com>
 256
 257         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 258         (string_vappendf): Add ARI comment.
 259
 260 2019-12-13  Tom Tromey  <tromey@adacore.com>
 261
 262         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 263         floatformat_to_double.
 264         * target-float.c (host_float_ops<T>::from_target): Add ARI
 265         comment.
 266
 267 2019-12-13  Tom Tromey  <tromey@adacore.com>
 268
 269         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 270         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 271         ARI marker to abort.
 272         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 273
 274 2019-12-13  Tom Tromey  <tromey@adacore.com>
 275
 276         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 277
 278 2019-12-13  Tom Tromey  <tromey@adacore.com>
 279
 280         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 281
 282 2019-12-13  Tom Tromey  <tromey@adacore.com>
 283
 284         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 285         checks.
 286
 287 2019-12-13  Tom Tromey  <tromey@adacore.com>
 288
 289         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 290         end>: No longer "const".
 291
 292 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 293
 294         * jit.c: Fix indentation, replace spaces with tabs where
 295         applicable.
 296
 297 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 298
 299         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 300
 301 2019-12-12  Tom Tromey  <tom@tromey.com>
 302
 303         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 304         unique_ptr.
 305
 306 2019-12-12  Tom Tromey  <tom@tromey.com>
 307
 308         * progspace.h (objfile_list): New typedef.
 309         (class unwrapping_objfile_iterator)
 310         (struct unwrapping_objfile_range): Newl
 311         (struct program_space) <objfiles_range>: Change type.
 312         <objfiles>: Change return type.
 313         <add_objfile>: Change type of "objfile" parameter.
 314         <objfiles_list>: Now a list of shared_ptr.
 315         * progspace.c (program_space::add_objfile): Change type of
 316         "objfile".  Update.
 317         (program_space::remove_objfile): Update.
 318         * objfiles.h (struct objfile) <~objfile>: Make public.
 319         * objfiles.c (objfile::make): Update.
 320         (objfile::unlink): Don't call delete.
 321
 322 2019-12-12  Tom Tromey  <tom@tromey.com>
 323
 324         * symfile.c (symbol_file_clear): Update.
 325         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 326         method.
 327         * progspace.c (program_space::free_all_objfiles): New method.
 328         * objfiles.h (free_all_objfiles): Don't declare.
 329         * objfiles.c (free_all_objfiles): Move to program_space.
 330
 331 2019-12-12  Tom Tromey  <tom@tromey.com>
 332
 333         * progspace.c (program_space::add_objfile)
 334         (program_space::remove_objfile): Update.
 335         (program_space::multi_objfile_p): Remove.
 336         * objfiles.h (struct objfile) <next>: Remove.
 337         * objfiles.c (objfile::objfile): Update.
 338         (put_objfile_before): Update.
 339         (unlink_objfile): Update.
 340         * progspace.h (object_files): Remove.
 341         (struct program_space) <objfiles_head>: Remove.
 342         <objfiles_list>: New member.
 343         <objfiles_range, objfiles_safe_range>: Change type.
 344         (objfiles): Change return type.
 345         (objfiles_safe): Update.
 346         (multi_objfile_p): Rewrite and inline.
 347         (object_files): Remove macro.
 348
 349 2019-12-12  Tom Tromey  <tom@tromey.com>
 350
 351         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 352         second constructor.
 353         (basic_safe_range): New class.
 354
 355 2019-12-12  Tom Tromey  <tom@tromey.com>
 356
 357         * progspace.c (program_space::multi_objfile_p): New method.
 358         * printcmd.c (info_symbol_command): Update.
 359         * maint.c (maintenance_translate_address): Update.
 360         * objfiles.h (MULTI_OBJFILE_P): Remove.
 361         * progspace.h (struct program_space) <multi_objfile_p>: New
 362         method.
 363
 364 2019-12-12  Tom Tromey  <tom@tromey.com>
 365
 366         * progspace.h (struct program_space) <remove_objfile>: Declare.
 367         * progspace.c (program_space::remove_objfile): New method.
 368         * objfiles.c (unlink_objfile): Remove.
 369         (objfile::unlink): Call remove_objfile.
 370         (objfile): Don't call unlink_objfile.
 371
 372 2019-12-12  Tom Tromey  <tom@tromey.com>
 373
 374         * progspace.h (struct program_space) <add_objfile>: Declare
 375         method.
 376         * progspace.c (program_space::add_objfile): New method.
 377         * objfiles.c (~objfile): Don't unlink objfile.
 378         (put_objfile_before): Remove.
 379         (add_separate_debug_objfile): Don't call put_objfile_before.
 380         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 381         the per-program-space data.
 382
 383 2019-12-12  Tom Tromey  <tom@tromey.com>
 384
 385         * symfile.c (syms_from_objfile_1): Use objfile_up.
 386         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 387         method.
 388         (reread_symbols): Use objfile_up.
 389         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 390         unlink method.
 391         * objfiles.h (struct objfile) <~objfile>: Now private.
 392         <unlink>: New method.
 393         (struct objfile_deleter): New.
 394         (objfile_up): New typedef.
 395         * objfiles.c (objfile::unlink): New method.
 396         (free_objfile_separate_debug, free_all_objfiles)
 397         (objfile_purge_solibs): Use it.
 398         * jit.c (jit_unregister_code): Remove.
 399         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 400         objfile.
 401         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 402         objfile.
 403         * compile/compile-object-load.c (compile_object_load): Use
 404         objfile_up.
 405
 406 2019-12-12  Tom Tromey  <tom@tromey.com>
 407
 408         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 409         objfile::make.
 410         * objfiles.h (struct objjfile) <make>: No longer inline.
 411         (add_separate_debug_objfile): Don't declare.
 412         * objfiles.c (add_separate_debug_objfile): Now static.
 413         (objfile::make): Move from objfiles.h.  Call
 414         add_separate_debug_objfile.  Add "parent" parameter.
 415
 416 2019-12-12  Tom Tromey  <tom@tromey.com>
 417
 418         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 419         * objfiles.h (struct objfile): Make constructor private.
 420         <make>: New static method.
 421         * jit.c (jit_object_close_impl): Update.
 422
 423 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 424
 425         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 426         gdb::byte_vector.
 427
 428 2019-12-12  Tom Tromey  <tromey@adacore.com>
 429
 430         * xml-support.c (xml_fetch_content_from_file): Don't call
 431         malloc_failure.
 432         * utils.h (class gdb_argv): Remove malloc_failure comment.
 433         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 434
 435 2019-12-12  Tom Tromey  <tromey@adacore.com>
 436
 437         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 438         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 439         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 440         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 441         * riscv-ravenscar-thread.c: New file.
 442         * riscv-ravenscar-thread.h: New file.
 443         * riscv-tdep.c (riscv_gdbarch_init): Call
 444         register_riscv_ravenscar_ops.
 445
 446 2019-12-12  Tom Tromey  <tromey@adacore.com>
 447
 448         * gdbsupport/thread-pool.c (set_thread_name): Use
 449         ATTRIBUTE_UNUSED.
 450
 451 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 452
 453         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 454         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 455         macros.
 456
 457 2019-12-11  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-win.c (tui_set_win_height_command): Call
 460         tui_adjust_window_height.
 461         (tui_adjust_win_heights, new_height_ok): Remove.
 462         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 463         * tui/tui-layout.c (tui_adjust_window_height): New function.
 464
 465 2019-12-11  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-win.c (tui_resize_all): Remove code, call
 468         tui_apply_current_layout.
 469
 470 2019-12-11  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 473         * tui/tui-layout.c (standard_layouts, applied_layout): New
 474         globals.
 475         (tui_apply_current_layout): New function.
 476         (show_layout): Set applied_layout.  Call
 477         tui_apply_current_layout.
 478         (show_source_command, show_disasm_command)
 479         (show_source_disasm_command, show_data)
 480         (show_source_or_disasm_and_command): Remove.
 481         (initialize_layouts): New function.
 482         (_initialize_tui_layout): Call initialize_layouts.
 483
 484 2019-12-11  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-layout.h (class tui_layout_base)
 487         (class tui_layout_window, class tui_layout_split): New.
 488         * tui/tui-layout.c (tui_get_window_by_name)
 489         (tui_layout_window::clone, tui_layout_window::apply)
 490         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 491         (tui_layout_split::add_window, tui_layout_split::clone)
 492         (tui_layout_split::get_sizes)
 493         (tui_layout_split::set_weights_from_heights)
 494         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 495         functions.
 496         (tui_layout_split::add_split, tui_layout_split::add_split)
 497         (tui_layout_split::set_weights_from_heights)
 498         (tui_layout_split::set_weights_from_heights): New functions.
 499
 500 2019-12-11  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 503         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 504         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 505         * tui/tui-data.h (struct tui_point): Remove.
 506         (struct tui_gen_win_info) <origin>: Remove.
 507         <x, y>: New fields.
 508         * tui/tui-command.c (tui_cmd_window::resize): Update.
 509
 510 2019-12-11  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 513         Implement.
 514         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 515         Implement.
 516         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 517         method.
 518         (struct tui_win_info) <min_height>: Implement.
 519
 520 2019-12-11  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 523         (struct tui_win_info) <can_box>: Update.
 524
 525 2019-12-11  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 528         method.
 529         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 530         method.
 531         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 532         method.
 533         (struct tui_win_info) <max_height>: Now override.
 534
 535 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 536
 537         * NEWS: Create a new section for the next release branch.
 538         Rename the section of the current branch, now that it has
 539         been cut.
 540
 541 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 542
 543         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 544         * version.in: Bump version to 10.0.50.DATE-git.
 545
 546 2019-12-11  Tom Tromey  <tromey@adacore.com>
 547
 548         PR build/25268:
 549         * gdbsupport/thread-pool.c (set_thread_name): New function.
 550         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 551         (thread_pool::thread_function): Call set_thread_name.
 552
 553 2019-12-11  Tom Tromey  <tromey@adacore.com>
 554
 555         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 556         bfd_get_signed_8.
 557
 558 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 559
 560         * NEWS: Document -raw-values option and the related setting commands.
 561         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 562         only set it on when /r is given.
 563         * valprint.c (value_print_option_defs): New element raw-values.
 564         * Makefile.in: Add the new file.
 565
 566 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 567
 568         * gdbsupport/safe-strerror.c: Supress the unused function warning
 569         for select_strerror_r.
 570
 571 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * config.in: Regenerate.
 574         * configure: Regenerate.
 575         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 576         safe_strerror instead of strerror.
 577         * gdbsupport/common.m4: Don't check for strerror.
 578         * gdbsupport/safe-strerror.c: Support both the glibc version
 579         of strerror_r and the XSI version.
 580
 581 2019-12-10  Tom Tromey  <tromey@adacore.com>
 582
 583         * ada-typeprint.c (print_choices): Use a single "?".
 584         (print_variant_part): Print "?" if the discriminant name
 585         is not known.
 586
 587 2019-12-10  George Barrett  <bob@bob131.so>
 588
 589         Fix scripted probe breakpoints.
 590         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 591         declaration forward.
 592         (breakpoint_ops_for_event_location_type)
 593         (breakpoint_ops_for_event_location): Add function definitions.
 594         (break_command_1, trace_command): Use
 595         breakpoint_ops_for_event_location.
 596         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 597         declarations.
 598         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 599         breakpoint_ops_for_event_location.
 600         * python/py-breakpoint.c (bppy_init): Use
 601         breakpoint_ops_for_event_location.
 602
 603 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 604
 605         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 606         when ranking an lvalue argument for an rvalue parameter.
 607
 608 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 609
 610         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 611         template argument for scoped_restore_tmpl from bool to int.
 612
 613 2019-12-07  Keith Seitz  <keiths@redhat.com>
 614
 615         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 616         (build_id_to_debug_bfd): Make static, rewriting to use
 617         build_id_to_bfd_suffix.
 618         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 619         adding `suffix' parameter. Append SUFFIX to file names
 620         when searching for matching files.
 621         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 622         (build_id_to_exec_bfd): Likewise.
 623         * build-id.h (build_id_to_debug_bfd): Clarify that function
 624         searches for BFD of debug info file.
 625         (build_id_to_exec_bfd): Declare.
 626         * corelow.c: Include build-id.h.
 627         (locate_exec_from_corefile_build_id): New function.
 628         (core_target_open): If no executable BFD is found,
 629         search for a core file BFD using build-id.
 630
 631 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 632
 633         * bcache.c: Put in namespace gdb.
 634         * bcache.h: Likewise.
 635         * gdbtypes.c (check_types_worklist): Update.
 636         (types_deeply_equal): Update.
 637         * macrotab.c (struct macro_table) <bcache>: Update.
 638         (new_macro_table): Update.
 639         * macrotab.h (struct bcache): Put this forward declaration
 640         inside namespace gdb.
 641         (new_macro_table): Update.
 642         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 643         Update.
 644         <macro_cache>: Update.
 645         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 646
 647 2019-12-06  Tom de Vries  <tdevries@suse.de>
 648
 649         PR symtab/24971
 650         * block.c (best_symbol, better_symbol): New function.
 651         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 652         decl.
 653
 654 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 655
 656         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 657         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 658         for ranking see-through reference cases.
 659
 660 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 661         * stack.c (faas_command): Check a command is provided.
 662         * thread.c (taas_command, tfaas_command): Likewise.
 663
 664 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 665         * inferior.c (prune_inferiors):  Only call delete_inferior,
 666         Do not modify the inferior list.
 667
 668 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 669
 670         * c-exp.y: Update calls to lookup_typename,
 671         lookup_signed_typename and lookup_unsigned_typename.
 672         * c-lang.c (evaluate_subexp_c): Likewise.
 673         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 674         Likewise.
 675         * eval.c (binop_promote): Likewise.
 676         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 677         (lookup_unsigned_typename): Likewise.
 678         (lookup_signed_typename): Likewise.
 679         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 680         (lookup_signed_typename): Likewise.
 681         (lookup_typename): Likewise.
 682         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 683         lookup_typename, lookup_signed_typename,
 684         lookup_unsigned_typename.
 685         * m2-exp.y: Likewise.
 686         * printcmd.c (printf_wide_c_string): Likewise.
 687         (ui_printf): Likewise.
 688         * python/py-type.c (typy_lookup_typename): Likewise.
 689         * python/py-xmethods.c (python_xmethod_worker::invoke):
 690         Likewise.
 691         * rust-exp.y: Likewise.
 692
 693 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 694
 695         * configure.nat (obsd64): Add missing files x86-nat.o and
 696         nat/x86-dregs.o.
 697
 698 2019-12-04  Tom Tromey  <tom@tromey.com>
 699
 700         * valprint.c (val_print_string): Use metadata_style.
 701         * go-valprint.c (print_go_string): Use metadata style.
 702         * p-valprint.c (pascal_object_print_static_field): Use metadata
 703         style.
 704         * cp-valprint.c (cp_print_static_field): Use metadata style.
 705
 706 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 707             Chris January  <chris.january@arm.com>
 708
 709         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 710         tokens.
 711         (typebase): New patterns for complex, single/double precision, and
 712         single/double complex.
 713         (f77_keywords): Change token for complex keyword, and add single,
 714         double, and precision keywords.
 715
 716 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 717
 718         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 719         "info io_registers".
 720
 721 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 722
 723         * regcache.c (cooked_read_test): Initialize thread list of
 724         mock_inferior.
 725
 726 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 727
 728         * aarch64-linux-tdep.c: Remove includes.
 729
 730 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 731
 732         * aarch64-tdep.c: Remove includes.
 733
 734 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 735
 736         * filtered-iterator.h (filtered_iterator) <operator==,
 737         operator!=>: Compare wrapped iterators, not wrapped pointers.
 738         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 739         unittests/filtered_iterator-selftests.c.
 740         * unittests/filtered_iterator-selftests.c: New file.
 741
 742 2019-12-04  Tom Tromey  <tromey@adacore.com>
 743
 744         * gdbtypes.c (create_range_type): Inherit endianity
 745         from base type.
 746
 747 2019-12-04  Tom Tromey  <tromey@adacore.com>
 748
 749         * ada-lang.c (decode_constrained_packed_array)
 750         (ada_value_assign, value_assign_to_component): Update.
 751         * dwarf2loc.c (rw_pieced_value, access_memory)
 752         (dwarf2_compile_expr_to_ax): Update.
 753         * dwarf2read.c (dwarf2_add_field): Update.
 754         * eval.c (evaluate_subexp_standard): Update.
 755         * gdbarch.c, gdbarch.h: Rebuild.
 756         * gdbarch.sh (bits_big_endian): Remove.
 757         * gdbtypes.h (union field_location): Update comment.
 758         * target-descriptions.c (make_gdb_type): Update.
 759         * valarith.c (value_bit_index): Update.
 760         * value.c (struct value) <bitpos>: Update comment.
 761         (unpack_bits_as_long, modify_field): Update.
 762         * value.h (value_bitpos): Update comment.
 763
 764 2019-12-04  Tom Tromey  <tromey@adacore.com>
 765
 766         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 767         endian-ness.
 768
 769 2019-12-04  Tom Tromey  <tromey@adacore.com>
 770
 771         * dwarf2read.c (dwarf2_init_float_type)
 772         (dwarf2_init_complex_target_type): Add byte_order parameter.
 773         (read_base_type): Compute byte order earlier.
 774         * gdbtypes.c (init_float_type): Add byte_order parameter.
 775         * gdbtypes.h (init_float_type): Add byte_order parameter.
 776
 777 2019-12-04  Tom Tromey  <tromey@adacore.com>
 778
 779         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 780
 781 2019-12-04  Tom Tromey  <tromey@adacore.com>
 782
 783         * dwarf2read.c (process_structure_scope): Initialize
 784         "discr_offset".
 785
 786 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 789         add it into the search spec.
 790         (parse_max_results_option): New function.
 791         (mi_info_functions_or_variables): Parse -max-results flag and pass
 792         it to mi_symbol_info.
 793         (mi_cmd_symbol_info_modules): Likewise.
 794         (mi_cmd_symbol_info_types): Likewise.
 795         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 796         return type to bool, change result container into a set, and don't
 797         add new results if we have enough already.
 798         (global_symbol_searcher::add_matching_msymbols): Change return
 799         type to bool, and don't add new results if we have enough already.
 800         (sort_search_symbols_remove_dups): Delete.
 801         (global_symbol_searcher::search): Early exit from search loop when
 802         we have enough results.  Use a std::set to collect the results
 803         from calling add_matching_symbols.
 804         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 805         member function.
 806         (global_symbol_searcher) <m_max_search_results>: New member
 807         variable.
 808         (global_symbol_searcher) <add_matching_symbols>: Update header
 809         comment and change return type to bool.
 810         (global_symbol_searcher) <add_matching_msymbols>: Update header
 811         comment and change return type to bool.
 812
 813 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * symtab.c (symbol_search::compare_search_syms): Update header
 816         comment.
 817         (global_symbol_searcher::is_suitable_msymbol): New function.
 818         (global_symbol_searcher::expand_symtabs): New function.
 819         (global_symbol_searcher::add_matching_symbols): New function.
 820         (global_symbol_searcher::add_matching_msymbols): New function.
 821         (global_symbol_searcher::search): Move most of the content
 822         into the new functions above, and call them as needed.
 823         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 824         function.
 825         (global_symbol_searcher) <add_matching_symbols>: New member
 826         function.
 827         (global_symbol_searcher) <add_matching_msymbols>: New member
 828         function.
 829         (global_symbol_searcher) <is_suitable_msymbol>: New member
 830         function.
 831
 832 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 835         -symbol-info-module-variables entries.
 836         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 837         (mi_cmd_symbol_info_module_variables): Declare.
 838         * mi/mi-symbol-cmds.c
 839         (module_symbol_search_iterator): New typedef.
 840         (output_module_symbols_in_single_module_and_file): New function.
 841         (output_module_symbols_in_single_module): New function.
 842         (mi_info_module_functions_or_variables): New function.
 843         (mi_cmd_symbol_info_module_functions): New function.
 844         (mi_cmd_symbol_info_module_variables): New function.
 845         * NEWS: Mention new MI command.
 846
 847 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * bcache.c (hash): Remove.
 850         (hash_continue): Remove.
 851         * bcache.h (hash): Remove.
 852         (hash_continue): Remove.
 853         (struct bcache) <ctor>: Update.
 854         * psymtab.c (psymbol_hash): Update.
 855         * stabsread.c (hashname): Update.
 856         * utils.h (fast_hash): Add an argument for a start value,
 857         defaulting to zero.
 858
 859 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 860         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 861         (destroy_block_symbol_cache): New function.
 862         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 863         (resize_symbol_cache): Likewise.
 864
 865 2019-12-02  Tom Tromey  <tom@tromey.com>
 866
 867         * unittests/tui-selftests.c (run_tests): Make conditional.
 868         (_initialize_tui_selftest): Make conditional.
 869
 870 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 871
 872         * aix-thread.c (debug_aix_thread): Change type to bool.
 873
 874 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 875
 876         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 877
 878 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * dwarf2read.c (read_tag_string_type): Read the fields required to
 881         make a dynamic string, and possibly create a dynamic range for the
 882         string.
 883         (attr_to_dynamic_prop): Setup is_reference based on the type of
 884         attribute being processed.
 885         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 886         (resolve_dynamic_array): Rename to...
 887         (resolve_dynamic_array_or_string): ...this, update header comment,
 888         and accept TYPE_CODE_STRING.
 889         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 890
 891 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 892
 893         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 894         of its implementation from...
 895         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 896         the new function.
 897
 898 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 901         create a range with stride where appropriate.
 902         * f-valprint.c: Include 'gdbarch.h'.
 903         (f77_print_array_1): Take the stride into account when walking the
 904         array.  Also convert the stride into addressable units.
 905         * gdbtypes.c (create_range_type): Initialise the stride to
 906         constant zero.
 907         (create_range_type_with_stride): New function, initialise the
 908         range as normal, and then setup the stride.
 909         (has_static_range): Include the stride here.  Also change the
 910         return type to bool.
 911         (create_array_type_with_stride): Consider the range stride if the
 912         array isn't given its own stride.
 913         (resolve_dynamic_range): Resolve the stride if needed.
 914         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 915         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 916         (TYPE_BIT_STRIDE): Define.
 917         (TYPE_ARRAY_BIT_STRIDE): Define.
 918         (create_range_type_with_stride): Declare.
 919         * valarith.c (value_subscripted_rvalue): Take range stride into
 920         account when walking the array.
 921
 922 2019-12-01  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 925         specially.
 926
 927 2019-12-01  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 930         \0.
 931         * unittests/tui-selftests.c: New file.
 932         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 933
 934 2019-12-01  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 937
 938 2019-12-01  Tom Tromey  <tom@tromey.com>
 939
 940         * NEWS: Document new settings.
 941         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 942         * tui/tui-win.c (_initialize_tui_win): Add border style
 943         observers.
 944         * tui/tui-io.h (tui_apply_style): Declare.
 945         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 946         longer static.
 947         (apply_ansi_escape, tui_set_reverse_mode): Update.
 948         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 949         Add "skip_intensity" parameter.
 950         <changed>: New member.
 951         <do_set_value>: Declare.
 952         (tui_border_style, tui_active_border_style): Declare.
 953         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 954         globals.
 955         (cli_style_option): Initialize "changed".
 956         (cli_style_option::do_set_value): New function.
 957         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 958         parameter.  Update.
 959         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 960         (_initialize_cli_style): Update.  Create TUI border style
 961         commands.
 962
 963 2019-12-01  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 966         parameter.
 967         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 968         parameter.
 969         * tui/tui-win.h (compact_source): Declare.
 970         * tui/tui-win.c (compact_source): New global.
 971         (tui_set_compact_source, tui_show_compact_source): New functions.
 972         (_initialize_tui_win): Add "compact-source" setting.
 973         * tui/tui-source.c (tui_source_window::set_contents): Handle
 974         compact_source setting.
 975         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 976         * NEWS: Document new setting.
 977
 978 2019-11-30  Tom Tromey  <tom@tromey.com>
 979
 980         * dwarf2read.c (dwarf2_add_field): Include field offset when
 981         computing variant part length.
 982
 983 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 984         * NEWS:  Mention define-prefix.  Tell that command names can now
 985         contain a . character.
 986
 987 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 988
 989         * command.h (valid_cmd_char_p): Declare.
 990         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 991         the check of valid command char.
 992         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 993         valid_cmd_char_p.
 994         * cli/cli-script.c (validate_comname): Likewise.
 995         * completer.c (gdb_completer_command_word_break_characters):
 996         Do not remove . from the word break char, update comments.
 997         (complete_line_internal_1): Use valid_cmd_char_p.
 998         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 999         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1000
1001 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1002
1003         * cli/cli-script.c (do_define_command): Ensure a redefined
1004         prefix command is kept as a prefix command.
1005         (define_prefix_command): New function.
1006         (show_user_1): Report user defined prefixes.
1007         (_initialize_cli_script):  Create the new 'define-prefix' command.
1008         Add completers for 'define' and 'document'.
1009         * top.c (execute_command):  If command is a user-defined prefix only
1010         command, report the list of commands for this prefix command.
1011
1012 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1013
1014         * valops.c (find_oload_champ): Improve debug output.
1015
1016 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1017
1018         * valops.c (find_oload_champ): Print part of debug messages
1019         before the badness vector is std::move'd.
1020
1021 2019-11-28  Tom Tromey  <tom@tromey.com>
1022
1023         * value.c (creal_internal_fn): Fix comment.
1024
1025 2019-11-28  Tom Tromey  <tom@tromey.com>
1026
1027         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1028         flag_bound_evaluated>: Now unsigned.
1029
1030 2019-11-28  Tom Tromey  <tom@tromey.com>
1031
1032         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1033         declare.
1034
1035 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1036
1037         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1038         debug output.
1039         * jit.c (jit_unregister_code): Add debug print to match
1040         `jit_register_code`.
1041
1042 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1043
1044         * NEWS: Mention the new multithreaded symbol loading.
1045
1046 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1047
1048         * maint.c (n_worker_threads): Default to 0.
1049         (worker_threads_disabled): New function.
1050         * maint.h (worker_threads_disabled): New function.
1051         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1052         here if worker_threads_disabled () is true.
1053         (minimal_symbol_reader::install): Skip all threading if
1054         worker_threads_disabled () is true.
1055
1056 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1059         hash code if possible.
1060         (add_minsym_to_demangled_hash_table): Likewise.
1061         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1062         on the background thread.
1063         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1064         Add these fields.
1065
1066 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1067
1068         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1069         of the mangled name on the background thread.
1070         * symtab.c (symbol_set_names): Allow passing in the hash of the
1071         linkage_name.
1072         * symtab.h (symbol_set_names): Likewise.
1073
1074 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1075
1076         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1077         physnames are computed for inherited DIEs.
1078
1079 2019-11-27  Tom Tromey  <tromey@adacore.com>
1080
1081         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1082         backslashes.
1083         * cp-support.c: Remove unnecessary backslashes.
1084
1085 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1086
1087         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1088         with sym->set_linkage_name.
1089         * coffread.c (coff_read_enum_type): Likewise.
1090         * mdebugread.c (parse_symbol): Likewise.
1091         * stabsread.c (patch_block_stabs): Likewise.
1092         (define_symbol): Likewise.
1093         (read_enum_type): Likewise.
1094         (common_block_end): Likewise.
1095         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1096         function.
1097         (SYMBOL_SET_LINKAGE_NAME): Remove.
1098         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1099         with sym->set_linkage_name.
1100
1101 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1104         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1105         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1106         * NEWS: Mention new MI command.
1107
1108 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1111         '-symbol-info-types', and '-symbol-info-variables'.
1112         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1113         (mi_cmd_symbol_info_types): Declare.
1114         (mi_cmd_symbol_info_variables): Declare.
1115         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1116         (output_debug_symbol): New function.
1117         (output_nondebug_symbol): New function.
1118         (mi_symbol_info): New function.
1119         (mi_info_functions_or_variables): New function.
1120         (mi_cmd_symbol_info_functions): New function.
1121         (mi_cmd_symbol_info_types): New function.
1122         (mi_cmd_symbol_info_variables): New function.
1123         * NEWS: Mention new commands.
1124
1125 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * symtab.c (symbol_to_info_string): New function, most content
1128         moved from print_symbol_info, but updated to return a std::string.
1129         (print_symbol_info): Update to use symbol_to_info_string and print
1130         returned string.
1131         * symtab.h (symbol_to_info_string): Declare new function.
1132
1133 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * python/python.c (gdbpy_rbreak): Convert to using
1136         global_symbol_searcher.
1137         * symtab.c (file_matches): Convert return type to bool, change
1138         file list to std::vector, update header comment.
1139         (search_symbols): Rename to...
1140         (global_symbol_searcher::search): ...this and update now its
1141         a member function of global_symbol_searcher.  Take account of the
1142         changes to file_matches.
1143         (symtab_symbol_info): Convert to using global_symbol_searcher.
1144         (rbreak_command): Likewise.
1145         (search_module_symbols): Likewise.
1146         * symtab.h (enum symbol_search): Update comment.
1147         (search_symbols): Remove declaration.
1148         (class global_symbol_searcher): New class.
1149
1150 2019-11-26  Tom Tromey  <tromey@adacore.com>
1151
1152         * cp-support.c (_initialize_cp_support): Conditionally initialize
1153         gdb_demangle_attempt_core_dump.
1154
1155 2019-11-26  Tom Tromey  <tom@tromey.com>
1156
1157         * python/py-function.c (fnpy_init): Update.
1158         * value.h (add_internal_function): Adjust declaration.
1159         * value.c (function_destroyer): Remove.
1160         (do_add_internal_function): Don't set destroyer or copy name.
1161         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1162         Set name_allocated.
1163         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1164         (cmdpy_init): Set name_allocated.
1165         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1166         member.
1167         (~cmd_list_element): Free "name" if needed.
1168
1169 2019-11-26  Tom Tromey  <tom@tromey.com>
1170
1171         * value.h (add_internal_function): Add new overload.  Move
1172         documentation from value.h.
1173         * value.c (do_add_internal_function): New function.
1174         (add_internal_function): Use it.  Add new overload.
1175         (function_destroyer): Don't free doc.
1176         * python/py-function.c (fnpy_init): Update.
1177
1178 2019-11-26  Tom Tromey  <tom@tromey.com>
1179
1180         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1181         (cmdpy_init): Set "doc_allocated".
1182
1183 2019-11-26  Tom Tromey  <tom@tromey.com>
1184
1185         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1186         name of worker thread.
1187         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1188         pthread_setname_np.
1189         * configure, config.in: Rebuild.
1190
1191 2019-11-26  Tom Tromey  <tom@tromey.com>
1192
1193         * python/python.c (class gdbpy_gil): New.
1194         (struct gdbpy_event): Add constructor, destructor, operator().
1195         (gdbpy_post_event): Use run_on_main_thread.
1196         (gdbpy_initialize_events): Remove.
1197         (do_start_initialization): Update.
1198
1199 2019-11-26  Tom Tromey  <tom@tromey.com>
1200
1201         * NEWS: Add entry.
1202         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1203         commands.  Call update_thread_pool_size.
1204         (update_thread_pool_size, maintenance_set_worker_threads): New
1205         functions.
1206         (n_worker_threads): New global.
1207
1208 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1209             Tom Tromey  <tom@tromey.com>
1210
1211         * minsyms.c (minimal_symbol_reader::install): Use
1212         parallel_for_each.
1213         * gdbsupport/parallel-for.h: New file.
1214         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1215
1216 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1217             Tom Tromey  <tom@tromey.com>
1218
1219         * gdbsupport/thread-pool.h: New file.
1220         * gdbsupport/thread-pool.c: New file.
1221         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1222         (HFILES_NO_SRCDIR): Add thread-pool.h.
1223
1224 2019-11-26  Tom Tromey  <tom@tromey.com>
1225
1226         * event-top.h (thread_local_segv_handler): Declare.
1227         * event-top.c (thread_local_segv_handler): New global.
1228         (install_handle_sigsegv, handle_sigsegv): New functions.
1229         (async_init_signals): Install SIGSEGV handler.
1230         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1231         thread-local.
1232         (report_failed_demangle): New function.
1233         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1234         handler-setting code, instead use segv_handler.  Run warning code
1235         on main thread.
1236
1237 2019-11-26  Tom Tromey  <tom@tromey.com>
1238
1239         * run-on-main-thread.c: New file.
1240         * run-on-main-thread.h: New file.
1241         * unittests/main-thread-selftests.c: New file.
1242         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1243         main-thread-selftests.c.
1244         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1245         (COMMON_SFILES): Add run-on-main-thread.c.
1246
1247 2019-11-26  Tom Tromey  <tom@tromey.com>
1248
1249         * main.c (setup_alternate_signal_stack): Remove.
1250         (captured_main_1): Use gdb::alternate_signal_stack.
1251         * gdbsupport/alt-stack.h: New file.
1252
1253 2019-11-26  Tom Tromey  <tom@tromey.com>
1254
1255         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1256         Remove comment.
1257         (save_original_signals_state, restore_original_signals_state): Use
1258         gdb_sigmask.
1259         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1260         (_initialize_linux_nat): Use gdb_sigmask.
1261         * guile/guile.c (_initialize_guile): Use block_signals.
1262         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1263         * gdbsupport/gdb-sigmask.h: New file.
1264         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1265         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1266         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1267         pthread_sigmask.
1268         * configure, config.in: Rebuild.
1269         * gdbsupport/block-signals.h: New file.
1270
1271 2019-11-26  Tom Tromey  <tom@tromey.com>
1272
1273         * acinclude.m4: Include ax_pthread.m4.
1274         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1275         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1276         (CLIBS): Use PTHREAD_LIBS.
1277         (aclocal_m4_deps): Add ax_pthread.m4.
1278         * config.in, configure: Rebuild.
1279         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1280
1281 2019-11-26  Tom Tromey  <tom@tromey.com>
1282
1283         * symtab.h (struct minimal_symbol) <name_set>: New member.
1284         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1285         Don't call symbol_set_names.
1286         (minimal_symbol_reader::install): Call symbol_set_names.
1287
1288 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1289
1290         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1291         restore_active_ext_lang, as GIL is needed for (indirectly)
1292         called PyOS_InterruptOccurred.
1293
1294 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1295
1296         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1297         definition.
1298
1299 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1300
1301         * remote-sim.c (simulator_command): Make static, remove
1302         declaration.
1303
1304 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1305
1306         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1307         static.
1308         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1309         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1310         (main): Likewise.
1311         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1312         (main): Likewise.
1313         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1314         (main): Likewise.
1315         * unittests/basic_string_view/element_access/char/1.cc (test01):
1316         Likewise.
1317         (main): Likewise.
1318         * unittests/basic_string_view/element_access/char/empty.cc (main):
1319         Likewise.
1320         * unittests/basic_string_view/element_access/char/front_back.cc
1321         (test01): Likewise.
1322         (main): Likewise.
1323         * unittests/basic_string_view/inserters/char/2.cc (test05):
1324         Likewise.
1325         (main): Likewise.
1326         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1327         (test01): Likewise.
1328         (main): Likewise.
1329         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1330         (test01): Likewise.
1331         (main): Likewise.
1332         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1333         Likewise.
1334         * unittests/basic_string_view/operations/compare/char/1.cc
1335         (test01): Likewise.
1336         (main): Likewise.
1337         * unittests/basic_string_view/operations/compare/char/13650.cc
1338         (test01): Likewise.
1339         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1340         Likewise.
1341         (main): Likewise.
1342         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1343         Likewise.
1344         (main): Likewise.
1345         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1346         Likewise.
1347         (main): Likewise.
1348         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1349         Likewise.
1350         (main): Likewise.
1351         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1352         Likewise.
1353         (main): Likewise.
1354         * unittests/basic_string_view/operations/find/char/4.cc (main):
1355         Likewise.
1356         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1357         Likewise.
1358         (main): Likewise.
1359         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1360         Likewise.
1361         (main): Likewise.
1362         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1363         Likewise.
1364         (main): Likewise.
1365         * unittests/basic_string_view/operations/substr/char/1.cc
1366         (test01): Likewise.
1367         (main): Likewise.
1368         * unittests/basic_string_view/operators/char/2.cc (main):
1369         Likewise.
1370         * unittests/optional/assignment/1.cc (test): Likewise.
1371         * unittests/optional/assignment/2.cc (test): Likewise.
1372         * unittests/optional/assignment/3.cc (test): Likewise.
1373         * unittests/optional/assignment/4.cc (test): Likewise.
1374         * unittests/optional/assignment/5.cc (test): Likewise.
1375         * unittests/optional/assignment/6.cc (test): Likewise.
1376         * unittests/optional/assignment/7.cc (test): Likewise.
1377         * unittests/optional/cons/copy.cc (test): Likewise.
1378         * unittests/optional/cons/default.cc (test): Likewise.
1379         * unittests/optional/cons/move.cc (test): Likewise.
1380         * unittests/optional/cons/value.cc (test): Likewise.
1381         * unittests/optional/in_place.cc (test): Likewise.
1382         * unittests/optional/observers/1.cc (test): Likewise.
1383         * unittests/optional/observers/2.cc (test): Likewise.
1384
1385 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1386
1387         * tui-win.h (tui_set_var_cmd): Remove.
1388         * tui-win.c (tui_set_var_cmd): Make static.
1389
1390 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1391
1392         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1393         rbreak_command_wrapper): Remove.
1394         * symtab.c (rbreak_command_wrapper): Remove.
1395
1396 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1397
1398         * inferior.h (info_terminal_command): Remove declaration.
1399         * inflow.c (info_terminal_command): Make static.
1400
1401 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1402
1403         * inferior.c (exit_inferior_silent): Remove.
1404
1405 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1406
1407         * dictionary.c (dict_empty, mdict_empty): Remove.
1408         * dictionary.c (mdict_empty): Remove.
1409
1410 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1411
1412          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1413          (arc_insn_get_memory_offset): Likewise.
1414          (arc_insn_dump): Likewise.
1415          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1416          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1417          * dictionary.c (dict_iterator_next): Likewise.
1418          (dict_iter_match_first): Likewise.
1419          (dict_iter_match_next): Likewise.
1420          * f-lang.c (evaluate_subexp_f): Likewise.
1421          * hppa-tdep.c (hppa_read_pc): Likewise.
1422          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1423          * parse.c (write_exp_elt_msym): Likewise.
1424          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1425          * remote.c (remote_packet_size): Likewise.
1426          (remote_notif_stop_parse): Likewise.
1427          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1428          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1429          * source.c (prepare_path_for_appending): Likewise.
1430          * sparc64-linux-tdep.c
1431          (sparc64_linux_handle_segmentation_fault); Likewise.
1432          * stack.c (frame_selection_by_function_completer): Likewise.
1433
1434 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1435
1436         * completer.c (set_gdb_completion_word_break_characters):
1437         Remove.
1438
1439 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1440
1441         * dwarf-index-write.c: Include dwarf-index-write.h.
1442         * mi/mi-interp.c: Include mi/mi-interp.h.
1443
1444 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1445
1446         * aarch32-tdep.c: Include aarch32-tdep.h.
1447         * aarch32-tdep.h: Forward-declare struct target_desc.
1448
1449 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1450
1451         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1452         strerror.
1453         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1454         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1455
1456 2019-11-25  Tom de Vries  <tdevries@suse.de>
1457
1458         * contrib/words.sh: Add -c option.
1459
1460 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1461
1462         * solib.c (solib_find_1): Change int to bool.
1463         (exec_file_find): Change int to bool.
1464         (solib_find): Change int to bool.
1465         (solib_read_symbols): Change int to bool.
1466         (solib_used): Change int to bool.
1467         (solib_add): Change int to bool.
1468         (info_sharedlibrary_command): Change int to bool.
1469         (solib_contains_address_p): Change int to bool.
1470         (solib_keep_data_in_core): Change int to bool.
1471         (in_solib_dynsym_resolve_code): Change int to bool.
1472         (reload_shared_libraries_1): Change int to bool.
1473         (gdb_sysroot_changed): Change int to bool.
1474         * solib.h (solib_read_symbols): Change int to bool.
1475         (solib_contains_address_p): Change int to bool.
1476         (solib_keep_data_in_core): Change int to bool.
1477         (in_solib_dynsym_resolve_code): Change int to bool.
1478         (libpthread_name_p): Change int to bool.
1479
1480 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1481
1482         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1483         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1484         (remote_packet_max_chars): New static global.
1485         (show_remote_packet_max_chars): New function.
1486         (remote_target::putpkt_binary): Adjust to use new
1487         remote_packet_max_chars option.
1488         (remote_target::getpkt_or_notif_sane_1): Likewise.
1489         (_initialize_remote): Register new remote-packet-max-chars option.
1490
1491 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1492
1493         * m68k-linux-nat.c: Include gdbarch.h.
1494
1495 2019-11-24  Tom Tromey  <tom@tromey.com>
1496
1497         * symfile.c (read_symbols): Update.
1498         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1499         bool.
1500         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1501         (psym_lookup_symbol, psym_find_last_source_symtab)
1502         (psym_forget_cached_source_info, psym_print_stats)
1503         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1504         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1505         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1506         (psym_find_compunit_symtab_by_address)
1507         (maintenance_print_psymbols, maintenance_info_psymtabs)
1508         (maintenance_check_psymtabs): Update.
1509         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1510         bool.
1511
1512 2019-11-22  Tom Tromey  <tom@tromey.com>
1513
1514         * observable.h: Update comments.
1515
1516 2019-11-22  Tom Tromey  <tromey@adacore.com>
1517
1518         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1519         (print_ada_task_info): Don't try to fetch thread id if task is not
1520         alive.
1521
1522 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1523
1524         * ada-exp.y: Update.
1525         * ada-lang.c (sort_choices): Update.
1526         (ada_print_symbol_signature): Update.
1527         (resolve_subexp): Update.
1528         (ada_parse_renaming): Update.
1529         (ada_read_renaming_var_value): Update.
1530         (lesseq_defined_than): Update.
1531         (remove_extra_symbols): Update.
1532         (remove_irrelevant_renamings): Update.
1533         (ada_add_block_symbols): Update.
1534         (ada_collect_symbol_completion_matches): Update.
1535         (ada_is_renaming_symbol): Update.
1536         (aggregate_assign_from_choices): Update.
1537         (ada_evaluate_subexp): Update.
1538         (ada_has_this_exception_support): Update.
1539         (ada_is_non_standard_exception_sym): Update.
1540         (ada_add_exceptions_from_frame): Update.
1541         (ada_add_global_exceptions): Update.
1542         (ada_print_subexp): Update.
1543         * ax-gdb.c (gen_var_ref): Update.
1544         (gen_maybe_namespace_elt): Update.
1545         (gen_expr_for_cast): Update.
1546         (gen_expr): Update.
1547         * block.h: Update.
1548         * blockframe.c (find_pc_partial_function): Update.
1549         * breakpoint.c (print_breakpoint_location): Update.
1550         (update_static_tracepoint): Update.
1551         * btrace.c (ftrace_print_function_name): Update.
1552         (ftrace_function_switched): Update.
1553         * buildsym.c (find_symbol_in_list): Update.
1554         * c-exp.y: Update.
1555         * c-typeprint.c (c_print_typedef): Update.
1556         (c_type_print_template_args): Update.
1557         * cli/cli-cmds.c (edit_command): Update.
1558         (list_command): Update.
1559         (print_sal_location): Update.
1560         * coffread.c (patch_opaque_types): Update.
1561         (process_coff_symbol): Update.
1562         (coff_read_enum_type): Update.
1563         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1564         (convert_one_symbol): Update.
1565         (hash_symname): Update.
1566         (eq_symname): Update.
1567         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1568         * compile/compile-cplus-types.c (debug_print_scope): Update.
1569         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1570         * compile/compile-object-load.c (get_out_value_type): Update.
1571         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1572         (search_symbol_list): Update.
1573         (cp_lookup_symbol_imports_or_template): Update.
1574         * cp-support.c (overload_list_add_symbol): Update.
1575         * ctfread.c (psymtab_to_symtab): Update.
1576         * dbxread.c (cp_set_block_scope): Update.
1577         * dictionary.c (iter_match_first_hashed): Update.
1578         (iter_match_next_hashed): Update.
1579         (insert_symbol_hashed): Update.
1580         (iter_match_next_linear): Update.
1581         * dictionary.h: Update.
1582         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1583         (locexpr_describe_location_piece): Update.
1584         (locexpr_describe_location_1): Update.
1585         (locexpr_generate_c_location): Update.
1586         (loclist_describe_location): Update.
1587         (loclist_generate_c_location): Update.
1588         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1589         (read_func_scope): Update.
1590         (process_enumeration_scope): Update.
1591         (new_symbol): Update.
1592         (dwarf2_const_value): Update.
1593         (dwarf2_symbol_mark_computed): Update.
1594         * eval.c (evaluate_funcall): Update.
1595         (evaluate_subexp_standard): Update.
1596         * expprint.c (print_subexp_standard): Update.
1597         (dump_subexp_body_standard): Update.
1598         * f-valprint.c (info_common_command_for_block): Update.
1599         * findvar.c (get_hosting_frame): Update.
1600         (default_read_var_value): Update.
1601         * go-lang.c (go_symbol_package_name): Update.
1602         * guile/scm-block.c (bkscm_print_block_smob): Update.
1603         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1604         (gdbscm_symbol_name): Update.
1605         (gdbscm_symbol_linkage_name): Update.
1606         (gdbscm_symbol_print_name): Update.
1607         * infcall.c (get_function_name): Update.
1608         * infcmd.c (jump_command): Update.
1609         (finish_command): Update.
1610         * infrun.c (insert_exception_resume_breakpoint): Update.
1611         * linespec.c (canonicalize_linespec): Update.
1612         (create_sals_line_offset): Update.
1613         (convert_linespec_to_sals): Update.
1614         (complete_label): Update.
1615         (find_label_symbols_in_block): Update.
1616         * m2-typeprint.c (m2_print_typedef): Update.
1617         * mdebugread.c (mdebug_reg_to_regnum): Update.
1618         (parse_symbol): Update.
1619         (mylookup_symbol): Update.
1620         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1621         (list_args_or_locals): Update.
1622         * objc-lang.c (compare_selectors): Update.
1623         (info_selectors_command): Update.
1624         (compare_classes): Update.
1625         (info_classes_command): Update.
1626         (find_imps): Update.
1627         * p-typeprint.c (pascal_print_typedef): Update.
1628         * printcmd.c (build_address_symbolic): Update.
1629         (info_address_command): Update.
1630         (print_variable_and_value): Update.
1631         * python/py-framefilter.c (extract_sym): Update.
1632         (py_print_single_arg): Update.
1633         * python/py-symbol.c (sympy_str): Update.
1634         (sympy_get_name): Update.
1635         (sympy_get_linkage_name): Update.
1636         * python/python.c (gdbpy_rbreak): Update.
1637         * record-btrace.c (btrace_get_bfun_name): Update.
1638         (btrace_call_history): Update.
1639         * rust-lang.c (rust_print_typedef): Update.
1640         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1641         * stabsread.c (stab_reg_to_regnum): Update.
1642         (define_symbol): Update.
1643         (read_enum_type): Update.
1644         (common_block_end): Update.
1645         (cleanup_undefined_types_1): Update.
1646         (scan_file_globals): Update.
1647         * stack.c (print_frame_arg): Update.
1648         (print_frame_args): Update.
1649         (find_frame_funname): Update.
1650         (info_frame_command_core): Update.
1651         (iterate_over_block_locals): Update.
1652         (print_block_frame_labels): Update.
1653         (do_print_variable_and_value): Update.
1654         (iterate_over_block_arg_vars): Update.
1655         (return_command): Update.
1656         * symmisc.c (dump_symtab_1): Update.
1657         (print_symbol): Update.
1658         * symtab.c (eq_symbol_entry): Update.
1659         (symbol_cache_dump): Update.
1660         (lookup_language_this): Update.
1661         (find_pc_sect_line): Update.
1662         (skip_prologue_sal): Update.
1663         (symbol_search::compare_search_syms): Update.
1664         (treg_matches_sym_type_name): Update.
1665         (search_symbols): Update.
1666         (print_symbol_info): Update.
1667         (rbreak_command): Update.
1668         (completion_list_add_symbol): Update.
1669         (find_gnu_ifunc): Update.
1670         (get_symbol_address): Update.
1671         (search_module_symbols): Update.
1672         (info_module_subcommand): Update.
1673         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1674         (SYMBOL_LINKAGE_NAME): Remove.
1675         (SYMBOL_DEMANGLED_NAME): Remove.
1676         (SYMBOL_PRINT_NAME): Remove.
1677         (SYMBOL_SEARCH_NAME): Remove.
1678         * tracepoint.c (set_traceframe_context): Update.
1679         (validate_actionline): Update.
1680         (collection_list::collect_symbol): Update.
1681         (encode_actions_1): Update.
1682         (info_scope_command): Update.
1683         (print_one_static_tracepoint_marker): Update.
1684         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1685         * valops.c (address_of_variable): Update.
1686         (find_overload_match): Update.
1687         (find_oload_champ): Update.
1688
1689 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1690
1691         * ada-lang.c (ada_lookup_simple_minsym): Update.
1692         (ada_collect_symbol_completion_matches): Update.
1693         * ada-tasks.c (read_atcb): Update.
1694         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1695         (amd64_windows_skip_trampoline_code): Update.
1696         * arm-tdep.c (skip_prologue_function): Update.
1697         (arm_skip_stack_protector): Update.
1698         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1699         (arm_wince_skip_main_prologue): Update.
1700         * ax-gdb.c (gen_expr): Update.
1701         * block.c (call_site_for_pc): Update.
1702         * blockframe.c (find_pc_partial_function): Update.
1703         * breakpoint.c (set_breakpoint_location_function): Update.
1704         * btrace.c (ftrace_print_function_name): Update.
1705         (ftrace_function_switched): Update.
1706         * c-valprint.c (print_unpacked_pointer): Update.
1707         * coffread.c (coff_symfile_read): Update.
1708         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1709         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1710         * dwarf-index-write.c (write_psymbols): Update.
1711         * dwarf2loc.c (call_site_to_target_addr): Update.
1712         (func_verify_no_selftailcall): Update.
1713         (tailcall_dump): Update.
1714         (call_site_find_chain_1): Update.
1715         (dwarf_expr_reg_to_entry_parameter): Update.
1716         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1717         * eval.c (evaluate_funcall): Update.
1718         (evaluate_subexp_standard): Update.
1719         (evaluate_subexp_for_sizeof): Update.
1720         * expprint.c (print_subexp_standard): Update.
1721         (dump_subexp_body_standard): Update.
1722         * frame.c (get_prev_frame_always_1): Update.
1723         * frv-tdep.c (frv_skip_main_prologue): Update.
1724         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1725         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1726         (gnuv3_get_typename_from_type_info): Update.
1727         (gnuv3_skip_trampoline): Update.
1728         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1729         * i386-tdep.c (i386_skip_main_prologue): Update.
1730         (i386_pe_skip_trampoline_code): Update.
1731         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1732         * infcall.c (get_function_name): Update.
1733         * linespec.c (minsym_found): Update.
1734         * linux-fork.c (info_checkpoints_command): Update.
1735         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1736         (m32c_m16c_pointer_to_address): Update.
1737         * maint.c (maintenance_translate_address): Update.
1738         * minsyms.c (add_minsym_to_hash_table): Update.
1739         (add_minsym_to_demangled_hash_table): Update.
1740         (lookup_minimal_symbol_mangled): Update.
1741         (lookup_minimal_symbol_demangled): Update.
1742         (lookup_minimal_symbol_linkage): Update.
1743         (lookup_minimal_symbol_text): Update.
1744         (lookup_minimal_symbol_by_pc_name): Update.
1745         (minimal_symbol_is_less_than): Update.
1746         (compact_minimal_symbols): Update.
1747         (build_minimal_symbol_hash_tables): Update.
1748         (find_solib_trampoline_target): Update.
1749         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1750         (mips_skip_pic_trampoline_code): Update.
1751         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1752         * objc-lang.c (info_selectors_command): Update.
1753         (info_classes_command): Update.
1754         (find_methods): Update.
1755         (find_imps): Update.
1756         * p-valprint.c (pascal_val_print): Update.
1757         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1758         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1759         * printcmd.c (build_address_symbolic): Update.
1760         (info_symbol_command): Update.
1761         * psymtab.c (psymbol_name_matches): Update.
1762         (match_partial_symbol): Update.
1763         (lookup_partial_symbol): Update.
1764         (print_partial_symbols): Update.
1765         (sort_pst_symbols): Update.
1766         (maintenance_check_psymtabs): Update.
1767         * python/py-framefilter.c (py_print_frame): Update.
1768         * python/python.c (gdbpy_rbreak): Update.
1769         * record-btrace.c (btrace_get_bfun_name): Update.
1770         (btrace_call_history): Update.
1771         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1772         (rs6000_skip_trampoline_code): Update.
1773         * sol-thread.c (info_cb): Update.
1774         * stabsread.c (scan_file_globals): Update.
1775         * stack.c (find_frame_funname): Update.
1776         (info_frame_command_core): Update.
1777         * symmisc.c (dump_msymbols): Update.
1778         * symtab.c (symbol_natural_name): Rename to..,
1779         (general_symbol_info::natural_name): ...this.
1780         (symbol_demangled_name): Rename to...
1781         (general_symbol_info::demangled_name): ...this.
1782         (symbol_search_name): Rename to...
1783         (general_symbol_info::search_name): ...this.
1784         (symbol_matches_search_name): Update.
1785         (find_pc_sect_line): Update.
1786         (skip_prologue_sal): Update.
1787         (search_symbols): Update.
1788         (print_msymbol_info): Update.
1789         (rbreak_command): Update.
1790         (completion_list_add_msymbol): Update.
1791         (completion_list_objc_symbol): Update.
1792         (get_msymbol_address): Update.
1793         * symtab.h (struct general_symbol_info): Add member functions
1794         natural_name (), linkage_name (), print_name (), demangled_name (),
1795         and search_name ().
1796         (SYMBOL_NATURAL_NAME): Update.
1797         (symbol_natural_name): Move to a member function on general_symbol_info.
1798         (SYMBOL_DEMANGLED_NAME): Update.
1799         (symbol_demangled_name): Move to a member function on
1800         general_symbol_info.
1801         (SYMBOL_SEARCH_NAME): Update.
1802         (symbol_search_name): Move to a member function on general_symbol_info.
1803         (MSYMBOL_NATURAL_NAME): Remove.
1804         (MSYMBOL_LINKAGE_NAME): Remove.
1805         (MSYMBOL_PRINT_NAME): Remove.
1806         (MSYMBOL_DEMANGLED_NAME): Remove.
1807         (MSYMBOL_SEARCH_NAME): Remove.
1808         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1809
1810 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1811
1812         * symtab.c (create_demangled_names_hash): Use per_bfd->
1813         minimal_symbol_count for computing the initial size, if greater
1814         than our default size.
1815
1816 2019-11-22  Tom de Vries  <tdevries@suse.de>
1817
1818         * contrib/words.sh: Improve words extraction.
1819
1820 2019-11-22  Tom de Vries  <tdevries@suse.de>
1821
1822         * contrib/words.sh: Combine sed invocations.
1823
1824 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1825
1826         * Makefile.in: Update.
1827         * demangle.c: Rename to...
1828         * gdb-demangle.c: ..this.
1829         (is_cplus_marker): Change return type to bool.
1830         (_initialize_demangler): Rename to...
1831         (_initialize_gdb_demangle): ...this.
1832         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1833         * symtab.h (demangle): Remove declaration; instead include
1834         gdb-demangle.h.
1835
1836 2019-11-21  Tom Tromey  <tromey@adacore.com>
1837
1838         * gdbsupport/format.c (format_pieces): Parse %I64d.
1839         * unittests/format_pieces-selftests.c (test_windows_formats): New
1840         function.
1841         (run_tests): Call it.
1842
1843 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1844
1845         Byte reverse display of variables with DW_END_big, DW_END_little
1846         (DW_AT_endianity) dwarf attributes if different than the native
1847         byte order.
1848         * ada-lang.c (ada_value_binop):
1849         Use type_byte_order instead of gdbarch_byte_order.
1850         * ada-valprint.c (printstr):
1851         (ada_val_print_string):
1852         * ada-lang.c (value_pointer):
1853         (ada_value_binop):
1854         Use type_byte_order instead of gdbarch_byte_order.
1855         * c-lang.c (c_get_string):
1856         Use type_byte_order instead of gdbarch_byte_order.
1857         * c-valprint.c (c_val_print_array):
1858         Use type_byte_order instead of gdbarch_byte_order.
1859         * cp-valprint.c (cp_print_class_member):
1860         Use type_byte_order instead of gdbarch_byte_order.
1861         * dwarf2loc.c (rw_pieced_value):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * dwarf2read.c (read_base_type): Handle DW_END_big,
1864         DW_END_little
1865         * f-lang.c (f_get_encoding):
1866         Use type_byte_order instead of gdbarch_byte_order.
1867         * findvar.c (default_read_var_value):
1868         Use type_byte_order instead of gdbarch_byte_order.
1869         * gdbtypes.c (check_types_equal):
1870         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1871         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1872         and TYPE_ENDIANITY_LITTLE if set.
1873         (type_byte_order): new function.
1874         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1875         (struct main_type) <flag_endianity_not_default>:
1876         New field.
1877         (type_byte_order): New function.
1878         * infcmd.c (default_print_one_register_info):
1879         Use type_byte_order instead of gdbarch_byte_order.
1880         * p-lang.c (pascal_printstr):
1881         Use type_byte_order instead of gdbarch_byte_order.
1882         * p-valprint.c (pascal_val_print):
1883         Use type_byte_order instead of gdbarch_byte_order.
1884         * printcmd.c (print_scalar_formatted):
1885         Use type_byte_order instead of gdbarch_byte_order.
1886         * solib-darwin.c (darwin_current_sos):
1887         Use type_byte_order instead of gdbarch_byte_order.
1888         * solib-svr4.c (solib_svr4_r_ldsomap):
1889         Use type_byte_order instead of gdbarch_byte_order.
1890         * stap-probe.c (stap_modify_semaphore):
1891         Use type_byte_order instead of gdbarch_byte_order.
1892         * target-float.c (target_float_same_format_p):
1893         Use type_byte_order instead of gdbarch_byte_order.
1894         * valarith.c (scalar_binop):
1895         (value_bit_index):
1896         Use type_byte_order instead of gdbarch_byte_order.
1897         * valops.c (value_cast):
1898         Use type_byte_order instead of gdbarch_byte_order.
1899         * valprint.c (generic_emit_char):
1900         (generic_printstr):
1901         (val_print_string):
1902         Use type_byte_order instead of gdbarch_byte_order.
1903         * value.c (unpack_long):
1904         (unpack_bits_as_long):
1905         (unpack_value_bitfield):
1906         (modify_field):
1907         (pack_long):
1908         (pack_unsigned_long):
1909         Use type_byte_order instead of gdbarch_byte_order.
1910         * findvar.c (unsigned_pointer_to_address):
1911         (signed_pointer_to_address):
1912         (unsigned_address_to_pointer):
1913         (address_to_signed_pointer):
1914         (default_read_var_value):
1915         (default_value_from_register):
1916         Use type_byte_order instead of gdbarch_byte_order.
1917         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1918         Use type_byte_order instead of gdbarch_byte_order.
1919         * riscv-tdep.c (riscv_print_one_register_info):
1920         Use type_byte_order instead of gdbarch_byte_order.
1921
1922 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1923
1924         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1925         (current_ui_gdb_stdin_ptr): Likewise.
1926         (current_ui_gdb_stderr_ptr): Likewise.
1927         (current_ui_gdb_stdlog_ptr): Likewise.
1928         (current_ui_current_uiout_ptr): Likewise.
1929         (gen_ret_current_ui_field_ptr): Remove.
1930
1931 2019-11-21  Tom de Vries  <tdevries@suse.de>
1932
1933         PR gdb/24956
1934         * cli/cli-script.c (execute_control_command): Only switch to
1935         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1936
1937 2019-11-19  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1940         Now static.  Change type of "name".
1941         (tui_set_win_height_command): Don't copy "arg".
1942         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1943         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1944
1945 2019-11-19  Ali Tamur <tamur@google.com>
1946
1947         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1948         "if (attr != nullptr)".
1949         (dwarf2_find_base_address): Likewise.
1950         (dwarf2_build_include_psymtabs): Likewise.
1951         (read_cutu_die_from_dwo): Likewise.
1952         (read_func_scope): Likewise.
1953         (read_call_site_scope): Likewise.
1954         (dwarf2_get_pc_bounds): Likewise.
1955         (dwarf2_record_block_ranges): Likewise.
1956         (dwarf2_add_field): Likewise.
1957         (dwarf2_add_member_fn): Likewise.
1958         (read_structure_type): Likewise.
1959         (read_enumeration_type): Likewise.
1960         (read_array_type): Likewise.
1961         (read_array_order): Likewise.
1962         (read_set_type): Likewise.
1963         (read_common_block): Likewise.
1964         (read_tag_reference_type): Likewise.
1965         (read_tag_string_type): Likewise.
1966         (read_subroutine_type): Likewise.
1967         (read_base_type): Likewise.
1968         (read_subrange_type): Likewise.
1969         (new_symbol): Likewise.
1970         (prepare_one_comp_unit): Likewise.
1971
1972 2019-11-19  Tom Tromey  <tromey@adacore.com>
1973
1974         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1975         result in error when DebugActiveProcess fails.
1976
1977 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1978             Pedro Alves  <palves@redhat.com>
1979
1980         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1981         * target.c (target_stack::push): Call 'unpush' if there's a
1982         target on top of the stack.
1983
1984 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985
1986         * python/py-block.c (blpy_dealloc): Call tp_free.
1987         (blpy_block_syms_dealloc): Likewise.
1988         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1989         * python/py-inferior.c (infpy_dealloc): Likewise.
1990         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1991         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1992         * python/py-symbol.c (sympy_dealloc): Likewise.
1993         * python/py-symtab.c (stpy_dealloc): Likewise.
1994         * python/py-type.c (typy_iterator_dealloc): Likewise.
1995
1996 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1999         constructor instead of using a class initializer.
2000
2001 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2002
2003         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2004         * configure: Regenerate.
2005         * configure.ac: Don't source common.host.
2006         * gdbsupport/common.host: Remove.
2007         * gdbsupport/mingw-strerror.c: Remove.
2008         * gdbsupport/posix-strerror.c: Rename to...
2009         * gdbsupport/safe-strerror.c: ...this.
2010
2011 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2012
2013         * maint.c (scoped_command_stats::print_time): Use localtime_r
2014         instead of localtime (provided through gnulib if necessary).
2015         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2016         of ctime.
2017
2018 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2019
2020         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2021         avoid compile errors.
2022
2023 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2024
2025         * config.in: Regenerate.
2026         * configure: Regenerate.
2027         * gdbsupport/common.m4: No longer check for strerror_r.
2028         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2029         POSIX version of strerror_r, now that gnulib provides it if
2030         necessary.
2031
2032 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2033
2034         * README (`configure' options): Update.
2035
2036 2019-11-14  Tom Tromey  <tromey@adacore.com>
2037
2038         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2039         expected type for the RHS if the LHS is a convenience variable.
2040
2041 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2042
2043         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2044         Provide explicit default and copy constructor.
2045
2046 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2047
2048         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2049         only call Py_INCREF (newbp) in the bppy_pending_object case.
2050
2051 2019-11-13  Tom Tromey  <tromey@adacore.com>
2052
2053         PR build/25182:
2054         * psympriv.h (partial_symbol): Remove static assert.
2055         * symtab.h (general_symbol_info, symbol): Remove static assert.
2056
2057 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * gdbsupport/format.c (format_pieces::format_pieces): Support
2060         printf 'z' size modifier.
2061         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2062         * printcmd.c (ui_printf):  Handle size_t_arg.
2063         * ui-out.c (ui_out::vmessage): Likewise.
2064         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2065         function.
2066         (run_tests): Call test_format_int_sizes.
2067
2068 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2069
2070         * ada-exp.y (write_ambiguous_var): Update.
2071         * buildsym.c (add_symbol_to_list): Update.
2072         * dwarf2read.c (read_variable): Update.
2073         (new_symbol): Update.
2074         * jit.c (finalize_symtab): Update.
2075         * language.c (language_alloc_type_symbol): Update.
2076         * symtab.c (fixup_symbol_section): Update.
2077         (initialize_objfile_symbol_1): Move code to...
2078         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2079         (allocate_symbol): Update.
2080         (allocate_template_symbol): Update.
2081         (get_symbol_address): Update.
2082         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2083         of having as a field, and add a constructor.
2084         (SYMBOL_VALUE): Update.
2085         (SYMBOL_VALUE_ADDRESS): Update.
2086         (SET_SYMBOL_VALUE_ADDRESS): Update.
2087         (SYMBOL_VALUE_BYTES): Update.
2088         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2089         (SYMBOL_BLOCK_VALUE): Update.
2090         (SYMBOL_VALUE_CHAIN): Update.
2091         (SYMBOL_LANGUAGE): Update.
2092         (SYMBOL_SECTION): Update.
2093         (SYMBOL_OBJ_SECTION): Update.
2094         (SYMBOL_SET_LANGUAGE): Update.
2095         (SYMBOL_SET_LINKAGE_NAME): Update.
2096         (SYMBOL_SET_NAMES): Update.
2097         (SYMBOL_NATURAL_NAME): Update.
2098         (SYMBOL_LINKAGE_NAME): Update.
2099         (SYMBOL_DEMANGLED_NAME): Update.
2100         (SYMBOL_SEARCH_NAME): Update.
2101         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2102         (struct symbol): Update.
2103         (struct template_symbol): Update.
2104         (struct rust_vtable_symbol): Update.
2105         * xcoffread.c (SYMBOL_DUP): Update.
2106
2107 2019-11-12  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-layout.c (show_layout): Set current_layout.
2110         (show_source_disasm_command, show_data)
2111         (show_source_or_disasm_and_command): Don't set current_layout.
2112
2113 2019-11-12  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2116
2117 2019-11-12  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-win.c (resize_message): New global.
2120         (show_tui_resize_message): New function.
2121         (tui_async_resize_screen): Print message if requested.
2122         (_initialize_tui_win): Add tui-resize-message setting.
2123         * NEWS: Add entry for new commands.
2124
2125 2019-11-11  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2128         functions.
2129
2130 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2131
2132         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2133
2134 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2137         function.
2138         * python/python-internal.h (gdbpy_lookup_static_symbols):
2139         Declare new function.
2140         * python/python.c (python_GdbMethods): Add
2141         gdb.lookup_static_symbols method.
2142         * NEWS: Mention gdb.lookup_static_symbols.
2143
2144 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2147         static block of current object file first.  Also fix typo in
2148         header comment.
2149
2150 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * stack.c (set_last_displayed_sal): Delete.
2153         (last_displayed_sal_valid): Delete.
2154         (last_displayed_pspace): Delete.
2155         (last_displayed_addr): Delete.
2156         (last_displayed_symtab): Delete.
2157         (last_displayed_line): Delete.
2158         (class last_displayed_symtab_info_type): New.
2159         (last_displayed_symtab_info): New static global variable.
2160         (print_frame_info): Call methods on last_displayed_symtab_info.
2161         (clear_last_displayed_sal): Update header comment, and make use of
2162         last_displayed_symtab_info.
2163         (last_displayed_sal_is_valid): Likewise.
2164         (get_last_displayed_pspace): Likewise.
2165         (get_last_displayed_addr): Likewise.
2166         (get_last_displayed_symtab): Likewise.
2167         (get_last_displayed_line): Likewise.
2168         (get_last_displayed_sal): Likewise.
2169         * stack.h (clear_last_displayed_sal): Update header comment.
2170         (last_displayed_sal_is_valid): Likewise.
2171         (get_last_displayed_pspace): Likewise.
2172         (get_last_displayed_addr): Likewise.
2173         (get_last_displayed_symtab): Likewise.
2174         (get_last_displayed_line): Likewise.
2175         (get_last_displayed_sal): Likewise.
2176
2177 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * stack.c (frame_show_address): Convert return type to bool.
2180         * stack.h (frame_show_address): Likewise, and update header
2181         comment.
2182
2183 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2186         * unittests/vec-utils-selftests.c: New file.
2187         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2188
2189 2019-11-10  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2192         (tui_highlight_win): Likewise.
2193         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2194         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2195         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2196         Don't set can_highlight.
2197
2198 2019-11-10  Tom Tromey  <tom@tromey.com>
2199
2200         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2201         Remove unused declaration.
2202
2203 2019-11-08  Tom Tromey  <tromey@adacore.com>
2204
2205         * top.c (read_command_file): Update.
2206         (command_line_input): Make return type const.
2207         * python/py-gdb-readline.c: Update.
2208         * linespec.c (decode_line_2): Update.
2209         * defs.h (command_line_input): Make return type const.
2210         * cli/cli-script.c (read_next_line): Make return type const.
2211         * ada-lang.c (get_selections): Update.
2212
2213 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2214
2215         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2216         * mi/mi-main.c (output_cores): Likewise.
2217         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2218         (linux_xfer_osdata_modules): Likewise.
2219         * remote.c (register_remote_support_xml): Likewise.
2220         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2221         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2222
2223 2019-11-06  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-interp.c: Don't include readline.h.
2226         * tui/tui-hooks.c: Don't include readline.h.
2227         * symmisc.c: Include tilde.h, not readline.h.
2228         * symfile.c: Include tilde.h, not readline.h.
2229         * source.c: Include tilde.h, not readline.h.
2230         * solib.c: Include tilde.h, not readline.h.
2231         * psymtab.c: Include tilde.h, not readline.h.
2232         * exec.c: Include tilde.h, not readline.h.
2233         * corelow.c: Include tilde.h, not readline.h.
2234         * cli/cli-dump.c: Include tilde.h, not readline.h.
2235         * cli/cli-cmds.c: Don't include readline.h.
2236
2237 2019-11-05  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2240         (tui_disassemble): Set addr_size.
2241         (tui_disasm_window::set_contents): Use addr_size.
2242
2243 2019-11-05  Tom Tromey  <tom@tromey.com>
2244
2245         * rust-lang.c (rust_language_defn): Update.
2246         * python/py-value.c (valpy_string): Call c_get_string.
2247         * p-lang.c (pascal_language_defn): Update.
2248         * opencl-lang.c (opencl_language_defn): Update.
2249         * objc-lang.c (objc_language_defn): Update.
2250         * m2-lang.c (m2_language_defn): Update.
2251         * language.c (unknown_language_defn, auto_language_defn): Update.
2252         (default_get_string): Remove.
2253         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2254         * go-lang.c (go_language_defn): Update.
2255         * f-lang.c (f_language_defn): Update.
2256         * d-lang.c (d_language_defn): Update.
2257         * c-lang.c (c_language_defn, cplus_language_defn)
2258         (asm_language_defn, minimal_language_defn): Update.
2259         * ada-lang.c (ada_language_defn): Update.
2260         * language.h (struct language_defn) <la_get_string>: Remove.
2261         (LA_GET_STRING): Remove.
2262         (default_get_string): Don't declare.
2263
2264 2019-11-05  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-source.h (struct tui_source_window): Inline
2267         constructor.  Remove destructor.
2268         <style_changed, m_observable>: Move to superclass.
2269         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2270         (struct tui_source_window_base): Move private members to end.
2271         <style_changed, m_observable>: Move from tui_source_window.
2272         * tui/tui-winsource.c (tui_copy_source_line): Move from
2273         tui-source.c.  Rename from copy_source_line.  Add special handling
2274         for negative line number.
2275         (tui_source_window_base::style_changed): Move from
2276         tui_source_window.
2277         (tui_source_window_base): Register observer.
2278         (~tui_source_window_base): New.
2279         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2280         rename.
2281         (tui_source_window::set_contents): Use tui_copy_source_line.
2282         (tui_source_window::tui_source_window): Move to tui-source.h.
2283         (tui_source_window::~tui_source_window): Remove.
2284         (tui_source_window::style_changed): Move to superclass.
2285         * tui/tui-disasm.c (tui_disassemble): Create string file with
2286         styling, when possible.  Add "addr_size" parameter.
2287         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2288         Don't compute maximum size.
2289         (len_without_escapes): New function
2290
2291 2019-11-05  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2294         std::string.
2295         * tui/tui-winsource.c (tui_show_source_line): Update.
2296         * tui/tui-source.c (tui_source_window::set_contents): Update.
2297         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2298
2299 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2300
2301         * symtab.h (gdb_static_assert): Put && operator at the beginning
2302         of the line instead of the end.
2303
2304 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2307         and sizeof (symbol).
2308         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2309
2310 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2311
2312         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2313         * configure.host: Mark *-*-solaris2.10* obsolete.
2314         * configure.tgt: Mark Solaris < 11 obsolete.
2315         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2316         Update target triplet.
2317
2318 2019-11-01  Tom Tromey  <tromey@adacore.com>
2319
2320         * utils.c (print_sys_errmsg): Simplify.
2321
2322 2019-11-01  Tom Tromey  <tromey@adacore.com>
2323
2324         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2325
2326 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2327
2328         * configure: Regenerate.
2329         * configure.ac: Remove check for strerror_r.
2330         * gdbsupport/common.m4: Check for strerror_r.
2331
2332 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2333
2334         PR gdb/25124
2335
2336         * arm-tdep.c (arm_per_objfile): Rename to ...
2337         (arm_per_bfd): ... this.
2338         (arm_objfile_data_key): Rename to ...
2339         (arm_bfd_data_key): ... this.
2340         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2341         data.
2342         (arm_record_special_symbol): Likewise.
2343
2344 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2347         end.
2348         * c-typeprint.c (c_print_typedef): Likewise.
2349         * f-typeprint.c (f_print_typedef): Likewise.
2350         * m2-typeprint.c (m2_print_typedef): Likewise.
2351         * p-typeprint.c (pascal_print_typedef): Likewise.
2352         * rust-lang.c (rust_print_typedef): Likewise.
2353         * symtab.c (print_symbol_info): Print a newline after calling
2354         typedef_print.
2355
2356 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * symtab.c (info_module_cmdlist): New variable.
2359         (info_module_command): New function.
2360         (search_module_symbols): New function.
2361         (info_module_subcommand): New function.
2362         (struct info_modules_var_func_options): New struct.
2363         (info_modules_var_func_options_defs): New variable.
2364         (make_info_modules_var_func_options_def_group): New function.
2365         (info_module_functions_command): New function.
2366         (info_module_variables_command): New function.
2367         (info_module_var_func_command_completer): New function.
2368         (_initialize_symtab): Register new 'info module functions' and
2369         'info module variables' commands.
2370         * symtab.h (typedef symbol_search_in_module): New typedef.
2371         (search_module_symbols): Declare new function.
2372         * NEWS: Mention new commands.
2373
2374 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2377         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2378         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2379         MODULES_DOMAIN.
2380         (scan_partial_symbols): Only create partial module symbols for non
2381         declarations.
2382         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2383         and MODULES_DOMAIN.
2384         * symtab.c (search_domain_name): Likewise.
2385         (search_symbols): Likewise.
2386         (print_symbol_info): Likewise.
2387         (symtab_symbol_info): Likewise.
2388         (info_modules_command): New function.
2389         (_initialize_symtab): Register 'info modules' command.
2390         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2391         * NEWS: Mention new 'info modules' command.
2392
2393 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2396         and $_gdb_maint_setting_str.
2397
2398 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2399
2400         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2401         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2402         (str_value_from_setting, gdb_setting_str_internal_fn)
2403         (gdb_maint_setting_str_internal_fn): New functions.
2404         (_initialize_cli_cmds): Define the new convenience functions.
2405         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2406         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2407
2408 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2409
2410         * agent.c (set_can_use_agent): When the setting is turned on,
2411         look up agent symbols if we don't have them yet.
2412         (agent_new_objfile): Don't look up agent symbols when the agent
2413         setting is off.
2414
2415 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2416
2417         * config.in: Regenerate.
2418
2419 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2420
2421         * configure: Regenerate.
2422         * configure.ac: Check for strerror_r.
2423         * gdbsupport/common-utils.h (safe_strerror): Change return value
2424         to const char * and document that this function is now threadsafe.
2425         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2426         thread_local and call strerror_r, if available.
2427         * utils.c (perror_string): Update.
2428         (print_sys_errmsg): Update.
2429
2430 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2431
2432         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2433         objfile_key.
2434         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2435         objfile to fetch per-bfd data.
2436         (arm_find_exidx_entry): Likewise.
2437
2438 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * gdbsupport/agent.c (debug_agent): Change type to bool.
2441         (use_agent): Likewise.
2442         (all_agent_symbols_look_up): Likewise.
2443         (agent_loaded_p): Change return value to bool.
2444         (agent_look_up_symbols): Update.
2445         (agent_capability_check): Change return value to bool.
2446         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2447         (debug_agent): Change type to bool.
2448         (use_agent): Likewise.
2449         (agent_capability_check): Change return value to bool.
2450
2451 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2452
2453         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2454         (build_minimal_symbol_hash_tables): Code to clear the table moved
2455         to clear_minimal_symbol_hash_tables.
2456         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2457         when needed.
2458
2459 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2460
2461         * infcmd.c: Remove includes.
2462         * infrun.c: Remove includes.
2463
2464 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2465
2466         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2467         (grow_vect): Remove declaration.
2468         (ada_type_of_array): Remove declaration.
2469         (ada_update_initial_language): Remove declaration.
2470         (ada_fold_name): Remove declaration.
2471         (ada_fill_in_ada_prototype): Remove declaration.
2472         (user_select_syms): Remove declaration.
2473         (get_selections): Remove declaration.
2474         (ada_tag_type): Remove declaration.
2475         (ada_value_tag): Remove declaration.
2476         (ada_is_others_clause): Remove declaration.
2477         (ada_in_variant): Remove declaration.
2478         (ada_value_struct_elt): Remove declaration.
2479         (ada_attribute_name): Remove declaration.
2480         (ada_system_address_type): Remove declaration.
2481         * ada-lang.c (ada_watch_location_expression): Make static.
2482         (GROW_VECT): Move here from ada-lang.h.
2483         (grow_vect): Make static.
2484         (ada_update_initial_language): Make static.
2485         (ada_fold_name): Make static.
2486         (ada_type_of_array): Make static.
2487         (encoded_ordered_before): Move up.
2488         (sort_choices): Move up.
2489         (print_signatures): Move up.
2490         (ada_print_symbol_signature): Move up.
2491         (get_selections): Move up and make static.
2492         (user_select_syms): Move up and make static.
2493         (ada_value_struct_elt): Move up and make static.
2494         (ada_tag_type): Make static.
2495         (ada_value_tag): Make static.
2496         (ada_is_others_clause): Make static.
2497         (ada_in_variant): Make static.
2498         (ada_attribute_name): Make static.
2499
2500 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2501
2502         * ada-lang.c: Remove includes.
2503         * ada-typeprint.c: Remove includes.
2504         * ada-valprint.c: Remove includes.
2505
2506 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2507
2508         * addrmap.c: Add static assertions of type size, moved from
2509         _initialize_addrmap.
2510         (_initialize_addrmap): Remove.
2511
2512 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2513
2514         * coffread.c (record_minimal_symbol): Update.
2515         (process_coff_symbol): Update.
2516         * dbxread.c (read_dbx_symtab): Update.
2517         * dwarf2read.c (add_partial_symbol): Update.
2518         (fixup_go_packaging): Update.
2519         (load_partial_dies): Update.
2520         (new_symbol): Update.
2521         * elfread.c (record_minimal_symbol): Change signature to use
2522         gdb::string_view instead of name+len.
2523         (elf_symtab_read): Update.
2524         (elf_rel_plt_read): Update.
2525         * mdebugread.c (parse_partial_symbols): Update.
2526         (handle_psymbol_enumerators): Update.
2527         (new_symbol): Update.
2528         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2529         to use gdb::string_view instead of name+len.
2530         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2531         * psympriv.h (add_psymbol_to_list): Likewise.
2532         * psymtab.c (add_psymbol_to_bcache): Likewise.
2533         (add_psymbol_to_list): Likewise.
2534         * stabsread.c (define_symbol): Update.
2535         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2536         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2537         (symbol_set_names): Likewise.
2538         * xcoffread.c (scan_xcoff_symtab): Update.
2539
2540 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2541
2542         * symtab.h (symbol_set_names): Document that copy_name must be
2543         set to true for non-nullterminated strings.
2544         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2545         linkage_name if the entry was not found and we need to demangle.
2546
2547 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2548
2549         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2550         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2551         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2552         * gdbsupport/gdb_binary_search.h: New file.
2553
2554 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2555
2556         * NEWS: Mention new --with-system-gdbinit-dir option.
2557         * config.in: Regenerate.
2558         * configure: Regenerate.
2559         * configure.ac: Add new option --with-system-gdbinit-dir.
2560         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2561         for a ".gdb" suffix.
2562         * main.c (get_init_files): Change system_gdbinit argument to
2563         a vector and return the files in SYSTEM_GDBINIT_DIR in
2564         addition to SYSTEM_GDBINIT.
2565         (captured_main_1): Update.
2566         (print_gdb_help): Update.
2567         * top.c (print_gdb_configuration): Also print the value of
2568         SYSTEM_GDBINIT_DIR.
2569
2570 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2571
2572         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2573         that takes gdb::string_view arguments.
2574
2575 2019-10-26  Tom de Vries  <tdevries@suse.de>
2576
2577         * aarch64-linux-tdep.c: Fix typos in comments.
2578         * aarch64-tdep.c: Same.
2579         * ada-lang.c: Same.
2580         * amd64-nat.c: Same.
2581         * arc-tdep.c: Same.
2582         * arch/aarch64-insn.c: Same.
2583         * block.c: Same.
2584         * breakpoint.h: Same.
2585         * btrace.h: Same.
2586         * c-varobj.c: Same.
2587         * cli/cli-decode.c: Same.
2588         * cli/cli-script.c: Same.
2589         * cli/cli-utils.h: Same.
2590         * coff-pe-read.c: Same.
2591         * coffread.c: Same.
2592         * compile/compile-cplus-symbols.c: Same.
2593         * compile/compile-object-run.c: Same.
2594         * completer.c: Same.
2595         * corelow.c: Same.
2596         * cp-support.c: Same.
2597         * demangle.c: Same.
2598         * dwarf-index-write.c: Same.
2599         * dwarf2-frame.c: Same.
2600         * dwarf2-frame.h: Same.
2601         * eval.c: Same.
2602         * frame-base.h: Same.
2603         * frame.h: Same.
2604         * gdbcmd.h: Same.
2605         * gdbtypes.h: Same.
2606         * gnu-nat.c: Same.
2607         * guile/scm-objfile.c: Same.
2608         * i386-tdep.c: Same.
2609         * i386-tdep.h: Same.
2610         * infcall.c: Same.
2611         * infcall.h: Same.
2612         * linux-nat.c: Same.
2613         * m68k-tdep.c: Same.
2614         * macroexp.c: Same.
2615         * memattr.c: Same.
2616         * mi/mi-cmd-disas.c: Same.
2617         * mi/mi-getopt.h: Same.
2618         * mi/mi-main.c: Same.
2619         * minsyms.c: Same.
2620         * nat/aarch64-sve-linux-sigcontext.h: Same.
2621         * objfiles.h: Same.
2622         * ppc-linux-nat.c: Same.
2623         * ppc-linux-tdep.c: Same.
2624         * ppc-tdep.h: Same.
2625         * progspace.h: Same.
2626         * prologue-value.h: Same.
2627         * python/py-evtregistry.c: Same.
2628         * python/py-instruction.h: Same.
2629         * record-btrace.c: Same.
2630         * record-full.c: Same.
2631         * remote.c: Same.
2632         * rs6000-tdep.c: Same.
2633         * ser-tcp.c: Same.
2634         * sol-thread.c: Same.
2635         * sparc-sol2-tdep.c: Same.
2636         * sparc64-tdep.c: Same.
2637         * stabsread.c: Same.
2638         * symfile.c: Same.
2639         * symtab.h: Same.
2640         * target.c: Same.
2641         * tracepoint.c: Same.
2642         * tui/tui-data.h: Same.
2643         * tui/tui-io.c: Same.
2644         * tui/tui-win.c: Same.
2645         * tui/tui.c: Same.
2646         * unittests/rsp-low-selftests.c: Same.
2647         * user-regs.h: Same.
2648         * utils.c: Same.
2649         * utils.h: Same.
2650         * valarith.c: Same.
2651         * valops.c: Same.
2652         * valprint.c: Same.
2653         * valprint.h: Same.
2654         * value.c: Same.
2655         * value.h: Same.
2656         * varobj.c: Same.
2657         * x86-nat.h: Same.
2658         * xtensa-tdep.c: Same.
2659
2660 2019-10-25  Ali Tamur <tamur@google.com>
2661
2662         * charset.c (find_charset_names): Reflect API change.
2663
2664 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2665
2666         * symtab.c (struct demangled_name_entry): Change demangled name
2667         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2668         part of the struct anymore.
2669         (symbol_set_names): No longer obstack allocate + copy the demangled
2670         name, just store the allocated name from bfd.
2671
2672 2019-10-25  Tom Tromey  <tromey@adacore.com>
2673
2674         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2675         (bsearch_cie_cmp, add_cie): Remove.
2676         (find_cie): Reimplement.
2677         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2678         (dwarf2_build_frame_info): Update.
2679
2680 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2681
2682         PR gdb/25126
2683         * symfile.c (reread_symbols): Call forget_cached_source_info to
2684         clear the stale source cache.
2685
2686 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2687
2688         * configure: Regenerate.
2689         * configure.ac: Remove code that sets python_has_threads.
2690
2691 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2692
2693         * config.in: Regenerate.
2694         * configure: Regenerate.
2695         * configure.ac: Remove the code that uses sed to get the python
2696         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2697
2698 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2701         error paths.
2702
2703 2019-10-23  Tom Tromey  <tom@tromey.com>
2704
2705         * arc-tdep.c: Remove ".." from include.
2706         * frv-tdep.c: Remove ".." from include.
2707         * lm32-tdep.c: Remove ".." from include.
2708         * microblaze-tdep.c: Remove ".." from include.
2709         * or1k-tdep.h: Remove ".." from include.
2710         * s12z-tdep.c: Remove ".." from include.
2711         * Makefile.in (OPCODES_CFLAGS): Add comment.
2712         (TOP_CFLAGS): New variable.
2713         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2714
2715 2019-10-23  Tom Tromey  <tom@tromey.com>
2716
2717         * Makefile.in (READLINE_DIR): Update.
2718
2719 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2720
2721         * infcall.c (call_function_by_hand_dummy): Fix the function
2722         comment.  And extract out a code section into...
2723         (reserve_stack_space): ...this new function.
2724
2725 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2726
2727         * infcall.c (value_arg_coerce): Remove an unused parameter.
2728         (call_function_by_hand_dummy): Update the call to
2729         'value_arg_coerce'.
2730
2731 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2732
2733         * infcall.c (call_function_by_hand_dummy): Refactor.
2734
2735 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2736
2737         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2738
2739 2019-10-23  Tom Tromey  <tom@tromey.com>
2740
2741         * configure: Rebuild.
2742         * configure.ac: Don't check for sigprocmask.
2743         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2744
2745 2019-10-23  Tom Tromey  <tom@tromey.com>
2746
2747         * configure: Rebuild.
2748         * acinclude.m4: Use m4_include, not sinclude.
2749
2750 2019-10-23  Tom de Vries  <tdevries@suse.de>
2751
2752         PR breakpoints/24687
2753         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2754
2755 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2756
2757         * symtab.c (struct demangled_name_entry) <language>: Change from
2758         bitfield to regular variable.
2759
2760 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2761
2762         * symtab.c (struct demangled_name_entry): Add a constructor.
2763         (free_demangled_name_entry): New function to call the destructor
2764         for demangled_name_entry.
2765         (create_demangled_names_hash): Pass free_demangled_name_entry to
2766         htab_create_alloc.
2767         (symbol_set_names): Call placement new for demangled_name_entry.
2768         * utils.c: No longer include xxhash.h here, now that fast_hash
2769         is inlined in the header.
2770         * utils.h: Instead, include it here.
2771
2772 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2773
2774         * Makefile.in: Link with libxxhash.
2775         * config.in: Regenerate.
2776         * configure: Regenerate.
2777         * configure.ac: Search for libxxhash.
2778         * utils.c (fast_hash): Use xxhash if present.
2779
2780 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2781
2782         * utils.h (fast_hash): New function.
2783         * symtab.c (hash_demangled_name_entry): Call new function
2784         fast_hash.
2785
2786 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2787
2788         * symtab.c (struct demangled_name_entry): Change type of mangled
2789         to gdb::string_view. Also adds a constructor that takes the
2790         mangled name.
2791         (hash_demangled_name_entry): Update.
2792         (eq_demangled_name_entry): Update.
2793         (free_demangled_name_entry): New function to call the destructor
2794         now that this is not a POD anymore.
2795         (create_demangled_names_hash): Pass free_demangled_name_entry to
2796         htab_create_alloc.
2797         (symbol_set_names): Update.
2798
2799 2019-10-21  Ali Tamur  <tamu@google.com>
2800
2801         * dwarf2read.c (dir_index): Change type.
2802         (file_name_index): Likewise.
2803         (line_header::include_dir_at): Change comment and implementation on
2804         whether it is DWARF 5.
2805         (line_header::is_valid_file_index): New function.
2806         (line_header::file_name_at): Change comment and implementation on
2807         whether it is DWARF 5.
2808         (line_header::file_names): Change to private field renamed as
2809         m_file_names and introduce a new accessor method.
2810         (line_header::file_names_size): New method.
2811         (line_header::include_dirs): Change to private field and rename as
2812         m_include_dirs.
2813         (dw2_get_file_names_reader): Define local var at a smaller scope and
2814         reflect API change.
2815         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2816         (process_structure_scope): Likewise.
2817         (line_header::add_include_dir): Change message and reflect renaming.
2818         (line_header::add_file_name): Likewise.
2819         (read_formatted_entries): Handle DW_FORM_data16.
2820         (dwarf_decode_line_header): Fix line header length calculation.
2821         (psymtab_include_file_name): Change comment and API.
2822         (lnp_state_machine::m_file): Update comment and reflect type change.
2823         (lnp_state_machine::record_line): Reflect type change.
2824         (dwarf_decode_lines): Reflect API change.
2825         (file_file_name): Likewise.
2826         (file_full_name): Likewise.
2827
2828 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2831
2832 2019-10-21  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2835
2836 2019-10-21  Tom Tromey  <tom@tromey.com>
2837
2838         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2839         NM_H.   Use AC_CONFIG_LINKS.
2840         * configure: Rebuild.
2841         * Makefile.in (NM_H): New variable.
2842         (generated_files): Add NM_H.  Remove gcore.
2843         (nm.h, stamp-nmh): New targets.
2844
2845 2019-10-20  Tom Tromey  <tom@tromey.com>
2846
2847         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2848         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2849         obsolete comment.
2850         (put_objfile_before): Now static.
2851
2852 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2853
2854         * gdbsupport/common-utils.h (startswith): Change return type to
2855         bool.
2856
2857 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2858
2859         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2860         * breakpoint.c (bp_locations_compare): Rename to...
2861         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2862         (update_global_location_list): Use std::sort instead of qsort.
2863         * buildsym.c (compare_line_numbers): Rename to...
2864         (lte_is_less_than): ...this, and change to std::sort semantics.
2865         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2866         instead of qsort.
2867         * disasm.c (compare_lines): Rename to...
2868         (line_is_less_than): ...this, and change to std::sort semantics.
2869         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2870         of qsort.
2871         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2872         (fde_is_less_than): ...this, and change to std::sort semantics.
2873         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2874         * mdebugread.c (compare_blocks):
2875         (block_is_less_than): ...this, and change to std::sort semantics.
2876         (sort_blocks): Call std::sort instead of qsort.
2877         * objfiles.c (qsort_cmp): Rename to...
2878         (sort_cmp): ...this, and change to std::sort semantics.
2879         (update_section_map): Call std::sort instead of qsort.
2880         * remote.c (compare_pnums): Remove.
2881         (map_regcache_remote_table): Call std::sort instead of qsort.
2882         * utils.c (compare_positive_ints): Remove.
2883         * utils.h (compare_positive_ints): Remove.
2884         * xcoffread.c (compare_lte): Remove.
2885         (arrange_linetable): Call std::sort instead of qsort.
2886
2887 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2888
2889         * symfile.c (init_entry_point_info): Fix typo.
2890         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2891
2892 2019-10-18  Tom de Vries  <tdevries@suse.de>
2893
2894         * aarch64-tdep.c: Fix typos in comments.
2895         * ada-lang.c: Same.
2896         * ada-tasks.c: Same.
2897         * alpha-tdep.c: Same.
2898         * alpha-tdep.h: Same.
2899         * amd64-nat.c: Same.
2900         * amd64-windows-tdep.c: Same.
2901         * arc-tdep.c: Same.
2902         * arc-tdep.h: Same.
2903         * arch-utils.c: Same.
2904         * arm-nbsd-tdep.c: Same.
2905         * arm-tdep.c: Same.
2906         * ax-gdb.c: Same.
2907         * blockframe.c: Same.
2908         * btrace.c: Same.
2909         * c-varobj.c: Same.
2910         * coff-pe-read.c: Same.
2911         * coffread.c: Same.
2912         * cris-tdep.c: Same.
2913         * darwin-nat.c: Same.
2914         * dbxread.c: Same.
2915         * dcache.c: Same.
2916         * disasm.c: Same.
2917         * dtrace-probe.c: Same.
2918         * dwarf-index-write.c: Same.
2919         * dwarf2-frame-tailcall.c: Same.
2920         * dwarf2-frame.c: Same.
2921         * dwarf2read.c: Same.
2922         * eval.c: Same.
2923         * exceptions.c: Same.
2924         * fbsd-tdep.c: Same.
2925         * findvar.c: Same.
2926         * frame.c: Same.
2927         * frv-tdep.c: Same.
2928         * gnu-v3-abi.c: Same.
2929         * go32-nat.c: Same.
2930         * h8300-tdep.c: Same.
2931         * hppa-tdep.c: Same.
2932         * i386-linux-tdep.c: Same.
2933         * i386-tdep.c: Same.
2934         * ia64-libunwind-tdep.c: Same.
2935         * ia64-tdep.c: Same.
2936         * infcmd.c: Same.
2937         * infrun.c: Same.
2938         * linespec.c: Same.
2939         * linux-nat.c: Same.
2940         * linux-thread-db.c: Same.
2941         * machoread.c: Same.
2942         * mdebugread.c: Same.
2943         * mep-tdep.c: Same.
2944         * mn10300-tdep.c: Same.
2945         * namespace.c: Same.
2946         * objfiles.c: Same.
2947         * opencl-lang.c: Same.
2948         * or1k-tdep.c: Same.
2949         * osabi.c: Same.
2950         * ppc-linux-nat.c: Same.
2951         * ppc-linux-tdep.c: Same.
2952         * ppc-sysv-tdep.c: Same.
2953         * printcmd.c: Same.
2954         * procfs.c: Same.
2955         * record-btrace.c: Same.
2956         * record-full.c: Same.
2957         * remote-fileio.c: Same.
2958         * remote.c: Same.
2959         * rs6000-tdep.c: Same.
2960         * s12z-tdep.c: Same.
2961         * score-tdep.c: Same.
2962         * ser-base.c: Same.
2963         * ser-go32.c: Same.
2964         * skip.c: Same.
2965         * sol-thread.c: Same.
2966         * solib-svr4.c: Same.
2967         * solib.c: Same.
2968         * source.c: Same.
2969         * sparc-nat.c: Same.
2970         * sparc-sol2-tdep.c: Same.
2971         * sparc-tdep.c: Same.
2972         * sparc64-tdep.c: Same.
2973         * stabsread.c: Same.
2974         * stack.c: Same.
2975         * symfile.c: Same.
2976         * symtab.c: Same.
2977         * target-descriptions.c: Same.
2978         * target-float.c: Same.
2979         * thread.c: Same.
2980         * utils.c: Same.
2981         * valops.c: Same.
2982         * valprint.c: Same.
2983         * value.c: Same.
2984         * varobj.c: Same.
2985         * windows-nat.c: Same.
2986         * xcoffread.c: Same.
2987         * xstormy16-tdep.c: Same.
2988         * xtensa-tdep.c: Same.
2989
2990 2019-10-17  Tom Tromey  <tromey@adacore.com>
2991
2992         * configure: Rebuild.
2993         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2994         in AC_CONFIG_FILES invocation.
2995         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2996         new-style config.status invocation.
2997
2998 2019-10-17  Tom de Vries  <tdevries@suse.de>
2999
3000         * arm-nbsd-nat.c: Fix typos in comments.
3001         * arm-tdep.c: Same.
3002         * darwin-nat-info.c: Same.
3003         * dwarf2read.c: Same.
3004         * elfread.c: Same.
3005         * event-top.c: Same.
3006         * findvar.c: Same.
3007         * gdbtypes.c: Same.
3008         * hppa-tdep.c: Same.
3009         * i386-tdep.c: Same.
3010         * jit.c: Same.
3011         * main.c: Same.
3012         * mdebugread.c: Same.
3013         * moxie-tdep.c: Same.
3014         * nto-procfs.c: Same.
3015         * osabi.c: Same.
3016         * ppc-linux-tdep.c: Same.
3017         * remote.c: Same.
3018         * riscv-tdep.c: Same.
3019         * s390-tdep.c: Same.
3020         * sh-tdep.c: Same.
3021         * sparc-linux-tdep.c: Same.
3022         * sparc-nat.c: Same.
3023         * stack.c: Same.
3024         * target-descriptions.c: Same.
3025         * top.c: Same.
3026         * varobj.c: Same.
3027
3028 2019-10-16  Tom Tromey  <tom@tromey.com>
3029
3030         * objfiles.h (struct objfile) <original_name>: Now const.
3031
3032 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3033
3034         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3035         pass on to sigsetjmp's second argument.
3036         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3037
3038 2019-10-16  Keith Seitz  <keiths@redhat.com>
3039
3040         PR gdb/23567
3041         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3042         sections whose size is greater than the file size.
3043
3044 2019-10-16  Jim Wilson  <jimw@sifive.com>
3045
3046         * riscv-tdep.c (riscv_gcc_target_options): New.
3047         (riscv_gnu_triplet_regexp): New.
3048         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3049         set_gdbarch_gnu_triplet_regexp.
3050
3051 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3052
3053         * Makefile.in: Add xml-builtin.h.
3054         * features/feature_to_c.sh: Add an include for xml-builtin.h
3055         to ensure that the compiler checks that the types match.
3056         * xml-builtin.h: New file.
3057         * xml-support.c (fetch_xml_builtin): Add missing const.
3058         * xml-support.h: Remove declaration of xml_builtins.
3059
3060 2019-10-16  Tom de Vries  <tdevries@suse.de>
3061
3062         PR tdep/25096
3063         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3064         (amd64_classify_aggregate): ... here.
3065         (amd64_classify_aggregate_field): Handled fiels of nested structs
3066         recursively.
3067
3068 2019-10-16  Tom de Vries  <tdevries@suse.de>
3069
3070         PR tdep/24104
3071         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3072         that handles 'theclass'.
3073
3074 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3075
3076         * linespec.c (decode_digits_ordinary): Update comment.
3077         * make-target-delegates: No longer need to handle VEC case.
3078         * memrange.c (normalize_mem_ranges): Update comment.
3079         * namespace.c (add_using_directive): Update comment.
3080         * objc-lang.c (uniquify_strings): Update comment.
3081         * ppc-linux-nat.c (struct thread_points): Update comment.
3082         * probe.h (find_probes_in_objfile): Update comment.
3083         * target.h (enum flash_preserve_mode): Update comment.
3084         * varobj.c (varobj_restrict_range): Update comment.
3085         * varobj.h (varobj_list_children): Update comment.
3086
3087 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * Makefile.in: Remove references to vec.h and vec.c.
3090         * aarch64-tdep.c: No longer include vec.h.
3091         * ada-lang.c: Likewise.
3092         * ada-lang.h: Likewise.
3093         * arm-tdep.c: Likewise.
3094         * ax.h: Likewise.
3095         * breakpoint.h: Likewise.
3096         * charset.c: Likewise.
3097         * cp-support.h: Likewise.
3098         * dtrace-probe.c: Likewise.
3099         * dwarf2read.c: Likewise.
3100         * extension.h: Likewise.
3101         * gdb_bfd.c: Likewise.
3102         * gdbsupport/gdb_vecs.h: Likewise.
3103         * gdbsupport/vec.c: Remove.
3104         * gdbsupport/vec.h: Remove.
3105         * gdbthread.h: Likewise.
3106         * guile/scm-type.c: Likewise.
3107         * inline-frame.c: Likewise.
3108         * machoread.c: Likewise.
3109         * memattr.c: Likewise.
3110         * memrange.h: Likewise.
3111         * namespace.h: Likewise.
3112         * nat/linux-btrace.h: Likewise.
3113         * osdata.c: Likewise.
3114         * parser-defs.h: Likewise.
3115         * progspace.h: Likewise.
3116         * python/py-type.c: Likewise.
3117         * record-btrace.c: Likewise.
3118         * rust-exp.y: Likewise.
3119         * solib-target.c: Likewise.
3120         * stap-probe.c: Likewise.
3121         * target-descriptions.c: Likewise.
3122         * target-memory.c: Likewise.
3123         * target.h: Likewise.
3124         * varobj.c: Likewise.
3125         * varobj.h: Likewise.
3126         * xml-support.h: Likewise.
3127
3128 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3131         Update for new std::vector based implementation.
3132         (process_psymtab_comp_unit_reader): Likewise.
3133         (scan_partial_symbols): Likewise.
3134         (recursively_compute_inclusions): Likewise.
3135         (compute_compunit_symtab_includes): Likewise.
3136         (process_imported_unit_die): Likewise.
3137         (queue_and_load_dwo_tu): Likewise.
3138         (follow_die_sig_1): Likewise.
3139         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3140         (typedef dwarf2_per_cu_ptr): Remove.
3141         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3142         function.
3143         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3144         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3145         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3146         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3147         std::vector.
3148
3149 2019-10-15  Tom Tromey  <tromey@adacore.com>
3150
3151         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3152         TID.
3153
3154 2019-10-15  Tom Tromey  <tromey@adacore.com>
3155
3156         * windows-nat.c (windows_nat_target::fetch_registers)
3157         (windows_nat_target::store_registers): Rename "pid" to "tid".
3158
3159 2019-10-15  Tom Tromey  <tromey@adacore.com>
3160
3161         * gdbarch.h, gdbarch.c: Rebuild.
3162         * gdbarch.sh (gcc_target_options): Change return type to
3163         std::string.
3164         * compile/compile.c (get_args): Update.
3165         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3166         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3167         std::string.
3168         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3169         std::string.
3170         * arch-utils.c (default_gcc_target_options): Return std::string.
3171         * arch-utils.h (default_gcc_target_options): Return std::string.
3172         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3173
3174 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3175
3176         * breakpoint.c (breakpoint_chain): Make static.
3177         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3178         of accessing breakpoint_chain.
3179
3180 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3181
3182         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3183         to a gdb::function_view and return value to bool.
3184         * breakpoint.h (iterate_over_breakpoints): Likewise.
3185         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3186         (pop_dummy_frame): Update.
3187         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3188         (gdbscm_breakpoints): Update.
3189         * python/py-breakpoint.c (build_bp_list): Update.
3190         (gdbpy_breakpoints): Update.
3191         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3192         Update.
3193         (bpfinishpy_handle_stop): Update.
3194         (bpfinishpy_handle_exit): Update.
3195         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3196         (svr4_update_solib_event_breakpoints): Update.
3197
3198 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3199
3200         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3201         when unwrapping single-field structs.
3202
3203 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3204
3205         * dwarf2read.c: Remove includes.
3206
3207 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3208
3209         * ui-out.c (ui_out::call_do_message): Silence
3210         -Wformat-nonliteral warning.
3211
3212 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3213
3214         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3215         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3216         include: readline/tilde.h.
3217
3218 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3219
3220         * remote.c (remote_target::get_trace_status): Remove declaration of
3221         trace_regblock_size.
3222
3223 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3224
3225         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3226         (show_user): Remove declaration of cmdlist.
3227         * cli/cli-cmds.h (max_user_call_depth): Declare.
3228         * cli/cli-script.c (execute_user_command): Remove declaration
3229         of max_user_call_depth.
3230
3231 2019-10-11  Jim Wilson  <jimw@sifive.com>
3232
3233         * gdbsupport/print-utils.h (pulongest): Fix comment.
3234         (plongest): Likewise.
3235         (phex): Add missing comment, mention leading zeros.
3236         (phex_nz): Add mention of no leading zeros to comment.
3237
3238         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3239         plongest instead of unsigned long long cast.
3240
3241 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3242
3243         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3244         for external_editor_command and gdbtk_test.
3245
3246 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3247
3248         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3249         * varobj.c (varobjdebug): Move comment to...
3250         * varobj.h (varobjdebug): ...here, and declare.
3251
3252 2019-10-09  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3255         erase_data_content.
3256
3257 2019-10-09  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3260         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3261         * tui/tui-command.c (tui_cmd_window::resize)
3262         (tui_refresh_cmd_win): Update.
3263         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3264         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3265         * tui/tui-data.c (~tui_gen_win_info): Remove.
3266         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3267         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3268         (tui_redisplay_readline, tui_mld_flush)
3269         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3270         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3271         (tui_data_window::erase_data_content)
3272         (tui_data_item_window::rerender)
3273         (tui_data_item_window::refresh_window): Update.
3274         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3275         (box_win, tui_gen_win_info::make_window)
3276         (tui_gen_win_info::make_visible): Update.
3277         (tui_delete_win): Remove.
3278         * tui/tui-winsource.c
3279         (tui_source_window_base::do_erase_source_content): Update.
3280         (tui_show_source_line, tui_source_window_base::update_tab_width)
3281         (tui_source_window_base::update_exec_info): Update.
3282         * tui/tui-data.h (struct curses_deleter): New.
3283         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3284         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3285
3286 2019-10-09  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3289
3290 2019-10-09  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3293         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3294
3295 2019-10-09  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3298         window height directly.
3299         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3300         declare.
3301         * tui/tui-layout.c (tui_default_win_height): Remove.
3302         (tui_default_win_viewport_height): Remove.
3303
3304 2019-10-09  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui.h: Remove comments.
3307
3308 2019-10-09  Tom de Vries  <tdevries@suse.de>
3309
3310         * python/lib/gdb/printer/bound_registers.py: Use
3311         '^builtin_type_bound128' as regexp argument for
3312         add_builtin_pretty_printer.
3313
3314 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3315
3316         * guile/guile.c (guile_extension_script_ops): Remove forward
3317         declaration and mark as static.
3318         (guile_script_ops): Likewise.
3319         (extension_language_guile): Move further down in the file so
3320         it can reference the definitions for guile_{extension_,}script_ops.
3321
3322 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3323
3324         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3325         except SORTL, DFLTCC, and KDSA.
3326
3327 2019-10-08  Tom Tromey  <tromey@adacore.com>
3328
3329         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3330         (struct safe_symbol_file_add_args): Remove.
3331
3332 2019-10-08  Tom Tromey  <tromey@adacore.com>
3333
3334         * windows-nat.c: Don't include buildsym-legacy.h.
3335
3336 2019-10-08  Tom Tromey  <tromey@adacore.com>
3337
3338         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3339
3340 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3341
3342         * gdbtypes.c (overload_debug): Move comment to header.
3343         * gdbtypes.h (overload_debug): Declare.
3344         * valops.c: Remove declaration of overload_debug, instead
3345         include gdbtypes.h.
3346
3347 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3348
3349         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3350         through _().
3351         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3352         move comment...
3353         * language.h (lang_frame_mismatch_warn): ... here. Also add
3354         declaration.
3355         * top.c (lang_frame_mismatch_warn): Remove declaration.
3356         (check_frame_language_change): Pass lang_frame_mismatch_warn
3357         through _().
3358
3359 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3360
3361         * c-lang.h (vtbl_ptr_name): Declare.
3362         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3363         it from the header.
3364         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3365
3366 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3367
3368         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3369         gdb_static_assert.
3370
3371 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3372
3373         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3374         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3375         * ctfread.c: New file.
3376         * ctfread.h: New file.
3377         * elfread.c: Include ctfread.h.
3378         (struct elfinfo text_p): New member ctfsect.
3379         (elf_locate_sections): Mark CTF section.
3380         (elf_symfile_read): Call elfctf_build_psymtabs.
3381         * Makefile.in (LIBCTF): Add.
3382         (CLIBS): Use it.
3383         (CDEPS): Likewise.
3384         (DIST): Add ctfread.c.
3385
3386 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * ctfread.c (struct nextfield): Renamed to ...
3389         (struct ctf_nextfield): ... this.
3390         (struct field_info): Renamed to ...
3391         (strut ctf_field_info): ... this.
3392         (attach_fields_to_type): Update for renamed structures.
3393         (ctf_add_member_cb): Likewise.
3394         (ctf_add_enum_member_cb): Likewise.
3395         (process_struct_members): Likewise.
3396         (process_enum_type): Likewise.
3397
3398 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3399
3400         * tracectf.h: Rename, was ctf.h.
3401         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3402         * tracefile.c: Likewise.
3403         * tracepoint.c: Remove unused include ctf.h.
3404         * mi/mi-main.c: Likewise.
3405         * Makefile.in Replace ctf.c with tracectf.c.
3406
3407 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3408
3409         * version.in: Change version number to "9.0.50.DATE-git".
3410
3411 2019-10-03  Tom Tromey  <tom@tromey.com>
3412
3413         PR rust/24976:
3414         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3415
3416 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3419         cp_search_name_hash.
3420         * NEWS: Add entry about nested function support.
3421
3422 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3423             Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3426         for nested static variables when searchin VAR_DOMAIN.
3427         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3428         global scope, update comment.
3429         (add_partial_subprogram): Call add_partial_subprogram recursively
3430         for nested subroutines when processinng Fortran.
3431         (load_partial_dies): Process the child entities of a subprogram
3432         when processing Fortran.
3433         (partial_die_parent_scope): Handle building scope
3434         for Fortran nested functions.
3435         (process_die): Record that nested functions have a scope.
3436         (new_symbol): Always record Fortran subprograms on the global
3437         symbol list.
3438         (determine_prefix): How to build the prefix for Fortran
3439         subprograms.
3440
3441 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3444         have just sent the thread a SIGSTOP and are waiting for it to
3445         arrive.
3446
3447 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * btrace.c (btrace_add_pc): Remove whitespace before the template
3450         parameter in 'std::vector <...>'.
3451         (parse_xml_btrace_block): Likewise.
3452         (btrace_maint_decode_pt): Likewise.
3453         (btrace_maint_update_packets): Likewise.
3454         (btrace_maint_print_packets): Likewise.
3455         * btrace.h (struct btrace_maint_info): Likewise.
3456         * dwarf2read.c (struct type_unit_group): Likewise.
3457         (build_type_psymtabs_reader): Likewise.
3458         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3459         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3460         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3461
3462 2019-10-03  Tom de Vries  <tdevries@suse.de>
3463
3464         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3465         the first line of the help text for set/show style metadata.
3466
3467 2019-10-02  Tom Tromey  <tromey@adacore.com>
3468
3469         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3470         * gdbsupport/common-inferior.c: New file.
3471         * infcmd.c (startup_with_shell): Don't define.
3472         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3473         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3474         * inferior.h (startup_with_shell): Don't declare.
3475
3476 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3477
3478         * gdbsupport/gdb_assert.h: Include errors.h.
3479         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3480
3481 2019-10-02  Tom Tromey  <tromey@adacore.com>
3482
3483         * NEWS: Add $_ada_exception entry.
3484         * ada-lang.c (struct ada_catchpoint): Add constructor.
3485         <m_kind>: New member.
3486         (allocate_location_exception, re_set_exception): Remove
3487         "ex" parameter.
3488         (should_stop_exception): Compute $_ada_exception.
3489         (check_status_exception, print_it_exception)
3490         (print_one_exception, print_mention_exception): Remove
3491         "ex" parameter.
3492         (allocate_location_catch_exception, re_set_catch_exception)
3493         (check_status_exception, print_it_catch_exception)
3494         (print_one_catch_exception, print_mention_catch_exception)
3495         (print_recreate_catch_exception)
3496         (allocate_location_catch_exception_unhandled)
3497         (re_set_catch_exception_unhandled)
3498         (check_status_exception, print_it_catch_exception_unhandled)
3499         (print_one_catch_exception_unhandled)
3500         (print_mention_catch_exception_unhandled)
3501         (print_recreate_catch_exception_unhandled)
3502         (allocate_location_catch_assert, re_set_catch_assert)
3503         (check_status_assert, print_it_catch_assert)
3504         (print_one_catch_assert, print_mention_catch_assert)
3505         (print_recreate_catch_assert)
3506         (allocate_location_catch_handlers, re_set_catch_handlers)
3507         (check_status_handlers, print_it_catch_handlers)
3508         (print_one_catch_handlers, print_mention_catch_handlers)
3509         (print_recreate_catch_handlers): Remove.
3510         (create_ada_exception_catchpoint): Update.
3511         (initialize_ada_catchpoint_ops): Update.
3512
3513 2019-10-02  Tom Tromey  <tromey@adacore.com>
3514
3515         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3516         (create_excep_cond_exprs): Simplify exception string computation.
3517         (ada_exception_catchpoint_cond_string): Likewise.
3518
3519 2019-10-02  Tom Tromey  <tromey@adacore.com>
3520
3521         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3522         * ada-lang.c (lesseq_defined_than): Handle
3523         LOC_STATIC.
3524         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3525         parameter.
3526         (dwarf2_has_info): Likewise.
3527         (new_symbol): Set maybe_copied on symbol when
3528         appropriate.
3529         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3530         parameter.
3531         <can_copy>: New member.
3532         * elfread.c (record_minimal_symbol): Set maybe_copied
3533         on symbol when appropriate.
3534         (elf_symfile_read): Update call to dwarf2_has_info.
3535         * minsyms.c (lookup_minimal_symbol_linkage): New
3536         function.
3537         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3538         * symtab.c (get_symbol_address, get_msymbol_address):
3539         New functions.
3540         * symtab.h (get_symbol_address, get_msymbol_address):
3541         Declare.
3542         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3543         maybe_copied.
3544         (struct symbol, struct minimal_symbol) <maybe_copied>:
3545         New member.
3546
3547 2019-10-02  Tom Tromey  <tromey@adacore.com>
3548
3549         * source.c (struct current_source_location): New.
3550         (current_source_key): New global.
3551         (current_source_symtab, current_source_line)
3552         (current_source_pspace): Remove.
3553         (get_source_location): New function.
3554         (get_current_source_symtab_and_line)
3555         (set_default_source_symtab_and_line)
3556         (set_current_source_symtab_and_line)
3557         (clear_current_source_symtab_and_line, select_source_symtab)
3558         (info_source_command, print_source_lines_base)
3559         (info_line_command, search_command_helper, _initialize_source):
3560         Update.
3561
3562 2019-10-02  Tom Tromey  <tromey@adacore.com>
3563
3564         * source.c (select_source_symtab): Don't call
3565         decode_line_with_current_source.
3566
3567 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * symtab.c (lookup_global_symbol): Search global block.
3570
3571 2019-10-02  Tom Tromey  <tromey@adacore.com>
3572
3573         * coffread.c (process_coff_symbol): Update.
3574         * dwarf2read.c (var_decode_location, new_symbol): Update.
3575         * mdebugread.c (parse_symbol): Update.
3576         * objfiles.c (relocate_one_symbol): Update.
3577         * stabsread.c (define_symbol, fix_common_block)
3578         (scan_file_globals): Update.
3579         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3580         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3581         * xcoffread.c (process_xcoff_symbol): Update.
3582
3583 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3584
3585         * MAINTAINERS: Update my email address.
3586
3587 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3590         std::vector.
3591         (build_type_psymtabs_reader): Update for std::vector.
3592         (build_type_psymtab_dependencies): Likewise.
3593         * dwarf2read.h: Remove use of DEF_VEC_P.
3594         (typedef sig_type_ptr): Delete.
3595
3596 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3599         to std::vector.
3600         (btrace_maint_decode_pt): Likewise, and move allocation of the
3601         vector outside of the loop.
3602         (btrace_maint_update_packets): Update to handle change from VEC to
3603         std::vector.
3604         (btrace_maint_print_packets): Likewise.
3605         (maint_info_btrace_cmd): Likewise.
3606         * btrace.h: Remove use of DEF_VEC_O.
3607         (typedef btrace_pt_packet_s): Delete.
3608         (struct btrace_maint_info) <packets>: Change fromm VEC to
3609         std::vector.
3610         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3611
3612 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3613
3614         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3615         make accesses into the vector constant references.
3616         (btrace_add_pc): Update for std::vector.
3617         (btrace_stitch_bts): Likewise.
3618         (parse_xml_btrace_block): Likewise.
3619         (btrace_maint_update_packets): Likewise.
3620         (btrace_maint_print_packets): Likewise.
3621         (maint_info_btrace_cmd): Likewise.
3622         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3623         std::vector.
3624         (btrace_data::empty): Likewise.
3625         (btrace_data_append): Likewise.
3626         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3627         (typedef btrace_block_s): Delete.
3628         (struct btrace_block): Add constructor.
3629         (struct btrace_data_bts) <blocks>: Change to std::vector.
3630         * nat/linux-btrace.c (perf_event_read_bts): Update for
3631         std::vector.
3632         (linux_read_bts): Likewise.
3633
3634 2019-10-01  Tom Tromey  <tom@tromey.com>
3635
3636         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3637
3638 2019-10-01  Tom Tromey  <tom@tromey.com>
3639
3640         * stack.c (print_frame, info_frame_command_core): Use
3641         styled_string.
3642         * linux-thread-db.c (try_thread_db_load_1)
3643         (try_thread_db_load_from_pdir_1): Use styled_string.
3644         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3645         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3646         (maybe_print_unsupported_script_warning)
3647         (maybe_print_script_not_found_warning): Use styled_string.
3648         * ada-lang.c (user_select_syms): Use styled_string.
3649
3650 2019-10-01  Tom Tromey  <tom@tromey.com>
3651
3652         * p-lang.c (pascal_printstr): Use metadata style.
3653         * value.c (show_convenience): Use metadata style.
3654         * valprint.c (valprint_check_validity, val_print_optimized_out)
3655         (val_print_not_saved, val_print_unavailable)
3656         (val_print_invalid_address, generic_val_print, val_print)
3657         (value_check_printable, val_print_array_elements): Use metadata
3658         style.
3659         * ui-out.h (class ui_out) <field_fmt>: New overload.
3660         <do_field_fmt>: Add style parameter.
3661         * ui-out.c (ui_out::field_fmt): New overload.
3662         * typeprint.c (type_print_unknown_return_type)
3663         (val_print_not_allocated, val_print_not_associated): Use metadata
3664         style.
3665         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3666         parameter.
3667         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3668         * tracepoint.c (tvariables_info_1): Use metadata style.
3669         * stack.c (print_frame_arg, print_frame_info, print_frame)
3670         (info_frame_command_core): Use metadata style.
3671         * skip.c (info_skip_command): Use metadata style.
3672         * rust-lang.c (rust_print_enum): Use metadata style.
3673         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3674         metadata style.
3675         * python/py-framefilter.c (py_print_single_arg): Use metadata
3676         style.
3677         * printcmd.c (do_one_display, print_variable_and_value): Use
3678         metadata style.
3679         * p-valprint.c (pascal_val_print)
3680         (pascal_object_print_value_fields): Use metadata style.
3681         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3682         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3683         parameter.
3684         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3685         * m2-valprint.c (m2_print_long_set): Use metadata style.
3686         * m2-typeprint.c (m2_print_type): Use metadata style.
3687         * infcmd.c (print_return_value_1): Use metadata style.
3688         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3689         * f-valprint.c (info_common_command_for_block): Use metadata
3690         style.
3691         * f-typeprint.c (f_type_print_base): Use metadata style.
3692         * expprint.c (print_subexp_standard): Use metadata style.
3693         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3694         * cli/cli-style.h (class cli_style_option): Add constructor.
3695         (metadata_style): Declare.
3696         * cli/cli-style.c (metadata_style): New global.
3697         (_initialize_cli_style): Register metadata style.
3698         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3699         parameter.
3700         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3701         * c-typeprint.c (c_type_print_base_struct_union)
3702         (c_type_print_base_1): Use metadata style.
3703         * breakpoint.c (watchpoint_value_print)
3704         (print_one_breakpoint_location): Use metadata style.
3705         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3706         style.
3707         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3708         style.
3709         * ada-valprint.c (val_print_packed_array_elements, printstr)
3710         (print_field_values, ada_val_print_ref, ada_val_print): Use
3711         metadata style.
3712         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3713         style.
3714         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3715         style.
3716         * ada-lang.c (user_select_syms): Use metadata style.
3717
3718 2019-10-01  Tom Tromey  <tom@tromey.com>
3719
3720         * cli/cli-cmds.c (pwd_command): Style output.
3721
3722 2019-10-01  Pedro Alves  <palves@redhat.com>
3723             Tom Tromey  <tom@tromey.com>
3724
3725         * symtab.c (print_symbol_info): Use %ps.
3726         (print_msymbol_info): Use %ps.
3727         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3728         * printcmd.c (print_variable_and_value): Use %ps.
3729         * macrocmd.c (show_pp_source_pos): Use %ps.
3730         * infrun.c (print_exited_reason): Use ui_out::message.
3731         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3732         (describe_other_breakpoints): Use ui_out::message and new
3733         formats.
3734         (say_where): Use new formats.
3735         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3736         and new formats.
3737
3738 2019-10-01  Pedro Alves  <palves@redhat.com>
3739             Tom Tromey  <tom@tromey.com>
3740
3741         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3742         (test_gdb_formats): New function.
3743         (run_tests): Call it.
3744         (test_format_specifier): Update.
3745         * utils.h (fputs_filtered): Update comment.
3746         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3747         (fputs_styled_unfiltered): Declare.
3748         * utils.c (fputs_styled_unfiltered): New function.
3749         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3750         (vfprintf_filtered): Update.
3751         (vfprintf_unfiltered, vprintf_filtered): Update.
3752         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3753         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3754         disallow_ui_out_field>: New constants.
3755         (enum class field_kind): New.
3756         (struct base_field_s, struct signed_field_s): New.
3757         (signed_field): New function.
3758         (struct string_field_s): New.
3759         (string_field): New function.
3760         (struct styled_string_s): New.
3761         (styled_string): New function.
3762         (class ui_out) <message>: Add comment.
3763         <vmessage, call_do_message>: New methods.
3764         <do_message>: Add style parameter.
3765         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3766         methods.
3767         (ui_out::message): Rewrite.
3768         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3769         parameter.
3770         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3771         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3772         gdb_extensions parameter.
3773         (class format_piece): Add parameter to constructor.
3774         (n_int_args): New field.
3775         * gdbsupport/format.c (format_pieces::format_pieces): Add
3776         gdb_extensions parameter.  Handle '*'.
3777         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3778         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3779         vfprintf_styled_no_gdbfmt.
3780         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3781         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3782         unfiltered output.
3783         * ui-style.h (struct ui_file_style) <ptr>: New method.
3784
3785 2019-10-01  Tom Tromey  <tom@tromey.com>
3786
3787         * unittests/format_pieces-selftests.c: Update.  Add final format.
3788         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3789         empty literal pieces.
3790
3791 2019-10-01  Tom Tromey  <tom@tromey.com>
3792
3793         * ui-out.h (enum class ui_out_style_kind): Remove.
3794         (class ui_out) <field_string, field_stsream, do_field_string>:
3795         Change type of "style".
3796         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3797         (ui_out::field_string): Update.
3798         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3799         of "style".
3800         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3801         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3802         * stack.c (print_frame_arg, print_frame_info, print_frame):
3803         Update.
3804         * source.c (print_source_lines_base): Update.
3805         * solib.c (info_sharedlibrary_command): Update.
3806         * skip.c (info_skip_command): Update.
3807         * record-btrace.c (btrace_call_history_src_line)
3808         (btrace_call_history): Update.
3809         * python/py-framefilter.c (py_print_frame): Update.
3810         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3811         "style".
3812         * mi/mi-out.c (mi_ui_out::do_table_header)
3813         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3814         (mi_ui_out::do_field_string): Update.
3815         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3816         Update.
3817         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3818         "style".
3819         * cli-out.c (cli_ui_out::do_table_header)
3820         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3821         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3822         (cli_ui_out::do_field_fmt): Update.
3823         * breakpoint.c (print_breakpoint_location): Update.
3824         (update_static_tracepoint): Update.
3825
3826 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3827
3828         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3829         conversion of gdb_datadir.
3830         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3831         remove not needed c_str ().
3832
3833 2019-09-30  Ali Tamur <tamur@google.com>
3834
3835         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3836         (dwarf2_string_attr): Likewise.
3837
3838 2019-09-30  Ali Tamur <tamur@google.com>
3839
3840         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3841         (process_full_type_unit): Likewise.
3842         (dump_die_shallow): Likewise.
3843         (cu_debug_loc_section): Likewise.
3844
3845 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3846
3847         * minsyms.c (compare_minimal_symbols): Rename to...
3848         (minimal_symbol_is_less_than): ...this, and adjust to STL
3849         conventions (return bool, take arguments as references)
3850         (minimal_symbol_reader::install): Call std::sort instead
3851         of qsort.
3852
3853 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3854
3855         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3856         hash and why.
3857         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3858         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3859
3860 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3861
3862         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3863         * psympriv.h (add_psymbol_to_list): Move comment here and update
3864         it.
3865
3866 2019-09-29  Tom de Vries  <tdevries@suse.de>
3867
3868         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3869         Use $tmpdir/$(basename "$output_file").dwz instead of
3870         "${output_file}.dwz".
3871
3872 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3873
3874         PR gdb/25045
3875         * hppa-linux-nat.c: Include gdbarch.h.
3876
3877 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3878
3879         * blockframe.c (find_pc_partial_function): Change return type to bool.
3880         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3881         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3882         (stub_gnu_ifunc_resolve_name): Likewise.
3883         * symtab.c (compare_filenames_for_search): Likewise.
3884         (compare_glob_filenames_for_search): Likewise.
3885         (matching_obj_sections): Likewise.
3886         (symbol_matches_domain): Likewise.
3887         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3888         (find_line_pc): Change return type to bool.
3889         (find_line_pc_range): Likewise.
3890         (producer_is_realview): Likewise.
3891         * symtab.h (symbol_matches_domain): Likewise.
3892         (find_pc_partial_function): Likewise.
3893         (find_pc_line_pc_range): Likewise.
3894         (in_gnu_ifunc_stub): Likewise.
3895         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3896         (find_line_pc): Likewise.
3897         (find_line_pc_range): Likewise.
3898         (matching_obj_sections): Likewise.
3899         (find_line_symtab): Change out parameter to bool.
3900         (producer_is_realview): Change return type to bool.
3901         (compare_filenames_for_search): Likewise.
3902         (compare_glob_filenames_for_search): Likewise.
3903
3904 2019-09-26  Tom Tromey  <tom@tromey.com>
3905
3906         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3907         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3908         * gdb_usleep.h: Remove.
3909         * gdb_usleep.c: Remove.
3910         * utils.c: Don't include gdb_usleep.h.
3911
3912 2019-09-26  Tom Tromey  <tromey@adacore.com>
3913
3914         * python/py-type.c (type_to_type_object): Call check_typedef
3915         for stub types.
3916
3917 2019-09-26  Tom Tromey  <tom@tromey.com>
3918
3919         * utils.h (initialize_utils): Don't declare.
3920         * top.c (gdb_init): Don't call initialize_utils.
3921         * utils.c (initialize_utils): Remove.  Move contents...
3922         (_initialize_utils): ... here.
3923
3924 2019-09-25  Tom Tromey  <tom@tromey.com>
3925
3926         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3927         * utils.h (make_hex_string): Don't declare.
3928         * utils.c (make_hex_string): Remove.
3929
3930 2019-09-24  Tom de Vries  <tdevries@suse.de>
3931
3932         PR gdb/23815
3933         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3934         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3935
3936 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3937
3938         * NEWS: Mention new simulator port for PRU.
3939
3940 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3941
3942         * ada-exp.y (write_object_remaining): Update.
3943         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3944         and eliminate the static buffer.
3945         (ada_decode_symbol): Update.
3946         (ada_la_decode): Update.
3947         (ada_sniff_from_mangled_name): Update.
3948         (is_valid_name_for_wild_match): Update.
3949         (ada_lookup_name_info::matches): Update and simplify.
3950         (name_matches_regex): Update.
3951         (ada_add_global_exceptions): Update.
3952         * ada-lang.h (ada_decode): Update signature.
3953         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3954         * dwarf-index-write.c (debug_names::insert): Update.
3955
3956 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3959         formatting.
3960
3961 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3962
3963         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3964         Change "nonzero" to "true" in documentation.
3965
3966 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3967
3968         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3969         (_initialize_darwin_solib): Don't set
3970         darwin_so_ops.lookup_lib_global_symbol.
3971         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3972         set_gdbarch_iterate_over_objfiles_in_search_order.
3973         (elf_lookup_lib_symbol): Rename to...
3974         (svr4_iterate_over_objfiles_in_search_order): this, and update
3975         to iterate semantics.
3976         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3977         * solib.c (solib_global_lookup): Remove.
3978         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3979         (solib_global_lookup): Remove.
3980         * symtab.c (lookup_global_or_static_symbol): Remove call to
3981         solib_global_lookup.
3982
3983 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3984
3985         * NEWS: Move entries about default MI version now being
3986         version 3, and about the GDB/MI fix for multi-location
3987         breakpoints to the "since GDB 8.3" section.
3988
3989 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3990
3991         GDB 8.3.1 released.
3992
3993 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3994
3995         * NEWS: Mention that Cell/B.E. debugging support was removed.
3996         * MAINTAINERS: Remove spu target.
3997
3998         * config/djgpp/fnchange.lst: Remove entries for removed files.
3999
4000         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4001         spu-multiarch.o, and spu-tdep.o.
4002         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4003         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4004         spu-multiarch.c, and spu-tdep.c.
4005         * spu-linux-nat.c: Remove file.
4006         * spu-multiarch.c: Remove file.
4007         * spu-tdep.c: Remove file.
4008         * spu-tdep.h: Remove file.
4009         * solib-spu.c: Remove file.
4010         * solib-spu.h: Remove file.
4011
4012         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4013         * configure.nat (spu-linux): Remove.
4014         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4015         solib-multiarch.o from gdb_target_obs.
4016         (spu*-*-*): Remove.
4017
4018         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4019         feature flag.
4020         (ppc_linux_no_features): Update.
4021         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4022         Cell/B.E. support.
4023         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4024         (tdesc_powerpc_cell64l): Likewise.
4025         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4026         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4027         Cell/B.E. support.
4028         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4029         Do not include "features/rs6000/powerpc-cell32l.c" or
4030         "features/rs6000/powerpc-cell64l.c".
4031         (ppc_linux_spu_section): Remove.
4032         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4033         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4034         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4035         (ppc_linux_spe_context_lookup): Remove.
4036         (ppc_linux_spe_context_inferior_created): Remove.
4037         (ppc_linux_spe_context_solib_loaded): Remove.
4038         (ppc_linux_spe_context_solib_unloaded): Remove.
4039         (ppc_linux_spe_context): Remove.
4040         (struct ppu2spu_cache): Remove.
4041         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4042         (struct ppu2spu_data): Remove.
4043         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4044         ppu2spu_unwind): Remove.
4045         (ppc_linux_init_abi): Remove Cell/B.E. support.
4046         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4047
4048         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4049         (rs6000/powerpc-cell64l-expedite): Likewise
4050         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4051         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4052         rs6000/powerpc-cell64l.xml.
4053         * features/rs6000/powerpc-cell32l.xml: Remove.
4054         * features/rs6000/powerpc-cell64l.xml: Likewise.
4055         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4056         * features/rs6000/powerpc-cell64l.c: Likewise.
4057         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4058         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4059         * regformats/reg-spu.dat: Remove.
4060
4061         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4062         * corelow.c (struct spuid_list): Remove.
4063         (add_to_spuid_list): Remove.
4064         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4065         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4066         (remote_protocol_features): Remove associated entries.
4067         (_initialize_remote): No longer initialize them.
4068         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4069         * linux-nat.c (SPUFS_MAGIC): Remove.
4070         (linux_proc_xfer_spu): Remove.
4071         (spu_enumerate_spu_ids): Remove.
4072         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4073         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4074         (linux_make_corefile_notes): No longer call it.
4075
4076         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4077         (cooked_write_test): Likewise.
4078
4079 2019-09-20  Tom Tromey  <tom@tromey.com>
4080
4081         * NEWS: Mention case-sensitivity of TUI commands.
4082         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4083         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4084         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4085
4086 2019-09-20  Tom Tromey  <tom@tromey.com>
4087
4088         * tui/tui-source.c (tui_source_window::set_contents): Use
4089         make_unique_xstrdup.
4090         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4091         make_unique_xstrdup.
4092
4093 2019-09-20  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-data.c: Remove separator comments.
4096         * tui/tui-layout.c: Remove separator comments.
4097         * tui/tui-win.c: Remove separator comments.
4098         * tui/tui-wingeneral.c: Remove separator comments.
4099
4100 2019-09-20  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui.h (strcat_to_buf): Don't declare.
4103         * tui/tui.c (strcat_to_buf): Remove.
4104
4105 2019-09-20  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4108         from "fullname".
4109         * tui/tui-source.c (tui_source_window::set_contents)
4110         (tui_source_window::location_matches_p)
4111         (tui_source_window::maybe_update): Update.
4112
4113 2019-09-20  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4116         Update.
4117         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4118         prefix.
4119         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4120         (tui_data_window::line_from_reg_element_no)
4121         (tui_data_window::first_reg_element_no_inline)
4122         (tui_data_window::show_registers)
4123         (tui_data_window::show_register_group)
4124         (tui_data_window::display_registers_from)
4125         (tui_data_window::display_registers_from_line)
4126         (tui_data_window::first_data_item_displayed)
4127         (tui_data_window::delete_data_content_windows)
4128         (tui_data_window::erase_data_content)
4129         (tui_data_window::do_scroll_vertical)
4130         (tui_data_window::refresh_window)
4131         (tui_data_window::check_register_values): Update.
4132
4133 2019-09-20  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4136         (struct tui_locator_window) <full_name, proc_name>: Now
4137         std::string.
4138         * tui/tui-stack.c (tui_locator_window::make_status_line)
4139         (tui_locator_window::set_locator_fullname)
4140         (tui_locator_window::set_locator_info): Update.
4141         * tui/tui-source.c (tui_source_window::set_contents)
4142         (tui_source_window::showing_source_p): Update.
4143
4144 2019-09-20  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4147         Don't call tui_locator_win_info_ptr.
4148
4149 2019-09-20  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4152
4153 2019-09-20  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4156         height for locator.
4157         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4158         * tui/tui-layout.c (show_source_disasm_command, show_data)
4159         (show_source_or_disasm_and_command): Use 1 as height for locator.
4160
4161 2019-09-20  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui.c (tui_enable): Update.
4164         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4165         Update.
4166         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4167         Update.
4168         * tui/tui-data.c (win_resized): Now bool.
4169         (tui_win_resized): Return bool.
4170         (tui_set_win_resized_to): Accept a bool.
4171
4172 2019-09-20  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4175         Change type of "refresh_values_only".
4176         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4177         type of "refresh_values_only".
4178
4179 2019-09-20  Tom Tromey  <tom@tromey.com>
4180
4181         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4182         std::string.
4183         (tui_disassemble): Add "pos" parameter.
4184         (tui_disasm_window::set_contents): Simplify.
4185
4186 2019-09-20  Tom Tromey  <tom@tromey.com>
4187
4188         * tui/tui-winsource.h (struct tui_source_window_base)
4189         <show_source_content>: Now private.
4190         * tui/tui-winsource.c
4191         (tui_source_window_base::show_source_content): Don't handle empty
4192         content case.
4193
4194 2019-09-20  Tom Tromey  <tom@tromey.com>
4195
4196         * tui/tui-layout.c (show_source_disasm_command)
4197         (show_source_or_disasm_and_command): Don't call
4198         show_source_content.
4199
4200 2019-09-20  Tom Tromey  <tom@tromey.com>
4201
4202         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4203         Declare.
4204         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4205         from tui_make_status_line.
4206         (tui_locator_window::rerender): Update.
4207
4208 2019-09-20  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4211         (tui_locator_window::rerender): Update.
4212
4213 2019-09-20  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-winsource.h (struct tui_source_window_base)
4216         <~tui_source_window_base>: Don't declare.
4217         <fullname>: Remove.
4218         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4219         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4220         member.
4221         * tui/tui-source.c (tui_source_window::set_contents): Update.
4222         (tui_source_window::location_matches_p)
4223         (tui_source_window::maybe_update): Update.
4224
4225 2019-09-20  Tom Tromey  <tom@tromey.com>
4226
4227         * tui/tui-winsource.h (~tui_source_element): Remove.
4228         (tui_source_element): Update.
4229         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4230         * tui/tui-winsource.c (tui_show_source_line): Update.
4231         * tui/tui-source.c (tui_source_window::set_contents): Update.
4232         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4233
4234 2019-09-20  Tom Tromey  <tom@tromey.com>
4235
4236         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4237         declare.
4238         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4239         tui_clear_source_windows_detail.
4240         * tui/tui-winsource.h (struct tui_source_window_base)
4241         <clear_detail>: Don't declare.
4242         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4243         Remove.
4244         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4245
4246 2019-09-20  Tom Tromey  <tromey@adacore.com>
4247
4248         PR ada/24919:
4249         * block.c (contained_in): Fix final return value.
4250
4251 2019-09-20  Alan Modra  <amodra@gmail.com>
4252
4253         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4254         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4255         (read_indirect_string_from_dwz): Use bfd accessor.
4256         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4257         * machoread.c (macho_symfile_read_all_oso): Likewise.
4258         * solib.c (solib_bfd_open): Likewise.
4259
4260 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4261
4262         * eval.c: Move declaration of overload_resolution to...
4263         * value.h: ...here.
4264
4265 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4266
4267         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4268         * arm-linux-tdep.c: Likewise.
4269         * arm-nbsd-nat.c: Likewise.
4270         * arm-tdep.h: Declare arm_apcs_32.
4271         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4272
4273 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4274
4275         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4276         * dwarf2read.h: Declare dwarf_always_disassemble.
4277
4278 2019-09-19  Tom de Vries  <tdevries@suse.de>
4279
4280         PR gdb/25009
4281         * source-cache.c (source_cache::ensure): Catch exception thrown during
4282         construction of the highlighter.
4283
4284 2019-09-18  Alan Modra  <amodra@gmail.com>
4285
4286         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4287         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4288         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4289         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4290         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4291         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4292         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4293         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4294         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4295         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4296         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4297         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4298         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4299         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4300         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4301         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4302         * mi/mi-interp.c: Update throughout for bfd section macro and
4303         function changes.
4304         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4305         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4306
4307 2019-09-18  Tom Tromey  <tom@tromey.com>
4308
4309         * NEWS: Add entry.
4310         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4311         call rl_initialize.
4312         (tui_enable): Do not call rl_initialize.
4313
4314 2019-09-18  Christian Groessler  <chris@groessler.org>
4315
4316         * alpha-linux-nat.c: Include gdbarch.h.
4317
4318 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4319
4320         * ui-file.c: Include cli/cli-style.h.
4321         (term_cli_styling): Remove cli_styling declaration.
4322
4323 2019-09-18  Alan Modra  <amodra@gmail.com>
4324
4325         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4326         to bfd_asymbol_section.
4327
4328 2019-09-18  Alan Modra  <amodra@gmail.com>
4329
4330         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4331         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4332         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4333
4334 2019-09-18  Alan Modra  <amodra@gmail.com>
4335
4336         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4337         * spu-linux-nat.c (spu_bfd_open): Likewise.
4338
4339 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4340
4341         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4342         to bool to match definition in dwarf2read.c.
4343
4344 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4345
4346         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4347         (print_signatures): Likewise.
4348         (trust_pad_over_xvs): Likewise.
4349         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4350         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4351         * arm-linux-nat.c (arm_apcs_32): Likewise.
4352         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4353         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4354         * arm-tdep.c (arm_debug): Likewise.
4355         (arm_apcs_32): Likewise.
4356         * auto-load.c (debug_auto_load): Likewise.
4357         (auto_load_gdb_scripts): Likewise.
4358         (global_auto_load): Likewise.
4359         (auto_load_local_gdbinit): Likewise.
4360         (auto_load_local_gdbinit_loaded): Likewise.
4361         * auto-load.h (global_auto_load): Likewise.
4362         (auto_load_local_gdbinit): Likewise.
4363         (auto_load_local_gdbinit_loaded): Likewise.
4364         * breakpoint.c (disconnected_dprintf): Likewise.
4365         (breakpoint_proceeded): Likewise.
4366         (automatic_hardware_breakpoints): Likewise.
4367         (always_inserted_mode): Likewise.
4368         (target_exact_watchpoints): Likewise.
4369         (_initialize_breakpoint): Update.
4370         * breakpoint.h (target_exact_watchpoints): Change to bool.
4371         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4372         * cli/cli-cmds.c (trace_commands): Likewise.
4373         * cli/cli-cmds.h (trace_commands): Likewise.
4374         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4375         to bool*.
4376         * cli/cli-logging.c (logging_overwrite): Change to bool.
4377         (logging_redirect): Likewise.
4378         (debug_redirect): Likewise.
4379         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4380         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4381         to bool.
4382         <boolean_option_def>: Update.
4383         (struct flag_option_def): Change default type of Context to bool
4384         from int.
4385         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4386         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4387         (get_setshow_command_value_string): Likewise.
4388         * cli/cli-style.c (cli_styling): Change to bool.
4389         (source_styling): Likewise.
4390         * cli/cli-style.h (source_styling): Likewise.
4391         (cli_styling): Likewise.
4392         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4393         to bool.
4394         * command.h (var_types): Update comment.
4395         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4396         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4397         bool.
4398         (debug_compile_cplus_scopes): Likewise.
4399         * compile/compile-internal.h (compile_debug): Likewise.
4400         * compile/compile.c (compile_debug): Likewise.
4401         (struct compile_options) <raw>: Likewise.
4402         * cp-support.c (catch_demangler_crashes): Likewise.
4403         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4404         (usr_cmd_cris_dwarf2_cfi): Likewise.
4405         * csky-tdep.c (csky_debug): Likewise.
4406         * darwin-nat.c (enable_mach_exceptions): Likewise.
4407         * dcache.c (dcache_enabled_p): Likewise.
4408         * defs.h (info_verbose): Likewise.
4409         * demangle.c (demangle): Likewise.
4410         (asm_demangle): Likewise.
4411         * dwarf-index-cache.c (debug_index_cache): Likewise.
4412         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4413         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4414         * dwarf2read.c (check_physname): Likewise.
4415         (use_deprecated_index_sections): Likewise.
4416         (dwarf_always_disassemble): Likewise.
4417         * eval.c (overload_resolution): Likewise.
4418         * event-top.c (set_editing_cmd_var): Likewise.
4419         (exec_done_display_p): Likewise.
4420         * event-top.h (set_editing_cmd_var): Likewise.
4421         (exec_done_display_p): Likewise.
4422         * exec.c (write_files): Likewise.
4423         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4424         (debug_fbsd_nat): Likewise.
4425         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4426         Likewise.
4427         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4428         <backtrace_past_entry> Likewise.
4429         * gdb-demangle.h (demangle): Likewise.
4430         (asm_demangle): Likewise.
4431         * gdb_bfd.c (bfd_sharing): Likewise.
4432         * gdbcore.h (write_files): Likewise.
4433         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4434         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4435         * gdbthread.h (print_thread_events): Likewise.
4436         * gdbtypes.c (opaque_type_resolution): Likewise.
4437         (strict_type_checking): Likewise.
4438         * gnu-nat.c (gnu_debug_flag): Likewise.
4439         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4440         * guile/scm-param.c (pascm_variable): Add boolval.
4441         (add_setshow_generic): Update.
4442         (pascm_param_value): Update.
4443         (pascm_set_param_value_x): Update.
4444         * hppa-tdep.c (hppa_debug): Change to bool..
4445         * infcall.c (may_call_functions_p): Likewise.
4446         (coerce_float_to_double_p): Likewise.
4447         (unwind_on_signal_p): Likewise.
4448         (unwind_on_terminating_exception_p): Likewise.
4449         * infcmd.c (startup_with_shell): Likewise.
4450         * inferior.c (print_inferior_events): Likewise.
4451         * inferior.h (startup_with_shell): Likewise.
4452         (print_inferior_events): Likewise.
4453         * infrun.c (step_stop_if_no_debug): Likewise.
4454         (detach_fork): Likewise.
4455         (debug_displaced): Likewise.
4456         (disable_randomization): Likewise.
4457         (non_stop): Likewise.
4458         (non_stop_1): Likewise.
4459         (observer_mode): Likewise.
4460         (observer_mode_1): Likewise.
4461         (set_observer_mode): Update.
4462         (sched_multi): Change to bool.
4463         * infrun.h (debug_displaced): Likewise.
4464         (sched_multi): Likewise.
4465         (step_stop_if_no_debug): Likewise.
4466         (non_stop): Likewise.
4467         (disable_randomization): Likewise.
4468         * linux-tdep.c (use_coredump_filter): Likewise.
4469         (dump_excluded_mappings): Likewise.
4470         * linux-thread-db.c (auto_load_thread_db): Likewise.
4471         (check_thread_db_on_load): Likewise.
4472         * main.c (captured_main_1): Update.
4473         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4474         xx2_opt, boolean_opt>: Change to bool.
4475         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4476         * maint.c (maintenance_profile_p): Likewise.
4477         (per_command_time): Likewise.
4478         (per_command_space): Likewise.
4479         (per_command_symtab): Likewise.
4480         * memattr.c (inaccessible_by_default): Likewise.
4481         * mi/mi-main.c (mi_async): Likewise.
4482         (mi_async_1): Likewise.
4483         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4484         * nat/fork-inferior.h (startup_with_shell): Likewise.
4485         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4486         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4487         * nios2-tdep.c (nios2_debug): Likewise.
4488         * or1k-tdep.c (or1k_debug): Likewise.
4489         * parse.c (parser_debug): Likewise.
4490         * parser-defs.h (parser_debug): Likewise.
4491         * printcmd.c (print_symbol_filename): Likewise.
4492         * proc-api.c (procfs_trace): Likewise.
4493         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4494         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4495         (set_parameter_value): Update.
4496         (add_setshow_generic): Update.
4497         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4498         to bool*.
4499         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4500         int*.
4501         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4502         * record-btrace.c (record_btrace_target::store_registers): Update.
4503         * record-full.c (record_full_memory_query): Change to bool.
4504         (record_full_stop_at_limit): Likewise.
4505         * record-full.h (record_full_memory_query): Likewise.
4506         * remote-notif.c (notif_debug): Likewise.
4507         * remote-notif.h (notif_debug): Likewise.
4508         * remote.c (use_range_stepping): Likewise.
4509         (interrupt_on_connect): Likewise.
4510         (remote_break): Likewise.
4511         * ser-tcp.c (tcp_auto_retry): Likewise.
4512         * ser-unix.c (serial_hwflow): Likewise.
4513         * skip.c (debug_skip): Likewise.
4514         * solib-aix.c (solib_aix_debug): Likewise.
4515         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4516         (spu_auto_flush_cache_p): Likewise.
4517         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4518         Likewise.
4519         (struct info_print_options) <quiet>: Likewise.
4520         * symfile-debug.c (debug_symfile): Likewise.
4521         * symfile.c (auto_solib_add): Likewise.
4522         (separate_debug_file_debug): Likewise.
4523         * symfile.h (auto_solib_add): Likewise.
4524         (separate_debug_file_debug): Likewise.
4525         * symtab.c (basenames_may_differ): Likewise.
4526         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4527         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4528         (struct info_types_options) <quiet>: Likewise.
4529         * symtab.h (demangle): Likewise.
4530         (basenames_may_differ): Likewise.
4531         * target-dcache.c (stack_cache_enabled_1): Likewise.
4532         (code_cache_enabled_1): Likewise.
4533         * target.c (trust_readonly): Likewise.
4534         (may_write_registers): Likewise.
4535         (may_write_memory): Likewise.
4536         (may_insert_breakpoints): Likewise.
4537         (may_insert_tracepoints): Likewise.
4538         (may_insert_fast_tracepoints): Likewise.
4539         (may_stop): Likewise.
4540         (auto_connect_native_target): Likewise.
4541         (target_stop_and_wait): Update.
4542         (target_async_permitted): Change to bool.
4543         (target_async_permitted_1): Likewise.
4544         (may_write_registers_1): Likewise.
4545         (may_write_memory_1): Likewise.
4546         (may_insert_breakpoints_1): Likewise.
4547         (may_insert_tracepoints_1): Likewise.
4548         (may_insert_fast_tracepoints_1): Likewise.
4549         (may_stop_1): Likewise.
4550         * target.h (target_async_permitted): Likewise.
4551         (may_write_registers): Likewise.
4552         (may_write_memory): Likewise.
4553         (may_insert_breakpoints): Likewise.
4554         (may_insert_tracepoints): Likewise.
4555         (may_insert_fast_tracepoints): Likewise.
4556         (may_stop): Likewise.
4557         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4558         (make_thread_apply_all_options_def_group): Change argument from int*
4559         to bool*.
4560         (thread_apply_all_command): Update.
4561         (print_thread_events): Change to bool.
4562         * top.c (confirm): Likewise.
4563         (command_editing_p): Likewise.
4564         (history_expansion_p): Likewise.
4565         (write_history_p): Likewise.
4566         (info_verbose): Likewise.
4567         * top.h (confirm): Likewise.
4568         (history_expansion_p): Likewise.
4569         * tracepoint.c (disconnected_tracing): Likewise.
4570         (circular_trace_buffer): Likewise.
4571         * typeprint.c (print_methods): Likewise.
4572         (print_typedefs): Likewise.
4573         * utils.c (debug_timestamp): Likewise.
4574         (sevenbit_strings): Likewise.
4575         (pagination_enabled): Likewise.
4576         * utils.h (sevenbit_strings): Likewise.
4577         (pagination_enabled): Likewise.
4578         * valops.c (overload_resolution): Likewise.
4579         * valprint.h (struct value_print_options) <prettyformat_arrays,
4580         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4581         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4582         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4583         Likewise.
4584         * windows-nat.c (new_console): Likewise.
4585         (cygwin_exceptions): Likewise.
4586         (new_group): Likewise.
4587         (debug_exec): Likewise.
4588         (debug_events): Likewise.
4589         (debug_memory): Likewise.
4590         (debug_exceptions): Likewise.
4591         (useshell): Likewise.
4592         * windows-tdep.c (maint_display_all_tib): Likewise.
4593         * xml-support.c (debug_xml): Likewise.
4594
4595 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4596
4597         * source.c (prepare_path_for_appending): New function.
4598         (openp): Make use of new function.
4599         (find_and_open_source): Search for the compilation directory and
4600         source file as a relative path beneath the directory search path.
4601
4602 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * source-cache.c (source_cache::get_line_charpos): Catch
4605         exceptions and return false, this matches the behaviour documented
4606         in the header file.
4607
4608 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4609
4610         * ada-tasks.c (info_task): Remove quoting of the task's name.
4611
4612 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4613
4614         * symfile.c (auto_solib_add): Replace comment with a reference
4615         to the header file.
4616
4617 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4618
4619         * NEWS: Mention that gdb can now be compiled with Python 3
4620         on Windows.
4621
4622 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * maint.c (maint_print_section_data::maint_print_section_data):
4625         Force use of 'float log10 (float)' by casting the argument to
4626         float.
4627
4628 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * maint.c: Add 'cmath' include.
4631         (struct maint_print_section_data): New structure.
4632         (print_section_index): New function.
4633         (print_bfd_section_info): Add header comment, small whitespace
4634         cleanup, and update to call new print_section_index function.
4635         (print_objfile_section_info): Likewise.
4636         (maint_obj_section_from_bfd_section): New function.
4637         (print_bfd_section_info_maybe_relocated): New function.
4638         (maintenance_info_sections): Add header comment, always use
4639         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4640
4641 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4644         inner scope, add check that the objfile has psymtabs before
4645         checking psymtabs_addrmap.
4646         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4647
4648 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649
4650         * NEWS: Announce that Ada task names are now shown at more places,
4651         and between quotes (except in info task output).
4652         * gdb/ada-tasks.c (task_to_str): New function.
4653         (display_current_task_id): Call task_to_str.
4654         (task_command_1): Likewise.
4655         (print_ada_task_info): In non-mi mode, Properly align headers and data
4656         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4657
4658 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4659
4660         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4661         prstatus.pr_lwp.pr_info instead of making it up.
4662
4663 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4664
4665         * auto-load.c (auto_load_expand_dir_vars): Update.
4666         * defs.h (gdb_datadir): Change to std::string.
4667         (python_libdir): Likewise.
4668         (relocate_gdb_directory): Change return type to std::string.
4669         * guile/guile.c (gdbscm_data_directory): Update.
4670         (initialize_scheme_side): Update.
4671         * jit.c (jit_reader_dir): Change to std::string.
4672         (jit_reader_load_command): Update.
4673         * main.c (gdb_datadir): Change to std::string.
4674         (python_libdir): Likewise.
4675         (set_gdb_data_directory): Update.
4676         (relocate_path): Change to return std::string.
4677         (relocate_gdb_directory): Change to return std::string.
4678         (relocate_gdbinit_path_maybe_in_datadir): Update.
4679         (captured_main_1): Update.
4680         * python/python.c (do_start_initialization): Update.
4681         * top.c (show_gdb_datadir): Update.
4682         * xml-syscall.c (xml_init_syscalls_info): Update.
4683         (init_syscalls_info): Update.
4684
4685 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4686
4687         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4688         out of get_init_files.
4689         (get_init_files): Update.
4690
4691 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4692
4693         * main.c (get_init_files): Change to use std::string.
4694         (captured_main_1): Update.
4695         (print_gdb_help): Update.
4696
4697 2019-09-11  Ali Tamur  <tamur@google.com>
4698
4699         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4700         implementation.
4701
4702 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4703
4704         * dbxread.c (read_dbx_symtab): Update.
4705         * dwarf2read.c (load_partial_dies): Update.
4706         * mdebugread.c (parse_partial_symbols): Update.
4707         (handle_psymbol_enumerators): Update.
4708         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4709         * psymtab.c (add_psymbol_to_bcache): Likewise.
4710         (add_psymbol_to_list): Likewise.
4711         * symtab.c (symbol_set_names): Likewise.
4712         * symtab.h (symbol_set_names): Likewise.
4713         * xcoffread.c (scan_xcoff_symtab): Update.
4714
4715 2019-09-11  Tom Tromey  <tom@tromey.com>
4716
4717         * symfile-mem.c (symbol_file_add_from_memory): Use
4718         bfd_set_filename.
4719         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4720         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4721
4722 2019-09-10  Tom Tromey  <tromey@adacore.com>
4723
4724         * dwarf-index-write.c (write_psymbols): Extend error message.
4725         (debug_names::insert): Add Ada code.
4726         (debug_names::write_psymbols): Remove Ada check.
4727         (debug_names) <m_string_obstack>: New member.
4728         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4729         (gdb_index_symbol_name_matcher::matches): Remove.
4730         (mapped_index_base::find_name_components_bounds): Add "lang"
4731         parameter.
4732         (mapped_index_base::build_name_components): Also split names
4733         according to Ada syntax.
4734         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4735         type of "match_callback".
4736         (check_match, check_find_bounds_finds)
4737         (dw2_expand_symtabs_matching): Update.
4738         (dw2_debug_names_iterator): Add new constructor.
4739         (dw2_debug_names_map_matching_symbols): New function.
4740         (dw2_debug_names_expand_symtabs_matching): Update.
4741         (dwarf2_debug_names_functions): Use
4742         dw2_debug_names_map_matching_symbols.
4743
4744 2019-09-10  Tom Tromey  <tromey@adacore.com>
4745
4746         * dwarf2read.c (dw2_get_file_names_reader): Add the
4747         CU's file name to the results.
4748
4749 2019-09-10  Tom Tromey  <tromey@adacore.com>
4750
4751         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4752         map_matching_symbols.  Update.
4753         * dwarf2read.c (dw2_map_matching_symbols): Update.
4754         * psymtab.c (match_partial_symbol): Change type; update.
4755         (psym_map_matching_symbols): Likewise.
4756         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4757         type; update.
4758         * symfile.h (struct quick_symbol_functions)
4759         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4760         Remove "match".
4761
4762 2019-09-10  Tom Tromey  <tromey@adacore.com>
4763
4764         * psymtab.c (map_block): Remove.
4765         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4766         * symtab.c (iterate_over_symbols_terminated): New function.
4767         * symtab.c (iterate_over_symbols_terminated): Declare.
4768
4769 2019-09-10  Tom Tromey  <tromey@adacore.com>
4770
4771         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4772         * language.h (struct language_defn) <la_iterate_over_symbols>:
4773         Return bool.
4774         * symtab.c (iterate_over_symbols): Return bool.
4775         * symtab.h (iterate_over_symbols): Return bool.
4776
4777 2019-09-10  Tom Tromey  <tromey@adacore.com>
4778
4779         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4780         (add_nonlocal_symbols): Update.
4781         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4782         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4783         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4784         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4785         Change type of "callback".  Remove "data".
4786
4787
4788 2019-09-09  Ali Tamur  <tamur@google.com>
4789
4790         * dwarf2read.c (comp_unit_head): Update comment.
4791         (dwarf2_dwo_name): New function declaration.
4792         (dwarf_unit_type_name): New function declaration.
4793         (read_comp_unit_head): Add support for new compilation units,
4794         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4795         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4796         (currently named as "signature") in their header. Also clarify error
4797         messages.
4798         (lookup_dwo_id): New function. Returns the dwo id of the given
4799         compile unit.
4800         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4801         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4802         functions.
4803         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4804         (dwarf2_dwo_name): Get the dwo name if present.
4805         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4806         purposes.
4807
4808 2019-09-09  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4811
4812 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4813
4814         * python/python.c (do_start_initialization): Make progname_copy static,
4815         to avoid a leak report.
4816
4817 2019-09-08  Tom Tromey  <tom@tromey.com>
4818
4819         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4820
4821 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4822
4823         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4824         Change type to gdb::optional<block_enum>.
4825         (dw2_symtab_iter_init): Change block_index parameter type
4826         to gdb::optional<block_enum>.
4827         (dw2_lookup_symbol): Change block_index parameter
4828         type to block_enum.c
4829         (dw2_debug_names_lookup_symbol): Likewise.
4830         * psymtab.c (psym_lookup_symbol): Likewise.
4831         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4832         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4833         Likewise.
4834
4835 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4836
4837         * defs.h (relocate_gdb_directory): Change int to bool in
4838         signature and rename flag to relocatable.
4839         * main.c (relocate_path): Likewise.
4840         (relocate_gdb_directory): Likewise.
4841
4842 2019-09-06  Alan Modra  <amodra@gmail.com>
4843
4844         * coffread.c (coff_symfile_read): Constify filename variable.
4845         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4846         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4847         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4848         * solib.c (reload_shared_libraries_1): Likewise.
4849         * symfile.c (reread_symbols): Likewise.
4850         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4851         * solib-darwin.c (darwin_bfd_open): Likewise.
4852         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4853
4854 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4857         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4858
4859 2019-09-03  Tom Tromey  <tromey@adacore.com>
4860
4861         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4862         types.
4863         (has_negatives): Unbias a range type bound.
4864         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4865         * gdbtypes.c (operator==): Handle new field.
4866         (create_range_type): Add "bias" parameter.
4867         (create_static_range_type, resolve_dynamic_range): Update.
4868         * gdbtypes.h (struct range_bounds) <bias>: New member.
4869         (create_range_type): Add bias parameter.
4870         * printcmd.c (print_scalar_formatted): Unbias range types.
4871         * value.c (unpack_long): Unbias range types.
4872         (pack_long): Bias range types.
4873
4874 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4875
4876         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4877         probe arguments.
4878
4879 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4880
4881         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4882         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4883         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4884         (compile_probe_arg): Likewise.
4885         * probe.h (get_argument_count): Likewise.
4886         * solib-svr4.c (solib_event_probe_action): Likewise.
4887         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4888
4889 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4890
4891         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4892         code to here...
4893         (svr4_create_solib_event_breakpoints): ...from here.
4894
4895 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4896
4897         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4898         suffix from warning message.
4899
4900 2019-08-30  Tom Tromey  <tom@tromey.com>
4901
4902         * tui/tui-winsource.h (struct tui_source_window_base)
4903         <refresh_all>: Don't declare.
4904         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4905         Remove.
4906         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4907         tui_show_locator_content.
4908         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4909         declare.
4910         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4911         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4912         declare.
4913
4914 2019-08-30  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4917
4918 2019-08-30  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4921         Remove unnecessary forward declarations.
4922
4923 2019-08-30  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4926         rerender.
4927         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4928         tui_show_locator_content.
4929
4930 2019-08-30  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4933         (tui_locator_window::rerender): Rewrite using body of previous
4934         tui_show_locator_content.
4935
4936 2019-08-30  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4939         set_locator_fullname>: New methods.
4940         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4941         Rename from tui_set_locator_fullname.
4942         (tui_locator_window::set_locator_info): Rename from
4943         tui_set_locator_info.  Return bool.
4944         (tui_update_locator_fullname, tui_show_frame_info): Update.
4945
4946 2019-08-30  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4949
4950 2019-08-30  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4953         call touchwin.
4954
4955 2019-08-30  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-wingeneral.c (box_win): Assume win_info and
4958         win_info->handle cannot be NULL.
4959
4960 2019-08-30  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4963         refresh_window>: Declare.
4964         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4965         resize.
4966         (tui_data_item_window::rerender): Rename from
4967         tui_display_register.
4968         (tui_data_item_window::refresh_window): New method.
4969         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4970         no-op.
4971
4972 2019-08-30  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4975         regs_column_count, current_group>: Move later.  Now private.
4976         <get_current_group>: New method.
4977         * tui/tui-regs.c (tui_reg_command): Update.
4978         * tui/tui-layout.c (tui_set_layout): Update.
4979
4980 2019-08-30  Tom Tromey  <tom@tromey.com>
4981
4982         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4983         (tui_data_window::rerender): Don't call
4984         check_and_display_highlight_if_needed.
4985         (tui_data_window::refresh_all): Remove call to
4986         erase_data_content.
4987
4988 2019-08-30  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4991         (tui_data_window::display_registers_from)
4992         (tui_data_window::display_reg_element_at_line)
4993         (tui_data_window::display_registers_from_line): Remove checks of
4994         "empty".
4995
4996 2019-08-30  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4999         Don't declare.
5000         * tui/tui-regs.c (tui_data_window::show_registers): Call
5001         rerender.
5002         (tui_data_window::rerender): Rename from display_all_data.
5003         (tui_data_window::rerender): Remove old implementation.
5004
5005 2019-08-30  Tom Tromey  <tom@tromey.com>
5006
5007         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5008         text.
5009         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5010
5011 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5012             Sergio Durigan Junior  <sergiodj@redhat.com>
5013
5014         PR win32/24284
5015         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5016
5017 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5020         when searching for types.
5021
5022 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * f-lang.c (f_language_defn): Use f_print_typedef.
5025         * f-lang.h (f_print_typedef): Declare.
5026         * f-typeprint.c (f_print_typedef): Define.
5027
5028 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5029
5030         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5031
5032 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * cli/cli-utils.c (info_print_options_defs): Delete.
5035         (make_info_print_options_def_group): Delete.
5036         (extract_info_print_options): Delete.
5037         (info_print_command_completer): Delete.
5038         (info_print_args_help): Add extra parameter, and optionally
5039         include text about -n flag.
5040         * cli/cli-utils.h (struct info_print_options): Delete.
5041         (extract_info_print_options): Delete declaration.
5042         (info_print_command_completer): Delete declaration.
5043         (info_print_args_help): Add extra parameter, extend header
5044         comment.
5045         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5046         search_symbols.
5047         * stack.c (struct info_print_options): New type.
5048         (info_print_options_defs): New file scoped variable.
5049         (make_info_print_options_def_group): New static function.
5050         (info_print_command_completer): New static function.
5051         (info_locals_command): Update to use new local functions.
5052         (info_args_command): Likewise.
5053         (_initialize_stack): Add extra parameter to calls to
5054         info_print_args_help.
5055         * symtab.c (search_symbols): Add extra parameter, use this to
5056         possibly excluse non-debug symbols.
5057         (symtab_symbol_info): Add extra parameter, which is passed on to
5058         search_symbols.
5059         (struct info_print_options): New type.
5060         (info_print_options_defs): New file scoped variable.
5061         (make_info_print_options_def_group): New static function.
5062         (info_print_command_completer): New static function.
5063         (info_variables_command): Update to use local functions, and pass
5064         extra parameter through to symtab_symbol_info.
5065         (info_functions_command): Likewise.
5066         (info_types_command): Pass additional argument through to
5067         symtab_symbol_info.
5068         (rbreak_command): Pass extra argument to search_symbols.
5069         (_initialize_symtab): Add extra arguments for calls to
5070         info_print_args_help, and update help text for 'info variables',
5071         'whereis', and 'info functions' commands.
5072         * symtab.h (search_symbols): Add extra argument to declaration.
5073         * NEWS: Mention new flags.
5074
5075 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5076
5077         * symtab.c (lookup_static_symbol): Call the new function (and move
5078         it down to be next to lookup_global_symbol).
5079         (struct global_sym_lookup_data): Add block_enum member and rename to...
5080         (struct global_or_static_sym_lookup_data): ...this.
5081         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5082         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5083         (lookup_symbol_global_or_static_iterator_cb): ...this.
5084         (lookup_global_or_static_symbol): New function.
5085         (lookup_global_symbol): Call new function.
5086
5087 2019-08-26  Tom de Vries  <tdevries@suse.de>
5088
5089         PR c++/24852
5090         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5091         when pc_probe.prob == NULL.
5092
5093 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5094
5095         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5096         variable symbol_linkage to symbol_linkage_.
5097
5098 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5099
5100         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5101         represent whether the symbol is static, dynamic, or we don't
5102         know.
5103
5104 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5105
5106         * gdb/rx-tdep.c (rx_register_names): New.
5107         (rx_register_name): Delete.
5108         (rx_psw_type): Delete.
5109         (rx_fpsw_type): Delete.
5110         (rx_register_type): Delete.
5111         (rx_gdbarch_init): Convert target-descriptions.
5112         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5113         * gdb/features/Makefile: Add rx.xml.
5114         * gdb/features/rx.xml: New.
5115         * gdb/features/rx.c: Generated.
5116         * gdb/NEWS: Mention target description support.
5117
5118 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5119
5120         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5121         *slot_ptr.
5122
5123 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5124
5125         * configure.ac: Don't check for 'dlfcn.h' (moved to
5126         gdbsupport/common.m4).
5127         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5128         'gdbsupport/'.
5129         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5130         * compile/compile-c-support.c: Include
5131         'gdbsupport/gdb-dlfcn.h'.
5132         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5133         * gdb-dlfcn.c: Move to...
5134         * gdbsupport/gdb-dlfcn.c: ... here.
5135         * gdb-dlfcn.h: Move to...
5136         * gdbsupport/gdb-dlfcn.h: ... here.
5137
5138 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5139
5140         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5141         the offset field signed.
5142
5143 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5144
5145         * python/lib/gdb/__init__.py (_execute_file): New function.
5146         * python/python.c (python_run_simple_file): Call gdb._execute_file
5147         on Windows.
5148
5149 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5152         all uses as this was never set to anything but a zero value.
5153
5154 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5155
5156         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5157
5158 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5159
5160         * tui/tui-data.h (tui_gen_win_info): Add an =default
5161         move constructor, required by some GCC versions.
5162
5163 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5164
5165         * go32-nat.c (go32_sysinfo): Add hygon_p.
5166
5167 2019-08-20  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5170         line_from_reg_element_no, first_reg_element_no_inline,
5171         display_all_data, delete_data_content_windows,
5172         erase_data_content>: Now private.
5173
5174 2019-08-20  Tom Tromey  <tom@tromey.com>
5175
5176         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5177         (tui_unhighlight_win, tui_highlight_win)
5178         (tui_win_info::make_window): Update.
5179         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5180
5181 2019-08-20  Tom Tromey  <tom@tromey.com>
5182
5183         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5184         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5185         (MAX_PID_WIDTH): Move to tui-stack.c.
5186         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5187         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5188         (MAX_PID_WIDTH): Move from tui-data.h.
5189
5190 2019-08-20  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5193         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5194         (box_win): Update.
5195         (tui_gen_win_info::make_window): Rename from tui_make_window.
5196         (tui_win_info::make_window): New method.
5197         (tui_gen_win_info::make_visible): Update.
5198         * tui/tui-source.c (tui_source_window::set_contents): Update.
5199         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5200         (tui_data_window::display_registers_from): Update.
5201         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5202         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5203         Declare.
5204         <can_box>: Remove.
5205         <title>: Remove.
5206         (struct tui_win_info) <make_window>: Declare.
5207         <can_box>: Now virtual.
5208         <title>: New member.
5209         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5210         * tui/tui-command.c (tui_cmd_window::resize): Update.
5211
5212 2019-08-20  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5215         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5216         (tui_data_window::check_register_values): Update.
5217
5218 2019-08-20  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-regs.h (struct tui_data_window): Use
5221         DISABLE_COPY_AND_ASSIGN.
5222         <regs_content>: Change type, removing unique_ptr.
5223         <tui_data_window>: Add move constructor.
5224         * tui/tui-regs.c (tui_data_window::show_registers)
5225         (tui_data_window::show_register_group)
5226         (tui_data_window::display_registers_from)
5227         (tui_data_window::display_registers_from)
5228         (tui_data_window::first_data_item_displayed)
5229         (tui_data_window::delete_data_content_windows)
5230         (tui_data_window::rerender, tui_data_window::refresh_window)
5231         (tui_data_window::check_register_values): Update.
5232
5233 2019-08-20  Tom Tromey  <tom@tromey.com>
5234
5235         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5236         show_register_group>: Declare.
5237         (tui_show_register_group): Don't declare.
5238         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5239         tui_show_registers.
5240         (tui_data_window::show_register_group): Rename from
5241         tui_show_register_group.
5242         (tui_data_window::check_register_values, tui_reg_command):
5243         Update.
5244         * tui/tui-layout.c (tui_set_layout): Update.
5245
5246 2019-08-20  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5249         Declare.
5250         (tui_check_register_values): Don't declare.
5251         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5252         from tui_check_register_values.
5253         * tui/tui-hooks.c (tui_register_changed): Update.
5254
5255 2019-08-20  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-regs.c (tui_reg_layout): Move later.
5258         (tui_show_registers): Don't enable TUI mode or change layout.
5259
5260 2019-08-20  Tom Tromey  <tom@tromey.com>
5261
5262         * tui/tui-regs.h (struct tui_data_item_window)
5263         <~tui_data_item_window>: Remove.
5264         <content>: Now a unique_xmalloc_ptr.
5265         * tui/tui-regs.c (tui_register_format): Return a
5266         unique_xmalloc_ptr.
5267         (tui_get_register): Update.
5268         (~tui_data_item_window): Remove.
5269         (tui_data_window::display_registers_from, tui_display_register):
5270         Update.
5271         * tui/tui-io.h (tui_expand_tabs): Update.
5272         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5273         Remove "col" parameter.
5274
5275 2019-08-20  Tom Tromey  <tom@tromey.com>
5276
5277         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5278         field.
5279         * tui/tui-regs.c (~tui_data_item_window): Update.
5280
5281 2019-08-20  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5284         earlier.
5285
5286 2019-08-20  Tom Tromey  <tom@tromey.com>
5287
5288         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5289
5290 2019-08-20  Tom Tromey  <tom@tromey.com>
5291
5292         * tui/tui-source.h (struct tui_source_window): Update.
5293         * tui/tui-regs.c (tui_show_registers): Update.
5294         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5295         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5296         (NO_REGS_STRING): Remove defines.
5297
5298 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5299
5300         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5301         unnecessary thread walk if remote doesn't support the packet.
5302
5303 2019-08-19  Tom Tromey  <tromey@adacore.com>
5304
5305         * python/py-value.c (value_has_field): Fix indentation.
5306
5307 2019-08-19  Tom Tromey  <tromey@adacore.com>
5308
5309         * printcmd.c (do_one_display, info_display_command): Update.
5310         * block.h (contained_in): Return bool.  Add allow_nested
5311         parameter.
5312         * block.c (contained_in): Return bool.  Add allow_nested
5313         parameter.
5314
5315 2019-08-19  Tom Tromey  <tom@tromey.com>
5316
5317         * configure: Rebuild.
5318         * configure.ac: Disallow the combination of -static-libstdc++ and
5319         source highlight.
5320         * source-cache.c (get_language_name): Handle rust.
5321         (source_cache::get_source_lines): Ignore highlighting exceptions.
5322
5323 2019-08-16  Tom Tromey  <tom@tromey.com>
5324
5325         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5326         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5327         (struct tui_source_window_base) <make_visible, refresh_window,
5328         resize>: Remove methods.
5329         <execution_info>: Remove field.
5330         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5331         (tui_show_source_line, tui_source_window_base)
5332         (~tui_source_window_base): Update.
5333         (tui_source_window_base::resize)
5334         (tui_source_window_base::make_visible)
5335         (tui_source_window_base::refresh_window): Remove.
5336         (tui_source_window_base::update_exec_info): Update.
5337         * tui/tui-source.c (tui_source_window::set_contents): Update.
5338         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5339
5340 2019-08-16  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5343         deprecated_query_hook.
5344
5345 2019-08-16  Tom Tromey  <tom@tromey.com>
5346
5347         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5348         (tui_update_source_windows_with_line): Update.
5349         * tui/tui-source.h (struct tui_source_window)
5350         <show_symtab_source>: Declare.
5351         (tui_show_symtab_source): Don't declare.
5352         * tui/tui-source.c (tui_show_symtab_source): Rename from
5353         tui_show_symtab_source.
5354
5355 2019-08-16  Tom Tromey  <tom@tromey.com>
5356
5357         * tui/tui-winsource.h (struct tui_source_window_base)
5358         <set_contents>: Declare.
5359         * tui/tui-winsource.c
5360         (tui_source_window_base::update_source_window_as_is): Update.
5361         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5362         Declare.
5363         (tui_set_source_content): Don't declare.
5364         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5365         tui_set_source_content.
5366         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5367         Declare.
5368         (tui_set_disassem_content): Don't declare.
5369         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5370         tui_set_disassem_content.
5371
5372 2019-08-16  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-winsource.h (struct tui_source_window_base)
5375         <update_breakpoint_info>: Declare.
5376         (tui_update_breakpoint_info): Don't declare.
5377         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5378         (tui_update_all_breakpoint_info): Update.
5379         (tui_source_window_base::update_breakpoint_info): Rename from
5380         tui_update_breakpoint_info.
5381         (tui_source_window_base::update_exec_info): Update.
5382
5383 2019-08-16  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-winsource.h (struct tui_source_window_base)
5386         <update_source_window>: Declare.
5387         (tui_update_source_window): Don't declare.
5388         * tui/tui-winsource.c
5389         (tui_source_window_base::update_source_window): Rename from
5390         tui_update_source_window.
5391         (tui_source_window_base::rerender): Update.
5392         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5393         * tui/tui-disasm.c (tui_show_disassem)
5394         (tui_show_disassem_and_update_source)
5395         (tui_disasm_window::maybe_update): Update.
5396
5397 2019-08-16  Tom Tromey  <tom@tromey.com>
5398
5399         * tui/tui-winsource.h (struct tui_source_window_base)
5400         <update_source_window_as_is>: Declare.
5401         (tui_update_source_window_as_is): Don't declare.
5402         * tui/tui-winsource.c (tui_update_source_window): Update
5403         (tui_source_window_base::update_source_window_as_is): Rename from
5404         tui_update_source_window_as_is.
5405         (tui_source_window_base::refill): Update.
5406         * tui/tui-source.c (tui_show_symtab_source): Update.
5407         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5408         Update.
5409
5410 2019-08-16  Tom Tromey  <tom@tromey.com>
5411
5412         * tui/tui-winsource.h (tui_update_source_window)
5413         (tui_update_source_window_as_is): Remove "noerror" parameter.
5414         * tui/tui-winsource.c (tui_update_source_window)
5415         (tui_update_source_window_as_is): Remove "noerror" parameter.
5416         (tui_update_source_windows_with_addr)
5417         (tui_update_source_windows_with_line)
5418         (tui_source_window_base::rerender)
5419         (tui_source_window_base::refill): Update.
5420         * tui/tui-source.h (tui_set_source_content)
5421         (tui_show_symtab_source): Remove "noerror" parameter.
5422         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5423         parameter.
5424         (tui_show_symtab_source): Likewise.
5425         (tui_source_window::maybe_update): Update.
5426         * tui/tui-disasm.c (tui_show_disassem)
5427         (tui_show_disassem_and_update_source)
5428         (tui_disasm_window::do_scroll_vertical)
5429         (tui_disasm_window::maybe_update): Update.
5430
5431 2019-08-16  Tom Tromey  <tom@tromey.com>
5432
5433         * tui/tui.c (tui_is_window_visible): Update.
5434         * tui/tui-wingeneral.c (tui_make_window)
5435         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5436         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5437         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5438         (tui_set_win_height_command, parse_scrolling_args): Update.
5439         * tui/tui-source.c (tui_source_window::style_changed): Update.
5440         * tui/tui-regs.c (tui_show_registers)
5441         (tui_data_window::first_data_item_displayed)
5442         (tui_data_window::delete_data_content_windows)
5443         (tui_check_register_values, tui_reg_command): Update.
5444         * tui/tui-disasm.c (tui_show_disassem): Update.
5445         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5446         method.
5447         <is_visible>: Remove field.
5448         * tui/tui-data.c (tui_next_win, tui_prev_win)
5449         (tui_delete_invisible_windows): Update.
5450
5451 2019-08-16  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-winsource.h (struct tui_source_window_base)
5454         <m_has_locator>: Remove.
5455         * tui/tui-layout.c (show_source_disasm_command, show_data)
5456         (show_source_or_disasm_and_command): Update.
5457
5458 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5459
5460         * NEWS (Other MI changes): New subsection.
5461         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5462         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5463         * arch-utils.c (default_get_pc_address_flags): New function.
5464         * arch-utils.h (default_get_pc_address_flags): New declaration.
5465         * gdbarch.sh: Add get_pc_address_flags.
5466         * gdbarch.c: Regenerate.
5467         * gdbarch.h: Likewise.
5468         * stack.c (print_pc): New function.
5469         (print_frame_info) (print_frame): Call print_pc.
5470
5471 2019-08-16  Tom de Vries  <tdevries@suse.de>
5472
5473         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5474         print_objfile_section_info.
5475
5476 2019-08-15  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5479         calling update_cmdwin_start_line.
5480         * tui/tui-winsource.h (struct tui_source_window_base)
5481         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5482         <rerender>: Declare.
5483         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5484         Call rerender.
5485         (tui_source_window_base::set_new_height): Remove.
5486         (tui_source_window_base::rerender): Rename from
5487         do_make_visible_with_new_height.
5488         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5489         resize method.
5490         (tui_win_info::make_invisible_and_set_new_height)
5491         (tui_win_info::make_visible_with_new_height): Remove.
5492         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5493         Declare.
5494         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5495         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5496         do_make_visible_with_new_height>: Don't declare.
5497         <rerender>: Declare.
5498         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5499         set_new_height.
5500         (tui_data_window::do_make_visible_with_new_height): Remove.
5501         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5502         call tui_show_locator_content.
5503         (tui_gen_win_info::resize): Call rerender.
5504         (show_source_or_disasm_and_command): Don't call
5505         tui_show_locator_content.
5506         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5507         method.
5508         (struct tui_win_info) <rerender>: Declare.
5509         <set_new_height, make_invisible_and_set_new_height,
5510         make_visible_with_new_height>: Don't declare.
5511         * tui/tui-data.c (tui_win_list::rerender): New method.
5512         * tui/tui-command.h (struct tui_cmd_window)
5513         <do_make_visible_with_new_height>: Don't declare.
5514         * tui/tui-command.c
5515         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5516
5517 2019-08-15  Tom Tromey  <tromey@adacore.com>
5518
5519         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5520         * ada-lang.c (ada_enum_name): Likewise.
5521
5522 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5523
5524         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5525         leading underscore.
5526         (GdbOutputErrorFile): Likewise.
5527         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5528         accordingly.
5529         (execute_unwinders): Rename to have a leading underscore.
5530         (auto_load_packages): Likewise.
5531         (global scope): Adjust call to auto_load_packages accordingly.
5532         (GdbSetPythonDirectory): Likewise.
5533         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5534         instead of execute_unwinders.
5535
5536 2019-08-15  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5539         (show_data): Don't change window visibility.
5540         (tui_gen_win_info::resize): Remove special case for command
5541         window.  Use wresize, when available.
5542         (show_source_or_disasm_and_command): Don't change window
5543         visibility.
5544         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5545         <make_visible>: New method.
5546         * tui/tui-command.c (tui_cmd_window::resize): New method.
5547
5548 2019-08-15  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5551         (struct tui_source_windows): New.
5552         * tui/tui-winsource.c (tui_display_main): Update.
5553         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5554         (new_height_ok, parse_scrolling_args): Update.
5555         * tui/tui-layout.c (show_layout, show_data): Update.
5556         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5557         (tui_add_to_source_windows): Don't declare.
5558         * tui/tui-data.c (source_windows, tui_source_windows)
5559         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5560
5561 2019-08-15  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5564         Rename from reset.
5565         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5566         * tui/tui-layout.c (show_source_disasm_command, show_data):
5567         Update.
5568         (tui_gen_win_info::resize): Rename.
5569         (show_source_or_disasm_and_command): Update.
5570         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5571         reset.
5572
5573 2019-08-15  Tom Tromey  <tom@tromey.com>
5574
5575         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5576         * tui/tui-interp.c (tui_interp::init): Don't call
5577         tui_initialize_static_data.
5578         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5579
5580 2019-08-15  Tom Tromey  <tom@tromey.com>
5581
5582         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5583         examine tui_win_list.
5584
5585 2019-08-15  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5588         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5589         tui_clear_source_content.
5590         (tui_clear_source_content): Remove.
5591         (tui_source_window_base::do_erase_source_content): Hoist call to
5592         content.clear().
5593         * tui/tui-stack.c (tui_show_frame_info): Don't call
5594         tui_clear_source_content.
5595
5596 2019-08-15  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-winsource.h (struct tui_source_window_base)
5599         <do_erase_source_content>: New method.
5600         <erase_source_content>: New method.
5601         (tui_erase_source_content): Don't declare.
5602         * tui/tui-winsource.c (tui_clear_source_content): Update.
5603         (tui_source_window_base::do_erase_source_content): Rename from
5604         tui_erase_source_content.
5605         (tui_source_window_base::show_source_content): Update.
5606         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5607         * tui/tui-source.h (struct tui_source_window)
5608         <erase_source_content>: New method.
5609         * tui/tui-disasm.h (struct tui_disasm_window)
5610         <erase_source_content>: New method.
5611
5612 2019-08-15  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5615         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5616         constructor.
5617         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5618         * tui/tui-source.c (tui_set_source_content): Update.
5619         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5620
5621 2019-08-15  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5624         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5625         tui-source.c.
5626         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5627         Declare.
5628         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5629         method.
5630         (tui_source_window::maybe_update): Update.
5631
5632 2019-08-15  Tom Tromey  <tom@tromey.com>
5633
5634         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5635         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5636         tui-disasm.c.
5637         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5638         Declare.
5639         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5640         method.
5641         (tui_disasm_window::maybe_update): Update.
5642
5643 2019-08-15  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-winsource.h (struct tui_source_window_base)
5646         <maybe_update>: Declare.
5647         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5648         method.
5649         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5650         Declare.
5651         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5652         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5653         Declare.
5654         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5655
5656 2019-08-15  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5659
5660 2019-08-15  Tom Tromey  <tom@tromey.com>
5661
5662         * tui/tui-wingeneral.c: Include tui-stack.h.
5663         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5664         (struct tui_locator_window): Move from tui-data.h.
5665         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5666         (tui_initialize_static_data): Move from tui-data.c.
5667         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5668         (struct tui_locator_window): Move to tui-stack.c.
5669         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5670         (tui_initialize_static_data): Move to tui-stack.c.
5671
5672 2019-08-15  Tom Tromey  <tom@tromey.com>
5673
5674         * tui/tui-layout.c (show_source_disasm_command)
5675         (show_source_or_disasm_and_command): Use make_visible method, not
5676         tui_make_window.
5677         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5678         Remove.
5679
5680 2019-08-15  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui-wingeneral.h (tui_make_window): Update.
5683         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5684         parameter.
5685         (tui_gen_win_info::make_visible): Update.
5686         * tui/tui-regs.c (tui_data_window::display_registers_from):
5687         Update.
5688         * tui/tui-layout.c (show_source_disasm_command)
5689         (show_source_or_disasm_and_command): Update.
5690         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5691         (enum tui_box): Remove.
5692         (struct tui_win_info) <can_box>: New method.
5693         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5694         method.
5695
5696 2019-08-15  Tom de Vries  <tdevries@suse.de>
5697
5698         * linux-nat-trad.c: Include gdbarch.h.
5699
5700 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5701
5702         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5703         register sizes.
5704
5705 2019-08-14  Tom Tromey  <tromey@adacore.com>
5706
5707         * darwin-nat.c: Include gdbarch.h.
5708         * darwin-nat-info.c: Include gdbarch.h.
5709
5710 2019-08-13  Tom Tromey  <tom@tromey.com>
5711
5712         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5713         Remove.
5714         * tui/tui-data.c (tui_initialize_static_data): Update.
5715
5716 2019-08-13  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-winsource.h (struct tui_exec_info_window)
5719         <~tui_exec_info_window, maybe_allocate_content, get_content,
5720         m_content>: Remove.
5721         (struct tui_source_window_base) <set_exec_info_content,
5722         show_exec_info_content>: Don't declare.
5723         * tui/tui-winsource.c
5724         (tui_exec_info_window::maybe_allocate_content): Remove.
5725         (tui_source_window_base::update_exec_info): Rename from
5726         set_exec_info_content.
5727         (tui_source_window_base::show_exec_info_content)
5728         (tui_source_window_base::update_exec_info): Remove.
5729
5730 2019-08-13  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5733         declare.
5734         * tui/tui-winsource.c (tui_update_source_window_as_is)
5735         (tui_update_source_windows_with_addr, tui_erase_source_content):
5736         Update.
5737         (tui_clear_exec_info_content): Remove.
5738
5739 2019-08-13  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5742         declare.
5743         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5744         call tui_erase_exec_info_content.
5745         (tui_clear_exec_info_content): Rename from
5746         tui_erase_exec_info_content.
5747         (tui_clear_exec_info_content): Delete.
5748
5749 2019-08-13  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-winsource.h (struct tui_source_window_base)
5752         <show_exec_info_content>: Declare.
5753         (tui_show_exec_info_content): Don't declare.
5754         * tui/tui-winsource.c
5755         (tui_source_window_base::show_exec_info_content): Rename from
5756         tui_show_exec_info_content.
5757         (tui_source_window_base::update_exec_info): Update.
5758
5759 2019-08-13  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5762         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5763         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5764         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5765         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5766         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5767         ... here.
5768
5769 2019-08-13  Tom Tromey  <tom@tromey.com>
5770
5771         * tui/tui-winsource.h (struct tui_source_window_base)
5772         <update_exec_info>: Declare.
5773         (tui_update_exec_info): Don't declare.
5774         * tui/tui-winsource.c (tui_update_source_window_as_is)
5775         (tui_source_window_base::refresh_all)
5776         (tui_update_all_breakpoint_info): Update.
5777         (tui_source_window_base::update_exec_info): Rename from
5778         tui_update_exec_info.
5779         * tui/tui-stack.c (tui_show_frame_info): Update.
5780
5781 2019-08-13  Tom Tromey  <tom@tromey.com>
5782
5783         * tui/tui-winsource.h (struct tui_source_window_base)
5784         <set_exec_info_content>: Declare.
5785         (tui_set_exec_info_content): Don't declare.
5786         * tui/tui-winsource.c
5787         (tui_source_window_base::set_exec_info_content): Rename from
5788         tui_set_exec_info_content.
5789         (tui_update_exec_info): Update.
5790
5791 2019-08-13  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-winsource.h (struct tui_source_window_base)
5794         <show_source_content>: Declare.
5795         (tui_show_source_content): Don't declare.
5796         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5797         (tui_source_window_base::show_source_content): Rename from
5798         tui_show_source_content.
5799         (tui_source_window_base::refresh_all): Update.
5800         * tui/tui-layout.c (show_source_disasm_command)
5801         (show_source_or_disasm_and_command): Update.
5802
5803 2019-08-13  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-winsource.c (tui_erase_source_content)
5806         (tui_show_source_content, tui_source_window_base::refresh_all):
5807         Update.
5808         * tui/tui-wingeneral.h
5809         (tui_check_and_display_highlight_if_needed): Don't declare.
5810         * tui/tui-wingeneral.c
5811         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5812         check_and_display_highlight_if_needed.
5813         * tui/tui-win.c (tui_rehighlight_all)
5814         (tui_win_info::make_visible_with_new_height): Update.
5815         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5816         (tui_data_window::erase_data_content)
5817         (tui_data_window::display_all_data): Update.
5818         * tui/tui-data.h (struct tui_win_info)
5819         <check_and_display_highlight_if_needed>: Declare.
5820
5821 2019-08-13  Tom Tromey  <tom@tromey.com>
5822
5823         * tui/tui-win.c (tui_resize_all): Call
5824         tui_delete_invisible_windows.
5825         * tui/tui-layout.c (show_layout): Call
5826         tui_delete_invisible_windows.
5827         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5828         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5829
5830 2019-08-13  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5833         tui_add_win_to_layout.
5834
5835 2019-08-13  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5838         * tui/tui-layout.c (tui_default_win_height): Now static.
5839
5840 2019-08-13  Tom Tromey  <tom@tromey.com>
5841
5842         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5843         single switch.
5844         (show_source_disasm_command, show_source_or_disasm_and_command):
5845         Don't check current layout.
5846
5847 2019-08-13  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-wingeneral.c (make_all_visible): Remove.
5850         (tui_make_all_invisible): Simplify.
5851         * tui/tui-layout.c (tui_make_all_invisible): Move from
5852         tui-wingeneral.c; simplify.
5853         (show_layout): Hoist call to tui_make_all_invisible.
5854         (show_data): Don't call tui_make_all_invisible.
5855
5856 2019-08-13  Tom Tromey  <tom@tromey.com>
5857
5858         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5859         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5860
5861 2019-08-13  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5864         tui-data.c.
5865         (show_source_disasm_command, show_data)
5866         (show_source_or_disasm_and_command): Don't use
5867         tui_set_current_layout_to.
5868         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5869         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5870         tui-layout.c.
5871         (tui_set_current_layout_to): Remove.
5872
5873 2019-08-13  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui-layout.c (tui_set_layout): Update.
5876         * tui/tui-data.h (struct tui_layout_def): Remove.
5877         (tui_layout_def): Don't declare.
5878         * tui/tui-data.c (layout_def): Remove.
5879         (tui_layout_def): Remove.
5880
5881 2019-08-13  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-winsource.h (struct tui_source_window_base)
5884         <clear_detail>: No longer "override".
5885         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5886         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5887         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5888         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5889         Remove.
5890         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5891
5892 2019-08-13  Tom Tromey  <tromey@adacore.com>
5893
5894         * tracepoint.c: Don't include readline.h or history.h.
5895
5896 2019-08-12  Tom Tromey  <tom@tromey.com>
5897
5898         * configure: Rebuild.
5899         * configure.ac: Check for readline 7.
5900         * NEWS: Mention readline 7 requirement.
5901         * README: Update.
5902
5903 2019-08-12  Tom Tromey  <tom@tromey.com>
5904
5905         * mingw-hdep.c (gdb_select): Remove readline hack.
5906
5907 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5908
5909         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5910         when the function fails.
5911
5912 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5913
5914         * s390-tdep.c (s390_type_align): New function.
5915         (s390_gdbarch_init): Set it as type_align gdbarch method.
5916
5917 2019-08-09  Tom de Vries  <tdevries@suse.de>
5918
5919         PR gdb/24591
5920         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5921         pc_low with relocation offset.
5922
5923 2019-08-07  Tom Tromey  <tromey@adacore.com>
5924
5925         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5926         (print_frame_args): Update.
5927         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5928         Update.
5929         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5930         * frame.h (struct frame_arg): Add initializers.
5931         <error>: Now a unique_xmalloc_ptr.
5932
5933 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5934
5935         * NEWS: Expand the Pointer Authentication entry.
5936         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5937         (aarch64_frame_unmask_lr): ... to this.
5938         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5939         Call aarch64_frame_unmask_lr.
5940         * frame.c (struct frame_info): Add "masked" variable.
5941         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5942         (fprint_frame): Check for masked pc.
5943         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5944         declarations.
5945         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5946         * stack.c (print_frame): Check for masked pc.
5947
5948 2019-08-06  Tom Tromey  <tom@tromey.com>
5949
5950         * stabsread.c (patch_block_stabs, read_one_struct_field)
5951         (read_enum_type): Use obstack_strndup.
5952         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5953         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5954         * dwarf2read.c (guess_full_die_structure_name)
5955         (anonymous_struct_prefix): Use obstack_strndup.
5956         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5957         * c-exp.y (yylex): Use obstack_strndup.
5958         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5959         (write_var_or_type): Use obstack_strndup.
5960
5961 2019-08-06  Tom Tromey  <tom@tromey.com>
5962
5963         * symfile.c (reread_symbols): Use obstack_strdup.
5964         * stabsread.c (read_type): Use obstack_strdup.
5965         * gdb_obstack.h (obstack_strdup): New overload.
5966         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5967         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5968         (dwarf2_canonicalize_name): Use obstack_strdup.
5969         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5970         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5971         Use obstack_strdup.
5972
5973 2019-08-06  Tom Tromey  <tom@tromey.com>
5974
5975         * gdb_obstack.h (obstack_strdup): Define.
5976         * gdb_obstack.c (obstack_strdup): Don't define.
5977
5978 2019-08-06  Tom Tromey  <tom@tromey.com>
5979
5980         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5981         obstack_strdup.
5982         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5983         obstack_strdup.
5984         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5985         * stabsread.c (common_block_start): Use obstack_strdup.
5986         * objfiles.c (set_objfile_main_name, objfile): Use
5987         obstack_strdup.
5988         * namespace.c (add_using_directive): Use obstack_strdup.
5989         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5990         * jit.c (finalize_symtab): Use obstack_strdup.
5991         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5992         (guess_partial_die_structure_name, partial_die_info::fixup)
5993         (dwarf2_name): Use obstack_strdup.
5994         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5995         obstack_strdup.
5996         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5997         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5998         obstack_strdup.
5999         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6000
6001 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6002
6003         * unittests/help-doc-selftests.c: New file.
6004         * Makefile.in: Add the new file.
6005
6006 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6007
6008         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6009         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6010         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6011         the trailing '.' is not output, and the first character is uppercased.
6012         (print_help_for_command): Update call to print_doc_line.
6013         (print_doc_of_command): Likewise.
6014         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6015         * cli/cli-option.c (append_indented_doc): Do not append newline.
6016         (build_help_option): Append newline after first appended_indented_doc
6017         only if a second call is done.
6018         (build_help): Append 2 new lines before each option, except the first
6019         one.
6020         * compile/compile.c (_initialize_compile): Add new lines after
6021         %OPTIONS%, when not at the end of the help.
6022         Change help doc or code
6023         producing the help doc to respect the invariants.
6024         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6025         Also removed the new line after 'Options:', as all other commands
6026         do not put an empty line between 'Options:' and the first option.
6027         * printcmd.c (_initialize_printcmd): Likewise.
6028         * stack.c (_initialize_stack): Likewise.
6029         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6030         incorrectly telling COMMAND is optional.
6031         * ada-lang.c (_initialize_ada_language): Change help doc or code
6032         producing the help doc to respect the invariants.
6033         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6034         * breakpoint.c (_initialize_breakpoint): Likewise.
6035         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6036         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6037         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6038         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6039         _initialize_cli_style): Likewise.
6040         * corelow.c (core_target_info): Likewise.
6041         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6042         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6043         * filesystem.c (_initialize_filesystem): Likewise.
6044         * frame.c (_initialize_frame): Likewise.
6045         * gnu-nat.c (add_task_commands): Likewise.
6046         * infcall.c (_initialize_infcall): Likewise.
6047         * infcmd.c (_initialize_infcmd): Likewise.
6048         * interps.c (_initialize_interpreter): Likewise.
6049         * language.c (_initialize_language): Likewise.
6050         * linux-fork.c (_initialize_linux_fork): Likewise.
6051         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6052         * maint.c (_initialize_maint_cmds): Likewise.
6053         * memattr.c (_initialize_mem): Likewise.
6054         * printcmd.c (_initialize_printcmd): Likewise.
6055         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6056         _RegEx): Likewise.
6057         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6058         * record-btrace.c (_initialize_record_btrace): Likewise.
6059         * record-full.c (_initialize_record_full): Likewise.
6060         * record.c (_initialize_record): Likewise.
6061         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6062         * regcache.c (_initialize_regcache): Likewise.
6063         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6064         _initialize_remote): Likewise.
6065         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6066         * serial.c (_initialize_serial): Likewise.
6067         * skip.c (_initialize_step_skip): Likewise.
6068         * source.c (_initialize_source): Likewise.
6069         * stack.c (_initialize_stack): Likewise.
6070         * symfile.c (_initialize_symfile): Likewise.
6071         * symtab.c (_initialize_symtab): Likewise.
6072         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6073         * top.c (init_main): Likewise.
6074         * tracefile-tfile.c (tfile_target_info): Likewise.
6075         * tracepoint.c (_initialize_tracepoint): Likewise.
6076         * tui/tui-win.c (_initialize_tui_win): Likewise.
6077         * utils.c (add_internal_problem_command): Likewise.
6078         * valprint.c (value_print_option_defs): Likewise.
6079
6080 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6081
6082         PR build/24886
6083         * configure.ac: Drop enable-libmcheck support.
6084         * configure, config.in: Rebuild.
6085         * libmcheck.m4: Remove.
6086         * acinclude.m4: Don't include it.
6087         * Makefile.in: Don't distribute it.
6088         * top.c (print_gdb_configuration): Don't mention it.
6089
6090 2019-08-06  Tom Tromey  <tom@tromey.com>
6091
6092         * utils.c (set_output_style): Sometimes pass stream to
6093         emit_style_escape.
6094         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6095         * record-btrace.c (btrace_insn_history): Update.
6096         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6097         method.
6098         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6099         Update initializers.
6100         <m_uiout>: New field.
6101         <m_di>: Move lower.
6102         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6103         Remove "uiout" parameter.
6104         (dump_insns): Update.
6105         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6106         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6107
6108 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6109
6110         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6111         (error_in_psymtab_expansion): Likewise.
6112         (lookup_symbol_via_quick_fns): Likewise.
6113         (basic_lookup_transparent_type_quick): Likewise.
6114         (basic_lookup_transparent_type_1): Likewise.
6115
6116 2019-08-06  Tom Tromey  <tromey@adacore.com>
6117
6118         * source.c (last_source_error): Now bool.
6119         (print_source_lines_base): Make "noprint" bool.  Only open
6120         source file when last_source_visited changes.
6121
6122 2019-08-06  Tom Tromey  <tromey@adacore.com>
6123
6124         * annotate.c (annotate_source_line): Use g_source_cache.
6125         * source-cache.c (source_cache::get_plain_source_lines): Change
6126         parameters.  Populate m_offset_cache.
6127         (source_cache::ensure): New method.
6128         (source_cache::get_line_charpos): New method.
6129         (extract_lines): Move lower.  Change parameters.
6130         (source_cache::get_source_lines): Move lower.
6131         * source-cache.h (class source_cache): Update comment.
6132         <get_line_charpos>: New method.
6133         <get_source_lines>: Update comment.
6134         <clear>: Clear m_offset_cache.
6135         <get_plain_source_lines>: Change parameters.
6136         <ensure>: New method
6137         <m_offset_cache>: New member.
6138         * source.c (forget_cached_source_info_for_objfile): Update.
6139         (info_source_command): Use g_source_cache.
6140         (find_source_lines, open_source_file_with_line_charpos): Remove.
6141         (print_source_lines_base, search_command_helper): Use g_source_cache.
6142         * source.h (open_source_file_with_line_charpos): Don't declare.
6143         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6144         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6145         Use g_source_cache.
6146
6147 2019-08-06  Tom Tromey  <tromey@adacore.com>
6148
6149         * source-cache.c (source_cache::get_plain_source_lines):
6150         Remove "first_line" and "last_line" parameters.
6151         (source_cache::get_source_lines): Cache plain text.
6152         * source-cache.h (class source_cache)
6153         <get_plain_source_lines>: Update.
6154
6155 2019-08-06  Tom Tromey  <tromey@adacore.com>
6156
6157         * source-cache.c (extract_lines): No longer a method.
6158         Changed type of parameter.  Include final newline.
6159         (selftests::extract_lines_test): New function.
6160         (_initialize_source_cache): Likewise.
6161         * source-cache.h (class source_cache)
6162         <extract_lines>: Don't declare.
6163
6164 2019-08-06  Tom Tromey  <tromey@adacore.com>
6165
6166         * breakpoint.c (init_breakpoint_sal): Update.
6167         (breakpoint): Update.
6168         * breakpoint.h (struct breakpoint) <filter>: Now a
6169         unique_xmalloc_ptr.
6170
6171 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6172
6173         * NEWS: Mention dictionary access on blocks.
6174         * python/py-block.c (blpy_getitem): New function.
6175         (block_object_as_mapping): New struct.
6176         (block_object_type): Use new struct for tp_as_mapping field.
6177
6178 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6179
6180         * objfiles.h (objfile): Add a comment describing partial symbols.
6181
6182 2019-08-05  Tom Tromey  <tromey@adacore.com>
6183
6184         * compile/compile.c (_initialize_compile): Use _(), not N_().
6185         * thread.c (_initialize_thread): Use _(), not N_().
6186         * stack.c (_initialize_stack): Use _(), not N_().
6187         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6188
6189 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6190
6191         * dwarf2read.c (struct dw2_symtab_iterator):
6192         <want_specific_block>: Remove.
6193         <block_index>: Change type to gdb::optional.
6194         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6195         change type of BLOCK_INDEX parameter to gdb::optional.
6196         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6197         (dw2_lookup_symbol): Don't pass argument for
6198         WANT_SPECIFIC_BLOCK.
6199         (dw2_expand_symtabs_for_function): Don't pass argument for
6200         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6201         (class dw2_debug_names_iterator)
6202         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6203         parameter, change BLOCK_INDEX type to gdb::optional.
6204         <m_want_specific_block>: Remove.
6205         <m_block_index>: Change type to gdb::optional.
6206         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6207         gdb::optional.  Re-write in function of gdb::optional.
6208         (dw2_debug_names_lookup_symbol): Don't pass argument for
6209         WANT_SPECIFIC_BLOCK.
6210         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6211         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6212         BLOCK_INDEX.
6213
6214 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6215
6216         * NEWS: Mention changes to "info sources" command.
6217
6218 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6219
6220         * symtab.c (filename_partial_match_opts): New struct type.
6221         (struct output_source_filename_data): New members
6222         regexp, c_regexp, partial_match.
6223         (output_source_filename): Use new members to decide to print file.
6224         (info_sources_option_defs): New variable.
6225         (make_info_sources_options_def_group, print_info_sources_header,
6226         info_sources_command_completer):
6227         New functions.
6228         (info_sources_command): Read new optional arguments.
6229         (_initialize_symtab): Update info sources help.
6230
6231 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6232
6233         * ada-lang.c (exception_support_info_v0): Renamed from...
6234         (default_exception_support_info): ... this.  Create new
6235         definition for v1.
6236         (ada_has_this_exception_support): Look up catch_handlers_sym.
6237         (ada_exception_support_info_sniffer): Try v0 after default.
6238
6239 2019-08-01  Tom Tromey  <tromey@adacore.com>
6240
6241         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6242         gdbarch.h.
6243
6244 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6245
6246         * s12z-tdep.c: Fix include path for s12z-opc.h.
6247
6248 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6249
6250         * NEWS: Require GNU make 3.82.
6251
6252 2019-07-16  Tom Tromey  <tom@tromey.com>
6253
6254         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6255         declare.
6256
6257 2019-07-30  Tom Tromey  <tromey@adacore.com>
6258
6259         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6260
6261 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6262
6263         * printcmd.c (print_address_symbolic): Print negative offsets.
6264         (build_address_symbolic): Force signed arithmetic when computing
6265         offset.
6266
6267 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6268
6269         PR/24474: Add a function to lookup static variables.
6270         * NEWS: Mention this new function.
6271         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6272         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6273         * python/python.c (python_GdbMethods): Add new function.
6274
6275 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6276
6277         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6278         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6279         (objfpy_lookup_static_symbol): New function.
6280         (objfile_object_methods): Add new functions.
6281
6282 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6283
6284         * NEWS: Mention 'set|show print frame-info'.  Mention new
6285         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6286         backtrace argument.  Mention that python frame filtering code
6287         is now consistent with what 'backtrace' command prints.
6288
6289 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6290
6291         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6292         comments.
6293         (print_frame_info_auto, print_frame_info_source_line,
6294         print_frame_info_location, print_frame_info_source_and_location,
6295         print_frame_info_location_and_address, print_frame_info_short_location):
6296         New declarations.
6297         (struct frame_print_options): New member print_frame_info.
6298         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6299         * stack.h (get_user_print_what_frame_info): New declaration.
6300         (frame_show_address): New declaration.
6301         * stack.c (print_frame_arguments_choices): New value 'presence'.
6302         (print_frame_info_auto, print_frame_info_source_line,
6303         print_frame_info_location, print_frame_info_source_and_location,
6304         print_frame_info_location_and_address, print_frame_info_short_location,
6305         print_frame_info_choices, print_frame_info_print_what): New definitions.
6306         (print_frame_args): Only print dots for args if print frame-arguments
6307         is 'presence'.
6308         (frame_print_option_defs): New element for "frame-info".
6309         (get_user_print_what_frame_info): New function.
6310         (frame_show_address): Make non static.  Move comment to stack.h.
6311         (print_frame_info_to_print_what): New function.
6312         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6313         to decide what to print.
6314         (backtrace_command_1): Handle the new print_frame_arguments_presence
6315         value.
6316         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6317         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6318         (py_print_frame): In non-mi mode, use LOCATION as default for
6319         print_what, similarly to frame information printed directly by
6320         backtrace command. Handle frame-info user option in non MI mode.
6321
6322 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6323
6324         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6325         Add case for debugging 32-bit target on 64-bit host.  Revise
6326         comment.
6327
6328 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6329
6330         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6331         instead of find_function_entry_range_from_pc.
6332
6333 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6334
6335         * stack.c (find_frame_funname): Remove code which preferred
6336         minsym over symtab sym in "certain pathological cases".
6337
6338         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6339         parameter.  Change type of "do_demangle" to bool.
6340         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6341         Pass suitable "prefer_sym_over_minsym" flag to
6342         build_address_symbolic().  Don't output "+" for negative offsets.
6343         * printcmd.c (print_address_symbolic): Update invocation of
6344         build_address_symbolic to include a "prefer_sym_over_minsym"
6345         flag.
6346         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6347         Restrict cases in which use of minimal symbol is preferred to that
6348         of a found symbol.  Update comments.
6349
6350         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6351         for entry pc when entry pc is out of range for that FDE.
6352
6353 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6354
6355         PR gdb/24839:
6356         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6357         type.
6358
6359 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6360
6361         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6362         this function's Python signature.
6363
6364
6365 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6366
6367         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6368         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6369         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6370         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6371         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6372
6373
6374 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6375
6376         * h8300-tdep.c (h8300_register_name_common): New.
6377         h8300_register_name): Use h8300_register_name_common.
6378         (h8300s_register_name): Likewise.
6379         (h8300sx_register_name): Likewise.
6380         (h8300h_register_nam): New.
6381         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6382
6383
6384 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6385
6386         * arm-tdep.c (arm_skip_cmse_entry): New function.
6387         (arm_is_sgstubs_section): New function.
6388         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6389
6390 2019-07-22  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6393         Don't self-assign.
6394
6395 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6398         type_print.
6399
6400 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6403         so that GDB doesn't match any msymbols when searching in the
6404         TYPES_DOMAIN.
6405         (print_symbol_info): Print using typedef_print or type_print based
6406         on the type of the symbol.  Add updated FIXME comment moved from...
6407         (_initialize_symtab): ... move and update FIXME comment to above.
6408
6409 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * NEWS: Mention adding -q option to "info types".
6412         * symtab.c (struct info_types_options): New struct.
6413         (info_types_options_defs): New variable.
6414         (make_info_types_options_def_group): New function.
6415         (info_types_command): Use gdb::option framework to parse options.
6416         (info_types_command_completer): New function.
6417         (_initialize_symtab): Extend the help text on "info types" and
6418         register command completer.
6419
6420 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6421
6422         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6423         (lookup_symbol_in_objfile): Change int to block_enum and add a
6424         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6425
6426 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6427
6428         * MAINTAINERS (Write After Approval): Add self.
6429
6430 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6433         instruction to the dummy code region.
6434
6435 2019-07-19  Tom Tromey  <tromey@adacore.com>
6436
6437         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6438         (ARGSUSED, PARAMS, __func__): Remove rules.
6439
6440 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6441
6442         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6443         * features/arm/arm-with-iwmmxt.c: Remove.
6444         * features/arm/arm-with-iwmmxt.xml: Remove.
6445         * features/arm/arm-with-m-fpa-layout.c: Remove.
6446         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6447         * features/arm/arm-with-m-vfp-d16.c: Remove.
6448         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6449         * features/arm/arm-with-m.c: Remove.
6450         * features/arm/arm-with-m.xml: Remove.
6451         * features/arm/arm-with-neon.c: Remove.
6452         * features/arm/arm-with-neon.xml: Remove.
6453         * features/arm/arm-with-vfpv2.c: Remove.
6454         * features/arm/arm-with-vfpv2.xml: Remove.
6455         * features/arm/arm-with-vfpv3.c: Remove.
6456         * features/arm/arm-with-vfpv3.xml: Remove.
6457
6458 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6459
6460         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6461
6462 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6463
6464         * arch/aarch32.c (aarch32_create_target_description): Create
6465         target descriptions using features.
6466         * arch/arm.c (arm_create_target_description)
6467         (arm_create_mprofile_target_description): Likewise.
6468         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6469
6470 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6471
6472         * Makefile.in: Add new files.
6473         * aarch32-tdep.c: New file.
6474         * aarch32-tdep.h: New file.
6475         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6476         Call aarch32_read_description.
6477         * arch/aarch32.c: New file.
6478         * arch/aarch32.h: New file.
6479         * arch/arm.c (arm_create_target_description)
6480         (arm_create_mprofile_target_description): New function.
6481         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6482         (arm_create_target_description)
6483         (arm_create_mprofile_target_description): New declaration.
6484         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6485         read_description functions.
6486         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6487         Likewise.
6488         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6489         * arm-tdep.c (tdesc_arm_list): New variable.
6490         (arm_register_g_packet_guesses): Call create description functions.
6491         (arm_read_description) (arm_read_mprofile_description): New
6492         function.
6493         * arm-tdep.h (arm_read_description)
6494         (arm_read_mprofile_description): Add declaration.
6495         * configure.tgt: Add new files.
6496
6497 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6498
6499         * top.c (new_ui_command): Open specified terminal just once.
6500
6501 2019-07-18  Tom Tromey  <tromey@adacore.com>
6502
6503         * symtab.c (main_name): Constify return type.
6504         * symfile.c (set_initial_language): Update.
6505         * symtab.h (main_name): Constify return type.
6506
6507 2019-07-17  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-winsource.c (tui_update_source_window)
6510         (tui_update_source_window_as_is)
6511         (tui_update_source_windows_with_line): Remove return.
6512         * tui/tui-disasm.c (tui_show_disassem)
6513         (tui_show_disassem_and_update_source): Remove return.
6514         * tui/tui.c (tui_reset): Remove return.
6515         * tui/tui-wingeneral.c
6516         (tui_check_and_display_highlight_if_needed): Remove return.
6517
6518 2019-07-17  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6521
6522 2019-07-17  Tom Tromey  <tom@tromey.com>
6523
6524         * tui/tui-winsource.h (struct tui_exec_info_window)
6525         (struct tui_source_window_base): Move from tui-data.h.
6526         * tui/tui-winsource.c: Move many method definitions from
6527         elsewhere.  Remove "structuring" comments.
6528         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6529         (tui_source_window_base::refresh_window): Move to
6530         tui-winsource.c.
6531         * tui/tui-win.c (tui_source_window_base::refresh_all)
6532         (tui_source_window_base::update_tab_width)
6533         (tui_source_window_base::set_new_height)
6534         (tui_source_window_base::do_make_visible_with_new_height): Move to
6535         tui-winsource.c.
6536         * tui/tui-source.h: Update.
6537         * tui/tui-source.c (tui_source_window_base::reset): Move to
6538         tui-winsource.c.
6539         * tui/tui-disasm.h: Update.
6540         * tui/tui-data.h (struct tui_exec_info_window): Move to
6541         tui-winsource.h.
6542         (struct tui_source_window_base): Likewise.
6543         * tui/tui-data.c (tui_source_window_base::clear_detail)
6544         (tui_source_window_base, ~tui_source_window_base): Move to
6545         tui-winsource.c.
6546
6547 2019-07-17  Tom Tromey  <tom@tromey.com>
6548
6549         * tui/tui-win.c (tui_resize_all)
6550         (tui_source_window_base::update_tab_width)
6551         (tui_adjust_win_heights): Update.
6552         (tui_win_info::make_invisible_and_set_new_height): Rename from
6553         make_invisible_and_set_new_height.
6554         * tui/tui-data.h (struct tui_win_info)
6555         <make_invisible_and_set_new_height>: New method.
6556
6557 2019-07-17  Tom Tromey  <tom@tromey.com>
6558
6559         * tui/tui.c: Update.
6560         * tui/tui-source.h (struct tui_source_window): Move from
6561         tui-data.h.
6562         * tui/tui-layout.c: Update.
6563         * tui/tui-disasm.c: Update.
6564         * tui/tui-data.h (struct tui_source_window): Move to
6565         tui-source.h.
6566
6567 2019-07-17  Tom Tromey  <tom@tromey.com>
6568
6569         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6570         tui-data.h.
6571         * tui/tui-data.h (struct tui_disasm_window): Move to
6572         tui-disasm.h.
6573
6574 2019-07-17  Tom Tromey  <tom@tromey.com>
6575
6576         * tui/tui-regs.h (struct tui_data_item_window): Move from
6577         tui-data.h.
6578         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6579         * tui/tui-data.h (struct tui_data_item_window): Move to
6580         tui-regs.h.
6581         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6582
6583 2019-07-17  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui.c: Update.
6586         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6587         (tui_cmd_window::max_height): Move to tui-command.c.
6588         * tui/tui-layout.c: Update.
6589         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6590         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6591         tui-command.c.
6592         * tui/tui-command.h (struct tui_cmd_window): Move from
6593         tui-data.h.
6594         * tui/tui-command.c: Remove "structuring" comments.
6595         (tui_cmd_window::clear_detail)
6596         (tui_cmd_window::do_make_visible_with_new_height)
6597         (tui_cmd_window::max_height): Move from elsewhere.
6598
6599 2019-07-17  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6602         Now static.
6603         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6604         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui.c: Update.
6609         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6610         tui-regs.c.
6611         * tui/tui-windata.h: Remove file.
6612         * tui/tui-windata.c: Remove file.
6613         * tui/tui-win.c (tui_data_window::set_new_height)
6614         (tui_data_window::do_make_visible_with_new_height): Move to
6615         tui-regs.c.
6616         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6617         * tui/tui-regs.c: Remove "structuring" comments.
6618         (tui_data_window::first_data_item_displayed)
6619         (tui_data_window::delete_data_content_windows)
6620         (tui_data_window::erase_data_content)
6621         (tui_data_window::display_all_data)
6622         (tui_data_window::refresh_all)
6623         (tui_data_window::do_scroll_vertical)
6624         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6625         (tui_data_window::do_make_visible_with_new_height)
6626         (tui_data_window::refresh_window): Move from elsewhere.
6627         (_initialize_tui_regs): Move to end of file.
6628         * tui/tui-layout.c: Update.
6629         * tui/tui-hooks.c: Update.
6630         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6631         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6632         tui-regs.c.
6633         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6634
6635 2019-07-17  Tom Tromey  <tom@tromey.com>
6636
6637         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6638         seen.
6639
6640 2019-07-17  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-win.c (tui_source_window_base::set_new_height)
6643         (tui_source_window_base::do_make_visible_with_new_height): Use
6644         m_has_locator field directly.
6645         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6646         method.
6647         (struct tui_source_window_base) <has_locator>: Likewise.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6652         Don't declare.
6653         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6654         Remove.
6655         * tui/tui-win.c (tui_source_window_base::set_new_height)
6656         (tui_source_window_base::set_new_height)
6657         (make_invisible_and_set_new_height)
6658         (tui_source_window_base::do_make_visible_with_new_height)
6659         (tui_source_window_base::do_make_visible_with_new_height):
6660         Update.
6661         * tui/tui-layout.c (show_source_disasm_command, show_data)
6662         (show_source_or_disasm_and_command): Update.
6663         * tui/tui-layout.c (show_layout): Update.
6664
6665 2019-07-17  Tom Tromey  <tom@tromey.com>
6666
6667         * tui/tui-layout.c (make_data_window): Remove.
6668         (show_data): Unify creation and re-initialization cases.
6669
6670 2019-07-17  Tom Tromey  <tom@tromey.com>
6671
6672         * tui/tui-layout.c (make_source_window, make_disasm_window):
6673         Remove.
6674         (show_data): Unify creation and re-initialization cases.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-layout.c (make_command_window): Remove.
6679         (show_source_disasm_command, show_source_or_disasm_and_command):
6680         Unify creation and re-initialization cases.
6681
6682 2019-07-17  Tom Tromey  <tom@tromey.com>
6683
6684         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6685         creation and re-initialization cases.
6686
6687 2019-07-17  Tom Tromey  <tom@tromey.com>
6688
6689         * tui/tui-regs.c (tui_get_register): Return void.
6690
6691 2019-07-17  Tom Tromey  <tom@tromey.com>
6692
6693         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6694         Simplify.
6695
6696 2019-07-17  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6699         resetting.
6700
6701 2019-07-17  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6704         * tui/tui-regs.c (tui_reg_layout): New function.
6705         (tui_show_registers, tui_reg_command): Use it.
6706         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6707         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6708         parameters.
6709         (tui_layout_command): Remove.
6710
6711 2019-07-17  Tom Tromey  <tom@tromey.com>
6712
6713         * tui/tui-layout.h (tui/tui-layout): Return void.
6714         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6715
6716 2019-07-17  Tom Tromey  <tom@tromey.com>
6717
6718         * tui/tui-layout.c (show_source_disasm_command, show_data):
6719         Update.
6720         (reset_locator): Remove.
6721         (show_source_or_disasm_and_command): Update.
6722
6723 2019-07-17  Tom Tromey  <tom@tromey.com>
6724
6725         * tui/tui-source.c (tui_source_window_base::reset): Remove
6726         win_type parameter.
6727         * tui/tui-layout.c (make_command_window, make_source_window)
6728         (make_disasm_window, make_data_window)
6729         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6730         (reset_locator, show_source_or_disasm_and_command): Update.
6731         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6732         win_type parameter.
6733         (struct tui_source_window_base) <reset>: Likewise.
6734
6735 2019-07-17  Tom Tromey  <tom@tromey.com>
6736
6737         * tui/tui-layout.c (show_source_disasm_command): Use
6738         reset_locator.
6739         (reset_locator): New function.
6740         (init_and_make_win): Remove.
6741         (show_source_or_disasm_and_command): Use reset_locator.
6742
6743 2019-07-17  Tom Tromey  <tom@tromey.com>
6744
6745         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6746         condition.
6747         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6748         Remove condition.
6749         * tui/tui-source.c (tui_source_window_base::reset): New method.
6750         * tui/tui-layout.c (make_command_window): Don't call
6751         init_and_make_win.
6752         (make_source_window, make_disasm_window): Don't call
6753         make_source_or_disasm_window.
6754         (make_data_window): Don't call init_and_make_win.  Change calling
6755         convention.
6756         (show_source_disasm_command, show_data): Simplify.
6757         (make_source_or_disasm_window): Remove.
6758         (show_source_or_disasm_and_command): Simplify.
6759         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6760         (struct tui_source_window_base) <reset>: Likewise.
6761         <execution_info>: Remove initializer.
6762         * tui/tui-data.c (tui_source_window_base): Initialize
6763         execution_info.
6764
6765 2019-07-17  Tom Tromey  <tom@tromey.com>
6766
6767         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6768         variable.
6769
6770 2019-07-17  Tom Tromey  <tom@tromey.com>
6771
6772         * tui/tui.c (tui_rl_other_window): Update.
6773         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6774         superclass method first.  Always iterate over regs_content.
6775         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6776         method.
6777         * tui/tui-win.c (tui_set_focus_command): Update.
6778
6779 2019-07-17  Tom Tromey  <tom@tromey.com>
6780
6781         * tui/tui-win.c (tui_set_focus_command): Rename from
6782         tui_set_focus.  Call tui_enable.
6783         (tui_set_focus_command): Remove.
6784
6785 2019-07-17  Tom Tromey  <tom@tromey.com>
6786
6787         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6788         refresh_window.
6789         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6790         touchwin.
6791         (tui_data_window::refresh_window): Call refresh_window on data
6792         items.  Always call superclass refresh_window.
6793         (tui_win_info::refresh): Remove.
6794         (tui_source_window_base::refresh_window): Update.
6795         (tui_refresh_all): Update.
6796         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6797         refresh_window.
6798         (show_source_or_disasm_and_command): Likewise.
6799         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6800         (struct tui_source_window_base) <refresh>: Likewise.
6801
6802 2019-07-17  Tom Tromey  <tom@tromey.com>
6803
6804         * tui/tui-winsource.c (tui_clear_source_content)
6805         (tui_show_source_content): Update.
6806         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6807         whether content is empty.
6808         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6809         Remove.
6810
6811 2019-07-17  Tom Tromey  <tom@tromey.com>
6812
6813         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6814         window's contents.
6815         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6816         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6817
6818 2019-07-17  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6821         (struct tui_data_item_window): Update.
6822
6823 2019-07-17  Tom Tromey  <tom@tromey.com>
6824
6825         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6826         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6827         defines.
6828
6829 2019-07-17  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui-winsource.h (tui_erase_source_content)
6832         (tui_clear_source_content): Remove "display_prompt" parameter.
6833         * tui/tui-winsource.c (tui_update_source_window_as_is)
6834         (tui_update_source_windows_with_addr): Update.
6835         (tui_clear_source_content): Remove "display_prompt" parameter.
6836         (tui_erase_source_content): Likewise.  Simplify.
6837         (tui_show_source_content): Update.
6838         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6839         * tui/tui-stack.c (tui_show_frame_info): Update.
6840         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6841         Remove defines.
6842
6843 2019-07-17  Tom Tromey  <tom@tromey.com>
6844
6845         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6846         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6847         parameter.
6848         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6849         parameter.
6850
6851 2019-07-17  Tom Tromey  <tom@tromey.com>
6852
6853         * tui/tui-winsource.c (tui_clear_source_content)
6854         (tui_show_source_content, tui_show_exec_info_content)
6855         (tui_clear_exec_info_content): Update.
6856         * tui/tui-stack.c (tui_show_locator_content): Update.
6857         (tui_show_frame_info): Update.
6858         * tui/tui-source.h (tui_source_window): Don't declare.
6859         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6860         from tui_source_is_displayed.
6861         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6862         Remove field.
6863         (struct tui_source_window_base) <content_in_use>: New field.  Now
6864         bool.
6865         (struct tui_source_window) <showing_source_p>: New method.
6866         (TUI_SRC_WIN): Change cast.
6867         * tui/tui-data.c (tui_initialize_static_data): Update.
6868
6869 2019-07-17  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6872         location_matches_p.
6873         * tui/tui-source.c (tui_source_window::location_matches_p): New
6874         method.
6875         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6876         method.
6877         * tui/tui-data.h (struct tui_source_window_base)
6878         <location_matches_p>: New method.
6879         (struct tui_source_window, struct tui_disasm_window)
6880         <location_matches_p>: Likewise.
6881
6882 2019-07-17  Tom Tromey  <tom@tromey.com>
6883
6884         * tui/tui-win.c (tui_set_win_height_command): Rename from
6885         tui_set_win_height.
6886         (tui_set_win_height_command): Remove.
6887
6888 2019-07-17  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui-source.c (tui_source_window): New constructor.  Add
6891         observer.
6892         (~tui_source_window): New destructor.
6893         (tui_source_window::style_changed): New method.
6894         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6895         (tui_attach_detach_observers): Update.
6896         * tui/tui-data.h (struct tui_source_window): Make constructor not
6897         inline.  Add destructor.
6898         (struct tui_source_window) <style_changed>: New method.
6899         <m_observable>: New member.
6900
6901 2019-07-17  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6904         * tui/tui-win.c (tui_resize_all): Fix typo.
6905
6906 2019-07-17  Tom Tromey  <tom@tromey.com>
6907
6908         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6909         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6910         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6911         * tui/tui-win.c (window_name_completer): Use foreach.
6912         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6913         (update_tab_width): Likewise.
6914         * tui/tui-layout.c (show_layout): Update.
6915         * tui/tui-data.h (class tui_window_iterator): New.
6916         (struct all_tui_windows): New.
6917         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6918
6919 2019-07-17  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6922         parameter.  Don't reference globals.
6923         (tui_reg_command): Update.
6924
6925 2019-07-17  Tom Tromey  <tom@tromey.com>
6926
6927         * tui/tui-regs.c (tui_show_registers): Simplify.
6928
6929 2019-07-17  Tom Tromey  <tom@tromey.com>
6930
6931         * tui/tui-regs.c (tui_show_registers): Update.
6932         (tui_show_register_group): Add win_info parameter.
6933
6934 2019-07-17  Tom Tromey  <tom@tromey.com>
6935
6936         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6937         Rename from tui_display_reg_element_at_line.
6938         (tui_data_window::display_registers_from_line): Update.
6939         * tui/tui-data.h (struct tui_data_window)
6940         <display_reg_element_at_line>: New method.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-regs.h (tui_display_registers_from)
6945         (tui_display_registers_from_line): Don't declare.
6946         * tui/tui-windata.c (tui_data_window::display_all_data)
6947         (tui_data_window::refresh_all)
6948         (tui_data_window::do_scroll_vertical): Update.
6949         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6950         from tui_display_registers_from.
6951         (tui_display_reg_element_at_line): Update.
6952         (tui_data_window::display_registers_from_line): Rename from
6953         tui_display_registers_from_line.
6954         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6955         display_registers_from_line>: New methods.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6960         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6961         from tui_erase_data_content.
6962         (tui_data_window::display_all_data)
6963         (tui_data_window::refresh_all)
6964         (tui_data_window::do_scroll_vertical): Update.
6965         * tui/tui-regs.c (tui_show_registers): Update.
6966         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6967         New method.
6968
6969 2019-07-17  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6972         declare.
6973         * tui/tui-windata.c
6974         (tui_data_window::delete_data_content_windows): Rename from
6975         tui_delete_data_content_windows.
6976         (tui_data_window::display_all_data)
6977         (tui_data_window::do_scroll_vertical): Update.
6978         * tui/tui-data.h (struct tui_data_window)
6979         <delete_data_content_windows>: New method.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6984         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6985
6986 2019-07-17  Tom Tromey  <tom@tromey.com>
6987
6988         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6989         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6990         from tui_display_all_data.
6991         * tui/tui-win.c
6992         (tui_data_window::do_make_visible_with_new_height): Update.
6993         * tui/tui-regs.c (tui_show_registers): Update.
6994         * tui/tui-layout.c (tui_set_layout): Update.
6995         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6996         method.
6997
6998 2019-07-17  Tom Tromey  <tom@tromey.com>
6999
7000         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7001         * tui/tui-windata.c (tui_display_data_from): Remove.
7002         (tui_data_window::refresh_all): Update.
7003
7004 2019-07-17  Tom Tromey  <tom@tromey.com>
7005
7006         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7007         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7008         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7009         tui_display_registers_from_line.
7010         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7011         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7012         "force_display" parameter.
7013
7014 2019-07-17  Tom Tromey  <tom@tromey.com>
7015
7016         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7017         declare.
7018         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7019         Rename from tui_first_reg_element_no_inline.
7020         (tui_display_reg_element_at_line)
7021         (tui_display_registers_from_line): Update.
7022         * tui/tui-data.h (struct tui_data_window)
7023         <first_reg_element_no_inline>: New method.
7024
7025 2019-07-17  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-windata.c (tui_display_data_from)
7028         (tui_data_window::do_scroll_vertical): Update.
7029         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7030         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7031         Rename from tui_line_from_reg_element_no.
7032         (tui_display_registers_from_line): Update.
7033         * tui/tui-data.h (struct tui_data_window)
7034         <line_from_reg_element_no>: New method.
7035
7036 2019-07-17  Tom Tromey  <tom@tromey.com>
7037
7038         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7039         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7040         tui_last_regs_line_no.
7041         (tui_display_reg_element_at_line)
7042         (tui_display_registers_from_line): Update.
7043         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7044         method.
7045
7046 2019-07-17  Tom Tromey  <tom@tromey.com>
7047
7048         PR tui/24722:
7049         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7050         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7051         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7052         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7053         (tui_update_breakpoint_info): Likewise.
7054         * tui/tui-hooks.c (tui_event_create_breakpoint)
7055         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7056         Update.
7057
7058 2019-07-17  Tom Tromey  <tom@tromey.com>
7059
7060         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7061
7062 2019-07-17  Tom Tromey  <tom@tromey.com>
7063
7064         * tui/tui-winsource.c (tui_update_source_window_as_is)
7065         (tui_update_source_windows_with_addr): Update.
7066         * tui/tui-source.h (tui_set_source_content)
7067         (tui_show_symtab_source): Add "win_info" parameter.
7068         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7069         parameter.
7070         (tui_show_symtab_source): Likewise.
7071
7072 2019-07-17  Tom Tromey  <tom@tromey.com>
7073
7074         * tui/tui-wingeneral.c
7075         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7076
7077 2019-07-17  Tom Tromey  <tom@tromey.com>
7078
7079         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7080         (struct tui_cmd_window) <can_scroll>: New method.
7081         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7082         method.
7083
7084 2019-07-17  Tom Tromey  <tromey@adacore.com>
7085
7086         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7087         do_field_signed>: Rename.  Change type of "value".
7088         * ui-out.c (ui_out::field_signed): Rename from field_int.
7089         Change type of "value".
7090         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7091         type of "value".
7092         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7093         do_field_int.  Change type of "value".
7094         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7095         do_field_int.  Change type of "value".
7096         * tracepoint.c (trace_status_mi, tfind_1)
7097         (print_one_static_tracepoint_marker): Update.
7098         * thread.c (print_thread_info_1, print_selected_thread_frame):
7099         Update.
7100         * stack.c (print_frame, print_frame_info): Update.
7101         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7102         Update.
7103         * source.c (print_source_lines_base): Update.
7104         * skip.c (info_skip_command): Update.
7105         * record-btrace.c (btrace_ui_out_decode_error)
7106         (btrace_call_history_src_line): Update.
7107         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7108         Update.
7109         * progspace.c (print_program_space): Update.
7110         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7111         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7112         do_field_int.  Change type of "value".
7113         * mi/mi-out.c (mi_ui_out::do_table_begin)
7114         (mi_ui_out::do_table_header): Update.
7115         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7116         type of "value".
7117         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7118         (mi_cmd_data_list_changed_registers, output_register)
7119         (mi_cmd_data_read_memory, mi_load_progress)
7120         (mi_cmd_trace_frame_collected): Update.
7121         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7122         Update.
7123         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7124         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7125         (mi_cmd_var_list_children, varobj_update_one): Update.
7126         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7127         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7129         * inferior.c (print_inferior): Update.
7130         * gdb_bfd.c (print_one_bfd): Update.
7131         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7132         Update.
7133         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7134         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7135         do_field_int.  Change type of "value".
7136         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7137         do_field_int.  Change type of "value".
7138         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7139         (print_one_breakpoint_location, print_it_catch_fork)
7140         (print_one_catch_fork, print_it_catch_vfork)
7141         (print_one_catch_vfork, print_it_catch_solib)
7142         (print_it_catch_exec, print_it_ranged_breakpoint)
7143         (print_mention_watchpoint, print_mention_masked_watchpoint)
7144         (bkpt_print_it, update_static_tracepoint): Update.
7145         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7146         * break-catch-syscall.c (print_it_catch_syscall): Update.
7147         * ada-tasks.c (print_ada_task_info): Update.
7148         * ada-lang.c (print_it_exception, print_mention_exception):
7149         Update.
7150
7151 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         PR breakpoints/24541
7154         * gdbarch.c: Regenerate.
7155         * gdbarch.h: Regenerate.
7156         * gdbarch.sh: Adjust return type and parameter types for
7157         'stap_adjust_register'.
7158         (i386_stap_adjust_register): Adjust signature and return new
7159         register name.
7160         * stap-probe.c (stap_parse_register_operand): Adjust use of
7161         'gdbarch_stap_adjust_register'.
7162
7163 2019-07-17  Tom Tromey  <tromey@adacore.com>
7164
7165         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7166         declare VEC.
7167         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7168         std::vector.
7169         (struct s390_process_info): Add initializers.
7170         (s390_add_process): Use new.
7171         (s390_linux_nat_target::low_forget_process): Use delete.
7172         (s390_linux_nat_target::low_new_fork)
7173         (s390_linux_nat_target::stopped_by_watchpoint)
7174         (s390_linux_nat_target::low_prepare_to_resume)
7175         (s390_linux_nat_target::insert_watchpoint)
7176         (s390_linux_nat_target::insert_hw_breakpoint)
7177         (s390_linux_nat_target::remove_watchpoint)
7178         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7179
7180 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7181
7182         * aarch64-fbsd-nat.c: Include regcache.h.
7183         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7184         argument.
7185         (aarch64_fbsd_nat_target::fetch_registers)
7186         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7187         variable.
7188         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7189
7190 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * fbsd-nat.c: Include gdbarch.h.
7193
7194 2019-07-15  Tom Tromey  <tromey@adacore.com>
7195
7196         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7197
7198 2019-07-15  Tom Tromey  <tromey@adacore.com>
7199
7200         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7201         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7202         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7203         * cli-out.c (cli_ui_out::do_field_int): New method.
7204         * ui-out.c (ui_out::field_unsigned): New method.
7205         * symfile.c (generic_load): Use field_unsigned.
7206         (print_transfer_performance): Likewise.
7207         * record-btrace.c (ui_out_field_uint): Remove.
7208         (btrace_call_history_insn_range, btrace_call_history): Use
7209         field_unsigned.
7210         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7211         field_unsigned.
7212         * ui-out.h (class ui_out) <field_unsigned>: New method.
7213         <do_field_unsigned>: Likewise.
7214
7215 2019-07-15  Tom Tromey  <tromey@adacore.com>
7216
7217         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7218         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7219         * target.c (flash_erase_command): Use field_string.
7220         * infrun.c (print_signal_received_reason): Use field_string.
7221         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7222         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7223         field_string.
7224         * ada-tasks.c (print_ada_task_info): Use field_string.
7225
7226 2019-07-15  Tom Tromey  <tromey@adacore.com>
7227
7228         * target.c (flash_erase_command): Use field_core_addr.
7229         * symfile.c (generic_load): Use field_core_addr.
7230         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7231         Use field_core_addr.
7232         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7233         field_core_addr.
7234
7235 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7238         value if its desired type is smaller than a CORE_ADDR and signed.
7239
7240 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7241
7242         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7243         of changes to field names, and use new is_reference field to
7244         decide if a property is a reference or not.
7245         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7246         field.
7247         (struct dwarf2_property_baton): Update header comment, rename
7248         'referenced_type' to 'property_type' and update comments.
7249         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7250         default property type, store in property baton, update to take
7251         accound of renamed field.
7252         (read_func_scope): Update call to attr_to_dynamic_prop.
7253         (read_array_type): Likewise.
7254         (dwarf2_per_cu_addr_sized_int_type): New function.
7255         (read_subrange_index_type): Move type finding code to
7256         dwarf2_per_cu_addr_sized_int_type.
7257         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7258         (dwarf2_per_cu_addr_type): New function.
7259         (set_die_type): Update calls to attr_to_dynamic_prop.
7260
7261 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7262
7263         * dwarf2read.c (read_subrange_index_type): New function.
7264         (read_subrange_type): Move code into new function and call it.
7265         * gdbtypes.c (create_range_type): Add some asserts.
7266
7267 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7270         update return statements.
7271         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7272         declaration, and update comment to match.
7273         * gdbtypes.c (resolve_dynamic_array): Update call to
7274         dwarf2_evaluate_property to match new return type.
7275
7276 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * valarith.c (value_subscripted_rvalue): Change lowerbound
7279         parameter type from int to LONGEST.
7280         * value.h (value_subscripted_rvalue): Likewise in declaration.
7281
7282 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * cli/cli-utils.c (info_print_command_completer): New function.
7285         * cli/cli-utils.h: Add 'completer.h' include, and forward
7286         declaration for 'struct cmd_list_element'.
7287         (info_print_command_completer): Declare.
7288         * stack.c (_initialize_stack): Add completer for 'info locals' and
7289         'info args'.
7290         * symtab.c (_initialize_symtab): Add completer for 'info
7291         variables' and 'info functions'.
7292         * NEWS: Mention completion for additional info commands.
7293
7294 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7295
7296         * cli/cli-utils.c (extract_info_print_args): Delete.
7297         (extract_arg_maybe_quoted): Delete.
7298         (info_print_options_defs): New variable.
7299         (make_info_print_options_def_group): New function.
7300         (extract_info_print_options): Define new function.
7301         * cli/cli-utils.h (extract_info_print_args): Delete.
7302         (struct info_print_options): New structure.
7303         (extract_info_print_options): Declare new function.
7304         * stack.c (info_locals_command): Update to use new
7305         extract_info_print_options, also add a header comment.
7306         (info_args_command): Likewise.
7307         * symtab.c (info_variables_command): Likewise.
7308         (info_functions_command): Likewise.
7309
7310 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7313         to extract string arguments.
7314         * common/common-utils.c (extract_string_maybe_quoted): New function.
7315         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7316
7317 2019-07-11  Tom Tromey  <tromey@adacore.com>
7318
7319         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7320         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7321         * top.h (gdbinit): Don't declare.
7322         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7323         into...
7324         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7325         * top.c (gdb_init): Don't call init_cli_cmds.
7326         (gdbinit): Remove.
7327         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7328
7329 2019-07-11  Tom Tromey  <tromey@adacore.com>
7330
7331         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7332         after it has been moved.
7333
7334 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7335
7336         * valops.c (value_must_coerce_to_target): Change return type to
7337         bool.
7338         * value.h (value_must_coerce_to_target): Likewise.
7339
7340 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7341
7342         * breakpoint.c (is_hardware_watchpoint): Remove
7343         forward-declaration.
7344         (is_masked_watchpoint): Change return type to bool.
7345         (is_tracepoint): Likewise.
7346         (is_breakpoint): Likewise.
7347         (is_hardware_watchpoint): Likewise.
7348         (is_watchpoint): Likewise.
7349         (is_no_memory_software_watchpoint): Likewise.
7350         (is_catchpoint): Likewise.
7351         (breakpoint_1): Make FILTER parameter's return type bool.
7352         is_masked_watchpoint): Change return type to bool.
7353         (save_breakpoints): Make FILTER parameter's return type bool.
7354         * breakpoint.h (is_breakpoint): Change return type to bool.
7355         (is_watchpoint): Likewise.
7356         (is_catchpoint): Likewise.
7357         (is_tracepoint): Likewise.
7358
7359 2019-07-10  Tom Tromey  <tom@tromey.com>
7360
7361         * defs.h: Don't include gdbarch.h.
7362         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7363         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7364         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7365         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7366         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7367         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7368         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7369         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7370         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7371         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7372         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7373         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7374         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7375         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7376         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7377         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7378         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7379         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7380         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7381         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7382         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7383         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7384         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7385         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7386         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7387         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7388         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7389
7390 2019-07-10  Tom Tromey  <tromey@adacore.com>
7391
7392         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7393         * breakpoint.c (init_ada_exception_breakpoint): Register as
7394         bp_catchpoint.
7395         (print_one_breakpoint_location, print_one_breakpoint): Use
7396         is_ada_exception_catchpoint.
7397         * ada-lang.c (class ada_catchpoint_location): Pass
7398         bp_loc_software_breakpoint to bp_location constructor.
7399         (is_ada_exception_catchpoint): New function.
7400
7401 2019-07-10  Tom Tromey  <tromey@adacore.com>
7402
7403         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7404         VEC.
7405         (struct arm_exidx_entry): New method operator<.
7406         (struct arm_exidx_data) <section_maps>: Change type.
7407         (arm_exidx_data_free): Remove.
7408         (arm_exidx_data_key): Change type.  Move lower.
7409         (arm_exidx_new_objfile): Update.
7410         (arm_compare_exidx_entries): Remove.
7411         (arm_find_exidx_entry, _initialize_arm_tdep)
7412
7413 2019-07-10  Tom Tromey  <tromey@adacore.com>
7414
7415         * solib-spu.c (ocl_program_data_key): Change type.
7416         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7417         Update.
7418
7419 2019-07-10  Tom Tromey  <tromey@adacore.com>
7420
7421         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7422         (struct solib_aix_inferior_data) <library_list>: Change type.
7423         (solib_aix_inferior_data_handle): Change type.
7424         (get_solib_aix_inferior_data): Update.
7425         (solib_aix_free_library_list): Remove.
7426         (library_list_start_library): Update.
7427         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7428         return type.
7429         (solib_aix_get_library_list)
7430         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7431         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7432
7433 2019-07-10  Tom Tromey  <tromey@adacore.com>
7434
7435         * solib-dsbt.c (struct dsbt_info): Add initializers.
7436         (solib_dsbt_pspace_data): Change type.
7437         (dsbt_pspace_data_cleanup): Remove.
7438         (get_dsbt_info, _initialize_dsbt_solib): Update.
7439
7440 2019-07-10  Tom Tromey  <tromey@adacore.com>
7441
7442         * spu-tdep.c (spu_overlay_data): Change type.
7443         (spu_get_overlay_table, spu_overlay_new_objfile)
7444         (_initialize_spu_tdep): Update.
7445
7446 2019-07-10  Tom Tromey  <tromey@adacore.com>
7447
7448         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7449         destructor.
7450         (dbx_objfile_data_key): Change type and declare later.
7451         (DBX_SYMFILE_INFO): Rewrite.
7452         * dbxread.c (dbx_objfile_data_key): Change type.
7453         (dbx_symfile_init): Update.
7454         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7455         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7456         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7457
7458 2019-07-10  Tom Tromey  <tromey@adacore.com>
7459
7460         * jit.c (jit_program_space_key): Change type.  Move lower.
7461         (get_jit_program_space_data): Update.
7462         (jit_program_space_data_cleanup): Remove.
7463         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7464         Update.
7465         (struct jit_program_space_data): Add initializers.
7466
7467 2019-07-10  Tom Tromey  <tromey@adacore.com>
7468
7469         * solib-darwin.c (struct darwin_info): Add initializers.
7470         (solib_darwin_pspace_data): Change type.
7471         (darwin_pspace_data_cleanup): Remove.
7472         (get_darwin_info, _initialize_darwin_solib): Update.
7473
7474 2019-07-10  Tom Tromey  <tromey@adacore.com>
7475
7476         * remote-sim.c (struct sim_inferior_data): Add initializers,
7477         constructor, and destructor.
7478         (sim_inferior_data_key): Change type.  Move lower.
7479         (check_for_duplicate_sim_descriptor): Update.
7480         (get_sim_inferior_data): Use new.  Update.
7481         (~sim_inferior_data_cleanup): Rename from
7482         sim_inferior_data_cleanup.  Simplify.
7483         (gdbsim_close_inferior, simulator_command)
7484         (sim_command_completer, _initialize_remote_sim): Update.
7485         (next_pid, INITIAL_PID): Move earlier.
7486
7487 2019-07-10  Tom Tromey  <tromey@adacore.com>
7488
7489         * python/python-internal.h (create_thread_object): Return
7490         gdbpy_ref.
7491         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7492         * python/py-inferior.c (struct threadlist_entry): Add
7493         constructor.
7494         <thread_obj>: Now a gdbpy_ref.
7495         (thread_to_thread_object): Update.
7496         (add_thread_object): Use new.
7497         (delete_thread_object): Use delete.
7498         (infpy_threads): Update.
7499         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7500         GIL.
7501
7502 2019-07-10  Tom Tromey  <tromey@adacore.com>
7503
7504         * valops.c (value_cast): Specialize error message for Ada.
7505
7506 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7507
7508         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7509
7510 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7511
7512         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7513         bpstat_should_step): Return bool, adjust comments.
7514         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7515         bpstat_should_step): Likewise.
7516
7517 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7518
7519         * features/Makefile: Use feature target descriptions for Arm.
7520         * features/arm/arm-core.c: Generate new file.
7521         * features/arm/arm-fpa.c: Likewise.
7522         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7523         * features/arm/arm-m-profile.c: Likewise.
7524         * features/arm/arm-vfpv2.c: Likewise.
7525         * features/arm/arm-vfpv3.c: Likewise.
7526         * features/arm/xscale-iwmmxt.c: Likewise.
7527         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7528
7529 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7530
7531         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7532         ptrace earlier.
7533
7534 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7535
7536         * features/aarch64-pauth.c: Regenerate.
7537
7538 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7539
7540         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7541         bool.
7542         (bpstat_what): Use false instead of 0.
7543
7544 2019-07-09  Pedro Alves  <palves@redhat.com>
7545
7546         * break-catch-throw.c (is_exception_catchpoint): New.
7547         * breakpoint.c (print_one_breakpoint_location): New parameter
7548         'raw_loc'.  Handle it.  Use
7549         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7550         looking at the breakpoint's type.
7551         (print_one_breakpoint): If handling "maint info breakpoints", also
7552         print locations of exception catchpoints.
7553         * breakpoint.h (is_exception_catchpoint): Declare.
7554
7555 2019-07-09  Pedro Alves  <palves@redhat.com>
7556
7557         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7558         "addr" field.
7559         (allocate_location_exception_catchpoint): New.
7560         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7561         (initialize_throw_catchpoint_ops): Install
7562         allocate_location_exception_catchpoint as allocate_location
7563         method.
7564         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7565         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7566         bp_loc_other.
7567         (breakpoint_address_is_meaningful): Delete.
7568         (bl_address_is_meaningful): New.
7569         (breakpoint_locations_match): Adjust comment.
7570         (bp_location_from_bp_type): New, factored out of...
7571         (bp_location::bp_location(breakpoint *)): ... this.
7572         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7573         factored out of...
7574         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7575         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7576         breakpoint_address_is_meaningful.
7577         (bp_locations_compare): Adjust comment.
7578         (update_global_location_list): Use bl_address_is_meaningful
7579         instead of breakpoint_address_is_meaningful.
7580         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7581         explicit.
7582         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7583         * python/py-breakpoint.c (bppy_get_location): No longer check
7584         whether location is null.
7585
7586 2019-07-09  Pedro Alves  <palves@redhat.com>
7587
7588         PR c++/15468
7589         * breakpoint.c (print_one_breakpoint_location): Remove
7590         single-location assert.
7591
7592 2019-07-09  Tom Tromey  <tom@tromey.com>
7593
7594         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7595         * configure: Rebuild.
7596         * configure.ac: Change common to gdbsupport.
7597         * gdbsupport: Rename from common.
7598         * acinclude.m4: Change common to gdbsupport.
7599         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7600         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7601         gdbsupport.
7602         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7603         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7604         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7605         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7606         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7607         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7608         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7609         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7610         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7611         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7612         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7613         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7614         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7615         coff-pe-read.c, command.h, compile/compile-c-support.c,
7616         compile/compile-c.h, compile/compile-cplus-symbols.c,
7617         compile/compile-cplus-types.c, compile/compile-cplus.h,
7618         compile/compile-loc2c.c, compile/compile.c, completer.c,
7619         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7620         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7621         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7622         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7623         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7624         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7625         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7626         features/aarch64-core.c, features/aarch64-fpu.c,
7627         features/aarch64-pauth.c, features/aarch64-sve.c,
7628         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7629         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7630         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7631         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7632         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7633         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7634         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7635         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7636         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7637         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7638         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7639         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7640         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7641         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7642         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7643         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7644         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7645         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7646         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7647         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7648         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7649         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7650         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7651         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7652         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7653         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7654         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7655         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7656         minsyms.c, mips-linux-tdep.c, namespace.h,
7657         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7658         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7659         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7660         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7661         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7662         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7663         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7664         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7665         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7666         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7667         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7668         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7669         procfs.c, producer.c, progspace.h, psymtab.h,
7670         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7671         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7672         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7673         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7674         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7675         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7676         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7677         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7678         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7679         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7680         target-memory.c, target.c, target.h, target/waitstatus.c,
7681         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7682         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7683         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7684         unittests/array-view-selftests.c,
7685         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7686         unittests/common-utils-selftests.c,
7687         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7688         unittests/format_pieces-selftests.c,
7689         unittests/function-view-selftests.c,
7690         unittests/lookup_name_info-selftests.c,
7691         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7692         unittests/mkdir-recursive-selftests.c,
7693         unittests/observable-selftests.c,
7694         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7695         unittests/parse-connection-spec-selftests.c,
7696         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7697         unittests/scoped_fd-selftests.c,
7698         unittests/scoped_mmap-selftests.c,
7699         unittests/scoped_restore-selftests.c,
7700         unittests/string_view-selftests.c, unittests/style-selftests.c,
7701         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7702         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7703         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7704         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7705         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7706         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7707
7708 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7711         bool value.
7712         (decode_digits_ordinary): Set explicit_line field in sal.
7713         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7714         symtab_and_line that was set on an explicit line number in
7715         assembler code.  Do always update the recorded symtab and line if
7716         we do skip the prologue.
7717
7718 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * breakpoint.c (set_breakpoint_location_function): Remove
7721         explicit_loc parameter.
7722         (momentary_breakpoint_from_master): Update call to
7723         set_breakpoint_location_function.
7724         (add_location_to_breakpoint): Likewise.
7725
7726 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7727
7728         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7729         required features based on default bfd type when no specific bfd
7730         is present.
7731
7732 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7733
7734         * NEWS: Mention that GDB printf and eval commands can now print
7735         C-style and Ada-style convenience var strings without
7736         calling the inferior.
7737         * printcmd.c (printf_c_string): Locally print GDB internal var
7738         instead of transiting via the inferior.
7739         (printf_wide_c_string): Likewise.
7740
7741 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7742
7743         PR breakpoints/25011
7744         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7745
7746 2019-07-04  Tom Tromey  <tom@tromey.com>
7747
7748         PR tui/24724:
7749         * tui/tui-winsource.c (tui_clear_source_content): Update.
7750         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7751         (tui_update_breakpoint_info): Update.
7752         (tui_set_exec_info_content): Update.
7753         * tui/tui-source.c (tui_set_source_content_nil): Update.
7754         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7755         has_break.
7756         * tui/tui-data.h (enum tui_bp_flag): New.
7757         (tui_bp_flags): New enum flags type.
7758         (struct tui_source_element) <break_mode>: Change type.  Rename
7759         from has_break.
7760         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7761         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7762         constants.
7763         * tui/tui-winsource.h: Fix comment.
7764
7765 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7766
7767         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7768         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7769         (store_fpregs_to_thread)
7770         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7771         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7772         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7773         (IWMMXT_REGS_SIZE): Add define.
7774         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7775         (fetch_vfp_regs, store_vfp_regs)
7776         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7777         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7778
7779 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7780
7781         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7782         defines.
7783         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7784         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7785         (ARM_INT_REGISTER_SIZE): ...to this.
7786         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7787         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7788         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7789         (arm_linux_collect_gregset, supply_nwfpe_register)
7790         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7791         defines.
7792         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7793         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7794         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7795         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7796         (arm_return_in_memory, arm_store_return_value)
7797         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7798         (arm_record_ld_st_multiple): Likewise.
7799         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7800         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7801
7802 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7803
7804         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7805         AARCH64_DISPLACED_MODIFIED_INSNS.
7806         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7807         (aarch64_displaced_step_copy_insn): Likewise.
7808         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7809         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7810         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7811         ARM_DISPLACED_MODIFIED_INSNS.
7812         * arm-tdep.c (arm_gdbarch_init): Likewise.
7813         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7814         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7815         (struct arm_displaced_step_closure): Use
7816         ARM_DISPLACED_MODIFIED_INSNS.
7817
7818 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7819
7820         * features/Makefile: Remove unused xml files.
7821         * features/aarch64.xml: Remove.
7822         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7823         * features/i386/amd64-avx-avx512.xml: Remove.
7824         * features/i386/amd64-avx-linux.xml: Remove.
7825         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7826         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7827         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7828         * features/i386/amd64-avx-mpx.xml: Remove.
7829         * features/i386/amd64-avx.xml: Remove.
7830         * features/i386/amd64-linux.xml: Remove.
7831         * features/i386/amd64-mpx-linux.xml: Remove.
7832         * features/i386/amd64-mpx.xml: Remove.
7833         * features/i386/amd64.xml: Remove.
7834         * features/i386/i386-avx-avx512-linux.xml: Remove.
7835         * features/i386/i386-avx-avx512.xml: Remove.
7836         * features/i386/i386-avx-linux.xml: Remove.
7837         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7838         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7839         * features/i386/i386-avx-mpx-linux.xml: Remove.
7840         * features/i386/i386-avx-mpx.xml: Remove.
7841         * features/i386/i386-avx.xml: Remove.
7842         * features/i386/i386-linux.xml: Remove.
7843         * features/i386/i386-mmx-linux.xml: Remove.
7844         * features/i386/i386-mmx.xml: Remove.
7845         * features/i386/i386-mpx-linux.xml: Remove.
7846         * features/i386/i386-mpx.xml: Remove.
7847         * features/i386/i386.xml: Remove.
7848         * features/i386/x32-avx-avx512-linux.xml: Remove.
7849         * features/i386/x32-avx-linux.xml: Remove.
7850         * features/i386/x32-linux.xml: Remove.
7851
7852 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7853
7854         * regformats/aarch64.dat: Remove.
7855         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7856         * regformats/i386/amd64-avx-linux.dat: Remove.
7857         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7858         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7859         * regformats/i386/amd64-linux.dat: Remove.
7860         * regformats/i386/amd64-mpx-linux.dat: Remove.
7861         * regformats/i386/amd64.dat: Remove.
7862         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7863         * regformats/i386/i386-avx-linux.dat: Remove.
7864         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7865         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7866         * regformats/i386/i386-linux.dat: Remove.
7867         * regformats/i386/i386-mmx-linux.dat: Remove.
7868         * regformats/i386/i386-mpx-linux.dat: Remove.
7869         * regformats/i386/i386.dat: Remove.
7870         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7871         * regformats/i386/x32-avx-linux.dat: Remove.
7872         * regformats/i386/x32-linux.dat: Remove.
7873
7874 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7875
7876         * aarch64-tdep.c: Remove xml self tests.
7877         * amd64-linux-tdep.c: Likewise.
7878         * amd64-tdep.c: Likewise.
7879         * i386-linux-tdep.c: Likewise.
7880         * i386-tdep.c: Likewise.
7881
7882 2019-07-03  Pedro Alves  <palves@redhat.com>
7883
7884         PR cli/24732
7885         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7886         (pipe_cmd_option_defs): New.
7887         (make_pipe_cmd_options_def_group): New.
7888         (pipe_command): Use gdb::option::process_options.
7889         (pipe_command_completer): New function.
7890         (_initialize_cli_cmds): Install completer for "pipe" command.
7891
7892 2019-07-03  Pedro Alves  <palves@redhat.com>
7893
7894         * cli/cli-option.c (union option_value) <string>: New field.
7895         (struct option_def_and_value): Add ctor, move ctor, dtor and
7896         use DISABLE_COPY_AND_ASSIGN.
7897         (option_def_and_value::clear_value): New.
7898         (parse_option, save_option_value_in_ctx, get_val_type_str)
7899         (add_setshow_cmds_for_options): Handle var_string.
7900         * cli-option.h (union option_def::var_address) <string>: New
7901         field.
7902         (struct string_option_def): New.
7903         * maint-test-options.c (struct test_options_opts): Add default
7904         ctor and use DISABLE_COPY_AND_ASSIGN.
7905         <string_opt>: New field.
7906         (test_options_opts::~test_options_opts): New.
7907         (test_options_opts::dump): Also dump "-string".
7908         (test_options_option_defs): Install "string.
7909
7910 2019-07-03  Pedro Alves  <palves@redhat.com>
7911
7912         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7913         option_value with a null enumeration.
7914         (complete_options): Save the option values in the context.
7915         (save_option_value_in_ctx): New, factored out from ...
7916         (process_options): ... here.
7917         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7918         of the function.
7919         * maint-test-options.c (test_options_opts::dump): New, factored
7920         out from ...
7921         (maintenance_test_options_command_mode): ... here.
7922         (maintenance_test_options_command_completion_result): Delete.
7923         (maintenance_test_options_command_completion_text): Update
7924         comment.
7925         (maintenance_show_test_options_completion_result): Change
7926         prototype.  Just print
7927         maintenance_test_options_command_completion_text.
7928         (save_completion_result): New.
7929         (maintenance_test_options_completer_mode): Pass options context to
7930         complete_options, and then save a dump.
7931         (_initialize_maint_test_options): Use add_cmd to install "maint
7932         show test-options-completion-result".
7933
7934 2019-07-03  Pedro Alves  <palves@redhat.com>
7935
7936         * NEWS (New commands): Mention "with" and "maint with".
7937         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7938         (with_command, with_command_completer): New.
7939         (pipe_command): Adjust to new repeat_previous
7940         interface.
7941         (_initialize_cli_cmds): Install the "with" command and its "w"
7942         alias.
7943         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7944         declarations.
7945         * cli/cli-setshow.c (parse_cli_var_uinteger)
7946         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7947         argument strings for all var_types.
7948         (get_setshow_command_value_string): New, factored out from ...
7949         (do_show_command): ... this.
7950         * cli/cli-setshow.h: Include <string>.
7951         (get_setshow_command_value_string): Declare.
7952         * command.h (repeat_previous): Now returns const char *.  Adjust
7953         comment.
7954         * maint.c: Include "cli/cli-cmds.h".
7955         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7956         (_initialize_maint_cmds): Register the "maintenance with" command.
7957         * top.c (repeat_previous): Move bits from pipe_command here:
7958         Return the saved command line, if any; error out if there's no
7959         command to relaunch.
7960
7961 2019-07-03  Pedro Alves  <palves@redhat.com>
7962
7963         * NEWS (New commands): Mention "maint set/show test-settings"
7964         instead of "maint test-settings".
7965         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7966         (maintenance_test_settings_set_list): Rename to ...
7967         (maintenance_set_test_settings_list): ... this.
7968         (maintenance_test_settings_show_list): Rename to  ...
7969         (maintenance_show_test_settings_list): ... this.
7970         (maintenance_test_settings_cmd): Delete.
7971         (maintenance_test_settings_set_cmd): ...
7972         (maintenance_set_test_settings_cmd): ... this.
7973         (maintenance_test_settings_show_cmd): ...
7974         (maintenance_show_test_settings_cmd): ... this.
7975         (maintenance_test_settings_show_value_cmd):
7976         (maintenance_show_test_settings_value_cmd): ... this.
7977         (_initialize_maint_test_settings): No longer install the "maint
7978         test-settings" prefix command.  Rename "maint test-settings set"
7979         to "maint set test-settings", and "maint test-settings show" to
7980         "maint show test-settings".  Adjust all subcommands.
7981
7982 2019-07-03  Pedro Alves  <palves@redhat.com>
7983
7984         * maint-test-settings.c: Fix file's intro comment.  Replace all
7985         references to "test-options" with references to "test-settings",
7986         in comments.
7987
7988 2019-07-03  Pedro Alves  <palves@redhat.com>
7989
7990         * maint-test-settings.c (maintenance_test_settings_xxx)
7991         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7992         New.
7993         (maintenance_test_settings_enums): Use them.
7994         (maintenance_test_settings_enum): Default to
7995         maintenance_test_settings_xxx.
7996         (_initialize_maint_test_settings): Initialize
7997         MAINTENANCE_TEST_SETTINGS_FILENAME.
7998
7999 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8000
8001         * breakpoint.h (remove_breakpoints_inf): Change return type to
8002         void, move function documentation here.
8003         * breakpoint.c (remove_breakpoints_inf): Change return type to
8004         void, move function documentation to header.
8005
8006 2019-07-02  Pedro Alves  <palves@redhat.com>
8007
8008         * NEWS (Completion improvements): Mention "info threads".
8009         * thread.c (struct info_threads_opts, info_threads_option_defs)
8010         (make_info_threads_options_def_group): New.
8011         (info_threads_command): Use gdb::option::process_options.
8012         (info_threads_command_completer): New.
8013         (_initialize_thread): Use gdb::option::build_help to build the
8014         help text for "info threads".
8015
8016 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8017
8018         * defs.h (generic_load): Move from here...
8019         * symfile.h (generic_load): ... to here.  Rename name parameter
8020         to args.
8021         * symfile.c (generic_load): Add comment.
8022
8023 2019-07-01  Tom Tromey  <tromey@adacore.com>
8024
8025         * dwarf2read.c
8026         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8027         declaration of without_params.  Fix formatting.
8028
8029 2019-07-01  Tom Tromey  <tromey@adacore.com>
8030
8031         * ada-exp.y (find_primitive_type): Update.
8032         * ada-lang.h (ada_lookup_symbol): Update.
8033         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8034         parameter.
8035         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8036
8037 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8038
8039         PR breakpoints/24541
8040         * gdbarch.c: Regenerate.
8041         * gdbarch.h: Regenerate.
8042         * gdbarch.sh: Add 'stap_adjust_register'.
8043         * i386-tdep.c: Include '<unordered_set>'.
8044         (i386_stap_adjust_register): New function.
8045         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8046         * stap-probe.c (stap_parse_register_operand): Call
8047         'gdbarch_stap_adjust_register'.
8048
8049 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8050
8051         PR python/24742
8052         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8053         * python/python.c (do_start_initialization): Use 'xmalloc'
8054         instead of 'PyMem_Malloc'.
8055
8056 2019-06-28  Tom Tromey  <tromey@adacore.com>
8057
8058         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8059         for Ada.
8060
8061 2019-06-27  Tom Tromey  <tromey@adacore.com>
8062
8063         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8064         objfile_key.
8065         (arm_find_mapping_symbol, arm_record_special_symbol)
8066         (_initialize_arm_tdep): Update.
8067         (arm_objfile_data_free): Remove.
8068
8069 2019-06-27  Tom Tromey  <tromey@adacore.com>
8070
8071         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8072         to cp_print_static_field.
8073
8074 2019-06-26  Tom Tromey  <tromey@adacore.com>
8075
8076         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8077         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8078         declare.
8079
8080 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8081
8082         * features/aarch64-core.c (create_feature_aarch64_core):
8083         Regenerate.
8084         * features/aarch64-core.xml: Add cpsr flags.
8085
8086 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8087
8088         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8089         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8090
8091 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8092
8093         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8094         field.
8095         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8096         use.
8097         (arm_record_special_symbol): Don't insert new symbol in sorted
8098         position, push it at the end.
8099
8100 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8101
8102         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8103         (arm_mapping_symbol_s): Remove.
8104         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8105         (arm_mapping_symbol_vec): New typedef.
8106         (struct arm_per_objfile): Add constructor.
8107         <section_maps>: Change type to
8108         std::unique_ptr<arm_mapping_symbol_vec[]>.
8109         (arm_compare_mapping_symbols): Remove.
8110         (arm_find_mapping_symbol): Adjust to section_maps type change.
8111         (arm_objfile_data_free): Call delete on arm_per_objfile.
8112         (arm_record_special_symbol): Adjust to section_maps type change.
8113         Allocate arm_per_objfile with new.
8114
8115 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8116
8117         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8118         with the command prefix.
8119
8120 2019-06-25  Tom Tromey  <tom@tromey.com>
8121
8122         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8123         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8124
8125 2019-06-25  Tom Tromey  <tom@tromey.com>
8126
8127         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8128         type.
8129         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8130         protected.
8131
8132 2019-06-25  Tom Tromey  <tom@tromey.com>
8133
8134         * tui/tui-winsource.c
8135         (tui_source_window_base::set_is_exec_point_at): Add check against
8136         LOA_ADDRESS.
8137
8138 2019-06-25  Tom Tromey  <tom@tromey.com>
8139
8140         * tui/tui-source.c (tui_set_source_content): Don't check before
8141         xfree.
8142         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8143
8144 2019-06-25  Tom Tromey  <tom@tromey.com>
8145
8146         * tui/tui-winsource.h (tui_update_source_window_as_is)
8147         (tui_alloc_source_buffer, tui_line_is_displayed)
8148         (tui_addr_is_displayed): Change type of win_info.
8149         * tui/tui-winsource.c (tui_update_source_window_as_is)
8150         (tui_clear_source_content, tui_show_source_line)
8151         (tui_show_source_content, tui_source_window_base::refill)
8152         (tui_source_window_base::set_is_exec_point_at)
8153         (tui_source_window_base::set_is_exec_point_at)
8154         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8155         (tui_alloc_source_buffer, tui_line_is_displayed)
8156         (tui_addr_is_displayed): Change type of win_info.  Update.
8157         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8158         (tui_source_window_base::do_make_visible_with_new_height):
8159         Update.
8160         * tui/tui-source.c (tui_set_source_content)
8161         (tui_set_source_content_nil)
8162         (tui_source_window::do_scroll_vertical): Update.
8163         * tui/tui-layout.c (show_layout): Update.
8164         * tui/tui-disasm.c (tui_set_disassem_content)
8165         (tui_disasm_window::do_scroll_vertical): Update.
8166         * tui/tui-data.h (tui_win_content): Remove.
8167         (struct tui_gen_win_info) <content, content_size>: Remove.
8168         (struct tui_source_element): Add initializers and destructor.
8169         (union tui_which_element, struct tui_win_element): Remove.
8170         (struct tui_source_window_base) <content>: New field.
8171         (struct tui_data_window): Remove destructor.
8172         (tui_alloc_content, tui_free_win_content)
8173         (tui_free_all_source_wins_content): Don't declare.
8174         * tui/tui-data.c (tui_initialize_static_data): Update.
8175         (init_content_element, tui_alloc_content): Remove.
8176         (~tui_gen_win_info): Update.
8177         (~tui_data_window, tui_free_all_source_wins_content)
8178         (tui_free_win_content, free_content, free_content_elements):
8179         Remove.
8180
8181 2019-06-25  Tom Tromey  <tom@tromey.com>
8182
8183         * tui/tui-winsource.h (tui_clear_source_content)
8184         (tui_erase_source_content, tui_show_source_content): Change type
8185         of win_info.
8186         * tui/tui-winsource.c (tui_clear_source_content)
8187         (tui_erase_source_content, tui_show_source_content): Change type
8188         of win_info.
8189         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8190         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8191         win_info.
8192         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8193         win_info.
8194         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8195
8196 2019-06-25  Tom Tromey  <tom@tromey.com>
8197
8198         * tui/tui-winsource.c (tui_clear_source_content)
8199         (tui_source_window_base::set_is_exec_point_at): Update.
8200         * tui/tui-source.c (tui_set_source_content_nil): Update.
8201         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8202         a bool.
8203         * tui/tui-data.c (init_content_element): Update.
8204
8205 2019-06-25  Tom Tromey  <tom@tromey.com>
8206
8207         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8208         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8209         * tui/tui-layout.c (init_and_make_win): Update.
8210         * tui/tui.h (enum tui_win_type): Update.
8211         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8212         tui_win_is_auxillary.
8213         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8214         tui_win_is_auxillary.
8215
8216 2019-06-25  Tom Tromey  <tom@tromey.com>
8217
8218         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8219         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8220         (tui_delete_data_content_windows, tui_display_all_data)
8221         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8222         Update.
8223         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8224         * tui/tui-regs.c (tui_last_regs_line_no)
8225         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8226         (tui_show_registers): Update.
8227         (tui_show_register_group): Return void.  Update.
8228         (tui_display_registers_from, tui_display_reg_element_at_line)
8229         (tui_display_registers_from_line, tui_check_register_values):
8230         Update.
8231         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8232         member.
8233         (struct tui_data_window) <regs_content>: Now a std::vector.
8234         <regs_content_count>: Remove.
8235         (tui_add_content_elements, tui_free_data_content): Don't declare.
8236         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8237         (init_content_element): Remove DATA_WIN case.  Add assert.
8238         (tui_add_content_elements): Remove.
8239         (tui_data_window): Update.
8240         (tui_free_data_content): Remove.
8241         (free_content_elements): Remove DATA_WIN case.
8242
8243 2019-06-25  Tom Tromey  <tom@tromey.com>
8244
8245         * tui/tui-data.c (tui_data_item_window): Update.
8246         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8247         * tui/tui-windata.c (tui_display_all_data)
8248         (tui_display_data_from_line): Update.
8249         (tui_check_data_values): Remove.
8250         * tui/tui-regs.c (tui_show_register_group)
8251         (tui_display_reg_element_at_line): Update.
8252         * tui/tui-hooks.c (tui_register_changed)
8253         (tui_refresh_frame_and_register_information): Call
8254         tui_check_register_values.
8255         * tui/tui-data.h (struct tui_data_window) <data_content,
8256         data_content_count, data_type>: Remove.
8257         (enum tui_data_type): Remove.
8258
8259         * tui/tui-data.c (tui_data_window::clear_detail)
8260         (~tui_data_window): Update.
8261
8262 2019-06-25  Tom Tromey  <tom@tromey.com>
8263
8264         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8265         declare.
8266         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8267         Rename from tui_first_data_item_displayed.  Update.
8268         (tui_data_window::refresh_all)
8269         (tui_data_window::do_scroll_vertical): Update.
8270         * tui/tui-data.h (struct tui_data_window)
8271         <first_data_item_displayed>: Declare new method.
8272
8273 2019-06-25  Tom Tromey  <tom@tromey.com>
8274
8275         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8276         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8277         contents...
8278         (tui_initialize_static_data): ...here.
8279
8280 2019-06-25  Tom Tromey  <tom@tromey.com>
8281
8282         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8283         (tui_display_registers_from, tui_check_register_values): Update.
8284         (tui_display_register): Remove win_info parameter; update.
8285         (tui_get_register): Change type of parameters.
8286         * tui/tui-data.h (struct tui_data_element): Remove.
8287         (union tui_which_element) <data>: Remove.
8288         <data_window>: Change type.
8289         (struct tui_data_item_window): New.
8290         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8291         case.  Add assert.
8292         (~tui_data_item_window): New destructor.
8293         (free_content_elements): Remove DATA_ITEM_WIN case.
8294
8295 2019-06-25  Tom Tromey  <tom@tromey.com>
8296
8297         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8298         Remove.
8299
8300 2019-06-25  Tom Tromey  <tom@tromey.com>
8301
8302         * tui/tui-data.h (struct tui_command_element): Remove.
8303         (union tui_which_element) <command>: Remove.
8304         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8305         assert.
8306         (free_content_elements): Remove CMD_WIN case.
8307
8308 2019-06-25  Tom Tromey  <tom@tromey.com>
8309
8310         * tui/tui-layout.c (tui_set_layout): Update.
8311         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8312         * tui/tui-data.c (layout_def): Update.
8313
8314 2019-06-25  Tom Tromey  <tom@tromey.com>
8315
8316         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8317         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8318         (tui_source_window_base::set_new_height): Update.
8319         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8320         Update.
8321         (tui_set_locator_fullname, tui_set_locator_info)
8322         (tui_show_frame_info): Update.
8323         * tui/tui-source.c (tui_set_source_content)
8324         (tui_source_is_displayed): Update.
8325         * tui/tui-layout.c (show_source_disasm_command, show_data)
8326         (show_source_or_disasm_and_command): Update.
8327         * tui/tui-disasm.c (tui_set_disassem_content)
8328         (tui_get_begin_asm_address): Update.
8329         * tui/tui-data.h (struct tui_locator_element): Remove.
8330         (union tui_which_element) <locator>: Remove.
8331         (struct tui_locator_window): New.
8332         (tui_locator_win_info_ptr): Change return type.
8333         * tui/tui-data.c (_locator): Change type.
8334         (tui_locator_win_info_ptr): Change return type.
8335         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8336         (tui_alloc_content): Add assert.
8337
8338 2019-06-25  Tom Tromey  <tom@tromey.com>
8339
8340         * tui/tui-winsource.c
8341         (tui_exec_info_window::maybe_allocate_content): New method.
8342         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8343         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8344         (make_source_or_disasm_window): Add cast.
8345         * tui/tui-data.h (union tui_which_element) <simple_string>:
8346         Remove.
8347         (struct tui_source_info): New.
8348         (struct tui_source_window_base) <execution_info>: Change type.
8349         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8350         case, and add assert.
8351         (tui_alloc_content): Add assert.
8352
8353 2019-06-25  Tom Tromey  <tom@tromey.com>
8354
8355         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8356         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8357         * tui/tui-data.c (tui_alloc_win_info): Remove.
8358
8359 2019-06-25  Tom Tromey  <tom@tromey.com>
8360
8361         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8362         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8363         can_highlight.
8364
8365 2019-06-25  Tom Tromey  <tom@tromey.com>
8366
8367         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8368         make_visible_with_new_height method.
8369         (tui_win_info::make_visible_with_new_height): New method.
8370         (tui_source_window_base::do_make_visible_with_new_height)
8371         (tui_data_window::do_make_visible_with_new_height)
8372         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8373         (make_visible_with_new_height): Remove.
8374         (tui_resize_all, tui_adjust_win_heights): Use
8375         make_visible_with_new_height method.
8376         * tui/tui-data.h (struct tui_win_info)
8377         <do_make_visible_with_new_height, make_visible_with_new_height>:
8378         New methods.
8379         (struct tui_source_window_base, struct tui_data_window)
8380         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8381         methods.
8382
8383 2019-06-25  Tom Tromey  <tom@tromey.com>
8384
8385         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8386         method.
8387         (update_tab_width): Call update_tab_width method.
8388         * tui/tui-data.h (struct tui_win_info)
8389         (struct tui_source_window_base) <update_tab_width>: New methods.
8390
8391 2019-06-25  Tom Tromey  <tom@tromey.com>
8392
8393         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8394         parameter.
8395         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8396         parameter.
8397         (tui_gen_win_info::make_visible): Update.
8398         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8399         parameter.
8400         * tui/tui-data.h (enum tui_box): New enum.
8401         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8402
8403 2019-06-25  Tom Tromey  <tom@tromey.com>
8404
8405         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8406         init_and_make_win for EXEC_INFO_WIN.
8407         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8408         longer inline.
8409         (struct tui_win_info) <~tui_win_info>: Inline.
8410         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8411         Don't declare.
8412         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8413         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8414         Remove.
8415         (tui_initialize_static_data): Update.
8416         (~tui_gen_win_info): Handle more cleanup here.
8417         (~tui_source_window_base): Delete "execution_info".
8418         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8419
8420 2019-06-25  Tom Tromey  <tom@tromey.com>
8421
8422         * tui/tui-layout.c (make_command_window): Don't set
8423         can_highlight.
8424         (show_source_disasm_command): Call the reset method.
8425         (show_data): Don't set can_highlight.  Call the reset method.
8426         (tui_gen_win_info::reset): Rename from init_gen_win_info
8427         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8428         (show_source_or_disasm_and_command): Call the reset method.
8429         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8430         (struct tui_cmd_window): Set can_highlight.
8431
8432 2019-06-25  Tom Tromey  <tom@tromey.com>
8433
8434         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8435         from make_visible.
8436         (tui_make_visible, tui_make_invisible): Rewrite.
8437         (tui_win_info::make_visible): Remove.
8438         (tui_source_window_base::make_visible): Update.
8439         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8440         method.  Moved from...
8441         (struct tui_win_info) <make_visible>: ...here.
8442
8443 2019-06-25  Tom Tromey  <tom@tromey.com>
8444
8445         * tui/tui-winsource.c
8446         (tui_source_window_base::do_scroll_horizontal): Remove direction
8447         parameter.
8448         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8449         direction parameter.
8450         * tui/tui-win.c (tui_win_info::forward_scroll)
8451         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8452         (tui_win_info::right_scroll): Update.
8453         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8454         direction parameter.
8455         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8456         direction parameter.
8457         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8458         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8459         Remove direction parameter.
8460         (struct tui_source_window_base, struct tui_source_window)
8461         (struct tui_disasm_window, struct tui_data_window)
8462         (struct tui_cmd_window): Update.
8463
8464 2019-06-25  Tom Tromey  <tom@tromey.com>
8465
8466         * tui/tui-winsource.h (tui_set_exec_info_content)
8467         (tui_show_exec_info_content, tui_erase_exec_info_content)
8468         (tui_clear_exec_info_content, tui_update_exec_info): Change
8469         argument to tui_source_window_base.
8470         * tui/tui-winsource.c (tui_set_exec_info_content)
8471         (tui_show_exec_info_content, tui_erase_exec_info_content)
8472         (tui_clear_exec_info_content, tui_update_exec_info): Change
8473         argument to tui_source_window_base.
8474
8475 2019-06-25  Tom Tromey  <tom@tromey.com>
8476
8477         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8478         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8479
8480 2019-06-25  Tom Tromey  <tom@tromey.com>
8481
8482         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8483         check.
8484
8485 2019-06-25  Tom Tromey  <tom@tromey.com>
8486
8487         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8488         type to void.
8489         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8490         type to void.
8491         * tui/tui-source.c (tui_set_source_content): Update.
8492         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8493
8494 2019-06-25  Tom Tromey  <tom@tromey.com>
8495
8496         * tui/tui-win.c (window_name_completer, tui_set_focus)
8497         (tui_all_windows_info): Use name method.
8498         * tui/tui-data.h (struct tui_gen_win_info)
8499         (struct tui_source_window, struct tui_disasm_window)
8500         (struct tui_data_window, struct tui_cmd_window) <name>: New
8501         method.
8502         (tui_win_name): Don't declare.
8503         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8504         (tui_win_name): Remove.
8505
8506 2019-06-25  Tom Tromey  <tom@tromey.com>
8507
8508         * tui/tui-winsource.h (tui_update_source_window)
8509         (tui_update_source_window_as_is): Change parameter type.
8510         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8511         to be a tui_source_window_base.
8512         (tui_update_source_window_as_is): Likewise.
8513         * tui/tui-win.c (make_visible_with_new_height): Update.
8514
8515 2019-06-25  Tom Tromey  <tom@tromey.com>
8516
8517         * tui/tui-winsource.c (tui_erase_source_content)
8518         (tui_show_source_content, tui_show_exec_info_content)
8519         (tui_erase_exec_info_content): Use refresh_window method.
8520         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8521         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8522         from tui_refresh_win.
8523         (tui_data_window::refresh_window): New method.
8524         (tui_win_info::refresh, tui_source_window_base::refresh)
8525         (tui_refresh_all): Use refresh_window method.
8526         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8527         method.
8528         * tui/tui-regs.c (tui_display_register): Call refresh_window
8529         method.
8530         * tui/tui-layout.c (show_source_disasm_command)
8531         (show_source_or_disasm_and_command): Call refresh_window method.
8532         * tui/tui-data.h (struct tui_gen_win_info)
8533         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8534         New method.
8535
8536 2019-06-25  Tom Tromey  <tom@tromey.com>
8537
8538         * tui/tui.c (tui_rl_other_window, tui_enable)
8539         (tui_is_window_visible, tui_get_command_dimension): Update.
8540         * tui/tui-winsource.c (tui_update_source_window_as_is)
8541         (tui_clear_source_content, tui_erase_source_content)
8542         (tui_show_source_line, tui_source_window_base::refill)
8543         (tui_source_window_base::do_scroll_horizontal)
8544         (tui_source_window_base::set_is_exec_point_at)
8545         (tui_update_breakpoint_info, tui_set_exec_info_content)
8546         (tui_alloc_source_buffer, tui_line_is_displayed)
8547         (tui_addr_is_displayed): Update.
8548         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8549         (tui_check_and_display_highlight_if_needed)
8550         (tui_win_info::make_visible, tui_win_info::refresh)
8551         (tui_refresh_all): Update.
8552         * tui/tui-windata.c (tui_first_data_item_displayed)
8553         (tui_delete_data_content_windows, tui_erase_data_content)
8554         (tui_display_all_data, tui_data_window::refresh_all)
8555         (tui_check_data_values): Update.
8556         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8557         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8558         (tui_win_info::backward_scroll, tui_refresh_all_win)
8559         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8560         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8561         (tui_source_window_base::set_new_height)
8562         (tui_data_window::set_new_height)
8563         (make_invisible_and_set_new_height)
8564         (make_visible_with_new_height, new_height_ok)
8565         (parse_scrolling_args): Update.
8566         * tui/tui-stack.c (tui_show_frame_info): Update.
8567         * tui/tui-source.c (tui_set_source_content)
8568         (tui_set_source_content_nil, tui_source_is_displayed)
8569         (tui_source_window::do_scroll_vertical): Update.
8570         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8571         (tui_display_registers_from, tui_display_reg_element_at_line)
8572         (tui_check_register_values, tui_reg_command): Update.
8573         * tui/tui-layout.c (tui_default_win_height)
8574         (show_source_disasm_command, show_data, init_and_make_win)
8575         (show_source_or_disasm_and_command): Update.
8576         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8577         (tui_redisplay_readline, tui_mld_flush)
8578         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8579         (tui_getc): Update.
8580         * tui/tui-disasm.c (tui_set_disassem_content)
8581         (tui_disasm_window::do_scroll_vertical): Update.
8582         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8583         Now virtual.
8584         (struct tui_win_info): Derive from tui_gen_win_info.
8585         <~tui_win_info>: Mark as override.
8586         <generic>: Remove member.
8587         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8588         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8589         (~tui_data_window, ~tui_win_info)
8590         (tui_free_all_source_wins_content): Update.
8591         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8592
8593 2019-06-25  Tom Tromey  <tom@tromey.com>
8594
8595         * tui/tui-layout.c (init_and_make_win): Use new.
8596         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8597         destructor, initializers.
8598         (tui_alloc_generic_win_info): Don't declare.
8599         * tui/tui-data.c (_locator): Add argument to constructor.
8600         (source_win, disasm_win): New globals.
8601         (exec_info): Remove.
8602         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8603         Update.
8604         (tui_alloc_generic_win_info): Remove.
8605         (init_content_element): Use new.
8606         (tui_win_info::tui_win_info): Update.
8607         (free_content_elements) <case DATA_WIN>: Use delete.
8608
8609 2019-06-25  Tom Tromey  <tom@tromey.com>
8610
8611         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8612         * tui/tui-windata.c (tui_first_data_item_displayed)
8613         (tui_delete_data_content_windows): Update.
8614         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8615         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8616         (tui_display_registers_from, tui_check_register_values): Update.
8617         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8618         pointer.
8619         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8620         window.
8621         (tui_free_data_content): Update.
8622         (free_content_elements) <case DATA_WIN>: Free the window.
8623
8624 2019-06-25  Tom Tromey  <tom@tromey.com>
8625
8626         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8627         Update.
8628         * tui/tui-layout.c (make_command_window)
8629         (show_source_disasm_command, show_data, init_and_make_win)
8630         (show_source_or_disasm_and_command): Update.
8631         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8632         method.
8633         <can_highight, is_highlighted>: Now bool.
8634         (tui_set_win_highlight): Don't declare.
8635         * tui/tui-data.c (tui_set_win_highlight): Remove.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-wingeneral.c (make_visible): Remove check of window
8640         type.
8641
8642 2019-06-25  Tom Tromey  <tom@tromey.com>
8643
8644         * tui/tui-win.c (tui_win_info::max_height)
8645         (tui_cmd_window::max_height): New methods.
8646         (new_height_ok): Call max_height.
8647         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8648         <max_height>: New method.
8649
8650 2019-06-25  Tom Tromey  <tom@tromey.com>
8651
8652         * tui/tui-win.c (tui_source_window_base::set_new_height)
8653         (tui_data_window::set_new_height): New methods.
8654         (make_invisible_and_set_new_height): Call set_new_height method.
8655         * tui/tui-data.h (struct tui_win_info)
8656         (struct tui_source_window_base, struct tui_data_window)
8657         <set_new_height>: New method.
8658
8659 2019-06-25  Tom Tromey  <tom@tromey.com>
8660
8661         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8662         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8663         tui_refresh_data_win.
8664         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8665         method.
8666         (tui_refresh_all_win): Call the refresh_all method.
8667         (tui_set_focus): Likewise.
8668         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8669         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8670         Likewise.
8671
8672 2019-06-25  Tom Tromey  <tom@tromey.com>
8673
8674         * tui/tui-winsource.h (tui_refill_source_window)
8675         (tui_set_is_exec_point_at): Don't declare.
8676         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8677         (tui_source_window_base::refill): Rename from
8678         tui_refill_source_window.
8679         (tui_source_window_base::do_scroll_horizontal): Update.
8680         (tui_source_window_base::set_is_exec_point_at): Rename from
8681         tui_set_is_exec_point_at.
8682         (tui_update_all_breakpoint_info): Update.
8683         * tui/tui-stack.c (tui_show_frame_info): Update.
8684         * tui/tui-layout.c (show_data): Add cast.
8685         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8686         * tui/tui-data.h (struct tui_source_window_base) <refill,
8687         set_is_exec_point_at>: New methods.
8688         (tui_source_windows, tui_add_to_source_windows): Update types.
8689         (tui_add_to_source_windows): Remove redundant declaration.
8690         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8691         (tui_source_windows): Change return type.
8692         (tui_clear_source_windows_detail): Update.
8693         (tui_add_to_source_windows): Change type of parameter.
8694         (tui_free_all_source_wins_content): Update.
8695
8696 2019-06-25  Tom Tromey  <tom@tromey.com>
8697
8698         * tui/tui-wingeneral.c (tui_win_info::refresh)
8699         (tui_source_window_base::refresh): New methods.
8700         (tui_refresh_all): Call the refresh method.
8701         * tui/tui-data.h (struct tui_win_info)
8702         (struct tui_source_window_base) <refresh>: New method.
8703
8704 2019-06-25  Tom Tromey  <tom@tromey.com>
8705
8706         * tui/tui.h (tui_is_window_visible): Return bool.
8707         * tui/tui.c (tui_is_window_visible): Return bool.
8708         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8709         (tui_make_visible, tui_make_invisible)
8710         (tui_win_info::make_visible)
8711         (tui_source_window_base::make_visible, make_all_visible)
8712         (tui_make_all_visible, tui_make_all_invisible): Update.
8713         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8714         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8715         bool.
8716         (struct tui_win_info, struct tui_source_window_base)
8717         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8718         * tui/tui-data.c (tui_init_generic_part): Update.
8719
8720 2019-06-25  Tom Tromey  <tom@tromey.com>
8721
8722         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8723         (tui_source_window_base::make_visible): New methods.
8724         (make_all_visible): Make method call.
8725         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8726         (struct tui_source_window_base, struct tui_cmd_window): Override
8727         make_visible.
8728         (tui_win_is_source_type): Don't declare.
8729         * tui/tui-data.c (tui_win_is_source_type): Remove.
8730
8731 2019-06-25  Tom Tromey  <tom@tromey.com>
8732
8733         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8734         NULL check.
8735
8736 2019-06-25  Tom Tromey  <tom@tromey.com>
8737
8738         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8739         Inline constructor.  Add initializers for members.
8740         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8741         constructors; now inline in class.
8742
8743 2019-06-25  Tom Tromey  <tom@tromey.com>
8744
8745         * tui/tui-regs.c (tui_show_registers): Update.
8746         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8747         bool.
8748         * tui/tui-data.c (tui_data_window::clear_detail)
8749         (tui_data_window): Update.
8750
8751 2019-06-25  Tom Tromey  <tom@tromey.com>
8752
8753         * tui/tui-windata.c (tui_display_all_data)
8754         (tui_display_data_from_line, tui_display_data_from)
8755         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8756         Update.
8757         * tui/tui-regs.c (tui_last_regs_line_no)
8758         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8759         (tui_show_registers, tui_show_register_group)
8760         (tui_display_registers_from, tui_display_reg_element_at_line)
8761         (tui_display_registers_from_line, tui_check_register_values)
8762         (tui_reg_next, tui_reg_prev): Update.
8763         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8764         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8765         tui_data_window.
8766         (struct tui_win_info) <detail>: Remove.  Add new fields from
8767         tui_data_info.
8768         (TUI_DATA_WIN): Add cast.
8769         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8770         (~tui_data_window): Simplify.
8771
8772 2019-06-25  Tom Tromey  <tom@tromey.com>
8773
8774         * tui/tui-layout.c (show_source_disasm_command)
8775         (show_source_or_disasm_and_command): Update.
8776         * tui/tui-io.c (update_cmdwin_start_line)
8777         (tui_redisplay_readline): Update.
8778         * tui/tui-data.h (struct tui_command_info): Remove.
8779         (struct tui_win_info) <detail>: Remove command_info member.
8780         (struct tui_data_window) <start_line>: New member, from
8781         tui_command_info.
8782         (TUI_CMD_WIN): Add casts.
8783
8784 2019-06-25  Tom Tromey  <tom@tromey.com>
8785
8786         * tui/tui-winsource.c (tui_update_source_window)
8787         (tui_refill_source_window)
8788         (tui_source_window_base::do_scroll_horizontal)
8789         (tui_update_breakpoint_info, tui_set_exec_info_content)
8790         (tui_show_exec_info_content, tui_erase_exec_info_content)
8791         (tui_clear_exec_info_content): Update.
8792         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8793         Update.
8794         * tui/tui-win.c (make_invisible_and_set_new_height)
8795         (make_visible_with_new_height): Update.
8796         * tui/tui-source.c (tui_set_source_content)
8797         (tui_show_symtab_source): Update.
8798         * tui/tui-layout.c (extract_display_start_addr)
8799         (show_source_disasm_command, show_data)
8800         (make_source_or_disasm_window)
8801         (show_source_or_disasm_and_command): Update.
8802         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8803         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8804         "gdbarch".
8805         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8806         to tui_source_window_base.
8807         (struct tui_win_info) <detail>: Remove source_info member.
8808         (struct tui_source_window_base) <has_locator>: Inline.
8809         Move contents from tui_source_info; rename has_locator member to
8810         m_has_locator.
8811         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8812         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8813         header file.
8814         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8815         Simplify.
8816         (tui_free_all_source_wins_content): Cast to
8817         tui_source_window_base.
8818
8819 2019-06-25  Tom Tromey  <tom@tromey.com>
8820
8821         * tui/tui-win.c (make_invisible_and_set_new_height)
8822         (make_visible_with_new_height): Call has_locator method.
8823         * tui/tui-layout.c (show_source_disasm_command, show_data)
8824         (show_source_or_disasm_and_command): Update for bool change.
8825         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8826         (tui_win_info) <has_locator>: New method.
8827         (struct tui_source_window_base) <has_locator>: New method.
8828         (tui_win_has_locator): Don't declare.
8829         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8830         from tui_win_has_locator.
8831         (tui_source_window_base): Use false, not FALSE.
8832
8833 2019-06-25  Tom Tromey  <tom@tromey.com>
8834
8835         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8836         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8837         clear_detail method directly.
8838         (tui_clear_win_detail): Remove.
8839
8840 2019-06-25  Tom Tromey  <tom@tromey.com>
8841
8842         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8843         "this", not TUI_DISASM_WIN.
8844
8845 2019-06-25  Tom Tromey  <tom@tromey.com>
8846
8847         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8848         declare.
8849         * tui/tui-winsource.c
8850         (tui_source_window_base::do_scroll_horizontal): Rename from
8851         tui_horizontal_source_scroll.
8852         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8853         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8854         from tui_vertical_data_scroll.
8855         * tui/tui-win.h (tui_scroll): Don't declare.
8856         * tui/tui-win.c (tui_win_info::forward_scroll)
8857         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8858         (tui_win_info::right_scroll): Rename and update.
8859         (tui_scroll_forward_command, tui_scroll_backward_command)
8860         (tui_scroll_left_command, tui_scroll_right_command): Update.
8861         (tui_scroll): Remove.
8862         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8863         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8864         from tui_vertical_source_scroll.
8865         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8866         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8867         from tui_vertical_disassem_scroll.
8868         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8869         do_scroll_horizontal>: New methods.
8870         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8871         Likewise.
8872         (struct tui_source_window_base): Add do_scroll_horizontal.
8873         (struct tui_source_window, struct tui_disasm_window): Add
8874         do_scroll_vertical.
8875         (struct tui_data_window, struct tui_cmd_window): Add
8876         do_scroll_horizontal and do_scroll_vertical.
8877         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8878
8879 2019-06-25  Tom Tromey  <tom@tromey.com>
8880
8881         * tui/tui-data.h (struct tui_source_window_base): New struct.
8882         (struct tui_source_window): Derive from tui_source_window_base.
8883         (struct tui_disasm_window): New struct.
8884         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8885         from tui_source_window::clear_detail.
8886         (tui_source_window_base): Rename from tui_source_window.
8887         (~tui_source_window_base): Rename from ~tui_source_window.
8888         (tui_alloc_win_info): Create a tui_disasm_window.
8889
8890 2019-06-25  Tom Tromey  <tom@tromey.com>
8891
8892         * tui/tui-data.h (struct tui_source_window)
8893         (struct tui_data_window): Declare destructors.
8894         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8895         destructors.
8896         (tui_win_info): Simplify.
8897
8898 2019-06-25  Tom Tromey  <tom@tromey.com>
8899
8900         * tui/tui-winsource.c (tui_display_main)
8901         (tui_update_source_windows_with_addr)
8902         (tui_update_all_breakpoint_info): Update.
8903         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8904         (new_height_ok, parse_scrolling_args): Update.
8905         * tui/tui-stack.c (tui_show_frame_info): Update.
8906         * tui/tui-data.h (struct tui_list): Remove.
8907         (tui_source_windows): Return a reference to a std::vector.
8908         * tui/tui-data.c (source_windows): Now a std::vector.
8909         (tui_source_windows): Change return type.
8910         (tui_clear_source_windows): Rewrite.
8911         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8912         (tui_free_all_source_wins_content): Rewrite.
8913
8914 2019-06-25  Tom Tromey  <tom@tromey.com>
8915
8916         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8917         (struct tui_data_window, struct tui_cmd_window): Declare
8918         clear_detail method.
8919         * tui/tui-data.c (tui_source_window::clear_detail)
8920         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8921         methods.
8922         (tui_clear_win_detail): Simplify.
8923
8924 2019-06-25  Tom Tromey  <tom@tromey.com>
8925
8926         * tui/tui-layout.c (make_source_window, make_disasm_window)
8927         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8928         Return the new window.
8929         (show_source_disasm_command, show_data)
8930         (show_source_or_disasm_and_command): Update.
8931
8932 2019-06-25  Tom Tromey  <tom@tromey.com>
8933
8934         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8935         parameter.  Return the new window.
8936         (show_source_disasm_command): Update and remove NULL check.
8937         (show_source_or_disasm_and_command): Update.
8938
8939 2019-06-25  Tom Tromey  <tom@tromey.com>
8940
8941         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8942
8943 2019-06-25  Tom Tromey  <tom@tromey.com>
8944
8945         * tui/tui-data.h (struct tui_win_info): Make constructor
8946         protected.  Make destructor virtual.  Add initializers.
8947         (tui_source_window, tui_data_window, tui_cmd_window): New
8948         classes.
8949         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8950         constructor.  Add "type" parameter.
8951         (tui_source_window, tui_data_window, tui_cmd_window): New
8952         constructors.
8953         (tui_alloc_win_info): Instantiate the appropriate subclass.
8954
8955 2019-06-25  Tom Tromey  <tom@tromey.com>
8956
8957         * tui/tui-win.c (tui_resize_all): Use delete.
8958         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8959         destructor.
8960         (tui_free_window): Don't declare.
8961         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8962         Update.
8963
8964 2019-06-25  Tom Tromey  <tom@tromey.com>
8965
8966         * tui/tui-data.h (struct tui_win_info): Add constructor.
8967         * tui/tui-data.c (tui_alloc_win_info): Use new.
8968         (tui_free_window): Use delete.
8969
8970 2019-06-22  Tom Tromey  <tom@tromey.com>
8971
8972         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8973         declare.
8974         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8975
8976 2019-06-22  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8979         declare.
8980         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8981
8982 2019-06-22  Tom de Vries  <tdevries@suse.de>
8983
8984         * dwarf2read.c (create_addrmap_from_aranges)
8985         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8986         instead of '%zu'.
8987
8988 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8989
8990         * dwarf2read.h (dwarf2_section_info_def): Remove.
8991         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8992         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8993         std::vector<dwarf2_section_info>.
8994         (struct dwo_file) <~dwo_file>: Remove.
8995         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8996         types field.
8997         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8998         (dwarf2_read_debug_names): Likewise.
8999         (create_debug_types_hash_table): Change parameter type to
9000         array_view, adjust code accordingly.
9001         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9002         (partial_die_info::fixup): Likewise.
9003         (determine_prefix): Likewise.
9004         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9005
9006 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9007
9008         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9009         gdb_bfd_ref_ptr.
9010         <~dwo_file>: Remove call to gdb_bfd_unref.
9011         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9012         gdb_bfd_ref_ptr::get.
9013
9014 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9015
9016         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9017         type to htab_up.
9018         * dwarf2read.c (struct dwo_file): Initialize fields.
9019         <~dwo_file>: New.
9020         (free_dwo_file): Remove, move content to ~dwo_file.
9021         (struct dwo_file_deleter): Remove.
9022         (dwo_file_up>: Remove custom deleter.
9023         (free_dwo_files): Remove.
9024         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9025         dwo_files.
9026         (process_skeletonless_type_units): Call unique_ptr::get.
9027         (allocate_dwo_file_hash_table): Add deleter to created hash
9028         table.  Change return type to htab_up.
9029         (lookup_dwo_file_slot): Don't memset dwo_file, call
9030         unique_ptr::get.
9031         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9032         (create_dwo_unit_in_dwp_v2): Likewise.
9033         (open_and_init_dwo_file): Likewise.
9034         (free_dwo_file_from_slot): Remove.
9035
9036 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9037
9038         * dwarf2read.h (struct dwarf2_section_info) <readin,
9039         is_virtual>: Change type to bool.
9040         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9041         true instead of 1.
9042
9043 2019-06-19  Tom Tromey  <tom@tromey.com>
9044
9045         * tui/tui-data.h (tui_init_content_element): Don't declare.
9046
9047 2019-06-19  Tom Tromey  <tom@tromey.com>
9048
9049         * tui/tui-data.h (tui_init_win_info): Don't declare.
9050
9051 2019-06-19  Tom de Vries  <tdevries@suse.de>
9052
9053         * dwarf2read.h (abstract_to_concrete): Change type to
9054         std::unordered_map<sect_offset, std::vector<sect_offset>,
9055         gdb::hash_enum<sect_offset>>.
9056
9057 2019-06-19  Tom Tromey  <tromey@adacore.com>
9058
9059         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9060         EVAL_AVOID_SIDE_EFFECTS specially.
9061
9062 2019-06-19  Tom Tromey  <tromey@adacore.com>
9063
9064         * source-cache.c (highlighter): New global.
9065         (source_cache::get_source_lines): Create a highlighter on demand.
9066
9067 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * defs.h (deprecated_interactive_hook): Delete declaration.
9070         * interps.c (clear_interpreter_hooks): Remove use of
9071         deprecated_interactive_hook.
9072         * top.c (deprecated_interactive_hook): Delete definition.
9073         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9074
9075 2019-06-18  Tom de Vries  <tdevries@suse.de>
9076
9077         PR gdb/24515
9078         * dwarf2read.h (abstract_to_concrete): Change type from
9079         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9080         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9081         * dwarf2read.c (read_variable): Update.
9082         (dwarf2_fetch_die_loc_sect_off): Update.
9083
9084 2019-06-17  Tom de Vries  <tdevries@suse.de>
9085
9086         PR gdb/24617
9087         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9088         accessing parent[parent_len - 1].
9089
9090 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9091
9092         PR gdb/24364
9093         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9094         call dtrace_process_dof with NULL dof.
9095
9096 2019-06-16  Tom de Vries  <tdevries@suse.de>
9097
9098         PR gdb/24445
9099         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9100
9101 2019-06-16  Tom Tromey  <tom@tromey.com>
9102
9103         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9104         (make_all_visible): Use address of member.
9105
9106 2019-06-16  Tom Tromey  <tom@tromey.com>
9107
9108         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9109         (tui_free_window, free_content, free_content_elements): Remove
9110         unnecessary cast.
9111         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9112         cast.
9113         * tui/tui-regs.c (tui_show_register_group)
9114         (tui_display_registers_from, tui_display_reg_element_at_line):
9115         Remove unnecessary cast.
9116
9117 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * linux-nat.c (normal_mask): Delete.
9120         (_initialize_linux_nat): Don't initialise normal_mask.
9121
9122 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9123
9124         PR gdb/24445
9125         * dwarf-index-write.h (write_psymtabs_to_index): Add
9126         dwz_basename parameter.
9127         * dwarf-index-write.c (write_gdbindex): Move file writing to
9128         write_gdbindex_1.  Change return type void.
9129         (assert_file_size): Move up, remove filename parameter.
9130         (write_gdbindex_1): New function.
9131         (write_debug_names): Change return type to void, call
9132         assert_file_size.
9133         (struct index_wip_file): New struct.
9134         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9135         file logic to index_wip_file.  Write index for dwz file if
9136         needed.
9137         (save_gdb_index_command): Pass basename of dwz file, if present.
9138         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9139         build-id of dwz file, if present.
9140         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9141         (dwarf2_get_dwz_file): Likewise.
9142         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9143         (dwarf2_get_dwz_file): Likewise.
9144
9145 2019-06-16  Tom Tromey  <tom@tromey.com>
9146
9147         * coffread.c (process_coff_symbol): Use xstrdup.
9148         * value.c (create_internalvar): Use xstrdup.
9149
9150 2019-06-16  Tom Tromey  <tom@tromey.com>
9151
9152         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9153         * breakpoint.c (stopin_command, stopat_command)
9154         (until_break_command, decode_location_default): Remove unnecessary
9155         cast.
9156         * utils.c (subset_compare): Remove unnecessary cast.
9157         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9158         cast.
9159         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9160         cast.
9161         * infcmd.c (path_command): Remove unnecessary cast.
9162         * coffread.c (decode_type): Remove unnecessary cast.
9163         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9164         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9165         * tui/tui-stack.c (tui_show_locator_content)
9166         (tui_show_frame_info): Remove unnecessary cast.
9167         * tui/tui-win.c (tui_scroll_forward_command)
9168         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9169         (parse_scrolling_args): Remove unnecessary cast.
9170         * tui/tui-data.c (init_win_info, tui_del_window)
9171         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9172         (free_content_elements): Remove unnecessary cast.
9173         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9174         unnecessary cast.
9175         * tui/tui-source.c (tui_set_source_content)
9176         (tui_vertical_source_scroll): Remove unnecessary cast.
9177         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9178         cast.
9179         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9180         * tui/tui-regs.c (tui_display_registers_from)
9181         (tui_display_register): Remove unnecessary cast.
9182         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9183         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9184         (make_visible): Remove unnecessary cast.
9185         * tui/tui-winsource.c (tui_erase_source_content)
9186         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9187         unnecessary cast.
9188         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9189         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9190         * stabsread.c (read_type, read_array_type, read_range_type):
9191         Remove unnecessary cast.
9192         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9193         (parse_symbol, parse_type, upgrade_type, parse_external)
9194         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9195         unnecessary cast.
9196         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9197
9198 2019-06-16  Tom Tromey  <tom@tromey.com>
9199
9200         * tui/tui-data.c (tui_alloc_generic_win_info)
9201         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9202         checks.
9203
9204 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9205             Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * f-typeprint.c (f_print_type): Don't return early for not
9208         associated or not allocated types.
9209         (f_type_print_varspec_suffix): Add print_rank parameter and print
9210         ranks of array types in case they dangling.
9211         (f_type_print_base): Add print_rank parameter.
9212
9213 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * NEWS: Mention new MI commands.
9216         * break-catch-throw.c (enum exception_event_kind): Move to
9217         breakpoint.h.
9218         (print_mention_exception_catchpoint): Output text as a single
9219         message.
9220         (catch_exception_command_1): Rename to...
9221         (catch_exception_event): ...this, make non-static, update header
9222         command, and change some parameter types.
9223         (catch_catch_command): Update for changes to
9224         catch_exception_command_1.
9225         (catch_throw_command): Likewise.
9226         (catch_rethrow_command): Likewise.
9227         * breakpoint.c (enum exception_event_kind): Delete.
9228         * breakpoint.h (enum exception_event_kind): Moved here from
9229         break-catch-throw.c.
9230         (catch_exception_event): Declare.
9231         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9232         (mi_cmd_catch_throw): New function.
9233         (mi_cmd_catch_rethrow): New function.
9234         (mi_cmd_catch_catch): New function.
9235         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9236         'catch-catch' entries.
9237         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9238         (mi_cmd_catch_rethrow): Declare.
9239         (mi_cmd_catch_catch): Declare.
9240
9241 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * annotate.c (annotate_source_line): Change return type to void,
9244         update implementation to match.
9245         * annotate.h (annotate_source_line): Change return type to void,
9246         update header comment.
9247         * stack.c (print_frame_info): Don't change what frame information
9248         is printed based on whether annotations are on or not.
9249
9250 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9251
9252         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9253         (annotate_source): Make static.
9254         (annotate_source_line): Moved from source.c and renamed from
9255         identify_source_line.  Update the return type.
9256         * annotate.h (annotate_source): Delete declaration.
9257         (annotate_source_line): Declaration moved from source.h, and
9258         renamed from identify_source_line.  Return type updated.
9259         * source.c (identify_source_line): Moved to annotate.c and renamed
9260         to annotate_source_line.
9261         (info_line_command): Remove check of annotation_level.
9262         * source.h (identify_source_line): Move declaration to annotate.h
9263         and rename to annotate_source_line.
9264         * stack.c: Add 'annotate.h' include.
9265         (print_frame_info): Remove check of annotation_level before
9266         calling annotate_source_line.
9267
9268 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * source-cache.c (source_cache::get_plain_source_lines): Use
9271         open_source_file_with_line_charpos instead of just
9272         open_source_file, remove call to find_source_lines.
9273         (source_cache::get_source_lines): Likewise.
9274         * source.c (find_source_lines): Make static.
9275         (get_filename_and_charpos): Renamed into...
9276         (open_source_file_with_line_charpos): ..this along with changes to
9277         return a scoped_fd, and some other minor clean ups.
9278         (identify_source_line): Use open_source_file_with_line_charpos.
9279         (search_command_helper): Use open_source_file_with_line_charpos
9280         instead of just open_source_file, remove call to
9281         find_source_lines.
9282         * source.h (open_source_file_with_line_charpos): Declare new
9283         function.
9284         (find_source_lines): Delete declaration.
9285
9286 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * source.c (get_filename_and_charpos): Remove fullname
9289         parameter.
9290         (identify_source_line): Update call to get_filename_and_charpos.
9291
9292 2019-06-14  Tom Tromey  <tromey@adacore.com>
9293
9294         PR gdb/24502:
9295         * ui-style.h (skip_ansi_escape): Update comment.
9296         * ui-file.h (class no_terminal_escape_file): New class.
9297         * ui-file.c (no_terminal_escape_file::write)
9298         (no_terminal_escape_file::puts): New methods.
9299         * cli/cli-logging.c (handle_redirections): Use
9300         no_terminal_escape_file.
9301
9302 2019-06-14  Tom Tromey  <tromey@adacore.com>
9303
9304         * NEWS: Move convenience variable news above Python news.
9305
9306 2019-06-14  Tom Tromey  <tom@tromey.com>
9307
9308         * gnulib: Move directory to top-level.
9309         * configure.ac: Don't configure gnulib.
9310         * configure: Rebuild.
9311         * common/common-defs.h: Use new path to gnulib.
9312         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9313         (GNULIB_H): Remove.
9314         (INCGNU): Look in new gnulib location.
9315         (HFILES_NO_SRCDIR): Remove gnulib files.
9316         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9317         (generated_files): Remove GNULIB_H.
9318         ($(LIBGNU), all-lib): Remove targets.
9319         (distclean): Don't mention GNULIB_BUILDDIR.
9320         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9321
9322 2019-06-14  Tom Tromey  <tromey@adacore.com>
9323
9324         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9325         Warn if symbol file does not provide any symbols.
9326
9327 2019-06-14  Tom Tromey  <tromey@adacore.com>
9328
9329         * source.c (find_and_open_source): Respect basenames_may_differ.
9330
9331 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * annotate.c (annotate_breakpoints_invalid): Make use of
9334         scoped_restore_terminal_state.
9335         (annotate_frames_invalid): Likewise.
9336
9337 2019-06-14  Tom Tromey  <tromey@adacore.com>
9338
9339         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9340         allow assignment to an internalvar.
9341
9342 2019-06-14  Tom Tromey  <tromey@adacore.com>
9343
9344         * ada-lex.l: Allow "_" in attribute names.
9345
9346 2019-06-14  Tom Tromey  <tromey@adacore.com>
9347
9348         PR gdb/24653:
9349         * regcache.c (registers_changed): Don't call alloca.
9350         * top.c (execute_command): Don't call alloca.
9351
9352 2019-06-13  Pedro Alves  <palves@redhat.com>
9353
9354         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9355         'expression'.  When parsing an expression, error out if there's
9356         junk after "unlimited".
9357         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9358         (do_set_command): Adjust calls to is_unlimited_literal.
9359
9360 2019-06-13  Pedro Alves  <palves@redhat.com>
9361
9362         * compile/compile.c (make_compile_options_def_group): Add braces
9363         around array_view initializer.
9364         * thread.c (make_thread_apply_all_options_def_group)
9365         (make_thread_apply_all_options_def_group): Likewise.
9366
9367 2019-06-13  Pedro Alves  <palves@redhat.com>
9368
9369         * NEWS (New commands): Mention "maint test-options
9370         require-delimiter", "maint test-options unknown-is-error", "maint
9371         test-options unknown-is-operand" and "maint show
9372         test-options-completion-result".
9373         (New command options, command completion): New section.
9374         (Completion improvements): New section.
9375         Mention that you can abbreviate "unlimited".
9376
9377 2019-06-13  Pedro Alves  <palves@redhat.com>
9378
9379         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9380         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9381         * unittests/cli-utils-selftests.c (test_parse_flags)
9382         (test_parse_flags_qcs): Delete.
9383         (test_cli_utils): Don't call deleted functions.
9384
9385 2019-06-13  Pedro Alves  <palves@redhat.com>
9386
9387         * thread.c: Include "cli/cli-option.h".
9388         (tp_array_compar_ascending): Global.
9389         (tp_array_compar): Delete function.
9390         (tp_array_compar_ascending, tp_array_compar_descending): New
9391         functions.
9392         (ascending_option_def, qcs_flag_option_def)
9393         (thr_qcs_flags_option_defs)
9394         (make_thread_apply_all_options_def_group)
9395         (make_thread_apply_options_def_group): New.
9396         (thread_apply_all_command): Use gdb::option::process_options.
9397         (thread_apply_command_completer)
9398         (thread_apply_all_command_completer): New.
9399         (thread_apply_command): Use gdb::option::process_options.
9400         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9401         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9402         to generate help text of "thread apply".  Adjust "taas"'s help.
9403         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9404         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9405
9406 2019-06-13  Pedro Alves  <palves@redhat.com>
9407
9408         * thread.c (thread_apply_command): Check for invalid TID with
9409         isdigit instead of !isalpha.
9410
9411 2019-06-13  Pedro Alves  <palves@redhat.com>
9412
9413         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9414         (validate_flags_qcs): New.
9415         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9416         (validate_flags_qcs): Declare.
9417         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9418         (make_frame_apply_options_def_group): New.
9419         (frame_apply_command_count): Process options with
9420         gdb::option::process_options.
9421         (frame_apply_completer): New.
9422         (frame_apply_level_completer, frame_apply_all_completer)
9423         (frame_apply_completer): New.
9424         (_initialize_stack): Update help of "frame apply", "frame apply
9425         level", "frame apply all" and "faas" to mention supported options
9426         and install command completers.
9427         * stack.h (frame_apply_all_completer): Declare.
9428         * thread.c: Include "stack.h".
9429         (tfaas_command): Add "--".
9430         (_initialize_thread): Update help "tfaas" to mention supported
9431         options and install command completer.
9432
9433 2019-06-13  Pedro Alves  <palves@redhat.com>
9434
9435         * completer.c (complete_nested_command_line): New.
9436         (gdb_completion_word_break_characters_throw): Add assertion.
9437         * completer.h (complete_nested_command_line): Declare.
9438
9439 2019-06-13  Pedro Alves  <palves@redhat.com>
9440
9441         * stack.c (parse_backtrace_qualifiers): New.
9442         (backtrace_command): Use it.
9443         (backtrace_command_completer): Complete on qualifiers.
9444
9445 2019-06-13  Pedro Alves  <palves@redhat.com>
9446
9447         * frame.c: Include "cli/cli-option.h.
9448         (user_set_backtrace_options): New.
9449         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9450         Delete.
9451         (get_prev_frame): Adjust.
9452         (boolean_option_def, uinteger_option_def)
9453         (set_backtrace_option_defs): New.
9454         (_initialize_frame): Adjust and use
9455         gdb::option::add_setshow_cmds_for_options to install "set
9456         backtrace past-main" and "set backtrace past-entry".
9457         * frame.h: Include "cli/cli-option.h".
9458         (struct frame_print_options): Forward declare.
9459         (print_frame_arguments_all, print_frame_arguments_scalars)
9460         (print_frame_arguments_none): Declare.
9461         (print_entry_values): Delete declaration.
9462         (struct frame_print_options, user_frame_print_options): New.
9463         (struct set_backtrace_options): New.
9464         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9465         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9466         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9467         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9468         (list_args_or_locals): Add frame_print_options parameter.
9469         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9470         * python/py-framefilter.c (enumerate_args): Pass down
9471         USER_FRAME_PRINT_OPTIONS.
9472         * stack.c: Include "cli/cli-option.h".
9473         (print_frame_arguments_all, print_frame_arguments_scalars)
9474         (print_frame_arguments_none): Declare.
9475         (print_raw_frame_arguments, print_entry_values): Delete.
9476         (user_frame_print_options): New.
9477         (boolean_option_def, enum_option_def, frame_print_option_defs):
9478         New.
9479         (struct backtrace_cmd_options): New.
9480         (bt_flag_option_def): New.
9481         (backtrace_command_option_defs): New.
9482         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9483         (print_frame_arg, read_frame_arg, print_frame_args)
9484         (print_frame_info, print_frame): Add frame_print_options parameter
9485         and use it.
9486         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9487         (backtrace_command_1): Add frame_print_options and
9488         backtrace_cmd_options parameters and use them.
9489         (make_backtrace_options_def_group): New.
9490         (backtrace_command): Process command options with
9491         gdb::option::process_options.
9492         (backtrace_command_completer): New.
9493         (_initialize_stack): Extend "backtrace"'s help to mention
9494         supported options.  Install completer for "backtrace".
9495         Install some settings commands with add_setshow_cmds_for_options.
9496
9497 2019-06-13  Pedro Alves  <palves@redhat.com>
9498
9499         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9500         and that "set/show print raw frame-arguments" are now deprecated.
9501
9502         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9503         command.
9504         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9505         * stack.c (_initialize_stack): Install "set/show print
9506         raw-frame-arguments", and deprecate "set/show print raw
9507         frame-arguments".
9508         * valprint.c (_initialize_valprint): Deprecate "set/show print
9509         raw".
9510
9511 2019-06-13  Pedro Alves  <palves@redhat.com>
9512
9513         * compile/compile.c (struct compile_options): New.
9514         (compile_flag_option_def, compile_command_option_defs)
9515         (make_compile_options_def_group): New.
9516         (compile_file_command): Handle options with
9517         gdb::option::process_options.
9518         (compile_file_command_completer): New function.
9519         (compile_code_command): Handle options with
9520         gdb::option::process_options.
9521         (compile_code_command_completer): New function.
9522         (_initialize_compiler): Install completers for "compile code" and
9523         "compile file".  Mention available options in "compile code" and
9524         "compile code"'s help.
9525         * completer.c (advance_to_completion_word): New, factored out from
9526         ...
9527         (advance_to_expression_complete_word_point): ... this.
9528         (advance_to_filename_complete_word_point): New.
9529         * completer.h (advance_to_filename_complete_word_point): New
9530         declaration.
9531
9532 2019-06-13  Pedro Alves  <palves@redhat.com>
9533
9534         * compile/compile.c: Include "cli/cli-option.h".
9535         (compile_print_value): Scope data pointer is now a
9536         value_print_options pointer; adjust.
9537         (compile_print_command): Process options.  Scope data pointer is
9538         now a value_print_options pointer; adjust.
9539         (_initialize_compile): Update "compile print"'s help to include
9540         supported options.  Install a completer for "compile print".
9541         * cp-valprint.c (show_vtblprint, show_objectprint)
9542         (show_static_field_print): Delete.
9543         (_initialize_cp_valprint): Don't install "set print
9544         static-members", "set print vtbl", "set print object" here.
9545         * printcmd.c: Include "cli/cli-option.h" and
9546         "common/gdb_optional.h".
9547         (print_command_parse_format): Rework to fill in a
9548         value_print_options instead of a format_data.
9549         (print_value): Change parameter type from format_data pointer to
9550         value_print_options reference.  Adjust.
9551         (print_command_1): Process options.  Adjust to pass down a
9552         value_print_options.
9553         (print_command_completer): New.
9554         (_initialize_printcmd): Install print_command_completer as
9555         handle_brkchars completer for the "print" command.  Update
9556         "print"'s help to include supported options.
9557         * valprint.c: Include "cli/cli-option.h".
9558         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9559         here from cp-valprint.c.
9560         (boolean_option_def, uinteger_option_def)
9561         (value_print_option_defs, make_value_print_options_def_group):
9562         New.  Use gdb::option::add_setshow_cmds_for_options to install
9563         "set print elements", "set print null-stop", "set print repeats",
9564         "set print pretty", "set print union", "set print array", "set
9565         print address", "set print symbol", "set print array-indexes".
9566         * valprint.h: Include <string> and "cli/cli-option.h".
9567         (make_value_print_options_def_group): Declare.
9568         (print_value): Change parameter type from format_data pointer to
9569         value_print_options reference.
9570         (print_command_completer): Declare.
9571
9572 2019-06-13  Pedro Alves  <palves@redhat.com>
9573
9574         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9575         (COMMON_SFILES): Add maint-test-settings.c.
9576         * cli/cli-decode.c (boolean_enums): New global, factored out from
9577         ...
9578         (add_setshow_boolean_cmd): ... here.
9579         * cli/cli-decode.h (boolean_enums): Declare.
9580         * cli/cli-option.c: New file.
9581         * cli/cli-option.h: New file.
9582         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9583         factored out from ...
9584         (parse_cli_boolean_value(const char *)): ... this.
9585         (is_unlimited_literal): Change parameter type to pointer to
9586         pointer.  Adjust and advance ARG pointer.
9587         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9588         (parse_cli_var_enum): New, factored out from ...
9589         (do_set_command): ... this.  Adjust.
9590         * cli/cli-setshow.h (parse_cli_boolean_value)
9591         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9592         (parse_cli_var_enum): Declare.
9593         * cli/cli-utils.c: Include "cli/cli-option.h".
9594         (get_ulongest): New.
9595         * cli/cli-utils.h (get_ulongest): Declare.
9596         (check_for_argument): New overloads.
9597         * maint-test-options.c: New file.
9598
9599 2019-06-13  Pedro Alves  <palves@redhat.com>
9600
9601         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9602         parse a range if "-" is at the end of the string.
9603
9604 2019-06-13  Pedro Alves  <palves@redhat.com>
9605
9606         * cli/cli-setshow.c (parse_auto_binary_operation)
9607         (parse_cli_boolean_value): Don't allow "o".
9608
9609 2019-06-13  Pedro Alves  <palves@redhat.com>
9610
9611         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9612         * NEWS: Mention maint test-settings KIND.
9613         * maint-test-settings.c: New file.
9614
9615 2019-06-13  Pedro Alves  <palves@redhat.com>
9616
9617         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9618         completer.
9619         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9620         "set" completers.
9621
9622 2019-06-13  Pedro Alves  <palves@redhat.com>
9623
9624         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9625         after item.
9626
9627 2019-06-13  Pedro Alves  <palves@redhat.com>
9628
9629         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9630
9631 2019-06-13  Pedro Alves <palves@redhat.com>
9632
9633         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9634         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9635         call.
9636         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9637         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9638         calls.
9639         (check_for_argument): Skip spaces after argument.
9640
9641 2019-06-13  Pedro Alves  <palves@redhat.com>
9642
9643         * thread.c (thread_apply_command): Adjust TID parsing.
9644         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9645         detected before end of string.
9646         (tid_is_in_list): Error out if LIST is invalid.
9647
9648 2019-06-13  Pedro Alves  <palves@redhat.com>
9649
9650         * completer.c (complete_line_internal_1): Rewind completion word
9651         point.
9652         (completion_tracker::advance_custom_word_point_by): Change
9653         parameter type to int.
9654         * completer.h (completion_tracker::advance_custom_word_point_by):
9655         Likewise.
9656
9657 2019-06-13  Pedro Alves  <palves@redhat.com>
9658
9659         * completer.c (advance_to_completion_word): Handle delimiters.
9660
9661 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9662
9663         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9664
9665 2019-06-11  Tom Tromey  <tom@tromey.com>
9666
9667         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9668         (xmalloc_failed): Move to alloc.c.
9669         * alloc.c: New file.
9670         * Makefile.in (COMMON_SFILES): Add alloc.c.
9671
9672 2019-06-11  Tom Tromey  <tom@tromey.com>
9673
9674         * nat/linux-waitpid.c: Don't include server.h.
9675         (linux_debug): Remove.
9676         (my_waitpid): Update.
9677
9678 2019-06-11  Tom Tromey  <tromey@adacore.com>
9679
9680         * infcall.c (_initialize_infcall): Remove trailing newline from
9681         help.
9682         * user-regs.c (_initialize_user_regs): Remove trailing newline
9683         from help.
9684         * typeprint.c (_initialize_typeprint): Remove trailing newline
9685         from help.
9686         * reverse.c (_initialize_reverse): Remove trailing newlines from
9687         help.
9688         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9689         from help.
9690         * language.c (add_set_language_command): Remove trailing newline
9691         from help.
9692         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9693         help.
9694         * disasm.c (_initialize_disasm): Remove trailing newline from
9695         help.
9696         * top.c (init_main): Remove trailing newline from help.
9697         * interps.c (_initialize_interpreter): Remove trailing newline
9698         from help.
9699         * btrace.c (_initialize_btrace): Remove trailing newlines from
9700         help.
9701         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9702         from help.
9703         * python/python.c (_initialize_python): Remove trailing newline
9704         from help.
9705         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9706         help.
9707         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9708         from help.  Reformat some text.
9709         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9710         from help.
9711         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9712         newline from help.
9713
9714 2019-06-11  Tom Tromey  <tromey@adacore.com>
9715
9716         * darwin-nat.c (darwin_decode_exception_message)
9717         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9718
9719 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9720
9721         * valops.c (value_slice): Check for not allocated or not
9722         associated values.
9723
9724 2019-06-10  Tom de Vries  <tdevries@suse.de>
9725
9726         PR gdb/24618
9727         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9728         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9729         invalid.
9730
9731 2019-06-10  Tom de Vries  <tdevries@suse.de>
9732
9733         PR gdb/24611
9734         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9735         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9736
9737 2019-06-10  Tom de Vries  <tdevries@suse.de>
9738
9739         PR symtab/24545
9740         * symtab.c (struct demangled_name_entry): Add language field.
9741         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9742         static minimal symbol".  Set and use language field.
9743
9744 2019-06-10  Tom Tromey  <tromey@adacore.com>
9745
9746         * ada-lang.c (_initialize_ada_language): Update help text.
9747
9748 2019-06-10  Tom Tromey  <tromey@adacore.com>
9749
9750         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9751         with a newline.
9752         * guile/guile.c (handle_boot_error): Don't end warning with a
9753         newline.
9754         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9755         warning with a newline.
9756         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9757         newline.
9758         (s12z_frame_cache): Likewise.
9759         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9760         a newline.
9761         * solib-svr4.c (disable_probes_interface): Don't end warning with
9762         a newline.
9763         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9764         newline.
9765         * python/python.c (do_finish_initialization): Don't end warning
9766         with a newline.
9767
9768 2019-06-10  Tom Tromey  <tom@tromey.com>
9769
9770         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9771         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9772         gdbpy_enter.
9773
9774 2019-06-10  Tom Tromey  <tromey@adacore.com>
9775
9776         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9777         data.
9778         (elf_new_init): Don't call stabsread_new_init.
9779         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9780         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9781         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9782
9783 2019-06-10  Tom de Vries  <tdevries@suse.de>
9784
9785         PR symtab/16264
9786         PR symtab/24517
9787         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9788
9789 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9790
9791         * source.c (find_and_open_source): Also rewrite relative file
9792         names.
9793
9794 2019-04-26  Amos Bird  <amosbird@gmail.com>
9795
9796         * annotate.c (annotate_thread_exited): Add "thread-exited"
9797         annotation.
9798
9799 2019-06-06  Tom Tromey  <tromey@adacore.com>
9800
9801         * maint.h (class scoped_command_stats): Use
9802         DISABLE_COPY_AND_ASSIGN.
9803         <print_time>: New method.
9804         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9805         print_time.
9806         (scoped_command_stats::print_time): New method.
9807
9808 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9809
9810         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9811         instructions of lengths 6 or 8 bytes.
9812
9813 2019-06-04  Pedro Alves  <palves@redhat.com>
9814
9815         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9816
9817         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9818         * breakpoint.c (condition_completer): Likewise.
9819         * cli/cli-dump.c (scan_expression): Likewise.
9820         * common/filestuff.c (mkdir_recursive): Likewise.
9821         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9822         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9823         (gdb_abspath): Likewise.
9824         * compile/compile-cplus-types.c
9825         (compile_cplus_instance::decl_name): Likewise.
9826         * completer.c (complete_explicit_location):
9827         (signal_completer, reg_or_group_completer_1): Likewise.
9828         * cp-support.c (cp_remove_params_if_any): Likewise.
9829         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9830         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9831         * infcmd.c (strip_bg_char): Likewise.
9832         * linespec.c (copy_token_string): Likewise.
9833         * mi/mi-main.c (output_cores): Likewise.
9834         * psymtab.c (psymtab_search_name):
9835         * symfile.c (test_set_ext_lang_command): Likewise.
9836         * target.c (target_fileio_read_stralloc): Likewise.
9837         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9838         * value.c (complete_internalvar): Likewise.
9839
9840 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9841
9842         Add objfile property to gdb.Type.
9843         * NEWS: Mention Python API addition.
9844         * python/py-type.c (typy_get_objfile): New method.
9845
9846 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847
9848         * NEWS: Mention the new set|show style [title|highlight].
9849         Mention changes to "show style", "help" and "apropos".
9850
9851 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9852
9853         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9854         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9855         instead of print_help_for_command.
9856         (print_doc_of_command): New function.
9857         (help_list): Add 'apropos -v word' suggestion.
9858         (print_help_for_command): Style the command name using title style.
9859         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9860         (_initialize_cli_cmds): Describe -v in apropos_command help.
9861
9862 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9863
9864         * cli/cli-style.h (cli_style_option): Add name in constructor,
9865         add m_name class member, add constructor with intensity,
9866         add name class function.
9867         (cli_style_option::add_setshow_commands): Remove name argument.
9868         (highlight_style, title_style): New styles.
9869         * cli/cli-style.c (do_show): New function that shows a style
9870         characteristic styling the style name with itself.
9871         (set_style_name): New function.
9872         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9873         Update all callers according to the changes in cli/cli-style.h.
9874         * utils.h (fputs_highlighted): New function.
9875         * utils.c (fputs_highlighted): Likewise.
9876
9877 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9878
9879         * NEWS: Mention new pipe command and new convenience variables.
9880
9881 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9882
9883         * cli/cli-cmds.c (pipe_command): New function.
9884         (_initialize_cli_cmds): Call add_com for pipe_command.
9885         Define | as an alias for pipe.
9886         (exit_status_set_internal_vars): New function.
9887         (shell_escape): Call exit_status_set_internal_vars.
9888         cli/cli-decode.c (find_command_name_length): Recognize | as
9889         a single character command.
9890
9891 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9892
9893         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9894         top.c (execute_command_to_ui_file): New function, mostly a copy
9895         of execute_command_to_string.
9896         (execute_command_to_string): Implement by calling
9897         execute_command_to_ui_file.
9898
9899 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9900
9901         * top.h (saved_command_line): Remove declaration.
9902         * top.c (previous_saved_command_line, previous_repeat_arguments):
9903         New variables.
9904         (saved_command_line): Make static, define together with other
9905         'repeat variables'.
9906         (dont_repeat): Clear repeat_arguments.
9907         (repeat_previous, get_saved_command_line, save_command_line):
9908         New functions.
9909         (gdb_init): Initialize saved_command_line
9910         and previous_saved_command_line.
9911         * main.c (captured_main_1): Remove saved_command_line initialization.
9912         * event-top.c (handle_line_of_input): Update to use
9913         the new 'repeat' related functions instead of direct access to
9914         saved_command_line.
9915         * command.h (repeat_previous, get_saved_command_line,
9916         save_command_line): New declarations.
9917         (dont_repeat): Add comment.
9918
9919 2019-05-30  Tom Tromey  <tromey@adacore.com>
9920
9921         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9922         Fix comment.
9923         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9924
9925 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9926
9927         PR cli/24587
9928         * completer.c (complete): Initialize variable word.
9929
9930 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9931
9932         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9933         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9934         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9935         'body' is NULL to the outter 'if', protecting the '!is_define'
9936         situation as well.
9937
9938 2019-05-29  Tom Tromey  <tromey@adacore.com>
9939
9940         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9941         (dwarf_unknown): New function.
9942         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9943         (dwarf_type_encoding_name): Use dwarf_unknown.
9944
9945 2019-05-29  Tom Tromey  <tromey@adacore.com>
9946
9947         PR c++/20020:
9948         * cp-valprint.c (cp_print_value_fields): Call
9949         cp_print_static_field inside "try".
9950
9951 2019-05-29  Tom Tromey  <tromey@adacore.com>
9952
9953         * inflow.c (struct terminal_info): Add default operator=.
9954         * configure: Rebuild.
9955         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9956         -Wdeprecated-copy-dtor, -Wredundant-move.
9957
9958 2019-05-29  Tom Tromey  <tromey@adacore.com>
9959
9960         * NEWS: Add entry.
9961         * infcmd.c (print_return_value_1): Handle finish_print
9962         option.
9963         (show_print_finish): New function.
9964         (_initialize_infcmd): Add "set/show print finish" commands.
9965         * valprint.c (user_print_options): Initialize new member.
9966         * valprint.h (struct value_print_options) <finish_print>: New
9967         member.
9968
9969 2019-05-28  Tom Tromey  <tromey@adacore.com>
9970
9971         * ada-lang.c (ada_remove_Xbn_suffix)
9972         (find_old_style_renaming_symbol)
9973         (parse_old_style_renaming): Remove.
9974         (ada_find_renaming_symbol): Don't call
9975         find_old_style_renaming_symbol.
9976         (ada_is_renaming_symbol): Rename from
9977         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9978         bool.  Now static.
9979         (ada_read_var_value): Update and simplify.
9980         * ada-exp.y (write_var_or_type): Remove old code.
9981
9982 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9983
9984         PR gdb/25010
9985         * event-top.c: Remove include comment.
9986         * inflow.c (class scoped_ignore_sigttou): Move from here...
9987         * inflow.h (class scoped_ignore_sigttou): ...to here.
9988         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9989         * top.c:  Remove include comment.
9990
9991 2019-05-27  Tom Tromey  <tom@tromey.com>
9992
9993         * NEWS: Fix typo.
9994
9995 2019-05-22  Tom Tromey  <tromey@adacore.com>
9996
9997         * target.c (target_follow_exec): Constify parameter.
9998         * target-delegates.c: Rebuild.
9999         * remote.c (remote_target::follow_exec): Constify parameter.
10000         * infrun.c (follow_exec): Constify parameter.
10001         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10002         (target_follow_exec): Likewise.
10003
10004 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10005
10006         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10007         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10008
10009 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10010
10011         * NEWS: Add debugredirect and testsuite sections.
10012
10013 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10014
10015         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10016         target descriptions using exclusively floating point register name
10017         aliases.
10018
10019 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10020
10021         PR gdb/18644:
10022         * f-lang.c (build_fortran_types): Handle the case where
10023         gdbarch_floatformat_for_type returns a nullptr.
10024
10025 2019-05-21  Tom de Vries  <tdevries@suse.de>
10026
10027         PR cli/24587
10028         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10029
10030 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10031
10032         PR gdb/18644:
10033         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10034         16-byte floats.
10035         * i386-tdep.c (i386_floatformat_for_type): Use
10036         floatformats_ia64_quad for the 16-byte floating point component
10037         within a fortran 32-byte complex number.
10038
10039 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10040
10041         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10042         delete default constructor.
10043         (find_partial_die): Update to return const struct.
10044         (partial_die_parent_scope): Move variable declaration into scope
10045         of its use and change its type to auto.
10046         (guess_partial_die_structure_name): Likewise.
10047         (partial_die_info::fixup): Likewise.
10048
10049 2019-05-17  Tom Tromey  <tromey@adacore.com>
10050
10051         * source.c (find_and_open_source): Remove cast.
10052
10053 2019-05-17  Tom Tromey  <tromey@adacore.com>
10054
10055         * annotate.c (annotate_source): Make "filename" const.
10056         * annotate.h (annotate_source): Use const.
10057
10058 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10059
10060         * disasm.c (set_disassembler_options): Send errors to stderr.
10061
10062 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10063
10064         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10065         (cli_interp_base::set_logging): Check debug_redirect.
10066         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10067         * cli/cli-logging.c (debug_redirect): Add static variable.
10068         (pop_output_files): Add default param.
10069         (handle_redirections): Print debug setting.
10070         (show_logging_command): Likewise.
10071         (_initialize_cli_logging): Add debugredirect command.
10072         * interps.c (current_interp_set_logging): Add debug_redirect
10073         parameter.
10074         * interps.h (set_logging): Add debug_redirect parameter.
10075         (current_interp_set_logging): Likewise.
10076         * mi/mi-common.h: Likewise.
10077         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10078
10079 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10080             Tom Tromey  <tromey@adacore.com>
10081
10082         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10083         directly.
10084         * cli/cli-interp.h (make_logging_output): Remove declaration.
10085         * cli/cli-logging.c (make_logging_output): Remove function.
10086         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10087         directly.
10088         * ui-file.c (tee_file::tee_file): Remove bools.
10089         (tee_file::~tee_file): Remove deletes.
10090         * ui-file.h (tee_file): Remove bools.
10091
10092 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10093
10094         * mi/mi-cmds.h (mi_cmd_complete): New function.
10095         * mi/mi-main.c (mi_cmd_complete): Likewise.
10096         * mi/mi-cmds.c: Define new MI command -complete.
10097         * NEWS: Mention new -complete command.
10098
10099 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10100
10101         * completer.h (complete): New function.
10102         * completer.c (complete): Likewise.
10103         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10104         function defined in completer.h.
10105
10106 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10107
10108         * MAINTAINERS (Write After Approval): Add myself.
10109
10110 2019-05-17  Tom de Vries  <tdevries@suse.de>
10111
10112         PR gdb/24094
10113         * dwarf2read.c (struct cu_partial_die_info): New struct.
10114         (find_partial_die): Return cu_partial_die_info.
10115         (partial_die_parent_scope, guess_partial_die_structure_name)
10116         (partial_die_info::fixup): Handle new return type of find_partial_die.
10117
10118 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10119
10120         PR breakpoints/24541
10121         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10122         "std::string", simplifying the algorithm.
10123
10124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10125
10126         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10127         (stap_static_probe_ops::get_probes): Likewise.
10128
10129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10130
10131         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10132         '-')" and "else if".
10133         (stap_parse_single_operand): Join checks for
10134         "gdbarch_stap_parse_special_token_p" and
10135         "gdbarch_stap_parse_special_token" in the same "if" statement.
10136         Invert check when verifying for operation on register
10137         displacement.
10138
10139 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10140
10141         * stap-probe.c (stap_get_opcode): Update comment.
10142         (stap_get_expected_argument_type): Likewise.
10143         (handle_stap_probe): Likewise.
10144
10145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10146
10147         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10148         return type to 'bool'.  Adjust comment.  Use 'bool' when
10149         appropriate.
10150         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10151         * stap-probe.c (stap_parse_argument_1): Likewise.
10152         (stap_is_operator): Likewise.
10153         (stap_is_generic_prefix): Likewise.
10154         (stap_is_register_prefix): Likewise.
10155         (stap_is_register_indirection_prefix): Likewise.
10156         (stap_is_integer_prefix): Likewise.
10157         (stap_generic_check_suffix): Likewise.
10158         (stap_check_integer_suffix): Likewise.
10159         (stap_check_register_suffix): Likewise.
10160         (stap_check_register_indirection_suffix): Likewise.
10161         (stap_parse_register_operand): Likewise.
10162         (stap_parse_single_operand): Likewise.
10163         (stap_parse_argument_1): Likewise.
10164         (stap_probe::get_argument_count): Likewise.
10165         (stap_is_operator): Likewise.
10166
10167 2019-05-16  Tom Tromey  <tromey@adacore.com>
10168
10169         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10170         keyword to foreach.
10171
10172 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10173
10174         * linux-thread-db.c (try_thread_db_load_1): Change return type
10175         to bool.
10176         (try_thread_db_load): Likewise.
10177         (try_thread_db_load_from_pdir_1): Likewise.
10178         (try_thread_db_load_from_pdir): Likewise.
10179         (try_thread_db_load_from_sdir): Likewise.
10180         (try_thread_db_load_from_dir): Likewise.
10181         (thread_db_load_search): Likewise.
10182         (has_libpthread): Likewise.
10183         (thread_db_load): Likewise.
10184
10185 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10186
10187         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10188         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10189         NULL, and complain/return if that's the case.
10190
10191 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10192
10193         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10194         (advance, posn, abstract_read_memory): New functions.
10195         [struct mem_read_abstraction]: New struct.
10196         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10197
10198 2019-05-14  Tom Tromey  <tromey@adacore.com>
10199
10200         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10201         value is not lval_memory.
10202
10203 2019-05-14  Tom Tromey  <tromey@adacore.com>
10204
10205         * solib.c (info_sharedlibrary_command): Style the file name.
10206
10207 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10208
10209         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10210         (aarch64_vnv_type): Likewise.
10211         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10212         * common/tdesc.c: Likewise.
10213         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10214         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10215         * features/aarch64-fpu.xml: Add ieee half view.
10216         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10217         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10218         * gdbtypes.h (struct builtin_type): Likewise.
10219         (struct objfile_type): Likewise.
10220
10221 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10222
10223         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10224         typo.
10225         * location.h (string_to_event_location): Likewise.
10226
10227 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10228
10229         GDB 8.3 released.
10230
10231 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10232
10233         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10234         New variable declaration.
10235         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10236         New variable.
10237         (print_one_breakpoint): Use ui_out::test_flags and new global
10238         variable to compute use_fixed_output.
10239         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10240         Remove.
10241         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10242         (mi_multi_location_breakpoint_output_fixed): Remove.
10243         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10244         new variable.
10245         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10246         fix_multi_location_breakpoint_output flag if version >= 3.
10247         * ui-out.h (enum ui_out_flag)
10248         <fix_multi_location_breakpoint_output>: New enumerator.
10249
10250 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10251
10252         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10253
10254 2019-05-10  Tom Tromey  <tromey@adacore.com>
10255
10256         * ada-lang.c (catch_ada_completer): New function.
10257         (_initialize_ada_language): Use it.
10258
10259 2019-05-10  Tom Tromey  <tromey@adacore.com>
10260
10261         * thread.c (print_thread_info): Make "requested_threads" const.
10262         * gdbthread.h (print_thread_info): Make "requested_threads"
10263         const.
10264         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10265         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10266
10267 2019-05-08  Tom Tromey  <tom@tromey.com>
10268
10269         * gdbtypes.c (objfile_type_data): Change type.
10270         (objfile_type, _initialize_gdbtypes): Update.
10271
10272 2019-05-08  Tom Tromey  <tom@tromey.com>
10273
10274         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10275         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10276         (_initialize_dwarf2_frame): Update.
10277
10278 2019-05-08  Tom Tromey  <tom@tromey.com>
10279
10280         * objc-lang.c (objc_objfile_data): Change type.
10281         (find_methods): Update.
10282         (_initialize_objc_lang): Remove.
10283
10284 2019-05-08  Tom Tromey  <tom@tromey.com>
10285
10286         * stabsread.c (rs6000_builtin_type_data): Change type.
10287         (rs6000_builtin_type, _initialize_stabsread): Update.
10288
10289 2019-05-08  Tom Tromey  <tom@tromey.com>
10290
10291         * mips-tdep.c (mips_pdr_data): Remove.
10292         (_initialize_mips_tdep): Update.
10293
10294 2019-05-08  Tom Tromey  <tom@tromey.com>
10295
10296         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10297         (hppa_init_objfile_priv_data, read_unwind_info)
10298         (find_unwind_entry, _initialize_hppa_tdep): Update.
10299
10300 2019-05-08  Tom Tromey  <tom@tromey.com>
10301
10302         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10303         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10304         on obstack.
10305         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10306
10307 2019-05-08  Tom Tromey  <tom@tromey.com>
10308
10309         * mdebugread.c (basic_type_data): Change type.
10310         (basic_type, _initialize_mdebugread): Update.
10311
10312 2019-05-08  Tom Tromey  <tom@tromey.com>
10313
10314         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10315
10316 2019-05-08  Tom Tromey  <tom@tromey.com>
10317
10318         * nto-tdep.c (nto_inferior_data_reg): Change type.
10319         (nto_inferior_data): Update.
10320         (nto_inferior_data_cleanup, nto_new_inferior_data)
10321         (_initialize_nto_tdep): Remove.
10322         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10323
10324 2019-05-08  Tom Tromey  <tom@tromey.com>
10325
10326         * ada-lang.c (struct ada_inferior_data): Add initializers.
10327         (ada_inferior_data): Change type.
10328         (ada_inferior_data_cleanup): Remove.
10329         (get_ada_inferior_data, ada_inferior_exit)
10330         (struct ada_pspace_data): Add initializers, destructor.
10331         (ada_pspace_data_handle): Change type.
10332         (get_ada_pspace_data): Update.
10333         (ada_pspace_data_cleanup): Remove.
10334
10335 2019-05-08  Tom Tromey  <tom@tromey.com>
10336
10337         * coffread.c (struct coff_symfile_info): Add initializers.
10338         (coff_objfile_data_key): Move lower.  Change type.
10339         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10340         Update.
10341         (coff_free_info): Remove.
10342
10343 2019-05-08  Tom Tromey  <tom@tromey.com>
10344
10345         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10346         (fbsd_pspace_data_handle): Move lower.  Change type.
10347         (get_fbsd_pspace_data): Update.
10348         (fbsd_pspace_data_cleanup): Remove.
10349         (_initialize_fbsd_tdep): Update.
10350
10351 2019-05-08  Tom Tromey  <tom@tromey.com>
10352
10353         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10354         (get_ada_tasks_pspace_data): Update.
10355         (ada_tasks_pspace_data_cleanup): Remove.
10356         (_initialize_tasks): Update.
10357         (ada_tasks_inferior_data_handle): Change type.
10358         (get_ada_tasks_inferior_data): Update.
10359         (ada_tasks_inferior_data_cleanup): Remove.
10360         (struct ada_tasks_pspace_data): Add initializers.
10361
10362 2019-05-08  Tom Tromey  <tom@tromey.com>
10363
10364         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10365         * symfile-debug.c (debug_sym_get_probes): Change type.
10366         * stap-probe.c (handle_stap_probe):
10367         (stap_static_probe_ops::get_probes): Change type.
10368         * probe.h (class static_probe_ops) <get_probes>: Change type.
10369         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10370         (parse_probes_in_pspace): Update.
10371         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10372         Update.
10373         (any_static_probe_ops::get_probes): Change type.
10374         * elfread.c (elfread_data): New typedef.
10375         (probe_key): Change type.
10376         (elf_get_probes): Likewise.  Update.
10377         (probe_key_free): Remove.
10378         (_initialize_elfread): Update.
10379         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10380         Change type.
10381         (dtrace_process_dof_probe, dtrace_process_dof)
10382         (dtrace_static_probe_ops::get_probe): Change type.
10383
10384 2019-05-08  Tom Tromey  <tom@tromey.com>
10385
10386         * xcoffread.c (struct xcoff_symfile_info): Rename from
10387         coff_symfile_info.  Add initializers.
10388         (xcoff_objfile_data_key): Move lower.  Change type.
10389         (XCOFF_DATA): Rewrite.
10390         (xcoff_free_info): Remove.
10391         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10392         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10393         (xcoff_initial_scan): Update.
10394
10395 2019-05-08  Tom Tromey  <tom@tromey.com>
10396
10397         * solib-svr4.c (struct svr4_info): Add initializers and
10398         destructor.
10399         <probes_table>: Now an htab_up.
10400         (solib_svr4_pspace_data): Change type.
10401         (free_probes_table): Simplify.
10402         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10403         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10404         (probes_table_remove_objfile_probes, register_solib_event_probe)
10405         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10406         (_initialize_svr4_solib): Update.
10407
10408 2019-05-08  Tom Tromey  <tom@tromey.com>
10409
10410         * remote.c (remote_pspace_data): Change type.
10411         (remote_pspace_data_cleanup): Remove.
10412         (get_remote_exec_file, set_pspace_remote_exec_file)
10413         (_initialize_remote): Update.
10414
10415 2019-05-08  Tom Tromey  <tom@tromey.com>
10416
10417         * breakpoint.c (breakpoint_objfile_key): Change type.
10418         (get_breakpoint_objfile_data): Update.
10419         (free_breakpoint_objfile_data): Remove.
10420         (_initialize_breakpoint): Update.
10421
10422 2019-05-08  Tom Tromey  <tom@tromey.com>
10423
10424         * linux-tdep.c (struct linux_info): Add initializers.
10425         (linux_inferior_data): Move.  Change type.
10426         (invalidate_linux_cache_inf): Update.
10427         (linux_inferior_data_cleanup): Remove.
10428         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10429
10430 2019-05-08  Tom Tromey  <tom@tromey.com>
10431
10432         * auxv.c (auxv_inferior_data): Move.  Change type.
10433         (auxv_inferior_data_cleanup): Remove.
10434         (invalidate_auxv_cache_inf): Rewrite.
10435         (get_auxv_inferior_data, _initialize_auxv): Update.
10436
10437 2019-05-08  Tom Tromey  <tom@tromey.com>
10438
10439         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10440         (symfile_debug_objfile_data_key): Change type.
10441         (symfile_debug_installed, debug_qf_has_symbols)
10442         (debug_qf_find_last_source_symtab)
10443         (debug_qf_forget_cached_source_info)
10444         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10445         (debug_qf_print_stats, debug_qf_dump)
10446         (debug_qf_expand_symtabs_for_function)
10447         (debug_qf_expand_all_symtabs)
10448         (debug_qf_expand_symtabs_with_fullname)
10449         (debug_qf_map_matching_symbols)
10450         (debug_qf_expand_symtabs_matching)
10451         (debug_qf_find_pc_sect_compunit_symtab)
10452         (debug_qf_map_symbol_filenames)
10453         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10454         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10455         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10456         (debug_sym_read_linetable, debug_sym_relocate): Update.
10457         (symfile_debug_free_objfile): Remove.
10458         (install_symfile_debug_logging, _initialize_symfile_debug):
10459         Update.
10460
10461 2019-05-08  Tom Tromey  <tom@tromey.com>
10462
10463         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10464         allocate_on_obstack.
10465         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10466         (get_dwarf2_per_objfile): Update.
10467         (set_dwarf2_per_objfile): Remove.
10468         (dwarf2_has_info, dwarf2_get_section_info): Update.
10469         (dwarf2_free_objfile): Remove.
10470         (_initialize_dwarf2_read): Update.
10471
10472 2019-05-08  Tom Tromey  <tom@tromey.com>
10473
10474         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10475         initializers.
10476         <unsupported_script_warning_printed,
10477         script_not_found_warning_printed>: Now bool.
10478         (auto_load_pspace_data): Change type.
10479         (~auto_load_pspace_info): Rename from
10480         auto_load_pspace_data_cleanup.
10481         (get_auto_load_pspace_data, init_loaded_scripts_info)
10482         (clear_section_scripts, maybe_print_unsupported_script_warning)
10483         (maybe_print_script_not_found_warning, _initialize_auto_load):
10484         Update.
10485
10486 2019-05-08  Tom Tromey  <tom@tromey.com>
10487
10488         * objfiles.c (objfile_pspace_info): Add destructor and
10489         initializers.
10490         (objfiles_pspace_data): Change type.
10491         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10492         (get_objfile_pspace_data): Update.
10493         (objfiles_bfd_data): Change type.
10494         (get_objfile_bfd_data): Update.
10495         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10496
10497 2019-05-08  Tom Tromey  <tom@tromey.com>
10498
10499         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10500         Change type.
10501         (get_catch_syscall_inferior_data): Update.
10502         (catch_syscall_inferior_data_cleanup): Remove.
10503         (_initialize_break_catch_syscall): Update.
10504
10505 2019-05-08  Tom Tromey  <tom@tromey.com>
10506
10507         * inflow.c (struct terminal_info): Add destructor and
10508         initializers.
10509         (inflow_inferior_data): Change type.
10510         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10511         (get_inflow_inferior_data, inflow_inferior_exit)
10512         (swap_terminal_info, _initialize_inflow): Update.
10513
10514 2019-05-08  Tom Tromey  <tom@tromey.com>
10515
10516         * target-dcache.c (target_dcache_cleanup): Remove.
10517         (target_dcache_aspace_key): Change type.
10518         (target_dcache_init_p, target_dcache_invalidate)
10519         (target_dcache_get, target_dcache_get_or_init)
10520         (_initialize_target_dcache): Update.
10521         * dcache.h (struct dcache_deleter): New.
10522
10523 2019-05-08  Tom Tromey  <tom@tromey.com>
10524
10525         * symtab.c (struct symbol_cache): Add destructor and
10526         initializers.
10527         (symbol_cache_key): Move.  Change type.
10528         (make_symbol_cache, free_symbol_cache): Remove.
10529         (get_symbol_cache): Update.
10530         (symbol_cache_cleanup): Remove.
10531         (ALL_PSPACES, symbol_cache_flush)
10532         (maintenance_print_symbol_cache)
10533         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10534         Update.
10535
10536 2019-05-08  Tom Tromey  <tom@tromey.com>
10537
10538         * symtab.c (struct main_info): Add destructor and initializers.
10539         (main_progspace_key): Move.  Change type.
10540         (get_main_info): Update.
10541         (main_info_cleanup): Remove.
10542         (_initialize_symtab): Update.
10543
10544 2019-05-08  Tom Tromey  <tom@tromey.com>
10545
10546         * registry.h (DECLARE_REGISTRY): Define the _key class.
10547
10548 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10549
10550         * NEWS: Merge two 'New commands' sections.
10551
10552 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10553
10554         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10555         parameter and use Ada language definition instead.
10556         (ada_val_print_ptr): Remove unused language parameter.
10557         (ada_val_print_num): Remove language parameter and use Ada language
10558         definition instead.
10559         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10560         parameter.
10561         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10562         parameter and use Ada language definition instead.
10563         (ada_val_print_1): Update all ada_val_print_xxx calls.
10564         Remove language parameter.
10565         (ada_val_print): Update ada_val_print_1 call.
10566
10567 2019-05-08  Tom Tromey  <tromey@adacore.com>
10568
10569         * remote.c (remote_hw_watchpoint_limit)
10570         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10571         Now static.
10572
10573 2019-05-08  Tom Tromey  <tromey@adacore.com>
10574
10575         * maint.c (_initialize_maint_cmds): Move initialization code to
10576         remote.c.
10577         (watchdog, show_watchdog): Move to remote.c.
10578         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10579         "watchdog" static.
10580         (_initialize_remote): Move initialization code from maint.c.
10581         * defs.h (watchdog): Don't declare.
10582
10583 2019-05-08  Tom Tromey  <tromey@adacore.com>
10584
10585         * tui/tui-interp.c: Include main.h.
10586         * interps.c: Include main.h.
10587         * main.h (interpreter_p): Declare.
10588         * defs.h (interpreter_p): Don't declare.
10589
10590 2019-05-08  Tom Tromey  <tromey@adacore.com>
10591
10592         * dwarf2loc.c: Include dwarf2read.h.
10593         * defs.h (read_unsigned_leb128): Don't declare.
10594         * dwarf2read.h (read_unsigned_leb128): Declare.
10595
10596 2019-05-08  Tom Tromey  <tromey@adacore.com>
10597
10598         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10599         method.
10600
10601 2019-05-08  Tom Tromey  <tromey@adacore.com>
10602
10603         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10604         when no wrap column is set.
10605
10606 2019-05-08  Tom Tromey  <tromey@adacore.com>
10607
10608         * c-lang.c (c_get_string): Handle non-C-style arrays.
10609
10610 2019-05-08  Tom Tromey  <tromey@adacore.com>
10611
10612         * typeprint.c (print_offset_data::update): Print the bit offset,
10613         not the number of bits remaining.
10614
10615 2019-05-08  Tom Tromey  <tromey@adacore.com>
10616
10617         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10618         padding at end of comment.
10619
10620 2019-05-08  Tom Tromey  <tromey@adacore.com>
10621
10622         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10623         Compare main types.
10624
10625 2019-05-06  Tom Tromey  <tom@tromey.com>
10626
10627         * common/scoped_mmap.c: Include common-defs.h.
10628         * common/scoped_mmap.h: Don't include config.h.
10629
10630 2019-05-04  Tom Tromey  <tom@tromey.com>
10631
10632         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10633         (struct aarch64_call_info): Add initializers.
10634         <si>: Now a std::vector.
10635         (pass_on_stack, aarch64_push_dummy_call): Update.
10636
10637 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10638             Tom Tromey  <tom@tromey.com>
10639
10640         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10641         (ppc_threads): Now a std::vector.  Now static.
10642         (hwdebug_find_thread_points_by_tid)
10643         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10644         Update.
10645
10646 2019-05-04  Tom Tromey  <tom@tromey.com>
10647
10648         * arc-tdep.c (arc_tdesc_init): Return bool.
10649
10650 2019-05-04  Tom Tromey  <tom@tromey.com>
10651
10652         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10653         Use gdb_assert_not_reached.
10654
10655 2019-05-04  Tom Tromey  <tom@tromey.com>
10656
10657         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10658         "false".
10659
10660 2019-05-04  Tom Tromey  <tom@tromey.com>
10661
10662         * arc-tdep.c (arc_tdesc_init): Use bool.
10663
10664 2019-05-04  Tom Tromey  <tom@tromey.com>
10665
10666         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10667
10668 2019-05-04  Tom Tromey  <tom@tromey.com>
10669
10670         * cli/cli-cmds.c (valid_command_p): Return bool.
10671
10672 2019-05-04  Tom Tromey  <tom@tromey.com>
10673
10674         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10675         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10676
10677 2019-05-04  Raul Tambre  <raul@tambre.ee>
10678
10679         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10680         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10681         operator for comparison.
10682
10683 2019-05-04  Tom Tromey  <tom@tromey.com>
10684
10685         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10686         (lookup_partial_symbol, print_partial_symbols)
10687         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10688         (psymbol_compare): Update.
10689         (add_psymbol_to_bcache): Clear the entire psymbol.
10690         (maintenance_check_psymtabs): Update.
10691         * psympriv.h (struct partial_symbol): Don't derive from
10692         general_symbol_info.
10693         <obj_section, unrelocated_address, address,
10694         set_unrelocated_address>: Update.
10695         <ginfo>: New member.
10696         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10697         (debug_names::write_psymbols): Update.
10698
10699 2019-05-04  Tom de Vries  <tdevries@suse.de>
10700
10701         * contrib/cc-with-tweaks.sh: Support -n arg.
10702
10703 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10704
10705         * corelow.c (core_target::detach): Ensure frame cache and
10706         register caches are cleared.
10707         inferior.c (exit_inferior_1): Likewise.
10708
10709 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10710             Tom Tromey  <tom@tromey.com>
10711
10712         * dictionary.c (collate_pending_symbols_by_language): Remove
10713         "struct" from foreach.
10714         * symtab.c (lookup_global_symbol_from_objfile)
10715         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10716         foreach.
10717         * ser-tcp.c (net_open): Remove "struct" from foreach.
10718         * objfiles.c (objfile_relocate, objfile_rebase)
10719         (objfile_has_symbols): Remove "struct" from foreach.
10720         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10721         from foreach.
10722         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10723         foreach.
10724         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10725         "struct" from foreach.
10726         * ada-lang.c (create_excep_cond_exprs)
10727         (ada_exception_catchpoint_cond_string): Remove "struct" from
10728         foreach.
10729
10730 2019-05-03  Tom Tromey  <tromey@adacore.com>
10731
10732         * ada-exp.y (convert_char_literal): Check suffix of each
10733         enumerator.
10734
10735 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10736
10737         PR ada/21406:
10738         * ada-exp.y (yywrap): Don't define.
10739         * ada-lex.l (%option): Add noyywrap
10740         (yywrap): Remove.
10741
10742 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10743
10744         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10745         _WIN32_WINNT to the XP level, unless already defined to a higher
10746         level.
10747
10748         * unittests/parse-connection-spec-selftests.c:
10749         * ser-tcp.c:
10750         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10751         override.
10752
10753         * symfile.c (find_separate_debug_file): Remove colon from the
10754         drive spec of DOS/Windows file names of the target, so that the
10755         file name produced from DEBUGDIR and the target's directory will
10756         be valid on DOS/Windows systems.
10757
10758 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * rust-lang.c (val_print_struct): Handle printing structures
10761         containing strings.
10762
10763 2019-05-02  Tom Tromey  <tromey@adacore.com>
10764
10765         * valarith.c (_initialize_valarith): Remove.
10766
10767 2019-05-01  Tom Tromey  <tromey@adacore.com>
10768
10769         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10770         bitfields.
10771
10772 2019-05-01  Tom Tromey  <tromey@adacore.com>
10773
10774         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10775         for big-endian copies.
10776
10777 2019-04-30  Ali Tamur  <tamur@google.com>
10778         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10779         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10780         (read_3_bytes): New function.
10781
10782 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10783
10784         * windows-nat.c (main_thread_id): Delete.
10785         (handle_output_debug_string): Replace main_thread_id by
10786         current_event.dwThreadId.
10787         (fake_create_process): Likewise.
10788         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10789         Do not set main_thread_id.
10790         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10791         current_event.dwThreadId.
10792         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10793
10794 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10795
10796         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10797         Use current_event.dwThreadId instead of main_thread_id.
10798
10799 2019-04-30  Tom Tromey  <tromey@adacore.com>
10800
10801         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10802         (create_excep_cond_exprs): Iterate over program spaces.
10803         (ada_exception_catchpoint_cond_string): Examine all minimal
10804         symbols for exception types.
10805
10806 2019-04-30  Tom Tromey  <tromey@adacore.com>
10807
10808         PR c++/24470:
10809         * dwarf2read.c (process_structure_scope): Handle case where type
10810         has template parameters but no symbol was created.
10811
10812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10813             Chris January  <chris.january@arm.com>
10814
10815         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10816         qualifier.
10817         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10818
10819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10820
10821         * f-typeprint.c (f_print_type): Update rules for printing
10822         whitespace.
10823         (f_type_print_varspec_suffix): Likewise.
10824
10825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10826             Chris January  <chris.january@arm.com>
10827
10828         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10829         function arguments.
10830
10831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10832
10833         * f-lang.c (build_fortran_types): Change name of void type to
10834         lower case.
10835         * f-typeprint.c (f_type_print_base): Print the name of the void
10836         type, rather than a fixed string.
10837         * f-valprint.c (f_decorations): Use lower case void string.
10838
10839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10840             Chris January  <chris.january@arm.com>
10841
10842         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10843         types for Fortran.
10844
10845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10846             Chris January  <chris.january@arm.com>
10847             David Lecomber  <david.lecomber@arm.com>
10848
10849         * f-exp.y (BINOP_INTRINSIC): New token.
10850         (exp): New parser rule handling BINOP_INTRINSIC.
10851         (f77_keywords): Add new builtin procedures.
10852         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10853         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10854         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10855         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10856         (print_unop_subexp_f): New function.
10857         (print_binop_subexp_f): New function.
10858         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10859         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10860         (dump_subexp_body_f): Likewise.
10861         (operator_check_f): Likewise.
10862         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10863         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10864
10865 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10866
10867         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10868         UNOP_KIND.
10869         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10870         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10871         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10872         (operator_length_f): New fuction.
10873         (print_subexp_f): New function.
10874         (op_name_f): New function.
10875         (dump_subexp_body_f): New function.
10876         (operator_check_f): New function.
10877         (exp_descriptor_f): Replace standard expression handling functions
10878         with new functions.
10879         * gdb/fortran-operator.def: New file.
10880         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10881         * gdb/std-operator.def: Remove UNOP_KIND.
10882
10883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * std-operator.def: Remove unbalanced, stray double quote
10886         character.
10887
10888 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10889             Chris January  <chris.january@arm.com>
10890             Daniel Everett  <daniel.everett@arm.com>
10891             Nick Forrington  <nick.forrington@arm.com>
10892             Richard Bunt  <richard.bunt@arm.com>
10893
10894         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10895         of depth when printing anonymous structs or unions.
10896         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10897         Don't print either the top-level value, or the children if the
10898         max-depth is exceeded.
10899         (ppscm_print_children): When printing the key of a map, allow one
10900         extra level of depth.
10901         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10902         print either the top-level value, or the children if the max-depth
10903         is exceeded.
10904         (print_children): When printing the key of a map, allow one extra
10905         level of depth.
10906         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10907         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10908         (user_print_options): Initialise max_depth field.
10909         (val_print_scalar_or_string_type_p): New function.
10910         (val_print): Check to see if the max depth has been reached.
10911         (val_print_check_max_depth): Define new function.
10912         (show_print_max_depth): New function.
10913         (_initialize_valprint): Add 'print max-depth' option.
10914         * valprint.h (struct value_print_options) <max_depth>: New field.
10915         (val_print_check_max_depth): Declare new function.
10916         * NEWS: Document new feature.
10917
10918 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10919
10920         * ada-lang.c (ada_language_defn): Initialise new field.
10921         * c-lang.c (c_is_string_type_p): New function.
10922         (c_language_defn): Initialise new field.
10923         (cplus_language_defn): Initialise new field.
10924         (asm_language_defn): Initialise new field.
10925         (minimal_language_defn): Initialise new field.
10926         * c-lang.h (c_is_string_type_p): Declare new function.
10927         * d-lang.c (d_language_defn): Initialise new field.
10928         * f-lang.c (f_is_string_type_p): New function.
10929         (f_language_defn): Initialise new field.
10930         * go-lang.c (go_is_string_type_p): New function.
10931         (go_language_defn): Initialise new field.
10932         * language.c (default_is_string_type_p): New function.
10933         (unknown_language_defn): Initialise new field.
10934         (auto_language_defn): Initialise new field.
10935         * language.h (struct language_defn) <la_is_string_type_p>: New
10936         member variable.
10937         (default_is_string_type_p): Declare new function.
10938         * m2-lang.c (m2_language_defn): Initialise new field.
10939         * objc-lang.c (objc_language_defn): Initialise new field.
10940         * opencl-lang.c (opencl_language_defn): Initialise new field.
10941         * p-lang.c (pascal_is_string_type_p): New function.
10942         (pascal_language_defn): Initialise new field.
10943         * rust-lang.c (rust_is_string_type_p): New function.
10944         (rust_language_defn): Initialise new field.
10945
10946 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10947
10948         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10949         New field.
10950         * ada-lang.c (ada_language_defn): Initialise new field.
10951         * c-lang.c (c_language_defn): Likewise.
10952         (cplus_language_defn): Likewise.
10953         (asm_language_defn): Likewise.
10954         (minimal_language_defn): Likewise.
10955         * d-lang.c (d_language_defn): Likewise.
10956         * f-lang.c (f_language_defn): Likewise.
10957         * go-lang.c (go_language_defn): Likewise.
10958         * language.c (unknown_language_defn): Likewise.
10959         (auto_language_defn): Likewise.
10960         * m2-lang.c (m2_language_defn): Likewise.
10961         * objc-lang.c (objc_language_defn): Likewise.
10962         * opencl-lang.c (opencl_language_defn): Likewise.
10963         * p-lang.c (pascal_language_defn): Likewise.
10964         * rust-lang.c (rust_language_defn): Likewise.
10965
10966 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10967
10968         * ada-lang.c (ada_is_character_type): Change return type to bool.
10969         (ada_is_string_type): Likewise.
10970         * ada-lang.h (ada_is_character_type): Update declaration
10971         (ada_is_string_type): Likewise.
10972
10973 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10974
10975         Support style in 'frame|thread apply'
10976
10977         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10978         * record.c (record_start, record_stop): Update callers of
10979         execute_command_to_string with false.
10980         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10981         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10982         methods.
10983         (class string_file): New constructor with term_out parameter.
10984         Override methods term_out and can_emit_style_escape.  New member
10985         term_out.
10986         (class stdio_file): Override can_emit_style_escape.
10987         (class tee_file): Override term_out and can_emit_style_escape.
10988         * utils.h (can_emit_style_escape): Remove.
10989         * utils.c (can_emit_style_escape): Likewise.
10990         Update all callers of can_emit_style_escape (SOMESTREAM) to
10991         SOMESTREAM->can_emit_style_escape.
10992         * source-cache.c (source_cache::get_source_lines): Likewise.
10993         * stack.c (frame_apply_command_count): Call execute_command_to_string
10994         passing the term_out characteristic of the current gdb_stdout.
10995         * thread.c (thr_try_catch_cmd): Likewise.
10996         * top.c (execute_command_to_string): pass term_out parameter
10997         to construct the string_file for the command output.
10998         * ui-file.c (term_cli_styling): New function (most code moved
10999         from utils.c can_emit_style_escape).
11000         (string_file::string_file, string_file::can_emit_style_escape,
11001         stdio_file::can_emit_style_escape, tee_file::term_out,
11002         tee_file::can_emit_style_escape): New functions.
11003
11004 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11005
11006         * NEWS: Mention the new set|show may-call-functions.
11007         * infcall.c (may_call_functions_p): New variable.
11008         (show_may_call_functions_p): New function.
11009         (call_function_by_hand_dummy): Throws an error if not
11010         may-call-functions.
11011         (_initialize_infcall): Call add_setshow_boolean_cmd for
11012         may-call-functions.
11013
11014 2019-04-25  Keith Seitz  <keiths@redhat.com>
11015
11016         PR c++/24367
11017         * cp-support.c (inspect_type): Don't attempt substitutions
11018         of symbol with the same name.
11019
11020 2019-04-25  Tom Tromey  <tromey@adacore.com>
11021
11022         PR gdb/24475:
11023         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11024         static.
11025
11026 2019-04-25  Tom Tromey  <tromey@adacore.com>
11027
11028         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11029         rvalue reference.
11030         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11031         (gdb_xml_parser::parse): Use std::move.
11032         * python/python-internal.h (gdbpy_convert_exception): Take a const
11033         reference.
11034         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11035         std::move.
11036         * python/py-utils.c (gdbpy_convert_exception): Take a const
11037         reference.
11038         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11039         Use std::move.
11040         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11041         Use std::move.
11042         * mi/mi-main.c (mi_print_exception): Take a const reference.
11043         * main.c (handle_command_errors): Take a const reference.
11044         * linespec.c (parse_linespec): Use std::move.
11045         * infcall.c (run_inferior_call): Use std::move.
11046         (call_function_by_hand_dummy): Use std::move.
11047         * exec.c (try_open_exec_file): Use std::move.
11048         * exceptions.h (exception_print, exception_fprintf)
11049         (exception_print_same): Update.
11050         * exceptions.c (print_exception, exception_print)
11051         (exception_fprintf, exception_print_same): Change parameters to
11052         const reference.
11053         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11054         * common/new-op.c: Use std::move.
11055         * common/common-exceptions.h (struct gdb_exception): Add move
11056         constructor.
11057         (struct gdb_exception_error, struct gdb_exception_quit, struct
11058         gdb_quit_bad_alloc): Change constructor to move constructor.
11059         (throw_exception): Change parameter to rvalue reference.
11060         * common/common-exceptions.c (throw_exception): Take rvalue
11061         reference.
11062         * cli/cli-interp.c (safe_execute_command): Use std::move.
11063         * breakpoint.c (insert_bp_location, location_to_sals): Use
11064         std::move.
11065
11066 2019-04-25  Tom Tromey  <tromey@adacore.com>
11067
11068         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11069         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11070         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11071         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11072         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11073         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11074         guile/scm-value.c: Use unpack.
11075         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11076         gdbscm_gdb_exception.
11077         (gdbscm_throw_gdb_exception): Likewise.
11078         (struct gdbscm_gdb_exception): New.
11079         (unpack): New function.
11080         (gdbscm_wrap): Use unpack.
11081
11082 2019-04-25  Tom Tromey  <tromey@adacore.com>
11083
11084         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11085         (gdb_rl_callback_handler): Use std::move.
11086         * common/common-exceptions.h (struct gdb_exception): Add move
11087         assignment operator.
11088         (throw_exception_sjlj): Change "exception" to const reference.
11089         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11090         (throw_exception_sjlj): Change "exception" to const reference.
11091
11092 2019-04-25  Tom Tromey  <tromey@adacore.com>
11093
11094         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11095         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11096         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11097         Update.
11098         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11099         Update.
11100         * mi/mi-interp.c (mi_interp::exec): Update.
11101         * linespec.c (parse_linespec): Update.
11102         * infcall.c (run_inferior_call): Update.
11103         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11104         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11105         (gdbscm_lookup_global_symbol): Update.
11106         * guile/scm-param.c (gdbscm_parameter_value): Update.
11107         * guile/scm-frame.c (gdbscm_frame_read_register)
11108         (gdbscm_frame_read_var): Update.
11109         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11110         * exec.c (try_open_exec_file): Update.
11111         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11112         (gdb_rl_callback_handler): Update.
11113         * common/common-exceptions.h (exception_none): Don't declare.
11114         * common/common-exceptions.c (exception_none): Don't define.
11115         (struct catcher) <exception>: Update.
11116         * cli/cli-interp.c (safe_execute_command): Update.
11117         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11118
11119 2019-04-25  Ali Tamur  <tamur@google.com>
11120
11121         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11122         (read_attribute_value): Likewise.
11123         (dwarf2_read_addr_index): Update comment.
11124         (read_str_index): Add DW_FORM_strx.
11125         (dwarf2_string_attr): Likewise.
11126         (dwarf2_const_value_attr): Likewise.
11127         (dump_die_shallow): Likewise.
11128         (dwarf2_fetch_constant_bytes): Likewise.
11129         (skip_form_bytes): Likewise.
11130         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11131
11132 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11133
11134         PR corefiles/11608
11135         PR corefiles/18187
11136         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11137         OFFSET.  Verify if current mapping contains an ELF header.
11138         (linux_find_memory_regions_full): Adjust call to
11139         dump_mapping_p.
11140
11141 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11142             Kang Li <kanglictf@gmail.com>
11143
11144         PR gdb/21600
11145
11146         * dwarf2-frame.c (read_initial_length): Be consistent about using
11147         unsigned representation of length.
11148         (decode_frame_entry_1): Likewise.  Check for wraparound of
11149         end pointer as well as buffer overflow.
11150
11151 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11152
11153         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11154         "vq".
11155
11156 2019-04-24  Tom Tromey  <tromey@adacore.com>
11157
11158         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11159
11160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11161
11162         * s12z-tdep.c (s12z_unwind_pc): Delete.
11163         (s12z_unwind_sp): Delete.
11164         (s12z_gdbarch_init): Don't register deleted functions with
11165         gdbarch.
11166
11167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11168
11169         * rl78-tdep.c (rl78_unwind_sp): Delete.
11170         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11171
11172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11173
11174         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11175         (xstormy16_unwind_pc): Delete.
11176         (xstormy16_dummy_id): Delete.
11177         (xstormy16_gdbarch_init): Don't register deleted functions with
11178         gdbarch.
11179
11180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * vax-tdep.c (vax_unwind_pc): Delete.
11183         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11184
11185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * v850-tdep.c (v850_unwind_sp): Delete.
11188         (v850_unwind_pc): Delete.
11189         (v850_dummy_id): Delete.
11190         (v850_gdbarch_init): Don't register deleted functions with
11191         gdbarch.
11192
11193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11194
11195         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11196         (tilegx_unwind_pc): Delete.
11197         (tilegx_unwind_dummy_id): Delete.
11198         (tilegx_gdbarch_init): Don't register deleted functions with
11199         gdbarch.
11200
11201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11202
11203         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11204         (tic6x_dummy_id): Delete.
11205         (tic6x_gdbarch_init): Don't register deleted functions with
11206         gdbarch.
11207
11208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11209
11210         * sparc-tdep.c (sparc_unwind_pc): Delete.
11211         (sparc32_gdbarch_init): Don't register deleted function with
11212         gdbarch.
11213
11214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * sh-tdep.c (sh_unwind_sp): Delete.
11217         (sh_unwind_pc): Delete.
11218         (sh_dummy_id): Delete.
11219         (sh_gdbarch_init): Don't register deleted functions with
11220         gdbarch.
11221
11222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * score-tdep.c (score_unwind_sp): Delete.
11225         (score_unwind_pc): Delete.
11226         (score_dummy_id): Delete.
11227         (score_gdbarch_init): Don't register deleted functions with
11228         gdbarch.
11229
11230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11231
11232         * rx-tdep.c (rx_unwind_pc): Delete.
11233         (rx_unwind_sp): Delete.
11234         (rx_dummy_id): Delete.
11235         (rx_gdbarch_init): Don't register deleted functions with
11236         gdbarch.  Update comment.
11237
11238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11239
11240         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11241         (rs6000_dummy_id): Delete.
11242         (rs6000_gdbarch_init): Don't register deleted functions with
11243         gdbarch.
11244
11245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11246
11247         * or1k-tdep.c (or1k_dummy_id): Delete.
11248         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11249
11250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11251
11252         * nios2-tdep.c (nios2_dummy_id): Delete.
11253         (nios2_unwind_sp): Delete.
11254         (nios2_gdbarch_init): Don't register deleted functions with
11255         gdbarch.
11256
11257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11258
11259         * nds32-tdep.c (nds32_dummy_id): Delete.
11260         (nds32_unwind_pc): Delete.
11261         (nds32_unwind_sp): Delete.
11262         (nds32_gdbarch_init): Don't register deleted functions with
11263         gdbarch.
11264
11265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11266
11267         * msp430-tdep.c (msp430_unwind_pc): Delete.
11268         (msp430_unwind_sp): Delete.
11269         (msp430_dummy_id): Delete.
11270         (msp430_gdbarch_init): Don't register deleted functions with
11271         gdbarch.
11272
11273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11274
11275         * moxie-tdep.c (moxie_unwind_sp): Delete.
11276         (moxie_unwind_pc): Delete.
11277         (moxie_dummy_id): Delete.
11278         (moxie_gdbarch_init): Don't register deleted functions with
11279         gdbarch.
11280
11281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11282
11283         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11284         (mn10300_unwind_pc): Delete.
11285         (mn10300_unwind_sp): Delete.
11286         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11287         mn10300_unwind_sp.
11288         (mn10300_frame_unwind_init): Don't register deleted functions with
11289         gdbarch.
11290
11291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * mep-tdep.c (mep_unwind_pc): Delete.
11294         (mep_unwind_sp): Delete.
11295         (mep_dummy_id): Delete.
11296         (mep_gdbarch_init): Don't register deleted functions with
11297         gdbarch.
11298
11299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11300
11301         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11302         (m68hc11_unwind_sp): Delete.
11303         (m68hc11_gdbarch_init): Don't register deleted functions with
11304         gdbarch.
11305
11306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11307
11308         * m32r-tdep.c (m32r_unwind_sp): Delete.
11309         (m32r_unwind_pc): Delete.
11310         (m32r_dummy_id): Delete.
11311         (m32r_gdbarch_init): Don't register deleted functions with
11312         gdbarch.
11313
11314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11315
11316         * m32c-tdep.c (m32c_unwind_pc): Delete.
11317         (m32c_unwind_sp): Delete.
11318         (m32c_dummy_id): Delete.
11319         (m32c_gdbarch_init): Don't register deleted functions with
11320         gdbarch.
11321
11322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11323
11324         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11325         (lm32_unwind_pc): Delete.
11326         (lm32_dummy_id): Delete.
11327         (lm32_gdbarch_init): Don't register deleted functions with
11328         gdbarch.
11329
11330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11331
11332         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11333         (iq2000_unwind_pc): Delete.
11334         (iq2000_dummy_id): Delete.
11335         (iq2000_gdbarch_init): Don't register deleted functions with
11336         gdbarch.
11337
11338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11339
11340         * nds32-tdep.c (nds32_type_align): Delete.
11341         (nds32_push_dummy_call): Use type_align instead.
11342
11343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11344
11345         * arm-tdep.c (arm_type_align): Only handle vector override case.
11346         (arm_push_dummy_call): Use type_align.
11347         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11348
11349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11350
11351         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11352         case.
11353         (pass_on_stack): Use type_align.
11354         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11355         function.
11356
11357 2019-04-23  Tom Tromey  <tromey@adacore.com>
11358
11359         * dwarf2read.c (line_header::file_name_at): Remove unused
11360         overload.
11361
11362 2019-04-23  Tom de Vries  <tdevries@suse.de>
11363
11364         PR gdb/24438
11365         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11366         invocation.
11367
11368
11369 2019-03-27  Ali Tamur  <tamur@google.com>
11370
11371         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11372         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11373         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11374         (dwarf_expr_context::get_addr_index): Likewise
11375         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11376         (symbol_needs_eval_context::get_addr_index): Likewise
11377         (disassemble_dwarf_expression): Add DW_OP_addrx
11378         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11379         (read_cutu_die_from_dwo): Update comment
11380         (skip_one_die): Add DW_FORM_addrx
11381         (read_attribute_value): Likewise
11382         (var_decode_location): Add DW_OP_addrx
11383         (dwarf2_const_value_attr): Add DW_FORM_addrx
11384         (dump_die_shallow): Likewise
11385         (dwarf2_fetch_constant_bytes): Likewise
11386         (decode_locdesc): Add DW_OP_addrx
11387         (skip_form_bytes): Add DW_FORM_addrx
11388
11389 2019-04-22  Ali Tamur  <tamur@google.com>
11390
11391         * MAINTAINERS (Write After Approval): Add self.
11392
11393 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11394
11395         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11396         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11397         (open_symbol_file_object): Likewise.
11398         (svr4_default_sos): Add info parameter.
11399         (svr4_read_so_list): Likewise.
11400         (svr4_current_sos_direct): Adjust functions calls to pass down
11401         info.
11402         (svr4_current_sos_1): Add info parameter.
11403         (svr4_current_sos): Call get_svr4_info, pass info down to
11404         svr4_current_sos_1.
11405         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11406         get_svr4_info.
11407         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11408         get_svr4_info.
11409         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11410         to get_svr4_info.
11411         (probes_table_remove_objfile_probes): Likewise.
11412         (register_solib_event_probe): Add info parameter.
11413         (solist_update_incremental): Pass info parameter down to
11414         svr4_read_so_list.
11415         (disable_probes_interface): Add info parameter.
11416         (svr4_handle_solib_event): Pass current_program_space to
11417         get_svr4_info.  Adjust disable_probes_interface cleanup.
11418         (svr4_create_probe_breakpoints): Add info parameter, pass it
11419         down to register_solib_event_probe.
11420         (svr4_create_solib_event_breakpoints): Add info parameter,
11421         pass it down to svr4_create_probe_breakpoints.
11422         (enable_break): Pass info down to
11423         svr4_create_solib_event_breakpoints.
11424         (svr4_solib_create_inferior_hook): Pass current_program_space to
11425         get_svr4_info.
11426         (svr4_clear_solib): Likewise.
11427
11428 2019-04-22  Pedro Alves  <palves@redhat.com>
11429
11430         * solib-svr4.c (svr4_free_objfile_observer): New.
11431         (probe_and_action::objfile): New field.
11432         (probes_table_htab_remove_objfile_probes)
11433         (probes_table_remove_objfile_probes): New functions.
11434         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11435         in the new probe_and_action.  Don't store the probe in 'lookup'.
11436         (svr4_create_probe_breakpoints): Pass objfile to
11437         register_solib_event_probe.
11438         (_initialize_svr4_solib): Register a free_objfile observer.
11439
11440 2019-04-19  Tom Tromey  <tom@tromey.com>
11441
11442         * common/queue.h: Remove.
11443
11444 2019-04-19  Tom Tromey  <tom@tromey.com>
11445
11446         * event-loop.c: Don't include "common/queue.h".
11447
11448 2019-04-19  Tom Tromey  <tom@tromey.com>
11449
11450         * remote.c (remote_target): Use delete.
11451         * remote-notif.h: Include <list>, not "common/queue.h".
11452         (notif_client_p): Remove typedef.
11453         (remote_notif_state): Add constructor, destructor, initializer.
11454         <notif_queue>: Now a std::list.
11455         (remote_notif_state_xfree): Don't declare.
11456         * remote-notif.c (remote_notif_process, handle_notification)
11457         (remote_notif_state_allocate): Update.
11458         (~remote_notif_state): Rename from remote_notif_state_xfree.
11459
11460 2019-04-19  Tom Tromey  <tom@tromey.com>
11461
11462         * symfile.c (reread_symbols): Update.
11463         * objfiles.c (objfile_register_static_link)
11464         (objfile_lookup_static_link): Update
11465         (~objfile) Don't delete static_links.
11466         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11467
11468 2019-04-19  Tom Tromey  <tom@tromey.com>
11469
11470         * type-stack.h (struct type_stack) <insert>: Constify string.
11471         * type-stack.c (type_stack::insert): Constify string.
11472         * gdbtypes.h (lookup_template_type): Update.
11473         (address_space_name_to_int): Update.
11474         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11475         const.
11476         (lookup_template_type): Make name const.
11477         * c-exp.y: Update rules.
11478         (lex_one_token, classify_name, classify_inner_name)
11479         (c_print_token): Update.
11480         * p-exp.y: Update rules.
11481         (yylex): Update.
11482         * f-exp.y: Update rules.
11483         (yylex): Update.
11484         * d-exp.y: Update rules.
11485         (lex_one_token, classify_name, classify_inner_name): Update.
11486         * parse.c (write_dollar_variable, copy_name): Return std::string.
11487         * parser-defs.h (copy_name): Change return type.
11488         * m2-exp.y: Update rules.
11489         (yylex): Update.
11490         * go-exp.y (lex_one_token): Update.
11491         Update rules.
11492         (classify_unsafe_function, classify_packaged_name)
11493         (classify_name, yylex): Update.
11494
11495 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11496
11497         * configure.ac: add --enable-source-highlight switch.
11498         * configure: Regenerate.
11499         * top.c (print_gdb_version): plumb --enable-source-highlight
11500         status to "show configuration".
11501
11502 2019-04-19  Tom Tromey  <tromey@adacore.com>
11503
11504         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11505         Check ADA_TYPE_P.
11506         (empty_record, ada_template_to_fixed_record_type_1)
11507         (template_to_static_fixed_type)
11508         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11509         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11510         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11511         macros.
11512
11513 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11514
11515         PR symtab/24423:
11516         * source.c (print_source_lines_base): Advance "iter" when a
11517         control character is seen.
11518
11519 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11520
11521         * inferior.h (struct infcall_suspend_state_deleter):
11522         Catch exception in destructor to avoid crash.
11523
11524 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11525
11526         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11527         close to the add_com "shell".
11528
11529 2019-04-18  Tom Tromey  <tromey@adacore.com>
11530
11531         * process-stratum-target.h (class process_stratum_target)
11532         <stratum>: Add "final".
11533
11534 2019-04-17  Tom Tromey  <tromey@adacore.com>
11535
11536         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11537         against nullptr before use.
11538
11539 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11540
11541         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11542
11543 2019-04-17  Jim Wilson  <jimw@sifive.com>
11544             Andrew Burgess  <andrew.burgess@embecosm.com>
11545
11546         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11547         code read might fail, assume 4-byte breakpoint in that case.
11548
11549 2019-04-15  Leszek Swirski  <leszeks@google.com>
11550
11551         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11552         rather than a hand-rolled POD check when checking for forced MEMORY
11553         classification.
11554
11555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11556
11557         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11558         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11559         function.
11560         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11561         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11562         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11563         declaration.
11564
11565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11566
11567         * aarch64-linux-nat.c
11568         (aarch64_linux_nat_target::thread_architecture): Add override.
11569         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11570         each VQ.
11571
11572 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11573
11574         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11575
11576 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11577
11578         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11579         target types of size 96-bits, add some additional comments, and
11580         check that the builtin type we found was the correct size.
11581
11582 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11583
11584         * utils.c (prompt_for_continue): Don't restore the styling at the
11585         end, as applied_style has the wrong value.  This fixes styling in
11586         long lists of file names that are interrupted by the "Continue?"
11587         prompt.
11588
11589 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11590
11591         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11592         * c-lang.c (c_language_defn): Likewise.
11593         (cplus_language_defn): Likewise.
11594         (asm_language_defn): Likewise.
11595         (minimal_language_defn): Likewise.
11596         * d-lang.c (d_language_defn): Likewise.
11597         * f-lang.c (f_language_defn): Likewise.
11598         * go-lang.c (go_language_defn): Likewise.
11599         * language.c (unknown_language_defn): Likewise.
11600         (auto_language_defn): Likewise.
11601         * language.h (struct language_defn): Remove la_magic field.
11602         (LANG_MAGIC): Delete.
11603         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11604         * objc-lang.c (objc_language_defn): Likewise.
11605         * opencl-lang.c (opencl_language_defn): Likewise.
11606         * p-lang.c (pascal_language_defn): Likewise.
11607         * rust-lang.c (rust_language_defn): Likewise.
11608
11609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11610
11611         * riscv-tdep.c (riscv_type_align): New function.
11612         (riscv_type_alignment): Delete.
11613         (riscv_arg_location): Use 'type_align'.
11614         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11615
11616 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11617
11618         * gdbtypes.c (type_align): A struct with no non-static fields also
11619         has alignment of 1.
11620
11621 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11622
11623         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11624         component to 0.
11625         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11626         member.
11627         (riscv_struct_info::analyse): New implementation using new
11628         analyse_inner member function.
11629         (riscv_struct_info::field_offset): New member function.
11630         (riscv_struct_info::m_offsets): New member variable.
11631         (riscv_struct_info::analyse_inner): New private member function,
11632         takes the old implementation of riscv_struct_info::analyse but
11633         extended to track field offsets.
11634         (riscv_call_arg_struct): Update the struct folding special cases
11635         to handle cases where empty C++ structs, which are non-zero
11636         length, are found.
11637         (riscv_arg_location): Initialise the length of each location, a
11638         non-zero length now indicates the location is in use.
11639         (riscv_push_dummy_call): Allow for the first location having a
11640         non-zero offset when setting up arguments.
11641         (riscv_return_value): Likewise, but for return values.
11642
11643 2019-04-11  Tom Tromey  <tromey@adacore.com>
11644
11645         * utils.c (internal_vproblem): Make "msg" const.
11646
11647 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11648
11649         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11650         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11651         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11652         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11653
11654 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11655
11656         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11657         function.
11658         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11659         of amd64_collect_native_gregset.
11660         (amd64_linux_nat_target::store_registers): Likewise.
11661
11662 2019-04-10  Tom Tromey  <tom@tromey.com>
11663
11664         * symtab.c (lookup_global_symbol_from_objfile)
11665         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11666         * objfiles.h (class separate_debug_iterator): New.
11667         (class separate_debug_range): New.
11668         (struct objfile) <separate_debug_objfiles>: New method.
11669         (objfile_separate_debug_iterate): Don't declare.
11670         * objfiles.c (separate_debug_iterator::operator++): Rename from
11671         objfile_separate_debug_iterate.
11672         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11673         iterator.
11674         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11675         iterator.
11676
11677 2019-04-10  Tom Tromey  <tom@tromey.com>
11678
11679         * symfile.c (reread_symbols): Remove old comment.
11680         * objfiles.c (free_all_objfiles): Fix a typo.
11681
11682 2019-04-10  Tom Tromey  <tom@tromey.com>
11683
11684         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11685         * minsyms.c (lookup_minimal_symbol): Use foreach.
11686         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11687         (lookup_minimal_symbol_solib_trampoline): Likewise.
11688         * symfile.c (reread_symbols): Use foreach.
11689
11690 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11691             Tom Tromey  <tromey@adacore.com>
11692
11693         PR rust/24414:
11694         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11695         (rust_lex_int_test): Change "value" to be LONGEST.
11696         (rust_lex_tests): Add test for long integer literal.
11697
11698 2019-04-09  Tom Tromey  <tromey@adacore.com>
11699
11700         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11701         to bool.
11702         (extended_remote_target::attach): Update.
11703         (remote_target::remote_notice_new_inferior): Update.
11704         (remote_target::add_current_inferior_and_thread): Update.
11705         * inferior.c (exit_inferior_1): Use "false".
11706         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11707
11708 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11709
11710         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11711         the "start" command.
11712
11713 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11714
11715         * python/py-inferior.c (infpy_thread_from_thread_handle):
11716         Adjust comments to reflect renaming of thread_from_thread_handle
11717         to thread_from_handle.  Adjust keywords.  Fix type error message.
11718         (inferior_object_methods): Add thread_from_handle.  Retain
11719         thread_from_thread_handle, but mark it as deprecated.
11720
11721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11722
11723         * gdbthread.h (find_thread_by_handle): Revise declaration.
11724         * thread.c (find_thread_by_handle): Likewise.  Adjust
11725         implementation too.
11726         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11727         support for buffer objects as handles.
11728
11729 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11730
11731         * python/py-infthread.c (thpy_thread_handle): New function.
11732         (thread_object_methods): Register thpy_thread_handle.
11733
11734 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11735
11736         * gdbthread.h (thread_to_thread_handle): Declare.
11737         * thread.c (gdbtypes.h): Include.
11738         (thread_to_thread_handle): New function.
11739
11740         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11741         (target_thread_info_to_thread_handle): Declare.
11742         * target.c (target_thread_info_to_thread_handle): New function.
11743         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11744         * target-delegates.c: Regenerate.
11745
11746         * linux-thread-db.c (class thread_db_target): Add method
11747         thread_info_to_thread_handle.
11748         (thread_db_target::thread_info_to_thread_handle): Define.
11749         * remote.c (class remote_target): Add new method
11750         thread_info_to_thread_handle.
11751         (remote_target::thread_info_to_thread_handle): Define.
11752
11753 2019-04-08  Pedro Alves  <palves@redhat.com>
11754
11755         * common/common-exceptions.c (throw_exception): Don't create
11756         named object to throw; throw directly.
11757         (throw_it): Likewise.  Don't initialize gdb_exception::message
11758         here, with new; pass FMT and AP to the ctor instead.
11759         * common/common-exceptions.h: Include <string>.
11760         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11761         const char *, va_list)): New ctor.  Use std::make_shared.
11762         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11763         errors)): Delete.
11764         (gdb_exception_error::gdb_exception_error(enum errors, const char
11765         *, va_list)): New.
11766         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11767         Add assertion.
11768         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11769         errors)): Delete.
11770         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11771         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11772         Add assertion.
11773
11774 2019-04-08  Tom Tromey  <tom@tromey.com>
11775
11776         * valops.c (value_rtti_indirect_type): Replace throw_exception
11777         with throw.
11778         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11779         with throw.
11780         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11781         throw.
11782         * target.c (target_translate_tls_address): Replace throw_exception
11783         with throw.
11784         * stack.c (frame_apply_command_count): Replace throw_exception
11785         with throw.
11786         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11787         throw.
11788         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11789         with throw.
11790         * rs6000-tdep.c (rs6000_frame_cache)
11791         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11792         * remote.c: Replace throw_exception with throw.
11793         * record-full.c (record_full_message, record_full_wait_1)
11794         (record_full_restore): Replace throw_exception with throw.
11795         * record-btrace.c:
11796         (get_thread_current_frame_id, record_btrace_start_replaying)
11797         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11798         (cmd_record_btrace_start): Replace throw_exception with throw.
11799         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11800         throw.
11801         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11802         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11803         * linespec.c:
11804         (find_linespec_symbols): Replace throw_exception with throw.
11805         * infrun.c (displaced_step_prepare, resume): Replace
11806         throw_exception with throw.
11807         * infcmd.c (post_create_inferior): Replace throw_exception with
11808         throw.
11809         * inf-loop.c (inferior_event_handler): Replace throw_exception
11810         with throw.
11811         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11812         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11813         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11814         (get_prev_frame_always, get_frame_pc_if_available)
11815         (get_frame_address_in_block_if_available, get_frame_language):
11816         Replace throw_exception with throw.
11817         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11818         throw_exception with throw.
11819         * eval.c (fetch_subexp_value, evaluate_var_value)
11820         (evaluate_funcall, evaluate_subexp_standard): Replace
11821         throw_exception with throw.
11822         * dwarf2loc.c (call_site_find_chain)
11823         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11824         Replace throw_exception with throw.
11825         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11826         with throw.
11827         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11828         throw.
11829         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11830         * completer.c (complete_line_internal): Replace throw_exception
11831         with throw.
11832         * compile/compile-object-run.c (compile_object_run): Replace
11833         throw_exception with throw.
11834         * cli/cli-script.c (process_next_line): Replace throw_exception
11835         with throw.
11836         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11837         (btrace_enable, btrace_maint_update_pt_packets): Replace
11838         throw_exception with throw.
11839         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11840         throw_exception with throw.
11841         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11842         throw_exception with throw.
11843         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11844         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11845         * aarch64-tdep.c (aarch64_make_prologue_cache)
11846         (aarch64_make_stub_cache): Replace throw_exception with throw.
11847
11848 2019-04-08  Tom Tromey  <tom@tromey.com>
11849
11850         * common/common-exceptions.c (throw_exception): Rename from
11851         throw_exception_cxx.  Remove old copy.  Make argument const.
11852         (throw_it): Create and throw exception objects directly.
11853         * common/common-exceptions.h (throw_exception): Make argument
11854         const.
11855         (struct gdb_exception_error): Add constructor.
11856         (struct gdb_exception_quit): Add constructor.
11857
11858 2019-04-08  Tom Tromey  <tom@tromey.com>
11859
11860         * common/common-exceptions.h (exception_rethrow): Don't declare.
11861         (TRY_SJLJ): Update comment.
11862         (TRY, CATCH, END_CATCH): Remove.
11863         * common/common-exceptions.c (exception_rethrow): Remove.
11864
11865 2019-04-08  Tom Tromey  <tom@tromey.com>
11866
11867         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11868         Remove.
11869         (gdb_exception_error): Rename from
11870         gdb_exception_RETURN_MASK_ERROR.
11871         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11872         (gdb_quit_bad_alloc): Update.
11873         * aarch64-tdep.c: Update.
11874         * ada-lang.c: Update.
11875         * ada-typeprint.c: Update.
11876         * ada-valprint.c: Update.
11877         * amd64-tdep.c: Update.
11878         * arch-utils.c: Update.
11879         * break-catch-throw.c: Update.
11880         * breakpoint.c: Update.
11881         * btrace.c: Update.
11882         * c-varobj.c: Update.
11883         * cli/cli-cmds.c: Update.
11884         * cli/cli-interp.c: Update.
11885         * cli/cli-script.c: Update.
11886         * common/common-exceptions.c: Update.
11887         * common/new-op.c: Update.
11888         * common/selftest.c: Update.
11889         * compile/compile-c-symbols.c: Update.
11890         * compile/compile-cplus-symbols.c: Update.
11891         * compile/compile-object-load.c: Update.
11892         * compile/compile-object-run.c: Update.
11893         * completer.c: Update.
11894         * corelow.c: Update.
11895         * cp-abi.c: Update.
11896         * cp-support.c: Update.
11897         * cp-valprint.c: Update.
11898         * darwin-nat.c: Update.
11899         * disasm-selftests.c: Update.
11900         * dtrace-probe.c: Update.
11901         * dwarf-index-cache.c: Update.
11902         * dwarf-index-write.c: Update.
11903         * dwarf2-frame-tailcall.c: Update.
11904         * dwarf2-frame.c: Update.
11905         * dwarf2loc.c: Update.
11906         * dwarf2read.c: Update.
11907         * eval.c: Update.
11908         * event-loop.c: Update.
11909         * event-top.c: Update.
11910         * exec.c: Update.
11911         * f-valprint.c: Update.
11912         * fbsd-tdep.c: Update.
11913         * frame-unwind.c: Update.
11914         * frame.c: Update.
11915         * gdbtypes.c: Update.
11916         * gnu-v3-abi.c: Update.
11917         * guile/guile-internal.h: Update.
11918         * guile/scm-block.c: Update.
11919         * guile/scm-breakpoint.c: Update.
11920         * guile/scm-cmd.c: Update.
11921         * guile/scm-disasm.c: Update.
11922         * guile/scm-frame.c: Update.
11923         * guile/scm-lazy-string.c: Update.
11924         * guile/scm-math.c: Update.
11925         * guile/scm-param.c: Update.
11926         * guile/scm-ports.c: Update.
11927         * guile/scm-pretty-print.c: Update.
11928         * guile/scm-symbol.c: Update.
11929         * guile/scm-symtab.c: Update.
11930         * guile/scm-type.c: Update.
11931         * guile/scm-value.c: Update.
11932         * i386-linux-tdep.c: Update.
11933         * i386-tdep.c: Update.
11934         * inf-loop.c: Update.
11935         * infcall.c: Update.
11936         * infcmd.c: Update.
11937         * infrun.c: Update.
11938         * jit.c: Update.
11939         * language.c: Update.
11940         * linespec.c: Update.
11941         * linux-fork.c: Update.
11942         * linux-nat.c: Update.
11943         * linux-tdep.c: Update.
11944         * linux-thread-db.c: Update.
11945         * main.c: Update.
11946         * mi/mi-cmd-break.c: Update.
11947         * mi/mi-cmd-stack.c: Update.
11948         * mi/mi-interp.c: Update.
11949         * mi/mi-main.c: Update.
11950         * objc-lang.c: Update.
11951         * p-valprint.c: Update.
11952         * parse.c: Update.
11953         * ppc-linux-tdep.c: Update.
11954         * printcmd.c: Update.
11955         * python/py-arch.c: Update.
11956         * python/py-breakpoint.c: Update.
11957         * python/py-cmd.c: Update.
11958         * python/py-finishbreakpoint.c: Update.
11959         * python/py-frame.c: Update.
11960         * python/py-framefilter.c: Update.
11961         * python/py-gdb-readline.c: Update.
11962         * python/py-inferior.c: Update.
11963         * python/py-infthread.c: Update.
11964         * python/py-lazy-string.c: Update.
11965         * python/py-linetable.c: Update.
11966         * python/py-objfile.c: Update.
11967         * python/py-param.c: Update.
11968         * python/py-prettyprint.c: Update.
11969         * python/py-progspace.c: Update.
11970         * python/py-record-btrace.c: Update.
11971         * python/py-record.c: Update.
11972         * python/py-symbol.c: Update.
11973         * python/py-type.c: Update.
11974         * python/py-unwind.c: Update.
11975         * python/py-utils.c: Update.
11976         * python/py-value.c: Update.
11977         * python/python.c: Update.
11978         * record-btrace.c: Update.
11979         * record-full.c: Update.
11980         * remote-fileio.c: Update.
11981         * remote.c: Update.
11982         * riscv-tdep.c: Update.
11983         * rs6000-aix-tdep.c: Update.
11984         * rs6000-tdep.c: Update.
11985         * rust-exp.y: Update.
11986         * rust-lang.c: Update.
11987         * s390-tdep.c: Update.
11988         * selftest-arch.c: Update.
11989         * solib-dsbt.c: Update.
11990         * solib-frv.c: Update.
11991         * solib-spu.c: Update.
11992         * solib-svr4.c: Update.
11993         * solib.c: Update.
11994         * sparc64-linux-tdep.c: Update.
11995         * stack.c: Update.
11996         * symfile-mem.c: Update.
11997         * symmisc.c: Update.
11998         * target.c: Update.
11999         * thread.c: Update.
12000         * top.c: Update.
12001         * tracefile-tfile.c: Update.
12002         * tui/tui.c: Update.
12003         * typeprint.c: Update.
12004         * unittests/cli-utils-selftests.c: Update.
12005         * unittests/parse-connection-spec-selftests.c: Update.
12006         * valops.c: Update.
12007         * valprint.c: Update.
12008         * value.c: Update.
12009         * varobj.c: Update.
12010         * windows-nat.c: Update.
12011         * x86-linux-nat.c: Update.
12012         * xml-support.c: Update.
12013
12014 2019-04-08  Tom Tromey  <tom@tromey.com>
12015
12016         * xml-support.c: Use C++ exception handling.
12017         * x86-linux-nat.c: Use C++ exception handling.
12018         * windows-nat.c: Use C++ exception handling.
12019         * varobj.c: Use C++ exception handling.
12020         * value.c: Use C++ exception handling.
12021         * valprint.c: Use C++ exception handling.
12022         * valops.c: Use C++ exception handling.
12023         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12024         handling.
12025         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12026         * typeprint.c: Use C++ exception handling.
12027         * tui/tui.c: Use C++ exception handling.
12028         * tracefile-tfile.c: Use C++ exception handling.
12029         * top.c: Use C++ exception handling.
12030         * thread.c: Use C++ exception handling.
12031         * target.c: Use C++ exception handling.
12032         * symmisc.c: Use C++ exception handling.
12033         * symfile-mem.c: Use C++ exception handling.
12034         * stack.c: Use C++ exception handling.
12035         * sparc64-linux-tdep.c: Use C++ exception handling.
12036         * solib.c: Use C++ exception handling.
12037         * solib-svr4.c: Use C++ exception handling.
12038         * solib-spu.c: Use C++ exception handling.
12039         * solib-frv.c: Use C++ exception handling.
12040         * solib-dsbt.c: Use C++ exception handling.
12041         * selftest-arch.c: Use C++ exception handling.
12042         * s390-tdep.c: Use C++ exception handling.
12043         * rust-lang.c: Use C++ exception handling.
12044         * rust-exp.y: Use C++ exception handling.
12045         * rs6000-tdep.c: Use C++ exception handling.
12046         * rs6000-aix-tdep.c: Use C++ exception handling.
12047         * riscv-tdep.c: Use C++ exception handling.
12048         * remote.c: Use C++ exception handling.
12049         * remote-fileio.c: Use C++ exception handling.
12050         * record-full.c: Use C++ exception handling.
12051         * record-btrace.c: Use C++ exception handling.
12052         * python/python.c: Use C++ exception handling.
12053         * python/py-value.c: Use C++ exception handling.
12054         * python/py-utils.c: Use C++ exception handling.
12055         * python/py-unwind.c: Use C++ exception handling.
12056         * python/py-type.c: Use C++ exception handling.
12057         * python/py-symbol.c: Use C++ exception handling.
12058         * python/py-record.c: Use C++ exception handling.
12059         * python/py-record-btrace.c: Use C++ exception handling.
12060         * python/py-progspace.c: Use C++ exception handling.
12061         * python/py-prettyprint.c: Use C++ exception handling.
12062         * python/py-param.c: Use C++ exception handling.
12063         * python/py-objfile.c: Use C++ exception handling.
12064         * python/py-linetable.c: Use C++ exception handling.
12065         * python/py-lazy-string.c: Use C++ exception handling.
12066         * python/py-infthread.c: Use C++ exception handling.
12067         * python/py-inferior.c: Use C++ exception handling.
12068         * python/py-gdb-readline.c: Use C++ exception handling.
12069         * python/py-framefilter.c: Use C++ exception handling.
12070         * python/py-frame.c: Use C++ exception handling.
12071         * python/py-finishbreakpoint.c: Use C++ exception handling.
12072         * python/py-cmd.c: Use C++ exception handling.
12073         * python/py-breakpoint.c: Use C++ exception handling.
12074         * python/py-arch.c: Use C++ exception handling.
12075         * printcmd.c: Use C++ exception handling.
12076         * ppc-linux-tdep.c: Use C++ exception handling.
12077         * parse.c: Use C++ exception handling.
12078         * p-valprint.c: Use C++ exception handling.
12079         * objc-lang.c: Use C++ exception handling.
12080         * mi/mi-main.c: Use C++ exception handling.
12081         * mi/mi-interp.c: Use C++ exception handling.
12082         * mi/mi-cmd-stack.c: Use C++ exception handling.
12083         * mi/mi-cmd-break.c: Use C++ exception handling.
12084         * main.c: Use C++ exception handling.
12085         * linux-thread-db.c: Use C++ exception handling.
12086         * linux-tdep.c: Use C++ exception handling.
12087         * linux-nat.c: Use C++ exception handling.
12088         * linux-fork.c: Use C++ exception handling.
12089         * linespec.c: Use C++ exception handling.
12090         * language.c: Use C++ exception handling.
12091         * jit.c: Use C++ exception handling.
12092         * infrun.c: Use C++ exception handling.
12093         * infcmd.c: Use C++ exception handling.
12094         * infcall.c: Use C++ exception handling.
12095         * inf-loop.c: Use C++ exception handling.
12096         * i386-tdep.c: Use C++ exception handling.
12097         * i386-linux-tdep.c: Use C++ exception handling.
12098         * guile/scm-value.c: Use C++ exception handling.
12099         * guile/scm-type.c: Use C++ exception handling.
12100         * guile/scm-symtab.c: Use C++ exception handling.
12101         * guile/scm-symbol.c: Use C++ exception handling.
12102         * guile/scm-pretty-print.c: Use C++ exception handling.
12103         * guile/scm-ports.c: Use C++ exception handling.
12104         * guile/scm-param.c: Use C++ exception handling.
12105         * guile/scm-math.c: Use C++ exception handling.
12106         * guile/scm-lazy-string.c: Use C++ exception handling.
12107         * guile/scm-frame.c: Use C++ exception handling.
12108         * guile/scm-disasm.c: Use C++ exception handling.
12109         * guile/scm-cmd.c: Use C++ exception handling.
12110         * guile/scm-breakpoint.c: Use C++ exception handling.
12111         * guile/scm-block.c: Use C++ exception handling.
12112         * guile/guile-internal.h: Use C++ exception handling.
12113         * gnu-v3-abi.c: Use C++ exception handling.
12114         * gdbtypes.c: Use C++ exception handling.
12115         * frame.c: Use C++ exception handling.
12116         * frame-unwind.c: Use C++ exception handling.
12117         * fbsd-tdep.c: Use C++ exception handling.
12118         * f-valprint.c: Use C++ exception handling.
12119         * exec.c: Use C++ exception handling.
12120         * event-top.c: Use C++ exception handling.
12121         * event-loop.c: Use C++ exception handling.
12122         * eval.c: Use C++ exception handling.
12123         * dwarf2read.c: Use C++ exception handling.
12124         * dwarf2loc.c: Use C++ exception handling.
12125         * dwarf2-frame.c: Use C++ exception handling.
12126         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12127         * dwarf-index-write.c: Use C++ exception handling.
12128         * dwarf-index-cache.c: Use C++ exception handling.
12129         * dtrace-probe.c: Use C++ exception handling.
12130         * disasm-selftests.c: Use C++ exception handling.
12131         * darwin-nat.c: Use C++ exception handling.
12132         * cp-valprint.c: Use C++ exception handling.
12133         * cp-support.c: Use C++ exception handling.
12134         * cp-abi.c: Use C++ exception handling.
12135         * corelow.c: Use C++ exception handling.
12136         * completer.c: Use C++ exception handling.
12137         * compile/compile-object-run.c: Use C++ exception handling.
12138         * compile/compile-object-load.c: Use C++ exception handling.
12139         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12140         * compile/compile-c-symbols.c: Use C++ exception handling.
12141         * common/selftest.c: Use C++ exception handling.
12142         * common/new-op.c: Use C++ exception handling.
12143         * cli/cli-script.c: Use C++ exception handling.
12144         * cli/cli-interp.c: Use C++ exception handling.
12145         * cli/cli-cmds.c: Use C++ exception handling.
12146         * c-varobj.c: Use C++ exception handling.
12147         * btrace.c: Use C++ exception handling.
12148         * breakpoint.c: Use C++ exception handling.
12149         * break-catch-throw.c: Use C++ exception handling.
12150         * arch-utils.c: Use C++ exception handling.
12151         * amd64-tdep.c: Use C++ exception handling.
12152         * ada-valprint.c: Use C++ exception handling.
12153         * ada-typeprint.c: Use C++ exception handling.
12154         * ada-lang.c: Use C++ exception handling.
12155         * aarch64-tdep.c: Use C++ exception handling.
12156
12157 2019-04-08  Tom Tromey  <tom@tromey.com>
12158
12159         * xml-support.c (gdb_xml_parser::parse): Update.
12160         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12161         * value.c (show_convenience): Update.
12162         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12163         (test_parse_flags_qcs): Update.
12164         * thread.c (thr_try_catch_cmd): Update.
12165         * target.c (target_translate_tls_address): Update.
12166         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12167         (info_frame_command_core, frame_apply_command_count): Update.
12168         * rust-exp.y (rust_lex_exception_test): Update.
12169         * riscv-tdep.c (riscv_print_one_register_info): Update.
12170         * remote.c (remote_target::enable_btrace): Update.
12171         * record-btrace.c (record_btrace_enable_warn): Update.
12172         * python/py-utils.c (gdbpy_convert_exception): Update.
12173         * printcmd.c (do_one_display, print_variable_and_value): Update.
12174         * mi/mi-main.c (mi_print_exception): Update.
12175         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12176         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12177         * linux-nat.c (linux_nat_target::attach): Update.
12178         * linux-fork.c (class scoped_switch_fork_info): Update.
12179         * infrun.c (displaced_step_prepare): Update.
12180         * infcall.c (call_function_by_hand_dummy): Update.
12181         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12182         * gnu-v3-abi.c (print_one_vtable): Update.
12183         * frame.c (get_prev_frame_always): Update.
12184         * f-valprint.c (info_common_command_for_block): Update.
12185         * exec.c (try_open_exec_file): Update.
12186         * exceptions.c (print_exception, exception_print)
12187         (exception_fprintf, exception_print_same): Update.
12188         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12189         * dwarf-index-cache.c (index_cache::store)
12190         (index_cache::lookup_gdb_index): Update.
12191         * darwin-nat.c (maybe_cache_shell): Update.
12192         * cp-valprint.c (cp_print_value_fields): Update.
12193         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12194         (gcc_cplus_symbol_address): Update.
12195         * compile/compile-c-symbols.c (gcc_convert_symbol)
12196         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12197         * common/selftest.c: Update.
12198         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12199         a std::string.
12200         (exception_try_scope_entry, exception_try_scope_exit): Don't
12201         declare.
12202         (struct exception_try_scope): Remove.
12203         (TRY): Don't use exception_try_scope.
12204         (struct gdb_exception): Add constructor, operator=.
12205         <what>: New method.
12206         (struct gdb_exception_RETURN_MASK_ALL)
12207         (struct gdb_exception_RETURN_MASK_ERROR)
12208         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12209         (struct gdb_quit_bad_alloc): Update.
12210         * common/common-exceptions.c (exception_none): Change
12211         initializer.
12212         (struct catcher) <state, exception>: Initialize inline.
12213         <prev>: Remove member.
12214         (current_catcher): Remove.
12215         (catchers): New global.
12216         (exceptions_state_mc_init): Simplify.
12217         (catcher_pop): Remove.
12218         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12219         (try_scope_depth, exception_try_scope_entry)
12220         (exception_try_scope_exit): Remove.
12221         (throw_exception_sjlj): Update.
12222         (exception_messages, exception_messages_size): Remove.
12223         (throw_it): Simplify.
12224         (gdb_exception_sliced_copy): Remove.
12225         (throw_exception_cxx): Update.
12226         * cli/cli-script.c (script_from_file): Update.
12227         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12228         Update.
12229         * ada-valprint.c (ada_val_print): Update.
12230         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12231         (create_excep_cond_exprs): Update.
12232
12233 2019-04-08  Tom Tromey  <tom@tromey.com>
12234
12235         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12236         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12237         (TRY, CATCH, END_CATCH): Remove some definitions.
12238         * common/common-exceptions.c: Don't use GDB_XCPT.
12239         (catcher_list_size): Remove.
12240         (throw_exception, throw_it): Simplify.
12241
12242 2019-04-05  Tom Tromey  <tom@tromey.com>
12243
12244         Revert the header-sorting patch.
12245         * ft32-tdep.c: Revert.
12246         * frv-tdep.c: Revert.
12247         * frv-linux-tdep.c: Revert.
12248         * frame.c: Revert.
12249         * frame-unwind.c: Revert.
12250         * frame-base.c: Revert.
12251         * fork-child.c: Revert.
12252         * findvar.c: Revert.
12253         * findcmd.c: Revert.
12254         * filesystem.c: Revert.
12255         * filename-seen-cache.h: Revert.
12256         * filename-seen-cache.c: Revert.
12257         * fbsd-tdep.c: Revert.
12258         * fbsd-nat.h: Revert.
12259         * fbsd-nat.c: Revert.
12260         * f-valprint.c: Revert.
12261         * f-typeprint.c: Revert.
12262         * f-lang.c: Revert.
12263         * extension.h: Revert.
12264         * extension.c: Revert.
12265         * extension-priv.h: Revert.
12266         * expprint.c: Revert.
12267         * exec.h: Revert.
12268         * exec.c: Revert.
12269         * exceptions.c: Revert.
12270         * event-top.c: Revert.
12271         * event-loop.c: Revert.
12272         * eval.c: Revert.
12273         * elfread.c: Revert.
12274         * dwarf2read.h: Revert.
12275         * dwarf2read.c: Revert.
12276         * dwarf2loc.c: Revert.
12277         * dwarf2expr.h: Revert.
12278         * dwarf2expr.c: Revert.
12279         * dwarf2-frame.c: Revert.
12280         * dwarf2-frame-tailcall.c: Revert.
12281         * dwarf-index-write.h: Revert.
12282         * dwarf-index-write.c: Revert.
12283         * dwarf-index-common.c: Revert.
12284         * dwarf-index-cache.h: Revert.
12285         * dwarf-index-cache.c: Revert.
12286         * dummy-frame.c: Revert.
12287         * dtrace-probe.c: Revert.
12288         * disasm.h: Revert.
12289         * disasm.c: Revert.
12290         * disasm-selftests.c: Revert.
12291         * dictionary.c: Revert.
12292         * dicos-tdep.c: Revert.
12293         * demangle.c: Revert.
12294         * dcache.h: Revert.
12295         * dcache.c: Revert.
12296         * darwin-nat.h: Revert.
12297         * darwin-nat.c: Revert.
12298         * darwin-nat-info.c: Revert.
12299         * d-valprint.c: Revert.
12300         * d-namespace.c: Revert.
12301         * d-lang.c: Revert.
12302         * ctf.c: Revert.
12303         * csky-tdep.c: Revert.
12304         * csky-linux-tdep.c: Revert.
12305         * cris-tdep.c: Revert.
12306         * cris-linux-tdep.c: Revert.
12307         * cp-valprint.c: Revert.
12308         * cp-support.c: Revert.
12309         * cp-namespace.c: Revert.
12310         * cp-abi.c: Revert.
12311         * corelow.c: Revert.
12312         * corefile.c: Revert.
12313         * continuations.c: Revert.
12314         * completer.h: Revert.
12315         * completer.c: Revert.
12316         * complaints.c: Revert.
12317         * coffread.c: Revert.
12318         * coff-pe-read.c: Revert.
12319         * cli-out.h: Revert.
12320         * cli-out.c: Revert.
12321         * charset.c: Revert.
12322         * c-varobj.c: Revert.
12323         * c-valprint.c: Revert.
12324         * c-typeprint.c: Revert.
12325         * c-lang.c: Revert.
12326         * buildsym.c: Revert.
12327         * buildsym-legacy.c: Revert.
12328         * build-id.h: Revert.
12329         * build-id.c: Revert.
12330         * btrace.c: Revert.
12331         * bsd-uthread.c: Revert.
12332         * breakpoint.h: Revert.
12333         * breakpoint.c: Revert.
12334         * break-catch-throw.c: Revert.
12335         * break-catch-syscall.c: Revert.
12336         * break-catch-sig.c: Revert.
12337         * blockframe.c: Revert.
12338         * block.c: Revert.
12339         * bfin-tdep.c: Revert.
12340         * bfin-linux-tdep.c: Revert.
12341         * bfd-target.c: Revert.
12342         * bcache.c: Revert.
12343         * ax-general.c: Revert.
12344         * ax-gdb.h: Revert.
12345         * ax-gdb.c: Revert.
12346         * avr-tdep.c: Revert.
12347         * auxv.c: Revert.
12348         * auto-load.c: Revert.
12349         * arm-wince-tdep.c: Revert.
12350         * arm-tdep.c: Revert.
12351         * arm-symbian-tdep.c: Revert.
12352         * arm-pikeos-tdep.c: Revert.
12353         * arm-obsd-tdep.c: Revert.
12354         * arm-nbsd-tdep.c: Revert.
12355         * arm-nbsd-nat.c: Revert.
12356         * arm-linux-tdep.c: Revert.
12357         * arm-linux-nat.c: Revert.
12358         * arm-fbsd-tdep.c: Revert.
12359         * arm-fbsd-nat.c: Revert.
12360         * arm-bsd-tdep.c: Revert.
12361         * arch-utils.c: Revert.
12362         * arc-tdep.c: Revert.
12363         * arc-newlib-tdep.c: Revert.
12364         * annotate.h: Revert.
12365         * annotate.c: Revert.
12366         * amd64-windows-tdep.c: Revert.
12367         * amd64-windows-nat.c: Revert.
12368         * amd64-tdep.c: Revert.
12369         * amd64-sol2-tdep.c: Revert.
12370         * amd64-obsd-tdep.c: Revert.
12371         * amd64-obsd-nat.c: Revert.
12372         * amd64-nbsd-tdep.c: Revert.
12373         * amd64-nbsd-nat.c: Revert.
12374         * amd64-nat.c: Revert.
12375         * amd64-linux-tdep.c: Revert.
12376         * amd64-linux-nat.c: Revert.
12377         * amd64-fbsd-tdep.c: Revert.
12378         * amd64-fbsd-nat.c: Revert.
12379         * amd64-dicos-tdep.c: Revert.
12380         * amd64-darwin-tdep.c: Revert.
12381         * amd64-bsd-nat.c: Revert.
12382         * alpha-tdep.c: Revert.
12383         * alpha-obsd-tdep.c: Revert.
12384         * alpha-nbsd-tdep.c: Revert.
12385         * alpha-mdebug-tdep.c: Revert.
12386         * alpha-linux-tdep.c: Revert.
12387         * alpha-linux-nat.c: Revert.
12388         * alpha-bsd-tdep.c: Revert.
12389         * alpha-bsd-nat.c: Revert.
12390         * aix-thread.c: Revert.
12391         * agent.c: Revert.
12392         * addrmap.c: Revert.
12393         * ada-varobj.c: Revert.
12394         * ada-valprint.c: Revert.
12395         * ada-typeprint.c: Revert.
12396         * ada-tasks.c: Revert.
12397         * ada-lang.c: Revert.
12398         * aarch64-tdep.c: Revert.
12399         * aarch64-ravenscar-thread.c: Revert.
12400         * aarch64-newlib-tdep.c: Revert.
12401         * aarch64-linux-tdep.c: Revert.
12402         * aarch64-linux-nat.c: Revert.
12403         * aarch64-fbsd-tdep.c: Revert.
12404         * aarch64-fbsd-nat.c: Revert.
12405         * aarch32-linux-nat.c: Revert.
12406
12407 2019-04-05  Tom Tromey  <tom@tromey.com>
12408
12409         * ft32-tdep.c: Sort headers.
12410         * frv-tdep.c: Sort headers.
12411         * frv-linux-tdep.c: Sort headers.
12412         * frame.c: Sort headers.
12413         * frame-unwind.c: Sort headers.
12414         * frame-base.c: Sort headers.
12415         * fork-child.c: Sort headers.
12416         * findvar.c: Sort headers.
12417         * findcmd.c: Sort headers.
12418         * filesystem.c: Sort headers.
12419         * filename-seen-cache.h: Sort headers.
12420         * filename-seen-cache.c: Sort headers.
12421         * fbsd-tdep.c: Sort headers.
12422         * fbsd-nat.h: Sort headers.
12423         * fbsd-nat.c: Sort headers.
12424         * f-valprint.c: Sort headers.
12425         * f-typeprint.c: Sort headers.
12426         * f-lang.c: Sort headers.
12427         * extension.h: Sort headers.
12428         * extension.c: Sort headers.
12429         * extension-priv.h: Sort headers.
12430         * expprint.c: Sort headers.
12431         * exec.h: Sort headers.
12432         * exec.c: Sort headers.
12433         * exceptions.c: Sort headers.
12434         * event-top.c: Sort headers.
12435         * event-loop.c: Sort headers.
12436         * eval.c: Sort headers.
12437         * elfread.c: Sort headers.
12438         * dwarf2read.h: Sort headers.
12439         * dwarf2read.c: Sort headers.
12440         * dwarf2loc.c: Sort headers.
12441         * dwarf2expr.h: Sort headers.
12442         * dwarf2expr.c: Sort headers.
12443         * dwarf2-frame.c: Sort headers.
12444         * dwarf2-frame-tailcall.c: Sort headers.
12445         * dwarf-index-write.h: Sort headers.
12446         * dwarf-index-write.c: Sort headers.
12447         * dwarf-index-common.c: Sort headers.
12448         * dwarf-index-cache.h: Sort headers.
12449         * dwarf-index-cache.c: Sort headers.
12450         * dummy-frame.c: Sort headers.
12451         * dtrace-probe.c: Sort headers.
12452         * disasm.h: Sort headers.
12453         * disasm.c: Sort headers.
12454         * disasm-selftests.c: Sort headers.
12455         * dictionary.c: Sort headers.
12456         * dicos-tdep.c: Sort headers.
12457         * demangle.c: Sort headers.
12458         * dcache.h: Sort headers.
12459         * dcache.c: Sort headers.
12460         * darwin-nat.h: Sort headers.
12461         * darwin-nat.c: Sort headers.
12462         * darwin-nat-info.c: Sort headers.
12463         * d-valprint.c: Sort headers.
12464         * d-namespace.c: Sort headers.
12465         * d-lang.c: Sort headers.
12466         * ctf.c: Sort headers.
12467         * csky-tdep.c: Sort headers.
12468         * csky-linux-tdep.c: Sort headers.
12469         * cris-tdep.c: Sort headers.
12470         * cris-linux-tdep.c: Sort headers.
12471         * cp-valprint.c: Sort headers.
12472         * cp-support.c: Sort headers.
12473         * cp-namespace.c: Sort headers.
12474         * cp-abi.c: Sort headers.
12475         * corelow.c: Sort headers.
12476         * corefile.c: Sort headers.
12477         * continuations.c: Sort headers.
12478         * completer.h: Sort headers.
12479         * completer.c: Sort headers.
12480         * complaints.c: Sort headers.
12481         * coffread.c: Sort headers.
12482         * coff-pe-read.c: Sort headers.
12483         * cli-out.h: Sort headers.
12484         * cli-out.c: Sort headers.
12485         * charset.c: Sort headers.
12486         * c-varobj.c: Sort headers.
12487         * c-valprint.c: Sort headers.
12488         * c-typeprint.c: Sort headers.
12489         * c-lang.c: Sort headers.
12490         * buildsym.c: Sort headers.
12491         * buildsym-legacy.c: Sort headers.
12492         * build-id.h: Sort headers.
12493         * build-id.c: Sort headers.
12494         * btrace.c: Sort headers.
12495         * bsd-uthread.c: Sort headers.
12496         * breakpoint.h: Sort headers.
12497         * breakpoint.c: Sort headers.
12498         * break-catch-throw.c: Sort headers.
12499         * break-catch-syscall.c: Sort headers.
12500         * break-catch-sig.c: Sort headers.
12501         * blockframe.c: Sort headers.
12502         * block.c: Sort headers.
12503         * bfin-tdep.c: Sort headers.
12504         * bfin-linux-tdep.c: Sort headers.
12505         * bfd-target.c: Sort headers.
12506         * bcache.c: Sort headers.
12507         * ax-general.c: Sort headers.
12508         * ax-gdb.h: Sort headers.
12509         * ax-gdb.c: Sort headers.
12510         * avr-tdep.c: Sort headers.
12511         * auxv.c: Sort headers.
12512         * auto-load.c: Sort headers.
12513         * arm-wince-tdep.c: Sort headers.
12514         * arm-tdep.c: Sort headers.
12515         * arm-symbian-tdep.c: Sort headers.
12516         * arm-pikeos-tdep.c: Sort headers.
12517         * arm-obsd-tdep.c: Sort headers.
12518         * arm-nbsd-tdep.c: Sort headers.
12519         * arm-nbsd-nat.c: Sort headers.
12520         * arm-linux-tdep.c: Sort headers.
12521         * arm-linux-nat.c: Sort headers.
12522         * arm-fbsd-tdep.c: Sort headers.
12523         * arm-fbsd-nat.c: Sort headers.
12524         * arm-bsd-tdep.c: Sort headers.
12525         * arch-utils.c: Sort headers.
12526         * arc-tdep.c: Sort headers.
12527         * arc-newlib-tdep.c: Sort headers.
12528         * annotate.h: Sort headers.
12529         * annotate.c: Sort headers.
12530         * amd64-windows-tdep.c: Sort headers.
12531         * amd64-windows-nat.c: Sort headers.
12532         * amd64-tdep.c: Sort headers.
12533         * amd64-sol2-tdep.c: Sort headers.
12534         * amd64-obsd-tdep.c: Sort headers.
12535         * amd64-obsd-nat.c: Sort headers.
12536         * amd64-nbsd-tdep.c: Sort headers.
12537         * amd64-nbsd-nat.c: Sort headers.
12538         * amd64-nat.c: Sort headers.
12539         * amd64-linux-tdep.c: Sort headers.
12540         * amd64-linux-nat.c: Sort headers.
12541         * amd64-fbsd-tdep.c: Sort headers.
12542         * amd64-fbsd-nat.c: Sort headers.
12543         * amd64-dicos-tdep.c: Sort headers.
12544         * amd64-darwin-tdep.c: Sort headers.
12545         * amd64-bsd-nat.c: Sort headers.
12546         * alpha-tdep.c: Sort headers.
12547         * alpha-obsd-tdep.c: Sort headers.
12548         * alpha-nbsd-tdep.c: Sort headers.
12549         * alpha-mdebug-tdep.c: Sort headers.
12550         * alpha-linux-tdep.c: Sort headers.
12551         * alpha-linux-nat.c: Sort headers.
12552         * alpha-bsd-tdep.c: Sort headers.
12553         * alpha-bsd-nat.c: Sort headers.
12554         * aix-thread.c: Sort headers.
12555         * agent.c: Sort headers.
12556         * addrmap.c: Sort headers.
12557         * ada-varobj.c: Sort headers.
12558         * ada-valprint.c: Sort headers.
12559         * ada-typeprint.c: Sort headers.
12560         * ada-tasks.c: Sort headers.
12561         * ada-lang.c: Sort headers.
12562         * aarch64-tdep.c: Sort headers.
12563         * aarch64-ravenscar-thread.c: Sort headers.
12564         * aarch64-newlib-tdep.c: Sort headers.
12565         * aarch64-linux-tdep.c: Sort headers.
12566         * aarch64-linux-nat.c: Sort headers.
12567         * aarch64-fbsd-tdep.c: Sort headers.
12568         * aarch64-fbsd-nat.c: Sort headers.
12569         * aarch32-linux-nat.c: Sort headers.
12570
12571 2019-04-04  Tom Tromey  <tom@tromey.com>
12572
12573         * varobj.c (varobj_create): Update.
12574         * rust-exp.y (struct rust_parser) <update_innermost_block,
12575         lookup_symbol>: New methods.
12576         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12577         Rename.
12578         (rust_parser::rust_lookup_type)
12579         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12580         * printcmd.c (display_command, do_one_display): Update.
12581         * parser-defs.h (struct parser_state) <parser_state>: Add
12582         "tracker" parameter.
12583         (block_tracker): New member.
12584         (class innermost_block_tracker) <innermost_block_tracker>: Add
12585         "types" parameter.
12586         <reset>: Remove method.
12587         (innermost_block): Don't declare.
12588         (null_post_parser): Update.
12589         * parse.c (innermost_block): Remove global.
12590         (write_dollar_variable): Update.
12591         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12592         Remove "tracker_types" parameter.
12593         (parse_expression): Add "tracker" parameter.
12594         (parse_expression_for_completion): Update.
12595         (null_post_parser): Add "tracker" parameter.
12596         * p-exp.y: Update rules.
12597         * m2-exp.y: Update rules.
12598         * language.h (struct language_defn) <la_post_parser>: Add
12599         "tracker" parameter.
12600         * go-exp.y: Update rules.
12601         * f-exp.y: Update rules.
12602         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12603         parameter.
12604         * d-exp.y: Update rules.
12605         * c-exp.y: Update rules.
12606         * breakpoint.c (set_breakpoint_condition): Create an
12607         innermost_block_tracker.
12608         (watch_command_1): Likewise.
12609         * ada-lang.c (resolve): Add "tracker" parameter.
12610         (resolve_subexp): Likewise.
12611         * ada-exp.y (write_var_from_sym): Update.
12612
12613 2019-04-04  Tom Tromey  <tom@tromey.com>
12614
12615         * type-stack.h: New file.
12616         * type-stack.c: New file.
12617         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12618         type-stack.h.
12619         (insert_into_type_stack, insert_type, push_type, push_type_int)
12620         (insert_type_address_space, pop_type, pop_type_int)
12621         (pop_typelist, pop_type_stack, append_type_stack)
12622         (push_type_stack, get_type_stack, push_typelist)
12623         (follow_type_instance_flags, follow_types): Don't declare.
12624         * parse.c (type_stack): Remove global.
12625         (parse_exp_in_context): Update.
12626         (insert_into_type_stack, insert_type, push_type, push_type_int)
12627         (insert_type_address_space, pop_type, pop_type_int)
12628         (pop_typelist, pop_type_stack, append_type_stack)
12629         (push_type_stack, get_type_stack, push_typelist)
12630         (follow_type_instance_flags, follow_types): Remove (moved to
12631         type-stack.c).
12632         * f-exp.y (type_stack): New global.
12633         Update rules.
12634         (push_kind_type, f_parse): Update.
12635         * d-exp.y (type_stack): New global.
12636         Update rules.
12637         (d_parse): Update.
12638         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12639         Update rules.
12640         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12641         (HFILES_NO_SRCDIR): Add type-stack.h.
12642
12643 2019-04-04  Tom Tromey  <tom@tromey.com>
12644
12645         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12646         (rust_parser::convert_ast_to_expression, rust_parse)
12647         (rust_lex_test_completion, rust_lex_tests): Update.
12648         * parser-defs.h (struct expr_completion_state): New.
12649         (struct parser_state) <parser_state>: Add completion parameter.
12650         <mark_struct_expression, mark_completion_tag>: New methods.
12651         <parse_completion, m_completion_state>: New members.
12652         (prefixify_expression, null_post_parser): Update.
12653         (mark_struct_expression, mark_completion_tag): Don't declare.
12654         * parse.c (parse_completion, expout_last_struct)
12655         (expout_tag_completion_type, expout_completion_name): Remove
12656         globals.
12657         (parser_state::mark_struct_expression)
12658         (parser_state::mark_completion_tag): Now methods.
12659         (prefixify_expression): Add last_struct parameter.
12660         (prefixify_subexp): Likewise.
12661         (parse_exp_1): Update.
12662         (parse_exp_in_context): Add cstate parameter.  Update.
12663         (parse_expression_for_completion): Create an
12664         expr_completion_state.
12665         (null_post_parser): Add "completion" parameter.
12666         * p-exp.y: Update rules.
12667         (yylex): Update.
12668         * language.h (struct language_defn) <la_post_parser>: Add
12669         "completing" parameter.
12670         * go-exp.y: Update rules.
12671         (lex_one_token): Update.
12672         * expression.h (parse_completion): Don't declare.
12673         * d-exp.y: Update rules.
12674         (lex_one_token): Update rules.
12675         * c-exp.y: Update rules.
12676         (lex_one_token): Update.
12677         * ada-lang.c (resolve): Add "parse_completion" parameter.
12678         (resolve_subexp): Likewise.
12679         (ada_resolve_function): Likewise.
12680
12681 2019-04-04  Tom Tromey  <tom@tromey.com>
12682
12683         * parser-defs.h (struct parser_state) <start_arglist,
12684         end_arglist>: New methods.
12685         <arglist_len, m_funcall_chain>: New members.
12686         (arglist_len, start_arglist, end_arglist): Don't declare.
12687         * parse.c (arglist_len, funcall_chain): Remove global.
12688         (start_arglist, end_arglist): Remove functions.
12689         (parse_exp_in_context): Update.
12690         * p-exp.y: Update rules.
12691         * m2-exp.y: Update rules.
12692         * go-exp.y: Update rules.
12693         * f-exp.y: Update rules.
12694         * d-exp.y: Update rules.
12695         * c-exp.y: Update rules.
12696
12697 2019-04-04  Tom Tromey  <tom@tromey.com>
12698
12699         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12700         lex_operator, push_back>: New methods.
12701         Update all rules.
12702         (rust_parser::lex_hex, lex_escape): Rename and update.
12703         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12704         (rust_parser::lex_operator): Rename and update.
12705         (rust_parser::lex_number, rustyylex, rustyyerror)
12706         (rust_lex_test_init, rust_lex_test_sequence)
12707         (rust_lex_test_push_back, rust_lex_tests): Update.
12708         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12709         parameter.
12710         <lexptr, prev_lexptr>: New members.
12711         (lexptr, prev_lexptr): Don't declare.
12712         * parse.c (lexptr, prev_lexptr): Remove globals.
12713         (parse_exp_in_context): Update.
12714         * p-exp.y (yylex, yyerror): Update.
12715         * m2-exp.y (parse_number, yylex, yyerror): Update.
12716         * go-exp.y (lex_one_token, yyerror): Update.
12717         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12718         * d-exp.y (lex_one_token, yyerror): Update.
12719         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12720         (lex_one_token, yyerror): Update.
12721         * ada-lex.l (YY_INPUT): Update.
12722         (rewind_to_char): Update.
12723         * ada-exp.y (yyerror): Update.
12724
12725 2019-04-04  Tom Tromey  <tom@tromey.com>
12726
12727         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12728         * parser-defs.h (struct parser_state) <parser_state>: Add new
12729         parameter.
12730         <comma_terminates>: New member.
12731         (comma_terminates): Don't declare global.
12732         * parse.c (comma_terminates): Remove global.
12733         (parse_exp_in_context): Update.
12734         * p-exp.y (yylex): Update.
12735         * m2-exp.y (yylex): Update.
12736         * go-exp.y (lex_one_token): Update.
12737         * f-exp.y (yylex): Update.
12738         * d-exp.y (lex_one_token): Update.
12739         * c-exp.y (lex_one_token): Update.
12740         * ada-lex.l: Update.
12741
12742 2019-04-04  Tom Tromey  <tom@tromey.com>
12743
12744         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12745         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12746         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12747         * parser-defs.h (paren_depth): Don't declare.
12748         * parse.c (paren_depth): Remove global.
12749         (parse_exp_in_context): Update.
12750         * p-exp.y (paren_depth): New global.
12751         (pascal_parse): Initialize it.
12752         * m2-exp.y (paren_depth): New global.
12753         (m2_parse): Initialize it.
12754         * go-exp.y (paren_depth): New global.
12755         (go_parse): Initialize it.
12756         * f-exp.y (paren_depth): New global.
12757         (f_parse): Initialize it.
12758         * d-exp.y (paren_depth): New global.
12759         (d_parse): Initialize it.
12760         * c-exp.y (paren_depth): New global.
12761         (c_parse): Initialize it.
12762         * ada-lex.l (paren_depth): New global.
12763         (lexer_init): Initialize it.
12764
12765 2019-04-04  Tom Tromey  <tom@tromey.com>
12766
12767         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12768         (rust_parser::convert_ast_to_type)
12769         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12770         * parser-defs.h (struct parser_state) <parser_state>: Add
12771         parameters.  Initialize new members.
12772         <expression_context_block, expression_context_pc>: New members.
12773         * parse.c (expression_context_block, expression_context_pc):
12774         Remove globals.
12775         (parse_exp_in_context): Update.
12776         * p-exp.y: Update all rules.
12777         (yylex): Update.
12778         * m2-exp.y: Update all rules.
12779         (yylex): Update.
12780         * go-exp.y (yylex): Update.
12781         * f-exp.y (yylex): Update.
12782         * d-exp.y: Update all rules.
12783         (yylex): Update.
12784         * c-exp.y: Update all rules.
12785         (lex_one_token, classify_name, yylex, c_parse): Update.
12786         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12787
12788 2019-04-04  Tom Tromey  <tom@tromey.com>
12789
12790         * gdbarch.h, gdbarch.c: Rebuild.
12791         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12792         * stap-probe.h:
12793         (struct stap_parse_info): Replace "parser_state" with
12794         "expr_builder".
12795         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12796         (parser_state): New class.
12797         * parse.c (expr_builder): Rename.
12798         (expr_builder::release): Rename.
12799         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12800         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12801         (write_exp_elt_longcst, write_exp_elt_floatcst)
12802         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12803         (write_exp_string_vector, write_exp_bitstring)
12804         (write_exp_msymbol, mark_struct_expression)
12805         (write_dollar_variable)
12806         (insert_type_address_space, increase_expout_size): Replace
12807         "parser_state" with "expr_builder".
12808         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12809         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12810         "parser_state" with "expr_builder".
12811
12812 2019-04-04  Tom Tromey  <tom@tromey.com>
12813
12814         * rust-exp.y: Replace "parse_language" with method call.
12815         * p-exp.y:
12816         (yylex): Replace "parse_language" with method call.
12817         * m2-exp.y:
12818         (yylex): Replace "parse_language" with method call.
12819         * go-exp.y (classify_name): Replace "parse_language" with method
12820         call.
12821         * f-exp.y (yylex): Replace "parse_language" with method call.
12822         * d-exp.y (lex_one_token): Replace "parse_language" with method
12823         call.
12824         * c-exp.y:
12825         (lex_one_token, classify_name, yylex): Replace "parse_language"
12826         with method call.
12827         * ada-exp.y (find_primitive_type, type_char)
12828         (type_system_address): Replace "parse_language" with method call.
12829
12830 2019-04-04  Tom Tromey  <tom@tromey.com>
12831
12832         * rust-exp.y: Replace "parse_gdbarch" with method call.
12833         * parse.c (write_dollar_variable, insert_type_address_space):
12834         Replace "parse_gdbarch" with method call.
12835         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12836         call.
12837         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12838         call.
12839         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12840         "parse_gdbarch" with method call.
12841         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12842         with method call.
12843         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12844         "parse_gdbarch" with method call.
12845         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12846         "parse_gdbarch" with method call.
12847         * c-exp.y (parse_type, parse_number, classify_name): Replace
12848         "parse_gdbarch" with method call.
12849         * ada-lex.l: Replace "parse_gdbarch" with method call.
12850         * ada-exp.y (parse_type, find_primitive_type, type_char)
12851         (type_system_address): Replace "parse_gdbarch" with method call.
12852
12853 2019-04-04  Tom Tromey  <tom@tromey.com>
12854
12855         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12856         * stap-probe.c (stap_parse_argument): Update.
12857         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12858         initial_size parameter.
12859         * rust-exp.y (rust_lex_tests): Update.
12860         * parse.c (parser_state): Update.
12861         (parse_exp_in_context): Update.
12862         * parser-defs.h (struct parser_state) <parser_state>: Remove
12863         "initial_size" parameter.
12864
12865 2019-04-04  Tom Tromey  <tom@tromey.com>
12866
12867         * parser-defs.h (increase_expout_size): Don't declare.
12868         * parse.c (increase_expout_size): Now static.
12869
12870 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12871
12872         * gnu-nat.c (gnu_nat_target::wait): Fix
12873         target_waitstatus_to_string call.
12874
12875 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12876
12877         * eval.c (evaluate_subexp_standard): Handle internal functions
12878         during Fortran function call handling.
12879
12880 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12881
12882         * NEWS: Mention new internal functions.
12883         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12884         (read_base_type): Use dwarf2_init_complex_target_type.
12885         * value.c (creal_internal_fn): New function.
12886         (cimag_internal_fn): New function.
12887         (_initialize_values): Register new internal functions.
12888
12889 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12890
12891         * infrun.c (stop_all_threads): If debug_infrun, always
12892         trace the wait status after wait_one, using
12893         target_waitstatus_to_string and target_pid_to_str.
12894         (handle_inferior_event): Replace various trace of
12895         wait status kind by a single trace.
12896         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12897         wait status kind image by target_waitstatus_to_string.
12898         * target/waitstatus.c (target_waitstatus_to_string): Fix
12899         obsolete comment.
12900
12901 2019-04-01  Tom Tromey  <tromey@adacore.com>
12902
12903         PR symtab/23331:
12904         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12905
12906 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12907             Pedro Alves  <palves@redhat.com>
12908
12909         * top.c (quit_force): Call 'finalize_values'.
12910         * value.c (finalize_values): New function.
12911         * value.h (finalize_values): Declare.
12912
12913 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12914
12915         * NEWS: Announce $_gdb_major and $_gdb_minor.
12916
12917         * top.c (init_gdb_version_vars): New function.
12918         (gdb_init): Call init_gdb_version_vars.
12919
12920 2019-03-29  Tom Tromey  <tromey@adacore.com>
12921
12922         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12923         help text.  Remove dead code.
12924
12925 2019-03-29  Keith Seitz  <keiths@redhat.com>
12926
12927         From Siddhesh Poyarekar:
12928         * f-lang.h (f77_get_upperbound): Return LONGEST.
12929         (f77_get_lowerbound): Likewise.
12930         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12931         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12932         print them.
12933         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12934         plongest to format print it.
12935         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12936         (f77_get_upperbound): Likewise.
12937         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12938         LOWER_BOUND to LONGEST.
12939         (f77_create_arrayprint_offset_tbl): Likewise.
12940
12941 2019-03-29  Keith Seitz  <keiths@redhat.com>
12942
12943         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12944         %s/pulongest for TYPE_LENGTH instead of %d in format
12945         strings.
12946         * ada-typerint.c (ada_print_type): Likewise.
12947         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12948         * compile/compile-c-support.c (generate_register_struct): Likewise.
12949         * gdbtypes.c (recursive_dump_type): Likewise.
12950         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12951         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12952         instead of %d in format strings.
12953         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12954         to std::min to ULONGEST.
12955         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12956         instead of %d in format strings.
12957         * tracepoint.c (info_scope_command): Likewise.
12958         * typeprint.c (print_offset_data::update)
12959         (print_offset_data::finish): Likewise.
12960         * xtensa-tdep.c (xtensa_store_return_value)
12961         (xtensa_push_dummy_call): Likewise.
12962
12963 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12964
12965         * windows-nat.c (display_selector): Fixed format specifications
12966         for 64-bit Cygwin.
12967
12968 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12969
12970         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12971
12972 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12973
12974         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12975         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12976         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12977         (nios2_linux_init_abi): Install it.
12978
12979 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12980
12981         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12982
12983 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12984
12985         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12986
12987 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12988             Tom Tromey  <tromey@adacore.com>
12989
12990         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12991
12992 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12993
12994         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12995         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12996         method to compute the bounds of range types. Also print "[evaluated]"
12997         if the bounds' values come from a dynamic evaluation.
12998
12999 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13000
13001         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13002         whitespace when pretty printing is on.
13003
13004 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13005
13006         * ppc-linux-nat.c: Add include.
13007
13008 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13009
13010         * NEWS: Mention AArch64 Pointer Authentication.
13011
13012 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13013
13014         * arm-linux-nat.c: Add include.
13015
13016 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13017
13018         * source-cache.c (source_cache::get_source_lines): Re-read
13019         fullname after calling open_source_file.
13020
13021 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13022
13023         * NEWS: Mention TLS support for FreeBSD.
13024
13025 2019-03-25  Tom Tromey  <tromey@adacore.com>
13026
13027         * minsyms.c (BUNCH_SIZE): Update comment.
13028         (~minimal_symbol_reader): Remove old comment.
13029         (compact_minimal_symbols): Update comment.
13030         (minimal_symbol_reader::install): Remove old comment.  Update
13031         other comments.
13032
13033 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13034
13035         * s390-linux-nat.c: Add include.
13036
13037 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13038
13039         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13040         Call linux_get_hwcap.
13041         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13042         Likewise.
13043         (aarch64_linux_get_hwcap): Remove function.
13044         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13045         declaration.
13046         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13047         linux_get_hwcap.
13048         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13049         * linux-tdep.c (linux_get_hwcap): Add function.
13050         (linux_get_hwcap2): Likewise.
13051         * linux-tdep.h (linux_get_hwcap): Add declaration.
13052         (linux_get_hwcap2): Likewise.
13053         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13054         (ppc_linux_get_hwcap2): Likewise.
13055         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13056         linux_get_hwcap.
13057         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13058         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13059         (ppc_linux_nat_target::read_description): Likewise.
13060         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13061         * s390-linux-nat.c: Likewise.
13062         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13063
13064 2019-03-24  Tom Tromey  <tom@tromey.com>
13065
13066         * ada-lang.c (standard_lookup): Simplify initialization.
13067         (ada_lookup_symbol_nonlocal): Simplify return.
13068         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13069         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13070         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13071         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13072         initialization.
13073         * solib.c (solib_global_lookup): Simplify.
13074         * symtab.c (null_block_symbol): Remove.
13075         (symbol_cache_lookup): Simplify returns.
13076         (lookup_language_this): Simplify returns.
13077         (lookup_symbol_aux): Simplify return.
13078         (lookup_local_symbol): Simplify returns.
13079         (lookup_global_symbol_from_objfile): Simplify return.
13080         (lookup_symbol_in_objfile_symtabs)
13081         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13082         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13083         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13084         * cp-namespace.c (cp_lookup_bare_symbol)
13085         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13086         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13087         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13088         (cp_lookup_symbol_via_imports): Simplify initialization.
13089         (find_symbol_in_baseclass): Likewise.
13090         * symtab.h (null_block_symbol): Remove.
13091         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13092         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13093         (d_lookup_symbol_module): Likewise.
13094         (find_symbol_in_baseclass): Simplify initialization.
13095
13096 2019-03-24  Tom Tromey  <tom@tromey.com>
13097
13098         * expression.h: Don't include symtab.h.
13099         (struct block): Forward declare.
13100
13101 2019-03-24  Tom Tromey  <tom@tromey.com>
13102
13103         * c-exp.y (typebase): Remove casts.
13104         * gdbtypes.c (lookup_unsigned_typename, )
13105         (lookup_signed_typename): Remove cast.
13106         * eval.c (parse_to_comma_and_eval): Remove cast.
13107         * parse.c (write_dollar_variable): Remove cast.
13108         * block.h (struct block) <superblock>: Now const.
13109         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13110         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13111         (map_block): Make "block" const.
13112         * symfile.h (struct quick_symbol_functions)
13113         <map_matching_symbols>: Constify block argument to "callback".
13114         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13115         const.
13116         (find_pc_sect_compunit_symtab): Make "b" const.
13117         (find_symbol_at_address): Likewise.
13118         (search_symbols): Likewise.
13119         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13120         (dw2_debug_names_lookup_symbol): Likewise.
13121         (dw2_map_matching_symbols): Update.
13122         * p-valprint.c (pascal_val_print): Remove "block".
13123         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13124         (aux_add_nonlocal_symbols): Make "block" const.
13125         (resolve_subexp): Remove cast.
13126         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13127         const.
13128         (iterate_over_file_blocks): Likewise.
13129         * f-exp.y (%union) <bval>: Remove.
13130         * coffread.c (patch_opaque_types): Make "b" const.
13131         * spu-tdep.c (spu_catch_start): Make "block" const.
13132         * c-valprint.c (print_unpacked_pointer): Remove "block".
13133         * symmisc.c (dump_symtab_1): Make "b" const.
13134         (block_depth): Make "block" const.
13135         * d-exp.y (%union) <bval>: Remove.
13136         * cp-support.h (cp_lookup_rtti_type): Update.
13137         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13138         * psymtab.c (psym_lookup_symbol): Make "block" const.
13139         (maintenance_check_psymtabs): Make "b" const.
13140         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13141         (enumerate_locals, enumerate_args): Update.
13142         * python/py-symtab.c (stpy_global_block): Make "block" const.
13143         (stpy_static_block): Likewise.
13144         * inline-frame.c (block_starting_point_at): Make "new_block"
13145         const.
13146         * block.c (find_block_in_blockvector): Make return type const.
13147         (blockvector_for_pc_sect): Make "b" const.
13148         (find_block_in_blockvector): Make "b" const.
13149
13150 2019-03-23  Tom Tromey  <tom@tromey.com>
13151
13152         * varobj.c (varobj_create): Update.
13153         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13154         * printcmd.c (display_command, do_one_display): Don't reset
13155         innermost_block.
13156         * parser-defs.h (enum innermost_block_tracker_type): Move to
13157         expression.h.
13158         (innermost_block): Update comment.
13159         * parse.c (parse_exp_1): Add tracker_types parameter.
13160         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13161         tracker_types parameter.  Reset innermost_block.
13162         (parse_exp_in_context): Remove.
13163         (parse_expression_for_completion): Update.
13164         * objfiles.c (~objfile): Don't reset expression_context_block or
13165         innermost_block.
13166         * expression.h (enum innermost_block_tracker_type): Move from
13167         parser-defs.h.
13168         (parse_exp_1): Add tracker_types parameter.
13169         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13170         reset innermost_block.
13171
13172 2019-03-23  Tom Tromey  <tom@tromey.com>
13173
13174         * objfiles.h: Include bcache.h.
13175
13176 2019-03-23  Tom Tromey  <tom@tromey.com>
13177
13178         * linespec.c (get_current_search_block): Use
13179         scoped_restore_current_language.
13180         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13181
13182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13183             Jiong Wang  <jiong.wang@arm.com>
13184
13185         * aarch64-linux-tdep.c
13186         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13187         section.
13188         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13189
13190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13191             Jiong Wang  <jiong.wang@arm.com>
13192
13193         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13194         instructions.
13195         (aarch64_analyze_prologue_test): Add PACIASP test.
13196         (aarch64_prologue_prev_register): Unmask PC value.
13197
13198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13199             Jiong Wang  <jiong.wang@arm.com>
13200
13201         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13202         (aarch64_dwarf2_prev_register): Unmask PC value.
13203         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13204         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13205         DW_CFA_AARCH64_negate_ra_state.
13206         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13207
13208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13209             Jiong Wang  <jiong.wang@arm.com>
13210
13211         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13212         registers.
13213         (aarch64_pseudo_register_name): Likewise.
13214         (aarch64_pseudo_register_type): Likewise.
13215         (aarch64_pseudo_register_reggroup_p): Likewise.
13216         (aarch64_gdbarch_init): Add pauth registers.
13217         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13218         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13219         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13220         (struct gdbarch_tdep): Add regnum for ra_state.
13221
13222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13223             Jiong Wang  <jiong.wang@arm.com>
13224
13225         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13226
13227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13228             Jiong Wang  <jiong.wang@arm.com>
13229
13230         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13231         function.
13232         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13233         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13234         (aarch64_gdbarch_init): Add puth registers.
13235         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13236         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13237         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13238
13239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13240             Jiong Wang  <jiong.wang@arm.com>
13241
13242         * aarch64-linux-nat.c
13243         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13244         * aarch64-linux-tdep.c
13245         (aarch64_linux_core_read_description): Likewise.
13246         (aarch64_linux_get_hwcap): New function.
13247         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13248         (aarch64_linux_get_hwcap): New declaration.
13249
13250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13251             Jiong Wang  <jiong.wang@arm.com>
13252
13253         * aarch64-linux-nat.c
13254         (aarch64_linux_nat_target::read_description): Add pauth param.
13255         * aarch64-linux-tdep.c
13256         (aarch64_linux_core_read_description): Likewise.
13257         * aarch64-tdep.c (struct target_desc): Add in pauth.
13258         (aarch64_read_description): Add pauth param.
13259         (aarch64_gdbarch_init): Likewise.
13260         * aarch64-tdep.h (aarch64_read_description): Likewise.
13261         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13262         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13263         * features/Makefile: Add new files.
13264         * features/aarch64-pauth.c: New file.
13265         * features/aarch64-pauth.xml: New file.
13266
13267 2019-03-20  Tom Tromey  <tromey@adacore.com>
13268
13269         * infrun.c (handle_inferior_event): Rename from
13270         handle_inferior_event_1.  Create a scoped_value_mark.
13271         (handle_inferior_event): Remove.
13272
13273 2019-03-19  Tom Tromey  <tromey@adacore.com>
13274
13275         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13276         * infrun.h (print_stop_event): Add "displays" parameter.
13277         * infrun.c (print_stop_event): Add "displays" parameter.
13278
13279 2019-03-19  Pedro Alves  <palves@redhat.com>
13280
13281         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13282         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13283         to -1.  Fix TABs vs spaces.
13284         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13285         * tui/tui-out.h (tui_ui_out) Add intro comments.
13286         <m_line, m_start_of_line>: In-class initialize, and add describing
13287         comment.
13288
13289 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13290
13291         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13292         variable names.
13293         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13294
13295 2019-03-18  Pedro Alves  <palves@redhat.com>
13296             Eli Zaretskii <eliz@gnu.org>
13297
13298         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13299         m_line and m_start_of_line.
13300
13301 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13302
13303         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13304         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13305         it returns a newline.  This fixes a regression in TU mode, whereby
13306         the next line is output on the same screen line as the user input.
13307
13308 2019-03-18  Tom Tromey  <tromey@adacore.com>
13309
13310         * minsyms.c (minimal_symbol_reader::install): Remove call to
13311         obstack_blank.
13312
13313 2019-03-18  Pedro Alves  <palves@redhat.com>
13314
13315         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13316         New globals.
13317         (apply_style): New, factored out from ...
13318         (apply_ansi_escape): ... this.  Handle reverse video mode.
13319         (tui_set_reverse_mode): New function.
13320         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13321         * tui/tui-winsource.c (tui_show_source_line): Use
13322         tui_set_reverse_mode instead of setting A_STANDOUT.
13323         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13324         New setter methods.
13325
13326 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13327
13328         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13329         Handle tabs.
13330
13331 2019-03-18  Tom Tromey  <tromey@adacore.com>
13332
13333         * ada-lang.c (empty_array): Add "high" parameter.
13334         (ada_evaluate_subexp): Update.
13335
13336 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13337
13338         * unittests/string_view-selftests.c: Define
13339         _initialize_string_view_selftests unconditionally.
13340
13341 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13342
13343         PR gdb/24350
13344         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13345
13346 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13347
13348         PR gdb/24351
13349         * windows-nat.c (display_selector): Fix format specifiers.
13350
13351 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13352
13353         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13354         tui_refill_source_window instead of tui_refresh_win, to update the
13355         current execution line.  This fixes redisplay of the current line
13356         when stepping through the code with "next" or "step".
13357
13358 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13359
13360         * source-cache.c (source_cache::get_source_lines): Call
13361         find_source_lines to initialize s->nlines.  This fixes vertical
13362         scrolling of TUI source window when the DOWN arrow is pressed.
13363
13364 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13365
13366         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13367         linux-thread-db.c (_initialize_thread_db): Likewise.
13368
13369 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13370
13371         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13372         wclrtoeol in tui_show_source_line".  This reverts changes made in
13373         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13374
13375 2019-03-15  Tom Tromey  <tom@tromey.com>
13376
13377         * symtab.h (struct minimal_symbol): Derive from
13378         general_symbol_info.
13379         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13380         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13381         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13382         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13383         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13384         (MSYMBOL_SEARCH_NAME): Update.
13385         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13386         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13387         * minsyms.c (minimal_symbol_reader::record_full): Update.
13388
13389 2019-03-15  Tom Tromey  <tom@tromey.com>
13390
13391         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13392
13393 2019-03-15  Tom Tromey  <tom@tromey.com>
13394
13395         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13396         unique_xmalloc_ptr.
13397         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13398         Update.
13399         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13400         (build_minimal_symbol_hash_tables)
13401         (minimal_symbol_reader::install): Update.
13402
13403 2019-03-15  Tom Tromey  <tom@tromey.com>
13404
13405         * symtab.c (create_demangled_names_hash): Update.
13406         (symbol_set_names): Update.
13407         * objfiles.h (struct objfile_per_bfd_storage)
13408         <demangled_names_hash>: Now an htab_up.
13409         * objfiles.c (objfile_per_bfd_storage): Simplify.
13410
13411 2019-03-15  Tom Tromey  <tom@tromey.com>
13412
13413         * objfiles.h (struct objfile_per_bfd_storage): Declare
13414         destructor.
13415         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13416         New.
13417         (get_objfile_bfd_data): Use new.  Don't initialize
13418         language_of_main.
13419         (free_objfile_per_bfd_storage): Remove.
13420         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13421
13422 2019-03-15  Tom Tromey  <tom@tromey.com>
13423
13424         * symfile.c (reread_symbols): Update.
13425         * objfiles.c (objfile::objfile): Update.
13426         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13427         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13428         comment.
13429         (minimal_symbol_reader::install): Update.
13430         (terminate_minimal_symbol_table): Remove.
13431         * jit.c (jit_object_close_impl): Update.
13432
13433 2019-03-15  Tom Tromey  <tom@tromey.com>
13434
13435         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13436         initializations.
13437
13438 2019-03-15  Tom Tromey  <tom@tromey.com>
13439
13440         * objfiles.h (struct objfile_per_bfd_storage)
13441         <demangled_hash_languages>: Now a bitset.
13442         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13443         (lookup_minimal_symbol): Update.
13444
13445 2019-03-15  Tom Tromey  <tom@tromey.com>
13446
13447         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13448         Don't return the symbol.
13449         * coffread.c (record_minimal_symbol): Use record_full.
13450
13451 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13452
13453         The MS-Windows port of ncurses fails to switch to a color pair if
13454         one or both of the colors are the implicit default colors.  This
13455         change records the default colors when TUI is initialized, and
13456         then specifies them explicitly when a color pair uses the default
13457         colors.  This allows color styling in TUI mode on MS-Windows.
13458
13459         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13460         ncurses_norm_attr.
13461         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13462         colors in ncurses_norm_attr.
13463         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13464         "none", replace it with the default color recorded in
13465         ncurses_norm_attr.
13466
13467 2019-03-14  Tom Tromey  <tromey@adacore.com>
13468
13469         * source-cache.h (class source_cache) <get_source_lines>: Return
13470         std::string.
13471         * source-cache.c (source_cache::extract_lines): Handle case where
13472         first_pos==npos.  Return std::string.
13473         (source_cache::get_source_lines): Update.
13474
13475 2019-03-14  Tom Tromey  <tromey@adacore.com>
13476
13477         * NEWS: Add item for "style sources" commands.
13478         * source-cache.c (source_cache::get_source_lines): Check
13479         source_styling.
13480         * cli/cli-style.c (source_styling): New global.
13481         (_initialize_cli_style): Add "style sources" commands.
13482         (show_style_sources): New function.
13483         * cli/cli-style.h (source_styling): Declare.
13484
13485 2019-03-14  Pedro Alves  <palves@redhat.com>
13486             Tom Tromey  <tromey@adacore.com>
13487
13488         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13489         * tui/tui-winsource.c (tui_refill_source_window): New function,
13490         from...
13491         (tui_horizontal_source_scroll): ... here.  Move some logic.
13492         * cli/cli-style.c (set_style_enabled): Notify new observable.
13493         * tui/tui-hooks.c (tui_redisplay_source): New function.
13494         (tui_attach_detach_observers): Attach or detach
13495         tui_redisplay_source.
13496         * observable.h (source_styling_changed): New observable.
13497         * observable.c: Define source_styling_changed observable.
13498
13499 2019-03-13  Tom Tromey  <tromey@adacore.com>
13500
13501         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13502         (i386_gnu_nat_target::store_registers): Update.
13503         * target-debug.h (target_debug_print_std_string): New macro.
13504         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13505         * windows-tdep.c (display_one_tib): Update.
13506         * tui/tui-stack.c (tui_make_status_line): Update.
13507         * top.c (print_inferior_quit_action): Update.
13508         * thread.c (thr_try_catch_cmd): Update.
13509         (add_thread_with_info): Update.
13510         (thread_target_id_str): Update.
13511         (thr_try_catch_cmd): Update.
13512         (thread_command): Update.
13513         (thread_find_command): Update.
13514         * record-btrace.c (record_btrace_target::info_record)
13515         (record_btrace_resume_thread, record_btrace_target::resume)
13516         (record_btrace_cancel_resume, record_btrace_step_thread)
13517         (record_btrace_target::wait, record_btrace_target::wait)
13518         (record_btrace_target::wait, record_btrace_target::stop): Update.
13519         * progspace.c (print_program_space): Update.
13520         * process-stratum-target.c
13521         (process_stratum_target::thread_address_space): Update.
13522         * linux-fork.c (linux_fork_mourn_inferior)
13523         (detach_checkpoint_command, info_checkpoints_command)
13524         (linux_fork_context): Update.
13525         (linux_fork_detach): Update.
13526         (class scoped_switch_fork_info): Update.
13527         (delete_checkpoint_command): Update.
13528         * infrun.c (follow_fork_inferior): Update.
13529         (follow_fork_inferior): Update.
13530         (proceed_after_vfork_done): Update.
13531         (handle_vfork_child_exec_or_exit): Update.
13532         (follow_exec): Update.
13533         (displaced_step_prepare_throw): Update.
13534         (displaced_step_restore): Update.
13535         (start_step_over): Update.
13536         (resume_1): Update.
13537         (clear_proceed_status_thread): Update.
13538         (proceed): Update.
13539         (print_target_wait_results): Update.
13540         (do_target_wait): Update.
13541         (context_switch): Update.
13542         (stop_all_threads): Update.
13543         (restart_threads): Update.
13544         (finish_step_over): Update.
13545         (handle_signal_stop): Update.
13546         (switch_back_to_stepped_thread): Update.
13547         (keep_going_pass_signal): Update.
13548         (print_exited_reason): Update.
13549         (normal_stop): Update.
13550         * inferior.c (inferior_pid_to_str): Change return type.
13551         (print_selected_inferior): Update.
13552         (add_inferior): Update.
13553         (detach_inferior): Update.
13554         * dummy-frame.c (fprint_dummy_frames): Update.
13555         * dcache.c (dcache_info_1): Update.
13556         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13557         (btrace_fetch, btrace_clear): Update.
13558         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13559         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13560         type.
13561         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13562         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13563         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13564         * gdbarch.c, gdbarch.h: Rebuild.
13565         * gdbarch.sh (core_pid_to_str): Change return type.
13566         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13567         return type.
13568         (windows_nat_target::pid_to_str): Change return type.
13569         (windows_delete_thread): Update.
13570         (windows_nat_target::attach): Update.
13571         (windows_nat_target::files_info): Update.
13572         * target-delegates.c: Rebuild.
13573         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13574         return type.
13575         (sol_thread_target::pid_to_str): Change return type.
13576         * remote.c (class remote_target) <pid_to_str>: Change return
13577         type.
13578         (remote_target::pid_to_str): Change return type.
13579         (extended_remote_target::attach, remote_target::remote_stop_ns)
13580         (remote_target::remote_notif_remove_queued_reply)
13581         (remote_target::push_stop_reply, remote_target::disable_btrace):
13582         Update.
13583         (extended_remote_target::attach): Update.
13584         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13585         type.
13586         (gdbsim_target::pid_to_str): Change return type.
13587         * ravenscar-thread.c (struct ravenscar_thread_target)
13588         <pid_to_str>: Change return type.
13589         (ravenscar_thread_target::pid_to_str): Change return type.
13590         * procfs.c (class procfs_target) <pid_to_str>: Change return
13591         type.
13592         (procfs_target::pid_to_str): Change return type.
13593         (procfs_target::attach): Update.
13594         (procfs_target::detach): Update.
13595         (procfs_target::fetch_registers): Update.
13596         (procfs_target::store_registers): Update.
13597         (procfs_target::wait): Update.
13598         (procfs_target::files_info): Update.
13599         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13600         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13601         return type.
13602         (nto_procfs_target::pid_to_str): Change return type.
13603         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13604         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13605         return type.
13606         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13607         (exit_lwp): Update.
13608         (attach_proc_task_lwp_callback, get_detach_signal)
13609         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13610         (linux_nat_target::resume, wait_lwp, stop_callback)
13611         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13612         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13613         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13614         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13615         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13616         type.
13617         (inf_ptrace_target::attach): Update.
13618         (inf_ptrace_target::files_info): Update.
13619         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13620         type.
13621         (go32_nat_target::pid_to_str): Change return type.
13622         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13623         (gnu_nat_target::wait): Update.
13624         (gnu_nat_target::wait): Update.
13625         (gnu_nat_target::resume): Update.
13626         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13627         (fbsd_nat_target::wait): Update.
13628         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13629         type.
13630         (darwin_nat_target::attach): Update.
13631         * corelow.c (class core_target) <pid_to_str>: Change return type.
13632         (core_target::pid_to_str): Change return type.
13633         * target.c (normal_pid_to_str): Change return type.
13634         (default_pid_to_str): Likewise.
13635         (target_pid_to_str): Change return type.
13636         (target_translate_tls_address): Update.
13637         (target_announce_detach): Update.
13638         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13639         return type.
13640         (bsd_uthread_target::pid_to_str): Change return type.
13641         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13642         type.
13643         (bsd_kvm_target::pid_to_str): Change return type.
13644         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13645         return type.
13646         (aix_thread_target::pid_to_str): Change return type.
13647         * target.h (struct target_ops) <pid_to_str>: Change return type.
13648         (target_pid_to_str, normal_pid_to_str): Likewise.
13649         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13650         type.
13651         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13652         type.
13653         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13654         return type.
13655         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13656         type.
13657         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13658         type.
13659         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13660         return type.
13661
13662 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13663
13664         * NEWS: Mention that the new default MI version is 3.  Mention
13665         changes to the output of commands and events that deal with
13666         multi-location breakpoints.
13667         * breakpoint.c: Include "mi/mi-out.h".
13668         (print_one_breakpoint): Change output syntax if using MI version
13669         >= 3.
13670         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13671         New.
13672         (mi_multi_location_breakpoint_output_fixed): New.
13673         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13674         (mi_cmd_fix_multi_location_breakpoint_output): New.
13675         (mi_multi_location_breakpoint_output_fixed): New.
13676         * mi/mi-cmds.c (mi_cmds): Register command
13677         -fix-multi-location-breakpoint-output.
13678         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13679         interpreter "mi".
13680
13681 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13682
13683         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13684         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13685         instantiate mi_ui_out based on interpreter name.
13686         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13687         * mi/mi-main.c (mi_load_progress): Likewise.
13688
13689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13690
13691         * NEWS: Combine separate "New targets" sections for 8.3.
13692
13693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13694
13695         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13696         (ppcfbsd_init_abi): Install gdbarch
13697         "fetch_tls_load_module_address" and "get_thread_local_address"
13698         methods.
13699
13700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13701
13702         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13703         (riscv_fbsd_init_abi): Install gdbarch
13704         "fetch_tls_load_module_address" and "get_thread_local_address"
13705         methods.
13706
13707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13708
13709         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13710         (i386fbsd_init_abi): Install gdbarch
13711         "fetch_tls_load_module_address" and "get_thread_local_address"
13712         methods.
13713
13714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13715
13716         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13717         (amd64fbsd_init_abi): Install gdbarch
13718         "fetch_tls_load_module_address" and "get_thread_local_address"
13719         methods.
13720
13721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13722
13723         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13724         (struct fbsd_pspace_data): New type.
13725         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13726         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13727         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13728         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13729         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13730
13731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13732
13733         * gdbtypes.c (lookup_struct_elt): New function.
13734         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13735         * gdbtypes.h (struct struct_elt): New type.
13736         (lookup_struct_elt): New prototype.
13737
13738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13739
13740         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13741         remove disabled code block.
13742
13743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13744
13745         * gdbarch.sh (get_thread_local_address): New method.
13746         * gdbarch.h, gdbarch.c: Regenerate.
13747         * target.c (target_translate_tls_address): Use
13748         gdbarch_get_thread_local_address if present instead of
13749         target::get_thread_local_address.
13750
13751 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13752
13753         * target.h (target::get_thread_local_address): Update comment.
13754
13755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13756
13757         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13758         objfile->separate_debug_objfile_backlink if not NULL.
13759
13760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13761
13762         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13763         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13764         (amd64bsd_store_inferior_registers): Likewise.
13765         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13766         Enable segment base registers.
13767         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13768         PT_GETFSBASE and PT_GETGSBASE.
13769         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13770         PT_SETGSBASE.
13771         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13772         segment base registers.
13773         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13774
13775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13776
13777         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13778         Update calls to i386_target_description to add 'segments'
13779         parameter.
13780         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13781         add segment base registers.
13782         * arch/i386.c (i386_create_target_description): Add 'segments'
13783         parameter to enable segment base registers.
13784         * arch/i386.h (i386_create_target_description): Likewise.
13785         * features/i386/32bit-segments.xml: New file.
13786         * features/i386/32bit-segments.c: Generate.
13787         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13788         call to i386_target_description to add 'segments' parameter.
13789         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13790         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13791         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13792         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13793         if feature is present.
13794         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13795         Add 'segments' parameter to call to i386_target_description.
13796         (i386_target_description): Add 'segments' parameter to enable
13797         segment base registers.
13798         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13799         to call to i386_target_description.
13800         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13801         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13802         Define I386_NUM_REGS.
13803         (i386_target_description): Add 'segments' parameter to enable
13804         segment base registers.
13805
13806 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13807
13808         PR/24325
13809         * source-cache.c: #undef open and close, to avoid unresolved
13810         externals during linking.
13811
13812 2019-03-12  Tom Tromey  <tromey@adacore.com>
13813
13814         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13815         const.  Add initializers.
13816         (_initialize_remote): Don't initialize ptid globals.
13817
13818 2019-03-12  Pedro Alves  <palves@redhat.com>
13819
13820         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13821
13822 2019-03-12  Pedro Alves  <palves@redhat.com>
13823
13824         * cp-name-parser.y (main): Remove unused 'len' variable.
13825
13826 2019-03-12  Tom Tromey  <tromey@adacore.com>
13827
13828         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13829         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13830
13831 2019-03-12  Tom Tromey  <tromey@adacore.com>
13832
13833         * linux-nat.c (iterate_over_lwps): Update.
13834         (stop_callback): Remove parameter.
13835         (stop_wait_callback, detach_callback, resume_set_callback)
13836         (select_singlestep_lwp_callback, set_ignore_sigint)
13837         (status_callback, resumed_callback, resume_clear_callback)
13838         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13839         data parameter.
13840         (linux_nat_target::detach, linux_nat_target::resume)
13841         (linux_stop_and_wait_all_lwps, select_event_lwp)
13842         (linux_nat_filter_event, linux_nat_wait_1)
13843         (linux_nat_target::kill, linux_nat_target::stop)
13844         (linux_nat_target::stop): Update.
13845         (linux_nat_resume_callback): Change type.
13846         (resume_stopped_resumed_lwps, count_events_callback)
13847         (select_event_lwp_callback): Likewise.
13848         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13849         * arm-linux-nat.c (struct update_registers_data): Remove.
13850         (update_registers_callback): Change type.
13851         (arm_linux_insert_hw_breakpoint1): Update.
13852         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13853         parameter.
13854         (x86_linux_dr_set_addr): Update.
13855         (x86_linux_dr_set_control): Update.
13856         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13857         (iterate_over_lwps): Use gdb::function_view.
13858         * nat/aarch64-linux-hw-point.c (struct
13859         aarch64_dr_update_callback_param): Remove.
13860         (debug_reg_change_callback): Change type.
13861         (aarch64_notify_debug_reg_change): Update.
13862         * s390-linux-nat.c (s390_refresh_per_info): Update.
13863
13864 2019-03-11  Tom Tromey  <tromey@adacore.com>
13865
13866         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13867         redundant assignment to "this_cu".
13868
13869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13870
13871         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13872
13873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13874
13875         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13876         from...
13877         (rank_one_type): ... this.
13878
13879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13880
13881         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13882         from...
13883         (rank_one_type): ... this.
13884
13885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13886
13887         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13888         from...
13889         (rank_one_type): ... this.
13890
13891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13892
13893         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13894         from...
13895         (rank_one_type): ... this.
13896
13897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13898
13899         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13900         from...
13901         (rank_one_type): ... this.
13902
13903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13904
13905         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13906         from...
13907         (rank_one_type): ... this.
13908
13909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13910
13911         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13912         from...
13913         (rank_one_type): ... this.
13914
13915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13916
13917         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13918         from...
13919         (rank_one_type): ... this.
13920
13921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13922
13923         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13924         from...
13925         (rank_one_type): ... this.
13926
13927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13928
13929         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13930         from...
13931         (rank_one_type): ... this.
13932
13933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13934
13935         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13936         from...
13937         (rank_one_type): ... this.
13938
13939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13940
13941         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13942         from...
13943         (rank_one_type): ... this.
13944
13945 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13946
13947         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13948         inferior-events' shows the example events.
13949
13950 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13951
13952         Support styling on native MS-Windows console
13953
13954         PR/24315
13955         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13956         on MS-Windows if $TERM is not defined.
13957
13958         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13959
13960         * posix-hdep.c (gdb_console_fputs):
13961         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13962         functions.
13963         * ui-file.h (gdb_console_fputs): Add prototype.
13964
13965         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13966         back to fputs only if the former returns zero.
13967
13968 2019-03-07  Tom Tromey  <tom@tromey.com>
13969
13970         * symmisc.c (print_symbol_bcache_statistics): Update.
13971         (print_objfile_statistics): Update.
13972         * symfile.c (allocate_symtab): Update.
13973         * stabsread.c: Don't include bcache.h.
13974         * psymtab.h (struct psymbol_bcache): Don't declare.
13975         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13976         (psymbol_bcache_init, psymbol_bcache_free)
13977         (psymbol_bcache_get_bcache): Don't declare.
13978         * psymtab.c (struct psymbol_bcache): Remove.
13979         (psymtab_storage::psymtab_storage): Update.
13980         (psymtab_storage::~psymtab_storage): Update.
13981         (psymbol_bcache_init, psymbol_bcache_free)
13982         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13983         (add_psymbol_to_bcache): Update.
13984         (allocate_psymtab): Update.
13985         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13986         macro_cache>: No longer pointers.
13987         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13988         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13989         * macrotab.c (macro_bcache): Update.
13990         * macroexp.c: Don't include bcache.h.
13991         * gdbtypes.c (check_types_worklist): Update.
13992         (types_deeply_equal): Remove TRY/CATCH.  Update.
13993         * elfread.c (elf_symtab_read): Update.
13994         * dwarf2read.c: Don't include bcache.h.
13995         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13996         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13997         (print_bcache_statistics, bcache_memory_used): Don't declare.
13998         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13999         methods.  Rename all data members.
14000         * bcache.c (struct bcache): Move to bcache.h.
14001         (bcache::expand_hash_table): Rename from expand_hash_table.
14002         (bcache): Remove.
14003         (bcache::insert): Rename from bcache_full.
14004         (bcache::compare): Rename from bcache_compare.
14005         (bcache_xmalloc): Remove.
14006         (bcache::~bcache): Rename from bcache_xfree.
14007         (bcache::print_statistics): Rename from print_bcache_statistics.
14008         (bcache::memory_used): Rename from bcache_memory_used.
14009
14010 2019-03-07  Pedro Alves  <palves@redhat.com>
14011
14012         * infrun.c (normal_stop): Also check for
14013         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14014
14015 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14016
14017         * f-lang.c (value_from_host_double): Moved to...
14018         * value.c (value_from_host_double): ...here.
14019         * value.h (value_from_host_double): Declare.
14020         * guile/scm-math.c (vlscm_convert_typed_number): Use
14021         value_from_host_double.
14022         (vlscm_convert_number): Likewise.
14023         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14024         * python/py-value.c (convert_value_from_python): Likewise.
14025
14026 2019-03-06  Tom Tromey  <tom@tromey.com>
14027
14028         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14029
14030 2019-03-06  Tom Tromey  <tom@tromey.com>
14031
14032         * utils.h (free_current_contents): Don't declare.
14033         * utils.c (free_current_contents): Remove.
14034
14035 2019-03-06  Tom Tromey  <tom@tromey.com>
14036
14037         * top.c (quit_force): Update.
14038         * main.c (captured_command_loop): Update.
14039         * common/new-op.c (operator new): Update.
14040         * common/common-exceptions.c (struct catcher)
14041         <save_cleanup_chain>: Remove member.
14042         (exceptions_state_mc_init): Update.
14043         (exception_try_scope_entry): Return nullptr.
14044         (exception_try_scope_exit, exception_rethrow)
14045         (throw_exception_sjlj, throw_exception_cxx): Update.
14046         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14047         (all_cleanups, do_cleanups, discard_cleanups)
14048         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14049         (restore_cleanups, restore_final_cleanups): Don't declare.
14050         (do_final_cleanups): Remove parameter.
14051         * common/cleanups.c (cleanup_chain, make_cleanup)
14052         (make_cleanup_dtor, all_cleanups, do_cleanups)
14053         (discard_my_cleanups, discard_cleanups)
14054         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14055         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14056         (null_cleanup): Remove.
14057         (do_final_cleanups): Remove parameter.
14058
14059 2019-03-06  Tom Tromey  <tom@tromey.com>
14060
14061         * remote.c (remote_target::remote_parse_stop_reply): Use
14062         unique_xmalloc_ptr.
14063
14064 2019-03-06  Tom Tromey  <tom@tromey.com>
14065
14066         * stabsread.c (struct stabs_field_info): Rename from field_info.
14067         <list, fnlist>: Add initializers.
14068         <obstack>: New member.
14069         (read_member_functions, read_struct_fields, read_baseclasses):
14070         Allocate on obstack.  Don't use cleanups.
14071         (read_one_struct_field, read_member_functions, read_struct_fields)
14072         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14073         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14074         (read_struct_type): Update.
14075
14076 2019-03-06  Tom Tromey  <tom@tromey.com>
14077
14078         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14079         * common/filestuff.h (make_cleanup_close): Don't declare.
14080         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14081         Remove.
14082
14083 2019-03-06  Tom Tromey  <tom@tromey.com>
14084
14085         * solib-aix.c: Use make_scope_exit.
14086
14087 2019-03-06  Tom Tromey  <tom@tromey.com>
14088
14089         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14090         Use make_scope_exit.
14091
14092 2019-03-06  Tom Tromey  <tom@tromey.com>
14093
14094         * solib-svr4.c (disable_probes_interface): Remove parameter.
14095         (svr4_handle_solib_event): Use make_scope_exit.
14096
14097 2019-03-06  Tom Tromey  <tom@tromey.com>
14098
14099         * remote.c (struct stop_reply_deleter): Remove.
14100         (stop_reply_up): Update.
14101         (struct stop_reply): Derive from notif_event.  Don't typedef.
14102         <regcache>: Now a std::vector.
14103         (stop_reply_xfree): Remove.
14104         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14105         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14106         (remote_target::discard_pending_stop_replies): Use delete.
14107         (remote_target::remote_parse_stop_reply): Update.
14108         (remote_target::process_stop_reply): Update.
14109         * remote-notif.h (struct notif_event): Add virtual destructor.
14110         Remove "dtr" member.
14111         (struct notif_client) <alloc_event>: Return a unique_ptr.
14112         (notif_event_xfree): Don't declare.
14113         (notif_event_up): New typedef.
14114         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14115         (notif_event_xfree, do_notif_event_xfree): Remove.
14116         (remote_notif_state_xfree): Update.
14117
14118 2019-03-06  Tom Tromey  <tom@tromey.com>
14119
14120         * infrun.c (displaced_step_clear_cleanup): Now a
14121         forward_scope_exit type.
14122         (displaced_step_prepare_throw): Update.
14123         (displaced_step_fixup): Update.
14124
14125 2019-03-06  Tom Tromey  <tom@tromey.com>
14126
14127         * inferior.h (class inferior): Update comment.
14128         * gdbthread.h (class thread_info): Update comment.
14129
14130 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14131             Tom Tromey  <tom@tromey.com>
14132
14133         * stabsread.h (struct stab_section_list): Remove.
14134         (coffstab_build_psymtabs): Update.
14135         * dbxread.c (symbuf_sections): Now a std::vector.
14136         (sect_idx): New global.
14137         (fill_symbuf): Update.
14138         (coffstab_build_psymtabs): Change type of stabsects parameter.
14139         Update.
14140         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14141         std::vector.
14142         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14143         (coff_locate_sections): Update.
14144         (coff_symfile_read): Remove cleanups.  Update.
14145         (init_stringtab): Add storage parameter.
14146         (free_stringtab, free_stringtab_cleanup): Remove.
14147         (init_lineno): Add storage parameter.
14148         (free_linetab, free_linetab_cleanup): Remove.
14149
14150 2019-03-06  Pedro Alves  <palves@redhat.com>
14151
14152         * linux-fork.c (fork_info::clobber_regs): Delete.
14153         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14154         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14155         comment.  Adjust.
14156         (scoped_switch_fork_info::scoped_switch_fork_info)
14157         (checkpoint_command, linux_fork_context): Adjust
14158         fork_save_infrun_state calls.
14159
14160 2019-03-06  Pedro Alves  <palves@redhat.com>
14161
14162         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14163         (inf_has_multiple_threads): Return 'bool' and rewrite using
14164         inferior_info::threads().
14165
14166 2019-03-06  Pedro Alves  <palves@redhat.com>
14167
14168         * linux-fork.c: Include <list>.
14169         (fork_list): Now a std::list instance.
14170         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14171         (forks_exist_p, find_last_fork): Adjust.
14172         (new_fork): Delete.
14173         (one_fork_p): New.
14174         (add_fork): Adjust.
14175         (free_fork): Delete, folded into fork_info::~fork_info().
14176         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14177         Adjust.
14178         (init_fork_list): Delete.
14179         (linux_fork_killall, linux_fork_mourn_inferior)
14180         (linux_fork_detach, info_checkpoints_command): Adjust.
14181         (_initialize_linux_fork): No longer call init_fork_list.
14182
14183 2019-03-06  Pedro Alves  <palves@redhat.com>
14184
14185         * linux-fork.c (new_fork): New, split out of ...
14186         (add_fork): ... this.  Return void.  Move "first fork" special
14187         case from here, to ...
14188         (checkpoint_command): ... here.
14189         * linux-linux.h (add_fork): Return void.
14190
14191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14192
14193         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14194
14195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14196             Chris January  <chris.january@arm.com>
14197             David Lecomber  <david.lecomber@arm.com>
14198
14199         * f-exp.y: New token, UNOP_INTRINSIC.
14200         (exp): New pattern using UNOP_INTRINSIC token.
14201         (f77_keywords): Add 'abs' keyword.
14202         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14203         (value_from_host_double): New function.
14204         (evaluate_subexp_f): Support UNOP_ABS.
14205
14206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14207
14208         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14209         types.
14210
14211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14212
14213         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14214         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14215         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14216
14217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14218
14219         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14220
14221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14222             Chris January  <chris.january@arm.com>
14223
14224         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14225         * f-exp.y: Define 'KIND' token.
14226         (exp): New pattern for KIND expressions.
14227         (ptype): Handle types with a kind extension.
14228         (direct_abs_decl): Extend to spot kind extensions.
14229         (f77_keywords): Add 'kind' to the list.
14230         (push_kind_type): New function.
14231         (convert_to_kind_type): New function.
14232         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14233         * parse.c (operator_length_standard): Likewise.
14234         * parser-defs.h (enum type_pieces): Add tp_kind.
14235         * std-operator.def: Add UNOP_KIND.
14236
14237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14238
14239         * f-exp.y (f_parse): Set yydebug.
14240
14241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14242
14243         * f-lang.c (evaluate_subexp_f): New function.
14244         (exp_descriptor_f): New global.
14245         (f_language_defn): Use exp_descriptor_f instead of
14246         exp_descriptor_standard.
14247
14248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14249
14250         * f-exp.y (struct token): Add comments.
14251         (dot_ops): Remove uppercase versions and the end marker.
14252         (f77_keywords): Likewise.
14253         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14254         entries in the dot_ops array are case insensitive, and use
14255         strncasecmp to compare strings.  Also some whitespace cleanup in
14256         this area.  Similar for the f77_keywords array, except entries in
14257         this list might be case sensitive.
14258
14259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14260
14261         * f-exp.y (struct f77_boolean_val): Add comments.
14262         (boolean_values): Remove uppercase versions, and end marker.
14263         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14264         and use strncasecmp to achieve case insensitivity.  Additionally,
14265         perform whitespace cleanup around this code.
14266
14267 2019-03-06  Tom Tromey  <tromey@adacore.com>
14268
14269         * remote-sim.c (gdbsim_target_open): Use result of
14270         gdb_argv::release.
14271
14272 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14273         Dirk Schubert  <dirk.schubert@arm.com>
14274         Chris January  <chris.january@arm.com>
14275
14276         * eval.c (evaluate_subexp_standard): Call Fortran argument
14277         wrapping logic.
14278         * f-lang.c (struct value): A value which can be passed into a
14279         Fortran function call.
14280         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14281         where appropriate.
14282         (struct type): Value ready for a Fortran function call.
14283         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14284         is needed.
14285         * f-lang.h (fortran_argument_convert): Declaration.
14286         (fortran_preserve_arg_pointer): Declaration.
14287         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14288
14289 2019-03-05  Tom Tromey  <tromey@adacore.com>
14290
14291         * python/py-prettyprint.c (print_string_repr): Remove #if.
14292         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14293
14294 2019-03-05  Tom Tromey  <tromey@adacore.com>
14295
14296         * target.c (the_dummy_target): Move later.  Change type to
14297         "dummy_target".
14298         (initialize_targets): Don't initialize the_dummy_target.
14299
14300 2019-03-05  Tom Tromey  <tromey@adacore.com>
14301
14302         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14303         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14304
14305 2019-03-05  Tom Tromey  <tromey@adacore.com>
14306
14307         * windows-nat.c (windows_nat_target::attach)
14308         (windows_nat_target::detach): Don't call gdb_flush.
14309         * valprint.c (generic_val_print, val_print, val_print_string):
14310         Don't call gdb_flush.
14311         * utils.c (defaulted_query): Don't call gdb_flush.
14312         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14313         * target.c (target_announce_detach): Don't call gdb_flush.
14314         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14315         * remote.c (extended_remote_target::attach): Don't call
14316         gdb_flush.
14317         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14318         * printcmd.c (do_examine): Don't call gdb_flush.
14319         (info_display_command): Don't call gdb_flush.
14320         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14321         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14322         * memattr.c (info_mem_command): Don't call gdb_flush.
14323         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14324         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14325         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14326         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14327         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14328         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14329         (gnu_nat_target::detach): Don't call gdb_flush.
14330         * f-valprint.c (f_val_print): Don't call gdb_flush.
14331         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14332         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14333         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14334         gdb_flush.
14335         * c-valprint.c (c_val_print): Don't call gdb_flush.
14336         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14337
14338 2019-03-05  Tom Tromey  <tromey@adacore.com>
14339
14340         * varobj.c (update_dynamic_varobj_children): Update.
14341         (install_default_visualizer): Use reset, not release.
14342         * value.c (set_internalvar): Update.
14343         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14344         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14345         ATTRIBUTE_UNUSED_RESULT.
14346
14347 2019-03-05  Tom Tromey  <tromey@adacore.com>
14348
14349         * remote.c (class scoped_remote_fd) <release>: Add
14350         ATTRIBUTE_UNUSED_RESULT.
14351
14352 2019-03-05  Tom Tromey  <tromey@adacore.com>
14353
14354         * macroexp.c (struct macro_buffer) <release>: Add
14355         ATTRIBUTE_UNUSED_RESULT.
14356
14357 2019-03-05  Tom Tromey  <tromey@adacore.com>
14358
14359         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14360         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14361         ATTRIBUTE_UNUSED_RESULT.
14362
14363 2019-03-05  Tom Tromey  <tromey@adacore.com>
14364
14365         * common/scoped_fd.h (class scoped_fd) <release>: Add
14366         ATTRIBUTE_UNUSED_RESULT.
14367
14368 2019-03-05  Tom Tromey  <tromey@adacore.com>
14369
14370         * parser-defs.h (struct parser_state) <release>: Add
14371         ATTRIBUTE_UNUSED_RESULT.
14372
14373 2019-03-05  Tom Tromey  <tromey@adacore.com>
14374
14375         * utils.h (class gdb_argv) <release>: Add
14376         ATTRIBUTE_UNUSED_RESULT.
14377         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14378
14379 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14380
14381         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14382         for-loop range, to avoid compiler warnings.
14383
14384         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14385         avoid compiler warnings about unused variables.
14386
14387         * NEWS: Mention end of support for native debugging on MS-Windows
14388         before XP.
14389
14390         PR gdb/24292
14391         * common/netstuff.c:
14392         * gdbserver/gdbreplay.c
14393         * gdbserver/remote-utils.c:
14394         * ser-tcp.c:
14395         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14396         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14397         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14398         'getaddrinfo' and 'freeaddrinfo' were not available before
14399         Windows XP, and mingw.org's MinGW headers by default define
14400         _WIN32_WINNT to 0x500.
14401
14402 2019-03-01  Gary Benson <gbenson@redhat.com>
14403
14404         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14405
14406 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14407             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14408
14409         PR gdb/8527
14410         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14411         set_sigint_trap, clear_sigint_trap.
14412
14413 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14414
14415         * target.c (target_detach): Clear the regcache and the
14416         frame cache.
14417
14418 2019-02-27  Pedro Alves  <palves@redhat.com>
14419
14420         * utils.c (set_screen_size): When we cap the height/width sizes,
14421         tweak the corresponding command variable to show "unlimited":
14422
14423 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14424             Pedro Alves  <palves@redhat.com>
14425
14426         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14427         before calling rl_set_screen_size.
14428
14429 2019-02-27  Tom Tromey  <tromey@adacore.com>
14430
14431         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14432         define.
14433         * python/py-value.c: Remove Python 2.4 workaround.
14434         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14435         workaround.
14436         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14437         Python 2.4 workaround.
14438         * python/python-internal.h: Remove Python 2.4 comment.
14439         (Py_ssize_t): Don't define.
14440         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14441         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14442         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14443         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14444         * python/python.c (do_start_initialization): Remove Python 2.4
14445         workaround.
14446         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14447         (print_children): Remove Python 2.4 workaround.
14448         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14449         workaround.
14450         (CHARBUFFERPROC_NAME): Remove.
14451         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14452         Python 2.4 workaround.
14453
14454 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14455
14456         * NEWS: Note minimum Python version.
14457
14458 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14459
14460         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14461         code from these functions.  Remove corresponding ifdefs.  Use
14462         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14463         Remove gotos and target of gotos.
14464         (infpy_search_memory): Likewise.
14465
14466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14467
14468         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14469         (hppa_gdbarch_init): Don't register deleted functions with
14470         gdbarch.
14471
14472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14473
14474         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14475         (h8300_unwind_sp): Delete.
14476         (h8300_dummy_id): Delete.
14477         (h8300_gdbarch_init): Don't register deleted functions with
14478         gdbarch.
14479
14480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14481
14482         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14483         (ft32_unwind_pc): Delete.
14484         (ft32_unwind_sp): Delete.
14485         (ft32_gdbarch_init): Don't register deleted functions with
14486         gdbarch.
14487
14488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14489
14490         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14491         (frv_unwind_pc): Delete.
14492         (frv_unwind_sp): Delete.
14493         (frv_gdbarch_init): Don't register deleted functions with
14494         gdbarch.
14495
14496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14497
14498         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14499         (riscv_unwind_pc): Delete.
14500         (riscv_unwind_sp): Delete.
14501         (riscv_gdbarch_init): Don't register deleted functions with
14502         gdbarch.
14503
14504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14505
14506         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14507         (csky_unwind_pc): Delete.
14508         (csky_unwind_sp): Delete.
14509         (csky_gdbarch_init): Don't register deleted functions with
14510         gdbarch.
14511
14512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14513
14514         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14515         (cris_unwind_pc): Delete.
14516         (cris_unwind_sp): Delete.
14517         (cris_gdbarch_init): Don't register deleted functions with
14518         gdbarch.
14519
14520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14521
14522         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14523         (bfin_unwind_pc): Delete.
14524         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14525
14526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14527
14528         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14529         (arm_unwind_pc): Delete.
14530         (arm_unwind_sp): Delete.
14531         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14532
14533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14534
14535         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14536         (arc_unwind_pc): Delete.
14537         (arc_unwind_sp): Delete.
14538         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14539
14540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14541
14542         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14543         (alpha_unwind_pc): Delete.
14544         (alpha_gdbarch_init): Don't register deleted functions with
14545         gdbarch.
14546
14547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14548
14549         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14550         (aarch64_unwind_pc): Delete.
14551         (aarch64_unwind_sp): Delete.
14552         (aarch64_gdbarch_init): Don't register deleted functions with
14553         gdbarch.
14554
14555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14556
14557         * gdbtypes.c (type_align): Don't consider static members when
14558         computing structure alignment.
14559
14560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14561
14562         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14563         return 0 for other types.
14564         * arch-utils.c (default_type_align): Always return 0.
14565         * gdbarch.h: Regenerate.
14566         * gdbarch.sh (type_align): Extend comment.
14567         * gdbtypes.c (type_align): Add additional comments, always call
14568         gdbarch_type_align before applying the default rules.
14569         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14570         generic code will then apply a suitable default.
14571         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14572         types, return 0 for other types.
14573
14574 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14575
14576         * NEWS: Create a new section for the next release branch.
14577         Rename the section of the current branch, now that it has
14578         been cut.
14579
14580 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14581
14582         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14583         * version.in: Bump version to 8.3.50.DATE-git.
14584
14585 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14586
14587         * aix-thread.c (ptid_cmp): Remove unused variable.
14588         (get_signaled_thread): Likewise.
14589         (store_regs_user_thread): Likewise.
14590         (store_regs_kernel_thread): Likewise.
14591         (fetch_regs_kernel_thread): Remove shadowed variable.
14592
14593 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14594
14595         * features/riscv/32bit-cpu.xml: Add register numbers.
14596         * features/riscv/32bit-fpu.c: Regenerate.
14597         * features/riscv/32bit-fpu.xml: Add register numbers.
14598         * features/riscv/64bit-cpu.xml: Add register numbers.
14599         * features/riscv/64bit-fpu.c: Regenerate.
14600         * features/riscv/64bit-fpu.xml: Add register numbers.
14601
14602 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14603
14604         * NEWS: Mention two argument form of gdb.Value constructor.
14605         * python/py-value.c (convert_buffer_and_type_to_value): New
14606         function.
14607         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14608         Add support for handling an optional second argument.  Call
14609         convert_buffer_and_type_to_value as appropriate.
14610         * python/python-internal.h (Py_buffer_deleter): New struct.
14611         (Py_buffer_up): New typedef.
14612
14613 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14614
14615         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14616         instead of releasing ownership.
14617
14618 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14619
14620         * dwarf2read.c (open_and_init_dwp_file): Call
14621         elf_numsections instead of bfd_count_sections to initialize
14622         dwp_file->num_sections.
14623
14624 2019-02-25  Tom Tromey  <tromey@adacore.com>
14625
14626         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14627
14628 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14629
14630         * gcore.in: Add '--readnever' option when invoking GDB.
14631
14632 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14633
14634         * MAINTAINERS: Update my email address.
14635
14636 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14637
14638         * build-id.c (build_id_to_debug_bfd_1): New function.
14639         (build_id_to_debug_bfd): Look for separate debug file in
14640         sysroot.
14641
14642 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14643
14644         * gdbarch.sh: Update the copyright year range that is placed into
14645         generated files.
14646
14647 2019-02-22  Keith Seitz  <keiths@redhat.com>
14648
14649         PR symtab/23853
14650         * linespec.c (create_sals_line_offset): Search for the default
14651         symtab's filename instead of its fullname.
14652
14653 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14654
14655         * NEWS: Update style defaults.
14656
14657 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14658
14659         * main.c (captured_main_1): Disable styling in batch mode.
14660
14661 2019-02-20  Tom Tromey  <tom@tromey.com>
14662
14663         * symtab.c (symtab_symbol_info): Fix typos.
14664
14665 2019-02-20  Tom Tromey  <tromey@adacore.com>
14666
14667         * findcmd.c (_initialize_mem_search): Use upper case for
14668         metasyntactic variables.
14669
14670 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14671
14672         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14673         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14674
14675 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14676
14677         * top.h (source_file_name): Change to std::string.
14678         * top.c (source_file_name): Likewise.
14679         (command_line_input): Adjust.
14680         * cli/cli-script.c (script_from_file): Adjust.
14681
14682 2019-02-19  Tom Tromey  <tromey@adacore.com>
14683
14684         * ravenscar-thread.c
14685         (ravenscar_thread_target::update_thread_list): Don't call
14686         ada_build_task_list.
14687         * ada-lang.h (ada_build_task_list): Don't declare.
14688         * ada-tasks.c (struct ada_tasks_inferior_data)
14689         <task_list_valid_p>: Now bool.
14690         (read_known_tasks, ada_task_list_changed)
14691         (ada_tasks_invalidate_inferior_data): Update.
14692         (read_known_tasks_array): Return bool.
14693         (read_known_tasks_list): Likewise.
14694         (read_known_tasks): Return void.
14695         (ada_build_task_list): Now static.
14696
14697 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14698
14699         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14700         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14701
14702 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14703
14704         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14705         variant for ada_tasks_pspace_data_handle and
14706         ada_tasks_inferior_data_handle.
14707         (ada_tasks_pspace_data_cleanup): New function.
14708         (ada_tasks_inferior_data_cleanup): New function.
14709
14710 2019-02-17  Tom Tromey  <tom@tromey.com>
14711
14712         * macrotab.h (macro_source_fullname): Return a std::string.
14713         * macrotab.c (macro_include, check_for_redefinition)
14714         (macro_undef, macro_lookup_definition, foreach_macro)
14715         (foreach_macro_in_scope): Update.
14716         (macro_source_fullname): Return a std::string.
14717         * macrocmd.c (show_pp_source_pos): Update.
14718
14719 2019-02-17  Tom Tromey  <tom@tromey.com>
14720
14721         * macrocmd.c (show_pp_source_pos): Style the file names.
14722
14723 2019-02-17  Tom Tromey  <tom@tromey.com>
14724
14725         PR tui/24197:
14726         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14727
14728 2019-02-17  Tom Tromey  <tom@tromey.com>
14729
14730         * ada-lang.c (user_select_syms): Use filtered printing.
14731         * utils.c (wrap_style): New global.
14732         (desired_style): Remove.
14733         (emit_style_escape): Add stream parameter.
14734         (set_output_style, reset_terminal_style, prompt_for_continue):
14735         Update.
14736         (flush_wrap_buffer): Only flush gdb_stdout.
14737         (wrap_here): Set wrap_style.
14738         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14739         treat escape sequences as a character.  Change when wrap buffer is
14740         flushed.
14741         (fputs_styled): Do not set the output style when the default is
14742         requested.
14743         * ui-style.h (struct ui_file_style) <is_default>: New method.
14744         * source.c (print_source_lines_base): Emit escape sequences in one
14745         piece.
14746
14747 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14748
14749         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14750         integers and enumeration types.
14751
14752 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14753
14754         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14755         instead of lookup_symbol_in_language
14756         (do_exact_match): New function.
14757         (ada_get_symbol_name_matcher): Return do_exact_match when
14758         doing a verbatim match.
14759
14760 2019-02-15  Tom Tromey  <tromey@adacore.com>
14761
14762         * ravenscar-thread.c (ravenscar_thread_target::resume)
14763         (ravenscar_thread_target::wait): Special case wildcard requests.
14764
14765 2019-02-15  Tom Tromey  <tromey@adacore.com>
14766
14767         * ravenscar-thread.c (base_ptid): Remove.
14768         (struct ravenscar_thread_target) <close>: New method.
14769         <m_base_ptid>: New member.
14770         <update_inferior_ptid, active_task, task_is_currently_active,
14771         runtime_initialized>: Declare methods.
14772         <ravenscar_thread_target>: Add constructor.
14773         (ravenscar_thread_target::task_is_currently_active)
14774         (ravenscar_thread_target::update_inferior_ptid)
14775         (ravenscar_runtime_initialized): Rename.  Now methods.
14776         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14777         (ravenscar_thread_target::update_thread_list): Update.
14778         (ravenscar_thread_target::active_task): Now method.
14779         (ravenscar_thread_target::store_registers)
14780         (ravenscar_thread_target::prepare_to_store)
14781         (ravenscar_thread_target::prepare_to_store)
14782         (ravenscar_thread_target::mourn_inferior): Update.
14783         (ravenscar_inferior_created): Use "new" to create target.
14784         (ravenscar_thread_target::get_ada_task_ptid): Update.
14785         (_initialize_ravenscar): Don't initialize base_ptid.
14786         (ravenscar_ops): Remove global.
14787
14788 2019-02-15  Tom Tromey  <tromey@adacore.com>
14789
14790         * target.h (push_target): Declare new overload.
14791         * target.c (push_target): New overload, taking an rvalue reference.
14792         * remote.c (remote_target::open_1): Use push_target overload.
14793         * corelow.c (core_target_open): Use push_target overload.
14794
14795 2019-02-15  Tom Tromey  <tromey@adacore.com>
14796
14797         * ravenscar-thread.c (is_ravenscar_task)
14798         (ravenscar_task_is_currently_active): Return bool.
14799         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14800         (_initialize_ravenscar): Remove "(void)".
14801         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14802         Return bool.
14803
14804 2019-02-15  Tom Tromey  <tromey@adacore.com>
14805
14806         * ravenscar-thread.c (ravenscar_runtime_initializer)
14807         (has_ravenscar_runtime, get_running_thread_id)
14808         (ravenscar_thread_target::resume): Fix indentation.
14809
14810 2019-02-15  Tom Tromey  <tromey@adacore.com>
14811
14812         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14813         from ravenscar_arch_ops.
14814         (sparc_ravenscar_ops::fetch_registers)
14815         (sparc_ravenscar_ops::store_registers): Now methods.
14816         (sparc_ravenscar_prepare_to_store): Remove.
14817         (sparc_ravenscar_ops): Redefine.
14818         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14819         methods and destructor.  Remove members.
14820         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14821         (ravenscar_thread_target::store_registers)
14822         (ravenscar_thread_target::prepare_to_store): Update.
14823         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14824         Remove.
14825         (struct ppc_ravenscar_powerpc_ops): Derive from
14826         ravenscar_arch_ops.
14827         (ppc_ravenscar_powerpc_ops::fetch_registers)
14828         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14829         (ppc_ravenscar_powerpc_ops): Redefine.
14830         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14831         (ppc_ravenscar_e500_ops::fetch_registers)
14832         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14833         (ppc_ravenscar_e500_ops): Redefine.
14834         * aarch64-ravenscar-thread.c
14835         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14836         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14837         (aarch64_ravenscar_fetch_registers)
14838         (aarch64_ravenscar_store_registers): Now methods.
14839         (aarch64_ravenscar_ops): Redefine.
14840
14841 2019-02-15  Tom Tromey  <tromey@adacore.com>
14842
14843         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14844         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14845         (ravenscar_thread_target::stopped_by_watchpoint)
14846         (ravenscar_thread_target::stopped_data_address)
14847         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14848
14849 2019-02-15  Tom Tromey  <tromey@adacore.com>
14850
14851         * ravenscar-thread.c: Fix some typos.
14852
14853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14854             Tom Tromey  <tromey@adacore.com>
14855
14856         * ada-lang.c (ada_exception_sal): Change addr_string to a
14857         std::string.
14858         (create_ada_exception_catchpoint): Update.
14859
14860 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14861             Tom Tromey  <tromey@adacore.com>
14862
14863         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14864         (bp_location_ops): Remove.
14865         (base_breakpoint_allocate_location): Update.
14866         (free_bp_location): Update.
14867         * ada-lang.c (class ada_catchpoint_location)
14868         <ada_catchpoint_location>: Remove ops parameter.
14869         (ada_catchpoint_location_dtor): Remove.
14870         (ada_catchpoint_location_ops): Remove.
14871         (allocate_location_exception): Update.
14872         * breakpoint.h (struct bp_location_ops): Remove.
14873         (class bp_location) <bp_location>: Remove bp_location_ops
14874         parameter.
14875         <~bp_location>: Add destructor.
14876         <ops>: Remove.
14877
14878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14879             Pedro Alves  <palves@redhat.com>
14880
14881         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14882         'PATH_MAX'.
14883
14884 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14885             Samuel Thibault  <samuel.thibault@gnu.org>
14886             Thomas Schwinge  <thomas@codesourcery.com>
14887
14888         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14889         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14890
14891 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14892
14893         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14894         (check_empty): Use "const char *".
14895
14896         * gnu-nat.c (gnu_nat_target::detach): Instead of
14897         'detach_inferior (pid)' call
14898         'detach_inferior (find_inferior_pid (pid))'.
14899
14900         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14901         'nat/fork-inferior.o'.
14902         * gnu-nat.c: #include "nat/fork-inferior.h".
14903
14904         * gnu-nat.c (gnu_nat_target::detach): Instead of
14905         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14906         * gnu-nat.h: #include "inf-child.h".
14907         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14908         'i386_gnu_nat_target::fetch_registers'.
14909         (gnu_store_registers): Rename/move to
14910         'i386_gnu_nat_target::store_registers'.
14911
14912         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14913         * gnu-nat.h (mach_thread_info): New function.
14914         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14915
14916         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14917
14918 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14919
14920         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14921
14922 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14923
14924         * windows-nat.c (windows_add_thread): Add new parameter
14925         "main_thread_p" with default value set to false.  Update
14926         function documentation as well as all callers.
14927         (windows_delete_thread): Likewise.
14928         (fake_create_process): Update call to windows_add_thread.
14929         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14930         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14931         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14932         call to windows_delete_thread.
14933
14934 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14935
14936         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14937
14938 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14939
14940         * symfile.c (find_separate_debug_file): Use canonical path of
14941         sysroot with child_path instead of gdb_sysroot if it is valid.
14942
14943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14944
14945         * symfile.c (find_separate_debug_file): Use child_path to
14946         determine if an object file is under a sysroot.
14947
14948 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14949
14950         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14951         unittests/child-path-selftests.c.
14952         * common/pathstuff.c (child_path): New function.
14953         * common/pathstuff.h (child_path): New prototype.
14954         * unittests/child-path-selftests.c: New file.
14955
14956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14957
14958         * symfile.c (find_separate_debug_file): Look for separate debug
14959         files in debug directories under the sysroot.
14960
14961 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14962
14963         * symtab.h (struct minimal_symbol data_p): New const method.
14964         (struct minimal_symbol text_p): Likewise.
14965         * symtab.c (output_source_filename): Use file name style
14966         to print file name.
14967         (print_symbol_info): Likewise.
14968         (print_msymbol_info): Use address style to print addresses.
14969         Use function name style to print executable text symbols.
14970         (expand_symtab_containing_pc): Use data_p.
14971         (find_pc_sect_compunit_symtab): Likewise.
14972
14973 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14974
14975         * breakpoint.c (describe_other_breakpoints): Use address style
14976         to print addresses.
14977         (say_where): Likewise.
14978
14979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14980
14981         * ada-typeprint.c (print_func_type): Print function name
14982         style to print function name.
14983         * c-typeprint.c (c_print_type_1): Likewise.
14984
14985 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14986
14987         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14988         for execve.
14989
14990 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14991
14992         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14993         type_stack.
14994
14995 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14996
14997         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14998         TYPE_CODE_REF types.
14999
15000 2019-02-08  Jim Wilson  <jimw@sifive.com>
15001
15002         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15003         (riscv_linux_fregset): New.
15004         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15005
15006 2019-02-07  Tom Tromey  <tom@tromey.com>
15007
15008         * thread.c (thread_cancel_execution_command): Update.
15009         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15010         methods.
15011         (struct thread_fsm_ops): Remove.
15012         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15013         (thread_fsm_should_stop, thread_fsm_return_value)
15014         (thread_fsm_set_finished, thread_fsm_finished_p)
15015         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15016         Don't declare.
15017         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15018         * infrun.c (clear_proceed_status_thread)
15019         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15020         (print_stop_event): Update.
15021         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15022         Add constructor.
15023         (step_command_fsm_ops): Remove.
15024         (new_step_command_fsm): Remove.
15025         (step_1): Update.
15026         (step_command_fsm::should_stop): Rename from
15027         step_command_fsm_should_stop.
15028         (step_command_fsm::clean_up): Rename from
15029         step_command_fsm_clean_up.
15030         (step_command_fsm::do_async_reply_reason): Rename from
15031         step_command_fsm_async_reply_reason.
15032         (struct until_next_fsm): Inherit from thread_fsm.  Add
15033         constructor.
15034         (until_next_fsm_ops): Remove.
15035         (new_until_next_fsm): Remove.
15036         (until_next_fsm::should_stop): Rename from
15037         until_next_fsm_should_stop.
15038         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15039         (until_next_fsm::do_async_reply_reason): Rename from
15040         until_next_fsm_async_reply_reason.
15041         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15042         constructor.  Change type of breakpoint.
15043         (finish_command_fsm_ops): Remove.
15044         (new_finish_command_fsm): Remove.
15045         (finish_command_fsm::should_stop): Rename from
15046         finish_command_fsm_should_stop.
15047         (finish_command_fsm::clean_up): Rename from
15048         finish_command_fsm_clean_up.
15049         (finish_command_fsm::return_value): Rename from
15050         finish_command_fsm_return_value.
15051         (finish_command_fsm::do_async_reply_reason): Rename from
15052         finish_command_fsm_async_reply_reason.
15053         (finish_command): Update.
15054         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15055         Add constructor.
15056         (call_thread_fsm_ops): Remove.
15057         (call_thread_fsm::call_thread_fsm): Rename from
15058         new_call_thread_fsm.
15059         (call_thread_fsm::should_stop): Rename from
15060         call_thread_fsm_should_stop.
15061         (call_thread_fsm::should_notify_stop): Rename from
15062         call_thread_fsm_should_notify_stop.
15063         (run_inferior_call, call_function_by_hand_dummy): Update.
15064         * cli/cli-interp.c (should_print_stop_to_console): Update.
15065         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15066         Add constructor.  Change type of location_breakpoint,
15067         caller_breakpoint.
15068         (until_break_fsm_ops): Remove.
15069         (new_until_break_fsm): Remove.
15070         (until_break_fsm::should_stop): Rename from
15071         until_break_fsm_should_stop.
15072         (until_break_fsm::clean_up): Rename from
15073         until_break_fsm_clean_up.
15074         (until_break_fsm::do_async_reply_reason): Rename from
15075         until_break_fsm_async_reply_reason.
15076         (until_break_command): Update.
15077         * thread-fsm.c: Remove.
15078         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15079
15080 2019-02-07  Tom Tromey  <tom@tromey.com>
15081
15082         * yy-remap.h: Add include guard.
15083         * xtensa-tdep.h: Add include guard.
15084         * xcoffread.h: Rename include guard.
15085         * varobj-iter.h: Add include guard.
15086         * tui/tui.h: Rename include guard.
15087         * tui/tui-winsource.h: Rename include guard.
15088         * tui/tui-wingeneral.h: Rename include guard.
15089         * tui/tui-windata.h: Rename include guard.
15090         * tui/tui-win.h: Rename include guard.
15091         * tui/tui-stack.h: Rename include guard.
15092         * tui/tui-source.h: Rename include guard.
15093         * tui/tui-regs.h: Rename include guard.
15094         * tui/tui-out.h: Rename include guard.
15095         * tui/tui-layout.h: Rename include guard.
15096         * tui/tui-io.h: Rename include guard.
15097         * tui/tui-hooks.h: Rename include guard.
15098         * tui/tui-file.h: Rename include guard.
15099         * tui/tui-disasm.h: Rename include guard.
15100         * tui/tui-data.h: Rename include guard.
15101         * tui/tui-command.h: Rename include guard.
15102         * tic6x-tdep.h: Add include guard.
15103         * target/waitstatus.h: Rename include guard.
15104         * target/wait.h: Rename include guard.
15105         * target/target.h: Rename include guard.
15106         * target/resume.h: Rename include guard.
15107         * target-float.h: Rename include guard.
15108         * stabsread.h: Add include guard.
15109         * rs6000-tdep.h: Add include guard.
15110         * riscv-fbsd-tdep.h: Add include guard.
15111         * regformats/regdef.h: Rename include guard.
15112         * record.h: Rename include guard.
15113         * python/python.h: Rename include guard.
15114         * python/python-internal.h: Rename include guard.
15115         * python/py-stopevent.h: Rename include guard.
15116         * python/py-ref.h: Rename include guard.
15117         * python/py-record.h: Rename include guard.
15118         * python/py-record-full.h: Rename include guard.
15119         * python/py-record-btrace.h: Rename include guard.
15120         * python/py-instruction.h: Rename include guard.
15121         * python/py-events.h: Rename include guard.
15122         * python/py-event.h: Rename include guard.
15123         * procfs.h: Add include guard.
15124         * proc-utils.h: Add include guard.
15125         * p-lang.h: Add include guard.
15126         * or1k-tdep.h: Rename include guard.
15127         * observable.h: Rename include guard.
15128         * nto-tdep.h: Rename include guard.
15129         * nat/x86-linux.h: Rename include guard.
15130         * nat/x86-linux-dregs.h: Rename include guard.
15131         * nat/x86-gcc-cpuid.h: Add include guard.
15132         * nat/x86-dregs.h: Rename include guard.
15133         * nat/x86-cpuid.h: Rename include guard.
15134         * nat/ppc-linux.h: Rename include guard.
15135         * nat/mips-linux-watch.h: Rename include guard.
15136         * nat/linux-waitpid.h: Rename include guard.
15137         * nat/linux-ptrace.h: Rename include guard.
15138         * nat/linux-procfs.h: Rename include guard.
15139         * nat/linux-osdata.h: Rename include guard.
15140         * nat/linux-nat.h: Rename include guard.
15141         * nat/linux-namespaces.h: Rename include guard.
15142         * nat/linux-btrace.h: Rename include guard.
15143         * nat/glibc_thread_db.h: Rename include guard.
15144         * nat/gdb_thread_db.h: Rename include guard.
15145         * nat/gdb_ptrace.h: Rename include guard.
15146         * nat/fork-inferior.h: Rename include guard.
15147         * nat/amd64-linux-siginfo.h: Rename include guard.
15148         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15149         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15150         * nat/aarch64-linux.h: Rename include guard.
15151         * nat/aarch64-linux-hw-point.h: Rename include guard.
15152         * mn10300-tdep.h: Add include guard.
15153         * mips-linux-tdep.h: Add include guard.
15154         * mi/mi-parse.h: Rename include guard.
15155         * mi/mi-out.h: Rename include guard.
15156         * mi/mi-main.h: Rename include guard.
15157         * mi/mi-interp.h: Rename include guard.
15158         * mi/mi-getopt.h: Rename include guard.
15159         * mi/mi-console.h: Rename include guard.
15160         * mi/mi-common.h: Rename include guard.
15161         * mi/mi-cmds.h: Rename include guard.
15162         * mi/mi-cmd-break.h: Rename include guard.
15163         * m2-lang.h: Add include guard.
15164         * location.h: Rename include guard.
15165         * linux-record.h: Rename include guard.
15166         * linux-nat.h: Add include guard.
15167         * linux-fork.h: Add include guard.
15168         * i386-darwin-tdep.h: Rename include guard.
15169         * hppa-linux-offsets.h: Add include guard.
15170         * guile/guile.h: Rename include guard.
15171         * guile/guile-internal.h: Rename include guard.
15172         * gnu-nat.h: Rename include guard.
15173         * gdb-stabs.h: Rename include guard.
15174         * frv-tdep.h: Add include guard.
15175         * f-lang.h: Add include guard.
15176         * event-loop.h: Add include guard.
15177         * darwin-nat.h: Rename include guard.
15178         * cp-abi.h: Rename include guard.
15179         * config/sparc/nm-sol2.h: Rename include guard.
15180         * config/nm-nto.h: Rename include guard.
15181         * config/nm-linux.h: Add include guard.
15182         * config/i386/nm-i386gnu.h: Rename include guard.
15183         * config/djgpp/nl_types.h: Rename include guard.
15184         * config/djgpp/langinfo.h: Rename include guard.
15185         * compile/gcc-cp-plugin.h: Add include guard.
15186         * compile/gcc-c-plugin.h: Add include guard.
15187         * compile/compile.h: Rename include guard.
15188         * compile/compile-object-run.h: Rename include guard.
15189         * compile/compile-object-load.h: Rename include guard.
15190         * compile/compile-internal.h: Rename include guard.
15191         * compile/compile-cplus.h: Rename include guard.
15192         * compile/compile-c.h: Rename include guard.
15193         * common/xml-utils.h: Rename include guard.
15194         * common/x86-xstate.h: Rename include guard.
15195         * common/version.h: Rename include guard.
15196         * common/vec.h: Rename include guard.
15197         * common/tdesc.h: Rename include guard.
15198         * common/selftest.h: Rename include guard.
15199         * common/scoped_restore.h: Rename include guard.
15200         * common/scoped_mmap.h: Rename include guard.
15201         * common/scoped_fd.h: Rename include guard.
15202         * common/safe-iterator.h: Rename include guard.
15203         * common/run-time-clock.h: Rename include guard.
15204         * common/refcounted-object.h: Rename include guard.
15205         * common/queue.h: Rename include guard.
15206         * common/ptid.h: Rename include guard.
15207         * common/print-utils.h: Rename include guard.
15208         * common/preprocessor.h: Rename include guard.
15209         * common/pathstuff.h: Rename include guard.
15210         * common/observable.h: Rename include guard.
15211         * common/netstuff.h: Rename include guard.
15212         * common/job-control.h: Rename include guard.
15213         * common/host-defs.h: Rename include guard.
15214         * common/gdb_wait.h: Rename include guard.
15215         * common/gdb_vecs.h: Rename include guard.
15216         * common/gdb_unlinker.h: Rename include guard.
15217         * common/gdb_unique_ptr.h: Rename include guard.
15218         * common/gdb_tilde_expand.h: Rename include guard.
15219         * common/gdb_sys_time.h: Rename include guard.
15220         * common/gdb_string_view.h: Rename include guard.
15221         * common/gdb_splay_tree.h: Rename include guard.
15222         * common/gdb_setjmp.h: Rename include guard.
15223         * common/gdb_ref_ptr.h: Rename include guard.
15224         * common/gdb_optional.h: Rename include guard.
15225         * common/gdb_locale.h: Rename include guard.
15226         * common/gdb_assert.h: Rename include guard.
15227         * common/filtered-iterator.h: Rename include guard.
15228         * common/filestuff.h: Rename include guard.
15229         * common/fileio.h: Rename include guard.
15230         * common/environ.h: Rename include guard.
15231         * common/common-utils.h: Rename include guard.
15232         * common/common-types.h: Rename include guard.
15233         * common/common-regcache.h: Rename include guard.
15234         * common/common-inferior.h: Rename include guard.
15235         * common/common-gdbthread.h: Rename include guard.
15236         * common/common-exceptions.h: Rename include guard.
15237         * common/common-defs.h: Rename include guard.
15238         * common/common-debug.h: Rename include guard.
15239         * common/cleanups.h: Rename include guard.
15240         * common/buffer.h: Rename include guard.
15241         * common/btrace-common.h: Rename include guard.
15242         * common/break-common.h: Rename include guard.
15243         * cli/cli-utils.h: Rename include guard.
15244         * cli/cli-style.h: Rename include guard.
15245         * cli/cli-setshow.h: Rename include guard.
15246         * cli/cli-script.h: Rename include guard.
15247         * cli/cli-interp.h: Rename include guard.
15248         * cli/cli-decode.h: Rename include guard.
15249         * cli/cli-cmds.h: Rename include guard.
15250         * charset-list.h: Add include guard.
15251         * buildsym-legacy.h: Rename include guard.
15252         * bfin-tdep.h: Add include guard.
15253         * ax.h: Rename include guard.
15254         * arm-linux-tdep.h: Add include guard.
15255         * arm-fbsd-tdep.h: Add include guard.
15256         * arch/xtensa.h: Rename include guard.
15257         * arch/tic6x.h: Add include guard.
15258         * arch/i386.h: Add include guard.
15259         * arch/arm.h: Rename include guard.
15260         * arch/arm-linux.h: Rename include guard.
15261         * arch/arm-get-next-pcs.h: Rename include guard.
15262         * arch/amd64.h: Add include guard.
15263         * arch/aarch64-insn.h: Rename include guard.
15264         * arch-utils.h: Rename include guard.
15265         * annotate.h: Add include guard.
15266         * amd64-darwin-tdep.h: Rename include guard.
15267         * aarch64-linux-tdep.h: Add include guard.
15268         * aarch64-fbsd-tdep.h: Add include guard.
15269         * aarch32-linux-nat.h: Add include guard.
15270
15271 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15272
15273         * macrotab.c (macro_define_internal): New function that
15274         factorizes macro_define_object_internal and macro_define_function
15275         code.
15276         (macro_define_object_internal): Use macro_define_internal.
15277         (macro_define_function): Likewise.
15278
15279 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15280
15281         * macrocmd.c (extract_identifier): Return
15282         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15283         callers.
15284
15285 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15286
15287         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15288
15289 2019-02-05  Tom Tromey  <tom@tromey.com>
15290
15291         * target.c (target_stack::unpush): Move assertion earlier.
15292
15293 2019-01-30  Tom Tromey  <tom@tromey.com>
15294
15295         PR python/23615:
15296         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15297         (gdbpy_parse_and_eval): Likewise.
15298         * python/python-internal.h (gdbpy_allow_threads): New class.
15299
15300 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15301
15302         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15303         (aarch64_fbsd_fpregmap): Move earlier.
15304         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15305         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15306         instead of individual calls to trad_frame_set_reg_addr.
15307         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15308         earlier.
15309         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15310         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15311         instead of individual calls to trad_frame_set_reg_addr.
15312
15313 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15314
15315         * CONTRIBUTE: Replace contribution list with wiki link.
15316
15317 2019-01-25  Tom Tromey  <tom@tromey.com>
15318
15319         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15320
15321 2019-01-25  Tom Tromey  <tom@tromey.com>
15322
15323         * xtensa-linux-nat.c: Fix common/ includes.
15324         * xml-support.h: Fix common/ includes.
15325         * xml-support.c: Fix common/ includes.
15326         * x86-linux-nat.c: Fix common/ includes.
15327         * windows-nat.c: Fix common/ includes.
15328         * varobj.h: Fix common/ includes.
15329         * varobj.c: Fix common/ includes.
15330         * value.c: Fix common/ includes.
15331         * valops.c: Fix common/ includes.
15332         * utils.c: Fix common/ includes.
15333         * unittests/xml-utils-selftests.c: Fix common/ includes.
15334         * unittests/utils-selftests.c: Fix common/ includes.
15335         * unittests/unpack-selftests.c: Fix common/ includes.
15336         * unittests/tracepoint-selftests.c: Fix common/ includes.
15337         * unittests/style-selftests.c: Fix common/ includes.
15338         * unittests/string_view-selftests.c: Fix common/ includes.
15339         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15340         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15341         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15342         * unittests/rsp-low-selftests.c: Fix common/ includes.
15343         * unittests/parse-connection-spec-selftests.c: Fix common/
15344         includes.
15345         * unittests/optional-selftests.c: Fix common/ includes.
15346         * unittests/offset-type-selftests.c: Fix common/ includes.
15347         * unittests/observable-selftests.c: Fix common/ includes.
15348         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15349         * unittests/memrange-selftests.c: Fix common/ includes.
15350         * unittests/memory-map-selftests.c: Fix common/ includes.
15351         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15352         * unittests/function-view-selftests.c: Fix common/ includes.
15353         * unittests/environ-selftests.c: Fix common/ includes.
15354         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15355         * unittests/common-utils-selftests.c: Fix common/ includes.
15356         * unittests/cli-utils-selftests.c: Fix common/ includes.
15357         * unittests/array-view-selftests.c: Fix common/ includes.
15358         * ui-file.c: Fix common/ includes.
15359         * tui/tui-io.c: Fix common/ includes.
15360         * tracepoint.h: Fix common/ includes.
15361         * tracepoint.c: Fix common/ includes.
15362         * tracefile-tfile.c: Fix common/ includes.
15363         * top.h: Fix common/ includes.
15364         * top.c: Fix common/ includes.
15365         * thread.c: Fix common/ includes.
15366         * target/waitstatus.h: Fix common/ includes.
15367         * target/waitstatus.c: Fix common/ includes.
15368         * target.h: Fix common/ includes.
15369         * target.c: Fix common/ includes.
15370         * target-memory.c: Fix common/ includes.
15371         * target-descriptions.c: Fix common/ includes.
15372         * symtab.h: Fix common/ includes.
15373         * symfile.c: Fix common/ includes.
15374         * stap-probe.c: Fix common/ includes.
15375         * spu-linux-nat.c: Fix common/ includes.
15376         * sparc-nat.c: Fix common/ includes.
15377         * source.c: Fix common/ includes.
15378         * solib.c: Fix common/ includes.
15379         * solib-target.c: Fix common/ includes.
15380         * ser-unix.c: Fix common/ includes.
15381         * ser-tcp.c: Fix common/ includes.
15382         * ser-pipe.c: Fix common/ includes.
15383         * ser-base.c: Fix common/ includes.
15384         * selftest-arch.c: Fix common/ includes.
15385         * s12z-tdep.c: Fix common/ includes.
15386         * rust-exp.y: Fix common/ includes.
15387         * rs6000-aix-tdep.c: Fix common/ includes.
15388         * riscv-tdep.c: Fix common/ includes.
15389         * remote.c: Fix common/ includes.
15390         * remote-notif.h: Fix common/ includes.
15391         * remote-fileio.h: Fix common/ includes.
15392         * remote-fileio.c: Fix common/ includes.
15393         * regcache.h: Fix common/ includes.
15394         * regcache.c: Fix common/ includes.
15395         * record-btrace.c: Fix common/ includes.
15396         * python/python.c: Fix common/ includes.
15397         * python/py-type.c: Fix common/ includes.
15398         * python/py-inferior.c: Fix common/ includes.
15399         * progspace.h: Fix common/ includes.
15400         * producer.c: Fix common/ includes.
15401         * procfs.c: Fix common/ includes.
15402         * proc-api.c: Fix common/ includes.
15403         * printcmd.c: Fix common/ includes.
15404         * ppc-linux-nat.c: Fix common/ includes.
15405         * parser-defs.h: Fix common/ includes.
15406         * osdata.c: Fix common/ includes.
15407         * obsd-nat.c: Fix common/ includes.
15408         * nat/x86-linux.c: Fix common/ includes.
15409         * nat/x86-linux-dregs.c: Fix common/ includes.
15410         * nat/x86-dregs.h: Fix common/ includes.
15411         * nat/x86-dregs.c: Fix common/ includes.
15412         * nat/ppc-linux.c: Fix common/ includes.
15413         * nat/mips-linux-watch.h: Fix common/ includes.
15414         * nat/mips-linux-watch.c: Fix common/ includes.
15415         * nat/linux-waitpid.c: Fix common/ includes.
15416         * nat/linux-ptrace.h: Fix common/ includes.
15417         * nat/linux-ptrace.c: Fix common/ includes.
15418         * nat/linux-procfs.c: Fix common/ includes.
15419         * nat/linux-personality.c: Fix common/ includes.
15420         * nat/linux-osdata.c: Fix common/ includes.
15421         * nat/linux-namespaces.c: Fix common/ includes.
15422         * nat/linux-btrace.h: Fix common/ includes.
15423         * nat/linux-btrace.c: Fix common/ includes.
15424         * nat/fork-inferior.c: Fix common/ includes.
15425         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15426         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15427         * nat/aarch64-linux.c: Fix common/ includes.
15428         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15429         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15430         * namespace.h: Fix common/ includes.
15431         * mips-linux-tdep.c: Fix common/ includes.
15432         * minsyms.c: Fix common/ includes.
15433         * mi/mi-parse.h: Fix common/ includes.
15434         * mi/mi-main.c: Fix common/ includes.
15435         * mi/mi-cmd-env.c: Fix common/ includes.
15436         * memrange.h: Fix common/ includes.
15437         * memattr.c: Fix common/ includes.
15438         * maint.h: Fix common/ includes.
15439         * maint.c: Fix common/ includes.
15440         * main.c: Fix common/ includes.
15441         * machoread.c: Fix common/ includes.
15442         * location.c: Fix common/ includes.
15443         * linux-thread-db.c: Fix common/ includes.
15444         * linux-nat.c: Fix common/ includes.
15445         * linux-fork.c: Fix common/ includes.
15446         * inline-frame.c: Fix common/ includes.
15447         * infrun.c: Fix common/ includes.
15448         * inflow.c: Fix common/ includes.
15449         * inferior.h: Fix common/ includes.
15450         * inferior.c: Fix common/ includes.
15451         * infcmd.c: Fix common/ includes.
15452         * inf-ptrace.c: Fix common/ includes.
15453         * inf-child.c: Fix common/ includes.
15454         * ia64-linux-nat.c: Fix common/ includes.
15455         * i387-tdep.c: Fix common/ includes.
15456         * i386-tdep.c: Fix common/ includes.
15457         * i386-linux-tdep.c: Fix common/ includes.
15458         * i386-linux-nat.c: Fix common/ includes.
15459         * i386-go32-tdep.c: Fix common/ includes.
15460         * i386-fbsd-tdep.c: Fix common/ includes.
15461         * i386-fbsd-nat.c: Fix common/ includes.
15462         * guile/scm-type.c: Fix common/ includes.
15463         * guile/guile.c: Fix common/ includes.
15464         * go32-nat.c: Fix common/ includes.
15465         * gnu-nat.c: Fix common/ includes.
15466         * gdbthread.h: Fix common/ includes.
15467         * gdbarch-selftests.c: Fix common/ includes.
15468         * gdb_usleep.c: Fix common/ includes.
15469         * gdb_select.h: Fix common/ includes.
15470         * gdb_bfd.c: Fix common/ includes.
15471         * gcore.c: Fix common/ includes.
15472         * fork-child.c: Fix common/ includes.
15473         * findvar.c: Fix common/ includes.
15474         * fbsd-nat.c: Fix common/ includes.
15475         * event-top.c: Fix common/ includes.
15476         * event-loop.c: Fix common/ includes.
15477         * dwarf2read.c: Fix common/ includes.
15478         * dwarf2loc.c: Fix common/ includes.
15479         * dwarf2-frame.c: Fix common/ includes.
15480         * dwarf-index-cache.c: Fix common/ includes.
15481         * dtrace-probe.c: Fix common/ includes.
15482         * disasm-selftests.c: Fix common/ includes.
15483         * defs.h: Fix common/ includes.
15484         * csky-tdep.c: Fix common/ includes.
15485         * cp-valprint.c: Fix common/ includes.
15486         * cp-support.h: Fix common/ includes.
15487         * cp-support.c: Fix common/ includes.
15488         * corelow.c: Fix common/ includes.
15489         * completer.h: Fix common/ includes.
15490         * completer.c: Fix common/ includes.
15491         * compile/compile.c: Fix common/ includes.
15492         * compile/compile-loc2c.c: Fix common/ includes.
15493         * compile/compile-cplus-types.c: Fix common/ includes.
15494         * compile/compile-cplus-symbols.c: Fix common/ includes.
15495         * command.h: Fix common/ includes.
15496         * cli/cli-dump.c: Fix common/ includes.
15497         * cli/cli-cmds.c: Fix common/ includes.
15498         * charset.c: Fix common/ includes.
15499         * build-id.c: Fix common/ includes.
15500         * btrace.h: Fix common/ includes.
15501         * btrace.c: Fix common/ includes.
15502         * breakpoint.h: Fix common/ includes.
15503         * breakpoint.c: Fix common/ includes.
15504         * ax.h:
15505         (enum agent_op): Fix common/ includes.
15506         * ax-general.c (struct aop_map): Fix common/ includes.
15507         * ax-gdb.c: Fix common/ includes.
15508         * auxv.c: Fix common/ includes.
15509         * auto-load.c: Fix common/ includes.
15510         * arm-tdep.c: Fix common/ includes.
15511         * arch/riscv.c: Fix common/ includes.
15512         * arch/ppc-linux-common.c: Fix common/ includes.
15513         * arch/i386.c: Fix common/ includes.
15514         * arch/arm.c: Fix common/ includes.
15515         * arch/arm-linux.c: Fix common/ includes.
15516         * arch/arm-get-next-pcs.c: Fix common/ includes.
15517         * arch/amd64.c: Fix common/ includes.
15518         * arch/aarch64.c: Fix common/ includes.
15519         * arch/aarch64-insn.c: Fix common/ includes.
15520         * arch-utils.c: Fix common/ includes.
15521         * amd64-windows-tdep.c: Fix common/ includes.
15522         * amd64-tdep.c: Fix common/ includes.
15523         * amd64-sol2-tdep.c: Fix common/ includes.
15524         * amd64-obsd-tdep.c: Fix common/ includes.
15525         * amd64-nbsd-tdep.c: Fix common/ includes.
15526         * amd64-linux-tdep.c: Fix common/ includes.
15527         * amd64-linux-nat.c: Fix common/ includes.
15528         * amd64-fbsd-tdep.c: Fix common/ includes.
15529         * amd64-fbsd-nat.c: Fix common/ includes.
15530         * amd64-dicos-tdep.c: Fix common/ includes.
15531         * amd64-darwin-tdep.c: Fix common/ includes.
15532         * agent.c: Fix common/ includes.
15533         * ada-lang.h: Fix common/ includes.
15534         * ada-lang.c: Fix common/ includes.
15535         * aarch64-tdep.c: Fix common/ includes.
15536
15537 2019-01-25  Tom Tromey  <tom@tromey.com>
15538
15539         * common/create-version.sh: Use common/version.h.
15540
15541 2019-01-24  Pedro Alves  <palves@redhat.com>
15542
15543         * infrun.c (signal_stop, signal_print, signal_program)
15544         (signal_catch, signal_pass): Now arrays instead of pointers.
15545         (update_signals_program_target, do_target_resume)
15546         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15547         * linux-nat.c (linux_nat_target::pass_signals)
15548         (linux_nat_target::create_inferior, linux_nat_target::attach):
15549         Adjust.
15550         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15551         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15552         * procfs.c (procfs_target::pass_signals): Adjust.
15553         * record-full.c (record_full_target::resume): Adjust.
15554         * remote.c (remote_target::pass_signals)
15555         (remote_target::program_signals): Adjust.
15556         * target-debug.h (target_debug_print_signals): Now takes a
15557         gdb::array_view as parameter.  Adjust.
15558         * target.h (target_ops) <pass_signals, program_signals>: Replace
15559         pointer and length parameters with gdb::array_view.
15560         (target_pass_signals, target_program_signals): Likewise.
15561         * target-delegates.c: Regenerate.
15562
15563 2019-01-24  Pedro Alves  <palves@redhat.com>
15564
15565         * common/forward-scope-exit.h
15566         (forward_scope_exit::forward_scope_exit): Pass arguments to
15567         m_bind_function directly, instead of creating a std::bind and
15568         copying that.
15569
15570 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15571
15572         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15573         for static members.
15574         (pass_in_v_vfp_candidate): Likewise.
15575
15576 2019-01-23  Tom Tromey  <tom@tromey.com>
15577             Pedro Alves  <palves@redhat.com>
15578
15579         * regcache.c (class regcache_invalidator): Remove.
15580         (regcache::raw_write): Use make_scope_exit.
15581
15582 2019-01-23  Tom Tromey  <tom@tromey.com>
15583
15584         * ui-out.h (class ui_out_emit_type): Update comment.
15585
15586 2019-01-23  Tom Tromey  <tom@tromey.com>
15587
15588         * infrun.c (fetch_inferior_event): Update comment.
15589
15590 2019-01-23  Tom Tromey  <tom@tromey.com>
15591             Pedro Alves  <palves@redhat.com>
15592
15593         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15594         parameter.
15595         (fetch_inferior_event): Use SCOPE_EXIT.
15596
15597
15598 2019-01-23  Tom Tromey  <tom@tromey.com>
15599             Pedro Alves  <palves@redhat.com>
15600
15601         * infrun.c (disable_thread_events): Delete.
15602         (stop_all_threads): Use SCOPE_EXIT.
15603
15604 2019-01-23  Tom Tromey  <tom@tromey.com>
15605             Pedro Alves  <palves@redhat.com>
15606
15607         * symfile.c: Include forward-scope-exit.h.
15608         (clear_symtab_users_cleanup): Replace forward declaration with
15609         a FORWARD_SCOPE_EXIT.
15610         (syms_from_objfile_1): Use the forward_scope_exit and
15611         gdb::optional instead of cleanup_function.
15612         (reread_symbols): Use the forward_scope_exit instead of
15613         cleanup_function.
15614         (clear_symtab_users_cleanup): Remove function.
15615
15616 2019-01-23  Tom Tromey  <tom@tromey.com>
15617             Pedro Alves  <palves@redhat.com>
15618
15619         * linux-nat.c: Include scope-exit.h.
15620         (cleanup_target_stop): Remove.
15621         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15622         SCOPE_EXIT.
15623
15624 2019-01-23  Tom Tromey  <tom@tromey.com>
15625             Pedro Alves  <palves@redhat.com>
15626
15627         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15628         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15629
15630 2019-01-23  Tom Tromey  <tom@tromey.com>
15631             Andrew Burgess  <andrew.burgess@embecosm.com>
15632             Pedro Alves  <palves@redhat.com>
15633
15634         * infrun.c (fetch_inferior_event): Use scope_exit.
15635         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15636         * top.c (execute_command): Use scope_exit.
15637         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15638         * utils.c (do_bpstat_clear_actions_cleanup)
15639         (make_bpstat_clear_actions_cleanup): Remove.
15640
15641 2019-01-23  Tom Tromey  <tom@tromey.com>
15642             Pedro Alves  <palves@redhat.com>
15643
15644         * infrun.c: Include "common/scope-exit.h"
15645         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15646         (wait_for_inferior): Use SCOPE_EXIT.
15647         (fetch_inferior_event): Use scope_exit.
15648
15649 2019-01-23  Tom Tromey  <tom@tromey.com>
15650             Pedro Alves  <palves@redhat.com>
15651
15652         * breakpoint.c (create_breakpoint): Remove cleanup.
15653
15654 2019-01-23  Tom Tromey  <tom@tromey.com>
15655             Andrew Burgess  <andrew.burgess@embecosm.com>
15656             Pedro Alves  <palves@redhat.com>
15657
15658 2019-01-23  Pedro Alves  <palves@redhat.com>
15659
15660         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15661
15662 2019-01-23  Pedro Alves  <palves@redhat.com>
15663             Andrew Burgess  <andrew.burgess@embecosm.com>
15664
15665         * gdbthread.h: Include "common/forward-scope-exit.h".
15666         (scoped_finish_thread_state): Redefine custom class in terms of
15667         forward_scope_exit.
15668
15669 2019-01-23  Pedro Alves  <palves@redhat.com>
15670             Andrew Burgess  <andrew.burgess@embecosm.com>
15671
15672         * common/forward-scope-exit.h: New file.
15673
15674 2019-01-23  Pedro Alves  <palves@redhat.com>
15675             Andrew Burgess  <andrew.burgess@embecosm.com>
15676             Tom Tromey  <tom@tromey.com>
15677
15678         * common/scope-exit.h: New file.
15679
15680 2019-01-23  Pedro Alves  <palves@redhat.com>
15681
15682         * common/preprocessor.h (ESC): Rename to ...
15683         (ESC_PARENS): ... this.
15684         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15685         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15686
15687 2019-01-23  Tom Tromey  <tom@tromey.com>
15688
15689         * language.h (class scoped_switch_to_sym_language_if_auto):
15690         Initialize m_lang in both cases.
15691
15692 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15693
15694         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15695         with XCNEW.
15696
15697 2019-01-22  Tom Tromey  <tom@tromey.com>
15698
15699         * corelow.c: Do not include sys/file.h.
15700
15701 2019-01-22  Tom Tromey  <tom@tromey.com>
15702
15703         * tui/tui-wingeneral.h: Include gdb_curses.h.
15704
15705 2019-01-22  Tom Tromey  <tom@tromey.com>
15706
15707         * source-cache.h (class source_cache) <get_source_lines,
15708         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15709
15710 2019-01-22  Tom Tromey  <tom@tromey.com>
15711
15712         * remote-fileio.h (struct remote_target): Declare.
15713
15714 2019-01-22  Tom Tromey  <tom@tromey.com>
15715
15716         * python/py-arch.c: Do not include py-ref.h.
15717         * python/py-bpevent.c: Do not include py-ref.h.
15718         * python/py-cmd.c: Do not include py-ref.h.
15719         * python/py-continueevent.c: Do not include py-ref.h.
15720         * python/py-event.h: Do not include py-ref.h.
15721         * python/py-evtregistry.c: Do not include py-ref.h.
15722         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15723         * python/py-frame.c: Do not include py-ref.h.
15724         * python/py-framefilter.c: Do not include py-ref.h.
15725         * python/py-function.c: Do not include py-ref.h.
15726         * python/py-infevents.c: Do not include py-ref.h.
15727         * python/py-linetable.c: Do not include py-ref.h.
15728         * python/py-objfile.c: Do not include py-ref.h.
15729         * python/py-param.c: Do not include py-ref.h.
15730         * python/py-prettyprint.c: Do not include py-ref.h.
15731         * python/py-progspace.c: Do not include py-ref.h.
15732         * python/py-symbol.c: Do not include py-ref.h.
15733         * python/py-symtab.c: Do not include py-ref.h.
15734         * python/py-type.c: Do not include py-ref.h.
15735         * python/py-unwind.c: Do not include py-ref.h.
15736         * python/py-utils.c: Do not include py-ref.h.
15737         * python/py-value.c: Do not include py-ref.h.
15738         * python/py-varobj.c: Do not include py-ref.h.
15739         * python/py-xmethods.c: Do not include py-ref.h.
15740         * python/python.c: Do not include py-ref.h.
15741         * varobj.c: Do not include py-ref.h.
15742
15743 2019-01-22  Tom Tromey  <tom@tromey.com>
15744
15745         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15746         keyword for bcache.
15747
15748 2019-01-22  Tom Tromey  <tom@tromey.com>
15749
15750         * compile/compile-cplus-types.c: Remove a comment by #include.
15751
15752 2019-01-22  Tom Tromey  <tom@tromey.com>
15753
15754         * compile/gcc-c-plugin.h: Include compile-internal.h.
15755
15756 2019-01-22  Tom Tromey  <tom@tromey.com>
15757
15758         * stabsread.c (EXTERN): Do not define.
15759         (symnum, next_symbol_text_func, processing_gcc_compilation)
15760         (within_function, global_sym_chain, global_stabs)
15761         (previous_stab_code, this_object_header_files)
15762         (n_this_object_header_files)
15763         (n_allocated_this_object_header_files): Define.
15764         * stabsread.h (EXTERN): Never define.  Use "extern".
15765
15766 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15767
15768         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15769         history_value.
15770
15771 2019-01-21  Tom Tromey  <tom@tromey.com>
15772
15773         * ui-out.c: Fix includes.
15774         * tui/tui-source.c: Fix includes.
15775         * target.c: Fix includes.
15776         * remote.c: Fix includes.
15777         * regcache.c: Fix includes.
15778         * python/py-block.c: Fix includes.
15779         * printcmd.c: Fix includes.
15780         * or1k-tdep.c: Fix includes.
15781         * mi/mi-main.c: Fix includes.
15782         * m32r-tdep.c: Fix includes.
15783         * csky-tdep.c: Fix includes.
15784         * compile/compile-cplus-types.c: Fix includes.
15785         * cli/cli-interp.c: Fix includes.
15786
15787 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15788
15789         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15790         for padding.
15791
15792 2019-01-16  Tom Tromey  <tom@tromey.com>
15793
15794         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15795         earlier.
15796         (struct objfile) <msymbols_range>: Move from top level.
15797         <msymbols>: New method.
15798         (class objfile_msymbols): Remove.
15799         * symtab.c (default_collect_symbol_completion_matches_break_on):
15800         Update.
15801         * symmisc.c (dump_msymbols): Update.
15802         * stabsread.c (scan_file_globals): Update.
15803         * objc-lang.c (info_selectors_command, info_classes_command)
15804         (find_methods): Update.
15805         * minsyms.c (find_solib_trampoline_target): Update.
15806         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15807         * coffread.c (coff_symfile_read): Update.
15808         * ada-lang.c (ada_lookup_simple_minsym)
15809         (ada_collect_symbol_completion_matches): Update.
15810
15811 2019-01-16  Tom Tromey  <tom@tromey.com>
15812
15813         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15814         type.  Remove no-argument constructor.
15815         <iterator::operator++>: Simplify.
15816         <begin>: Update.
15817         <end>: Use minimal_symbol_count.
15818
15819 2019-01-16  Tom Tromey  <tom@tromey.com>
15820
15821         * objfiles.h (struct objfile) <psymtabs>: New method.
15822         (class objfile_psymtabs): Remove.
15823         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15824         typedef.
15825         <range>: New method.
15826         (require_partial_symbols): Change return type.
15827         * psymtab.c (require_partial_symbols)
15828         (psym_expand_symtabs_matching): Update.
15829         * mdebugread.c (parse_partial_symbols): Update.
15830         * dbxread.c (dbx_end_psymtab): Update.
15831
15832 2019-01-15  Tom Tromey  <tom@tromey.com>
15833
15834         * symtab.c (lookup_objfile_from_block)
15835         (lookup_symbol_in_objfile_symtabs)
15836         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15837         (find_line_symtab, info_sources_command)
15838         (default_collect_symbol_completion_matches_break_on)
15839         (make_source_files_completion_list): Update.
15840         * symmisc.c (print_objfile_statistics, dump_objfile)
15841         (maintenance_print_symbols, maintenance_info_symtabs)
15842         (maintenance_check_symtabs, maintenance_info_line_tables):
15843         Update.
15844         * source.c (select_source_symtab)
15845         (forget_cached_source_info_for_objfile): Update.
15846         * objfiles.h (class objfile_compunits): Remove.
15847         (struct objfile) <compunits_range>: New typedef.
15848         (compunits): New method.
15849         * objfiles.c (objfile_relocate1): Update.
15850         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15851         * maint.c (count_symtabs_and_blocks): Update.
15852         * linespec.c (iterate_over_all_matching_symtabs): Update.
15853         * cp-support.c (add_symbol_overload_list_qualified): Update.
15854         * coffread.c (coff_symtab_read): Update.
15855         * ada-lang.c (add_nonlocal_symbols)
15856         (ada_collect_symbol_completion_matches)
15857         (ada_add_global_exceptions): Update.
15858
15859 2019-01-15  Tom Tromey  <tom@tromey.com>
15860
15861         * progspace.h (program_space) <objfiles_safe_range>: New
15862         typedef.
15863         <objfiles_safe>: New method.
15864         * objfiles.h (class all_objfiles_safe): Remove.
15865         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15866         * jit.c (jit_inferior_exit_hook): Update.
15867
15868 2019-01-17  Tom Tromey  <tom@tromey.com>
15869
15870         * progspace.h (program_space) <objfiles_range>: New typedef.
15871         <objfiles>: New method.
15872         <objfiles_head>: Rename from objfiles.
15873         (object_files): Update.
15874         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15875         * guile/scm-pretty-print.c
15876         (ppscm_find_pretty_printer_from_objfiles): Update.
15877         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15878         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15879         Update.
15880         * python/py-progspace.c (pspy_get_objfiles): Update.
15881         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15882         Update.
15883         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15884         (objfpy_lookup_objfile_by_build_id): Update.
15885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15886         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15887         Update.
15888         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15889         (expand_symtab_containing_pc, lookup_objfile_from_block)
15890         (lookup_static_symbol, basic_lookup_transparent_type)
15891         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15892         (find_line_symtab, info_sources_command)
15893         (default_collect_symbol_completion_matches_break_on)
15894         (make_source_files_completion_list, find_main_name): Update.
15895         * symmisc.c (print_symbol_bcache_statistics)
15896         (print_objfile_statistics, maintenance_print_symbols)
15897         (maintenance_print_msymbols, maintenance_print_objfiles)
15898         (maintenance_info_symtabs, maintenance_check_symtabs)
15899         (maintenance_expand_symtabs, maintenance_info_line_tables):
15900         Update.
15901         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15902         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15903         (map_overlay_command, unmap_overlay_command)
15904         (simple_overlay_update, expand_symtabs_matching)
15905         (map_symbol_filenames): Update.
15906         * symfile-debug.c (set_debug_symfile): Update.
15907         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15908         Update.
15909         * source.c (select_source_symtab, forget_cached_source_info):
15910         Update.
15911         * solib.c (solib_read_symbols): Update.
15912         * solib-spu.c (append_ocl_sos): Update.
15913         * psymtab.c (maintenance_print_psymbols)
15914         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15915         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15916         * printcmd.c (info_symbol_command): Update.
15917         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15918         Update.
15919         * objfiles.h (class all_objfiles): Remove.
15920         * objfiles.c (have_partial_symbols, have_full_symbols)
15921         (have_minimal_symbols, qsort_cmp, update_section_map)
15922         (shared_objfile_contains_address_p)
15923         (default_iterate_over_objfiles_in_search_order): Update.
15924         * objc-lang.c (info_selectors_command, info_classes_command)
15925         (find_methods): Update.
15926         * minsyms.c (find_solib_trampoline_target): Update.
15927         * maint.c (maintenance_info_sections)
15928         (maintenance_translate_address, count_symtabs_and_blocks):
15929         Update.
15930         * main.c (captured_main_1): Update.
15931         * linux-thread-db.c (try_thread_db_load_from_pdir)
15932         (has_libpthread): Update.
15933         * linespec.c (iterate_over_all_matching_symtabs)
15934         (search_minsyms_for_name): Update.
15935         * jit.c (jit_find_objf_with_entry_addr): Update.
15936         * hppa-tdep.c (find_unwind_entry)
15937         (hppa_lookup_stub_minimal_symbol): Update.
15938         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15939         Update.
15940         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15941         (elf_gnu_ifunc_resolve_by_got): Update.
15942         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15943         * dwarf-index-write.c (save_gdb_index_command): Update.
15944         * cp-support.c (add_symbol_overload_list_qualified): Update.
15945         * breakpoint.c (create_overlay_event_breakpoint)
15946         (create_longjmp_master_breakpoint)
15947         (create_std_terminate_master_breakpoint)
15948         (create_exception_master_breakpoint): Update.
15949         * blockframe.c (find_pc_partial_function): Update.
15950         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15951         (ada_collect_symbol_completion_matches)
15952         (ada_add_global_exceptions): Update.
15953
15954 2019-01-17  Tom Tromey  <tom@tromey.com>
15955
15956         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15957         declare VEC.
15958         (solib_target_parse_libraries): Change return type.
15959         (library_list_start_segment, library_list_start_section)
15960         (library_list_end_library, library_list_start_library); Update.
15961         (solib_target_free_library_list): Remove.
15962         (solib_target_parse_libraries): Remove cleanup.  Change return
15963         type.
15964         (solib_target_current_sos): Update.
15965
15966 2019-01-17  Tom Tromey  <tromey@bapiya>
15967
15968         * valprint.c: Replace "the the" with "the".
15969         * symtab.c: Replace "the the" with "the".
15970         * solib.c: Replace "the the" with "the".
15971         * solib-dsbt.c: Replace "the the" with "the".
15972         * linespec.c: Replace "the the" with "the".
15973         * dwarf2loc.h: Replace "the the" with "the".
15974         * amd64-windows-tdep.c: Replace "the the" with "the".
15975         * aarch64-tdep.c: Replace "the the" with "the".
15976
15977 2019-01-16  Keith Seitz  <keiths@redhat.com>
15978
15979         PR gdb/23773
15980         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15981         <builder>: Rename to ..
15982         <m_builder>: ... this and make private.
15983         (dwarf2_cu::get_builder): New method.  Change all users of
15984         `builder' to use this method.
15985         (dwarf2_start_symtab): Move to ...
15986         (dwarf2_cu::start_symtab): ... here.  Update all callers
15987         (setup_type_unit_groups): Move to ...
15988         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15989         callers.
15990         (dwarf2_cu::reset_builder): New method.
15991         (process_full_compunit, process_full_type_unit): Use
15992         dwarf2_cu::reset_builder.
15993         (follow_die_offset): Record the ancestor CU if it is different
15994         from the followed DIE's CU.
15995         (follow_die_sig_1): Likewise.
15996
15997 2019-01-15  Tom Tromey  <tom@tromey.com>
15998
15999         * remote.c (class remote_state) <buf>: Now a char_vector.
16000         <buf_size>: Remove.
16001         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16002         parameter.
16003         (remote_target::getpkt_or_notif_sane_1)
16004         (remote_target::getpkt_sane)
16005         (remote_target::getpkt_or_notif_sane): Likewise.
16006         (class remote_target) <putpkt>: New overload.
16007         (remote_target::read_frame): Change type of "buf_p".  Remove
16008         sizeof_p parameter.
16009         (packet_ok): New overload.
16010         (packet_check_result): New overload.
16011         Update all uses.
16012
16013 2019-01-14  Tom Tromey  <tom@tromey.com>
16014
16015         * remote-notif.c (handle_notification, remote_notif_ack)
16016         (remote_notif_parse): Make "buf" const.
16017         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16018         const.
16019         (remote_notif_parse, remote_notif_ack, handle_notification):
16020         Likewise.
16021         * remote.c (remote_notif_stop_parse): Make "buf" const.
16022         (remote_target::remote_parse_stop_reply): Make "buf" const.
16023         (remote_notif_stop_ack): Make "buf" const.
16024
16025 2019-01-14  Tom Tromey  <tom@tromey.com>
16026
16027         * remote.c (remote_console_output): Make parameter const.
16028
16029 2019-01-14  Tom Tromey  <tom@tromey.com>
16030
16031         * target-debug.h (target_debug_print_signals): Constify.
16032         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16033         * procfs.c (procfs_target::pass_signals): Update.
16034         * linux-nat.c (linux_nat_target::pass_signals): Update.
16035         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16036         * target-delegates.c: Rebuild.
16037         * remote.c (remote_target::program_signals): Update.
16038         (remote_target::pass_signals): Update.
16039         * target.c (target_pass_signals): Constify argument.
16040         (target_program_signals): Likewise.
16041         * target.h (struct target_ops) <pass_signals, program_signals>:
16042         Constify argument.
16043         (target_pass_signals, target_program_signals): Constify argument.
16044
16045 2019-01-14  Tom Tromey  <tom@tromey.com>
16046
16047         PR tui/28819:
16048         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16049
16050 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16051
16052         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16053         field.
16054         * rs6000-tdep.c: Include reggroups.h.
16055         (IS_V_ALIAS_PSEUDOREG): Define.
16056         (rs6000_register_name): Return names for the "vX" aliases.
16057         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16058         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16059         aliases.  Call default_register_reggroup_p for all other
16060         pseudo-registers.
16061         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16062         New functions.
16063         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16064         Handle "vX" aliases.
16065         (v_alias_pseudo_register_collect): New function.
16066         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16067         (rs6000_gdbarch_init): Initialize "vX" aliases as
16068         pseudo-registers.  Restore registration of
16069         rs6000_pseudo_register_reggroup_p with
16070         set_tdesc_pseudo_register_reggroup_p.
16071
16072 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16073
16074         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16075         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16076         set_gdbarch_num_pseudo_regs.
16077
16078 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16079
16080         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16081         Remove arg prefixname, add do_set and do_show.
16082         Add member functions set_list and show_list.
16083         * cli/cli-style.c (class cli_style_option): Update accordingly.
16084         (style_set_list): Move to file scope.
16085         (style_show_list): Likewise.
16086         (set_style): Call help_list.
16087         (show_style): Call cmd_show_list.
16088         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16089         Update to use the new macro.
16090
16091 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16092
16093         * ada-lang.c (_initialize_ada_language): Expand the help text
16094         for the "catch exception" command.
16095
16096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16097
16098         * symtab.c (matching_obj_sections): Initialize obj,
16099         declare it closer to its usage.
16100
16101 2019-01-10  Tom Tromey  <tom@tromey.com>
16102
16103         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16104         (basic_inf_threads_range): Remove.
16105         (inf_threads_range, inf_non_exited_threads_range)
16106         (safe_inf_threads_range): Use next_adapter.
16107
16108 2019-01-10  Keith Seitz  <keiths@redhat.com>
16109
16110         PR gdb/23712
16111         PR symtab/23010
16112         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16113         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16114
16115 2019-01-10  Keith Seitz  <keiths@redhat.com>
16116
16117         PR gdb/23712
16118         PR symtab/23010
16119         * dictionary.c (pending_to_vector): Remove.
16120         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16121         Remove _1 suffix, replacing functions of the same name.  Update
16122         all callers.
16123         (dict_create_hashed, dict_create_hashed_expandable)
16124         (dict_create_linear, dict_create_linear_expandable, dict_free)
16125         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16126         Make functions static.
16127
16128 2019-01-10  Keith Seitz  <keiths@redhat.com>
16129
16130         PR gdb/23712
16131         PR symtab/23010
16132         * dictionary.h (struct dictionary): Replace declaration with
16133         multidictionary.
16134         (dict_create_hashed, dict_create_hashed_expandable)
16135         (dict_create_linear, dict_create_linear_expandable)
16136         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16137         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16138         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16139         taking multidictionary argument.
16140         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16141         * block.h (struct block) <dict>: Change to multidictionary
16142         and rename `multidict'.
16143         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16144         symmisc.c: Update all dictionary references to multidictionary.
16145
16146 2019-01-10  Keith Seitz  <keiths@redhat.com>
16147
16148         PR gdb/23712
16149         PR symtab/23010
16150         * dictionary.c: Include unordered_map.
16151         (pending_to_vector): New function.
16152         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16153         Rewrite the non-"_1" functions to take vector instead
16154         of linked list.
16155         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16156         "new" _1 versions of the same name.
16157         (multidictionary): Define.
16158         (std::hash<enum language): New definition.
16159         (collate_pending_symbols_by_language, mdict_create_hashed)
16160         (mdict_create_hashed_expandable, mdict_create_linear)
16161         (mdict_create_linear_expandable, mdict_free)
16162         (find_language_dictionary, create_new_language_dictionary)
16163         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16164         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16165         (mdict_size, mdict_empty): New functions.
16166         * dictionary.h (mdict_iterator): Define.
16167
16168 2019-01-10  Pedro Alves  <palves@redhat.com>
16169
16170         * breakpoint.c (read_uploaded_action)
16171         (create_tracepoint_from_upload): Adjust to use
16172         gdb::unique_xmalloc_ptr.
16173         * ctf.c (ctf_write_uploaded_tp):
16174         (SET_ARRAY_FIELD): Use emplace_back.
16175         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16176         * tracefile-tfile.c (tfile_write_uploaded_tp):
16177         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16178         gdb::unique_xmalloc_ptr.
16179         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16180         at_string, cond_string, cmd_strings>: Replace char pointers
16181         with gdb::unique_xmalloc_ptr.
16182
16183 2019-01-10  Pedro Alves  <palves@redhat.com>
16184
16185         * solib-target.c (library_list_start_library): Don't xstrdup name.
16186
16187 2019-01-10  Pedro Alves  <palves@redhat.com>
16188
16189         * mdebugread.c (parse_partial_symbols): Use
16190         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16191
16192 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16193
16194         * linux-fork.c (scoped_switch_fork_info)
16195         <~scoped_switch_fork_info>: Fix incorrect variable name.
16196
16197 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16198
16199         * linux-fork.c (scoped_switch_fork_info)
16200         <scoped_switch_fork_info>: Make explicit.
16201         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16202
16203 2019-01-10  Tom Tromey  <tom@tromey.com>
16204
16205         * objfiles.h (objfile::reset_psymtabs): Update.
16206         * objfiles.c (objfile::objfile): Update.
16207         * psymtab.h (psymtab_storage::obstack): Update.
16208         (psymtab_storage::m_obstack): Use gdb::optional.
16209         (class psymtab_storage): Update comment.  Remove objfile
16210         parameter.
16211         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16212
16213 2019-01-10  Tom Tromey  <tom@tromey.com>
16214
16215         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16216         <free_psymtabs>: Now private.
16217         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16218         (allocate_psymtab): Use new method.
16219
16220 2019-01-10  Tom Tromey  <tom@tromey.com>
16221
16222         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16223         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16224         * mdebugread.c (parse_partial_symbols): Use
16225         allocate_dependencies.
16226         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16227         allocate_dependencies.
16228         (process_psymtab_comp_unit_reader)
16229         (build_type_psymtab_dependencies): Likewise.
16230         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16231
16232 2019-01-10  Tom Tromey  <tom@tromey.com>
16233
16234         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16235         PSYMBOL_SET_LANGUAGE.
16236         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16237
16238 2019-01-10  Tom Tromey  <tom@tromey.com>
16239
16240         * psymtab.h (psymtab_storage::obstack): New method.
16241         <m_obstack>: Rename from obstack; now private.
16242         * psymtab.c (psymtab_storage): Update.
16243         * dwarf2read.c (create_addrmap_from_index)
16244         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16245         Update.
16246
16247 2019-01-10  Tom Tromey  <tom@tromey.com>
16248
16249         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16250         * objfiles.h (objfile::reset_psymtabs): New method.
16251
16252 2019-01-10  Tom Tromey  <tom@tromey.com>
16253
16254         * symmisc.c (print_symbol_bcache_statistics): Update.
16255         (print_objfile_statistics): Update.
16256         * symfile.c (reread_symbols): Update.
16257         * psymtab.h (class psymtab_storage): New.
16258         * psymtab.c (psymtab_storage): New constructor.
16259         (~psymtab_storage): New destructor.
16260         (require_partial_symbols): Update.
16261         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16262         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16263         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16264         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16265         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16266         (start_psymtab_common, end_psymtab_common)
16267         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16268         (allocate_psymtab): Update.
16269         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16270         Update.
16271         (dump_psymtab_addrmap, maintenance_print_psymbols)
16272         (maintenance_check_psymtabs): Update.
16273         (class objfile_psymtabs): Move to objfiles.h.
16274         * psympriv.h (discard_psymtab): Now inline.
16275         (psymtab_discarder::psymtab_discarder): Update.
16276         (psymtab_discarder::~psymtab_discarder): Update.
16277         (ALL_OBJFILE_PSYMTABS): Rewrite.
16278         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16279         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16280         Remove fields.
16281         <partial_symtabs>: New field.
16282         (class objfile_psymtabs): Move from psymtab.h.  Update.
16283         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16284         psymbol_cache.
16285         (objfile::~objfile): Don't destroy psymbol_cache.
16286         * mdebugread.c (parse_partial_symbols): Update.
16287         * dwarf2read.c (create_addrmap_from_index)
16288         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16289         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16290         (add_partial_subprogram, dwarf2_ranges_read): Update.
16291         * dwarf-index-write.c (write_address_map)
16292         (write_one_signatured_type, recursively_write_psymbols)
16293         (class debug_names, class debug_names, write_psymtabs_to_index):
16294         Update.
16295
16296 2019-01-10  Tom Tromey  <tom@tromey.com>
16297
16298         * symtab.h (SYMBOL_SET_NAMES): Update.
16299         (symbol_set_names): Update.
16300         (MSYMBOL_SET_NAMES): Update.
16301         * symtab.c (symbol_set_names): Change argument to be an
16302         objfile_per_bfd_storage.
16303         * psymtab.c (add_psymbol_to_bcache): Update.
16304         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16305
16306 2019-01-10  Tom Tromey  <tom@tromey.com>
16307
16308         * symtab.c (create_demangled_names_hash): Change argument to be an
16309         objfile_per_bfd_storage.
16310         (symbol_set_names): Update.
16311
16312 2019-01-10  Tom Tromey  <tom@tromey.com>
16313
16314         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16315         init_psymbol_list.
16316         * psymtab.c (init_psymbol_list): Do nothing if already called.
16317         * psympriv.h (init_psymbol_list): Add comment.
16318         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16319         init_psymbol_list.
16320         * dbxread.c (dbx_symfile_read): Unconditionally call
16321         init_psymbol_list.
16322
16323 2019-01-10  Tom Tromey  <tom@tromey.com>
16324
16325         * xcoffread.c (scan_xcoff_symtab): Update.
16326         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16327         "where".
16328         * mdebugread.c (parse_partial_symbols)
16329         (handle_psymbol_enumerators): Update.
16330         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16331         * dbxread.c (read_dbx_symtab): Update.
16332         * psympriv.h (psymbol_placement): New enum.
16333         (add_psymbol_to_list): Update.
16334
16335 2019-01-10  Tom Tromey  <tom@tromey.com>
16336
16337         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16338         static_psymbols parameters.
16339         (scan_xcoff_symtab): Update.
16340         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16341         static_psymbols parameters.
16342         * psympriv.h (start_psymtab_common): Update.
16343         * mdebugread.c (parse_partial_symbols): Update.
16344         * dwarf2read.c (create_partial_symtab): Update.
16345         * dbxread.c (read_dbx_symtab): Update.
16346         (start_psymtab): Remove global_psymbols and static_psymbols
16347         parameters.
16348
16349 2019-01-10  Tom Tromey  <tom@tromey.com>
16350
16351         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16352         * psymtab.c (allocate_psymtab): Add comment.
16353         * psympriv.h (allocate_psymtab): Add comment.
16354         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16355         initializations.
16356         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16357
16358 2019-01-10  Tom Tromey  <tom@tromey.com>
16359
16360         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16361         Don't declare.
16362         * mipsread.c: Include mdebugread.h.
16363         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16364         Declare.
16365         * elfread.c: Include mdebugread.h.
16366
16367 2019-01-09  Tom Tromey  <tom@tromey.com>
16368
16369         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16370         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16371         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16372         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16373         (psym_lookup_symbol, psym_find_last_source_symtab)
16374         (psym_forget_cached_source_info, psym_print_stats)
16375         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16376         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16377         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16378         (psym_find_compunit_symtab_by_address)
16379         (maintenance_print_psymbols, maintenance_info_psymtabs)
16380         (maintenance_check_psymtabs): Use ranged for.
16381         * psymtab.h (class objfile_psymtabs): New.
16382         (require_partial_symbols): Return objfile_psymtabs.
16383         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16384
16385 2019-01-09  Tom Tromey  <tom@tromey.com>
16386
16387         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16388         (find_pc_mapped_section, list_overlays_command)
16389         (map_overlay_command, unmap_overlay_command)
16390         (simple_overlay_update): Use all_objfiles.
16391         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16392         * printcmd.c (info_symbol_command): Use all_objfiles.
16393         * objfiles.h (ALL_OBJSECTIONS): Remove.
16394         * maint.c (maintenance_translate_address): Use all_objfiles.
16395         * gcore.c (gcore_create_callback): Use all_objfiles.
16396         (objfile_find_memory_regions): Likewise.
16397
16398 2019-01-09  Tom Tromey  <tom@tromey.com>
16399
16400         * symtab.c (find_line_symtab, info_sources_command)
16401         (make_source_files_completion_list): Use objfile_compunits.
16402         * source.c (select_source_symtab): Use objfile_compunits.
16403         * objfiles.h (struct objfile): Update comment.
16404         (ALL_OBJFILES): Remove.
16405         (ALL_FILETABS): Remove.
16406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16407         objfile_compunits.
16408
16409 2019-01-09  Tom Tromey  <tom@tromey.com>
16410
16411         * symmisc.c (print_objfile_statistics, dump_objfile)
16412         (maintenance_print_symbols): Use compunit_filetabs.
16413         * source.c (forget_cached_source_info_for_objfile): Use
16414         compunit_filetabs.
16415         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16416         (ALL_FILETABS): Use compunit_filetabs.
16417         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16418         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16419
16420 2019-01-09  Tom Tromey  <tom@tromey.com>
16421
16422         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16423         (compunit_filetabs): New.
16424         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16425         compunit_filetabs.
16426         (info_sources_command, make_source_files_completion_list): Remove
16427         declaration.
16428         * symmisc.c (print_objfile_statistics, dump_objfile)
16429         (maintenance_print_symbols): Remove declaration.
16430         (maintenance_info_symtabs): Use compunit_filetabs.
16431         (maintenance_info_line_tables): Likewise.
16432         * source.c (select_source_symtab): Change local variable name.
16433         (forget_cached_source_info_for_objfile): Remove declaration.
16434         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16435         * objfiles.c (objfile_relocate1): Remove declaration.
16436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16437         declaration.
16438         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16439         * coffread.c (coff_symtab_read): Remove declaration.
16440         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16441         compunit_filetabs.
16442
16443 2019-01-09  Tom Tromey  <tom@tromey.com>
16444
16445         * symtab.c (lookup_objfile_from_block)
16446         (find_pc_sect_compunit_symtab, search_symbols)
16447         (default_collect_symbol_completion_matches_break_on): Use
16448         objfile_compunits.
16449         * objfiles.h (ALL_COMPUNITS): Remove.
16450         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16451         * cp-support.c (add_symbol_overload_list_qualified): Use
16452         objfile_compunits.
16453         * ada-lang.c (ada_collect_symbol_completion_matches)
16454         (ada_add_global_exceptions): Use objfile_compunits.
16455
16456 2019-01-09  Tom Tromey  <tom@tromey.com>
16457
16458         * source.c (select_source_symtab)
16459         (forget_cached_source_info_for_objfile): Remove declaration.
16460         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16461         declaration.
16462         * maint.c (count_symtabs_and_blocks): Remove declaration.
16463         * cp-support.c (add_symbol_overload_list_qualified): Remove
16464         declaration.
16465         * coffread.c (coff_symtab_read): Remove declaration.
16466         * symtab.c (lookup_symbol_in_objfile_symtabs)
16467         (basic_lookup_transparent_type_1): Use objfile_compunits.
16468         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16469         (info_sources_command, search_symbols)
16470         (default_collect_symbol_completion_matches_break_on)
16471         (make_source_files_completion_list): Remove declaration.
16472         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16473         (ada_collect_symbol_completion_matches)
16474         (ada_add_global_exceptions): Remove declaration.
16475         * linespec.c (iterate_over_all_matching_symtabs): Use
16476         objfile_compunits.
16477         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16478         (class objfile_compunits): New.
16479         (ALL_COMPUNITS): Use objfile_compunits.
16480         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16481         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16482         objfile_compunits.
16483         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16484
16485 2019-01-09  Tom Tromey  <tom@tromey.com>
16486
16487         * symtab.c (search_symbols)
16488         (default_collect_symbol_completion_matches_break_on): Use
16489         objfile_msymbols.
16490         * ada-lang.c (ada_lookup_simple_minsym)
16491         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16492         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16493         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16494         objfile_msymbols.
16495         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16496         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16497         * objc-lang.c (find_methods): Use objfile_msymbols.
16498         (info_selectors_command, info_classes_command): Likewise.
16499         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16500         * objfiles.h (class objfile_msymbols): New.
16501         (ALL_OBJFILE_MSYMBOLS): Remove.
16502         (ALL_MSYMBOLS): Remove.
16503
16504 2019-01-09  Tom Tromey  <tom@tromey.com>
16505
16506         * common/next-iterator.h (next_adapter): Add Iterator template
16507         parameter.
16508         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16509         (class all_objfiles_safe): New.
16510         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16511         * objfiles.c (put_objfile_before): Update comment.
16512         (add_separate_debug_objfile): Likewise.
16513         (free_all_objfiles): Use all_objfiles_safe.
16514         (objfile_purge_solibs): Likewise.
16515
16516 2019-01-09  Tom Tromey  <tom@tromey.com>
16517
16518         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16519         (expand_symtab_containing_pc, lookup_static_symbol)
16520         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16521         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16522         all_objfiles.
16523         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16524         * breakpoint.c (create_overlay_event_breakpoint)
16525         (create_longjmp_master_breakpoint)
16526         (create_std_terminate_master_breakpoint)
16527         (create_exception_master_breakpoint): Use all_objfiles.
16528         * linux-thread-db.c (try_thread_db_load_from_pdir)
16529         (has_libpthread): Use all_objfiles.
16530         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16531         * linespec.c (iterate_over_all_matching_symtabs)
16532         (search_minsyms_for_name): Use all_objfiles.
16533         * maint.c (maintenance_info_sections): Use all_objfiles.
16534         * main.c (captured_main_1): Use all_objfiles.
16535         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16536         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16537         * guile/scm-pretty-print.c
16538         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16539         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16540         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16541         (maintenance_print_msymbols): Use all_objfiles.
16542         * source.c (select_source_symtab): Use all_objfiles.
16543         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16544         * symfile.c (remove_symbol_file_command)
16545         (expand_symtabs_matching, map_symbol_filenames): Use
16546         all_objfiles.
16547         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16548         all_objfiles.
16549         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16550         * objc-lang.c (find_methods): Use all_objfiles.
16551         * objfiles.c (have_partial_symbols, have_full_symbols)
16552         (have_minimal_symbols, qsort_cmp)
16553         (default_iterate_over_objfiles_in_search_order): Use
16554         all_objfiles.
16555         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16556         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16557         (maintenance_check_psymtabs): Use all_objfiles.
16558         (ALL_PSYMTABS): Remove.
16559         * compile/compile-object-run.c (do_module_cleanup): Use
16560         all_objfiles.
16561         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16562         * cp-support.c (add_symbol_overload_list_qualified): Use
16563         all_objfiles.
16564         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16565         Use all_objfiles.
16566         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16567         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16568         all_objfiles.
16569         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16570         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16571         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16572         Uses all_objfiles.
16573         * solib.c (solib_read_symbols): Use all_objfiles
16574
16575 2019-01-09  Tom Tromey  <tom@tromey.com>
16576
16577         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16578         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16579         all_objfiles.
16580         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16581         * symmisc.c (print_symbol_bcache_statistics)
16582         (print_objfile_statistics, maintenance_print_objfiles)
16583         (maintenance_info_symtabs, maintenance_check_symtabs)
16584         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16585         all_objfiles.
16586         * source.c (forget_cached_source_info): Use all_objfiles.
16587         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16588         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16589         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16590         * objfiles.c (update_section_map): Use all_objfiles.
16591         (shared_objfile_contains_address_p): Likewise.
16592         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16593         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16594
16595 2019-01-09  Tom Tromey  <tom@tromey.com>
16596
16597         * common/next-iterator.h: New file.
16598         * objfiles.h (class all_objfiles): New.
16599         (struct objfile_iterator): New.
16600
16601 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16602
16603         * NEWS: Move the description of the changed "frame", "select-frame",
16604          and "info frame" commands to the Changed commands section.
16605
16606 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16607
16608         * gdbtypes.c (check_stub_method_group): Remove handling of old
16609         mangling schemes.
16610         * linespec.c (find_methods): Likewise.
16611         * stabsread.c (read_member_functions): Likewise.
16612         * valops.c (search_struct_method): Likewise.
16613         (value_struct_elt_for_reference): Likewise.
16614         * NEWS: Mention this change.
16615
16616 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16617
16618         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16619         print_source_lines.
16620         * source.c (print_source_lines_base): Update line number check.
16621         (print_source_lines): New function.
16622         (source_lines_range::source_lines_range): New function.
16623         * source.h (class source_lines_range): New class.
16624         (print_source_lines): New declaration.
16625
16626 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16627
16628         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16629
16630 2019-01-08  Tom Tromey  <tom@tromey.com>
16631             Simon Marchi  <simon.marchi@ericsson.com>
16632
16633         PR gdb/24060
16634         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16635         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16636         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16637         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16638         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16639         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16640
16641 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16642
16643         * source.c (select_source_symtab): Move header comment to
16644         declaration in source.h.
16645         (forget_cached_source_info_for_objfile): Likewise.
16646         (forget_cached_source_info): Likewise.
16647         (identify_source_line): Likewise.
16648         * source.h (identify_source_line): Move declaration from symtab.h
16649         and add comment from source.c
16650         (print_source_lines): Likewise.
16651         (forget_cached_source_info_for_objfile): Likewise.
16652         (forget_cached_source_info): Likewise.
16653         (select_source_symtab): Likewise.
16654         (enum print_source_lines_flag): Move definition from symtab.h.
16655         * symtab.h (identify_source_line): Move declaration to source.h.
16656         (print_source_lines): Likewise.
16657         (forget_cached_source_info_for_objfile): Likewise.
16658         (forget_cached_source_info): Likewise.
16659         (select_source_symtab): Likewise.
16660         (enum print_source_lines_flag): Move definition to source.h.
16661         * tui/tui-hooks.c: Add 'source.h' include.
16662
16663 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16664
16665         * source.c (print_source_lines_base): Handle requests to print
16666         reverse line number sequences, and guard against empty lines
16667         string.
16668
16669 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16670
16671         * source.c (print_source_lines_base): Fix skip of '\r' if next
16672         character is '\n'.
16673
16674 2019-01-06  Tom Tromey  <tom@tromey.com>
16675
16676         * c-exp.y (struct c_parse_state) <macro_original_text,
16677         expansion_obstack>: New member.
16678         (macro_original_text, expansion_obstack): Remove globals.
16679         (scan_macro_expansion, scanning_macro_expansion)
16680         (finished_macro_expansion): Update.
16681         (scan_macro_cleanup): Remove.
16682         (yylex, c_parse): Update.
16683
16684 2019-01-06  Tom Tromey  <tom@tromey.com>
16685
16686         * c-exp.y (struct c_parse_state) <strings>: New member.
16687         (operator_stoken): Update.
16688
16689 2019-01-06  Tom Tromey  <tom@tromey.com>
16690
16691         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16692         (union type_stack_elt) <typelist_val>: Now a pointer to
16693         std::vector.
16694         (type_stack_cleanup): Don't declare.
16695         (push_typelist): Update.
16696         * parse.c (pop_typelist): Return a std::vector.
16697         (push_typelist): Take a std::vector.
16698         (follow_types): Update.  Do not free args.
16699         (type_stack_cleanup): Remove.
16700         * c-exp.y (struct c_parse_state): New.
16701         (cpstate): New global.
16702         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16703         (nonempty_typelist): Update.
16704         (func_mod): Create a new vector.
16705         (c_parse): Create a c_parse_state.
16706         (check_parameter_typelist): Do not delete params.
16707         (function_method): Update.  Do not delete type_list.
16708
16709 2019-01-06  Tom Tromey  <tom@tromey.com>
16710
16711         PR gdb/28155:
16712         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16713         check_typedef.
16714         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16715         (print_return_value): Likewise.
16716
16717 2019-01-05  Tom Tromey  <tom@tromey.com>
16718
16719         * contrib/cleanup_check.py: Remove.
16720         * contrib/gcc-with-excheck: Remove.
16721         * contrib/exsummary.py: Remove.
16722         * contrib/excheck.py: Remove.
16723
16724 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16725
16726         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16727         NULL. Initialize tpprev to NULL instead of assigning it
16728         to NULL on the next statement.
16729         * windows-nat.c (windows_delete_thread): Remove check for
16730         main_thread_id before printing thread exit notifications.
16731         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16732         Remove thread ID check against main_thread_id.
16733         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16734         windows_delete_thread.
16735         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16736
16737 2019-01-04  Tom Tromey  <tom@tromey.com>
16738
16739         * compile/compile.c (_initialize_compile): Use upper case for
16740         metasyntactic variables.
16741         * symmisc.c (_initialize_symmisc): Use upper case for
16742         metasyntactic variables.
16743         * psymtab.c (_initialize_psymtab): Use upper case for
16744         metasyntactic variables.
16745         * demangle.c (demangle_command): Use upper case for metasyntactic
16746         variables.
16747         (_initialize_demangler): Likewise.
16748         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16749         variables.
16750
16751 2019-01-03  Tom Tromey  <tom@tromey.com>
16752
16753         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16754
16755 2019-01-03  Tom Tromey  <tom@tromey.com>
16756
16757         * python/py-symtab.c (salpy_str): Update.
16758         (struct salpy_sal_object) <symtab>: Now a PyObject.
16759         (salpy_dealloc): Update.
16760         (del_objfile_sal): Use gdbpy_ref.
16761
16762 2019-01-03  Tom Tromey  <tom@tromey.com>
16763
16764         * python/py-type.c (convert_field): Use new_reference.  Return
16765         gdbpy_ref.
16766         (make_fielditem): Return gdbpy_ref.
16767         (typy_fields): Update.
16768         (typy_getitem): Update.
16769         (field_name): Return gdbpy_ref.  Use new_reference.
16770         (typy_iterator_iternext): Update.
16771
16772 2019-01-03  Tom Tromey  <tom@tromey.com>
16773
16774         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16775
16776 2019-01-03  Tom Tromey  <tom@tromey.com>
16777
16778         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16779         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16780         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16781         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16782         (pspy_set_type_printers): Likewise.
16783         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16784         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16785         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16786         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16787         (objfpy_set_type_printers): Likewise.
16788
16789 2019-01-03  Tom Tromey  <tom@tromey.com>
16790
16791         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16792         (gdbpy_print_stack): Use gdbpy_err_fetch.
16793         * python/python-internal.h (class gdbpy_err_fetch): New class.
16794         (class gdbpy_enter) <m_error_type, m_error_value,
16795         m_error_traceback>: Remove.
16796         <m_error>: New member.
16797         (gdbpy_exception_to_string): Don't declare.
16798         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16799         * python/py-value.c (convert_value_from_python): Use
16800         gdbpy_err_fetch.
16801         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16802         gdbpy_exception_to_string.
16803         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16804         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16805         gdbpy_err_fetch.
16806
16807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16808
16809         * linux-nat.c (delete_lwp_cleanup): Delete.
16810         (struct lwp_deleter): New struct.
16811         (lwp_info_up): New typedef.
16812         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16813         lwp_info_up.
16814
16815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16816
16817         * linux-fork.c (class scoped_switch_fork_info): New class.
16818         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16819
16820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16821
16822         * valops.c (find_overload_match): Remove use of null_cleanup, and
16823         calls to do_cleanups.
16824
16825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16826
16827         * compile/compile-cplus-types.c
16828         (compile_cplus_instance::decl_name): Handle changes to
16829         cp_func_name.
16830         * cp-support.c (cp_func_name): Update header comment, update
16831         return type.
16832         * cp-support.h (cp_func_name): Update return type in declaration.
16833         * valops.c (find_overload_match): Move temp_func local to top
16834         level of function and change its type.  Use temp_func to hold and
16835         delete temporary string obtained from cp_func_name.
16836
16837 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16838
16839         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16840         gdb::char_vector, remove cleanup, and update uses of `msg`.
16841
16842 2019-01-03  Jim Wilson  <jimw@sifive.com>
16843
16844         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16845
16846 2019-01-02  Tom Tromey  <tom@tromey.com>
16847
16848         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16849         (tdesc_parse_xml): Remove cleanups.
16850         * target-descriptions.h (make_cleanup_free_target_description):
16851         Don't declare.
16852         (target_desc_deleter): New struct.
16853         (target_desc_up): New typedef.
16854         * target-descriptions.c (target_desc_deleter::operator()): Rename
16855         from free_target_description.
16856         (make_cleanup_free_target_description): Remove.
16857
16858 2019-01-02  Tom Tromey  <tom@tromey.com>
16859
16860         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16861         constructor, destructor.
16862         (linespec_parser): Remove typedef.
16863         (~linespec_parser): Rename from linespec_parser_delete.
16864         (linespec_lex_to_end, linespec_complete_label)
16865         (linespec_complete): Update.
16866         (decode_line_full): Remove cleanups.
16867         (decode_line_1): Update.
16868
16869 2019-01-02  Tom Tromey  <tom@tromey.com>
16870
16871         * python/python-internal.h (inferior_to_inferior_object): Change
16872         return type.
16873         * python/py-exitedevent.c (create_exited_event_object): Update.
16874         * python/py-inferior.c (inferior_to_inferior_object): Return
16875         gdbpy_ref.
16876         (python_new_inferior, python_inferior_deleted)
16877         (thread_to_thread_object, delete_thread_object)
16878         (build_inferior_list, gdbpy_selected_inferior): Update.
16879         * python/py-infthread.c (create_thread_object): Update.  Also fail
16880         if inferior_to_inferior_object fails.
16881
16882 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16883
16884         * inferior.h (class inferior) <displaced_step_state>: New field.
16885         * infrun.h (struct displaced_step_state): Move here from
16886         infrun.c.  Initialize fields, add constructor.
16887         <inf>: Remove field.
16888         <reset>: New method.
16889         * infrun.c (struct displaced_step_inferior_state): Move to
16890         infrun.h.
16891         (displaced_step_inferior_states): Remove.
16892         (get_displaced_stepping_state): Adust.
16893         (displaced_step_in_progress_any_inferior): Adjust.
16894         (displaced_step_in_progress_thread): Adjust.
16895         (displaced_step_in_progress): Adjust.
16896         (add_displaced_stepping_state): Remove.
16897         (get_displaced_step_closure_by_addr): Adjust.
16898         (remove_displaced_stepping_state): Remove.
16899         (infrun_inferior_exit): Call displaced_step_state.reset.
16900         (use_displaced_stepping): Don't check for NULL.
16901         (displaced_step_prepare_throw): Call
16902         get_displaced_stepping_state.
16903         (displaced_step_fixup): Don't check for NULL.
16904         (prepare_for_detach): Don't check for NULL.
16905
16906 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16907
16908         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16909          in case of call that did not complete.
16910
16911 2019-01-02  Andrey Utkin  <autkin@undo.io>
16912
16913         * symfile.c (find_separate_debug_file): Fix search of debug files for
16914         remote debuggee.
16915
16916 2019-01-02  Tom Tromey  <tom@tromey.com>
16917
16918         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16919         indentation.
16920         * python/py-frame.c (frapy_older): Remove cast.
16921         (frapy_newer): Likewise.
16922         * python/py-breakpoint.c (local_setattro): Remove cast.
16923         * python/py-arch.c (archpy_name): Remove local variable.
16924         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16925
16926 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16927
16928         * unittests/basic_string_view/element_access/char/empty.cc:
16929         Fix year range in copyright header.
16930
16931 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16932
16933         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16934         Delete.
16935         <operator==>: Update with for removed field.
16936         <hash>: Likewise.
16937         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16938         <isa_features>: ...this.
16939         <abi_features>: New field.
16940         (riscv_isa_flen): Update comment.
16941         (riscv_abi_xlen): New declaration.
16942         (riscv_abi_flen): New declaration.
16943         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16944         isa_features.
16945         (riscv_abi_xlen): New function.
16946         (riscv_isa_flen): Update to get answer from isa_features.
16947         (riscv_abi_flen): New function.
16948         (riscv_has_fp_abi): Update to get answer from abi_features.
16949         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16950         xlen and flen.
16951         (riscv_call_info) <xlen, flen>: Update comment.
16952         (riscv_call_arg_struct): Remove invalid assertions
16953         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16954         is removed.
16955         (riscv_gdbarch_init): Gather isa features and abi features
16956         separately, ensure both match on the gdbarch when reusing an old
16957         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16958         a target with 64-bit float hardware.
16959
16960 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16961
16962         * source.c (search_command_helper): Stop reverse search
16963         when line 1 has been searched.
16964
16965 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16966
16967         * record-full.c (record_full_base_target::close): Rewrite
16968         record_full_core_buf_list free logic.
16969
16970 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16971
16972         * break-catch-syscall.c (print_one_catch_syscall): xfree
16973         the last text.
16974
16975 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16976
16977         * top.c (print_gdb_version): Update Copyright year in version
16978         message.
16979
16980 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16981
16982         Update copyright year range in all GDB files.
16983
16984 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16985
16986         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16987
16988 For older changes see ChangeLog-2018.
16989 \f
16990 Local Variables:
16991 mode: change-log
16992 left-margin: 8
16993 fill-column: 74
16994 version-control: never
16995 coding: utf-8
16996 End:
16997