gdb/ChangeLog

   1 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * s390-linux-nat.c: Add include.
   4
   5 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
   8         Call linux_get_hwcap.
   9         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  10         Likewise.
  11         (aarch64_linux_get_hwcap): Remove function.
  12         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  13         declaration.
  14         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  15         linux_get_hwcap.
  16         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  17         * linux-tdep.c (linux_get_hwcap): Add function.
  18         (linux_get_hwcap2): Likewise.
  19         * linux-tdep.h (linux_get_hwcap): Add declaration.
  20         (linux_get_hwcap2): Likewise.
  21         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  22         (ppc_linux_get_hwcap2): Likewise.
  23         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  24         linux_get_hwcap.
  25         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  26         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  27         (ppc_linux_nat_target::read_description): Likewise.
  28         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  29         * s390-linux-nat.c: Likewise.
  30         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  31
  32 2019-03-24  Tom Tromey  <tom@tromey.com>
  33
  34         * ada-lang.c (standard_lookup): Simplify initialization.
  35         (ada_lookup_symbol_nonlocal): Simplify return.
  36         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  37         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  38         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  39         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  40         initialization.
  41         * solib.c (solib_global_lookup): Simplify.
  42         * symtab.c (null_block_symbol): Remove.
  43         (symbol_cache_lookup): Simplify returns.
  44         (lookup_language_this): Simplify returns.
  45         (lookup_symbol_aux): Simplify return.
  46         (lookup_local_symbol): Simplify returns.
  47         (lookup_global_symbol_from_objfile): Simplify return.
  48         (lookup_symbol_in_objfile_symtabs)
  49         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  50         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  51         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  52         * cp-namespace.c (cp_lookup_bare_symbol)
  53         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  54         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  55         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  56         (cp_lookup_symbol_via_imports): Simplify initialization.
  57         (find_symbol_in_baseclass): Likewise.
  58         * symtab.h (null_block_symbol): Remove.
  59         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  60         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  61         (d_lookup_symbol_module): Likewise.
  62         (find_symbol_in_baseclass): Simplify initialization.
  63
  64 2019-03-24  Tom Tromey  <tom@tromey.com>
  65
  66         * expression.h: Don't include symtab.h.
  67         (struct block): Forward declare.
  68
  69 2019-03-24  Tom Tromey  <tom@tromey.com>
  70
  71         * c-exp.y (typebase): Remove casts.
  72         * gdbtypes.c (lookup_unsigned_typename, )
  73         (lookup_signed_typename): Remove cast.
  74         * eval.c (parse_to_comma_and_eval): Remove cast.
  75         * parse.c (write_dollar_variable): Remove cast.
  76         * block.h (struct block) <superblock>: Now const.
  77         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
  78         * psymtab.c (psym_map_matching_symbols): Make "block" const.
  79         (map_block): Make "block" const.
  80         * symfile.h (struct quick_symbol_functions)
  81         <map_matching_symbols>: Constify block argument to "callback".
  82         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
  83         const.
  84         (find_pc_sect_compunit_symtab): Make "b" const.
  85         (find_symbol_at_address): Likewise.
  86         (search_symbols): Likewise.
  87         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
  88         (dw2_debug_names_lookup_symbol): Likewise.
  89         (dw2_map_matching_symbols): Update.
  90         * p-valprint.c (pascal_val_print): Remove "block".
  91         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
  92         (aux_add_nonlocal_symbols): Make "block" const.
  93         (resolve_subexp): Remove cast.
  94         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
  95         const.
  96         (iterate_over_file_blocks): Likewise.
  97         * f-exp.y (%union) <bval>: Remove.
  98         * coffread.c (patch_opaque_types): Make "b" const.
  99         * spu-tdep.c (spu_catch_start): Make "block" const.
 100         * c-valprint.c (print_unpacked_pointer): Remove "block".
 101         * symmisc.c (dump_symtab_1): Make "b" const.
 102         (block_depth): Make "block" const.
 103         * d-exp.y (%union) <bval>: Remove.
 104         * cp-support.h (cp_lookup_rtti_type): Update.
 105         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 106         * psymtab.c (psym_lookup_symbol): Make "block" const.
 107         (maintenance_check_psymtabs): Make "b" const.
 108         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 109         (enumerate_locals, enumerate_args): Update.
 110         * python/py-symtab.c (stpy_global_block): Make "block" const.
 111         (stpy_static_block): Likewise.
 112         * inline-frame.c (block_starting_point_at): Make "new_block"
 113         const.
 114         * block.c (find_block_in_blockvector): Make return type const.
 115         (blockvector_for_pc_sect): Make "b" const.
 116         (find_block_in_blockvector): Make "b" const.
 117
 118 2019-03-23  Tom Tromey  <tom@tromey.com>
 119
 120         * varobj.c (varobj_create): Update.
 121         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 122         * printcmd.c (display_command, do_one_display): Don't reset
 123         innermost_block.
 124         * parser-defs.h (enum innermost_block_tracker_type): Move to
 125         expression.h.
 126         (innermost_block): Update comment.
 127         * parse.c (parse_exp_1): Add tracker_types parameter.
 128         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 129         tracker_types parameter.  Reset innermost_block.
 130         (parse_exp_in_context): Remove.
 131         (parse_expression_for_completion): Update.
 132         * objfiles.c (~objfile): Don't reset expression_context_block or
 133         innermost_block.
 134         * expression.h (enum innermost_block_tracker_type): Move from
 135         parser-defs.h.
 136         (parse_exp_1): Add tracker_types parameter.
 137         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 138         reset innermost_block.
 139
 140 2019-03-23  Tom Tromey  <tom@tromey.com>
 141
 142         * objfiles.h: Include bcache.h.
 143
 144 2019-03-23  Tom Tromey  <tom@tromey.com>
 145
 146         * linespec.c (get_current_search_block): Use
 147         scoped_restore_current_language.
 148         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 149
 150 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 151             Jiong Wang  <jiong.wang@arm.com>
 152
 153         * aarch64-linux-tdep.c
 154         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 155         section.
 156         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 157
 158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 159             Jiong Wang  <jiong.wang@arm.com>
 160
 161         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 162         instructions.
 163         (aarch64_analyze_prologue_test): Add PACIASP test.
 164         (aarch64_prologue_prev_register): Unmask PC value.
 165
 166 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 167             Jiong Wang  <jiong.wang@arm.com>
 168
 169         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 170         (aarch64_dwarf2_prev_register): Unmask PC value.
 171         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 172         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 173         DW_CFA_AARCH64_negate_ra_state.
 174         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 175
 176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 177             Jiong Wang  <jiong.wang@arm.com>
 178
 179         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 180         registers.
 181         (aarch64_pseudo_register_name): Likewise.
 182         (aarch64_pseudo_register_type): Likewise.
 183         (aarch64_pseudo_register_reggroup_p): Likewise.
 184         (aarch64_gdbarch_init): Add pauth registers.
 185         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 186         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 187         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 188         (struct gdbarch_tdep): Add regnum for ra_state.
 189
 190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 191             Jiong Wang  <jiong.wang@arm.com>
 192
 193         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 194
 195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 196             Jiong Wang  <jiong.wang@arm.com>
 197
 198         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 199         function.
 200         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 201         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 202         (aarch64_gdbarch_init): Add puth registers.
 203         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 204         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 205         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 206
 207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 208             Jiong Wang  <jiong.wang@arm.com>
 209
 210         * aarch64-linux-nat.c
 211         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 212         * aarch64-linux-tdep.c
 213         (aarch64_linux_core_read_description): Likewise.
 214         (aarch64_linux_get_hwcap): New function.
 215         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 216         (aarch64_linux_get_hwcap): New declaration.
 217
 218 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 219             Jiong Wang  <jiong.wang@arm.com>
 220
 221         * aarch64-linux-nat.c
 222         (aarch64_linux_nat_target::read_description): Add pauth param.
 223         * aarch64-linux-tdep.c
 224         (aarch64_linux_core_read_description): Likewise.
 225         * aarch64-tdep.c (struct target_desc): Add in pauth.
 226         (aarch64_read_description): Add pauth param.
 227         (aarch64_gdbarch_init): Likewise.
 228         * aarch64-tdep.h (aarch64_read_description): Likewise.
 229         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 230         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 231         * features/Makefile: Add new files.
 232         * features/aarch64-pauth.c: New file.
 233         * features/aarch64-pauth.xml: New file.
 234
 235 2019-03-20  Tom Tromey  <tromey@adacore.com>
 236
 237         * infrun.c (handle_inferior_event): Rename from
 238         handle_inferior_event_1.  Create a scoped_value_mark.
 239         (handle_inferior_event): Remove.
 240
 241 2019-03-19  Tom Tromey  <tromey@adacore.com>
 242
 243         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 244         * infrun.h (print_stop_event): Add "displays" parameter.
 245         * infrun.c (print_stop_event): Add "displays" parameter.
 246
 247 2019-03-19  Pedro Alves  <palves@redhat.com>
 248
 249         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 250         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 251         to -1.  Fix TABs vs spaces.
 252         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 253         * tui/tui-out.h (tui_ui_out) Add intro comments.
 254         <m_line, m_start_of_line>: In-class initialize, and add describing
 255         comment.
 256
 257 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 258
 259         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 260         variable names.
 261         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 262
 263 2019-03-18  Pedro Alves  <palves@redhat.com>
 264             Eli Zaretskii <eliz@gnu.org>
 265
 266         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 267         m_line and m_start_of_line.
 268
 269 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 270
 271         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 272         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 273         it returns a newline.  This fixes a regression in TU mode, whereby
 274         the next line is output on the same screen line as the user input.
 275
 276 2019-03-18  Tom Tromey  <tromey@adacore.com>
 277
 278         * minsyms.c (minimal_symbol_reader::install): Remove call to
 279         obstack_blank.
 280
 281 2019-03-18  Pedro Alves  <palves@redhat.com>
 282
 283         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 284         New globals.
 285         (apply_style): New, factored out from ...
 286         (apply_ansi_escape): ... this.  Handle reverse video mode.
 287         (tui_set_reverse_mode): New function.
 288         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 289         * tui/tui-winsource.c (tui_show_source_line): Use
 290         tui_set_reverse_mode instead of setting A_STANDOUT.
 291         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 292         New setter methods.
 293
 294 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 295
 296         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 297         Handle tabs.
 298
 299 2019-03-18  Tom Tromey  <tromey@adacore.com>
 300
 301         * ada-lang.c (empty_array): Add "high" parameter.
 302         (ada_evaluate_subexp): Update.
 303
 304 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 305
 306         * unittests/string_view-selftests.c: Define
 307         _initialize_string_view_selftests unconditionally.
 308
 309 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 310
 311         PR gdb/24350
 312         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 313
 314 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 315
 316         PR gdb/24351
 317         * windows-nat.c (display_selector): Fix format specifiers.
 318
 319 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 320
 321         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 322         tui_refill_source_window instead of tui_refresh_win, to update the
 323         current execution line.  This fixes redisplay of the current line
 324         when stepping through the code with "next" or "step".
 325
 326 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 327
 328         * source-cache.c (source_cache::get_source_lines): Call
 329         find_source_lines to initialize s->nlines.  This fixes vertical
 330         scrolling of TUI source window when the DOWN arrow is pressed.
 331
 332 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 333
 334         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 335         linux-thread-db.c (_initialize_thread_db): Likewise.
 336
 337 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 338
 339         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 340         wclrtoeol in tui_show_source_line".  This reverts changes made in
 341         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 342
 343 2019-03-15  Tom Tromey  <tom@tromey.com>
 344
 345         * symtab.h (struct minimal_symbol): Derive from
 346         general_symbol_info.
 347         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 348         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 349         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 350         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 351         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 352         (MSYMBOL_SEARCH_NAME): Update.
 353         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 354         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 355         * minsyms.c (minimal_symbol_reader::record_full): Update.
 356
 357 2019-03-15  Tom Tromey  <tom@tromey.com>
 358
 359         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 360
 361 2019-03-15  Tom Tromey  <tom@tromey.com>
 362
 363         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 364         unique_xmalloc_ptr.
 365         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 366         Update.
 367         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 368         (build_minimal_symbol_hash_tables)
 369         (minimal_symbol_reader::install): Update.
 370
 371 2019-03-15  Tom Tromey  <tom@tromey.com>
 372
 373         * symtab.c (create_demangled_names_hash): Update.
 374         (symbol_set_names): Update.
 375         * objfiles.h (struct objfile_per_bfd_storage)
 376         <demangled_names_hash>: Now an htab_up.
 377         * objfiles.c (objfile_per_bfd_storage): Simplify.
 378
 379 2019-03-15  Tom Tromey  <tom@tromey.com>
 380
 381         * objfiles.h (struct objfile_per_bfd_storage): Declare
 382         destructor.
 383         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 384         New.
 385         (get_objfile_bfd_data): Use new.  Don't initialize
 386         language_of_main.
 387         (free_objfile_per_bfd_storage): Remove.
 388         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 389
 390 2019-03-15  Tom Tromey  <tom@tromey.com>
 391
 392         * symfile.c (reread_symbols): Update.
 393         * objfiles.c (objfile::objfile): Update.
 394         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 395         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 396         comment.
 397         (minimal_symbol_reader::install): Update.
 398         (terminate_minimal_symbol_table): Remove.
 399         * jit.c (jit_object_close_impl): Update.
 400
 401 2019-03-15  Tom Tromey  <tom@tromey.com>
 402
 403         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 404         initializations.
 405
 406 2019-03-15  Tom Tromey  <tom@tromey.com>
 407
 408         * objfiles.h (struct objfile_per_bfd_storage)
 409         <demangled_hash_languages>: Now a bitset.
 410         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 411         (lookup_minimal_symbol): Update.
 412
 413 2019-03-15  Tom Tromey  <tom@tromey.com>
 414
 415         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 416         Don't return the symbol.
 417         * coffread.c (record_minimal_symbol): Use record_full.
 418
 419 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 420
 421         The MS-Windows port of ncurses fails to switch to a color pair if
 422         one or both of the colors are the implicit default colors.  This
 423         change records the default colors when TUI is initialized, and
 424         then specifies them explicitly when a color pair uses the default
 425         colors.  This allows color styling in TUI mode on MS-Windows.
 426
 427         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 428         ncurses_norm_attr.
 429         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 430         colors in ncurses_norm_attr.
 431         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 432         "none", replace it with the default color recorded in
 433         ncurses_norm_attr.
 434
 435 2019-03-14  Tom Tromey  <tromey@adacore.com>
 436
 437         * source-cache.h (class source_cache) <get_source_lines>: Return
 438         std::string.
 439         * source-cache.c (source_cache::extract_lines): Handle case where
 440         first_pos==npos.  Return std::string.
 441         (source_cache::get_source_lines): Update.
 442
 443 2019-03-14  Tom Tromey  <tromey@adacore.com>
 444
 445         * NEWS: Add item for "style sources" commands.
 446         * source-cache.c (source_cache::get_source_lines): Check
 447         source_styling.
 448         * cli/cli-style.c (source_styling): New global.
 449         (_initialize_cli_style): Add "style sources" commands.
 450         (show_style_sources): New function.
 451         * cli/cli-style.h (source_styling): Declare.
 452
 453 2019-03-14  Pedro Alves  <palves@redhat.com>
 454             Tom Tromey  <tromey@adacore.com>
 455
 456         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 457         * tui/tui-winsource.c (tui_refill_source_window): New function,
 458         from...
 459         (tui_horizontal_source_scroll): ... here.  Move some logic.
 460         * cli/cli-style.c (set_style_enabled): Notify new observable.
 461         * tui/tui-hooks.c (tui_redisplay_source): New function.
 462         (tui_attach_detach_observers): Attach or detach
 463         tui_redisplay_source.
 464         * observable.h (source_styling_changed): New observable.
 465         * observable.c: Define source_styling_changed observable.
 466
 467 2019-03-13  Tom Tromey  <tromey@adacore.com>
 468
 469         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 470         (i386_gnu_nat_target::store_registers): Update.
 471         * target-debug.h (target_debug_print_std_string): New macro.
 472         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 473         * windows-tdep.c (display_one_tib): Update.
 474         * tui/tui-stack.c (tui_make_status_line): Update.
 475         * top.c (print_inferior_quit_action): Update.
 476         * thread.c (thr_try_catch_cmd): Update.
 477         (add_thread_with_info): Update.
 478         (thread_target_id_str): Update.
 479         (thr_try_catch_cmd): Update.
 480         (thread_command): Update.
 481         (thread_find_command): Update.
 482         * record-btrace.c (record_btrace_target::info_record)
 483         (record_btrace_resume_thread, record_btrace_target::resume)
 484         (record_btrace_cancel_resume, record_btrace_step_thread)
 485         (record_btrace_target::wait, record_btrace_target::wait)
 486         (record_btrace_target::wait, record_btrace_target::stop): Update.
 487         * progspace.c (print_program_space): Update.
 488         * process-stratum-target.c
 489         (process_stratum_target::thread_address_space): Update.
 490         * linux-fork.c (linux_fork_mourn_inferior)
 491         (detach_checkpoint_command, info_checkpoints_command)
 492         (linux_fork_context): Update.
 493         (linux_fork_detach): Update.
 494         (class scoped_switch_fork_info): Update.
 495         (delete_checkpoint_command): Update.
 496         * infrun.c (follow_fork_inferior): Update.
 497         (follow_fork_inferior): Update.
 498         (proceed_after_vfork_done): Update.
 499         (handle_vfork_child_exec_or_exit): Update.
 500         (follow_exec): Update.
 501         (displaced_step_prepare_throw): Update.
 502         (displaced_step_restore): Update.
 503         (start_step_over): Update.
 504         (resume_1): Update.
 505         (clear_proceed_status_thread): Update.
 506         (proceed): Update.
 507         (print_target_wait_results): Update.
 508         (do_target_wait): Update.
 509         (context_switch): Update.
 510         (stop_all_threads): Update.
 511         (restart_threads): Update.
 512         (finish_step_over): Update.
 513         (handle_signal_stop): Update.
 514         (switch_back_to_stepped_thread): Update.
 515         (keep_going_pass_signal): Update.
 516         (print_exited_reason): Update.
 517         (normal_stop): Update.
 518         * inferior.c (inferior_pid_to_str): Change return type.
 519         (print_selected_inferior): Update.
 520         (add_inferior): Update.
 521         (detach_inferior): Update.
 522         * dummy-frame.c (fprint_dummy_frames): Update.
 523         * dcache.c (dcache_info_1): Update.
 524         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 525         (btrace_fetch, btrace_clear): Update.
 526         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 527         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 528         type.
 529         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 530         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 531         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 532         * gdbarch.c, gdbarch.h: Rebuild.
 533         * gdbarch.sh (core_pid_to_str): Change return type.
 534         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 535         return type.
 536         (windows_nat_target::pid_to_str): Change return type.
 537         (windows_delete_thread): Update.
 538         (windows_nat_target::attach): Update.
 539         (windows_nat_target::files_info): Update.
 540         * target-delegates.c: Rebuild.
 541         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 542         return type.
 543         (sol_thread_target::pid_to_str): Change return type.
 544         * remote.c (class remote_target) <pid_to_str>: Change return
 545         type.
 546         (remote_target::pid_to_str): Change return type.
 547         (extended_remote_target::attach, remote_target::remote_stop_ns)
 548         (remote_target::remote_notif_remove_queued_reply)
 549         (remote_target::push_stop_reply, remote_target::disable_btrace):
 550         Update.
 551         (extended_remote_target::attach): Update.
 552         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 553         type.
 554         (gdbsim_target::pid_to_str): Change return type.
 555         * ravenscar-thread.c (struct ravenscar_thread_target)
 556         <pid_to_str>: Change return type.
 557         (ravenscar_thread_target::pid_to_str): Change return type.
 558         * procfs.c (class procfs_target) <pid_to_str>: Change return
 559         type.
 560         (procfs_target::pid_to_str): Change return type.
 561         (procfs_target::attach): Update.
 562         (procfs_target::detach): Update.
 563         (procfs_target::fetch_registers): Update.
 564         (procfs_target::store_registers): Update.
 565         (procfs_target::wait): Update.
 566         (procfs_target::files_info): Update.
 567         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 568         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 569         return type.
 570         (nto_procfs_target::pid_to_str): Change return type.
 571         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 572         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 573         return type.
 574         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 575         (exit_lwp): Update.
 576         (attach_proc_task_lwp_callback, get_detach_signal)
 577         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 578         (linux_nat_target::resume, wait_lwp, stop_callback)
 579         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 580         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 581         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 582         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 583         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 584         type.
 585         (inf_ptrace_target::attach): Update.
 586         (inf_ptrace_target::files_info): Update.
 587         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 588         type.
 589         (go32_nat_target::pid_to_str): Change return type.
 590         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 591         (gnu_nat_target::wait): Update.
 592         (gnu_nat_target::wait): Update.
 593         (gnu_nat_target::resume): Update.
 594         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 595         (fbsd_nat_target::wait): Update.
 596         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 597         type.
 598         (darwin_nat_target::attach): Update.
 599         * corelow.c (class core_target) <pid_to_str>: Change return type.
 600         (core_target::pid_to_str): Change return type.
 601         * target.c (normal_pid_to_str): Change return type.
 602         (default_pid_to_str): Likewise.
 603         (target_pid_to_str): Change return type.
 604         (target_translate_tls_address): Update.
 605         (target_announce_detach): Update.
 606         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 607         return type.
 608         (bsd_uthread_target::pid_to_str): Change return type.
 609         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 610         type.
 611         (bsd_kvm_target::pid_to_str): Change return type.
 612         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 613         return type.
 614         (aix_thread_target::pid_to_str): Change return type.
 615         * target.h (struct target_ops) <pid_to_str>: Change return type.
 616         (target_pid_to_str, normal_pid_to_str): Likewise.
 617         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 618         type.
 619         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 620         type.
 621         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 622         return type.
 623         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 624         type.
 625         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 626         type.
 627         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 628         return type.
 629
 630 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 631
 632         * NEWS: Mention that the new default MI version is 3.  Mention
 633         changes to the output of commands and events that deal with
 634         multi-location breakpoints.
 635         * breakpoint.c: Include "mi/mi-out.h".
 636         (print_one_breakpoint): Change output syntax if using MI version
 637         >= 3.
 638         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 639         New.
 640         (mi_multi_location_breakpoint_output_fixed): New.
 641         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 642         (mi_cmd_fix_multi_location_breakpoint_output): New.
 643         (mi_multi_location_breakpoint_output_fixed): New.
 644         * mi/mi-cmds.c (mi_cmds): Register command
 645         -fix-multi-location-breakpoint-output.
 646         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 647         interpreter "mi".
 648
 649 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 650
 651         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 652         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 653         instantiate mi_ui_out based on interpreter name.
 654         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 655         * mi/mi-main.c (mi_load_progress): Likewise.
 656
 657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 658
 659         * NEWS: Combine separate "New targets" sections for 8.3.
 660
 661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 662
 663         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 664         (ppcfbsd_init_abi): Install gdbarch
 665         "fetch_tls_load_module_address" and "get_thread_local_address"
 666         methods.
 667
 668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 669
 670         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 671         (riscv_fbsd_init_abi): Install gdbarch
 672         "fetch_tls_load_module_address" and "get_thread_local_address"
 673         methods.
 674
 675 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 676
 677         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 678         (i386fbsd_init_abi): Install gdbarch
 679         "fetch_tls_load_module_address" and "get_thread_local_address"
 680         methods.
 681
 682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 683
 684         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 685         (amd64fbsd_init_abi): Install gdbarch
 686         "fetch_tls_load_module_address" and "get_thread_local_address"
 687         methods.
 688
 689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 690
 691         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 692         (struct fbsd_pspace_data): New type.
 693         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 694         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 695         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 696         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 697         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 698
 699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 700
 701         * gdbtypes.c (lookup_struct_elt): New function.
 702         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 703         * gdbtypes.h (struct struct_elt): New type.
 704         (lookup_struct_elt): New prototype.
 705
 706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 707
 708         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 709         remove disabled code block.
 710
 711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 712
 713         * gdbarch.sh (get_thread_local_address): New method.
 714         * gdbarch.h, gdbarch.c: Regenerate.
 715         * target.c (target_translate_tls_address): Use
 716         gdbarch_get_thread_local_address if present instead of
 717         target::get_thread_local_address.
 718
 719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 720
 721         * target.h (target::get_thread_local_address): Update comment.
 722
 723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 724
 725         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 726         objfile->separate_debug_objfile_backlink if not NULL.
 727
 728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 729
 730         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 731         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 732         (amd64bsd_store_inferior_registers): Likewise.
 733         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 734         Enable segment base registers.
 735         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 736         PT_GETFSBASE and PT_GETGSBASE.
 737         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 738         PT_SETGSBASE.
 739         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 740         segment base registers.
 741         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 742
 743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 744
 745         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 746         Update calls to i386_target_description to add 'segments'
 747         parameter.
 748         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 749         add segment base registers.
 750         * arch/i386.c (i386_create_target_description): Add 'segments'
 751         parameter to enable segment base registers.
 752         * arch/i386.h (i386_create_target_description): Likewise.
 753         * features/i386/32bit-segments.xml: New file.
 754         * features/i386/32bit-segments.c: Generate.
 755         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 756         call to i386_target_description to add 'segments' parameter.
 757         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 758         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 759         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 760         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 761         if feature is present.
 762         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 763         Add 'segments' parameter to call to i386_target_description.
 764         (i386_target_description): Add 'segments' parameter to enable
 765         segment base registers.
 766         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 767         to call to i386_target_description.
 768         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 769         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 770         Define I386_NUM_REGS.
 771         (i386_target_description): Add 'segments' parameter to enable
 772         segment base registers.
 773
 774 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 775
 776         PR/24325
 777         * source-cache.c: #undef open and close, to avoid unresolved
 778         externals during linking.
 779
 780 2019-03-12  Tom Tromey  <tromey@adacore.com>
 781
 782         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 783         const.  Add initializers.
 784         (_initialize_remote): Don't initialize ptid globals.
 785
 786 2019-03-12  Pedro Alves  <palves@redhat.com>
 787
 788         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 789
 790 2019-03-12  Pedro Alves  <palves@redhat.com>
 791
 792         * cp-name-parser.y (main): Remove unused 'len' variable.
 793
 794 2019-03-12  Tom Tromey  <tromey@adacore.com>
 795
 796         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 797         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 798
 799 2019-03-12  Tom Tromey  <tromey@adacore.com>
 800
 801         * linux-nat.c (iterate_over_lwps): Update.
 802         (stop_callback): Remove parameter.
 803         (stop_wait_callback, detach_callback, resume_set_callback)
 804         (select_singlestep_lwp_callback, set_ignore_sigint)
 805         (status_callback, resumed_callback, resume_clear_callback)
 806         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 807         data parameter.
 808         (linux_nat_target::detach, linux_nat_target::resume)
 809         (linux_stop_and_wait_all_lwps, select_event_lwp)
 810         (linux_nat_filter_event, linux_nat_wait_1)
 811         (linux_nat_target::kill, linux_nat_target::stop)
 812         (linux_nat_target::stop): Update.
 813         (linux_nat_resume_callback): Change type.
 814         (resume_stopped_resumed_lwps, count_events_callback)
 815         (select_event_lwp_callback): Likewise.
 816         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 817         * arm-linux-nat.c (struct update_registers_data): Remove.
 818         (update_registers_callback): Change type.
 819         (arm_linux_insert_hw_breakpoint1): Update.
 820         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 821         parameter.
 822         (x86_linux_dr_set_addr): Update.
 823         (x86_linux_dr_set_control): Update.
 824         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 825         (iterate_over_lwps): Use gdb::function_view.
 826         * nat/aarch64-linux-hw-point.c (struct
 827         aarch64_dr_update_callback_param): Remove.
 828         (debug_reg_change_callback): Change type.
 829         (aarch64_notify_debug_reg_change): Update.
 830         * s390-linux-nat.c (s390_refresh_per_info): Update.
 831
 832 2019-03-11  Tom Tromey  <tromey@adacore.com>
 833
 834         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 835         redundant assignment to "this_cu".
 836
 837 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 838
 839         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 840
 841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 842
 843         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 844         from...
 845         (rank_one_type): ... this.
 846
 847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 848
 849         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 850         from...
 851         (rank_one_type): ... this.
 852
 853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 854
 855         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 856         from...
 857         (rank_one_type): ... this.
 858
 859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 860
 861         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 862         from...
 863         (rank_one_type): ... this.
 864
 865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 866
 867         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 868         from...
 869         (rank_one_type): ... this.
 870
 871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 872
 873         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 874         from...
 875         (rank_one_type): ... this.
 876
 877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 878
 879         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 880         from...
 881         (rank_one_type): ... this.
 882
 883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 884
 885         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 886         from...
 887         (rank_one_type): ... this.
 888
 889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 890
 891         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 892         from...
 893         (rank_one_type): ... this.
 894
 895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 896
 897         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 898         from...
 899         (rank_one_type): ... this.
 900
 901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 902
 903         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 904         from...
 905         (rank_one_type): ... this.
 906
 907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 908
 909         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 910         from...
 911         (rank_one_type): ... this.
 912
 913 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 914
 915         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 916         inferior-events' shows the example events.
 917
 918 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 919
 920         Support styling on native MS-Windows console
 921
 922         PR/24315
 923         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 924         on MS-Windows if $TERM is not defined.
 925
 926         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 927
 928         * posix-hdep.c (gdb_console_fputs):
 929         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 930         functions.
 931         * ui-file.h (gdb_console_fputs): Add prototype.
 932
 933         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 934         back to fputs only if the former returns zero.
 935
 936 2019-03-07  Tom Tromey  <tom@tromey.com>
 937
 938         * symmisc.c (print_symbol_bcache_statistics): Update.
 939         (print_objfile_statistics): Update.
 940         * symfile.c (allocate_symtab): Update.
 941         * stabsread.c: Don't include bcache.h.
 942         * psymtab.h (struct psymbol_bcache): Don't declare.
 943         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 944         (psymbol_bcache_init, psymbol_bcache_free)
 945         (psymbol_bcache_get_bcache): Don't declare.
 946         * psymtab.c (struct psymbol_bcache): Remove.
 947         (psymtab_storage::psymtab_storage): Update.
 948         (psymtab_storage::~psymtab_storage): Update.
 949         (psymbol_bcache_init, psymbol_bcache_free)
 950         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 951         (add_psymbol_to_bcache): Update.
 952         (allocate_psymtab): Update.
 953         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 954         macro_cache>: No longer pointers.
 955         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 956         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 957         * macrotab.c (macro_bcache): Update.
 958         * macroexp.c: Don't include bcache.h.
 959         * gdbtypes.c (check_types_worklist): Update.
 960         (types_deeply_equal): Remove TRY/CATCH.  Update.
 961         * elfread.c (elf_symtab_read): Update.
 962         * dwarf2read.c: Don't include bcache.h.
 963         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 964         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 965         (print_bcache_statistics, bcache_memory_used): Don't declare.
 966         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 967         methods.  Rename all data members.
 968         * bcache.c (struct bcache): Move to bcache.h.
 969         (bcache::expand_hash_table): Rename from expand_hash_table.
 970         (bcache): Remove.
 971         (bcache::insert): Rename from bcache_full.
 972         (bcache::compare): Rename from bcache_compare.
 973         (bcache_xmalloc): Remove.
 974         (bcache::~bcache): Rename from bcache_xfree.
 975         (bcache::print_statistics): Rename from print_bcache_statistics.
 976         (bcache::memory_used): Rename from bcache_memory_used.
 977
 978 2019-03-07  Pedro Alves  <palves@redhat.com>
 979
 980         * infrun.c (normal_stop): Also check for
 981         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 982
 983 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * f-lang.c (value_from_host_double): Moved to...
 986         * value.c (value_from_host_double): ...here.
 987         * value.h (value_from_host_double): Declare.
 988         * guile/scm-math.c (vlscm_convert_typed_number): Use
 989         value_from_host_double.
 990         (vlscm_convert_number): Likewise.
 991         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 992         * python/py-value.c (convert_value_from_python): Likewise.
 993
 994 2019-03-06  Tom Tromey  <tom@tromey.com>
 995
 996         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 997
 998 2019-03-06  Tom Tromey  <tom@tromey.com>
 999
1000         * utils.h (free_current_contents): Don't declare.
1001         * utils.c (free_current_contents): Remove.
1002
1003 2019-03-06  Tom Tromey  <tom@tromey.com>
1004
1005         * top.c (quit_force): Update.
1006         * main.c (captured_command_loop): Update.
1007         * common/new-op.c (operator new): Update.
1008         * common/common-exceptions.c (struct catcher)
1009         <save_cleanup_chain>: Remove member.
1010         (exceptions_state_mc_init): Update.
1011         (exception_try_scope_entry): Return nullptr.
1012         (exception_try_scope_exit, exception_rethrow)
1013         (throw_exception_sjlj, throw_exception_cxx): Update.
1014         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1015         (all_cleanups, do_cleanups, discard_cleanups)
1016         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1017         (restore_cleanups, restore_final_cleanups): Don't declare.
1018         (do_final_cleanups): Remove parameter.
1019         * common/cleanups.c (cleanup_chain, make_cleanup)
1020         (make_cleanup_dtor, all_cleanups, do_cleanups)
1021         (discard_my_cleanups, discard_cleanups)
1022         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1023         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1024         (null_cleanup): Remove.
1025         (do_final_cleanups): Remove parameter.
1026
1027 2019-03-06  Tom Tromey  <tom@tromey.com>
1028
1029         * remote.c (remote_target::remote_parse_stop_reply): Use
1030         unique_xmalloc_ptr.
1031
1032 2019-03-06  Tom Tromey  <tom@tromey.com>
1033
1034         * stabsread.c (struct stabs_field_info): Rename from field_info.
1035         <list, fnlist>: Add initializers.
1036         <obstack>: New member.
1037         (read_member_functions, read_struct_fields, read_baseclasses):
1038         Allocate on obstack.  Don't use cleanups.
1039         (read_one_struct_field, read_member_functions, read_struct_fields)
1040         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1041         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1042         (read_struct_type): Update.
1043
1044 2019-03-06  Tom Tromey  <tom@tromey.com>
1045
1046         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1047         * common/filestuff.h (make_cleanup_close): Don't declare.
1048         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1049         Remove.
1050
1051 2019-03-06  Tom Tromey  <tom@tromey.com>
1052
1053         * solib-aix.c: Use make_scope_exit.
1054
1055 2019-03-06  Tom Tromey  <tom@tromey.com>
1056
1057         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1058         Use make_scope_exit.
1059
1060 2019-03-06  Tom Tromey  <tom@tromey.com>
1061
1062         * solib-svr4.c (disable_probes_interface): Remove parameter.
1063         (svr4_handle_solib_event): Use make_scope_exit.
1064
1065 2019-03-06  Tom Tromey  <tom@tromey.com>
1066
1067         * remote.c (struct stop_reply_deleter): Remove.
1068         (stop_reply_up): Update.
1069         (struct stop_reply): Derive from notif_event.  Don't typedef.
1070         <regcache>: Now a std::vector.
1071         (stop_reply_xfree): Remove.
1072         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1073         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1074         (remote_target::discard_pending_stop_replies): Use delete.
1075         (remote_target::remote_parse_stop_reply): Update.
1076         (remote_target::process_stop_reply): Update.
1077         * remote-notif.h (struct notif_event): Add virtual destructor.
1078         Remove "dtr" member.
1079         (struct notif_client) <alloc_event>: Return a unique_ptr.
1080         (notif_event_xfree): Don't declare.
1081         (notif_event_up): New typedef.
1082         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1083         (notif_event_xfree, do_notif_event_xfree): Remove.
1084         (remote_notif_state_xfree): Update.
1085
1086 2019-03-06  Tom Tromey  <tom@tromey.com>
1087
1088         * infrun.c (displaced_step_clear_cleanup): Now a
1089         forward_scope_exit type.
1090         (displaced_step_prepare_throw): Update.
1091         (displaced_step_fixup): Update.
1092
1093 2019-03-06  Tom Tromey  <tom@tromey.com>
1094
1095         * inferior.h (class inferior): Update comment.
1096         * gdbthread.h (class thread_info): Update comment.
1097
1098 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1099             Tom Tromey  <tom@tromey.com>
1100
1101         * stabsread.h (struct stab_section_list): Remove.
1102         (coffstab_build_psymtabs): Update.
1103         * dbxread.c (symbuf_sections): Now a std::vector.
1104         (sect_idx): New global.
1105         (fill_symbuf): Update.
1106         (coffstab_build_psymtabs): Change type of stabsects parameter.
1107         Update.
1108         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1109         std::vector.
1110         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1111         (coff_locate_sections): Update.
1112         (coff_symfile_read): Remove cleanups.  Update.
1113         (init_stringtab): Add storage parameter.
1114         (free_stringtab, free_stringtab_cleanup): Remove.
1115         (init_lineno): Add storage parameter.
1116         (free_linetab, free_linetab_cleanup): Remove.
1117
1118 2019-03-06  Pedro Alves  <palves@redhat.com>
1119
1120         * linux-fork.c (fork_info::clobber_regs): Delete.
1121         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1122         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1123         comment.  Adjust.
1124         (scoped_switch_fork_info::scoped_switch_fork_info)
1125         (checkpoint_command, linux_fork_context): Adjust
1126         fork_save_infrun_state calls.
1127
1128 2019-03-06  Pedro Alves  <palves@redhat.com>
1129
1130         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1131         (inf_has_multiple_threads): Return 'bool' and rewrite using
1132         inferior_info::threads().
1133
1134 2019-03-06  Pedro Alves  <palves@redhat.com>
1135
1136         * linux-fork.c: Include <list>.
1137         (fork_list): Now a std::list instance.
1138         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1139         (forks_exist_p, find_last_fork): Adjust.
1140         (new_fork): Delete.
1141         (one_fork_p): New.
1142         (add_fork): Adjust.
1143         (free_fork): Delete, folded into fork_info::~fork_info().
1144         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1145         Adjust.
1146         (init_fork_list): Delete.
1147         (linux_fork_killall, linux_fork_mourn_inferior)
1148         (linux_fork_detach, info_checkpoints_command): Adjust.
1149         (_initialize_linux_fork): No longer call init_fork_list.
1150
1151 2019-03-06  Pedro Alves  <palves@redhat.com>
1152
1153         * linux-fork.c (new_fork): New, split out of ...
1154         (add_fork): ... this.  Return void.  Move "first fork" special
1155         case from here, to ...
1156         (checkpoint_command): ... here.
1157         * linux-linux.h (add_fork): Return void.
1158
1159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1160
1161         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1162
1163 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1164             Chris January  <chris.january@arm.com>
1165             David Lecomber  <david.lecomber@arm.com>
1166
1167         * f-exp.y: New token, UNOP_INTRINSIC.
1168         (exp): New pattern using UNOP_INTRINSIC token.
1169         (f77_keywords): Add 'abs' keyword.
1170         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1171         (value_from_host_double): New function.
1172         (evaluate_subexp_f): Support UNOP_ABS.
1173
1174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1175
1176         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1177         types.
1178
1179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1180
1181         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1182         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1183         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1184
1185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1188
1189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1190             Chris January  <chris.january@arm.com>
1191
1192         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1193         * f-exp.y: Define 'KIND' token.
1194         (exp): New pattern for KIND expressions.
1195         (ptype): Handle types with a kind extension.
1196         (direct_abs_decl): Extend to spot kind extensions.
1197         (f77_keywords): Add 'kind' to the list.
1198         (push_kind_type): New function.
1199         (convert_to_kind_type): New function.
1200         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1201         * parse.c (operator_length_standard): Likewise.
1202         * parser-defs.h (enum type_pieces): Add tp_kind.
1203         * std-operator.def: Add UNOP_KIND.
1204
1205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * f-exp.y (f_parse): Set yydebug.
1208
1209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1210
1211         * f-lang.c (evaluate_subexp_f): New function.
1212         (exp_descriptor_f): New global.
1213         (f_language_defn): Use exp_descriptor_f instead of
1214         exp_descriptor_standard.
1215
1216 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1217
1218         * f-exp.y (struct token): Add comments.
1219         (dot_ops): Remove uppercase versions and the end marker.
1220         (f77_keywords): Likewise.
1221         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1222         entries in the dot_ops array are case insensitive, and use
1223         strncasecmp to compare strings.  Also some whitespace cleanup in
1224         this area.  Similar for the f77_keywords array, except entries in
1225         this list might be case sensitive.
1226
1227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * f-exp.y (struct f77_boolean_val): Add comments.
1230         (boolean_values): Remove uppercase versions, and end marker.
1231         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1232         and use strncasecmp to achieve case insensitivity.  Additionally,
1233         perform whitespace cleanup around this code.
1234
1235 2019-03-06  Tom Tromey  <tromey@adacore.com>
1236
1237         * remote-sim.c (gdbsim_target_open): Use result of
1238         gdb_argv::release.
1239
1240 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1241         Dirk Schubert  <dirk.schubert@arm.com>
1242         Chris January  <chris.january@arm.com>
1243
1244         * eval.c (evaluate_subexp_standard): Call Fortran argument
1245         wrapping logic.
1246         * f-lang.c (struct value): A value which can be passed into a
1247         Fortran function call.
1248         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1249         where appropriate.
1250         (struct type): Value ready for a Fortran function call.
1251         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1252         is needed.
1253         * f-lang.h (fortran_argument_convert): Declaration.
1254         (fortran_preserve_arg_pointer): Declaration.
1255         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1256
1257 2019-03-05  Tom Tromey  <tromey@adacore.com>
1258
1259         * python/py-prettyprint.c (print_string_repr): Remove #if.
1260         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1261
1262 2019-03-05  Tom Tromey  <tromey@adacore.com>
1263
1264         * target.c (the_dummy_target): Move later.  Change type to
1265         "dummy_target".
1266         (initialize_targets): Don't initialize the_dummy_target.
1267
1268 2019-03-05  Tom Tromey  <tromey@adacore.com>
1269
1270         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1271         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1272
1273 2019-03-05  Tom Tromey  <tromey@adacore.com>
1274
1275         * windows-nat.c (windows_nat_target::attach)
1276         (windows_nat_target::detach): Don't call gdb_flush.
1277         * valprint.c (generic_val_print, val_print, val_print_string):
1278         Don't call gdb_flush.
1279         * utils.c (defaulted_query): Don't call gdb_flush.
1280         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1281         * target.c (target_announce_detach): Don't call gdb_flush.
1282         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1283         * remote.c (extended_remote_target::attach): Don't call
1284         gdb_flush.
1285         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1286         * printcmd.c (do_examine): Don't call gdb_flush.
1287         (info_display_command): Don't call gdb_flush.
1288         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1289         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1290         * memattr.c (info_mem_command): Don't call gdb_flush.
1291         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1292         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1293         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1294         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1295         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1296         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1297         (gnu_nat_target::detach): Don't call gdb_flush.
1298         * f-valprint.c (f_val_print): Don't call gdb_flush.
1299         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1300         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1301         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1302         gdb_flush.
1303         * c-valprint.c (c_val_print): Don't call gdb_flush.
1304         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1305
1306 2019-03-05  Tom Tromey  <tromey@adacore.com>
1307
1308         * varobj.c (update_dynamic_varobj_children): Update.
1309         (install_default_visualizer): Use reset, not release.
1310         * value.c (set_internalvar): Update.
1311         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1312         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1313         ATTRIBUTE_UNUSED_RESULT.
1314
1315 2019-03-05  Tom Tromey  <tromey@adacore.com>
1316
1317         * remote.c (class scoped_remote_fd) <release>: Add
1318         ATTRIBUTE_UNUSED_RESULT.
1319
1320 2019-03-05  Tom Tromey  <tromey@adacore.com>
1321
1322         * macroexp.c (struct macro_buffer) <release>: Add
1323         ATTRIBUTE_UNUSED_RESULT.
1324
1325 2019-03-05  Tom Tromey  <tromey@adacore.com>
1326
1327         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1328         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1329         ATTRIBUTE_UNUSED_RESULT.
1330
1331 2019-03-05  Tom Tromey  <tromey@adacore.com>
1332
1333         * common/scoped_fd.h (class scoped_fd) <release>: Add
1334         ATTRIBUTE_UNUSED_RESULT.
1335
1336 2019-03-05  Tom Tromey  <tromey@adacore.com>
1337
1338         * parser-defs.h (struct parser_state) <release>: Add
1339         ATTRIBUTE_UNUSED_RESULT.
1340
1341 2019-03-05  Tom Tromey  <tromey@adacore.com>
1342
1343         * utils.h (class gdb_argv) <release>: Add
1344         ATTRIBUTE_UNUSED_RESULT.
1345         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1346
1347 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1348
1349         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1350         for-loop range, to avoid compiler warnings.
1351
1352         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1353         avoid compiler warnings about unused variables.
1354
1355         * NEWS: Mention end of support for native debugging on MS-Windows
1356         before XP.
1357
1358         PR gdb/24292
1359         * common/netstuff.c:
1360         * gdbserver/gdbreplay.c
1361         * gdbserver/remote-utils.c:
1362         * ser-tcp.c:
1363         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1364         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1365         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1366         'getaddrinfo' and 'freeaddrinfo' were not available before
1367         Windows XP, and mingw.org's MinGW headers by default define
1368         _WIN32_WINNT to 0x500.
1369
1370 2019-03-01  Gary Benson <gbenson@redhat.com>
1371
1372         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1373
1374 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1375             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1376
1377         PR gdb/8527
1378         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1379         set_sigint_trap, clear_sigint_trap.
1380
1381 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1382
1383         * target.c (target_detach): Clear the regcache and the
1384         frame cache.
1385
1386 2019-02-27  Pedro Alves  <palves@redhat.com>
1387
1388         * utils.c (set_screen_size): When we cap the height/width sizes,
1389         tweak the corresponding command variable to show "unlimited":
1390
1391 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1392             Pedro Alves  <palves@redhat.com>
1393
1394         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1395         before calling rl_set_screen_size.
1396
1397 2019-02-27  Tom Tromey  <tromey@adacore.com>
1398
1399         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1400         define.
1401         * python/py-value.c: Remove Python 2.4 workaround.
1402         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1403         workaround.
1404         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1405         Python 2.4 workaround.
1406         * python/python-internal.h: Remove Python 2.4 comment.
1407         (Py_ssize_t): Don't define.
1408         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1409         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1410         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1411         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1412         * python/python.c (do_start_initialization): Remove Python 2.4
1413         workaround.
1414         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1415         (print_children): Remove Python 2.4 workaround.
1416         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1417         workaround.
1418         (CHARBUFFERPROC_NAME): Remove.
1419         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1420         Python 2.4 workaround.
1421
1422 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1423
1424         * NEWS: Note minimum Python version.
1425
1426 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1427
1428         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1429         code from these functions.  Remove corresponding ifdefs.  Use
1430         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1431         Remove gotos and target of gotos.
1432         (infpy_search_memory): Likewise.
1433
1434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1435
1436         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1437         (hppa_gdbarch_init): Don't register deleted functions with
1438         gdbarch.
1439
1440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1443         (h8300_unwind_sp): Delete.
1444         (h8300_dummy_id): Delete.
1445         (h8300_gdbarch_init): Don't register deleted functions with
1446         gdbarch.
1447
1448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1451         (ft32_unwind_pc): Delete.
1452         (ft32_unwind_sp): Delete.
1453         (ft32_gdbarch_init): Don't register deleted functions with
1454         gdbarch.
1455
1456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1459         (frv_unwind_pc): Delete.
1460         (frv_unwind_sp): Delete.
1461         (frv_gdbarch_init): Don't register deleted functions with
1462         gdbarch.
1463
1464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1467         (riscv_unwind_pc): Delete.
1468         (riscv_unwind_sp): Delete.
1469         (riscv_gdbarch_init): Don't register deleted functions with
1470         gdbarch.
1471
1472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1475         (csky_unwind_pc): Delete.
1476         (csky_unwind_sp): Delete.
1477         (csky_gdbarch_init): Don't register deleted functions with
1478         gdbarch.
1479
1480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1483         (cris_unwind_pc): Delete.
1484         (cris_unwind_sp): Delete.
1485         (cris_gdbarch_init): Don't register deleted functions with
1486         gdbarch.
1487
1488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1491         (bfin_unwind_pc): Delete.
1492         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1493
1494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1495
1496         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1497         (arm_unwind_pc): Delete.
1498         (arm_unwind_sp): Delete.
1499         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1500
1501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1504         (arc_unwind_pc): Delete.
1505         (arc_unwind_sp): Delete.
1506         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1507
1508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1511         (alpha_unwind_pc): Delete.
1512         (alpha_gdbarch_init): Don't register deleted functions with
1513         gdbarch.
1514
1515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1518         (aarch64_unwind_pc): Delete.
1519         (aarch64_unwind_sp): Delete.
1520         (aarch64_gdbarch_init): Don't register deleted functions with
1521         gdbarch.
1522
1523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * gdbtypes.c (type_align): Don't consider static members when
1526         computing structure alignment.
1527
1528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1531         return 0 for other types.
1532         * arch-utils.c (default_type_align): Always return 0.
1533         * gdbarch.h: Regenerate.
1534         * gdbarch.sh (type_align): Extend comment.
1535         * gdbtypes.c (type_align): Add additional comments, always call
1536         gdbarch_type_align before applying the default rules.
1537         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1538         generic code will then apply a suitable default.
1539         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1540         types, return 0 for other types.
1541
1542 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1543
1544         * NEWS: Create a new section for the next release branch.
1545         Rename the section of the current branch, now that it has
1546         been cut.
1547
1548 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1549
1550         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1551         * version.in: Bump version to 8.3.50.DATE-git.
1552
1553 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1554
1555         * aix-thread.c (ptid_cmp): Remove unused variable.
1556         (get_signaled_thread): Likewise.
1557         (store_regs_user_thread): Likewise.
1558         (store_regs_kernel_thread): Likewise.
1559         (fetch_regs_kernel_thread): Remove shadowed variable.
1560
1561 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * features/riscv/32bit-cpu.xml: Add register numbers.
1564         * features/riscv/32bit-fpu.c: Regenerate.
1565         * features/riscv/32bit-fpu.xml: Add register numbers.
1566         * features/riscv/64bit-cpu.xml: Add register numbers.
1567         * features/riscv/64bit-fpu.c: Regenerate.
1568         * features/riscv/64bit-fpu.xml: Add register numbers.
1569
1570 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1571
1572         * NEWS: Mention two argument form of gdb.Value constructor.
1573         * python/py-value.c (convert_buffer_and_type_to_value): New
1574         function.
1575         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1576         Add support for handling an optional second argument.  Call
1577         convert_buffer_and_type_to_value as appropriate.
1578         * python/python-internal.h (Py_buffer_deleter): New struct.
1579         (Py_buffer_up): New typedef.
1580
1581 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1582
1583         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1584         instead of releasing ownership.
1585
1586 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1587
1588         * dwarf2read.c (open_and_init_dwp_file): Call
1589         elf_numsections instead of bfd_count_sections to initialize
1590         dwp_file->num_sections.
1591
1592 2019-02-25  Tom Tromey  <tromey@adacore.com>
1593
1594         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1595
1596 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1597
1598         * gcore.in: Add '--readnever' option when invoking GDB.
1599
1600 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1601
1602         * MAINTAINERS: Update my email address.
1603
1604 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1605
1606         * build-id.c (build_id_to_debug_bfd_1): New function.
1607         (build_id_to_debug_bfd): Look for separate debug file in
1608         sysroot.
1609
1610 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1611
1612         * gdbarch.sh: Update the copyright year range that is placed into
1613         generated files.
1614
1615 2019-02-22  Keith Seitz  <keiths@redhat.com>
1616
1617         PR symtab/23853
1618         * linespec.c (create_sals_line_offset): Search for the default
1619         symtab's filename instead of its fullname.
1620
1621 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1622
1623         * NEWS: Update style defaults.
1624
1625 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1626
1627         * main.c (captured_main_1): Disable styling in batch mode.
1628
1629 2019-02-20  Tom Tromey  <tom@tromey.com>
1630
1631         * symtab.c (symtab_symbol_info): Fix typos.
1632
1633 2019-02-20  Tom Tromey  <tromey@adacore.com>
1634
1635         * findcmd.c (_initialize_mem_search): Use upper case for
1636         metasyntactic variables.
1637
1638 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1641         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1642
1643 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1644
1645         * top.h (source_file_name): Change to std::string.
1646         * top.c (source_file_name): Likewise.
1647         (command_line_input): Adjust.
1648         * cli/cli-script.c (script_from_file): Adjust.
1649
1650 2019-02-19  Tom Tromey  <tromey@adacore.com>
1651
1652         * ravenscar-thread.c
1653         (ravenscar_thread_target::update_thread_list): Don't call
1654         ada_build_task_list.
1655         * ada-lang.h (ada_build_task_list): Don't declare.
1656         * ada-tasks.c (struct ada_tasks_inferior_data)
1657         <task_list_valid_p>: Now bool.
1658         (read_known_tasks, ada_task_list_changed)
1659         (ada_tasks_invalidate_inferior_data): Update.
1660         (read_known_tasks_array): Return bool.
1661         (read_known_tasks_list): Likewise.
1662         (read_known_tasks): Return void.
1663         (ada_build_task_list): Now static.
1664
1665 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1668         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1669
1670 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1671
1672         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1673         variant for ada_tasks_pspace_data_handle and
1674         ada_tasks_inferior_data_handle.
1675         (ada_tasks_pspace_data_cleanup): New function.
1676         (ada_tasks_inferior_data_cleanup): New function.
1677
1678 2019-02-17  Tom Tromey  <tom@tromey.com>
1679
1680         * macrotab.h (macro_source_fullname): Return a std::string.
1681         * macrotab.c (macro_include, check_for_redefinition)
1682         (macro_undef, macro_lookup_definition, foreach_macro)
1683         (foreach_macro_in_scope): Update.
1684         (macro_source_fullname): Return a std::string.
1685         * macrocmd.c (show_pp_source_pos): Update.
1686
1687 2019-02-17  Tom Tromey  <tom@tromey.com>
1688
1689         * macrocmd.c (show_pp_source_pos): Style the file names.
1690
1691 2019-02-17  Tom Tromey  <tom@tromey.com>
1692
1693         PR tui/24197:
1694         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1695
1696 2019-02-17  Tom Tromey  <tom@tromey.com>
1697
1698         * ada-lang.c (user_select_syms): Use filtered printing.
1699         * utils.c (wrap_style): New global.
1700         (desired_style): Remove.
1701         (emit_style_escape): Add stream parameter.
1702         (set_output_style, reset_terminal_style, prompt_for_continue):
1703         Update.
1704         (flush_wrap_buffer): Only flush gdb_stdout.
1705         (wrap_here): Set wrap_style.
1706         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1707         treat escape sequences as a character.  Change when wrap buffer is
1708         flushed.
1709         (fputs_styled): Do not set the output style when the default is
1710         requested.
1711         * ui-style.h (struct ui_file_style) <is_default>: New method.
1712         * source.c (print_source_lines_base): Emit escape sequences in one
1713         piece.
1714
1715 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1716
1717         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1718         integers and enumeration types.
1719
1720 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1721
1722         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1723         instead of lookup_symbol_in_language
1724         (do_exact_match): New function.
1725         (ada_get_symbol_name_matcher): Return do_exact_match when
1726         doing a verbatim match.
1727
1728 2019-02-15  Tom Tromey  <tromey@adacore.com>
1729
1730         * ravenscar-thread.c (ravenscar_thread_target::resume)
1731         (ravenscar_thread_target::wait): Special case wildcard requests.
1732
1733 2019-02-15  Tom Tromey  <tromey@adacore.com>
1734
1735         * ravenscar-thread.c (base_ptid): Remove.
1736         (struct ravenscar_thread_target) <close>: New method.
1737         <m_base_ptid>: New member.
1738         <update_inferior_ptid, active_task, task_is_currently_active,
1739         runtime_initialized>: Declare methods.
1740         <ravenscar_thread_target>: Add constructor.
1741         (ravenscar_thread_target::task_is_currently_active)
1742         (ravenscar_thread_target::update_inferior_ptid)
1743         (ravenscar_runtime_initialized): Rename.  Now methods.
1744         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1745         (ravenscar_thread_target::update_thread_list): Update.
1746         (ravenscar_thread_target::active_task): Now method.
1747         (ravenscar_thread_target::store_registers)
1748         (ravenscar_thread_target::prepare_to_store)
1749         (ravenscar_thread_target::prepare_to_store)
1750         (ravenscar_thread_target::mourn_inferior): Update.
1751         (ravenscar_inferior_created): Use "new" to create target.
1752         (ravenscar_thread_target::get_ada_task_ptid): Update.
1753         (_initialize_ravenscar): Don't initialize base_ptid.
1754         (ravenscar_ops): Remove global.
1755
1756 2019-02-15  Tom Tromey  <tromey@adacore.com>
1757
1758         * target.h (push_target): Declare new overload.
1759         * target.c (push_target): New overload, taking an rvalue reference.
1760         * remote.c (remote_target::open_1): Use push_target overload.
1761         * corelow.c (core_target_open): Use push_target overload.
1762
1763 2019-02-15  Tom Tromey  <tromey@adacore.com>
1764
1765         * ravenscar-thread.c (is_ravenscar_task)
1766         (ravenscar_task_is_currently_active): Return bool.
1767         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1768         (_initialize_ravenscar): Remove "(void)".
1769         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1770         Return bool.
1771
1772 2019-02-15  Tom Tromey  <tromey@adacore.com>
1773
1774         * ravenscar-thread.c (ravenscar_runtime_initializer)
1775         (has_ravenscar_runtime, get_running_thread_id)
1776         (ravenscar_thread_target::resume): Fix indentation.
1777
1778 2019-02-15  Tom Tromey  <tromey@adacore.com>
1779
1780         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1781         from ravenscar_arch_ops.
1782         (sparc_ravenscar_ops::fetch_registers)
1783         (sparc_ravenscar_ops::store_registers): Now methods.
1784         (sparc_ravenscar_prepare_to_store): Remove.
1785         (sparc_ravenscar_ops): Redefine.
1786         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1787         methods and destructor.  Remove members.
1788         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1789         (ravenscar_thread_target::store_registers)
1790         (ravenscar_thread_target::prepare_to_store): Update.
1791         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1792         Remove.
1793         (struct ppc_ravenscar_powerpc_ops): Derive from
1794         ravenscar_arch_ops.
1795         (ppc_ravenscar_powerpc_ops::fetch_registers)
1796         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1797         (ppc_ravenscar_powerpc_ops): Redefine.
1798         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1799         (ppc_ravenscar_e500_ops::fetch_registers)
1800         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1801         (ppc_ravenscar_e500_ops): Redefine.
1802         * aarch64-ravenscar-thread.c
1803         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1804         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1805         (aarch64_ravenscar_fetch_registers)
1806         (aarch64_ravenscar_store_registers): Now methods.
1807         (aarch64_ravenscar_ops): Redefine.
1808
1809 2019-02-15  Tom Tromey  <tromey@adacore.com>
1810
1811         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1812         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1813         (ravenscar_thread_target::stopped_by_watchpoint)
1814         (ravenscar_thread_target::stopped_data_address)
1815         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1816
1817 2019-02-15  Tom Tromey  <tromey@adacore.com>
1818
1819         * ravenscar-thread.c: Fix some typos.
1820
1821 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1822             Tom Tromey  <tromey@adacore.com>
1823
1824         * ada-lang.c (ada_exception_sal): Change addr_string to a
1825         std::string.
1826         (create_ada_exception_catchpoint): Update.
1827
1828 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1829             Tom Tromey  <tromey@adacore.com>
1830
1831         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1832         (bp_location_ops): Remove.
1833         (base_breakpoint_allocate_location): Update.
1834         (free_bp_location): Update.
1835         * ada-lang.c (class ada_catchpoint_location)
1836         <ada_catchpoint_location>: Remove ops parameter.
1837         (ada_catchpoint_location_dtor): Remove.
1838         (ada_catchpoint_location_ops): Remove.
1839         (allocate_location_exception): Update.
1840         * breakpoint.h (struct bp_location_ops): Remove.
1841         (class bp_location) <bp_location>: Remove bp_location_ops
1842         parameter.
1843         <~bp_location>: Add destructor.
1844         <ops>: Remove.
1845
1846 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1847             Pedro Alves  <palves@redhat.com>
1848
1849         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1850         'PATH_MAX'.
1851
1852 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1853             Samuel Thibault  <samuel.thibault@gnu.org>
1854             Thomas Schwinge  <thomas@codesourcery.com>
1855
1856         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1857         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1858
1859 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1860
1861         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1862         (check_empty): Use "const char *".
1863
1864         * gnu-nat.c (gnu_nat_target::detach): Instead of
1865         'detach_inferior (pid)' call
1866         'detach_inferior (find_inferior_pid (pid))'.
1867
1868         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1869         'nat/fork-inferior.o'.
1870         * gnu-nat.c: #include "nat/fork-inferior.h".
1871
1872         * gnu-nat.c (gnu_nat_target::detach): Instead of
1873         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1874         * gnu-nat.h: #include "inf-child.h".
1875         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1876         'i386_gnu_nat_target::fetch_registers'.
1877         (gnu_store_registers): Rename/move to
1878         'i386_gnu_nat_target::store_registers'.
1879
1880         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1881         * gnu-nat.h (mach_thread_info): New function.
1882         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1883
1884         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1885
1886 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1887
1888         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1889
1890 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1891
1892         * windows-nat.c (windows_add_thread): Add new parameter
1893         "main_thread_p" with default value set to false.  Update
1894         function documentation as well as all callers.
1895         (windows_delete_thread): Likewise.
1896         (fake_create_process): Update call to windows_add_thread.
1897         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1898         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1899         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1900         call to windows_delete_thread.
1901
1902 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1903
1904         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1905
1906 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1907
1908         * symfile.c (find_separate_debug_file): Use canonical path of
1909         sysroot with child_path instead of gdb_sysroot if it is valid.
1910
1911 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1912
1913         * symfile.c (find_separate_debug_file): Use child_path to
1914         determine if an object file is under a sysroot.
1915
1916 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1917
1918         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1919         unittests/child-path-selftests.c.
1920         * common/pathstuff.c (child_path): New function.
1921         * common/pathstuff.h (child_path): New prototype.
1922         * unittests/child-path-selftests.c: New file.
1923
1924 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1925
1926         * symfile.c (find_separate_debug_file): Look for separate debug
1927         files in debug directories under the sysroot.
1928
1929 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1930
1931         * symtab.h (struct minimal_symbol data_p): New const method.
1932         (struct minimal_symbol text_p): Likewise.
1933         * symtab.c (output_source_filename): Use file name style
1934         to print file name.
1935         (print_symbol_info): Likewise.
1936         (print_msymbol_info): Use address style to print addresses.
1937         Use function name style to print executable text symbols.
1938         (expand_symtab_containing_pc): Use data_p.
1939         (find_pc_sect_compunit_symtab): Likewise.
1940
1941 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942
1943         * breakpoint.c (describe_other_breakpoints): Use address style
1944         to print addresses.
1945         (say_where): Likewise.
1946
1947 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1948
1949         * ada-typeprint.c (print_func_type): Print function name
1950         style to print function name.
1951         * c-typeprint.c (c_print_type_1): Likewise.
1952
1953 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1954
1955         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1956         for execve.
1957
1958 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1961         type_stack.
1962
1963 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1964
1965         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1966         TYPE_CODE_REF types.
1967
1968 2019-02-08  Jim Wilson  <jimw@sifive.com>
1969
1970         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1971         (riscv_linux_fregset): New.
1972         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1973
1974 2019-02-07  Tom Tromey  <tom@tromey.com>
1975
1976         * thread.c (thread_cancel_execution_command): Update.
1977         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1978         methods.
1979         (struct thread_fsm_ops): Remove.
1980         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1981         (thread_fsm_should_stop, thread_fsm_return_value)
1982         (thread_fsm_set_finished, thread_fsm_finished_p)
1983         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1984         Don't declare.
1985         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1986         * infrun.c (clear_proceed_status_thread)
1987         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1988         (print_stop_event): Update.
1989         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1990         Add constructor.
1991         (step_command_fsm_ops): Remove.
1992         (new_step_command_fsm): Remove.
1993         (step_1): Update.
1994         (step_command_fsm::should_stop): Rename from
1995         step_command_fsm_should_stop.
1996         (step_command_fsm::clean_up): Rename from
1997         step_command_fsm_clean_up.
1998         (step_command_fsm::do_async_reply_reason): Rename from
1999         step_command_fsm_async_reply_reason.
2000         (struct until_next_fsm): Inherit from thread_fsm.  Add
2001         constructor.
2002         (until_next_fsm_ops): Remove.
2003         (new_until_next_fsm): Remove.
2004         (until_next_fsm::should_stop): Rename from
2005         until_next_fsm_should_stop.
2006         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2007         (until_next_fsm::do_async_reply_reason): Rename from
2008         until_next_fsm_async_reply_reason.
2009         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2010         constructor.  Change type of breakpoint.
2011         (finish_command_fsm_ops): Remove.
2012         (new_finish_command_fsm): Remove.
2013         (finish_command_fsm::should_stop): Rename from
2014         finish_command_fsm_should_stop.
2015         (finish_command_fsm::clean_up): Rename from
2016         finish_command_fsm_clean_up.
2017         (finish_command_fsm::return_value): Rename from
2018         finish_command_fsm_return_value.
2019         (finish_command_fsm::do_async_reply_reason): Rename from
2020         finish_command_fsm_async_reply_reason.
2021         (finish_command): Update.
2022         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2023         Add constructor.
2024         (call_thread_fsm_ops): Remove.
2025         (call_thread_fsm::call_thread_fsm): Rename from
2026         new_call_thread_fsm.
2027         (call_thread_fsm::should_stop): Rename from
2028         call_thread_fsm_should_stop.
2029         (call_thread_fsm::should_notify_stop): Rename from
2030         call_thread_fsm_should_notify_stop.
2031         (run_inferior_call, call_function_by_hand_dummy): Update.
2032         * cli/cli-interp.c (should_print_stop_to_console): Update.
2033         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2034         Add constructor.  Change type of location_breakpoint,
2035         caller_breakpoint.
2036         (until_break_fsm_ops): Remove.
2037         (new_until_break_fsm): Remove.
2038         (until_break_fsm::should_stop): Rename from
2039         until_break_fsm_should_stop.
2040         (until_break_fsm::clean_up): Rename from
2041         until_break_fsm_clean_up.
2042         (until_break_fsm::do_async_reply_reason): Rename from
2043         until_break_fsm_async_reply_reason.
2044         (until_break_command): Update.
2045         * thread-fsm.c: Remove.
2046         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2047
2048 2019-02-07  Tom Tromey  <tom@tromey.com>
2049
2050         * yy-remap.h: Add include guard.
2051         * xtensa-tdep.h: Add include guard.
2052         * xcoffread.h: Rename include guard.
2053         * varobj-iter.h: Add include guard.
2054         * tui/tui.h: Rename include guard.
2055         * tui/tui-winsource.h: Rename include guard.
2056         * tui/tui-wingeneral.h: Rename include guard.
2057         * tui/tui-windata.h: Rename include guard.
2058         * tui/tui-win.h: Rename include guard.
2059         * tui/tui-stack.h: Rename include guard.
2060         * tui/tui-source.h: Rename include guard.
2061         * tui/tui-regs.h: Rename include guard.
2062         * tui/tui-out.h: Rename include guard.
2063         * tui/tui-layout.h: Rename include guard.
2064         * tui/tui-io.h: Rename include guard.
2065         * tui/tui-hooks.h: Rename include guard.
2066         * tui/tui-file.h: Rename include guard.
2067         * tui/tui-disasm.h: Rename include guard.
2068         * tui/tui-data.h: Rename include guard.
2069         * tui/tui-command.h: Rename include guard.
2070         * tic6x-tdep.h: Add include guard.
2071         * target/waitstatus.h: Rename include guard.
2072         * target/wait.h: Rename include guard.
2073         * target/target.h: Rename include guard.
2074         * target/resume.h: Rename include guard.
2075         * target-float.h: Rename include guard.
2076         * stabsread.h: Add include guard.
2077         * rs6000-tdep.h: Add include guard.
2078         * riscv-fbsd-tdep.h: Add include guard.
2079         * regformats/regdef.h: Rename include guard.
2080         * record.h: Rename include guard.
2081         * python/python.h: Rename include guard.
2082         * python/python-internal.h: Rename include guard.
2083         * python/py-stopevent.h: Rename include guard.
2084         * python/py-ref.h: Rename include guard.
2085         * python/py-record.h: Rename include guard.
2086         * python/py-record-full.h: Rename include guard.
2087         * python/py-record-btrace.h: Rename include guard.
2088         * python/py-instruction.h: Rename include guard.
2089         * python/py-events.h: Rename include guard.
2090         * python/py-event.h: Rename include guard.
2091         * procfs.h: Add include guard.
2092         * proc-utils.h: Add include guard.
2093         * p-lang.h: Add include guard.
2094         * or1k-tdep.h: Rename include guard.
2095         * observable.h: Rename include guard.
2096         * nto-tdep.h: Rename include guard.
2097         * nat/x86-linux.h: Rename include guard.
2098         * nat/x86-linux-dregs.h: Rename include guard.
2099         * nat/x86-gcc-cpuid.h: Add include guard.
2100         * nat/x86-dregs.h: Rename include guard.
2101         * nat/x86-cpuid.h: Rename include guard.
2102         * nat/ppc-linux.h: Rename include guard.
2103         * nat/mips-linux-watch.h: Rename include guard.
2104         * nat/linux-waitpid.h: Rename include guard.
2105         * nat/linux-ptrace.h: Rename include guard.
2106         * nat/linux-procfs.h: Rename include guard.
2107         * nat/linux-osdata.h: Rename include guard.
2108         * nat/linux-nat.h: Rename include guard.
2109         * nat/linux-namespaces.h: Rename include guard.
2110         * nat/linux-btrace.h: Rename include guard.
2111         * nat/glibc_thread_db.h: Rename include guard.
2112         * nat/gdb_thread_db.h: Rename include guard.
2113         * nat/gdb_ptrace.h: Rename include guard.
2114         * nat/fork-inferior.h: Rename include guard.
2115         * nat/amd64-linux-siginfo.h: Rename include guard.
2116         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2117         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2118         * nat/aarch64-linux.h: Rename include guard.
2119         * nat/aarch64-linux-hw-point.h: Rename include guard.
2120         * mn10300-tdep.h: Add include guard.
2121         * mips-linux-tdep.h: Add include guard.
2122         * mi/mi-parse.h: Rename include guard.
2123         * mi/mi-out.h: Rename include guard.
2124         * mi/mi-main.h: Rename include guard.
2125         * mi/mi-interp.h: Rename include guard.
2126         * mi/mi-getopt.h: Rename include guard.
2127         * mi/mi-console.h: Rename include guard.
2128         * mi/mi-common.h: Rename include guard.
2129         * mi/mi-cmds.h: Rename include guard.
2130         * mi/mi-cmd-break.h: Rename include guard.
2131         * m2-lang.h: Add include guard.
2132         * location.h: Rename include guard.
2133         * linux-record.h: Rename include guard.
2134         * linux-nat.h: Add include guard.
2135         * linux-fork.h: Add include guard.
2136         * i386-darwin-tdep.h: Rename include guard.
2137         * hppa-linux-offsets.h: Add include guard.
2138         * guile/guile.h: Rename include guard.
2139         * guile/guile-internal.h: Rename include guard.
2140         * gnu-nat.h: Rename include guard.
2141         * gdb-stabs.h: Rename include guard.
2142         * frv-tdep.h: Add include guard.
2143         * f-lang.h: Add include guard.
2144         * event-loop.h: Add include guard.
2145         * darwin-nat.h: Rename include guard.
2146         * cp-abi.h: Rename include guard.
2147         * config/sparc/nm-sol2.h: Rename include guard.
2148         * config/nm-nto.h: Rename include guard.
2149         * config/nm-linux.h: Add include guard.
2150         * config/i386/nm-i386gnu.h: Rename include guard.
2151         * config/djgpp/nl_types.h: Rename include guard.
2152         * config/djgpp/langinfo.h: Rename include guard.
2153         * compile/gcc-cp-plugin.h: Add include guard.
2154         * compile/gcc-c-plugin.h: Add include guard.
2155         * compile/compile.h: Rename include guard.
2156         * compile/compile-object-run.h: Rename include guard.
2157         * compile/compile-object-load.h: Rename include guard.
2158         * compile/compile-internal.h: Rename include guard.
2159         * compile/compile-cplus.h: Rename include guard.
2160         * compile/compile-c.h: Rename include guard.
2161         * common/xml-utils.h: Rename include guard.
2162         * common/x86-xstate.h: Rename include guard.
2163         * common/version.h: Rename include guard.
2164         * common/vec.h: Rename include guard.
2165         * common/tdesc.h: Rename include guard.
2166         * common/selftest.h: Rename include guard.
2167         * common/scoped_restore.h: Rename include guard.
2168         * common/scoped_mmap.h: Rename include guard.
2169         * common/scoped_fd.h: Rename include guard.
2170         * common/safe-iterator.h: Rename include guard.
2171         * common/run-time-clock.h: Rename include guard.
2172         * common/refcounted-object.h: Rename include guard.
2173         * common/queue.h: Rename include guard.
2174         * common/ptid.h: Rename include guard.
2175         * common/print-utils.h: Rename include guard.
2176         * common/preprocessor.h: Rename include guard.
2177         * common/pathstuff.h: Rename include guard.
2178         * common/observable.h: Rename include guard.
2179         * common/netstuff.h: Rename include guard.
2180         * common/job-control.h: Rename include guard.
2181         * common/host-defs.h: Rename include guard.
2182         * common/gdb_wait.h: Rename include guard.
2183         * common/gdb_vecs.h: Rename include guard.
2184         * common/gdb_unlinker.h: Rename include guard.
2185         * common/gdb_unique_ptr.h: Rename include guard.
2186         * common/gdb_tilde_expand.h: Rename include guard.
2187         * common/gdb_sys_time.h: Rename include guard.
2188         * common/gdb_string_view.h: Rename include guard.
2189         * common/gdb_splay_tree.h: Rename include guard.
2190         * common/gdb_setjmp.h: Rename include guard.
2191         * common/gdb_ref_ptr.h: Rename include guard.
2192         * common/gdb_optional.h: Rename include guard.
2193         * common/gdb_locale.h: Rename include guard.
2194         * common/gdb_assert.h: Rename include guard.
2195         * common/filtered-iterator.h: Rename include guard.
2196         * common/filestuff.h: Rename include guard.
2197         * common/fileio.h: Rename include guard.
2198         * common/environ.h: Rename include guard.
2199         * common/common-utils.h: Rename include guard.
2200         * common/common-types.h: Rename include guard.
2201         * common/common-regcache.h: Rename include guard.
2202         * common/common-inferior.h: Rename include guard.
2203         * common/common-gdbthread.h: Rename include guard.
2204         * common/common-exceptions.h: Rename include guard.
2205         * common/common-defs.h: Rename include guard.
2206         * common/common-debug.h: Rename include guard.
2207         * common/cleanups.h: Rename include guard.
2208         * common/buffer.h: Rename include guard.
2209         * common/btrace-common.h: Rename include guard.
2210         * common/break-common.h: Rename include guard.
2211         * cli/cli-utils.h: Rename include guard.
2212         * cli/cli-style.h: Rename include guard.
2213         * cli/cli-setshow.h: Rename include guard.
2214         * cli/cli-script.h: Rename include guard.
2215         * cli/cli-interp.h: Rename include guard.
2216         * cli/cli-decode.h: Rename include guard.
2217         * cli/cli-cmds.h: Rename include guard.
2218         * charset-list.h: Add include guard.
2219         * buildsym-legacy.h: Rename include guard.
2220         * bfin-tdep.h: Add include guard.
2221         * ax.h: Rename include guard.
2222         * arm-linux-tdep.h: Add include guard.
2223         * arm-fbsd-tdep.h: Add include guard.
2224         * arch/xtensa.h: Rename include guard.
2225         * arch/tic6x.h: Add include guard.
2226         * arch/i386.h: Add include guard.
2227         * arch/arm.h: Rename include guard.
2228         * arch/arm-linux.h: Rename include guard.
2229         * arch/arm-get-next-pcs.h: Rename include guard.
2230         * arch/amd64.h: Add include guard.
2231         * arch/aarch64-insn.h: Rename include guard.
2232         * arch-utils.h: Rename include guard.
2233         * annotate.h: Add include guard.
2234         * amd64-darwin-tdep.h: Rename include guard.
2235         * aarch64-linux-tdep.h: Add include guard.
2236         * aarch64-fbsd-tdep.h: Add include guard.
2237         * aarch32-linux-nat.h: Add include guard.
2238
2239 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2240
2241         * macrotab.c (macro_define_internal): New function that
2242         factorizes macro_define_object_internal and macro_define_function
2243         code.
2244         (macro_define_object_internal): Use macro_define_internal.
2245         (macro_define_function): Likewise.
2246
2247 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2248
2249         * macrocmd.c (extract_identifier): Return
2250         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2251         callers.
2252
2253 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2254
2255         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2256
2257 2019-02-05  Tom Tromey  <tom@tromey.com>
2258
2259         * target.c (target_stack::unpush): Move assertion earlier.
2260
2261 2019-01-30  Tom Tromey  <tom@tromey.com>
2262
2263         PR python/23615:
2264         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2265         (gdbpy_parse_and_eval): Likewise.
2266         * python/python-internal.h (gdbpy_allow_threads): New class.
2267
2268 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2269
2270         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2271         (aarch64_fbsd_fpregmap): Move earlier.
2272         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2273         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2274         instead of individual calls to trad_frame_set_reg_addr.
2275         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2276         earlier.
2277         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2278         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2279         instead of individual calls to trad_frame_set_reg_addr.
2280
2281 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2282
2283         * CONTRIBUTE: Replace contribution list with wiki link.
2284
2285 2019-01-25  Tom Tromey  <tom@tromey.com>
2286
2287         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2288
2289 2019-01-25  Tom Tromey  <tom@tromey.com>
2290
2291         * xtensa-linux-nat.c: Fix common/ includes.
2292         * xml-support.h: Fix common/ includes.
2293         * xml-support.c: Fix common/ includes.
2294         * x86-linux-nat.c: Fix common/ includes.
2295         * windows-nat.c: Fix common/ includes.
2296         * varobj.h: Fix common/ includes.
2297         * varobj.c: Fix common/ includes.
2298         * value.c: Fix common/ includes.
2299         * valops.c: Fix common/ includes.
2300         * utils.c: Fix common/ includes.
2301         * unittests/xml-utils-selftests.c: Fix common/ includes.
2302         * unittests/utils-selftests.c: Fix common/ includes.
2303         * unittests/unpack-selftests.c: Fix common/ includes.
2304         * unittests/tracepoint-selftests.c: Fix common/ includes.
2305         * unittests/style-selftests.c: Fix common/ includes.
2306         * unittests/string_view-selftests.c: Fix common/ includes.
2307         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2308         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2309         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2310         * unittests/rsp-low-selftests.c: Fix common/ includes.
2311         * unittests/parse-connection-spec-selftests.c: Fix common/
2312         includes.
2313         * unittests/optional-selftests.c: Fix common/ includes.
2314         * unittests/offset-type-selftests.c: Fix common/ includes.
2315         * unittests/observable-selftests.c: Fix common/ includes.
2316         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2317         * unittests/memrange-selftests.c: Fix common/ includes.
2318         * unittests/memory-map-selftests.c: Fix common/ includes.
2319         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2320         * unittests/function-view-selftests.c: Fix common/ includes.
2321         * unittests/environ-selftests.c: Fix common/ includes.
2322         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2323         * unittests/common-utils-selftests.c: Fix common/ includes.
2324         * unittests/cli-utils-selftests.c: Fix common/ includes.
2325         * unittests/array-view-selftests.c: Fix common/ includes.
2326         * ui-file.c: Fix common/ includes.
2327         * tui/tui-io.c: Fix common/ includes.
2328         * tracepoint.h: Fix common/ includes.
2329         * tracepoint.c: Fix common/ includes.
2330         * tracefile-tfile.c: Fix common/ includes.
2331         * top.h: Fix common/ includes.
2332         * top.c: Fix common/ includes.
2333         * thread.c: Fix common/ includes.
2334         * target/waitstatus.h: Fix common/ includes.
2335         * target/waitstatus.c: Fix common/ includes.
2336         * target.h: Fix common/ includes.
2337         * target.c: Fix common/ includes.
2338         * target-memory.c: Fix common/ includes.
2339         * target-descriptions.c: Fix common/ includes.
2340         * symtab.h: Fix common/ includes.
2341         * symfile.c: Fix common/ includes.
2342         * stap-probe.c: Fix common/ includes.
2343         * spu-linux-nat.c: Fix common/ includes.
2344         * sparc-nat.c: Fix common/ includes.
2345         * source.c: Fix common/ includes.
2346         * solib.c: Fix common/ includes.
2347         * solib-target.c: Fix common/ includes.
2348         * ser-unix.c: Fix common/ includes.
2349         * ser-tcp.c: Fix common/ includes.
2350         * ser-pipe.c: Fix common/ includes.
2351         * ser-base.c: Fix common/ includes.
2352         * selftest-arch.c: Fix common/ includes.
2353         * s12z-tdep.c: Fix common/ includes.
2354         * rust-exp.y: Fix common/ includes.
2355         * rs6000-aix-tdep.c: Fix common/ includes.
2356         * riscv-tdep.c: Fix common/ includes.
2357         * remote.c: Fix common/ includes.
2358         * remote-notif.h: Fix common/ includes.
2359         * remote-fileio.h: Fix common/ includes.
2360         * remote-fileio.c: Fix common/ includes.
2361         * regcache.h: Fix common/ includes.
2362         * regcache.c: Fix common/ includes.
2363         * record-btrace.c: Fix common/ includes.
2364         * python/python.c: Fix common/ includes.
2365         * python/py-type.c: Fix common/ includes.
2366         * python/py-inferior.c: Fix common/ includes.
2367         * progspace.h: Fix common/ includes.
2368         * producer.c: Fix common/ includes.
2369         * procfs.c: Fix common/ includes.
2370         * proc-api.c: Fix common/ includes.
2371         * printcmd.c: Fix common/ includes.
2372         * ppc-linux-nat.c: Fix common/ includes.
2373         * parser-defs.h: Fix common/ includes.
2374         * osdata.c: Fix common/ includes.
2375         * obsd-nat.c: Fix common/ includes.
2376         * nat/x86-linux.c: Fix common/ includes.
2377         * nat/x86-linux-dregs.c: Fix common/ includes.
2378         * nat/x86-dregs.h: Fix common/ includes.
2379         * nat/x86-dregs.c: Fix common/ includes.
2380         * nat/ppc-linux.c: Fix common/ includes.
2381         * nat/mips-linux-watch.h: Fix common/ includes.
2382         * nat/mips-linux-watch.c: Fix common/ includes.
2383         * nat/linux-waitpid.c: Fix common/ includes.
2384         * nat/linux-ptrace.h: Fix common/ includes.
2385         * nat/linux-ptrace.c: Fix common/ includes.
2386         * nat/linux-procfs.c: Fix common/ includes.
2387         * nat/linux-personality.c: Fix common/ includes.
2388         * nat/linux-osdata.c: Fix common/ includes.
2389         * nat/linux-namespaces.c: Fix common/ includes.
2390         * nat/linux-btrace.h: Fix common/ includes.
2391         * nat/linux-btrace.c: Fix common/ includes.
2392         * nat/fork-inferior.c: Fix common/ includes.
2393         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2394         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2395         * nat/aarch64-linux.c: Fix common/ includes.
2396         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2397         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2398         * namespace.h: Fix common/ includes.
2399         * mips-linux-tdep.c: Fix common/ includes.
2400         * minsyms.c: Fix common/ includes.
2401         * mi/mi-parse.h: Fix common/ includes.
2402         * mi/mi-main.c: Fix common/ includes.
2403         * mi/mi-cmd-env.c: Fix common/ includes.
2404         * memrange.h: Fix common/ includes.
2405         * memattr.c: Fix common/ includes.
2406         * maint.h: Fix common/ includes.
2407         * maint.c: Fix common/ includes.
2408         * main.c: Fix common/ includes.
2409         * machoread.c: Fix common/ includes.
2410         * location.c: Fix common/ includes.
2411         * linux-thread-db.c: Fix common/ includes.
2412         * linux-nat.c: Fix common/ includes.
2413         * linux-fork.c: Fix common/ includes.
2414         * inline-frame.c: Fix common/ includes.
2415         * infrun.c: Fix common/ includes.
2416         * inflow.c: Fix common/ includes.
2417         * inferior.h: Fix common/ includes.
2418         * inferior.c: Fix common/ includes.
2419         * infcmd.c: Fix common/ includes.
2420         * inf-ptrace.c: Fix common/ includes.
2421         * inf-child.c: Fix common/ includes.
2422         * ia64-linux-nat.c: Fix common/ includes.
2423         * i387-tdep.c: Fix common/ includes.
2424         * i386-tdep.c: Fix common/ includes.
2425         * i386-linux-tdep.c: Fix common/ includes.
2426         * i386-linux-nat.c: Fix common/ includes.
2427         * i386-go32-tdep.c: Fix common/ includes.
2428         * i386-fbsd-tdep.c: Fix common/ includes.
2429         * i386-fbsd-nat.c: Fix common/ includes.
2430         * guile/scm-type.c: Fix common/ includes.
2431         * guile/guile.c: Fix common/ includes.
2432         * go32-nat.c: Fix common/ includes.
2433         * gnu-nat.c: Fix common/ includes.
2434         * gdbthread.h: Fix common/ includes.
2435         * gdbarch-selftests.c: Fix common/ includes.
2436         * gdb_usleep.c: Fix common/ includes.
2437         * gdb_select.h: Fix common/ includes.
2438         * gdb_bfd.c: Fix common/ includes.
2439         * gcore.c: Fix common/ includes.
2440         * fork-child.c: Fix common/ includes.
2441         * findvar.c: Fix common/ includes.
2442         * fbsd-nat.c: Fix common/ includes.
2443         * event-top.c: Fix common/ includes.
2444         * event-loop.c: Fix common/ includes.
2445         * dwarf2read.c: Fix common/ includes.
2446         * dwarf2loc.c: Fix common/ includes.
2447         * dwarf2-frame.c: Fix common/ includes.
2448         * dwarf-index-cache.c: Fix common/ includes.
2449         * dtrace-probe.c: Fix common/ includes.
2450         * disasm-selftests.c: Fix common/ includes.
2451         * defs.h: Fix common/ includes.
2452         * csky-tdep.c: Fix common/ includes.
2453         * cp-valprint.c: Fix common/ includes.
2454         * cp-support.h: Fix common/ includes.
2455         * cp-support.c: Fix common/ includes.
2456         * corelow.c: Fix common/ includes.
2457         * completer.h: Fix common/ includes.
2458         * completer.c: Fix common/ includes.
2459         * compile/compile.c: Fix common/ includes.
2460         * compile/compile-loc2c.c: Fix common/ includes.
2461         * compile/compile-cplus-types.c: Fix common/ includes.
2462         * compile/compile-cplus-symbols.c: Fix common/ includes.
2463         * command.h: Fix common/ includes.
2464         * cli/cli-dump.c: Fix common/ includes.
2465         * cli/cli-cmds.c: Fix common/ includes.
2466         * charset.c: Fix common/ includes.
2467         * build-id.c: Fix common/ includes.
2468         * btrace.h: Fix common/ includes.
2469         * btrace.c: Fix common/ includes.
2470         * breakpoint.h: Fix common/ includes.
2471         * breakpoint.c: Fix common/ includes.
2472         * ax.h:
2473         (enum agent_op): Fix common/ includes.
2474         * ax-general.c (struct aop_map): Fix common/ includes.
2475         * ax-gdb.c: Fix common/ includes.
2476         * auxv.c: Fix common/ includes.
2477         * auto-load.c: Fix common/ includes.
2478         * arm-tdep.c: Fix common/ includes.
2479         * arch/riscv.c: Fix common/ includes.
2480         * arch/ppc-linux-common.c: Fix common/ includes.
2481         * arch/i386.c: Fix common/ includes.
2482         * arch/arm.c: Fix common/ includes.
2483         * arch/arm-linux.c: Fix common/ includes.
2484         * arch/arm-get-next-pcs.c: Fix common/ includes.
2485         * arch/amd64.c: Fix common/ includes.
2486         * arch/aarch64.c: Fix common/ includes.
2487         * arch/aarch64-insn.c: Fix common/ includes.
2488         * arch-utils.c: Fix common/ includes.
2489         * amd64-windows-tdep.c: Fix common/ includes.
2490         * amd64-tdep.c: Fix common/ includes.
2491         * amd64-sol2-tdep.c: Fix common/ includes.
2492         * amd64-obsd-tdep.c: Fix common/ includes.
2493         * amd64-nbsd-tdep.c: Fix common/ includes.
2494         * amd64-linux-tdep.c: Fix common/ includes.
2495         * amd64-linux-nat.c: Fix common/ includes.
2496         * amd64-fbsd-tdep.c: Fix common/ includes.
2497         * amd64-fbsd-nat.c: Fix common/ includes.
2498         * amd64-dicos-tdep.c: Fix common/ includes.
2499         * amd64-darwin-tdep.c: Fix common/ includes.
2500         * agent.c: Fix common/ includes.
2501         * ada-lang.h: Fix common/ includes.
2502         * ada-lang.c: Fix common/ includes.
2503         * aarch64-tdep.c: Fix common/ includes.
2504
2505 2019-01-25  Tom Tromey  <tom@tromey.com>
2506
2507         * common/create-version.sh: Use common/version.h.
2508
2509 2019-01-24  Pedro Alves  <palves@redhat.com>
2510
2511         * infrun.c (signal_stop, signal_print, signal_program)
2512         (signal_catch, signal_pass): Now arrays instead of pointers.
2513         (update_signals_program_target, do_target_resume)
2514         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2515         * linux-nat.c (linux_nat_target::pass_signals)
2516         (linux_nat_target::create_inferior, linux_nat_target::attach):
2517         Adjust.
2518         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2519         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2520         * procfs.c (procfs_target::pass_signals): Adjust.
2521         * record-full.c (record_full_target::resume): Adjust.
2522         * remote.c (remote_target::pass_signals)
2523         (remote_target::program_signals): Adjust.
2524         * target-debug.h (target_debug_print_signals): Now takes a
2525         gdb::array_view as parameter.  Adjust.
2526         * target.h (target_ops) <pass_signals, program_signals>: Replace
2527         pointer and length parameters with gdb::array_view.
2528         (target_pass_signals, target_program_signals): Likewise.
2529         * target-delegates.c: Regenerate.
2530
2531 2019-01-24  Pedro Alves  <palves@redhat.com>
2532
2533         * common/forward-scope-exit.h
2534         (forward_scope_exit::forward_scope_exit): Pass arguments to
2535         m_bind_function directly, instead of creating a std::bind and
2536         copying that.
2537
2538 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2539
2540         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2541         for static members.
2542         (pass_in_v_vfp_candidate): Likewise.
2543
2544 2019-01-23  Tom Tromey  <tom@tromey.com>
2545             Pedro Alves  <palves@redhat.com>
2546
2547         * regcache.c (class regcache_invalidator): Remove.
2548         (regcache::raw_write): Use make_scope_exit.
2549
2550 2019-01-23  Tom Tromey  <tom@tromey.com>
2551
2552         * ui-out.h (class ui_out_emit_type): Update comment.
2553
2554 2019-01-23  Tom Tromey  <tom@tromey.com>
2555
2556         * infrun.c (fetch_inferior_event): Update comment.
2557
2558 2019-01-23  Tom Tromey  <tom@tromey.com>
2559             Pedro Alves  <palves@redhat.com>
2560
2561         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2562         parameter.
2563         (fetch_inferior_event): Use SCOPE_EXIT.
2564
2565
2566 2019-01-23  Tom Tromey  <tom@tromey.com>
2567             Pedro Alves  <palves@redhat.com>
2568
2569         * infrun.c (disable_thread_events): Delete.
2570         (stop_all_threads): Use SCOPE_EXIT.
2571
2572 2019-01-23  Tom Tromey  <tom@tromey.com>
2573             Pedro Alves  <palves@redhat.com>
2574
2575         * symfile.c: Include forward-scope-exit.h.
2576         (clear_symtab_users_cleanup): Replace forward declaration with
2577         a FORWARD_SCOPE_EXIT.
2578         (syms_from_objfile_1): Use the forward_scope_exit and
2579         gdb::optional instead of cleanup_function.
2580         (reread_symbols): Use the forward_scope_exit instead of
2581         cleanup_function.
2582         (clear_symtab_users_cleanup): Remove function.
2583
2584 2019-01-23  Tom Tromey  <tom@tromey.com>
2585             Pedro Alves  <palves@redhat.com>
2586
2587         * linux-nat.c: Include scope-exit.h.
2588         (cleanup_target_stop): Remove.
2589         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2590         SCOPE_EXIT.
2591
2592 2019-01-23  Tom Tromey  <tom@tromey.com>
2593             Pedro Alves  <palves@redhat.com>
2594
2595         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2596         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2597
2598 2019-01-23  Tom Tromey  <tom@tromey.com>
2599             Andrew Burgess  <andrew.burgess@embecosm.com>
2600             Pedro Alves  <palves@redhat.com>
2601
2602         * infrun.c (fetch_inferior_event): Use scope_exit.
2603         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2604         * top.c (execute_command): Use scope_exit.
2605         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2606         * utils.c (do_bpstat_clear_actions_cleanup)
2607         (make_bpstat_clear_actions_cleanup): Remove.
2608
2609 2019-01-23  Tom Tromey  <tom@tromey.com>
2610             Pedro Alves  <palves@redhat.com>
2611
2612         * infrun.c: Include "common/scope-exit.h"
2613         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2614         (wait_for_inferior): Use SCOPE_EXIT.
2615         (fetch_inferior_event): Use scope_exit.
2616
2617 2019-01-23  Tom Tromey  <tom@tromey.com>
2618             Pedro Alves  <palves@redhat.com>
2619
2620         * breakpoint.c (create_breakpoint): Remove cleanup.
2621
2622 2019-01-23  Tom Tromey  <tom@tromey.com>
2623             Andrew Burgess  <andrew.burgess@embecosm.com>
2624             Pedro Alves  <palves@redhat.com>
2625
2626 2019-01-23  Pedro Alves  <palves@redhat.com>
2627
2628         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2629
2630 2019-01-23  Pedro Alves  <palves@redhat.com>
2631             Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * gdbthread.h: Include "common/forward-scope-exit.h".
2634         (scoped_finish_thread_state): Redefine custom class in terms of
2635         forward_scope_exit.
2636
2637 2019-01-23  Pedro Alves  <palves@redhat.com>
2638             Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * common/forward-scope-exit.h: New file.
2641
2642 2019-01-23  Pedro Alves  <palves@redhat.com>
2643             Andrew Burgess  <andrew.burgess@embecosm.com>
2644             Tom Tromey  <tom@tromey.com>
2645
2646         * common/scope-exit.h: New file.
2647
2648 2019-01-23  Pedro Alves  <palves@redhat.com>
2649
2650         * common/preprocessor.h (ESC): Rename to ...
2651         (ESC_PARENS): ... this.
2652         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2653         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2654
2655 2019-01-23  Tom Tromey  <tom@tromey.com>
2656
2657         * language.h (class scoped_switch_to_sym_language_if_auto):
2658         Initialize m_lang in both cases.
2659
2660 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2663         with XCNEW.
2664
2665 2019-01-22  Tom Tromey  <tom@tromey.com>
2666
2667         * corelow.c: Do not include sys/file.h.
2668
2669 2019-01-22  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-wingeneral.h: Include gdb_curses.h.
2672
2673 2019-01-22  Tom Tromey  <tom@tromey.com>
2674
2675         * source-cache.h (class source_cache) <get_source_lines,
2676         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2677
2678 2019-01-22  Tom Tromey  <tom@tromey.com>
2679
2680         * remote-fileio.h (struct remote_target): Declare.
2681
2682 2019-01-22  Tom Tromey  <tom@tromey.com>
2683
2684         * python/py-arch.c: Do not include py-ref.h.
2685         * python/py-bpevent.c: Do not include py-ref.h.
2686         * python/py-cmd.c: Do not include py-ref.h.
2687         * python/py-continueevent.c: Do not include py-ref.h.
2688         * python/py-event.h: Do not include py-ref.h.
2689         * python/py-evtregistry.c: Do not include py-ref.h.
2690         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2691         * python/py-frame.c: Do not include py-ref.h.
2692         * python/py-framefilter.c: Do not include py-ref.h.
2693         * python/py-function.c: Do not include py-ref.h.
2694         * python/py-infevents.c: Do not include py-ref.h.
2695         * python/py-linetable.c: Do not include py-ref.h.
2696         * python/py-objfile.c: Do not include py-ref.h.
2697         * python/py-param.c: Do not include py-ref.h.
2698         * python/py-prettyprint.c: Do not include py-ref.h.
2699         * python/py-progspace.c: Do not include py-ref.h.
2700         * python/py-symbol.c: Do not include py-ref.h.
2701         * python/py-symtab.c: Do not include py-ref.h.
2702         * python/py-type.c: Do not include py-ref.h.
2703         * python/py-unwind.c: Do not include py-ref.h.
2704         * python/py-utils.c: Do not include py-ref.h.
2705         * python/py-value.c: Do not include py-ref.h.
2706         * python/py-varobj.c: Do not include py-ref.h.
2707         * python/py-xmethods.c: Do not include py-ref.h.
2708         * python/python.c: Do not include py-ref.h.
2709         * varobj.c: Do not include py-ref.h.
2710
2711 2019-01-22  Tom Tromey  <tom@tromey.com>
2712
2713         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2714         keyword for bcache.
2715
2716 2019-01-22  Tom Tromey  <tom@tromey.com>
2717
2718         * compile/compile-cplus-types.c: Remove a comment by #include.
2719
2720 2019-01-22  Tom Tromey  <tom@tromey.com>
2721
2722         * compile/gcc-c-plugin.h: Include compile-internal.h.
2723
2724 2019-01-22  Tom Tromey  <tom@tromey.com>
2725
2726         * stabsread.c (EXTERN): Do not define.
2727         (symnum, next_symbol_text_func, processing_gcc_compilation)
2728         (within_function, global_sym_chain, global_stabs)
2729         (previous_stab_code, this_object_header_files)
2730         (n_this_object_header_files)
2731         (n_allocated_this_object_header_files): Define.
2732         * stabsread.h (EXTERN): Never define.  Use "extern".
2733
2734 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2735
2736         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2737         history_value.
2738
2739 2019-01-21  Tom Tromey  <tom@tromey.com>
2740
2741         * ui-out.c: Fix includes.
2742         * tui/tui-source.c: Fix includes.
2743         * target.c: Fix includes.
2744         * remote.c: Fix includes.
2745         * regcache.c: Fix includes.
2746         * python/py-block.c: Fix includes.
2747         * printcmd.c: Fix includes.
2748         * or1k-tdep.c: Fix includes.
2749         * mi/mi-main.c: Fix includes.
2750         * m32r-tdep.c: Fix includes.
2751         * csky-tdep.c: Fix includes.
2752         * compile/compile-cplus-types.c: Fix includes.
2753         * cli/cli-interp.c: Fix includes.
2754
2755 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2756
2757         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2758         for padding.
2759
2760 2019-01-16  Tom Tromey  <tom@tromey.com>
2761
2762         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2763         earlier.
2764         (struct objfile) <msymbols_range>: Move from top level.
2765         <msymbols>: New method.
2766         (class objfile_msymbols): Remove.
2767         * symtab.c (default_collect_symbol_completion_matches_break_on):
2768         Update.
2769         * symmisc.c (dump_msymbols): Update.
2770         * stabsread.c (scan_file_globals): Update.
2771         * objc-lang.c (info_selectors_command, info_classes_command)
2772         (find_methods): Update.
2773         * minsyms.c (find_solib_trampoline_target): Update.
2774         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2775         * coffread.c (coff_symfile_read): Update.
2776         * ada-lang.c (ada_lookup_simple_minsym)
2777         (ada_collect_symbol_completion_matches): Update.
2778
2779 2019-01-16  Tom Tromey  <tom@tromey.com>
2780
2781         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2782         type.  Remove no-argument constructor.
2783         <iterator::operator++>: Simplify.
2784         <begin>: Update.
2785         <end>: Use minimal_symbol_count.
2786
2787 2019-01-16  Tom Tromey  <tom@tromey.com>
2788
2789         * objfiles.h (struct objfile) <psymtabs>: New method.
2790         (class objfile_psymtabs): Remove.
2791         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2792         typedef.
2793         <range>: New method.
2794         (require_partial_symbols): Change return type.
2795         * psymtab.c (require_partial_symbols)
2796         (psym_expand_symtabs_matching): Update.
2797         * mdebugread.c (parse_partial_symbols): Update.
2798         * dbxread.c (dbx_end_psymtab): Update.
2799
2800 2019-01-15  Tom Tromey  <tom@tromey.com>
2801
2802         * symtab.c (lookup_objfile_from_block)
2803         (lookup_symbol_in_objfile_symtabs)
2804         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2805         (find_line_symtab, info_sources_command)
2806         (default_collect_symbol_completion_matches_break_on)
2807         (make_source_files_completion_list): Update.
2808         * symmisc.c (print_objfile_statistics, dump_objfile)
2809         (maintenance_print_symbols, maintenance_info_symtabs)
2810         (maintenance_check_symtabs, maintenance_info_line_tables):
2811         Update.
2812         * source.c (select_source_symtab)
2813         (forget_cached_source_info_for_objfile): Update.
2814         * objfiles.h (class objfile_compunits): Remove.
2815         (struct objfile) <compunits_range>: New typedef.
2816         (compunits): New method.
2817         * objfiles.c (objfile_relocate1): Update.
2818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2819         * maint.c (count_symtabs_and_blocks): Update.
2820         * linespec.c (iterate_over_all_matching_symtabs): Update.
2821         * cp-support.c (add_symbol_overload_list_qualified): Update.
2822         * coffread.c (coff_symtab_read): Update.
2823         * ada-lang.c (add_nonlocal_symbols)
2824         (ada_collect_symbol_completion_matches)
2825         (ada_add_global_exceptions): Update.
2826
2827 2019-01-15  Tom Tromey  <tom@tromey.com>
2828
2829         * progspace.h (program_space) <objfiles_safe_range>: New
2830         typedef.
2831         <objfiles_safe>: New method.
2832         * objfiles.h (class all_objfiles_safe): Remove.
2833         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2834         * jit.c (jit_inferior_exit_hook): Update.
2835
2836 2019-01-17  Tom Tromey  <tom@tromey.com>
2837
2838         * progspace.h (program_space) <objfiles_range>: New typedef.
2839         <objfiles>: New method.
2840         <objfiles_head>: Rename from objfiles.
2841         (object_files): Update.
2842         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2843         * guile/scm-pretty-print.c
2844         (ppscm_find_pretty_printer_from_objfiles): Update.
2845         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2846         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2847         Update.
2848         * python/py-progspace.c (pspy_get_objfiles): Update.
2849         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2850         Update.
2851         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2852         (objfpy_lookup_objfile_by_build_id): Update.
2853         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2854         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2855         Update.
2856         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2857         (expand_symtab_containing_pc, lookup_objfile_from_block)
2858         (lookup_static_symbol, basic_lookup_transparent_type)
2859         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2860         (find_line_symtab, info_sources_command)
2861         (default_collect_symbol_completion_matches_break_on)
2862         (make_source_files_completion_list, find_main_name): Update.
2863         * symmisc.c (print_symbol_bcache_statistics)
2864         (print_objfile_statistics, maintenance_print_symbols)
2865         (maintenance_print_msymbols, maintenance_print_objfiles)
2866         (maintenance_info_symtabs, maintenance_check_symtabs)
2867         (maintenance_expand_symtabs, maintenance_info_line_tables):
2868         Update.
2869         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2870         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2871         (map_overlay_command, unmap_overlay_command)
2872         (simple_overlay_update, expand_symtabs_matching)
2873         (map_symbol_filenames): Update.
2874         * symfile-debug.c (set_debug_symfile): Update.
2875         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2876         Update.
2877         * source.c (select_source_symtab, forget_cached_source_info):
2878         Update.
2879         * solib.c (solib_read_symbols): Update.
2880         * solib-spu.c (append_ocl_sos): Update.
2881         * psymtab.c (maintenance_print_psymbols)
2882         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2883         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2884         * printcmd.c (info_symbol_command): Update.
2885         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2886         Update.
2887         * objfiles.h (class all_objfiles): Remove.
2888         * objfiles.c (have_partial_symbols, have_full_symbols)
2889         (have_minimal_symbols, qsort_cmp, update_section_map)
2890         (shared_objfile_contains_address_p)
2891         (default_iterate_over_objfiles_in_search_order): Update.
2892         * objc-lang.c (info_selectors_command, info_classes_command)
2893         (find_methods): Update.
2894         * minsyms.c (find_solib_trampoline_target): Update.
2895         * maint.c (maintenance_info_sections)
2896         (maintenance_translate_address, count_symtabs_and_blocks):
2897         Update.
2898         * main.c (captured_main_1): Update.
2899         * linux-thread-db.c (try_thread_db_load_from_pdir)
2900         (has_libpthread): Update.
2901         * linespec.c (iterate_over_all_matching_symtabs)
2902         (search_minsyms_for_name): Update.
2903         * jit.c (jit_find_objf_with_entry_addr): Update.
2904         * hppa-tdep.c (find_unwind_entry)
2905         (hppa_lookup_stub_minimal_symbol): Update.
2906         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2907         Update.
2908         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2909         (elf_gnu_ifunc_resolve_by_got): Update.
2910         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2911         * dwarf-index-write.c (save_gdb_index_command): Update.
2912         * cp-support.c (add_symbol_overload_list_qualified): Update.
2913         * breakpoint.c (create_overlay_event_breakpoint)
2914         (create_longjmp_master_breakpoint)
2915         (create_std_terminate_master_breakpoint)
2916         (create_exception_master_breakpoint): Update.
2917         * blockframe.c (find_pc_partial_function): Update.
2918         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2919         (ada_collect_symbol_completion_matches)
2920         (ada_add_global_exceptions): Update.
2921
2922 2019-01-17  Tom Tromey  <tom@tromey.com>
2923
2924         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2925         declare VEC.
2926         (solib_target_parse_libraries): Change return type.
2927         (library_list_start_segment, library_list_start_section)
2928         (library_list_end_library, library_list_start_library); Update.
2929         (solib_target_free_library_list): Remove.
2930         (solib_target_parse_libraries): Remove cleanup.  Change return
2931         type.
2932         (solib_target_current_sos): Update.
2933
2934 2019-01-17  Tom Tromey  <tromey@bapiya>
2935
2936         * valprint.c: Replace "the the" with "the".
2937         * symtab.c: Replace "the the" with "the".
2938         * solib.c: Replace "the the" with "the".
2939         * solib-dsbt.c: Replace "the the" with "the".
2940         * linespec.c: Replace "the the" with "the".
2941         * dwarf2loc.h: Replace "the the" with "the".
2942         * amd64-windows-tdep.c: Replace "the the" with "the".
2943         * aarch64-tdep.c: Replace "the the" with "the".
2944
2945 2019-01-16  Keith Seitz  <keiths@redhat.com>
2946
2947         PR gdb/23773
2948         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2949         <builder>: Rename to ..
2950         <m_builder>: ... this and make private.
2951         (dwarf2_cu::get_builder): New method.  Change all users of
2952         `builder' to use this method.
2953         (dwarf2_start_symtab): Move to ...
2954         (dwarf2_cu::start_symtab): ... here.  Update all callers
2955         (setup_type_unit_groups): Move to ...
2956         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2957         callers.
2958         (dwarf2_cu::reset_builder): New method.
2959         (process_full_compunit, process_full_type_unit): Use
2960         dwarf2_cu::reset_builder.
2961         (follow_die_offset): Record the ancestor CU if it is different
2962         from the followed DIE's CU.
2963         (follow_die_sig_1): Likewise.
2964
2965 2019-01-15  Tom Tromey  <tom@tromey.com>
2966
2967         * remote.c (class remote_state) <buf>: Now a char_vector.
2968         <buf_size>: Remove.
2969         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2970         parameter.
2971         (remote_target::getpkt_or_notif_sane_1)
2972         (remote_target::getpkt_sane)
2973         (remote_target::getpkt_or_notif_sane): Likewise.
2974         (class remote_target) <putpkt>: New overload.
2975         (remote_target::read_frame): Change type of "buf_p".  Remove
2976         sizeof_p parameter.
2977         (packet_ok): New overload.
2978         (packet_check_result): New overload.
2979         Update all uses.
2980
2981 2019-01-14  Tom Tromey  <tom@tromey.com>
2982
2983         * remote-notif.c (handle_notification, remote_notif_ack)
2984         (remote_notif_parse): Make "buf" const.
2985         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2986         const.
2987         (remote_notif_parse, remote_notif_ack, handle_notification):
2988         Likewise.
2989         * remote.c (remote_notif_stop_parse): Make "buf" const.
2990         (remote_target::remote_parse_stop_reply): Make "buf" const.
2991         (remote_notif_stop_ack): Make "buf" const.
2992
2993 2019-01-14  Tom Tromey  <tom@tromey.com>
2994
2995         * remote.c (remote_console_output): Make parameter const.
2996
2997 2019-01-14  Tom Tromey  <tom@tromey.com>
2998
2999         * target-debug.h (target_debug_print_signals): Constify.
3000         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3001         * procfs.c (procfs_target::pass_signals): Update.
3002         * linux-nat.c (linux_nat_target::pass_signals): Update.
3003         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3004         * target-delegates.c: Rebuild.
3005         * remote.c (remote_target::program_signals): Update.
3006         (remote_target::pass_signals): Update.
3007         * target.c (target_pass_signals): Constify argument.
3008         (target_program_signals): Likewise.
3009         * target.h (struct target_ops) <pass_signals, program_signals>:
3010         Constify argument.
3011         (target_pass_signals, target_program_signals): Constify argument.
3012
3013 2019-01-14  Tom Tromey  <tom@tromey.com>
3014
3015         PR tui/28819:
3016         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3017
3018 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3019
3020         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3021         field.
3022         * rs6000-tdep.c: Include reggroups.h.
3023         (IS_V_ALIAS_PSEUDOREG): Define.
3024         (rs6000_register_name): Return names for the "vX" aliases.
3025         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3026         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3027         aliases.  Call default_register_reggroup_p for all other
3028         pseudo-registers.
3029         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3030         New functions.
3031         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3032         Handle "vX" aliases.
3033         (v_alias_pseudo_register_collect): New function.
3034         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3035         (rs6000_gdbarch_init): Initialize "vX" aliases as
3036         pseudo-registers.  Restore registration of
3037         rs6000_pseudo_register_reggroup_p with
3038         set_tdesc_pseudo_register_reggroup_p.
3039
3040 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3041
3042         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3043         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3044         set_gdbarch_num_pseudo_regs.
3045
3046 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3047
3048         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3049         Remove arg prefixname, add do_set and do_show.
3050         Add member functions set_list and show_list.
3051         * cli/cli-style.c (class cli_style_option): Update accordingly.
3052         (style_set_list): Move to file scope.
3053         (style_show_list): Likewise.
3054         (set_style): Call help_list.
3055         (show_style): Call cmd_show_list.
3056         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3057         Update to use the new macro.
3058
3059 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3060
3061         * ada-lang.c (_initialize_ada_language): Expand the help text
3062         for the "catch exception" command.
3063
3064 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3065
3066         * symtab.c (matching_obj_sections): Initialize obj,
3067         declare it closer to its usage.
3068
3069 2019-01-10  Tom Tromey  <tom@tromey.com>
3070
3071         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3072         (basic_inf_threads_range): Remove.
3073         (inf_threads_range, inf_non_exited_threads_range)
3074         (safe_inf_threads_range): Use next_adapter.
3075
3076 2019-01-10  Keith Seitz  <keiths@redhat.com>
3077
3078         PR gdb/23712
3079         PR symtab/23010
3080         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3081         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3082
3083 2019-01-10  Keith Seitz  <keiths@redhat.com>
3084
3085         PR gdb/23712
3086         PR symtab/23010
3087         * dictionary.c (pending_to_vector): Remove.
3088         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3089         Remove _1 suffix, replacing functions of the same name.  Update
3090         all callers.
3091         (dict_create_hashed, dict_create_hashed_expandable)
3092         (dict_create_linear, dict_create_linear_expandable, dict_free)
3093         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3094         Make functions static.
3095
3096 2019-01-10  Keith Seitz  <keiths@redhat.com>
3097
3098         PR gdb/23712
3099         PR symtab/23010
3100         * dictionary.h (struct dictionary): Replace declaration with
3101         multidictionary.
3102         (dict_create_hashed, dict_create_hashed_expandable)
3103         (dict_create_linear, dict_create_linear_expandable)
3104         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3105         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3106         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3107         taking multidictionary argument.
3108         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3109         * block.h (struct block) <dict>: Change to multidictionary
3110         and rename `multidict'.
3111         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3112         symmisc.c: Update all dictionary references to multidictionary.
3113
3114 2019-01-10  Keith Seitz  <keiths@redhat.com>
3115
3116         PR gdb/23712
3117         PR symtab/23010
3118         * dictionary.c: Include unordered_map.
3119         (pending_to_vector): New function.
3120         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3121         Rewrite the non-"_1" functions to take vector instead
3122         of linked list.
3123         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3124         "new" _1 versions of the same name.
3125         (multidictionary): Define.
3126         (std::hash<enum language): New definition.
3127         (collate_pending_symbols_by_language, mdict_create_hashed)
3128         (mdict_create_hashed_expandable, mdict_create_linear)
3129         (mdict_create_linear_expandable, mdict_free)
3130         (find_language_dictionary, create_new_language_dictionary)
3131         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3132         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3133         (mdict_size, mdict_empty): New functions.
3134         * dictionary.h (mdict_iterator): Define.
3135
3136 2019-01-10  Pedro Alves  <palves@redhat.com>
3137
3138         * breakpoint.c (read_uploaded_action)
3139         (create_tracepoint_from_upload): Adjust to use
3140         gdb::unique_xmalloc_ptr.
3141         * ctf.c (ctf_write_uploaded_tp):
3142         (SET_ARRAY_FIELD): Use emplace_back.
3143         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3144         * tracefile-tfile.c (tfile_write_uploaded_tp):
3145         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3146         gdb::unique_xmalloc_ptr.
3147         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3148         at_string, cond_string, cmd_strings>: Replace char pointers
3149         with gdb::unique_xmalloc_ptr.
3150
3151 2019-01-10  Pedro Alves  <palves@redhat.com>
3152
3153         * solib-target.c (library_list_start_library): Don't xstrdup name.
3154
3155 2019-01-10  Pedro Alves  <palves@redhat.com>
3156
3157         * mdebugread.c (parse_partial_symbols): Use
3158         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3159
3160 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * linux-fork.c (scoped_switch_fork_info)
3163         <~scoped_switch_fork_info>: Fix incorrect variable name.
3164
3165 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * linux-fork.c (scoped_switch_fork_info)
3168         <scoped_switch_fork_info>: Make explicit.
3169         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3170
3171 2019-01-10  Tom Tromey  <tom@tromey.com>
3172
3173         * objfiles.h (objfile::reset_psymtabs): Update.
3174         * objfiles.c (objfile::objfile): Update.
3175         * psymtab.h (psymtab_storage::obstack): Update.
3176         (psymtab_storage::m_obstack): Use gdb::optional.
3177         (class psymtab_storage): Update comment.  Remove objfile
3178         parameter.
3179         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3180
3181 2019-01-10  Tom Tromey  <tom@tromey.com>
3182
3183         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3184         <free_psymtabs>: Now private.
3185         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3186         (allocate_psymtab): Use new method.
3187
3188 2019-01-10  Tom Tromey  <tom@tromey.com>
3189
3190         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3191         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3192         * mdebugread.c (parse_partial_symbols): Use
3193         allocate_dependencies.
3194         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3195         allocate_dependencies.
3196         (process_psymtab_comp_unit_reader)
3197         (build_type_psymtab_dependencies): Likewise.
3198         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3199
3200 2019-01-10  Tom Tromey  <tom@tromey.com>
3201
3202         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3203         PSYMBOL_SET_LANGUAGE.
3204         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3205
3206 2019-01-10  Tom Tromey  <tom@tromey.com>
3207
3208         * psymtab.h (psymtab_storage::obstack): New method.
3209         <m_obstack>: Rename from obstack; now private.
3210         * psymtab.c (psymtab_storage): Update.
3211         * dwarf2read.c (create_addrmap_from_index)
3212         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3213         Update.
3214
3215 2019-01-10  Tom Tromey  <tom@tromey.com>
3216
3217         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3218         * objfiles.h (objfile::reset_psymtabs): New method.
3219
3220 2019-01-10  Tom Tromey  <tom@tromey.com>
3221
3222         * symmisc.c (print_symbol_bcache_statistics): Update.
3223         (print_objfile_statistics): Update.
3224         * symfile.c (reread_symbols): Update.
3225         * psymtab.h (class psymtab_storage): New.
3226         * psymtab.c (psymtab_storage): New constructor.
3227         (~psymtab_storage): New destructor.
3228         (require_partial_symbols): Update.
3229         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3230         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3231         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3232         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3233         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3234         (start_psymtab_common, end_psymtab_common)
3235         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3236         (allocate_psymtab): Update.
3237         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3238         Update.
3239         (dump_psymtab_addrmap, maintenance_print_psymbols)
3240         (maintenance_check_psymtabs): Update.
3241         (class objfile_psymtabs): Move to objfiles.h.
3242         * psympriv.h (discard_psymtab): Now inline.
3243         (psymtab_discarder::psymtab_discarder): Update.
3244         (psymtab_discarder::~psymtab_discarder): Update.
3245         (ALL_OBJFILE_PSYMTABS): Rewrite.
3246         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3247         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3248         Remove fields.
3249         <partial_symtabs>: New field.
3250         (class objfile_psymtabs): Move from psymtab.h.  Update.
3251         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3252         psymbol_cache.
3253         (objfile::~objfile): Don't destroy psymbol_cache.
3254         * mdebugread.c (parse_partial_symbols): Update.
3255         * dwarf2read.c (create_addrmap_from_index)
3256         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3257         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3258         (add_partial_subprogram, dwarf2_ranges_read): Update.
3259         * dwarf-index-write.c (write_address_map)
3260         (write_one_signatured_type, recursively_write_psymbols)
3261         (class debug_names, class debug_names, write_psymtabs_to_index):
3262         Update.
3263
3264 2019-01-10  Tom Tromey  <tom@tromey.com>
3265
3266         * symtab.h (SYMBOL_SET_NAMES): Update.
3267         (symbol_set_names): Update.
3268         (MSYMBOL_SET_NAMES): Update.
3269         * symtab.c (symbol_set_names): Change argument to be an
3270         objfile_per_bfd_storage.
3271         * psymtab.c (add_psymbol_to_bcache): Update.
3272         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3273
3274 2019-01-10  Tom Tromey  <tom@tromey.com>
3275
3276         * symtab.c (create_demangled_names_hash): Change argument to be an
3277         objfile_per_bfd_storage.
3278         (symbol_set_names): Update.
3279
3280 2019-01-10  Tom Tromey  <tom@tromey.com>
3281
3282         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3283         init_psymbol_list.
3284         * psymtab.c (init_psymbol_list): Do nothing if already called.
3285         * psympriv.h (init_psymbol_list): Add comment.
3286         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3287         init_psymbol_list.
3288         * dbxread.c (dbx_symfile_read): Unconditionally call
3289         init_psymbol_list.
3290
3291 2019-01-10  Tom Tromey  <tom@tromey.com>
3292
3293         * xcoffread.c (scan_xcoff_symtab): Update.
3294         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3295         "where".
3296         * mdebugread.c (parse_partial_symbols)
3297         (handle_psymbol_enumerators): Update.
3298         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3299         * dbxread.c (read_dbx_symtab): Update.
3300         * psympriv.h (psymbol_placement): New enum.
3301         (add_psymbol_to_list): Update.
3302
3303 2019-01-10  Tom Tromey  <tom@tromey.com>
3304
3305         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3306         static_psymbols parameters.
3307         (scan_xcoff_symtab): Update.
3308         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3309         static_psymbols parameters.
3310         * psympriv.h (start_psymtab_common): Update.
3311         * mdebugread.c (parse_partial_symbols): Update.
3312         * dwarf2read.c (create_partial_symtab): Update.
3313         * dbxread.c (read_dbx_symtab): Update.
3314         (start_psymtab): Remove global_psymbols and static_psymbols
3315         parameters.
3316
3317 2019-01-10  Tom Tromey  <tom@tromey.com>
3318
3319         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3320         * psymtab.c (allocate_psymtab): Add comment.
3321         * psympriv.h (allocate_psymtab): Add comment.
3322         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3323         initializations.
3324         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3325
3326 2019-01-10  Tom Tromey  <tom@tromey.com>
3327
3328         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3329         Don't declare.
3330         * mipsread.c: Include mdebugread.h.
3331         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3332         Declare.
3333         * elfread.c: Include mdebugread.h.
3334
3335 2019-01-09  Tom Tromey  <tom@tromey.com>
3336
3337         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3338         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3339         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3340         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3341         (psym_lookup_symbol, psym_find_last_source_symtab)
3342         (psym_forget_cached_source_info, psym_print_stats)
3343         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3344         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3345         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3346         (psym_find_compunit_symtab_by_address)
3347         (maintenance_print_psymbols, maintenance_info_psymtabs)
3348         (maintenance_check_psymtabs): Use ranged for.
3349         * psymtab.h (class objfile_psymtabs): New.
3350         (require_partial_symbols): Return objfile_psymtabs.
3351         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3352
3353 2019-01-09  Tom Tromey  <tom@tromey.com>
3354
3355         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3356         (find_pc_mapped_section, list_overlays_command)
3357         (map_overlay_command, unmap_overlay_command)
3358         (simple_overlay_update): Use all_objfiles.
3359         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3360         * printcmd.c (info_symbol_command): Use all_objfiles.
3361         * objfiles.h (ALL_OBJSECTIONS): Remove.
3362         * maint.c (maintenance_translate_address): Use all_objfiles.
3363         * gcore.c (gcore_create_callback): Use all_objfiles.
3364         (objfile_find_memory_regions): Likewise.
3365
3366 2019-01-09  Tom Tromey  <tom@tromey.com>
3367
3368         * symtab.c (find_line_symtab, info_sources_command)
3369         (make_source_files_completion_list): Use objfile_compunits.
3370         * source.c (select_source_symtab): Use objfile_compunits.
3371         * objfiles.h (struct objfile): Update comment.
3372         (ALL_OBJFILES): Remove.
3373         (ALL_FILETABS): Remove.
3374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3375         objfile_compunits.
3376
3377 2019-01-09  Tom Tromey  <tom@tromey.com>
3378
3379         * symmisc.c (print_objfile_statistics, dump_objfile)
3380         (maintenance_print_symbols): Use compunit_filetabs.
3381         * source.c (forget_cached_source_info_for_objfile): Use
3382         compunit_filetabs.
3383         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3384         (ALL_FILETABS): Use compunit_filetabs.
3385         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3386         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3387
3388 2019-01-09  Tom Tromey  <tom@tromey.com>
3389
3390         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3391         (compunit_filetabs): New.
3392         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3393         compunit_filetabs.
3394         (info_sources_command, make_source_files_completion_list): Remove
3395         declaration.
3396         * symmisc.c (print_objfile_statistics, dump_objfile)
3397         (maintenance_print_symbols): Remove declaration.
3398         (maintenance_info_symtabs): Use compunit_filetabs.
3399         (maintenance_info_line_tables): Likewise.
3400         * source.c (select_source_symtab): Change local variable name.
3401         (forget_cached_source_info_for_objfile): Remove declaration.
3402         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3403         * objfiles.c (objfile_relocate1): Remove declaration.
3404         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3405         declaration.
3406         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3407         * coffread.c (coff_symtab_read): Remove declaration.
3408         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3409         compunit_filetabs.
3410
3411 2019-01-09  Tom Tromey  <tom@tromey.com>
3412
3413         * symtab.c (lookup_objfile_from_block)
3414         (find_pc_sect_compunit_symtab, search_symbols)
3415         (default_collect_symbol_completion_matches_break_on): Use
3416         objfile_compunits.
3417         * objfiles.h (ALL_COMPUNITS): Remove.
3418         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3419         * cp-support.c (add_symbol_overload_list_qualified): Use
3420         objfile_compunits.
3421         * ada-lang.c (ada_collect_symbol_completion_matches)
3422         (ada_add_global_exceptions): Use objfile_compunits.
3423
3424 2019-01-09  Tom Tromey  <tom@tromey.com>
3425
3426         * source.c (select_source_symtab)
3427         (forget_cached_source_info_for_objfile): Remove declaration.
3428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3429         declaration.
3430         * maint.c (count_symtabs_and_blocks): Remove declaration.
3431         * cp-support.c (add_symbol_overload_list_qualified): Remove
3432         declaration.
3433         * coffread.c (coff_symtab_read): Remove declaration.
3434         * symtab.c (lookup_symbol_in_objfile_symtabs)
3435         (basic_lookup_transparent_type_1): Use objfile_compunits.
3436         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3437         (info_sources_command, search_symbols)
3438         (default_collect_symbol_completion_matches_break_on)
3439         (make_source_files_completion_list): Remove declaration.
3440         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3441         (ada_collect_symbol_completion_matches)
3442         (ada_add_global_exceptions): Remove declaration.
3443         * linespec.c (iterate_over_all_matching_symtabs): Use
3444         objfile_compunits.
3445         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3446         (class objfile_compunits): New.
3447         (ALL_COMPUNITS): Use objfile_compunits.
3448         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3449         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3450         objfile_compunits.
3451         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3452
3453 2019-01-09  Tom Tromey  <tom@tromey.com>
3454
3455         * symtab.c (search_symbols)
3456         (default_collect_symbol_completion_matches_break_on): Use
3457         objfile_msymbols.
3458         * ada-lang.c (ada_lookup_simple_minsym)
3459         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3460         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3461         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3462         objfile_msymbols.
3463         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3464         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3465         * objc-lang.c (find_methods): Use objfile_msymbols.
3466         (info_selectors_command, info_classes_command): Likewise.
3467         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3468         * objfiles.h (class objfile_msymbols): New.
3469         (ALL_OBJFILE_MSYMBOLS): Remove.
3470         (ALL_MSYMBOLS): Remove.
3471
3472 2019-01-09  Tom Tromey  <tom@tromey.com>
3473
3474         * common/next-iterator.h (next_adapter): Add Iterator template
3475         parameter.
3476         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3477         (class all_objfiles_safe): New.
3478         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3479         * objfiles.c (put_objfile_before): Update comment.
3480         (add_separate_debug_objfile): Likewise.
3481         (free_all_objfiles): Use all_objfiles_safe.
3482         (objfile_purge_solibs): Likewise.
3483
3484 2019-01-09  Tom Tromey  <tom@tromey.com>
3485
3486         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3487         (expand_symtab_containing_pc, lookup_static_symbol)
3488         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3489         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3490         all_objfiles.
3491         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3492         * breakpoint.c (create_overlay_event_breakpoint)
3493         (create_longjmp_master_breakpoint)
3494         (create_std_terminate_master_breakpoint)
3495         (create_exception_master_breakpoint): Use all_objfiles.
3496         * linux-thread-db.c (try_thread_db_load_from_pdir)
3497         (has_libpthread): Use all_objfiles.
3498         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3499         * linespec.c (iterate_over_all_matching_symtabs)
3500         (search_minsyms_for_name): Use all_objfiles.
3501         * maint.c (maintenance_info_sections): Use all_objfiles.
3502         * main.c (captured_main_1): Use all_objfiles.
3503         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3504         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3505         * guile/scm-pretty-print.c
3506         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3507         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3508         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3509         (maintenance_print_msymbols): Use all_objfiles.
3510         * source.c (select_source_symtab): Use all_objfiles.
3511         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3512         * symfile.c (remove_symbol_file_command)
3513         (expand_symtabs_matching, map_symbol_filenames): Use
3514         all_objfiles.
3515         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3516         all_objfiles.
3517         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3518         * objc-lang.c (find_methods): Use all_objfiles.
3519         * objfiles.c (have_partial_symbols, have_full_symbols)
3520         (have_minimal_symbols, qsort_cmp)
3521         (default_iterate_over_objfiles_in_search_order): Use
3522         all_objfiles.
3523         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3524         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3525         (maintenance_check_psymtabs): Use all_objfiles.
3526         (ALL_PSYMTABS): Remove.
3527         * compile/compile-object-run.c (do_module_cleanup): Use
3528         all_objfiles.
3529         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3530         * cp-support.c (add_symbol_overload_list_qualified): Use
3531         all_objfiles.
3532         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3533         Use all_objfiles.
3534         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3535         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3536         all_objfiles.
3537         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3538         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3539         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3540         Uses all_objfiles.
3541         * solib.c (solib_read_symbols): Use all_objfiles
3542
3543 2019-01-09  Tom Tromey  <tom@tromey.com>
3544
3545         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3546         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3547         all_objfiles.
3548         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3549         * symmisc.c (print_symbol_bcache_statistics)
3550         (print_objfile_statistics, maintenance_print_objfiles)
3551         (maintenance_info_symtabs, maintenance_check_symtabs)
3552         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3553         all_objfiles.
3554         * source.c (forget_cached_source_info): Use all_objfiles.
3555         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3556         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3557         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3558         * objfiles.c (update_section_map): Use all_objfiles.
3559         (shared_objfile_contains_address_p): Likewise.
3560         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3561         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3562
3563 2019-01-09  Tom Tromey  <tom@tromey.com>
3564
3565         * common/next-iterator.h: New file.
3566         * objfiles.h (class all_objfiles): New.
3567         (struct objfile_iterator): New.
3568
3569 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3570
3571         * NEWS: Move the description of the changed "frame", "select-frame",
3572          and "info frame" commands to the Changed commands section.
3573
3574 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3575
3576         * gdbtypes.c (check_stub_method_group): Remove handling of old
3577         mangling schemes.
3578         * linespec.c (find_methods): Likewise.
3579         * stabsread.c (read_member_functions): Likewise.
3580         * valops.c (search_struct_method): Likewise.
3581         (value_struct_elt_for_reference): Likewise.
3582         * NEWS: Mention this change.
3583
3584 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3585
3586         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3587         print_source_lines.
3588         * source.c (print_source_lines_base): Update line number check.
3589         (print_source_lines): New function.
3590         (source_lines_range::source_lines_range): New function.
3591         * source.h (class source_lines_range): New class.
3592         (print_source_lines): New declaration.
3593
3594 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3597
3598 2019-01-08  Tom Tromey  <tom@tromey.com>
3599             Simon Marchi  <simon.marchi@ericsson.com>
3600
3601         PR gdb/24060
3602         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3603         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3604         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3605         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3606         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3607         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3608
3609 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * source.c (select_source_symtab): Move header comment to
3612         declaration in source.h.
3613         (forget_cached_source_info_for_objfile): Likewise.
3614         (forget_cached_source_info): Likewise.
3615         (identify_source_line): Likewise.
3616         * source.h (identify_source_line): Move declaration from symtab.h
3617         and add comment from source.c
3618         (print_source_lines): Likewise.
3619         (forget_cached_source_info_for_objfile): Likewise.
3620         (forget_cached_source_info): Likewise.
3621         (select_source_symtab): Likewise.
3622         (enum print_source_lines_flag): Move definition from symtab.h.
3623         * symtab.h (identify_source_line): Move declaration to source.h.
3624         (print_source_lines): Likewise.
3625         (forget_cached_source_info_for_objfile): Likewise.
3626         (forget_cached_source_info): Likewise.
3627         (select_source_symtab): Likewise.
3628         (enum print_source_lines_flag): Move definition to source.h.
3629         * tui/tui-hooks.c: Add 'source.h' include.
3630
3631 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * source.c (print_source_lines_base): Handle requests to print
3634         reverse line number sequences, and guard against empty lines
3635         string.
3636
3637 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * source.c (print_source_lines_base): Fix skip of '\r' if next
3640         character is '\n'.
3641
3642 2019-01-06  Tom Tromey  <tom@tromey.com>
3643
3644         * c-exp.y (struct c_parse_state) <macro_original_text,
3645         expansion_obstack>: New member.
3646         (macro_original_text, expansion_obstack): Remove globals.
3647         (scan_macro_expansion, scanning_macro_expansion)
3648         (finished_macro_expansion): Update.
3649         (scan_macro_cleanup): Remove.
3650         (yylex, c_parse): Update.
3651
3652 2019-01-06  Tom Tromey  <tom@tromey.com>
3653
3654         * c-exp.y (struct c_parse_state) <strings>: New member.
3655         (operator_stoken): Update.
3656
3657 2019-01-06  Tom Tromey  <tom@tromey.com>
3658
3659         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3660         (union type_stack_elt) <typelist_val>: Now a pointer to
3661         std::vector.
3662         (type_stack_cleanup): Don't declare.
3663         (push_typelist): Update.
3664         * parse.c (pop_typelist): Return a std::vector.
3665         (push_typelist): Take a std::vector.
3666         (follow_types): Update.  Do not free args.
3667         (type_stack_cleanup): Remove.
3668         * c-exp.y (struct c_parse_state): New.
3669         (cpstate): New global.
3670         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3671         (nonempty_typelist): Update.
3672         (func_mod): Create a new vector.
3673         (c_parse): Create a c_parse_state.
3674         (check_parameter_typelist): Do not delete params.
3675         (function_method): Update.  Do not delete type_list.
3676
3677 2019-01-06  Tom Tromey  <tom@tromey.com>
3678
3679         PR gdb/28155:
3680         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3681         check_typedef.
3682         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3683         (print_return_value): Likewise.
3684
3685 2019-01-05  Tom Tromey  <tom@tromey.com>
3686
3687         * contrib/cleanup_check.py: Remove.
3688         * contrib/gcc-with-excheck: Remove.
3689         * contrib/exsummary.py: Remove.
3690         * contrib/excheck.py: Remove.
3691
3692 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3693
3694         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3695         NULL. Initialize tpprev to NULL instead of assigning it
3696         to NULL on the next statement.
3697         * windows-nat.c (windows_delete_thread): Remove check for
3698         main_thread_id before printing thread exit notifications.
3699         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3700         Remove thread ID check against main_thread_id.
3701         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3702         windows_delete_thread.
3703         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3704
3705 2019-01-04  Tom Tromey  <tom@tromey.com>
3706
3707         * compile/compile.c (_initialize_compile): Use upper case for
3708         metasyntactic variables.
3709         * symmisc.c (_initialize_symmisc): Use upper case for
3710         metasyntactic variables.
3711         * psymtab.c (_initialize_psymtab): Use upper case for
3712         metasyntactic variables.
3713         * demangle.c (demangle_command): Use upper case for metasyntactic
3714         variables.
3715         (_initialize_demangler): Likewise.
3716         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3717         variables.
3718
3719 2019-01-03  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3722
3723 2019-01-03  Tom Tromey  <tom@tromey.com>
3724
3725         * python/py-symtab.c (salpy_str): Update.
3726         (struct salpy_sal_object) <symtab>: Now a PyObject.
3727         (salpy_dealloc): Update.
3728         (del_objfile_sal): Use gdbpy_ref.
3729
3730 2019-01-03  Tom Tromey  <tom@tromey.com>
3731
3732         * python/py-type.c (convert_field): Use new_reference.  Return
3733         gdbpy_ref.
3734         (make_fielditem): Return gdbpy_ref.
3735         (typy_fields): Update.
3736         (typy_getitem): Update.
3737         (field_name): Return gdbpy_ref.  Use new_reference.
3738         (typy_iterator_iternext): Update.
3739
3740 2019-01-03  Tom Tromey  <tom@tromey.com>
3741
3742         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3743
3744 2019-01-03  Tom Tromey  <tom@tromey.com>
3745
3746         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3747         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3748         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3749         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3750         (pspy_set_type_printers): Likewise.
3751         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3752         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3753         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3754         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3755         (objfpy_set_type_printers): Likewise.
3756
3757 2019-01-03  Tom Tromey  <tom@tromey.com>
3758
3759         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3760         (gdbpy_print_stack): Use gdbpy_err_fetch.
3761         * python/python-internal.h (class gdbpy_err_fetch): New class.
3762         (class gdbpy_enter) <m_error_type, m_error_value,
3763         m_error_traceback>: Remove.
3764         <m_error>: New member.
3765         (gdbpy_exception_to_string): Don't declare.
3766         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3767         * python/py-value.c (convert_value_from_python): Use
3768         gdbpy_err_fetch.
3769         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3770         gdbpy_exception_to_string.
3771         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3772         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3773         gdbpy_err_fetch.
3774
3775 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * linux-nat.c (delete_lwp_cleanup): Delete.
3778         (struct lwp_deleter): New struct.
3779         (lwp_info_up): New typedef.
3780         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3781         lwp_info_up.
3782
3783 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * linux-fork.c (class scoped_switch_fork_info): New class.
3786         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3787
3788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * valops.c (find_overload_match): Remove use of null_cleanup, and
3791         calls to do_cleanups.
3792
3793 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * compile/compile-cplus-types.c
3796         (compile_cplus_instance::decl_name): Handle changes to
3797         cp_func_name.
3798         * cp-support.c (cp_func_name): Update header comment, update
3799         return type.
3800         * cp-support.h (cp_func_name): Update return type in declaration.
3801         * valops.c (find_overload_match): Move temp_func local to top
3802         level of function and change its type.  Use temp_func to hold and
3803         delete temporary string obtained from cp_func_name.
3804
3805 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3808         gdb::char_vector, remove cleanup, and update uses of `msg`.
3809
3810 2019-01-03  Jim Wilson  <jimw@sifive.com>
3811
3812         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3813
3814 2019-01-02  Tom Tromey  <tom@tromey.com>
3815
3816         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3817         (tdesc_parse_xml): Remove cleanups.
3818         * target-descriptions.h (make_cleanup_free_target_description):
3819         Don't declare.
3820         (target_desc_deleter): New struct.
3821         (target_desc_up): New typedef.
3822         * target-descriptions.c (target_desc_deleter::operator()): Rename
3823         from free_target_description.
3824         (make_cleanup_free_target_description): Remove.
3825
3826 2019-01-02  Tom Tromey  <tom@tromey.com>
3827
3828         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3829         constructor, destructor.
3830         (linespec_parser): Remove typedef.
3831         (~linespec_parser): Rename from linespec_parser_delete.
3832         (linespec_lex_to_end, linespec_complete_label)
3833         (linespec_complete): Update.
3834         (decode_line_full): Remove cleanups.
3835         (decode_line_1): Update.
3836
3837 2019-01-02  Tom Tromey  <tom@tromey.com>
3838
3839         * python/python-internal.h (inferior_to_inferior_object): Change
3840         return type.
3841         * python/py-exitedevent.c (create_exited_event_object): Update.
3842         * python/py-inferior.c (inferior_to_inferior_object): Return
3843         gdbpy_ref.
3844         (python_new_inferior, python_inferior_deleted)
3845         (thread_to_thread_object, delete_thread_object)
3846         (build_inferior_list, gdbpy_selected_inferior): Update.
3847         * python/py-infthread.c (create_thread_object): Update.  Also fail
3848         if inferior_to_inferior_object fails.
3849
3850 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3851
3852         * inferior.h (class inferior) <displaced_step_state>: New field.
3853         * infrun.h (struct displaced_step_state): Move here from
3854         infrun.c.  Initialize fields, add constructor.
3855         <inf>: Remove field.
3856         <reset>: New method.
3857         * infrun.c (struct displaced_step_inferior_state): Move to
3858         infrun.h.
3859         (displaced_step_inferior_states): Remove.
3860         (get_displaced_stepping_state): Adust.
3861         (displaced_step_in_progress_any_inferior): Adjust.
3862         (displaced_step_in_progress_thread): Adjust.
3863         (displaced_step_in_progress): Adjust.
3864         (add_displaced_stepping_state): Remove.
3865         (get_displaced_step_closure_by_addr): Adjust.
3866         (remove_displaced_stepping_state): Remove.
3867         (infrun_inferior_exit): Call displaced_step_state.reset.
3868         (use_displaced_stepping): Don't check for NULL.
3869         (displaced_step_prepare_throw): Call
3870         get_displaced_stepping_state.
3871         (displaced_step_fixup): Don't check for NULL.
3872         (prepare_for_detach): Don't check for NULL.
3873
3874 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3875
3876         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3877          in case of call that did not complete.
3878
3879 2019-01-02  Andrey Utkin  <autkin@undo.io>
3880
3881         * symfile.c (find_separate_debug_file): Fix search of debug files for
3882         remote debuggee.
3883
3884 2019-01-02  Tom Tromey  <tom@tromey.com>
3885
3886         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3887         indentation.
3888         * python/py-frame.c (frapy_older): Remove cast.
3889         (frapy_newer): Likewise.
3890         * python/py-breakpoint.c (local_setattro): Remove cast.
3891         * python/py-arch.c (archpy_name): Remove local variable.
3892         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3893
3894 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3895
3896         * unittests/basic_string_view/element_access/char/empty.cc:
3897         Fix year range in copyright header.
3898
3899 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3902         Delete.
3903         <operator==>: Update with for removed field.
3904         <hash>: Likewise.
3905         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3906         <isa_features>: ...this.
3907         <abi_features>: New field.
3908         (riscv_isa_flen): Update comment.
3909         (riscv_abi_xlen): New declaration.
3910         (riscv_abi_flen): New declaration.
3911         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3912         isa_features.
3913         (riscv_abi_xlen): New function.
3914         (riscv_isa_flen): Update to get answer from isa_features.
3915         (riscv_abi_flen): New function.
3916         (riscv_has_fp_abi): Update to get answer from abi_features.
3917         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3918         xlen and flen.
3919         (riscv_call_info) <xlen, flen>: Update comment.
3920         (riscv_call_arg_struct): Remove invalid assertions
3921         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3922         is removed.
3923         (riscv_gdbarch_init): Gather isa features and abi features
3924         separately, ensure both match on the gdbarch when reusing an old
3925         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3926         a target with 64-bit float hardware.
3927
3928 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * source.c (search_command_helper): Stop reverse search
3931         when line 1 has been searched.
3932
3933 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3934
3935         * record-full.c (record_full_base_target::close): Rewrite
3936         record_full_core_buf_list free logic.
3937
3938 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3939
3940         * break-catch-syscall.c (print_one_catch_syscall): xfree
3941         the last text.
3942
3943 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3944
3945         * top.c (print_gdb_version): Update Copyright year in version
3946         message.
3947
3948 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3949
3950         Update copyright year range in all GDB files.
3951
3952 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3953
3954         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3955
3956 For older changes see ChangeLog-2018.
3957 \f
3958 Local Variables:
3959 mode: change-log
3960 left-margin: 8
3961 fill-column: 74
3962 version-control: never
3963 coding: utf-8
3964 End:
3965