gdb/ChangeLog

   1 2019-10-01  Tom Tromey  <tom@tromey.com>
   2
   3         * cli/cli-logging.c (show_logging_filename): Use styled_string.
   4
   5 2019-10-01  Tom Tromey  <tom@tromey.com>
   6
   7         * stack.c (print_frame, info_frame_command_core): Use
   8         styled_string.
   9         * linux-thread-db.c (try_thread_db_load_1)
  10         (try_thread_db_load_from_pdir_1): Use styled_string.
  11         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  12         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  13         (maybe_print_unsupported_script_warning)
  14         (maybe_print_script_not_found_warning): Use styled_string.
  15         * ada-lang.c (user_select_syms): Use styled_string.
  16
  17 2019-10-01  Tom Tromey  <tom@tromey.com>
  18
  19         * p-lang.c (pascal_printstr): Use metadata style.
  20         * value.c (show_convenience): Use metadata style.
  21         * valprint.c (valprint_check_validity, val_print_optimized_out)
  22         (val_print_not_saved, val_print_unavailable)
  23         (val_print_invalid_address, generic_val_print, val_print)
  24         (value_check_printable, val_print_array_elements): Use metadata
  25         style.
  26         * ui-out.h (class ui_out) <field_fmt>: New overload.
  27         <do_field_fmt>: Add style parameter.
  28         * ui-out.c (ui_out::field_fmt): New overload.
  29         * typeprint.c (type_print_unknown_return_type)
  30         (val_print_not_allocated, val_print_not_associated): Use metadata
  31         style.
  32         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
  33         parameter.
  34         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
  35         * tracepoint.c (tvariables_info_1): Use metadata style.
  36         * stack.c (print_frame_arg, print_frame_info, print_frame)
  37         (info_frame_command_core): Use metadata style.
  38         * skip.c (info_skip_command): Use metadata style.
  39         * rust-lang.c (rust_print_enum): Use metadata style.
  40         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
  41         metadata style.
  42         * python/py-framefilter.c (py_print_single_arg): Use metadata
  43         style.
  44         * printcmd.c (do_one_display, print_variable_and_value): Use
  45         metadata style.
  46         * p-valprint.c (pascal_val_print)
  47         (pascal_object_print_value_fields): Use metadata style.
  48         * p-typeprint.c (pascal_type_print_base): Use metadata style.
  49         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
  50         parameter.
  51         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
  52         * m2-valprint.c (m2_print_long_set): Use metadata style.
  53         * m2-typeprint.c (m2_print_type): Use metadata style.
  54         * infcmd.c (print_return_value_1): Use metadata style.
  55         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
  56         * f-valprint.c (info_common_command_for_block): Use metadata
  57         style.
  58         * f-typeprint.c (f_type_print_base): Use metadata style.
  59         * expprint.c (print_subexp_standard): Use metadata style.
  60         * cp-valprint.c (cp_print_value_fields): Use metadata style.
  61         * cli/cli-style.h (class cli_style_option): Add constructor.
  62         (metadata_style): Declare.
  63         * cli/cli-style.c (metadata_style): New global.
  64         (_initialize_cli_style): Register metadata style.
  65         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
  66         parameter.
  67         * cli-out.c (cli_ui_out::do_field_fmt): Update.
  68         * c-typeprint.c (c_type_print_base_struct_union)
  69         (c_type_print_base_1): Use metadata style.
  70         * breakpoint.c (watchpoint_value_print)
  71         (print_one_breakpoint_location): Use metadata style.
  72         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
  73         style.
  74         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
  75         style.
  76         * ada-valprint.c (val_print_packed_array_elements, printstr)
  77         (print_field_values, ada_val_print_ref, ada_val_print): Use
  78         metadata style.
  79         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
  80         style.
  81         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
  82         style.
  83         * ada-lang.c (user_select_syms): Use metadata style.
  84
  85 2019-10-01  Tom Tromey  <tom@tromey.com>
  86
  87         * cli/cli-cmds.c (pwd_command): Style output.
  88
  89 2019-10-01  Pedro Alves  <palves@redhat.com>
  90             Tom Tromey  <tom@tromey.com>
  91
  92         * symtab.c (print_symbol_info): Use %ps.
  93         (print_msymbol_info): Use %ps.
  94         * symfile.c (symbol_file_add_with_addrs): Use %ps.
  95         * printcmd.c (print_variable_and_value): Use %ps.
  96         * macrocmd.c (show_pp_source_pos): Use %ps.
  97         * infrun.c (print_exited_reason): Use ui_out::message.
  98         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
  99         (describe_other_breakpoints): Use ui_out::message and new
 100         formats.
 101         (say_where): Use new formats.
 102         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 103         and new formats.
 104
 105 2019-10-01  Pedro Alves  <palves@redhat.com>
 106             Tom Tromey  <tom@tromey.com>
 107
 108         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 109         (test_gdb_formats): New function.
 110         (run_tests): Call it.
 111         (test_format_specifier): Update.
 112         * utils.h (fputs_filtered): Update comment.
 113         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 114         (fputs_styled_unfiltered): Declare.
 115         * utils.c (fputs_styled_unfiltered): New function.
 116         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 117         (vfprintf_filtered): Update.
 118         (vfprintf_unfiltered, vprintf_filtered): Update.
 119         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 120         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 121         disallow_ui_out_field>: New constants.
 122         (enum class field_kind): New.
 123         (struct base_field_s, struct signed_field_s): New.
 124         (signed_field): New function.
 125         (struct string_field_s): New.
 126         (string_field): New function.
 127         (struct styled_string_s): New.
 128         (styled_string): New function.
 129         (class ui_out) <message>: Add comment.
 130         <vmessage, call_do_message>: New methods.
 131         <do_message>: Add style parameter.
 132         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 133         methods.
 134         (ui_out::message): Rewrite.
 135         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 136         parameter.
 137         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 138         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 139         gdb_extensions parameter.
 140         (class format_piece): Add parameter to constructor.
 141         (n_int_args): New field.
 142         * gdbsupport/format.c (format_pieces::format_pieces): Add
 143         gdb_extensions parameter.  Handle '*'.
 144         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 145         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 146         vfprintf_styled_no_gdbfmt.
 147         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 148         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 149         unfiltered output.
 150         * ui-style.h (struct ui_file_style) <ptr>: New method.
 151
 152 2019-10-01  Tom Tromey  <tom@tromey.com>
 153
 154         * unittests/format_pieces-selftests.c: Update.  Add final format.
 155         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 156         empty literal pieces.
 157
 158 2019-10-01  Tom Tromey  <tom@tromey.com>
 159
 160         * ui-out.h (enum class ui_out_style_kind): Remove.
 161         (class ui_out) <field_string, field_stsream, do_field_string>:
 162         Change type of "style".
 163         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 164         (ui_out::field_string): Update.
 165         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 166         of "style".
 167         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 168         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 169         * stack.c (print_frame_arg, print_frame_info, print_frame):
 170         Update.
 171         * source.c (print_source_lines_base): Update.
 172         * solib.c (info_sharedlibrary_command): Update.
 173         * skip.c (info_skip_command): Update.
 174         * record-btrace.c (btrace_call_history_src_line)
 175         (btrace_call_history): Update.
 176         * python/py-framefilter.c (py_print_frame): Update.
 177         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 178         "style".
 179         * mi/mi-out.c (mi_ui_out::do_table_header)
 180         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 181         (mi_ui_out::do_field_string): Update.
 182         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 183         Update.
 184         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 185         "style".
 186         * cli-out.c (cli_ui_out::do_table_header)
 187         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 188         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 189         (cli_ui_out::do_field_fmt): Update.
 190         * breakpoint.c (print_breakpoint_location): Update.
 191         (update_static_tracepoint): Update.
 192
 193 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 194
 195         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 196         conversion of gdb_datadir.
 197         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 198         remove not needed c_str ().
 199
 200 2019-09-30  Ali Tamur <tamur@google.com>
 201
 202         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 203         (dwarf2_string_attr): Likewise.
 204
 205 2019-09-30  Ali Tamur <tamur@google.com>
 206
 207         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 208         (process_full_type_unit): Likewise.
 209         (dump_die_shallow): Likewise.
 210         (cu_debug_loc_section): Likewise.
 211
 212 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * minsyms.c (compare_minimal_symbols): Rename to...
 215         (minimal_symbol_is_less_than): ...this, and adjust to STL
 216         conventions (return bool, take arguments as references)
 217         (minimal_symbol_reader::install): Call std::sort instead
 218         of qsort.
 219
 220 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 221
 222         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 223         hash and why.
 224         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 225         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 226
 227 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 228
 229         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 230         * psympriv.h (add_psymbol_to_list): Move comment here and update
 231         it.
 232
 233 2019-09-29  Tom de Vries  <tdevries@suse.de>
 234
 235         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 236         Use $tmpdir/$(basename "$output_file").dwz instead of
 237         "${output_file}.dwz".
 238
 239 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         PR gdb/25045
 242         * hppa-linux-nat.c: Include gdbarch.h.
 243
 244 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * blockframe.c (find_pc_partial_function): Change return type to bool.
 247         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 248         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 249         (stub_gnu_ifunc_resolve_name): Likewise.
 250         * symtab.c (compare_filenames_for_search): Likewise.
 251         (compare_glob_filenames_for_search): Likewise.
 252         (matching_obj_sections): Likewise.
 253         (symbol_matches_domain): Likewise.
 254         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 255         (find_line_pc): Change return type to bool.
 256         (find_line_pc_range): Likewise.
 257         (producer_is_realview): Likewise.
 258         * symtab.h (symbol_matches_domain): Likewise.
 259         (find_pc_partial_function): Likewise.
 260         (find_pc_line_pc_range): Likewise.
 261         (in_gnu_ifunc_stub): Likewise.
 262         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 263         (find_line_pc): Likewise.
 264         (find_line_pc_range): Likewise.
 265         (matching_obj_sections): Likewise.
 266         (find_line_symtab): Change out parameter to bool.
 267         (producer_is_realview): Change return type to bool.
 268         (compare_filenames_for_search): Likewise.
 269         (compare_glob_filenames_for_search): Likewise.
 270
 271 2019-09-26  Tom Tromey  <tom@tromey.com>
 272
 273         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 274         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 275         * gdb_usleep.h: Remove.
 276         * gdb_usleep.c: Remove.
 277         * utils.c: Don't include gdb_usleep.h.
 278
 279 2019-09-26  Tom Tromey  <tromey@adacore.com>
 280
 281         * python/py-type.c (type_to_type_object): Call check_typedef
 282         for stub types.
 283
 284 2019-09-26  Tom Tromey  <tom@tromey.com>
 285
 286         * utils.h (initialize_utils): Don't declare.
 287         * top.c (gdb_init): Don't call initialize_utils.
 288         * utils.c (initialize_utils): Remove.  Move contents...
 289         (_initialize_utils): ... here.
 290
 291 2019-09-25  Tom Tromey  <tom@tromey.com>
 292
 293         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 294         * utils.h (make_hex_string): Don't declare.
 295         * utils.c (make_hex_string): Remove.
 296
 297 2019-09-24  Tom de Vries  <tdevries@suse.de>
 298
 299         PR gdb/23815
 300         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 301         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 302
 303 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 304
 305         * NEWS: Mention new simulator port for PRU.
 306
 307 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * ada-exp.y (write_object_remaining): Update.
 310         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 311         and eliminate the static buffer.
 312         (ada_decode_symbol): Update.
 313         (ada_la_decode): Update.
 314         (ada_sniff_from_mangled_name): Update.
 315         (is_valid_name_for_wild_match): Update.
 316         (ada_lookup_name_info::matches): Update and simplify.
 317         (name_matches_regex): Update.
 318         (ada_add_global_exceptions): Update.
 319         * ada-lang.h (ada_decode): Update signature.
 320         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 321         * dwarf-index-write.c (debug_names::insert): Update.
 322
 323 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 324
 325         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 326         formatting.
 327
 328 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 329
 330         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 331         Change "nonzero" to "true" in documentation.
 332
 333 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 334
 335         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 336         (_initialize_darwin_solib): Don't set
 337         darwin_so_ops.lookup_lib_global_symbol.
 338         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 339         set_gdbarch_iterate_over_objfiles_in_search_order.
 340         (elf_lookup_lib_symbol): Rename to...
 341         (svr4_iterate_over_objfiles_in_search_order): this, and update
 342         to iterate semantics.
 343         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 344         * solib.c (solib_global_lookup): Remove.
 345         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 346         (solib_global_lookup): Remove.
 347         * symtab.c (lookup_global_or_static_symbol): Remove call to
 348         solib_global_lookup.
 349
 350 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 351
 352         * NEWS: Move entries about default MI version now being
 353         version 3, and about the GDB/MI fix for multi-location
 354         breakpoints to the "since GDB 8.3" section.
 355
 356 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 357
 358         GDB 8.3.1 released.
 359
 360 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 361
 362         * NEWS: Mention that Cell/B.E. debugging support was removed.
 363         * MAINTAINERS: Remove spu target.
 364
 365         * config/djgpp/fnchange.lst: Remove entries for removed files.
 366
 367         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 368         spu-multiarch.o, and spu-tdep.o.
 369         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 370         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 371         spu-multiarch.c, and spu-tdep.c.
 372         * spu-linux-nat.c: Remove file.
 373         * spu-multiarch.c: Remove file.
 374         * spu-tdep.c: Remove file.
 375         * spu-tdep.h: Remove file.
 376         * solib-spu.c: Remove file.
 377         * solib-spu.h: Remove file.
 378
 379         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 380         * configure.nat (spu-linux): Remove.
 381         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 382         solib-multiarch.o from gdb_target_obs.
 383         (spu*-*-*): Remove.
 384
 385         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 386         feature flag.
 387         (ppc_linux_no_features): Update.
 388         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 389         Cell/B.E. support.
 390         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 391         (tdesc_powerpc_cell64l): Likewise.
 392         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 393         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 394         Cell/B.E. support.
 395         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 396         Do not include "features/rs6000/powerpc-cell32l.c" or
 397         "features/rs6000/powerpc-cell64l.c".
 398         (ppc_linux_spu_section): Remove.
 399         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 400         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 401         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 402         (ppc_linux_spe_context_lookup): Remove.
 403         (ppc_linux_spe_context_inferior_created): Remove.
 404         (ppc_linux_spe_context_solib_loaded): Remove.
 405         (ppc_linux_spe_context_solib_unloaded): Remove.
 406         (ppc_linux_spe_context): Remove.
 407         (struct ppu2spu_cache): Remove.
 408         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 409         (struct ppu2spu_data): Remove.
 410         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 411         ppu2spu_unwind): Remove.
 412         (ppc_linux_init_abi): Remove Cell/B.E. support.
 413         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 414
 415         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 416         (rs6000/powerpc-cell64l-expedite): Likewise
 417         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 418         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 419         rs6000/powerpc-cell64l.xml.
 420         * features/rs6000/powerpc-cell32l.xml: Remove.
 421         * features/rs6000/powerpc-cell64l.xml: Likewise.
 422         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 423         * features/rs6000/powerpc-cell64l.c: Likewise.
 424         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 425         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 426         * regformats/reg-spu.dat: Remove.
 427
 428         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 429         * corelow.c (struct spuid_list): Remove.
 430         (add_to_spuid_list): Remove.
 431         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 432         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 433         (remote_protocol_features): Remove associated entries.
 434         (_initialize_remote): No longer initialize them.
 435         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 436         * linux-nat.c (SPUFS_MAGIC): Remove.
 437         (linux_proc_xfer_spu): Remove.
 438         (spu_enumerate_spu_ids): Remove.
 439         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 440         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 441         (linux_make_corefile_notes): No longer call it.
 442
 443         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 444         (cooked_write_test): Likewise.
 445
 446 2019-09-20  Tom Tromey  <tom@tromey.com>
 447
 448         * NEWS: Mention case-sensitivity of TUI commands.
 449         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 450         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 451         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 452
 453 2019-09-20  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-source.c (tui_source_window::set_contents): Use
 456         make_unique_xstrdup.
 457         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 458         make_unique_xstrdup.
 459
 460 2019-09-20  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-data.c: Remove separator comments.
 463         * tui/tui-layout.c: Remove separator comments.
 464         * tui/tui-win.c: Remove separator comments.
 465         * tui/tui-wingeneral.c: Remove separator comments.
 466
 467 2019-09-20  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui.h (strcat_to_buf): Don't declare.
 470         * tui/tui.c (strcat_to_buf): Remove.
 471
 472 2019-09-20  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 475         from "fullname".
 476         * tui/tui-source.c (tui_source_window::set_contents)
 477         (tui_source_window::location_matches_p)
 478         (tui_source_window::maybe_update): Update.
 479
 480 2019-09-20  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 483         Update.
 484         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 485         prefix.
 486         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 487         (tui_data_window::line_from_reg_element_no)
 488         (tui_data_window::first_reg_element_no_inline)
 489         (tui_data_window::show_registers)
 490         (tui_data_window::show_register_group)
 491         (tui_data_window::display_registers_from)
 492         (tui_data_window::display_registers_from_line)
 493         (tui_data_window::first_data_item_displayed)
 494         (tui_data_window::delete_data_content_windows)
 495         (tui_data_window::erase_data_content)
 496         (tui_data_window::do_scroll_vertical)
 497         (tui_data_window::refresh_window)
 498         (tui_data_window::check_register_values): Update.
 499
 500 2019-09-20  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 503         (struct tui_locator_window) <full_name, proc_name>: Now
 504         std::string.
 505         * tui/tui-stack.c (tui_locator_window::make_status_line)
 506         (tui_locator_window::set_locator_fullname)
 507         (tui_locator_window::set_locator_info): Update.
 508         * tui/tui-source.c (tui_source_window::set_contents)
 509         (tui_source_window::showing_source_p): Update.
 510
 511 2019-09-20  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 514         Don't call tui_locator_win_info_ptr.
 515
 516 2019-09-20  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 519
 520 2019-09-20  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 523         height for locator.
 524         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 525         * tui/tui-layout.c (show_source_disasm_command, show_data)
 526         (show_source_or_disasm_and_command): Use 1 as height for locator.
 527
 528 2019-09-20  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui.c (tui_enable): Update.
 531         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 532         Update.
 533         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 534         Update.
 535         * tui/tui-data.c (win_resized): Now bool.
 536         (tui_win_resized): Return bool.
 537         (tui_set_win_resized_to): Accept a bool.
 538
 539 2019-09-20  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 542         Change type of "refresh_values_only".
 543         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 544         type of "refresh_values_only".
 545
 546 2019-09-20  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 549         std::string.
 550         (tui_disassemble): Add "pos" parameter.
 551         (tui_disasm_window::set_contents): Simplify.
 552
 553 2019-09-20  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-winsource.h (struct tui_source_window_base)
 556         <show_source_content>: Now private.
 557         * tui/tui-winsource.c
 558         (tui_source_window_base::show_source_content): Don't handle empty
 559         content case.
 560
 561 2019-09-20  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-layout.c (show_source_disasm_command)
 564         (show_source_or_disasm_and_command): Don't call
 565         show_source_content.
 566
 567 2019-09-20  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 570         Declare.
 571         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 572         from tui_make_status_line.
 573         (tui_locator_window::rerender): Update.
 574
 575 2019-09-20  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 578         (tui_locator_window::rerender): Update.
 579
 580 2019-09-20  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-winsource.h (struct tui_source_window_base)
 583         <~tui_source_window_base>: Don't declare.
 584         <fullname>: Remove.
 585         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 586         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 587         member.
 588         * tui/tui-source.c (tui_source_window::set_contents): Update.
 589         (tui_source_window::location_matches_p)
 590         (tui_source_window::maybe_update): Update.
 591
 592 2019-09-20  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.h (~tui_source_element): Remove.
 595         (tui_source_element): Update.
 596         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 597         * tui/tui-winsource.c (tui_show_source_line): Update.
 598         * tui/tui-source.c (tui_source_window::set_contents): Update.
 599         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 600
 601 2019-09-20  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 604         declare.
 605         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 606         tui_clear_source_windows_detail.
 607         * tui/tui-winsource.h (struct tui_source_window_base)
 608         <clear_detail>: Don't declare.
 609         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 610         Remove.
 611         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 612
 613 2019-09-20  Tom Tromey  <tromey@adacore.com>
 614
 615         PR ada/24919:
 616         * block.c (contained_in): Fix final return value.
 617
 618 2019-09-20  Alan Modra  <amodra@gmail.com>
 619
 620         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 621         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 622         (read_indirect_string_from_dwz): Use bfd accessor.
 623         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 624         * machoread.c (macho_symfile_read_all_oso): Likewise.
 625         * solib.c (solib_bfd_open): Likewise.
 626
 627 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 628
 629         * eval.c: Move declaration of overload_resolution to...
 630         * value.h: ...here.
 631
 632 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 633
 634         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 635         * arm-linux-tdep.c: Likewise.
 636         * arm-nbsd-nat.c: Likewise.
 637         * arm-tdep.h: Declare arm_apcs_32.
 638         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 639
 640 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 641
 642         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 643         * dwarf2read.h: Declare dwarf_always_disassemble.
 644
 645 2019-09-19  Tom de Vries  <tdevries@suse.de>
 646
 647         PR gdb/25009
 648         * source-cache.c (source_cache::ensure): Catch exception thrown during
 649         construction of the highlighter.
 650
 651 2019-09-18  Alan Modra  <amodra@gmail.com>
 652
 653         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 654         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 655         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 656         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 657         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 658         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 659         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 660         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 661         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 662         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 663         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 664         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 665         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 666         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 667         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 668         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 669         * mi/mi-interp.c: Update throughout for bfd section macro and
 670         function changes.
 671         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 672         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 673
 674 2019-09-18  Tom Tromey  <tom@tromey.com>
 675
 676         * NEWS: Add entry.
 677         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 678         call rl_initialize.
 679         (tui_enable): Do not call rl_initialize.
 680
 681 2019-09-18  Christian Groessler  <chris@groessler.org>
 682
 683         * alpha-linux-nat.c: Include gdbarch.h.
 684
 685 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 686
 687         * ui-file.c: Include cli/cli-style.h.
 688         (term_cli_styling): Remove cli_styling declaration.
 689
 690 2019-09-18  Alan Modra  <amodra@gmail.com>
 691
 692         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 693         to bfd_asymbol_section.
 694
 695 2019-09-18  Alan Modra  <amodra@gmail.com>
 696
 697         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 698         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 699         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 700
 701 2019-09-18  Alan Modra  <amodra@gmail.com>
 702
 703         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 704         * spu-linux-nat.c (spu_bfd_open): Likewise.
 705
 706 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 707
 708         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 709         to bool to match definition in dwarf2read.c.
 710
 711 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 712
 713         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 714         (print_signatures): Likewise.
 715         (trust_pad_over_xvs): Likewise.
 716         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 717         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 718         * arm-linux-nat.c (arm_apcs_32): Likewise.
 719         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 720         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 721         * arm-tdep.c (arm_debug): Likewise.
 722         (arm_apcs_32): Likewise.
 723         * auto-load.c (debug_auto_load): Likewise.
 724         (auto_load_gdb_scripts): Likewise.
 725         (global_auto_load): Likewise.
 726         (auto_load_local_gdbinit): Likewise.
 727         (auto_load_local_gdbinit_loaded): Likewise.
 728         * auto-load.h (global_auto_load): Likewise.
 729         (auto_load_local_gdbinit): Likewise.
 730         (auto_load_local_gdbinit_loaded): Likewise.
 731         * breakpoint.c (disconnected_dprintf): Likewise.
 732         (breakpoint_proceeded): Likewise.
 733         (automatic_hardware_breakpoints): Likewise.
 734         (always_inserted_mode): Likewise.
 735         (target_exact_watchpoints): Likewise.
 736         (_initialize_breakpoint): Update.
 737         * breakpoint.h (target_exact_watchpoints): Change to bool.
 738         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 739         * cli/cli-cmds.c (trace_commands): Likewise.
 740         * cli/cli-cmds.h (trace_commands): Likewise.
 741         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 742         to bool*.
 743         * cli/cli-logging.c (logging_overwrite): Change to bool.
 744         (logging_redirect): Likewise.
 745         (debug_redirect): Likewise.
 746         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 747         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 748         to bool.
 749         <boolean_option_def>: Update.
 750         (struct flag_option_def): Change default type of Context to bool
 751         from int.
 752         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 753         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 754         (get_setshow_command_value_string): Likewise.
 755         * cli/cli-style.c (cli_styling): Change to bool.
 756         (source_styling): Likewise.
 757         * cli/cli-style.h (source_styling): Likewise.
 758         (cli_styling): Likewise.
 759         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 760         to bool.
 761         * command.h (var_types): Update comment.
 762         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 763         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 764         bool.
 765         (debug_compile_cplus_scopes): Likewise.
 766         * compile/compile-internal.h (compile_debug): Likewise.
 767         * compile/compile.c (compile_debug): Likewise.
 768         (struct compile_options) <raw>: Likewise.
 769         * cp-support.c (catch_demangler_crashes): Likewise.
 770         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 771         (usr_cmd_cris_dwarf2_cfi): Likewise.
 772         * csky-tdep.c (csky_debug): Likewise.
 773         * darwin-nat.c (enable_mach_exceptions): Likewise.
 774         * dcache.c (dcache_enabled_p): Likewise.
 775         * defs.h (info_verbose): Likewise.
 776         * demangle.c (demangle): Likewise.
 777         (asm_demangle): Likewise.
 778         * dwarf-index-cache.c (debug_index_cache): Likewise.
 779         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 780         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 781         * dwarf2read.c (check_physname): Likewise.
 782         (use_deprecated_index_sections): Likewise.
 783         (dwarf_always_disassemble): Likewise.
 784         * eval.c (overload_resolution): Likewise.
 785         * event-top.c (set_editing_cmd_var): Likewise.
 786         (exec_done_display_p): Likewise.
 787         * event-top.h (set_editing_cmd_var): Likewise.
 788         (exec_done_display_p): Likewise.
 789         * exec.c (write_files): Likewise.
 790         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 791         (debug_fbsd_nat): Likewise.
 792         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 793         Likewise.
 794         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 795         <backtrace_past_entry> Likewise.
 796         * gdb-demangle.h (demangle): Likewise.
 797         (asm_demangle): Likewise.
 798         * gdb_bfd.c (bfd_sharing): Likewise.
 799         * gdbcore.h (write_files): Likewise.
 800         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 801         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 802         * gdbthread.h (print_thread_events): Likewise.
 803         * gdbtypes.c (opaque_type_resolution): Likewise.
 804         (strict_type_checking): Likewise.
 805         * gnu-nat.c (gnu_debug_flag): Likewise.
 806         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 807         * guile/scm-param.c (pascm_variable): Add boolval.
 808         (add_setshow_generic): Update.
 809         (pascm_param_value): Update.
 810         (pascm_set_param_value_x): Update.
 811         * hppa-tdep.c (hppa_debug): Change to bool..
 812         * infcall.c (may_call_functions_p): Likewise.
 813         (coerce_float_to_double_p): Likewise.
 814         (unwind_on_signal_p): Likewise.
 815         (unwind_on_terminating_exception_p): Likewise.
 816         * infcmd.c (startup_with_shell): Likewise.
 817         * inferior.c (print_inferior_events): Likewise.
 818         * inferior.h (startup_with_shell): Likewise.
 819         (print_inferior_events): Likewise.
 820         * infrun.c (step_stop_if_no_debug): Likewise.
 821         (detach_fork): Likewise.
 822         (debug_displaced): Likewise.
 823         (disable_randomization): Likewise.
 824         (non_stop): Likewise.
 825         (non_stop_1): Likewise.
 826         (observer_mode): Likewise.
 827         (observer_mode_1): Likewise.
 828         (set_observer_mode): Update.
 829         (sched_multi): Change to bool.
 830         * infrun.h (debug_displaced): Likewise.
 831         (sched_multi): Likewise.
 832         (step_stop_if_no_debug): Likewise.
 833         (non_stop): Likewise.
 834         (disable_randomization): Likewise.
 835         * linux-tdep.c (use_coredump_filter): Likewise.
 836         (dump_excluded_mappings): Likewise.
 837         * linux-thread-db.c (auto_load_thread_db): Likewise.
 838         (check_thread_db_on_load): Likewise.
 839         * main.c (captured_main_1): Update.
 840         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 841         xx2_opt, boolean_opt>: Change to bool.
 842         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 843         * maint.c (maintenance_profile_p): Likewise.
 844         (per_command_time): Likewise.
 845         (per_command_space): Likewise.
 846         (per_command_symtab): Likewise.
 847         * memattr.c (inaccessible_by_default): Likewise.
 848         * mi/mi-main.c (mi_async): Likewise.
 849         (mi_async_1): Likewise.
 850         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 851         * nat/fork-inferior.h (startup_with_shell): Likewise.
 852         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 853         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 854         * nios2-tdep.c (nios2_debug): Likewise.
 855         * or1k-tdep.c (or1k_debug): Likewise.
 856         * parse.c (parser_debug): Likewise.
 857         * parser-defs.h (parser_debug): Likewise.
 858         * printcmd.c (print_symbol_filename): Likewise.
 859         * proc-api.c (procfs_trace): Likewise.
 860         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 861         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 862         (set_parameter_value): Update.
 863         (add_setshow_generic): Update.
 864         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 865         to bool*.
 866         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 867         int*.
 868         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 869         * record-btrace.c (record_btrace_target::store_registers): Update.
 870         * record-full.c (record_full_memory_query): Change to bool.
 871         (record_full_stop_at_limit): Likewise.
 872         * record-full.h (record_full_memory_query): Likewise.
 873         * remote-notif.c (notif_debug): Likewise.
 874         * remote-notif.h (notif_debug): Likewise.
 875         * remote.c (use_range_stepping): Likewise.
 876         (interrupt_on_connect): Likewise.
 877         (remote_break): Likewise.
 878         * ser-tcp.c (tcp_auto_retry): Likewise.
 879         * ser-unix.c (serial_hwflow): Likewise.
 880         * skip.c (debug_skip): Likewise.
 881         * solib-aix.c (solib_aix_debug): Likewise.
 882         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 883         (spu_auto_flush_cache_p): Likewise.
 884         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 885         Likewise.
 886         (struct info_print_options) <quiet>: Likewise.
 887         * symfile-debug.c (debug_symfile): Likewise.
 888         * symfile.c (auto_solib_add): Likewise.
 889         (separate_debug_file_debug): Likewise.
 890         * symfile.h (auto_solib_add): Likewise.
 891         (separate_debug_file_debug): Likewise.
 892         * symtab.c (basenames_may_differ): Likewise.
 893         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 894         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 895         (struct info_types_options) <quiet>: Likewise.
 896         * symtab.h (demangle): Likewise.
 897         (basenames_may_differ): Likewise.
 898         * target-dcache.c (stack_cache_enabled_1): Likewise.
 899         (code_cache_enabled_1): Likewise.
 900         * target.c (trust_readonly): Likewise.
 901         (may_write_registers): Likewise.
 902         (may_write_memory): Likewise.
 903         (may_insert_breakpoints): Likewise.
 904         (may_insert_tracepoints): Likewise.
 905         (may_insert_fast_tracepoints): Likewise.
 906         (may_stop): Likewise.
 907         (auto_connect_native_target): Likewise.
 908         (target_stop_and_wait): Update.
 909         (target_async_permitted): Change to bool.
 910         (target_async_permitted_1): Likewise.
 911         (may_write_registers_1): Likewise.
 912         (may_write_memory_1): Likewise.
 913         (may_insert_breakpoints_1): Likewise.
 914         (may_insert_tracepoints_1): Likewise.
 915         (may_insert_fast_tracepoints_1): Likewise.
 916         (may_stop_1): Likewise.
 917         * target.h (target_async_permitted): Likewise.
 918         (may_write_registers): Likewise.
 919         (may_write_memory): Likewise.
 920         (may_insert_breakpoints): Likewise.
 921         (may_insert_tracepoints): Likewise.
 922         (may_insert_fast_tracepoints): Likewise.
 923         (may_stop): Likewise.
 924         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 925         (make_thread_apply_all_options_def_group): Change argument from int*
 926         to bool*.
 927         (thread_apply_all_command): Update.
 928         (print_thread_events): Change to bool.
 929         * top.c (confirm): Likewise.
 930         (command_editing_p): Likewise.
 931         (history_expansion_p): Likewise.
 932         (write_history_p): Likewise.
 933         (info_verbose): Likewise.
 934         * top.h (confirm): Likewise.
 935         (history_expansion_p): Likewise.
 936         * tracepoint.c (disconnected_tracing): Likewise.
 937         (circular_trace_buffer): Likewise.
 938         * typeprint.c (print_methods): Likewise.
 939         (print_typedefs): Likewise.
 940         * utils.c (debug_timestamp): Likewise.
 941         (sevenbit_strings): Likewise.
 942         (pagination_enabled): Likewise.
 943         * utils.h (sevenbit_strings): Likewise.
 944         (pagination_enabled): Likewise.
 945         * valops.c (overload_resolution): Likewise.
 946         * valprint.h (struct value_print_options) <prettyformat_arrays,
 947         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 948         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 949         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 950         Likewise.
 951         * windows-nat.c (new_console): Likewise.
 952         (cygwin_exceptions): Likewise.
 953         (new_group): Likewise.
 954         (debug_exec): Likewise.
 955         (debug_events): Likewise.
 956         (debug_memory): Likewise.
 957         (debug_exceptions): Likewise.
 958         (useshell): Likewise.
 959         * windows-tdep.c (maint_display_all_tib): Likewise.
 960         * xml-support.c (debug_xml): Likewise.
 961
 962 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 963
 964         * source.c (prepare_path_for_appending): New function.
 965         (openp): Make use of new function.
 966         (find_and_open_source): Search for the compilation directory and
 967         source file as a relative path beneath the directory search path.
 968
 969 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 970
 971         * source-cache.c (source_cache::get_line_charpos): Catch
 972         exceptions and return false, this matches the behaviour documented
 973         in the header file.
 974
 975 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 976
 977         * ada-tasks.c (info_task): Remove quoting of the task's name.
 978
 979 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 980
 981         * symfile.c (auto_solib_add): Replace comment with a reference
 982         to the header file.
 983
 984 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 985
 986         * NEWS: Mention that gdb can now be compiled with Python 3
 987         on Windows.
 988
 989 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * maint.c (maint_print_section_data::maint_print_section_data):
 992         Force use of 'float log10 (float)' by casting the argument to
 993         float.
 994
 995 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * maint.c: Add 'cmath' include.
 998         (struct maint_print_section_data): New structure.
 999         (print_section_index): New function.
1000         (print_bfd_section_info): Add header comment, small whitespace
1001         cleanup, and update to call new print_section_index function.
1002         (print_objfile_section_info): Likewise.
1003         (maint_obj_section_from_bfd_section): New function.
1004         (print_bfd_section_info_maybe_relocated): New function.
1005         (maintenance_info_sections): Add header comment, always use
1006         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1007
1008 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1011         inner scope, add check that the objfile has psymtabs before
1012         checking psymtabs_addrmap.
1013         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1014
1015 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1016
1017         * NEWS: Announce that Ada task names are now shown at more places,
1018         and between quotes (except in info task output).
1019         * gdb/ada-tasks.c (task_to_str): New function.
1020         (display_current_task_id): Call task_to_str.
1021         (task_command_1): Likewise.
1022         (print_ada_task_info): In non-mi mode, Properly align headers and data
1023         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1024
1025 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1026
1027         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1028         prstatus.pr_lwp.pr_info instead of making it up.
1029
1030 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1031
1032         * auto-load.c (auto_load_expand_dir_vars): Update.
1033         * defs.h (gdb_datadir): Change to std::string.
1034         (python_libdir): Likewise.
1035         (relocate_gdb_directory): Change return type to std::string.
1036         * guile/guile.c (gdbscm_data_directory): Update.
1037         (initialize_scheme_side): Update.
1038         * jit.c (jit_reader_dir): Change to std::string.
1039         (jit_reader_load_command): Update.
1040         * main.c (gdb_datadir): Change to std::string.
1041         (python_libdir): Likewise.
1042         (set_gdb_data_directory): Update.
1043         (relocate_path): Change to return std::string.
1044         (relocate_gdb_directory): Change to return std::string.
1045         (relocate_gdbinit_path_maybe_in_datadir): Update.
1046         (captured_main_1): Update.
1047         * python/python.c (do_start_initialization): Update.
1048         * top.c (show_gdb_datadir): Update.
1049         * xml-syscall.c (xml_init_syscalls_info): Update.
1050         (init_syscalls_info): Update.
1051
1052 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1053
1054         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1055         out of get_init_files.
1056         (get_init_files): Update.
1057
1058 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1059
1060         * main.c (get_init_files): Change to use std::string.
1061         (captured_main_1): Update.
1062         (print_gdb_help): Update.
1063
1064 2019-09-11  Ali Tamur  <tamur@google.com>
1065
1066         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1067         implementation.
1068
1069 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1070
1071         * dbxread.c (read_dbx_symtab): Update.
1072         * dwarf2read.c (load_partial_dies): Update.
1073         * mdebugread.c (parse_partial_symbols): Update.
1074         (handle_psymbol_enumerators): Update.
1075         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1076         * psymtab.c (add_psymbol_to_bcache): Likewise.
1077         (add_psymbol_to_list): Likewise.
1078         * symtab.c (symbol_set_names): Likewise.
1079         * symtab.h (symbol_set_names): Likewise.
1080         * xcoffread.c (scan_xcoff_symtab): Update.
1081
1082 2019-09-11  Tom Tromey  <tom@tromey.com>
1083
1084         * symfile-mem.c (symbol_file_add_from_memory): Use
1085         bfd_set_filename.
1086         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1087         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1088
1089 2019-09-10  Tom Tromey  <tromey@adacore.com>
1090
1091         * dwarf-index-write.c (write_psymbols): Extend error message.
1092         (debug_names::insert): Add Ada code.
1093         (debug_names::write_psymbols): Remove Ada check.
1094         (debug_names) <m_string_obstack>: New member.
1095         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1096         (gdb_index_symbol_name_matcher::matches): Remove.
1097         (mapped_index_base::find_name_components_bounds): Add "lang"
1098         parameter.
1099         (mapped_index_base::build_name_components): Also split names
1100         according to Ada syntax.
1101         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1102         type of "match_callback".
1103         (check_match, check_find_bounds_finds)
1104         (dw2_expand_symtabs_matching): Update.
1105         (dw2_debug_names_iterator): Add new constructor.
1106         (dw2_debug_names_map_matching_symbols): New function.
1107         (dw2_debug_names_expand_symtabs_matching): Update.
1108         (dwarf2_debug_names_functions): Use
1109         dw2_debug_names_map_matching_symbols.
1110
1111 2019-09-10  Tom Tromey  <tromey@adacore.com>
1112
1113         * dwarf2read.c (dw2_get_file_names_reader): Add the
1114         CU's file name to the results.
1115
1116 2019-09-10  Tom Tromey  <tromey@adacore.com>
1117
1118         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1119         map_matching_symbols.  Update.
1120         * dwarf2read.c (dw2_map_matching_symbols): Update.
1121         * psymtab.c (match_partial_symbol): Change type; update.
1122         (psym_map_matching_symbols): Likewise.
1123         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1124         type; update.
1125         * symfile.h (struct quick_symbol_functions)
1126         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1127         Remove "match".
1128
1129 2019-09-10  Tom Tromey  <tromey@adacore.com>
1130
1131         * psymtab.c (map_block): Remove.
1132         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1133         * symtab.c (iterate_over_symbols_terminated): New function.
1134         * symtab.c (iterate_over_symbols_terminated): Declare.
1135
1136 2019-09-10  Tom Tromey  <tromey@adacore.com>
1137
1138         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1139         * language.h (struct language_defn) <la_iterate_over_symbols>:
1140         Return bool.
1141         * symtab.c (iterate_over_symbols): Return bool.
1142         * symtab.h (iterate_over_symbols): Return bool.
1143
1144 2019-09-10  Tom Tromey  <tromey@adacore.com>
1145
1146         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1147         (add_nonlocal_symbols): Update.
1148         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1149         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1150         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1151         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1152         Change type of "callback".  Remove "data".
1153
1154
1155 2019-09-09  Ali Tamur  <tamur@google.com>
1156
1157         * dwarf2read.c (comp_unit_head): Update comment.
1158         (dwarf2_dwo_name): New function declaration.
1159         (dwarf_unit_type_name): New function declaration.
1160         (read_comp_unit_head): Add support for new compilation units,
1161         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1162         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1163         (currently named as "signature") in their header. Also clarify error
1164         messages.
1165         (lookup_dwo_id): New function. Returns the dwo id of the given
1166         compile unit.
1167         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1168         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1169         functions.
1170         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1171         (dwarf2_dwo_name): Get the dwo name if present.
1172         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1173         purposes.
1174
1175 2019-09-09  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1178
1179 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * python/python.c (do_start_initialization): Make progname_copy static,
1182         to avoid a leak report.
1183
1184 2019-09-08  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1187
1188 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1189
1190         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1191         Change type to gdb::optional<block_enum>.
1192         (dw2_symtab_iter_init): Change block_index parameter type
1193         to gdb::optional<block_enum>.
1194         (dw2_lookup_symbol): Change block_index parameter
1195         type to block_enum.c
1196         (dw2_debug_names_lookup_symbol): Likewise.
1197         * psymtab.c (psym_lookup_symbol): Likewise.
1198         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1199         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1200         Likewise.
1201
1202 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1203
1204         * defs.h (relocate_gdb_directory): Change int to bool in
1205         signature and rename flag to relocatable.
1206         * main.c (relocate_path): Likewise.
1207         (relocate_gdb_directory): Likewise.
1208
1209 2019-09-06  Alan Modra  <amodra@gmail.com>
1210
1211         * coffread.c (coff_symfile_read): Constify filename variable.
1212         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1213         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1214         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1215         * solib.c (reload_shared_libraries_1): Likewise.
1216         * symfile.c (reread_symbols): Likewise.
1217         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1218         * solib-darwin.c (darwin_bfd_open): Likewise.
1219         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1220
1221 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1224         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1225
1226 2019-09-03  Tom Tromey  <tromey@adacore.com>
1227
1228         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1229         types.
1230         (has_negatives): Unbias a range type bound.
1231         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1232         * gdbtypes.c (operator==): Handle new field.
1233         (create_range_type): Add "bias" parameter.
1234         (create_static_range_type, resolve_dynamic_range): Update.
1235         * gdbtypes.h (struct range_bounds) <bias>: New member.
1236         (create_range_type): Add bias parameter.
1237         * printcmd.c (print_scalar_formatted): Unbias range types.
1238         * value.c (unpack_long): Unbias range types.
1239         (pack_long): Bias range types.
1240
1241 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1242
1243         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1244         probe arguments.
1245
1246 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1247
1248         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1249         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1250         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1251         (compile_probe_arg): Likewise.
1252         * probe.h (get_argument_count): Likewise.
1253         * solib-svr4.c (solib_event_probe_action): Likewise.
1254         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1255
1256 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1257
1258         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1259         code to here...
1260         (svr4_create_solib_event_breakpoints): ...from here.
1261
1262 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1263
1264         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1265         suffix from warning message.
1266
1267 2019-08-30  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-winsource.h (struct tui_source_window_base)
1270         <refresh_all>: Don't declare.
1271         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1272         Remove.
1273         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1274         tui_show_locator_content.
1275         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1276         declare.
1277         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1278         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1279         declare.
1280
1281 2019-08-30  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1284
1285 2019-08-30  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1288         Remove unnecessary forward declarations.
1289
1290 2019-08-30  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1293         rerender.
1294         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1295         tui_show_locator_content.
1296
1297 2019-08-30  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1300         (tui_locator_window::rerender): Rewrite using body of previous
1301         tui_show_locator_content.
1302
1303 2019-08-30  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1306         set_locator_fullname>: New methods.
1307         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1308         Rename from tui_set_locator_fullname.
1309         (tui_locator_window::set_locator_info): Rename from
1310         tui_set_locator_info.  Return bool.
1311         (tui_update_locator_fullname, tui_show_frame_info): Update.
1312
1313 2019-08-30  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1316
1317 2019-08-30  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1320         call touchwin.
1321
1322 2019-08-30  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-wingeneral.c (box_win): Assume win_info and
1325         win_info->handle cannot be NULL.
1326
1327 2019-08-30  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1330         refresh_window>: Declare.
1331         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1332         resize.
1333         (tui_data_item_window::rerender): Rename from
1334         tui_display_register.
1335         (tui_data_item_window::refresh_window): New method.
1336         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1337         no-op.
1338
1339 2019-08-30  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1342         regs_column_count, current_group>: Move later.  Now private.
1343         <get_current_group>: New method.
1344         * tui/tui-regs.c (tui_reg_command): Update.
1345         * tui/tui-layout.c (tui_set_layout): Update.
1346
1347 2019-08-30  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1350         (tui_data_window::rerender): Don't call
1351         check_and_display_highlight_if_needed.
1352         (tui_data_window::refresh_all): Remove call to
1353         erase_data_content.
1354
1355 2019-08-30  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1358         (tui_data_window::display_registers_from)
1359         (tui_data_window::display_reg_element_at_line)
1360         (tui_data_window::display_registers_from_line): Remove checks of
1361         "empty".
1362
1363 2019-08-30  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1366         Don't declare.
1367         * tui/tui-regs.c (tui_data_window::show_registers): Call
1368         rerender.
1369         (tui_data_window::rerender): Rename from display_all_data.
1370         (tui_data_window::rerender): Remove old implementation.
1371
1372 2019-08-30  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1375         text.
1376         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1377
1378 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1379             Sergio Durigan Junior  <sergiodj@redhat.com>
1380
1381         PR win32/24284
1382         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1383
1384 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1387         when searching for types.
1388
1389 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * f-lang.c (f_language_defn): Use f_print_typedef.
1392         * f-lang.h (f_print_typedef): Declare.
1393         * f-typeprint.c (f_print_typedef): Define.
1394
1395 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1398
1399 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * cli/cli-utils.c (info_print_options_defs): Delete.
1402         (make_info_print_options_def_group): Delete.
1403         (extract_info_print_options): Delete.
1404         (info_print_command_completer): Delete.
1405         (info_print_args_help): Add extra parameter, and optionally
1406         include text about -n flag.
1407         * cli/cli-utils.h (struct info_print_options): Delete.
1408         (extract_info_print_options): Delete declaration.
1409         (info_print_command_completer): Delete declaration.
1410         (info_print_args_help): Add extra parameter, extend header
1411         comment.
1412         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1413         search_symbols.
1414         * stack.c (struct info_print_options): New type.
1415         (info_print_options_defs): New file scoped variable.
1416         (make_info_print_options_def_group): New static function.
1417         (info_print_command_completer): New static function.
1418         (info_locals_command): Update to use new local functions.
1419         (info_args_command): Likewise.
1420         (_initialize_stack): Add extra parameter to calls to
1421         info_print_args_help.
1422         * symtab.c (search_symbols): Add extra parameter, use this to
1423         possibly excluse non-debug symbols.
1424         (symtab_symbol_info): Add extra parameter, which is passed on to
1425         search_symbols.
1426         (struct info_print_options): New type.
1427         (info_print_options_defs): New file scoped variable.
1428         (make_info_print_options_def_group): New static function.
1429         (info_print_command_completer): New static function.
1430         (info_variables_command): Update to use local functions, and pass
1431         extra parameter through to symtab_symbol_info.
1432         (info_functions_command): Likewise.
1433         (info_types_command): Pass additional argument through to
1434         symtab_symbol_info.
1435         (rbreak_command): Pass extra argument to search_symbols.
1436         (_initialize_symtab): Add extra arguments for calls to
1437         info_print_args_help, and update help text for 'info variables',
1438         'whereis', and 'info functions' commands.
1439         * symtab.h (search_symbols): Add extra argument to declaration.
1440         * NEWS: Mention new flags.
1441
1442 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1443
1444         * symtab.c (lookup_static_symbol): Call the new function (and move
1445         it down to be next to lookup_global_symbol).
1446         (struct global_sym_lookup_data): Add block_enum member and rename to...
1447         (struct global_or_static_sym_lookup_data): ...this.
1448         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1449         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1450         (lookup_symbol_global_or_static_iterator_cb): ...this.
1451         (lookup_global_or_static_symbol): New function.
1452         (lookup_global_symbol): Call new function.
1453
1454 2019-08-26  Tom de Vries  <tdevries@suse.de>
1455
1456         PR c++/24852
1457         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1458         when pc_probe.prob == NULL.
1459
1460 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1461
1462         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1463         variable symbol_linkage to symbol_linkage_.
1464
1465 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1466
1467         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1468         represent whether the symbol is static, dynamic, or we don't
1469         know.
1470
1471 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1472
1473         * gdb/rx-tdep.c (rx_register_names): New.
1474         (rx_register_name): Delete.
1475         (rx_psw_type): Delete.
1476         (rx_fpsw_type): Delete.
1477         (rx_register_type): Delete.
1478         (rx_gdbarch_init): Convert target-descriptions.
1479         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1480         * gdb/features/Makefile: Add rx.xml.
1481         * gdb/features/rx.xml: New.
1482         * gdb/features/rx.c: Generated.
1483         * gdb/NEWS: Mention target description support.
1484
1485 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1486
1487         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1488         *slot_ptr.
1489
1490 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1491
1492         * configure.ac: Don't check for 'dlfcn.h' (moved to
1493         gdbsupport/common.m4).
1494         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1495         'gdbsupport/'.
1496         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1497         * compile/compile-c-support.c: Include
1498         'gdbsupport/gdb-dlfcn.h'.
1499         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1500         * gdb-dlfcn.c: Move to...
1501         * gdbsupport/gdb-dlfcn.c: ... here.
1502         * gdb-dlfcn.h: Move to...
1503         * gdbsupport/gdb-dlfcn.h: ... here.
1504
1505 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1506
1507         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1508         the offset field signed.
1509
1510 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1511
1512         * python/lib/gdb/__init__.py (_execute_file): New function.
1513         * python/python.c (python_run_simple_file): Call gdb._execute_file
1514         on Windows.
1515
1516 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1519         all uses as this was never set to anything but a zero value.
1520
1521 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1522
1523         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1524
1525 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1526
1527         * tui/tui-data.h (tui_gen_win_info): Add an =default
1528         move constructor, required by some GCC versions.
1529
1530 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1531
1532         * go32-nat.c (go32_sysinfo): Add hygon_p.
1533
1534 2019-08-20  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1537         line_from_reg_element_no, first_reg_element_no_inline,
1538         display_all_data, delete_data_content_windows,
1539         erase_data_content>: Now private.
1540
1541 2019-08-20  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1544         (tui_unhighlight_win, tui_highlight_win)
1545         (tui_win_info::make_window): Update.
1546         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1547
1548 2019-08-20  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1551         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1552         (MAX_PID_WIDTH): Move to tui-stack.c.
1553         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1554         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1555         (MAX_PID_WIDTH): Move from tui-data.h.
1556
1557 2019-08-20  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1560         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1561         (box_win): Update.
1562         (tui_gen_win_info::make_window): Rename from tui_make_window.
1563         (tui_win_info::make_window): New method.
1564         (tui_gen_win_info::make_visible): Update.
1565         * tui/tui-source.c (tui_source_window::set_contents): Update.
1566         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1567         (tui_data_window::display_registers_from): Update.
1568         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1569         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1570         Declare.
1571         <can_box>: Remove.
1572         <title>: Remove.
1573         (struct tui_win_info) <make_window>: Declare.
1574         <can_box>: Now virtual.
1575         <title>: New member.
1576         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1577         * tui/tui-command.c (tui_cmd_window::resize): Update.
1578
1579 2019-08-20  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1582         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1583         (tui_data_window::check_register_values): Update.
1584
1585 2019-08-20  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-regs.h (struct tui_data_window): Use
1588         DISABLE_COPY_AND_ASSIGN.
1589         <regs_content>: Change type, removing unique_ptr.
1590         <tui_data_window>: Add move constructor.
1591         * tui/tui-regs.c (tui_data_window::show_registers)
1592         (tui_data_window::show_register_group)
1593         (tui_data_window::display_registers_from)
1594         (tui_data_window::display_registers_from)
1595         (tui_data_window::first_data_item_displayed)
1596         (tui_data_window::delete_data_content_windows)
1597         (tui_data_window::rerender, tui_data_window::refresh_window)
1598         (tui_data_window::check_register_values): Update.
1599
1600 2019-08-20  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1603         show_register_group>: Declare.
1604         (tui_show_register_group): Don't declare.
1605         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1606         tui_show_registers.
1607         (tui_data_window::show_register_group): Rename from
1608         tui_show_register_group.
1609         (tui_data_window::check_register_values, tui_reg_command):
1610         Update.
1611         * tui/tui-layout.c (tui_set_layout): Update.
1612
1613 2019-08-20  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1616         Declare.
1617         (tui_check_register_values): Don't declare.
1618         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1619         from tui_check_register_values.
1620         * tui/tui-hooks.c (tui_register_changed): Update.
1621
1622 2019-08-20  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-regs.c (tui_reg_layout): Move later.
1625         (tui_show_registers): Don't enable TUI mode or change layout.
1626
1627 2019-08-20  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-regs.h (struct tui_data_item_window)
1630         <~tui_data_item_window>: Remove.
1631         <content>: Now a unique_xmalloc_ptr.
1632         * tui/tui-regs.c (tui_register_format): Return a
1633         unique_xmalloc_ptr.
1634         (tui_get_register): Update.
1635         (~tui_data_item_window): Remove.
1636         (tui_data_window::display_registers_from, tui_display_register):
1637         Update.
1638         * tui/tui-io.h (tui_expand_tabs): Update.
1639         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1640         Remove "col" parameter.
1641
1642 2019-08-20  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1645         field.
1646         * tui/tui-regs.c (~tui_data_item_window): Update.
1647
1648 2019-08-20  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1651         earlier.
1652
1653 2019-08-20  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1656
1657 2019-08-20  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-source.h (struct tui_source_window): Update.
1660         * tui/tui-regs.c (tui_show_registers): Update.
1661         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1662         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1663         (NO_REGS_STRING): Remove defines.
1664
1665 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1666
1667         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1668         unnecessary thread walk if remote doesn't support the packet.
1669
1670 2019-08-19  Tom Tromey  <tromey@adacore.com>
1671
1672         * python/py-value.c (value_has_field): Fix indentation.
1673
1674 2019-08-19  Tom Tromey  <tromey@adacore.com>
1675
1676         * printcmd.c (do_one_display, info_display_command): Update.
1677         * block.h (contained_in): Return bool.  Add allow_nested
1678         parameter.
1679         * block.c (contained_in): Return bool.  Add allow_nested
1680         parameter.
1681
1682 2019-08-19  Tom Tromey  <tom@tromey.com>
1683
1684         * configure: Rebuild.
1685         * configure.ac: Disallow the combination of -static-libstdc++ and
1686         source highlight.
1687         * source-cache.c (get_language_name): Handle rust.
1688         (source_cache::get_source_lines): Ignore highlighting exceptions.
1689
1690 2019-08-16  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1693         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1694         (struct tui_source_window_base) <make_visible, refresh_window,
1695         resize>: Remove methods.
1696         <execution_info>: Remove field.
1697         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1698         (tui_show_source_line, tui_source_window_base)
1699         (~tui_source_window_base): Update.
1700         (tui_source_window_base::resize)
1701         (tui_source_window_base::make_visible)
1702         (tui_source_window_base::refresh_window): Remove.
1703         (tui_source_window_base::update_exec_info): Update.
1704         * tui/tui-source.c (tui_source_window::set_contents): Update.
1705         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1706
1707 2019-08-16  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1710         deprecated_query_hook.
1711
1712 2019-08-16  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1715         (tui_update_source_windows_with_line): Update.
1716         * tui/tui-source.h (struct tui_source_window)
1717         <show_symtab_source>: Declare.
1718         (tui_show_symtab_source): Don't declare.
1719         * tui/tui-source.c (tui_show_symtab_source): Rename from
1720         tui_show_symtab_source.
1721
1722 2019-08-16  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-winsource.h (struct tui_source_window_base)
1725         <set_contents>: Declare.
1726         * tui/tui-winsource.c
1727         (tui_source_window_base::update_source_window_as_is): Update.
1728         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1729         Declare.
1730         (tui_set_source_content): Don't declare.
1731         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1732         tui_set_source_content.
1733         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1734         Declare.
1735         (tui_set_disassem_content): Don't declare.
1736         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1737         tui_set_disassem_content.
1738
1739 2019-08-16  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-winsource.h (struct tui_source_window_base)
1742         <update_breakpoint_info>: Declare.
1743         (tui_update_breakpoint_info): Don't declare.
1744         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1745         (tui_update_all_breakpoint_info): Update.
1746         (tui_source_window_base::update_breakpoint_info): Rename from
1747         tui_update_breakpoint_info.
1748         (tui_source_window_base::update_exec_info): Update.
1749
1750 2019-08-16  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-winsource.h (struct tui_source_window_base)
1753         <update_source_window>: Declare.
1754         (tui_update_source_window): Don't declare.
1755         * tui/tui-winsource.c
1756         (tui_source_window_base::update_source_window): Rename from
1757         tui_update_source_window.
1758         (tui_source_window_base::rerender): Update.
1759         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1760         * tui/tui-disasm.c (tui_show_disassem)
1761         (tui_show_disassem_and_update_source)
1762         (tui_disasm_window::maybe_update): Update.
1763
1764 2019-08-16  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.h (struct tui_source_window_base)
1767         <update_source_window_as_is>: Declare.
1768         (tui_update_source_window_as_is): Don't declare.
1769         * tui/tui-winsource.c (tui_update_source_window): Update
1770         (tui_source_window_base::update_source_window_as_is): Rename from
1771         tui_update_source_window_as_is.
1772         (tui_source_window_base::refill): Update.
1773         * tui/tui-source.c (tui_show_symtab_source): Update.
1774         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1775         Update.
1776
1777 2019-08-16  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (tui_update_source_window)
1780         (tui_update_source_window_as_is): Remove "noerror" parameter.
1781         * tui/tui-winsource.c (tui_update_source_window)
1782         (tui_update_source_window_as_is): Remove "noerror" parameter.
1783         (tui_update_source_windows_with_addr)
1784         (tui_update_source_windows_with_line)
1785         (tui_source_window_base::rerender)
1786         (tui_source_window_base::refill): Update.
1787         * tui/tui-source.h (tui_set_source_content)
1788         (tui_show_symtab_source): Remove "noerror" parameter.
1789         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1790         parameter.
1791         (tui_show_symtab_source): Likewise.
1792         (tui_source_window::maybe_update): Update.
1793         * tui/tui-disasm.c (tui_show_disassem)
1794         (tui_show_disassem_and_update_source)
1795         (tui_disasm_window::do_scroll_vertical)
1796         (tui_disasm_window::maybe_update): Update.
1797
1798 2019-08-16  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui.c (tui_is_window_visible): Update.
1801         * tui/tui-wingeneral.c (tui_make_window)
1802         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1803         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1804         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1805         (tui_set_win_height_command, parse_scrolling_args): Update.
1806         * tui/tui-source.c (tui_source_window::style_changed): Update.
1807         * tui/tui-regs.c (tui_show_registers)
1808         (tui_data_window::first_data_item_displayed)
1809         (tui_data_window::delete_data_content_windows)
1810         (tui_check_register_values, tui_reg_command): Update.
1811         * tui/tui-disasm.c (tui_show_disassem): Update.
1812         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1813         method.
1814         <is_visible>: Remove field.
1815         * tui/tui-data.c (tui_next_win, tui_prev_win)
1816         (tui_delete_invisible_windows): Update.
1817
1818 2019-08-16  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-winsource.h (struct tui_source_window_base)
1821         <m_has_locator>: Remove.
1822         * tui/tui-layout.c (show_source_disasm_command, show_data)
1823         (show_source_or_disasm_and_command): Update.
1824
1825 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1826
1827         * NEWS (Other MI changes): New subsection.
1828         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1829         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1830         * arch-utils.c (default_get_pc_address_flags): New function.
1831         * arch-utils.h (default_get_pc_address_flags): New declaration.
1832         * gdbarch.sh: Add get_pc_address_flags.
1833         * gdbarch.c: Regenerate.
1834         * gdbarch.h: Likewise.
1835         * stack.c (print_pc): New function.
1836         (print_frame_info) (print_frame): Call print_pc.
1837
1838 2019-08-16  Tom de Vries  <tdevries@suse.de>
1839
1840         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1841         print_objfile_section_info.
1842
1843 2019-08-15  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1846         calling update_cmdwin_start_line.
1847         * tui/tui-winsource.h (struct tui_source_window_base)
1848         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1849         <rerender>: Declare.
1850         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1851         Call rerender.
1852         (tui_source_window_base::set_new_height): Remove.
1853         (tui_source_window_base::rerender): Rename from
1854         do_make_visible_with_new_height.
1855         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1856         resize method.
1857         (tui_win_info::make_invisible_and_set_new_height)
1858         (tui_win_info::make_visible_with_new_height): Remove.
1859         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1860         Declare.
1861         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1862         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1863         do_make_visible_with_new_height>: Don't declare.
1864         <rerender>: Declare.
1865         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1866         set_new_height.
1867         (tui_data_window::do_make_visible_with_new_height): Remove.
1868         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1869         call tui_show_locator_content.
1870         (tui_gen_win_info::resize): Call rerender.
1871         (show_source_or_disasm_and_command): Don't call
1872         tui_show_locator_content.
1873         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1874         method.
1875         (struct tui_win_info) <rerender>: Declare.
1876         <set_new_height, make_invisible_and_set_new_height,
1877         make_visible_with_new_height>: Don't declare.
1878         * tui/tui-data.c (tui_win_list::rerender): New method.
1879         * tui/tui-command.h (struct tui_cmd_window)
1880         <do_make_visible_with_new_height>: Don't declare.
1881         * tui/tui-command.c
1882         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1883
1884 2019-08-15  Tom Tromey  <tromey@adacore.com>
1885
1886         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1887         * ada-lang.c (ada_enum_name): Likewise.
1888
1889 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1890
1891         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1892         leading underscore.
1893         (GdbOutputErrorFile): Likewise.
1894         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1895         accordingly.
1896         (execute_unwinders): Rename to have a leading underscore.
1897         (auto_load_packages): Likewise.
1898         (global scope): Adjust call to auto_load_packages accordingly.
1899         (GdbSetPythonDirectory): Likewise.
1900         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1901         instead of execute_unwinders.
1902
1903 2019-08-15  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1906         (show_data): Don't change window visibility.
1907         (tui_gen_win_info::resize): Remove special case for command
1908         window.  Use wresize, when available.
1909         (show_source_or_disasm_and_command): Don't change window
1910         visibility.
1911         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1912         <make_visible>: New method.
1913         * tui/tui-command.c (tui_cmd_window::resize): New method.
1914
1915 2019-08-15  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1918         (struct tui_source_windows): New.
1919         * tui/tui-winsource.c (tui_display_main): Update.
1920         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1921         (new_height_ok, parse_scrolling_args): Update.
1922         * tui/tui-layout.c (show_layout, show_data): Update.
1923         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1924         (tui_add_to_source_windows): Don't declare.
1925         * tui/tui-data.c (source_windows, tui_source_windows)
1926         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1927
1928 2019-08-15  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1931         Rename from reset.
1932         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1933         * tui/tui-layout.c (show_source_disasm_command, show_data):
1934         Update.
1935         (tui_gen_win_info::resize): Rename.
1936         (show_source_or_disasm_and_command): Update.
1937         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1938         reset.
1939
1940 2019-08-15  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1943         * tui/tui-interp.c (tui_interp::init): Don't call
1944         tui_initialize_static_data.
1945         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1946
1947 2019-08-15  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1950         examine tui_win_list.
1951
1952 2019-08-15  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1955         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1956         tui_clear_source_content.
1957         (tui_clear_source_content): Remove.
1958         (tui_source_window_base::do_erase_source_content): Hoist call to
1959         content.clear().
1960         * tui/tui-stack.c (tui_show_frame_info): Don't call
1961         tui_clear_source_content.
1962
1963 2019-08-15  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.h (struct tui_source_window_base)
1966         <do_erase_source_content>: New method.
1967         <erase_source_content>: New method.
1968         (tui_erase_source_content): Don't declare.
1969         * tui/tui-winsource.c (tui_clear_source_content): Update.
1970         (tui_source_window_base::do_erase_source_content): Rename from
1971         tui_erase_source_content.
1972         (tui_source_window_base::show_source_content): Update.
1973         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1974         * tui/tui-source.h (struct tui_source_window)
1975         <erase_source_content>: New method.
1976         * tui/tui-disasm.h (struct tui_disasm_window)
1977         <erase_source_content>: New method.
1978
1979 2019-08-15  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1982         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1983         constructor.
1984         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1985         * tui/tui-source.c (tui_set_source_content): Update.
1986         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1987
1988 2019-08-15  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1991         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1992         tui-source.c.
1993         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1994         Declare.
1995         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1996         method.
1997         (tui_source_window::maybe_update): Update.
1998
1999 2019-08-15  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2002         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2003         tui-disasm.c.
2004         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2005         Declare.
2006         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2007         method.
2008         (tui_disasm_window::maybe_update): Update.
2009
2010 2019-08-15  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.h (struct tui_source_window_base)
2013         <maybe_update>: Declare.
2014         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2015         method.
2016         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2017         Declare.
2018         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2019         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2020         Declare.
2021         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2022
2023 2019-08-15  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2026
2027 2019-08-15  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-wingeneral.c: Include tui-stack.h.
2030         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2031         (struct tui_locator_window): Move from tui-data.h.
2032         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2033         (tui_initialize_static_data): Move from tui-data.c.
2034         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2035         (struct tui_locator_window): Move to tui-stack.c.
2036         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2037         (tui_initialize_static_data): Move to tui-stack.c.
2038
2039 2019-08-15  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-layout.c (show_source_disasm_command)
2042         (show_source_or_disasm_and_command): Use make_visible method, not
2043         tui_make_window.
2044         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2045         Remove.
2046
2047 2019-08-15  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-wingeneral.h (tui_make_window): Update.
2050         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2051         parameter.
2052         (tui_gen_win_info::make_visible): Update.
2053         * tui/tui-regs.c (tui_data_window::display_registers_from):
2054         Update.
2055         * tui/tui-layout.c (show_source_disasm_command)
2056         (show_source_or_disasm_and_command): Update.
2057         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2058         (enum tui_box): Remove.
2059         (struct tui_win_info) <can_box>: New method.
2060         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2061         method.
2062
2063 2019-08-15  Tom de Vries  <tdevries@suse.de>
2064
2065         * linux-nat-trad.c: Include gdbarch.h.
2066
2067 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2068
2069         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2070         register sizes.
2071
2072 2019-08-14  Tom Tromey  <tromey@adacore.com>
2073
2074         * darwin-nat.c: Include gdbarch.h.
2075         * darwin-nat-info.c: Include gdbarch.h.
2076
2077 2019-08-13  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2080         Remove.
2081         * tui/tui-data.c (tui_initialize_static_data): Update.
2082
2083 2019-08-13  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-winsource.h (struct tui_exec_info_window)
2086         <~tui_exec_info_window, maybe_allocate_content, get_content,
2087         m_content>: Remove.
2088         (struct tui_source_window_base) <set_exec_info_content,
2089         show_exec_info_content>: Don't declare.
2090         * tui/tui-winsource.c
2091         (tui_exec_info_window::maybe_allocate_content): Remove.
2092         (tui_source_window_base::update_exec_info): Rename from
2093         set_exec_info_content.
2094         (tui_source_window_base::show_exec_info_content)
2095         (tui_source_window_base::update_exec_info): Remove.
2096
2097 2019-08-13  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2100         declare.
2101         * tui/tui-winsource.c (tui_update_source_window_as_is)
2102         (tui_update_source_windows_with_addr, tui_erase_source_content):
2103         Update.
2104         (tui_clear_exec_info_content): Remove.
2105
2106 2019-08-13  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2109         declare.
2110         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2111         call tui_erase_exec_info_content.
2112         (tui_clear_exec_info_content): Rename from
2113         tui_erase_exec_info_content.
2114         (tui_clear_exec_info_content): Delete.
2115
2116 2019-08-13  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.h (struct tui_source_window_base)
2119         <show_exec_info_content>: Declare.
2120         (tui_show_exec_info_content): Don't declare.
2121         * tui/tui-winsource.c
2122         (tui_source_window_base::show_exec_info_content): Rename from
2123         tui_show_exec_info_content.
2124         (tui_source_window_base::update_exec_info): Update.
2125
2126 2019-08-13  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2129         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2130         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2131         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2132         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2133         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2134         ... here.
2135
2136 2019-08-13  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-winsource.h (struct tui_source_window_base)
2139         <update_exec_info>: Declare.
2140         (tui_update_exec_info): Don't declare.
2141         * tui/tui-winsource.c (tui_update_source_window_as_is)
2142         (tui_source_window_base::refresh_all)
2143         (tui_update_all_breakpoint_info): Update.
2144         (tui_source_window_base::update_exec_info): Rename from
2145         tui_update_exec_info.
2146         * tui/tui-stack.c (tui_show_frame_info): Update.
2147
2148 2019-08-13  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-winsource.h (struct tui_source_window_base)
2151         <set_exec_info_content>: Declare.
2152         (tui_set_exec_info_content): Don't declare.
2153         * tui/tui-winsource.c
2154         (tui_source_window_base::set_exec_info_content): Rename from
2155         tui_set_exec_info_content.
2156         (tui_update_exec_info): Update.
2157
2158 2019-08-13  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.h (struct tui_source_window_base)
2161         <show_source_content>: Declare.
2162         (tui_show_source_content): Don't declare.
2163         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2164         (tui_source_window_base::show_source_content): Rename from
2165         tui_show_source_content.
2166         (tui_source_window_base::refresh_all): Update.
2167         * tui/tui-layout.c (show_source_disasm_command)
2168         (show_source_or_disasm_and_command): Update.
2169
2170 2019-08-13  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-winsource.c (tui_erase_source_content)
2173         (tui_show_source_content, tui_source_window_base::refresh_all):
2174         Update.
2175         * tui/tui-wingeneral.h
2176         (tui_check_and_display_highlight_if_needed): Don't declare.
2177         * tui/tui-wingeneral.c
2178         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2179         check_and_display_highlight_if_needed.
2180         * tui/tui-win.c (tui_rehighlight_all)
2181         (tui_win_info::make_visible_with_new_height): Update.
2182         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2183         (tui_data_window::erase_data_content)
2184         (tui_data_window::display_all_data): Update.
2185         * tui/tui-data.h (struct tui_win_info)
2186         <check_and_display_highlight_if_needed>: Declare.
2187
2188 2019-08-13  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-win.c (tui_resize_all): Call
2191         tui_delete_invisible_windows.
2192         * tui/tui-layout.c (show_layout): Call
2193         tui_delete_invisible_windows.
2194         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2195         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2196
2197 2019-08-13  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2200         tui_add_win_to_layout.
2201
2202 2019-08-13  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2205         * tui/tui-layout.c (tui_default_win_height): Now static.
2206
2207 2019-08-13  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2210         single switch.
2211         (show_source_disasm_command, show_source_or_disasm_and_command):
2212         Don't check current layout.
2213
2214 2019-08-13  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-wingeneral.c (make_all_visible): Remove.
2217         (tui_make_all_invisible): Simplify.
2218         * tui/tui-layout.c (tui_make_all_invisible): Move from
2219         tui-wingeneral.c; simplify.
2220         (show_layout): Hoist call to tui_make_all_invisible.
2221         (show_data): Don't call tui_make_all_invisible.
2222
2223 2019-08-13  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2226         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2227
2228 2019-08-13  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2231         tui-data.c.
2232         (show_source_disasm_command, show_data)
2233         (show_source_or_disasm_and_command): Don't use
2234         tui_set_current_layout_to.
2235         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2236         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2237         tui-layout.c.
2238         (tui_set_current_layout_to): Remove.
2239
2240 2019-08-13  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-layout.c (tui_set_layout): Update.
2243         * tui/tui-data.h (struct tui_layout_def): Remove.
2244         (tui_layout_def): Don't declare.
2245         * tui/tui-data.c (layout_def): Remove.
2246         (tui_layout_def): Remove.
2247
2248 2019-08-13  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-winsource.h (struct tui_source_window_base)
2251         <clear_detail>: No longer "override".
2252         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2253         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2254         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2255         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2256         Remove.
2257         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2258
2259 2019-08-13  Tom Tromey  <tromey@adacore.com>
2260
2261         * tracepoint.c: Don't include readline.h or history.h.
2262
2263 2019-08-12  Tom Tromey  <tom@tromey.com>
2264
2265         * configure: Rebuild.
2266         * configure.ac: Check for readline 7.
2267         * NEWS: Mention readline 7 requirement.
2268         * README: Update.
2269
2270 2019-08-12  Tom Tromey  <tom@tromey.com>
2271
2272         * mingw-hdep.c (gdb_select): Remove readline hack.
2273
2274 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2275
2276         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2277         when the function fails.
2278
2279 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2280
2281         * s390-tdep.c (s390_type_align): New function.
2282         (s390_gdbarch_init): Set it as type_align gdbarch method.
2283
2284 2019-08-09  Tom de Vries  <tdevries@suse.de>
2285
2286         PR gdb/24591
2287         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2288         pc_low with relocation offset.
2289
2290 2019-08-07  Tom Tromey  <tromey@adacore.com>
2291
2292         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2293         (print_frame_args): Update.
2294         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2295         Update.
2296         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2297         * frame.h (struct frame_arg): Add initializers.
2298         <error>: Now a unique_xmalloc_ptr.
2299
2300 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2301
2302         * NEWS: Expand the Pointer Authentication entry.
2303         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2304         (aarch64_frame_unmask_lr): ... to this.
2305         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2306         Call aarch64_frame_unmask_lr.
2307         * frame.c (struct frame_info): Add "masked" variable.
2308         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2309         (fprint_frame): Check for masked pc.
2310         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2311         declarations.
2312         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2313         * stack.c (print_frame): Check for masked pc.
2314
2315 2019-08-06  Tom Tromey  <tom@tromey.com>
2316
2317         * stabsread.c (patch_block_stabs, read_one_struct_field)
2318         (read_enum_type): Use obstack_strndup.
2319         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2320         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2321         * dwarf2read.c (guess_full_die_structure_name)
2322         (anonymous_struct_prefix): Use obstack_strndup.
2323         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2324         * c-exp.y (yylex): Use obstack_strndup.
2325         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2326         (write_var_or_type): Use obstack_strndup.
2327
2328 2019-08-06  Tom Tromey  <tom@tromey.com>
2329
2330         * symfile.c (reread_symbols): Use obstack_strdup.
2331         * stabsread.c (read_type): Use obstack_strdup.
2332         * gdb_obstack.h (obstack_strdup): New overload.
2333         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2334         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2335         (dwarf2_canonicalize_name): Use obstack_strdup.
2336         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2337         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2338         Use obstack_strdup.
2339
2340 2019-08-06  Tom Tromey  <tom@tromey.com>
2341
2342         * gdb_obstack.h (obstack_strdup): Define.
2343         * gdb_obstack.c (obstack_strdup): Don't define.
2344
2345 2019-08-06  Tom Tromey  <tom@tromey.com>
2346
2347         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2348         obstack_strdup.
2349         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2350         obstack_strdup.
2351         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2352         * stabsread.c (common_block_start): Use obstack_strdup.
2353         * objfiles.c (set_objfile_main_name, objfile): Use
2354         obstack_strdup.
2355         * namespace.c (add_using_directive): Use obstack_strdup.
2356         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2357         * jit.c (finalize_symtab): Use obstack_strdup.
2358         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2359         (guess_partial_die_structure_name, partial_die_info::fixup)
2360         (dwarf2_name): Use obstack_strdup.
2361         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2362         obstack_strdup.
2363         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2364         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2365         obstack_strdup.
2366         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2367
2368 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2369
2370         * unittests/help-doc-selftests.c: New file.
2371         * Makefile.in: Add the new file.
2372
2373 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2374
2375         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2376         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2377         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2378         the trailing '.' is not output, and the first character is uppercased.
2379         (print_help_for_command): Update call to print_doc_line.
2380         (print_doc_of_command): Likewise.
2381         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2382         * cli/cli-option.c (append_indented_doc): Do not append newline.
2383         (build_help_option): Append newline after first appended_indented_doc
2384         only if a second call is done.
2385         (build_help): Append 2 new lines before each option, except the first
2386         one.
2387         * compile/compile.c (_initialize_compile): Add new lines after
2388         %OPTIONS%, when not at the end of the help.
2389         Change help doc or code
2390         producing the help doc to respect the invariants.
2391         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2392         Also removed the new line after 'Options:', as all other commands
2393         do not put an empty line between 'Options:' and the first option.
2394         * printcmd.c (_initialize_printcmd): Likewise.
2395         * stack.c (_initialize_stack): Likewise.
2396         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2397         incorrectly telling COMMAND is optional.
2398         * ada-lang.c (_initialize_ada_language): Change help doc or code
2399         producing the help doc to respect the invariants.
2400         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2401         * breakpoint.c (_initialize_breakpoint): Likewise.
2402         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2403         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2404         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2405         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2406         _initialize_cli_style): Likewise.
2407         * corelow.c (core_target_info): Likewise.
2408         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2409         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2410         * filesystem.c (_initialize_filesystem): Likewise.
2411         * frame.c (_initialize_frame): Likewise.
2412         * gnu-nat.c (add_task_commands): Likewise.
2413         * infcall.c (_initialize_infcall): Likewise.
2414         * infcmd.c (_initialize_infcmd): Likewise.
2415         * interps.c (_initialize_interpreter): Likewise.
2416         * language.c (_initialize_language): Likewise.
2417         * linux-fork.c (_initialize_linux_fork): Likewise.
2418         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2419         * maint.c (_initialize_maint_cmds): Likewise.
2420         * memattr.c (_initialize_mem): Likewise.
2421         * printcmd.c (_initialize_printcmd): Likewise.
2422         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2423         _RegEx): Likewise.
2424         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2425         * record-btrace.c (_initialize_record_btrace): Likewise.
2426         * record-full.c (_initialize_record_full): Likewise.
2427         * record.c (_initialize_record): Likewise.
2428         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2429         * regcache.c (_initialize_regcache): Likewise.
2430         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2431         _initialize_remote): Likewise.
2432         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2433         * serial.c (_initialize_serial): Likewise.
2434         * skip.c (_initialize_step_skip): Likewise.
2435         * source.c (_initialize_source): Likewise.
2436         * stack.c (_initialize_stack): Likewise.
2437         * symfile.c (_initialize_symfile): Likewise.
2438         * symtab.c (_initialize_symtab): Likewise.
2439         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2440         * top.c (init_main): Likewise.
2441         * tracefile-tfile.c (tfile_target_info): Likewise.
2442         * tracepoint.c (_initialize_tracepoint): Likewise.
2443         * tui/tui-win.c (_initialize_tui_win): Likewise.
2444         * utils.c (add_internal_problem_command): Likewise.
2445         * valprint.c (value_print_option_defs): Likewise.
2446
2447 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2448
2449         PR build/24886
2450         * configure.ac: Drop enable-libmcheck support.
2451         * configure, config.in: Rebuild.
2452         * libmcheck.m4: Remove.
2453         * acinclude.m4: Don't include it.
2454         * Makefile.in: Don't distribute it.
2455         * top.c (print_gdb_configuration): Don't mention it.
2456
2457 2019-08-06  Tom Tromey  <tom@tromey.com>
2458
2459         * utils.c (set_output_style): Sometimes pass stream to
2460         emit_style_escape.
2461         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2462         * record-btrace.c (btrace_insn_history): Update.
2463         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2464         method.
2465         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2466         Update initializers.
2467         <m_uiout>: New field.
2468         <m_di>: Move lower.
2469         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2470         Remove "uiout" parameter.
2471         (dump_insns): Update.
2472         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2473         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2474
2475 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2476
2477         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2478         (error_in_psymtab_expansion): Likewise.
2479         (lookup_symbol_via_quick_fns): Likewise.
2480         (basic_lookup_transparent_type_quick): Likewise.
2481         (basic_lookup_transparent_type_1): Likewise.
2482
2483 2019-08-06  Tom Tromey  <tromey@adacore.com>
2484
2485         * source.c (last_source_error): Now bool.
2486         (print_source_lines_base): Make "noprint" bool.  Only open
2487         source file when last_source_visited changes.
2488
2489 2019-08-06  Tom Tromey  <tromey@adacore.com>
2490
2491         * annotate.c (annotate_source_line): Use g_source_cache.
2492         * source-cache.c (source_cache::get_plain_source_lines): Change
2493         parameters.  Populate m_offset_cache.
2494         (source_cache::ensure): New method.
2495         (source_cache::get_line_charpos): New method.
2496         (extract_lines): Move lower.  Change parameters.
2497         (source_cache::get_source_lines): Move lower.
2498         * source-cache.h (class source_cache): Update comment.
2499         <get_line_charpos>: New method.
2500         <get_source_lines>: Update comment.
2501         <clear>: Clear m_offset_cache.
2502         <get_plain_source_lines>: Change parameters.
2503         <ensure>: New method
2504         <m_offset_cache>: New member.
2505         * source.c (forget_cached_source_info_for_objfile): Update.
2506         (info_source_command): Use g_source_cache.
2507         (find_source_lines, open_source_file_with_line_charpos): Remove.
2508         (print_source_lines_base, search_command_helper): Use g_source_cache.
2509         * source.h (open_source_file_with_line_charpos): Don't declare.
2510         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2511         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2512         Use g_source_cache.
2513
2514 2019-08-06  Tom Tromey  <tromey@adacore.com>
2515
2516         * source-cache.c (source_cache::get_plain_source_lines):
2517         Remove "first_line" and "last_line" parameters.
2518         (source_cache::get_source_lines): Cache plain text.
2519         * source-cache.h (class source_cache)
2520         <get_plain_source_lines>: Update.
2521
2522 2019-08-06  Tom Tromey  <tromey@adacore.com>
2523
2524         * source-cache.c (extract_lines): No longer a method.
2525         Changed type of parameter.  Include final newline.
2526         (selftests::extract_lines_test): New function.
2527         (_initialize_source_cache): Likewise.
2528         * source-cache.h (class source_cache)
2529         <extract_lines>: Don't declare.
2530
2531 2019-08-06  Tom Tromey  <tromey@adacore.com>
2532
2533         * breakpoint.c (init_breakpoint_sal): Update.
2534         (breakpoint): Update.
2535         * breakpoint.h (struct breakpoint) <filter>: Now a
2536         unique_xmalloc_ptr.
2537
2538 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2539
2540         * NEWS: Mention dictionary access on blocks.
2541         * python/py-block.c (blpy_getitem): New function.
2542         (block_object_as_mapping): New struct.
2543         (block_object_type): Use new struct for tp_as_mapping field.
2544
2545 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2546
2547         * objfiles.h (objfile): Add a comment describing partial symbols.
2548
2549 2019-08-05  Tom Tromey  <tromey@adacore.com>
2550
2551         * compile/compile.c (_initialize_compile): Use _(), not N_().
2552         * thread.c (_initialize_thread): Use _(), not N_().
2553         * stack.c (_initialize_stack): Use _(), not N_().
2554         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2555
2556 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2557
2558         * dwarf2read.c (struct dw2_symtab_iterator):
2559         <want_specific_block>: Remove.
2560         <block_index>: Change type to gdb::optional.
2561         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2562         change type of BLOCK_INDEX parameter to gdb::optional.
2563         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2564         (dw2_lookup_symbol): Don't pass argument for
2565         WANT_SPECIFIC_BLOCK.
2566         (dw2_expand_symtabs_for_function): Don't pass argument for
2567         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2568         (class dw2_debug_names_iterator)
2569         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2570         parameter, change BLOCK_INDEX type to gdb::optional.
2571         <m_want_specific_block>: Remove.
2572         <m_block_index>: Change type to gdb::optional.
2573         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2574         gdb::optional.  Re-write in function of gdb::optional.
2575         (dw2_debug_names_lookup_symbol): Don't pass argument for
2576         WANT_SPECIFIC_BLOCK.
2577         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2578         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2579         BLOCK_INDEX.
2580
2581 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2582
2583         * NEWS: Mention changes to "info sources" command.
2584
2585 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2586
2587         * symtab.c (filename_partial_match_opts): New struct type.
2588         (struct output_source_filename_data): New members
2589         regexp, c_regexp, partial_match.
2590         (output_source_filename): Use new members to decide to print file.
2591         (info_sources_option_defs): New variable.
2592         (make_info_sources_options_def_group, print_info_sources_header,
2593         info_sources_command_completer):
2594         New functions.
2595         (info_sources_command): Read new optional arguments.
2596         (_initialize_symtab): Update info sources help.
2597
2598 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2599
2600         * ada-lang.c (exception_support_info_v0): Renamed from...
2601         (default_exception_support_info): ... this.  Create new
2602         definition for v1.
2603         (ada_has_this_exception_support): Look up catch_handlers_sym.
2604         (ada_exception_support_info_sniffer): Try v0 after default.
2605
2606 2019-08-01  Tom Tromey  <tromey@adacore.com>
2607
2608         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2609         gdbarch.h.
2610
2611 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2612
2613         * s12z-tdep.c: Fix include path for s12z-opc.h.
2614
2615 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2616
2617         * NEWS: Require GNU make 3.82.
2618
2619 2019-07-16  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2622         declare.
2623
2624 2019-07-30  Tom Tromey  <tromey@adacore.com>
2625
2626         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2627
2628 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2629
2630         * printcmd.c (print_address_symbolic): Print negative offsets.
2631         (build_address_symbolic): Force signed arithmetic when computing
2632         offset.
2633
2634 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2635
2636         PR/24474: Add a function to lookup static variables.
2637         * NEWS: Mention this new function.
2638         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2639         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2640         * python/python.c (python_GdbMethods): Add new function.
2641
2642 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2643
2644         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2645         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2646         (objfpy_lookup_static_symbol): New function.
2647         (objfile_object_methods): Add new functions.
2648
2649 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2650
2651         * NEWS: Mention 'set|show print frame-info'.  Mention new
2652         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2653         backtrace argument.  Mention that python frame filtering code
2654         is now consistent with what 'backtrace' command prints.
2655
2656 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2657
2658         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2659         comments.
2660         (print_frame_info_auto, print_frame_info_source_line,
2661         print_frame_info_location, print_frame_info_source_and_location,
2662         print_frame_info_location_and_address, print_frame_info_short_location):
2663         New declarations.
2664         (struct frame_print_options): New member print_frame_info.
2665         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2666         * stack.h (get_user_print_what_frame_info): New declaration.
2667         (frame_show_address): New declaration.
2668         * stack.c (print_frame_arguments_choices): New value 'presence'.
2669         (print_frame_info_auto, print_frame_info_source_line,
2670         print_frame_info_location, print_frame_info_source_and_location,
2671         print_frame_info_location_and_address, print_frame_info_short_location,
2672         print_frame_info_choices, print_frame_info_print_what): New definitions.
2673         (print_frame_args): Only print dots for args if print frame-arguments
2674         is 'presence'.
2675         (frame_print_option_defs): New element for "frame-info".
2676         (get_user_print_what_frame_info): New function.
2677         (frame_show_address): Make non static.  Move comment to stack.h.
2678         (print_frame_info_to_print_what): New function.
2679         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2680         to decide what to print.
2681         (backtrace_command_1): Handle the new print_frame_arguments_presence
2682         value.
2683         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2684         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2685         (py_print_frame): In non-mi mode, use LOCATION as default for
2686         print_what, similarly to frame information printed directly by
2687         backtrace command. Handle frame-info user option in non MI mode.
2688
2689 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2690
2691         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2692         Add case for debugging 32-bit target on 64-bit host.  Revise
2693         comment.
2694
2695 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2696
2697         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2698         instead of find_function_entry_range_from_pc.
2699
2700 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2701
2702         * stack.c (find_frame_funname): Remove code which preferred
2703         minsym over symtab sym in "certain pathological cases".
2704
2705         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2706         parameter.  Change type of "do_demangle" to bool.
2707         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2708         Pass suitable "prefer_sym_over_minsym" flag to
2709         build_address_symbolic().  Don't output "+" for negative offsets.
2710         * printcmd.c (print_address_symbolic): Update invocation of
2711         build_address_symbolic to include a "prefer_sym_over_minsym"
2712         flag.
2713         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2714         Restrict cases in which use of minimal symbol is preferred to that
2715         of a found symbol.  Update comments.
2716
2717         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2718         for entry pc when entry pc is out of range for that FDE.
2719
2720 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2721
2722         PR gdb/24839:
2723         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2724         type.
2725
2726 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2729         this function's Python signature.
2730
2731
2732 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2733
2734         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2735         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2736         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2737         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2738         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2739
2740
2741 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2742
2743         * h8300-tdep.c (h8300_register_name_common): New.
2744         h8300_register_name): Use h8300_register_name_common.
2745         (h8300s_register_name): Likewise.
2746         (h8300sx_register_name): Likewise.
2747         (h8300h_register_nam): New.
2748         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2749
2750
2751 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2752
2753         * arm-tdep.c (arm_skip_cmse_entry): New function.
2754         (arm_is_sgstubs_section): New function.
2755         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2756
2757 2019-07-22  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2760         Don't self-assign.
2761
2762 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2765         type_print.
2766
2767 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2770         so that GDB doesn't match any msymbols when searching in the
2771         TYPES_DOMAIN.
2772         (print_symbol_info): Print using typedef_print or type_print based
2773         on the type of the symbol.  Add updated FIXME comment moved from...
2774         (_initialize_symtab): ... move and update FIXME comment to above.
2775
2776 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * NEWS: Mention adding -q option to "info types".
2779         * symtab.c (struct info_types_options): New struct.
2780         (info_types_options_defs): New variable.
2781         (make_info_types_options_def_group): New function.
2782         (info_types_command): Use gdb::option framework to parse options.
2783         (info_types_command_completer): New function.
2784         (_initialize_symtab): Extend the help text on "info types" and
2785         register command completer.
2786
2787 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2788
2789         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2790         (lookup_symbol_in_objfile): Change int to block_enum and add a
2791         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2792
2793 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2794
2795         * MAINTAINERS (Write After Approval): Add self.
2796
2797 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2800         instruction to the dummy code region.
2801
2802 2019-07-19  Tom Tromey  <tromey@adacore.com>
2803
2804         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2805         (ARGSUSED, PARAMS, __func__): Remove rules.
2806
2807 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2808
2809         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2810         * features/arm/arm-with-iwmmxt.c: Remove.
2811         * features/arm/arm-with-iwmmxt.xml: Remove.
2812         * features/arm/arm-with-m-fpa-layout.c: Remove.
2813         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2814         * features/arm/arm-with-m-vfp-d16.c: Remove.
2815         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2816         * features/arm/arm-with-m.c: Remove.
2817         * features/arm/arm-with-m.xml: Remove.
2818         * features/arm/arm-with-neon.c: Remove.
2819         * features/arm/arm-with-neon.xml: Remove.
2820         * features/arm/arm-with-vfpv2.c: Remove.
2821         * features/arm/arm-with-vfpv2.xml: Remove.
2822         * features/arm/arm-with-vfpv3.c: Remove.
2823         * features/arm/arm-with-vfpv3.xml: Remove.
2824
2825 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2826
2827         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2828
2829 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * arch/aarch32.c (aarch32_create_target_description): Create
2832         target descriptions using features.
2833         * arch/arm.c (arm_create_target_description)
2834         (arm_create_mprofile_target_description): Likewise.
2835         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2836
2837 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2838
2839         * Makefile.in: Add new files.
2840         * aarch32-tdep.c: New file.
2841         * aarch32-tdep.h: New file.
2842         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2843         Call aarch32_read_description.
2844         * arch/aarch32.c: New file.
2845         * arch/aarch32.h: New file.
2846         * arch/arm.c (arm_create_target_description)
2847         (arm_create_mprofile_target_description): New function.
2848         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2849         (arm_create_target_description)
2850         (arm_create_mprofile_target_description): New declaration.
2851         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2852         read_description functions.
2853         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2854         Likewise.
2855         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2856         * arm-tdep.c (tdesc_arm_list): New variable.
2857         (arm_register_g_packet_guesses): Call create description functions.
2858         (arm_read_description) (arm_read_mprofile_description): New
2859         function.
2860         * arm-tdep.h (arm_read_description)
2861         (arm_read_mprofile_description): Add declaration.
2862         * configure.tgt: Add new files.
2863
2864 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2865
2866         * top.c (new_ui_command): Open specified terminal just once.
2867
2868 2019-07-18  Tom Tromey  <tromey@adacore.com>
2869
2870         * symtab.c (main_name): Constify return type.
2871         * symfile.c (set_initial_language): Update.
2872         * symtab.h (main_name): Constify return type.
2873
2874 2019-07-17  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-winsource.c (tui_update_source_window)
2877         (tui_update_source_window_as_is)
2878         (tui_update_source_windows_with_line): Remove return.
2879         * tui/tui-disasm.c (tui_show_disassem)
2880         (tui_show_disassem_and_update_source): Remove return.
2881         * tui/tui.c (tui_reset): Remove return.
2882         * tui/tui-wingeneral.c
2883         (tui_check_and_display_highlight_if_needed): Remove return.
2884
2885 2019-07-17  Tom Tromey  <tom@tromey.com>
2886
2887         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2888
2889 2019-07-17  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-winsource.h (struct tui_exec_info_window)
2892         (struct tui_source_window_base): Move from tui-data.h.
2893         * tui/tui-winsource.c: Move many method definitions from
2894         elsewhere.  Remove "structuring" comments.
2895         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2896         (tui_source_window_base::refresh_window): Move to
2897         tui-winsource.c.
2898         * tui/tui-win.c (tui_source_window_base::refresh_all)
2899         (tui_source_window_base::update_tab_width)
2900         (tui_source_window_base::set_new_height)
2901         (tui_source_window_base::do_make_visible_with_new_height): Move to
2902         tui-winsource.c.
2903         * tui/tui-source.h: Update.
2904         * tui/tui-source.c (tui_source_window_base::reset): Move to
2905         tui-winsource.c.
2906         * tui/tui-disasm.h: Update.
2907         * tui/tui-data.h (struct tui_exec_info_window): Move to
2908         tui-winsource.h.
2909         (struct tui_source_window_base): Likewise.
2910         * tui/tui-data.c (tui_source_window_base::clear_detail)
2911         (tui_source_window_base, ~tui_source_window_base): Move to
2912         tui-winsource.c.
2913
2914 2019-07-17  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-win.c (tui_resize_all)
2917         (tui_source_window_base::update_tab_width)
2918         (tui_adjust_win_heights): Update.
2919         (tui_win_info::make_invisible_and_set_new_height): Rename from
2920         make_invisible_and_set_new_height.
2921         * tui/tui-data.h (struct tui_win_info)
2922         <make_invisible_and_set_new_height>: New method.
2923
2924 2019-07-17  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui.c: Update.
2927         * tui/tui-source.h (struct tui_source_window): Move from
2928         tui-data.h.
2929         * tui/tui-layout.c: Update.
2930         * tui/tui-disasm.c: Update.
2931         * tui/tui-data.h (struct tui_source_window): Move to
2932         tui-source.h.
2933
2934 2019-07-17  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2937         tui-data.h.
2938         * tui/tui-data.h (struct tui_disasm_window): Move to
2939         tui-disasm.h.
2940
2941 2019-07-17  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-regs.h (struct tui_data_item_window): Move from
2944         tui-data.h.
2945         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2946         * tui/tui-data.h (struct tui_data_item_window): Move to
2947         tui-regs.h.
2948         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2949
2950 2019-07-17  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui.c: Update.
2953         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2954         (tui_cmd_window::max_height): Move to tui-command.c.
2955         * tui/tui-layout.c: Update.
2956         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2957         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2958         tui-command.c.
2959         * tui/tui-command.h (struct tui_cmd_window): Move from
2960         tui-data.h.
2961         * tui/tui-command.c: Remove "structuring" comments.
2962         (tui_cmd_window::clear_detail)
2963         (tui_cmd_window::do_make_visible_with_new_height)
2964         (tui_cmd_window::max_height): Move from elsewhere.
2965
2966 2019-07-17  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2969         Now static.
2970         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2971         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2972
2973 2019-07-17  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui.c: Update.
2976         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2977         tui-regs.c.
2978         * tui/tui-windata.h: Remove file.
2979         * tui/tui-windata.c: Remove file.
2980         * tui/tui-win.c (tui_data_window::set_new_height)
2981         (tui_data_window::do_make_visible_with_new_height): Move to
2982         tui-regs.c.
2983         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2984         * tui/tui-regs.c: Remove "structuring" comments.
2985         (tui_data_window::first_data_item_displayed)
2986         (tui_data_window::delete_data_content_windows)
2987         (tui_data_window::erase_data_content)
2988         (tui_data_window::display_all_data)
2989         (tui_data_window::refresh_all)
2990         (tui_data_window::do_scroll_vertical)
2991         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2992         (tui_data_window::do_make_visible_with_new_height)
2993         (tui_data_window::refresh_window): Move from elsewhere.
2994         (_initialize_tui_regs): Move to end of file.
2995         * tui/tui-layout.c: Update.
2996         * tui/tui-hooks.c: Update.
2997         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2998         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2999         tui-regs.c.
3000         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3001
3002 2019-07-17  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3005         seen.
3006
3007 2019-07-17  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-win.c (tui_source_window_base::set_new_height)
3010         (tui_source_window_base::do_make_visible_with_new_height): Use
3011         m_has_locator field directly.
3012         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3013         method.
3014         (struct tui_source_window_base) <has_locator>: Likewise.
3015
3016 2019-07-17  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3019         Don't declare.
3020         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3021         Remove.
3022         * tui/tui-win.c (tui_source_window_base::set_new_height)
3023         (tui_source_window_base::set_new_height)
3024         (make_invisible_and_set_new_height)
3025         (tui_source_window_base::do_make_visible_with_new_height)
3026         (tui_source_window_base::do_make_visible_with_new_height):
3027         Update.
3028         * tui/tui-layout.c (show_source_disasm_command, show_data)
3029         (show_source_or_disasm_and_command): Update.
3030         * tui/tui-layout.c (show_layout): Update.
3031
3032 2019-07-17  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-layout.c (make_data_window): Remove.
3035         (show_data): Unify creation and re-initialization cases.
3036
3037 2019-07-17  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-layout.c (make_source_window, make_disasm_window):
3040         Remove.
3041         (show_data): Unify creation and re-initialization cases.
3042
3043 2019-07-17  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-layout.c (make_command_window): Remove.
3046         (show_source_disasm_command, show_source_or_disasm_and_command):
3047         Unify creation and re-initialization cases.
3048
3049 2019-07-17  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3052         creation and re-initialization cases.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-regs.c (tui_get_register): Return void.
3057
3058 2019-07-17  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3061         Simplify.
3062
3063 2019-07-17  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3066         resetting.
3067
3068 2019-07-17  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3071         * tui/tui-regs.c (tui_reg_layout): New function.
3072         (tui_show_registers, tui_reg_command): Use it.
3073         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3074         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3075         parameters.
3076         (tui_layout_command): Remove.
3077
3078 2019-07-17  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-layout.h (tui/tui-layout): Return void.
3081         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3082
3083 2019-07-17  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-layout.c (show_source_disasm_command, show_data):
3086         Update.
3087         (reset_locator): Remove.
3088         (show_source_or_disasm_and_command): Update.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-source.c (tui_source_window_base::reset): Remove
3093         win_type parameter.
3094         * tui/tui-layout.c (make_command_window, make_source_window)
3095         (make_disasm_window, make_data_window)
3096         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3097         (reset_locator, show_source_or_disasm_and_command): Update.
3098         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3099         win_type parameter.
3100         (struct tui_source_window_base) <reset>: Likewise.
3101
3102 2019-07-17  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-layout.c (show_source_disasm_command): Use
3105         reset_locator.
3106         (reset_locator): New function.
3107         (init_and_make_win): Remove.
3108         (show_source_or_disasm_and_command): Use reset_locator.
3109
3110 2019-07-17  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3113         condition.
3114         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3115         Remove condition.
3116         * tui/tui-source.c (tui_source_window_base::reset): New method.
3117         * tui/tui-layout.c (make_command_window): Don't call
3118         init_and_make_win.
3119         (make_source_window, make_disasm_window): Don't call
3120         make_source_or_disasm_window.
3121         (make_data_window): Don't call init_and_make_win.  Change calling
3122         convention.
3123         (show_source_disasm_command, show_data): Simplify.
3124         (make_source_or_disasm_window): Remove.
3125         (show_source_or_disasm_and_command): Simplify.
3126         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3127         (struct tui_source_window_base) <reset>: Likewise.
3128         <execution_info>: Remove initializer.
3129         * tui/tui-data.c (tui_source_window_base): Initialize
3130         execution_info.
3131
3132 2019-07-17  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3135         variable.
3136
3137 2019-07-17  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui.c (tui_rl_other_window): Update.
3140         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3141         superclass method first.  Always iterate over regs_content.
3142         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3143         method.
3144         * tui/tui-win.c (tui_set_focus_command): Update.
3145
3146 2019-07-17  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-win.c (tui_set_focus_command): Rename from
3149         tui_set_focus.  Call tui_enable.
3150         (tui_set_focus_command): Remove.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3155         refresh_window.
3156         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3157         touchwin.
3158         (tui_data_window::refresh_window): Call refresh_window on data
3159         items.  Always call superclass refresh_window.
3160         (tui_win_info::refresh): Remove.
3161         (tui_source_window_base::refresh_window): Update.
3162         (tui_refresh_all): Update.
3163         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3164         refresh_window.
3165         (show_source_or_disasm_and_command): Likewise.
3166         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3167         (struct tui_source_window_base) <refresh>: Likewise.
3168
3169 2019-07-17  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-winsource.c (tui_clear_source_content)
3172         (tui_show_source_content): Update.
3173         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3174         whether content is empty.
3175         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3176         Remove.
3177
3178 2019-07-17  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3181         window's contents.
3182         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3183         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3188         (struct tui_data_item_window): Update.
3189
3190 2019-07-17  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3193         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3194         defines.
3195
3196 2019-07-17  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-winsource.h (tui_erase_source_content)
3199         (tui_clear_source_content): Remove "display_prompt" parameter.
3200         * tui/tui-winsource.c (tui_update_source_window_as_is)
3201         (tui_update_source_windows_with_addr): Update.
3202         (tui_clear_source_content): Remove "display_prompt" parameter.
3203         (tui_erase_source_content): Likewise.  Simplify.
3204         (tui_show_source_content): Update.
3205         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3206         * tui/tui-stack.c (tui_show_frame_info): Update.
3207         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3208         Remove defines.
3209
3210 2019-07-17  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3213         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3214         parameter.
3215         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3216         parameter.
3217
3218 2019-07-17  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.c (tui_clear_source_content)
3221         (tui_show_source_content, tui_show_exec_info_content)
3222         (tui_clear_exec_info_content): Update.
3223         * tui/tui-stack.c (tui_show_locator_content): Update.
3224         (tui_show_frame_info): Update.
3225         * tui/tui-source.h (tui_source_window): Don't declare.
3226         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3227         from tui_source_is_displayed.
3228         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3229         Remove field.
3230         (struct tui_source_window_base) <content_in_use>: New field.  Now
3231         bool.
3232         (struct tui_source_window) <showing_source_p>: New method.
3233         (TUI_SRC_WIN): Change cast.
3234         * tui/tui-data.c (tui_initialize_static_data): Update.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3239         location_matches_p.
3240         * tui/tui-source.c (tui_source_window::location_matches_p): New
3241         method.
3242         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3243         method.
3244         * tui/tui-data.h (struct tui_source_window_base)
3245         <location_matches_p>: New method.
3246         (struct tui_source_window, struct tui_disasm_window)
3247         <location_matches_p>: Likewise.
3248
3249 2019-07-17  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-win.c (tui_set_win_height_command): Rename from
3252         tui_set_win_height.
3253         (tui_set_win_height_command): Remove.
3254
3255 2019-07-17  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-source.c (tui_source_window): New constructor.  Add
3258         observer.
3259         (~tui_source_window): New destructor.
3260         (tui_source_window::style_changed): New method.
3261         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3262         (tui_attach_detach_observers): Update.
3263         * tui/tui-data.h (struct tui_source_window): Make constructor not
3264         inline.  Add destructor.
3265         (struct tui_source_window) <style_changed>: New method.
3266         <m_observable>: New member.
3267
3268 2019-07-17  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3271         * tui/tui-win.c (tui_resize_all): Fix typo.
3272
3273 2019-07-17  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3276         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3277         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3278         * tui/tui-win.c (window_name_completer): Use foreach.
3279         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3280         (update_tab_width): Likewise.
3281         * tui/tui-layout.c (show_layout): Update.
3282         * tui/tui-data.h (class tui_window_iterator): New.
3283         (struct all_tui_windows): New.
3284         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3285
3286 2019-07-17  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3289         parameter.  Don't reference globals.
3290         (tui_reg_command): Update.
3291
3292 2019-07-17  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-regs.c (tui_show_registers): Simplify.
3295
3296 2019-07-17  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-regs.c (tui_show_registers): Update.
3299         (tui_show_register_group): Add win_info parameter.
3300
3301 2019-07-17  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3304         Rename from tui_display_reg_element_at_line.
3305         (tui_data_window::display_registers_from_line): Update.
3306         * tui/tui-data.h (struct tui_data_window)
3307         <display_reg_element_at_line>: New method.
3308
3309 2019-07-17  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-regs.h (tui_display_registers_from)
3312         (tui_display_registers_from_line): Don't declare.
3313         * tui/tui-windata.c (tui_data_window::display_all_data)
3314         (tui_data_window::refresh_all)
3315         (tui_data_window::do_scroll_vertical): Update.
3316         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3317         from tui_display_registers_from.
3318         (tui_display_reg_element_at_line): Update.
3319         (tui_data_window::display_registers_from_line): Rename from
3320         tui_display_registers_from_line.
3321         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3322         display_registers_from_line>: New methods.
3323
3324 2019-07-17  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3327         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3328         from tui_erase_data_content.
3329         (tui_data_window::display_all_data)
3330         (tui_data_window::refresh_all)
3331         (tui_data_window::do_scroll_vertical): Update.
3332         * tui/tui-regs.c (tui_show_registers): Update.
3333         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3334         New method.
3335
3336 2019-07-17  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3339         declare.
3340         * tui/tui-windata.c
3341         (tui_data_window::delete_data_content_windows): Rename from
3342         tui_delete_data_content_windows.
3343         (tui_data_window::display_all_data)
3344         (tui_data_window::do_scroll_vertical): Update.
3345         * tui/tui-data.h (struct tui_data_window)
3346         <delete_data_content_windows>: New method.
3347
3348 2019-07-17  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3351         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3352
3353 2019-07-17  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3356         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3357         from tui_display_all_data.
3358         * tui/tui-win.c
3359         (tui_data_window::do_make_visible_with_new_height): Update.
3360         * tui/tui-regs.c (tui_show_registers): Update.
3361         * tui/tui-layout.c (tui_set_layout): Update.
3362         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3363         method.
3364
3365 2019-07-17  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3368         * tui/tui-windata.c (tui_display_data_from): Remove.
3369         (tui_data_window::refresh_all): Update.
3370
3371 2019-07-17  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3374         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3375         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3376         tui_display_registers_from_line.
3377         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3378         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3379         "force_display" parameter.
3380
3381 2019-07-17  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3384         declare.
3385         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3386         Rename from tui_first_reg_element_no_inline.
3387         (tui_display_reg_element_at_line)
3388         (tui_display_registers_from_line): Update.
3389         * tui/tui-data.h (struct tui_data_window)
3390         <first_reg_element_no_inline>: New method.
3391
3392 2019-07-17  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-windata.c (tui_display_data_from)
3395         (tui_data_window::do_scroll_vertical): Update.
3396         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3397         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3398         Rename from tui_line_from_reg_element_no.
3399         (tui_display_registers_from_line): Update.
3400         * tui/tui-data.h (struct tui_data_window)
3401         <line_from_reg_element_no>: New method.
3402
3403 2019-07-17  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3406         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3407         tui_last_regs_line_no.
3408         (tui_display_reg_element_at_line)
3409         (tui_display_registers_from_line): Update.
3410         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3411         method.
3412
3413 2019-07-17  Tom Tromey  <tom@tromey.com>
3414
3415         PR tui/24722:
3416         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3417         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3418         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3419         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3420         (tui_update_breakpoint_info): Likewise.
3421         * tui/tui-hooks.c (tui_event_create_breakpoint)
3422         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3423         Update.
3424
3425 2019-07-17  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3428
3429 2019-07-17  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-winsource.c (tui_update_source_window_as_is)
3432         (tui_update_source_windows_with_addr): Update.
3433         * tui/tui-source.h (tui_set_source_content)
3434         (tui_show_symtab_source): Add "win_info" parameter.
3435         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3436         parameter.
3437         (tui_show_symtab_source): Likewise.
3438
3439 2019-07-17  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-wingeneral.c
3442         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3443
3444 2019-07-17  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3447         (struct tui_cmd_window) <can_scroll>: New method.
3448         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3449         method.
3450
3451 2019-07-17  Tom Tromey  <tromey@adacore.com>
3452
3453         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3454         do_field_signed>: Rename.  Change type of "value".
3455         * ui-out.c (ui_out::field_signed): Rename from field_int.
3456         Change type of "value".
3457         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3458         type of "value".
3459         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3460         do_field_int.  Change type of "value".
3461         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3462         do_field_int.  Change type of "value".
3463         * tracepoint.c (trace_status_mi, tfind_1)
3464         (print_one_static_tracepoint_marker): Update.
3465         * thread.c (print_thread_info_1, print_selected_thread_frame):
3466         Update.
3467         * stack.c (print_frame, print_frame_info): Update.
3468         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3469         Update.
3470         * source.c (print_source_lines_base): Update.
3471         * skip.c (info_skip_command): Update.
3472         * record-btrace.c (btrace_ui_out_decode_error)
3473         (btrace_call_history_src_line): Update.
3474         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3475         Update.
3476         * progspace.c (print_program_space): Update.
3477         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3478         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3479         do_field_int.  Change type of "value".
3480         * mi/mi-out.c (mi_ui_out::do_table_begin)
3481         (mi_ui_out::do_table_header): Update.
3482         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3483         type of "value".
3484         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3485         (mi_cmd_data_list_changed_registers, output_register)
3486         (mi_cmd_data_read_memory, mi_load_progress)
3487         (mi_cmd_trace_frame_collected): Update.
3488         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3489         Update.
3490         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3491         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3492         (mi_cmd_var_list_children, varobj_update_one): Update.
3493         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3494         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3496         * inferior.c (print_inferior): Update.
3497         * gdb_bfd.c (print_one_bfd): Update.
3498         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3499         Update.
3500         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3501         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3502         do_field_int.  Change type of "value".
3503         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3504         do_field_int.  Change type of "value".
3505         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3506         (print_one_breakpoint_location, print_it_catch_fork)
3507         (print_one_catch_fork, print_it_catch_vfork)
3508         (print_one_catch_vfork, print_it_catch_solib)
3509         (print_it_catch_exec, print_it_ranged_breakpoint)
3510         (print_mention_watchpoint, print_mention_masked_watchpoint)
3511         (bkpt_print_it, update_static_tracepoint): Update.
3512         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3513         * break-catch-syscall.c (print_it_catch_syscall): Update.
3514         * ada-tasks.c (print_ada_task_info): Update.
3515         * ada-lang.c (print_it_exception, print_mention_exception):
3516         Update.
3517
3518 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         PR breakpoints/24541
3521         * gdbarch.c: Regenerate.
3522         * gdbarch.h: Regenerate.
3523         * gdbarch.sh: Adjust return type and parameter types for
3524         'stap_adjust_register'.
3525         (i386_stap_adjust_register): Adjust signature and return new
3526         register name.
3527         * stap-probe.c (stap_parse_register_operand): Adjust use of
3528         'gdbarch_stap_adjust_register'.
3529
3530 2019-07-17  Tom Tromey  <tromey@adacore.com>
3531
3532         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3533         declare VEC.
3534         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3535         std::vector.
3536         (struct s390_process_info): Add initializers.
3537         (s390_add_process): Use new.
3538         (s390_linux_nat_target::low_forget_process): Use delete.
3539         (s390_linux_nat_target::low_new_fork)
3540         (s390_linux_nat_target::stopped_by_watchpoint)
3541         (s390_linux_nat_target::low_prepare_to_resume)
3542         (s390_linux_nat_target::insert_watchpoint)
3543         (s390_linux_nat_target::insert_hw_breakpoint)
3544         (s390_linux_nat_target::remove_watchpoint)
3545         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3546
3547 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3548
3549         * aarch64-fbsd-nat.c: Include regcache.h.
3550         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3551         argument.
3552         (aarch64_fbsd_nat_target::fetch_registers)
3553         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3554         variable.
3555         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3556
3557 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3558
3559         * fbsd-nat.c: Include gdbarch.h.
3560
3561 2019-07-15  Tom Tromey  <tromey@adacore.com>
3562
3563         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3564
3565 2019-07-15  Tom Tromey  <tromey@adacore.com>
3566
3567         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3568         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3569         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3570         * cli-out.c (cli_ui_out::do_field_int): New method.
3571         * ui-out.c (ui_out::field_unsigned): New method.
3572         * symfile.c (generic_load): Use field_unsigned.
3573         (print_transfer_performance): Likewise.
3574         * record-btrace.c (ui_out_field_uint): Remove.
3575         (btrace_call_history_insn_range, btrace_call_history): Use
3576         field_unsigned.
3577         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3578         field_unsigned.
3579         * ui-out.h (class ui_out) <field_unsigned>: New method.
3580         <do_field_unsigned>: Likewise.
3581
3582 2019-07-15  Tom Tromey  <tromey@adacore.com>
3583
3584         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3585         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3586         * target.c (flash_erase_command): Use field_string.
3587         * infrun.c (print_signal_received_reason): Use field_string.
3588         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3589         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3590         field_string.
3591         * ada-tasks.c (print_ada_task_info): Use field_string.
3592
3593 2019-07-15  Tom Tromey  <tromey@adacore.com>
3594
3595         * target.c (flash_erase_command): Use field_core_addr.
3596         * symfile.c (generic_load): Use field_core_addr.
3597         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3598         Use field_core_addr.
3599         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3600         field_core_addr.
3601
3602 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3605         value if its desired type is smaller than a CORE_ADDR and signed.
3606
3607 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3608
3609         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3610         of changes to field names, and use new is_reference field to
3611         decide if a property is a reference or not.
3612         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3613         field.
3614         (struct dwarf2_property_baton): Update header comment, rename
3615         'referenced_type' to 'property_type' and update comments.
3616         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3617         default property type, store in property baton, update to take
3618         accound of renamed field.
3619         (read_func_scope): Update call to attr_to_dynamic_prop.
3620         (read_array_type): Likewise.
3621         (dwarf2_per_cu_addr_sized_int_type): New function.
3622         (read_subrange_index_type): Move type finding code to
3623         dwarf2_per_cu_addr_sized_int_type.
3624         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3625         (dwarf2_per_cu_addr_type): New function.
3626         (set_die_type): Update calls to attr_to_dynamic_prop.
3627
3628 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * dwarf2read.c (read_subrange_index_type): New function.
3631         (read_subrange_type): Move code into new function and call it.
3632         * gdbtypes.c (create_range_type): Add some asserts.
3633
3634 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3637         update return statements.
3638         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3639         declaration, and update comment to match.
3640         * gdbtypes.c (resolve_dynamic_array): Update call to
3641         dwarf2_evaluate_property to match new return type.
3642
3643 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3644
3645         * valarith.c (value_subscripted_rvalue): Change lowerbound
3646         parameter type from int to LONGEST.
3647         * value.h (value_subscripted_rvalue): Likewise in declaration.
3648
3649 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * cli/cli-utils.c (info_print_command_completer): New function.
3652         * cli/cli-utils.h: Add 'completer.h' include, and forward
3653         declaration for 'struct cmd_list_element'.
3654         (info_print_command_completer): Declare.
3655         * stack.c (_initialize_stack): Add completer for 'info locals' and
3656         'info args'.
3657         * symtab.c (_initialize_symtab): Add completer for 'info
3658         variables' and 'info functions'.
3659         * NEWS: Mention completion for additional info commands.
3660
3661 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * cli/cli-utils.c (extract_info_print_args): Delete.
3664         (extract_arg_maybe_quoted): Delete.
3665         (info_print_options_defs): New variable.
3666         (make_info_print_options_def_group): New function.
3667         (extract_info_print_options): Define new function.
3668         * cli/cli-utils.h (extract_info_print_args): Delete.
3669         (struct info_print_options): New structure.
3670         (extract_info_print_options): Declare new function.
3671         * stack.c (info_locals_command): Update to use new
3672         extract_info_print_options, also add a header comment.
3673         (info_args_command): Likewise.
3674         * symtab.c (info_variables_command): Likewise.
3675         (info_functions_command): Likewise.
3676
3677 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3680         to extract string arguments.
3681         * common/common-utils.c (extract_string_maybe_quoted): New function.
3682         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3683
3684 2019-07-11  Tom Tromey  <tromey@adacore.com>
3685
3686         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3687         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3688         * top.h (gdbinit): Don't declare.
3689         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3690         into...
3691         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3692         * top.c (gdb_init): Don't call init_cli_cmds.
3693         (gdbinit): Remove.
3694         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3695
3696 2019-07-11  Tom Tromey  <tromey@adacore.com>
3697
3698         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3699         after it has been moved.
3700
3701 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3702
3703         * valops.c (value_must_coerce_to_target): Change return type to
3704         bool.
3705         * value.h (value_must_coerce_to_target): Likewise.
3706
3707 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3708
3709         * breakpoint.c (is_hardware_watchpoint): Remove
3710         forward-declaration.
3711         (is_masked_watchpoint): Change return type to bool.
3712         (is_tracepoint): Likewise.
3713         (is_breakpoint): Likewise.
3714         (is_hardware_watchpoint): Likewise.
3715         (is_watchpoint): Likewise.
3716         (is_no_memory_software_watchpoint): Likewise.
3717         (is_catchpoint): Likewise.
3718         (breakpoint_1): Make FILTER parameter's return type bool.
3719         is_masked_watchpoint): Change return type to bool.
3720         (save_breakpoints): Make FILTER parameter's return type bool.
3721         * breakpoint.h (is_breakpoint): Change return type to bool.
3722         (is_watchpoint): Likewise.
3723         (is_catchpoint): Likewise.
3724         (is_tracepoint): Likewise.
3725
3726 2019-07-10  Tom Tromey  <tom@tromey.com>
3727
3728         * defs.h: Don't include gdbarch.h.
3729         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3730         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3731         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3732         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3733         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3734         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3735         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3736         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3737         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3738         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3739         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3740         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3741         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3742         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3743         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3744         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3745         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3746         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3747         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3748         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3749         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3750         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3751         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3752         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3753         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3754         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3755         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3756
3757 2019-07-10  Tom Tromey  <tromey@adacore.com>
3758
3759         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3760         * breakpoint.c (init_ada_exception_breakpoint): Register as
3761         bp_catchpoint.
3762         (print_one_breakpoint_location, print_one_breakpoint): Use
3763         is_ada_exception_catchpoint.
3764         * ada-lang.c (class ada_catchpoint_location): Pass
3765         bp_loc_software_breakpoint to bp_location constructor.
3766         (is_ada_exception_catchpoint): New function.
3767
3768 2019-07-10  Tom Tromey  <tromey@adacore.com>
3769
3770         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3771         VEC.
3772         (struct arm_exidx_entry): New method operator<.
3773         (struct arm_exidx_data) <section_maps>: Change type.
3774         (arm_exidx_data_free): Remove.
3775         (arm_exidx_data_key): Change type.  Move lower.
3776         (arm_exidx_new_objfile): Update.
3777         (arm_compare_exidx_entries): Remove.
3778         (arm_find_exidx_entry, _initialize_arm_tdep)
3779
3780 2019-07-10  Tom Tromey  <tromey@adacore.com>
3781
3782         * solib-spu.c (ocl_program_data_key): Change type.
3783         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3784         Update.
3785
3786 2019-07-10  Tom Tromey  <tromey@adacore.com>
3787
3788         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3789         (struct solib_aix_inferior_data) <library_list>: Change type.
3790         (solib_aix_inferior_data_handle): Change type.
3791         (get_solib_aix_inferior_data): Update.
3792         (solib_aix_free_library_list): Remove.
3793         (library_list_start_library): Update.
3794         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3795         return type.
3796         (solib_aix_get_library_list)
3797         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3798         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3799
3800 2019-07-10  Tom Tromey  <tromey@adacore.com>
3801
3802         * solib-dsbt.c (struct dsbt_info): Add initializers.
3803         (solib_dsbt_pspace_data): Change type.
3804         (dsbt_pspace_data_cleanup): Remove.
3805         (get_dsbt_info, _initialize_dsbt_solib): Update.
3806
3807 2019-07-10  Tom Tromey  <tromey@adacore.com>
3808
3809         * spu-tdep.c (spu_overlay_data): Change type.
3810         (spu_get_overlay_table, spu_overlay_new_objfile)
3811         (_initialize_spu_tdep): Update.
3812
3813 2019-07-10  Tom Tromey  <tromey@adacore.com>
3814
3815         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3816         destructor.
3817         (dbx_objfile_data_key): Change type and declare later.
3818         (DBX_SYMFILE_INFO): Rewrite.
3819         * dbxread.c (dbx_objfile_data_key): Change type.
3820         (dbx_symfile_init): Update.
3821         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3822         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3823         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3824
3825 2019-07-10  Tom Tromey  <tromey@adacore.com>
3826
3827         * jit.c (jit_program_space_key): Change type.  Move lower.
3828         (get_jit_program_space_data): Update.
3829         (jit_program_space_data_cleanup): Remove.
3830         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3831         Update.
3832         (struct jit_program_space_data): Add initializers.
3833
3834 2019-07-10  Tom Tromey  <tromey@adacore.com>
3835
3836         * solib-darwin.c (struct darwin_info): Add initializers.
3837         (solib_darwin_pspace_data): Change type.
3838         (darwin_pspace_data_cleanup): Remove.
3839         (get_darwin_info, _initialize_darwin_solib): Update.
3840
3841 2019-07-10  Tom Tromey  <tromey@adacore.com>
3842
3843         * remote-sim.c (struct sim_inferior_data): Add initializers,
3844         constructor, and destructor.
3845         (sim_inferior_data_key): Change type.  Move lower.
3846         (check_for_duplicate_sim_descriptor): Update.
3847         (get_sim_inferior_data): Use new.  Update.
3848         (~sim_inferior_data_cleanup): Rename from
3849         sim_inferior_data_cleanup.  Simplify.
3850         (gdbsim_close_inferior, simulator_command)
3851         (sim_command_completer, _initialize_remote_sim): Update.
3852         (next_pid, INITIAL_PID): Move earlier.
3853
3854 2019-07-10  Tom Tromey  <tromey@adacore.com>
3855
3856         * python/python-internal.h (create_thread_object): Return
3857         gdbpy_ref.
3858         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3859         * python/py-inferior.c (struct threadlist_entry): Add
3860         constructor.
3861         <thread_obj>: Now a gdbpy_ref.
3862         (thread_to_thread_object): Update.
3863         (add_thread_object): Use new.
3864         (delete_thread_object): Use delete.
3865         (infpy_threads): Update.
3866         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3867         GIL.
3868
3869 2019-07-10  Tom Tromey  <tromey@adacore.com>
3870
3871         * valops.c (value_cast): Specialize error message for Ada.
3872
3873 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3874
3875         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3876
3877 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3878
3879         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3880         bpstat_should_step): Return bool, adjust comments.
3881         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3882         bpstat_should_step): Likewise.
3883
3884 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3885
3886         * features/Makefile: Use feature target descriptions for Arm.
3887         * features/arm/arm-core.c: Generate new file.
3888         * features/arm/arm-fpa.c: Likewise.
3889         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3890         * features/arm/arm-m-profile.c: Likewise.
3891         * features/arm/arm-vfpv2.c: Likewise.
3892         * features/arm/arm-vfpv3.c: Likewise.
3893         * features/arm/xscale-iwmmxt.c: Likewise.
3894         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3895
3896 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3897
3898         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3899         ptrace earlier.
3900
3901 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3902
3903         * features/aarch64-pauth.c: Regenerate.
3904
3905 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3906
3907         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3908         bool.
3909         (bpstat_what): Use false instead of 0.
3910
3911 2019-07-09  Pedro Alves  <palves@redhat.com>
3912
3913         * break-catch-throw.c (is_exception_catchpoint): New.
3914         * breakpoint.c (print_one_breakpoint_location): New parameter
3915         'raw_loc'.  Handle it.  Use
3916         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3917         looking at the breakpoint's type.
3918         (print_one_breakpoint): If handling "maint info breakpoints", also
3919         print locations of exception catchpoints.
3920         * breakpoint.h (is_exception_catchpoint): Declare.
3921
3922 2019-07-09  Pedro Alves  <palves@redhat.com>
3923
3924         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3925         "addr" field.
3926         (allocate_location_exception_catchpoint): New.
3927         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3928         (initialize_throw_catchpoint_ops): Install
3929         allocate_location_exception_catchpoint as allocate_location
3930         method.
3931         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3932         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3933         bp_loc_other.
3934         (breakpoint_address_is_meaningful): Delete.
3935         (bl_address_is_meaningful): New.
3936         (breakpoint_locations_match): Adjust comment.
3937         (bp_location_from_bp_type): New, factored out of...
3938         (bp_location::bp_location(breakpoint *)): ... this.
3939         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3940         factored out of...
3941         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3942         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3943         breakpoint_address_is_meaningful.
3944         (bp_locations_compare): Adjust comment.
3945         (update_global_location_list): Use bl_address_is_meaningful
3946         instead of breakpoint_address_is_meaningful.
3947         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3948         explicit.
3949         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3950         * python/py-breakpoint.c (bppy_get_location): No longer check
3951         whether location is null.
3952
3953 2019-07-09  Pedro Alves  <palves@redhat.com>
3954
3955         PR c++/15468
3956         * breakpoint.c (print_one_breakpoint_location): Remove
3957         single-location assert.
3958
3959 2019-07-09  Tom Tromey  <tom@tromey.com>
3960
3961         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3962         * configure: Rebuild.
3963         * configure.ac: Change common to gdbsupport.
3964         * gdbsupport: Rename from common.
3965         * acinclude.m4: Change common to gdbsupport.
3966         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3967         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3968         gdbsupport.
3969         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3970         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3971         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3972         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3973         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3974         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3975         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3976         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3977         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3978         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3979         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3980         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3981         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3982         coff-pe-read.c, command.h, compile/compile-c-support.c,
3983         compile/compile-c.h, compile/compile-cplus-symbols.c,
3984         compile/compile-cplus-types.c, compile/compile-cplus.h,
3985         compile/compile-loc2c.c, compile/compile.c, completer.c,
3986         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3987         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3988         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3989         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3990         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3991         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3992         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3993         features/aarch64-core.c, features/aarch64-fpu.c,
3994         features/aarch64-pauth.c, features/aarch64-sve.c,
3995         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3996         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3997         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3998         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3999         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4000         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4001         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4002         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4003         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4004         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4005         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4006         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4007         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4008         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4009         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4010         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4011         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4012         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4013         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4014         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4015         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4016         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4017         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4018         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4019         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4020         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4021         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4022         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4023         minsyms.c, mips-linux-tdep.c, namespace.h,
4024         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4025         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4026         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4027         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4028         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4029         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4030         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4031         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4032         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4033         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4034         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4035         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4036         procfs.c, producer.c, progspace.h, psymtab.h,
4037         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4038         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4039         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4040         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4041         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4042         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4043         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4044         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4045         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4046         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4047         target-memory.c, target.c, target.h, target/waitstatus.c,
4048         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4049         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4050         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4051         unittests/array-view-selftests.c,
4052         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4053         unittests/common-utils-selftests.c,
4054         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4055         unittests/format_pieces-selftests.c,
4056         unittests/function-view-selftests.c,
4057         unittests/lookup_name_info-selftests.c,
4058         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4059         unittests/mkdir-recursive-selftests.c,
4060         unittests/observable-selftests.c,
4061         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4062         unittests/parse-connection-spec-selftests.c,
4063         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4064         unittests/scoped_fd-selftests.c,
4065         unittests/scoped_mmap-selftests.c,
4066         unittests/scoped_restore-selftests.c,
4067         unittests/string_view-selftests.c, unittests/style-selftests.c,
4068         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4069         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4070         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4071         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4072         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4073         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4074
4075 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4078         bool value.
4079         (decode_digits_ordinary): Set explicit_line field in sal.
4080         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4081         symtab_and_line that was set on an explicit line number in
4082         assembler code.  Do always update the recorded symtab and line if
4083         we do skip the prologue.
4084
4085 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * breakpoint.c (set_breakpoint_location_function): Remove
4088         explicit_loc parameter.
4089         (momentary_breakpoint_from_master): Update call to
4090         set_breakpoint_location_function.
4091         (add_location_to_breakpoint): Likewise.
4092
4093 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4096         required features based on default bfd type when no specific bfd
4097         is present.
4098
4099 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4100
4101         * NEWS: Mention that GDB printf and eval commands can now print
4102         C-style and Ada-style convenience var strings without
4103         calling the inferior.
4104         * printcmd.c (printf_c_string): Locally print GDB internal var
4105         instead of transiting via the inferior.
4106         (printf_wide_c_string): Likewise.
4107
4108 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4109
4110         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4111
4112 2019-07-04  Tom Tromey  <tom@tromey.com>
4113
4114         PR tui/24724:
4115         * tui/tui-winsource.c (tui_clear_source_content): Update.
4116         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4117         (tui_update_breakpoint_info): Update.
4118         (tui_set_exec_info_content): Update.
4119         * tui/tui-source.c (tui_set_source_content_nil): Update.
4120         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4121         has_break.
4122         * tui/tui-data.h (enum tui_bp_flag): New.
4123         (tui_bp_flags): New enum flags type.
4124         (struct tui_source_element) <break_mode>: Change type.  Rename
4125         from has_break.
4126         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4127         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4128         constants.
4129         * tui/tui-winsource.h: Fix comment.
4130
4131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4132
4133         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4134         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4135         (store_fpregs_to_thread)
4136         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4137         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4138         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4139         (IWMMXT_REGS_SIZE): Add define.
4140         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4141         (fetch_vfp_regs, store_vfp_regs)
4142         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4143         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4144
4145 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4148         defines.
4149         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4150         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4151         (ARM_INT_REGISTER_SIZE): ...to this.
4152         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4153         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4154         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4155         (arm_linux_collect_gregset, supply_nwfpe_register)
4156         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4157         defines.
4158         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4159         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4160         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4161         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4162         (arm_return_in_memory, arm_store_return_value)
4163         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4164         (arm_record_ld_st_multiple): Likewise.
4165         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4166         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4167
4168 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4169
4170         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4171         AARCH64_DISPLACED_MODIFIED_INSNS.
4172         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4173         (aarch64_displaced_step_copy_insn): Likewise.
4174         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4175         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4176         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4177         ARM_DISPLACED_MODIFIED_INSNS.
4178         * arm-tdep.c (arm_gdbarch_init): Likewise.
4179         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4180         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4181         (struct arm_displaced_step_closure): Use
4182         ARM_DISPLACED_MODIFIED_INSNS.
4183
4184 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4185
4186         * features/Makefile: Remove unused xml files.
4187         * features/aarch64.xml: Remove.
4188         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4189         * features/i386/amd64-avx-avx512.xml: Remove.
4190         * features/i386/amd64-avx-linux.xml: Remove.
4191         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4192         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4193         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4194         * features/i386/amd64-avx-mpx.xml: Remove.
4195         * features/i386/amd64-avx.xml: Remove.
4196         * features/i386/amd64-linux.xml: Remove.
4197         * features/i386/amd64-mpx-linux.xml: Remove.
4198         * features/i386/amd64-mpx.xml: Remove.
4199         * features/i386/amd64.xml: Remove.
4200         * features/i386/i386-avx-avx512-linux.xml: Remove.
4201         * features/i386/i386-avx-avx512.xml: Remove.
4202         * features/i386/i386-avx-linux.xml: Remove.
4203         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4204         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4205         * features/i386/i386-avx-mpx-linux.xml: Remove.
4206         * features/i386/i386-avx-mpx.xml: Remove.
4207         * features/i386/i386-avx.xml: Remove.
4208         * features/i386/i386-linux.xml: Remove.
4209         * features/i386/i386-mmx-linux.xml: Remove.
4210         * features/i386/i386-mmx.xml: Remove.
4211         * features/i386/i386-mpx-linux.xml: Remove.
4212         * features/i386/i386-mpx.xml: Remove.
4213         * features/i386/i386.xml: Remove.
4214         * features/i386/x32-avx-avx512-linux.xml: Remove.
4215         * features/i386/x32-avx-linux.xml: Remove.
4216         * features/i386/x32-linux.xml: Remove.
4217
4218 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4219
4220         * regformats/aarch64.dat: Remove.
4221         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4222         * regformats/i386/amd64-avx-linux.dat: Remove.
4223         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4224         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4225         * regformats/i386/amd64-linux.dat: Remove.
4226         * regformats/i386/amd64-mpx-linux.dat: Remove.
4227         * regformats/i386/amd64.dat: Remove.
4228         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4229         * regformats/i386/i386-avx-linux.dat: Remove.
4230         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4231         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4232         * regformats/i386/i386-linux.dat: Remove.
4233         * regformats/i386/i386-mmx-linux.dat: Remove.
4234         * regformats/i386/i386-mpx-linux.dat: Remove.
4235         * regformats/i386/i386.dat: Remove.
4236         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4237         * regformats/i386/x32-avx-linux.dat: Remove.
4238         * regformats/i386/x32-linux.dat: Remove.
4239
4240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4241
4242         * aarch64-tdep.c: Remove xml self tests.
4243         * amd64-linux-tdep.c: Likewise.
4244         * amd64-tdep.c: Likewise.
4245         * i386-linux-tdep.c: Likewise.
4246         * i386-tdep.c: Likewise.
4247
4248 2019-07-03  Pedro Alves  <palves@redhat.com>
4249
4250         PR cli/24732
4251         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4252         (pipe_cmd_option_defs): New.
4253         (make_pipe_cmd_options_def_group): New.
4254         (pipe_command): Use gdb::option::process_options.
4255         (pipe_command_completer): New function.
4256         (_initialize_cli_cmds): Install completer for "pipe" command.
4257
4258 2019-07-03  Pedro Alves  <palves@redhat.com>
4259
4260         * cli/cli-option.c (union option_value) <string>: New field.
4261         (struct option_def_and_value): Add ctor, move ctor, dtor and
4262         use DISABLE_COPY_AND_ASSIGN.
4263         (option_def_and_value::clear_value): New.
4264         (parse_option, save_option_value_in_ctx, get_val_type_str)
4265         (add_setshow_cmds_for_options): Handle var_string.
4266         * cli-option.h (union option_def::var_address) <string>: New
4267         field.
4268         (struct string_option_def): New.
4269         * maint-test-options.c (struct test_options_opts): Add default
4270         ctor and use DISABLE_COPY_AND_ASSIGN.
4271         <string_opt>: New field.
4272         (test_options_opts::~test_options_opts): New.
4273         (test_options_opts::dump): Also dump "-string".
4274         (test_options_option_defs): Install "string.
4275
4276 2019-07-03  Pedro Alves  <palves@redhat.com>
4277
4278         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4279         option_value with a null enumeration.
4280         (complete_options): Save the option values in the context.
4281         (save_option_value_in_ctx): New, factored out from ...
4282         (process_options): ... here.
4283         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4284         of the function.
4285         * maint-test-options.c (test_options_opts::dump): New, factored
4286         out from ...
4287         (maintenance_test_options_command_mode): ... here.
4288         (maintenance_test_options_command_completion_result): Delete.
4289         (maintenance_test_options_command_completion_text): Update
4290         comment.
4291         (maintenance_show_test_options_completion_result): Change
4292         prototype.  Just print
4293         maintenance_test_options_command_completion_text.
4294         (save_completion_result): New.
4295         (maintenance_test_options_completer_mode): Pass options context to
4296         complete_options, and then save a dump.
4297         (_initialize_maint_test_options): Use add_cmd to install "maint
4298         show test-options-completion-result".
4299
4300 2019-07-03  Pedro Alves  <palves@redhat.com>
4301
4302         * NEWS (New commands): Mention "with" and "maint with".
4303         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4304         (with_command, with_command_completer): New.
4305         (pipe_command): Adjust to new repeat_previous
4306         interface.
4307         (_initialize_cli_cmds): Install the "with" command and its "w"
4308         alias.
4309         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4310         declarations.
4311         * cli/cli-setshow.c (parse_cli_var_uinteger)
4312         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4313         argument strings for all var_types.
4314         (get_setshow_command_value_string): New, factored out from ...
4315         (do_show_command): ... this.
4316         * cli/cli-setshow.h: Include <string>.
4317         (get_setshow_command_value_string): Declare.
4318         * command.h (repeat_previous): Now returns const char *.  Adjust
4319         comment.
4320         * maint.c: Include "cli/cli-cmds.h".
4321         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4322         (_initialize_maint_cmds): Register the "maintenance with" command.
4323         * top.c (repeat_previous): Move bits from pipe_command here:
4324         Return the saved command line, if any; error out if there's no
4325         command to relaunch.
4326
4327 2019-07-03  Pedro Alves  <palves@redhat.com>
4328
4329         * NEWS (New commands): Mention "maint set/show test-settings"
4330         instead of "maint test-settings".
4331         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4332         (maintenance_test_settings_set_list): Rename to ...
4333         (maintenance_set_test_settings_list): ... this.
4334         (maintenance_test_settings_show_list): Rename to  ...
4335         (maintenance_show_test_settings_list): ... this.
4336         (maintenance_test_settings_cmd): Delete.
4337         (maintenance_test_settings_set_cmd): ...
4338         (maintenance_set_test_settings_cmd): ... this.
4339         (maintenance_test_settings_show_cmd): ...
4340         (maintenance_show_test_settings_cmd): ... this.
4341         (maintenance_test_settings_show_value_cmd):
4342         (maintenance_show_test_settings_value_cmd): ... this.
4343         (_initialize_maint_test_settings): No longer install the "maint
4344         test-settings" prefix command.  Rename "maint test-settings set"
4345         to "maint set test-settings", and "maint test-settings show" to
4346         "maint show test-settings".  Adjust all subcommands.
4347
4348 2019-07-03  Pedro Alves  <palves@redhat.com>
4349
4350         * maint-test-settings.c: Fix file's intro comment.  Replace all
4351         references to "test-options" with references to "test-settings",
4352         in comments.
4353
4354 2019-07-03  Pedro Alves  <palves@redhat.com>
4355
4356         * maint-test-settings.c (maintenance_test_settings_xxx)
4357         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4358         New.
4359         (maintenance_test_settings_enums): Use them.
4360         (maintenance_test_settings_enum): Default to
4361         maintenance_test_settings_xxx.
4362         (_initialize_maint_test_settings): Initialize
4363         MAINTENANCE_TEST_SETTINGS_FILENAME.
4364
4365 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4366
4367         * breakpoint.h (remove_breakpoints_inf): Change return type to
4368         void, move function documentation here.
4369         * breakpoint.c (remove_breakpoints_inf): Change return type to
4370         void, move function documentation to header.
4371
4372 2019-07-02  Pedro Alves  <palves@redhat.com>
4373
4374         * NEWS (Completion improvements): Mention "info threads".
4375         * thread.c (struct info_threads_opts, info_threads_option_defs)
4376         (make_info_threads_options_def_group): New.
4377         (info_threads_command): Use gdb::option::process_options.
4378         (info_threads_command_completer): New.
4379         (_initialize_thread): Use gdb::option::build_help to build the
4380         help text for "info threads".
4381
4382 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4383
4384         * defs.h (generic_load): Move from here...
4385         * symfile.h (generic_load): ... to here.  Rename name parameter
4386         to args.
4387         * symfile.c (generic_load): Add comment.
4388
4389 2019-07-01  Tom Tromey  <tromey@adacore.com>
4390
4391         * dwarf2read.c
4392         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4393         declaration of without_params.  Fix formatting.
4394
4395 2019-07-01  Tom Tromey  <tromey@adacore.com>
4396
4397         * ada-exp.y (find_primitive_type): Update.
4398         * ada-lang.h (ada_lookup_symbol): Update.
4399         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4400         parameter.
4401         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4402
4403 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4404
4405         PR breakpoints/24541
4406         * gdbarch.c: Regenerate.
4407         * gdbarch.h: Regenerate.
4408         * gdbarch.sh: Add 'stap_adjust_register'.
4409         * i386-tdep.c: Include '<unordered_set>'.
4410         (i386_stap_adjust_register): New function.
4411         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4412         * stap-probe.c (stap_parse_register_operand): Call
4413         'gdbarch_stap_adjust_register'.
4414
4415 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4416
4417         PR python/24742
4418         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4419         * python/python.c (do_start_initialization): Use 'xmalloc'
4420         instead of 'PyMem_Malloc'.
4421
4422 2019-06-28  Tom Tromey  <tromey@adacore.com>
4423
4424         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4425         for Ada.
4426
4427 2019-06-27  Tom Tromey  <tromey@adacore.com>
4428
4429         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4430         objfile_key.
4431         (arm_find_mapping_symbol, arm_record_special_symbol)
4432         (_initialize_arm_tdep): Update.
4433         (arm_objfile_data_free): Remove.
4434
4435 2019-06-27  Tom Tromey  <tromey@adacore.com>
4436
4437         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4438         to cp_print_static_field.
4439
4440 2019-06-26  Tom Tromey  <tromey@adacore.com>
4441
4442         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4443         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4444         declare.
4445
4446 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4447
4448         * features/aarch64-core.c (create_feature_aarch64_core):
4449         Regenerate.
4450         * features/aarch64-core.xml: Add cpsr flags.
4451
4452 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4453
4454         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4455         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4456
4457 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4458
4459         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4460         field.
4461         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4462         use.
4463         (arm_record_special_symbol): Don't insert new symbol in sorted
4464         position, push it at the end.
4465
4466 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4467
4468         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4469         (arm_mapping_symbol_s): Remove.
4470         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4471         (arm_mapping_symbol_vec): New typedef.
4472         (struct arm_per_objfile): Add constructor.
4473         <section_maps>: Change type to
4474         std::unique_ptr<arm_mapping_symbol_vec[]>.
4475         (arm_compare_mapping_symbols): Remove.
4476         (arm_find_mapping_symbol): Adjust to section_maps type change.
4477         (arm_objfile_data_free): Call delete on arm_per_objfile.
4478         (arm_record_special_symbol): Adjust to section_maps type change.
4479         Allocate arm_per_objfile with new.
4480
4481 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4482
4483         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4484         with the command prefix.
4485
4486 2019-06-25  Tom Tromey  <tom@tromey.com>
4487
4488         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4489         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4490
4491 2019-06-25  Tom Tromey  <tom@tromey.com>
4492
4493         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4494         type.
4495         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4496         protected.
4497
4498 2019-06-25  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-winsource.c
4501         (tui_source_window_base::set_is_exec_point_at): Add check against
4502         LOA_ADDRESS.
4503
4504 2019-06-25  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-source.c (tui_set_source_content): Don't check before
4507         xfree.
4508         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4509
4510 2019-06-25  Tom Tromey  <tom@tromey.com>
4511
4512         * tui/tui-winsource.h (tui_update_source_window_as_is)
4513         (tui_alloc_source_buffer, tui_line_is_displayed)
4514         (tui_addr_is_displayed): Change type of win_info.
4515         * tui/tui-winsource.c (tui_update_source_window_as_is)
4516         (tui_clear_source_content, tui_show_source_line)
4517         (tui_show_source_content, tui_source_window_base::refill)
4518         (tui_source_window_base::set_is_exec_point_at)
4519         (tui_source_window_base::set_is_exec_point_at)
4520         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4521         (tui_alloc_source_buffer, tui_line_is_displayed)
4522         (tui_addr_is_displayed): Change type of win_info.  Update.
4523         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4524         (tui_source_window_base::do_make_visible_with_new_height):
4525         Update.
4526         * tui/tui-source.c (tui_set_source_content)
4527         (tui_set_source_content_nil)
4528         (tui_source_window::do_scroll_vertical): Update.
4529         * tui/tui-layout.c (show_layout): Update.
4530         * tui/tui-disasm.c (tui_set_disassem_content)
4531         (tui_disasm_window::do_scroll_vertical): Update.
4532         * tui/tui-data.h (tui_win_content): Remove.
4533         (struct tui_gen_win_info) <content, content_size>: Remove.
4534         (struct tui_source_element): Add initializers and destructor.
4535         (union tui_which_element, struct tui_win_element): Remove.
4536         (struct tui_source_window_base) <content>: New field.
4537         (struct tui_data_window): Remove destructor.
4538         (tui_alloc_content, tui_free_win_content)
4539         (tui_free_all_source_wins_content): Don't declare.
4540         * tui/tui-data.c (tui_initialize_static_data): Update.
4541         (init_content_element, tui_alloc_content): Remove.
4542         (~tui_gen_win_info): Update.
4543         (~tui_data_window, tui_free_all_source_wins_content)
4544         (tui_free_win_content, free_content, free_content_elements):
4545         Remove.
4546
4547 2019-06-25  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui-winsource.h (tui_clear_source_content)
4550         (tui_erase_source_content, tui_show_source_content): Change type
4551         of win_info.
4552         * tui/tui-winsource.c (tui_clear_source_content)
4553         (tui_erase_source_content, tui_show_source_content): Change type
4554         of win_info.
4555         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4556         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4557         win_info.
4558         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4559         win_info.
4560         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4561
4562 2019-06-25  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-winsource.c (tui_clear_source_content)
4565         (tui_source_window_base::set_is_exec_point_at): Update.
4566         * tui/tui-source.c (tui_set_source_content_nil): Update.
4567         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4568         a bool.
4569         * tui/tui-data.c (init_content_element): Update.
4570
4571 2019-06-25  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4574         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4575         * tui/tui-layout.c (init_and_make_win): Update.
4576         * tui/tui.h (enum tui_win_type): Update.
4577         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4578         tui_win_is_auxillary.
4579         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4580         tui_win_is_auxillary.
4581
4582 2019-06-25  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4585         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4586         (tui_delete_data_content_windows, tui_display_all_data)
4587         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4588         Update.
4589         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4590         * tui/tui-regs.c (tui_last_regs_line_no)
4591         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4592         (tui_show_registers): Update.
4593         (tui_show_register_group): Return void.  Update.
4594         (tui_display_registers_from, tui_display_reg_element_at_line)
4595         (tui_display_registers_from_line, tui_check_register_values):
4596         Update.
4597         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4598         member.
4599         (struct tui_data_window) <regs_content>: Now a std::vector.
4600         <regs_content_count>: Remove.
4601         (tui_add_content_elements, tui_free_data_content): Don't declare.
4602         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4603         (init_content_element): Remove DATA_WIN case.  Add assert.
4604         (tui_add_content_elements): Remove.
4605         (tui_data_window): Update.
4606         (tui_free_data_content): Remove.
4607         (free_content_elements): Remove DATA_WIN case.
4608
4609 2019-06-25  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-data.c (tui_data_item_window): Update.
4612         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4613         * tui/tui-windata.c (tui_display_all_data)
4614         (tui_display_data_from_line): Update.
4615         (tui_check_data_values): Remove.
4616         * tui/tui-regs.c (tui_show_register_group)
4617         (tui_display_reg_element_at_line): Update.
4618         * tui/tui-hooks.c (tui_register_changed)
4619         (tui_refresh_frame_and_register_information): Call
4620         tui_check_register_values.
4621         * tui/tui-data.h (struct tui_data_window) <data_content,
4622         data_content_count, data_type>: Remove.
4623         (enum tui_data_type): Remove.
4624
4625         * tui/tui-data.c (tui_data_window::clear_detail)
4626         (~tui_data_window): Update.
4627
4628 2019-06-25  Tom Tromey  <tom@tromey.com>
4629
4630         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4631         declare.
4632         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4633         Rename from tui_first_data_item_displayed.  Update.
4634         (tui_data_window::refresh_all)
4635         (tui_data_window::do_scroll_vertical): Update.
4636         * tui/tui-data.h (struct tui_data_window)
4637         <first_data_item_displayed>: Declare new method.
4638
4639 2019-06-25  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4642         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4643         contents...
4644         (tui_initialize_static_data): ...here.
4645
4646 2019-06-25  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4649         (tui_display_registers_from, tui_check_register_values): Update.
4650         (tui_display_register): Remove win_info parameter; update.
4651         (tui_get_register): Change type of parameters.
4652         * tui/tui-data.h (struct tui_data_element): Remove.
4653         (union tui_which_element) <data>: Remove.
4654         <data_window>: Change type.
4655         (struct tui_data_item_window): New.
4656         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4657         case.  Add assert.
4658         (~tui_data_item_window): New destructor.
4659         (free_content_elements): Remove DATA_ITEM_WIN case.
4660
4661 2019-06-25  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4664         Remove.
4665
4666 2019-06-25  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-data.h (struct tui_command_element): Remove.
4669         (union tui_which_element) <command>: Remove.
4670         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4671         assert.
4672         (free_content_elements): Remove CMD_WIN case.
4673
4674 2019-06-25  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-layout.c (tui_set_layout): Update.
4677         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4678         * tui/tui-data.c (layout_def): Update.
4679
4680 2019-06-25  Tom Tromey  <tom@tromey.com>
4681
4682         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4683         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4684         (tui_source_window_base::set_new_height): Update.
4685         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4686         Update.
4687         (tui_set_locator_fullname, tui_set_locator_info)
4688         (tui_show_frame_info): Update.
4689         * tui/tui-source.c (tui_set_source_content)
4690         (tui_source_is_displayed): Update.
4691         * tui/tui-layout.c (show_source_disasm_command, show_data)
4692         (show_source_or_disasm_and_command): Update.
4693         * tui/tui-disasm.c (tui_set_disassem_content)
4694         (tui_get_begin_asm_address): Update.
4695         * tui/tui-data.h (struct tui_locator_element): Remove.
4696         (union tui_which_element) <locator>: Remove.
4697         (struct tui_locator_window): New.
4698         (tui_locator_win_info_ptr): Change return type.
4699         * tui/tui-data.c (_locator): Change type.
4700         (tui_locator_win_info_ptr): Change return type.
4701         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4702         (tui_alloc_content): Add assert.
4703
4704 2019-06-25  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-winsource.c
4707         (tui_exec_info_window::maybe_allocate_content): New method.
4708         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4709         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4710         (make_source_or_disasm_window): Add cast.
4711         * tui/tui-data.h (union tui_which_element) <simple_string>:
4712         Remove.
4713         (struct tui_source_info): New.
4714         (struct tui_source_window_base) <execution_info>: Change type.
4715         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4716         case, and add assert.
4717         (tui_alloc_content): Add assert.
4718
4719 2019-06-25  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4722         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4723         * tui/tui-data.c (tui_alloc_win_info): Remove.
4724
4725 2019-06-25  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4728         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4729         can_highlight.
4730
4731 2019-06-25  Tom Tromey  <tom@tromey.com>
4732
4733         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4734         make_visible_with_new_height method.
4735         (tui_win_info::make_visible_with_new_height): New method.
4736         (tui_source_window_base::do_make_visible_with_new_height)
4737         (tui_data_window::do_make_visible_with_new_height)
4738         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4739         (make_visible_with_new_height): Remove.
4740         (tui_resize_all, tui_adjust_win_heights): Use
4741         make_visible_with_new_height method.
4742         * tui/tui-data.h (struct tui_win_info)
4743         <do_make_visible_with_new_height, make_visible_with_new_height>:
4744         New methods.
4745         (struct tui_source_window_base, struct tui_data_window)
4746         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4747         methods.
4748
4749 2019-06-25  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4752         method.
4753         (update_tab_width): Call update_tab_width method.
4754         * tui/tui-data.h (struct tui_win_info)
4755         (struct tui_source_window_base) <update_tab_width>: New methods.
4756
4757 2019-06-25  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4760         parameter.
4761         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4762         parameter.
4763         (tui_gen_win_info::make_visible): Update.
4764         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4765         parameter.
4766         * tui/tui-data.h (enum tui_box): New enum.
4767         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4768
4769 2019-06-25  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4772         init_and_make_win for EXEC_INFO_WIN.
4773         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4774         longer inline.
4775         (struct tui_win_info) <~tui_win_info>: Inline.
4776         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4777         Don't declare.
4778         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4779         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4780         Remove.
4781         (tui_initialize_static_data): Update.
4782         (~tui_gen_win_info): Handle more cleanup here.
4783         (~tui_source_window_base): Delete "execution_info".
4784         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4785
4786 2019-06-25  Tom Tromey  <tom@tromey.com>
4787
4788         * tui/tui-layout.c (make_command_window): Don't set
4789         can_highlight.
4790         (show_source_disasm_command): Call the reset method.
4791         (show_data): Don't set can_highlight.  Call the reset method.
4792         (tui_gen_win_info::reset): Rename from init_gen_win_info
4793         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4794         (show_source_or_disasm_and_command): Call the reset method.
4795         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4796         (struct tui_cmd_window): Set can_highlight.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4801         from make_visible.
4802         (tui_make_visible, tui_make_invisible): Rewrite.
4803         (tui_win_info::make_visible): Remove.
4804         (tui_source_window_base::make_visible): Update.
4805         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4806         method.  Moved from...
4807         (struct tui_win_info) <make_visible>: ...here.
4808
4809 2019-06-25  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-winsource.c
4812         (tui_source_window_base::do_scroll_horizontal): Remove direction
4813         parameter.
4814         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4815         direction parameter.
4816         * tui/tui-win.c (tui_win_info::forward_scroll)
4817         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4818         (tui_win_info::right_scroll): Update.
4819         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4820         direction parameter.
4821         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4822         direction parameter.
4823         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4824         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4825         Remove direction parameter.
4826         (struct tui_source_window_base, struct tui_source_window)
4827         (struct tui_disasm_window, struct tui_data_window)
4828         (struct tui_cmd_window): Update.
4829
4830 2019-06-25  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-winsource.h (tui_set_exec_info_content)
4833         (tui_show_exec_info_content, tui_erase_exec_info_content)
4834         (tui_clear_exec_info_content, tui_update_exec_info): Change
4835         argument to tui_source_window_base.
4836         * tui/tui-winsource.c (tui_set_exec_info_content)
4837         (tui_show_exec_info_content, tui_erase_exec_info_content)
4838         (tui_clear_exec_info_content, tui_update_exec_info): Change
4839         argument to tui_source_window_base.
4840
4841 2019-06-25  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4844         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4849         check.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4854         type to void.
4855         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4856         type to void.
4857         * tui/tui-source.c (tui_set_source_content): Update.
4858         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4859
4860 2019-06-25  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-win.c (window_name_completer, tui_set_focus)
4863         (tui_all_windows_info): Use name method.
4864         * tui/tui-data.h (struct tui_gen_win_info)
4865         (struct tui_source_window, struct tui_disasm_window)
4866         (struct tui_data_window, struct tui_cmd_window) <name>: New
4867         method.
4868         (tui_win_name): Don't declare.
4869         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4870         (tui_win_name): Remove.
4871
4872 2019-06-25  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-winsource.h (tui_update_source_window)
4875         (tui_update_source_window_as_is): Change parameter type.
4876         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4877         to be a tui_source_window_base.
4878         (tui_update_source_window_as_is): Likewise.
4879         * tui/tui-win.c (make_visible_with_new_height): Update.
4880
4881 2019-06-25  Tom Tromey  <tom@tromey.com>
4882
4883         * tui/tui-winsource.c (tui_erase_source_content)
4884         (tui_show_source_content, tui_show_exec_info_content)
4885         (tui_erase_exec_info_content): Use refresh_window method.
4886         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4887         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4888         from tui_refresh_win.
4889         (tui_data_window::refresh_window): New method.
4890         (tui_win_info::refresh, tui_source_window_base::refresh)
4891         (tui_refresh_all): Use refresh_window method.
4892         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4893         method.
4894         * tui/tui-regs.c (tui_display_register): Call refresh_window
4895         method.
4896         * tui/tui-layout.c (show_source_disasm_command)
4897         (show_source_or_disasm_and_command): Call refresh_window method.
4898         * tui/tui-data.h (struct tui_gen_win_info)
4899         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4900         New method.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui.c (tui_rl_other_window, tui_enable)
4905         (tui_is_window_visible, tui_get_command_dimension): Update.
4906         * tui/tui-winsource.c (tui_update_source_window_as_is)
4907         (tui_clear_source_content, tui_erase_source_content)
4908         (tui_show_source_line, tui_source_window_base::refill)
4909         (tui_source_window_base::do_scroll_horizontal)
4910         (tui_source_window_base::set_is_exec_point_at)
4911         (tui_update_breakpoint_info, tui_set_exec_info_content)
4912         (tui_alloc_source_buffer, tui_line_is_displayed)
4913         (tui_addr_is_displayed): Update.
4914         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4915         (tui_check_and_display_highlight_if_needed)
4916         (tui_win_info::make_visible, tui_win_info::refresh)
4917         (tui_refresh_all): Update.
4918         * tui/tui-windata.c (tui_first_data_item_displayed)
4919         (tui_delete_data_content_windows, tui_erase_data_content)
4920         (tui_display_all_data, tui_data_window::refresh_all)
4921         (tui_check_data_values): Update.
4922         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4923         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4924         (tui_win_info::backward_scroll, tui_refresh_all_win)
4925         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4926         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4927         (tui_source_window_base::set_new_height)
4928         (tui_data_window::set_new_height)
4929         (make_invisible_and_set_new_height)
4930         (make_visible_with_new_height, new_height_ok)
4931         (parse_scrolling_args): Update.
4932         * tui/tui-stack.c (tui_show_frame_info): Update.
4933         * tui/tui-source.c (tui_set_source_content)
4934         (tui_set_source_content_nil, tui_source_is_displayed)
4935         (tui_source_window::do_scroll_vertical): Update.
4936         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4937         (tui_display_registers_from, tui_display_reg_element_at_line)
4938         (tui_check_register_values, tui_reg_command): Update.
4939         * tui/tui-layout.c (tui_default_win_height)
4940         (show_source_disasm_command, show_data, init_and_make_win)
4941         (show_source_or_disasm_and_command): Update.
4942         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4943         (tui_redisplay_readline, tui_mld_flush)
4944         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4945         (tui_getc): Update.
4946         * tui/tui-disasm.c (tui_set_disassem_content)
4947         (tui_disasm_window::do_scroll_vertical): Update.
4948         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4949         Now virtual.
4950         (struct tui_win_info): Derive from tui_gen_win_info.
4951         <~tui_win_info>: Mark as override.
4952         <generic>: Remove member.
4953         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4954         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4955         (~tui_data_window, ~tui_win_info)
4956         (tui_free_all_source_wins_content): Update.
4957         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4958
4959 2019-06-25  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-layout.c (init_and_make_win): Use new.
4962         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4963         destructor, initializers.
4964         (tui_alloc_generic_win_info): Don't declare.
4965         * tui/tui-data.c (_locator): Add argument to constructor.
4966         (source_win, disasm_win): New globals.
4967         (exec_info): Remove.
4968         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4969         Update.
4970         (tui_alloc_generic_win_info): Remove.
4971         (init_content_element): Use new.
4972         (tui_win_info::tui_win_info): Update.
4973         (free_content_elements) <case DATA_WIN>: Use delete.
4974
4975 2019-06-25  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4978         * tui/tui-windata.c (tui_first_data_item_displayed)
4979         (tui_delete_data_content_windows): Update.
4980         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4981         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4982         (tui_display_registers_from, tui_check_register_values): Update.
4983         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4984         pointer.
4985         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4986         window.
4987         (tui_free_data_content): Update.
4988         (free_content_elements) <case DATA_WIN>: Free the window.
4989
4990 2019-06-25  Tom Tromey  <tom@tromey.com>
4991
4992         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4993         Update.
4994         * tui/tui-layout.c (make_command_window)
4995         (show_source_disasm_command, show_data, init_and_make_win)
4996         (show_source_or_disasm_and_command): Update.
4997         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4998         method.
4999         <can_highight, is_highlighted>: Now bool.
5000         (tui_set_win_highlight): Don't declare.
5001         * tui/tui-data.c (tui_set_win_highlight): Remove.
5002
5003 2019-06-25  Tom Tromey  <tom@tromey.com>
5004
5005         * tui/tui-wingeneral.c (make_visible): Remove check of window
5006         type.
5007
5008 2019-06-25  Tom Tromey  <tom@tromey.com>
5009
5010         * tui/tui-win.c (tui_win_info::max_height)
5011         (tui_cmd_window::max_height): New methods.
5012         (new_height_ok): Call max_height.
5013         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5014         <max_height>: New method.
5015
5016 2019-06-25  Tom Tromey  <tom@tromey.com>
5017
5018         * tui/tui-win.c (tui_source_window_base::set_new_height)
5019         (tui_data_window::set_new_height): New methods.
5020         (make_invisible_and_set_new_height): Call set_new_height method.
5021         * tui/tui-data.h (struct tui_win_info)
5022         (struct tui_source_window_base, struct tui_data_window)
5023         <set_new_height>: New method.
5024
5025 2019-06-25  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5028         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5029         tui_refresh_data_win.
5030         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5031         method.
5032         (tui_refresh_all_win): Call the refresh_all method.
5033         (tui_set_focus): Likewise.
5034         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5035         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5036         Likewise.
5037
5038 2019-06-25  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-winsource.h (tui_refill_source_window)
5041         (tui_set_is_exec_point_at): Don't declare.
5042         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5043         (tui_source_window_base::refill): Rename from
5044         tui_refill_source_window.
5045         (tui_source_window_base::do_scroll_horizontal): Update.
5046         (tui_source_window_base::set_is_exec_point_at): Rename from
5047         tui_set_is_exec_point_at.
5048         (tui_update_all_breakpoint_info): Update.
5049         * tui/tui-stack.c (tui_show_frame_info): Update.
5050         * tui/tui-layout.c (show_data): Add cast.
5051         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5052         * tui/tui-data.h (struct tui_source_window_base) <refill,
5053         set_is_exec_point_at>: New methods.
5054         (tui_source_windows, tui_add_to_source_windows): Update types.
5055         (tui_add_to_source_windows): Remove redundant declaration.
5056         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5057         (tui_source_windows): Change return type.
5058         (tui_clear_source_windows_detail): Update.
5059         (tui_add_to_source_windows): Change type of parameter.
5060         (tui_free_all_source_wins_content): Update.
5061
5062 2019-06-25  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-wingeneral.c (tui_win_info::refresh)
5065         (tui_source_window_base::refresh): New methods.
5066         (tui_refresh_all): Call the refresh method.
5067         * tui/tui-data.h (struct tui_win_info)
5068         (struct tui_source_window_base) <refresh>: New method.
5069
5070 2019-06-25  Tom Tromey  <tom@tromey.com>
5071
5072         * tui/tui.h (tui_is_window_visible): Return bool.
5073         * tui/tui.c (tui_is_window_visible): Return bool.
5074         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5075         (tui_make_visible, tui_make_invisible)
5076         (tui_win_info::make_visible)
5077         (tui_source_window_base::make_visible, make_all_visible)
5078         (tui_make_all_visible, tui_make_all_invisible): Update.
5079         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5080         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5081         bool.
5082         (struct tui_win_info, struct tui_source_window_base)
5083         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5084         * tui/tui-data.c (tui_init_generic_part): Update.
5085
5086 2019-06-25  Tom Tromey  <tom@tromey.com>
5087
5088         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5089         (tui_source_window_base::make_visible): New methods.
5090         (make_all_visible): Make method call.
5091         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5092         (struct tui_source_window_base, struct tui_cmd_window): Override
5093         make_visible.
5094         (tui_win_is_source_type): Don't declare.
5095         * tui/tui-data.c (tui_win_is_source_type): Remove.
5096
5097 2019-06-25  Tom Tromey  <tom@tromey.com>
5098
5099         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5100         NULL check.
5101
5102 2019-06-25  Tom Tromey  <tom@tromey.com>
5103
5104         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5105         Inline constructor.  Add initializers for members.
5106         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5107         constructors; now inline in class.
5108
5109 2019-06-25  Tom Tromey  <tom@tromey.com>
5110
5111         * tui/tui-regs.c (tui_show_registers): Update.
5112         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5113         bool.
5114         * tui/tui-data.c (tui_data_window::clear_detail)
5115         (tui_data_window): Update.
5116
5117 2019-06-25  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-windata.c (tui_display_all_data)
5120         (tui_display_data_from_line, tui_display_data_from)
5121         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5122         Update.
5123         * tui/tui-regs.c (tui_last_regs_line_no)
5124         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5125         (tui_show_registers, tui_show_register_group)
5126         (tui_display_registers_from, tui_display_reg_element_at_line)
5127         (tui_display_registers_from_line, tui_check_register_values)
5128         (tui_reg_next, tui_reg_prev): Update.
5129         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5130         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5131         tui_data_window.
5132         (struct tui_win_info) <detail>: Remove.  Add new fields from
5133         tui_data_info.
5134         (TUI_DATA_WIN): Add cast.
5135         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5136         (~tui_data_window): Simplify.
5137
5138 2019-06-25  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-layout.c (show_source_disasm_command)
5141         (show_source_or_disasm_and_command): Update.
5142         * tui/tui-io.c (update_cmdwin_start_line)
5143         (tui_redisplay_readline): Update.
5144         * tui/tui-data.h (struct tui_command_info): Remove.
5145         (struct tui_win_info) <detail>: Remove command_info member.
5146         (struct tui_data_window) <start_line>: New member, from
5147         tui_command_info.
5148         (TUI_CMD_WIN): Add casts.
5149
5150 2019-06-25  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-winsource.c (tui_update_source_window)
5153         (tui_refill_source_window)
5154         (tui_source_window_base::do_scroll_horizontal)
5155         (tui_update_breakpoint_info, tui_set_exec_info_content)
5156         (tui_show_exec_info_content, tui_erase_exec_info_content)
5157         (tui_clear_exec_info_content): Update.
5158         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5159         Update.
5160         * tui/tui-win.c (make_invisible_and_set_new_height)
5161         (make_visible_with_new_height): Update.
5162         * tui/tui-source.c (tui_set_source_content)
5163         (tui_show_symtab_source): Update.
5164         * tui/tui-layout.c (extract_display_start_addr)
5165         (show_source_disasm_command, show_data)
5166         (make_source_or_disasm_window)
5167         (show_source_or_disasm_and_command): Update.
5168         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5169         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5170         "gdbarch".
5171         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5172         to tui_source_window_base.
5173         (struct tui_win_info) <detail>: Remove source_info member.
5174         (struct tui_source_window_base) <has_locator>: Inline.
5175         Move contents from tui_source_info; rename has_locator member to
5176         m_has_locator.
5177         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5178         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5179         header file.
5180         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5181         Simplify.
5182         (tui_free_all_source_wins_content): Cast to
5183         tui_source_window_base.
5184
5185 2019-06-25  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui-win.c (make_invisible_and_set_new_height)
5188         (make_visible_with_new_height): Call has_locator method.
5189         * tui/tui-layout.c (show_source_disasm_command, show_data)
5190         (show_source_or_disasm_and_command): Update for bool change.
5191         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5192         (tui_win_info) <has_locator>: New method.
5193         (struct tui_source_window_base) <has_locator>: New method.
5194         (tui_win_has_locator): Don't declare.
5195         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5196         from tui_win_has_locator.
5197         (tui_source_window_base): Use false, not FALSE.
5198
5199 2019-06-25  Tom Tromey  <tom@tromey.com>
5200
5201         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5202         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5203         clear_detail method directly.
5204         (tui_clear_win_detail): Remove.
5205
5206 2019-06-25  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5209         "this", not TUI_DISASM_WIN.
5210
5211 2019-06-25  Tom Tromey  <tom@tromey.com>
5212
5213         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5214         declare.
5215         * tui/tui-winsource.c
5216         (tui_source_window_base::do_scroll_horizontal): Rename from
5217         tui_horizontal_source_scroll.
5218         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5219         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5220         from tui_vertical_data_scroll.
5221         * tui/tui-win.h (tui_scroll): Don't declare.
5222         * tui/tui-win.c (tui_win_info::forward_scroll)
5223         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5224         (tui_win_info::right_scroll): Rename and update.
5225         (tui_scroll_forward_command, tui_scroll_backward_command)
5226         (tui_scroll_left_command, tui_scroll_right_command): Update.
5227         (tui_scroll): Remove.
5228         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5229         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5230         from tui_vertical_source_scroll.
5231         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5232         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5233         from tui_vertical_disassem_scroll.
5234         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5235         do_scroll_horizontal>: New methods.
5236         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5237         Likewise.
5238         (struct tui_source_window_base): Add do_scroll_horizontal.
5239         (struct tui_source_window, struct tui_disasm_window): Add
5240         do_scroll_vertical.
5241         (struct tui_data_window, struct tui_cmd_window): Add
5242         do_scroll_horizontal and do_scroll_vertical.
5243         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5244
5245 2019-06-25  Tom Tromey  <tom@tromey.com>
5246
5247         * tui/tui-data.h (struct tui_source_window_base): New struct.
5248         (struct tui_source_window): Derive from tui_source_window_base.
5249         (struct tui_disasm_window): New struct.
5250         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5251         from tui_source_window::clear_detail.
5252         (tui_source_window_base): Rename from tui_source_window.
5253         (~tui_source_window_base): Rename from ~tui_source_window.
5254         (tui_alloc_win_info): Create a tui_disasm_window.
5255
5256 2019-06-25  Tom Tromey  <tom@tromey.com>
5257
5258         * tui/tui-data.h (struct tui_source_window)
5259         (struct tui_data_window): Declare destructors.
5260         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5261         destructors.
5262         (tui_win_info): Simplify.
5263
5264 2019-06-25  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-winsource.c (tui_display_main)
5267         (tui_update_source_windows_with_addr)
5268         (tui_update_all_breakpoint_info): Update.
5269         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5270         (new_height_ok, parse_scrolling_args): Update.
5271         * tui/tui-stack.c (tui_show_frame_info): Update.
5272         * tui/tui-data.h (struct tui_list): Remove.
5273         (tui_source_windows): Return a reference to a std::vector.
5274         * tui/tui-data.c (source_windows): Now a std::vector.
5275         (tui_source_windows): Change return type.
5276         (tui_clear_source_windows): Rewrite.
5277         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5278         (tui_free_all_source_wins_content): Rewrite.
5279
5280 2019-06-25  Tom Tromey  <tom@tromey.com>
5281
5282         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5283         (struct tui_data_window, struct tui_cmd_window): Declare
5284         clear_detail method.
5285         * tui/tui-data.c (tui_source_window::clear_detail)
5286         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5287         methods.
5288         (tui_clear_win_detail): Simplify.
5289
5290 2019-06-25  Tom Tromey  <tom@tromey.com>
5291
5292         * tui/tui-layout.c (make_source_window, make_disasm_window)
5293         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5294         Return the new window.
5295         (show_source_disasm_command, show_data)
5296         (show_source_or_disasm_and_command): Update.
5297
5298 2019-06-25  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5301         parameter.  Return the new window.
5302         (show_source_disasm_command): Update and remove NULL check.
5303         (show_source_or_disasm_and_command): Update.
5304
5305 2019-06-25  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5308
5309 2019-06-25  Tom Tromey  <tom@tromey.com>
5310
5311         * tui/tui-data.h (struct tui_win_info): Make constructor
5312         protected.  Make destructor virtual.  Add initializers.
5313         (tui_source_window, tui_data_window, tui_cmd_window): New
5314         classes.
5315         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5316         constructor.  Add "type" parameter.
5317         (tui_source_window, tui_data_window, tui_cmd_window): New
5318         constructors.
5319         (tui_alloc_win_info): Instantiate the appropriate subclass.
5320
5321 2019-06-25  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-win.c (tui_resize_all): Use delete.
5324         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5325         destructor.
5326         (tui_free_window): Don't declare.
5327         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5328         Update.
5329
5330 2019-06-25  Tom Tromey  <tom@tromey.com>
5331
5332         * tui/tui-data.h (struct tui_win_info): Add constructor.
5333         * tui/tui-data.c (tui_alloc_win_info): Use new.
5334         (tui_free_window): Use delete.
5335
5336 2019-06-22  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5339         declare.
5340         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5341
5342 2019-06-22  Tom Tromey  <tom@tromey.com>
5343
5344         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5345         declare.
5346         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5347
5348 2019-06-22  Tom de Vries  <tdevries@suse.de>
5349
5350         * dwarf2read.c (create_addrmap_from_aranges)
5351         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5352         instead of '%zu'.
5353
5354 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5355
5356         * dwarf2read.h (dwarf2_section_info_def): Remove.
5357         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5358         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5359         std::vector<dwarf2_section_info>.
5360         (struct dwo_file) <~dwo_file>: Remove.
5361         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5362         types field.
5363         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5364         (dwarf2_read_debug_names): Likewise.
5365         (create_debug_types_hash_table): Change parameter type to
5366         array_view, adjust code accordingly.
5367         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5368         (partial_die_info::fixup): Likewise.
5369         (determine_prefix): Likewise.
5370         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5371
5372 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5373
5374         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5375         gdb_bfd_ref_ptr.
5376         <~dwo_file>: Remove call to gdb_bfd_unref.
5377         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5378         gdb_bfd_ref_ptr::get.
5379
5380 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5381
5382         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5383         type to htab_up.
5384         * dwarf2read.c (struct dwo_file): Initialize fields.
5385         <~dwo_file>: New.
5386         (free_dwo_file): Remove, move content to ~dwo_file.
5387         (struct dwo_file_deleter): Remove.
5388         (dwo_file_up>: Remove custom deleter.
5389         (free_dwo_files): Remove.
5390         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5391         dwo_files.
5392         (process_skeletonless_type_units): Call unique_ptr::get.
5393         (allocate_dwo_file_hash_table): Add deleter to created hash
5394         table.  Change return type to htab_up.
5395         (lookup_dwo_file_slot): Don't memset dwo_file, call
5396         unique_ptr::get.
5397         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5398         (create_dwo_unit_in_dwp_v2): Likewise.
5399         (open_and_init_dwo_file): Likewise.
5400         (free_dwo_file_from_slot): Remove.
5401
5402 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5403
5404         * dwarf2read.h (struct dwarf2_section_info) <readin,
5405         is_virtual>: Change type to bool.
5406         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5407         true instead of 1.
5408
5409 2019-06-19  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui-data.h (tui_init_content_element): Don't declare.
5412
5413 2019-06-19  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-data.h (tui_init_win_info): Don't declare.
5416
5417 2019-06-19  Tom de Vries  <tdevries@suse.de>
5418
5419         * dwarf2read.h (abstract_to_concrete): Change type to
5420         std::unordered_map<sect_offset, std::vector<sect_offset>,
5421         gdb::hash_enum<sect_offset>>.
5422
5423 2019-06-19  Tom Tromey  <tromey@adacore.com>
5424
5425         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5426         EVAL_AVOID_SIDE_EFFECTS specially.
5427
5428 2019-06-19  Tom Tromey  <tromey@adacore.com>
5429
5430         * source-cache.c (highlighter): New global.
5431         (source_cache::get_source_lines): Create a highlighter on demand.
5432
5433 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * defs.h (deprecated_interactive_hook): Delete declaration.
5436         * interps.c (clear_interpreter_hooks): Remove use of
5437         deprecated_interactive_hook.
5438         * top.c (deprecated_interactive_hook): Delete definition.
5439         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5440
5441 2019-06-18  Tom de Vries  <tdevries@suse.de>
5442
5443         PR gdb/24515
5444         * dwarf2read.h (abstract_to_concrete): Change type from
5445         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5446         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5447         * dwarf2read.c (read_variable): Update.
5448         (dwarf2_fetch_die_loc_sect_off): Update.
5449
5450 2019-06-17  Tom de Vries  <tdevries@suse.de>
5451
5452         PR gdb/24617
5453         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5454         accessing parent[parent_len - 1].
5455
5456 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5457
5458         PR gdb/24364
5459         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5460         call dtrace_process_dof with NULL dof.
5461
5462 2019-06-16  Tom de Vries  <tdevries@suse.de>
5463
5464         PR gdb/24445
5465         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5466
5467 2019-06-16  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5470         (make_all_visible): Use address of member.
5471
5472 2019-06-16  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5475         (tui_free_window, free_content, free_content_elements): Remove
5476         unnecessary cast.
5477         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5478         cast.
5479         * tui/tui-regs.c (tui_show_register_group)
5480         (tui_display_registers_from, tui_display_reg_element_at_line):
5481         Remove unnecessary cast.
5482
5483 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * linux-nat.c (normal_mask): Delete.
5486         (_initialize_linux_nat): Don't initialise normal_mask.
5487
5488 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5489
5490         PR gdb/24445
5491         * dwarf-index-write.h (write_psymtabs_to_index): Add
5492         dwz_basename parameter.
5493         * dwarf-index-write.c (write_gdbindex): Move file writing to
5494         write_gdbindex_1.  Change return type void.
5495         (assert_file_size): Move up, remove filename parameter.
5496         (write_gdbindex_1): New function.
5497         (write_debug_names): Change return type to void, call
5498         assert_file_size.
5499         (struct index_wip_file): New struct.
5500         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5501         file logic to index_wip_file.  Write index for dwz file if
5502         needed.
5503         (save_gdb_index_command): Pass basename of dwz file, if present.
5504         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5505         build-id of dwz file, if present.
5506         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5507         (dwarf2_get_dwz_file): Likewise.
5508         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5509         (dwarf2_get_dwz_file): Likewise.
5510
5511 2019-06-16  Tom Tromey  <tom@tromey.com>
5512
5513         * coffread.c (process_coff_symbol): Use xstrdup.
5514         * value.c (create_internalvar): Use xstrdup.
5515
5516 2019-06-16  Tom Tromey  <tom@tromey.com>
5517
5518         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5519         * breakpoint.c (stopin_command, stopat_command)
5520         (until_break_command, decode_location_default): Remove unnecessary
5521         cast.
5522         * utils.c (subset_compare): Remove unnecessary cast.
5523         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5524         cast.
5525         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5526         cast.
5527         * infcmd.c (path_command): Remove unnecessary cast.
5528         * coffread.c (decode_type): Remove unnecessary cast.
5529         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5530         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5531         * tui/tui-stack.c (tui_show_locator_content)
5532         (tui_show_frame_info): Remove unnecessary cast.
5533         * tui/tui-win.c (tui_scroll_forward_command)
5534         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5535         (parse_scrolling_args): Remove unnecessary cast.
5536         * tui/tui-data.c (init_win_info, tui_del_window)
5537         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5538         (free_content_elements): Remove unnecessary cast.
5539         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5540         unnecessary cast.
5541         * tui/tui-source.c (tui_set_source_content)
5542         (tui_vertical_source_scroll): Remove unnecessary cast.
5543         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5544         cast.
5545         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5546         * tui/tui-regs.c (tui_display_registers_from)
5547         (tui_display_register): Remove unnecessary cast.
5548         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5549         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5550         (make_visible): Remove unnecessary cast.
5551         * tui/tui-winsource.c (tui_erase_source_content)
5552         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5553         unnecessary cast.
5554         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5555         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5556         * stabsread.c (read_type, read_array_type, read_range_type):
5557         Remove unnecessary cast.
5558         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5559         (parse_symbol, parse_type, upgrade_type, parse_external)
5560         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5561         unnecessary cast.
5562         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5563
5564 2019-06-16  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-data.c (tui_alloc_generic_win_info)
5567         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5568         checks.
5569
5570 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5571             Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * f-typeprint.c (f_print_type): Don't return early for not
5574         associated or not allocated types.
5575         (f_type_print_varspec_suffix): Add print_rank parameter and print
5576         ranks of array types in case they dangling.
5577         (f_type_print_base): Add print_rank parameter.
5578
5579 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * NEWS: Mention new MI commands.
5582         * break-catch-throw.c (enum exception_event_kind): Move to
5583         breakpoint.h.
5584         (print_mention_exception_catchpoint): Output text as a single
5585         message.
5586         (catch_exception_command_1): Rename to...
5587         (catch_exception_event): ...this, make non-static, update header
5588         command, and change some parameter types.
5589         (catch_catch_command): Update for changes to
5590         catch_exception_command_1.
5591         (catch_throw_command): Likewise.
5592         (catch_rethrow_command): Likewise.
5593         * breakpoint.c (enum exception_event_kind): Delete.
5594         * breakpoint.h (enum exception_event_kind): Moved here from
5595         break-catch-throw.c.
5596         (catch_exception_event): Declare.
5597         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5598         (mi_cmd_catch_throw): New function.
5599         (mi_cmd_catch_rethrow): New function.
5600         (mi_cmd_catch_catch): New function.
5601         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5602         'catch-catch' entries.
5603         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5604         (mi_cmd_catch_rethrow): Declare.
5605         (mi_cmd_catch_catch): Declare.
5606
5607 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * annotate.c (annotate_source_line): Change return type to void,
5610         update implementation to match.
5611         * annotate.h (annotate_source_line): Change return type to void,
5612         update header comment.
5613         * stack.c (print_frame_info): Don't change what frame information
5614         is printed based on whether annotations are on or not.
5615
5616 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5619         (annotate_source): Make static.
5620         (annotate_source_line): Moved from source.c and renamed from
5621         identify_source_line.  Update the return type.
5622         * annotate.h (annotate_source): Delete declaration.
5623         (annotate_source_line): Declaration moved from source.h, and
5624         renamed from identify_source_line.  Return type updated.
5625         * source.c (identify_source_line): Moved to annotate.c and renamed
5626         to annotate_source_line.
5627         (info_line_command): Remove check of annotation_level.
5628         * source.h (identify_source_line): Move declaration to annotate.h
5629         and rename to annotate_source_line.
5630         * stack.c: Add 'annotate.h' include.
5631         (print_frame_info): Remove check of annotation_level before
5632         calling annotate_source_line.
5633
5634 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5635
5636         * source-cache.c (source_cache::get_plain_source_lines): Use
5637         open_source_file_with_line_charpos instead of just
5638         open_source_file, remove call to find_source_lines.
5639         (source_cache::get_source_lines): Likewise.
5640         * source.c (find_source_lines): Make static.
5641         (get_filename_and_charpos): Renamed into...
5642         (open_source_file_with_line_charpos): ..this along with changes to
5643         return a scoped_fd, and some other minor clean ups.
5644         (identify_source_line): Use open_source_file_with_line_charpos.
5645         (search_command_helper): Use open_source_file_with_line_charpos
5646         instead of just open_source_file, remove call to
5647         find_source_lines.
5648         * source.h (open_source_file_with_line_charpos): Declare new
5649         function.
5650         (find_source_lines): Delete declaration.
5651
5652 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * source.c (get_filename_and_charpos): Remove fullname
5655         parameter.
5656         (identify_source_line): Update call to get_filename_and_charpos.
5657
5658 2019-06-14  Tom Tromey  <tromey@adacore.com>
5659
5660         PR gdb/24502:
5661         * ui-style.h (skip_ansi_escape): Update comment.
5662         * ui-file.h (class no_terminal_escape_file): New class.
5663         * ui-file.c (no_terminal_escape_file::write)
5664         (no_terminal_escape_file::puts): New methods.
5665         * cli/cli-logging.c (handle_redirections): Use
5666         no_terminal_escape_file.
5667
5668 2019-06-14  Tom Tromey  <tromey@adacore.com>
5669
5670         * NEWS: Move convenience variable news above Python news.
5671
5672 2019-06-14  Tom Tromey  <tom@tromey.com>
5673
5674         * gnulib: Move directory to top-level.
5675         * configure.ac: Don't configure gnulib.
5676         * configure: Rebuild.
5677         * common/common-defs.h: Use new path to gnulib.
5678         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5679         (GNULIB_H): Remove.
5680         (INCGNU): Look in new gnulib location.
5681         (HFILES_NO_SRCDIR): Remove gnulib files.
5682         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5683         (generated_files): Remove GNULIB_H.
5684         ($(LIBGNU), all-lib): Remove targets.
5685         (distclean): Don't mention GNULIB_BUILDDIR.
5686         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5687
5688 2019-06-14  Tom Tromey  <tromey@adacore.com>
5689
5690         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5691         Warn if symbol file does not provide any symbols.
5692
5693 2019-06-14  Tom Tromey  <tromey@adacore.com>
5694
5695         * source.c (find_and_open_source): Respect basenames_may_differ.
5696
5697 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5698
5699         * annotate.c (annotate_breakpoints_invalid): Make use of
5700         scoped_restore_terminal_state.
5701         (annotate_frames_invalid): Likewise.
5702
5703 2019-06-14  Tom Tromey  <tromey@adacore.com>
5704
5705         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5706         allow assignment to an internalvar.
5707
5708 2019-06-14  Tom Tromey  <tromey@adacore.com>
5709
5710         * ada-lex.l: Allow "_" in attribute names.
5711
5712 2019-06-14  Tom Tromey  <tromey@adacore.com>
5713
5714         PR gdb/24653:
5715         * regcache.c (registers_changed): Don't call alloca.
5716         * top.c (execute_command): Don't call alloca.
5717
5718 2019-06-13  Pedro Alves  <palves@redhat.com>
5719
5720         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5721         'expression'.  When parsing an expression, error out if there's
5722         junk after "unlimited".
5723         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5724         (do_set_command): Adjust calls to is_unlimited_literal.
5725
5726 2019-06-13  Pedro Alves  <palves@redhat.com>
5727
5728         * compile/compile.c (make_compile_options_def_group): Add braces
5729         around array_view initializer.
5730         * thread.c (make_thread_apply_all_options_def_group)
5731         (make_thread_apply_all_options_def_group): Likewise.
5732
5733 2019-06-13  Pedro Alves  <palves@redhat.com>
5734
5735         * NEWS (New commands): Mention "maint test-options
5736         require-delimiter", "maint test-options unknown-is-error", "maint
5737         test-options unknown-is-operand" and "maint show
5738         test-options-completion-result".
5739         (New command options, command completion): New section.
5740         (Completion improvements): New section.
5741         Mention that you can abbreviate "unlimited".
5742
5743 2019-06-13  Pedro Alves  <palves@redhat.com>
5744
5745         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5746         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5747         * unittests/cli-utils-selftests.c (test_parse_flags)
5748         (test_parse_flags_qcs): Delete.
5749         (test_cli_utils): Don't call deleted functions.
5750
5751 2019-06-13  Pedro Alves  <palves@redhat.com>
5752
5753         * thread.c: Include "cli/cli-option.h".
5754         (tp_array_compar_ascending): Global.
5755         (tp_array_compar): Delete function.
5756         (tp_array_compar_ascending, tp_array_compar_descending): New
5757         functions.
5758         (ascending_option_def, qcs_flag_option_def)
5759         (thr_qcs_flags_option_defs)
5760         (make_thread_apply_all_options_def_group)
5761         (make_thread_apply_options_def_group): New.
5762         (thread_apply_all_command): Use gdb::option::process_options.
5763         (thread_apply_command_completer)
5764         (thread_apply_all_command_completer): New.
5765         (thread_apply_command): Use gdb::option::process_options.
5766         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5767         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5768         to generate help text of "thread apply".  Adjust "taas"'s help.
5769         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5770         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5771
5772 2019-06-13  Pedro Alves  <palves@redhat.com>
5773
5774         * thread.c (thread_apply_command): Check for invalid TID with
5775         isdigit instead of !isalpha.
5776
5777 2019-06-13  Pedro Alves  <palves@redhat.com>
5778
5779         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5780         (validate_flags_qcs): New.
5781         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5782         (validate_flags_qcs): Declare.
5783         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5784         (make_frame_apply_options_def_group): New.
5785         (frame_apply_command_count): Process options with
5786         gdb::option::process_options.
5787         (frame_apply_completer): New.
5788         (frame_apply_level_completer, frame_apply_all_completer)
5789         (frame_apply_completer): New.
5790         (_initialize_stack): Update help of "frame apply", "frame apply
5791         level", "frame apply all" and "faas" to mention supported options
5792         and install command completers.
5793         * stack.h (frame_apply_all_completer): Declare.
5794         * thread.c: Include "stack.h".
5795         (tfaas_command): Add "--".
5796         (_initialize_thread): Update help "tfaas" to mention supported
5797         options and install command completer.
5798
5799 2019-06-13  Pedro Alves  <palves@redhat.com>
5800
5801         * completer.c (complete_nested_command_line): New.
5802         (gdb_completion_word_break_characters_throw): Add assertion.
5803         * completer.h (complete_nested_command_line): Declare.
5804
5805 2019-06-13  Pedro Alves  <palves@redhat.com>
5806
5807         * stack.c (parse_backtrace_qualifiers): New.
5808         (backtrace_command): Use it.
5809         (backtrace_command_completer): Complete on qualifiers.
5810
5811 2019-06-13  Pedro Alves  <palves@redhat.com>
5812
5813         * frame.c: Include "cli/cli-option.h.
5814         (user_set_backtrace_options): New.
5815         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5816         Delete.
5817         (get_prev_frame): Adjust.
5818         (boolean_option_def, uinteger_option_def)
5819         (set_backtrace_option_defs): New.
5820         (_initialize_frame): Adjust and use
5821         gdb::option::add_setshow_cmds_for_options to install "set
5822         backtrace past-main" and "set backtrace past-entry".
5823         * frame.h: Include "cli/cli-option.h".
5824         (struct frame_print_options): Forward declare.
5825         (print_frame_arguments_all, print_frame_arguments_scalars)
5826         (print_frame_arguments_none): Declare.
5827         (print_entry_values): Delete declaration.
5828         (struct frame_print_options, user_frame_print_options): New.
5829         (struct set_backtrace_options): New.
5830         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5831         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5832         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5833         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5834         (list_args_or_locals): Add frame_print_options parameter.
5835         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5836         * python/py-framefilter.c (enumerate_args): Pass down
5837         USER_FRAME_PRINT_OPTIONS.
5838         * stack.c: Include "cli/cli-option.h".
5839         (print_frame_arguments_all, print_frame_arguments_scalars)
5840         (print_frame_arguments_none): Declare.
5841         (print_raw_frame_arguments, print_entry_values): Delete.
5842         (user_frame_print_options): New.
5843         (boolean_option_def, enum_option_def, frame_print_option_defs):
5844         New.
5845         (struct backtrace_cmd_options): New.
5846         (bt_flag_option_def): New.
5847         (backtrace_command_option_defs): New.
5848         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5849         (print_frame_arg, read_frame_arg, print_frame_args)
5850         (print_frame_info, print_frame): Add frame_print_options parameter
5851         and use it.
5852         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5853         (backtrace_command_1): Add frame_print_options and
5854         backtrace_cmd_options parameters and use them.
5855         (make_backtrace_options_def_group): New.
5856         (backtrace_command): Process command options with
5857         gdb::option::process_options.
5858         (backtrace_command_completer): New.
5859         (_initialize_stack): Extend "backtrace"'s help to mention
5860         supported options.  Install completer for "backtrace".
5861         Install some settings commands with add_setshow_cmds_for_options.
5862
5863 2019-06-13  Pedro Alves  <palves@redhat.com>
5864
5865         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5866         and that "set/show print raw frame-arguments" are now deprecated.
5867
5868         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5869         command.
5870         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5871         * stack.c (_initialize_stack): Install "set/show print
5872         raw-frame-arguments", and deprecate "set/show print raw
5873         frame-arguments".
5874         * valprint.c (_initialize_valprint): Deprecate "set/show print
5875         raw".
5876
5877 2019-06-13  Pedro Alves  <palves@redhat.com>
5878
5879         * compile/compile.c (struct compile_options): New.
5880         (compile_flag_option_def, compile_command_option_defs)
5881         (make_compile_options_def_group): New.
5882         (compile_file_command): Handle options with
5883         gdb::option::process_options.
5884         (compile_file_command_completer): New function.
5885         (compile_code_command): Handle options with
5886         gdb::option::process_options.
5887         (compile_code_command_completer): New function.
5888         (_initialize_compiler): Install completers for "compile code" and
5889         "compile file".  Mention available options in "compile code" and
5890         "compile code"'s help.
5891         * completer.c (advance_to_completion_word): New, factored out from
5892         ...
5893         (advance_to_expression_complete_word_point): ... this.
5894         (advance_to_filename_complete_word_point): New.
5895         * completer.h (advance_to_filename_complete_word_point): New
5896         declaration.
5897
5898 2019-06-13  Pedro Alves  <palves@redhat.com>
5899
5900         * compile/compile.c: Include "cli/cli-option.h".
5901         (compile_print_value): Scope data pointer is now a
5902         value_print_options pointer; adjust.
5903         (compile_print_command): Process options.  Scope data pointer is
5904         now a value_print_options pointer; adjust.
5905         (_initialize_compile): Update "compile print"'s help to include
5906         supported options.  Install a completer for "compile print".
5907         * cp-valprint.c (show_vtblprint, show_objectprint)
5908         (show_static_field_print): Delete.
5909         (_initialize_cp_valprint): Don't install "set print
5910         static-members", "set print vtbl", "set print object" here.
5911         * printcmd.c: Include "cli/cli-option.h" and
5912         "common/gdb_optional.h".
5913         (print_command_parse_format): Rework to fill in a
5914         value_print_options instead of a format_data.
5915         (print_value): Change parameter type from format_data pointer to
5916         value_print_options reference.  Adjust.
5917         (print_command_1): Process options.  Adjust to pass down a
5918         value_print_options.
5919         (print_command_completer): New.
5920         (_initialize_printcmd): Install print_command_completer as
5921         handle_brkchars completer for the "print" command.  Update
5922         "print"'s help to include supported options.
5923         * valprint.c: Include "cli/cli-option.h".
5924         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5925         here from cp-valprint.c.
5926         (boolean_option_def, uinteger_option_def)
5927         (value_print_option_defs, make_value_print_options_def_group):
5928         New.  Use gdb::option::add_setshow_cmds_for_options to install
5929         "set print elements", "set print null-stop", "set print repeats",
5930         "set print pretty", "set print union", "set print array", "set
5931         print address", "set print symbol", "set print array-indexes".
5932         * valprint.h: Include <string> and "cli/cli-option.h".
5933         (make_value_print_options_def_group): Declare.
5934         (print_value): Change parameter type from format_data pointer to
5935         value_print_options reference.
5936         (print_command_completer): Declare.
5937
5938 2019-06-13  Pedro Alves  <palves@redhat.com>
5939
5940         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5941         (COMMON_SFILES): Add maint-test-settings.c.
5942         * cli/cli-decode.c (boolean_enums): New global, factored out from
5943         ...
5944         (add_setshow_boolean_cmd): ... here.
5945         * cli/cli-decode.h (boolean_enums): Declare.
5946         * cli/cli-option.c: New file.
5947         * cli/cli-option.h: New file.
5948         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5949         factored out from ...
5950         (parse_cli_boolean_value(const char *)): ... this.
5951         (is_unlimited_literal): Change parameter type to pointer to
5952         pointer.  Adjust and advance ARG pointer.
5953         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5954         (parse_cli_var_enum): New, factored out from ...
5955         (do_set_command): ... this.  Adjust.
5956         * cli/cli-setshow.h (parse_cli_boolean_value)
5957         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5958         (parse_cli_var_enum): Declare.
5959         * cli/cli-utils.c: Include "cli/cli-option.h".
5960         (get_ulongest): New.
5961         * cli/cli-utils.h (get_ulongest): Declare.
5962         (check_for_argument): New overloads.
5963         * maint-test-options.c: New file.
5964
5965 2019-06-13  Pedro Alves  <palves@redhat.com>
5966
5967         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5968         parse a range if "-" is at the end of the string.
5969
5970 2019-06-13  Pedro Alves  <palves@redhat.com>
5971
5972         * cli/cli-setshow.c (parse_auto_binary_operation)
5973         (parse_cli_boolean_value): Don't allow "o".
5974
5975 2019-06-13  Pedro Alves  <palves@redhat.com>
5976
5977         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5978         * NEWS: Mention maint test-settings KIND.
5979         * maint-test-settings.c: New file.
5980
5981 2019-06-13  Pedro Alves  <palves@redhat.com>
5982
5983         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5984         completer.
5985         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5986         "set" completers.
5987
5988 2019-06-13  Pedro Alves  <palves@redhat.com>
5989
5990         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5991         after item.
5992
5993 2019-06-13  Pedro Alves  <palves@redhat.com>
5994
5995         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5996
5997 2019-06-13  Pedro Alves <palves@redhat.com>
5998
5999         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6000         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6001         call.
6002         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6003         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6004         calls.
6005         (check_for_argument): Skip spaces after argument.
6006
6007 2019-06-13  Pedro Alves  <palves@redhat.com>
6008
6009         * thread.c (thread_apply_command): Adjust TID parsing.
6010         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6011         detected before end of string.
6012         (tid_is_in_list): Error out if LIST is invalid.
6013
6014 2019-06-13  Pedro Alves  <palves@redhat.com>
6015
6016         * completer.c (complete_line_internal_1): Rewind completion word
6017         point.
6018         (completion_tracker::advance_custom_word_point_by): Change
6019         parameter type to int.
6020         * completer.h (completion_tracker::advance_custom_word_point_by):
6021         Likewise.
6022
6023 2019-06-13  Pedro Alves  <palves@redhat.com>
6024
6025         * completer.c (advance_to_completion_word): Handle delimiters.
6026
6027 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6028
6029         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6030
6031 2019-06-11  Tom Tromey  <tom@tromey.com>
6032
6033         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6034         (xmalloc_failed): Move to alloc.c.
6035         * alloc.c: New file.
6036         * Makefile.in (COMMON_SFILES): Add alloc.c.
6037
6038 2019-06-11  Tom Tromey  <tom@tromey.com>
6039
6040         * nat/linux-waitpid.c: Don't include server.h.
6041         (linux_debug): Remove.
6042         (my_waitpid): Update.
6043
6044 2019-06-11  Tom Tromey  <tromey@adacore.com>
6045
6046         * infcall.c (_initialize_infcall): Remove trailing newline from
6047         help.
6048         * user-regs.c (_initialize_user_regs): Remove trailing newline
6049         from help.
6050         * typeprint.c (_initialize_typeprint): Remove trailing newline
6051         from help.
6052         * reverse.c (_initialize_reverse): Remove trailing newlines from
6053         help.
6054         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6055         from help.
6056         * language.c (add_set_language_command): Remove trailing newline
6057         from help.
6058         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6059         help.
6060         * disasm.c (_initialize_disasm): Remove trailing newline from
6061         help.
6062         * top.c (init_main): Remove trailing newline from help.
6063         * interps.c (_initialize_interpreter): Remove trailing newline
6064         from help.
6065         * btrace.c (_initialize_btrace): Remove trailing newlines from
6066         help.
6067         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6068         from help.
6069         * python/python.c (_initialize_python): Remove trailing newline
6070         from help.
6071         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6072         help.
6073         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6074         from help.  Reformat some text.
6075         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6076         from help.
6077         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6078         newline from help.
6079
6080 2019-06-11  Tom Tromey  <tromey@adacore.com>
6081
6082         * darwin-nat.c (darwin_decode_exception_message)
6083         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6084
6085 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * valops.c (value_slice): Check for not allocated or not
6088         associated values.
6089
6090 2019-06-10  Tom de Vries  <tdevries@suse.de>
6091
6092         PR gdb/24618
6093         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6094         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6095         invalid.
6096
6097 2019-06-10  Tom de Vries  <tdevries@suse.de>
6098
6099         PR gdb/24611
6100         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6101         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6102
6103 2019-06-10  Tom de Vries  <tdevries@suse.de>
6104
6105         PR symtab/24545
6106         * symtab.c (struct demangled_name_entry): Add language field.
6107         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6108         static minimal symbol".  Set and use language field.
6109
6110 2019-06-10  Tom Tromey  <tromey@adacore.com>
6111
6112         * ada-lang.c (_initialize_ada_language): Update help text.
6113
6114 2019-06-10  Tom Tromey  <tromey@adacore.com>
6115
6116         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6117         with a newline.
6118         * guile/guile.c (handle_boot_error): Don't end warning with a
6119         newline.
6120         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6121         warning with a newline.
6122         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6123         newline.
6124         (s12z_frame_cache): Likewise.
6125         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6126         a newline.
6127         * solib-svr4.c (disable_probes_interface): Don't end warning with
6128         a newline.
6129         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6130         newline.
6131         * python/python.c (do_finish_initialization): Don't end warning
6132         with a newline.
6133
6134 2019-06-10  Tom Tromey  <tom@tromey.com>
6135
6136         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6137         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6138         gdbpy_enter.
6139
6140 2019-06-10  Tom Tromey  <tromey@adacore.com>
6141
6142         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6143         data.
6144         (elf_new_init): Don't call stabsread_new_init.
6145         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6146         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6147         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6148
6149 2019-06-10  Tom de Vries  <tdevries@suse.de>
6150
6151         PR symtab/16264
6152         PR symtab/24517
6153         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6154
6155 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6156
6157         * source.c (find_and_open_source): Also rewrite relative file
6158         names.
6159
6160 2019-04-26  Amos Bird  <amosbird@gmail.com>
6161
6162         * annotate.c (annotate_thread_exited): Add "thread-exited"
6163         annotation.
6164
6165 2019-06-06  Tom Tromey  <tromey@adacore.com>
6166
6167         * maint.h (class scoped_command_stats): Use
6168         DISABLE_COPY_AND_ASSIGN.
6169         <print_time>: New method.
6170         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6171         print_time.
6172         (scoped_command_stats::print_time): New method.
6173
6174 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6177         instructions of lengths 6 or 8 bytes.
6178
6179 2019-06-04  Pedro Alves  <palves@redhat.com>
6180
6181         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6182
6183         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6184         * breakpoint.c (condition_completer): Likewise.
6185         * cli/cli-dump.c (scan_expression): Likewise.
6186         * common/filestuff.c (mkdir_recursive): Likewise.
6187         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6188         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6189         (gdb_abspath): Likewise.
6190         * compile/compile-cplus-types.c
6191         (compile_cplus_instance::decl_name): Likewise.
6192         * completer.c (complete_explicit_location):
6193         (signal_completer, reg_or_group_completer_1): Likewise.
6194         * cp-support.c (cp_remove_params_if_any): Likewise.
6195         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6196         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6197         * infcmd.c (strip_bg_char): Likewise.
6198         * linespec.c (copy_token_string): Likewise.
6199         * mi/mi-main.c (output_cores): Likewise.
6200         * psymtab.c (psymtab_search_name):
6201         * symfile.c (test_set_ext_lang_command): Likewise.
6202         * target.c (target_fileio_read_stralloc): Likewise.
6203         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6204         * value.c (complete_internalvar): Likewise.
6205
6206 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6207
6208         Add objfile property to gdb.Type.
6209         * NEWS: Mention Python API addition.
6210         * python/py-type.c (typy_get_objfile): New method.
6211
6212 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6213
6214         * NEWS: Mention the new set|show style [title|highlight].
6215         Mention changes to "show style", "help" and "apropos".
6216
6217 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218
6219         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6220         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6221         instead of print_help_for_command.
6222         (print_doc_of_command): New function.
6223         (help_list): Add 'apropos -v word' suggestion.
6224         (print_help_for_command): Style the command name using title style.
6225         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6226         (_initialize_cli_cmds): Describe -v in apropos_command help.
6227
6228 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6229
6230         * cli/cli-style.h (cli_style_option): Add name in constructor,
6231         add m_name class member, add constructor with intensity,
6232         add name class function.
6233         (cli_style_option::add_setshow_commands): Remove name argument.
6234         (highlight_style, title_style): New styles.
6235         * cli/cli-style.c (do_show): New function that shows a style
6236         characteristic styling the style name with itself.
6237         (set_style_name): New function.
6238         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6239         Update all callers according to the changes in cli/cli-style.h.
6240         * utils.h (fputs_highlighted): New function.
6241         * utils.c (fputs_highlighted): Likewise.
6242
6243 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6244
6245         * NEWS: Mention new pipe command and new convenience variables.
6246
6247 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6248
6249         * cli/cli-cmds.c (pipe_command): New function.
6250         (_initialize_cli_cmds): Call add_com for pipe_command.
6251         Define | as an alias for pipe.
6252         (exit_status_set_internal_vars): New function.
6253         (shell_escape): Call exit_status_set_internal_vars.
6254         cli/cli-decode.c (find_command_name_length): Recognize | as
6255         a single character command.
6256
6257 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6258
6259         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6260         top.c (execute_command_to_ui_file): New function, mostly a copy
6261         of execute_command_to_string.
6262         (execute_command_to_string): Implement by calling
6263         execute_command_to_ui_file.
6264
6265 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6266
6267         * top.h (saved_command_line): Remove declaration.
6268         * top.c (previous_saved_command_line, previous_repeat_arguments):
6269         New variables.
6270         (saved_command_line): Make static, define together with other
6271         'repeat variables'.
6272         (dont_repeat): Clear repeat_arguments.
6273         (repeat_previous, get_saved_command_line, save_command_line):
6274         New functions.
6275         (gdb_init): Initialize saved_command_line
6276         and previous_saved_command_line.
6277         * main.c (captured_main_1): Remove saved_command_line initialization.
6278         * event-top.c (handle_line_of_input): Update to use
6279         the new 'repeat' related functions instead of direct access to
6280         saved_command_line.
6281         * command.h (repeat_previous, get_saved_command_line,
6282         save_command_line): New declarations.
6283         (dont_repeat): Add comment.
6284
6285 2019-05-30  Tom Tromey  <tromey@adacore.com>
6286
6287         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6288         Fix comment.
6289         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6290
6291 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6292
6293         PR cli/24587
6294         * completer.c (complete): Initialize variable word.
6295
6296 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6297
6298         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6299         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6300         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6301         'body' is NULL to the outter 'if', protecting the '!is_define'
6302         situation as well.
6303
6304 2019-05-29  Tom Tromey  <tromey@adacore.com>
6305
6306         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6307         (dwarf_unknown): New function.
6308         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6309         (dwarf_type_encoding_name): Use dwarf_unknown.
6310
6311 2019-05-29  Tom Tromey  <tromey@adacore.com>
6312
6313         PR c++/20020:
6314         * cp-valprint.c (cp_print_value_fields): Call
6315         cp_print_static_field inside "try".
6316
6317 2019-05-29  Tom Tromey  <tromey@adacore.com>
6318
6319         * inflow.c (struct terminal_info): Add default operator=.
6320         * configure: Rebuild.
6321         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6322         -Wdeprecated-copy-dtor, -Wredundant-move.
6323
6324 2019-05-29  Tom Tromey  <tromey@adacore.com>
6325
6326         * NEWS: Add entry.
6327         * infcmd.c (print_return_value_1): Handle finish_print
6328         option.
6329         (show_print_finish): New function.
6330         (_initialize_infcmd): Add "set/show print finish" commands.
6331         * valprint.c (user_print_options): Initialize new member.
6332         * valprint.h (struct value_print_options) <finish_print>: New
6333         member.
6334
6335 2019-05-28  Tom Tromey  <tromey@adacore.com>
6336
6337         * ada-lang.c (ada_remove_Xbn_suffix)
6338         (find_old_style_renaming_symbol)
6339         (parse_old_style_renaming): Remove.
6340         (ada_find_renaming_symbol): Don't call
6341         find_old_style_renaming_symbol.
6342         (ada_is_renaming_symbol): Rename from
6343         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6344         bool.  Now static.
6345         (ada_read_var_value): Update and simplify.
6346         * ada-exp.y (write_var_or_type): Remove old code.
6347
6348 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6349
6350         * event-top.c: Remove include comment.
6351         * inflow.c (class scoped_ignore_sigttou): Move from here...
6352         * inflow.h (class scoped_ignore_sigttou): ...to here.
6353         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6354         * top.c:  Remove include comment.
6355
6356 2019-05-27  Tom Tromey  <tom@tromey.com>
6357
6358         * NEWS: Fix typo.
6359
6360 2019-05-22  Tom Tromey  <tromey@adacore.com>
6361
6362         * target.c (target_follow_exec): Constify parameter.
6363         * target-delegates.c: Rebuild.
6364         * remote.c (remote_target::follow_exec): Constify parameter.
6365         * infrun.c (follow_exec): Constify parameter.
6366         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6367         (target_follow_exec): Likewise.
6368
6369 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6370
6371         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6372         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6373
6374 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6375
6376         * NEWS: Add debugredirect and testsuite sections.
6377
6378 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6379
6380         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6381         target descriptions using exclusively floating point register name
6382         aliases.
6383
6384 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         PR gdb/18644:
6387         * f-lang.c (build_fortran_types): Handle the case where
6388         gdbarch_floatformat_for_type returns a nullptr.
6389
6390 2019-05-21  Tom de Vries  <tdevries@suse.de>
6391
6392         PR cli/24587
6393         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6394
6395 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         PR gdb/18644:
6398         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6399         16-byte floats.
6400         * i386-tdep.c (i386_floatformat_for_type): Use
6401         floatformats_ia64_quad for the 16-byte floating point component
6402         within a fortran 32-byte complex number.
6403
6404 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6407         delete default constructor.
6408         (find_partial_die): Update to return const struct.
6409         (partial_die_parent_scope): Move variable declaration into scope
6410         of its use and change its type to auto.
6411         (guess_partial_die_structure_name): Likewise.
6412         (partial_die_info::fixup): Likewise.
6413
6414 2019-05-17  Tom Tromey  <tromey@adacore.com>
6415
6416         * source.c (find_and_open_source): Remove cast.
6417
6418 2019-05-17  Tom Tromey  <tromey@adacore.com>
6419
6420         * annotate.c (annotate_source): Make "filename" const.
6421         * annotate.h (annotate_source): Use const.
6422
6423 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6424
6425         * disasm.c (set_disassembler_options): Send errors to stderr.
6426
6427 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6428
6429         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6430         (cli_interp_base::set_logging): Check debug_redirect.
6431         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6432         * cli/cli-logging.c (debug_redirect): Add static variable.
6433         (pop_output_files): Add default param.
6434         (handle_redirections): Print debug setting.
6435         (show_logging_command): Likewise.
6436         (_initialize_cli_logging): Add debugredirect command.
6437         * interps.c (current_interp_set_logging): Add debug_redirect
6438         parameter.
6439         * interps.h (set_logging): Add debug_redirect parameter.
6440         (current_interp_set_logging): Likewise.
6441         * mi/mi-common.h: Likewise.
6442         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6443
6444 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6445             Tom Tromey  <tromey@adacore.com>
6446
6447         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6448         directly.
6449         * cli/cli-interp.h (make_logging_output): Remove declaration.
6450         * cli/cli-logging.c (make_logging_output): Remove function.
6451         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6452         directly.
6453         * ui-file.c (tee_file::tee_file): Remove bools.
6454         (tee_file::~tee_file): Remove deletes.
6455         * ui-file.h (tee_file): Remove bools.
6456
6457 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6458
6459         * mi/mi-cmds.h (mi_cmd_complete): New function.
6460         * mi/mi-main.c (mi_cmd_complete): Likewise.
6461         * mi/mi-cmds.c: Define new MI command -complete.
6462         * NEWS: Mention new -complete command.
6463
6464 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6465
6466         * completer.h (complete): New function.
6467         * completer.c (complete): Likewise.
6468         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6469         function defined in completer.h.
6470
6471 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6472
6473         * MAINTAINERS (Write After Approval): Add myself.
6474
6475 2019-05-17  Tom de Vries  <tdevries@suse.de>
6476
6477         PR gdb/24094
6478         * dwarf2read.c (struct cu_partial_die_info): New struct.
6479         (find_partial_die): Return cu_partial_die_info.
6480         (partial_die_parent_scope, guess_partial_die_structure_name)
6481         (partial_die_info::fixup): Handle new return type of find_partial_die.
6482
6483 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6484
6485         PR breakpoints/24541
6486         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6487         "std::string", simplifying the algorithm.
6488
6489 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6490
6491         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6492         (stap_static_probe_ops::get_probes): Likewise.
6493
6494 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6495
6496         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6497         '-')" and "else if".
6498         (stap_parse_single_operand): Join checks for
6499         "gdbarch_stap_parse_special_token_p" and
6500         "gdbarch_stap_parse_special_token" in the same "if" statement.
6501         Invert check when verifying for operation on register
6502         displacement.
6503
6504 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6505
6506         * stap-probe.c (stap_get_opcode): Update comment.
6507         (stap_get_expected_argument_type): Likewise.
6508         (handle_stap_probe): Likewise.
6509
6510 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6511
6512         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6513         return type to 'bool'.  Adjust comment.  Use 'bool' when
6514         appropriate.
6515         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6516         * stap-probe.c (stap_parse_argument_1): Likewise.
6517         (stap_is_operator): Likewise.
6518         (stap_is_generic_prefix): Likewise.
6519         (stap_is_register_prefix): Likewise.
6520         (stap_is_register_indirection_prefix): Likewise.
6521         (stap_is_integer_prefix): Likewise.
6522         (stap_generic_check_suffix): Likewise.
6523         (stap_check_integer_suffix): Likewise.
6524         (stap_check_register_suffix): Likewise.
6525         (stap_check_register_indirection_suffix): Likewise.
6526         (stap_parse_register_operand): Likewise.
6527         (stap_parse_single_operand): Likewise.
6528         (stap_parse_argument_1): Likewise.
6529         (stap_probe::get_argument_count): Likewise.
6530         (stap_is_operator): Likewise.
6531
6532 2019-05-16  Tom Tromey  <tromey@adacore.com>
6533
6534         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6535         keyword to foreach.
6536
6537 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6538
6539         * linux-thread-db.c (try_thread_db_load_1): Change return type
6540         to bool.
6541         (try_thread_db_load): Likewise.
6542         (try_thread_db_load_from_pdir_1): Likewise.
6543         (try_thread_db_load_from_pdir): Likewise.
6544         (try_thread_db_load_from_sdir): Likewise.
6545         (try_thread_db_load_from_dir): Likewise.
6546         (thread_db_load_search): Likewise.
6547         (has_libpthread): Likewise.
6548         (thread_db_load): Likewise.
6549
6550 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6551
6552         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6553         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6554         NULL, and complain/return if that's the case.
6555
6556 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6557
6558         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6559         (advance, posn, abstract_read_memory): New functions.
6560         [struct mem_read_abstraction]: New struct.
6561         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6562
6563 2019-05-14  Tom Tromey  <tromey@adacore.com>
6564
6565         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6566         value is not lval_memory.
6567
6568 2019-05-14  Tom Tromey  <tromey@adacore.com>
6569
6570         * solib.c (info_sharedlibrary_command): Style the file name.
6571
6572 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6575         (aarch64_vnv_type): Likewise.
6576         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6577         * common/tdesc.c: Likewise.
6578         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6579         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6580         * features/aarch64-fpu.xml: Add ieee half view.
6581         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6582         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6583         * gdbtypes.h (struct builtin_type): Likewise.
6584         (struct objfile_type): Likewise.
6585
6586 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6587
6588         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6589         typo.
6590         * location.h (string_to_event_location): Likewise.
6591
6592 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6593
6594         GDB 8.3 released.
6595
6596 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6597
6598         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6599         New variable declaration.
6600         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6601         New variable.
6602         (print_one_breakpoint): Use ui_out::test_flags and new global
6603         variable to compute use_fixed_output.
6604         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6605         Remove.
6606         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6607         (mi_multi_location_breakpoint_output_fixed): Remove.
6608         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6609         new variable.
6610         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6611         fix_multi_location_breakpoint_output flag if version >= 3.
6612         * ui-out.h (enum ui_out_flag)
6613         <fix_multi_location_breakpoint_output>: New enumerator.
6614
6615 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6616
6617         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6618
6619 2019-05-10  Tom Tromey  <tromey@adacore.com>
6620
6621         * ada-lang.c (catch_ada_completer): New function.
6622         (_initialize_ada_language): Use it.
6623
6624 2019-05-10  Tom Tromey  <tromey@adacore.com>
6625
6626         * thread.c (print_thread_info): Make "requested_threads" const.
6627         * gdbthread.h (print_thread_info): Make "requested_threads"
6628         const.
6629         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6630         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6631
6632 2019-05-08  Tom Tromey  <tom@tromey.com>
6633
6634         * gdbtypes.c (objfile_type_data): Change type.
6635         (objfile_type, _initialize_gdbtypes): Update.
6636
6637 2019-05-08  Tom Tromey  <tom@tromey.com>
6638
6639         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6640         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6641         (_initialize_dwarf2_frame): Update.
6642
6643 2019-05-08  Tom Tromey  <tom@tromey.com>
6644
6645         * objc-lang.c (objc_objfile_data): Change type.
6646         (find_methods): Update.
6647         (_initialize_objc_lang): Remove.
6648
6649 2019-05-08  Tom Tromey  <tom@tromey.com>
6650
6651         * stabsread.c (rs6000_builtin_type_data): Change type.
6652         (rs6000_builtin_type, _initialize_stabsread): Update.
6653
6654 2019-05-08  Tom Tromey  <tom@tromey.com>
6655
6656         * mips-tdep.c (mips_pdr_data): Remove.
6657         (_initialize_mips_tdep): Update.
6658
6659 2019-05-08  Tom Tromey  <tom@tromey.com>
6660
6661         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6662         (hppa_init_objfile_priv_data, read_unwind_info)
6663         (find_unwind_entry, _initialize_hppa_tdep): Update.
6664
6665 2019-05-08  Tom Tromey  <tom@tromey.com>
6666
6667         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6668         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6669         on obstack.
6670         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6671
6672 2019-05-08  Tom Tromey  <tom@tromey.com>
6673
6674         * mdebugread.c (basic_type_data): Change type.
6675         (basic_type, _initialize_mdebugread): Update.
6676
6677 2019-05-08  Tom Tromey  <tom@tromey.com>
6678
6679         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6680
6681 2019-05-08  Tom Tromey  <tom@tromey.com>
6682
6683         * nto-tdep.c (nto_inferior_data_reg): Change type.
6684         (nto_inferior_data): Update.
6685         (nto_inferior_data_cleanup, nto_new_inferior_data)
6686         (_initialize_nto_tdep): Remove.
6687         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6688
6689 2019-05-08  Tom Tromey  <tom@tromey.com>
6690
6691         * ada-lang.c (struct ada_inferior_data): Add initializers.
6692         (ada_inferior_data): Change type.
6693         (ada_inferior_data_cleanup): Remove.
6694         (get_ada_inferior_data, ada_inferior_exit)
6695         (struct ada_pspace_data): Add initializers, destructor.
6696         (ada_pspace_data_handle): Change type.
6697         (get_ada_pspace_data): Update.
6698         (ada_pspace_data_cleanup): Remove.
6699
6700 2019-05-08  Tom Tromey  <tom@tromey.com>
6701
6702         * coffread.c (struct coff_symfile_info): Add initializers.
6703         (coff_objfile_data_key): Move lower.  Change type.
6704         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6705         Update.
6706         (coff_free_info): Remove.
6707
6708 2019-05-08  Tom Tromey  <tom@tromey.com>
6709
6710         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6711         (fbsd_pspace_data_handle): Move lower.  Change type.
6712         (get_fbsd_pspace_data): Update.
6713         (fbsd_pspace_data_cleanup): Remove.
6714         (_initialize_fbsd_tdep): Update.
6715
6716 2019-05-08  Tom Tromey  <tom@tromey.com>
6717
6718         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6719         (get_ada_tasks_pspace_data): Update.
6720         (ada_tasks_pspace_data_cleanup): Remove.
6721         (_initialize_tasks): Update.
6722         (ada_tasks_inferior_data_handle): Change type.
6723         (get_ada_tasks_inferior_data): Update.
6724         (ada_tasks_inferior_data_cleanup): Remove.
6725         (struct ada_tasks_pspace_data): Add initializers.
6726
6727 2019-05-08  Tom Tromey  <tom@tromey.com>
6728
6729         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6730         * symfile-debug.c (debug_sym_get_probes): Change type.
6731         * stap-probe.c (handle_stap_probe):
6732         (stap_static_probe_ops::get_probes): Change type.
6733         * probe.h (class static_probe_ops) <get_probes>: Change type.
6734         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6735         (parse_probes_in_pspace): Update.
6736         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6737         Update.
6738         (any_static_probe_ops::get_probes): Change type.
6739         * elfread.c (elfread_data): New typedef.
6740         (probe_key): Change type.
6741         (elf_get_probes): Likewise.  Update.
6742         (probe_key_free): Remove.
6743         (_initialize_elfread): Update.
6744         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6745         Change type.
6746         (dtrace_process_dof_probe, dtrace_process_dof)
6747         (dtrace_static_probe_ops::get_probe): Change type.
6748
6749 2019-05-08  Tom Tromey  <tom@tromey.com>
6750
6751         * xcoffread.c (struct xcoff_symfile_info): Rename from
6752         coff_symfile_info.  Add initializers.
6753         (xcoff_objfile_data_key): Move lower.  Change type.
6754         (XCOFF_DATA): Rewrite.
6755         (xcoff_free_info): Remove.
6756         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6757         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6758         (xcoff_initial_scan): Update.
6759
6760 2019-05-08  Tom Tromey  <tom@tromey.com>
6761
6762         * solib-svr4.c (struct svr4_info): Add initializers and
6763         destructor.
6764         <probes_table>: Now an htab_up.
6765         (solib_svr4_pspace_data): Change type.
6766         (free_probes_table): Simplify.
6767         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6768         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6769         (probes_table_remove_objfile_probes, register_solib_event_probe)
6770         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6771         (_initialize_svr4_solib): Update.
6772
6773 2019-05-08  Tom Tromey  <tom@tromey.com>
6774
6775         * remote.c (remote_pspace_data): Change type.
6776         (remote_pspace_data_cleanup): Remove.
6777         (get_remote_exec_file, set_pspace_remote_exec_file)
6778         (_initialize_remote): Update.
6779
6780 2019-05-08  Tom Tromey  <tom@tromey.com>
6781
6782         * breakpoint.c (breakpoint_objfile_key): Change type.
6783         (get_breakpoint_objfile_data): Update.
6784         (free_breakpoint_objfile_data): Remove.
6785         (_initialize_breakpoint): Update.
6786
6787 2019-05-08  Tom Tromey  <tom@tromey.com>
6788
6789         * linux-tdep.c (struct linux_info): Add initializers.
6790         (linux_inferior_data): Move.  Change type.
6791         (invalidate_linux_cache_inf): Update.
6792         (linux_inferior_data_cleanup): Remove.
6793         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6794
6795 2019-05-08  Tom Tromey  <tom@tromey.com>
6796
6797         * auxv.c (auxv_inferior_data): Move.  Change type.
6798         (auxv_inferior_data_cleanup): Remove.
6799         (invalidate_auxv_cache_inf): Rewrite.
6800         (get_auxv_inferior_data, _initialize_auxv): Update.
6801
6802 2019-05-08  Tom Tromey  <tom@tromey.com>
6803
6804         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6805         (symfile_debug_objfile_data_key): Change type.
6806         (symfile_debug_installed, debug_qf_has_symbols)
6807         (debug_qf_find_last_source_symtab)
6808         (debug_qf_forget_cached_source_info)
6809         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6810         (debug_qf_print_stats, debug_qf_dump)
6811         (debug_qf_expand_symtabs_for_function)
6812         (debug_qf_expand_all_symtabs)
6813         (debug_qf_expand_symtabs_with_fullname)
6814         (debug_qf_map_matching_symbols)
6815         (debug_qf_expand_symtabs_matching)
6816         (debug_qf_find_pc_sect_compunit_symtab)
6817         (debug_qf_map_symbol_filenames)
6818         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6819         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6820         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6821         (debug_sym_read_linetable, debug_sym_relocate): Update.
6822         (symfile_debug_free_objfile): Remove.
6823         (install_symfile_debug_logging, _initialize_symfile_debug):
6824         Update.
6825
6826 2019-05-08  Tom Tromey  <tom@tromey.com>
6827
6828         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6829         allocate_on_obstack.
6830         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6831         (get_dwarf2_per_objfile): Update.
6832         (set_dwarf2_per_objfile): Remove.
6833         (dwarf2_has_info, dwarf2_get_section_info): Update.
6834         (dwarf2_free_objfile): Remove.
6835         (_initialize_dwarf2_read): Update.
6836
6837 2019-05-08  Tom Tromey  <tom@tromey.com>
6838
6839         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6840         initializers.
6841         <unsupported_script_warning_printed,
6842         script_not_found_warning_printed>: Now bool.
6843         (auto_load_pspace_data): Change type.
6844         (~auto_load_pspace_info): Rename from
6845         auto_load_pspace_data_cleanup.
6846         (get_auto_load_pspace_data, init_loaded_scripts_info)
6847         (clear_section_scripts, maybe_print_unsupported_script_warning)
6848         (maybe_print_script_not_found_warning, _initialize_auto_load):
6849         Update.
6850
6851 2019-05-08  Tom Tromey  <tom@tromey.com>
6852
6853         * objfiles.c (objfile_pspace_info): Add destructor and
6854         initializers.
6855         (objfiles_pspace_data): Change type.
6856         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6857         (get_objfile_pspace_data): Update.
6858         (objfiles_bfd_data): Change type.
6859         (get_objfile_bfd_data): Update.
6860         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6861
6862 2019-05-08  Tom Tromey  <tom@tromey.com>
6863
6864         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6865         Change type.
6866         (get_catch_syscall_inferior_data): Update.
6867         (catch_syscall_inferior_data_cleanup): Remove.
6868         (_initialize_break_catch_syscall): Update.
6869
6870 2019-05-08  Tom Tromey  <tom@tromey.com>
6871
6872         * inflow.c (struct terminal_info): Add destructor and
6873         initializers.
6874         (inflow_inferior_data): Change type.
6875         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6876         (get_inflow_inferior_data, inflow_inferior_exit)
6877         (swap_terminal_info, _initialize_inflow): Update.
6878
6879 2019-05-08  Tom Tromey  <tom@tromey.com>
6880
6881         * target-dcache.c (target_dcache_cleanup): Remove.
6882         (target_dcache_aspace_key): Change type.
6883         (target_dcache_init_p, target_dcache_invalidate)
6884         (target_dcache_get, target_dcache_get_or_init)
6885         (_initialize_target_dcache): Update.
6886         * dcache.h (struct dcache_deleter): New.
6887
6888 2019-05-08  Tom Tromey  <tom@tromey.com>
6889
6890         * symtab.c (struct symbol_cache): Add destructor and
6891         initializers.
6892         (symbol_cache_key): Move.  Change type.
6893         (make_symbol_cache, free_symbol_cache): Remove.
6894         (get_symbol_cache): Update.
6895         (symbol_cache_cleanup): Remove.
6896         (ALL_PSPACES, symbol_cache_flush)
6897         (maintenance_print_symbol_cache)
6898         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6899         Update.
6900
6901 2019-05-08  Tom Tromey  <tom@tromey.com>
6902
6903         * symtab.c (struct main_info): Add destructor and initializers.
6904         (main_progspace_key): Move.  Change type.
6905         (get_main_info): Update.
6906         (main_info_cleanup): Remove.
6907         (_initialize_symtab): Update.
6908
6909 2019-05-08  Tom Tromey  <tom@tromey.com>
6910
6911         * registry.h (DECLARE_REGISTRY): Define the _key class.
6912
6913 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6914
6915         * NEWS: Merge two 'New commands' sections.
6916
6917 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6918
6919         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6920         parameter and use Ada language definition instead.
6921         (ada_val_print_ptr): Remove unused language parameter.
6922         (ada_val_print_num): Remove language parameter and use Ada language
6923         definition instead.
6924         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6925         parameter.
6926         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6927         parameter and use Ada language definition instead.
6928         (ada_val_print_1): Update all ada_val_print_xxx calls.
6929         Remove language parameter.
6930         (ada_val_print): Update ada_val_print_1 call.
6931
6932 2019-05-08  Tom Tromey  <tromey@adacore.com>
6933
6934         * remote.c (remote_hw_watchpoint_limit)
6935         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6936         Now static.
6937
6938 2019-05-08  Tom Tromey  <tromey@adacore.com>
6939
6940         * maint.c (_initialize_maint_cmds): Move initialization code to
6941         remote.c.
6942         (watchdog, show_watchdog): Move to remote.c.
6943         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6944         "watchdog" static.
6945         (_initialize_remote): Move initialization code from maint.c.
6946         * defs.h (watchdog): Don't declare.
6947
6948 2019-05-08  Tom Tromey  <tromey@adacore.com>
6949
6950         * tui/tui-interp.c: Include main.h.
6951         * interps.c: Include main.h.
6952         * main.h (interpreter_p): Declare.
6953         * defs.h (interpreter_p): Don't declare.
6954
6955 2019-05-08  Tom Tromey  <tromey@adacore.com>
6956
6957         * dwarf2loc.c: Include dwarf2read.h.
6958         * defs.h (read_unsigned_leb128): Don't declare.
6959         * dwarf2read.h (read_unsigned_leb128): Declare.
6960
6961 2019-05-08  Tom Tromey  <tromey@adacore.com>
6962
6963         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6964         method.
6965
6966 2019-05-08  Tom Tromey  <tromey@adacore.com>
6967
6968         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6969         when no wrap column is set.
6970
6971 2019-05-08  Tom Tromey  <tromey@adacore.com>
6972
6973         * c-lang.c (c_get_string): Handle non-C-style arrays.
6974
6975 2019-05-08  Tom Tromey  <tromey@adacore.com>
6976
6977         * typeprint.c (print_offset_data::update): Print the bit offset,
6978         not the number of bits remaining.
6979
6980 2019-05-08  Tom Tromey  <tromey@adacore.com>
6981
6982         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6983         padding at end of comment.
6984
6985 2019-05-08  Tom Tromey  <tromey@adacore.com>
6986
6987         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6988         Compare main types.
6989
6990 2019-05-06  Tom Tromey  <tom@tromey.com>
6991
6992         * common/scoped_mmap.c: Include common-defs.h.
6993         * common/scoped_mmap.h: Don't include config.h.
6994
6995 2019-05-04  Tom Tromey  <tom@tromey.com>
6996
6997         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6998         (struct aarch64_call_info): Add initializers.
6999         <si>: Now a std::vector.
7000         (pass_on_stack, aarch64_push_dummy_call): Update.
7001
7002 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7003             Tom Tromey  <tom@tromey.com>
7004
7005         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7006         (ppc_threads): Now a std::vector.  Now static.
7007         (hwdebug_find_thread_points_by_tid)
7008         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7009         Update.
7010
7011 2019-05-04  Tom Tromey  <tom@tromey.com>
7012
7013         * arc-tdep.c (arc_tdesc_init): Return bool.
7014
7015 2019-05-04  Tom Tromey  <tom@tromey.com>
7016
7017         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7018         Use gdb_assert_not_reached.
7019
7020 2019-05-04  Tom Tromey  <tom@tromey.com>
7021
7022         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7023         "false".
7024
7025 2019-05-04  Tom Tromey  <tom@tromey.com>
7026
7027         * arc-tdep.c (arc_tdesc_init): Use bool.
7028
7029 2019-05-04  Tom Tromey  <tom@tromey.com>
7030
7031         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7032
7033 2019-05-04  Tom Tromey  <tom@tromey.com>
7034
7035         * cli/cli-cmds.c (valid_command_p): Return bool.
7036
7037 2019-05-04  Tom Tromey  <tom@tromey.com>
7038
7039         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7040         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7041
7042 2019-05-04  Raul Tambre  <raul@tambre.ee>
7043
7044         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7045         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7046         operator for comparison.
7047
7048 2019-05-04  Tom Tromey  <tom@tromey.com>
7049
7050         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7051         (lookup_partial_symbol, print_partial_symbols)
7052         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7053         (psymbol_compare): Update.
7054         (add_psymbol_to_bcache): Clear the entire psymbol.
7055         (maintenance_check_psymtabs): Update.
7056         * psympriv.h (struct partial_symbol): Don't derive from
7057         general_symbol_info.
7058         <obj_section, unrelocated_address, address,
7059         set_unrelocated_address>: Update.
7060         <ginfo>: New member.
7061         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7062         (debug_names::write_psymbols): Update.
7063
7064 2019-05-04  Tom de Vries  <tdevries@suse.de>
7065
7066         * contrib/cc-with-tweaks.sh: Support -n arg.
7067
7068 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7069
7070         * corelow.c (core_target::detach): Ensure frame cache and
7071         register caches are cleared.
7072         inferior.c (exit_inferior_1): Likewise.
7073
7074 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7075             Tom Tromey  <tom@tromey.com>
7076
7077         * dictionary.c (collate_pending_symbols_by_language): Remove
7078         "struct" from foreach.
7079         * symtab.c (lookup_global_symbol_from_objfile)
7080         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7081         foreach.
7082         * ser-tcp.c (net_open): Remove "struct" from foreach.
7083         * objfiles.c (objfile_relocate, objfile_rebase)
7084         (objfile_has_symbols): Remove "struct" from foreach.
7085         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7086         from foreach.
7087         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7088         foreach.
7089         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7090         "struct" from foreach.
7091         * ada-lang.c (create_excep_cond_exprs)
7092         (ada_exception_catchpoint_cond_string): Remove "struct" from
7093         foreach.
7094
7095 2019-05-03  Tom Tromey  <tromey@adacore.com>
7096
7097         * ada-exp.y (convert_char_literal): Check suffix of each
7098         enumerator.
7099
7100 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7101
7102         PR ada/21406:
7103         * ada-exp.y (yywrap): Don't define.
7104         * ada-lex.l (%option): Add noyywrap
7105         (yywrap): Remove.
7106
7107 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7108
7109         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7110         _WIN32_WINNT to the XP level, unless already defined to a higher
7111         level.
7112
7113         * unittests/parse-connection-spec-selftests.c:
7114         * ser-tcp.c:
7115         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7116         override.
7117
7118         * symfile.c (find_separate_debug_file): Remove colon from the
7119         drive spec of DOS/Windows file names of the target, so that the
7120         file name produced from DEBUGDIR and the target's directory will
7121         be valid on DOS/Windows systems.
7122
7123 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * rust-lang.c (val_print_struct): Handle printing structures
7126         containing strings.
7127
7128 2019-05-02  Tom Tromey  <tromey@adacore.com>
7129
7130         * valarith.c (_initialize_valarith): Remove.
7131
7132 2019-05-01  Tom Tromey  <tromey@adacore.com>
7133
7134         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7135         bitfields.
7136
7137 2019-05-01  Tom Tromey  <tromey@adacore.com>
7138
7139         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7140         for big-endian copies.
7141
7142 2019-04-30  Ali Tamur  <tamur@google.com>
7143         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7144         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7145         (read_3_bytes): New function.
7146
7147 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7148
7149         * windows-nat.c (main_thread_id): Delete.
7150         (handle_output_debug_string): Replace main_thread_id by
7151         current_event.dwThreadId.
7152         (fake_create_process): Likewise.
7153         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7154         Do not set main_thread_id.
7155         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7156         current_event.dwThreadId.
7157         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7158
7159 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7160
7161         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7162         Use current_event.dwThreadId instead of main_thread_id.
7163
7164 2019-04-30  Tom Tromey  <tromey@adacore.com>
7165
7166         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7167         (create_excep_cond_exprs): Iterate over program spaces.
7168         (ada_exception_catchpoint_cond_string): Examine all minimal
7169         symbols for exception types.
7170
7171 2019-04-30  Tom Tromey  <tromey@adacore.com>
7172
7173         PR c++/24470:
7174         * dwarf2read.c (process_structure_scope): Handle case where type
7175         has template parameters but no symbol was created.
7176
7177 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7178             Chris January  <chris.january@arm.com>
7179
7180         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7181         qualifier.
7182         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7183
7184 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * f-typeprint.c (f_print_type): Update rules for printing
7187         whitespace.
7188         (f_type_print_varspec_suffix): Likewise.
7189
7190 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7191             Chris January  <chris.january@arm.com>
7192
7193         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7194         function arguments.
7195
7196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7197
7198         * f-lang.c (build_fortran_types): Change name of void type to
7199         lower case.
7200         * f-typeprint.c (f_type_print_base): Print the name of the void
7201         type, rather than a fixed string.
7202         * f-valprint.c (f_decorations): Use lower case void string.
7203
7204 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7205             Chris January  <chris.january@arm.com>
7206
7207         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7208         types for Fortran.
7209
7210 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7211             Chris January  <chris.january@arm.com>
7212             David Lecomber  <david.lecomber@arm.com>
7213
7214         * f-exp.y (BINOP_INTRINSIC): New token.
7215         (exp): New parser rule handling BINOP_INTRINSIC.
7216         (f77_keywords): Add new builtin procedures.
7217         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7218         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7219         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7220         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7221         (print_unop_subexp_f): New function.
7222         (print_binop_subexp_f): New function.
7223         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7224         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7225         (dump_subexp_body_f): Likewise.
7226         (operator_check_f): Likewise.
7227         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7228         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7229
7230 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7231
7232         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7233         UNOP_KIND.
7234         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7235         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7236         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7237         (operator_length_f): New fuction.
7238         (print_subexp_f): New function.
7239         (op_name_f): New function.
7240         (dump_subexp_body_f): New function.
7241         (operator_check_f): New function.
7242         (exp_descriptor_f): Replace standard expression handling functions
7243         with new functions.
7244         * gdb/fortran-operator.def: New file.
7245         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7246         * gdb/std-operator.def: Remove UNOP_KIND.
7247
7248 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * std-operator.def: Remove unbalanced, stray double quote
7251         character.
7252
7253 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7254             Chris January  <chris.january@arm.com>
7255             Daniel Everett  <daniel.everett@arm.com>
7256             Nick Forrington  <nick.forrington@arm.com>
7257             Richard Bunt  <richard.bunt@arm.com>
7258
7259         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7260         of depth when printing anonymous structs or unions.
7261         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7262         Don't print either the top-level value, or the children if the
7263         max-depth is exceeded.
7264         (ppscm_print_children): When printing the key of a map, allow one
7265         extra level of depth.
7266         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7267         print either the top-level value, or the children if the max-depth
7268         is exceeded.
7269         (print_children): When printing the key of a map, allow one extra
7270         level of depth.
7271         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7272         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7273         (user_print_options): Initialise max_depth field.
7274         (val_print_scalar_or_string_type_p): New function.
7275         (val_print): Check to see if the max depth has been reached.
7276         (val_print_check_max_depth): Define new function.
7277         (show_print_max_depth): New function.
7278         (_initialize_valprint): Add 'print max-depth' option.
7279         * valprint.h (struct value_print_options) <max_depth>: New field.
7280         (val_print_check_max_depth): Declare new function.
7281         * NEWS: Document new feature.
7282
7283 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7284
7285         * ada-lang.c (ada_language_defn): Initialise new field.
7286         * c-lang.c (c_is_string_type_p): New function.
7287         (c_language_defn): Initialise new field.
7288         (cplus_language_defn): Initialise new field.
7289         (asm_language_defn): Initialise new field.
7290         (minimal_language_defn): Initialise new field.
7291         * c-lang.h (c_is_string_type_p): Declare new function.
7292         * d-lang.c (d_language_defn): Initialise new field.
7293         * f-lang.c (f_is_string_type_p): New function.
7294         (f_language_defn): Initialise new field.
7295         * go-lang.c (go_is_string_type_p): New function.
7296         (go_language_defn): Initialise new field.
7297         * language.c (default_is_string_type_p): New function.
7298         (unknown_language_defn): Initialise new field.
7299         (auto_language_defn): Initialise new field.
7300         * language.h (struct language_defn) <la_is_string_type_p>: New
7301         member variable.
7302         (default_is_string_type_p): Declare new function.
7303         * m2-lang.c (m2_language_defn): Initialise new field.
7304         * objc-lang.c (objc_language_defn): Initialise new field.
7305         * opencl-lang.c (opencl_language_defn): Initialise new field.
7306         * p-lang.c (pascal_is_string_type_p): New function.
7307         (pascal_language_defn): Initialise new field.
7308         * rust-lang.c (rust_is_string_type_p): New function.
7309         (rust_language_defn): Initialise new field.
7310
7311 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7314         New field.
7315         * ada-lang.c (ada_language_defn): Initialise new field.
7316         * c-lang.c (c_language_defn): Likewise.
7317         (cplus_language_defn): Likewise.
7318         (asm_language_defn): Likewise.
7319         (minimal_language_defn): Likewise.
7320         * d-lang.c (d_language_defn): Likewise.
7321         * f-lang.c (f_language_defn): Likewise.
7322         * go-lang.c (go_language_defn): Likewise.
7323         * language.c (unknown_language_defn): Likewise.
7324         (auto_language_defn): Likewise.
7325         * m2-lang.c (m2_language_defn): Likewise.
7326         * objc-lang.c (objc_language_defn): Likewise.
7327         * opencl-lang.c (opencl_language_defn): Likewise.
7328         * p-lang.c (pascal_language_defn): Likewise.
7329         * rust-lang.c (rust_language_defn): Likewise.
7330
7331 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7332
7333         * ada-lang.c (ada_is_character_type): Change return type to bool.
7334         (ada_is_string_type): Likewise.
7335         * ada-lang.h (ada_is_character_type): Update declaration
7336         (ada_is_string_type): Likewise.
7337
7338 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7339
7340         Support style in 'frame|thread apply'
7341
7342         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7343         * record.c (record_start, record_stop): Update callers of
7344         execute_command_to_string with false.
7345         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7346         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7347         methods.
7348         (class string_file): New constructor with term_out parameter.
7349         Override methods term_out and can_emit_style_escape.  New member
7350         term_out.
7351         (class stdio_file): Override can_emit_style_escape.
7352         (class tee_file): Override term_out and can_emit_style_escape.
7353         * utils.h (can_emit_style_escape): Remove.
7354         * utils.c (can_emit_style_escape): Likewise.
7355         Update all callers of can_emit_style_escape (SOMESTREAM) to
7356         SOMESTREAM->can_emit_style_escape.
7357         * source-cache.c (source_cache::get_source_lines): Likewise.
7358         * stack.c (frame_apply_command_count): Call execute_command_to_string
7359         passing the term_out characteristic of the current gdb_stdout.
7360         * thread.c (thr_try_catch_cmd): Likewise.
7361         * top.c (execute_command_to_string): pass term_out parameter
7362         to construct the string_file for the command output.
7363         * ui-file.c (term_cli_styling): New function (most code moved
7364         from utils.c can_emit_style_escape).
7365         (string_file::string_file, string_file::can_emit_style_escape,
7366         stdio_file::can_emit_style_escape, tee_file::term_out,
7367         tee_file::can_emit_style_escape): New functions.
7368
7369 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7370
7371         * NEWS: Mention the new set|show may-call-functions.
7372         * infcall.c (may_call_functions_p): New variable.
7373         (show_may_call_functions_p): New function.
7374         (call_function_by_hand_dummy): Throws an error if not
7375         may-call-functions.
7376         (_initialize_infcall): Call add_setshow_boolean_cmd for
7377         may-call-functions.
7378
7379 2019-04-25  Keith Seitz  <keiths@redhat.com>
7380
7381         PR c++/24367
7382         * cp-support.c (inspect_type): Don't attempt substitutions
7383         of symbol with the same name.
7384
7385 2019-04-25  Tom Tromey  <tromey@adacore.com>
7386
7387         PR gdb/24475:
7388         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7389         static.
7390
7391 2019-04-25  Tom Tromey  <tromey@adacore.com>
7392
7393         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7394         rvalue reference.
7395         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7396         (gdb_xml_parser::parse): Use std::move.
7397         * python/python-internal.h (gdbpy_convert_exception): Take a const
7398         reference.
7399         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7400         std::move.
7401         * python/py-utils.c (gdbpy_convert_exception): Take a const
7402         reference.
7403         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7404         Use std::move.
7405         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7406         Use std::move.
7407         * mi/mi-main.c (mi_print_exception): Take a const reference.
7408         * main.c (handle_command_errors): Take a const reference.
7409         * linespec.c (parse_linespec): Use std::move.
7410         * infcall.c (run_inferior_call): Use std::move.
7411         (call_function_by_hand_dummy): Use std::move.
7412         * exec.c (try_open_exec_file): Use std::move.
7413         * exceptions.h (exception_print, exception_fprintf)
7414         (exception_print_same): Update.
7415         * exceptions.c (print_exception, exception_print)
7416         (exception_fprintf, exception_print_same): Change parameters to
7417         const reference.
7418         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7419         * common/new-op.c: Use std::move.
7420         * common/common-exceptions.h (struct gdb_exception): Add move
7421         constructor.
7422         (struct gdb_exception_error, struct gdb_exception_quit, struct
7423         gdb_quit_bad_alloc): Change constructor to move constructor.
7424         (throw_exception): Change parameter to rvalue reference.
7425         * common/common-exceptions.c (throw_exception): Take rvalue
7426         reference.
7427         * cli/cli-interp.c (safe_execute_command): Use std::move.
7428         * breakpoint.c (insert_bp_location, location_to_sals): Use
7429         std::move.
7430
7431 2019-04-25  Tom Tromey  <tromey@adacore.com>
7432
7433         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7434         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7435         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7436         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7437         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7438         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7439         guile/scm-value.c: Use unpack.
7440         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7441         gdbscm_gdb_exception.
7442         (gdbscm_throw_gdb_exception): Likewise.
7443         (struct gdbscm_gdb_exception): New.
7444         (unpack): New function.
7445         (gdbscm_wrap): Use unpack.
7446
7447 2019-04-25  Tom Tromey  <tromey@adacore.com>
7448
7449         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7450         (gdb_rl_callback_handler): Use std::move.
7451         * common/common-exceptions.h (struct gdb_exception): Add move
7452         assignment operator.
7453         (throw_exception_sjlj): Change "exception" to const reference.
7454         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7455         (throw_exception_sjlj): Change "exception" to const reference.
7456
7457 2019-04-25  Tom Tromey  <tromey@adacore.com>
7458
7459         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7460         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7461         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7462         Update.
7463         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7464         Update.
7465         * mi/mi-interp.c (mi_interp::exec): Update.
7466         * linespec.c (parse_linespec): Update.
7467         * infcall.c (run_inferior_call): Update.
7468         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7469         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7470         (gdbscm_lookup_global_symbol): Update.
7471         * guile/scm-param.c (gdbscm_parameter_value): Update.
7472         * guile/scm-frame.c (gdbscm_frame_read_register)
7473         (gdbscm_frame_read_var): Update.
7474         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7475         * exec.c (try_open_exec_file): Update.
7476         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7477         (gdb_rl_callback_handler): Update.
7478         * common/common-exceptions.h (exception_none): Don't declare.
7479         * common/common-exceptions.c (exception_none): Don't define.
7480         (struct catcher) <exception>: Update.
7481         * cli/cli-interp.c (safe_execute_command): Update.
7482         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7483
7484 2019-04-25  Ali Tamur  <tamur@google.com>
7485
7486         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7487         (read_attribute_value): Likewise.
7488         (dwarf2_read_addr_index): Update comment.
7489         (read_str_index): Add DW_FORM_strx.
7490         (dwarf2_string_attr): Likewise.
7491         (dwarf2_const_value_attr): Likewise.
7492         (dump_die_shallow): Likewise.
7493         (dwarf2_fetch_constant_bytes): Likewise.
7494         (skip_form_bytes): Likewise.
7495         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7496
7497 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7498
7499         PR corefiles/11608
7500         PR corefiles/18187
7501         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7502         OFFSET.  Verify if current mapping contains an ELF header.
7503         (linux_find_memory_regions_full): Adjust call to
7504         dump_mapping_p.
7505
7506 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7507             Kang Li <kanglictf@gmail.com>
7508
7509         PR gdb/21600
7510
7511         * dwarf2-frame.c (read_initial_length): Be consistent about using
7512         unsigned representation of length.
7513         (decode_frame_entry_1): Likewise.  Check for wraparound of
7514         end pointer as well as buffer overflow.
7515
7516 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7517
7518         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7519         "vq".
7520
7521 2019-04-24  Tom Tromey  <tromey@adacore.com>
7522
7523         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7524
7525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7526
7527         * s12z-tdep.c (s12z_unwind_pc): Delete.
7528         (s12z_unwind_sp): Delete.
7529         (s12z_gdbarch_init): Don't register deleted functions with
7530         gdbarch.
7531
7532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7533
7534         * rl78-tdep.c (rl78_unwind_sp): Delete.
7535         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7536
7537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7538
7539         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7540         (xstormy16_unwind_pc): Delete.
7541         (xstormy16_dummy_id): Delete.
7542         (xstormy16_gdbarch_init): Don't register deleted functions with
7543         gdbarch.
7544
7545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * vax-tdep.c (vax_unwind_pc): Delete.
7548         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7549
7550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * v850-tdep.c (v850_unwind_sp): Delete.
7553         (v850_unwind_pc): Delete.
7554         (v850_dummy_id): Delete.
7555         (v850_gdbarch_init): Don't register deleted functions with
7556         gdbarch.
7557
7558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7561         (tilegx_unwind_pc): Delete.
7562         (tilegx_unwind_dummy_id): Delete.
7563         (tilegx_gdbarch_init): Don't register deleted functions with
7564         gdbarch.
7565
7566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7569         (tic6x_dummy_id): Delete.
7570         (tic6x_gdbarch_init): Don't register deleted functions with
7571         gdbarch.
7572
7573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7574
7575         * sparc-tdep.c (sparc_unwind_pc): Delete.
7576         (sparc32_gdbarch_init): Don't register deleted function with
7577         gdbarch.
7578
7579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7580
7581         * sh-tdep.c (sh_unwind_sp): Delete.
7582         (sh_unwind_pc): Delete.
7583         (sh_dummy_id): Delete.
7584         (sh_gdbarch_init): Don't register deleted functions with
7585         gdbarch.
7586
7587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * score-tdep.c (score_unwind_sp): Delete.
7590         (score_unwind_pc): Delete.
7591         (score_dummy_id): Delete.
7592         (score_gdbarch_init): Don't register deleted functions with
7593         gdbarch.
7594
7595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * rx-tdep.c (rx_unwind_pc): Delete.
7598         (rx_unwind_sp): Delete.
7599         (rx_dummy_id): Delete.
7600         (rx_gdbarch_init): Don't register deleted functions with
7601         gdbarch.  Update comment.
7602
7603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7606         (rs6000_dummy_id): Delete.
7607         (rs6000_gdbarch_init): Don't register deleted functions with
7608         gdbarch.
7609
7610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * or1k-tdep.c (or1k_dummy_id): Delete.
7613         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7614
7615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * nios2-tdep.c (nios2_dummy_id): Delete.
7618         (nios2_unwind_sp): Delete.
7619         (nios2_gdbarch_init): Don't register deleted functions with
7620         gdbarch.
7621
7622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * nds32-tdep.c (nds32_dummy_id): Delete.
7625         (nds32_unwind_pc): Delete.
7626         (nds32_unwind_sp): Delete.
7627         (nds32_gdbarch_init): Don't register deleted functions with
7628         gdbarch.
7629
7630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * msp430-tdep.c (msp430_unwind_pc): Delete.
7633         (msp430_unwind_sp): Delete.
7634         (msp430_dummy_id): Delete.
7635         (msp430_gdbarch_init): Don't register deleted functions with
7636         gdbarch.
7637
7638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7639
7640         * moxie-tdep.c (moxie_unwind_sp): Delete.
7641         (moxie_unwind_pc): Delete.
7642         (moxie_dummy_id): Delete.
7643         (moxie_gdbarch_init): Don't register deleted functions with
7644         gdbarch.
7645
7646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7647
7648         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7649         (mn10300_unwind_pc): Delete.
7650         (mn10300_unwind_sp): Delete.
7651         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7652         mn10300_unwind_sp.
7653         (mn10300_frame_unwind_init): Don't register deleted functions with
7654         gdbarch.
7655
7656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * mep-tdep.c (mep_unwind_pc): Delete.
7659         (mep_unwind_sp): Delete.
7660         (mep_dummy_id): Delete.
7661         (mep_gdbarch_init): Don't register deleted functions with
7662         gdbarch.
7663
7664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7665
7666         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7667         (m68hc11_unwind_sp): Delete.
7668         (m68hc11_gdbarch_init): Don't register deleted functions with
7669         gdbarch.
7670
7671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * m32r-tdep.c (m32r_unwind_sp): Delete.
7674         (m32r_unwind_pc): Delete.
7675         (m32r_dummy_id): Delete.
7676         (m32r_gdbarch_init): Don't register deleted functions with
7677         gdbarch.
7678
7679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * m32c-tdep.c (m32c_unwind_pc): Delete.
7682         (m32c_unwind_sp): Delete.
7683         (m32c_dummy_id): Delete.
7684         (m32c_gdbarch_init): Don't register deleted functions with
7685         gdbarch.
7686
7687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7690         (lm32_unwind_pc): Delete.
7691         (lm32_dummy_id): Delete.
7692         (lm32_gdbarch_init): Don't register deleted functions with
7693         gdbarch.
7694
7695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7696
7697         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7698         (iq2000_unwind_pc): Delete.
7699         (iq2000_dummy_id): Delete.
7700         (iq2000_gdbarch_init): Don't register deleted functions with
7701         gdbarch.
7702
7703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * nds32-tdep.c (nds32_type_align): Delete.
7706         (nds32_push_dummy_call): Use type_align instead.
7707
7708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * arm-tdep.c (arm_type_align): Only handle vector override case.
7711         (arm_push_dummy_call): Use type_align.
7712         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7713
7714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7717         case.
7718         (pass_on_stack): Use type_align.
7719         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7720         function.
7721
7722 2019-04-23  Tom Tromey  <tromey@adacore.com>
7723
7724         * dwarf2read.c (line_header::file_name_at): Remove unused
7725         overload.
7726
7727 2019-04-23  Tom de Vries  <tdevries@suse.de>
7728
7729         PR gdb/24438
7730         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7731         invocation.
7732
7733
7734 2019-03-27  Ali Tamur  <tamur@google.com>
7735
7736         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7737         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7738         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7739         (dwarf_expr_context::get_addr_index): Likewise
7740         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7741         (symbol_needs_eval_context::get_addr_index): Likewise
7742         (disassemble_dwarf_expression): Add DW_OP_addrx
7743         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7744         (read_cutu_die_from_dwo): Update comment
7745         (skip_one_die): Add DW_FORM_addrx
7746         (read_attribute_value): Likewise
7747         (var_decode_location): Add DW_OP_addrx
7748         (dwarf2_const_value_attr): Add DW_FORM_addrx
7749         (dump_die_shallow): Likewise
7750         (dwarf2_fetch_constant_bytes): Likewise
7751         (decode_locdesc): Add DW_OP_addrx
7752         (skip_form_bytes): Add DW_FORM_addrx
7753
7754 2019-04-22  Ali Tamur  <tamur@google.com>
7755
7756         * MAINTAINERS (Write After Approval): Add self.
7757
7758 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7759
7760         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7761         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7762         (open_symbol_file_object): Likewise.
7763         (svr4_default_sos): Add info parameter.
7764         (svr4_read_so_list): Likewise.
7765         (svr4_current_sos_direct): Adjust functions calls to pass down
7766         info.
7767         (svr4_current_sos_1): Add info parameter.
7768         (svr4_current_sos): Call get_svr4_info, pass info down to
7769         svr4_current_sos_1.
7770         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7771         get_svr4_info.
7772         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7773         get_svr4_info.
7774         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7775         to get_svr4_info.
7776         (probes_table_remove_objfile_probes): Likewise.
7777         (register_solib_event_probe): Add info parameter.
7778         (solist_update_incremental): Pass info parameter down to
7779         svr4_read_so_list.
7780         (disable_probes_interface): Add info parameter.
7781         (svr4_handle_solib_event): Pass current_program_space to
7782         get_svr4_info.  Adjust disable_probes_interface cleanup.
7783         (svr4_create_probe_breakpoints): Add info parameter, pass it
7784         down to register_solib_event_probe.
7785         (svr4_create_solib_event_breakpoints): Add info parameter,
7786         pass it down to svr4_create_probe_breakpoints.
7787         (enable_break): Pass info down to
7788         svr4_create_solib_event_breakpoints.
7789         (svr4_solib_create_inferior_hook): Pass current_program_space to
7790         get_svr4_info.
7791         (svr4_clear_solib): Likewise.
7792
7793 2019-04-22  Pedro Alves  <palves@redhat.com>
7794
7795         * solib-svr4.c (svr4_free_objfile_observer): New.
7796         (probe_and_action::objfile): New field.
7797         (probes_table_htab_remove_objfile_probes)
7798         (probes_table_remove_objfile_probes): New functions.
7799         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7800         in the new probe_and_action.  Don't store the probe in 'lookup'.
7801         (svr4_create_probe_breakpoints): Pass objfile to
7802         register_solib_event_probe.
7803         (_initialize_svr4_solib): Register a free_objfile observer.
7804
7805 2019-04-19  Tom Tromey  <tom@tromey.com>
7806
7807         * common/queue.h: Remove.
7808
7809 2019-04-19  Tom Tromey  <tom@tromey.com>
7810
7811         * event-loop.c: Don't include "common/queue.h".
7812
7813 2019-04-19  Tom Tromey  <tom@tromey.com>
7814
7815         * remote.c (remote_target): Use delete.
7816         * remote-notif.h: Include <list>, not "common/queue.h".
7817         (notif_client_p): Remove typedef.
7818         (remote_notif_state): Add constructor, destructor, initializer.
7819         <notif_queue>: Now a std::list.
7820         (remote_notif_state_xfree): Don't declare.
7821         * remote-notif.c (remote_notif_process, handle_notification)
7822         (remote_notif_state_allocate): Update.
7823         (~remote_notif_state): Rename from remote_notif_state_xfree.
7824
7825 2019-04-19  Tom Tromey  <tom@tromey.com>
7826
7827         * symfile.c (reread_symbols): Update.
7828         * objfiles.c (objfile_register_static_link)
7829         (objfile_lookup_static_link): Update
7830         (~objfile) Don't delete static_links.
7831         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7832
7833 2019-04-19  Tom Tromey  <tom@tromey.com>
7834
7835         * type-stack.h (struct type_stack) <insert>: Constify string.
7836         * type-stack.c (type_stack::insert): Constify string.
7837         * gdbtypes.h (lookup_template_type): Update.
7838         (address_space_name_to_int): Update.
7839         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7840         const.
7841         (lookup_template_type): Make name const.
7842         * c-exp.y: Update rules.
7843         (lex_one_token, classify_name, classify_inner_name)
7844         (c_print_token): Update.
7845         * p-exp.y: Update rules.
7846         (yylex): Update.
7847         * f-exp.y: Update rules.
7848         (yylex): Update.
7849         * d-exp.y: Update rules.
7850         (lex_one_token, classify_name, classify_inner_name): Update.
7851         * parse.c (write_dollar_variable, copy_name): Return std::string.
7852         * parser-defs.h (copy_name): Change return type.
7853         * m2-exp.y: Update rules.
7854         (yylex): Update.
7855         * go-exp.y (lex_one_token): Update.
7856         Update rules.
7857         (classify_unsafe_function, classify_packaged_name)
7858         (classify_name, yylex): Update.
7859
7860 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7861
7862         * configure.ac: add --enable-source-highlight switch.
7863         * configure: Regenerate.
7864         * top.c (print_gdb_version): plumb --enable-source-highlight
7865         status to "show configuration".
7866
7867 2019-04-19  Tom Tromey  <tromey@adacore.com>
7868
7869         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7870         Check ADA_TYPE_P.
7871         (empty_record, ada_template_to_fixed_record_type_1)
7872         (template_to_static_fixed_type)
7873         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7874         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7875         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7876         macros.
7877
7878 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7879
7880         PR symtab/24423:
7881         * source.c (print_source_lines_base): Advance "iter" when a
7882         control character is seen.
7883
7884 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7885
7886         * inferior.h (struct infcall_suspend_state_deleter):
7887         Catch exception in destructor to avoid crash.
7888
7889 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7892         close to the add_com "shell".
7893
7894 2019-04-18  Tom Tromey  <tromey@adacore.com>
7895
7896         * process-stratum-target.h (class process_stratum_target)
7897         <stratum>: Add "final".
7898
7899 2019-04-17  Tom Tromey  <tromey@adacore.com>
7900
7901         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7902         against nullptr before use.
7903
7904 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7905
7906         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7907
7908 2019-04-17  Jim Wilson  <jimw@sifive.com>
7909             Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7912         code read might fail, assume 4-byte breakpoint in that case.
7913
7914 2019-04-15  Leszek Swirski  <leszeks@google.com>
7915
7916         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7917         rather than a hand-rolled POD check when checking for forced MEMORY
7918         classification.
7919
7920 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7921
7922         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7923         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7924         function.
7925         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7926         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7927         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7928         declaration.
7929
7930 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7931
7932         * aarch64-linux-nat.c
7933         (aarch64_linux_nat_target::thread_architecture): Add override.
7934         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7935         each VQ.
7936
7937 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7938
7939         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7940
7941 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7944         target types of size 96-bits, add some additional comments, and
7945         check that the builtin type we found was the correct size.
7946
7947 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7948
7949         * utils.c (prompt_for_continue): Don't restore the styling at the
7950         end, as applied_style has the wrong value.  This fixes styling in
7951         long lists of file names that are interrupted by the "Continue?"
7952         prompt.
7953
7954 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7957         * c-lang.c (c_language_defn): Likewise.
7958         (cplus_language_defn): Likewise.
7959         (asm_language_defn): Likewise.
7960         (minimal_language_defn): Likewise.
7961         * d-lang.c (d_language_defn): Likewise.
7962         * f-lang.c (f_language_defn): Likewise.
7963         * go-lang.c (go_language_defn): Likewise.
7964         * language.c (unknown_language_defn): Likewise.
7965         (auto_language_defn): Likewise.
7966         * language.h (struct language_defn): Remove la_magic field.
7967         (LANG_MAGIC): Delete.
7968         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7969         * objc-lang.c (objc_language_defn): Likewise.
7970         * opencl-lang.c (opencl_language_defn): Likewise.
7971         * p-lang.c (pascal_language_defn): Likewise.
7972         * rust-lang.c (rust_language_defn): Likewise.
7973
7974 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7975
7976         * riscv-tdep.c (riscv_type_align): New function.
7977         (riscv_type_alignment): Delete.
7978         (riscv_arg_location): Use 'type_align'.
7979         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7980
7981 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * gdbtypes.c (type_align): A struct with no non-static fields also
7984         has alignment of 1.
7985
7986 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7989         component to 0.
7990         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7991         member.
7992         (riscv_struct_info::analyse): New implementation using new
7993         analyse_inner member function.
7994         (riscv_struct_info::field_offset): New member function.
7995         (riscv_struct_info::m_offsets): New member variable.
7996         (riscv_struct_info::analyse_inner): New private member function,
7997         takes the old implementation of riscv_struct_info::analyse but
7998         extended to track field offsets.
7999         (riscv_call_arg_struct): Update the struct folding special cases
8000         to handle cases where empty C++ structs, which are non-zero
8001         length, are found.
8002         (riscv_arg_location): Initialise the length of each location, a
8003         non-zero length now indicates the location is in use.
8004         (riscv_push_dummy_call): Allow for the first location having a
8005         non-zero offset when setting up arguments.
8006         (riscv_return_value): Likewise, but for return values.
8007
8008 2019-04-11  Tom Tromey  <tromey@adacore.com>
8009
8010         * utils.c (internal_vproblem): Make "msg" const.
8011
8012 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8013
8014         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8015         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8016         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8017         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8018
8019 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8020
8021         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8022         function.
8023         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8024         of amd64_collect_native_gregset.
8025         (amd64_linux_nat_target::store_registers): Likewise.
8026
8027 2019-04-10  Tom Tromey  <tom@tromey.com>
8028
8029         * symtab.c (lookup_global_symbol_from_objfile)
8030         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8031         * objfiles.h (class separate_debug_iterator): New.
8032         (class separate_debug_range): New.
8033         (struct objfile) <separate_debug_objfiles>: New method.
8034         (objfile_separate_debug_iterate): Don't declare.
8035         * objfiles.c (separate_debug_iterator::operator++): Rename from
8036         objfile_separate_debug_iterate.
8037         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8038         iterator.
8039         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8040         iterator.
8041
8042 2019-04-10  Tom Tromey  <tom@tromey.com>
8043
8044         * symfile.c (reread_symbols): Remove old comment.
8045         * objfiles.c (free_all_objfiles): Fix a typo.
8046
8047 2019-04-10  Tom Tromey  <tom@tromey.com>
8048
8049         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8050         * minsyms.c (lookup_minimal_symbol): Use foreach.
8051         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8052         (lookup_minimal_symbol_solib_trampoline): Likewise.
8053         * symfile.c (reread_symbols): Use foreach.
8054
8055 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8056             Tom Tromey  <tromey@adacore.com>
8057
8058         PR rust/24414:
8059         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8060         (rust_lex_int_test): Change "value" to be LONGEST.
8061         (rust_lex_tests): Add test for long integer literal.
8062
8063 2019-04-09  Tom Tromey  <tromey@adacore.com>
8064
8065         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8066         to bool.
8067         (extended_remote_target::attach): Update.
8068         (remote_target::remote_notice_new_inferior): Update.
8069         (remote_target::add_current_inferior_and_thread): Update.
8070         * inferior.c (exit_inferior_1): Use "false".
8071         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8072
8073 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8074
8075         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8076         the "start" command.
8077
8078 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8079
8080         * python/py-inferior.c (infpy_thread_from_thread_handle):
8081         Adjust comments to reflect renaming of thread_from_thread_handle
8082         to thread_from_handle.  Adjust keywords.  Fix type error message.
8083         (inferior_object_methods): Add thread_from_handle.  Retain
8084         thread_from_thread_handle, but mark it as deprecated.
8085
8086 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8087
8088         * gdbthread.h (find_thread_by_handle): Revise declaration.
8089         * thread.c (find_thread_by_handle): Likewise.  Adjust
8090         implementation too.
8091         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8092         support for buffer objects as handles.
8093
8094 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8095
8096         * python/py-infthread.c (thpy_thread_handle): New function.
8097         (thread_object_methods): Register thpy_thread_handle.
8098
8099 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8100
8101         * gdbthread.h (thread_to_thread_handle): Declare.
8102         * thread.c (gdbtypes.h): Include.
8103         (thread_to_thread_handle): New function.
8104
8105         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8106         (target_thread_info_to_thread_handle): Declare.
8107         * target.c (target_thread_info_to_thread_handle): New function.
8108         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8109         * target-delegates.c: Regenerate.
8110
8111         * linux-thread-db.c (class thread_db_target): Add method
8112         thread_info_to_thread_handle.
8113         (thread_db_target::thread_info_to_thread_handle): Define.
8114         * remote.c (class remote_target): Add new method
8115         thread_info_to_thread_handle.
8116         (remote_target::thread_info_to_thread_handle): Define.
8117
8118 2019-04-08  Pedro Alves  <palves@redhat.com>
8119
8120         * common/common-exceptions.c (throw_exception): Don't create
8121         named object to throw; throw directly.
8122         (throw_it): Likewise.  Don't initialize gdb_exception::message
8123         here, with new; pass FMT and AP to the ctor instead.
8124         * common/common-exceptions.h: Include <string>.
8125         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8126         const char *, va_list)): New ctor.  Use std::make_shared.
8127         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8128         errors)): Delete.
8129         (gdb_exception_error::gdb_exception_error(enum errors, const char
8130         *, va_list)): New.
8131         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8132         Add assertion.
8133         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8134         errors)): Delete.
8135         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8136         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8137         Add assertion.
8138
8139 2019-04-08  Tom Tromey  <tom@tromey.com>
8140
8141         * valops.c (value_rtti_indirect_type): Replace throw_exception
8142         with throw.
8143         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8144         with throw.
8145         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8146         throw.
8147         * target.c (target_translate_tls_address): Replace throw_exception
8148         with throw.
8149         * stack.c (frame_apply_command_count): Replace throw_exception
8150         with throw.
8151         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8152         throw.
8153         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8154         with throw.
8155         * rs6000-tdep.c (rs6000_frame_cache)
8156         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8157         * remote.c: Replace throw_exception with throw.
8158         * record-full.c (record_full_message, record_full_wait_1)
8159         (record_full_restore): Replace throw_exception with throw.
8160         * record-btrace.c:
8161         (get_thread_current_frame_id, record_btrace_start_replaying)
8162         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8163         (cmd_record_btrace_start): Replace throw_exception with throw.
8164         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8165         throw.
8166         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8167         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8168         * linespec.c:
8169         (find_linespec_symbols): Replace throw_exception with throw.
8170         * infrun.c (displaced_step_prepare, resume): Replace
8171         throw_exception with throw.
8172         * infcmd.c (post_create_inferior): Replace throw_exception with
8173         throw.
8174         * inf-loop.c (inferior_event_handler): Replace throw_exception
8175         with throw.
8176         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8177         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8178         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8179         (get_prev_frame_always, get_frame_pc_if_available)
8180         (get_frame_address_in_block_if_available, get_frame_language):
8181         Replace throw_exception with throw.
8182         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8183         throw_exception with throw.
8184         * eval.c (fetch_subexp_value, evaluate_var_value)
8185         (evaluate_funcall, evaluate_subexp_standard): Replace
8186         throw_exception with throw.
8187         * dwarf2loc.c (call_site_find_chain)
8188         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8189         Replace throw_exception with throw.
8190         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8191         with throw.
8192         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8193         throw.
8194         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8195         * completer.c (complete_line_internal): Replace throw_exception
8196         with throw.
8197         * compile/compile-object-run.c (compile_object_run): Replace
8198         throw_exception with throw.
8199         * cli/cli-script.c (process_next_line): Replace throw_exception
8200         with throw.
8201         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8202         (btrace_enable, btrace_maint_update_pt_packets): Replace
8203         throw_exception with throw.
8204         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8205         throw_exception with throw.
8206         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8207         throw_exception with throw.
8208         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8209         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8210         * aarch64-tdep.c (aarch64_make_prologue_cache)
8211         (aarch64_make_stub_cache): Replace throw_exception with throw.
8212
8213 2019-04-08  Tom Tromey  <tom@tromey.com>
8214
8215         * common/common-exceptions.c (throw_exception): Rename from
8216         throw_exception_cxx.  Remove old copy.  Make argument const.
8217         (throw_it): Create and throw exception objects directly.
8218         * common/common-exceptions.h (throw_exception): Make argument
8219         const.
8220         (struct gdb_exception_error): Add constructor.
8221         (struct gdb_exception_quit): Add constructor.
8222
8223 2019-04-08  Tom Tromey  <tom@tromey.com>
8224
8225         * common/common-exceptions.h (exception_rethrow): Don't declare.
8226         (TRY_SJLJ): Update comment.
8227         (TRY, CATCH, END_CATCH): Remove.
8228         * common/common-exceptions.c (exception_rethrow): Remove.
8229
8230 2019-04-08  Tom Tromey  <tom@tromey.com>
8231
8232         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8233         Remove.
8234         (gdb_exception_error): Rename from
8235         gdb_exception_RETURN_MASK_ERROR.
8236         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8237         (gdb_quit_bad_alloc): Update.
8238         * aarch64-tdep.c: Update.
8239         * ada-lang.c: Update.
8240         * ada-typeprint.c: Update.
8241         * ada-valprint.c: Update.
8242         * amd64-tdep.c: Update.
8243         * arch-utils.c: Update.
8244         * break-catch-throw.c: Update.
8245         * breakpoint.c: Update.
8246         * btrace.c: Update.
8247         * c-varobj.c: Update.
8248         * cli/cli-cmds.c: Update.
8249         * cli/cli-interp.c: Update.
8250         * cli/cli-script.c: Update.
8251         * common/common-exceptions.c: Update.
8252         * common/new-op.c: Update.
8253         * common/selftest.c: Update.
8254         * compile/compile-c-symbols.c: Update.
8255         * compile/compile-cplus-symbols.c: Update.
8256         * compile/compile-object-load.c: Update.
8257         * compile/compile-object-run.c: Update.
8258         * completer.c: Update.
8259         * corelow.c: Update.
8260         * cp-abi.c: Update.
8261         * cp-support.c: Update.
8262         * cp-valprint.c: Update.
8263         * darwin-nat.c: Update.
8264         * disasm-selftests.c: Update.
8265         * dtrace-probe.c: Update.
8266         * dwarf-index-cache.c: Update.
8267         * dwarf-index-write.c: Update.
8268         * dwarf2-frame-tailcall.c: Update.
8269         * dwarf2-frame.c: Update.
8270         * dwarf2loc.c: Update.
8271         * dwarf2read.c: Update.
8272         * eval.c: Update.
8273         * event-loop.c: Update.
8274         * event-top.c: Update.
8275         * exec.c: Update.
8276         * f-valprint.c: Update.
8277         * fbsd-tdep.c: Update.
8278         * frame-unwind.c: Update.
8279         * frame.c: Update.
8280         * gdbtypes.c: Update.
8281         * gnu-v3-abi.c: Update.
8282         * guile/guile-internal.h: Update.
8283         * guile/scm-block.c: Update.
8284         * guile/scm-breakpoint.c: Update.
8285         * guile/scm-cmd.c: Update.
8286         * guile/scm-disasm.c: Update.
8287         * guile/scm-frame.c: Update.
8288         * guile/scm-lazy-string.c: Update.
8289         * guile/scm-math.c: Update.
8290         * guile/scm-param.c: Update.
8291         * guile/scm-ports.c: Update.
8292         * guile/scm-pretty-print.c: Update.
8293         * guile/scm-symbol.c: Update.
8294         * guile/scm-symtab.c: Update.
8295         * guile/scm-type.c: Update.
8296         * guile/scm-value.c: Update.
8297         * i386-linux-tdep.c: Update.
8298         * i386-tdep.c: Update.
8299         * inf-loop.c: Update.
8300         * infcall.c: Update.
8301         * infcmd.c: Update.
8302         * infrun.c: Update.
8303         * jit.c: Update.
8304         * language.c: Update.
8305         * linespec.c: Update.
8306         * linux-fork.c: Update.
8307         * linux-nat.c: Update.
8308         * linux-tdep.c: Update.
8309         * linux-thread-db.c: Update.
8310         * main.c: Update.
8311         * mi/mi-cmd-break.c: Update.
8312         * mi/mi-cmd-stack.c: Update.
8313         * mi/mi-interp.c: Update.
8314         * mi/mi-main.c: Update.
8315         * objc-lang.c: Update.
8316         * p-valprint.c: Update.
8317         * parse.c: Update.
8318         * ppc-linux-tdep.c: Update.
8319         * printcmd.c: Update.
8320         * python/py-arch.c: Update.
8321         * python/py-breakpoint.c: Update.
8322         * python/py-cmd.c: Update.
8323         * python/py-finishbreakpoint.c: Update.
8324         * python/py-frame.c: Update.
8325         * python/py-framefilter.c: Update.
8326         * python/py-gdb-readline.c: Update.
8327         * python/py-inferior.c: Update.
8328         * python/py-infthread.c: Update.
8329         * python/py-lazy-string.c: Update.
8330         * python/py-linetable.c: Update.
8331         * python/py-objfile.c: Update.
8332         * python/py-param.c: Update.
8333         * python/py-prettyprint.c: Update.
8334         * python/py-progspace.c: Update.
8335         * python/py-record-btrace.c: Update.
8336         * python/py-record.c: Update.
8337         * python/py-symbol.c: Update.
8338         * python/py-type.c: Update.
8339         * python/py-unwind.c: Update.
8340         * python/py-utils.c: Update.
8341         * python/py-value.c: Update.
8342         * python/python.c: Update.
8343         * record-btrace.c: Update.
8344         * record-full.c: Update.
8345         * remote-fileio.c: Update.
8346         * remote.c: Update.
8347         * riscv-tdep.c: Update.
8348         * rs6000-aix-tdep.c: Update.
8349         * rs6000-tdep.c: Update.
8350         * rust-exp.y: Update.
8351         * rust-lang.c: Update.
8352         * s390-tdep.c: Update.
8353         * selftest-arch.c: Update.
8354         * solib-dsbt.c: Update.
8355         * solib-frv.c: Update.
8356         * solib-spu.c: Update.
8357         * solib-svr4.c: Update.
8358         * solib.c: Update.
8359         * sparc64-linux-tdep.c: Update.
8360         * stack.c: Update.
8361         * symfile-mem.c: Update.
8362         * symmisc.c: Update.
8363         * target.c: Update.
8364         * thread.c: Update.
8365         * top.c: Update.
8366         * tracefile-tfile.c: Update.
8367         * tui/tui.c: Update.
8368         * typeprint.c: Update.
8369         * unittests/cli-utils-selftests.c: Update.
8370         * unittests/parse-connection-spec-selftests.c: Update.
8371         * valops.c: Update.
8372         * valprint.c: Update.
8373         * value.c: Update.
8374         * varobj.c: Update.
8375         * windows-nat.c: Update.
8376         * x86-linux-nat.c: Update.
8377         * xml-support.c: Update.
8378
8379 2019-04-08  Tom Tromey  <tom@tromey.com>
8380
8381         * xml-support.c: Use C++ exception handling.
8382         * x86-linux-nat.c: Use C++ exception handling.
8383         * windows-nat.c: Use C++ exception handling.
8384         * varobj.c: Use C++ exception handling.
8385         * value.c: Use C++ exception handling.
8386         * valprint.c: Use C++ exception handling.
8387         * valops.c: Use C++ exception handling.
8388         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8389         handling.
8390         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8391         * typeprint.c: Use C++ exception handling.
8392         * tui/tui.c: Use C++ exception handling.
8393         * tracefile-tfile.c: Use C++ exception handling.
8394         * top.c: Use C++ exception handling.
8395         * thread.c: Use C++ exception handling.
8396         * target.c: Use C++ exception handling.
8397         * symmisc.c: Use C++ exception handling.
8398         * symfile-mem.c: Use C++ exception handling.
8399         * stack.c: Use C++ exception handling.
8400         * sparc64-linux-tdep.c: Use C++ exception handling.
8401         * solib.c: Use C++ exception handling.
8402         * solib-svr4.c: Use C++ exception handling.
8403         * solib-spu.c: Use C++ exception handling.
8404         * solib-frv.c: Use C++ exception handling.
8405         * solib-dsbt.c: Use C++ exception handling.
8406         * selftest-arch.c: Use C++ exception handling.
8407         * s390-tdep.c: Use C++ exception handling.
8408         * rust-lang.c: Use C++ exception handling.
8409         * rust-exp.y: Use C++ exception handling.
8410         * rs6000-tdep.c: Use C++ exception handling.
8411         * rs6000-aix-tdep.c: Use C++ exception handling.
8412         * riscv-tdep.c: Use C++ exception handling.
8413         * remote.c: Use C++ exception handling.
8414         * remote-fileio.c: Use C++ exception handling.
8415         * record-full.c: Use C++ exception handling.
8416         * record-btrace.c: Use C++ exception handling.
8417         * python/python.c: Use C++ exception handling.
8418         * python/py-value.c: Use C++ exception handling.
8419         * python/py-utils.c: Use C++ exception handling.
8420         * python/py-unwind.c: Use C++ exception handling.
8421         * python/py-type.c: Use C++ exception handling.
8422         * python/py-symbol.c: Use C++ exception handling.
8423         * python/py-record.c: Use C++ exception handling.
8424         * python/py-record-btrace.c: Use C++ exception handling.
8425         * python/py-progspace.c: Use C++ exception handling.
8426         * python/py-prettyprint.c: Use C++ exception handling.
8427         * python/py-param.c: Use C++ exception handling.
8428         * python/py-objfile.c: Use C++ exception handling.
8429         * python/py-linetable.c: Use C++ exception handling.
8430         * python/py-lazy-string.c: Use C++ exception handling.
8431         * python/py-infthread.c: Use C++ exception handling.
8432         * python/py-inferior.c: Use C++ exception handling.
8433         * python/py-gdb-readline.c: Use C++ exception handling.
8434         * python/py-framefilter.c: Use C++ exception handling.
8435         * python/py-frame.c: Use C++ exception handling.
8436         * python/py-finishbreakpoint.c: Use C++ exception handling.
8437         * python/py-cmd.c: Use C++ exception handling.
8438         * python/py-breakpoint.c: Use C++ exception handling.
8439         * python/py-arch.c: Use C++ exception handling.
8440         * printcmd.c: Use C++ exception handling.
8441         * ppc-linux-tdep.c: Use C++ exception handling.
8442         * parse.c: Use C++ exception handling.
8443         * p-valprint.c: Use C++ exception handling.
8444         * objc-lang.c: Use C++ exception handling.
8445         * mi/mi-main.c: Use C++ exception handling.
8446         * mi/mi-interp.c: Use C++ exception handling.
8447         * mi/mi-cmd-stack.c: Use C++ exception handling.
8448         * mi/mi-cmd-break.c: Use C++ exception handling.
8449         * main.c: Use C++ exception handling.
8450         * linux-thread-db.c: Use C++ exception handling.
8451         * linux-tdep.c: Use C++ exception handling.
8452         * linux-nat.c: Use C++ exception handling.
8453         * linux-fork.c: Use C++ exception handling.
8454         * linespec.c: Use C++ exception handling.
8455         * language.c: Use C++ exception handling.
8456         * jit.c: Use C++ exception handling.
8457         * infrun.c: Use C++ exception handling.
8458         * infcmd.c: Use C++ exception handling.
8459         * infcall.c: Use C++ exception handling.
8460         * inf-loop.c: Use C++ exception handling.
8461         * i386-tdep.c: Use C++ exception handling.
8462         * i386-linux-tdep.c: Use C++ exception handling.
8463         * guile/scm-value.c: Use C++ exception handling.
8464         * guile/scm-type.c: Use C++ exception handling.
8465         * guile/scm-symtab.c: Use C++ exception handling.
8466         * guile/scm-symbol.c: Use C++ exception handling.
8467         * guile/scm-pretty-print.c: Use C++ exception handling.
8468         * guile/scm-ports.c: Use C++ exception handling.
8469         * guile/scm-param.c: Use C++ exception handling.
8470         * guile/scm-math.c: Use C++ exception handling.
8471         * guile/scm-lazy-string.c: Use C++ exception handling.
8472         * guile/scm-frame.c: Use C++ exception handling.
8473         * guile/scm-disasm.c: Use C++ exception handling.
8474         * guile/scm-cmd.c: Use C++ exception handling.
8475         * guile/scm-breakpoint.c: Use C++ exception handling.
8476         * guile/scm-block.c: Use C++ exception handling.
8477         * guile/guile-internal.h: Use C++ exception handling.
8478         * gnu-v3-abi.c: Use C++ exception handling.
8479         * gdbtypes.c: Use C++ exception handling.
8480         * frame.c: Use C++ exception handling.
8481         * frame-unwind.c: Use C++ exception handling.
8482         * fbsd-tdep.c: Use C++ exception handling.
8483         * f-valprint.c: Use C++ exception handling.
8484         * exec.c: Use C++ exception handling.
8485         * event-top.c: Use C++ exception handling.
8486         * event-loop.c: Use C++ exception handling.
8487         * eval.c: Use C++ exception handling.
8488         * dwarf2read.c: Use C++ exception handling.
8489         * dwarf2loc.c: Use C++ exception handling.
8490         * dwarf2-frame.c: Use C++ exception handling.
8491         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8492         * dwarf-index-write.c: Use C++ exception handling.
8493         * dwarf-index-cache.c: Use C++ exception handling.
8494         * dtrace-probe.c: Use C++ exception handling.
8495         * disasm-selftests.c: Use C++ exception handling.
8496         * darwin-nat.c: Use C++ exception handling.
8497         * cp-valprint.c: Use C++ exception handling.
8498         * cp-support.c: Use C++ exception handling.
8499         * cp-abi.c: Use C++ exception handling.
8500         * corelow.c: Use C++ exception handling.
8501         * completer.c: Use C++ exception handling.
8502         * compile/compile-object-run.c: Use C++ exception handling.
8503         * compile/compile-object-load.c: Use C++ exception handling.
8504         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8505         * compile/compile-c-symbols.c: Use C++ exception handling.
8506         * common/selftest.c: Use C++ exception handling.
8507         * common/new-op.c: Use C++ exception handling.
8508         * cli/cli-script.c: Use C++ exception handling.
8509         * cli/cli-interp.c: Use C++ exception handling.
8510         * cli/cli-cmds.c: Use C++ exception handling.
8511         * c-varobj.c: Use C++ exception handling.
8512         * btrace.c: Use C++ exception handling.
8513         * breakpoint.c: Use C++ exception handling.
8514         * break-catch-throw.c: Use C++ exception handling.
8515         * arch-utils.c: Use C++ exception handling.
8516         * amd64-tdep.c: Use C++ exception handling.
8517         * ada-valprint.c: Use C++ exception handling.
8518         * ada-typeprint.c: Use C++ exception handling.
8519         * ada-lang.c: Use C++ exception handling.
8520         * aarch64-tdep.c: Use C++ exception handling.
8521
8522 2019-04-08  Tom Tromey  <tom@tromey.com>
8523
8524         * xml-support.c (gdb_xml_parser::parse): Update.
8525         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8526         * value.c (show_convenience): Update.
8527         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8528         (test_parse_flags_qcs): Update.
8529         * thread.c (thr_try_catch_cmd): Update.
8530         * target.c (target_translate_tls_address): Update.
8531         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8532         (info_frame_command_core, frame_apply_command_count): Update.
8533         * rust-exp.y (rust_lex_exception_test): Update.
8534         * riscv-tdep.c (riscv_print_one_register_info): Update.
8535         * remote.c (remote_target::enable_btrace): Update.
8536         * record-btrace.c (record_btrace_enable_warn): Update.
8537         * python/py-utils.c (gdbpy_convert_exception): Update.
8538         * printcmd.c (do_one_display, print_variable_and_value): Update.
8539         * mi/mi-main.c (mi_print_exception): Update.
8540         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8541         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8542         * linux-nat.c (linux_nat_target::attach): Update.
8543         * linux-fork.c (class scoped_switch_fork_info): Update.
8544         * infrun.c (displaced_step_prepare): Update.
8545         * infcall.c (call_function_by_hand_dummy): Update.
8546         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8547         * gnu-v3-abi.c (print_one_vtable): Update.
8548         * frame.c (get_prev_frame_always): Update.
8549         * f-valprint.c (info_common_command_for_block): Update.
8550         * exec.c (try_open_exec_file): Update.
8551         * exceptions.c (print_exception, exception_print)
8552         (exception_fprintf, exception_print_same): Update.
8553         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8554         * dwarf-index-cache.c (index_cache::store)
8555         (index_cache::lookup_gdb_index): Update.
8556         * darwin-nat.c (maybe_cache_shell): Update.
8557         * cp-valprint.c (cp_print_value_fields): Update.
8558         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8559         (gcc_cplus_symbol_address): Update.
8560         * compile/compile-c-symbols.c (gcc_convert_symbol)
8561         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8562         * common/selftest.c: Update.
8563         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8564         a std::string.
8565         (exception_try_scope_entry, exception_try_scope_exit): Don't
8566         declare.
8567         (struct exception_try_scope): Remove.
8568         (TRY): Don't use exception_try_scope.
8569         (struct gdb_exception): Add constructor, operator=.
8570         <what>: New method.
8571         (struct gdb_exception_RETURN_MASK_ALL)
8572         (struct gdb_exception_RETURN_MASK_ERROR)
8573         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8574         (struct gdb_quit_bad_alloc): Update.
8575         * common/common-exceptions.c (exception_none): Change
8576         initializer.
8577         (struct catcher) <state, exception>: Initialize inline.
8578         <prev>: Remove member.
8579         (current_catcher): Remove.
8580         (catchers): New global.
8581         (exceptions_state_mc_init): Simplify.
8582         (catcher_pop): Remove.
8583         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8584         (try_scope_depth, exception_try_scope_entry)
8585         (exception_try_scope_exit): Remove.
8586         (throw_exception_sjlj): Update.
8587         (exception_messages, exception_messages_size): Remove.
8588         (throw_it): Simplify.
8589         (gdb_exception_sliced_copy): Remove.
8590         (throw_exception_cxx): Update.
8591         * cli/cli-script.c (script_from_file): Update.
8592         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8593         Update.
8594         * ada-valprint.c (ada_val_print): Update.
8595         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8596         (create_excep_cond_exprs): Update.
8597
8598 2019-04-08  Tom Tromey  <tom@tromey.com>
8599
8600         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8601         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8602         (TRY, CATCH, END_CATCH): Remove some definitions.
8603         * common/common-exceptions.c: Don't use GDB_XCPT.
8604         (catcher_list_size): Remove.
8605         (throw_exception, throw_it): Simplify.
8606
8607 2019-04-05  Tom Tromey  <tom@tromey.com>
8608
8609         Revert the header-sorting patch.
8610         * ft32-tdep.c: Revert.
8611         * frv-tdep.c: Revert.
8612         * frv-linux-tdep.c: Revert.
8613         * frame.c: Revert.
8614         * frame-unwind.c: Revert.
8615         * frame-base.c: Revert.
8616         * fork-child.c: Revert.
8617         * findvar.c: Revert.
8618         * findcmd.c: Revert.
8619         * filesystem.c: Revert.
8620         * filename-seen-cache.h: Revert.
8621         * filename-seen-cache.c: Revert.
8622         * fbsd-tdep.c: Revert.
8623         * fbsd-nat.h: Revert.
8624         * fbsd-nat.c: Revert.
8625         * f-valprint.c: Revert.
8626         * f-typeprint.c: Revert.
8627         * f-lang.c: Revert.
8628         * extension.h: Revert.
8629         * extension.c: Revert.
8630         * extension-priv.h: Revert.
8631         * expprint.c: Revert.
8632         * exec.h: Revert.
8633         * exec.c: Revert.
8634         * exceptions.c: Revert.
8635         * event-top.c: Revert.
8636         * event-loop.c: Revert.
8637         * eval.c: Revert.
8638         * elfread.c: Revert.
8639         * dwarf2read.h: Revert.
8640         * dwarf2read.c: Revert.
8641         * dwarf2loc.c: Revert.
8642         * dwarf2expr.h: Revert.
8643         * dwarf2expr.c: Revert.
8644         * dwarf2-frame.c: Revert.
8645         * dwarf2-frame-tailcall.c: Revert.
8646         * dwarf-index-write.h: Revert.
8647         * dwarf-index-write.c: Revert.
8648         * dwarf-index-common.c: Revert.
8649         * dwarf-index-cache.h: Revert.
8650         * dwarf-index-cache.c: Revert.
8651         * dummy-frame.c: Revert.
8652         * dtrace-probe.c: Revert.
8653         * disasm.h: Revert.
8654         * disasm.c: Revert.
8655         * disasm-selftests.c: Revert.
8656         * dictionary.c: Revert.
8657         * dicos-tdep.c: Revert.
8658         * demangle.c: Revert.
8659         * dcache.h: Revert.
8660         * dcache.c: Revert.
8661         * darwin-nat.h: Revert.
8662         * darwin-nat.c: Revert.
8663         * darwin-nat-info.c: Revert.
8664         * d-valprint.c: Revert.
8665         * d-namespace.c: Revert.
8666         * d-lang.c: Revert.
8667         * ctf.c: Revert.
8668         * csky-tdep.c: Revert.
8669         * csky-linux-tdep.c: Revert.
8670         * cris-tdep.c: Revert.
8671         * cris-linux-tdep.c: Revert.
8672         * cp-valprint.c: Revert.
8673         * cp-support.c: Revert.
8674         * cp-namespace.c: Revert.
8675         * cp-abi.c: Revert.
8676         * corelow.c: Revert.
8677         * corefile.c: Revert.
8678         * continuations.c: Revert.
8679         * completer.h: Revert.
8680         * completer.c: Revert.
8681         * complaints.c: Revert.
8682         * coffread.c: Revert.
8683         * coff-pe-read.c: Revert.
8684         * cli-out.h: Revert.
8685         * cli-out.c: Revert.
8686         * charset.c: Revert.
8687         * c-varobj.c: Revert.
8688         * c-valprint.c: Revert.
8689         * c-typeprint.c: Revert.
8690         * c-lang.c: Revert.
8691         * buildsym.c: Revert.
8692         * buildsym-legacy.c: Revert.
8693         * build-id.h: Revert.
8694         * build-id.c: Revert.
8695         * btrace.c: Revert.
8696         * bsd-uthread.c: Revert.
8697         * breakpoint.h: Revert.
8698         * breakpoint.c: Revert.
8699         * break-catch-throw.c: Revert.
8700         * break-catch-syscall.c: Revert.
8701         * break-catch-sig.c: Revert.
8702         * blockframe.c: Revert.
8703         * block.c: Revert.
8704         * bfin-tdep.c: Revert.
8705         * bfin-linux-tdep.c: Revert.
8706         * bfd-target.c: Revert.
8707         * bcache.c: Revert.
8708         * ax-general.c: Revert.
8709         * ax-gdb.h: Revert.
8710         * ax-gdb.c: Revert.
8711         * avr-tdep.c: Revert.
8712         * auxv.c: Revert.
8713         * auto-load.c: Revert.
8714         * arm-wince-tdep.c: Revert.
8715         * arm-tdep.c: Revert.
8716         * arm-symbian-tdep.c: Revert.
8717         * arm-pikeos-tdep.c: Revert.
8718         * arm-obsd-tdep.c: Revert.
8719         * arm-nbsd-tdep.c: Revert.
8720         * arm-nbsd-nat.c: Revert.
8721         * arm-linux-tdep.c: Revert.
8722         * arm-linux-nat.c: Revert.
8723         * arm-fbsd-tdep.c: Revert.
8724         * arm-fbsd-nat.c: Revert.
8725         * arm-bsd-tdep.c: Revert.
8726         * arch-utils.c: Revert.
8727         * arc-tdep.c: Revert.
8728         * arc-newlib-tdep.c: Revert.
8729         * annotate.h: Revert.
8730         * annotate.c: Revert.
8731         * amd64-windows-tdep.c: Revert.
8732         * amd64-windows-nat.c: Revert.
8733         * amd64-tdep.c: Revert.
8734         * amd64-sol2-tdep.c: Revert.
8735         * amd64-obsd-tdep.c: Revert.
8736         * amd64-obsd-nat.c: Revert.
8737         * amd64-nbsd-tdep.c: Revert.
8738         * amd64-nbsd-nat.c: Revert.
8739         * amd64-nat.c: Revert.
8740         * amd64-linux-tdep.c: Revert.
8741         * amd64-linux-nat.c: Revert.
8742         * amd64-fbsd-tdep.c: Revert.
8743         * amd64-fbsd-nat.c: Revert.
8744         * amd64-dicos-tdep.c: Revert.
8745         * amd64-darwin-tdep.c: Revert.
8746         * amd64-bsd-nat.c: Revert.
8747         * alpha-tdep.c: Revert.
8748         * alpha-obsd-tdep.c: Revert.
8749         * alpha-nbsd-tdep.c: Revert.
8750         * alpha-mdebug-tdep.c: Revert.
8751         * alpha-linux-tdep.c: Revert.
8752         * alpha-linux-nat.c: Revert.
8753         * alpha-bsd-tdep.c: Revert.
8754         * alpha-bsd-nat.c: Revert.
8755         * aix-thread.c: Revert.
8756         * agent.c: Revert.
8757         * addrmap.c: Revert.
8758         * ada-varobj.c: Revert.
8759         * ada-valprint.c: Revert.
8760         * ada-typeprint.c: Revert.
8761         * ada-tasks.c: Revert.
8762         * ada-lang.c: Revert.
8763         * aarch64-tdep.c: Revert.
8764         * aarch64-ravenscar-thread.c: Revert.
8765         * aarch64-newlib-tdep.c: Revert.
8766         * aarch64-linux-tdep.c: Revert.
8767         * aarch64-linux-nat.c: Revert.
8768         * aarch64-fbsd-tdep.c: Revert.
8769         * aarch64-fbsd-nat.c: Revert.
8770         * aarch32-linux-nat.c: Revert.
8771
8772 2019-04-05  Tom Tromey  <tom@tromey.com>
8773
8774         * ft32-tdep.c: Sort headers.
8775         * frv-tdep.c: Sort headers.
8776         * frv-linux-tdep.c: Sort headers.
8777         * frame.c: Sort headers.
8778         * frame-unwind.c: Sort headers.
8779         * frame-base.c: Sort headers.
8780         * fork-child.c: Sort headers.
8781         * findvar.c: Sort headers.
8782         * findcmd.c: Sort headers.
8783         * filesystem.c: Sort headers.
8784         * filename-seen-cache.h: Sort headers.
8785         * filename-seen-cache.c: Sort headers.
8786         * fbsd-tdep.c: Sort headers.
8787         * fbsd-nat.h: Sort headers.
8788         * fbsd-nat.c: Sort headers.
8789         * f-valprint.c: Sort headers.
8790         * f-typeprint.c: Sort headers.
8791         * f-lang.c: Sort headers.
8792         * extension.h: Sort headers.
8793         * extension.c: Sort headers.
8794         * extension-priv.h: Sort headers.
8795         * expprint.c: Sort headers.
8796         * exec.h: Sort headers.
8797         * exec.c: Sort headers.
8798         * exceptions.c: Sort headers.
8799         * event-top.c: Sort headers.
8800         * event-loop.c: Sort headers.
8801         * eval.c: Sort headers.
8802         * elfread.c: Sort headers.
8803         * dwarf2read.h: Sort headers.
8804         * dwarf2read.c: Sort headers.
8805         * dwarf2loc.c: Sort headers.
8806         * dwarf2expr.h: Sort headers.
8807         * dwarf2expr.c: Sort headers.
8808         * dwarf2-frame.c: Sort headers.
8809         * dwarf2-frame-tailcall.c: Sort headers.
8810         * dwarf-index-write.h: Sort headers.
8811         * dwarf-index-write.c: Sort headers.
8812         * dwarf-index-common.c: Sort headers.
8813         * dwarf-index-cache.h: Sort headers.
8814         * dwarf-index-cache.c: Sort headers.
8815         * dummy-frame.c: Sort headers.
8816         * dtrace-probe.c: Sort headers.
8817         * disasm.h: Sort headers.
8818         * disasm.c: Sort headers.
8819         * disasm-selftests.c: Sort headers.
8820         * dictionary.c: Sort headers.
8821         * dicos-tdep.c: Sort headers.
8822         * demangle.c: Sort headers.
8823         * dcache.h: Sort headers.
8824         * dcache.c: Sort headers.
8825         * darwin-nat.h: Sort headers.
8826         * darwin-nat.c: Sort headers.
8827         * darwin-nat-info.c: Sort headers.
8828         * d-valprint.c: Sort headers.
8829         * d-namespace.c: Sort headers.
8830         * d-lang.c: Sort headers.
8831         * ctf.c: Sort headers.
8832         * csky-tdep.c: Sort headers.
8833         * csky-linux-tdep.c: Sort headers.
8834         * cris-tdep.c: Sort headers.
8835         * cris-linux-tdep.c: Sort headers.
8836         * cp-valprint.c: Sort headers.
8837         * cp-support.c: Sort headers.
8838         * cp-namespace.c: Sort headers.
8839         * cp-abi.c: Sort headers.
8840         * corelow.c: Sort headers.
8841         * corefile.c: Sort headers.
8842         * continuations.c: Sort headers.
8843         * completer.h: Sort headers.
8844         * completer.c: Sort headers.
8845         * complaints.c: Sort headers.
8846         * coffread.c: Sort headers.
8847         * coff-pe-read.c: Sort headers.
8848         * cli-out.h: Sort headers.
8849         * cli-out.c: Sort headers.
8850         * charset.c: Sort headers.
8851         * c-varobj.c: Sort headers.
8852         * c-valprint.c: Sort headers.
8853         * c-typeprint.c: Sort headers.
8854         * c-lang.c: Sort headers.
8855         * buildsym.c: Sort headers.
8856         * buildsym-legacy.c: Sort headers.
8857         * build-id.h: Sort headers.
8858         * build-id.c: Sort headers.
8859         * btrace.c: Sort headers.
8860         * bsd-uthread.c: Sort headers.
8861         * breakpoint.h: Sort headers.
8862         * breakpoint.c: Sort headers.
8863         * break-catch-throw.c: Sort headers.
8864         * break-catch-syscall.c: Sort headers.
8865         * break-catch-sig.c: Sort headers.
8866         * blockframe.c: Sort headers.
8867         * block.c: Sort headers.
8868         * bfin-tdep.c: Sort headers.
8869         * bfin-linux-tdep.c: Sort headers.
8870         * bfd-target.c: Sort headers.
8871         * bcache.c: Sort headers.
8872         * ax-general.c: Sort headers.
8873         * ax-gdb.h: Sort headers.
8874         * ax-gdb.c: Sort headers.
8875         * avr-tdep.c: Sort headers.
8876         * auxv.c: Sort headers.
8877         * auto-load.c: Sort headers.
8878         * arm-wince-tdep.c: Sort headers.
8879         * arm-tdep.c: Sort headers.
8880         * arm-symbian-tdep.c: Sort headers.
8881         * arm-pikeos-tdep.c: Sort headers.
8882         * arm-obsd-tdep.c: Sort headers.
8883         * arm-nbsd-tdep.c: Sort headers.
8884         * arm-nbsd-nat.c: Sort headers.
8885         * arm-linux-tdep.c: Sort headers.
8886         * arm-linux-nat.c: Sort headers.
8887         * arm-fbsd-tdep.c: Sort headers.
8888         * arm-fbsd-nat.c: Sort headers.
8889         * arm-bsd-tdep.c: Sort headers.
8890         * arch-utils.c: Sort headers.
8891         * arc-tdep.c: Sort headers.
8892         * arc-newlib-tdep.c: Sort headers.
8893         * annotate.h: Sort headers.
8894         * annotate.c: Sort headers.
8895         * amd64-windows-tdep.c: Sort headers.
8896         * amd64-windows-nat.c: Sort headers.
8897         * amd64-tdep.c: Sort headers.
8898         * amd64-sol2-tdep.c: Sort headers.
8899         * amd64-obsd-tdep.c: Sort headers.
8900         * amd64-obsd-nat.c: Sort headers.
8901         * amd64-nbsd-tdep.c: Sort headers.
8902         * amd64-nbsd-nat.c: Sort headers.
8903         * amd64-nat.c: Sort headers.
8904         * amd64-linux-tdep.c: Sort headers.
8905         * amd64-linux-nat.c: Sort headers.
8906         * amd64-fbsd-tdep.c: Sort headers.
8907         * amd64-fbsd-nat.c: Sort headers.
8908         * amd64-dicos-tdep.c: Sort headers.
8909         * amd64-darwin-tdep.c: Sort headers.
8910         * amd64-bsd-nat.c: Sort headers.
8911         * alpha-tdep.c: Sort headers.
8912         * alpha-obsd-tdep.c: Sort headers.
8913         * alpha-nbsd-tdep.c: Sort headers.
8914         * alpha-mdebug-tdep.c: Sort headers.
8915         * alpha-linux-tdep.c: Sort headers.
8916         * alpha-linux-nat.c: Sort headers.
8917         * alpha-bsd-tdep.c: Sort headers.
8918         * alpha-bsd-nat.c: Sort headers.
8919         * aix-thread.c: Sort headers.
8920         * agent.c: Sort headers.
8921         * addrmap.c: Sort headers.
8922         * ada-varobj.c: Sort headers.
8923         * ada-valprint.c: Sort headers.
8924         * ada-typeprint.c: Sort headers.
8925         * ada-tasks.c: Sort headers.
8926         * ada-lang.c: Sort headers.
8927         * aarch64-tdep.c: Sort headers.
8928         * aarch64-ravenscar-thread.c: Sort headers.
8929         * aarch64-newlib-tdep.c: Sort headers.
8930         * aarch64-linux-tdep.c: Sort headers.
8931         * aarch64-linux-nat.c: Sort headers.
8932         * aarch64-fbsd-tdep.c: Sort headers.
8933         * aarch64-fbsd-nat.c: Sort headers.
8934         * aarch32-linux-nat.c: Sort headers.
8935
8936 2019-04-04  Tom Tromey  <tom@tromey.com>
8937
8938         * varobj.c (varobj_create): Update.
8939         * rust-exp.y (struct rust_parser) <update_innermost_block,
8940         lookup_symbol>: New methods.
8941         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8942         Rename.
8943         (rust_parser::rust_lookup_type)
8944         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8945         * printcmd.c (display_command, do_one_display): Update.
8946         * parser-defs.h (struct parser_state) <parser_state>: Add
8947         "tracker" parameter.
8948         (block_tracker): New member.
8949         (class innermost_block_tracker) <innermost_block_tracker>: Add
8950         "types" parameter.
8951         <reset>: Remove method.
8952         (innermost_block): Don't declare.
8953         (null_post_parser): Update.
8954         * parse.c (innermost_block): Remove global.
8955         (write_dollar_variable): Update.
8956         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8957         Remove "tracker_types" parameter.
8958         (parse_expression): Add "tracker" parameter.
8959         (parse_expression_for_completion): Update.
8960         (null_post_parser): Add "tracker" parameter.
8961         * p-exp.y: Update rules.
8962         * m2-exp.y: Update rules.
8963         * language.h (struct language_defn) <la_post_parser>: Add
8964         "tracker" parameter.
8965         * go-exp.y: Update rules.
8966         * f-exp.y: Update rules.
8967         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8968         parameter.
8969         * d-exp.y: Update rules.
8970         * c-exp.y: Update rules.
8971         * breakpoint.c (set_breakpoint_condition): Create an
8972         innermost_block_tracker.
8973         (watch_command_1): Likewise.
8974         * ada-lang.c (resolve): Add "tracker" parameter.
8975         (resolve_subexp): Likewise.
8976         * ada-exp.y (write_var_from_sym): Update.
8977
8978 2019-04-04  Tom Tromey  <tom@tromey.com>
8979
8980         * type-stack.h: New file.
8981         * type-stack.c: New file.
8982         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8983         type-stack.h.
8984         (insert_into_type_stack, insert_type, push_type, push_type_int)
8985         (insert_type_address_space, pop_type, pop_type_int)
8986         (pop_typelist, pop_type_stack, append_type_stack)
8987         (push_type_stack, get_type_stack, push_typelist)
8988         (follow_type_instance_flags, follow_types): Don't declare.
8989         * parse.c (type_stack): Remove global.
8990         (parse_exp_in_context): Update.
8991         (insert_into_type_stack, insert_type, push_type, push_type_int)
8992         (insert_type_address_space, pop_type, pop_type_int)
8993         (pop_typelist, pop_type_stack, append_type_stack)
8994         (push_type_stack, get_type_stack, push_typelist)
8995         (follow_type_instance_flags, follow_types): Remove (moved to
8996         type-stack.c).
8997         * f-exp.y (type_stack): New global.
8998         Update rules.
8999         (push_kind_type, f_parse): Update.
9000         * d-exp.y (type_stack): New global.
9001         Update rules.
9002         (d_parse): Update.
9003         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9004         Update rules.
9005         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9006         (HFILES_NO_SRCDIR): Add type-stack.h.
9007
9008 2019-04-04  Tom Tromey  <tom@tromey.com>
9009
9010         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9011         (rust_parser::convert_ast_to_expression, rust_parse)
9012         (rust_lex_test_completion, rust_lex_tests): Update.
9013         * parser-defs.h (struct expr_completion_state): New.
9014         (struct parser_state) <parser_state>: Add completion parameter.
9015         <mark_struct_expression, mark_completion_tag>: New methods.
9016         <parse_completion, m_completion_state>: New members.
9017         (prefixify_expression, null_post_parser): Update.
9018         (mark_struct_expression, mark_completion_tag): Don't declare.
9019         * parse.c (parse_completion, expout_last_struct)
9020         (expout_tag_completion_type, expout_completion_name): Remove
9021         globals.
9022         (parser_state::mark_struct_expression)
9023         (parser_state::mark_completion_tag): Now methods.
9024         (prefixify_expression): Add last_struct parameter.
9025         (prefixify_subexp): Likewise.
9026         (parse_exp_1): Update.
9027         (parse_exp_in_context): Add cstate parameter.  Update.
9028         (parse_expression_for_completion): Create an
9029         expr_completion_state.
9030         (null_post_parser): Add "completion" parameter.
9031         * p-exp.y: Update rules.
9032         (yylex): Update.
9033         * language.h (struct language_defn) <la_post_parser>: Add
9034         "completing" parameter.
9035         * go-exp.y: Update rules.
9036         (lex_one_token): Update.
9037         * expression.h (parse_completion): Don't declare.
9038         * d-exp.y: Update rules.
9039         (lex_one_token): Update rules.
9040         * c-exp.y: Update rules.
9041         (lex_one_token): Update.
9042         * ada-lang.c (resolve): Add "parse_completion" parameter.
9043         (resolve_subexp): Likewise.
9044         (ada_resolve_function): Likewise.
9045
9046 2019-04-04  Tom Tromey  <tom@tromey.com>
9047
9048         * parser-defs.h (struct parser_state) <start_arglist,
9049         end_arglist>: New methods.
9050         <arglist_len, m_funcall_chain>: New members.
9051         (arglist_len, start_arglist, end_arglist): Don't declare.
9052         * parse.c (arglist_len, funcall_chain): Remove global.
9053         (start_arglist, end_arglist): Remove functions.
9054         (parse_exp_in_context): Update.
9055         * p-exp.y: Update rules.
9056         * m2-exp.y: Update rules.
9057         * go-exp.y: Update rules.
9058         * f-exp.y: Update rules.
9059         * d-exp.y: Update rules.
9060         * c-exp.y: Update rules.
9061
9062 2019-04-04  Tom Tromey  <tom@tromey.com>
9063
9064         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9065         lex_operator, push_back>: New methods.
9066         Update all rules.
9067         (rust_parser::lex_hex, lex_escape): Rename and update.
9068         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9069         (rust_parser::lex_operator): Rename and update.
9070         (rust_parser::lex_number, rustyylex, rustyyerror)
9071         (rust_lex_test_init, rust_lex_test_sequence)
9072         (rust_lex_test_push_back, rust_lex_tests): Update.
9073         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9074         parameter.
9075         <lexptr, prev_lexptr>: New members.
9076         (lexptr, prev_lexptr): Don't declare.
9077         * parse.c (lexptr, prev_lexptr): Remove globals.
9078         (parse_exp_in_context): Update.
9079         * p-exp.y (yylex, yyerror): Update.
9080         * m2-exp.y (parse_number, yylex, yyerror): Update.
9081         * go-exp.y (lex_one_token, yyerror): Update.
9082         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9083         * d-exp.y (lex_one_token, yyerror): Update.
9084         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9085         (lex_one_token, yyerror): Update.
9086         * ada-lex.l (YY_INPUT): Update.
9087         (rewind_to_char): Update.
9088         * ada-exp.y (yyerror): Update.
9089
9090 2019-04-04  Tom Tromey  <tom@tromey.com>
9091
9092         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9093         * parser-defs.h (struct parser_state) <parser_state>: Add new
9094         parameter.
9095         <comma_terminates>: New member.
9096         (comma_terminates): Don't declare global.
9097         * parse.c (comma_terminates): Remove global.
9098         (parse_exp_in_context): Update.
9099         * p-exp.y (yylex): Update.
9100         * m2-exp.y (yylex): Update.
9101         * go-exp.y (lex_one_token): Update.
9102         * f-exp.y (yylex): Update.
9103         * d-exp.y (lex_one_token): Update.
9104         * c-exp.y (lex_one_token): Update.
9105         * ada-lex.l: Update.
9106
9107 2019-04-04  Tom Tromey  <tom@tromey.com>
9108
9109         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9110         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9111         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9112         * parser-defs.h (paren_depth): Don't declare.
9113         * parse.c (paren_depth): Remove global.
9114         (parse_exp_in_context): Update.
9115         * p-exp.y (paren_depth): New global.
9116         (pascal_parse): Initialize it.
9117         * m2-exp.y (paren_depth): New global.
9118         (m2_parse): Initialize it.
9119         * go-exp.y (paren_depth): New global.
9120         (go_parse): Initialize it.
9121         * f-exp.y (paren_depth): New global.
9122         (f_parse): Initialize it.
9123         * d-exp.y (paren_depth): New global.
9124         (d_parse): Initialize it.
9125         * c-exp.y (paren_depth): New global.
9126         (c_parse): Initialize it.
9127         * ada-lex.l (paren_depth): New global.
9128         (lexer_init): Initialize it.
9129
9130 2019-04-04  Tom Tromey  <tom@tromey.com>
9131
9132         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9133         (rust_parser::convert_ast_to_type)
9134         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9135         * parser-defs.h (struct parser_state) <parser_state>: Add
9136         parameters.  Initialize new members.
9137         <expression_context_block, expression_context_pc>: New members.
9138         * parse.c (expression_context_block, expression_context_pc):
9139         Remove globals.
9140         (parse_exp_in_context): Update.
9141         * p-exp.y: Update all rules.
9142         (yylex): Update.
9143         * m2-exp.y: Update all rules.
9144         (yylex): Update.
9145         * go-exp.y (yylex): Update.
9146         * f-exp.y (yylex): Update.
9147         * d-exp.y: Update all rules.
9148         (yylex): Update.
9149         * c-exp.y: Update all rules.
9150         (lex_one_token, classify_name, yylex, c_parse): Update.
9151         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9152
9153 2019-04-04  Tom Tromey  <tom@tromey.com>
9154
9155         * gdbarch.h, gdbarch.c: Rebuild.
9156         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9157         * stap-probe.h:
9158         (struct stap_parse_info): Replace "parser_state" with
9159         "expr_builder".
9160         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9161         (parser_state): New class.
9162         * parse.c (expr_builder): Rename.
9163         (expr_builder::release): Rename.
9164         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9165         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9166         (write_exp_elt_longcst, write_exp_elt_floatcst)
9167         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9168         (write_exp_string_vector, write_exp_bitstring)
9169         (write_exp_msymbol, mark_struct_expression)
9170         (write_dollar_variable)
9171         (insert_type_address_space, increase_expout_size): Replace
9172         "parser_state" with "expr_builder".
9173         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9174         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9175         "parser_state" with "expr_builder".
9176
9177 2019-04-04  Tom Tromey  <tom@tromey.com>
9178
9179         * rust-exp.y: Replace "parse_language" with method call.
9180         * p-exp.y:
9181         (yylex): Replace "parse_language" with method call.
9182         * m2-exp.y:
9183         (yylex): Replace "parse_language" with method call.
9184         * go-exp.y (classify_name): Replace "parse_language" with method
9185         call.
9186         * f-exp.y (yylex): Replace "parse_language" with method call.
9187         * d-exp.y (lex_one_token): Replace "parse_language" with method
9188         call.
9189         * c-exp.y:
9190         (lex_one_token, classify_name, yylex): Replace "parse_language"
9191         with method call.
9192         * ada-exp.y (find_primitive_type, type_char)
9193         (type_system_address): Replace "parse_language" with method call.
9194
9195 2019-04-04  Tom Tromey  <tom@tromey.com>
9196
9197         * rust-exp.y: Replace "parse_gdbarch" with method call.
9198         * parse.c (write_dollar_variable, insert_type_address_space):
9199         Replace "parse_gdbarch" with method call.
9200         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9201         call.
9202         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9203         call.
9204         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9205         "parse_gdbarch" with method call.
9206         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9207         with method call.
9208         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9209         "parse_gdbarch" with method call.
9210         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9211         "parse_gdbarch" with method call.
9212         * c-exp.y (parse_type, parse_number, classify_name): Replace
9213         "parse_gdbarch" with method call.
9214         * ada-lex.l: Replace "parse_gdbarch" with method call.
9215         * ada-exp.y (parse_type, find_primitive_type, type_char)
9216         (type_system_address): Replace "parse_gdbarch" with method call.
9217
9218 2019-04-04  Tom Tromey  <tom@tromey.com>
9219
9220         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9221         * stap-probe.c (stap_parse_argument): Update.
9222         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9223         initial_size parameter.
9224         * rust-exp.y (rust_lex_tests): Update.
9225         * parse.c (parser_state): Update.
9226         (parse_exp_in_context): Update.
9227         * parser-defs.h (struct parser_state) <parser_state>: Remove
9228         "initial_size" parameter.
9229
9230 2019-04-04  Tom Tromey  <tom@tromey.com>
9231
9232         * parser-defs.h (increase_expout_size): Don't declare.
9233         * parse.c (increase_expout_size): Now static.
9234
9235 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9236
9237         * gnu-nat.c (gnu_nat_target::wait): Fix
9238         target_waitstatus_to_string call.
9239
9240 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9241
9242         * eval.c (evaluate_subexp_standard): Handle internal functions
9243         during Fortran function call handling.
9244
9245 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9246
9247         * NEWS: Mention new internal functions.
9248         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9249         (read_base_type): Use dwarf2_init_complex_target_type.
9250         * value.c (creal_internal_fn): New function.
9251         (cimag_internal_fn): New function.
9252         (_initialize_values): Register new internal functions.
9253
9254 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9255
9256         * infrun.c (stop_all_threads): If debug_infrun, always
9257         trace the wait status after wait_one, using
9258         target_waitstatus_to_string and target_pid_to_str.
9259         (handle_inferior_event): Replace various trace of
9260         wait status kind by a single trace.
9261         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9262         wait status kind image by target_waitstatus_to_string.
9263         * target/waitstatus.c (target_waitstatus_to_string): Fix
9264         obsolete comment.
9265
9266 2019-04-01  Tom Tromey  <tromey@adacore.com>
9267
9268         PR symtab/23331:
9269         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9270
9271 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9272             Pedro Alves  <palves@redhat.com>
9273
9274         * top.c (quit_force): Call 'finalize_values'.
9275         * value.c (finalize_values): New function.
9276         * value.h (finalize_values): Declare.
9277
9278 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9279
9280         * NEWS: Announce $_gdb_major and $_gdb_minor.
9281
9282         * top.c (init_gdb_version_vars): New function.
9283         (gdb_init): Call init_gdb_version_vars.
9284
9285 2019-03-29  Tom Tromey  <tromey@adacore.com>
9286
9287         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9288         help text.  Remove dead code.
9289
9290 2019-03-29  Keith Seitz  <keiths@redhat.com>
9291
9292         From Siddhesh Poyarekar:
9293         * f-lang.h (f77_get_upperbound): Return LONGEST.
9294         (f77_get_lowerbound): Likewise.
9295         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9296         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9297         print them.
9298         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9299         plongest to format print it.
9300         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9301         (f77_get_upperbound): Likewise.
9302         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9303         LOWER_BOUND to LONGEST.
9304         (f77_create_arrayprint_offset_tbl): Likewise.
9305
9306 2019-03-29  Keith Seitz  <keiths@redhat.com>
9307
9308         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9309         %s/pulongest for TYPE_LENGTH instead of %d in format
9310         strings.
9311         * ada-typerint.c (ada_print_type): Likewise.
9312         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9313         * compile/compile-c-support.c (generate_register_struct): Likewise.
9314         * gdbtypes.c (recursive_dump_type): Likewise.
9315         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9316         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9317         instead of %d in format strings.
9318         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9319         to std::min to ULONGEST.
9320         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9321         instead of %d in format strings.
9322         * tracepoint.c (info_scope_command): Likewise.
9323         * typeprint.c (print_offset_data::update)
9324         (print_offset_data::finish): Likewise.
9325         * xtensa-tdep.c (xtensa_store_return_value)
9326         (xtensa_push_dummy_call): Likewise.
9327
9328 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9329
9330         * windows-nat.c (display_selector): Fixed format specifications
9331         for 64-bit Cygwin.
9332
9333 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9334
9335         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9336
9337 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9338
9339         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9340         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9341         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9342         (nios2_linux_init_abi): Install it.
9343
9344 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9345
9346         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9347
9348 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9349
9350         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9351
9352 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9353             Tom Tromey  <tromey@adacore.com>
9354
9355         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9356
9357 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9358
9359         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9360         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9361         method to compute the bounds of range types. Also print "[evaluated]"
9362         if the bounds' values come from a dynamic evaluation.
9363
9364 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9365
9366         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9367         whitespace when pretty printing is on.
9368
9369 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9370
9371         * ppc-linux-nat.c: Add include.
9372
9373 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9374
9375         * NEWS: Mention AArch64 Pointer Authentication.
9376
9377 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9378
9379         * arm-linux-nat.c: Add include.
9380
9381 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9382
9383         * source-cache.c (source_cache::get_source_lines): Re-read
9384         fullname after calling open_source_file.
9385
9386 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9387
9388         * NEWS: Mention TLS support for FreeBSD.
9389
9390 2019-03-25  Tom Tromey  <tromey@adacore.com>
9391
9392         * minsyms.c (BUNCH_SIZE): Update comment.
9393         (~minimal_symbol_reader): Remove old comment.
9394         (compact_minimal_symbols): Update comment.
9395         (minimal_symbol_reader::install): Remove old comment.  Update
9396         other comments.
9397
9398 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9399
9400         * s390-linux-nat.c: Add include.
9401
9402 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9403
9404         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9405         Call linux_get_hwcap.
9406         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9407         Likewise.
9408         (aarch64_linux_get_hwcap): Remove function.
9409         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9410         declaration.
9411         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9412         linux_get_hwcap.
9413         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9414         * linux-tdep.c (linux_get_hwcap): Add function.
9415         (linux_get_hwcap2): Likewise.
9416         * linux-tdep.h (linux_get_hwcap): Add declaration.
9417         (linux_get_hwcap2): Likewise.
9418         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9419         (ppc_linux_get_hwcap2): Likewise.
9420         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9421         linux_get_hwcap.
9422         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9423         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9424         (ppc_linux_nat_target::read_description): Likewise.
9425         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9426         * s390-linux-nat.c: Likewise.
9427         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9428
9429 2019-03-24  Tom Tromey  <tom@tromey.com>
9430
9431         * ada-lang.c (standard_lookup): Simplify initialization.
9432         (ada_lookup_symbol_nonlocal): Simplify return.
9433         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9434         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9435         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9436         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9437         initialization.
9438         * solib.c (solib_global_lookup): Simplify.
9439         * symtab.c (null_block_symbol): Remove.
9440         (symbol_cache_lookup): Simplify returns.
9441         (lookup_language_this): Simplify returns.
9442         (lookup_symbol_aux): Simplify return.
9443         (lookup_local_symbol): Simplify returns.
9444         (lookup_global_symbol_from_objfile): Simplify return.
9445         (lookup_symbol_in_objfile_symtabs)
9446         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9447         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9448         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9449         * cp-namespace.c (cp_lookup_bare_symbol)
9450         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9451         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9452         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9453         (cp_lookup_symbol_via_imports): Simplify initialization.
9454         (find_symbol_in_baseclass): Likewise.
9455         * symtab.h (null_block_symbol): Remove.
9456         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9457         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9458         (d_lookup_symbol_module): Likewise.
9459         (find_symbol_in_baseclass): Simplify initialization.
9460
9461 2019-03-24  Tom Tromey  <tom@tromey.com>
9462
9463         * expression.h: Don't include symtab.h.
9464         (struct block): Forward declare.
9465
9466 2019-03-24  Tom Tromey  <tom@tromey.com>
9467
9468         * c-exp.y (typebase): Remove casts.
9469         * gdbtypes.c (lookup_unsigned_typename, )
9470         (lookup_signed_typename): Remove cast.
9471         * eval.c (parse_to_comma_and_eval): Remove cast.
9472         * parse.c (write_dollar_variable): Remove cast.
9473         * block.h (struct block) <superblock>: Now const.
9474         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9475         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9476         (map_block): Make "block" const.
9477         * symfile.h (struct quick_symbol_functions)
9478         <map_matching_symbols>: Constify block argument to "callback".
9479         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9480         const.
9481         (find_pc_sect_compunit_symtab): Make "b" const.
9482         (find_symbol_at_address): Likewise.
9483         (search_symbols): Likewise.
9484         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9485         (dw2_debug_names_lookup_symbol): Likewise.
9486         (dw2_map_matching_symbols): Update.
9487         * p-valprint.c (pascal_val_print): Remove "block".
9488         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9489         (aux_add_nonlocal_symbols): Make "block" const.
9490         (resolve_subexp): Remove cast.
9491         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9492         const.
9493         (iterate_over_file_blocks): Likewise.
9494         * f-exp.y (%union) <bval>: Remove.
9495         * coffread.c (patch_opaque_types): Make "b" const.
9496         * spu-tdep.c (spu_catch_start): Make "block" const.
9497         * c-valprint.c (print_unpacked_pointer): Remove "block".
9498         * symmisc.c (dump_symtab_1): Make "b" const.
9499         (block_depth): Make "block" const.
9500         * d-exp.y (%union) <bval>: Remove.
9501         * cp-support.h (cp_lookup_rtti_type): Update.
9502         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9503         * psymtab.c (psym_lookup_symbol): Make "block" const.
9504         (maintenance_check_psymtabs): Make "b" const.
9505         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9506         (enumerate_locals, enumerate_args): Update.
9507         * python/py-symtab.c (stpy_global_block): Make "block" const.
9508         (stpy_static_block): Likewise.
9509         * inline-frame.c (block_starting_point_at): Make "new_block"
9510         const.
9511         * block.c (find_block_in_blockvector): Make return type const.
9512         (blockvector_for_pc_sect): Make "b" const.
9513         (find_block_in_blockvector): Make "b" const.
9514
9515 2019-03-23  Tom Tromey  <tom@tromey.com>
9516
9517         * varobj.c (varobj_create): Update.
9518         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9519         * printcmd.c (display_command, do_one_display): Don't reset
9520         innermost_block.
9521         * parser-defs.h (enum innermost_block_tracker_type): Move to
9522         expression.h.
9523         (innermost_block): Update comment.
9524         * parse.c (parse_exp_1): Add tracker_types parameter.
9525         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9526         tracker_types parameter.  Reset innermost_block.
9527         (parse_exp_in_context): Remove.
9528         (parse_expression_for_completion): Update.
9529         * objfiles.c (~objfile): Don't reset expression_context_block or
9530         innermost_block.
9531         * expression.h (enum innermost_block_tracker_type): Move from
9532         parser-defs.h.
9533         (parse_exp_1): Add tracker_types parameter.
9534         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9535         reset innermost_block.
9536
9537 2019-03-23  Tom Tromey  <tom@tromey.com>
9538
9539         * objfiles.h: Include bcache.h.
9540
9541 2019-03-23  Tom Tromey  <tom@tromey.com>
9542
9543         * linespec.c (get_current_search_block): Use
9544         scoped_restore_current_language.
9545         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9546
9547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9548             Jiong Wang  <jiong.wang@arm.com>
9549
9550         * aarch64-linux-tdep.c
9551         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9552         section.
9553         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9554
9555 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9556             Jiong Wang  <jiong.wang@arm.com>
9557
9558         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9559         instructions.
9560         (aarch64_analyze_prologue_test): Add PACIASP test.
9561         (aarch64_prologue_prev_register): Unmask PC value.
9562
9563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9564             Jiong Wang  <jiong.wang@arm.com>
9565
9566         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9567         (aarch64_dwarf2_prev_register): Unmask PC value.
9568         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9569         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9570         DW_CFA_AARCH64_negate_ra_state.
9571         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9572
9573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9574             Jiong Wang  <jiong.wang@arm.com>
9575
9576         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9577         registers.
9578         (aarch64_pseudo_register_name): Likewise.
9579         (aarch64_pseudo_register_type): Likewise.
9580         (aarch64_pseudo_register_reggroup_p): Likewise.
9581         (aarch64_gdbarch_init): Add pauth registers.
9582         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9583         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9584         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9585         (struct gdbarch_tdep): Add regnum for ra_state.
9586
9587 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9588             Jiong Wang  <jiong.wang@arm.com>
9589
9590         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9591
9592 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9593             Jiong Wang  <jiong.wang@arm.com>
9594
9595         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9596         function.
9597         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9598         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9599         (aarch64_gdbarch_init): Add puth registers.
9600         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9601         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9602         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9603
9604 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9605             Jiong Wang  <jiong.wang@arm.com>
9606
9607         * aarch64-linux-nat.c
9608         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9609         * aarch64-linux-tdep.c
9610         (aarch64_linux_core_read_description): Likewise.
9611         (aarch64_linux_get_hwcap): New function.
9612         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9613         (aarch64_linux_get_hwcap): New declaration.
9614
9615 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9616             Jiong Wang  <jiong.wang@arm.com>
9617
9618         * aarch64-linux-nat.c
9619         (aarch64_linux_nat_target::read_description): Add pauth param.
9620         * aarch64-linux-tdep.c
9621         (aarch64_linux_core_read_description): Likewise.
9622         * aarch64-tdep.c (struct target_desc): Add in pauth.
9623         (aarch64_read_description): Add pauth param.
9624         (aarch64_gdbarch_init): Likewise.
9625         * aarch64-tdep.h (aarch64_read_description): Likewise.
9626         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9627         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9628         * features/Makefile: Add new files.
9629         * features/aarch64-pauth.c: New file.
9630         * features/aarch64-pauth.xml: New file.
9631
9632 2019-03-20  Tom Tromey  <tromey@adacore.com>
9633
9634         * infrun.c (handle_inferior_event): Rename from
9635         handle_inferior_event_1.  Create a scoped_value_mark.
9636         (handle_inferior_event): Remove.
9637
9638 2019-03-19  Tom Tromey  <tromey@adacore.com>
9639
9640         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9641         * infrun.h (print_stop_event): Add "displays" parameter.
9642         * infrun.c (print_stop_event): Add "displays" parameter.
9643
9644 2019-03-19  Pedro Alves  <palves@redhat.com>
9645
9646         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9647         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9648         to -1.  Fix TABs vs spaces.
9649         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9650         * tui/tui-out.h (tui_ui_out) Add intro comments.
9651         <m_line, m_start_of_line>: In-class initialize, and add describing
9652         comment.
9653
9654 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9655
9656         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9657         variable names.
9658         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9659
9660 2019-03-18  Pedro Alves  <palves@redhat.com>
9661             Eli Zaretskii <eliz@gnu.org>
9662
9663         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9664         m_line and m_start_of_line.
9665
9666 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9667
9668         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9669         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9670         it returns a newline.  This fixes a regression in TU mode, whereby
9671         the next line is output on the same screen line as the user input.
9672
9673 2019-03-18  Tom Tromey  <tromey@adacore.com>
9674
9675         * minsyms.c (minimal_symbol_reader::install): Remove call to
9676         obstack_blank.
9677
9678 2019-03-18  Pedro Alves  <palves@redhat.com>
9679
9680         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9681         New globals.
9682         (apply_style): New, factored out from ...
9683         (apply_ansi_escape): ... this.  Handle reverse video mode.
9684         (tui_set_reverse_mode): New function.
9685         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9686         * tui/tui-winsource.c (tui_show_source_line): Use
9687         tui_set_reverse_mode instead of setting A_STANDOUT.
9688         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9689         New setter methods.
9690
9691 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9692
9693         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9694         Handle tabs.
9695
9696 2019-03-18  Tom Tromey  <tromey@adacore.com>
9697
9698         * ada-lang.c (empty_array): Add "high" parameter.
9699         (ada_evaluate_subexp): Update.
9700
9701 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9702
9703         * unittests/string_view-selftests.c: Define
9704         _initialize_string_view_selftests unconditionally.
9705
9706 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9707
9708         PR gdb/24350
9709         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9710
9711 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9712
9713         PR gdb/24351
9714         * windows-nat.c (display_selector): Fix format specifiers.
9715
9716 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9717
9718         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9719         tui_refill_source_window instead of tui_refresh_win, to update the
9720         current execution line.  This fixes redisplay of the current line
9721         when stepping through the code with "next" or "step".
9722
9723 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9724
9725         * source-cache.c (source_cache::get_source_lines): Call
9726         find_source_lines to initialize s->nlines.  This fixes vertical
9727         scrolling of TUI source window when the DOWN arrow is pressed.
9728
9729 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9730
9731         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9732         linux-thread-db.c (_initialize_thread_db): Likewise.
9733
9734 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9735
9736         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9737         wclrtoeol in tui_show_source_line".  This reverts changes made in
9738         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9739
9740 2019-03-15  Tom Tromey  <tom@tromey.com>
9741
9742         * symtab.h (struct minimal_symbol): Derive from
9743         general_symbol_info.
9744         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9745         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9746         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9747         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9748         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9749         (MSYMBOL_SEARCH_NAME): Update.
9750         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9751         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9752         * minsyms.c (minimal_symbol_reader::record_full): Update.
9753
9754 2019-03-15  Tom Tromey  <tom@tromey.com>
9755
9756         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9757
9758 2019-03-15  Tom Tromey  <tom@tromey.com>
9759
9760         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9761         unique_xmalloc_ptr.
9762         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9763         Update.
9764         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9765         (build_minimal_symbol_hash_tables)
9766         (minimal_symbol_reader::install): Update.
9767
9768 2019-03-15  Tom Tromey  <tom@tromey.com>
9769
9770         * symtab.c (create_demangled_names_hash): Update.
9771         (symbol_set_names): Update.
9772         * objfiles.h (struct objfile_per_bfd_storage)
9773         <demangled_names_hash>: Now an htab_up.
9774         * objfiles.c (objfile_per_bfd_storage): Simplify.
9775
9776 2019-03-15  Tom Tromey  <tom@tromey.com>
9777
9778         * objfiles.h (struct objfile_per_bfd_storage): Declare
9779         destructor.
9780         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9781         New.
9782         (get_objfile_bfd_data): Use new.  Don't initialize
9783         language_of_main.
9784         (free_objfile_per_bfd_storage): Remove.
9785         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9786
9787 2019-03-15  Tom Tromey  <tom@tromey.com>
9788
9789         * symfile.c (reread_symbols): Update.
9790         * objfiles.c (objfile::objfile): Update.
9791         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9792         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9793         comment.
9794         (minimal_symbol_reader::install): Update.
9795         (terminate_minimal_symbol_table): Remove.
9796         * jit.c (jit_object_close_impl): Update.
9797
9798 2019-03-15  Tom Tromey  <tom@tromey.com>
9799
9800         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9801         initializations.
9802
9803 2019-03-15  Tom Tromey  <tom@tromey.com>
9804
9805         * objfiles.h (struct objfile_per_bfd_storage)
9806         <demangled_hash_languages>: Now a bitset.
9807         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9808         (lookup_minimal_symbol): Update.
9809
9810 2019-03-15  Tom Tromey  <tom@tromey.com>
9811
9812         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9813         Don't return the symbol.
9814         * coffread.c (record_minimal_symbol): Use record_full.
9815
9816 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9817
9818         The MS-Windows port of ncurses fails to switch to a color pair if
9819         one or both of the colors are the implicit default colors.  This
9820         change records the default colors when TUI is initialized, and
9821         then specifies them explicitly when a color pair uses the default
9822         colors.  This allows color styling in TUI mode on MS-Windows.
9823
9824         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9825         ncurses_norm_attr.
9826         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9827         colors in ncurses_norm_attr.
9828         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9829         "none", replace it with the default color recorded in
9830         ncurses_norm_attr.
9831
9832 2019-03-14  Tom Tromey  <tromey@adacore.com>
9833
9834         * source-cache.h (class source_cache) <get_source_lines>: Return
9835         std::string.
9836         * source-cache.c (source_cache::extract_lines): Handle case where
9837         first_pos==npos.  Return std::string.
9838         (source_cache::get_source_lines): Update.
9839
9840 2019-03-14  Tom Tromey  <tromey@adacore.com>
9841
9842         * NEWS: Add item for "style sources" commands.
9843         * source-cache.c (source_cache::get_source_lines): Check
9844         source_styling.
9845         * cli/cli-style.c (source_styling): New global.
9846         (_initialize_cli_style): Add "style sources" commands.
9847         (show_style_sources): New function.
9848         * cli/cli-style.h (source_styling): Declare.
9849
9850 2019-03-14  Pedro Alves  <palves@redhat.com>
9851             Tom Tromey  <tromey@adacore.com>
9852
9853         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9854         * tui/tui-winsource.c (tui_refill_source_window): New function,
9855         from...
9856         (tui_horizontal_source_scroll): ... here.  Move some logic.
9857         * cli/cli-style.c (set_style_enabled): Notify new observable.
9858         * tui/tui-hooks.c (tui_redisplay_source): New function.
9859         (tui_attach_detach_observers): Attach or detach
9860         tui_redisplay_source.
9861         * observable.h (source_styling_changed): New observable.
9862         * observable.c: Define source_styling_changed observable.
9863
9864 2019-03-13  Tom Tromey  <tromey@adacore.com>
9865
9866         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9867         (i386_gnu_nat_target::store_registers): Update.
9868         * target-debug.h (target_debug_print_std_string): New macro.
9869         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9870         * windows-tdep.c (display_one_tib): Update.
9871         * tui/tui-stack.c (tui_make_status_line): Update.
9872         * top.c (print_inferior_quit_action): Update.
9873         * thread.c (thr_try_catch_cmd): Update.
9874         (add_thread_with_info): Update.
9875         (thread_target_id_str): Update.
9876         (thr_try_catch_cmd): Update.
9877         (thread_command): Update.
9878         (thread_find_command): Update.
9879         * record-btrace.c (record_btrace_target::info_record)
9880         (record_btrace_resume_thread, record_btrace_target::resume)
9881         (record_btrace_cancel_resume, record_btrace_step_thread)
9882         (record_btrace_target::wait, record_btrace_target::wait)
9883         (record_btrace_target::wait, record_btrace_target::stop): Update.
9884         * progspace.c (print_program_space): Update.
9885         * process-stratum-target.c
9886         (process_stratum_target::thread_address_space): Update.
9887         * linux-fork.c (linux_fork_mourn_inferior)
9888         (detach_checkpoint_command, info_checkpoints_command)
9889         (linux_fork_context): Update.
9890         (linux_fork_detach): Update.
9891         (class scoped_switch_fork_info): Update.
9892         (delete_checkpoint_command): Update.
9893         * infrun.c (follow_fork_inferior): Update.
9894         (follow_fork_inferior): Update.
9895         (proceed_after_vfork_done): Update.
9896         (handle_vfork_child_exec_or_exit): Update.
9897         (follow_exec): Update.
9898         (displaced_step_prepare_throw): Update.
9899         (displaced_step_restore): Update.
9900         (start_step_over): Update.
9901         (resume_1): Update.
9902         (clear_proceed_status_thread): Update.
9903         (proceed): Update.
9904         (print_target_wait_results): Update.
9905         (do_target_wait): Update.
9906         (context_switch): Update.
9907         (stop_all_threads): Update.
9908         (restart_threads): Update.
9909         (finish_step_over): Update.
9910         (handle_signal_stop): Update.
9911         (switch_back_to_stepped_thread): Update.
9912         (keep_going_pass_signal): Update.
9913         (print_exited_reason): Update.
9914         (normal_stop): Update.
9915         * inferior.c (inferior_pid_to_str): Change return type.
9916         (print_selected_inferior): Update.
9917         (add_inferior): Update.
9918         (detach_inferior): Update.
9919         * dummy-frame.c (fprint_dummy_frames): Update.
9920         * dcache.c (dcache_info_1): Update.
9921         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9922         (btrace_fetch, btrace_clear): Update.
9923         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9924         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9925         type.
9926         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9927         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9928         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9929         * gdbarch.c, gdbarch.h: Rebuild.
9930         * gdbarch.sh (core_pid_to_str): Change return type.
9931         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9932         return type.
9933         (windows_nat_target::pid_to_str): Change return type.
9934         (windows_delete_thread): Update.
9935         (windows_nat_target::attach): Update.
9936         (windows_nat_target::files_info): Update.
9937         * target-delegates.c: Rebuild.
9938         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9939         return type.
9940         (sol_thread_target::pid_to_str): Change return type.
9941         * remote.c (class remote_target) <pid_to_str>: Change return
9942         type.
9943         (remote_target::pid_to_str): Change return type.
9944         (extended_remote_target::attach, remote_target::remote_stop_ns)
9945         (remote_target::remote_notif_remove_queued_reply)
9946         (remote_target::push_stop_reply, remote_target::disable_btrace):
9947         Update.
9948         (extended_remote_target::attach): Update.
9949         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9950         type.
9951         (gdbsim_target::pid_to_str): Change return type.
9952         * ravenscar-thread.c (struct ravenscar_thread_target)
9953         <pid_to_str>: Change return type.
9954         (ravenscar_thread_target::pid_to_str): Change return type.
9955         * procfs.c (class procfs_target) <pid_to_str>: Change return
9956         type.
9957         (procfs_target::pid_to_str): Change return type.
9958         (procfs_target::attach): Update.
9959         (procfs_target::detach): Update.
9960         (procfs_target::fetch_registers): Update.
9961         (procfs_target::store_registers): Update.
9962         (procfs_target::wait): Update.
9963         (procfs_target::files_info): Update.
9964         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9965         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9966         return type.
9967         (nto_procfs_target::pid_to_str): Change return type.
9968         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9969         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9970         return type.
9971         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9972         (exit_lwp): Update.
9973         (attach_proc_task_lwp_callback, get_detach_signal)
9974         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9975         (linux_nat_target::resume, wait_lwp, stop_callback)
9976         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9977         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9978         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9979         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9980         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9981         type.
9982         (inf_ptrace_target::attach): Update.
9983         (inf_ptrace_target::files_info): Update.
9984         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9985         type.
9986         (go32_nat_target::pid_to_str): Change return type.
9987         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9988         (gnu_nat_target::wait): Update.
9989         (gnu_nat_target::wait): Update.
9990         (gnu_nat_target::resume): Update.
9991         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9992         (fbsd_nat_target::wait): Update.
9993         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9994         type.
9995         (darwin_nat_target::attach): Update.
9996         * corelow.c (class core_target) <pid_to_str>: Change return type.
9997         (core_target::pid_to_str): Change return type.
9998         * target.c (normal_pid_to_str): Change return type.
9999         (default_pid_to_str): Likewise.
10000         (target_pid_to_str): Change return type.
10001         (target_translate_tls_address): Update.
10002         (target_announce_detach): Update.
10003         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10004         return type.
10005         (bsd_uthread_target::pid_to_str): Change return type.
10006         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10007         type.
10008         (bsd_kvm_target::pid_to_str): Change return type.
10009         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10010         return type.
10011         (aix_thread_target::pid_to_str): Change return type.
10012         * target.h (struct target_ops) <pid_to_str>: Change return type.
10013         (target_pid_to_str, normal_pid_to_str): Likewise.
10014         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10015         type.
10016         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10017         type.
10018         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10019         return type.
10020         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10021         type.
10022         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10023         type.
10024         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10025         return type.
10026
10027 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10028
10029         * NEWS: Mention that the new default MI version is 3.  Mention
10030         changes to the output of commands and events that deal with
10031         multi-location breakpoints.
10032         * breakpoint.c: Include "mi/mi-out.h".
10033         (print_one_breakpoint): Change output syntax if using MI version
10034         >= 3.
10035         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10036         New.
10037         (mi_multi_location_breakpoint_output_fixed): New.
10038         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10039         (mi_cmd_fix_multi_location_breakpoint_output): New.
10040         (mi_multi_location_breakpoint_output_fixed): New.
10041         * mi/mi-cmds.c (mi_cmds): Register command
10042         -fix-multi-location-breakpoint-output.
10043         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10044         interpreter "mi".
10045
10046 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10047
10048         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10049         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10050         instantiate mi_ui_out based on interpreter name.
10051         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10052         * mi/mi-main.c (mi_load_progress): Likewise.
10053
10054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10055
10056         * NEWS: Combine separate "New targets" sections for 8.3.
10057
10058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10059
10060         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10061         (ppcfbsd_init_abi): Install gdbarch
10062         "fetch_tls_load_module_address" and "get_thread_local_address"
10063         methods.
10064
10065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10066
10067         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10068         (riscv_fbsd_init_abi): Install gdbarch
10069         "fetch_tls_load_module_address" and "get_thread_local_address"
10070         methods.
10071
10072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10073
10074         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10075         (i386fbsd_init_abi): Install gdbarch
10076         "fetch_tls_load_module_address" and "get_thread_local_address"
10077         methods.
10078
10079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10080
10081         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10082         (amd64fbsd_init_abi): Install gdbarch
10083         "fetch_tls_load_module_address" and "get_thread_local_address"
10084         methods.
10085
10086 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10087
10088         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10089         (struct fbsd_pspace_data): New type.
10090         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10091         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10092         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10093         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10094         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10095
10096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10097
10098         * gdbtypes.c (lookup_struct_elt): New function.
10099         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10100         * gdbtypes.h (struct struct_elt): New type.
10101         (lookup_struct_elt): New prototype.
10102
10103 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10104
10105         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10106         remove disabled code block.
10107
10108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10109
10110         * gdbarch.sh (get_thread_local_address): New method.
10111         * gdbarch.h, gdbarch.c: Regenerate.
10112         * target.c (target_translate_tls_address): Use
10113         gdbarch_get_thread_local_address if present instead of
10114         target::get_thread_local_address.
10115
10116 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10117
10118         * target.h (target::get_thread_local_address): Update comment.
10119
10120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10121
10122         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10123         objfile->separate_debug_objfile_backlink if not NULL.
10124
10125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10126
10127         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10128         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10129         (amd64bsd_store_inferior_registers): Likewise.
10130         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10131         Enable segment base registers.
10132         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10133         PT_GETFSBASE and PT_GETGSBASE.
10134         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10135         PT_SETGSBASE.
10136         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10137         segment base registers.
10138         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10139
10140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10141
10142         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10143         Update calls to i386_target_description to add 'segments'
10144         parameter.
10145         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10146         add segment base registers.
10147         * arch/i386.c (i386_create_target_description): Add 'segments'
10148         parameter to enable segment base registers.
10149         * arch/i386.h (i386_create_target_description): Likewise.
10150         * features/i386/32bit-segments.xml: New file.
10151         * features/i386/32bit-segments.c: Generate.
10152         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10153         call to i386_target_description to add 'segments' parameter.
10154         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10155         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10156         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10157         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10158         if feature is present.
10159         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10160         Add 'segments' parameter to call to i386_target_description.
10161         (i386_target_description): Add 'segments' parameter to enable
10162         segment base registers.
10163         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10164         to call to i386_target_description.
10165         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10166         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10167         Define I386_NUM_REGS.
10168         (i386_target_description): Add 'segments' parameter to enable
10169         segment base registers.
10170
10171 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10172
10173         PR/24325
10174         * source-cache.c: #undef open and close, to avoid unresolved
10175         externals during linking.
10176
10177 2019-03-12  Tom Tromey  <tromey@adacore.com>
10178
10179         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10180         const.  Add initializers.
10181         (_initialize_remote): Don't initialize ptid globals.
10182
10183 2019-03-12  Pedro Alves  <palves@redhat.com>
10184
10185         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10186
10187 2019-03-12  Pedro Alves  <palves@redhat.com>
10188
10189         * cp-name-parser.y (main): Remove unused 'len' variable.
10190
10191 2019-03-12  Tom Tromey  <tromey@adacore.com>
10192
10193         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10194         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10195
10196 2019-03-12  Tom Tromey  <tromey@adacore.com>
10197
10198         * linux-nat.c (iterate_over_lwps): Update.
10199         (stop_callback): Remove parameter.
10200         (stop_wait_callback, detach_callback, resume_set_callback)
10201         (select_singlestep_lwp_callback, set_ignore_sigint)
10202         (status_callback, resumed_callback, resume_clear_callback)
10203         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10204         data parameter.
10205         (linux_nat_target::detach, linux_nat_target::resume)
10206         (linux_stop_and_wait_all_lwps, select_event_lwp)
10207         (linux_nat_filter_event, linux_nat_wait_1)
10208         (linux_nat_target::kill, linux_nat_target::stop)
10209         (linux_nat_target::stop): Update.
10210         (linux_nat_resume_callback): Change type.
10211         (resume_stopped_resumed_lwps, count_events_callback)
10212         (select_event_lwp_callback): Likewise.
10213         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10214         * arm-linux-nat.c (struct update_registers_data): Remove.
10215         (update_registers_callback): Change type.
10216         (arm_linux_insert_hw_breakpoint1): Update.
10217         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10218         parameter.
10219         (x86_linux_dr_set_addr): Update.
10220         (x86_linux_dr_set_control): Update.
10221         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10222         (iterate_over_lwps): Use gdb::function_view.
10223         * nat/aarch64-linux-hw-point.c (struct
10224         aarch64_dr_update_callback_param): Remove.
10225         (debug_reg_change_callback): Change type.
10226         (aarch64_notify_debug_reg_change): Update.
10227         * s390-linux-nat.c (s390_refresh_per_info): Update.
10228
10229 2019-03-11  Tom Tromey  <tromey@adacore.com>
10230
10231         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10232         redundant assignment to "this_cu".
10233
10234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10235
10236         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10237
10238 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10239
10240         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10241         from...
10242         (rank_one_type): ... this.
10243
10244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10245
10246         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10247         from...
10248         (rank_one_type): ... this.
10249
10250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10251
10252         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10253         from...
10254         (rank_one_type): ... this.
10255
10256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10257
10258         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10259         from...
10260         (rank_one_type): ... this.
10261
10262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10263
10264         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10265         from...
10266         (rank_one_type): ... this.
10267
10268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10269
10270         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10271         from...
10272         (rank_one_type): ... this.
10273
10274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10275
10276         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10277         from...
10278         (rank_one_type): ... this.
10279
10280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10281
10282         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10283         from...
10284         (rank_one_type): ... this.
10285
10286 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10287
10288         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10289         from...
10290         (rank_one_type): ... this.
10291
10292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10293
10294         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10295         from...
10296         (rank_one_type): ... this.
10297
10298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10299
10300         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10301         from...
10302         (rank_one_type): ... this.
10303
10304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10305
10306         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10307         from...
10308         (rank_one_type): ... this.
10309
10310 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10311
10312         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10313         inferior-events' shows the example events.
10314
10315 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10316
10317         Support styling on native MS-Windows console
10318
10319         PR/24315
10320         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10321         on MS-Windows if $TERM is not defined.
10322
10323         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10324
10325         * posix-hdep.c (gdb_console_fputs):
10326         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10327         functions.
10328         * ui-file.h (gdb_console_fputs): Add prototype.
10329
10330         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10331         back to fputs only if the former returns zero.
10332
10333 2019-03-07  Tom Tromey  <tom@tromey.com>
10334
10335         * symmisc.c (print_symbol_bcache_statistics): Update.
10336         (print_objfile_statistics): Update.
10337         * symfile.c (allocate_symtab): Update.
10338         * stabsread.c: Don't include bcache.h.
10339         * psymtab.h (struct psymbol_bcache): Don't declare.
10340         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10341         (psymbol_bcache_init, psymbol_bcache_free)
10342         (psymbol_bcache_get_bcache): Don't declare.
10343         * psymtab.c (struct psymbol_bcache): Remove.
10344         (psymtab_storage::psymtab_storage): Update.
10345         (psymtab_storage::~psymtab_storage): Update.
10346         (psymbol_bcache_init, psymbol_bcache_free)
10347         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10348         (add_psymbol_to_bcache): Update.
10349         (allocate_psymtab): Update.
10350         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10351         macro_cache>: No longer pointers.
10352         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10353         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10354         * macrotab.c (macro_bcache): Update.
10355         * macroexp.c: Don't include bcache.h.
10356         * gdbtypes.c (check_types_worklist): Update.
10357         (types_deeply_equal): Remove TRY/CATCH.  Update.
10358         * elfread.c (elf_symtab_read): Update.
10359         * dwarf2read.c: Don't include bcache.h.
10360         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10361         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10362         (print_bcache_statistics, bcache_memory_used): Don't declare.
10363         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10364         methods.  Rename all data members.
10365         * bcache.c (struct bcache): Move to bcache.h.
10366         (bcache::expand_hash_table): Rename from expand_hash_table.
10367         (bcache): Remove.
10368         (bcache::insert): Rename from bcache_full.
10369         (bcache::compare): Rename from bcache_compare.
10370         (bcache_xmalloc): Remove.
10371         (bcache::~bcache): Rename from bcache_xfree.
10372         (bcache::print_statistics): Rename from print_bcache_statistics.
10373         (bcache::memory_used): Rename from bcache_memory_used.
10374
10375 2019-03-07  Pedro Alves  <palves@redhat.com>
10376
10377         * infrun.c (normal_stop): Also check for
10378         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10379
10380 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10381
10382         * f-lang.c (value_from_host_double): Moved to...
10383         * value.c (value_from_host_double): ...here.
10384         * value.h (value_from_host_double): Declare.
10385         * guile/scm-math.c (vlscm_convert_typed_number): Use
10386         value_from_host_double.
10387         (vlscm_convert_number): Likewise.
10388         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10389         * python/py-value.c (convert_value_from_python): Likewise.
10390
10391 2019-03-06  Tom Tromey  <tom@tromey.com>
10392
10393         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10394
10395 2019-03-06  Tom Tromey  <tom@tromey.com>
10396
10397         * utils.h (free_current_contents): Don't declare.
10398         * utils.c (free_current_contents): Remove.
10399
10400 2019-03-06  Tom Tromey  <tom@tromey.com>
10401
10402         * top.c (quit_force): Update.
10403         * main.c (captured_command_loop): Update.
10404         * common/new-op.c (operator new): Update.
10405         * common/common-exceptions.c (struct catcher)
10406         <save_cleanup_chain>: Remove member.
10407         (exceptions_state_mc_init): Update.
10408         (exception_try_scope_entry): Return nullptr.
10409         (exception_try_scope_exit, exception_rethrow)
10410         (throw_exception_sjlj, throw_exception_cxx): Update.
10411         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10412         (all_cleanups, do_cleanups, discard_cleanups)
10413         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10414         (restore_cleanups, restore_final_cleanups): Don't declare.
10415         (do_final_cleanups): Remove parameter.
10416         * common/cleanups.c (cleanup_chain, make_cleanup)
10417         (make_cleanup_dtor, all_cleanups, do_cleanups)
10418         (discard_my_cleanups, discard_cleanups)
10419         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10420         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10421         (null_cleanup): Remove.
10422         (do_final_cleanups): Remove parameter.
10423
10424 2019-03-06  Tom Tromey  <tom@tromey.com>
10425
10426         * remote.c (remote_target::remote_parse_stop_reply): Use
10427         unique_xmalloc_ptr.
10428
10429 2019-03-06  Tom Tromey  <tom@tromey.com>
10430
10431         * stabsread.c (struct stabs_field_info): Rename from field_info.
10432         <list, fnlist>: Add initializers.
10433         <obstack>: New member.
10434         (read_member_functions, read_struct_fields, read_baseclasses):
10435         Allocate on obstack.  Don't use cleanups.
10436         (read_one_struct_field, read_member_functions, read_struct_fields)
10437         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10438         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10439         (read_struct_type): Update.
10440
10441 2019-03-06  Tom Tromey  <tom@tromey.com>
10442
10443         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10444         * common/filestuff.h (make_cleanup_close): Don't declare.
10445         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10446         Remove.
10447
10448 2019-03-06  Tom Tromey  <tom@tromey.com>
10449
10450         * solib-aix.c: Use make_scope_exit.
10451
10452 2019-03-06  Tom Tromey  <tom@tromey.com>
10453
10454         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10455         Use make_scope_exit.
10456
10457 2019-03-06  Tom Tromey  <tom@tromey.com>
10458
10459         * solib-svr4.c (disable_probes_interface): Remove parameter.
10460         (svr4_handle_solib_event): Use make_scope_exit.
10461
10462 2019-03-06  Tom Tromey  <tom@tromey.com>
10463
10464         * remote.c (struct stop_reply_deleter): Remove.
10465         (stop_reply_up): Update.
10466         (struct stop_reply): Derive from notif_event.  Don't typedef.
10467         <regcache>: Now a std::vector.
10468         (stop_reply_xfree): Remove.
10469         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10470         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10471         (remote_target::discard_pending_stop_replies): Use delete.
10472         (remote_target::remote_parse_stop_reply): Update.
10473         (remote_target::process_stop_reply): Update.
10474         * remote-notif.h (struct notif_event): Add virtual destructor.
10475         Remove "dtr" member.
10476         (struct notif_client) <alloc_event>: Return a unique_ptr.
10477         (notif_event_xfree): Don't declare.
10478         (notif_event_up): New typedef.
10479         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10480         (notif_event_xfree, do_notif_event_xfree): Remove.
10481         (remote_notif_state_xfree): Update.
10482
10483 2019-03-06  Tom Tromey  <tom@tromey.com>
10484
10485         * infrun.c (displaced_step_clear_cleanup): Now a
10486         forward_scope_exit type.
10487         (displaced_step_prepare_throw): Update.
10488         (displaced_step_fixup): Update.
10489
10490 2019-03-06  Tom Tromey  <tom@tromey.com>
10491
10492         * inferior.h (class inferior): Update comment.
10493         * gdbthread.h (class thread_info): Update comment.
10494
10495 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10496             Tom Tromey  <tom@tromey.com>
10497
10498         * stabsread.h (struct stab_section_list): Remove.
10499         (coffstab_build_psymtabs): Update.
10500         * dbxread.c (symbuf_sections): Now a std::vector.
10501         (sect_idx): New global.
10502         (fill_symbuf): Update.
10503         (coffstab_build_psymtabs): Change type of stabsects parameter.
10504         Update.
10505         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10506         std::vector.
10507         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10508         (coff_locate_sections): Update.
10509         (coff_symfile_read): Remove cleanups.  Update.
10510         (init_stringtab): Add storage parameter.
10511         (free_stringtab, free_stringtab_cleanup): Remove.
10512         (init_lineno): Add storage parameter.
10513         (free_linetab, free_linetab_cleanup): Remove.
10514
10515 2019-03-06  Pedro Alves  <palves@redhat.com>
10516
10517         * linux-fork.c (fork_info::clobber_regs): Delete.
10518         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10519         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10520         comment.  Adjust.
10521         (scoped_switch_fork_info::scoped_switch_fork_info)
10522         (checkpoint_command, linux_fork_context): Adjust
10523         fork_save_infrun_state calls.
10524
10525 2019-03-06  Pedro Alves  <palves@redhat.com>
10526
10527         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10528         (inf_has_multiple_threads): Return 'bool' and rewrite using
10529         inferior_info::threads().
10530
10531 2019-03-06  Pedro Alves  <palves@redhat.com>
10532
10533         * linux-fork.c: Include <list>.
10534         (fork_list): Now a std::list instance.
10535         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10536         (forks_exist_p, find_last_fork): Adjust.
10537         (new_fork): Delete.
10538         (one_fork_p): New.
10539         (add_fork): Adjust.
10540         (free_fork): Delete, folded into fork_info::~fork_info().
10541         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10542         Adjust.
10543         (init_fork_list): Delete.
10544         (linux_fork_killall, linux_fork_mourn_inferior)
10545         (linux_fork_detach, info_checkpoints_command): Adjust.
10546         (_initialize_linux_fork): No longer call init_fork_list.
10547
10548 2019-03-06  Pedro Alves  <palves@redhat.com>
10549
10550         * linux-fork.c (new_fork): New, split out of ...
10551         (add_fork): ... this.  Return void.  Move "first fork" special
10552         case from here, to ...
10553         (checkpoint_command): ... here.
10554         * linux-linux.h (add_fork): Return void.
10555
10556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10557
10558         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10559
10560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10561             Chris January  <chris.january@arm.com>
10562             David Lecomber  <david.lecomber@arm.com>
10563
10564         * f-exp.y: New token, UNOP_INTRINSIC.
10565         (exp): New pattern using UNOP_INTRINSIC token.
10566         (f77_keywords): Add 'abs' keyword.
10567         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10568         (value_from_host_double): New function.
10569         (evaluate_subexp_f): Support UNOP_ABS.
10570
10571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10574         types.
10575
10576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10577
10578         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10579         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10580         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10581
10582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10583
10584         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10585
10586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10587             Chris January  <chris.january@arm.com>
10588
10589         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10590         * f-exp.y: Define 'KIND' token.
10591         (exp): New pattern for KIND expressions.
10592         (ptype): Handle types with a kind extension.
10593         (direct_abs_decl): Extend to spot kind extensions.
10594         (f77_keywords): Add 'kind' to the list.
10595         (push_kind_type): New function.
10596         (convert_to_kind_type): New function.
10597         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10598         * parse.c (operator_length_standard): Likewise.
10599         * parser-defs.h (enum type_pieces): Add tp_kind.
10600         * std-operator.def: Add UNOP_KIND.
10601
10602 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10603
10604         * f-exp.y (f_parse): Set yydebug.
10605
10606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10607
10608         * f-lang.c (evaluate_subexp_f): New function.
10609         (exp_descriptor_f): New global.
10610         (f_language_defn): Use exp_descriptor_f instead of
10611         exp_descriptor_standard.
10612
10613 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10614
10615         * f-exp.y (struct token): Add comments.
10616         (dot_ops): Remove uppercase versions and the end marker.
10617         (f77_keywords): Likewise.
10618         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10619         entries in the dot_ops array are case insensitive, and use
10620         strncasecmp to compare strings.  Also some whitespace cleanup in
10621         this area.  Similar for the f77_keywords array, except entries in
10622         this list might be case sensitive.
10623
10624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10625
10626         * f-exp.y (struct f77_boolean_val): Add comments.
10627         (boolean_values): Remove uppercase versions, and end marker.
10628         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10629         and use strncasecmp to achieve case insensitivity.  Additionally,
10630         perform whitespace cleanup around this code.
10631
10632 2019-03-06  Tom Tromey  <tromey@adacore.com>
10633
10634         * remote-sim.c (gdbsim_target_open): Use result of
10635         gdb_argv::release.
10636
10637 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10638         Dirk Schubert  <dirk.schubert@arm.com>
10639         Chris January  <chris.january@arm.com>
10640
10641         * eval.c (evaluate_subexp_standard): Call Fortran argument
10642         wrapping logic.
10643         * f-lang.c (struct value): A value which can be passed into a
10644         Fortran function call.
10645         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10646         where appropriate.
10647         (struct type): Value ready for a Fortran function call.
10648         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10649         is needed.
10650         * f-lang.h (fortran_argument_convert): Declaration.
10651         (fortran_preserve_arg_pointer): Declaration.
10652         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10653
10654 2019-03-05  Tom Tromey  <tromey@adacore.com>
10655
10656         * python/py-prettyprint.c (print_string_repr): Remove #if.
10657         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10658
10659 2019-03-05  Tom Tromey  <tromey@adacore.com>
10660
10661         * target.c (the_dummy_target): Move later.  Change type to
10662         "dummy_target".
10663         (initialize_targets): Don't initialize the_dummy_target.
10664
10665 2019-03-05  Tom Tromey  <tromey@adacore.com>
10666
10667         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10668         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10669
10670 2019-03-05  Tom Tromey  <tromey@adacore.com>
10671
10672         * windows-nat.c (windows_nat_target::attach)
10673         (windows_nat_target::detach): Don't call gdb_flush.
10674         * valprint.c (generic_val_print, val_print, val_print_string):
10675         Don't call gdb_flush.
10676         * utils.c (defaulted_query): Don't call gdb_flush.
10677         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10678         * target.c (target_announce_detach): Don't call gdb_flush.
10679         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10680         * remote.c (extended_remote_target::attach): Don't call
10681         gdb_flush.
10682         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10683         * printcmd.c (do_examine): Don't call gdb_flush.
10684         (info_display_command): Don't call gdb_flush.
10685         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10686         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10687         * memattr.c (info_mem_command): Don't call gdb_flush.
10688         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10689         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10690         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10691         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10692         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10693         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10694         (gnu_nat_target::detach): Don't call gdb_flush.
10695         * f-valprint.c (f_val_print): Don't call gdb_flush.
10696         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10697         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10698         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10699         gdb_flush.
10700         * c-valprint.c (c_val_print): Don't call gdb_flush.
10701         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10702
10703 2019-03-05  Tom Tromey  <tromey@adacore.com>
10704
10705         * varobj.c (update_dynamic_varobj_children): Update.
10706         (install_default_visualizer): Use reset, not release.
10707         * value.c (set_internalvar): Update.
10708         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10709         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10710         ATTRIBUTE_UNUSED_RESULT.
10711
10712 2019-03-05  Tom Tromey  <tromey@adacore.com>
10713
10714         * remote.c (class scoped_remote_fd) <release>: Add
10715         ATTRIBUTE_UNUSED_RESULT.
10716
10717 2019-03-05  Tom Tromey  <tromey@adacore.com>
10718
10719         * macroexp.c (struct macro_buffer) <release>: Add
10720         ATTRIBUTE_UNUSED_RESULT.
10721
10722 2019-03-05  Tom Tromey  <tromey@adacore.com>
10723
10724         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10725         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10726         ATTRIBUTE_UNUSED_RESULT.
10727
10728 2019-03-05  Tom Tromey  <tromey@adacore.com>
10729
10730         * common/scoped_fd.h (class scoped_fd) <release>: Add
10731         ATTRIBUTE_UNUSED_RESULT.
10732
10733 2019-03-05  Tom Tromey  <tromey@adacore.com>
10734
10735         * parser-defs.h (struct parser_state) <release>: Add
10736         ATTRIBUTE_UNUSED_RESULT.
10737
10738 2019-03-05  Tom Tromey  <tromey@adacore.com>
10739
10740         * utils.h (class gdb_argv) <release>: Add
10741         ATTRIBUTE_UNUSED_RESULT.
10742         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10743
10744 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10745
10746         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10747         for-loop range, to avoid compiler warnings.
10748
10749         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10750         avoid compiler warnings about unused variables.
10751
10752         * NEWS: Mention end of support for native debugging on MS-Windows
10753         before XP.
10754
10755         PR gdb/24292
10756         * common/netstuff.c:
10757         * gdbserver/gdbreplay.c
10758         * gdbserver/remote-utils.c:
10759         * ser-tcp.c:
10760         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10761         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10762         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10763         'getaddrinfo' and 'freeaddrinfo' were not available before
10764         Windows XP, and mingw.org's MinGW headers by default define
10765         _WIN32_WINNT to 0x500.
10766
10767 2019-03-01  Gary Benson <gbenson@redhat.com>
10768
10769         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10770
10771 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10772             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10773
10774         PR gdb/8527
10775         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10776         set_sigint_trap, clear_sigint_trap.
10777
10778 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10779
10780         * target.c (target_detach): Clear the regcache and the
10781         frame cache.
10782
10783 2019-02-27  Pedro Alves  <palves@redhat.com>
10784
10785         * utils.c (set_screen_size): When we cap the height/width sizes,
10786         tweak the corresponding command variable to show "unlimited":
10787
10788 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10789             Pedro Alves  <palves@redhat.com>
10790
10791         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10792         before calling rl_set_screen_size.
10793
10794 2019-02-27  Tom Tromey  <tromey@adacore.com>
10795
10796         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10797         define.
10798         * python/py-value.c: Remove Python 2.4 workaround.
10799         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10800         workaround.
10801         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10802         Python 2.4 workaround.
10803         * python/python-internal.h: Remove Python 2.4 comment.
10804         (Py_ssize_t): Don't define.
10805         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10806         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10807         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10808         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10809         * python/python.c (do_start_initialization): Remove Python 2.4
10810         workaround.
10811         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10812         (print_children): Remove Python 2.4 workaround.
10813         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10814         workaround.
10815         (CHARBUFFERPROC_NAME): Remove.
10816         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10817         Python 2.4 workaround.
10818
10819 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10820
10821         * NEWS: Note minimum Python version.
10822
10823 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10824
10825         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10826         code from these functions.  Remove corresponding ifdefs.  Use
10827         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10828         Remove gotos and target of gotos.
10829         (infpy_search_memory): Likewise.
10830
10831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10832
10833         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10834         (hppa_gdbarch_init): Don't register deleted functions with
10835         gdbarch.
10836
10837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10838
10839         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10840         (h8300_unwind_sp): Delete.
10841         (h8300_dummy_id): Delete.
10842         (h8300_gdbarch_init): Don't register deleted functions with
10843         gdbarch.
10844
10845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10846
10847         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10848         (ft32_unwind_pc): Delete.
10849         (ft32_unwind_sp): Delete.
10850         (ft32_gdbarch_init): Don't register deleted functions with
10851         gdbarch.
10852
10853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10856         (frv_unwind_pc): Delete.
10857         (frv_unwind_sp): Delete.
10858         (frv_gdbarch_init): Don't register deleted functions with
10859         gdbarch.
10860
10861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10862
10863         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10864         (riscv_unwind_pc): Delete.
10865         (riscv_unwind_sp): Delete.
10866         (riscv_gdbarch_init): Don't register deleted functions with
10867         gdbarch.
10868
10869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10870
10871         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10872         (csky_unwind_pc): Delete.
10873         (csky_unwind_sp): Delete.
10874         (csky_gdbarch_init): Don't register deleted functions with
10875         gdbarch.
10876
10877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10878
10879         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10880         (cris_unwind_pc): Delete.
10881         (cris_unwind_sp): Delete.
10882         (cris_gdbarch_init): Don't register deleted functions with
10883         gdbarch.
10884
10885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10886
10887         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10888         (bfin_unwind_pc): Delete.
10889         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10890
10891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10892
10893         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10894         (arm_unwind_pc): Delete.
10895         (arm_unwind_sp): Delete.
10896         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10897
10898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10899
10900         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10901         (arc_unwind_pc): Delete.
10902         (arc_unwind_sp): Delete.
10903         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10904
10905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10906
10907         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10908         (alpha_unwind_pc): Delete.
10909         (alpha_gdbarch_init): Don't register deleted functions with
10910         gdbarch.
10911
10912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10913
10914         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10915         (aarch64_unwind_pc): Delete.
10916         (aarch64_unwind_sp): Delete.
10917         (aarch64_gdbarch_init): Don't register deleted functions with
10918         gdbarch.
10919
10920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * gdbtypes.c (type_align): Don't consider static members when
10923         computing structure alignment.
10924
10925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10926
10927         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10928         return 0 for other types.
10929         * arch-utils.c (default_type_align): Always return 0.
10930         * gdbarch.h: Regenerate.
10931         * gdbarch.sh (type_align): Extend comment.
10932         * gdbtypes.c (type_align): Add additional comments, always call
10933         gdbarch_type_align before applying the default rules.
10934         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10935         generic code will then apply a suitable default.
10936         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10937         types, return 0 for other types.
10938
10939 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10940
10941         * NEWS: Create a new section for the next release branch.
10942         Rename the section of the current branch, now that it has
10943         been cut.
10944
10945 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10946
10947         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10948         * version.in: Bump version to 8.3.50.DATE-git.
10949
10950 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10951
10952         * aix-thread.c (ptid_cmp): Remove unused variable.
10953         (get_signaled_thread): Likewise.
10954         (store_regs_user_thread): Likewise.
10955         (store_regs_kernel_thread): Likewise.
10956         (fetch_regs_kernel_thread): Remove shadowed variable.
10957
10958 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10959
10960         * features/riscv/32bit-cpu.xml: Add register numbers.
10961         * features/riscv/32bit-fpu.c: Regenerate.
10962         * features/riscv/32bit-fpu.xml: Add register numbers.
10963         * features/riscv/64bit-cpu.xml: Add register numbers.
10964         * features/riscv/64bit-fpu.c: Regenerate.
10965         * features/riscv/64bit-fpu.xml: Add register numbers.
10966
10967 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10968
10969         * NEWS: Mention two argument form of gdb.Value constructor.
10970         * python/py-value.c (convert_buffer_and_type_to_value): New
10971         function.
10972         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10973         Add support for handling an optional second argument.  Call
10974         convert_buffer_and_type_to_value as appropriate.
10975         * python/python-internal.h (Py_buffer_deleter): New struct.
10976         (Py_buffer_up): New typedef.
10977
10978 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10979
10980         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10981         instead of releasing ownership.
10982
10983 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10984
10985         * dwarf2read.c (open_and_init_dwp_file): Call
10986         elf_numsections instead of bfd_count_sections to initialize
10987         dwp_file->num_sections.
10988
10989 2019-02-25  Tom Tromey  <tromey@adacore.com>
10990
10991         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10992
10993 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10994
10995         * gcore.in: Add '--readnever' option when invoking GDB.
10996
10997 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10998
10999         * MAINTAINERS: Update my email address.
11000
11001 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11002
11003         * build-id.c (build_id_to_debug_bfd_1): New function.
11004         (build_id_to_debug_bfd): Look for separate debug file in
11005         sysroot.
11006
11007 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11008
11009         * gdbarch.sh: Update the copyright year range that is placed into
11010         generated files.
11011
11012 2019-02-22  Keith Seitz  <keiths@redhat.com>
11013
11014         PR symtab/23853
11015         * linespec.c (create_sals_line_offset): Search for the default
11016         symtab's filename instead of its fullname.
11017
11018 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11019
11020         * NEWS: Update style defaults.
11021
11022 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11023
11024         * main.c (captured_main_1): Disable styling in batch mode.
11025
11026 2019-02-20  Tom Tromey  <tom@tromey.com>
11027
11028         * symtab.c (symtab_symbol_info): Fix typos.
11029
11030 2019-02-20  Tom Tromey  <tromey@adacore.com>
11031
11032         * findcmd.c (_initialize_mem_search): Use upper case for
11033         metasyntactic variables.
11034
11035 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11036
11037         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11038         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11039
11040 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11041
11042         * top.h (source_file_name): Change to std::string.
11043         * top.c (source_file_name): Likewise.
11044         (command_line_input): Adjust.
11045         * cli/cli-script.c (script_from_file): Adjust.
11046
11047 2019-02-19  Tom Tromey  <tromey@adacore.com>
11048
11049         * ravenscar-thread.c
11050         (ravenscar_thread_target::update_thread_list): Don't call
11051         ada_build_task_list.
11052         * ada-lang.h (ada_build_task_list): Don't declare.
11053         * ada-tasks.c (struct ada_tasks_inferior_data)
11054         <task_list_valid_p>: Now bool.
11055         (read_known_tasks, ada_task_list_changed)
11056         (ada_tasks_invalidate_inferior_data): Update.
11057         (read_known_tasks_array): Return bool.
11058         (read_known_tasks_list): Likewise.
11059         (read_known_tasks): Return void.
11060         (ada_build_task_list): Now static.
11061
11062 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11063
11064         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11065         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11066
11067 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11068
11069         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11070         variant for ada_tasks_pspace_data_handle and
11071         ada_tasks_inferior_data_handle.
11072         (ada_tasks_pspace_data_cleanup): New function.
11073         (ada_tasks_inferior_data_cleanup): New function.
11074
11075 2019-02-17  Tom Tromey  <tom@tromey.com>
11076
11077         * macrotab.h (macro_source_fullname): Return a std::string.
11078         * macrotab.c (macro_include, check_for_redefinition)
11079         (macro_undef, macro_lookup_definition, foreach_macro)
11080         (foreach_macro_in_scope): Update.
11081         (macro_source_fullname): Return a std::string.
11082         * macrocmd.c (show_pp_source_pos): Update.
11083
11084 2019-02-17  Tom Tromey  <tom@tromey.com>
11085
11086         * macrocmd.c (show_pp_source_pos): Style the file names.
11087
11088 2019-02-17  Tom Tromey  <tom@tromey.com>
11089
11090         PR tui/24197:
11091         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11092
11093 2019-02-17  Tom Tromey  <tom@tromey.com>
11094
11095         * ada-lang.c (user_select_syms): Use filtered printing.
11096         * utils.c (wrap_style): New global.
11097         (desired_style): Remove.
11098         (emit_style_escape): Add stream parameter.
11099         (set_output_style, reset_terminal_style, prompt_for_continue):
11100         Update.
11101         (flush_wrap_buffer): Only flush gdb_stdout.
11102         (wrap_here): Set wrap_style.
11103         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11104         treat escape sequences as a character.  Change when wrap buffer is
11105         flushed.
11106         (fputs_styled): Do not set the output style when the default is
11107         requested.
11108         * ui-style.h (struct ui_file_style) <is_default>: New method.
11109         * source.c (print_source_lines_base): Emit escape sequences in one
11110         piece.
11111
11112 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11113
11114         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11115         integers and enumeration types.
11116
11117 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11118
11119         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11120         instead of lookup_symbol_in_language
11121         (do_exact_match): New function.
11122         (ada_get_symbol_name_matcher): Return do_exact_match when
11123         doing a verbatim match.
11124
11125 2019-02-15  Tom Tromey  <tromey@adacore.com>
11126
11127         * ravenscar-thread.c (ravenscar_thread_target::resume)
11128         (ravenscar_thread_target::wait): Special case wildcard requests.
11129
11130 2019-02-15  Tom Tromey  <tromey@adacore.com>
11131
11132         * ravenscar-thread.c (base_ptid): Remove.
11133         (struct ravenscar_thread_target) <close>: New method.
11134         <m_base_ptid>: New member.
11135         <update_inferior_ptid, active_task, task_is_currently_active,
11136         runtime_initialized>: Declare methods.
11137         <ravenscar_thread_target>: Add constructor.
11138         (ravenscar_thread_target::task_is_currently_active)
11139         (ravenscar_thread_target::update_inferior_ptid)
11140         (ravenscar_runtime_initialized): Rename.  Now methods.
11141         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11142         (ravenscar_thread_target::update_thread_list): Update.
11143         (ravenscar_thread_target::active_task): Now method.
11144         (ravenscar_thread_target::store_registers)
11145         (ravenscar_thread_target::prepare_to_store)
11146         (ravenscar_thread_target::prepare_to_store)
11147         (ravenscar_thread_target::mourn_inferior): Update.
11148         (ravenscar_inferior_created): Use "new" to create target.
11149         (ravenscar_thread_target::get_ada_task_ptid): Update.
11150         (_initialize_ravenscar): Don't initialize base_ptid.
11151         (ravenscar_ops): Remove global.
11152
11153 2019-02-15  Tom Tromey  <tromey@adacore.com>
11154
11155         * target.h (push_target): Declare new overload.
11156         * target.c (push_target): New overload, taking an rvalue reference.
11157         * remote.c (remote_target::open_1): Use push_target overload.
11158         * corelow.c (core_target_open): Use push_target overload.
11159
11160 2019-02-15  Tom Tromey  <tromey@adacore.com>
11161
11162         * ravenscar-thread.c (is_ravenscar_task)
11163         (ravenscar_task_is_currently_active): Return bool.
11164         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11165         (_initialize_ravenscar): Remove "(void)".
11166         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11167         Return bool.
11168
11169 2019-02-15  Tom Tromey  <tromey@adacore.com>
11170
11171         * ravenscar-thread.c (ravenscar_runtime_initializer)
11172         (has_ravenscar_runtime, get_running_thread_id)
11173         (ravenscar_thread_target::resume): Fix indentation.
11174
11175 2019-02-15  Tom Tromey  <tromey@adacore.com>
11176
11177         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11178         from ravenscar_arch_ops.
11179         (sparc_ravenscar_ops::fetch_registers)
11180         (sparc_ravenscar_ops::store_registers): Now methods.
11181         (sparc_ravenscar_prepare_to_store): Remove.
11182         (sparc_ravenscar_ops): Redefine.
11183         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11184         methods and destructor.  Remove members.
11185         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11186         (ravenscar_thread_target::store_registers)
11187         (ravenscar_thread_target::prepare_to_store): Update.
11188         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11189         Remove.
11190         (struct ppc_ravenscar_powerpc_ops): Derive from
11191         ravenscar_arch_ops.
11192         (ppc_ravenscar_powerpc_ops::fetch_registers)
11193         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11194         (ppc_ravenscar_powerpc_ops): Redefine.
11195         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11196         (ppc_ravenscar_e500_ops::fetch_registers)
11197         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11198         (ppc_ravenscar_e500_ops): Redefine.
11199         * aarch64-ravenscar-thread.c
11200         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11201         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11202         (aarch64_ravenscar_fetch_registers)
11203         (aarch64_ravenscar_store_registers): Now methods.
11204         (aarch64_ravenscar_ops): Redefine.
11205
11206 2019-02-15  Tom Tromey  <tromey@adacore.com>
11207
11208         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11209         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11210         (ravenscar_thread_target::stopped_by_watchpoint)
11211         (ravenscar_thread_target::stopped_data_address)
11212         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11213
11214 2019-02-15  Tom Tromey  <tromey@adacore.com>
11215
11216         * ravenscar-thread.c: Fix some typos.
11217
11218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11219             Tom Tromey  <tromey@adacore.com>
11220
11221         * ada-lang.c (ada_exception_sal): Change addr_string to a
11222         std::string.
11223         (create_ada_exception_catchpoint): Update.
11224
11225 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11226             Tom Tromey  <tromey@adacore.com>
11227
11228         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11229         (bp_location_ops): Remove.
11230         (base_breakpoint_allocate_location): Update.
11231         (free_bp_location): Update.
11232         * ada-lang.c (class ada_catchpoint_location)
11233         <ada_catchpoint_location>: Remove ops parameter.
11234         (ada_catchpoint_location_dtor): Remove.
11235         (ada_catchpoint_location_ops): Remove.
11236         (allocate_location_exception): Update.
11237         * breakpoint.h (struct bp_location_ops): Remove.
11238         (class bp_location) <bp_location>: Remove bp_location_ops
11239         parameter.
11240         <~bp_location>: Add destructor.
11241         <ops>: Remove.
11242
11243 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11244             Pedro Alves  <palves@redhat.com>
11245
11246         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11247         'PATH_MAX'.
11248
11249 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11250             Samuel Thibault  <samuel.thibault@gnu.org>
11251             Thomas Schwinge  <thomas@codesourcery.com>
11252
11253         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11254         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11255
11256 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11257
11258         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11259         (check_empty): Use "const char *".
11260
11261         * gnu-nat.c (gnu_nat_target::detach): Instead of
11262         'detach_inferior (pid)' call
11263         'detach_inferior (find_inferior_pid (pid))'.
11264
11265         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11266         'nat/fork-inferior.o'.
11267         * gnu-nat.c: #include "nat/fork-inferior.h".
11268
11269         * gnu-nat.c (gnu_nat_target::detach): Instead of
11270         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11271         * gnu-nat.h: #include "inf-child.h".
11272         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11273         'i386_gnu_nat_target::fetch_registers'.
11274         (gnu_store_registers): Rename/move to
11275         'i386_gnu_nat_target::store_registers'.
11276
11277         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11278         * gnu-nat.h (mach_thread_info): New function.
11279         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11280
11281         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11282
11283 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11284
11285         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11286
11287 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11288
11289         * windows-nat.c (windows_add_thread): Add new parameter
11290         "main_thread_p" with default value set to false.  Update
11291         function documentation as well as all callers.
11292         (windows_delete_thread): Likewise.
11293         (fake_create_process): Update call to windows_add_thread.
11294         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11295         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11296         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11297         call to windows_delete_thread.
11298
11299 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11300
11301         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11302
11303 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11304
11305         * symfile.c (find_separate_debug_file): Use canonical path of
11306         sysroot with child_path instead of gdb_sysroot if it is valid.
11307
11308 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11309
11310         * symfile.c (find_separate_debug_file): Use child_path to
11311         determine if an object file is under a sysroot.
11312
11313 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11314
11315         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11316         unittests/child-path-selftests.c.
11317         * common/pathstuff.c (child_path): New function.
11318         * common/pathstuff.h (child_path): New prototype.
11319         * unittests/child-path-selftests.c: New file.
11320
11321 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11322
11323         * symfile.c (find_separate_debug_file): Look for separate debug
11324         files in debug directories under the sysroot.
11325
11326 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11327
11328         * symtab.h (struct minimal_symbol data_p): New const method.
11329         (struct minimal_symbol text_p): Likewise.
11330         * symtab.c (output_source_filename): Use file name style
11331         to print file name.
11332         (print_symbol_info): Likewise.
11333         (print_msymbol_info): Use address style to print addresses.
11334         Use function name style to print executable text symbols.
11335         (expand_symtab_containing_pc): Use data_p.
11336         (find_pc_sect_compunit_symtab): Likewise.
11337
11338 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11339
11340         * breakpoint.c (describe_other_breakpoints): Use address style
11341         to print addresses.
11342         (say_where): Likewise.
11343
11344 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11345
11346         * ada-typeprint.c (print_func_type): Print function name
11347         style to print function name.
11348         * c-typeprint.c (c_print_type_1): Likewise.
11349
11350 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11351
11352         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11353         for execve.
11354
11355 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11356
11357         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11358         type_stack.
11359
11360 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11361
11362         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11363         TYPE_CODE_REF types.
11364
11365 2019-02-08  Jim Wilson  <jimw@sifive.com>
11366
11367         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11368         (riscv_linux_fregset): New.
11369         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11370
11371 2019-02-07  Tom Tromey  <tom@tromey.com>
11372
11373         * thread.c (thread_cancel_execution_command): Update.
11374         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11375         methods.
11376         (struct thread_fsm_ops): Remove.
11377         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11378         (thread_fsm_should_stop, thread_fsm_return_value)
11379         (thread_fsm_set_finished, thread_fsm_finished_p)
11380         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11381         Don't declare.
11382         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11383         * infrun.c (clear_proceed_status_thread)
11384         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11385         (print_stop_event): Update.
11386         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11387         Add constructor.
11388         (step_command_fsm_ops): Remove.
11389         (new_step_command_fsm): Remove.
11390         (step_1): Update.
11391         (step_command_fsm::should_stop): Rename from
11392         step_command_fsm_should_stop.
11393         (step_command_fsm::clean_up): Rename from
11394         step_command_fsm_clean_up.
11395         (step_command_fsm::do_async_reply_reason): Rename from
11396         step_command_fsm_async_reply_reason.
11397         (struct until_next_fsm): Inherit from thread_fsm.  Add
11398         constructor.
11399         (until_next_fsm_ops): Remove.
11400         (new_until_next_fsm): Remove.
11401         (until_next_fsm::should_stop): Rename from
11402         until_next_fsm_should_stop.
11403         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11404         (until_next_fsm::do_async_reply_reason): Rename from
11405         until_next_fsm_async_reply_reason.
11406         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11407         constructor.  Change type of breakpoint.
11408         (finish_command_fsm_ops): Remove.
11409         (new_finish_command_fsm): Remove.
11410         (finish_command_fsm::should_stop): Rename from
11411         finish_command_fsm_should_stop.
11412         (finish_command_fsm::clean_up): Rename from
11413         finish_command_fsm_clean_up.
11414         (finish_command_fsm::return_value): Rename from
11415         finish_command_fsm_return_value.
11416         (finish_command_fsm::do_async_reply_reason): Rename from
11417         finish_command_fsm_async_reply_reason.
11418         (finish_command): Update.
11419         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11420         Add constructor.
11421         (call_thread_fsm_ops): Remove.
11422         (call_thread_fsm::call_thread_fsm): Rename from
11423         new_call_thread_fsm.
11424         (call_thread_fsm::should_stop): Rename from
11425         call_thread_fsm_should_stop.
11426         (call_thread_fsm::should_notify_stop): Rename from
11427         call_thread_fsm_should_notify_stop.
11428         (run_inferior_call, call_function_by_hand_dummy): Update.
11429         * cli/cli-interp.c (should_print_stop_to_console): Update.
11430         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11431         Add constructor.  Change type of location_breakpoint,
11432         caller_breakpoint.
11433         (until_break_fsm_ops): Remove.
11434         (new_until_break_fsm): Remove.
11435         (until_break_fsm::should_stop): Rename from
11436         until_break_fsm_should_stop.
11437         (until_break_fsm::clean_up): Rename from
11438         until_break_fsm_clean_up.
11439         (until_break_fsm::do_async_reply_reason): Rename from
11440         until_break_fsm_async_reply_reason.
11441         (until_break_command): Update.
11442         * thread-fsm.c: Remove.
11443         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11444
11445 2019-02-07  Tom Tromey  <tom@tromey.com>
11446
11447         * yy-remap.h: Add include guard.
11448         * xtensa-tdep.h: Add include guard.
11449         * xcoffread.h: Rename include guard.
11450         * varobj-iter.h: Add include guard.
11451         * tui/tui.h: Rename include guard.
11452         * tui/tui-winsource.h: Rename include guard.
11453         * tui/tui-wingeneral.h: Rename include guard.
11454         * tui/tui-windata.h: Rename include guard.
11455         * tui/tui-win.h: Rename include guard.
11456         * tui/tui-stack.h: Rename include guard.
11457         * tui/tui-source.h: Rename include guard.
11458         * tui/tui-regs.h: Rename include guard.
11459         * tui/tui-out.h: Rename include guard.
11460         * tui/tui-layout.h: Rename include guard.
11461         * tui/tui-io.h: Rename include guard.
11462         * tui/tui-hooks.h: Rename include guard.
11463         * tui/tui-file.h: Rename include guard.
11464         * tui/tui-disasm.h: Rename include guard.
11465         * tui/tui-data.h: Rename include guard.
11466         * tui/tui-command.h: Rename include guard.
11467         * tic6x-tdep.h: Add include guard.
11468         * target/waitstatus.h: Rename include guard.
11469         * target/wait.h: Rename include guard.
11470         * target/target.h: Rename include guard.
11471         * target/resume.h: Rename include guard.
11472         * target-float.h: Rename include guard.
11473         * stabsread.h: Add include guard.
11474         * rs6000-tdep.h: Add include guard.
11475         * riscv-fbsd-tdep.h: Add include guard.
11476         * regformats/regdef.h: Rename include guard.
11477         * record.h: Rename include guard.
11478         * python/python.h: Rename include guard.
11479         * python/python-internal.h: Rename include guard.
11480         * python/py-stopevent.h: Rename include guard.
11481         * python/py-ref.h: Rename include guard.
11482         * python/py-record.h: Rename include guard.
11483         * python/py-record-full.h: Rename include guard.
11484         * python/py-record-btrace.h: Rename include guard.
11485         * python/py-instruction.h: Rename include guard.
11486         * python/py-events.h: Rename include guard.
11487         * python/py-event.h: Rename include guard.
11488         * procfs.h: Add include guard.
11489         * proc-utils.h: Add include guard.
11490         * p-lang.h: Add include guard.
11491         * or1k-tdep.h: Rename include guard.
11492         * observable.h: Rename include guard.
11493         * nto-tdep.h: Rename include guard.
11494         * nat/x86-linux.h: Rename include guard.
11495         * nat/x86-linux-dregs.h: Rename include guard.
11496         * nat/x86-gcc-cpuid.h: Add include guard.
11497         * nat/x86-dregs.h: Rename include guard.
11498         * nat/x86-cpuid.h: Rename include guard.
11499         * nat/ppc-linux.h: Rename include guard.
11500         * nat/mips-linux-watch.h: Rename include guard.
11501         * nat/linux-waitpid.h: Rename include guard.
11502         * nat/linux-ptrace.h: Rename include guard.
11503         * nat/linux-procfs.h: Rename include guard.
11504         * nat/linux-osdata.h: Rename include guard.
11505         * nat/linux-nat.h: Rename include guard.
11506         * nat/linux-namespaces.h: Rename include guard.
11507         * nat/linux-btrace.h: Rename include guard.
11508         * nat/glibc_thread_db.h: Rename include guard.
11509         * nat/gdb_thread_db.h: Rename include guard.
11510         * nat/gdb_ptrace.h: Rename include guard.
11511         * nat/fork-inferior.h: Rename include guard.
11512         * nat/amd64-linux-siginfo.h: Rename include guard.
11513         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11514         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11515         * nat/aarch64-linux.h: Rename include guard.
11516         * nat/aarch64-linux-hw-point.h: Rename include guard.
11517         * mn10300-tdep.h: Add include guard.
11518         * mips-linux-tdep.h: Add include guard.
11519         * mi/mi-parse.h: Rename include guard.
11520         * mi/mi-out.h: Rename include guard.
11521         * mi/mi-main.h: Rename include guard.
11522         * mi/mi-interp.h: Rename include guard.
11523         * mi/mi-getopt.h: Rename include guard.
11524         * mi/mi-console.h: Rename include guard.
11525         * mi/mi-common.h: Rename include guard.
11526         * mi/mi-cmds.h: Rename include guard.
11527         * mi/mi-cmd-break.h: Rename include guard.
11528         * m2-lang.h: Add include guard.
11529         * location.h: Rename include guard.
11530         * linux-record.h: Rename include guard.
11531         * linux-nat.h: Add include guard.
11532         * linux-fork.h: Add include guard.
11533         * i386-darwin-tdep.h: Rename include guard.
11534         * hppa-linux-offsets.h: Add include guard.
11535         * guile/guile.h: Rename include guard.
11536         * guile/guile-internal.h: Rename include guard.
11537         * gnu-nat.h: Rename include guard.
11538         * gdb-stabs.h: Rename include guard.
11539         * frv-tdep.h: Add include guard.
11540         * f-lang.h: Add include guard.
11541         * event-loop.h: Add include guard.
11542         * darwin-nat.h: Rename include guard.
11543         * cp-abi.h: Rename include guard.
11544         * config/sparc/nm-sol2.h: Rename include guard.
11545         * config/nm-nto.h: Rename include guard.
11546         * config/nm-linux.h: Add include guard.
11547         * config/i386/nm-i386gnu.h: Rename include guard.
11548         * config/djgpp/nl_types.h: Rename include guard.
11549         * config/djgpp/langinfo.h: Rename include guard.
11550         * compile/gcc-cp-plugin.h: Add include guard.
11551         * compile/gcc-c-plugin.h: Add include guard.
11552         * compile/compile.h: Rename include guard.
11553         * compile/compile-object-run.h: Rename include guard.
11554         * compile/compile-object-load.h: Rename include guard.
11555         * compile/compile-internal.h: Rename include guard.
11556         * compile/compile-cplus.h: Rename include guard.
11557         * compile/compile-c.h: Rename include guard.
11558         * common/xml-utils.h: Rename include guard.
11559         * common/x86-xstate.h: Rename include guard.
11560         * common/version.h: Rename include guard.
11561         * common/vec.h: Rename include guard.
11562         * common/tdesc.h: Rename include guard.
11563         * common/selftest.h: Rename include guard.
11564         * common/scoped_restore.h: Rename include guard.
11565         * common/scoped_mmap.h: Rename include guard.
11566         * common/scoped_fd.h: Rename include guard.
11567         * common/safe-iterator.h: Rename include guard.
11568         * common/run-time-clock.h: Rename include guard.
11569         * common/refcounted-object.h: Rename include guard.
11570         * common/queue.h: Rename include guard.
11571         * common/ptid.h: Rename include guard.
11572         * common/print-utils.h: Rename include guard.
11573         * common/preprocessor.h: Rename include guard.
11574         * common/pathstuff.h: Rename include guard.
11575         * common/observable.h: Rename include guard.
11576         * common/netstuff.h: Rename include guard.
11577         * common/job-control.h: Rename include guard.
11578         * common/host-defs.h: Rename include guard.
11579         * common/gdb_wait.h: Rename include guard.
11580         * common/gdb_vecs.h: Rename include guard.
11581         * common/gdb_unlinker.h: Rename include guard.
11582         * common/gdb_unique_ptr.h: Rename include guard.
11583         * common/gdb_tilde_expand.h: Rename include guard.
11584         * common/gdb_sys_time.h: Rename include guard.
11585         * common/gdb_string_view.h: Rename include guard.
11586         * common/gdb_splay_tree.h: Rename include guard.
11587         * common/gdb_setjmp.h: Rename include guard.
11588         * common/gdb_ref_ptr.h: Rename include guard.
11589         * common/gdb_optional.h: Rename include guard.
11590         * common/gdb_locale.h: Rename include guard.
11591         * common/gdb_assert.h: Rename include guard.
11592         * common/filtered-iterator.h: Rename include guard.
11593         * common/filestuff.h: Rename include guard.
11594         * common/fileio.h: Rename include guard.
11595         * common/environ.h: Rename include guard.
11596         * common/common-utils.h: Rename include guard.
11597         * common/common-types.h: Rename include guard.
11598         * common/common-regcache.h: Rename include guard.
11599         * common/common-inferior.h: Rename include guard.
11600         * common/common-gdbthread.h: Rename include guard.
11601         * common/common-exceptions.h: Rename include guard.
11602         * common/common-defs.h: Rename include guard.
11603         * common/common-debug.h: Rename include guard.
11604         * common/cleanups.h: Rename include guard.
11605         * common/buffer.h: Rename include guard.
11606         * common/btrace-common.h: Rename include guard.
11607         * common/break-common.h: Rename include guard.
11608         * cli/cli-utils.h: Rename include guard.
11609         * cli/cli-style.h: Rename include guard.
11610         * cli/cli-setshow.h: Rename include guard.
11611         * cli/cli-script.h: Rename include guard.
11612         * cli/cli-interp.h: Rename include guard.
11613         * cli/cli-decode.h: Rename include guard.
11614         * cli/cli-cmds.h: Rename include guard.
11615         * charset-list.h: Add include guard.
11616         * buildsym-legacy.h: Rename include guard.
11617         * bfin-tdep.h: Add include guard.
11618         * ax.h: Rename include guard.
11619         * arm-linux-tdep.h: Add include guard.
11620         * arm-fbsd-tdep.h: Add include guard.
11621         * arch/xtensa.h: Rename include guard.
11622         * arch/tic6x.h: Add include guard.
11623         * arch/i386.h: Add include guard.
11624         * arch/arm.h: Rename include guard.
11625         * arch/arm-linux.h: Rename include guard.
11626         * arch/arm-get-next-pcs.h: Rename include guard.
11627         * arch/amd64.h: Add include guard.
11628         * arch/aarch64-insn.h: Rename include guard.
11629         * arch-utils.h: Rename include guard.
11630         * annotate.h: Add include guard.
11631         * amd64-darwin-tdep.h: Rename include guard.
11632         * aarch64-linux-tdep.h: Add include guard.
11633         * aarch64-fbsd-tdep.h: Add include guard.
11634         * aarch32-linux-nat.h: Add include guard.
11635
11636 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11637
11638         * macrotab.c (macro_define_internal): New function that
11639         factorizes macro_define_object_internal and macro_define_function
11640         code.
11641         (macro_define_object_internal): Use macro_define_internal.
11642         (macro_define_function): Likewise.
11643
11644 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11645
11646         * macrocmd.c (extract_identifier): Return
11647         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11648         callers.
11649
11650 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11651
11652         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11653
11654 2019-02-05  Tom Tromey  <tom@tromey.com>
11655
11656         * target.c (target_stack::unpush): Move assertion earlier.
11657
11658 2019-01-30  Tom Tromey  <tom@tromey.com>
11659
11660         PR python/23615:
11661         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11662         (gdbpy_parse_and_eval): Likewise.
11663         * python/python-internal.h (gdbpy_allow_threads): New class.
11664
11665 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11666
11667         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11668         (aarch64_fbsd_fpregmap): Move earlier.
11669         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11670         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11671         instead of individual calls to trad_frame_set_reg_addr.
11672         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11673         earlier.
11674         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11675         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11676         instead of individual calls to trad_frame_set_reg_addr.
11677
11678 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11679
11680         * CONTRIBUTE: Replace contribution list with wiki link.
11681
11682 2019-01-25  Tom Tromey  <tom@tromey.com>
11683
11684         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11685
11686 2019-01-25  Tom Tromey  <tom@tromey.com>
11687
11688         * xtensa-linux-nat.c: Fix common/ includes.
11689         * xml-support.h: Fix common/ includes.
11690         * xml-support.c: Fix common/ includes.
11691         * x86-linux-nat.c: Fix common/ includes.
11692         * windows-nat.c: Fix common/ includes.
11693         * varobj.h: Fix common/ includes.
11694         * varobj.c: Fix common/ includes.
11695         * value.c: Fix common/ includes.
11696         * valops.c: Fix common/ includes.
11697         * utils.c: Fix common/ includes.
11698         * unittests/xml-utils-selftests.c: Fix common/ includes.
11699         * unittests/utils-selftests.c: Fix common/ includes.
11700         * unittests/unpack-selftests.c: Fix common/ includes.
11701         * unittests/tracepoint-selftests.c: Fix common/ includes.
11702         * unittests/style-selftests.c: Fix common/ includes.
11703         * unittests/string_view-selftests.c: Fix common/ includes.
11704         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11705         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11706         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11707         * unittests/rsp-low-selftests.c: Fix common/ includes.
11708         * unittests/parse-connection-spec-selftests.c: Fix common/
11709         includes.
11710         * unittests/optional-selftests.c: Fix common/ includes.
11711         * unittests/offset-type-selftests.c: Fix common/ includes.
11712         * unittests/observable-selftests.c: Fix common/ includes.
11713         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11714         * unittests/memrange-selftests.c: Fix common/ includes.
11715         * unittests/memory-map-selftests.c: Fix common/ includes.
11716         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11717         * unittests/function-view-selftests.c: Fix common/ includes.
11718         * unittests/environ-selftests.c: Fix common/ includes.
11719         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11720         * unittests/common-utils-selftests.c: Fix common/ includes.
11721         * unittests/cli-utils-selftests.c: Fix common/ includes.
11722         * unittests/array-view-selftests.c: Fix common/ includes.
11723         * ui-file.c: Fix common/ includes.
11724         * tui/tui-io.c: Fix common/ includes.
11725         * tracepoint.h: Fix common/ includes.
11726         * tracepoint.c: Fix common/ includes.
11727         * tracefile-tfile.c: Fix common/ includes.
11728         * top.h: Fix common/ includes.
11729         * top.c: Fix common/ includes.
11730         * thread.c: Fix common/ includes.
11731         * target/waitstatus.h: Fix common/ includes.
11732         * target/waitstatus.c: Fix common/ includes.
11733         * target.h: Fix common/ includes.
11734         * target.c: Fix common/ includes.
11735         * target-memory.c: Fix common/ includes.
11736         * target-descriptions.c: Fix common/ includes.
11737         * symtab.h: Fix common/ includes.
11738         * symfile.c: Fix common/ includes.
11739         * stap-probe.c: Fix common/ includes.
11740         * spu-linux-nat.c: Fix common/ includes.
11741         * sparc-nat.c: Fix common/ includes.
11742         * source.c: Fix common/ includes.
11743         * solib.c: Fix common/ includes.
11744         * solib-target.c: Fix common/ includes.
11745         * ser-unix.c: Fix common/ includes.
11746         * ser-tcp.c: Fix common/ includes.
11747         * ser-pipe.c: Fix common/ includes.
11748         * ser-base.c: Fix common/ includes.
11749         * selftest-arch.c: Fix common/ includes.
11750         * s12z-tdep.c: Fix common/ includes.
11751         * rust-exp.y: Fix common/ includes.
11752         * rs6000-aix-tdep.c: Fix common/ includes.
11753         * riscv-tdep.c: Fix common/ includes.
11754         * remote.c: Fix common/ includes.
11755         * remote-notif.h: Fix common/ includes.
11756         * remote-fileio.h: Fix common/ includes.
11757         * remote-fileio.c: Fix common/ includes.
11758         * regcache.h: Fix common/ includes.
11759         * regcache.c: Fix common/ includes.
11760         * record-btrace.c: Fix common/ includes.
11761         * python/python.c: Fix common/ includes.
11762         * python/py-type.c: Fix common/ includes.
11763         * python/py-inferior.c: Fix common/ includes.
11764         * progspace.h: Fix common/ includes.
11765         * producer.c: Fix common/ includes.
11766         * procfs.c: Fix common/ includes.
11767         * proc-api.c: Fix common/ includes.
11768         * printcmd.c: Fix common/ includes.
11769         * ppc-linux-nat.c: Fix common/ includes.
11770         * parser-defs.h: Fix common/ includes.
11771         * osdata.c: Fix common/ includes.
11772         * obsd-nat.c: Fix common/ includes.
11773         * nat/x86-linux.c: Fix common/ includes.
11774         * nat/x86-linux-dregs.c: Fix common/ includes.
11775         * nat/x86-dregs.h: Fix common/ includes.
11776         * nat/x86-dregs.c: Fix common/ includes.
11777         * nat/ppc-linux.c: Fix common/ includes.
11778         * nat/mips-linux-watch.h: Fix common/ includes.
11779         * nat/mips-linux-watch.c: Fix common/ includes.
11780         * nat/linux-waitpid.c: Fix common/ includes.
11781         * nat/linux-ptrace.h: Fix common/ includes.
11782         * nat/linux-ptrace.c: Fix common/ includes.
11783         * nat/linux-procfs.c: Fix common/ includes.
11784         * nat/linux-personality.c: Fix common/ includes.
11785         * nat/linux-osdata.c: Fix common/ includes.
11786         * nat/linux-namespaces.c: Fix common/ includes.
11787         * nat/linux-btrace.h: Fix common/ includes.
11788         * nat/linux-btrace.c: Fix common/ includes.
11789         * nat/fork-inferior.c: Fix common/ includes.
11790         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11791         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11792         * nat/aarch64-linux.c: Fix common/ includes.
11793         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11794         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11795         * namespace.h: Fix common/ includes.
11796         * mips-linux-tdep.c: Fix common/ includes.
11797         * minsyms.c: Fix common/ includes.
11798         * mi/mi-parse.h: Fix common/ includes.
11799         * mi/mi-main.c: Fix common/ includes.
11800         * mi/mi-cmd-env.c: Fix common/ includes.
11801         * memrange.h: Fix common/ includes.
11802         * memattr.c: Fix common/ includes.
11803         * maint.h: Fix common/ includes.
11804         * maint.c: Fix common/ includes.
11805         * main.c: Fix common/ includes.
11806         * machoread.c: Fix common/ includes.
11807         * location.c: Fix common/ includes.
11808         * linux-thread-db.c: Fix common/ includes.
11809         * linux-nat.c: Fix common/ includes.
11810         * linux-fork.c: Fix common/ includes.
11811         * inline-frame.c: Fix common/ includes.
11812         * infrun.c: Fix common/ includes.
11813         * inflow.c: Fix common/ includes.
11814         * inferior.h: Fix common/ includes.
11815         * inferior.c: Fix common/ includes.
11816         * infcmd.c: Fix common/ includes.
11817         * inf-ptrace.c: Fix common/ includes.
11818         * inf-child.c: Fix common/ includes.
11819         * ia64-linux-nat.c: Fix common/ includes.
11820         * i387-tdep.c: Fix common/ includes.
11821         * i386-tdep.c: Fix common/ includes.
11822         * i386-linux-tdep.c: Fix common/ includes.
11823         * i386-linux-nat.c: Fix common/ includes.
11824         * i386-go32-tdep.c: Fix common/ includes.
11825         * i386-fbsd-tdep.c: Fix common/ includes.
11826         * i386-fbsd-nat.c: Fix common/ includes.
11827         * guile/scm-type.c: Fix common/ includes.
11828         * guile/guile.c: Fix common/ includes.
11829         * go32-nat.c: Fix common/ includes.
11830         * gnu-nat.c: Fix common/ includes.
11831         * gdbthread.h: Fix common/ includes.
11832         * gdbarch-selftests.c: Fix common/ includes.
11833         * gdb_usleep.c: Fix common/ includes.
11834         * gdb_select.h: Fix common/ includes.
11835         * gdb_bfd.c: Fix common/ includes.
11836         * gcore.c: Fix common/ includes.
11837         * fork-child.c: Fix common/ includes.
11838         * findvar.c: Fix common/ includes.
11839         * fbsd-nat.c: Fix common/ includes.
11840         * event-top.c: Fix common/ includes.
11841         * event-loop.c: Fix common/ includes.
11842         * dwarf2read.c: Fix common/ includes.
11843         * dwarf2loc.c: Fix common/ includes.
11844         * dwarf2-frame.c: Fix common/ includes.
11845         * dwarf-index-cache.c: Fix common/ includes.
11846         * dtrace-probe.c: Fix common/ includes.
11847         * disasm-selftests.c: Fix common/ includes.
11848         * defs.h: Fix common/ includes.
11849         * csky-tdep.c: Fix common/ includes.
11850         * cp-valprint.c: Fix common/ includes.
11851         * cp-support.h: Fix common/ includes.
11852         * cp-support.c: Fix common/ includes.
11853         * corelow.c: Fix common/ includes.
11854         * completer.h: Fix common/ includes.
11855         * completer.c: Fix common/ includes.
11856         * compile/compile.c: Fix common/ includes.
11857         * compile/compile-loc2c.c: Fix common/ includes.
11858         * compile/compile-cplus-types.c: Fix common/ includes.
11859         * compile/compile-cplus-symbols.c: Fix common/ includes.
11860         * command.h: Fix common/ includes.
11861         * cli/cli-dump.c: Fix common/ includes.
11862         * cli/cli-cmds.c: Fix common/ includes.
11863         * charset.c: Fix common/ includes.
11864         * build-id.c: Fix common/ includes.
11865         * btrace.h: Fix common/ includes.
11866         * btrace.c: Fix common/ includes.
11867         * breakpoint.h: Fix common/ includes.
11868         * breakpoint.c: Fix common/ includes.
11869         * ax.h:
11870         (enum agent_op): Fix common/ includes.
11871         * ax-general.c (struct aop_map): Fix common/ includes.
11872         * ax-gdb.c: Fix common/ includes.
11873         * auxv.c: Fix common/ includes.
11874         * auto-load.c: Fix common/ includes.
11875         * arm-tdep.c: Fix common/ includes.
11876         * arch/riscv.c: Fix common/ includes.
11877         * arch/ppc-linux-common.c: Fix common/ includes.
11878         * arch/i386.c: Fix common/ includes.
11879         * arch/arm.c: Fix common/ includes.
11880         * arch/arm-linux.c: Fix common/ includes.
11881         * arch/arm-get-next-pcs.c: Fix common/ includes.
11882         * arch/amd64.c: Fix common/ includes.
11883         * arch/aarch64.c: Fix common/ includes.
11884         * arch/aarch64-insn.c: Fix common/ includes.
11885         * arch-utils.c: Fix common/ includes.
11886         * amd64-windows-tdep.c: Fix common/ includes.
11887         * amd64-tdep.c: Fix common/ includes.
11888         * amd64-sol2-tdep.c: Fix common/ includes.
11889         * amd64-obsd-tdep.c: Fix common/ includes.
11890         * amd64-nbsd-tdep.c: Fix common/ includes.
11891         * amd64-linux-tdep.c: Fix common/ includes.
11892         * amd64-linux-nat.c: Fix common/ includes.
11893         * amd64-fbsd-tdep.c: Fix common/ includes.
11894         * amd64-fbsd-nat.c: Fix common/ includes.
11895         * amd64-dicos-tdep.c: Fix common/ includes.
11896         * amd64-darwin-tdep.c: Fix common/ includes.
11897         * agent.c: Fix common/ includes.
11898         * ada-lang.h: Fix common/ includes.
11899         * ada-lang.c: Fix common/ includes.
11900         * aarch64-tdep.c: Fix common/ includes.
11901
11902 2019-01-25  Tom Tromey  <tom@tromey.com>
11903
11904         * common/create-version.sh: Use common/version.h.
11905
11906 2019-01-24  Pedro Alves  <palves@redhat.com>
11907
11908         * infrun.c (signal_stop, signal_print, signal_program)
11909         (signal_catch, signal_pass): Now arrays instead of pointers.
11910         (update_signals_program_target, do_target_resume)
11911         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11912         * linux-nat.c (linux_nat_target::pass_signals)
11913         (linux_nat_target::create_inferior, linux_nat_target::attach):
11914         Adjust.
11915         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11916         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11917         * procfs.c (procfs_target::pass_signals): Adjust.
11918         * record-full.c (record_full_target::resume): Adjust.
11919         * remote.c (remote_target::pass_signals)
11920         (remote_target::program_signals): Adjust.
11921         * target-debug.h (target_debug_print_signals): Now takes a
11922         gdb::array_view as parameter.  Adjust.
11923         * target.h (target_ops) <pass_signals, program_signals>: Replace
11924         pointer and length parameters with gdb::array_view.
11925         (target_pass_signals, target_program_signals): Likewise.
11926         * target-delegates.c: Regenerate.
11927
11928 2019-01-24  Pedro Alves  <palves@redhat.com>
11929
11930         * common/forward-scope-exit.h
11931         (forward_scope_exit::forward_scope_exit): Pass arguments to
11932         m_bind_function directly, instead of creating a std::bind and
11933         copying that.
11934
11935 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11936
11937         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11938         for static members.
11939         (pass_in_v_vfp_candidate): Likewise.
11940
11941 2019-01-23  Tom Tromey  <tom@tromey.com>
11942             Pedro Alves  <palves@redhat.com>
11943
11944         * regcache.c (class regcache_invalidator): Remove.
11945         (regcache::raw_write): Use make_scope_exit.
11946
11947 2019-01-23  Tom Tromey  <tom@tromey.com>
11948
11949         * ui-out.h (class ui_out_emit_type): Update comment.
11950
11951 2019-01-23  Tom Tromey  <tom@tromey.com>
11952
11953         * infrun.c (fetch_inferior_event): Update comment.
11954
11955 2019-01-23  Tom Tromey  <tom@tromey.com>
11956             Pedro Alves  <palves@redhat.com>
11957
11958         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11959         parameter.
11960         (fetch_inferior_event): Use SCOPE_EXIT.
11961
11962
11963 2019-01-23  Tom Tromey  <tom@tromey.com>
11964             Pedro Alves  <palves@redhat.com>
11965
11966         * infrun.c (disable_thread_events): Delete.
11967         (stop_all_threads): Use SCOPE_EXIT.
11968
11969 2019-01-23  Tom Tromey  <tom@tromey.com>
11970             Pedro Alves  <palves@redhat.com>
11971
11972         * symfile.c: Include forward-scope-exit.h.
11973         (clear_symtab_users_cleanup): Replace forward declaration with
11974         a FORWARD_SCOPE_EXIT.
11975         (syms_from_objfile_1): Use the forward_scope_exit and
11976         gdb::optional instead of cleanup_function.
11977         (reread_symbols): Use the forward_scope_exit instead of
11978         cleanup_function.
11979         (clear_symtab_users_cleanup): Remove function.
11980
11981 2019-01-23  Tom Tromey  <tom@tromey.com>
11982             Pedro Alves  <palves@redhat.com>
11983
11984         * linux-nat.c: Include scope-exit.h.
11985         (cleanup_target_stop): Remove.
11986         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11987         SCOPE_EXIT.
11988
11989 2019-01-23  Tom Tromey  <tom@tromey.com>
11990             Pedro Alves  <palves@redhat.com>
11991
11992         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11993         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11994
11995 2019-01-23  Tom Tromey  <tom@tromey.com>
11996             Andrew Burgess  <andrew.burgess@embecosm.com>
11997             Pedro Alves  <palves@redhat.com>
11998
11999         * infrun.c (fetch_inferior_event): Use scope_exit.
12000         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12001         * top.c (execute_command): Use scope_exit.
12002         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12003         * utils.c (do_bpstat_clear_actions_cleanup)
12004         (make_bpstat_clear_actions_cleanup): Remove.
12005
12006 2019-01-23  Tom Tromey  <tom@tromey.com>
12007             Pedro Alves  <palves@redhat.com>
12008
12009         * infrun.c: Include "common/scope-exit.h"
12010         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12011         (wait_for_inferior): Use SCOPE_EXIT.
12012         (fetch_inferior_event): Use scope_exit.
12013
12014 2019-01-23  Tom Tromey  <tom@tromey.com>
12015             Pedro Alves  <palves@redhat.com>
12016
12017         * breakpoint.c (create_breakpoint): Remove cleanup.
12018
12019 2019-01-23  Tom Tromey  <tom@tromey.com>
12020             Andrew Burgess  <andrew.burgess@embecosm.com>
12021             Pedro Alves  <palves@redhat.com>
12022
12023 2019-01-23  Pedro Alves  <palves@redhat.com>
12024
12025         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12026
12027 2019-01-23  Pedro Alves  <palves@redhat.com>
12028             Andrew Burgess  <andrew.burgess@embecosm.com>
12029
12030         * gdbthread.h: Include "common/forward-scope-exit.h".
12031         (scoped_finish_thread_state): Redefine custom class in terms of
12032         forward_scope_exit.
12033
12034 2019-01-23  Pedro Alves  <palves@redhat.com>
12035             Andrew Burgess  <andrew.burgess@embecosm.com>
12036
12037         * common/forward-scope-exit.h: New file.
12038
12039 2019-01-23  Pedro Alves  <palves@redhat.com>
12040             Andrew Burgess  <andrew.burgess@embecosm.com>
12041             Tom Tromey  <tom@tromey.com>
12042
12043         * common/scope-exit.h: New file.
12044
12045 2019-01-23  Pedro Alves  <palves@redhat.com>
12046
12047         * common/preprocessor.h (ESC): Rename to ...
12048         (ESC_PARENS): ... this.
12049         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12050         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12051
12052 2019-01-23  Tom Tromey  <tom@tromey.com>
12053
12054         * language.h (class scoped_switch_to_sym_language_if_auto):
12055         Initialize m_lang in both cases.
12056
12057 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12058
12059         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12060         with XCNEW.
12061
12062 2019-01-22  Tom Tromey  <tom@tromey.com>
12063
12064         * corelow.c: Do not include sys/file.h.
12065
12066 2019-01-22  Tom Tromey  <tom@tromey.com>
12067
12068         * tui/tui-wingeneral.h: Include gdb_curses.h.
12069
12070 2019-01-22  Tom Tromey  <tom@tromey.com>
12071
12072         * source-cache.h (class source_cache) <get_source_lines,
12073         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12074
12075 2019-01-22  Tom Tromey  <tom@tromey.com>
12076
12077         * remote-fileio.h (struct remote_target): Declare.
12078
12079 2019-01-22  Tom Tromey  <tom@tromey.com>
12080
12081         * python/py-arch.c: Do not include py-ref.h.
12082         * python/py-bpevent.c: Do not include py-ref.h.
12083         * python/py-cmd.c: Do not include py-ref.h.
12084         * python/py-continueevent.c: Do not include py-ref.h.
12085         * python/py-event.h: Do not include py-ref.h.
12086         * python/py-evtregistry.c: Do not include py-ref.h.
12087         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12088         * python/py-frame.c: Do not include py-ref.h.
12089         * python/py-framefilter.c: Do not include py-ref.h.
12090         * python/py-function.c: Do not include py-ref.h.
12091         * python/py-infevents.c: Do not include py-ref.h.
12092         * python/py-linetable.c: Do not include py-ref.h.
12093         * python/py-objfile.c: Do not include py-ref.h.
12094         * python/py-param.c: Do not include py-ref.h.
12095         * python/py-prettyprint.c: Do not include py-ref.h.
12096         * python/py-progspace.c: Do not include py-ref.h.
12097         * python/py-symbol.c: Do not include py-ref.h.
12098         * python/py-symtab.c: Do not include py-ref.h.
12099         * python/py-type.c: Do not include py-ref.h.
12100         * python/py-unwind.c: Do not include py-ref.h.
12101         * python/py-utils.c: Do not include py-ref.h.
12102         * python/py-value.c: Do not include py-ref.h.
12103         * python/py-varobj.c: Do not include py-ref.h.
12104         * python/py-xmethods.c: Do not include py-ref.h.
12105         * python/python.c: Do not include py-ref.h.
12106         * varobj.c: Do not include py-ref.h.
12107
12108 2019-01-22  Tom Tromey  <tom@tromey.com>
12109
12110         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12111         keyword for bcache.
12112
12113 2019-01-22  Tom Tromey  <tom@tromey.com>
12114
12115         * compile/compile-cplus-types.c: Remove a comment by #include.
12116
12117 2019-01-22  Tom Tromey  <tom@tromey.com>
12118
12119         * compile/gcc-c-plugin.h: Include compile-internal.h.
12120
12121 2019-01-22  Tom Tromey  <tom@tromey.com>
12122
12123         * stabsread.c (EXTERN): Do not define.
12124         (symnum, next_symbol_text_func, processing_gcc_compilation)
12125         (within_function, global_sym_chain, global_stabs)
12126         (previous_stab_code, this_object_header_files)
12127         (n_this_object_header_files)
12128         (n_allocated_this_object_header_files): Define.
12129         * stabsread.h (EXTERN): Never define.  Use "extern".
12130
12131 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12132
12133         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12134         history_value.
12135
12136 2019-01-21  Tom Tromey  <tom@tromey.com>
12137
12138         * ui-out.c: Fix includes.
12139         * tui/tui-source.c: Fix includes.
12140         * target.c: Fix includes.
12141         * remote.c: Fix includes.
12142         * regcache.c: Fix includes.
12143         * python/py-block.c: Fix includes.
12144         * printcmd.c: Fix includes.
12145         * or1k-tdep.c: Fix includes.
12146         * mi/mi-main.c: Fix includes.
12147         * m32r-tdep.c: Fix includes.
12148         * csky-tdep.c: Fix includes.
12149         * compile/compile-cplus-types.c: Fix includes.
12150         * cli/cli-interp.c: Fix includes.
12151
12152 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12153
12154         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12155         for padding.
12156
12157 2019-01-16  Tom Tromey  <tom@tromey.com>
12158
12159         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12160         earlier.
12161         (struct objfile) <msymbols_range>: Move from top level.
12162         <msymbols>: New method.
12163         (class objfile_msymbols): Remove.
12164         * symtab.c (default_collect_symbol_completion_matches_break_on):
12165         Update.
12166         * symmisc.c (dump_msymbols): Update.
12167         * stabsread.c (scan_file_globals): Update.
12168         * objc-lang.c (info_selectors_command, info_classes_command)
12169         (find_methods): Update.
12170         * minsyms.c (find_solib_trampoline_target): Update.
12171         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12172         * coffread.c (coff_symfile_read): Update.
12173         * ada-lang.c (ada_lookup_simple_minsym)
12174         (ada_collect_symbol_completion_matches): Update.
12175
12176 2019-01-16  Tom Tromey  <tom@tromey.com>
12177
12178         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12179         type.  Remove no-argument constructor.
12180         <iterator::operator++>: Simplify.
12181         <begin>: Update.
12182         <end>: Use minimal_symbol_count.
12183
12184 2019-01-16  Tom Tromey  <tom@tromey.com>
12185
12186         * objfiles.h (struct objfile) <psymtabs>: New method.
12187         (class objfile_psymtabs): Remove.
12188         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12189         typedef.
12190         <range>: New method.
12191         (require_partial_symbols): Change return type.
12192         * psymtab.c (require_partial_symbols)
12193         (psym_expand_symtabs_matching): Update.
12194         * mdebugread.c (parse_partial_symbols): Update.
12195         * dbxread.c (dbx_end_psymtab): Update.
12196
12197 2019-01-15  Tom Tromey  <tom@tromey.com>
12198
12199         * symtab.c (lookup_objfile_from_block)
12200         (lookup_symbol_in_objfile_symtabs)
12201         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12202         (find_line_symtab, info_sources_command)
12203         (default_collect_symbol_completion_matches_break_on)
12204         (make_source_files_completion_list): Update.
12205         * symmisc.c (print_objfile_statistics, dump_objfile)
12206         (maintenance_print_symbols, maintenance_info_symtabs)
12207         (maintenance_check_symtabs, maintenance_info_line_tables):
12208         Update.
12209         * source.c (select_source_symtab)
12210         (forget_cached_source_info_for_objfile): Update.
12211         * objfiles.h (class objfile_compunits): Remove.
12212         (struct objfile) <compunits_range>: New typedef.
12213         (compunits): New method.
12214         * objfiles.c (objfile_relocate1): Update.
12215         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12216         * maint.c (count_symtabs_and_blocks): Update.
12217         * linespec.c (iterate_over_all_matching_symtabs): Update.
12218         * cp-support.c (add_symbol_overload_list_qualified): Update.
12219         * coffread.c (coff_symtab_read): Update.
12220         * ada-lang.c (add_nonlocal_symbols)
12221         (ada_collect_symbol_completion_matches)
12222         (ada_add_global_exceptions): Update.
12223
12224 2019-01-15  Tom Tromey  <tom@tromey.com>
12225
12226         * progspace.h (program_space) <objfiles_safe_range>: New
12227         typedef.
12228         <objfiles_safe>: New method.
12229         * objfiles.h (class all_objfiles_safe): Remove.
12230         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12231         * jit.c (jit_inferior_exit_hook): Update.
12232
12233 2019-01-17  Tom Tromey  <tom@tromey.com>
12234
12235         * progspace.h (program_space) <objfiles_range>: New typedef.
12236         <objfiles>: New method.
12237         <objfiles_head>: Rename from objfiles.
12238         (object_files): Update.
12239         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12240         * guile/scm-pretty-print.c
12241         (ppscm_find_pretty_printer_from_objfiles): Update.
12242         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12243         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12244         Update.
12245         * python/py-progspace.c (pspy_get_objfiles): Update.
12246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12247         Update.
12248         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12249         (objfpy_lookup_objfile_by_build_id): Update.
12250         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12251         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12252         Update.
12253         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12254         (expand_symtab_containing_pc, lookup_objfile_from_block)
12255         (lookup_static_symbol, basic_lookup_transparent_type)
12256         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12257         (find_line_symtab, info_sources_command)
12258         (default_collect_symbol_completion_matches_break_on)
12259         (make_source_files_completion_list, find_main_name): Update.
12260         * symmisc.c (print_symbol_bcache_statistics)
12261         (print_objfile_statistics, maintenance_print_symbols)
12262         (maintenance_print_msymbols, maintenance_print_objfiles)
12263         (maintenance_info_symtabs, maintenance_check_symtabs)
12264         (maintenance_expand_symtabs, maintenance_info_line_tables):
12265         Update.
12266         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12267         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12268         (map_overlay_command, unmap_overlay_command)
12269         (simple_overlay_update, expand_symtabs_matching)
12270         (map_symbol_filenames): Update.
12271         * symfile-debug.c (set_debug_symfile): Update.
12272         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12273         Update.
12274         * source.c (select_source_symtab, forget_cached_source_info):
12275         Update.
12276         * solib.c (solib_read_symbols): Update.
12277         * solib-spu.c (append_ocl_sos): Update.
12278         * psymtab.c (maintenance_print_psymbols)
12279         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12280         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12281         * printcmd.c (info_symbol_command): Update.
12282         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12283         Update.
12284         * objfiles.h (class all_objfiles): Remove.
12285         * objfiles.c (have_partial_symbols, have_full_symbols)
12286         (have_minimal_symbols, qsort_cmp, update_section_map)
12287         (shared_objfile_contains_address_p)
12288         (default_iterate_over_objfiles_in_search_order): Update.
12289         * objc-lang.c (info_selectors_command, info_classes_command)
12290         (find_methods): Update.
12291         * minsyms.c (find_solib_trampoline_target): Update.
12292         * maint.c (maintenance_info_sections)
12293         (maintenance_translate_address, count_symtabs_and_blocks):
12294         Update.
12295         * main.c (captured_main_1): Update.
12296         * linux-thread-db.c (try_thread_db_load_from_pdir)
12297         (has_libpthread): Update.
12298         * linespec.c (iterate_over_all_matching_symtabs)
12299         (search_minsyms_for_name): Update.
12300         * jit.c (jit_find_objf_with_entry_addr): Update.
12301         * hppa-tdep.c (find_unwind_entry)
12302         (hppa_lookup_stub_minimal_symbol): Update.
12303         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12304         Update.
12305         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12306         (elf_gnu_ifunc_resolve_by_got): Update.
12307         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12308         * dwarf-index-write.c (save_gdb_index_command): Update.
12309         * cp-support.c (add_symbol_overload_list_qualified): Update.
12310         * breakpoint.c (create_overlay_event_breakpoint)
12311         (create_longjmp_master_breakpoint)
12312         (create_std_terminate_master_breakpoint)
12313         (create_exception_master_breakpoint): Update.
12314         * blockframe.c (find_pc_partial_function): Update.
12315         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12316         (ada_collect_symbol_completion_matches)
12317         (ada_add_global_exceptions): Update.
12318
12319 2019-01-17  Tom Tromey  <tom@tromey.com>
12320
12321         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12322         declare VEC.
12323         (solib_target_parse_libraries): Change return type.
12324         (library_list_start_segment, library_list_start_section)
12325         (library_list_end_library, library_list_start_library); Update.
12326         (solib_target_free_library_list): Remove.
12327         (solib_target_parse_libraries): Remove cleanup.  Change return
12328         type.
12329         (solib_target_current_sos): Update.
12330
12331 2019-01-17  Tom Tromey  <tromey@bapiya>
12332
12333         * valprint.c: Replace "the the" with "the".
12334         * symtab.c: Replace "the the" with "the".
12335         * solib.c: Replace "the the" with "the".
12336         * solib-dsbt.c: Replace "the the" with "the".
12337         * linespec.c: Replace "the the" with "the".
12338         * dwarf2loc.h: Replace "the the" with "the".
12339         * amd64-windows-tdep.c: Replace "the the" with "the".
12340         * aarch64-tdep.c: Replace "the the" with "the".
12341
12342 2019-01-16  Keith Seitz  <keiths@redhat.com>
12343
12344         PR gdb/23773
12345         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12346         <builder>: Rename to ..
12347         <m_builder>: ... this and make private.
12348         (dwarf2_cu::get_builder): New method.  Change all users of
12349         `builder' to use this method.
12350         (dwarf2_start_symtab): Move to ...
12351         (dwarf2_cu::start_symtab): ... here.  Update all callers
12352         (setup_type_unit_groups): Move to ...
12353         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12354         callers.
12355         (dwarf2_cu::reset_builder): New method.
12356         (process_full_compunit, process_full_type_unit): Use
12357         dwarf2_cu::reset_builder.
12358         (follow_die_offset): Record the ancestor CU if it is different
12359         from the followed DIE's CU.
12360         (follow_die_sig_1): Likewise.
12361
12362 2019-01-15  Tom Tromey  <tom@tromey.com>
12363
12364         * remote.c (class remote_state) <buf>: Now a char_vector.
12365         <buf_size>: Remove.
12366         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12367         parameter.
12368         (remote_target::getpkt_or_notif_sane_1)
12369         (remote_target::getpkt_sane)
12370         (remote_target::getpkt_or_notif_sane): Likewise.
12371         (class remote_target) <putpkt>: New overload.
12372         (remote_target::read_frame): Change type of "buf_p".  Remove
12373         sizeof_p parameter.
12374         (packet_ok): New overload.
12375         (packet_check_result): New overload.
12376         Update all uses.
12377
12378 2019-01-14  Tom Tromey  <tom@tromey.com>
12379
12380         * remote-notif.c (handle_notification, remote_notif_ack)
12381         (remote_notif_parse): Make "buf" const.
12382         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12383         const.
12384         (remote_notif_parse, remote_notif_ack, handle_notification):
12385         Likewise.
12386         * remote.c (remote_notif_stop_parse): Make "buf" const.
12387         (remote_target::remote_parse_stop_reply): Make "buf" const.
12388         (remote_notif_stop_ack): Make "buf" const.
12389
12390 2019-01-14  Tom Tromey  <tom@tromey.com>
12391
12392         * remote.c (remote_console_output): Make parameter const.
12393
12394 2019-01-14  Tom Tromey  <tom@tromey.com>
12395
12396         * target-debug.h (target_debug_print_signals): Constify.
12397         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12398         * procfs.c (procfs_target::pass_signals): Update.
12399         * linux-nat.c (linux_nat_target::pass_signals): Update.
12400         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12401         * target-delegates.c: Rebuild.
12402         * remote.c (remote_target::program_signals): Update.
12403         (remote_target::pass_signals): Update.
12404         * target.c (target_pass_signals): Constify argument.
12405         (target_program_signals): Likewise.
12406         * target.h (struct target_ops) <pass_signals, program_signals>:
12407         Constify argument.
12408         (target_pass_signals, target_program_signals): Constify argument.
12409
12410 2019-01-14  Tom Tromey  <tom@tromey.com>
12411
12412         PR tui/28819:
12413         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12414
12415 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12416
12417         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12418         field.
12419         * rs6000-tdep.c: Include reggroups.h.
12420         (IS_V_ALIAS_PSEUDOREG): Define.
12421         (rs6000_register_name): Return names for the "vX" aliases.
12422         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12423         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12424         aliases.  Call default_register_reggroup_p for all other
12425         pseudo-registers.
12426         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12427         New functions.
12428         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12429         Handle "vX" aliases.
12430         (v_alias_pseudo_register_collect): New function.
12431         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12432         (rs6000_gdbarch_init): Initialize "vX" aliases as
12433         pseudo-registers.  Restore registration of
12434         rs6000_pseudo_register_reggroup_p with
12435         set_tdesc_pseudo_register_reggroup_p.
12436
12437 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12438
12439         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12440         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12441         set_gdbarch_num_pseudo_regs.
12442
12443 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12444
12445         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12446         Remove arg prefixname, add do_set and do_show.
12447         Add member functions set_list and show_list.
12448         * cli/cli-style.c (class cli_style_option): Update accordingly.
12449         (style_set_list): Move to file scope.
12450         (style_show_list): Likewise.
12451         (set_style): Call help_list.
12452         (show_style): Call cmd_show_list.
12453         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12454         Update to use the new macro.
12455
12456 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12457
12458         * ada-lang.c (_initialize_ada_language): Expand the help text
12459         for the "catch exception" command.
12460
12461 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12462
12463         * symtab.c (matching_obj_sections): Initialize obj,
12464         declare it closer to its usage.
12465
12466 2019-01-10  Tom Tromey  <tom@tromey.com>
12467
12468         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12469         (basic_inf_threads_range): Remove.
12470         (inf_threads_range, inf_non_exited_threads_range)
12471         (safe_inf_threads_range): Use next_adapter.
12472
12473 2019-01-10  Keith Seitz  <keiths@redhat.com>
12474
12475         PR gdb/23712
12476         PR symtab/23010
12477         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12478         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12479
12480 2019-01-10  Keith Seitz  <keiths@redhat.com>
12481
12482         PR gdb/23712
12483         PR symtab/23010
12484         * dictionary.c (pending_to_vector): Remove.
12485         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12486         Remove _1 suffix, replacing functions of the same name.  Update
12487         all callers.
12488         (dict_create_hashed, dict_create_hashed_expandable)
12489         (dict_create_linear, dict_create_linear_expandable, dict_free)
12490         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12491         Make functions static.
12492
12493 2019-01-10  Keith Seitz  <keiths@redhat.com>
12494
12495         PR gdb/23712
12496         PR symtab/23010
12497         * dictionary.h (struct dictionary): Replace declaration with
12498         multidictionary.
12499         (dict_create_hashed, dict_create_hashed_expandable)
12500         (dict_create_linear, dict_create_linear_expandable)
12501         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12502         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12503         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12504         taking multidictionary argument.
12505         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12506         * block.h (struct block) <dict>: Change to multidictionary
12507         and rename `multidict'.
12508         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12509         symmisc.c: Update all dictionary references to multidictionary.
12510
12511 2019-01-10  Keith Seitz  <keiths@redhat.com>
12512
12513         PR gdb/23712
12514         PR symtab/23010
12515         * dictionary.c: Include unordered_map.
12516         (pending_to_vector): New function.
12517         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12518         Rewrite the non-"_1" functions to take vector instead
12519         of linked list.
12520         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12521         "new" _1 versions of the same name.
12522         (multidictionary): Define.
12523         (std::hash<enum language): New definition.
12524         (collate_pending_symbols_by_language, mdict_create_hashed)
12525         (mdict_create_hashed_expandable, mdict_create_linear)
12526         (mdict_create_linear_expandable, mdict_free)
12527         (find_language_dictionary, create_new_language_dictionary)
12528         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12529         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12530         (mdict_size, mdict_empty): New functions.
12531         * dictionary.h (mdict_iterator): Define.
12532
12533 2019-01-10  Pedro Alves  <palves@redhat.com>
12534
12535         * breakpoint.c (read_uploaded_action)
12536         (create_tracepoint_from_upload): Adjust to use
12537         gdb::unique_xmalloc_ptr.
12538         * ctf.c (ctf_write_uploaded_tp):
12539         (SET_ARRAY_FIELD): Use emplace_back.
12540         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12541         * tracefile-tfile.c (tfile_write_uploaded_tp):
12542         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12543         gdb::unique_xmalloc_ptr.
12544         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12545         at_string, cond_string, cmd_strings>: Replace char pointers
12546         with gdb::unique_xmalloc_ptr.
12547
12548 2019-01-10  Pedro Alves  <palves@redhat.com>
12549
12550         * solib-target.c (library_list_start_library): Don't xstrdup name.
12551
12552 2019-01-10  Pedro Alves  <palves@redhat.com>
12553
12554         * mdebugread.c (parse_partial_symbols): Use
12555         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12556
12557 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12558
12559         * linux-fork.c (scoped_switch_fork_info)
12560         <~scoped_switch_fork_info>: Fix incorrect variable name.
12561
12562 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12563
12564         * linux-fork.c (scoped_switch_fork_info)
12565         <scoped_switch_fork_info>: Make explicit.
12566         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12567
12568 2019-01-10  Tom Tromey  <tom@tromey.com>
12569
12570         * objfiles.h (objfile::reset_psymtabs): Update.
12571         * objfiles.c (objfile::objfile): Update.
12572         * psymtab.h (psymtab_storage::obstack): Update.
12573         (psymtab_storage::m_obstack): Use gdb::optional.
12574         (class psymtab_storage): Update comment.  Remove objfile
12575         parameter.
12576         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12577
12578 2019-01-10  Tom Tromey  <tom@tromey.com>
12579
12580         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12581         <free_psymtabs>: Now private.
12582         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12583         (allocate_psymtab): Use new method.
12584
12585 2019-01-10  Tom Tromey  <tom@tromey.com>
12586
12587         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12588         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12589         * mdebugread.c (parse_partial_symbols): Use
12590         allocate_dependencies.
12591         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12592         allocate_dependencies.
12593         (process_psymtab_comp_unit_reader)
12594         (build_type_psymtab_dependencies): Likewise.
12595         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12596
12597 2019-01-10  Tom Tromey  <tom@tromey.com>
12598
12599         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12600         PSYMBOL_SET_LANGUAGE.
12601         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12602
12603 2019-01-10  Tom Tromey  <tom@tromey.com>
12604
12605         * psymtab.h (psymtab_storage::obstack): New method.
12606         <m_obstack>: Rename from obstack; now private.
12607         * psymtab.c (psymtab_storage): Update.
12608         * dwarf2read.c (create_addrmap_from_index)
12609         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12610         Update.
12611
12612 2019-01-10  Tom Tromey  <tom@tromey.com>
12613
12614         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12615         * objfiles.h (objfile::reset_psymtabs): New method.
12616
12617 2019-01-10  Tom Tromey  <tom@tromey.com>
12618
12619         * symmisc.c (print_symbol_bcache_statistics): Update.
12620         (print_objfile_statistics): Update.
12621         * symfile.c (reread_symbols): Update.
12622         * psymtab.h (class psymtab_storage): New.
12623         * psymtab.c (psymtab_storage): New constructor.
12624         (~psymtab_storage): New destructor.
12625         (require_partial_symbols): Update.
12626         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12627         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12628         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12629         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12630         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12631         (start_psymtab_common, end_psymtab_common)
12632         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12633         (allocate_psymtab): Update.
12634         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12635         Update.
12636         (dump_psymtab_addrmap, maintenance_print_psymbols)
12637         (maintenance_check_psymtabs): Update.
12638         (class objfile_psymtabs): Move to objfiles.h.
12639         * psympriv.h (discard_psymtab): Now inline.
12640         (psymtab_discarder::psymtab_discarder): Update.
12641         (psymtab_discarder::~psymtab_discarder): Update.
12642         (ALL_OBJFILE_PSYMTABS): Rewrite.
12643         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12644         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12645         Remove fields.
12646         <partial_symtabs>: New field.
12647         (class objfile_psymtabs): Move from psymtab.h.  Update.
12648         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12649         psymbol_cache.
12650         (objfile::~objfile): Don't destroy psymbol_cache.
12651         * mdebugread.c (parse_partial_symbols): Update.
12652         * dwarf2read.c (create_addrmap_from_index)
12653         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12654         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12655         (add_partial_subprogram, dwarf2_ranges_read): Update.
12656         * dwarf-index-write.c (write_address_map)
12657         (write_one_signatured_type, recursively_write_psymbols)
12658         (class debug_names, class debug_names, write_psymtabs_to_index):
12659         Update.
12660
12661 2019-01-10  Tom Tromey  <tom@tromey.com>
12662
12663         * symtab.h (SYMBOL_SET_NAMES): Update.
12664         (symbol_set_names): Update.
12665         (MSYMBOL_SET_NAMES): Update.
12666         * symtab.c (symbol_set_names): Change argument to be an
12667         objfile_per_bfd_storage.
12668         * psymtab.c (add_psymbol_to_bcache): Update.
12669         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12670
12671 2019-01-10  Tom Tromey  <tom@tromey.com>
12672
12673         * symtab.c (create_demangled_names_hash): Change argument to be an
12674         objfile_per_bfd_storage.
12675         (symbol_set_names): Update.
12676
12677 2019-01-10  Tom Tromey  <tom@tromey.com>
12678
12679         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12680         init_psymbol_list.
12681         * psymtab.c (init_psymbol_list): Do nothing if already called.
12682         * psympriv.h (init_psymbol_list): Add comment.
12683         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12684         init_psymbol_list.
12685         * dbxread.c (dbx_symfile_read): Unconditionally call
12686         init_psymbol_list.
12687
12688 2019-01-10  Tom Tromey  <tom@tromey.com>
12689
12690         * xcoffread.c (scan_xcoff_symtab): Update.
12691         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12692         "where".
12693         * mdebugread.c (parse_partial_symbols)
12694         (handle_psymbol_enumerators): Update.
12695         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12696         * dbxread.c (read_dbx_symtab): Update.
12697         * psympriv.h (psymbol_placement): New enum.
12698         (add_psymbol_to_list): Update.
12699
12700 2019-01-10  Tom Tromey  <tom@tromey.com>
12701
12702         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12703         static_psymbols parameters.
12704         (scan_xcoff_symtab): Update.
12705         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12706         static_psymbols parameters.
12707         * psympriv.h (start_psymtab_common): Update.
12708         * mdebugread.c (parse_partial_symbols): Update.
12709         * dwarf2read.c (create_partial_symtab): Update.
12710         * dbxread.c (read_dbx_symtab): Update.
12711         (start_psymtab): Remove global_psymbols and static_psymbols
12712         parameters.
12713
12714 2019-01-10  Tom Tromey  <tom@tromey.com>
12715
12716         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12717         * psymtab.c (allocate_psymtab): Add comment.
12718         * psympriv.h (allocate_psymtab): Add comment.
12719         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12720         initializations.
12721         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12722
12723 2019-01-10  Tom Tromey  <tom@tromey.com>
12724
12725         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12726         Don't declare.
12727         * mipsread.c: Include mdebugread.h.
12728         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12729         Declare.
12730         * elfread.c: Include mdebugread.h.
12731
12732 2019-01-09  Tom Tromey  <tom@tromey.com>
12733
12734         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12735         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12736         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12737         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12738         (psym_lookup_symbol, psym_find_last_source_symtab)
12739         (psym_forget_cached_source_info, psym_print_stats)
12740         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12741         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12742         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12743         (psym_find_compunit_symtab_by_address)
12744         (maintenance_print_psymbols, maintenance_info_psymtabs)
12745         (maintenance_check_psymtabs): Use ranged for.
12746         * psymtab.h (class objfile_psymtabs): New.
12747         (require_partial_symbols): Return objfile_psymtabs.
12748         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12749
12750 2019-01-09  Tom Tromey  <tom@tromey.com>
12751
12752         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12753         (find_pc_mapped_section, list_overlays_command)
12754         (map_overlay_command, unmap_overlay_command)
12755         (simple_overlay_update): Use all_objfiles.
12756         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12757         * printcmd.c (info_symbol_command): Use all_objfiles.
12758         * objfiles.h (ALL_OBJSECTIONS): Remove.
12759         * maint.c (maintenance_translate_address): Use all_objfiles.
12760         * gcore.c (gcore_create_callback): Use all_objfiles.
12761         (objfile_find_memory_regions): Likewise.
12762
12763 2019-01-09  Tom Tromey  <tom@tromey.com>
12764
12765         * symtab.c (find_line_symtab, info_sources_command)
12766         (make_source_files_completion_list): Use objfile_compunits.
12767         * source.c (select_source_symtab): Use objfile_compunits.
12768         * objfiles.h (struct objfile): Update comment.
12769         (ALL_OBJFILES): Remove.
12770         (ALL_FILETABS): Remove.
12771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12772         objfile_compunits.
12773
12774 2019-01-09  Tom Tromey  <tom@tromey.com>
12775
12776         * symmisc.c (print_objfile_statistics, dump_objfile)
12777         (maintenance_print_symbols): Use compunit_filetabs.
12778         * source.c (forget_cached_source_info_for_objfile): Use
12779         compunit_filetabs.
12780         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12781         (ALL_FILETABS): Use compunit_filetabs.
12782         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12783         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12784
12785 2019-01-09  Tom Tromey  <tom@tromey.com>
12786
12787         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12788         (compunit_filetabs): New.
12789         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12790         compunit_filetabs.
12791         (info_sources_command, make_source_files_completion_list): Remove
12792         declaration.
12793         * symmisc.c (print_objfile_statistics, dump_objfile)
12794         (maintenance_print_symbols): Remove declaration.
12795         (maintenance_info_symtabs): Use compunit_filetabs.
12796         (maintenance_info_line_tables): Likewise.
12797         * source.c (select_source_symtab): Change local variable name.
12798         (forget_cached_source_info_for_objfile): Remove declaration.
12799         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12800         * objfiles.c (objfile_relocate1): Remove declaration.
12801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12802         declaration.
12803         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12804         * coffread.c (coff_symtab_read): Remove declaration.
12805         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12806         compunit_filetabs.
12807
12808 2019-01-09  Tom Tromey  <tom@tromey.com>
12809
12810         * symtab.c (lookup_objfile_from_block)
12811         (find_pc_sect_compunit_symtab, search_symbols)
12812         (default_collect_symbol_completion_matches_break_on): Use
12813         objfile_compunits.
12814         * objfiles.h (ALL_COMPUNITS): Remove.
12815         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12816         * cp-support.c (add_symbol_overload_list_qualified): Use
12817         objfile_compunits.
12818         * ada-lang.c (ada_collect_symbol_completion_matches)
12819         (ada_add_global_exceptions): Use objfile_compunits.
12820
12821 2019-01-09  Tom Tromey  <tom@tromey.com>
12822
12823         * source.c (select_source_symtab)
12824         (forget_cached_source_info_for_objfile): Remove declaration.
12825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12826         declaration.
12827         * maint.c (count_symtabs_and_blocks): Remove declaration.
12828         * cp-support.c (add_symbol_overload_list_qualified): Remove
12829         declaration.
12830         * coffread.c (coff_symtab_read): Remove declaration.
12831         * symtab.c (lookup_symbol_in_objfile_symtabs)
12832         (basic_lookup_transparent_type_1): Use objfile_compunits.
12833         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12834         (info_sources_command, search_symbols)
12835         (default_collect_symbol_completion_matches_break_on)
12836         (make_source_files_completion_list): Remove declaration.
12837         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12838         (ada_collect_symbol_completion_matches)
12839         (ada_add_global_exceptions): Remove declaration.
12840         * linespec.c (iterate_over_all_matching_symtabs): Use
12841         objfile_compunits.
12842         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12843         (class objfile_compunits): New.
12844         (ALL_COMPUNITS): Use objfile_compunits.
12845         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12846         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12847         objfile_compunits.
12848         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12849
12850 2019-01-09  Tom Tromey  <tom@tromey.com>
12851
12852         * symtab.c (search_symbols)
12853         (default_collect_symbol_completion_matches_break_on): Use
12854         objfile_msymbols.
12855         * ada-lang.c (ada_lookup_simple_minsym)
12856         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12857         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12858         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12859         objfile_msymbols.
12860         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12861         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12862         * objc-lang.c (find_methods): Use objfile_msymbols.
12863         (info_selectors_command, info_classes_command): Likewise.
12864         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12865         * objfiles.h (class objfile_msymbols): New.
12866         (ALL_OBJFILE_MSYMBOLS): Remove.
12867         (ALL_MSYMBOLS): Remove.
12868
12869 2019-01-09  Tom Tromey  <tom@tromey.com>
12870
12871         * common/next-iterator.h (next_adapter): Add Iterator template
12872         parameter.
12873         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12874         (class all_objfiles_safe): New.
12875         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12876         * objfiles.c (put_objfile_before): Update comment.
12877         (add_separate_debug_objfile): Likewise.
12878         (free_all_objfiles): Use all_objfiles_safe.
12879         (objfile_purge_solibs): Likewise.
12880
12881 2019-01-09  Tom Tromey  <tom@tromey.com>
12882
12883         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12884         (expand_symtab_containing_pc, lookup_static_symbol)
12885         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12886         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12887         all_objfiles.
12888         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12889         * breakpoint.c (create_overlay_event_breakpoint)
12890         (create_longjmp_master_breakpoint)
12891         (create_std_terminate_master_breakpoint)
12892         (create_exception_master_breakpoint): Use all_objfiles.
12893         * linux-thread-db.c (try_thread_db_load_from_pdir)
12894         (has_libpthread): Use all_objfiles.
12895         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12896         * linespec.c (iterate_over_all_matching_symtabs)
12897         (search_minsyms_for_name): Use all_objfiles.
12898         * maint.c (maintenance_info_sections): Use all_objfiles.
12899         * main.c (captured_main_1): Use all_objfiles.
12900         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12901         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12902         * guile/scm-pretty-print.c
12903         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12904         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12905         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12906         (maintenance_print_msymbols): Use all_objfiles.
12907         * source.c (select_source_symtab): Use all_objfiles.
12908         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12909         * symfile.c (remove_symbol_file_command)
12910         (expand_symtabs_matching, map_symbol_filenames): Use
12911         all_objfiles.
12912         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12913         all_objfiles.
12914         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12915         * objc-lang.c (find_methods): Use all_objfiles.
12916         * objfiles.c (have_partial_symbols, have_full_symbols)
12917         (have_minimal_symbols, qsort_cmp)
12918         (default_iterate_over_objfiles_in_search_order): Use
12919         all_objfiles.
12920         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12921         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12922         (maintenance_check_psymtabs): Use all_objfiles.
12923         (ALL_PSYMTABS): Remove.
12924         * compile/compile-object-run.c (do_module_cleanup): Use
12925         all_objfiles.
12926         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12927         * cp-support.c (add_symbol_overload_list_qualified): Use
12928         all_objfiles.
12929         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12930         Use all_objfiles.
12931         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12932         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12933         all_objfiles.
12934         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12935         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12936         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12937         Uses all_objfiles.
12938         * solib.c (solib_read_symbols): Use all_objfiles
12939
12940 2019-01-09  Tom Tromey  <tom@tromey.com>
12941
12942         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12943         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12944         all_objfiles.
12945         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12946         * symmisc.c (print_symbol_bcache_statistics)
12947         (print_objfile_statistics, maintenance_print_objfiles)
12948         (maintenance_info_symtabs, maintenance_check_symtabs)
12949         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12950         all_objfiles.
12951         * source.c (forget_cached_source_info): Use all_objfiles.
12952         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12953         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12954         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12955         * objfiles.c (update_section_map): Use all_objfiles.
12956         (shared_objfile_contains_address_p): Likewise.
12957         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12958         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12959
12960 2019-01-09  Tom Tromey  <tom@tromey.com>
12961
12962         * common/next-iterator.h: New file.
12963         * objfiles.h (class all_objfiles): New.
12964         (struct objfile_iterator): New.
12965
12966 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12967
12968         * NEWS: Move the description of the changed "frame", "select-frame",
12969          and "info frame" commands to the Changed commands section.
12970
12971 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12972
12973         * gdbtypes.c (check_stub_method_group): Remove handling of old
12974         mangling schemes.
12975         * linespec.c (find_methods): Likewise.
12976         * stabsread.c (read_member_functions): Likewise.
12977         * valops.c (search_struct_method): Likewise.
12978         (value_struct_elt_for_reference): Likewise.
12979         * NEWS: Mention this change.
12980
12981 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12982
12983         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12984         print_source_lines.
12985         * source.c (print_source_lines_base): Update line number check.
12986         (print_source_lines): New function.
12987         (source_lines_range::source_lines_range): New function.
12988         * source.h (class source_lines_range): New class.
12989         (print_source_lines): New declaration.
12990
12991 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12992
12993         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12994
12995 2019-01-08  Tom Tromey  <tom@tromey.com>
12996             Simon Marchi  <simon.marchi@ericsson.com>
12997
12998         PR gdb/24060
12999         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13000         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13001         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13002         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13003         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13004         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13005
13006 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13007
13008         * source.c (select_source_symtab): Move header comment to
13009         declaration in source.h.
13010         (forget_cached_source_info_for_objfile): Likewise.
13011         (forget_cached_source_info): Likewise.
13012         (identify_source_line): Likewise.
13013         * source.h (identify_source_line): Move declaration from symtab.h
13014         and add comment from source.c
13015         (print_source_lines): Likewise.
13016         (forget_cached_source_info_for_objfile): Likewise.
13017         (forget_cached_source_info): Likewise.
13018         (select_source_symtab): Likewise.
13019         (enum print_source_lines_flag): Move definition from symtab.h.
13020         * symtab.h (identify_source_line): Move declaration to source.h.
13021         (print_source_lines): Likewise.
13022         (forget_cached_source_info_for_objfile): Likewise.
13023         (forget_cached_source_info): Likewise.
13024         (select_source_symtab): Likewise.
13025         (enum print_source_lines_flag): Move definition to source.h.
13026         * tui/tui-hooks.c: Add 'source.h' include.
13027
13028 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13029
13030         * source.c (print_source_lines_base): Handle requests to print
13031         reverse line number sequences, and guard against empty lines
13032         string.
13033
13034 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13035
13036         * source.c (print_source_lines_base): Fix skip of '\r' if next
13037         character is '\n'.
13038
13039 2019-01-06  Tom Tromey  <tom@tromey.com>
13040
13041         * c-exp.y (struct c_parse_state) <macro_original_text,
13042         expansion_obstack>: New member.
13043         (macro_original_text, expansion_obstack): Remove globals.
13044         (scan_macro_expansion, scanning_macro_expansion)
13045         (finished_macro_expansion): Update.
13046         (scan_macro_cleanup): Remove.
13047         (yylex, c_parse): Update.
13048
13049 2019-01-06  Tom Tromey  <tom@tromey.com>
13050
13051         * c-exp.y (struct c_parse_state) <strings>: New member.
13052         (operator_stoken): Update.
13053
13054 2019-01-06  Tom Tromey  <tom@tromey.com>
13055
13056         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13057         (union type_stack_elt) <typelist_val>: Now a pointer to
13058         std::vector.
13059         (type_stack_cleanup): Don't declare.
13060         (push_typelist): Update.
13061         * parse.c (pop_typelist): Return a std::vector.
13062         (push_typelist): Take a std::vector.
13063         (follow_types): Update.  Do not free args.
13064         (type_stack_cleanup): Remove.
13065         * c-exp.y (struct c_parse_state): New.
13066         (cpstate): New global.
13067         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13068         (nonempty_typelist): Update.
13069         (func_mod): Create a new vector.
13070         (c_parse): Create a c_parse_state.
13071         (check_parameter_typelist): Do not delete params.
13072         (function_method): Update.  Do not delete type_list.
13073
13074 2019-01-06  Tom Tromey  <tom@tromey.com>
13075
13076         PR gdb/28155:
13077         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13078         check_typedef.
13079         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13080         (print_return_value): Likewise.
13081
13082 2019-01-05  Tom Tromey  <tom@tromey.com>
13083
13084         * contrib/cleanup_check.py: Remove.
13085         * contrib/gcc-with-excheck: Remove.
13086         * contrib/exsummary.py: Remove.
13087         * contrib/excheck.py: Remove.
13088
13089 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13090
13091         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13092         NULL. Initialize tpprev to NULL instead of assigning it
13093         to NULL on the next statement.
13094         * windows-nat.c (windows_delete_thread): Remove check for
13095         main_thread_id before printing thread exit notifications.
13096         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13097         Remove thread ID check against main_thread_id.
13098         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13099         windows_delete_thread.
13100         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13101
13102 2019-01-04  Tom Tromey  <tom@tromey.com>
13103
13104         * compile/compile.c (_initialize_compile): Use upper case for
13105         metasyntactic variables.
13106         * symmisc.c (_initialize_symmisc): Use upper case for
13107         metasyntactic variables.
13108         * psymtab.c (_initialize_psymtab): Use upper case for
13109         metasyntactic variables.
13110         * demangle.c (demangle_command): Use upper case for metasyntactic
13111         variables.
13112         (_initialize_demangler): Likewise.
13113         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13114         variables.
13115
13116 2019-01-03  Tom Tromey  <tom@tromey.com>
13117
13118         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13119
13120 2019-01-03  Tom Tromey  <tom@tromey.com>
13121
13122         * python/py-symtab.c (salpy_str): Update.
13123         (struct salpy_sal_object) <symtab>: Now a PyObject.
13124         (salpy_dealloc): Update.
13125         (del_objfile_sal): Use gdbpy_ref.
13126
13127 2019-01-03  Tom Tromey  <tom@tromey.com>
13128
13129         * python/py-type.c (convert_field): Use new_reference.  Return
13130         gdbpy_ref.
13131         (make_fielditem): Return gdbpy_ref.
13132         (typy_fields): Update.
13133         (typy_getitem): Update.
13134         (field_name): Return gdbpy_ref.  Use new_reference.
13135         (typy_iterator_iternext): Update.
13136
13137 2019-01-03  Tom Tromey  <tom@tromey.com>
13138
13139         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13140
13141 2019-01-03  Tom Tromey  <tom@tromey.com>
13142
13143         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13144         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13145         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13146         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13147         (pspy_set_type_printers): Likewise.
13148         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13149         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13150         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13151         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13152         (objfpy_set_type_printers): Likewise.
13153
13154 2019-01-03  Tom Tromey  <tom@tromey.com>
13155
13156         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13157         (gdbpy_print_stack): Use gdbpy_err_fetch.
13158         * python/python-internal.h (class gdbpy_err_fetch): New class.
13159         (class gdbpy_enter) <m_error_type, m_error_value,
13160         m_error_traceback>: Remove.
13161         <m_error>: New member.
13162         (gdbpy_exception_to_string): Don't declare.
13163         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13164         * python/py-value.c (convert_value_from_python): Use
13165         gdbpy_err_fetch.
13166         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13167         gdbpy_exception_to_string.
13168         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13169         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13170         gdbpy_err_fetch.
13171
13172 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13173
13174         * linux-nat.c (delete_lwp_cleanup): Delete.
13175         (struct lwp_deleter): New struct.
13176         (lwp_info_up): New typedef.
13177         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13178         lwp_info_up.
13179
13180 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13181
13182         * linux-fork.c (class scoped_switch_fork_info): New class.
13183         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13184
13185 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13186
13187         * valops.c (find_overload_match): Remove use of null_cleanup, and
13188         calls to do_cleanups.
13189
13190 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13191
13192         * compile/compile-cplus-types.c
13193         (compile_cplus_instance::decl_name): Handle changes to
13194         cp_func_name.
13195         * cp-support.c (cp_func_name): Update header comment, update
13196         return type.
13197         * cp-support.h (cp_func_name): Update return type in declaration.
13198         * valops.c (find_overload_match): Move temp_func local to top
13199         level of function and change its type.  Use temp_func to hold and
13200         delete temporary string obtained from cp_func_name.
13201
13202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13203
13204         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13205         gdb::char_vector, remove cleanup, and update uses of `msg`.
13206
13207 2019-01-03  Jim Wilson  <jimw@sifive.com>
13208
13209         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13210
13211 2019-01-02  Tom Tromey  <tom@tromey.com>
13212
13213         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13214         (tdesc_parse_xml): Remove cleanups.
13215         * target-descriptions.h (make_cleanup_free_target_description):
13216         Don't declare.
13217         (target_desc_deleter): New struct.
13218         (target_desc_up): New typedef.
13219         * target-descriptions.c (target_desc_deleter::operator()): Rename
13220         from free_target_description.
13221         (make_cleanup_free_target_description): Remove.
13222
13223 2019-01-02  Tom Tromey  <tom@tromey.com>
13224
13225         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13226         constructor, destructor.
13227         (linespec_parser): Remove typedef.
13228         (~linespec_parser): Rename from linespec_parser_delete.
13229         (linespec_lex_to_end, linespec_complete_label)
13230         (linespec_complete): Update.
13231         (decode_line_full): Remove cleanups.
13232         (decode_line_1): Update.
13233
13234 2019-01-02  Tom Tromey  <tom@tromey.com>
13235
13236         * python/python-internal.h (inferior_to_inferior_object): Change
13237         return type.
13238         * python/py-exitedevent.c (create_exited_event_object): Update.
13239         * python/py-inferior.c (inferior_to_inferior_object): Return
13240         gdbpy_ref.
13241         (python_new_inferior, python_inferior_deleted)
13242         (thread_to_thread_object, delete_thread_object)
13243         (build_inferior_list, gdbpy_selected_inferior): Update.
13244         * python/py-infthread.c (create_thread_object): Update.  Also fail
13245         if inferior_to_inferior_object fails.
13246
13247 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13248
13249         * inferior.h (class inferior) <displaced_step_state>: New field.
13250         * infrun.h (struct displaced_step_state): Move here from
13251         infrun.c.  Initialize fields, add constructor.
13252         <inf>: Remove field.
13253         <reset>: New method.
13254         * infrun.c (struct displaced_step_inferior_state): Move to
13255         infrun.h.
13256         (displaced_step_inferior_states): Remove.
13257         (get_displaced_stepping_state): Adust.
13258         (displaced_step_in_progress_any_inferior): Adjust.
13259         (displaced_step_in_progress_thread): Adjust.
13260         (displaced_step_in_progress): Adjust.
13261         (add_displaced_stepping_state): Remove.
13262         (get_displaced_step_closure_by_addr): Adjust.
13263         (remove_displaced_stepping_state): Remove.
13264         (infrun_inferior_exit): Call displaced_step_state.reset.
13265         (use_displaced_stepping): Don't check for NULL.
13266         (displaced_step_prepare_throw): Call
13267         get_displaced_stepping_state.
13268         (displaced_step_fixup): Don't check for NULL.
13269         (prepare_for_detach): Don't check for NULL.
13270
13271 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13272
13273         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13274          in case of call that did not complete.
13275
13276 2019-01-02  Andrey Utkin  <autkin@undo.io>
13277
13278         * symfile.c (find_separate_debug_file): Fix search of debug files for
13279         remote debuggee.
13280
13281 2019-01-02  Tom Tromey  <tom@tromey.com>
13282
13283         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13284         indentation.
13285         * python/py-frame.c (frapy_older): Remove cast.
13286         (frapy_newer): Likewise.
13287         * python/py-breakpoint.c (local_setattro): Remove cast.
13288         * python/py-arch.c (archpy_name): Remove local variable.
13289         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13290
13291 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13292
13293         * unittests/basic_string_view/element_access/char/empty.cc:
13294         Fix year range in copyright header.
13295
13296 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13297
13298         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13299         Delete.
13300         <operator==>: Update with for removed field.
13301         <hash>: Likewise.
13302         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13303         <isa_features>: ...this.
13304         <abi_features>: New field.
13305         (riscv_isa_flen): Update comment.
13306         (riscv_abi_xlen): New declaration.
13307         (riscv_abi_flen): New declaration.
13308         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13309         isa_features.
13310         (riscv_abi_xlen): New function.
13311         (riscv_isa_flen): Update to get answer from isa_features.
13312         (riscv_abi_flen): New function.
13313         (riscv_has_fp_abi): Update to get answer from abi_features.
13314         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13315         xlen and flen.
13316         (riscv_call_info) <xlen, flen>: Update comment.
13317         (riscv_call_arg_struct): Remove invalid assertions
13318         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13319         is removed.
13320         (riscv_gdbarch_init): Gather isa features and abi features
13321         separately, ensure both match on the gdbarch when reusing an old
13322         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13323         a target with 64-bit float hardware.
13324
13325 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13326
13327         * source.c (search_command_helper): Stop reverse search
13328         when line 1 has been searched.
13329
13330 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13331
13332         * record-full.c (record_full_base_target::close): Rewrite
13333         record_full_core_buf_list free logic.
13334
13335 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13336
13337         * break-catch-syscall.c (print_one_catch_syscall): xfree
13338         the last text.
13339
13340 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13341
13342         * top.c (print_gdb_version): Update Copyright year in version
13343         message.
13344
13345 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13346
13347         Update copyright year range in all GDB files.
13348
13349 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13350
13351         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13352
13353 For older changes see ChangeLog-2018.
13354 \f
13355 Local Variables:
13356 mode: change-log
13357 left-margin: 8
13358 fill-column: 74
13359 version-control: never
13360 coding: utf-8
13361 End:
13362