gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_source_window)
   4         (tui_update_source_window_as_is)
   5         (tui_update_source_windows_with_line): Remove return.
   6         * tui/tui-disasm.c (tui_show_disassem)
   7         (tui_show_disassem_and_update_source): Remove return.
   8         * tui/tui.c (tui_reset): Remove return.
   9         * tui/tui-wingeneral.c
  10         (tui_check_and_display_highlight_if_needed): Remove return.
  11
  12 2019-07-17  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-winsource.h (struct tui_exec_info_window)
  19         (struct tui_source_window_base): Move from tui-data.h.
  20         * tui/tui-winsource.c: Move many method definitions from
  21         elsewhere.  Remove "structuring" comments.
  22         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  23         (tui_source_window_base::refresh_window): Move to
  24         tui-winsource.c.
  25         * tui/tui-win.c (tui_source_window_base::refresh_all)
  26         (tui_source_window_base::update_tab_width)
  27         (tui_source_window_base::set_new_height)
  28         (tui_source_window_base::do_make_visible_with_new_height): Move to
  29         tui-winsource.c.
  30         * tui/tui-source.h: Update.
  31         * tui/tui-source.c (tui_source_window_base::reset): Move to
  32         tui-winsource.c.
  33         * tui/tui-disasm.h: Update.
  34         * tui/tui-data.h (struct tui_exec_info_window): Move to
  35         tui-winsource.h.
  36         (struct tui_source_window_base): Likewise.
  37         * tui/tui-data.c (tui_source_window_base::clear_detail)
  38         (tui_source_window_base, ~tui_source_window_base): Move to
  39         tui-winsource.c.
  40
  41 2019-07-17  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-win.c (tui_resize_all)
  44         (tui_source_window_base::update_tab_width)
  45         (tui_adjust_win_heights): Update.
  46         (tui_win_info::make_invisible_and_set_new_height): Rename from
  47         make_invisible_and_set_new_height.
  48         * tui/tui-data.h (struct tui_win_info)
  49         <make_invisible_and_set_new_height>: New method.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui.c: Update.
  54         * tui/tui-source.h (struct tui_source_window): Move from
  55         tui-data.h.
  56         * tui/tui-layout.c: Update.
  57         * tui/tui-disasm.c: Update.
  58         * tui/tui-data.h (struct tui_source_window): Move to
  59         tui-source.h.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  64         tui-data.h.
  65         * tui/tui-data.h (struct tui_disasm_window): Move to
  66         tui-disasm.h.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-regs.h (struct tui_data_item_window): Move from
  71         tui-data.h.
  72         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  73         * tui/tui-data.h (struct tui_data_item_window): Move to
  74         tui-regs.h.
  75         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui.c: Update.
  80         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  81         (tui_cmd_window::max_height): Move to tui-command.c.
  82         * tui/tui-layout.c: Update.
  83         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  84         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  85         tui-command.c.
  86         * tui/tui-command.h (struct tui_cmd_window): Move from
  87         tui-data.h.
  88         * tui/tui-command.c: Remove "structuring" comments.
  89         (tui_cmd_window::clear_detail)
  90         (tui_cmd_window::do_make_visible_with_new_height)
  91         (tui_cmd_window::max_height): Move from elsewhere.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  96         Now static.
  97         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  98         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui.c: Update.
 103         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 104         tui-regs.c.
 105         * tui/tui-windata.h: Remove file.
 106         * tui/tui-windata.c: Remove file.
 107         * tui/tui-win.c (tui_data_window::set_new_height)
 108         (tui_data_window::do_make_visible_with_new_height): Move to
 109         tui-regs.c.
 110         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 111         * tui/tui-regs.c: Remove "structuring" comments.
 112         (tui_data_window::first_data_item_displayed)
 113         (tui_data_window::delete_data_content_windows)
 114         (tui_data_window::erase_data_content)
 115         (tui_data_window::display_all_data)
 116         (tui_data_window::refresh_all)
 117         (tui_data_window::do_scroll_vertical)
 118         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 119         (tui_data_window::do_make_visible_with_new_height)
 120         (tui_data_window::refresh_window): Move from elsewhere.
 121         (_initialize_tui_regs): Move to end of file.
 122         * tui/tui-layout.c: Update.
 123         * tui/tui-hooks.c: Update.
 124         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 125         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 126         tui-regs.c.
 127         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 132         seen.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-win.c (tui_source_window_base::set_new_height)
 137         (tui_source_window_base::do_make_visible_with_new_height): Use
 138         m_has_locator field directly.
 139         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 140         method.
 141         (struct tui_source_window_base) <has_locator>: Likewise.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 146         Don't declare.
 147         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 148         Remove.
 149         * tui/tui-win.c (tui_source_window_base::set_new_height)
 150         (tui_source_window_base::set_new_height)
 151         (make_invisible_and_set_new_height)
 152         (tui_source_window_base::do_make_visible_with_new_height)
 153         (tui_source_window_base::do_make_visible_with_new_height):
 154         Update.
 155         * tui/tui-layout.c (show_source_disasm_command, show_data)
 156         (show_source_or_disasm_and_command): Update.
 157         * tui/tui-layout.c (show_layout): Update.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-layout.c (make_data_window): Remove.
 162         (show_data): Unify creation and re-initialization cases.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-layout.c (make_source_window, make_disasm_window):
 167         Remove.
 168         (show_data): Unify creation and re-initialization cases.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-layout.c (make_command_window): Remove.
 173         (show_source_disasm_command, show_source_or_disasm_and_command):
 174         Unify creation and re-initialization cases.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 179         creation and re-initialization cases.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-regs.c (tui_get_register): Return void.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 188         Simplify.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 193         resetting.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 198         * tui/tui-regs.c (tui_reg_layout): New function.
 199         (tui_show_registers, tui_reg_command): Use it.
 200         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 201         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 202         parameters.
 203         (tui_layout_command): Remove.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-layout.h (tui/tui-layout): Return void.
 208         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-layout.c (show_source_disasm_command, show_data):
 213         Update.
 214         (reset_locator): Remove.
 215         (show_source_or_disasm_and_command): Update.
 216
 217 2019-07-17  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-source.c (tui_source_window_base::reset): Remove
 220         win_type parameter.
 221         * tui/tui-layout.c (make_command_window, make_source_window)
 222         (make_disasm_window, make_data_window)
 223         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 224         (reset_locator, show_source_or_disasm_and_command): Update.
 225         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 226         win_type parameter.
 227         (struct tui_source_window_base) <reset>: Likewise.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-layout.c (show_source_disasm_command): Use
 232         reset_locator.
 233         (reset_locator): New function.
 234         (init_and_make_win): Remove.
 235         (show_source_or_disasm_and_command): Use reset_locator.
 236
 237 2019-07-17  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 240         condition.
 241         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 242         Remove condition.
 243         * tui/tui-source.c (tui_source_window_base::reset): New method.
 244         * tui/tui-layout.c (make_command_window): Don't call
 245         init_and_make_win.
 246         (make_source_window, make_disasm_window): Don't call
 247         make_source_or_disasm_window.
 248         (make_data_window): Don't call init_and_make_win.  Change calling
 249         convention.
 250         (show_source_disasm_command, show_data): Simplify.
 251         (make_source_or_disasm_window): Remove.
 252         (show_source_or_disasm_and_command): Simplify.
 253         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 254         (struct tui_source_window_base) <reset>: Likewise.
 255         <execution_info>: Remove initializer.
 256         * tui/tui-data.c (tui_source_window_base): Initialize
 257         execution_info.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 262         variable.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui.c (tui_rl_other_window): Update.
 267         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 268         superclass method first.  Always iterate over regs_content.
 269         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 270         method.
 271         * tui/tui-win.c (tui_set_focus_command): Update.
 272
 273 2019-07-17  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-win.c (tui_set_focus_command): Rename from
 276         tui_set_focus.  Call tui_enable.
 277         (tui_set_focus_command): Remove.
 278
 279 2019-07-17  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 282         refresh_window.
 283         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 284         touchwin.
 285         (tui_data_window::refresh_window): Call refresh_window on data
 286         items.  Always call superclass refresh_window.
 287         (tui_win_info::refresh): Remove.
 288         (tui_source_window_base::refresh_window): Update.
 289         (tui_refresh_all): Update.
 290         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 291         refresh_window.
 292         (show_source_or_disasm_and_command): Likewise.
 293         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 294         (struct tui_source_window_base) <refresh>: Likewise.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-winsource.c (tui_clear_source_content)
 299         (tui_show_source_content): Update.
 300         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 301         whether content is empty.
 302         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 303         Remove.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 308         window's contents.
 309         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 310         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 315         (struct tui_data_item_window): Update.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 320         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 321         defines.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-winsource.h (tui_erase_source_content)
 326         (tui_clear_source_content): Remove "display_prompt" parameter.
 327         * tui/tui-winsource.c (tui_update_source_window_as_is)
 328         (tui_update_source_windows_with_addr): Update.
 329         (tui_clear_source_content): Remove "display_prompt" parameter.
 330         (tui_erase_source_content): Likewise.  Simplify.
 331         (tui_show_source_content): Update.
 332         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 333         * tui/tui-stack.c (tui_show_frame_info): Update.
 334         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 335         Remove defines.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 340         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 341         parameter.
 342         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 343         parameter.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.c (tui_clear_source_content)
 348         (tui_show_source_content, tui_show_exec_info_content)
 349         (tui_clear_exec_info_content): Update.
 350         * tui/tui-stack.c (tui_show_locator_content): Update.
 351         (tui_show_frame_info): Update.
 352         * tui/tui-source.h (tui_source_window): Don't declare.
 353         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 354         from tui_source_is_displayed.
 355         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 356         Remove field.
 357         (struct tui_source_window_base) <content_in_use>: New field.  Now
 358         bool.
 359         (struct tui_source_window) <showing_source_p>: New method.
 360         (TUI_SRC_WIN): Change cast.
 361         * tui/tui-data.c (tui_initialize_static_data): Update.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 366         location_matches_p.
 367         * tui/tui-source.c (tui_source_window::location_matches_p): New
 368         method.
 369         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 370         method.
 371         * tui/tui-data.h (struct tui_source_window_base)
 372         <location_matches_p>: New method.
 373         (struct tui_source_window, struct tui_disasm_window)
 374         <location_matches_p>: Likewise.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-win.c (tui_set_win_height_command): Rename from
 379         tui_set_win_height.
 380         (tui_set_win_height_command): Remove.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-source.c (tui_source_window): New constructor.  Add
 385         observer.
 386         (~tui_source_window): New destructor.
 387         (tui_source_window::style_changed): New method.
 388         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 389         (tui_attach_detach_observers): Update.
 390         * tui/tui-data.h (struct tui_source_window): Make constructor not
 391         inline.  Add destructor.
 392         (struct tui_source_window) <style_changed>: New method.
 393         <m_observable>: New member.
 394
 395 2019-07-17  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 398         * tui/tui-win.c (tui_resize_all): Fix typo.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 403         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 404         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 405         * tui/tui-win.c (window_name_completer): Use foreach.
 406         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 407         (update_tab_width): Likewise.
 408         * tui/tui-layout.c (show_layout): Update.
 409         * tui/tui-data.h (class tui_window_iterator): New.
 410         (struct all_tui_windows): New.
 411         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 416         parameter.  Don't reference globals.
 417         (tui_reg_command): Update.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-regs.c (tui_show_registers): Simplify.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-regs.c (tui_show_registers): Update.
 426         (tui_show_register_group): Add win_info parameter.
 427
 428 2019-07-17  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 431         Rename from tui_display_reg_element_at_line.
 432         (tui_data_window::display_registers_from_line): Update.
 433         * tui/tui-data.h (struct tui_data_window)
 434         <display_reg_element_at_line>: New method.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-regs.h (tui_display_registers_from)
 439         (tui_display_registers_from_line): Don't declare.
 440         * tui/tui-windata.c (tui_data_window::display_all_data)
 441         (tui_data_window::refresh_all)
 442         (tui_data_window::do_scroll_vertical): Update.
 443         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 444         from tui_display_registers_from.
 445         (tui_display_reg_element_at_line): Update.
 446         (tui_data_window::display_registers_from_line): Rename from
 447         tui_display_registers_from_line.
 448         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 449         display_registers_from_line>: New methods.
 450
 451 2019-07-17  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 454         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 455         from tui_erase_data_content.
 456         (tui_data_window::display_all_data)
 457         (tui_data_window::refresh_all)
 458         (tui_data_window::do_scroll_vertical): Update.
 459         * tui/tui-regs.c (tui_show_registers): Update.
 460         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 461         New method.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 466         declare.
 467         * tui/tui-windata.c
 468         (tui_data_window::delete_data_content_windows): Rename from
 469         tui_delete_data_content_windows.
 470         (tui_data_window::display_all_data)
 471         (tui_data_window::do_scroll_vertical): Update.
 472         * tui/tui-data.h (struct tui_data_window)
 473         <delete_data_content_windows>: New method.
 474
 475 2019-07-17  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 478         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 483         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 484         from tui_display_all_data.
 485         * tui/tui-win.c
 486         (tui_data_window::do_make_visible_with_new_height): Update.
 487         * tui/tui-regs.c (tui_show_registers): Update.
 488         * tui/tui-layout.c (tui_set_layout): Update.
 489         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 490         method.
 491
 492 2019-07-17  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 495         * tui/tui-windata.c (tui_display_data_from): Remove.
 496         (tui_data_window::refresh_all): Update.
 497
 498 2019-07-17  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 501         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 502         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 503         tui_display_registers_from_line.
 504         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 505         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 506         "force_display" parameter.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 511         declare.
 512         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 513         Rename from tui_first_reg_element_no_inline.
 514         (tui_display_reg_element_at_line)
 515         (tui_display_registers_from_line): Update.
 516         * tui/tui-data.h (struct tui_data_window)
 517         <first_reg_element_no_inline>: New method.
 518
 519 2019-07-17  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-windata.c (tui_display_data_from)
 522         (tui_data_window::do_scroll_vertical): Update.
 523         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 524         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 525         Rename from tui_line_from_reg_element_no.
 526         (tui_display_registers_from_line): Update.
 527         * tui/tui-data.h (struct tui_data_window)
 528         <line_from_reg_element_no>: New method.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 533         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 534         tui_last_regs_line_no.
 535         (tui_display_reg_element_at_line)
 536         (tui_display_registers_from_line): Update.
 537         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 538         method.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         PR tui/24722:
 543         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 544         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 545         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 546         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 547         (tui_update_breakpoint_info): Likewise.
 548         * tui/tui-hooks.c (tui_event_create_breakpoint)
 549         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 550         Update.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-winsource.c (tui_update_source_window_as_is)
 559         (tui_update_source_windows_with_addr): Update.
 560         * tui/tui-source.h (tui_set_source_content)
 561         (tui_show_symtab_source): Add "win_info" parameter.
 562         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 563         parameter.
 564         (tui_show_symtab_source): Likewise.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-wingeneral.c
 569         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 570
 571 2019-07-17  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 574         (struct tui_cmd_window) <can_scroll>: New method.
 575         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 576         method.
 577
 578 2019-07-17  Tom Tromey  <tromey@adacore.com>
 579
 580         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 581         do_field_signed>: Rename.  Change type of "value".
 582         * ui-out.c (ui_out::field_signed): Rename from field_int.
 583         Change type of "value".
 584         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 585         type of "value".
 586         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 587         do_field_int.  Change type of "value".
 588         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 589         do_field_int.  Change type of "value".
 590         * tracepoint.c (trace_status_mi, tfind_1)
 591         (print_one_static_tracepoint_marker): Update.
 592         * thread.c (print_thread_info_1, print_selected_thread_frame):
 593         Update.
 594         * stack.c (print_frame, print_frame_info): Update.
 595         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 596         Update.
 597         * source.c (print_source_lines_base): Update.
 598         * skip.c (info_skip_command): Update.
 599         * record-btrace.c (btrace_ui_out_decode_error)
 600         (btrace_call_history_src_line): Update.
 601         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 602         Update.
 603         * progspace.c (print_program_space): Update.
 604         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 605         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 606         do_field_int.  Change type of "value".
 607         * mi/mi-out.c (mi_ui_out::do_table_begin)
 608         (mi_ui_out::do_table_header): Update.
 609         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 610         type of "value".
 611         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 612         (mi_cmd_data_list_changed_registers, output_register)
 613         (mi_cmd_data_read_memory, mi_load_progress)
 614         (mi_cmd_trace_frame_collected): Update.
 615         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 616         Update.
 617         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 618         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 619         (mi_cmd_var_list_children, varobj_update_one): Update.
 620         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 621         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 623         * inferior.c (print_inferior): Update.
 624         * gdb_bfd.c (print_one_bfd): Update.
 625         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 626         Update.
 627         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 628         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 629         do_field_int.  Change type of "value".
 630         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 631         do_field_int.  Change type of "value".
 632         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 633         (print_one_breakpoint_location, print_it_catch_fork)
 634         (print_one_catch_fork, print_it_catch_vfork)
 635         (print_one_catch_vfork, print_it_catch_solib)
 636         (print_it_catch_exec, print_it_ranged_breakpoint)
 637         (print_mention_watchpoint, print_mention_masked_watchpoint)
 638         (bkpt_print_it, update_static_tracepoint): Update.
 639         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 640         * break-catch-syscall.c (print_it_catch_syscall): Update.
 641         * ada-tasks.c (print_ada_task_info): Update.
 642         * ada-lang.c (print_it_exception, print_mention_exception):
 643         Update.
 644
 645 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         PR breakpoints/24541
 648         * gdbarch.c: Regenerate.
 649         * gdbarch.h: Regenerate.
 650         * gdbarch.sh: Adjust return type and parameter types for
 651         'stap_adjust_register'.
 652         (i386_stap_adjust_register): Adjust signature and return new
 653         register name.
 654         * stap-probe.c (stap_parse_register_operand): Adjust use of
 655         'gdbarch_stap_adjust_register'.
 656
 657 2019-07-17  Tom Tromey  <tromey@adacore.com>
 658
 659         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 660         declare VEC.
 661         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 662         std::vector.
 663         (struct s390_process_info): Add initializers.
 664         (s390_add_process): Use new.
 665         (s390_linux_nat_target::low_forget_process): Use delete.
 666         (s390_linux_nat_target::low_new_fork)
 667         (s390_linux_nat_target::stopped_by_watchpoint)
 668         (s390_linux_nat_target::low_prepare_to_resume)
 669         (s390_linux_nat_target::insert_watchpoint)
 670         (s390_linux_nat_target::insert_hw_breakpoint)
 671         (s390_linux_nat_target::remove_watchpoint)
 672         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 673
 674 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 675
 676         * aarch64-fbsd-nat.c: Include regcache.h.
 677         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 678         argument.
 679         (aarch64_fbsd_nat_target::fetch_registers)
 680         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 681         variable.
 682         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 683
 684 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 685
 686         * fbsd-nat.c: Include gdbarch.h.
 687
 688 2019-07-15  Tom Tromey  <tromey@adacore.com>
 689
 690         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 691
 692 2019-07-15  Tom Tromey  <tromey@adacore.com>
 693
 694         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 695         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 696         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 697         * cli-out.c (cli_ui_out::do_field_int): New method.
 698         * ui-out.c (ui_out::field_unsigned): New method.
 699         * symfile.c (generic_load): Use field_unsigned.
 700         (print_transfer_performance): Likewise.
 701         * record-btrace.c (ui_out_field_uint): Remove.
 702         (btrace_call_history_insn_range, btrace_call_history): Use
 703         field_unsigned.
 704         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 705         field_unsigned.
 706         * ui-out.h (class ui_out) <field_unsigned>: New method.
 707         <do_field_unsigned>: Likewise.
 708
 709 2019-07-15  Tom Tromey  <tromey@adacore.com>
 710
 711         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 712         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 713         * target.c (flash_erase_command): Use field_string.
 714         * infrun.c (print_signal_received_reason): Use field_string.
 715         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 716         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 717         field_string.
 718         * ada-tasks.c (print_ada_task_info): Use field_string.
 719
 720 2019-07-15  Tom Tromey  <tromey@adacore.com>
 721
 722         * target.c (flash_erase_command): Use field_core_addr.
 723         * symfile.c (generic_load): Use field_core_addr.
 724         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 725         Use field_core_addr.
 726         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 727         field_core_addr.
 728
 729 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 732         value if its desired type is smaller than a CORE_ADDR and signed.
 733
 734 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 737         of changes to field names, and use new is_reference field to
 738         decide if a property is a reference or not.
 739         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 740         field.
 741         (struct dwarf2_property_baton): Update header comment, rename
 742         'referenced_type' to 'property_type' and update comments.
 743         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 744         default property type, store in property baton, update to take
 745         accound of renamed field.
 746         (read_func_scope): Update call to attr_to_dynamic_prop.
 747         (read_array_type): Likewise.
 748         (dwarf2_per_cu_addr_sized_int_type): New function.
 749         (read_subrange_index_type): Move type finding code to
 750         dwarf2_per_cu_addr_sized_int_type.
 751         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 752         (dwarf2_per_cu_addr_type): New function.
 753         (set_die_type): Update calls to attr_to_dynamic_prop.
 754
 755 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 756
 757         * dwarf2read.c (read_subrange_index_type): New function.
 758         (read_subrange_type): Move code into new function and call it.
 759         * gdbtypes.c (create_range_type): Add some asserts.
 760
 761 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 764         update return statements.
 765         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 766         declaration, and update comment to match.
 767         * gdbtypes.c (resolve_dynamic_array): Update call to
 768         dwarf2_evaluate_property to match new return type.
 769
 770 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * valarith.c (value_subscripted_rvalue): Change lowerbound
 773         parameter type from int to LONGEST.
 774         * value.h (value_subscripted_rvalue): Likewise in declaration.
 775
 776 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * cli/cli-utils.c (info_print_command_completer): New function.
 779         * cli/cli-utils.h: Add 'completer.h' include, and forward
 780         declaration for 'struct cmd_list_element'.
 781         (info_print_command_completer): Declare.
 782         * stack.c (_initialize_stack): Add completer for 'info locals' and
 783         'info args'.
 784         * symtab.c (_initialize_symtab): Add completer for 'info
 785         variables' and 'info functions'.
 786         * NEWS: Mention completion for additional info commands.
 787
 788 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * cli/cli-utils.c (extract_info_print_args): Delete.
 791         (extract_arg_maybe_quoted): Delete.
 792         (info_print_options_defs): New variable.
 793         (make_info_print_options_def_group): New function.
 794         (extract_info_print_options): Define new function.
 795         * cli/cli-utils.h (extract_info_print_args): Delete.
 796         (struct info_print_options): New structure.
 797         (extract_info_print_options): Declare new function.
 798         * stack.c (info_locals_command): Update to use new
 799         extract_info_print_options, also add a header comment.
 800         (info_args_command): Likewise.
 801         * symtab.c (info_variables_command): Likewise.
 802         (info_functions_command): Likewise.
 803
 804 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 807         to extract string arguments.
 808         * common/common-utils.c (extract_string_maybe_quoted): New function.
 809         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 810
 811 2019-07-11  Tom Tromey  <tromey@adacore.com>
 812
 813         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 814         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 815         * top.h (gdbinit): Don't declare.
 816         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 817         into...
 818         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 819         * top.c (gdb_init): Don't call init_cli_cmds.
 820         (gdbinit): Remove.
 821         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 822
 823 2019-07-11  Tom Tromey  <tromey@adacore.com>
 824
 825         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 826         after it has been moved.
 827
 828 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 829
 830         * valops.c (value_must_coerce_to_target): Change return type to
 831         bool.
 832         * value.h (value_must_coerce_to_target): Likewise.
 833
 834 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 835
 836         * breakpoint.c (is_hardware_watchpoint): Remove
 837         forward-declaration.
 838         (is_masked_watchpoint): Change return type to bool.
 839         (is_tracepoint): Likewise.
 840         (is_breakpoint): Likewise.
 841         (is_hardware_watchpoint): Likewise.
 842         (is_watchpoint): Likewise.
 843         (is_no_memory_software_watchpoint): Likewise.
 844         (is_catchpoint): Likewise.
 845         (breakpoint_1): Make FILTER parameter's return type bool.
 846         is_masked_watchpoint): Change return type to bool.
 847         (save_breakpoints): Make FILTER parameter's return type bool.
 848         * breakpoint.h (is_breakpoint): Change return type to bool.
 849         (is_watchpoint): Likewise.
 850         (is_catchpoint): Likewise.
 851         (is_tracepoint): Likewise.
 852
 853 2019-07-10  Tom Tromey  <tom@tromey.com>
 854
 855         * defs.h: Don't include gdbarch.h.
 856         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 857         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 858         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 859         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 860         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 861         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 862         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 863         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 864         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 865         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 866         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 867         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 868         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 869         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 870         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 871         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 872         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 873         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 874         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 875         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 876         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 877         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 878         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 879         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 880         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 881         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 882         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 883
 884 2019-07-10  Tom Tromey  <tromey@adacore.com>
 885
 886         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 887         * breakpoint.c (init_ada_exception_breakpoint): Register as
 888         bp_catchpoint.
 889         (print_one_breakpoint_location, print_one_breakpoint): Use
 890         is_ada_exception_catchpoint.
 891         * ada-lang.c (class ada_catchpoint_location): Pass
 892         bp_loc_software_breakpoint to bp_location constructor.
 893         (is_ada_exception_catchpoint): New function.
 894
 895 2019-07-10  Tom Tromey  <tromey@adacore.com>
 896
 897         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 898         VEC.
 899         (struct arm_exidx_entry): New method operator<.
 900         (struct arm_exidx_data) <section_maps>: Change type.
 901         (arm_exidx_data_free): Remove.
 902         (arm_exidx_data_key): Change type.  Move lower.
 903         (arm_exidx_new_objfile): Update.
 904         (arm_compare_exidx_entries): Remove.
 905         (arm_find_exidx_entry, _initialize_arm_tdep)
 906
 907 2019-07-10  Tom Tromey  <tromey@adacore.com>
 908
 909         * solib-spu.c (ocl_program_data_key): Change type.
 910         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 911         Update.
 912
 913 2019-07-10  Tom Tromey  <tromey@adacore.com>
 914
 915         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 916         (struct solib_aix_inferior_data) <library_list>: Change type.
 917         (solib_aix_inferior_data_handle): Change type.
 918         (get_solib_aix_inferior_data): Update.
 919         (solib_aix_free_library_list): Remove.
 920         (library_list_start_library): Update.
 921         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 922         return type.
 923         (solib_aix_get_library_list)
 924         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 925         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 926
 927 2019-07-10  Tom Tromey  <tromey@adacore.com>
 928
 929         * solib-dsbt.c (struct dsbt_info): Add initializers.
 930         (solib_dsbt_pspace_data): Change type.
 931         (dsbt_pspace_data_cleanup): Remove.
 932         (get_dsbt_info, _initialize_dsbt_solib): Update.
 933
 934 2019-07-10  Tom Tromey  <tromey@adacore.com>
 935
 936         * spu-tdep.c (spu_overlay_data): Change type.
 937         (spu_get_overlay_table, spu_overlay_new_objfile)
 938         (_initialize_spu_tdep): Update.
 939
 940 2019-07-10  Tom Tromey  <tromey@adacore.com>
 941
 942         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 943         destructor.
 944         (dbx_objfile_data_key): Change type and declare later.
 945         (DBX_SYMFILE_INFO): Rewrite.
 946         * dbxread.c (dbx_objfile_data_key): Change type.
 947         (dbx_symfile_init): Update.
 948         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 949         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 950         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 951
 952 2019-07-10  Tom Tromey  <tromey@adacore.com>
 953
 954         * jit.c (jit_program_space_key): Change type.  Move lower.
 955         (get_jit_program_space_data): Update.
 956         (jit_program_space_data_cleanup): Remove.
 957         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 958         Update.
 959         (struct jit_program_space_data): Add initializers.
 960
 961 2019-07-10  Tom Tromey  <tromey@adacore.com>
 962
 963         * solib-darwin.c (struct darwin_info): Add initializers.
 964         (solib_darwin_pspace_data): Change type.
 965         (darwin_pspace_data_cleanup): Remove.
 966         (get_darwin_info, _initialize_darwin_solib): Update.
 967
 968 2019-07-10  Tom Tromey  <tromey@adacore.com>
 969
 970         * remote-sim.c (struct sim_inferior_data): Add initializers,
 971         constructor, and destructor.
 972         (sim_inferior_data_key): Change type.  Move lower.
 973         (check_for_duplicate_sim_descriptor): Update.
 974         (get_sim_inferior_data): Use new.  Update.
 975         (~sim_inferior_data_cleanup): Rename from
 976         sim_inferior_data_cleanup.  Simplify.
 977         (gdbsim_close_inferior, simulator_command)
 978         (sim_command_completer, _initialize_remote_sim): Update.
 979         (next_pid, INITIAL_PID): Move earlier.
 980
 981 2019-07-10  Tom Tromey  <tromey@adacore.com>
 982
 983         * python/python-internal.h (create_thread_object): Return
 984         gdbpy_ref.
 985         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 986         * python/py-inferior.c (struct threadlist_entry): Add
 987         constructor.
 988         <thread_obj>: Now a gdbpy_ref.
 989         (thread_to_thread_object): Update.
 990         (add_thread_object): Use new.
 991         (delete_thread_object): Use delete.
 992         (infpy_threads): Update.
 993         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 994         GIL.
 995
 996 2019-07-10  Tom Tromey  <tromey@adacore.com>
 997
 998         * valops.c (value_cast): Specialize error message for Ada.
 999
1000 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1001
1002         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1003
1004 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1005
1006         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1007         bpstat_should_step): Return bool, adjust comments.
1008         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1009         bpstat_should_step): Likewise.
1010
1011 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * features/Makefile: Use feature target descriptions for Arm.
1014         * features/arm/arm-core.c: Generate new file.
1015         * features/arm/arm-fpa.c: Likewise.
1016         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1017         * features/arm/arm-m-profile.c: Likewise.
1018         * features/arm/arm-vfpv2.c: Likewise.
1019         * features/arm/arm-vfpv3.c: Likewise.
1020         * features/arm/xscale-iwmmxt.c: Likewise.
1021         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1022
1023 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1026         ptrace earlier.
1027
1028 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * features/aarch64-pauth.c: Regenerate.
1031
1032 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1033
1034         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1035         bool.
1036         (bpstat_what): Use false instead of 0.
1037
1038 2019-07-09  Pedro Alves  <palves@redhat.com>
1039
1040         * break-catch-throw.c (is_exception_catchpoint): New.
1041         * breakpoint.c (print_one_breakpoint_location): New parameter
1042         'raw_loc'.  Handle it.  Use
1043         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1044         looking at the breakpoint's type.
1045         (print_one_breakpoint): If handling "maint info breakpoints", also
1046         print locations of exception catchpoints.
1047         * breakpoint.h (is_exception_catchpoint): Declare.
1048
1049 2019-07-09  Pedro Alves  <palves@redhat.com>
1050
1051         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1052         "addr" field.
1053         (allocate_location_exception_catchpoint): New.
1054         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1055         (initialize_throw_catchpoint_ops): Install
1056         allocate_location_exception_catchpoint as allocate_location
1057         method.
1058         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1059         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1060         bp_loc_other.
1061         (breakpoint_address_is_meaningful): Delete.
1062         (bl_address_is_meaningful): New.
1063         (breakpoint_locations_match): Adjust comment.
1064         (bp_location_from_bp_type): New, factored out of...
1065         (bp_location::bp_location(breakpoint *)): ... this.
1066         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1067         factored out of...
1068         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1069         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1070         breakpoint_address_is_meaningful.
1071         (bp_locations_compare): Adjust comment.
1072         (update_global_location_list): Use bl_address_is_meaningful
1073         instead of breakpoint_address_is_meaningful.
1074         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1075         explicit.
1076         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1077         * python/py-breakpoint.c (bppy_get_location): No longer check
1078         whether location is null.
1079
1080 2019-07-09  Pedro Alves  <palves@redhat.com>
1081
1082         PR c++/15468
1083         * breakpoint.c (print_one_breakpoint_location): Remove
1084         single-location assert.
1085
1086 2019-07-09  Tom Tromey  <tom@tromey.com>
1087
1088         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1089         * configure: Rebuild.
1090         * configure.ac: Change common to gdbsupport.
1091         * gdbsupport: Rename from common.
1092         * acinclude.m4: Change common to gdbsupport.
1093         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1094         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1095         gdbsupport.
1096         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1097         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1098         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1099         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1100         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1101         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1102         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1103         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1104         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1105         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1106         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1107         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1108         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1109         coff-pe-read.c, command.h, compile/compile-c-support.c,
1110         compile/compile-c.h, compile/compile-cplus-symbols.c,
1111         compile/compile-cplus-types.c, compile/compile-cplus.h,
1112         compile/compile-loc2c.c, compile/compile.c, completer.c,
1113         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1114         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1115         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1116         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1117         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1118         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1119         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1120         features/aarch64-core.c, features/aarch64-fpu.c,
1121         features/aarch64-pauth.c, features/aarch64-sve.c,
1122         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1123         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1124         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1125         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1126         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1127         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1128         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1129         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1130         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1131         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1132         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1133         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1134         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1135         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1136         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1137         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1138         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1139         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1140         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1141         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1142         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1143         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1144         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1145         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1146         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1147         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1148         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1149         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1150         minsyms.c, mips-linux-tdep.c, namespace.h,
1151         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1152         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1153         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1154         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1155         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1156         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1157         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1158         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1159         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1160         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1161         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1162         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1163         procfs.c, producer.c, progspace.h, psymtab.h,
1164         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1165         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1166         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1167         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1168         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1169         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1170         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1171         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1172         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1173         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1174         target-memory.c, target.c, target.h, target/waitstatus.c,
1175         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1176         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1177         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1178         unittests/array-view-selftests.c,
1179         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1180         unittests/common-utils-selftests.c,
1181         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1182         unittests/format_pieces-selftests.c,
1183         unittests/function-view-selftests.c,
1184         unittests/lookup_name_info-selftests.c,
1185         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1186         unittests/mkdir-recursive-selftests.c,
1187         unittests/observable-selftests.c,
1188         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1189         unittests/parse-connection-spec-selftests.c,
1190         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1191         unittests/scoped_fd-selftests.c,
1192         unittests/scoped_mmap-selftests.c,
1193         unittests/scoped_restore-selftests.c,
1194         unittests/string_view-selftests.c, unittests/style-selftests.c,
1195         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1196         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1197         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1198         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1199         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1200         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1201
1202 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1205         bool value.
1206         (decode_digits_ordinary): Set explicit_line field in sal.
1207         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1208         symtab_and_line that was set on an explicit line number in
1209         assembler code.  Do always update the recorded symtab and line if
1210         we do skip the prologue.
1211
1212 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * breakpoint.c (set_breakpoint_location_function): Remove
1215         explicit_loc parameter.
1216         (momentary_breakpoint_from_master): Update call to
1217         set_breakpoint_location_function.
1218         (add_location_to_breakpoint): Likewise.
1219
1220 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1223         required features based on default bfd type when no specific bfd
1224         is present.
1225
1226 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * NEWS: Mention that GDB printf and eval commands can now print
1229         C-style and Ada-style convenience var strings without
1230         calling the inferior.
1231         * printcmd.c (printf_c_string): Locally print GDB internal var
1232         instead of transiting via the inferior.
1233         (printf_wide_c_string): Likewise.
1234
1235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1236
1237         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1238
1239 2019-07-04  Tom Tromey  <tom@tromey.com>
1240
1241         PR tui/24724:
1242         * tui/tui-winsource.c (tui_clear_source_content): Update.
1243         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1244         (tui_update_breakpoint_info): Update.
1245         (tui_set_exec_info_content): Update.
1246         * tui/tui-source.c (tui_set_source_content_nil): Update.
1247         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1248         has_break.
1249         * tui/tui-data.h (enum tui_bp_flag): New.
1250         (tui_bp_flags): New enum flags type.
1251         (struct tui_source_element) <break_mode>: Change type.  Rename
1252         from has_break.
1253         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1254         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1255         constants.
1256         * tui/tui-winsource.h: Fix comment.
1257
1258 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1259
1260         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1261         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1262         (store_fpregs_to_thread)
1263         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1264         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1265         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1266         (IWMMXT_REGS_SIZE): Add define.
1267         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1268         (fetch_vfp_regs, store_vfp_regs)
1269         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1270         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1271
1272 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1273
1274         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1275         defines.
1276         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1277         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1278         (ARM_INT_REGISTER_SIZE): ...to this.
1279         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1280         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1281         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1282         (arm_linux_collect_gregset, supply_nwfpe_register)
1283         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1284         defines.
1285         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1286         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1287         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1288         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1289         (arm_return_in_memory, arm_store_return_value)
1290         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1291         (arm_record_ld_st_multiple): Likewise.
1292         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1293         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1294
1295 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1296
1297         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1298         AARCH64_DISPLACED_MODIFIED_INSNS.
1299         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1300         (aarch64_displaced_step_copy_insn): Likewise.
1301         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1302         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1303         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1304         ARM_DISPLACED_MODIFIED_INSNS.
1305         * arm-tdep.c (arm_gdbarch_init): Likewise.
1306         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1307         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1308         (struct arm_displaced_step_closure): Use
1309         ARM_DISPLACED_MODIFIED_INSNS.
1310
1311 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1312
1313         * features/Makefile: Remove unused xml files.
1314         * features/aarch64.xml: Remove.
1315         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1316         * features/i386/amd64-avx-avx512.xml: Remove.
1317         * features/i386/amd64-avx-linux.xml: Remove.
1318         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1319         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1320         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1321         * features/i386/amd64-avx-mpx.xml: Remove.
1322         * features/i386/amd64-avx.xml: Remove.
1323         * features/i386/amd64-linux.xml: Remove.
1324         * features/i386/amd64-mpx-linux.xml: Remove.
1325         * features/i386/amd64-mpx.xml: Remove.
1326         * features/i386/amd64.xml: Remove.
1327         * features/i386/i386-avx-avx512-linux.xml: Remove.
1328         * features/i386/i386-avx-avx512.xml: Remove.
1329         * features/i386/i386-avx-linux.xml: Remove.
1330         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1331         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1332         * features/i386/i386-avx-mpx-linux.xml: Remove.
1333         * features/i386/i386-avx-mpx.xml: Remove.
1334         * features/i386/i386-avx.xml: Remove.
1335         * features/i386/i386-linux.xml: Remove.
1336         * features/i386/i386-mmx-linux.xml: Remove.
1337         * features/i386/i386-mmx.xml: Remove.
1338         * features/i386/i386-mpx-linux.xml: Remove.
1339         * features/i386/i386-mpx.xml: Remove.
1340         * features/i386/i386.xml: Remove.
1341         * features/i386/x32-avx-avx512-linux.xml: Remove.
1342         * features/i386/x32-avx-linux.xml: Remove.
1343         * features/i386/x32-linux.xml: Remove.
1344
1345 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * regformats/aarch64.dat: Remove.
1348         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1349         * regformats/i386/amd64-avx-linux.dat: Remove.
1350         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1351         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1352         * regformats/i386/amd64-linux.dat: Remove.
1353         * regformats/i386/amd64-mpx-linux.dat: Remove.
1354         * regformats/i386/amd64.dat: Remove.
1355         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1356         * regformats/i386/i386-avx-linux.dat: Remove.
1357         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1358         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1359         * regformats/i386/i386-linux.dat: Remove.
1360         * regformats/i386/i386-mmx-linux.dat: Remove.
1361         * regformats/i386/i386-mpx-linux.dat: Remove.
1362         * regformats/i386/i386.dat: Remove.
1363         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1364         * regformats/i386/x32-avx-linux.dat: Remove.
1365         * regformats/i386/x32-linux.dat: Remove.
1366
1367 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1368
1369         * aarch64-tdep.c: Remove xml self tests.
1370         * amd64-linux-tdep.c: Likewise.
1371         * amd64-tdep.c: Likewise.
1372         * i386-linux-tdep.c: Likewise.
1373         * i386-tdep.c: Likewise.
1374
1375 2019-07-03  Pedro Alves  <palves@redhat.com>
1376
1377         PR cli/24732
1378         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1379         (pipe_cmd_option_defs): New.
1380         (make_pipe_cmd_options_def_group): New.
1381         (pipe_command): Use gdb::option::process_options.
1382         (pipe_command_completer): New function.
1383         (_initialize_cli_cmds): Install completer for "pipe" command.
1384
1385 2019-07-03  Pedro Alves  <palves@redhat.com>
1386
1387         * cli/cli-option.c (union option_value) <string>: New field.
1388         (struct option_def_and_value): Add ctor, move ctor, dtor and
1389         use DISABLE_COPY_AND_ASSIGN.
1390         (option_def_and_value::clear_value): New.
1391         (parse_option, save_option_value_in_ctx, get_val_type_str)
1392         (add_setshow_cmds_for_options): Handle var_string.
1393         * cli-option.h (union option_def::var_address) <string>: New
1394         field.
1395         (struct string_option_def): New.
1396         * maint-test-options.c (struct test_options_opts): Add default
1397         ctor and use DISABLE_COPY_AND_ASSIGN.
1398         <string_opt>: New field.
1399         (test_options_opts::~test_options_opts): New.
1400         (test_options_opts::dump): Also dump "-string".
1401         (test_options_option_defs): Install "string.
1402
1403 2019-07-03  Pedro Alves  <palves@redhat.com>
1404
1405         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1406         option_value with a null enumeration.
1407         (complete_options): Save the option values in the context.
1408         (save_option_value_in_ctx): New, factored out from ...
1409         (process_options): ... here.
1410         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1411         of the function.
1412         * maint-test-options.c (test_options_opts::dump): New, factored
1413         out from ...
1414         (maintenance_test_options_command_mode): ... here.
1415         (maintenance_test_options_command_completion_result): Delete.
1416         (maintenance_test_options_command_completion_text): Update
1417         comment.
1418         (maintenance_show_test_options_completion_result): Change
1419         prototype.  Just print
1420         maintenance_test_options_command_completion_text.
1421         (save_completion_result): New.
1422         (maintenance_test_options_completer_mode): Pass options context to
1423         complete_options, and then save a dump.
1424         (_initialize_maint_test_options): Use add_cmd to install "maint
1425         show test-options-completion-result".
1426
1427 2019-07-03  Pedro Alves  <palves@redhat.com>
1428
1429         * NEWS (New commands): Mention "with" and "maint with".
1430         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1431         (with_command, with_command_completer): New.
1432         (pipe_command): Adjust to new repeat_previous
1433         interface.
1434         (_initialize_cli_cmds): Install the "with" command and its "w"
1435         alias.
1436         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1437         declarations.
1438         * cli/cli-setshow.c (parse_cli_var_uinteger)
1439         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1440         argument strings for all var_types.
1441         (get_setshow_command_value_string): New, factored out from ...
1442         (do_show_command): ... this.
1443         * cli/cli-setshow.h: Include <string>.
1444         (get_setshow_command_value_string): Declare.
1445         * command.h (repeat_previous): Now returns const char *.  Adjust
1446         comment.
1447         * maint.c: Include "cli/cli-cmds.h".
1448         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1449         (_initialize_maint_cmds): Register the "maintenance with" command.
1450         * top.c (repeat_previous): Move bits from pipe_command here:
1451         Return the saved command line, if any; error out if there's no
1452         command to relaunch.
1453
1454 2019-07-03  Pedro Alves  <palves@redhat.com>
1455
1456         * NEWS (New commands): Mention "maint set/show test-settings"
1457         instead of "maint test-settings".
1458         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1459         (maintenance_test_settings_set_list): Rename to ...
1460         (maintenance_set_test_settings_list): ... this.
1461         (maintenance_test_settings_show_list): Rename to  ...
1462         (maintenance_show_test_settings_list): ... this.
1463         (maintenance_test_settings_cmd): Delete.
1464         (maintenance_test_settings_set_cmd): ...
1465         (maintenance_set_test_settings_cmd): ... this.
1466         (maintenance_test_settings_show_cmd): ...
1467         (maintenance_show_test_settings_cmd): ... this.
1468         (maintenance_test_settings_show_value_cmd):
1469         (maintenance_show_test_settings_value_cmd): ... this.
1470         (_initialize_maint_test_settings): No longer install the "maint
1471         test-settings" prefix command.  Rename "maint test-settings set"
1472         to "maint set test-settings", and "maint test-settings show" to
1473         "maint show test-settings".  Adjust all subcommands.
1474
1475 2019-07-03  Pedro Alves  <palves@redhat.com>
1476
1477         * maint-test-settings.c: Fix file's intro comment.  Replace all
1478         references to "test-options" with references to "test-settings",
1479         in comments.
1480
1481 2019-07-03  Pedro Alves  <palves@redhat.com>
1482
1483         * maint-test-settings.c (maintenance_test_settings_xxx)
1484         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1485         New.
1486         (maintenance_test_settings_enums): Use them.
1487         (maintenance_test_settings_enum): Default to
1488         maintenance_test_settings_xxx.
1489         (_initialize_maint_test_settings): Initialize
1490         MAINTENANCE_TEST_SETTINGS_FILENAME.
1491
1492 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1493
1494         * breakpoint.h (remove_breakpoints_inf): Change return type to
1495         void, move function documentation here.
1496         * breakpoint.c (remove_breakpoints_inf): Change return type to
1497         void, move function documentation to header.
1498
1499 2019-07-02  Pedro Alves  <palves@redhat.com>
1500
1501         * NEWS (Completion improvements): Mention "info threads".
1502         * thread.c (struct info_threads_opts, info_threads_option_defs)
1503         (make_info_threads_options_def_group): New.
1504         (info_threads_command): Use gdb::option::process_options.
1505         (info_threads_command_completer): New.
1506         (_initialize_thread): Use gdb::option::build_help to build the
1507         help text for "info threads".
1508
1509 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1510
1511         * defs.h (generic_load): Move from here...
1512         * symfile.h (generic_load): ... to here.  Rename name parameter
1513         to args.
1514         * symfile.c (generic_load): Add comment.
1515
1516 2019-07-01  Tom Tromey  <tromey@adacore.com>
1517
1518         * dwarf2read.c
1519         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1520         declaration of without_params.  Fix formatting.
1521
1522 2019-07-01  Tom Tromey  <tromey@adacore.com>
1523
1524         * ada-exp.y (find_primitive_type): Update.
1525         * ada-lang.h (ada_lookup_symbol): Update.
1526         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1527         parameter.
1528         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1529
1530 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1531
1532         PR breakpoints/24541
1533         * gdbarch.c: Regenerate.
1534         * gdbarch.h: Regenerate.
1535         * gdbarch.sh: Add 'stap_adjust_register'.
1536         * i386-tdep.c: Include '<unordered_set>'.
1537         (i386_stap_adjust_register): New function.
1538         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1539         * stap-probe.c (stap_parse_register_operand): Call
1540         'gdbarch_stap_adjust_register'.
1541
1542 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1543
1544         PR python/24742
1545         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1546         * python/python.c (do_start_initialization): Use 'xmalloc'
1547         instead of 'PyMem_Malloc'.
1548
1549 2019-06-28  Tom Tromey  <tromey@adacore.com>
1550
1551         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1552         for Ada.
1553
1554 2019-06-27  Tom Tromey  <tromey@adacore.com>
1555
1556         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1557         objfile_key.
1558         (arm_find_mapping_symbol, arm_record_special_symbol)
1559         (_initialize_arm_tdep): Update.
1560         (arm_objfile_data_free): Remove.
1561
1562 2019-06-27  Tom Tromey  <tromey@adacore.com>
1563
1564         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1565         to cp_print_static_field.
1566
1567 2019-06-26  Tom Tromey  <tromey@adacore.com>
1568
1569         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1570         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1571         declare.
1572
1573 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1574
1575         * features/aarch64-core.c (create_feature_aarch64_core):
1576         Regenerate.
1577         * features/aarch64-core.xml: Add cpsr flags.
1578
1579 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1580
1581         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1582         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1583
1584 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1585
1586         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1587         field.
1588         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1589         use.
1590         (arm_record_special_symbol): Don't insert new symbol in sorted
1591         position, push it at the end.
1592
1593 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1594
1595         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1596         (arm_mapping_symbol_s): Remove.
1597         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1598         (arm_mapping_symbol_vec): New typedef.
1599         (struct arm_per_objfile): Add constructor.
1600         <section_maps>: Change type to
1601         std::unique_ptr<arm_mapping_symbol_vec[]>.
1602         (arm_compare_mapping_symbols): Remove.
1603         (arm_find_mapping_symbol): Adjust to section_maps type change.
1604         (arm_objfile_data_free): Call delete on arm_per_objfile.
1605         (arm_record_special_symbol): Adjust to section_maps type change.
1606         Allocate arm_per_objfile with new.
1607
1608 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1609
1610         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1611         with the command prefix.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1616         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1621         type.
1622         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1623         protected.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-winsource.c
1628         (tui_source_window_base::set_is_exec_point_at): Add check against
1629         LOA_ADDRESS.
1630
1631 2019-06-25  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-source.c (tui_set_source_content): Don't check before
1634         xfree.
1635         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.h (tui_update_source_window_as_is)
1640         (tui_alloc_source_buffer, tui_line_is_displayed)
1641         (tui_addr_is_displayed): Change type of win_info.
1642         * tui/tui-winsource.c (tui_update_source_window_as_is)
1643         (tui_clear_source_content, tui_show_source_line)
1644         (tui_show_source_content, tui_source_window_base::refill)
1645         (tui_source_window_base::set_is_exec_point_at)
1646         (tui_source_window_base::set_is_exec_point_at)
1647         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1648         (tui_alloc_source_buffer, tui_line_is_displayed)
1649         (tui_addr_is_displayed): Change type of win_info.  Update.
1650         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1651         (tui_source_window_base::do_make_visible_with_new_height):
1652         Update.
1653         * tui/tui-source.c (tui_set_source_content)
1654         (tui_set_source_content_nil)
1655         (tui_source_window::do_scroll_vertical): Update.
1656         * tui/tui-layout.c (show_layout): Update.
1657         * tui/tui-disasm.c (tui_set_disassem_content)
1658         (tui_disasm_window::do_scroll_vertical): Update.
1659         * tui/tui-data.h (tui_win_content): Remove.
1660         (struct tui_gen_win_info) <content, content_size>: Remove.
1661         (struct tui_source_element): Add initializers and destructor.
1662         (union tui_which_element, struct tui_win_element): Remove.
1663         (struct tui_source_window_base) <content>: New field.
1664         (struct tui_data_window): Remove destructor.
1665         (tui_alloc_content, tui_free_win_content)
1666         (tui_free_all_source_wins_content): Don't declare.
1667         * tui/tui-data.c (tui_initialize_static_data): Update.
1668         (init_content_element, tui_alloc_content): Remove.
1669         (~tui_gen_win_info): Update.
1670         (~tui_data_window, tui_free_all_source_wins_content)
1671         (tui_free_win_content, free_content, free_content_elements):
1672         Remove.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.h (tui_clear_source_content)
1677         (tui_erase_source_content, tui_show_source_content): Change type
1678         of win_info.
1679         * tui/tui-winsource.c (tui_clear_source_content)
1680         (tui_erase_source_content, tui_show_source_content): Change type
1681         of win_info.
1682         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1683         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1684         win_info.
1685         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1686         win_info.
1687         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.c (tui_clear_source_content)
1692         (tui_source_window_base::set_is_exec_point_at): Update.
1693         * tui/tui-source.c (tui_set_source_content_nil): Update.
1694         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1695         a bool.
1696         * tui/tui-data.c (init_content_element): Update.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1701         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1702         * tui/tui-layout.c (init_and_make_win): Update.
1703         * tui/tui.h (enum tui_win_type): Update.
1704         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1705         tui_win_is_auxillary.
1706         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1707         tui_win_is_auxillary.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1712         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1713         (tui_delete_data_content_windows, tui_display_all_data)
1714         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1715         Update.
1716         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1717         * tui/tui-regs.c (tui_last_regs_line_no)
1718         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1719         (tui_show_registers): Update.
1720         (tui_show_register_group): Return void.  Update.
1721         (tui_display_registers_from, tui_display_reg_element_at_line)
1722         (tui_display_registers_from_line, tui_check_register_values):
1723         Update.
1724         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1725         member.
1726         (struct tui_data_window) <regs_content>: Now a std::vector.
1727         <regs_content_count>: Remove.
1728         (tui_add_content_elements, tui_free_data_content): Don't declare.
1729         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1730         (init_content_element): Remove DATA_WIN case.  Add assert.
1731         (tui_add_content_elements): Remove.
1732         (tui_data_window): Update.
1733         (tui_free_data_content): Remove.
1734         (free_content_elements): Remove DATA_WIN case.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-data.c (tui_data_item_window): Update.
1739         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1740         * tui/tui-windata.c (tui_display_all_data)
1741         (tui_display_data_from_line): Update.
1742         (tui_check_data_values): Remove.
1743         * tui/tui-regs.c (tui_show_register_group)
1744         (tui_display_reg_element_at_line): Update.
1745         * tui/tui-hooks.c (tui_register_changed)
1746         (tui_refresh_frame_and_register_information): Call
1747         tui_check_register_values.
1748         * tui/tui-data.h (struct tui_data_window) <data_content,
1749         data_content_count, data_type>: Remove.
1750         (enum tui_data_type): Remove.
1751
1752         * tui/tui-data.c (tui_data_window::clear_detail)
1753         (~tui_data_window): Update.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1758         declare.
1759         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1760         Rename from tui_first_data_item_displayed.  Update.
1761         (tui_data_window::refresh_all)
1762         (tui_data_window::do_scroll_vertical): Update.
1763         * tui/tui-data.h (struct tui_data_window)
1764         <first_data_item_displayed>: Declare new method.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1769         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1770         contents...
1771         (tui_initialize_static_data): ...here.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1776         (tui_display_registers_from, tui_check_register_values): Update.
1777         (tui_display_register): Remove win_info parameter; update.
1778         (tui_get_register): Change type of parameters.
1779         * tui/tui-data.h (struct tui_data_element): Remove.
1780         (union tui_which_element) <data>: Remove.
1781         <data_window>: Change type.
1782         (struct tui_data_item_window): New.
1783         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1784         case.  Add assert.
1785         (~tui_data_item_window): New destructor.
1786         (free_content_elements): Remove DATA_ITEM_WIN case.
1787
1788 2019-06-25  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1791         Remove.
1792
1793 2019-06-25  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-data.h (struct tui_command_element): Remove.
1796         (union tui_which_element) <command>: Remove.
1797         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1798         assert.
1799         (free_content_elements): Remove CMD_WIN case.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-layout.c (tui_set_layout): Update.
1804         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1805         * tui/tui-data.c (layout_def): Update.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1810         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1811         (tui_source_window_base::set_new_height): Update.
1812         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1813         Update.
1814         (tui_set_locator_fullname, tui_set_locator_info)
1815         (tui_show_frame_info): Update.
1816         * tui/tui-source.c (tui_set_source_content)
1817         (tui_source_is_displayed): Update.
1818         * tui/tui-layout.c (show_source_disasm_command, show_data)
1819         (show_source_or_disasm_and_command): Update.
1820         * tui/tui-disasm.c (tui_set_disassem_content)
1821         (tui_get_begin_asm_address): Update.
1822         * tui/tui-data.h (struct tui_locator_element): Remove.
1823         (union tui_which_element) <locator>: Remove.
1824         (struct tui_locator_window): New.
1825         (tui_locator_win_info_ptr): Change return type.
1826         * tui/tui-data.c (_locator): Change type.
1827         (tui_locator_win_info_ptr): Change return type.
1828         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1829         (tui_alloc_content): Add assert.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.c
1834         (tui_exec_info_window::maybe_allocate_content): New method.
1835         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1836         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1837         (make_source_or_disasm_window): Add cast.
1838         * tui/tui-data.h (union tui_which_element) <simple_string>:
1839         Remove.
1840         (struct tui_source_info): New.
1841         (struct tui_source_window_base) <execution_info>: Change type.
1842         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1843         case, and add assert.
1844         (tui_alloc_content): Add assert.
1845
1846 2019-06-25  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1849         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1850         * tui/tui-data.c (tui_alloc_win_info): Remove.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1855         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1856         can_highlight.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1861         make_visible_with_new_height method.
1862         (tui_win_info::make_visible_with_new_height): New method.
1863         (tui_source_window_base::do_make_visible_with_new_height)
1864         (tui_data_window::do_make_visible_with_new_height)
1865         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1866         (make_visible_with_new_height): Remove.
1867         (tui_resize_all, tui_adjust_win_heights): Use
1868         make_visible_with_new_height method.
1869         * tui/tui-data.h (struct tui_win_info)
1870         <do_make_visible_with_new_height, make_visible_with_new_height>:
1871         New methods.
1872         (struct tui_source_window_base, struct tui_data_window)
1873         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1874         methods.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1879         method.
1880         (update_tab_width): Call update_tab_width method.
1881         * tui/tui-data.h (struct tui_win_info)
1882         (struct tui_source_window_base) <update_tab_width>: New methods.
1883
1884 2019-06-25  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1887         parameter.
1888         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1889         parameter.
1890         (tui_gen_win_info::make_visible): Update.
1891         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1892         parameter.
1893         * tui/tui-data.h (enum tui_box): New enum.
1894         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1899         init_and_make_win for EXEC_INFO_WIN.
1900         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1901         longer inline.
1902         (struct tui_win_info) <~tui_win_info>: Inline.
1903         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1904         Don't declare.
1905         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1906         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1907         Remove.
1908         (tui_initialize_static_data): Update.
1909         (~tui_gen_win_info): Handle more cleanup here.
1910         (~tui_source_window_base): Delete "execution_info".
1911         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-layout.c (make_command_window): Don't set
1916         can_highlight.
1917         (show_source_disasm_command): Call the reset method.
1918         (show_data): Don't set can_highlight.  Call the reset method.
1919         (tui_gen_win_info::reset): Rename from init_gen_win_info
1920         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1921         (show_source_or_disasm_and_command): Call the reset method.
1922         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1923         (struct tui_cmd_window): Set can_highlight.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1928         from make_visible.
1929         (tui_make_visible, tui_make_invisible): Rewrite.
1930         (tui_win_info::make_visible): Remove.
1931         (tui_source_window_base::make_visible): Update.
1932         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1933         method.  Moved from...
1934         (struct tui_win_info) <make_visible>: ...here.
1935
1936 2019-06-25  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-winsource.c
1939         (tui_source_window_base::do_scroll_horizontal): Remove direction
1940         parameter.
1941         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1942         direction parameter.
1943         * tui/tui-win.c (tui_win_info::forward_scroll)
1944         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1945         (tui_win_info::right_scroll): Update.
1946         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1947         direction parameter.
1948         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1949         direction parameter.
1950         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1951         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1952         Remove direction parameter.
1953         (struct tui_source_window_base, struct tui_source_window)
1954         (struct tui_disasm_window, struct tui_data_window)
1955         (struct tui_cmd_window): Update.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-winsource.h (tui_set_exec_info_content)
1960         (tui_show_exec_info_content, tui_erase_exec_info_content)
1961         (tui_clear_exec_info_content, tui_update_exec_info): Change
1962         argument to tui_source_window_base.
1963         * tui/tui-winsource.c (tui_set_exec_info_content)
1964         (tui_show_exec_info_content, tui_erase_exec_info_content)
1965         (tui_clear_exec_info_content, tui_update_exec_info): Change
1966         argument to tui_source_window_base.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1971         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1976         check.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1981         type to void.
1982         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1983         type to void.
1984         * tui/tui-source.c (tui_set_source_content): Update.
1985         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1986
1987 2019-06-25  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-win.c (window_name_completer, tui_set_focus)
1990         (tui_all_windows_info): Use name method.
1991         * tui/tui-data.h (struct tui_gen_win_info)
1992         (struct tui_source_window, struct tui_disasm_window)
1993         (struct tui_data_window, struct tui_cmd_window) <name>: New
1994         method.
1995         (tui_win_name): Don't declare.
1996         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1997         (tui_win_name): Remove.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-winsource.h (tui_update_source_window)
2002         (tui_update_source_window_as_is): Change parameter type.
2003         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2004         to be a tui_source_window_base.
2005         (tui_update_source_window_as_is): Likewise.
2006         * tui/tui-win.c (make_visible_with_new_height): Update.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-winsource.c (tui_erase_source_content)
2011         (tui_show_source_content, tui_show_exec_info_content)
2012         (tui_erase_exec_info_content): Use refresh_window method.
2013         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2014         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2015         from tui_refresh_win.
2016         (tui_data_window::refresh_window): New method.
2017         (tui_win_info::refresh, tui_source_window_base::refresh)
2018         (tui_refresh_all): Use refresh_window method.
2019         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2020         method.
2021         * tui/tui-regs.c (tui_display_register): Call refresh_window
2022         method.
2023         * tui/tui-layout.c (show_source_disasm_command)
2024         (show_source_or_disasm_and_command): Call refresh_window method.
2025         * tui/tui-data.h (struct tui_gen_win_info)
2026         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2027         New method.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui.c (tui_rl_other_window, tui_enable)
2032         (tui_is_window_visible, tui_get_command_dimension): Update.
2033         * tui/tui-winsource.c (tui_update_source_window_as_is)
2034         (tui_clear_source_content, tui_erase_source_content)
2035         (tui_show_source_line, tui_source_window_base::refill)
2036         (tui_source_window_base::do_scroll_horizontal)
2037         (tui_source_window_base::set_is_exec_point_at)
2038         (tui_update_breakpoint_info, tui_set_exec_info_content)
2039         (tui_alloc_source_buffer, tui_line_is_displayed)
2040         (tui_addr_is_displayed): Update.
2041         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2042         (tui_check_and_display_highlight_if_needed)
2043         (tui_win_info::make_visible, tui_win_info::refresh)
2044         (tui_refresh_all): Update.
2045         * tui/tui-windata.c (tui_first_data_item_displayed)
2046         (tui_delete_data_content_windows, tui_erase_data_content)
2047         (tui_display_all_data, tui_data_window::refresh_all)
2048         (tui_check_data_values): Update.
2049         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2050         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2051         (tui_win_info::backward_scroll, tui_refresh_all_win)
2052         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2053         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2054         (tui_source_window_base::set_new_height)
2055         (tui_data_window::set_new_height)
2056         (make_invisible_and_set_new_height)
2057         (make_visible_with_new_height, new_height_ok)
2058         (parse_scrolling_args): Update.
2059         * tui/tui-stack.c (tui_show_frame_info): Update.
2060         * tui/tui-source.c (tui_set_source_content)
2061         (tui_set_source_content_nil, tui_source_is_displayed)
2062         (tui_source_window::do_scroll_vertical): Update.
2063         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2064         (tui_display_registers_from, tui_display_reg_element_at_line)
2065         (tui_check_register_values, tui_reg_command): Update.
2066         * tui/tui-layout.c (tui_default_win_height)
2067         (show_source_disasm_command, show_data, init_and_make_win)
2068         (show_source_or_disasm_and_command): Update.
2069         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2070         (tui_redisplay_readline, tui_mld_flush)
2071         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2072         (tui_getc): Update.
2073         * tui/tui-disasm.c (tui_set_disassem_content)
2074         (tui_disasm_window::do_scroll_vertical): Update.
2075         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2076         Now virtual.
2077         (struct tui_win_info): Derive from tui_gen_win_info.
2078         <~tui_win_info>: Mark as override.
2079         <generic>: Remove member.
2080         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2081         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2082         (~tui_data_window, ~tui_win_info)
2083         (tui_free_all_source_wins_content): Update.
2084         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2085
2086 2019-06-25  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-layout.c (init_and_make_win): Use new.
2089         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2090         destructor, initializers.
2091         (tui_alloc_generic_win_info): Don't declare.
2092         * tui/tui-data.c (_locator): Add argument to constructor.
2093         (source_win, disasm_win): New globals.
2094         (exec_info): Remove.
2095         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2096         Update.
2097         (tui_alloc_generic_win_info): Remove.
2098         (init_content_element): Use new.
2099         (tui_win_info::tui_win_info): Update.
2100         (free_content_elements) <case DATA_WIN>: Use delete.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2105         * tui/tui-windata.c (tui_first_data_item_displayed)
2106         (tui_delete_data_content_windows): Update.
2107         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2108         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2109         (tui_display_registers_from, tui_check_register_values): Update.
2110         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2111         pointer.
2112         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2113         window.
2114         (tui_free_data_content): Update.
2115         (free_content_elements) <case DATA_WIN>: Free the window.
2116
2117 2019-06-25  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2120         Update.
2121         * tui/tui-layout.c (make_command_window)
2122         (show_source_disasm_command, show_data, init_and_make_win)
2123         (show_source_or_disasm_and_command): Update.
2124         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2125         method.
2126         <can_highight, is_highlighted>: Now bool.
2127         (tui_set_win_highlight): Don't declare.
2128         * tui/tui-data.c (tui_set_win_highlight): Remove.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-wingeneral.c (make_visible): Remove check of window
2133         type.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-win.c (tui_win_info::max_height)
2138         (tui_cmd_window::max_height): New methods.
2139         (new_height_ok): Call max_height.
2140         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2141         <max_height>: New method.
2142
2143 2019-06-25  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-win.c (tui_source_window_base::set_new_height)
2146         (tui_data_window::set_new_height): New methods.
2147         (make_invisible_and_set_new_height): Call set_new_height method.
2148         * tui/tui-data.h (struct tui_win_info)
2149         (struct tui_source_window_base, struct tui_data_window)
2150         <set_new_height>: New method.
2151
2152 2019-06-25  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2155         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2156         tui_refresh_data_win.
2157         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2158         method.
2159         (tui_refresh_all_win): Call the refresh_all method.
2160         (tui_set_focus): Likewise.
2161         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2162         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2163         Likewise.
2164
2165 2019-06-25  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-winsource.h (tui_refill_source_window)
2168         (tui_set_is_exec_point_at): Don't declare.
2169         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2170         (tui_source_window_base::refill): Rename from
2171         tui_refill_source_window.
2172         (tui_source_window_base::do_scroll_horizontal): Update.
2173         (tui_source_window_base::set_is_exec_point_at): Rename from
2174         tui_set_is_exec_point_at.
2175         (tui_update_all_breakpoint_info): Update.
2176         * tui/tui-stack.c (tui_show_frame_info): Update.
2177         * tui/tui-layout.c (show_data): Add cast.
2178         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2179         * tui/tui-data.h (struct tui_source_window_base) <refill,
2180         set_is_exec_point_at>: New methods.
2181         (tui_source_windows, tui_add_to_source_windows): Update types.
2182         (tui_add_to_source_windows): Remove redundant declaration.
2183         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2184         (tui_source_windows): Change return type.
2185         (tui_clear_source_windows_detail): Update.
2186         (tui_add_to_source_windows): Change type of parameter.
2187         (tui_free_all_source_wins_content): Update.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-wingeneral.c (tui_win_info::refresh)
2192         (tui_source_window_base::refresh): New methods.
2193         (tui_refresh_all): Call the refresh method.
2194         * tui/tui-data.h (struct tui_win_info)
2195         (struct tui_source_window_base) <refresh>: New method.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui.h (tui_is_window_visible): Return bool.
2200         * tui/tui.c (tui_is_window_visible): Return bool.
2201         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2202         (tui_make_visible, tui_make_invisible)
2203         (tui_win_info::make_visible)
2204         (tui_source_window_base::make_visible, make_all_visible)
2205         (tui_make_all_visible, tui_make_all_invisible): Update.
2206         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2207         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2208         bool.
2209         (struct tui_win_info, struct tui_source_window_base)
2210         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2211         * tui/tui-data.c (tui_init_generic_part): Update.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2216         (tui_source_window_base::make_visible): New methods.
2217         (make_all_visible): Make method call.
2218         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2219         (struct tui_source_window_base, struct tui_cmd_window): Override
2220         make_visible.
2221         (tui_win_is_source_type): Don't declare.
2222         * tui/tui-data.c (tui_win_is_source_type): Remove.
2223
2224 2019-06-25  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2227         NULL check.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2232         Inline constructor.  Add initializers for members.
2233         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2234         constructors; now inline in class.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-regs.c (tui_show_registers): Update.
2239         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2240         bool.
2241         * tui/tui-data.c (tui_data_window::clear_detail)
2242         (tui_data_window): Update.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-windata.c (tui_display_all_data)
2247         (tui_display_data_from_line, tui_display_data_from)
2248         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2249         Update.
2250         * tui/tui-regs.c (tui_last_regs_line_no)
2251         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2252         (tui_show_registers, tui_show_register_group)
2253         (tui_display_registers_from, tui_display_reg_element_at_line)
2254         (tui_display_registers_from_line, tui_check_register_values)
2255         (tui_reg_next, tui_reg_prev): Update.
2256         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2257         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2258         tui_data_window.
2259         (struct tui_win_info) <detail>: Remove.  Add new fields from
2260         tui_data_info.
2261         (TUI_DATA_WIN): Add cast.
2262         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2263         (~tui_data_window): Simplify.
2264
2265 2019-06-25  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-layout.c (show_source_disasm_command)
2268         (show_source_or_disasm_and_command): Update.
2269         * tui/tui-io.c (update_cmdwin_start_line)
2270         (tui_redisplay_readline): Update.
2271         * tui/tui-data.h (struct tui_command_info): Remove.
2272         (struct tui_win_info) <detail>: Remove command_info member.
2273         (struct tui_data_window) <start_line>: New member, from
2274         tui_command_info.
2275         (TUI_CMD_WIN): Add casts.
2276
2277 2019-06-25  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-winsource.c (tui_update_source_window)
2280         (tui_refill_source_window)
2281         (tui_source_window_base::do_scroll_horizontal)
2282         (tui_update_breakpoint_info, tui_set_exec_info_content)
2283         (tui_show_exec_info_content, tui_erase_exec_info_content)
2284         (tui_clear_exec_info_content): Update.
2285         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2286         Update.
2287         * tui/tui-win.c (make_invisible_and_set_new_height)
2288         (make_visible_with_new_height): Update.
2289         * tui/tui-source.c (tui_set_source_content)
2290         (tui_show_symtab_source): Update.
2291         * tui/tui-layout.c (extract_display_start_addr)
2292         (show_source_disasm_command, show_data)
2293         (make_source_or_disasm_window)
2294         (show_source_or_disasm_and_command): Update.
2295         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2296         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2297         "gdbarch".
2298         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2299         to tui_source_window_base.
2300         (struct tui_win_info) <detail>: Remove source_info member.
2301         (struct tui_source_window_base) <has_locator>: Inline.
2302         Move contents from tui_source_info; rename has_locator member to
2303         m_has_locator.
2304         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2305         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2306         header file.
2307         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2308         Simplify.
2309         (tui_free_all_source_wins_content): Cast to
2310         tui_source_window_base.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-win.c (make_invisible_and_set_new_height)
2315         (make_visible_with_new_height): Call has_locator method.
2316         * tui/tui-layout.c (show_source_disasm_command, show_data)
2317         (show_source_or_disasm_and_command): Update for bool change.
2318         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2319         (tui_win_info) <has_locator>: New method.
2320         (struct tui_source_window_base) <has_locator>: New method.
2321         (tui_win_has_locator): Don't declare.
2322         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2323         from tui_win_has_locator.
2324         (tui_source_window_base): Use false, not FALSE.
2325
2326 2019-06-25  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2329         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2330         clear_detail method directly.
2331         (tui_clear_win_detail): Remove.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2336         "this", not TUI_DISASM_WIN.
2337
2338 2019-06-25  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2341         declare.
2342         * tui/tui-winsource.c
2343         (tui_source_window_base::do_scroll_horizontal): Rename from
2344         tui_horizontal_source_scroll.
2345         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2346         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2347         from tui_vertical_data_scroll.
2348         * tui/tui-win.h (tui_scroll): Don't declare.
2349         * tui/tui-win.c (tui_win_info::forward_scroll)
2350         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2351         (tui_win_info::right_scroll): Rename and update.
2352         (tui_scroll_forward_command, tui_scroll_backward_command)
2353         (tui_scroll_left_command, tui_scroll_right_command): Update.
2354         (tui_scroll): Remove.
2355         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2356         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2357         from tui_vertical_source_scroll.
2358         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2359         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2360         from tui_vertical_disassem_scroll.
2361         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2362         do_scroll_horizontal>: New methods.
2363         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2364         Likewise.
2365         (struct tui_source_window_base): Add do_scroll_horizontal.
2366         (struct tui_source_window, struct tui_disasm_window): Add
2367         do_scroll_vertical.
2368         (struct tui_data_window, struct tui_cmd_window): Add
2369         do_scroll_horizontal and do_scroll_vertical.
2370         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-data.h (struct tui_source_window_base): New struct.
2375         (struct tui_source_window): Derive from tui_source_window_base.
2376         (struct tui_disasm_window): New struct.
2377         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2378         from tui_source_window::clear_detail.
2379         (tui_source_window_base): Rename from tui_source_window.
2380         (~tui_source_window_base): Rename from ~tui_source_window.
2381         (tui_alloc_win_info): Create a tui_disasm_window.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-data.h (struct tui_source_window)
2386         (struct tui_data_window): Declare destructors.
2387         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2388         destructors.
2389         (tui_win_info): Simplify.
2390
2391 2019-06-25  Tom Tromey  <tom@tromey.com>
2392
2393         * tui/tui-winsource.c (tui_display_main)
2394         (tui_update_source_windows_with_addr)
2395         (tui_update_all_breakpoint_info): Update.
2396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2397         (new_height_ok, parse_scrolling_args): Update.
2398         * tui/tui-stack.c (tui_show_frame_info): Update.
2399         * tui/tui-data.h (struct tui_list): Remove.
2400         (tui_source_windows): Return a reference to a std::vector.
2401         * tui/tui-data.c (source_windows): Now a std::vector.
2402         (tui_source_windows): Change return type.
2403         (tui_clear_source_windows): Rewrite.
2404         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2405         (tui_free_all_source_wins_content): Rewrite.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2410         (struct tui_data_window, struct tui_cmd_window): Declare
2411         clear_detail method.
2412         * tui/tui-data.c (tui_source_window::clear_detail)
2413         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2414         methods.
2415         (tui_clear_win_detail): Simplify.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-layout.c (make_source_window, make_disasm_window)
2420         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2421         Return the new window.
2422         (show_source_disasm_command, show_data)
2423         (show_source_or_disasm_and_command): Update.
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2428         parameter.  Return the new window.
2429         (show_source_disasm_command): Update and remove NULL check.
2430         (show_source_or_disasm_and_command): Update.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-data.h (struct tui_win_info): Make constructor
2439         protected.  Make destructor virtual.  Add initializers.
2440         (tui_source_window, tui_data_window, tui_cmd_window): New
2441         classes.
2442         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2443         constructor.  Add "type" parameter.
2444         (tui_source_window, tui_data_window, tui_cmd_window): New
2445         constructors.
2446         (tui_alloc_win_info): Instantiate the appropriate subclass.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-win.c (tui_resize_all): Use delete.
2451         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2452         destructor.
2453         (tui_free_window): Don't declare.
2454         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2455         Update.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-data.h (struct tui_win_info): Add constructor.
2460         * tui/tui-data.c (tui_alloc_win_info): Use new.
2461         (tui_free_window): Use delete.
2462
2463 2019-06-22  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2466         declare.
2467         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2468
2469 2019-06-22  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2472         declare.
2473         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2474
2475 2019-06-22  Tom de Vries  <tdevries@suse.de>
2476
2477         * dwarf2read.c (create_addrmap_from_aranges)
2478         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2479         instead of '%zu'.
2480
2481 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2482
2483         * dwarf2read.h (dwarf2_section_info_def): Remove.
2484         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2485         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2486         std::vector<dwarf2_section_info>.
2487         (struct dwo_file) <~dwo_file>: Remove.
2488         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2489         types field.
2490         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2491         (dwarf2_read_debug_names): Likewise.
2492         (create_debug_types_hash_table): Change parameter type to
2493         array_view, adjust code accordingly.
2494         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2495         (partial_die_info::fixup): Likewise.
2496         (determine_prefix): Likewise.
2497         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2498
2499 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2500
2501         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2502         gdb_bfd_ref_ptr.
2503         <~dwo_file>: Remove call to gdb_bfd_unref.
2504         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2505         gdb_bfd_ref_ptr::get.
2506
2507 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2508
2509         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2510         type to htab_up.
2511         * dwarf2read.c (struct dwo_file): Initialize fields.
2512         <~dwo_file>: New.
2513         (free_dwo_file): Remove, move content to ~dwo_file.
2514         (struct dwo_file_deleter): Remove.
2515         (dwo_file_up>: Remove custom deleter.
2516         (free_dwo_files): Remove.
2517         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2518         dwo_files.
2519         (process_skeletonless_type_units): Call unique_ptr::get.
2520         (allocate_dwo_file_hash_table): Add deleter to created hash
2521         table.  Change return type to htab_up.
2522         (lookup_dwo_file_slot): Don't memset dwo_file, call
2523         unique_ptr::get.
2524         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2525         (create_dwo_unit_in_dwp_v2): Likewise.
2526         (open_and_init_dwo_file): Likewise.
2527         (free_dwo_file_from_slot): Remove.
2528
2529 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2530
2531         * dwarf2read.h (struct dwarf2_section_info) <readin,
2532         is_virtual>: Change type to bool.
2533         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2534         true instead of 1.
2535
2536 2019-06-19  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-data.h (tui_init_content_element): Don't declare.
2539
2540 2019-06-19  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-data.h (tui_init_win_info): Don't declare.
2543
2544 2019-06-19  Tom de Vries  <tdevries@suse.de>
2545
2546         * dwarf2read.h (abstract_to_concrete): Change type to
2547         std::unordered_map<sect_offset, std::vector<sect_offset>,
2548         gdb::hash_enum<sect_offset>>.
2549
2550 2019-06-19  Tom Tromey  <tromey@adacore.com>
2551
2552         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2553         EVAL_AVOID_SIDE_EFFECTS specially.
2554
2555 2019-06-19  Tom Tromey  <tromey@adacore.com>
2556
2557         * source-cache.c (highlighter): New global.
2558         (source_cache::get_source_lines): Create a highlighter on demand.
2559
2560 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * defs.h (deprecated_interactive_hook): Delete declaration.
2563         * interps.c (clear_interpreter_hooks): Remove use of
2564         deprecated_interactive_hook.
2565         * top.c (deprecated_interactive_hook): Delete definition.
2566         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2567
2568 2019-06-18  Tom de Vries  <tdevries@suse.de>
2569
2570         PR gdb/24515
2571         * dwarf2read.h (abstract_to_concrete): Change type from
2572         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2573         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2574         * dwarf2read.c (read_variable): Update.
2575         (dwarf2_fetch_die_loc_sect_off): Update.
2576
2577 2019-06-17  Tom de Vries  <tdevries@suse.de>
2578
2579         PR gdb/24617
2580         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2581         accessing parent[parent_len - 1].
2582
2583 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2584
2585         PR gdb/24364
2586         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2587         call dtrace_process_dof with NULL dof.
2588
2589 2019-06-16  Tom de Vries  <tdevries@suse.de>
2590
2591         PR gdb/24445
2592         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2593
2594 2019-06-16  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2597         (make_all_visible): Use address of member.
2598
2599 2019-06-16  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2602         (tui_free_window, free_content, free_content_elements): Remove
2603         unnecessary cast.
2604         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2605         cast.
2606         * tui/tui-regs.c (tui_show_register_group)
2607         (tui_display_registers_from, tui_display_reg_element_at_line):
2608         Remove unnecessary cast.
2609
2610 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * linux-nat.c (normal_mask): Delete.
2613         (_initialize_linux_nat): Don't initialise normal_mask.
2614
2615 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2616
2617         PR gdb/24445
2618         * dwarf-index-write.h (write_psymtabs_to_index): Add
2619         dwz_basename parameter.
2620         * dwarf-index-write.c (write_gdbindex): Move file writing to
2621         write_gdbindex_1.  Change return type void.
2622         (assert_file_size): Move up, remove filename parameter.
2623         (write_gdbindex_1): New function.
2624         (write_debug_names): Change return type to void, call
2625         assert_file_size.
2626         (struct index_wip_file): New struct.
2627         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2628         file logic to index_wip_file.  Write index for dwz file if
2629         needed.
2630         (save_gdb_index_command): Pass basename of dwz file, if present.
2631         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2632         build-id of dwz file, if present.
2633         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2634         (dwarf2_get_dwz_file): Likewise.
2635         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2636         (dwarf2_get_dwz_file): Likewise.
2637
2638 2019-06-16  Tom Tromey  <tom@tromey.com>
2639
2640         * coffread.c (process_coff_symbol): Use xstrdup.
2641         * value.c (create_internalvar): Use xstrdup.
2642
2643 2019-06-16  Tom Tromey  <tom@tromey.com>
2644
2645         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2646         * breakpoint.c (stopin_command, stopat_command)
2647         (until_break_command, decode_location_default): Remove unnecessary
2648         cast.
2649         * utils.c (subset_compare): Remove unnecessary cast.
2650         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2651         cast.
2652         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2653         cast.
2654         * infcmd.c (path_command): Remove unnecessary cast.
2655         * coffread.c (decode_type): Remove unnecessary cast.
2656         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2657         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2658         * tui/tui-stack.c (tui_show_locator_content)
2659         (tui_show_frame_info): Remove unnecessary cast.
2660         * tui/tui-win.c (tui_scroll_forward_command)
2661         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2662         (parse_scrolling_args): Remove unnecessary cast.
2663         * tui/tui-data.c (init_win_info, tui_del_window)
2664         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2665         (free_content_elements): Remove unnecessary cast.
2666         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2667         unnecessary cast.
2668         * tui/tui-source.c (tui_set_source_content)
2669         (tui_vertical_source_scroll): Remove unnecessary cast.
2670         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2671         cast.
2672         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2673         * tui/tui-regs.c (tui_display_registers_from)
2674         (tui_display_register): Remove unnecessary cast.
2675         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2676         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2677         (make_visible): Remove unnecessary cast.
2678         * tui/tui-winsource.c (tui_erase_source_content)
2679         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2680         unnecessary cast.
2681         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2682         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2683         * stabsread.c (read_type, read_array_type, read_range_type):
2684         Remove unnecessary cast.
2685         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2686         (parse_symbol, parse_type, upgrade_type, parse_external)
2687         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2688         unnecessary cast.
2689         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2690
2691 2019-06-16  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-data.c (tui_alloc_generic_win_info)
2694         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2695         checks.
2696
2697 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2698             Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * f-typeprint.c (f_print_type): Don't return early for not
2701         associated or not allocated types.
2702         (f_type_print_varspec_suffix): Add print_rank parameter and print
2703         ranks of array types in case they dangling.
2704         (f_type_print_base): Add print_rank parameter.
2705
2706 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * NEWS: Mention new MI commands.
2709         * break-catch-throw.c (enum exception_event_kind): Move to
2710         breakpoint.h.
2711         (print_mention_exception_catchpoint): Output text as a single
2712         message.
2713         (catch_exception_command_1): Rename to...
2714         (catch_exception_event): ...this, make non-static, update header
2715         command, and change some parameter types.
2716         (catch_catch_command): Update for changes to
2717         catch_exception_command_1.
2718         (catch_throw_command): Likewise.
2719         (catch_rethrow_command): Likewise.
2720         * breakpoint.c (enum exception_event_kind): Delete.
2721         * breakpoint.h (enum exception_event_kind): Moved here from
2722         break-catch-throw.c.
2723         (catch_exception_event): Declare.
2724         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2725         (mi_cmd_catch_throw): New function.
2726         (mi_cmd_catch_rethrow): New function.
2727         (mi_cmd_catch_catch): New function.
2728         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2729         'catch-catch' entries.
2730         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2731         (mi_cmd_catch_rethrow): Declare.
2732         (mi_cmd_catch_catch): Declare.
2733
2734 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * annotate.c (annotate_source_line): Change return type to void,
2737         update implementation to match.
2738         * annotate.h (annotate_source_line): Change return type to void,
2739         update header comment.
2740         * stack.c (print_frame_info): Don't change what frame information
2741         is printed based on whether annotations are on or not.
2742
2743 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2746         (annotate_source): Make static.
2747         (annotate_source_line): Moved from source.c and renamed from
2748         identify_source_line.  Update the return type.
2749         * annotate.h (annotate_source): Delete declaration.
2750         (annotate_source_line): Declaration moved from source.h, and
2751         renamed from identify_source_line.  Return type updated.
2752         * source.c (identify_source_line): Moved to annotate.c and renamed
2753         to annotate_source_line.
2754         (info_line_command): Remove check of annotation_level.
2755         * source.h (identify_source_line): Move declaration to annotate.h
2756         and rename to annotate_source_line.
2757         * stack.c: Add 'annotate.h' include.
2758         (print_frame_info): Remove check of annotation_level before
2759         calling annotate_source_line.
2760
2761 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2762
2763         * source-cache.c (source_cache::get_plain_source_lines): Use
2764         open_source_file_with_line_charpos instead of just
2765         open_source_file, remove call to find_source_lines.
2766         (source_cache::get_source_lines): Likewise.
2767         * source.c (find_source_lines): Make static.
2768         (get_filename_and_charpos): Renamed into...
2769         (open_source_file_with_line_charpos): ..this along with changes to
2770         return a scoped_fd, and some other minor clean ups.
2771         (identify_source_line): Use open_source_file_with_line_charpos.
2772         (search_command_helper): Use open_source_file_with_line_charpos
2773         instead of just open_source_file, remove call to
2774         find_source_lines.
2775         * source.h (open_source_file_with_line_charpos): Declare new
2776         function.
2777         (find_source_lines): Delete declaration.
2778
2779 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * source.c (get_filename_and_charpos): Remove fullname
2782         parameter.
2783         (identify_source_line): Update call to get_filename_and_charpos.
2784
2785 2019-06-14  Tom Tromey  <tromey@adacore.com>
2786
2787         PR gdb/24502:
2788         * ui-style.h (skip_ansi_escape): Update comment.
2789         * ui-file.h (class no_terminal_escape_file): New class.
2790         * ui-file.c (no_terminal_escape_file::write)
2791         (no_terminal_escape_file::puts): New methods.
2792         * cli/cli-logging.c (handle_redirections): Use
2793         no_terminal_escape_file.
2794
2795 2019-06-14  Tom Tromey  <tromey@adacore.com>
2796
2797         * NEWS: Move convenience variable news above Python news.
2798
2799 2019-06-14  Tom Tromey  <tom@tromey.com>
2800
2801         * gnulib: Move directory to top-level.
2802         * configure.ac: Don't configure gnulib.
2803         * configure: Rebuild.
2804         * common/common-defs.h: Use new path to gnulib.
2805         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2806         (GNULIB_H): Remove.
2807         (INCGNU): Look in new gnulib location.
2808         (HFILES_NO_SRCDIR): Remove gnulib files.
2809         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2810         (generated_files): Remove GNULIB_H.
2811         ($(LIBGNU), all-lib): Remove targets.
2812         (distclean): Don't mention GNULIB_BUILDDIR.
2813         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2814
2815 2019-06-14  Tom Tromey  <tromey@adacore.com>
2816
2817         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2818         Warn if symbol file does not provide any symbols.
2819
2820 2019-06-14  Tom Tromey  <tromey@adacore.com>
2821
2822         * source.c (find_and_open_source): Respect basenames_may_differ.
2823
2824 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * annotate.c (annotate_breakpoints_invalid): Make use of
2827         scoped_restore_terminal_state.
2828         (annotate_frames_invalid): Likewise.
2829
2830 2019-06-14  Tom Tromey  <tromey@adacore.com>
2831
2832         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2833         allow assignment to an internalvar.
2834
2835 2019-06-14  Tom Tromey  <tromey@adacore.com>
2836
2837         * ada-lex.l: Allow "_" in attribute names.
2838
2839 2019-06-14  Tom Tromey  <tromey@adacore.com>
2840
2841         PR gdb/24653:
2842         * regcache.c (registers_changed): Don't call alloca.
2843         * top.c (execute_command): Don't call alloca.
2844
2845 2019-06-13  Pedro Alves  <palves@redhat.com>
2846
2847         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2848         'expression'.  When parsing an expression, error out if there's
2849         junk after "unlimited".
2850         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2851         (do_set_command): Adjust calls to is_unlimited_literal.
2852
2853 2019-06-13  Pedro Alves  <palves@redhat.com>
2854
2855         * compile/compile.c (make_compile_options_def_group): Add braces
2856         around array_view initializer.
2857         * thread.c (make_thread_apply_all_options_def_group)
2858         (make_thread_apply_all_options_def_group): Likewise.
2859
2860 2019-06-13  Pedro Alves  <palves@redhat.com>
2861
2862         * NEWS (New commands): Mention "maint test-options
2863         require-delimiter", "maint test-options unknown-is-error", "maint
2864         test-options unknown-is-operand" and "maint show
2865         test-options-completion-result".
2866         (New command options, command completion): New section.
2867         (Completion improvements): New section.
2868         Mention that you can abbreviate "unlimited".
2869
2870 2019-06-13  Pedro Alves  <palves@redhat.com>
2871
2872         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2873         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2874         * unittests/cli-utils-selftests.c (test_parse_flags)
2875         (test_parse_flags_qcs): Delete.
2876         (test_cli_utils): Don't call deleted functions.
2877
2878 2019-06-13  Pedro Alves  <palves@redhat.com>
2879
2880         * thread.c: Include "cli/cli-option.h".
2881         (tp_array_compar_ascending): Global.
2882         (tp_array_compar): Delete function.
2883         (tp_array_compar_ascending, tp_array_compar_descending): New
2884         functions.
2885         (ascending_option_def, qcs_flag_option_def)
2886         (thr_qcs_flags_option_defs)
2887         (make_thread_apply_all_options_def_group)
2888         (make_thread_apply_options_def_group): New.
2889         (thread_apply_all_command): Use gdb::option::process_options.
2890         (thread_apply_command_completer)
2891         (thread_apply_all_command_completer): New.
2892         (thread_apply_command): Use gdb::option::process_options.
2893         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2894         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2895         to generate help text of "thread apply".  Adjust "taas"'s help.
2896         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2897         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2898
2899 2019-06-13  Pedro Alves  <palves@redhat.com>
2900
2901         * thread.c (thread_apply_command): Check for invalid TID with
2902         isdigit instead of !isalpha.
2903
2904 2019-06-13  Pedro Alves  <palves@redhat.com>
2905
2906         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2907         (validate_flags_qcs): New.
2908         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2909         (validate_flags_qcs): Declare.
2910         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2911         (make_frame_apply_options_def_group): New.
2912         (frame_apply_command_count): Process options with
2913         gdb::option::process_options.
2914         (frame_apply_completer): New.
2915         (frame_apply_level_completer, frame_apply_all_completer)
2916         (frame_apply_completer): New.
2917         (_initialize_stack): Update help of "frame apply", "frame apply
2918         level", "frame apply all" and "faas" to mention supported options
2919         and install command completers.
2920         * stack.h (frame_apply_all_completer): Declare.
2921         * thread.c: Include "stack.h".
2922         (tfaas_command): Add "--".
2923         (_initialize_thread): Update help "tfaas" to mention supported
2924         options and install command completer.
2925
2926 2019-06-13  Pedro Alves  <palves@redhat.com>
2927
2928         * completer.c (complete_nested_command_line): New.
2929         (gdb_completion_word_break_characters_throw): Add assertion.
2930         * completer.h (complete_nested_command_line): Declare.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * stack.c (parse_backtrace_qualifiers): New.
2935         (backtrace_command): Use it.
2936         (backtrace_command_completer): Complete on qualifiers.
2937
2938 2019-06-13  Pedro Alves  <palves@redhat.com>
2939
2940         * frame.c: Include "cli/cli-option.h.
2941         (user_set_backtrace_options): New.
2942         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2943         Delete.
2944         (get_prev_frame): Adjust.
2945         (boolean_option_def, uinteger_option_def)
2946         (set_backtrace_option_defs): New.
2947         (_initialize_frame): Adjust and use
2948         gdb::option::add_setshow_cmds_for_options to install "set
2949         backtrace past-main" and "set backtrace past-entry".
2950         * frame.h: Include "cli/cli-option.h".
2951         (struct frame_print_options): Forward declare.
2952         (print_frame_arguments_all, print_frame_arguments_scalars)
2953         (print_frame_arguments_none): Declare.
2954         (print_entry_values): Delete declaration.
2955         (struct frame_print_options, user_frame_print_options): New.
2956         (struct set_backtrace_options): New.
2957         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2958         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2959         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2960         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2961         (list_args_or_locals): Add frame_print_options parameter.
2962         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2963         * python/py-framefilter.c (enumerate_args): Pass down
2964         USER_FRAME_PRINT_OPTIONS.
2965         * stack.c: Include "cli/cli-option.h".
2966         (print_frame_arguments_all, print_frame_arguments_scalars)
2967         (print_frame_arguments_none): Declare.
2968         (print_raw_frame_arguments, print_entry_values): Delete.
2969         (user_frame_print_options): New.
2970         (boolean_option_def, enum_option_def, frame_print_option_defs):
2971         New.
2972         (struct backtrace_cmd_options): New.
2973         (bt_flag_option_def): New.
2974         (backtrace_command_option_defs): New.
2975         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2976         (print_frame_arg, read_frame_arg, print_frame_args)
2977         (print_frame_info, print_frame): Add frame_print_options parameter
2978         and use it.
2979         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2980         (backtrace_command_1): Add frame_print_options and
2981         backtrace_cmd_options parameters and use them.
2982         (make_backtrace_options_def_group): New.
2983         (backtrace_command): Process command options with
2984         gdb::option::process_options.
2985         (backtrace_command_completer): New.
2986         (_initialize_stack): Extend "backtrace"'s help to mention
2987         supported options.  Install completer for "backtrace".
2988         Install some settings commands with add_setshow_cmds_for_options.
2989
2990 2019-06-13  Pedro Alves  <palves@redhat.com>
2991
2992         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2993         and that "set/show print raw frame-arguments" are now deprecated.
2994
2995         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2996         command.
2997         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2998         * stack.c (_initialize_stack): Install "set/show print
2999         raw-frame-arguments", and deprecate "set/show print raw
3000         frame-arguments".
3001         * valprint.c (_initialize_valprint): Deprecate "set/show print
3002         raw".
3003
3004 2019-06-13  Pedro Alves  <palves@redhat.com>
3005
3006         * compile/compile.c (struct compile_options): New.
3007         (compile_flag_option_def, compile_command_option_defs)
3008         (make_compile_options_def_group): New.
3009         (compile_file_command): Handle options with
3010         gdb::option::process_options.
3011         (compile_file_command_completer): New function.
3012         (compile_code_command): Handle options with
3013         gdb::option::process_options.
3014         (compile_code_command_completer): New function.
3015         (_initialize_compiler): Install completers for "compile code" and
3016         "compile file".  Mention available options in "compile code" and
3017         "compile code"'s help.
3018         * completer.c (advance_to_completion_word): New, factored out from
3019         ...
3020         (advance_to_expression_complete_word_point): ... this.
3021         (advance_to_filename_complete_word_point): New.
3022         * completer.h (advance_to_filename_complete_word_point): New
3023         declaration.
3024
3025 2019-06-13  Pedro Alves  <palves@redhat.com>
3026
3027         * compile/compile.c: Include "cli/cli-option.h".
3028         (compile_print_value): Scope data pointer is now a
3029         value_print_options pointer; adjust.
3030         (compile_print_command): Process options.  Scope data pointer is
3031         now a value_print_options pointer; adjust.
3032         (_initialize_compile): Update "compile print"'s help to include
3033         supported options.  Install a completer for "compile print".
3034         * cp-valprint.c (show_vtblprint, show_objectprint)
3035         (show_static_field_print): Delete.
3036         (_initialize_cp_valprint): Don't install "set print
3037         static-members", "set print vtbl", "set print object" here.
3038         * printcmd.c: Include "cli/cli-option.h" and
3039         "common/gdb_optional.h".
3040         (print_command_parse_format): Rework to fill in a
3041         value_print_options instead of a format_data.
3042         (print_value): Change parameter type from format_data pointer to
3043         value_print_options reference.  Adjust.
3044         (print_command_1): Process options.  Adjust to pass down a
3045         value_print_options.
3046         (print_command_completer): New.
3047         (_initialize_printcmd): Install print_command_completer as
3048         handle_brkchars completer for the "print" command.  Update
3049         "print"'s help to include supported options.
3050         * valprint.c: Include "cli/cli-option.h".
3051         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3052         here from cp-valprint.c.
3053         (boolean_option_def, uinteger_option_def)
3054         (value_print_option_defs, make_value_print_options_def_group):
3055         New.  Use gdb::option::add_setshow_cmds_for_options to install
3056         "set print elements", "set print null-stop", "set print repeats",
3057         "set print pretty", "set print union", "set print array", "set
3058         print address", "set print symbol", "set print array-indexes".
3059         * valprint.h: Include <string> and "cli/cli-option.h".
3060         (make_value_print_options_def_group): Declare.
3061         (print_value): Change parameter type from format_data pointer to
3062         value_print_options reference.
3063         (print_command_completer): Declare.
3064
3065 2019-06-13  Pedro Alves  <palves@redhat.com>
3066
3067         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3068         (COMMON_SFILES): Add maint-test-settings.c.
3069         * cli/cli-decode.c (boolean_enums): New global, factored out from
3070         ...
3071         (add_setshow_boolean_cmd): ... here.
3072         * cli/cli-decode.h (boolean_enums): Declare.
3073         * cli/cli-option.c: New file.
3074         * cli/cli-option.h: New file.
3075         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3076         factored out from ...
3077         (parse_cli_boolean_value(const char *)): ... this.
3078         (is_unlimited_literal): Change parameter type to pointer to
3079         pointer.  Adjust and advance ARG pointer.
3080         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3081         (parse_cli_var_enum): New, factored out from ...
3082         (do_set_command): ... this.  Adjust.
3083         * cli/cli-setshow.h (parse_cli_boolean_value)
3084         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3085         (parse_cli_var_enum): Declare.
3086         * cli/cli-utils.c: Include "cli/cli-option.h".
3087         (get_ulongest): New.
3088         * cli/cli-utils.h (get_ulongest): Declare.
3089         (check_for_argument): New overloads.
3090         * maint-test-options.c: New file.
3091
3092 2019-06-13  Pedro Alves  <palves@redhat.com>
3093
3094         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3095         parse a range if "-" is at the end of the string.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * cli/cli-setshow.c (parse_auto_binary_operation)
3100         (parse_cli_boolean_value): Don't allow "o".
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3105         * NEWS: Mention maint test-settings KIND.
3106         * maint-test-settings.c: New file.
3107
3108 2019-06-13  Pedro Alves  <palves@redhat.com>
3109
3110         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3111         completer.
3112         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3113         "set" completers.
3114
3115 2019-06-13  Pedro Alves  <palves@redhat.com>
3116
3117         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3118         after item.
3119
3120 2019-06-13  Pedro Alves  <palves@redhat.com>
3121
3122         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3123
3124 2019-06-13  Pedro Alves <palves@redhat.com>
3125
3126         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3127         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3128         call.
3129         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3130         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3131         calls.
3132         (check_for_argument): Skip spaces after argument.
3133
3134 2019-06-13  Pedro Alves  <palves@redhat.com>
3135
3136         * thread.c (thread_apply_command): Adjust TID parsing.
3137         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3138         detected before end of string.
3139         (tid_is_in_list): Error out if LIST is invalid.
3140
3141 2019-06-13  Pedro Alves  <palves@redhat.com>
3142
3143         * completer.c (complete_line_internal_1): Rewind completion word
3144         point.
3145         (completion_tracker::advance_custom_word_point_by): Change
3146         parameter type to int.
3147         * completer.h (completion_tracker::advance_custom_word_point_by):
3148         Likewise.
3149
3150 2019-06-13  Pedro Alves  <palves@redhat.com>
3151
3152         * completer.c (advance_to_completion_word): Handle delimiters.
3153
3154 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3155
3156         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3157
3158 2019-06-11  Tom Tromey  <tom@tromey.com>
3159
3160         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3161         (xmalloc_failed): Move to alloc.c.
3162         * alloc.c: New file.
3163         * Makefile.in (COMMON_SFILES): Add alloc.c.
3164
3165 2019-06-11  Tom Tromey  <tom@tromey.com>
3166
3167         * nat/linux-waitpid.c: Don't include server.h.
3168         (linux_debug): Remove.
3169         (my_waitpid): Update.
3170
3171 2019-06-11  Tom Tromey  <tromey@adacore.com>
3172
3173         * infcall.c (_initialize_infcall): Remove trailing newline from
3174         help.
3175         * user-regs.c (_initialize_user_regs): Remove trailing newline
3176         from help.
3177         * typeprint.c (_initialize_typeprint): Remove trailing newline
3178         from help.
3179         * reverse.c (_initialize_reverse): Remove trailing newlines from
3180         help.
3181         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3182         from help.
3183         * language.c (add_set_language_command): Remove trailing newline
3184         from help.
3185         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3186         help.
3187         * disasm.c (_initialize_disasm): Remove trailing newline from
3188         help.
3189         * top.c (init_main): Remove trailing newline from help.
3190         * interps.c (_initialize_interpreter): Remove trailing newline
3191         from help.
3192         * btrace.c (_initialize_btrace): Remove trailing newlines from
3193         help.
3194         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3195         from help.
3196         * python/python.c (_initialize_python): Remove trailing newline
3197         from help.
3198         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3199         help.
3200         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3201         from help.  Reformat some text.
3202         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3203         from help.
3204         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3205         newline from help.
3206
3207 2019-06-11  Tom Tromey  <tromey@adacore.com>
3208
3209         * darwin-nat.c (darwin_decode_exception_message)
3210         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3211
3212 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * valops.c (value_slice): Check for not allocated or not
3215         associated values.
3216
3217 2019-06-10  Tom de Vries  <tdevries@suse.de>
3218
3219         PR gdb/24618
3220         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3221         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3222         invalid.
3223
3224 2019-06-10  Tom de Vries  <tdevries@suse.de>
3225
3226         PR gdb/24611
3227         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3228         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3229
3230 2019-06-10  Tom de Vries  <tdevries@suse.de>
3231
3232         PR symtab/24545
3233         * symtab.c (struct demangled_name_entry): Add language field.
3234         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3235         static minimal symbol".  Set and use language field.
3236
3237 2019-06-10  Tom Tromey  <tromey@adacore.com>
3238
3239         * ada-lang.c (_initialize_ada_language): Update help text.
3240
3241 2019-06-10  Tom Tromey  <tromey@adacore.com>
3242
3243         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3244         with a newline.
3245         * guile/guile.c (handle_boot_error): Don't end warning with a
3246         newline.
3247         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3248         warning with a newline.
3249         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3250         newline.
3251         (s12z_frame_cache): Likewise.
3252         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3253         a newline.
3254         * solib-svr4.c (disable_probes_interface): Don't end warning with
3255         a newline.
3256         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3257         newline.
3258         * python/python.c (do_finish_initialization): Don't end warning
3259         with a newline.
3260
3261 2019-06-10  Tom Tromey  <tom@tromey.com>
3262
3263         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3264         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3265         gdbpy_enter.
3266
3267 2019-06-10  Tom Tromey  <tromey@adacore.com>
3268
3269         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3270         data.
3271         (elf_new_init): Don't call stabsread_new_init.
3272         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3273         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3274         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3275
3276 2019-06-10  Tom de Vries  <tdevries@suse.de>
3277
3278         PR symtab/16264
3279         PR symtab/24517
3280         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3281
3282 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3283
3284         * source.c (find_and_open_source): Also rewrite relative file
3285         names.
3286
3287 2019-04-26  Amos Bird  <amosbird@gmail.com>
3288
3289         * annotate.c (annotate_thread_exited): Add "thread-exited"
3290         annotation.
3291
3292 2019-06-06  Tom Tromey  <tromey@adacore.com>
3293
3294         * maint.h (class scoped_command_stats): Use
3295         DISABLE_COPY_AND_ASSIGN.
3296         <print_time>: New method.
3297         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3298         print_time.
3299         (scoped_command_stats::print_time): New method.
3300
3301 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3302
3303         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3304         instructions of lengths 6 or 8 bytes.
3305
3306 2019-06-04  Pedro Alves  <palves@redhat.com>
3307
3308         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3309
3310         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3311         * breakpoint.c (condition_completer): Likewise.
3312         * cli/cli-dump.c (scan_expression): Likewise.
3313         * common/filestuff.c (mkdir_recursive): Likewise.
3314         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3315         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3316         (gdb_abspath): Likewise.
3317         * compile/compile-cplus-types.c
3318         (compile_cplus_instance::decl_name): Likewise.
3319         * completer.c (complete_explicit_location):
3320         (signal_completer, reg_or_group_completer_1): Likewise.
3321         * cp-support.c (cp_remove_params_if_any): Likewise.
3322         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3323         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3324         * infcmd.c (strip_bg_char): Likewise.
3325         * linespec.c (copy_token_string): Likewise.
3326         * mi/mi-main.c (output_cores): Likewise.
3327         * psymtab.c (psymtab_search_name):
3328         * symfile.c (test_set_ext_lang_command): Likewise.
3329         * target.c (target_fileio_read_stralloc): Likewise.
3330         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3331         * value.c (complete_internalvar): Likewise.
3332
3333 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3334
3335         Add objfile property to gdb.Type.
3336         * NEWS: Mention Python API addition.
3337         * python/py-type.c (typy_get_objfile): New method.
3338
3339 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3340
3341         * NEWS: Mention the new set|show style [title|highlight].
3342         Mention changes to "show style", "help" and "apropos".
3343
3344 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3345
3346         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3347         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3348         instead of print_help_for_command.
3349         (print_doc_of_command): New function.
3350         (help_list): Add 'apropos -v word' suggestion.
3351         (print_help_for_command): Style the command name using title style.
3352         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3353         (_initialize_cli_cmds): Describe -v in apropos_command help.
3354
3355 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3356
3357         * cli/cli-style.h (cli_style_option): Add name in constructor,
3358         add m_name class member, add constructor with intensity,
3359         add name class function.
3360         (cli_style_option::add_setshow_commands): Remove name argument.
3361         (highlight_style, title_style): New styles.
3362         * cli/cli-style.c (do_show): New function that shows a style
3363         characteristic styling the style name with itself.
3364         (set_style_name): New function.
3365         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3366         Update all callers according to the changes in cli/cli-style.h.
3367         * utils.h (fputs_highlighted): New function.
3368         * utils.c (fputs_highlighted): Likewise.
3369
3370 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3371
3372         * NEWS: Mention new pipe command and new convenience variables.
3373
3374 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3375
3376         * cli/cli-cmds.c (pipe_command): New function.
3377         (_initialize_cli_cmds): Call add_com for pipe_command.
3378         Define | as an alias for pipe.
3379         (exit_status_set_internal_vars): New function.
3380         (shell_escape): Call exit_status_set_internal_vars.
3381         cli/cli-decode.c (find_command_name_length): Recognize | as
3382         a single character command.
3383
3384 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3385
3386         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3387         top.c (execute_command_to_ui_file): New function, mostly a copy
3388         of execute_command_to_string.
3389         (execute_command_to_string): Implement by calling
3390         execute_command_to_ui_file.
3391
3392 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3393
3394         * top.h (saved_command_line): Remove declaration.
3395         * top.c (previous_saved_command_line, previous_repeat_arguments):
3396         New variables.
3397         (saved_command_line): Make static, define together with other
3398         'repeat variables'.
3399         (dont_repeat): Clear repeat_arguments.
3400         (repeat_previous, get_saved_command_line, save_command_line):
3401         New functions.
3402         (gdb_init): Initialize saved_command_line
3403         and previous_saved_command_line.
3404         * main.c (captured_main_1): Remove saved_command_line initialization.
3405         * event-top.c (handle_line_of_input): Update to use
3406         the new 'repeat' related functions instead of direct access to
3407         saved_command_line.
3408         * command.h (repeat_previous, get_saved_command_line,
3409         save_command_line): New declarations.
3410         (dont_repeat): Add comment.
3411
3412 2019-05-30  Tom Tromey  <tromey@adacore.com>
3413
3414         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3415         Fix comment.
3416         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3417
3418 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3419
3420         PR cli/24587
3421         * completer.c (complete): Initialize variable word.
3422
3423 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3424
3425         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3426         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3427         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3428         'body' is NULL to the outter 'if', protecting the '!is_define'
3429         situation as well.
3430
3431 2019-05-29  Tom Tromey  <tromey@adacore.com>
3432
3433         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3434         (dwarf_unknown): New function.
3435         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3436         (dwarf_type_encoding_name): Use dwarf_unknown.
3437
3438 2019-05-29  Tom Tromey  <tromey@adacore.com>
3439
3440         PR c++/20020:
3441         * cp-valprint.c (cp_print_value_fields): Call
3442         cp_print_static_field inside "try".
3443
3444 2019-05-29  Tom Tromey  <tromey@adacore.com>
3445
3446         * inflow.c (struct terminal_info): Add default operator=.
3447         * configure: Rebuild.
3448         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3449         -Wdeprecated-copy-dtor, -Wredundant-move.
3450
3451 2019-05-29  Tom Tromey  <tromey@adacore.com>
3452
3453         * NEWS: Add entry.
3454         * infcmd.c (print_return_value_1): Handle finish_print
3455         option.
3456         (show_print_finish): New function.
3457         (_initialize_infcmd): Add "set/show print finish" commands.
3458         * valprint.c (user_print_options): Initialize new member.
3459         * valprint.h (struct value_print_options) <finish_print>: New
3460         member.
3461
3462 2019-05-28  Tom Tromey  <tromey@adacore.com>
3463
3464         * ada-lang.c (ada_remove_Xbn_suffix)
3465         (find_old_style_renaming_symbol)
3466         (parse_old_style_renaming): Remove.
3467         (ada_find_renaming_symbol): Don't call
3468         find_old_style_renaming_symbol.
3469         (ada_is_renaming_symbol): Rename from
3470         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3471         bool.  Now static.
3472         (ada_read_var_value): Update and simplify.
3473         * ada-exp.y (write_var_or_type): Remove old code.
3474
3475 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3476
3477         * event-top.c: Remove include comment.
3478         * inflow.c (class scoped_ignore_sigttou): Move from here...
3479         * inflow.h (class scoped_ignore_sigttou): ...to here.
3480         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3481         * top.c:  Remove include comment.
3482
3483 2019-05-27  Tom Tromey  <tom@tromey.com>
3484
3485         * NEWS: Fix typo.
3486
3487 2019-05-22  Tom Tromey  <tromey@adacore.com>
3488
3489         * target.c (target_follow_exec): Constify parameter.
3490         * target-delegates.c: Rebuild.
3491         * remote.c (remote_target::follow_exec): Constify parameter.
3492         * infrun.c (follow_exec): Constify parameter.
3493         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3494         (target_follow_exec): Likewise.
3495
3496 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3497
3498         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3499         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3500
3501 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3502
3503         * NEWS: Add debugredirect and testsuite sections.
3504
3505 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3506
3507         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3508         target descriptions using exclusively floating point register name
3509         aliases.
3510
3511 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         PR gdb/18644:
3514         * f-lang.c (build_fortran_types): Handle the case where
3515         gdbarch_floatformat_for_type returns a nullptr.
3516
3517 2019-05-21  Tom de Vries  <tdevries@suse.de>
3518
3519         PR cli/24587
3520         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3521
3522 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3523
3524         PR gdb/18644:
3525         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3526         16-byte floats.
3527         * i386-tdep.c (i386_floatformat_for_type): Use
3528         floatformats_ia64_quad for the 16-byte floating point component
3529         within a fortran 32-byte complex number.
3530
3531 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3534         delete default constructor.
3535         (find_partial_die): Update to return const struct.
3536         (partial_die_parent_scope): Move variable declaration into scope
3537         of its use and change its type to auto.
3538         (guess_partial_die_structure_name): Likewise.
3539         (partial_die_info::fixup): Likewise.
3540
3541 2019-05-17  Tom Tromey  <tromey@adacore.com>
3542
3543         * source.c (find_and_open_source): Remove cast.
3544
3545 2019-05-17  Tom Tromey  <tromey@adacore.com>
3546
3547         * annotate.c (annotate_source): Make "filename" const.
3548         * annotate.h (annotate_source): Use const.
3549
3550 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3551
3552         * disasm.c (set_disassembler_options): Send errors to stderr.
3553
3554 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3555
3556         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3557         (cli_interp_base::set_logging): Check debug_redirect.
3558         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3559         * cli/cli-logging.c (debug_redirect): Add static variable.
3560         (pop_output_files): Add default param.
3561         (handle_redirections): Print debug setting.
3562         (show_logging_command): Likewise.
3563         (_initialize_cli_logging): Add debugredirect command.
3564         * interps.c (current_interp_set_logging): Add debug_redirect
3565         parameter.
3566         * interps.h (set_logging): Add debug_redirect parameter.
3567         (current_interp_set_logging): Likewise.
3568         * mi/mi-common.h: Likewise.
3569         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3570
3571 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3572             Tom Tromey  <tromey@adacore.com>
3573
3574         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3575         directly.
3576         * cli/cli-interp.h (make_logging_output): Remove declaration.
3577         * cli/cli-logging.c (make_logging_output): Remove function.
3578         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3579         directly.
3580         * ui-file.c (tee_file::tee_file): Remove bools.
3581         (tee_file::~tee_file): Remove deletes.
3582         * ui-file.h (tee_file): Remove bools.
3583
3584 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3585
3586         * mi/mi-cmds.h (mi_cmd_complete): New function.
3587         * mi/mi-main.c (mi_cmd_complete): Likewise.
3588         * mi/mi-cmds.c: Define new MI command -complete.
3589         * NEWS: Mention new -complete command.
3590
3591 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3592
3593         * completer.h (complete): New function.
3594         * completer.c (complete): Likewise.
3595         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3596         function defined in completer.h.
3597
3598 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3599
3600         * MAINTAINERS (Write After Approval): Add myself.
3601
3602 2019-05-17  Tom de Vries  <tdevries@suse.de>
3603
3604         PR gdb/24094
3605         * dwarf2read.c (struct cu_partial_die_info): New struct.
3606         (find_partial_die): Return cu_partial_die_info.
3607         (partial_die_parent_scope, guess_partial_die_structure_name)
3608         (partial_die_info::fixup): Handle new return type of find_partial_die.
3609
3610 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3611
3612         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3613         "std::string", simplifying the algorithm.
3614
3615 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3616
3617         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3618         (stap_static_probe_ops::get_probes): Likewise.
3619
3620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3621
3622         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3623         '-')" and "else if".
3624         (stap_parse_single_operand): Join checks for
3625         "gdbarch_stap_parse_special_token_p" and
3626         "gdbarch_stap_parse_special_token" in the same "if" statement.
3627         Invert check when verifying for operation on register
3628         displacement.
3629
3630 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3631
3632         * stap-probe.c (stap_get_opcode): Update comment.
3633         (stap_get_expected_argument_type): Likewise.
3634         (handle_stap_probe): Likewise.
3635
3636 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3637
3638         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3639         return type to 'bool'.  Adjust comment.  Use 'bool' when
3640         appropriate.
3641         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3642         * stap-probe.c (stap_parse_argument_1): Likewise.
3643         (stap_is_operator): Likewise.
3644         (stap_is_generic_prefix): Likewise.
3645         (stap_is_register_prefix): Likewise.
3646         (stap_is_register_indirection_prefix): Likewise.
3647         (stap_is_integer_prefix): Likewise.
3648         (stap_generic_check_suffix): Likewise.
3649         (stap_check_integer_suffix): Likewise.
3650         (stap_check_register_suffix): Likewise.
3651         (stap_check_register_indirection_suffix): Likewise.
3652         (stap_parse_register_operand): Likewise.
3653         (stap_parse_single_operand): Likewise.
3654         (stap_parse_argument_1): Likewise.
3655         (stap_probe::get_argument_count): Likewise.
3656         (stap_is_operator): Likewise.
3657
3658 2019-05-16  Tom Tromey  <tromey@adacore.com>
3659
3660         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3661         keyword to foreach.
3662
3663 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3664
3665         * linux-thread-db.c (try_thread_db_load_1): Change return type
3666         to bool.
3667         (try_thread_db_load): Likewise.
3668         (try_thread_db_load_from_pdir_1): Likewise.
3669         (try_thread_db_load_from_pdir): Likewise.
3670         (try_thread_db_load_from_sdir): Likewise.
3671         (try_thread_db_load_from_dir): Likewise.
3672         (thread_db_load_search): Likewise.
3673         (has_libpthread): Likewise.
3674         (thread_db_load): Likewise.
3675
3676 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3677
3678         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3679         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3680         NULL, and complain/return if that's the case.
3681
3682 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3683
3684         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3685         (advance, posn, abstract_read_memory): New functions.
3686         [struct mem_read_abstraction]: New struct.
3687         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3688
3689 2019-05-14  Tom Tromey  <tromey@adacore.com>
3690
3691         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3692         value is not lval_memory.
3693
3694 2019-05-14  Tom Tromey  <tromey@adacore.com>
3695
3696         * solib.c (info_sharedlibrary_command): Style the file name.
3697
3698 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3699
3700         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3701         (aarch64_vnv_type): Likewise.
3702         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3703         * common/tdesc.c: Likewise.
3704         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3705         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3706         * features/aarch64-fpu.xml: Add ieee half view.
3707         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3708         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3709         * gdbtypes.h (struct builtin_type): Likewise.
3710         (struct objfile_type): Likewise.
3711
3712 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3713
3714         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3715         typo.
3716         * location.h (string_to_event_location): Likewise.
3717
3718 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3719
3720         GDB 8.3 released.
3721
3722 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3723
3724         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3725         New variable declaration.
3726         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3727         New variable.
3728         (print_one_breakpoint): Use ui_out::test_flags and new global
3729         variable to compute use_fixed_output.
3730         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3731         Remove.
3732         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3733         (mi_multi_location_breakpoint_output_fixed): Remove.
3734         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3735         new variable.
3736         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3737         fix_multi_location_breakpoint_output flag if version >= 3.
3738         * ui-out.h (enum ui_out_flag)
3739         <fix_multi_location_breakpoint_output>: New enumerator.
3740
3741 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3742
3743         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3744
3745 2019-05-10  Tom Tromey  <tromey@adacore.com>
3746
3747         * ada-lang.c (catch_ada_completer): New function.
3748         (_initialize_ada_language): Use it.
3749
3750 2019-05-10  Tom Tromey  <tromey@adacore.com>
3751
3752         * thread.c (print_thread_info): Make "requested_threads" const.
3753         * gdbthread.h (print_thread_info): Make "requested_threads"
3754         const.
3755         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3756         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * gdbtypes.c (objfile_type_data): Change type.
3761         (objfile_type, _initialize_gdbtypes): Update.
3762
3763 2019-05-08  Tom Tromey  <tom@tromey.com>
3764
3765         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3766         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3767         (_initialize_dwarf2_frame): Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * objc-lang.c (objc_objfile_data): Change type.
3772         (find_methods): Update.
3773         (_initialize_objc_lang): Remove.
3774
3775 2019-05-08  Tom Tromey  <tom@tromey.com>
3776
3777         * stabsread.c (rs6000_builtin_type_data): Change type.
3778         (rs6000_builtin_type, _initialize_stabsread): Update.
3779
3780 2019-05-08  Tom Tromey  <tom@tromey.com>
3781
3782         * mips-tdep.c (mips_pdr_data): Remove.
3783         (_initialize_mips_tdep): Update.
3784
3785 2019-05-08  Tom Tromey  <tom@tromey.com>
3786
3787         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3788         (hppa_init_objfile_priv_data, read_unwind_info)
3789         (find_unwind_entry, _initialize_hppa_tdep): Update.
3790
3791 2019-05-08  Tom Tromey  <tom@tromey.com>
3792
3793         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3794         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3795         on obstack.
3796         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3797
3798 2019-05-08  Tom Tromey  <tom@tromey.com>
3799
3800         * mdebugread.c (basic_type_data): Change type.
3801         (basic_type, _initialize_mdebugread): Update.
3802
3803 2019-05-08  Tom Tromey  <tom@tromey.com>
3804
3805         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * nto-tdep.c (nto_inferior_data_reg): Change type.
3810         (nto_inferior_data): Update.
3811         (nto_inferior_data_cleanup, nto_new_inferior_data)
3812         (_initialize_nto_tdep): Remove.
3813         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3814
3815 2019-05-08  Tom Tromey  <tom@tromey.com>
3816
3817         * ada-lang.c (struct ada_inferior_data): Add initializers.
3818         (ada_inferior_data): Change type.
3819         (ada_inferior_data_cleanup): Remove.
3820         (get_ada_inferior_data, ada_inferior_exit)
3821         (struct ada_pspace_data): Add initializers, destructor.
3822         (ada_pspace_data_handle): Change type.
3823         (get_ada_pspace_data): Update.
3824         (ada_pspace_data_cleanup): Remove.
3825
3826 2019-05-08  Tom Tromey  <tom@tromey.com>
3827
3828         * coffread.c (struct coff_symfile_info): Add initializers.
3829         (coff_objfile_data_key): Move lower.  Change type.
3830         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3831         Update.
3832         (coff_free_info): Remove.
3833
3834 2019-05-08  Tom Tromey  <tom@tromey.com>
3835
3836         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3837         (fbsd_pspace_data_handle): Move lower.  Change type.
3838         (get_fbsd_pspace_data): Update.
3839         (fbsd_pspace_data_cleanup): Remove.
3840         (_initialize_fbsd_tdep): Update.
3841
3842 2019-05-08  Tom Tromey  <tom@tromey.com>
3843
3844         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3845         (get_ada_tasks_pspace_data): Update.
3846         (ada_tasks_pspace_data_cleanup): Remove.
3847         (_initialize_tasks): Update.
3848         (ada_tasks_inferior_data_handle): Change type.
3849         (get_ada_tasks_inferior_data): Update.
3850         (ada_tasks_inferior_data_cleanup): Remove.
3851         (struct ada_tasks_pspace_data): Add initializers.
3852
3853 2019-05-08  Tom Tromey  <tom@tromey.com>
3854
3855         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3856         * symfile-debug.c (debug_sym_get_probes): Change type.
3857         * stap-probe.c (handle_stap_probe):
3858         (stap_static_probe_ops::get_probes): Change type.
3859         * probe.h (class static_probe_ops) <get_probes>: Change type.
3860         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3861         (parse_probes_in_pspace): Update.
3862         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3863         Update.
3864         (any_static_probe_ops::get_probes): Change type.
3865         * elfread.c (elfread_data): New typedef.
3866         (probe_key): Change type.
3867         (elf_get_probes): Likewise.  Update.
3868         (probe_key_free): Remove.
3869         (_initialize_elfread): Update.
3870         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3871         Change type.
3872         (dtrace_process_dof_probe, dtrace_process_dof)
3873         (dtrace_static_probe_ops::get_probe): Change type.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * xcoffread.c (struct xcoff_symfile_info): Rename from
3878         coff_symfile_info.  Add initializers.
3879         (xcoff_objfile_data_key): Move lower.  Change type.
3880         (XCOFF_DATA): Rewrite.
3881         (xcoff_free_info): Remove.
3882         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3883         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3884         (xcoff_initial_scan): Update.
3885
3886 2019-05-08  Tom Tromey  <tom@tromey.com>
3887
3888         * solib-svr4.c (struct svr4_info): Add initializers and
3889         destructor.
3890         <probes_table>: Now an htab_up.
3891         (solib_svr4_pspace_data): Change type.
3892         (free_probes_table): Simplify.
3893         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3894         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3895         (probes_table_remove_objfile_probes, register_solib_event_probe)
3896         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3897         (_initialize_svr4_solib): Update.
3898
3899 2019-05-08  Tom Tromey  <tom@tromey.com>
3900
3901         * remote.c (remote_pspace_data): Change type.
3902         (remote_pspace_data_cleanup): Remove.
3903         (get_remote_exec_file, set_pspace_remote_exec_file)
3904         (_initialize_remote): Update.
3905
3906 2019-05-08  Tom Tromey  <tom@tromey.com>
3907
3908         * breakpoint.c (breakpoint_objfile_key): Change type.
3909         (get_breakpoint_objfile_data): Update.
3910         (free_breakpoint_objfile_data): Remove.
3911         (_initialize_breakpoint): Update.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * linux-tdep.c (struct linux_info): Add initializers.
3916         (linux_inferior_data): Move.  Change type.
3917         (invalidate_linux_cache_inf): Update.
3918         (linux_inferior_data_cleanup): Remove.
3919         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3920
3921 2019-05-08  Tom Tromey  <tom@tromey.com>
3922
3923         * auxv.c (auxv_inferior_data): Move.  Change type.
3924         (auxv_inferior_data_cleanup): Remove.
3925         (invalidate_auxv_cache_inf): Rewrite.
3926         (get_auxv_inferior_data, _initialize_auxv): Update.
3927
3928 2019-05-08  Tom Tromey  <tom@tromey.com>
3929
3930         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3931         (symfile_debug_objfile_data_key): Change type.
3932         (symfile_debug_installed, debug_qf_has_symbols)
3933         (debug_qf_find_last_source_symtab)
3934         (debug_qf_forget_cached_source_info)
3935         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3936         (debug_qf_print_stats, debug_qf_dump)
3937         (debug_qf_expand_symtabs_for_function)
3938         (debug_qf_expand_all_symtabs)
3939         (debug_qf_expand_symtabs_with_fullname)
3940         (debug_qf_map_matching_symbols)
3941         (debug_qf_expand_symtabs_matching)
3942         (debug_qf_find_pc_sect_compunit_symtab)
3943         (debug_qf_map_symbol_filenames)
3944         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3945         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3946         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3947         (debug_sym_read_linetable, debug_sym_relocate): Update.
3948         (symfile_debug_free_objfile): Remove.
3949         (install_symfile_debug_logging, _initialize_symfile_debug):
3950         Update.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3955         allocate_on_obstack.
3956         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3957         (get_dwarf2_per_objfile): Update.
3958         (set_dwarf2_per_objfile): Remove.
3959         (dwarf2_has_info, dwarf2_get_section_info): Update.
3960         (dwarf2_free_objfile): Remove.
3961         (_initialize_dwarf2_read): Update.
3962
3963 2019-05-08  Tom Tromey  <tom@tromey.com>
3964
3965         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3966         initializers.
3967         <unsupported_script_warning_printed,
3968         script_not_found_warning_printed>: Now bool.
3969         (auto_load_pspace_data): Change type.
3970         (~auto_load_pspace_info): Rename from
3971         auto_load_pspace_data_cleanup.
3972         (get_auto_load_pspace_data, init_loaded_scripts_info)
3973         (clear_section_scripts, maybe_print_unsupported_script_warning)
3974         (maybe_print_script_not_found_warning, _initialize_auto_load):
3975         Update.
3976
3977 2019-05-08  Tom Tromey  <tom@tromey.com>
3978
3979         * objfiles.c (objfile_pspace_info): Add destructor and
3980         initializers.
3981         (objfiles_pspace_data): Change type.
3982         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3983         (get_objfile_pspace_data): Update.
3984         (objfiles_bfd_data): Change type.
3985         (get_objfile_bfd_data): Update.
3986         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3987
3988 2019-05-08  Tom Tromey  <tom@tromey.com>
3989
3990         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3991         Change type.
3992         (get_catch_syscall_inferior_data): Update.
3993         (catch_syscall_inferior_data_cleanup): Remove.
3994         (_initialize_break_catch_syscall): Update.
3995
3996 2019-05-08  Tom Tromey  <tom@tromey.com>
3997
3998         * inflow.c (struct terminal_info): Add destructor and
3999         initializers.
4000         (inflow_inferior_data): Change type.
4001         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4002         (get_inflow_inferior_data, inflow_inferior_exit)
4003         (swap_terminal_info, _initialize_inflow): Update.
4004
4005 2019-05-08  Tom Tromey  <tom@tromey.com>
4006
4007         * target-dcache.c (target_dcache_cleanup): Remove.
4008         (target_dcache_aspace_key): Change type.
4009         (target_dcache_init_p, target_dcache_invalidate)
4010         (target_dcache_get, target_dcache_get_or_init)
4011         (_initialize_target_dcache): Update.
4012         * dcache.h (struct dcache_deleter): New.
4013
4014 2019-05-08  Tom Tromey  <tom@tromey.com>
4015
4016         * symtab.c (struct symbol_cache): Add destructor and
4017         initializers.
4018         (symbol_cache_key): Move.  Change type.
4019         (make_symbol_cache, free_symbol_cache): Remove.
4020         (get_symbol_cache): Update.
4021         (symbol_cache_cleanup): Remove.
4022         (ALL_PSPACES, symbol_cache_flush)
4023         (maintenance_print_symbol_cache)
4024         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4025         Update.
4026
4027 2019-05-08  Tom Tromey  <tom@tromey.com>
4028
4029         * symtab.c (struct main_info): Add destructor and initializers.
4030         (main_progspace_key): Move.  Change type.
4031         (get_main_info): Update.
4032         (main_info_cleanup): Remove.
4033         (_initialize_symtab): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * registry.h (DECLARE_REGISTRY): Define the _key class.
4038
4039 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * NEWS: Merge two 'New commands' sections.
4042
4043 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4044
4045         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4046         parameter and use Ada language definition instead.
4047         (ada_val_print_ptr): Remove unused language parameter.
4048         (ada_val_print_num): Remove language parameter and use Ada language
4049         definition instead.
4050         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4051         parameter.
4052         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4053         parameter and use Ada language definition instead.
4054         (ada_val_print_1): Update all ada_val_print_xxx calls.
4055         Remove language parameter.
4056         (ada_val_print): Update ada_val_print_1 call.
4057
4058 2019-05-08  Tom Tromey  <tromey@adacore.com>
4059
4060         * remote.c (remote_hw_watchpoint_limit)
4061         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4062         Now static.
4063
4064 2019-05-08  Tom Tromey  <tromey@adacore.com>
4065
4066         * maint.c (_initialize_maint_cmds): Move initialization code to
4067         remote.c.
4068         (watchdog, show_watchdog): Move to remote.c.
4069         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4070         "watchdog" static.
4071         (_initialize_remote): Move initialization code from maint.c.
4072         * defs.h (watchdog): Don't declare.
4073
4074 2019-05-08  Tom Tromey  <tromey@adacore.com>
4075
4076         * tui/tui-interp.c: Include main.h.
4077         * interps.c: Include main.h.
4078         * main.h (interpreter_p): Declare.
4079         * defs.h (interpreter_p): Don't declare.
4080
4081 2019-05-08  Tom Tromey  <tromey@adacore.com>
4082
4083         * dwarf2loc.c: Include dwarf2read.h.
4084         * defs.h (read_unsigned_leb128): Don't declare.
4085         * dwarf2read.h (read_unsigned_leb128): Declare.
4086
4087 2019-05-08  Tom Tromey  <tromey@adacore.com>
4088
4089         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4090         method.
4091
4092 2019-05-08  Tom Tromey  <tromey@adacore.com>
4093
4094         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4095         when no wrap column is set.
4096
4097 2019-05-08  Tom Tromey  <tromey@adacore.com>
4098
4099         * c-lang.c (c_get_string): Handle non-C-style arrays.
4100
4101 2019-05-08  Tom Tromey  <tromey@adacore.com>
4102
4103         * typeprint.c (print_offset_data::update): Print the bit offset,
4104         not the number of bits remaining.
4105
4106 2019-05-08  Tom Tromey  <tromey@adacore.com>
4107
4108         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4109         padding at end of comment.
4110
4111 2019-05-08  Tom Tromey  <tromey@adacore.com>
4112
4113         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4114         Compare main types.
4115
4116 2019-05-06  Tom Tromey  <tom@tromey.com>
4117
4118         * common/scoped_mmap.c: Include common-defs.h.
4119         * common/scoped_mmap.h: Don't include config.h.
4120
4121 2019-05-04  Tom Tromey  <tom@tromey.com>
4122
4123         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4124         (struct aarch64_call_info): Add initializers.
4125         <si>: Now a std::vector.
4126         (pass_on_stack, aarch64_push_dummy_call): Update.
4127
4128 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4129             Tom Tromey  <tom@tromey.com>
4130
4131         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4132         (ppc_threads): Now a std::vector.  Now static.
4133         (hwdebug_find_thread_points_by_tid)
4134         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4135         Update.
4136
4137 2019-05-04  Tom Tromey  <tom@tromey.com>
4138
4139         * arc-tdep.c (arc_tdesc_init): Return bool.
4140
4141 2019-05-04  Tom Tromey  <tom@tromey.com>
4142
4143         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4144         Use gdb_assert_not_reached.
4145
4146 2019-05-04  Tom Tromey  <tom@tromey.com>
4147
4148         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4149         "false".
4150
4151 2019-05-04  Tom Tromey  <tom@tromey.com>
4152
4153         * arc-tdep.c (arc_tdesc_init): Use bool.
4154
4155 2019-05-04  Tom Tromey  <tom@tromey.com>
4156
4157         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4158
4159 2019-05-04  Tom Tromey  <tom@tromey.com>
4160
4161         * cli/cli-cmds.c (valid_command_p): Return bool.
4162
4163 2019-05-04  Tom Tromey  <tom@tromey.com>
4164
4165         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4166         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4167
4168 2019-05-04  Raul Tambre  <raul@tambre.ee>
4169
4170         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4171         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4172         operator for comparison.
4173
4174 2019-05-04  Tom Tromey  <tom@tromey.com>
4175
4176         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4177         (lookup_partial_symbol, print_partial_symbols)
4178         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4179         (psymbol_compare): Update.
4180         (add_psymbol_to_bcache): Clear the entire psymbol.
4181         (maintenance_check_psymtabs): Update.
4182         * psympriv.h (struct partial_symbol): Don't derive from
4183         general_symbol_info.
4184         <obj_section, unrelocated_address, address,
4185         set_unrelocated_address>: Update.
4186         <ginfo>: New member.
4187         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4188         (debug_names::write_psymbols): Update.
4189
4190 2019-05-04  Tom de Vries  <tdevries@suse.de>
4191
4192         * contrib/cc-with-tweaks.sh: Support -n arg.
4193
4194 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4195
4196         * corelow.c (core_target::detach): Ensure frame cache and
4197         register caches are cleared.
4198         inferior.c (exit_inferior_1): Likewise.
4199
4200 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4201             Tom Tromey  <tom@tromey.com>
4202
4203         * dictionary.c (collate_pending_symbols_by_language): Remove
4204         "struct" from foreach.
4205         * symtab.c (lookup_global_symbol_from_objfile)
4206         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4207         foreach.
4208         * ser-tcp.c (net_open): Remove "struct" from foreach.
4209         * objfiles.c (objfile_relocate, objfile_rebase)
4210         (objfile_has_symbols): Remove "struct" from foreach.
4211         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4212         from foreach.
4213         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4214         foreach.
4215         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4216         "struct" from foreach.
4217         * ada-lang.c (create_excep_cond_exprs)
4218         (ada_exception_catchpoint_cond_string): Remove "struct" from
4219         foreach.
4220
4221 2019-05-03  Tom Tromey  <tromey@adacore.com>
4222
4223         * ada-exp.y (convert_char_literal): Check suffix of each
4224         enumerator.
4225
4226 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4227
4228         PR ada/21406:
4229         * ada-exp.y (yywrap): Don't define.
4230         * ada-lex.l (%option): Add noyywrap
4231         (yywrap): Remove.
4232
4233 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4234
4235         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4236         _WIN32_WINNT to the XP level, unless already defined to a higher
4237         level.
4238
4239         * unittests/parse-connection-spec-selftests.c:
4240         * ser-tcp.c:
4241         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4242         override.
4243
4244         * symfile.c (find_separate_debug_file): Remove colon from the
4245         drive spec of DOS/Windows file names of the target, so that the
4246         file name produced from DEBUGDIR and the target's directory will
4247         be valid on DOS/Windows systems.
4248
4249 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * rust-lang.c (val_print_struct): Handle printing structures
4252         containing strings.
4253
4254 2019-05-02  Tom Tromey  <tromey@adacore.com>
4255
4256         * valarith.c (_initialize_valarith): Remove.
4257
4258 2019-05-01  Tom Tromey  <tromey@adacore.com>
4259
4260         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4261         bitfields.
4262
4263 2019-05-01  Tom Tromey  <tromey@adacore.com>
4264
4265         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4266         for big-endian copies.
4267
4268 2019-04-30  Ali Tamur  <tamur@google.com>
4269         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4270         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4271         (read_3_bytes): New function.
4272
4273 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4274
4275         * windows-nat.c (main_thread_id): Delete.
4276         (handle_output_debug_string): Replace main_thread_id by
4277         current_event.dwThreadId.
4278         (fake_create_process): Likewise.
4279         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4280         Do not set main_thread_id.
4281         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4282         current_event.dwThreadId.
4283         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4284
4285 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4286
4287         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4288         Use current_event.dwThreadId instead of main_thread_id.
4289
4290 2019-04-30  Tom Tromey  <tromey@adacore.com>
4291
4292         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4293         (create_excep_cond_exprs): Iterate over program spaces.
4294         (ada_exception_catchpoint_cond_string): Examine all minimal
4295         symbols for exception types.
4296
4297 2019-04-30  Tom Tromey  <tromey@adacore.com>
4298
4299         PR c++/24470:
4300         * dwarf2read.c (process_structure_scope): Handle case where type
4301         has template parameters but no symbol was created.
4302
4303 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4304             Chris January  <chris.january@arm.com>
4305
4306         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4307         qualifier.
4308         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4309
4310 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4311
4312         * f-typeprint.c (f_print_type): Update rules for printing
4313         whitespace.
4314         (f_type_print_varspec_suffix): Likewise.
4315
4316 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4317             Chris January  <chris.january@arm.com>
4318
4319         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4320         function arguments.
4321
4322 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * f-lang.c (build_fortran_types): Change name of void type to
4325         lower case.
4326         * f-typeprint.c (f_type_print_base): Print the name of the void
4327         type, rather than a fixed string.
4328         * f-valprint.c (f_decorations): Use lower case void string.
4329
4330 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4331             Chris January  <chris.january@arm.com>
4332
4333         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4334         types for Fortran.
4335
4336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4337             Chris January  <chris.january@arm.com>
4338             David Lecomber  <david.lecomber@arm.com>
4339
4340         * f-exp.y (BINOP_INTRINSIC): New token.
4341         (exp): New parser rule handling BINOP_INTRINSIC.
4342         (f77_keywords): Add new builtin procedures.
4343         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4344         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4345         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4346         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4347         (print_unop_subexp_f): New function.
4348         (print_binop_subexp_f): New function.
4349         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4350         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4351         (dump_subexp_body_f): Likewise.
4352         (operator_check_f): Likewise.
4353         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4354         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4355
4356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4359         UNOP_KIND.
4360         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4361         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4362         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4363         (operator_length_f): New fuction.
4364         (print_subexp_f): New function.
4365         (op_name_f): New function.
4366         (dump_subexp_body_f): New function.
4367         (operator_check_f): New function.
4368         (exp_descriptor_f): Replace standard expression handling functions
4369         with new functions.
4370         * gdb/fortran-operator.def: New file.
4371         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4372         * gdb/std-operator.def: Remove UNOP_KIND.
4373
4374 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4375
4376         * std-operator.def: Remove unbalanced, stray double quote
4377         character.
4378
4379 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4380             Chris January  <chris.january@arm.com>
4381             Daniel Everett  <daniel.everett@arm.com>
4382             Nick Forrington  <nick.forrington@arm.com>
4383             Richard Bunt  <richard.bunt@arm.com>
4384
4385         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4386         of depth when printing anonymous structs or unions.
4387         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4388         Don't print either the top-level value, or the children if the
4389         max-depth is exceeded.
4390         (ppscm_print_children): When printing the key of a map, allow one
4391         extra level of depth.
4392         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4393         print either the top-level value, or the children if the max-depth
4394         is exceeded.
4395         (print_children): When printing the key of a map, allow one extra
4396         level of depth.
4397         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4398         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4399         (user_print_options): Initialise max_depth field.
4400         (val_print_scalar_or_string_type_p): New function.
4401         (val_print): Check to see if the max depth has been reached.
4402         (val_print_check_max_depth): Define new function.
4403         (show_print_max_depth): New function.
4404         (_initialize_valprint): Add 'print max-depth' option.
4405         * valprint.h (struct value_print_options) <max_depth>: New field.
4406         (val_print_check_max_depth): Declare new function.
4407         * NEWS: Document new feature.
4408
4409 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * ada-lang.c (ada_language_defn): Initialise new field.
4412         * c-lang.c (c_is_string_type_p): New function.
4413         (c_language_defn): Initialise new field.
4414         (cplus_language_defn): Initialise new field.
4415         (asm_language_defn): Initialise new field.
4416         (minimal_language_defn): Initialise new field.
4417         * c-lang.h (c_is_string_type_p): Declare new function.
4418         * d-lang.c (d_language_defn): Initialise new field.
4419         * f-lang.c (f_is_string_type_p): New function.
4420         (f_language_defn): Initialise new field.
4421         * go-lang.c (go_is_string_type_p): New function.
4422         (go_language_defn): Initialise new field.
4423         * language.c (default_is_string_type_p): New function.
4424         (unknown_language_defn): Initialise new field.
4425         (auto_language_defn): Initialise new field.
4426         * language.h (struct language_defn) <la_is_string_type_p>: New
4427         member variable.
4428         (default_is_string_type_p): Declare new function.
4429         * m2-lang.c (m2_language_defn): Initialise new field.
4430         * objc-lang.c (objc_language_defn): Initialise new field.
4431         * opencl-lang.c (opencl_language_defn): Initialise new field.
4432         * p-lang.c (pascal_is_string_type_p): New function.
4433         (pascal_language_defn): Initialise new field.
4434         * rust-lang.c (rust_is_string_type_p): New function.
4435         (rust_language_defn): Initialise new field.
4436
4437 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4440         New field.
4441         * ada-lang.c (ada_language_defn): Initialise new field.
4442         * c-lang.c (c_language_defn): Likewise.
4443         (cplus_language_defn): Likewise.
4444         (asm_language_defn): Likewise.
4445         (minimal_language_defn): Likewise.
4446         * d-lang.c (d_language_defn): Likewise.
4447         * f-lang.c (f_language_defn): Likewise.
4448         * go-lang.c (go_language_defn): Likewise.
4449         * language.c (unknown_language_defn): Likewise.
4450         (auto_language_defn): Likewise.
4451         * m2-lang.c (m2_language_defn): Likewise.
4452         * objc-lang.c (objc_language_defn): Likewise.
4453         * opencl-lang.c (opencl_language_defn): Likewise.
4454         * p-lang.c (pascal_language_defn): Likewise.
4455         * rust-lang.c (rust_language_defn): Likewise.
4456
4457 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * ada-lang.c (ada_is_character_type): Change return type to bool.
4460         (ada_is_string_type): Likewise.
4461         * ada-lang.h (ada_is_character_type): Update declaration
4462         (ada_is_string_type): Likewise.
4463
4464 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4465
4466         Support style in 'frame|thread apply'
4467
4468         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4469         * record.c (record_start, record_stop): Update callers of
4470         execute_command_to_string with false.
4471         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4472         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4473         methods.
4474         (class string_file): New constructor with term_out parameter.
4475         Override methods term_out and can_emit_style_escape.  New member
4476         term_out.
4477         (class stdio_file): Override can_emit_style_escape.
4478         (class tee_file): Override term_out and can_emit_style_escape.
4479         * utils.h (can_emit_style_escape): Remove.
4480         * utils.c (can_emit_style_escape): Likewise.
4481         Update all callers of can_emit_style_escape (SOMESTREAM) to
4482         SOMESTREAM->can_emit_style_escape.
4483         * source-cache.c (source_cache::get_source_lines): Likewise.
4484         * stack.c (frame_apply_command_count): Call execute_command_to_string
4485         passing the term_out characteristic of the current gdb_stdout.
4486         * thread.c (thr_try_catch_cmd): Likewise.
4487         * top.c (execute_command_to_string): pass term_out parameter
4488         to construct the string_file for the command output.
4489         * ui-file.c (term_cli_styling): New function (most code moved
4490         from utils.c can_emit_style_escape).
4491         (string_file::string_file, string_file::can_emit_style_escape,
4492         stdio_file::can_emit_style_escape, tee_file::term_out,
4493         tee_file::can_emit_style_escape): New functions.
4494
4495 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4496
4497         * NEWS: Mention the new set|show may-call-functions.
4498         * infcall.c (may_call_functions_p): New variable.
4499         (show_may_call_functions_p): New function.
4500         (call_function_by_hand_dummy): Throws an error if not
4501         may-call-functions.
4502         (_initialize_infcall): Call add_setshow_boolean_cmd for
4503         may-call-functions.
4504
4505 2019-04-25  Keith Seitz  <keiths@redhat.com>
4506
4507         PR c++/24367
4508         * cp-support.c (inspect_type): Don't attempt substitutions
4509         of symbol with the same name.
4510
4511 2019-04-25  Tom Tromey  <tromey@adacore.com>
4512
4513         PR gdb/24475:
4514         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4515         static.
4516
4517 2019-04-25  Tom Tromey  <tromey@adacore.com>
4518
4519         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4520         rvalue reference.
4521         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4522         (gdb_xml_parser::parse): Use std::move.
4523         * python/python-internal.h (gdbpy_convert_exception): Take a const
4524         reference.
4525         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4526         std::move.
4527         * python/py-utils.c (gdbpy_convert_exception): Take a const
4528         reference.
4529         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4530         Use std::move.
4531         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4532         Use std::move.
4533         * mi/mi-main.c (mi_print_exception): Take a const reference.
4534         * main.c (handle_command_errors): Take a const reference.
4535         * linespec.c (parse_linespec): Use std::move.
4536         * infcall.c (run_inferior_call): Use std::move.
4537         (call_function_by_hand_dummy): Use std::move.
4538         * exec.c (try_open_exec_file): Use std::move.
4539         * exceptions.h (exception_print, exception_fprintf)
4540         (exception_print_same): Update.
4541         * exceptions.c (print_exception, exception_print)
4542         (exception_fprintf, exception_print_same): Change parameters to
4543         const reference.
4544         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4545         * common/new-op.c: Use std::move.
4546         * common/common-exceptions.h (struct gdb_exception): Add move
4547         constructor.
4548         (struct gdb_exception_error, struct gdb_exception_quit, struct
4549         gdb_quit_bad_alloc): Change constructor to move constructor.
4550         (throw_exception): Change parameter to rvalue reference.
4551         * common/common-exceptions.c (throw_exception): Take rvalue
4552         reference.
4553         * cli/cli-interp.c (safe_execute_command): Use std::move.
4554         * breakpoint.c (insert_bp_location, location_to_sals): Use
4555         std::move.
4556
4557 2019-04-25  Tom Tromey  <tromey@adacore.com>
4558
4559         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4560         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4561         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4562         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4563         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4564         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4565         guile/scm-value.c: Use unpack.
4566         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4567         gdbscm_gdb_exception.
4568         (gdbscm_throw_gdb_exception): Likewise.
4569         (struct gdbscm_gdb_exception): New.
4570         (unpack): New function.
4571         (gdbscm_wrap): Use unpack.
4572
4573 2019-04-25  Tom Tromey  <tromey@adacore.com>
4574
4575         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4576         (gdb_rl_callback_handler): Use std::move.
4577         * common/common-exceptions.h (struct gdb_exception): Add move
4578         assignment operator.
4579         (throw_exception_sjlj): Change "exception" to const reference.
4580         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4581         (throw_exception_sjlj): Change "exception" to const reference.
4582
4583 2019-04-25  Tom Tromey  <tromey@adacore.com>
4584
4585         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4586         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4587         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4588         Update.
4589         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4590         Update.
4591         * mi/mi-interp.c (mi_interp::exec): Update.
4592         * linespec.c (parse_linespec): Update.
4593         * infcall.c (run_inferior_call): Update.
4594         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4595         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4596         (gdbscm_lookup_global_symbol): Update.
4597         * guile/scm-param.c (gdbscm_parameter_value): Update.
4598         * guile/scm-frame.c (gdbscm_frame_read_register)
4599         (gdbscm_frame_read_var): Update.
4600         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4601         * exec.c (try_open_exec_file): Update.
4602         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4603         (gdb_rl_callback_handler): Update.
4604         * common/common-exceptions.h (exception_none): Don't declare.
4605         * common/common-exceptions.c (exception_none): Don't define.
4606         (struct catcher) <exception>: Update.
4607         * cli/cli-interp.c (safe_execute_command): Update.
4608         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4609
4610 2019-04-25  Ali Tamur  <tamur@google.com>
4611
4612         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4613         (read_attribute_value): Likewise.
4614         (dwarf2_read_addr_index): Update comment.
4615         (read_str_index): Add DW_FORM_strx.
4616         (dwarf2_string_attr): Likewise.
4617         (dwarf2_const_value_attr): Likewise.
4618         (dump_die_shallow): Likewise.
4619         (dwarf2_fetch_constant_bytes): Likewise.
4620         (skip_form_bytes): Likewise.
4621         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4622
4623 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4624
4625         PR corefiles/11608
4626         PR corefiles/18187
4627         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4628         OFFSET.  Verify if current mapping contains an ELF header.
4629         (linux_find_memory_regions_full): Adjust call to
4630         dump_mapping_p.
4631
4632 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4633             Kang Li <kanglictf@gmail.com>
4634
4635         PR gdb/21600
4636
4637         * dwarf2-frame.c (read_initial_length): Be consistent about using
4638         unsigned representation of length.
4639         (decode_frame_entry_1): Likewise.  Check for wraparound of
4640         end pointer as well as buffer overflow.
4641
4642 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4643
4644         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4645         "vq".
4646
4647 2019-04-24  Tom Tromey  <tromey@adacore.com>
4648
4649         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4650
4651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * s12z-tdep.c (s12z_unwind_pc): Delete.
4654         (s12z_unwind_sp): Delete.
4655         (s12z_gdbarch_init): Don't register deleted functions with
4656         gdbarch.
4657
4658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * rl78-tdep.c (rl78_unwind_sp): Delete.
4661         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4662
4663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4666         (xstormy16_unwind_pc): Delete.
4667         (xstormy16_dummy_id): Delete.
4668         (xstormy16_gdbarch_init): Don't register deleted functions with
4669         gdbarch.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * vax-tdep.c (vax_unwind_pc): Delete.
4674         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4675
4676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4677
4678         * v850-tdep.c (v850_unwind_sp): Delete.
4679         (v850_unwind_pc): Delete.
4680         (v850_dummy_id): Delete.
4681         (v850_gdbarch_init): Don't register deleted functions with
4682         gdbarch.
4683
4684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4685
4686         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4687         (tilegx_unwind_pc): Delete.
4688         (tilegx_unwind_dummy_id): Delete.
4689         (tilegx_gdbarch_init): Don't register deleted functions with
4690         gdbarch.
4691
4692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4695         (tic6x_dummy_id): Delete.
4696         (tic6x_gdbarch_init): Don't register deleted functions with
4697         gdbarch.
4698
4699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * sparc-tdep.c (sparc_unwind_pc): Delete.
4702         (sparc32_gdbarch_init): Don't register deleted function with
4703         gdbarch.
4704
4705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * sh-tdep.c (sh_unwind_sp): Delete.
4708         (sh_unwind_pc): Delete.
4709         (sh_dummy_id): Delete.
4710         (sh_gdbarch_init): Don't register deleted functions with
4711         gdbarch.
4712
4713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * score-tdep.c (score_unwind_sp): Delete.
4716         (score_unwind_pc): Delete.
4717         (score_dummy_id): Delete.
4718         (score_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * rx-tdep.c (rx_unwind_pc): Delete.
4724         (rx_unwind_sp): Delete.
4725         (rx_dummy_id): Delete.
4726         (rx_gdbarch_init): Don't register deleted functions with
4727         gdbarch.  Update comment.
4728
4729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4732         (rs6000_dummy_id): Delete.
4733         (rs6000_gdbarch_init): Don't register deleted functions with
4734         gdbarch.
4735
4736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * or1k-tdep.c (or1k_dummy_id): Delete.
4739         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4740
4741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * nios2-tdep.c (nios2_dummy_id): Delete.
4744         (nios2_unwind_sp): Delete.
4745         (nios2_gdbarch_init): Don't register deleted functions with
4746         gdbarch.
4747
4748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * nds32-tdep.c (nds32_dummy_id): Delete.
4751         (nds32_unwind_pc): Delete.
4752         (nds32_unwind_sp): Delete.
4753         (nds32_gdbarch_init): Don't register deleted functions with
4754         gdbarch.
4755
4756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * msp430-tdep.c (msp430_unwind_pc): Delete.
4759         (msp430_unwind_sp): Delete.
4760         (msp430_dummy_id): Delete.
4761         (msp430_gdbarch_init): Don't register deleted functions with
4762         gdbarch.
4763
4764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4765
4766         * moxie-tdep.c (moxie_unwind_sp): Delete.
4767         (moxie_unwind_pc): Delete.
4768         (moxie_dummy_id): Delete.
4769         (moxie_gdbarch_init): Don't register deleted functions with
4770         gdbarch.
4771
4772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4775         (mn10300_unwind_pc): Delete.
4776         (mn10300_unwind_sp): Delete.
4777         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4778         mn10300_unwind_sp.
4779         (mn10300_frame_unwind_init): Don't register deleted functions with
4780         gdbarch.
4781
4782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * mep-tdep.c (mep_unwind_pc): Delete.
4785         (mep_unwind_sp): Delete.
4786         (mep_dummy_id): Delete.
4787         (mep_gdbarch_init): Don't register deleted functions with
4788         gdbarch.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4793         (m68hc11_unwind_sp): Delete.
4794         (m68hc11_gdbarch_init): Don't register deleted functions with
4795         gdbarch.
4796
4797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * m32r-tdep.c (m32r_unwind_sp): Delete.
4800         (m32r_unwind_pc): Delete.
4801         (m32r_dummy_id): Delete.
4802         (m32r_gdbarch_init): Don't register deleted functions with
4803         gdbarch.
4804
4805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * m32c-tdep.c (m32c_unwind_pc): Delete.
4808         (m32c_unwind_sp): Delete.
4809         (m32c_dummy_id): Delete.
4810         (m32c_gdbarch_init): Don't register deleted functions with
4811         gdbarch.
4812
4813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4816         (lm32_unwind_pc): Delete.
4817         (lm32_dummy_id): Delete.
4818         (lm32_gdbarch_init): Don't register deleted functions with
4819         gdbarch.
4820
4821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4822
4823         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4824         (iq2000_unwind_pc): Delete.
4825         (iq2000_dummy_id): Delete.
4826         (iq2000_gdbarch_init): Don't register deleted functions with
4827         gdbarch.
4828
4829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * nds32-tdep.c (nds32_type_align): Delete.
4832         (nds32_push_dummy_call): Use type_align instead.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * arm-tdep.c (arm_type_align): Only handle vector override case.
4837         (arm_push_dummy_call): Use type_align.
4838         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4839
4840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4843         case.
4844         (pass_on_stack): Use type_align.
4845         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4846         function.
4847
4848 2019-04-23  Tom Tromey  <tromey@adacore.com>
4849
4850         * dwarf2read.c (line_header::file_name_at): Remove unused
4851         overload.
4852
4853 2019-04-23  Tom de Vries  <tdevries@suse.de>
4854
4855         PR gdb/24438
4856         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4857         invocation.
4858
4859
4860 2019-03-27  Ali Tamur  <tamur@google.com>
4861
4862         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4863         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4864         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4865         (dwarf_expr_context::get_addr_index): Likewise
4866         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4867         (symbol_needs_eval_context::get_addr_index): Likewise
4868         (disassemble_dwarf_expression): Add DW_OP_addrx
4869         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4870         (read_cutu_die_from_dwo): Update comment
4871         (skip_one_die): Add DW_FORM_addrx
4872         (read_attribute_value): Likewise
4873         (var_decode_location): Add DW_OP_addrx
4874         (dwarf2_const_value_attr): Add DW_FORM_addrx
4875         (dump_die_shallow): Likewise
4876         (dwarf2_fetch_constant_bytes): Likewise
4877         (decode_locdesc): Add DW_OP_addrx
4878         (skip_form_bytes): Add DW_FORM_addrx
4879
4880 2019-04-22  Ali Tamur  <tamur@google.com>
4881
4882         * MAINTAINERS (Write After Approval): Add self.
4883
4884 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4887         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4888         (open_symbol_file_object): Likewise.
4889         (svr4_default_sos): Add info parameter.
4890         (svr4_read_so_list): Likewise.
4891         (svr4_current_sos_direct): Adjust functions calls to pass down
4892         info.
4893         (svr4_current_sos_1): Add info parameter.
4894         (svr4_current_sos): Call get_svr4_info, pass info down to
4895         svr4_current_sos_1.
4896         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4897         get_svr4_info.
4898         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4899         get_svr4_info.
4900         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4901         to get_svr4_info.
4902         (probes_table_remove_objfile_probes): Likewise.
4903         (register_solib_event_probe): Add info parameter.
4904         (solist_update_incremental): Pass info parameter down to
4905         svr4_read_so_list.
4906         (disable_probes_interface): Add info parameter.
4907         (svr4_handle_solib_event): Pass current_program_space to
4908         get_svr4_info.  Adjust disable_probes_interface cleanup.
4909         (svr4_create_probe_breakpoints): Add info parameter, pass it
4910         down to register_solib_event_probe.
4911         (svr4_create_solib_event_breakpoints): Add info parameter,
4912         pass it down to svr4_create_probe_breakpoints.
4913         (enable_break): Pass info down to
4914         svr4_create_solib_event_breakpoints.
4915         (svr4_solib_create_inferior_hook): Pass current_program_space to
4916         get_svr4_info.
4917         (svr4_clear_solib): Likewise.
4918
4919 2019-04-22  Pedro Alves  <palves@redhat.com>
4920
4921         * solib-svr4.c (svr4_free_objfile_observer): New.
4922         (probe_and_action::objfile): New field.
4923         (probes_table_htab_remove_objfile_probes)
4924         (probes_table_remove_objfile_probes): New functions.
4925         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4926         in the new probe_and_action.  Don't store the probe in 'lookup'.
4927         (svr4_create_probe_breakpoints): Pass objfile to
4928         register_solib_event_probe.
4929         (_initialize_svr4_solib): Register a free_objfile observer.
4930
4931 2019-04-19  Tom Tromey  <tom@tromey.com>
4932
4933         * common/queue.h: Remove.
4934
4935 2019-04-19  Tom Tromey  <tom@tromey.com>
4936
4937         * event-loop.c: Don't include "common/queue.h".
4938
4939 2019-04-19  Tom Tromey  <tom@tromey.com>
4940
4941         * remote.c (remote_target): Use delete.
4942         * remote-notif.h: Include <list>, not "common/queue.h".
4943         (notif_client_p): Remove typedef.
4944         (remote_notif_state): Add constructor, destructor, initializer.
4945         <notif_queue>: Now a std::list.
4946         (remote_notif_state_xfree): Don't declare.
4947         * remote-notif.c (remote_notif_process, handle_notification)
4948         (remote_notif_state_allocate): Update.
4949         (~remote_notif_state): Rename from remote_notif_state_xfree.
4950
4951 2019-04-19  Tom Tromey  <tom@tromey.com>
4952
4953         * symfile.c (reread_symbols): Update.
4954         * objfiles.c (objfile_register_static_link)
4955         (objfile_lookup_static_link): Update
4956         (~objfile) Don't delete static_links.
4957         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4958
4959 2019-04-19  Tom Tromey  <tom@tromey.com>
4960
4961         * type-stack.h (struct type_stack) <insert>: Constify string.
4962         * type-stack.c (type_stack::insert): Constify string.
4963         * gdbtypes.h (lookup_template_type): Update.
4964         (address_space_name_to_int): Update.
4965         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4966         const.
4967         (lookup_template_type): Make name const.
4968         * c-exp.y: Update rules.
4969         (lex_one_token, classify_name, classify_inner_name)
4970         (c_print_token): Update.
4971         * p-exp.y: Update rules.
4972         (yylex): Update.
4973         * f-exp.y: Update rules.
4974         (yylex): Update.
4975         * d-exp.y: Update rules.
4976         (lex_one_token, classify_name, classify_inner_name): Update.
4977         * parse.c (write_dollar_variable, copy_name): Return std::string.
4978         * parser-defs.h (copy_name): Change return type.
4979         * m2-exp.y: Update rules.
4980         (yylex): Update.
4981         * go-exp.y (lex_one_token): Update.
4982         Update rules.
4983         (classify_unsafe_function, classify_packaged_name)
4984         (classify_name, yylex): Update.
4985
4986 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4987
4988         * configure.ac: add --enable-source-highlight switch.
4989         * configure: Regenerate.
4990         * top.c (print_gdb_version): plumb --enable-source-highlight
4991         status to "show configuration".
4992
4993 2019-04-19  Tom Tromey  <tromey@adacore.com>
4994
4995         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4996         Check ADA_TYPE_P.
4997         (empty_record, ada_template_to_fixed_record_type_1)
4998         (template_to_static_fixed_type)
4999         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5000         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5001         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5002         macros.
5003
5004 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5005
5006         PR symtab/24423:
5007         * source.c (print_source_lines_base): Advance "iter" when a
5008         control character is seen.
5009
5010 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5011
5012         * inferior.h (struct infcall_suspend_state_deleter):
5013         Catch exception in destructor to avoid crash.
5014
5015 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5016
5017         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5018         close to the add_com "shell".
5019
5020 2019-04-18  Tom Tromey  <tromey@adacore.com>
5021
5022         * process-stratum-target.h (class process_stratum_target)
5023         <stratum>: Add "final".
5024
5025 2019-04-17  Tom Tromey  <tromey@adacore.com>
5026
5027         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5028         against nullptr before use.
5029
5030 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5031
5032         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5033
5034 2019-04-17  Jim Wilson  <jimw@sifive.com>
5035             Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5038         code read might fail, assume 4-byte breakpoint in that case.
5039
5040 2019-04-15  Leszek Swirski  <leszeks@google.com>
5041
5042         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5043         rather than a hand-rolled POD check when checking for forced MEMORY
5044         classification.
5045
5046 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5049         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5050         function.
5051         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5052         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5053         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5054         declaration.
5055
5056 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5057
5058         * aarch64-linux-nat.c
5059         (aarch64_linux_nat_target::thread_architecture): Add override.
5060         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5061         each VQ.
5062
5063 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5064
5065         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5066
5067 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5068
5069         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5070         target types of size 96-bits, add some additional comments, and
5071         check that the builtin type we found was the correct size.
5072
5073 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5074
5075         * utils.c (prompt_for_continue): Don't restore the styling at the
5076         end, as applied_style has the wrong value.  This fixes styling in
5077         long lists of file names that are interrupted by the "Continue?"
5078         prompt.
5079
5080 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5083         * c-lang.c (c_language_defn): Likewise.
5084         (cplus_language_defn): Likewise.
5085         (asm_language_defn): Likewise.
5086         (minimal_language_defn): Likewise.
5087         * d-lang.c (d_language_defn): Likewise.
5088         * f-lang.c (f_language_defn): Likewise.
5089         * go-lang.c (go_language_defn): Likewise.
5090         * language.c (unknown_language_defn): Likewise.
5091         (auto_language_defn): Likewise.
5092         * language.h (struct language_defn): Remove la_magic field.
5093         (LANG_MAGIC): Delete.
5094         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5095         * objc-lang.c (objc_language_defn): Likewise.
5096         * opencl-lang.c (opencl_language_defn): Likewise.
5097         * p-lang.c (pascal_language_defn): Likewise.
5098         * rust-lang.c (rust_language_defn): Likewise.
5099
5100 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * riscv-tdep.c (riscv_type_align): New function.
5103         (riscv_type_alignment): Delete.
5104         (riscv_arg_location): Use 'type_align'.
5105         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5106
5107 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * gdbtypes.c (type_align): A struct with no non-static fields also
5110         has alignment of 1.
5111
5112 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5115         component to 0.
5116         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5117         member.
5118         (riscv_struct_info::analyse): New implementation using new
5119         analyse_inner member function.
5120         (riscv_struct_info::field_offset): New member function.
5121         (riscv_struct_info::m_offsets): New member variable.
5122         (riscv_struct_info::analyse_inner): New private member function,
5123         takes the old implementation of riscv_struct_info::analyse but
5124         extended to track field offsets.
5125         (riscv_call_arg_struct): Update the struct folding special cases
5126         to handle cases where empty C++ structs, which are non-zero
5127         length, are found.
5128         (riscv_arg_location): Initialise the length of each location, a
5129         non-zero length now indicates the location is in use.
5130         (riscv_push_dummy_call): Allow for the first location having a
5131         non-zero offset when setting up arguments.
5132         (riscv_return_value): Likewise, but for return values.
5133
5134 2019-04-11  Tom Tromey  <tromey@adacore.com>
5135
5136         * utils.c (internal_vproblem): Make "msg" const.
5137
5138 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5139
5140         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5141         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5142         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5143         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5144
5145 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5146
5147         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5148         function.
5149         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5150         of amd64_collect_native_gregset.
5151         (amd64_linux_nat_target::store_registers): Likewise.
5152
5153 2019-04-10  Tom Tromey  <tom@tromey.com>
5154
5155         * symtab.c (lookup_global_symbol_from_objfile)
5156         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5157         * objfiles.h (class separate_debug_iterator): New.
5158         (class separate_debug_range): New.
5159         (struct objfile) <separate_debug_objfiles>: New method.
5160         (objfile_separate_debug_iterate): Don't declare.
5161         * objfiles.c (separate_debug_iterator::operator++): Rename from
5162         objfile_separate_debug_iterate.
5163         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5164         iterator.
5165         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5166         iterator.
5167
5168 2019-04-10  Tom Tromey  <tom@tromey.com>
5169
5170         * symfile.c (reread_symbols): Remove old comment.
5171         * objfiles.c (free_all_objfiles): Fix a typo.
5172
5173 2019-04-10  Tom Tromey  <tom@tromey.com>
5174
5175         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5176         * minsyms.c (lookup_minimal_symbol): Use foreach.
5177         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5178         (lookup_minimal_symbol_solib_trampoline): Likewise.
5179         * symfile.c (reread_symbols): Use foreach.
5180
5181 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5182             Tom Tromey  <tromey@adacore.com>
5183
5184         PR rust/24414:
5185         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5186         (rust_lex_int_test): Change "value" to be LONGEST.
5187         (rust_lex_tests): Add test for long integer literal.
5188
5189 2019-04-09  Tom Tromey  <tromey@adacore.com>
5190
5191         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5192         to bool.
5193         (extended_remote_target::attach): Update.
5194         (remote_target::remote_notice_new_inferior): Update.
5195         (remote_target::add_current_inferior_and_thread): Update.
5196         * inferior.c (exit_inferior_1): Use "false".
5197         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5198
5199 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5200
5201         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5202         the "start" command.
5203
5204 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5205
5206         * python/py-inferior.c (infpy_thread_from_thread_handle):
5207         Adjust comments to reflect renaming of thread_from_thread_handle
5208         to thread_from_handle.  Adjust keywords.  Fix type error message.
5209         (inferior_object_methods): Add thread_from_handle.  Retain
5210         thread_from_thread_handle, but mark it as deprecated.
5211
5212 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5213
5214         * gdbthread.h (find_thread_by_handle): Revise declaration.
5215         * thread.c (find_thread_by_handle): Likewise.  Adjust
5216         implementation too.
5217         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5218         support for buffer objects as handles.
5219
5220 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5221
5222         * python/py-infthread.c (thpy_thread_handle): New function.
5223         (thread_object_methods): Register thpy_thread_handle.
5224
5225 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5226
5227         * gdbthread.h (thread_to_thread_handle): Declare.
5228         * thread.c (gdbtypes.h): Include.
5229         (thread_to_thread_handle): New function.
5230
5231         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5232         (target_thread_info_to_thread_handle): Declare.
5233         * target.c (target_thread_info_to_thread_handle): New function.
5234         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5235         * target-delegates.c: Regenerate.
5236
5237         * linux-thread-db.c (class thread_db_target): Add method
5238         thread_info_to_thread_handle.
5239         (thread_db_target::thread_info_to_thread_handle): Define.
5240         * remote.c (class remote_target): Add new method
5241         thread_info_to_thread_handle.
5242         (remote_target::thread_info_to_thread_handle): Define.
5243
5244 2019-04-08  Pedro Alves  <palves@redhat.com>
5245
5246         * common/common-exceptions.c (throw_exception): Don't create
5247         named object to throw; throw directly.
5248         (throw_it): Likewise.  Don't initialize gdb_exception::message
5249         here, with new; pass FMT and AP to the ctor instead.
5250         * common/common-exceptions.h: Include <string>.
5251         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5252         const char *, va_list)): New ctor.  Use std::make_shared.
5253         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5254         errors)): Delete.
5255         (gdb_exception_error::gdb_exception_error(enum errors, const char
5256         *, va_list)): New.
5257         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5258         Add assertion.
5259         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5260         errors)): Delete.
5261         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5262         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5263         Add assertion.
5264
5265 2019-04-08  Tom Tromey  <tom@tromey.com>
5266
5267         * valops.c (value_rtti_indirect_type): Replace throw_exception
5268         with throw.
5269         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5270         with throw.
5271         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5272         throw.
5273         * target.c (target_translate_tls_address): Replace throw_exception
5274         with throw.
5275         * stack.c (frame_apply_command_count): Replace throw_exception
5276         with throw.
5277         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5278         throw.
5279         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5280         with throw.
5281         * rs6000-tdep.c (rs6000_frame_cache)
5282         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5283         * remote.c: Replace throw_exception with throw.
5284         * record-full.c (record_full_message, record_full_wait_1)
5285         (record_full_restore): Replace throw_exception with throw.
5286         * record-btrace.c:
5287         (get_thread_current_frame_id, record_btrace_start_replaying)
5288         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5289         (cmd_record_btrace_start): Replace throw_exception with throw.
5290         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5291         throw.
5292         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5293         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5294         * linespec.c:
5295         (find_linespec_symbols): Replace throw_exception with throw.
5296         * infrun.c (displaced_step_prepare, resume): Replace
5297         throw_exception with throw.
5298         * infcmd.c (post_create_inferior): Replace throw_exception with
5299         throw.
5300         * inf-loop.c (inferior_event_handler): Replace throw_exception
5301         with throw.
5302         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5303         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5304         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5305         (get_prev_frame_always, get_frame_pc_if_available)
5306         (get_frame_address_in_block_if_available, get_frame_language):
5307         Replace throw_exception with throw.
5308         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5309         throw_exception with throw.
5310         * eval.c (fetch_subexp_value, evaluate_var_value)
5311         (evaluate_funcall, evaluate_subexp_standard): Replace
5312         throw_exception with throw.
5313         * dwarf2loc.c (call_site_find_chain)
5314         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5315         Replace throw_exception with throw.
5316         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5317         with throw.
5318         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5319         throw.
5320         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5321         * completer.c (complete_line_internal): Replace throw_exception
5322         with throw.
5323         * compile/compile-object-run.c (compile_object_run): Replace
5324         throw_exception with throw.
5325         * cli/cli-script.c (process_next_line): Replace throw_exception
5326         with throw.
5327         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5328         (btrace_enable, btrace_maint_update_pt_packets): Replace
5329         throw_exception with throw.
5330         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5331         throw_exception with throw.
5332         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5333         throw_exception with throw.
5334         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5335         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5336         * aarch64-tdep.c (aarch64_make_prologue_cache)
5337         (aarch64_make_stub_cache): Replace throw_exception with throw.
5338
5339 2019-04-08  Tom Tromey  <tom@tromey.com>
5340
5341         * common/common-exceptions.c (throw_exception): Rename from
5342         throw_exception_cxx.  Remove old copy.  Make argument const.
5343         (throw_it): Create and throw exception objects directly.
5344         * common/common-exceptions.h (throw_exception): Make argument
5345         const.
5346         (struct gdb_exception_error): Add constructor.
5347         (struct gdb_exception_quit): Add constructor.
5348
5349 2019-04-08  Tom Tromey  <tom@tromey.com>
5350
5351         * common/common-exceptions.h (exception_rethrow): Don't declare.
5352         (TRY_SJLJ): Update comment.
5353         (TRY, CATCH, END_CATCH): Remove.
5354         * common/common-exceptions.c (exception_rethrow): Remove.
5355
5356 2019-04-08  Tom Tromey  <tom@tromey.com>
5357
5358         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5359         Remove.
5360         (gdb_exception_error): Rename from
5361         gdb_exception_RETURN_MASK_ERROR.
5362         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5363         (gdb_quit_bad_alloc): Update.
5364         * aarch64-tdep.c: Update.
5365         * ada-lang.c: Update.
5366         * ada-typeprint.c: Update.
5367         * ada-valprint.c: Update.
5368         * amd64-tdep.c: Update.
5369         * arch-utils.c: Update.
5370         * break-catch-throw.c: Update.
5371         * breakpoint.c: Update.
5372         * btrace.c: Update.
5373         * c-varobj.c: Update.
5374         * cli/cli-cmds.c: Update.
5375         * cli/cli-interp.c: Update.
5376         * cli/cli-script.c: Update.
5377         * common/common-exceptions.c: Update.
5378         * common/new-op.c: Update.
5379         * common/selftest.c: Update.
5380         * compile/compile-c-symbols.c: Update.
5381         * compile/compile-cplus-symbols.c: Update.
5382         * compile/compile-object-load.c: Update.
5383         * compile/compile-object-run.c: Update.
5384         * completer.c: Update.
5385         * corelow.c: Update.
5386         * cp-abi.c: Update.
5387         * cp-support.c: Update.
5388         * cp-valprint.c: Update.
5389         * darwin-nat.c: Update.
5390         * disasm-selftests.c: Update.
5391         * dtrace-probe.c: Update.
5392         * dwarf-index-cache.c: Update.
5393         * dwarf-index-write.c: Update.
5394         * dwarf2-frame-tailcall.c: Update.
5395         * dwarf2-frame.c: Update.
5396         * dwarf2loc.c: Update.
5397         * dwarf2read.c: Update.
5398         * eval.c: Update.
5399         * event-loop.c: Update.
5400         * event-top.c: Update.
5401         * exec.c: Update.
5402         * f-valprint.c: Update.
5403         * fbsd-tdep.c: Update.
5404         * frame-unwind.c: Update.
5405         * frame.c: Update.
5406         * gdbtypes.c: Update.
5407         * gnu-v3-abi.c: Update.
5408         * guile/guile-internal.h: Update.
5409         * guile/scm-block.c: Update.
5410         * guile/scm-breakpoint.c: Update.
5411         * guile/scm-cmd.c: Update.
5412         * guile/scm-disasm.c: Update.
5413         * guile/scm-frame.c: Update.
5414         * guile/scm-lazy-string.c: Update.
5415         * guile/scm-math.c: Update.
5416         * guile/scm-param.c: Update.
5417         * guile/scm-ports.c: Update.
5418         * guile/scm-pretty-print.c: Update.
5419         * guile/scm-symbol.c: Update.
5420         * guile/scm-symtab.c: Update.
5421         * guile/scm-type.c: Update.
5422         * guile/scm-value.c: Update.
5423         * i386-linux-tdep.c: Update.
5424         * i386-tdep.c: Update.
5425         * inf-loop.c: Update.
5426         * infcall.c: Update.
5427         * infcmd.c: Update.
5428         * infrun.c: Update.
5429         * jit.c: Update.
5430         * language.c: Update.
5431         * linespec.c: Update.
5432         * linux-fork.c: Update.
5433         * linux-nat.c: Update.
5434         * linux-tdep.c: Update.
5435         * linux-thread-db.c: Update.
5436         * main.c: Update.
5437         * mi/mi-cmd-break.c: Update.
5438         * mi/mi-cmd-stack.c: Update.
5439         * mi/mi-interp.c: Update.
5440         * mi/mi-main.c: Update.
5441         * objc-lang.c: Update.
5442         * p-valprint.c: Update.
5443         * parse.c: Update.
5444         * ppc-linux-tdep.c: Update.
5445         * printcmd.c: Update.
5446         * python/py-arch.c: Update.
5447         * python/py-breakpoint.c: Update.
5448         * python/py-cmd.c: Update.
5449         * python/py-finishbreakpoint.c: Update.
5450         * python/py-frame.c: Update.
5451         * python/py-framefilter.c: Update.
5452         * python/py-gdb-readline.c: Update.
5453         * python/py-inferior.c: Update.
5454         * python/py-infthread.c: Update.
5455         * python/py-lazy-string.c: Update.
5456         * python/py-linetable.c: Update.
5457         * python/py-objfile.c: Update.
5458         * python/py-param.c: Update.
5459         * python/py-prettyprint.c: Update.
5460         * python/py-progspace.c: Update.
5461         * python/py-record-btrace.c: Update.
5462         * python/py-record.c: Update.
5463         * python/py-symbol.c: Update.
5464         * python/py-type.c: Update.
5465         * python/py-unwind.c: Update.
5466         * python/py-utils.c: Update.
5467         * python/py-value.c: Update.
5468         * python/python.c: Update.
5469         * record-btrace.c: Update.
5470         * record-full.c: Update.
5471         * remote-fileio.c: Update.
5472         * remote.c: Update.
5473         * riscv-tdep.c: Update.
5474         * rs6000-aix-tdep.c: Update.
5475         * rs6000-tdep.c: Update.
5476         * rust-exp.y: Update.
5477         * rust-lang.c: Update.
5478         * s390-tdep.c: Update.
5479         * selftest-arch.c: Update.
5480         * solib-dsbt.c: Update.
5481         * solib-frv.c: Update.
5482         * solib-spu.c: Update.
5483         * solib-svr4.c: Update.
5484         * solib.c: Update.
5485         * sparc64-linux-tdep.c: Update.
5486         * stack.c: Update.
5487         * symfile-mem.c: Update.
5488         * symmisc.c: Update.
5489         * target.c: Update.
5490         * thread.c: Update.
5491         * top.c: Update.
5492         * tracefile-tfile.c: Update.
5493         * tui/tui.c: Update.
5494         * typeprint.c: Update.
5495         * unittests/cli-utils-selftests.c: Update.
5496         * unittests/parse-connection-spec-selftests.c: Update.
5497         * valops.c: Update.
5498         * valprint.c: Update.
5499         * value.c: Update.
5500         * varobj.c: Update.
5501         * windows-nat.c: Update.
5502         * x86-linux-nat.c: Update.
5503         * xml-support.c: Update.
5504
5505 2019-04-08  Tom Tromey  <tom@tromey.com>
5506
5507         * xml-support.c: Use C++ exception handling.
5508         * x86-linux-nat.c: Use C++ exception handling.
5509         * windows-nat.c: Use C++ exception handling.
5510         * varobj.c: Use C++ exception handling.
5511         * value.c: Use C++ exception handling.
5512         * valprint.c: Use C++ exception handling.
5513         * valops.c: Use C++ exception handling.
5514         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5515         handling.
5516         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5517         * typeprint.c: Use C++ exception handling.
5518         * tui/tui.c: Use C++ exception handling.
5519         * tracefile-tfile.c: Use C++ exception handling.
5520         * top.c: Use C++ exception handling.
5521         * thread.c: Use C++ exception handling.
5522         * target.c: Use C++ exception handling.
5523         * symmisc.c: Use C++ exception handling.
5524         * symfile-mem.c: Use C++ exception handling.
5525         * stack.c: Use C++ exception handling.
5526         * sparc64-linux-tdep.c: Use C++ exception handling.
5527         * solib.c: Use C++ exception handling.
5528         * solib-svr4.c: Use C++ exception handling.
5529         * solib-spu.c: Use C++ exception handling.
5530         * solib-frv.c: Use C++ exception handling.
5531         * solib-dsbt.c: Use C++ exception handling.
5532         * selftest-arch.c: Use C++ exception handling.
5533         * s390-tdep.c: Use C++ exception handling.
5534         * rust-lang.c: Use C++ exception handling.
5535         * rust-exp.y: Use C++ exception handling.
5536         * rs6000-tdep.c: Use C++ exception handling.
5537         * rs6000-aix-tdep.c: Use C++ exception handling.
5538         * riscv-tdep.c: Use C++ exception handling.
5539         * remote.c: Use C++ exception handling.
5540         * remote-fileio.c: Use C++ exception handling.
5541         * record-full.c: Use C++ exception handling.
5542         * record-btrace.c: Use C++ exception handling.
5543         * python/python.c: Use C++ exception handling.
5544         * python/py-value.c: Use C++ exception handling.
5545         * python/py-utils.c: Use C++ exception handling.
5546         * python/py-unwind.c: Use C++ exception handling.
5547         * python/py-type.c: Use C++ exception handling.
5548         * python/py-symbol.c: Use C++ exception handling.
5549         * python/py-record.c: Use C++ exception handling.
5550         * python/py-record-btrace.c: Use C++ exception handling.
5551         * python/py-progspace.c: Use C++ exception handling.
5552         * python/py-prettyprint.c: Use C++ exception handling.
5553         * python/py-param.c: Use C++ exception handling.
5554         * python/py-objfile.c: Use C++ exception handling.
5555         * python/py-linetable.c: Use C++ exception handling.
5556         * python/py-lazy-string.c: Use C++ exception handling.
5557         * python/py-infthread.c: Use C++ exception handling.
5558         * python/py-inferior.c: Use C++ exception handling.
5559         * python/py-gdb-readline.c: Use C++ exception handling.
5560         * python/py-framefilter.c: Use C++ exception handling.
5561         * python/py-frame.c: Use C++ exception handling.
5562         * python/py-finishbreakpoint.c: Use C++ exception handling.
5563         * python/py-cmd.c: Use C++ exception handling.
5564         * python/py-breakpoint.c: Use C++ exception handling.
5565         * python/py-arch.c: Use C++ exception handling.
5566         * printcmd.c: Use C++ exception handling.
5567         * ppc-linux-tdep.c: Use C++ exception handling.
5568         * parse.c: Use C++ exception handling.
5569         * p-valprint.c: Use C++ exception handling.
5570         * objc-lang.c: Use C++ exception handling.
5571         * mi/mi-main.c: Use C++ exception handling.
5572         * mi/mi-interp.c: Use C++ exception handling.
5573         * mi/mi-cmd-stack.c: Use C++ exception handling.
5574         * mi/mi-cmd-break.c: Use C++ exception handling.
5575         * main.c: Use C++ exception handling.
5576         * linux-thread-db.c: Use C++ exception handling.
5577         * linux-tdep.c: Use C++ exception handling.
5578         * linux-nat.c: Use C++ exception handling.
5579         * linux-fork.c: Use C++ exception handling.
5580         * linespec.c: Use C++ exception handling.
5581         * language.c: Use C++ exception handling.
5582         * jit.c: Use C++ exception handling.
5583         * infrun.c: Use C++ exception handling.
5584         * infcmd.c: Use C++ exception handling.
5585         * infcall.c: Use C++ exception handling.
5586         * inf-loop.c: Use C++ exception handling.
5587         * i386-tdep.c: Use C++ exception handling.
5588         * i386-linux-tdep.c: Use C++ exception handling.
5589         * guile/scm-value.c: Use C++ exception handling.
5590         * guile/scm-type.c: Use C++ exception handling.
5591         * guile/scm-symtab.c: Use C++ exception handling.
5592         * guile/scm-symbol.c: Use C++ exception handling.
5593         * guile/scm-pretty-print.c: Use C++ exception handling.
5594         * guile/scm-ports.c: Use C++ exception handling.
5595         * guile/scm-param.c: Use C++ exception handling.
5596         * guile/scm-math.c: Use C++ exception handling.
5597         * guile/scm-lazy-string.c: Use C++ exception handling.
5598         * guile/scm-frame.c: Use C++ exception handling.
5599         * guile/scm-disasm.c: Use C++ exception handling.
5600         * guile/scm-cmd.c: Use C++ exception handling.
5601         * guile/scm-breakpoint.c: Use C++ exception handling.
5602         * guile/scm-block.c: Use C++ exception handling.
5603         * guile/guile-internal.h: Use C++ exception handling.
5604         * gnu-v3-abi.c: Use C++ exception handling.
5605         * gdbtypes.c: Use C++ exception handling.
5606         * frame.c: Use C++ exception handling.
5607         * frame-unwind.c: Use C++ exception handling.
5608         * fbsd-tdep.c: Use C++ exception handling.
5609         * f-valprint.c: Use C++ exception handling.
5610         * exec.c: Use C++ exception handling.
5611         * event-top.c: Use C++ exception handling.
5612         * event-loop.c: Use C++ exception handling.
5613         * eval.c: Use C++ exception handling.
5614         * dwarf2read.c: Use C++ exception handling.
5615         * dwarf2loc.c: Use C++ exception handling.
5616         * dwarf2-frame.c: Use C++ exception handling.
5617         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5618         * dwarf-index-write.c: Use C++ exception handling.
5619         * dwarf-index-cache.c: Use C++ exception handling.
5620         * dtrace-probe.c: Use C++ exception handling.
5621         * disasm-selftests.c: Use C++ exception handling.
5622         * darwin-nat.c: Use C++ exception handling.
5623         * cp-valprint.c: Use C++ exception handling.
5624         * cp-support.c: Use C++ exception handling.
5625         * cp-abi.c: Use C++ exception handling.
5626         * corelow.c: Use C++ exception handling.
5627         * completer.c: Use C++ exception handling.
5628         * compile/compile-object-run.c: Use C++ exception handling.
5629         * compile/compile-object-load.c: Use C++ exception handling.
5630         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5631         * compile/compile-c-symbols.c: Use C++ exception handling.
5632         * common/selftest.c: Use C++ exception handling.
5633         * common/new-op.c: Use C++ exception handling.
5634         * cli/cli-script.c: Use C++ exception handling.
5635         * cli/cli-interp.c: Use C++ exception handling.
5636         * cli/cli-cmds.c: Use C++ exception handling.
5637         * c-varobj.c: Use C++ exception handling.
5638         * btrace.c: Use C++ exception handling.
5639         * breakpoint.c: Use C++ exception handling.
5640         * break-catch-throw.c: Use C++ exception handling.
5641         * arch-utils.c: Use C++ exception handling.
5642         * amd64-tdep.c: Use C++ exception handling.
5643         * ada-valprint.c: Use C++ exception handling.
5644         * ada-typeprint.c: Use C++ exception handling.
5645         * ada-lang.c: Use C++ exception handling.
5646         * aarch64-tdep.c: Use C++ exception handling.
5647
5648 2019-04-08  Tom Tromey  <tom@tromey.com>
5649
5650         * xml-support.c (gdb_xml_parser::parse): Update.
5651         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5652         * value.c (show_convenience): Update.
5653         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5654         (test_parse_flags_qcs): Update.
5655         * thread.c (thr_try_catch_cmd): Update.
5656         * target.c (target_translate_tls_address): Update.
5657         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5658         (info_frame_command_core, frame_apply_command_count): Update.
5659         * rust-exp.y (rust_lex_exception_test): Update.
5660         * riscv-tdep.c (riscv_print_one_register_info): Update.
5661         * remote.c (remote_target::enable_btrace): Update.
5662         * record-btrace.c (record_btrace_enable_warn): Update.
5663         * python/py-utils.c (gdbpy_convert_exception): Update.
5664         * printcmd.c (do_one_display, print_variable_and_value): Update.
5665         * mi/mi-main.c (mi_print_exception): Update.
5666         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5667         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5668         * linux-nat.c (linux_nat_target::attach): Update.
5669         * linux-fork.c (class scoped_switch_fork_info): Update.
5670         * infrun.c (displaced_step_prepare): Update.
5671         * infcall.c (call_function_by_hand_dummy): Update.
5672         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5673         * gnu-v3-abi.c (print_one_vtable): Update.
5674         * frame.c (get_prev_frame_always): Update.
5675         * f-valprint.c (info_common_command_for_block): Update.
5676         * exec.c (try_open_exec_file): Update.
5677         * exceptions.c (print_exception, exception_print)
5678         (exception_fprintf, exception_print_same): Update.
5679         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5680         * dwarf-index-cache.c (index_cache::store)
5681         (index_cache::lookup_gdb_index): Update.
5682         * darwin-nat.c (maybe_cache_shell): Update.
5683         * cp-valprint.c (cp_print_value_fields): Update.
5684         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5685         (gcc_cplus_symbol_address): Update.
5686         * compile/compile-c-symbols.c (gcc_convert_symbol)
5687         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5688         * common/selftest.c: Update.
5689         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5690         a std::string.
5691         (exception_try_scope_entry, exception_try_scope_exit): Don't
5692         declare.
5693         (struct exception_try_scope): Remove.
5694         (TRY): Don't use exception_try_scope.
5695         (struct gdb_exception): Add constructor, operator=.
5696         <what>: New method.
5697         (struct gdb_exception_RETURN_MASK_ALL)
5698         (struct gdb_exception_RETURN_MASK_ERROR)
5699         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5700         (struct gdb_quit_bad_alloc): Update.
5701         * common/common-exceptions.c (exception_none): Change
5702         initializer.
5703         (struct catcher) <state, exception>: Initialize inline.
5704         <prev>: Remove member.
5705         (current_catcher): Remove.
5706         (catchers): New global.
5707         (exceptions_state_mc_init): Simplify.
5708         (catcher_pop): Remove.
5709         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5710         (try_scope_depth, exception_try_scope_entry)
5711         (exception_try_scope_exit): Remove.
5712         (throw_exception_sjlj): Update.
5713         (exception_messages, exception_messages_size): Remove.
5714         (throw_it): Simplify.
5715         (gdb_exception_sliced_copy): Remove.
5716         (throw_exception_cxx): Update.
5717         * cli/cli-script.c (script_from_file): Update.
5718         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5719         Update.
5720         * ada-valprint.c (ada_val_print): Update.
5721         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5722         (create_excep_cond_exprs): Update.
5723
5724 2019-04-08  Tom Tromey  <tom@tromey.com>
5725
5726         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5727         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5728         (TRY, CATCH, END_CATCH): Remove some definitions.
5729         * common/common-exceptions.c: Don't use GDB_XCPT.
5730         (catcher_list_size): Remove.
5731         (throw_exception, throw_it): Simplify.
5732
5733 2019-04-05  Tom Tromey  <tom@tromey.com>
5734
5735         Revert the header-sorting patch.
5736         * ft32-tdep.c: Revert.
5737         * frv-tdep.c: Revert.
5738         * frv-linux-tdep.c: Revert.
5739         * frame.c: Revert.
5740         * frame-unwind.c: Revert.
5741         * frame-base.c: Revert.
5742         * fork-child.c: Revert.
5743         * findvar.c: Revert.
5744         * findcmd.c: Revert.
5745         * filesystem.c: Revert.
5746         * filename-seen-cache.h: Revert.
5747         * filename-seen-cache.c: Revert.
5748         * fbsd-tdep.c: Revert.
5749         * fbsd-nat.h: Revert.
5750         * fbsd-nat.c: Revert.
5751         * f-valprint.c: Revert.
5752         * f-typeprint.c: Revert.
5753         * f-lang.c: Revert.
5754         * extension.h: Revert.
5755         * extension.c: Revert.
5756         * extension-priv.h: Revert.
5757         * expprint.c: Revert.
5758         * exec.h: Revert.
5759         * exec.c: Revert.
5760         * exceptions.c: Revert.
5761         * event-top.c: Revert.
5762         * event-loop.c: Revert.
5763         * eval.c: Revert.
5764         * elfread.c: Revert.
5765         * dwarf2read.h: Revert.
5766         * dwarf2read.c: Revert.
5767         * dwarf2loc.c: Revert.
5768         * dwarf2expr.h: Revert.
5769         * dwarf2expr.c: Revert.
5770         * dwarf2-frame.c: Revert.
5771         * dwarf2-frame-tailcall.c: Revert.
5772         * dwarf-index-write.h: Revert.
5773         * dwarf-index-write.c: Revert.
5774         * dwarf-index-common.c: Revert.
5775         * dwarf-index-cache.h: Revert.
5776         * dwarf-index-cache.c: Revert.
5777         * dummy-frame.c: Revert.
5778         * dtrace-probe.c: Revert.
5779         * disasm.h: Revert.
5780         * disasm.c: Revert.
5781         * disasm-selftests.c: Revert.
5782         * dictionary.c: Revert.
5783         * dicos-tdep.c: Revert.
5784         * demangle.c: Revert.
5785         * dcache.h: Revert.
5786         * dcache.c: Revert.
5787         * darwin-nat.h: Revert.
5788         * darwin-nat.c: Revert.
5789         * darwin-nat-info.c: Revert.
5790         * d-valprint.c: Revert.
5791         * d-namespace.c: Revert.
5792         * d-lang.c: Revert.
5793         * ctf.c: Revert.
5794         * csky-tdep.c: Revert.
5795         * csky-linux-tdep.c: Revert.
5796         * cris-tdep.c: Revert.
5797         * cris-linux-tdep.c: Revert.
5798         * cp-valprint.c: Revert.
5799         * cp-support.c: Revert.
5800         * cp-namespace.c: Revert.
5801         * cp-abi.c: Revert.
5802         * corelow.c: Revert.
5803         * corefile.c: Revert.
5804         * continuations.c: Revert.
5805         * completer.h: Revert.
5806         * completer.c: Revert.
5807         * complaints.c: Revert.
5808         * coffread.c: Revert.
5809         * coff-pe-read.c: Revert.
5810         * cli-out.h: Revert.
5811         * cli-out.c: Revert.
5812         * charset.c: Revert.
5813         * c-varobj.c: Revert.
5814         * c-valprint.c: Revert.
5815         * c-typeprint.c: Revert.
5816         * c-lang.c: Revert.
5817         * buildsym.c: Revert.
5818         * buildsym-legacy.c: Revert.
5819         * build-id.h: Revert.
5820         * build-id.c: Revert.
5821         * btrace.c: Revert.
5822         * bsd-uthread.c: Revert.
5823         * breakpoint.h: Revert.
5824         * breakpoint.c: Revert.
5825         * break-catch-throw.c: Revert.
5826         * break-catch-syscall.c: Revert.
5827         * break-catch-sig.c: Revert.
5828         * blockframe.c: Revert.
5829         * block.c: Revert.
5830         * bfin-tdep.c: Revert.
5831         * bfin-linux-tdep.c: Revert.
5832         * bfd-target.c: Revert.
5833         * bcache.c: Revert.
5834         * ax-general.c: Revert.
5835         * ax-gdb.h: Revert.
5836         * ax-gdb.c: Revert.
5837         * avr-tdep.c: Revert.
5838         * auxv.c: Revert.
5839         * auto-load.c: Revert.
5840         * arm-wince-tdep.c: Revert.
5841         * arm-tdep.c: Revert.
5842         * arm-symbian-tdep.c: Revert.
5843         * arm-pikeos-tdep.c: Revert.
5844         * arm-obsd-tdep.c: Revert.
5845         * arm-nbsd-tdep.c: Revert.
5846         * arm-nbsd-nat.c: Revert.
5847         * arm-linux-tdep.c: Revert.
5848         * arm-linux-nat.c: Revert.
5849         * arm-fbsd-tdep.c: Revert.
5850         * arm-fbsd-nat.c: Revert.
5851         * arm-bsd-tdep.c: Revert.
5852         * arch-utils.c: Revert.
5853         * arc-tdep.c: Revert.
5854         * arc-newlib-tdep.c: Revert.
5855         * annotate.h: Revert.
5856         * annotate.c: Revert.
5857         * amd64-windows-tdep.c: Revert.
5858         * amd64-windows-nat.c: Revert.
5859         * amd64-tdep.c: Revert.
5860         * amd64-sol2-tdep.c: Revert.
5861         * amd64-obsd-tdep.c: Revert.
5862         * amd64-obsd-nat.c: Revert.
5863         * amd64-nbsd-tdep.c: Revert.
5864         * amd64-nbsd-nat.c: Revert.
5865         * amd64-nat.c: Revert.
5866         * amd64-linux-tdep.c: Revert.
5867         * amd64-linux-nat.c: Revert.
5868         * amd64-fbsd-tdep.c: Revert.
5869         * amd64-fbsd-nat.c: Revert.
5870         * amd64-dicos-tdep.c: Revert.
5871         * amd64-darwin-tdep.c: Revert.
5872         * amd64-bsd-nat.c: Revert.
5873         * alpha-tdep.c: Revert.
5874         * alpha-obsd-tdep.c: Revert.
5875         * alpha-nbsd-tdep.c: Revert.
5876         * alpha-mdebug-tdep.c: Revert.
5877         * alpha-linux-tdep.c: Revert.
5878         * alpha-linux-nat.c: Revert.
5879         * alpha-bsd-tdep.c: Revert.
5880         * alpha-bsd-nat.c: Revert.
5881         * aix-thread.c: Revert.
5882         * agent.c: Revert.
5883         * addrmap.c: Revert.
5884         * ada-varobj.c: Revert.
5885         * ada-valprint.c: Revert.
5886         * ada-typeprint.c: Revert.
5887         * ada-tasks.c: Revert.
5888         * ada-lang.c: Revert.
5889         * aarch64-tdep.c: Revert.
5890         * aarch64-ravenscar-thread.c: Revert.
5891         * aarch64-newlib-tdep.c: Revert.
5892         * aarch64-linux-tdep.c: Revert.
5893         * aarch64-linux-nat.c: Revert.
5894         * aarch64-fbsd-tdep.c: Revert.
5895         * aarch64-fbsd-nat.c: Revert.
5896         * aarch32-linux-nat.c: Revert.
5897
5898 2019-04-05  Tom Tromey  <tom@tromey.com>
5899
5900         * ft32-tdep.c: Sort headers.
5901         * frv-tdep.c: Sort headers.
5902         * frv-linux-tdep.c: Sort headers.
5903         * frame.c: Sort headers.
5904         * frame-unwind.c: Sort headers.
5905         * frame-base.c: Sort headers.
5906         * fork-child.c: Sort headers.
5907         * findvar.c: Sort headers.
5908         * findcmd.c: Sort headers.
5909         * filesystem.c: Sort headers.
5910         * filename-seen-cache.h: Sort headers.
5911         * filename-seen-cache.c: Sort headers.
5912         * fbsd-tdep.c: Sort headers.
5913         * fbsd-nat.h: Sort headers.
5914         * fbsd-nat.c: Sort headers.
5915         * f-valprint.c: Sort headers.
5916         * f-typeprint.c: Sort headers.
5917         * f-lang.c: Sort headers.
5918         * extension.h: Sort headers.
5919         * extension.c: Sort headers.
5920         * extension-priv.h: Sort headers.
5921         * expprint.c: Sort headers.
5922         * exec.h: Sort headers.
5923         * exec.c: Sort headers.
5924         * exceptions.c: Sort headers.
5925         * event-top.c: Sort headers.
5926         * event-loop.c: Sort headers.
5927         * eval.c: Sort headers.
5928         * elfread.c: Sort headers.
5929         * dwarf2read.h: Sort headers.
5930         * dwarf2read.c: Sort headers.
5931         * dwarf2loc.c: Sort headers.
5932         * dwarf2expr.h: Sort headers.
5933         * dwarf2expr.c: Sort headers.
5934         * dwarf2-frame.c: Sort headers.
5935         * dwarf2-frame-tailcall.c: Sort headers.
5936         * dwarf-index-write.h: Sort headers.
5937         * dwarf-index-write.c: Sort headers.
5938         * dwarf-index-common.c: Sort headers.
5939         * dwarf-index-cache.h: Sort headers.
5940         * dwarf-index-cache.c: Sort headers.
5941         * dummy-frame.c: Sort headers.
5942         * dtrace-probe.c: Sort headers.
5943         * disasm.h: Sort headers.
5944         * disasm.c: Sort headers.
5945         * disasm-selftests.c: Sort headers.
5946         * dictionary.c: Sort headers.
5947         * dicos-tdep.c: Sort headers.
5948         * demangle.c: Sort headers.
5949         * dcache.h: Sort headers.
5950         * dcache.c: Sort headers.
5951         * darwin-nat.h: Sort headers.
5952         * darwin-nat.c: Sort headers.
5953         * darwin-nat-info.c: Sort headers.
5954         * d-valprint.c: Sort headers.
5955         * d-namespace.c: Sort headers.
5956         * d-lang.c: Sort headers.
5957         * ctf.c: Sort headers.
5958         * csky-tdep.c: Sort headers.
5959         * csky-linux-tdep.c: Sort headers.
5960         * cris-tdep.c: Sort headers.
5961         * cris-linux-tdep.c: Sort headers.
5962         * cp-valprint.c: Sort headers.
5963         * cp-support.c: Sort headers.
5964         * cp-namespace.c: Sort headers.
5965         * cp-abi.c: Sort headers.
5966         * corelow.c: Sort headers.
5967         * corefile.c: Sort headers.
5968         * continuations.c: Sort headers.
5969         * completer.h: Sort headers.
5970         * completer.c: Sort headers.
5971         * complaints.c: Sort headers.
5972         * coffread.c: Sort headers.
5973         * coff-pe-read.c: Sort headers.
5974         * cli-out.h: Sort headers.
5975         * cli-out.c: Sort headers.
5976         * charset.c: Sort headers.
5977         * c-varobj.c: Sort headers.
5978         * c-valprint.c: Sort headers.
5979         * c-typeprint.c: Sort headers.
5980         * c-lang.c: Sort headers.
5981         * buildsym.c: Sort headers.
5982         * buildsym-legacy.c: Sort headers.
5983         * build-id.h: Sort headers.
5984         * build-id.c: Sort headers.
5985         * btrace.c: Sort headers.
5986         * bsd-uthread.c: Sort headers.
5987         * breakpoint.h: Sort headers.
5988         * breakpoint.c: Sort headers.
5989         * break-catch-throw.c: Sort headers.
5990         * break-catch-syscall.c: Sort headers.
5991         * break-catch-sig.c: Sort headers.
5992         * blockframe.c: Sort headers.
5993         * block.c: Sort headers.
5994         * bfin-tdep.c: Sort headers.
5995         * bfin-linux-tdep.c: Sort headers.
5996         * bfd-target.c: Sort headers.
5997         * bcache.c: Sort headers.
5998         * ax-general.c: Sort headers.
5999         * ax-gdb.h: Sort headers.
6000         * ax-gdb.c: Sort headers.
6001         * avr-tdep.c: Sort headers.
6002         * auxv.c: Sort headers.
6003         * auto-load.c: Sort headers.
6004         * arm-wince-tdep.c: Sort headers.
6005         * arm-tdep.c: Sort headers.
6006         * arm-symbian-tdep.c: Sort headers.
6007         * arm-pikeos-tdep.c: Sort headers.
6008         * arm-obsd-tdep.c: Sort headers.
6009         * arm-nbsd-tdep.c: Sort headers.
6010         * arm-nbsd-nat.c: Sort headers.
6011         * arm-linux-tdep.c: Sort headers.
6012         * arm-linux-nat.c: Sort headers.
6013         * arm-fbsd-tdep.c: Sort headers.
6014         * arm-fbsd-nat.c: Sort headers.
6015         * arm-bsd-tdep.c: Sort headers.
6016         * arch-utils.c: Sort headers.
6017         * arc-tdep.c: Sort headers.
6018         * arc-newlib-tdep.c: Sort headers.
6019         * annotate.h: Sort headers.
6020         * annotate.c: Sort headers.
6021         * amd64-windows-tdep.c: Sort headers.
6022         * amd64-windows-nat.c: Sort headers.
6023         * amd64-tdep.c: Sort headers.
6024         * amd64-sol2-tdep.c: Sort headers.
6025         * amd64-obsd-tdep.c: Sort headers.
6026         * amd64-obsd-nat.c: Sort headers.
6027         * amd64-nbsd-tdep.c: Sort headers.
6028         * amd64-nbsd-nat.c: Sort headers.
6029         * amd64-nat.c: Sort headers.
6030         * amd64-linux-tdep.c: Sort headers.
6031         * amd64-linux-nat.c: Sort headers.
6032         * amd64-fbsd-tdep.c: Sort headers.
6033         * amd64-fbsd-nat.c: Sort headers.
6034         * amd64-dicos-tdep.c: Sort headers.
6035         * amd64-darwin-tdep.c: Sort headers.
6036         * amd64-bsd-nat.c: Sort headers.
6037         * alpha-tdep.c: Sort headers.
6038         * alpha-obsd-tdep.c: Sort headers.
6039         * alpha-nbsd-tdep.c: Sort headers.
6040         * alpha-mdebug-tdep.c: Sort headers.
6041         * alpha-linux-tdep.c: Sort headers.
6042         * alpha-linux-nat.c: Sort headers.
6043         * alpha-bsd-tdep.c: Sort headers.
6044         * alpha-bsd-nat.c: Sort headers.
6045         * aix-thread.c: Sort headers.
6046         * agent.c: Sort headers.
6047         * addrmap.c: Sort headers.
6048         * ada-varobj.c: Sort headers.
6049         * ada-valprint.c: Sort headers.
6050         * ada-typeprint.c: Sort headers.
6051         * ada-tasks.c: Sort headers.
6052         * ada-lang.c: Sort headers.
6053         * aarch64-tdep.c: Sort headers.
6054         * aarch64-ravenscar-thread.c: Sort headers.
6055         * aarch64-newlib-tdep.c: Sort headers.
6056         * aarch64-linux-tdep.c: Sort headers.
6057         * aarch64-linux-nat.c: Sort headers.
6058         * aarch64-fbsd-tdep.c: Sort headers.
6059         * aarch64-fbsd-nat.c: Sort headers.
6060         * aarch32-linux-nat.c: Sort headers.
6061
6062 2019-04-04  Tom Tromey  <tom@tromey.com>
6063
6064         * varobj.c (varobj_create): Update.
6065         * rust-exp.y (struct rust_parser) <update_innermost_block,
6066         lookup_symbol>: New methods.
6067         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6068         Rename.
6069         (rust_parser::rust_lookup_type)
6070         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6071         * printcmd.c (display_command, do_one_display): Update.
6072         * parser-defs.h (struct parser_state) <parser_state>: Add
6073         "tracker" parameter.
6074         (block_tracker): New member.
6075         (class innermost_block_tracker) <innermost_block_tracker>: Add
6076         "types" parameter.
6077         <reset>: Remove method.
6078         (innermost_block): Don't declare.
6079         (null_post_parser): Update.
6080         * parse.c (innermost_block): Remove global.
6081         (write_dollar_variable): Update.
6082         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6083         Remove "tracker_types" parameter.
6084         (parse_expression): Add "tracker" parameter.
6085         (parse_expression_for_completion): Update.
6086         (null_post_parser): Add "tracker" parameter.
6087         * p-exp.y: Update rules.
6088         * m2-exp.y: Update rules.
6089         * language.h (struct language_defn) <la_post_parser>: Add
6090         "tracker" parameter.
6091         * go-exp.y: Update rules.
6092         * f-exp.y: Update rules.
6093         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6094         parameter.
6095         * d-exp.y: Update rules.
6096         * c-exp.y: Update rules.
6097         * breakpoint.c (set_breakpoint_condition): Create an
6098         innermost_block_tracker.
6099         (watch_command_1): Likewise.
6100         * ada-lang.c (resolve): Add "tracker" parameter.
6101         (resolve_subexp): Likewise.
6102         * ada-exp.y (write_var_from_sym): Update.
6103
6104 2019-04-04  Tom Tromey  <tom@tromey.com>
6105
6106         * type-stack.h: New file.
6107         * type-stack.c: New file.
6108         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6109         type-stack.h.
6110         (insert_into_type_stack, insert_type, push_type, push_type_int)
6111         (insert_type_address_space, pop_type, pop_type_int)
6112         (pop_typelist, pop_type_stack, append_type_stack)
6113         (push_type_stack, get_type_stack, push_typelist)
6114         (follow_type_instance_flags, follow_types): Don't declare.
6115         * parse.c (type_stack): Remove global.
6116         (parse_exp_in_context): Update.
6117         (insert_into_type_stack, insert_type, push_type, push_type_int)
6118         (insert_type_address_space, pop_type, pop_type_int)
6119         (pop_typelist, pop_type_stack, append_type_stack)
6120         (push_type_stack, get_type_stack, push_typelist)
6121         (follow_type_instance_flags, follow_types): Remove (moved to
6122         type-stack.c).
6123         * f-exp.y (type_stack): New global.
6124         Update rules.
6125         (push_kind_type, f_parse): Update.
6126         * d-exp.y (type_stack): New global.
6127         Update rules.
6128         (d_parse): Update.
6129         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6130         Update rules.
6131         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6132         (HFILES_NO_SRCDIR): Add type-stack.h.
6133
6134 2019-04-04  Tom Tromey  <tom@tromey.com>
6135
6136         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6137         (rust_parser::convert_ast_to_expression, rust_parse)
6138         (rust_lex_test_completion, rust_lex_tests): Update.
6139         * parser-defs.h (struct expr_completion_state): New.
6140         (struct parser_state) <parser_state>: Add completion parameter.
6141         <mark_struct_expression, mark_completion_tag>: New methods.
6142         <parse_completion, m_completion_state>: New members.
6143         (prefixify_expression, null_post_parser): Update.
6144         (mark_struct_expression, mark_completion_tag): Don't declare.
6145         * parse.c (parse_completion, expout_last_struct)
6146         (expout_tag_completion_type, expout_completion_name): Remove
6147         globals.
6148         (parser_state::mark_struct_expression)
6149         (parser_state::mark_completion_tag): Now methods.
6150         (prefixify_expression): Add last_struct parameter.
6151         (prefixify_subexp): Likewise.
6152         (parse_exp_1): Update.
6153         (parse_exp_in_context): Add cstate parameter.  Update.
6154         (parse_expression_for_completion): Create an
6155         expr_completion_state.
6156         (null_post_parser): Add "completion" parameter.
6157         * p-exp.y: Update rules.
6158         (yylex): Update.
6159         * language.h (struct language_defn) <la_post_parser>: Add
6160         "completing" parameter.
6161         * go-exp.y: Update rules.
6162         (lex_one_token): Update.
6163         * expression.h (parse_completion): Don't declare.
6164         * d-exp.y: Update rules.
6165         (lex_one_token): Update rules.
6166         * c-exp.y: Update rules.
6167         (lex_one_token): Update.
6168         * ada-lang.c (resolve): Add "parse_completion" parameter.
6169         (resolve_subexp): Likewise.
6170         (ada_resolve_function): Likewise.
6171
6172 2019-04-04  Tom Tromey  <tom@tromey.com>
6173
6174         * parser-defs.h (struct parser_state) <start_arglist,
6175         end_arglist>: New methods.
6176         <arglist_len, m_funcall_chain>: New members.
6177         (arglist_len, start_arglist, end_arglist): Don't declare.
6178         * parse.c (arglist_len, funcall_chain): Remove global.
6179         (start_arglist, end_arglist): Remove functions.
6180         (parse_exp_in_context): Update.
6181         * p-exp.y: Update rules.
6182         * m2-exp.y: Update rules.
6183         * go-exp.y: Update rules.
6184         * f-exp.y: Update rules.
6185         * d-exp.y: Update rules.
6186         * c-exp.y: Update rules.
6187
6188 2019-04-04  Tom Tromey  <tom@tromey.com>
6189
6190         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6191         lex_operator, push_back>: New methods.
6192         Update all rules.
6193         (rust_parser::lex_hex, lex_escape): Rename and update.
6194         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6195         (rust_parser::lex_operator): Rename and update.
6196         (rust_parser::lex_number, rustyylex, rustyyerror)
6197         (rust_lex_test_init, rust_lex_test_sequence)
6198         (rust_lex_test_push_back, rust_lex_tests): Update.
6199         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6200         parameter.
6201         <lexptr, prev_lexptr>: New members.
6202         (lexptr, prev_lexptr): Don't declare.
6203         * parse.c (lexptr, prev_lexptr): Remove globals.
6204         (parse_exp_in_context): Update.
6205         * p-exp.y (yylex, yyerror): Update.
6206         * m2-exp.y (parse_number, yylex, yyerror): Update.
6207         * go-exp.y (lex_one_token, yyerror): Update.
6208         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6209         * d-exp.y (lex_one_token, yyerror): Update.
6210         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6211         (lex_one_token, yyerror): Update.
6212         * ada-lex.l (YY_INPUT): Update.
6213         (rewind_to_char): Update.
6214         * ada-exp.y (yyerror): Update.
6215
6216 2019-04-04  Tom Tromey  <tom@tromey.com>
6217
6218         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6219         * parser-defs.h (struct parser_state) <parser_state>: Add new
6220         parameter.
6221         <comma_terminates>: New member.
6222         (comma_terminates): Don't declare global.
6223         * parse.c (comma_terminates): Remove global.
6224         (parse_exp_in_context): Update.
6225         * p-exp.y (yylex): Update.
6226         * m2-exp.y (yylex): Update.
6227         * go-exp.y (lex_one_token): Update.
6228         * f-exp.y (yylex): Update.
6229         * d-exp.y (lex_one_token): Update.
6230         * c-exp.y (lex_one_token): Update.
6231         * ada-lex.l: Update.
6232
6233 2019-04-04  Tom Tromey  <tom@tromey.com>
6234
6235         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6236         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6237         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6238         * parser-defs.h (paren_depth): Don't declare.
6239         * parse.c (paren_depth): Remove global.
6240         (parse_exp_in_context): Update.
6241         * p-exp.y (paren_depth): New global.
6242         (pascal_parse): Initialize it.
6243         * m2-exp.y (paren_depth): New global.
6244         (m2_parse): Initialize it.
6245         * go-exp.y (paren_depth): New global.
6246         (go_parse): Initialize it.
6247         * f-exp.y (paren_depth): New global.
6248         (f_parse): Initialize it.
6249         * d-exp.y (paren_depth): New global.
6250         (d_parse): Initialize it.
6251         * c-exp.y (paren_depth): New global.
6252         (c_parse): Initialize it.
6253         * ada-lex.l (paren_depth): New global.
6254         (lexer_init): Initialize it.
6255
6256 2019-04-04  Tom Tromey  <tom@tromey.com>
6257
6258         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6259         (rust_parser::convert_ast_to_type)
6260         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6261         * parser-defs.h (struct parser_state) <parser_state>: Add
6262         parameters.  Initialize new members.
6263         <expression_context_block, expression_context_pc>: New members.
6264         * parse.c (expression_context_block, expression_context_pc):
6265         Remove globals.
6266         (parse_exp_in_context): Update.
6267         * p-exp.y: Update all rules.
6268         (yylex): Update.
6269         * m2-exp.y: Update all rules.
6270         (yylex): Update.
6271         * go-exp.y (yylex): Update.
6272         * f-exp.y (yylex): Update.
6273         * d-exp.y: Update all rules.
6274         (yylex): Update.
6275         * c-exp.y: Update all rules.
6276         (lex_one_token, classify_name, yylex, c_parse): Update.
6277         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6278
6279 2019-04-04  Tom Tromey  <tom@tromey.com>
6280
6281         * gdbarch.h, gdbarch.c: Rebuild.
6282         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6283         * stap-probe.h:
6284         (struct stap_parse_info): Replace "parser_state" with
6285         "expr_builder".
6286         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6287         (parser_state): New class.
6288         * parse.c (expr_builder): Rename.
6289         (expr_builder::release): Rename.
6290         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6291         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6292         (write_exp_elt_longcst, write_exp_elt_floatcst)
6293         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6294         (write_exp_string_vector, write_exp_bitstring)
6295         (write_exp_msymbol, mark_struct_expression)
6296         (write_dollar_variable)
6297         (insert_type_address_space, increase_expout_size): Replace
6298         "parser_state" with "expr_builder".
6299         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6300         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6301         "parser_state" with "expr_builder".
6302
6303 2019-04-04  Tom Tromey  <tom@tromey.com>
6304
6305         * rust-exp.y: Replace "parse_language" with method call.
6306         * p-exp.y:
6307         (yylex): Replace "parse_language" with method call.
6308         * m2-exp.y:
6309         (yylex): Replace "parse_language" with method call.
6310         * go-exp.y (classify_name): Replace "parse_language" with method
6311         call.
6312         * f-exp.y (yylex): Replace "parse_language" with method call.
6313         * d-exp.y (lex_one_token): Replace "parse_language" with method
6314         call.
6315         * c-exp.y:
6316         (lex_one_token, classify_name, yylex): Replace "parse_language"
6317         with method call.
6318         * ada-exp.y (find_primitive_type, type_char)
6319         (type_system_address): Replace "parse_language" with method call.
6320
6321 2019-04-04  Tom Tromey  <tom@tromey.com>
6322
6323         * rust-exp.y: Replace "parse_gdbarch" with method call.
6324         * parse.c (write_dollar_variable, insert_type_address_space):
6325         Replace "parse_gdbarch" with method call.
6326         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6327         call.
6328         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6329         call.
6330         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6331         "parse_gdbarch" with method call.
6332         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6333         with method call.
6334         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6335         "parse_gdbarch" with method call.
6336         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6337         "parse_gdbarch" with method call.
6338         * c-exp.y (parse_type, parse_number, classify_name): Replace
6339         "parse_gdbarch" with method call.
6340         * ada-lex.l: Replace "parse_gdbarch" with method call.
6341         * ada-exp.y (parse_type, find_primitive_type, type_char)
6342         (type_system_address): Replace "parse_gdbarch" with method call.
6343
6344 2019-04-04  Tom Tromey  <tom@tromey.com>
6345
6346         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6347         * stap-probe.c (stap_parse_argument): Update.
6348         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6349         initial_size parameter.
6350         * rust-exp.y (rust_lex_tests): Update.
6351         * parse.c (parser_state): Update.
6352         (parse_exp_in_context): Update.
6353         * parser-defs.h (struct parser_state) <parser_state>: Remove
6354         "initial_size" parameter.
6355
6356 2019-04-04  Tom Tromey  <tom@tromey.com>
6357
6358         * parser-defs.h (increase_expout_size): Don't declare.
6359         * parse.c (increase_expout_size): Now static.
6360
6361 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6362
6363         * gnu-nat.c (gnu_nat_target::wait): Fix
6364         target_waitstatus_to_string call.
6365
6366 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * eval.c (evaluate_subexp_standard): Handle internal functions
6369         during Fortran function call handling.
6370
6371 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * NEWS: Mention new internal functions.
6374         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6375         (read_base_type): Use dwarf2_init_complex_target_type.
6376         * value.c (creal_internal_fn): New function.
6377         (cimag_internal_fn): New function.
6378         (_initialize_values): Register new internal functions.
6379
6380 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6381
6382         * infrun.c (stop_all_threads): If debug_infrun, always
6383         trace the wait status after wait_one, using
6384         target_waitstatus_to_string and target_pid_to_str.
6385         (handle_inferior_event): Replace various trace of
6386         wait status kind by a single trace.
6387         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6388         wait status kind image by target_waitstatus_to_string.
6389         * target/waitstatus.c (target_waitstatus_to_string): Fix
6390         obsolete comment.
6391
6392 2019-04-01  Tom Tromey  <tromey@adacore.com>
6393
6394         PR symtab/23331:
6395         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6396
6397 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6398             Pedro Alves  <palves@redhat.com>
6399
6400         * top.c (quit_force): Call 'finalize_values'.
6401         * value.c (finalize_values): New function.
6402         * value.h (finalize_values): Declare.
6403
6404 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6405
6406         * NEWS: Announce $_gdb_major and $_gdb_minor.
6407
6408         * top.c (init_gdb_version_vars): New function.
6409         (gdb_init): Call init_gdb_version_vars.
6410
6411 2019-03-29  Tom Tromey  <tromey@adacore.com>
6412
6413         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6414         help text.  Remove dead code.
6415
6416 2019-03-29  Keith Seitz  <keiths@redhat.com>
6417
6418         From Siddhesh Poyarekar:
6419         * f-lang.h (f77_get_upperbound): Return LONGEST.
6420         (f77_get_lowerbound): Likewise.
6421         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6422         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6423         print them.
6424         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6425         plongest to format print it.
6426         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6427         (f77_get_upperbound): Likewise.
6428         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6429         LOWER_BOUND to LONGEST.
6430         (f77_create_arrayprint_offset_tbl): Likewise.
6431
6432 2019-03-29  Keith Seitz  <keiths@redhat.com>
6433
6434         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6435         %s/pulongest for TYPE_LENGTH instead of %d in format
6436         strings.
6437         * ada-typerint.c (ada_print_type): Likewise.
6438         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6439         * compile/compile-c-support.c (generate_register_struct): Likewise.
6440         * gdbtypes.c (recursive_dump_type): Likewise.
6441         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6442         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6443         instead of %d in format strings.
6444         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6445         to std::min to ULONGEST.
6446         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6447         instead of %d in format strings.
6448         * tracepoint.c (info_scope_command): Likewise.
6449         * typeprint.c (print_offset_data::update)
6450         (print_offset_data::finish): Likewise.
6451         * xtensa-tdep.c (xtensa_store_return_value)
6452         (xtensa_push_dummy_call): Likewise.
6453
6454 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6455
6456         * windows-nat.c (display_selector): Fixed format specifications
6457         for 64-bit Cygwin.
6458
6459 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6460
6461         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6462
6463 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6464
6465         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6466         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6467         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6468         (nios2_linux_init_abi): Install it.
6469
6470 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6471
6472         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6473
6474 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6475
6476         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6477
6478 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6479             Tom Tromey  <tromey@adacore.com>
6480
6481         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6482
6483 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6484
6485         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6486         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6487         method to compute the bounds of range types. Also print "[evaluated]"
6488         if the bounds' values come from a dynamic evaluation.
6489
6490 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6493         whitespace when pretty printing is on.
6494
6495 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6496
6497         * ppc-linux-nat.c: Add include.
6498
6499 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6500
6501         * NEWS: Mention AArch64 Pointer Authentication.
6502
6503 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6504
6505         * arm-linux-nat.c: Add include.
6506
6507 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6508
6509         * source-cache.c (source_cache::get_source_lines): Re-read
6510         fullname after calling open_source_file.
6511
6512 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6513
6514         * NEWS: Mention TLS support for FreeBSD.
6515
6516 2019-03-25  Tom Tromey  <tromey@adacore.com>
6517
6518         * minsyms.c (BUNCH_SIZE): Update comment.
6519         (~minimal_symbol_reader): Remove old comment.
6520         (compact_minimal_symbols): Update comment.
6521         (minimal_symbol_reader::install): Remove old comment.  Update
6522         other comments.
6523
6524 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6525
6526         * s390-linux-nat.c: Add include.
6527
6528 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6529
6530         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6531         Call linux_get_hwcap.
6532         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6533         Likewise.
6534         (aarch64_linux_get_hwcap): Remove function.
6535         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6536         declaration.
6537         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6538         linux_get_hwcap.
6539         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6540         * linux-tdep.c (linux_get_hwcap): Add function.
6541         (linux_get_hwcap2): Likewise.
6542         * linux-tdep.h (linux_get_hwcap): Add declaration.
6543         (linux_get_hwcap2): Likewise.
6544         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6545         (ppc_linux_get_hwcap2): Likewise.
6546         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6547         linux_get_hwcap.
6548         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6549         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6550         (ppc_linux_nat_target::read_description): Likewise.
6551         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6552         * s390-linux-nat.c: Likewise.
6553         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6554
6555 2019-03-24  Tom Tromey  <tom@tromey.com>
6556
6557         * ada-lang.c (standard_lookup): Simplify initialization.
6558         (ada_lookup_symbol_nonlocal): Simplify return.
6559         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6560         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6561         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6562         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6563         initialization.
6564         * solib.c (solib_global_lookup): Simplify.
6565         * symtab.c (null_block_symbol): Remove.
6566         (symbol_cache_lookup): Simplify returns.
6567         (lookup_language_this): Simplify returns.
6568         (lookup_symbol_aux): Simplify return.
6569         (lookup_local_symbol): Simplify returns.
6570         (lookup_global_symbol_from_objfile): Simplify return.
6571         (lookup_symbol_in_objfile_symtabs)
6572         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6573         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6574         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6575         * cp-namespace.c (cp_lookup_bare_symbol)
6576         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6577         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6578         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6579         (cp_lookup_symbol_via_imports): Simplify initialization.
6580         (find_symbol_in_baseclass): Likewise.
6581         * symtab.h (null_block_symbol): Remove.
6582         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6583         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6584         (d_lookup_symbol_module): Likewise.
6585         (find_symbol_in_baseclass): Simplify initialization.
6586
6587 2019-03-24  Tom Tromey  <tom@tromey.com>
6588
6589         * expression.h: Don't include symtab.h.
6590         (struct block): Forward declare.
6591
6592 2019-03-24  Tom Tromey  <tom@tromey.com>
6593
6594         * c-exp.y (typebase): Remove casts.
6595         * gdbtypes.c (lookup_unsigned_typename, )
6596         (lookup_signed_typename): Remove cast.
6597         * eval.c (parse_to_comma_and_eval): Remove cast.
6598         * parse.c (write_dollar_variable): Remove cast.
6599         * block.h (struct block) <superblock>: Now const.
6600         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6601         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6602         (map_block): Make "block" const.
6603         * symfile.h (struct quick_symbol_functions)
6604         <map_matching_symbols>: Constify block argument to "callback".
6605         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6606         const.
6607         (find_pc_sect_compunit_symtab): Make "b" const.
6608         (find_symbol_at_address): Likewise.
6609         (search_symbols): Likewise.
6610         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6611         (dw2_debug_names_lookup_symbol): Likewise.
6612         (dw2_map_matching_symbols): Update.
6613         * p-valprint.c (pascal_val_print): Remove "block".
6614         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6615         (aux_add_nonlocal_symbols): Make "block" const.
6616         (resolve_subexp): Remove cast.
6617         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6618         const.
6619         (iterate_over_file_blocks): Likewise.
6620         * f-exp.y (%union) <bval>: Remove.
6621         * coffread.c (patch_opaque_types): Make "b" const.
6622         * spu-tdep.c (spu_catch_start): Make "block" const.
6623         * c-valprint.c (print_unpacked_pointer): Remove "block".
6624         * symmisc.c (dump_symtab_1): Make "b" const.
6625         (block_depth): Make "block" const.
6626         * d-exp.y (%union) <bval>: Remove.
6627         * cp-support.h (cp_lookup_rtti_type): Update.
6628         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6629         * psymtab.c (psym_lookup_symbol): Make "block" const.
6630         (maintenance_check_psymtabs): Make "b" const.
6631         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6632         (enumerate_locals, enumerate_args): Update.
6633         * python/py-symtab.c (stpy_global_block): Make "block" const.
6634         (stpy_static_block): Likewise.
6635         * inline-frame.c (block_starting_point_at): Make "new_block"
6636         const.
6637         * block.c (find_block_in_blockvector): Make return type const.
6638         (blockvector_for_pc_sect): Make "b" const.
6639         (find_block_in_blockvector): Make "b" const.
6640
6641 2019-03-23  Tom Tromey  <tom@tromey.com>
6642
6643         * varobj.c (varobj_create): Update.
6644         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6645         * printcmd.c (display_command, do_one_display): Don't reset
6646         innermost_block.
6647         * parser-defs.h (enum innermost_block_tracker_type): Move to
6648         expression.h.
6649         (innermost_block): Update comment.
6650         * parse.c (parse_exp_1): Add tracker_types parameter.
6651         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6652         tracker_types parameter.  Reset innermost_block.
6653         (parse_exp_in_context): Remove.
6654         (parse_expression_for_completion): Update.
6655         * objfiles.c (~objfile): Don't reset expression_context_block or
6656         innermost_block.
6657         * expression.h (enum innermost_block_tracker_type): Move from
6658         parser-defs.h.
6659         (parse_exp_1): Add tracker_types parameter.
6660         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6661         reset innermost_block.
6662
6663 2019-03-23  Tom Tromey  <tom@tromey.com>
6664
6665         * objfiles.h: Include bcache.h.
6666
6667 2019-03-23  Tom Tromey  <tom@tromey.com>
6668
6669         * linespec.c (get_current_search_block): Use
6670         scoped_restore_current_language.
6671         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6672
6673 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6674             Jiong Wang  <jiong.wang@arm.com>
6675
6676         * aarch64-linux-tdep.c
6677         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6678         section.
6679         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6680
6681 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6682             Jiong Wang  <jiong.wang@arm.com>
6683
6684         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6685         instructions.
6686         (aarch64_analyze_prologue_test): Add PACIASP test.
6687         (aarch64_prologue_prev_register): Unmask PC value.
6688
6689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6690             Jiong Wang  <jiong.wang@arm.com>
6691
6692         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6693         (aarch64_dwarf2_prev_register): Unmask PC value.
6694         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6695         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6696         DW_CFA_AARCH64_negate_ra_state.
6697         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6698
6699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6700             Jiong Wang  <jiong.wang@arm.com>
6701
6702         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6703         registers.
6704         (aarch64_pseudo_register_name): Likewise.
6705         (aarch64_pseudo_register_type): Likewise.
6706         (aarch64_pseudo_register_reggroup_p): Likewise.
6707         (aarch64_gdbarch_init): Add pauth registers.
6708         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6709         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6710         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6711         (struct gdbarch_tdep): Add regnum for ra_state.
6712
6713 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6714             Jiong Wang  <jiong.wang@arm.com>
6715
6716         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6717
6718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6719             Jiong Wang  <jiong.wang@arm.com>
6720
6721         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6722         function.
6723         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6724         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6725         (aarch64_gdbarch_init): Add puth registers.
6726         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6727         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6728         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6729
6730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6731             Jiong Wang  <jiong.wang@arm.com>
6732
6733         * aarch64-linux-nat.c
6734         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6735         * aarch64-linux-tdep.c
6736         (aarch64_linux_core_read_description): Likewise.
6737         (aarch64_linux_get_hwcap): New function.
6738         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6739         (aarch64_linux_get_hwcap): New declaration.
6740
6741 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6742             Jiong Wang  <jiong.wang@arm.com>
6743
6744         * aarch64-linux-nat.c
6745         (aarch64_linux_nat_target::read_description): Add pauth param.
6746         * aarch64-linux-tdep.c
6747         (aarch64_linux_core_read_description): Likewise.
6748         * aarch64-tdep.c (struct target_desc): Add in pauth.
6749         (aarch64_read_description): Add pauth param.
6750         (aarch64_gdbarch_init): Likewise.
6751         * aarch64-tdep.h (aarch64_read_description): Likewise.
6752         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6753         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6754         * features/Makefile: Add new files.
6755         * features/aarch64-pauth.c: New file.
6756         * features/aarch64-pauth.xml: New file.
6757
6758 2019-03-20  Tom Tromey  <tromey@adacore.com>
6759
6760         * infrun.c (handle_inferior_event): Rename from
6761         handle_inferior_event_1.  Create a scoped_value_mark.
6762         (handle_inferior_event): Remove.
6763
6764 2019-03-19  Tom Tromey  <tromey@adacore.com>
6765
6766         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6767         * infrun.h (print_stop_event): Add "displays" parameter.
6768         * infrun.c (print_stop_event): Add "displays" parameter.
6769
6770 2019-03-19  Pedro Alves  <palves@redhat.com>
6771
6772         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6773         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6774         to -1.  Fix TABs vs spaces.
6775         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6776         * tui/tui-out.h (tui_ui_out) Add intro comments.
6777         <m_line, m_start_of_line>: In-class initialize, and add describing
6778         comment.
6779
6780 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6781
6782         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6783         variable names.
6784         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6785
6786 2019-03-18  Pedro Alves  <palves@redhat.com>
6787             Eli Zaretskii <eliz@gnu.org>
6788
6789         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6790         m_line and m_start_of_line.
6791
6792 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6793
6794         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6795         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6796         it returns a newline.  This fixes a regression in TU mode, whereby
6797         the next line is output on the same screen line as the user input.
6798
6799 2019-03-18  Tom Tromey  <tromey@adacore.com>
6800
6801         * minsyms.c (minimal_symbol_reader::install): Remove call to
6802         obstack_blank.
6803
6804 2019-03-18  Pedro Alves  <palves@redhat.com>
6805
6806         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6807         New globals.
6808         (apply_style): New, factored out from ...
6809         (apply_ansi_escape): ... this.  Handle reverse video mode.
6810         (tui_set_reverse_mode): New function.
6811         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6812         * tui/tui-winsource.c (tui_show_source_line): Use
6813         tui_set_reverse_mode instead of setting A_STANDOUT.
6814         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6815         New setter methods.
6816
6817 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6818
6819         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6820         Handle tabs.
6821
6822 2019-03-18  Tom Tromey  <tromey@adacore.com>
6823
6824         * ada-lang.c (empty_array): Add "high" parameter.
6825         (ada_evaluate_subexp): Update.
6826
6827 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6828
6829         * unittests/string_view-selftests.c: Define
6830         _initialize_string_view_selftests unconditionally.
6831
6832 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6833
6834         PR gdb/24350
6835         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6836
6837 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6838
6839         PR gdb/24351
6840         * windows-nat.c (display_selector): Fix format specifiers.
6841
6842 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6843
6844         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6845         tui_refill_source_window instead of tui_refresh_win, to update the
6846         current execution line.  This fixes redisplay of the current line
6847         when stepping through the code with "next" or "step".
6848
6849 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6850
6851         * source-cache.c (source_cache::get_source_lines): Call
6852         find_source_lines to initialize s->nlines.  This fixes vertical
6853         scrolling of TUI source window when the DOWN arrow is pressed.
6854
6855 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6856
6857         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6858         linux-thread-db.c (_initialize_thread_db): Likewise.
6859
6860 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6861
6862         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6863         wclrtoeol in tui_show_source_line".  This reverts changes made in
6864         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6865
6866 2019-03-15  Tom Tromey  <tom@tromey.com>
6867
6868         * symtab.h (struct minimal_symbol): Derive from
6869         general_symbol_info.
6870         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6871         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6872         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6873         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6874         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6875         (MSYMBOL_SEARCH_NAME): Update.
6876         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6877         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6878         * minsyms.c (minimal_symbol_reader::record_full): Update.
6879
6880 2019-03-15  Tom Tromey  <tom@tromey.com>
6881
6882         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6883
6884 2019-03-15  Tom Tromey  <tom@tromey.com>
6885
6886         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6887         unique_xmalloc_ptr.
6888         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6889         Update.
6890         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6891         (build_minimal_symbol_hash_tables)
6892         (minimal_symbol_reader::install): Update.
6893
6894 2019-03-15  Tom Tromey  <tom@tromey.com>
6895
6896         * symtab.c (create_demangled_names_hash): Update.
6897         (symbol_set_names): Update.
6898         * objfiles.h (struct objfile_per_bfd_storage)
6899         <demangled_names_hash>: Now an htab_up.
6900         * objfiles.c (objfile_per_bfd_storage): Simplify.
6901
6902 2019-03-15  Tom Tromey  <tom@tromey.com>
6903
6904         * objfiles.h (struct objfile_per_bfd_storage): Declare
6905         destructor.
6906         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6907         New.
6908         (get_objfile_bfd_data): Use new.  Don't initialize
6909         language_of_main.
6910         (free_objfile_per_bfd_storage): Remove.
6911         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6912
6913 2019-03-15  Tom Tromey  <tom@tromey.com>
6914
6915         * symfile.c (reread_symbols): Update.
6916         * objfiles.c (objfile::objfile): Update.
6917         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6918         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6919         comment.
6920         (minimal_symbol_reader::install): Update.
6921         (terminate_minimal_symbol_table): Remove.
6922         * jit.c (jit_object_close_impl): Update.
6923
6924 2019-03-15  Tom Tromey  <tom@tromey.com>
6925
6926         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6927         initializations.
6928
6929 2019-03-15  Tom Tromey  <tom@tromey.com>
6930
6931         * objfiles.h (struct objfile_per_bfd_storage)
6932         <demangled_hash_languages>: Now a bitset.
6933         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6934         (lookup_minimal_symbol): Update.
6935
6936 2019-03-15  Tom Tromey  <tom@tromey.com>
6937
6938         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6939         Don't return the symbol.
6940         * coffread.c (record_minimal_symbol): Use record_full.
6941
6942 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6943
6944         The MS-Windows port of ncurses fails to switch to a color pair if
6945         one or both of the colors are the implicit default colors.  This
6946         change records the default colors when TUI is initialized, and
6947         then specifies them explicitly when a color pair uses the default
6948         colors.  This allows color styling in TUI mode on MS-Windows.
6949
6950         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6951         ncurses_norm_attr.
6952         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6953         colors in ncurses_norm_attr.
6954         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6955         "none", replace it with the default color recorded in
6956         ncurses_norm_attr.
6957
6958 2019-03-14  Tom Tromey  <tromey@adacore.com>
6959
6960         * source-cache.h (class source_cache) <get_source_lines>: Return
6961         std::string.
6962         * source-cache.c (source_cache::extract_lines): Handle case where
6963         first_pos==npos.  Return std::string.
6964         (source_cache::get_source_lines): Update.
6965
6966 2019-03-14  Tom Tromey  <tromey@adacore.com>
6967
6968         * NEWS: Add item for "style sources" commands.
6969         * source-cache.c (source_cache::get_source_lines): Check
6970         source_styling.
6971         * cli/cli-style.c (source_styling): New global.
6972         (_initialize_cli_style): Add "style sources" commands.
6973         (show_style_sources): New function.
6974         * cli/cli-style.h (source_styling): Declare.
6975
6976 2019-03-14  Pedro Alves  <palves@redhat.com>
6977             Tom Tromey  <tromey@adacore.com>
6978
6979         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6980         * tui/tui-winsource.c (tui_refill_source_window): New function,
6981         from...
6982         (tui_horizontal_source_scroll): ... here.  Move some logic.
6983         * cli/cli-style.c (set_style_enabled): Notify new observable.
6984         * tui/tui-hooks.c (tui_redisplay_source): New function.
6985         (tui_attach_detach_observers): Attach or detach
6986         tui_redisplay_source.
6987         * observable.h (source_styling_changed): New observable.
6988         * observable.c: Define source_styling_changed observable.
6989
6990 2019-03-13  Tom Tromey  <tromey@adacore.com>
6991
6992         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6993         (i386_gnu_nat_target::store_registers): Update.
6994         * target-debug.h (target_debug_print_std_string): New macro.
6995         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6996         * windows-tdep.c (display_one_tib): Update.
6997         * tui/tui-stack.c (tui_make_status_line): Update.
6998         * top.c (print_inferior_quit_action): Update.
6999         * thread.c (thr_try_catch_cmd): Update.
7000         (add_thread_with_info): Update.
7001         (thread_target_id_str): Update.
7002         (thr_try_catch_cmd): Update.
7003         (thread_command): Update.
7004         (thread_find_command): Update.
7005         * record-btrace.c (record_btrace_target::info_record)
7006         (record_btrace_resume_thread, record_btrace_target::resume)
7007         (record_btrace_cancel_resume, record_btrace_step_thread)
7008         (record_btrace_target::wait, record_btrace_target::wait)
7009         (record_btrace_target::wait, record_btrace_target::stop): Update.
7010         * progspace.c (print_program_space): Update.
7011         * process-stratum-target.c
7012         (process_stratum_target::thread_address_space): Update.
7013         * linux-fork.c (linux_fork_mourn_inferior)
7014         (detach_checkpoint_command, info_checkpoints_command)
7015         (linux_fork_context): Update.
7016         (linux_fork_detach): Update.
7017         (class scoped_switch_fork_info): Update.
7018         (delete_checkpoint_command): Update.
7019         * infrun.c (follow_fork_inferior): Update.
7020         (follow_fork_inferior): Update.
7021         (proceed_after_vfork_done): Update.
7022         (handle_vfork_child_exec_or_exit): Update.
7023         (follow_exec): Update.
7024         (displaced_step_prepare_throw): Update.
7025         (displaced_step_restore): Update.
7026         (start_step_over): Update.
7027         (resume_1): Update.
7028         (clear_proceed_status_thread): Update.
7029         (proceed): Update.
7030         (print_target_wait_results): Update.
7031         (do_target_wait): Update.
7032         (context_switch): Update.
7033         (stop_all_threads): Update.
7034         (restart_threads): Update.
7035         (finish_step_over): Update.
7036         (handle_signal_stop): Update.
7037         (switch_back_to_stepped_thread): Update.
7038         (keep_going_pass_signal): Update.
7039         (print_exited_reason): Update.
7040         (normal_stop): Update.
7041         * inferior.c (inferior_pid_to_str): Change return type.
7042         (print_selected_inferior): Update.
7043         (add_inferior): Update.
7044         (detach_inferior): Update.
7045         * dummy-frame.c (fprint_dummy_frames): Update.
7046         * dcache.c (dcache_info_1): Update.
7047         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7048         (btrace_fetch, btrace_clear): Update.
7049         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7050         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7051         type.
7052         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7053         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7054         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7055         * gdbarch.c, gdbarch.h: Rebuild.
7056         * gdbarch.sh (core_pid_to_str): Change return type.
7057         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7058         return type.
7059         (windows_nat_target::pid_to_str): Change return type.
7060         (windows_delete_thread): Update.
7061         (windows_nat_target::attach): Update.
7062         (windows_nat_target::files_info): Update.
7063         * target-delegates.c: Rebuild.
7064         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7065         return type.
7066         (sol_thread_target::pid_to_str): Change return type.
7067         * remote.c (class remote_target) <pid_to_str>: Change return
7068         type.
7069         (remote_target::pid_to_str): Change return type.
7070         (extended_remote_target::attach, remote_target::remote_stop_ns)
7071         (remote_target::remote_notif_remove_queued_reply)
7072         (remote_target::push_stop_reply, remote_target::disable_btrace):
7073         Update.
7074         (extended_remote_target::attach): Update.
7075         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7076         type.
7077         (gdbsim_target::pid_to_str): Change return type.
7078         * ravenscar-thread.c (struct ravenscar_thread_target)
7079         <pid_to_str>: Change return type.
7080         (ravenscar_thread_target::pid_to_str): Change return type.
7081         * procfs.c (class procfs_target) <pid_to_str>: Change return
7082         type.
7083         (procfs_target::pid_to_str): Change return type.
7084         (procfs_target::attach): Update.
7085         (procfs_target::detach): Update.
7086         (procfs_target::fetch_registers): Update.
7087         (procfs_target::store_registers): Update.
7088         (procfs_target::wait): Update.
7089         (procfs_target::files_info): Update.
7090         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7091         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7092         return type.
7093         (nto_procfs_target::pid_to_str): Change return type.
7094         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7095         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7096         return type.
7097         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7098         (exit_lwp): Update.
7099         (attach_proc_task_lwp_callback, get_detach_signal)
7100         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7101         (linux_nat_target::resume, wait_lwp, stop_callback)
7102         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7103         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7104         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7105         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7106         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7107         type.
7108         (inf_ptrace_target::attach): Update.
7109         (inf_ptrace_target::files_info): Update.
7110         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7111         type.
7112         (go32_nat_target::pid_to_str): Change return type.
7113         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7114         (gnu_nat_target::wait): Update.
7115         (gnu_nat_target::wait): Update.
7116         (gnu_nat_target::resume): Update.
7117         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7118         (fbsd_nat_target::wait): Update.
7119         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7120         type.
7121         (darwin_nat_target::attach): Update.
7122         * corelow.c (class core_target) <pid_to_str>: Change return type.
7123         (core_target::pid_to_str): Change return type.
7124         * target.c (normal_pid_to_str): Change return type.
7125         (default_pid_to_str): Likewise.
7126         (target_pid_to_str): Change return type.
7127         (target_translate_tls_address): Update.
7128         (target_announce_detach): Update.
7129         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7130         return type.
7131         (bsd_uthread_target::pid_to_str): Change return type.
7132         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7133         type.
7134         (bsd_kvm_target::pid_to_str): Change return type.
7135         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7136         return type.
7137         (aix_thread_target::pid_to_str): Change return type.
7138         * target.h (struct target_ops) <pid_to_str>: Change return type.
7139         (target_pid_to_str, normal_pid_to_str): Likewise.
7140         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7141         type.
7142         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7143         type.
7144         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7145         return type.
7146         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7147         type.
7148         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7149         type.
7150         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7151         return type.
7152
7153 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7154
7155         * NEWS: Mention that the new default MI version is 3.  Mention
7156         changes to the output of commands and events that deal with
7157         multi-location breakpoints.
7158         * breakpoint.c: Include "mi/mi-out.h".
7159         (print_one_breakpoint): Change output syntax if using MI version
7160         >= 3.
7161         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7162         New.
7163         (mi_multi_location_breakpoint_output_fixed): New.
7164         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7165         (mi_cmd_fix_multi_location_breakpoint_output): New.
7166         (mi_multi_location_breakpoint_output_fixed): New.
7167         * mi/mi-cmds.c (mi_cmds): Register command
7168         -fix-multi-location-breakpoint-output.
7169         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7170         interpreter "mi".
7171
7172 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7173
7174         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7175         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7176         instantiate mi_ui_out based on interpreter name.
7177         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7178         * mi/mi-main.c (mi_load_progress): Likewise.
7179
7180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7181
7182         * NEWS: Combine separate "New targets" sections for 8.3.
7183
7184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7185
7186         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7187         (ppcfbsd_init_abi): Install gdbarch
7188         "fetch_tls_load_module_address" and "get_thread_local_address"
7189         methods.
7190
7191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7192
7193         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7194         (riscv_fbsd_init_abi): Install gdbarch
7195         "fetch_tls_load_module_address" and "get_thread_local_address"
7196         methods.
7197
7198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7199
7200         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7201         (i386fbsd_init_abi): Install gdbarch
7202         "fetch_tls_load_module_address" and "get_thread_local_address"
7203         methods.
7204
7205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7206
7207         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7208         (amd64fbsd_init_abi): Install gdbarch
7209         "fetch_tls_load_module_address" and "get_thread_local_address"
7210         methods.
7211
7212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7213
7214         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7215         (struct fbsd_pspace_data): New type.
7216         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7217         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7218         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7219         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7220         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7221
7222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7223
7224         * gdbtypes.c (lookup_struct_elt): New function.
7225         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7226         * gdbtypes.h (struct struct_elt): New type.
7227         (lookup_struct_elt): New prototype.
7228
7229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7230
7231         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7232         remove disabled code block.
7233
7234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7235
7236         * gdbarch.sh (get_thread_local_address): New method.
7237         * gdbarch.h, gdbarch.c: Regenerate.
7238         * target.c (target_translate_tls_address): Use
7239         gdbarch_get_thread_local_address if present instead of
7240         target::get_thread_local_address.
7241
7242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7243
7244         * target.h (target::get_thread_local_address): Update comment.
7245
7246 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7247
7248         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7249         objfile->separate_debug_objfile_backlink if not NULL.
7250
7251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7252
7253         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7254         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7255         (amd64bsd_store_inferior_registers): Likewise.
7256         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7257         Enable segment base registers.
7258         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7259         PT_GETFSBASE and PT_GETGSBASE.
7260         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7261         PT_SETGSBASE.
7262         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7263         segment base registers.
7264         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7265
7266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7267
7268         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7269         Update calls to i386_target_description to add 'segments'
7270         parameter.
7271         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7272         add segment base registers.
7273         * arch/i386.c (i386_create_target_description): Add 'segments'
7274         parameter to enable segment base registers.
7275         * arch/i386.h (i386_create_target_description): Likewise.
7276         * features/i386/32bit-segments.xml: New file.
7277         * features/i386/32bit-segments.c: Generate.
7278         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7279         call to i386_target_description to add 'segments' parameter.
7280         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7281         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7282         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7283         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7284         if feature is present.
7285         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7286         Add 'segments' parameter to call to i386_target_description.
7287         (i386_target_description): Add 'segments' parameter to enable
7288         segment base registers.
7289         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7290         to call to i386_target_description.
7291         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7292         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7293         Define I386_NUM_REGS.
7294         (i386_target_description): Add 'segments' parameter to enable
7295         segment base registers.
7296
7297 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7298
7299         PR/24325
7300         * source-cache.c: #undef open and close, to avoid unresolved
7301         externals during linking.
7302
7303 2019-03-12  Tom Tromey  <tromey@adacore.com>
7304
7305         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7306         const.  Add initializers.
7307         (_initialize_remote): Don't initialize ptid globals.
7308
7309 2019-03-12  Pedro Alves  <palves@redhat.com>
7310
7311         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7312
7313 2019-03-12  Pedro Alves  <palves@redhat.com>
7314
7315         * cp-name-parser.y (main): Remove unused 'len' variable.
7316
7317 2019-03-12  Tom Tromey  <tromey@adacore.com>
7318
7319         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7320         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7321
7322 2019-03-12  Tom Tromey  <tromey@adacore.com>
7323
7324         * linux-nat.c (iterate_over_lwps): Update.
7325         (stop_callback): Remove parameter.
7326         (stop_wait_callback, detach_callback, resume_set_callback)
7327         (select_singlestep_lwp_callback, set_ignore_sigint)
7328         (status_callback, resumed_callback, resume_clear_callback)
7329         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7330         data parameter.
7331         (linux_nat_target::detach, linux_nat_target::resume)
7332         (linux_stop_and_wait_all_lwps, select_event_lwp)
7333         (linux_nat_filter_event, linux_nat_wait_1)
7334         (linux_nat_target::kill, linux_nat_target::stop)
7335         (linux_nat_target::stop): Update.
7336         (linux_nat_resume_callback): Change type.
7337         (resume_stopped_resumed_lwps, count_events_callback)
7338         (select_event_lwp_callback): Likewise.
7339         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7340         * arm-linux-nat.c (struct update_registers_data): Remove.
7341         (update_registers_callback): Change type.
7342         (arm_linux_insert_hw_breakpoint1): Update.
7343         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7344         parameter.
7345         (x86_linux_dr_set_addr): Update.
7346         (x86_linux_dr_set_control): Update.
7347         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7348         (iterate_over_lwps): Use gdb::function_view.
7349         * nat/aarch64-linux-hw-point.c (struct
7350         aarch64_dr_update_callback_param): Remove.
7351         (debug_reg_change_callback): Change type.
7352         (aarch64_notify_debug_reg_change): Update.
7353         * s390-linux-nat.c (s390_refresh_per_info): Update.
7354
7355 2019-03-11  Tom Tromey  <tromey@adacore.com>
7356
7357         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7358         redundant assignment to "this_cu".
7359
7360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7361
7362         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7363
7364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7365
7366         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7367         from...
7368         (rank_one_type): ... this.
7369
7370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7371
7372         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7373         from...
7374         (rank_one_type): ... this.
7375
7376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7377
7378         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7379         from...
7380         (rank_one_type): ... this.
7381
7382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7383
7384         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7385         from...
7386         (rank_one_type): ... this.
7387
7388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7389
7390         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7391         from...
7392         (rank_one_type): ... this.
7393
7394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7395
7396         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7397         from...
7398         (rank_one_type): ... this.
7399
7400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7401
7402         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7403         from...
7404         (rank_one_type): ... this.
7405
7406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7407
7408         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7409         from...
7410         (rank_one_type): ... this.
7411
7412 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7413
7414         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7415         from...
7416         (rank_one_type): ... this.
7417
7418 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7419
7420         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7421         from...
7422         (rank_one_type): ... this.
7423
7424 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7425
7426         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7427         from...
7428         (rank_one_type): ... this.
7429
7430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7431
7432         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7433         from...
7434         (rank_one_type): ... this.
7435
7436 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7437
7438         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7439         inferior-events' shows the example events.
7440
7441 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7442
7443         Support styling on native MS-Windows console
7444
7445         PR/24315
7446         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7447         on MS-Windows if $TERM is not defined.
7448
7449         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7450
7451         * posix-hdep.c (gdb_console_fputs):
7452         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7453         functions.
7454         * ui-file.h (gdb_console_fputs): Add prototype.
7455
7456         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7457         back to fputs only if the former returns zero.
7458
7459 2019-03-07  Tom Tromey  <tom@tromey.com>
7460
7461         * symmisc.c (print_symbol_bcache_statistics): Update.
7462         (print_objfile_statistics): Update.
7463         * symfile.c (allocate_symtab): Update.
7464         * stabsread.c: Don't include bcache.h.
7465         * psymtab.h (struct psymbol_bcache): Don't declare.
7466         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7467         (psymbol_bcache_init, psymbol_bcache_free)
7468         (psymbol_bcache_get_bcache): Don't declare.
7469         * psymtab.c (struct psymbol_bcache): Remove.
7470         (psymtab_storage::psymtab_storage): Update.
7471         (psymtab_storage::~psymtab_storage): Update.
7472         (psymbol_bcache_init, psymbol_bcache_free)
7473         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7474         (add_psymbol_to_bcache): Update.
7475         (allocate_psymtab): Update.
7476         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7477         macro_cache>: No longer pointers.
7478         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7479         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7480         * macrotab.c (macro_bcache): Update.
7481         * macroexp.c: Don't include bcache.h.
7482         * gdbtypes.c (check_types_worklist): Update.
7483         (types_deeply_equal): Remove TRY/CATCH.  Update.
7484         * elfread.c (elf_symtab_read): Update.
7485         * dwarf2read.c: Don't include bcache.h.
7486         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7487         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7488         (print_bcache_statistics, bcache_memory_used): Don't declare.
7489         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7490         methods.  Rename all data members.
7491         * bcache.c (struct bcache): Move to bcache.h.
7492         (bcache::expand_hash_table): Rename from expand_hash_table.
7493         (bcache): Remove.
7494         (bcache::insert): Rename from bcache_full.
7495         (bcache::compare): Rename from bcache_compare.
7496         (bcache_xmalloc): Remove.
7497         (bcache::~bcache): Rename from bcache_xfree.
7498         (bcache::print_statistics): Rename from print_bcache_statistics.
7499         (bcache::memory_used): Rename from bcache_memory_used.
7500
7501 2019-03-07  Pedro Alves  <palves@redhat.com>
7502
7503         * infrun.c (normal_stop): Also check for
7504         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7505
7506 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7507
7508         * f-lang.c (value_from_host_double): Moved to...
7509         * value.c (value_from_host_double): ...here.
7510         * value.h (value_from_host_double): Declare.
7511         * guile/scm-math.c (vlscm_convert_typed_number): Use
7512         value_from_host_double.
7513         (vlscm_convert_number): Likewise.
7514         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7515         * python/py-value.c (convert_value_from_python): Likewise.
7516
7517 2019-03-06  Tom Tromey  <tom@tromey.com>
7518
7519         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7520
7521 2019-03-06  Tom Tromey  <tom@tromey.com>
7522
7523         * utils.h (free_current_contents): Don't declare.
7524         * utils.c (free_current_contents): Remove.
7525
7526 2019-03-06  Tom Tromey  <tom@tromey.com>
7527
7528         * top.c (quit_force): Update.
7529         * main.c (captured_command_loop): Update.
7530         * common/new-op.c (operator new): Update.
7531         * common/common-exceptions.c (struct catcher)
7532         <save_cleanup_chain>: Remove member.
7533         (exceptions_state_mc_init): Update.
7534         (exception_try_scope_entry): Return nullptr.
7535         (exception_try_scope_exit, exception_rethrow)
7536         (throw_exception_sjlj, throw_exception_cxx): Update.
7537         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7538         (all_cleanups, do_cleanups, discard_cleanups)
7539         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7540         (restore_cleanups, restore_final_cleanups): Don't declare.
7541         (do_final_cleanups): Remove parameter.
7542         * common/cleanups.c (cleanup_chain, make_cleanup)
7543         (make_cleanup_dtor, all_cleanups, do_cleanups)
7544         (discard_my_cleanups, discard_cleanups)
7545         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7546         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7547         (null_cleanup): Remove.
7548         (do_final_cleanups): Remove parameter.
7549
7550 2019-03-06  Tom Tromey  <tom@tromey.com>
7551
7552         * remote.c (remote_target::remote_parse_stop_reply): Use
7553         unique_xmalloc_ptr.
7554
7555 2019-03-06  Tom Tromey  <tom@tromey.com>
7556
7557         * stabsread.c (struct stabs_field_info): Rename from field_info.
7558         <list, fnlist>: Add initializers.
7559         <obstack>: New member.
7560         (read_member_functions, read_struct_fields, read_baseclasses):
7561         Allocate on obstack.  Don't use cleanups.
7562         (read_one_struct_field, read_member_functions, read_struct_fields)
7563         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7564         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7565         (read_struct_type): Update.
7566
7567 2019-03-06  Tom Tromey  <tom@tromey.com>
7568
7569         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7570         * common/filestuff.h (make_cleanup_close): Don't declare.
7571         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7572         Remove.
7573
7574 2019-03-06  Tom Tromey  <tom@tromey.com>
7575
7576         * solib-aix.c: Use make_scope_exit.
7577
7578 2019-03-06  Tom Tromey  <tom@tromey.com>
7579
7580         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7581         Use make_scope_exit.
7582
7583 2019-03-06  Tom Tromey  <tom@tromey.com>
7584
7585         * solib-svr4.c (disable_probes_interface): Remove parameter.
7586         (svr4_handle_solib_event): Use make_scope_exit.
7587
7588 2019-03-06  Tom Tromey  <tom@tromey.com>
7589
7590         * remote.c (struct stop_reply_deleter): Remove.
7591         (stop_reply_up): Update.
7592         (struct stop_reply): Derive from notif_event.  Don't typedef.
7593         <regcache>: Now a std::vector.
7594         (stop_reply_xfree): Remove.
7595         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7596         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7597         (remote_target::discard_pending_stop_replies): Use delete.
7598         (remote_target::remote_parse_stop_reply): Update.
7599         (remote_target::process_stop_reply): Update.
7600         * remote-notif.h (struct notif_event): Add virtual destructor.
7601         Remove "dtr" member.
7602         (struct notif_client) <alloc_event>: Return a unique_ptr.
7603         (notif_event_xfree): Don't declare.
7604         (notif_event_up): New typedef.
7605         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7606         (notif_event_xfree, do_notif_event_xfree): Remove.
7607         (remote_notif_state_xfree): Update.
7608
7609 2019-03-06  Tom Tromey  <tom@tromey.com>
7610
7611         * infrun.c (displaced_step_clear_cleanup): Now a
7612         forward_scope_exit type.
7613         (displaced_step_prepare_throw): Update.
7614         (displaced_step_fixup): Update.
7615
7616 2019-03-06  Tom Tromey  <tom@tromey.com>
7617
7618         * inferior.h (class inferior): Update comment.
7619         * gdbthread.h (class thread_info): Update comment.
7620
7621 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7622             Tom Tromey  <tom@tromey.com>
7623
7624         * stabsread.h (struct stab_section_list): Remove.
7625         (coffstab_build_psymtabs): Update.
7626         * dbxread.c (symbuf_sections): Now a std::vector.
7627         (sect_idx): New global.
7628         (fill_symbuf): Update.
7629         (coffstab_build_psymtabs): Change type of stabsects parameter.
7630         Update.
7631         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7632         std::vector.
7633         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7634         (coff_locate_sections): Update.
7635         (coff_symfile_read): Remove cleanups.  Update.
7636         (init_stringtab): Add storage parameter.
7637         (free_stringtab, free_stringtab_cleanup): Remove.
7638         (init_lineno): Add storage parameter.
7639         (free_linetab, free_linetab_cleanup): Remove.
7640
7641 2019-03-06  Pedro Alves  <palves@redhat.com>
7642
7643         * linux-fork.c (fork_info::clobber_regs): Delete.
7644         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7645         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7646         comment.  Adjust.
7647         (scoped_switch_fork_info::scoped_switch_fork_info)
7648         (checkpoint_command, linux_fork_context): Adjust
7649         fork_save_infrun_state calls.
7650
7651 2019-03-06  Pedro Alves  <palves@redhat.com>
7652
7653         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7654         (inf_has_multiple_threads): Return 'bool' and rewrite using
7655         inferior_info::threads().
7656
7657 2019-03-06  Pedro Alves  <palves@redhat.com>
7658
7659         * linux-fork.c: Include <list>.
7660         (fork_list): Now a std::list instance.
7661         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7662         (forks_exist_p, find_last_fork): Adjust.
7663         (new_fork): Delete.
7664         (one_fork_p): New.
7665         (add_fork): Adjust.
7666         (free_fork): Delete, folded into fork_info::~fork_info().
7667         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7668         Adjust.
7669         (init_fork_list): Delete.
7670         (linux_fork_killall, linux_fork_mourn_inferior)
7671         (linux_fork_detach, info_checkpoints_command): Adjust.
7672         (_initialize_linux_fork): No longer call init_fork_list.
7673
7674 2019-03-06  Pedro Alves  <palves@redhat.com>
7675
7676         * linux-fork.c (new_fork): New, split out of ...
7677         (add_fork): ... this.  Return void.  Move "first fork" special
7678         case from here, to ...
7679         (checkpoint_command): ... here.
7680         * linux-linux.h (add_fork): Return void.
7681
7682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7685
7686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7687             Chris January  <chris.january@arm.com>
7688             David Lecomber  <david.lecomber@arm.com>
7689
7690         * f-exp.y: New token, UNOP_INTRINSIC.
7691         (exp): New pattern using UNOP_INTRINSIC token.
7692         (f77_keywords): Add 'abs' keyword.
7693         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7694         (value_from_host_double): New function.
7695         (evaluate_subexp_f): Support UNOP_ABS.
7696
7697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7700         types.
7701
7702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7705         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7706         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7707
7708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7711
7712 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7713             Chris January  <chris.january@arm.com>
7714
7715         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7716         * f-exp.y: Define 'KIND' token.
7717         (exp): New pattern for KIND expressions.
7718         (ptype): Handle types with a kind extension.
7719         (direct_abs_decl): Extend to spot kind extensions.
7720         (f77_keywords): Add 'kind' to the list.
7721         (push_kind_type): New function.
7722         (convert_to_kind_type): New function.
7723         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7724         * parse.c (operator_length_standard): Likewise.
7725         * parser-defs.h (enum type_pieces): Add tp_kind.
7726         * std-operator.def: Add UNOP_KIND.
7727
7728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * f-exp.y (f_parse): Set yydebug.
7731
7732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * f-lang.c (evaluate_subexp_f): New function.
7735         (exp_descriptor_f): New global.
7736         (f_language_defn): Use exp_descriptor_f instead of
7737         exp_descriptor_standard.
7738
7739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * f-exp.y (struct token): Add comments.
7742         (dot_ops): Remove uppercase versions and the end marker.
7743         (f77_keywords): Likewise.
7744         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7745         entries in the dot_ops array are case insensitive, and use
7746         strncasecmp to compare strings.  Also some whitespace cleanup in
7747         this area.  Similar for the f77_keywords array, except entries in
7748         this list might be case sensitive.
7749
7750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * f-exp.y (struct f77_boolean_val): Add comments.
7753         (boolean_values): Remove uppercase versions, and end marker.
7754         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7755         and use strncasecmp to achieve case insensitivity.  Additionally,
7756         perform whitespace cleanup around this code.
7757
7758 2019-03-06  Tom Tromey  <tromey@adacore.com>
7759
7760         * remote-sim.c (gdbsim_target_open): Use result of
7761         gdb_argv::release.
7762
7763 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7764         Dirk Schubert  <dirk.schubert@arm.com>
7765         Chris January  <chris.january@arm.com>
7766
7767         * eval.c (evaluate_subexp_standard): Call Fortran argument
7768         wrapping logic.
7769         * f-lang.c (struct value): A value which can be passed into a
7770         Fortran function call.
7771         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7772         where appropriate.
7773         (struct type): Value ready for a Fortran function call.
7774         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7775         is needed.
7776         * f-lang.h (fortran_argument_convert): Declaration.
7777         (fortran_preserve_arg_pointer): Declaration.
7778         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7779
7780 2019-03-05  Tom Tromey  <tromey@adacore.com>
7781
7782         * python/py-prettyprint.c (print_string_repr): Remove #if.
7783         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7784
7785 2019-03-05  Tom Tromey  <tromey@adacore.com>
7786
7787         * target.c (the_dummy_target): Move later.  Change type to
7788         "dummy_target".
7789         (initialize_targets): Don't initialize the_dummy_target.
7790
7791 2019-03-05  Tom Tromey  <tromey@adacore.com>
7792
7793         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7794         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7795
7796 2019-03-05  Tom Tromey  <tromey@adacore.com>
7797
7798         * windows-nat.c (windows_nat_target::attach)
7799         (windows_nat_target::detach): Don't call gdb_flush.
7800         * valprint.c (generic_val_print, val_print, val_print_string):
7801         Don't call gdb_flush.
7802         * utils.c (defaulted_query): Don't call gdb_flush.
7803         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7804         * target.c (target_announce_detach): Don't call gdb_flush.
7805         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7806         * remote.c (extended_remote_target::attach): Don't call
7807         gdb_flush.
7808         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7809         * printcmd.c (do_examine): Don't call gdb_flush.
7810         (info_display_command): Don't call gdb_flush.
7811         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7812         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7813         * memattr.c (info_mem_command): Don't call gdb_flush.
7814         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7815         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7816         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7817         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7818         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7819         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7820         (gnu_nat_target::detach): Don't call gdb_flush.
7821         * f-valprint.c (f_val_print): Don't call gdb_flush.
7822         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7823         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7824         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7825         gdb_flush.
7826         * c-valprint.c (c_val_print): Don't call gdb_flush.
7827         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7828
7829 2019-03-05  Tom Tromey  <tromey@adacore.com>
7830
7831         * varobj.c (update_dynamic_varobj_children): Update.
7832         (install_default_visualizer): Use reset, not release.
7833         * value.c (set_internalvar): Update.
7834         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7835         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7836         ATTRIBUTE_UNUSED_RESULT.
7837
7838 2019-03-05  Tom Tromey  <tromey@adacore.com>
7839
7840         * remote.c (class scoped_remote_fd) <release>: Add
7841         ATTRIBUTE_UNUSED_RESULT.
7842
7843 2019-03-05  Tom Tromey  <tromey@adacore.com>
7844
7845         * macroexp.c (struct macro_buffer) <release>: Add
7846         ATTRIBUTE_UNUSED_RESULT.
7847
7848 2019-03-05  Tom Tromey  <tromey@adacore.com>
7849
7850         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7851         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7852         ATTRIBUTE_UNUSED_RESULT.
7853
7854 2019-03-05  Tom Tromey  <tromey@adacore.com>
7855
7856         * common/scoped_fd.h (class scoped_fd) <release>: Add
7857         ATTRIBUTE_UNUSED_RESULT.
7858
7859 2019-03-05  Tom Tromey  <tromey@adacore.com>
7860
7861         * parser-defs.h (struct parser_state) <release>: Add
7862         ATTRIBUTE_UNUSED_RESULT.
7863
7864 2019-03-05  Tom Tromey  <tromey@adacore.com>
7865
7866         * utils.h (class gdb_argv) <release>: Add
7867         ATTRIBUTE_UNUSED_RESULT.
7868         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7869
7870 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7871
7872         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7873         for-loop range, to avoid compiler warnings.
7874
7875         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7876         avoid compiler warnings about unused variables.
7877
7878         * NEWS: Mention end of support for native debugging on MS-Windows
7879         before XP.
7880
7881         PR gdb/24292
7882         * common/netstuff.c:
7883         * gdbserver/gdbreplay.c
7884         * gdbserver/remote-utils.c:
7885         * ser-tcp.c:
7886         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7887         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7888         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7889         'getaddrinfo' and 'freeaddrinfo' were not available before
7890         Windows XP, and mingw.org's MinGW headers by default define
7891         _WIN32_WINNT to 0x500.
7892
7893 2019-03-01  Gary Benson <gbenson@redhat.com>
7894
7895         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7896
7897 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7898             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7899
7900         PR gdb/8527
7901         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7902         set_sigint_trap, clear_sigint_trap.
7903
7904 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7905
7906         * target.c (target_detach): Clear the regcache and the
7907         frame cache.
7908
7909 2019-02-27  Pedro Alves  <palves@redhat.com>
7910
7911         * utils.c (set_screen_size): When we cap the height/width sizes,
7912         tweak the corresponding command variable to show "unlimited":
7913
7914 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7915             Pedro Alves  <palves@redhat.com>
7916
7917         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7918         before calling rl_set_screen_size.
7919
7920 2019-02-27  Tom Tromey  <tromey@adacore.com>
7921
7922         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7923         define.
7924         * python/py-value.c: Remove Python 2.4 workaround.
7925         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7926         workaround.
7927         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7928         Python 2.4 workaround.
7929         * python/python-internal.h: Remove Python 2.4 comment.
7930         (Py_ssize_t): Don't define.
7931         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7932         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7933         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7934         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7935         * python/python.c (do_start_initialization): Remove Python 2.4
7936         workaround.
7937         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7938         (print_children): Remove Python 2.4 workaround.
7939         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7940         workaround.
7941         (CHARBUFFERPROC_NAME): Remove.
7942         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7943         Python 2.4 workaround.
7944
7945 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7946
7947         * NEWS: Note minimum Python version.
7948
7949 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7950
7951         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7952         code from these functions.  Remove corresponding ifdefs.  Use
7953         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7954         Remove gotos and target of gotos.
7955         (infpy_search_memory): Likewise.
7956
7957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7960         (hppa_gdbarch_init): Don't register deleted functions with
7961         gdbarch.
7962
7963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7966         (h8300_unwind_sp): Delete.
7967         (h8300_dummy_id): Delete.
7968         (h8300_gdbarch_init): Don't register deleted functions with
7969         gdbarch.
7970
7971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7974         (ft32_unwind_pc): Delete.
7975         (ft32_unwind_sp): Delete.
7976         (ft32_gdbarch_init): Don't register deleted functions with
7977         gdbarch.
7978
7979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7982         (frv_unwind_pc): Delete.
7983         (frv_unwind_sp): Delete.
7984         (frv_gdbarch_init): Don't register deleted functions with
7985         gdbarch.
7986
7987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7988
7989         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7990         (riscv_unwind_pc): Delete.
7991         (riscv_unwind_sp): Delete.
7992         (riscv_gdbarch_init): Don't register deleted functions with
7993         gdbarch.
7994
7995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7996
7997         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7998         (csky_unwind_pc): Delete.
7999         (csky_unwind_sp): Delete.
8000         (csky_gdbarch_init): Don't register deleted functions with
8001         gdbarch.
8002
8003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8006         (cris_unwind_pc): Delete.
8007         (cris_unwind_sp): Delete.
8008         (cris_gdbarch_init): Don't register deleted functions with
8009         gdbarch.
8010
8011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8012
8013         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8014         (bfin_unwind_pc): Delete.
8015         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8016
8017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8020         (arm_unwind_pc): Delete.
8021         (arm_unwind_sp): Delete.
8022         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8023
8024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8027         (arc_unwind_pc): Delete.
8028         (arc_unwind_sp): Delete.
8029         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8030
8031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8032
8033         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8034         (alpha_unwind_pc): Delete.
8035         (alpha_gdbarch_init): Don't register deleted functions with
8036         gdbarch.
8037
8038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8039
8040         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8041         (aarch64_unwind_pc): Delete.
8042         (aarch64_unwind_sp): Delete.
8043         (aarch64_gdbarch_init): Don't register deleted functions with
8044         gdbarch.
8045
8046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8047
8048         * gdbtypes.c (type_align): Don't consider static members when
8049         computing structure alignment.
8050
8051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8054         return 0 for other types.
8055         * arch-utils.c (default_type_align): Always return 0.
8056         * gdbarch.h: Regenerate.
8057         * gdbarch.sh (type_align): Extend comment.
8058         * gdbtypes.c (type_align): Add additional comments, always call
8059         gdbarch_type_align before applying the default rules.
8060         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8061         generic code will then apply a suitable default.
8062         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8063         types, return 0 for other types.
8064
8065 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8066
8067         * NEWS: Create a new section for the next release branch.
8068         Rename the section of the current branch, now that it has
8069         been cut.
8070
8071 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8072
8073         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8074         * version.in: Bump version to 8.3.50.DATE-git.
8075
8076 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8077
8078         * aix-thread.c (ptid_cmp): Remove unused variable.
8079         (get_signaled_thread): Likewise.
8080         (store_regs_user_thread): Likewise.
8081         (store_regs_kernel_thread): Likewise.
8082         (fetch_regs_kernel_thread): Remove shadowed variable.
8083
8084 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * features/riscv/32bit-cpu.xml: Add register numbers.
8087         * features/riscv/32bit-fpu.c: Regenerate.
8088         * features/riscv/32bit-fpu.xml: Add register numbers.
8089         * features/riscv/64bit-cpu.xml: Add register numbers.
8090         * features/riscv/64bit-fpu.c: Regenerate.
8091         * features/riscv/64bit-fpu.xml: Add register numbers.
8092
8093 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8094
8095         * NEWS: Mention two argument form of gdb.Value constructor.
8096         * python/py-value.c (convert_buffer_and_type_to_value): New
8097         function.
8098         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8099         Add support for handling an optional second argument.  Call
8100         convert_buffer_and_type_to_value as appropriate.
8101         * python/python-internal.h (Py_buffer_deleter): New struct.
8102         (Py_buffer_up): New typedef.
8103
8104 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8105
8106         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8107         instead of releasing ownership.
8108
8109 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8110
8111         * dwarf2read.c (open_and_init_dwp_file): Call
8112         elf_numsections instead of bfd_count_sections to initialize
8113         dwp_file->num_sections.
8114
8115 2019-02-25  Tom Tromey  <tromey@adacore.com>
8116
8117         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8118
8119 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8120
8121         * gcore.in: Add '--readnever' option when invoking GDB.
8122
8123 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8124
8125         * MAINTAINERS: Update my email address.
8126
8127 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8128
8129         * build-id.c (build_id_to_debug_bfd_1): New function.
8130         (build_id_to_debug_bfd): Look for separate debug file in
8131         sysroot.
8132
8133 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * gdbarch.sh: Update the copyright year range that is placed into
8136         generated files.
8137
8138 2019-02-22  Keith Seitz  <keiths@redhat.com>
8139
8140         PR symtab/23853
8141         * linespec.c (create_sals_line_offset): Search for the default
8142         symtab's filename instead of its fullname.
8143
8144 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8145
8146         * NEWS: Update style defaults.
8147
8148 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8149
8150         * main.c (captured_main_1): Disable styling in batch mode.
8151
8152 2019-02-20  Tom Tromey  <tom@tromey.com>
8153
8154         * symtab.c (symtab_symbol_info): Fix typos.
8155
8156 2019-02-20  Tom Tromey  <tromey@adacore.com>
8157
8158         * findcmd.c (_initialize_mem_search): Use upper case for
8159         metasyntactic variables.
8160
8161 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8162
8163         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8164         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8165
8166 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8167
8168         * top.h (source_file_name): Change to std::string.
8169         * top.c (source_file_name): Likewise.
8170         (command_line_input): Adjust.
8171         * cli/cli-script.c (script_from_file): Adjust.
8172
8173 2019-02-19  Tom Tromey  <tromey@adacore.com>
8174
8175         * ravenscar-thread.c
8176         (ravenscar_thread_target::update_thread_list): Don't call
8177         ada_build_task_list.
8178         * ada-lang.h (ada_build_task_list): Don't declare.
8179         * ada-tasks.c (struct ada_tasks_inferior_data)
8180         <task_list_valid_p>: Now bool.
8181         (read_known_tasks, ada_task_list_changed)
8182         (ada_tasks_invalidate_inferior_data): Update.
8183         (read_known_tasks_array): Return bool.
8184         (read_known_tasks_list): Likewise.
8185         (read_known_tasks): Return void.
8186         (ada_build_task_list): Now static.
8187
8188 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8191         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8192
8193 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8194
8195         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8196         variant for ada_tasks_pspace_data_handle and
8197         ada_tasks_inferior_data_handle.
8198         (ada_tasks_pspace_data_cleanup): New function.
8199         (ada_tasks_inferior_data_cleanup): New function.
8200
8201 2019-02-17  Tom Tromey  <tom@tromey.com>
8202
8203         * macrotab.h (macro_source_fullname): Return a std::string.
8204         * macrotab.c (macro_include, check_for_redefinition)
8205         (macro_undef, macro_lookup_definition, foreach_macro)
8206         (foreach_macro_in_scope): Update.
8207         (macro_source_fullname): Return a std::string.
8208         * macrocmd.c (show_pp_source_pos): Update.
8209
8210 2019-02-17  Tom Tromey  <tom@tromey.com>
8211
8212         * macrocmd.c (show_pp_source_pos): Style the file names.
8213
8214 2019-02-17  Tom Tromey  <tom@tromey.com>
8215
8216         PR tui/24197:
8217         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8218
8219 2019-02-17  Tom Tromey  <tom@tromey.com>
8220
8221         * ada-lang.c (user_select_syms): Use filtered printing.
8222         * utils.c (wrap_style): New global.
8223         (desired_style): Remove.
8224         (emit_style_escape): Add stream parameter.
8225         (set_output_style, reset_terminal_style, prompt_for_continue):
8226         Update.
8227         (flush_wrap_buffer): Only flush gdb_stdout.
8228         (wrap_here): Set wrap_style.
8229         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8230         treat escape sequences as a character.  Change when wrap buffer is
8231         flushed.
8232         (fputs_styled): Do not set the output style when the default is
8233         requested.
8234         * ui-style.h (struct ui_file_style) <is_default>: New method.
8235         * source.c (print_source_lines_base): Emit escape sequences in one
8236         piece.
8237
8238 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8239
8240         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8241         integers and enumeration types.
8242
8243 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8244
8245         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8246         instead of lookup_symbol_in_language
8247         (do_exact_match): New function.
8248         (ada_get_symbol_name_matcher): Return do_exact_match when
8249         doing a verbatim match.
8250
8251 2019-02-15  Tom Tromey  <tromey@adacore.com>
8252
8253         * ravenscar-thread.c (ravenscar_thread_target::resume)
8254         (ravenscar_thread_target::wait): Special case wildcard requests.
8255
8256 2019-02-15  Tom Tromey  <tromey@adacore.com>
8257
8258         * ravenscar-thread.c (base_ptid): Remove.
8259         (struct ravenscar_thread_target) <close>: New method.
8260         <m_base_ptid>: New member.
8261         <update_inferior_ptid, active_task, task_is_currently_active,
8262         runtime_initialized>: Declare methods.
8263         <ravenscar_thread_target>: Add constructor.
8264         (ravenscar_thread_target::task_is_currently_active)
8265         (ravenscar_thread_target::update_inferior_ptid)
8266         (ravenscar_runtime_initialized): Rename.  Now methods.
8267         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8268         (ravenscar_thread_target::update_thread_list): Update.
8269         (ravenscar_thread_target::active_task): Now method.
8270         (ravenscar_thread_target::store_registers)
8271         (ravenscar_thread_target::prepare_to_store)
8272         (ravenscar_thread_target::prepare_to_store)
8273         (ravenscar_thread_target::mourn_inferior): Update.
8274         (ravenscar_inferior_created): Use "new" to create target.
8275         (ravenscar_thread_target::get_ada_task_ptid): Update.
8276         (_initialize_ravenscar): Don't initialize base_ptid.
8277         (ravenscar_ops): Remove global.
8278
8279 2019-02-15  Tom Tromey  <tromey@adacore.com>
8280
8281         * target.h (push_target): Declare new overload.
8282         * target.c (push_target): New overload, taking an rvalue reference.
8283         * remote.c (remote_target::open_1): Use push_target overload.
8284         * corelow.c (core_target_open): Use push_target overload.
8285
8286 2019-02-15  Tom Tromey  <tromey@adacore.com>
8287
8288         * ravenscar-thread.c (is_ravenscar_task)
8289         (ravenscar_task_is_currently_active): Return bool.
8290         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8291         (_initialize_ravenscar): Remove "(void)".
8292         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8293         Return bool.
8294
8295 2019-02-15  Tom Tromey  <tromey@adacore.com>
8296
8297         * ravenscar-thread.c (ravenscar_runtime_initializer)
8298         (has_ravenscar_runtime, get_running_thread_id)
8299         (ravenscar_thread_target::resume): Fix indentation.
8300
8301 2019-02-15  Tom Tromey  <tromey@adacore.com>
8302
8303         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8304         from ravenscar_arch_ops.
8305         (sparc_ravenscar_ops::fetch_registers)
8306         (sparc_ravenscar_ops::store_registers): Now methods.
8307         (sparc_ravenscar_prepare_to_store): Remove.
8308         (sparc_ravenscar_ops): Redefine.
8309         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8310         methods and destructor.  Remove members.
8311         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8312         (ravenscar_thread_target::store_registers)
8313         (ravenscar_thread_target::prepare_to_store): Update.
8314         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8315         Remove.
8316         (struct ppc_ravenscar_powerpc_ops): Derive from
8317         ravenscar_arch_ops.
8318         (ppc_ravenscar_powerpc_ops::fetch_registers)
8319         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8320         (ppc_ravenscar_powerpc_ops): Redefine.
8321         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8322         (ppc_ravenscar_e500_ops::fetch_registers)
8323         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8324         (ppc_ravenscar_e500_ops): Redefine.
8325         * aarch64-ravenscar-thread.c
8326         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8327         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8328         (aarch64_ravenscar_fetch_registers)
8329         (aarch64_ravenscar_store_registers): Now methods.
8330         (aarch64_ravenscar_ops): Redefine.
8331
8332 2019-02-15  Tom Tromey  <tromey@adacore.com>
8333
8334         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8335         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8336         (ravenscar_thread_target::stopped_by_watchpoint)
8337         (ravenscar_thread_target::stopped_data_address)
8338         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8339
8340 2019-02-15  Tom Tromey  <tromey@adacore.com>
8341
8342         * ravenscar-thread.c: Fix some typos.
8343
8344 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8345             Tom Tromey  <tromey@adacore.com>
8346
8347         * ada-lang.c (ada_exception_sal): Change addr_string to a
8348         std::string.
8349         (create_ada_exception_catchpoint): Update.
8350
8351 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8352             Tom Tromey  <tromey@adacore.com>
8353
8354         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8355         (bp_location_ops): Remove.
8356         (base_breakpoint_allocate_location): Update.
8357         (free_bp_location): Update.
8358         * ada-lang.c (class ada_catchpoint_location)
8359         <ada_catchpoint_location>: Remove ops parameter.
8360         (ada_catchpoint_location_dtor): Remove.
8361         (ada_catchpoint_location_ops): Remove.
8362         (allocate_location_exception): Update.
8363         * breakpoint.h (struct bp_location_ops): Remove.
8364         (class bp_location) <bp_location>: Remove bp_location_ops
8365         parameter.
8366         <~bp_location>: Add destructor.
8367         <ops>: Remove.
8368
8369 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8370             Pedro Alves  <palves@redhat.com>
8371
8372         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8373         'PATH_MAX'.
8374
8375 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8376             Samuel Thibault  <samuel.thibault@gnu.org>
8377             Thomas Schwinge  <thomas@codesourcery.com>
8378
8379         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8380         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8381
8382 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8383
8384         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8385         (check_empty): Use "const char *".
8386
8387         * gnu-nat.c (gnu_nat_target::detach): Instead of
8388         'detach_inferior (pid)' call
8389         'detach_inferior (find_inferior_pid (pid))'.
8390
8391         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8392         'nat/fork-inferior.o'.
8393         * gnu-nat.c: #include "nat/fork-inferior.h".
8394
8395         * gnu-nat.c (gnu_nat_target::detach): Instead of
8396         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8397         * gnu-nat.h: #include "inf-child.h".
8398         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8399         'i386_gnu_nat_target::fetch_registers'.
8400         (gnu_store_registers): Rename/move to
8401         'i386_gnu_nat_target::store_registers'.
8402
8403         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8404         * gnu-nat.h (mach_thread_info): New function.
8405         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8406
8407         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8408
8409 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8410
8411         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8412
8413 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8414
8415         * windows-nat.c (windows_add_thread): Add new parameter
8416         "main_thread_p" with default value set to false.  Update
8417         function documentation as well as all callers.
8418         (windows_delete_thread): Likewise.
8419         (fake_create_process): Update call to windows_add_thread.
8420         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8421         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8422         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8423         call to windows_delete_thread.
8424
8425 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8426
8427         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8428
8429 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8430
8431         * symfile.c (find_separate_debug_file): Use canonical path of
8432         sysroot with child_path instead of gdb_sysroot if it is valid.
8433
8434 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8435
8436         * symfile.c (find_separate_debug_file): Use child_path to
8437         determine if an object file is under a sysroot.
8438
8439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8440
8441         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8442         unittests/child-path-selftests.c.
8443         * common/pathstuff.c (child_path): New function.
8444         * common/pathstuff.h (child_path): New prototype.
8445         * unittests/child-path-selftests.c: New file.
8446
8447 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8448
8449         * symfile.c (find_separate_debug_file): Look for separate debug
8450         files in debug directories under the sysroot.
8451
8452 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8453
8454         * symtab.h (struct minimal_symbol data_p): New const method.
8455         (struct minimal_symbol text_p): Likewise.
8456         * symtab.c (output_source_filename): Use file name style
8457         to print file name.
8458         (print_symbol_info): Likewise.
8459         (print_msymbol_info): Use address style to print addresses.
8460         Use function name style to print executable text symbols.
8461         (expand_symtab_containing_pc): Use data_p.
8462         (find_pc_sect_compunit_symtab): Likewise.
8463
8464 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8465
8466         * breakpoint.c (describe_other_breakpoints): Use address style
8467         to print addresses.
8468         (say_where): Likewise.
8469
8470 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8471
8472         * ada-typeprint.c (print_func_type): Print function name
8473         style to print function name.
8474         * c-typeprint.c (c_print_type_1): Likewise.
8475
8476 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8477
8478         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8479         for execve.
8480
8481 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8482
8483         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8484         type_stack.
8485
8486 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8487
8488         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8489         TYPE_CODE_REF types.
8490
8491 2019-02-08  Jim Wilson  <jimw@sifive.com>
8492
8493         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8494         (riscv_linux_fregset): New.
8495         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8496
8497 2019-02-07  Tom Tromey  <tom@tromey.com>
8498
8499         * thread.c (thread_cancel_execution_command): Update.
8500         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8501         methods.
8502         (struct thread_fsm_ops): Remove.
8503         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8504         (thread_fsm_should_stop, thread_fsm_return_value)
8505         (thread_fsm_set_finished, thread_fsm_finished_p)
8506         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8507         Don't declare.
8508         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8509         * infrun.c (clear_proceed_status_thread)
8510         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8511         (print_stop_event): Update.
8512         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8513         Add constructor.
8514         (step_command_fsm_ops): Remove.
8515         (new_step_command_fsm): Remove.
8516         (step_1): Update.
8517         (step_command_fsm::should_stop): Rename from
8518         step_command_fsm_should_stop.
8519         (step_command_fsm::clean_up): Rename from
8520         step_command_fsm_clean_up.
8521         (step_command_fsm::do_async_reply_reason): Rename from
8522         step_command_fsm_async_reply_reason.
8523         (struct until_next_fsm): Inherit from thread_fsm.  Add
8524         constructor.
8525         (until_next_fsm_ops): Remove.
8526         (new_until_next_fsm): Remove.
8527         (until_next_fsm::should_stop): Rename from
8528         until_next_fsm_should_stop.
8529         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8530         (until_next_fsm::do_async_reply_reason): Rename from
8531         until_next_fsm_async_reply_reason.
8532         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8533         constructor.  Change type of breakpoint.
8534         (finish_command_fsm_ops): Remove.
8535         (new_finish_command_fsm): Remove.
8536         (finish_command_fsm::should_stop): Rename from
8537         finish_command_fsm_should_stop.
8538         (finish_command_fsm::clean_up): Rename from
8539         finish_command_fsm_clean_up.
8540         (finish_command_fsm::return_value): Rename from
8541         finish_command_fsm_return_value.
8542         (finish_command_fsm::do_async_reply_reason): Rename from
8543         finish_command_fsm_async_reply_reason.
8544         (finish_command): Update.
8545         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8546         Add constructor.
8547         (call_thread_fsm_ops): Remove.
8548         (call_thread_fsm::call_thread_fsm): Rename from
8549         new_call_thread_fsm.
8550         (call_thread_fsm::should_stop): Rename from
8551         call_thread_fsm_should_stop.
8552         (call_thread_fsm::should_notify_stop): Rename from
8553         call_thread_fsm_should_notify_stop.
8554         (run_inferior_call, call_function_by_hand_dummy): Update.
8555         * cli/cli-interp.c (should_print_stop_to_console): Update.
8556         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8557         Add constructor.  Change type of location_breakpoint,
8558         caller_breakpoint.
8559         (until_break_fsm_ops): Remove.
8560         (new_until_break_fsm): Remove.
8561         (until_break_fsm::should_stop): Rename from
8562         until_break_fsm_should_stop.
8563         (until_break_fsm::clean_up): Rename from
8564         until_break_fsm_clean_up.
8565         (until_break_fsm::do_async_reply_reason): Rename from
8566         until_break_fsm_async_reply_reason.
8567         (until_break_command): Update.
8568         * thread-fsm.c: Remove.
8569         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8570
8571 2019-02-07  Tom Tromey  <tom@tromey.com>
8572
8573         * yy-remap.h: Add include guard.
8574         * xtensa-tdep.h: Add include guard.
8575         * xcoffread.h: Rename include guard.
8576         * varobj-iter.h: Add include guard.
8577         * tui/tui.h: Rename include guard.
8578         * tui/tui-winsource.h: Rename include guard.
8579         * tui/tui-wingeneral.h: Rename include guard.
8580         * tui/tui-windata.h: Rename include guard.
8581         * tui/tui-win.h: Rename include guard.
8582         * tui/tui-stack.h: Rename include guard.
8583         * tui/tui-source.h: Rename include guard.
8584         * tui/tui-regs.h: Rename include guard.
8585         * tui/tui-out.h: Rename include guard.
8586         * tui/tui-layout.h: Rename include guard.
8587         * tui/tui-io.h: Rename include guard.
8588         * tui/tui-hooks.h: Rename include guard.
8589         * tui/tui-file.h: Rename include guard.
8590         * tui/tui-disasm.h: Rename include guard.
8591         * tui/tui-data.h: Rename include guard.
8592         * tui/tui-command.h: Rename include guard.
8593         * tic6x-tdep.h: Add include guard.
8594         * target/waitstatus.h: Rename include guard.
8595         * target/wait.h: Rename include guard.
8596         * target/target.h: Rename include guard.
8597         * target/resume.h: Rename include guard.
8598         * target-float.h: Rename include guard.
8599         * stabsread.h: Add include guard.
8600         * rs6000-tdep.h: Add include guard.
8601         * riscv-fbsd-tdep.h: Add include guard.
8602         * regformats/regdef.h: Rename include guard.
8603         * record.h: Rename include guard.
8604         * python/python.h: Rename include guard.
8605         * python/python-internal.h: Rename include guard.
8606         * python/py-stopevent.h: Rename include guard.
8607         * python/py-ref.h: Rename include guard.
8608         * python/py-record.h: Rename include guard.
8609         * python/py-record-full.h: Rename include guard.
8610         * python/py-record-btrace.h: Rename include guard.
8611         * python/py-instruction.h: Rename include guard.
8612         * python/py-events.h: Rename include guard.
8613         * python/py-event.h: Rename include guard.
8614         * procfs.h: Add include guard.
8615         * proc-utils.h: Add include guard.
8616         * p-lang.h: Add include guard.
8617         * or1k-tdep.h: Rename include guard.
8618         * observable.h: Rename include guard.
8619         * nto-tdep.h: Rename include guard.
8620         * nat/x86-linux.h: Rename include guard.
8621         * nat/x86-linux-dregs.h: Rename include guard.
8622         * nat/x86-gcc-cpuid.h: Add include guard.
8623         * nat/x86-dregs.h: Rename include guard.
8624         * nat/x86-cpuid.h: Rename include guard.
8625         * nat/ppc-linux.h: Rename include guard.
8626         * nat/mips-linux-watch.h: Rename include guard.
8627         * nat/linux-waitpid.h: Rename include guard.
8628         * nat/linux-ptrace.h: Rename include guard.
8629         * nat/linux-procfs.h: Rename include guard.
8630         * nat/linux-osdata.h: Rename include guard.
8631         * nat/linux-nat.h: Rename include guard.
8632         * nat/linux-namespaces.h: Rename include guard.
8633         * nat/linux-btrace.h: Rename include guard.
8634         * nat/glibc_thread_db.h: Rename include guard.
8635         * nat/gdb_thread_db.h: Rename include guard.
8636         * nat/gdb_ptrace.h: Rename include guard.
8637         * nat/fork-inferior.h: Rename include guard.
8638         * nat/amd64-linux-siginfo.h: Rename include guard.
8639         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8640         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8641         * nat/aarch64-linux.h: Rename include guard.
8642         * nat/aarch64-linux-hw-point.h: Rename include guard.
8643         * mn10300-tdep.h: Add include guard.
8644         * mips-linux-tdep.h: Add include guard.
8645         * mi/mi-parse.h: Rename include guard.
8646         * mi/mi-out.h: Rename include guard.
8647         * mi/mi-main.h: Rename include guard.
8648         * mi/mi-interp.h: Rename include guard.
8649         * mi/mi-getopt.h: Rename include guard.
8650         * mi/mi-console.h: Rename include guard.
8651         * mi/mi-common.h: Rename include guard.
8652         * mi/mi-cmds.h: Rename include guard.
8653         * mi/mi-cmd-break.h: Rename include guard.
8654         * m2-lang.h: Add include guard.
8655         * location.h: Rename include guard.
8656         * linux-record.h: Rename include guard.
8657         * linux-nat.h: Add include guard.
8658         * linux-fork.h: Add include guard.
8659         * i386-darwin-tdep.h: Rename include guard.
8660         * hppa-linux-offsets.h: Add include guard.
8661         * guile/guile.h: Rename include guard.
8662         * guile/guile-internal.h: Rename include guard.
8663         * gnu-nat.h: Rename include guard.
8664         * gdb-stabs.h: Rename include guard.
8665         * frv-tdep.h: Add include guard.
8666         * f-lang.h: Add include guard.
8667         * event-loop.h: Add include guard.
8668         * darwin-nat.h: Rename include guard.
8669         * cp-abi.h: Rename include guard.
8670         * config/sparc/nm-sol2.h: Rename include guard.
8671         * config/nm-nto.h: Rename include guard.
8672         * config/nm-linux.h: Add include guard.
8673         * config/i386/nm-i386gnu.h: Rename include guard.
8674         * config/djgpp/nl_types.h: Rename include guard.
8675         * config/djgpp/langinfo.h: Rename include guard.
8676         * compile/gcc-cp-plugin.h: Add include guard.
8677         * compile/gcc-c-plugin.h: Add include guard.
8678         * compile/compile.h: Rename include guard.
8679         * compile/compile-object-run.h: Rename include guard.
8680         * compile/compile-object-load.h: Rename include guard.
8681         * compile/compile-internal.h: Rename include guard.
8682         * compile/compile-cplus.h: Rename include guard.
8683         * compile/compile-c.h: Rename include guard.
8684         * common/xml-utils.h: Rename include guard.
8685         * common/x86-xstate.h: Rename include guard.
8686         * common/version.h: Rename include guard.
8687         * common/vec.h: Rename include guard.
8688         * common/tdesc.h: Rename include guard.
8689         * common/selftest.h: Rename include guard.
8690         * common/scoped_restore.h: Rename include guard.
8691         * common/scoped_mmap.h: Rename include guard.
8692         * common/scoped_fd.h: Rename include guard.
8693         * common/safe-iterator.h: Rename include guard.
8694         * common/run-time-clock.h: Rename include guard.
8695         * common/refcounted-object.h: Rename include guard.
8696         * common/queue.h: Rename include guard.
8697         * common/ptid.h: Rename include guard.
8698         * common/print-utils.h: Rename include guard.
8699         * common/preprocessor.h: Rename include guard.
8700         * common/pathstuff.h: Rename include guard.
8701         * common/observable.h: Rename include guard.
8702         * common/netstuff.h: Rename include guard.
8703         * common/job-control.h: Rename include guard.
8704         * common/host-defs.h: Rename include guard.
8705         * common/gdb_wait.h: Rename include guard.
8706         * common/gdb_vecs.h: Rename include guard.
8707         * common/gdb_unlinker.h: Rename include guard.
8708         * common/gdb_unique_ptr.h: Rename include guard.
8709         * common/gdb_tilde_expand.h: Rename include guard.
8710         * common/gdb_sys_time.h: Rename include guard.
8711         * common/gdb_string_view.h: Rename include guard.
8712         * common/gdb_splay_tree.h: Rename include guard.
8713         * common/gdb_setjmp.h: Rename include guard.
8714         * common/gdb_ref_ptr.h: Rename include guard.
8715         * common/gdb_optional.h: Rename include guard.
8716         * common/gdb_locale.h: Rename include guard.
8717         * common/gdb_assert.h: Rename include guard.
8718         * common/filtered-iterator.h: Rename include guard.
8719         * common/filestuff.h: Rename include guard.
8720         * common/fileio.h: Rename include guard.
8721         * common/environ.h: Rename include guard.
8722         * common/common-utils.h: Rename include guard.
8723         * common/common-types.h: Rename include guard.
8724         * common/common-regcache.h: Rename include guard.
8725         * common/common-inferior.h: Rename include guard.
8726         * common/common-gdbthread.h: Rename include guard.
8727         * common/common-exceptions.h: Rename include guard.
8728         * common/common-defs.h: Rename include guard.
8729         * common/common-debug.h: Rename include guard.
8730         * common/cleanups.h: Rename include guard.
8731         * common/buffer.h: Rename include guard.
8732         * common/btrace-common.h: Rename include guard.
8733         * common/break-common.h: Rename include guard.
8734         * cli/cli-utils.h: Rename include guard.
8735         * cli/cli-style.h: Rename include guard.
8736         * cli/cli-setshow.h: Rename include guard.
8737         * cli/cli-script.h: Rename include guard.
8738         * cli/cli-interp.h: Rename include guard.
8739         * cli/cli-decode.h: Rename include guard.
8740         * cli/cli-cmds.h: Rename include guard.
8741         * charset-list.h: Add include guard.
8742         * buildsym-legacy.h: Rename include guard.
8743         * bfin-tdep.h: Add include guard.
8744         * ax.h: Rename include guard.
8745         * arm-linux-tdep.h: Add include guard.
8746         * arm-fbsd-tdep.h: Add include guard.
8747         * arch/xtensa.h: Rename include guard.
8748         * arch/tic6x.h: Add include guard.
8749         * arch/i386.h: Add include guard.
8750         * arch/arm.h: Rename include guard.
8751         * arch/arm-linux.h: Rename include guard.
8752         * arch/arm-get-next-pcs.h: Rename include guard.
8753         * arch/amd64.h: Add include guard.
8754         * arch/aarch64-insn.h: Rename include guard.
8755         * arch-utils.h: Rename include guard.
8756         * annotate.h: Add include guard.
8757         * amd64-darwin-tdep.h: Rename include guard.
8758         * aarch64-linux-tdep.h: Add include guard.
8759         * aarch64-fbsd-tdep.h: Add include guard.
8760         * aarch32-linux-nat.h: Add include guard.
8761
8762 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8763
8764         * macrotab.c (macro_define_internal): New function that
8765         factorizes macro_define_object_internal and macro_define_function
8766         code.
8767         (macro_define_object_internal): Use macro_define_internal.
8768         (macro_define_function): Likewise.
8769
8770 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8771
8772         * macrocmd.c (extract_identifier): Return
8773         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8774         callers.
8775
8776 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8777
8778         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8779
8780 2019-02-05  Tom Tromey  <tom@tromey.com>
8781
8782         * target.c (target_stack::unpush): Move assertion earlier.
8783
8784 2019-01-30  Tom Tromey  <tom@tromey.com>
8785
8786         PR python/23615:
8787         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8788         (gdbpy_parse_and_eval): Likewise.
8789         * python/python-internal.h (gdbpy_allow_threads): New class.
8790
8791 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8792
8793         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8794         (aarch64_fbsd_fpregmap): Move earlier.
8795         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8796         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8797         instead of individual calls to trad_frame_set_reg_addr.
8798         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8799         earlier.
8800         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8801         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8802         instead of individual calls to trad_frame_set_reg_addr.
8803
8804 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8805
8806         * CONTRIBUTE: Replace contribution list with wiki link.
8807
8808 2019-01-25  Tom Tromey  <tom@tromey.com>
8809
8810         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8811
8812 2019-01-25  Tom Tromey  <tom@tromey.com>
8813
8814         * xtensa-linux-nat.c: Fix common/ includes.
8815         * xml-support.h: Fix common/ includes.
8816         * xml-support.c: Fix common/ includes.
8817         * x86-linux-nat.c: Fix common/ includes.
8818         * windows-nat.c: Fix common/ includes.
8819         * varobj.h: Fix common/ includes.
8820         * varobj.c: Fix common/ includes.
8821         * value.c: Fix common/ includes.
8822         * valops.c: Fix common/ includes.
8823         * utils.c: Fix common/ includes.
8824         * unittests/xml-utils-selftests.c: Fix common/ includes.
8825         * unittests/utils-selftests.c: Fix common/ includes.
8826         * unittests/unpack-selftests.c: Fix common/ includes.
8827         * unittests/tracepoint-selftests.c: Fix common/ includes.
8828         * unittests/style-selftests.c: Fix common/ includes.
8829         * unittests/string_view-selftests.c: Fix common/ includes.
8830         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8831         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8832         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8833         * unittests/rsp-low-selftests.c: Fix common/ includes.
8834         * unittests/parse-connection-spec-selftests.c: Fix common/
8835         includes.
8836         * unittests/optional-selftests.c: Fix common/ includes.
8837         * unittests/offset-type-selftests.c: Fix common/ includes.
8838         * unittests/observable-selftests.c: Fix common/ includes.
8839         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8840         * unittests/memrange-selftests.c: Fix common/ includes.
8841         * unittests/memory-map-selftests.c: Fix common/ includes.
8842         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8843         * unittests/function-view-selftests.c: Fix common/ includes.
8844         * unittests/environ-selftests.c: Fix common/ includes.
8845         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8846         * unittests/common-utils-selftests.c: Fix common/ includes.
8847         * unittests/cli-utils-selftests.c: Fix common/ includes.
8848         * unittests/array-view-selftests.c: Fix common/ includes.
8849         * ui-file.c: Fix common/ includes.
8850         * tui/tui-io.c: Fix common/ includes.
8851         * tracepoint.h: Fix common/ includes.
8852         * tracepoint.c: Fix common/ includes.
8853         * tracefile-tfile.c: Fix common/ includes.
8854         * top.h: Fix common/ includes.
8855         * top.c: Fix common/ includes.
8856         * thread.c: Fix common/ includes.
8857         * target/waitstatus.h: Fix common/ includes.
8858         * target/waitstatus.c: Fix common/ includes.
8859         * target.h: Fix common/ includes.
8860         * target.c: Fix common/ includes.
8861         * target-memory.c: Fix common/ includes.
8862         * target-descriptions.c: Fix common/ includes.
8863         * symtab.h: Fix common/ includes.
8864         * symfile.c: Fix common/ includes.
8865         * stap-probe.c: Fix common/ includes.
8866         * spu-linux-nat.c: Fix common/ includes.
8867         * sparc-nat.c: Fix common/ includes.
8868         * source.c: Fix common/ includes.
8869         * solib.c: Fix common/ includes.
8870         * solib-target.c: Fix common/ includes.
8871         * ser-unix.c: Fix common/ includes.
8872         * ser-tcp.c: Fix common/ includes.
8873         * ser-pipe.c: Fix common/ includes.
8874         * ser-base.c: Fix common/ includes.
8875         * selftest-arch.c: Fix common/ includes.
8876         * s12z-tdep.c: Fix common/ includes.
8877         * rust-exp.y: Fix common/ includes.
8878         * rs6000-aix-tdep.c: Fix common/ includes.
8879         * riscv-tdep.c: Fix common/ includes.
8880         * remote.c: Fix common/ includes.
8881         * remote-notif.h: Fix common/ includes.
8882         * remote-fileio.h: Fix common/ includes.
8883         * remote-fileio.c: Fix common/ includes.
8884         * regcache.h: Fix common/ includes.
8885         * regcache.c: Fix common/ includes.
8886         * record-btrace.c: Fix common/ includes.
8887         * python/python.c: Fix common/ includes.
8888         * python/py-type.c: Fix common/ includes.
8889         * python/py-inferior.c: Fix common/ includes.
8890         * progspace.h: Fix common/ includes.
8891         * producer.c: Fix common/ includes.
8892         * procfs.c: Fix common/ includes.
8893         * proc-api.c: Fix common/ includes.
8894         * printcmd.c: Fix common/ includes.
8895         * ppc-linux-nat.c: Fix common/ includes.
8896         * parser-defs.h: Fix common/ includes.
8897         * osdata.c: Fix common/ includes.
8898         * obsd-nat.c: Fix common/ includes.
8899         * nat/x86-linux.c: Fix common/ includes.
8900         * nat/x86-linux-dregs.c: Fix common/ includes.
8901         * nat/x86-dregs.h: Fix common/ includes.
8902         * nat/x86-dregs.c: Fix common/ includes.
8903         * nat/ppc-linux.c: Fix common/ includes.
8904         * nat/mips-linux-watch.h: Fix common/ includes.
8905         * nat/mips-linux-watch.c: Fix common/ includes.
8906         * nat/linux-waitpid.c: Fix common/ includes.
8907         * nat/linux-ptrace.h: Fix common/ includes.
8908         * nat/linux-ptrace.c: Fix common/ includes.
8909         * nat/linux-procfs.c: Fix common/ includes.
8910         * nat/linux-personality.c: Fix common/ includes.
8911         * nat/linux-osdata.c: Fix common/ includes.
8912         * nat/linux-namespaces.c: Fix common/ includes.
8913         * nat/linux-btrace.h: Fix common/ includes.
8914         * nat/linux-btrace.c: Fix common/ includes.
8915         * nat/fork-inferior.c: Fix common/ includes.
8916         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8917         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8918         * nat/aarch64-linux.c: Fix common/ includes.
8919         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8920         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8921         * namespace.h: Fix common/ includes.
8922         * mips-linux-tdep.c: Fix common/ includes.
8923         * minsyms.c: Fix common/ includes.
8924         * mi/mi-parse.h: Fix common/ includes.
8925         * mi/mi-main.c: Fix common/ includes.
8926         * mi/mi-cmd-env.c: Fix common/ includes.
8927         * memrange.h: Fix common/ includes.
8928         * memattr.c: Fix common/ includes.
8929         * maint.h: Fix common/ includes.
8930         * maint.c: Fix common/ includes.
8931         * main.c: Fix common/ includes.
8932         * machoread.c: Fix common/ includes.
8933         * location.c: Fix common/ includes.
8934         * linux-thread-db.c: Fix common/ includes.
8935         * linux-nat.c: Fix common/ includes.
8936         * linux-fork.c: Fix common/ includes.
8937         * inline-frame.c: Fix common/ includes.
8938         * infrun.c: Fix common/ includes.
8939         * inflow.c: Fix common/ includes.
8940         * inferior.h: Fix common/ includes.
8941         * inferior.c: Fix common/ includes.
8942         * infcmd.c: Fix common/ includes.
8943         * inf-ptrace.c: Fix common/ includes.
8944         * inf-child.c: Fix common/ includes.
8945         * ia64-linux-nat.c: Fix common/ includes.
8946         * i387-tdep.c: Fix common/ includes.
8947         * i386-tdep.c: Fix common/ includes.
8948         * i386-linux-tdep.c: Fix common/ includes.
8949         * i386-linux-nat.c: Fix common/ includes.
8950         * i386-go32-tdep.c: Fix common/ includes.
8951         * i386-fbsd-tdep.c: Fix common/ includes.
8952         * i386-fbsd-nat.c: Fix common/ includes.
8953         * guile/scm-type.c: Fix common/ includes.
8954         * guile/guile.c: Fix common/ includes.
8955         * go32-nat.c: Fix common/ includes.
8956         * gnu-nat.c: Fix common/ includes.
8957         * gdbthread.h: Fix common/ includes.
8958         * gdbarch-selftests.c: Fix common/ includes.
8959         * gdb_usleep.c: Fix common/ includes.
8960         * gdb_select.h: Fix common/ includes.
8961         * gdb_bfd.c: Fix common/ includes.
8962         * gcore.c: Fix common/ includes.
8963         * fork-child.c: Fix common/ includes.
8964         * findvar.c: Fix common/ includes.
8965         * fbsd-nat.c: Fix common/ includes.
8966         * event-top.c: Fix common/ includes.
8967         * event-loop.c: Fix common/ includes.
8968         * dwarf2read.c: Fix common/ includes.
8969         * dwarf2loc.c: Fix common/ includes.
8970         * dwarf2-frame.c: Fix common/ includes.
8971         * dwarf-index-cache.c: Fix common/ includes.
8972         * dtrace-probe.c: Fix common/ includes.
8973         * disasm-selftests.c: Fix common/ includes.
8974         * defs.h: Fix common/ includes.
8975         * csky-tdep.c: Fix common/ includes.
8976         * cp-valprint.c: Fix common/ includes.
8977         * cp-support.h: Fix common/ includes.
8978         * cp-support.c: Fix common/ includes.
8979         * corelow.c: Fix common/ includes.
8980         * completer.h: Fix common/ includes.
8981         * completer.c: Fix common/ includes.
8982         * compile/compile.c: Fix common/ includes.
8983         * compile/compile-loc2c.c: Fix common/ includes.
8984         * compile/compile-cplus-types.c: Fix common/ includes.
8985         * compile/compile-cplus-symbols.c: Fix common/ includes.
8986         * command.h: Fix common/ includes.
8987         * cli/cli-dump.c: Fix common/ includes.
8988         * cli/cli-cmds.c: Fix common/ includes.
8989         * charset.c: Fix common/ includes.
8990         * build-id.c: Fix common/ includes.
8991         * btrace.h: Fix common/ includes.
8992         * btrace.c: Fix common/ includes.
8993         * breakpoint.h: Fix common/ includes.
8994         * breakpoint.c: Fix common/ includes.
8995         * ax.h:
8996         (enum agent_op): Fix common/ includes.
8997         * ax-general.c (struct aop_map): Fix common/ includes.
8998         * ax-gdb.c: Fix common/ includes.
8999         * auxv.c: Fix common/ includes.
9000         * auto-load.c: Fix common/ includes.
9001         * arm-tdep.c: Fix common/ includes.
9002         * arch/riscv.c: Fix common/ includes.
9003         * arch/ppc-linux-common.c: Fix common/ includes.
9004         * arch/i386.c: Fix common/ includes.
9005         * arch/arm.c: Fix common/ includes.
9006         * arch/arm-linux.c: Fix common/ includes.
9007         * arch/arm-get-next-pcs.c: Fix common/ includes.
9008         * arch/amd64.c: Fix common/ includes.
9009         * arch/aarch64.c: Fix common/ includes.
9010         * arch/aarch64-insn.c: Fix common/ includes.
9011         * arch-utils.c: Fix common/ includes.
9012         * amd64-windows-tdep.c: Fix common/ includes.
9013         * amd64-tdep.c: Fix common/ includes.
9014         * amd64-sol2-tdep.c: Fix common/ includes.
9015         * amd64-obsd-tdep.c: Fix common/ includes.
9016         * amd64-nbsd-tdep.c: Fix common/ includes.
9017         * amd64-linux-tdep.c: Fix common/ includes.
9018         * amd64-linux-nat.c: Fix common/ includes.
9019         * amd64-fbsd-tdep.c: Fix common/ includes.
9020         * amd64-fbsd-nat.c: Fix common/ includes.
9021         * amd64-dicos-tdep.c: Fix common/ includes.
9022         * amd64-darwin-tdep.c: Fix common/ includes.
9023         * agent.c: Fix common/ includes.
9024         * ada-lang.h: Fix common/ includes.
9025         * ada-lang.c: Fix common/ includes.
9026         * aarch64-tdep.c: Fix common/ includes.
9027
9028 2019-01-25  Tom Tromey  <tom@tromey.com>
9029
9030         * common/create-version.sh: Use common/version.h.
9031
9032 2019-01-24  Pedro Alves  <palves@redhat.com>
9033
9034         * infrun.c (signal_stop, signal_print, signal_program)
9035         (signal_catch, signal_pass): Now arrays instead of pointers.
9036         (update_signals_program_target, do_target_resume)
9037         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9038         * linux-nat.c (linux_nat_target::pass_signals)
9039         (linux_nat_target::create_inferior, linux_nat_target::attach):
9040         Adjust.
9041         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9042         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9043         * procfs.c (procfs_target::pass_signals): Adjust.
9044         * record-full.c (record_full_target::resume): Adjust.
9045         * remote.c (remote_target::pass_signals)
9046         (remote_target::program_signals): Adjust.
9047         * target-debug.h (target_debug_print_signals): Now takes a
9048         gdb::array_view as parameter.  Adjust.
9049         * target.h (target_ops) <pass_signals, program_signals>: Replace
9050         pointer and length parameters with gdb::array_view.
9051         (target_pass_signals, target_program_signals): Likewise.
9052         * target-delegates.c: Regenerate.
9053
9054 2019-01-24  Pedro Alves  <palves@redhat.com>
9055
9056         * common/forward-scope-exit.h
9057         (forward_scope_exit::forward_scope_exit): Pass arguments to
9058         m_bind_function directly, instead of creating a std::bind and
9059         copying that.
9060
9061 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9062
9063         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9064         for static members.
9065         (pass_in_v_vfp_candidate): Likewise.
9066
9067 2019-01-23  Tom Tromey  <tom@tromey.com>
9068             Pedro Alves  <palves@redhat.com>
9069
9070         * regcache.c (class regcache_invalidator): Remove.
9071         (regcache::raw_write): Use make_scope_exit.
9072
9073 2019-01-23  Tom Tromey  <tom@tromey.com>
9074
9075         * ui-out.h (class ui_out_emit_type): Update comment.
9076
9077 2019-01-23  Tom Tromey  <tom@tromey.com>
9078
9079         * infrun.c (fetch_inferior_event): Update comment.
9080
9081 2019-01-23  Tom Tromey  <tom@tromey.com>
9082             Pedro Alves  <palves@redhat.com>
9083
9084         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9085         parameter.
9086         (fetch_inferior_event): Use SCOPE_EXIT.
9087
9088
9089 2019-01-23  Tom Tromey  <tom@tromey.com>
9090             Pedro Alves  <palves@redhat.com>
9091
9092         * infrun.c (disable_thread_events): Delete.
9093         (stop_all_threads): Use SCOPE_EXIT.
9094
9095 2019-01-23  Tom Tromey  <tom@tromey.com>
9096             Pedro Alves  <palves@redhat.com>
9097
9098         * symfile.c: Include forward-scope-exit.h.
9099         (clear_symtab_users_cleanup): Replace forward declaration with
9100         a FORWARD_SCOPE_EXIT.
9101         (syms_from_objfile_1): Use the forward_scope_exit and
9102         gdb::optional instead of cleanup_function.
9103         (reread_symbols): Use the forward_scope_exit instead of
9104         cleanup_function.
9105         (clear_symtab_users_cleanup): Remove function.
9106
9107 2019-01-23  Tom Tromey  <tom@tromey.com>
9108             Pedro Alves  <palves@redhat.com>
9109
9110         * linux-nat.c: Include scope-exit.h.
9111         (cleanup_target_stop): Remove.
9112         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9113         SCOPE_EXIT.
9114
9115 2019-01-23  Tom Tromey  <tom@tromey.com>
9116             Pedro Alves  <palves@redhat.com>
9117
9118         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9119         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9120
9121 2019-01-23  Tom Tromey  <tom@tromey.com>
9122             Andrew Burgess  <andrew.burgess@embecosm.com>
9123             Pedro Alves  <palves@redhat.com>
9124
9125         * infrun.c (fetch_inferior_event): Use scope_exit.
9126         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9127         * top.c (execute_command): Use scope_exit.
9128         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9129         * utils.c (do_bpstat_clear_actions_cleanup)
9130         (make_bpstat_clear_actions_cleanup): Remove.
9131
9132 2019-01-23  Tom Tromey  <tom@tromey.com>
9133             Pedro Alves  <palves@redhat.com>
9134
9135         * infrun.c: Include "common/scope-exit.h"
9136         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9137         (wait_for_inferior): Use SCOPE_EXIT.
9138         (fetch_inferior_event): Use scope_exit.
9139
9140 2019-01-23  Tom Tromey  <tom@tromey.com>
9141             Pedro Alves  <palves@redhat.com>
9142
9143         * breakpoint.c (create_breakpoint): Remove cleanup.
9144
9145 2019-01-23  Tom Tromey  <tom@tromey.com>
9146             Andrew Burgess  <andrew.burgess@embecosm.com>
9147             Pedro Alves  <palves@redhat.com>
9148
9149 2019-01-23  Pedro Alves  <palves@redhat.com>
9150
9151         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9152
9153 2019-01-23  Pedro Alves  <palves@redhat.com>
9154             Andrew Burgess  <andrew.burgess@embecosm.com>
9155
9156         * gdbthread.h: Include "common/forward-scope-exit.h".
9157         (scoped_finish_thread_state): Redefine custom class in terms of
9158         forward_scope_exit.
9159
9160 2019-01-23  Pedro Alves  <palves@redhat.com>
9161             Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * common/forward-scope-exit.h: New file.
9164
9165 2019-01-23  Pedro Alves  <palves@redhat.com>
9166             Andrew Burgess  <andrew.burgess@embecosm.com>
9167             Tom Tromey  <tom@tromey.com>
9168
9169         * common/scope-exit.h: New file.
9170
9171 2019-01-23  Pedro Alves  <palves@redhat.com>
9172
9173         * common/preprocessor.h (ESC): Rename to ...
9174         (ESC_PARENS): ... this.
9175         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9176         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9177
9178 2019-01-23  Tom Tromey  <tom@tromey.com>
9179
9180         * language.h (class scoped_switch_to_sym_language_if_auto):
9181         Initialize m_lang in both cases.
9182
9183 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9184
9185         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9186         with XCNEW.
9187
9188 2019-01-22  Tom Tromey  <tom@tromey.com>
9189
9190         * corelow.c: Do not include sys/file.h.
9191
9192 2019-01-22  Tom Tromey  <tom@tromey.com>
9193
9194         * tui/tui-wingeneral.h: Include gdb_curses.h.
9195
9196 2019-01-22  Tom Tromey  <tom@tromey.com>
9197
9198         * source-cache.h (class source_cache) <get_source_lines,
9199         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9200
9201 2019-01-22  Tom Tromey  <tom@tromey.com>
9202
9203         * remote-fileio.h (struct remote_target): Declare.
9204
9205 2019-01-22  Tom Tromey  <tom@tromey.com>
9206
9207         * python/py-arch.c: Do not include py-ref.h.
9208         * python/py-bpevent.c: Do not include py-ref.h.
9209         * python/py-cmd.c: Do not include py-ref.h.
9210         * python/py-continueevent.c: Do not include py-ref.h.
9211         * python/py-event.h: Do not include py-ref.h.
9212         * python/py-evtregistry.c: Do not include py-ref.h.
9213         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9214         * python/py-frame.c: Do not include py-ref.h.
9215         * python/py-framefilter.c: Do not include py-ref.h.
9216         * python/py-function.c: Do not include py-ref.h.
9217         * python/py-infevents.c: Do not include py-ref.h.
9218         * python/py-linetable.c: Do not include py-ref.h.
9219         * python/py-objfile.c: Do not include py-ref.h.
9220         * python/py-param.c: Do not include py-ref.h.
9221         * python/py-prettyprint.c: Do not include py-ref.h.
9222         * python/py-progspace.c: Do not include py-ref.h.
9223         * python/py-symbol.c: Do not include py-ref.h.
9224         * python/py-symtab.c: Do not include py-ref.h.
9225         * python/py-type.c: Do not include py-ref.h.
9226         * python/py-unwind.c: Do not include py-ref.h.
9227         * python/py-utils.c: Do not include py-ref.h.
9228         * python/py-value.c: Do not include py-ref.h.
9229         * python/py-varobj.c: Do not include py-ref.h.
9230         * python/py-xmethods.c: Do not include py-ref.h.
9231         * python/python.c: Do not include py-ref.h.
9232         * varobj.c: Do not include py-ref.h.
9233
9234 2019-01-22  Tom Tromey  <tom@tromey.com>
9235
9236         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9237         keyword for bcache.
9238
9239 2019-01-22  Tom Tromey  <tom@tromey.com>
9240
9241         * compile/compile-cplus-types.c: Remove a comment by #include.
9242
9243 2019-01-22  Tom Tromey  <tom@tromey.com>
9244
9245         * compile/gcc-c-plugin.h: Include compile-internal.h.
9246
9247 2019-01-22  Tom Tromey  <tom@tromey.com>
9248
9249         * stabsread.c (EXTERN): Do not define.
9250         (symnum, next_symbol_text_func, processing_gcc_compilation)
9251         (within_function, global_sym_chain, global_stabs)
9252         (previous_stab_code, this_object_header_files)
9253         (n_this_object_header_files)
9254         (n_allocated_this_object_header_files): Define.
9255         * stabsread.h (EXTERN): Never define.  Use "extern".
9256
9257 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9258
9259         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9260         history_value.
9261
9262 2019-01-21  Tom Tromey  <tom@tromey.com>
9263
9264         * ui-out.c: Fix includes.
9265         * tui/tui-source.c: Fix includes.
9266         * target.c: Fix includes.
9267         * remote.c: Fix includes.
9268         * regcache.c: Fix includes.
9269         * python/py-block.c: Fix includes.
9270         * printcmd.c: Fix includes.
9271         * or1k-tdep.c: Fix includes.
9272         * mi/mi-main.c: Fix includes.
9273         * m32r-tdep.c: Fix includes.
9274         * csky-tdep.c: Fix includes.
9275         * compile/compile-cplus-types.c: Fix includes.
9276         * cli/cli-interp.c: Fix includes.
9277
9278 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9279
9280         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9281         for padding.
9282
9283 2019-01-16  Tom Tromey  <tom@tromey.com>
9284
9285         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9286         earlier.
9287         (struct objfile) <msymbols_range>: Move from top level.
9288         <msymbols>: New method.
9289         (class objfile_msymbols): Remove.
9290         * symtab.c (default_collect_symbol_completion_matches_break_on):
9291         Update.
9292         * symmisc.c (dump_msymbols): Update.
9293         * stabsread.c (scan_file_globals): Update.
9294         * objc-lang.c (info_selectors_command, info_classes_command)
9295         (find_methods): Update.
9296         * minsyms.c (find_solib_trampoline_target): Update.
9297         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9298         * coffread.c (coff_symfile_read): Update.
9299         * ada-lang.c (ada_lookup_simple_minsym)
9300         (ada_collect_symbol_completion_matches): Update.
9301
9302 2019-01-16  Tom Tromey  <tom@tromey.com>
9303
9304         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9305         type.  Remove no-argument constructor.
9306         <iterator::operator++>: Simplify.
9307         <begin>: Update.
9308         <end>: Use minimal_symbol_count.
9309
9310 2019-01-16  Tom Tromey  <tom@tromey.com>
9311
9312         * objfiles.h (struct objfile) <psymtabs>: New method.
9313         (class objfile_psymtabs): Remove.
9314         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9315         typedef.
9316         <range>: New method.
9317         (require_partial_symbols): Change return type.
9318         * psymtab.c (require_partial_symbols)
9319         (psym_expand_symtabs_matching): Update.
9320         * mdebugread.c (parse_partial_symbols): Update.
9321         * dbxread.c (dbx_end_psymtab): Update.
9322
9323 2019-01-15  Tom Tromey  <tom@tromey.com>
9324
9325         * symtab.c (lookup_objfile_from_block)
9326         (lookup_symbol_in_objfile_symtabs)
9327         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9328         (find_line_symtab, info_sources_command)
9329         (default_collect_symbol_completion_matches_break_on)
9330         (make_source_files_completion_list): Update.
9331         * symmisc.c (print_objfile_statistics, dump_objfile)
9332         (maintenance_print_symbols, maintenance_info_symtabs)
9333         (maintenance_check_symtabs, maintenance_info_line_tables):
9334         Update.
9335         * source.c (select_source_symtab)
9336         (forget_cached_source_info_for_objfile): Update.
9337         * objfiles.h (class objfile_compunits): Remove.
9338         (struct objfile) <compunits_range>: New typedef.
9339         (compunits): New method.
9340         * objfiles.c (objfile_relocate1): Update.
9341         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9342         * maint.c (count_symtabs_and_blocks): Update.
9343         * linespec.c (iterate_over_all_matching_symtabs): Update.
9344         * cp-support.c (add_symbol_overload_list_qualified): Update.
9345         * coffread.c (coff_symtab_read): Update.
9346         * ada-lang.c (add_nonlocal_symbols)
9347         (ada_collect_symbol_completion_matches)
9348         (ada_add_global_exceptions): Update.
9349
9350 2019-01-15  Tom Tromey  <tom@tromey.com>
9351
9352         * progspace.h (program_space) <objfiles_safe_range>: New
9353         typedef.
9354         <objfiles_safe>: New method.
9355         * objfiles.h (class all_objfiles_safe): Remove.
9356         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9357         * jit.c (jit_inferior_exit_hook): Update.
9358
9359 2019-01-17  Tom Tromey  <tom@tromey.com>
9360
9361         * progspace.h (program_space) <objfiles_range>: New typedef.
9362         <objfiles>: New method.
9363         <objfiles_head>: Rename from objfiles.
9364         (object_files): Update.
9365         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9366         * guile/scm-pretty-print.c
9367         (ppscm_find_pretty_printer_from_objfiles): Update.
9368         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9369         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9370         Update.
9371         * python/py-progspace.c (pspy_get_objfiles): Update.
9372         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9373         Update.
9374         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9375         (objfpy_lookup_objfile_by_build_id): Update.
9376         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9377         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9378         Update.
9379         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9380         (expand_symtab_containing_pc, lookup_objfile_from_block)
9381         (lookup_static_symbol, basic_lookup_transparent_type)
9382         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9383         (find_line_symtab, info_sources_command)
9384         (default_collect_symbol_completion_matches_break_on)
9385         (make_source_files_completion_list, find_main_name): Update.
9386         * symmisc.c (print_symbol_bcache_statistics)
9387         (print_objfile_statistics, maintenance_print_symbols)
9388         (maintenance_print_msymbols, maintenance_print_objfiles)
9389         (maintenance_info_symtabs, maintenance_check_symtabs)
9390         (maintenance_expand_symtabs, maintenance_info_line_tables):
9391         Update.
9392         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9393         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9394         (map_overlay_command, unmap_overlay_command)
9395         (simple_overlay_update, expand_symtabs_matching)
9396         (map_symbol_filenames): Update.
9397         * symfile-debug.c (set_debug_symfile): Update.
9398         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9399         Update.
9400         * source.c (select_source_symtab, forget_cached_source_info):
9401         Update.
9402         * solib.c (solib_read_symbols): Update.
9403         * solib-spu.c (append_ocl_sos): Update.
9404         * psymtab.c (maintenance_print_psymbols)
9405         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9406         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9407         * printcmd.c (info_symbol_command): Update.
9408         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9409         Update.
9410         * objfiles.h (class all_objfiles): Remove.
9411         * objfiles.c (have_partial_symbols, have_full_symbols)
9412         (have_minimal_symbols, qsort_cmp, update_section_map)
9413         (shared_objfile_contains_address_p)
9414         (default_iterate_over_objfiles_in_search_order): Update.
9415         * objc-lang.c (info_selectors_command, info_classes_command)
9416         (find_methods): Update.
9417         * minsyms.c (find_solib_trampoline_target): Update.
9418         * maint.c (maintenance_info_sections)
9419         (maintenance_translate_address, count_symtabs_and_blocks):
9420         Update.
9421         * main.c (captured_main_1): Update.
9422         * linux-thread-db.c (try_thread_db_load_from_pdir)
9423         (has_libpthread): Update.
9424         * linespec.c (iterate_over_all_matching_symtabs)
9425         (search_minsyms_for_name): Update.
9426         * jit.c (jit_find_objf_with_entry_addr): Update.
9427         * hppa-tdep.c (find_unwind_entry)
9428         (hppa_lookup_stub_minimal_symbol): Update.
9429         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9430         Update.
9431         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9432         (elf_gnu_ifunc_resolve_by_got): Update.
9433         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9434         * dwarf-index-write.c (save_gdb_index_command): Update.
9435         * cp-support.c (add_symbol_overload_list_qualified): Update.
9436         * breakpoint.c (create_overlay_event_breakpoint)
9437         (create_longjmp_master_breakpoint)
9438         (create_std_terminate_master_breakpoint)
9439         (create_exception_master_breakpoint): Update.
9440         * blockframe.c (find_pc_partial_function): Update.
9441         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9442         (ada_collect_symbol_completion_matches)
9443         (ada_add_global_exceptions): Update.
9444
9445 2019-01-17  Tom Tromey  <tom@tromey.com>
9446
9447         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9448         declare VEC.
9449         (solib_target_parse_libraries): Change return type.
9450         (library_list_start_segment, library_list_start_section)
9451         (library_list_end_library, library_list_start_library); Update.
9452         (solib_target_free_library_list): Remove.
9453         (solib_target_parse_libraries): Remove cleanup.  Change return
9454         type.
9455         (solib_target_current_sos): Update.
9456
9457 2019-01-17  Tom Tromey  <tromey@bapiya>
9458
9459         * valprint.c: Replace "the the" with "the".
9460         * symtab.c: Replace "the the" with "the".
9461         * solib.c: Replace "the the" with "the".
9462         * solib-dsbt.c: Replace "the the" with "the".
9463         * linespec.c: Replace "the the" with "the".
9464         * dwarf2loc.h: Replace "the the" with "the".
9465         * amd64-windows-tdep.c: Replace "the the" with "the".
9466         * aarch64-tdep.c: Replace "the the" with "the".
9467
9468 2019-01-16  Keith Seitz  <keiths@redhat.com>
9469
9470         PR gdb/23773
9471         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9472         <builder>: Rename to ..
9473         <m_builder>: ... this and make private.
9474         (dwarf2_cu::get_builder): New method.  Change all users of
9475         `builder' to use this method.
9476         (dwarf2_start_symtab): Move to ...
9477         (dwarf2_cu::start_symtab): ... here.  Update all callers
9478         (setup_type_unit_groups): Move to ...
9479         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9480         callers.
9481         (dwarf2_cu::reset_builder): New method.
9482         (process_full_compunit, process_full_type_unit): Use
9483         dwarf2_cu::reset_builder.
9484         (follow_die_offset): Record the ancestor CU if it is different
9485         from the followed DIE's CU.
9486         (follow_die_sig_1): Likewise.
9487
9488 2019-01-15  Tom Tromey  <tom@tromey.com>
9489
9490         * remote.c (class remote_state) <buf>: Now a char_vector.
9491         <buf_size>: Remove.
9492         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9493         parameter.
9494         (remote_target::getpkt_or_notif_sane_1)
9495         (remote_target::getpkt_sane)
9496         (remote_target::getpkt_or_notif_sane): Likewise.
9497         (class remote_target) <putpkt>: New overload.
9498         (remote_target::read_frame): Change type of "buf_p".  Remove
9499         sizeof_p parameter.
9500         (packet_ok): New overload.
9501         (packet_check_result): New overload.
9502         Update all uses.
9503
9504 2019-01-14  Tom Tromey  <tom@tromey.com>
9505
9506         * remote-notif.c (handle_notification, remote_notif_ack)
9507         (remote_notif_parse): Make "buf" const.
9508         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9509         const.
9510         (remote_notif_parse, remote_notif_ack, handle_notification):
9511         Likewise.
9512         * remote.c (remote_notif_stop_parse): Make "buf" const.
9513         (remote_target::remote_parse_stop_reply): Make "buf" const.
9514         (remote_notif_stop_ack): Make "buf" const.
9515
9516 2019-01-14  Tom Tromey  <tom@tromey.com>
9517
9518         * remote.c (remote_console_output): Make parameter const.
9519
9520 2019-01-14  Tom Tromey  <tom@tromey.com>
9521
9522         * target-debug.h (target_debug_print_signals): Constify.
9523         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9524         * procfs.c (procfs_target::pass_signals): Update.
9525         * linux-nat.c (linux_nat_target::pass_signals): Update.
9526         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9527         * target-delegates.c: Rebuild.
9528         * remote.c (remote_target::program_signals): Update.
9529         (remote_target::pass_signals): Update.
9530         * target.c (target_pass_signals): Constify argument.
9531         (target_program_signals): Likewise.
9532         * target.h (struct target_ops) <pass_signals, program_signals>:
9533         Constify argument.
9534         (target_pass_signals, target_program_signals): Constify argument.
9535
9536 2019-01-14  Tom Tromey  <tom@tromey.com>
9537
9538         PR tui/28819:
9539         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9540
9541 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9542
9543         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9544         field.
9545         * rs6000-tdep.c: Include reggroups.h.
9546         (IS_V_ALIAS_PSEUDOREG): Define.
9547         (rs6000_register_name): Return names for the "vX" aliases.
9548         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9549         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9550         aliases.  Call default_register_reggroup_p for all other
9551         pseudo-registers.
9552         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9553         New functions.
9554         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9555         Handle "vX" aliases.
9556         (v_alias_pseudo_register_collect): New function.
9557         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9558         (rs6000_gdbarch_init): Initialize "vX" aliases as
9559         pseudo-registers.  Restore registration of
9560         rs6000_pseudo_register_reggroup_p with
9561         set_tdesc_pseudo_register_reggroup_p.
9562
9563 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9564
9565         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9566         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9567         set_gdbarch_num_pseudo_regs.
9568
9569 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9570
9571         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9572         Remove arg prefixname, add do_set and do_show.
9573         Add member functions set_list and show_list.
9574         * cli/cli-style.c (class cli_style_option): Update accordingly.
9575         (style_set_list): Move to file scope.
9576         (style_show_list): Likewise.
9577         (set_style): Call help_list.
9578         (show_style): Call cmd_show_list.
9579         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9580         Update to use the new macro.
9581
9582 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9583
9584         * ada-lang.c (_initialize_ada_language): Expand the help text
9585         for the "catch exception" command.
9586
9587 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9588
9589         * symtab.c (matching_obj_sections): Initialize obj,
9590         declare it closer to its usage.
9591
9592 2019-01-10  Tom Tromey  <tom@tromey.com>
9593
9594         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9595         (basic_inf_threads_range): Remove.
9596         (inf_threads_range, inf_non_exited_threads_range)
9597         (safe_inf_threads_range): Use next_adapter.
9598
9599 2019-01-10  Keith Seitz  <keiths@redhat.com>
9600
9601         PR gdb/23712
9602         PR symtab/23010
9603         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9604         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9605
9606 2019-01-10  Keith Seitz  <keiths@redhat.com>
9607
9608         PR gdb/23712
9609         PR symtab/23010
9610         * dictionary.c (pending_to_vector): Remove.
9611         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9612         Remove _1 suffix, replacing functions of the same name.  Update
9613         all callers.
9614         (dict_create_hashed, dict_create_hashed_expandable)
9615         (dict_create_linear, dict_create_linear_expandable, dict_free)
9616         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9617         Make functions static.
9618
9619 2019-01-10  Keith Seitz  <keiths@redhat.com>
9620
9621         PR gdb/23712
9622         PR symtab/23010
9623         * dictionary.h (struct dictionary): Replace declaration with
9624         multidictionary.
9625         (dict_create_hashed, dict_create_hashed_expandable)
9626         (dict_create_linear, dict_create_linear_expandable)
9627         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9628         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9629         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9630         taking multidictionary argument.
9631         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9632         * block.h (struct block) <dict>: Change to multidictionary
9633         and rename `multidict'.
9634         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9635         symmisc.c: Update all dictionary references to multidictionary.
9636
9637 2019-01-10  Keith Seitz  <keiths@redhat.com>
9638
9639         PR gdb/23712
9640         PR symtab/23010
9641         * dictionary.c: Include unordered_map.
9642         (pending_to_vector): New function.
9643         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9644         Rewrite the non-"_1" functions to take vector instead
9645         of linked list.
9646         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9647         "new" _1 versions of the same name.
9648         (multidictionary): Define.
9649         (std::hash<enum language): New definition.
9650         (collate_pending_symbols_by_language, mdict_create_hashed)
9651         (mdict_create_hashed_expandable, mdict_create_linear)
9652         (mdict_create_linear_expandable, mdict_free)
9653         (find_language_dictionary, create_new_language_dictionary)
9654         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9655         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9656         (mdict_size, mdict_empty): New functions.
9657         * dictionary.h (mdict_iterator): Define.
9658
9659 2019-01-10  Pedro Alves  <palves@redhat.com>
9660
9661         * breakpoint.c (read_uploaded_action)
9662         (create_tracepoint_from_upload): Adjust to use
9663         gdb::unique_xmalloc_ptr.
9664         * ctf.c (ctf_write_uploaded_tp):
9665         (SET_ARRAY_FIELD): Use emplace_back.
9666         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9667         * tracefile-tfile.c (tfile_write_uploaded_tp):
9668         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9669         gdb::unique_xmalloc_ptr.
9670         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9671         at_string, cond_string, cmd_strings>: Replace char pointers
9672         with gdb::unique_xmalloc_ptr.
9673
9674 2019-01-10  Pedro Alves  <palves@redhat.com>
9675
9676         * solib-target.c (library_list_start_library): Don't xstrdup name.
9677
9678 2019-01-10  Pedro Alves  <palves@redhat.com>
9679
9680         * mdebugread.c (parse_partial_symbols): Use
9681         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9682
9683 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9684
9685         * linux-fork.c (scoped_switch_fork_info)
9686         <~scoped_switch_fork_info>: Fix incorrect variable name.
9687
9688 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9689
9690         * linux-fork.c (scoped_switch_fork_info)
9691         <scoped_switch_fork_info>: Make explicit.
9692         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9693
9694 2019-01-10  Tom Tromey  <tom@tromey.com>
9695
9696         * objfiles.h (objfile::reset_psymtabs): Update.
9697         * objfiles.c (objfile::objfile): Update.
9698         * psymtab.h (psymtab_storage::obstack): Update.
9699         (psymtab_storage::m_obstack): Use gdb::optional.
9700         (class psymtab_storage): Update comment.  Remove objfile
9701         parameter.
9702         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9703
9704 2019-01-10  Tom Tromey  <tom@tromey.com>
9705
9706         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9707         <free_psymtabs>: Now private.
9708         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9709         (allocate_psymtab): Use new method.
9710
9711 2019-01-10  Tom Tromey  <tom@tromey.com>
9712
9713         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9714         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9715         * mdebugread.c (parse_partial_symbols): Use
9716         allocate_dependencies.
9717         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9718         allocate_dependencies.
9719         (process_psymtab_comp_unit_reader)
9720         (build_type_psymtab_dependencies): Likewise.
9721         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9722
9723 2019-01-10  Tom Tromey  <tom@tromey.com>
9724
9725         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9726         PSYMBOL_SET_LANGUAGE.
9727         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9728
9729 2019-01-10  Tom Tromey  <tom@tromey.com>
9730
9731         * psymtab.h (psymtab_storage::obstack): New method.
9732         <m_obstack>: Rename from obstack; now private.
9733         * psymtab.c (psymtab_storage): Update.
9734         * dwarf2read.c (create_addrmap_from_index)
9735         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9736         Update.
9737
9738 2019-01-10  Tom Tromey  <tom@tromey.com>
9739
9740         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9741         * objfiles.h (objfile::reset_psymtabs): New method.
9742
9743 2019-01-10  Tom Tromey  <tom@tromey.com>
9744
9745         * symmisc.c (print_symbol_bcache_statistics): Update.
9746         (print_objfile_statistics): Update.
9747         * symfile.c (reread_symbols): Update.
9748         * psymtab.h (class psymtab_storage): New.
9749         * psymtab.c (psymtab_storage): New constructor.
9750         (~psymtab_storage): New destructor.
9751         (require_partial_symbols): Update.
9752         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9753         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9754         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9755         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9756         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9757         (start_psymtab_common, end_psymtab_common)
9758         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9759         (allocate_psymtab): Update.
9760         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9761         Update.
9762         (dump_psymtab_addrmap, maintenance_print_psymbols)
9763         (maintenance_check_psymtabs): Update.
9764         (class objfile_psymtabs): Move to objfiles.h.
9765         * psympriv.h (discard_psymtab): Now inline.
9766         (psymtab_discarder::psymtab_discarder): Update.
9767         (psymtab_discarder::~psymtab_discarder): Update.
9768         (ALL_OBJFILE_PSYMTABS): Rewrite.
9769         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9770         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9771         Remove fields.
9772         <partial_symtabs>: New field.
9773         (class objfile_psymtabs): Move from psymtab.h.  Update.
9774         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9775         psymbol_cache.
9776         (objfile::~objfile): Don't destroy psymbol_cache.
9777         * mdebugread.c (parse_partial_symbols): Update.
9778         * dwarf2read.c (create_addrmap_from_index)
9779         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9780         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9781         (add_partial_subprogram, dwarf2_ranges_read): Update.
9782         * dwarf-index-write.c (write_address_map)
9783         (write_one_signatured_type, recursively_write_psymbols)
9784         (class debug_names, class debug_names, write_psymtabs_to_index):
9785         Update.
9786
9787 2019-01-10  Tom Tromey  <tom@tromey.com>
9788
9789         * symtab.h (SYMBOL_SET_NAMES): Update.
9790         (symbol_set_names): Update.
9791         (MSYMBOL_SET_NAMES): Update.
9792         * symtab.c (symbol_set_names): Change argument to be an
9793         objfile_per_bfd_storage.
9794         * psymtab.c (add_psymbol_to_bcache): Update.
9795         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9796
9797 2019-01-10  Tom Tromey  <tom@tromey.com>
9798
9799         * symtab.c (create_demangled_names_hash): Change argument to be an
9800         objfile_per_bfd_storage.
9801         (symbol_set_names): Update.
9802
9803 2019-01-10  Tom Tromey  <tom@tromey.com>
9804
9805         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9806         init_psymbol_list.
9807         * psymtab.c (init_psymbol_list): Do nothing if already called.
9808         * psympriv.h (init_psymbol_list): Add comment.
9809         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9810         init_psymbol_list.
9811         * dbxread.c (dbx_symfile_read): Unconditionally call
9812         init_psymbol_list.
9813
9814 2019-01-10  Tom Tromey  <tom@tromey.com>
9815
9816         * xcoffread.c (scan_xcoff_symtab): Update.
9817         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9818         "where".
9819         * mdebugread.c (parse_partial_symbols)
9820         (handle_psymbol_enumerators): Update.
9821         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9822         * dbxread.c (read_dbx_symtab): Update.
9823         * psympriv.h (psymbol_placement): New enum.
9824         (add_psymbol_to_list): Update.
9825
9826 2019-01-10  Tom Tromey  <tom@tromey.com>
9827
9828         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9829         static_psymbols parameters.
9830         (scan_xcoff_symtab): Update.
9831         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9832         static_psymbols parameters.
9833         * psympriv.h (start_psymtab_common): Update.
9834         * mdebugread.c (parse_partial_symbols): Update.
9835         * dwarf2read.c (create_partial_symtab): Update.
9836         * dbxread.c (read_dbx_symtab): Update.
9837         (start_psymtab): Remove global_psymbols and static_psymbols
9838         parameters.
9839
9840 2019-01-10  Tom Tromey  <tom@tromey.com>
9841
9842         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9843         * psymtab.c (allocate_psymtab): Add comment.
9844         * psympriv.h (allocate_psymtab): Add comment.
9845         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9846         initializations.
9847         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9848
9849 2019-01-10  Tom Tromey  <tom@tromey.com>
9850
9851         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9852         Don't declare.
9853         * mipsread.c: Include mdebugread.h.
9854         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9855         Declare.
9856         * elfread.c: Include mdebugread.h.
9857
9858 2019-01-09  Tom Tromey  <tom@tromey.com>
9859
9860         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9861         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9862         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9863         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9864         (psym_lookup_symbol, psym_find_last_source_symtab)
9865         (psym_forget_cached_source_info, psym_print_stats)
9866         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9867         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9868         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9869         (psym_find_compunit_symtab_by_address)
9870         (maintenance_print_psymbols, maintenance_info_psymtabs)
9871         (maintenance_check_psymtabs): Use ranged for.
9872         * psymtab.h (class objfile_psymtabs): New.
9873         (require_partial_symbols): Return objfile_psymtabs.
9874         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9875
9876 2019-01-09  Tom Tromey  <tom@tromey.com>
9877
9878         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9879         (find_pc_mapped_section, list_overlays_command)
9880         (map_overlay_command, unmap_overlay_command)
9881         (simple_overlay_update): Use all_objfiles.
9882         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9883         * printcmd.c (info_symbol_command): Use all_objfiles.
9884         * objfiles.h (ALL_OBJSECTIONS): Remove.
9885         * maint.c (maintenance_translate_address): Use all_objfiles.
9886         * gcore.c (gcore_create_callback): Use all_objfiles.
9887         (objfile_find_memory_regions): Likewise.
9888
9889 2019-01-09  Tom Tromey  <tom@tromey.com>
9890
9891         * symtab.c (find_line_symtab, info_sources_command)
9892         (make_source_files_completion_list): Use objfile_compunits.
9893         * source.c (select_source_symtab): Use objfile_compunits.
9894         * objfiles.h (struct objfile): Update comment.
9895         (ALL_OBJFILES): Remove.
9896         (ALL_FILETABS): Remove.
9897         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9898         objfile_compunits.
9899
9900 2019-01-09  Tom Tromey  <tom@tromey.com>
9901
9902         * symmisc.c (print_objfile_statistics, dump_objfile)
9903         (maintenance_print_symbols): Use compunit_filetabs.
9904         * source.c (forget_cached_source_info_for_objfile): Use
9905         compunit_filetabs.
9906         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9907         (ALL_FILETABS): Use compunit_filetabs.
9908         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9909         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9910
9911 2019-01-09  Tom Tromey  <tom@tromey.com>
9912
9913         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9914         (compunit_filetabs): New.
9915         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9916         compunit_filetabs.
9917         (info_sources_command, make_source_files_completion_list): Remove
9918         declaration.
9919         * symmisc.c (print_objfile_statistics, dump_objfile)
9920         (maintenance_print_symbols): Remove declaration.
9921         (maintenance_info_symtabs): Use compunit_filetabs.
9922         (maintenance_info_line_tables): Likewise.
9923         * source.c (select_source_symtab): Change local variable name.
9924         (forget_cached_source_info_for_objfile): Remove declaration.
9925         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9926         * objfiles.c (objfile_relocate1): Remove declaration.
9927         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9928         declaration.
9929         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9930         * coffread.c (coff_symtab_read): Remove declaration.
9931         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9932         compunit_filetabs.
9933
9934 2019-01-09  Tom Tromey  <tom@tromey.com>
9935
9936         * symtab.c (lookup_objfile_from_block)
9937         (find_pc_sect_compunit_symtab, search_symbols)
9938         (default_collect_symbol_completion_matches_break_on): Use
9939         objfile_compunits.
9940         * objfiles.h (ALL_COMPUNITS): Remove.
9941         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9942         * cp-support.c (add_symbol_overload_list_qualified): Use
9943         objfile_compunits.
9944         * ada-lang.c (ada_collect_symbol_completion_matches)
9945         (ada_add_global_exceptions): Use objfile_compunits.
9946
9947 2019-01-09  Tom Tromey  <tom@tromey.com>
9948
9949         * source.c (select_source_symtab)
9950         (forget_cached_source_info_for_objfile): Remove declaration.
9951         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9952         declaration.
9953         * maint.c (count_symtabs_and_blocks): Remove declaration.
9954         * cp-support.c (add_symbol_overload_list_qualified): Remove
9955         declaration.
9956         * coffread.c (coff_symtab_read): Remove declaration.
9957         * symtab.c (lookup_symbol_in_objfile_symtabs)
9958         (basic_lookup_transparent_type_1): Use objfile_compunits.
9959         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9960         (info_sources_command, search_symbols)
9961         (default_collect_symbol_completion_matches_break_on)
9962         (make_source_files_completion_list): Remove declaration.
9963         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9964         (ada_collect_symbol_completion_matches)
9965         (ada_add_global_exceptions): Remove declaration.
9966         * linespec.c (iterate_over_all_matching_symtabs): Use
9967         objfile_compunits.
9968         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9969         (class objfile_compunits): New.
9970         (ALL_COMPUNITS): Use objfile_compunits.
9971         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9972         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9973         objfile_compunits.
9974         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9975
9976 2019-01-09  Tom Tromey  <tom@tromey.com>
9977
9978         * symtab.c (search_symbols)
9979         (default_collect_symbol_completion_matches_break_on): Use
9980         objfile_msymbols.
9981         * ada-lang.c (ada_lookup_simple_minsym)
9982         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9983         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9984         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9985         objfile_msymbols.
9986         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9987         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9988         * objc-lang.c (find_methods): Use objfile_msymbols.
9989         (info_selectors_command, info_classes_command): Likewise.
9990         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9991         * objfiles.h (class objfile_msymbols): New.
9992         (ALL_OBJFILE_MSYMBOLS): Remove.
9993         (ALL_MSYMBOLS): Remove.
9994
9995 2019-01-09  Tom Tromey  <tom@tromey.com>
9996
9997         * common/next-iterator.h (next_adapter): Add Iterator template
9998         parameter.
9999         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10000         (class all_objfiles_safe): New.
10001         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10002         * objfiles.c (put_objfile_before): Update comment.
10003         (add_separate_debug_objfile): Likewise.
10004         (free_all_objfiles): Use all_objfiles_safe.
10005         (objfile_purge_solibs): Likewise.
10006
10007 2019-01-09  Tom Tromey  <tom@tromey.com>
10008
10009         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10010         (expand_symtab_containing_pc, lookup_static_symbol)
10011         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10012         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10013         all_objfiles.
10014         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10015         * breakpoint.c (create_overlay_event_breakpoint)
10016         (create_longjmp_master_breakpoint)
10017         (create_std_terminate_master_breakpoint)
10018         (create_exception_master_breakpoint): Use all_objfiles.
10019         * linux-thread-db.c (try_thread_db_load_from_pdir)
10020         (has_libpthread): Use all_objfiles.
10021         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10022         * linespec.c (iterate_over_all_matching_symtabs)
10023         (search_minsyms_for_name): Use all_objfiles.
10024         * maint.c (maintenance_info_sections): Use all_objfiles.
10025         * main.c (captured_main_1): Use all_objfiles.
10026         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10027         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10028         * guile/scm-pretty-print.c
10029         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10030         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10031         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10032         (maintenance_print_msymbols): Use all_objfiles.
10033         * source.c (select_source_symtab): Use all_objfiles.
10034         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10035         * symfile.c (remove_symbol_file_command)
10036         (expand_symtabs_matching, map_symbol_filenames): Use
10037         all_objfiles.
10038         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10039         all_objfiles.
10040         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10041         * objc-lang.c (find_methods): Use all_objfiles.
10042         * objfiles.c (have_partial_symbols, have_full_symbols)
10043         (have_minimal_symbols, qsort_cmp)
10044         (default_iterate_over_objfiles_in_search_order): Use
10045         all_objfiles.
10046         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10047         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10048         (maintenance_check_psymtabs): Use all_objfiles.
10049         (ALL_PSYMTABS): Remove.
10050         * compile/compile-object-run.c (do_module_cleanup): Use
10051         all_objfiles.
10052         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10053         * cp-support.c (add_symbol_overload_list_qualified): Use
10054         all_objfiles.
10055         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10056         Use all_objfiles.
10057         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10058         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10059         all_objfiles.
10060         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10061         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10062         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10063         Uses all_objfiles.
10064         * solib.c (solib_read_symbols): Use all_objfiles
10065
10066 2019-01-09  Tom Tromey  <tom@tromey.com>
10067
10068         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10069         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10070         all_objfiles.
10071         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10072         * symmisc.c (print_symbol_bcache_statistics)
10073         (print_objfile_statistics, maintenance_print_objfiles)
10074         (maintenance_info_symtabs, maintenance_check_symtabs)
10075         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10076         all_objfiles.
10077         * source.c (forget_cached_source_info): Use all_objfiles.
10078         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10079         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10080         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10081         * objfiles.c (update_section_map): Use all_objfiles.
10082         (shared_objfile_contains_address_p): Likewise.
10083         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10084         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10085
10086 2019-01-09  Tom Tromey  <tom@tromey.com>
10087
10088         * common/next-iterator.h: New file.
10089         * objfiles.h (class all_objfiles): New.
10090         (struct objfile_iterator): New.
10091
10092 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10093
10094         * NEWS: Move the description of the changed "frame", "select-frame",
10095          and "info frame" commands to the Changed commands section.
10096
10097 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10098
10099         * gdbtypes.c (check_stub_method_group): Remove handling of old
10100         mangling schemes.
10101         * linespec.c (find_methods): Likewise.
10102         * stabsread.c (read_member_functions): Likewise.
10103         * valops.c (search_struct_method): Likewise.
10104         (value_struct_elt_for_reference): Likewise.
10105         * NEWS: Mention this change.
10106
10107 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10108
10109         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10110         print_source_lines.
10111         * source.c (print_source_lines_base): Update line number check.
10112         (print_source_lines): New function.
10113         (source_lines_range::source_lines_range): New function.
10114         * source.h (class source_lines_range): New class.
10115         (print_source_lines): New declaration.
10116
10117 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10118
10119         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10120
10121 2019-01-08  Tom Tromey  <tom@tromey.com>
10122             Simon Marchi  <simon.marchi@ericsson.com>
10123
10124         PR gdb/24060
10125         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10126         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10127         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10128         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10129         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10130         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10131
10132 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10133
10134         * source.c (select_source_symtab): Move header comment to
10135         declaration in source.h.
10136         (forget_cached_source_info_for_objfile): Likewise.
10137         (forget_cached_source_info): Likewise.
10138         (identify_source_line): Likewise.
10139         * source.h (identify_source_line): Move declaration from symtab.h
10140         and add comment from source.c
10141         (print_source_lines): Likewise.
10142         (forget_cached_source_info_for_objfile): Likewise.
10143         (forget_cached_source_info): Likewise.
10144         (select_source_symtab): Likewise.
10145         (enum print_source_lines_flag): Move definition from symtab.h.
10146         * symtab.h (identify_source_line): Move declaration to source.h.
10147         (print_source_lines): Likewise.
10148         (forget_cached_source_info_for_objfile): Likewise.
10149         (forget_cached_source_info): Likewise.
10150         (select_source_symtab): Likewise.
10151         (enum print_source_lines_flag): Move definition to source.h.
10152         * tui/tui-hooks.c: Add 'source.h' include.
10153
10154 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10155
10156         * source.c (print_source_lines_base): Handle requests to print
10157         reverse line number sequences, and guard against empty lines
10158         string.
10159
10160 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10161
10162         * source.c (print_source_lines_base): Fix skip of '\r' if next
10163         character is '\n'.
10164
10165 2019-01-06  Tom Tromey  <tom@tromey.com>
10166
10167         * c-exp.y (struct c_parse_state) <macro_original_text,
10168         expansion_obstack>: New member.
10169         (macro_original_text, expansion_obstack): Remove globals.
10170         (scan_macro_expansion, scanning_macro_expansion)
10171         (finished_macro_expansion): Update.
10172         (scan_macro_cleanup): Remove.
10173         (yylex, c_parse): Update.
10174
10175 2019-01-06  Tom Tromey  <tom@tromey.com>
10176
10177         * c-exp.y (struct c_parse_state) <strings>: New member.
10178         (operator_stoken): Update.
10179
10180 2019-01-06  Tom Tromey  <tom@tromey.com>
10181
10182         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10183         (union type_stack_elt) <typelist_val>: Now a pointer to
10184         std::vector.
10185         (type_stack_cleanup): Don't declare.
10186         (push_typelist): Update.
10187         * parse.c (pop_typelist): Return a std::vector.
10188         (push_typelist): Take a std::vector.
10189         (follow_types): Update.  Do not free args.
10190         (type_stack_cleanup): Remove.
10191         * c-exp.y (struct c_parse_state): New.
10192         (cpstate): New global.
10193         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10194         (nonempty_typelist): Update.
10195         (func_mod): Create a new vector.
10196         (c_parse): Create a c_parse_state.
10197         (check_parameter_typelist): Do not delete params.
10198         (function_method): Update.  Do not delete type_list.
10199
10200 2019-01-06  Tom Tromey  <tom@tromey.com>
10201
10202         PR gdb/28155:
10203         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10204         check_typedef.
10205         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10206         (print_return_value): Likewise.
10207
10208 2019-01-05  Tom Tromey  <tom@tromey.com>
10209
10210         * contrib/cleanup_check.py: Remove.
10211         * contrib/gcc-with-excheck: Remove.
10212         * contrib/exsummary.py: Remove.
10213         * contrib/excheck.py: Remove.
10214
10215 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10216
10217         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10218         NULL. Initialize tpprev to NULL instead of assigning it
10219         to NULL on the next statement.
10220         * windows-nat.c (windows_delete_thread): Remove check for
10221         main_thread_id before printing thread exit notifications.
10222         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10223         Remove thread ID check against main_thread_id.
10224         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10225         windows_delete_thread.
10226         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10227
10228 2019-01-04  Tom Tromey  <tom@tromey.com>
10229
10230         * compile/compile.c (_initialize_compile): Use upper case for
10231         metasyntactic variables.
10232         * symmisc.c (_initialize_symmisc): Use upper case for
10233         metasyntactic variables.
10234         * psymtab.c (_initialize_psymtab): Use upper case for
10235         metasyntactic variables.
10236         * demangle.c (demangle_command): Use upper case for metasyntactic
10237         variables.
10238         (_initialize_demangler): Likewise.
10239         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10240         variables.
10241
10242 2019-01-03  Tom Tromey  <tom@tromey.com>
10243
10244         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10245
10246 2019-01-03  Tom Tromey  <tom@tromey.com>
10247
10248         * python/py-symtab.c (salpy_str): Update.
10249         (struct salpy_sal_object) <symtab>: Now a PyObject.
10250         (salpy_dealloc): Update.
10251         (del_objfile_sal): Use gdbpy_ref.
10252
10253 2019-01-03  Tom Tromey  <tom@tromey.com>
10254
10255         * python/py-type.c (convert_field): Use new_reference.  Return
10256         gdbpy_ref.
10257         (make_fielditem): Return gdbpy_ref.
10258         (typy_fields): Update.
10259         (typy_getitem): Update.
10260         (field_name): Return gdbpy_ref.  Use new_reference.
10261         (typy_iterator_iternext): Update.
10262
10263 2019-01-03  Tom Tromey  <tom@tromey.com>
10264
10265         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10266
10267 2019-01-03  Tom Tromey  <tom@tromey.com>
10268
10269         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10270         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10271         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10272         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10273         (pspy_set_type_printers): Likewise.
10274         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10275         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10276         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10277         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10278         (objfpy_set_type_printers): Likewise.
10279
10280 2019-01-03  Tom Tromey  <tom@tromey.com>
10281
10282         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10283         (gdbpy_print_stack): Use gdbpy_err_fetch.
10284         * python/python-internal.h (class gdbpy_err_fetch): New class.
10285         (class gdbpy_enter) <m_error_type, m_error_value,
10286         m_error_traceback>: Remove.
10287         <m_error>: New member.
10288         (gdbpy_exception_to_string): Don't declare.
10289         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10290         * python/py-value.c (convert_value_from_python): Use
10291         gdbpy_err_fetch.
10292         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10293         gdbpy_exception_to_string.
10294         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10295         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10296         gdbpy_err_fetch.
10297
10298 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10299
10300         * linux-nat.c (delete_lwp_cleanup): Delete.
10301         (struct lwp_deleter): New struct.
10302         (lwp_info_up): New typedef.
10303         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10304         lwp_info_up.
10305
10306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10307
10308         * linux-fork.c (class scoped_switch_fork_info): New class.
10309         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10310
10311 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10312
10313         * valops.c (find_overload_match): Remove use of null_cleanup, and
10314         calls to do_cleanups.
10315
10316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10317
10318         * compile/compile-cplus-types.c
10319         (compile_cplus_instance::decl_name): Handle changes to
10320         cp_func_name.
10321         * cp-support.c (cp_func_name): Update header comment, update
10322         return type.
10323         * cp-support.h (cp_func_name): Update return type in declaration.
10324         * valops.c (find_overload_match): Move temp_func local to top
10325         level of function and change its type.  Use temp_func to hold and
10326         delete temporary string obtained from cp_func_name.
10327
10328 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10331         gdb::char_vector, remove cleanup, and update uses of `msg`.
10332
10333 2019-01-03  Jim Wilson  <jimw@sifive.com>
10334
10335         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10336
10337 2019-01-02  Tom Tromey  <tom@tromey.com>
10338
10339         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10340         (tdesc_parse_xml): Remove cleanups.
10341         * target-descriptions.h (make_cleanup_free_target_description):
10342         Don't declare.
10343         (target_desc_deleter): New struct.
10344         (target_desc_up): New typedef.
10345         * target-descriptions.c (target_desc_deleter::operator()): Rename
10346         from free_target_description.
10347         (make_cleanup_free_target_description): Remove.
10348
10349 2019-01-02  Tom Tromey  <tom@tromey.com>
10350
10351         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10352         constructor, destructor.
10353         (linespec_parser): Remove typedef.
10354         (~linespec_parser): Rename from linespec_parser_delete.
10355         (linespec_lex_to_end, linespec_complete_label)
10356         (linespec_complete): Update.
10357         (decode_line_full): Remove cleanups.
10358         (decode_line_1): Update.
10359
10360 2019-01-02  Tom Tromey  <tom@tromey.com>
10361
10362         * python/python-internal.h (inferior_to_inferior_object): Change
10363         return type.
10364         * python/py-exitedevent.c (create_exited_event_object): Update.
10365         * python/py-inferior.c (inferior_to_inferior_object): Return
10366         gdbpy_ref.
10367         (python_new_inferior, python_inferior_deleted)
10368         (thread_to_thread_object, delete_thread_object)
10369         (build_inferior_list, gdbpy_selected_inferior): Update.
10370         * python/py-infthread.c (create_thread_object): Update.  Also fail
10371         if inferior_to_inferior_object fails.
10372
10373 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10374
10375         * inferior.h (class inferior) <displaced_step_state>: New field.
10376         * infrun.h (struct displaced_step_state): Move here from
10377         infrun.c.  Initialize fields, add constructor.
10378         <inf>: Remove field.
10379         <reset>: New method.
10380         * infrun.c (struct displaced_step_inferior_state): Move to
10381         infrun.h.
10382         (displaced_step_inferior_states): Remove.
10383         (get_displaced_stepping_state): Adust.
10384         (displaced_step_in_progress_any_inferior): Adjust.
10385         (displaced_step_in_progress_thread): Adjust.
10386         (displaced_step_in_progress): Adjust.
10387         (add_displaced_stepping_state): Remove.
10388         (get_displaced_step_closure_by_addr): Adjust.
10389         (remove_displaced_stepping_state): Remove.
10390         (infrun_inferior_exit): Call displaced_step_state.reset.
10391         (use_displaced_stepping): Don't check for NULL.
10392         (displaced_step_prepare_throw): Call
10393         get_displaced_stepping_state.
10394         (displaced_step_fixup): Don't check for NULL.
10395         (prepare_for_detach): Don't check for NULL.
10396
10397 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10398
10399         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10400          in case of call that did not complete.
10401
10402 2019-01-02  Andrey Utkin  <autkin@undo.io>
10403
10404         * symfile.c (find_separate_debug_file): Fix search of debug files for
10405         remote debuggee.
10406
10407 2019-01-02  Tom Tromey  <tom@tromey.com>
10408
10409         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10410         indentation.
10411         * python/py-frame.c (frapy_older): Remove cast.
10412         (frapy_newer): Likewise.
10413         * python/py-breakpoint.c (local_setattro): Remove cast.
10414         * python/py-arch.c (archpy_name): Remove local variable.
10415         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10416
10417 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10418
10419         * unittests/basic_string_view/element_access/char/empty.cc:
10420         Fix year range in copyright header.
10421
10422 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10423
10424         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10425         Delete.
10426         <operator==>: Update with for removed field.
10427         <hash>: Likewise.
10428         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10429         <isa_features>: ...this.
10430         <abi_features>: New field.
10431         (riscv_isa_flen): Update comment.
10432         (riscv_abi_xlen): New declaration.
10433         (riscv_abi_flen): New declaration.
10434         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10435         isa_features.
10436         (riscv_abi_xlen): New function.
10437         (riscv_isa_flen): Update to get answer from isa_features.
10438         (riscv_abi_flen): New function.
10439         (riscv_has_fp_abi): Update to get answer from abi_features.
10440         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10441         xlen and flen.
10442         (riscv_call_info) <xlen, flen>: Update comment.
10443         (riscv_call_arg_struct): Remove invalid assertions
10444         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10445         is removed.
10446         (riscv_gdbarch_init): Gather isa features and abi features
10447         separately, ensure both match on the gdbarch when reusing an old
10448         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10449         a target with 64-bit float hardware.
10450
10451 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10452
10453         * source.c (search_command_helper): Stop reverse search
10454         when line 1 has been searched.
10455
10456 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10457
10458         * record-full.c (record_full_base_target::close): Rewrite
10459         record_full_core_buf_list free logic.
10460
10461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10462
10463         * break-catch-syscall.c (print_one_catch_syscall): xfree
10464         the last text.
10465
10466 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10467
10468         * top.c (print_gdb_version): Update Copyright year in version
10469         message.
10470
10471 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10472
10473         Update copyright year range in all GDB files.
10474
10475 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10476
10477         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10478
10479 For older changes see ChangeLog-2018.
10480 \f
10481 Local Variables:
10482 mode: change-log
10483 left-margin: 8
10484 fill-column: 74
10485 version-control: never
10486 coding: utf-8
10487 End:
10488